[ChangeLog]
[bpt/emacs.git] / src / ChangeLog
CommitLineData
df52aeb9 12011-10-02 Paul Eggert <eggert@cs.ucla.edu>
d311d28c
PE
2
3 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
4 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
5 (string_bytes, check_sblock, allocate_string_data):
6 (compact_small_strings, Fmake_bool_vector, make_string)
7 (make_unibyte_string, make_multibyte_string)
8 (make_string_from_bytes, make_specified_string)
9 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
10 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
11 (mark_vectorlike):
12 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
13 (allocate_pseudovector):
14 Use int, not EMACS_INT, where int is wide enough.
15 (inhibit_garbage_collection, Fgarbage_collect):
16 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
c9af454e
PE
17 (GC_LISP_OBJECT_ARGUMENT):
18 Use offsetof, not __alignof__ or sizeof. __alignof__ gives
19 the wrong answer on the x86 with GCC.
d311d28c
PE
20 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
21 int might not be wide enough.
22 (bidi_cache_search, bidi_cache_find, bidi_init_it)
23 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
24 (bidi_at_paragraph_end, bidi_find_paragraph_start)
25 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
26 (bidi_level_of_next_char, bidi_move_to_visually_next):
27 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
28 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
29 (Fkill_buffer, Fset_buffer_major_mode)
30 (advance_to_char_boundary, Fbuffer_swap_text)
31 (Fset_buffer_multibyte, overlays_at, overlays_in)
32 (overlay_touches_p, struct sortvec, record_overlay_string)
33 (overlay_strings, recenter_overlay_lists)
34 (adjust_overlays_for_insert, adjust_overlays_for_delete)
35 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
36 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
37 (Foverlay_recenter, last_overlay_modification_hooks_used)
38 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
39 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
40 (validate_region): Omit unnecessary test for b <= e, since
41 that's guaranteed by the previous test.
42 (adjust_overlays_for_delete): Avoid pos + length overflow.
43 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
44 (report_overlay_modification):
45 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
46 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
47 Omit pointer cast, which isn't needed anyway, and doesn't work
48 after the EMACS_INT -> ptrdiff_t change.
79cce3f2
PE
49 (Fmove_overlay): Delete an evaporating overlay
50 if it becomes empty after its bounds are adjusted to fit within
51 its buffer. Without this fix, in a nonempty buffer (let ((o
52 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
53 yields an empty overlay that has the evaporate property, which is
54 not supposed to happen. (Bug#9642)
d311d28c
PE
55 * buffer.h: Adjust decls to match defn changes elsewhere.
56 (struct buffer_text, struct buffer):
57 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
58 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
59 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
60 not int, to avoid needless 32-bit limit on 64-bit hosts.
61 (exec_byte_code): Use tighter memory-full test, one that checks
62 for alloca overflow. Don't compute the address of the object just
63 before an array, as that's not portable. Use EMACS_INT, not
64 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
65 * callint.c (Fcall_interactively):
66 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
67 * callproc.c (call_process_kill, Fcall_process):
68 Don't assume pid_t fits into an Emacs fixnum.
69 (call_process_cleanup, Fcall_process, child_setup):
70 Don't assume pid_t fits into int.
71 (call_process_cleanup, Fcall_process, delete_temp_file)
72 (Fcall_process_region):
73 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
74 (Fcall_process): Simplify handling of volatile integers.
75 Use int, not EMACS_INT, where int will do.
76 * casefiddle.c (casify_object, casify_region, operate_on_word)
77 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
78 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
79 (casify_object): Avoid integer overflow when overallocating buffer.
80 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 81 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
82 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
83 * category.h (CATEGORYP): Don't assume arg is nonnegative.
84 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
85 integers are now checked earlier. All uses replaced with XINT.
86 (ccl_driver):
87 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
88 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
89 (ccl_driver, Fregister_code_conversion_map):
90 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
91 (resolve_symbol_ccl_program): Check that vector header is in range.
92 Always copy the vector, so that we can check its contents reliably
93 now rather than having to recheck each instruction as it's being
94 executed. Check that vector words fit in 'int'.
95 (ccl_get_compiled_code, Fregister_ccl_program)
96 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
97 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
98 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
99 contents are in range.
100 (Fccl_execute_on_string): Check that status is in range.
101 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
102 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
103 Accept and return EMACS_INT, not int, because callers can pass values
104 out of 'int' range.
105 (c_string_width, strwidth, lisp_string_width, chars_in_text)
106 (multibyte_chars_in_text, parse_str_as_multibyte)
107 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
108 (str_as_unibyte, str_to_unibyte, string_count_byte8)
109 (string_escape_byte8, Fget_byte):
110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
111 (Funibyte_string): Use CHECK_CHARACTER, not CHECK_NATNUM, to
112 avoid mishandling large integers.
113 * character.h: Adjust decls to match defn changes elsewhere.
114 * charset.c (load_charset_map_from_file, find_charsets_in_text)
115 (Ffind_charset_region):
116 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
117 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
118 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 119 Don't assume fixnum fits in int.
d311d28c
PE
120 (load_charset_map_from_vector, Fmap_charset_chars):
121 Remove now-unnecessary CHECK_NATNUMs.
122 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
123 Don't rely on undefined behavior with signed left shift overflow.
124 Don't assume unsigned int fits into fixnum, or that fixnum fits
125 into unsigned int. Don't require max_code to be a valid fixnum;
126 that's not true for gb10830 4-byte on a 32-bit host. Allow
127 invalid_code to be a cons, for the same reason. Require code_offset
128 to be a character. Avoid int overflow if max_char is close
129 to INT_MAX.
130 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
131 this is intended anyway and avoids some undefined behavior.
132 (load_charset_map): Pass unsigned, not int, as 2nd arg of
133 INDEX_TO_CODE_POINT, as that's what it expects.
134 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
135 * charset.h (DECODE_CHAR): Return int, not unsigned;
136 this is what was intended anyway, and it avoids undefined behavior.
137 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
138 integer-overflow issues.
139 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
140 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
141 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
142 * chartab.c (Fmake_char_table, Fset_char_table_range)
143 (uniprop_get_decoder, uniprop_get_encoder):
144 Don't assume fixnum fits in int.
145 * cmds.c (move_point): New function, that does the gist of
146 Fforward_char and Fbackward_char, but does so while checking
147 for integer overflow more accurately.
c96e5d6a 148 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
149 (Fforward_line, Fend_of_line, internal_self_insert)
150 (internal_self_insert):
151 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
152 Fix a FIXME, by checking for integer overflow when calculating
153 target_clm and actual_clm.
154 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
155 (ASSURE_DESTINATION, coding_alloc_by_realloc)
156 (coding_alloc_by_making_gap, alloc_destination)
157 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
158 (encode_coding_utf_16, detect_coding_emacs_mule)
159 (decode_coding_emacs_mule, encode_coding_emacs_mule)
160 (detect_coding_iso_2022, decode_coding_iso_2022)
161 (encode_invocation_designation, encode_designation_at_bol)
162 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
163 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
164 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
165 (encode_coding_ccl, encode_coding_raw_text)
166 (detect_coding_charset, decode_coding_charset)
167 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
168 (produce_composition, produce_charset, produce_annotation)
169 (decode_coding, handle_composition_annotation)
170 (handle_charset_annotation, consume_chars, decode_coding_gap)
171 (decode_coding_object, encode_coding_object, detect_coding_system)
172 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
173 (code_convert_region, code_convert_string)
174 (Fdefine_coding_system_internal):
175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
176 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
177 (Fdefine_coding_system_internal):
178 Don't assume fixnums fit in int.
179 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 180 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
181 (Funencodable_char_position, Fcheck_coding_systems_region)
182 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2c6a9faa 184 (consume_chars): Rewrite to avoid calculating an address outside buffer.
d311d28c 185 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 186 Don't access memory outside of the args array.
d311d28c 187 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
188 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
189 result of ENCODE_CHAR.
d311d28c
PE
190 * coding.h: Adjust decls to match defn changes elsewhere.
191 (struct coding_system):
192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
193 * composite.c (get_composition_id, find_composition)
194 (run_composition_function, update_compositions)
195 (compose_text, composition_gstring_put_cache)
196 (composition_gstring_p, composition_gstring_width)
197 (fill_gstring_header, fill_gstring_body, autocmp_chars)
198 (composition_compute_stop_pos, composition_reseat_it)
199 (composition_update_it, struct position_record)
200 (find_automatic_composition, composition_adjust_point)
201 (Fcomposition_get_gstring, Ffind_composition_internal):
202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
203 (update_compositions):
204 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
205 * composite.h: Adjust decls to match defn changes elsewhere.
206 (struct composition):
207 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
208 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
209 Do not attempt to compute the address of the object just before a
210 buffer; this is not portable.
211 (Faref, Faset):
212 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
213 (Faset): Use int, not EMACS_INT, where int is wide enough.
214 (Fstring_to_number): Don't assume fixnums fit in int.
215 (Frem): Don't assume arg is nonnegative.
216 * dbusbind.c (xd_append_arg): Check for integers out of range.
217 (Fdbus_call_method): Don't overflow the timeout int.
218 * dired.c (directory_files_internal, file_name_completion, scmp)
219 (file_name_completion_stat):
220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
221 (file_name_completion): Don't overflow matchcount.
222 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
223 * dispextern.h: Adjust decls to match defn changes elsewhere.
224 (struct text_pos, struct glyph, struct bidi_saved_info)
225 (struct bidi_string_data, struct bidi_it, struct composition_it)
226 (struct it):
227 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
228 (struct display_pos, struct composition_it, struct it):
229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
230 * dispnew.c (increment_matrix_positions)
231 (increment_row_positions, mode_line_string)
232 (marginal_area_string):
233 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 234 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
235 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
236 (duration_to_sec_usec): New function, to check for overflow better.
237 (Fsleep_for, sit_for): Use it.
238 * doc.c (get_doc_string, store_function_docstring):
239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
240 (get_doc_string, Fsnarf_documentation):
241 Use int, not EMACS_INT, where int is wide enough.
242 (get_doc_string):
243 Use SAFE_ALLOCA, not alloca.
244 Check for overflow when converting EMACS_INT to off_t.
245 * doprnt.c (doprnt):
246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
247 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
248 Don't assume uid_t fits into fixnum.
249 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
250 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
251 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
252 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
253 (general_insert_function)
254 (Finsert_char, make_buffer_string, make_buffer_string_both)
255 (update_buffer_properties, Fbuffer_substring)
256 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
257 (Fsubst_char_in_region, check_translation)
258 (Ftranslate_region_internal, save_restriction_restore, Fformat)
259 (transpose_markers, Ftranspose_regions):
260 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
261 (clip_to_bounds): Move to lisp.h as an inline function).
262 (Fconstrain_to_field): Don't assume integers are nonnegative.
263 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
264 (Fsubst_char_in_region, Fsave_restriction):
265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
266 (Femacs_pid): Don't assume pid_t fits into fixnum.
267 (lo_time): Use int, not EMACS_INT, when int suffices.
268 (lisp_time_argument): Check for usec out of range.
269 (Fencode_time): Don't assume fixnum fits in int.
270 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
271 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
272 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
273 (init_cmdargs, Fdump_emacs):
274 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
275 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
276 the bottom (typically) 32 bits of the fixnum.
277 * eval.c (specpdl_size, call_debugger):
278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
279 (when_entered_debugger, Fbacktrace_debug):
280 Don't assume fixnum can fit in int.
281 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
282 the object just before a buffer; this is not portable.
283 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
284 (grow_specpdl, unbind_to):
285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
286 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
287 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 288 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
289 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
290 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
291 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
292 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
293 (a_write, e_write):
294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
295 (Fcopy_file, non_regular_nbytes, read_non_regular)
296 (Finsert_file_contents):
297 Use int, not EMACS_INT, where int is wide enough.
298 (READ_BUF_SIZE): Verify that it fits in int.
299 (Finsert_file_contents): Check that counts are in proper range,
300 rather than assuming fixnums fit into ptrdiff_t etc.
301 Don't assume fixnums fit into int.
125b3835 302 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
303 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
304 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
305 (string_char_to_byte, string_byte_to_char)
306 (string_make_multibyte, string_to_multibyte)
307 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
308 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
309 (substring_both, Fdelete, internal_equal, Ffillarray)
310 (Fclear_string, mapcar1)
311 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
312 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
313 (larger_vector, make_hash_table, maybe_resize_hash_table)
314 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
315 (Fmaphash, secure_hash):
316 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
317 (concat): Check for string index and length overflow.
318 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
319 (Frequire):
320 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
321 (larger_vector): New API (vec, incr_min, size_max) replaces old
322 one (vec, new_size, init). This catches size overflow.
323 INIT was removed because it was always Qnil.
324 All callers changed.
325 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
326 the upper bound on a hash table index size.
327 (make_hash_table, maybe_resize_hash_table): Use it.
328 (secure_hash): Computer start_byte and end_byte only after
329 they're known to be in ptrdiff_t range.
330 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
331 (Ffont_get_glyphs, Ffont_at):
332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
333 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
334 (Flist_fonts, Fopen_font):
335 Don't assume fixnum can fit in int.
336 (check_gstring): Don't assume index can fit in int.
337 (font_match_p): Check that fixnum is a character, not a nonnegative
338 fixnum, since the later code needs to stuff it into an int.
339 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
340 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
341 conversion overflow issues.
342 (Fopen_font): Check for integer out of range.
343 (Ffont_get_glyphs): Don't assume index can fit in int.
344 * font.h: Adjust decls to match defn changes elsewhere.
345 * fontset.c (reorder_font_vector): Redo score calculation to avoid
346 integer overflow.
347 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
348 printmax_t, where ptrdiff_t is wide enough.
349 (Finternal_char_font):
350 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
351 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
352 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
353 (Fset_frame_position, x_set_frame_parameters)
354 (x_set_line_spacing, x_set_border_width)
355 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
356 Check that fixnums are in proper range for system types.
357 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
358 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
359 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
360 Use SAFE_ALLOCA_LISP, not alloca.
361 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
362 intptr_t is wide enough.
363 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
364 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
365 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
366 Check for fixnum out of range.
367 * ftfont.c (ftfont_list): Don't assume index fits in int.
368 Check that fixnums are in proper range for system types.
369 (ftfont_shape_by_flt):
370 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
371 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
373 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
374 Check that fixnums are in proper range for system types.
375 * gnutls.h: Adjust decls to match defn changes elsewhere.
376 * gtkutil.c (xg_dialog_run):
377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
378 (update_frame_tool_bar):
379 Check that fixnums are in proper range for system types.
380 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 381 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
382 * indent.c (last_known_column, last_known_column_point):
383 (current_column_bol_cache):
384 (skip_invisible, current_column, check_display_width):
385 (check_display_width, scan_for_column, current_column_1)
386 (Findent_to, Fcurrent_indentation, position_indentation)
387 (indented_beyond_p, Fmove_to_column, compute_motion):
388 (Fcompute_motion, Fvertical_motion):
389 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
390 (last_known_column_modified): Use EMACS_INT, not int.
391 (check_display_width):
392 (Fcompute_motion):
393 Check that fixnums and floats are in proper range for system types.
394 (compute_motion): Don't assume index or fixnum fits in int.
395 (compute_motion, Fcompute_motion):
396 Use int, not EMACS_INT, when it is wide enough.
397 (vmotion): Omit local var start_hpos that is always 0; that way
398 we don't need to worry about overflow in expressions involving it.
399 * indent.h: Adjust decls to match defn changes elsewhere.
400 (struct position):
401 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
402 Use int, not EMACS_INT, where int is wide enough.
403 Remove unused members ovstring_chars_done and tab_offset;
404 all uses removed.
405 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
406 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
407 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
408 (make_gap, copy_text, insert, insert_and_inherit)
409 (insert_before_markers, insert_before_markers_and_inherit)
410 (insert_1, count_combining_before, count_combining_after)
411 (insert_1_both, insert_from_string)
412 (insert_from_string_before_markers, insert_from_string_1)
413 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
414 (adjust_after_replace, adjust_after_insert, replace_range)
415 (replace_range_2, del_range, del_range_1, del_range_byte)
416 (del_range_both, del_range_2, modify_region)
417 (prepare_to_modify_buffer, signal_before_change)
418 (signal_after_change, Fcombine_after_change_execute):
419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
420 * intervals.c (traverse_intervals, rotate_right, rotate_left)
421 (balance_an_interval, split_interval_right, split_interval_left)
422 (find_interval, next_interval, update_interval)
423 (adjust_intervals_for_insertion, delete_node, delete_interval)
424 (interval_deletion_adjustment, adjust_intervals_for_deletion)
425 (static_offset_intervals, offset_intervals)
426 (merge_interval_right, merge_interval_left, make_new_interval)
427 (graft_intervals_into_buffer, temp_set_point_both)
428 (temp_set_point, set_point, adjust_for_invis_intang)
429 (set_point_both, move_if_not_intangible, get_property_and_range)
430 (get_local_map, copy_intervals, copy_intervals_to_string)
431 (compare_string_intervals, set_intervals_multibyte_1):
432 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
433 * intervals.h: Adjust decls to match defn changes elsewhere.
434 (struct interval):
435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
436 * keyboard.c (this_command_key_count, this_single_command_key_start)
437 (before_command_key_count, before_command_echo_length, echo_now)
438 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
439 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
440 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
441 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
442 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
443 (last_non_minibuf_size, last_point_position, echo_truncate)
444 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
445 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
446 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
447 (stuff_buffered_input):
448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
449 (last_auto_save, command_loop_1, read_char):
450 Use EMACS_INT, not int, to avoid integer overflow.
451 (record_char): Avoid overflow in total_keys computation.
452 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
453 * keyboard.h: Adjust decls to match defn changes elsewhere.
454 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
455 (Fkey_description, Fdescribe_vector, Flookup_key):
456 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
457 (click_position): New function, to check that positions are in range.
458 (Fcurrent_active_maps):
459 (describe_command):
460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
461 (Faccessible_keymaps, Fkey_description):
462 (preferred_sequence_p):
463 Don't assume fixnum can fit into int.
464 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
465 Check for integer overflow in size calculations.
466 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
467 avoid mishandling large integers.
468 * lisp.h: Adjust decls to match defn changes elsewhere.
469 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
470 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
471 (struct Lisp_Marker):
472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
473 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
474 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
475 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
476 All callers changed.
477 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
478 Assume the arg has valid form, since it always does.
479 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
480 unsigned integer system type.
481 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
482 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
483 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
484 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
485 (duration_to_sec_usec): New decl.
486 * lread.c (read_from_string_index, read_from_string_index_byte)
487 (read_from_string_limit, readchar, unreadchar, openp)
488 (read_internal_start, read1, oblookup):
489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
490 (Fload, readevalloop, Feval_buffer, Feval_region):
491 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
492 (openp): Check for out-of-range argument to 'access'.
493 (read1): Use int, not EMACS_INT, where int is wide enough.
494 Don't assume fixnum fits into int.
1ab7b8ac
PE
495 (read_filtered_event): Use duration_to_sec_usec
496 to do proper overflow checking on durations.
d311d28c
PE
497 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
498 in size calculation.
499 (Fexecute_kbd_macro):
500 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
501 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
502 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
503 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
504 (set_marker_both, set_marker_restricted_both, marker_position)
505 (marker_byte_position, Fbuffer_has_markers_at):
506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
507 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
508 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
509 It now merely ensures that the menu is large enough, without
510 necessarily growing it, as this avoids some integer overflow issues.
511 All callers changed.
512 (keymap_panes, parse_single_submenu, Fx_popup_menu):
513 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
514 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
515 Use SAFE_ALLOCA_LISP, not alloca.
516 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
517 to EMACS_INT. Check that fixnums are in proper range for system types.
518 * minibuf.c (minibuf_prompt_width, string_to_object)
519 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
520 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
521 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
522 (get_minibuffer, read_minibuf_unwind):
523 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
524 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
525 this simplifies overflow checking. All callers changed.
526 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
527 (Ftest_completion):
528 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
529 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
530 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
531 Check that fixnums are in proper range for system types.
532 (Fx_create_frame, Fx_show_tip):
533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
534 * nsfont.m (ns_findfonts, nsfont_list_family):
535 Don't assume fixnum fits in long.
536 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
538 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
539 wide enough.
17fdb222 540 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
541 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
542 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
543 (PRINTDECLARE, PRINTPREPARE):
544 (strout, print_string):
545 (print, print_preprocess, print_check_string_charset_prop)
546 (print_object):
547 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
548 (PRINTDECLARE):
549 (temp_output_buffer_setup, Fprin1_to_string, print_object):
550 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
551 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
552 (PRINTFINISH): Use SAFE_ALLOCA, not alloca.
553 (printchar, strout): Use xpalloc to catch size calculation overflow.
554 (Fexternal_debugging_output): Use CHECK_CHARACTER, not CHECK_NUMBER,
555 to avoid mishandling large integers.
556 (print_error_message): Use SAFE_ALLOCA, not alloca.
557 (print_object): Use int, not EMACS_INT, where int is wide enough.
558 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
559 (Fset_process_window_size, Fformat_network_address)
560 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
561 (Fsignal_process, sigchld_handler):
562 Check that fixnums are in proper range for system types.
563 (Fformat_network_address, read_process_output, send_process)
564 (Fprocess_send_region, status_notify):
565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
566 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
567 (wait_reading_process_output, read_process_output, exec_sentinel):
568 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
569 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
570 (Faccept_process_output): Use duration_to_sec_usec to do proper
571 overflow checking on durations.
b62b53e8
PE
572 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
573 configured --with-wide-int.
d311d28c
PE
574 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
575 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
576 * search.c (looking_at_1, string_match_1):
577 (fast_string_match, fast_c_string_match_ignore_case)
578 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
579 (scan_newline, find_before_next_newline, search_command)
580 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
581 (set_search_regs, wordify):
582 (Freplace_match):
583 (Fmatch_data):
584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
585 (string_match_1, search_buffer, set_search_regs):
586 (Fmatch_data):
587 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
588 (wordify): Check for overflow in size calculation.
589 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
590 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
591 Check that fixnums are in proper range for system types.
592 * sound.c (struct sound_device)
593 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
595 (Fplay_sound_internal):
596 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
597 * syntax.c (ST_COMMENT_STYLE, ST_STRING_STYLE):
598 In definitions, make it clearer that these values must be out of range
5895d7b9
PE
599 for the respective integer ranges. This fixes a bug with
600 ST_STRING_STYLE and non-ASCII characters.
d311d28c
PE
601 (struct lisp_parse_state, find_start_modiff)
602 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
603 (Fparse_partial_sexp):
604 Don't assume fixnums can fit in int.
605 (struct lisp_parse_state, find_start_pos, find_start_value)
606 (find_start_value_byte, find_start_begv)
607 (update_syntax_table, char_quoted, dec_bytepos)
608 (find_defun_start, prev_char_comend_first, back_comment):
609 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
610 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
611 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
612 (Finternal_describe_syntax_value): Check that match_lisp is a
613 character, not an integer, since the code stuffs it into int.
614 (scan_words, scan_sexps_forward):
615 Check that fixnums are in proper range for system types.
616 (Fforward_word):
617 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
618 (scan_sexps_forward):
619 Use CHARACTERP, not INTEGERP, since the value must fit into int.
620 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
621 * syntax.h: Adjust decls to match defn changes elsewhere.
622 (struct gl_state_s):
623 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
624 * sysdep.c (wait_for_termination_1, wait_for_termination)
625 (interruptible_wait_for_termination, mkdir):
626 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
627 (emacs_read, emacs_write):
628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
629 (system_process_attributes): Don't assume uid_t, gid_t, and
630 double all fit in int or even EMACS_INT.
631 * term.c (set_tty_color_mode):
632 Check that fixnums are in proper range for system types.
633 * termhooks.h (struct input_event):
634 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
635 * textprop.c (validate_interval_range, interval_of)
636 (Fadd_text_properties, set_text_properties_1)
637 (Fremove_text_properties, Fremove_list_of_text_properties)
638 (Ftext_property_any, Ftext_property_not_all)
639 (copy_text_properties, text_property_list, extend_property_ranges)
640 (verify_interval_modification):
641 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
642 (Fnext_single_char_property_change)
643 (Fprevious_single_char_property_change):
644 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
645 (copy_text_properties):
646 Check for integer overflow in index calculation.
d311d28c
PE
647 * undo.c (last_boundary_position, record_point, record_insert)
648 (record_delete, record_marker_adjustment, record_change)
649 (record_property_change):
650 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
651 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
652 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
653 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
654 (Fx_hide_tip, Fx_file_dialog):
655 * w32menu.c (set_frame_menubar):
656 Use ptrdiff_t, not int, for consistency with rest of code.
657 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
658 (select_window, Fdelete_other_windows_internal)
659 (window_scroll_pixel_based, window_scroll_line_based)
660 (Frecenter, Fset_window_configuration):
661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
662 (Fset_window_hscroll, run_window_configuration_change_hook)
663 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 664 (Fscroll_other_window, Frecenter):
d311d28c
PE
665 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
666 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
667 Don't assume fixnum fits in int.
668 (Fset_window_scroll_bars):
669 Check that fixnums are in proper range for system types.
670 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
671 (string_pos, c_string_pos, number_of_chars, init_iterator)
672 (in_ellipses_for_invisible_text_p, init_from_display_pos)
673 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
674 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
675 (face_before_or_after_it_pos, handle_invisible_prop)
676 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
677 (display_prop_intangible_p, string_buffer_position_lim)
678 (string_buffer_position, handle_composition_prop, load_overlay_strings)
679 (get_overlay_strings_1, get_overlay_strings)
680 (iterate_out_of_display_property, forward_to_next_line_start)
681 (back_to_previous_visible_line_start, reseat, reseat_to_string)
682 (get_next_display_element, set_iterator_to_next)
683 (get_visually_first_element, compute_stop_pos_backwards)
684 (handle_stop_backwards, next_element_from_buffer)
685 (move_it_in_display_line_to, move_it_in_display_line)
686 (move_it_to, move_it_vertically_backward, move_it_by_lines)
687 (add_to_log, message_dolog, message_log_check_duplicate)
688 (message2, message2_nolog, message3, message3_nolog
689 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
690 (current_message_1, truncate_echo_area, truncate_message_1)
691 (set_message, set_message_1, store_mode_line_noprop)
692 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
693 (text_outside_line_unchanged_p, check_point_in_composition)
694 (reconsider_clip_changes)
695 (redisplay_internal, set_cursor_from_row, try_scrolling)
696 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
697 (redisplay_window, find_last_unchanged_at_beg_row)
698 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
699 (trailing_whitespace_p, find_row_edges, display_line)
700 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
701 (display_mode_element, store_mode_line_string)
702 (pint2str, pint2hrstr, decode_mode_spec)
703 (display_count_lines, display_string, draw_glyphs)
704 (x_produce_glyphs, x_insert_glyphs)
705 (rows_from_pos_range, mouse_face_from_buffer_pos)
706 (fast_find_string_pos, mouse_face_from_string_pos)
707 (note_mode_line_or_margin_highlight, note_mouse_highlight):
708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
709 (safe_call, init_from_display_pos, handle_fontified_prop)
710 (handle_single_display_spec, load_overlay_strings)
711 (with_echo_area_buffer, setup_echo_area_for_printing)
712 (display_echo_area, echo_area_display)
713 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
714 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
715 (redisplay_window, dump_glyph_row, display_mode_line)
716 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 717 (handle_display_spec, display_prop_string_p):
d311d28c
PE
718 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
719 (handle_single_display_spec, build_desired_tool_bar_string)
720 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
721 (get_specified_cursor_type):
722 Check that fixnums are in proper range for system types.
723 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
724 (Flookup_image_map):
725 Don't assume fixnums fit in int.
726 (compare_overlay_entries):
727 Avoid mishandling comparisons due to subtraction overflow.
728 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
729 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
730 (handle_tool_bar_click):
731 Use int, not unsigned, since we prefer signed and the signedness
732 doesn't matter here.
733 (get_next_display_element, next_element_from_display_vector):
734 Use int, not EMACS_INT, when int is wide enough.
735 (start_hourglass): Use duration_to_sec_usec to do proper
736 overflow checking on durations.
737 * xfaces.c (Fbitmap_spec_p):
738 Check that fixnums are in proper range for system types.
739 (compare_fonts_by_sort_order):
740 Avoid mishandling comparisons due to subtraction overflow.
741 (Fx_family_fonts, realize_basic_faces):
742 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
743 (Fx_family_fonts):
744 Don't assume fixnum fits in int.
745 Use SAFE_ALLOCA_LISP, not alloca.
746 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
747 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
748 (face_at_buffer_position, face_for_overlay_string)
749 (face_at_string_position):
750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
751 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
752 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
753 (Fx_show_tip):
754 Check that fixnums are in proper range for system types.
755 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
756 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
757 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
758 (Fx_change_window_property): Don't assume fixnums fit in int.
759 * xfont.c (xfont_chars_supported):
760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
761 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
762 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
764 * xml.c (parse_region):
765 * xrdb.c (magic_file_p):
766 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
767 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
768 (x_get_local_selection, x_reply_selection_request)
769 (x_handle_selection_request, wait_for_property_change):
770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
771 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
772 short is wide enough.
773 (x_send_client_event): Don't assume fixnum fits in int.
774 * xterm.c (x_x_to_emacs_modifiers):
775 Don't assume EMACS_INT overflows nicely into int.
776 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
777 may come from Lisp.
778 (handle_one_xevent): NATNUMP can eval its arg twice.
779 (x_connection_closed):
780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
781 * xterm.h: Adjust decls to match defn changes elsewhere.
782 (struct scroll_bar): Use struct vectorlike_header
783 rather than rolling our own approximation.
784 (SCROLL_BAR_VEC_SIZE): Remove; not used.
785
51553db6
SM
7862011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
787
32c1fffd
SM
788 * dired.c (file_name_completion): Don't expand file name.
789 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
790 before checking file name handler.
791
51553db6
SM
792 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
793 they've been requested explicitly (bug#9591).
794
b6bd1599 7952011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
796
797 * keymap.c (Fsingle_key_description): Use make_specified_string
798 instead of build_string to build string from push_key_description.
799 (Bug#5193)
800
f701dc2a
PE
8012011-09-30 Paul Eggert <eggert@cs.ucla.edu>
802
4222c55d
PE
803 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
804 This fixes a Y2038 bug on 64-bit hosts.
805 * buffer.c (reset_buffer):
806 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
807 (Fclear_buffer_auto_save_failure):
808 Use 0, not -1, to represent an unset failure time, since time_t
809 might not be signed.
810
f701dc2a
PE
811 Remove dependency on glibc malloc internals.
812 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
813 Move back here from lisp.h, but with their new implementations.
814 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
815 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
816 * charset.c (charset_table_init): New static var.
817 (syms_of_charset): Use it instead of xmalloc. This removes a
818 dependency on glibc malloc internals. See Eli Zaretskii's comment in
819 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
820 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
821 Move back to alloc.c.
822 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
823 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
824
9ceebf39
JD
8252011-09-30 Jan Djärv <jan.h.d@swipnet.se>
826
827 * nsterm.m (windowDidResize): Call x_set_window_size only when
828 ns_in_resize is true. Otherwise set pixelwidth/height and
829 call change_frame_size (Bug#9628).
830
cb993c58
PE
8312011-09-30 Paul Eggert <eggert@cs.ucla.edu>
832
3930c88b
PE
833 Port --enable-checking=all to Fedora 14 x86-64.
834 * charset.c (syms_of_charset): Also account for glibc malloc's
835 internal overhead when calculating the initial malloc maximum.
836
cb993c58
PE
837 Port --enable-checking=all to Fedora 14 x86.
838 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
839 Move to lisp.h.
840 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
841 (overrun_check_realloc, overrun_check_free):
842 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
843 That way, xmalloc returns a properly-aligned pointer even if
844 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
845 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
846 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
847 into account when calculating the initial malloc maximum.
848 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
849 Move here from alloc.c, so that charset.c can use it too.
850 Properly align; the old code wasn't right for common 32-bit hosts
851 when configured with --enable-checking=all.
852 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
853 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
854
31bed486
EZ
8552011-09-29 Eli Zaretskii <eliz@gnu.org>
856
04c70788 857 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
858 use EDOM.
859
fbcaa2f3
EZ
8602011-09-28 Eli Zaretskii <eliz@gnu.org>
861
862 * xdisp.c (compute_display_string_end): If there's no display
863 string at CHARPOS, return -1.
864
865 * bidi.c (bidi_fetch_char): When compute_display_string_end
866 returns a negative value, treat the character as a normal
867 character not covered by a display string. (Bug#9624)
868
a239d4e9
JB
8692011-09-28 Juanma Barranquero <lekktu@gmail.com>
870
871 * lread.c (Fread_from_string): Fix typo in docstring.
872
88652fd5
EZ
8732011-09-27 Eli Zaretskii <eliz@gnu.org>
874
875 * xdisp.c (handle_invisible_prop): If invisible text ends on a
876 newline, reseat the iterator instead of bidi-iterating there one
877 character at a time. (Bug#9610)
32c1fffd
SM
878 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
879 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 880
ed497dd4
AS
8812011-09-27 Andreas Schwab <schwab@linux-m68k.org>
882
883 * lread.c (readevalloop): Use correct code for NBSP.
884 (read1): Likewise. (Bug#9608)
885
b2bf61aa
MA
8862011-09-25 Michael Albinus <michael.albinus@gmx.de>
887
888 * dbusbind.c (Fdbus_register_signal): When service is not
889 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
890
32bbb17c
GM
8912011-09-25 Glenn Morris <rgm@gnu.org>
892
893 * buffer.c (truncate-lines): Doc fix.
894
94e0933e
CY
8952011-09-24 Chong Yidong <cyd@stupidchicken.com>
896
897 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
898 (Fset_window_next_buffers): Doc fix.
899
cddde921
GM
9002011-09-24 Glenn Morris <rgm@gnu.org>
901
902 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
903
1260aef1
PE
9042011-09-24 Paul Eggert <eggert@cs.ucla.edu>
905
25b4bfa0
PE
906 Fix minor problems found by static checking.
907 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
908 * indent.c (Fvertical_motion): Fix == vs = typo.
909
e3cbd34b
EZ
9102011-09-24 Eli Zaretskii <eliz@gnu.org>
911
6bf7006f
EZ
912 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
913 value is now t. Doc fix.
914
e3cbd34b 915 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 916 logic when moving up, not only when moving down. Fix the
e3cbd34b 917 confusing name and values of the it_overshoot_expected variable;
32c1fffd 918 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
919
920 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
921 CHARPOS is covered by a display string which includes newlines.
922 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
923 is covered by a display string with embedded newlines.
924
a3de0cbd
MA
9252011-09-24 Michael Albinus <michael.albinus@gmx.de>
926
927 * dbusbind.c (Fdbus_register_signal): Add match rule to
928 Vdbus_registered_objects_table. (Bug#9581)
929 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
930 docstring.
931
b260039d
JM
9322011-09-24 Jim Meyering <meyering@redhat.com>
933
32c1fffd 934 do not ignore write error for any output size
b260039d
JM
935 The previous change was incomplete.
936 While it makes emacs --batch detect the vast majority of stdout
937 write failures, errors were still ignored whenever the output size is
938 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
939 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
940 && echo FAIL: ignored write error
941 FAIL: ignored write error
942 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
943 && echo FAIL: ignored write error
944 FAIL: ignored write error
945 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
946
8eca8a7c
AS
9472011-09-23 Andreas Schwab <schwab@linux-m68k.org>
948
949 * emacs.c (Fkill_emacs): In noninteractive mode exit
950 non-successfully if a write error occurred on stdout. (Bug#9574)
951
3341db62
EZ
9522011-09-21 Eli Zaretskii <eliz@gnu.org>
953
954 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
955 the xassert test.
956
957 * dispextern.h (struct it): Update the comment documenting what
958 can it->OBJECT be.
959
8c203dbf
EZ
9602011-09-20 Eli Zaretskii <eliz@gnu.org>
961
962 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
963 a display string, extend search for cursor position to end of row.
964 (find_row_edges): If the row ends in a newline from a display
965 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
966 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
967 (Fcurrent_bidi_paragraph_direction): Fix search for previous
968 non-empty line. Fixes confusing cursor motion with arrow keys at
969 the beginning of a line that starts with whitespace.
8c203dbf 970
a4824228
LMI
9712011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
972
973 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
974 (bug#9493).
975
33ed493b
CY
9762011-09-18 Chong Yidong <cyd@stupidchicken.com>
977
978 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
979 boolean (Bug#9154).
980
56cd55c8
EZ
9812011-09-18 Eli Zaretskii <eliz@gnu.org>
982
983 * xdisp.c (display_line): Record maximum and minimum buffer
984 positions even if no glyphs were produced (e.g., by a zero-width
985 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
986 buffer positions that will be removed from the glyph row because
987 they don't fit.
c02dcedf
EZ
988 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
989 column is beyond frame width: don't subtract 1 "pixel" when
990 computing width of the stretch.
3e62b7e0
EZ
991 (reseat_at_next_visible_line_start): Undo the change made on
992 2011-09-17 that saved paragraph information and restored it after
993 the call to `reseat'. (Bug#9545)
56cd55c8 994
5ed99d36 9952011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
996
997 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
998 and turn window cursor on if cleared (Bug#9415).
999
5ed99d36 10002011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1001
1002 * search.c (boyer_moore): Take unibyte characters from pattern
1003 literally. (Bug#9458)
1004
9bade7b2
EZ
10052011-09-18 Eli Zaretskii <eliz@gnu.org>
1006
1007 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1008
e5e9d610
PE
10092011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1010
87e4427a
PE
1011 Fix minor problem found by static checking.
1012 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1013 initialized, to pacify gcc -Wuninitialized.
1014
e5e9d610
PE
1015 * fileio.c: Report proper errno when syscall falls.
1016 (Finsert_file_contents): Save and restore errno,
1017 so that report_file_error outputs the correct diagnostic.
1018 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1019
a1674f0b
EZ
10202011-09-18 Eli Zaretskii <eliz@gnu.org>
1021
1022 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1023
fbfb6dd4
EZ
10242011-09-17 Eli Zaretskii <eliz@gnu.org>
1025
1026 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1027 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1028
bb187662
EZ
10292011-09-17 Eli Zaretskii <eliz@gnu.org>
1030
1137e8b8
EZ
1031 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1032 about the current paragraph and restore it after the call to
1033 reseat.
1034
1035 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1036 (bidi_find_paragraph_start): Search back for paragraph beginning
1037 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1038 (bidi_move_to_visually_next): Only trigger paragraph-related
1039 computations when the last character is a newline or at EOB, not
1040 just any NEUTRAL_B. (Bug#9470)
1041
bb187662
EZ
1042 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1043 truncated lines if point is covered by a display string. (Bug#9524)
1044
2e621251
PE
10452011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1046
1047 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1048 (cons_to_x_long): New function.
1049 (lisp_data_to_selection_data): Use it. Correct the test for
1050 short-versus-long data; it was negated. Break out of vector
1051 loop, for efficiency, when a long datum is discovered.
1052
91a15bc6
SM
10532011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1054
1055 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1056
b41c3a35
EZ
10572011-09-16 Eli Zaretskii <eliz@gnu.org>
1058
1059 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1060 GCC PR/17406) by declaring this function with external scope.
1061
7812ba2d
PE
10622011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1063
1064 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1065 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1066
cf7edc2a
AS
10672011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1068
1069 * editfns.c (Fformat): Correctly handle text properties on "%%".
1070
bd01620e
EZ
10712011-09-15 Eli Zaretskii <eliz@gnu.org>
1072
1073 * xterm.c (x_draw_composite_glyph_string_foreground):
1074 * w32term.c (x_draw_composite_glyph_string_foreground):
1075 * term.c (encode_terminal_code):
1076 * composite.c (composition_update_it, get_composition_id):
1077 * xdisp.c (get_next_display_element)
1078 (fill_composite_glyph_string): Add comments about special meaning
1079 of TAB characters in a composition.
1080
a02719a3
PE
10812011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1082
1083 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1084 This occurs when processing a multibyte format.
1085 Problem reported by Wolfgang Jenker.
a02719a3 1086
72589a3c
JB
10872011-09-15 Johan Bockgård <bojohan@gnu.org>
1088
1089 * xdisp.c (try_cursor_movement): Only check for exact match if
1090 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1091
1c14176c
PE
10922011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1093
1094 Remove unused external symbols.
1095 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1096 * xdisp.c (calc_pixel_width_or_height): Now static.
1097 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1098 * indent.c (check_display_width):
1099 * w32term.c: Fix comment to match code.
1100 * xterm.c, xterm.h (x_catching_errors): Remove.
1101
d2eea5b5
PE
11022011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1103
1104 * xselect.c: Use signed conversions more consistently (Bug#9498).
1105 (selection_data_to_lisp_data): Assume incoming selection data are
1106 signed integers, not unsigned. This is to be consistent with
1107 outgoing selection data, which was modified to use signed integers
1108 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1109 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1110 expects long, not unsigned long.
1111
46888499
EZ
11122011-09-14 Eli Zaretskii <eliz@gnu.org>
1113
1114 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1115 computation of loop end. Reported by Johan Bockgård
1116 <bojohan@gnu.org>.
1117
ef8ef9fb
CY
11182011-09-13 Chong Yidong <cyd@stupidchicken.com>
1119
1120 * frame.c (Fother_visible_frames_p): Function deleted.
1121
fa819fed
EZ
11222011-09-12 Eli Zaretskii <eliz@gnu.org>
1123
1124 * indent.c (compute_motion): Process display vector front to back
1125 rather than the other way around. (Bug#2496)
1126
2ba8e008
SM
11272011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1128
1129 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1130
20f53c69
CY
11312011-09-11 Chong Yidong <cyd@stupidchicken.com>
1132
1133 * minibuf.c (Fread_from_minibuffer): Doc fix.
1134
d562d7a4
EZ
11352011-09-11 Eli Zaretskii <eliz@gnu.org>
1136
1137 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1138 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1139
1c4d7f3d
LMI
11402011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1141
1142 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1143 value for non-existent files.
1144
b885bf36
EZ
11452011-09-11 Eli Zaretskii <eliz@gnu.org>
1146
1147 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1148 set its "size" to -1. This will set the modtime_size field of
1149 the corresponding buffer to -1, which is what
1150 verify-visited-file-modtime expects for files that do not exist.
1151 (Bug#9139)
1152
6612f0bf
PE
11532011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1154
1155 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1156 here ...
1157 * lisp.h: ... from here. push_key_description is no longer
1158 defined in keyboard.c, so its declaration should not be in
1159 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1160 logically belongs with push_key_description.
1161
dfb3f755
PE
11622011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1163
1164 * buffer.h: Include <sys/types.h> instead of <time.h>.
1165 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1166 Problem reported by Herbert J. Skuhra.
1167
3134906c
LMI
11682011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1169
1170 * xml.c (parse_region): Make the parsing work for
1171 non-comment-starting XML files again (bug#9144).
1172
8d903f4e
AS
11732011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1174
1175 * image.c (gif_load): Fix calculation of bottom and right corner.
1176 (Bug#9468)
1177
80ad64f4
EZ
11782011-09-10 Eli Zaretskii <eliz@gnu.org>
1179
1180 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1181 redisplay in small windows.
1182
208a048d
EZ
11832011-09-09 Eli Zaretskii <eliz@gnu.org>
1184
1185 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1186
9b1c252e
MR
11872011-09-08 Martin Rudalics <rudalics@gmx.at>
1188
1189 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1190 Operate on live windows only.
1191
2949f33b
JB
11922011-09-08 Juanma Barranquero <lekktu@gmail.com>
1193
1194 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1195
e08dcafd
EZ
11962011-09-07 Eli Zaretskii <eliz@gnu.org>
1197
1198 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1199 only under bidi iteration.
1200
115b96bd
JD
12012011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1202
1203 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1204
c8199d0f
PE
12052011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1206
1207 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1208 Without this fix, the command to link temacs failed due to an
1209 undefined symbol __builtin_isnan. This is because
1210 /usr/include/iso/math_c99.h #defines isnan(x) to
1211 __builtin_isnan(x), but the bundled gcc, which identifies itself
1212 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1213 a __builtin_isnan.
1214 * floatfns.c (isnan): #undef, and then #define to a clone of
1215 what's in data.c.
1216 (Fisnan): Always define, since it's always available now.
1217 (syms_of_floatfns): Always define isnan at the Lisp level.
1218
e39b275c 12192011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1220
1221 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1222
b2db44d9 12232011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1224
f4af5137 1225 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1226 The previous code assumed that file offsets (off_t values) fit in
1227 EMACS_INT variables, which is not true on typical 32-bit hosts.
1228 The code messed up by falsely reporting buffer overflow in cases
1229 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1230 when "big" contains more than 2**29 bytes, even though this
1231 inserts just one byte and does not overflow the buffer.
1232 (Finsert_file_contents): Store file offsets as off_t
1233 values, not as EMACS_INT values. Check for overflow when
1234 converting between EMACS_INT and off_t. When checking for
1235 buffer overflow or for overlap, take the offsets into account.
1236 Don't use EMACS_INT for small values where int suffices.
1237 When checking for overlap, fix a typo: ZV was used where
1238 ZV_BYTE was intended.
1239 (Fwrite_region): Don't assume off_t fits into 'long'.
1240 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1241
ecfc0a49
MA
12422011-09-05 Michael Albinus <michael.albinus@gmx.de>
1243
1244 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1245
6511acf2 12462011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1247
0999621a 1248 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1249
1250 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1251 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
1252 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1253 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
1254 (modify_event_symbol): Do not assume that the length of
1255 name_alist_or_stem is safe to alloca and fits in int.
1256 (Fexecute_extended_command): Likewise for function name and binding.
1257 (Frecursion_depth): Wrap around reliably on integer overflow.
1258 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1259 since some callers pass EMACS_INT values.
1260 (Fsingle_key_description): Don't crash if symbol name contains more
1261 than MAX_ALLOCA bytes.
1262 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1263 (get_minibuffer): Arg is now EMACS_INT, not int.
1264 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1265 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1266 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1267
2be7d702
PE
1268 * dbusbind.c (signature_cat): New function.
1269 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1270 Do not overrun buffer; instead, report string overflow.
1271
9d1df220
PE
1272 * dispnew.c (add_window_display_history): Don't overrun buffer.
1273 Truncate instead; this is OK since it's just a log.
1274
33ef5c64
PE
1275 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1276 even if the time zone offset is outlandishly large.
1277 Don't mishandle offset == INT_MIN.
1278
66c6fdd5
PE
1279 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1280 when creating daemon; the previous buffer-overflow check was incorrect.
1281
d749b01b
PE
1282 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1283 which has the guts of the old verror function.
1284
b5cd1905
PE
1285 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1286 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1287
6e1a67fb
PE
1288 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1289 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1290 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1291 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1292 length of string rather than counting it via multiple sprintfs;
1293 that's simpler and more reliable.
c21721cc
PE
1294 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1295 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1296 sprintf, in case result does not fit in int.
1297
c57b67fc
PE
1298 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1299 (fontset_from_font): Print it.
1300
8a401434
PE
1301 * frame.c (tty_frame_count): Now printmax_t, not int.
1302 (make_terminal_frame, set_term_frame_name): Print it.
1303 (x_report_frame_params): In X, window IDs are unsigned long,
1304 not signed long, so print them as unsigned.
1305 (validate_x_resource_name): Check for implausibly long names,
1306 and don't assume name length fits in 'int'.
1307 (x_get_resource_string): Don't blindly alloca invocation name;
1308 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1309 not fit in int.
1310
6e1a67fb
PE
1311 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1312 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1313 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1314
0df02bf3
PE
1315 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1316 Use esprintf, not sprintf, in case result does not fit in int.
1317
48e30793
PE
1318 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1319 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1320 it as a large positive number.
1321 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1322 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1323
a66ff6d8
PE
1324 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1325 in case result does not fit in int.
1326
aca216ff
PE
1327 * print.c (float_to_string): Detect width overflow more reliably.
1328 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1329 buffer overrun. Don't assume list length fits in 'int'. Treat
1330 print length of 0 as 0, not as infinity; to be consistent with other
1331 uses of print length in this function. Don't overflow print length
1332 index. Don't assume hash table size fits in 'long', or that
1333 vectorlike size fits in 'unsigned long'.
1334
31c286f7
PE
1335 * process.c (make_process): Use printmax_t, not int, to format
1336 process-name gensyms.
1337
55e5faa1
PE
1338 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1339
80f2e268
PE
1340 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1341 to avoid potential buffer overrun.
1342
670741ab
PE
1343 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1344 if X resource line is longer than 512 bytes.
1345
b7163a50
PE
1346 * xfns.c (x_window): Make sprintf buffer a bit bigger
1347 to avoid potential buffer overrun.
1348
ae58ff1f
PE
1349 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1350
c43c8a6a
PE
1351 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1352
3f8236f4
PE
13532011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1354
53e9fe90 1355 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1356 Without these, Emacs silently mishandles large integers sometimes.
1357 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1358 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1359
6511acf2
PE
1360 * xdisp.c (try_window_id): Check Emacs fixnum range before
1361 converting to 'int'.
806add1d 1362
6511acf2 1363 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1364 Check that an Emacs fixnum is in range before assigning it to 'int'.
1365 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1366 values converted from Emacs fixnums.
1367 (Frecenter): Don't wrap around a line count if it is out of 'int'
1368 range; instead, treat it as an extreme value.
1369 (Fset_window_configuration, compare_window_configurations):
1370 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1371
6511acf2
PE
1372 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1373 that can exceed INT_MAX. Check that EMACS_INT value is in range
1374 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1375 (match_limit): Don't assume that a fixnum can fit in 'int'.
1376
6511acf2 1377 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1378 exceed INT_MAX.
1379
6511acf2 1380 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1381 (Fvertical_motion): Don't wrap around LINES values that don't fit
1382 in 'int'. Instead, treat them as extreme values. This is good
1383 enough for windows, which can't have more than INT_MAX lines anyway.
1384
fcb901a7
LMI
13852011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1386
0f2f6b6d
LMI
1387 * Require libxml/parser.h to avoid compilation warning.
1388
fcb901a7
LMI
1389 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1390
1391 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1392 since this reportedly can destroy thread storage.
1393
6e20a0d4
CY
13942011-08-30 Chong Yidong <cyd@stupidchicken.com>
1395
1396 * syntax.c (find_defun_start): Update all cache variables if
1397 exiting early (Bug#9401).
1398
148ae00e
EZ
13992011-08-30 Eli Zaretskii <eliz@gnu.org>
1400
f6cfbd8f
EZ
1401 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1402
148ae00e
EZ
1403 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1404 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1405 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1406
1407 * term.c (tty_append_glyph): New function.
1408 (produce_stretch_glyph): Static function and its prototype deleted.
1409
1410 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
1411 prototypes.
1412
c4a07a4c
PE
14132011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1414
1415 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1416 when checking :margin (Bug#9390).
1417 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1418 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1419 so that the name doesn't mislead. All uses changed.
1420
6bc8cd65
JB
14212011-08-28 Johan Bockgård <bojohan@gnu.org>
1422
1423 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1424 set_tty_hooks.
1425
dca4927e
EZ
14262011-08-27 Eli Zaretskii <eliz@gnu.org>
1427
1428 * xdisp.c (move_it_to): Don't bail out early when reaching
1429 position beyond to_charpos, if we are scanning backwards.
1430 (move_it_vertically_backward): When DY == 0, make sure we get to
1431 the first character in the line after the newline.
1432
f2cad773
PE
14332011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1434
1435 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1436 (ccl_driver): Do not generate an out-of-range pointer.
1437 (Fccl_execute_on_string): Remove unnecessary check for
1438 integer overflow, noted by Stefan Monnier in
1439 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1440 Remove a FIXME that didn't need fixing.
1441 Simplify the newly-introduced buffer reallocation code.
1442
0cae2cdb
JB
14432011-08-27 Juanma Barranquero <lekktu@gmail.com>
1444
1445 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1446
5fc295a4 14472011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1448
70c60eb2 1449 Integer and memory overflow issues (Bug#9196).
726e0ab1 1450
d31850da
PE
1451 * doc.c (get_doc_string): Rework so that
1452 get_doc_string_buffer_size is the actual buffer size, rather than
1453 being 1 less than the actual buffer size; this makes xpalloc more
1454 convenient.
1455
a69fbedb
PE
1456 * image.c (x_allocate_bitmap_record, cache_image):
1457 * xselect.c (Fx_register_dnd_atom):
1458 Simplify previous changes by using xpalloc.
1459
fe5c5d37
PE
1460 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1461 since either will do and ptrdiff_t is convenient with xpalloc.
1462
0065d054
PE
1463 * charset.c (charset_table_size)
1464 (struct charset_sort_data.priority): Now ptrdiff_t.
1465 (charset_compare): Don't overflow if priorities differ greatly.
1466 (Fsort_charsets): Don't assume list length fits in int.
1467 Check for size-calculation overflow when allocating sort data.
1468 (syms_of_charset): Allocate an initial charset table that is
1469 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1470
1471 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1472
1473 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1474 The actual value is always <= INT_MAX, and leaving it unsigned made
1475 overflow checking harder.
1476
1477 * dispextern.h (struct glyph_matrix.rows_allocated)
1478 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1479 with xpalloc. The values are still always <= INT_MAX.
1480
1481 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1482
1483 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1484 (SAFE_NALLOCA): New macro.
1485
1486 * region-cache.c (struct boundary.pos, find_cache_boundary)
1487 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1488 (set_cache_region, invalidate_region_cache)
1489 (revalidate_region_cache, know_region_cache, region_cache_forward)
1490 (region_cache_backward, pp_cache):
1491 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1492 so that ptrdiff_t * can be passed to xpalloc.
1493 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1494 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1495 (pp_cache): Don't assume cache_len fits in int.
1496 * region-cache.h: Adjust extern decls to match.
1497
1498 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1499 EMACS_INT, since either will do, for xpalloc.
1500
1501 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1502 (xnmalloc, xnrealloc, xpalloc): New functions.
1503
726e0ab1
PE
1504 * bidi.c (bidi_shelve_header_size): New constant.
1505 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1506 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1507
51f30bc5 1508 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1509 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1510 (overlay_strings):
1511 Don't update size of array until after memory allocation succeeds,
1512 because xmalloc/xrealloc may not return.
0065d054
PE
1513 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1514 now that we have proper integer overflow checking.
1515 (record_overlay_string, overlay_strings): Catch overflows when
1516 calculating size of overlay_str_buf.
726e0ab1 1517
0065d054
PE
1518 * callproc.c (Fcall_process): Check for size overflow when
1519 calculating size of args2.
1520 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1521 Normally we prefer signed values, but sticking with ptrdiff_t would
1522 require adding more-complicated checks.
726e0ab1
PE
1523
1524 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1525 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1526 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1527 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1528
1529 * character.c (Fstring): Check for size-calculation overflow.
1530
1531 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1532 unnecessary integer overflow. Check for size overflow.
1533 (encode_coding_object): Don't update size until xmalloc succeeds.
1534
1535 * composite.c (get_composition_id): Check for overflow in glyph
1536 length calculations.
1537
1538 Integer and memory overflow fixes for display code.
1539 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1540 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1541 (scrolling_window): Check for overflow in size calculations.
1542 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1543 Don't assume glyph table len fits in int.
1544 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1545 (row_table_size): Now ptrdiff_t, not int.
1546 (scrolling_window): Avoid overflow in size calculations.
1547 Don't update size until allocation succeeds.
1548 * fns.c (concat): Check for overflow in size calculations.
1549 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1550 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1551 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1552
1553 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1554 (get_doc_string): Check for size calculation overflow.
1555 Don't update size until allocation succeeds.
1556 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1557 EMACS_INT, where ptrdiff_t will do.
1558 (Fsubstitute_command_keys): Check for string overflow.
1559
1560 * editfns.c (set_time_zone_rule): Don't assume environment length
1561 fits in int.
1562 (message_length): Now ptrdiff_t, not int.
1563 (Fmessage_box): Don't update size until allocation succeeds.
1564 Don't assume message length fits in int.
1565 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1566
0065d054
PE
1567 * emacs.c (main): Do not reallocate argv, since there is a null at
1568 the end that can be overwritten, and this way there's no need to
1569 worry about size-calculation overflow.
1570 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1571
1572 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1573 alloc succeeds.
1574 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1575
1576 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1577 (x_set_scroll_bar_width, x_figure_window_size):
1578 Check for integer overflow.
1579 (x_set_alpha): Do not assume XINT fits in int.
1580
1581 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1582 This is for the members text_lines, text_cols, total_lines, total_cols,
1583 where the system imposes an 'int' limit.
1584
1585 * fringe.c (Fdefine_fringe_bitmap):
1586 Don't update size until alloc works.
1587
1588 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1589 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1590
1591 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1592 Check for size-calculation overflow.
1593 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1594 do, as we prefer signed integers.
1595 (id_to_widget.max_size, id_to_widget.used)
1596 (xg_store_widget_in_map, xg_remove_widget_from_map)
1597 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1598 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1599 Use and return ptrdiff_t, not int.
1600 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1601 * gtkutil.h: Change prototypes to match the above.
1602
1603 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1604 are duplicate now that they've been promoted to lisp.h.
1605 (x_allocate_bitmap_record, x_alloc_image_color)
1606 (make_image_cache, cache_image, xpm_load):
1607 Don't update size until alloc is done.
1608 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1609 (x_detect_edges):
3256efce 1610 Check for size calculation overflow.
726e0ab1
PE
1611 (ct_colors_allocated_max): New constant.
1612 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1613 overflow.
3256efce 1614
726e0ab1
PE
1615 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1616 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1617 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1618 Use ptrdiff_t, not int, to count maps.
1619 (read_char_minibuf_menu_prompt): Check for overflow in size
1620 calculations. Don't update size until allocation succeeds. Redo
1621 calculations to avoid overflow.
1622 * keyboard.h: Change prototypes to match the above.
1623
1624 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1625 to count maps.
1626 (current_minor_maps): Check for size calculation overflow.
1627 * keymap.h: Change prototypes to match the above.
1628
1629 * lread.c (read1, init_obarray): Don't update size until alloc done.
1630
1631 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1632 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1633
726e0ab1
PE
1634 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1635 Now ptrdiff_t, not int.
1636 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1637 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1638
1639 * process.c (Fnetwork_interface_list): Check for overflow
1640 in size calculation.
1641
1642 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1643
1644 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1645 overflow. Don't bother calling xmalloc when xrealloc will do.
1646
1647 * search.c (Freplace_match): Check for size calculation overflow.
1648 (Fset_match_data): Don't assume list lengths fit in 'int'.
1649
1650 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1651 for command line length. Do not attempt to address one before the
1652 beginning of an array, as that's not portable.
1653
1654 * term.c (max_frame_lines): Remove; unused.
1655 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1656 not int.
1657 (encode_terminal_code, calculate_costs): Check for size
1658 calculation overflow.
1659 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1660 table lengths and related sizes. Don't update size until alloc
1661 done. Redo calculations to avoid overflow.
1662 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1663
1664 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1665 subtracting pointers.
1666 (gobble_line): Check for overflow more carefully. Don't update size
1667 until alloc done.
1668
1669 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1670 Don't update size until alloc done.
1671 Redo size calculations to avoid overflow.
1672 Check for size calculation overflow.
0065d054 1673 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1674
1675 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1676 Use ptrdiff_t, not int, for sizes.
1677 (store_mode_line_noprop_char): Don't update size until alloc done.
1678
0065d054
PE
1679 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1680 Use ptrdiff_t, not int, for sizes.
1681 (Finternal_make_lisp_face, cache_face):
1682 Check for size calculation overflow.
1683 (cache_face): Treat size calculation overflows as if they were
1684 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1685
1686 * xfns.c (x_encode_text, x_set_name_internal)
1687 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1688 sizes, since they can exceed INT_MAX in size. Check for size
1689 calculation overflow.
1690
0065d054
PE
1691 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1692 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1693 Don't update size until alloc done.
1694
0065d054 1695 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1696 as sprintf is limited to int lengths.
1d526e2f 1697
252c5ee1
PE
1698 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1699 (X_LONG_MIN): New macros.
864d7ce7
PE
1700 Use them to make the following changes clearer.
1701 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1702 This change doesn't affect the value now, but it may help remind
1703 future maintainers not to raise the value too much later.
1704 (SELECTION_QUANTUM): Remove, replacing with ...
1705 (selection_quantum): ... new function, which avoids overflow.
1706 All uses changed.
1707 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1708 assumption that selection length fits in 'int'.
1709 (x_reply_selection_request, x_handle_selection_request)
1710 (x_get_window_property, receive_incremental_selection)
1711 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1712 (lisp_data_to_selection_data, clean_local_selection_data):
1713 Use ptrdiff_t, not int, to record length of selection.
1714 (x_reply_selection_request, x_get_window_property)
1715 (receive_incremental_selection, x_property_data_to_lisp):
1716 Redo calculations to avoid overflow.
1717 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1718 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1719 something.
1720 (x_get_window_property, receive_incremental_selection)
1721 (lisp_data_to_selection_data, x_property_data_to_lisp):
1722 Check for size-calculation overflow.
1723 (x_get_window_property, receive_incremental_selection)
1724 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1725 Don't store size until memory allocation succeeds.
1726 (x_get_window_property): Plug memory leak on memory exhaustion.
1727 Don't double-block input; malloc is safe here. Don't assume 2**34
1728 - 4 fits in unsigned long. Add an xassert to check
1729 XGetWindowProperty overflow. Be more careful about overflow
1730 calculations, and distinguish size from memory overflow better.
1731 (receive_incremental_selection): When tracing, don't assume
1732 unsigned int is less than INT_MAX.
1733 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1734 harmful) conversions of unsigned short to int.
1735 (lisp_data_to_selection_data): Don't assume that integers
1736 in the range -65535 through -1 fit in an X unsigned short.
1737 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1738 result parameters unless successful. Rely on cons_to_unsigned
1739 to report problems with elements; the old code wasn't right anyway.
1740 (x_check_property_data): Check for int overflow; we cannot use
1741 a wider type due to X limits.
1742 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1743
726e0ab1 1744 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1745
0065d054
PE
1746 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1747 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1748 (x_color_cells): Don't store size until memory allocation succeeds.
1749 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1750 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1751 (x_term_init): Don't assume length fits in int (sprintf is limited
1752 to int size).
bc18e09d 1753
ebfa62c0
PE
1754 Use ptrdiff_t for composition IDs.
1755 * character.c (lisp_string_width):
1756 * composite.c (composition_table_size, n_compositions)
1757 (get_composition_id, composition_gstring_from_id):
1758 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1759 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1760 * window.c (Frecenter):
1761 Use ptrdiff_t, not int, for composition IDs.
1762 * composite.c (get_composition_id): Check for integer overflow.
1763 * composite.h: Adjust prototypes to match the above changes.
1764
d3411f89
PE
1765 Use ptrdiff_t for hash table indexes.
1766 * category.c (hash_get_category_set):
1767 * ccl.c (ccl_driver):
1768 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1769 * coding.c (coding_system_charset_list, detect_coding_system):
1770 * coding.h (struct coding_system.id):
1771 * composite.c (get_composition_id, gstring_lookup_cache):
1772 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1773 * image.c (xpm_get_color_table_h):
1774 * lisp.h (hash_lookup, hash_put):
1775 * minibuf.c (Ftest_completion):
1776 Use ptrdiff_t for hash table indexes, not int (which is too
1777 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1778 32-bit --with-wide-int hosts).
1779
e097a6fa
PE
1780 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1781 Add a FIXME comment about memory leaks.
1782 (syms_of_charset): Don't assume xmalloc returns.
1783
5637687f
PE
1784 Don't assume that stated character widths fit in int.
1785 * character.c (Fchar_width, c_string_width, lisp_string_width):
1786 * character.h (CHAR_WIDTH):
1787 * indent.c (MULTIBYTE_BYTES_WIDTH):
1788 Use sanitize_char_width to avoid undefined and/or bad behavior
1789 with outlandish widths.
1790 * character.h (sanitize_tab_width): Renamed from sanitize_width,
1791 now that we have two such functions. All uses changed.
1792 (sanitize_char_width): New inline function.
1793
a2271ba2
PE
1794 Don't assume that tab-width fits in int.
1795 * character.h (sanitize_width): New inline function.
1796 (SANE_TAB_WIDTH): New macro.
1797 (ASCII_CHAR_WIDTH): Use it.
1798 * indent.c (sane_tab_width): Remove. All uses replaced by
1799 SANE_TAB_WIDTH (current_buffer).
1800 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1801
18c52557
PE
1802 * fileio.c: Integer overflow issues with file modes.
1803 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1804
caeeedc1
PE
1805 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1806 Remove unreachable code.
1807 (read_hex, load_charset_map_from_file): Check for integer overflow.
1808
50849c52
PE
1809 * xterm.c: don't go over XClientMessageEvent limit
1810 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1811 (x_send_scroll_bar_event): Likewise. Check that the size does not
1812 exceed limits imposed by XClientMessageEvent, as well as the usual
1813 ptrdiff_t and size_t limits.
1814
b13995db
PE
1815 * keyboard.c: Overflow, signedness and related fixes.
1816 (make_lispy_movement): Use same integer type in forward decl
1817 that is used in the definition.
1818 (read_key_sequence, keyremap_step):
1819 Change bufsize argument back to int, undoing my 2011-03-30 change.
1820 We prefer signed types, and int is wide enough here.
1821 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1822 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1823 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1824 length, not size_t. Use ptrdiff_t for index, not int.
1825 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1826 possibility of integer overflow.
1827
13464394
PE
1828 Overflow, signedness and related fixes for images.
1829
1830 * dispextern.h (struct it.stack[0].u.image.image_id)
1831 (struct_it.image_id, struct image.id, struct image_cache.size)
1832 (struct image_cache.used, struct image_cache.ref_count):
1833 * gtkutil.c (update_frame_tool_bar):
1834 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1835 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1836 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1837 * nsmenu.m (update_frame_tool_bar):
1838 * xdisp.c (calc_pixel_width_or_height):
1839 * xfns.c (image_cache_refcount):
1840 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1841 on typical 64-bit hosts.
1842
1843 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1844 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1845 Omit unnecessary casts to int.
1846 (parse_image_spec): Check that integers fall into 'int' range
1847 when the callers expect that.
1848 (image_ascent): Redo ascent calculation to avoid int overflow.
1849 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1850 (lookup_image): Remove unnecessary tests.
1851 (xbm_image_p): Locals are now of int, not EMACS_INT,
1852 since parse_image_check makes sure they fit into int.
1853 (png_load, gif_load, svg_load_image):
1854 Prefer int to unsigned where either will do.
1855 (tiff_handler): New function, combining the cores of the
1856 old tiff_error_handler and tiff_warning_handler. This
1857 function is rewritten to use vsnprintf and thereby avoid
1858 stack buffer overflows. It uses only the features of vsnprintf
1859 that are common to both POSIX and native Microsoft.
1860 (tiff_error_handler, tiff_warning_handler): Use it.
1861 (tiff_load, gif_load, imagemagick_load_image):
1862 Don't assume :index value fits in 'int'.
1863 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1864 (imagemagick_load_image): Check that crop parameters fit into
1865 the integer types that MagickCropImage accepts. Don't assume
1866 Vimagemagick_render_type has a nonnegative value. Don't assume
1867 size_t fits in 'long'.
1868 (gs_load): Use printmax_t to print the widest integers possible.
1869 Check for integer overflow when computing image height and width.
1870
c11821d4
EZ
18712011-08-26 Eli Zaretskii <eliz@gnu.org>
1872
1873 * xdisp.c (redisplay_window): Don't force window start if point
1874 will be invisible in the resulting window. (Bug#9324)
1875
0c95fcf7
EZ
18762011-08-25 Eli Zaretskii <eliz@gnu.org>
1877
1878 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1879 the display spec is of the form `(space ...)'.
1880 (handle_display_spec): Return the value returned by
1881 handle_single_display_spec, not just 1 or zero.
1882 (handle_single_display_spec): If the display spec is of the form
1883 `(space ...)', and specifies display in the text area, return 2
1884 rather than 1.
fee65a97 1885 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
1886 accurately, and prefer exact match for point under bidi. Don't
1887 advance `row' beyond the last row of the window.
0c95fcf7
EZ
1888
1889 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1890 into disp_prop; all users changed.
1891
1892 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1893 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1894 for the text covered by the display property.
1895
e4ed06f1
CY
18962011-08-25 Chong Yidong <cyd@stupidchicken.com>
1897
1898 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1899 Change return value to nil.
1900 (Frecord_buffer): Delete unused function.
1901
f67cdd7f
EZ
19022011-08-24 Eli Zaretskii <eliz@gnu.org>
1903
5980d4c6
EZ
1904 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1905 buffers, return left-to-right.
8610fe8b
EZ
1906 (set_cursor_from_row): Consider candidate row a win if its glyph
1907 represents a newline and point is on that newline. Fixes cursor
1908 positioning on the newline at EOL of R2L text within L2R
1909 paragraph, and vice versa.
1910 (try_cursor_movement): Check continued rows, in addition to
1911 continuation rows. Fixes unwarranted scroll when point enters a
1912 continued line of R2L text within an L2R paragraph, or vice versa.
1913 (cursor_row_p): Consider the case of point being equal to
1914 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1915 from the end of a short line to the beginning of a continued line
1916 of R2L text within L2R paragraph.
1917 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1918 composed characters.
5980d4c6 1919
f67cdd7f
EZ
1920 * bidi.c (bidi_check_type): Use xassert.
1921 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1922 members.
1923
bca633fb
EZ
19242011-08-23 Eli Zaretskii <eliz@gnu.org>
1925
1926 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1927 a character.
1928
4a5885a7
CY
19292011-08-23 Chong Yidong <cyd@stupidchicken.com>
1930
1931 * nsfont.m (ns_otf_to_script): Fix typo.
1932
0902a04e
KH
19332011-08-22 Kenichi Handa <handa@m17n.org>
1934
1935 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1936 extra slot even if the purpose is char-code-property-table.
1937
1a2e6670
EZ
19382011-08-23 Eli Zaretskii <eliz@gnu.org>
1939
8ddde651
EZ
1940 * xdisp.c (redisplay_window): When computing centering_position,
1941 account for the height of the header line. (Bug#8874)
1942
425cc014
EZ
1943 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1944 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1945 candidate is selected by the mouse, and that candidate has a
1946 composed character under the mouse.
1947
1a2e6670
EZ
1948 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1949 coordinates reported by pos-visible-in-window-p for a composed
1950 character in column zero.
1951
8b76d6f8
SM
19522011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1953
1954 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1955
dac347dd
EZ
19562011-08-22 Eli Zaretskii <eliz@gnu.org>
1957
1958 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1959 consider it a hit if to_charpos is anywhere in the range of the
1960 composed buffer positions.
1961
e013fb34
CY
19622011-08-22 Chong Yidong <cyd@stupidchicken.com>
1963
1964 * image.c (gif_load): Don't assume that each subimage has the same
1965 dimensions as the base image. Handle disposal method that is
1966 "undefined" by the gif spec (Bug#9335).
1967
bd1ba3e8
CY
19682011-08-20 Chong Yidong <cyd@stupidchicken.com>
1969
1970 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1971 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1972
54a1215b
EZ
19732011-08-19 Eli Zaretskii <eliz@gnu.org>
1974
823564e5
EZ
1975 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1976 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1977 from an Org mode buffer to a Speedbar frame.
1978
54a1215b
EZ
1979 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1980 a composition, take its buffer position from IT->cmp_it.charpos.
1981 Fixes cursor positioning at the beginning of a line that begins
1982 with a composed character.
1983
9778ebcc
EZ
19842011-08-18 Eli Zaretskii <eliz@gnu.org>
1985
0be6ee06
EZ
1986 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1987 character bidirectional type, use STRONG_L instead. Fixes crashes
1988 in a buffer produced by `describe-categories'.
1989
9778ebcc
EZ
1990 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1991 members before the level stack, so they would be saved and
1992 restored when copying iterator state. Fixes incorrect reordering
1993 around TABs covered by display properties.
1994
156bffbe
AS
19952011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1996
1997 * process.c (Fnetwork_interface_list): Correctly determine buffer
1998 size.
1999
72ad093b
CY
20002011-08-17 Chong Yidong <cyd@stupidchicken.com>
2001
2002 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2003 (internal_condition_case_2, internal_condition_case_n):
2004 Remove unnecessary aborts (Bug#9081).
72ad093b 2005
35774242
EZ
20062011-08-17 Eli Zaretskii <eliz@gnu.org>
2007
2008 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2009 has no `load' handler, try opening the file locally. (Bug#9311)
2010
db76dd85
KB
20112011-08-16 Ken Brown <kbrown@cornell.edu>
2012
2013 * gmalloc.c: Expand comment.
2014
b215eee5
EZ
20152011-08-16 Eli Zaretskii <eliz@gnu.org>
2016
2017 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2018 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2019
a4579d33
KB
20202011-08-16 Ken Brown <kbrown@cornell.edu>
2021
2022 Fix memory allocation problems in Cygwin build (Bug#9273).
2023
2024 * unexcw.c ( __malloc_initialized): Declare external variable.
2025 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2026
8b76d6f8
SM
2027 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2028 New variables.
a4579d33
KB
2029 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2030 dumped emacs.
2031 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2032 in the static heap.
2033 [CYGWIN] (special_realloc): New function.
2034 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2035 requests to realloc storage in the static heap.
2036
3ebec551
PE
20372011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2038
2039 * bidi.c (bidi_initialize): Remove unused local.
2040
9fd8be00
EZ
20412011-08-15 Eli Zaretskii <eliz@gnu.org>
2042
474a8465
EZ
2043 * biditype.h: File removed.
2044
2045 * bidimirror.h: File removed.
2046
2047 * deps.mk (bidi.o): Remove biditype.h and
2048 bidimirror.h.
2049
2050 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
2051 bidimirror.h.
2052
2053 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2054
2055 * chartab.c: Improve commentary for the uniprop_table API.
2056
32413314
EZ
2057 * bidi.c (bidi_paragraph_init): Support zero value of
2058 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2059 (bidi_initialize): Use uniprop_table instead of including
2060 biditype.h and bidimirror.h.
32413314 2061
9fd8be00
EZ
2062 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2063 coordinates of the iterator when restoring from ppos_it.
2064 (Bug#9296)
2065
5cf2b69b
KH
20662011-08-14 Kenichi Handa <handa@m17n.org>
2067
2068 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2069 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2070
daf17d00
EZ
20712011-08-14 Eli Zaretskii <eliz@gnu.org>
2072
2073 * xdisp.c (move_it_in_display_line_to): Don't invoke
2074 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2075 ppos_it. Fixes vertical cursor motion when line beginning is
2076 covered by an image. (Bug#9296)
2077
08e3161a
JD
20782011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2079
2080 * nsterm.h (ns_run_ascript): Declare.
2081 (NSAPP_DATA2_RUNASSCRIPT): Define.
2082
2083 * nsfns.m (as_script, as_result, as_status): New static variables.
2084 (ns_run_ascript): New function.
5e617bc2 2085 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2086 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2087 the event loop. Get status from as_status (Bug#7276).
2088
2089 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2090 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2091 the event loop (Bug#7276).
2092
a3720aa2
AS
20932011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2094
2095 * gnutls.c (QCgnutls_bootprop_priority)
2096 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2097 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2098 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2099 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2100 (QCgnutls_bootprop_verify_hostname_error)
2101 (QCgnutls_bootprop_callbacks_verify): Rename from
2102 Qgnutls_bootprop_..., all uses changed.
2103
2104 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2105 uses changed.
2106
0a0d27fb
PE
21072011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2108
19d5c50c
PE
2109 * xfaces.c (Qframe_set_background_mode): Now static.
2110 * dispextern.h (Qframe_set_background_mode): Remove decl.
2111
0a0d27fb
PE
2112 * process.c (Fnetwork_interface_info): Declare local only if needed.
2113
377538cb
JD
21142011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2115
2116 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2117 (Fnetwork_interface_list): Allocate in increments of bytes instead
2118 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2119 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2120 sockaddr.
2121 (struct ifflag_def): notrailers is smart on OSX.
2122 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2123 Get hardware address with getifaddrs if available.
2124
08fff70c
EZ
21252011-08-12 Eli Zaretskii <eliz@gnu.org>
2126
2127 * xdisp.c (iterate_out_of_display_property): xassert that
2128 IT->position is set to within IT->object's boundaries. Break from
2129 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2130 when IT->position is set up wrongly due to some bug.
2131 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2132 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2133 entry. Force push_it to save on the stack the current
2134 buffer/string position, to be restored by pop_it. Fix flags in
2135 the iterator structure wrt the object coming from a display
2136 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2137 properties. (Bug#9284)
2138
7be1c708 21392011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2140
7be1c708
CY
2141 * fontset.c (fontset_get_font_group): Add proper type checks.
2142 (Bug#9172)
aac0c6e3 2143
7be1c708 21442011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2145
7be1c708
CY
2146 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2147 and LC_VERSION_MIN_MACOSX.
2148 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2149 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2150
97bb72a6
EZ
21512011-08-08 Eli Zaretskii <eliz@gnu.org>
2152
2153 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2154 no-display-properties-and-no-overlays under bidi display.
2155 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2156 properties and overlays.
97bb72a6 2157
d5617611
CY
21582011-08-08 Chong Yidong <cyd@stupidchicken.com>
2159
37e11a63
CY
2160 * editfns.c (Fset_time_zone_rule): Document relationship with the
2161 setenv function.
2162
d5617611
CY
2163 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2164 the font entity extracted from the cache (Bug#8109).
2165
58872834
CY
21662011-08-07 Chong Yidong <cyd@stupidchicken.com>
2167
2168 * composite.c (autocmp_chars): Don't reset point. That is done by
2169 restore_point_unwind (Bug#5984).
2170
75bfc667
JL
21712011-08-07 Juri Linkov <juri@jurta.org>
2172
2173 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2174 to show the arg `TIME' instead of `TIMEVAL'.
2175
d1410150
EZ
21762011-08-06 Eli Zaretskii <eliz@gnu.org>
2177
2178 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2179 display property strides EOL and includes a newline, as in
2180 longlines-mode. (Bug#9254)
75b771e4
EZ
2181 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2182 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2183
2184 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2185 is non-zero, even if the data buffer is NULL. Fixes a crash in
2186 vertical-motion with longlines-mode. (Bug#9254)
2187
35928349
EZ
21882011-08-05 Eli Zaretskii <eliz@gnu.org>
2189
ec7cc85b
EZ
2190 * bidi.c <bidi_cache_total_alloc>: Now static.
2191 (bidi_initialize): Initialize bidi_cache_total_alloc.
2192
8b76d6f8 2193 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2194 cache. (Bug#9221)
2195
2196 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2197 amount allocated this far in `bidi_cache_total_alloc'.
2198 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2199 non-zero, only free the data buffer without restoring the cache
2200 contents. All callers changed.
2201
2202 * dispextern.h (bidi_unshelve_cache): Update prototype.
2203
2204 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2205 (move_it_in_display_line, move_it_to)
2206 (move_it_vertically_backward, move_it_by_lines): Replace the call
2207 to xfree to an equivalent call to bidi_unshelve_cache.
2208 (move_it_in_display_line_to): Fix logic of returning
412b6358 2209 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2210
e2e2423b
EZ
22112011-08-05 Eli Zaretskii <eliz@gnu.org>
2212
2213 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2214 came from a string character with a `cursor' property. (Bug#9229)
2215
ae9e757a
JD
22162011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2217
2218 * Makefile.in (LIB_PTHREAD): New variable.
2219 (LIBES): Add LIB_PTHREAD (Bug#9216).
2220
2221 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2222 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2223
213bd7f2
AS
22242011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2225
2226 * regex.c (re_iswctype): Remove some redundant boolean
2227 conversions.
2228
99aaf75f
JD
22292011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2230
2231 * xterm.c (x_find_topmost_parent): New function.
2232 (x_set_frame_alpha): Find topmost parent window with
2233 x_find_topmost_parent and set the property there also (bug#9181).
2234 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2235
c74e9d86
PE
22362011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2237
2238 * callproc.c (Fcall_process): Avoid vfork clobbering
2239 the local vars buffer, coding_systems, current_dir.
2240
640c8776
SM
22412011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2242
2243 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2244
f26d0e4c
PE
22452011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2246
8a10d76c
PE
2247 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2248 so that it is not optimized away.
2249
f26d0e4c
PE
2250 * xdisp.c (compute_display_string_pos): Remove unused local.
2251
55439c61
EZ
22522011-08-02 Eli Zaretskii <eliz@gnu.org>
2253
2254 Fix slow cursor motion and scrolling in large buffers with
2255 selective display, like Org Mode buffers. (Bug#9218)
2256
2257 * dispextern.h (struct bidi_it): New member disp_prop_p.
2258
2259 * xdisp.c: Remove one-slot cache of display string positions.
2260 (compute_display_string_pos): Accept an additional argument
5e617bc2 2261 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2262 for a display string or property. If found, set DISP_PROP_P
2263 non-zero.
2264
2265 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2266 DISP_PROP_P, and pass it to compute_display_string_pos.
2267 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2268 non-zero. All callers of bidi_fetch_char changed.
2269
fb33fa43
SM
22702011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2271
2272 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2273
b099e063
DM
22742010-12-03 Don March <don@ohspite.net>
2275
2276 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2277 last character M-[char] is translated to ESC [char] (bug#7541).
2278
5cc7f7af
KH
22792011-08-02 Kenichi Handa <handa@m17n.org>
2280
d0fffa3f 2281 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2282
2283 * chartab.c (uniprop_table): Make it non-static.
2284
525d5e6e
EZ
22852011-08-01 Eli Zaretskii <eliz@gnu.org>
2286
2287 * xdisp.c (forward_to_next_line_start): Accept additional argument
2288 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2289 on the newline.
2290 (reseat_at_next_visible_line_start): Use the bidi iterator state
2291 returned by forward_to_next_line_start to restore the state of
2292 it->bidi_it after backing up to previous newline. (Bug#9212)
2293
31011111
AS
22942011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2295
2296 * regex.c (re_comp): Protoize.
2297 (re_exec): Fix return type.
2298 (regexec): Fix type of `ret'. (Bug#9203)
2299
476371c4
PE
23002011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2301
e5d76069
PE
2302 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2303 This is needed if max-image-size is a floating-point number.
2304
9a79b20c
AS
23052011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2306
2307 * print.c (print_object): Print empty symbol as ##.
2308
2309 * lread.c (read1): Read ## as empty symbol.
2310
d8c2fa78
AA
23112011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2312
2313 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2314 setting frame foreground color (Bug#9175).
2315 (x_set_background_color): Likewise.
2316
ffe57a7a
AA
2317 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2318 contents (Bug#9176).
2319 (EmacsTooltip -init): Remove bezels and add shadows to
2320 tooltip windows.
2321
bf3492a5
AA
2322 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2323 or scroll bar (Bug#8470).
2324
d55e9c53
AA
2325 * nsfont.m (nsfont_open): Remove assignment to voffset and
2326 unnecessary vars hshink, expand, hd, full_height, min_height.
2327 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2328
2329 * nsterm.h (nsfont_info): Remove voffset field.
2330
d8c2fa78 23312011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2332
2333 Implement strike-through and overline on NextStep (Bug#8863).
2334
2335 * nsfont.m (nsfont_open): Use underline position provided by font,
2336 instead of hard-coded value of 2.
2337 (nsfont_draw): Call ns_draw_text_decoration instead.
2338
2339 * nsterm.h: Add declaration for ns_draw_text_decoration.
2340
2341 * nsterm.m (ns_draw_text_decoration): New function for drawing
2342 underline, overline, and strike-through.
2343 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2344 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2345 accommodate underlining, etc.
4843aac3 2346
4cc60b9b
EZ
23472011-07-28 Eli Zaretskii <eliz@gnu.org>
2348
bc7ece87
EZ
2349 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2350 default.
4cc60b9b 2351
476371c4
PE
23522011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2353
66606eea
PE
2354 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2355 Without this fix, if a signal arrives just after memory fills up,
2356 'malloc' might be invoked reentrantly.
2357
476371c4
PE
2358 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2359 In other words, assume that every image size is allowed, on non-X
2360 hosts. This assumption is probably wrong, but it lets Emacs compile.
2361
f3fcc40d
AS
23622011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2363
2364 * regex.c (re_iswctype): Convert return values to boolean.
2365
350c992f
EZ
23662011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2367
2368 * xdisp.c (compute_display_string_pos): Don't use cached display
2369 string position if the buffer had its restriction changed.
2370 (Bug#9184)
2371
5266b4bb
PE
23722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2373
2374 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2375
2573a837 23762011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2377
41f55ccd 2378 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2379
39e378da
PE
2380 * bidi.c: Integer size and overflow fixes.
2381 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2382 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2383 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2384 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2385 (bidi_find_other_level_edge):
2386 Use ptrdiff_t instead of EMACS_INT where either will do.
2387 This works better on 32-bit hosts configured --with-wide-int.
2388 (bidi_cache_ensure_space): Check for size-calculation overflow.
2389 Use % rather than repeated addition, for better worst-case speed.
2390 Don't set bidi_cache_size until after xrealloc returns, because it
2391 might not return.
2392 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2393 (bidi_cache_ensure_space): Also check that the bidi cache size
2394 does not exceed that of the largest Lisp string or buffer. See Eli
2395 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2396
5e927815
PE
2397 * alloc.c (__malloc_size_t): Remove.
2398 All uses replaced by size_t. See Andreas Schwab's note
2399 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2400
ca4aa935
PE
2401 * image.c: Improve checking for integer overflow.
2402 (check_image_size): Assume that f is nonnull, since
2403 it is always nonnull in practice. This is one less thing to
2404 worry about when checking for integer overflow later.
2405 (x_check_image_size): New function, which checks for integer
2406 overflow issues inside X.
2407 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2408 This removes the need for a memory_full check.
2409 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2410 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2411 (xbm_read_bitmap_data): Change locals back to 'int', since
2412 their values must fit in 'int'.
2413 (xpm_load_image, png_load, tiff_load):
2414 Invoke x_create_x_image_and_pixmap earlier,
2415 to avoid much needless work if the image is too large.
2416 (tiff_load): Treat overly large images as if
2417 x_create_x_image_and_pixmap failed, not as malloc failures.
2418 (gs_load): Use x_check_image_size.
2419
5f8f9cc2
PE
2420 * gtkutil.c: Omit integer casts.
2421 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2422 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2423
5adf60bc
PE
2424 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2425
c8907a93
PE
2426 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2427 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2428 would wrongly return t on a 64-bit host.
2429
e3c25c68
PE
2430 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2431 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2432 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2433 and therefore cause GCC to emit a bogus diagnostic in some cases.
2434
3f791afe
PE
2435 * image.c: Integer signedness and overflow and related fixes.
2436 This is not an exhaustive set of fixes, but it's time to
2437 record what I've got.
2438 (lookup_pixel_color, check_image_size): Remove redundant decls.
2439 (check_image_size): Don't assume that arbitrary EMACS_INT values
2440 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2441 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2442 (tiff_load, imagemagick_load_image):
2443 Check for overflow in size calculations.
2444 (x_create_x_image_and_pixmap): Remove unnecessary test for
2445 xmalloc returning NULL; that can't happen.
2446 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2447 (xpm_color_bucket): Use better integer hashing function.
2448 (xpm_cache_color): Don't possibly over-allocate memory.
2449 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2450 (gif_memory_source):
2451 Use ptrdiff_t, not int or size_t, to record sizes.
2452 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2453 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2454 either works, as we prefer signed integers.
2455 (tiff_read_from_memory, tiff_write_from_memory):
2456 Return tsize_t, not size_t, since that's what the TIFF API wants.
2457 (tiff_read_from_memory): Don't fail simply because the read would
2458 go past EOF; instead, return a short read.
2459 (tiff_load): Omit no-longer-needed casts.
2460 (Fimagemagick_types): Don't assume size fits into 'int'.
2461
3cc5a532
PE
2462 Improve hashing quality when configured --with-wide-int.
2463 * fns.c (hash_string): New function, taken from sxhash_string.
2464 Do not discard information about ASCII character case; this
2465 discarding is no longer needed.
2466 (sxhash-string): Use it. Change sig to match it. Caller changed.
2467 * lisp.h: Declare it.
2468 * lread.c (hash_string): Remove, since we now use fns.c's version.
2469 The fns.c version returns a wider integer if --with-wide-int is
2470 specified, so this should help the quality of the hashing a bit.
2471
b312a492
PE
2472 * emacs.c: Integer overflow minor fix.
2473 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2474 Define only if GNU_LINUX.
2475 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2476
dfd153ae
PE
2477 * dispnew.c: Integer signedness and overflow fixes.
2478 Remove unnecessary forward decls, that were a maintenance hassle.
2479 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2480 All uses changed.
2481 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2482 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2483 (prepare_desired_row, line_draw_cost):
2484 Use int, not unsigned, where either works.
2485 (save_current_matrix, restore_current_matrix):
2486 Use ptrdiff_t, not size_t, where either works.
2487 (init_display): Check for overflow more accurately, and without
2488 relying on undefined behavior.
2489
a81d11a3
PE
2490 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2491 Remove, replacing with the new symbols in lisp.h. All uses changed.
2492 * fileio.c (make_temp_name):
2493 * filelock.c (lock_file_1, lock_file):
2494 * xdisp.c (message_dolog):
2495 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2496 Use pMd etc. instead.
2497 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2498 replacing the pWIDE etc. symbols removed from editfns.c.
2499
3300e6fd
PE
2500 * keyboard.h (num_input_events): Now uintmax_t.
2501 This is (very slightly) less likely to mess up due to wraparound.
2502 All uses changed.
2503
fd05c7e9
PE
2504 * buffer.c: Integer signedness fixes.
2505 (alloc_buffer_text, enlarge_buffer_text):
2506 Use ptrdiff_t rather than size_t when either will do, as we prefer
2507 signed integers.
2508
903fe15d
PE
2509 * alloc.c: Integer signedness and overflow fixes.
2510 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2511 (__malloc_size_t): Default to size_t, not to int.
2512 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2513 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2514 Prefer ptrdiff_t to size_t when either would do, as we prefer
2515 signed integers.
2516 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2517 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2518 Now const. Initialize with values that are in range even if char
2519 is signed.
2520 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2521 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2522 These functions do the right thing with sizes > 2**32.
2523 (check_depth): Now ptrdiff_t, not int.
2524 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2525 Adjust to new way of storing sizes. Check for size overflow bugs
2526 in rest of code.
2527 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2528 slightly wrong anyway, as it missed one instance of
2529 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2530 (refill_memory_reserve): Omit needless cast to size_t.
2531 (mark_object_loop_halt): Mark as externally visible.
2532
ac82cc6a
PE
2533 * xselect.c: Integer signedness and overflow fixes.
2534 (Fx_register_dnd_atom, x_handle_dnd_message):
2535 Use ptrdiff_t, not size_t, since we prefer signed.
2536 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2537 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2538 x_dnd_atoms_size and x_dnd_atoms_length.
2539
c2d1e36d
PE
2540 * doprnt.c: Prefer signed to unsigned when either works.
2541 * eval.c (verror):
2542 * doprnt.c (doprnt):
2543 * lisp.h (doprnt):
2544 * xdisp.c (vmessage):
2545 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2546 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2547 prefer signed arithmetic to avoid comparison confusion.
2548 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2549 but is a bit tricky.
2550
0e926e56
PE
2551 Assume freestanding C89 headers, string.h, stdlib.h.
2552 * data.c, doprnt.c, floatfns.c, print.c:
2553 Include float.h unconditionally.
2554 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2555 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2556 * regex.c: Likewise for stddef.h, string.h.
2557 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2558 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2559 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2560 (STDC_HEADERS): Remove obsolete defines.
2561 * sysdep.c: Include limits.h unconditionally.
2562
9cfdb3ec
PE
2563 Assume support for memcmp, memcpy, memmove, memset.
2564 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2565 * regex.c (memcmp, memcpy):
2566 Remove; we assume C89 now.
2567
2568 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2569 (__malloc_safe_bcopy): Remove; no longer needed.
2570
cf950e6b 2571 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2572 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2573 well either way, and we prefer signed to unsigned.
2574
dbf38e02
LMI
25752011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2576
2577 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2578 closes the connection while we're reading (bug#9182).
2579
d6f0886c 25802011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2581
d6f0886c
JD
2582 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2583 are specified (Bug#9168).
24e0f6b1 2584
2eb1f9e6
PE
25852011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2586
2587 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2588 Found by GCC static checking and --with-wide-int on a 32-bit host.
2589
22381272 25902011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2591
2592 * xdisp.c (compute_display_string_pos): Fix logic of caching
2593 previous display string position. Initialize cached_prev_pos to
2594 -1. Fixes slow-down at the beginning of a buffer.
2595
f25e39b4
EZ
25962011-07-24 Eli Zaretskii <eliz@gnu.org>
2597
2598 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2599 for attrs[LFACE_FONTSET_INDEX].
2600
04c4b52e
PE
26012011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2602
2603 * xml.c (parse_region): Remove unused local
2604 that was recently introduced.
2605
c1734fbd
EZ
26062011-07-23 Eli Zaretskii <eliz@gnu.org>
2607
be18c5a5
EZ
2608 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2609 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2610
c1734fbd
EZ
2611 * xdisp.c (move_it_in_display_line_to): Record the best matching
2612 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2613 exit if none of the characters scanned was an exact match.
2614 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2615 when exact match is impossible due to invisible text, and the
2616 lines are truncated.
2617
a258d627
JD
26182011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2619
2620 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2621 for OSX >= 10.7.
2622
b6d5a689
EZ
26232011-07-22 Eli Zaretskii <eliz@gnu.org>
2624
0f74f785
EZ
2625 Fix a significant slow-down of cursor motion with C-n, C-p,
2626 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2627 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2628 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2629 (next_element_from_buffer): Call compute_stop_pos_backwards to
2630 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2631 base_level_stop.
2632 (reseat): Don't look for prev_stop, as that could mean a very long
2633 run.
2634 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2635 <cached_disp_overlay_modiff>: Cache for last found display string
2636 position.
551918c1 2637 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2638 about the same buffer in the same area of character positions, and
2639 the buffer wasn't changed since the time the display string
2640 position was cached.
551918c1 2641
b2d0c91a
EZ
26422011-07-22 Eli Zaretskii <eliz@gnu.org>
2643
2644 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2645 is an integer, which is important for empty lines. (Bug#9149)
2646
043604ee
CY
26472011-07-22 Chong Yidong <cyd@stupidchicken.com>
2648
2649 * frame.c (Fmodify_frame_parameters): In tty case, update the
2650 default face if necessary (Bug#4238).
2651
da4adb04
CY
26522011-07-21 Chong Yidong <cyd@stupidchicken.com>
2653
2654 * editfns.c (Fstring_to_char): No need to explain what a character
2655 is in the docstring (Bug#6576).
2656
9abd0532
LMI
26572011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2658
2659 * xml.c (parse_region): Make sure we always return a tree.
2660
36881d16
HK
26612011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2662
2663 * xml.c (parse_region): If a document contains only comments,
2664 return that, too.
2665
1e98674d
LMI
26662011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2667
2668 * xml.c (make_dom): Return comments, too.
2669
590bd467
PE
26702011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2671
2672 Port to OpenBSD.
2673 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2674 and the surrounding thread.
2675 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2676 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2677 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2678 timer goes off.
2679 * s/openbsd.h (BROKEN_SIGIO): Define.
2680 * unexelf.c (unexec) [__OpenBSD__]:
2681 Don't update the .mdebug section of the Alpha COFF symbol table.
2682
f41628b2
LMI
26832011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2684
2685 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2686 (bug#8460).
2687
b59b67c5
PE
26882011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2689
15e3a074
PE
2690 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2691 This fixes some race conditions on the permissions of any newly
2692 created file.
2693
41bed37d
PE
2694 * alloc.c (valid_pointer_p): Use pipe, not open.
2695 This fixes some permissions issues when debugging.
2696
b59b67c5
PE
2697 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2698 If fchown fails to set both uid and gid, try to set just gid,
2699 as that is sometimes allowed. Adjust the file's mode to eliminate
2700 setuid or setgid bits that are inappropriate if fchown fails.
2701
925a6be7
SM
27022011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2703
2704 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2705 to compare Lisp_Objects.
2706 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2707 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2708 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2709
52968808
AS
27102011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2711
0a6a104b
AS
2712 * lread.c (read_integer): Unread even EOF character.
2713 (read1): Likewise. Properly record start position of symbol.
2714
52968808
AS
2715 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2716 symbol character follows.
2717
9e381cdd
PE
27182011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2719
2720 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2721 This works around a problem with the previous change to Fcopy_file.
2722 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2723 and without this change, GCC might complain about discarding
2724 fchown's return value.
2725
b5641435
JB
27262011-07-16 Juanma Barranquero <lekktu@gmail.com>
2727
2728 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2729
a8031457
PE
27302011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2731
2732 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2733
dd889327
LMI
27342011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2735
750c33f7
LMI
2736 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2737 it's used from the C level.
2738
dd889327
LMI
2739 * process.c: Use the same condition for POLL_FOR_INPUT in both
2740 keyboard.c and process.c (bug#1858).
2741
87e86684
LM
27422011-07-09 Lawrence Mitchell <wence@gmx.li>
2743
2744 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2745 (Fgnutls_boot): Use it.
2746
64348f40
AS
27472011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2748
2749 * doc.c (Fsubstitute_command_keys): Revert last change.
2750
1d698799
LMI
27512011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2752
f863868c
LMI
2753 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2754 quotes the next character, and doesn't affect other longer
2755 sequences (bug#8935).
2756
1d698799
LMI
2757 * lread.c (syms_of_lread): Clarify that is isn't only
2758 `eval-buffer' and `eval-defun' that's affected by
2759 `lexical-binding' (bug#8460).
2760
aa4b6df6
EZ
27612011-07-15 Eli Zaretskii <eliz@gnu.org>
2762
2763 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2764 bidi redisplay when a line includes both an image and is
2765 truncated.
2766
5d856da6
PE
27672011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2768
ad6042bb
PE
2769 Fix minor problems found by static checking.
2770 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2771 (elsz): Now a signed constant, not a size_t var. We prefer signed
2772 types to unsigned, to avoid integer comparison confusion. Without
2773 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2774 "cannot optimize loop, the loop counter may overflow", a symptom
2775 of the confusion.
f00bbb22 2776 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2777 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2778
6468f31c
LMI
27792011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2780
49080b10
LMI
2781 * search.c (Fre_search_backward): Mention `case-fold-search' in
2782 all the re_search_* functions (bug#8138).
2783
6468f31c
LMI
2784 * keyboard.c (Fopen_dribble_file): Document when the file is
2785 closed (bug#8056).
2786
c965adc5
EZ
27872011-07-14 Eli Zaretskii <eliz@gnu.org>
2788
df9733bf
EZ
2789 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2790 bidi_cache_idx.
2791
0bb23927
EZ
2792 Support bidi reordering of display and overlay strings.
2793 * xdisp.c (compute_display_string_pos)
2794 (compute_display_string_end): Accept additional argument STRING.
2795 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2796 (reseat_to_string): Initialize bidi_it->string.s and
2797 bidi_it->string.schars.
2798 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2799 NULL (avoids a crash in bidi_paragraph_init).
2800 Initialize itb.string.lstring.
0bb23927
EZ
2801 (init_iterator): Call bidi_init_it only of a valid
2802 buffer position was specified. Initialize paragraph_embedding to
2803 L2R.
2804 (reseat_to_string): Initialize the bidi iterator.
2805 (display_string): If we need to ignore text properties of
2806 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2807 original value of -1 will not work with bidi.)
2808 (compute_display_string_pos): First arg is now struct
2809 `text_pos *'; all callers changed. Support display properties on
2810 Lisp strings.
2811 (compute_display_string_end): Support display properties on Lisp
2812 strings.
2813 (init_iterator, reseat_1, reseat_to_string): Initialize the
2814 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2815 when iterating on a string not from display properties).
640c8776
SM
2816 (compute_display_string_pos, compute_display_string_end):
2817 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2818 arrow keys.
2819 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2820 base_level_stop; instead, set base_level_stop to BEGV.
2821 Fixes crashes in vertical-motion.
0bb23927
EZ
2822 (next_element_from_buffer): Improve commentary for when
2823 the iterator is before prev_stop.
2824 (init_iterator): Initialize bidi_p from the default value of
2825 bidi-display-reordering, not from buffer-local value. Use the
2826 buffer-local value only if initializing for buffer iteration.
2827 (handle_invisible_prop): Support invisible properties on strings
2828 that are being bidi-reordered.
2829 (set_iterator_to_next): Support bidi reordering of C strings and
2830 Lisp strings.
2831 (next_element_from_string): Support bidi reordering of Lisp
2832 strings.
2833 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2834 (display_string): Support display of R2L glyph rows.
2835 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2836 (init_iterator): Don't initialize it->bidi_p for strings
2837 here.
2838 (reseat_to_string): Initialize it->bidi_p for strings here.
2839 (next_element_from_string, next_element_from_c_string)
2840 (next_element_from_buffer): Add xassert's for correspondence
2841 between IT's object being iterated and it->bidi_it.string
2842 structure.
2843 (face_before_or_after_it_pos): Support bidi iteration.
2844 (next_element_from_c_string): Handle the case of the first string
2845 character that is not the first one in the visual order.
2846 (get_visually_first_element): New function, refactored from common
2847 parts of next_element_from_buffer, next_element_from_string, and
2848 next_element_from_c_string.
2849 (tool_bar_lines_needed, redisplay_tool_bar)
2850 (display_menu_bar): Force left-to-right direction. Add a FIXME
2851 comment for making that be controlled by a user option.
2852 (push_it, pop_it): Save and restore the state of the
2853 bidi iterator. Save and restore the bidi_p flag.
2854 (pop_it): Iterate out of display property for string iteration as
2855 well.
2856 (iterate_out_of_display_property): Support iteration over strings.
2857 (handle_single_display_spec): Set up it->bidi_it for iteration
2858 over a display string, and call bidi_init_it.
2859 (handle_single_display_spec, next_overlay_string)
2860 (get_overlay_strings_1, push_display_prop): Set up the bidi
2861 iterator for displaying display or overlay strings.
2862 (forward_to_next_line_start): Don't use the shortcut if
2863 bidi-iterating.
2864 (back_to_previous_visible_line_start): If handle_display_prop
2865 pushed the iterator stack, restore the internal state of the bidi
2866 iterator by calling bidi_pop_it same number of times.
2867 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2868 and we are bidi-iterating, don't decrement the iterator position;
2869 instead, set the first_elt flag in the bidi iterator, to produce
2870 the same effect.
2871 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2872 (push_display_prop): xassert that we are iterating a buffer.
2873 (push_it, pop_it): Save and restore paragraph_embedding member.
2874 (handle_single_display_spec, next_overlay_string)
2875 (get_overlay_strings_1, reseat_1, reseat_to_string)
2876 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2877 correctly. Don't assume unibyte strings are not bidi-reordered.
2878 (compute_display_string_pos)
2879 (compute_display_string_end): Fix handling the case of C string.
2880 (push_it, pop_it): Save and restore from_disp_prop_p.
2881 (handle_single_display_spec, push_display_prop): Set the
2882 from_disp_prop_p flag.
2883 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2884 (pop_it): Call iterate_out_of_display_property only if we are
2885 popping after iteration over a string that came from a display
2886 property. Fix a typo in popping stretch info. Add an assertion
2887 for verifying that the iterator position is in sync with the bidi
2888 iterator.
2889 (handle_single_display_spec, get_overlay_strings_1)
2890 (push_display_prop): Fix initialization of paragraph direction for
2891 string when that of the parent object is not yet determined.
2892 (reseat_1): Call bidi_init_it to resync the bidi
2893 iterator with IT's position. (Bug#7616)
2894 (find_row_edges): If ROW->start.pos gives position
2895 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2896 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2897 Reset the from_disp_prop_p flag.
2898 (SAVE_IT, RESTORE_IT): New macros.
2899 (pos_visible_p, face_before_or_after_it_pos)
2900 (back_to_previous_visible_line_start)
2901 (move_it_in_display_line_to, move_it_in_display_line)
2902 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2903 (try_scrolling, redisplay_window, display_line): Use them when
2904 saving a temporary copy of the iterator and restoring it back.
2905 (back_to_previous_visible_line_start, reseat_1)
2906 (init_iterator): Empty the bidi cache "stack".
2907 (move_it_in_display_line_to): If iterator ended up at
2908 EOL, but we never saw any buffer positions smaller than
2909 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2910 motion in bidi-reordered lines.
2911 (move_it_in_display_line_to): Record prev_method and prev_pos
2912 immediately before the call to set_iterator_to_next. Fixes cursor
2913 motion in bidi-reordered lines with stretch glyphs and strings
2914 displayed in margins. (Bug#8133) (Bug#8867)
2915 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2916 TO_CHARPOS.
640c8776
SM
2917 (pos_visible_p): Support positions in bidi-reordered lines.
2918 Save and restore bidi cache.
0bb23927
EZ
2919
2920 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2921 (bidi_paragraph_info): Delete unused struct.
2922 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2923 (bidi_cache_start): New variable.
2924 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2925 to zero.
2926 (bidi_cache_fetch_state, bidi_cache_search)
2927 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2928 (bidi_cache_find, bidi_peek_at_next_level)
2929 (bidi_level_of_next_char, bidi_find_other_level_edge)
2930 (bidi_move_to_visually_next): Compare cache index with
2931 bidi_cache_start rather than with zero.
2932 (bidi_fetch_char): Accept new argument STRING; all callers
2933 changed. Support iteration over a string. Support strings with
2934 display properties. Support unibyte strings. Fix the type of
2935 `len' according to what STRING_CHAR_AND_LENGTH expects.
2936 (bidi_paragraph_init, bidi_resolve_explicit_1)
2937 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2938 (bidi_level_of_next_char, bidi_move_to_visually_next):
2939 Support iteration over a string.
0bb23927
EZ
2940 (bidi_set_sor_type, bidi_resolve_explicit_1)
2941 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2942 can now be zero (for strings); special values 0 and -1 were
2943 changed to -1 and -2, respectively.
2944 (bidi_char_at_pos): New function.
2945 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2946 Call it instead of FETCH_MULTIBYTE_CHAR.
2947 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2948 initialized to valid values.
2949 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2950 values.
2951 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2952 the test for valid cached positions. Fix the logic for looking up
2953 the sentinel state in the cache. GCPRO the Lisp string we are
2954 iterating.
2955 (bidi_push_it, bidi_pop_it): New functions.
2956 (bidi_initialize): Initialize the bidi cache start stack pointer.
2957 (bidi_cache_ensure_space): New function, refactored from part of
2958 bidi_cache_iterator_state. Don't assume the required size is just
2959 one BIDI_CACHE_CHUNK away.
2960 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2961 (bidi_count_bytes, bidi_char_at_pos): New functions.
2962 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2963 always valid if bidi_cache_idx is valid.
2964 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2965 is valid if it's going to be used.
2966 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2967 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2968 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2969 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2970 (bidi_find_other_level_edge, bidi_cache_start_stack):
2971 All variables related to cache indices are now EMACS_INT.
c965adc5 2972
0bb23927
EZ
2973 * dispextern.h (struct bidi_string_data): New structure.
2974 (struct bidi_it): New member `string'. Make flag members be 1-bit
2975 fields, and put them last in the struct.
640c8776
SM
2976 (compute_display_string_pos, compute_display_string_end):
2977 Update prototypes.
0bb23927
EZ
2978 (bidi_push_it, bidi_pop_it): Add prototypes.
2979 (struct iterator_stack_entry): New members bidi_p,
2980 paragraph_embedding, and from_disp_prop_p.
2981 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2982 (bidi_shelve_cache, bidi_unshelve_cache):
2983 Declare prototypes.
0bb23927
EZ
2984
2985 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2986 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2987 and vector-like objects.
2988
2989 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2990 cache around display iteration.
2991
2992 * window.c (Fwindow_end, window_scroll_pixel_based)
2993 (displayed_window_lines, Frecenter): Save and restore the bidi
2994 cache around display iteration.
2995
3bbd2265
LMI
29962011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2997
2998 * editfns.c (Fdelete_region): Clarify the use of the named
2999 parameters (bug#6788).
3000
adc47434
MR
30012011-07-14 Martin Rudalics <rudalics@gmx.at>
3002
3003 * indent.c (Fvertical_motion): Set and restore w->pointm when
3004 saving and restoring the window's buffer (Bug#9006).
3005
837c31f8
LMI
30062011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3007
3008 * editfns.c (Fstring_to_char): Clarify just what is returned
3009 (bug#6576). Text by Eli Zaretskii.
3010
ac389d0c
JB
30112011-07-13 Juanma Barranquero <lekktu@gmail.com>
3012
3013 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3014
0be0ce47
EZ
30152011-07-13 Eli Zaretskii <eliz@gnu.org>
3016
3017 * buffer.c (mmap_find): Fix a typo.
3018
cd18e7e3
JB
30192011-07-13 Johan Bockgård <bojohan@gnu.org>
3020
3021 Fix execution of x selection hooks.
3022 * xselect.c (Qx_lost_selection_functions)
3023 (Qx_sent_selection_functions): New vars.
3024 (syms_of_xselect): DEFSYM them.
3025 (x_handle_selection_request): Pass Qx_sent_selection_functions
3026 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3027 (x_handle_selection_clear,x_clear_frame_selections):
3028 Pass Qx_lost_selection_functions rather than
3029 Vx_lost_selection_functions to Frun_hook_with_args.
3030
47ea7f44
PE
30312011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3032
ac389d0c 3033 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3034 The old code sometimes used this field without initializing it.
3035
47ea7f44
PE
3036 * alloc.c (gc_sweep): Don't read past end of array.
3037 In theory, the old code could also have corrupted Emacs internals,
3038 though it'd be very unlikely.
3039
bc985c87
AS
30402011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3041
3042 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3043 argument. (Bug#4026)
bc985c87 3044
0cf34688
LMI
30452011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3046
b3dadd76
LMI
3047 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3048 key" (bug#4257).
3049
0cf34688
LMI
3050 * window.c (Fset_window_start): Doc fix (bug#4199).
3051 (Fset_window_hscroll): Ditto.
3052
270768cd
PE
30532011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3054
077e3dda 3055 Fix minor new problems caught by GCC 4.6.1.
270768cd 3056 * term.c (init_tty): Remove unused local.
490011a6 3057 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3058 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3059 not used otherwise.
270768cd 3060
b1f58454
CY
30612011-07-12 Chong Yidong <cyd@stupidchicken.com>
3062
3063 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3064
22b9578d
LMI
30652011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3066
6e70ab07
LMI
3067 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3068 are the mini-buffer and the echo area (bug#3320).
3069
22b9578d
LMI
3070 * term.c (init_tty): Remove support for supdup, c10 and perq
3071 terminals, which are no longer supported (bug#1482).
3072
8974cc9f
JB
30732011-07-10 Johan Bockgård <bojohan@gnu.org>
3074
3075 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3076
a560d974
JD
30772011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3078
3079 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3080 for non-popups (Bug#3642).
3081
1dae0f0a
AS
30822011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3083
268c2c36 3084 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3085 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3086 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3087 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3088 * data.c (fmod): Likewise.
3089 * dispnew.c (swap_glyphs_in_rows): Likewise.
3090 * emacs.c (memory_warning_signal): Likewise.
3091 * floatfns.c (float_error): Likewise.
3092 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3093 (otf_open, font_otf_capability, generate_otf_features)
3094 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3095 Likewise.
3096 * image.c (pbm_read_file): Likewise.
3097 * indent.c (string_display_width): Likewise.
3098 * intervals.c (check_for_interval, search_for_interval)
3099 (inc_interval_count, count_intervals, root_interval)
3100 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3101 * lread.c (defalias): Likewise.
268c2c36 3102 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3103 * regex.c (set_image_of_range_1, set_image_of_range)
3104 (regex_grow_registers): Likewise.
3105 * sysdep.c (strerror): Likewise.
3106 * termcap.c (valid_filename_p, tprint, main): Likewise.
3107 * tparam.c (main): Likewise.
3108 * unexhp9k800.c (run_time_remap, save_data_space)
3109 (update_file_ptrs, read_header, write_header, calculate_checksum)
3110 (copy_file, copy_rest, display_header): Likewise.
3111 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3112 Likewise.
3113 * xdisp.c (check_it): Likewise.
3114 * xfaces.c (register_color, unregister_color, unregister_colors):
3115 Likewise.
3116 * xfns.c (print_fontset_result): Likewise.
3117 * xrdb.c (member, fatal, main): Likewise.
3118
99033785
PE
31192011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3120
3121 Fix minor problems found by static checking (Bug#9031).
3122 * chartab.c (char_table_set_range, map_sub_char_table):
3123 Remove unused locals.
3124 (uniprop_table): Now static.
3125 * composite.c (_work_char): Remove unused static var.
3126
9cb2ac56
JB
31272011-07-09 Juanma Barranquero <lekktu@gmail.com>
3128
3129 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3130
f25661f0
JD
31312011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3132
3133 * gtkutil.c (qttip_cb): Remove code without function.
3134
8278c4fe
EZ
31352011-07-09 Eli Zaretskii <eliz@gnu.org>
3136
3137 * w32.c (pthread_sigmask): New stub.
3138
1692ae2d 31392011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3140
8a6ebd58 3141 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3142 sigprocmask is portable only for single-threaded applications, and
3143 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3144 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3145 (LIBES): Use it.
3146 * callproc.c (Fcall_process):
3147 * process.c (create_process):
3148 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3149 Use pthread_sigmask, not sigprocmask.
123403e4 3150
1b854618
JD
31512011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3152
3153 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3154 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3155 wrong (Bug#8591).
3156
3fe4b549
JD
31572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3158
0ce7e563
JD
3159 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3160 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3161 (xg_hide_tooltip): Fix comment.
3162
3fe4b549
JD
3163 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3164 in registerServicesMenuSendTypes.
3165 (validRequestorForSendType): Don't check ns_return_types.
3166
3167 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3168 ns_return_type.
3169
5df75e47
JR
31702011-07-08 Jason Rumney <jasonr@gnu.org>
3171
3172 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3173 frame struct members of non-existent frames (Bug#6284).
3174
699c10bd
JD
31752011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3176
4393663b
JD
3177 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3178 variable firstTime not needed on OSX >= 10.6.
3179 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3180 >= 10.5. Use setKnobProportion, setDoubleValue.
3181
3182 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3183 (MAC_OS_X_VERSION_10_5): Define if not defined.
3184 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3185 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3186 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3187
3188 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3189 cString and lossyCString on OSX >= 10.4
3190
3191 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
3192 sizeToFit on OSX >= 10.2.
3193
3194 * nsimage.m (allocInitFromFile): Don't use deprecated method
3195 bestRepresentationForDevice on OSX >= 10.6.
3196
3197 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3198 to avoid warning.
3199
3200 * emacs.c: Declare unexec_init_emacs_zone.
3201
a63e0781
JD
3202 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3203
699c10bd
JD
3204 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3205
3206 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3207 on svcsMenu (Bug#8842).
3208
3209 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3210 ns_return_types.
3211 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3212
3213 * nsterm.m (QUTF8_STRING): Declare.
3214 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3215 (validRequestorForSendType): Return type is (id).
3216 Change indexOfObjectIdenticalTo to indexOfObject.
3217 Check if we have local selection before returning self (Bug#8842).
3218 (writeSelectionToPasteboard): Put local selection into paste board
3219 if we have a local selection (Bug#8842).
3220 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3221
3222 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3223 (ns_get_local_selection): Declare.
3224
54e10184
LMI
32252011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3226
9888ff71
LMI
3227 * keymap.c (describe_map_tree): Don't insert a double newline at
3228 the end of the buffer (bug#1169) and return whether we inserted
3229 something.
3230
54e10184
LMI
3231 * callint.c (Fcall_interactively): Change "reading args" to
3232 "providing args" to try to clarify what it does (bug#1010).
3233
15fa4783
KH
32342011-07-07 Kenichi Handa <handa@m17n.org>
3235
3236 * composite.c (composition_compute_stop_pos): Ignore a static
3237 composition starting before CHARPOS (Bug#8915).
3238
3239 * xdisp.c (handle_composition_prop): Likewise.
3240
a8815b00
EZ
32412011-07-07 Eli Zaretskii <eliz@gnu.org>
3242
3243 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3244 (Bug#9015)
3245
ef7b981d 32462011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3247
3248 * character.h (unicode_category_t): New enum type.
3249
3250 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3251 (Qchar_code_property_table): New variable.
3252 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3253 (UNIPROP_COMPRESSED_FORM_P): New macros.
3254 (char_table_ascii): Uncompress the compressed values.
3255 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3256 Uncompress the compressed values.
ac389d0c 3257 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3258 (char_table_ref_and_range): Uncompress the compressed values.
3259 (sub_char_table_set): New arg is_uniprop. Callers changed.
3260 Uncompress the compressed values.
3261 (sub_char_table_set_range): Args changed. Callers changed.
3262 (char_table_set_range): Adjuted for the above change.
3263 (map_sub_char_table): Delete args default_val and parent. Add arg
3264 top. Give decoded values to a Lisp function.
640c8776 3265 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3266 values to a Lisp function. Gcpro more variables.
3267 (uniprop_table_uncompress)
3268 (uniprop_decode_value_run_length): New functions.
3269 (uniprop_decoder, uniprop_decoder_count): New variables.
3270 (uniprop_get_decoder, uniprop_encode_value_character)
3271 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3272 New functions.
3273 (uniprop_encoder, uniprop_encoder_count): New variables.
3274 (uniprop_get_encoder, uniprop_table)
3275 (Funicode_property_table_internal, Fget_unicode_property_internal)
3276 (Fput_unicode_property_internal): New functions.
3277 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3278 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3279 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3280 char-code-property-alist.
3281
640c8776 3282 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3283 Vunicode_category_table.
3284
640c8776 3285 * font.c (font_range): Adjust for the change of
c805dec0
KH
3286 Vunicode_category_table.
3287
76b397fb
DN
32882011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3289
3290 * m/iris4d.h: Remove file, move contents ...
3291 * s/irix6-5.h: ... here.
3292
22b4128e
PE
32932011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3294
3295 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3296 * alloc.c (mark_buffer):
3297 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3298 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3299 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3300 This isn't true in general, and it's particularly not true
3301 if Emacs is configured with --with-wide-int.
3302 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3303 New macros, used in the buffer.c change.
3304
869795d6
JD
33052011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3306
3307 * xsettings.c: Use both GConf and GSettings if both are available.
3308 (store_config_changed_event): Add comment.
3309 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3310 (store_tool_bar_style_changed): New functions.
5e617bc2 3311 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3312 (struct xsettings): Move font inside HAVE_XFT.
3313 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3314 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3315 Move inside HAVE_XFT.
640c8776 3316 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3317 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3318 also.
3319 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3320 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3321 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3322 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3323 (parse_settings): Move check for font inside HAVE_XFT.
3324 (read_settings, apply_xft_settings): Add comment.
3325 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3326 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3327 call store_font_name_changed.
3328 (xft_settings_event): Add comment.
3329 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3330 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3331 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3332 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3333 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3334 (xsettings_get_system_font, xsettings_get_system_normal_font):
3335 Add comment.
869795d6 3336
d8ed26bd
PE
33372011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3338
3339 Random fixes. E.g., (random) never returned negative values.
3340 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3341 subseconds part to the entropy, as that's a bit more random.
3342 Prefer signed to unsigned, since the signedness doesn't matter and
3343 in general we prefer signed. When given a limit, use a
3344 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3345 latter isn't right if USE_2_TAGS_FOR_INTS.
3346 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3347 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3348
cabf1cac
SM
33492011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3350
3351 * textprop.c (text_property_stickiness):
3352 Obey Vtext_property_default_nonsticky.
3353 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3354 * w32fns.c (syms_of_w32fns):
3355 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3356
6e9b2be9
PE
33572011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3358
3359 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3360 This is more efficient than Ffile_directory_p and avoids a minor race.
3361
90186c68
LMI
33622011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3363
7c301272
LMI
3364 * buffer.c (Foverlay_put): Say what the return value is
3365 (bug#7835).
3366
c4f2d8d4
LMI
3367 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3368 is a directory before asking whether to use the file name
3369 (bug#7564).
ad637907
LMI
3370 (barf_or_query_if_file_exists): Make the "File is a directory"
3371 error be more correct.
c4f2d8d4 3372
90186c68
LMI
3373 * fns.c (Frequire): Remove the mention of the .gz files, since
3374 that's installation-specific, but keep the mention of
3375 `get-load-suffixes'.
3376
da64016e
PE
33772011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3378
3379 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3380 Report string overflow if the output is too long.
3381
7d47b580
JB
33822011-07-04 Juanma Barranquero <lekktu@gmail.com>
3383
a555cb87
JB
3384 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3385 (syms_of_gnutls): Remove duplicate DEFSYM for
3386 Qgnutls_bootprop_verify_hostname_error, an error for
3387 Qgnutls_bootprop_verify_error (which is no longer used).
3388
7d47b580
JB
3389 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3390 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3391 Also (re)move comments that are misplaced or no longer relevant.
3392
1e49bfab
LMI
33932011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3394
3395 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3396
1485f4c0
CY
33972011-07-03 Chong Yidong <cyd@stupidchicken.com>
3398
3399 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3400 and background color parameters if they have been changed.
3401
a9ab721e
LMI
34022011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3403
3404 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3405
cf7cff57
PE
34062011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3407
2e13213d
PE
3408 * xsettings.c (SYSTEM_FONT): Define only when used.
3409 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3410
cf7cff57
PE
3411 * keymap.c (access_keymap_1): Now static.
3412
7a8e04f7
CY
34132011-07-02 Chong Yidong <cyd@stupidchicken.com>
3414
3415 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3416 leave any prefix arg for the up event (Bug#1586).
3417
61352f62
LMI
34182011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3419
69bb1ef7
LMI
3420 * lread.c (syms_of_lread): Mention single symbols defined by
3421 `defvar' or `defconst' (bug#7154).
3422
61352f62 3423 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3424 (Frequire): Mention get-load-suffixes.
61352f62 3425
28545e04
MR
34262011-07-02 Martin Rudalics <rudalics@gmx.at>
3427
3428 * window.h (window): Remove clone_number slot.
3429 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3430 Remove.
3431 (make_parent_window, make_window, saved_window)
3432 (Fset_window_configuration, save_window_save): Don't deal with
3433 clone numbers.
3434 * buffer.c (Qclone_number): Remove declaration.
3435 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3436
3349e122
SM
34372011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3438
3439 Add multiple inheritance to keymaps.
3440 * keymap.c (Fmake_composed_keymap): New function.
3441 (Fset_keymap_parent): Simplify.
3442 (fix_submap_inheritance): Remove.
3443 (access_keymap_1): New function extracted from access_keymap to handle
3444 embedded parents and handle lists of maps.
3445 (access_keymap): Use it.
3446 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3447 (Fcopy_keymap): Handle embedded parents.
3448 (Fcommand_remapping, define_as_prefix): Simplify.
3449 (Fkey_binding): Simplify.
3450 (syms_of_keymap): Move minibuffer-local-completion-map,
3451 minibuffer-local-filename-completion-map,
3452 minibuffer-local-must-match-map, and
3453 minibuffer-local-filename-must-match-map to Elisp.
3454 (syms_of_keymap): Defsubr make-composed-keymap.
3455 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3456 (parse_menu_item): Trivial simplification.
3457
3279eb87
GM
34582011-07-01 Glenn Morris <rgm@gnu.org>
3459
3460 * Makefile.in (SETTINGS_LIBS): Fix typo.
3461
4550efdf
KI
34622011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3463
3464 * coding.c (Fencode_coding_string): Record the last coding system
3465 used, as the function doc string says (bug#8738).
3466
0949d2b6
JD
34672011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3468
3469 * xsettings.c (store_monospaced_changed): Take new font as arg and
3470 check for change against current_mono_font.
3471 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3472 (emacs_settings_constructor, emacs_settings_get_property)
3473 (emacs_settings_set_property, emacs_settings_class_init)
3474 (emacs_settings_init, gsettings_obj): Remove.
3475 (something_changedCB): New function for HAVE_GSETTINGS.
3476 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3477 with value as argument.
3478 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3479 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3480 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3481 "changed".
3482
3483 * xgselect.c: Add defined (HAVE_GSETTINGS).
3484 (xgselect_initialize): Ditto.
3485
3486 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3487 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3488 xg_select.
3489
bbc6b304
PE
34902011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3491
3492 * eval.c (struct backtrace): Simplify and port the data structure.
3493 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3494 signed bit field, as this assumption is not portable and it makes
3495 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3496 "char debug_on_exit : 1" as this is not portable either; instead,
3497 use the portable "unsigned int debug_on_exit : 1". Remove unused
3498 member evalargs. Remove obsolete comments about cc bombing out.
3499
9851bfc5
JD
35002011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3501
51bb811f 3502 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3503 Let HAVE_GSETTINGS override HAVE_GCONF.
3504 (store_monospaced_changed): New function.
3505 (EMACS_SETTINGS): A new type derived from GObject to handle
3506 GSettings notifications.
3507 (emacs_settings_constructor, emacs_settings_get_property)
3508 (emacs_settings_set_property, emacs_settings_class_init):
3509 New functions.
3510 (gsettings_client, gsettings_obj): New variables.
3511 (GSETTINGS_SCHEMA): New define.
3512 (something_changedCB): Call store_monospaced_changed.
3513 (init_gsettings): New function.
3514 (xsettings_initialize): Call init_gsettings.
3515 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3516 to NULL.
3517
640c8776 3518 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3519 GCONF_CFLAGS/LIBS.
3520
5386012d
MR
35212011-06-29 Martin Rudalics <rudalics@gmx.at>
3522
3523 * window.c (resize_root_window, grow_mini_window)
3524 (shrink_mini_window): Rename Qresize_root_window to
3525 Qwindow_resize_root_window and Qresize_root_window_vertically to
3526 Qwindow_resize_root_window_vertically.
3527
f13e0b08
PE
35282011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3529
3530 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3531
94515237
JB
35322011-06-27 Juanma Barranquero <lekktu@gmail.com>
3533
3534 * makefile.w32-in: Redesign dependencies so they reflect more
3535 clearly which files are directly included by each source file,
3536 and not through other includes.
3537
e43b6e43
MR
35382011-06-27 Martin Rudalics <rudalics@gmx.at>
3539
3540 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3541 (sort_overlays, overlay_strings): When an overlay's clone number
3542 matches the window's clone number process the overlay even if
3543 the overlay's window property doesn't match the current window.
3544
d68443dc
MR
3545 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3546 (Fwindow_hchild): Rename to Fwindow_left_child.
3547 (Fwindow_next): Rename to Fwindow_next_sibling.
3548 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3549 (resize_window_check): Rename to window_resize_check.
3550 (resize_window_apply): Rename to window_resize_apply.
3551 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3552 (Fdelete_other_windows_internal, resize_frame_windows)
3553 (Fsplit_window_internal, Fdelete_window_internal)
3554 (grow_mini_window, shrink_mini_window)
3555 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3556
c7e73be5
JD
35572011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3558
3559 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3560 (emacs_fixed_set_min_size): Remove.
3561 (emacs_fixed_new): Take frame as argument.
3562
3563 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3564 (_EmacsFixedPrivate): Remove minwidth/height.
3565 Add struct frame *f.
3566 (emacs_fixed_init): Initialize priv->f.
3567 (get_parent_class, emacs_fixed_set_min_size): Remove.
3568 (emacs_fixed_new): Set priv->f to argument.
3569 (emacs_fixed_get_preferred_width)
3570 (emacs_fixed_get_preferred_height): Use min_width/height from
3571 frames size_hint to set minimum and natural (Bug#8919).
3572 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3573 and use min_width/height from frames size_hint to set
3574 min_width/height (Bug#8919).
3575
3576 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3577 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3578 Fix indentation.
c7e73be5 3579
cf99dcf8
EZ
35802011-06-26 Eli Zaretskii <eliz@gnu.org>
3581
3582 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3583 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3584 called at ZV.
3585
029529ac
CY
35862011-06-26 Chong Yidong <cyd@stupidchicken.com>
3587
3588 * process.c (wait_reading_process_output): Bypass select if
3589 waiting for a cell while ignoring keyboard input, and input is
3590 pending. Suggested by Jan Djärv (Bug#8869).
3591
7a7ef429
PE
35922011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3593
3594 Use gnulib's dup2 module instead of rolling our own.
3595 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3596
11fdef7d 35972011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3598
3599 * dispnew.c (scrolling_window): Before scrolling, turn off a
3600 mouse-highlight in the window being scrolled.
3601
cd3520a4
JB
36022011-06-24 Juanma Barranquero <lekktu@gmail.com>
3603
3604 Move DEFSYM to lisp.h and use everywhere.
3605
3606 * character.h (DEFSYM): Move declaration...
3607 * lisp.h (DEFSYM): ...here.
3608
3609 * gnutls.c:
3610 * minibuf.c:
3611 * w32menu.c:
3612 * w32proc.c:
3613 * w32select.c: Don't include character.h.
3614
3615 * alloc.c (syms_of_alloc):
3616 * buffer.c (syms_of_buffer):
3617 * bytecode.c (syms_of_bytecode):
3618 * callint.c (syms_of_callint):
3619 * casefiddle.c (syms_of_casefiddle):
3620 * casetab.c (init_casetab_once):
3621 * category.c (init_category_once, syms_of_category):
3622 * ccl.c (syms_of_ccl):
3623 * cmds.c (syms_of_cmds):
3624 * composite.c (syms_of_composite):
3625 * dbusbind.c (syms_of_dbusbind):
3626 * dired.c (syms_of_dired):
3627 * dispnew.c (syms_of_display):
3628 * doc.c (syms_of_doc):
3629 * editfns.c (syms_of_editfns):
3630 * emacs.c (syms_of_emacs):
3631 * eval.c (syms_of_eval):
3632 * fileio.c (syms_of_fileio):
3633 * fns.c (syms_of_fns):
3634 * frame.c (syms_of_frame):
3635 * fringe.c (syms_of_fringe):
3636 * insdel.c (syms_of_insdel):
3637 * keymap.c (syms_of_keymap):
3638 * lread.c (init_obarray, syms_of_lread):
3639 * macros.c (syms_of_macros):
3640 * msdos.c (syms_of_msdos):
3641 * print.c (syms_of_print):
3642 * process.c (syms_of_process):
3643 * search.c (syms_of_search):
3644 * sound.c (syms_of_sound):
3645 * syntax.c (init_syntax_once, syms_of_syntax):
3646 * terminal.c (syms_of_terminal):
3647 * textprop.c (syms_of_textprop):
3648 * undo.c (syms_of_undo):
3649 * w32.c (globals_of_w32):
3650 * window.c (syms_of_window):
3651 * xdisp.c (syms_of_xdisp):
3652 * xfaces.c (syms_of_xfaces):
3653 * xfns.c (syms_of_xfns):
3654 * xmenu.c (syms_of_xmenu):
3655 * xsettings.c (syms_of_xsettings):
3656 * xterm.c (syms_of_xterm): Use DEFSYM.
3657
4228cf16
TZ
36582011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3659
cd3520a4 3660 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3661
7fcccf1e
PE
36622011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3663
7efb4e0e
PE
3664 Integer and buffer overflow fixes (Bug#8873).
3665
ff5844ad
PE
3666 * print.c (printchar, strout): Check for string overflow.
3667 (PRINTPREPARE, printchar, strout):
3668 Don't set size unless allocation succeeds.
3669
90532f02
PE
3670 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3671 for sizes. Check for string overflow more accurately.
3672 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3673
6d84508d
PE
3674 * macros.c: Integer and buffer overflow fixes.
3675 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3676 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3677 Use ptrdiff_t, not int, for sizes.
3678 Don't increment bufsize until after realloc succeeds.
3679 Check for size-calculation overflow.
3680 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3681
437b2cb4
PE
3682 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3683
8b9ac8b4
PE
3684 * lread.c: Integer overflow fixes.
3685 (read_integer): Radix is now EMACS_INT, not int,
3686 to improve quality of diagnostics for out-of-range radices.
3687 Calculate buffer size correctly for out-of-range radices.
3688 (read1): Check for integer overflow in radices, and in
3689 read-circle numbers.
82cb60d3
PE
3690 (read_escape): Avoid int overflow.
3691 (Fload, openp, read_buffer_size, read1)
3692 (substitute_object_recurse, read_vector, read_list, map_obarray):
3693 Use ptrdiff_t, not int, for sizes.
3694 (read1): Use EMACS_INT, not int, for sizes.
20270765 3695 Check for size overflow.
8b9ac8b4 3696
7fcccf1e
PE
3697 * image.c (cache_image): Check for size arithmetic overflow.
3698
bfbbd7e7
PE
3699 * lread.c: Integer overflow issues.
3700 (saved_doc_string_size, saved_doc_string_length)
3701 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3702 Now ptrdiff_t, not int.
3703 (read1): Don't assume doc string length fits in int. Check for
3704 out-of-range doc string lengths.
3705 (read_list): Don't assume file position fits in int.
39019e54 3706 (read_escape): Check for hex character overflow.
bfbbd7e7 3707
4e323265
LL
37082011-06-22 Leo Liu <sdl.web@gmail.com>
3709
3710 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3711 Move to minibuffer.el.
3712
85fece3e
PE
37132011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3714
20b84ce9 3715 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3716 The following patches are for when GLYPH_DEBUG && !XASSERT.
3717 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3718 * dispnew.c (flush_stdout):
3719 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3720 Mark as externally visible.
3721 * dispnew.c (check_window_matrix_pointers): Now static.
3722 * dispnew.c (window_to_frame_vpos):
3723 * xfns.c (unwind_create_frame):
3724 * xterm.c (x_check_font): Remove unused local.
3725 * scroll.c (CHECK_BOUNDS):
3726 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3727 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3728 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3729 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3730 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3731 Now static.
3732 (debug_method_add): Use va_list and vsprintf rather than relying
3733 on undefined behavior with wrong number of arguments.
3734 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3735 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3736 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3737 since we're not interested in debugging glyphs with old libraries.
3738 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3739 GCC 4.6.0's static checking.
3740
0766b489
PE
37412011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3742
31fd4b32
PE
3743 Integer overflow and signedness fixes (Bug#8873).
3744 A few related buffer overrun fixes, too.
3745
b79e8648
PE
3746 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3747
0766b489
PE
3748 * dispextern.h (struct face.stipple):
3749 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3750 (x_bitmap_mask, x_allocate_bitmap_record)
3751 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3752 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3753 (x_create_bitmap_from_xpm_data):
3754 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3755 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3756 (.bitmaps_last):
3757 * xfaces.c (load_pixmap):
3758 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3759 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3760 (.bitmaps_last, struct x_output.icon_bitmap):
3761 Use ptrdiff_t, not int, for bitmap indexes.
3762 (x_allocate_bitmap_record): Check for size overflow.
3763 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3764
b081724f
PE
3765 Use ptrdiff_t, not int, for overlay counts.
3766 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3767 * editfns.c (overlays_around, get_pos_property):
3768 * textprop.c (get_char_property_and_overlay):
3769 * xdisp.c (next_overlay_change, note_mouse_highlight):
3770 * xfaces.c (face_at_buffer_position):
21514da7
PE
3771 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3772 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3773 (Fnext_overlay_change, Fprevious_overlay_change)
3774 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3775 Use ptrdiff_t, not int, for sizes.
21514da7 3776 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3777
3de73e5e
PE
3778 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3779
2606c57b
PE
3780 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3781 (x_session_initialize): Do not assume string length fits in int.
3782
aaafe47a
PE
3783 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3784 This is unlikely, but can occur if DPI is outlandish.
3785
2674ddc8 3786 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3787 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3788
28154962
PE
3789 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3790 * xrdb.c (magic_file_p, search_magic_path):
3791 Omit last arg SUFFIX; it was always 0. All callers changed.
3792 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3793
7de51af5
PE
3794 * xfont.c (xfont_match): Avoid need for strlen.
3795
25ed6cc3
PE
3796 * xfns.c: Don't assume strlen fits in int.
3797 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3798
4eab31dd
PE
3799 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3800 not unsigned long, as we prefer signed integers. All callers changed.
3801 Detect integer overflow in repeat count.
3802 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3803 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3804
171e2a58
PE
3805 * termcap.c: Don't assume sizes fit in int and never overflow.
3806 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3807 (gobble_line): Check for size-calculation overflow.
3808
ad39faca 3809 * minibuf.c (Fread_buffer):
6e5bb2dc 3810 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3811 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3812 Don't assume string length fits in int.
3813
52c61c22 3814 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3815 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3816
b5b8c9e5
PE
3817 * font.c: Don't assume string length fits in int.
3818 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3819 Use ptrdiff_t, not int.
ccd6111c
PE
3820 (font_intern_prop): Don't assume string length fits in int.
3821 Don't assume integer property fits in fixnum.
3822 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3823
882f0d81 3824 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3825 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3826 Reformulate so as not to need the command string.
3827 Invoke gzip -cd rather than gunzip, as it's more portable.
3828 (lock_info_type, lock_file_1, lock_file):
3829 Don't assume pid_t and time_t fit in unsigned long.
3830 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3831 (current_lock_owner): Prefer signed type for sizes.
3832 Use memcpy, not strncpy, where memcpy is what is really wanted.
3833 Don't assume (via atoi) that time_t and pid_t fit in int.
3834 Check for time_t and/or pid_t out of range, e.g., via a network share.
3835 Don't alloca where an auto var works fine.
3836
93f4cf88
PE
3837 * fileio.c: Fix some integer overflow issues.
3838 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3839 Don't assume string length fits in int.
3840 (directory_file_name): Don't assume string length fits in long.
3841 (make_temp_name): Don't assume pid fits in int, or that its print
3842 length is less than 20.
3843
f3e92b69
PE
3844 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3845
1bfdaf10
PE
3846 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3847
35016e9a
PE
3848 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3849
3d1e65a1
PE
3850 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3851 We prefer signed integers, even for size calculations.
3852
0b963a93
PE
3853 * emacs.c: Don't assume string length fits in 'int'.
3854 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3855 (main): Don't invoke strlen when not needed.
3856
573f4b54
PE
3857 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3858 (XD_DEBUG_MESSAGE): Don't waste a byte.
3859
989f33ba
PE
3860 * callproc.c (getenv_internal_1, getenv_internal)
3861 (Fgetenv_internal):
965d34eb
PE
3862 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3863
e4d29b33
PE
3864 * lread.c (invalid_syntax): Omit length argument.
3865 All uses changed. This doesn't fix a bug, but it simplifies the
3866 code away from its former Hollerith-constant appearance, and it's
3867 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3868 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3869
eb49b136
PE
3870 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3871 This didn't break anything, but it didn't help either.
3872 It's confusing to put a bogus integer in a place where the actual
3873 value does not matter.
9f62aeb1 3874 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3875 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3876
15375a22
PE
3877 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3878 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3879 implementation.
b61cc01c
PE
3880 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3881 We prefer signed types, and the value cannot exceed the EMACS_INT
3882 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3883 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3884 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3885 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3886
53b2623d
PE
3887 * indent.c (sane_tab_width): New function.
3888 (current_column, scan_for_column, Findent_to, position_indentation)
3889 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3890 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3891
51cab52b 3892 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3893
f2ed8a70
PE
3894 * lisp.h (lint_assume): New macro.
3895 * composite.c (composition_gstring_put_cache):
3896 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3897
abe80cc6
PE
3898 * editfns.c, insdel.c:
3899 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3900
b02c740e
PE
3901 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3902
ebc96716
PE
3903 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3904
b4e50fa0 3905 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3906 Use much-faster test for byte-length change.
311d5d7c 3907 Don't assume string byte-length fits in 'int'.
a4cf38e4 3908 Check that character arg fits in 'int'.
85461888 3909 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3910
c0c1ee9f
PE
3911 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3912
a498d7f4
PE
3913 * fns.c (concat): Catch string overflow earlier.
3914 Do not rely on integer wraparound.
3915
51cab52b
PE
3916 * dispextern.h (struct it.overlay_strings_charpos)
3917 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3918 * xdisp.c (forward_to_next_line_start)
3919 (back_to_previous_visible_line_start)
3920 (reseat_at_next_visible_line_start, next_element_from_buffer):
3921 Don't arbitrarily truncate the value of 'selective' to int.
3922
76031fad
PE
3923 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3924
5eb55db9
PE
3925 * composite.c: Don't truncate sizes to 'int'.
3926 (composition_gstring_p, composition_reseat_it)
3927 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3928 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3929 not EMACS_UINT, for indexes.
5eb55db9 3930
0703a717
PE
3931 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3932
d6202519
PE
3933 * buffer.c: Include <verify.h>.
3934 (struct sortvec.priority, struct sortstr.priority):
8961a454 3935 Now EMACS_INT, not int.
c20998a7 3936 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3937 (struct sortstr.size, record_overlay_string)
3938 (struct sortstrlist.size, struct sortlist.used):
3939 Don't truncate size to int.
3940 (record_overlay_string): Check for size-calculation overflow.
d6202519 3941 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3942
d5a19415
JM
39432011-06-22 Jim Meyering <meyering@redhat.com>
3944
029529ac 3945 Don't leak an XBM-image-sized buffer
d5a19415
JM
3946 * image.c (xbm_load): Free the image buffer after using it.
3947
a9041e6c
PE
39482011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3949
3950 Port to Sun C.
3951 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3952 that Sun C diagnosed.
3953 * fns.c (secure_hash): Fix pointer signedness issue.
3954 * intervals.c (static_offset_intervals): New function.
3955 (offset_intervals): Use it.
3956
7f3f739f
LL
39572011-06-21 Leo Liu <sdl.web@gmail.com>
3958
3959 * deps.mk (fns.o):
3960 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3961 sha512.h.
3962
3963 * fns.c (secure_hash): Rename from crypto_hash_function and change
3964 the first arg to accept symbols.
5b66d427 3965 (Fsecure_hash): New primitive.
7f3f739f
LL
3966 (syms_of_fns): New symbols.
3967
76147d94
DD
39682011-06-20 Deniz Dogan <deniz@dogan.se>
3969
3970 * process.c (Fset_process_buffer): Clarify return value in
3971 docstring.
3972
7d7d0045
CY
39732011-06-18 Chong Yidong <cyd@stupidchicken.com>
3974
3975 * dispnew.c (add_window_display_history): Use BVAR.
3976
3977 * xdisp.c (debug_method_add): Use BVAR.
3978 (check_window_end, dump_glyph_matrix, dump_glyph)
3979 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3980
3981 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3982 Likewise.
3983
3984 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3985 check till after the cache is created in init_frame_faces.
3986
ff2bc410
SM
39872011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3988
3989 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3990
28177add
PE
39912011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3992
dd3482fe
PE
3993 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3994 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3995 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3996
393d71f3 3997 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3998 * fileio.c (Finsert_file_contents):
3999 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4000 Remove the old (too-loose) buffer overflow checks.
4001 They weren't needed, since make_gap checks for buffer overflow.
4002 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4003 The old code merely checked for Emacs fixnum overflow, and relied
4004 on undefined (wraparound) behavior. The new code avoids undefined
4005 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4006
2e6813b0 4007 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4008 Tune. Don't use wider integers than needed. Don't use alloca.
4009 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4010
599a9e4f
PE
4011 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4012
99561444
PE
4013 * insdel.c, lisp.h (buffer_overflow): New function.
4014 (insert_from_buffer_1, replace_range, replace_range_2):
4015 * insdel.c (make_gap_larger):
4016 * editfns.c (Finsert_char):
4017 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4018
28177add
PE
4019 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4020
e69dafad
PE
40212011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4022
a7af7fde 4023 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4024
b1c46f02
PE
4025 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4026 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4027
e69dafad
PE
4028 * fileio.c: Don't assume EMACS_INT fits in off_t.
4029 (emacs_lseek): New static function.
4030 (Finsert_file_contents, Fwrite_region): Use it.
4031 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4032
566684ea
PE
4033 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4034
e6966cd6
PE
4035 * fns.c: Don't overflow int when computing a list length.
4036 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4037 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4038 truncation on 64-bit hosts. Check for QUIT every
4039 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4040 faster and is responsive enough.
4041 (Flength): Report an error instead of overflowing an integer.
4042 (Fsafe_length): Return a float if the value is not representable
4043 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4044 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4045 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4046
dd0b0efb
PE
4047 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4048 (header_size, word_size): New constants.
4049 (allocate_vectorlike): Don't check size overflow here.
4050 (allocate_vector): Check it here instead, since this is the only
4051 caller of allocate_vectorlike that could cause overflow.
4052 Check that the new vector's length is representable as a fixnum.
4053
86fe5cfe
PE
4054 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4055 The previous code was bogus. For example, next_almost_prime (32)
4056 returned 39, which is undesirable as it is a multiple of 3; and
4057 next_almost_prime (24) returned 25, which is a multiple of 5 so
4058 why was the code bothering to check for multiples of 7?
4059
80e88859
PE
4060 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4061
4a2f0ad6
PE
4062 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4063
f66c7cf8
PE
4064 Variadic C functions now count arguments with ptrdiff_t.
4065 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4066 Back then I didn't know that the Emacs coding style prefers signed int.
4067 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4068 were being counted with int, which may truncate counts on 64-bit
4069 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4070 * lisp.h (struct Lisp_Subr.function.aMANY)
4071 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4072 Arg counts are now ptrdiff_t, not size_t.
4073 All variadic functions and their callers changed accordingly.
4074 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4075 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4076 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4077 * callint.c (Fcall_interactively): Check arg count for overflow,
4078 to avoid potential buffer overrun. Use signed char, not 'int',
4079 for 'varies' array, so that we needn't bother to check its size
4080 calculation for overflow.
4081 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4082 * eval.c (apply_lambda):
4083 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4084 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4085 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4086
a1759b76
PE
4087 * callint.c (Fcall_interactively): Don't use index var as event count.
4088
d96be9fc
PE
4089 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4090 * mem-limits.h (SIZE): Remove; no longer used.
4091
a690a978 4092 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4093
578c21e6
PE
4094 Remove unnecessary casts.
4095 * xterm.c (x_term_init):
4096 * xfns.c (x_set_border_pixel):
4097 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4098 These aren't needed now that we assume ANSI C.
4099
96f53c6c
PE
4100 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4101 It's more likely to cause problems (due to unsigned overflow)
4102 than to cure them.
4103
83c77d31
PE
4104 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4105
ee2079f1
PE
4106 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4107
6da65536
PE
4108 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4109
7147c4a4
PE
4110 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4111
193e32d9
PE
4112 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4113
e5533da6
PE
4114 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4115
9910e595
PE
4116 GLYPH_CODE_FACE returns EMACS_INT, not int.
4117 * dispextern.h (merge_faces):
4118 * xfaces.c (merge_faces):
01103c44
PE
4119 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4120 Don't assume EMACS_INT fits in int.
9910e595 4121
2638320e
PE
4122 * character.h (CHAR_VALID_P): Remove unused parameter.
4123 * fontset.c, lisp.h, xdisp.c: All uses changed.
4124
045eb8d9
PE
4125 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4126
c1f134b5
PE
4127 * fns.c (concat): Minor tuning based on overflow analysis.
4128 This doesn't fix any bugs. Use int to hold character, instead
4129 of constantly refetching from Emacs object. Use XFASTINT, not
4130 XINT, for value known to be a character. Don't bother comparing
4131 a single byte to 0400, as it's always less.
4132
395fcb93 4133 * floatfns.c (Fexpt):
327eeec8
PE
4134 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4135
abbd3d23
PE
4136 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4137 for characters.
4138
684a03ef
PE
4139 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4140
0fed43f3
PE
4141 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4142 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4143 incorrectly succeed when S was a string, because 4294967386 was
4144 truncated before it was used.
4145
8fd02eb7
PE
4146 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4147 Otherwise, an out-of-range integer could cause undefined behavior
4148 on a 64-bit host.
4149
f8c86b69
PE
4150 * composite.c: Use int, not EMACS_INT, for characters.
4151 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4152 EMACS_INT, for values that are known to be in character range.
4153 This doesn't fix any bugs but is the usual style inside Emacs and
4154 may generate better code on 32-bit machines.
4155
34206dd2
PE
4156 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4157 This is for reasons similar to the recent CHAR_STRING fix.
4158 * charset.c (Fencode_char): Check that character arg is actually
4159 a character. Pass an int to ENCODE_CHAR.
4160 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4161 wider than 'int', as a compile-time check to prevent future regressions
4162 in this area.
4163
c5958d4c 4164 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4165
4166 Make sure a 64-bit char is never passed to CHAR_STRING.
4167 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4168 by silently ignoring the top 32 bits, allowing some values
4169 that were far too large to be valid characters.
4170 * character.h: Include <verify.h>.
4171 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4172 arguments are no wider than unsigned, as a compile-time check
4173 to prevent future regressions in this area.
4174 * data.c (Faset):
01103c44 4175 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4176 (Fsubst_char_in_region):
4177 * fns.c (concat):
4178 * xdisp.c (decode_mode_spec_coding):
4179 Adjust to CHAR_STRING's new requirement.
4180 * editfns.c (Finsert_char, Fsubst_char_in_region):
4181 * fns.c (concat): Check that character args are actually
4182 characters. Without this test, these functions did the wrong
4183 thing with wildly out-of-range values on 64-bit hosts.
4184
d37ca623
PE
4185 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4186 These casts should not be needed on 32-bit hosts, either.
4187 * keyboard.c (read_char):
4188 * lread.c (Fload): Remove casts to unsigned.
4189
ea204efb
PE
4190 * lisp.h (UNSIGNED_CMP): New macro.
4191 This fixes comparison bugs on 64-bit hosts.
4192 (ASCII_CHAR_P): Use it.
4193 * casefiddle.c (casify_object):
01103c44 4194 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4195 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4196 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4197 * dispextern.h (FACE_FROM_ID):
4198 * keyboard.c (read_char): Use UNSIGNED_CMP.
4199
41cb286c
PE
4200 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4201 not to EMACS_INT, to avoid GCC warning.
4202
4a1b9832
PE
4203 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4204
55daad71
PE
4205 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4206 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4207 isn't needed on 32-bit machines.
8f95c75c 4208
01103c44
PE
4209 * buffer.c (Fgenerate_new_buffer_name):
4210 Use EMACS_INT for count, not int.
0ceccced 4211 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4212
4213 * data.c (Qcompiled_function): Now static.
4214
c6f072e7
PE
4215 * window.c (window_body_lines): Now static.
4216
20ce5912
PE
4217 * image.c (gif_load): Rename local to avoid shadowing.
4218
9c4c5f81
PE
4219 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4220 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4221 * alloc.c (make_save_value): Integer argument is now of type
4222 ptrdiff_t, not int.
4223 (mark_object): Use ptrdiff_t, not int.
4224 * lisp.h (pD): New macro.
4225 * print.c (print_object): Use it.
4226
c0c5c8ae
PE
4227 * alloc.c: Use EMACS_INT, not int, to count objects.
4228 (total_conses, total_markers, total_symbols, total_vector_size)
4229 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4230 (total_free_floats, total_floats, total_free_intervals)
4231 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4232 Now EMACS_INT, not int. All uses changed.
4233 (Fgarbage_collect): Compute overall total using a double, so that
4234 integer overflow is less likely to be a problem. Check for overflow
4235 when converting back to an integer.
5a25e253
PE
4236 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4237 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4238 These were 'int' variables that could overflow on 64-bit hosts;
4239 they were never used, so remove them instead of repairing them.
211a0b2a 4240 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4241 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4242 Previously, this ceilinged at INT_MAX, but that doesn't work on
4243 64-bit machines.
e46bb31a 4244 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4245
c78baabf 4246 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4247 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4248 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4249 when a (possibly-narrower) signed value would do just as well.
4250 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4251
c9d624c6
PE
4252 * alloc.c: Catch some string size overflows that we were missing.
4253 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4254 for convenience in STRING_BYTES_MAX.
4255 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4256 The definition here is exact; the one in lisp.h was approximate.
4257 (allocate_string_data): Check for string overflow. This catches
4258 some instances we weren't catching before. Also, it catches
4259 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4260 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4261 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4262
c9d624c6
PE
4263 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4264 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4265 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4266
353032ce
PE
4267 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4268
2bccce07
PE
4269 * alloc.c (Fmake_string): Check for out-of-range init.
4270
0ac30604
SM
42712011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4272
4273 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4274
c195f2de
JD
42752011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4276
4277 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4278 xg_get_default_scrollbar_width.
4279
4280 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4281 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4282 (style_changed_cb): Call update_theme_scrollbar_width and call
4283 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4284 all frames (Bug#8505).
4285 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4286 Call gtk_window_set_resizable if HAVE_GTK3.
4287 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4288 and height if HAVE_GTK3 (Bug#8505).
4289 (scroll_bar_width_for_theme): New variable.
4290 (update_theme_scrollbar_width): New function.
4291 (xg_get_default_scrollbar_width): Move code to
4292 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4293 (xg_initialize): Call update_theme_scrollbar_width.
4294
4295 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4296
4297 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4298
e10ac9f1
MR
42992011-06-12 Martin Rudalics <rudalics@gmx.at>
4300
4301 * frame.c (make_frame): Call other_buffer_safely instead of
4302 other_buffer.
4303
4304 * window.c (temp_output_buffer_show): Call display_buffer with
4305 second argument Vtemp_buffer_show_specifiers and reset latter
4306 immediately after the call.
4307 (Vtemp_buffer_show_specifiers): New variable.
4308 (auto_window_vscroll_p, next_screen_context_lines)
4309 (Vscroll_preserve_screen_position): Remove leading asterisks from
4310 doc-strings.
4311
2d3c217e 43122011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4313
7b7f97e8 4314 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4315 * buffer.c (Qclone_number): Remove for now, as it's unused.
4316 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4317 (record_buffer): Remove unused local.
4318 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4319 (set_frame_buffer_list): Remove; unused.
4320 * frame.h (other_visible_frames): Remove decl.
4321 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4322 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4323 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4324 if HAVE_GPM.
4325 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4326 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4327 Define only if HAVE_GPM.
4328 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4329 (update_hints_inhibit): Remove; never set. All uses removed.
4330 * widgetprv.h (emacsFrameClassRec): Remove decl.
4331 * window.c (delete_deletable_window): Now returns void, since it
4332 wasn't returning anything.
4333 (compare_window_configurations): Remove unused locals.
4334 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4335 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4336 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4337 the same widths as pointers. This follows up on the 2011-05-06 patch.
4338 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4339 * xterm.h: Likewise.
4340 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4341
1384b89e
JB
43422011-06-12 Juanma Barranquero <lekktu@gmail.com>
4343
4344 * makefile.w32-in: Update dependencies.
4345 (LISP_H): Add lib/intprops.h.
4346
1100a63c
CY
43472011-06-11 Chong Yidong <cyd@stupidchicken.com>
4348
4349 * image.c (gif_load): Add animation frame delay to the metadata.
4350 (syms_of_image): Use DEFSYM. New symbol `delay'.
4351
6198ccd0
MR
43522011-06-11 Martin Rudalics <rudalics@gmx.at>
4353
4354 * window.c (delete_deletable_window): Re-add.
4355 (Fset_window_configuration): Rewrite to handle dead buffers and
4356 consequently deletable windows.
4357 (window_tree, Fwindow_tree): Remove. Supply functionality in
4358 window.el.
4359 (compare_window_configurations): Simplify code.
4360
b6e3633c
AS
43612011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4362
1ab0dee5
AS
4363 * image.c (imagemagick_load_image): Fix type mismatch.
4364 (Fimagemagick_types): Likewise.
4365
b6e3633c
AS
4366 * window.h (replace_buffer_in_windows): Declare.
4367
9397e56f
MR
43682011-06-11 Martin Rudalics <rudalics@gmx.at>
4369
4370 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4371 Qclone_number. Remove external declaration of Qdelete_window.
4372 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4373 code.
640c8776
SM
4374 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4375 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4376 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4377 buffer list implementation.
4378 (other_buffer_safely): New function.
4379 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4380 calls to replace_buffer_in_windows and
4381 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4382 if allowed.
4383 (record_buffer): Inhibit quitting and rewrite using quittable
4384 functions. Run Qbuffer_list_update_hook if allowed.
4385 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4386 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4387 Move switch-to-buffer to window.el.
9397e56f
MR
4388 (bury-buffer): Move to window.el.
4389 (Vbuffer_list_update_hook): New variable.
4390
4391 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4392 section.
4393
4394 * window.h (resize_frame_windows): Move up in code.
4395 (Fwindow_frame): Remove EXFUN.
4396 (replace_buffer_in_all_windows): Remove prototype.
4397 (replace_buffer_in_windows_safely): Add prototype.
4398
4399 * window.c: Declare Qdelete_window static again. Move down
4400 declaration of select_count.
4401 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4402 (Fother_window): Move to window.el.
4403 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4404 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4405 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4406 window.el.
4407 (replace_buffer_in_windows): Implement by calling
4408 Qreplace_buffer_in_windows.
4409 (replace_buffer_in_all_windows): Remove with some functionality
4410 moved into replace_buffer_in_windows_safely.
4411 (replace_buffer_in_windows_safely): New function.
4412 (select_window_norecord, select_frame_norecord): Move in front
4413 of run_window_configuration_change_hook. Remove now obsolete
4414 declarations.
640c8776
SM
4415 (Fset_window_buffer): Rewrite doc-string.
4416 Call Qrecord_window_buffer.
9397e56f
MR
4417 (keys_of_window): Move binding for other-window to window.el.
4418
b50691aa
CY
44192011-06-11 Chong Yidong <cyd@stupidchicken.com>
4420
4421 * dispextern.h (struct image): Replace data member, whose int_val
4422 and ptr_val fields were not used by anything, with a single
4423 lisp_val object.
4424
4425 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4426 (gif_clear_image, gif_load, imagemagick_load_image)
4427 (gs_clear_image, gs_load): Callers changed.
4428
3f754b86
PE
44292011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4430
cca69397
PE
4431 * buffer.h: Include <time.h>, for time_t.
4432 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4433
109e28d0
PE
4434 Fix minor problems found by static checking.
4435
60737f02
PE
4436 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4437
4b66faf3
PE
4438 Make identifiers static if they are not used in other modules.
4439 * data.c (Qcompiled_function, Qframe, Qvector):
4440 * image.c (QimageMagick, Qsvg):
4441 * minibuf.c (Qmetadata):
4442 * window.c (resize_window_check, resize_root_window): Now static.
4443 * window.h (resize_window_check, resize_root_window): Remove decls.
4444
109e28d0
PE
4445 * window.c (window_deletion_count, delete_deletable_window):
4446 Remove; unused.
46a4ce9e
PE
4447 (window_body_lines): Now static.
4448 (Fdelete_other_windows_internal): Mark vars as initialized.
4449 Make sure 'resize_failed' is initialized.
4450 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4451 (resize_window_apply): Remove unused local.
4452 * window.h (delete_deletable_window): Remove decl.
4453
109e28d0 4454 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4455 (imagemagick_load_image): Fix pointer signedness problem by changing
4456 last arg from unsigned char * to char *. All uses changed.
4457 Also, fix a local for similar reasons.
4458 Remove unused locals. Remove locals to avoid shadowing.
4459 (fn_rsvg_handle_free): Remove; unused.
4460 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4461 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4462
3f754b86
PE
4463 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4464
2547adb1
CY
44652011-06-10 Chong Yidong <cyd@stupidchicken.com>
4466
4467 * image.c (gif_load): Fix omitted cast error introduced by
4468 2011-06-06 change.
4469
2c8e37d4
MR
44702011-06-10 Martin Rudalics <rudalics@gmx.at>
4471
4472 * window.h (resize_proportionally, orig_total_lines)
4473 (orig_top_line): Remove from window structure.
4474 (set_window_height, set_window_width, change_window_heights)
4475 (Fdelete_window): Remove prototypes.
4476 (resize_frame_windows): Remove duplicate declaration.
4477
440a42e3
EZ
44782011-06-10 Eli Zaretskii <eliz@gnu.org>
4479
4480 * window.h (resize_frame_windows, resize_window_check)
4481 (delete_deletable_window, resize_root_window)
4482 (resize_frame_windows): Declare prototypes.
4483
4484 * window.c (resize_window_apply): Make definition be "static" to
4485 match the prototype.
4486
562dd5e9
MR
44872011-06-10 Martin Rudalics <rudalics@gmx.at>
4488
4489 * window.c: Remove declarations of Qwindow_size_fixed,
4490 window_min_size_1, window_min_size_2, window_min_size,
4491 size_window, window_fixed_size_p, enlarge_window, delete_window.
4492 Remove static from declaration of Qdelete_window, it's
4493 temporarily needed by Fbury_buffer.
4494 (replace_window): Don't assign orig_top_line and
4495 orig_total_lines.
4496 (Fdelete_window, delete_window): Remove. Window deletion is
4497 handled by window.el.
640c8776
SM
4498 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4499 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4500 (Fdelete_other_windows): Remove. Deleting other windows is
4501 handled by window.el.
4502 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4503 handled in window.el.
4504 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4505 Window minimum sizes are handled in window.el.
4506 (shrink_windows, size_window, set_window_height)
4507 (set_window_width, change_window_heights, window_height)
4508 (window_width, CURBEG, CURSIZE, enlarge_window)
4509 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4510 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4511 handled in window.el.
4512 (make_dummy_parent): Rename to make_parent_window and give it a
4513 second argument horflag.
4514 (make_window): Don't set resize_proportionally any more.
4515 (Fsplit_window): Remove. Windows are split in window.el.
4516 (save_restore_action, save_restore_orig_size)
4517 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4518 Resize mini windows in window.el.
4519 (grow_mini_window, shrink_mini_window): Implement by calling
4520 Qresize_root_window_vertically, resize_window_check and
4521 resize_window_apply.
640c8776
SM
4522 (saved_window, Fset_window_configuration, save_window_save):
4523 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4524 resize_proportionally.
4525 (window_min_height, window_min_width): Move to window.el.
4526 (keys_of_window): Move bindings for delete-other-windows,
4527 split-window, delete-window and enlarge-window to window.el.
4528
4529 * buffer.c: Temporarily extern Qdelete_window.
4530 (Fbury_buffer): Temporarily call Qdelete_window instead of
4531 Fdelete_window (Fbury_buffer will move to window.el soon).
4532
4533 * frame.c (set_menu_bar_lines_1): Remove code handling
4534 orig_top_line and orig_total_lines.
4535
4536 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4537 set_window_height but set heights directly.
4538 (change_frame_size_1): Use resize_frame_windows.
4539
4540 * xdisp.c (init_xdisp): Don't use set_window_height but set
4541 heights directly.
4542
640c8776
SM
4543 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4544 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4545 run_window_configuration_change_hook.
4546
4547 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4548 instead of change_window_heights and run
4549 run_window_configuration_change_hook.
4550
1a13852e
MR
45512011-06-09 Martin Rudalics <rudalics@gmx.at>
4552
4553 * window.c (replace_window): Rename second argument REPLACEMENT to
4554 NEW. New third argument SETFLAG. Rewrite.
4555 (delete_window, make_dummy_parent): Call replace_window with
4556 third argument 1.
4557 (window_list_1): Move down in code.
4558 (run_window_configuration_change_hook): Move set_buffer part
4559 before select_frame_norecord part in order to unwind correctly.
4560 Rename count1 to count.
4561 (recombine_windows, delete_deletable_window, resize_root_window)
4562 (Fdelete_other_windows_internal)
4563 (Frun_window_configuration_change_hook, make_parent_window)
4564 (resize_window_check, resize_window_apply, Fresize_window_apply)
4565 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4566 (Fdelete_window_internal, Fresize_mini_window_internal):
4567 New functions.
1a13852e
MR
4568 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4569
f3d1777e
MR
45702011-06-08 Martin Rudalics <rudalics@gmx.at>
4571
496e208e
MR
4572 * window.h (window): Add some new members to window structure -
4573 normal_lines, normal_cols, new_total, new_normal, clone_number,
4574 splits, nest, prev_buffers, next_buffers.
4575 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4576 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4577
f3d1777e
MR
4578 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4579 Remove.
496e208e
MR
4580 (make_dummy_parent): Set new members of windows structure.
4581 (make_window): Move down in code. Handle new members of window
4582 structure.
4583 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4584 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4585 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4586 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4587 (Fset_window_next_buffers, Fset_window_clone_number):
4588 New functions.
496e208e
MR
4589 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4590 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4591 Doc-string fixes.
4592 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4593 Argument WINDOW can be now internal window too.
4594 (Fwindow_use_time): Move up in code.
4595 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4596 Rewrite doc-string.
4597 (Fset_window_configuration, saved_window)
4598 (Fcurrent_window_configuration, save_window_save): Handle new
4599 members of window structure.
b9e809c2
MR
4600 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4601 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4602 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4603 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4604 Qget_mru_window, Qresize_root_window,
4605 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4606 Qauto_buffer_name; staticpro them.
f3d1777e 4607
abde8f8c
MR
46082011-06-07 Martin Rudalics <rudalics@gmx.at>
4609
4610 * window.c (Fwindow_total_size, Fwindow_left_column)
4611 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4612 (Fwindow_list_1): New functions.
4613 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4614 (Fwindow_width, Fscroll_left, Fscroll_right):
4615 Use window_body_cols instead of window_box_text_cols.
4616 (delete_window, Fset_window_configuration):
4617 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4618 (delete_all_subwindows): Take a window as argument and not a
4619 structure. Rewrite.
190b47e6
MR
4620 (window_loop): Remove handling of GET_LRU_WINDOW and
4621 GET_LARGEST_WINDOW.
4622 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4623
4624 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4625 window_box_text_cols. delete_all_subwindows now takes a
4626 Lisp_Object as argument.
abde8f8c 4627
640c8776
SM
4628 * indent.c (compute_motion, Fcompute_motion):
4629 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4630
fa8a67e6
MR
4631 * frame.c (delete_frame): Call delete_all_subwindows with root
4632 window as argument.
4633
a54e3482
DC
46342011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4635
4636 * fns.c (Fputhash): Document return value.
4637
60002bf5
CY
46382011-06-06 Chong Yidong <cyd@stupidchicken.com>
4639
4640 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4641
0c671da6 46422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4643
b862a52a 4644 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4645
be44ca6c
PE
4646 Check for overflow when converting integer to cons and back.
4647 * charset.c (Fdefine_charset_internal, Fdecode_char):
4648 Use cons_to_unsigned to catch overflow.
4649 (Fencode_char): Use INTEGER_TO_CONS.
4650 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4651 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4652 * data.c (long_to_cons, cons_to_long): Remove.
4653 (cons_to_unsigned, cons_to_signed): New functions.
4654 These signal an error for invalid or out-of-range values.
4655 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4656 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4657 * font.c (Ffont_variation_glyphs):
4658 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4659 * lisp.h: Include <intprops.h>.
4660 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4661 (cons_to_signed, cons_to_unsigned): New decls.
4662 (long_to_cons, cons_to_long): Remove decls.
4663 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4664 (Fprimitive_undo): Use CONS_TO_INTEGER.
4665 * xfns.c (Fx_window_property): Likewise.
4666 * xselect.c: Include <limits.h>.
4667 (x_own_selection, selection_data_to_lisp_data):
4668 Use INTEGER_TO_CONS.
4669 (x_handle_selection_request, x_handle_selection_clear)
4670 (x_get_foreign_selection, Fx_disown_selection_internal)
4671 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4672 (lisp_data_to_selection_data): Use cons_to_unsigned.
4673 (x_fill_property_data): Use cons_to_signed.
4674 Report values out of range.
4675
d1f3d2af
PE
4676 Check for buffer and string overflow more precisely.
4677 * buffer.h (BUF_BYTES_MAX): New macro.
4678 * lisp.h (STRING_BYTES_MAX): New macro.
4679 * alloc.c (Fmake_string):
4680 * character.c (string_escape_byte8):
4681 * coding.c (coding_alloc_by_realloc):
4682 * doprnt.c (doprnt):
4683 * editfns.c (Fformat):
4684 * eval.c (verror):
4685 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4686 since they may not be the same number.
4687 * editfns.c (Finsert_char):
4688 * fileio.c (Finsert_file_contents):
4689 Likewise for BUF_BYTES_MAX.
4690
dd52fcea
PE
4691 * image.c: Use ptrdiff_t, not int, for sizes.
4692 (slurp_file): Switch from int to ptrdiff_t.
4693 All uses changed.
4694 (slurp_file): Check that file size fits in both size_t (for
4695 malloc) and ptrdiff_t (for sanity and safety).
4696
7f9bbdbb
PE
4697 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4698 if b->modtime has its maximal value.
4699
dfe18f82
PE
4700 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4701
84acfcf0
PE
4702 Don't assume time_t can fit into int.
4703 * buffer.h (struct buffer.modtime): Now time_t, not int.
4704 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4705 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4706
ccd9a01a
PE
4707 Minor fixes for signed vs unsigned integers.
4708 * character.h (MAYBE_UNIFY_CHAR):
4709 * charset.c (maybe_unify_char):
4710 * keyboard.c (read_char, reorder_modifiers):
4711 XINT -> XFASTINT, since the integer must be nonnegative.
4712 * ftfont.c (ftfont_spec_pattern):
4713 * keymap.c (access_keymap, silly_event_symbol_error):
4714 XUINT -> XFASTINT, since the integer must be nonnegative.
4715 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4716 since it makes no difference and we prefer signed.
4717 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4718 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4719 nonnegative.
4720
d6d100dd
SM
47212011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4722
4723 * window.h (Fwindow_frame): Declare.
4724
2b6148e4
PE
47252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4726
4727 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4728 (SPARE_MEMORY): Always define.
4729 (LARGE_REQUEST): Remove.
4730 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4731
f230ecc9
MR
47322011-06-06 Martin Rudalics <rudalics@gmx.at>
4733
727e958e
MR
4734 * lisp.h: Move EXFUNS for Fframe_root_window,
4735 Fframe_first_window and Fset_frame_selected_window to window.h.
4736
4737 * window.h: Move EXFUNS for Fframe_root_window,
4738 Fframe_first_window and Fset_frame_selected_window here from
4739 lisp.h.
4740
4741 * frame.c (Fwindow_frame, Fframe_first_window)
4742 (Fframe_root_window, Fframe_selected_window)
4743 (Fset_frame_selected_window): Move to window.c.
4744 (Factive_minibuffer_window): Move to minibuf.c.
4745 (Fother_visible_frames_p): New function.
4746
4747 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4748
f230ecc9
MR
4749 * window.c (decode_window, decode_any_window): Move up in code.
4750 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4751 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4752 (Fwindow_buffer): Move up and rewrite doc-string.
4753 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4754 (Fwindow_prev): New functions.
727e958e
MR
4755 (Fwindow_frame): Move here from frame.c. Accept any window as
4756 argument.
4757 (Fframe_root_window, Fframe_first_window)
4758 (Fframe_selected_window): Move here from frame.c. Accept frame
4759 or arbitrary window as argument. Update doc-strings.
4760 (Fminibuffer_window): Move up in code.
4761 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4762 (Fset_frame_selected_window): Move here from frame.c.
4763 Marginal rewrite.
727e958e
MR
4764 (Fselected_window, select_window, Fselect_window): Move up in
4765 code. Minor doc-string fixes.
f230ecc9 4766
4d09bcf6
PE
47672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4768
4769 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4770 Do not assume that spare memory exists; that assumption is valid
4771 only if SYSTEM_MALLOC.
4772 (LARGE_REQUEST): New macro, so that the issue of large requests
4773 is separated from the issue of spare memory.
4774
810928a2
AS
47752011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4776
172418ad
AS
4777 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4778 format. (Bug#8806)
4779
43f862f7
AS
4780 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4781
810928a2
AS
4782 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4783 before statements.
4784
a059fe24
JD
47852011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4786
4787 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4788
4789 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4790
4791 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4792 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4793
989bf368
JB
47942011-06-05 Juanma Barranquero <lekktu@gmail.com>
4795
4796 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4797
4b80f674
CY
47982011-06-04 Chong Yidong <cyd@stupidchicken.com>
4799
4800 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4801 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4802 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4803 New error handlers.
4b80f674
CY
4804 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4805 Obey Vx_select_enable_clipboard_manager. Catch errors in
4806 x_clipboard_manager_save (Bug#8779).
4807 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4808 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4809
99a33b77 48102011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4811
4812 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4813
99a33b77 48142011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4815
4816 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4817 in the current matrix if keep_current_p is non-zero.
4818
8264569d
EZ
48192011-06-04 Eli Zaretskii <eliz@gnu.org>
4820
4821 * bidi.c (bidi_level_of_next_char): Fix last change.
4822
57f97249
EZ
48232011-06-03 Eli Zaretskii <eliz@gnu.org>
4824
fec2107c 4825 Support bidi reordering of text covered by display properties.
57f97249 4826
fec2107c
EZ
4827 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4828 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4829 (bidi_cache_search, bidi_cache_iterator_state)
4830 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4831 (bidi_level_of_next_char, bidi_move_to_visually_next):
4832 Support character positions inside a run of characters covered by a
fec2107c
EZ
4833 display string.
4834 (bidi_paragraph_init, bidi_resolve_explicit_1)
4835 (bidi_level_of_next_char): Call bidi_fetch_char and
4836 bidi_fetch_char_advance instead of FETCH_CHAR and
4837 FETCH_CHAR_ADVANCE.
4838 (bidi_init_it): Initialize new members.
4839 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4840 definitions.
4841 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4842 instead of using explicit *_CHAR codes.
d6d100dd
SM
4843 (bidi_resolve_explicit, bidi_resolve_weak):
4844 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4845 bidirectional text is supported only in multibyte buffers.
4846 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4847 it to initialize the frame_window_p member of struct bidi_it.
4848 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4849 (bidi_resolve_explicit, bidi_resolve_weak)
4850 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4851 bidi_it->nchars is non-positive.
4852 (bidi_level_of_next_char): Don't try to lookup the cache for the
4853 next/previous character if nothing is cached there yet, or if we
4854 were just reseat()'ed to a new position.
c40e2fb2 4855
0e14fe90
EZ
4856 * xdisp.c (set_cursor_from_row): Set start and stop points
4857 according to the row's direction when priming the loop that looks
4858 for the glyph on which to display cursor.
4859 (single_display_spec_intangible_p): Function deleted.
4860 (display_prop_intangible_p): Reimplement to call
4861 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4862 Accept 3 additional arguments needed by handle_display_spec.
4863 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4864 values: lists, `(when COND...)' forms, etc.
4865 (single_display_spec_string_p): Support property values that are
4866 lists with the argument STRING its top-level element.
4867 (display_prop_string_p): Fix the condition for processing a
4868 property that is a list to be consistent with handle_display_spec.
fec2107c 4869 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4870 last portion of handle_display_prop.
4871 (compute_display_string_pos): Accept additional argument
4872 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4873 value of a `display' property is a "replacing spec".
4874 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4875 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4876 the display property, but just return a value indicating whether
4877 the display property will replace the characters it covers.
4878 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4879 frame_window_p members of struct bidi_it.
d6d100dd
SM
4880 (compute_display_string_pos, compute_display_string_end):
4881 New functions.
fec2107c
EZ
4882 (push_it): Accept second argument POSITION, where pop_it should
4883 jump to continue iteration.
4884 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4885
fec2107c
EZ
4886 * keyboard.c (adjust_point_for_property): Adjust the call to
4887 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4888
4889 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4890 (bidi_init_it): Update prototypes.
4891 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4892 (compute_display_string_pos, compute_display_string_end):
4893 Declare prototypes.
fec2107c
EZ
4894 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4895 EMACS_INT.
fc6f18ce 4896
40087514 48972011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4898
57f53182
PE
4899 Malloc failure behavior now depends on size of allocation.
4900 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4901 * lisp.h: Change signatures accordingly.
4902 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4903 All callers changed. (Bug#8762)
4904
4905 * gnutls.c: Use Emacs's memory allocators.
4906 Without this change, the gnutls library would invoke malloc etc.
4907 directly, which causes problems on non-SYNC_INPUT hosts, and which
4908 runs afoul of improving memory_full behavior. (Bug#8761)
4909 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4910 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4911 xfree instead of the default malloc, realloc, free.
4912 (Fgnutls_boot): No need to check for memory allocation failure,
4913 since xmalloc does that for us.
4914
ac32cd99 4915 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4916 * category.c (hash_get_category_set):
4917 * ccl.c (ccl_driver):
4918 * charset.c (Fdefine_charset_internal):
4919 * charset.h (struct charset.hash_index):
4920 * composite.c (get_composition_id, gstring_lookup_cache)
4921 (composition_gstring_put_cache):
4922 * composite.h (struct composition.hash_index):
4923 * dispextern.h (struct image.hash):
4924 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4925 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4926 (hashfn_equal, hashfn_user_defined, make_hash_table)
4927 (maybe_resize_hash_table, hash_lookup, hash_put)
4928 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4929 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4930 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4931 * image.c (make_image, search_image_cache, lookup_image)
4932 (xpm_put_color_table_h):
4933 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4934 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4935 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4936 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4937 * alloc.c (allocate_vectorlike):
4938 Check for overflow in vector size calculations.
4939 * ccl.c (ccl_driver):
4940 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4941 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4942 need to be updated by these changes.
40087514
PE
4943 * fns.c (make_hash_table, maybe_resize_hash_table):
4944 Check for integer overflow with large hash tables.
0de4bb68
PE
4945 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4946 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4947 (SXHASH_REDUCE): New macro.
4948 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4949 Use it instead of discarding useful hash info with large hash values.
4950 (sxhash_float): New function.
4951 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4952 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4953 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4954 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4955 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4956 Adjust signatures to match updated version of code.
4957 (consing_since_gc): Now EMACS_INT, since a single hash table can
4958 use more than INT_MAX bytes.
4959
698d32e2
DN
49602011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4961
4962 Make it possible to build with GCC-4.6+ -O2 -flto.
4963
4964 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4965
fd6fa53f
SM
49662011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4967
4968 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4969 Call minibuffer-inactive-mode.
4970
864db017
JB
49712011-05-31 Juanma Barranquero <lekktu@gmail.com>
4972
4973 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4974 Update dependencies.
4975
2ad0baf4
DN
49762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4977
4978 * data.c (init_data): Remove code for UTS, this system is not
4979 supported anymore.
4980
4fcc2638
DN
49812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4982
4983 Don't force ./temacs to start in terminal mode.
4984
4985 * frame.c (make_initial_frame): Initialize faces in all cases, not
4986 only when CANNOT_DUMP is defined.
4987 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4988
c56e0fd5
DN
49892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4990
4991 * dispnew.c (add_window_display_history): Use const for the string
4992 pointer. Remove declaration, not needed.
4993
333d54da 49942011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4995
55d4c1b2 4996 Use 'inline', not 'INLINE'.
333d54da 4997 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4998 * alloc.c, fontset.c (INLINE): Remove.
4999 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5000 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5001 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5002 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5003 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5004
738db178
DN
50052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5006
5007 Make it possible to run ./temacs.
5008
5009 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5010 syms_of_callproc does the same thing. Remove test for
5011 "initialized", do it in the caller.
5012 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5013
620c53a6
SM
50142011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5015
5016 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5017 (read_minibuf): Use get_minibuffer.
5018 (syms_of_minibuf): Use DEFSYM.
5019 (Qmetadata): New var.
5020 * data.c (Qbuffer): Don't make it static.
5021 (syms_of_data): Use DEFSYM.
5022
e003a292
PE
50232011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5024
5025 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5026 (CCL_CODE_MIN): New macro.
5027
ed008a6d
PE
50282011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5029
3687c2ef
PE
5030 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5031
ed008a6d
PE
5032 * eval.c (Qdebug): Now static.
5033 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5034 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5035 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5036
d66c4c7c
CY
50372011-05-29 Chong Yidong <cyd@stupidchicken.com>
5038
5039 * image.c: Various fixes to ImageMagick code comments.
5040 (Fimagemagick_types): Doc fix.
5041
5fbc2025
PE
50422011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5043
0196f88a
PE
5044 Minor fixes prompted by GCC 4.6.0 warnings.
5045
5046 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5047
5fbc2025
PE
5048 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5049 (x_clipboard_manager_save_all): Move extern decl to ...
5050 * xterm.h: ... here, so that it can be checked for consistency.
5051
1dd3c2d9
CY
50522011-05-29 Chong Yidong <cyd@stupidchicken.com>
5053
5054 * xselect.c (x_clipboard_manager_save_frame)
5055 (x_clipboard_manager_save_all): New functions.
5056 (Fx_clipboard_manager_save): Lisp function deleted.
5057
5058 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5059 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5060
5061 * xterm.h: Update prototype.
5062
5ba6571d
WX
50632011-05-28 William Xu <william.xwl@gmail.com>
5064
5065 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5066 exiting (Bug#8239).
5067
3eaff834
JM
50682011-05-28 Jim Meyering <meyering@redhat.com>
5069
e1900994 5070 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5071 * fns.c (to_uchar): Define.
5072 (crypto_hash_function): Use it to convert some newly-signed
5073 variables to unsigned, to avoid sign-extension bugs. For example,
5074 without this change, (md5 "truc") would evaluate to
5075 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5076 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5077 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5078
0f6990a7
PE
50792011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5080
5081 Integer overflow fixes.
c8a9ca5a 5082
08686060
PE
5083 * dbusbind.c: Serial number integer overflow fixes.
5084 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5085 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5086 to hold a serial number that is too large for a fixnum.
5087 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5088 Check for serial numbers out of range. Decode any serial number
59568bf0 5089 that was so large that it became a float. (Bug#8722)
08686060 5090
2d1fc3c7
PE
5091 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5092 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5093 Use XFASTINT rather than XUINT when numbers are nonnegative.
5094 (xd_append_arg, Fdbus_method_return_internal):
5095 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5096 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5097 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5098 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5099 (Bug#8722)
2d1fc3c7 5100
c8a9ca5a
PE
5101 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5102
519e1d69
PE
5103 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5104
30569699
PE
5105 ccl: add integer overflow checks
5106 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5107 (IN_INT_RANGE): New macros.
5108 (ccl_driver): Use them to check for integer overflow when
5109 decoding a CCL program. Many of the new checks are whether XINT (x)
5110 fits in int; it doesn't always, on 64-bit hosts. The new version
5111 doesn't catch all possible integer overflows, but it's an
847044ea 5112 improvement. (Bug#8719)
30569699 5113
c11285dc
PE
5114 * alloc.c (make_event_array): Use XINT, not XUINT.
5115 There's no need for unsigned here.
5116
fdccd48e
PE
5117 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5118 This follows up to the 2011-05-06 change that substituted uintptr_t
5119 for EMACS_INT. This case wasn't caught back then.
5120
37910ab2
PE
5121 Rework Fformat to avoid integer overflow issues.
5122 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5123 now (part of C89). Include <verify.h>.
5124 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5125 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5126 (Fformat): Avoid the prepass trying to compute sizes; it was only
5127 approximate and thus did not catch overflow reliably. Instead, walk
5128 through the format just once, formatting and computing sizes as we go,
5129 checking for integer overflow at every step, and allocating a larger
5130 buffer as needed. Keep track separately whether the format is
5131 multibyte. Keep only the most-recently calculated precision, rather
5132 than them all. Record whether each argument has been converted to
5133 string. Use EMACS_INT, not int, for byte and char and arg counts.
5134 Support field widths and precisions larger than INT_MAX. Avoid
5135 sprintf's undefined behavior with conversion specifications such as %#d
5136 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5137 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5138 formatting out-of-range floating point numbers with int
9173deec 5139 formats. (Bug#8668)
37910ab2 5140
2e6578fb
PE
5141 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5142
0ae6bdee
PE
5143 * data.c: Avoid integer truncation in expressions involving floats.
5144 * data.c: Include <intprops.h>.
5145 (arith_driver): When there's an integer overflow in an expression
5146 involving floating point, convert the integers to floating point
5147 so that the resulting value does not suffer from catastrophic
5148 integer truncation. For example, on a 64-bit host (* 4
5149 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5150 Do not rely on undefined behavior after integer overflow.
5151
de883a70
PE
5152 merge count_size_as_multibyte, parse_str_to_multibyte
5153 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5154 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5155 Check for integer overflow.
5156 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5157 since it's now a duplicate of the other. This is more of
5158 a character than a buffer op, so better that it's in character.c.
5159 * fns.c, print.c: Adjust to above changes.
5160
2ff916cb
PE
51612011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5162
5163 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5164
f1b54466
PE
51652011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5166
fb1ac845
PE
5167 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5168 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5169 (x_clipboard_manager_save): Now static.
5170 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5171
f1b54466
PE
5172 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5173 (crypto_hash_function): Now static.
5174 Fix pointer signedness problems. Avoid unnecessary initializations.
5175
a9f737ee
CY
51762011-05-27 Chong Yidong <cyd@stupidchicken.com>
5177
5178 * termhooks.h (Vselection_alist): Make it terminal-local.
5179
5180 * terminal.c (create_terminal): Initialize it.
5181
5182 * xselect.c: Support for clipboard managers.
5183 (Vselection_alist): Move to termhooks.h as terminal-local var.
5184 (LOCAL_SELECTION): New macro.
5185 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5186 (symbol_to_x_atom): Remove gratuitous arg.
5187 (x_handle_selection_request, lisp_data_to_selection_data)
5188 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5189 (x_own_selection, x_get_local_selection, x_convert_selection):
5190 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5191 (some_frame_on_display): Delete unused function.
5192 (Fx_own_selection_internal, Fx_get_selection_internal)
5193 (Fx_disown_selection_internal, Fx_selection_owner_p)
5194 (Fx_selection_exists_p): New optional frame arg.
5195 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5196 (x_handle_selection_clear): Don't treat other terminals with the
5197 same keyboard specially. Use the terminal-local Vselection_alist.
5198 (x_clear_frame_selections): Use Frun_hook_with_args.
5199
5200 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5201
5202 * xterm.h: Add support for those atoms.
5203
e067f0c1
CY
52042011-05-26 Chong Yidong <cyd@stupidchicken.com>
5205
5206 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5207 (converted_selections, conversion_fail_tag): New global variables.
5208 (x_selection_request_lisp_error): Free the above.
5209 (x_get_local_selection): Remove unnecessary code.
5210 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5211 of converted selections stored in converted_selections.
5212 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5213 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5214 (x_convert_selection): New function.
5215 (x_handle_selection_event): Simplify.
5216 (x_get_foreign_selection): Don't ignore incoming requests while
5217 waiting for an answer; this will fail when we implement
5218 SAVE_TARGETS, and seems unnecessary anyway.
5219 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5220 (Vx_sent_selection_functions): Doc fix.
5221
0f4aebc0
LL
52222011-05-26 Leo Liu <sdl.web@gmail.com>
5223
5224 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5225
e61124cd
YM
52262011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5227
5228 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5229
5230 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5231 for fringe update if it has periodic bitmap.
ac389d0c 5232 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5233 and fringe_bitmap_periodic_p.
5234
5235 * fringe.c (get_fringe_bitmap_data): New function.
5236 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5237 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5238 row. Mark glyph row for fringe update if periodicity changed.
5239
5240 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5241 for fringe update unless it has periodic bitmap.
5242
f16d9837
KH
52432011-05-25 Kenichi Handa <handa@m17n.org>
5244
5245 * xdisp.c (get_next_display_element): Set correct it->face_id for
5246 a static composition.
5247
e1b90ef6
LL
52482011-05-24 Leo Liu <sdl.web@gmail.com>
5249
5250 * deps.mk (fns.o):
5251 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5252
5253 * fns.c (crypto_hash_function, Fsha1): New function.
5254 (Fmd5): Use crypto_hash_function.
5255 (syms_of_fns): Add Ssha1.
5256
7400048f
PE
52572011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5258
5259 * gnutls.c: Remove unused macros.
5260 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5261 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5262 Remove macros that are defined and never used.
5263 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5264
abb71cf4
CY
52652011-05-22 Chong Yidong <cyd@stupidchicken.com>
5266
5267 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5268 (Fx_get_selection_internal): Minor cleanup.
5269 (Fx_own_selection_internal): Rename arguments for consistency with
5270 select.el.
5271
6307db39
PE
52722011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5273
5274 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5275
f3d4e0a4
CY
52762011-05-22 Chong Yidong <cyd@stupidchicken.com>
5277
5278 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5279
4d8ade89
YM
52802011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5281
5282 * dispnew.c (scrolling_window): Don't exclude the case that the
5283 last enabled row in the desired matrix touches the bottom boundary.
5284
32078c8d
GM
52852011-05-21 Glenn Morris <rgm@gnu.org>
5286
5287 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5288 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5289 and add some more files.
32078c8d 5290
7285dc67
EZ
52912011-05-20 Eli Zaretskii <eliz@gnu.org>
5292
5293 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5294 report_file_error introduced by the change from 2011-05-07.
5295
89d1bd22
PE
52962011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5297
5298 * systime.h (Time): Define only if emacs is defined.
5299 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5300 where the include path doesn't have X11/X.h by default. See
5301 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5302
e23640bb 53032011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5304
5305 * composite.c (find_automatic_composition): Fix previous change.
5306
b9704ad9
GM
53072011-05-20 Glenn Morris <rgm@gnu.org>
5308
5309 * lisp.mk: New file, split from Makefile.in.
5310 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5311 (shortlisp): Remove.
5312 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5313
4a720484
GM
53142011-05-19 Glenn Morris <rgm@gnu.org>
5315
5316 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5317 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5318 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5319 (lisp): Set the order to that of loadup.el.
5320 (shortlisp): Make it a copy of $lisp.
5321 (SOME_MACHINE_LISP): Remove.
5322 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5323 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5324
a28d4396
KH
53252011-05-18 Kenichi Handa <handa@m17n.org>
5326
5327 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5328 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5329 (find_automatic_composition): Mostly rewrite for efficiency.
5330
a2b1fa8e
JB
53312011-05-18 Juanma Barranquero <lekktu@gmail.com>
5332
5333 * makefile.w32-in: Update dependencies.
5334
8e1f5610
CS
53352011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5336
5337 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5338 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5339
7025ee00 53402011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5341
cdfa6eab
PE
5342 Fix some integer overflow issues, such as string length overflow.
5343
06d6db33
PE
5344 * insdel.c (count_size_as_multibyte): Check for string overflow.
5345
2b4560a8
PE
5346 * character.c (lisp_string_width): Check for string overflow.
5347 Use EMACS_INT, not int, for string indexes and lengths; in
5348 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5349 the resulting string length overflows an EMACS_INT; instead,
5350 report a string overflow if no precision given. When checking for
5351 precision exhaustion, use a check that cannot possibly have
5352 integer overflow. (Bug#8675)
5353 * character.h (lisp_string_width): Adjust to new signature.
5354
cb93f9be
PE
5355 * alloc.c (string_overflow): New function.
5356 (Fmake_string): Use it. This doesn't change behavior, but saves
5357 a few bytes and will simplify future changes.
5358 * character.c (string_escape_byte8): Likewise.
5359 * lisp.h (string_overflow): New decl.
5360
1a1f3366
PE
5361 Fixups, following up to the user-interface timestamp change.
5362 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5363 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5364 * msdos.c (mouse_get_pos): Likewise.
5365 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5366 * w32gui.h (Time): Define by including "systime.h" rather than by
5367 declaring it ourselves. (Bug#8664)
5368
d4e3e4d3
PE
5369 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5370 * image.c (clear_image_cache): Likewise.
5371
f6a24d19
PE
5372 * term.c (term_mouse_position): Don't assume time_t wraparound.
5373
08dc5ae6
PE
5374 Be more systematic about user-interface timestamps.
5375 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5376 and sometimes 'EMACS_UINT', to represent these timestamps.
5377 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5378 This makes the code easier to follow, and makes it easier to catch
5379 integer overflow bugs such as Bug#8664.
5380 * frame.c (Fmouse_position, Fmouse_pixel_position):
5381 Use Time, not unsigned long, for user-interface timestamps.
5382 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5383 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5384 * keyboard.h (last_event_timestamp): Likewise.
5385 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5386 * menu.h (xmenu_show): Likewise.
5387 * term.c (term_mouse_position): Likewise.
5388 * termhooks.h (struct input_event.timestamp): Likewise.
5389 (struct terminal.mouse_position_hook): Likewise.
5390 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5391 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5392 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5393 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5394 what it was before.
5395 * menu.h, termhooks.h: Include "systime.h", for Time.
5396
8e55734a
PE
5397 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5398 Don't assume that the difference between two unsigned long values
5399 can fit into an integer. At this point, we know button_down_time
5400 <= event->timestamp, so the difference must be nonnegative, so
5401 there's no need to cast the result if double-click-time is
5402 nonnegative, as it should be; check that it's nonnegative, just in
5403 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5404 apart (about 25 days). (Bug#8664)
8e55734a 5405
841f1b75 5406 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5407 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5408
3e26f69c
PE
5409 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5410 that always fit in int. Use a sentinel instead of a counter, to
5411 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5412 * frame.h (struct frame): Use int for menu_bar_items_used
5413 instead of EMACS_INT, since it always fits in int.
3e26f69c 5414
5cc152c0
PE
5415 * menu.c (grow_menu_items): Check for int overflow.
5416
d89eb65e
PE
5417 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5418
5235bd3e
PE
5419 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5420 Before, the code was not consistent. These values cannot exceed
5421 2**31 - 1 so there's no need to make them unsigned.
5422 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5423 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5424 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5425 as modifiers.
5426 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5427
bc827e23
PE
5428 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5429 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5430 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5431 presumably because the widths might not match.
5432
78eb494e
PE
5433 * window.c (size_window): Avoid needless test at loop start.
5434
04f2d78b
CB
54352011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5436
5437 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5438
d2fc7e3d 54392011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5440
5441 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5442
d2fc7e3d 54432011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5444
5445 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5446 `width' to `bar_area_x' and `bar_area_width', respectively.
5447 (x_scroll_run): Take account of fringe background extension.
5448
04f2d78b
CB
5449 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5450 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5451 `bar_area_width', respectively.
5452 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5453 background extension.
5454
79b70037
GM
54552011-05-10 Jim Meyering <meyering@redhat.com>
5456
5457 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5458
2f142cc5
JB
54592011-05-10 Juanma Barranquero <lekktu@gmail.com>
5460
5461 * image.c (Finit_image_library): Return t for built-in image types,
5462 like pbm and xbm. (Bug#8640)
5463
57679c86
AS
54642011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5465
5466 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5467
888c9e86
EZ
54682011-05-07 Eli Zaretskii <eliz@gnu.org>
5469
b0512a1d
EZ
5470 * w32console.c (Fset_screen_color): Doc fix.
5471 (Fget_screen_color): New function.
5472 (syms_of_ntterm): Defsubr it.
5473
7285dc67
EZ
5474 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5475 unlink the temporary file if Fcall_process didn't create it in the
5476 first place.
5477 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5478 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5479 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5480 cue to call_process_cleanup not to close that handle.
5481
4d3fcc8e
BK
54822011-05-07 Ben Key <bkey76@gmail.com>
5483
5484 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5485 one of two shell specific rules, either bootstrap-temacs-CMD or
5486 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5487 to the previous implementation of the bootstrap-temacs rule.
5488 The bootstrap-temacs-CMD rule is similar to the previous
5489 implementation of the bootstrap-temacs rule except that it
5490 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5491 variable.
5492
5493 These changes, along with some changes to nt/configure.bat,
5494 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5495 earlier fix to add support for --cflags and --ldflags options
5496 that include quotes so that it works whether make uses cmd or
5497 sh as the shell.
5498
b4289b64
MA
54992011-05-06 Michael Albinus <michael.albinus@gmx.de>
5500
5501 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5502 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5503 is a constant.
5504 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5505 a string. Handle both cases.
5506 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5507 (Fdbus_register_method): Use Qinvalid_function.
5508
af4c0e28
JB
55092011-05-06 Juanma Barranquero <lekktu@gmail.com>
5510
5511 * makefile.w32-in: Update dependencies.
5512 (LISP_H): Add inttypes.h and stdin.h.
5513 (PROCESS_H): Add unistd.h.
5514
c51453d9
EZ
55152011-05-06 Eli Zaretskii <eliz@gnu.org>
5516
5517 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5518 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5519
8ff0ac3c 55202011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5521
4c4b566b
PE
5522 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5523
aab2b9b5
PE
5524 * term.c (vfatal): Remove stray call to va_end.
5525 It's not needed and the C Standard doesn't allow it here anyway.
5526
c378da0b
PE
5527 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5528 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5529
288b08c7
PE
5530 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5531 bytes.
5532
e3601888
PE
5533 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5534
db6c0e74
PE
5535 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5536
dd5963ea
PE
5537 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5538
88c9450f
PE
5539 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5540
2f9442b8
PE
5541 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5542
c032b5f8
PE
5543 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5544 * charset.c (Fdefine_charset_internal): Don't initialize
5545 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5546 32-bit int (Bug#8600).
a108c10b
PE
5547
5548 * lread.c (read_integer): Be more consistent with string-to-number.
5549 Use string_to_number to do the actual conversion; this avoids
5550 rounding errors and fixes some other screwups. Without this fix,
5551 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5552 (digit_to_number): Move earlier, for benefit of read_integer.
5553 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5554 not a digit in any supported base. (Bug#8602)
a108c10b 5555
ad5f9eea
PE
5556 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5557
aec1708a
PE
5558 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5559 to match comment at start of function. This also removes a
5560 GCC warning about overflow in a 32+64-bit port.
5561
47be4ab5
PE
5562 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5563
371cac43
PE
5564 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5565 Reported by Stefan Monnier in
5566 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5567 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5568 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5569
d01a7826
PE
5570 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5571 (EMACS_UINTPTR): Likewise, with uintptr_t.
5572
7fd47d5c
PE
5573 * lisp.h: Prefer 64-bit EMACS_INT if available.
5574 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5575 on 32-bit hosts that have 64-bit int, so that they can access
5576 large files.
122b0c86
PE
5577 However, temporarily disable this change unless the temporary
5578 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5579
8727937b
PE
5580 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5581
8ac068ac
PE
5582 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5583 This removes an assumption that EMACS_INT and long are the same
5584 width as pointers. The assumption is true for Emacs porting targets
5585 now, but we want to make other targets possible.
5586 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5587 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5588 In the rest of the code, change types of integers that hold casted
5589 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5590 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5591 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5592 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5593 No need to cast type when ORing.
5594 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5595 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5596 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5597 assume EMACS_INT is the same width as char *.
5598 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5599 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5600 Remove no-longer-needed casts.
5601 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5602 (xg_tool_bar_help_callback, xg_make_tool_item):
5603 Use EMACS_INTPTR to hold an integer
5604 that will be cast to void *; this can avoid a GCC warning
5605 if EMACS_INT is not the same width as void *.
5606 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5607 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5608 (current_message_1, set_message_1):
5609 Use a local to convert to proper width without a cast.
5610 * xmenu.c (dialog_selection_callback): Likewise.
5611
ede49d71
PE
5612 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5613 Also, don't assume VALBITS / RAND_BITS is less than 5,
5614 and don't rely on undefined behavior when shifting a 1 left into
5615 the sign bit.
5616 * lisp.h (get_random): Change signature to match.
5617
2f30ecd0
PE
5618 * lread.c (hash_string): Use size_t, not int, for hash computation.
5619 Normally we prefer signed values; but hashing is special, because
5620 it's better to use unsigned division on hash table sizes so that
5621 the remainder is nonnegative. Also, size_t is the natural width
5622 for hashing into memory. The previous code used 'int', which doesn't
5623 retain enough info to hash well into very large tables.
5624 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5625
2a866e7b
PE
5626 * dbusbind.c: Don't possibly lose pointer info when converting.
5627 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5628 Use XPNTR rather than XHASH, so that the high-order bits of
5629 the pointer aren't lost when converting through void *.
5630
51639eac
PE
5631 * eval.c (Fautoload): Don't double-shift a pointer.
5632
92394119
PE
5633 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5634
dbdb9a7c
JB
56352011-05-06 Juanma Barranquero <lekktu@gmail.com>
5636
5637 * gnutls.c (DEF_GNUTLS_FN):
5638 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5639
db7a0b4f
AS
56402011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5641
5642 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5643 marker. (Bug#8610)
5644
f7ff1b0f 56452011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5646
5647 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5648 New version that can reserve upto 2GB of heap space.
5649
f7ff1b0f 56502011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5651
5652 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5653
639c109b
TZ
56542011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5655
5656 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5657 `gnutls_certificate_set_x509_key_file'.
5658
d2127135
JB
56592011-05-05 Juanma Barranquero <lekktu@gmail.com>
5660
5661 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5662 Update dependencies.
5663
e968f4f3
JB
56642011-05-04 Juanma Barranquero <lekktu@gmail.com>
5665
5666 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5667 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5668 Remove unused parameter `fildes'.
5669 * process.c (read_process_output, send_process): Don't pass it.
5670
84d358f0
JB
56712011-05-04 Juanma Barranquero <lekktu@gmail.com>
5672
5673 Fix previous change: the library cache is defined in w32.c.
5674 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5675 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5676
0898ca10
JB
56772011-05-04 Juanma Barranquero <lekktu@gmail.com>
5678
5679 Implement dynamic loading of GnuTLS on Windows.
5680
5681 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5682 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5683 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5684 Declare.
5685
5686 * gnutls.c (Qgnutls_dll): Define.
5687 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5688 (gnutls_*): Declare function pointers.
5689 (init_gnutls_functions): New function to initialize function pointers.
5690 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5691 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5692 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5693 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5694 (emacs_gnutls_write, emacs_gnutls_read)
5695 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5696 (Fgnutls_available_p): New function.
5697 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5698 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5699 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5700
5701 * image.c: Include w32.h.
5702 (Vimage_type_cache): Delete.
5703 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5704 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5705 (w32_delayed_load): Move to w32.c.
5706
5707 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5708
5709 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5710 (w32_delayed_load): Move from image.c. When loading a library, record
5711 its filename in the :loaded-from property of the library id.
5712 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5713 Initialize and staticpro them.
5714 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5715
5716 * process.c: Include lisp.h before w32.h, not after.
5717 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5718 instead of gnutls_record_check_pending.
5719
5720 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5721
ff4de4aa
TZ
57222011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5723
5724 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5725 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5726 as passed in.
5727
abe95abb
JD
57282011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5729
5730 * xterm.c (x_set_frame_alpha): Do not set property on anything
5731 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5732
e16e55d4
JB
57332011-05-02 Juanma Barranquero <lekktu@gmail.com>
5734
5735 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5736
bafcf6a5
JB
57372011-05-02 Juanma Barranquero <lekktu@gmail.com>
5738
5739 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5740 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5741 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5742 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5743 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5744 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5745 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5746 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5747 (Qgnutls_bootprop_callbacks_verify): Make static.
5748
e7a6747f
AS
57492011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5750
19ed11ba
AS
5751 * callproc.c: Indentation fixup.
5752
e7a6747f 5753 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5754 (wait_for_termination, interruptible_wait_for_termination):
5755 Move after wait_for_termination_1.
e7a6747f 5756
1ef14cb4
LMI
57572011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5758
5759 * sysdep.c (interruptible_wait_for_termination): New function
5760 which is like wait_for_termination, but allows keyboard
5761 interruptions.
5762
5763 * callproc.c (Fcall_process): Add (:file "file") as an option for
5764 the STDOUT buffer.
5765 (Fcall_process_region): Ditto.
5766
330d880c
EZ
57672011-04-30 Eli Zaretskii <eliz@gnu.org>
5768
8db90b73
EZ
5769 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5770 rather than `XVECTOR (FOO)->size'.
5771
330d880c
EZ
5772 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5773 inttypes.h, as a gnulib replacement is used if it not available in
5774 system headers.
5775
15cbd324
EZ
57762011-04-21 Eli Zaretskii <eliz@gnu.org>
5777
5778 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5779 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5780 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5781
5782 * coding.c (coding_alloc_by_realloc): Error out if destination
5783 will grow beyond MOST_POSITIVE_FIXNUM.
5784 (decode_coding_emacs_mule): Abort if there isn't enough place in
5785 charbuf for the composition carryover bytes. Reserve an extra
5786 space for up to 2 characters produced in a loop.
5787 (decode_coding_iso_2022): Abort if there isn't enough place in
5788 charbuf for the composition carryover bytes.
5789
57902011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5791
ae940cca
EZ
5792 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5793 aborting when %lld or %lll format is passed.
5794 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5795 %llo or %llx format is passed. (Bug#8545)
5796
03ab8921
EZ
5797 * window.c (window_scroll_line_based): Use a marker instead of
5798 simple variables to record original value of point. (Bug#7952)
5799
afda1437
EZ
5800 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5801 produced by %s or %c overflows available buffer space. (Bug#8545)
5802
f76dee0c
PE
58032011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5804
5805 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5806 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5807
fdc5744d
JB
58082011-04-28 Juanma Barranquero <lekktu@gmail.com>
5809
5810 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5811
638f053a
JB
58122011-04-28 Juanma Barranquero <lekktu@gmail.com>
5813
5814 * keyboard.c (Qdelayed_warnings_hook): Define.
5815 (command_loop_1): Run `delayed-warnings-hook'
5816 if Vdelayed_warnings_list is non-nil.
5817 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5818 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5819
d178f871
EZ
58202011-04-28 Eli Zaretskii <eliz@gnu.org>
5821
5822 * doprnt.c (doprnt): Don't return value smaller than the buffer
5823 size if the message was truncated. (Bug#8545).
5824
b124fd93
JB
58252011-04-28 Juanma Barranquero <lekktu@gmail.com>
5826
5827 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5828 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5829
e810457d
PE
58302011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5831
5832 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5833
ea51cceb
JB
58342011-04-27 Juanma Barranquero <lekktu@gmail.com>
5835
5836 * makefile.w32-in: Update dependencies.
5837
94dcfacf
EZ
58382011-04-27 Eli Zaretskii <eliz@gnu.org>
5839
5840 Improve `doprnt' and its usage. (Bug#8545)
5841 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5842 `format_end'. Remove support for %l as a conversion specifier.
5843 Don't use xrealloc. Improve diagnostics when the %l size modifier
5844 is used. Update the commentary.
5845
5846 * eval.c (verror): Simplify calculation of size_t.
5847
5848 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5849 messages.
5850
f61f41d7
PE
58512011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5852
5853 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5854 change.
5855
96fb4434
PE
58562011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5857
5858 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5859 This makes this file independent of the recent pseudovector change.
5860
671875da 58612011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5862
69e9b5a3
PE
5863 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5864
b5f869a7 5865 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5866 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5867 Remove unused local.
c8926152 5868 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5869
841a1577 5870 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5871 GCC 4.6.0 optimizes based on type-based alias analysis.
5872 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5873 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5874 != &v->size, and therefore "v->size = 1; b->size = 2; return
5875 v->size;" must therefore return 1. This assumption is incorrect
5876 for Emacs, since it type-puns struct Lisp_Vector * with many other
5877 types. To fix this problem, this patch adds a new type struct
f904488f 5878 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5879 and pseudovectors, and helps optimizing compilers not get fooled
5880 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5881 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5882 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5883 the size member.
eab3844f
PE
5884 (XSETPVECTYPE): Rewrite in terms of new macro.
5885 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5886 This is a bit clearer, and further avoids the possibility of
5887 undesirable aliasing.
5888 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5889 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5890 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5891 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5892 (ASIZE): Now uses header.size rather than size.
5893 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5894 to avoid the hassle of writing XVECTOR (foo)->header.size.
5895 (struct vectorlike_header): New type.
eab3844f
PE
5896 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5897 object, to help avoid aliasing.
5898 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5899 (SUBRP): Likewise, since Lisp_Subr is a special case.
5900 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5901 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5902 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5903 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5904 changed to be "header.size" and "header.next".
5905 * buffer.h (struct buffer): Likewise.
5906 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5907 * frame.h (struct frame): Likewise.
5908 * process.h (struct Lisp_Process): Likewise.
5909 * termhooks.h (struct terminal): Likewise.
5910 * window.c (struct save_window_data, struct saved_window): Likewise.
5911 * window.h (struct window): Likewise.
5912 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5913 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5914 * buffer.c (init_buffer_once): Likewise.
5915 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5916 special case.
5917 * process.c (Fformat_network_address): Use local var for size,
5918 for brevity.
5919
0df1eac5
PE
5920 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5921
847ab9d1 5922 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5923 * data.c (atof): Remove decl; no longer used or needed.
5924 (digit_to_number): Move to lread.c.
5925 (Fstring_to_number): Use new string_to_number function, to be
5926 consistent with how the Lisp reader treats infinities and NaNs.
5927 Do not assume that floating-point numbers represent EMACS_INT
5928 without losing information; this is not true on most 64-bit hosts.
5929 Avoid double-rounding errors, by insisting on integers when
5930 parsing non-base-10 numbers, as the documentation specifies.
5931 * lisp.h (string_to_number): New decl, replacing ...
5932 (isfloat_string): Remove.
bc0a5c13 5933 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5934 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5935 appears to have been a coding error. Similarly, do not accept
5936 strings like +-1e0 as floating point numbers. Do not report
5937 overflow for integer overflows unless the base is not 10 which
5938 means we have no simple and reliable way to continue.
5939 Break out the floating-point parsing into a new
5940 function string_to_number, so that Fstring_to_number parses
5941 floating point numbers consistently with the Lisp reader.
04f2d78b 5942 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5943 (E_CHAR, EXP_INT): Remove, replacing with ...
5944 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5945 (string_to_number): New function, replacing isfloat_string.
5946 This function checks for valid syntax and produces the resulting
5947 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5948 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5949 so that overflow for non-base-10 numbers is reported only when
5950 there's no portable and simple way to convert to floating point.
452f4150 5951
67769ffc
PE
5952 * textprop.c (set_text_properties_1): Rewrite for clarity,
5953 and to avoid GCC warning about integer overflow.
5954
c20db43f
PE
5955 * intervals.h (struct interval): Use EMACS_INT for members
5956 where EMACS_UINT might cause problems. See
5957 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5958 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5959 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5960 All uses changed.
37aa2f85
PE
5961 (offset_intervals): Tell GCC not to worry about length overflow
5962 when negating a negative length.
c20db43f 5963
2538aa2f
PE
5964 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5965 (overrun_check_free): Likewise.
5966
f2d3008d
PE
5967 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5968 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5969 word size.
5970
ec8df744
PE
5971 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5972 (gnutls_make_error): Rename local to avoid shadowing.
5973 (gnutls_emacs_global_deinit): ifdef out; not used.
5974 (Fgnutls_boot): Use const for pointer to readonly storage.
5975 Comment out unused local. Fix pointer signedness problems.
5976
640ee02d
PE
5977 * lread.c (openp): Don't stuff size_t into an 'int'.
5978 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5979 about possible signed overflow.
5980
6048fb2a
PE
5981 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5982 (GDK_KEY_g): Don't define if already defined.
5983 (xg_prepare_tooltip): Avoid pointer signedness problem.
5984 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5985
fa3c87e1
PE
5986 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5987 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5988
2172544b
PE
5989 * xfns.c (Fx_window_property): Simplify a bit,
5990 to make a bit faster and to avoid GCC 4.6.0 warning.
5991 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5992
9b821a21
PE
5993 * fns.c (internal_equal): Don't assume size_t fits in int.
5994
3c616cfa
PE
5995 * alloc.c (compact_small_strings): Tighten assertion a little.
5996
c2982e87
PE
5997 Replace pEd with more-general pI, and fix some printf arg casts.
5998 * lisp.h (pI): New macro, generalizing old pEd macro to other
5999 conversion specifiers. For example, use "...%"pI"d..." rather
6000 than "...%"pEd"...".
6001 (pEd): Remove. All uses replaced with similar uses of pI.
6002 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6003 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6004 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6005 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6006 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6007 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6008 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6009 64-bit hosts.
6010 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6011 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6012 * print.c (safe_debug_print, print_object): Likewise.
6013 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6014 to int.
6f04d126
PE
6015 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6016 avoiding the 0 flag, which is not portable.
c2982e87
PE
6017 * process.c (Fmake_network_process): Use pI to avoid cast.
6018 * region-cache.c (pp_cache): Likewise.
6019 * xdisp.c (decode_mode_spec): Likewise.
6020 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6021 behavior on 64-bit hosts with printf arg.
6f04d126 6022 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6023 (x_stop_queuing_selection_requests): Likewise.
6024 (x_get_window_property): Don't truncate byte count to an 'int'
6025 when tracing.
0b432f21 6026
5e073ec7
PE
6027 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6028 here, since it parses constructs like leading '-' and spaces,
6029 which are not wanted; and it overflows with large numbers.
6030 Instead, simply match F[0-9]+, which is what is wanted anyway.
6031
36372bf9
PE
6032 * alloc.c: Remove unportable assumptions about struct layout.
6033 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6034 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6035 (allocate_vectorlike, make_pure_vector): Use the new macros,
6036 plus offsetof, to remove unportable assumptions about struct layout.
6037 These assumptions hold on all porting targets that I know of, but
6038 they are not guaranteed, they're easy to remove, and removing them
6039 makes further changes easier.
6040
0b432f21
PE
6041 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6042 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6043 (string_overrun_cookie): Now const. Use initializers that
6044 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6045 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6046 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6047 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6048 multiple of sizeof (EMACS_INT); it need not be, if
6049 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6050 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6051
895009e1
JB
60522011-04-26 Juanma Barranquero <lekktu@gmail.com>
6053
6054 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6055
6a7a1b0b
TZ
60562011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6057
6058 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6059 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6060 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6061
841a1577 60622011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6063
6064 * lisp.h (Qdebug): List symbol.
895009e1 6065 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6066 * keyboard.c (debug-on-event): New variable.
6067 (handle_user_signal): Break into debugger when debug-on-event
6068 matches the current signal symbol.
6069
f2d3ba6f
DN
60702011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6071
6072 * alloc.c (check_sblock, check_string_bytes)
6073 (check_string_free_list): Convert to standard C.
6074
42ce4c63
TZ
60752011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6076
6077 * w32.c (emacs_gnutls_push): Fix typo.
6078
825cd63c
EZ
60792011-04-25 Eli Zaretskii <eliz@gnu.org>
6080
fb11d64d
EZ
6081 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6082 "cast to pointer from integer of different size".
6083
825cd63c
EZ
6084 Improve doprnt and its use in verror. (Bug#8545)
6085 * doprnt.c (doprnt): Document the set of format control sequences
6086 supported by the function. Use SAFE_ALLOCA instead of always
6087 using `alloca'.
6088
6089 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6090 is one byte too soon. Don't use xrealloc; instead xfree and
6091 xmalloc anew.
6092
e061a11b
TZ
60932011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6094
6095 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6096 callbacks stage.
6097
6098 * gnutls.c: Renamed global_initialized to
6099 gnutls_global_initialized. Added internals for the
6100 :verify-hostname-error, :verify-error, and :verify-flags
6101 parameters of `gnutls-boot' and documented those parameters in the
6102 docstring. Start callback support.
9173deec
JB
6103 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6104 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6105 on error. Return error code.
e061a11b
TZ
6106 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6107 (emacs_gnutls_read): Likewise.
6108 (Fgnutls_boot): Return handshake error code.
6109 (emacs_gnutls_handle_error): New function.
6110 (wsaerror_to_errno): Likewise.
6111
6112 * w32.h (emacs_gnutls_pull): Add prototype.
6113 (emacs_gnutls_push): Likewise.
6114
6115 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6116 (emacs_gnutls_push): Likewise.
6117
61182011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6119
6120 * process.c (wait_reading_process_output): Check if GnuTLS
6121 buffered some data internally if no FDs are set for TLS
6122 connections.
6123
6124 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6125 (LIBS): Link to USER_LIBS.
6126 ($(BLD)/gnutls.$(0)): New target.
6127
fa6996bc
EZ
61282011-04-24 Eli Zaretskii <eliz@gnu.org>
6129
eb35682e
EZ
6130 * xdisp.c (handle_single_display_spec): Rename the
6131 display_replaced_before_p argument into display_replaced_p, to
6132 make it consistent with the commentary. Fix typos in the
6133 commentary.
6134
e2ad650c
EZ
6135 * textprop.c (syms_of_textprop): Remove dead code.
6136 (copy_text_properties): Delete obsolete commentary about an
6137 interface that was deleted long ago. Fix typos in the description
6138 of arguments.
6139
1b2de274
EZ
6140 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6141 to changes in oldXMenu/XMenu.h from 2011-04-16.
6142 <menu_help_message, prev_menu_help_message>: Constify.
6143 (IT_menu_make_room): menu->help_text is now `const char **';
6144 adjust.
6145
6146 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6147 to changes in oldXMenu/XMenu.h from 2011-04-16.
6148 (struct XMenu): Declare `help_text' `const char **'.
6149
6150 * xfaces.c <Qunspecified>: Make extern again.
6151
6152 * syntax.c: Include sys/types.h before including regex.h, as
6153 required by Posix.
6154
762b15be
EZ
6155 * doc.c (get_doc_string): Improve the format passed to `error'.
6156
6157 * doprnt.c (doprnt): Improve commentary.
6158
6159 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6160
6161 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6162 them with etags.
6163
f1052e5d
EZ
6164 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6165 changes in globals.h immediately force recompilation.
762b15be
EZ
6166 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6167 $(CURDIR)/s/ms-w32.h.
6168 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6169
fa6996bc
EZ
6170 * character.c (Fchar_direction): Function deleted.
6171 (syms_of_character): Don't defsubr it.
6172 <char-direction-table>: Deleted.
6173
e6c3da20
EZ
61742011-04-23 Eli Zaretskii <eliz@gnu.org>
6175
6176 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6177 * doprnt.c: Include limits.h.
6178 (SIZE_MAX): New macro.
04f2d78b
CB
6179 (doprnt): Return a size_t value. 2nd arg is now size_t.
6180 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6181 Improve overflow protection. Support `l' modifier for integer
6182 conversions. Support %l conversion. Don't assume an EMACS_INT
6183 argument for integer conversions and for %c.
6184
6185 * lisp.h (doprnt): Restore prototype.
6186
6187 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6188 $(SRC)/character.h.
6189
6190 * Makefile.in (base_obj): Add back doprnt.o.
6191
6192 * deps.mk (doprnt.o): Add back prerequisites.
6193 (callint.o): Depend on character.h.
6194
6195 * eval.c (internal_lisp_condition_case): Include the handler
6196 representation in the error message.
6197 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6198 when breaking from the loop.
6199
6200 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6201
6202 * callint.c (Fcall_interactively): When displaying error message
6203 about invalid control letter, pass the character's codepoint, not
6204 a pointer to its multibyte form. Improve display of the character
6205 in octal and display also its hex code.
6206
6207 * character.c (char_string): Use %x to display the (unsigned)
6208 codepoint of an invalid character, to avoid displaying a bogus
6209 negative value.
6210
6211 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6212 `error', not SYMBOL_NAME itself.
6213
6214 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6215 character arguments to `error'.
6216
6217 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6218 to `error' in error message about FINAL_CHAR argument. Make sure
6219 FINAL_CHAR is a character, and use %c when it is passed as
6220 argument to `error'.
6221
4ffd0d6b 62222011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6223
6224 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6225
6226 * w32.c: Include <time.h>.
6227 (sys_localtime): New function.
6228
4ffd0d6b 62292011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6230
6231 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6232
4ffd0d6b 6233 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6234
4ffd0d6b 62352011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6236
4ffd0d6b
GM
6237 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6238 zombies (Bug#8467).
aac0c6e3 6239
04c56954
EZ
62402011-04-19 Eli Zaretskii <eliz@gnu.org>
6241
6242 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6243 gl_state.e_property when gl_state.object is Qt.
6244
6245 * insdel.c (make_gap_larger): Remove limitation of buffer size
6246 to <= INT_MAX.
6247
16a43933
CY
62482011-04-18 Chong Yidong <cyd@stupidchicken.com>
6249
6250 * xdisp.c (lookup_glyphless_char_display)
6251 (produce_glyphless_glyph): Handle cons cell entry in
6252 glyphless-char-display.
6253 (Vglyphless_char_display): Document it.
6254
6255 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6256 glyphless-char-display.
6257
4581706e
CY
62582011-04-17 Chong Yidong <cyd@stupidchicken.com>
6259
6260 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6261
6262 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6263
6264 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6265 definition for no-X builds.
6266
4887c6e2 62672011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6268
fd35b6f9
PE
6269 Static checks with GCC 4.6.0 and non-default toolkits.
6270
5c1ccb01
PE
6271 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6272
006c5daa
PE
6273 * process.c (keyboard_bit_set): Define only if SIGIO.
6274 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6275 (send_process): Repair possible setjmp clobbering.
6276
efc736d3
PE
6277 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6278
4e2fe2e6
PE
6279 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6280
f97334a2
PE
6281 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6282
4e75f29d
PE
6283 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6284 Define only if needed.
6285
90efadd1
PE
6286 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6287 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6288 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6289
3c647824
PE
6290 * dispextern.h (struct redisplay_interface): Rename param
6291 to avoid shadowing.
e264f262 6292 * termhooks.h (struct terminal): Likewise.
761383f4 6293 * xterm.c (xembed_send_message): Likewise.
3c647824 6294
b58c5c4a
PE
6295 * insdel.c (make_gap_smaller): Define only if
6296 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6297
cad59032
PE
6298 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6299 it.
6300
c339dc2e
PE
6301 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6302 so that we aren't warned about unused symbols.
6303
91a3e27b
PE
6304 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6305
399c71d3 6306 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6307
8ffc96f5
PE
6308 * xfns.c (x_real_positions): Mark locals as initialized.
6309
eef9bc79
PE
6310 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6311
098db9dd
PE
6312 * xterm.c: Fix problems found by static analysis with other toolkits.
6313 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6314 (x_dispatch_event): Declare static if USE_GTK, and
6315 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6316 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6317 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6318 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6319 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6320
eb18f6cc
PE
6321 * xmenu.c (menu_help_callback): Pointer type fixes.
6322 Use const pointers when pointing at readonly data. Avoid pointer
6323 signedness clashes.
6324 (FALSE): Remove unused macro.
6325 (update_frame_menubar): Remove unused decl.
6326
1fe72bf8
PE
6327 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6328
60d9e1db
PE
6329 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6330 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6331 (single_menu_item): Rename local to avoid shadowing.
6332
39261c26
PE
6333 * keyboard.c (make_lispy_event): Remove unused local var.
6334
018c5e19
PE
6335 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6336 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6337
63d2b86e
PE
6338 * bitmaps: Change bitmaps from unsigned char back to the X11
6339 compatible char. Avoid the old compiler warnings about
6340 out-of-range initializers by using, for example, '\xab' rather
6341 than 0xab.
6342
aefd87e1
PE
6343 * xgselect.c (xgselect_initialize): Check vs interface
6344 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6345
bf501fb9
PE
6346 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6347
e9829fdf
PE
6348 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6349 to read-only memory.
6350
1086c095
PE
6351 * fns.c (vector): Remove; this old hack is no longer needed.
6352
2baccd04 6353 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6354 Remove unused var.
dde42981 6355 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6356
72391843 6357 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6358
436c16df 6359 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6360 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6361 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6362
92bb796d 6363 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6364 (x_term_init): Remove local to avoid shadowing.
92bb796d 6365
764430a3 6366 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6367
6368 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6369 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6370
d1dfb56c
EZ
63712011-04-16 Eli Zaretskii <eliz@gnu.org>
6372
c4354cb4
EZ
6373 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6374
d1dfb56c
EZ
6375 Fix regex.c, syntax.c and friends for buffers > 2GB.
6376 * syntax.h (struct gl_state_s): Declare character position members
6377 EMACS_INT.
6378
6379 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6380
04f2d78b
CB
6381 * textprop.c (verify_interval_modification, interval_of):
6382 Declare arguments EMACS_INT.
d1dfb56c
EZ
6383
6384 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6385 EMACS_INT.
6386
6387 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6388
6389 * indent.c (Fvertical_motion): Local variable it_start is now
6390 EMACS_INT.
6391
6392 * regex.c (re_match, re_match_2, re_match_2_internal)
6393 (bcmp_translate, regcomp, regexec, print_double_string)
6394 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6395 (re_compile_pattern, re_exec): Declare arguments and local
6396 variables `size_t' and `ssize_t' and return values `regoff_t', as
6397 appropriate.
6398 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6399 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6400 <compile_stack_type>: `size' and `avail' are now `size_t'.
6401
6402 * regex.h <regoff_t>: Use ssize_t, not int.
6403 (re_search, re_search_2, re_match, re_match_2): Arguments that
6404 specify buffer/string position and length are now ssize_t and
6405 size_t. Return type is regoff_t.
6406
613052cd
BK
64072011-04-16 Ben Key <bkey76@gmail.com>
6408
6409 * nsfont.m: Fixed bugs in ns_get_family and
6410 ns_descriptor_to_entity that were caused by using free to
6411 deallocate memory blocks that were allocated by xmalloc (via
6412 xstrdup). This caused Emacs to crash when compiled with
6413 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6414 --enable-checking=xmallocoverrun). xfree is now used to
6415 deallocate these memory blocks.
6416
4170f62f 64172011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6418
71b41406
PE
6419 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6420
9587a89d
PE
6421 emacs_write: Accept and return EMACS_INT for sizes.
6422 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6423 et seq.
6424 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6425 Accept and return EMACS_INT.
6426 (emacs_gnutls_write): Return the number of bytes written on
6427 partial writes.
6428 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6429 (emacs_read, emacs_write): Remove check for negative size, as the
6430 Emacs source code has been audited now.
9587a89d
PE
6431 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6432 (emacs_read, emacs_write): Use it.
273a5f82
PE
6433 * process.c (send_process): Adjust to the new signatures of
6434 emacs_write and emacs_gnutls_write. Do not attempt to store
6435 a byte offset into an 'int'; it might overflow.
9587a89d 6436 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6437
3e047f51
PE
6438 * sound.c: Don't assume sizes fit in 'int'.
6439 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6440 Return EMACS_INT, not int.
3e047f51 6441 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6442 Accept EMACS_INT, not int.
6443 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6444 record read return values.
6445
cc39a9db
BK
64462011-04-15 Ben Key <bkey76@gmail.com>
6447
c9d0ec6d
JB
6448 * keyboard.c (Qundefined): Don't declare static since it is used
6449 in nsfns.m.
6450 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6451 static since they are used in nsfont.m.
cc39a9db 6452
6c60eb9f
SM
64532011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6454
6455 * process.c (Qprocessp): Don't declare static.
6456 * lisp.h (Qprocessp): Declare again.
6457
7990b61a
JB
64582011-04-15 Juanma Barranquero <lekktu@gmail.com>
6459
6460 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6461
5d4cb038
PE
64622011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6463
8bd7b830 6464 Improve C-level modularity by making more things 'static'.
cd64ea1d 6465
e3b27b31
PE
6466 Don't publish debugger-only interfaces to other modules.
6467 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6468 (verify_bytepos, count_markers): Move decls to the only modules
6469 that need them.
6470 * region-cache.h (pp_cache): Likewise.
6471 * window.h (check_all_windows): Likewise.
6472 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6473
5d4cb038
PE
6474 * sysdep.c (croak): Now static, if
6475 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6476 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6477
6478 * alloc.c (refill_memory_reserve): Now static if
6479 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6480 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6481
e87b6180
PE
6482 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6483 Define only if USE_LUCID.
6484
ac64929e
PE
6485 * xrdb.c (x_customization_string, x_rm_string): Now static.
6486
6f37259d
PE
6487 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6488 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6489
1683e3ab
PE
6490 * xdisp.c (draw_row_with_mouse_face): Now static.
6491 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6492
de9c2632
PE
6493 * window.h (check_all_windows): Mark externally visible.
6494
2b96acb7
PE
6495 * window.c (window_deletion_count): Now static.
6496
6497 * undo.c: Make symbols static if they're not exported.
6498 (last_undo_buffer, last_boundary_position, pending_boundary):
6499 Now static.
6500
50436f33
PE
6501 * textprop.c (interval_insert_behind_hooks): Now static.
6502 (interval_insert_in_front_hooks): Likewise.
6503
64520e5c
PE
6504 * term.c: Make symbols static if they're not exported.
6505 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6506 (max_frame_lines, tty_set_terminal_modes):
6507 (tty_reset_terminal_modes, tty_turn_off_highlight):
6508 (get_tty_terminal): Now static.
6509 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6510 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6511 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6512 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6513 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6514
1fa53021
PE
6515 * sysdep.c: Make symbols static if they're not exported.
6516 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6517 Now static.
6518 (sigprocmask_set, full_mask): Remove; unused.
6519 (wait_debugging): Mark as visible.
6520 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6521 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6522
d4b43b22
PE
6523 * syntax.c (syntax_temp): Define only if !__GNUC__.
6524
b7c513d0
PE
6525 * sound.c (current_sound_device, current_sound): Now static.
6526
989b29ad
PE
6527 * search.c (searchbufs, searchbuf_head): Now static.
6528
13a55a78
PE
6529 * scroll.c (scroll_cost): Remove; unused.
6530 * dispextern.h (scroll_cost): Remove decl.
6531
de68a1fc
PE
6532 * region-cache.h (pp_cache): Mark as externally visible.
6533
40ccffa6
PE
6534 * process.c: Make symbols static if they're not exported.
6535 (process_tick, update_tick, create_process, chan_process):
6536 (Vprocess_alist, proc_buffered_char, datagram_access):
6537 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6538 (deactivate_process): Mark defn as static, as well as decl.
6539 * lisp.h (create_process): Remove decl.
6540 * process.h (chan_process, Vprocess_alist): Remove decls.
6541
ad64fc97
PE
6542 * print.c: Make symbols static if they're not exported.
6543 (print_depth, new_backquote_output, being_printed, print_buffer):
6544 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6545 (print_interval, print_number_index, initial_stderr_stream):
6546 Now static.
6547 * lisp.h (Fprinc): Remove decl.
6548 (debug_output_compilation_hack): Mark as externally visible.
6549
adddb265
PE
6550 * sysdep.c (croak): Move decl from here to syssignal.h.
6551 * syssignal.h (croak): Put it here, so the API can be checked when
6552 'croak' is called from dissociate_if_controlling_tty.
6553
1717ede2
PE
6554 * minibuf.c: Make symbols static if they're not exported.
6555 (minibuf_save_list, choose_minibuf_frame): Now static.
6556 * lisp.h (choose_minibuf_frame): Remove decl.
6557
fa5fb2bc
PE
6558 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6559
1e3890d1
PE
6560 * lread.c: Make symbols static if they're not exported.
6561 (read_objects, initial_obarray, oblookup_last_bucket_number):
6562 Now static.
6563 (make_symbol): Remove; unused.
6564 * lisp.h (initial_obarray, make_symbol): Remove decls.
6565
8a1414fa
PE
6566 * keyboard.c: Make symbols static if they're not exported.
6567 (single_kboard, recent_keys_index, total_keys, recent_keys):
6568 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6569 (this_single_command_key_start, echoing, last_auto_save):
6570 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6571 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6572 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6573 (Vlispy_mouse_stem, double_click_count):
6574 Now static.
6575 (force_auto_save_soon): Define only if SIGDANGER.
6576 (ignore_mouse_drag_p): Now static if
6577 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6578 (print_help): Remove; unused.
6579 (stop_character, last_timer_event): Mark as externally visible.
6580 * keyboard.h (ignore_mouse_drag_p): Declare only if
6581 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6582 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6583 * lisp.h (echoing): Remove decl.
6584 (force_auto_save_soon): Declare only if SIGDANGER.
6585 * xdisp.c (redisplay_window): Simplify code, to make it more
6586 obvious that ignore_mouse_drag_p is not accessed if !defined
6587 USE_GTK && !defined HAVE_NS.
6588
93ea6e8f
PE
6589 * intervals.c: Make symbols static if they're not exported.
6590 (merge_properties_sticky, merge_interval_right, delete_interval):
6591 Now static.
6592 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6593
77382fcc
PE
6594 * insdel.c: Make symbols static if they're not exported.
6595 However, leave prepare_to_modify_buffer alone. It's never
6596 called from outside this function, but that appears to be a bug.
6597 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6598 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6599 (adjust_after_replace_noundo): Remove; unused.
6600 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6601 (signal_before_change): Remove decls.
77382fcc 6602
9306c32e
PE
6603 * indent.c (val_compute_motion, val_vmotion): Now static.
6604
cd44d2eb
PE
6605 * image.c: Make symbols static if they're not exported.
6606 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6607 if USE_GTK.
6608 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6609 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6610
ad9a7a06
PE
6611 * fringe.c (standard_bitmaps): Now static.
6612 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6613
81626931
PE
6614 * frame.c: Make symbols static if they're not exported.
6615 (x_report_frame_params, make_terminal_frame): Now static.
6616 (get_frame_param): Now static, unless HAVE_NS.
6617 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6618 (x_get_resource_string): Remove; not used.
6619 * frame.h (make_terminal_frame, x_report_frame_params):
6620 (x_get_resource_string); Remove decls.
6621 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6622 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6623
239f9db9
PE
6624 * font.c, fontset.c: Make symbols static if they're not exported.
6625 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6626 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6627 * font.c (font_close_object): Now static.
6628 * font.h (font_close_object): Remove.
6629 * fontset.c (FONTSET_OBJLIST): Remove.
6630 (free_realized_fontset) #if-0 the body, which does nothing.
6631 (face_suitable_for_char_p): #if-0, as it's never called.
6632 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6633 * xfaces.c (face_at_string_position):
6634 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6635 since 0 is always ASCII.
6636
dfcf3579
PE
6637 * fns.c (weak_hash_tables): Now static.
6638
5045092b
PE
6639 * fileio.c: Make symbols static if they're not exported.
6640 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6641 (Vwrite_region_annotation_buffers): Now static.
6642
57a96f5c
PE
6643 * eval.c: Make symbols static if they're not exported.
6644 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6645 * lisp.h (backtrace_list): Remove decl.
6646
35f08c38
PE
6647 * emacs.c: Make symbols static if they're not exported.
6648 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6649 (fatal_error_code, fatal_error_signal_hook, standard_args):
6650 Now static.
6651 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6652 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6653 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6654 * lisp.h (fatal_error_signal_hook): Remove decl.
6655 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6656
f44bd759
PE
6657 * editfns.c: Move a (normally-unused) function to its only use.
6658 * editfns.c, lisp.h (get_operating_system_release): Remove.
6659 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6660 worth the hassle of breaking this out.
6661
b532497d
PE
6662 * xterm.c: Make symbols static if they're not exported.
6663 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6664 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6665 (x_destroy_window, x_delete_display):
6666 Now static.
6667 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6668 (x_mouse_leave): Remove; unused.
6669 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6670 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6671 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6672 Remove decls.
6673 (x_mouse_leave): Declare only if WINDOWSNT.
6674 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6675 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6676 USE_X_TOOLKIT.
6677
1675728f
PE
6678 * ftxfont.c: Make symbols static if they're not exported.
6679 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6680 HAVE_FREETYPE.
6681 * font.h (ftxfont_driver): Likewise.
6682
e4cebfca
PE
6683 * xfns.c: Make symbols static if they're not exported.
6684 (x_last_font_name, x_display_info_for_name):
6685 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6686 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6687 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6688 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6689 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6690 (last_show_tip_args): Now static.
6691 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6692 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6693 (x_screen_planes): Remove; unused.
6694 * dispextern.h (x_screen_planes): Remove decl.
6695
5bf46f05
PE
6696 * dispnew.c: Make symbols static if they're not exported.
6697 * dispextern.h (redraw_garbaged_frames, scrolling):
6698 (increment_row_positions): Remove.
6699 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6700 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6701 Now static.
6702 (redraw_garbaged_frames): Remove; unused.
6703
435f4c28
PE
6704 * xfaces.c: Make symbols static if they're not exported.
6705 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6706 Remove decls.
6707 * xterm.h (defined_color): Remove decls.
6708 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6709 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6710 (menu_face_changed_default, defined_color, free_realized_face):
6711 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6712 (ascii_face_of_lisp_face): Remove; unused.
6713
8524aef3
PE
6714 * xdisp.c: Make symbols static if they're not exported.
6715 * dispextern.h (scratch_glyph_row, window_box_edges):
6716 (glyph_to_pixel_coords, set_cursor_from_row):
6717 (get_next_display_element, set_iterator_to_next):
6718 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6719 (show_mouse_face): Remove decls
6720 * frame.h (message_buf_print): Likewise.
6721 * lisp.h (pop_message, set_message, check_point_in_composition):
6722 Likewise.
6723 * xterm.h (set_vertical_scroll_bar): Likewise.
6724 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6725 (message_buf_print, scratch_glyph_row, displayed_buffer):
6726 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6727 (get_next_display_element, show_mouse_face, window_box_edges):
6728 (frame_to_window_pixel_xy, check_point_in_composition):
6729 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6730 (glyph_to_pixel_coords): Remove; unused.
6731
16390cd2
PE
6732 * dired.c (file_name_completion): Now static.
6733
6734 * dbusbind.c (xd_in_read_queued_messages): Now static.
6735
a25f4dfa
PE
6736 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6737 * data.c (circular_list_error): Remove.
6738
14a9c8df
PE
6739 * commands.h (last_point_position, last_point_position_buffer):
6740 (last_point_position_window): Remove decls.
6741 * keyboard.c: Make these variables static.
6742
04f2d78b
CB
6743 * coding.h (coding, code_convert_region, encode_coding_gap):
6744 Remove decls.
74ab6df5
PE
6745 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6746 (iso_code_class, detect_coding, code_convert_region): Now static.
6747 (encode_coding_gap): Remove; unused.
6748
38dfbee1
PE
6749 * chartab.c (chartab_chars, chartab_bits): Now static.
6750
a2cb4e63
PE
6751 * charset.h (charset_iso_8859_1): Remove decl.
6752 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6753 Now static.
6754
127198fd
PE
6755 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6756 * ccl.c (Vccl_program_table): Now static.
6757 (check_ccl_update): Remove; unused.
6758
d85b608f
PE
6759 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6760 * category.h: ... from here.
6761 * category.c (check_category_table, set_category_set): Now static.
6762
31cd66f3
PE
6763 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6764 * lisp.h: Remove these decls.
6765
c358e587
PE
6766 * buffer.c (buffer_count): Remove unused var.
6767
e78aecca
PE
6768 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6769 so that it's not optimized away.
6770 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6771 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6772 exported only to the debugger.
6773
e192d7d3 6774 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6775 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6776
92470028
PE
6777 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6778 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6779 was inaccessible from Lisp.
6780 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6781 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6782
244ed907
PE
6783 alloc.c: Import and export fewer symbols, and remove unused items.
6784 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6785 is defined.
6786 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6787 it's not optimized away by whole-program optimization.
6788 (message_enable_multibyte, free_misc): Remove.
6789 (catchlist, handlerlist, mark_backtrace):
6790 Declare only if BYTE_MARK_STACK.
6791 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6792 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6793 (message_enable_multibyte): Remove decl.
6794 (free_misc, interval_free_list, float_block, float_block_index):
6795 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6796 (cons_free_list, last_marked_index):
6797 Now static.
6798 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6799 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6800 (mark_backtrace): Define only if BYTE_MARK_STACK.
6801 * xdisp.c (message_enable_multibyte): Now static.
6802
61c2b50e 6803 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6804 This makes it easier for human readers (and static analyzers)
6805 to see whether these variables are used from other modules.
6806 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6807 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6808 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6809 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6810 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6811 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6812 * xmenu.c, xselect.c:
6813 Declare Q* vars static if they are not used in other modules.
6814 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6815 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6816 Remove decls of unexported vars.
6817 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6818
95c82688
PE
6819 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6820
16a97296
PE
6821 Make Emacs functions such as Fatom 'static' by default.
6822 This makes it easier for human readers (and static analyzers)
6823 to see whether these functions can be called from other modules.
6824 DEFUN now defines a static function. To make the function external
6825 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6826 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6827 (Finit_image_library):
16a97296
PE
6828 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6829 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6830 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6831 Remove decls, since these functions are now static.
6832 (Funintern, Fget_internal_run_time): New decls, since these functions
6833 were already external.
95c82688 6834
16a97296
PE
6835 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6836 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6837 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6838 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6839 * keyboard.c, keymap.c, lread.c:
6840 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6841 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6842 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6843 Mark functions with DEFUE instead of DEFUN,
6844 if they are used in other modules.
6845 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6846 decls for now-static functions.
6847 * buffer.h (Fdelete_overlay): Remove decl.
6848 * callproc.c (Fgetenv_internal): Mark as internal.
6849 * composite.c (Fremove_list_of_text_properties): Remove decl.
6850 (Fcomposition_get_gstring): New forward static decl.
6851 * composite.h (Fcomposite_get_gstring): Remove decl.
6852 * dired.c (Ffile_attributes): New forward static decl.
6853 * doc.c (Fdocumntation_property): New forward static decl.
6854 * eval.c (Ffetch_bytecode): New forward static decl.
6855 (Funintern): Remove extern decl; now in .h file where it belongs.
6856 * fileio.c (Fmake_symbolic_link): New forward static decl.
6857 * image.c (Finit_image_library): New forward static decl.
6858 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6859 * intervals.h (Fprevious_property_change):
6860 (Fremove_list_of_text_properties): Remove decls.
6861 * keyboard.c (Fthis_command_keys): Remove decl.
6862 (Fcommand_execute): New forward static decl.
6863 * keymap.c (Flookup_key): New forward static decl.
6864 (Fcopy_keymap): Now static.
6865 * keymap.h (Flookup_key): Remove decl.
6866 * process.c (Fget_process): New forward static decl.
6867 (Fprocess_datagram_address): Mark as internal.
6868 * syntax.c (Fsyntax_table_p): New forward static decl.
6869 (skip_chars): Remove duplicate decl.
6870 * textprop.c (Fprevious_property_change): New forward static decl.
6871 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6872 Now internal.
6873 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6874 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6875
785bbd42
PE
6876 * editfns.c (Fformat): Remove unreachable code.
6877
8b913b57
AS
68782011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6879
6880 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6881 change. (Bug#8496)
6882
a6744a35
EZ
68832011-04-13 Eli Zaretskii <eliz@gnu.org>
6884
6885 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6886 when at ZV. (Bug#8487)
6887
e7974947
AS
68882011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6889
baad03f0
AS
6890 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6891 (Bug#8437)
6892 * keyboard.c (parse_tool_bar_item): Likewise.
6893 * sound.c (sound_cleanup, alsa_close): Likewise.
6894 * termcap.c (tgetent): Likewise.
6895 * xfns.c (x_default_font_parameter): Likewise.
6896 * xsettings.c (read_and_apply_settings): Likewise.
6897
e7974947
AS
6898 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6899 (overrun_check_free): Protoize.
6900
28272684
PE
69012011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6902
6903 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6904 since callers should never pass a negative size.
6905 Change the signature to match that of plain 'read' and 'write'; see
6906 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6907 * lisp.h: Update prototypes of emacs_write and emacs_read.
6908
11997c76
EZ
69092011-04-11 Eli Zaretskii <eliz@gnu.org>
6910
6911 * xdisp.c (redisplay_window): Don't try to determine the character
6912 position of the scroll margin if the window start point w->startp
e896f03c 6913 is outside the buffer's accessible region. (Bug#8468)
11997c76 6914
8a2cbd72
EZ
69152011-04-10 Eli Zaretskii <eliz@gnu.org>
6916
6917 Fix write-region and its subroutines for buffers > 2GB.
6918 * fileio.c (a_write, e_write): Modify declaration of arguments and
6919 local variables to support buffers larger than 2GB.
6920 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6921
6922 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6923 argument, local variables, and return value.
6924
6925 * lisp.h: Update prototypes of emacs_write and emacs_read.
6926
6927 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6928
4073e537 69292011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6930
1ebfdcb6
PE
6931 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6932
b2ded58d
PE
6933 Fix more problems found by GCC 4.6.0's static checks.
6934
7d66342c
PE
6935 * xdisp.c (vmessage): Use a better test for character truncation.
6936
bbf47d44
PE
6937 * charset.c (load_charset_map): <, not <=, for optimization,
6938 and to avoid potential problems with integer overflow.
9248994d 6939 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6940 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6941 * editfns.c (Fformat): Likewise.
1e69125e 6942 * syntax.c (skip_chars): Likewise.
3befa583 6943
e3019616
PE
6944 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6945 This also lets GCC 4.6.0 generate slightly better loop code.
6946
becfa255
PE
6947 * callint.c (Fcall_interactively): <, not <=, for optimization.
6948 (Fcall_interactively): Count the number of arguments produced,
6949 not the number of arguments given. This is simpler and lets GCC
6950 4.6.0 generate slightly better code.
6951
dae0cd48
PE
6952 * ftfont.c: Distingish more carefully between FcChar8 and char.
6953 The previous code passed unsigned char * to a functions like
6954 strlen and xstrcasecmp that expect char *, which does not
6955 conform to the C standard.
6956 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6957 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6958 char * when the C standard requires it.
6959
76032d70
PE
6960 * keyboard.c (read_char): Remove unused var.
6961
eb3f1cc8
PE
6962 * eval.c: Port to Windows vsnprintf (Bug#8435).
6963 Include <limits.h>.
6964 (SIZE_MAX): Define if the headers do not.
6965 (verror): Do not give up if vsnprintf returns a negative count.
6966 Instead, grow the buffer. This ports to Windows vsnprintf, which
6967 does not conform to C99. Problem reported by Eli Zaretskii.
6968 Also, simplify the allocation scheme, by avoiding the need for
6969 calling realloc, and removing the ALLOCATED variable.
6970
70476b54
PE
6971 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6972
12020a9e
PE
6973 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6974 But keep the doprint source code for now, as we might revamp it
6975 and use it again (Bug#8435).
ea6c7ae6
PE
6976 * lisp.h (doprnt): Remove.
6977 * Makefile.in (base_obj): Remove doprnt.o.
6978 * deps.mk (doprnt.o): Remove.
6979
5fdb398c
PE
6980 error: Print 32- and 64-bit integers portably (Bug#8435).
6981 Without this change, on typical 64-bit hosts error ("...%d...", N)
6982 was used to print both 32- and 64-bit integers N, which relied on
6983 undefined behavior.
6984 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6985 New macro.
6986 * lisp.h (error, verror): Mark as printf-like functions.
6987 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6988 Report overflow in size calculations when allocating printf buffer.
6989 Do not truncate output string at its first null byte.
6990 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6991 Truncate the output at a character boundary, since vsnprintf does not
6992 do that.
6993 * charset.c (check_iso_charset_parameter): Convert internal
6994 character to string before calling 'error', since %c now has the
6995 printf meaning.
6996 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6997 overflow when computing char to be passed to 'error'. Do not
6998 pass Lisp_Object to 'error'; pass the integer instead.
6999 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7000 formatted with plain %d.
7001
b189fa66
PE
7002 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7003
bff87ef0
PE
7004 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7005
7e2cac20
PE
7006 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7007
ce4d90b5
PE
7008 * xterm.c (x_catch_errors): Remove duplicate declaration.
7009
266c9547
PE
7010 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7011
79c49ad2
PE
7012 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7013
368f4090
JM
70142011-04-10 Jim Meyering <meyering@redhat.com>
7015
7016 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7017 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7018 return ssize_t not "int", and use size_t as the buffer length.
7019 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7020 * gnutls.h: Update declarations.
7021 * process.c (read_process_output): Use ssize_t, to match.
7022 (send_process): Likewise.
7023
a32d4040
CY
70242011-04-09 Chong Yidong <cyd@stupidchicken.com>
7025
7026 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7027
8546720e 70282011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7029
04f2d78b
CB
7030 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7031 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7032
8546720e
GM
7033 * xterm.c (handle_one_xevent):
7034 * xmenu.c (create_and_show_popup_menu):
7035 * xselect.c (x_decline_selection_request)
7036 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7037
0a2f5c1a 70382011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7039
7040 Fix some uses of `int' instead of EMACS_INT.
7041 * search.c (string_match_1, fast_string_match)
7042 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7043 (scan_buffer, find_next_newline_no_quit)
7044 (find_before_next_newline, search_command, Freplace_match)
7045 (Fmatch_data): Make some `int' variables be EMACS_INT.
7046
7047 * xdisp.c (display_count_lines): 3rd argument and return value now
7048 EMACS_INT. All callers changed.
7049 (pint2hrstr): Last argument is now EMACS_INT.
7050
7051 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7052 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7053 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7054 (decode_coding_utf_16, decode_coding_emacs_mule)
7055 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7056 (decode_coding_ccl, decode_coding_charset)
7057 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7058 (decode_coding_iso_2022, decode_coding_emacs_mule)
7059 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7060 <char_offset, last_offset>: Declare EMACS_INT.
7061 (encode_coding_utf_8, encode_coding_utf_16)
7062 (encode_coding_emacs_mule, encode_invocation_designation)
7063 (encode_designation_at_bol, encode_coding_iso_2022)
7064 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7065 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7066 Declare EMACS_INT.
7067 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7068 (encode_invocation_designation): Last argument P_NCHARS is now
7069 EMACS_INT.
7070 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7071 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7072
7073 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7074 All users changed.
7075
7076 * ccl.c (Fccl_execute_on_string): Declare some variables
7077 EMACS_INT.
7078
8546720e 70792011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7080
7081 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7082
4e19a977
CS
70832011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7084
7085 * process.c (Fformat_network_address): Doc fix.
7086
87302331
R
70872011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7088
7089 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7090
cbb59342
CY
70912011-04-08 Chong Yidong <cyd@stupidchicken.com>
7092
7093 * keyboard.c (read_char): Call Lisp function help-form-show,
7094 instead of using internal_with_output_to_temp_buffer.
7095 (Qhelp_form_show): New var.
e0d38eeb 7096 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7097
7098 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7099
7100 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7101
e67a13ab
CY
71022011-04-06 Chong Yidong <cyd@stupidchicken.com>
7103
04f2d78b
CB
7104 * process.c (Flist_processes): Remove to Lisp.
7105 (list_processes_1): Delete.
e67a13ab 7106
973f782d
EZ
71072011-04-06 Eli Zaretskii <eliz@gnu.org>
7108
7c106b1e
EZ
7109 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7110
973f782d
EZ
7111 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7112
41cf7d1a 71132011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7114
ca23cc88
PE
7115 Fix more problems found by GCC 4.6.0's static checks.
7116
f390e2d5
PE
7117 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7118
42eea0d0
PE
7119 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7120
b69769da 7121 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7122
f9541e84
PE
7123 * xdisp.c (vmessage): Mark as a printf-like function.
7124
13841b55
PE
7125 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7126
c136c10f
PE
7127 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7128
5e2d4a30
PE
7129 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7130 printf-like functions.
7131 (tiff_load): Add casts to remove these marks before passing them
7132 to system-supplied API.
7133
583f48b9
PE
7134 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7135
b25d760e
PE
7136 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7137 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7138 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7139 directly, rather than having caller test rule sign. This avoids
7140 some unnecessary tests.
7141 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7142 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7143 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7144
bc7b6697 7145 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7146 (xfont_open): Avoid unnecessary tests.
bc7b6697 7147
27ccc379
PE
7148 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7149
dcd5c89a
PE
7150 * composite.h, composite.c (composition_gstring_put_cache):
7151 Use EMACS_INT, not int, for length.
7152
b13a45c6
PE
7153 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7154 breaking out part of COMPOSITION_DECODE_RULE.
7155 (COMPOSITION_DECODE_RULE): Use it.
7156 * composite.c (get_composition_id): Remove unused local vars,
7157 by using the new macro.
7158
1e792e4d
PE
7159 * textprop.c (set_text_properties_1): Change while to do-while,
7160 since the condition is always true at first.
7161
dc6c6455 7162 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7163 (interval_deletion_adjustment): Return unsigned value.
7164 All uses changed.
dc6c6455 7165
aba7731a
PE
7166 * process.c (list_processes_1, create_pty, read_process_output):
7167 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7168 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7169 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7170 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7171 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7172
fdfc4bf3
PE
7173 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7174
fca8fe46 7175 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7176 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7177
06a0259a 7178 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7179 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7180 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7181
e7b9e80f
PE
7182 * print.c (print_error_message): Avoid int overflow.
7183
56201685
PE
7184 * font.c (font_list_entities): Redo for clarity,
7185 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7186
78834453 7187 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7188 (font_score): Avoid potential overflow in diff calculation.
78834453 7189
0bc0b309 7190 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7191 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7192
e610eaca
PE
7193 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7194
b895abce
PE
7195 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7196 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7197 can always succeed if overflow has undefined behavior.
7198
1f1d9321 7199 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7200 (wordify): Omit three unnecessary tests.
1f1d9321 7201
c59478bc
PE
7202 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7203 All callers changed. This avoids the need for an unused var.
7204
79b73827
PE
7205 * casefiddle.c (casify_region): Remove var that is set but not used.
7206
a4db5dfe
PE
7207 * dired.c (file_name_completion): Remove var that is set but not used.
7208
43aae36e
PE
7209 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7210
2a47c44d 7211 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7212 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7213
a37c69bf
PE
7214 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7215 Check for integer overflow on size calculations.
7216
328ab8e7
PE
7217 * buffer.c (Fprevious_overlay_change): Remove var that is set
7218 but not used.
7219
e5a2a5cb
PE
7220 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7221 Remove vars that are set but not used.
8d84a6eb 7222 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7223 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7224
a60e5f68
PE
7225 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7226
f661cb61 7227 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7228 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7229
f0397f5a
PE
7230 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7231 that are set but not used.
7232
8664db06 7233 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7234 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7235
6abdaa4a
PE
7236 * xselect.c (x_get_local_selection, x_handle_property_notify):
7237 Remove vars that are set but not used.
7238
0ce7538d 7239 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7240 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7241
9ae848fc
PE
7242 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7243 Remove var that is set but not used.
0b918413
PE
7244 (scroll_bar_windows_size): Now size_t, not int.
7245 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7246 Check for overflow.
9ae848fc 7247
a5a62657
PE
7248 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7249 (map_tty_color) [!defined MSDOS]: Likewise.
7250
5c5cdd39
PE
7251 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7252
66ebf983
PE
7253 * coding.c: Remove vars that are set but not used.
7254 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7255 All callers changed.
7256 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7257 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7258 (decode_coding_charset): Remove vars that are set but not used.
7259
1be4d761
PE
7260 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7261 that is set but not used.
7262
47553fa8
PE
7263 * print.c (print_object): Remove var that is set but not used.
7264
1f7196bf 7265 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7266 The gnulib version avoids calling malloc in the usual case,
7267 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7268 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7269 * filelock.c (current_lock_owner): Likewise.
7270 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7271 * sysdep.c: Include allocator.h, careadlinkat.h.
7272 (emacs_no_realloc_allocator): New static constant.
7273 (emacs_readlink): New function.
fdb61804
PE
7274 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7275 ../lib/careadlinkat.h.
d1fdcab7 7276
f84c17c7
SM
72772011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7278
7279 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7280 first non-nil return value).
7281
ef3862ad
JD
72822011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7283
7284 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7285 if not defined (Bug#8403).
7286
376a7006
JB
72872011-04-02 Juanma Barranquero <lekktu@gmail.com>
7288
7289 * xdisp.c (display_count_lines): Remove parameter `start',
7290 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7291 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7292 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7293 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7294 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7295 and thereabouts. All callers changed.
7296 (get_per_char_metric): Remove parameter `f', unused since
7297 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7298
6ca3801d
JM
72992011-04-02 Jim Meyering <meyering@redhat.com>
7300
7301 do not dereference NULL upon failed strdup
7302 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7303 (ns_get_family): Likewise.
7304
d8e2b5ba
JB
73052011-04-02 Juanma Barranquero <lekktu@gmail.com>
7306
7307 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7308
8c74fcbd
JD
73092011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7310
7311 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7312 later (Bug#8403).
7313
7200d79c
SM
73142011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7315
03408648 7316 Add lexical binding.
7200d79c 7317
03408648
SM
7318 * window.c (Ftemp_output_buffer_show): New fun.
7319 (Fsave_window_excursion):
7320 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7321
7322 * lread.c (lisp_file_lexically_bound_p): New function.
7323 (Fload): Bind Qlexical_binding.
7324 (readevalloop): Remove `evalfun' arg.
7325 Bind Qinternal_interpreter_environment.
7326 (Feval_buffer): Bind Qlexical_binding.
7327 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7328 Mark as dynamic.
7329 (syms_of_lread): Declare `lexical-binding'.
7330
7331 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7332
7333 * keyboard.c (eval_dyn): New fun.
7334 (menu_item_eval_property): Use it.
ca105506
SM
7335
7336 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7337
03408648
SM
7338 * fns.c (concat, mapcar1): Accept byte-code-functions.
7339
7340 * eval.c (Fsetq): Handle lexical vars.
7341 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7342 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7343 (FletX, Flet): Obey lexical binding.
7344 (Fcommandp): Handle closures.
7345 (Feval): New `lexical' arg.
7346 (eval_sub): New function extracted from Feval. Use it almost
7347 everywhere where Feval was used. Look up vars in lexical env.
7348 Handle closures.
7349 (Ffunctionp): Move from subr.el.
7350 (Ffuncall): Handle closures.
7351 (apply_lambda): Remove `eval_flags'.
7352 (funcall_lambda): Handle closures and new byte-code-functions.
7353 (Fspecial_variable_p): New function.
7354 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7355 but without exporting it to Lisp.
23aba0ea 7356
23aba0ea 7357 * doc.c (Fdocumentation, store_function_docstring):
03408648 7358 * data.c (Finteractive_form): Handle closures.
23aba0ea 7359
03408648
SM
7360 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7361 interactive spec.
ba83908c 7362
04f2d78b
CB
7363 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7364 New byte-codes.
03408648
SM
7365 (exec_byte_code): New function extracted from Fbyte_code to handle new
7366 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7367
03408648 7368 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7369
03408648 7370 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7371
e2abce01
JB
73722011-03-31 Juanma Barranquero <lekktu@gmail.com>
7373
7374 * xdisp.c (redisplay_internal): Fix prototype.
7375
63696a73 73762011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7377
63696a73 7378 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7379 (try_scrolling): Use it when setting scroll_limit.
7380 Limit scrolling to 100 screen lines.
63696a73
EZ
7381 (redisplay_window): Even when falling back on "recentering",
7382 position point in the window according to scroll-conservatively,
7383 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7384
7385 (try_scrolling): When point is above the window, allow searching
7386 as far as scroll_max, or one screenful, to compute vertical
7387 distance from PT to the scroll margin position. This prevents
7388 try_scrolling from unnecessarily failing when
7389 scroll-conservatively is set to a value slightly larger than the
7390 window height. Clean up the case of PT below the margin at bottom
7391 of window: scroll_max can no longer be INT_MAX. When aggressive
7392 scrolling is in use, don't let point enter the opposite scroll
7393 margin as result of the scroll.
7394 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7395 threshold of 100 lines for never-recentering scrolling.
7396
e4cc2dfc
JB
73972011-03-31 Juanma Barranquero <lekktu@gmail.com>
7398
7399 * dispextern.h (move_it_by_lines):
7400 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7401 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7402 (message_log_check_duplicate): Remove parameters `prev_bol' and
7403 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7404 (redisplay_internal): Remove parameter `preserve_echo_area',
7405 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7406
7407 * indent.c (Fvertical_motion):
7408 * window.c (window_scroll_pixel_based, Frecenter):
7409 Don't pass `need_y_p' to `move_it_by_lines'.
7410
1c470562
SM
74112011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7412
44f230aa
SM
7413 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7414 steal a few bits to be more compact.
7415 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7416 Remove unneeded casts.
7417
1c470562
SM
7418 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7419
888adce9
ZK
74202011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7421
7422 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7423 binding" message (bug#7967).
7424
f838ed7b
PE
74252011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7426
77861b95
PE
7427 Fix more problems found by GCC 4.6.0's static checks.
7428
de6dbc14
PE
7429 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7430 Remove unused local var.
7431
f838ed7b
PE
7432 * editfns.c (Fmessage_box): Remove unused local var.
7433
792c7b2b
PE
7434 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7435 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7436 Omit unused local vars.
c499e557 7437 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7438 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7439 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7440 Omit unused local var.
7441
ba0165e1
PE
7442 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7443 Don't assume string length fits in int.
32ad8845 7444 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7445 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7446
3c59b4c9
PE
7447 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7448 instead of alloca (Bug#8344).
7449
a3eed478 7450 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7451 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7452
eb4d412d
PE
7453 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7454
1658b401
PE
7455 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7456 concerns.
7457
7458 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7459
7460 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7461
9a2c6e05
PE
7462 * keyboard.c (syms_of_keyboard): Use the same style as later
7463 in this function when indexing through an array. This also
7464 works around GCC bug 48267.
7465
03d0a109
PE
7466 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7467
44f730c8
PE
7468 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7469
fe75f926
PE
7470 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7471 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7472
ffa8c828
PE
7473 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7474 This avoids undefined behavior on integer overflow, and is a bit
7475 more convenient anyway since it is compared to a size_t variable.
7476
c5101a77
PE
7477 Variadic C functions now count arguments with size_t, not int.
7478 This avoids an unnecessary limitation on 64-bit machines, which
7479 caused (substring ...) to crash on large vectors (Bug#8344).
7480 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7481 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7482 All variadic functions and their callers changed accordingly.
c5101a77
PE
7483 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7484 * data.c (arith_driver, float_arith_driver): Likewise.
7485 * editfns.c (general_insert_function): Likewise.
7486 * eval.c (struct backtrace.nargs, interactive_p)
7487 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7488 (funcall_lambda, mark_backtrace): Likewise.
7489 * fns.c (concat): Likewise.
7490 * frame.c (x_set_frame_parameters): Likewise.
7491 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7492 0 if not found, not -1. All callers changed.
7493
dd3f25f7
PE
7494 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7495 (stack_copy_size): Now size_t, not int.
7496 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7497
461c2ab9
JB
74982011-03-28 Juanma Barranquero <lekktu@gmail.com>
7499
7500 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7501 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7502 All callers changed.
7503
7504 * lisp.h (multibyte_char_to_unibyte):
7505 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7506 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7507 * character.h (CHAR_TO_BYTE8):
7508 * cmds.c (internal_self_insert):
7509 * editfns.c (general_insert_function):
7510 * keymap.c (push_key_description):
7511 * search.c (Freplace_match):
7512 * xdisp.c (message_dolog, set_message_1): All callers changed.
7513
f6d62986
SM
75142011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7515
7516 * keyboard.c (safe_run_hook_funcall): New function.
7517 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7518 don't set the hook to nil, but remove the offending function instead.
7519 (Qcommand_hook_internal): Remove, unused.
7520 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7521 Vcommand_hook_internal.
7522
7523 * eval.c (enum run_hooks_condition): Remove.
7524 (funcall_nil, funcall_not): New functions.
7525 (run_hook_with_args): Call each function through a `funcall' argument.
7526 Remove `cond' argument, now redundant.
7527 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7528 (Frun_hook_with_args_until_failure): Adjust accordingly.
7529 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7530
1db5b1ad
JB
75312011-03-28 Juanma Barranquero <lekktu@gmail.com>
7532
7533 * dispextern.h (string_buffer_position): Remove declaration.
7534
7535 * print.c (strout): Remove parameter `multibyte', unused since
7536 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7537
7538 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7539 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7540 All callers changed.
7541
7542 * w32.c (_wsa_errlist): Use braces for struct initializers.
7543
7544 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7545 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7546 All callers changed.
7547 (string_buffer_position): Likewise. Also, make static (it's never
7548 used outside xdisp.c).
7549 (cursor_row_p): Remove parameter `w', unused since
7550 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7551 (decode_mode_spec): Remove parameter `precision', introduced during
7552 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7553 All callers changed.
7554
5ffb62aa
JD
75552011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7556
7557 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7558
461c2ab9 75592011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7560
7561 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7562 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7563 (ns_update_auto_hide_menu_bar): New functions.
7564 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7565 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7566 ns_constrain_all_frames.
7567 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7568 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7569
5c380ffb
JD
75702011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7571
7572 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7573
9af30bdf
GM
75742011-03-27 Glenn Morris <rgm@gnu.org>
7575
7576 * syssignal.h: Replace RETSIGTYPE with void.
7577 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7578 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7579 Replace SIGTYPE with void everywhere.
7580 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7581 * s/template.h (SIGTYPE): Remove commented out definition.
7582
e2abce01
JB
75832011-03-26 Eli Zaretskii <eliz@gnu.org>
7584
7585 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7586 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7587
f868cd8a
JB
75882011-03-26 Juanma Barranquero <lekktu@gmail.com>
7589
59eb0929
JB
7590 * w32.c (read_unc_volume): Use parameter `henum', instead of
7591 global variable `wget_enum_handle'.
7592
7593 * keymap.c (describe_vector): Remove parameters `indices' and
7594 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7595 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7596
f868cd8a
JB
7597 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7598
7599 * keyboard.c (timer_check): Remove parameter `do_it_now',
7600 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7601 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7602 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7603
7604 * keyboard.c (read_char):
7605 * w32menu.c (w32_menu_display_help):
7606 * xmenu.c (show_help_event, menu_help_callback):
7607 Adjust calls to `show_help_echo'.
7608
7609 * gtkutil.c (xg_maybe_add_timer):
7610 * keyboard.c (readable_events):
7611 * process.c (wait_reading_process_output):
7612 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7613
7614 * insdel.c (adjust_markers_gap_motion):
7615 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7616 (gap_left, gap_right): Don't call it.
7617
2ecf6fdb
CY
76182011-03-25 Chong Yidong <cyd@stupidchicken.com>
7619
7620 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7621 incurred during fontification.
7622
6b1f9ba4
JB
76232011-03-25 Juanma Barranquero <lekktu@gmail.com>
7624
7625 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7626 (DEFVAR_PER_BUFFER): Don't pass it.
7627
7628 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7629 (scrolling_window): Don't pass it.
7630
0f4a96b5
JB
76312011-03-25 Juanma Barranquero <lekktu@gmail.com>
7632
7633 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7634
7635 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7636 and `suffix'.
7637 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7638 of variables specific to SELinux and computation of `encoded_absname'.
7639
7640 * image.c (XPutPixel): Remove unused variable `height'.
7641
7642 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7643
7644 * unexw32.c (get_section_info): Remove unused variable `section'.
7645
7646 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7647 (system_process_attributes): Remove unused variable `sess'.
7648 (sys_read): Remove unused variable `err'.
7649
7650 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7651 (w32_wnd_proc): Remove unused variable `isdead'.
7652 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7653 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7654 (x_create_tip_frame): Remove unused variable `tem'.
7655
7656 * w32inevt.c (w32_console_read_socket):
7657 Remove unused variable `no_events'.
7658
7659 * w32term.c (x_draw_composite_glyph_string_foreground):
7660 Remove unused variable `width'.
7661
1149507c
JB
76622011-03-24 Juanma Barranquero <lekktu@gmail.com>
7663
7664 * w32term.c (x_set_glyph_string_clipping):
7665 Don't pass uninitialized region to CombineRgn.
7666
9c88f339
JB
76672011-03-23 Juanma Barranquero <lekktu@gmail.com>
7668
7669 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7670 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7671 (Fx_close_connection): Remove unused variable `i'.
7672
7673 * w32font.c (w32font_draw): Return number of glyphs.
7674 (w32font_open_internal): Remove unused variable `i'.
7675 (w32font_driver): Add missing initializer.
7676
7677 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7678 (fill_in_menu): Remove unused variable `items_added'.
7679
7680 * w32term.c (last_mouse_press_frame): Remove static global variable.
7681 (w32_clip_to_row): Remove unused variable `f'.
7682 (x_delete_terminal): Remove unused variable `i'.
7683
7684 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7685 (NOTHING): Remove unused static global variable.
7686 (uniscribe_check_otf): Remove unused variable `table'.
7687 (uniscribe_font_driver): Add missing initializers.
7688
dee091a3
JD
76892011-03-23 Julien Danjou <julien@danjou.info>
7690
7691 * term.c (Fsuspend_tty, Fresume_tty):
7692 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7693 * window.c (temp_output_buffer_show):
7694 * insdel.c (signal_before_change):
7695 * frame.c (Fhandle_switch_frame):
7696 * fileio.c (Fdo_auto_save):
7697 * emacs.c (Fkill_emacs):
7698 * editfns.c (save_excursion_restore):
7699 * cmds.c (internal_self_insert):
7700 * callint.c (Fcall_interactively):
7701 * buffer.c (Fkill_all_local_variables):
7702 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7703 Use Frun_hooks.
0f4a96b5 7704 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7705 unconditionnaly since it does the check itself.
7706
2c520ab5 77072011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7708
c9c49752
PE
7709 Fix more problems found by GCC 4.5.2's static checks.
7710
8abc3f12
PE
7711 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7712 the first time through the loop, since we know p0 < p1 then.
7713 This also avoids a gcc -Wstrict-overflow warning.
7714
a2d26660
PE
7715 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7716 leading to a memory leak, possible in functions like
7717 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7718 of objects (Bug#8318).
a2d26660 7719
916c72e9
PE
7720 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7721 that could (at least in theory) be that large.
7722
19ab8a18
PE
7723 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7724 This is less likely to overflow, and avoids undefined behavior if
7725 overflow does occur. All callers changed. Use strtoul to scan
7726 for the unsigned long integer.
b7cbbd6f
PE
7727 (pint2hrstr): Simplify and tune code slightly.
7728 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7729
f0641eff
PE
7730 * scroll.c (do_scrolling): Work around GCC bug 48228.
7731 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7732
7f650bb9
PE
7733 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7734 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7735 (validate_x_resource_name): Simplify count usage.
7736 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7737
37dd57d1
PE
7738 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7739 fail (Bug#8306).
81e56e61 7740
699979fc 7741 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7742
401bf9b4
PE
7743 * process.c (Fmake_network_process): Use socklen_t, not int,
7744 where POSIX says socklen_t is required in portable programs.
7745 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7746 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7747 (Fmake_network_process, server_accept_connection):
7748 (wait_reading_process_output, read_process_output):
7749 Likewise.
7750
b93aacde
PE
7751 * process.c: Rename or move locals to avoid shadowing.
7752 (list_processes_1, Fmake_network_process):
7753 (read_process_output_error_handler, exec_sentinel_error_handler):
7754 Rename or move locals.
4dc343ee 7755 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7756 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7757 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7758 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7759 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7760
af8a867c 7761 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7762 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7763 Include tparam.h instead, since it declares them.
af8a867c
PE
7764 * cm.h (PC): Remove extern decl; tparam.h now does this.
7765 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7766 * terminfo.c: Include tparam.h, to check interfaces.
7767 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7768 (tparam): Adjust signature to match interface in tparam.h;
7769 this removes some undefined behavior. Check that outstring and len
7770 are zero, which they always are with Emacs.
7771 * tparam.h (PC, BC, UP): New extern decls.
7772
0248044d 7773 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7774 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7775
8ff096c1 7776 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7777 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7778 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7779 (ftfont_list): Remove unused local.
49eaafba
PE
7780 (get_adstyle_property, ftfont_pattern_entity):
7781 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7782 Rename locals to avoid shadowing.
8ff096c1 7783
e2be39f6
PE
7784 * xfont.c (xfont_list_family): Mark var as initialized.
7785
c9735e30
PE
7786 * xml.c (make_dom): Now static.
7787
8f5201ae
PE
7788 * composite.c (composition_compute_stop_pos): Rename local to
7789 avoid shadowing.
b246f932
PE
7790 (composition_reseat_it): Remove unused locals.
7791 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7792 (composition_update_it): Mark var as initialized.
11b61122
PE
7793 (find_automatic_composition): Mark vars as initialized,
7794 with a FIXME (Bug#8290).
8f5201ae 7795
760fbc2c
PE
7796 character.h: Rename locals to avoid shadowing.
7797 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7798 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7799 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7800 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7801 to avoid shadowing.
7802
ff08eb85
PE
7803 * textprop.c (property_change_between_p): Remove; unused.
7804
fc7bf025
PE
7805 * intervals.c (interval_start_pos): Now static.
7806
235d7abc
PE
7807 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7808
44f230aa
SM
7809 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7810 Rename locals to avoid shadowing.
3e7d6594 7811
50060332
PE
7812 * sound.c (wav_play, au_play, Fplay_sound_internal):
7813 Fix pointer signedness.
d01f234b 7814 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7815 (wav_play): Initialize a variable to 0, to prevent undefined
7816 behavior (Bug#8278).
50060332 7817
c4fc4e30
PE
7818 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7819
918436ed
PE
7820 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7821
c939f91b
PE
7822 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7823 clobbering (Bug#8298).
b9c7f648
PE
7824 * sysdep.c (sys_subshell): Likewise.
7825 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7826
6bd8c144
PE
7827 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7828 This should get cleaned up, so that child_setup has the
7829 same signature on all platforms.
7830
7710357c 7831 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7832 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7833
c59da222
CY
78342011-03-22 Chong Yidong <cyd@stupidchicken.com>
7835
7836 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7837 not to be necessary, and produces flickering.
7838
66b87493
GM
78392011-03-20 Glenn Morris <rgm@gnu.org>
7840
7841 * config.in: Remove file.
7842
45b6f6d5
JB
78432011-03-20 Juanma Barranquero <lekktu@gmail.com>
7844
7845 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7846 are now in src/globals.h.
7847 (syms_of_minibuf): Remove spurious & from previous change.
7848
3ec03f7e
LL
78492011-03-20 Leo <sdl.web@gmail.com>
7850
7851 * minibuf.c (completing-read-function): New variable.
7852 (completing-read-default): Rename from completing-read.
7853 (completing-read): Call completing-read-function.
7854
b14e3e21
CY
78552011-03-19 Juanma Barranquero <lekktu@gmail.com>
7856
7857 * xfaces.c (Fx_load_color_file):
7858 Read color file from absolute filename (bug#8250).
7859
f2b726e6
JB
78602011-03-19 Juanma Barranquero <lekktu@gmail.com>
7861
7862 * makefile.w32-in: Update dependencies.
7863
09f6ff02
EZ
78642011-03-17 Eli Zaretskii <eliz@gnu.org>
7865
7866 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7867
29a6015a
PE
78682011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7869
a3a6c54e
PE
7870 Fix more problems found by GCC 4.5.2's static checks.
7871
b766f867
PE
7872 * process.c (make_serial_process_unwind, send_process_trap):
7873 (sigchld_handler): Now static.
7874
be02381c
PE
7875 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7876 That way, the code declares only the vars that it needs.
7877 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7878 * s/cygwin.h (PTY_ITERATION): Likewise.
7879 * s/darwin.h (PTY_ITERATION): Likewise.
7880 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7881
57048744
PE
7882 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7883 * process.c (allocate_pty): Don't declare stb unless it's needed.
7884
7914961c 7885 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7886 (CONSTANTLIM): Remove; unused.
7887 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7888 Define only if needed.
7914961c 7889
b3967b18
PE
7890 * unexelf.c (unexec): Name an expression,
7891 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7892 Use a different way to cause a compilation error if anyone uses
7893 n rather than nn, a way that does not involve shadowing.
73366a00 7894 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7895
29a6015a
PE
7896 * deps.mk (unexalpha.o): Remove; unused.
7897
43cfc33e 7898 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7899 * unexec.h: New file.
ce701a33
PE
7900 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7901 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7902 Depend on unexec.h.
7903 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7904 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7905 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7906 Change as necessary to match prototype in unexec.h.
ce701a33 7907
01f44d5a
PE
7908 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7909 shadowing.
4f63c6bb 7910 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7911
a6670b0b
PE
7912 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7913 Rename locals to avoid shadowing.
7914
cef2010d 7915 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7916 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7917
d4d7173a
PE
7918 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7919
f08b802a
PE
7920 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7921 warning when compiling print.c.
7922
3ddb0639
PE
7923 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7924 instead of using an uninitialized var.
5ad03b97 7925 (font_sort_entities): Mark var as initialized.
3ddb0639 7926
170a2692
PE
7927 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7928
e663c700
PE
7929 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7930 pointers to constants.
89bc529a 7931 (font_parse_fcname): Remove unused vars.
7b81e2d0 7932 (font_delete_unmatched): Now static.
ea838e10 7933 (font_get_spec): Remove; unused.
13a547c6
PE
7934 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7935 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7936 Rename or move locals to avoid shadowing.
e663c700 7937
2a80c887 7938 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7939 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7940
1384fa33 7941 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7942 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7943
8b2c52e9
PE
7944 * alloc.c (mark_backtrace): Move decl from here ...
7945 * lisp.h: ... to here, so that it can be checked.
7946
475545b5 7947 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7948 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7949 (lisp_indirect_variable): Name an expression,
7950 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7951 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7952
b1349114 7953 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7954 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7955 Use const pointer when appropriate.
b1349114 7956
a2928364
PE
7957 * lisp.h (get_system_name, get_operating_system_release):
7958 Move decls here, to check interfaces.
7959 * process.c (get_operating_system_release): Move decl to lisp.h.
7960 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7961 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7962 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7963 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7964 (Fformat_time_string, Fencode_time, Finsert_char):
7965 (Ftranslate_region_internal, Fformat):
7966 Rename or remove local vars to avoid shadowing.
9710023e 7967 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7968
a415e694
PE
7969 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7970 avoid shadowing.
7971
8ef4622d
PE
7972 * lisp.h (eassert): Check that the argument compiles, even if
7973 ENABLE_CHECKING is not defined.
7974
946f9a5b
PE
7975 * data.c (Findirect_variable): Name an expression, to avoid
7976 gcc -Wbad-function-cast warning.
112396d6 7977 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7978 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7979 (Fmake_variable_buffer_local, Fmake_local_variable):
7980 Mark variables as initialized.
52746918 7981 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7982
e5aab7e7 7983 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7984 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7985 Rename locals to avoid shadowing.
dff45157
PE
7986 (mark_stack): Move local variables into the #ifdef region where
7987 they're used.
7bc26fdb
PE
7988 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7989 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7990 needed otherwise.
7991 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7992 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7993 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7994
e5aab7e7
PE
7995 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7996 avoids undefined behavior in theory.
7997
4da60324
PE
7998 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7999
88043301
PE
8000 Use functions, not macros, for up- and down-casing (Bug#8254).
8001 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8002 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8003 to use the following functions instead of these macros.
8004 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8005 EMACS_INT, since callers assume the returned value fits in int.
8006 (upcase1): Likewise, for UPCASE_TABLE.
8007 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8008 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8009 the race-condition problem in the old DOWNCASE.
88043301 8010
19ed5445
PE
8011 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8012 Rename locals to avoid shadowing.
8013 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8014 (regex_compile, re_search_2, re_match_2_internal):
8015 Remove unused local vars.
952db0d7
PE
8016 (FREE_VAR): Rewrite so as not to use empty "else",
8017 which gcc can warn about.
da053e48 8018 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8019 (RETALLOC_IF): Define only if needed.
8020 (WORDCHAR_P): Likewise. This one is never needed, but is used
8021 only in a comment talking about a compiler bug, so put inside
8022 the #if 0 of that comment.
8023 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8024 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8025 Remove; unused.
19ed5445 8026
1f3561e4 8027 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8028 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8029 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8030
ded6f8f7
PE
8031 * search.c (simple_search): Remove unused var.
8032
dbd37a95
PE
8033 * dired.c (compile_pattern): Move decl from here ...
8034 * lisp.h: ... to here, so that it can be checked.
8035 (struct re_registers): New forward decl.
8036
7e47afad
PE
8037 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8038
85f24f61
PE
8039 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8040 All uses changed.
8041 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8042 Rename locals to avoid shadowing.
5671df8f 8043 (Fvertical_motion): Mark locals as initialized.
85f24f61 8044
181aa2be 8045 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8046 (casify_region): Mark local as initialized.
181aa2be 8047
930d429c
PE
8048 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8049
7082eac6
PE
8050 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8051 New macros, so that the caller can use some names other than
8052 gcpro1, gcpro2, etc.
8053 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8054 of the new macros.
8055 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8056 argument, for consistency with GCPRO2_VAR, etc: it is now the
8057 prefix of the variable, not the variable itself. All uses
8058 changed.
38b2c076
PE
8059 * dired.c (directory_files_internal, file_name_completion):
8060 Rename locals to avoid shadowing.
8061
15206ed9
PE
8062 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8063 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8064 dired.c's scmp function, had undefined behavior.
8065 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8066 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8067 * buffer.h: ... to here, because these macros use current_buffer,
8068 and the new implementation with inline functions needs to have
8069 current_buffer in scope now, rather than later when the macros
8070 are used.
8071 (downcase, upcase1): New static inline functions.
8072 (DOWNCASE, UPCASE1): Reimplement using these functions.
8073 This avoids undefined behavior in expressions like
8074 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8075 from race conditions in accessing the global variables
8076 case_temp1 and case_temp2.
8077 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8078 * lisp.h (case_temp1, case_temp2): Remove their decls.
8079 * character.h (ASCII_CHAR_P): Move from here ...
8080 * lisp.h: ... to here, so that the inline functions mentioned
8081 above can use them.
8082
4a6bea26
PE
8083 * dired.c (directory_files_internal_unwind): Now static.
8084
f14b7e14
PE
8085 * fileio.c (file_name_as_directory, directory_file_name):
8086 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8087 Now static.
2893f146
PE
8088 (file_name_as_directory): Use const pointers when appropriate.
8089 (Fexpand_file_name): Likewise. In particular, newdir might
8090 point at constant storage, so make it a const pointer.
fd4ead52 8091 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8092 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8093 signedness issues.
f839df0c
PE
8094 (Fset_file_times, Finsert_file_contents, auto_save_error):
8095 Rename locals to avoid shadowing.
f14b7e14 8096
5716756e 8097 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8098 (Ftry_completion, Fall_completions): Rename or remove locals
8099 to avoid shadowing.
5716756e 8100
b4c3046a
PE
8101 * marker.c (bytepos_to_charpos): Remove; unused.
8102
b45db522
PE
8103 * lisp.h (verify_bytepos, count_markers): New decls,
8104 so that gcc does not warn that these functions aren't declared.
8105
85876d07
PE
8106 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8107 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8108 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8109 (copy_text): Remove unused local var.
85876d07 8110
03d78a21 8111 * filelock.c (within_one_second): Now static.
b3dd38ab 8112 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8113
5df8f01b
PE
8114 * buffer.c (fix_overlays_before): Mark locals as initialized.
8115 (fix_start_end_in_overlays): Likewise. This function should be
8116 simplified by using pointers-to-pointers, but that's a different
8117 matter.
b1d876f1 8118 (switch_to_buffer_1): Now static.
8f54f30a
PE
8119 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8120 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8121
a70072c9 8122 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8123 Fix pointer signedness issue.
edced198
PE
8124 (sys_subshell): Mark local as volatile if checking for lint,
8125 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8126 (MAXPATHLEN): Define only if needed.
a70072c9 8127
a0977c44
PE
8128 * process.c (serial_open, serial_configure): Move decls from here ...
8129 * systty.h: ... to here, so that they can be checked.
8130
a884fdcc
PE
8131 * fns.c (get_random, seed_random): Move extern decls from here ...
8132 * lisp.h: ... to here, so that they can be checked.
8133
604efe86 8134 * sysdep.c (reset_io): Now static.
b8950c94 8135 (wait_for_termination_signal): Remove; unused.
604efe86 8136
38fc62d9
PE
8137 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8138 (copy_keymap_item, append_key, push_text_char_description):
8139 Now static.
1004a21a 8140 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8141 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8142 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8143 (describe_map_tree):
8144 Rename locals to avoid shadowing.
38fc62d9 8145
2f2650da
PE
8146 * keyboard.c: Declare functions static if they are not used elsewhere.
8147 (echo_char, echo_dash, cmd_error, top_level_2):
8148 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8149 (read_char, kbd_buffer_get_event, make_lispy_position):
8150 (make_lispy_event, make_lispy_movement, apply_modifiers):
8151 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8152 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8153 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8154 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8155 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8156
a053e86c 8157 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8158 (mark_kboards): Move decl here ...
8159 * alloc.c (mark_kboards): ... from here.
a053e86c 8160
4752793e
PE
8161 * lisp.h (force_auto_save_soon): New decl.
8162
74f10ca7 8163 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8164 (DEFINE_DUMMY_FUNCTION): New macro.
8165 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8166 Use it.
c03cd23f
PE
8167 (main): Add casts to avoid warnings
8168 if GCC considers string literals to be constants.
74f10ca7 8169
022e70d4
PE
8170 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8171
59d6fe83
PE
8172 * dbusbind.c: Pointer signedness fixes.
8173 (xd_signature, xd_append_arg, xd_initialize):
8174 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8175 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8176 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8177 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8178
78320123
PE
8179 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8180 if GCC considers string literals to be constants.
49cebcca 8181 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8182
35ac2a97
SM
81832011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8184
fb103ca9
SM
8185 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8186 (print_preprocess, print_object): New macro to fix last change.
8187
35ac2a97
SM
8188 * print.c (print_preprocess): Don't forget font objects.
8189
62973b41
JB
81902011-03-16 Juanma Barranquero <lekktu@gmail.com>
8191
8192 * emacs.c (USAGE3): Doc fixes.
8193
0e48bb22
AS
81942011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8195
8196 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8197 structure.
8198
7684e57b
JB
81992011-03-14 Juanma Barranquero <lekktu@gmail.com>
8200
8201 * lisp.h (VWindow_system, Qfile_name_history):
8202 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8203 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8204 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8205
8206 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8207 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8208
8209 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8210 * w32console.c (detect_input_pending, read_input_pending)
8211 (encode_terminal_code):
8212 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8213 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8214 (w32_system_caret_y, Qfile_name_history):
8215 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8216 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8217 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8218 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8219 * w32proc.c (Qlocal, report_file_error):
8220 * w32term.c (Vwindow_system, updating_frame):
8221 * w32uniscribe.c (initialized, uniscribe_font_driver):
8222 Remove unneeded extern declarations.
8223
2aa46d6c
CY
82242011-03-14 Chong Yidong <cyd@stupidchicken.com>
8225
c96bbc66 8226 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8227
cffc6f3b
CY
82282011-03-13 Chong Yidong <cyd@stupidchicken.com>
8229
8230 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8231 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8232 These macros can no longer be used for assignment.
8233
44f230aa
SM
8234 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8235 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8236 (record_buffer_markers, fetch_buffer_markers): New functions for
8237 recording and fetching special buffer markers.
8238 (set_buffer_internal_1, set_buffer_temp): Use them.
8239
8240 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8241
8242 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8243
8244 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8245 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8246
8247 * xdisp.c (hscroll_window_tree):
8248 (reconsider_clip_changes): Use PT instead of BUF_PT.
8249
d251f04b
EZ
82502011-03-13 Eli Zaretskii <eliz@gnu.org>
8251
8252 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8253 $(EMACS_ROOT)/lib/intprops.h.
8254
f0c77cd1
PE
82552011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8256
3eca4629
PE
8257 Fix more problems found by GCC 4.5.2's static checks.
8258
7c86ee98
PE
8259 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8260 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8261 (xg_free_frame_widgets): Make it clear that a local variable is
8262 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8263 (gdk_window_get_screen): Make it clear that this macro is needed
8264 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8265 (int_gtk_range_get_value): New function, which avoids a diagnostic
8266 from gcc -Wbad-function-cast.
8267 (xg_set_toolkit_scroll_bar_thumb): Use it.
8268 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8269 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8270 (get_utf8_string, xg_get_file_with_chooser):
8271 Rename locals to avoid shadowing.
8272 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8273
41729b81
PE
8274 * xgselect.c (xg_select): Remove unused var.
8275
f0c77cd1
PE
8276 * image.c (four_corners_best): Mark locals as initialized.
8277 (gif_load): Initialize transparent_p to zero (Bug#8238).
8278 Mark another local as initialized.
ec6cf4c6 8279 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8280
ce0ad53d 8281 * image.c (clear_image_cache): Now static.
d5d5a617 8282 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8283 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8284 (x_edge_detection): Remove unnecessary cast that
8285 gcc -Wbad-function-cast diagnoses.
2037898d 8286 (gif_load): Fix pointer signedness.
6ae141d6
PE
8287 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8288 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8289
33383987 82902011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8291
d32df629
PE
8292 Improve quality of tests for time stamp overflow.
8293 For example, without this patch (encode-time 0 0 0 1 1
8294 1152921504606846976) returns the obviously-bogus value (-948597
8295 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8296 reports time overflow. See
8297 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8298 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8299 * editfns.c: Include limits.h and intprops.h.
8300 (TIME_T_MIN, TIME_T_MAX): New macros.
8301 (time_overflow): Move earlier, to before first use.
8302 (hi_time, lo_time): New functions, for an accurate test for
8303 out-of-range times.
8304 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8305 (Fget_internal_run_time): Don't assume time_t fits in int.
8306 (make_time): Use list2 instead of Fcons twice.
8307 (Fdecode_time): More accurate test for out-of-range times.
8308 (check_tm_member): New function.
8309 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8310 (lisp_time_argument): Don't rely on undefined left-shift and
8311 right-shift behavior when checking for time stamp overflow.
8be6f318 8312
fe31d94c
PE
8313 * editfns.c (time_overflow): New function, refactoring common code.
8314 (Fformat_time_string, Fdecode_time, Fencode_time):
8315 (Fcurrent_time_string): Use it.
8316
8be6f318
PE
8317 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8318 * dired.c (make_time): Move to ...
8319 * editfns.c (make_time): ... here.
8320 * systime.h: Note the move.
8321
09d9db2c 83222011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8323
126bc0dc
YM
8324 * fringe.c (update_window_fringes): Remove unused variables.
8325
c47cbdfd
YM
8326 * unexmacosx.c (copy_data_segment): Also copy __got section.
8327 (Bug#8223)
8328
7ac80be9
EZ
83292011-03-12 Eli Zaretskii <eliz@gnu.org>
8330
c96bbc66 8331 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8332 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8333 Constify `char *' arguments and their references according to
8334 prototypes in tparam.h.
8335
ecb0f94d 8336 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8337
7ac80be9
EZ
8338 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8339 Adapt all references accordingly.
8340
8341 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8342
ef1fd07e
TT
83432011-03-11 Tom Tromey <tromey@redhat.com>
8344
8345 * buffer.c (syms_of_buffer): Remove obsolete comment.
8346
7ef4b50c
EZ
83472011-03-11 Eli Zaretskii <eliz@gnu.org>
8348
8349 * termhooks.h (encode_terminal_code): Declare prototype.
8350
8351 * msdos.c (encode_terminal_code): Don't declare prototype.
8352
8353 * term.c (encode_terminal_code): Now external again, used by
8354 w32console.c and msdos.c.
8355
44f230aa
SM
8356 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8357 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8358
4b1ec863 83592011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8360
1714f52b 8361 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8362
4b1ec863
PE
8363 * fringe.c (update_window_fringes): Mark locals as initialized
8364 (Bug#8227).
8365 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8366
524c7aa6
PE
8367 * alloc.c (mark_fringe_data): Move decl from here ...
8368 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8369 to check its interface.
8370 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8371
a5c0af81 8372 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8373 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8374 (fontset_font): Mark local as initialized.
a9a06e0b 8375 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8376
b4716021
PE
8377 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8378
811e9bac 8379 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8380 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8381 (x_own_selection, Fx_disown_selection_internal): Rename locals
8382 to avoid shadowing.
8383 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8384
7e3ab302
PE
8385 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8386 so that the caller can use some name other than gcpro1.
8387 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8388 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8389 (Fx_backspace_delete_keys_p):
8390 Use them to avoid shadowing, and rename vars to avoid shadowing.
8391 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8392 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8393 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8394 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8395 Remove unused locals.
7e3ab302
PE
8396 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8397 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8398 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8399 macros.
f78faa98 8400
e2b13473
PE
8401 * xterm.h (x_mouse_leave): New decl.
8402
77f23912
PE
8403 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8404 Remove unused functions.
cdf4ba58
PE
8405 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8406 (x_calc_absolute_position): Now static.
7411c686 8407 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8408 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8409 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8410 unless they are used.
38d0b34a
PE
8411 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8412 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8413 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8414 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8415 (x_error_catcher, x_connection_closed, x_error_handler):
8416 (x_error_quitter, xembed_send_message, x_iconify_frame):
8417 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8418 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8419 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8420
44f230aa
SM
8421 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8422 Rename or move locals to avoid shadowing.
6b463e58 8423 (tty_defined_color, merge_face_heights): Now static.
5967d051 8424 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8425 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8426 does not deduce is never used uninitialized.
73719eba
PE
8427 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8428 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8429
426994c3 8430 * terminal.c (store_terminal_param): Now static.
5489860b 8431
032f1620 8432 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8433 (set_frame_menubar): Remove unused local.
d4323972 8434 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8435 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8436 since they might point to immutable storage.
281585b0
PE
8437 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8438 since it's unused otherwise.
032f1620 8439
367c19e5 8440 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8441 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8442 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8443 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8444 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8445 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8446 does not deduce are never used uninitialized.
70739cbe 8447
07b48fa9
PE
8448 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8449
8868a238 8450 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8451 * window.c (window_loop, size_window):
8452 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8453
7e5cf297 8454 * window.c (display_buffer): Now static.
d6550a9f
PE
8455 (size_window): Mark variables that gcc -Wuninitialized
8456 does not deduce are never used uninitialized.
a586633d
PE
8457 * window.h (check_all_windows): New decl, to forestall
8458 gcc -Wmissing-prototypes diagnostic.
5b555da1 8459 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8460
f6095868
PE
8461 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8462 shadowing.
8463 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8464 Include <limits.h>.
8465 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8466 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8467 (load_charset_map): Mark variables that gcc -Wuninitialized
8468 does not deduce are never used uninitialized.
53df7c11 8469 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8470
f38b440c
PE
8471 * coding.c (coding_set_source, coding_set_destination):
8472 Use "else { /* comment */ }" rather than "else /* comment */;"
8473 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8474 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8475 a block, when the outer 'i' will do.
8476 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8477 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8478 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8479 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8480 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8481 Rename locals to avoid shadowing.
8482 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8483 * coding.c (emacs_mule_char, encode_invocation_designation):
8484 Now static, since they're not used elsewhere.
413bb2db 8485 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8486 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8487 (decode_coding_emacs_mule): Mark variables that gcc
8488 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8489 (detect_coding_iso_2022): Initialize a local variable that might
8490 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8491 this initialization is needed. (Bug#8211)
5f58e762
PE
8492 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8493 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8494 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8495 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8496 Remove unused macros.
f38b440c 8497
232b38b9 8498 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8499 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8500 * character.c (string_count_byte8): Likewise.
232b38b9 8501
fb90da1b
PE
8502 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8503 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8504
fb93dbc2
PE
8505 * chartab.c (copy_sub_char_table): Now static, since it's not used
8506 elsewhere.
5c156ace
PE
8507 (sub_char_table_ref_and_range, char_table_ref_and_range):
8508 Rename locals to avoid shadowing.
bbcd0949 8509 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8510
7d3b3862 8511 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8512 (BIDI_BOB): Remove unused macro.
7d3b3862 8513
6be7d3da
PE
8514 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8515 deduce are never used uninitialized.
c2ed9c8b 8516 * term.c (encode_terminal_code): Likewise.
6be7d3da 8517
75f8807f 8518 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8519
50938595
PE
8520 * tparam.h: New file.
8521 * term.c, tparam.h: Include it.
8522 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8523 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8524 Move these decls to tparam.h, and make them agree with what
8525 is actually in tparam.c. The previous trick of using incompatible
8526 decls in different modules does not conform to the C standard.
8527 All callers of tparam changed to use tparam's actual API.
8528 * tparam.c (tparam1, tparam, tgoto):
8529 Use const pointers where appropriate.
8530
fbceeba2
PE
8531 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8532 * cm.h (struct cm): Likewise.
8533 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8534 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8535 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8536 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8537 (turn_on_face, init_tty): Likewise.
8538 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8539
7f3f1250
PE
8540 * term.c (term_mouse_position): Rename local to avoid shadowing.
8541
e6ca6543
PE
8542 * alloc.c (mark_ttys): Move decl from here ...
8543 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8544
c40f8d15
AS
85452011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8546
8547 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8548
cfe0661d
JB
85492011-03-09 Juanma Barranquero <lekktu@gmail.com>
8550
8551 * search.c (compile_pattern_1): Remove argument regp, unused since
8552 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8553 (compile_pattern): Don't pass it.
8554
0afb4571
J
85552011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8556
8557 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8558 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8559 for ! HAVE_GTK3.
8560 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8561
8562 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8563
8564 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8565 gdk_window_get_screen, gdk_window_get_geometry,
8566 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8567 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8568 (xg_get_pixbuf_from_pixmap): New function.
8569 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8570 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8571 Call xg_get_pixbuf_from_pixmap instead of
8572 gdk_pixbuf_get_from_drawable.
8573 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8574 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8575 (xg_check_special_colors): Use GtkStyleContext and its functions
8576 for HAVE_GTK3.
8577 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8578 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8579 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8580 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8581 Call gtk_widget_get_preferred_size.
0afb4571
J
8582 (xg_frame_resized): gdk_window_get_geometry only takes 5
8583 parameters.
44f230aa
SM
8584 (xg_win_to_widget, xg_event_is_for_menubar):
8585 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8586 (xg_set_widget_bg): New function.
8587 (delete_cb): New function.
895009e1 8588 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8589 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8590 (xg_set_background_color): Call xg_set_widget_bg.
8591 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8592 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8593 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8594 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8595 if ! HAVE_GTK3.
8596 (update_frame_tool_bar): Call gtk_widget_hide.
8597 (xg_initialize): Use GDK_KEY_g.
8598
8599 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8600 if ! HAVE_GTK3
8601 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8602
8603 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8604 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8605 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8606
1c2cc4ef
JB
86072011-03-08 Juanma Barranquero <lekktu@gmail.com>
8608
8609 * w32xfns.c (select_palette): Check success of RealizePalette against
8610 GDI_ERROR, not zero.
8611
33383987 8612See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8613
8614;; Local Variables:
8615;; coding: utf-8
aac0c6e3
MR
8616;; End:
8617
33383987 8618 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8619
8620 This file is part of GNU Emacs.
8621
8622 GNU Emacs is free software: you can redistribute it and/or modify
8623 it under the terms of the GNU General Public License as published by
8624 the Free Software Foundation, either version 3 of the License, or
8625 (at your option) any later version.
8626
8627 GNU Emacs is distributed in the hope that it will be useful,
8628 but WITHOUT ANY WARRANTY; without even the implied warranty of
8629 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8630 GNU General Public License for more details.
8631
8632 You should have received a copy of the GNU General Public License
8633 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.