Miscellaneous fixes for non-default X toolkits.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c09bfb2f
DA
12012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Miscellaneous fixes for non-default X toolkits.
4 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
5 * xterm.c (x_frame_of_widget): Remove redundant prototype.
6 Move under #ifdef USE_LUCID.
7 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
8 definition and usage to avoid warnings.
9
14c114ae
JD
102012-07-31 Jan Djärv <jan.h.d@swipnet.se>
11
12 * nsterm.m (openFiles): Fix previous checkin.
13
3bd21e82
PE
142012-07-31 Paul Eggert <eggert@cs.ucla.edu>
15
16 * indent.c (compute_motion): Remove unused local.
17
c1529ded
GM
182012-07-31 Glenn Morris <rgm@gnu.org>
19
400d5621
GM
20 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
21
268e2432
GM
22 * conf_post.h [USG5_4]:
23 Move remaining contents of s/usg5-4-common.h here.
24 * s/usg5-4-common.h: Remove file.
25
7552f3ee
GM
26 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
27 * s/irix6-5.h: Remove file.
28
6a381852
GM
29 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
30 * s/darwin.h: Remove file.
31
c1529ded
GM
32 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
33 * s/hpux10-20.h: Remove file, which is now empty.
34
b429a4ee
GM
352012-07-30 Glenn Morris <rgm@gnu.org>
36
37 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
38 * Makefile.in (config_h): Add conf_post.h.
39 * makefile.w32-in (CONFIG_H): Add conf_post.h.
40
adff3182
JD
412012-07-30 Jan Djärv <jan.h.d@swipnet.se>
42
43 * nsterm.m (ns_do_open_file): New variable.
b9031d69 44 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
45 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
46 files only if ns_do_open_file.
47
c32af1e4
PE
482012-07-30 Paul Eggert <eggert@cs.ucla.edu>
49
7393bcbb
PE
50 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
51 This no-op macro hasn't been needed for many years.
52 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
53
c32af1e4
PE
54 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
55 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
56 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
57 gdb_make_enums_visible.
58 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
59 (DIRECTORY_SEP): Now a constant, not a macro.
60
302fc036
EZ
612012-07-30 Eli Zaretskii <eliz@gnu.org>
62
63 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
64 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
65
66 * w32term.c <w32_keyboard_codepage>: Renamed from
67 keyboard_codepage and now external. All users changed.
68
69 * w32term.h: Add declaration of w32_keyboard_codepage.
70
71 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
72 the codepage to translate keys to Unicode. If this argument is
73 -1, use the value returned by GetConsoleCP. All callers changed.
74
88fb40b4
PE
752012-07-30 Paul Eggert <eggert@cs.ucla.edu>
76
0aee6912
PE
77 Update .PHONY listings in makefiles.
78 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
79 bootstrap-clean, distclean, maintainer-clean, versioclean,
80 extraclean, frc.
81
88fb40b4
PE
82 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
83 This is a bit clearer. Fix some commentary typos.
84
0a763bd1
GM
852012-07-30 Glenn Morris <rgm@gnu.org>
86
32bac6d6
GM
87 * s/netbsd.h: Let configure include signal.h if needed.
88 Remove file, which is now empty.
89
b65e7c46
GM
90 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
91 Let configure set them.
92 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
93 No more need to undefine.
0a763bd1 94
169304bd
AS
952012-07-30 Andreas Schwab <schwab@linux-m68k.org>
96
97 * keymap.c (Fkey_description): Don't remove 0x80 bit from
98 non-single-byte char when adding meta modifier. (Bug#12090)
99
6cd7a139
DA
1002012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
101
102 Convert safe_call to use variable number of arguments.
103 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
104 (safe_call2): Fix comment.
105 * lisp.h (safe_call): Adjust prototype.
106 * coding.c (encode_coding_object): Change to use safe_call2.
107 * xfaces.c (merge_face_heights): Change to use safe_call1.
108
d34d6ffc
GM
1092012-07-30 Glenn Morris <rgm@gnu.org>
110
7b8a48e4 111 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 112 does that unconditionally. Remove file, which is now empty.
7b8a48e4 113
d34d6ffc
GM
114 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
115 Remove empty files.
116
03a660a6
PE
1172012-07-30 Paul Eggert <eggert@cs.ucla.edu>
118
119 Export to GDB most of lisp.h's remaining object-like macros.
120 * lisp.h (min, max): Move earlier, because they're used earlier now.
121 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
122 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
123 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
124 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
125 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
126 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
127 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
128 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
129 Now constants, for GDB. They need not be macros.
130 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
131 Now constants, for GDB, as well as macros, for static initializers.
132 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
133 Move to after the definition of struct Lisp_Char_Table,
134 since the former now needs that type defined.
135 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
136 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
137 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
138 New enums, for gdb_make_enums_visible.
139 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 140 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
141 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
142 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
143 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
144 enum maxargs, enum MAX_ALLOCA.
145 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
146 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
147 no longer needed, now that they are done in lisp.h.
148
e499d0ee
DA
1492012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
150
151 Cleanup string bytes checking.
152 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
153 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
154 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
155 (check_sblock, compact_small_strings): Simplify.
156
d5040d2d
PE
1572012-07-29 Paul Eggert <eggert@cs.ucla.edu>
158
159 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
160 These macros are confusing and no longer need to be defined, as
161 the enum values now suffice. All uses replaced with definiens.
162 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
163
7f259ae6
JB
1642012-07-29 Juanma Barranquero <lekktu@gmail.com>
165
166 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
167 ($(BLD)/w32console.$(O)): Update dependencies.
168
7e63e0c3
DA
1692012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
170
171 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
172 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
173 time. Adjust users.
174 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
175
ffd817eb
JD
1762012-07-29 Jan Djärv <jan.h.d@swipnet.se>
177
178 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
179 setting sitelisp (Bug#12010).
180
417a7a0e
EZ
1812012-07-29 Eli Zaretskii <eliz@gnu.org>
182
183 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
184
185 * w32heap.c (cache_system_info):
186 * w32.c (sys_rename):
187 * w32proc.c (find_child_console, sys_kill): All users changed.
188
387d4d92
PE
1892012-07-29 Paul Eggert <eggert@cs.ucla.edu>
190
191 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
192
55a6cca6
EZ
1932012-07-29 Eli Zaretskii <eliz@gnu.org>
194
195 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
196
dbcf001c
DA
1972012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
198
199 Cleanup statistics calculation in Fgarbage_collect.
200 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
201 zombies percentage calculation. Simplify elapsed time calculation.
202
e2688e4a
DA
2032012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
204
205 Generalize marker debugging code under MARKER_DEBUG and use eassert.
206 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
207 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
208 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
209 (replace_range, replace_range_2, del_range_2): Change to eassert.
210 * marker.c (byte_char_debug_check): Adjust style.
211
b46a6a83
PE
2122012-07-29 Paul Eggert <eggert@cs.ucla.edu>
213
214 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
215 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
216 long-ago-commented-out code that talks about "WIN32".
217 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
218 All uses changed.
219
e32a5799
PE
2202012-07-28 Paul Eggert <eggert@cs.ucla.edu>
221
222 Use Gnulib stdalign module (Bug#9772, Bug#9960).
223 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
224 Simplify by using alignof.
225 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
226 * lisp.h: Include <stdalign.h>.
227 (GCALIGNMENT): New macro and constant.
228 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
229 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
230 (stdalign): New macro, if not already defined.
231
df81cd29
EZ
2322012-07-28 Eli Zaretskii <eliz@gnu.org>
233
01bd1b0d
EZ
234 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
235 * w32inevt.c: Include w32inevt.h.
236 (w32_read_console_input): New inline function, calls either
237 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
238 w32_console_unicode_input.
239 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
240 (w32_kbd_patch_key, key_event): Use the codepage returned by
241 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
242 (key_event): use uChar.UnicodeChar only if
243 w32_console_unicode_input is non-zero.
244
245 * w32console.c: Include w32heap.h.
246 <w32_console_unicode_input>: New global variable.
247 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
248 family of Windows, zero otherwise.
249
250 * w32inevt.h: Declare w32_console_unicode_input.
251
df81cd29
EZ
252 * xdisp.c (init_iterator): Don't reference tip_frame in a build
253 --without-x. (Bug#11742)
254
c20fdd9e
PE
2552012-07-27 Paul Eggert <eggert@cs.ucla.edu>
256
257 Adjust GDB to reflect pvec_type changes (Bug#12036).
258 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
259 2012-07-04 changes to pseudovector representation. Problem
260 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
261
32770973 2622012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
263
264 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
265 bus address.
266 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
267
3438fe21
EZ
2682012-07-27 Eli Zaretskii <eliz@gnu.org>
269
bcfbc9de
EZ
270 * alloc.c (listn): Fix the order the arguments are consed onto the
271 list.
272
3438fe21
EZ
273 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
274 enumeration constants, as PURE and HEAP are too general, and clash
275 with other headers and sources, such as gmalloc.c and the
276 MS-Windows system headers. All users changed.
277
eeaea515
DA
2782012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
279
280 Revert last save_excursion_save and save_excursion_restore changes.
281 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
282 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
283
073c88c2
DA
2842012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
285
286 Fix recently-introduced typos in Windows port.
287 Reported by Martin Rudalics <rudalics@gmx.at>.
288 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 289 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 290
4706125e
PE
2912012-07-27 Paul Eggert <eggert@cs.ucla.edu>
292
293 Improve GDB symbol export (Bug#12036).
294 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
295 arms of an 'if', not using conditional expressions; otherwise GDB
296 complains about the types in the unevaluated arm when the argument
297 is an integer literal.
298 (xgetint): Simplify expression.
299 * alloc.c (gdb_make_enums_visible): New constant. This ports to
300 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
301 Zaretskii in <http://bugs.gnu.org/12036#13>.
302 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
303 needed now that we have gdb_make_enums_visible.
304 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
305 (enum enum_USE_LSB_TAG):
306 New enum types, packaging up enums that need to be exported to GDB.
307
694b6c97
DA
3082012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
309
310 Utility function to make a list from specified amount of objects.
311 * lisp.h (enum constype): New datatype.
312 (listn): New prototype.
313 * alloc.c (listn): New function.
314 (Fmemory_use_count, syms_of_alloc): Use it.
315 * buffer.c (syms_of_buffer): Likewise.
316 * callint.c (syms_of_callint): Likewise.
317 * charset.c (define_charset_internal): Likewise.
318 * coding.c (syms_of_coding): Likewise.
319 * keymap.c (syms_of_keymap): Likewise.
320 * search.c (syms_of_search): Likewise.
321 * syntax.c (syms_of_syntax): Likewise.
322 * w32.c (init_environment): Likewise.
323 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
324 * xdisp.c (syms_of_xdisp): Likewise.
325 * xfns.c (syms_of_xfns): Likewise.
326
6195f384
DA
3272012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
328
329 Fast save_excursion_save and save_excursion_restore.
330 * lisp.h (struct Lisp_Excursion): New data type.
331 (PVEC_EXCURSION): New pseudovector type.
332 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
333 to deal with it. Adjust comments.
334 (init_marker, attach_marker): New prototype.
335 (unchain_marker): Adjust prototype.
336 * marker.c (attach_marker): Change to global.
337 (init_marker): New function.
338 * alloc.c (Fmake_marker, build_marker): Use it.
339 (build_marker): More easserts.
340 (mark_object): Handle struct Lisp_Excursion.
341 * editfns.c (save_excursion_save, save_excursion_restore):
342 Reimplement to use struct Lisp_Excursion. Add comments.
343
5eceb8fb
PE
3442012-07-26 Paul Eggert <eggert@cs.ucla.edu>
345
346 Fix export of symbols to GDB (Bug#12036).
347 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
348 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
349 emacs.c, as this is a more-suitable home. Had this been done earlier
350 the fix for 12036 would have avoided some of the problems noted in
351 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
352 would have been more obvious.
562157c8
PE
353 * emacs.c: Do not include <verify.h>; no longer needed.
354 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
355 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
356 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
357 Remove; now done in lisp.h.
358 * lisp.h (PUBLISH_TO_GDB): New macro.
359 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
360 (DATA_SEG_BITS): Use it.
361 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
362 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
363 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
364 not be usable in #if. This simplifies things.
365
d6749401
JB
3662012-07-26 Juanma Barranquero <lekktu@gmail.com>
367
368 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
369
1781b9e9
PE
3702012-07-26 Paul Eggert <eggert@cs.ucla.edu>
371
d89518db 372 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
373 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
374 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
375 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
376 Adjust to changes in lisp.h and emacs.c, by using
377 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
378 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
379 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
380 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
381 instead of gdb_valbits.
382 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
383 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
384 instead of gdb_array_mark_flag.
385 (xboolvector): Get size from $->size, not $->header.size.
386 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
387 (xreload, hook-run, hookpost-run): Remove.
388 * emacs.c: Include <verify.h>.
389 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
390 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
391 Remove.
392 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
393 (gdb_USE_LSB_TAG): New enum constants.
394 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
395 Also define these as enum constants, so they're visible to GDB.
396 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
397 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
398 as constants, so they're visible to GDB.
399 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
400 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
401 Now enum constants, not macros, so they're visible to GDB.
402 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
403 more convenient now. All uses changed.
404 (VALMASK) [USE_LSB_TAG]: Also define in this case.
405 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
406
3628596a
DA
4072012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
408
409 Explicitly free restriction data that are not needed anymore.
410 * editfns.c (save_restriction_restore): Free restriction data.
411
7abaf5cc
SM
4122012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
413
414 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
415 add argument, tune behavior, and adjust all callers.
416
71f88e00
PE
4172012-07-25 Paul Eggert <eggert@cs.ucla.edu>
418
419 Use typedef for EMACS_INT, EMACS_UINT.
420 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
421 than macros. This simplifies debugging in the usual case, since
422 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
423 and it allows expressions involving EMACS_INT casts.
424 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
425
57ec3034
JD
4262012-07-25 Jan Djärv <jan.h.d@swipnet.se>
427
428 * nsterm.m (ns_read_socket): Return early if there is a modal
429 window (Bug#12043).
430
8137e7b3
MR
4312012-07-25 Martin Rudalics <rudalics@gmx.at>
432
433 * frame.c (Fredirect_frame_focus): In doc-string don't mention
434 that FOCUS-FRAME can be omitted.
435
04e9897c
DA
4362012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
437
438 Adjust buffer text indirection counters at the end of Fkill_buffer.
439 * buffer.c (Fkill_buffer): Adjust indirection counters when the
440 buffer is definitely dead. This should really fix an issue reported
441 by Christoph Scholtes again. (Bug#12007).
442 (init_buffer_once): Initialize indirection counters of
443 buffer_defaults and buffer_local_symbols (for sanity and safety).
444
8a0484e1
EZ
4452012-07-24 Eli Zaretskii <eliz@gnu.org>
446
447 * xdisp.c (init_iterator): Don't compute dimensions of truncation
448 and continuation glyphs on tooltip frames, leave them at zero.
449 Avoids continued lines in tooltips. (Bug#11832)
450
fa691a83
DA
4512012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
452
453 Simplify copy_overlay.
04e9897c 454 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
455 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
456
436bc8e0
EZ
4572012-07-23 Eli Zaretskii <eliz@gnu.org>
458
459 * print.c (print_object): Don't crash when a frame's name is nil
460 or invalid. (Bug#12025)
461
462 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
463 it signals an error when a tooltip frame is being created.
464
d7a7fda3
DA
4652012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
466
467 Cleanup miscellaneous objects allocation and initialization.
468 * alloc.c (allocate_misc): Change to static. Add argument to
469 specify the subtype. Adjust comment and users.
470 (build_overlay): New function.
471 * buffer.c (copy_overlays, Fmake_overlay): Use it.
472 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
473 (allocate_misc): Remove prototype.
474 (build_overlay): Add prototype.
475
4762012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
477
478 Swap buffer text indirection counters in Fbuffer_swap_text.
479 * buffer.c (Fbuffer_swap_text): Swap indirections too.
480 This avoids crash reported by Christoph Scholtes at
481 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
482
9d7fa573
JD
4832012-07-22 Jan Djärv <jan.h.d@swipnet.se>
484
485 * nsmenu.m (Popdown_data): New struct.
486 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
487 free Popdown_data.
488 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
489 (initWithContentRect): Make imgView and contentView non-static
490 and autorelease them. Also autorelease img and matrix (Bug#12005).
491 (dealloc): Remove (Bug#12005).
492
0dd6d66d
DA
4932012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
494
495 Adjust consing_since_gc when objects are explicitly freed.
496 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
497 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
498 (free_cons, free_misc): Subtract object size from consing_since_gc.
499
d36d71df
DA
5002012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
501
502 Simplify and cleanup markers positioning code.
503 * marker.c (attach_marker): More useful eassert.
504 (live_buffer, set_marker_internal): New function.
505 (Fset_marker, set_marker_restricted): Use set_marker_internal.
506 (set_marker_both, set_marker_restricted_both): Use live_buffer.
507
fb9ea40f
PE
5082012-07-22 Paul Eggert <eggert@cs.ucla.edu>
509
510 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
511 as it's limited by the amount of memory, not by INT_MAX.
512
2d5c5f7d
EZ
5132012-07-21 Eli Zaretskii <eliz@gnu.org>
514
07fb592e
EZ
515 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
516 in special-event-map. See the discussion at
517 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
518 for the reasons.
519
37a9eac8 520 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
521 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
522 Fabrice Popineau <fabrice.popineau@supelec.fr>.
523
c4328746
JD
5242012-07-21 Jan Djärv <jan.h.d@swipnet.se>
525
526 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 527 (conversationIdentifier): Return value is NSInteger.
784051c4 528 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 529
6e5d1c12
CY
5302012-07-21 Chong Yidong <cyd@gnu.org>
531
532 * window.c (decode_any_window): Signal an error if the window is
533 on a dead frame (Bug#11984).
534
9928463d
DA
5352012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
536
537 Add indirection counting to speed up Fkill_buffer.
538 * buffer.h (struct buffer): New member.
539 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
540 (Fmake_indirect_buffer): Set indirection counter to -1, increment
541 base buffer indirection counter.
542 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
543 (Fkill_buffer): Adjust indirection counters as needed, don't walk
544 through buffer list if indirection counter is 0.
545
f8643a6b
DA
5462012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
547
548 Extend the value returned by Fgarbage_collect with heap statistics.
549 * alloc.c (Qheap): New symbol.
550 (syms_of_alloc): DEFSYM it.
551 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
552 (Fmemory_free): Remove.
553 (syms_of_alloc): Don't defsubr it.
554 * buffer.c (Fcompact_buffer): Remove.
555 (syms_of_buffer): Don't defsubr it.
556
dac616ff
DA
5572012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
558
559 Make maybe_gc inline.
560 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
561 * lisp.h (consing_since_gc, gc_relative_threshold)
562 (memory_full_cons_threshold): Revert declaration.
563 (maybe_gc): Remove prototype, define as inline.
564 * alloc.c: Remove old commented-out code.
565 (consing_since_gc, gc_relative_threshold)
566 (memory_full_cons_threshold): Revert to global.
567 (maybe_gc): Remove.
568
d7ea76b4
DA
5692012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
570
571 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
572 * lisp.h (build_unibyte_string): New function.
573 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
574 * sysdep.c, w32fns.c, xfns.c: Use it.
575 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
576 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
577 Adjust users accordingly.
578 * font.h (font_open_by_name): Adjust prototype.
579
765e61e3
DA
5802012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
581
582 Cleanup calls to Fgarbage_collect.
583 * lisp.h (maybe_gc): New prototype.
584 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
585 Remove declarations.
586 * alloc.c (maybe_gc): New function.
587 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
588 Make them static.
589 * bytecode.c (MAYBE_GC): Use maybe_gc.
590 * eval.c (eval_sub, Ffuncall): Likewise.
591 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
592 to avoid dependency from auto-save feature.
593
52b852c7
PE
5942012-07-19 Paul Eggert <eggert@cs.ucla.edu>
595
596 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
597 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
598 'for_each_per_buffer_object_at'.
599 All uses changed. It's better to use upper-case for macros that
600 cannot be implemented as functions, to give the reader a clue
601 that they're special.
602
5db81e33
SM
6032012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
604
605 * alloc.c (Fgarbage_collect): Tweak docstring.
606
5b835e1d
DA
6072012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
608
609 Tweak the value returned from Fgarbage_collect again.
610 * alloc.c (Fgarbage_collect): New return value, as confirmed in
611 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
612 Adjust documentation.
613 (total_vector_bytes): Rename to total_vector_slots, adjust
614 accounting.
615 (total_free_vector_bytes): Rename to total_free_vector_slots,
616 adjust accounting.
617 (Qstring_bytes, Qvector_slots): New symbols.
618 (syms_of_alloc): DEFSYM them.
619
9cd47b72
DA
6202012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
621
622 Buffer compaction primitive which may be used from Lisp.
623 * buffer.c (compact_buffer, Fcompact_buffer): New function.
624 (syms_of_buffer): Register Fcompact_buffer.
625 * alloc.c (Fgarbage_collect): Use compact_buffer.
626 * buffer.h (compact_buffer): New prototype.
627 (struct buffer_text): New member.
628
d17337e5
DA
6292012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
630
631 New macro to iterate over all buffers, miscellaneous cleanups.
632 * lisp.h (all_buffers): Remove declaration.
633 * buffer.h (all_buffers): Add declaration, with comment.
634 (for_each_buffer): New macro.
635 * alloc.c (Fgarbage_collect, mark_object): Use it.
636 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
637 (init_buffer): Likewise.
638 * data.c (Fset_default): Likewise.
639 * coding.c (code_conversion_restore): Remove redundant check
640 for dead buffer.
641 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
642
60cfd278
AS
6432012-07-18 Andreas Schwab <schwab@linux-m68k.org>
644
645 Fix bug that created negative-length intervals.
646 * intervals.c (merge_interval_right, merge_interval_left):
647 Do not zero out this interval if it is absorbed by its children,
648 as this interval's total length doesn't change in that case. See
649 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
650
d06714cb
PE
6512012-07-18 Paul Eggert <eggert@cs.ucla.edu>
652
83713154
PE
653 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
654 when invoking (make-bool-vector N t) and N is a positive
655 multiple of 8 -- the last 8 bits were mistakenly cleared.
656
d06714cb
PE
657 Remove some struct layout assumptions in bool vectors.
658 * alloc.c (bool_header_size): New constant.
659 (header_size, word_size): Move earlier, as they're now used earlier.
660 Use 'word_size' in a few more places, where it's appropriate.
661 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
662 padding before the data member of a bool vector.
663 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
664 than doing the check by hand with an abort ().
665
464d5a5e
SM
6662012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
667
5fbc0409
SM
668 * eval.c (Fdefvar): Don't check constants since we only set the var if
669 it's not yet defined anyway (bug#11904).
670
464d5a5e
SM
671 * lisp.h (last_undo_boundary): Declare new var.
672 * keyboard.c (command_loop_1): Set it.
673 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
674 were auto-added by the command loop (bug#11774).
675
8dc2e44a
AS
6762012-07-18 Andreas Schwab <schwab@linux-m68k.org>
677
678 * w32font.c (Qsymbol): Remove local definition.
679 (syms_of_w32font): Don't DEFSYM it.
680
169925ec
DA
6812012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
682
683 Fix sweep_vectors to handle large bool vectors correctly.
684 * alloc.c (sweep_vectors): Account total_vector_bytes for
685 bool vectors larger than VBLOCK_BYTES_MAX.
686
5fbfb018
CY
6872012-07-18 Chong Yidong <cyd@gnu.org>
688
689 * frame.c (x_set_frame_parameters): Revert bogus change introduced
690 in 2012-05-25 commit by Paul Eggert (Bug#11738).
691
3ab6e069
DA
6922012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
693
694 Return more descriptive data from Fgarbage_collect.
695 Suggested by Stefan Monnier in
696 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
697 * alloc.c (bounded_number): New function.
698 (total_buffers, total_vectors): New variable.
699 (total_string_size): Rename to total_string_bytes, adjust users.
700 (total_vector_size): Rename to total_vector_bytes, adjust users.
701 (sweep_vectors): Account total_vectors and total_vector_bytes.
702 (Fgarbage_collect): New return value. Adjust documentation.
703 (gc_sweep): Account total_buffers.
704 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
705 (VECTOR_SIZE): Remove.
706 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
707 (Qinterval, Qmisc): New symbols.
708 (syms_of_data): Initialize them.
709 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
710 (Qcons, Qbuffer): New declarations.
711
6d02fe5b
PE
7122012-07-17 Paul Eggert <eggert@cs.ucla.edu>
713
714 * alloc.c (Fmemory_free): Account for memory-free's own storage.
715 Round up, not down. Improve doc.
716
b7ffe040
DA
7172012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
718
719 Restore old code in allocate_string_data to avoid Faset breakage.
720 Reported by Julien Danjou <julien@danjou.info> in
721 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
722 * alloc.c (allocate_string_data): Restore old code with minor
723 adjustments, fix comment to explain this subtle issue.
724
4dc7c8d5
SM
7252012-07-17 Eli Zaretskii <eliz@gnu.org>
726
727 Remove FILE_SYSTEM_CASE.
728 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
729
730 * fileio.c (FILE_SYSTEM_CASE): Don't define.
731 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
732 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
733 call-process-region passes it through expand-file-name.
734
735 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
736
7372012-07-17 Andreas Schwab <schwab@linux-m68k.org>
738
739 Fix crash when creating indirect buffer (Bug#11917)
740 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
741 Don't handle unbound variables specially if non-zero.
742 (Fbuffer_local_variables): Pass zero.
743 (clone_per_buffer_values): Pass non-zero.
744
7452012-07-17 Andreas Schwab <schwab@linux-m68k.org>
746
747 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
748 to make the loop interruptible.
749
7502012-07-17 Andreas Schwab <schwab@linux-m68k.org>
751
752 * gnutls.c (emacs_gnutls_handshake): Only retry if
753 GNUTLS_E_INTERRUPTED.
754
cce7fefc
DA
7552012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
756
757 Cleanup and convert miscellaneous checks to eassert.
758 * alloc.c (mark_interval): Fix comment, partially rephrase
759 old comment from intervals.h (see below).
760 * intervals.c (find_interval, adjust_intervals_for_insertion)
761 (delete_interval, adjust_intervals_for_deletion)
762 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
763 Convert to eassert.
764 (adjust_intervals_for_insertion, make_new_interval):
765 Remove obsolete and unused code.
766 * intervals.h (struct interval): Remove obsolete comment.
767 * textprotp.c (erase_properties): Remove unused code.
768 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
769 (Fremove_list_of_text_properties): Convert to eassert.
770
9ea10cc3
CY
7712012-07-17 Chong Yidong <cyd@gnu.org>
772
773 * editfns.c (Finsert_char): Doc fix.
774
3900d5de
DA
7752012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
776
777 Fix previous change to make Fmemory_free always accurate.
778 * alloc.c (make_interval): Update total_free_intervals.
779 (make_float): Likewise for total_free_floats.
780 (free_cons, Fcons): Likewise for total_free_conses.
781 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
782 Likewise for total_free_vector_bytes.
783 (Fmake_symbol): Likewise for total_free_symbols.
784 (bytes_free): Remove.
785
7098646f
DA
7862012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
787
788 Simple free memory accounting feature.
789 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
790 (sweep_vectors): Accumulate size of free vectors.
791 (Fgarbage_collect): Setup bytes_free.
792 (Fmemory_free): New function.
793 (syms_of_alloc): Register it.
794
22657b40
DA
7952012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
796
797 Cleanup overlays checking.
798 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
799 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
800 eassert and OVERLAYP.
801 (sort_overlays): Change to use OVERLAYP.
802
ddfc8813
RK
8032012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
804
805 * editfns.c (Finsert_char): Make it interactive, and make the
806 second arg optional. Copy interactive spec and docstring from
807 ucs-insert.
808
7c26cf3c
PE
8092012-07-17 Paul Eggert <eggert@cs.ucla.edu>
810
811 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
812 Unlike the other wrapped functions, fabs has an unspecified
813 effect on errno.
814
5d127af9
JD
8152012-07-16 Jan Djärv <jan.h.d@swipnet.se>
816
817 * nsterm.m (keyDown): Interpret flags without left/right bits
818 as the left key (Bug#11670).
819
6a0dd1d7
DA
8202012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
821
822 Remove empty and useless init functions.
823 * lisp.h (init_character_once, init_fns, init_image)
824 (init_filelock, init_sound): Remove prototype.
825 * character.c (init_character_once): Remove.
826 * filelock.c (init_filelock): Likewise.
827 * fns.c (init_fns): Likewise.
828 * image.c (init_image): Likewise.
829 * sound.c (init_sound): Likewise.
830 * emacs.c (main): Adjust accordingly.
831
7a6136fd
DA
8322012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
833
834 * gtkutil.h: Tiny cleanups.
835 (use_old_gtk_file_dialog): Remove useless declaration.
836 (xg_uses_old_file_dialog): Add suggested const attribute.
837
ce811ad9
EZ
8382012-07-15 Eli Zaretskii <eliz@gnu.org>
839
840 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
841 (bidi_paragraph_init): Use it to limit search forward for a strong
842 directional character in abnormally large paragraphs full of
843 neutral or weak characters. (Bug#11943)
844
c9adfeaa
SF
8452012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
846
847 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
848 the toolbar (Bug#9451).
849 (xg_make_tool_item): Give the widget event box a transparent
850 background.
851
fff62aa9
DA
8522012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
853
854 Cleanup basic allocation variables and functions.
855 * alloc.c (ignore_warnings, init_intervals, init_float)
856 (init_cons, init_symbol, init_marker): Remove.
857 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
858 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
859 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
860 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
861 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
862 (staticidx, init_alloc_once, init_strings, free_ablock):
863 Remove redundant initialization.
864 * fns.c (init_weak_hash_tables): Remove.
865 * lisp.h (init_weak_hash_tables): Remove prototype.
866
9730daca
DA
8672012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
868
869 Use zero_vector where appropriate.
870 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
871 accordingly.
872 * lisp.h (zero_vector): New declaration.
873 * font.c (null_vector): Remove.
874 (syms_of_font): Remove initialization and staticpro.
875 (font_list_entities, font_find_for_lface): Change to use zero_vector.
876 * keymap.c (Faccessible_keymaps): Likewise.
877
2e2d2a13
LL
8782012-07-15 Leo Liu <sdl.web@gmail.com>
879
880 * fringe.c: Fix typo in comments.
881
cd276f6e
LL
8822012-07-14 Leo Liu <sdl.web@gmail.com>
883
884 * fringe.c: Add a new bitmap exclamation-mark.
885
5a1131d9
EZ
8862012-07-14 Eli Zaretskii <eliz@gnu.org>
887
888 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
889
890 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
891 (HAVE_MENUS): Don't define, defined by editing config.in with
892 msdos/sed2v2.inp.
893 (GMALLOC_INHIBIT_VALLOC): Don't define.
894 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
895
22e983b7
JB
8962012-07-14 Juanma Barranquero <lekktu@gmail.com>
897
898 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
899
5b3f250f
GM
9002012-07-14 Glenn Morris <rgm@gnu.org>
901
902 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
903 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
904 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
905
33d63ff4
GM
9062012-07-13 Glenn Morris <rgm@gnu.org>
907
5b633342
GM
908 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
909
33d63ff4
GM
910 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
911 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
912
b55b9f85
JD
9132012-07-13 Jan Djärv <jan.h.d@swipnet.se>
914
0dc8cf50
JD
915 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
916 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
917 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
918 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
919 where appropriate.
920 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
921 as boolean expression.
922 (x_set_window_size): Remove unused variable toolbar.
923 (ns_get_color_default, ns_mod_to_lisp): Remove.
924 (ns_mouse_position): Remove unused variables xchar and ychar.
925 (ns_compute_glyph_string_overhangs): Remove unused variable face.
926 (ns_set_vertical_scroll_bar): Remove unused variable count.
927 (ns_delete_terminal): Remove unused variable i.
928 (ns_term_init): Remove unused variables r, g and b.
929 (mouseDown): Remove unused variable window.
930 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
931 (initFrameFromEmacs): Remove unused variable vbextra.
932 (mouseEntered): Remove unused variables p and dpyinfo.
933 (mouseExited): Remove unused variables p and r.
934 (ns_define_frame_cursor, ns_clear_frame_area)
935 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
936 (menuDown): Assign [sender tag] to variable and cast the variable.
937
938 * nsterm.h (menuDown): Add id as type to argument sender.
939 (ns_display_info_for_name): Add Lisp_Object argument.
940 (ns_term_init): Add Lisp_Object argument.
941 (ns_map_event_to_object): Add void argument.
942 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
943 prototype with arguments and only declare if __OBJC__.
944 (nxatoms_of_nsselect): Add void argument.
945 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
946 (ns_alloc_autorelease_pool): Add void argument.
947 (ns_release_autorelease_pool): Add void* argument.
948 (ns_get_defaults_value): Add const char* argument.
949
950 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
951 (initFromContents): Use SSDATA where appropriate.
952 (ns_update_menubar): Add braces to ambigous if-else.
953 (initWithTitle): Put () around assignment in if statement.
954 (ns_menu_show): Remove unused variables window and keymap.
955 (update_frame_tool_bar): Remove unused variable selected_p.
956 (initWithContentRect): Remove unused variable this_cmd_name.
957
958 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
959 appropriate.
960 (setXBMColor): Remove unused variable len.
961 (setPixmapData): Put () around assignment in loop statement.
962
963 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
964 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
965 where appropriate.
966 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
967 around assignment in loop statement.
968 (nsfont_open): Remove unused variable i.
969 (nsfont_open): Remove unused variable len.
970 (nsfont_draw): Remove unused variable cs.
971
972 * nsfns.m (x_set_icon_name, ns_set_name_internal)
973 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
974 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
975 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
976 (Fns_font_name, Fns_perform_service)
977 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
978 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
979 (ns_set_name): Remove unused variable view.
980 (x_set_menu_bar_lines): Remove unused variable olines.
981 (x_set_tool_bar_lines): Remove unused variable root_window.
982 (Fns_list_colors): Put () around assignment in while statement.
983 (Fns_perform_service): Remove unused variable len.
984 (Fns_display_usable_bounds): Remove unused variable top.
985 (syms_of_nsfns): Remove unused variable i.
986
b55b9f85
JD
987 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
988 memcpy (Bug#11907).
989
ed9265fc 9902012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
991
992 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
993 and free it with DestroyExceptionInfo (Bug#11558).
994
ef099b57
JB
9952012-07-13 Juanma Barranquero <lekktu@gmail.com>
996
997 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
998 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
999 Set here, not in nt/config.nt.
1000
ea814a5d
EZ
10012012-07-13 Eli Zaretskii <eliz@gnu.org>
1002
1003 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1004 cursor overflow into the last glyph on display line when the right
1005 fringe is off. (Bug#11832)
1006
1a952767
PE
10072012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1008
1009 * xdisp.c (produce_special_glyphs): Now static.
1010 * dispextern.h (produce_special_glyphs): Remove decl.
1011
983188fd
GM
10122012-07-13 Glenn Morris <rgm@gnu.org>
1013
32fb4bb6
GM
1014 * s/bsd-common, s/cygwin.h: Remove empty files.
1015 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1016
983188fd
GM
1017 * s/usg5-4-common.h (USG, USG5):
1018 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1019 * s/sol2-6.h (SOLARIS2):
1020 * s/irix6-5.h (IRIX6_5):
1021 * s/hpux10-20.h (USG, USG5, HPUX):
1022 * s/gnu-linux.h (USG, GNU_LINUX):
1023 * s/freebsd.h (BSD_SYSTEM):
1024 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1025 * s/cygwin.h (CYGWIN):
1026 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1027 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1028
d1e68667 10292012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1030
1031 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1032
6de0e799
GM
10332012-07-13 Glenn Morris <rgm@gnu.org>
1034
739ae010
GM
1035 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1036
dbee5793
GM
1037 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1038
6de0e799
GM
1039 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1040 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1041
b82da769
GM
10422012-07-12 Glenn Morris <rgm@gnu.org>
1043
4fae5a7a 1044 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1045
1046 * process.c (init_process_emacs): Rename from init_process.
1047 The old name is also the name of a Mach system call.
1048 * lisp.h, emacs.c: Update for this name change.
1049 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1050 longer needed.
1051
5a979817
EZ
10522012-07-12 Eli Zaretskii <eliz@gnu.org>
1053
1054 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1055 memmove call that removes glyphs covered by the left truncation
1056 glyph. Improve commentary.
1057 (display_line): Fix display of continuation glyphs on GUI frames
1058 when the right fringe is turned off and variable-size fonts are
1059 used in the window. Move the code that appends a stretch glyph to
1060 produce_special_glyphs, so that it could be used for truncation
1061 and continuation glyphs alike.
1062 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1063 glyph of a suitably computed width, to align the special glyphs at
1064 the window margin. Code moved from display_line. (Bug#11832)
1065
3e91a053
GM
10662012-07-12 Glenn Morris <rgm@gnu.org>
1067
ba9e4b84
GM
1068 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1069
1070 * s/gnu-linux.h, s/hpux10-20.h:
1071 Do not unconditionally define HAVE_XRMSETDATABASE.
1072
3e91a053
GM
1073 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1074
b300b1f4
PE
10752012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1076
1077 Fix typos that broke OS X build.
1078 Reported by Randal L. Schwartz in
1079 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1080 * nsterm.m (ns_timeout): Add missing local decl.
1081 (ns_get_color): snprintf -> sprintf, to fix typo.
1082
6e777848
GM
10832012-07-12 Glenn Morris <rgm@gnu.org>
1084
3f922c37
GM
1085 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1086 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1087 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1088 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1089
0ab7b23a
GM
1090 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1091 Move PTY_OPEN to configure.
1092
6e777848
GM
1093 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1094 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1095 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1096
4a7edc24
DA
10972012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1098
1099 Use empty_unibyte_string where applicable.
1100 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1101 * lread.c (read1): Likewise.
1102 * xsettings.c (syms_of_xsettings): Likewise.
1103
308aab79
GM
11042012-07-12 Glenn Morris <rgm@gnu.org>
1105
42bd1719
GM
1106 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1107 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1108 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1109 * s/hpux10-20.h (RUN_TIME_REMAP):
1110 * s/bsd-common.h (TABDLY): Move to configure.
1111
1112 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1113
1114 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1115
ea0bbd17 1116 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1117 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1118
1119 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1120
308aab79
GM
1121 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1122 * s/template.h: Move NARROWPROTO to configure.
1123
ee1cf5cf
GM
11242012-07-11 Glenn Morris <rgm@gnu.org>
1125
30fe9bf4
GM
1126 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1127 unused since 2011-01-17 change to systty.h.
1128
ee1cf5cf
GM
1129 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1130 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1131 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1132
63e47e07
PE
11332012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1134
1135 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1136
c43fb4c3
GM
11372012-07-11 Glenn Morris <rgm@gnu.org>
1138
1139 * s/darwin.h, s/gnu-linux.h, s/template.h:
1140 Move INTERRUPT_INPUT to configure.
1141
e8df9267
DA
11422012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1143
1144 Minor adjustments to interning code.
1145 * lisp.h (intern, intern_c_string): Redefine as static inline
1146 wrappers for intern_1 and intern_c_string_1, respectively.
1147 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1148 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1149 Vobarray checking.
e8df9267
DA
1150 * font.c (font_intern_prop): Likewise. Adjust comment.
1151 * w32font.c (intern_font_name): Likewise.
1152
34348bd4
AS
11532012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1154
d96a1e0c
AS
1155 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1156
34348bd4
AS
1157 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1158 of Fcar/Fcdr if possible.
1159 * font.c (check_otf_features): Likewise.
1160 * fontset.c (Fnew_fontset): Likewise.
1161 * gnutls.c (Fgnutls_boot): Likewise.
1162 * minibuf.c (read_minibuf): Likewise.
1163 * msdos.c (IT_set_frame_parameters): Likewise.
1164 * xmenu.c (Fx_popup_dialog): Likewise.
1165 * w32menu.c (Fx_popup_dialog): Likewise.
1166
c8add24e
GM
11672012-07-11 Glenn Morris <rgm@gnu.org>
1168
4b575b3c
GM
1169 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1170 since nothing has defined it on these platforms.
1171
09f4e3b0
GM
1172 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1173 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1174
172bedef
GM
1175 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1176 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1177 Move CLASH_DETECTION to configure.
1178
249685df
GM
1179 * s/gnu.h: Remove file, which is now empty.
1180
c8add24e
GM
1181 * s/gnu.h, s/gnu-linux.h:
1182 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1183
b41253a3
JW
11842012-07-11 John Wiegley <johnw@newartisans.com>
1185
1186 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1187 function attribute, so we only use it if it exists in the
1188 compiler.
1189
d923b542
DA
11902012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1191
1192 Avoid call to strlen in fast_c_string_match_ignore_case.
1193 * search.c (fast_c_string_match_ignore_case): Change to use
1194 length argument. Adjust users accordingly.
1195 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1196
5ebbef1d
PE
11972012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1198
bb352260
PE
1199 Assume mkdir, rmdir.
1200 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1201 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1202
57054ddd
PE
1203 Assume rename.
1204 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1205
b747d3f7
PE
1206 Assume perror.
1207 * s/hpux10-20.h (HAVE_PERROR): Remove.
1208 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1209 Remove dummy definition, as this problem was obsolete long ago.
1210
5ebbef1d
PE
1211 Assume strerror.
1212 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1213
984e7f30
DA
12142012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1215
1216 Avoid calls to strlen in font processing functions.
1217 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1218 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1219 users accordingly.
d923b542
DA
1220 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1221 Adjust prototypes.
1222 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1223 Change to return ptrdiff_t.
984e7f30
DA
1224 (xfont_list_pattern, xfont_match): Use length returned by
1225 xfont_decode_coding_xlfd.
1226 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1227
20e94fdd
GM
12282012-07-11 Glenn Morris <rgm@gnu.org>
1229
9d596af3
GM
1230 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1231 Move DONT_REOPEN_PTY to configure.
1232
20e94fdd
GM
1233 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1234 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1235
e99a530f
PE
12362012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1237
22ffb973
PE
1238 Remove "#define unix" that is no longer needed (Bug#11905).
1239 * s/aix4-2.h (unix): Remove; no longer needed.
1240
e9a9ae03
PE
1241 EMACS_TIME simplification (Bug#11875).
1242 This replaces macros (which typically do not work in GDB)
1243 with functions, typedefs and enums, making the code easier to debug.
1244 The functional style also makes code easier to read and maintain.
1245 * systime.h: Include <sys/time.h> on all hosts, not just if
1246 WINDOWSNT, since 'struct timeval' is needed in general.
1247 (EMACS_TIME): Now a typedef, not a macro.
1248 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1249 not macros.
1250 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1251 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1252 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1253 (EMACS_TIME_LE): Now functions, not macros.
1254 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1255 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1256 which are not functions. All uses rewritten to use:
1257 (make_emacs_time): New function.
1258 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1259 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1260 not functions. All uses rewritten to use the following, respectively:
1261 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1262 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1263 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1264 * fileio.c (Fcopy_file):
1265 * xterm.c (XTflash): Get the current time closer to when it's used.
1266 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1267
ffacb126
PE
1268 * bytecode.c (targets): Suppress -Woverride-init warnings.
1269
e99a530f
PE
1270 Simplify by avoiding confusing use of strncpy etc.
1271 * doc.c (Fsnarf_documentation):
1272 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1273 * frame.c (Fmake_terminal_frame):
1274 * gtkutil.c (get_utf8_string):
1275 * lread.c (openp):
1276 * nsmenu.m (ns_update_menubar):
1277 * regex.c (regerror):
1278 Prefer memcpy to strncpy and strncat when either will do.
1279 * fileio.c (Fsubstitute_in_file_name):
1280 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1281 (menu_separator_name_p):
1282 * nsmenu.m (ns_update_menubar):
1283 Prefer memcmp to strncmp when either will do.
1284 * nsterm.m: Include <ftoastr.h>.
1285 (ns_get_color):
1286 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1287 Prefer snprintf to strncpy.
1288 * nsterm.m (ns_term_init):
1289 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1290 * nsterm.m (ns_term_init):
1291 Avoid the need for strncpy, by using build_string or
1292 make_unibyte_string directly. Use dtoastr, not snprintf.
1293 * process.c (Fmake_network_process): Diagnose service names that
1294 are too long, rather than silently truncating them or creating
1295 non-null-terminated names.
1296 (Fnetwork_interface_info): Likewise, for interface names.
1297 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1298 Prefer sprintf to strncat.
1299 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1300 Prefer vsnprintf to vsprintf + strncpy.
1301
c59592b3
GM
13022012-07-10 Glenn Morris <rgm@gnu.org>
1303
1304 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1305 Clarify fallback case.
1306
7d7bbefd
DA
13072012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1308
1309 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1310 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1311 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1312 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1313 where argument type is known to be a Lisp_Cons.
1314
3a4c8000
TT
13152012-07-10 Tom Tromey <tromey@redhat.com>
1316
1317 * bytecode.c (BYTE_CODE_THREADED): New macro.
1318 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1319 (enum byte_code_op): New type.
1320 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1321 (exec_byte_code): Use them. Use token threading when applicable.
1322
2a0213a6
DA
13232012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1324
1325 Optimize pure C strings initialization.
1326 * lisp.h (make_pure_string): Fix prototype.
1327 (build_pure_c_string): New function, defined as static inline. This
1328 provides a better opportunity to optimize away calls to strlen when
1329 the function is called with compile-time constant argument.
1330 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1331 argument, adjust users accordingly. Use build_pure_c_string where
1332 appropriate.
1333 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1334 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1335 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1336
cb1caeaf
DA
13372012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1338
1339 Avoid calls to strlen in miscellaneous functions.
1340 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1341 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1342 * lread.c (openp): Likewise.
1343
c293e30c
DA
13442012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1345
1346 Avoid calls to strlen in path processing functions.
1347 * fileio.c (file_name_as_directory): Add comment. Change to add
1348 srclen argument and return the length of result. Adjust users
1349 accordingly.
1350 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1351 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1352 users accordingly.
1353 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1354
9e059e3f
GM
13552012-07-10 Glenn Morris <rgm@gnu.org>
1356
d02eb359
GM
1357 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1358 Move PENDING_OUTPUT_COUNT definition to configure.
1359
882cf227
GM
1360 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1361 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1362 * s/gnu.h (DATA_START): Move definitions to configure.
1363
af6e839f
GM
1364 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1365 We include usg5-4-common.h, which defines them both.
1366
40289a12
GM
1367 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1368 O_RDONLY already includes it).
1369
9e059e3f
GM
1370 Stop ns builds setting the EMACSLOADPATH environment variable.
1371 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1372 Now it does not set EMACSLOADPATH, just returns the load-path string.
1373 * nsterm.h: Update accordingly.
1374 * lread.c [HAVE_NS]: Include nsterm.h.
1375 (init_lread) [HAVE_NS]: Use ns_load_path.
1376 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1377
7c4e8ec0
GM
13782012-07-09 Glenn Morris <rgm@gnu.org>
1379
d4f600ff
GM
1380 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1381 since the included bsd-common.h does so.
1382
cbb31951
GM
1383 Stop ns builds setting the EMACSPATH environment variable.
1384 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1385 (ns_init_paths): Do not set EMACSPATH.
1386 * nsterm.h (ns_exec_path): Add it.
1387 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1388 Use ns_exec_path.
1389
7c4e8ec0
GM
1390 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1391
26bccfae
PE
13922012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1393
a0bee46f
PE
1394 * process.c (wait_reading_process_output): 'waitchannels' was unset
1395 when read_kbd || !NILP (wait_for_cell); fix this.
1396
5994c183
PE
1397 Add GCC-style 'const' attribute to functions that can use it.
1398 * character.h (char_resolve_modifier_mask):
1399 * keyboard.h (make_ctrl_char):
1400 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1401 (init_character_once, next_almost_prime, init_fns, init_image)
1402 (flush_pending_output, init_sound):
1403 * mem-limits.h (start_of_data):
1404 * menu.h (finish_menu_items):
1405 Add ATTRIBUTE_CONST.
1406 * emacs.c (DEFINE_DUMMY_FUNCTION):
1407 Declare the dummy function with ATTRIBUTE_CONST.
1408 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1409 Add decls with ATTRIBUTE_CONST.
1410
26bccfae
PE
1411 Minor improvements to make_formatted_string.
1412 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1413 where int is good enough, as vsprintf returns an int.
1414 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1415
a8290ec3
DA
14162012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1417
1418 Use make_formatted_string to avoid double length calculation.
1419 * lisp.h (make_formatted_string): New prototype.
1420 * alloc.c (make_formatted_string): New function.
1421 * buffer.c (Fgenerate_new_buffer_name): Use it.
1422 * dbus.c (syms_of_dbusbind): Likewise.
1423 * editfns.c (Fcurrent_time_zone): Likewise.
1424 * filelock.c (get_boot_time): Likewise.
1425 * frame.c (make_terminal_frame, set_term_frame_name)
1426 (x_report_frame_params): Likewise.
1427 * image.c (gs_load): Likewise.
1428 * minibuf.c (get_minibuffer): Likewise.
1429 * msdos.c (dos_set_window_size): Likewise.
1430 * process.c (make_process): Likewise.
1431 * xdisp.c (ensure_echo_area_buffers): Likewise.
1432 * xsettings.c (apply_xft_settings): Likewise.
1433
d01ba2f1
GM
14342012-07-09 Glenn Morris <rgm@gnu.org>
1435
1436 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1437 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1438 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1439 * nsterm.h (ns_etc_directory): Add it.
1440 * callproc.c [HAVE_NS]: Include nsterm.h.
1441 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1442
f1f924b6
DA
14432012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1444
1445 Move marker debugging code under MARKER_DEBUG.
1446 * marker.c (MARKER_DEBUG): Move marker debugging code under
1447 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1448 for bootstrap with --enable-checking (~3x slowdown reported
1449 by Juanma Barranquero <lekktu@gmail.com>).
1450 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1451
ab531b66
PE
14522012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1453
1454 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1455 See <http://bugs.gnu.org/11825#29>.
1456
c4b3bc8a
EZ
14572012-07-08 Eli Zaretskii <eliz@gnu.org>
1458
1459 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1460 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1461 (display_line): Add commentary about displaying truncation glyphs
1462 on GUI frames.
1463 (produce_special_glyphs): Move here from term.c.
1464
1465 * term.c (produce_special_glyphs): Move to xdisp.c.
1466
1467 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1468 section.
c4b3bc8a 1469
b676b881
AS
14702012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1471
f17c5273
AS
1472 * xdisp.c (display_line): Avoid warning about implicit declaration
1473 of FRAME_FONT.
1474
298819b9
AS
1475 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1476
b676b881
AS
1477 * lisp.h: Remove empty conditional.
1478
6045c4fd
PE
14792012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1480
b3350bf9
PE
1481 * lread.c (load_path_check): Now static.
1482
6045c4fd
PE
1483 Fix some minor --with-ns problems found by static checking.
1484 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1485 (x_set_font) [!HAVE_X_WINDOWS]:
1486 * image.c (xpm_load_image) [HAVE_NS]:
1487 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1488 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1489 Remove unused local.
1490 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1491 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1492 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1493 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1494 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1495 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1496 Fix pointer signedness problem.
1497 * xfaces.c (FRAME_X_FONT_TABLE):
1498 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1499
929e7845
GM
15002012-07-07 Glenn Morris <rgm@gnu.org>
1501
1502 * lread.c (load_path_check): New function, split from init_lread.
1503 (init_lread): Reorganize. Motivation:
1504 If EMACSLOADPATH is set, check/warn about that rather than the
1505 defaults, which we are not going to use. Hence we can remove
1506 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1507 Don't warn if site-lisp directories are missing.
1508 If not installed, start from a blank load-path, since
1509 PATH_LOADSEARCH refers to the eventual installation directories.
1510
58dd0aa4
EZ
15112012-07-07 Eli Zaretskii <eliz@gnu.org>
1512
1513 Support truncation and continuation glyphs on GUI frames, when
1514 fringes are disabled. (Bug#11832)
1515 * xdisp.c (init_iterator): Get dimensions of truncation and
1516 continuation glyphs even if on GUI frames. Adjust
1517 it->last_visible_x on GUI frames when the left or right fringes,
1518 or both, are absent.
1519 (start_display, move_it_in_display_line_to): Handle the case of a
1520 GUI frame without a fringe to display continuation or truncation
1521 glyphs.
1522 (insert_left_trunc_glyphs): Support GUI frames: make sure
1523 truncation glyphs overwrite enough glyphs from the current line to
1524 have sufficient space in pixels.
1525 (display_line): Support truncation and continuation glyphs on GUI
1526 frames. If some spare pixels are left on the line after inserting
1527 the truncation glyphs, fill that space with a stretch glyph of a
1528 suitably computed width.
1529
1530 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1531 produce_glyphs, to support GUI sessions.
1532
31571fd7
PE
15332012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1534
5a16b9bc
PE
1535 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1536
f3047c75
PE
1537 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1538
31571fd7
PE
1539 Do not require float-time's arg to fit in time_t (Bug#11825).
1540 This works better on hosts where time_t is unsigned, and where
1541 float-time is applied to the (negative) difference between two times.
1542 * editfns.c (decode_time_components): Last arg is now double *,
1543 not int *, and means to store all the result as a double, without
1544 worrying about whether the seconds part fits in time_t.
1545 All callers changed.
1546 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1547 All callers changed.
1548 (Ffloat_time): Do not fail merely because the specified time falls
1549 outside of time_t range.
1550
4516fbef
GM
15512012-07-07 Glenn Morris <rgm@gnu.org>
1552
1553 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1554 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1555 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1556
07adc2c6
JB
15572012-07-07 Juanma Barranquero <lekktu@gmail.com>
1558
1559 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1560 Update dependencies.
1561
1562 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1563
fd573f31
PE
15642012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1565
fee5959d
PE
1566 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1567 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1568 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1569 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1570 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1571 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1572
fd573f31
PE
1573 * xfont.c (compare_font_names): Redo to omit the need for casts.
1574
ddadbc0e
AS
15752012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1576
fca8d6b6
AS
1577 * xfns.c (Fx_change_window_property): Doc fix.
1578 * w32fns.c (Fx_change_window_property): Doc fix.
1579
ddadbc0e
AS
1580 * w32fns.c (Fx_window_property): Accept the same arguments as the
1581 X Windows version. Doc fix.
1582 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1583
ed9265fc 15842012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1585 Eli Zaretskii <eliz@gnu.org>
1586
1587 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1588 Windows-specific code from nt/config.nt moved here.
1589 Obsolete settings removed.
1590
216ee680
PE
15912012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1592
1593 * process.c: Avoid unnecessary calls to gettime.
1594 (wait_reading_process_output): Don't get the time of day
1595 when gobbling data immediately and not waiting, as there's no need
1596 for it in that case. This removes a FIXME.
1597
bdd091e4
JD
15982012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1599
1600 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1601 is defined (Bug#11768).
1602
9d44f8ce
DA
16032012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1604
1605 Fix marker debugging code.
1606 * marker.c (byte_char_debug_check): Do not perform the check
1607 if buffer is not multibyte.
090bd7cb
JB
1608 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1609 Call byte_char_debug_check with correct arguments.
9d44f8ce 1610
90fc4786
DA
16112012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1612
1613 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1614 * marker.c (byte_char_debug_check, count_markers):
1615 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1616 (byte_debug_flag): Remove.
1617 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1618 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1619
7b7ae965
DA
16202012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1621
4e57b342
DA
1622 Avoid code repetition in marker-related functions.
1623 * marker.c (attach_marker): New function.
1624 (Fset_marker, set_marker_restricted, set_marker_both)
1625 (set_marker_restricted_both): Use it.
1626 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1627 Consistently rename charno to charpos.
1628 (marker_position): Add eassert.
1629 (marker_byte_position): Convert to eassert.
1630
16312012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1632
1633 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1634 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1635 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1636
657924ff
DA
16372012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1638
1639 Introduce fast path for the widely used marker operation.
1640 * alloc.c (build_marker): New function.
1641 * lisp.h (build_marker): New prototype.
1642 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1643 * composite.c (autocmp_chars): Likewise.
1644 * editfns.c (buildmark): Remove.
1645 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1646 (save_restriction_save): Use build_marker.
1647 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1648 * window.c (save_window_save): Likewise.
1649
041a49a6
DA
16502012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1651
1652 Do not use Fdelete_overlay in delete_all_overlays
1653 to avoid redundant calls to unchain_overlay.
1654 * buffer.c (drop_overlay): New function.
1655 (delete_all_overlays, Fdelete_overlay): Use it.
1656 * minibuf.c (get_minibuffer): Fix comment.
1657
7dca65a4
PE
16582012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1659
1660 Port to OpenBSD 5.1 amd64.
1661 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1662 This is needed for OpenBSD, and should be harmless on all BSD systems.
1663 Also, include <sys/sysctl.h>, as it should be available on all
1664 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1665 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1666 use p_pid member, not kp_proc.pid.
1667
8eb876e2
GM
16682012-07-06 Glenn Morris <rgm@gnu.org>
1669
1670 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1671
38182d90
PE
16722012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1673
1674 More xmalloc and related cleanup.
1675 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1676 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1677 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1678 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1679 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1680 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1681 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1682 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1683 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1684 * xterm.c:
1685 Omit needless casts involving void * pointers and allocation.
1686 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1687 as the former is more robust if P's type is changed.
1688 Prefer xzalloc to xmalloc + memset 0.
1689 Simplify malloc-or-realloc to realloc.
1690 Don't worry about xmalloc returning a null pointer.
1691 Prefer xstrdup to xmalloc + strcpy.
1692 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1693 growing it.
1694 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1695 alloca of a constant.
1696
6dd5a677
EZ
16972012-07-05 Eli Zaretskii <eliz@gnu.org>
1698
1699 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1700 hscroll is larger than the line width. Fixes long and futile
1701 looping inside extend_face_to_end_of_line (on a TTY) producing
1702 glyphs that are not needed and thrown away.
1703
6b312f0f
DA
17042012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1705
1706 * marker.c (set_marker_restricted_both): Simplify by using
1707 clip_to_bounds.
1708
f520ef9b
PE
17092012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1710
1711 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1712
383b7c95
JD
17132012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1714
1715 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1716 not defined (Bug#11768).
1717 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1718 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1719 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1720 followed by gtk_box_set_homogeneous (Bug#11768).
1721 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1722 (update_theme_scrollbar_width, xg_create_scroll_bar):
1723 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1724 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1725 (is_box_type): New function (Bug#11768).
1726 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1727 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1728 with default display (Bug#11768).
1729
d6e7bf45
EZ
17302012-07-05 Eli Zaretskii <eliz@gnu.org>
1731
1732 * xdisp.c (window_hscroll_limited): New function.
1733 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1734 coordinates when window's hscroll is set to insanely large
1735 values. (Bug#11857)
1736
431391ec
JB
17372012-07-05 Juanma Barranquero <lekktu@gmail.com>
1738
1739 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1740 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1741
23f86fce
DA
17422012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1743
1744 Cleanup xmalloc.
1745 * lisp.h (xzalloc): New prototype. Omit needless casts.
1746 * alloc.c (xzalloc): New function. Omit needless casts.
1747 * charset.c: Omit needless casts. Convert all calls to
1748 xmalloc with following memset to xzalloc.
1749 * dispnew.c: Likewise.
1750 * fringe.c: Likewise.
1751 * image.c: Likewise.
1752 * sound.c: Likewise.
1753 * term.c: Likewise.
1754 * w32fns.c: Likewise.
1755 * w32font.c: Likewise.
1756 * w32term.c: Likewise.
1757 * xfaces.c: Likewise.
1758 * xfns.c: Likewise.
1759 * xterm.c: Likewise.
1760 * atimer.c: Omit needless casts.
1761 * buffer.c: Likewise.
1762 * callproc.c: Likewise.
1763 * ccl.c: Likewise.
1764 * coding.c: Likewise.
1765 * composite.c: Likewise.
1766 * doc.c: Likewise.
1767 * doprnt.c: Likewise.
1768 * editfns.c: Likewise.
1769 * emacs.c: Likewise.
1770 * eval.c: Likewise.
1771 * filelock.c: Likewise.
1772 * fns.c: Likewise.
1773 * gtkutil.c: Likewise.
1774 * keyboard.c: Likewise.
1775 * lisp.h: Likewise.
1776 * lread.c: Likewise.
1777 * minibuf.c: Likewise.
1778 * msdos.c: Likewise.
1779 * print.c: Likewise.
1780 * process.c: Likewise.
1781 * region-cache.c: Likewise.
1782 * search.c: Likewise.
1783 * sysdep.c: Likewise.
1784 * termcap.c: Likewise.
1785 * terminal.c: Likewise.
1786 * tparam.c: Likewise.
1787 * w16select.c: Likewise.
1788 * w32.c: Likewise.
1789 * w32reg.c: Likewise.
1790 * w32select.c: Likewise.
1791 * w32uniscribe.c: Likewise.
1792 * widget.c: Likewise.
1793 * xdisp.c: Likewise.
1794 * xmenu.c: Likewise.
1795 * xrdb.c: Likewise.
1796 * xselect.c: Likewise.
1797
0497dc44
PE
17982012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1799
1800 * fileio.c (time_error_value): Check the right error number.
1801 Problem reported by Troels Nielsen in
1802 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1803
356e7178
PE
18042012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1805
4e71fd89
PE
1806 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1807 This should be fixed in a better way; see Eli Zaretskii in
1808 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1809 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1810
f0941253
PE
1811 * fileio.c (time_error_value): Rename from special_mtime.
1812 The old name's problems were noted by Eli Zaretskii in
1813 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1814
065c9eb4
PE
1815 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1816 This variable's comment says Emacs needs at least one GDB-visible
1817 symbol of type enum pvec_type, to work around GDB problems.
1818 The symbol's value doesn't matter.
1819
356e7178
PE
1820 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1821 that causes compilation to fail on pre-C99 compilers.
1822
ed9265fc 18232012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1824
1825 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1826 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1827
3884d954
DA
18282012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1829
d209e2fb 1830 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1831 headers for buffer_defaults and buffer_local_symbols.
1832 Reported by Juanma Barranquero <lekktu@gmail.com>.
1833
ee28be33
SM
18342012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1835
1836 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1837 * lisp.h (enum pvec_type): Use fewer bits.
1838 (PSEUDOVECTOR_SIZE_BITS): New constant.
1839 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1840 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1841 change in pvec_type.
1842 (PSEUDOVECTOR_TYPEP): New macro.
1843 (TYPED_PSEUDOVECTORP): Use it.
1844 * fns.c (internal_equal): Adapt code to extract pvectype.
1845 * emacs.c (gdb_pvec_type): Update type.
1846 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1847 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1848 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1849 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1850 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1851 abusing vector->header.next.nbytes.
1852 (live_vector_p): Use PVEC_TYPE.
1853 (mark_object): Adapt code to extract pvectype. Use switch.
1854
c7f2cd7f
PE
18552012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1856
1857 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1858 Tighten new eassert a bit.
1859
8ce70ed2
DA
18602012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1861
1862 Fix compilation with --enable-gcc-warnings and -O1
1863 optimization level.
1864 * doprnt.c (doprnt): Change type of tem to int, initialize
1865 to avoid compiler warning. Add eassert.
1866 * search.c (simple_search): Initialize match_byte to avoid
1867 compiler warning. Add eassert.
1868
dea7f1e5
PE
18692012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1870
24a212eb
PE
1871 Avoid weird behavior with large horizontal scrolls.
1872 Without this change, for example, large hscroll values would
1873 mess up Emacs's display on Fedora 15 x86, presumably due to
1874 overflows in int calculations in the display code.
1875 Also, if buffers had long lines, Emacs would freeze.
1876 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1877 (set_window_hscroll): New function, containing the old guts of
1878 Fset_window_hscroll. Return the clipped value.
1879 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1880 This avoids the need to check against PTRDIFF_MAX.
1881
dea7f1e5
PE
1882 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1883
76046526
DA
18842012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1885
1886 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1887
39adff0d
PE
18882012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1889
63807d47
PE
1890 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1891 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1892 since GCC 4.4.6 issues a bogus warning for them.
1893
39adff0d
PE
1894 Fix bugs in file timestamp newness comparisons.
1895 * fileio.c (Ffile_newer_than_file_p):
1896 * lread.c (Fload): Use full timestamp resolution of files,
1897 not just the 1-second resolution, so that files that are only
1898 slightly newer still count as newer.
1899 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1900 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1901
dbeed9a6
PE
19022012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1903
1904 * fileio.c: Improve handling of file time marker. (Bug#11852)
1905 (special_mtime): New function.
1906 (Finsert_file_contents, Fverify_visited_file_modtime):
1907 Use it to set special mtime values consistently.
1908
636334d6
AS
19092012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1910
1911 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1912 marker for non-existing file. (Bug#11852)
1913
e2017fe2
GM
19142012-07-03 Glenn Morris <rgm@gnu.org>
1915
1916 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1917 and did not make it into globals.h).
1918
404dbd37
TT
19192012-07-03 Tom Tromey <tromey@redhat.com>
1920
1921 * window.c (Fset_window_margins, Fset_window_fringes)
1922 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1923 * textprop.c (Fprevious_property_change): No longer static.
1924 * syntax.c (Fsyntax_table_p): No longer static.
1925 * process.c (Fget_process, Fprocess_datagram_address): No longer
1926 static.
1927 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1928 * keyboard.c (Fcommand_execute): No longer static.
1929 Remove EXFUN.
1930 * insdel.c (Fcombine_after_change_execute): No longer static.
1931 * image.c (Finit_image_library): No longer static.
1932 * fileio.c (Fmake_symbolic_link): No longer static.
1933 * eval.c (Ffetch_bytecode): No longer static.
1934 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1935 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1936 No longer static.
404dbd37
TT
1937 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1938 static.
1939 * dired.c (Ffile_attributes): No longer static.
1940 * composite.c (Fcomposition_get_gstring): No longer static.
1941 * callproc.c (Fgetenv_internal): No longer static.
1942
1943 * ccl.h: Remove EXFUNs.
1944 * buffer.h: Remove EXFUNs.
1945 * dispextern.h: Remove EXFUNs.
1946 * intervals.h: Remove EXFUNs.
1947 * fontset.h: Remove EXFUN.
1948 * font.h: Remove EXFUNs.
1949 * dosfns.c (system_process_attributes): Remove EXFUN.
1950 * keymap.h: Remove EXFUNs.
1951 * lisp.h: Remove EXFUNs.
1952 * w32term.h: Remove EXFUNs.
1953 * window.h: Remove EXFUNs.
1954 * xsettings.h: Remove EXFUN.
1955 * xterm.h: Remove EXFUN.
1956
8e4fd1e1
GM
19572012-07-03 Glenn Morris <rgm@gnu.org>
1958
1959 * lisp.h (Frandom): Make it visible to C.
1960 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1961 buffer for invisible buffers. (Bug#1229)
1962
ca95b3eb
DA
19632012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1964
1965 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1966 values which aren't power of 2.
1967 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1968 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1969 accordingly.
1970
7555c33f
SM
19712012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1972
1973 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1974
1975 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1976
d12e8f5a
DA
19772012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1978
1979 * alloc.c (allocate_vector_block): Remove redundant
1980 calls to mallopt if DOUG_LEA_MALLOC is defined.
1981 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1982 avoid calls to mallopt if zero_vector is returned.
1983
296094c3
DA
19842012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1985
1986 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1987 is enabled, avoid dereferencing NULL current_sblock if
1988 running undumped.
1989
36429c89
DA
19902012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1991
1992 Cleanup basic buffer management.
1993 * buffer.h (struct buffer): Change layout to use generic vector
1994 marking code. Fix some comments. Change type of 'clip_changed'
1995 to bitfield. Remove unused #ifndef old.
1996 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1997 (GET_OVERLAYS_AT): Fix indentation.
1998 (for_each_per_buffer_object_at): New macro.
1999 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2000 (Fbuffer_local_variables): Use it.
2001 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2002 * alloc.c (allocate_buffer): Adjust to match new layout of
2003 struct buffer. Fix comment.
2004 (mark_overlay): New function.
2005 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2006 Lisp area of struct buffer.
2007 (mark_object): Use it. Adjust marking of misc objects
2008 and related comments.
2009
3b3e4cac
PE
20102012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2011
2012 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2013 wrapper that is not needed because the wrapped code is a no-op (zero
2014 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2015 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2016
cf5c0175
DA
20172012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2018
2019 * alloc.c (mark_buffer): Simplify. Remove prototype.
2020 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2021 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2022 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2023 redundant calls to mark_vectorlike for bool vectors.
2024
ca26824c
GM
20252012-06-30 Glenn Morris <rgm@gnu.org>
2026
2e4c5312
GM
2027 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2028
ca26824c
GM
2029 * epaths.in (PATH_SITELOADSEARCH): New.
2030 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2031 This is rather than relying on --enable-locallisppath elements
2032 having "site-lisp" in their names. (Bug#10208#25, 11658)
2033
0d23c240
EZ
20342012-06-30 Eli Zaretskii <eliz@gnu.org>
2035
c9240d7a
EZ
2036 * w32proc.c (sys_select): Accept and ignore one more argument.
2037
2038 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2039
0d23c240 2040 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2041 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2042
2043 * sysdep.c: Don't include dos.h and dosfns.h.
2044
2045 * process.c (sys_select):
2046 * msdos.c (sys_select): Accept one more argument and ignore it.
2047
2048 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2049 adapt data types and code to that.
2050
2051 * dosfns.c:
2052 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2053 which clashes with the gnulib function of the same name.
2054
af5a5a98
AS
20552012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2056
c5e4379c
AS
2057 * font.c (font_style_to_value, font_style_symbolic)
2058 (font_prop_validate_style): Add type checks for values in
2059 font_style_table.
2060
af5a5a98
AS
2061 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2062 argument.
2063 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2064 uses.
2065
8d38f461
EZ
20662012-06-29 Eli Zaretskii <eliz@gnu.org>
2067
2e5a6631
EZ
2068 * xdisp.c (try_window_id): Undo last change.
2069
8d38f461
EZ
2070 * w32.c (getwd): Adjust commentary about startup_dir.
2071 (init_environment): Always call sys_access, even in non-MSVC
2072 builds. Don't chdir to the directory of the Emacs executable.
2073 This undoes code from 1997 which was justified by the need to
2074 "avoid conflicts when removing and renaming directories". But its
2075 downside was that every relative file name was being interpreted
2076 relative to the directory of the Emacs executable, which can never
2077 be TRT. In particular, it broke sys_access when called with
2078 relative file names.
2079 (sys_access): Map GetLastError to errno.
2080
2af3565e
DA
20812012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2082
2083 * window.h (struct window): Change type of 'fringes_outside_margins'
2084 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2085 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2086 Adjust comment.
2087 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2088 to ptrdiff_t.
2089
c8d3a25c 20902012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2091
c8d3a25c
GM
2092 * gnutls.c (emacs_gnutls_handshake):
2093 Add QUIT to make the loop interruptible.
57570cd3 2094
c8d3a25c 20952012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2096
c8d3a25c
GM
2097 * charset.c (init_charset): Make lack of etc/charsets fatal.
2098
3e984ee8
DA
20992012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2100
2101 * editfns.c (region_limit): Fix type mismatch.
2102
ef884f23
DA
21032012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2104
2105 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2106 undefined. Convert from xassert to eassert.
2107 * nsmenu.m: Convert from xassert to eassert.
2108 * nsterm.m: Likewise.
2109
7d7e0027
SM
21102012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2111
2112 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2113
aa754e6a
PE
21142012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2115
2116 Avoid integer overflow on scroll-left and scroll-right.
2117 * window.c (HSCROLL_MAX): New macro.
2118 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2119 overflow when requested scroll falls outside ptrdiff_t range.
2120
80b00b08
DA
21212012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2122
2123 * window.h (struct window): Change type of 'hscroll',
2124 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2125 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2126 Adjust users accordingly.
2127 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2128 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2129 from EMACS_INT to ptrdiff_t.
2130 (make_window): Omit redundant initialization.
2131
62b2bcf6
JB
21322012-06-28 Juanma Barranquero <lekktu@gmail.com>
2133
2134 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2135
45942c7d
DA
21362012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2137
2138 * window.h (struct window): Change type of 'use_time' and
2139 'sequence_number' from Lisp_Object to int.
2140 * frame.c (make_frame): Adjust users accordingly.
2141 * print.c (print_object): Likewise.
2142 * window.c (select_window, Fwindow_use_time, make_parent_window)
2143 (make_window): Likewise.
2144
e509cfa6
DA
21452012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2146
2147 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2148 enabled with --enable-checking=[all,glyphs] configure option.
2149 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2150 adjust comments accordingly.
2151 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2152 undefined, adjust comments accordingly.
2153 * image.c: Likewise.
2154 * scroll.c: Likewise.
2155 * w32fns.c: Likewise.
2156 * w32term.c: Likewise.
2157 * xdisp.c: Likewise.
2158 * xfaces.c: Likewise.
2159 * xfns.c: Likewise.
2160 * xterm.c: Likewise.
2161
a54e2c05
DA
21622012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2163
2164 Generalize run-time debugging checks.
2165 * dispextern.h (XASSERTS): Remove.
2166 * fontset.c (xassert): Remove.
2167 Convert from xassert to eassert.
2168 * alloc.c: Convert from xassert to eassert.
2169 * bidi.c: Likewise.
2170 * dispnew.c: Likewise.
2171 * fns.c: Likewise.
2172 * fringe.c: Likewise.
2173 * ftfont.c: Likewise.
2174 * gtkutil.c: Likewise.
2175 * image.c: Likewise.
2176 * keyboard.c: Likewise.
2177 * menu.c: Likewise.
2178 * process.c: Likewise.
2179 * scroll.c: Likewise.
2180 * sound.c: Likewise.
2181 * term.c: Likewise.
2182 * w32console.c: Likewise.
2183 * w32fns.c: Likewise.
2184 * w32term.c: Likewise.
2185 * window.c: Likewise.
2186 * xdisp.c: Likewise.
2187 * xfaces.c: Likewise.
2188 * xfns.c: Likewise.
2189 * xselect.c: Likewise.
2190 * xterm.c: Likewise.
2191
1ec4b7b2
SM
21922012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2193
2194 * fns.c (maybe_resize_hash_table): Output message when growing the
2195 purify-hashtable.
2196
2014308a
DA
21972012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2198
2199 * alloc.c (allocate_string_data): Remove dead code.
2200 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2201 avoid GCC warning about unused macro.
2202
246155eb
DA
22032012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2204
2205 * alloc.c (allocate_string): Omit intervals initialization.
2206 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2207 as in make_pure_string and make_pure_c_string.
2208
43184b7b
DA
22092012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2210
d209e2fb 2211 * alloc.c (allocate_string): Fix last change.
43184b7b 2212
3fe6dd74
DA
22132012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2214
d209e2fb 2215 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2216 to memset, add explicit initialization where appropriate.
2217
1ba6038a
GM
22182012-06-27 Glenn Morris <rgm@gnu.org>
2219
2220 * lisp.mk (lisp): Remove paths.elc.
2221
c89926a5
CY
22222012-06-27 Chong Yidong <cyd@gnu.org>
2223
2224 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2225
ed6b3510
JW
22262012-06-26 John Wiegley <johnw@newartisans.com>
2227
1ec4b7b2 2228 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2229 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2230
ed6b3510
JW
2231 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2232 when building with Clang.
2233
8edd4a2b
SM
22342012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2235
2236 * eval.c (Fapply): Allow calling it with a single argument.
2237
f6f62d1b
EZ
22382012-06-26 Eli Zaretskii <eliz@gnu.org>
2239
2240 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2241 _stricmp and _strnicmp.
2242 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2243
62efea5e
DA
22442012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2245
2246 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2247 allocated window.
2248 (allocate_process): Likewise for new process.
8edd4a2b 2249 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2250 (allocate_frame): Likewise.
2251 * frame.c (make_frame): Omit redundant initialization.
2252 * window.c (make_parent_window): Use memset.
2253 (make_window): Omit redundant initialization.
2254 * process.c (make_process): Omit redundant initialization.
2255 * terminal.c (create_terminal): Likewise.
2256
42997f4d
DA
22572012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2258
2259 * term.c (delete_tty): Remove redundant call to memset.
2260
1130ecfc
DA
22612012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2262
2263 * alloc.c: Remove build_string.
2264 * lisp.h: Define build_string as static inline. This provides
2265 a better opportunity to optimize away calls to strlen when the
2266 function is called with compile-time constant argument.
2267 * image.c (imagemagick_error): Convert to build_string.
2268 * w32proc.c (sys_spawnve): Likewise.
2269 * xterm.c (x_term_init): Likewise.
2270
cf38a720
PE
22712012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2272
99027bdd
PE
2273 Use sprintf return value instead of invoking strlen on result.
2274 In the old days this wasn't portable, since some sprintf
2275 implementations returned char *. But they died out years ago and
2276 Emacs already assumes sprintf returns int.
2277 Similarly for float_to_string.
2278 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2279 * ccl.c (ccl_driver):
2280 * character.c (string_escape_byte8):
2281 * data.c (Fnumber_to_string):
2282 * doprnt.c (doprnt):
2283 * print.c (print_object):
2284 * xdisp.c (message_dolog):
2285 * xfns.c (syms_of_xfns):
2286 Use sprintf or float_to_string result to avoid need to call strlen.
2287 * data.c (Fnumber_to_string):
2288 Use make_unibyte_string, since the string must be ASCII.
2289 * lisp.h, print.c (float_to_string): Now returns int length.
2290 * term.c (produce_glyphless_glyph):
2291 Use sprintf result rather than recomputing it.
2292
cf38a720
PE
2293 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2294 * Makefile.in (ALL_CFLAGS):
2295 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2296 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2297
3511c784
DA
22982012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2299
0a08eb21 2300 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2301 strcasecmp if available.
2302 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2303
fb7da12e
AS
23042012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2305
2306 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2307 Avoid comma operator.
2308 * menu.c (push_submenu_start, push_submenu_end)
2309 (push_left_right_boundary, push_menu_pane): Likewise.
2310 * msdos.c (dos_rawgetc): Likewise.
2311
afa2ffd8
DA
23122012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2313
2314 * xfns.c (xic_create_fontsetname): Remove redundant calls
2315 to memset.
2316
b3b4476b
PE
23172012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2318
4495ff38
PE
2319 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2320 sprintf already null-terminates its output.
2321
b3b4476b
PE
2322 * xfns.c (x_window): Remove redundant cast.
2323
b00876c9
DA
23242012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2325
2326 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2327 `const char *' to `char *' to avoid compiler warning.
2328
d188e26b
PE
23292012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2330
885d1d74
PE
2331 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2332 instead of truncating it to 63 (admittedly a generous limit).
2333
d188e26b
PE
2334 * process.c: Fix spelling and caps in comments.
2335
e2f560b1
DN
23362012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2337
e86db54b 2338 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2339 * sysdep.c (setpgrp): Remove definition, not used in this file.
2340
7583a3a1
JB
23412012-06-24 Juanma Barranquero <lekktu@gmail.com>
2342
2343 * makefile.w32-in: Update dependencies.
2344
696056c2
EZ
23452012-06-24 Eli Zaretskii <eliz@gnu.org>
2346
2347 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2348 (SYSTIME_H): Add nt/inc/sys/time.h.
2349
2350 * systime.h [WINDOWSNT]: Include sys/time.h.
2351
2352 * s/ms-w32.h (struct timespec): Definition moved from
2353 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2354
845ca893
PE
23552012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2356
2357 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2358 * buffer.h (buffer_slot_type_mismatch):
2359 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2360 * eval.c (unwind_to_catch):
2361 * image.c (my_png_error, my_error_exit):
2362 * keyboard.c (quit_throw_to_read_char, user_error)
2363 (Fexit_recursive_edit, Fabort_recursive_edit):
2364 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2365 (wrong_type_argument, buffer_overflow, __executable_start)
2366 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2367 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2368 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2369 (fatal):
2370 (child_setup) [!DOS_NT]:
2371 * lread.c (end_of_file_error, invalid_syntax):
2372 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2373 * puresize.h (pure_write_error):
2374 * search.c (matcher_overflow):
2375 * sound.c (sound_perror, alsa_sound_perror):
2376 * sysdep.c, syssignal.h (croak):
2377 * term.c (maybe_fatal, vfatal):
2378 * textprop.c (text_read_only):
2379 * undo.c (user_error):
2380 * unexmacosx.c (unexec_error):
2381 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2382 Use _Noreturn rather than NO_RETURN.
2383 No need for separate decl merely because of _Noreturn.
2384 * sound.c (sound_warning, parse_sound):
2385 Remove unnecessary forward decls.
2386
f1dd8073
PE
23872012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2388
2389 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2390 * lisp.h (WAIT_READING_MAX): New macro.
2391 * dispnew.c (Fsleep_for, sit_for):
2392 * keyboard.c (kbd_buffer_get_event):
2393 * process.c (Faccept_process_output):
2394 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2395 This improves on the previous patch, which introduced a bug
2396 when time_t is unsigned and as wide as intmax_t.
2397 See <http://bugs.gnu.org/9000#51>.
2398
b82c1755
EZ
23992012-06-23 Eli Zaretskii <eliz@gnu.org>
2400
2401 * dispnew.c (sit_for, Fsleep_for):
2402 * keyboard.c (kbd_buffer_get_event):
2403 * process.c (Faccept_process_output): Avoid compiler warnings when
2404 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2405
ca300656
JB
24062012-06-23 Juanma Barranquero <lekktu@gmail.com>
2407
049ec95b
JB
2408 * makefile.w32-in: Update dependencies.
2409
ca300656
JB
2410 * w32.c (ltime): Add return type and declare static.
2411 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2412
db7b8d06
PE
24132012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2414
2415 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2416 Privately reported by Herbert J. Skuhra.
2417 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2418 All uses changed.
2419 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2420 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2421
0bd8297f
EZ
24222012-06-23 Eli Zaretskii <eliz@gnu.org>
2423
96512555
EZ
2424 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2425 last argument of make_unibyte_string.
2426
0bd8297f
EZ
2427 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2428 language ID in the event parameters.
2429
2430 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2431 event.code, not the obscure "character set ID".
2432
63def6b6
CY
24332012-06-23 Chong Yidong <cyd@gnu.org>
2434
2435 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2436
e8a02204
EZ
24372012-06-23 Eli Zaretskii <eliz@gnu.org>
2438
388cdec0
EZ
2439 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2440 * w32.c (fdutimens): New function.
2441
2442 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2443
2444 * s/ms-w32.h (pselect): Redirect to sys_select.
2445
2446 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2447
e8a02204
EZ
2448 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2449 in the logic of incrementing and decrementing the value of
2450 use_relocatable_buffers.
2451
d054f3fb
PE
24522012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2453
2454 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2455 Privately reported by Herbert J. Skuhra.
2456 [__FreeBSD__]: Remove "*/" typo after "#include".
2457 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2458 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2459 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2460 Don't assume EMACS_TIME and struct timeval are the same type.
2461
d35af63c
PE
24622012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2463
2464 Support higher-resolution time stamps (Bug#9000).
2465 The time stamps are only nanosecond-resolution at the C level,
2466 since that's the best that any real-world system supports now.
2467 But they are picosecond-resolution at the Lisp level, as that's
2468 easy, and leaves room for future OS improvements.
2469
2470 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2471 (LIBES): Use it.
2472
2473 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2474 Don't get current time unless it's needed.
2475
2476 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2477 now provides it if it's absent.
2478 (start_atimer): Port to higher-res time stamps.
2479 Check for time stamp overflow. Don't get current time more
2480 often than is needed.
2481
2482 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2483 Include systime.h, not time.h.
2484 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2485
2486 * dired.c: Include stat-time.h.
2487 (Ffile-attributes): File times now have higher resolution.
2488
2489 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2490 (struct image): Timestamp now has higher resolution.
2491
2492 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2493 has at least microseconds now. All uses removed.
2494 (update_frame, update_single_window, update_window, update_frame_1)
2495 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2496
2497 * editfns.c (time_overflow): Now extern.
2498 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2499 (float-time, Fformat_time_string, Fcurrent_time_string)
2500 (Fcurrent_time_zone): Accept and generate higher-resolution
2501 time stamps.
2502 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2503 (decode_time_components, lisp_seconds_argument): New functions.
2504 (make_time): Now static.
2505 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2506 Report an error if the time is invalid, rather than having the caller
2507 do that.
2508
2509 * fileio.c: Include <stat-time.h>
2510 (Fcopy_file): Copy higher-resolution time stamps.
2511 Prefer to set the time stamp via a file descriptor if that works.
2512 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2513 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2514 (Fvisited_file_modtime, Fset_visited_file_modtime):
2515 Support higher-resolution time stamps.
2516
2517 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2518
2519 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2520
2521 * image.c (prepare_image_for_display, clear_image_cache)
2522 (lookup_image): Port to higer-resolution time stamps.
2523
2524 * keyboard.c (start_polling, bind_polling_period):
2525 Check for time stamp overflow.
2526 (read_char, kbd_buffer_get_event, timer_start_idle)
2527 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2528 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2529 Port to higher-resolution time stamps. Do not assume time_t is signed.
2530 (decode_timer): New function. Timers are now vectors of length 9,
2531 not 8, to accommodate the picosecond component.
2532 (timer_check_2): Use it.
2533
2534 * nsterm.m (select_timeout, timeval_subtract): Remove.
2535 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2536 as they're a bit more accurate and handle overflow better.
2537 (ns_select): Change prototype to be compatible with pselect.
2538 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2539 * nsterm.h (ns_select): Adjust prototype.
2540
2541 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2542 us-resolution time stamps.
2543 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2544
2545 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2546
2547 * lisp.h (time_overflow): New decl.
2548 (wait_reading_process_output): First arg is now intmax_t, not int,
2549 to accommodate larger waits.
2550
2551 * process.h (struct Lisp_Process.read_output_delay):
2552 Now counts nanoseconds, not microseconds.
2553 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2554 EMACS_HAS_USECS.
2555 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2556 (wait_reading_process_output):
2557 Port to ns-resolution time stamps.
2558 (Faccept_process_output, wait_reading_process_output):
2559 Check for time stamp overflow. Do not assume time_t is signed.
2560 (select_wrapper): Remove; we now use pselect.
2561 (Fprocess_attributes): Now generates ns-resolution time stamps.
2562
2563 * sysdep.c: Include utimens.h. Don't include utime.h
2564 or worry about struct utimbuf; gnulib does that for us now.
2565 (gettimeofday): Remove; gnulib provides a substitute.
2566 (make_timeval): New function.
2567 (set_file_times): Now sets ns-resolution time stamps.
2568 New arg FD; all uses changed.
2569 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2570 (system_process_attributes):
2571 Now returns ns-resolution time stamp. All uses changed.
2572 Check for time stamp overflow.
2573
2574 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2575 provides a substitute now.
2576
2577 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2578 since it guarantees struct timespec.
2579 (EMACS_TIME): Now struct timespec, so that we can support
2580 ns-resolution time stamps.
2581 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2582 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2583 (EMACS_USECS): Remove.
2584 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2585 so multiply the arg by 1000 before storing it.
2586 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2587 New macros.
2588 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2589 Port to ns-resolution time stamps.
2590 (EMACS_TIME_NEG_P): Remove; replaced by....
2591 (EMACS_TIME_SIGN): New macro.
2592 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2593 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2594 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2595 (make_timeval, make_lisp_time, decode_time_components): New decls.
2596 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2597 that it mishandled time_t overflow. You can't compare by subtracting!
2598 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2599 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2600
2601 * term.c: Include <sys/time.h>.
2602 (timeval_to_Time): New function, for proper overflow wraparound.
2603 (term_mouse_position, term_mouse_click): Use it.
2604
2605 * undo.c (record_first_change): Support higher-resolution time stamps
2606 in the undo buffer.
2607 (Fprimitive_undo): Use them when restoring time stamps.
2608
2609 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2610 (w32_get_internal_run_time):
2611 Port to higher-resolution Emacs time stamps.
2612 (ltime): Now accepts single 64-bit integer, as that's more convenient
2613 for callers.
2614
2615 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2616
2617 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2618 for compatibility with pselect. Support ns-resolution time stamps.
2619
2620 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2621
2622 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2623 Check for time stamp overflow, and support ns-resolution time stamps.
2624
2625 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2626 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2627 (timeval_subtract): Remove; no longer needed.
2628 (XTflash, XTring_bell, x_wait_for_event):
2629 Port to ns-resolution time stamps. Don't assume time_t is signed.
2630
b6a92dfe
CY
26312012-06-22 Chong Yidong <cyd@gnu.org>
2632
2633 * xdisp.c (x_consider_frame_title): Revert last change.
2634
d251c37c
EZ
26352012-06-22 Eli Zaretskii <eliz@gnu.org>
2636
2637 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2638 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2639 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2640 staticidx goes up to 1597 out of 1600 = 0x640.)
2641
f10deafb
PE
26422012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2643
2644 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2645 Otherwise, the umask might be mistakenly 0 while handling input signals.
2646
ec6de1e2
SM
26472012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2648
2649 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2650
28be1ada
DA
26512012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2652
2653 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2654 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2655 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2656 access to `contents' member of Lisp_Vector objects with AREF and ASET
2657 where appropriate.
2658
c6bf3022
CY
26592012-06-19 Chong Yidong <cyd@gnu.org>
2660
2661 * frame.c (delete_frame): When selecting a frame on a different
2662 text terminal, do not alter the terminal's top-frame.
2663
2664 * xdisp.c (format_mode_line_unwind_data): Record the target
2665 frame's selected window and its terminal's top-frame.
2666 (unwind_format_mode_line): Restore them.
2667 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2668 Callers changed.
2669 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2670 since tty frames can be explicitly named.
2671 (prepare_menu_bars): Likewise.
2672
2673 * term.c (Ftty_top_frame): New function.
2674
defd4196
PE
26752012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2676
2677 Port byte-code-meter to modern targets.
2678 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2679 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2680 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2681 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2682 (METER_1, METER_2): Simplify.
2683
1053a871
SM
26842012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2685
2686 * data.c (Fdefalias): Return `symbol' (bug#11686).
2687
b7e8d081
MR
26882012-06-18 Martin Rudalics <rudalics@gmx.at>
2689
2690 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2691 gets killed during executing of this function (Bug#11665).
2692 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2693 (Vkill_buffer_query_functions): In doc-string say that functions
2694 run by this hook should not change the current buffer.
2695
7ea2b339
PE
26962012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2697
2698 Fix recently-introduced process.c problems found by static checking.
2699 * process.c (write_queue_push, write_queue_pop, send_process):
2700 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2701 (write_queue_pop): Fix pointer signedness problem.
2702 (send_process): Remove unused local.
2703
96a313a1
CY
27042012-06-17 Chong Yidong <cyd@gnu.org>
2705
2706 * xdisp.c (redisplay_internal): No need to redisplay terminal
2707 frames that are not on top.
2708
20ca2e94
TN
27092012-06-17 Troels Nielsen <bn.troels@gmail.com>
2710
2711 * process.c (make_process): Initialize write_queue.
2712 (write_queue_push, write_queue_pop): New functions.
2713 (send_process): Use them to maintain correct ordering of process
2714 writes (Bug#10815).
2715
9a900ca9
PE
27162012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2717
310fbfa8
PE
2718 * lisp.h (eassert): Assume C89 or later.
2719 This removes the need for CHECK.
2720 (CHECK): Remove. Its comments about always evaluating its
2721 argument were confusing, as 'eassert' typically does not evaluate
2722 its argument.
2723
27bb1ca4
PE
2724 * coding.c (produce_chars): Use ptrdiff_t, not int.
2725
9a900ca9
PE
2726 * xterm.c (x_draw_underwave): Check for integer overflow.
2727 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2728
41b7f8bc 27292012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2730
2731 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2732 referenced (Bug#11583).
2733
9b0e3eba
AA
27342012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2735
2736 Implement wave-style variant of underlining.
2737 * dispextern.h (face_underline_type): New enum.
2738 (face): Add field for underline type.
2739 * nsterm.m (ns_draw_underwave): New function.
2740 (ns_draw_text_decoration): Use it.
2741 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2742 New functions.
2743 (x_draw_glyph_string): Use them.
2744 * xfaces.c (Qline, Qwave): New Lisp objects.
2745 (check_lface_attrs, merge_face_ref)
1053a871
SM
2746 (Finternal_set_lisp_face_attribute, realize_x_face):
2747 Handle wave-style underline face attributes.
9b0e3eba
AA
2748 * xterm.c (x_draw_underwave): New function.
2749 (x_draw_glyph_string): Use it.
2750
0fb52f11
JB
27512012-06-16 Juanma Barranquero <lekktu@gmail.com>
2752
2753 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2754 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2755 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2756 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2757 ($(BLD)/w32select.$(O)): Update dependencies.
2758
e5560ff7
AS
27592012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2760
2761 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2762 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2763 * character.c (_fetch_multibyte_char_p): Remove.
2764 * alloc.c: Include "character.h" before "buffer.h".
2765 * bidi.c: Likewise.
2766 * buffer.c: Likewise.
2767 * bytecode.c: Likewise.
2768 * callint.c: Likewise.
2769 * callproc.c: Likewise.
2770 * casefiddle.c: Likewise.
2771 * casetab.c: Likewise.
2772 * category.c: Likewise.
2773 * cmds.c: Likewise.
2774 * coding.c: Likewise.
2775 * composite.c: Likewise.
2776 * dired.c: Likewise.
2777 * dispnew.c: Likewise.
2778 * doc.c: Likewise.
2779 * dosfns.c: Likewise.
2780 * editfns.c: Likewise.
2781 * emacs.c: Likewise.
2782 * fileio.c: Likewise.
2783 * filelock.c: Likewise.
2784 * font.c: Likewise.
2785 * fontset.c: Likewise.
2786 * fringe.c: Likewise.
2787 * indent.c: Likewise.
2788 * insdel.c: Likewise.
2789 * intervals.c: Likewise.
2790 * keyboard.c: Likewise.
2791 * keymap.c: Likewise.
2792 * lread.c: Likewise.
2793 * macros.c: Likewise.
2794 * marker.c: Likewise.
2795 * minibuf.c: Likewise.
2796 * nsfns.m: Likewise.
2797 * nsmenu.m: Likewise.
2798 * print.c: Likewise.
2799 * process.c: Likewise.
2800 * regex.c: Likewise.
2801 * region-cache.c: Likewise.
2802 * search.c: Likewise.
2803 * syntax.c: Likewise.
2804 * term.c: Likewise.
2805 * textprop.c: Likewise.
2806 * undo.c: Likewise.
2807 * unexsol.c: Likewise.
2808 * w16select.c: Likewise.
2809 * w32fns.c: Likewise.
2810 * w32menu.c: Likewise.
2811 * window.c: Likewise.
2812 * xdisp.c: Likewise.
2813 * xfns.c: Likewise.
2814 * xmenu.c: Likewise.
2815 * xml.c: Likewise.
2816 * xselect.c: Likewise.
2817
2f07e6af
EZ
28182012-06-16 Eli Zaretskii <eliz@gnu.org>
2819
1053a871
SM
2820 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2821 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2822 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2823 row.
2824 (handle_face_prop): Use chunk-relative overlay string index when
2825 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2826 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2827 the rightmost. (Bug#11720)
2f07e6af 2828
29b83cec
AS
28292012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2830
2831 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2832 (CATEGORY_MEMBER): Enforce 1/0 value.
2833 * category.c (_temp_category_set): Remove.
2834
4c5501e9
EZ
28352012-06-16 Eli Zaretskii <eliz@gnu.org>
2836
2837 * window.c (Fdelete_other_windows_internal)
2838 (Fdelete_window_internal): Don't access frame's mouse highlight
2839 info of the initial frame. (Bug#11677)
2840
2b570124
PE
28412012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2842
e93864f9
PE
2843 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2844 Assume USE_2_TAGS_FOR_INTS.
2845 (xreload): Adjust $tagmask width to match recent lisp.h change.
2846
2b570124
PE
2847 Simplify lisp.h in minor ways that should not affect code.
2848 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2849 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2850 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2851 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2852 (INTTYPEBITS): New macro, for clarity.
2853 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2854 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2855 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2856 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2857 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2858
81755f69
JB
28592012-06-13 Juanma Barranquero <lekktu@gmail.com>
2860
2861 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2862
16192a57
GM
28632012-06-13 Glenn Morris <rgm@gnu.org>
2864
2865 * s/bsd-common.h (BSD4_3):
2866 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2867
646b5f55
AS
28682012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2869
2870 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2871 instead of union.
2872 (XLI, XIL): Define.
1053a871
SM
2873 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2874 Use them.
2875 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2876 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2877 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2878 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2879 * frame.c (delete_frame): Remove outdated comment.
2880 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2881 USE_LISP_UNION_TYPE.
2882 (Fw32_unregister_hot_key): Likewise.
2883 (Fw32_toggle_lock_key): Likewise.
2884 * w32menu.c (add_menu_item): Likewise.
2885 (w32_menu_display_help): Use XIL instead of checking
2886 USE_LISP_UNION_TYPE.
2887 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2888 (init_heap): Likewise.
2889 * w32term.c (w32_read_socket): Update comment.
2890
1d3823c9
GM
28912012-06-13 Glenn Morris <rgm@gnu.org>
2892
c62ff706
GM
2893 * s/usg5-4-common.h, src/s/unixware.h:
2894 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2895
1d3823c9
GM
2896 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2897
bfe3e0a2
PE
28982012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2899
2900 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2901 * alloc.c (make_number) [!defined make_number]:
2902 Remove, as lisp.h always defines this now.
2903 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2904 (roundup_size): Verify that it is a power of 2.
2905 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2906 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2907 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2908 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2909 USE_LSB_TAG now is always defined to be either 0 or 1.
2910 All uses changed.
2911 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2912 code works fine either way, and efficiency is not a concern here,
2913 as the union type is for debugging, not for production.
2914 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2915 Use an inline function on all platforms when using the union type,
2916 since this is simpler and 'static inline' can be used portably
2917 within Emacs now.
2918 (LISP_INITIALLY_ZERO): New macro.
2919 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2920 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2921
45fa9c0f
GM
29222012-06-12 Glenn Morris <rgm@gnu.org>
2923
b4492cba
GM
2924 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2925
2926 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2927
45fa9c0f
GM
2928 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2929 Move BROKEN_SIGIO to configure.
2930
2931 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2932 Move NO_TERMIO to configure.
2933
0e25d334
CY
29342012-06-12 Chong Yidong <cyd@gnu.org>
2935
2936 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2937 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2938 MagickExportImagePixels is undefined.
2939
43682bb6
PE
29402012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2941
2942 * image.c (imagemagick_load_image): Remove unused label.
2943
a9be7d2b
GM
29442012-06-11 Glenn Morris <rgm@gnu.org>
2945
2946 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2947 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2948 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2949 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2950
3017f87f
SM
29512012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2952
2953 * alloc.c (make_byte_code): New function.
2954 (Fmake_byte_code): Use it. Don't purify here.
2955 * lread.c (read1): Use it as well to avoid extra allocation.
2956
1b9b4cf4
CY
29572012-06-11 Chong Yidong <cyd@gnu.org>
2958
2959 * image.c (imagemagick_load_image): Implement transparency.
2960
95988fcf
AS
29612012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2962
2963 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2964 account for preceding backslashes. (Bug#11663)
2965
cd4eb164
CY
29662012-06-09 Chong Yidong <cyd@gnu.org>
2967
2968 * term.c: Support italics in capable terminals (Bug#9652).
2969 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2970 (turn_on_face): Output using TS_enter_italic_mode if available.
2971 Don't handle unused blinking and alt-charset cases.
2972 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2973 and tty_alt_charset_p cases.
2974 (tty_capable_p, init_tty): Support italics.
2975
2976 * termchar.h (struct tty_display_info): Add field for italics.
2977 Remove unused blink field.
2978
2979 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2980 Handle slant.
2981
2982 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2983 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2984 tty_alt_charset_p. Add tty_italic_p.
2985
ff88beb8
MA
29862012-06-09 Michael Albinus <michael.albinus@gmx.de>
2987
2988 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2989 dbus_type_is_basic if available.
2990 (xd_extract_signed, xd_extract_unsigned): Rename from
2991 extract_signed and extract_unsigned, respectively. Adapt callers.
2992
44286096
CY
29932012-06-09 Chong Yidong <cyd@gnu.org>
2994
1682701f
CY
2995 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2996
44286096
CY
2997 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2998 case (Bug#9752).
2999
d86feb17
PE
30002012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3001
3002 * xdisp.c (vmessage): Treat frame message as multibyte.
3003 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3004 would generate the diagnostic "Making \302\247 buffer-local while
3005 let-bound!".
3006
d5c20fe8
EZ
30072012-06-08 Eli Zaretskii <eliz@gnu.org>
3008
3009 * dispnew.c (showing_window_margins_p): Undo last change, which
3010 was done due to an inadvertent commit.
3011 (adjust_frame_glyphs_for_frame_redisplay): Do call
3012 showing_window_margins_p.
3013
513749ee
SM
30142012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3015
3016 * eval.c (Fmake_var_non_special): New primitive.
3017 (syms_of_eval): Defsubr it.
3018 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3019
d4a8f5c1
JB
30202012-06-08 Juanma Barranquero <lekktu@gmail.com>
3021
3022 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3023 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3024
8bbbc977
EZ
30252012-06-08 Eli Zaretskii <eliz@gnu.org>
3026
3027 * alloc.c (allocate_vectorlike): Fix last change.
3028
f3372c87
DA
30292012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3030
3031 Block-based vector allocation of small vectors.
3032 * lisp.h (struct vectorlike_header): New field `nbytes',
3033 adjust comment accordingly.
3034 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3035 to denote vector blocks. Adjust users (live_vector_p,
3036 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3037 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3038 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3039 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3040 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3041 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3042 (roundup_size): New constant.
3043 (struct vector_block): New data type.
3044 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3045 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3046 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3047 (sweep_vectors): New functions.
3048 (allocate_vectorlike): Return `zero_vector' as the only vector of
3049 0 items. Allocate new vector from block if vector size is less than
3050 or equal to VBLOCK_BYTES_MAX.
3051 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3052 (init_alloc_once): Add call to init_vectors.
3053
4f18a4ed
SM
30542012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3055
3056 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3057
86f158bc
PE
30582012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3059
3060 * doprnt.c (doprnt): Truncate multibyte char correctly.
3061 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3062 would mishandle a string argument "Xc" if X was a multibyte
3063 character of length 2: it would truncate after X's first byte
3064 rather than including all of X.
3065
c5cfcbe0
CY
30662012-06-06 Chong Yidong <cyd@gnu.org>
3067
3068 * buffer.c (word_wrap): Doc fix.
3069
c05cf390
PE
30702012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3071
3072 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3073
0c3461de
GM
30742012-06-03 Glenn Morris <rgm@gnu.org>
3075
3076 * xdisp.c (tool-bar-style): Doc fix.
3077
c71232db
UM
30782012-06-03 Ulrich Müller <ulm@gentoo.org>
3079
3080 * Makefile.in (PAXCTL): Define.
3081 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3082 binary via PaX flags if the paxctl utility is available.
3083 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3084 Restore PaX flags to their default. (Bug#11398)
3085
383f7350
CY
30862012-06-03 Chong Yidong <cyd@gnu.org>
3087
3088 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3089 buffer (Bug#11226).
3090
5f2c76c6
CY
30912012-06-03 Chong Yidong <cyd@gnu.org>
3092
3093 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3094 (note_mode_line_or_margin_highlight): If there is no help echo,
3095 use mode-line-default-help-echo. Handle the case where the mouse
3096 position is past the end of the mode line string.
3097
3098 * buffer.c (buffer_local_value_1): New function, split from
3099 Fbuffer_local_value; can return Qunbound.
3100 (Fbuffer_local_value): Use it.
3101 (Vmode_line_format): Docstring tweaks.
3102
773d47f6
PE
31032012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3104
3105 * sysdep.c (system_process_attributes): Improve comment.
3106
f2d6a3df
SM
31072012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3108
3109 * keyboard.c: Export real-this-command to Elisp.
3110 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3111 and DEFVAR it. Update all users.
3112
63810350
PE
31132012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3114
7bd5c1f4
PE
3115 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3116
63810350
PE
3117 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3118 Convert pctcpu and pctmem to Lisp float properly.
3119 Let the compiler fold better, as 100.0/0x8000 is exact.
3120
a2821611
AS
31212012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3122
3123 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3124 cons_block.
3125
5fceba1d
PE
31262012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3127
3128 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3129
c98ff5dd
DA
31302012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3131
3132 For a 'struct window', replace some Lisp_Object fields to
3133 bitfields where appropriate, remove unused fields.
3134 * window.h (struct window): Remove unused 'last_mark_x' and
3135 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3136 change it's type from Lisp_Object to bitfield.
3137 Change type of 'force_start', 'optional_new_start',
3138 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3139 fields from Lisp_Object to bitfield. Adjust users accordingly.
3140
ca34e0be
PE
31412012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3142
3143 Pacify gcc -Wdouble-precision when using Xaw.
3144 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3145 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3146 Use 'float' consistently, rather than 'float' in most places
3147 and 'double' in a couple of places.
3148
efc00ab1 31492012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3150
3151 * xdisp.c (handle_stop): Detect whether we have overlay strings
3152 loaded by testing it->current.overlay_string_index to be
3153 non-negative, instead of checking whether n_overlay_strings is
3154 positive. (Bug#11587)
3155
efc00ab1 31562012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3157
3158 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3159
3160 * doc.c (Fsubstitute_command_keys): Doc fix.
3161
efc00ab1 31622012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3163
3164 * search.c (search_buffer): Remove calls to
3165 r_alloc_inhibit_buffer_relocation, as it is now called by
3166 maybe_unify_char, which was the cause of relocation of buffer text
3167 in bug#11519.
3168
efc00ab1 31692012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3170
3171 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3172 for the duration of call to load_charset, to avoid problems with
3173 callers of maybe_unify_char that access buffer text through C
3174 pointers.
3175
3176 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3177 decrement the inhibition flag, instead of just setting or
3178 resetting it.
3179
ba93a187
PE
31802012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3181
3182 Remove obsolete '#define static' cruft.
3183 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3184 This #undef was "temporary" in 2000; it is no longer needed
3185 now that '#define static' has gone away.
3186 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3187 (gray_bitmap_bits): Remove; no longer needed.
3188 All uses replaced with definiens.
3189 * xterm.c: Include "bitmaps/gray.xbm".
3190
9e4bf381
PE
31912012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3192
3193 Clean up __executable_start, monstartup when --enable-profiling.
3194 The following changes affect the code only when profiling.
3195 * dispnew.c (__executable_start): Rename from safe_bcopy.
3196 Define only on platforms that need it.
3197 * emacs.c: Include <sys/gmon.h> when profiling.
3198 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3199 (__executable_start): Remove decl, since lisp.h does it now.
3200 (safe_bcopy): Remove decl; no longer has that name.
3201 (main): Coalesce #if into single bit of code, for simplicity.
3202 Cast pointers to uintptr_t, since standard libraries want integers
3203 and not pointers.
3204 * lisp.h (__executable_start): New decl.
3205
32d72c2f
GM
32062012-05-31 Glenn Morris <rgm@gnu.org>
3207
3208 * image.c (Fimagemagick_types): Doc fix.
3209
baac5bc7
JM
32102012-05-30 Jim Meyering <meyering@redhat.com>
3211
3212 * callproc.c (Fcall_process_region): Include directory component
3213 in mkstemp error message (Bug#11586).
3214
72cb32cf
PE
32152012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3216
3217 * alloc.c, lisp.h (make_pure_vector): Now static.
3218
61b108cc
SM
32192012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3220
3221 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3222 Move to byte-run.el.
3223 (Fautoload): Do the hash-doc more carefully.
3224 * data.c (Fdefalias): Purify definition, except for keymaps.
3225 (Qdefun): Move from eval.c.
3226 * lisp.h (Qdefun): Remove.
3227 * lread.c (read1): Tiny simplification.
3228
471fe23d
TN
32292012-05-29 Troels Nielsen <bn.troels@gmail.com>
3230
934f3f58 3231 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3232 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3233 Bug#9642, but explicitly check that the buffer the overlay would
3234 be moved to is live and rearrange lines to make sure that errors
3235 will not put the overlay in an inconsistent state.
3236 (Fdelete_overlay): Cosmetics.
3237
85d0efd1
EZ
32382012-05-28 Eli Zaretskii <eliz@gnu.org>
3239
3240 * w32term.c (my_bring_window_to_top): New function.
3241 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3242 could be different from the original one.
3243 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3244 (Bug#11513)
3245
3246 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3247 by calling BringWindowToTop.
3248
3249 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3250 (WM_EMACS_END): Increase by one.
3251
da92a98c
PE
32522012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3253
3254 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3255 This avoids undefined behavior that might cause the eassert
3256 to not catch an out-of-range value.
3257
74d1f848
JB
32582012-05-28 Juanma Barranquero <lekktu@gmail.com>
3259
3260 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3261 Update dependencies.
3262
9e1a06fc
EZ
32632012-05-27 Eli Zaretskii <eliz@gnu.org>
3264
3265 * bidi.c (bidi_mirror_char): Fix last change.
3266
f3dd7312
AS
32672012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3268
3269 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3270 when referring to sectname field in printf format.
3271
81899c91
PE
32722012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3273
57b81a9f
PE
3274 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3275 Only r_alloc_inhibit_buffer_relocation needed to be added;
3276 the others were already declared.
3277
81899c91
PE
3278 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3279 before checking whether it's out of range. Put the check inside
3280 eassert. See
3281 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3282
33017faf 32832012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3284
3285 * callproc.c (Fcall_process): Restore a line that was accidentally
3286 commented out in the 2011-02-13 change (bug#11547).
3287
33017faf 32882012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3289
3290 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3291 defined on ralloc.c.
3292
3293 * buffer.c [REL_ALLOC]: Remove prototypes of
3294 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3295 they are now on lisp.h.
3296
3297 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3298
3299 * search.c (search_buffer): Use it to inhibit relocation of buffer
3300 text while re_search_2 is doing its job, because re_search_2 is
3301 passed C pointers to buffer text. (Bug#11519)
3302
23415acf
EZ
3303 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3304 Update value to 24.
3305
44e27368
EZ
3306 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3307 state after an additional call to move_it_in_display_line_to, keep
3308 the values of it->max_ascent and it->max_descent found for the
3309 entire line.
3310 (pos_visible_p): Revert the comparison against bottom_y to what it
3311 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3312 (Bug#11464)
3313
c1892f11
PE
33142012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3315
3316 Fix coding-related core dumps with gcc -ftrapv.
3317 The code was computing A - B, where A and B are pointers, and B is
3318 random garbage. This can lead to core dumps on platforms that
3319 have special pointer registers, and it also leads to core dumps on
3320 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3321 A - B only when B is initialized properly.
3322 * coding.c (coding_set_source, coding_set_destination): Return void.
3323 (coding_change_source, coding_change_destinations): New functions,
3324 with the old behaviors of coding_set_source and coding_set_destination.
3325 All callers that need an offset changed to use these new functions.
3326
eb7afdad
GM
33272012-05-26 Glenn Morris <rgm@gnu.org>
3328
3329 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3330
f12fdf02
EZ
33312012-05-26 Eli Zaretskii <eliz@gnu.org>
3332
53a63be6 3333 Extend mouse support on W32 text-mode console.
61b108cc
SM
3334 * xdisp.c (draw_row_with_mouse_face):
3335 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3336
eb3f6f01 3337 * w32console.c: Include window.h.
61b108cc
SM
3338 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3339 New functions.
eb3f6f01
EZ
3340 (initialize_w32_display): Initialize mouse-highlight data.
3341
53a63be6
EZ
3342 * w32inevt.c: Include termchar.h and window.h.
3343 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3344 moves, call note_mouse_highlight. If help_echo changed, call
3345 gen_help_event to produce help-echo message in the echo area.
3346 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3347 highlight info.
3348
4cfd81f6
PE
33492012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3350
3351 * lread.c (read1): Simplify slightly to avoid an overflow warning
3352 with GCC 4.7.0 on x86-64.
3353
4446092a
EZ
33542012-05-26 Eli Zaretskii <eliz@gnu.org>
3355
3356 * bidi.c (bidi_mirror_char): Revert last change: an int is
3357 definitely wide enough here.
3358
42b2a986 33592012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3360
42b2a986 3361 Fix integer width and related bugs (Bug#9874).
eb106a49 3362 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3363 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3364 (string_bytes, check_sblock, allocate_string_data):
3365 (compact_small_strings, Fmake_bool_vector, make_string)
3366 (make_unibyte_string, make_multibyte_string)
3367 (make_string_from_bytes, make_specified_string)
3368 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3369 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3370 (mark_vectorlike):
3371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3372 (allocate_pseudovector):
3373 Use int, not EMACS_INT, where int is wide enough.
3374 (inhibit_garbage_collection, Fgarbage_collect):
3375 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3376 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3377 int might not be wide enough.
3378 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3379 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3380 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3381 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3382 (bidi_level_of_next_char, bidi_move_to_visually_next):
3383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3384 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3385 (Fkill_buffer, Fset_buffer_major_mode)
3386 (advance_to_char_boundary, Fbuffer_swap_text)
3387 (Fset_buffer_multibyte, overlays_at, overlays_in)
3388 (overlay_touches_p, struct sortvec, record_overlay_string)
3389 (overlay_strings, recenter_overlay_lists)
3390 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3391 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3392 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3393 (Foverlay_recenter, last_overlay_modification_hooks_used)
3394 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3396 (validate_region): Omit unnecessary test for b <= e,
3397 since that's guaranteed by the previous test.
d311d28c
PE
3398 (adjust_overlays_for_delete): Avoid pos + length overflow.
3399 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3400 (report_overlay_modification):
3401 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3402 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3403 Omit pointer cast, which isn't needed anyway, and doesn't work
3404 after the EMACS_INT -> ptrdiff_t change.
02481186 3405 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3406 * buffer.h: Adjust decls to match defn changes elsewhere.
3407 (struct buffer_text, struct buffer):
3408 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3409 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3410 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3411 not int, to avoid needless 32-bit limit on 64-bit hosts.
3412 (exec_byte_code): Use tighter memory-full test, one that checks
3413 for alloca overflow. Don't compute the address of the object just
3414 before an array, as that's not portable. Use EMACS_INT, not
3415 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3416 * callint.c (Fcall_interactively):
3417 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3418 * callproc.c (call_process_kill, Fcall_process):
3419 Don't assume pid_t fits into an Emacs fixnum.
3420 (call_process_cleanup, Fcall_process, child_setup):
3421 Don't assume pid_t fits into int.
3422 (call_process_cleanup, Fcall_process, delete_temp_file)
3423 (Fcall_process_region):
3424 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3425 (Fcall_process): Simplify handling of volatile integers.
3426 Use int, not EMACS_INT, where int will do.
3427 * casefiddle.c (casify_object, casify_region, operate_on_word)
3428 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3430 (casify_object): Avoid integer overflow when overallocating buffer.
3431 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3432 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3433 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3434 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3435 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3436 integers are now checked earlier. All uses replaced with XINT.
3437 (ccl_driver):
3438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3439 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3440 (ccl_driver, Fregister_code_conversion_map):
3441 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3442 (resolve_symbol_ccl_program): Check that vector header is in range.
3443 Always copy the vector, so that we can check its contents reliably
3444 now rather than having to recheck each instruction as it's being
3445 executed. Check that vector words fit in 'int'.
3446 (ccl_get_compiled_code, Fregister_ccl_program)
3447 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3448 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3449 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3450 contents are in range.
3451 (Fccl_execute_on_string): Check that status is in range.
3452 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3453 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3454 Accept and return EMACS_INT, not int, because callers can pass values
3455 out of 'int' range.
3456 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3457 (multibyte_chars_in_text, parse_str_as_multibyte)
3458 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3459 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3460 (string_escape_byte8, Fget_byte):
3461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3462 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3463 avoid mishandling large integers.
3464 * character.h: Adjust decls to match defn changes elsewhere.
3465 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3466 (Ffind_charset_region):
3467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3468 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3469 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3470 Don't assume fixnum fits in int.
d311d28c
PE
3471 (load_charset_map_from_vector, Fmap_charset_chars):
3472 Remove now-unnecessary CHECK_NATNUMs.
3473 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3474 Don't rely on undefined behavior with signed left shift overflow.
3475 Don't assume unsigned int fits into fixnum, or that fixnum fits
3476 into unsigned int. Don't require max_code to be a valid fixnum;
3477 that's not true for gb10830 4-byte on a 32-bit host. Allow
3478 invalid_code to be a cons, for the same reason. Require code_offset
3479 to be a character. Avoid int overflow if max_char is close
3480 to INT_MAX.
3481 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3482 this is intended anyway and avoids some undefined behavior.
3483 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3484 INDEX_TO_CODE_POINT, as that's what it expects.
3485 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3486 * charset.h (DECODE_CHAR): Return int, not unsigned;
3487 this is what was intended anyway, and it avoids undefined behavior.
3488 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3489 integer-overflow issues.
3490 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3491 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3492 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3493 * chartab.c (Fmake_char_table, Fset_char_table_range)
3494 (uniprop_get_decoder, uniprop_get_encoder):
3495 Don't assume fixnum fits in int.
3496 * cmds.c (move_point): New function, that does the gist of
3497 Fforward_char and Fbackward_char, but does so while checking
3498 for integer overflow more accurately.
c96e5d6a 3499 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3500 (Fforward_line, Fend_of_line, internal_self_insert)
3501 (internal_self_insert):
3502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3503 Fix a FIXME, by checking for integer overflow when calculating
3504 target_clm and actual_clm.
3505 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3506 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3507 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3508 (coding_alloc_by_making_gap, alloc_destination)
3509 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3510 (encode_coding_utf_16, detect_coding_emacs_mule)
3511 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3512 (detect_coding_iso_2022, decode_coding_iso_2022)
3513 (encode_invocation_designation, encode_designation_at_bol)
3514 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3515 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3516 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3517 (encode_coding_ccl, encode_coding_raw_text)
3518 (detect_coding_charset, decode_coding_charset)
3519 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3520 (produce_composition, produce_charset, produce_annotation)
3521 (decode_coding, handle_composition_annotation)
3522 (handle_charset_annotation, consume_chars, decode_coding_gap)
3523 (decode_coding_object, encode_coding_object, detect_coding_system)
3524 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3525 (code_convert_region, code_convert_string)
8f50130c
PE
3526 (Fdefine_coding_system_internal)
3527 (coding_set_source, coding_set_destination):
d311d28c
PE
3528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3529 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3530 (Fdefine_coding_system_internal):
3531 Don't assume fixnums fit in int.
3532 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3533 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3534 (Funencodable_char_position, Fcheck_coding_systems_region)
3535 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3536 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3537 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3538 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3539 Don't access memory outside of the args array.
d311d28c 3540 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3541 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3542 result of ENCODE_CHAR.
d311d28c
PE
3543 * coding.h: Adjust decls to match defn changes elsewhere.
3544 (struct coding_system):
3545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3546 * composite.c (get_composition_id, find_composition)
3547 (run_composition_function, update_compositions)
3548 (compose_text, composition_gstring_put_cache)
3549 (composition_gstring_p, composition_gstring_width)
3550 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3551 (composition_compute_stop_pos, composition_reseat_it)
3552 (composition_update_it, struct position_record)
3553 (find_automatic_composition, composition_adjust_point)
3554 (Fcomposition_get_gstring, Ffind_composition_internal):
3555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3556 (update_compositions):
3557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3558 * composite.h: Adjust decls to match defn changes elsewhere.
3559 (struct composition):
3560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3561 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3562 Do not attempt to compute the address of the object just before a
3563 buffer; this is not portable.
3564 (Faref, Faset):
3565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3566 (Faset): Use int, not EMACS_INT, where int is wide enough.
3567 (Fstring_to_number): Don't assume fixnums fit in int.
3568 (Frem): Don't assume arg is nonnegative.
3569 * dbusbind.c (xd_append_arg): Check for integers out of range.
3570 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3571 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3572 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3573 (xd_get_connection_references): Return ptrdiff_t, not int.
3574 All uses changed.
3575 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3576 (xd_read_message_1):
3577 Use int, not unsigned, where the dbus API uses int.
3578 (Fdbus_message_internal): Don't overflow mtype.
3579 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3580 * dired.c (directory_files_internal, file_name_completion, scmp)
3581 (file_name_completion_stat):
3582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3583 (file_name_completion): Don't overflow matchcount.
3584 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3585 * dispextern.h: Adjust decls to match defn changes elsewhere.
3586 (struct text_pos, struct glyph, struct bidi_saved_info)
3587 (struct bidi_string_data, struct bidi_it, struct composition_it)
3588 (struct it):
3589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3590 (struct display_pos, struct composition_it, struct it):
3591 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3592 * dispnew.c (increment_matrix_positions)
3593 (increment_row_positions, mode_line_string)
3594 (marginal_area_string):
3595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3596 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3598 (duration_to_sec_usec): New function, to check for overflow better.
3599 (Fsleep_for, sit_for): Use it.
3600 * doc.c (get_doc_string, store_function_docstring):
3601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3602 (get_doc_string, Fsnarf_documentation):
3603 Use int, not EMACS_INT, where int is wide enough.
3604 (get_doc_string):
3605 Use SAFE_ALLOCA, not alloca.
3606 Check for overflow when converting EMACS_INT to off_t.
3607 * doprnt.c (doprnt):
3608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3609 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3610 Don't assume uid_t fits into fixnum.
3611 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3612 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3613 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3614 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3615 (general_insert_function)
3616 (Finsert_char, make_buffer_string, make_buffer_string_both)
3617 (update_buffer_properties, Fbuffer_substring)
3618 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3619 (Fsubst_char_in_region, check_translation)
3620 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3621 (transpose_markers, Ftranspose_regions):
3622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3623 (clip_to_bounds): Move to lisp.h as an inline function).
3624 (Fconstrain_to_field): Don't assume integers are nonnegative.
3625 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3626 (Fsubst_char_in_region, Fsave_restriction):
3627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3628 (Femacs_pid): Don't assume pid_t fits into fixnum.
3629 (lo_time): Use int, not EMACS_INT, when int suffices.
3630 (lisp_time_argument): Check for usec out of range.
3631 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3632 (Fuser_login_name, Fuser_full_name): Signal an error
3633 if a uid argument is out of range, rather than relying on
3634 undefined behavior.
c8d5c857
PE
3635 (Fformat_time_string): Remove now-unnecessary check.
3636 lisp_time_argument checks for out-of-range usec now.
243e0530 3637 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3638 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3639 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3640 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3641 (init_cmdargs, Fdump_emacs):
3642 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3643 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3644 the bottom (typically) 32 bits of the fixnum.
3645 * eval.c (specpdl_size, call_debugger):
3646 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3647 (when_entered_debugger, Fbacktrace_debug):
3648 Don't assume fixnum can fit in int.
3649 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3650 the object just before a buffer; this is not portable.
3651 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3652 (grow_specpdl, unbind_to):
3653 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3654 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3655 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3656 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3657 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3658 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3660 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3661 (a_write, e_write):
3662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3663 (Fcopy_file, non_regular_nbytes, read_non_regular)
3664 (Finsert_file_contents):
3665 Use int, not EMACS_INT, where int is wide enough.
3666 (READ_BUF_SIZE): Verify that it fits in int.
3667 (Finsert_file_contents): Check that counts are in proper range,
3668 rather than assuming fixnums fit into ptrdiff_t etc.
3669 Don't assume fixnums fit into int.
125b3835 3670 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3671 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3672 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3673 (string_char_to_byte, string_byte_to_char)
3674 (string_make_multibyte, string_to_multibyte)
3675 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3676 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3677 (substring_both, Fdelete, internal_equal, Ffillarray)
3678 (Fclear_string, mapcar1)
3679 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3680 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3681 (larger_vector, make_hash_table, maybe_resize_hash_table)
3682 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3683 (Fmaphash, secure_hash):
3684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3685 (concat): Check for string index and length overflow.
3686 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3687 (Frequire):
3688 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3689 (larger_vector): New API (vec, incr_min, size_max) replaces old
3690 one (vec, new_size, init). This catches size overflow.
3691 INIT was removed because it was always Qnil.
3692 All callers changed.
3693 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3694 the upper bound on a hash table index size.
3695 (make_hash_table, maybe_resize_hash_table): Use it.
3696 (secure_hash): Computer start_byte and end_byte only after
3697 they're known to be in ptrdiff_t range.
3698 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3699 (Ffont_get_glyphs, Ffont_at):
3700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3701 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3702 (Flist_fonts, Fopen_font):
3703 Don't assume fixnum can fit in int.
3704 (check_gstring): Don't assume index can fit in int.
3705 (font_match_p): Check that fixnum is a character, not a nonnegative
3706 fixnum, since the later code needs to stuff it into an int.
3707 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3708 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3709 conversion overflow issues.
3710 (Fopen_font): Check for integer out of range.
3711 (Ffont_get_glyphs): Don't assume index can fit in int.
3712 * font.h: Adjust decls to match defn changes elsewhere.
3713 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3714 integer overflow.
3715 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3716 printmax_t, where ptrdiff_t is wide enough.
3717 (Finternal_char_font):
3718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3719 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3720 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3721 (Fset_frame_position, x_set_frame_parameters)
3722 (x_set_line_spacing, x_set_border_width)
3723 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3724 Check that fixnums are in proper range for system types.
3725 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3727 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3728 Use SAFE_ALLOCA_LISP, not alloca.
3729 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3730 intptr_t is wide enough.
3731 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3732 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3733 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3734 Check for fixnum out of range.
3735 * ftfont.c (ftfont_list): Don't assume index fits in int.
3736 Check that fixnums are in proper range for system types.
3737 (ftfont_shape_by_flt):
3738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3739 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3740 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3741 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3742 Check that fixnums are in proper range for system types.
3743 * gnutls.h: Adjust decls to match defn changes elsewhere.
3744 * gtkutil.c (xg_dialog_run):
3745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3746 (update_frame_tool_bar):
3747 Check that fixnums are in proper range for system types.
3748 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3749 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3750 * indent.c (last_known_column, last_known_column_point):
3751 (current_column_bol_cache):
3752 (skip_invisible, current_column, check_display_width):
3753 (check_display_width, scan_for_column, current_column_1)
3754 (Findent_to, Fcurrent_indentation, position_indentation)
3755 (indented_beyond_p, Fmove_to_column, compute_motion):
3756 (Fcompute_motion, Fvertical_motion):
3757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3758 (last_known_column_modified): Use EMACS_INT, not int.
3759 (check_display_width):
3760 (Fcompute_motion):
3761 Check that fixnums and floats are in proper range for system types.
3762 (compute_motion): Don't assume index or fixnum fits in int.
3763 (compute_motion, Fcompute_motion):
3764 Use int, not EMACS_INT, when it is wide enough.
3765 (vmotion): Omit local var start_hpos that is always 0; that way
3766 we don't need to worry about overflow in expressions involving it.
3767 * indent.h: Adjust decls to match defn changes elsewhere.
3768 (struct position):
3769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3770 Use int, not EMACS_INT, where int is wide enough.
3771 Remove unused members ovstring_chars_done and tab_offset;
3772 all uses removed.
3773 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3774 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3775 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3776 (make_gap, copy_text, insert, insert_and_inherit)
3777 (insert_before_markers, insert_before_markers_and_inherit)
3778 (insert_1, count_combining_before, count_combining_after)
3779 (insert_1_both, insert_from_string)
3780 (insert_from_string_before_markers, insert_from_string_1)
3781 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3782 (adjust_after_replace, adjust_after_insert, replace_range)
3783 (replace_range_2, del_range, del_range_1, del_range_byte)
3784 (del_range_both, del_range_2, modify_region)
3785 (prepare_to_modify_buffer, signal_before_change)
3786 (signal_after_change, Fcombine_after_change_execute):
3787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3788 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3789 (balance_an_interval, split_interval_right, split_interval_left)
3790 (find_interval, next_interval, update_interval)
3791 (adjust_intervals_for_insertion, delete_node, delete_interval)
3792 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3793 (static_offset_intervals, offset_intervals)
3794 (merge_interval_right, merge_interval_left, make_new_interval)
3795 (graft_intervals_into_buffer, temp_set_point_both)
3796 (temp_set_point, set_point, adjust_for_invis_intang)
3797 (set_point_both, move_if_not_intangible, get_property_and_range)
3798 (get_local_map, copy_intervals, copy_intervals_to_string)
3799 (compare_string_intervals, set_intervals_multibyte_1):
3800 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3801 * intervals.h: Adjust decls to match defn changes elsewhere.
3802 (struct interval):
3803 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3804 * keyboard.c (this_command_key_count, this_single_command_key_start)
3805 (before_command_key_count, before_command_echo_length, echo_now)
3806 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3807 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3808 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3809 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3811 (last_non_minibuf_size, last_point_position, echo_truncate)
3812 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3813 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3814 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3815 (stuff_buffered_input):
3816 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3817 (last_auto_save, command_loop_1, read_char):
3818 Use EMACS_INT, not int, to avoid integer overflow.
3819 (record_char): Avoid overflow in total_keys computation.
3820 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3821 * keyboard.h: Adjust decls to match defn changes elsewhere.
3822 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3823 (Fkey_description, Fdescribe_vector, Flookup_key):
3824 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3825 (click_position): New function, to check that positions are in range.
3826 (Fcurrent_active_maps):
3827 (describe_command):
3828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3829 (Faccessible_keymaps, Fkey_description):
3830 (preferred_sequence_p):
3831 Don't assume fixnum can fit into int.
3832 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3833 Check for integer overflow in size calculations.
3834 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3835 avoid mishandling large integers.
3836 * lisp.h: Adjust decls to match defn changes elsewhere.
3837 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3838 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3839 (struct Lisp_Marker):
3840 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3841 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3842 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3843 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3844 All callers changed.
3845 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3846 Assume the arg has valid form, since it always does.
3847 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3848 unsigned integer system type.
3849 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3850 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3852 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3853 (duration_to_sec_usec): New decl.
3854 * lread.c (read_from_string_index, read_from_string_index_byte)
3855 (read_from_string_limit, readchar, unreadchar, openp)
3856 (read_internal_start, read1, oblookup):
3857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3858 (Fload, readevalloop, Feval_buffer, Feval_region):
3859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3860 (openp): Check for out-of-range argument to 'access'.
3861 (read1): Use int, not EMACS_INT, where int is wide enough.
3862 Don't assume fixnum fits into int.
6efdadfd 3863 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3864 (read_filtered_event): Use duration_to_sec_usec
3865 to do proper overflow checking on durations.
d311d28c
PE
3866 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3867 in size calculation.
3868 (Fexecute_kbd_macro):
3869 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3870 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3871 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3872 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3873 (set_marker_both, set_marker_restricted_both, marker_position)
3874 (marker_byte_position, Fbuffer_has_markers_at):
3875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3876 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3877 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3878 It now merely ensures that the menu is large enough, without
3879 necessarily growing it, as this avoids some integer overflow issues.
3880 All callers changed.
3881 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3882 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3883 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3884 Use SAFE_ALLOCA_LISP, not alloca.
3885 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3886 to EMACS_INT. Check that fixnums are in proper range for system types.
3887 * minibuf.c (minibuf_prompt_width, string_to_object)
3888 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3889 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3891 (get_minibuffer, read_minibuf_unwind):
3892 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3893 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3894 this simplifies overflow checking. All callers changed.
3895 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3896 (Ftest_completion):
3897 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3898 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3899 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3900 Check that fixnums are in proper range for system types.
3901 (Fx_create_frame, Fx_show_tip):
3902 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3903 * nsfont.m (ns_findfonts, nsfont_list_family):
3904 Don't assume fixnum fits in long.
3905 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3906 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3907 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3908 wide enough.
17fdb222 3909 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3910 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3911 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3912 (PRINTDECLARE, PRINTPREPARE):
3913 (strout, print_string):
3914 (print, print_preprocess, print_check_string_charset_prop)
3915 (print_object):
3916 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3917 (PRINTDECLARE):
3918 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3920 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3921 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3922 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3923 (print_error_message): Use SAFE_ALLOCA, not alloca.
3924 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3925 (print_depth, new_backquote_output, print_number_index):
3926 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3927 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3928 (Fset_process_window_size, Fformat_network_address)
3929 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3930 (sigchld_handler):
d311d28c 3931 Check that fixnums are in proper range for system types.
d44287d4 3932 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3933 Check for process-ids out of pid_t range rather than relying on
3934 undefined behavior.
e4d81efc 3935 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3936 (Fformat_network_address, read_process_output, send_process)
3937 (Fprocess_send_region, status_notify):
3938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3939 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3940 (wait_reading_process_output, read_process_output, exec_sentinel):
3941 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3942 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3943 (Faccept_process_output): Use duration_to_sec_usec to do proper
3944 overflow checking on durations.
dde14581
PE
3945 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3946 Don't assume pid_t fits in int.
02481186
PE
3947 * process.h (struct Lisp_Process): Members tick and update_tick
3948 are now of type EMACS_INT, not int.
b62b53e8
PE
3949 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3950 configured --with-wide-int.
d311d28c
PE
3951 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3952 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3953 * search.c (looking_at_1, string_match_1):
3954 (fast_string_match, fast_c_string_match_ignore_case)
3955 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3956 (scan_newline, find_before_next_newline, search_command)
3957 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3958 (set_search_regs, wordify):
3959 (Freplace_match):
3960 (Fmatch_data):
3961 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3962 (string_match_1, search_buffer, set_search_regs):
3963 (Fmatch_data):
3964 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3965 (wordify): Check for overflow in size calculation.
3966 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3967 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3968 Check that fixnums are in proper range for system types.
3969 * sound.c (struct sound_device)
3970 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3971 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3972 (Fplay_sound_internal):
3973 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3974 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3975 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3976 (Fparse_partial_sexp):
3977 Don't assume fixnums can fit in int.
3978 (struct lisp_parse_state, find_start_pos, find_start_value)
3979 (find_start_value_byte, find_start_begv)
3980 (update_syntax_table, char_quoted, dec_bytepos)
3981 (find_defun_start, prev_char_comend_first, back_comment):
3982 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3983 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3984 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3985 (Finternal_describe_syntax_value): Check that match_lisp is a
3986 character, not an integer, since the code stuffs it into int.
3987 (scan_words, scan_sexps_forward):
3988 Check that fixnums are in proper range for system types.
3989 (Fforward_word):
3990 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3991 (scan_sexps_forward):
3992 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3993 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3994 * syntax.h: Adjust decls to match defn changes elsewhere.
3995 (struct gl_state_s):
3996 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3997 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3998 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3999 * sysdep.c (wait_for_termination_1, wait_for_termination)
4000 (interruptible_wait_for_termination, mkdir):
4001 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4002 (emacs_read, emacs_write):
4003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4004 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4005 and double all fit in int.
d311d28c
PE
4006 * term.c (set_tty_color_mode):
4007 Check that fixnums are in proper range for system types.
4008 * termhooks.h (struct input_event):
4009 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4010 * textprop.c (validate_interval_range, interval_of)
4011 (Fadd_text_properties, set_text_properties_1)
4012 (Fremove_text_properties, Fremove_list_of_text_properties)
4013 (Ftext_property_any, Ftext_property_not_all)
4014 (copy_text_properties, text_property_list, extend_property_ranges)
4015 (verify_interval_modification):
4016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4017 (Fnext_single_char_property_change)
4018 (Fprevious_single_char_property_change):
4019 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4020 (copy_text_properties):
4021 Check for integer overflow in index calculation.
d311d28c
PE
4022 * undo.c (last_boundary_position, record_point, record_insert)
4023 (record_delete, record_marker_adjustment, record_change)
4024 (record_property_change):
4025 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4026 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4027 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4028 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4029 (Fx_hide_tip, Fx_file_dialog):
4030 * w32menu.c (set_frame_menubar):
4031 Use ptrdiff_t, not int, for consistency with rest of code.
4032 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4033 (select_window, Fdelete_other_windows_internal)
4034 (window_scroll_pixel_based, window_scroll_line_based)
4035 (Frecenter, Fset_window_configuration):
4036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4037 (Fset_window_hscroll, run_window_configuration_change_hook)
4038 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4039 (Fscroll_other_window, Frecenter):
d311d28c
PE
4040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4041 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4042 Don't assume fixnum fits in int.
4043 (Fset_window_scroll_bars):
4044 Check that fixnums are in proper range for system types.
4045 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4046 (string_pos, c_string_pos, number_of_chars, init_iterator)
4047 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4048 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4049 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4050 (face_before_or_after_it_pos, handle_invisible_prop)
4051 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4052 (display_prop_intangible_p, string_buffer_position_lim)
4053 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4054 (get_overlay_strings_1, get_overlay_strings)
4055 (iterate_out_of_display_property, forward_to_next_line_start)
4056 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4057 (get_next_display_element, set_iterator_to_next)
4058 (get_visually_first_element, compute_stop_pos_backwards)
4059 (handle_stop_backwards, next_element_from_buffer)
4060 (move_it_in_display_line_to, move_it_in_display_line)
4061 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4062 (add_to_log, message_dolog, message_log_check_duplicate)
4063 (message2, message2_nolog, message3, message3_nolog
4064 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4065 (current_message_1, truncate_echo_area, truncate_message_1)
4066 (set_message, set_message_1, store_mode_line_noprop)
4067 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4068 (text_outside_line_unchanged_p, check_point_in_composition)
4069 (reconsider_clip_changes)
4070 (redisplay_internal, set_cursor_from_row, try_scrolling)
4071 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4072 (redisplay_window, find_last_unchanged_at_beg_row)
4073 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4074 (trailing_whitespace_p, find_row_edges, display_line)
4075 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4076 (display_mode_element, store_mode_line_string)
4077 (pint2str, pint2hrstr, decode_mode_spec)
4078 (display_count_lines, display_string, draw_glyphs)
4079 (x_produce_glyphs, x_insert_glyphs)
4080 (rows_from_pos_range, mouse_face_from_buffer_pos)
4081 (fast_find_string_pos, mouse_face_from_string_pos)
4082 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4084 (safe_call, init_from_display_pos, handle_fontified_prop)
4085 (handle_single_display_spec, load_overlay_strings)
4086 (with_echo_area_buffer, setup_echo_area_for_printing)
4087 (display_echo_area, echo_area_display)
4088 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4089 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4090 (redisplay_window, dump_glyph_row, display_mode_line)
4091 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4092 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4094 (handle_single_display_spec, build_desired_tool_bar_string)
4095 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4096 (get_specified_cursor_type):
4097 Check that fixnums are in proper range for system types.
4098 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4099 (Flookup_image_map):
4100 Don't assume fixnums fit in int.
4101 (compare_overlay_entries):
4102 Avoid mishandling comparisons due to subtraction overflow.
4103 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4104 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4105 (handle_tool_bar_click):
4106 Use int, not unsigned, since we prefer signed and the signedness
4107 doesn't matter here.
4108 (get_next_display_element, next_element_from_display_vector):
4109 Use int, not EMACS_INT, when int is wide enough.
4110 (start_hourglass): Use duration_to_sec_usec to do proper
4111 overflow checking on durations.
4112 * xfaces.c (Fbitmap_spec_p):
4113 Check that fixnums are in proper range for system types.
4114 (compare_fonts_by_sort_order):
4115 Avoid mishandling comparisons due to subtraction overflow.
4116 (Fx_family_fonts, realize_basic_faces):
4117 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4118 (Fx_family_fonts):
4119 Don't assume fixnum fits in int.
4120 Use SAFE_ALLOCA_LISP, not alloca.
4121 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4122 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4123 (face_at_buffer_position, face_for_overlay_string)
4124 (face_at_string_position):
4125 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4126 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4127 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4128 (Fx_show_tip):
4129 Check that fixnums are in proper range for system types.
4130 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4131 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4133 (Fx_change_window_property): Don't assume fixnums fit in int.
4134 * xfont.c (xfont_chars_supported):
4135 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4136 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4137 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4138 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4139 * xml.c (parse_region):
4140 * xrdb.c (magic_file_p):
4141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4142 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4143 (x_get_local_selection, x_reply_selection_request)
4144 (x_handle_selection_request, wait_for_property_change):
4145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4146 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4147 short is wide enough.
4148 (x_send_client_event): Don't assume fixnum fits in int.
4149 * xterm.c (x_x_to_emacs_modifiers):
4150 Don't assume EMACS_INT overflows nicely into int.
4151 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4152 may come from Lisp.
4153 (handle_one_xevent): NATNUMP can eval its arg twice.
4154 (x_connection_closed):
4155 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4156 * xterm.h: Adjust decls to match defn changes elsewhere.
4157 (struct scroll_bar): Use struct vectorlike_header
4158 rather than rolling our own approximation.
4159 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4160
c6574eb5
GM
41612012-05-25 Glenn Morris <rgm@gnu.org>
4162
4163 * lisp.mk (lisp): Update for more files being compiled now.
4164
e8d32c7e
SM
41652012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4166
48def666
SM
4167 * lread.c: Remove `read_pure' which makes no difference.
4168 (read_pure): Remove var.
4169 (unreadpure): Remove function.
4170 (readevalloop): Don't call read_list with -1 flag.
4171 (read1, read_vector): Don't test read_pure any more.
4172 (read_list): Simplify.
4173
e8d32c7e
SM
4174 * fileio.c, character.h: Minor style tweaks.
4175
4b2addb7
DA
41762012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4177
4178 * window.h (clip_changed): Remove useless declaration.
4179
584461b2
JB
41802012-05-22 Juanma Barranquero <lekktu@gmail.com>
4181
4182 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4183 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4184
34374650
PE
41852012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4186
4187 Remove src/m/*.
4188 This directory predates autoconf and is no longer needed nowadays.
4189 Move its few remaining bits of functionality to where they're needed.
4190 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4191 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4192 * m/template.h: Remove.
4193 * Makefile.in (M_FILE): Remove. All uses removed.
4194 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4195 * lisp.h (USE_LSB_TAG):
4196 * mem-limits.h (EXCEEDS_LISP_PTR):
4197 Use VAL_MAX, not VALBITS, in #if.
4198 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4199 (EMACS_UINT): Define unconditionally now.
4200 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4201 (BITS_PER_EMACS_INT): New constants, replacing
4202 what used to be in config.h, but not useful in #if.
4203 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4204 define them any more.
4205 (VAL_MAX): New macro.
4206 (VALMASK): Use it.
4207 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4208 BITS_PER_EMACS_INT, in #if.
4209 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4210 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4211 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4212 * s/ms-w32.h (DATA_START):
4213 Move here from removed file m/intel386.h.
4214 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4215 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4216
261cb4bb
PE
42172012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4218
4219 Assume C89 or later.
4220 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4221 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4222 (xrealloc):
4223 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4224 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4225 * textprop.c, tparam.c (NULL): Remove.
4226 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4227 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4228 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4229 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4230 * xterm.c (input_signal_count): Assume volatile works.
4231
ff23cd9f
KB
42322012-05-21 Ken Brown <kbrown@cornell.edu>
4233
4234 * xgselect.c (xg_select): Fix first argument in call to 'select'
4235 (bug#11508).
4236
1b170bc6
KB
42372012-05-20 Ken Brown <kbrown@cornell.edu>
4238
4239 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4240 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4241
b2f4d39f
KB
42422012-05-19 Ken Brown <kbrown@cornell.edu>
4243
4244 * xfns.c (x_in_use): Remove `static' qualifier.
4245 * xterm.h (x_in_use): Declare.
4246 * xgselect.c: Include xterm.h.
4247 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4248 and `display_arg' (bug#9754).
4249
003fdae2
PE
42502012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4251
9232a6d9
PE
4252 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4253
003fdae2
PE
4254 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4255 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4256
784b56e2
EZ
42572012-05-18 Eli Zaretskii <eliz@gnu.org>
4258
4259 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4260
4261 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4262 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4263
4264 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4265 reference to image_cache->refcount.
4266 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4267
a0a79cde
JL
42682012-05-17 Juri Linkov <juri@jurta.org>
4269
4270 * search.c (Fword_search_regexp, Fword_search_backward)
4271 (Fword_search_forward, Fword_search_backward_lax)
4272 (Fword_search_forward_lax): Move functions to isearch.el
4273 (bug#10145, bug#11381).
4274
b0572523
PE
42752012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4276
4277 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4278
9660f5fc
SM
42792012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4280
4281 * lread.c (init_obarray): Declare Qt and Qnil as special.
4282
4374de83
GM
42832012-05-14 Glenn Morris <rgm@gnu.org>
4284
4285 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4286 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4287
dc44c39a
PE
42882012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4289
078c97cb
PE
4290 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4291
dc44c39a
PE
4292 * unexaix.c: Port to more-recent AIX compilers.
4293 (report_error, report_error_1, make_hdr, copy_sym)
4294 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4295 Make arguments const char *, not char *, to avoid violations of C
4296 standard and to fix some AIX warnings reported by Gilles Pion.
4297
e18afed7 42982012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4299
4300 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4301 already have overlays loaded.
4302 (handle_single_display_spec): Before returning without displaying
4303 fringe bitmap, synchronize the bidi iterator with the main display
4304 iterator, by calling iterate_out_of_display_property.
4305 (iterate_out_of_display_property): Detect buffer iteration by
4306 testing that it->string is a Lisp string.
4307 (get_next_display_element): When the current object is exhausted,
4308 and there's something on it->stack, call set_iterator_to_next to
4309 proceed with what's on the stack, instead of returning zero.
4310 (set_iterator_to_next): If called at the end of a Lisp string,
4311 proceed to consider_string_end without incrementing string
4312 position. Don't increment display vector index past the end of
4313 the display vector. (Bug#11417)
c8fb9dc6
EZ
4314 (pos_visible_p): Don't report a position visible when move_it_to
4315 stopped at the last line of window, which happens to be scanned
4316 backwards by the bidi iteration. (Bug#11464)
ac268e67 4317
e18afed7 43182012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4319
4320 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4321 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4322 are on a TTY, and thus unable to display on the fringes.
4323 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4324 so we need to signal to the caller that this is a "replacing"
4325 display spec. This fixes display when the spec is invalid or we
4326 are on a TTY.
4327
e18afed7 43282012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4329
4330 * unexaix.c (make_hdr): Fix typo in prototype.
4331 This bug broke the build on AIX. Problem reported by Gilles Pion.
4332
9d0a235a
MA
43332012-05-14 Michael Albinus <michael.albinus@gmx.de>
4334
4335 * keyboard.c (kbd_buffer_get_event): Read special events also in
4336 batch mode. (Bug#11415)
4337
9e6b06ed
GM
43382012-05-12 Glenn Morris <rgm@gnu.org>
4339
4340 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4341
c1a1d7a3
EZ
43422012-05-12 Eli Zaretskii <eliz@gnu.org>
4343
4344 * lisp.mk (lisp): Add newcomment.elc.
4345
3fe7cdc8
GM
43462012-05-12 Glenn Morris <rgm@gnu.org>
4347
4348 * Makefile.in (MKDIR_P): New, set by configure.
4349 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4350
53f7d2c0
PE
43512012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4352
4353 Remove unused function hourglass_started.
4354 * dispextern.h (hourglass_started):
4355 * w32fns.c (hourglass_started):
4356 * xdisp.c (hourglass_started): Remove.
4357
75aafb17
JB
43582012-05-10 Juanma Barranquero <lekktu@gmail.com>
4359
4360 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4361 Update dependencies.
4362
12959e8e
PE
43632012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4364
97107e2e
PE
4365 * xgselect.c (xg_select): Put maxfds+1 into a var.
4366 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4367
12959e8e
PE
4368 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4369
836d29b3
DA
43702012-05-10 Dave Abrahams <dave@boostpro.com>
4371
4372 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4373 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4374
5cb67954
MA
43752012-05-09 Michael Albinus <michael.albinus@gmx.de>
4376
4377 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4378 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4379 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4380 Initialize xd_registered_buses.
4381
3478ec45
PE
43822012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4383
b263a6b0
PE
4384 Untag more efficiently if USE_LSB_TAG.
4385 This is based on a proposal by YAMAMOTO Mitsuharu in
4386 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4387 For an admittedly artificial (nth 8000 longlist) benchmark on
4388 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4389 Emacs's overall text size by 1%.
4390 * lisp.h (XUNTAG): New macro.
4391 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4392 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4393 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4394 * eval.c (Fautoload):
4395 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4396 * frame.h (XFRAME): Use XUNTAG.
4397
3478ec45
PE
4398 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4399 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4400 Remove unportable assumptions about print widths of types like
4401 dbus_uint32_t.
4402 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4403 intptr_t when converting between pointer and integer, to avoid GCC
4404 warnings about wrong width.
4405
666b903b 44062012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4407
4408 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4409 stack for each reader_thread, instead of defaulting to 8MB
4410 determined by the linker. This avoids failures in creating
4411 subprocesses on Windows 7, see the discussion in this thread:
4412 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4413
b120cc17
JC
44142012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4415
4416 Fix up display of the *Minibuf-0* buffer in the mini window.
4417 * keyboard.c (read_char): Don't clear the echo area if there's no
4418 message to clear.
4419 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4420 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4421
9a4b36f8
MA
44222012-05-07 Michael Albinus <michael.albinus@gmx.de>
4423
4424 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4425 batch mode.
4426
e5f9458f
CY
44272012-05-06 Chong Yidong <cyd@gnu.org>
4428
4429 * lisp.mk (lisp): Update.
4430
eceeb5fc 44312012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4432
4433 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4434
71873e2b
SM
44352012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4436
4437 * data.c (PUT_ERROR): New macro.
4438 (syms_of_data): Use it. Add new error type `user-error'.
4439 * undo.c (user_error): New function.
4440 (Fprimitive_undo): Use it.
4441 * print.c (print_error_message): Adjust print style for `user-error'.
4442 * keyboard.c (user_error): New function.
4443 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4444
ab0fa4e4
PE
44452012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4446
4447 Do not limit current-time-string to years 1000..9999.
4448 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4449 (Fcurrent_time_string): Support any year that is supported by the
4450 underlying localtime representation. Don't use asctime, as it
4451 has undefined behavior for years outside the range -999..9999.
4452
7ed806a7
PE
44532012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4454
4455 Fix race conditions involving setenv, gmtime, localtime, asctime.
4456 Without this fix, interrupts could mess up code that uses these
4457 nonreentrant functions, since setting TZ invalidates existing
4458 tm_zone or tzname values, and since most of these functions return
4459 pointers to static storage.
4460 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4461 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4462 Grow the critical sections to include not just invoking
4463 localtime/gmtime, but also accessing these functions' results
4464 including their tm_zone values if any, and any related TZ setting.
4465 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4466 so that the struct tm is saved in the critical section.
4467 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4468 motivated by the fact that memory allocation needs to be outside
4469 the critical section.
4470
0c16dfed
DA
44712012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4472
4473 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4474 with RESET_INTERVAL.
4475
4476 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4477 Remove duplicated buffer name initialization.
4478
3f83ace8
JM
44792012-05-02 Jim Meyering <jim@meyering.net>
4480
4481 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4482
c7b8541e
JM
4483 * xfns.c (x_window): Use xstrdup (Bug#11375).
4484
90207a15 44852012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4486
4487 * xdisp.c (pos_visible_p): If already at a newline from the
4488 display string before the 'while' loop, don't walk back the glyphs
4489 from it3.glyph_row. Solves assertion violation when the display
4490 string begins with a newline (egg.el). (Bug#11367)
4491
b593d6a9
AH
44922012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4493
4494 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4495 Move to simple.el.
4496
4737362e
GM
44972012-05-01 Glenn Morris <rgm@gnu.org>
4498
99cf43f9
GM
4499 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4500 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4501 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4502 All were removed before 23.1.
4503
9311dcff
GM
4504 * dispnew.c: Remove HAVE_LIBNCURSES test;
4505 it is always true on relevant platforms.
4506
4d5c6349
GM
4507 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4508 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4509
4737362e
GM
4510 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4511
74dd3a6b
AS
45122012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4513
4514 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4515 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4516 Remove.
4517
13c379ee
PE
45182012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4519
4520 Do not avoid creating empty evaporating overlays (Bug#9642).
4521 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4522 That is, do not delete an evaporating overlay if it becomes
4523 empty after its bounds are adjusted to fit within its buffer.
4524 This fix caused other problems, and I'm reverting it until we get
4525 to the bottom of them.
4526
a8e7d6d7 45272012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4528
4529 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4530
a8e7d6d7 45312012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4532
4533 * xdisp.c (pos_visible_p): If the window start position is beyond
4534 ZV, start the display from buffer beginning. Prevents assertion
4535 violation in init_iterator when the minibuffer window is scrolled
4536 via the scroll bar.
4537
4538 * window.c (window_scroll_pixel_based): Likewise.
4539
a8e7d6d7 45402012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4541
4542 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4543
a8e7d6d7 45442012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4545
4546 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4547 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4548
a8e7d6d7 45492012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4550
b593d6a9
AH
4551 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4552 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4553
1c6900d9
EZ
45542012-04-26 Eli Zaretskii <eliz@gnu.org>
4555
4c3fa1d9
EZ
4556 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4557 display element, check also the underlying string or buffer
4558 character. (Bug#11341)
4559
1c6900d9
EZ
4560 * w32menu.c: Include w32heap.h.
4561 (add_menu_item): If the call to AppendMenuW (via
4562 unicode_append_menu) fails, disable Unicode menus only if we are
4563 running on Windows 9X/Me.
4564
42bf8205
AS
45652012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4566
4567 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4568 (xgetint): Add missing shift for LSB tags.
4569
b1bac16e
MR
45702012-04-24 Martin Rudalics <rudalics@gmx.at>
4571
4572 * keyboard.c (read_char): Don't wipe echo area for select window
4573 events: These might get delayed via `mouse-autoselect-window'
4574 (Bug#11304).
4575
d69621cc
JB
45762012-04-24 Juanma Barranquero <lekktu@gmail.com>
4577
4578 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4579 manipulation of :loaded-from data.
4580
02fd101b
JB
45812012-04-23 Juanma Barranquero <lekktu@gmail.com>
4582
4583 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4584 now a cons (bug#11311).
4585
888bec30
PE
45862012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4587
89a438bd
PE
4588 Do not create empty overlays with the evaporate property (Bug#9642).
4589 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4590 if it becomes empty after its bounds are adjusted to fit within
4591 its buffer. Without this fix, in a nonempty buffer (let ((o
4592 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4593 yields an empty overlay that has the evaporate property, which is
4594 not supposed to happen.
4595
1068fe4d
PE
4596 Fix minor GTK3 problems found by static checking.
4597 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4598 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4599 (struct _EmacsFixedClass, emacs_fixed_get_type):
4600 Move decls here from emacsgtkfixed.h, since they needn't be public.
4601 (emacs_fixed_get_type): Now static.
4602 (emacs_fixed_class_init): Omit unused local.
4603 (emacs_fixed_child_type): Remove; unused.
4604 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4605 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4606 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4607 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4608 (EMACS_FIXED_GET_CLASS): Remove; unused.
4609 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4610
888bec30
PE
4611 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4612 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4613
de85e130
PE
46142012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4615
d0baac98 4616 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4617 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4618 (__malloc_size_t, __malloc_ptrdiff_t):
4619 Remove. All uses removed, replaced by the definiens if needed,
4620 since we can assume C89 or better now.
4621 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4622 (protect_malloc_state, align, get_contiguous_space)
4623 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4624 (malloc_atfork_handler_child, malloc_enable_thread)
4625 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4626 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4627 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4628 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4629 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4630 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4631 Define using prototypes, not old style.
4632 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4633 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4634 (align): Don't assume that signed integer overflow wraps around.
4635 Omit unused local var.
4636 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4637 (_free_internal_nolock, memalign, mallochook, reallochook):
4638 Omit no-longer-needed casts.
4639 (valloc): Use getpagesize, not __getpagesize.
4640 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4641 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4642
de85e130
PE
4643 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4644
dcbf5805
MA
46452012-04-22 Michael Albinus <michael.albinus@gmx.de>
4646
4647 Move functions from C to Lisp. Make non-blocking method calls
4648 the default. Implement further D-Bus standard interfaces.
4649
4650 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4651 (QCdbus_request_name_allow_replacement)
4652 (QCdbus_request_name_replace_existing)
4653 (QCdbus_request_name_do_not_queue)
4654 (QCdbus_request_name_reply_primary_owner)
4655 (QCdbus_request_name_reply_in_queue)
4656 (QCdbus_request_name_reply_exists)
4657 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4658 (QCdbus_registered_serial, QCdbus_registered_method)
4659 (QCdbus_registered_signal): New Lisp objects.
4660 (XD_DEBUG_MESSAGE): Use sizeof.
4661 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4662 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4663 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4664 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4665 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4666 (xd_signature, xd_append_arg): Allow float for integer types.
4667 (xd_get_connection_references): New function.
b593d6a9
AH
4668 (xd_get_connection_address): Rename from xd_initialize.
4669 Return cached address.
dcbf5805
MA
4670 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4671 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4672 level.
4673 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4674 Return number of refcounts.
dcbf5805
MA
4675 (Fdbus_get_unique_name): Make stronger parameter check.
4676 (Fdbus_message_internal): New defun.
4677 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4678 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4679 (Fdbus_send_signal, Fdbus_register_service)
4680 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4681 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4682 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4683 (Vdbus_compiled_version, Vdbus_runtime_version)
4684 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4685 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4686 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4687 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4688 Adapt docstring.
dcbf5805 4689
52828e02
PE
46902012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4691
da05bc4c
PE
4692 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4693 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4694 Do not assume ptrdiff_t is the same width as 'int'.
4695
52828e02
PE
4696 * alloc.c: Handle unusual debugging option combinations.
4697 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4698 since the two debugging options are incompatible.
4699 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4700 is defined.
4701 (mem_init, mem_insert, mem_insert_fixup):
4702 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4703 (NEED_MEM_INSERT): Remove; no longer needed.
4704
f01769f9
LL
47052012-04-22 Leo Liu <sdl.web@gmail.com>
4706
4707 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4708
5790543d
PE
47092012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4710
4711 * sysdep.c [__FreeBSD__]: Minor cleanups.
4712 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4713 Use Emacs indenting style more consistently. Avoid some casts.
4714 Use 'double' consistently rather than mixing 'float' and 'double'.
4715
b91b7e4d
EW
47162012-04-21 Eduard Wiebe <usenet@pusto.de>
4717
b593d6a9
AH
4718 * sysdep.c (list_system_processes, system_process_attributes):
4719 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4720
6114eb15
AS
47212012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4722
4723 * lisp.mk (lisp): Update.
4724
2f38dff7
PE
47252012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4726
4727 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4728 It is never used otherwise.
4729
4ae29f89
SM
47302012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4731
4732 * print.c (print_preprocess): Only check print_depth if print-circle
4733 is nil.
4734 (print_object): Check for cycles even when print-circle is nil and
4735 print-gensym is t, but only check print_depth if print-circle is nil.
4736
f30d612a
CY
47372012-04-20 Chong Yidong <cyd@gnu.org>
4738
4739 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4740 set the status to "failed" and ensure that sentinel is run.
4741
c07a4c0b 47422012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4743
4744 * process.c (Fset_process_inherit_coding_system_flag)
4745 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4746 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4747
c07a4c0b 47482012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4749
4750 * xdisp.c (string_buffer_position_lim): Limit starting position to
4751 BEGV.
4752 (set_cursor_from_row): If called for a mode-line or header-line
4753 row, return zero immediately.
4754 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4755 farther than the first row after the header line, if any.
4756 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4757 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4758
c07a4c0b 47592012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4760
4ae29f89
SM
4761 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4762 (bug#11238).
ad3a2b41 4763
c07a4c0b 47642012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 47652012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4766
4767 configure: new option --enable-gcc-warnings (Bug#11207)
4768 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4769 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4770 (ALL_CFLAGS): Use new macros rather than old.
4771 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4772 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4773 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4774 -Wunused-result, -Wunused-variable. This should go away once
4775 the Emacs and Gnulib regex code is merged.
4776 (xmalloc, xrealloc): Now static.
4777
aba027e8
PE
47782012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4779
4780 * dired.c (Fsystem_groups): Remove unused local.
4781
e5a36063
GM
47822012-04-17 Glenn Morris <rgm@gnu.org>
4783
4784 * dired.c (Fsystem_users): Doc fix.
4785
316411f0
DA
47862012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4787
4788 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4789 (syms_of_dired): Add them.
4790
9426aba4
PE
47912012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4792
b62a57be
PE
4793 Fix minor alloc.c problems found by static checking.
4794 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4795 New extern decls, to avoid calling undeclared functions.
4796 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4797 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4798 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4799 (NEED_MEM_INSERT): New macro.
4800 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4801 Remove one incorrect comment and fix another.
b62a57be 4802
3539f31f
PE
4803 Fix minor ralloc.c problems found by static checking.
4804 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4805 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4806 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4807 (r_alloc_sbrk): Now static.
4808
a041960a
PE
4809 Improve ralloc.c interface checking.
4810 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4811 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4812 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4813 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4814 [REL_ALLOC]: ... to here, to check interface.
4815 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4816 Remove decls. This fixes an "It stinks!".
4817
9426aba4
PE
4818 * alloc.c (which_symbols): Fix alignment issue / type clash.
4819
d55c12ed
AS
48202012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4821
4822 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4823 (struct Lisp_Misc_Any): Likewise.
4824 (struct Lisp_Free): Likewise.
4825 * alloc.c (union aligned_Lisp_Symbol): Define.
4826 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4827 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4828 (union aligned_Lisp_Misc): Define.
4829 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4830 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4831 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4832
b948ce8b
PE
48332012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4834
4835 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4836 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4837 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4838 * s/netbsd.h, s/sol2-6.h:
4839 Remove definition of GC_MARK_STACK, since the default now works.
4840 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4841 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4842 no longer the default.
4843 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4844
35dc09a1 48452012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4846
35dc09a1
GM
4847 * lread.c (lisp_file_lexically_bound_p):
4848 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4849
35dc09a1
GM
48502012-04-14 Eli Zaretskii <eliz@gnu.org>
4851
4852 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4853 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4854
48552012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4856
4857 * nsterm.m (constrainFrameRect): Always constrain when there is only
4858 one screen (Bug#10962).
4859
bcd86815
KB
48602012-04-13 Ken Brown <kbrown@cornell.edu>
4861
4862 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4863
c25df26e
RT
48642012-04-13 Reuben Thomas <rrt@sc3d.org>
4865
4866 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4867
0fc59f1e
DC
48682012-04-11 Daniel Colascione <dancol@dancol.org>
4869
4870 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4871 against is gone. It's better to use vfork now so that when Cygwin
4872 gains a new, working vfork, we use it automatically (bug#10398).
4873
de8c03dc
SM
48742012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4875
4876 * window.c (save_window_save): Obey window-point-insertion-type.
4877
2f097256
GM
48782012-04-11 Glenn Morris <rgm@gnu.org>
4879
4880 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4881
453b951e
SM
48822012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4883
4884 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4885
75f1671a 48862012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4887
4888 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4889 (force_quit_count): New var.
4890 (handle_interrupt): Use it.
4891
2a8ce227
JB
48922012-04-10 Juanma Barranquero <lekktu@gmail.com>
4893
4894 * w32.c (w32_delayed_load): Record the full path of the library
4895 being loaded (bug#10424).
4896
935396c0
GM
48972012-04-09 Glenn Morris <rgm@gnu.org>
4898
05920a43
GM
4899 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4900 not just in the obarray, before snarfing them. (Bug#11036)
4901
935396c0
GM
4902 * Makefile.in ($(leimdir)/leim-list.el):
4903 Pass EMACS rather than BUILT_EMACS.
4904
a18ecafa
TZ
49052012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4906
4907 * process.c (make_process):
4908 * process.h: Add integer `gnutls_handshakes_tried' member to
4909 process struct.
4910
6bbef4e5
JC
4911 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4912 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4913
4914 * gnutls.c (gnutls_log_function2i): Convenience log function.
4915 (emacs_gnutls_read): Use new log functions,
4916 `gnutls_handshakes_tried' process member, and
4917 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4918 attempts per process (connection).
4919
b4d3bc10
CY
49202012-04-09 Chong Yidong <cyd@gnu.org>
4921
4922 * eval.c (Fuser_variable_p, user_variable_p_eh)
4923 (lisp_indirect_variable): Functions deleted.
4924 (Fdefvar): Caller changed.
4925
4926 * callint.c (Finteractive, Fcall_interactively):
4927 * minibuf.c (Fread_variable): Callers changed.
4928
70f4d973
EZ
49292012-04-09 Eli Zaretskii <eliz@gnu.org>
4930
4931 * xdisp.c (set_cursor_from_row): If the display string appears in
4932 the buffer at position that is closer to point than the position
4933 after the display string, display the cursor on the first glyph of
4934 the display string. Fixes cursor display when a 'display' text
4935 property immediately follows invisible text. (Bug#11094)
4936
cb3c2e3e
PE
49372012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4938
4939 composite.c: use 'double' consistently
4940 * composite.c (get_composition_id): Use 'double' consistently
4941 instead of converting 'float' to 'double' and vice versa; this is
4942 easier to understand and avoids a GCC warning.
4943
fd06db5d
GM
49442012-04-09 Glenn Morris <rgm@gnu.org>
4945
50fe702a
GM
4946 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4947 preparation for dumping it with emacs. (Bug#4789)
4948 (leimdir): New variable.
4949 ($(leimdir)/leim-list.el): New rule.
4950 (emacs$(EXEEXT)): Depend on leim-list.el.
4951
fd06db5d
GM
4952 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4953 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4954 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4955
55c131ee
AS
49562012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4957
4958 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4959 proper alignment.
4960
9209588f
JB
49612012-04-07 Juanma Barranquero <lekktu@gmail.com>
4962
4963 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4964 Remove unused local variable.
4965
e3fb2efb
PE
49662012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4967
4968 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4969 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4970 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4971 objects, as mark_maybe_pointer will catch them otherwise.
4972 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4973 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4974
b5385551
PE
49752012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4976
4977 Fix typo that broke non-Windows builds.
4978 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4979
9078ead6
EZ
49802012-04-07 Eli Zaretskii <eliz@gnu.org>
4981
4982 Support building on MS-Windows with libxml2.
4983
4984 * makefile.w32-in (OBJ2): Add xml.$(O).
4985 (GLOBAL_SOURCES): Add xml.c.
4986 ($(BLD)/xml.$(O)): New dependency list.
4987
4988 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4989 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4990 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4991 [!WINDOWSNT]: New macros.
4992 (init_libxml2_functions, libxml2_loaded_p): New functions.
4993 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4994 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4995 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4996 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4997 linked in).
6bbef4e5
JC
4998 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4999 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5000 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5001
5002 * emacs.c: Don't include libxml/parser.h.
5003 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5004 xmlCleanupParser directly.
5005
5006 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5007
3811fdf3
EZ
50082012-04-07 Eli Zaretskii <eliz@gnu.org>
5009
5010 * indent.c (Fvertical_motion): If there is a display string at
5011 point, use it.vpos to compute how many lines to backtrack after
5012 move_it_to point. (Bug#11133)
5013
2f8e16b2
EZ
50142012-04-06 Eli Zaretskii <eliz@gnu.org>
5015
5016 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5017 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5018 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5019 macros related to unification of CJK characters. For the details,
5020 see the discussion following the message here:
5021 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5022
3d439cd1
CY
50232012-04-04 Chong Yidong <cyd@gnu.org>
5024
5025 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5026
8bc53d00
EZ
50272012-04-01 Eli Zaretskii <eliz@gnu.org>
5028
5029 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5030 instead of alloca. (Bug#11138)
5031
3b0512a3
AS
50322012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5033
5034 * w32menu.c (is_simple_dialog): Properly check lisp types.
5035 (Bug#11141)
5036
8427ddd2
EZ
50372012-03-31 Eli Zaretskii <eliz@gnu.org>
5038
979022ef
EZ
5039 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5040 position we get to after a call to move_it_to fails the
5041 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5042 only if we wind up in a string from display property. (Bug#11063)
5043
a6b1c7cc
EZ
5044 * window.c (Fdelete_other_windows_internal): Invalidate the row
5045 and column information about mouse highlight, so that redisplay
5046 restores it after reallocating the glyph matrices. (Bug#7464)
5047
8427ddd2
EZ
5048 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5049 string comes from a `display' text property, use the buffer
5050 position of that property as if we actually saw that position in
5051 the row's glyphs.
697ba24b
EZ
5052 (move_it_by_lines): Remove the assertion that
5053 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5054 violated when there's a before-string at the beginning of a line.
5055 (Bug#11063)
8427ddd2 5056
65a0a738
EZ
50572012-03-30 Eli Zaretskii <eliz@gnu.org>
5058
5059 * xdisp.c (append_space_for_newline): If the default face was
5060 remapped, use the remapped face for the appended newline.
5061 (extend_face_to_end_of_line): Use the remapped default face for
5062 extending the face to the end of the line.
5063 (display_line): Call extend_face_to_end_of_line when the default
5064 face was remapped. (Bug#11068)
5065
581355cc
EZ
50662012-03-29 Eli Zaretskii <eliz@gnu.org>
5067
5068 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5069
e8fc049f
SM
50702012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5071
5072 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5073
4fb9a543
GM
50742012-03-27 Glenn Morris <rgm@gnu.org>
5075
5076 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5077 Doc fixes.
5078
679910f1
KH
50792012-03-26 Kenichi Handa <handa@m17n.org>
5080
5081 * dispextern.h (struct glyph): Fix previous change. Change the
5082 bit length of glyphless.ch to 25 (Bug#11082).
5083
90d49b7f
CY
50842012-03-26 Chong Yidong <cyd@gnu.org>
5085
5086 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5087 (command_loop_1): Use it; inhibit selection update for
5088 handle-select-window too (Bug#8996).
5089
f514f6f0
FP
50902012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5091
e8fc049f 5092 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5093
bf43fa51
KH
50942012-03-25 Kenichi Handa <handa@m17n.org>
5095
5096 * dispextern.h (struct glyph): Change the bit length of
5097 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5098
8a0c01dd
EZ
50992012-03-24 Eli Zaretskii <eliz@gnu.org>
5100
5101 * s/ms-w32.h (tzname): Include time.h before redirecting to
5102 _tzname. Fixes the MSVC build. (Bug#9960)
5103
7d1c3a76
AS
51042012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5105
8ed79523
AS
5106 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5107 characters.
5108
7d1c3a76
AS
5109 * xterm.c (XTread_socket): Only modify handling_signal if
5110 !SYNC_INPUT. (Bug#11080)
5111
e99a9b8b
EZ
51122012-03-23 Eli Zaretskii <eliz@gnu.org>
5113
5114 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5115 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5116 when fetching a multibyte character consumes more bytes than
5117 CHAR_BYTES returns, due to unification of CJK characters in
5118 string_char. (Bug#11073)
5119
5063c0e1
TN
51202012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5121
5122 * process.c (wait_reading_process_output): Handle pty disconnect
5123 by refraining from sending oneself a SIGCHLD (bug#10933).
5124
9f851fbd
CY
51252012-03-22 Chong Yidong <cyd@gnu.org>
5126
5127 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5128
5063c0e1 5129 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5130 Mark string as coming from a prefix property.
5131 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5132 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5133
fb5b8aca
CY
51342012-03-21 Chong Yidong <cyd@gnu.org>
5135
5136 * xfaces.c (Vface_remapping_alist): Doc fix.
5137
62356a1b
EZ
51382012-03-20 Eli Zaretskii <eliz@gnu.org>
5139
5140 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5141 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5142 Doc fixes.
62356a1b 5143
025de85b
CY
51442012-03-20 Chong Yidong <cyd@gnu.org>
5145
5146 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5147 to reflect default non-nil value of redisplay-dont-pause.
5148
4827f94e
KH
51492012-03-19 Kenichi Handa <handa@m17n.org>
5150
5151 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5152 it fit in a valid range (Bug#11003).
5153
e50a24a2
EZ
51542012-03-18 Eli Zaretskii <eliz@gnu.org>
5155
5156 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5157 that is not from display property, accept the row as a "cursor
5158 row" if one of the string's character has a non-nil `cursor'
5159 property. Fixes cursor positioning when there are newlines in
5160 overlay strings, e.g. in icomplete.el. (Bug#11035)
5161
9af5ed87
PE
51622012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5163
5164 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5165
d1f55f16
CY
51662012-03-12 Chong Yidong <cyd@gnu.org>
5167
5168 * eval.c (inhibit_lisp_code): Rename from
5169 inhibit_window_configuration_change_hook; move from window.c.
5170
5171 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5172 * window.c (run_window_configuration_change_hook)
5173 (syms_of_window): Callers changed.
5174
66c5eebd
CY
51752012-03-11 Chong Yidong <cyd@gnu.org>
5176
413df973
CY
5177 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5178
66c5eebd
CY
5179 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5180
1de11f56
CY
51812012-03-10 Chong Yidong <cyd@gnu.org>
5182
5183 * frame.c (other_visible_frames): Don't assume the selected frame
5184 is visible (Bug#10955).
5185
cae07000
SM
51862012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5187
5188 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5189
89c94350
JD
51902012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5191
5192 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5193 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5194 zero (Bug#10954).
5195
999dd333
GM
51962012-03-03 Glenn Morris <rgm@gnu.org>
5197
01a6dcc8 5198 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5199
de0100f2
EZ
52002012-03-02 Eli Zaretskii <eliz@gnu.org>
5201
5202 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5203 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5204 (redisplay_window, next_element_from_string): Fix typos in
5205 comments.
3e441275
EZ
5206 (redisplay_window): Pass to move_it_vertically the margin in
5207 pixels, not in screen lines.
de0100f2 5208
96a72ee9
GM
52092012-03-02 Glenn Morris <rgm@gnu.org>
5210
5211 * buffer.c (buffer-list-update-hook): Doc fix.
5212
312508d7
EZ
52132012-02-29 Eli Zaretskii <eliz@gnu.org>
5214
5215 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5216 push_it before setting up the iterator for the first overlay
5217 string, even if we have an empty string loaded.
5218 (next_overlay_string): If there's an empty string on the iterator
5219 stack, pop the stack. (Bug#10903)
5220
27f3c637
PE
52212012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5222
5223 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5224 Suggested by Stefan Monnier in
5225 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5226 * alloc.c (widen_to_Lisp_Object): New static function.
5227 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5228 and widening them to Lisp_Objects. This would work even if
5229 USE_LSB_TAG is defined and wide integers are used, which might
5230 happen in a future version of Emacs.
5231
3c9dfce6
CY
52322012-02-25 Chong Yidong <cyd@gnu.org>
5233
fa74b241
CY
5234 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5235 Doc fix.
5236
3c9dfce6
CY
5237 * xselect.c (Fx_selection_exists_p): Doc fix.
5238 (x_clipboard_manager_save_all): Print an informative message
5239 before saving to clipboard manager.
5240
9486df08
CY
52412012-02-24 Chong Yidong <cyd@gnu.org>
5242
5243 * keyboard.c (process_special_events): Handle all X selection
5244 requests in kbd_buffer, not just the next one (Bug#8869).
5245
f01d3321
CY
52462012-02-23 Chong Yidong <cyd@gnu.org>
5247
5248 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5249 call when setting menu-bar-lines and tool-bar-lines parameters.
5250 (unwind_create_frame_1): New helper function.
5251
5252 * window.c (inhibit_window_configuration_change_hook): New var.
5253 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5254 (syms_of_window): Initialize it.
f01d3321 5255
86b847b6
CY
52562012-02-22 Chong Yidong <cyd@gnu.org>
5257
5258 * xterm.c (x_draw_image_relief): Add missing type check for
5259 Vtool_bar_button_margin (Bug#10743).
5260
a59225b1
CY
52612012-02-21 Chong Yidong <cyd@gnu.org>
5262
5263 * fileio.c (Vfile_name_handler_alist): Doc fix.
5264
5265 * buffer.c (Fget_file_buffer): Protect against invalid file
5266 handler return value.
5267
310f5bd4
PE
52682012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5269
cb3a28cc
PE
5270 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5271 when computing $valmask.
5272
310f5bd4
PE
5273 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5274 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5275 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5276 It's useless in that case, and it can cause problems on hosts
5277 that allocate halves of EMACS_INT values separately.
5278 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5279 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5280 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5281 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5282 it avoids undefined behavior on hosts where shifting right by more
5283 than the word width has undefined behavior.
5284
2375c96a
CY
52852012-02-19 Chong Yidong <cyd@gnu.org>
5286
5287 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5288 (Funhandled_file_name_directory, Ffile_name_as_directory)
5289 (Fdirectory_file_name, Fexpand_file_name)
5290 (Fsubstitute_in_file_name): Protect against invalid file handler
5291 return values (Bug#10845).
5292
3eb49e71
EZ
52932012-02-18 Eli Zaretskii <eliz@gnu.org>
5294
5295 * .gdbinit (pitx): Fix incorrect references to fields of the
5296 iterator stack.
5297
7b926f3f
CY
52982012-02-17 Chong Yidong <cyd@gnu.org>
5299
5300 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5301
11273115
PE
53022012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5303
5304 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5305 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5306
c3a70e2b
CY
53072012-02-15 Chong Yidong <cyd@gnu.org>
5308
5309 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5310 marked as special. Also, starting docstrings with * is obsolete.
5311
0ca43699
AS
53122012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5313
5314 * gnutls.c (emacs_gnutls_write): Fix last change.
5315
2e8f3c56
LI
53162012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5317
5318 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5319 send_process.
5320
af70074f
SM
53212012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5322
5323 * keymap.c (Fsingle_key_description): Handle char ranges.
5324
95986d52
CY
53252012-02-12 Chong Yidong <cyd@gnu.org>
5326
afd83bd1
CY
5327 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5328 as that creates a dangerous corner case.
5329
95986d52
CY
5330 * window.c (Fdelete_window_internal): Invalidate the mouse
5331 highlight (Bug#9904).
5332
bd7da63e
GM
53332012-02-12 Glenn Morris <rgm@gnu.org>
5334
5335 * xselect.c (Fx_own_selection_internal)
5336 (Fx_get_selection_internal, Fx_disown_selection_internal)
5337 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5338 * nsselect.m (Fx_own_selection_internal)
5339 (Fx_disown_selection_internal, Fx_selection_exists_p)
5340 (Fx_selection_owner_p, Fx_get_selection_internal):
5341 Sync docs and argument specs with the xselect.c versions.
5342
77abcbc2
LI
53432012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5344
5345 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5346
90b671e2
EZ
53472012-02-11 Eli Zaretskii <eliz@gnu.org>
5348
1c0ca0b7
EZ
5349 * w32select.c (Fx_selection_exists_p): Sync doc string and
5350 argument list with xselect.c. (Bug#10783)
5351
5352 * w16select.c (Fx_selection_exists_p): Sync doc string and
5353 argument list with xselect.c. (Bug#10783)
90b671e2 5354
49241268
GM
53552012-02-10 Glenn Morris <rgm@gnu.org>
5356
5357 * fns.c (Fsecure_hash): Doc fix.
5358
f998bbe7 53592012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5360
5361 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5362
0992bd9c
CY
53632012-02-07 Chong Yidong <cyd@gnu.org>
5364
5365 * buffer.c (Fbuffer_local_variables)
5366 (buffer_lisp_local_variables): Handle unbound vars correctly;
5367 don't let Qunbound leak into Lisp.
5368
af008560
GM
53692012-02-07 Glenn Morris <rgm@gnu.org>
5370
dd605cc4
GM
5371 * image.c (Fimagemagick_types): Doc fix.
5372
af008560
GM
5373 * image.c (imagemagick-render-type): Change it from a lisp object
5374 to an integer. Move the doc here from the lisp manual.
5375 Treat all values not equal to 0 the same.
5376
1449fa1d
CY
53772012-02-06 Chong Yidong <cyd@gnu.org>
5378
5379 * doc.c (store_function_docstring): Avoid applying docstring of
5380 alias to base function (Bug#2603).
5381
3723ec07
AS
53822012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5383
5384 * .gdbinit (pp1, pv1): Remove redundant defines.
5385 (pr): Use pp.
5386
79c1cc1e
CY
53872012-02-04 Chong Yidong <cyd@gnu.org>
5388
5389 * nsterm.m: Declare a global (Bug#10694).
5390
d7f29f8e
EZ
53912012-02-04 Eli Zaretskii <eliz@gnu.org>
5392
cae07000
SM
5393 * w32.c (get_emacs_configuration_options):
5394 Include --enable-checking, if specified, in the return value.
d7f29f8e 5395
3b95a6f9
MR
53962012-02-04 Martin Rudalics <rudalics@gmx.at>
5397
5398 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5399 after rounding frame sizes. (Bug#9723)
5400
d6fa96a6
EZ
54012012-02-04 Eli Zaretskii <eliz@gnu.org>
5402
5403 * keyboard.c (adjust_point_for_property): Don't position point
5404 before BEGV. (Bug#10696)
5405
df0b2940
PE
54062012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5407
5408 Handle overflow when computing char display width (Bug#9496).
5409 * character.c (char_width): Return EMACS_INT, not int.
5410 (char_width, c_string_width): Check for overflow when
5411 computing the width; this is possible now that individual
5412 characters can have unbounded width. Problem introduced
5413 by merge from Emacs 23 on 2012-01-19.
5414
6bee44d6
MA
54152012-02-02 Michael Albinus <michael.albinus@gmx.de>
5416
5417 * dbusbind.c (Fdbus_register_method): Mention the return value
5418 :ignore in the docstring.
5419
44f92739
GM
54202012-02-02 Glenn Morris <rgm@gnu.org>
5421
1b9f60cc
GM
5422 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5423
44f92739
GM
5424 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5425 Unconditionally set to t. (Bug#10673)
5426 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5427 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5428 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5429
c5d3843c
KH
54302012-02-02 Kenichi Handa <handa@m17n.org>
5431
5432 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5433 0, do not call append_composite_glyph.
5434
159462d4 54352012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5436
5437 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5438 NULL (Bug#6988).
5439 (x_produce_glyphs): If the component of a composition is a null
5440 string, set it->pixel_width to 1 to avoid zero-width glyph.
5441
78cef877
EZ
54422012-02-01 Eli Zaretskii <eliz@gnu.org>
5443
5444 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5445 first 2 arguments are identical. This makes inserting large
5446 output from a subprocess an order of magnitude faster on
5447 MS-Windows, where all sbrk'ed memory is always contiguous.
5448
97897668
GM
54492012-01-31 Glenn Morris <rgm@gnu.org>
5450
5451 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5452 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5453 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5454
31fd3586
GM
54552012-01-29 Glenn Morris <rgm@gnu.org>
5456
5457 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5458
0e24a8b2
CY
54592012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5460
5461 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5462
cc0adcb0
CY
54632012-01-28 Chong Yidong <cyd@gnu.org>
5464
5465 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5466
acc28cb9
CY
54672012-01-26 Chong Yidong <cyd@gnu.org>
5468
9c69cfb7
CY
5469 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5470
acc28cb9
CY
5471 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5472 repeat counts (Bug#10507).
5473
48da7392
GM
54742012-01-26 Glenn Morris <rgm@gnu.org>
5475
5476 * lread.c (syms_of_lread): Doc fix.
5477
14af5f7f
CY
54782012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5479
5480 * coding.c (encode_designation_at_bol): Change return value to
5481 EMACS_INT.
5482
0b21c100
CY
54832012-01-25 Chong Yidong <cyd@gnu.org>
5484
5485 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5486
3c2907f7
CY
54872012-01-21 Chong Yidong <cyd@gnu.org>
5488
5489 * floatfns.c (Fcopysign): Make the second argument non-optional,
5490 since nil is not allowed anyway.
5491
959ad23f
AS
54922012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5493
5494 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5495 (send_process): Likewise.
5496
34a02f46
MR
54972012-01-19 Martin Rudalics <rudalics@gmx.at>
5498
5499 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5500 (Vwindow_persistent_parameters): Do not use Qstate.
5501 Rewrite doc-strings.
34a02f46 5502
1259009a 55032012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5504
5505 * character.c (char_width): New function.
70d4fdf6
GM
5506 (Fchar_width, c_string_width, lisp_string_width):
5507 Use char_width (Bug#9496).
25ed9e61 5508
6a6ee00d
MR
55092012-01-16 Martin Rudalics <rudalics@gmx.at>
5510
5511 * window.c (Vwindow_persistent_parameters): New variable.
5512 (Fset_window_configuration, save_window_save): Handle persistent
5513 window parameters.
5514
c85efaf7
EZ
55152012-01-14 Eli Zaretskii <eliz@gnu.org>
5516
5517 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5518 thrashing the stack of the thread. (Bug#9087)
5519
5944709e
PE
55202012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5521
5522 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5523
e71f5d99
EZ
55242012-01-11 Eli Zaretskii <eliz@gnu.org>
5525
5526 * xdisp.c (rows_from_pos_range): Handle the case where the
5527 highlight ends on a newline. (Bug#10464)
5528 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5529 he end column for display of highlight that ends on a newline
5530 before a R2L line.
5531
ce316182
GM
55322012-01-11 Glenn Morris <rgm@gnu.org>
5533
5534 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5535 from load-path also when installation-directory is nil. (Bug#10208)
5536
5b43da69
GM
55372012-01-10 Glenn Morris <rgm@gnu.org>
5538
74cc8ff9
GM
5539 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5540
7d8d6e4e
GM
5541 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5542 Update template values to be closer to their typical values these days.
5b43da69 5543
a0db8d43
EZ
55442012-01-09 Eli Zaretskii <eliz@gnu.org>
5545
5546 * xdisp.c (rows_from_pos_range): Accept additional argument
5547 DISP_STRING, and accept any glyph in a row whose object is that
5548 string as eligible for mouse highlight. Fixes mouse highlight of
5549 display strings from overlays. (Bug#10464)
5550
9a0115ab 55512012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5552
b9110d6a 5553 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5554 * fileio.c (auto_saving_dir_umask): New static var.
5555 (Fmake_directory_internal): Use it.
5556 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5557 creating the directory. The old code temporarily assigns
5558 too-generous permissions to the directory.
5559 (do_auto_save_eh): Clear it.
b9110d6a 5560 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5561 that the var is always cleared.
5562
6c1bd3f3
EZ
55632012-01-07 Eli Zaretskii <eliz@gnu.org>
5564
5565 * search.c (scan_buffer): Pass character positions to
5566 know_region_cache, not byte positions. (Bug#6540)
5567
069d2b50
L
55682012-01-07 LynX <_LynX@bk.ru> (tiny change)
5569
5570 * w32.c (sys_rename): Report EXDEV when rename of a directory
5571 fails because the target is on another logical disk. (Bug#10284)
5572
75bf0d33
DB
55732012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5574
5575 * xterm.c (x_embed_request_focus): New function.
5576
5577 * xterm.h: Add prototype.
5578
5579 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5580
1c6e5a32
GM
55812012-01-05 Glenn Morris <rgm@gnu.org>
5582
5583 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5584
651e947e
EZ
55852012-01-01 Eli Zaretskii <eliz@gnu.org>
5586
5587 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5588 Load gnutls_transport_set_lowat only if GnuTLS version is below
5589 2.11.1.
5590 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5591 GnuTLS versions below 2.11.1.
5592
3778cdd8
AL
55932011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5594
5595 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5596 to the doc string advising against its use for altering the way
5597 windows are scrolled.
5598
0e5317f7
KH
55992011-12-28 Kenichi Handa <handa@m17n.org>
5600
5601 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5602 coding-system ASCII compatible only when it does not produce BOM
5603 on encoding (Bug#10383).
5604
93d5ca1f
JD
56052011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5606
5607 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5608 can scroll.
5609 (create_and_show_popup_menu): Always use menu_position_func for
5610 Gtk3 (Bug#10361).
5611
ca22b785
AS
56122011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5613
5614 * callint.c (Fcall_interactively): Don't truncate prompt string.
5615
d048e1e6
EZ
56162011-12-23 Eli Zaretskii <eliz@gnu.org>
5617
5618 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5619 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5620 resumed from there (after widening). (Bug#10360)
d048e1e6 5621
5ccaba1f
JD
56222011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5623
5624 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5625
204ee57f
JD
56262011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5627
b81d40f0
JB
5628 * nsterm.m (x_free_frame_resources):
5629 Release f->output_data.ns->miniimage.
204ee57f
JD
5630 (ns_index_color): Fix indentation. Do not retain
5631 color_table->colors[i].
5632
5633 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5634 before returning.
5635
5636 * nsfns.m (x_set_background_color): Assign return value from
5637 ns_index_color to face-background instead of NSColor*.
5638 (ns_implicitly_set_icon_type): Fix indentation.
5639 Change assignment in for loop to comparison.
5640
5641 * emacs.c (ns_pool): New variable.
5642 (main): Assign ns_pool.
5643 (Fkill_emacs): Call ns_release_autorelease_pool.
5644
5645 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5646 autorelease fdesc, release fdAttrs and tdict.
5647 (ns_get_covering_families): Release charset.
5648 (ns_findfonts): Release NSFontDescriptor created with new.
5649 (ns_uni_to_glyphs): Fix indentation.
5650 (setString): Release attrStr before assigning new value.
5651
c803b2b7
JD
56522011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5653
678f4426
JD
5654 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5655 and NS_IMPL_COCOA.
5656 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5657 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5658
cd394be1 56592011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5660
5fecd5fc
JD
5661 * nsterm.m (ns_term_init): Subscribe for notifications
5662 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5663 to method trackingNotification in EmacsMenu.
5664
5665 * nsmenu.m (trackingMenu): New variable.
3771cb17 5666 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5667 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5668 from Aquamacs (Bug#7030).
678f4426
JD
5669
56702011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5671
c803b2b7
JD
5672 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5673 (symbol_to_nsstring): Fix indentation.
5674 (ns_symbol_to_pb): New function.
cae07000
SM
5675 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5676 (Fns_rotate_cut_buffers_internal): Remove.
5677 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5678 Fns_store_cut_buffer_internal.
5679 (ns_get_foreign_selection, Fx_own_selection_internal)
5680 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5681 (Fns_get_selection_internal, Fns_store_selection_internal):
5682 Use ns_symbol_to_pb and check if return value is nil.
5683 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5684 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5685 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5686 renamed to Sns_store_selection_internal.
5687 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5688 and remove this function.
5689 (ns_handle_selection_clear): Remove, never used.
5690 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5691 here.
5692
e1b01a3a
KB
56932011-12-17 Ken Brown <kbrown@cornell.edu>
5694
5695 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5696 GID is unknown (Bug#10257).
5697
2adb6e85
PE
56982011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5699
5700 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5701 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5702 which caused a build failure on GNU/Linux IA-64. This problem was
5703 introduced by my 2011-10-07 patch.
5704
d1d7b339
JL
57052011-12-15 Juri Linkov <juri@jurta.org>
5706
5707 * image.c (imagemagick_error): New function. (Bug#10112)
5708 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5709 Use `imagemagick_error' where ImageMagick functions return
5710 `MagickFalse'.
5711 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5712 proper order.
5713
100d5755
KH
57142011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5715
5716 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5717 fill background (Bug#8992).
5718
454592a6
MR
57192011-12-13 Martin Rudalics <rudalics@gmx.at>
5720
5721 * window.c (Vwindow_combination_resize)
5722 (Vwindow_combination_limit): Use t instead of non-nil in
5723 doc-strings.
61d4b438
MR
5724 (Vrecenter_redisplay): Add first sentence of doc-string on
5725 separate line.
53524d93 5726 (Frecenter): Fix doc-string typo.
454592a6 5727
3633e3aa
KH
57282011-12-11 Kenichi Handa <handa@m17n.org>
5729
5730 * coding.c (Funencodable_char_position): Pay attention to the
5731 buffer text relocation (Bug#9389).
5732
7b9d523a 57332011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5734
7b9d523a
JD
5735 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5736 gtk_init (Bug#10100).
5737
b73189c6
EZ
57382011-12-10 Eli Zaretskii <eliz@gnu.org>
5739
5740 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5741 IT->string is nil. (Bug#10263)
5742
f7dfe5d6
JD
57432011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5744
83faebb4
JD
5745 * nsterm.h (x_free_frame_resources): Declare.
5746
f7dfe5d6
JD
5747 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5748 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5749
5750 * nsterm.h (ns_get_defaults_value): Declare.
5751
5752 * nsterm.m (ns_default): Call ns_get_defaults_value.
5753
7cd4e72c
EZ
57542011-12-09 Eli Zaretskii <eliz@gnu.org>
5755
5756 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5757 (Bug#10170)
5758
b34d7317
YM
57592011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5760
5761 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5762 that where the value of an _OBJC_* symbol points to is in the .bss
5763 section (Bug#10240).
5764
76470ad1
KH
57652011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5766
5767 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5768 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5769
745fff94
KH
57702011-12-08 Kenichi Handa <handa@m17n.org>
5771
5772 * ftfont.c (get_adstyle_property): Fix previous change
5773 (Bug#10233).
5774
6e44397c
JB
57752011-12-07 Juanma Barranquero <lekktu@gmail.com>
5776
5777 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5778 dirs from the default value of EMACSLOADPATH (bug#10208).
5779
7efa6272
GM
57802011-12-07 Glenn Morris <rgm@gnu.org>
5781
5782 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5783 installation and source directories as well. (Bug#10208)
5784
f6fc4d87
CY
57852011-12-06 Chong Yidong <cyd@gnu.org>
5786
5787 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5788
2bf26180
GM
57892011-12-06 Glenn Morris <rgm@gnu.org>
5790
5791 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5792 as an error, not just -1. (Bug#10217)
5793
3a6ad4f0
CY
57942011-12-05 Chong Yidong <cyd@gnu.org>
5795
5796 * keyboard.c (process_special_events): New function.
5797 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5798
75a3b399
PE
57992011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5800
5801 * coding.c (encode_designation_at_bol): Don't use uninitialized
5802 local variable (Bug#9318).
5803
c3c9e25e
KH
58042011-12-05 Kenichi Handa <handa@m17n.org>
5805
5806 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5807 return Qnil (Bug#8046, Bug#10193).
5808
5eb05ea3
KH
58092011-12-05 Kenichi Handa <handa@m17n.org>
5810
5811 * coding.c (encode_designation_at_bol): New args charbuf_end and
5812 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5813 (coding_set_source): Return how many bytes coding->source was
5814 relocated.
5815 (coding_set_destination): Return how many bytes
5816 coding->destination was relocated.
5817 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5818 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5819
58202011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5821
5822 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5823 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5824 macro (Bug#9318).
5825
58262011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5827
5828 The following changes are to fix Bug#9318.
5829
a79703f5 5830 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5831 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5832 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5833 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5834
7dbda6df
JB
58352011-12-05 Juanma Barranquero <lekktu@gmail.com>
5836
5837 * lisp.h (process_quit_flag): Fix external declaration.
5838
6d5eb5b0
SM
58392011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5840
5841 Don't macro-inline non-performance-critical code.
5842 * eval.c (process_quit_flag): New function.
5843 * lisp.h (QUIT): Use it.
5844
a0c3fad0
JD
58452011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5846
5847 * nsfns.m (get_geometry_from_preferences): New function.
5848 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5849
6c07aac2
AS
58502011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5851
5852 * emacs.c (Qkill_emacs): Define.
5853 (syms_of_emacs): Initialize it.
5854 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5855 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5856 (quit_throw_to_read_char): Add parameter `from_signal'.
5857 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5858 * lisp.h (QUIT): Call Fkill_emacs if requested.
5859
c052ead4
JD
58602011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5861
5862 * widget.c (update_wm_hints): Return if wmshell is null.
5863 (widget_update_wm_size_hints): New function.
5864
5865 * widget.h (widget_update_wm_size_hints): Declare.
5866
5867 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5868 widget_update_wm_size_hints (Bug#10104).
5869
9e49252b
EZ
58702011-12-03 Eli Zaretskii <eliz@gnu.org>
5871
5872 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5873 before a newline, prepare the bidi iterator for consuming the
5874 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5875 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5876
02b16839
JL
58772011-12-02 Juri Linkov <juri@jurta.org>
5878
5879 * search.c (Fword_search_regexp): New Lisp function created from
5880 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5881 (Fword_search_backward, Fword_search_forward)
5882 (Fword_search_backward_lax, Fword_search_forward_lax):
5883 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5884 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5885
0068070e
SM
58862011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5887
5888 * fileio.c (Finsert_file_contents): Move after-change-function call
5889 to before the "handled:" label, since all "goto handled" appear in
5890 cases where the *-change-functions have already been properly called
5891 (bug#10117).
5892
3360a3fc
AS
58932011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5894
5895 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5896 waiting for input. (Bug#10169)
5897
73d6c093
EZ
58982011-11-30 Eli Zaretskii <eliz@gnu.org>
5899
5900 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5901 verifies glyph row's hash code--we have just reallocated the
5902 glyphs, so their contents can be complete garbage. (Bug#10164)
5903
febe6bea
JB
59042011-11-30 Juanma Barranquero <lekktu@gmail.com>
5905
5906 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5907
801a4313
EZ
59082011-11-30 Eli Zaretskii <eliz@gnu.org>
5909
5910 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5911 attributes are tested _before_ calling verify_row_hash, to protect
5912 against GCC re-ordering of the tests. (Bug#10164)
5913
2b56b87e
JD
59142011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5915
5916 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5917
5918 * xterm.c (handle_one_xevent): Only set async_visible and friends
5919 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5920 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5921 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5922
dbf31225
PE
59232011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5924
5925 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5926 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5927 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5928 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5929 All uses changed to use GCPRO1 etc.
5930 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5931 Revert to old implementation (i.e., before 2011-03-11).
5932
1305621b
YM
59332011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5934
5935 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5936 of scroll runs so as to avoid assigning disabled bogus rows and
5937 unnecessary graphics copy operations.
5938
8c9afb46
EZ
59392011-11-27 Eli Zaretskii <eliz@gnu.org>
5940
5941 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5942 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5943 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5944 (malloc, free, realloc, calloc): Redirect to e_* only when
5945 compiling Emacs.
5946
5947 * lisp.h (GCTYPEBITS): Move before first use.
5948 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5949 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5950 this macro definition.
5951
5952 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5953 _MSC_VER.
5954
54e9e3bf
JD
59552011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5956
6d5eb5b0
SM
5957 * gtkutil.c (xg_create_frame_widgets):
5958 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5959 present with Gtk+ 2.0.
5960
83aca1cb
PE
59612011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5962
5963 * fileio.c (Finsert_file_contents): Undo previous change; see
5964 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5965
5b76caa4
PE
59662011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5967
5968 Rename locals to avoid shadowing.
5969 * fileio.c (Finsert_file_contents):
5970 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5971 * process.c (wait_reading_process_output):
5972 Rename inner 'proc' to 'p' to avoid shadowing.
5973 Indent for consistency with usual Emacs style.
5974
8c535114
EZ
59752011-11-25 Eli Zaretskii <eliz@gnu.org>
5976
5977 * xdisp.c (redisplay_window): If cursor row is not fully visible
5978 after recentering, and scroll-conservatively is set to a large
5979 number, scroll window by a few more lines to make the cursor fully
5980 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5981 (start_display): Don't move to the next line if the display should
5982 start at a newline that is part of a display vector or an overlay
5983 string. (Bug#10119)
8c535114 5984
fa4fdb5c
JL
59852011-11-24 Juri Linkov <juri@jurta.org>
5986
5987 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5988 after the `MagickPingImage' call. (Bug#10112)
5989
90ec88df
CY
59902011-11-23 Chong Yidong <cyd@gnu.org>
5991
5992 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5993
56e2e794
MR
59942011-11-23 Martin Rudalics <rudalics@gmx.at>
5995
5996 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5997 making another buffer current. (Bug#10114)
5998
b6e64c41
GM
59992011-11-23 Glenn Morris <rgm@gnu.org>
6000
6001 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6002
6b21de18
CY
60032011-11-23 Chong Yidong <cyd@gnu.org>
6004
6005 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6006 using it (Bug#5984).
6007
b12cd789
EZ
60082011-11-22 Eli Zaretskii <eliz@gnu.org>
6009
6010 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6011 and header-lines, as they don't have one computed for them.
6012 (Bug#10098)
6013
6014 * .gdbinit (prow): Make displayed values more self-explaining.
6015 Add row's hash code.
6016
261b6fd4
LMI
60172011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6018
6019 * process.c (wait_reading_process_output): Fix asynchrounous
6020 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6021 (wait_reading_process_output): Add comment and URL.
261b6fd4 6022
e7cfd277
JD
60232011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6024
6025 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6026
a9b9b7f5
CY
60272011-11-21 Chong Yidong <cyd@gnu.org>
6028
6029 * window.c (Fnext_window, Fprevious_window): Doc fix.
6030
b0d15b4f
SM
60312011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6032
6033 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6034
fe7a3057
JB
60352011-11-20 Juanma Barranquero <lekktu@gmail.com>
6036
6037 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6038
d2999b1a
MR
60392011-11-20 Martin Rudalics <rudalics@gmx.at>
6040
6041 * window.c (Fset_window_combination_limit): Rename argument
6042 STATUS to LIMIT.
6043 (Vwindow_combination_limit): Remove "status" from doc-string.
6044
d5ff9cd0
AS
60452011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6046
6047 * m/ibms390.h: Remove.
6048 * m/ibms390x.h: Don't include "ibms390.h".
6049
a5bb9bd3
SM
60502011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6051
6052 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6053 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6054
cd1181db
JB
60552011-11-20 Juanma Barranquero <lekktu@gmail.com>
6056
6057 * casetab.c (Fset_case_table):
6058 * charset.c (Fcharset_after): Fix typos.
6059
615a3b8d 60602011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6061
17e845af
PE
6062 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6063 Otherwise, valgrind does not work on some platforms.
6064 Problem reported by Andreas Schwab in
6a0bf43d
PE
6065 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6066 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6067 is set, removing the need for VIRT_ADDRESS_VARIES.
6068 (PURE_P): Use a more-efficient implementation that needs just one
6069 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6070 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6071 to 4 (xorl, subq, cmpq, setbe).
6072 * alloc.c (pure): Always extern now, since that's the
6073 VIRT_ADDR_VARIES behavior.
6074 (PURE_POINTER_P): Use a single comparison, not two, for
6075 consistency with the new puresize.h.
6076 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6077 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6078 Remove VIRT_ADDR_VARIES no longer needed.
6079
f8fe6f96
EZ
60802011-11-19 Eli Zaretskii <eliz@gnu.org>
6081
6082 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6083 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6084 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6085 behave as if the cursor position were at the window margin.
6086
6087 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6088 and the cursor position is out of bounds, behave as if the cursor
6089 position were at the window margin. (Bug#10075)
6090
df05a53c
CY
60912011-11-18 Chong Yidong <cyd@gnu.org>
6092
6093 * window.c (Fwindow_combination_limit): Make first argument
6094 non-optional, since it is meaningless for live windows like the
6095 selected window.
61ccba97 6096
2071918e
DA
60972011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6098
6099 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6100
b50a28de
SM
61012011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6102
6103 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6104 (graft_intervals_into_buffer): Simplify.
6105
015137db
EZ
61062011-11-18 Eli Zaretskii <eliz@gnu.org>
6107
6108 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6109 hash values of the two rows.
6110 (copy_row_except_pointers): Preserve the used[] arrays and the
6111 hash values of the two rows. (Bug#10035)
68c95424 6112 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6113
6114 * xdisp.c (row_hash): New function, body extracted from
6115 compute_line_metrics.
6116 (compute_line_metrics): Call row_hash, instead of computing the
6117 hash code inline.
6118
6119 * dispnew.c (verify_row_hash): Call row_hash for computing the
6120 hash code of a row, instead of duplicating code from xdisp.c.
6121
6122 * dispextern.h (row_hash): Add prototype.
6123
a2addb04
TH
61242011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6125
6126 * frame.c (delete_frame): Don't delete the terminal when the last
6127 X frame is closed if emacs is built with GTK toolkit.
6128
df85d315
JB
61292011-11-17 Juanma Barranquero <lekktu@gmail.com>
6130
6131 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6132
a0c2d0ae
MR
61332011-11-17 Martin Rudalics <rudalics@gmx.at>
6134
6135 * window.c (Vwindow_splits): Rename to
6136 Vwindow_combination_resize. Suggested by Juri Linkov.
6137 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6138 of Vwindow_splits.
6139
58179cce
JB
61402011-11-16 Juanma Barranquero <lekktu@gmail.com>
6141
7877f373
JB
6142 * nsfns.m (Fns_font_name):
6143 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6144
b6f67890
MR
61452011-11-16 Martin Rudalics <rudalics@gmx.at>
6146
6147 * window.h (window): Rename slot "nest" to "combination_limit".
6148 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6149 (Fset_window_nest): Rename to Fset_window_combination_limit.
6150 (Vwindow_nest): Rename to Vwindow_combination_limit.
6151 (recombine_windows, make_parent_window, make_window)
6152 (Fsplit_window_internal, saved_window)
6153 (Fset_window_configuration, save_window_save): Rename all
6154 occurrences of window_nest to window_combination_limit.
6155
c7015153
JB
61562011-11-15 Juanma Barranquero <lekktu@gmail.com>
6157
6158 * image.c (imagemagick_load_image): Fix typo.
6159
322ad6ec
EZ
61602011-11-14 Eli Zaretskii <eliz@gnu.org>
6161
6162 * xdisp.c (display_line): Move the call to
6163 highlight_trailing_whitespace before the call to
6164 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6165 faces of all the glyphs to compute ROW's hash value.
6166 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6167
f067b8ec
JB
61682011-11-14 Juanma Barranquero <lekktu@gmail.com>
6169
6170 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6171 just return (bug#10044).
6172
1e5b2111
EZ
61732011-11-12 Eli Zaretskii <eliz@gnu.org>
6174
7ef3cbd5
EZ
6175 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6176 with user-defined heap size. Bump the default size of the temacs
6177 heap to 27MB, to avoid memory warning when running temacs.
6178 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6179
1e5b2111
EZ
6180 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6181 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6182 (verify_row_hash) [XASSERTS]: New function.
6183 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6184 that the hash value of glyph rows is correct.
1e5b2111 6185
89d61221
MR
61862011-11-12 Martin Rudalics <rudalics@gmx.at>
6187
6188 * window.h (window): Remove splits slot.
6189 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6190 (Fdelete_other_windows_internal, make_parent_window)
6191 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6192 (Fset_window_configuration, save_window_save): Don't deal with
6193 split status of windows.
6194 (saved_window): Remove splits slot.
6195 (Vwindow_splits): Rewrite doc-string.
6196
97f18cc8
JD
61972011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6198
6199 * xfns.c (unwind_create_frame):
6200 * nsfns.m (unwind_create_frame):
6201 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6202 Vframe_list (Bug#9999).
6203
22a648b4
DA
62042011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6205
0b381c7e 6206 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6207
659afede
KH
62082011-11-11 Kenichi Handa <handa@m17n.org>
6209
6210 * callproc.c (Fcall_process): Set the member dst_multibyte of
6211 process_coding.
6212
9ac0394b
KH
62132011-11-11 Johan Bockgård <bojohan@gnu.org>
6214
6215 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6216 avoid a crash (bug#9496).
6217
2fbdc249
CY
62182011-11-09 Chong Yidong <cyd@gnu.org>
6219
6220 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6221 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6222
ac6b1f81
PE
62232011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6224
6225 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6226
09db192c
PE
62272011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6228
6229 Avoid some portability problems by eschewing 'extern inline' functions.
6230 The trivial performance wins aren't worth the portability hassles; see
6231 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6232 et seq.
6233 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6234 (window_box_width, window_box_left, window_box_left_offset)
6235 (window_box_right, window_box_right_offset): Undo previous change,
6236 by removing the "extern"s.
6237 * intervals.c (adjust_intervals_for_insertion)
6238 (adjust_intervals_for_deletion): Undo previous change,
6239 making these static again.
6240 (offset_intervals, temp_set_point_both, temp_set_point)
6241 (copy_intervals_to_string): No longer inline.
6242 * xdisp.c (window_text_bottom_y, window_box_width)
6243 (window_box_height, window_box_left_offset)
6244 (window_box_right_offset, window_box_left, window_box_right)
6245 (window_box): No longer inline.
6246
105216ed
CY
62472011-11-08 Chong Yidong <cyd@gnu.org>
6248
6249 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6250 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6251 Signal an error if not a live window.
105216ed
CY
6252 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6253 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6254
ae9e237f
JB
62552011-11-07 Juanma Barranquero <lekktu@gmail.com>
6256
6257 * lisp.h (syms_of_abbrev): Remove declaration.
6258 Reported by CHENG Gao <chenggao@royau.me>.
6259
c7aa8333
EZ
62602011-11-07 Eli Zaretskii <eliz@gnu.org>
6261
6262 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6263 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6264 of temacs in GUI mode.
6265
be7f5545
MR
62662011-11-07 Martin Rudalics <rudalics@gmx.at>
6267
6268 * window.h: Declare delete_all_child_windows instead of
6269 delete_all_subwindows.
6270 * window.c (Fwindow_nest, Fset_window_nest)
6271 (Fset_window_new_total, Fset_window_new_normal)
6272 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6273 (delete_all_subwindows): Rename to delete_all_child_windows.
6274 (Fdelete_other_windows_internal, Fset_window_configuration):
6275 Call delete_all_child_windows instead of delete_all_subwindows.
6276 * frame.c (delete_frame): Call delete_all_child_windows instead
6277 of delete_all_subwindows.
6278
ca78dc43
PE
62792011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6280
6281 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6282 This is also needed for porting to any host where GC_MARK_STACK is
6283 not GC_MAKE_GCPROS_NOOPS.
6284 (which_symbols): Use it.
6285
a0241d01
KH
62862011-11-07 Kenichi Handa <handa@m17n.org>
6287
6288 * coding.c (coding_set_destination): Check coding->src_pos only
6289 when coding->src_object is a buffer (bug#9910).
6290
6291 * process.c (send_process): Set the member src_multibyte of coding
6292 to 0 (bug#9911) when sending a unibyte text.
6293
6294 * callproc.c (Fcall_process): Set the member src_multibyte of
6295 process_coding to 0 (bug#9912).
6296
a64bfdfa 62972011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6298
6299 * xmenu.c (cleanup_widget_value_tree): New function.
6300 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6301 calling free_menubar_widget_value_tree directly (Bug#9830).
6302
cb41b32a
PE
63032011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6304
6305 Fix some portability problems with 'inline'.
6306 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6307 (window_box_width, window_box_left, window_box_left_offset)
6308 (window_box_right, window_box_right_offset): Declare extern.
6309 Otherwise, these inline functions do not conform to C99 and
6310 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6311 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6312 * intervals.c (adjust_intervals_for_insertion)
6313 (adjust_intervals_for_deletion): Now extern, because otherwise the
6314 extern inline functions 'offset_intervals' couldn't refer to it.
6315 (static_offset_intervals): Remove.
6316 (offset_intervals): Rewrite using the old contents of
6317 static_offset_intervals. The old version didn't conform to C99
6318 because an extern inline function contained a reference to an
6319 identifier with static linkage.
6320
b7041366
AS
63212011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6322
6323 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6324 GC.
6325
88a37c4d
EZ
63262011-11-06 Eli Zaretskii <eliz@gnu.org>
6327
6328 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6329 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6330 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6331 return Qleft_to_right.
6332
49745b39
CY
63332011-11-06 Chong Yidong <cyd@gnu.org>
6334
6335 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6336 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6337 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6338 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6339 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6340 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6341 (Fwindow_vscroll): Doc fix.
6342 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6343 argument, since it makes no sense to pass a live window and for
6344 consistency with window-child.
6345
1f05cd82
CS
63462011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6347
6348 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6349 support MSVC.
6350
22610910
JR
63512011-11-05 Jason Rumney <jasonr@gnu.org>
6352
6353 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6354 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6355 fonts (Bug#6029).
6356 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6357 bitwise arithmetic preventing use of unicode-sip and non-truetype
6358 opentype fonts.
6359
a06776b2
EZ
63602011-11-05 Eli Zaretskii <eliz@gnu.org>
6361
3ad924ba
EZ
6362 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6363 "emacs"-only part.
6364
a06776b2
EZ
6365 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6366 initialization code to keep similarity to xfns.c after changes
6367 from 2011-11-05.
6368
c9e7db78
JD
63692011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6370
a97f8f3f
JD
6371 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6372 (unwind_create_frame): New function (Bug#9943).
6373 (Fx_create_frame): Restructure code to be more similar to the one in
6374 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6375 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6376 Move terminal->reference_count++ just before making the frame official
6377 (Bug#9943).
6378
6379 * nsterm.m (x_free_frame_resources): New function.
6380 (x_destroy_window): Move code to x_free_frame_resources.
6381
c9e7db78 6382 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6383 (Fx_create_frame, x_create_tip_frame):
6384 Move terminal->reference_count++ just before making the frame
75f1671a 6385 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6386 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6387
a6fc3b5c
EZ
63882011-11-05 Eli Zaretskii <eliz@gnu.org>
6389
6390 Support MSVC build with newer versions of Visual Studio.
6391 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6392 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6393 nt/gmake.defs.
6394
6395 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6396 which are not supported by MSVC.
6397 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6398 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6399 bitfields.
6400 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6401 types in bitfields.
6402 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6403
6404 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6405
58179cce 64062011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6407
6408 Support MSVC build with newer versions of Visual Studio.
6409 * w32.c: Don't include w32api.h for MSVC.
6410 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6411
6412 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6413 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6414 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6415 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6416 e_* cousins.
6417 (alloca) [_MSC_VER]: Define to _alloca.
6418
6419 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6420
6421 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6422
a58c13ed
EZ
64232011-11-04 Eli Zaretskii <eliz@gnu.org>
6424
6425 * xdisp.c (note_mouse_highlight): If either of
6426 previous/next-single-property-change returns nil, treat that as
6427 the beginning or the end of the buffer. (Bug#9955)
6428
fe0b6370
JD
64292011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6430
a58c13ed 6431 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6432 label is not null (Bug#9951).
6433 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6434 may be NULL.
6435
89bd5ee1
EZ
64362011-11-04 Eli Zaretskii <eliz@gnu.org>
6437
6438 * window.c (Fwindow_body_size): Mention in the doc string that the
6439 return value is in frame's canonical units. (Bug#9949)
6440
84c3edb9
EZ
64412011-11-03 Eli Zaretskii <eliz@gnu.org>
6442
4e2fb5c7
EZ
6443 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6444
84c3edb9 6445 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6446 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6447 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6448
bc17a887
EZ
64492011-11-01 Eli Zaretskii <eliz@gnu.org>
6450
6451 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6452 Don't stop backward scan on the continuation glyph, even though
6453 its CHARPOS is positive.
6d5eb5b0
SM
6454 (mouse_face_from_buffer_pos, note_mouse_highlight):
6455 Rename cover_string to disp_string.
bc17a887 6456
4ee88440
MR
64572011-11-01 Martin Rudalics <rudalics@gmx.at>
6458
6459 * window.c (temp_output_buffer_show): Don't use
6460 Vtemp_buffer_show_specifiers.
6461 (Vtemp_buffer_show_specifiers): Remove unused variable.
6462
c2ff3c02
EZ
64632011-10-30 Eli Zaretskii <eliz@gnu.org>
6464
6465 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6466 past the beginning of the current glyph matrix.
6467
58179cce 64682011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6469
6470 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6471 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6472 HAVE_GTK3 (Bug#9869).
b77a6a7f 6473
3b574623
JD
6474 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6475 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6476
b77a6a7f
JD
6477 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6478
6479 * xterm.c: Declare x_handle_net_wm_state to return int.
6480 (handle_one_xevent): Check if we are iconified but don't have
6481 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6482 (get_current_wm_state): Return non-zero if not hidden,
6483 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6484 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6485 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6486 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6487
196e41e4
PE
64882011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6489
6490 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6491 so that this new function doesn't get optimized away by a
6492 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6493
021f2e1a
AS
64942011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6495
6496 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6497
8b058d44
EZ
64982011-10-29 Eli Zaretskii <eliz@gnu.org>
6499
6500 Fix the `xbytecode' command.
6501 * .gdbinit (xprintbytestr): New command.
b50a28de 6502 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6503 (xbytecode): Print the byte-code string as well.
6504
4452fb80
EZ
65052011-10-29 Kim Storm <storm@cua.dk>
6506
8b058d44
EZ
6507 * alloc.c (which_symbols): New function.
6508
21b72067
AS
65092011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6510
6511 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6512 line. (Bug#9903)
6513
83ed7b5c
GM
65142011-10-29 Glenn Morris <rgm@gnu.org>
6515
6516 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6517 Not clear what it was for, and it causes various bugs. (Bug#9839)
6518
5a7a728b
EZ
65192011-10-28 Eli Zaretskii <eliz@gnu.org>
6520
6521 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6522 possible random value that matches one of those tested as
6523 condition to clear the mouse face.
6524
d3d0842f
CY
65252011-10-28 Chong Yidong <cyd@gnu.org>
6526
6527 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6528
31b39d13
DN
65292011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6530
6531 * window.c (make_window): Initialize phys_cursor_on_p.
6532
9aba6043
SM
65332011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6534
6535 * lisp.h (struct Lisp_Symbol): Update comments.
6536
c20992f4
JB
65372011-10-28 Juanma Barranquero <lekktu@gmail.com>
6538
6539 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6540
db4f02f2
EZ
65412011-10-28 Eli Zaretskii <eliz@gnu.org>
6542
6543 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6544 <oslsachem@gmail.com> for helping to debug this.
6545
6546 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6547 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6548 (g_b_init_get_glyph_outline_w): New static variables.
6549 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6550 (GetGlyphOutlineW_Proc): New typedefs.
6551 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6552 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6553 New functions.
6554 (w32font_open_internal, compute_metrics):
6555 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6556 instead of calling the "wide" APIs directly.
6557
6558 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6559
6560 * w32.h (syms_of_w32font): Add prototype.
6561
87e68db4
JB
65622011-10-27 Juanma Barranquero <lekktu@gmail.com>
6563
6564 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6565 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6566 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6567 (Fmove_to_window_line): Doc fix.
6568
435c1d67
CY
65692011-10-27 Chong Yidong <cyd@gnu.org>
6570
6571 * process.c (make_process): Set gnutls_state to NULL.
6572
6573 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6574 non-NULL, regardless of GNUTLS_INITSTAGE.
6575 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6576 an error. Set process slots as soon as we allocate them.
6577
6578 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6579
9c6c6f49
CY
65802011-10-27 Chong Yidong <cyd@gnu.org>
6581
9aba6043
SM
6582 * gnutls.c (emacs_gnutls_deinit): New function.
6583 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6584 (Fgnutls_deinit, Fgnutls_boot): Use it.
6585
6586 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6587 (deactivate_process): Call emacs_gnutls_deinit.
6588
657d08d3
JB
65892011-10-27 Juanma Barranquero <lekktu@gmail.com>
6590
6591 * image.c (x_create_x_image_and_pixmap):
6592 * w32.c (sys_rename, w32_delayed_load):
6593 * w32font.c (fill_in_logfont):
6594 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6595
5430d399
JB
65962011-10-26 Juanma Barranquero <lekktu@gmail.com>
6597
6598 * w32fns.c (w32_default_color_map): New function,
6599 extracted from Fw32_default_color_map.
a7ef684b 6600 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6601
fe0055fa
PE
66022011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6603
6604 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6605
e6346438
SM
66062011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6607
6608 * keyboard.c (test_undefined): New function (bug#9751).
6609 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6610
e112cc37
ET
66112011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6612
6613 * sysdep.c (init_sys_modes): Fix the check for the controlling
6614 terminal (Bug#6649).
6615
7b5d6677
EZ
66162011-10-20 Eli Zaretskii <eliz@gnu.org>
6617
6618 * dispextern.h (struct bidi_it): New member next_en_type.
6619
6620 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6621 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6622 current character, check also for next_en_type being WEAK_EN.
6623 (bidi_resolve_weak): Don't enter the expensive loop if the current
6624 position is before next_en_pos. Record the bidi type of the first
6625 non-ET, non-BN character we find, in addition to its position.
6626 (bidi_level_of_next_char): Invalidate next_en_type when
6627 next_en_pos is over-stepped.
6628
7da0b018
PE
66292011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6630
6631 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6632 * editfns.c: Rewrite current-time-zone so that it invokes
6633 the equivalent of (format-time-string "%Z") to get the time zone name.
6634 This fixes a bug when the time zone name contains characters that
6635 need converting from the system time locale to Emacs internal format.
6636 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6637 that patch fixed format-time-string to do the conversion, but
6638 I forgot to fix current-time-zone.
6639 (format_time_string): New function, containing most of
6640 what Fformat_time_string used to contain.
6641 (Fformat_time_string): Rewrite in terms of format_time_string.
6642 This doesn't change this function's behavior.
6643 (current-time-zone): Rewrite to use format_time_string.
6644 This fixes the bug reported by Michael Schierl in
6645 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6646 Jason Rumney's 2007-06-07 change worked around this bug, but
6647 didn't fix it.
6648 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6649
8547b010
EZ
66502011-10-19 Eli Zaretskii <eliz@gnu.org>
6651
6652 * xdisp.c (start_display): If the character at POS is displayed
6653 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6654 (try_window_reusing_current_matrix): If a line ends in a display
6655 vector or the next line starts in a display vector, continue
6656 redrawing the window even though the character position of
6657 start_row was reached.
8547b010
EZ
6658 (Bug#9771, part 2)
6659
4e948d15
CY
66602011-10-18 Chong Yidong <cyd@gnu.org>
6661
6662 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6663 with nobreak-char-display too.
6664
4787455f
EZ
66652011-10-18 Eli Zaretskii <eliz@gnu.org>
6666
6667 Fix part 3 of bug#9771.
6668 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6669 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6670 non-neutral characters if the current character is a paragraph
6671 separator (a.k.a. Newline). This avoids running the same
6672 expensive loop twice, once when we consume the preceding newline
6673 and the other time when the line actually needs to be displayed.
6674 Avoid the loop when we see neutrals on the base embedding level
6675 following a character whose directionality is the same as the
6676 paragraph's. This avoids running the expensive loop when a line
6677 ends in a long sequence of neutrals, like control characters.
6678 Add assertion against STRONG_AL type. Slightly rearrange code
6679 that determines the type of a neutral given the first non-neutral
6680 that follows it.
6681 (bidi_level_of_next_char): Set next_en_pos to zero when
6682 invalidating its info.
6683
2c91f553
EZ
66842011-10-17 Eli Zaretskii <eliz@gnu.org>
6685
6686 * xdisp.c (push_display_prop): Determine whether to record string
6687 or buffer position by IT->string, not by IT->method. Allow
6688 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6689 (move_it_vertically_backward): Don't look for character position
6690 immediately after the newline when in a continuation line.
6691 (Bug#9771, part 1)
2c91f553 6692
c7b08b0d
MR
66932011-10-15 Martin Rudalics <rudalics@gmx.at>
6694
6695 * window.c (coordinates_in_window): Rewrite and delabelize
6696 vertical border check. (Bug#5357) (Bug#9618)
6697
6b02f655
SM
66982011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6699
6700 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6701 errors in XSetWindowBorder (bug#9310).
6702
81d40c92
DA
67032011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6704
6705 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6706 avoid crash when xmalloc overrun checking is enabled.
6707
d4172c3b
EZ
67082011-10-13 Eli Zaretskii <eliz@gnu.org>
6709
6710 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6711 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6712 cursor motion with <left> and <right> arrow keys.
6713
6714 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6715 some callers set that themselves.
6716
b00eea75
EZ
67172011-10-12 Eli Zaretskii <eliz@gnu.org>
6718
6719 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6720 display string and the previous row comes from the same string and
6721 is empty. (Bug#9739) (Bug#9738)
6722
8fe012c4
SM
67232011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6724
6725 * doc.c (get_doc_string): Encode file name (bug#9735).
6726
0074aef2
EZ
67272011-10-12 Eli Zaretskii <eliz@gnu.org>
6728
79beb178
EZ
6729 * bidi.c (bidi_level_of_next_char):
6730 * xdisp.c (get_visually_first_element): Remove old incorrect
6731 comments regarding the Unicode Line Separator character.
6732
0074aef2
EZ
6733 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6734
6e4b3fbe
DA
67352011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6736
6737 * alloc.c (Fgc_status): Do not access beyond zombies array
6738 boundary if nzombies > MAX_ZOMBIES.
6739 * alloc.c (dump_zombies): Add missing format specifier.
6740
0324f3af
PE
67412011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6742
b5525cac
PE
6743 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6744 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6745
0324f3af
PE
6746 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6747 Some packages use them to denote characters with modifiers.
6748
e9b5f888
AS
67492011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6750
6751 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6752 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6753 matching a pp-number. Rename parameter var to var1.
6754
127827c0
SM
67552011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6756
6757 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6758
c8fd3bd0
GM
67592011-10-08 Glenn Morris <rgm@gnu.org>
6760
6761 * callint.c (Fcall_interactively): Give a more explicit error for the
6762 'c' case with a non-character input. (Bug#8479)
6763
352ec8ff
EZ
67642011-10-08 Eli Zaretskii <eliz@gnu.org>
6765
03669ccb
EZ
6766 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6767 lines.
7061c986
EZ
6768 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6769 lines that are hscrolled on the left.
03669ccb 6770
352ec8ff
EZ
6771 * dispnew.c (buffer_posn_from_coords): Account for a possible
6772 presence of header-line. (Bug#4426)
6773
a66cfb1c
SM
67742011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6775
6b02f655
SM
6776 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6777 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6778
7c5ee88e
PE
67792011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6780
6781 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6782 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6783 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6784 this makes Emacs dump core during garbage collection on rare
6785 occasions. sizeof is obviously inferior to offsetof here, so
6786 stick with offsetof.
6787 (GC_POINTER_ALIGNMENT): New macro.
6788 (mark_memory): Omit 3rd (offset) arg; caller changed.
6789 Don't assume EMACS_INT alignment is the same as pointer alignment.
6790
df1bbe5b
SM
67912011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6792
6793 * keyboard.c (read_key_sequence_remapped): New var.
6794 (read_key_sequence): Compute remapping in the right buffer.
6795 (command_loop_1): Use read_key_sequence's remapping directly.
6796
51553db6
SM
67972011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6798
32c1fffd
SM
6799 * dired.c (file_name_completion): Don't expand file name.
6800 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6801 before checking file name handler.
6802
51553db6
SM
6803 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6804 they've been requested explicitly (bug#9591).
6805
b6bd1599 68062011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6807
6808 * keymap.c (Fsingle_key_description): Use make_specified_string
6809 instead of build_string to build string from push_key_description.
6810 (Bug#5193)
6811
f701dc2a
PE
68122011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6813
4222c55d
PE
6814 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6815 This fixes a Y2038 bug on 64-bit hosts.
6816 * buffer.c (reset_buffer):
6817 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6818 (Fclear_buffer_auto_save_failure):
6819 Use 0, not -1, to represent an unset failure time, since time_t
6820 might not be signed.
6821
f701dc2a
PE
6822 Remove dependency on glibc malloc internals.
6823 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6824 Move back here from lisp.h, but with their new implementations.
6825 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6826 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6827 * charset.c (charset_table_init): New static var.
6828 (syms_of_charset): Use it instead of xmalloc. This removes a
6829 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6830 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6831 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6832 Move back to alloc.c.
6833 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6834 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6835
9ceebf39
JD
68362011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6837
6838 * nsterm.m (windowDidResize): Call x_set_window_size only when
6839 ns_in_resize is true. Otherwise set pixelwidth/height and
6840 call change_frame_size (Bug#9628).
6841
cb993c58
PE
68422011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6843
3930c88b
PE
6844 Port --enable-checking=all to Fedora 14 x86-64.
6845 * charset.c (syms_of_charset): Also account for glibc malloc's
6846 internal overhead when calculating the initial malloc maximum.
6847
cb993c58
PE
6848 Port --enable-checking=all to Fedora 14 x86.
6849 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6850 Move to lisp.h.
6851 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6852 (overrun_check_realloc, overrun_check_free):
6853 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6854 That way, xmalloc returns a properly-aligned pointer even if
6855 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6856 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6857 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6858 into account when calculating the initial malloc maximum.
6859 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6860 Move here from alloc.c, so that charset.c can use it too.
6861 Properly align; the old code wasn't right for common 32-bit hosts
6862 when configured with --enable-checking=all.
6863 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6864 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6865
31bed486
EZ
68662011-09-29 Eli Zaretskii <eliz@gnu.org>
6867
04c70788 6868 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6869 use EDOM.
6870
fbcaa2f3
EZ
68712011-09-28 Eli Zaretskii <eliz@gnu.org>
6872
6873 * xdisp.c (compute_display_string_end): If there's no display
6874 string at CHARPOS, return -1.
6875
6876 * bidi.c (bidi_fetch_char): When compute_display_string_end
6877 returns a negative value, treat the character as a normal
6878 character not covered by a display string. (Bug#9624)
6879
a239d4e9
JB
68802011-09-28 Juanma Barranquero <lekktu@gmail.com>
6881
6882 * lread.c (Fread_from_string): Fix typo in docstring.
6883
88652fd5
EZ
68842011-09-27 Eli Zaretskii <eliz@gnu.org>
6885
6886 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6887 newline, reseat the iterator instead of bidi-iterating there one
6888 character at a time. (Bug#9610)
32c1fffd
SM
6889 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6890 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6891
ed497dd4
AS
68922011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6893
6894 * lread.c (readevalloop): Use correct code for NBSP.
6895 (read1): Likewise. (Bug#9608)
6896
b2bf61aa
MA
68972011-09-25 Michael Albinus <michael.albinus@gmx.de>
6898
6899 * dbusbind.c (Fdbus_register_signal): When service is not
6900 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6901
32bbb17c
GM
69022011-09-25 Glenn Morris <rgm@gnu.org>
6903
6904 * buffer.c (truncate-lines): Doc fix.
6905
94e0933e
CY
69062011-09-24 Chong Yidong <cyd@stupidchicken.com>
6907
6908 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6909 (Fset_window_next_buffers): Doc fix.
6910
cddde921
GM
69112011-09-24 Glenn Morris <rgm@gnu.org>
6912
6913 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6914
1260aef1
PE
69152011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6916
25b4bfa0
PE
6917 Fix minor problems found by static checking.
6918 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6919 * indent.c (Fvertical_motion): Fix == vs = typo.
6920
e3cbd34b
EZ
69212011-09-24 Eli Zaretskii <eliz@gnu.org>
6922
a66cfb1c
SM
6923 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6924 Default value is now t. Doc fix.
6bf7006f 6925
e3cbd34b 6926 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6927 logic when moving up, not only when moving down. Fix the
e3cbd34b 6928 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6929 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6930
6931 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6932 CHARPOS is covered by a display string which includes newlines.
6933 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6934 is covered by a display string with embedded newlines.
6935
a3de0cbd
MA
69362011-09-24 Michael Albinus <michael.albinus@gmx.de>
6937
6938 * dbusbind.c (Fdbus_register_signal): Add match rule to
6939 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6940 (Fdbus_register_method, Vdbus_registered_objects_table):
6941 Fix docstring.
a3de0cbd 6942
b260039d
JM
69432011-09-24 Jim Meyering <meyering@redhat.com>
6944
32c1fffd 6945 do not ignore write error for any output size
b260039d
JM
6946 The previous change was incomplete.
6947 While it makes emacs --batch detect the vast majority of stdout
6948 write failures, errors were still ignored whenever the output size is
6949 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6950 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6951 && echo FAIL: ignored write error
6952 FAIL: ignored write error
6953 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6954 && echo FAIL: ignored write error
6955 FAIL: ignored write error
6956 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6957
8eca8a7c
AS
69582011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6959
6960 * emacs.c (Fkill_emacs): In noninteractive mode exit
6961 non-successfully if a write error occurred on stdout. (Bug#9574)
6962
3341db62
EZ
69632011-09-21 Eli Zaretskii <eliz@gnu.org>
6964
6965 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6966 the xassert test.
6967
6968 * dispextern.h (struct it): Update the comment documenting what
6969 can it->OBJECT be.
6970
8c203dbf
EZ
69712011-09-20 Eli Zaretskii <eliz@gnu.org>
6972
6973 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6974 a display string, extend search for cursor position to end of row.
6975 (find_row_edges): If the row ends in a newline from a display
6976 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6977 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6978 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6979 non-empty line. Fixes confusing cursor motion with arrow keys at
6980 the beginning of a line that starts with whitespace.
8c203dbf 6981
a4824228
LMI
69822011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6983
6984 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6985 (bug#9493).
6986
33ed493b
CY
69872011-09-18 Chong Yidong <cyd@stupidchicken.com>
6988
6989 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6990 boolean (Bug#9154).
6991
56cd55c8
EZ
69922011-09-18 Eli Zaretskii <eliz@gnu.org>
6993
6994 * xdisp.c (display_line): Record maximum and minimum buffer
6995 positions even if no glyphs were produced (e.g., by a zero-width
6996 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6997 buffer positions that will be removed from the glyph row because
6998 they don't fit.
c02dcedf
EZ
6999 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7000 column is beyond frame width: don't subtract 1 "pixel" when
7001 computing width of the stretch.
3e62b7e0
EZ
7002 (reseat_at_next_visible_line_start): Undo the change made on
7003 2011-09-17 that saved paragraph information and restored it after
7004 the call to `reseat'. (Bug#9545)
56cd55c8 7005
5ed99d36 70062011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7007
7008 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7009 and turn window cursor on if cleared (Bug#9415).
7010
5ed99d36 70112011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7012
7013 * search.c (boyer_moore): Take unibyte characters from pattern
7014 literally. (Bug#9458)
7015
9bade7b2
EZ
70162011-09-18 Eli Zaretskii <eliz@gnu.org>
7017
7018 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7019
e5e9d610
PE
70202011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7021
87e4427a
PE
7022 Fix minor problem found by static checking.
7023 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7024 initialized, to pacify gcc -Wuninitialized.
7025
e5e9d610
PE
7026 * fileio.c: Report proper errno when syscall falls.
7027 (Finsert_file_contents): Save and restore errno,
7028 so that report_file_error outputs the correct diagnostic.
7029 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7030
a1674f0b
EZ
70312011-09-18 Eli Zaretskii <eliz@gnu.org>
7032
7033 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7034
fbfb6dd4
EZ
70352011-09-17 Eli Zaretskii <eliz@gnu.org>
7036
7037 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7038 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7039
bb187662
EZ
70402011-09-17 Eli Zaretskii <eliz@gnu.org>
7041
1137e8b8 7042 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7043 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7044
7045 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7046 (bidi_find_paragraph_start): Search back for paragraph beginning
7047 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7048 (bidi_move_to_visually_next): Only trigger paragraph-related
7049 computations when the last character is a newline or at EOB, not
7050 just any NEUTRAL_B. (Bug#9470)
7051
bb187662
EZ
7052 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7053 truncated lines if point is covered by a display string. (Bug#9524)
7054
2e621251
PE
70552011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7056
7057 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7058 (cons_to_x_long): New function.
7059 (lisp_data_to_selection_data): Use it. Correct the test for
7060 short-versus-long data; it was negated. Break out of vector
7061 loop, for efficiency, when a long datum is discovered.
7062
91a15bc6
SM
70632011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7064
7065 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7066
b41c3a35
EZ
70672011-09-16 Eli Zaretskii <eliz@gnu.org>
7068
7069 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7070 GCC PR/17406) by declaring this function with external scope.
7071
7812ba2d
PE
70722011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7073
7074 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7075 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7076
cf7edc2a
AS
70772011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7078
7079 * editfns.c (Fformat): Correctly handle text properties on "%%".
7080
bd01620e
EZ
70812011-09-15 Eli Zaretskii <eliz@gnu.org>
7082
7083 * xterm.c (x_draw_composite_glyph_string_foreground):
7084 * w32term.c (x_draw_composite_glyph_string_foreground):
7085 * term.c (encode_terminal_code):
7086 * composite.c (composition_update_it, get_composition_id):
7087 * xdisp.c (get_next_display_element)
7088 (fill_composite_glyph_string): Add comments about special meaning
7089 of TAB characters in a composition.
7090
a02719a3
PE
70912011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7092
7093 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7094 This occurs when processing a multibyte format.
7095 Problem reported by Wolfgang Jenker.
a02719a3 7096
72589a3c
JB
70972011-09-15 Johan Bockgård <bojohan@gnu.org>
7098
7099 * xdisp.c (try_cursor_movement): Only check for exact match if
7100 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7101
1c14176c
PE
71022011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7103
7104 Remove unused external symbols.
7105 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7106 * xdisp.c (calc_pixel_width_or_height): Now static.
7107 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7108 * indent.c (check_display_width):
7109 * w32term.c: Fix comment to match code.
7110 * xterm.c, xterm.h (x_catching_errors): Remove.
7111
d2eea5b5
PE
71122011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7113
7114 * xselect.c: Use signed conversions more consistently (Bug#9498).
7115 (selection_data_to_lisp_data): Assume incoming selection data are
7116 signed integers, not unsigned. This is to be consistent with
7117 outgoing selection data, which was modified to use signed integers
7118 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7119 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7120 expects long, not unsigned long.
7121
46888499
EZ
71222011-09-14 Eli Zaretskii <eliz@gnu.org>
7123
7124 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7125 computation of loop end. Reported by Johan Bockgård
7126 <bojohan@gnu.org>.
7127
ef8ef9fb
CY
71282011-09-13 Chong Yidong <cyd@stupidchicken.com>
7129
7130 * frame.c (Fother_visible_frames_p): Function deleted.
7131
fa819fed
EZ
71322011-09-12 Eli Zaretskii <eliz@gnu.org>
7133
7134 * indent.c (compute_motion): Process display vector front to back
7135 rather than the other way around. (Bug#2496)
7136
2ba8e008
SM
71372011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7138
7139 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7140
20f53c69
CY
71412011-09-11 Chong Yidong <cyd@stupidchicken.com>
7142
7143 * minibuf.c (Fread_from_minibuffer): Doc fix.
7144
d562d7a4
EZ
71452011-09-11 Eli Zaretskii <eliz@gnu.org>
7146
7147 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7148 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7149
1c4d7f3d
LMI
71502011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7151
7152 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7153 value for non-existent files.
7154
b885bf36
EZ
71552011-09-11 Eli Zaretskii <eliz@gnu.org>
7156
7157 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7158 set its "size" to -1. This will set the modtime_size field of
7159 the corresponding buffer to -1, which is what
7160 verify-visited-file-modtime expects for files that do not exist.
7161 (Bug#9139)
7162
6612f0bf
PE
71632011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7164
7165 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7166 here ...
7167 * lisp.h: ... from here. push_key_description is no longer
7168 defined in keyboard.c, so its declaration should not be in
7169 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7170 logically belongs with push_key_description.
7171
dfb3f755
PE
71722011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7173
7174 * buffer.h: Include <sys/types.h> instead of <time.h>.
7175 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7176 Problem reported by Herbert J. Skuhra.
7177
3134906c
LMI
71782011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7179
7180 * xml.c (parse_region): Make the parsing work for
7181 non-comment-starting XML files again (bug#9144).
7182
8d903f4e
AS
71832011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7184
7185 * image.c (gif_load): Fix calculation of bottom and right corner.
7186 (Bug#9468)
7187
80ad64f4
EZ
71882011-09-10 Eli Zaretskii <eliz@gnu.org>
7189
7190 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7191 redisplay in small windows.
7192
208a048d
EZ
71932011-09-09 Eli Zaretskii <eliz@gnu.org>
7194
7195 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7196
9b1c252e
MR
71972011-09-08 Martin Rudalics <rudalics@gmx.at>
7198
7199 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7200 Operate on live windows only.
7201
2949f33b
JB
72022011-09-08 Juanma Barranquero <lekktu@gmail.com>
7203
7204 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7205
e08dcafd
EZ
72062011-09-07 Eli Zaretskii <eliz@gnu.org>
7207
7208 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7209 only under bidi iteration.
7210
115b96bd
JD
72112011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7212
7213 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7214
c8199d0f
PE
72152011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7216
7217 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7218 Without this fix, the command to link temacs failed due to an
7219 undefined symbol __builtin_isnan. This is because
7220 /usr/include/iso/math_c99.h #defines isnan(x) to
7221 __builtin_isnan(x), but the bundled gcc, which identifies itself
7222 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7223 a __builtin_isnan.
7224 * floatfns.c (isnan): #undef, and then #define to a clone of
7225 what's in data.c.
7226 (Fisnan): Always define, since it's always available now.
7227 (syms_of_floatfns): Always define isnan at the Lisp level.
7228
e39b275c 72292011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7230
7231 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7232
b2db44d9 72332011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7234
f4af5137 7235 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7236 The previous code assumed that file offsets (off_t values) fit in
7237 EMACS_INT variables, which is not true on typical 32-bit hosts.
7238 The code messed up by falsely reporting buffer overflow in cases
7239 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7240 when "big" contains more than 2**29 bytes, even though this
7241 inserts just one byte and does not overflow the buffer.
7242 (Finsert_file_contents): Store file offsets as off_t
7243 values, not as EMACS_INT values. Check for overflow when
7244 converting between EMACS_INT and off_t. When checking for
7245 buffer overflow or for overlap, take the offsets into account.
7246 Don't use EMACS_INT for small values where int suffices.
7247 When checking for overlap, fix a typo: ZV was used where
7248 ZV_BYTE was intended.
7249 (Fwrite_region): Don't assume off_t fits into 'long'.
7250 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7251
ecfc0a49
MA
72522011-09-05 Michael Albinus <michael.albinus@gmx.de>
7253
7254 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7255
6511acf2 72562011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7257
0999621a 7258 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7259
7260 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7261 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7262 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7263 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7264 (modify_event_symbol): Do not assume that the length of
7265 name_alist_or_stem is safe to alloca and fits in int.
7266 (Fexecute_extended_command): Likewise for function name and binding.
7267 (Frecursion_depth): Wrap around reliably on integer overflow.
7268 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7269 since some callers pass EMACS_INT values.
7270 (Fsingle_key_description): Don't crash if symbol name contains more
7271 than MAX_ALLOCA bytes.
7272 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7273 (get_minibuffer): Arg is now EMACS_INT, not int.
7274 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7275 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7276 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7277
2be7d702
PE
7278 * dbusbind.c (signature_cat): New function.
7279 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7280 Do not overrun buffer; instead, report string overflow.
7281
9d1df220
PE
7282 * dispnew.c (add_window_display_history): Don't overrun buffer.
7283 Truncate instead; this is OK since it's just a log.
7284
33ef5c64
PE
7285 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7286 even if the time zone offset is outlandishly large.
7287 Don't mishandle offset == INT_MIN.
7288
66c6fdd5
PE
7289 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7290 when creating daemon; the previous buffer-overflow check was incorrect.
7291
d749b01b
PE
7292 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7293 which has the guts of the old verror function.
7294
b5cd1905
PE
7295 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7296 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7297
6e1a67fb
PE
7298 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7299 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7300 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7301 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7302 length of string rather than counting it via multiple sprintfs;
7303 that's simpler and more reliable.
c21721cc
PE
7304 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7305 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7306 sprintf, in case result does not fit in int.
7307
c57b67fc
PE
7308 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7309 (fontset_from_font): Print it.
7310
8a401434
PE
7311 * frame.c (tty_frame_count): Now printmax_t, not int.
7312 (make_terminal_frame, set_term_frame_name): Print it.
7313 (x_report_frame_params): In X, window IDs are unsigned long,
7314 not signed long, so print them as unsigned.
7315 (validate_x_resource_name): Check for implausibly long names,
7316 and don't assume name length fits in 'int'.
7317 (x_get_resource_string): Don't blindly alloca invocation name;
7318 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7319 not fit in int.
7320
6e1a67fb
PE
7321 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7322 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7323 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7324
0df02bf3
PE
7325 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7326 Use esprintf, not sprintf, in case result does not fit in int.
7327
48e30793
PE
7328 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7329 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7330 it as a large positive number.
7331 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7332 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7333
a66ff6d8
PE
7334 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7335 in case result does not fit in int.
7336
aca216ff
PE
7337 * print.c (float_to_string): Detect width overflow more reliably.
7338 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7339 buffer overrun. Don't assume list length fits in 'int'. Treat
7340 print length of 0 as 0, not as infinity; to be consistent with other
7341 uses of print length in this function. Don't overflow print length
7342 index. Don't assume hash table size fits in 'long', or that
7343 vectorlike size fits in 'unsigned long'.
7344
31c286f7
PE
7345 * process.c (make_process): Use printmax_t, not int, to format
7346 process-name gensyms.
7347
55e5faa1
PE
7348 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7349
80f2e268
PE
7350 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7351 to avoid potential buffer overrun.
7352
670741ab
PE
7353 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7354 if X resource line is longer than 512 bytes.
7355
b7163a50
PE
7356 * xfns.c (x_window): Make sprintf buffer a bit bigger
7357 to avoid potential buffer overrun.
7358
ae58ff1f
PE
7359 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7360
c43c8a6a
PE
7361 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7362
3f8236f4
PE
73632011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7364
53e9fe90 7365 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7366 Without these, Emacs silently mishandles large integers sometimes.
7367 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7368 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7369
6511acf2
PE
7370 * xdisp.c (try_window_id): Check Emacs fixnum range before
7371 converting to 'int'.
806add1d 7372
6511acf2 7373 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7374 Check that an Emacs fixnum is in range before assigning it to 'int'.
7375 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7376 values converted from Emacs fixnums.
7377 (Frecenter): Don't wrap around a line count if it is out of 'int'
7378 range; instead, treat it as an extreme value.
7379 (Fset_window_configuration, compare_window_configurations):
7380 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7381
6511acf2
PE
7382 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7383 that can exceed INT_MAX. Check that EMACS_INT value is in range
7384 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7385 (match_limit): Don't assume that a fixnum can fit in 'int'.
7386
6511acf2 7387 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7388 exceed INT_MAX.
7389
6511acf2 7390 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7391 (Fvertical_motion): Don't wrap around LINES values that don't fit
7392 in 'int'. Instead, treat them as extreme values. This is good
7393 enough for windows, which can't have more than INT_MAX lines anyway.
7394
fcb901a7
LMI
73952011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7396
0f2f6b6d
LMI
7397 * Require libxml/parser.h to avoid compilation warning.
7398
fcb901a7
LMI
7399 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7400
7401 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7402 since this reportedly can destroy thread storage.
7403
6e20a0d4
CY
74042011-08-30 Chong Yidong <cyd@stupidchicken.com>
7405
7406 * syntax.c (find_defun_start): Update all cache variables if
7407 exiting early (Bug#9401).
7408
148ae00e
EZ
74092011-08-30 Eli Zaretskii <eliz@gnu.org>
7410
f6cfbd8f
EZ
7411 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7412
148ae00e
EZ
7413 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7414 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7415 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7416
7417 * term.c (tty_append_glyph): New function.
7418 (produce_stretch_glyph): Static function and its prototype deleted.
7419
a66cfb1c
SM
7420 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7421 Add prototypes.
148ae00e 7422
c4a07a4c
PE
74232011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7424
7425 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7426 when checking :margin (Bug#9390).
7427 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7428 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7429 so that the name doesn't mislead. All uses changed.
7430
6bc8cd65
JB
74312011-08-28 Johan Bockgård <bojohan@gnu.org>
7432
7433 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7434 set_tty_hooks.
7435
dca4927e
EZ
74362011-08-27 Eli Zaretskii <eliz@gnu.org>
7437
7438 * xdisp.c (move_it_to): Don't bail out early when reaching
7439 position beyond to_charpos, if we are scanning backwards.
7440 (move_it_vertically_backward): When DY == 0, make sure we get to
7441 the first character in the line after the newline.
7442
f2cad773
PE
74432011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7444
7445 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7446 (ccl_driver): Do not generate an out-of-range pointer.
7447 (Fccl_execute_on_string): Remove unnecessary check for
7448 integer overflow, noted by Stefan Monnier in
7449 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7450 Remove a FIXME that didn't need fixing.
7451 Simplify the newly-introduced buffer reallocation code.
7452
0cae2cdb
JB
74532011-08-27 Juanma Barranquero <lekktu@gmail.com>
7454
7455 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7456
5fc295a4 74572011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7458
70c60eb2 7459 Integer and memory overflow issues (Bug#9196).
726e0ab1 7460
d31850da
PE
7461 * doc.c (get_doc_string): Rework so that
7462 get_doc_string_buffer_size is the actual buffer size, rather than
7463 being 1 less than the actual buffer size; this makes xpalloc more
7464 convenient.
7465
a69fbedb
PE
7466 * image.c (x_allocate_bitmap_record, cache_image):
7467 * xselect.c (Fx_register_dnd_atom):
7468 Simplify previous changes by using xpalloc.
7469
fe5c5d37
PE
7470 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7471 since either will do and ptrdiff_t is convenient with xpalloc.
7472
0065d054
PE
7473 * charset.c (charset_table_size)
7474 (struct charset_sort_data.priority): Now ptrdiff_t.
7475 (charset_compare): Don't overflow if priorities differ greatly.
7476 (Fsort_charsets): Don't assume list length fits in int.
7477 Check for size-calculation overflow when allocating sort data.
7478 (syms_of_charset): Allocate an initial charset table that is
7479 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7480
7481 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7482
7483 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7484 The actual value is always <= INT_MAX, and leaving it unsigned made
7485 overflow checking harder.
7486
7487 * dispextern.h (struct glyph_matrix.rows_allocated)
7488 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7489 with xpalloc. The values are still always <= INT_MAX.
7490
7491 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7492
7493 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7494 (SAFE_NALLOCA): New macro.
7495
7496 * region-cache.c (struct boundary.pos, find_cache_boundary)
7497 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7498 (set_cache_region, invalidate_region_cache)
7499 (revalidate_region_cache, know_region_cache, region_cache_forward)
7500 (region_cache_backward, pp_cache):
7501 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7502 so that ptrdiff_t * can be passed to xpalloc.
7503 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7504 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7505 (pp_cache): Don't assume cache_len fits in int.
7506 * region-cache.h: Adjust extern decls to match.
7507
7508 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7509 EMACS_INT, since either will do, for xpalloc.
7510
7511 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7512 (xnmalloc, xnrealloc, xpalloc): New functions.
7513
726e0ab1
PE
7514 * bidi.c (bidi_shelve_header_size): New constant.
7515 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7516 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7517
51f30bc5 7518 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7519 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7520 (overlay_strings):
7521 Don't update size of array until after memory allocation succeeds,
7522 because xmalloc/xrealloc may not return.
0065d054
PE
7523 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7524 now that we have proper integer overflow checking.
7525 (record_overlay_string, overlay_strings): Catch overflows when
7526 calculating size of overlay_str_buf.
726e0ab1 7527
0065d054
PE
7528 * callproc.c (Fcall_process): Check for size overflow when
7529 calculating size of args2.
7530 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7531 Normally we prefer signed values, but sticking with ptrdiff_t would
7532 require adding more-complicated checks.
726e0ab1
PE
7533
7534 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7535 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7536 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7537 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7538
7539 * character.c (Fstring): Check for size-calculation overflow.
7540
7541 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7542 unnecessary integer overflow. Check for size overflow.
7543 (encode_coding_object): Don't update size until xmalloc succeeds.
7544
7545 * composite.c (get_composition_id): Check for overflow in glyph
7546 length calculations.
7547
7548 Integer and memory overflow fixes for display code.
7549 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7550 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7551 (scrolling_window): Check for overflow in size calculations.
7552 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7553 Don't assume glyph table len fits in int.
7554 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7555 (row_table_size): Now ptrdiff_t, not int.
7556 (scrolling_window): Avoid overflow in size calculations.
7557 Don't update size until allocation succeeds.
7558 * fns.c (concat): Check for overflow in size calculations.
7559 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7560 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7561 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7562
7563 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7564 (get_doc_string): Check for size calculation overflow.
7565 Don't update size until allocation succeeds.
7566 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7567 EMACS_INT, where ptrdiff_t will do.
7568 (Fsubstitute_command_keys): Check for string overflow.
7569
7570 * editfns.c (set_time_zone_rule): Don't assume environment length
7571 fits in int.
7572 (message_length): Now ptrdiff_t, not int.
7573 (Fmessage_box): Don't update size until allocation succeeds.
7574 Don't assume message length fits in int.
7575 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7576
0065d054
PE
7577 * emacs.c (main): Do not reallocate argv, since there is a null at
7578 the end that can be overwritten, and this way there's no need to
7579 worry about size-calculation overflow.
7580 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7581
7582 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7583 alloc succeeds.
7584 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7585
7586 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7587 (x_set_scroll_bar_width, x_figure_window_size):
7588 Check for integer overflow.
7589 (x_set_alpha): Do not assume XINT fits in int.
7590
7591 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7592 This is for the members text_lines, text_cols, total_lines, total_cols,
7593 where the system imposes an 'int' limit.
7594
7595 * fringe.c (Fdefine_fringe_bitmap):
7596 Don't update size until alloc works.
7597
7598 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7599 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7600
7601 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7602 Check for size-calculation overflow.
7603 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7604 do, as we prefer signed integers.
7605 (id_to_widget.max_size, id_to_widget.used)
7606 (xg_store_widget_in_map, xg_remove_widget_from_map)
7607 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7608 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7609 Use and return ptrdiff_t, not int.
7610 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7611 * gtkutil.h: Change prototypes to match the above.
7612
7613 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7614 are duplicate now that they've been promoted to lisp.h.
7615 (x_allocate_bitmap_record, x_alloc_image_color)
7616 (make_image_cache, cache_image, xpm_load):
7617 Don't update size until alloc is done.
7618 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7619 (x_detect_edges):
3256efce 7620 Check for size calculation overflow.
726e0ab1
PE
7621 (ct_colors_allocated_max): New constant.
7622 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7623 overflow.
3256efce 7624
726e0ab1
PE
7625 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7626 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7627 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7628 Use ptrdiff_t, not int, to count maps.
7629 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7630 calculations. Don't update size until allocation succeeds.
7631 Redo calculations to avoid overflow.
726e0ab1
PE
7632 * keyboard.h: Change prototypes to match the above.
7633
7634 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7635 to count maps.
7636 (current_minor_maps): Check for size calculation overflow.
7637 * keymap.h: Change prototypes to match the above.
7638
7639 * lread.c (read1, init_obarray): Don't update size until alloc done.
7640
7641 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7642 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7643
726e0ab1
PE
7644 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7645 Now ptrdiff_t, not int.
7646 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7647 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7648
7649 * process.c (Fnetwork_interface_list): Check for overflow
7650 in size calculation.
7651
7652 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7653
7654 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7655 overflow. Don't bother calling xmalloc when xrealloc will do.
7656
7657 * search.c (Freplace_match): Check for size calculation overflow.
7658 (Fset_match_data): Don't assume list lengths fit in 'int'.
7659
7660 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7661 for command line length. Do not attempt to address one before the
7662 beginning of an array, as that's not portable.
7663
7664 * term.c (max_frame_lines): Remove; unused.
7665 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7666 not int.
7667 (encode_terminal_code, calculate_costs): Check for size
7668 calculation overflow.
7669 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7670 table lengths and related sizes. Don't update size until alloc
7671 done. Redo calculations to avoid overflow.
7672 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7673
7674 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7675 subtracting pointers.
7676 (gobble_line): Check for overflow more carefully. Don't update size
7677 until alloc done.
7678
7679 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7680 Don't update size until alloc done.
7681 Redo size calculations to avoid overflow.
7682 Check for size calculation overflow.
0065d054 7683 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7684
7685 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7686 Use ptrdiff_t, not int, for sizes.
7687 (store_mode_line_noprop_char): Don't update size until alloc done.
7688
0065d054
PE
7689 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7690 Use ptrdiff_t, not int, for sizes.
7691 (Finternal_make_lisp_face, cache_face):
7692 Check for size calculation overflow.
7693 (cache_face): Treat size calculation overflows as if they were
7694 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7695
7696 * xfns.c (x_encode_text, x_set_name_internal)
7697 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7698 sizes, since they can exceed INT_MAX in size. Check for size
7699 calculation overflow.
7700
0065d054
PE
7701 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7702 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7703 Don't update size until alloc done.
7704
0065d054 7705 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7706 as sprintf is limited to int lengths.
1d526e2f 7707
252c5ee1
PE
7708 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7709 (X_LONG_MIN): New macros.
864d7ce7
PE
7710 Use them to make the following changes clearer.
7711 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7712 This change doesn't affect the value now, but it may help remind
7713 future maintainers not to raise the value too much later.
7714 (SELECTION_QUANTUM): Remove, replacing with ...
7715 (selection_quantum): ... new function, which avoids overflow.
7716 All uses changed.
7717 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7718 assumption that selection length fits in 'int'.
7719 (x_reply_selection_request, x_handle_selection_request)
7720 (x_get_window_property, receive_incremental_selection)
7721 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7722 (lisp_data_to_selection_data, clean_local_selection_data):
7723 Use ptrdiff_t, not int, to record length of selection.
7724 (x_reply_selection_request, x_get_window_property)
7725 (receive_incremental_selection, x_property_data_to_lisp):
7726 Redo calculations to avoid overflow.
7727 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7728 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7729 something.
7730 (x_get_window_property, receive_incremental_selection)
7731 (lisp_data_to_selection_data, x_property_data_to_lisp):
7732 Check for size-calculation overflow.
7733 (x_get_window_property, receive_incremental_selection)
7734 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7735 Don't store size until memory allocation succeeds.
7736 (x_get_window_property): Plug memory leak on memory exhaustion.
7737 Don't double-block input; malloc is safe here. Don't assume 2**34
7738 - 4 fits in unsigned long. Add an xassert to check
7739 XGetWindowProperty overflow. Be more careful about overflow
7740 calculations, and distinguish size from memory overflow better.
7741 (receive_incremental_selection): When tracing, don't assume
7742 unsigned int is less than INT_MAX.
7743 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7744 harmful) conversions of unsigned short to int.
7745 (lisp_data_to_selection_data): Don't assume that integers
7746 in the range -65535 through -1 fit in an X unsigned short.
7747 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7748 result parameters unless successful. Rely on cons_to_unsigned
7749 to report problems with elements; the old code wasn't right anyway.
7750 (x_check_property_data): Check for int overflow; we cannot use
7751 a wider type due to X limits.
7752 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7753
726e0ab1 7754 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7755
0065d054
PE
7756 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7757 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7758 (x_color_cells): Don't store size until memory allocation succeeds.
7759 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7760 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7761 (x_term_init): Don't assume length fits in int (sprintf is limited
7762 to int size).
bc18e09d 7763
ebfa62c0
PE
7764 Use ptrdiff_t for composition IDs.
7765 * character.c (lisp_string_width):
7766 * composite.c (composition_table_size, n_compositions)
7767 (get_composition_id, composition_gstring_from_id):
7768 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7769 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7770 * window.c (Frecenter):
7771 Use ptrdiff_t, not int, for composition IDs.
7772 * composite.c (get_composition_id): Check for integer overflow.
7773 * composite.h: Adjust prototypes to match the above changes.
7774
d3411f89
PE
7775 Use ptrdiff_t for hash table indexes.
7776 * category.c (hash_get_category_set):
7777 * ccl.c (ccl_driver):
7778 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7779 * coding.c (coding_system_charset_list, detect_coding_system):
7780 * coding.h (struct coding_system.id):
7781 * composite.c (get_composition_id, gstring_lookup_cache):
7782 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7783 * image.c (xpm_get_color_table_h):
7784 * lisp.h (hash_lookup, hash_put):
7785 * minibuf.c (Ftest_completion):
7786 Use ptrdiff_t for hash table indexes, not int (which is too
7787 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7788 32-bit --with-wide-int hosts).
7789
e097a6fa
PE
7790 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7791 Add a FIXME comment about memory leaks.
7792 (syms_of_charset): Don't assume xmalloc returns.
7793
5637687f
PE
7794 Don't assume that stated character widths fit in int.
7795 * character.c (Fchar_width, c_string_width, lisp_string_width):
7796 * character.h (CHAR_WIDTH):
7797 * indent.c (MULTIBYTE_BYTES_WIDTH):
7798 Use sanitize_char_width to avoid undefined and/or bad behavior
7799 with outlandish widths.
a66cfb1c 7800 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7801 now that we have two such functions. All uses changed.
7802 (sanitize_char_width): New inline function.
7803
a2271ba2
PE
7804 Don't assume that tab-width fits in int.
7805 * character.h (sanitize_width): New inline function.
7806 (SANE_TAB_WIDTH): New macro.
7807 (ASCII_CHAR_WIDTH): Use it.
7808 * indent.c (sane_tab_width): Remove. All uses replaced by
7809 SANE_TAB_WIDTH (current_buffer).
7810 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7811
18c52557
PE
7812 * fileio.c: Integer overflow issues with file modes.
7813 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7814
caeeedc1
PE
7815 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7816 Remove unreachable code.
7817 (read_hex, load_charset_map_from_file): Check for integer overflow.
7818
6df6ae42 7819 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7820 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7821 (x_send_scroll_bar_event): Likewise. Check that the size does not
7822 exceed limits imposed by XClientMessageEvent, as well as the usual
7823 ptrdiff_t and size_t limits.
7824
b13995db
PE
7825 * keyboard.c: Overflow, signedness and related fixes.
7826 (make_lispy_movement): Use same integer type in forward decl
7827 that is used in the definition.
7828 (read_key_sequence, keyremap_step):
7829 Change bufsize argument back to int, undoing my 2011-03-30 change.
7830 We prefer signed types, and int is wide enough here.
7831 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7832 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7833 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7834 length, not size_t. Use ptrdiff_t for index, not int.
7835 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7836 possibility of integer overflow.
7837
13464394
PE
7838 Overflow, signedness and related fixes for images.
7839
7840 * dispextern.h (struct it.stack[0].u.image.image_id)
7841 (struct_it.image_id, struct image.id, struct image_cache.size)
7842 (struct image_cache.used, struct image_cache.ref_count):
7843 * gtkutil.c (update_frame_tool_bar):
7844 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7845 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7846 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7847 * nsmenu.m (update_frame_tool_bar):
7848 * xdisp.c (calc_pixel_width_or_height):
7849 * xfns.c (image_cache_refcount):
7850 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7851 on typical 64-bit hosts.
7852
7853 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7854 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7855 Omit unnecessary casts to int.
7856 (parse_image_spec): Check that integers fall into 'int' range
7857 when the callers expect that.
7858 (image_ascent): Redo ascent calculation to avoid int overflow.
7859 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7860 (lookup_image): Remove unnecessary tests.
7861 (xbm_image_p): Locals are now of int, not EMACS_INT,
7862 since parse_image_check makes sure they fit into int.
7863 (png_load, gif_load, svg_load_image):
7864 Prefer int to unsigned where either will do.
7865 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7866 old tiff_error_handler and tiff_warning_handler.
7867 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7868 stack buffer overflows. It uses only the features of vsnprintf
7869 that are common to both POSIX and native Microsoft.
7870 (tiff_error_handler, tiff_warning_handler): Use it.
7871 (tiff_load, gif_load, imagemagick_load_image):
7872 Don't assume :index value fits in 'int'.
7873 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7874 (imagemagick_load_image): Check that crop parameters fit into
7875 the integer types that MagickCropImage accepts. Don't assume
7876 Vimagemagick_render_type has a nonnegative value. Don't assume
7877 size_t fits in 'long'.
7878 (gs_load): Use printmax_t to print the widest integers possible.
7879 Check for integer overflow when computing image height and width.
7880
c11821d4
EZ
78812011-08-26 Eli Zaretskii <eliz@gnu.org>
7882
7883 * xdisp.c (redisplay_window): Don't force window start if point
7884 will be invisible in the resulting window. (Bug#9324)
7885
0c95fcf7
EZ
78862011-08-25 Eli Zaretskii <eliz@gnu.org>
7887
7888 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7889 the display spec is of the form `(space ...)'.
7890 (handle_display_spec): Return the value returned by
7891 handle_single_display_spec, not just 1 or zero.
7892 (handle_single_display_spec): If the display spec is of the form
7893 `(space ...)', and specifies display in the text area, return 2
7894 rather than 1.
fee65a97 7895 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7896 accurately, and prefer exact match for point under bidi.
7897 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7898
7899 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7900 into disp_prop; all users changed.
7901
7902 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7903 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7904 for the text covered by the display property.
7905
e4ed06f1
CY
79062011-08-25 Chong Yidong <cyd@stupidchicken.com>
7907
7908 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7909 Change return value to nil.
7910 (Frecord_buffer): Delete unused function.
7911
f67cdd7f
EZ
79122011-08-24 Eli Zaretskii <eliz@gnu.org>
7913
5980d4c6
EZ
7914 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7915 buffers, return left-to-right.
8610fe8b
EZ
7916 (set_cursor_from_row): Consider candidate row a win if its glyph
7917 represents a newline and point is on that newline. Fixes cursor
7918 positioning on the newline at EOL of R2L text within L2R
7919 paragraph, and vice versa.
7920 (try_cursor_movement): Check continued rows, in addition to
7921 continuation rows. Fixes unwarranted scroll when point enters a
7922 continued line of R2L text within an L2R paragraph, or vice versa.
7923 (cursor_row_p): Consider the case of point being equal to
7924 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7925 from the end of a short line to the beginning of a continued line
7926 of R2L text within L2R paragraph.
7927 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7928 composed characters.
5980d4c6 7929
f67cdd7f
EZ
7930 * bidi.c (bidi_check_type): Use xassert.
7931 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7932 members.
7933
bca633fb
EZ
79342011-08-23 Eli Zaretskii <eliz@gnu.org>
7935
7936 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7937 a character.
7938
4a5885a7
CY
79392011-08-23 Chong Yidong <cyd@stupidchicken.com>
7940
7941 * nsfont.m (ns_otf_to_script): Fix typo.
7942
0902a04e
KH
79432011-08-22 Kenichi Handa <handa@m17n.org>
7944
7945 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7946 extra slot even if the purpose is char-code-property-table.
7947
1a2e6670
EZ
79482011-08-23 Eli Zaretskii <eliz@gnu.org>
7949
8ddde651
EZ
7950 * xdisp.c (redisplay_window): When computing centering_position,
7951 account for the height of the header line. (Bug#8874)
7952
425cc014
EZ
7953 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7954 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7955 candidate is selected by the mouse, and that candidate has a
7956 composed character under the mouse.
7957
1a2e6670
EZ
7958 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7959 coordinates reported by pos-visible-in-window-p for a composed
7960 character in column zero.
7961
8b76d6f8
SM
79622011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7963
7964 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7965
dac347dd
EZ
79662011-08-22 Eli Zaretskii <eliz@gnu.org>
7967
7968 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7969 consider it a hit if to_charpos is anywhere in the range of the
7970 composed buffer positions.
7971
e013fb34
CY
79722011-08-22 Chong Yidong <cyd@stupidchicken.com>
7973
7974 * image.c (gif_load): Don't assume that each subimage has the same
7975 dimensions as the base image. Handle disposal method that is
7976 "undefined" by the gif spec (Bug#9335).
7977
bd1ba3e8
CY
79782011-08-20 Chong Yidong <cyd@stupidchicken.com>
7979
7980 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7981 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7982
54a1215b
EZ
79832011-08-19 Eli Zaretskii <eliz@gnu.org>
7984
823564e5
EZ
7985 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7986 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7987 from an Org mode buffer to a Speedbar frame.
7988
54a1215b
EZ
7989 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7990 a composition, take its buffer position from IT->cmp_it.charpos.
7991 Fixes cursor positioning at the beginning of a line that begins
7992 with a composed character.
7993
9778ebcc
EZ
79942011-08-18 Eli Zaretskii <eliz@gnu.org>
7995
0be6ee06
EZ
7996 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7997 character bidirectional type, use STRONG_L instead. Fixes crashes
7998 in a buffer produced by `describe-categories'.
7999
9778ebcc
EZ
8000 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8001 members before the level stack, so they would be saved and
8002 restored when copying iterator state. Fixes incorrect reordering
8003 around TABs covered by display properties.
8004
156bffbe
AS
80052011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8006
6b02f655 8007 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8008
72ad093b
CY
80092011-08-17 Chong Yidong <cyd@stupidchicken.com>
8010
8011 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8012 (internal_condition_case_2, internal_condition_case_n):
8013 Remove unnecessary aborts (Bug#9081).
72ad093b 8014
35774242
EZ
80152011-08-17 Eli Zaretskii <eliz@gnu.org>
8016
8017 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8018 has no `load' handler, try opening the file locally. (Bug#9311)
8019
db76dd85
KB
80202011-08-16 Ken Brown <kbrown@cornell.edu>
8021
8022 * gmalloc.c: Expand comment.
8023
b215eee5
EZ
80242011-08-16 Eli Zaretskii <eliz@gnu.org>
8025
8026 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8027 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8028
a4579d33
KB
80292011-08-16 Ken Brown <kbrown@cornell.edu>
8030
8031 Fix memory allocation problems in Cygwin build (Bug#9273).
8032
8033 * unexcw.c ( __malloc_initialized): Declare external variable.
8034 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8035
8b76d6f8
SM
8036 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8037 New variables.
a4579d33
KB
8038 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8039 dumped emacs.
8040 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8041 in the static heap.
8042 [CYGWIN] (special_realloc): New function.
8043 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8044 requests to realloc storage in the static heap.
8045
3ebec551
PE
80462011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8047
8048 * bidi.c (bidi_initialize): Remove unused local.
8049
9fd8be00
EZ
80502011-08-15 Eli Zaretskii <eliz@gnu.org>
8051
6b02f655
SM
8052 * bidimirror.h:
8053 * biditype.h: Remove file.
8054 * makefile.w32-in ($(BLD)/bidi.$(O)):
8055 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8056
8057 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8058
8059 * chartab.c: Improve commentary for the uniprop_table API.
8060
32413314
EZ
8061 * bidi.c (bidi_paragraph_init): Support zero value of
8062 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8063 (bidi_initialize): Use uniprop_table instead of including
8064 biditype.h and bidimirror.h.
32413314 8065
9fd8be00
EZ
8066 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8067 coordinates of the iterator when restoring from ppos_it.
8068 (Bug#9296)
8069
5cf2b69b
KH
80702011-08-14 Kenichi Handa <handa@m17n.org>
8071
8072 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8073 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8074
daf17d00
EZ
80752011-08-14 Eli Zaretskii <eliz@gnu.org>
8076
8077 * xdisp.c (move_it_in_display_line_to): Don't invoke
8078 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8079 ppos_it. Fixes vertical cursor motion when line beginning is
8080 covered by an image. (Bug#9296)
8081
08e3161a
JD
80822011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8083
8084 * nsterm.h (ns_run_ascript): Declare.
8085 (NSAPP_DATA2_RUNASSCRIPT): Define.
8086
8087 * nsfns.m (as_script, as_result, as_status): New static variables.
8088 (ns_run_ascript): New function.
5e617bc2 8089 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8090 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8091 the event loop. Get status from as_status (Bug#7276).
8092
8093 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8094 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8095 the event loop (Bug#7276).
8096
a3720aa2
AS
80972011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8098
8099 * gnutls.c (QCgnutls_bootprop_priority)
8100 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8101 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8102 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8103 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8104 (QCgnutls_bootprop_verify_hostname_error)
8105 (QCgnutls_bootprop_callbacks_verify): Rename from
8106 Qgnutls_bootprop_..., all uses changed.
8107
8108 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8109 uses changed.
8110
0a0d27fb
PE
81112011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8112
19d5c50c
PE
8113 * xfaces.c (Qframe_set_background_mode): Now static.
8114 * dispextern.h (Qframe_set_background_mode): Remove decl.
8115
0a0d27fb
PE
8116 * process.c (Fnetwork_interface_info): Declare local only if needed.
8117
377538cb
JD
81182011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8119
8120 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8121 (Fnetwork_interface_list): Allocate in increments of bytes instead
8122 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8123 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8124 sockaddr.
8125 (struct ifflag_def): notrailers is smart on OSX.
8126 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8127 Get hardware address with getifaddrs if available.
8128
08fff70c
EZ
81292011-08-12 Eli Zaretskii <eliz@gnu.org>
8130
8131 * xdisp.c (iterate_out_of_display_property): xassert that
8132 IT->position is set to within IT->object's boundaries. Break from
8133 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8134 when IT->position is set up wrongly due to some bug.
8135 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8136 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8137 entry. Force push_it to save on the stack the current
8138 buffer/string position, to be restored by pop_it. Fix flags in
8139 the iterator structure wrt the object coming from a display
8140 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8141 properties. (Bug#9284)
8142
7be1c708 81432011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8144
7be1c708
CY
8145 * fontset.c (fontset_get_font_group): Add proper type checks.
8146 (Bug#9172)
aac0c6e3 8147
7be1c708 81482011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8149
7be1c708
CY
8150 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8151 and LC_VERSION_MIN_MACOSX.
8152 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8153 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8154
97bb72a6
EZ
81552011-08-08 Eli Zaretskii <eliz@gnu.org>
8156
8157 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8158 no-display-properties-and-no-overlays under bidi display.
8159 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8160 properties and overlays.
97bb72a6 8161
d5617611
CY
81622011-08-08 Chong Yidong <cyd@stupidchicken.com>
8163
37e11a63
CY
8164 * editfns.c (Fset_time_zone_rule): Document relationship with the
8165 setenv function.
8166
d5617611
CY
8167 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8168 the font entity extracted from the cache (Bug#8109).
8169
58872834
CY
81702011-08-07 Chong Yidong <cyd@stupidchicken.com>
8171
8172 * composite.c (autocmp_chars): Don't reset point. That is done by
8173 restore_point_unwind (Bug#5984).
8174
75bfc667
JL
81752011-08-07 Juri Linkov <juri@jurta.org>
8176
8177 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8178 to show the arg `TIME' instead of `TIMEVAL'.
8179
d1410150
EZ
81802011-08-06 Eli Zaretskii <eliz@gnu.org>
8181
8182 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8183 display property strides EOL and includes a newline, as in
8184 longlines-mode. (Bug#9254)
75b771e4
EZ
8185 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8186 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8187
8188 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8189 is non-zero, even if the data buffer is NULL. Fixes a crash in
8190 vertical-motion with longlines-mode. (Bug#9254)
8191
35928349
EZ
81922011-08-05 Eli Zaretskii <eliz@gnu.org>
8193
ec7cc85b
EZ
8194 * bidi.c <bidi_cache_total_alloc>: Now static.
8195 (bidi_initialize): Initialize bidi_cache_total_alloc.
8196
8b76d6f8 8197 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8198 cache. (Bug#9221)
8199
8200 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8201 amount allocated this far in `bidi_cache_total_alloc'.
8202 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8203 non-zero, only free the data buffer without restoring the cache
8204 contents. All callers changed.
8205
8206 * dispextern.h (bidi_unshelve_cache): Update prototype.
8207
8208 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8209 (move_it_in_display_line, move_it_to)
8210 (move_it_vertically_backward, move_it_by_lines): Replace the call
8211 to xfree to an equivalent call to bidi_unshelve_cache.
8212 (move_it_in_display_line_to): Fix logic of returning
412b6358 8213 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8214
e2e2423b
EZ
82152011-08-05 Eli Zaretskii <eliz@gnu.org>
8216
8217 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8218 came from a string character with a `cursor' property. (Bug#9229)
8219
ae9e757a
JD
82202011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8221
8222 * Makefile.in (LIB_PTHREAD): New variable.
8223 (LIBES): Add LIB_PTHREAD (Bug#9216).
8224
8225 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8226 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8227
213bd7f2
AS
82282011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8229
6b02f655 8230 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8231
99aaf75f
JD
82322011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8233
8234 * xterm.c (x_find_topmost_parent): New function.
8235 (x_set_frame_alpha): Find topmost parent window with
8236 x_find_topmost_parent and set the property there also (bug#9181).
8237 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8238
c74e9d86
PE
82392011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8240
8241 * callproc.c (Fcall_process): Avoid vfork clobbering
8242 the local vars buffer, coding_systems, current_dir.
8243
640c8776
SM
82442011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8245
8246 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8247
f26d0e4c
PE
82482011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8249
8a10d76c
PE
8250 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8251 so that it is not optimized away.
8252
f26d0e4c
PE
8253 * xdisp.c (compute_display_string_pos): Remove unused local.
8254
55439c61
EZ
82552011-08-02 Eli Zaretskii <eliz@gnu.org>
8256
8257 Fix slow cursor motion and scrolling in large buffers with
8258 selective display, like Org Mode buffers. (Bug#9218)
8259
8260 * dispextern.h (struct bidi_it): New member disp_prop_p.
8261
8262 * xdisp.c: Remove one-slot cache of display string positions.
8263 (compute_display_string_pos): Accept an additional argument
5e617bc2 8264 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8265 for a display string or property. If found, set DISP_PROP_P
8266 non-zero.
8267
8268 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8269 DISP_PROP_P, and pass it to compute_display_string_pos.
8270 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8271 non-zero. All callers of bidi_fetch_char changed.
8272
fb33fa43
SM
82732011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8274
8275 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8276
b099e063
DM
82772010-12-03 Don March <don@ohspite.net>
8278
8279 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8280 last character M-[char] is translated to ESC [char] (bug#7541).
8281
5cc7f7af
KH
82822011-08-02 Kenichi Handa <handa@m17n.org>
8283
d0fffa3f 8284 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8285
8286 * chartab.c (uniprop_table): Make it non-static.
8287
525d5e6e
EZ
82882011-08-01 Eli Zaretskii <eliz@gnu.org>
8289
8290 * xdisp.c (forward_to_next_line_start): Accept additional argument
8291 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8292 on the newline.
8293 (reseat_at_next_visible_line_start): Use the bidi iterator state
8294 returned by forward_to_next_line_start to restore the state of
8295 it->bidi_it after backing up to previous newline. (Bug#9212)
8296
31011111
AS
82972011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8298
8299 * regex.c (re_comp): Protoize.
8300 (re_exec): Fix return type.
8301 (regexec): Fix type of `ret'. (Bug#9203)
8302
476371c4
PE
83032011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8304
e5d76069
PE
8305 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8306 This is needed if max-image-size is a floating-point number.
8307
9a79b20c
AS
83082011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8309
8310 * print.c (print_object): Print empty symbol as ##.
8311
8312 * lread.c (read1): Read ## as empty symbol.
8313
d8c2fa78
AA
83142011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8315
8316 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8317 setting frame foreground color (Bug#9175).
8318 (x_set_background_color): Likewise.
8319
ffe57a7a
AA
8320 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8321 contents (Bug#9176).
8322 (EmacsTooltip -init): Remove bezels and add shadows to
8323 tooltip windows.
8324
bf3492a5
AA
8325 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8326 or scroll bar (Bug#8470).
8327
d55e9c53
AA
8328 * nsfont.m (nsfont_open): Remove assignment to voffset and
8329 unnecessary vars hshink, expand, hd, full_height, min_height.
8330 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8331
8332 * nsterm.h (nsfont_info): Remove voffset field.
8333
d8c2fa78 83342011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8335
8336 Implement strike-through and overline on NextStep (Bug#8863).
8337
8338 * nsfont.m (nsfont_open): Use underline position provided by font,
8339 instead of hard-coded value of 2.
8340 (nsfont_draw): Call ns_draw_text_decoration instead.
8341
8342 * nsterm.h: Add declaration for ns_draw_text_decoration.
8343
8344 * nsterm.m (ns_draw_text_decoration): New function for drawing
8345 underline, overline, and strike-through.
8346 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8347 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8348 accommodate underlining, etc.
4843aac3 8349
4cc60b9b
EZ
83502011-07-28 Eli Zaretskii <eliz@gnu.org>
8351
bc7ece87
EZ
8352 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8353 default.
4cc60b9b 8354
476371c4
PE
83552011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8356
66606eea
PE
8357 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8358 Without this fix, if a signal arrives just after memory fills up,
8359 'malloc' might be invoked reentrantly.
8360
476371c4
PE
8361 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8362 In other words, assume that every image size is allowed, on non-X
8363 hosts. This assumption is probably wrong, but it lets Emacs compile.
8364
f3fcc40d
AS
83652011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8366
8367 * regex.c (re_iswctype): Convert return values to boolean.
8368
350c992f
EZ
83692011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8370
8371 * xdisp.c (compute_display_string_pos): Don't use cached display
8372 string position if the buffer had its restriction changed.
8373 (Bug#9184)
8374
5266b4bb
PE
83752011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8376
8377 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8378
2573a837 83792011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8380
41f55ccd 8381 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8382
39e378da
PE
8383 * bidi.c: Integer size and overflow fixes.
8384 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8385 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8386 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8387 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8388 (bidi_find_other_level_edge):
8389 Use ptrdiff_t instead of EMACS_INT where either will do.
8390 This works better on 32-bit hosts configured --with-wide-int.
8391 (bidi_cache_ensure_space): Check for size-calculation overflow.
8392 Use % rather than repeated addition, for better worst-case speed.
8393 Don't set bidi_cache_size until after xrealloc returns, because it
8394 might not return.
8395 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8396 (bidi_cache_ensure_space): Also check that the bidi cache size
8397 does not exceed that of the largest Lisp string or buffer. See Eli
8398 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8399
5e927815
PE
8400 * alloc.c (__malloc_size_t): Remove.
8401 All uses replaced by size_t. See Andreas Schwab's note
8402 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8403
ca4aa935
PE
8404 * image.c: Improve checking for integer overflow.
8405 (check_image_size): Assume that f is nonnull, since
8406 it is always nonnull in practice. This is one less thing to
8407 worry about when checking for integer overflow later.
8408 (x_check_image_size): New function, which checks for integer
8409 overflow issues inside X.
8410 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8411 This removes the need for a memory_full check.
8412 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8413 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8414 (xbm_read_bitmap_data): Change locals back to 'int', since
8415 their values must fit in 'int'.
8416 (xpm_load_image, png_load, tiff_load):
8417 Invoke x_create_x_image_and_pixmap earlier,
8418 to avoid much needless work if the image is too large.
8419 (tiff_load): Treat overly large images as if
8420 x_create_x_image_and_pixmap failed, not as malloc failures.
8421 (gs_load): Use x_check_image_size.
8422
5f8f9cc2
PE
8423 * gtkutil.c: Omit integer casts.
8424 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8425 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8426
5adf60bc
PE
8427 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8428
c8907a93
PE
8429 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8430 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8431 would wrongly return t on a 64-bit host.
8432
e3c25c68
PE
8433 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8434 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8435 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8436 and therefore cause GCC to emit a bogus diagnostic in some cases.
8437
3f791afe
PE
8438 * image.c: Integer signedness and overflow and related fixes.
8439 This is not an exhaustive set of fixes, but it's time to
8440 record what I've got.
8441 (lookup_pixel_color, check_image_size): Remove redundant decls.
8442 (check_image_size): Don't assume that arbitrary EMACS_INT values
8443 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8444 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8445 (tiff_load, imagemagick_load_image):
8446 Check for overflow in size calculations.
8447 (x_create_x_image_and_pixmap): Remove unnecessary test for
8448 xmalloc returning NULL; that can't happen.
8449 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8450 (xpm_color_bucket): Use better integer hashing function.
8451 (xpm_cache_color): Don't possibly over-allocate memory.
8452 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8453 (gif_memory_source):
8454 Use ptrdiff_t, not int or size_t, to record sizes.
8455 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8456 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8457 either works, as we prefer signed integers.
8458 (tiff_read_from_memory, tiff_write_from_memory):
8459 Return tsize_t, not size_t, since that's what the TIFF API wants.
8460 (tiff_read_from_memory): Don't fail simply because the read would
8461 go past EOF; instead, return a short read.
8462 (tiff_load): Omit no-longer-needed casts.
8463 (Fimagemagick_types): Don't assume size fits into 'int'.
8464
3cc5a532
PE
8465 Improve hashing quality when configured --with-wide-int.
8466 * fns.c (hash_string): New function, taken from sxhash_string.
8467 Do not discard information about ASCII character case; this
8468 discarding is no longer needed.
8469 (sxhash-string): Use it. Change sig to match it. Caller changed.
8470 * lisp.h: Declare it.
8471 * lread.c (hash_string): Remove, since we now use fns.c's version.
8472 The fns.c version returns a wider integer if --with-wide-int is
8473 specified, so this should help the quality of the hashing a bit.
8474
b312a492
PE
8475 * emacs.c: Integer overflow minor fix.
8476 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8477 Define only if GNU_LINUX.
8478 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8479
dfd153ae
PE
8480 * dispnew.c: Integer signedness and overflow fixes.
8481 Remove unnecessary forward decls, that were a maintenance hassle.
8482 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8483 All uses changed.
8484 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8485 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8486 (prepare_desired_row, line_draw_cost):
8487 Use int, not unsigned, where either works.
8488 (save_current_matrix, restore_current_matrix):
8489 Use ptrdiff_t, not size_t, where either works.
8490 (init_display): Check for overflow more accurately, and without
8491 relying on undefined behavior.
8492
a81d11a3
PE
8493 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8494 Remove, replacing with the new symbols in lisp.h. All uses changed.
8495 * fileio.c (make_temp_name):
8496 * filelock.c (lock_file_1, lock_file):
8497 * xdisp.c (message_dolog):
8498 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8499 Use pMd etc. instead.
8500 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8501 replacing the pWIDE etc. symbols removed from editfns.c.
8502
3300e6fd
PE
8503 * keyboard.h (num_input_events): Now uintmax_t.
8504 This is (very slightly) less likely to mess up due to wraparound.
8505 All uses changed.
8506
fd05c7e9
PE
8507 * buffer.c: Integer signedness fixes.
8508 (alloc_buffer_text, enlarge_buffer_text):
8509 Use ptrdiff_t rather than size_t when either will do, as we prefer
8510 signed integers.
8511
903fe15d
PE
8512 * alloc.c: Integer signedness and overflow fixes.
8513 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8514 (__malloc_size_t): Default to size_t, not to int.
8515 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8516 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8517 Prefer ptrdiff_t to size_t when either would do, as we prefer
8518 signed integers.
8519 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8520 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8521 Now const. Initialize with values that are in range even if char
8522 is signed.
8523 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8524 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8525 These functions do the right thing with sizes > 2**32.
8526 (check_depth): Now ptrdiff_t, not int.
8527 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8528 Adjust to new way of storing sizes. Check for size overflow bugs
8529 in rest of code.
8530 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8531 slightly wrong anyway, as it missed one instance of
8532 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8533 (refill_memory_reserve): Omit needless cast to size_t.
8534 (mark_object_loop_halt): Mark as externally visible.
8535
ac82cc6a
PE
8536 * xselect.c: Integer signedness and overflow fixes.
8537 (Fx_register_dnd_atom, x_handle_dnd_message):
8538 Use ptrdiff_t, not size_t, since we prefer signed.
8539 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8540 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8541 x_dnd_atoms_size and x_dnd_atoms_length.
8542
c2d1e36d
PE
8543 * doprnt.c: Prefer signed to unsigned when either works.
8544 * eval.c (verror):
8545 * doprnt.c (doprnt):
8546 * lisp.h (doprnt):
8547 * xdisp.c (vmessage):
8548 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8549 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8550 prefer signed arithmetic to avoid comparison confusion.
8551 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8552 but is a bit tricky.
8553
0e926e56
PE
8554 Assume freestanding C89 headers, string.h, stdlib.h.
8555 * data.c, doprnt.c, floatfns.c, print.c:
8556 Include float.h unconditionally.
8557 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8558 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8559 * regex.c: Likewise for stddef.h, string.h.
8560 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8561 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8562 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8563 (STDC_HEADERS): Remove obsolete defines.
8564 * sysdep.c: Include limits.h unconditionally.
8565
9cfdb3ec
PE
8566 Assume support for memcmp, memcpy, memmove, memset.
8567 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8568 * regex.c (memcmp, memcpy):
8569 Remove; we assume C89 now.
8570
8571 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8572 (__malloc_safe_bcopy): Remove; no longer needed.
8573
cf950e6b 8574 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8575 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8576 well either way, and we prefer signed to unsigned.
8577
dbf38e02
LMI
85782011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8579
8580 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8581 closes the connection while we're reading (bug#9182).
8582
d6f0886c 85832011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8584
d6f0886c
JD
8585 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8586 are specified (Bug#9168).
24e0f6b1 8587
2eb1f9e6
PE
85882011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8589
8590 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8591 Found by GCC static checking and --with-wide-int on a 32-bit host.
8592
22381272 85932011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8594
8595 * xdisp.c (compute_display_string_pos): Fix logic of caching
8596 previous display string position. Initialize cached_prev_pos to
8597 -1. Fixes slow-down at the beginning of a buffer.
8598
f25e39b4
EZ
85992011-07-24 Eli Zaretskii <eliz@gnu.org>
8600
8601 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8602 for attrs[LFACE_FONTSET_INDEX].
8603
04c4b52e
PE
86042011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8605
8606 * xml.c (parse_region): Remove unused local
8607 that was recently introduced.
8608
c1734fbd
EZ
86092011-07-23 Eli Zaretskii <eliz@gnu.org>
8610
be18c5a5
EZ
8611 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8612 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8613
c1734fbd
EZ
8614 * xdisp.c (move_it_in_display_line_to): Record the best matching
8615 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8616 exit if none of the characters scanned was an exact match.
8617 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8618 when exact match is impossible due to invisible text, and the
8619 lines are truncated.
8620
a258d627
JD
86212011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8622
8623 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8624 for OSX >= 10.7.
8625
b6d5a689
EZ
86262011-07-22 Eli Zaretskii <eliz@gnu.org>
8627
0f74f785
EZ
8628 Fix a significant slow-down of cursor motion with C-n, C-p,
8629 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8630 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8631 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8632 (next_element_from_buffer): Call compute_stop_pos_backwards to
8633 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8634 base_level_stop.
8635 (reseat): Don't look for prev_stop, as that could mean a very long
8636 run.
8637 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8638 <cached_disp_overlay_modiff>: Cache for last found display string
8639 position.
551918c1 8640 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8641 about the same buffer in the same area of character positions, and
8642 the buffer wasn't changed since the time the display string
8643 position was cached.
551918c1 8644
b2d0c91a
EZ
86452011-07-22 Eli Zaretskii <eliz@gnu.org>
8646
8647 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8648 is an integer, which is important for empty lines. (Bug#9149)
8649
043604ee
CY
86502011-07-22 Chong Yidong <cyd@stupidchicken.com>
8651
8652 * frame.c (Fmodify_frame_parameters): In tty case, update the
8653 default face if necessary (Bug#4238).
8654
da4adb04
CY
86552011-07-21 Chong Yidong <cyd@stupidchicken.com>
8656
8657 * editfns.c (Fstring_to_char): No need to explain what a character
8658 is in the docstring (Bug#6576).
8659
9abd0532
LMI
86602011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8661
8662 * xml.c (parse_region): Make sure we always return a tree.
8663
36881d16
HK
86642011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8665
8666 * xml.c (parse_region): If a document contains only comments,
8667 return that, too.
8668
1e98674d
LMI
86692011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8670
8671 * xml.c (make_dom): Return comments, too.
8672
590bd467
PE
86732011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8674
8675 Port to OpenBSD.
8676 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8677 and the surrounding thread.
8678 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8679 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8680 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8681 timer goes off.
8682 * s/openbsd.h (BROKEN_SIGIO): Define.
8683 * unexelf.c (unexec) [__OpenBSD__]:
8684 Don't update the .mdebug section of the Alpha COFF symbol table.
8685
f41628b2
LMI
86862011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8687
8688 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8689 (bug#8460).
8690
b59b67c5
PE
86912011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8692
15e3a074
PE
8693 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8694 This fixes some race conditions on the permissions of any newly
8695 created file.
8696
41bed37d
PE
8697 * alloc.c (valid_pointer_p): Use pipe, not open.
8698 This fixes some permissions issues when debugging.
8699
b59b67c5
PE
8700 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8701 If fchown fails to set both uid and gid, try to set just gid,
8702 as that is sometimes allowed. Adjust the file's mode to eliminate
8703 setuid or setgid bits that are inappropriate if fchown fails.
8704
925a6be7
SM
87052011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8706
8707 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8708 to compare Lisp_Objects.
8709 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8710 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8711 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8712
52968808
AS
87132011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8714
0a6a104b
AS
8715 * lread.c (read_integer): Unread even EOF character.
8716 (read1): Likewise. Properly record start position of symbol.
8717
52968808
AS
8718 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8719 symbol character follows.
8720
9e381cdd
PE
87212011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8722
8723 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8724 This works around a problem with the previous change to Fcopy_file.
8725 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8726 and without this change, GCC might complain about discarding
8727 fchown's return value.
8728
b5641435
JB
87292011-07-16 Juanma Barranquero <lekktu@gmail.com>
8730
8731 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8732
a8031457
PE
87332011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8734
8735 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8736
dd889327
LMI
87372011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8738
750c33f7
LMI
8739 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8740 it's used from the C level.
8741
dd889327
LMI
8742 * process.c: Use the same condition for POLL_FOR_INPUT in both
8743 keyboard.c and process.c (bug#1858).
8744
87e86684
LM
87452011-07-09 Lawrence Mitchell <wence@gmx.li>
8746
8747 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8748 (Fgnutls_boot): Use it.
8749
64348f40
AS
87502011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8751
8752 * doc.c (Fsubstitute_command_keys): Revert last change.
8753
1d698799
LMI
87542011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8755
f863868c
LMI
8756 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8757 quotes the next character, and doesn't affect other longer
8758 sequences (bug#8935).
8759
1d698799
LMI
8760 * lread.c (syms_of_lread): Clarify that is isn't only
8761 `eval-buffer' and `eval-defun' that's affected by
8762 `lexical-binding' (bug#8460).
8763
aa4b6df6
EZ
87642011-07-15 Eli Zaretskii <eliz@gnu.org>
8765
8766 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8767 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8768
5d856da6
PE
87692011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8770
ad6042bb
PE
8771 Fix minor problems found by static checking.
8772 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8773 (elsz): Now a signed constant, not a size_t var. We prefer signed
8774 types to unsigned, to avoid integer comparison confusion. Without
8775 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8776 "cannot optimize loop, the loop counter may overflow", a symptom
8777 of the confusion.
f00bbb22 8778 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8779 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8780
6468f31c
LMI
87812011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8782
49080b10
LMI
8783 * search.c (Fre_search_backward): Mention `case-fold-search' in
8784 all the re_search_* functions (bug#8138).
8785
6468f31c
LMI
8786 * keyboard.c (Fopen_dribble_file): Document when the file is
8787 closed (bug#8056).
8788
c965adc5
EZ
87892011-07-14 Eli Zaretskii <eliz@gnu.org>
8790
df9733bf
EZ
8791 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8792 bidi_cache_idx.
8793
0bb23927
EZ
8794 Support bidi reordering of display and overlay strings.
8795 * xdisp.c (compute_display_string_pos)
8796 (compute_display_string_end): Accept additional argument STRING.
8797 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8798 (reseat_to_string): Initialize bidi_it->string.s and
8799 bidi_it->string.schars.
8800 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8801 NULL (avoids a crash in bidi_paragraph_init).
8802 Initialize itb.string.lstring.
0bb23927
EZ
8803 (init_iterator): Call bidi_init_it only of a valid
8804 buffer position was specified. Initialize paragraph_embedding to
8805 L2R.
8806 (reseat_to_string): Initialize the bidi iterator.
8807 (display_string): If we need to ignore text properties of
8808 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8809 original value of -1 will not work with bidi.)
8810 (compute_display_string_pos): First arg is now struct
8811 `text_pos *'; all callers changed. Support display properties on
8812 Lisp strings.
8813 (compute_display_string_end): Support display properties on Lisp
8814 strings.
8815 (init_iterator, reseat_1, reseat_to_string): Initialize the
8816 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8817 when iterating on a string not from display properties).
640c8776
SM
8818 (compute_display_string_pos, compute_display_string_end):
8819 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8820 arrow keys.
8821 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8822 base_level_stop; instead, set base_level_stop to BEGV.
8823 Fixes crashes in vertical-motion.
0bb23927
EZ
8824 (next_element_from_buffer): Improve commentary for when
8825 the iterator is before prev_stop.
8826 (init_iterator): Initialize bidi_p from the default value of
8827 bidi-display-reordering, not from buffer-local value. Use the
8828 buffer-local value only if initializing for buffer iteration.
8829 (handle_invisible_prop): Support invisible properties on strings
8830 that are being bidi-reordered.
8831 (set_iterator_to_next): Support bidi reordering of C strings and
8832 Lisp strings.
8833 (next_element_from_string): Support bidi reordering of Lisp
8834 strings.
8835 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8836 (display_string): Support display of R2L glyph rows.
8837 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8838 (init_iterator): Don't initialize it->bidi_p for strings
8839 here.
8840 (reseat_to_string): Initialize it->bidi_p for strings here.
8841 (next_element_from_string, next_element_from_c_string)
8842 (next_element_from_buffer): Add xassert's for correspondence
8843 between IT's object being iterated and it->bidi_it.string
8844 structure.
8845 (face_before_or_after_it_pos): Support bidi iteration.
8846 (next_element_from_c_string): Handle the case of the first string
8847 character that is not the first one in the visual order.
8848 (get_visually_first_element): New function, refactored from common
8849 parts of next_element_from_buffer, next_element_from_string, and
8850 next_element_from_c_string.
8851 (tool_bar_lines_needed, redisplay_tool_bar)
8852 (display_menu_bar): Force left-to-right direction. Add a FIXME
8853 comment for making that be controlled by a user option.
8854 (push_it, pop_it): Save and restore the state of the
8855 bidi iterator. Save and restore the bidi_p flag.
8856 (pop_it): Iterate out of display property for string iteration as
8857 well.
8858 (iterate_out_of_display_property): Support iteration over strings.
8859 (handle_single_display_spec): Set up it->bidi_it for iteration
8860 over a display string, and call bidi_init_it.
8861 (handle_single_display_spec, next_overlay_string)
8862 (get_overlay_strings_1, push_display_prop): Set up the bidi
8863 iterator for displaying display or overlay strings.
8864 (forward_to_next_line_start): Don't use the shortcut if
8865 bidi-iterating.
8866 (back_to_previous_visible_line_start): If handle_display_prop
8867 pushed the iterator stack, restore the internal state of the bidi
8868 iterator by calling bidi_pop_it same number of times.
8869 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8870 and we are bidi-iterating, don't decrement the iterator position;
8871 instead, set the first_elt flag in the bidi iterator, to produce
8872 the same effect.
8873 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8874 (push_display_prop): xassert that we are iterating a buffer.
8875 (push_it, pop_it): Save and restore paragraph_embedding member.
8876 (handle_single_display_spec, next_overlay_string)
8877 (get_overlay_strings_1, reseat_1, reseat_to_string)
8878 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8879 correctly. Don't assume unibyte strings are not bidi-reordered.
8880 (compute_display_string_pos)
8881 (compute_display_string_end): Fix handling the case of C string.
8882 (push_it, pop_it): Save and restore from_disp_prop_p.
8883 (handle_single_display_spec, push_display_prop): Set the
8884 from_disp_prop_p flag.
8885 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8886 (pop_it): Call iterate_out_of_display_property only if we are
8887 popping after iteration over a string that came from a display
8888 property. Fix a typo in popping stretch info. Add an assertion
8889 for verifying that the iterator position is in sync with the bidi
8890 iterator.
8891 (handle_single_display_spec, get_overlay_strings_1)
8892 (push_display_prop): Fix initialization of paragraph direction for
8893 string when that of the parent object is not yet determined.
8894 (reseat_1): Call bidi_init_it to resync the bidi
8895 iterator with IT's position. (Bug#7616)
8896 (find_row_edges): If ROW->start.pos gives position
8897 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8898 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8899 Reset the from_disp_prop_p flag.
8900 (SAVE_IT, RESTORE_IT): New macros.
8901 (pos_visible_p, face_before_or_after_it_pos)
8902 (back_to_previous_visible_line_start)
8903 (move_it_in_display_line_to, move_it_in_display_line)
8904 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8905 (try_scrolling, redisplay_window, display_line): Use them when
8906 saving a temporary copy of the iterator and restoring it back.
8907 (back_to_previous_visible_line_start, reseat_1)
8908 (init_iterator): Empty the bidi cache "stack".
8909 (move_it_in_display_line_to): If iterator ended up at
8910 EOL, but we never saw any buffer positions smaller than
8911 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8912 motion in bidi-reordered lines.
8913 (move_it_in_display_line_to): Record prev_method and prev_pos
8914 immediately before the call to set_iterator_to_next. Fixes cursor
8915 motion in bidi-reordered lines with stretch glyphs and strings
8916 displayed in margins. (Bug#8133) (Bug#8867)
8917 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8918 TO_CHARPOS.
640c8776
SM
8919 (pos_visible_p): Support positions in bidi-reordered lines.
8920 Save and restore bidi cache.
0bb23927
EZ
8921
8922 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8923 (bidi_paragraph_info): Delete unused struct.
8924 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8925 (bidi_cache_start): New variable.
8926 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8927 to zero.
8928 (bidi_cache_fetch_state, bidi_cache_search)
8929 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8930 (bidi_cache_find, bidi_peek_at_next_level)
8931 (bidi_level_of_next_char, bidi_find_other_level_edge)
8932 (bidi_move_to_visually_next): Compare cache index with
8933 bidi_cache_start rather than with zero.
8934 (bidi_fetch_char): Accept new argument STRING; all callers
8935 changed. Support iteration over a string. Support strings with
8936 display properties. Support unibyte strings. Fix the type of
8937 `len' according to what STRING_CHAR_AND_LENGTH expects.
8938 (bidi_paragraph_init, bidi_resolve_explicit_1)
8939 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8940 (bidi_level_of_next_char, bidi_move_to_visually_next):
8941 Support iteration over a string.
0bb23927
EZ
8942 (bidi_set_sor_type, bidi_resolve_explicit_1)
8943 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8944 can now be zero (for strings); special values 0 and -1 were
8945 changed to -1 and -2, respectively.
8946 (bidi_char_at_pos): New function.
8947 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8948 Call it instead of FETCH_MULTIBYTE_CHAR.
8949 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8950 initialized to valid values.
8951 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8952 values.
8953 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8954 the test for valid cached positions. Fix the logic for looking up
8955 the sentinel state in the cache. GCPRO the Lisp string we are
8956 iterating.
8957 (bidi_push_it, bidi_pop_it): New functions.
8958 (bidi_initialize): Initialize the bidi cache start stack pointer.
8959 (bidi_cache_ensure_space): New function, refactored from part of
8960 bidi_cache_iterator_state. Don't assume the required size is just
8961 one BIDI_CACHE_CHUNK away.
8962 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8963 (bidi_count_bytes, bidi_char_at_pos): New functions.
8964 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8965 always valid if bidi_cache_idx is valid.
8966 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8967 is valid if it's going to be used.
8968 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8969 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8970 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8971 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8972 (bidi_find_other_level_edge, bidi_cache_start_stack):
8973 All variables related to cache indices are now EMACS_INT.
c965adc5 8974
0bb23927
EZ
8975 * dispextern.h (struct bidi_string_data): New structure.
8976 (struct bidi_it): New member `string'. Make flag members be 1-bit
8977 fields, and put them last in the struct.
640c8776
SM
8978 (compute_display_string_pos, compute_display_string_end):
8979 Update prototypes.
0bb23927
EZ
8980 (bidi_push_it, bidi_pop_it): Add prototypes.
8981 (struct iterator_stack_entry): New members bidi_p,
8982 paragraph_embedding, and from_disp_prop_p.
8983 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8984 (bidi_shelve_cache, bidi_unshelve_cache):
8985 Declare prototypes.
0bb23927
EZ
8986
8987 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8988 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8989 and vector-like objects.
8990
8991 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8992 cache around display iteration.
8993
8994 * window.c (Fwindow_end, window_scroll_pixel_based)
8995 (displayed_window_lines, Frecenter): Save and restore the bidi
8996 cache around display iteration.
8997
3bbd2265
LMI
89982011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8999
9000 * editfns.c (Fdelete_region): Clarify the use of the named
9001 parameters (bug#6788).
9002
adc47434
MR
90032011-07-14 Martin Rudalics <rudalics@gmx.at>
9004
9005 * indent.c (Fvertical_motion): Set and restore w->pointm when
9006 saving and restoring the window's buffer (Bug#9006).
9007
837c31f8
LMI
90082011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9009
9010 * editfns.c (Fstring_to_char): Clarify just what is returned
9011 (bug#6576). Text by Eli Zaretskii.
9012
ac389d0c
JB
90132011-07-13 Juanma Barranquero <lekktu@gmail.com>
9014
9015 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9016
0be0ce47
EZ
90172011-07-13 Eli Zaretskii <eliz@gnu.org>
9018
9019 * buffer.c (mmap_find): Fix a typo.
9020
cd18e7e3
JB
90212011-07-13 Johan Bockgård <bojohan@gnu.org>
9022
9023 Fix execution of x selection hooks.
9024 * xselect.c (Qx_lost_selection_functions)
9025 (Qx_sent_selection_functions): New vars.
9026 (syms_of_xselect): DEFSYM them.
9027 (x_handle_selection_request): Pass Qx_sent_selection_functions
9028 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9029 (x_handle_selection_clear,x_clear_frame_selections):
9030 Pass Qx_lost_selection_functions rather than
9031 Vx_lost_selection_functions to Frun_hook_with_args.
9032
47ea7f44
PE
90332011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9034
ac389d0c 9035 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9036 The old code sometimes used this field without initializing it.
9037
47ea7f44
PE
9038 * alloc.c (gc_sweep): Don't read past end of array.
9039 In theory, the old code could also have corrupted Emacs internals,
9040 though it'd be very unlikely.
9041
bc985c87
AS
90422011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9043
9044 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9045 argument. (Bug#4026)
bc985c87 9046
0cf34688
LMI
90472011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9048
b3dadd76
LMI
9049 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9050 key" (bug#4257).
9051
0cf34688
LMI
9052 * window.c (Fset_window_start): Doc fix (bug#4199).
9053 (Fset_window_hscroll): Ditto.
9054
270768cd
PE
90552011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9056
077e3dda 9057 Fix minor new problems caught by GCC 4.6.1.
270768cd 9058 * term.c (init_tty): Remove unused local.
490011a6 9059 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9060 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9061 not used otherwise.
270768cd 9062
b1f58454
CY
90632011-07-12 Chong Yidong <cyd@stupidchicken.com>
9064
9065 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9066
22b9578d
LMI
90672011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9068
6e70ab07
LMI
9069 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9070 are the mini-buffer and the echo area (bug#3320).
9071
22b9578d
LMI
9072 * term.c (init_tty): Remove support for supdup, c10 and perq
9073 terminals, which are no longer supported (bug#1482).
9074
8974cc9f
JB
90752011-07-10 Johan Bockgård <bojohan@gnu.org>
9076
9077 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9078
a560d974
JD
90792011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9080
9081 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9082 for non-popups (Bug#3642).
9083
1dae0f0a
AS
90842011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9085
268c2c36 9086 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9087 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9088 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9089 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9090 * data.c (fmod): Likewise.
9091 * dispnew.c (swap_glyphs_in_rows): Likewise.
9092 * emacs.c (memory_warning_signal): Likewise.
9093 * floatfns.c (float_error): Likewise.
9094 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9095 (otf_open, font_otf_capability, generate_otf_features)
9096 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9097 Likewise.
9098 * image.c (pbm_read_file): Likewise.
9099 * indent.c (string_display_width): Likewise.
9100 * intervals.c (check_for_interval, search_for_interval)
9101 (inc_interval_count, count_intervals, root_interval)
9102 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9103 * lread.c (defalias): Likewise.
268c2c36 9104 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9105 * regex.c (set_image_of_range_1, set_image_of_range)
9106 (regex_grow_registers): Likewise.
9107 * sysdep.c (strerror): Likewise.
9108 * termcap.c (valid_filename_p, tprint, main): Likewise.
9109 * tparam.c (main): Likewise.
9110 * unexhp9k800.c (run_time_remap, save_data_space)
9111 (update_file_ptrs, read_header, write_header, calculate_checksum)
9112 (copy_file, copy_rest, display_header): Likewise.
9113 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9114 Likewise.
9115 * xdisp.c (check_it): Likewise.
9116 * xfaces.c (register_color, unregister_color, unregister_colors):
9117 Likewise.
9118 * xfns.c (print_fontset_result): Likewise.
9119 * xrdb.c (member, fatal, main): Likewise.
9120
99033785
PE
91212011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9122
9123 Fix minor problems found by static checking (Bug#9031).
9124 * chartab.c (char_table_set_range, map_sub_char_table):
9125 Remove unused locals.
9126 (uniprop_table): Now static.
9127 * composite.c (_work_char): Remove unused static var.
9128
9cb2ac56
JB
91292011-07-09 Juanma Barranquero <lekktu@gmail.com>
9130
9131 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9132
f25661f0
JD
91332011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9134
9135 * gtkutil.c (qttip_cb): Remove code without function.
9136
8278c4fe
EZ
91372011-07-09 Eli Zaretskii <eliz@gnu.org>
9138
9139 * w32.c (pthread_sigmask): New stub.
9140
1692ae2d 91412011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9142
8a6ebd58 9143 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9144 sigprocmask is portable only for single-threaded applications, and
9145 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9146 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9147 (LIBES): Use it.
9148 * callproc.c (Fcall_process):
9149 * process.c (create_process):
9150 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9151 Use pthread_sigmask, not sigprocmask.
123403e4 9152
1b854618
JD
91532011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9154
9155 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9156 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9157 wrong (Bug#8591).
9158
3fe4b549
JD
91592011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9160
0ce7e563
JD
9161 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9162 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9163 (xg_hide_tooltip): Fix comment.
9164
3fe4b549
JD
9165 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9166 in registerServicesMenuSendTypes.
9167 (validRequestorForSendType): Don't check ns_return_types.
9168
9169 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9170 ns_return_type.
9171
5df75e47
JR
91722011-07-08 Jason Rumney <jasonr@gnu.org>
9173
22610910
JR
9174 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9175 SH_SHOW for hidden windows (Bug#5482).
9176
5df75e47
JR
9177 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9178 frame struct members of non-existent frames (Bug#6284).
9179
699c10bd
JD
91802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9181
4393663b
JD
9182 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9183 variable firstTime not needed on OSX >= 10.6.
9184 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9185 >= 10.5. Use setKnobProportion, setDoubleValue.
9186
9187 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9188 (MAC_OS_X_VERSION_10_5): Define if not defined.
9189 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9190 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9191 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9192
9193 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9194 cString and lossyCString on OSX >= 10.4.
4393663b 9195
58179cce 9196 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9197 sizeToFit on OSX >= 10.2.
9198
9199 * nsimage.m (allocInitFromFile): Don't use deprecated method
9200 bestRepresentationForDevice on OSX >= 10.6.
9201
9202 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9203 to avoid warning.
9204
9205 * emacs.c: Declare unexec_init_emacs_zone.
9206
a63e0781
JD
9207 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9208
699c10bd
JD
9209 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9210
9211 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9212 on svcsMenu (Bug#8842).
9213
9214 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9215 ns_return_types.
9216 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9217
9218 * nsterm.m (QUTF8_STRING): Declare.
9219 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9220 (validRequestorForSendType): Return type is (id).
9221 Change indexOfObjectIdenticalTo to indexOfObject.
9222 Check if we have local selection before returning self (Bug#8842).
9223 (writeSelectionToPasteboard): Put local selection into paste board
9224 if we have a local selection (Bug#8842).
9225 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9226
9227 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9228 (ns_get_local_selection): Declare.
9229
54e10184
LMI
92302011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9231
9888ff71
LMI
9232 * keymap.c (describe_map_tree): Don't insert a double newline at
9233 the end of the buffer (bug#1169) and return whether we inserted
9234 something.
9235
54e10184
LMI
9236 * callint.c (Fcall_interactively): Change "reading args" to
9237 "providing args" to try to clarify what it does (bug#1010).
9238
15fa4783
KH
92392011-07-07 Kenichi Handa <handa@m17n.org>
9240
9241 * composite.c (composition_compute_stop_pos): Ignore a static
9242 composition starting before CHARPOS (Bug#8915).
9243
9244 * xdisp.c (handle_composition_prop): Likewise.
9245
a8815b00
EZ
92462011-07-07 Eli Zaretskii <eliz@gnu.org>
9247
9248 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9249 (Bug#9015)
9250
ef7b981d 92512011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9252
9253 * character.h (unicode_category_t): New enum type.
9254
9255 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9256 (Qchar_code_property_table): New variable.
9257 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9258 (UNIPROP_COMPRESSED_FORM_P): New macros.
9259 (char_table_ascii): Uncompress the compressed values.
9260 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9261 Uncompress the compressed values.
ac389d0c 9262 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9263 (char_table_ref_and_range): Uncompress the compressed values.
9264 (sub_char_table_set): New arg is_uniprop. Callers changed.
9265 Uncompress the compressed values.
9266 (sub_char_table_set_range): Args changed. Callers changed.
9267 (char_table_set_range): Adjuted for the above change.
9268 (map_sub_char_table): Delete args default_val and parent. Add arg
9269 top. Give decoded values to a Lisp function.
640c8776 9270 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9271 values to a Lisp function. Gcpro more variables.
9272 (uniprop_table_uncompress)
9273 (uniprop_decode_value_run_length): New functions.
9274 (uniprop_decoder, uniprop_decoder_count): New variables.
9275 (uniprop_get_decoder, uniprop_encode_value_character)
9276 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9277 New functions.
9278 (uniprop_encoder, uniprop_encoder_count): New variables.
9279 (uniprop_get_encoder, uniprop_table)
9280 (Funicode_property_table_internal, Fget_unicode_property_internal)
9281 (Fput_unicode_property_internal): New functions.
9282 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9283 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9284 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9285 char-code-property-alist.
9286
640c8776 9287 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9288 Vunicode_category_table.
9289
640c8776 9290 * font.c (font_range): Adjust for the change of
c805dec0
KH
9291 Vunicode_category_table.
9292
76b397fb
DN
92932011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9294
9295 * m/iris4d.h: Remove file, move contents ...
9296 * s/irix6-5.h: ... here.
9297
22b4128e
PE
92982011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9299
9300 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9301 * alloc.c (mark_buffer):
9302 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9303 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9304 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9305 This isn't true in general, and it's particularly not true
9306 if Emacs is configured with --with-wide-int.
9307 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9308 New macros, used in the buffer.c change.
9309
869795d6
JD
93102011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9311
9312 * xsettings.c: Use both GConf and GSettings if both are available.
9313 (store_config_changed_event): Add comment.
9314 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9315 (store_tool_bar_style_changed): New functions.
5e617bc2 9316 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9317 (struct xsettings): Move font inside HAVE_XFT.
9318 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9319 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9320 Move inside HAVE_XFT.
640c8776 9321 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9322 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9323 also.
9324 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9325 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9326 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9327 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9328 (parse_settings): Move check for font inside HAVE_XFT.
9329 (read_settings, apply_xft_settings): Add comment.
9330 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9331 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9332 call store_font_name_changed.
9333 (xft_settings_event): Add comment.
9334 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9335 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9336 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9337 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9338 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9339 (xsettings_get_system_font, xsettings_get_system_normal_font):
9340 Add comment.
869795d6 9341
d8ed26bd
PE
93422011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9343
9344 Random fixes. E.g., (random) never returned negative values.
9345 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9346 subseconds part to the entropy, as that's a bit more random.
9347 Prefer signed to unsigned, since the signedness doesn't matter and
9348 in general we prefer signed. When given a limit, use a
9349 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9350 latter isn't right if USE_2_TAGS_FOR_INTS.
9351 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9352 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9353
cabf1cac
SM
93542011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9355
9356 * textprop.c (text_property_stickiness):
9357 Obey Vtext_property_default_nonsticky.
9358 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9359 * w32fns.c (syms_of_w32fns):
9360 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9361
6e9b2be9
PE
93622011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9363
9364 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9365 This is more efficient than Ffile_directory_p and avoids a minor race.
9366
90186c68
LMI
93672011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9368
7c301272
LMI
9369 * buffer.c (Foverlay_put): Say what the return value is
9370 (bug#7835).
9371
c4f2d8d4
LMI
9372 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9373 is a directory before asking whether to use the file name
9374 (bug#7564).
ad637907
LMI
9375 (barf_or_query_if_file_exists): Make the "File is a directory"
9376 error be more correct.
c4f2d8d4 9377
90186c68
LMI
9378 * fns.c (Frequire): Remove the mention of the .gz files, since
9379 that's installation-specific, but keep the mention of
9380 `get-load-suffixes'.
9381
da64016e
PE
93822011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9383
9384 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9385 Report string overflow if the output is too long.
9386
7d47b580
JB
93872011-07-04 Juanma Barranquero <lekktu@gmail.com>
9388
a555cb87
JB
9389 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9390 (syms_of_gnutls): Remove duplicate DEFSYM for
9391 Qgnutls_bootprop_verify_hostname_error, an error for
9392 Qgnutls_bootprop_verify_error (which is no longer used).
9393
7d47b580
JB
9394 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9395 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9396 Also (re)move comments that are misplaced or no longer relevant.
9397
1e49bfab
LMI
93982011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9399
9400 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9401
1485f4c0
CY
94022011-07-03 Chong Yidong <cyd@stupidchicken.com>
9403
9404 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9405 and background color parameters if they have been changed.
9406
a9ab721e
LMI
94072011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9408
9409 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9410
cf7cff57
PE
94112011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9412
2e13213d
PE
9413 * xsettings.c (SYSTEM_FONT): Define only when used.
9414 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9415
cf7cff57
PE
9416 * keymap.c (access_keymap_1): Now static.
9417
7a8e04f7
CY
94182011-07-02 Chong Yidong <cyd@stupidchicken.com>
9419
9420 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9421 leave any prefix arg for the up event (Bug#1586).
9422
61352f62
LMI
94232011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9424
69bb1ef7
LMI
9425 * lread.c (syms_of_lread): Mention single symbols defined by
9426 `defvar' or `defconst' (bug#7154).
9427
61352f62 9428 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9429 (Frequire): Mention get-load-suffixes.
61352f62 9430
28545e04
MR
94312011-07-02 Martin Rudalics <rudalics@gmx.at>
9432
9433 * window.h (window): Remove clone_number slot.
9434 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9435 Remove.
9436 (make_parent_window, make_window, saved_window)
9437 (Fset_window_configuration, save_window_save): Don't deal with
9438 clone numbers.
9439 * buffer.c (Qclone_number): Remove declaration.
9440 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9441
3349e122
SM
94422011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9443
9444 Add multiple inheritance to keymaps.
9445 * keymap.c (Fmake_composed_keymap): New function.
9446 (Fset_keymap_parent): Simplify.
9447 (fix_submap_inheritance): Remove.
9448 (access_keymap_1): New function extracted from access_keymap to handle
9449 embedded parents and handle lists of maps.
9450 (access_keymap): Use it.
9451 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9452 (Fcopy_keymap): Handle embedded parents.
9453 (Fcommand_remapping, define_as_prefix): Simplify.
9454 (Fkey_binding): Simplify.
9455 (syms_of_keymap): Move minibuffer-local-completion-map,
9456 minibuffer-local-filename-completion-map,
9457 minibuffer-local-must-match-map, and
9458 minibuffer-local-filename-must-match-map to Elisp.
9459 (syms_of_keymap): Defsubr make-composed-keymap.
9460 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9461 (parse_menu_item): Trivial simplification.
9462
3279eb87
GM
94632011-07-01 Glenn Morris <rgm@gnu.org>
9464
9465 * Makefile.in (SETTINGS_LIBS): Fix typo.
9466
4550efdf
KI
94672011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9468
9469 * coding.c (Fencode_coding_string): Record the last coding system
9470 used, as the function doc string says (bug#8738).
9471
0949d2b6
JD
94722011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9473
9474 * xsettings.c (store_monospaced_changed): Take new font as arg and
9475 check for change against current_mono_font.
9476 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9477 (emacs_settings_constructor, emacs_settings_get_property)
9478 (emacs_settings_set_property, emacs_settings_class_init)
9479 (emacs_settings_init, gsettings_obj): Remove.
9480 (something_changedCB): New function for HAVE_GSETTINGS.
9481 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9482 with value as argument.
9483 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9484 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9485 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9486 "changed".
9487
9488 * xgselect.c: Add defined (HAVE_GSETTINGS).
9489 (xgselect_initialize): Ditto.
9490
9491 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9492 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9493 xg_select.
9494
bbc6b304
PE
94952011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9496
9497 * eval.c (struct backtrace): Simplify and port the data structure.
9498 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9499 signed bit field, as this assumption is not portable and it makes
9500 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9501 "char debug_on_exit : 1" as this is not portable either; instead,
9502 use the portable "unsigned int debug_on_exit : 1". Remove unused
9503 member evalargs. Remove obsolete comments about cc bombing out.
9504
9851bfc5
JD
95052011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9506
51bb811f 9507 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9508 Let HAVE_GSETTINGS override HAVE_GCONF.
9509 (store_monospaced_changed): New function.
9510 (EMACS_SETTINGS): A new type derived from GObject to handle
9511 GSettings notifications.
9512 (emacs_settings_constructor, emacs_settings_get_property)
9513 (emacs_settings_set_property, emacs_settings_class_init):
9514 New functions.
9515 (gsettings_client, gsettings_obj): New variables.
9516 (GSETTINGS_SCHEMA): New define.
9517 (something_changedCB): Call store_monospaced_changed.
9518 (init_gsettings): New function.
9519 (xsettings_initialize): Call init_gsettings.
9520 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9521 to NULL.
9522
640c8776 9523 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9524 GCONF_CFLAGS/LIBS.
9525
5386012d
MR
95262011-06-29 Martin Rudalics <rudalics@gmx.at>
9527
9528 * window.c (resize_root_window, grow_mini_window)
9529 (shrink_mini_window): Rename Qresize_root_window to
9530 Qwindow_resize_root_window and Qresize_root_window_vertically to
9531 Qwindow_resize_root_window_vertically.
9532
f13e0b08
PE
95332011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9534
9535 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9536
94515237
JB
95372011-06-27 Juanma Barranquero <lekktu@gmail.com>
9538
9539 * makefile.w32-in: Redesign dependencies so they reflect more
9540 clearly which files are directly included by each source file,
9541 and not through other includes.
9542
e43b6e43
MR
95432011-06-27 Martin Rudalics <rudalics@gmx.at>
9544
9545 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9546 (sort_overlays, overlay_strings): When an overlay's clone number
9547 matches the window's clone number process the overlay even if
9548 the overlay's window property doesn't match the current window.
9549
d68443dc
MR
9550 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9551 (Fwindow_hchild): Rename to Fwindow_left_child.
9552 (Fwindow_next): Rename to Fwindow_next_sibling.
9553 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9554 (resize_window_check): Rename to window_resize_check.
9555 (resize_window_apply): Rename to window_resize_apply.
9556 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9557 (Fdelete_other_windows_internal, resize_frame_windows)
9558 (Fsplit_window_internal, Fdelete_window_internal)
9559 (grow_mini_window, shrink_mini_window)
9560 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9561
c7e73be5
JD
95622011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9563
9564 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9565 (emacs_fixed_set_min_size): Remove.
9566 (emacs_fixed_new): Take frame as argument.
9567
9568 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9569 (_EmacsFixedPrivate): Remove minwidth/height.
9570 Add struct frame *f.
9571 (emacs_fixed_init): Initialize priv->f.
9572 (get_parent_class, emacs_fixed_set_min_size): Remove.
9573 (emacs_fixed_new): Set priv->f to argument.
9574 (emacs_fixed_get_preferred_width)
9575 (emacs_fixed_get_preferred_height): Use min_width/height from
9576 frames size_hint to set minimum and natural (Bug#8919).
9577 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9578 and use min_width/height from frames size_hint to set
9579 min_width/height (Bug#8919).
9580
9581 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9582 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9583 Fix indentation.
c7e73be5 9584
cf99dcf8
EZ
95852011-06-26 Eli Zaretskii <eliz@gnu.org>
9586
9587 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9588 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9589 called at ZV.
9590
029529ac
CY
95912011-06-26 Chong Yidong <cyd@stupidchicken.com>
9592
9593 * process.c (wait_reading_process_output): Bypass select if
9594 waiting for a cell while ignoring keyboard input, and input is
9595 pending. Suggested by Jan Djärv (Bug#8869).
9596
7a7ef429
PE
95972011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9598
9599 Use gnulib's dup2 module instead of rolling our own.
9600 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9601
11fdef7d 96022011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9603
9604 * dispnew.c (scrolling_window): Before scrolling, turn off a
9605 mouse-highlight in the window being scrolled.
9606
cd3520a4
JB
96072011-06-24 Juanma Barranquero <lekktu@gmail.com>
9608
9609 Move DEFSYM to lisp.h and use everywhere.
9610
9611 * character.h (DEFSYM): Move declaration...
9612 * lisp.h (DEFSYM): ...here.
9613
9614 * gnutls.c:
9615 * minibuf.c:
9616 * w32menu.c:
9617 * w32proc.c:
9618 * w32select.c: Don't include character.h.
9619
9620 * alloc.c (syms_of_alloc):
9621 * buffer.c (syms_of_buffer):
9622 * bytecode.c (syms_of_bytecode):
9623 * callint.c (syms_of_callint):
9624 * casefiddle.c (syms_of_casefiddle):
9625 * casetab.c (init_casetab_once):
9626 * category.c (init_category_once, syms_of_category):
9627 * ccl.c (syms_of_ccl):
9628 * cmds.c (syms_of_cmds):
9629 * composite.c (syms_of_composite):
9630 * dbusbind.c (syms_of_dbusbind):
9631 * dired.c (syms_of_dired):
9632 * dispnew.c (syms_of_display):
9633 * doc.c (syms_of_doc):
9634 * editfns.c (syms_of_editfns):
9635 * emacs.c (syms_of_emacs):
9636 * eval.c (syms_of_eval):
9637 * fileio.c (syms_of_fileio):
9638 * fns.c (syms_of_fns):
9639 * frame.c (syms_of_frame):
9640 * fringe.c (syms_of_fringe):
9641 * insdel.c (syms_of_insdel):
9642 * keymap.c (syms_of_keymap):
9643 * lread.c (init_obarray, syms_of_lread):
9644 * macros.c (syms_of_macros):
9645 * msdos.c (syms_of_msdos):
9646 * print.c (syms_of_print):
9647 * process.c (syms_of_process):
9648 * search.c (syms_of_search):
9649 * sound.c (syms_of_sound):
9650 * syntax.c (init_syntax_once, syms_of_syntax):
9651 * terminal.c (syms_of_terminal):
9652 * textprop.c (syms_of_textprop):
9653 * undo.c (syms_of_undo):
9654 * w32.c (globals_of_w32):
9655 * window.c (syms_of_window):
9656 * xdisp.c (syms_of_xdisp):
9657 * xfaces.c (syms_of_xfaces):
9658 * xfns.c (syms_of_xfns):
9659 * xmenu.c (syms_of_xmenu):
9660 * xsettings.c (syms_of_xsettings):
9661 * xterm.c (syms_of_xterm): Use DEFSYM.
9662
4228cf16
TZ
96632011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9664
cd3520a4 9665 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9666
7fcccf1e
PE
96672011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9668
7efb4e0e
PE
9669 Integer and buffer overflow fixes (Bug#8873).
9670
ff5844ad
PE
9671 * print.c (printchar, strout): Check for string overflow.
9672 (PRINTPREPARE, printchar, strout):
9673 Don't set size unless allocation succeeds.
9674
90532f02
PE
9675 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9676 for sizes. Check for string overflow more accurately.
9677 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9678
6d84508d
PE
9679 * macros.c: Integer and buffer overflow fixes.
9680 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9681 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9682 Use ptrdiff_t, not int, for sizes.
9683 Don't increment bufsize until after realloc succeeds.
9684 Check for size-calculation overflow.
9685 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9686
437b2cb4
PE
9687 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9688
8b9ac8b4
PE
9689 * lread.c: Integer overflow fixes.
9690 (read_integer): Radix is now EMACS_INT, not int,
9691 to improve quality of diagnostics for out-of-range radices.
9692 Calculate buffer size correctly for out-of-range radices.
9693 (read1): Check for integer overflow in radices, and in
9694 read-circle numbers.
82cb60d3
PE
9695 (read_escape): Avoid int overflow.
9696 (Fload, openp, read_buffer_size, read1)
9697 (substitute_object_recurse, read_vector, read_list, map_obarray):
9698 Use ptrdiff_t, not int, for sizes.
9699 (read1): Use EMACS_INT, not int, for sizes.
20270765 9700 Check for size overflow.
8b9ac8b4 9701
7fcccf1e
PE
9702 * image.c (cache_image): Check for size arithmetic overflow.
9703
bfbbd7e7
PE
9704 * lread.c: Integer overflow issues.
9705 (saved_doc_string_size, saved_doc_string_length)
9706 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9707 Now ptrdiff_t, not int.
9708 (read1): Don't assume doc string length fits in int. Check for
9709 out-of-range doc string lengths.
9710 (read_list): Don't assume file position fits in int.
39019e54 9711 (read_escape): Check for hex character overflow.
bfbbd7e7 9712
4e323265
LL
97132011-06-22 Leo Liu <sdl.web@gmail.com>
9714
9715 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9716 Move to minibuffer.el.
9717
85fece3e
PE
97182011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9719
20b84ce9 9720 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9721 The following patches are for when GLYPH_DEBUG && !XASSERT.
9722 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9723 * dispnew.c (flush_stdout):
9724 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9725 Mark as externally visible.
9726 * dispnew.c (check_window_matrix_pointers): Now static.
9727 * dispnew.c (window_to_frame_vpos):
9728 * xfns.c (unwind_create_frame):
9729 * xterm.c (x_check_font): Remove unused local.
9730 * scroll.c (CHECK_BOUNDS):
9731 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9732 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9733 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9734 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9735 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9736 Now static.
9737 (debug_method_add): Use va_list and vsprintf rather than relying
9738 on undefined behavior with wrong number of arguments.
9739 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9740 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9741 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9742 since we're not interested in debugging glyphs with old libraries.
9743 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9744 GCC 4.6.0's static checking.
9745
0766b489
PE
97462011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9747
31fd4b32
PE
9748 Integer overflow and signedness fixes (Bug#8873).
9749 A few related buffer overrun fixes, too.
9750
b79e8648
PE
9751 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9752
0766b489
PE
9753 * dispextern.h (struct face.stipple):
9754 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9755 (x_bitmap_mask, x_allocate_bitmap_record)
9756 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9757 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9758 (x_create_bitmap_from_xpm_data):
9759 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9760 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9761 (.bitmaps_last):
9762 * xfaces.c (load_pixmap):
9763 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9764 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9765 (.bitmaps_last, struct x_output.icon_bitmap):
9766 Use ptrdiff_t, not int, for bitmap indexes.
9767 (x_allocate_bitmap_record): Check for size overflow.
9768 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9769
b081724f
PE
9770 Use ptrdiff_t, not int, for overlay counts.
9771 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9772 * editfns.c (overlays_around, get_pos_property):
9773 * textprop.c (get_char_property_and_overlay):
9774 * xdisp.c (next_overlay_change, note_mouse_highlight):
9775 * xfaces.c (face_at_buffer_position):
21514da7
PE
9776 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9777 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9778 (Fnext_overlay_change, Fprevious_overlay_change)
9779 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9780 Use ptrdiff_t, not int, for sizes.
21514da7 9781 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9782
3de73e5e
PE
9783 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9784
2606c57b
PE
9785 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9786 (x_session_initialize): Do not assume string length fits in int.
9787
aaafe47a
PE
9788 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9789 This is unlikely, but can occur if DPI is outlandish.
9790
2674ddc8 9791 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9792 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9793
28154962
PE
9794 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9795 * xrdb.c (magic_file_p, search_magic_path):
9796 Omit last arg SUFFIX; it was always 0. All callers changed.
9797 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9798
7de51af5
PE
9799 * xfont.c (xfont_match): Avoid need for strlen.
9800
25ed6cc3
PE
9801 * xfns.c: Don't assume strlen fits in int.
9802 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9803
4eab31dd
PE
9804 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9805 not unsigned long, as we prefer signed integers. All callers changed.
9806 Detect integer overflow in repeat count.
9807 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9808 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9809
171e2a58
PE
9810 * termcap.c: Don't assume sizes fit in int and never overflow.
9811 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9812 (gobble_line): Check for size-calculation overflow.
9813
ad39faca 9814 * minibuf.c (Fread_buffer):
6e5bb2dc 9815 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9816 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9817 Don't assume string length fits in int.
9818
52c61c22 9819 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9820 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9821
b5b8c9e5
PE
9822 * font.c: Don't assume string length fits in int.
9823 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9824 Use ptrdiff_t, not int.
ccd6111c
PE
9825 (font_intern_prop): Don't assume string length fits in int.
9826 Don't assume integer property fits in fixnum.
9827 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9828
882f0d81 9829 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9830 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9831 Reformulate so as not to need the command string.
9832 Invoke gzip -cd rather than gunzip, as it's more portable.
9833 (lock_info_type, lock_file_1, lock_file):
9834 Don't assume pid_t and time_t fit in unsigned long.
9835 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9836 (current_lock_owner): Prefer signed type for sizes.
9837 Use memcpy, not strncpy, where memcpy is what is really wanted.
9838 Don't assume (via atoi) that time_t and pid_t fit in int.
9839 Check for time_t and/or pid_t out of range, e.g., via a network share.
9840 Don't alloca where an auto var works fine.
9841
93f4cf88
PE
9842 * fileio.c: Fix some integer overflow issues.
9843 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9844 Don't assume string length fits in int.
9845 (directory_file_name): Don't assume string length fits in long.
9846 (make_temp_name): Don't assume pid fits in int, or that its print
9847 length is less than 20.
9848
f3e92b69
PE
9849 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9850
1bfdaf10
PE
9851 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9852
35016e9a
PE
9853 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9854
3d1e65a1
PE
9855 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9856 We prefer signed integers, even for size calculations.
9857
0b963a93
PE
9858 * emacs.c: Don't assume string length fits in 'int'.
9859 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9860 (main): Don't invoke strlen when not needed.
9861
573f4b54
PE
9862 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9863 (XD_DEBUG_MESSAGE): Don't waste a byte.
9864
989f33ba
PE
9865 * callproc.c (getenv_internal_1, getenv_internal)
9866 (Fgetenv_internal):
965d34eb
PE
9867 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9868
e4d29b33
PE
9869 * lread.c (invalid_syntax): Omit length argument.
9870 All uses changed. This doesn't fix a bug, but it simplifies the
9871 code away from its former Hollerith-constant appearance, and it's
9872 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9873 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9874
eb49b136
PE
9875 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9876 This didn't break anything, but it didn't help either.
9877 It's confusing to put a bogus integer in a place where the actual
9878 value does not matter.
9f62aeb1 9879 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9880 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9881
15375a22
PE
9882 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9883 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9884 implementation.
b61cc01c
PE
9885 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9886 We prefer signed types, and the value cannot exceed the EMACS_INT
9887 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9888 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9889 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9890 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9891
53b2623d
PE
9892 * indent.c (sane_tab_width): New function.
9893 (current_column, scan_for_column, Findent_to, position_indentation)
9894 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9895 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9896
51cab52b 9897 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9898
f2ed8a70
PE
9899 * lisp.h (lint_assume): New macro.
9900 * composite.c (composition_gstring_put_cache):
9901 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9902
abe80cc6
PE
9903 * editfns.c, insdel.c:
9904 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9905
b02c740e
PE
9906 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9907
ebc96716
PE
9908 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9909
b4e50fa0 9910 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9911 Use much-faster test for byte-length change.
311d5d7c 9912 Don't assume string byte-length fits in 'int'.
a4cf38e4 9913 Check that character arg fits in 'int'.
85461888 9914 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9915
c0c1ee9f
PE
9916 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9917
a498d7f4
PE
9918 * fns.c (concat): Catch string overflow earlier.
9919 Do not rely on integer wraparound.
9920
51cab52b
PE
9921 * dispextern.h (struct it.overlay_strings_charpos)
9922 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9923 * xdisp.c (forward_to_next_line_start)
9924 (back_to_previous_visible_line_start)
9925 (reseat_at_next_visible_line_start, next_element_from_buffer):
9926 Don't arbitrarily truncate the value of 'selective' to int.
9927
76031fad
PE
9928 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9929
5eb55db9
PE
9930 * composite.c: Don't truncate sizes to 'int'.
9931 (composition_gstring_p, composition_reseat_it)
9932 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9933 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9934 not EMACS_UINT, for indexes.
5eb55db9 9935
0703a717
PE
9936 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9937
d6202519
PE
9938 * buffer.c: Include <verify.h>.
9939 (struct sortvec.priority, struct sortstr.priority):
8961a454 9940 Now EMACS_INT, not int.
c20998a7 9941 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9942 (struct sortstr.size, record_overlay_string)
9943 (struct sortstrlist.size, struct sortlist.used):
9944 Don't truncate size to int.
9945 (record_overlay_string): Check for size-calculation overflow.
d6202519 9946 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9947
d5a19415
JM
99482011-06-22 Jim Meyering <meyering@redhat.com>
9949
029529ac 9950 Don't leak an XBM-image-sized buffer
d5a19415
JM
9951 * image.c (xbm_load): Free the image buffer after using it.
9952
a9041e6c
PE
99532011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9954
9955 Port to Sun C.
9956 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9957 that Sun C diagnosed.
9958 * fns.c (secure_hash): Fix pointer signedness issue.
9959 * intervals.c (static_offset_intervals): New function.
9960 (offset_intervals): Use it.
9961
7f3f739f
LL
99622011-06-21 Leo Liu <sdl.web@gmail.com>
9963
9964 * deps.mk (fns.o):
9965 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9966 sha512.h.
9967
9968 * fns.c (secure_hash): Rename from crypto_hash_function and change
9969 the first arg to accept symbols.
5b66d427 9970 (Fsecure_hash): New primitive.
7f3f739f
LL
9971 (syms_of_fns): New symbols.
9972
76147d94
DD
99732011-06-20 Deniz Dogan <deniz@dogan.se>
9974
9975 * process.c (Fset_process_buffer): Clarify return value in
9976 docstring.
9977
7d7d0045
CY
99782011-06-18 Chong Yidong <cyd@stupidchicken.com>
9979
9980 * dispnew.c (add_window_display_history): Use BVAR.
9981
9982 * xdisp.c (debug_method_add): Use BVAR.
9983 (check_window_end, dump_glyph_matrix, dump_glyph)
9984 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9985
9986 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9987 Likewise.
9988
9989 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9990 check till after the cache is created in init_frame_faces.
9991
ff2bc410
SM
99922011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9993
9994 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9995
28177add
PE
99962011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9997
dd3482fe
PE
9998 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9999 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10000 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10001
393d71f3 10002 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10003 * fileio.c (Finsert_file_contents):
10004 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10005 Remove the old (too-loose) buffer overflow checks.
10006 They weren't needed, since make_gap checks for buffer overflow.
10007 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10008 The old code merely checked for Emacs fixnum overflow, and relied
10009 on undefined (wraparound) behavior. The new code avoids undefined
10010 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10011
2e6813b0 10012 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10013 Tune. Don't use wider integers than needed. Don't use alloca.
10014 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10015
599a9e4f
PE
10016 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10017
99561444
PE
10018 * insdel.c, lisp.h (buffer_overflow): New function.
10019 (insert_from_buffer_1, replace_range, replace_range_2):
10020 * insdel.c (make_gap_larger):
10021 * editfns.c (Finsert_char):
10022 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10023
28177add
PE
10024 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10025
e69dafad
PE
100262011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10027
4baa020d 10028 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10029
b1c46f02
PE
10030 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10031 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10032
e69dafad
PE
10033 * fileio.c: Don't assume EMACS_INT fits in off_t.
10034 (emacs_lseek): New static function.
10035 (Finsert_file_contents, Fwrite_region): Use it.
10036 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10037
566684ea
PE
10038 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10039
e6966cd6
PE
10040 * fns.c: Don't overflow int when computing a list length.
10041 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10042 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10043 truncation on 64-bit hosts. Check for QUIT every
10044 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10045 faster and is responsive enough.
10046 (Flength): Report an error instead of overflowing an integer.
10047 (Fsafe_length): Return a float if the value is not representable
10048 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10049 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10050 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10051
dd0b0efb
PE
10052 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10053 (header_size, word_size): New constants.
10054 (allocate_vectorlike): Don't check size overflow here.
10055 (allocate_vector): Check it here instead, since this is the only
10056 caller of allocate_vectorlike that could cause overflow.
10057 Check that the new vector's length is representable as a fixnum.
10058
86fe5cfe
PE
10059 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10060 The previous code was bogus. For example, next_almost_prime (32)
10061 returned 39, which is undesirable as it is a multiple of 3; and
10062 next_almost_prime (24) returned 25, which is a multiple of 5 so
10063 why was the code bothering to check for multiples of 7?
10064
80e88859
PE
10065 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10066
4a2f0ad6
PE
10067 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10068
f66c7cf8
PE
10069 Variadic C functions now count arguments with ptrdiff_t.
10070 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10071 Back then I didn't know that the Emacs coding style prefers signed int.
10072 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10073 were being counted with int, which may truncate counts on 64-bit
10074 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10075 * lisp.h (struct Lisp_Subr.function.aMANY)
10076 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10077 Arg counts are now ptrdiff_t, not size_t.
10078 All variadic functions and their callers changed accordingly.
10079 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10080 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10081 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10082 * callint.c (Fcall_interactively): Check arg count for overflow,
10083 to avoid potential buffer overrun. Use signed char, not 'int',
10084 for 'varies' array, so that we needn't bother to check its size
10085 calculation for overflow.
10086 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10087 * eval.c (apply_lambda):
10088 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10089 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10090 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10091
a1759b76
PE
10092 * callint.c (Fcall_interactively): Don't use index var as event count.
10093
d96be9fc
PE
10094 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10095 * mem-limits.h (SIZE): Remove; no longer used.
10096
a690a978 10097 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10098
578c21e6
PE
10099 Remove unnecessary casts.
10100 * xterm.c (x_term_init):
10101 * xfns.c (x_set_border_pixel):
10102 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10103 These aren't needed now that we assume ANSI C.
10104
96f53c6c
PE
10105 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10106 It's more likely to cause problems (due to unsigned overflow)
10107 than to cure them.
10108
83c77d31
PE
10109 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10110
ee2079f1
PE
10111 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10112
6da65536
PE
10113 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10114
7147c4a4
PE
10115 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10116
193e32d9
PE
10117 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10118
e5533da6
PE
10119 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10120
9910e595
PE
10121 GLYPH_CODE_FACE returns EMACS_INT, not int.
10122 * dispextern.h (merge_faces):
10123 * xfaces.c (merge_faces):
01103c44
PE
10124 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10125 Don't assume EMACS_INT fits in int.
9910e595 10126
2638320e
PE
10127 * character.h (CHAR_VALID_P): Remove unused parameter.
10128 * fontset.c, lisp.h, xdisp.c: All uses changed.
10129
045eb8d9
PE
10130 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10131
c1f134b5
PE
10132 * fns.c (concat): Minor tuning based on overflow analysis.
10133 This doesn't fix any bugs. Use int to hold character, instead
10134 of constantly refetching from Emacs object. Use XFASTINT, not
10135 XINT, for value known to be a character. Don't bother comparing
10136 a single byte to 0400, as it's always less.
10137
395fcb93 10138 * floatfns.c (Fexpt):
327eeec8
PE
10139 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10140
abbd3d23
PE
10141 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10142 for characters.
10143
684a03ef
PE
10144 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10145
0fed43f3
PE
10146 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10147 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10148 incorrectly succeed when S was a string, because 4294967386 was
10149 truncated before it was used.
10150
8fd02eb7
PE
10151 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10152 Otherwise, an out-of-range integer could cause undefined behavior
10153 on a 64-bit host.
10154
f8c86b69
PE
10155 * composite.c: Use int, not EMACS_INT, for characters.
10156 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10157 EMACS_INT, for values that are known to be in character range.
10158 This doesn't fix any bugs but is the usual style inside Emacs and
10159 may generate better code on 32-bit machines.
10160
34206dd2
PE
10161 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10162 This is for reasons similar to the recent CHAR_STRING fix.
10163 * charset.c (Fencode_char): Check that character arg is actually
10164 a character. Pass an int to ENCODE_CHAR.
10165 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10166 wider than 'int', as a compile-time check to prevent future regressions
10167 in this area.
10168
c5958d4c 10169 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10170
10171 Make sure a 64-bit char is never passed to CHAR_STRING.
10172 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10173 by silently ignoring the top 32 bits, allowing some values
10174 that were far too large to be valid characters.
10175 * character.h: Include <verify.h>.
10176 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10177 arguments are no wider than unsigned, as a compile-time check
10178 to prevent future regressions in this area.
10179 * data.c (Faset):
01103c44 10180 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10181 (Fsubst_char_in_region):
10182 * fns.c (concat):
10183 * xdisp.c (decode_mode_spec_coding):
10184 Adjust to CHAR_STRING's new requirement.
10185 * editfns.c (Finsert_char, Fsubst_char_in_region):
10186 * fns.c (concat): Check that character args are actually
10187 characters. Without this test, these functions did the wrong
10188 thing with wildly out-of-range values on 64-bit hosts.
10189
d37ca623
PE
10190 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10191 These casts should not be needed on 32-bit hosts, either.
10192 * keyboard.c (read_char):
10193 * lread.c (Fload): Remove casts to unsigned.
10194
ea204efb
PE
10195 * lisp.h (UNSIGNED_CMP): New macro.
10196 This fixes comparison bugs on 64-bit hosts.
10197 (ASCII_CHAR_P): Use it.
10198 * casefiddle.c (casify_object):
01103c44 10199 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10200 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10201 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10202 * dispextern.h (FACE_FROM_ID):
10203 * keyboard.c (read_char): Use UNSIGNED_CMP.
10204
41cb286c
PE
10205 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10206 not to EMACS_INT, to avoid GCC warning.
10207
4a1b9832
PE
10208 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10209
55daad71
PE
10210 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10211 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10212 isn't needed on 32-bit machines.
8f95c75c 10213
01103c44
PE
10214 * buffer.c (Fgenerate_new_buffer_name):
10215 Use EMACS_INT for count, not int.
0ceccced 10216 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10217
10218 * data.c (Qcompiled_function): Now static.
10219
c6f072e7
PE
10220 * window.c (window_body_lines): Now static.
10221
20ce5912
PE
10222 * image.c (gif_load): Rename local to avoid shadowing.
10223
9c4c5f81
PE
10224 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10225 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10226 * alloc.c (make_save_value): Integer argument is now of type
10227 ptrdiff_t, not int.
10228 (mark_object): Use ptrdiff_t, not int.
10229 * lisp.h (pD): New macro.
10230 * print.c (print_object): Use it.
10231
c0c5c8ae
PE
10232 * alloc.c: Use EMACS_INT, not int, to count objects.
10233 (total_conses, total_markers, total_symbols, total_vector_size)
10234 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10235 (total_free_floats, total_floats, total_free_intervals)
10236 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10237 Now EMACS_INT, not int. All uses changed.
10238 (Fgarbage_collect): Compute overall total using a double, so that
10239 integer overflow is less likely to be a problem. Check for overflow
10240 when converting back to an integer.
5a25e253
PE
10241 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10242 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10243 These were 'int' variables that could overflow on 64-bit hosts;
10244 they were never used, so remove them instead of repairing them.
211a0b2a 10245 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10246 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10247 Previously, this ceilinged at INT_MAX, but that doesn't work on
10248 64-bit machines.
e46bb31a 10249 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10250
c78baabf 10251 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10252 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10253 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10254 when a (possibly-narrower) signed value would do just as well.
10255 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10256
c9d624c6
PE
10257 * alloc.c: Catch some string size overflows that we were missing.
10258 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10259 for convenience in STRING_BYTES_MAX.
10260 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10261 The definition here is exact; the one in lisp.h was approximate.
10262 (allocate_string_data): Check for string overflow. This catches
10263 some instances we weren't catching before. Also, it catches
10264 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10265 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10266 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10267
c9d624c6
PE
10268 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10269 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10270 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10271
353032ce
PE
10272 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10273
2bccce07
PE
10274 * alloc.c (Fmake_string): Check for out-of-range init.
10275
0ac30604
SM
102762011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10277
10278 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10279
c195f2de
JD
102802011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10281
10282 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10283 xg_get_default_scrollbar_width.
10284
10285 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10286 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10287 (style_changed_cb): Call update_theme_scrollbar_width and call
10288 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10289 all frames (Bug#8505).
10290 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10291 Call gtk_window_set_resizable if HAVE_GTK3.
10292 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10293 and height if HAVE_GTK3 (Bug#8505).
10294 (scroll_bar_width_for_theme): New variable.
10295 (update_theme_scrollbar_width): New function.
10296 (xg_get_default_scrollbar_width): Move code to
10297 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10298 (xg_initialize): Call update_theme_scrollbar_width.
10299
10300 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10301
10302 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10303
e10ac9f1
MR
103042011-06-12 Martin Rudalics <rudalics@gmx.at>
10305
10306 * frame.c (make_frame): Call other_buffer_safely instead of
10307 other_buffer.
10308
10309 * window.c (temp_output_buffer_show): Call display_buffer with
10310 second argument Vtemp_buffer_show_specifiers and reset latter
10311 immediately after the call.
10312 (Vtemp_buffer_show_specifiers): New variable.
10313 (auto_window_vscroll_p, next_screen_context_lines)
10314 (Vscroll_preserve_screen_position): Remove leading asterisks from
10315 doc-strings.
10316
2d3c217e 103172011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10318
7b7f97e8 10319 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10320 * buffer.c (Qclone_number): Remove for now, as it's unused.
10321 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10322 (record_buffer): Remove unused local.
10323 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10324 (set_frame_buffer_list): Remove; unused.
10325 * frame.h (other_visible_frames): Remove decl.
10326 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10327 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10328 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10329 if HAVE_GPM.
10330 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10331 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10332 Define only if HAVE_GPM.
10333 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10334 (update_hints_inhibit): Remove; never set. All uses removed.
10335 * widgetprv.h (emacsFrameClassRec): Remove decl.
10336 * window.c (delete_deletable_window): Now returns void, since it
10337 wasn't returning anything.
10338 (compare_window_configurations): Remove unused locals.
10339 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10340 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10341 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10342 the same widths as pointers. This follows up on the 2011-05-06 patch.
10343 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10344 * xterm.h: Likewise.
10345 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10346
1384b89e
JB
103472011-06-12 Juanma Barranquero <lekktu@gmail.com>
10348
10349 * makefile.w32-in: Update dependencies.
10350 (LISP_H): Add lib/intprops.h.
10351
1100a63c
CY
103522011-06-11 Chong Yidong <cyd@stupidchicken.com>
10353
10354 * image.c (gif_load): Add animation frame delay to the metadata.
10355 (syms_of_image): Use DEFSYM. New symbol `delay'.
10356
6198ccd0
MR
103572011-06-11 Martin Rudalics <rudalics@gmx.at>
10358
10359 * window.c (delete_deletable_window): Re-add.
10360 (Fset_window_configuration): Rewrite to handle dead buffers and
10361 consequently deletable windows.
10362 (window_tree, Fwindow_tree): Remove. Supply functionality in
10363 window.el.
10364 (compare_window_configurations): Simplify code.
10365
b6e3633c
AS
103662011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10367
1ab0dee5
AS
10368 * image.c (imagemagick_load_image): Fix type mismatch.
10369 (Fimagemagick_types): Likewise.
10370
b6e3633c
AS
10371 * window.h (replace_buffer_in_windows): Declare.
10372
9397e56f
MR
103732011-06-11 Martin Rudalics <rudalics@gmx.at>
10374
10375 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10376 Qclone_number. Remove external declaration of Qdelete_window.
10377 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10378 code.
640c8776
SM
10379 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10380 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10381 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10382 buffer list implementation.
10383 (other_buffer_safely): New function.
10384 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10385 calls to replace_buffer_in_windows and
10386 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10387 if allowed.
10388 (record_buffer): Inhibit quitting and rewrite using quittable
10389 functions. Run Qbuffer_list_update_hook if allowed.
10390 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10391 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10392 Move switch-to-buffer to window.el.
9397e56f
MR
10393 (bury-buffer): Move to window.el.
10394 (Vbuffer_list_update_hook): New variable.
10395
10396 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10397 section.
10398
10399 * window.h (resize_frame_windows): Move up in code.
10400 (Fwindow_frame): Remove EXFUN.
10401 (replace_buffer_in_all_windows): Remove prototype.
10402 (replace_buffer_in_windows_safely): Add prototype.
10403
10404 * window.c: Declare Qdelete_window static again. Move down
10405 declaration of select_count.
10406 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10407 (Fother_window): Move to window.el.
10408 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10409 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10410 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10411 window.el.
10412 (replace_buffer_in_windows): Implement by calling
10413 Qreplace_buffer_in_windows.
10414 (replace_buffer_in_all_windows): Remove with some functionality
10415 moved into replace_buffer_in_windows_safely.
10416 (replace_buffer_in_windows_safely): New function.
10417 (select_window_norecord, select_frame_norecord): Move in front
10418 of run_window_configuration_change_hook. Remove now obsolete
10419 declarations.
640c8776
SM
10420 (Fset_window_buffer): Rewrite doc-string.
10421 Call Qrecord_window_buffer.
9397e56f
MR
10422 (keys_of_window): Move binding for other-window to window.el.
10423
b50691aa
CY
104242011-06-11 Chong Yidong <cyd@stupidchicken.com>
10425
10426 * dispextern.h (struct image): Replace data member, whose int_val
10427 and ptr_val fields were not used by anything, with a single
10428 lisp_val object.
10429
10430 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10431 (gif_clear_image, gif_load, imagemagick_load_image)
10432 (gs_clear_image, gs_load): Callers changed.
10433
3f754b86
PE
104342011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10435
cca69397
PE
10436 * buffer.h: Include <time.h>, for time_t.
10437 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10438
109e28d0
PE
10439 Fix minor problems found by static checking.
10440
60737f02
PE
10441 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10442
4b66faf3
PE
10443 Make identifiers static if they are not used in other modules.
10444 * data.c (Qcompiled_function, Qframe, Qvector):
10445 * image.c (QimageMagick, Qsvg):
10446 * minibuf.c (Qmetadata):
10447 * window.c (resize_window_check, resize_root_window): Now static.
10448 * window.h (resize_window_check, resize_root_window): Remove decls.
10449
109e28d0
PE
10450 * window.c (window_deletion_count, delete_deletable_window):
10451 Remove; unused.
46a4ce9e
PE
10452 (window_body_lines): Now static.
10453 (Fdelete_other_windows_internal): Mark vars as initialized.
10454 Make sure 'resize_failed' is initialized.
10455 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10456 (resize_window_apply): Remove unused local.
10457 * window.h (delete_deletable_window): Remove decl.
10458
109e28d0 10459 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10460 (imagemagick_load_image): Fix pointer signedness problem by changing
10461 last arg from unsigned char * to char *. All uses changed.
10462 Also, fix a local for similar reasons.
10463 Remove unused locals. Remove locals to avoid shadowing.
10464 (fn_rsvg_handle_free): Remove; unused.
10465 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10466 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10467
3f754b86
PE
10468 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10469
2547adb1
CY
104702011-06-10 Chong Yidong <cyd@stupidchicken.com>
10471
10472 * image.c (gif_load): Fix omitted cast error introduced by
10473 2011-06-06 change.
10474
2c8e37d4
MR
104752011-06-10 Martin Rudalics <rudalics@gmx.at>
10476
10477 * window.h (resize_proportionally, orig_total_lines)
10478 (orig_top_line): Remove from window structure.
10479 (set_window_height, set_window_width, change_window_heights)
10480 (Fdelete_window): Remove prototypes.
10481 (resize_frame_windows): Remove duplicate declaration.
10482
440a42e3
EZ
104832011-06-10 Eli Zaretskii <eliz@gnu.org>
10484
10485 * window.h (resize_frame_windows, resize_window_check)
10486 (delete_deletable_window, resize_root_window)
10487 (resize_frame_windows): Declare prototypes.
10488
10489 * window.c (resize_window_apply): Make definition be "static" to
10490 match the prototype.
10491
562dd5e9
MR
104922011-06-10 Martin Rudalics <rudalics@gmx.at>
10493
10494 * window.c: Remove declarations of Qwindow_size_fixed,
10495 window_min_size_1, window_min_size_2, window_min_size,
10496 size_window, window_fixed_size_p, enlarge_window, delete_window.
10497 Remove static from declaration of Qdelete_window, it's
10498 temporarily needed by Fbury_buffer.
10499 (replace_window): Don't assign orig_top_line and
10500 orig_total_lines.
10501 (Fdelete_window, delete_window): Remove. Window deletion is
10502 handled by window.el.
640c8776
SM
10503 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10504 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10505 (Fdelete_other_windows): Remove. Deleting other windows is
10506 handled by window.el.
10507 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10508 handled in window.el.
10509 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10510 Window minimum sizes are handled in window.el.
10511 (shrink_windows, size_window, set_window_height)
10512 (set_window_width, change_window_heights, window_height)
10513 (window_width, CURBEG, CURSIZE, enlarge_window)
10514 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10515 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10516 handled in window.el.
10517 (make_dummy_parent): Rename to make_parent_window and give it a
10518 second argument horflag.
10519 (make_window): Don't set resize_proportionally any more.
10520 (Fsplit_window): Remove. Windows are split in window.el.
10521 (save_restore_action, save_restore_orig_size)
10522 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10523 Resize mini windows in window.el.
10524 (grow_mini_window, shrink_mini_window): Implement by calling
10525 Qresize_root_window_vertically, resize_window_check and
10526 resize_window_apply.
640c8776
SM
10527 (saved_window, Fset_window_configuration, save_window_save):
10528 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10529 resize_proportionally.
10530 (window_min_height, window_min_width): Move to window.el.
10531 (keys_of_window): Move bindings for delete-other-windows,
10532 split-window, delete-window and enlarge-window to window.el.
10533
10534 * buffer.c: Temporarily extern Qdelete_window.
10535 (Fbury_buffer): Temporarily call Qdelete_window instead of
10536 Fdelete_window (Fbury_buffer will move to window.el soon).
10537
10538 * frame.c (set_menu_bar_lines_1): Remove code handling
10539 orig_top_line and orig_total_lines.
10540
10541 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10542 set_window_height but set heights directly.
10543 (change_frame_size_1): Use resize_frame_windows.
10544
10545 * xdisp.c (init_xdisp): Don't use set_window_height but set
10546 heights directly.
10547
640c8776
SM
10548 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10549 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10550 run_window_configuration_change_hook.
10551
10552 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10553 instead of change_window_heights and run
10554 run_window_configuration_change_hook.
10555
1a13852e
MR
105562011-06-09 Martin Rudalics <rudalics@gmx.at>
10557
10558 * window.c (replace_window): Rename second argument REPLACEMENT to
10559 NEW. New third argument SETFLAG. Rewrite.
10560 (delete_window, make_dummy_parent): Call replace_window with
10561 third argument 1.
10562 (window_list_1): Move down in code.
10563 (run_window_configuration_change_hook): Move set_buffer part
10564 before select_frame_norecord part in order to unwind correctly.
10565 Rename count1 to count.
10566 (recombine_windows, delete_deletable_window, resize_root_window)
10567 (Fdelete_other_windows_internal)
10568 (Frun_window_configuration_change_hook, make_parent_window)
10569 (resize_window_check, resize_window_apply, Fresize_window_apply)
10570 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10571 (Fdelete_window_internal, Fresize_mini_window_internal):
10572 New functions.
1a13852e
MR
10573 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10574
f3d1777e
MR
105752011-06-08 Martin Rudalics <rudalics@gmx.at>
10576
496e208e
MR
10577 * window.h (window): Add some new members to window structure -
10578 normal_lines, normal_cols, new_total, new_normal, clone_number,
10579 splits, nest, prev_buffers, next_buffers.
10580 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10581 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10582
f3d1777e
MR
10583 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10584 Remove.
496e208e
MR
10585 (make_dummy_parent): Set new members of windows structure.
10586 (make_window): Move down in code. Handle new members of window
10587 structure.
10588 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10589 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10590 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10591 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10592 (Fset_window_next_buffers, Fset_window_clone_number):
10593 New functions.
496e208e
MR
10594 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10595 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10596 Doc-string fixes.
10597 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10598 Argument WINDOW can be now internal window too.
10599 (Fwindow_use_time): Move up in code.
10600 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10601 Rewrite doc-string.
10602 (Fset_window_configuration, saved_window)
10603 (Fcurrent_window_configuration, save_window_save): Handle new
10604 members of window structure.
b9e809c2
MR
10605 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10606 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10607 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10608 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10609 Qget_mru_window, Qresize_root_window,
10610 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10611 Qauto_buffer_name; staticpro them.
f3d1777e 10612
abde8f8c
MR
106132011-06-07 Martin Rudalics <rudalics@gmx.at>
10614
10615 * window.c (Fwindow_total_size, Fwindow_left_column)
10616 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10617 (Fwindow_list_1): New functions.
10618 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10619 (Fwindow_width, Fscroll_left, Fscroll_right):
10620 Use window_body_cols instead of window_box_text_cols.
10621 (delete_window, Fset_window_configuration):
10622 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10623 (delete_all_subwindows): Take a window as argument and not a
10624 structure. Rewrite.
190b47e6
MR
10625 (window_loop): Remove handling of GET_LRU_WINDOW and
10626 GET_LARGEST_WINDOW.
10627 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10628
10629 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10630 window_box_text_cols. delete_all_subwindows now takes a
10631 Lisp_Object as argument.
abde8f8c 10632
640c8776
SM
10633 * indent.c (compute_motion, Fcompute_motion):
10634 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10635
fa8a67e6
MR
10636 * frame.c (delete_frame): Call delete_all_subwindows with root
10637 window as argument.
10638
a54e3482
DC
106392011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10640
10641 * fns.c (Fputhash): Document return value.
10642
60002bf5
CY
106432011-06-06 Chong Yidong <cyd@stupidchicken.com>
10644
10645 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10646
0c671da6 106472011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10648
b862a52a 10649 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10650
be44ca6c
PE
10651 Check for overflow when converting integer to cons and back.
10652 * charset.c (Fdefine_charset_internal, Fdecode_char):
10653 Use cons_to_unsigned to catch overflow.
10654 (Fencode_char): Use INTEGER_TO_CONS.
10655 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10656 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10657 * data.c (long_to_cons, cons_to_long): Remove.
10658 (cons_to_unsigned, cons_to_signed): New functions.
10659 These signal an error for invalid or out-of-range values.
10660 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10661 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10662 * font.c (Ffont_variation_glyphs):
10663 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10664 * lisp.h: Include <intprops.h>.
10665 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10666 (cons_to_signed, cons_to_unsigned): New decls.
10667 (long_to_cons, cons_to_long): Remove decls.
10668 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10669 (Fprimitive_undo): Use CONS_TO_INTEGER.
10670 * xfns.c (Fx_window_property): Likewise.
10671 * xselect.c: Include <limits.h>.
10672 (x_own_selection, selection_data_to_lisp_data):
10673 Use INTEGER_TO_CONS.
10674 (x_handle_selection_request, x_handle_selection_clear)
10675 (x_get_foreign_selection, Fx_disown_selection_internal)
10676 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10677 (lisp_data_to_selection_data): Use cons_to_unsigned.
10678 (x_fill_property_data): Use cons_to_signed.
10679 Report values out of range.
10680
d1f3d2af
PE
10681 Check for buffer and string overflow more precisely.
10682 * buffer.h (BUF_BYTES_MAX): New macro.
10683 * lisp.h (STRING_BYTES_MAX): New macro.
10684 * alloc.c (Fmake_string):
10685 * character.c (string_escape_byte8):
10686 * coding.c (coding_alloc_by_realloc):
10687 * doprnt.c (doprnt):
10688 * editfns.c (Fformat):
10689 * eval.c (verror):
10690 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10691 since they may not be the same number.
10692 * editfns.c (Finsert_char):
10693 * fileio.c (Finsert_file_contents):
10694 Likewise for BUF_BYTES_MAX.
10695
dd52fcea
PE
10696 * image.c: Use ptrdiff_t, not int, for sizes.
10697 (slurp_file): Switch from int to ptrdiff_t.
10698 All uses changed.
10699 (slurp_file): Check that file size fits in both size_t (for
10700 malloc) and ptrdiff_t (for sanity and safety).
10701
7f9bbdbb
PE
10702 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10703 if b->modtime has its maximal value.
10704
dfe18f82
PE
10705 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10706
84acfcf0
PE
10707 Don't assume time_t can fit into int.
10708 * buffer.h (struct buffer.modtime): Now time_t, not int.
10709 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10710 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10711
ccd9a01a
PE
10712 Minor fixes for signed vs unsigned integers.
10713 * character.h (MAYBE_UNIFY_CHAR):
10714 * charset.c (maybe_unify_char):
10715 * keyboard.c (read_char, reorder_modifiers):
10716 XINT -> XFASTINT, since the integer must be nonnegative.
10717 * ftfont.c (ftfont_spec_pattern):
10718 * keymap.c (access_keymap, silly_event_symbol_error):
10719 XUINT -> XFASTINT, since the integer must be nonnegative.
10720 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10721 since it makes no difference and we prefer signed.
10722 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10723 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10724 nonnegative.
10725
d6d100dd
SM
107262011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10727
10728 * window.h (Fwindow_frame): Declare.
10729
2b6148e4
PE
107302011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10731
10732 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10733 (SPARE_MEMORY): Always define.
10734 (LARGE_REQUEST): Remove.
10735 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10736
f230ecc9
MR
107372011-06-06 Martin Rudalics <rudalics@gmx.at>
10738
727e958e
MR
10739 * lisp.h: Move EXFUNS for Fframe_root_window,
10740 Fframe_first_window and Fset_frame_selected_window to window.h.
10741
10742 * window.h: Move EXFUNS for Fframe_root_window,
10743 Fframe_first_window and Fset_frame_selected_window here from
10744 lisp.h.
10745
10746 * frame.c (Fwindow_frame, Fframe_first_window)
10747 (Fframe_root_window, Fframe_selected_window)
10748 (Fset_frame_selected_window): Move to window.c.
10749 (Factive_minibuffer_window): Move to minibuf.c.
10750 (Fother_visible_frames_p): New function.
10751
10752 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10753
f230ecc9
MR
10754 * window.c (decode_window, decode_any_window): Move up in code.
10755 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10756 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10757 (Fwindow_buffer): Move up and rewrite doc-string.
10758 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10759 (Fwindow_prev): New functions.
727e958e
MR
10760 (Fwindow_frame): Move here from frame.c. Accept any window as
10761 argument.
10762 (Fframe_root_window, Fframe_first_window)
10763 (Fframe_selected_window): Move here from frame.c. Accept frame
10764 or arbitrary window as argument. Update doc-strings.
10765 (Fminibuffer_window): Move up in code.
10766 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10767 (Fset_frame_selected_window): Move here from frame.c.
10768 Marginal rewrite.
727e958e
MR
10769 (Fselected_window, select_window, Fselect_window): Move up in
10770 code. Minor doc-string fixes.
f230ecc9 10771
4d09bcf6
PE
107722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10773
10774 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10775 Do not assume that spare memory exists; that assumption is valid
10776 only if SYSTEM_MALLOC.
10777 (LARGE_REQUEST): New macro, so that the issue of large requests
10778 is separated from the issue of spare memory.
10779
810928a2
AS
107802011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10781
172418ad
AS
10782 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10783 format. (Bug#8806)
10784
43f862f7
AS
10785 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10786
810928a2
AS
10787 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10788 before statements.
10789
a059fe24
JD
107902011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10791
10792 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10793
10794 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10795
10796 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10797 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10798
989bf368
JB
107992011-06-05 Juanma Barranquero <lekktu@gmail.com>
10800
10801 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10802
4b80f674
CY
108032011-06-04 Chong Yidong <cyd@stupidchicken.com>
10804
10805 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10806 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10807 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10808 New error handlers.
4b80f674
CY
10809 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10810 Obey Vx_select_enable_clipboard_manager. Catch errors in
10811 x_clipboard_manager_save (Bug#8779).
10812 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10813 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10814
99a33b77 108152011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10816
10817 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10818
99a33b77 108192011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10820
10821 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10822 in the current matrix if keep_current_p is non-zero.
10823
8264569d
EZ
108242011-06-04 Eli Zaretskii <eliz@gnu.org>
10825
10826 * bidi.c (bidi_level_of_next_char): Fix last change.
10827
57f97249
EZ
108282011-06-03 Eli Zaretskii <eliz@gnu.org>
10829
fec2107c 10830 Support bidi reordering of text covered by display properties.
57f97249 10831
fec2107c
EZ
10832 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10833 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10834 (bidi_cache_search, bidi_cache_iterator_state)
10835 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10836 (bidi_level_of_next_char, bidi_move_to_visually_next):
10837 Support character positions inside a run of characters covered by a
fec2107c
EZ
10838 display string.
10839 (bidi_paragraph_init, bidi_resolve_explicit_1)
10840 (bidi_level_of_next_char): Call bidi_fetch_char and
10841 bidi_fetch_char_advance instead of FETCH_CHAR and
10842 FETCH_CHAR_ADVANCE.
10843 (bidi_init_it): Initialize new members.
10844 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10845 definitions.
10846 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10847 instead of using explicit *_CHAR codes.
d6d100dd
SM
10848 (bidi_resolve_explicit, bidi_resolve_weak):
10849 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10850 bidirectional text is supported only in multibyte buffers.
10851 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10852 it to initialize the frame_window_p member of struct bidi_it.
10853 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10854 (bidi_resolve_explicit, bidi_resolve_weak)
10855 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10856 bidi_it->nchars is non-positive.
10857 (bidi_level_of_next_char): Don't try to lookup the cache for the
10858 next/previous character if nothing is cached there yet, or if we
10859 were just reseat()'ed to a new position.
c40e2fb2 10860
0e14fe90
EZ
10861 * xdisp.c (set_cursor_from_row): Set start and stop points
10862 according to the row's direction when priming the loop that looks
10863 for the glyph on which to display cursor.
10864 (single_display_spec_intangible_p): Function deleted.
10865 (display_prop_intangible_p): Reimplement to call
10866 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10867 Accept 3 additional arguments needed by handle_display_spec.
10868 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10869 values: lists, `(when COND...)' forms, etc.
10870 (single_display_spec_string_p): Support property values that are
10871 lists with the argument STRING its top-level element.
10872 (display_prop_string_p): Fix the condition for processing a
10873 property that is a list to be consistent with handle_display_spec.
fec2107c 10874 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10875 last portion of handle_display_prop.
10876 (compute_display_string_pos): Accept additional argument
10877 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10878 value of a `display' property is a "replacing spec".
10879 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10880 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10881 the display property, but just return a value indicating whether
10882 the display property will replace the characters it covers.
10883 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10884 frame_window_p members of struct bidi_it.
d6d100dd
SM
10885 (compute_display_string_pos, compute_display_string_end):
10886 New functions.
fec2107c
EZ
10887 (push_it): Accept second argument POSITION, where pop_it should
10888 jump to continue iteration.
10889 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10890
fec2107c
EZ
10891 * keyboard.c (adjust_point_for_property): Adjust the call to
10892 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10893
10894 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10895 (bidi_init_it): Update prototypes.
10896 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10897 (compute_display_string_pos, compute_display_string_end):
10898 Declare prototypes.
fec2107c
EZ
10899 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10900 EMACS_INT.
fc6f18ce 10901
40087514 109022011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10903
57f53182
PE
10904 Malloc failure behavior now depends on size of allocation.
10905 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10906 * lisp.h: Change signatures accordingly.
10907 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10908 All callers changed. (Bug#8762)
10909
10910 * gnutls.c: Use Emacs's memory allocators.
10911 Without this change, the gnutls library would invoke malloc etc.
10912 directly, which causes problems on non-SYNC_INPUT hosts, and which
10913 runs afoul of improving memory_full behavior. (Bug#8761)
10914 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10915 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10916 xfree instead of the default malloc, realloc, free.
10917 (Fgnutls_boot): No need to check for memory allocation failure,
10918 since xmalloc does that for us.
10919
ac32cd99 10920 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10921 * category.c (hash_get_category_set):
10922 * ccl.c (ccl_driver):
10923 * charset.c (Fdefine_charset_internal):
10924 * charset.h (struct charset.hash_index):
10925 * composite.c (get_composition_id, gstring_lookup_cache)
10926 (composition_gstring_put_cache):
10927 * composite.h (struct composition.hash_index):
10928 * dispextern.h (struct image.hash):
10929 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10930 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10931 (hashfn_equal, hashfn_user_defined, make_hash_table)
10932 (maybe_resize_hash_table, hash_lookup, hash_put)
10933 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10934 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10935 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10936 * image.c (make_image, search_image_cache, lookup_image)
10937 (xpm_put_color_table_h):
10938 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10939 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10940 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10941 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10942 * alloc.c (allocate_vectorlike):
10943 Check for overflow in vector size calculations.
10944 * ccl.c (ccl_driver):
10945 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10946 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10947 need to be updated by these changes.
40087514
PE
10948 * fns.c (make_hash_table, maybe_resize_hash_table):
10949 Check for integer overflow with large hash tables.
0de4bb68
PE
10950 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10951 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10952 (SXHASH_REDUCE): New macro.
10953 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10954 Use it instead of discarding useful hash info with large hash values.
10955 (sxhash_float): New function.
10956 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10957 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10958 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10959 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10960 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10961 Adjust signatures to match updated version of code.
10962 (consing_since_gc): Now EMACS_INT, since a single hash table can
10963 use more than INT_MAX bytes.
10964
698d32e2
DN
109652011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10966
10967 Make it possible to build with GCC-4.6+ -O2 -flto.
10968
10969 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10970
fd6fa53f
SM
109712011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10972
10973 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10974 Call minibuffer-inactive-mode.
10975
864db017
JB
109762011-05-31 Juanma Barranquero <lekktu@gmail.com>
10977
10978 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10979 Update dependencies.
10980
2ad0baf4
DN
109812011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10982
10983 * data.c (init_data): Remove code for UTS, this system is not
10984 supported anymore.
10985
4fcc2638
DN
109862011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10987
10988 Don't force ./temacs to start in terminal mode.
10989
10990 * frame.c (make_initial_frame): Initialize faces in all cases, not
10991 only when CANNOT_DUMP is defined.
10992 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10993
c56e0fd5
DN
109942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10995
10996 * dispnew.c (add_window_display_history): Use const for the string
10997 pointer. Remove declaration, not needed.
10998
333d54da 109992011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11000
55d4c1b2 11001 Use 'inline', not 'INLINE'.
333d54da 11002 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11003 * alloc.c, fontset.c (INLINE): Remove.
11004 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11005 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11006 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11007 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11008 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11009
738db178
DN
110102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11011
11012 Make it possible to run ./temacs.
11013
11014 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11015 syms_of_callproc does the same thing. Remove test for
11016 "initialized", do it in the caller.
11017 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11018
620c53a6
SM
110192011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11020
11021 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11022 (read_minibuf): Use get_minibuffer.
11023 (syms_of_minibuf): Use DEFSYM.
11024 (Qmetadata): New var.
11025 * data.c (Qbuffer): Don't make it static.
11026 (syms_of_data): Use DEFSYM.
11027
e003a292
PE
110282011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11029
11030 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11031 (CCL_CODE_MIN): New macro.
11032
ed008a6d
PE
110332011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11034
3687c2ef
PE
11035 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11036
ed008a6d
PE
11037 * eval.c (Qdebug): Now static.
11038 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11039 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11040 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11041
d66c4c7c
CY
110422011-05-29 Chong Yidong <cyd@stupidchicken.com>
11043
11044 * image.c: Various fixes to ImageMagick code comments.
11045 (Fimagemagick_types): Doc fix.
11046
5fbc2025
PE
110472011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11048
0196f88a
PE
11049 Minor fixes prompted by GCC 4.6.0 warnings.
11050
11051 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11052
5fbc2025
PE
11053 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11054 (x_clipboard_manager_save_all): Move extern decl to ...
11055 * xterm.h: ... here, so that it can be checked for consistency.
11056
1dd3c2d9
CY
110572011-05-29 Chong Yidong <cyd@stupidchicken.com>
11058
11059 * xselect.c (x_clipboard_manager_save_frame)
11060 (x_clipboard_manager_save_all): New functions.
11061 (Fx_clipboard_manager_save): Lisp function deleted.
11062
11063 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11064 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11065
11066 * xterm.h: Update prototype.
11067
5ba6571d
WX
110682011-05-28 William Xu <william.xwl@gmail.com>
11069
11070 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11071 exiting (Bug#8239).
11072
3eaff834
JM
110732011-05-28 Jim Meyering <meyering@redhat.com>
11074
e1900994 11075 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11076 * fns.c (to_uchar): Define.
11077 (crypto_hash_function): Use it to convert some newly-signed
11078 variables to unsigned, to avoid sign-extension bugs. For example,
11079 without this change, (md5 "truc") would evaluate to
11080 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11081 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11082 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11083
0f6990a7
PE
110842011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11085
11086 Integer overflow fixes.
c8a9ca5a 11087
08686060
PE
11088 * dbusbind.c: Serial number integer overflow fixes.
11089 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11090 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11091 to hold a serial number that is too large for a fixnum.
11092 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11093 Check for serial numbers out of range. Decode any serial number
59568bf0 11094 that was so large that it became a float. (Bug#8722)
08686060 11095
2d1fc3c7
PE
11096 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11097 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11098 Use XFASTINT rather than XUINT when numbers are nonnegative.
11099 (xd_append_arg, Fdbus_method_return_internal):
11100 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11101 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11102 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11103 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11104 (Bug#8722)
2d1fc3c7 11105
c8a9ca5a
PE
11106 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11107
519e1d69
PE
11108 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11109
6df6ae42 11110 ccl: Add integer overflow checks.
30569699
PE
11111 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11112 (IN_INT_RANGE): New macros.
11113 (ccl_driver): Use them to check for integer overflow when
11114 decoding a CCL program. Many of the new checks are whether XINT (x)
11115 fits in int; it doesn't always, on 64-bit hosts. The new version
11116 doesn't catch all possible integer overflows, but it's an
847044ea 11117 improvement. (Bug#8719)
30569699 11118
c11285dc
PE
11119 * alloc.c (make_event_array): Use XINT, not XUINT.
11120 There's no need for unsigned here.
11121
fdccd48e
PE
11122 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11123 This follows up to the 2011-05-06 change that substituted uintptr_t
11124 for EMACS_INT. This case wasn't caught back then.
11125
37910ab2
PE
11126 Rework Fformat to avoid integer overflow issues.
11127 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11128 now (part of C89). Include <verify.h>.
11129 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11130 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11131 (Fformat): Avoid the prepass trying to compute sizes; it was only
11132 approximate and thus did not catch overflow reliably. Instead, walk
11133 through the format just once, formatting and computing sizes as we go,
11134 checking for integer overflow at every step, and allocating a larger
11135 buffer as needed. Keep track separately whether the format is
11136 multibyte. Keep only the most-recently calculated precision, rather
11137 than them all. Record whether each argument has been converted to
11138 string. Use EMACS_INT, not int, for byte and char and arg counts.
11139 Support field widths and precisions larger than INT_MAX. Avoid
11140 sprintf's undefined behavior with conversion specifications such as %#d
11141 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11142 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11143 formatting out-of-range floating point numbers with int
9173deec 11144 formats. (Bug#8668)
37910ab2 11145
2e6578fb
PE
11146 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11147
0ae6bdee
PE
11148 * data.c: Avoid integer truncation in expressions involving floats.
11149 * data.c: Include <intprops.h>.
11150 (arith_driver): When there's an integer overflow in an expression
11151 involving floating point, convert the integers to floating point
11152 so that the resulting value does not suffer from catastrophic
11153 integer truncation. For example, on a 64-bit host (* 4
11154 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11155 Do not rely on undefined behavior after integer overflow.
11156
de883a70
PE
11157 merge count_size_as_multibyte, parse_str_to_multibyte
11158 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11159 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11160 Check for integer overflow.
11161 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11162 since it's now a duplicate of the other. This is more of
11163 a character than a buffer op, so better that it's in character.c.
11164 * fns.c, print.c: Adjust to above changes.
11165
2ff916cb
PE
111662011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11167
11168 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11169
f1b54466
PE
111702011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11171
fb1ac845
PE
11172 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11173 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11174 (x_clipboard_manager_save): Now static.
11175 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11176
f1b54466
PE
11177 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11178 (crypto_hash_function): Now static.
11179 Fix pointer signedness problems. Avoid unnecessary initializations.
11180
a9f737ee
CY
111812011-05-27 Chong Yidong <cyd@stupidchicken.com>
11182
11183 * termhooks.h (Vselection_alist): Make it terminal-local.
11184
11185 * terminal.c (create_terminal): Initialize it.
11186
11187 * xselect.c: Support for clipboard managers.
11188 (Vselection_alist): Move to termhooks.h as terminal-local var.
11189 (LOCAL_SELECTION): New macro.
11190 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11191 (symbol_to_x_atom): Remove gratuitous arg.
11192 (x_handle_selection_request, lisp_data_to_selection_data)
11193 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11194 (x_own_selection, x_get_local_selection, x_convert_selection):
11195 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11196 (some_frame_on_display): Delete unused function.
11197 (Fx_own_selection_internal, Fx_get_selection_internal)
11198 (Fx_disown_selection_internal, Fx_selection_owner_p)
11199 (Fx_selection_exists_p): New optional frame arg.
11200 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11201 (x_handle_selection_clear): Don't treat other terminals with the
11202 same keyboard specially. Use the terminal-local Vselection_alist.
11203 (x_clear_frame_selections): Use Frun_hook_with_args.
11204
11205 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11206
11207 * xterm.h: Add support for those atoms.
11208
e067f0c1
CY
112092011-05-26 Chong Yidong <cyd@stupidchicken.com>
11210
11211 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11212 (converted_selections, conversion_fail_tag): New global variables.
11213 (x_selection_request_lisp_error): Free the above.
11214 (x_get_local_selection): Remove unnecessary code.
11215 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11216 of converted selections stored in converted_selections.
11217 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11218 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11219 (x_convert_selection): New function.
11220 (x_handle_selection_event): Simplify.
11221 (x_get_foreign_selection): Don't ignore incoming requests while
11222 waiting for an answer; this will fail when we implement
11223 SAVE_TARGETS, and seems unnecessary anyway.
11224 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11225 (Vx_sent_selection_functions): Doc fix.
11226
0f4aebc0
LL
112272011-05-26 Leo Liu <sdl.web@gmail.com>
11228
11229 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11230
e61124cd
YM
112312011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11232
11233 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11234
11235 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11236 for fringe update if it has periodic bitmap.
ac389d0c 11237 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11238 and fringe_bitmap_periodic_p.
11239
11240 * fringe.c (get_fringe_bitmap_data): New function.
11241 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11242 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11243 row. Mark glyph row for fringe update if periodicity changed.
11244
11245 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11246 for fringe update unless it has periodic bitmap.
11247
f16d9837
KH
112482011-05-25 Kenichi Handa <handa@m17n.org>
11249
11250 * xdisp.c (get_next_display_element): Set correct it->face_id for
11251 a static composition.
11252
e1b90ef6
LL
112532011-05-24 Leo Liu <sdl.web@gmail.com>
11254
11255 * deps.mk (fns.o):
11256 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11257
11258 * fns.c (crypto_hash_function, Fsha1): New function.
11259 (Fmd5): Use crypto_hash_function.
11260 (syms_of_fns): Add Ssha1.
11261
7400048f
PE
112622011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11263
11264 * gnutls.c: Remove unused macros.
11265 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11266 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11267 Remove macros that are defined and never used.
11268 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11269
abb71cf4
CY
112702011-05-22 Chong Yidong <cyd@stupidchicken.com>
11271
11272 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11273 (Fx_get_selection_internal): Minor cleanup.
11274 (Fx_own_selection_internal): Rename arguments for consistency with
11275 select.el.
11276
6307db39
PE
112772011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11278
11279 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11280
f3d4e0a4
CY
112812011-05-22 Chong Yidong <cyd@stupidchicken.com>
11282
11283 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11284
4d8ade89
YM
112852011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11286
11287 * dispnew.c (scrolling_window): Don't exclude the case that the
11288 last enabled row in the desired matrix touches the bottom boundary.
11289
32078c8d
GM
112902011-05-21 Glenn Morris <rgm@gnu.org>
11291
11292 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11293 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11294 and add some more files.
32078c8d 11295
7285dc67
EZ
112962011-05-20 Eli Zaretskii <eliz@gnu.org>
11297
11298 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11299 report_file_error introduced by the change from 2011-05-07.
11300
89d1bd22
PE
113012011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11302
11303 * systime.h (Time): Define only if emacs is defined.
11304 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11305 where the include path doesn't have X11/X.h by default. See
11306 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11307
cd394be1 113082011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11309
11310 * composite.c (find_automatic_composition): Fix previous change.
11311
b9704ad9
GM
113122011-05-20 Glenn Morris <rgm@gnu.org>
11313
11314 * lisp.mk: New file, split from Makefile.in.
11315 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11316 (shortlisp): Remove.
11317 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11318
4a720484
GM
113192011-05-19 Glenn Morris <rgm@gnu.org>
11320
11321 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11322 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11323 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11324 (lisp): Set the order to that of loadup.el.
11325 (shortlisp): Make it a copy of $lisp.
11326 (SOME_MACHINE_LISP): Remove.
11327 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11328 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11329
a28d4396
KH
113302011-05-18 Kenichi Handa <handa@m17n.org>
11331
11332 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11333 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11334 (find_automatic_composition): Mostly rewrite for efficiency.
11335
a2b1fa8e
JB
113362011-05-18 Juanma Barranquero <lekktu@gmail.com>
11337
11338 * makefile.w32-in: Update dependencies.
11339
8e1f5610
CS
113402011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11341
11342 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11343 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11344
7025ee00 113452011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11346
cdfa6eab
PE
11347 Fix some integer overflow issues, such as string length overflow.
11348
06d6db33
PE
11349 * insdel.c (count_size_as_multibyte): Check for string overflow.
11350
2b4560a8
PE
11351 * character.c (lisp_string_width): Check for string overflow.
11352 Use EMACS_INT, not int, for string indexes and lengths; in
11353 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11354 the resulting string length overflows an EMACS_INT; instead,
11355 report a string overflow if no precision given. When checking for
11356 precision exhaustion, use a check that cannot possibly have
11357 integer overflow. (Bug#8675)
11358 * character.h (lisp_string_width): Adjust to new signature.
11359
cb93f9be
PE
11360 * alloc.c (string_overflow): New function.
11361 (Fmake_string): Use it. This doesn't change behavior, but saves
11362 a few bytes and will simplify future changes.
11363 * character.c (string_escape_byte8): Likewise.
11364 * lisp.h (string_overflow): New decl.
11365
1a1f3366
PE
11366 Fixups, following up to the user-interface timestamp change.
11367 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11368 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11369 * msdos.c (mouse_get_pos): Likewise.
11370 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11371 * w32gui.h (Time): Define by including "systime.h" rather than by
11372 declaring it ourselves. (Bug#8664)
11373
d4e3e4d3
PE
11374 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11375 * image.c (clear_image_cache): Likewise.
11376
f6a24d19
PE
11377 * term.c (term_mouse_position): Don't assume time_t wraparound.
11378
08dc5ae6
PE
11379 Be more systematic about user-interface timestamps.
11380 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11381 and sometimes 'EMACS_UINT', to represent these timestamps.
11382 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11383 This makes the code easier to follow, and makes it easier to catch
11384 integer overflow bugs such as Bug#8664.
11385 * frame.c (Fmouse_position, Fmouse_pixel_position):
11386 Use Time, not unsigned long, for user-interface timestamps.
11387 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11388 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11389 * keyboard.h (last_event_timestamp): Likewise.
11390 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11391 * menu.h (xmenu_show): Likewise.
11392 * term.c (term_mouse_position): Likewise.
11393 * termhooks.h (struct input_event.timestamp): Likewise.
11394 (struct terminal.mouse_position_hook): Likewise.
11395 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11396 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11397 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11398 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11399 what it was before.
11400 * menu.h, termhooks.h: Include "systime.h", for Time.
11401
8e55734a
PE
11402 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11403 Don't assume that the difference between two unsigned long values
11404 can fit into an integer. At this point, we know button_down_time
11405 <= event->timestamp, so the difference must be nonnegative, so
11406 there's no need to cast the result if double-click-time is
11407 nonnegative, as it should be; check that it's nonnegative, just in
11408 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11409 apart (about 25 days). (Bug#8664)
8e55734a 11410
841f1b75 11411 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11412 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11413
3e26f69c
PE
11414 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11415 that always fit in int. Use a sentinel instead of a counter, to
11416 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11417 * frame.h (struct frame): Use int for menu_bar_items_used
11418 instead of EMACS_INT, since it always fits in int.
3e26f69c 11419
5cc152c0
PE
11420 * menu.c (grow_menu_items): Check for int overflow.
11421
d89eb65e
PE
11422 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11423
5235bd3e
PE
11424 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11425 Before, the code was not consistent. These values cannot exceed
11426 2**31 - 1 so there's no need to make them unsigned.
11427 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11428 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11429 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11430 as modifiers.
11431 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11432
bc827e23
PE
11433 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11434 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11435 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11436 presumably because the widths might not match.
11437
78eb494e
PE
11438 * window.c (size_window): Avoid needless test at loop start.
11439
04f2d78b
CB
114402011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11441
11442 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11443
d2fc7e3d 114442011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11445
11446 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11447
d2fc7e3d 114482011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11449
11450 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11451 `width' to `bar_area_x' and `bar_area_width', respectively.
11452 (x_scroll_run): Take account of fringe background extension.
11453
04f2d78b
CB
11454 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11455 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11456 `bar_area_width', respectively.
11457 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11458 background extension.
11459
79b70037
GM
114602011-05-10 Jim Meyering <meyering@redhat.com>
11461
11462 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11463
2f142cc5
JB
114642011-05-10 Juanma Barranquero <lekktu@gmail.com>
11465
11466 * image.c (Finit_image_library): Return t for built-in image types,
11467 like pbm and xbm. (Bug#8640)
11468
57679c86
AS
114692011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11470
11471 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11472
888c9e86
EZ
114732011-05-07 Eli Zaretskii <eliz@gnu.org>
11474
b0512a1d
EZ
11475 * w32console.c (Fset_screen_color): Doc fix.
11476 (Fget_screen_color): New function.
11477 (syms_of_ntterm): Defsubr it.
11478
7285dc67
EZ
11479 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11480 unlink the temporary file if Fcall_process didn't create it in the
11481 first place.
11482 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11483 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11484 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11485 cue to call_process_cleanup not to close that handle.
11486
4d3fcc8e
BK
114872011-05-07 Ben Key <bkey76@gmail.com>
11488
11489 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11490 one of two shell specific rules, either bootstrap-temacs-CMD or
11491 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11492 to the previous implementation of the bootstrap-temacs rule.
11493 The bootstrap-temacs-CMD rule is similar to the previous
11494 implementation of the bootstrap-temacs rule except that it
11495 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11496 variable.
11497
11498 These changes, along with some changes to nt/configure.bat,
11499 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11500 earlier fix to add support for --cflags and --ldflags options
11501 that include quotes so that it works whether make uses cmd or
11502 sh as the shell.
11503
b4289b64
MA
115042011-05-06 Michael Albinus <michael.albinus@gmx.de>
11505
11506 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11507 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11508 is a constant.
11509 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11510 a string. Handle both cases.
11511 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11512 (Fdbus_register_method): Use Qinvalid_function.
11513
af4c0e28
JB
115142011-05-06 Juanma Barranquero <lekktu@gmail.com>
11515
11516 * makefile.w32-in: Update dependencies.
11517 (LISP_H): Add inttypes.h and stdin.h.
11518 (PROCESS_H): Add unistd.h.
11519
c51453d9
EZ
115202011-05-06 Eli Zaretskii <eliz@gnu.org>
11521
11522 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11523 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11524
8ff0ac3c 115252011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11526
4c4b566b
PE
11527 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11528
aab2b9b5
PE
11529 * term.c (vfatal): Remove stray call to va_end.
11530 It's not needed and the C Standard doesn't allow it here anyway.
11531
c378da0b
PE
11532 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11533 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11534
288b08c7
PE
11535 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11536 bytes.
11537
e3601888
PE
11538 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11539
db6c0e74
PE
11540 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11541
dd5963ea
PE
11542 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11543
88c9450f
PE
11544 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11545
2f9442b8
PE
11546 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11547
c032b5f8
PE
11548 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11549 * charset.c (Fdefine_charset_internal): Don't initialize
11550 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11551 32-bit int (Bug#8600).
a108c10b
PE
11552
11553 * lread.c (read_integer): Be more consistent with string-to-number.
11554 Use string_to_number to do the actual conversion; this avoids
11555 rounding errors and fixes some other screwups. Without this fix,
11556 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11557 (digit_to_number): Move earlier, for benefit of read_integer.
11558 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11559 not a digit in any supported base. (Bug#8602)
a108c10b 11560
ad5f9eea
PE
11561 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11562
aec1708a
PE
11563 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11564 to match comment at start of function. This also removes a
11565 GCC warning about overflow in a 32+64-bit port.
11566
47be4ab5
PE
11567 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11568
371cac43
PE
11569 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11570 Reported by Stefan Monnier in
11571 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11572 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11573 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11574
d01a7826
PE
11575 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11576 (EMACS_UINTPTR): Likewise, with uintptr_t.
11577
7fd47d5c
PE
11578 * lisp.h: Prefer 64-bit EMACS_INT if available.
11579 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11580 on 32-bit hosts that have 64-bit int, so that they can access
11581 large files.
122b0c86
PE
11582 However, temporarily disable this change unless the temporary
11583 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11584
8727937b
PE
11585 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11586
8ac068ac
PE
11587 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11588 This removes an assumption that EMACS_INT and long are the same
11589 width as pointers. The assumption is true for Emacs porting targets
11590 now, but we want to make other targets possible.
11591 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11592 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11593 In the rest of the code, change types of integers that hold casted
11594 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11595 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11596 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11597 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11598 No need to cast type when ORing.
11599 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11600 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11601 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11602 assume EMACS_INT is the same width as char *.
11603 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11604 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11605 Remove no-longer-needed casts.
11606 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11607 (xg_tool_bar_help_callback, xg_make_tool_item):
11608 Use EMACS_INTPTR to hold an integer
11609 that will be cast to void *; this can avoid a GCC warning
11610 if EMACS_INT is not the same width as void *.
11611 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11612 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11613 (current_message_1, set_message_1):
11614 Use a local to convert to proper width without a cast.
11615 * xmenu.c (dialog_selection_callback): Likewise.
11616
ede49d71
PE
11617 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11618 Also, don't assume VALBITS / RAND_BITS is less than 5,
11619 and don't rely on undefined behavior when shifting a 1 left into
11620 the sign bit.
11621 * lisp.h (get_random): Change signature to match.
11622
2f30ecd0
PE
11623 * lread.c (hash_string): Use size_t, not int, for hash computation.
11624 Normally we prefer signed values; but hashing is special, because
11625 it's better to use unsigned division on hash table sizes so that
11626 the remainder is nonnegative. Also, size_t is the natural width
11627 for hashing into memory. The previous code used 'int', which doesn't
11628 retain enough info to hash well into very large tables.
11629 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11630
2a866e7b
PE
11631 * dbusbind.c: Don't possibly lose pointer info when converting.
11632 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11633 Use XPNTR rather than XHASH, so that the high-order bits of
11634 the pointer aren't lost when converting through void *.
11635
51639eac
PE
11636 * eval.c (Fautoload): Don't double-shift a pointer.
11637
92394119
PE
11638 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11639
dbdb9a7c
JB
116402011-05-06 Juanma Barranquero <lekktu@gmail.com>
11641
11642 * gnutls.c (DEF_GNUTLS_FN):
11643 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11644
db7a0b4f
AS
116452011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11646
11647 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11648 marker. (Bug#8610)
11649
cd394be1 116502011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11651
11652 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11653 New version that can reserve upto 2GB of heap space.
11654
f7ff1b0f 116552011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11656
11657 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11658
639c109b
TZ
116592011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11660
11661 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11662 `gnutls_certificate_set_x509_key_file'.
11663
d2127135
JB
116642011-05-05 Juanma Barranquero <lekktu@gmail.com>
11665
11666 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11667 Update dependencies.
11668
e968f4f3
JB
116692011-05-04 Juanma Barranquero <lekktu@gmail.com>
11670
11671 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11672 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11673 Remove unused parameter `fildes'.
11674 * process.c (read_process_output, send_process): Don't pass it.
11675
84d358f0
JB
116762011-05-04 Juanma Barranquero <lekktu@gmail.com>
11677
11678 Fix previous change: the library cache is defined in w32.c.
11679 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11680 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11681
0898ca10
JB
116822011-05-04 Juanma Barranquero <lekktu@gmail.com>
11683
11684 Implement dynamic loading of GnuTLS on Windows.
11685
11686 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11687 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11688 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11689 Declare.
11690
11691 * gnutls.c (Qgnutls_dll): Define.
11692 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11693 (gnutls_*): Declare function pointers.
11694 (init_gnutls_functions): New function to initialize function pointers.
11695 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11696 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11697 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11698 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11699 (emacs_gnutls_write, emacs_gnutls_read)
11700 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11701 (Fgnutls_available_p): New function.
11702 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11703 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11704 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11705
11706 * image.c: Include w32.h.
11707 (Vimage_type_cache): Delete.
11708 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11709 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11710 (w32_delayed_load): Move to w32.c.
11711
11712 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11713
11714 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11715 (w32_delayed_load): Move from image.c. When loading a library, record
11716 its filename in the :loaded-from property of the library id.
11717 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11718 Initialize and staticpro them.
11719 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11720
11721 * process.c: Include lisp.h before w32.h, not after.
11722 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11723 instead of gnutls_record_check_pending.
11724
11725 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11726
ff4de4aa
TZ
117272011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11728
11729 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11730 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11731 as passed in.
11732
abe95abb
JD
117332011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11734
11735 * xterm.c (x_set_frame_alpha): Do not set property on anything
11736 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11737
e16e55d4
JB
117382011-05-02 Juanma Barranquero <lekktu@gmail.com>
11739
11740 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11741
bafcf6a5
JB
117422011-05-02 Juanma Barranquero <lekktu@gmail.com>
11743
11744 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11745 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11746 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11747 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11748 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11749 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11750 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11751 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11752 (Qgnutls_bootprop_callbacks_verify): Make static.
11753
e7a6747f
AS
117542011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11755
19ed11ba
AS
11756 * callproc.c: Indentation fixup.
11757
e7a6747f 11758 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11759 (wait_for_termination, interruptible_wait_for_termination):
11760 Move after wait_for_termination_1.
e7a6747f 11761
1ef14cb4
LMI
117622011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11763
11764 * sysdep.c (interruptible_wait_for_termination): New function
11765 which is like wait_for_termination, but allows keyboard
11766 interruptions.
11767
11768 * callproc.c (Fcall_process): Add (:file "file") as an option for
11769 the STDOUT buffer.
11770 (Fcall_process_region): Ditto.
11771
330d880c
EZ
117722011-04-30 Eli Zaretskii <eliz@gnu.org>
11773
8db90b73
EZ
11774 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11775 rather than `XVECTOR (FOO)->size'.
11776
330d880c
EZ
11777 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11778 inttypes.h, as a gnulib replacement is used if it not available in
11779 system headers.
11780
15cbd324
EZ
117812011-04-21 Eli Zaretskii <eliz@gnu.org>
11782
11783 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11784 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11785 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11786
11787 * coding.c (coding_alloc_by_realloc): Error out if destination
11788 will grow beyond MOST_POSITIVE_FIXNUM.
11789 (decode_coding_emacs_mule): Abort if there isn't enough place in
11790 charbuf for the composition carryover bytes. Reserve an extra
11791 space for up to 2 characters produced in a loop.
11792 (decode_coding_iso_2022): Abort if there isn't enough place in
11793 charbuf for the composition carryover bytes.
11794
117952011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11796
ae940cca
EZ
11797 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11798 aborting when %lld or %lll format is passed.
11799 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11800 %llo or %llx format is passed. (Bug#8545)
11801
03ab8921
EZ
11802 * window.c (window_scroll_line_based): Use a marker instead of
11803 simple variables to record original value of point. (Bug#7952)
11804
afda1437
EZ
11805 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11806 produced by %s or %c overflows available buffer space. (Bug#8545)
11807
f76dee0c
PE
118082011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11809
11810 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11811 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11812
fdc5744d
JB
118132011-04-28 Juanma Barranquero <lekktu@gmail.com>
11814
11815 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11816
638f053a
JB
118172011-04-28 Juanma Barranquero <lekktu@gmail.com>
11818
11819 * keyboard.c (Qdelayed_warnings_hook): Define.
11820 (command_loop_1): Run `delayed-warnings-hook'
11821 if Vdelayed_warnings_list is non-nil.
11822 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11823 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11824
d178f871
EZ
118252011-04-28 Eli Zaretskii <eliz@gnu.org>
11826
11827 * doprnt.c (doprnt): Don't return value smaller than the buffer
11828 size if the message was truncated. (Bug#8545).
11829
b124fd93
JB
118302011-04-28 Juanma Barranquero <lekktu@gmail.com>
11831
11832 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11833 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11834
e810457d
PE
118352011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11836
11837 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11838
ea51cceb
JB
118392011-04-27 Juanma Barranquero <lekktu@gmail.com>
11840
11841 * makefile.w32-in: Update dependencies.
11842
94dcfacf
EZ
118432011-04-27 Eli Zaretskii <eliz@gnu.org>
11844
11845 Improve `doprnt' and its usage. (Bug#8545)
11846 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11847 `format_end'. Remove support for %l as a conversion specifier.
11848 Don't use xrealloc. Improve diagnostics when the %l size modifier
11849 is used. Update the commentary.
11850
11851 * eval.c (verror): Simplify calculation of size_t.
11852
11853 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11854 messages.
11855
f61f41d7
PE
118562011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11857
11858 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11859 change.
11860
96fb4434
PE
118612011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11862
11863 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11864 This makes this file independent of the recent pseudovector change.
11865
671875da 118662011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11867
69e9b5a3
PE
11868 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11869
b5f869a7 11870 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11871 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11872 Remove unused local.
c8926152 11873 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11874
841a1577 11875 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11876 GCC 4.6.0 optimizes based on type-based alias analysis.
11877 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11878 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11879 != &v->size, and therefore "v->size = 1; b->size = 2; return
11880 v->size;" must therefore return 1. This assumption is incorrect
11881 for Emacs, since it type-puns struct Lisp_Vector * with many other
11882 types. To fix this problem, this patch adds a new type struct
f904488f 11883 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11884 and pseudovectors, and helps optimizing compilers not get fooled
11885 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11886 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11887 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11888 the size member.
eab3844f
PE
11889 (XSETPVECTYPE): Rewrite in terms of new macro.
11890 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11891 This is a bit clearer, and further avoids the possibility of
11892 undesirable aliasing.
11893 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11894 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11895 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11896 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11897 (ASIZE): Now uses header.size rather than size.
11898 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11899 to avoid the hassle of writing XVECTOR (foo)->header.size.
11900 (struct vectorlike_header): New type.
eab3844f
PE
11901 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11902 object, to help avoid aliasing.
11903 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11904 (SUBRP): Likewise, since Lisp_Subr is a special case.
11905 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11906 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11907 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11908 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11909 changed to be "header.size" and "header.next".
11910 * buffer.h (struct buffer): Likewise.
11911 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11912 * frame.h (struct frame): Likewise.
11913 * process.h (struct Lisp_Process): Likewise.
11914 * termhooks.h (struct terminal): Likewise.
11915 * window.c (struct save_window_data, struct saved_window): Likewise.
11916 * window.h (struct window): Likewise.
11917 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11918 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11919 * buffer.c (init_buffer_once): Likewise.
11920 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11921 special case.
11922 * process.c (Fformat_network_address): Use local var for size,
11923 for brevity.
11924
0df1eac5
PE
11925 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11926
847ab9d1 11927 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11928 * data.c (atof): Remove decl; no longer used or needed.
11929 (digit_to_number): Move to lread.c.
11930 (Fstring_to_number): Use new string_to_number function, to be
11931 consistent with how the Lisp reader treats infinities and NaNs.
11932 Do not assume that floating-point numbers represent EMACS_INT
11933 without losing information; this is not true on most 64-bit hosts.
11934 Avoid double-rounding errors, by insisting on integers when
11935 parsing non-base-10 numbers, as the documentation specifies.
11936 * lisp.h (string_to_number): New decl, replacing ...
11937 (isfloat_string): Remove.
bc0a5c13 11938 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11939 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11940 appears to have been a coding error. Similarly, do not accept
11941 strings like +-1e0 as floating point numbers. Do not report
11942 overflow for integer overflows unless the base is not 10 which
11943 means we have no simple and reliable way to continue.
11944 Break out the floating-point parsing into a new
11945 function string_to_number, so that Fstring_to_number parses
11946 floating point numbers consistently with the Lisp reader.
04f2d78b 11947 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11948 (E_CHAR, EXP_INT): Remove, replacing with ...
11949 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11950 (string_to_number): New function, replacing isfloat_string.
11951 This function checks for valid syntax and produces the resulting
11952 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11953 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11954 so that overflow for non-base-10 numbers is reported only when
11955 there's no portable and simple way to convert to floating point.
452f4150 11956
67769ffc
PE
11957 * textprop.c (set_text_properties_1): Rewrite for clarity,
11958 and to avoid GCC warning about integer overflow.
11959
c20db43f
PE
11960 * intervals.h (struct interval): Use EMACS_INT for members
11961 where EMACS_UINT might cause problems. See
11962 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11963 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11964 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11965 All uses changed.
37aa2f85
PE
11966 (offset_intervals): Tell GCC not to worry about length overflow
11967 when negating a negative length.
c20db43f 11968
2538aa2f
PE
11969 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11970 (overrun_check_free): Likewise.
11971
f2d3008d
PE
11972 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11973 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11974 word size.
11975
ec8df744
PE
11976 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11977 (gnutls_make_error): Rename local to avoid shadowing.
11978 (gnutls_emacs_global_deinit): ifdef out; not used.
11979 (Fgnutls_boot): Use const for pointer to readonly storage.
11980 Comment out unused local. Fix pointer signedness problems.
11981
640ee02d
PE
11982 * lread.c (openp): Don't stuff size_t into an 'int'.
11983 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11984 about possible signed overflow.
11985
6048fb2a
PE
11986 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11987 (GDK_KEY_g): Don't define if already defined.
11988 (xg_prepare_tooltip): Avoid pointer signedness problem.
11989 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11990
fa3c87e1
PE
11991 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11992 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11993
2172544b
PE
11994 * xfns.c (Fx_window_property): Simplify a bit,
11995 to make a bit faster and to avoid GCC 4.6.0 warning.
11996 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11997
9b821a21
PE
11998 * fns.c (internal_equal): Don't assume size_t fits in int.
11999
3c616cfa
PE
12000 * alloc.c (compact_small_strings): Tighten assertion a little.
12001
c2982e87
PE
12002 Replace pEd with more-general pI, and fix some printf arg casts.
12003 * lisp.h (pI): New macro, generalizing old pEd macro to other
12004 conversion specifiers. For example, use "...%"pI"d..." rather
12005 than "...%"pEd"...".
12006 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12007 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12008 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12009 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12010 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12011 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12012 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12013 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12014 64-bit hosts.
12015 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12016 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12017 * print.c (safe_debug_print, print_object): Likewise.
12018 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12019 to int.
6f04d126
PE
12020 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12021 avoiding the 0 flag, which is not portable.
c2982e87
PE
12022 * process.c (Fmake_network_process): Use pI to avoid cast.
12023 * region-cache.c (pp_cache): Likewise.
12024 * xdisp.c (decode_mode_spec): Likewise.
12025 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12026 behavior on 64-bit hosts with printf arg.
6f04d126 12027 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12028 (x_stop_queuing_selection_requests): Likewise.
12029 (x_get_window_property): Don't truncate byte count to an 'int'
12030 when tracing.
0b432f21 12031
5e073ec7
PE
12032 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12033 here, since it parses constructs like leading '-' and spaces,
12034 which are not wanted; and it overflows with large numbers.
12035 Instead, simply match F[0-9]+, which is what is wanted anyway.
12036
36372bf9
PE
12037 * alloc.c: Remove unportable assumptions about struct layout.
12038 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12039 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12040 (allocate_vectorlike, make_pure_vector): Use the new macros,
12041 plus offsetof, to remove unportable assumptions about struct layout.
12042 These assumptions hold on all porting targets that I know of, but
12043 they are not guaranteed, they're easy to remove, and removing them
12044 makes further changes easier.
12045
0b432f21
PE
12046 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12047 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12048 (string_overrun_cookie): Now const. Use initializers that
12049 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12050 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12051 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12052 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12053 multiple of sizeof (EMACS_INT); it need not be, if
12054 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12055 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12056
895009e1
JB
120572011-04-26 Juanma Barranquero <lekktu@gmail.com>
12058
12059 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12060
6a7a1b0b
TZ
120612011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12062
12063 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12064 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12065 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12066
841a1577 120672011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12068
12069 * lisp.h (Qdebug): List symbol.
895009e1 12070 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12071 * keyboard.c (debug-on-event): New variable.
12072 (handle_user_signal): Break into debugger when debug-on-event
12073 matches the current signal symbol.
12074
f2d3ba6f
DN
120752011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12076
12077 * alloc.c (check_sblock, check_string_bytes)
12078 (check_string_free_list): Convert to standard C.
12079
42ce4c63
TZ
120802011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12081
12082 * w32.c (emacs_gnutls_push): Fix typo.
12083
825cd63c
EZ
120842011-04-25 Eli Zaretskii <eliz@gnu.org>
12085
fb11d64d
EZ
12086 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12087 "cast to pointer from integer of different size".
12088
825cd63c
EZ
12089 Improve doprnt and its use in verror. (Bug#8545)
12090 * doprnt.c (doprnt): Document the set of format control sequences
12091 supported by the function. Use SAFE_ALLOCA instead of always
12092 using `alloca'.
12093
12094 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12095 is one byte too soon. Don't use xrealloc; instead xfree and
12096 xmalloc anew.
12097
e061a11b
TZ
120982011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12099
12100 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12101 callbacks stage.
12102
12103 * gnutls.c: Renamed global_initialized to
12104 gnutls_global_initialized. Added internals for the
12105 :verify-hostname-error, :verify-error, and :verify-flags
12106 parameters of `gnutls-boot' and documented those parameters in the
12107 docstring. Start callback support.
9173deec
JB
12108 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12109 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12110 on error. Return error code.
e061a11b
TZ
12111 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12112 (emacs_gnutls_read): Likewise.
12113 (Fgnutls_boot): Return handshake error code.
12114 (emacs_gnutls_handle_error): New function.
12115 (wsaerror_to_errno): Likewise.
12116
12117 * w32.h (emacs_gnutls_pull): Add prototype.
12118 (emacs_gnutls_push): Likewise.
12119
12120 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12121 (emacs_gnutls_push): Likewise.
12122
121232011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12124
12125 * process.c (wait_reading_process_output): Check if GnuTLS
12126 buffered some data internally if no FDs are set for TLS
12127 connections.
12128
12129 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12130 (LIBS): Link to USER_LIBS.
12131 ($(BLD)/gnutls.$(0)): New target.
12132
fa6996bc
EZ
121332011-04-24 Eli Zaretskii <eliz@gnu.org>
12134
eb35682e
EZ
12135 * xdisp.c (handle_single_display_spec): Rename the
12136 display_replaced_before_p argument into display_replaced_p, to
12137 make it consistent with the commentary. Fix typos in the
12138 commentary.
12139
e2ad650c
EZ
12140 * textprop.c (syms_of_textprop): Remove dead code.
12141 (copy_text_properties): Delete obsolete commentary about an
12142 interface that was deleted long ago. Fix typos in the description
12143 of arguments.
12144
1b2de274
EZ
12145 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12146 to changes in oldXMenu/XMenu.h from 2011-04-16.
12147 <menu_help_message, prev_menu_help_message>: Constify.
12148 (IT_menu_make_room): menu->help_text is now `const char **';
12149 adjust.
12150
12151 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12152 to changes in oldXMenu/XMenu.h from 2011-04-16.
12153 (struct XMenu): Declare `help_text' `const char **'.
12154
12155 * xfaces.c <Qunspecified>: Make extern again.
12156
12157 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12158 required by POSIX.
1b2de274 12159
762b15be
EZ
12160 * doc.c (get_doc_string): Improve the format passed to `error'.
12161
12162 * doprnt.c (doprnt): Improve commentary.
12163
12164 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12165
12166 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12167 them with etags.
12168
f1052e5d
EZ
12169 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12170 changes in globals.h immediately force recompilation.
762b15be
EZ
12171 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12172 $(CURDIR)/s/ms-w32.h.
12173 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12174
fa6996bc
EZ
12175 * character.c (Fchar_direction): Function deleted.
12176 (syms_of_character): Don't defsubr it.
12177 <char-direction-table>: Deleted.
12178
e6c3da20
EZ
121792011-04-23 Eli Zaretskii <eliz@gnu.org>
12180
12181 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12182 * doprnt.c: Include limits.h.
12183 (SIZE_MAX): New macro.
04f2d78b
CB
12184 (doprnt): Return a size_t value. 2nd arg is now size_t.
12185 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12186 Improve overflow protection. Support `l' modifier for integer
12187 conversions. Support %l conversion. Don't assume an EMACS_INT
12188 argument for integer conversions and for %c.
12189
12190 * lisp.h (doprnt): Restore prototype.
12191
12192 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12193 $(SRC)/character.h.
12194
12195 * Makefile.in (base_obj): Add back doprnt.o.
12196
12197 * deps.mk (doprnt.o): Add back prerequisites.
12198 (callint.o): Depend on character.h.
12199
12200 * eval.c (internal_lisp_condition_case): Include the handler
12201 representation in the error message.
12202 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12203 when breaking from the loop.
12204
12205 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12206
12207 * callint.c (Fcall_interactively): When displaying error message
12208 about invalid control letter, pass the character's codepoint, not
12209 a pointer to its multibyte form. Improve display of the character
12210 in octal and display also its hex code.
12211
12212 * character.c (char_string): Use %x to display the (unsigned)
12213 codepoint of an invalid character, to avoid displaying a bogus
12214 negative value.
12215
12216 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12217 `error', not SYMBOL_NAME itself.
12218
12219 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12220 character arguments to `error'.
12221
12222 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12223 to `error' in error message about FINAL_CHAR argument. Make sure
12224 FINAL_CHAR is a character, and use %c when it is passed as
12225 argument to `error'.
12226
4ffd0d6b 122272011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12228
12229 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12230
12231 * w32.c: Include <time.h>.
12232 (sys_localtime): New function.
12233
4ffd0d6b 122342011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12235
12236 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12237
4ffd0d6b 12238 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12239
4ffd0d6b 122402011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12241
4ffd0d6b
GM
12242 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12243 zombies (Bug#8467).
aac0c6e3 12244
04c56954
EZ
122452011-04-19 Eli Zaretskii <eliz@gnu.org>
12246
12247 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12248 gl_state.e_property when gl_state.object is Qt.
12249
12250 * insdel.c (make_gap_larger): Remove limitation of buffer size
12251 to <= INT_MAX.
12252
16a43933
CY
122532011-04-18 Chong Yidong <cyd@stupidchicken.com>
12254
12255 * xdisp.c (lookup_glyphless_char_display)
12256 (produce_glyphless_glyph): Handle cons cell entry in
12257 glyphless-char-display.
12258 (Vglyphless_char_display): Document it.
12259
12260 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12261 glyphless-char-display.
12262
4581706e
CY
122632011-04-17 Chong Yidong <cyd@stupidchicken.com>
12264
12265 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12266
12267 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12268
12269 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12270 definition for no-X builds.
12271
4887c6e2 122722011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12273
fd35b6f9
PE
12274 Static checks with GCC 4.6.0 and non-default toolkits.
12275
5c1ccb01
PE
12276 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12277
006c5daa
PE
12278 * process.c (keyboard_bit_set): Define only if SIGIO.
12279 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12280 (send_process): Repair possible setjmp clobbering.
12281
efc736d3
PE
12282 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12283
4e2fe2e6
PE
12284 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12285
f97334a2
PE
12286 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12287
4e75f29d
PE
12288 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12289 Define only if needed.
12290
90efadd1
PE
12291 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12292 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12293 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12294
3c647824
PE
12295 * dispextern.h (struct redisplay_interface): Rename param
12296 to avoid shadowing.
e264f262 12297 * termhooks.h (struct terminal): Likewise.
761383f4 12298 * xterm.c (xembed_send_message): Likewise.
3c647824 12299
b58c5c4a
PE
12300 * insdel.c (make_gap_smaller): Define only if
12301 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12302
cad59032
PE
12303 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12304 it.
12305
c339dc2e
PE
12306 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12307 so that we aren't warned about unused symbols.
12308
91a3e27b
PE
12309 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12310
399c71d3 12311 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12312
8ffc96f5
PE
12313 * xfns.c (x_real_positions): Mark locals as initialized.
12314
eef9bc79
PE
12315 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12316
098db9dd
PE
12317 * xterm.c: Fix problems found by static analysis with other toolkits.
12318 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12319 (x_dispatch_event): Declare static if USE_GTK, and
12320 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12321 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12322 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12323 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12324 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12325
eb18f6cc
PE
12326 * xmenu.c (menu_help_callback): Pointer type fixes.
12327 Use const pointers when pointing at readonly data. Avoid pointer
12328 signedness clashes.
12329 (FALSE): Remove unused macro.
12330 (update_frame_menubar): Remove unused decl.
12331
1fe72bf8
PE
12332 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12333
60d9e1db
PE
12334 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12335 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12336 (single_menu_item): Rename local to avoid shadowing.
12337
39261c26
PE
12338 * keyboard.c (make_lispy_event): Remove unused local var.
12339
018c5e19
PE
12340 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12341 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12342
63d2b86e
PE
12343 * bitmaps: Change bitmaps from unsigned char back to the X11
12344 compatible char. Avoid the old compiler warnings about
12345 out-of-range initializers by using, for example, '\xab' rather
12346 than 0xab.
12347
aefd87e1
PE
12348 * xgselect.c (xgselect_initialize): Check vs interface
12349 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12350
bf501fb9
PE
12351 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12352
e9829fdf
PE
12353 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12354 to read-only memory.
12355
1086c095
PE
12356 * fns.c (vector): Remove; this old hack is no longer needed.
12357
2baccd04 12358 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12359 Remove unused var.
dde42981 12360 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12361
72391843 12362 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12363
436c16df 12364 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12365 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12366 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12367
92bb796d 12368 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12369 (x_term_init): Remove local to avoid shadowing.
92bb796d 12370
764430a3 12371 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12372
12373 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12374 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12375
d1dfb56c
EZ
123762011-04-16 Eli Zaretskii <eliz@gnu.org>
12377
c4354cb4
EZ
12378 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12379
d1dfb56c
EZ
12380 Fix regex.c, syntax.c and friends for buffers > 2GB.
12381 * syntax.h (struct gl_state_s): Declare character position members
12382 EMACS_INT.
12383
12384 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12385
04f2d78b
CB
12386 * textprop.c (verify_interval_modification, interval_of):
12387 Declare arguments EMACS_INT.
d1dfb56c
EZ
12388
12389 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12390 EMACS_INT.
12391
12392 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12393
12394 * indent.c (Fvertical_motion): Local variable it_start is now
12395 EMACS_INT.
12396
12397 * regex.c (re_match, re_match_2, re_match_2_internal)
12398 (bcmp_translate, regcomp, regexec, print_double_string)
12399 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12400 (re_compile_pattern, re_exec): Declare arguments and local
12401 variables `size_t' and `ssize_t' and return values `regoff_t', as
12402 appropriate.
12403 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12404 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12405 <compile_stack_type>: `size' and `avail' are now `size_t'.
12406
12407 * regex.h <regoff_t>: Use ssize_t, not int.
12408 (re_search, re_search_2, re_match, re_match_2): Arguments that
12409 specify buffer/string position and length are now ssize_t and
12410 size_t. Return type is regoff_t.
12411
613052cd
BK
124122011-04-16 Ben Key <bkey76@gmail.com>
12413
12414 * nsfont.m: Fixed bugs in ns_get_family and
12415 ns_descriptor_to_entity that were caused by using free to
12416 deallocate memory blocks that were allocated by xmalloc (via
12417 xstrdup). This caused Emacs to crash when compiled with
12418 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12419 --enable-checking=xmallocoverrun). xfree is now used to
12420 deallocate these memory blocks.
12421
4170f62f 124222011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12423
71b41406
PE
12424 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12425
9587a89d
PE
12426 emacs_write: Accept and return EMACS_INT for sizes.
12427 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12428 et seq.
12429 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12430 Accept and return EMACS_INT.
12431 (emacs_gnutls_write): Return the number of bytes written on
12432 partial writes.
12433 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12434 (emacs_read, emacs_write): Remove check for negative size, as the
12435 Emacs source code has been audited now.
9587a89d
PE
12436 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12437 (emacs_read, emacs_write): Use it.
273a5f82
PE
12438 * process.c (send_process): Adjust to the new signatures of
12439 emacs_write and emacs_gnutls_write. Do not attempt to store
12440 a byte offset into an 'int'; it might overflow.
9587a89d 12441 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12442
3e047f51
PE
12443 * sound.c: Don't assume sizes fit in 'int'.
12444 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12445 Return EMACS_INT, not int.
3e047f51 12446 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12447 Accept EMACS_INT, not int.
12448 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12449 record read return values.
12450
cc39a9db
BK
124512011-04-15 Ben Key <bkey76@gmail.com>
12452
c9d0ec6d
JB
12453 * keyboard.c (Qundefined): Don't declare static since it is used
12454 in nsfns.m.
12455 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12456 static since they are used in nsfont.m.
cc39a9db 12457
6c60eb9f
SM
124582011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12459
12460 * process.c (Qprocessp): Don't declare static.
12461 * lisp.h (Qprocessp): Declare again.
12462
7990b61a
JB
124632011-04-15 Juanma Barranquero <lekktu@gmail.com>
12464
12465 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12466
5d4cb038
PE
124672011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12468
8bd7b830 12469 Improve C-level modularity by making more things 'static'.
cd64ea1d 12470
e3b27b31
PE
12471 Don't publish debugger-only interfaces to other modules.
12472 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12473 (verify_bytepos, count_markers): Move decls to the only modules
12474 that need them.
12475 * region-cache.h (pp_cache): Likewise.
12476 * window.h (check_all_windows): Likewise.
12477 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12478
5d4cb038
PE
12479 * sysdep.c (croak): Now static, if
12480 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12481 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12482
12483 * alloc.c (refill_memory_reserve): Now static if
12484 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12485 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12486
e87b6180
PE
12487 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12488 Define only if USE_LUCID.
12489
ac64929e
PE
12490 * xrdb.c (x_customization_string, x_rm_string): Now static.
12491
6f37259d
PE
12492 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12493 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12494
1683e3ab
PE
12495 * xdisp.c (draw_row_with_mouse_face): Now static.
12496 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12497
de9c2632
PE
12498 * window.h (check_all_windows): Mark externally visible.
12499
2b96acb7
PE
12500 * window.c (window_deletion_count): Now static.
12501
12502 * undo.c: Make symbols static if they're not exported.
12503 (last_undo_buffer, last_boundary_position, pending_boundary):
12504 Now static.
12505
50436f33
PE
12506 * textprop.c (interval_insert_behind_hooks): Now static.
12507 (interval_insert_in_front_hooks): Likewise.
12508
64520e5c
PE
12509 * term.c: Make symbols static if they're not exported.
12510 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12511 (max_frame_lines, tty_set_terminal_modes):
12512 (tty_reset_terminal_modes, tty_turn_off_highlight):
12513 (get_tty_terminal): Now static.
12514 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12515 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12516 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12517 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12518 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12519
1fa53021
PE
12520 * sysdep.c: Make symbols static if they're not exported.
12521 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12522 Now static.
12523 (sigprocmask_set, full_mask): Remove; unused.
12524 (wait_debugging): Mark as visible.
12525 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12526 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12527
d4b43b22
PE
12528 * syntax.c (syntax_temp): Define only if !__GNUC__.
12529
b7c513d0
PE
12530 * sound.c (current_sound_device, current_sound): Now static.
12531
989b29ad
PE
12532 * search.c (searchbufs, searchbuf_head): Now static.
12533
13a55a78
PE
12534 * scroll.c (scroll_cost): Remove; unused.
12535 * dispextern.h (scroll_cost): Remove decl.
12536
de68a1fc
PE
12537 * region-cache.h (pp_cache): Mark as externally visible.
12538
40ccffa6
PE
12539 * process.c: Make symbols static if they're not exported.
12540 (process_tick, update_tick, create_process, chan_process):
12541 (Vprocess_alist, proc_buffered_char, datagram_access):
12542 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12543 (deactivate_process): Mark defn as static, as well as decl.
12544 * lisp.h (create_process): Remove decl.
12545 * process.h (chan_process, Vprocess_alist): Remove decls.
12546
ad64fc97
PE
12547 * print.c: Make symbols static if they're not exported.
12548 (print_depth, new_backquote_output, being_printed, print_buffer):
12549 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12550 (print_interval, print_number_index, initial_stderr_stream):
12551 Now static.
12552 * lisp.h (Fprinc): Remove decl.
12553 (debug_output_compilation_hack): Mark as externally visible.
12554
adddb265
PE
12555 * sysdep.c (croak): Move decl from here to syssignal.h.
12556 * syssignal.h (croak): Put it here, so the API can be checked when
12557 'croak' is called from dissociate_if_controlling_tty.
12558
1717ede2
PE
12559 * minibuf.c: Make symbols static if they're not exported.
12560 (minibuf_save_list, choose_minibuf_frame): Now static.
12561 * lisp.h (choose_minibuf_frame): Remove decl.
12562
fa5fb2bc
PE
12563 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12564
1e3890d1
PE
12565 * lread.c: Make symbols static if they're not exported.
12566 (read_objects, initial_obarray, oblookup_last_bucket_number):
12567 Now static.
12568 (make_symbol): Remove; unused.
12569 * lisp.h (initial_obarray, make_symbol): Remove decls.
12570
8a1414fa
PE
12571 * keyboard.c: Make symbols static if they're not exported.
12572 (single_kboard, recent_keys_index, total_keys, recent_keys):
12573 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12574 (this_single_command_key_start, echoing, last_auto_save):
12575 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12576 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12577 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12578 (Vlispy_mouse_stem, double_click_count):
12579 Now static.
12580 (force_auto_save_soon): Define only if SIGDANGER.
12581 (ignore_mouse_drag_p): Now static if
12582 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12583 (print_help): Remove; unused.
12584 (stop_character, last_timer_event): Mark as externally visible.
12585 * keyboard.h (ignore_mouse_drag_p): Declare only if
12586 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12587 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12588 * lisp.h (echoing): Remove decl.
12589 (force_auto_save_soon): Declare only if SIGDANGER.
12590 * xdisp.c (redisplay_window): Simplify code, to make it more
12591 obvious that ignore_mouse_drag_p is not accessed if !defined
12592 USE_GTK && !defined HAVE_NS.
12593
93ea6e8f
PE
12594 * intervals.c: Make symbols static if they're not exported.
12595 (merge_properties_sticky, merge_interval_right, delete_interval):
12596 Now static.
12597 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12598
77382fcc
PE
12599 * insdel.c: Make symbols static if they're not exported.
12600 However, leave prepare_to_modify_buffer alone. It's never
12601 called from outside this function, but that appears to be a bug.
12602 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12603 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12604 (adjust_after_replace_noundo): Remove; unused.
12605 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12606 (signal_before_change): Remove decls.
77382fcc 12607
9306c32e
PE
12608 * indent.c (val_compute_motion, val_vmotion): Now static.
12609
cd44d2eb
PE
12610 * image.c: Make symbols static if they're not exported.
12611 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12612 if USE_GTK.
12613 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12614 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12615
ad9a7a06
PE
12616 * fringe.c (standard_bitmaps): Now static.
12617 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12618
81626931
PE
12619 * frame.c: Make symbols static if they're not exported.
12620 (x_report_frame_params, make_terminal_frame): Now static.
12621 (get_frame_param): Now static, unless HAVE_NS.
12622 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12623 (x_get_resource_string): Remove; not used.
12624 * frame.h (make_terminal_frame, x_report_frame_params):
12625 (x_get_resource_string); Remove decls.
12626 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12627 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12628
239f9db9
PE
12629 * font.c, fontset.c: Make symbols static if they're not exported.
12630 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12631 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12632 * font.c (font_close_object): Now static.
12633 * font.h (font_close_object): Remove.
12634 * fontset.c (FONTSET_OBJLIST): Remove.
12635 (free_realized_fontset) #if-0 the body, which does nothing.
12636 (face_suitable_for_char_p): #if-0, as it's never called.
12637 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12638 * xfaces.c (face_at_string_position):
12639 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12640 since 0 is always ASCII.
12641
dfcf3579
PE
12642 * fns.c (weak_hash_tables): Now static.
12643
5045092b
PE
12644 * fileio.c: Make symbols static if they're not exported.
12645 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12646 (Vwrite_region_annotation_buffers): Now static.
12647
57a96f5c
PE
12648 * eval.c: Make symbols static if they're not exported.
12649 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12650 * lisp.h (backtrace_list): Remove decl.
12651
35f08c38
PE
12652 * emacs.c: Make symbols static if they're not exported.
12653 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12654 (fatal_error_code, fatal_error_signal_hook, standard_args):
12655 Now static.
12656 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12657 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12658 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12659 * lisp.h (fatal_error_signal_hook): Remove decl.
12660 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12661
f44bd759
PE
12662 * editfns.c: Move a (normally-unused) function to its only use.
12663 * editfns.c, lisp.h (get_operating_system_release): Remove.
12664 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12665 worth the hassle of breaking this out.
12666
b532497d
PE
12667 * xterm.c: Make symbols static if they're not exported.
12668 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12669 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12670 (x_destroy_window, x_delete_display):
12671 Now static.
12672 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12673 (x_mouse_leave): Remove; unused.
12674 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12675 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12676 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12677 Remove decls.
12678 (x_mouse_leave): Declare only if WINDOWSNT.
12679 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12680 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12681 USE_X_TOOLKIT.
12682
1675728f
PE
12683 * ftxfont.c: Make symbols static if they're not exported.
12684 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12685 HAVE_FREETYPE.
12686 * font.h (ftxfont_driver): Likewise.
12687
e4cebfca
PE
12688 * xfns.c: Make symbols static if they're not exported.
12689 (x_last_font_name, x_display_info_for_name):
12690 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12691 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12692 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12693 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12694 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12695 (last_show_tip_args): Now static.
12696 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12697 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12698 (x_screen_planes): Remove; unused.
12699 * dispextern.h (x_screen_planes): Remove decl.
12700
5bf46f05
PE
12701 * dispnew.c: Make symbols static if they're not exported.
12702 * dispextern.h (redraw_garbaged_frames, scrolling):
12703 (increment_row_positions): Remove.
12704 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12705 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12706 Now static.
12707 (redraw_garbaged_frames): Remove; unused.
12708
435f4c28
PE
12709 * xfaces.c: Make symbols static if they're not exported.
12710 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12711 Remove decls.
12712 * xterm.h (defined_color): Remove decls.
12713 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12714 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12715 (menu_face_changed_default, defined_color, free_realized_face):
12716 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12717 (ascii_face_of_lisp_face): Remove; unused.
12718
8524aef3
PE
12719 * xdisp.c: Make symbols static if they're not exported.
12720 * dispextern.h (scratch_glyph_row, window_box_edges):
12721 (glyph_to_pixel_coords, set_cursor_from_row):
12722 (get_next_display_element, set_iterator_to_next):
12723 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12724 (show_mouse_face): Remove decls
12725 * frame.h (message_buf_print): Likewise.
12726 * lisp.h (pop_message, set_message, check_point_in_composition):
12727 Likewise.
12728 * xterm.h (set_vertical_scroll_bar): Likewise.
12729 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12730 (message_buf_print, scratch_glyph_row, displayed_buffer):
12731 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12732 (get_next_display_element, show_mouse_face, window_box_edges):
12733 (frame_to_window_pixel_xy, check_point_in_composition):
12734 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12735 (glyph_to_pixel_coords): Remove; unused.
12736
16390cd2
PE
12737 * dired.c (file_name_completion): Now static.
12738
12739 * dbusbind.c (xd_in_read_queued_messages): Now static.
12740
a25f4dfa
PE
12741 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12742 * data.c (circular_list_error): Remove.
12743
14a9c8df
PE
12744 * commands.h (last_point_position, last_point_position_buffer):
12745 (last_point_position_window): Remove decls.
12746 * keyboard.c: Make these variables static.
12747
04f2d78b
CB
12748 * coding.h (coding, code_convert_region, encode_coding_gap):
12749 Remove decls.
74ab6df5
PE
12750 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12751 (iso_code_class, detect_coding, code_convert_region): Now static.
12752 (encode_coding_gap): Remove; unused.
12753
38dfbee1
PE
12754 * chartab.c (chartab_chars, chartab_bits): Now static.
12755
a2cb4e63
PE
12756 * charset.h (charset_iso_8859_1): Remove decl.
12757 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12758 Now static.
12759
127198fd
PE
12760 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12761 * ccl.c (Vccl_program_table): Now static.
12762 (check_ccl_update): Remove; unused.
12763
d85b608f
PE
12764 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12765 * category.h: ... from here.
12766 * category.c (check_category_table, set_category_set): Now static.
12767
31cd66f3
PE
12768 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12769 * lisp.h: Remove these decls.
12770
c358e587
PE
12771 * buffer.c (buffer_count): Remove unused var.
12772
e78aecca
PE
12773 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12774 so that it's not optimized away.
12775 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12776 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12777 exported only to the debugger.
12778
e192d7d3 12779 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12780 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12781
92470028
PE
12782 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12783 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12784 was inaccessible from Lisp.
12785 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12786 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12787
244ed907
PE
12788 alloc.c: Import and export fewer symbols, and remove unused items.
12789 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12790 is defined.
12791 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12792 it's not optimized away by whole-program optimization.
12793 (message_enable_multibyte, free_misc): Remove.
12794 (catchlist, handlerlist, mark_backtrace):
12795 Declare only if BYTE_MARK_STACK.
12796 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12797 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12798 (message_enable_multibyte): Remove decl.
12799 (free_misc, interval_free_list, float_block, float_block_index):
12800 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12801 (cons_free_list, last_marked_index):
12802 Now static.
12803 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12804 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12805 (mark_backtrace): Define only if BYTE_MARK_STACK.
12806 * xdisp.c (message_enable_multibyte): Now static.
12807
61c2b50e 12808 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12809 This makes it easier for human readers (and static analyzers)
12810 to see whether these variables are used from other modules.
12811 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12812 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12813 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12814 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12815 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12816 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12817 * xmenu.c, xselect.c:
12818 Declare Q* vars static if they are not used in other modules.
12819 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12820 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12821 Remove decls of unexported vars.
12822 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12823
95c82688
PE
12824 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12825
16a97296
PE
12826 Make Emacs functions such as Fatom 'static' by default.
12827 This makes it easier for human readers (and static analyzers)
12828 to see whether these functions can be called from other modules.
12829 DEFUN now defines a static function. To make the function external
12830 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12831 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12832 (Finit_image_library):
16a97296
PE
12833 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12834 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12835 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12836 Remove decls, since these functions are now static.
12837 (Funintern, Fget_internal_run_time): New decls, since these functions
12838 were already external.
95c82688 12839
16a97296
PE
12840 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12841 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12842 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12843 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12844 * keyboard.c, keymap.c, lread.c:
12845 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12846 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12847 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12848 Mark functions with DEFUE instead of DEFUN,
12849 if they are used in other modules.
12850 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12851 decls for now-static functions.
12852 * buffer.h (Fdelete_overlay): Remove decl.
12853 * callproc.c (Fgetenv_internal): Mark as internal.
12854 * composite.c (Fremove_list_of_text_properties): Remove decl.
12855 (Fcomposition_get_gstring): New forward static decl.
12856 * composite.h (Fcomposite_get_gstring): Remove decl.
12857 * dired.c (Ffile_attributes): New forward static decl.
12858 * doc.c (Fdocumntation_property): New forward static decl.
12859 * eval.c (Ffetch_bytecode): New forward static decl.
12860 (Funintern): Remove extern decl; now in .h file where it belongs.
12861 * fileio.c (Fmake_symbolic_link): New forward static decl.
12862 * image.c (Finit_image_library): New forward static decl.
12863 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12864 * intervals.h (Fprevious_property_change):
12865 (Fremove_list_of_text_properties): Remove decls.
12866 * keyboard.c (Fthis_command_keys): Remove decl.
12867 (Fcommand_execute): New forward static decl.
12868 * keymap.c (Flookup_key): New forward static decl.
12869 (Fcopy_keymap): Now static.
12870 * keymap.h (Flookup_key): Remove decl.
12871 * process.c (Fget_process): New forward static decl.
12872 (Fprocess_datagram_address): Mark as internal.
12873 * syntax.c (Fsyntax_table_p): New forward static decl.
12874 (skip_chars): Remove duplicate decl.
12875 * textprop.c (Fprevious_property_change): New forward static decl.
12876 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12877 Now internal.
12878 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12879 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12880
785bbd42
PE
12881 * editfns.c (Fformat): Remove unreachable code.
12882
8b913b57
AS
128832011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12884
12885 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12886 change. (Bug#8496)
12887
a6744a35
EZ
128882011-04-13 Eli Zaretskii <eliz@gnu.org>
12889
12890 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12891 when at ZV. (Bug#8487)
12892
e7974947
AS
128932011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12894
baad03f0
AS
12895 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12896 (Bug#8437)
12897 * keyboard.c (parse_tool_bar_item): Likewise.
12898 * sound.c (sound_cleanup, alsa_close): Likewise.
12899 * termcap.c (tgetent): Likewise.
12900 * xfns.c (x_default_font_parameter): Likewise.
12901 * xsettings.c (read_and_apply_settings): Likewise.
12902
e7974947
AS
12903 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12904 (overrun_check_free): Protoize.
12905
28272684
PE
129062011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12907
12908 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12909 since callers should never pass a negative size.
12910 Change the signature to match that of plain 'read' and 'write'; see
12911 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12912 * lisp.h: Update prototypes of emacs_write and emacs_read.
12913
11997c76
EZ
129142011-04-11 Eli Zaretskii <eliz@gnu.org>
12915
12916 * xdisp.c (redisplay_window): Don't try to determine the character
12917 position of the scroll margin if the window start point w->startp
e896f03c 12918 is outside the buffer's accessible region. (Bug#8468)
11997c76 12919
8a2cbd72
EZ
129202011-04-10 Eli Zaretskii <eliz@gnu.org>
12921
12922 Fix write-region and its subroutines for buffers > 2GB.
12923 * fileio.c (a_write, e_write): Modify declaration of arguments and
12924 local variables to support buffers larger than 2GB.
12925 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12926
12927 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12928 argument, local variables, and return value.
12929
12930 * lisp.h: Update prototypes of emacs_write and emacs_read.
12931
12932 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12933
4073e537 129342011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12935
1ebfdcb6
PE
12936 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12937
b2ded58d
PE
12938 Fix more problems found by GCC 4.6.0's static checks.
12939
7d66342c
PE
12940 * xdisp.c (vmessage): Use a better test for character truncation.
12941
bbf47d44
PE
12942 * charset.c (load_charset_map): <, not <=, for optimization,
12943 and to avoid potential problems with integer overflow.
9248994d 12944 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12945 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12946 * editfns.c (Fformat): Likewise.
1e69125e 12947 * syntax.c (skip_chars): Likewise.
3befa583 12948
e3019616
PE
12949 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12950 This also lets GCC 4.6.0 generate slightly better loop code.
12951
becfa255
PE
12952 * callint.c (Fcall_interactively): <, not <=, for optimization.
12953 (Fcall_interactively): Count the number of arguments produced,
12954 not the number of arguments given. This is simpler and lets GCC
12955 4.6.0 generate slightly better code.
12956
dae0cd48
PE
12957 * ftfont.c: Distingish more carefully between FcChar8 and char.
12958 The previous code passed unsigned char * to a functions like
12959 strlen and xstrcasecmp that expect char *, which does not
12960 conform to the C standard.
12961 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12962 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12963 char * when the C standard requires it.
12964
76032d70
PE
12965 * keyboard.c (read_char): Remove unused var.
12966
eb3f1cc8
PE
12967 * eval.c: Port to Windows vsnprintf (Bug#8435).
12968 Include <limits.h>.
12969 (SIZE_MAX): Define if the headers do not.
12970 (verror): Do not give up if vsnprintf returns a negative count.
12971 Instead, grow the buffer. This ports to Windows vsnprintf, which
12972 does not conform to C99. Problem reported by Eli Zaretskii.
12973 Also, simplify the allocation scheme, by avoiding the need for
12974 calling realloc, and removing the ALLOCATED variable.
12975
70476b54
PE
12976 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12977
12020a9e
PE
12978 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12979 But keep the doprint source code for now, as we might revamp it
12980 and use it again (Bug#8435).
ea6c7ae6
PE
12981 * lisp.h (doprnt): Remove.
12982 * Makefile.in (base_obj): Remove doprnt.o.
12983 * deps.mk (doprnt.o): Remove.
12984
5fdb398c
PE
12985 error: Print 32- and 64-bit integers portably (Bug#8435).
12986 Without this change, on typical 64-bit hosts error ("...%d...", N)
12987 was used to print both 32- and 64-bit integers N, which relied on
12988 undefined behavior.
61bdb816 12989 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12990 * lisp.h (error, verror): Mark as printf-like functions.
12991 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12992 Report overflow in size calculations when allocating printf buffer.
12993 Do not truncate output string at its first null byte.
12994 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12995 Truncate the output at a character boundary, since vsnprintf does not
12996 do that.
12997 * charset.c (check_iso_charset_parameter): Convert internal
12998 character to string before calling 'error', since %c now has the
12999 printf meaning.
13000 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13001 overflow when computing char to be passed to 'error'. Do not
13002 pass Lisp_Object to 'error'; pass the integer instead.
13003 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13004 formatted with plain %d.
13005
b189fa66
PE
13006 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13007
bff87ef0
PE
13008 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13009
7e2cac20
PE
13010 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13011
ce4d90b5
PE
13012 * xterm.c (x_catch_errors): Remove duplicate declaration.
13013
266c9547
PE
13014 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13015
79c49ad2
PE
13016 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13017
368f4090
JM
130182011-04-10 Jim Meyering <meyering@redhat.com>
13019
13020 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13021 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13022 return ssize_t not "int", and use size_t as the buffer length.
13023 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13024 * gnutls.h: Update declarations.
13025 * process.c (read_process_output): Use ssize_t, to match.
13026 (send_process): Likewise.
13027
a32d4040
CY
130282011-04-09 Chong Yidong <cyd@stupidchicken.com>
13029
13030 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13031
8546720e 130322011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13033
04f2d78b
CB
13034 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13035 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13036
8546720e
GM
13037 * xterm.c (handle_one_xevent):
13038 * xmenu.c (create_and_show_popup_menu):
13039 * xselect.c (x_decline_selection_request)
13040 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13041
0a2f5c1a 130422011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13043
13044 Fix some uses of `int' instead of EMACS_INT.
13045 * search.c (string_match_1, fast_string_match)
13046 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13047 (scan_buffer, find_next_newline_no_quit)
13048 (find_before_next_newline, search_command, Freplace_match)
13049 (Fmatch_data): Make some `int' variables be EMACS_INT.
13050
13051 * xdisp.c (display_count_lines): 3rd argument and return value now
13052 EMACS_INT. All callers changed.
13053 (pint2hrstr): Last argument is now EMACS_INT.
13054
13055 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13056 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13057 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13058 (decode_coding_utf_16, decode_coding_emacs_mule)
13059 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13060 (decode_coding_ccl, decode_coding_charset)
13061 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13062 (decode_coding_iso_2022, decode_coding_emacs_mule)
13063 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13064 <char_offset, last_offset>: Declare EMACS_INT.
13065 (encode_coding_utf_8, encode_coding_utf_16)
13066 (encode_coding_emacs_mule, encode_invocation_designation)
13067 (encode_designation_at_bol, encode_coding_iso_2022)
13068 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13069 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13070 Declare EMACS_INT.
13071 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13072 (encode_invocation_designation): Last argument P_NCHARS is now
13073 EMACS_INT.
13074 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13075 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13076
13077 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13078 All users changed.
13079
13080 * ccl.c (Fccl_execute_on_string): Declare some variables
13081 EMACS_INT.
13082
8546720e 130832011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13084
13085 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13086
4e19a977
CS
130872011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13088
13089 * process.c (Fformat_network_address): Doc fix.
13090
87302331
R
130912011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13092
ee7683eb 13093 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13094
cbb59342
CY
130952011-04-08 Chong Yidong <cyd@stupidchicken.com>
13096
13097 * keyboard.c (read_char): Call Lisp function help-form-show,
13098 instead of using internal_with_output_to_temp_buffer.
13099 (Qhelp_form_show): New var.
e0d38eeb 13100 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13101
13102 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13103
13104 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13105
e67a13ab
CY
131062011-04-06 Chong Yidong <cyd@stupidchicken.com>
13107
04f2d78b
CB
13108 * process.c (Flist_processes): Remove to Lisp.
13109 (list_processes_1): Delete.
e67a13ab 13110
973f782d
EZ
131112011-04-06 Eli Zaretskii <eliz@gnu.org>
13112
7c106b1e
EZ
13113 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13114
973f782d
EZ
13115 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13116
41cf7d1a 131172011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13118
ca23cc88
PE
13119 Fix more problems found by GCC 4.6.0's static checks.
13120
f390e2d5
PE
13121 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13122
42eea0d0
PE
13123 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13124
b69769da 13125 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13126
f9541e84
PE
13127 * xdisp.c (vmessage): Mark as a printf-like function.
13128
13841b55
PE
13129 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13130
c136c10f
PE
13131 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13132
5e2d4a30
PE
13133 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13134 printf-like functions.
13135 (tiff_load): Add casts to remove these marks before passing them
13136 to system-supplied API.
13137
583f48b9
PE
13138 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13139
b25d760e
PE
13140 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13141 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13142 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13143 directly, rather than having caller test rule sign. This avoids
13144 some unnecessary tests.
13145 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13146 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13147 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13148
bc7b6697 13149 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13150 (xfont_open): Avoid unnecessary tests.
bc7b6697 13151
27ccc379
PE
13152 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13153
dcd5c89a
PE
13154 * composite.h, composite.c (composition_gstring_put_cache):
13155 Use EMACS_INT, not int, for length.
13156
b13a45c6
PE
13157 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13158 breaking out part of COMPOSITION_DECODE_RULE.
13159 (COMPOSITION_DECODE_RULE): Use it.
13160 * composite.c (get_composition_id): Remove unused local vars,
13161 by using the new macro.
13162
1e792e4d
PE
13163 * textprop.c (set_text_properties_1): Change while to do-while,
13164 since the condition is always true at first.
13165
dc6c6455 13166 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13167 (interval_deletion_adjustment): Return unsigned value.
13168 All uses changed.
dc6c6455 13169
aba7731a
PE
13170 * process.c (list_processes_1, create_pty, read_process_output):
13171 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13172 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13173 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13174 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13175 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13176
fdfc4bf3
PE
13177 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13178
fca8fe46 13179 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13180 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13181
06a0259a 13182 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13183 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13184 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13185
e7b9e80f
PE
13186 * print.c (print_error_message): Avoid int overflow.
13187
56201685
PE
13188 * font.c (font_list_entities): Redo for clarity,
13189 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13190
78834453 13191 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13192 (font_score): Avoid potential overflow in diff calculation.
78834453 13193
0bc0b309 13194 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13195 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13196
e610eaca
PE
13197 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13198
b895abce
PE
13199 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13200 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13201 can always succeed if overflow has undefined behavior.
13202
1f1d9321 13203 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13204 (wordify): Omit three unnecessary tests.
1f1d9321 13205
c59478bc
PE
13206 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13207 All callers changed. This avoids the need for an unused var.
13208
79b73827
PE
13209 * casefiddle.c (casify_region): Remove var that is set but not used.
13210
a4db5dfe
PE
13211 * dired.c (file_name_completion): Remove var that is set but not used.
13212
43aae36e
PE
13213 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13214
2a47c44d 13215 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13216 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13217
a37c69bf
PE
13218 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13219 Check for integer overflow on size calculations.
13220
328ab8e7
PE
13221 * buffer.c (Fprevious_overlay_change): Remove var that is set
13222 but not used.
13223
e5a2a5cb
PE
13224 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13225 Remove vars that are set but not used.
8d84a6eb 13226 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13227 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13228
a60e5f68
PE
13229 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13230
f661cb61 13231 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13232 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13233
f0397f5a
PE
13234 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13235 that are set but not used.
13236
8664db06 13237 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13238 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13239
6abdaa4a
PE
13240 * xselect.c (x_get_local_selection, x_handle_property_notify):
13241 Remove vars that are set but not used.
13242
0ce7538d 13243 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13244 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13245
9ae848fc
PE
13246 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13247 Remove var that is set but not used.
0b918413
PE
13248 (scroll_bar_windows_size): Now size_t, not int.
13249 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13250 Check for overflow.
9ae848fc 13251
a5a62657
PE
13252 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13253 (map_tty_color) [!defined MSDOS]: Likewise.
13254
5c5cdd39
PE
13255 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13256
66ebf983
PE
13257 * coding.c: Remove vars that are set but not used.
13258 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13259 All callers changed.
13260 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13261 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13262 (decode_coding_charset): Remove vars that are set but not used.
13263
1be4d761
PE
13264 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13265 that is set but not used.
13266
47553fa8
PE
13267 * print.c (print_object): Remove var that is set but not used.
13268
1f7196bf 13269 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13270 The gnulib version avoids calling malloc in the usual case,
13271 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13272 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13273 * filelock.c (current_lock_owner): Likewise.
13274 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13275 * sysdep.c: Include allocator.h, careadlinkat.h.
13276 (emacs_no_realloc_allocator): New static constant.
13277 (emacs_readlink): New function.
fdb61804
PE
13278 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13279 ../lib/careadlinkat.h.
d1fdcab7 13280
f84c17c7
SM
132812011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13282
13283 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13284 first non-nil return value).
13285
ef3862ad
JD
132862011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13287
13288 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13289 if not defined (Bug#8403).
13290
376a7006
JB
132912011-04-02 Juanma Barranquero <lekktu@gmail.com>
13292
13293 * xdisp.c (display_count_lines): Remove parameter `start',
13294 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13295 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13296 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13297 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13298 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13299 and thereabouts. All callers changed.
13300 (get_per_char_metric): Remove parameter `f', unused since
13301 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13302
6ca3801d
JM
133032011-04-02 Jim Meyering <meyering@redhat.com>
13304
13305 do not dereference NULL upon failed strdup
13306 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13307 (ns_get_family): Likewise.
13308
d8e2b5ba
JB
133092011-04-02 Juanma Barranquero <lekktu@gmail.com>
13310
13311 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13312
8c74fcbd
JD
133132011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13314
13315 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13316 later (Bug#8403).
13317
7200d79c
SM
133182011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13319
03408648 13320 Add lexical binding.
7200d79c 13321
03408648
SM
13322 * window.c (Ftemp_output_buffer_show): New fun.
13323 (Fsave_window_excursion):
13324 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13325
13326 * lread.c (lisp_file_lexically_bound_p): New function.
13327 (Fload): Bind Qlexical_binding.
13328 (readevalloop): Remove `evalfun' arg.
13329 Bind Qinternal_interpreter_environment.
13330 (Feval_buffer): Bind Qlexical_binding.
13331 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13332 Mark as dynamic.
13333 (syms_of_lread): Declare `lexical-binding'.
13334
13335 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13336
13337 * keyboard.c (eval_dyn): New fun.
13338 (menu_item_eval_property): Use it.
ca105506
SM
13339
13340 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13341
03408648
SM
13342 * fns.c (concat, mapcar1): Accept byte-code-functions.
13343
13344 * eval.c (Fsetq): Handle lexical vars.
13345 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13346 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13347 (FletX, Flet): Obey lexical binding.
13348 (Fcommandp): Handle closures.
13349 (Feval): New `lexical' arg.
13350 (eval_sub): New function extracted from Feval. Use it almost
13351 everywhere where Feval was used. Look up vars in lexical env.
13352 Handle closures.
13353 (Ffunctionp): Move from subr.el.
13354 (Ffuncall): Handle closures.
13355 (apply_lambda): Remove `eval_flags'.
13356 (funcall_lambda): Handle closures and new byte-code-functions.
13357 (Fspecial_variable_p): New function.
13358 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13359 but without exporting it to Lisp.
23aba0ea 13360
23aba0ea 13361 * doc.c (Fdocumentation, store_function_docstring):
03408648 13362 * data.c (Finteractive_form): Handle closures.
23aba0ea 13363
03408648
SM
13364 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13365 interactive spec.
ba83908c 13366
04f2d78b
CB
13367 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13368 New byte-codes.
03408648
SM
13369 (exec_byte_code): New function extracted from Fbyte_code to handle new
13370 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13371
03408648 13372 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13373
03408648 13374 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13375
e2abce01
JB
133762011-03-31 Juanma Barranquero <lekktu@gmail.com>
13377
13378 * xdisp.c (redisplay_internal): Fix prototype.
13379
63696a73 133802011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13381
63696a73 13382 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13383 (try_scrolling): Use it when setting scroll_limit.
13384 Limit scrolling to 100 screen lines.
63696a73
EZ
13385 (redisplay_window): Even when falling back on "recentering",
13386 position point in the window according to scroll-conservatively,
13387 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13388
13389 (try_scrolling): When point is above the window, allow searching
13390 as far as scroll_max, or one screenful, to compute vertical
13391 distance from PT to the scroll margin position. This prevents
13392 try_scrolling from unnecessarily failing when
13393 scroll-conservatively is set to a value slightly larger than the
13394 window height. Clean up the case of PT below the margin at bottom
13395 of window: scroll_max can no longer be INT_MAX. When aggressive
13396 scrolling is in use, don't let point enter the opposite scroll
13397 margin as result of the scroll.
13398 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13399 threshold of 100 lines for never-recentering scrolling.
13400
e4cc2dfc
JB
134012011-03-31 Juanma Barranquero <lekktu@gmail.com>
13402
13403 * dispextern.h (move_it_by_lines):
13404 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13405 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13406 (message_log_check_duplicate): Remove parameters `prev_bol' and
13407 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13408 (redisplay_internal): Remove parameter `preserve_echo_area',
13409 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13410
13411 * indent.c (Fvertical_motion):
13412 * window.c (window_scroll_pixel_based, Frecenter):
13413 Don't pass `need_y_p' to `move_it_by_lines'.
13414
1c470562
SM
134152011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13416
44f230aa
SM
13417 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13418 steal a few bits to be more compact.
13419 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13420 Remove unneeded casts.
13421
1c470562
SM
13422 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13423
888adce9
ZK
134242011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13425
13426 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13427 binding" message (bug#7967).
13428
f838ed7b
PE
134292011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13430
77861b95
PE
13431 Fix more problems found by GCC 4.6.0's static checks.
13432
de6dbc14
PE
13433 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13434 Remove unused local var.
13435
f838ed7b
PE
13436 * editfns.c (Fmessage_box): Remove unused local var.
13437
792c7b2b
PE
13438 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13439 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13440 Omit unused local vars.
c499e557 13441 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13442 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13443 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13444 Omit unused local var.
13445
ba0165e1
PE
13446 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13447 Don't assume string length fits in int.
32ad8845 13448 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13449 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13450
3c59b4c9
PE
13451 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13452 instead of alloca (Bug#8344).
13453
a3eed478 13454 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13455 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13456
eb4d412d
PE
13457 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13458
1658b401
PE
13459 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13460 concerns.
13461
13462 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13463
13464 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13465
9a2c6e05
PE
13466 * keyboard.c (syms_of_keyboard): Use the same style as later
13467 in this function when indexing through an array. This also
13468 works around GCC bug 48267.
13469
03d0a109
PE
13470 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13471
44f730c8
PE
13472 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13473
fe75f926
PE
13474 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13475 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13476
ffa8c828
PE
13477 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13478 This avoids undefined behavior on integer overflow, and is a bit
13479 more convenient anyway since it is compared to a size_t variable.
13480
c5101a77
PE
13481 Variadic C functions now count arguments with size_t, not int.
13482 This avoids an unnecessary limitation on 64-bit machines, which
13483 caused (substring ...) to crash on large vectors (Bug#8344).
13484 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13485 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13486 All variadic functions and their callers changed accordingly.
c5101a77
PE
13487 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13488 * data.c (arith_driver, float_arith_driver): Likewise.
13489 * editfns.c (general_insert_function): Likewise.
13490 * eval.c (struct backtrace.nargs, interactive_p)
13491 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13492 (funcall_lambda, mark_backtrace): Likewise.
13493 * fns.c (concat): Likewise.
13494 * frame.c (x_set_frame_parameters): Likewise.
13495 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13496 0 if not found, not -1. All callers changed.
13497
dd3f25f7
PE
13498 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13499 (stack_copy_size): Now size_t, not int.
13500 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13501
461c2ab9
JB
135022011-03-28 Juanma Barranquero <lekktu@gmail.com>
13503
13504 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13505 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13506 All callers changed.
13507
13508 * lisp.h (multibyte_char_to_unibyte):
13509 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13510 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13511 * character.h (CHAR_TO_BYTE8):
13512 * cmds.c (internal_self_insert):
13513 * editfns.c (general_insert_function):
13514 * keymap.c (push_key_description):
13515 * search.c (Freplace_match):
13516 * xdisp.c (message_dolog, set_message_1): All callers changed.
13517
f6d62986
SM
135182011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13519
13520 * keyboard.c (safe_run_hook_funcall): New function.
13521 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13522 don't set the hook to nil, but remove the offending function instead.
13523 (Qcommand_hook_internal): Remove, unused.
13524 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13525 Vcommand_hook_internal.
13526
13527 * eval.c (enum run_hooks_condition): Remove.
13528 (funcall_nil, funcall_not): New functions.
13529 (run_hook_with_args): Call each function through a `funcall' argument.
13530 Remove `cond' argument, now redundant.
13531 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13532 (Frun_hook_with_args_until_failure): Adjust accordingly.
13533 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13534
1db5b1ad
JB
135352011-03-28 Juanma Barranquero <lekktu@gmail.com>
13536
13537 * dispextern.h (string_buffer_position): Remove declaration.
13538
13539 * print.c (strout): Remove parameter `multibyte', unused since
13540 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13541
13542 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13543 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13544 All callers changed.
13545
13546 * w32.c (_wsa_errlist): Use braces for struct initializers.
13547
13548 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13549 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13550 All callers changed.
13551 (string_buffer_position): Likewise. Also, make static (it's never
13552 used outside xdisp.c).
13553 (cursor_row_p): Remove parameter `w', unused since
13554 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13555 (decode_mode_spec): Remove parameter `precision', introduced during
13556 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13557 All callers changed.
13558
5ffb62aa
JD
135592011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13560
13561 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13562
461c2ab9 135632011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13564
13565 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13566 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13567 (ns_update_auto_hide_menu_bar): New functions.
13568 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13569 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13570 ns_constrain_all_frames.
13571 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13572 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13573
5c380ffb
JD
135742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13575
13576 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13577
9af30bdf
GM
135782011-03-27 Glenn Morris <rgm@gnu.org>
13579
13580 * syssignal.h: Replace RETSIGTYPE with void.
13581 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13582 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13583 Replace SIGTYPE with void everywhere.
13584 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13585 * s/template.h (SIGTYPE): Remove commented out definition.
13586
e2abce01
JB
135872011-03-26 Eli Zaretskii <eliz@gnu.org>
13588
13589 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13590 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13591
f868cd8a
JB
135922011-03-26 Juanma Barranquero <lekktu@gmail.com>
13593
59eb0929
JB
13594 * w32.c (read_unc_volume): Use parameter `henum', instead of
13595 global variable `wget_enum_handle'.
13596
13597 * keymap.c (describe_vector): Remove parameters `indices' and
13598 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13599 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13600
f868cd8a
JB
13601 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13602
13603 * keyboard.c (timer_check): Remove parameter `do_it_now',
13604 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13605 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13606 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13607
13608 * keyboard.c (read_char):
13609 * w32menu.c (w32_menu_display_help):
13610 * xmenu.c (show_help_event, menu_help_callback):
13611 Adjust calls to `show_help_echo'.
13612
13613 * gtkutil.c (xg_maybe_add_timer):
13614 * keyboard.c (readable_events):
13615 * process.c (wait_reading_process_output):
13616 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13617
13618 * insdel.c (adjust_markers_gap_motion):
13619 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13620 (gap_left, gap_right): Don't call it.
13621
2ecf6fdb
CY
136222011-03-25 Chong Yidong <cyd@stupidchicken.com>
13623
13624 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13625 incurred during fontification.
13626
6b1f9ba4
JB
136272011-03-25 Juanma Barranquero <lekktu@gmail.com>
13628
13629 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13630 (DEFVAR_PER_BUFFER): Don't pass it.
13631
13632 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13633 (scrolling_window): Don't pass it.
13634
0f4a96b5
JB
136352011-03-25 Juanma Barranquero <lekktu@gmail.com>
13636
13637 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13638
13639 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13640 and `suffix'.
13641 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13642 of variables specific to SELinux and computation of `encoded_absname'.
13643
13644 * image.c (XPutPixel): Remove unused variable `height'.
13645
13646 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13647
13648 * unexw32.c (get_section_info): Remove unused variable `section'.
13649
13650 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13651 (system_process_attributes): Remove unused variable `sess'.
13652 (sys_read): Remove unused variable `err'.
13653
13654 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13655 (w32_wnd_proc): Remove unused variable `isdead'.
13656 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13657 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13658 (x_create_tip_frame): Remove unused variable `tem'.
13659
13660 * w32inevt.c (w32_console_read_socket):
13661 Remove unused variable `no_events'.
13662
13663 * w32term.c (x_draw_composite_glyph_string_foreground):
13664 Remove unused variable `width'.
13665
1149507c
JB
136662011-03-24 Juanma Barranquero <lekktu@gmail.com>
13667
13668 * w32term.c (x_set_glyph_string_clipping):
13669 Don't pass uninitialized region to CombineRgn.
13670
9c88f339
JB
136712011-03-23 Juanma Barranquero <lekktu@gmail.com>
13672
13673 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13674 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13675 (Fx_close_connection): Remove unused variable `i'.
13676
13677 * w32font.c (w32font_draw): Return number of glyphs.
13678 (w32font_open_internal): Remove unused variable `i'.
13679 (w32font_driver): Add missing initializer.
13680
13681 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13682 (fill_in_menu): Remove unused variable `items_added'.
13683
13684 * w32term.c (last_mouse_press_frame): Remove static global variable.
13685 (w32_clip_to_row): Remove unused variable `f'.
13686 (x_delete_terminal): Remove unused variable `i'.
13687
13688 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13689 (NOTHING): Remove unused static global variable.
13690 (uniscribe_check_otf): Remove unused variable `table'.
13691 (uniscribe_font_driver): Add missing initializers.
13692
dee091a3
JD
136932011-03-23 Julien Danjou <julien@danjou.info>
13694
13695 * term.c (Fsuspend_tty, Fresume_tty):
13696 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13697 * window.c (temp_output_buffer_show):
13698 * insdel.c (signal_before_change):
13699 * frame.c (Fhandle_switch_frame):
13700 * fileio.c (Fdo_auto_save):
13701 * emacs.c (Fkill_emacs):
13702 * editfns.c (save_excursion_restore):
13703 * cmds.c (internal_self_insert):
13704 * callint.c (Fcall_interactively):
13705 * buffer.c (Fkill_all_local_variables):
13706 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13707 Use Frun_hooks.
0f4a96b5 13708 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13709 unconditionally since it does the check itself.
dee091a3 13710
2c520ab5 137112011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13712
c9c49752
PE
13713 Fix more problems found by GCC 4.5.2's static checks.
13714
8abc3f12
PE
13715 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13716 the first time through the loop, since we know p0 < p1 then.
13717 This also avoids a gcc -Wstrict-overflow warning.
13718
a2d26660
PE
13719 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13720 leading to a memory leak, possible in functions like
13721 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13722 of objects (Bug#8318).
a2d26660 13723
916c72e9
PE
13724 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13725 that could (at least in theory) be that large.
13726
19ab8a18
PE
13727 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13728 This is less likely to overflow, and avoids undefined behavior if
13729 overflow does occur. All callers changed. Use strtoul to scan
13730 for the unsigned long integer.
b7cbbd6f
PE
13731 (pint2hrstr): Simplify and tune code slightly.
13732 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13733
f0641eff
PE
13734 * scroll.c (do_scrolling): Work around GCC bug 48228.
13735 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13736
7f650bb9
PE
13737 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13738 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13739 (validate_x_resource_name): Simplify count usage.
13740 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13741
37dd57d1
PE
13742 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13743 fail (Bug#8306).
81e56e61 13744
699979fc 13745 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13746
401bf9b4
PE
13747 * process.c (Fmake_network_process): Use socklen_t, not int,
13748 where POSIX says socklen_t is required in portable programs.
13749 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13750 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13751 (Fmake_network_process, server_accept_connection):
13752 (wait_reading_process_output, read_process_output):
13753 Likewise.
13754
b93aacde
PE
13755 * process.c: Rename or move locals to avoid shadowing.
13756 (list_processes_1, Fmake_network_process):
13757 (read_process_output_error_handler, exec_sentinel_error_handler):
13758 Rename or move locals.
4dc343ee 13759 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13760 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13761 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13762 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13763 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13764
af8a867c 13765 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13766 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13767 Include tparam.h instead, since it declares them.
af8a867c
PE
13768 * cm.h (PC): Remove extern decl; tparam.h now does this.
13769 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13770 * terminfo.c: Include tparam.h, to check interfaces.
13771 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13772 (tparam): Adjust signature to match interface in tparam.h;
13773 this removes some undefined behavior. Check that outstring and len
13774 are zero, which they always are with Emacs.
13775 * tparam.h (PC, BC, UP): New extern decls.
13776
0248044d 13777 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13778 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13779
8ff096c1 13780 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13781 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13782 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13783 (ftfont_list): Remove unused local.
49eaafba
PE
13784 (get_adstyle_property, ftfont_pattern_entity):
13785 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13786 Rename locals to avoid shadowing.
8ff096c1 13787
e2be39f6
PE
13788 * xfont.c (xfont_list_family): Mark var as initialized.
13789
c9735e30
PE
13790 * xml.c (make_dom): Now static.
13791
8f5201ae
PE
13792 * composite.c (composition_compute_stop_pos): Rename local to
13793 avoid shadowing.
b246f932
PE
13794 (composition_reseat_it): Remove unused locals.
13795 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13796 (composition_update_it): Mark var as initialized.
11b61122
PE
13797 (find_automatic_composition): Mark vars as initialized,
13798 with a FIXME (Bug#8290).
8f5201ae 13799
760fbc2c
PE
13800 character.h: Rename locals to avoid shadowing.
13801 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13802 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13803 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13804 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13805 to avoid shadowing.
13806
ff08eb85
PE
13807 * textprop.c (property_change_between_p): Remove; unused.
13808
fc7bf025
PE
13809 * intervals.c (interval_start_pos): Now static.
13810
235d7abc
PE
13811 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13812
44f230aa
SM
13813 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13814 Rename locals to avoid shadowing.
3e7d6594 13815
50060332
PE
13816 * sound.c (wav_play, au_play, Fplay_sound_internal):
13817 Fix pointer signedness.
d01f234b 13818 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13819 (wav_play): Initialize a variable to 0, to prevent undefined
13820 behavior (Bug#8278).
50060332 13821
c4fc4e30
PE
13822 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13823
918436ed
PE
13824 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13825
c939f91b
PE
13826 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13827 clobbering (Bug#8298).
b9c7f648
PE
13828 * sysdep.c (sys_subshell): Likewise.
13829 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13830
6bd8c144
PE
13831 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13832 This should get cleaned up, so that child_setup has the
13833 same signature on all platforms.
13834
7710357c 13835 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13836 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13837
c59da222
CY
138382011-03-22 Chong Yidong <cyd@stupidchicken.com>
13839
13840 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13841 not to be necessary, and produces flickering.
13842
66b87493
GM
138432011-03-20 Glenn Morris <rgm@gnu.org>
13844
13845 * config.in: Remove file.
13846
45b6f6d5
JB
138472011-03-20 Juanma Barranquero <lekktu@gmail.com>
13848
13849 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13850 are now in src/globals.h.
13851 (syms_of_minibuf): Remove spurious & from previous change.
13852
cd394be1 138532011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13854
13855 * minibuf.c (completing-read-function): New variable.
13856 (completing-read-default): Rename from completing-read.
13857 (completing-read): Call completing-read-function.
13858
b14e3e21
CY
138592011-03-19 Juanma Barranquero <lekktu@gmail.com>
13860
13861 * xfaces.c (Fx_load_color_file):
13862 Read color file from absolute filename (bug#8250).
13863
f2b726e6
JB
138642011-03-19 Juanma Barranquero <lekktu@gmail.com>
13865
13866 * makefile.w32-in: Update dependencies.
13867
09f6ff02
EZ
138682011-03-17 Eli Zaretskii <eliz@gnu.org>
13869
13870 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13871
29a6015a
PE
138722011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13873
a3a6c54e
PE
13874 Fix more problems found by GCC 4.5.2's static checks.
13875
b766f867
PE
13876 * process.c (make_serial_process_unwind, send_process_trap):
13877 (sigchld_handler): Now static.
13878
be02381c
PE
13879 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13880 That way, the code declares only the vars that it needs.
13881 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13882 * s/cygwin.h (PTY_ITERATION): Likewise.
13883 * s/darwin.h (PTY_ITERATION): Likewise.
13884 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13885
57048744
PE
13886 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13887 * process.c (allocate_pty): Don't declare stb unless it's needed.
13888
7914961c 13889 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13890 (CONSTANTLIM): Remove; unused.
13891 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13892 Define only if needed.
7914961c 13893
b3967b18
PE
13894 * unexelf.c (unexec): Name an expression,
13895 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13896 Use a different way to cause a compilation error if anyone uses
13897 n rather than nn, a way that does not involve shadowing.
73366a00 13898 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13899
29a6015a
PE
13900 * deps.mk (unexalpha.o): Remove; unused.
13901
43cfc33e 13902 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13903 * unexec.h: New file.
ce701a33
PE
13904 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13905 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13906 Depend on unexec.h.
13907 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13908 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13909 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13910 Change as necessary to match prototype in unexec.h.
ce701a33 13911
01f44d5a
PE
13912 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13913 shadowing.
4f63c6bb 13914 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13915
a6670b0b
PE
13916 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13917 Rename locals to avoid shadowing.
13918
cef2010d 13919 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13920 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13921
d4d7173a
PE
13922 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13923
f08b802a
PE
13924 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13925 warning when compiling print.c.
13926
3ddb0639
PE
13927 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13928 instead of using an uninitialized var.
5ad03b97 13929 (font_sort_entities): Mark var as initialized.
3ddb0639 13930
170a2692
PE
13931 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13932
e663c700
PE
13933 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13934 pointers to constants.
89bc529a 13935 (font_parse_fcname): Remove unused vars.
7b81e2d0 13936 (font_delete_unmatched): Now static.
ea838e10 13937 (font_get_spec): Remove; unused.
13a547c6
PE
13938 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13939 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13940 Rename or move locals to avoid shadowing.
e663c700 13941
2a80c887 13942 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13943 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13944
1384fa33 13945 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13946 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13947
8b2c52e9
PE
13948 * alloc.c (mark_backtrace): Move decl from here ...
13949 * lisp.h: ... to here, so that it can be checked.
13950
475545b5 13951 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13952 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13953 (lisp_indirect_variable): Name an expression,
13954 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13955 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13956
b1349114 13957 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13958 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13959 Use const pointer when appropriate.
b1349114 13960
a2928364
PE
13961 * lisp.h (get_system_name, get_operating_system_release):
13962 Move decls here, to check interfaces.
13963 * process.c (get_operating_system_release): Move decl to lisp.h.
13964 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13965 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13966 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13967 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13968 (Fformat_time_string, Fencode_time, Finsert_char):
13969 (Ftranslate_region_internal, Fformat):
13970 Rename or remove local vars to avoid shadowing.
9710023e 13971 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13972
a415e694
PE
13973 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13974 avoid shadowing.
13975
8ef4622d
PE
13976 * lisp.h (eassert): Check that the argument compiles, even if
13977 ENABLE_CHECKING is not defined.
13978
946f9a5b
PE
13979 * data.c (Findirect_variable): Name an expression, to avoid
13980 gcc -Wbad-function-cast warning.
112396d6 13981 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13982 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13983 (Fmake_variable_buffer_local, Fmake_local_variable):
13984 Mark variables as initialized.
52746918 13985 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13986
e5aab7e7 13987 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13988 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13989 Rename locals to avoid shadowing.
dff45157
PE
13990 (mark_stack): Move local variables into the #ifdef region where
13991 they're used.
7bc26fdb
PE
13992 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13993 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13994 needed otherwise.
13995 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13996 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13997 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13998
e5aab7e7
PE
13999 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14000 avoids undefined behavior in theory.
14001
4da60324
PE
14002 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14003
88043301
PE
14004 Use functions, not macros, for up- and down-casing (Bug#8254).
14005 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14006 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14007 to use the following functions instead of these macros.
14008 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14009 EMACS_INT, since callers assume the returned value fits in int.
14010 (upcase1): Likewise, for UPCASE_TABLE.
14011 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14012 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14013 the race-condition problem in the old DOWNCASE.
88043301 14014
19ed5445
PE
14015 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14016 Rename locals to avoid shadowing.
14017 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14018 (regex_compile, re_search_2, re_match_2_internal):
14019 Remove unused local vars.
952db0d7
PE
14020 (FREE_VAR): Rewrite so as not to use empty "else",
14021 which gcc can warn about.
da053e48 14022 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14023 (RETALLOC_IF): Define only if needed.
14024 (WORDCHAR_P): Likewise. This one is never needed, but is used
14025 only in a comment talking about a compiler bug, so put inside
14026 the #if 0 of that comment.
14027 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14028 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14029 Remove; unused.
19ed5445 14030
1f3561e4 14031 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14032 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14033 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14034
ded6f8f7
PE
14035 * search.c (simple_search): Remove unused var.
14036
dbd37a95
PE
14037 * dired.c (compile_pattern): Move decl from here ...
14038 * lisp.h: ... to here, so that it can be checked.
14039 (struct re_registers): New forward decl.
14040
7e47afad
PE
14041 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14042
85f24f61
PE
14043 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14044 All uses changed.
14045 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14046 Rename locals to avoid shadowing.
5671df8f 14047 (Fvertical_motion): Mark locals as initialized.
85f24f61 14048
181aa2be 14049 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14050 (casify_region): Mark local as initialized.
181aa2be 14051
930d429c
PE
14052 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14053
7082eac6
PE
14054 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14055 New macros, so that the caller can use some names other than
14056 gcpro1, gcpro2, etc.
14057 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14058 of the new macros.
14059 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14060 argument, for consistency with GCPRO2_VAR, etc: it is now the
14061 prefix of the variable, not the variable itself. All uses
14062 changed.
38b2c076
PE
14063 * dired.c (directory_files_internal, file_name_completion):
14064 Rename locals to avoid shadowing.
14065
15206ed9
PE
14066 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14067 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14068 dired.c's scmp function, had undefined behavior.
14069 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14070 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14071 * buffer.h: ... to here, because these macros use current_buffer,
14072 and the new implementation with inline functions needs to have
14073 current_buffer in scope now, rather than later when the macros
14074 are used.
14075 (downcase, upcase1): New static inline functions.
14076 (DOWNCASE, UPCASE1): Reimplement using these functions.
14077 This avoids undefined behavior in expressions like
14078 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14079 from race conditions in accessing the global variables
14080 case_temp1 and case_temp2.
14081 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14082 * lisp.h (case_temp1, case_temp2): Remove their decls.
14083 * character.h (ASCII_CHAR_P): Move from here ...
14084 * lisp.h: ... to here, so that the inline functions mentioned
14085 above can use them.
14086
4a6bea26
PE
14087 * dired.c (directory_files_internal_unwind): Now static.
14088
f14b7e14
PE
14089 * fileio.c (file_name_as_directory, directory_file_name):
14090 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14091 Now static.
2893f146
PE
14092 (file_name_as_directory): Use const pointers when appropriate.
14093 (Fexpand_file_name): Likewise. In particular, newdir might
14094 point at constant storage, so make it a const pointer.
fd4ead52 14095 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14096 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14097 signedness issues.
f839df0c
PE
14098 (Fset_file_times, Finsert_file_contents, auto_save_error):
14099 Rename locals to avoid shadowing.
f14b7e14 14100
5716756e 14101 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14102 (Ftry_completion, Fall_completions): Rename or remove locals
14103 to avoid shadowing.
5716756e 14104
b4c3046a
PE
14105 * marker.c (bytepos_to_charpos): Remove; unused.
14106
b45db522
PE
14107 * lisp.h (verify_bytepos, count_markers): New decls,
14108 so that gcc does not warn that these functions aren't declared.
14109
85876d07
PE
14110 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14111 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14112 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14113 (copy_text): Remove unused local var.
85876d07 14114
03d78a21 14115 * filelock.c (within_one_second): Now static.
b3dd38ab 14116 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14117
5df8f01b
PE
14118 * buffer.c (fix_overlays_before): Mark locals as initialized.
14119 (fix_start_end_in_overlays): Likewise. This function should be
14120 simplified by using pointers-to-pointers, but that's a different
14121 matter.
b1d876f1 14122 (switch_to_buffer_1): Now static.
8f54f30a
PE
14123 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14124 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14125
a70072c9 14126 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14127 Fix pointer signedness issue.
edced198
PE
14128 (sys_subshell): Mark local as volatile if checking for lint,
14129 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14130 (MAXPATHLEN): Define only if needed.
a70072c9 14131
a0977c44
PE
14132 * process.c (serial_open, serial_configure): Move decls from here ...
14133 * systty.h: ... to here, so that they can be checked.
14134
a884fdcc
PE
14135 * fns.c (get_random, seed_random): Move extern decls from here ...
14136 * lisp.h: ... to here, so that they can be checked.
14137
604efe86 14138 * sysdep.c (reset_io): Now static.
b8950c94 14139 (wait_for_termination_signal): Remove; unused.
604efe86 14140
38fc62d9
PE
14141 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14142 (copy_keymap_item, append_key, push_text_char_description):
14143 Now static.
1004a21a 14144 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14145 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14146 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14147 (describe_map_tree):
14148 Rename locals to avoid shadowing.
38fc62d9 14149
2f2650da
PE
14150 * keyboard.c: Declare functions static if they are not used elsewhere.
14151 (echo_char, echo_dash, cmd_error, top_level_2):
14152 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14153 (read_char, kbd_buffer_get_event, make_lispy_position):
14154 (make_lispy_event, make_lispy_movement, apply_modifiers):
14155 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14156 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14157 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14158 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14159 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14160
a053e86c 14161 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14162 (mark_kboards): Move decl here ...
14163 * alloc.c (mark_kboards): ... from here.
a053e86c 14164
4752793e
PE
14165 * lisp.h (force_auto_save_soon): New decl.
14166
74f10ca7 14167 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14168 (DEFINE_DUMMY_FUNCTION): New macro.
14169 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14170 Use it.
c03cd23f
PE
14171 (main): Add casts to avoid warnings
14172 if GCC considers string literals to be constants.
74f10ca7 14173
022e70d4
PE
14174 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14175
59d6fe83
PE
14176 * dbusbind.c: Pointer signedness fixes.
14177 (xd_signature, xd_append_arg, xd_initialize):
14178 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14179 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14180 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14181 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14182
78320123
PE
14183 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14184 if GCC considers string literals to be constants.
49cebcca 14185 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14186
35ac2a97
SM
141872011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14188
fb103ca9
SM
14189 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14190 (print_preprocess, print_object): New macro to fix last change.
14191
35ac2a97
SM
14192 * print.c (print_preprocess): Don't forget font objects.
14193
62973b41
JB
141942011-03-16 Juanma Barranquero <lekktu@gmail.com>
14195
14196 * emacs.c (USAGE3): Doc fixes.
14197
0e48bb22
AS
141982011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14199
14200 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14201 structure.
14202
7684e57b
JB
142032011-03-14 Juanma Barranquero <lekktu@gmail.com>
14204
14205 * lisp.h (VWindow_system, Qfile_name_history):
14206 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14207 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14208 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14209
14210 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14211 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14212
14213 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14214 * w32console.c (detect_input_pending, read_input_pending)
14215 (encode_terminal_code):
14216 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14217 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14218 (w32_system_caret_y, Qfile_name_history):
14219 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14220 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14221 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14222 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14223 * w32proc.c (Qlocal, report_file_error):
14224 * w32term.c (Vwindow_system, updating_frame):
14225 * w32uniscribe.c (initialized, uniscribe_font_driver):
14226 Remove unneeded extern declarations.
14227
2aa46d6c
CY
142282011-03-14 Chong Yidong <cyd@stupidchicken.com>
14229
c96bbc66 14230 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14231
cffc6f3b
CY
142322011-03-13 Chong Yidong <cyd@stupidchicken.com>
14233
14234 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14235 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14236 These macros can no longer be used for assignment.
14237
44f230aa
SM
14238 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14239 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14240 (record_buffer_markers, fetch_buffer_markers): New functions for
14241 recording and fetching special buffer markers.
14242 (set_buffer_internal_1, set_buffer_temp): Use them.
14243
14244 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14245
14246 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14247
14248 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14249 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14250
14251 * xdisp.c (hscroll_window_tree):
14252 (reconsider_clip_changes): Use PT instead of BUF_PT.
14253
d251f04b
EZ
142542011-03-13 Eli Zaretskii <eliz@gnu.org>
14255
14256 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14257 $(EMACS_ROOT)/lib/intprops.h.
14258
f0c77cd1
PE
142592011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14260
3eca4629
PE
14261 Fix more problems found by GCC 4.5.2's static checks.
14262
7c86ee98
PE
14263 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14264 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14265 (xg_free_frame_widgets): Make it clear that a local variable is
14266 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14267 (gdk_window_get_screen): Make it clear that this macro is needed
14268 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14269 (int_gtk_range_get_value): New function, which avoids a diagnostic
14270 from gcc -Wbad-function-cast.
14271 (xg_set_toolkit_scroll_bar_thumb): Use it.
14272 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14273 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14274 (get_utf8_string, xg_get_file_with_chooser):
14275 Rename locals to avoid shadowing.
14276 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14277
41729b81
PE
14278 * xgselect.c (xg_select): Remove unused var.
14279
f0c77cd1
PE
14280 * image.c (four_corners_best): Mark locals as initialized.
14281 (gif_load): Initialize transparent_p to zero (Bug#8238).
14282 Mark another local as initialized.
ec6cf4c6 14283 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14284
ce0ad53d 14285 * image.c (clear_image_cache): Now static.
d5d5a617 14286 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14287 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14288 (x_edge_detection): Remove unnecessary cast that
14289 gcc -Wbad-function-cast diagnoses.
2037898d 14290 (gif_load): Fix pointer signedness.
6ae141d6
PE
14291 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14292 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14293
33383987 142942011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14295
d32df629
PE
14296 Improve quality of tests for time stamp overflow.
14297 For example, without this patch (encode-time 0 0 0 1 1
14298 1152921504606846976) returns the obviously-bogus value (-948597
14299 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14300 reports time overflow. See
14301 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14302 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14303 * editfns.c: Include limits.h and intprops.h.
14304 (TIME_T_MIN, TIME_T_MAX): New macros.
14305 (time_overflow): Move earlier, to before first use.
14306 (hi_time, lo_time): New functions, for an accurate test for
14307 out-of-range times.
14308 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14309 (Fget_internal_run_time): Don't assume time_t fits in int.
14310 (make_time): Use list2 instead of Fcons twice.
14311 (Fdecode_time): More accurate test for out-of-range times.
14312 (check_tm_member): New function.
14313 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14314 (lisp_time_argument): Don't rely on undefined left-shift and
14315 right-shift behavior when checking for time stamp overflow.
8be6f318 14316
fe31d94c
PE
14317 * editfns.c (time_overflow): New function, refactoring common code.
14318 (Fformat_time_string, Fdecode_time, Fencode_time):
14319 (Fcurrent_time_string): Use it.
14320
8be6f318
PE
14321 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14322 * dired.c (make_time): Move to ...
14323 * editfns.c (make_time): ... here.
14324 * systime.h: Note the move.
14325
09d9db2c 143262011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14327
126bc0dc
YM
14328 * fringe.c (update_window_fringes): Remove unused variables.
14329
c47cbdfd
YM
14330 * unexmacosx.c (copy_data_segment): Also copy __got section.
14331 (Bug#8223)
14332
7ac80be9
EZ
143332011-03-12 Eli Zaretskii <eliz@gnu.org>
14334
c96bbc66 14335 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14336 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14337 Constify `char *' arguments and their references according to
14338 prototypes in tparam.h.
14339
ecb0f94d 14340 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14341
7ac80be9
EZ
14342 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14343 Adapt all references accordingly.
14344
14345 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14346
ef1fd07e
TT
143472011-03-11 Tom Tromey <tromey@redhat.com>
14348
14349 * buffer.c (syms_of_buffer): Remove obsolete comment.
14350
7ef4b50c
EZ
143512011-03-11 Eli Zaretskii <eliz@gnu.org>
14352
14353 * termhooks.h (encode_terminal_code): Declare prototype.
14354
14355 * msdos.c (encode_terminal_code): Don't declare prototype.
14356
14357 * term.c (encode_terminal_code): Now external again, used by
14358 w32console.c and msdos.c.
14359
44f230aa
SM
14360 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14361 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14362
4b1ec863 143632011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14364
1714f52b 14365 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14366
4b1ec863
PE
14367 * fringe.c (update_window_fringes): Mark locals as initialized
14368 (Bug#8227).
14369 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14370
524c7aa6
PE
14371 * alloc.c (mark_fringe_data): Move decl from here ...
14372 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14373 to check its interface.
14374 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14375
a5c0af81 14376 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14377 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14378 (fontset_font): Mark local as initialized.
a9a06e0b 14379 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14380
b4716021
PE
14381 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14382
811e9bac 14383 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14384 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14385 (x_own_selection, Fx_disown_selection_internal): Rename locals
14386 to avoid shadowing.
14387 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14388
7e3ab302
PE
14389 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14390 so that the caller can use some name other than gcpro1.
14391 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14392 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14393 (Fx_backspace_delete_keys_p):
14394 Use them to avoid shadowing, and rename vars to avoid shadowing.
14395 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14396 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14397 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14398 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14399 Remove unused locals.
7e3ab302
PE
14400 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14401 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14402 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14403 macros.
f78faa98 14404
e2b13473
PE
14405 * xterm.h (x_mouse_leave): New decl.
14406
77f23912
PE
14407 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14408 Remove unused functions.
cdf4ba58
PE
14409 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14410 (x_calc_absolute_position): Now static.
7411c686 14411 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14412 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14413 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14414 unless they are used.
38d0b34a
PE
14415 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14416 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14417 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14418 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14419 (x_error_catcher, x_connection_closed, x_error_handler):
14420 (x_error_quitter, xembed_send_message, x_iconify_frame):
14421 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14422 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14423 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14424
44f230aa
SM
14425 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14426 Rename or move locals to avoid shadowing.
6b463e58 14427 (tty_defined_color, merge_face_heights): Now static.
5967d051 14428 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14429 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14430 does not deduce is never used uninitialized.
73719eba
PE
14431 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14432 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14433
426994c3 14434 * terminal.c (store_terminal_param): Now static.
5489860b 14435
032f1620 14436 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14437 (set_frame_menubar): Remove unused local.
d4323972 14438 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14439 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14440 since they might point to immutable storage.
281585b0
PE
14441 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14442 since it's unused otherwise.
032f1620 14443
367c19e5 14444 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14445 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14446 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14447 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14448 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14449 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14450 does not deduce are never used uninitialized.
70739cbe 14451
07b48fa9
PE
14452 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14453
8868a238 14454 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14455 * window.c (window_loop, size_window):
14456 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14457
7e5cf297 14458 * window.c (display_buffer): Now static.
d6550a9f
PE
14459 (size_window): Mark variables that gcc -Wuninitialized
14460 does not deduce are never used uninitialized.
a586633d
PE
14461 * window.h (check_all_windows): New decl, to forestall
14462 gcc -Wmissing-prototypes diagnostic.
5b555da1 14463 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14464
f6095868
PE
14465 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14466 shadowing.
14467 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14468 Include <limits.h>.
14469 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14470 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14471 (load_charset_map): Mark variables that gcc -Wuninitialized
14472 does not deduce are never used uninitialized.
53df7c11 14473 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14474
f38b440c
PE
14475 * coding.c (coding_set_source, coding_set_destination):
14476 Use "else { /* comment */ }" rather than "else /* comment */;"
14477 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14478 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14479 a block, when the outer 'i' will do.
14480 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14481 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14482 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14483 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14484 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14485 Rename locals to avoid shadowing.
14486 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14487 * coding.c (emacs_mule_char, encode_invocation_designation):
14488 Now static, since they're not used elsewhere.
413bb2db 14489 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14490 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14491 (decode_coding_emacs_mule): Mark variables that gcc
14492 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14493 (detect_coding_iso_2022): Initialize a local variable that might
14494 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14495 this initialization is needed. (Bug#8211)
5f58e762
PE
14496 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14497 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14498 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14499 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14500 Remove unused macros.
f38b440c 14501
232b38b9 14502 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14503 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14504 * character.c (string_count_byte8): Likewise.
232b38b9 14505
fb90da1b
PE
14506 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14507 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14508
fb93dbc2
PE
14509 * chartab.c (copy_sub_char_table): Now static, since it's not used
14510 elsewhere.
5c156ace
PE
14511 (sub_char_table_ref_and_range, char_table_ref_and_range):
14512 Rename locals to avoid shadowing.
bbcd0949 14513 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14514
7d3b3862 14515 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14516 (BIDI_BOB): Remove unused macro.
7d3b3862 14517
6be7d3da
PE
14518 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14519 deduce are never used uninitialized.
c2ed9c8b 14520 * term.c (encode_terminal_code): Likewise.
6be7d3da 14521
75f8807f 14522 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14523
50938595
PE
14524 * tparam.h: New file.
14525 * term.c, tparam.h: Include it.
14526 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14527 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14528 Move these decls to tparam.h, and make them agree with what
14529 is actually in tparam.c. The previous trick of using incompatible
14530 decls in different modules does not conform to the C standard.
14531 All callers of tparam changed to use tparam's actual API.
14532 * tparam.c (tparam1, tparam, tgoto):
14533 Use const pointers where appropriate.
14534
fbceeba2
PE
14535 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14536 * cm.h (struct cm): Likewise.
14537 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14538 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14539 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14540 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14541 (turn_on_face, init_tty): Likewise.
14542 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14543
7f3f1250
PE
14544 * term.c (term_mouse_position): Rename local to avoid shadowing.
14545
e6ca6543
PE
14546 * alloc.c (mark_ttys): Move decl from here ...
14547 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14548
c40f8d15
AS
145492011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14550
14551 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14552
cfe0661d
JB
145532011-03-09 Juanma Barranquero <lekktu@gmail.com>
14554
14555 * search.c (compile_pattern_1): Remove argument regp, unused since
14556 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14557 (compile_pattern): Don't pass it.
14558
0afb4571
J
145592011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14560
14561 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14562 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14563 for ! HAVE_GTK3.
14564 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14565
14566 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14567
14568 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14569 gdk_window_get_screen, gdk_window_get_geometry,
14570 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14571 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14572 (xg_get_pixbuf_from_pixmap): New function.
14573 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14574 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14575 Call xg_get_pixbuf_from_pixmap instead of
14576 gdk_pixbuf_get_from_drawable.
14577 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14578 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14579 (xg_check_special_colors): Use GtkStyleContext and its functions
14580 for HAVE_GTK3.
14581 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14582 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14583 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14584 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14585 Call gtk_widget_get_preferred_size.
0afb4571
J
14586 (xg_frame_resized): gdk_window_get_geometry only takes 5
14587 parameters.
44f230aa
SM
14588 (xg_win_to_widget, xg_event_is_for_menubar):
14589 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14590 (xg_set_widget_bg): New function.
14591 (delete_cb): New function.
895009e1 14592 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14593 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14594 (xg_set_background_color): Call xg_set_widget_bg.
14595 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14596 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14597 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14598 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14599 if ! HAVE_GTK3.
14600 (update_frame_tool_bar): Call gtk_widget_hide.
14601 (xg_initialize): Use GDK_KEY_g.
14602
14603 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14604 if ! HAVE_GTK3
14605 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14606
14607 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14608 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14609 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14610
1c2cc4ef
JB
146112011-03-08 Juanma Barranquero <lekktu@gmail.com>
14612
14613 * w32xfns.c (select_palette): Check success of RealizePalette against
14614 GDI_ERROR, not zero.
14615
33383987 14616See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14617
14618;; Local Variables:
14619;; coding: utf-8
aac0c6e3
MR
14620;; End:
14621
2f097256 14622 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14623
14624 This file is part of GNU Emacs.
14625
14626 GNU Emacs is free software: you can redistribute it and/or modify
14627 it under the terms of the GNU General Public License as published by
14628 the Free Software Foundation, either version 3 of the License, or
14629 (at your option) any later version.
14630
14631 GNU Emacs is distributed in the hope that it will be useful,
14632 but WITHOUT ANY WARRANTY; without even the implied warranty of
14633 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14634 GNU General Public License for more details.
14635
14636 You should have received a copy of the GNU General Public License
14637 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.