* lisp/emacs-lisp/eieio.el: Adapt further to gv.el.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3ab6e069
DA
12012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Return more descriptive data from Fgarbage_collect.
4 Suggested by Stefan Monnier in
5 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
6 * alloc.c (bounded_number): New function.
7 (total_buffers, total_vectors): New variable.
8 (total_string_size): Rename to total_string_bytes, adjust users.
9 (total_vector_size): Rename to total_vector_bytes, adjust users.
10 (sweep_vectors): Account total_vectors and total_vector_bytes.
11 (Fgarbage_collect): New return value. Adjust documentation.
12 (gc_sweep): Account total_buffers.
13 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
14 (VECTOR_SIZE): Remove.
15 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
16 (Qinterval, Qmisc): New symbols.
17 (syms_of_data): Initialize them.
18 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
19 (Qcons, Qbuffer): New declarations.
20
6d02fe5b
PE
212012-07-17 Paul Eggert <eggert@cs.ucla.edu>
22
23 * alloc.c (Fmemory_free): Account for memory-free's own storage.
24 Round up, not down. Improve doc.
25
b7ffe040
DA
262012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
27
28 Restore old code in allocate_string_data to avoid Faset breakage.
29 Reported by Julien Danjou <julien@danjou.info> in
30 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
31 * alloc.c (allocate_string_data): Restore old code with minor
32 adjustments, fix comment to explain this subtle issue.
33
4dc7c8d5
SM
342012-07-17 Eli Zaretskii <eliz@gnu.org>
35
36 Remove FILE_SYSTEM_CASE.
37 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
38
39 * fileio.c (FILE_SYSTEM_CASE): Don't define.
40 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
41 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
42 call-process-region passes it through expand-file-name.
43
44 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
45
462012-07-17 Andreas Schwab <schwab@linux-m68k.org>
47
48 Fix crash when creating indirect buffer (Bug#11917)
49 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
50 Don't handle unbound variables specially if non-zero.
51 (Fbuffer_local_variables): Pass zero.
52 (clone_per_buffer_values): Pass non-zero.
53
542012-07-17 Andreas Schwab <schwab@linux-m68k.org>
55
56 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
57 to make the loop interruptible.
58
592012-07-17 Andreas Schwab <schwab@linux-m68k.org>
60
61 * gnutls.c (emacs_gnutls_handshake): Only retry if
62 GNUTLS_E_INTERRUPTED.
63
642012-07-17 Eli Zaretskii <eliz@gnu.org>
cce7fefc
DA
652012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
66
67 Cleanup and convert miscellaneous checks to eassert.
68 * alloc.c (mark_interval): Fix comment, partially rephrase
69 old comment from intervals.h (see below).
70 * intervals.c (find_interval, adjust_intervals_for_insertion)
71 (delete_interval, adjust_intervals_for_deletion)
72 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
73 Convert to eassert.
74 (adjust_intervals_for_insertion, make_new_interval):
75 Remove obsolete and unused code.
76 * intervals.h (struct interval): Remove obsolete comment.
77 * textprotp.c (erase_properties): Remove unused code.
78 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
79 (Fremove_list_of_text_properties): Convert to eassert.
80
9ea10cc3
CY
812012-07-17 Chong Yidong <cyd@gnu.org>
82
83 * editfns.c (Finsert_char): Doc fix.
84
3900d5de
DA
852012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
86
87 Fix previous change to make Fmemory_free always accurate.
88 * alloc.c (make_interval): Update total_free_intervals.
89 (make_float): Likewise for total_free_floats.
90 (free_cons, Fcons): Likewise for total_free_conses.
91 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
92 Likewise for total_free_vector_bytes.
93 (Fmake_symbol): Likewise for total_free_symbols.
94 (bytes_free): Remove.
95
7098646f
DA
962012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
97
98 Simple free memory accounting feature.
99 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
100 (sweep_vectors): Accumulate size of free vectors.
101 (Fgarbage_collect): Setup bytes_free.
102 (Fmemory_free): New function.
103 (syms_of_alloc): Register it.
104
22657b40
DA
1052012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
106
107 Cleanup overlays checking.
108 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
109 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
110 eassert and OVERLAYP.
111 (sort_overlays): Change to use OVERLAYP.
112
ddfc8813
RK
1132012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
114
115 * editfns.c (Finsert_char): Make it interactive, and make the
116 second arg optional. Copy interactive spec and docstring from
117 ucs-insert.
118
7c26cf3c
PE
1192012-07-17 Paul Eggert <eggert@cs.ucla.edu>
120
121 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
122 Unlike the other wrapped functions, fabs has an unspecified
123 effect on errno.
124
5d127af9
JD
1252012-07-16 Jan Djärv <jan.h.d@swipnet.se>
126
127 * nsterm.m (keyDown): Interpret flags without left/right bits
128 as the left key (Bug#11670).
129
6a0dd1d7
DA
1302012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
131
132 Remove empty and useless init functions.
133 * lisp.h (init_character_once, init_fns, init_image)
134 (init_filelock, init_sound): Remove prototype.
135 * character.c (init_character_once): Remove.
136 * filelock.c (init_filelock): Likewise.
137 * fns.c (init_fns): Likewise.
138 * image.c (init_image): Likewise.
139 * sound.c (init_sound): Likewise.
140 * emacs.c (main): Adjust accordingly.
141
7a6136fd
DA
1422012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
143
144 * gtkutil.h: Tiny cleanups.
145 (use_old_gtk_file_dialog): Remove useless declaration.
146 (xg_uses_old_file_dialog): Add suggested const attribute.
147
ce811ad9
EZ
1482012-07-15 Eli Zaretskii <eliz@gnu.org>
149
150 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
151 (bidi_paragraph_init): Use it to limit search forward for a strong
152 directional character in abnormally large paragraphs full of
153 neutral or weak characters. (Bug#11943)
154
c9adfeaa
SF
1552012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
156
157 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
158 the toolbar (Bug#9451).
159 (xg_make_tool_item): Give the widget event box a transparent
160 background.
161
fff62aa9
DA
1622012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
163
164 Cleanup basic allocation variables and functions.
165 * alloc.c (ignore_warnings, init_intervals, init_float)
166 (init_cons, init_symbol, init_marker): Remove.
167 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
168 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
169 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
170 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
171 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
172 (staticidx, init_alloc_once, init_strings, free_ablock):
173 Remove redundant initialization.
174 * fns.c (init_weak_hash_tables): Remove.
175 * lisp.h (init_weak_hash_tables): Remove prototype.
176
9730daca
DA
1772012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
178
179 Use zero_vector where appropriate.
180 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
181 accordingly.
182 * lisp.h (zero_vector): New declaration.
183 * font.c (null_vector): Remove.
184 (syms_of_font): Remove initialization and staticpro.
185 (font_list_entities, font_find_for_lface): Change to use zero_vector.
186 * keymap.c (Faccessible_keymaps): Likewise.
187
2e2d2a13
LL
1882012-07-15 Leo Liu <sdl.web@gmail.com>
189
190 * fringe.c: Fix typo in comments.
191
cd276f6e
LL
1922012-07-14 Leo Liu <sdl.web@gmail.com>
193
194 * fringe.c: Add a new bitmap exclamation-mark.
195
5a1131d9
EZ
1962012-07-14 Eli Zaretskii <eliz@gnu.org>
197
198 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
199
200 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
201 (HAVE_MENUS): Don't define, defined by editing config.in with
202 msdos/sed2v2.inp.
203 (GMALLOC_INHIBIT_VALLOC): Don't define.
204 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
205
22e983b7
JB
2062012-07-14 Juanma Barranquero <lekktu@gmail.com>
207
208 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
209
5b3f250f
GM
2102012-07-14 Glenn Morris <rgm@gnu.org>
211
212 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
213 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
214 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
215
33d63ff4
GM
2162012-07-13 Glenn Morris <rgm@gnu.org>
217
5b633342
GM
218 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
219
33d63ff4
GM
220 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
221 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
222
b55b9f85
JD
2232012-07-13 Jan Djärv <jan.h.d@swipnet.se>
224
0dc8cf50
JD
225 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
226 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
227 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
228 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
229 where appropriate.
230 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
231 as boolean expression.
232 (x_set_window_size): Remove unused variable toolbar.
233 (ns_get_color_default, ns_mod_to_lisp): Remove.
234 (ns_mouse_position): Remove unused variables xchar and ychar.
235 (ns_compute_glyph_string_overhangs): Remove unused variable face.
236 (ns_set_vertical_scroll_bar): Remove unused variable count.
237 (ns_delete_terminal): Remove unused variable i.
238 (ns_term_init): Remove unused variables r, g and b.
239 (mouseDown): Remove unused variable window.
240 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
241 (initFrameFromEmacs): Remove unused variable vbextra.
242 (mouseEntered): Remove unused variables p and dpyinfo.
243 (mouseExited): Remove unused variables p and r.
244 (ns_define_frame_cursor, ns_clear_frame_area)
245 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
246 (menuDown): Assign [sender tag] to variable and cast the variable.
247
248 * nsterm.h (menuDown): Add id as type to argument sender.
249 (ns_display_info_for_name): Add Lisp_Object argument.
250 (ns_term_init): Add Lisp_Object argument.
251 (ns_map_event_to_object): Add void argument.
252 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
253 prototype with arguments and only declare if __OBJC__.
254 (nxatoms_of_nsselect): Add void argument.
255 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
256 (ns_alloc_autorelease_pool): Add void argument.
257 (ns_release_autorelease_pool): Add void* argument.
258 (ns_get_defaults_value): Add const char* argument.
259
260 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
261 (initFromContents): Use SSDATA where appropriate.
262 (ns_update_menubar): Add braces to ambigous if-else.
263 (initWithTitle): Put () around assignment in if statement.
264 (ns_menu_show): Remove unused variables window and keymap.
265 (update_frame_tool_bar): Remove unused variable selected_p.
266 (initWithContentRect): Remove unused variable this_cmd_name.
267
268 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
269 appropriate.
270 (setXBMColor): Remove unused variable len.
271 (setPixmapData): Put () around assignment in loop statement.
272
273 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
274 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
275 where appropriate.
276 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
277 around assignment in loop statement.
278 (nsfont_open): Remove unused variable i.
279 (nsfont_open): Remove unused variable len.
280 (nsfont_draw): Remove unused variable cs.
281
282 * nsfns.m (x_set_icon_name, ns_set_name_internal)
283 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
284 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
285 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
286 (Fns_font_name, Fns_perform_service)
287 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
288 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
289 (ns_set_name): Remove unused variable view.
290 (x_set_menu_bar_lines): Remove unused variable olines.
291 (x_set_tool_bar_lines): Remove unused variable root_window.
292 (Fns_list_colors): Put () around assignment in while statement.
293 (Fns_perform_service): Remove unused variable len.
294 (Fns_display_usable_bounds): Remove unused variable top.
295 (syms_of_nsfns): Remove unused variable i.
296
b55b9f85
JD
297 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
298 memcpy (Bug#11907).
299
ed9265fc 3002012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
301
302 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
303 and free it with DestroyExceptionInfo (Bug#11558).
304
ef099b57
JB
3052012-07-13 Juanma Barranquero <lekktu@gmail.com>
306
307 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
308 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
309 Set here, not in nt/config.nt.
310
ea814a5d
EZ
3112012-07-13 Eli Zaretskii <eliz@gnu.org>
312
313 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
314 cursor overflow into the last glyph on display line when the right
315 fringe is off. (Bug#11832)
316
1a952767
PE
3172012-07-13 Paul Eggert <eggert@cs.ucla.edu>
318
319 * xdisp.c (produce_special_glyphs): Now static.
320 * dispextern.h (produce_special_glyphs): Remove decl.
321
983188fd
GM
3222012-07-13 Glenn Morris <rgm@gnu.org>
323
32fb4bb6
GM
324 * s/bsd-common, s/cygwin.h: Remove empty files.
325 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
326
983188fd
GM
327 * s/usg5-4-common.h (USG, USG5):
328 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
329 * s/sol2-6.h (SOLARIS2):
330 * s/irix6-5.h (IRIX6_5):
331 * s/hpux10-20.h (USG, USG5, HPUX):
332 * s/gnu-linux.h (USG, GNU_LINUX):
333 * s/freebsd.h (BSD_SYSTEM):
334 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
335 * s/cygwin.h (CYGWIN):
336 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
337 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
338
d1e68667 3392012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
340
341 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 342
6de0e799
GM
3432012-07-13 Glenn Morris <rgm@gnu.org>
344
739ae010
GM
345 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
346
dbee5793
GM
347 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
348
6de0e799
GM
349 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
350 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
351
b82da769
GM
3522012-07-12 Glenn Morris <rgm@gnu.org>
353
4fae5a7a 354 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
355
356 * process.c (init_process_emacs): Rename from init_process.
357 The old name is also the name of a Mach system call.
358 * lisp.h, emacs.c: Update for this name change.
359 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
360 longer needed.
361
5a979817
EZ
3622012-07-12 Eli Zaretskii <eliz@gnu.org>
363
364 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
365 memmove call that removes glyphs covered by the left truncation
366 glyph. Improve commentary.
367 (display_line): Fix display of continuation glyphs on GUI frames
368 when the right fringe is turned off and variable-size fonts are
369 used in the window. Move the code that appends a stretch glyph to
370 produce_special_glyphs, so that it could be used for truncation
371 and continuation glyphs alike.
372 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
373 glyph of a suitably computed width, to align the special glyphs at
374 the window margin. Code moved from display_line. (Bug#11832)
375
3e91a053
GM
3762012-07-12 Glenn Morris <rgm@gnu.org>
377
ba9e4b84
GM
378 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
379
380 * s/gnu-linux.h, s/hpux10-20.h:
381 Do not unconditionally define HAVE_XRMSETDATABASE.
382
3e91a053
GM
383 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
384
b300b1f4
PE
3852012-07-12 Paul Eggert <eggert@cs.ucla.edu>
386
387 Fix typos that broke OS X build.
388 Reported by Randal L. Schwartz in
389 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
390 * nsterm.m (ns_timeout): Add missing local decl.
391 (ns_get_color): snprintf -> sprintf, to fix typo.
392
6e777848
GM
3932012-07-12 Glenn Morris <rgm@gnu.org>
394
3f922c37
GM
395 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
396 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
397 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
398 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
399
0ab7b23a
GM
400 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
401 Move PTY_OPEN to configure.
402
6e777848
GM
403 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
404 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
405 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
406
4a7edc24
DA
4072012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
408
409 Use empty_unibyte_string where applicable.
410 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
411 * lread.c (read1): Likewise.
412 * xsettings.c (syms_of_xsettings): Likewise.
413
308aab79
GM
4142012-07-12 Glenn Morris <rgm@gnu.org>
415
42bd1719
GM
416 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
417 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
418 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
419 * s/hpux10-20.h (RUN_TIME_REMAP):
420 * s/bsd-common.h (TABDLY): Move to configure.
421
422 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
423
424 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
425
ea0bbd17 426 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 427 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
428
429 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 430
308aab79
GM
431 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
432 * s/template.h: Move NARROWPROTO to configure.
433
ee1cf5cf
GM
4342012-07-11 Glenn Morris <rgm@gnu.org>
435
30fe9bf4
GM
436 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
437 unused since 2011-01-17 change to systty.h.
438
ee1cf5cf
GM
439 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
440 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
441 Move HAVE_PTYS and HAVE_SOCKETS to configure.
442
63e47e07
PE
4432012-07-11 Paul Eggert <eggert@cs.ucla.edu>
444
445 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
446
c43fb4c3
GM
4472012-07-11 Glenn Morris <rgm@gnu.org>
448
449 * s/darwin.h, s/gnu-linux.h, s/template.h:
450 Move INTERRUPT_INPUT to configure.
451
e8df9267
DA
4522012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
453
454 Minor adjustments to interning code.
455 * lisp.h (intern, intern_c_string): Redefine as static inline
456 wrappers for intern_1 and intern_c_string_1, respectively.
457 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
458 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
459 Vobarray checking.
e8df9267
DA
460 * font.c (font_intern_prop): Likewise. Adjust comment.
461 * w32font.c (intern_font_name): Likewise.
462
34348bd4
AS
4632012-07-11 Andreas Schwab <schwab@linux-m68k.org>
464
d96a1e0c
AS
465 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
466
34348bd4
AS
467 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
468 of Fcar/Fcdr if possible.
469 * font.c (check_otf_features): Likewise.
470 * fontset.c (Fnew_fontset): Likewise.
471 * gnutls.c (Fgnutls_boot): Likewise.
472 * minibuf.c (read_minibuf): Likewise.
473 * msdos.c (IT_set_frame_parameters): Likewise.
474 * xmenu.c (Fx_popup_dialog): Likewise.
475 * w32menu.c (Fx_popup_dialog): Likewise.
476
c8add24e
GM
4772012-07-11 Glenn Morris <rgm@gnu.org>
478
4b575b3c
GM
479 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
480 since nothing has defined it on these platforms.
481
09f4e3b0
GM
482 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
483 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
484
172bedef
GM
485 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
486 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
487 Move CLASH_DETECTION to configure.
488
249685df
GM
489 * s/gnu.h: Remove file, which is now empty.
490
c8add24e
GM
491 * s/gnu.h, s/gnu-linux.h:
492 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
493
b41253a3
JW
4942012-07-11 John Wiegley <johnw@newartisans.com>
495
496 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
497 function attribute, so we only use it if it exists in the
498 compiler.
499
d923b542
DA
5002012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
501
502 Avoid call to strlen in fast_c_string_match_ignore_case.
503 * search.c (fast_c_string_match_ignore_case): Change to use
504 length argument. Adjust users accordingly.
505 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
506
5ebbef1d
PE
5072012-07-11 Paul Eggert <eggert@cs.ucla.edu>
508
bb352260
PE
509 Assume mkdir, rmdir.
510 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
511 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
512
57054ddd
PE
513 Assume rename.
514 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
515
b747d3f7
PE
516 Assume perror.
517 * s/hpux10-20.h (HAVE_PERROR): Remove.
518 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
519 Remove dummy definition, as this problem was obsolete long ago.
520
5ebbef1d
PE
521 Assume strerror.
522 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
523
984e7f30
DA
5242012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
525
526 Avoid calls to strlen in font processing functions.
527 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 528 (font_open_by_name): Change to use length argument. Adjust
984e7f30 529 users accordingly.
d923b542
DA
530 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
531 Adjust prototypes.
532 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
533 Change to return ptrdiff_t.
984e7f30
DA
534 (xfont_list_pattern, xfont_match): Use length returned by
535 xfont_decode_coding_xlfd.
536 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
537
20e94fdd
GM
5382012-07-11 Glenn Morris <rgm@gnu.org>
539
9d596af3
GM
540 * s/darwin.h, s/freebsd.h, s/netbsd.h:
541 Move DONT_REOPEN_PTY to configure.
542
20e94fdd
GM
543 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
544 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
545
e99a530f
PE
5462012-07-10 Paul Eggert <eggert@cs.ucla.edu>
547
22ffb973
PE
548 Remove "#define unix" that is no longer needed (Bug#11905).
549 * s/aix4-2.h (unix): Remove; no longer needed.
550
e9a9ae03
PE
551 EMACS_TIME simplification (Bug#11875).
552 This replaces macros (which typically do not work in GDB)
553 with functions, typedefs and enums, making the code easier to debug.
554 The functional style also makes code easier to read and maintain.
555 * systime.h: Include <sys/time.h> on all hosts, not just if
556 WINDOWSNT, since 'struct timeval' is needed in general.
557 (EMACS_TIME): Now a typedef, not a macro.
558 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
559 not macros.
560 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
561 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
562 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
563 (EMACS_TIME_LE): Now functions, not macros.
564 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
565 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
566 which are not functions. All uses rewritten to use:
567 (make_emacs_time): New function.
568 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
569 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
570 not functions. All uses rewritten to use the following, respectively:
571 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
572 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 573 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
574 * fileio.c (Fcopy_file):
575 * xterm.c (XTflash): Get the current time closer to when it's used.
576 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
577
ffacb126
PE
578 * bytecode.c (targets): Suppress -Woverride-init warnings.
579
e99a530f
PE
580 Simplify by avoiding confusing use of strncpy etc.
581 * doc.c (Fsnarf_documentation):
582 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
583 * frame.c (Fmake_terminal_frame):
584 * gtkutil.c (get_utf8_string):
585 * lread.c (openp):
586 * nsmenu.m (ns_update_menubar):
587 * regex.c (regerror):
588 Prefer memcpy to strncpy and strncat when either will do.
589 * fileio.c (Fsubstitute_in_file_name):
590 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
591 (menu_separator_name_p):
592 * nsmenu.m (ns_update_menubar):
593 Prefer memcmp to strncmp when either will do.
594 * nsterm.m: Include <ftoastr.h>.
595 (ns_get_color):
596 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
597 Prefer snprintf to strncpy.
598 * nsterm.m (ns_term_init):
599 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
600 * nsterm.m (ns_term_init):
601 Avoid the need for strncpy, by using build_string or
602 make_unibyte_string directly. Use dtoastr, not snprintf.
603 * process.c (Fmake_network_process): Diagnose service names that
604 are too long, rather than silently truncating them or creating
605 non-null-terminated names.
606 (Fnetwork_interface_info): Likewise, for interface names.
607 * sysdep.c (system_process_attributes) [GNU_LINUX]:
608 Prefer sprintf to strncat.
609 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
610 Prefer vsnprintf to vsprintf + strncpy.
611
c59592b3
GM
6122012-07-10 Glenn Morris <rgm@gnu.org>
613
614 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
615 Clarify fallback case.
616
7d7bbefd
DA
6172012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
618
619 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
620 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
621 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 622 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
623 where argument type is known to be a Lisp_Cons.
624
3a4c8000
TT
6252012-07-10 Tom Tromey <tromey@redhat.com>
626
627 * bytecode.c (BYTE_CODE_THREADED): New macro.
628 (BYTE_CODES): New macro. Replaces all old byte-code defines.
629 (enum byte_code_op): New type.
630 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
631 (exec_byte_code): Use them. Use token threading when applicable.
632
2a0213a6
DA
6332012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
634
635 Optimize pure C strings initialization.
636 * lisp.h (make_pure_string): Fix prototype.
637 (build_pure_c_string): New function, defined as static inline. This
638 provides a better opportunity to optimize away calls to strlen when
639 the function is called with compile-time constant argument.
640 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
641 argument, adjust users accordingly. Use build_pure_c_string where
642 appropriate.
643 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
644 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
645 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
646
cb1caeaf
DA
6472012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
648
649 Avoid calls to strlen in miscellaneous functions.
650 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
651 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
652 * lread.c (openp): Likewise.
653
c293e30c
DA
6542012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
655
656 Avoid calls to strlen in path processing functions.
657 * fileio.c (file_name_as_directory): Add comment. Change to add
658 srclen argument and return the length of result. Adjust users
659 accordingly.
660 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 661 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
662 users accordingly.
663 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
664
9e059e3f
GM
6652012-07-10 Glenn Morris <rgm@gnu.org>
666
d02eb359
GM
667 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
668 Move PENDING_OUTPUT_COUNT definition to configure.
669
882cf227
GM
670 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
671 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
672 * s/gnu.h (DATA_START): Move definitions to configure.
673
af6e839f
GM
674 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
675 We include usg5-4-common.h, which defines them both.
676
40289a12
GM
677 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
678 O_RDONLY already includes it).
679
9e059e3f
GM
680 Stop ns builds setting the EMACSLOADPATH environment variable.
681 * nsterm.m (ns_load_path): Rename from ns_init_paths.
682 Now it does not set EMACSLOADPATH, just returns the load-path string.
683 * nsterm.h: Update accordingly.
684 * lread.c [HAVE_NS]: Include nsterm.h.
685 (init_lread) [HAVE_NS]: Use ns_load_path.
686 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
687
7c4e8ec0
GM
6882012-07-09 Glenn Morris <rgm@gnu.org>
689
d4f600ff
GM
690 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
691 since the included bsd-common.h does so.
692
cbb31951
GM
693 Stop ns builds setting the EMACSPATH environment variable.
694 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
695 (ns_init_paths): Do not set EMACSPATH.
696 * nsterm.h (ns_exec_path): Add it.
697 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
698 Use ns_exec_path.
699
7c4e8ec0
GM
700 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
701
26bccfae
PE
7022012-07-09 Paul Eggert <eggert@cs.ucla.edu>
703
a0bee46f
PE
704 * process.c (wait_reading_process_output): 'waitchannels' was unset
705 when read_kbd || !NILP (wait_for_cell); fix this.
706
5994c183
PE
707 Add GCC-style 'const' attribute to functions that can use it.
708 * character.h (char_resolve_modifier_mask):
709 * keyboard.h (make_ctrl_char):
710 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
711 (init_character_once, next_almost_prime, init_fns, init_image)
712 (flush_pending_output, init_sound):
713 * mem-limits.h (start_of_data):
714 * menu.h (finish_menu_items):
715 Add ATTRIBUTE_CONST.
716 * emacs.c (DEFINE_DUMMY_FUNCTION):
717 Declare the dummy function with ATTRIBUTE_CONST.
718 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
719 Add decls with ATTRIBUTE_CONST.
720
26bccfae
PE
721 Minor improvements to make_formatted_string.
722 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
723 where int is good enough, as vsprintf returns an int.
724 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
725
a8290ec3
DA
7262012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
727
728 Use make_formatted_string to avoid double length calculation.
729 * lisp.h (make_formatted_string): New prototype.
730 * alloc.c (make_formatted_string): New function.
731 * buffer.c (Fgenerate_new_buffer_name): Use it.
732 * dbus.c (syms_of_dbusbind): Likewise.
733 * editfns.c (Fcurrent_time_zone): Likewise.
734 * filelock.c (get_boot_time): Likewise.
735 * frame.c (make_terminal_frame, set_term_frame_name)
736 (x_report_frame_params): Likewise.
737 * image.c (gs_load): Likewise.
738 * minibuf.c (get_minibuffer): Likewise.
739 * msdos.c (dos_set_window_size): Likewise.
740 * process.c (make_process): Likewise.
741 * xdisp.c (ensure_echo_area_buffers): Likewise.
742 * xsettings.c (apply_xft_settings): Likewise.
743
d01ba2f1
GM
7442012-07-09 Glenn Morris <rgm@gnu.org>
745
746 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
747 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
748 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
749 * nsterm.h (ns_etc_directory): Add it.
750 * callproc.c [HAVE_NS]: Include nsterm.h.
751 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
752
f1f924b6
DA
7532012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
754
755 Move marker debugging code under MARKER_DEBUG.
756 * marker.c (MARKER_DEBUG): Move marker debugging code under
757 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
758 for bootstrap with --enable-checking (~3x slowdown reported
759 by Juanma Barranquero <lekktu@gmail.com>).
760 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
761
ab531b66
PE
7622012-07-08 Paul Eggert <eggert@cs.ucla.edu>
763
764 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
765 See <http://bugs.gnu.org/11825#29>.
766
c4b3bc8a
EZ
7672012-07-08 Eli Zaretskii <eliz@gnu.org>
768
769 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
770 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
771 (display_line): Add commentary about displaying truncation glyphs
772 on GUI frames.
773 (produce_special_glyphs): Move here from term.c.
774
775 * term.c (produce_special_glyphs): Move to xdisp.c.
776
777 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
778 section.
c4b3bc8a 779
b676b881
AS
7802012-07-07 Andreas Schwab <schwab@linux-m68k.org>
781
f17c5273
AS
782 * xdisp.c (display_line): Avoid warning about implicit declaration
783 of FRAME_FONT.
784
298819b9
AS
785 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
786
b676b881
AS
787 * lisp.h: Remove empty conditional.
788
6045c4fd
PE
7892012-07-07 Paul Eggert <eggert@cs.ucla.edu>
790
b3350bf9
PE
791 * lread.c (load_path_check): Now static.
792
6045c4fd
PE
793 Fix some minor --with-ns problems found by static checking.
794 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
795 (x_set_font) [!HAVE_X_WINDOWS]:
796 * image.c (xpm_load_image) [HAVE_NS]:
797 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
798 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
799 Remove unused local.
800 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
801 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
802 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
803 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
804 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
805 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
806 Fix pointer signedness problem.
807 * xfaces.c (FRAME_X_FONT_TABLE):
808 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
809
929e7845
GM
8102012-07-07 Glenn Morris <rgm@gnu.org>
811
812 * lread.c (load_path_check): New function, split from init_lread.
813 (init_lread): Reorganize. Motivation:
814 If EMACSLOADPATH is set, check/warn about that rather than the
815 defaults, which we are not going to use. Hence we can remove
816 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
817 Don't warn if site-lisp directories are missing.
818 If not installed, start from a blank load-path, since
819 PATH_LOADSEARCH refers to the eventual installation directories.
820
58dd0aa4
EZ
8212012-07-07 Eli Zaretskii <eliz@gnu.org>
822
823 Support truncation and continuation glyphs on GUI frames, when
824 fringes are disabled. (Bug#11832)
825 * xdisp.c (init_iterator): Get dimensions of truncation and
826 continuation glyphs even if on GUI frames. Adjust
827 it->last_visible_x on GUI frames when the left or right fringes,
828 or both, are absent.
829 (start_display, move_it_in_display_line_to): Handle the case of a
830 GUI frame without a fringe to display continuation or truncation
831 glyphs.
832 (insert_left_trunc_glyphs): Support GUI frames: make sure
833 truncation glyphs overwrite enough glyphs from the current line to
834 have sufficient space in pixels.
835 (display_line): Support truncation and continuation glyphs on GUI
836 frames. If some spare pixels are left on the line after inserting
837 the truncation glyphs, fill that space with a stretch glyph of a
838 suitably computed width.
839
840 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
841 produce_glyphs, to support GUI sessions.
842
31571fd7
PE
8432012-07-07 Paul Eggert <eggert@cs.ucla.edu>
844
5a16b9bc
PE
845 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
846
f3047c75
PE
847 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
848
31571fd7
PE
849 Do not require float-time's arg to fit in time_t (Bug#11825).
850 This works better on hosts where time_t is unsigned, and where
851 float-time is applied to the (negative) difference between two times.
852 * editfns.c (decode_time_components): Last arg is now double *,
853 not int *, and means to store all the result as a double, without
854 worrying about whether the seconds part fits in time_t.
855 All callers changed.
856 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
857 All callers changed.
858 (Ffloat_time): Do not fail merely because the specified time falls
859 outside of time_t range.
860
4516fbef
GM
8612012-07-07 Glenn Morris <rgm@gnu.org>
862
863 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
864 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
865 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
866
07adc2c6
JB
8672012-07-07 Juanma Barranquero <lekktu@gmail.com>
868
869 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
870 Update dependencies.
871
872 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
873
fd573f31
PE
8742012-07-06 Paul Eggert <eggert@cs.ucla.edu>
875
fee5959d
PE
876 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
877 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
878 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
879 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
880 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
881 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
882
fd573f31
PE
883 * xfont.c (compare_font_names): Redo to omit the need for casts.
884
ddadbc0e
AS
8852012-07-06 Andreas Schwab <schwab@linux-m68k.org>
886
fca8d6b6
AS
887 * xfns.c (Fx_change_window_property): Doc fix.
888 * w32fns.c (Fx_change_window_property): Doc fix.
889
ddadbc0e
AS
890 * w32fns.c (Fx_window_property): Accept the same arguments as the
891 X Windows version. Doc fix.
892 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
893
ed9265fc 8942012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
895 Eli Zaretskii <eliz@gnu.org>
896
897 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
898 Windows-specific code from nt/config.nt moved here.
899 Obsolete settings removed.
900
216ee680
PE
9012012-07-06 Paul Eggert <eggert@cs.ucla.edu>
902
903 * process.c: Avoid unnecessary calls to gettime.
904 (wait_reading_process_output): Don't get the time of day
905 when gobbling data immediately and not waiting, as there's no need
906 for it in that case. This removes a FIXME.
907
bdd091e4
JD
9082012-07-06 Jan Djärv <jan.h.d@swipnet.se>
909
910 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
911 is defined (Bug#11768).
912
9d44f8ce
DA
9132012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
914
915 Fix marker debugging code.
916 * marker.c (byte_char_debug_check): Do not perform the check
917 if buffer is not multibyte.
090bd7cb
JB
918 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
919 Call byte_char_debug_check with correct arguments.
9d44f8ce 920
90fc4786
DA
9212012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
922
923 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
924 * marker.c (byte_char_debug_check, count_markers):
925 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
926 (byte_debug_flag): Remove.
927 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
928 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
929
7b7ae965
DA
9302012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
931
4e57b342
DA
932 Avoid code repetition in marker-related functions.
933 * marker.c (attach_marker): New function.
934 (Fset_marker, set_marker_restricted, set_marker_both)
935 (set_marker_restricted_both): Use it.
936 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
937 Consistently rename charno to charpos.
938 (marker_position): Add eassert.
939 (marker_byte_position): Convert to eassert.
940
9412012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
942
943 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 944 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 945 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 946
657924ff
DA
9472012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
948
949 Introduce fast path for the widely used marker operation.
950 * alloc.c (build_marker): New function.
951 * lisp.h (build_marker): New prototype.
952 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
953 * composite.c (autocmp_chars): Likewise.
954 * editfns.c (buildmark): Remove.
955 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
956 (save_restriction_save): Use build_marker.
957 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
958 * window.c (save_window_save): Likewise.
959
041a49a6
DA
9602012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
961
962 Do not use Fdelete_overlay in delete_all_overlays
963 to avoid redundant calls to unchain_overlay.
964 * buffer.c (drop_overlay): New function.
965 (delete_all_overlays, Fdelete_overlay): Use it.
966 * minibuf.c (get_minibuffer): Fix comment.
967
7dca65a4
PE
9682012-07-06 Paul Eggert <eggert@cs.ucla.edu>
969
970 Port to OpenBSD 5.1 amd64.
971 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
972 This is needed for OpenBSD, and should be harmless on all BSD systems.
973 Also, include <sys/sysctl.h>, as it should be available on all
974 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
975 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
976 use p_pid member, not kp_proc.pid.
977
8eb876e2
GM
9782012-07-06 Glenn Morris <rgm@gnu.org>
979
980 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
981
38182d90
PE
9822012-07-05 Paul Eggert <eggert@cs.ucla.edu>
983
984 More xmalloc and related cleanup.
985 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
986 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
987 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
988 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
989 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
990 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
991 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
992 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
993 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
994 * xterm.c:
995 Omit needless casts involving void * pointers and allocation.
996 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
997 as the former is more robust if P's type is changed.
998 Prefer xzalloc to xmalloc + memset 0.
999 Simplify malloc-or-realloc to realloc.
1000 Don't worry about xmalloc returning a null pointer.
1001 Prefer xstrdup to xmalloc + strcpy.
1002 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1003 growing it.
1004 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1005 alloca of a constant.
1006
6dd5a677
EZ
10072012-07-05 Eli Zaretskii <eliz@gnu.org>
1008
1009 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1010 hscroll is larger than the line width. Fixes long and futile
1011 looping inside extend_face_to_end_of_line (on a TTY) producing
1012 glyphs that are not needed and thrown away.
1013
6b312f0f
DA
10142012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1015
1016 * marker.c (set_marker_restricted_both): Simplify by using
1017 clip_to_bounds.
1018
f520ef9b
PE
10192012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1020
1021 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1022
383b7c95
JD
10232012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1024
1025 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1026 not defined (Bug#11768).
1027 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1028 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1029 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1030 followed by gtk_box_set_homogeneous (Bug#11768).
1031 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1032 (update_theme_scrollbar_width, xg_create_scroll_bar):
1033 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1034 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1035 (is_box_type): New function (Bug#11768).
1036 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1037 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1038 with default display (Bug#11768).
1039
d6e7bf45
EZ
10402012-07-05 Eli Zaretskii <eliz@gnu.org>
1041
1042 * xdisp.c (window_hscroll_limited): New function.
1043 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1044 coordinates when window's hscroll is set to insanely large
1045 values. (Bug#11857)
1046
431391ec
JB
10472012-07-05 Juanma Barranquero <lekktu@gmail.com>
1048
1049 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1050 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1051
23f86fce
DA
10522012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1053
1054 Cleanup xmalloc.
1055 * lisp.h (xzalloc): New prototype. Omit needless casts.
1056 * alloc.c (xzalloc): New function. Omit needless casts.
1057 * charset.c: Omit needless casts. Convert all calls to
1058 xmalloc with following memset to xzalloc.
1059 * dispnew.c: Likewise.
1060 * fringe.c: Likewise.
1061 * image.c: Likewise.
1062 * sound.c: Likewise.
1063 * term.c: Likewise.
1064 * w32fns.c: Likewise.
1065 * w32font.c: Likewise.
1066 * w32term.c: Likewise.
1067 * xfaces.c: Likewise.
1068 * xfns.c: Likewise.
1069 * xterm.c: Likewise.
1070 * atimer.c: Omit needless casts.
1071 * buffer.c: Likewise.
1072 * callproc.c: Likewise.
1073 * ccl.c: Likewise.
1074 * coding.c: Likewise.
1075 * composite.c: Likewise.
1076 * doc.c: Likewise.
1077 * doprnt.c: Likewise.
1078 * editfns.c: Likewise.
1079 * emacs.c: Likewise.
1080 * eval.c: Likewise.
1081 * filelock.c: Likewise.
1082 * fns.c: Likewise.
1083 * gtkutil.c: Likewise.
1084 * keyboard.c: Likewise.
1085 * lisp.h: Likewise.
1086 * lread.c: Likewise.
1087 * minibuf.c: Likewise.
1088 * msdos.c: Likewise.
1089 * print.c: Likewise.
1090 * process.c: Likewise.
1091 * region-cache.c: Likewise.
1092 * search.c: Likewise.
1093 * sysdep.c: Likewise.
1094 * termcap.c: Likewise.
1095 * terminal.c: Likewise.
1096 * tparam.c: Likewise.
1097 * w16select.c: Likewise.
1098 * w32.c: Likewise.
1099 * w32reg.c: Likewise.
1100 * w32select.c: Likewise.
1101 * w32uniscribe.c: Likewise.
1102 * widget.c: Likewise.
1103 * xdisp.c: Likewise.
1104 * xmenu.c: Likewise.
1105 * xrdb.c: Likewise.
1106 * xselect.c: Likewise.
1107
0497dc44
PE
11082012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1109
1110 * fileio.c (time_error_value): Check the right error number.
1111 Problem reported by Troels Nielsen in
1112 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1113
356e7178
PE
11142012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1115
4e71fd89
PE
1116 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1117 This should be fixed in a better way; see Eli Zaretskii in
1118 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1119 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1120
f0941253
PE
1121 * fileio.c (time_error_value): Rename from special_mtime.
1122 The old name's problems were noted by Eli Zaretskii in
1123 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1124
065c9eb4
PE
1125 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1126 This variable's comment says Emacs needs at least one GDB-visible
1127 symbol of type enum pvec_type, to work around GDB problems.
1128 The symbol's value doesn't matter.
1129
356e7178
PE
1130 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1131 that causes compilation to fail on pre-C99 compilers.
1132
ed9265fc 11332012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1134
1135 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1136 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1137
3884d954
DA
11382012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1139
d209e2fb 1140 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1141 headers for buffer_defaults and buffer_local_symbols.
1142 Reported by Juanma Barranquero <lekktu@gmail.com>.
1143
ee28be33
SM
11442012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1145
1146 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1147 * lisp.h (enum pvec_type): Use fewer bits.
1148 (PSEUDOVECTOR_SIZE_BITS): New constant.
1149 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1150 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1151 change in pvec_type.
1152 (PSEUDOVECTOR_TYPEP): New macro.
1153 (TYPED_PSEUDOVECTORP): Use it.
1154 * fns.c (internal_equal): Adapt code to extract pvectype.
1155 * emacs.c (gdb_pvec_type): Update type.
1156 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1157 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1158 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1159 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1160 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1161 abusing vector->header.next.nbytes.
1162 (live_vector_p): Use PVEC_TYPE.
1163 (mark_object): Adapt code to extract pvectype. Use switch.
1164
c7f2cd7f
PE
11652012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1166
1167 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1168 Tighten new eassert a bit.
1169
8ce70ed2
DA
11702012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1171
1172 Fix compilation with --enable-gcc-warnings and -O1
1173 optimization level.
1174 * doprnt.c (doprnt): Change type of tem to int, initialize
1175 to avoid compiler warning. Add eassert.
1176 * search.c (simple_search): Initialize match_byte to avoid
1177 compiler warning. Add eassert.
1178
dea7f1e5
PE
11792012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1180
24a212eb
PE
1181 Avoid weird behavior with large horizontal scrolls.
1182 Without this change, for example, large hscroll values would
1183 mess up Emacs's display on Fedora 15 x86, presumably due to
1184 overflows in int calculations in the display code.
1185 Also, if buffers had long lines, Emacs would freeze.
1186 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1187 (set_window_hscroll): New function, containing the old guts of
1188 Fset_window_hscroll. Return the clipped value.
1189 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1190 This avoids the need to check against PTRDIFF_MAX.
1191
dea7f1e5
PE
1192 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1193
76046526
DA
11942012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1195
1196 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1197
39adff0d
PE
11982012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1199
63807d47
PE
1200 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1201 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1202 since GCC 4.4.6 issues a bogus warning for them.
1203
39adff0d
PE
1204 Fix bugs in file timestamp newness comparisons.
1205 * fileio.c (Ffile_newer_than_file_p):
1206 * lread.c (Fload): Use full timestamp resolution of files,
1207 not just the 1-second resolution, so that files that are only
1208 slightly newer still count as newer.
1209 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1210 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1211
dbeed9a6
PE
12122012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1213
1214 * fileio.c: Improve handling of file time marker. (Bug#11852)
1215 (special_mtime): New function.
1216 (Finsert_file_contents, Fverify_visited_file_modtime):
1217 Use it to set special mtime values consistently.
1218
636334d6
AS
12192012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1220
1221 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1222 marker for non-existing file. (Bug#11852)
1223
e2017fe2
GM
12242012-07-03 Glenn Morris <rgm@gnu.org>
1225
1226 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1227 and did not make it into globals.h).
1228
404dbd37
TT
12292012-07-03 Tom Tromey <tromey@redhat.com>
1230
1231 * window.c (Fset_window_margins, Fset_window_fringes)
1232 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1233 * textprop.c (Fprevious_property_change): No longer static.
1234 * syntax.c (Fsyntax_table_p): No longer static.
1235 * process.c (Fget_process, Fprocess_datagram_address): No longer
1236 static.
1237 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1238 * keyboard.c (Fcommand_execute): No longer static.
1239 Remove EXFUN.
1240 * insdel.c (Fcombine_after_change_execute): No longer static.
1241 * image.c (Finit_image_library): No longer static.
1242 * fileio.c (Fmake_symbolic_link): No longer static.
1243 * eval.c (Ffetch_bytecode): No longer static.
1244 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1245 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1246 No longer static.
404dbd37
TT
1247 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1248 static.
1249 * dired.c (Ffile_attributes): No longer static.
1250 * composite.c (Fcomposition_get_gstring): No longer static.
1251 * callproc.c (Fgetenv_internal): No longer static.
1252
1253 * ccl.h: Remove EXFUNs.
1254 * buffer.h: Remove EXFUNs.
1255 * dispextern.h: Remove EXFUNs.
1256 * intervals.h: Remove EXFUNs.
1257 * fontset.h: Remove EXFUN.
1258 * font.h: Remove EXFUNs.
1259 * dosfns.c (system_process_attributes): Remove EXFUN.
1260 * keymap.h: Remove EXFUNs.
1261 * lisp.h: Remove EXFUNs.
1262 * w32term.h: Remove EXFUNs.
1263 * window.h: Remove EXFUNs.
1264 * xsettings.h: Remove EXFUN.
1265 * xterm.h: Remove EXFUN.
1266
8e4fd1e1
GM
12672012-07-03 Glenn Morris <rgm@gnu.org>
1268
1269 * lisp.h (Frandom): Make it visible to C.
1270 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1271 buffer for invisible buffers. (Bug#1229)
1272
ca95b3eb
DA
12732012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1274
1275 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1276 values which aren't power of 2.
1277 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1278 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1279 accordingly.
1280
7555c33f
SM
12812012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1282
1283 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1284
1285 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1286
d12e8f5a
DA
12872012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1288
1289 * alloc.c (allocate_vector_block): Remove redundant
1290 calls to mallopt if DOUG_LEA_MALLOC is defined.
1291 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1292 avoid calls to mallopt if zero_vector is returned.
1293
296094c3
DA
12942012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1295
1296 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1297 is enabled, avoid dereferencing NULL current_sblock if
1298 running undumped.
1299
36429c89
DA
13002012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1301
1302 Cleanup basic buffer management.
1303 * buffer.h (struct buffer): Change layout to use generic vector
1304 marking code. Fix some comments. Change type of 'clip_changed'
1305 to bitfield. Remove unused #ifndef old.
1306 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1307 (GET_OVERLAYS_AT): Fix indentation.
1308 (for_each_per_buffer_object_at): New macro.
1309 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1310 (Fbuffer_local_variables): Use it.
1311 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1312 * alloc.c (allocate_buffer): Adjust to match new layout of
1313 struct buffer. Fix comment.
1314 (mark_overlay): New function.
1315 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1316 Lisp area of struct buffer.
1317 (mark_object): Use it. Adjust marking of misc objects
1318 and related comments.
1319
3b3e4cac
PE
13202012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1321
1322 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1323 wrapper that is not needed because the wrapped code is a no-op (zero
1324 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1325 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1326
cf5c0175
DA
13272012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1328
1329 * alloc.c (mark_buffer): Simplify. Remove prototype.
1330 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1331 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1332 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1333 redundant calls to mark_vectorlike for bool vectors.
1334
ca26824c
GM
13352012-06-30 Glenn Morris <rgm@gnu.org>
1336
2e4c5312
GM
1337 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1338
ca26824c
GM
1339 * epaths.in (PATH_SITELOADSEARCH): New.
1340 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1341 This is rather than relying on --enable-locallisppath elements
1342 having "site-lisp" in their names. (Bug#10208#25, 11658)
1343
0d23c240
EZ
13442012-06-30 Eli Zaretskii <eliz@gnu.org>
1345
c9240d7a
EZ
1346 * w32proc.c (sys_select): Accept and ignore one more argument.
1347
1348 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1349
0d23c240 1350 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1351 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1352
1353 * sysdep.c: Don't include dos.h and dosfns.h.
1354
1355 * process.c (sys_select):
1356 * msdos.c (sys_select): Accept one more argument and ignore it.
1357
1358 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1359 adapt data types and code to that.
1360
1361 * dosfns.c:
1362 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1363 which clashes with the gnulib function of the same name.
1364
af5a5a98
AS
13652012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1366
c5e4379c
AS
1367 * font.c (font_style_to_value, font_style_symbolic)
1368 (font_prop_validate_style): Add type checks for values in
1369 font_style_table.
1370
af5a5a98
AS
1371 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1372 argument.
1373 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1374 uses.
1375
8d38f461
EZ
13762012-06-29 Eli Zaretskii <eliz@gnu.org>
1377
2e5a6631
EZ
1378 * xdisp.c (try_window_id): Undo last change.
1379
8d38f461
EZ
1380 * w32.c (getwd): Adjust commentary about startup_dir.
1381 (init_environment): Always call sys_access, even in non-MSVC
1382 builds. Don't chdir to the directory of the Emacs executable.
1383 This undoes code from 1997 which was justified by the need to
1384 "avoid conflicts when removing and renaming directories". But its
1385 downside was that every relative file name was being interpreted
1386 relative to the directory of the Emacs executable, which can never
1387 be TRT. In particular, it broke sys_access when called with
1388 relative file names.
1389 (sys_access): Map GetLastError to errno.
1390
2af3565e
DA
13912012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1392
1393 * window.h (struct window): Change type of 'fringes_outside_margins'
1394 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1395 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1396 Adjust comment.
1397 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1398 to ptrdiff_t.
1399
c8d3a25c 14002012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1401
c8d3a25c
GM
1402 * gnutls.c (emacs_gnutls_handshake):
1403 Add QUIT to make the loop interruptible.
57570cd3 1404
c8d3a25c 14052012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1406
c8d3a25c
GM
1407 * charset.c (init_charset): Make lack of etc/charsets fatal.
1408
3e984ee8
DA
14092012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1410
1411 * editfns.c (region_limit): Fix type mismatch.
1412
ef884f23
DA
14132012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1414
1415 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1416 undefined. Convert from xassert to eassert.
1417 * nsmenu.m: Convert from xassert to eassert.
1418 * nsterm.m: Likewise.
1419
7d7e0027
SM
14202012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1421
1422 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1423
aa754e6a
PE
14242012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1425
1426 Avoid integer overflow on scroll-left and scroll-right.
1427 * window.c (HSCROLL_MAX): New macro.
1428 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1429 overflow when requested scroll falls outside ptrdiff_t range.
1430
80b00b08
DA
14312012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1432
1433 * window.h (struct window): Change type of 'hscroll',
1434 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1435 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1436 Adjust users accordingly.
1437 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1438 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1439 from EMACS_INT to ptrdiff_t.
1440 (make_window): Omit redundant initialization.
1441
62b2bcf6
JB
14422012-06-28 Juanma Barranquero <lekktu@gmail.com>
1443
1444 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1445
45942c7d
DA
14462012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1447
1448 * window.h (struct window): Change type of 'use_time' and
1449 'sequence_number' from Lisp_Object to int.
1450 * frame.c (make_frame): Adjust users accordingly.
1451 * print.c (print_object): Likewise.
1452 * window.c (select_window, Fwindow_use_time, make_parent_window)
1453 (make_window): Likewise.
1454
e509cfa6
DA
14552012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1456
1457 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1458 enabled with --enable-checking=[all,glyphs] configure option.
1459 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1460 adjust comments accordingly.
1461 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1462 undefined, adjust comments accordingly.
1463 * image.c: Likewise.
1464 * scroll.c: Likewise.
1465 * w32fns.c: Likewise.
1466 * w32term.c: Likewise.
1467 * xdisp.c: Likewise.
1468 * xfaces.c: Likewise.
1469 * xfns.c: Likewise.
1470 * xterm.c: Likewise.
1471
a54e2c05
DA
14722012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1473
1474 Generalize run-time debugging checks.
1475 * dispextern.h (XASSERTS): Remove.
1476 * fontset.c (xassert): Remove.
1477 Convert from xassert to eassert.
1478 * alloc.c: Convert from xassert to eassert.
1479 * bidi.c: Likewise.
1480 * dispnew.c: Likewise.
1481 * fns.c: Likewise.
1482 * fringe.c: Likewise.
1483 * ftfont.c: Likewise.
1484 * gtkutil.c: Likewise.
1485 * image.c: Likewise.
1486 * keyboard.c: Likewise.
1487 * menu.c: Likewise.
1488 * process.c: Likewise.
1489 * scroll.c: Likewise.
1490 * sound.c: Likewise.
1491 * term.c: Likewise.
1492 * w32console.c: Likewise.
1493 * w32fns.c: Likewise.
1494 * w32term.c: Likewise.
1495 * window.c: Likewise.
1496 * xdisp.c: Likewise.
1497 * xfaces.c: Likewise.
1498 * xfns.c: Likewise.
1499 * xselect.c: Likewise.
1500 * xterm.c: Likewise.
1501
1ec4b7b2
SM
15022012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1503
1504 * fns.c (maybe_resize_hash_table): Output message when growing the
1505 purify-hashtable.
1506
2014308a
DA
15072012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1508
1509 * alloc.c (allocate_string_data): Remove dead code.
1510 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1511 avoid GCC warning about unused macro.
1512
246155eb
DA
15132012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1514
1515 * alloc.c (allocate_string): Omit intervals initialization.
1516 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1517 as in make_pure_string and make_pure_c_string.
1518
43184b7b
DA
15192012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1520
d209e2fb 1521 * alloc.c (allocate_string): Fix last change.
43184b7b 1522
3fe6dd74
DA
15232012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1524
d209e2fb 1525 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1526 to memset, add explicit initialization where appropriate.
1527
1ba6038a
GM
15282012-06-27 Glenn Morris <rgm@gnu.org>
1529
1530 * lisp.mk (lisp): Remove paths.elc.
1531
c89926a5
CY
15322012-06-27 Chong Yidong <cyd@gnu.org>
1533
1534 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1535
ed6b3510
JW
15362012-06-26 John Wiegley <johnw@newartisans.com>
1537
1ec4b7b2 1538 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1539 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1540
ed6b3510
JW
1541 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1542 when building with Clang.
1543
8edd4a2b
SM
15442012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1545
1546 * eval.c (Fapply): Allow calling it with a single argument.
1547
f6f62d1b
EZ
15482012-06-26 Eli Zaretskii <eliz@gnu.org>
1549
1550 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1551 _stricmp and _strnicmp.
1552 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1553
62efea5e
DA
15542012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1555
1556 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1557 allocated window.
1558 (allocate_process): Likewise for new process.
8edd4a2b 1559 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1560 (allocate_frame): Likewise.
1561 * frame.c (make_frame): Omit redundant initialization.
1562 * window.c (make_parent_window): Use memset.
1563 (make_window): Omit redundant initialization.
1564 * process.c (make_process): Omit redundant initialization.
1565 * terminal.c (create_terminal): Likewise.
1566
42997f4d
DA
15672012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1568
1569 * term.c (delete_tty): Remove redundant call to memset.
1570
1130ecfc
DA
15712012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1572
1573 * alloc.c: Remove build_string.
1574 * lisp.h: Define build_string as static inline. This provides
1575 a better opportunity to optimize away calls to strlen when the
1576 function is called with compile-time constant argument.
1577 * image.c (imagemagick_error): Convert to build_string.
1578 * w32proc.c (sys_spawnve): Likewise.
1579 * xterm.c (x_term_init): Likewise.
1580
cf38a720
PE
15812012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1582
99027bdd
PE
1583 Use sprintf return value instead of invoking strlen on result.
1584 In the old days this wasn't portable, since some sprintf
1585 implementations returned char *. But they died out years ago and
1586 Emacs already assumes sprintf returns int.
1587 Similarly for float_to_string.
1588 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1589 * ccl.c (ccl_driver):
1590 * character.c (string_escape_byte8):
1591 * data.c (Fnumber_to_string):
1592 * doprnt.c (doprnt):
1593 * print.c (print_object):
1594 * xdisp.c (message_dolog):
1595 * xfns.c (syms_of_xfns):
1596 Use sprintf or float_to_string result to avoid need to call strlen.
1597 * data.c (Fnumber_to_string):
1598 Use make_unibyte_string, since the string must be ASCII.
1599 * lisp.h, print.c (float_to_string): Now returns int length.
1600 * term.c (produce_glyphless_glyph):
1601 Use sprintf result rather than recomputing it.
1602
cf38a720
PE
1603 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1604 * Makefile.in (ALL_CFLAGS):
1605 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1606 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1607
3511c784
DA
16082012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1609
0a08eb21 1610 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1611 strcasecmp if available.
1612 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1613
fb7da12e
AS
16142012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1615
1616 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1617 Avoid comma operator.
1618 * menu.c (push_submenu_start, push_submenu_end)
1619 (push_left_right_boundary, push_menu_pane): Likewise.
1620 * msdos.c (dos_rawgetc): Likewise.
1621
afa2ffd8
DA
16222012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1623
1624 * xfns.c (xic_create_fontsetname): Remove redundant calls
1625 to memset.
1626
b3b4476b
PE
16272012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1628
4495ff38
PE
1629 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1630 sprintf already null-terminates its output.
1631
b3b4476b
PE
1632 * xfns.c (x_window): Remove redundant cast.
1633
b00876c9
DA
16342012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1635
1636 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1637 `const char *' to `char *' to avoid compiler warning.
1638
d188e26b
PE
16392012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1640
885d1d74
PE
1641 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1642 instead of truncating it to 63 (admittedly a generous limit).
1643
d188e26b
PE
1644 * process.c: Fix spelling and caps in comments.
1645
e2f560b1
DN
16462012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1647
e86db54b 1648 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1649 * sysdep.c (setpgrp): Remove definition, not used in this file.
1650
7583a3a1
JB
16512012-06-24 Juanma Barranquero <lekktu@gmail.com>
1652
1653 * makefile.w32-in: Update dependencies.
1654
696056c2
EZ
16552012-06-24 Eli Zaretskii <eliz@gnu.org>
1656
1657 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1658 (SYSTIME_H): Add nt/inc/sys/time.h.
1659
1660 * systime.h [WINDOWSNT]: Include sys/time.h.
1661
1662 * s/ms-w32.h (struct timespec): Definition moved from
1663 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1664
845ca893
PE
16652012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1666
1667 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1668 * buffer.h (buffer_slot_type_mismatch):
1669 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1670 * eval.c (unwind_to_catch):
1671 * image.c (my_png_error, my_error_exit):
1672 * keyboard.c (quit_throw_to_read_char, user_error)
1673 (Fexit_recursive_edit, Fabort_recursive_edit):
1674 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1675 (wrong_type_argument, buffer_overflow, __executable_start)
1676 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1677 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1678 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1679 (fatal):
1680 (child_setup) [!DOS_NT]:
1681 * lread.c (end_of_file_error, invalid_syntax):
1682 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1683 * puresize.h (pure_write_error):
1684 * search.c (matcher_overflow):
1685 * sound.c (sound_perror, alsa_sound_perror):
1686 * sysdep.c, syssignal.h (croak):
1687 * term.c (maybe_fatal, vfatal):
1688 * textprop.c (text_read_only):
1689 * undo.c (user_error):
1690 * unexmacosx.c (unexec_error):
1691 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1692 Use _Noreturn rather than NO_RETURN.
1693 No need for separate decl merely because of _Noreturn.
1694 * sound.c (sound_warning, parse_sound):
1695 Remove unnecessary forward decls.
1696
f1dd8073
PE
16972012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1698
1699 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1700 * lisp.h (WAIT_READING_MAX): New macro.
1701 * dispnew.c (Fsleep_for, sit_for):
1702 * keyboard.c (kbd_buffer_get_event):
1703 * process.c (Faccept_process_output):
1704 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1705 This improves on the previous patch, which introduced a bug
1706 when time_t is unsigned and as wide as intmax_t.
1707 See <http://bugs.gnu.org/9000#51>.
1708
b82c1755
EZ
17092012-06-23 Eli Zaretskii <eliz@gnu.org>
1710
1711 * dispnew.c (sit_for, Fsleep_for):
1712 * keyboard.c (kbd_buffer_get_event):
1713 * process.c (Faccept_process_output): Avoid compiler warnings when
1714 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1715
ca300656
JB
17162012-06-23 Juanma Barranquero <lekktu@gmail.com>
1717
049ec95b
JB
1718 * makefile.w32-in: Update dependencies.
1719
ca300656
JB
1720 * w32.c (ltime): Add return type and declare static.
1721 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1722
db7b8d06
PE
17232012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1724
1725 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1726 Privately reported by Herbert J. Skuhra.
1727 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1728 All uses changed.
1729 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1730 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1731
0bd8297f
EZ
17322012-06-23 Eli Zaretskii <eliz@gnu.org>
1733
96512555
EZ
1734 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1735 last argument of make_unibyte_string.
1736
0bd8297f
EZ
1737 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1738 language ID in the event parameters.
1739
1740 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1741 event.code, not the obscure "character set ID".
1742
63def6b6
CY
17432012-06-23 Chong Yidong <cyd@gnu.org>
1744
1745 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1746
e8a02204
EZ
17472012-06-23 Eli Zaretskii <eliz@gnu.org>
1748
388cdec0
EZ
1749 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1750 * w32.c (fdutimens): New function.
1751
1752 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1753
1754 * s/ms-w32.h (pselect): Redirect to sys_select.
1755
1756 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1757
e8a02204
EZ
1758 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1759 in the logic of incrementing and decrementing the value of
1760 use_relocatable_buffers.
1761
d054f3fb
PE
17622012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1763
1764 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1765 Privately reported by Herbert J. Skuhra.
1766 [__FreeBSD__]: Remove "*/" typo after "#include".
1767 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1768 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1769 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1770 Don't assume EMACS_TIME and struct timeval are the same type.
1771
d35af63c
PE
17722012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1773
1774 Support higher-resolution time stamps (Bug#9000).
1775 The time stamps are only nanosecond-resolution at the C level,
1776 since that's the best that any real-world system supports now.
1777 But they are picosecond-resolution at the Lisp level, as that's
1778 easy, and leaves room for future OS improvements.
1779
1780 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1781 (LIBES): Use it.
1782
1783 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1784 Don't get current time unless it's needed.
1785
1786 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1787 now provides it if it's absent.
1788 (start_atimer): Port to higher-res time stamps.
1789 Check for time stamp overflow. Don't get current time more
1790 often than is needed.
1791
1792 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1793 Include systime.h, not time.h.
1794 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1795
1796 * dired.c: Include stat-time.h.
1797 (Ffile-attributes): File times now have higher resolution.
1798
1799 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1800 (struct image): Timestamp now has higher resolution.
1801
1802 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1803 has at least microseconds now. All uses removed.
1804 (update_frame, update_single_window, update_window, update_frame_1)
1805 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1806
1807 * editfns.c (time_overflow): Now extern.
1808 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1809 (float-time, Fformat_time_string, Fcurrent_time_string)
1810 (Fcurrent_time_zone): Accept and generate higher-resolution
1811 time stamps.
1812 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1813 (decode_time_components, lisp_seconds_argument): New functions.
1814 (make_time): Now static.
1815 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1816 Report an error if the time is invalid, rather than having the caller
1817 do that.
1818
1819 * fileio.c: Include <stat-time.h>
1820 (Fcopy_file): Copy higher-resolution time stamps.
1821 Prefer to set the time stamp via a file descriptor if that works.
1822 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1823 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1824 (Fvisited_file_modtime, Fset_visited_file_modtime):
1825 Support higher-resolution time stamps.
1826
1827 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1828
1829 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1830
1831 * image.c (prepare_image_for_display, clear_image_cache)
1832 (lookup_image): Port to higer-resolution time stamps.
1833
1834 * keyboard.c (start_polling, bind_polling_period):
1835 Check for time stamp overflow.
1836 (read_char, kbd_buffer_get_event, timer_start_idle)
1837 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1838 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1839 Port to higher-resolution time stamps. Do not assume time_t is signed.
1840 (decode_timer): New function. Timers are now vectors of length 9,
1841 not 8, to accommodate the picosecond component.
1842 (timer_check_2): Use it.
1843
1844 * nsterm.m (select_timeout, timeval_subtract): Remove.
1845 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1846 as they're a bit more accurate and handle overflow better.
1847 (ns_select): Change prototype to be compatible with pselect.
1848 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1849 * nsterm.h (ns_select): Adjust prototype.
1850
1851 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1852 us-resolution time stamps.
1853 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1854
1855 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1856
1857 * lisp.h (time_overflow): New decl.
1858 (wait_reading_process_output): First arg is now intmax_t, not int,
1859 to accommodate larger waits.
1860
1861 * process.h (struct Lisp_Process.read_output_delay):
1862 Now counts nanoseconds, not microseconds.
1863 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1864 EMACS_HAS_USECS.
1865 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1866 (wait_reading_process_output):
1867 Port to ns-resolution time stamps.
1868 (Faccept_process_output, wait_reading_process_output):
1869 Check for time stamp overflow. Do not assume time_t is signed.
1870 (select_wrapper): Remove; we now use pselect.
1871 (Fprocess_attributes): Now generates ns-resolution time stamps.
1872
1873 * sysdep.c: Include utimens.h. Don't include utime.h
1874 or worry about struct utimbuf; gnulib does that for us now.
1875 (gettimeofday): Remove; gnulib provides a substitute.
1876 (make_timeval): New function.
1877 (set_file_times): Now sets ns-resolution time stamps.
1878 New arg FD; all uses changed.
1879 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1880 (system_process_attributes):
1881 Now returns ns-resolution time stamp. All uses changed.
1882 Check for time stamp overflow.
1883
1884 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1885 provides a substitute now.
1886
1887 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1888 since it guarantees struct timespec.
1889 (EMACS_TIME): Now struct timespec, so that we can support
1890 ns-resolution time stamps.
1891 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1892 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1893 (EMACS_USECS): Remove.
1894 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1895 so multiply the arg by 1000 before storing it.
1896 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1897 New macros.
1898 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1899 Port to ns-resolution time stamps.
1900 (EMACS_TIME_NEG_P): Remove; replaced by....
1901 (EMACS_TIME_SIGN): New macro.
1902 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1903 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1904 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1905 (make_timeval, make_lisp_time, decode_time_components): New decls.
1906 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1907 that it mishandled time_t overflow. You can't compare by subtracting!
1908 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1909 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1910
1911 * term.c: Include <sys/time.h>.
1912 (timeval_to_Time): New function, for proper overflow wraparound.
1913 (term_mouse_position, term_mouse_click): Use it.
1914
1915 * undo.c (record_first_change): Support higher-resolution time stamps
1916 in the undo buffer.
1917 (Fprimitive_undo): Use them when restoring time stamps.
1918
1919 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1920 (w32_get_internal_run_time):
1921 Port to higher-resolution Emacs time stamps.
1922 (ltime): Now accepts single 64-bit integer, as that's more convenient
1923 for callers.
1924
1925 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1926
1927 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1928 for compatibility with pselect. Support ns-resolution time stamps.
1929
1930 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1931
1932 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1933 Check for time stamp overflow, and support ns-resolution time stamps.
1934
1935 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1936 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1937 (timeval_subtract): Remove; no longer needed.
1938 (XTflash, XTring_bell, x_wait_for_event):
1939 Port to ns-resolution time stamps. Don't assume time_t is signed.
1940
b6a92dfe
CY
19412012-06-22 Chong Yidong <cyd@gnu.org>
1942
1943 * xdisp.c (x_consider_frame_title): Revert last change.
1944
d251c37c
EZ
19452012-06-22 Eli Zaretskii <eliz@gnu.org>
1946
1947 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1948 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1949 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1950 staticidx goes up to 1597 out of 1600 = 0x640.)
1951
f10deafb
PE
19522012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1953
1954 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1955 Otherwise, the umask might be mistakenly 0 while handling input signals.
1956
ec6de1e2
SM
19572012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1958
1959 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1960
28be1ada
DA
19612012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1962
1963 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1964 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1965 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1966 access to `contents' member of Lisp_Vector objects with AREF and ASET
1967 where appropriate.
1968
c6bf3022
CY
19692012-06-19 Chong Yidong <cyd@gnu.org>
1970
1971 * frame.c (delete_frame): When selecting a frame on a different
1972 text terminal, do not alter the terminal's top-frame.
1973
1974 * xdisp.c (format_mode_line_unwind_data): Record the target
1975 frame's selected window and its terminal's top-frame.
1976 (unwind_format_mode_line): Restore them.
1977 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1978 Callers changed.
1979 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1980 since tty frames can be explicitly named.
1981 (prepare_menu_bars): Likewise.
1982
1983 * term.c (Ftty_top_frame): New function.
1984
defd4196
PE
19852012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1986
1987 Port byte-code-meter to modern targets.
1988 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1989 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1990 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1991 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1992 (METER_1, METER_2): Simplify.
1993
1053a871
SM
19942012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1995
1996 * data.c (Fdefalias): Return `symbol' (bug#11686).
1997
b7e8d081
MR
19982012-06-18 Martin Rudalics <rudalics@gmx.at>
1999
2000 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2001 gets killed during executing of this function (Bug#11665).
2002 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2003 (Vkill_buffer_query_functions): In doc-string say that functions
2004 run by this hook should not change the current buffer.
2005
7ea2b339
PE
20062012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2007
2008 Fix recently-introduced process.c problems found by static checking.
2009 * process.c (write_queue_push, write_queue_pop, send_process):
2010 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2011 (write_queue_pop): Fix pointer signedness problem.
2012 (send_process): Remove unused local.
2013
96a313a1
CY
20142012-06-17 Chong Yidong <cyd@gnu.org>
2015
2016 * xdisp.c (redisplay_internal): No need to redisplay terminal
2017 frames that are not on top.
2018
20ca2e94
TN
20192012-06-17 Troels Nielsen <bn.troels@gmail.com>
2020
2021 * process.c (make_process): Initialize write_queue.
2022 (write_queue_push, write_queue_pop): New functions.
2023 (send_process): Use them to maintain correct ordering of process
2024 writes (Bug#10815).
2025
9a900ca9
PE
20262012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2027
310fbfa8
PE
2028 * lisp.h (eassert): Assume C89 or later.
2029 This removes the need for CHECK.
2030 (CHECK): Remove. Its comments about always evaluating its
2031 argument were confusing, as 'eassert' typically does not evaluate
2032 its argument.
2033
27bb1ca4
PE
2034 * coding.c (produce_chars): Use ptrdiff_t, not int.
2035
9a900ca9
PE
2036 * xterm.c (x_draw_underwave): Check for integer overflow.
2037 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2038
41b7f8bc 20392012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2040
2041 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2042 referenced (Bug#11583).
2043
9b0e3eba
AA
20442012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2045
2046 Implement wave-style variant of underlining.
2047 * dispextern.h (face_underline_type): New enum.
2048 (face): Add field for underline type.
2049 * nsterm.m (ns_draw_underwave): New function.
2050 (ns_draw_text_decoration): Use it.
2051 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2052 New functions.
2053 (x_draw_glyph_string): Use them.
2054 * xfaces.c (Qline, Qwave): New Lisp objects.
2055 (check_lface_attrs, merge_face_ref)
1053a871
SM
2056 (Finternal_set_lisp_face_attribute, realize_x_face):
2057 Handle wave-style underline face attributes.
9b0e3eba
AA
2058 * xterm.c (x_draw_underwave): New function.
2059 (x_draw_glyph_string): Use it.
2060
0fb52f11
JB
20612012-06-16 Juanma Barranquero <lekktu@gmail.com>
2062
2063 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2064 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2065 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2066 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2067 ($(BLD)/w32select.$(O)): Update dependencies.
2068
e5560ff7
AS
20692012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2070
2071 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2072 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2073 * character.c (_fetch_multibyte_char_p): Remove.
2074 * alloc.c: Include "character.h" before "buffer.h".
2075 * bidi.c: Likewise.
2076 * buffer.c: Likewise.
2077 * bytecode.c: Likewise.
2078 * callint.c: Likewise.
2079 * callproc.c: Likewise.
2080 * casefiddle.c: Likewise.
2081 * casetab.c: Likewise.
2082 * category.c: Likewise.
2083 * cmds.c: Likewise.
2084 * coding.c: Likewise.
2085 * composite.c: Likewise.
2086 * dired.c: Likewise.
2087 * dispnew.c: Likewise.
2088 * doc.c: Likewise.
2089 * dosfns.c: Likewise.
2090 * editfns.c: Likewise.
2091 * emacs.c: Likewise.
2092 * fileio.c: Likewise.
2093 * filelock.c: Likewise.
2094 * font.c: Likewise.
2095 * fontset.c: Likewise.
2096 * fringe.c: Likewise.
2097 * indent.c: Likewise.
2098 * insdel.c: Likewise.
2099 * intervals.c: Likewise.
2100 * keyboard.c: Likewise.
2101 * keymap.c: Likewise.
2102 * lread.c: Likewise.
2103 * macros.c: Likewise.
2104 * marker.c: Likewise.
2105 * minibuf.c: Likewise.
2106 * nsfns.m: Likewise.
2107 * nsmenu.m: Likewise.
2108 * print.c: Likewise.
2109 * process.c: Likewise.
2110 * regex.c: Likewise.
2111 * region-cache.c: Likewise.
2112 * search.c: Likewise.
2113 * syntax.c: Likewise.
2114 * term.c: Likewise.
2115 * textprop.c: Likewise.
2116 * undo.c: Likewise.
2117 * unexsol.c: Likewise.
2118 * w16select.c: Likewise.
2119 * w32fns.c: Likewise.
2120 * w32menu.c: Likewise.
2121 * window.c: Likewise.
2122 * xdisp.c: Likewise.
2123 * xfns.c: Likewise.
2124 * xmenu.c: Likewise.
2125 * xml.c: Likewise.
2126 * xselect.c: Likewise.
2127
2f07e6af
EZ
21282012-06-16 Eli Zaretskii <eliz@gnu.org>
2129
1053a871
SM
2130 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2131 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2132 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2133 row.
2134 (handle_face_prop): Use chunk-relative overlay string index when
2135 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2136 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2137 the rightmost. (Bug#11720)
2f07e6af 2138
29b83cec
AS
21392012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2140
2141 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2142 (CATEGORY_MEMBER): Enforce 1/0 value.
2143 * category.c (_temp_category_set): Remove.
2144
4c5501e9
EZ
21452012-06-16 Eli Zaretskii <eliz@gnu.org>
2146
2147 * window.c (Fdelete_other_windows_internal)
2148 (Fdelete_window_internal): Don't access frame's mouse highlight
2149 info of the initial frame. (Bug#11677)
2150
2b570124
PE
21512012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2152
e93864f9
PE
2153 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2154 Assume USE_2_TAGS_FOR_INTS.
2155 (xreload): Adjust $tagmask width to match recent lisp.h change.
2156
2b570124
PE
2157 Simplify lisp.h in minor ways that should not affect code.
2158 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2159 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2160 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2161 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2162 (INTTYPEBITS): New macro, for clarity.
2163 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2164 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2165 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2166 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2167 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2168
81755f69
JB
21692012-06-13 Juanma Barranquero <lekktu@gmail.com>
2170
2171 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2172
16192a57
GM
21732012-06-13 Glenn Morris <rgm@gnu.org>
2174
2175 * s/bsd-common.h (BSD4_3):
2176 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2177
646b5f55
AS
21782012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2179
2180 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2181 instead of union.
2182 (XLI, XIL): Define.
1053a871
SM
2183 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2184 Use them.
2185 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2186 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2187 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2188 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2189 * frame.c (delete_frame): Remove outdated comment.
2190 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2191 USE_LISP_UNION_TYPE.
2192 (Fw32_unregister_hot_key): Likewise.
2193 (Fw32_toggle_lock_key): Likewise.
2194 * w32menu.c (add_menu_item): Likewise.
2195 (w32_menu_display_help): Use XIL instead of checking
2196 USE_LISP_UNION_TYPE.
2197 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2198 (init_heap): Likewise.
2199 * w32term.c (w32_read_socket): Update comment.
2200
1d3823c9
GM
22012012-06-13 Glenn Morris <rgm@gnu.org>
2202
c62ff706
GM
2203 * s/usg5-4-common.h, src/s/unixware.h:
2204 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2205
1d3823c9
GM
2206 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2207
bfe3e0a2
PE
22082012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2209
2210 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2211 * alloc.c (make_number) [!defined make_number]:
2212 Remove, as lisp.h always defines this now.
2213 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2214 (roundup_size): Verify that it is a power of 2.
2215 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2216 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2217 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2218 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2219 USE_LSB_TAG now is always defined to be either 0 or 1.
2220 All uses changed.
2221 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2222 code works fine either way, and efficiency is not a concern here,
2223 as the union type is for debugging, not for production.
2224 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2225 Use an inline function on all platforms when using the union type,
2226 since this is simpler and 'static inline' can be used portably
2227 within Emacs now.
2228 (LISP_INITIALLY_ZERO): New macro.
2229 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2230 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2231
45fa9c0f
GM
22322012-06-12 Glenn Morris <rgm@gnu.org>
2233
b4492cba
GM
2234 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2235
2236 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2237
45fa9c0f
GM
2238 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2239 Move BROKEN_SIGIO to configure.
2240
2241 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2242 Move NO_TERMIO to configure.
2243
0e25d334
CY
22442012-06-12 Chong Yidong <cyd@gnu.org>
2245
2246 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2247 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2248 MagickExportImagePixels is undefined.
2249
43682bb6
PE
22502012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2251
2252 * image.c (imagemagick_load_image): Remove unused label.
2253
a9be7d2b
GM
22542012-06-11 Glenn Morris <rgm@gnu.org>
2255
2256 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2257 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2258 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2259 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2260
3017f87f
SM
22612012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2262
2263 * alloc.c (make_byte_code): New function.
2264 (Fmake_byte_code): Use it. Don't purify here.
2265 * lread.c (read1): Use it as well to avoid extra allocation.
2266
1b9b4cf4
CY
22672012-06-11 Chong Yidong <cyd@gnu.org>
2268
2269 * image.c (imagemagick_load_image): Implement transparency.
2270
95988fcf
AS
22712012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2272
2273 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2274 account for preceding backslashes. (Bug#11663)
2275
cd4eb164
CY
22762012-06-09 Chong Yidong <cyd@gnu.org>
2277
2278 * term.c: Support italics in capable terminals (Bug#9652).
2279 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2280 (turn_on_face): Output using TS_enter_italic_mode if available.
2281 Don't handle unused blinking and alt-charset cases.
2282 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2283 and tty_alt_charset_p cases.
2284 (tty_capable_p, init_tty): Support italics.
2285
2286 * termchar.h (struct tty_display_info): Add field for italics.
2287 Remove unused blink field.
2288
2289 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2290 Handle slant.
2291
2292 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2293 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2294 tty_alt_charset_p. Add tty_italic_p.
2295
ff88beb8
MA
22962012-06-09 Michael Albinus <michael.albinus@gmx.de>
2297
2298 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2299 dbus_type_is_basic if available.
2300 (xd_extract_signed, xd_extract_unsigned): Rename from
2301 extract_signed and extract_unsigned, respectively. Adapt callers.
2302
44286096
CY
23032012-06-09 Chong Yidong <cyd@gnu.org>
2304
1682701f
CY
2305 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2306
44286096
CY
2307 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2308 case (Bug#9752).
2309
d86feb17
PE
23102012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2311
2312 * xdisp.c (vmessage): Treat frame message as multibyte.
2313 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2314 would generate the diagnostic "Making \302\247 buffer-local while
2315 let-bound!".
2316
d5c20fe8
EZ
23172012-06-08 Eli Zaretskii <eliz@gnu.org>
2318
2319 * dispnew.c (showing_window_margins_p): Undo last change, which
2320 was done due to an inadvertent commit.
2321 (adjust_frame_glyphs_for_frame_redisplay): Do call
2322 showing_window_margins_p.
2323
513749ee
SM
23242012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2325
2326 * eval.c (Fmake_var_non_special): New primitive.
2327 (syms_of_eval): Defsubr it.
2328 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2329
d4a8f5c1
JB
23302012-06-08 Juanma Barranquero <lekktu@gmail.com>
2331
2332 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2333 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2334
8bbbc977
EZ
23352012-06-08 Eli Zaretskii <eliz@gnu.org>
2336
2337 * alloc.c (allocate_vectorlike): Fix last change.
2338
f3372c87
DA
23392012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2340
2341 Block-based vector allocation of small vectors.
2342 * lisp.h (struct vectorlike_header): New field `nbytes',
2343 adjust comment accordingly.
2344 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2345 to denote vector blocks. Adjust users (live_vector_p,
2346 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2347 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2348 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2349 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2350 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2351 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2352 (roundup_size): New constant.
2353 (struct vector_block): New data type.
2354 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2355 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2356 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2357 (sweep_vectors): New functions.
2358 (allocate_vectorlike): Return `zero_vector' as the only vector of
2359 0 items. Allocate new vector from block if vector size is less than
2360 or equal to VBLOCK_BYTES_MAX.
2361 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2362 (init_alloc_once): Add call to init_vectors.
2363
4f18a4ed
SM
23642012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2365
2366 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2367
86f158bc
PE
23682012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2369
2370 * doprnt.c (doprnt): Truncate multibyte char correctly.
2371 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2372 would mishandle a string argument "Xc" if X was a multibyte
2373 character of length 2: it would truncate after X's first byte
2374 rather than including all of X.
2375
c5cfcbe0
CY
23762012-06-06 Chong Yidong <cyd@gnu.org>
2377
2378 * buffer.c (word_wrap): Doc fix.
2379
c05cf390
PE
23802012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2381
2382 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2383
0c3461de
GM
23842012-06-03 Glenn Morris <rgm@gnu.org>
2385
2386 * xdisp.c (tool-bar-style): Doc fix.
2387
c71232db
UM
23882012-06-03 Ulrich Müller <ulm@gentoo.org>
2389
2390 * Makefile.in (PAXCTL): Define.
2391 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2392 binary via PaX flags if the paxctl utility is available.
2393 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2394 Restore PaX flags to their default. (Bug#11398)
2395
383f7350
CY
23962012-06-03 Chong Yidong <cyd@gnu.org>
2397
2398 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2399 buffer (Bug#11226).
2400
5f2c76c6
CY
24012012-06-03 Chong Yidong <cyd@gnu.org>
2402
2403 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2404 (note_mode_line_or_margin_highlight): If there is no help echo,
2405 use mode-line-default-help-echo. Handle the case where the mouse
2406 position is past the end of the mode line string.
2407
2408 * buffer.c (buffer_local_value_1): New function, split from
2409 Fbuffer_local_value; can return Qunbound.
2410 (Fbuffer_local_value): Use it.
2411 (Vmode_line_format): Docstring tweaks.
2412
773d47f6
PE
24132012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2414
2415 * sysdep.c (system_process_attributes): Improve comment.
2416
f2d6a3df
SM
24172012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2418
2419 * keyboard.c: Export real-this-command to Elisp.
2420 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2421 and DEFVAR it. Update all users.
2422
63810350
PE
24232012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2424
7bd5c1f4
PE
2425 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2426
63810350
PE
2427 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2428 Convert pctcpu and pctmem to Lisp float properly.
2429 Let the compiler fold better, as 100.0/0x8000 is exact.
2430
a2821611
AS
24312012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2432
2433 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2434 cons_block.
2435
5fceba1d
PE
24362012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2437
2438 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2439
c98ff5dd
DA
24402012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2441
2442 For a 'struct window', replace some Lisp_Object fields to
2443 bitfields where appropriate, remove unused fields.
2444 * window.h (struct window): Remove unused 'last_mark_x' and
2445 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2446 change it's type from Lisp_Object to bitfield.
2447 Change type of 'force_start', 'optional_new_start',
2448 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2449 fields from Lisp_Object to bitfield. Adjust users accordingly.
2450
ca34e0be
PE
24512012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2452
2453 Pacify gcc -Wdouble-precision when using Xaw.
2454 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2455 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2456 Use 'float' consistently, rather than 'float' in most places
2457 and 'double' in a couple of places.
2458
efc00ab1 24592012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2460
2461 * xdisp.c (handle_stop): Detect whether we have overlay strings
2462 loaded by testing it->current.overlay_string_index to be
2463 non-negative, instead of checking whether n_overlay_strings is
2464 positive. (Bug#11587)
2465
efc00ab1 24662012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2467
2468 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2469
2470 * doc.c (Fsubstitute_command_keys): Doc fix.
2471
efc00ab1 24722012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2473
2474 * search.c (search_buffer): Remove calls to
2475 r_alloc_inhibit_buffer_relocation, as it is now called by
2476 maybe_unify_char, which was the cause of relocation of buffer text
2477 in bug#11519.
2478
efc00ab1 24792012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2480
2481 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2482 for the duration of call to load_charset, to avoid problems with
2483 callers of maybe_unify_char that access buffer text through C
2484 pointers.
2485
2486 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2487 decrement the inhibition flag, instead of just setting or
2488 resetting it.
2489
ba93a187
PE
24902012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2491
2492 Remove obsolete '#define static' cruft.
2493 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2494 This #undef was "temporary" in 2000; it is no longer needed
2495 now that '#define static' has gone away.
2496 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2497 (gray_bitmap_bits): Remove; no longer needed.
2498 All uses replaced with definiens.
2499 * xterm.c: Include "bitmaps/gray.xbm".
2500
9e4bf381
PE
25012012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2502
2503 Clean up __executable_start, monstartup when --enable-profiling.
2504 The following changes affect the code only when profiling.
2505 * dispnew.c (__executable_start): Rename from safe_bcopy.
2506 Define only on platforms that need it.
2507 * emacs.c: Include <sys/gmon.h> when profiling.
2508 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2509 (__executable_start): Remove decl, since lisp.h does it now.
2510 (safe_bcopy): Remove decl; no longer has that name.
2511 (main): Coalesce #if into single bit of code, for simplicity.
2512 Cast pointers to uintptr_t, since standard libraries want integers
2513 and not pointers.
2514 * lisp.h (__executable_start): New decl.
2515
32d72c2f
GM
25162012-05-31 Glenn Morris <rgm@gnu.org>
2517
2518 * image.c (Fimagemagick_types): Doc fix.
2519
baac5bc7
JM
25202012-05-30 Jim Meyering <meyering@redhat.com>
2521
2522 * callproc.c (Fcall_process_region): Include directory component
2523 in mkstemp error message (Bug#11586).
2524
72cb32cf
PE
25252012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2526
2527 * alloc.c, lisp.h (make_pure_vector): Now static.
2528
61b108cc
SM
25292012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2530
2531 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2532 Move to byte-run.el.
2533 (Fautoload): Do the hash-doc more carefully.
2534 * data.c (Fdefalias): Purify definition, except for keymaps.
2535 (Qdefun): Move from eval.c.
2536 * lisp.h (Qdefun): Remove.
2537 * lread.c (read1): Tiny simplification.
2538
471fe23d
TN
25392012-05-29 Troels Nielsen <bn.troels@gmail.com>
2540
934f3f58 2541 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2542 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2543 Bug#9642, but explicitly check that the buffer the overlay would
2544 be moved to is live and rearrange lines to make sure that errors
2545 will not put the overlay in an inconsistent state.
2546 (Fdelete_overlay): Cosmetics.
2547
85d0efd1
EZ
25482012-05-28 Eli Zaretskii <eliz@gnu.org>
2549
2550 * w32term.c (my_bring_window_to_top): New function.
2551 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2552 could be different from the original one.
2553 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2554 (Bug#11513)
2555
2556 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2557 by calling BringWindowToTop.
2558
2559 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2560 (WM_EMACS_END): Increase by one.
2561
da92a98c
PE
25622012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2563
2564 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2565 This avoids undefined behavior that might cause the eassert
2566 to not catch an out-of-range value.
2567
74d1f848
JB
25682012-05-28 Juanma Barranquero <lekktu@gmail.com>
2569
2570 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2571 Update dependencies.
2572
9e1a06fc
EZ
25732012-05-27 Eli Zaretskii <eliz@gnu.org>
2574
2575 * bidi.c (bidi_mirror_char): Fix last change.
2576
f3dd7312
AS
25772012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2578
2579 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2580 when referring to sectname field in printf format.
2581
81899c91
PE
25822012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2583
57b81a9f
PE
2584 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2585 Only r_alloc_inhibit_buffer_relocation needed to be added;
2586 the others were already declared.
2587
81899c91
PE
2588 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2589 before checking whether it's out of range. Put the check inside
2590 eassert. See
2591 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2592
33017faf 25932012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2594
2595 * callproc.c (Fcall_process): Restore a line that was accidentally
2596 commented out in the 2011-02-13 change (bug#11547).
2597
33017faf 25982012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2599
2600 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2601 defined on ralloc.c.
2602
2603 * buffer.c [REL_ALLOC]: Remove prototypes of
2604 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2605 they are now on lisp.h.
2606
2607 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2608
2609 * search.c (search_buffer): Use it to inhibit relocation of buffer
2610 text while re_search_2 is doing its job, because re_search_2 is
2611 passed C pointers to buffer text. (Bug#11519)
2612
23415acf
EZ
2613 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2614 Update value to 24.
2615
44e27368
EZ
2616 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2617 state after an additional call to move_it_in_display_line_to, keep
2618 the values of it->max_ascent and it->max_descent found for the
2619 entire line.
2620 (pos_visible_p): Revert the comparison against bottom_y to what it
2621 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2622 (Bug#11464)
2623
c1892f11
PE
26242012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2625
2626 Fix coding-related core dumps with gcc -ftrapv.
2627 The code was computing A - B, where A and B are pointers, and B is
2628 random garbage. This can lead to core dumps on platforms that
2629 have special pointer registers, and it also leads to core dumps on
2630 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2631 A - B only when B is initialized properly.
2632 * coding.c (coding_set_source, coding_set_destination): Return void.
2633 (coding_change_source, coding_change_destinations): New functions,
2634 with the old behaviors of coding_set_source and coding_set_destination.
2635 All callers that need an offset changed to use these new functions.
2636
eb7afdad
GM
26372012-05-26 Glenn Morris <rgm@gnu.org>
2638
2639 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2640
f12fdf02
EZ
26412012-05-26 Eli Zaretskii <eliz@gnu.org>
2642
53a63be6 2643 Extend mouse support on W32 text-mode console.
61b108cc
SM
2644 * xdisp.c (draw_row_with_mouse_face):
2645 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2646
eb3f6f01 2647 * w32console.c: Include window.h.
61b108cc
SM
2648 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2649 New functions.
eb3f6f01
EZ
2650 (initialize_w32_display): Initialize mouse-highlight data.
2651
53a63be6
EZ
2652 * w32inevt.c: Include termchar.h and window.h.
2653 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2654 moves, call note_mouse_highlight. If help_echo changed, call
2655 gen_help_event to produce help-echo message in the echo area.
2656 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2657 highlight info.
2658
4cfd81f6
PE
26592012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2660
2661 * lread.c (read1): Simplify slightly to avoid an overflow warning
2662 with GCC 4.7.0 on x86-64.
2663
4446092a
EZ
26642012-05-26 Eli Zaretskii <eliz@gnu.org>
2665
2666 * bidi.c (bidi_mirror_char): Revert last change: an int is
2667 definitely wide enough here.
2668
42b2a986 26692012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2670
42b2a986 2671 Fix integer width and related bugs (Bug#9874).
eb106a49 2672 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2673 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2674 (string_bytes, check_sblock, allocate_string_data):
2675 (compact_small_strings, Fmake_bool_vector, make_string)
2676 (make_unibyte_string, make_multibyte_string)
2677 (make_string_from_bytes, make_specified_string)
2678 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2679 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2680 (mark_vectorlike):
2681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2682 (allocate_pseudovector):
2683 Use int, not EMACS_INT, where int is wide enough.
2684 (inhibit_garbage_collection, Fgarbage_collect):
2685 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2686 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2687 int might not be wide enough.
2688 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2689 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2690 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2691 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2692 (bidi_level_of_next_char, bidi_move_to_visually_next):
2693 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2694 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2695 (Fkill_buffer, Fset_buffer_major_mode)
2696 (advance_to_char_boundary, Fbuffer_swap_text)
2697 (Fset_buffer_multibyte, overlays_at, overlays_in)
2698 (overlay_touches_p, struct sortvec, record_overlay_string)
2699 (overlay_strings, recenter_overlay_lists)
2700 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2701 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2702 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2703 (Foverlay_recenter, last_overlay_modification_hooks_used)
2704 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2706 (validate_region): Omit unnecessary test for b <= e,
2707 since that's guaranteed by the previous test.
d311d28c
PE
2708 (adjust_overlays_for_delete): Avoid pos + length overflow.
2709 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2710 (report_overlay_modification):
2711 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2712 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2713 Omit pointer cast, which isn't needed anyway, and doesn't work
2714 after the EMACS_INT -> ptrdiff_t change.
02481186 2715 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2716 * buffer.h: Adjust decls to match defn changes elsewhere.
2717 (struct buffer_text, struct buffer):
2718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2719 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2720 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2721 not int, to avoid needless 32-bit limit on 64-bit hosts.
2722 (exec_byte_code): Use tighter memory-full test, one that checks
2723 for alloca overflow. Don't compute the address of the object just
2724 before an array, as that's not portable. Use EMACS_INT, not
2725 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2726 * callint.c (Fcall_interactively):
2727 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2728 * callproc.c (call_process_kill, Fcall_process):
2729 Don't assume pid_t fits into an Emacs fixnum.
2730 (call_process_cleanup, Fcall_process, child_setup):
2731 Don't assume pid_t fits into int.
2732 (call_process_cleanup, Fcall_process, delete_temp_file)
2733 (Fcall_process_region):
2734 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2735 (Fcall_process): Simplify handling of volatile integers.
2736 Use int, not EMACS_INT, where int will do.
2737 * casefiddle.c (casify_object, casify_region, operate_on_word)
2738 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2739 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2740 (casify_object): Avoid integer overflow when overallocating buffer.
2741 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2742 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2743 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2744 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2745 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2746 integers are now checked earlier. All uses replaced with XINT.
2747 (ccl_driver):
2748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2749 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2750 (ccl_driver, Fregister_code_conversion_map):
2751 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2752 (resolve_symbol_ccl_program): Check that vector header is in range.
2753 Always copy the vector, so that we can check its contents reliably
2754 now rather than having to recheck each instruction as it's being
2755 executed. Check that vector words fit in 'int'.
2756 (ccl_get_compiled_code, Fregister_ccl_program)
2757 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2758 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2759 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2760 contents are in range.
2761 (Fccl_execute_on_string): Check that status is in range.
2762 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2763 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2764 Accept and return EMACS_INT, not int, because callers can pass values
2765 out of 'int' range.
2766 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2767 (multibyte_chars_in_text, parse_str_as_multibyte)
2768 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2769 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2770 (string_escape_byte8, Fget_byte):
2771 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2772 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2773 avoid mishandling large integers.
2774 * character.h: Adjust decls to match defn changes elsewhere.
2775 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2776 (Ffind_charset_region):
2777 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2778 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2779 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2780 Don't assume fixnum fits in int.
d311d28c
PE
2781 (load_charset_map_from_vector, Fmap_charset_chars):
2782 Remove now-unnecessary CHECK_NATNUMs.
2783 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2784 Don't rely on undefined behavior with signed left shift overflow.
2785 Don't assume unsigned int fits into fixnum, or that fixnum fits
2786 into unsigned int. Don't require max_code to be a valid fixnum;
2787 that's not true for gb10830 4-byte on a 32-bit host. Allow
2788 invalid_code to be a cons, for the same reason. Require code_offset
2789 to be a character. Avoid int overflow if max_char is close
2790 to INT_MAX.
2791 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2792 this is intended anyway and avoids some undefined behavior.
2793 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2794 INDEX_TO_CODE_POINT, as that's what it expects.
2795 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2796 * charset.h (DECODE_CHAR): Return int, not unsigned;
2797 this is what was intended anyway, and it avoids undefined behavior.
2798 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2799 integer-overflow issues.
2800 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2801 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2802 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2803 * chartab.c (Fmake_char_table, Fset_char_table_range)
2804 (uniprop_get_decoder, uniprop_get_encoder):
2805 Don't assume fixnum fits in int.
2806 * cmds.c (move_point): New function, that does the gist of
2807 Fforward_char and Fbackward_char, but does so while checking
2808 for integer overflow more accurately.
c96e5d6a 2809 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2810 (Fforward_line, Fend_of_line, internal_self_insert)
2811 (internal_self_insert):
2812 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2813 Fix a FIXME, by checking for integer overflow when calculating
2814 target_clm and actual_clm.
2815 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2816 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2817 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2818 (coding_alloc_by_making_gap, alloc_destination)
2819 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2820 (encode_coding_utf_16, detect_coding_emacs_mule)
2821 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2822 (detect_coding_iso_2022, decode_coding_iso_2022)
2823 (encode_invocation_designation, encode_designation_at_bol)
2824 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2825 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2826 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2827 (encode_coding_ccl, encode_coding_raw_text)
2828 (detect_coding_charset, decode_coding_charset)
2829 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2830 (produce_composition, produce_charset, produce_annotation)
2831 (decode_coding, handle_composition_annotation)
2832 (handle_charset_annotation, consume_chars, decode_coding_gap)
2833 (decode_coding_object, encode_coding_object, detect_coding_system)
2834 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2835 (code_convert_region, code_convert_string)
8f50130c
PE
2836 (Fdefine_coding_system_internal)
2837 (coding_set_source, coding_set_destination):
d311d28c
PE
2838 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2839 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2840 (Fdefine_coding_system_internal):
2841 Don't assume fixnums fit in int.
2842 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2843 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2844 (Funencodable_char_position, Fcheck_coding_systems_region)
2845 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2846 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2847 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2848 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2849 Don't access memory outside of the args array.
d311d28c 2850 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2851 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2852 result of ENCODE_CHAR.
d311d28c
PE
2853 * coding.h: Adjust decls to match defn changes elsewhere.
2854 (struct coding_system):
2855 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2856 * composite.c (get_composition_id, find_composition)
2857 (run_composition_function, update_compositions)
2858 (compose_text, composition_gstring_put_cache)
2859 (composition_gstring_p, composition_gstring_width)
2860 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2861 (composition_compute_stop_pos, composition_reseat_it)
2862 (composition_update_it, struct position_record)
2863 (find_automatic_composition, composition_adjust_point)
2864 (Fcomposition_get_gstring, Ffind_composition_internal):
2865 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2866 (update_compositions):
2867 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2868 * composite.h: Adjust decls to match defn changes elsewhere.
2869 (struct composition):
2870 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2871 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2872 Do not attempt to compute the address of the object just before a
2873 buffer; this is not portable.
2874 (Faref, Faset):
2875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2876 (Faset): Use int, not EMACS_INT, where int is wide enough.
2877 (Fstring_to_number): Don't assume fixnums fit in int.
2878 (Frem): Don't assume arg is nonnegative.
2879 * dbusbind.c (xd_append_arg): Check for integers out of range.
2880 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2881 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2882 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2883 (xd_get_connection_references): Return ptrdiff_t, not int.
2884 All uses changed.
2885 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2886 (xd_read_message_1):
2887 Use int, not unsigned, where the dbus API uses int.
2888 (Fdbus_message_internal): Don't overflow mtype.
2889 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2890 * dired.c (directory_files_internal, file_name_completion, scmp)
2891 (file_name_completion_stat):
2892 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2893 (file_name_completion): Don't overflow matchcount.
2894 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2895 * dispextern.h: Adjust decls to match defn changes elsewhere.
2896 (struct text_pos, struct glyph, struct bidi_saved_info)
2897 (struct bidi_string_data, struct bidi_it, struct composition_it)
2898 (struct it):
2899 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2900 (struct display_pos, struct composition_it, struct it):
2901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2902 * dispnew.c (increment_matrix_positions)
2903 (increment_row_positions, mode_line_string)
2904 (marginal_area_string):
2905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2906 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2907 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2908 (duration_to_sec_usec): New function, to check for overflow better.
2909 (Fsleep_for, sit_for): Use it.
2910 * doc.c (get_doc_string, store_function_docstring):
2911 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2912 (get_doc_string, Fsnarf_documentation):
2913 Use int, not EMACS_INT, where int is wide enough.
2914 (get_doc_string):
2915 Use SAFE_ALLOCA, not alloca.
2916 Check for overflow when converting EMACS_INT to off_t.
2917 * doprnt.c (doprnt):
2918 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2919 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2920 Don't assume uid_t fits into fixnum.
2921 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2922 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2923 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2924 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2925 (general_insert_function)
2926 (Finsert_char, make_buffer_string, make_buffer_string_both)
2927 (update_buffer_properties, Fbuffer_substring)
2928 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2929 (Fsubst_char_in_region, check_translation)
2930 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2931 (transpose_markers, Ftranspose_regions):
2932 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2933 (clip_to_bounds): Move to lisp.h as an inline function).
2934 (Fconstrain_to_field): Don't assume integers are nonnegative.
2935 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2936 (Fsubst_char_in_region, Fsave_restriction):
2937 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2938 (Femacs_pid): Don't assume pid_t fits into fixnum.
2939 (lo_time): Use int, not EMACS_INT, when int suffices.
2940 (lisp_time_argument): Check for usec out of range.
2941 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2942 (Fuser_login_name, Fuser_full_name): Signal an error
2943 if a uid argument is out of range, rather than relying on
2944 undefined behavior.
c8d5c857
PE
2945 (Fformat_time_string): Remove now-unnecessary check.
2946 lisp_time_argument checks for out-of-range usec now.
243e0530 2947 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2948 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2949 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2950 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2951 (init_cmdargs, Fdump_emacs):
2952 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2953 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2954 the bottom (typically) 32 bits of the fixnum.
2955 * eval.c (specpdl_size, call_debugger):
2956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2957 (when_entered_debugger, Fbacktrace_debug):
2958 Don't assume fixnum can fit in int.
2959 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2960 the object just before a buffer; this is not portable.
2961 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2962 (grow_specpdl, unbind_to):
2963 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2964 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2965 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2966 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2967 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2968 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2969 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2970 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2971 (a_write, e_write):
2972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2973 (Fcopy_file, non_regular_nbytes, read_non_regular)
2974 (Finsert_file_contents):
2975 Use int, not EMACS_INT, where int is wide enough.
2976 (READ_BUF_SIZE): Verify that it fits in int.
2977 (Finsert_file_contents): Check that counts are in proper range,
2978 rather than assuming fixnums fit into ptrdiff_t etc.
2979 Don't assume fixnums fit into int.
125b3835 2980 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2981 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2982 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2983 (string_char_to_byte, string_byte_to_char)
2984 (string_make_multibyte, string_to_multibyte)
2985 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2986 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2987 (substring_both, Fdelete, internal_equal, Ffillarray)
2988 (Fclear_string, mapcar1)
2989 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2990 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2991 (larger_vector, make_hash_table, maybe_resize_hash_table)
2992 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2993 (Fmaphash, secure_hash):
2994 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2995 (concat): Check for string index and length overflow.
2996 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2997 (Frequire):
2998 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2999 (larger_vector): New API (vec, incr_min, size_max) replaces old
3000 one (vec, new_size, init). This catches size overflow.
3001 INIT was removed because it was always Qnil.
3002 All callers changed.
3003 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3004 the upper bound on a hash table index size.
3005 (make_hash_table, maybe_resize_hash_table): Use it.
3006 (secure_hash): Computer start_byte and end_byte only after
3007 they're known to be in ptrdiff_t range.
3008 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3009 (Ffont_get_glyphs, Ffont_at):
3010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3011 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3012 (Flist_fonts, Fopen_font):
3013 Don't assume fixnum can fit in int.
3014 (check_gstring): Don't assume index can fit in int.
3015 (font_match_p): Check that fixnum is a character, not a nonnegative
3016 fixnum, since the later code needs to stuff it into an int.
3017 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3018 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3019 conversion overflow issues.
3020 (Fopen_font): Check for integer out of range.
3021 (Ffont_get_glyphs): Don't assume index can fit in int.
3022 * font.h: Adjust decls to match defn changes elsewhere.
3023 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3024 integer overflow.
3025 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3026 printmax_t, where ptrdiff_t is wide enough.
3027 (Finternal_char_font):
3028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3029 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3030 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3031 (Fset_frame_position, x_set_frame_parameters)
3032 (x_set_line_spacing, x_set_border_width)
3033 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3034 Check that fixnums are in proper range for system types.
3035 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3037 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3038 Use SAFE_ALLOCA_LISP, not alloca.
3039 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3040 intptr_t is wide enough.
3041 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3042 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3043 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3044 Check for fixnum out of range.
3045 * ftfont.c (ftfont_list): Don't assume index fits in int.
3046 Check that fixnums are in proper range for system types.
3047 (ftfont_shape_by_flt):
3048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3049 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3050 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3051 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3052 Check that fixnums are in proper range for system types.
3053 * gnutls.h: Adjust decls to match defn changes elsewhere.
3054 * gtkutil.c (xg_dialog_run):
3055 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3056 (update_frame_tool_bar):
3057 Check that fixnums are in proper range for system types.
3058 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3059 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3060 * indent.c (last_known_column, last_known_column_point):
3061 (current_column_bol_cache):
3062 (skip_invisible, current_column, check_display_width):
3063 (check_display_width, scan_for_column, current_column_1)
3064 (Findent_to, Fcurrent_indentation, position_indentation)
3065 (indented_beyond_p, Fmove_to_column, compute_motion):
3066 (Fcompute_motion, Fvertical_motion):
3067 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3068 (last_known_column_modified): Use EMACS_INT, not int.
3069 (check_display_width):
3070 (Fcompute_motion):
3071 Check that fixnums and floats are in proper range for system types.
3072 (compute_motion): Don't assume index or fixnum fits in int.
3073 (compute_motion, Fcompute_motion):
3074 Use int, not EMACS_INT, when it is wide enough.
3075 (vmotion): Omit local var start_hpos that is always 0; that way
3076 we don't need to worry about overflow in expressions involving it.
3077 * indent.h: Adjust decls to match defn changes elsewhere.
3078 (struct position):
3079 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3080 Use int, not EMACS_INT, where int is wide enough.
3081 Remove unused members ovstring_chars_done and tab_offset;
3082 all uses removed.
3083 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3084 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3085 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3086 (make_gap, copy_text, insert, insert_and_inherit)
3087 (insert_before_markers, insert_before_markers_and_inherit)
3088 (insert_1, count_combining_before, count_combining_after)
3089 (insert_1_both, insert_from_string)
3090 (insert_from_string_before_markers, insert_from_string_1)
3091 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3092 (adjust_after_replace, adjust_after_insert, replace_range)
3093 (replace_range_2, del_range, del_range_1, del_range_byte)
3094 (del_range_both, del_range_2, modify_region)
3095 (prepare_to_modify_buffer, signal_before_change)
3096 (signal_after_change, Fcombine_after_change_execute):
3097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3098 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3099 (balance_an_interval, split_interval_right, split_interval_left)
3100 (find_interval, next_interval, update_interval)
3101 (adjust_intervals_for_insertion, delete_node, delete_interval)
3102 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3103 (static_offset_intervals, offset_intervals)
3104 (merge_interval_right, merge_interval_left, make_new_interval)
3105 (graft_intervals_into_buffer, temp_set_point_both)
3106 (temp_set_point, set_point, adjust_for_invis_intang)
3107 (set_point_both, move_if_not_intangible, get_property_and_range)
3108 (get_local_map, copy_intervals, copy_intervals_to_string)
3109 (compare_string_intervals, set_intervals_multibyte_1):
3110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3111 * intervals.h: Adjust decls to match defn changes elsewhere.
3112 (struct interval):
3113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3114 * keyboard.c (this_command_key_count, this_single_command_key_start)
3115 (before_command_key_count, before_command_echo_length, echo_now)
3116 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3117 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3118 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3119 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3120 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3121 (last_non_minibuf_size, last_point_position, echo_truncate)
3122 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3123 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3124 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3125 (stuff_buffered_input):
3126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3127 (last_auto_save, command_loop_1, read_char):
3128 Use EMACS_INT, not int, to avoid integer overflow.
3129 (record_char): Avoid overflow in total_keys computation.
3130 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3131 * keyboard.h: Adjust decls to match defn changes elsewhere.
3132 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3133 (Fkey_description, Fdescribe_vector, Flookup_key):
3134 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3135 (click_position): New function, to check that positions are in range.
3136 (Fcurrent_active_maps):
3137 (describe_command):
3138 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3139 (Faccessible_keymaps, Fkey_description):
3140 (preferred_sequence_p):
3141 Don't assume fixnum can fit into int.
3142 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3143 Check for integer overflow in size calculations.
3144 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3145 avoid mishandling large integers.
3146 * lisp.h: Adjust decls to match defn changes elsewhere.
3147 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3148 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3149 (struct Lisp_Marker):
3150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3151 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3152 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3153 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3154 All callers changed.
3155 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3156 Assume the arg has valid form, since it always does.
3157 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3158 unsigned integer system type.
3159 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3160 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3162 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3163 (duration_to_sec_usec): New decl.
3164 * lread.c (read_from_string_index, read_from_string_index_byte)
3165 (read_from_string_limit, readchar, unreadchar, openp)
3166 (read_internal_start, read1, oblookup):
3167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3168 (Fload, readevalloop, Feval_buffer, Feval_region):
3169 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3170 (openp): Check for out-of-range argument to 'access'.
3171 (read1): Use int, not EMACS_INT, where int is wide enough.
3172 Don't assume fixnum fits into int.
6efdadfd 3173 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3174 (read_filtered_event): Use duration_to_sec_usec
3175 to do proper overflow checking on durations.
d311d28c
PE
3176 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3177 in size calculation.
3178 (Fexecute_kbd_macro):
3179 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3180 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3181 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3182 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3183 (set_marker_both, set_marker_restricted_both, marker_position)
3184 (marker_byte_position, Fbuffer_has_markers_at):
3185 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3186 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3187 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3188 It now merely ensures that the menu is large enough, without
3189 necessarily growing it, as this avoids some integer overflow issues.
3190 All callers changed.
3191 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3192 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3193 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3194 Use SAFE_ALLOCA_LISP, not alloca.
3195 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3196 to EMACS_INT. Check that fixnums are in proper range for system types.
3197 * minibuf.c (minibuf_prompt_width, string_to_object)
3198 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3199 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3201 (get_minibuffer, read_minibuf_unwind):
3202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3203 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3204 this simplifies overflow checking. All callers changed.
3205 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3206 (Ftest_completion):
3207 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3208 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3209 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3210 Check that fixnums are in proper range for system types.
3211 (Fx_create_frame, Fx_show_tip):
3212 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3213 * nsfont.m (ns_findfonts, nsfont_list_family):
3214 Don't assume fixnum fits in long.
3215 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3216 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3217 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3218 wide enough.
17fdb222 3219 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3220 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3221 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3222 (PRINTDECLARE, PRINTPREPARE):
3223 (strout, print_string):
3224 (print, print_preprocess, print_check_string_charset_prop)
3225 (print_object):
3226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3227 (PRINTDECLARE):
3228 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3230 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3231 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3232 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3233 (print_error_message): Use SAFE_ALLOCA, not alloca.
3234 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3235 (print_depth, new_backquote_output, print_number_index):
3236 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3237 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3238 (Fset_process_window_size, Fformat_network_address)
3239 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3240 (sigchld_handler):
d311d28c 3241 Check that fixnums are in proper range for system types.
d44287d4 3242 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3243 Check for process-ids out of pid_t range rather than relying on
3244 undefined behavior.
e4d81efc 3245 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3246 (Fformat_network_address, read_process_output, send_process)
3247 (Fprocess_send_region, status_notify):
3248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3249 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3250 (wait_reading_process_output, read_process_output, exec_sentinel):
3251 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3252 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3253 (Faccept_process_output): Use duration_to_sec_usec to do proper
3254 overflow checking on durations.
dde14581
PE
3255 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3256 Don't assume pid_t fits in int.
02481186
PE
3257 * process.h (struct Lisp_Process): Members tick and update_tick
3258 are now of type EMACS_INT, not int.
b62b53e8
PE
3259 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3260 configured --with-wide-int.
d311d28c
PE
3261 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3262 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3263 * search.c (looking_at_1, string_match_1):
3264 (fast_string_match, fast_c_string_match_ignore_case)
3265 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3266 (scan_newline, find_before_next_newline, search_command)
3267 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3268 (set_search_regs, wordify):
3269 (Freplace_match):
3270 (Fmatch_data):
3271 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3272 (string_match_1, search_buffer, set_search_regs):
3273 (Fmatch_data):
3274 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3275 (wordify): Check for overflow in size calculation.
3276 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3277 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3278 Check that fixnums are in proper range for system types.
3279 * sound.c (struct sound_device)
3280 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3282 (Fplay_sound_internal):
3283 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3284 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3285 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3286 (Fparse_partial_sexp):
3287 Don't assume fixnums can fit in int.
3288 (struct lisp_parse_state, find_start_pos, find_start_value)
3289 (find_start_value_byte, find_start_begv)
3290 (update_syntax_table, char_quoted, dec_bytepos)
3291 (find_defun_start, prev_char_comend_first, back_comment):
3292 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3293 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3295 (Finternal_describe_syntax_value): Check that match_lisp is a
3296 character, not an integer, since the code stuffs it into int.
3297 (scan_words, scan_sexps_forward):
3298 Check that fixnums are in proper range for system types.
3299 (Fforward_word):
3300 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3301 (scan_sexps_forward):
3302 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3303 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3304 * syntax.h: Adjust decls to match defn changes elsewhere.
3305 (struct gl_state_s):
3306 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3307 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3308 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3309 * sysdep.c (wait_for_termination_1, wait_for_termination)
3310 (interruptible_wait_for_termination, mkdir):
3311 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3312 (emacs_read, emacs_write):
3313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3314 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3315 and double all fit in int.
d311d28c
PE
3316 * term.c (set_tty_color_mode):
3317 Check that fixnums are in proper range for system types.
3318 * termhooks.h (struct input_event):
3319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3320 * textprop.c (validate_interval_range, interval_of)
3321 (Fadd_text_properties, set_text_properties_1)
3322 (Fremove_text_properties, Fremove_list_of_text_properties)
3323 (Ftext_property_any, Ftext_property_not_all)
3324 (copy_text_properties, text_property_list, extend_property_ranges)
3325 (verify_interval_modification):
3326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3327 (Fnext_single_char_property_change)
3328 (Fprevious_single_char_property_change):
3329 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3330 (copy_text_properties):
3331 Check for integer overflow in index calculation.
d311d28c
PE
3332 * undo.c (last_boundary_position, record_point, record_insert)
3333 (record_delete, record_marker_adjustment, record_change)
3334 (record_property_change):
3335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3336 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3337 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3338 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3339 (Fx_hide_tip, Fx_file_dialog):
3340 * w32menu.c (set_frame_menubar):
3341 Use ptrdiff_t, not int, for consistency with rest of code.
3342 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3343 (select_window, Fdelete_other_windows_internal)
3344 (window_scroll_pixel_based, window_scroll_line_based)
3345 (Frecenter, Fset_window_configuration):
3346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3347 (Fset_window_hscroll, run_window_configuration_change_hook)
3348 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3349 (Fscroll_other_window, Frecenter):
d311d28c
PE
3350 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3351 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3352 Don't assume fixnum fits in int.
3353 (Fset_window_scroll_bars):
3354 Check that fixnums are in proper range for system types.
3355 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3356 (string_pos, c_string_pos, number_of_chars, init_iterator)
3357 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3358 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3359 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3360 (face_before_or_after_it_pos, handle_invisible_prop)
3361 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3362 (display_prop_intangible_p, string_buffer_position_lim)
3363 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3364 (get_overlay_strings_1, get_overlay_strings)
3365 (iterate_out_of_display_property, forward_to_next_line_start)
3366 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3367 (get_next_display_element, set_iterator_to_next)
3368 (get_visually_first_element, compute_stop_pos_backwards)
3369 (handle_stop_backwards, next_element_from_buffer)
3370 (move_it_in_display_line_to, move_it_in_display_line)
3371 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3372 (add_to_log, message_dolog, message_log_check_duplicate)
3373 (message2, message2_nolog, message3, message3_nolog
3374 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3375 (current_message_1, truncate_echo_area, truncate_message_1)
3376 (set_message, set_message_1, store_mode_line_noprop)
3377 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3378 (text_outside_line_unchanged_p, check_point_in_composition)
3379 (reconsider_clip_changes)
3380 (redisplay_internal, set_cursor_from_row, try_scrolling)
3381 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3382 (redisplay_window, find_last_unchanged_at_beg_row)
3383 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3384 (trailing_whitespace_p, find_row_edges, display_line)
3385 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3386 (display_mode_element, store_mode_line_string)
3387 (pint2str, pint2hrstr, decode_mode_spec)
3388 (display_count_lines, display_string, draw_glyphs)
3389 (x_produce_glyphs, x_insert_glyphs)
3390 (rows_from_pos_range, mouse_face_from_buffer_pos)
3391 (fast_find_string_pos, mouse_face_from_string_pos)
3392 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3394 (safe_call, init_from_display_pos, handle_fontified_prop)
3395 (handle_single_display_spec, load_overlay_strings)
3396 (with_echo_area_buffer, setup_echo_area_for_printing)
3397 (display_echo_area, echo_area_display)
3398 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3399 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3400 (redisplay_window, dump_glyph_row, display_mode_line)
3401 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3402 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3403 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3404 (handle_single_display_spec, build_desired_tool_bar_string)
3405 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3406 (get_specified_cursor_type):
3407 Check that fixnums are in proper range for system types.
3408 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3409 (Flookup_image_map):
3410 Don't assume fixnums fit in int.
3411 (compare_overlay_entries):
3412 Avoid mishandling comparisons due to subtraction overflow.
3413 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3414 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3415 (handle_tool_bar_click):
3416 Use int, not unsigned, since we prefer signed and the signedness
3417 doesn't matter here.
3418 (get_next_display_element, next_element_from_display_vector):
3419 Use int, not EMACS_INT, when int is wide enough.
3420 (start_hourglass): Use duration_to_sec_usec to do proper
3421 overflow checking on durations.
3422 * xfaces.c (Fbitmap_spec_p):
3423 Check that fixnums are in proper range for system types.
3424 (compare_fonts_by_sort_order):
3425 Avoid mishandling comparisons due to subtraction overflow.
3426 (Fx_family_fonts, realize_basic_faces):
3427 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3428 (Fx_family_fonts):
3429 Don't assume fixnum fits in int.
3430 Use SAFE_ALLOCA_LISP, not alloca.
3431 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3432 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3433 (face_at_buffer_position, face_for_overlay_string)
3434 (face_at_string_position):
3435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3436 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3437 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3438 (Fx_show_tip):
3439 Check that fixnums are in proper range for system types.
3440 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3441 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3442 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3443 (Fx_change_window_property): Don't assume fixnums fit in int.
3444 * xfont.c (xfont_chars_supported):
3445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3446 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3447 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3448 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3449 * xml.c (parse_region):
3450 * xrdb.c (magic_file_p):
3451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3452 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3453 (x_get_local_selection, x_reply_selection_request)
3454 (x_handle_selection_request, wait_for_property_change):
3455 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3456 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3457 short is wide enough.
3458 (x_send_client_event): Don't assume fixnum fits in int.
3459 * xterm.c (x_x_to_emacs_modifiers):
3460 Don't assume EMACS_INT overflows nicely into int.
3461 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3462 may come from Lisp.
3463 (handle_one_xevent): NATNUMP can eval its arg twice.
3464 (x_connection_closed):
3465 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3466 * xterm.h: Adjust decls to match defn changes elsewhere.
3467 (struct scroll_bar): Use struct vectorlike_header
3468 rather than rolling our own approximation.
3469 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3470
c6574eb5
GM
34712012-05-25 Glenn Morris <rgm@gnu.org>
3472
3473 * lisp.mk (lisp): Update for more files being compiled now.
3474
e8d32c7e
SM
34752012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3476
48def666
SM
3477 * lread.c: Remove `read_pure' which makes no difference.
3478 (read_pure): Remove var.
3479 (unreadpure): Remove function.
3480 (readevalloop): Don't call read_list with -1 flag.
3481 (read1, read_vector): Don't test read_pure any more.
3482 (read_list): Simplify.
3483
e8d32c7e
SM
3484 * fileio.c, character.h: Minor style tweaks.
3485
4b2addb7
DA
34862012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3487
3488 * window.h (clip_changed): Remove useless declaration.
3489
584461b2
JB
34902012-05-22 Juanma Barranquero <lekktu@gmail.com>
3491
3492 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3493 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3494
34374650
PE
34952012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3496
3497 Remove src/m/*.
3498 This directory predates autoconf and is no longer needed nowadays.
3499 Move its few remaining bits of functionality to where they're needed.
3500 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3501 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3502 * m/template.h: Remove.
3503 * Makefile.in (M_FILE): Remove. All uses removed.
3504 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3505 * lisp.h (USE_LSB_TAG):
3506 * mem-limits.h (EXCEEDS_LISP_PTR):
3507 Use VAL_MAX, not VALBITS, in #if.
3508 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3509 (EMACS_UINT): Define unconditionally now.
3510 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3511 (BITS_PER_EMACS_INT): New constants, replacing
3512 what used to be in config.h, but not useful in #if.
3513 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3514 define them any more.
3515 (VAL_MAX): New macro.
3516 (VALMASK): Use it.
3517 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3518 BITS_PER_EMACS_INT, in #if.
3519 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3520 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3521 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3522 * s/ms-w32.h (DATA_START):
3523 Move here from removed file m/intel386.h.
3524 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3525 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3526
261cb4bb
PE
35272012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3528
3529 Assume C89 or later.
3530 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3531 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3532 (xrealloc):
3533 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3534 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3535 * textprop.c, tparam.c (NULL): Remove.
3536 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3537 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3538 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3539 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3540 * xterm.c (input_signal_count): Assume volatile works.
3541
ff23cd9f
KB
35422012-05-21 Ken Brown <kbrown@cornell.edu>
3543
3544 * xgselect.c (xg_select): Fix first argument in call to 'select'
3545 (bug#11508).
3546
1b170bc6
KB
35472012-05-20 Ken Brown <kbrown@cornell.edu>
3548
3549 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3550 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3551
b2f4d39f
KB
35522012-05-19 Ken Brown <kbrown@cornell.edu>
3553
3554 * xfns.c (x_in_use): Remove `static' qualifier.
3555 * xterm.h (x_in_use): Declare.
3556 * xgselect.c: Include xterm.h.
3557 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3558 and `display_arg' (bug#9754).
3559
003fdae2
PE
35602012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3561
9232a6d9
PE
3562 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3563
003fdae2
PE
3564 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3565 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3566
784b56e2
EZ
35672012-05-18 Eli Zaretskii <eliz@gnu.org>
3568
3569 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3570
3571 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3572 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3573
3574 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3575 reference to image_cache->refcount.
3576 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3577
a0a79cde
JL
35782012-05-17 Juri Linkov <juri@jurta.org>
3579
3580 * search.c (Fword_search_regexp, Fword_search_backward)
3581 (Fword_search_forward, Fword_search_backward_lax)
3582 (Fword_search_forward_lax): Move functions to isearch.el
3583 (bug#10145, bug#11381).
3584
b0572523
PE
35852012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3586
3587 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3588
9660f5fc
SM
35892012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3590
3591 * lread.c (init_obarray): Declare Qt and Qnil as special.
3592
4374de83
GM
35932012-05-14 Glenn Morris <rgm@gnu.org>
3594
3595 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3596 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3597
dc44c39a
PE
35982012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3599
078c97cb
PE
3600 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3601
dc44c39a
PE
3602 * unexaix.c: Port to more-recent AIX compilers.
3603 (report_error, report_error_1, make_hdr, copy_sym)
3604 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3605 Make arguments const char *, not char *, to avoid violations of C
3606 standard and to fix some AIX warnings reported by Gilles Pion.
3607
e18afed7 36082012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3609
3610 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3611 already have overlays loaded.
3612 (handle_single_display_spec): Before returning without displaying
3613 fringe bitmap, synchronize the bidi iterator with the main display
3614 iterator, by calling iterate_out_of_display_property.
3615 (iterate_out_of_display_property): Detect buffer iteration by
3616 testing that it->string is a Lisp string.
3617 (get_next_display_element): When the current object is exhausted,
3618 and there's something on it->stack, call set_iterator_to_next to
3619 proceed with what's on the stack, instead of returning zero.
3620 (set_iterator_to_next): If called at the end of a Lisp string,
3621 proceed to consider_string_end without incrementing string
3622 position. Don't increment display vector index past the end of
3623 the display vector. (Bug#11417)
c8fb9dc6
EZ
3624 (pos_visible_p): Don't report a position visible when move_it_to
3625 stopped at the last line of window, which happens to be scanned
3626 backwards by the bidi iteration. (Bug#11464)
ac268e67 3627
e18afed7 36282012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3629
3630 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3631 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3632 are on a TTY, and thus unable to display on the fringes.
3633 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3634 so we need to signal to the caller that this is a "replacing"
3635 display spec. This fixes display when the spec is invalid or we
3636 are on a TTY.
3637
e18afed7 36382012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3639
3640 * unexaix.c (make_hdr): Fix typo in prototype.
3641 This bug broke the build on AIX. Problem reported by Gilles Pion.
3642
9d0a235a
MA
36432012-05-14 Michael Albinus <michael.albinus@gmx.de>
3644
3645 * keyboard.c (kbd_buffer_get_event): Read special events also in
3646 batch mode. (Bug#11415)
3647
9e6b06ed
GM
36482012-05-12 Glenn Morris <rgm@gnu.org>
3649
3650 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3651
c1a1d7a3
EZ
36522012-05-12 Eli Zaretskii <eliz@gnu.org>
3653
3654 * lisp.mk (lisp): Add newcomment.elc.
3655
3fe7cdc8
GM
36562012-05-12 Glenn Morris <rgm@gnu.org>
3657
3658 * Makefile.in (MKDIR_P): New, set by configure.
3659 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3660
53f7d2c0
PE
36612012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3662
3663 Remove unused function hourglass_started.
3664 * dispextern.h (hourglass_started):
3665 * w32fns.c (hourglass_started):
3666 * xdisp.c (hourglass_started): Remove.
3667
75aafb17
JB
36682012-05-10 Juanma Barranquero <lekktu@gmail.com>
3669
3670 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3671 Update dependencies.
3672
12959e8e
PE
36732012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3674
97107e2e
PE
3675 * xgselect.c (xg_select): Put maxfds+1 into a var.
3676 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3677
12959e8e
PE
3678 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3679
836d29b3
DA
36802012-05-10 Dave Abrahams <dave@boostpro.com>
3681
3682 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3683 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3684
5cb67954
MA
36852012-05-09 Michael Albinus <michael.albinus@gmx.de>
3686
3687 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3688 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3689 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3690 Initialize xd_registered_buses.
3691
3478ec45
PE
36922012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3693
b263a6b0
PE
3694 Untag more efficiently if USE_LSB_TAG.
3695 This is based on a proposal by YAMAMOTO Mitsuharu in
3696 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3697 For an admittedly artificial (nth 8000 longlist) benchmark on
3698 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3699 Emacs's overall text size by 1%.
3700 * lisp.h (XUNTAG): New macro.
3701 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3702 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3703 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3704 * eval.c (Fautoload):
3705 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3706 * frame.h (XFRAME): Use XUNTAG.
3707
3478ec45
PE
3708 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3709 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3710 Remove unportable assumptions about print widths of types like
3711 dbus_uint32_t.
3712 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3713 intptr_t when converting between pointer and integer, to avoid GCC
3714 warnings about wrong width.
3715
666b903b 37162012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3717
3718 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3719 stack for each reader_thread, instead of defaulting to 8MB
3720 determined by the linker. This avoids failures in creating
3721 subprocesses on Windows 7, see the discussion in this thread:
3722 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3723
b120cc17
JC
37242012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3725
3726 Fix up display of the *Minibuf-0* buffer in the mini window.
3727 * keyboard.c (read_char): Don't clear the echo area if there's no
3728 message to clear.
3729 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3730 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3731
9a4b36f8
MA
37322012-05-07 Michael Albinus <michael.albinus@gmx.de>
3733
3734 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3735 batch mode.
3736
e5f9458f
CY
37372012-05-06 Chong Yidong <cyd@gnu.org>
3738
3739 * lisp.mk (lisp): Update.
3740
eceeb5fc 37412012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3742
3743 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3744
71873e2b
SM
37452012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3746
3747 * data.c (PUT_ERROR): New macro.
3748 (syms_of_data): Use it. Add new error type `user-error'.
3749 * undo.c (user_error): New function.
3750 (Fprimitive_undo): Use it.
3751 * print.c (print_error_message): Adjust print style for `user-error'.
3752 * keyboard.c (user_error): New function.
3753 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3754
ab0fa4e4
PE
37552012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3756
3757 Do not limit current-time-string to years 1000..9999.
3758 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3759 (Fcurrent_time_string): Support any year that is supported by the
3760 underlying localtime representation. Don't use asctime, as it
3761 has undefined behavior for years outside the range -999..9999.
3762
7ed806a7
PE
37632012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3764
3765 Fix race conditions involving setenv, gmtime, localtime, asctime.
3766 Without this fix, interrupts could mess up code that uses these
3767 nonreentrant functions, since setting TZ invalidates existing
3768 tm_zone or tzname values, and since most of these functions return
3769 pointers to static storage.
3770 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3771 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3772 Grow the critical sections to include not just invoking
3773 localtime/gmtime, but also accessing these functions' results
3774 including their tm_zone values if any, and any related TZ setting.
3775 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3776 so that the struct tm is saved in the critical section.
3777 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3778 motivated by the fact that memory allocation needs to be outside
3779 the critical section.
3780
0c16dfed
DA
37812012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3782
3783 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3784 with RESET_INTERVAL.
3785
3786 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3787 Remove duplicated buffer name initialization.
3788
3f83ace8
JM
37892012-05-02 Jim Meyering <jim@meyering.net>
3790
3791 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3792
c7b8541e
JM
3793 * xfns.c (x_window): Use xstrdup (Bug#11375).
3794
90207a15 37952012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3796
3797 * xdisp.c (pos_visible_p): If already at a newline from the
3798 display string before the 'while' loop, don't walk back the glyphs
3799 from it3.glyph_row. Solves assertion violation when the display
3800 string begins with a newline (egg.el). (Bug#11367)
3801
b593d6a9
AH
38022012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3803
3804 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3805 Move to simple.el.
3806
4737362e
GM
38072012-05-01 Glenn Morris <rgm@gnu.org>
3808
99cf43f9
GM
3809 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3810 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3811 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3812 All were removed before 23.1.
3813
9311dcff
GM
3814 * dispnew.c: Remove HAVE_LIBNCURSES test;
3815 it is always true on relevant platforms.
3816
4d5c6349
GM
3817 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3818 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3819
4737362e
GM
3820 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3821
74dd3a6b
AS
38222012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3823
3824 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3825 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3826 Remove.
3827
13c379ee
PE
38282012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3829
3830 Do not avoid creating empty evaporating overlays (Bug#9642).
3831 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3832 That is, do not delete an evaporating overlay if it becomes
3833 empty after its bounds are adjusted to fit within its buffer.
3834 This fix caused other problems, and I'm reverting it until we get
3835 to the bottom of them.
3836
a8e7d6d7 38372012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3838
3839 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3840
a8e7d6d7 38412012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3842
3843 * xdisp.c (pos_visible_p): If the window start position is beyond
3844 ZV, start the display from buffer beginning. Prevents assertion
3845 violation in init_iterator when the minibuffer window is scrolled
3846 via the scroll bar.
3847
3848 * window.c (window_scroll_pixel_based): Likewise.
3849
a8e7d6d7 38502012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3851
3852 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3853
a8e7d6d7 38542012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3855
3856 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3857 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3858
a8e7d6d7 38592012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3860
b593d6a9
AH
3861 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3862 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3863
1c6900d9
EZ
38642012-04-26 Eli Zaretskii <eliz@gnu.org>
3865
4c3fa1d9
EZ
3866 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3867 display element, check also the underlying string or buffer
3868 character. (Bug#11341)
3869
1c6900d9
EZ
3870 * w32menu.c: Include w32heap.h.
3871 (add_menu_item): If the call to AppendMenuW (via
3872 unicode_append_menu) fails, disable Unicode menus only if we are
3873 running on Windows 9X/Me.
3874
42bf8205
AS
38752012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3876
3877 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3878 (xgetint): Add missing shift for LSB tags.
3879
b1bac16e
MR
38802012-04-24 Martin Rudalics <rudalics@gmx.at>
3881
3882 * keyboard.c (read_char): Don't wipe echo area for select window
3883 events: These might get delayed via `mouse-autoselect-window'
3884 (Bug#11304).
3885
d69621cc
JB
38862012-04-24 Juanma Barranquero <lekktu@gmail.com>
3887
3888 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3889 manipulation of :loaded-from data.
3890
02fd101b
JB
38912012-04-23 Juanma Barranquero <lekktu@gmail.com>
3892
3893 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3894 now a cons (bug#11311).
3895
888bec30
PE
38962012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3897
89a438bd
PE
3898 Do not create empty overlays with the evaporate property (Bug#9642).
3899 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3900 if it becomes empty after its bounds are adjusted to fit within
3901 its buffer. Without this fix, in a nonempty buffer (let ((o
3902 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3903 yields an empty overlay that has the evaporate property, which is
3904 not supposed to happen.
3905
1068fe4d
PE
3906 Fix minor GTK3 problems found by static checking.
3907 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3908 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3909 (struct _EmacsFixedClass, emacs_fixed_get_type):
3910 Move decls here from emacsgtkfixed.h, since they needn't be public.
3911 (emacs_fixed_get_type): Now static.
3912 (emacs_fixed_class_init): Omit unused local.
3913 (emacs_fixed_child_type): Remove; unused.
3914 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3915 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3916 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3917 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3918 (EMACS_FIXED_GET_CLASS): Remove; unused.
3919 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3920
888bec30
PE
3921 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3922 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3923
de85e130
PE
39242012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3925
d0baac98 3926 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3927 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3928 (__malloc_size_t, __malloc_ptrdiff_t):
3929 Remove. All uses removed, replaced by the definiens if needed,
3930 since we can assume C89 or better now.
3931 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3932 (protect_malloc_state, align, get_contiguous_space)
3933 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3934 (malloc_atfork_handler_child, malloc_enable_thread)
3935 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3936 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3937 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3938 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3939 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3940 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3941 Define using prototypes, not old style.
3942 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3943 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3944 (align): Don't assume that signed integer overflow wraps around.
3945 Omit unused local var.
3946 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3947 (_free_internal_nolock, memalign, mallochook, reallochook):
3948 Omit no-longer-needed casts.
3949 (valloc): Use getpagesize, not __getpagesize.
3950 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3951 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3952
de85e130
PE
3953 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3954
dcbf5805
MA
39552012-04-22 Michael Albinus <michael.albinus@gmx.de>
3956
3957 Move functions from C to Lisp. Make non-blocking method calls
3958 the default. Implement further D-Bus standard interfaces.
3959
3960 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3961 (QCdbus_request_name_allow_replacement)
3962 (QCdbus_request_name_replace_existing)
3963 (QCdbus_request_name_do_not_queue)
3964 (QCdbus_request_name_reply_primary_owner)
3965 (QCdbus_request_name_reply_in_queue)
3966 (QCdbus_request_name_reply_exists)
3967 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3968 (QCdbus_registered_serial, QCdbus_registered_method)
3969 (QCdbus_registered_signal): New Lisp objects.
3970 (XD_DEBUG_MESSAGE): Use sizeof.
3971 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3972 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3973 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3974 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3975 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3976 (xd_signature, xd_append_arg): Allow float for integer types.
3977 (xd_get_connection_references): New function.
b593d6a9
AH
3978 (xd_get_connection_address): Rename from xd_initialize.
3979 Return cached address.
dcbf5805
MA
3980 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3981 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3982 level.
3983 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3984 Return number of refcounts.
dcbf5805
MA
3985 (Fdbus_get_unique_name): Make stronger parameter check.
3986 (Fdbus_message_internal): New defun.
3987 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3988 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3989 (Fdbus_send_signal, Fdbus_register_service)
3990 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3991 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3992 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3993 (Vdbus_compiled_version, Vdbus_runtime_version)
3994 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3995 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3996 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3997 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3998 Adapt docstring.
dcbf5805 3999
52828e02
PE
40002012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4001
da05bc4c
PE
4002 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4003 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4004 Do not assume ptrdiff_t is the same width as 'int'.
4005
52828e02
PE
4006 * alloc.c: Handle unusual debugging option combinations.
4007 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4008 since the two debugging options are incompatible.
4009 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4010 is defined.
4011 (mem_init, mem_insert, mem_insert_fixup):
4012 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4013 (NEED_MEM_INSERT): Remove; no longer needed.
4014
f01769f9
LL
40152012-04-22 Leo Liu <sdl.web@gmail.com>
4016
4017 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4018
5790543d
PE
40192012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4020
4021 * sysdep.c [__FreeBSD__]: Minor cleanups.
4022 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4023 Use Emacs indenting style more consistently. Avoid some casts.
4024 Use 'double' consistently rather than mixing 'float' and 'double'.
4025
b91b7e4d
EW
40262012-04-21 Eduard Wiebe <usenet@pusto.de>
4027
b593d6a9
AH
4028 * sysdep.c (list_system_processes, system_process_attributes):
4029 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4030
6114eb15
AS
40312012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4032
4033 * lisp.mk (lisp): Update.
4034
2f38dff7
PE
40352012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4036
4037 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4038 It is never used otherwise.
4039
4ae29f89
SM
40402012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4041
4042 * print.c (print_preprocess): Only check print_depth if print-circle
4043 is nil.
4044 (print_object): Check for cycles even when print-circle is nil and
4045 print-gensym is t, but only check print_depth if print-circle is nil.
4046
f30d612a
CY
40472012-04-20 Chong Yidong <cyd@gnu.org>
4048
4049 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4050 set the status to "failed" and ensure that sentinel is run.
4051
c07a4c0b 40522012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4053
4054 * process.c (Fset_process_inherit_coding_system_flag)
4055 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4056 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4057
c07a4c0b 40582012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4059
4060 * xdisp.c (string_buffer_position_lim): Limit starting position to
4061 BEGV.
4062 (set_cursor_from_row): If called for a mode-line or header-line
4063 row, return zero immediately.
4064 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4065 farther than the first row after the header line, if any.
4066 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4067 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4068
c07a4c0b 40692012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4070
4ae29f89
SM
4071 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4072 (bug#11238).
ad3a2b41 4073
c07a4c0b 40742012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 40752012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4076
4077 configure: new option --enable-gcc-warnings (Bug#11207)
4078 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4079 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4080 (ALL_CFLAGS): Use new macros rather than old.
4081 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4082 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4083 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4084 -Wunused-result, -Wunused-variable. This should go away once
4085 the Emacs and Gnulib regex code is merged.
4086 (xmalloc, xrealloc): Now static.
4087
aba027e8
PE
40882012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4089
4090 * dired.c (Fsystem_groups): Remove unused local.
4091
e5a36063
GM
40922012-04-17 Glenn Morris <rgm@gnu.org>
4093
4094 * dired.c (Fsystem_users): Doc fix.
4095
316411f0
DA
40962012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4097
4098 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4099 (syms_of_dired): Add them.
4100
9426aba4
PE
41012012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4102
b62a57be
PE
4103 Fix minor alloc.c problems found by static checking.
4104 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4105 New extern decls, to avoid calling undeclared functions.
4106 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4107 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4108 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4109 (NEED_MEM_INSERT): New macro.
4110 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4111 Remove one incorrect comment and fix another.
b62a57be 4112
3539f31f
PE
4113 Fix minor ralloc.c problems found by static checking.
4114 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4115 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4116 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4117 (r_alloc_sbrk): Now static.
4118
a041960a
PE
4119 Improve ralloc.c interface checking.
4120 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4121 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4122 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4123 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4124 [REL_ALLOC]: ... to here, to check interface.
4125 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4126 Remove decls. This fixes an "It stinks!".
4127
9426aba4
PE
4128 * alloc.c (which_symbols): Fix alignment issue / type clash.
4129
d55c12ed
AS
41302012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4131
4132 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4133 (struct Lisp_Misc_Any): Likewise.
4134 (struct Lisp_Free): Likewise.
4135 * alloc.c (union aligned_Lisp_Symbol): Define.
4136 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4137 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4138 (union aligned_Lisp_Misc): Define.
4139 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4140 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4141 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4142
b948ce8b
PE
41432012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4144
4145 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4146 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4147 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4148 * s/netbsd.h, s/sol2-6.h:
4149 Remove definition of GC_MARK_STACK, since the default now works.
4150 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4151 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4152 no longer the default.
4153 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4154
35dc09a1 41552012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4156
35dc09a1
GM
4157 * lread.c (lisp_file_lexically_bound_p):
4158 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4159
35dc09a1
GM
41602012-04-14 Eli Zaretskii <eliz@gnu.org>
4161
4162 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4163 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4164
41652012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4166
4167 * nsterm.m (constrainFrameRect): Always constrain when there is only
4168 one screen (Bug#10962).
4169
bcd86815
KB
41702012-04-13 Ken Brown <kbrown@cornell.edu>
4171
4172 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4173
c25df26e
RT
41742012-04-13 Reuben Thomas <rrt@sc3d.org>
4175
4176 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4177
0fc59f1e
DC
41782012-04-11 Daniel Colascione <dancol@dancol.org>
4179
4180 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4181 against is gone. It's better to use vfork now so that when Cygwin
4182 gains a new, working vfork, we use it automatically (bug#10398).
4183
de8c03dc
SM
41842012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4185
4186 * window.c (save_window_save): Obey window-point-insertion-type.
4187
2f097256
GM
41882012-04-11 Glenn Morris <rgm@gnu.org>
4189
4190 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4191
453b951e
SM
41922012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4193
4194 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4195
75f1671a 41962012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4197
4198 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4199 (force_quit_count): New var.
4200 (handle_interrupt): Use it.
4201
2a8ce227
JB
42022012-04-10 Juanma Barranquero <lekktu@gmail.com>
4203
4204 * w32.c (w32_delayed_load): Record the full path of the library
4205 being loaded (bug#10424).
4206
935396c0
GM
42072012-04-09 Glenn Morris <rgm@gnu.org>
4208
05920a43
GM
4209 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4210 not just in the obarray, before snarfing them. (Bug#11036)
4211
935396c0
GM
4212 * Makefile.in ($(leimdir)/leim-list.el):
4213 Pass EMACS rather than BUILT_EMACS.
4214
a18ecafa
TZ
42152012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4216
4217 * process.c (make_process):
4218 * process.h: Add integer `gnutls_handshakes_tried' member to
4219 process struct.
4220
6bbef4e5
JC
4221 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4222 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4223
4224 * gnutls.c (gnutls_log_function2i): Convenience log function.
4225 (emacs_gnutls_read): Use new log functions,
4226 `gnutls_handshakes_tried' process member, and
4227 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4228 attempts per process (connection).
4229
b4d3bc10
CY
42302012-04-09 Chong Yidong <cyd@gnu.org>
4231
4232 * eval.c (Fuser_variable_p, user_variable_p_eh)
4233 (lisp_indirect_variable): Functions deleted.
4234 (Fdefvar): Caller changed.
4235
4236 * callint.c (Finteractive, Fcall_interactively):
4237 * minibuf.c (Fread_variable): Callers changed.
4238
70f4d973
EZ
42392012-04-09 Eli Zaretskii <eliz@gnu.org>
4240
4241 * xdisp.c (set_cursor_from_row): If the display string appears in
4242 the buffer at position that is closer to point than the position
4243 after the display string, display the cursor on the first glyph of
4244 the display string. Fixes cursor display when a 'display' text
4245 property immediately follows invisible text. (Bug#11094)
4246
cb3c2e3e
PE
42472012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4248
4249 composite.c: use 'double' consistently
4250 * composite.c (get_composition_id): Use 'double' consistently
4251 instead of converting 'float' to 'double' and vice versa; this is
4252 easier to understand and avoids a GCC warning.
4253
fd06db5d
GM
42542012-04-09 Glenn Morris <rgm@gnu.org>
4255
50fe702a
GM
4256 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4257 preparation for dumping it with emacs. (Bug#4789)
4258 (leimdir): New variable.
4259 ($(leimdir)/leim-list.el): New rule.
4260 (emacs$(EXEEXT)): Depend on leim-list.el.
4261
fd06db5d
GM
4262 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4263 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4264 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4265
55c131ee
AS
42662012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4267
4268 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4269 proper alignment.
4270
9209588f
JB
42712012-04-07 Juanma Barranquero <lekktu@gmail.com>
4272
4273 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4274 Remove unused local variable.
4275
e3fb2efb
PE
42762012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4277
4278 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4279 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4280 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4281 objects, as mark_maybe_pointer will catch them otherwise.
4282 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4283 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4284
b5385551
PE
42852012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4286
4287 Fix typo that broke non-Windows builds.
4288 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4289
9078ead6
EZ
42902012-04-07 Eli Zaretskii <eliz@gnu.org>
4291
4292 Support building on MS-Windows with libxml2.
4293
4294 * makefile.w32-in (OBJ2): Add xml.$(O).
4295 (GLOBAL_SOURCES): Add xml.c.
4296 ($(BLD)/xml.$(O)): New dependency list.
4297
4298 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4299 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4300 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4301 [!WINDOWSNT]: New macros.
4302 (init_libxml2_functions, libxml2_loaded_p): New functions.
4303 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4304 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4305 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4306 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4307 linked in).
6bbef4e5
JC
4308 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4309 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4310 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4311
4312 * emacs.c: Don't include libxml/parser.h.
4313 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4314 xmlCleanupParser directly.
4315
4316 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4317
3811fdf3
EZ
43182012-04-07 Eli Zaretskii <eliz@gnu.org>
4319
4320 * indent.c (Fvertical_motion): If there is a display string at
4321 point, use it.vpos to compute how many lines to backtrack after
4322 move_it_to point. (Bug#11133)
4323
2f8e16b2
EZ
43242012-04-06 Eli Zaretskii <eliz@gnu.org>
4325
4326 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4327 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4328 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4329 macros related to unification of CJK characters. For the details,
4330 see the discussion following the message here:
4331 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4332
3d439cd1
CY
43332012-04-04 Chong Yidong <cyd@gnu.org>
4334
4335 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4336
8bc53d00
EZ
43372012-04-01 Eli Zaretskii <eliz@gnu.org>
4338
4339 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4340 instead of alloca. (Bug#11138)
4341
3b0512a3
AS
43422012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4343
4344 * w32menu.c (is_simple_dialog): Properly check lisp types.
4345 (Bug#11141)
4346
8427ddd2
EZ
43472012-03-31 Eli Zaretskii <eliz@gnu.org>
4348
979022ef
EZ
4349 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4350 position we get to after a call to move_it_to fails the
4351 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4352 only if we wind up in a string from display property. (Bug#11063)
4353
a6b1c7cc
EZ
4354 * window.c (Fdelete_other_windows_internal): Invalidate the row
4355 and column information about mouse highlight, so that redisplay
4356 restores it after reallocating the glyph matrices. (Bug#7464)
4357
8427ddd2
EZ
4358 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4359 string comes from a `display' text property, use the buffer
4360 position of that property as if we actually saw that position in
4361 the row's glyphs.
697ba24b
EZ
4362 (move_it_by_lines): Remove the assertion that
4363 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4364 violated when there's a before-string at the beginning of a line.
4365 (Bug#11063)
8427ddd2 4366
65a0a738
EZ
43672012-03-30 Eli Zaretskii <eliz@gnu.org>
4368
4369 * xdisp.c (append_space_for_newline): If the default face was
4370 remapped, use the remapped face for the appended newline.
4371 (extend_face_to_end_of_line): Use the remapped default face for
4372 extending the face to the end of the line.
4373 (display_line): Call extend_face_to_end_of_line when the default
4374 face was remapped. (Bug#11068)
4375
581355cc
EZ
43762012-03-29 Eli Zaretskii <eliz@gnu.org>
4377
4378 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4379
e8fc049f
SM
43802012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4381
4382 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4383
4fb9a543
GM
43842012-03-27 Glenn Morris <rgm@gnu.org>
4385
4386 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4387 Doc fixes.
4388
679910f1
KH
43892012-03-26 Kenichi Handa <handa@m17n.org>
4390
4391 * dispextern.h (struct glyph): Fix previous change. Change the
4392 bit length of glyphless.ch to 25 (Bug#11082).
4393
90d49b7f
CY
43942012-03-26 Chong Yidong <cyd@gnu.org>
4395
4396 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4397 (command_loop_1): Use it; inhibit selection update for
4398 handle-select-window too (Bug#8996).
4399
f514f6f0
FP
44002012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4401
e8fc049f 4402 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4403
bf43fa51
KH
44042012-03-25 Kenichi Handa <handa@m17n.org>
4405
4406 * dispextern.h (struct glyph): Change the bit length of
4407 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4408
8a0c01dd
EZ
44092012-03-24 Eli Zaretskii <eliz@gnu.org>
4410
4411 * s/ms-w32.h (tzname): Include time.h before redirecting to
4412 _tzname. Fixes the MSVC build. (Bug#9960)
4413
7d1c3a76
AS
44142012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4415
8ed79523
AS
4416 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4417 characters.
4418
7d1c3a76
AS
4419 * xterm.c (XTread_socket): Only modify handling_signal if
4420 !SYNC_INPUT. (Bug#11080)
4421
e99a9b8b
EZ
44222012-03-23 Eli Zaretskii <eliz@gnu.org>
4423
4424 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4425 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4426 when fetching a multibyte character consumes more bytes than
4427 CHAR_BYTES returns, due to unification of CJK characters in
4428 string_char. (Bug#11073)
4429
5063c0e1
TN
44302012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4431
4432 * process.c (wait_reading_process_output): Handle pty disconnect
4433 by refraining from sending oneself a SIGCHLD (bug#10933).
4434
9f851fbd
CY
44352012-03-22 Chong Yidong <cyd@gnu.org>
4436
4437 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4438
5063c0e1 4439 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4440 Mark string as coming from a prefix property.
4441 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4442 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4443
fb5b8aca
CY
44442012-03-21 Chong Yidong <cyd@gnu.org>
4445
4446 * xfaces.c (Vface_remapping_alist): Doc fix.
4447
62356a1b
EZ
44482012-03-20 Eli Zaretskii <eliz@gnu.org>
4449
4450 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4451 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4452 Doc fixes.
62356a1b 4453
025de85b
CY
44542012-03-20 Chong Yidong <cyd@gnu.org>
4455
4456 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4457 to reflect default non-nil value of redisplay-dont-pause.
4458
4827f94e
KH
44592012-03-19 Kenichi Handa <handa@m17n.org>
4460
4461 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4462 it fit in a valid range (Bug#11003).
4463
e50a24a2
EZ
44642012-03-18 Eli Zaretskii <eliz@gnu.org>
4465
4466 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4467 that is not from display property, accept the row as a "cursor
4468 row" if one of the string's character has a non-nil `cursor'
4469 property. Fixes cursor positioning when there are newlines in
4470 overlay strings, e.g. in icomplete.el. (Bug#11035)
4471
9af5ed87
PE
44722012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4473
4474 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4475
d1f55f16
CY
44762012-03-12 Chong Yidong <cyd@gnu.org>
4477
4478 * eval.c (inhibit_lisp_code): Rename from
4479 inhibit_window_configuration_change_hook; move from window.c.
4480
4481 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4482 * window.c (run_window_configuration_change_hook)
4483 (syms_of_window): Callers changed.
4484
66c5eebd
CY
44852012-03-11 Chong Yidong <cyd@gnu.org>
4486
413df973
CY
4487 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4488
66c5eebd
CY
4489 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4490
1de11f56
CY
44912012-03-10 Chong Yidong <cyd@gnu.org>
4492
4493 * frame.c (other_visible_frames): Don't assume the selected frame
4494 is visible (Bug#10955).
4495
cae07000
SM
44962012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4497
4498 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4499
89c94350
JD
45002012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4501
4502 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4503 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4504 zero (Bug#10954).
4505
999dd333
GM
45062012-03-03 Glenn Morris <rgm@gnu.org>
4507
01a6dcc8 4508 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4509
de0100f2
EZ
45102012-03-02 Eli Zaretskii <eliz@gnu.org>
4511
4512 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4513 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4514 (redisplay_window, next_element_from_string): Fix typos in
4515 comments.
3e441275
EZ
4516 (redisplay_window): Pass to move_it_vertically the margin in
4517 pixels, not in screen lines.
de0100f2 4518
96a72ee9
GM
45192012-03-02 Glenn Morris <rgm@gnu.org>
4520
4521 * buffer.c (buffer-list-update-hook): Doc fix.
4522
312508d7
EZ
45232012-02-29 Eli Zaretskii <eliz@gnu.org>
4524
4525 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4526 push_it before setting up the iterator for the first overlay
4527 string, even if we have an empty string loaded.
4528 (next_overlay_string): If there's an empty string on the iterator
4529 stack, pop the stack. (Bug#10903)
4530
27f3c637
PE
45312012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4532
4533 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4534 Suggested by Stefan Monnier in
4535 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4536 * alloc.c (widen_to_Lisp_Object): New static function.
4537 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4538 and widening them to Lisp_Objects. This would work even if
4539 USE_LSB_TAG is defined and wide integers are used, which might
4540 happen in a future version of Emacs.
4541
3c9dfce6
CY
45422012-02-25 Chong Yidong <cyd@gnu.org>
4543
fa74b241
CY
4544 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4545 Doc fix.
4546
3c9dfce6
CY
4547 * xselect.c (Fx_selection_exists_p): Doc fix.
4548 (x_clipboard_manager_save_all): Print an informative message
4549 before saving to clipboard manager.
4550
9486df08
CY
45512012-02-24 Chong Yidong <cyd@gnu.org>
4552
4553 * keyboard.c (process_special_events): Handle all X selection
4554 requests in kbd_buffer, not just the next one (Bug#8869).
4555
f01d3321
CY
45562012-02-23 Chong Yidong <cyd@gnu.org>
4557
4558 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4559 call when setting menu-bar-lines and tool-bar-lines parameters.
4560 (unwind_create_frame_1): New helper function.
4561
4562 * window.c (inhibit_window_configuration_change_hook): New var.
4563 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4564 (syms_of_window): Initialize it.
f01d3321 4565
86b847b6
CY
45662012-02-22 Chong Yidong <cyd@gnu.org>
4567
4568 * xterm.c (x_draw_image_relief): Add missing type check for
4569 Vtool_bar_button_margin (Bug#10743).
4570
a59225b1
CY
45712012-02-21 Chong Yidong <cyd@gnu.org>
4572
4573 * fileio.c (Vfile_name_handler_alist): Doc fix.
4574
4575 * buffer.c (Fget_file_buffer): Protect against invalid file
4576 handler return value.
4577
310f5bd4
PE
45782012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4579
cb3a28cc
PE
4580 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4581 when computing $valmask.
4582
310f5bd4
PE
4583 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4584 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4585 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4586 It's useless in that case, and it can cause problems on hosts
4587 that allocate halves of EMACS_INT values separately.
4588 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4589 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4590 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4591 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4592 it avoids undefined behavior on hosts where shifting right by more
4593 than the word width has undefined behavior.
4594
2375c96a
CY
45952012-02-19 Chong Yidong <cyd@gnu.org>
4596
4597 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4598 (Funhandled_file_name_directory, Ffile_name_as_directory)
4599 (Fdirectory_file_name, Fexpand_file_name)
4600 (Fsubstitute_in_file_name): Protect against invalid file handler
4601 return values (Bug#10845).
4602
3eb49e71
EZ
46032012-02-18 Eli Zaretskii <eliz@gnu.org>
4604
4605 * .gdbinit (pitx): Fix incorrect references to fields of the
4606 iterator stack.
4607
7b926f3f
CY
46082012-02-17 Chong Yidong <cyd@gnu.org>
4609
4610 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4611
11273115
PE
46122012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4613
4614 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4615 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4616
c3a70e2b
CY
46172012-02-15 Chong Yidong <cyd@gnu.org>
4618
4619 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4620 marked as special. Also, starting docstrings with * is obsolete.
4621
0ca43699
AS
46222012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4623
4624 * gnutls.c (emacs_gnutls_write): Fix last change.
4625
2e8f3c56
LI
46262012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4627
4628 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4629 send_process.
4630
af70074f
SM
46312012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4632
4633 * keymap.c (Fsingle_key_description): Handle char ranges.
4634
95986d52
CY
46352012-02-12 Chong Yidong <cyd@gnu.org>
4636
afd83bd1
CY
4637 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4638 as that creates a dangerous corner case.
4639
95986d52
CY
4640 * window.c (Fdelete_window_internal): Invalidate the mouse
4641 highlight (Bug#9904).
4642
bd7da63e
GM
46432012-02-12 Glenn Morris <rgm@gnu.org>
4644
4645 * xselect.c (Fx_own_selection_internal)
4646 (Fx_get_selection_internal, Fx_disown_selection_internal)
4647 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4648 * nsselect.m (Fx_own_selection_internal)
4649 (Fx_disown_selection_internal, Fx_selection_exists_p)
4650 (Fx_selection_owner_p, Fx_get_selection_internal):
4651 Sync docs and argument specs with the xselect.c versions.
4652
77abcbc2
LI
46532012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4654
4655 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4656
90b671e2
EZ
46572012-02-11 Eli Zaretskii <eliz@gnu.org>
4658
1c0ca0b7
EZ
4659 * w32select.c (Fx_selection_exists_p): Sync doc string and
4660 argument list with xselect.c. (Bug#10783)
4661
4662 * w16select.c (Fx_selection_exists_p): Sync doc string and
4663 argument list with xselect.c. (Bug#10783)
90b671e2 4664
49241268
GM
46652012-02-10 Glenn Morris <rgm@gnu.org>
4666
4667 * fns.c (Fsecure_hash): Doc fix.
4668
f998bbe7 46692012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4670
4671 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4672
0992bd9c
CY
46732012-02-07 Chong Yidong <cyd@gnu.org>
4674
4675 * buffer.c (Fbuffer_local_variables)
4676 (buffer_lisp_local_variables): Handle unbound vars correctly;
4677 don't let Qunbound leak into Lisp.
4678
af008560
GM
46792012-02-07 Glenn Morris <rgm@gnu.org>
4680
dd605cc4
GM
4681 * image.c (Fimagemagick_types): Doc fix.
4682
af008560
GM
4683 * image.c (imagemagick-render-type): Change it from a lisp object
4684 to an integer. Move the doc here from the lisp manual.
4685 Treat all values not equal to 0 the same.
4686
1449fa1d
CY
46872012-02-06 Chong Yidong <cyd@gnu.org>
4688
4689 * doc.c (store_function_docstring): Avoid applying docstring of
4690 alias to base function (Bug#2603).
4691
3723ec07
AS
46922012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4693
4694 * .gdbinit (pp1, pv1): Remove redundant defines.
4695 (pr): Use pp.
4696
79c1cc1e
CY
46972012-02-04 Chong Yidong <cyd@gnu.org>
4698
4699 * nsterm.m: Declare a global (Bug#10694).
4700
d7f29f8e
EZ
47012012-02-04 Eli Zaretskii <eliz@gnu.org>
4702
cae07000
SM
4703 * w32.c (get_emacs_configuration_options):
4704 Include --enable-checking, if specified, in the return value.
d7f29f8e 4705
3b95a6f9
MR
47062012-02-04 Martin Rudalics <rudalics@gmx.at>
4707
4708 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4709 after rounding frame sizes. (Bug#9723)
4710
d6fa96a6
EZ
47112012-02-04 Eli Zaretskii <eliz@gnu.org>
4712
4713 * keyboard.c (adjust_point_for_property): Don't position point
4714 before BEGV. (Bug#10696)
4715
df0b2940
PE
47162012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4717
4718 Handle overflow when computing char display width (Bug#9496).
4719 * character.c (char_width): Return EMACS_INT, not int.
4720 (char_width, c_string_width): Check for overflow when
4721 computing the width; this is possible now that individual
4722 characters can have unbounded width. Problem introduced
4723 by merge from Emacs 23 on 2012-01-19.
4724
6bee44d6
MA
47252012-02-02 Michael Albinus <michael.albinus@gmx.de>
4726
4727 * dbusbind.c (Fdbus_register_method): Mention the return value
4728 :ignore in the docstring.
4729
44f92739
GM
47302012-02-02 Glenn Morris <rgm@gnu.org>
4731
1b9f60cc
GM
4732 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4733
44f92739
GM
4734 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4735 Unconditionally set to t. (Bug#10673)
4736 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4737 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4738 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4739
c5d3843c
KH
47402012-02-02 Kenichi Handa <handa@m17n.org>
4741
4742 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4743 0, do not call append_composite_glyph.
4744
159462d4 47452012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4746
4747 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4748 NULL (Bug#6988).
4749 (x_produce_glyphs): If the component of a composition is a null
4750 string, set it->pixel_width to 1 to avoid zero-width glyph.
4751
78cef877
EZ
47522012-02-01 Eli Zaretskii <eliz@gnu.org>
4753
4754 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4755 first 2 arguments are identical. This makes inserting large
4756 output from a subprocess an order of magnitude faster on
4757 MS-Windows, where all sbrk'ed memory is always contiguous.
4758
97897668
GM
47592012-01-31 Glenn Morris <rgm@gnu.org>
4760
4761 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4762 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4763 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4764
31fd3586
GM
47652012-01-29 Glenn Morris <rgm@gnu.org>
4766
4767 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4768
0e24a8b2
CY
47692012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4770
4771 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4772
cc0adcb0
CY
47732012-01-28 Chong Yidong <cyd@gnu.org>
4774
4775 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4776
acc28cb9
CY
47772012-01-26 Chong Yidong <cyd@gnu.org>
4778
9c69cfb7
CY
4779 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4780
acc28cb9
CY
4781 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4782 repeat counts (Bug#10507).
4783
48da7392
GM
47842012-01-26 Glenn Morris <rgm@gnu.org>
4785
4786 * lread.c (syms_of_lread): Doc fix.
4787
14af5f7f
CY
47882012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4789
4790 * coding.c (encode_designation_at_bol): Change return value to
4791 EMACS_INT.
4792
0b21c100
CY
47932012-01-25 Chong Yidong <cyd@gnu.org>
4794
4795 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4796
3c2907f7
CY
47972012-01-21 Chong Yidong <cyd@gnu.org>
4798
4799 * floatfns.c (Fcopysign): Make the second argument non-optional,
4800 since nil is not allowed anyway.
4801
959ad23f
AS
48022012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4803
4804 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4805 (send_process): Likewise.
4806
34a02f46
MR
48072012-01-19 Martin Rudalics <rudalics@gmx.at>
4808
4809 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4810 (Vwindow_persistent_parameters): Do not use Qstate.
4811 Rewrite doc-strings.
34a02f46 4812
1259009a 48132012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4814
4815 * character.c (char_width): New function.
70d4fdf6
GM
4816 (Fchar_width, c_string_width, lisp_string_width):
4817 Use char_width (Bug#9496).
25ed9e61 4818
6a6ee00d
MR
48192012-01-16 Martin Rudalics <rudalics@gmx.at>
4820
4821 * window.c (Vwindow_persistent_parameters): New variable.
4822 (Fset_window_configuration, save_window_save): Handle persistent
4823 window parameters.
4824
c85efaf7
EZ
48252012-01-14 Eli Zaretskii <eliz@gnu.org>
4826
4827 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4828 thrashing the stack of the thread. (Bug#9087)
4829
5944709e
PE
48302012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4831
4832 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4833
e71f5d99
EZ
48342012-01-11 Eli Zaretskii <eliz@gnu.org>
4835
4836 * xdisp.c (rows_from_pos_range): Handle the case where the
4837 highlight ends on a newline. (Bug#10464)
4838 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4839 he end column for display of highlight that ends on a newline
4840 before a R2L line.
4841
ce316182
GM
48422012-01-11 Glenn Morris <rgm@gnu.org>
4843
4844 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4845 from load-path also when installation-directory is nil. (Bug#10208)
4846
5b43da69
GM
48472012-01-10 Glenn Morris <rgm@gnu.org>
4848
74cc8ff9
GM
4849 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4850
7d8d6e4e
GM
4851 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4852 Update template values to be closer to their typical values these days.
5b43da69 4853
a0db8d43
EZ
48542012-01-09 Eli Zaretskii <eliz@gnu.org>
4855
4856 * xdisp.c (rows_from_pos_range): Accept additional argument
4857 DISP_STRING, and accept any glyph in a row whose object is that
4858 string as eligible for mouse highlight. Fixes mouse highlight of
4859 display strings from overlays. (Bug#10464)
4860
9a0115ab 48612012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4862
b9110d6a 4863 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4864 * fileio.c (auto_saving_dir_umask): New static var.
4865 (Fmake_directory_internal): Use it.
4866 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4867 creating the directory. The old code temporarily assigns
4868 too-generous permissions to the directory.
4869 (do_auto_save_eh): Clear it.
b9110d6a 4870 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4871 that the var is always cleared.
4872
6c1bd3f3
EZ
48732012-01-07 Eli Zaretskii <eliz@gnu.org>
4874
4875 * search.c (scan_buffer): Pass character positions to
4876 know_region_cache, not byte positions. (Bug#6540)
4877
069d2b50
L
48782012-01-07 LynX <_LynX@bk.ru> (tiny change)
4879
4880 * w32.c (sys_rename): Report EXDEV when rename of a directory
4881 fails because the target is on another logical disk. (Bug#10284)
4882
75bf0d33
DB
48832012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4884
4885 * xterm.c (x_embed_request_focus): New function.
4886
4887 * xterm.h: Add prototype.
4888
4889 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4890
1c6e5a32
GM
48912012-01-05 Glenn Morris <rgm@gnu.org>
4892
4893 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4894
651e947e
EZ
48952012-01-01 Eli Zaretskii <eliz@gnu.org>
4896
4897 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4898 Load gnutls_transport_set_lowat only if GnuTLS version is below
4899 2.11.1.
4900 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4901 GnuTLS versions below 2.11.1.
4902
3778cdd8
AL
49032011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4904
4905 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4906 to the doc string advising against its use for altering the way
4907 windows are scrolled.
4908
0e5317f7
KH
49092011-12-28 Kenichi Handa <handa@m17n.org>
4910
4911 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4912 coding-system ASCII compatible only when it does not produce BOM
4913 on encoding (Bug#10383).
4914
93d5ca1f
JD
49152011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4916
4917 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4918 can scroll.
4919 (create_and_show_popup_menu): Always use menu_position_func for
4920 Gtk3 (Bug#10361).
4921
ca22b785
AS
49222011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4923
4924 * callint.c (Fcall_interactively): Don't truncate prompt string.
4925
d048e1e6
EZ
49262011-12-23 Eli Zaretskii <eliz@gnu.org>
4927
4928 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4929 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4930 resumed from there (after widening). (Bug#10360)
d048e1e6 4931
5ccaba1f
JD
49322011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4933
4934 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4935
204ee57f
JD
49362011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4937
b81d40f0
JB
4938 * nsterm.m (x_free_frame_resources):
4939 Release f->output_data.ns->miniimage.
204ee57f
JD
4940 (ns_index_color): Fix indentation. Do not retain
4941 color_table->colors[i].
4942
4943 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4944 before returning.
4945
4946 * nsfns.m (x_set_background_color): Assign return value from
4947 ns_index_color to face-background instead of NSColor*.
4948 (ns_implicitly_set_icon_type): Fix indentation.
4949 Change assignment in for loop to comparison.
4950
4951 * emacs.c (ns_pool): New variable.
4952 (main): Assign ns_pool.
4953 (Fkill_emacs): Call ns_release_autorelease_pool.
4954
4955 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4956 autorelease fdesc, release fdAttrs and tdict.
4957 (ns_get_covering_families): Release charset.
4958 (ns_findfonts): Release NSFontDescriptor created with new.
4959 (ns_uni_to_glyphs): Fix indentation.
4960 (setString): Release attrStr before assigning new value.
4961
c803b2b7
JD
49622011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4963
678f4426
JD
4964 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4965 and NS_IMPL_COCOA.
4966 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4967 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4968
cd394be1 49692011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4970
5fecd5fc
JD
4971 * nsterm.m (ns_term_init): Subscribe for notifications
4972 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4973 to method trackingNotification in EmacsMenu.
4974
4975 * nsmenu.m (trackingMenu): New variable.
3771cb17 4976 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4977 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4978 from Aquamacs (Bug#7030).
678f4426
JD
4979
49802011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4981
c803b2b7
JD
4982 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4983 (symbol_to_nsstring): Fix indentation.
4984 (ns_symbol_to_pb): New function.
cae07000
SM
4985 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4986 (Fns_rotate_cut_buffers_internal): Remove.
4987 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4988 Fns_store_cut_buffer_internal.
4989 (ns_get_foreign_selection, Fx_own_selection_internal)
4990 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4991 (Fns_get_selection_internal, Fns_store_selection_internal):
4992 Use ns_symbol_to_pb and check if return value is nil.
4993 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4994 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4995 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4996 renamed to Sns_store_selection_internal.
4997 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4998 and remove this function.
4999 (ns_handle_selection_clear): Remove, never used.
5000 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5001 here.
5002
e1b01a3a
KB
50032011-12-17 Ken Brown <kbrown@cornell.edu>
5004
5005 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5006 GID is unknown (Bug#10257).
5007
2adb6e85
PE
50082011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5009
5010 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5011 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5012 which caused a build failure on GNU/Linux IA-64. This problem was
5013 introduced by my 2011-10-07 patch.
5014
d1d7b339
JL
50152011-12-15 Juri Linkov <juri@jurta.org>
5016
5017 * image.c (imagemagick_error): New function. (Bug#10112)
5018 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5019 Use `imagemagick_error' where ImageMagick functions return
5020 `MagickFalse'.
5021 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5022 proper order.
5023
100d5755
KH
50242011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5025
5026 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5027 fill background (Bug#8992).
5028
454592a6
MR
50292011-12-13 Martin Rudalics <rudalics@gmx.at>
5030
5031 * window.c (Vwindow_combination_resize)
5032 (Vwindow_combination_limit): Use t instead of non-nil in
5033 doc-strings.
61d4b438
MR
5034 (Vrecenter_redisplay): Add first sentence of doc-string on
5035 separate line.
53524d93 5036 (Frecenter): Fix doc-string typo.
454592a6 5037
3633e3aa
KH
50382011-12-11 Kenichi Handa <handa@m17n.org>
5039
5040 * coding.c (Funencodable_char_position): Pay attention to the
5041 buffer text relocation (Bug#9389).
5042
7b9d523a 50432011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5044
7b9d523a
JD
5045 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5046 gtk_init (Bug#10100).
5047
b73189c6
EZ
50482011-12-10 Eli Zaretskii <eliz@gnu.org>
5049
5050 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5051 IT->string is nil. (Bug#10263)
5052
f7dfe5d6
JD
50532011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5054
83faebb4
JD
5055 * nsterm.h (x_free_frame_resources): Declare.
5056
f7dfe5d6
JD
5057 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5058 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5059
5060 * nsterm.h (ns_get_defaults_value): Declare.
5061
5062 * nsterm.m (ns_default): Call ns_get_defaults_value.
5063
7cd4e72c
EZ
50642011-12-09 Eli Zaretskii <eliz@gnu.org>
5065
5066 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5067 (Bug#10170)
5068
b34d7317
YM
50692011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5070
5071 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5072 that where the value of an _OBJC_* symbol points to is in the .bss
5073 section (Bug#10240).
5074
76470ad1
KH
50752011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5076
5077 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5078 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5079
745fff94
KH
50802011-12-08 Kenichi Handa <handa@m17n.org>
5081
5082 * ftfont.c (get_adstyle_property): Fix previous change
5083 (Bug#10233).
5084
6e44397c
JB
50852011-12-07 Juanma Barranquero <lekktu@gmail.com>
5086
5087 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5088 dirs from the default value of EMACSLOADPATH (bug#10208).
5089
7efa6272
GM
50902011-12-07 Glenn Morris <rgm@gnu.org>
5091
5092 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5093 installation and source directories as well. (Bug#10208)
5094
f6fc4d87
CY
50952011-12-06 Chong Yidong <cyd@gnu.org>
5096
5097 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5098
2bf26180
GM
50992011-12-06 Glenn Morris <rgm@gnu.org>
5100
5101 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5102 as an error, not just -1. (Bug#10217)
5103
3a6ad4f0
CY
51042011-12-05 Chong Yidong <cyd@gnu.org>
5105
5106 * keyboard.c (process_special_events): New function.
5107 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5108
75a3b399
PE
51092011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5110
5111 * coding.c (encode_designation_at_bol): Don't use uninitialized
5112 local variable (Bug#9318).
5113
c3c9e25e
KH
51142011-12-05 Kenichi Handa <handa@m17n.org>
5115
5116 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5117 return Qnil (Bug#8046, Bug#10193).
5118
5eb05ea3
KH
51192011-12-05 Kenichi Handa <handa@m17n.org>
5120
5121 * coding.c (encode_designation_at_bol): New args charbuf_end and
5122 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5123 (coding_set_source): Return how many bytes coding->source was
5124 relocated.
5125 (coding_set_destination): Return how many bytes
5126 coding->destination was relocated.
5127 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5128 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5129
51302011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5131
5132 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5133 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5134 macro (Bug#9318).
5135
51362011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5137
5138 The following changes are to fix Bug#9318.
5139
a79703f5 5140 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5141 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5142 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5143 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5144
7dbda6df
JB
51452011-12-05 Juanma Barranquero <lekktu@gmail.com>
5146
5147 * lisp.h (process_quit_flag): Fix external declaration.
5148
6d5eb5b0
SM
51492011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5150
5151 Don't macro-inline non-performance-critical code.
5152 * eval.c (process_quit_flag): New function.
5153 * lisp.h (QUIT): Use it.
5154
a0c3fad0
JD
51552011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5156
5157 * nsfns.m (get_geometry_from_preferences): New function.
5158 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5159
6c07aac2
AS
51602011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5161
5162 * emacs.c (Qkill_emacs): Define.
5163 (syms_of_emacs): Initialize it.
5164 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5165 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5166 (quit_throw_to_read_char): Add parameter `from_signal'.
5167 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5168 * lisp.h (QUIT): Call Fkill_emacs if requested.
5169
c052ead4
JD
51702011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5171
5172 * widget.c (update_wm_hints): Return if wmshell is null.
5173 (widget_update_wm_size_hints): New function.
5174
5175 * widget.h (widget_update_wm_size_hints): Declare.
5176
5177 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5178 widget_update_wm_size_hints (Bug#10104).
5179
9e49252b
EZ
51802011-12-03 Eli Zaretskii <eliz@gnu.org>
5181
5182 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5183 before a newline, prepare the bidi iterator for consuming the
5184 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5185 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5186
02b16839
JL
51872011-12-02 Juri Linkov <juri@jurta.org>
5188
5189 * search.c (Fword_search_regexp): New Lisp function created from
5190 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5191 (Fword_search_backward, Fword_search_forward)
5192 (Fword_search_backward_lax, Fword_search_forward_lax):
5193 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5194 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5195
0068070e
SM
51962011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5197
5198 * fileio.c (Finsert_file_contents): Move after-change-function call
5199 to before the "handled:" label, since all "goto handled" appear in
5200 cases where the *-change-functions have already been properly called
5201 (bug#10117).
5202
3360a3fc
AS
52032011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5204
5205 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5206 waiting for input. (Bug#10169)
5207
73d6c093
EZ
52082011-11-30 Eli Zaretskii <eliz@gnu.org>
5209
5210 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5211 verifies glyph row's hash code--we have just reallocated the
5212 glyphs, so their contents can be complete garbage. (Bug#10164)
5213
febe6bea
JB
52142011-11-30 Juanma Barranquero <lekktu@gmail.com>
5215
5216 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5217
801a4313
EZ
52182011-11-30 Eli Zaretskii <eliz@gnu.org>
5219
5220 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5221 attributes are tested _before_ calling verify_row_hash, to protect
5222 against GCC re-ordering of the tests. (Bug#10164)
5223
2b56b87e
JD
52242011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5225
5226 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5227
5228 * xterm.c (handle_one_xevent): Only set async_visible and friends
5229 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5230 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5231 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5232
dbf31225
PE
52332011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5234
5235 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5236 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5237 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5238 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5239 All uses changed to use GCPRO1 etc.
5240 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5241 Revert to old implementation (i.e., before 2011-03-11).
5242
1305621b
YM
52432011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5244
5245 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5246 of scroll runs so as to avoid assigning disabled bogus rows and
5247 unnecessary graphics copy operations.
5248
8c9afb46
EZ
52492011-11-27 Eli Zaretskii <eliz@gnu.org>
5250
5251 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5252 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5253 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5254 (malloc, free, realloc, calloc): Redirect to e_* only when
5255 compiling Emacs.
5256
5257 * lisp.h (GCTYPEBITS): Move before first use.
5258 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5259 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5260 this macro definition.
5261
5262 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5263 _MSC_VER.
5264
54e9e3bf
JD
52652011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5266
6d5eb5b0
SM
5267 * gtkutil.c (xg_create_frame_widgets):
5268 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5269 present with Gtk+ 2.0.
5270
83aca1cb
PE
52712011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5272
5273 * fileio.c (Finsert_file_contents): Undo previous change; see
5274 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5275
5b76caa4
PE
52762011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5277
5278 Rename locals to avoid shadowing.
5279 * fileio.c (Finsert_file_contents):
5280 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5281 * process.c (wait_reading_process_output):
5282 Rename inner 'proc' to 'p' to avoid shadowing.
5283 Indent for consistency with usual Emacs style.
5284
8c535114
EZ
52852011-11-25 Eli Zaretskii <eliz@gnu.org>
5286
5287 * xdisp.c (redisplay_window): If cursor row is not fully visible
5288 after recentering, and scroll-conservatively is set to a large
5289 number, scroll window by a few more lines to make the cursor fully
5290 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5291 (start_display): Don't move to the next line if the display should
5292 start at a newline that is part of a display vector or an overlay
5293 string. (Bug#10119)
8c535114 5294
fa4fdb5c
JL
52952011-11-24 Juri Linkov <juri@jurta.org>
5296
5297 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5298 after the `MagickPingImage' call. (Bug#10112)
5299
90ec88df
CY
53002011-11-23 Chong Yidong <cyd@gnu.org>
5301
5302 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5303
56e2e794
MR
53042011-11-23 Martin Rudalics <rudalics@gmx.at>
5305
5306 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5307 making another buffer current. (Bug#10114)
5308
b6e64c41
GM
53092011-11-23 Glenn Morris <rgm@gnu.org>
5310
5311 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5312
6b21de18
CY
53132011-11-23 Chong Yidong <cyd@gnu.org>
5314
5315 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5316 using it (Bug#5984).
5317
b12cd789
EZ
53182011-11-22 Eli Zaretskii <eliz@gnu.org>
5319
5320 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5321 and header-lines, as they don't have one computed for them.
5322 (Bug#10098)
5323
5324 * .gdbinit (prow): Make displayed values more self-explaining.
5325 Add row's hash code.
5326
261b6fd4
LMI
53272011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5328
5329 * process.c (wait_reading_process_output): Fix asynchrounous
5330 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5331 (wait_reading_process_output): Add comment and URL.
261b6fd4 5332
e7cfd277
JD
53332011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5334
5335 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5336
a9b9b7f5
CY
53372011-11-21 Chong Yidong <cyd@gnu.org>
5338
5339 * window.c (Fnext_window, Fprevious_window): Doc fix.
5340
b0d15b4f
SM
53412011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5342
5343 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5344
fe7a3057
JB
53452011-11-20 Juanma Barranquero <lekktu@gmail.com>
5346
5347 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5348
d2999b1a
MR
53492011-11-20 Martin Rudalics <rudalics@gmx.at>
5350
5351 * window.c (Fset_window_combination_limit): Rename argument
5352 STATUS to LIMIT.
5353 (Vwindow_combination_limit): Remove "status" from doc-string.
5354
d5ff9cd0
AS
53552011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5356
5357 * m/ibms390.h: Remove.
5358 * m/ibms390x.h: Don't include "ibms390.h".
5359
a5bb9bd3
SM
53602011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5361
5362 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5363 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5364
cd1181db
JB
53652011-11-20 Juanma Barranquero <lekktu@gmail.com>
5366
5367 * casetab.c (Fset_case_table):
5368 * charset.c (Fcharset_after): Fix typos.
5369
615a3b8d 53702011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5371
17e845af
PE
5372 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5373 Otherwise, valgrind does not work on some platforms.
5374 Problem reported by Andreas Schwab in
6a0bf43d
PE
5375 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5376 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5377 is set, removing the need for VIRT_ADDRESS_VARIES.
5378 (PURE_P): Use a more-efficient implementation that needs just one
5379 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5380 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5381 to 4 (xorl, subq, cmpq, setbe).
5382 * alloc.c (pure): Always extern now, since that's the
5383 VIRT_ADDR_VARIES behavior.
5384 (PURE_POINTER_P): Use a single comparison, not two, for
5385 consistency with the new puresize.h.
5386 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5387 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5388 Remove VIRT_ADDR_VARIES no longer needed.
5389
f8fe6f96
EZ
53902011-11-19 Eli Zaretskii <eliz@gnu.org>
5391
5392 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5393 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5394 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5395 behave as if the cursor position were at the window margin.
5396
5397 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5398 and the cursor position is out of bounds, behave as if the cursor
5399 position were at the window margin. (Bug#10075)
5400
df05a53c
CY
54012011-11-18 Chong Yidong <cyd@gnu.org>
5402
5403 * window.c (Fwindow_combination_limit): Make first argument
5404 non-optional, since it is meaningless for live windows like the
5405 selected window.
61ccba97 5406
2071918e
DA
54072011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5408
5409 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5410
b50a28de
SM
54112011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5412
5413 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5414 (graft_intervals_into_buffer): Simplify.
5415
015137db
EZ
54162011-11-18 Eli Zaretskii <eliz@gnu.org>
5417
5418 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5419 hash values of the two rows.
5420 (copy_row_except_pointers): Preserve the used[] arrays and the
5421 hash values of the two rows. (Bug#10035)
68c95424 5422 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5423
5424 * xdisp.c (row_hash): New function, body extracted from
5425 compute_line_metrics.
5426 (compute_line_metrics): Call row_hash, instead of computing the
5427 hash code inline.
5428
5429 * dispnew.c (verify_row_hash): Call row_hash for computing the
5430 hash code of a row, instead of duplicating code from xdisp.c.
5431
5432 * dispextern.h (row_hash): Add prototype.
5433
a2addb04
TH
54342011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5435
5436 * frame.c (delete_frame): Don't delete the terminal when the last
5437 X frame is closed if emacs is built with GTK toolkit.
5438
df85d315
JB
54392011-11-17 Juanma Barranquero <lekktu@gmail.com>
5440
5441 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5442
a0c2d0ae
MR
54432011-11-17 Martin Rudalics <rudalics@gmx.at>
5444
5445 * window.c (Vwindow_splits): Rename to
5446 Vwindow_combination_resize. Suggested by Juri Linkov.
5447 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5448 of Vwindow_splits.
5449
58179cce
JB
54502011-11-16 Juanma Barranquero <lekktu@gmail.com>
5451
7877f373
JB
5452 * nsfns.m (Fns_font_name):
5453 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5454
b6f67890
MR
54552011-11-16 Martin Rudalics <rudalics@gmx.at>
5456
5457 * window.h (window): Rename slot "nest" to "combination_limit".
5458 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5459 (Fset_window_nest): Rename to Fset_window_combination_limit.
5460 (Vwindow_nest): Rename to Vwindow_combination_limit.
5461 (recombine_windows, make_parent_window, make_window)
5462 (Fsplit_window_internal, saved_window)
5463 (Fset_window_configuration, save_window_save): Rename all
5464 occurrences of window_nest to window_combination_limit.
5465
c7015153
JB
54662011-11-15 Juanma Barranquero <lekktu@gmail.com>
5467
5468 * image.c (imagemagick_load_image): Fix typo.
5469
322ad6ec
EZ
54702011-11-14 Eli Zaretskii <eliz@gnu.org>
5471
5472 * xdisp.c (display_line): Move the call to
5473 highlight_trailing_whitespace before the call to
5474 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5475 faces of all the glyphs to compute ROW's hash value.
5476 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5477
f067b8ec
JB
54782011-11-14 Juanma Barranquero <lekktu@gmail.com>
5479
5480 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5481 just return (bug#10044).
5482
1e5b2111
EZ
54832011-11-12 Eli Zaretskii <eliz@gnu.org>
5484
7ef3cbd5
EZ
5485 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5486 with user-defined heap size. Bump the default size of the temacs
5487 heap to 27MB, to avoid memory warning when running temacs.
5488 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5489
1e5b2111
EZ
5490 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5491 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5492 (verify_row_hash) [XASSERTS]: New function.
5493 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5494 that the hash value of glyph rows is correct.
1e5b2111 5495
89d61221
MR
54962011-11-12 Martin Rudalics <rudalics@gmx.at>
5497
5498 * window.h (window): Remove splits slot.
5499 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5500 (Fdelete_other_windows_internal, make_parent_window)
5501 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5502 (Fset_window_configuration, save_window_save): Don't deal with
5503 split status of windows.
5504 (saved_window): Remove splits slot.
5505 (Vwindow_splits): Rewrite doc-string.
5506
97f18cc8
JD
55072011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5508
5509 * xfns.c (unwind_create_frame):
5510 * nsfns.m (unwind_create_frame):
5511 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5512 Vframe_list (Bug#9999).
5513
22a648b4
DA
55142011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5515
0b381c7e 5516 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5517
659afede
KH
55182011-11-11 Kenichi Handa <handa@m17n.org>
5519
5520 * callproc.c (Fcall_process): Set the member dst_multibyte of
5521 process_coding.
5522
9ac0394b
KH
55232011-11-11 Johan Bockgård <bojohan@gnu.org>
5524
5525 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5526 avoid a crash (bug#9496).
5527
2fbdc249
CY
55282011-11-09 Chong Yidong <cyd@gnu.org>
5529
5530 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5531 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5532
ac6b1f81
PE
55332011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5534
5535 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5536
09db192c
PE
55372011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5538
5539 Avoid some portability problems by eschewing 'extern inline' functions.
5540 The trivial performance wins aren't worth the portability hassles; see
5541 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5542 et seq.
5543 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5544 (window_box_width, window_box_left, window_box_left_offset)
5545 (window_box_right, window_box_right_offset): Undo previous change,
5546 by removing the "extern"s.
5547 * intervals.c (adjust_intervals_for_insertion)
5548 (adjust_intervals_for_deletion): Undo previous change,
5549 making these static again.
5550 (offset_intervals, temp_set_point_both, temp_set_point)
5551 (copy_intervals_to_string): No longer inline.
5552 * xdisp.c (window_text_bottom_y, window_box_width)
5553 (window_box_height, window_box_left_offset)
5554 (window_box_right_offset, window_box_left, window_box_right)
5555 (window_box): No longer inline.
5556
105216ed
CY
55572011-11-08 Chong Yidong <cyd@gnu.org>
5558
5559 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5560 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5561 Signal an error if not a live window.
105216ed
CY
5562 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5563 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5564
ae9e237f
JB
55652011-11-07 Juanma Barranquero <lekktu@gmail.com>
5566
5567 * lisp.h (syms_of_abbrev): Remove declaration.
5568 Reported by CHENG Gao <chenggao@royau.me>.
5569
c7aa8333
EZ
55702011-11-07 Eli Zaretskii <eliz@gnu.org>
5571
5572 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5573 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5574 of temacs in GUI mode.
5575
be7f5545
MR
55762011-11-07 Martin Rudalics <rudalics@gmx.at>
5577
5578 * window.h: Declare delete_all_child_windows instead of
5579 delete_all_subwindows.
5580 * window.c (Fwindow_nest, Fset_window_nest)
5581 (Fset_window_new_total, Fset_window_new_normal)
5582 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5583 (delete_all_subwindows): Rename to delete_all_child_windows.
5584 (Fdelete_other_windows_internal, Fset_window_configuration):
5585 Call delete_all_child_windows instead of delete_all_subwindows.
5586 * frame.c (delete_frame): Call delete_all_child_windows instead
5587 of delete_all_subwindows.
5588
ca78dc43
PE
55892011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5590
5591 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5592 This is also needed for porting to any host where GC_MARK_STACK is
5593 not GC_MAKE_GCPROS_NOOPS.
5594 (which_symbols): Use it.
5595
a0241d01
KH
55962011-11-07 Kenichi Handa <handa@m17n.org>
5597
5598 * coding.c (coding_set_destination): Check coding->src_pos only
5599 when coding->src_object is a buffer (bug#9910).
5600
5601 * process.c (send_process): Set the member src_multibyte of coding
5602 to 0 (bug#9911) when sending a unibyte text.
5603
5604 * callproc.c (Fcall_process): Set the member src_multibyte of
5605 process_coding to 0 (bug#9912).
5606
a64bfdfa 56072011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5608
5609 * xmenu.c (cleanup_widget_value_tree): New function.
5610 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5611 calling free_menubar_widget_value_tree directly (Bug#9830).
5612
cb41b32a
PE
56132011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5614
5615 Fix some portability problems with 'inline'.
5616 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5617 (window_box_width, window_box_left, window_box_left_offset)
5618 (window_box_right, window_box_right_offset): Declare extern.
5619 Otherwise, these inline functions do not conform to C99 and
5620 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5621 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5622 * intervals.c (adjust_intervals_for_insertion)
5623 (adjust_intervals_for_deletion): Now extern, because otherwise the
5624 extern inline functions 'offset_intervals' couldn't refer to it.
5625 (static_offset_intervals): Remove.
5626 (offset_intervals): Rewrite using the old contents of
5627 static_offset_intervals. The old version didn't conform to C99
5628 because an extern inline function contained a reference to an
5629 identifier with static linkage.
5630
b7041366
AS
56312011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5632
5633 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5634 GC.
5635
88a37c4d
EZ
56362011-11-06 Eli Zaretskii <eliz@gnu.org>
5637
5638 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5639 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5640 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5641 return Qleft_to_right.
5642
49745b39
CY
56432011-11-06 Chong Yidong <cyd@gnu.org>
5644
5645 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5646 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5647 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5648 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5649 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5650 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5651 (Fwindow_vscroll): Doc fix.
5652 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5653 argument, since it makes no sense to pass a live window and for
5654 consistency with window-child.
5655
1f05cd82
CS
56562011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5657
5658 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5659 support MSVC.
5660
22610910
JR
56612011-11-05 Jason Rumney <jasonr@gnu.org>
5662
5663 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5664 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5665 fonts (Bug#6029).
5666 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5667 bitwise arithmetic preventing use of unicode-sip and non-truetype
5668 opentype fonts.
5669
a06776b2
EZ
56702011-11-05 Eli Zaretskii <eliz@gnu.org>
5671
3ad924ba
EZ
5672 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5673 "emacs"-only part.
5674
a06776b2
EZ
5675 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5676 initialization code to keep similarity to xfns.c after changes
5677 from 2011-11-05.
5678
c9e7db78
JD
56792011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5680
a97f8f3f
JD
5681 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5682 (unwind_create_frame): New function (Bug#9943).
5683 (Fx_create_frame): Restructure code to be more similar to the one in
5684 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5685 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5686 Move terminal->reference_count++ just before making the frame official
5687 (Bug#9943).
5688
5689 * nsterm.m (x_free_frame_resources): New function.
5690 (x_destroy_window): Move code to x_free_frame_resources.
5691
c9e7db78 5692 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5693 (Fx_create_frame, x_create_tip_frame):
5694 Move terminal->reference_count++ just before making the frame
75f1671a 5695 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5696 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5697
a6fc3b5c
EZ
56982011-11-05 Eli Zaretskii <eliz@gnu.org>
5699
5700 Support MSVC build with newer versions of Visual Studio.
5701 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5702 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5703 nt/gmake.defs.
5704
5705 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5706 which are not supported by MSVC.
5707 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5708 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5709 bitfields.
5710 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5711 types in bitfields.
5712 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5713
5714 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5715
58179cce 57162011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5717
5718 Support MSVC build with newer versions of Visual Studio.
5719 * w32.c: Don't include w32api.h for MSVC.
5720 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5721
5722 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5723 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5724 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5725 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5726 e_* cousins.
5727 (alloca) [_MSC_VER]: Define to _alloca.
5728
5729 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5730
5731 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5732
a58c13ed
EZ
57332011-11-04 Eli Zaretskii <eliz@gnu.org>
5734
5735 * xdisp.c (note_mouse_highlight): If either of
5736 previous/next-single-property-change returns nil, treat that as
5737 the beginning or the end of the buffer. (Bug#9955)
5738
fe0b6370
JD
57392011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5740
a58c13ed 5741 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5742 label is not null (Bug#9951).
5743 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5744 may be NULL.
5745
89bd5ee1
EZ
57462011-11-04 Eli Zaretskii <eliz@gnu.org>
5747
5748 * window.c (Fwindow_body_size): Mention in the doc string that the
5749 return value is in frame's canonical units. (Bug#9949)
5750
84c3edb9
EZ
57512011-11-03 Eli Zaretskii <eliz@gnu.org>
5752
4e2fb5c7
EZ
5753 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5754
84c3edb9 5755 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5756 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5757 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5758
bc17a887
EZ
57592011-11-01 Eli Zaretskii <eliz@gnu.org>
5760
5761 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5762 Don't stop backward scan on the continuation glyph, even though
5763 its CHARPOS is positive.
6d5eb5b0
SM
5764 (mouse_face_from_buffer_pos, note_mouse_highlight):
5765 Rename cover_string to disp_string.
bc17a887 5766
4ee88440
MR
57672011-11-01 Martin Rudalics <rudalics@gmx.at>
5768
5769 * window.c (temp_output_buffer_show): Don't use
5770 Vtemp_buffer_show_specifiers.
5771 (Vtemp_buffer_show_specifiers): Remove unused variable.
5772
c2ff3c02
EZ
57732011-10-30 Eli Zaretskii <eliz@gnu.org>
5774
5775 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5776 past the beginning of the current glyph matrix.
5777
58179cce 57782011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5779
5780 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5781 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5782 HAVE_GTK3 (Bug#9869).
b77a6a7f 5783
3b574623
JD
5784 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5785 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5786
b77a6a7f
JD
5787 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5788
5789 * xterm.c: Declare x_handle_net_wm_state to return int.
5790 (handle_one_xevent): Check if we are iconified but don't have
5791 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5792 (get_current_wm_state): Return non-zero if not hidden,
5793 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5794 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5795 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5796 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5797
196e41e4
PE
57982011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5799
5800 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5801 so that this new function doesn't get optimized away by a
5802 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5803
021f2e1a
AS
58042011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5805
5806 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5807
8b058d44
EZ
58082011-10-29 Eli Zaretskii <eliz@gnu.org>
5809
5810 Fix the `xbytecode' command.
5811 * .gdbinit (xprintbytestr): New command.
b50a28de 5812 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5813 (xbytecode): Print the byte-code string as well.
5814
4452fb80
EZ
58152011-10-29 Kim Storm <storm@cua.dk>
5816
8b058d44
EZ
5817 * alloc.c (which_symbols): New function.
5818
21b72067
AS
58192011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5820
5821 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5822 line. (Bug#9903)
5823
83ed7b5c
GM
58242011-10-29 Glenn Morris <rgm@gnu.org>
5825
5826 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5827 Not clear what it was for, and it causes various bugs. (Bug#9839)
5828
5a7a728b
EZ
58292011-10-28 Eli Zaretskii <eliz@gnu.org>
5830
5831 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5832 possible random value that matches one of those tested as
5833 condition to clear the mouse face.
5834
d3d0842f
CY
58352011-10-28 Chong Yidong <cyd@gnu.org>
5836
5837 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5838
31b39d13
DN
58392011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5840
5841 * window.c (make_window): Initialize phys_cursor_on_p.
5842
9aba6043
SM
58432011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5844
5845 * lisp.h (struct Lisp_Symbol): Update comments.
5846
c20992f4
JB
58472011-10-28 Juanma Barranquero <lekktu@gmail.com>
5848
5849 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5850
db4f02f2
EZ
58512011-10-28 Eli Zaretskii <eliz@gnu.org>
5852
5853 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5854 <oslsachem@gmail.com> for helping to debug this.
5855
5856 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5857 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5858 (g_b_init_get_glyph_outline_w): New static variables.
5859 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5860 (GetGlyphOutlineW_Proc): New typedefs.
5861 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5862 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5863 New functions.
5864 (w32font_open_internal, compute_metrics):
5865 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5866 instead of calling the "wide" APIs directly.
5867
5868 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5869
5870 * w32.h (syms_of_w32font): Add prototype.
5871
87e68db4
JB
58722011-10-27 Juanma Barranquero <lekktu@gmail.com>
5873
5874 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5875 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5876 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5877 (Fmove_to_window_line): Doc fix.
5878
435c1d67
CY
58792011-10-27 Chong Yidong <cyd@gnu.org>
5880
5881 * process.c (make_process): Set gnutls_state to NULL.
5882
5883 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5884 non-NULL, regardless of GNUTLS_INITSTAGE.
5885 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5886 an error. Set process slots as soon as we allocate them.
5887
5888 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5889
9c6c6f49
CY
58902011-10-27 Chong Yidong <cyd@gnu.org>
5891
9aba6043
SM
5892 * gnutls.c (emacs_gnutls_deinit): New function.
5893 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5894 (Fgnutls_deinit, Fgnutls_boot): Use it.
5895
5896 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5897 (deactivate_process): Call emacs_gnutls_deinit.
5898
657d08d3
JB
58992011-10-27 Juanma Barranquero <lekktu@gmail.com>
5900
5901 * image.c (x_create_x_image_and_pixmap):
5902 * w32.c (sys_rename, w32_delayed_load):
5903 * w32font.c (fill_in_logfont):
5904 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5905
5430d399
JB
59062011-10-26 Juanma Barranquero <lekktu@gmail.com>
5907
5908 * w32fns.c (w32_default_color_map): New function,
5909 extracted from Fw32_default_color_map.
a7ef684b 5910 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5911
fe0055fa
PE
59122011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5913
5914 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5915
e6346438
SM
59162011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5917
5918 * keyboard.c (test_undefined): New function (bug#9751).
5919 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5920
e112cc37
ET
59212011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5922
5923 * sysdep.c (init_sys_modes): Fix the check for the controlling
5924 terminal (Bug#6649).
5925
7b5d6677
EZ
59262011-10-20 Eli Zaretskii <eliz@gnu.org>
5927
5928 * dispextern.h (struct bidi_it): New member next_en_type.
5929
5930 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5931 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5932 current character, check also for next_en_type being WEAK_EN.
5933 (bidi_resolve_weak): Don't enter the expensive loop if the current
5934 position is before next_en_pos. Record the bidi type of the first
5935 non-ET, non-BN character we find, in addition to its position.
5936 (bidi_level_of_next_char): Invalidate next_en_type when
5937 next_en_pos is over-stepped.
5938
7da0b018
PE
59392011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5940
5941 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5942 * editfns.c: Rewrite current-time-zone so that it invokes
5943 the equivalent of (format-time-string "%Z") to get the time zone name.
5944 This fixes a bug when the time zone name contains characters that
5945 need converting from the system time locale to Emacs internal format.
5946 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5947 that patch fixed format-time-string to do the conversion, but
5948 I forgot to fix current-time-zone.
5949 (format_time_string): New function, containing most of
5950 what Fformat_time_string used to contain.
5951 (Fformat_time_string): Rewrite in terms of format_time_string.
5952 This doesn't change this function's behavior.
5953 (current-time-zone): Rewrite to use format_time_string.
5954 This fixes the bug reported by Michael Schierl in
5955 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5956 Jason Rumney's 2007-06-07 change worked around this bug, but
5957 didn't fix it.
5958 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5959
8547b010
EZ
59602011-10-19 Eli Zaretskii <eliz@gnu.org>
5961
5962 * xdisp.c (start_display): If the character at POS is displayed
5963 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5964 (try_window_reusing_current_matrix): If a line ends in a display
5965 vector or the next line starts in a display vector, continue
5966 redrawing the window even though the character position of
5967 start_row was reached.
8547b010
EZ
5968 (Bug#9771, part 2)
5969
4e948d15
CY
59702011-10-18 Chong Yidong <cyd@gnu.org>
5971
5972 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5973 with nobreak-char-display too.
5974
4787455f
EZ
59752011-10-18 Eli Zaretskii <eliz@gnu.org>
5976
5977 Fix part 3 of bug#9771.
5978 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5979 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5980 non-neutral characters if the current character is a paragraph
5981 separator (a.k.a. Newline). This avoids running the same
5982 expensive loop twice, once when we consume the preceding newline
5983 and the other time when the line actually needs to be displayed.
5984 Avoid the loop when we see neutrals on the base embedding level
5985 following a character whose directionality is the same as the
5986 paragraph's. This avoids running the expensive loop when a line
5987 ends in a long sequence of neutrals, like control characters.
5988 Add assertion against STRONG_AL type. Slightly rearrange code
5989 that determines the type of a neutral given the first non-neutral
5990 that follows it.
5991 (bidi_level_of_next_char): Set next_en_pos to zero when
5992 invalidating its info.
5993
2c91f553
EZ
59942011-10-17 Eli Zaretskii <eliz@gnu.org>
5995
5996 * xdisp.c (push_display_prop): Determine whether to record string
5997 or buffer position by IT->string, not by IT->method. Allow
5998 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5999 (move_it_vertically_backward): Don't look for character position
6000 immediately after the newline when in a continuation line.
6001 (Bug#9771, part 1)
2c91f553 6002
c7b08b0d
MR
60032011-10-15 Martin Rudalics <rudalics@gmx.at>
6004
6005 * window.c (coordinates_in_window): Rewrite and delabelize
6006 vertical border check. (Bug#5357) (Bug#9618)
6007
6b02f655
SM
60082011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6009
6010 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6011 errors in XSetWindowBorder (bug#9310).
6012
81d40c92
DA
60132011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6014
6015 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6016 avoid crash when xmalloc overrun checking is enabled.
6017
d4172c3b
EZ
60182011-10-13 Eli Zaretskii <eliz@gnu.org>
6019
6020 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6021 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6022 cursor motion with <left> and <right> arrow keys.
6023
6024 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6025 some callers set that themselves.
6026
b00eea75
EZ
60272011-10-12 Eli Zaretskii <eliz@gnu.org>
6028
6029 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6030 display string and the previous row comes from the same string and
6031 is empty. (Bug#9739) (Bug#9738)
6032
8fe012c4
SM
60332011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6034
6035 * doc.c (get_doc_string): Encode file name (bug#9735).
6036
0074aef2
EZ
60372011-10-12 Eli Zaretskii <eliz@gnu.org>
6038
79beb178
EZ
6039 * bidi.c (bidi_level_of_next_char):
6040 * xdisp.c (get_visually_first_element): Remove old incorrect
6041 comments regarding the Unicode Line Separator character.
6042
0074aef2
EZ
6043 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6044
6e4b3fbe
DA
60452011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6046
6047 * alloc.c (Fgc_status): Do not access beyond zombies array
6048 boundary if nzombies > MAX_ZOMBIES.
6049 * alloc.c (dump_zombies): Add missing format specifier.
6050
0324f3af
PE
60512011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6052
b5525cac
PE
6053 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6054 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6055
0324f3af
PE
6056 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6057 Some packages use them to denote characters with modifiers.
6058
e9b5f888
AS
60592011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6060
6061 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6062 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6063 matching a pp-number. Rename parameter var to var1.
6064
127827c0
SM
60652011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6066
6067 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6068
c8fd3bd0
GM
60692011-10-08 Glenn Morris <rgm@gnu.org>
6070
6071 * callint.c (Fcall_interactively): Give a more explicit error for the
6072 'c' case with a non-character input. (Bug#8479)
6073
352ec8ff
EZ
60742011-10-08 Eli Zaretskii <eliz@gnu.org>
6075
03669ccb
EZ
6076 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6077 lines.
7061c986
EZ
6078 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6079 lines that are hscrolled on the left.
03669ccb 6080
352ec8ff
EZ
6081 * dispnew.c (buffer_posn_from_coords): Account for a possible
6082 presence of header-line. (Bug#4426)
6083
a66cfb1c
SM
60842011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6085
6b02f655
SM
6086 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6087 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6088
7c5ee88e
PE
60892011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6090
6091 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6092 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6093 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6094 this makes Emacs dump core during garbage collection on rare
6095 occasions. sizeof is obviously inferior to offsetof here, so
6096 stick with offsetof.
6097 (GC_POINTER_ALIGNMENT): New macro.
6098 (mark_memory): Omit 3rd (offset) arg; caller changed.
6099 Don't assume EMACS_INT alignment is the same as pointer alignment.
6100
df1bbe5b
SM
61012011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6102
6103 * keyboard.c (read_key_sequence_remapped): New var.
6104 (read_key_sequence): Compute remapping in the right buffer.
6105 (command_loop_1): Use read_key_sequence's remapping directly.
6106
51553db6
SM
61072011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6108
32c1fffd
SM
6109 * dired.c (file_name_completion): Don't expand file name.
6110 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6111 before checking file name handler.
6112
51553db6
SM
6113 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6114 they've been requested explicitly (bug#9591).
6115
b6bd1599 61162011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6117
6118 * keymap.c (Fsingle_key_description): Use make_specified_string
6119 instead of build_string to build string from push_key_description.
6120 (Bug#5193)
6121
f701dc2a
PE
61222011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6123
4222c55d
PE
6124 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6125 This fixes a Y2038 bug on 64-bit hosts.
6126 * buffer.c (reset_buffer):
6127 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6128 (Fclear_buffer_auto_save_failure):
6129 Use 0, not -1, to represent an unset failure time, since time_t
6130 might not be signed.
6131
f701dc2a
PE
6132 Remove dependency on glibc malloc internals.
6133 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6134 Move back here from lisp.h, but with their new implementations.
6135 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6136 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6137 * charset.c (charset_table_init): New static var.
6138 (syms_of_charset): Use it instead of xmalloc. This removes a
6139 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6140 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6141 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6142 Move back to alloc.c.
6143 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6144 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6145
9ceebf39
JD
61462011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6147
6148 * nsterm.m (windowDidResize): Call x_set_window_size only when
6149 ns_in_resize is true. Otherwise set pixelwidth/height and
6150 call change_frame_size (Bug#9628).
6151
cb993c58
PE
61522011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6153
3930c88b
PE
6154 Port --enable-checking=all to Fedora 14 x86-64.
6155 * charset.c (syms_of_charset): Also account for glibc malloc's
6156 internal overhead when calculating the initial malloc maximum.
6157
cb993c58
PE
6158 Port --enable-checking=all to Fedora 14 x86.
6159 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6160 Move to lisp.h.
6161 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6162 (overrun_check_realloc, overrun_check_free):
6163 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6164 That way, xmalloc returns a properly-aligned pointer even if
6165 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6166 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6167 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6168 into account when calculating the initial malloc maximum.
6169 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6170 Move here from alloc.c, so that charset.c can use it too.
6171 Properly align; the old code wasn't right for common 32-bit hosts
6172 when configured with --enable-checking=all.
6173 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6174 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6175
31bed486
EZ
61762011-09-29 Eli Zaretskii <eliz@gnu.org>
6177
04c70788 6178 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6179 use EDOM.
6180
fbcaa2f3
EZ
61812011-09-28 Eli Zaretskii <eliz@gnu.org>
6182
6183 * xdisp.c (compute_display_string_end): If there's no display
6184 string at CHARPOS, return -1.
6185
6186 * bidi.c (bidi_fetch_char): When compute_display_string_end
6187 returns a negative value, treat the character as a normal
6188 character not covered by a display string. (Bug#9624)
6189
a239d4e9
JB
61902011-09-28 Juanma Barranquero <lekktu@gmail.com>
6191
6192 * lread.c (Fread_from_string): Fix typo in docstring.
6193
88652fd5
EZ
61942011-09-27 Eli Zaretskii <eliz@gnu.org>
6195
6196 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6197 newline, reseat the iterator instead of bidi-iterating there one
6198 character at a time. (Bug#9610)
32c1fffd
SM
6199 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6200 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6201
ed497dd4
AS
62022011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6203
6204 * lread.c (readevalloop): Use correct code for NBSP.
6205 (read1): Likewise. (Bug#9608)
6206
b2bf61aa
MA
62072011-09-25 Michael Albinus <michael.albinus@gmx.de>
6208
6209 * dbusbind.c (Fdbus_register_signal): When service is not
6210 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6211
32bbb17c
GM
62122011-09-25 Glenn Morris <rgm@gnu.org>
6213
6214 * buffer.c (truncate-lines): Doc fix.
6215
94e0933e
CY
62162011-09-24 Chong Yidong <cyd@stupidchicken.com>
6217
6218 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6219 (Fset_window_next_buffers): Doc fix.
6220
cddde921
GM
62212011-09-24 Glenn Morris <rgm@gnu.org>
6222
6223 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6224
1260aef1
PE
62252011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6226
25b4bfa0
PE
6227 Fix minor problems found by static checking.
6228 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6229 * indent.c (Fvertical_motion): Fix == vs = typo.
6230
e3cbd34b
EZ
62312011-09-24 Eli Zaretskii <eliz@gnu.org>
6232
a66cfb1c
SM
6233 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6234 Default value is now t. Doc fix.
6bf7006f 6235
e3cbd34b 6236 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6237 logic when moving up, not only when moving down. Fix the
e3cbd34b 6238 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6239 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6240
6241 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6242 CHARPOS is covered by a display string which includes newlines.
6243 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6244 is covered by a display string with embedded newlines.
6245
a3de0cbd
MA
62462011-09-24 Michael Albinus <michael.albinus@gmx.de>
6247
6248 * dbusbind.c (Fdbus_register_signal): Add match rule to
6249 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6250 (Fdbus_register_method, Vdbus_registered_objects_table):
6251 Fix docstring.
a3de0cbd 6252
b260039d
JM
62532011-09-24 Jim Meyering <meyering@redhat.com>
6254
32c1fffd 6255 do not ignore write error for any output size
b260039d
JM
6256 The previous change was incomplete.
6257 While it makes emacs --batch detect the vast majority of stdout
6258 write failures, errors were still ignored whenever the output size is
6259 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6260 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6261 && echo FAIL: ignored write error
6262 FAIL: ignored write error
6263 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6264 && echo FAIL: ignored write error
6265 FAIL: ignored write error
6266 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6267
8eca8a7c
AS
62682011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6269
6270 * emacs.c (Fkill_emacs): In noninteractive mode exit
6271 non-successfully if a write error occurred on stdout. (Bug#9574)
6272
3341db62
EZ
62732011-09-21 Eli Zaretskii <eliz@gnu.org>
6274
6275 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6276 the xassert test.
6277
6278 * dispextern.h (struct it): Update the comment documenting what
6279 can it->OBJECT be.
6280
8c203dbf
EZ
62812011-09-20 Eli Zaretskii <eliz@gnu.org>
6282
6283 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6284 a display string, extend search for cursor position to end of row.
6285 (find_row_edges): If the row ends in a newline from a display
6286 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6287 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6288 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6289 non-empty line. Fixes confusing cursor motion with arrow keys at
6290 the beginning of a line that starts with whitespace.
8c203dbf 6291
a4824228
LMI
62922011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6293
6294 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6295 (bug#9493).
6296
33ed493b
CY
62972011-09-18 Chong Yidong <cyd@stupidchicken.com>
6298
6299 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6300 boolean (Bug#9154).
6301
56cd55c8
EZ
63022011-09-18 Eli Zaretskii <eliz@gnu.org>
6303
6304 * xdisp.c (display_line): Record maximum and minimum buffer
6305 positions even if no glyphs were produced (e.g., by a zero-width
6306 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6307 buffer positions that will be removed from the glyph row because
6308 they don't fit.
c02dcedf
EZ
6309 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6310 column is beyond frame width: don't subtract 1 "pixel" when
6311 computing width of the stretch.
3e62b7e0
EZ
6312 (reseat_at_next_visible_line_start): Undo the change made on
6313 2011-09-17 that saved paragraph information and restored it after
6314 the call to `reseat'. (Bug#9545)
56cd55c8 6315
5ed99d36 63162011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6317
6318 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6319 and turn window cursor on if cleared (Bug#9415).
6320
5ed99d36 63212011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6322
6323 * search.c (boyer_moore): Take unibyte characters from pattern
6324 literally. (Bug#9458)
6325
9bade7b2
EZ
63262011-09-18 Eli Zaretskii <eliz@gnu.org>
6327
6328 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6329
e5e9d610
PE
63302011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6331
87e4427a
PE
6332 Fix minor problem found by static checking.
6333 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6334 initialized, to pacify gcc -Wuninitialized.
6335
e5e9d610
PE
6336 * fileio.c: Report proper errno when syscall falls.
6337 (Finsert_file_contents): Save and restore errno,
6338 so that report_file_error outputs the correct diagnostic.
6339 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6340
a1674f0b
EZ
63412011-09-18 Eli Zaretskii <eliz@gnu.org>
6342
6343 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6344
fbfb6dd4
EZ
63452011-09-17 Eli Zaretskii <eliz@gnu.org>
6346
6347 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6348 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6349
bb187662
EZ
63502011-09-17 Eli Zaretskii <eliz@gnu.org>
6351
1137e8b8 6352 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6353 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6354
6355 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6356 (bidi_find_paragraph_start): Search back for paragraph beginning
6357 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6358 (bidi_move_to_visually_next): Only trigger paragraph-related
6359 computations when the last character is a newline or at EOB, not
6360 just any NEUTRAL_B. (Bug#9470)
6361
bb187662
EZ
6362 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6363 truncated lines if point is covered by a display string. (Bug#9524)
6364
2e621251
PE
63652011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6366
6367 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6368 (cons_to_x_long): New function.
6369 (lisp_data_to_selection_data): Use it. Correct the test for
6370 short-versus-long data; it was negated. Break out of vector
6371 loop, for efficiency, when a long datum is discovered.
6372
91a15bc6
SM
63732011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6374
6375 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6376
b41c3a35
EZ
63772011-09-16 Eli Zaretskii <eliz@gnu.org>
6378
6379 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6380 GCC PR/17406) by declaring this function with external scope.
6381
7812ba2d
PE
63822011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6383
6384 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6385 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6386
cf7edc2a
AS
63872011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6388
6389 * editfns.c (Fformat): Correctly handle text properties on "%%".
6390
bd01620e
EZ
63912011-09-15 Eli Zaretskii <eliz@gnu.org>
6392
6393 * xterm.c (x_draw_composite_glyph_string_foreground):
6394 * w32term.c (x_draw_composite_glyph_string_foreground):
6395 * term.c (encode_terminal_code):
6396 * composite.c (composition_update_it, get_composition_id):
6397 * xdisp.c (get_next_display_element)
6398 (fill_composite_glyph_string): Add comments about special meaning
6399 of TAB characters in a composition.
6400
a02719a3
PE
64012011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6402
6403 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6404 This occurs when processing a multibyte format.
6405 Problem reported by Wolfgang Jenker.
a02719a3 6406
72589a3c
JB
64072011-09-15 Johan Bockgård <bojohan@gnu.org>
6408
6409 * xdisp.c (try_cursor_movement): Only check for exact match if
6410 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6411
1c14176c
PE
64122011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6413
6414 Remove unused external symbols.
6415 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6416 * xdisp.c (calc_pixel_width_or_height): Now static.
6417 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6418 * indent.c (check_display_width):
6419 * w32term.c: Fix comment to match code.
6420 * xterm.c, xterm.h (x_catching_errors): Remove.
6421
d2eea5b5
PE
64222011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6423
6424 * xselect.c: Use signed conversions more consistently (Bug#9498).
6425 (selection_data_to_lisp_data): Assume incoming selection data are
6426 signed integers, not unsigned. This is to be consistent with
6427 outgoing selection data, which was modified to use signed integers
6428 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6429 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6430 expects long, not unsigned long.
6431
46888499
EZ
64322011-09-14 Eli Zaretskii <eliz@gnu.org>
6433
6434 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6435 computation of loop end. Reported by Johan Bockgård
6436 <bojohan@gnu.org>.
6437
ef8ef9fb
CY
64382011-09-13 Chong Yidong <cyd@stupidchicken.com>
6439
6440 * frame.c (Fother_visible_frames_p): Function deleted.
6441
fa819fed
EZ
64422011-09-12 Eli Zaretskii <eliz@gnu.org>
6443
6444 * indent.c (compute_motion): Process display vector front to back
6445 rather than the other way around. (Bug#2496)
6446
2ba8e008
SM
64472011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6448
6449 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6450
20f53c69
CY
64512011-09-11 Chong Yidong <cyd@stupidchicken.com>
6452
6453 * minibuf.c (Fread_from_minibuffer): Doc fix.
6454
d562d7a4
EZ
64552011-09-11 Eli Zaretskii <eliz@gnu.org>
6456
6457 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6458 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6459
1c4d7f3d
LMI
64602011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6461
6462 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6463 value for non-existent files.
6464
b885bf36
EZ
64652011-09-11 Eli Zaretskii <eliz@gnu.org>
6466
6467 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6468 set its "size" to -1. This will set the modtime_size field of
6469 the corresponding buffer to -1, which is what
6470 verify-visited-file-modtime expects for files that do not exist.
6471 (Bug#9139)
6472
6612f0bf
PE
64732011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6474
6475 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6476 here ...
6477 * lisp.h: ... from here. push_key_description is no longer
6478 defined in keyboard.c, so its declaration should not be in
6479 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6480 logically belongs with push_key_description.
6481
dfb3f755
PE
64822011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6483
6484 * buffer.h: Include <sys/types.h> instead of <time.h>.
6485 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6486 Problem reported by Herbert J. Skuhra.
6487
3134906c
LMI
64882011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6489
6490 * xml.c (parse_region): Make the parsing work for
6491 non-comment-starting XML files again (bug#9144).
6492
8d903f4e
AS
64932011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6494
6495 * image.c (gif_load): Fix calculation of bottom and right corner.
6496 (Bug#9468)
6497
80ad64f4
EZ
64982011-09-10 Eli Zaretskii <eliz@gnu.org>
6499
6500 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6501 redisplay in small windows.
6502
208a048d
EZ
65032011-09-09 Eli Zaretskii <eliz@gnu.org>
6504
6505 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6506
9b1c252e
MR
65072011-09-08 Martin Rudalics <rudalics@gmx.at>
6508
6509 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6510 Operate on live windows only.
6511
2949f33b
JB
65122011-09-08 Juanma Barranquero <lekktu@gmail.com>
6513
6514 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6515
e08dcafd
EZ
65162011-09-07 Eli Zaretskii <eliz@gnu.org>
6517
6518 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6519 only under bidi iteration.
6520
115b96bd
JD
65212011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6522
6523 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6524
c8199d0f
PE
65252011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6526
6527 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6528 Without this fix, the command to link temacs failed due to an
6529 undefined symbol __builtin_isnan. This is because
6530 /usr/include/iso/math_c99.h #defines isnan(x) to
6531 __builtin_isnan(x), but the bundled gcc, which identifies itself
6532 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6533 a __builtin_isnan.
6534 * floatfns.c (isnan): #undef, and then #define to a clone of
6535 what's in data.c.
6536 (Fisnan): Always define, since it's always available now.
6537 (syms_of_floatfns): Always define isnan at the Lisp level.
6538
e39b275c 65392011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6540
6541 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6542
b2db44d9 65432011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6544
f4af5137 6545 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6546 The previous code assumed that file offsets (off_t values) fit in
6547 EMACS_INT variables, which is not true on typical 32-bit hosts.
6548 The code messed up by falsely reporting buffer overflow in cases
6549 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6550 when "big" contains more than 2**29 bytes, even though this
6551 inserts just one byte and does not overflow the buffer.
6552 (Finsert_file_contents): Store file offsets as off_t
6553 values, not as EMACS_INT values. Check for overflow when
6554 converting between EMACS_INT and off_t. When checking for
6555 buffer overflow or for overlap, take the offsets into account.
6556 Don't use EMACS_INT for small values where int suffices.
6557 When checking for overlap, fix a typo: ZV was used where
6558 ZV_BYTE was intended.
6559 (Fwrite_region): Don't assume off_t fits into 'long'.
6560 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6561
ecfc0a49
MA
65622011-09-05 Michael Albinus <michael.albinus@gmx.de>
6563
6564 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6565
6511acf2 65662011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6567
0999621a 6568 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6569
6570 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6571 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6572 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6573 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6574 (modify_event_symbol): Do not assume that the length of
6575 name_alist_or_stem is safe to alloca and fits in int.
6576 (Fexecute_extended_command): Likewise for function name and binding.
6577 (Frecursion_depth): Wrap around reliably on integer overflow.
6578 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6579 since some callers pass EMACS_INT values.
6580 (Fsingle_key_description): Don't crash if symbol name contains more
6581 than MAX_ALLOCA bytes.
6582 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6583 (get_minibuffer): Arg is now EMACS_INT, not int.
6584 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6585 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6586 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6587
2be7d702
PE
6588 * dbusbind.c (signature_cat): New function.
6589 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6590 Do not overrun buffer; instead, report string overflow.
6591
9d1df220
PE
6592 * dispnew.c (add_window_display_history): Don't overrun buffer.
6593 Truncate instead; this is OK since it's just a log.
6594
33ef5c64
PE
6595 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6596 even if the time zone offset is outlandishly large.
6597 Don't mishandle offset == INT_MIN.
6598
66c6fdd5
PE
6599 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6600 when creating daemon; the previous buffer-overflow check was incorrect.
6601
d749b01b
PE
6602 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6603 which has the guts of the old verror function.
6604
b5cd1905
PE
6605 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6606 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6607
6e1a67fb
PE
6608 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6609 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6610 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6611 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6612 length of string rather than counting it via multiple sprintfs;
6613 that's simpler and more reliable.
c21721cc
PE
6614 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6615 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6616 sprintf, in case result does not fit in int.
6617
c57b67fc
PE
6618 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6619 (fontset_from_font): Print it.
6620
8a401434
PE
6621 * frame.c (tty_frame_count): Now printmax_t, not int.
6622 (make_terminal_frame, set_term_frame_name): Print it.
6623 (x_report_frame_params): In X, window IDs are unsigned long,
6624 not signed long, so print them as unsigned.
6625 (validate_x_resource_name): Check for implausibly long names,
6626 and don't assume name length fits in 'int'.
6627 (x_get_resource_string): Don't blindly alloca invocation name;
6628 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6629 not fit in int.
6630
6e1a67fb
PE
6631 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6632 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6633 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6634
0df02bf3
PE
6635 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6636 Use esprintf, not sprintf, in case result does not fit in int.
6637
48e30793
PE
6638 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6639 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6640 it as a large positive number.
6641 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6642 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6643
a66ff6d8
PE
6644 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6645 in case result does not fit in int.
6646
aca216ff
PE
6647 * print.c (float_to_string): Detect width overflow more reliably.
6648 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6649 buffer overrun. Don't assume list length fits in 'int'. Treat
6650 print length of 0 as 0, not as infinity; to be consistent with other
6651 uses of print length in this function. Don't overflow print length
6652 index. Don't assume hash table size fits in 'long', or that
6653 vectorlike size fits in 'unsigned long'.
6654
31c286f7
PE
6655 * process.c (make_process): Use printmax_t, not int, to format
6656 process-name gensyms.
6657
55e5faa1
PE
6658 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6659
80f2e268
PE
6660 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6661 to avoid potential buffer overrun.
6662
670741ab
PE
6663 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6664 if X resource line is longer than 512 bytes.
6665
b7163a50
PE
6666 * xfns.c (x_window): Make sprintf buffer a bit bigger
6667 to avoid potential buffer overrun.
6668
ae58ff1f
PE
6669 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6670
c43c8a6a
PE
6671 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6672
3f8236f4
PE
66732011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6674
53e9fe90 6675 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6676 Without these, Emacs silently mishandles large integers sometimes.
6677 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6678 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6679
6511acf2
PE
6680 * xdisp.c (try_window_id): Check Emacs fixnum range before
6681 converting to 'int'.
806add1d 6682
6511acf2 6683 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6684 Check that an Emacs fixnum is in range before assigning it to 'int'.
6685 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6686 values converted from Emacs fixnums.
6687 (Frecenter): Don't wrap around a line count if it is out of 'int'
6688 range; instead, treat it as an extreme value.
6689 (Fset_window_configuration, compare_window_configurations):
6690 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6691
6511acf2
PE
6692 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6693 that can exceed INT_MAX. Check that EMACS_INT value is in range
6694 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6695 (match_limit): Don't assume that a fixnum can fit in 'int'.
6696
6511acf2 6697 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6698 exceed INT_MAX.
6699
6511acf2 6700 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6701 (Fvertical_motion): Don't wrap around LINES values that don't fit
6702 in 'int'. Instead, treat them as extreme values. This is good
6703 enough for windows, which can't have more than INT_MAX lines anyway.
6704
fcb901a7
LMI
67052011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6706
0f2f6b6d
LMI
6707 * Require libxml/parser.h to avoid compilation warning.
6708
fcb901a7
LMI
6709 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6710
6711 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6712 since this reportedly can destroy thread storage.
6713
6e20a0d4
CY
67142011-08-30 Chong Yidong <cyd@stupidchicken.com>
6715
6716 * syntax.c (find_defun_start): Update all cache variables if
6717 exiting early (Bug#9401).
6718
148ae00e
EZ
67192011-08-30 Eli Zaretskii <eliz@gnu.org>
6720
f6cfbd8f
EZ
6721 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6722
148ae00e
EZ
6723 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6724 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6725 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6726
6727 * term.c (tty_append_glyph): New function.
6728 (produce_stretch_glyph): Static function and its prototype deleted.
6729
a66cfb1c
SM
6730 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6731 Add prototypes.
148ae00e 6732
c4a07a4c
PE
67332011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6734
6735 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6736 when checking :margin (Bug#9390).
6737 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6738 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6739 so that the name doesn't mislead. All uses changed.
6740
6bc8cd65
JB
67412011-08-28 Johan Bockgård <bojohan@gnu.org>
6742
6743 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6744 set_tty_hooks.
6745
dca4927e
EZ
67462011-08-27 Eli Zaretskii <eliz@gnu.org>
6747
6748 * xdisp.c (move_it_to): Don't bail out early when reaching
6749 position beyond to_charpos, if we are scanning backwards.
6750 (move_it_vertically_backward): When DY == 0, make sure we get to
6751 the first character in the line after the newline.
6752
f2cad773
PE
67532011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6754
6755 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6756 (ccl_driver): Do not generate an out-of-range pointer.
6757 (Fccl_execute_on_string): Remove unnecessary check for
6758 integer overflow, noted by Stefan Monnier in
6759 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6760 Remove a FIXME that didn't need fixing.
6761 Simplify the newly-introduced buffer reallocation code.
6762
0cae2cdb
JB
67632011-08-27 Juanma Barranquero <lekktu@gmail.com>
6764
6765 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6766
5fc295a4 67672011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6768
70c60eb2 6769 Integer and memory overflow issues (Bug#9196).
726e0ab1 6770
d31850da
PE
6771 * doc.c (get_doc_string): Rework so that
6772 get_doc_string_buffer_size is the actual buffer size, rather than
6773 being 1 less than the actual buffer size; this makes xpalloc more
6774 convenient.
6775
a69fbedb
PE
6776 * image.c (x_allocate_bitmap_record, cache_image):
6777 * xselect.c (Fx_register_dnd_atom):
6778 Simplify previous changes by using xpalloc.
6779
fe5c5d37
PE
6780 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6781 since either will do and ptrdiff_t is convenient with xpalloc.
6782
0065d054
PE
6783 * charset.c (charset_table_size)
6784 (struct charset_sort_data.priority): Now ptrdiff_t.
6785 (charset_compare): Don't overflow if priorities differ greatly.
6786 (Fsort_charsets): Don't assume list length fits in int.
6787 Check for size-calculation overflow when allocating sort data.
6788 (syms_of_charset): Allocate an initial charset table that is
6789 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6790
6791 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6792
6793 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6794 The actual value is always <= INT_MAX, and leaving it unsigned made
6795 overflow checking harder.
6796
6797 * dispextern.h (struct glyph_matrix.rows_allocated)
6798 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6799 with xpalloc. The values are still always <= INT_MAX.
6800
6801 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6802
6803 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6804 (SAFE_NALLOCA): New macro.
6805
6806 * region-cache.c (struct boundary.pos, find_cache_boundary)
6807 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6808 (set_cache_region, invalidate_region_cache)
6809 (revalidate_region_cache, know_region_cache, region_cache_forward)
6810 (region_cache_backward, pp_cache):
6811 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6812 so that ptrdiff_t * can be passed to xpalloc.
6813 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6814 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6815 (pp_cache): Don't assume cache_len fits in int.
6816 * region-cache.h: Adjust extern decls to match.
6817
6818 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6819 EMACS_INT, since either will do, for xpalloc.
6820
6821 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6822 (xnmalloc, xnrealloc, xpalloc): New functions.
6823
726e0ab1
PE
6824 * bidi.c (bidi_shelve_header_size): New constant.
6825 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6826 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6827
51f30bc5 6828 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6829 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6830 (overlay_strings):
6831 Don't update size of array until after memory allocation succeeds,
6832 because xmalloc/xrealloc may not return.
0065d054
PE
6833 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6834 now that we have proper integer overflow checking.
6835 (record_overlay_string, overlay_strings): Catch overflows when
6836 calculating size of overlay_str_buf.
726e0ab1 6837
0065d054
PE
6838 * callproc.c (Fcall_process): Check for size overflow when
6839 calculating size of args2.
6840 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6841 Normally we prefer signed values, but sticking with ptrdiff_t would
6842 require adding more-complicated checks.
726e0ab1
PE
6843
6844 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6845 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6846 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6847 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6848
6849 * character.c (Fstring): Check for size-calculation overflow.
6850
6851 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6852 unnecessary integer overflow. Check for size overflow.
6853 (encode_coding_object): Don't update size until xmalloc succeeds.
6854
6855 * composite.c (get_composition_id): Check for overflow in glyph
6856 length calculations.
6857
6858 Integer and memory overflow fixes for display code.
6859 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6860 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6861 (scrolling_window): Check for overflow in size calculations.
6862 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6863 Don't assume glyph table len fits in int.
6864 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6865 (row_table_size): Now ptrdiff_t, not int.
6866 (scrolling_window): Avoid overflow in size calculations.
6867 Don't update size until allocation succeeds.
6868 * fns.c (concat): Check for overflow in size calculations.
6869 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6870 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6871 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6872
6873 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6874 (get_doc_string): Check for size calculation overflow.
6875 Don't update size until allocation succeeds.
6876 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6877 EMACS_INT, where ptrdiff_t will do.
6878 (Fsubstitute_command_keys): Check for string overflow.
6879
6880 * editfns.c (set_time_zone_rule): Don't assume environment length
6881 fits in int.
6882 (message_length): Now ptrdiff_t, not int.
6883 (Fmessage_box): Don't update size until allocation succeeds.
6884 Don't assume message length fits in int.
6885 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6886
0065d054
PE
6887 * emacs.c (main): Do not reallocate argv, since there is a null at
6888 the end that can be overwritten, and this way there's no need to
6889 worry about size-calculation overflow.
6890 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6891
6892 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6893 alloc succeeds.
6894 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6895
6896 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6897 (x_set_scroll_bar_width, x_figure_window_size):
6898 Check for integer overflow.
6899 (x_set_alpha): Do not assume XINT fits in int.
6900
6901 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6902 This is for the members text_lines, text_cols, total_lines, total_cols,
6903 where the system imposes an 'int' limit.
6904
6905 * fringe.c (Fdefine_fringe_bitmap):
6906 Don't update size until alloc works.
6907
6908 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6909 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6910
6911 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6912 Check for size-calculation overflow.
6913 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6914 do, as we prefer signed integers.
6915 (id_to_widget.max_size, id_to_widget.used)
6916 (xg_store_widget_in_map, xg_remove_widget_from_map)
6917 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6918 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6919 Use and return ptrdiff_t, not int.
6920 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6921 * gtkutil.h: Change prototypes to match the above.
6922
6923 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6924 are duplicate now that they've been promoted to lisp.h.
6925 (x_allocate_bitmap_record, x_alloc_image_color)
6926 (make_image_cache, cache_image, xpm_load):
6927 Don't update size until alloc is done.
6928 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6929 (x_detect_edges):
3256efce 6930 Check for size calculation overflow.
726e0ab1
PE
6931 (ct_colors_allocated_max): New constant.
6932 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6933 overflow.
3256efce 6934
726e0ab1
PE
6935 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6936 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6937 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6938 Use ptrdiff_t, not int, to count maps.
6939 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6940 calculations. Don't update size until allocation succeeds.
6941 Redo calculations to avoid overflow.
726e0ab1
PE
6942 * keyboard.h: Change prototypes to match the above.
6943
6944 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6945 to count maps.
6946 (current_minor_maps): Check for size calculation overflow.
6947 * keymap.h: Change prototypes to match the above.
6948
6949 * lread.c (read1, init_obarray): Don't update size until alloc done.
6950
6951 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6952 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6953
726e0ab1
PE
6954 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6955 Now ptrdiff_t, not int.
6956 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6957 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6958
6959 * process.c (Fnetwork_interface_list): Check for overflow
6960 in size calculation.
6961
6962 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6963
6964 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6965 overflow. Don't bother calling xmalloc when xrealloc will do.
6966
6967 * search.c (Freplace_match): Check for size calculation overflow.
6968 (Fset_match_data): Don't assume list lengths fit in 'int'.
6969
6970 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6971 for command line length. Do not attempt to address one before the
6972 beginning of an array, as that's not portable.
6973
6974 * term.c (max_frame_lines): Remove; unused.
6975 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6976 not int.
6977 (encode_terminal_code, calculate_costs): Check for size
6978 calculation overflow.
6979 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6980 table lengths and related sizes. Don't update size until alloc
6981 done. Redo calculations to avoid overflow.
6982 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6983
6984 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6985 subtracting pointers.
6986 (gobble_line): Check for overflow more carefully. Don't update size
6987 until alloc done.
6988
6989 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6990 Don't update size until alloc done.
6991 Redo size calculations to avoid overflow.
6992 Check for size calculation overflow.
0065d054 6993 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6994
6995 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6996 Use ptrdiff_t, not int, for sizes.
6997 (store_mode_line_noprop_char): Don't update size until alloc done.
6998
0065d054
PE
6999 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7000 Use ptrdiff_t, not int, for sizes.
7001 (Finternal_make_lisp_face, cache_face):
7002 Check for size calculation overflow.
7003 (cache_face): Treat size calculation overflows as if they were
7004 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7005
7006 * xfns.c (x_encode_text, x_set_name_internal)
7007 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7008 sizes, since they can exceed INT_MAX in size. Check for size
7009 calculation overflow.
7010
0065d054
PE
7011 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7012 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7013 Don't update size until alloc done.
7014
0065d054 7015 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7016 as sprintf is limited to int lengths.
1d526e2f 7017
252c5ee1
PE
7018 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7019 (X_LONG_MIN): New macros.
864d7ce7
PE
7020 Use them to make the following changes clearer.
7021 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7022 This change doesn't affect the value now, but it may help remind
7023 future maintainers not to raise the value too much later.
7024 (SELECTION_QUANTUM): Remove, replacing with ...
7025 (selection_quantum): ... new function, which avoids overflow.
7026 All uses changed.
7027 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7028 assumption that selection length fits in 'int'.
7029 (x_reply_selection_request, x_handle_selection_request)
7030 (x_get_window_property, receive_incremental_selection)
7031 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7032 (lisp_data_to_selection_data, clean_local_selection_data):
7033 Use ptrdiff_t, not int, to record length of selection.
7034 (x_reply_selection_request, x_get_window_property)
7035 (receive_incremental_selection, x_property_data_to_lisp):
7036 Redo calculations to avoid overflow.
7037 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7038 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7039 something.
7040 (x_get_window_property, receive_incremental_selection)
7041 (lisp_data_to_selection_data, x_property_data_to_lisp):
7042 Check for size-calculation overflow.
7043 (x_get_window_property, receive_incremental_selection)
7044 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7045 Don't store size until memory allocation succeeds.
7046 (x_get_window_property): Plug memory leak on memory exhaustion.
7047 Don't double-block input; malloc is safe here. Don't assume 2**34
7048 - 4 fits in unsigned long. Add an xassert to check
7049 XGetWindowProperty overflow. Be more careful about overflow
7050 calculations, and distinguish size from memory overflow better.
7051 (receive_incremental_selection): When tracing, don't assume
7052 unsigned int is less than INT_MAX.
7053 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7054 harmful) conversions of unsigned short to int.
7055 (lisp_data_to_selection_data): Don't assume that integers
7056 in the range -65535 through -1 fit in an X unsigned short.
7057 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7058 result parameters unless successful. Rely on cons_to_unsigned
7059 to report problems with elements; the old code wasn't right anyway.
7060 (x_check_property_data): Check for int overflow; we cannot use
7061 a wider type due to X limits.
7062 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7063
726e0ab1 7064 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7065
0065d054
PE
7066 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7067 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7068 (x_color_cells): Don't store size until memory allocation succeeds.
7069 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7070 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7071 (x_term_init): Don't assume length fits in int (sprintf is limited
7072 to int size).
bc18e09d 7073
ebfa62c0
PE
7074 Use ptrdiff_t for composition IDs.
7075 * character.c (lisp_string_width):
7076 * composite.c (composition_table_size, n_compositions)
7077 (get_composition_id, composition_gstring_from_id):
7078 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7079 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7080 * window.c (Frecenter):
7081 Use ptrdiff_t, not int, for composition IDs.
7082 * composite.c (get_composition_id): Check for integer overflow.
7083 * composite.h: Adjust prototypes to match the above changes.
7084
d3411f89
PE
7085 Use ptrdiff_t for hash table indexes.
7086 * category.c (hash_get_category_set):
7087 * ccl.c (ccl_driver):
7088 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7089 * coding.c (coding_system_charset_list, detect_coding_system):
7090 * coding.h (struct coding_system.id):
7091 * composite.c (get_composition_id, gstring_lookup_cache):
7092 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7093 * image.c (xpm_get_color_table_h):
7094 * lisp.h (hash_lookup, hash_put):
7095 * minibuf.c (Ftest_completion):
7096 Use ptrdiff_t for hash table indexes, not int (which is too
7097 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7098 32-bit --with-wide-int hosts).
7099
e097a6fa
PE
7100 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7101 Add a FIXME comment about memory leaks.
7102 (syms_of_charset): Don't assume xmalloc returns.
7103
5637687f
PE
7104 Don't assume that stated character widths fit in int.
7105 * character.c (Fchar_width, c_string_width, lisp_string_width):
7106 * character.h (CHAR_WIDTH):
7107 * indent.c (MULTIBYTE_BYTES_WIDTH):
7108 Use sanitize_char_width to avoid undefined and/or bad behavior
7109 with outlandish widths.
a66cfb1c 7110 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7111 now that we have two such functions. All uses changed.
7112 (sanitize_char_width): New inline function.
7113
a2271ba2
PE
7114 Don't assume that tab-width fits in int.
7115 * character.h (sanitize_width): New inline function.
7116 (SANE_TAB_WIDTH): New macro.
7117 (ASCII_CHAR_WIDTH): Use it.
7118 * indent.c (sane_tab_width): Remove. All uses replaced by
7119 SANE_TAB_WIDTH (current_buffer).
7120 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7121
18c52557
PE
7122 * fileio.c: Integer overflow issues with file modes.
7123 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7124
caeeedc1
PE
7125 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7126 Remove unreachable code.
7127 (read_hex, load_charset_map_from_file): Check for integer overflow.
7128
6df6ae42 7129 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7130 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7131 (x_send_scroll_bar_event): Likewise. Check that the size does not
7132 exceed limits imposed by XClientMessageEvent, as well as the usual
7133 ptrdiff_t and size_t limits.
7134
b13995db
PE
7135 * keyboard.c: Overflow, signedness and related fixes.
7136 (make_lispy_movement): Use same integer type in forward decl
7137 that is used in the definition.
7138 (read_key_sequence, keyremap_step):
7139 Change bufsize argument back to int, undoing my 2011-03-30 change.
7140 We prefer signed types, and int is wide enough here.
7141 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7142 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7143 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7144 length, not size_t. Use ptrdiff_t for index, not int.
7145 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7146 possibility of integer overflow.
7147
13464394
PE
7148 Overflow, signedness and related fixes for images.
7149
7150 * dispextern.h (struct it.stack[0].u.image.image_id)
7151 (struct_it.image_id, struct image.id, struct image_cache.size)
7152 (struct image_cache.used, struct image_cache.ref_count):
7153 * gtkutil.c (update_frame_tool_bar):
7154 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7155 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7156 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7157 * nsmenu.m (update_frame_tool_bar):
7158 * xdisp.c (calc_pixel_width_or_height):
7159 * xfns.c (image_cache_refcount):
7160 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7161 on typical 64-bit hosts.
7162
7163 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7164 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7165 Omit unnecessary casts to int.
7166 (parse_image_spec): Check that integers fall into 'int' range
7167 when the callers expect that.
7168 (image_ascent): Redo ascent calculation to avoid int overflow.
7169 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7170 (lookup_image): Remove unnecessary tests.
7171 (xbm_image_p): Locals are now of int, not EMACS_INT,
7172 since parse_image_check makes sure they fit into int.
7173 (png_load, gif_load, svg_load_image):
7174 Prefer int to unsigned where either will do.
7175 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7176 old tiff_error_handler and tiff_warning_handler.
7177 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7178 stack buffer overflows. It uses only the features of vsnprintf
7179 that are common to both POSIX and native Microsoft.
7180 (tiff_error_handler, tiff_warning_handler): Use it.
7181 (tiff_load, gif_load, imagemagick_load_image):
7182 Don't assume :index value fits in 'int'.
7183 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7184 (imagemagick_load_image): Check that crop parameters fit into
7185 the integer types that MagickCropImage accepts. Don't assume
7186 Vimagemagick_render_type has a nonnegative value. Don't assume
7187 size_t fits in 'long'.
7188 (gs_load): Use printmax_t to print the widest integers possible.
7189 Check for integer overflow when computing image height and width.
7190
c11821d4
EZ
71912011-08-26 Eli Zaretskii <eliz@gnu.org>
7192
7193 * xdisp.c (redisplay_window): Don't force window start if point
7194 will be invisible in the resulting window. (Bug#9324)
7195
0c95fcf7
EZ
71962011-08-25 Eli Zaretskii <eliz@gnu.org>
7197
7198 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7199 the display spec is of the form `(space ...)'.
7200 (handle_display_spec): Return the value returned by
7201 handle_single_display_spec, not just 1 or zero.
7202 (handle_single_display_spec): If the display spec is of the form
7203 `(space ...)', and specifies display in the text area, return 2
7204 rather than 1.
fee65a97 7205 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7206 accurately, and prefer exact match for point under bidi.
7207 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7208
7209 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7210 into disp_prop; all users changed.
7211
7212 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7213 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7214 for the text covered by the display property.
7215
e4ed06f1
CY
72162011-08-25 Chong Yidong <cyd@stupidchicken.com>
7217
7218 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7219 Change return value to nil.
7220 (Frecord_buffer): Delete unused function.
7221
f67cdd7f
EZ
72222011-08-24 Eli Zaretskii <eliz@gnu.org>
7223
5980d4c6
EZ
7224 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7225 buffers, return left-to-right.
8610fe8b
EZ
7226 (set_cursor_from_row): Consider candidate row a win if its glyph
7227 represents a newline and point is on that newline. Fixes cursor
7228 positioning on the newline at EOL of R2L text within L2R
7229 paragraph, and vice versa.
7230 (try_cursor_movement): Check continued rows, in addition to
7231 continuation rows. Fixes unwarranted scroll when point enters a
7232 continued line of R2L text within an L2R paragraph, or vice versa.
7233 (cursor_row_p): Consider the case of point being equal to
7234 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7235 from the end of a short line to the beginning of a continued line
7236 of R2L text within L2R paragraph.
7237 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7238 composed characters.
5980d4c6 7239
f67cdd7f
EZ
7240 * bidi.c (bidi_check_type): Use xassert.
7241 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7242 members.
7243
bca633fb
EZ
72442011-08-23 Eli Zaretskii <eliz@gnu.org>
7245
7246 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7247 a character.
7248
4a5885a7
CY
72492011-08-23 Chong Yidong <cyd@stupidchicken.com>
7250
7251 * nsfont.m (ns_otf_to_script): Fix typo.
7252
0902a04e
KH
72532011-08-22 Kenichi Handa <handa@m17n.org>
7254
7255 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7256 extra slot even if the purpose is char-code-property-table.
7257
1a2e6670
EZ
72582011-08-23 Eli Zaretskii <eliz@gnu.org>
7259
8ddde651
EZ
7260 * xdisp.c (redisplay_window): When computing centering_position,
7261 account for the height of the header line. (Bug#8874)
7262
425cc014
EZ
7263 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7264 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7265 candidate is selected by the mouse, and that candidate has a
7266 composed character under the mouse.
7267
1a2e6670
EZ
7268 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7269 coordinates reported by pos-visible-in-window-p for a composed
7270 character in column zero.
7271
8b76d6f8
SM
72722011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7273
7274 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7275
dac347dd
EZ
72762011-08-22 Eli Zaretskii <eliz@gnu.org>
7277
7278 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7279 consider it a hit if to_charpos is anywhere in the range of the
7280 composed buffer positions.
7281
e013fb34
CY
72822011-08-22 Chong Yidong <cyd@stupidchicken.com>
7283
7284 * image.c (gif_load): Don't assume that each subimage has the same
7285 dimensions as the base image. Handle disposal method that is
7286 "undefined" by the gif spec (Bug#9335).
7287
bd1ba3e8
CY
72882011-08-20 Chong Yidong <cyd@stupidchicken.com>
7289
7290 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7291 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7292
54a1215b
EZ
72932011-08-19 Eli Zaretskii <eliz@gnu.org>
7294
823564e5
EZ
7295 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7296 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7297 from an Org mode buffer to a Speedbar frame.
7298
54a1215b
EZ
7299 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7300 a composition, take its buffer position from IT->cmp_it.charpos.
7301 Fixes cursor positioning at the beginning of a line that begins
7302 with a composed character.
7303
9778ebcc
EZ
73042011-08-18 Eli Zaretskii <eliz@gnu.org>
7305
0be6ee06
EZ
7306 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7307 character bidirectional type, use STRONG_L instead. Fixes crashes
7308 in a buffer produced by `describe-categories'.
7309
9778ebcc
EZ
7310 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7311 members before the level stack, so they would be saved and
7312 restored when copying iterator state. Fixes incorrect reordering
7313 around TABs covered by display properties.
7314
156bffbe
AS
73152011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7316
6b02f655 7317 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7318
72ad093b
CY
73192011-08-17 Chong Yidong <cyd@stupidchicken.com>
7320
7321 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7322 (internal_condition_case_2, internal_condition_case_n):
7323 Remove unnecessary aborts (Bug#9081).
72ad093b 7324
35774242
EZ
73252011-08-17 Eli Zaretskii <eliz@gnu.org>
7326
7327 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7328 has no `load' handler, try opening the file locally. (Bug#9311)
7329
db76dd85
KB
73302011-08-16 Ken Brown <kbrown@cornell.edu>
7331
7332 * gmalloc.c: Expand comment.
7333
b215eee5
EZ
73342011-08-16 Eli Zaretskii <eliz@gnu.org>
7335
7336 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7337 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7338
a4579d33
KB
73392011-08-16 Ken Brown <kbrown@cornell.edu>
7340
7341 Fix memory allocation problems in Cygwin build (Bug#9273).
7342
7343 * unexcw.c ( __malloc_initialized): Declare external variable.
7344 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7345
8b76d6f8
SM
7346 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7347 New variables.
a4579d33
KB
7348 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7349 dumped emacs.
7350 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7351 in the static heap.
7352 [CYGWIN] (special_realloc): New function.
7353 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7354 requests to realloc storage in the static heap.
7355
3ebec551
PE
73562011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7357
7358 * bidi.c (bidi_initialize): Remove unused local.
7359
9fd8be00
EZ
73602011-08-15 Eli Zaretskii <eliz@gnu.org>
7361
6b02f655
SM
7362 * bidimirror.h:
7363 * biditype.h: Remove file.
7364 * makefile.w32-in ($(BLD)/bidi.$(O)):
7365 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7366
7367 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7368
7369 * chartab.c: Improve commentary for the uniprop_table API.
7370
32413314
EZ
7371 * bidi.c (bidi_paragraph_init): Support zero value of
7372 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7373 (bidi_initialize): Use uniprop_table instead of including
7374 biditype.h and bidimirror.h.
32413314 7375
9fd8be00
EZ
7376 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7377 coordinates of the iterator when restoring from ppos_it.
7378 (Bug#9296)
7379
5cf2b69b
KH
73802011-08-14 Kenichi Handa <handa@m17n.org>
7381
7382 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7383 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7384
daf17d00
EZ
73852011-08-14 Eli Zaretskii <eliz@gnu.org>
7386
7387 * xdisp.c (move_it_in_display_line_to): Don't invoke
7388 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7389 ppos_it. Fixes vertical cursor motion when line beginning is
7390 covered by an image. (Bug#9296)
7391
08e3161a
JD
73922011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7393
7394 * nsterm.h (ns_run_ascript): Declare.
7395 (NSAPP_DATA2_RUNASSCRIPT): Define.
7396
7397 * nsfns.m (as_script, as_result, as_status): New static variables.
7398 (ns_run_ascript): New function.
5e617bc2 7399 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7400 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7401 the event loop. Get status from as_status (Bug#7276).
7402
7403 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7404 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7405 the event loop (Bug#7276).
7406
a3720aa2
AS
74072011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7408
7409 * gnutls.c (QCgnutls_bootprop_priority)
7410 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7411 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7412 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7413 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7414 (QCgnutls_bootprop_verify_hostname_error)
7415 (QCgnutls_bootprop_callbacks_verify): Rename from
7416 Qgnutls_bootprop_..., all uses changed.
7417
7418 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7419 uses changed.
7420
0a0d27fb
PE
74212011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7422
19d5c50c
PE
7423 * xfaces.c (Qframe_set_background_mode): Now static.
7424 * dispextern.h (Qframe_set_background_mode): Remove decl.
7425
0a0d27fb
PE
7426 * process.c (Fnetwork_interface_info): Declare local only if needed.
7427
377538cb
JD
74282011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7429
7430 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7431 (Fnetwork_interface_list): Allocate in increments of bytes instead
7432 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7433 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7434 sockaddr.
7435 (struct ifflag_def): notrailers is smart on OSX.
7436 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7437 Get hardware address with getifaddrs if available.
7438
08fff70c
EZ
74392011-08-12 Eli Zaretskii <eliz@gnu.org>
7440
7441 * xdisp.c (iterate_out_of_display_property): xassert that
7442 IT->position is set to within IT->object's boundaries. Break from
7443 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7444 when IT->position is set up wrongly due to some bug.
7445 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7446 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7447 entry. Force push_it to save on the stack the current
7448 buffer/string position, to be restored by pop_it. Fix flags in
7449 the iterator structure wrt the object coming from a display
7450 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7451 properties. (Bug#9284)
7452
7be1c708 74532011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7454
7be1c708
CY
7455 * fontset.c (fontset_get_font_group): Add proper type checks.
7456 (Bug#9172)
aac0c6e3 7457
7be1c708 74582011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7459
7be1c708
CY
7460 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7461 and LC_VERSION_MIN_MACOSX.
7462 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7463 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7464
97bb72a6
EZ
74652011-08-08 Eli Zaretskii <eliz@gnu.org>
7466
7467 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7468 no-display-properties-and-no-overlays under bidi display.
7469 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7470 properties and overlays.
97bb72a6 7471
d5617611
CY
74722011-08-08 Chong Yidong <cyd@stupidchicken.com>
7473
37e11a63
CY
7474 * editfns.c (Fset_time_zone_rule): Document relationship with the
7475 setenv function.
7476
d5617611
CY
7477 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7478 the font entity extracted from the cache (Bug#8109).
7479
58872834
CY
74802011-08-07 Chong Yidong <cyd@stupidchicken.com>
7481
7482 * composite.c (autocmp_chars): Don't reset point. That is done by
7483 restore_point_unwind (Bug#5984).
7484
75bfc667
JL
74852011-08-07 Juri Linkov <juri@jurta.org>
7486
7487 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7488 to show the arg `TIME' instead of `TIMEVAL'.
7489
d1410150
EZ
74902011-08-06 Eli Zaretskii <eliz@gnu.org>
7491
7492 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7493 display property strides EOL and includes a newline, as in
7494 longlines-mode. (Bug#9254)
75b771e4
EZ
7495 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7496 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7497
7498 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7499 is non-zero, even if the data buffer is NULL. Fixes a crash in
7500 vertical-motion with longlines-mode. (Bug#9254)
7501
35928349
EZ
75022011-08-05 Eli Zaretskii <eliz@gnu.org>
7503
ec7cc85b
EZ
7504 * bidi.c <bidi_cache_total_alloc>: Now static.
7505 (bidi_initialize): Initialize bidi_cache_total_alloc.
7506
8b76d6f8 7507 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7508 cache. (Bug#9221)
7509
7510 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7511 amount allocated this far in `bidi_cache_total_alloc'.
7512 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7513 non-zero, only free the data buffer without restoring the cache
7514 contents. All callers changed.
7515
7516 * dispextern.h (bidi_unshelve_cache): Update prototype.
7517
7518 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7519 (move_it_in_display_line, move_it_to)
7520 (move_it_vertically_backward, move_it_by_lines): Replace the call
7521 to xfree to an equivalent call to bidi_unshelve_cache.
7522 (move_it_in_display_line_to): Fix logic of returning
412b6358 7523 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7524
e2e2423b
EZ
75252011-08-05 Eli Zaretskii <eliz@gnu.org>
7526
7527 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7528 came from a string character with a `cursor' property. (Bug#9229)
7529
ae9e757a
JD
75302011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7531
7532 * Makefile.in (LIB_PTHREAD): New variable.
7533 (LIBES): Add LIB_PTHREAD (Bug#9216).
7534
7535 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7536 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7537
213bd7f2
AS
75382011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7539
6b02f655 7540 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7541
99aaf75f
JD
75422011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7543
7544 * xterm.c (x_find_topmost_parent): New function.
7545 (x_set_frame_alpha): Find topmost parent window with
7546 x_find_topmost_parent and set the property there also (bug#9181).
7547 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7548
c74e9d86
PE
75492011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7550
7551 * callproc.c (Fcall_process): Avoid vfork clobbering
7552 the local vars buffer, coding_systems, current_dir.
7553
640c8776
SM
75542011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7555
7556 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7557
f26d0e4c
PE
75582011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7559
8a10d76c
PE
7560 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7561 so that it is not optimized away.
7562
f26d0e4c
PE
7563 * xdisp.c (compute_display_string_pos): Remove unused local.
7564
55439c61
EZ
75652011-08-02 Eli Zaretskii <eliz@gnu.org>
7566
7567 Fix slow cursor motion and scrolling in large buffers with
7568 selective display, like Org Mode buffers. (Bug#9218)
7569
7570 * dispextern.h (struct bidi_it): New member disp_prop_p.
7571
7572 * xdisp.c: Remove one-slot cache of display string positions.
7573 (compute_display_string_pos): Accept an additional argument
5e617bc2 7574 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7575 for a display string or property. If found, set DISP_PROP_P
7576 non-zero.
7577
7578 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7579 DISP_PROP_P, and pass it to compute_display_string_pos.
7580 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7581 non-zero. All callers of bidi_fetch_char changed.
7582
fb33fa43
SM
75832011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7584
7585 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7586
b099e063
DM
75872010-12-03 Don March <don@ohspite.net>
7588
7589 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7590 last character M-[char] is translated to ESC [char] (bug#7541).
7591
5cc7f7af
KH
75922011-08-02 Kenichi Handa <handa@m17n.org>
7593
d0fffa3f 7594 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7595
7596 * chartab.c (uniprop_table): Make it non-static.
7597
525d5e6e
EZ
75982011-08-01 Eli Zaretskii <eliz@gnu.org>
7599
7600 * xdisp.c (forward_to_next_line_start): Accept additional argument
7601 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7602 on the newline.
7603 (reseat_at_next_visible_line_start): Use the bidi iterator state
7604 returned by forward_to_next_line_start to restore the state of
7605 it->bidi_it after backing up to previous newline. (Bug#9212)
7606
31011111
AS
76072011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7608
7609 * regex.c (re_comp): Protoize.
7610 (re_exec): Fix return type.
7611 (regexec): Fix type of `ret'. (Bug#9203)
7612
476371c4
PE
76132011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7614
e5d76069
PE
7615 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7616 This is needed if max-image-size is a floating-point number.
7617
9a79b20c
AS
76182011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7619
7620 * print.c (print_object): Print empty symbol as ##.
7621
7622 * lread.c (read1): Read ## as empty symbol.
7623
d8c2fa78
AA
76242011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7625
7626 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7627 setting frame foreground color (Bug#9175).
7628 (x_set_background_color): Likewise.
7629
ffe57a7a
AA
7630 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7631 contents (Bug#9176).
7632 (EmacsTooltip -init): Remove bezels and add shadows to
7633 tooltip windows.
7634
bf3492a5
AA
7635 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7636 or scroll bar (Bug#8470).
7637
d55e9c53
AA
7638 * nsfont.m (nsfont_open): Remove assignment to voffset and
7639 unnecessary vars hshink, expand, hd, full_height, min_height.
7640 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7641
7642 * nsterm.h (nsfont_info): Remove voffset field.
7643
d8c2fa78 76442011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7645
7646 Implement strike-through and overline on NextStep (Bug#8863).
7647
7648 * nsfont.m (nsfont_open): Use underline position provided by font,
7649 instead of hard-coded value of 2.
7650 (nsfont_draw): Call ns_draw_text_decoration instead.
7651
7652 * nsterm.h: Add declaration for ns_draw_text_decoration.
7653
7654 * nsterm.m (ns_draw_text_decoration): New function for drawing
7655 underline, overline, and strike-through.
7656 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7657 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7658 accommodate underlining, etc.
4843aac3 7659
4cc60b9b
EZ
76602011-07-28 Eli Zaretskii <eliz@gnu.org>
7661
bc7ece87
EZ
7662 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7663 default.
4cc60b9b 7664
476371c4
PE
76652011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7666
66606eea
PE
7667 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7668 Without this fix, if a signal arrives just after memory fills up,
7669 'malloc' might be invoked reentrantly.
7670
476371c4
PE
7671 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7672 In other words, assume that every image size is allowed, on non-X
7673 hosts. This assumption is probably wrong, but it lets Emacs compile.
7674
f3fcc40d
AS
76752011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7676
7677 * regex.c (re_iswctype): Convert return values to boolean.
7678
350c992f
EZ
76792011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7680
7681 * xdisp.c (compute_display_string_pos): Don't use cached display
7682 string position if the buffer had its restriction changed.
7683 (Bug#9184)
7684
5266b4bb
PE
76852011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7686
7687 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7688
2573a837 76892011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7690
41f55ccd 7691 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7692
39e378da
PE
7693 * bidi.c: Integer size and overflow fixes.
7694 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7695 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7696 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7697 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7698 (bidi_find_other_level_edge):
7699 Use ptrdiff_t instead of EMACS_INT where either will do.
7700 This works better on 32-bit hosts configured --with-wide-int.
7701 (bidi_cache_ensure_space): Check for size-calculation overflow.
7702 Use % rather than repeated addition, for better worst-case speed.
7703 Don't set bidi_cache_size until after xrealloc returns, because it
7704 might not return.
7705 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7706 (bidi_cache_ensure_space): Also check that the bidi cache size
7707 does not exceed that of the largest Lisp string or buffer. See Eli
7708 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7709
5e927815
PE
7710 * alloc.c (__malloc_size_t): Remove.
7711 All uses replaced by size_t. See Andreas Schwab's note
7712 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7713
ca4aa935
PE
7714 * image.c: Improve checking for integer overflow.
7715 (check_image_size): Assume that f is nonnull, since
7716 it is always nonnull in practice. This is one less thing to
7717 worry about when checking for integer overflow later.
7718 (x_check_image_size): New function, which checks for integer
7719 overflow issues inside X.
7720 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7721 This removes the need for a memory_full check.
7722 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7723 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7724 (xbm_read_bitmap_data): Change locals back to 'int', since
7725 their values must fit in 'int'.
7726 (xpm_load_image, png_load, tiff_load):
7727 Invoke x_create_x_image_and_pixmap earlier,
7728 to avoid much needless work if the image is too large.
7729 (tiff_load): Treat overly large images as if
7730 x_create_x_image_and_pixmap failed, not as malloc failures.
7731 (gs_load): Use x_check_image_size.
7732
5f8f9cc2
PE
7733 * gtkutil.c: Omit integer casts.
7734 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7735 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7736
5adf60bc
PE
7737 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7738
c8907a93
PE
7739 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7740 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7741 would wrongly return t on a 64-bit host.
7742
e3c25c68
PE
7743 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7744 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7745 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7746 and therefore cause GCC to emit a bogus diagnostic in some cases.
7747
3f791afe
PE
7748 * image.c: Integer signedness and overflow and related fixes.
7749 This is not an exhaustive set of fixes, but it's time to
7750 record what I've got.
7751 (lookup_pixel_color, check_image_size): Remove redundant decls.
7752 (check_image_size): Don't assume that arbitrary EMACS_INT values
7753 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7754 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7755 (tiff_load, imagemagick_load_image):
7756 Check for overflow in size calculations.
7757 (x_create_x_image_and_pixmap): Remove unnecessary test for
7758 xmalloc returning NULL; that can't happen.
7759 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7760 (xpm_color_bucket): Use better integer hashing function.
7761 (xpm_cache_color): Don't possibly over-allocate memory.
7762 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7763 (gif_memory_source):
7764 Use ptrdiff_t, not int or size_t, to record sizes.
7765 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7766 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7767 either works, as we prefer signed integers.
7768 (tiff_read_from_memory, tiff_write_from_memory):
7769 Return tsize_t, not size_t, since that's what the TIFF API wants.
7770 (tiff_read_from_memory): Don't fail simply because the read would
7771 go past EOF; instead, return a short read.
7772 (tiff_load): Omit no-longer-needed casts.
7773 (Fimagemagick_types): Don't assume size fits into 'int'.
7774
3cc5a532
PE
7775 Improve hashing quality when configured --with-wide-int.
7776 * fns.c (hash_string): New function, taken from sxhash_string.
7777 Do not discard information about ASCII character case; this
7778 discarding is no longer needed.
7779 (sxhash-string): Use it. Change sig to match it. Caller changed.
7780 * lisp.h: Declare it.
7781 * lread.c (hash_string): Remove, since we now use fns.c's version.
7782 The fns.c version returns a wider integer if --with-wide-int is
7783 specified, so this should help the quality of the hashing a bit.
7784
b312a492
PE
7785 * emacs.c: Integer overflow minor fix.
7786 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7787 Define only if GNU_LINUX.
7788 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7789
dfd153ae
PE
7790 * dispnew.c: Integer signedness and overflow fixes.
7791 Remove unnecessary forward decls, that were a maintenance hassle.
7792 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7793 All uses changed.
7794 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7795 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7796 (prepare_desired_row, line_draw_cost):
7797 Use int, not unsigned, where either works.
7798 (save_current_matrix, restore_current_matrix):
7799 Use ptrdiff_t, not size_t, where either works.
7800 (init_display): Check for overflow more accurately, and without
7801 relying on undefined behavior.
7802
a81d11a3
PE
7803 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7804 Remove, replacing with the new symbols in lisp.h. All uses changed.
7805 * fileio.c (make_temp_name):
7806 * filelock.c (lock_file_1, lock_file):
7807 * xdisp.c (message_dolog):
7808 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7809 Use pMd etc. instead.
7810 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7811 replacing the pWIDE etc. symbols removed from editfns.c.
7812
3300e6fd
PE
7813 * keyboard.h (num_input_events): Now uintmax_t.
7814 This is (very slightly) less likely to mess up due to wraparound.
7815 All uses changed.
7816
fd05c7e9
PE
7817 * buffer.c: Integer signedness fixes.
7818 (alloc_buffer_text, enlarge_buffer_text):
7819 Use ptrdiff_t rather than size_t when either will do, as we prefer
7820 signed integers.
7821
903fe15d
PE
7822 * alloc.c: Integer signedness and overflow fixes.
7823 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7824 (__malloc_size_t): Default to size_t, not to int.
7825 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7826 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7827 Prefer ptrdiff_t to size_t when either would do, as we prefer
7828 signed integers.
7829 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7830 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7831 Now const. Initialize with values that are in range even if char
7832 is signed.
7833 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7834 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7835 These functions do the right thing with sizes > 2**32.
7836 (check_depth): Now ptrdiff_t, not int.
7837 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7838 Adjust to new way of storing sizes. Check for size overflow bugs
7839 in rest of code.
7840 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7841 slightly wrong anyway, as it missed one instance of
7842 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7843 (refill_memory_reserve): Omit needless cast to size_t.
7844 (mark_object_loop_halt): Mark as externally visible.
7845
ac82cc6a
PE
7846 * xselect.c: Integer signedness and overflow fixes.
7847 (Fx_register_dnd_atom, x_handle_dnd_message):
7848 Use ptrdiff_t, not size_t, since we prefer signed.
7849 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7850 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7851 x_dnd_atoms_size and x_dnd_atoms_length.
7852
c2d1e36d
PE
7853 * doprnt.c: Prefer signed to unsigned when either works.
7854 * eval.c (verror):
7855 * doprnt.c (doprnt):
7856 * lisp.h (doprnt):
7857 * xdisp.c (vmessage):
7858 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7859 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7860 prefer signed arithmetic to avoid comparison confusion.
7861 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7862 but is a bit tricky.
7863
0e926e56
PE
7864 Assume freestanding C89 headers, string.h, stdlib.h.
7865 * data.c, doprnt.c, floatfns.c, print.c:
7866 Include float.h unconditionally.
7867 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7868 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7869 * regex.c: Likewise for stddef.h, string.h.
7870 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7871 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7872 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7873 (STDC_HEADERS): Remove obsolete defines.
7874 * sysdep.c: Include limits.h unconditionally.
7875
9cfdb3ec
PE
7876 Assume support for memcmp, memcpy, memmove, memset.
7877 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7878 * regex.c (memcmp, memcpy):
7879 Remove; we assume C89 now.
7880
7881 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7882 (__malloc_safe_bcopy): Remove; no longer needed.
7883
cf950e6b 7884 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7885 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7886 well either way, and we prefer signed to unsigned.
7887
dbf38e02
LMI
78882011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7889
7890 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7891 closes the connection while we're reading (bug#9182).
7892
d6f0886c 78932011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7894
d6f0886c
JD
7895 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7896 are specified (Bug#9168).
24e0f6b1 7897
2eb1f9e6
PE
78982011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7899
7900 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7901 Found by GCC static checking and --with-wide-int on a 32-bit host.
7902
22381272 79032011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7904
7905 * xdisp.c (compute_display_string_pos): Fix logic of caching
7906 previous display string position. Initialize cached_prev_pos to
7907 -1. Fixes slow-down at the beginning of a buffer.
7908
f25e39b4
EZ
79092011-07-24 Eli Zaretskii <eliz@gnu.org>
7910
7911 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7912 for attrs[LFACE_FONTSET_INDEX].
7913
04c4b52e
PE
79142011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7915
7916 * xml.c (parse_region): Remove unused local
7917 that was recently introduced.
7918
c1734fbd
EZ
79192011-07-23 Eli Zaretskii <eliz@gnu.org>
7920
be18c5a5
EZ
7921 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7922 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7923
c1734fbd
EZ
7924 * xdisp.c (move_it_in_display_line_to): Record the best matching
7925 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7926 exit if none of the characters scanned was an exact match.
7927 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7928 when exact match is impossible due to invisible text, and the
7929 lines are truncated.
7930
a258d627
JD
79312011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7932
7933 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7934 for OSX >= 10.7.
7935
b6d5a689
EZ
79362011-07-22 Eli Zaretskii <eliz@gnu.org>
7937
0f74f785
EZ
7938 Fix a significant slow-down of cursor motion with C-n, C-p,
7939 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7940 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7941 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7942 (next_element_from_buffer): Call compute_stop_pos_backwards to
7943 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7944 base_level_stop.
7945 (reseat): Don't look for prev_stop, as that could mean a very long
7946 run.
7947 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7948 <cached_disp_overlay_modiff>: Cache for last found display string
7949 position.
551918c1 7950 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7951 about the same buffer in the same area of character positions, and
7952 the buffer wasn't changed since the time the display string
7953 position was cached.
551918c1 7954
b2d0c91a
EZ
79552011-07-22 Eli Zaretskii <eliz@gnu.org>
7956
7957 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7958 is an integer, which is important for empty lines. (Bug#9149)
7959
043604ee
CY
79602011-07-22 Chong Yidong <cyd@stupidchicken.com>
7961
7962 * frame.c (Fmodify_frame_parameters): In tty case, update the
7963 default face if necessary (Bug#4238).
7964
da4adb04
CY
79652011-07-21 Chong Yidong <cyd@stupidchicken.com>
7966
7967 * editfns.c (Fstring_to_char): No need to explain what a character
7968 is in the docstring (Bug#6576).
7969
9abd0532
LMI
79702011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7971
7972 * xml.c (parse_region): Make sure we always return a tree.
7973
36881d16
HK
79742011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7975
7976 * xml.c (parse_region): If a document contains only comments,
7977 return that, too.
7978
1e98674d
LMI
79792011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7980
7981 * xml.c (make_dom): Return comments, too.
7982
590bd467
PE
79832011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7984
7985 Port to OpenBSD.
7986 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7987 and the surrounding thread.
7988 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7989 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7990 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7991 timer goes off.
7992 * s/openbsd.h (BROKEN_SIGIO): Define.
7993 * unexelf.c (unexec) [__OpenBSD__]:
7994 Don't update the .mdebug section of the Alpha COFF symbol table.
7995
f41628b2
LMI
79962011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7997
7998 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7999 (bug#8460).
8000
b59b67c5
PE
80012011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8002
15e3a074
PE
8003 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8004 This fixes some race conditions on the permissions of any newly
8005 created file.
8006
41bed37d
PE
8007 * alloc.c (valid_pointer_p): Use pipe, not open.
8008 This fixes some permissions issues when debugging.
8009
b59b67c5
PE
8010 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8011 If fchown fails to set both uid and gid, try to set just gid,
8012 as that is sometimes allowed. Adjust the file's mode to eliminate
8013 setuid or setgid bits that are inappropriate if fchown fails.
8014
925a6be7
SM
80152011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8016
8017 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8018 to compare Lisp_Objects.
8019 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8020 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8021 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8022
52968808
AS
80232011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8024
0a6a104b
AS
8025 * lread.c (read_integer): Unread even EOF character.
8026 (read1): Likewise. Properly record start position of symbol.
8027
52968808
AS
8028 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8029 symbol character follows.
8030
9e381cdd
PE
80312011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8032
8033 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8034 This works around a problem with the previous change to Fcopy_file.
8035 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8036 and without this change, GCC might complain about discarding
8037 fchown's return value.
8038
b5641435
JB
80392011-07-16 Juanma Barranquero <lekktu@gmail.com>
8040
8041 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8042
a8031457
PE
80432011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8044
8045 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8046
dd889327
LMI
80472011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8048
750c33f7
LMI
8049 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8050 it's used from the C level.
8051
dd889327
LMI
8052 * process.c: Use the same condition for POLL_FOR_INPUT in both
8053 keyboard.c and process.c (bug#1858).
8054
87e86684
LM
80552011-07-09 Lawrence Mitchell <wence@gmx.li>
8056
8057 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8058 (Fgnutls_boot): Use it.
8059
64348f40
AS
80602011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8061
8062 * doc.c (Fsubstitute_command_keys): Revert last change.
8063
1d698799
LMI
80642011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8065
f863868c
LMI
8066 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8067 quotes the next character, and doesn't affect other longer
8068 sequences (bug#8935).
8069
1d698799
LMI
8070 * lread.c (syms_of_lread): Clarify that is isn't only
8071 `eval-buffer' and `eval-defun' that's affected by
8072 `lexical-binding' (bug#8460).
8073
aa4b6df6
EZ
80742011-07-15 Eli Zaretskii <eliz@gnu.org>
8075
8076 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8077 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8078
5d856da6
PE
80792011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8080
ad6042bb
PE
8081 Fix minor problems found by static checking.
8082 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8083 (elsz): Now a signed constant, not a size_t var. We prefer signed
8084 types to unsigned, to avoid integer comparison confusion. Without
8085 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8086 "cannot optimize loop, the loop counter may overflow", a symptom
8087 of the confusion.
f00bbb22 8088 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8089 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8090
6468f31c
LMI
80912011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8092
49080b10
LMI
8093 * search.c (Fre_search_backward): Mention `case-fold-search' in
8094 all the re_search_* functions (bug#8138).
8095
6468f31c
LMI
8096 * keyboard.c (Fopen_dribble_file): Document when the file is
8097 closed (bug#8056).
8098
c965adc5
EZ
80992011-07-14 Eli Zaretskii <eliz@gnu.org>
8100
df9733bf
EZ
8101 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8102 bidi_cache_idx.
8103
0bb23927
EZ
8104 Support bidi reordering of display and overlay strings.
8105 * xdisp.c (compute_display_string_pos)
8106 (compute_display_string_end): Accept additional argument STRING.
8107 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8108 (reseat_to_string): Initialize bidi_it->string.s and
8109 bidi_it->string.schars.
8110 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8111 NULL (avoids a crash in bidi_paragraph_init).
8112 Initialize itb.string.lstring.
0bb23927
EZ
8113 (init_iterator): Call bidi_init_it only of a valid
8114 buffer position was specified. Initialize paragraph_embedding to
8115 L2R.
8116 (reseat_to_string): Initialize the bidi iterator.
8117 (display_string): If we need to ignore text properties of
8118 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8119 original value of -1 will not work with bidi.)
8120 (compute_display_string_pos): First arg is now struct
8121 `text_pos *'; all callers changed. Support display properties on
8122 Lisp strings.
8123 (compute_display_string_end): Support display properties on Lisp
8124 strings.
8125 (init_iterator, reseat_1, reseat_to_string): Initialize the
8126 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8127 when iterating on a string not from display properties).
640c8776
SM
8128 (compute_display_string_pos, compute_display_string_end):
8129 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8130 arrow keys.
8131 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8132 base_level_stop; instead, set base_level_stop to BEGV.
8133 Fixes crashes in vertical-motion.
0bb23927
EZ
8134 (next_element_from_buffer): Improve commentary for when
8135 the iterator is before prev_stop.
8136 (init_iterator): Initialize bidi_p from the default value of
8137 bidi-display-reordering, not from buffer-local value. Use the
8138 buffer-local value only if initializing for buffer iteration.
8139 (handle_invisible_prop): Support invisible properties on strings
8140 that are being bidi-reordered.
8141 (set_iterator_to_next): Support bidi reordering of C strings and
8142 Lisp strings.
8143 (next_element_from_string): Support bidi reordering of Lisp
8144 strings.
8145 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8146 (display_string): Support display of R2L glyph rows.
8147 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8148 (init_iterator): Don't initialize it->bidi_p for strings
8149 here.
8150 (reseat_to_string): Initialize it->bidi_p for strings here.
8151 (next_element_from_string, next_element_from_c_string)
8152 (next_element_from_buffer): Add xassert's for correspondence
8153 between IT's object being iterated and it->bidi_it.string
8154 structure.
8155 (face_before_or_after_it_pos): Support bidi iteration.
8156 (next_element_from_c_string): Handle the case of the first string
8157 character that is not the first one in the visual order.
8158 (get_visually_first_element): New function, refactored from common
8159 parts of next_element_from_buffer, next_element_from_string, and
8160 next_element_from_c_string.
8161 (tool_bar_lines_needed, redisplay_tool_bar)
8162 (display_menu_bar): Force left-to-right direction. Add a FIXME
8163 comment for making that be controlled by a user option.
8164 (push_it, pop_it): Save and restore the state of the
8165 bidi iterator. Save and restore the bidi_p flag.
8166 (pop_it): Iterate out of display property for string iteration as
8167 well.
8168 (iterate_out_of_display_property): Support iteration over strings.
8169 (handle_single_display_spec): Set up it->bidi_it for iteration
8170 over a display string, and call bidi_init_it.
8171 (handle_single_display_spec, next_overlay_string)
8172 (get_overlay_strings_1, push_display_prop): Set up the bidi
8173 iterator for displaying display or overlay strings.
8174 (forward_to_next_line_start): Don't use the shortcut if
8175 bidi-iterating.
8176 (back_to_previous_visible_line_start): If handle_display_prop
8177 pushed the iterator stack, restore the internal state of the bidi
8178 iterator by calling bidi_pop_it same number of times.
8179 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8180 and we are bidi-iterating, don't decrement the iterator position;
8181 instead, set the first_elt flag in the bidi iterator, to produce
8182 the same effect.
8183 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8184 (push_display_prop): xassert that we are iterating a buffer.
8185 (push_it, pop_it): Save and restore paragraph_embedding member.
8186 (handle_single_display_spec, next_overlay_string)
8187 (get_overlay_strings_1, reseat_1, reseat_to_string)
8188 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8189 correctly. Don't assume unibyte strings are not bidi-reordered.
8190 (compute_display_string_pos)
8191 (compute_display_string_end): Fix handling the case of C string.
8192 (push_it, pop_it): Save and restore from_disp_prop_p.
8193 (handle_single_display_spec, push_display_prop): Set the
8194 from_disp_prop_p flag.
8195 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8196 (pop_it): Call iterate_out_of_display_property only if we are
8197 popping after iteration over a string that came from a display
8198 property. Fix a typo in popping stretch info. Add an assertion
8199 for verifying that the iterator position is in sync with the bidi
8200 iterator.
8201 (handle_single_display_spec, get_overlay_strings_1)
8202 (push_display_prop): Fix initialization of paragraph direction for
8203 string when that of the parent object is not yet determined.
8204 (reseat_1): Call bidi_init_it to resync the bidi
8205 iterator with IT's position. (Bug#7616)
8206 (find_row_edges): If ROW->start.pos gives position
8207 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8208 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8209 Reset the from_disp_prop_p flag.
8210 (SAVE_IT, RESTORE_IT): New macros.
8211 (pos_visible_p, face_before_or_after_it_pos)
8212 (back_to_previous_visible_line_start)
8213 (move_it_in_display_line_to, move_it_in_display_line)
8214 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8215 (try_scrolling, redisplay_window, display_line): Use them when
8216 saving a temporary copy of the iterator and restoring it back.
8217 (back_to_previous_visible_line_start, reseat_1)
8218 (init_iterator): Empty the bidi cache "stack".
8219 (move_it_in_display_line_to): If iterator ended up at
8220 EOL, but we never saw any buffer positions smaller than
8221 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8222 motion in bidi-reordered lines.
8223 (move_it_in_display_line_to): Record prev_method and prev_pos
8224 immediately before the call to set_iterator_to_next. Fixes cursor
8225 motion in bidi-reordered lines with stretch glyphs and strings
8226 displayed in margins. (Bug#8133) (Bug#8867)
8227 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8228 TO_CHARPOS.
640c8776
SM
8229 (pos_visible_p): Support positions in bidi-reordered lines.
8230 Save and restore bidi cache.
0bb23927
EZ
8231
8232 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8233 (bidi_paragraph_info): Delete unused struct.
8234 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8235 (bidi_cache_start): New variable.
8236 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8237 to zero.
8238 (bidi_cache_fetch_state, bidi_cache_search)
8239 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8240 (bidi_cache_find, bidi_peek_at_next_level)
8241 (bidi_level_of_next_char, bidi_find_other_level_edge)
8242 (bidi_move_to_visually_next): Compare cache index with
8243 bidi_cache_start rather than with zero.
8244 (bidi_fetch_char): Accept new argument STRING; all callers
8245 changed. Support iteration over a string. Support strings with
8246 display properties. Support unibyte strings. Fix the type of
8247 `len' according to what STRING_CHAR_AND_LENGTH expects.
8248 (bidi_paragraph_init, bidi_resolve_explicit_1)
8249 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8250 (bidi_level_of_next_char, bidi_move_to_visually_next):
8251 Support iteration over a string.
0bb23927
EZ
8252 (bidi_set_sor_type, bidi_resolve_explicit_1)
8253 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8254 can now be zero (for strings); special values 0 and -1 were
8255 changed to -1 and -2, respectively.
8256 (bidi_char_at_pos): New function.
8257 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8258 Call it instead of FETCH_MULTIBYTE_CHAR.
8259 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8260 initialized to valid values.
8261 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8262 values.
8263 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8264 the test for valid cached positions. Fix the logic for looking up
8265 the sentinel state in the cache. GCPRO the Lisp string we are
8266 iterating.
8267 (bidi_push_it, bidi_pop_it): New functions.
8268 (bidi_initialize): Initialize the bidi cache start stack pointer.
8269 (bidi_cache_ensure_space): New function, refactored from part of
8270 bidi_cache_iterator_state. Don't assume the required size is just
8271 one BIDI_CACHE_CHUNK away.
8272 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8273 (bidi_count_bytes, bidi_char_at_pos): New functions.
8274 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8275 always valid if bidi_cache_idx is valid.
8276 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8277 is valid if it's going to be used.
8278 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8279 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8280 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8281 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8282 (bidi_find_other_level_edge, bidi_cache_start_stack):
8283 All variables related to cache indices are now EMACS_INT.
c965adc5 8284
0bb23927
EZ
8285 * dispextern.h (struct bidi_string_data): New structure.
8286 (struct bidi_it): New member `string'. Make flag members be 1-bit
8287 fields, and put them last in the struct.
640c8776
SM
8288 (compute_display_string_pos, compute_display_string_end):
8289 Update prototypes.
0bb23927
EZ
8290 (bidi_push_it, bidi_pop_it): Add prototypes.
8291 (struct iterator_stack_entry): New members bidi_p,
8292 paragraph_embedding, and from_disp_prop_p.
8293 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8294 (bidi_shelve_cache, bidi_unshelve_cache):
8295 Declare prototypes.
0bb23927
EZ
8296
8297 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8298 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8299 and vector-like objects.
8300
8301 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8302 cache around display iteration.
8303
8304 * window.c (Fwindow_end, window_scroll_pixel_based)
8305 (displayed_window_lines, Frecenter): Save and restore the bidi
8306 cache around display iteration.
8307
3bbd2265
LMI
83082011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8309
8310 * editfns.c (Fdelete_region): Clarify the use of the named
8311 parameters (bug#6788).
8312
adc47434
MR
83132011-07-14 Martin Rudalics <rudalics@gmx.at>
8314
8315 * indent.c (Fvertical_motion): Set and restore w->pointm when
8316 saving and restoring the window's buffer (Bug#9006).
8317
837c31f8
LMI
83182011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8319
8320 * editfns.c (Fstring_to_char): Clarify just what is returned
8321 (bug#6576). Text by Eli Zaretskii.
8322
ac389d0c
JB
83232011-07-13 Juanma Barranquero <lekktu@gmail.com>
8324
8325 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8326
0be0ce47
EZ
83272011-07-13 Eli Zaretskii <eliz@gnu.org>
8328
8329 * buffer.c (mmap_find): Fix a typo.
8330
cd18e7e3
JB
83312011-07-13 Johan Bockgård <bojohan@gnu.org>
8332
8333 Fix execution of x selection hooks.
8334 * xselect.c (Qx_lost_selection_functions)
8335 (Qx_sent_selection_functions): New vars.
8336 (syms_of_xselect): DEFSYM them.
8337 (x_handle_selection_request): Pass Qx_sent_selection_functions
8338 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8339 (x_handle_selection_clear,x_clear_frame_selections):
8340 Pass Qx_lost_selection_functions rather than
8341 Vx_lost_selection_functions to Frun_hook_with_args.
8342
47ea7f44
PE
83432011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8344
ac389d0c 8345 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8346 The old code sometimes used this field without initializing it.
8347
47ea7f44
PE
8348 * alloc.c (gc_sweep): Don't read past end of array.
8349 In theory, the old code could also have corrupted Emacs internals,
8350 though it'd be very unlikely.
8351
bc985c87
AS
83522011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8353
8354 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8355 argument. (Bug#4026)
bc985c87 8356
0cf34688
LMI
83572011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8358
b3dadd76
LMI
8359 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8360 key" (bug#4257).
8361
0cf34688
LMI
8362 * window.c (Fset_window_start): Doc fix (bug#4199).
8363 (Fset_window_hscroll): Ditto.
8364
270768cd
PE
83652011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8366
077e3dda 8367 Fix minor new problems caught by GCC 4.6.1.
270768cd 8368 * term.c (init_tty): Remove unused local.
490011a6 8369 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8370 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8371 not used otherwise.
270768cd 8372
b1f58454
CY
83732011-07-12 Chong Yidong <cyd@stupidchicken.com>
8374
8375 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8376
22b9578d
LMI
83772011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8378
6e70ab07
LMI
8379 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8380 are the mini-buffer and the echo area (bug#3320).
8381
22b9578d
LMI
8382 * term.c (init_tty): Remove support for supdup, c10 and perq
8383 terminals, which are no longer supported (bug#1482).
8384
8974cc9f
JB
83852011-07-10 Johan Bockgård <bojohan@gnu.org>
8386
8387 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8388
a560d974
JD
83892011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8390
8391 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8392 for non-popups (Bug#3642).
8393
1dae0f0a
AS
83942011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8395
268c2c36 8396 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8397 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8398 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8399 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8400 * data.c (fmod): Likewise.
8401 * dispnew.c (swap_glyphs_in_rows): Likewise.
8402 * emacs.c (memory_warning_signal): Likewise.
8403 * floatfns.c (float_error): Likewise.
8404 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8405 (otf_open, font_otf_capability, generate_otf_features)
8406 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8407 Likewise.
8408 * image.c (pbm_read_file): Likewise.
8409 * indent.c (string_display_width): Likewise.
8410 * intervals.c (check_for_interval, search_for_interval)
8411 (inc_interval_count, count_intervals, root_interval)
8412 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8413 * lread.c (defalias): Likewise.
268c2c36 8414 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8415 * regex.c (set_image_of_range_1, set_image_of_range)
8416 (regex_grow_registers): Likewise.
8417 * sysdep.c (strerror): Likewise.
8418 * termcap.c (valid_filename_p, tprint, main): Likewise.
8419 * tparam.c (main): Likewise.
8420 * unexhp9k800.c (run_time_remap, save_data_space)
8421 (update_file_ptrs, read_header, write_header, calculate_checksum)
8422 (copy_file, copy_rest, display_header): Likewise.
8423 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8424 Likewise.
8425 * xdisp.c (check_it): Likewise.
8426 * xfaces.c (register_color, unregister_color, unregister_colors):
8427 Likewise.
8428 * xfns.c (print_fontset_result): Likewise.
8429 * xrdb.c (member, fatal, main): Likewise.
8430
99033785
PE
84312011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8432
8433 Fix minor problems found by static checking (Bug#9031).
8434 * chartab.c (char_table_set_range, map_sub_char_table):
8435 Remove unused locals.
8436 (uniprop_table): Now static.
8437 * composite.c (_work_char): Remove unused static var.
8438
9cb2ac56
JB
84392011-07-09 Juanma Barranquero <lekktu@gmail.com>
8440
8441 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8442
f25661f0
JD
84432011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8444
8445 * gtkutil.c (qttip_cb): Remove code without function.
8446
8278c4fe
EZ
84472011-07-09 Eli Zaretskii <eliz@gnu.org>
8448
8449 * w32.c (pthread_sigmask): New stub.
8450
1692ae2d 84512011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8452
8a6ebd58 8453 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8454 sigprocmask is portable only for single-threaded applications, and
8455 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8456 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8457 (LIBES): Use it.
8458 * callproc.c (Fcall_process):
8459 * process.c (create_process):
8460 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8461 Use pthread_sigmask, not sigprocmask.
123403e4 8462
1b854618
JD
84632011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8464
8465 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8466 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8467 wrong (Bug#8591).
8468
3fe4b549
JD
84692011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8470
0ce7e563
JD
8471 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8472 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8473 (xg_hide_tooltip): Fix comment.
8474
3fe4b549
JD
8475 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8476 in registerServicesMenuSendTypes.
8477 (validRequestorForSendType): Don't check ns_return_types.
8478
8479 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8480 ns_return_type.
8481
5df75e47
JR
84822011-07-08 Jason Rumney <jasonr@gnu.org>
8483
22610910
JR
8484 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8485 SH_SHOW for hidden windows (Bug#5482).
8486
5df75e47
JR
8487 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8488 frame struct members of non-existent frames (Bug#6284).
8489
699c10bd
JD
84902011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8491
4393663b
JD
8492 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8493 variable firstTime not needed on OSX >= 10.6.
8494 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8495 >= 10.5. Use setKnobProportion, setDoubleValue.
8496
8497 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8498 (MAC_OS_X_VERSION_10_5): Define if not defined.
8499 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8500 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8501 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8502
8503 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8504 cString and lossyCString on OSX >= 10.4.
4393663b 8505
58179cce 8506 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8507 sizeToFit on OSX >= 10.2.
8508
8509 * nsimage.m (allocInitFromFile): Don't use deprecated method
8510 bestRepresentationForDevice on OSX >= 10.6.
8511
8512 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8513 to avoid warning.
8514
8515 * emacs.c: Declare unexec_init_emacs_zone.
8516
a63e0781
JD
8517 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8518
699c10bd
JD
8519 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8520
8521 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8522 on svcsMenu (Bug#8842).
8523
8524 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8525 ns_return_types.
8526 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8527
8528 * nsterm.m (QUTF8_STRING): Declare.
8529 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8530 (validRequestorForSendType): Return type is (id).
8531 Change indexOfObjectIdenticalTo to indexOfObject.
8532 Check if we have local selection before returning self (Bug#8842).
8533 (writeSelectionToPasteboard): Put local selection into paste board
8534 if we have a local selection (Bug#8842).
8535 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8536
8537 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8538 (ns_get_local_selection): Declare.
8539
54e10184
LMI
85402011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8541
9888ff71
LMI
8542 * keymap.c (describe_map_tree): Don't insert a double newline at
8543 the end of the buffer (bug#1169) and return whether we inserted
8544 something.
8545
54e10184
LMI
8546 * callint.c (Fcall_interactively): Change "reading args" to
8547 "providing args" to try to clarify what it does (bug#1010).
8548
15fa4783
KH
85492011-07-07 Kenichi Handa <handa@m17n.org>
8550
8551 * composite.c (composition_compute_stop_pos): Ignore a static
8552 composition starting before CHARPOS (Bug#8915).
8553
8554 * xdisp.c (handle_composition_prop): Likewise.
8555
a8815b00
EZ
85562011-07-07 Eli Zaretskii <eliz@gnu.org>
8557
8558 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8559 (Bug#9015)
8560
ef7b981d 85612011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8562
8563 * character.h (unicode_category_t): New enum type.
8564
8565 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8566 (Qchar_code_property_table): New variable.
8567 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8568 (UNIPROP_COMPRESSED_FORM_P): New macros.
8569 (char_table_ascii): Uncompress the compressed values.
8570 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8571 Uncompress the compressed values.
ac389d0c 8572 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8573 (char_table_ref_and_range): Uncompress the compressed values.
8574 (sub_char_table_set): New arg is_uniprop. Callers changed.
8575 Uncompress the compressed values.
8576 (sub_char_table_set_range): Args changed. Callers changed.
8577 (char_table_set_range): Adjuted for the above change.
8578 (map_sub_char_table): Delete args default_val and parent. Add arg
8579 top. Give decoded values to a Lisp function.
640c8776 8580 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8581 values to a Lisp function. Gcpro more variables.
8582 (uniprop_table_uncompress)
8583 (uniprop_decode_value_run_length): New functions.
8584 (uniprop_decoder, uniprop_decoder_count): New variables.
8585 (uniprop_get_decoder, uniprop_encode_value_character)
8586 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8587 New functions.
8588 (uniprop_encoder, uniprop_encoder_count): New variables.
8589 (uniprop_get_encoder, uniprop_table)
8590 (Funicode_property_table_internal, Fget_unicode_property_internal)
8591 (Fput_unicode_property_internal): New functions.
8592 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8593 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8594 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8595 char-code-property-alist.
8596
640c8776 8597 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8598 Vunicode_category_table.
8599
640c8776 8600 * font.c (font_range): Adjust for the change of
c805dec0
KH
8601 Vunicode_category_table.
8602
76b397fb
DN
86032011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8604
8605 * m/iris4d.h: Remove file, move contents ...
8606 * s/irix6-5.h: ... here.
8607
22b4128e
PE
86082011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8609
8610 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8611 * alloc.c (mark_buffer):
8612 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8613 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8614 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8615 This isn't true in general, and it's particularly not true
8616 if Emacs is configured with --with-wide-int.
8617 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8618 New macros, used in the buffer.c change.
8619
869795d6
JD
86202011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8621
8622 * xsettings.c: Use both GConf and GSettings if both are available.
8623 (store_config_changed_event): Add comment.
8624 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8625 (store_tool_bar_style_changed): New functions.
5e617bc2 8626 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8627 (struct xsettings): Move font inside HAVE_XFT.
8628 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8629 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8630 Move inside HAVE_XFT.
640c8776 8631 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8632 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8633 also.
8634 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8635 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8636 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8637 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8638 (parse_settings): Move check for font inside HAVE_XFT.
8639 (read_settings, apply_xft_settings): Add comment.
8640 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8641 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8642 call store_font_name_changed.
8643 (xft_settings_event): Add comment.
8644 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8645 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8646 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8647 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8648 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8649 (xsettings_get_system_font, xsettings_get_system_normal_font):
8650 Add comment.
869795d6 8651
d8ed26bd
PE
86522011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8653
8654 Random fixes. E.g., (random) never returned negative values.
8655 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8656 subseconds part to the entropy, as that's a bit more random.
8657 Prefer signed to unsigned, since the signedness doesn't matter and
8658 in general we prefer signed. When given a limit, use a
8659 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8660 latter isn't right if USE_2_TAGS_FOR_INTS.
8661 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8662 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8663
cabf1cac
SM
86642011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8665
8666 * textprop.c (text_property_stickiness):
8667 Obey Vtext_property_default_nonsticky.
8668 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8669 * w32fns.c (syms_of_w32fns):
8670 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8671
6e9b2be9
PE
86722011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8673
8674 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8675 This is more efficient than Ffile_directory_p and avoids a minor race.
8676
90186c68
LMI
86772011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8678
7c301272
LMI
8679 * buffer.c (Foverlay_put): Say what the return value is
8680 (bug#7835).
8681
c4f2d8d4
LMI
8682 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8683 is a directory before asking whether to use the file name
8684 (bug#7564).
ad637907
LMI
8685 (barf_or_query_if_file_exists): Make the "File is a directory"
8686 error be more correct.
c4f2d8d4 8687
90186c68
LMI
8688 * fns.c (Frequire): Remove the mention of the .gz files, since
8689 that's installation-specific, but keep the mention of
8690 `get-load-suffixes'.
8691
da64016e
PE
86922011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8693
8694 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8695 Report string overflow if the output is too long.
8696
7d47b580
JB
86972011-07-04 Juanma Barranquero <lekktu@gmail.com>
8698
a555cb87
JB
8699 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8700 (syms_of_gnutls): Remove duplicate DEFSYM for
8701 Qgnutls_bootprop_verify_hostname_error, an error for
8702 Qgnutls_bootprop_verify_error (which is no longer used).
8703
7d47b580
JB
8704 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8705 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8706 Also (re)move comments that are misplaced or no longer relevant.
8707
1e49bfab
LMI
87082011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8709
8710 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8711
1485f4c0
CY
87122011-07-03 Chong Yidong <cyd@stupidchicken.com>
8713
8714 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8715 and background color parameters if they have been changed.
8716
a9ab721e
LMI
87172011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8718
8719 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8720
cf7cff57
PE
87212011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8722
2e13213d
PE
8723 * xsettings.c (SYSTEM_FONT): Define only when used.
8724 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8725
cf7cff57
PE
8726 * keymap.c (access_keymap_1): Now static.
8727
7a8e04f7
CY
87282011-07-02 Chong Yidong <cyd@stupidchicken.com>
8729
8730 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8731 leave any prefix arg for the up event (Bug#1586).
8732
61352f62
LMI
87332011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8734
69bb1ef7
LMI
8735 * lread.c (syms_of_lread): Mention single symbols defined by
8736 `defvar' or `defconst' (bug#7154).
8737
61352f62 8738 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8739 (Frequire): Mention get-load-suffixes.
61352f62 8740
28545e04
MR
87412011-07-02 Martin Rudalics <rudalics@gmx.at>
8742
8743 * window.h (window): Remove clone_number slot.
8744 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8745 Remove.
8746 (make_parent_window, make_window, saved_window)
8747 (Fset_window_configuration, save_window_save): Don't deal with
8748 clone numbers.
8749 * buffer.c (Qclone_number): Remove declaration.
8750 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8751
3349e122
SM
87522011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8753
8754 Add multiple inheritance to keymaps.
8755 * keymap.c (Fmake_composed_keymap): New function.
8756 (Fset_keymap_parent): Simplify.
8757 (fix_submap_inheritance): Remove.
8758 (access_keymap_1): New function extracted from access_keymap to handle
8759 embedded parents and handle lists of maps.
8760 (access_keymap): Use it.
8761 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8762 (Fcopy_keymap): Handle embedded parents.
8763 (Fcommand_remapping, define_as_prefix): Simplify.
8764 (Fkey_binding): Simplify.
8765 (syms_of_keymap): Move minibuffer-local-completion-map,
8766 minibuffer-local-filename-completion-map,
8767 minibuffer-local-must-match-map, and
8768 minibuffer-local-filename-must-match-map to Elisp.
8769 (syms_of_keymap): Defsubr make-composed-keymap.
8770 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8771 (parse_menu_item): Trivial simplification.
8772
3279eb87
GM
87732011-07-01 Glenn Morris <rgm@gnu.org>
8774
8775 * Makefile.in (SETTINGS_LIBS): Fix typo.
8776
4550efdf
KI
87772011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8778
8779 * coding.c (Fencode_coding_string): Record the last coding system
8780 used, as the function doc string says (bug#8738).
8781
0949d2b6
JD
87822011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8783
8784 * xsettings.c (store_monospaced_changed): Take new font as arg and
8785 check for change against current_mono_font.
8786 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8787 (emacs_settings_constructor, emacs_settings_get_property)
8788 (emacs_settings_set_property, emacs_settings_class_init)
8789 (emacs_settings_init, gsettings_obj): Remove.
8790 (something_changedCB): New function for HAVE_GSETTINGS.
8791 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8792 with value as argument.
8793 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8794 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8795 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8796 "changed".
8797
8798 * xgselect.c: Add defined (HAVE_GSETTINGS).
8799 (xgselect_initialize): Ditto.
8800
8801 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8802 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8803 xg_select.
8804
bbc6b304
PE
88052011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8806
8807 * eval.c (struct backtrace): Simplify and port the data structure.
8808 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8809 signed bit field, as this assumption is not portable and it makes
8810 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8811 "char debug_on_exit : 1" as this is not portable either; instead,
8812 use the portable "unsigned int debug_on_exit : 1". Remove unused
8813 member evalargs. Remove obsolete comments about cc bombing out.
8814
9851bfc5
JD
88152011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8816
51bb811f 8817 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8818 Let HAVE_GSETTINGS override HAVE_GCONF.
8819 (store_monospaced_changed): New function.
8820 (EMACS_SETTINGS): A new type derived from GObject to handle
8821 GSettings notifications.
8822 (emacs_settings_constructor, emacs_settings_get_property)
8823 (emacs_settings_set_property, emacs_settings_class_init):
8824 New functions.
8825 (gsettings_client, gsettings_obj): New variables.
8826 (GSETTINGS_SCHEMA): New define.
8827 (something_changedCB): Call store_monospaced_changed.
8828 (init_gsettings): New function.
8829 (xsettings_initialize): Call init_gsettings.
8830 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8831 to NULL.
8832
640c8776 8833 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8834 GCONF_CFLAGS/LIBS.
8835
5386012d
MR
88362011-06-29 Martin Rudalics <rudalics@gmx.at>
8837
8838 * window.c (resize_root_window, grow_mini_window)
8839 (shrink_mini_window): Rename Qresize_root_window to
8840 Qwindow_resize_root_window and Qresize_root_window_vertically to
8841 Qwindow_resize_root_window_vertically.
8842
f13e0b08
PE
88432011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8844
8845 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8846
94515237
JB
88472011-06-27 Juanma Barranquero <lekktu@gmail.com>
8848
8849 * makefile.w32-in: Redesign dependencies so they reflect more
8850 clearly which files are directly included by each source file,
8851 and not through other includes.
8852
e43b6e43
MR
88532011-06-27 Martin Rudalics <rudalics@gmx.at>
8854
8855 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8856 (sort_overlays, overlay_strings): When an overlay's clone number
8857 matches the window's clone number process the overlay even if
8858 the overlay's window property doesn't match the current window.
8859
d68443dc
MR
8860 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8861 (Fwindow_hchild): Rename to Fwindow_left_child.
8862 (Fwindow_next): Rename to Fwindow_next_sibling.
8863 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8864 (resize_window_check): Rename to window_resize_check.
8865 (resize_window_apply): Rename to window_resize_apply.
8866 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8867 (Fdelete_other_windows_internal, resize_frame_windows)
8868 (Fsplit_window_internal, Fdelete_window_internal)
8869 (grow_mini_window, shrink_mini_window)
8870 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8871
c7e73be5
JD
88722011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8873
8874 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8875 (emacs_fixed_set_min_size): Remove.
8876 (emacs_fixed_new): Take frame as argument.
8877
8878 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8879 (_EmacsFixedPrivate): Remove minwidth/height.
8880 Add struct frame *f.
8881 (emacs_fixed_init): Initialize priv->f.
8882 (get_parent_class, emacs_fixed_set_min_size): Remove.
8883 (emacs_fixed_new): Set priv->f to argument.
8884 (emacs_fixed_get_preferred_width)
8885 (emacs_fixed_get_preferred_height): Use min_width/height from
8886 frames size_hint to set minimum and natural (Bug#8919).
8887 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8888 and use min_width/height from frames size_hint to set
8889 min_width/height (Bug#8919).
8890
8891 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8892 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8893 Fix indentation.
c7e73be5 8894
cf99dcf8
EZ
88952011-06-26 Eli Zaretskii <eliz@gnu.org>
8896
8897 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8898 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8899 called at ZV.
8900
029529ac
CY
89012011-06-26 Chong Yidong <cyd@stupidchicken.com>
8902
8903 * process.c (wait_reading_process_output): Bypass select if
8904 waiting for a cell while ignoring keyboard input, and input is
8905 pending. Suggested by Jan Djärv (Bug#8869).
8906
7a7ef429
PE
89072011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8908
8909 Use gnulib's dup2 module instead of rolling our own.
8910 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8911
11fdef7d 89122011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8913
8914 * dispnew.c (scrolling_window): Before scrolling, turn off a
8915 mouse-highlight in the window being scrolled.
8916
cd3520a4
JB
89172011-06-24 Juanma Barranquero <lekktu@gmail.com>
8918
8919 Move DEFSYM to lisp.h and use everywhere.
8920
8921 * character.h (DEFSYM): Move declaration...
8922 * lisp.h (DEFSYM): ...here.
8923
8924 * gnutls.c:
8925 * minibuf.c:
8926 * w32menu.c:
8927 * w32proc.c:
8928 * w32select.c: Don't include character.h.
8929
8930 * alloc.c (syms_of_alloc):
8931 * buffer.c (syms_of_buffer):
8932 * bytecode.c (syms_of_bytecode):
8933 * callint.c (syms_of_callint):
8934 * casefiddle.c (syms_of_casefiddle):
8935 * casetab.c (init_casetab_once):
8936 * category.c (init_category_once, syms_of_category):
8937 * ccl.c (syms_of_ccl):
8938 * cmds.c (syms_of_cmds):
8939 * composite.c (syms_of_composite):
8940 * dbusbind.c (syms_of_dbusbind):
8941 * dired.c (syms_of_dired):
8942 * dispnew.c (syms_of_display):
8943 * doc.c (syms_of_doc):
8944 * editfns.c (syms_of_editfns):
8945 * emacs.c (syms_of_emacs):
8946 * eval.c (syms_of_eval):
8947 * fileio.c (syms_of_fileio):
8948 * fns.c (syms_of_fns):
8949 * frame.c (syms_of_frame):
8950 * fringe.c (syms_of_fringe):
8951 * insdel.c (syms_of_insdel):
8952 * keymap.c (syms_of_keymap):
8953 * lread.c (init_obarray, syms_of_lread):
8954 * macros.c (syms_of_macros):
8955 * msdos.c (syms_of_msdos):
8956 * print.c (syms_of_print):
8957 * process.c (syms_of_process):
8958 * search.c (syms_of_search):
8959 * sound.c (syms_of_sound):
8960 * syntax.c (init_syntax_once, syms_of_syntax):
8961 * terminal.c (syms_of_terminal):
8962 * textprop.c (syms_of_textprop):
8963 * undo.c (syms_of_undo):
8964 * w32.c (globals_of_w32):
8965 * window.c (syms_of_window):
8966 * xdisp.c (syms_of_xdisp):
8967 * xfaces.c (syms_of_xfaces):
8968 * xfns.c (syms_of_xfns):
8969 * xmenu.c (syms_of_xmenu):
8970 * xsettings.c (syms_of_xsettings):
8971 * xterm.c (syms_of_xterm): Use DEFSYM.
8972
4228cf16
TZ
89732011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8974
cd3520a4 8975 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8976
7fcccf1e
PE
89772011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8978
7efb4e0e
PE
8979 Integer and buffer overflow fixes (Bug#8873).
8980
ff5844ad
PE
8981 * print.c (printchar, strout): Check for string overflow.
8982 (PRINTPREPARE, printchar, strout):
8983 Don't set size unless allocation succeeds.
8984
90532f02
PE
8985 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8986 for sizes. Check for string overflow more accurately.
8987 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8988
6d84508d
PE
8989 * macros.c: Integer and buffer overflow fixes.
8990 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8991 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8992 Use ptrdiff_t, not int, for sizes.
8993 Don't increment bufsize until after realloc succeeds.
8994 Check for size-calculation overflow.
8995 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8996
437b2cb4
PE
8997 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8998
8b9ac8b4
PE
8999 * lread.c: Integer overflow fixes.
9000 (read_integer): Radix is now EMACS_INT, not int,
9001 to improve quality of diagnostics for out-of-range radices.
9002 Calculate buffer size correctly for out-of-range radices.
9003 (read1): Check for integer overflow in radices, and in
9004 read-circle numbers.
82cb60d3
PE
9005 (read_escape): Avoid int overflow.
9006 (Fload, openp, read_buffer_size, read1)
9007 (substitute_object_recurse, read_vector, read_list, map_obarray):
9008 Use ptrdiff_t, not int, for sizes.
9009 (read1): Use EMACS_INT, not int, for sizes.
20270765 9010 Check for size overflow.
8b9ac8b4 9011
7fcccf1e
PE
9012 * image.c (cache_image): Check for size arithmetic overflow.
9013
bfbbd7e7
PE
9014 * lread.c: Integer overflow issues.
9015 (saved_doc_string_size, saved_doc_string_length)
9016 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9017 Now ptrdiff_t, not int.
9018 (read1): Don't assume doc string length fits in int. Check for
9019 out-of-range doc string lengths.
9020 (read_list): Don't assume file position fits in int.
39019e54 9021 (read_escape): Check for hex character overflow.
bfbbd7e7 9022
4e323265
LL
90232011-06-22 Leo Liu <sdl.web@gmail.com>
9024
9025 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9026 Move to minibuffer.el.
9027
85fece3e
PE
90282011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9029
20b84ce9 9030 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9031 The following patches are for when GLYPH_DEBUG && !XASSERT.
9032 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9033 * dispnew.c (flush_stdout):
9034 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9035 Mark as externally visible.
9036 * dispnew.c (check_window_matrix_pointers): Now static.
9037 * dispnew.c (window_to_frame_vpos):
9038 * xfns.c (unwind_create_frame):
9039 * xterm.c (x_check_font): Remove unused local.
9040 * scroll.c (CHECK_BOUNDS):
9041 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9042 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9043 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9044 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9045 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9046 Now static.
9047 (debug_method_add): Use va_list and vsprintf rather than relying
9048 on undefined behavior with wrong number of arguments.
9049 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9050 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9051 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9052 since we're not interested in debugging glyphs with old libraries.
9053 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9054 GCC 4.6.0's static checking.
9055
0766b489
PE
90562011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9057
31fd4b32
PE
9058 Integer overflow and signedness fixes (Bug#8873).
9059 A few related buffer overrun fixes, too.
9060
b79e8648
PE
9061 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9062
0766b489
PE
9063 * dispextern.h (struct face.stipple):
9064 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9065 (x_bitmap_mask, x_allocate_bitmap_record)
9066 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9067 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9068 (x_create_bitmap_from_xpm_data):
9069 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9070 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9071 (.bitmaps_last):
9072 * xfaces.c (load_pixmap):
9073 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9074 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9075 (.bitmaps_last, struct x_output.icon_bitmap):
9076 Use ptrdiff_t, not int, for bitmap indexes.
9077 (x_allocate_bitmap_record): Check for size overflow.
9078 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9079
b081724f
PE
9080 Use ptrdiff_t, not int, for overlay counts.
9081 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9082 * editfns.c (overlays_around, get_pos_property):
9083 * textprop.c (get_char_property_and_overlay):
9084 * xdisp.c (next_overlay_change, note_mouse_highlight):
9085 * xfaces.c (face_at_buffer_position):
21514da7
PE
9086 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9087 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9088 (Fnext_overlay_change, Fprevious_overlay_change)
9089 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9090 Use ptrdiff_t, not int, for sizes.
21514da7 9091 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9092
3de73e5e
PE
9093 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9094
2606c57b
PE
9095 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9096 (x_session_initialize): Do not assume string length fits in int.
9097
aaafe47a
PE
9098 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9099 This is unlikely, but can occur if DPI is outlandish.
9100
2674ddc8 9101 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9102 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9103
28154962
PE
9104 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9105 * xrdb.c (magic_file_p, search_magic_path):
9106 Omit last arg SUFFIX; it was always 0. All callers changed.
9107 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9108
7de51af5
PE
9109 * xfont.c (xfont_match): Avoid need for strlen.
9110
25ed6cc3
PE
9111 * xfns.c: Don't assume strlen fits in int.
9112 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9113
4eab31dd
PE
9114 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9115 not unsigned long, as we prefer signed integers. All callers changed.
9116 Detect integer overflow in repeat count.
9117 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9118 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9119
171e2a58
PE
9120 * termcap.c: Don't assume sizes fit in int and never overflow.
9121 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9122 (gobble_line): Check for size-calculation overflow.
9123
ad39faca 9124 * minibuf.c (Fread_buffer):
6e5bb2dc 9125 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9126 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9127 Don't assume string length fits in int.
9128
52c61c22 9129 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9130 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9131
b5b8c9e5
PE
9132 * font.c: Don't assume string length fits in int.
9133 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9134 Use ptrdiff_t, not int.
ccd6111c
PE
9135 (font_intern_prop): Don't assume string length fits in int.
9136 Don't assume integer property fits in fixnum.
9137 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9138
882f0d81 9139 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9140 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9141 Reformulate so as not to need the command string.
9142 Invoke gzip -cd rather than gunzip, as it's more portable.
9143 (lock_info_type, lock_file_1, lock_file):
9144 Don't assume pid_t and time_t fit in unsigned long.
9145 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9146 (current_lock_owner): Prefer signed type for sizes.
9147 Use memcpy, not strncpy, where memcpy is what is really wanted.
9148 Don't assume (via atoi) that time_t and pid_t fit in int.
9149 Check for time_t and/or pid_t out of range, e.g., via a network share.
9150 Don't alloca where an auto var works fine.
9151
93f4cf88
PE
9152 * fileio.c: Fix some integer overflow issues.
9153 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9154 Don't assume string length fits in int.
9155 (directory_file_name): Don't assume string length fits in long.
9156 (make_temp_name): Don't assume pid fits in int, or that its print
9157 length is less than 20.
9158
f3e92b69
PE
9159 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9160
1bfdaf10
PE
9161 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9162
35016e9a
PE
9163 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9164
3d1e65a1
PE
9165 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9166 We prefer signed integers, even for size calculations.
9167
0b963a93
PE
9168 * emacs.c: Don't assume string length fits in 'int'.
9169 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9170 (main): Don't invoke strlen when not needed.
9171
573f4b54
PE
9172 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9173 (XD_DEBUG_MESSAGE): Don't waste a byte.
9174
989f33ba
PE
9175 * callproc.c (getenv_internal_1, getenv_internal)
9176 (Fgetenv_internal):
965d34eb
PE
9177 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9178
e4d29b33
PE
9179 * lread.c (invalid_syntax): Omit length argument.
9180 All uses changed. This doesn't fix a bug, but it simplifies the
9181 code away from its former Hollerith-constant appearance, and it's
9182 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9183 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9184
eb49b136
PE
9185 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9186 This didn't break anything, but it didn't help either.
9187 It's confusing to put a bogus integer in a place where the actual
9188 value does not matter.
9f62aeb1 9189 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9190 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9191
15375a22
PE
9192 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9193 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9194 implementation.
b61cc01c
PE
9195 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9196 We prefer signed types, and the value cannot exceed the EMACS_INT
9197 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9198 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9199 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9200 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9201
53b2623d
PE
9202 * indent.c (sane_tab_width): New function.
9203 (current_column, scan_for_column, Findent_to, position_indentation)
9204 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9205 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9206
51cab52b 9207 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9208
f2ed8a70
PE
9209 * lisp.h (lint_assume): New macro.
9210 * composite.c (composition_gstring_put_cache):
9211 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9212
abe80cc6
PE
9213 * editfns.c, insdel.c:
9214 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9215
b02c740e
PE
9216 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9217
ebc96716
PE
9218 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9219
b4e50fa0 9220 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9221 Use much-faster test for byte-length change.
311d5d7c 9222 Don't assume string byte-length fits in 'int'.
a4cf38e4 9223 Check that character arg fits in 'int'.
85461888 9224 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9225
c0c1ee9f
PE
9226 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9227
a498d7f4
PE
9228 * fns.c (concat): Catch string overflow earlier.
9229 Do not rely on integer wraparound.
9230
51cab52b
PE
9231 * dispextern.h (struct it.overlay_strings_charpos)
9232 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9233 * xdisp.c (forward_to_next_line_start)
9234 (back_to_previous_visible_line_start)
9235 (reseat_at_next_visible_line_start, next_element_from_buffer):
9236 Don't arbitrarily truncate the value of 'selective' to int.
9237
76031fad
PE
9238 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9239
5eb55db9
PE
9240 * composite.c: Don't truncate sizes to 'int'.
9241 (composition_gstring_p, composition_reseat_it)
9242 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9243 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9244 not EMACS_UINT, for indexes.
5eb55db9 9245
0703a717
PE
9246 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9247
d6202519
PE
9248 * buffer.c: Include <verify.h>.
9249 (struct sortvec.priority, struct sortstr.priority):
8961a454 9250 Now EMACS_INT, not int.
c20998a7 9251 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9252 (struct sortstr.size, record_overlay_string)
9253 (struct sortstrlist.size, struct sortlist.used):
9254 Don't truncate size to int.
9255 (record_overlay_string): Check for size-calculation overflow.
d6202519 9256 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9257
d5a19415
JM
92582011-06-22 Jim Meyering <meyering@redhat.com>
9259
029529ac 9260 Don't leak an XBM-image-sized buffer
d5a19415
JM
9261 * image.c (xbm_load): Free the image buffer after using it.
9262
a9041e6c
PE
92632011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9264
9265 Port to Sun C.
9266 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9267 that Sun C diagnosed.
9268 * fns.c (secure_hash): Fix pointer signedness issue.
9269 * intervals.c (static_offset_intervals): New function.
9270 (offset_intervals): Use it.
9271
7f3f739f
LL
92722011-06-21 Leo Liu <sdl.web@gmail.com>
9273
9274 * deps.mk (fns.o):
9275 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9276 sha512.h.
9277
9278 * fns.c (secure_hash): Rename from crypto_hash_function and change
9279 the first arg to accept symbols.
5b66d427 9280 (Fsecure_hash): New primitive.
7f3f739f
LL
9281 (syms_of_fns): New symbols.
9282
76147d94
DD
92832011-06-20 Deniz Dogan <deniz@dogan.se>
9284
9285 * process.c (Fset_process_buffer): Clarify return value in
9286 docstring.
9287
7d7d0045
CY
92882011-06-18 Chong Yidong <cyd@stupidchicken.com>
9289
9290 * dispnew.c (add_window_display_history): Use BVAR.
9291
9292 * xdisp.c (debug_method_add): Use BVAR.
9293 (check_window_end, dump_glyph_matrix, dump_glyph)
9294 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9295
9296 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9297 Likewise.
9298
9299 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9300 check till after the cache is created in init_frame_faces.
9301
ff2bc410
SM
93022011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9303
9304 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9305
28177add
PE
93062011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9307
dd3482fe
PE
9308 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9309 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9310 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9311
393d71f3 9312 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9313 * fileio.c (Finsert_file_contents):
9314 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9315 Remove the old (too-loose) buffer overflow checks.
9316 They weren't needed, since make_gap checks for buffer overflow.
9317 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9318 The old code merely checked for Emacs fixnum overflow, and relied
9319 on undefined (wraparound) behavior. The new code avoids undefined
9320 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9321
2e6813b0 9322 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9323 Tune. Don't use wider integers than needed. Don't use alloca.
9324 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9325
599a9e4f
PE
9326 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9327
99561444
PE
9328 * insdel.c, lisp.h (buffer_overflow): New function.
9329 (insert_from_buffer_1, replace_range, replace_range_2):
9330 * insdel.c (make_gap_larger):
9331 * editfns.c (Finsert_char):
9332 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9333
28177add
PE
9334 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9335
e69dafad
PE
93362011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9337
4baa020d 9338 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9339
b1c46f02
PE
9340 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9341 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9342
e69dafad
PE
9343 * fileio.c: Don't assume EMACS_INT fits in off_t.
9344 (emacs_lseek): New static function.
9345 (Finsert_file_contents, Fwrite_region): Use it.
9346 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9347
566684ea
PE
9348 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9349
e6966cd6
PE
9350 * fns.c: Don't overflow int when computing a list length.
9351 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9352 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9353 truncation on 64-bit hosts. Check for QUIT every
9354 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9355 faster and is responsive enough.
9356 (Flength): Report an error instead of overflowing an integer.
9357 (Fsafe_length): Return a float if the value is not representable
9358 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9359 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9360 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9361
dd0b0efb
PE
9362 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9363 (header_size, word_size): New constants.
9364 (allocate_vectorlike): Don't check size overflow here.
9365 (allocate_vector): Check it here instead, since this is the only
9366 caller of allocate_vectorlike that could cause overflow.
9367 Check that the new vector's length is representable as a fixnum.
9368
86fe5cfe
PE
9369 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9370 The previous code was bogus. For example, next_almost_prime (32)
9371 returned 39, which is undesirable as it is a multiple of 3; and
9372 next_almost_prime (24) returned 25, which is a multiple of 5 so
9373 why was the code bothering to check for multiples of 7?
9374
80e88859
PE
9375 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9376
4a2f0ad6
PE
9377 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9378
f66c7cf8
PE
9379 Variadic C functions now count arguments with ptrdiff_t.
9380 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9381 Back then I didn't know that the Emacs coding style prefers signed int.
9382 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9383 were being counted with int, which may truncate counts on 64-bit
9384 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9385 * lisp.h (struct Lisp_Subr.function.aMANY)
9386 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9387 Arg counts are now ptrdiff_t, not size_t.
9388 All variadic functions and their callers changed accordingly.
9389 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9390 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9391 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9392 * callint.c (Fcall_interactively): Check arg count for overflow,
9393 to avoid potential buffer overrun. Use signed char, not 'int',
9394 for 'varies' array, so that we needn't bother to check its size
9395 calculation for overflow.
9396 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9397 * eval.c (apply_lambda):
9398 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9399 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9400 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9401
a1759b76
PE
9402 * callint.c (Fcall_interactively): Don't use index var as event count.
9403
d96be9fc
PE
9404 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9405 * mem-limits.h (SIZE): Remove; no longer used.
9406
a690a978 9407 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9408
578c21e6
PE
9409 Remove unnecessary casts.
9410 * xterm.c (x_term_init):
9411 * xfns.c (x_set_border_pixel):
9412 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9413 These aren't needed now that we assume ANSI C.
9414
96f53c6c
PE
9415 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9416 It's more likely to cause problems (due to unsigned overflow)
9417 than to cure them.
9418
83c77d31
PE
9419 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9420
ee2079f1
PE
9421 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9422
6da65536
PE
9423 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9424
7147c4a4
PE
9425 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9426
193e32d9
PE
9427 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9428
e5533da6
PE
9429 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9430
9910e595
PE
9431 GLYPH_CODE_FACE returns EMACS_INT, not int.
9432 * dispextern.h (merge_faces):
9433 * xfaces.c (merge_faces):
01103c44
PE
9434 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9435 Don't assume EMACS_INT fits in int.
9910e595 9436
2638320e
PE
9437 * character.h (CHAR_VALID_P): Remove unused parameter.
9438 * fontset.c, lisp.h, xdisp.c: All uses changed.
9439
045eb8d9
PE
9440 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9441
c1f134b5
PE
9442 * fns.c (concat): Minor tuning based on overflow analysis.
9443 This doesn't fix any bugs. Use int to hold character, instead
9444 of constantly refetching from Emacs object. Use XFASTINT, not
9445 XINT, for value known to be a character. Don't bother comparing
9446 a single byte to 0400, as it's always less.
9447
395fcb93 9448 * floatfns.c (Fexpt):
327eeec8
PE
9449 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9450
abbd3d23
PE
9451 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9452 for characters.
9453
684a03ef
PE
9454 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9455
0fed43f3
PE
9456 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9457 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9458 incorrectly succeed when S was a string, because 4294967386 was
9459 truncated before it was used.
9460
8fd02eb7
PE
9461 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9462 Otherwise, an out-of-range integer could cause undefined behavior
9463 on a 64-bit host.
9464
f8c86b69
PE
9465 * composite.c: Use int, not EMACS_INT, for characters.
9466 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9467 EMACS_INT, for values that are known to be in character range.
9468 This doesn't fix any bugs but is the usual style inside Emacs and
9469 may generate better code on 32-bit machines.
9470
34206dd2
PE
9471 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9472 This is for reasons similar to the recent CHAR_STRING fix.
9473 * charset.c (Fencode_char): Check that character arg is actually
9474 a character. Pass an int to ENCODE_CHAR.
9475 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9476 wider than 'int', as a compile-time check to prevent future regressions
9477 in this area.
9478
c5958d4c 9479 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9480
9481 Make sure a 64-bit char is never passed to CHAR_STRING.
9482 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9483 by silently ignoring the top 32 bits, allowing some values
9484 that were far too large to be valid characters.
9485 * character.h: Include <verify.h>.
9486 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9487 arguments are no wider than unsigned, as a compile-time check
9488 to prevent future regressions in this area.
9489 * data.c (Faset):
01103c44 9490 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9491 (Fsubst_char_in_region):
9492 * fns.c (concat):
9493 * xdisp.c (decode_mode_spec_coding):
9494 Adjust to CHAR_STRING's new requirement.
9495 * editfns.c (Finsert_char, Fsubst_char_in_region):
9496 * fns.c (concat): Check that character args are actually
9497 characters. Without this test, these functions did the wrong
9498 thing with wildly out-of-range values on 64-bit hosts.
9499
d37ca623
PE
9500 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9501 These casts should not be needed on 32-bit hosts, either.
9502 * keyboard.c (read_char):
9503 * lread.c (Fload): Remove casts to unsigned.
9504
ea204efb
PE
9505 * lisp.h (UNSIGNED_CMP): New macro.
9506 This fixes comparison bugs on 64-bit hosts.
9507 (ASCII_CHAR_P): Use it.
9508 * casefiddle.c (casify_object):
01103c44 9509 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9510 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9511 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9512 * dispextern.h (FACE_FROM_ID):
9513 * keyboard.c (read_char): Use UNSIGNED_CMP.
9514
41cb286c
PE
9515 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9516 not to EMACS_INT, to avoid GCC warning.
9517
4a1b9832
PE
9518 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9519
55daad71
PE
9520 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9521 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9522 isn't needed on 32-bit machines.
8f95c75c 9523
01103c44
PE
9524 * buffer.c (Fgenerate_new_buffer_name):
9525 Use EMACS_INT for count, not int.
0ceccced 9526 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9527
9528 * data.c (Qcompiled_function): Now static.
9529
c6f072e7
PE
9530 * window.c (window_body_lines): Now static.
9531
20ce5912
PE
9532 * image.c (gif_load): Rename local to avoid shadowing.
9533
9c4c5f81
PE
9534 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9535 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9536 * alloc.c (make_save_value): Integer argument is now of type
9537 ptrdiff_t, not int.
9538 (mark_object): Use ptrdiff_t, not int.
9539 * lisp.h (pD): New macro.
9540 * print.c (print_object): Use it.
9541
c0c5c8ae
PE
9542 * alloc.c: Use EMACS_INT, not int, to count objects.
9543 (total_conses, total_markers, total_symbols, total_vector_size)
9544 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9545 (total_free_floats, total_floats, total_free_intervals)
9546 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9547 Now EMACS_INT, not int. All uses changed.
9548 (Fgarbage_collect): Compute overall total using a double, so that
9549 integer overflow is less likely to be a problem. Check for overflow
9550 when converting back to an integer.
5a25e253
PE
9551 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9552 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9553 These were 'int' variables that could overflow on 64-bit hosts;
9554 they were never used, so remove them instead of repairing them.
211a0b2a 9555 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9556 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9557 Previously, this ceilinged at INT_MAX, but that doesn't work on
9558 64-bit machines.
e46bb31a 9559 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9560
c78baabf 9561 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9562 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9563 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9564 when a (possibly-narrower) signed value would do just as well.
9565 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9566
c9d624c6
PE
9567 * alloc.c: Catch some string size overflows that we were missing.
9568 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9569 for convenience in STRING_BYTES_MAX.
9570 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9571 The definition here is exact; the one in lisp.h was approximate.
9572 (allocate_string_data): Check for string overflow. This catches
9573 some instances we weren't catching before. Also, it catches
9574 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9575 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9576 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9577
c9d624c6
PE
9578 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9579 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9580 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9581
353032ce
PE
9582 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9583
2bccce07
PE
9584 * alloc.c (Fmake_string): Check for out-of-range init.
9585
0ac30604
SM
95862011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9587
9588 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9589
c195f2de
JD
95902011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9591
9592 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9593 xg_get_default_scrollbar_width.
9594
9595 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9596 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9597 (style_changed_cb): Call update_theme_scrollbar_width and call
9598 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9599 all frames (Bug#8505).
9600 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9601 Call gtk_window_set_resizable if HAVE_GTK3.
9602 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9603 and height if HAVE_GTK3 (Bug#8505).
9604 (scroll_bar_width_for_theme): New variable.
9605 (update_theme_scrollbar_width): New function.
9606 (xg_get_default_scrollbar_width): Move code to
9607 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9608 (xg_initialize): Call update_theme_scrollbar_width.
9609
9610 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9611
9612 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9613
e10ac9f1
MR
96142011-06-12 Martin Rudalics <rudalics@gmx.at>
9615
9616 * frame.c (make_frame): Call other_buffer_safely instead of
9617 other_buffer.
9618
9619 * window.c (temp_output_buffer_show): Call display_buffer with
9620 second argument Vtemp_buffer_show_specifiers and reset latter
9621 immediately after the call.
9622 (Vtemp_buffer_show_specifiers): New variable.
9623 (auto_window_vscroll_p, next_screen_context_lines)
9624 (Vscroll_preserve_screen_position): Remove leading asterisks from
9625 doc-strings.
9626
2d3c217e 96272011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9628
7b7f97e8 9629 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9630 * buffer.c (Qclone_number): Remove for now, as it's unused.
9631 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9632 (record_buffer): Remove unused local.
9633 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9634 (set_frame_buffer_list): Remove; unused.
9635 * frame.h (other_visible_frames): Remove decl.
9636 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9637 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9638 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9639 if HAVE_GPM.
9640 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9641 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9642 Define only if HAVE_GPM.
9643 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9644 (update_hints_inhibit): Remove; never set. All uses removed.
9645 * widgetprv.h (emacsFrameClassRec): Remove decl.
9646 * window.c (delete_deletable_window): Now returns void, since it
9647 wasn't returning anything.
9648 (compare_window_configurations): Remove unused locals.
9649 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9650 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9651 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9652 the same widths as pointers. This follows up on the 2011-05-06 patch.
9653 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9654 * xterm.h: Likewise.
9655 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9656
1384b89e
JB
96572011-06-12 Juanma Barranquero <lekktu@gmail.com>
9658
9659 * makefile.w32-in: Update dependencies.
9660 (LISP_H): Add lib/intprops.h.
9661
1100a63c
CY
96622011-06-11 Chong Yidong <cyd@stupidchicken.com>
9663
9664 * image.c (gif_load): Add animation frame delay to the metadata.
9665 (syms_of_image): Use DEFSYM. New symbol `delay'.
9666
6198ccd0
MR
96672011-06-11 Martin Rudalics <rudalics@gmx.at>
9668
9669 * window.c (delete_deletable_window): Re-add.
9670 (Fset_window_configuration): Rewrite to handle dead buffers and
9671 consequently deletable windows.
9672 (window_tree, Fwindow_tree): Remove. Supply functionality in
9673 window.el.
9674 (compare_window_configurations): Simplify code.
9675
b6e3633c
AS
96762011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9677
1ab0dee5
AS
9678 * image.c (imagemagick_load_image): Fix type mismatch.
9679 (Fimagemagick_types): Likewise.
9680
b6e3633c
AS
9681 * window.h (replace_buffer_in_windows): Declare.
9682
9397e56f
MR
96832011-06-11 Martin Rudalics <rudalics@gmx.at>
9684
9685 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9686 Qclone_number. Remove external declaration of Qdelete_window.
9687 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9688 code.
640c8776
SM
9689 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9690 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9691 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9692 buffer list implementation.
9693 (other_buffer_safely): New function.
9694 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9695 calls to replace_buffer_in_windows and
9696 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9697 if allowed.
9698 (record_buffer): Inhibit quitting and rewrite using quittable
9699 functions. Run Qbuffer_list_update_hook if allowed.
9700 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9701 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9702 Move switch-to-buffer to window.el.
9397e56f
MR
9703 (bury-buffer): Move to window.el.
9704 (Vbuffer_list_update_hook): New variable.
9705
9706 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9707 section.
9708
9709 * window.h (resize_frame_windows): Move up in code.
9710 (Fwindow_frame): Remove EXFUN.
9711 (replace_buffer_in_all_windows): Remove prototype.
9712 (replace_buffer_in_windows_safely): Add prototype.
9713
9714 * window.c: Declare Qdelete_window static again. Move down
9715 declaration of select_count.
9716 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9717 (Fother_window): Move to window.el.
9718 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9719 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9720 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9721 window.el.
9722 (replace_buffer_in_windows): Implement by calling
9723 Qreplace_buffer_in_windows.
9724 (replace_buffer_in_all_windows): Remove with some functionality
9725 moved into replace_buffer_in_windows_safely.
9726 (replace_buffer_in_windows_safely): New function.
9727 (select_window_norecord, select_frame_norecord): Move in front
9728 of run_window_configuration_change_hook. Remove now obsolete
9729 declarations.
640c8776
SM
9730 (Fset_window_buffer): Rewrite doc-string.
9731 Call Qrecord_window_buffer.
9397e56f
MR
9732 (keys_of_window): Move binding for other-window to window.el.
9733
b50691aa
CY
97342011-06-11 Chong Yidong <cyd@stupidchicken.com>
9735
9736 * dispextern.h (struct image): Replace data member, whose int_val
9737 and ptr_val fields were not used by anything, with a single
9738 lisp_val object.
9739
9740 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9741 (gif_clear_image, gif_load, imagemagick_load_image)
9742 (gs_clear_image, gs_load): Callers changed.
9743
3f754b86
PE
97442011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9745
cca69397
PE
9746 * buffer.h: Include <time.h>, for time_t.
9747 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9748
109e28d0
PE
9749 Fix minor problems found by static checking.
9750
60737f02
PE
9751 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9752
4b66faf3
PE
9753 Make identifiers static if they are not used in other modules.
9754 * data.c (Qcompiled_function, Qframe, Qvector):
9755 * image.c (QimageMagick, Qsvg):
9756 * minibuf.c (Qmetadata):
9757 * window.c (resize_window_check, resize_root_window): Now static.
9758 * window.h (resize_window_check, resize_root_window): Remove decls.
9759
109e28d0
PE
9760 * window.c (window_deletion_count, delete_deletable_window):
9761 Remove; unused.
46a4ce9e
PE
9762 (window_body_lines): Now static.
9763 (Fdelete_other_windows_internal): Mark vars as initialized.
9764 Make sure 'resize_failed' is initialized.
9765 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9766 (resize_window_apply): Remove unused local.
9767 * window.h (delete_deletable_window): Remove decl.
9768
109e28d0 9769 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9770 (imagemagick_load_image): Fix pointer signedness problem by changing
9771 last arg from unsigned char * to char *. All uses changed.
9772 Also, fix a local for similar reasons.
9773 Remove unused locals. Remove locals to avoid shadowing.
9774 (fn_rsvg_handle_free): Remove; unused.
9775 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9776 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9777
3f754b86
PE
9778 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9779
2547adb1
CY
97802011-06-10 Chong Yidong <cyd@stupidchicken.com>
9781
9782 * image.c (gif_load): Fix omitted cast error introduced by
9783 2011-06-06 change.
9784
2c8e37d4
MR
97852011-06-10 Martin Rudalics <rudalics@gmx.at>
9786
9787 * window.h (resize_proportionally, orig_total_lines)
9788 (orig_top_line): Remove from window structure.
9789 (set_window_height, set_window_width, change_window_heights)
9790 (Fdelete_window): Remove prototypes.
9791 (resize_frame_windows): Remove duplicate declaration.
9792
440a42e3
EZ
97932011-06-10 Eli Zaretskii <eliz@gnu.org>
9794
9795 * window.h (resize_frame_windows, resize_window_check)
9796 (delete_deletable_window, resize_root_window)
9797 (resize_frame_windows): Declare prototypes.
9798
9799 * window.c (resize_window_apply): Make definition be "static" to
9800 match the prototype.
9801
562dd5e9
MR
98022011-06-10 Martin Rudalics <rudalics@gmx.at>
9803
9804 * window.c: Remove declarations of Qwindow_size_fixed,
9805 window_min_size_1, window_min_size_2, window_min_size,
9806 size_window, window_fixed_size_p, enlarge_window, delete_window.
9807 Remove static from declaration of Qdelete_window, it's
9808 temporarily needed by Fbury_buffer.
9809 (replace_window): Don't assign orig_top_line and
9810 orig_total_lines.
9811 (Fdelete_window, delete_window): Remove. Window deletion is
9812 handled by window.el.
640c8776
SM
9813 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9814 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9815 (Fdelete_other_windows): Remove. Deleting other windows is
9816 handled by window.el.
9817 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9818 handled in window.el.
9819 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9820 Window minimum sizes are handled in window.el.
9821 (shrink_windows, size_window, set_window_height)
9822 (set_window_width, change_window_heights, window_height)
9823 (window_width, CURBEG, CURSIZE, enlarge_window)
9824 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9825 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9826 handled in window.el.
9827 (make_dummy_parent): Rename to make_parent_window and give it a
9828 second argument horflag.
9829 (make_window): Don't set resize_proportionally any more.
9830 (Fsplit_window): Remove. Windows are split in window.el.
9831 (save_restore_action, save_restore_orig_size)
9832 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9833 Resize mini windows in window.el.
9834 (grow_mini_window, shrink_mini_window): Implement by calling
9835 Qresize_root_window_vertically, resize_window_check and
9836 resize_window_apply.
640c8776
SM
9837 (saved_window, Fset_window_configuration, save_window_save):
9838 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9839 resize_proportionally.
9840 (window_min_height, window_min_width): Move to window.el.
9841 (keys_of_window): Move bindings for delete-other-windows,
9842 split-window, delete-window and enlarge-window to window.el.
9843
9844 * buffer.c: Temporarily extern Qdelete_window.
9845 (Fbury_buffer): Temporarily call Qdelete_window instead of
9846 Fdelete_window (Fbury_buffer will move to window.el soon).
9847
9848 * frame.c (set_menu_bar_lines_1): Remove code handling
9849 orig_top_line and orig_total_lines.
9850
9851 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9852 set_window_height but set heights directly.
9853 (change_frame_size_1): Use resize_frame_windows.
9854
9855 * xdisp.c (init_xdisp): Don't use set_window_height but set
9856 heights directly.
9857
640c8776
SM
9858 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9859 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9860 run_window_configuration_change_hook.
9861
9862 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9863 instead of change_window_heights and run
9864 run_window_configuration_change_hook.
9865
1a13852e
MR
98662011-06-09 Martin Rudalics <rudalics@gmx.at>
9867
9868 * window.c (replace_window): Rename second argument REPLACEMENT to
9869 NEW. New third argument SETFLAG. Rewrite.
9870 (delete_window, make_dummy_parent): Call replace_window with
9871 third argument 1.
9872 (window_list_1): Move down in code.
9873 (run_window_configuration_change_hook): Move set_buffer part
9874 before select_frame_norecord part in order to unwind correctly.
9875 Rename count1 to count.
9876 (recombine_windows, delete_deletable_window, resize_root_window)
9877 (Fdelete_other_windows_internal)
9878 (Frun_window_configuration_change_hook, make_parent_window)
9879 (resize_window_check, resize_window_apply, Fresize_window_apply)
9880 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9881 (Fdelete_window_internal, Fresize_mini_window_internal):
9882 New functions.
1a13852e
MR
9883 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9884
f3d1777e
MR
98852011-06-08 Martin Rudalics <rudalics@gmx.at>
9886
496e208e
MR
9887 * window.h (window): Add some new members to window structure -
9888 normal_lines, normal_cols, new_total, new_normal, clone_number,
9889 splits, nest, prev_buffers, next_buffers.
9890 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9891 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9892
f3d1777e
MR
9893 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9894 Remove.
496e208e
MR
9895 (make_dummy_parent): Set new members of windows structure.
9896 (make_window): Move down in code. Handle new members of window
9897 structure.
9898 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9899 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9900 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9901 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9902 (Fset_window_next_buffers, Fset_window_clone_number):
9903 New functions.
496e208e
MR
9904 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9905 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9906 Doc-string fixes.
9907 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9908 Argument WINDOW can be now internal window too.
9909 (Fwindow_use_time): Move up in code.
9910 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9911 Rewrite doc-string.
9912 (Fset_window_configuration, saved_window)
9913 (Fcurrent_window_configuration, save_window_save): Handle new
9914 members of window structure.
b9e809c2
MR
9915 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9916 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9917 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9918 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9919 Qget_mru_window, Qresize_root_window,
9920 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9921 Qauto_buffer_name; staticpro them.
f3d1777e 9922
abde8f8c
MR
99232011-06-07 Martin Rudalics <rudalics@gmx.at>
9924
9925 * window.c (Fwindow_total_size, Fwindow_left_column)
9926 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9927 (Fwindow_list_1): New functions.
9928 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9929 (Fwindow_width, Fscroll_left, Fscroll_right):
9930 Use window_body_cols instead of window_box_text_cols.
9931 (delete_window, Fset_window_configuration):
9932 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9933 (delete_all_subwindows): Take a window as argument and not a
9934 structure. Rewrite.
190b47e6
MR
9935 (window_loop): Remove handling of GET_LRU_WINDOW and
9936 GET_LARGEST_WINDOW.
9937 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9938
9939 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9940 window_box_text_cols. delete_all_subwindows now takes a
9941 Lisp_Object as argument.
abde8f8c 9942
640c8776
SM
9943 * indent.c (compute_motion, Fcompute_motion):
9944 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9945
fa8a67e6
MR
9946 * frame.c (delete_frame): Call delete_all_subwindows with root
9947 window as argument.
9948
a54e3482
DC
99492011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9950
9951 * fns.c (Fputhash): Document return value.
9952
60002bf5
CY
99532011-06-06 Chong Yidong <cyd@stupidchicken.com>
9954
9955 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9956
0c671da6 99572011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9958
b862a52a 9959 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9960
be44ca6c
PE
9961 Check for overflow when converting integer to cons and back.
9962 * charset.c (Fdefine_charset_internal, Fdecode_char):
9963 Use cons_to_unsigned to catch overflow.
9964 (Fencode_char): Use INTEGER_TO_CONS.
9965 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9966 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9967 * data.c (long_to_cons, cons_to_long): Remove.
9968 (cons_to_unsigned, cons_to_signed): New functions.
9969 These signal an error for invalid or out-of-range values.
9970 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9971 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9972 * font.c (Ffont_variation_glyphs):
9973 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9974 * lisp.h: Include <intprops.h>.
9975 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9976 (cons_to_signed, cons_to_unsigned): New decls.
9977 (long_to_cons, cons_to_long): Remove decls.
9978 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9979 (Fprimitive_undo): Use CONS_TO_INTEGER.
9980 * xfns.c (Fx_window_property): Likewise.
9981 * xselect.c: Include <limits.h>.
9982 (x_own_selection, selection_data_to_lisp_data):
9983 Use INTEGER_TO_CONS.
9984 (x_handle_selection_request, x_handle_selection_clear)
9985 (x_get_foreign_selection, Fx_disown_selection_internal)
9986 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9987 (lisp_data_to_selection_data): Use cons_to_unsigned.
9988 (x_fill_property_data): Use cons_to_signed.
9989 Report values out of range.
9990
d1f3d2af
PE
9991 Check for buffer and string overflow more precisely.
9992 * buffer.h (BUF_BYTES_MAX): New macro.
9993 * lisp.h (STRING_BYTES_MAX): New macro.
9994 * alloc.c (Fmake_string):
9995 * character.c (string_escape_byte8):
9996 * coding.c (coding_alloc_by_realloc):
9997 * doprnt.c (doprnt):
9998 * editfns.c (Fformat):
9999 * eval.c (verror):
10000 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10001 since they may not be the same number.
10002 * editfns.c (Finsert_char):
10003 * fileio.c (Finsert_file_contents):
10004 Likewise for BUF_BYTES_MAX.
10005
dd52fcea
PE
10006 * image.c: Use ptrdiff_t, not int, for sizes.
10007 (slurp_file): Switch from int to ptrdiff_t.
10008 All uses changed.
10009 (slurp_file): Check that file size fits in both size_t (for
10010 malloc) and ptrdiff_t (for sanity and safety).
10011
7f9bbdbb
PE
10012 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10013 if b->modtime has its maximal value.
10014
dfe18f82
PE
10015 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10016
84acfcf0
PE
10017 Don't assume time_t can fit into int.
10018 * buffer.h (struct buffer.modtime): Now time_t, not int.
10019 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10020 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10021
ccd9a01a
PE
10022 Minor fixes for signed vs unsigned integers.
10023 * character.h (MAYBE_UNIFY_CHAR):
10024 * charset.c (maybe_unify_char):
10025 * keyboard.c (read_char, reorder_modifiers):
10026 XINT -> XFASTINT, since the integer must be nonnegative.
10027 * ftfont.c (ftfont_spec_pattern):
10028 * keymap.c (access_keymap, silly_event_symbol_error):
10029 XUINT -> XFASTINT, since the integer must be nonnegative.
10030 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10031 since it makes no difference and we prefer signed.
10032 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10033 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10034 nonnegative.
10035
d6d100dd
SM
100362011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10037
10038 * window.h (Fwindow_frame): Declare.
10039
2b6148e4
PE
100402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10041
10042 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10043 (SPARE_MEMORY): Always define.
10044 (LARGE_REQUEST): Remove.
10045 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10046
f230ecc9
MR
100472011-06-06 Martin Rudalics <rudalics@gmx.at>
10048
727e958e
MR
10049 * lisp.h: Move EXFUNS for Fframe_root_window,
10050 Fframe_first_window and Fset_frame_selected_window to window.h.
10051
10052 * window.h: Move EXFUNS for Fframe_root_window,
10053 Fframe_first_window and Fset_frame_selected_window here from
10054 lisp.h.
10055
10056 * frame.c (Fwindow_frame, Fframe_first_window)
10057 (Fframe_root_window, Fframe_selected_window)
10058 (Fset_frame_selected_window): Move to window.c.
10059 (Factive_minibuffer_window): Move to minibuf.c.
10060 (Fother_visible_frames_p): New function.
10061
10062 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10063
f230ecc9
MR
10064 * window.c (decode_window, decode_any_window): Move up in code.
10065 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10066 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10067 (Fwindow_buffer): Move up and rewrite doc-string.
10068 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10069 (Fwindow_prev): New functions.
727e958e
MR
10070 (Fwindow_frame): Move here from frame.c. Accept any window as
10071 argument.
10072 (Fframe_root_window, Fframe_first_window)
10073 (Fframe_selected_window): Move here from frame.c. Accept frame
10074 or arbitrary window as argument. Update doc-strings.
10075 (Fminibuffer_window): Move up in code.
10076 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10077 (Fset_frame_selected_window): Move here from frame.c.
10078 Marginal rewrite.
727e958e
MR
10079 (Fselected_window, select_window, Fselect_window): Move up in
10080 code. Minor doc-string fixes.
f230ecc9 10081
4d09bcf6
PE
100822011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10083
10084 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10085 Do not assume that spare memory exists; that assumption is valid
10086 only if SYSTEM_MALLOC.
10087 (LARGE_REQUEST): New macro, so that the issue of large requests
10088 is separated from the issue of spare memory.
10089
810928a2
AS
100902011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10091
172418ad
AS
10092 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10093 format. (Bug#8806)
10094
43f862f7
AS
10095 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10096
810928a2
AS
10097 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10098 before statements.
10099
a059fe24
JD
101002011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10101
10102 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10103
10104 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10105
10106 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10107 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10108
989bf368
JB
101092011-06-05 Juanma Barranquero <lekktu@gmail.com>
10110
10111 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10112
4b80f674
CY
101132011-06-04 Chong Yidong <cyd@stupidchicken.com>
10114
10115 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10116 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10117 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10118 New error handlers.
4b80f674
CY
10119 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10120 Obey Vx_select_enable_clipboard_manager. Catch errors in
10121 x_clipboard_manager_save (Bug#8779).
10122 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10123 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10124
99a33b77 101252011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10126
10127 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10128
99a33b77 101292011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10130
10131 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10132 in the current matrix if keep_current_p is non-zero.
10133
8264569d
EZ
101342011-06-04 Eli Zaretskii <eliz@gnu.org>
10135
10136 * bidi.c (bidi_level_of_next_char): Fix last change.
10137
57f97249
EZ
101382011-06-03 Eli Zaretskii <eliz@gnu.org>
10139
fec2107c 10140 Support bidi reordering of text covered by display properties.
57f97249 10141
fec2107c
EZ
10142 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10143 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10144 (bidi_cache_search, bidi_cache_iterator_state)
10145 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10146 (bidi_level_of_next_char, bidi_move_to_visually_next):
10147 Support character positions inside a run of characters covered by a
fec2107c
EZ
10148 display string.
10149 (bidi_paragraph_init, bidi_resolve_explicit_1)
10150 (bidi_level_of_next_char): Call bidi_fetch_char and
10151 bidi_fetch_char_advance instead of FETCH_CHAR and
10152 FETCH_CHAR_ADVANCE.
10153 (bidi_init_it): Initialize new members.
10154 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10155 definitions.
10156 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10157 instead of using explicit *_CHAR codes.
d6d100dd
SM
10158 (bidi_resolve_explicit, bidi_resolve_weak):
10159 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10160 bidirectional text is supported only in multibyte buffers.
10161 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10162 it to initialize the frame_window_p member of struct bidi_it.
10163 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10164 (bidi_resolve_explicit, bidi_resolve_weak)
10165 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10166 bidi_it->nchars is non-positive.
10167 (bidi_level_of_next_char): Don't try to lookup the cache for the
10168 next/previous character if nothing is cached there yet, or if we
10169 were just reseat()'ed to a new position.
c40e2fb2 10170
0e14fe90
EZ
10171 * xdisp.c (set_cursor_from_row): Set start and stop points
10172 according to the row's direction when priming the loop that looks
10173 for the glyph on which to display cursor.
10174 (single_display_spec_intangible_p): Function deleted.
10175 (display_prop_intangible_p): Reimplement to call
10176 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10177 Accept 3 additional arguments needed by handle_display_spec.
10178 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10179 values: lists, `(when COND...)' forms, etc.
10180 (single_display_spec_string_p): Support property values that are
10181 lists with the argument STRING its top-level element.
10182 (display_prop_string_p): Fix the condition for processing a
10183 property that is a list to be consistent with handle_display_spec.
fec2107c 10184 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10185 last portion of handle_display_prop.
10186 (compute_display_string_pos): Accept additional argument
10187 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10188 value of a `display' property is a "replacing spec".
10189 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10190 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10191 the display property, but just return a value indicating whether
10192 the display property will replace the characters it covers.
10193 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10194 frame_window_p members of struct bidi_it.
d6d100dd
SM
10195 (compute_display_string_pos, compute_display_string_end):
10196 New functions.
fec2107c
EZ
10197 (push_it): Accept second argument POSITION, where pop_it should
10198 jump to continue iteration.
10199 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10200
fec2107c
EZ
10201 * keyboard.c (adjust_point_for_property): Adjust the call to
10202 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10203
10204 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10205 (bidi_init_it): Update prototypes.
10206 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10207 (compute_display_string_pos, compute_display_string_end):
10208 Declare prototypes.
fec2107c
EZ
10209 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10210 EMACS_INT.
fc6f18ce 10211
40087514 102122011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10213
57f53182
PE
10214 Malloc failure behavior now depends on size of allocation.
10215 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10216 * lisp.h: Change signatures accordingly.
10217 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10218 All callers changed. (Bug#8762)
10219
10220 * gnutls.c: Use Emacs's memory allocators.
10221 Without this change, the gnutls library would invoke malloc etc.
10222 directly, which causes problems on non-SYNC_INPUT hosts, and which
10223 runs afoul of improving memory_full behavior. (Bug#8761)
10224 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10225 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10226 xfree instead of the default malloc, realloc, free.
10227 (Fgnutls_boot): No need to check for memory allocation failure,
10228 since xmalloc does that for us.
10229
ac32cd99 10230 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10231 * category.c (hash_get_category_set):
10232 * ccl.c (ccl_driver):
10233 * charset.c (Fdefine_charset_internal):
10234 * charset.h (struct charset.hash_index):
10235 * composite.c (get_composition_id, gstring_lookup_cache)
10236 (composition_gstring_put_cache):
10237 * composite.h (struct composition.hash_index):
10238 * dispextern.h (struct image.hash):
10239 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10240 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10241 (hashfn_equal, hashfn_user_defined, make_hash_table)
10242 (maybe_resize_hash_table, hash_lookup, hash_put)
10243 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10244 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10245 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10246 * image.c (make_image, search_image_cache, lookup_image)
10247 (xpm_put_color_table_h):
10248 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10249 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10250 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10251 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10252 * alloc.c (allocate_vectorlike):
10253 Check for overflow in vector size calculations.
10254 * ccl.c (ccl_driver):
10255 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10256 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10257 need to be updated by these changes.
40087514
PE
10258 * fns.c (make_hash_table, maybe_resize_hash_table):
10259 Check for integer overflow with large hash tables.
0de4bb68
PE
10260 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10261 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10262 (SXHASH_REDUCE): New macro.
10263 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10264 Use it instead of discarding useful hash info with large hash values.
10265 (sxhash_float): New function.
10266 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10267 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10268 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10269 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10270 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10271 Adjust signatures to match updated version of code.
10272 (consing_since_gc): Now EMACS_INT, since a single hash table can
10273 use more than INT_MAX bytes.
10274
698d32e2
DN
102752011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10276
10277 Make it possible to build with GCC-4.6+ -O2 -flto.
10278
10279 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10280
fd6fa53f
SM
102812011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10282
10283 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10284 Call minibuffer-inactive-mode.
10285
864db017
JB
102862011-05-31 Juanma Barranquero <lekktu@gmail.com>
10287
10288 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10289 Update dependencies.
10290
2ad0baf4
DN
102912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10292
10293 * data.c (init_data): Remove code for UTS, this system is not
10294 supported anymore.
10295
4fcc2638
DN
102962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10297
10298 Don't force ./temacs to start in terminal mode.
10299
10300 * frame.c (make_initial_frame): Initialize faces in all cases, not
10301 only when CANNOT_DUMP is defined.
10302 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10303
c56e0fd5
DN
103042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10305
10306 * dispnew.c (add_window_display_history): Use const for the string
10307 pointer. Remove declaration, not needed.
10308
333d54da 103092011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10310
55d4c1b2 10311 Use 'inline', not 'INLINE'.
333d54da 10312 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10313 * alloc.c, fontset.c (INLINE): Remove.
10314 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10315 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10316 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10317 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10318 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10319
738db178
DN
103202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10321
10322 Make it possible to run ./temacs.
10323
10324 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10325 syms_of_callproc does the same thing. Remove test for
10326 "initialized", do it in the caller.
10327 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10328
620c53a6
SM
103292011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10330
10331 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10332 (read_minibuf): Use get_minibuffer.
10333 (syms_of_minibuf): Use DEFSYM.
10334 (Qmetadata): New var.
10335 * data.c (Qbuffer): Don't make it static.
10336 (syms_of_data): Use DEFSYM.
10337
e003a292
PE
103382011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10339
10340 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10341 (CCL_CODE_MIN): New macro.
10342
ed008a6d
PE
103432011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10344
3687c2ef
PE
10345 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10346
ed008a6d
PE
10347 * eval.c (Qdebug): Now static.
10348 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10349 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10350 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10351
d66c4c7c
CY
103522011-05-29 Chong Yidong <cyd@stupidchicken.com>
10353
10354 * image.c: Various fixes to ImageMagick code comments.
10355 (Fimagemagick_types): Doc fix.
10356
5fbc2025
PE
103572011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10358
0196f88a
PE
10359 Minor fixes prompted by GCC 4.6.0 warnings.
10360
10361 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10362
5fbc2025
PE
10363 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10364 (x_clipboard_manager_save_all): Move extern decl to ...
10365 * xterm.h: ... here, so that it can be checked for consistency.
10366
1dd3c2d9
CY
103672011-05-29 Chong Yidong <cyd@stupidchicken.com>
10368
10369 * xselect.c (x_clipboard_manager_save_frame)
10370 (x_clipboard_manager_save_all): New functions.
10371 (Fx_clipboard_manager_save): Lisp function deleted.
10372
10373 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10374 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10375
10376 * xterm.h: Update prototype.
10377
5ba6571d
WX
103782011-05-28 William Xu <william.xwl@gmail.com>
10379
10380 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10381 exiting (Bug#8239).
10382
3eaff834
JM
103832011-05-28 Jim Meyering <meyering@redhat.com>
10384
e1900994 10385 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10386 * fns.c (to_uchar): Define.
10387 (crypto_hash_function): Use it to convert some newly-signed
10388 variables to unsigned, to avoid sign-extension bugs. For example,
10389 without this change, (md5 "truc") would evaluate to
10390 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10391 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10392 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10393
0f6990a7
PE
103942011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10395
10396 Integer overflow fixes.
c8a9ca5a 10397
08686060
PE
10398 * dbusbind.c: Serial number integer overflow fixes.
10399 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10400 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10401 to hold a serial number that is too large for a fixnum.
10402 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10403 Check for serial numbers out of range. Decode any serial number
59568bf0 10404 that was so large that it became a float. (Bug#8722)
08686060 10405
2d1fc3c7
PE
10406 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10407 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10408 Use XFASTINT rather than XUINT when numbers are nonnegative.
10409 (xd_append_arg, Fdbus_method_return_internal):
10410 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10411 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10412 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10413 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10414 (Bug#8722)
2d1fc3c7 10415
c8a9ca5a
PE
10416 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10417
519e1d69
PE
10418 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10419
6df6ae42 10420 ccl: Add integer overflow checks.
30569699
PE
10421 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10422 (IN_INT_RANGE): New macros.
10423 (ccl_driver): Use them to check for integer overflow when
10424 decoding a CCL program. Many of the new checks are whether XINT (x)
10425 fits in int; it doesn't always, on 64-bit hosts. The new version
10426 doesn't catch all possible integer overflows, but it's an
847044ea 10427 improvement. (Bug#8719)
30569699 10428
c11285dc
PE
10429 * alloc.c (make_event_array): Use XINT, not XUINT.
10430 There's no need for unsigned here.
10431
fdccd48e
PE
10432 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10433 This follows up to the 2011-05-06 change that substituted uintptr_t
10434 for EMACS_INT. This case wasn't caught back then.
10435
37910ab2
PE
10436 Rework Fformat to avoid integer overflow issues.
10437 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10438 now (part of C89). Include <verify.h>.
10439 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10440 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10441 (Fformat): Avoid the prepass trying to compute sizes; it was only
10442 approximate and thus did not catch overflow reliably. Instead, walk
10443 through the format just once, formatting and computing sizes as we go,
10444 checking for integer overflow at every step, and allocating a larger
10445 buffer as needed. Keep track separately whether the format is
10446 multibyte. Keep only the most-recently calculated precision, rather
10447 than them all. Record whether each argument has been converted to
10448 string. Use EMACS_INT, not int, for byte and char and arg counts.
10449 Support field widths and precisions larger than INT_MAX. Avoid
10450 sprintf's undefined behavior with conversion specifications such as %#d
10451 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10452 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10453 formatting out-of-range floating point numbers with int
9173deec 10454 formats. (Bug#8668)
37910ab2 10455
2e6578fb
PE
10456 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10457
0ae6bdee
PE
10458 * data.c: Avoid integer truncation in expressions involving floats.
10459 * data.c: Include <intprops.h>.
10460 (arith_driver): When there's an integer overflow in an expression
10461 involving floating point, convert the integers to floating point
10462 so that the resulting value does not suffer from catastrophic
10463 integer truncation. For example, on a 64-bit host (* 4
10464 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10465 Do not rely on undefined behavior after integer overflow.
10466
de883a70
PE
10467 merge count_size_as_multibyte, parse_str_to_multibyte
10468 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10469 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10470 Check for integer overflow.
10471 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10472 since it's now a duplicate of the other. This is more of
10473 a character than a buffer op, so better that it's in character.c.
10474 * fns.c, print.c: Adjust to above changes.
10475
2ff916cb
PE
104762011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10477
10478 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10479
f1b54466
PE
104802011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10481
fb1ac845
PE
10482 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10483 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10484 (x_clipboard_manager_save): Now static.
10485 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10486
f1b54466
PE
10487 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10488 (crypto_hash_function): Now static.
10489 Fix pointer signedness problems. Avoid unnecessary initializations.
10490
a9f737ee
CY
104912011-05-27 Chong Yidong <cyd@stupidchicken.com>
10492
10493 * termhooks.h (Vselection_alist): Make it terminal-local.
10494
10495 * terminal.c (create_terminal): Initialize it.
10496
10497 * xselect.c: Support for clipboard managers.
10498 (Vselection_alist): Move to termhooks.h as terminal-local var.
10499 (LOCAL_SELECTION): New macro.
10500 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10501 (symbol_to_x_atom): Remove gratuitous arg.
10502 (x_handle_selection_request, lisp_data_to_selection_data)
10503 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10504 (x_own_selection, x_get_local_selection, x_convert_selection):
10505 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10506 (some_frame_on_display): Delete unused function.
10507 (Fx_own_selection_internal, Fx_get_selection_internal)
10508 (Fx_disown_selection_internal, Fx_selection_owner_p)
10509 (Fx_selection_exists_p): New optional frame arg.
10510 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10511 (x_handle_selection_clear): Don't treat other terminals with the
10512 same keyboard specially. Use the terminal-local Vselection_alist.
10513 (x_clear_frame_selections): Use Frun_hook_with_args.
10514
10515 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10516
10517 * xterm.h: Add support for those atoms.
10518
e067f0c1
CY
105192011-05-26 Chong Yidong <cyd@stupidchicken.com>
10520
10521 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10522 (converted_selections, conversion_fail_tag): New global variables.
10523 (x_selection_request_lisp_error): Free the above.
10524 (x_get_local_selection): Remove unnecessary code.
10525 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10526 of converted selections stored in converted_selections.
10527 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10528 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10529 (x_convert_selection): New function.
10530 (x_handle_selection_event): Simplify.
10531 (x_get_foreign_selection): Don't ignore incoming requests while
10532 waiting for an answer; this will fail when we implement
10533 SAVE_TARGETS, and seems unnecessary anyway.
10534 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10535 (Vx_sent_selection_functions): Doc fix.
10536
0f4aebc0
LL
105372011-05-26 Leo Liu <sdl.web@gmail.com>
10538
10539 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10540
e61124cd
YM
105412011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10542
10543 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10544
10545 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10546 for fringe update if it has periodic bitmap.
ac389d0c 10547 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10548 and fringe_bitmap_periodic_p.
10549
10550 * fringe.c (get_fringe_bitmap_data): New function.
10551 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10552 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10553 row. Mark glyph row for fringe update if periodicity changed.
10554
10555 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10556 for fringe update unless it has periodic bitmap.
10557
f16d9837
KH
105582011-05-25 Kenichi Handa <handa@m17n.org>
10559
10560 * xdisp.c (get_next_display_element): Set correct it->face_id for
10561 a static composition.
10562
e1b90ef6
LL
105632011-05-24 Leo Liu <sdl.web@gmail.com>
10564
10565 * deps.mk (fns.o):
10566 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10567
10568 * fns.c (crypto_hash_function, Fsha1): New function.
10569 (Fmd5): Use crypto_hash_function.
10570 (syms_of_fns): Add Ssha1.
10571
7400048f
PE
105722011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10573
10574 * gnutls.c: Remove unused macros.
10575 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10576 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10577 Remove macros that are defined and never used.
10578 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10579
abb71cf4
CY
105802011-05-22 Chong Yidong <cyd@stupidchicken.com>
10581
10582 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10583 (Fx_get_selection_internal): Minor cleanup.
10584 (Fx_own_selection_internal): Rename arguments for consistency with
10585 select.el.
10586
6307db39
PE
105872011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10588
10589 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10590
f3d4e0a4
CY
105912011-05-22 Chong Yidong <cyd@stupidchicken.com>
10592
10593 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10594
4d8ade89
YM
105952011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10596
10597 * dispnew.c (scrolling_window): Don't exclude the case that the
10598 last enabled row in the desired matrix touches the bottom boundary.
10599
32078c8d
GM
106002011-05-21 Glenn Morris <rgm@gnu.org>
10601
10602 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10603 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10604 and add some more files.
32078c8d 10605
7285dc67
EZ
106062011-05-20 Eli Zaretskii <eliz@gnu.org>
10607
10608 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10609 report_file_error introduced by the change from 2011-05-07.
10610
89d1bd22
PE
106112011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10612
10613 * systime.h (Time): Define only if emacs is defined.
10614 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10615 where the include path doesn't have X11/X.h by default. See
10616 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10617
cd394be1 106182011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10619
10620 * composite.c (find_automatic_composition): Fix previous change.
10621
b9704ad9
GM
106222011-05-20 Glenn Morris <rgm@gnu.org>
10623
10624 * lisp.mk: New file, split from Makefile.in.
10625 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10626 (shortlisp): Remove.
10627 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10628
4a720484
GM
106292011-05-19 Glenn Morris <rgm@gnu.org>
10630
10631 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10632 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10633 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10634 (lisp): Set the order to that of loadup.el.
10635 (shortlisp): Make it a copy of $lisp.
10636 (SOME_MACHINE_LISP): Remove.
10637 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10638 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10639
a28d4396
KH
106402011-05-18 Kenichi Handa <handa@m17n.org>
10641
10642 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10643 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10644 (find_automatic_composition): Mostly rewrite for efficiency.
10645
a2b1fa8e
JB
106462011-05-18 Juanma Barranquero <lekktu@gmail.com>
10647
10648 * makefile.w32-in: Update dependencies.
10649
8e1f5610
CS
106502011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10651
10652 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10653 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10654
7025ee00 106552011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10656
cdfa6eab
PE
10657 Fix some integer overflow issues, such as string length overflow.
10658
06d6db33
PE
10659 * insdel.c (count_size_as_multibyte): Check for string overflow.
10660
2b4560a8
PE
10661 * character.c (lisp_string_width): Check for string overflow.
10662 Use EMACS_INT, not int, for string indexes and lengths; in
10663 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10664 the resulting string length overflows an EMACS_INT; instead,
10665 report a string overflow if no precision given. When checking for
10666 precision exhaustion, use a check that cannot possibly have
10667 integer overflow. (Bug#8675)
10668 * character.h (lisp_string_width): Adjust to new signature.
10669
cb93f9be
PE
10670 * alloc.c (string_overflow): New function.
10671 (Fmake_string): Use it. This doesn't change behavior, but saves
10672 a few bytes and will simplify future changes.
10673 * character.c (string_escape_byte8): Likewise.
10674 * lisp.h (string_overflow): New decl.
10675
1a1f3366
PE
10676 Fixups, following up to the user-interface timestamp change.
10677 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10678 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10679 * msdos.c (mouse_get_pos): Likewise.
10680 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10681 * w32gui.h (Time): Define by including "systime.h" rather than by
10682 declaring it ourselves. (Bug#8664)
10683
d4e3e4d3
PE
10684 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10685 * image.c (clear_image_cache): Likewise.
10686
f6a24d19
PE
10687 * term.c (term_mouse_position): Don't assume time_t wraparound.
10688
08dc5ae6
PE
10689 Be more systematic about user-interface timestamps.
10690 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10691 and sometimes 'EMACS_UINT', to represent these timestamps.
10692 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10693 This makes the code easier to follow, and makes it easier to catch
10694 integer overflow bugs such as Bug#8664.
10695 * frame.c (Fmouse_position, Fmouse_pixel_position):
10696 Use Time, not unsigned long, for user-interface timestamps.
10697 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10698 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10699 * keyboard.h (last_event_timestamp): Likewise.
10700 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10701 * menu.h (xmenu_show): Likewise.
10702 * term.c (term_mouse_position): Likewise.
10703 * termhooks.h (struct input_event.timestamp): Likewise.
10704 (struct terminal.mouse_position_hook): Likewise.
10705 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10706 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10707 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10708 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10709 what it was before.
10710 * menu.h, termhooks.h: Include "systime.h", for Time.
10711
8e55734a
PE
10712 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10713 Don't assume that the difference between two unsigned long values
10714 can fit into an integer. At this point, we know button_down_time
10715 <= event->timestamp, so the difference must be nonnegative, so
10716 there's no need to cast the result if double-click-time is
10717 nonnegative, as it should be; check that it's nonnegative, just in
10718 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10719 apart (about 25 days). (Bug#8664)
8e55734a 10720
841f1b75 10721 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10722 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10723
3e26f69c
PE
10724 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10725 that always fit in int. Use a sentinel instead of a counter, to
10726 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10727 * frame.h (struct frame): Use int for menu_bar_items_used
10728 instead of EMACS_INT, since it always fits in int.
3e26f69c 10729
5cc152c0
PE
10730 * menu.c (grow_menu_items): Check for int overflow.
10731
d89eb65e
PE
10732 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10733
5235bd3e
PE
10734 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10735 Before, the code was not consistent. These values cannot exceed
10736 2**31 - 1 so there's no need to make them unsigned.
10737 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10738 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10739 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10740 as modifiers.
10741 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10742
bc827e23
PE
10743 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10744 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10745 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10746 presumably because the widths might not match.
10747
78eb494e
PE
10748 * window.c (size_window): Avoid needless test at loop start.
10749
04f2d78b
CB
107502011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10751
10752 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10753
d2fc7e3d 107542011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10755
10756 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10757
d2fc7e3d 107582011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10759
10760 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10761 `width' to `bar_area_x' and `bar_area_width', respectively.
10762 (x_scroll_run): Take account of fringe background extension.
10763
04f2d78b
CB
10764 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10765 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10766 `bar_area_width', respectively.
10767 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10768 background extension.
10769
79b70037
GM
107702011-05-10 Jim Meyering <meyering@redhat.com>
10771
10772 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10773
2f142cc5
JB
107742011-05-10 Juanma Barranquero <lekktu@gmail.com>
10775
10776 * image.c (Finit_image_library): Return t for built-in image types,
10777 like pbm and xbm. (Bug#8640)
10778
57679c86
AS
107792011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10780
10781 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10782
888c9e86
EZ
107832011-05-07 Eli Zaretskii <eliz@gnu.org>
10784
b0512a1d
EZ
10785 * w32console.c (Fset_screen_color): Doc fix.
10786 (Fget_screen_color): New function.
10787 (syms_of_ntterm): Defsubr it.
10788
7285dc67
EZ
10789 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10790 unlink the temporary file if Fcall_process didn't create it in the
10791 first place.
10792 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10793 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10794 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10795 cue to call_process_cleanup not to close that handle.
10796
4d3fcc8e
BK
107972011-05-07 Ben Key <bkey76@gmail.com>
10798
10799 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10800 one of two shell specific rules, either bootstrap-temacs-CMD or
10801 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10802 to the previous implementation of the bootstrap-temacs rule.
10803 The bootstrap-temacs-CMD rule is similar to the previous
10804 implementation of the bootstrap-temacs rule except that it
10805 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10806 variable.
10807
10808 These changes, along with some changes to nt/configure.bat,
10809 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10810 earlier fix to add support for --cflags and --ldflags options
10811 that include quotes so that it works whether make uses cmd or
10812 sh as the shell.
10813
b4289b64
MA
108142011-05-06 Michael Albinus <michael.albinus@gmx.de>
10815
10816 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10817 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10818 is a constant.
10819 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10820 a string. Handle both cases.
10821 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10822 (Fdbus_register_method): Use Qinvalid_function.
10823
af4c0e28
JB
108242011-05-06 Juanma Barranquero <lekktu@gmail.com>
10825
10826 * makefile.w32-in: Update dependencies.
10827 (LISP_H): Add inttypes.h and stdin.h.
10828 (PROCESS_H): Add unistd.h.
10829
c51453d9
EZ
108302011-05-06 Eli Zaretskii <eliz@gnu.org>
10831
10832 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10833 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10834
8ff0ac3c 108352011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10836
4c4b566b
PE
10837 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10838
aab2b9b5
PE
10839 * term.c (vfatal): Remove stray call to va_end.
10840 It's not needed and the C Standard doesn't allow it here anyway.
10841
c378da0b
PE
10842 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10843 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10844
288b08c7
PE
10845 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10846 bytes.
10847
e3601888
PE
10848 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10849
db6c0e74
PE
10850 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10851
dd5963ea
PE
10852 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10853
88c9450f
PE
10854 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10855
2f9442b8
PE
10856 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10857
c032b5f8
PE
10858 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10859 * charset.c (Fdefine_charset_internal): Don't initialize
10860 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10861 32-bit int (Bug#8600).
a108c10b
PE
10862
10863 * lread.c (read_integer): Be more consistent with string-to-number.
10864 Use string_to_number to do the actual conversion; this avoids
10865 rounding errors and fixes some other screwups. Without this fix,
10866 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10867 (digit_to_number): Move earlier, for benefit of read_integer.
10868 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10869 not a digit in any supported base. (Bug#8602)
a108c10b 10870
ad5f9eea
PE
10871 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10872
aec1708a
PE
10873 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10874 to match comment at start of function. This also removes a
10875 GCC warning about overflow in a 32+64-bit port.
10876
47be4ab5
PE
10877 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10878
371cac43
PE
10879 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10880 Reported by Stefan Monnier in
10881 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10882 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10883 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10884
d01a7826
PE
10885 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10886 (EMACS_UINTPTR): Likewise, with uintptr_t.
10887
7fd47d5c
PE
10888 * lisp.h: Prefer 64-bit EMACS_INT if available.
10889 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10890 on 32-bit hosts that have 64-bit int, so that they can access
10891 large files.
122b0c86
PE
10892 However, temporarily disable this change unless the temporary
10893 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10894
8727937b
PE
10895 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10896
8ac068ac
PE
10897 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10898 This removes an assumption that EMACS_INT and long are the same
10899 width as pointers. The assumption is true for Emacs porting targets
10900 now, but we want to make other targets possible.
10901 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10902 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10903 In the rest of the code, change types of integers that hold casted
10904 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10905 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10906 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10907 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10908 No need to cast type when ORing.
10909 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10910 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10911 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10912 assume EMACS_INT is the same width as char *.
10913 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10914 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10915 Remove no-longer-needed casts.
10916 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10917 (xg_tool_bar_help_callback, xg_make_tool_item):
10918 Use EMACS_INTPTR to hold an integer
10919 that will be cast to void *; this can avoid a GCC warning
10920 if EMACS_INT is not the same width as void *.
10921 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10922 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10923 (current_message_1, set_message_1):
10924 Use a local to convert to proper width without a cast.
10925 * xmenu.c (dialog_selection_callback): Likewise.
10926
ede49d71
PE
10927 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10928 Also, don't assume VALBITS / RAND_BITS is less than 5,
10929 and don't rely on undefined behavior when shifting a 1 left into
10930 the sign bit.
10931 * lisp.h (get_random): Change signature to match.
10932
2f30ecd0
PE
10933 * lread.c (hash_string): Use size_t, not int, for hash computation.
10934 Normally we prefer signed values; but hashing is special, because
10935 it's better to use unsigned division on hash table sizes so that
10936 the remainder is nonnegative. Also, size_t is the natural width
10937 for hashing into memory. The previous code used 'int', which doesn't
10938 retain enough info to hash well into very large tables.
10939 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10940
2a866e7b
PE
10941 * dbusbind.c: Don't possibly lose pointer info when converting.
10942 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10943 Use XPNTR rather than XHASH, so that the high-order bits of
10944 the pointer aren't lost when converting through void *.
10945
51639eac
PE
10946 * eval.c (Fautoload): Don't double-shift a pointer.
10947
92394119
PE
10948 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10949
dbdb9a7c
JB
109502011-05-06 Juanma Barranquero <lekktu@gmail.com>
10951
10952 * gnutls.c (DEF_GNUTLS_FN):
10953 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10954
db7a0b4f
AS
109552011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10956
10957 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10958 marker. (Bug#8610)
10959
cd394be1 109602011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10961
10962 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10963 New version that can reserve upto 2GB of heap space.
10964
f7ff1b0f 109652011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10966
10967 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10968
639c109b
TZ
109692011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10970
10971 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10972 `gnutls_certificate_set_x509_key_file'.
10973
d2127135
JB
109742011-05-05 Juanma Barranquero <lekktu@gmail.com>
10975
10976 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10977 Update dependencies.
10978
e968f4f3
JB
109792011-05-04 Juanma Barranquero <lekktu@gmail.com>
10980
10981 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10982 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10983 Remove unused parameter `fildes'.
10984 * process.c (read_process_output, send_process): Don't pass it.
10985
84d358f0
JB
109862011-05-04 Juanma Barranquero <lekktu@gmail.com>
10987
10988 Fix previous change: the library cache is defined in w32.c.
10989 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10990 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10991
0898ca10
JB
109922011-05-04 Juanma Barranquero <lekktu@gmail.com>
10993
10994 Implement dynamic loading of GnuTLS on Windows.
10995
10996 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10997 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10998 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10999 Declare.
11000
11001 * gnutls.c (Qgnutls_dll): Define.
11002 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11003 (gnutls_*): Declare function pointers.
11004 (init_gnutls_functions): New function to initialize function pointers.
11005 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11006 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11007 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11008 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11009 (emacs_gnutls_write, emacs_gnutls_read)
11010 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11011 (Fgnutls_available_p): New function.
11012 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11013 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11014 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11015
11016 * image.c: Include w32.h.
11017 (Vimage_type_cache): Delete.
11018 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11019 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11020 (w32_delayed_load): Move to w32.c.
11021
11022 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11023
11024 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11025 (w32_delayed_load): Move from image.c. When loading a library, record
11026 its filename in the :loaded-from property of the library id.
11027 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11028 Initialize and staticpro them.
11029 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11030
11031 * process.c: Include lisp.h before w32.h, not after.
11032 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11033 instead of gnutls_record_check_pending.
11034
11035 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11036
ff4de4aa
TZ
110372011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11038
11039 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11040 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11041 as passed in.
11042
abe95abb
JD
110432011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11044
11045 * xterm.c (x_set_frame_alpha): Do not set property on anything
11046 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11047
e16e55d4
JB
110482011-05-02 Juanma Barranquero <lekktu@gmail.com>
11049
11050 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11051
bafcf6a5
JB
110522011-05-02 Juanma Barranquero <lekktu@gmail.com>
11053
11054 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11055 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11056 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11057 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11058 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11059 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11060 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11061 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11062 (Qgnutls_bootprop_callbacks_verify): Make static.
11063
e7a6747f
AS
110642011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11065
19ed11ba
AS
11066 * callproc.c: Indentation fixup.
11067
e7a6747f 11068 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11069 (wait_for_termination, interruptible_wait_for_termination):
11070 Move after wait_for_termination_1.
e7a6747f 11071
1ef14cb4
LMI
110722011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11073
11074 * sysdep.c (interruptible_wait_for_termination): New function
11075 which is like wait_for_termination, but allows keyboard
11076 interruptions.
11077
11078 * callproc.c (Fcall_process): Add (:file "file") as an option for
11079 the STDOUT buffer.
11080 (Fcall_process_region): Ditto.
11081
330d880c
EZ
110822011-04-30 Eli Zaretskii <eliz@gnu.org>
11083
8db90b73
EZ
11084 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11085 rather than `XVECTOR (FOO)->size'.
11086
330d880c
EZ
11087 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11088 inttypes.h, as a gnulib replacement is used if it not available in
11089 system headers.
11090
15cbd324
EZ
110912011-04-21 Eli Zaretskii <eliz@gnu.org>
11092
11093 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11094 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11095 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11096
11097 * coding.c (coding_alloc_by_realloc): Error out if destination
11098 will grow beyond MOST_POSITIVE_FIXNUM.
11099 (decode_coding_emacs_mule): Abort if there isn't enough place in
11100 charbuf for the composition carryover bytes. Reserve an extra
11101 space for up to 2 characters produced in a loop.
11102 (decode_coding_iso_2022): Abort if there isn't enough place in
11103 charbuf for the composition carryover bytes.
11104
111052011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11106
ae940cca
EZ
11107 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11108 aborting when %lld or %lll format is passed.
11109 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11110 %llo or %llx format is passed. (Bug#8545)
11111
03ab8921
EZ
11112 * window.c (window_scroll_line_based): Use a marker instead of
11113 simple variables to record original value of point. (Bug#7952)
11114
afda1437
EZ
11115 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11116 produced by %s or %c overflows available buffer space. (Bug#8545)
11117
f76dee0c
PE
111182011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11119
11120 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11121 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11122
fdc5744d
JB
111232011-04-28 Juanma Barranquero <lekktu@gmail.com>
11124
11125 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11126
638f053a
JB
111272011-04-28 Juanma Barranquero <lekktu@gmail.com>
11128
11129 * keyboard.c (Qdelayed_warnings_hook): Define.
11130 (command_loop_1): Run `delayed-warnings-hook'
11131 if Vdelayed_warnings_list is non-nil.
11132 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11133 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11134
d178f871
EZ
111352011-04-28 Eli Zaretskii <eliz@gnu.org>
11136
11137 * doprnt.c (doprnt): Don't return value smaller than the buffer
11138 size if the message was truncated. (Bug#8545).
11139
b124fd93
JB
111402011-04-28 Juanma Barranquero <lekktu@gmail.com>
11141
11142 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11143 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11144
e810457d
PE
111452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11146
11147 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11148
ea51cceb
JB
111492011-04-27 Juanma Barranquero <lekktu@gmail.com>
11150
11151 * makefile.w32-in: Update dependencies.
11152
94dcfacf
EZ
111532011-04-27 Eli Zaretskii <eliz@gnu.org>
11154
11155 Improve `doprnt' and its usage. (Bug#8545)
11156 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11157 `format_end'. Remove support for %l as a conversion specifier.
11158 Don't use xrealloc. Improve diagnostics when the %l size modifier
11159 is used. Update the commentary.
11160
11161 * eval.c (verror): Simplify calculation of size_t.
11162
11163 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11164 messages.
11165
f61f41d7
PE
111662011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11167
11168 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11169 change.
11170
96fb4434
PE
111712011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11172
11173 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11174 This makes this file independent of the recent pseudovector change.
11175
671875da 111762011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11177
69e9b5a3
PE
11178 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11179
b5f869a7 11180 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11181 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11182 Remove unused local.
c8926152 11183 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11184
841a1577 11185 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11186 GCC 4.6.0 optimizes based on type-based alias analysis.
11187 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11188 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11189 != &v->size, and therefore "v->size = 1; b->size = 2; return
11190 v->size;" must therefore return 1. This assumption is incorrect
11191 for Emacs, since it type-puns struct Lisp_Vector * with many other
11192 types. To fix this problem, this patch adds a new type struct
f904488f 11193 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11194 and pseudovectors, and helps optimizing compilers not get fooled
11195 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11196 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11197 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11198 the size member.
eab3844f
PE
11199 (XSETPVECTYPE): Rewrite in terms of new macro.
11200 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11201 This is a bit clearer, and further avoids the possibility of
11202 undesirable aliasing.
11203 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11204 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11205 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11206 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11207 (ASIZE): Now uses header.size rather than size.
11208 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11209 to avoid the hassle of writing XVECTOR (foo)->header.size.
11210 (struct vectorlike_header): New type.
eab3844f
PE
11211 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11212 object, to help avoid aliasing.
11213 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11214 (SUBRP): Likewise, since Lisp_Subr is a special case.
11215 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11216 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11217 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11218 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11219 changed to be "header.size" and "header.next".
11220 * buffer.h (struct buffer): Likewise.
11221 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11222 * frame.h (struct frame): Likewise.
11223 * process.h (struct Lisp_Process): Likewise.
11224 * termhooks.h (struct terminal): Likewise.
11225 * window.c (struct save_window_data, struct saved_window): Likewise.
11226 * window.h (struct window): Likewise.
11227 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11228 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11229 * buffer.c (init_buffer_once): Likewise.
11230 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11231 special case.
11232 * process.c (Fformat_network_address): Use local var for size,
11233 for brevity.
11234
0df1eac5
PE
11235 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11236
847ab9d1 11237 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11238 * data.c (atof): Remove decl; no longer used or needed.
11239 (digit_to_number): Move to lread.c.
11240 (Fstring_to_number): Use new string_to_number function, to be
11241 consistent with how the Lisp reader treats infinities and NaNs.
11242 Do not assume that floating-point numbers represent EMACS_INT
11243 without losing information; this is not true on most 64-bit hosts.
11244 Avoid double-rounding errors, by insisting on integers when
11245 parsing non-base-10 numbers, as the documentation specifies.
11246 * lisp.h (string_to_number): New decl, replacing ...
11247 (isfloat_string): Remove.
bc0a5c13 11248 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11249 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11250 appears to have been a coding error. Similarly, do not accept
11251 strings like +-1e0 as floating point numbers. Do not report
11252 overflow for integer overflows unless the base is not 10 which
11253 means we have no simple and reliable way to continue.
11254 Break out the floating-point parsing into a new
11255 function string_to_number, so that Fstring_to_number parses
11256 floating point numbers consistently with the Lisp reader.
04f2d78b 11257 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11258 (E_CHAR, EXP_INT): Remove, replacing with ...
11259 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11260 (string_to_number): New function, replacing isfloat_string.
11261 This function checks for valid syntax and produces the resulting
11262 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11263 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11264 so that overflow for non-base-10 numbers is reported only when
11265 there's no portable and simple way to convert to floating point.
452f4150 11266
67769ffc
PE
11267 * textprop.c (set_text_properties_1): Rewrite for clarity,
11268 and to avoid GCC warning about integer overflow.
11269
c20db43f
PE
11270 * intervals.h (struct interval): Use EMACS_INT for members
11271 where EMACS_UINT might cause problems. See
11272 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11273 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11274 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11275 All uses changed.
37aa2f85
PE
11276 (offset_intervals): Tell GCC not to worry about length overflow
11277 when negating a negative length.
c20db43f 11278
2538aa2f
PE
11279 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11280 (overrun_check_free): Likewise.
11281
f2d3008d
PE
11282 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11283 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11284 word size.
11285
ec8df744
PE
11286 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11287 (gnutls_make_error): Rename local to avoid shadowing.
11288 (gnutls_emacs_global_deinit): ifdef out; not used.
11289 (Fgnutls_boot): Use const for pointer to readonly storage.
11290 Comment out unused local. Fix pointer signedness problems.
11291
640ee02d
PE
11292 * lread.c (openp): Don't stuff size_t into an 'int'.
11293 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11294 about possible signed overflow.
11295
6048fb2a
PE
11296 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11297 (GDK_KEY_g): Don't define if already defined.
11298 (xg_prepare_tooltip): Avoid pointer signedness problem.
11299 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11300
fa3c87e1
PE
11301 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11302 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11303
2172544b
PE
11304 * xfns.c (Fx_window_property): Simplify a bit,
11305 to make a bit faster and to avoid GCC 4.6.0 warning.
11306 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11307
9b821a21
PE
11308 * fns.c (internal_equal): Don't assume size_t fits in int.
11309
3c616cfa
PE
11310 * alloc.c (compact_small_strings): Tighten assertion a little.
11311
c2982e87
PE
11312 Replace pEd with more-general pI, and fix some printf arg casts.
11313 * lisp.h (pI): New macro, generalizing old pEd macro to other
11314 conversion specifiers. For example, use "...%"pI"d..." rather
11315 than "...%"pEd"...".
11316 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11317 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11318 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11319 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11320 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11321 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11322 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11323 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11324 64-bit hosts.
11325 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11326 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11327 * print.c (safe_debug_print, print_object): Likewise.
11328 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11329 to int.
6f04d126
PE
11330 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11331 avoiding the 0 flag, which is not portable.
c2982e87
PE
11332 * process.c (Fmake_network_process): Use pI to avoid cast.
11333 * region-cache.c (pp_cache): Likewise.
11334 * xdisp.c (decode_mode_spec): Likewise.
11335 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11336 behavior on 64-bit hosts with printf arg.
6f04d126 11337 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11338 (x_stop_queuing_selection_requests): Likewise.
11339 (x_get_window_property): Don't truncate byte count to an 'int'
11340 when tracing.
0b432f21 11341
5e073ec7
PE
11342 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11343 here, since it parses constructs like leading '-' and spaces,
11344 which are not wanted; and it overflows with large numbers.
11345 Instead, simply match F[0-9]+, which is what is wanted anyway.
11346
36372bf9
PE
11347 * alloc.c: Remove unportable assumptions about struct layout.
11348 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11349 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11350 (allocate_vectorlike, make_pure_vector): Use the new macros,
11351 plus offsetof, to remove unportable assumptions about struct layout.
11352 These assumptions hold on all porting targets that I know of, but
11353 they are not guaranteed, they're easy to remove, and removing them
11354 makes further changes easier.
11355
0b432f21
PE
11356 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11357 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11358 (string_overrun_cookie): Now const. Use initializers that
11359 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11360 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11361 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11362 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11363 multiple of sizeof (EMACS_INT); it need not be, if
11364 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11365 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11366
895009e1
JB
113672011-04-26 Juanma Barranquero <lekktu@gmail.com>
11368
11369 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11370
6a7a1b0b
TZ
113712011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11372
11373 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11374 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11375 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11376
841a1577 113772011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11378
11379 * lisp.h (Qdebug): List symbol.
895009e1 11380 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11381 * keyboard.c (debug-on-event): New variable.
11382 (handle_user_signal): Break into debugger when debug-on-event
11383 matches the current signal symbol.
11384
f2d3ba6f
DN
113852011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11386
11387 * alloc.c (check_sblock, check_string_bytes)
11388 (check_string_free_list): Convert to standard C.
11389
42ce4c63
TZ
113902011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11391
11392 * w32.c (emacs_gnutls_push): Fix typo.
11393
825cd63c
EZ
113942011-04-25 Eli Zaretskii <eliz@gnu.org>
11395
fb11d64d
EZ
11396 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11397 "cast to pointer from integer of different size".
11398
825cd63c
EZ
11399 Improve doprnt and its use in verror. (Bug#8545)
11400 * doprnt.c (doprnt): Document the set of format control sequences
11401 supported by the function. Use SAFE_ALLOCA instead of always
11402 using `alloca'.
11403
11404 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11405 is one byte too soon. Don't use xrealloc; instead xfree and
11406 xmalloc anew.
11407
e061a11b
TZ
114082011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11409
11410 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11411 callbacks stage.
11412
11413 * gnutls.c: Renamed global_initialized to
11414 gnutls_global_initialized. Added internals for the
11415 :verify-hostname-error, :verify-error, and :verify-flags
11416 parameters of `gnutls-boot' and documented those parameters in the
11417 docstring. Start callback support.
9173deec
JB
11418 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11419 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11420 on error. Return error code.
e061a11b
TZ
11421 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11422 (emacs_gnutls_read): Likewise.
11423 (Fgnutls_boot): Return handshake error code.
11424 (emacs_gnutls_handle_error): New function.
11425 (wsaerror_to_errno): Likewise.
11426
11427 * w32.h (emacs_gnutls_pull): Add prototype.
11428 (emacs_gnutls_push): Likewise.
11429
11430 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11431 (emacs_gnutls_push): Likewise.
11432
114332011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11434
11435 * process.c (wait_reading_process_output): Check if GnuTLS
11436 buffered some data internally if no FDs are set for TLS
11437 connections.
11438
11439 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11440 (LIBS): Link to USER_LIBS.
11441 ($(BLD)/gnutls.$(0)): New target.
11442
fa6996bc
EZ
114432011-04-24 Eli Zaretskii <eliz@gnu.org>
11444
eb35682e
EZ
11445 * xdisp.c (handle_single_display_spec): Rename the
11446 display_replaced_before_p argument into display_replaced_p, to
11447 make it consistent with the commentary. Fix typos in the
11448 commentary.
11449
e2ad650c
EZ
11450 * textprop.c (syms_of_textprop): Remove dead code.
11451 (copy_text_properties): Delete obsolete commentary about an
11452 interface that was deleted long ago. Fix typos in the description
11453 of arguments.
11454
1b2de274
EZ
11455 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11456 to changes in oldXMenu/XMenu.h from 2011-04-16.
11457 <menu_help_message, prev_menu_help_message>: Constify.
11458 (IT_menu_make_room): menu->help_text is now `const char **';
11459 adjust.
11460
11461 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11462 to changes in oldXMenu/XMenu.h from 2011-04-16.
11463 (struct XMenu): Declare `help_text' `const char **'.
11464
11465 * xfaces.c <Qunspecified>: Make extern again.
11466
11467 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11468 required by POSIX.
1b2de274 11469
762b15be
EZ
11470 * doc.c (get_doc_string): Improve the format passed to `error'.
11471
11472 * doprnt.c (doprnt): Improve commentary.
11473
11474 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11475
11476 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11477 them with etags.
11478
f1052e5d
EZ
11479 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11480 changes in globals.h immediately force recompilation.
762b15be
EZ
11481 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11482 $(CURDIR)/s/ms-w32.h.
11483 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11484
fa6996bc
EZ
11485 * character.c (Fchar_direction): Function deleted.
11486 (syms_of_character): Don't defsubr it.
11487 <char-direction-table>: Deleted.
11488
e6c3da20
EZ
114892011-04-23 Eli Zaretskii <eliz@gnu.org>
11490
11491 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11492 * doprnt.c: Include limits.h.
11493 (SIZE_MAX): New macro.
04f2d78b
CB
11494 (doprnt): Return a size_t value. 2nd arg is now size_t.
11495 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11496 Improve overflow protection. Support `l' modifier for integer
11497 conversions. Support %l conversion. Don't assume an EMACS_INT
11498 argument for integer conversions and for %c.
11499
11500 * lisp.h (doprnt): Restore prototype.
11501
11502 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11503 $(SRC)/character.h.
11504
11505 * Makefile.in (base_obj): Add back doprnt.o.
11506
11507 * deps.mk (doprnt.o): Add back prerequisites.
11508 (callint.o): Depend on character.h.
11509
11510 * eval.c (internal_lisp_condition_case): Include the handler
11511 representation in the error message.
11512 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11513 when breaking from the loop.
11514
11515 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11516
11517 * callint.c (Fcall_interactively): When displaying error message
11518 about invalid control letter, pass the character's codepoint, not
11519 a pointer to its multibyte form. Improve display of the character
11520 in octal and display also its hex code.
11521
11522 * character.c (char_string): Use %x to display the (unsigned)
11523 codepoint of an invalid character, to avoid displaying a bogus
11524 negative value.
11525
11526 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11527 `error', not SYMBOL_NAME itself.
11528
11529 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11530 character arguments to `error'.
11531
11532 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11533 to `error' in error message about FINAL_CHAR argument. Make sure
11534 FINAL_CHAR is a character, and use %c when it is passed as
11535 argument to `error'.
11536
4ffd0d6b 115372011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11538
11539 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11540
11541 * w32.c: Include <time.h>.
11542 (sys_localtime): New function.
11543
4ffd0d6b 115442011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11545
11546 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11547
4ffd0d6b 11548 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11549
4ffd0d6b 115502011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11551
4ffd0d6b
GM
11552 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11553 zombies (Bug#8467).
aac0c6e3 11554
04c56954
EZ
115552011-04-19 Eli Zaretskii <eliz@gnu.org>
11556
11557 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11558 gl_state.e_property when gl_state.object is Qt.
11559
11560 * insdel.c (make_gap_larger): Remove limitation of buffer size
11561 to <= INT_MAX.
11562
16a43933
CY
115632011-04-18 Chong Yidong <cyd@stupidchicken.com>
11564
11565 * xdisp.c (lookup_glyphless_char_display)
11566 (produce_glyphless_glyph): Handle cons cell entry in
11567 glyphless-char-display.
11568 (Vglyphless_char_display): Document it.
11569
11570 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11571 glyphless-char-display.
11572
4581706e
CY
115732011-04-17 Chong Yidong <cyd@stupidchicken.com>
11574
11575 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11576
11577 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11578
11579 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11580 definition for no-X builds.
11581
4887c6e2 115822011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11583
fd35b6f9
PE
11584 Static checks with GCC 4.6.0 and non-default toolkits.
11585
5c1ccb01
PE
11586 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11587
006c5daa
PE
11588 * process.c (keyboard_bit_set): Define only if SIGIO.
11589 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11590 (send_process): Repair possible setjmp clobbering.
11591
efc736d3
PE
11592 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11593
4e2fe2e6
PE
11594 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11595
f97334a2
PE
11596 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11597
4e75f29d
PE
11598 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11599 Define only if needed.
11600
90efadd1
PE
11601 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11602 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11603 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11604
3c647824
PE
11605 * dispextern.h (struct redisplay_interface): Rename param
11606 to avoid shadowing.
e264f262 11607 * termhooks.h (struct terminal): Likewise.
761383f4 11608 * xterm.c (xembed_send_message): Likewise.
3c647824 11609
b58c5c4a
PE
11610 * insdel.c (make_gap_smaller): Define only if
11611 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11612
cad59032
PE
11613 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11614 it.
11615
c339dc2e
PE
11616 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11617 so that we aren't warned about unused symbols.
11618
91a3e27b
PE
11619 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11620
399c71d3 11621 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11622
8ffc96f5
PE
11623 * xfns.c (x_real_positions): Mark locals as initialized.
11624
eef9bc79
PE
11625 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11626
098db9dd
PE
11627 * xterm.c: Fix problems found by static analysis with other toolkits.
11628 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11629 (x_dispatch_event): Declare static if USE_GTK, and
11630 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11631 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11632 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11633 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11634 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11635
eb18f6cc
PE
11636 * xmenu.c (menu_help_callback): Pointer type fixes.
11637 Use const pointers when pointing at readonly data. Avoid pointer
11638 signedness clashes.
11639 (FALSE): Remove unused macro.
11640 (update_frame_menubar): Remove unused decl.
11641
1fe72bf8
PE
11642 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11643
60d9e1db
PE
11644 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11645 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11646 (single_menu_item): Rename local to avoid shadowing.
11647
39261c26
PE
11648 * keyboard.c (make_lispy_event): Remove unused local var.
11649
018c5e19
PE
11650 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11651 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11652
63d2b86e
PE
11653 * bitmaps: Change bitmaps from unsigned char back to the X11
11654 compatible char. Avoid the old compiler warnings about
11655 out-of-range initializers by using, for example, '\xab' rather
11656 than 0xab.
11657
aefd87e1
PE
11658 * xgselect.c (xgselect_initialize): Check vs interface
11659 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11660
bf501fb9
PE
11661 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11662
e9829fdf
PE
11663 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11664 to read-only memory.
11665
1086c095
PE
11666 * fns.c (vector): Remove; this old hack is no longer needed.
11667
2baccd04 11668 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11669 Remove unused var.
dde42981 11670 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11671
72391843 11672 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11673
436c16df 11674 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11675 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11676 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11677
92bb796d 11678 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11679 (x_term_init): Remove local to avoid shadowing.
92bb796d 11680
764430a3 11681 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11682
11683 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11684 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11685
d1dfb56c
EZ
116862011-04-16 Eli Zaretskii <eliz@gnu.org>
11687
c4354cb4
EZ
11688 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11689
d1dfb56c
EZ
11690 Fix regex.c, syntax.c and friends for buffers > 2GB.
11691 * syntax.h (struct gl_state_s): Declare character position members
11692 EMACS_INT.
11693
11694 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11695
04f2d78b
CB
11696 * textprop.c (verify_interval_modification, interval_of):
11697 Declare arguments EMACS_INT.
d1dfb56c
EZ
11698
11699 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11700 EMACS_INT.
11701
11702 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11703
11704 * indent.c (Fvertical_motion): Local variable it_start is now
11705 EMACS_INT.
11706
11707 * regex.c (re_match, re_match_2, re_match_2_internal)
11708 (bcmp_translate, regcomp, regexec, print_double_string)
11709 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11710 (re_compile_pattern, re_exec): Declare arguments and local
11711 variables `size_t' and `ssize_t' and return values `regoff_t', as
11712 appropriate.
11713 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11714 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11715 <compile_stack_type>: `size' and `avail' are now `size_t'.
11716
11717 * regex.h <regoff_t>: Use ssize_t, not int.
11718 (re_search, re_search_2, re_match, re_match_2): Arguments that
11719 specify buffer/string position and length are now ssize_t and
11720 size_t. Return type is regoff_t.
11721
613052cd
BK
117222011-04-16 Ben Key <bkey76@gmail.com>
11723
11724 * nsfont.m: Fixed bugs in ns_get_family and
11725 ns_descriptor_to_entity that were caused by using free to
11726 deallocate memory blocks that were allocated by xmalloc (via
11727 xstrdup). This caused Emacs to crash when compiled with
11728 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11729 --enable-checking=xmallocoverrun). xfree is now used to
11730 deallocate these memory blocks.
11731
4170f62f 117322011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11733
71b41406
PE
11734 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11735
9587a89d
PE
11736 emacs_write: Accept and return EMACS_INT for sizes.
11737 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11738 et seq.
11739 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11740 Accept and return EMACS_INT.
11741 (emacs_gnutls_write): Return the number of bytes written on
11742 partial writes.
11743 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11744 (emacs_read, emacs_write): Remove check for negative size, as the
11745 Emacs source code has been audited now.
9587a89d
PE
11746 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11747 (emacs_read, emacs_write): Use it.
273a5f82
PE
11748 * process.c (send_process): Adjust to the new signatures of
11749 emacs_write and emacs_gnutls_write. Do not attempt to store
11750 a byte offset into an 'int'; it might overflow.
9587a89d 11751 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11752
3e047f51
PE
11753 * sound.c: Don't assume sizes fit in 'int'.
11754 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11755 Return EMACS_INT, not int.
3e047f51 11756 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11757 Accept EMACS_INT, not int.
11758 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11759 record read return values.
11760
cc39a9db
BK
117612011-04-15 Ben Key <bkey76@gmail.com>
11762
c9d0ec6d
JB
11763 * keyboard.c (Qundefined): Don't declare static since it is used
11764 in nsfns.m.
11765 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11766 static since they are used in nsfont.m.
cc39a9db 11767
6c60eb9f
SM
117682011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11769
11770 * process.c (Qprocessp): Don't declare static.
11771 * lisp.h (Qprocessp): Declare again.
11772
7990b61a
JB
117732011-04-15 Juanma Barranquero <lekktu@gmail.com>
11774
11775 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11776
5d4cb038
PE
117772011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11778
8bd7b830 11779 Improve C-level modularity by making more things 'static'.
cd64ea1d 11780
e3b27b31
PE
11781 Don't publish debugger-only interfaces to other modules.
11782 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11783 (verify_bytepos, count_markers): Move decls to the only modules
11784 that need them.
11785 * region-cache.h (pp_cache): Likewise.
11786 * window.h (check_all_windows): Likewise.
11787 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11788
5d4cb038
PE
11789 * sysdep.c (croak): Now static, if
11790 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11791 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11792
11793 * alloc.c (refill_memory_reserve): Now static if
11794 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11795 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11796
e87b6180
PE
11797 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11798 Define only if USE_LUCID.
11799
ac64929e
PE
11800 * xrdb.c (x_customization_string, x_rm_string): Now static.
11801
6f37259d
PE
11802 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11803 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11804
1683e3ab
PE
11805 * xdisp.c (draw_row_with_mouse_face): Now static.
11806 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11807
de9c2632
PE
11808 * window.h (check_all_windows): Mark externally visible.
11809
2b96acb7
PE
11810 * window.c (window_deletion_count): Now static.
11811
11812 * undo.c: Make symbols static if they're not exported.
11813 (last_undo_buffer, last_boundary_position, pending_boundary):
11814 Now static.
11815
50436f33
PE
11816 * textprop.c (interval_insert_behind_hooks): Now static.
11817 (interval_insert_in_front_hooks): Likewise.
11818
64520e5c
PE
11819 * term.c: Make symbols static if they're not exported.
11820 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11821 (max_frame_lines, tty_set_terminal_modes):
11822 (tty_reset_terminal_modes, tty_turn_off_highlight):
11823 (get_tty_terminal): Now static.
11824 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11825 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11826 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11827 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11828 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11829
1fa53021
PE
11830 * sysdep.c: Make symbols static if they're not exported.
11831 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11832 Now static.
11833 (sigprocmask_set, full_mask): Remove; unused.
11834 (wait_debugging): Mark as visible.
11835 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11836 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11837
d4b43b22
PE
11838 * syntax.c (syntax_temp): Define only if !__GNUC__.
11839
b7c513d0
PE
11840 * sound.c (current_sound_device, current_sound): Now static.
11841
989b29ad
PE
11842 * search.c (searchbufs, searchbuf_head): Now static.
11843
13a55a78
PE
11844 * scroll.c (scroll_cost): Remove; unused.
11845 * dispextern.h (scroll_cost): Remove decl.
11846
de68a1fc
PE
11847 * region-cache.h (pp_cache): Mark as externally visible.
11848
40ccffa6
PE
11849 * process.c: Make symbols static if they're not exported.
11850 (process_tick, update_tick, create_process, chan_process):
11851 (Vprocess_alist, proc_buffered_char, datagram_access):
11852 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11853 (deactivate_process): Mark defn as static, as well as decl.
11854 * lisp.h (create_process): Remove decl.
11855 * process.h (chan_process, Vprocess_alist): Remove decls.
11856
ad64fc97
PE
11857 * print.c: Make symbols static if they're not exported.
11858 (print_depth, new_backquote_output, being_printed, print_buffer):
11859 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11860 (print_interval, print_number_index, initial_stderr_stream):
11861 Now static.
11862 * lisp.h (Fprinc): Remove decl.
11863 (debug_output_compilation_hack): Mark as externally visible.
11864
adddb265
PE
11865 * sysdep.c (croak): Move decl from here to syssignal.h.
11866 * syssignal.h (croak): Put it here, so the API can be checked when
11867 'croak' is called from dissociate_if_controlling_tty.
11868
1717ede2
PE
11869 * minibuf.c: Make symbols static if they're not exported.
11870 (minibuf_save_list, choose_minibuf_frame): Now static.
11871 * lisp.h (choose_minibuf_frame): Remove decl.
11872
fa5fb2bc
PE
11873 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11874
1e3890d1
PE
11875 * lread.c: Make symbols static if they're not exported.
11876 (read_objects, initial_obarray, oblookup_last_bucket_number):
11877 Now static.
11878 (make_symbol): Remove; unused.
11879 * lisp.h (initial_obarray, make_symbol): Remove decls.
11880
8a1414fa
PE
11881 * keyboard.c: Make symbols static if they're not exported.
11882 (single_kboard, recent_keys_index, total_keys, recent_keys):
11883 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11884 (this_single_command_key_start, echoing, last_auto_save):
11885 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11886 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11887 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11888 (Vlispy_mouse_stem, double_click_count):
11889 Now static.
11890 (force_auto_save_soon): Define only if SIGDANGER.
11891 (ignore_mouse_drag_p): Now static if
11892 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11893 (print_help): Remove; unused.
11894 (stop_character, last_timer_event): Mark as externally visible.
11895 * keyboard.h (ignore_mouse_drag_p): Declare only if
11896 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11897 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11898 * lisp.h (echoing): Remove decl.
11899 (force_auto_save_soon): Declare only if SIGDANGER.
11900 * xdisp.c (redisplay_window): Simplify code, to make it more
11901 obvious that ignore_mouse_drag_p is not accessed if !defined
11902 USE_GTK && !defined HAVE_NS.
11903
93ea6e8f
PE
11904 * intervals.c: Make symbols static if they're not exported.
11905 (merge_properties_sticky, merge_interval_right, delete_interval):
11906 Now static.
11907 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11908
77382fcc
PE
11909 * insdel.c: Make symbols static if they're not exported.
11910 However, leave prepare_to_modify_buffer alone. It's never
11911 called from outside this function, but that appears to be a bug.
11912 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11913 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11914 (adjust_after_replace_noundo): Remove; unused.
11915 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11916 (signal_before_change): Remove decls.
77382fcc 11917
9306c32e
PE
11918 * indent.c (val_compute_motion, val_vmotion): Now static.
11919
cd44d2eb
PE
11920 * image.c: Make symbols static if they're not exported.
11921 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11922 if USE_GTK.
11923 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11924 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11925
ad9a7a06
PE
11926 * fringe.c (standard_bitmaps): Now static.
11927 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11928
81626931
PE
11929 * frame.c: Make symbols static if they're not exported.
11930 (x_report_frame_params, make_terminal_frame): Now static.
11931 (get_frame_param): Now static, unless HAVE_NS.
11932 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11933 (x_get_resource_string): Remove; not used.
11934 * frame.h (make_terminal_frame, x_report_frame_params):
11935 (x_get_resource_string); Remove decls.
11936 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11937 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11938
239f9db9
PE
11939 * font.c, fontset.c: Make symbols static if they're not exported.
11940 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11941 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11942 * font.c (font_close_object): Now static.
11943 * font.h (font_close_object): Remove.
11944 * fontset.c (FONTSET_OBJLIST): Remove.
11945 (free_realized_fontset) #if-0 the body, which does nothing.
11946 (face_suitable_for_char_p): #if-0, as it's never called.
11947 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11948 * xfaces.c (face_at_string_position):
11949 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11950 since 0 is always ASCII.
11951
dfcf3579
PE
11952 * fns.c (weak_hash_tables): Now static.
11953
5045092b
PE
11954 * fileio.c: Make symbols static if they're not exported.
11955 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11956 (Vwrite_region_annotation_buffers): Now static.
11957
57a96f5c
PE
11958 * eval.c: Make symbols static if they're not exported.
11959 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11960 * lisp.h (backtrace_list): Remove decl.
11961
35f08c38
PE
11962 * emacs.c: Make symbols static if they're not exported.
11963 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11964 (fatal_error_code, fatal_error_signal_hook, standard_args):
11965 Now static.
11966 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11967 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11968 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11969 * lisp.h (fatal_error_signal_hook): Remove decl.
11970 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11971
f44bd759
PE
11972 * editfns.c: Move a (normally-unused) function to its only use.
11973 * editfns.c, lisp.h (get_operating_system_release): Remove.
11974 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11975 worth the hassle of breaking this out.
11976
b532497d
PE
11977 * xterm.c: Make symbols static if they're not exported.
11978 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11979 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11980 (x_destroy_window, x_delete_display):
11981 Now static.
11982 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11983 (x_mouse_leave): Remove; unused.
11984 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11985 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11986 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11987 Remove decls.
11988 (x_mouse_leave): Declare only if WINDOWSNT.
11989 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11990 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11991 USE_X_TOOLKIT.
11992
1675728f
PE
11993 * ftxfont.c: Make symbols static if they're not exported.
11994 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11995 HAVE_FREETYPE.
11996 * font.h (ftxfont_driver): Likewise.
11997
e4cebfca
PE
11998 * xfns.c: Make symbols static if they're not exported.
11999 (x_last_font_name, x_display_info_for_name):
12000 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12001 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12002 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12003 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12004 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12005 (last_show_tip_args): Now static.
12006 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12007 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12008 (x_screen_planes): Remove; unused.
12009 * dispextern.h (x_screen_planes): Remove decl.
12010
5bf46f05
PE
12011 * dispnew.c: Make symbols static if they're not exported.
12012 * dispextern.h (redraw_garbaged_frames, scrolling):
12013 (increment_row_positions): Remove.
12014 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12015 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12016 Now static.
12017 (redraw_garbaged_frames): Remove; unused.
12018
435f4c28
PE
12019 * xfaces.c: Make symbols static if they're not exported.
12020 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12021 Remove decls.
12022 * xterm.h (defined_color): Remove decls.
12023 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12024 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12025 (menu_face_changed_default, defined_color, free_realized_face):
12026 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12027 (ascii_face_of_lisp_face): Remove; unused.
12028
8524aef3
PE
12029 * xdisp.c: Make symbols static if they're not exported.
12030 * dispextern.h (scratch_glyph_row, window_box_edges):
12031 (glyph_to_pixel_coords, set_cursor_from_row):
12032 (get_next_display_element, set_iterator_to_next):
12033 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12034 (show_mouse_face): Remove decls
12035 * frame.h (message_buf_print): Likewise.
12036 * lisp.h (pop_message, set_message, check_point_in_composition):
12037 Likewise.
12038 * xterm.h (set_vertical_scroll_bar): Likewise.
12039 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12040 (message_buf_print, scratch_glyph_row, displayed_buffer):
12041 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12042 (get_next_display_element, show_mouse_face, window_box_edges):
12043 (frame_to_window_pixel_xy, check_point_in_composition):
12044 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12045 (glyph_to_pixel_coords): Remove; unused.
12046
16390cd2
PE
12047 * dired.c (file_name_completion): Now static.
12048
12049 * dbusbind.c (xd_in_read_queued_messages): Now static.
12050
a25f4dfa
PE
12051 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12052 * data.c (circular_list_error): Remove.
12053
14a9c8df
PE
12054 * commands.h (last_point_position, last_point_position_buffer):
12055 (last_point_position_window): Remove decls.
12056 * keyboard.c: Make these variables static.
12057
04f2d78b
CB
12058 * coding.h (coding, code_convert_region, encode_coding_gap):
12059 Remove decls.
74ab6df5
PE
12060 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12061 (iso_code_class, detect_coding, code_convert_region): Now static.
12062 (encode_coding_gap): Remove; unused.
12063
38dfbee1
PE
12064 * chartab.c (chartab_chars, chartab_bits): Now static.
12065
a2cb4e63
PE
12066 * charset.h (charset_iso_8859_1): Remove decl.
12067 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12068 Now static.
12069
127198fd
PE
12070 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12071 * ccl.c (Vccl_program_table): Now static.
12072 (check_ccl_update): Remove; unused.
12073
d85b608f
PE
12074 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12075 * category.h: ... from here.
12076 * category.c (check_category_table, set_category_set): Now static.
12077
31cd66f3
PE
12078 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12079 * lisp.h: Remove these decls.
12080
c358e587
PE
12081 * buffer.c (buffer_count): Remove unused var.
12082
e78aecca
PE
12083 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12084 so that it's not optimized away.
12085 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12086 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12087 exported only to the debugger.
12088
e192d7d3 12089 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12090 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12091
92470028
PE
12092 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12093 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12094 was inaccessible from Lisp.
12095 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12096 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12097
244ed907
PE
12098 alloc.c: Import and export fewer symbols, and remove unused items.
12099 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12100 is defined.
12101 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12102 it's not optimized away by whole-program optimization.
12103 (message_enable_multibyte, free_misc): Remove.
12104 (catchlist, handlerlist, mark_backtrace):
12105 Declare only if BYTE_MARK_STACK.
12106 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12107 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12108 (message_enable_multibyte): Remove decl.
12109 (free_misc, interval_free_list, float_block, float_block_index):
12110 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12111 (cons_free_list, last_marked_index):
12112 Now static.
12113 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12114 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12115 (mark_backtrace): Define only if BYTE_MARK_STACK.
12116 * xdisp.c (message_enable_multibyte): Now static.
12117
61c2b50e 12118 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12119 This makes it easier for human readers (and static analyzers)
12120 to see whether these variables are used from other modules.
12121 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12122 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12123 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12124 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12125 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12126 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12127 * xmenu.c, xselect.c:
12128 Declare Q* vars static if they are not used in other modules.
12129 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12130 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12131 Remove decls of unexported vars.
12132 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12133
95c82688
PE
12134 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12135
16a97296
PE
12136 Make Emacs functions such as Fatom 'static' by default.
12137 This makes it easier for human readers (and static analyzers)
12138 to see whether these functions can be called from other modules.
12139 DEFUN now defines a static function. To make the function external
12140 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12141 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12142 (Finit_image_library):
16a97296
PE
12143 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12144 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12145 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12146 Remove decls, since these functions are now static.
12147 (Funintern, Fget_internal_run_time): New decls, since these functions
12148 were already external.
95c82688 12149
16a97296
PE
12150 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12151 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12152 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12153 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12154 * keyboard.c, keymap.c, lread.c:
12155 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12156 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12157 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12158 Mark functions with DEFUE instead of DEFUN,
12159 if they are used in other modules.
12160 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12161 decls for now-static functions.
12162 * buffer.h (Fdelete_overlay): Remove decl.
12163 * callproc.c (Fgetenv_internal): Mark as internal.
12164 * composite.c (Fremove_list_of_text_properties): Remove decl.
12165 (Fcomposition_get_gstring): New forward static decl.
12166 * composite.h (Fcomposite_get_gstring): Remove decl.
12167 * dired.c (Ffile_attributes): New forward static decl.
12168 * doc.c (Fdocumntation_property): New forward static decl.
12169 * eval.c (Ffetch_bytecode): New forward static decl.
12170 (Funintern): Remove extern decl; now in .h file where it belongs.
12171 * fileio.c (Fmake_symbolic_link): New forward static decl.
12172 * image.c (Finit_image_library): New forward static decl.
12173 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12174 * intervals.h (Fprevious_property_change):
12175 (Fremove_list_of_text_properties): Remove decls.
12176 * keyboard.c (Fthis_command_keys): Remove decl.
12177 (Fcommand_execute): New forward static decl.
12178 * keymap.c (Flookup_key): New forward static decl.
12179 (Fcopy_keymap): Now static.
12180 * keymap.h (Flookup_key): Remove decl.
12181 * process.c (Fget_process): New forward static decl.
12182 (Fprocess_datagram_address): Mark as internal.
12183 * syntax.c (Fsyntax_table_p): New forward static decl.
12184 (skip_chars): Remove duplicate decl.
12185 * textprop.c (Fprevious_property_change): New forward static decl.
12186 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12187 Now internal.
12188 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12189 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12190
785bbd42
PE
12191 * editfns.c (Fformat): Remove unreachable code.
12192
8b913b57
AS
121932011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12194
12195 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12196 change. (Bug#8496)
12197
a6744a35
EZ
121982011-04-13 Eli Zaretskii <eliz@gnu.org>
12199
12200 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12201 when at ZV. (Bug#8487)
12202
e7974947
AS
122032011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12204
baad03f0
AS
12205 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12206 (Bug#8437)
12207 * keyboard.c (parse_tool_bar_item): Likewise.
12208 * sound.c (sound_cleanup, alsa_close): Likewise.
12209 * termcap.c (tgetent): Likewise.
12210 * xfns.c (x_default_font_parameter): Likewise.
12211 * xsettings.c (read_and_apply_settings): Likewise.
12212
e7974947
AS
12213 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12214 (overrun_check_free): Protoize.
12215
28272684
PE
122162011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12217
12218 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12219 since callers should never pass a negative size.
12220 Change the signature to match that of plain 'read' and 'write'; see
12221 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12222 * lisp.h: Update prototypes of emacs_write and emacs_read.
12223
11997c76
EZ
122242011-04-11 Eli Zaretskii <eliz@gnu.org>
12225
12226 * xdisp.c (redisplay_window): Don't try to determine the character
12227 position of the scroll margin if the window start point w->startp
e896f03c 12228 is outside the buffer's accessible region. (Bug#8468)
11997c76 12229
8a2cbd72
EZ
122302011-04-10 Eli Zaretskii <eliz@gnu.org>
12231
12232 Fix write-region and its subroutines for buffers > 2GB.
12233 * fileio.c (a_write, e_write): Modify declaration of arguments and
12234 local variables to support buffers larger than 2GB.
12235 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12236
12237 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12238 argument, local variables, and return value.
12239
12240 * lisp.h: Update prototypes of emacs_write and emacs_read.
12241
12242 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12243
4073e537 122442011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12245
1ebfdcb6
PE
12246 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12247
b2ded58d
PE
12248 Fix more problems found by GCC 4.6.0's static checks.
12249
7d66342c
PE
12250 * xdisp.c (vmessage): Use a better test for character truncation.
12251
bbf47d44
PE
12252 * charset.c (load_charset_map): <, not <=, for optimization,
12253 and to avoid potential problems with integer overflow.
9248994d 12254 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12255 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12256 * editfns.c (Fformat): Likewise.
1e69125e 12257 * syntax.c (skip_chars): Likewise.
3befa583 12258
e3019616
PE
12259 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12260 This also lets GCC 4.6.0 generate slightly better loop code.
12261
becfa255
PE
12262 * callint.c (Fcall_interactively): <, not <=, for optimization.
12263 (Fcall_interactively): Count the number of arguments produced,
12264 not the number of arguments given. This is simpler and lets GCC
12265 4.6.0 generate slightly better code.
12266
dae0cd48
PE
12267 * ftfont.c: Distingish more carefully between FcChar8 and char.
12268 The previous code passed unsigned char * to a functions like
12269 strlen and xstrcasecmp that expect char *, which does not
12270 conform to the C standard.
12271 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12272 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12273 char * when the C standard requires it.
12274
76032d70
PE
12275 * keyboard.c (read_char): Remove unused var.
12276
eb3f1cc8
PE
12277 * eval.c: Port to Windows vsnprintf (Bug#8435).
12278 Include <limits.h>.
12279 (SIZE_MAX): Define if the headers do not.
12280 (verror): Do not give up if vsnprintf returns a negative count.
12281 Instead, grow the buffer. This ports to Windows vsnprintf, which
12282 does not conform to C99. Problem reported by Eli Zaretskii.
12283 Also, simplify the allocation scheme, by avoiding the need for
12284 calling realloc, and removing the ALLOCATED variable.
12285
70476b54
PE
12286 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12287
12020a9e
PE
12288 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12289 But keep the doprint source code for now, as we might revamp it
12290 and use it again (Bug#8435).
ea6c7ae6
PE
12291 * lisp.h (doprnt): Remove.
12292 * Makefile.in (base_obj): Remove doprnt.o.
12293 * deps.mk (doprnt.o): Remove.
12294
5fdb398c
PE
12295 error: Print 32- and 64-bit integers portably (Bug#8435).
12296 Without this change, on typical 64-bit hosts error ("...%d...", N)
12297 was used to print both 32- and 64-bit integers N, which relied on
12298 undefined behavior.
61bdb816 12299 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12300 * lisp.h (error, verror): Mark as printf-like functions.
12301 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12302 Report overflow in size calculations when allocating printf buffer.
12303 Do not truncate output string at its first null byte.
12304 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12305 Truncate the output at a character boundary, since vsnprintf does not
12306 do that.
12307 * charset.c (check_iso_charset_parameter): Convert internal
12308 character to string before calling 'error', since %c now has the
12309 printf meaning.
12310 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12311 overflow when computing char to be passed to 'error'. Do not
12312 pass Lisp_Object to 'error'; pass the integer instead.
12313 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12314 formatted with plain %d.
12315
b189fa66
PE
12316 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12317
bff87ef0
PE
12318 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12319
7e2cac20
PE
12320 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12321
ce4d90b5
PE
12322 * xterm.c (x_catch_errors): Remove duplicate declaration.
12323
266c9547
PE
12324 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12325
79c49ad2
PE
12326 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12327
368f4090
JM
123282011-04-10 Jim Meyering <meyering@redhat.com>
12329
12330 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12331 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12332 return ssize_t not "int", and use size_t as the buffer length.
12333 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12334 * gnutls.h: Update declarations.
12335 * process.c (read_process_output): Use ssize_t, to match.
12336 (send_process): Likewise.
12337
a32d4040
CY
123382011-04-09 Chong Yidong <cyd@stupidchicken.com>
12339
12340 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12341
8546720e 123422011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12343
04f2d78b
CB
12344 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12345 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12346
8546720e
GM
12347 * xterm.c (handle_one_xevent):
12348 * xmenu.c (create_and_show_popup_menu):
12349 * xselect.c (x_decline_selection_request)
12350 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12351
0a2f5c1a 123522011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12353
12354 Fix some uses of `int' instead of EMACS_INT.
12355 * search.c (string_match_1, fast_string_match)
12356 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12357 (scan_buffer, find_next_newline_no_quit)
12358 (find_before_next_newline, search_command, Freplace_match)
12359 (Fmatch_data): Make some `int' variables be EMACS_INT.
12360
12361 * xdisp.c (display_count_lines): 3rd argument and return value now
12362 EMACS_INT. All callers changed.
12363 (pint2hrstr): Last argument is now EMACS_INT.
12364
12365 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12366 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12367 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12368 (decode_coding_utf_16, decode_coding_emacs_mule)
12369 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12370 (decode_coding_ccl, decode_coding_charset)
12371 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12372 (decode_coding_iso_2022, decode_coding_emacs_mule)
12373 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12374 <char_offset, last_offset>: Declare EMACS_INT.
12375 (encode_coding_utf_8, encode_coding_utf_16)
12376 (encode_coding_emacs_mule, encode_invocation_designation)
12377 (encode_designation_at_bol, encode_coding_iso_2022)
12378 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12379 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12380 Declare EMACS_INT.
12381 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12382 (encode_invocation_designation): Last argument P_NCHARS is now
12383 EMACS_INT.
12384 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12385 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12386
12387 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12388 All users changed.
12389
12390 * ccl.c (Fccl_execute_on_string): Declare some variables
12391 EMACS_INT.
12392
8546720e 123932011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12394
12395 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12396
4e19a977
CS
123972011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12398
12399 * process.c (Fformat_network_address): Doc fix.
12400
87302331
R
124012011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12402
ee7683eb 12403 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12404
cbb59342
CY
124052011-04-08 Chong Yidong <cyd@stupidchicken.com>
12406
12407 * keyboard.c (read_char): Call Lisp function help-form-show,
12408 instead of using internal_with_output_to_temp_buffer.
12409 (Qhelp_form_show): New var.
e0d38eeb 12410 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12411
12412 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12413
12414 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12415
e67a13ab
CY
124162011-04-06 Chong Yidong <cyd@stupidchicken.com>
12417
04f2d78b
CB
12418 * process.c (Flist_processes): Remove to Lisp.
12419 (list_processes_1): Delete.
e67a13ab 12420
973f782d
EZ
124212011-04-06 Eli Zaretskii <eliz@gnu.org>
12422
7c106b1e
EZ
12423 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12424
973f782d
EZ
12425 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12426
41cf7d1a 124272011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12428
ca23cc88
PE
12429 Fix more problems found by GCC 4.6.0's static checks.
12430
f390e2d5
PE
12431 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12432
42eea0d0
PE
12433 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12434
b69769da 12435 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12436
f9541e84
PE
12437 * xdisp.c (vmessage): Mark as a printf-like function.
12438
13841b55
PE
12439 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12440
c136c10f
PE
12441 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12442
5e2d4a30
PE
12443 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12444 printf-like functions.
12445 (tiff_load): Add casts to remove these marks before passing them
12446 to system-supplied API.
12447
583f48b9
PE
12448 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12449
b25d760e
PE
12450 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12451 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12452 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12453 directly, rather than having caller test rule sign. This avoids
12454 some unnecessary tests.
12455 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12456 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12457 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12458
bc7b6697 12459 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12460 (xfont_open): Avoid unnecessary tests.
bc7b6697 12461
27ccc379
PE
12462 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12463
dcd5c89a
PE
12464 * composite.h, composite.c (composition_gstring_put_cache):
12465 Use EMACS_INT, not int, for length.
12466
b13a45c6
PE
12467 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12468 breaking out part of COMPOSITION_DECODE_RULE.
12469 (COMPOSITION_DECODE_RULE): Use it.
12470 * composite.c (get_composition_id): Remove unused local vars,
12471 by using the new macro.
12472
1e792e4d
PE
12473 * textprop.c (set_text_properties_1): Change while to do-while,
12474 since the condition is always true at first.
12475
dc6c6455 12476 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12477 (interval_deletion_adjustment): Return unsigned value.
12478 All uses changed.
dc6c6455 12479
aba7731a
PE
12480 * process.c (list_processes_1, create_pty, read_process_output):
12481 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12482 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12483 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12484 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12485 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12486
fdfc4bf3
PE
12487 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12488
fca8fe46 12489 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12490 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12491
06a0259a 12492 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12493 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12494 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12495
e7b9e80f
PE
12496 * print.c (print_error_message): Avoid int overflow.
12497
56201685
PE
12498 * font.c (font_list_entities): Redo for clarity,
12499 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12500
78834453 12501 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12502 (font_score): Avoid potential overflow in diff calculation.
78834453 12503
0bc0b309 12504 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12505 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12506
e610eaca
PE
12507 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12508
b895abce
PE
12509 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12510 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12511 can always succeed if overflow has undefined behavior.
12512
1f1d9321 12513 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12514 (wordify): Omit three unnecessary tests.
1f1d9321 12515
c59478bc
PE
12516 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12517 All callers changed. This avoids the need for an unused var.
12518
79b73827
PE
12519 * casefiddle.c (casify_region): Remove var that is set but not used.
12520
a4db5dfe
PE
12521 * dired.c (file_name_completion): Remove var that is set but not used.
12522
43aae36e
PE
12523 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12524
2a47c44d 12525 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12526 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12527
a37c69bf
PE
12528 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12529 Check for integer overflow on size calculations.
12530
328ab8e7
PE
12531 * buffer.c (Fprevious_overlay_change): Remove var that is set
12532 but not used.
12533
e5a2a5cb
PE
12534 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12535 Remove vars that are set but not used.
8d84a6eb 12536 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12537 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12538
a60e5f68
PE
12539 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12540
f661cb61 12541 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12542 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12543
f0397f5a
PE
12544 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12545 that are set but not used.
12546
8664db06 12547 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12548 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12549
6abdaa4a
PE
12550 * xselect.c (x_get_local_selection, x_handle_property_notify):
12551 Remove vars that are set but not used.
12552
0ce7538d 12553 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12554 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12555
9ae848fc
PE
12556 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12557 Remove var that is set but not used.
0b918413
PE
12558 (scroll_bar_windows_size): Now size_t, not int.
12559 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12560 Check for overflow.
9ae848fc 12561
a5a62657
PE
12562 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12563 (map_tty_color) [!defined MSDOS]: Likewise.
12564
5c5cdd39
PE
12565 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12566
66ebf983
PE
12567 * coding.c: Remove vars that are set but not used.
12568 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12569 All callers changed.
12570 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12571 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12572 (decode_coding_charset): Remove vars that are set but not used.
12573
1be4d761
PE
12574 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12575 that is set but not used.
12576
47553fa8
PE
12577 * print.c (print_object): Remove var that is set but not used.
12578
1f7196bf 12579 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12580 The gnulib version avoids calling malloc in the usual case,
12581 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12582 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12583 * filelock.c (current_lock_owner): Likewise.
12584 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12585 * sysdep.c: Include allocator.h, careadlinkat.h.
12586 (emacs_no_realloc_allocator): New static constant.
12587 (emacs_readlink): New function.
fdb61804
PE
12588 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12589 ../lib/careadlinkat.h.
d1fdcab7 12590
f84c17c7
SM
125912011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12592
12593 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12594 first non-nil return value).
12595
ef3862ad
JD
125962011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12597
12598 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12599 if not defined (Bug#8403).
12600
376a7006
JB
126012011-04-02 Juanma Barranquero <lekktu@gmail.com>
12602
12603 * xdisp.c (display_count_lines): Remove parameter `start',
12604 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12605 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12606 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12607 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12608 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12609 and thereabouts. All callers changed.
12610 (get_per_char_metric): Remove parameter `f', unused since
12611 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12612
6ca3801d
JM
126132011-04-02 Jim Meyering <meyering@redhat.com>
12614
12615 do not dereference NULL upon failed strdup
12616 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12617 (ns_get_family): Likewise.
12618
d8e2b5ba
JB
126192011-04-02 Juanma Barranquero <lekktu@gmail.com>
12620
12621 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12622
8c74fcbd
JD
126232011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12624
12625 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12626 later (Bug#8403).
12627
7200d79c
SM
126282011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12629
03408648 12630 Add lexical binding.
7200d79c 12631
03408648
SM
12632 * window.c (Ftemp_output_buffer_show): New fun.
12633 (Fsave_window_excursion):
12634 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12635
12636 * lread.c (lisp_file_lexically_bound_p): New function.
12637 (Fload): Bind Qlexical_binding.
12638 (readevalloop): Remove `evalfun' arg.
12639 Bind Qinternal_interpreter_environment.
12640 (Feval_buffer): Bind Qlexical_binding.
12641 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12642 Mark as dynamic.
12643 (syms_of_lread): Declare `lexical-binding'.
12644
12645 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12646
12647 * keyboard.c (eval_dyn): New fun.
12648 (menu_item_eval_property): Use it.
ca105506
SM
12649
12650 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12651
03408648
SM
12652 * fns.c (concat, mapcar1): Accept byte-code-functions.
12653
12654 * eval.c (Fsetq): Handle lexical vars.
12655 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12656 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12657 (FletX, Flet): Obey lexical binding.
12658 (Fcommandp): Handle closures.
12659 (Feval): New `lexical' arg.
12660 (eval_sub): New function extracted from Feval. Use it almost
12661 everywhere where Feval was used. Look up vars in lexical env.
12662 Handle closures.
12663 (Ffunctionp): Move from subr.el.
12664 (Ffuncall): Handle closures.
12665 (apply_lambda): Remove `eval_flags'.
12666 (funcall_lambda): Handle closures and new byte-code-functions.
12667 (Fspecial_variable_p): New function.
12668 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12669 but without exporting it to Lisp.
23aba0ea 12670
23aba0ea 12671 * doc.c (Fdocumentation, store_function_docstring):
03408648 12672 * data.c (Finteractive_form): Handle closures.
23aba0ea 12673
03408648
SM
12674 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12675 interactive spec.
ba83908c 12676
04f2d78b
CB
12677 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12678 New byte-codes.
03408648
SM
12679 (exec_byte_code): New function extracted from Fbyte_code to handle new
12680 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12681
03408648 12682 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12683
03408648 12684 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12685
e2abce01
JB
126862011-03-31 Juanma Barranquero <lekktu@gmail.com>
12687
12688 * xdisp.c (redisplay_internal): Fix prototype.
12689
63696a73 126902011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12691
63696a73 12692 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12693 (try_scrolling): Use it when setting scroll_limit.
12694 Limit scrolling to 100 screen lines.
63696a73
EZ
12695 (redisplay_window): Even when falling back on "recentering",
12696 position point in the window according to scroll-conservatively,
12697 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12698
12699 (try_scrolling): When point is above the window, allow searching
12700 as far as scroll_max, or one screenful, to compute vertical
12701 distance from PT to the scroll margin position. This prevents
12702 try_scrolling from unnecessarily failing when
12703 scroll-conservatively is set to a value slightly larger than the
12704 window height. Clean up the case of PT below the margin at bottom
12705 of window: scroll_max can no longer be INT_MAX. When aggressive
12706 scrolling is in use, don't let point enter the opposite scroll
12707 margin as result of the scroll.
12708 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12709 threshold of 100 lines for never-recentering scrolling.
12710
e4cc2dfc
JB
127112011-03-31 Juanma Barranquero <lekktu@gmail.com>
12712
12713 * dispextern.h (move_it_by_lines):
12714 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12715 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12716 (message_log_check_duplicate): Remove parameters `prev_bol' and
12717 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12718 (redisplay_internal): Remove parameter `preserve_echo_area',
12719 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12720
12721 * indent.c (Fvertical_motion):
12722 * window.c (window_scroll_pixel_based, Frecenter):
12723 Don't pass `need_y_p' to `move_it_by_lines'.
12724
1c470562
SM
127252011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12726
44f230aa
SM
12727 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12728 steal a few bits to be more compact.
12729 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12730 Remove unneeded casts.
12731
1c470562
SM
12732 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12733
888adce9
ZK
127342011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12735
12736 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12737 binding" message (bug#7967).
12738
f838ed7b
PE
127392011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12740
77861b95
PE
12741 Fix more problems found by GCC 4.6.0's static checks.
12742
de6dbc14
PE
12743 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12744 Remove unused local var.
12745
f838ed7b
PE
12746 * editfns.c (Fmessage_box): Remove unused local var.
12747
792c7b2b
PE
12748 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12749 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12750 Omit unused local vars.
c499e557 12751 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12752 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12753 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12754 Omit unused local var.
12755
ba0165e1
PE
12756 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12757 Don't assume string length fits in int.
32ad8845 12758 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12759 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12760
3c59b4c9
PE
12761 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12762 instead of alloca (Bug#8344).
12763
a3eed478 12764 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12765 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12766
eb4d412d
PE
12767 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12768
1658b401
PE
12769 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12770 concerns.
12771
12772 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12773
12774 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12775
9a2c6e05
PE
12776 * keyboard.c (syms_of_keyboard): Use the same style as later
12777 in this function when indexing through an array. This also
12778 works around GCC bug 48267.
12779
03d0a109
PE
12780 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12781
44f730c8
PE
12782 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12783
fe75f926
PE
12784 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12785 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12786
ffa8c828
PE
12787 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12788 This avoids undefined behavior on integer overflow, and is a bit
12789 more convenient anyway since it is compared to a size_t variable.
12790
c5101a77
PE
12791 Variadic C functions now count arguments with size_t, not int.
12792 This avoids an unnecessary limitation on 64-bit machines, which
12793 caused (substring ...) to crash on large vectors (Bug#8344).
12794 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12795 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12796 All variadic functions and their callers changed accordingly.
c5101a77
PE
12797 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12798 * data.c (arith_driver, float_arith_driver): Likewise.
12799 * editfns.c (general_insert_function): Likewise.
12800 * eval.c (struct backtrace.nargs, interactive_p)
12801 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12802 (funcall_lambda, mark_backtrace): Likewise.
12803 * fns.c (concat): Likewise.
12804 * frame.c (x_set_frame_parameters): Likewise.
12805 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12806 0 if not found, not -1. All callers changed.
12807
dd3f25f7
PE
12808 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12809 (stack_copy_size): Now size_t, not int.
12810 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12811
461c2ab9
JB
128122011-03-28 Juanma Barranquero <lekktu@gmail.com>
12813
12814 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12815 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12816 All callers changed.
12817
12818 * lisp.h (multibyte_char_to_unibyte):
12819 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12820 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12821 * character.h (CHAR_TO_BYTE8):
12822 * cmds.c (internal_self_insert):
12823 * editfns.c (general_insert_function):
12824 * keymap.c (push_key_description):
12825 * search.c (Freplace_match):
12826 * xdisp.c (message_dolog, set_message_1): All callers changed.
12827
f6d62986
SM
128282011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12829
12830 * keyboard.c (safe_run_hook_funcall): New function.
12831 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12832 don't set the hook to nil, but remove the offending function instead.
12833 (Qcommand_hook_internal): Remove, unused.
12834 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12835 Vcommand_hook_internal.
12836
12837 * eval.c (enum run_hooks_condition): Remove.
12838 (funcall_nil, funcall_not): New functions.
12839 (run_hook_with_args): Call each function through a `funcall' argument.
12840 Remove `cond' argument, now redundant.
12841 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12842 (Frun_hook_with_args_until_failure): Adjust accordingly.
12843 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12844
1db5b1ad
JB
128452011-03-28 Juanma Barranquero <lekktu@gmail.com>
12846
12847 * dispextern.h (string_buffer_position): Remove declaration.
12848
12849 * print.c (strout): Remove parameter `multibyte', unused since
12850 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12851
12852 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12853 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12854 All callers changed.
12855
12856 * w32.c (_wsa_errlist): Use braces for struct initializers.
12857
12858 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12859 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12860 All callers changed.
12861 (string_buffer_position): Likewise. Also, make static (it's never
12862 used outside xdisp.c).
12863 (cursor_row_p): Remove parameter `w', unused since
12864 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12865 (decode_mode_spec): Remove parameter `precision', introduced during
12866 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12867 All callers changed.
12868
5ffb62aa
JD
128692011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12870
12871 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12872
461c2ab9 128732011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12874
12875 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12876 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12877 (ns_update_auto_hide_menu_bar): New functions.
12878 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12879 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12880 ns_constrain_all_frames.
12881 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12882 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12883
5c380ffb
JD
128842011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12885
12886 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12887
9af30bdf
GM
128882011-03-27 Glenn Morris <rgm@gnu.org>
12889
12890 * syssignal.h: Replace RETSIGTYPE with void.
12891 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12892 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12893 Replace SIGTYPE with void everywhere.
12894 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12895 * s/template.h (SIGTYPE): Remove commented out definition.
12896
e2abce01
JB
128972011-03-26 Eli Zaretskii <eliz@gnu.org>
12898
12899 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12900 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12901
f868cd8a
JB
129022011-03-26 Juanma Barranquero <lekktu@gmail.com>
12903
59eb0929
JB
12904 * w32.c (read_unc_volume): Use parameter `henum', instead of
12905 global variable `wget_enum_handle'.
12906
12907 * keymap.c (describe_vector): Remove parameters `indices' and
12908 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12909 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12910
f868cd8a
JB
12911 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12912
12913 * keyboard.c (timer_check): Remove parameter `do_it_now',
12914 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12915 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12916 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12917
12918 * keyboard.c (read_char):
12919 * w32menu.c (w32_menu_display_help):
12920 * xmenu.c (show_help_event, menu_help_callback):
12921 Adjust calls to `show_help_echo'.
12922
12923 * gtkutil.c (xg_maybe_add_timer):
12924 * keyboard.c (readable_events):
12925 * process.c (wait_reading_process_output):
12926 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12927
12928 * insdel.c (adjust_markers_gap_motion):
12929 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12930 (gap_left, gap_right): Don't call it.
12931
2ecf6fdb
CY
129322011-03-25 Chong Yidong <cyd@stupidchicken.com>
12933
12934 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12935 incurred during fontification.
12936
6b1f9ba4
JB
129372011-03-25 Juanma Barranquero <lekktu@gmail.com>
12938
12939 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12940 (DEFVAR_PER_BUFFER): Don't pass it.
12941
12942 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12943 (scrolling_window): Don't pass it.
12944
0f4a96b5
JB
129452011-03-25 Juanma Barranquero <lekktu@gmail.com>
12946
12947 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12948
12949 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12950 and `suffix'.
12951 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12952 of variables specific to SELinux and computation of `encoded_absname'.
12953
12954 * image.c (XPutPixel): Remove unused variable `height'.
12955
12956 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12957
12958 * unexw32.c (get_section_info): Remove unused variable `section'.
12959
12960 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12961 (system_process_attributes): Remove unused variable `sess'.
12962 (sys_read): Remove unused variable `err'.
12963
12964 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12965 (w32_wnd_proc): Remove unused variable `isdead'.
12966 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12967 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12968 (x_create_tip_frame): Remove unused variable `tem'.
12969
12970 * w32inevt.c (w32_console_read_socket):
12971 Remove unused variable `no_events'.
12972
12973 * w32term.c (x_draw_composite_glyph_string_foreground):
12974 Remove unused variable `width'.
12975
1149507c
JB
129762011-03-24 Juanma Barranquero <lekktu@gmail.com>
12977
12978 * w32term.c (x_set_glyph_string_clipping):
12979 Don't pass uninitialized region to CombineRgn.
12980
9c88f339
JB
129812011-03-23 Juanma Barranquero <lekktu@gmail.com>
12982
12983 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12984 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12985 (Fx_close_connection): Remove unused variable `i'.
12986
12987 * w32font.c (w32font_draw): Return number of glyphs.
12988 (w32font_open_internal): Remove unused variable `i'.
12989 (w32font_driver): Add missing initializer.
12990
12991 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12992 (fill_in_menu): Remove unused variable `items_added'.
12993
12994 * w32term.c (last_mouse_press_frame): Remove static global variable.
12995 (w32_clip_to_row): Remove unused variable `f'.
12996 (x_delete_terminal): Remove unused variable `i'.
12997
12998 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12999 (NOTHING): Remove unused static global variable.
13000 (uniscribe_check_otf): Remove unused variable `table'.
13001 (uniscribe_font_driver): Add missing initializers.
13002
dee091a3
JD
130032011-03-23 Julien Danjou <julien@danjou.info>
13004
13005 * term.c (Fsuspend_tty, Fresume_tty):
13006 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13007 * window.c (temp_output_buffer_show):
13008 * insdel.c (signal_before_change):
13009 * frame.c (Fhandle_switch_frame):
13010 * fileio.c (Fdo_auto_save):
13011 * emacs.c (Fkill_emacs):
13012 * editfns.c (save_excursion_restore):
13013 * cmds.c (internal_self_insert):
13014 * callint.c (Fcall_interactively):
13015 * buffer.c (Fkill_all_local_variables):
13016 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13017 Use Frun_hooks.
0f4a96b5 13018 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13019 unconditionally since it does the check itself.
dee091a3 13020
2c520ab5 130212011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13022
c9c49752
PE
13023 Fix more problems found by GCC 4.5.2's static checks.
13024
8abc3f12
PE
13025 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13026 the first time through the loop, since we know p0 < p1 then.
13027 This also avoids a gcc -Wstrict-overflow warning.
13028
a2d26660
PE
13029 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13030 leading to a memory leak, possible in functions like
13031 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13032 of objects (Bug#8318).
a2d26660 13033
916c72e9
PE
13034 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13035 that could (at least in theory) be that large.
13036
19ab8a18
PE
13037 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13038 This is less likely to overflow, and avoids undefined behavior if
13039 overflow does occur. All callers changed. Use strtoul to scan
13040 for the unsigned long integer.
b7cbbd6f
PE
13041 (pint2hrstr): Simplify and tune code slightly.
13042 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13043
f0641eff
PE
13044 * scroll.c (do_scrolling): Work around GCC bug 48228.
13045 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13046
7f650bb9
PE
13047 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13048 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13049 (validate_x_resource_name): Simplify count usage.
13050 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13051
37dd57d1
PE
13052 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13053 fail (Bug#8306).
81e56e61 13054
699979fc 13055 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13056
401bf9b4
PE
13057 * process.c (Fmake_network_process): Use socklen_t, not int,
13058 where POSIX says socklen_t is required in portable programs.
13059 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13060 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13061 (Fmake_network_process, server_accept_connection):
13062 (wait_reading_process_output, read_process_output):
13063 Likewise.
13064
b93aacde
PE
13065 * process.c: Rename or move locals to avoid shadowing.
13066 (list_processes_1, Fmake_network_process):
13067 (read_process_output_error_handler, exec_sentinel_error_handler):
13068 Rename or move locals.
4dc343ee 13069 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13070 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13071 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13072 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13073 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13074
af8a867c 13075 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13076 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13077 Include tparam.h instead, since it declares them.
af8a867c
PE
13078 * cm.h (PC): Remove extern decl; tparam.h now does this.
13079 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13080 * terminfo.c: Include tparam.h, to check interfaces.
13081 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13082 (tparam): Adjust signature to match interface in tparam.h;
13083 this removes some undefined behavior. Check that outstring and len
13084 are zero, which they always are with Emacs.
13085 * tparam.h (PC, BC, UP): New extern decls.
13086
0248044d 13087 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13088 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13089
8ff096c1 13090 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13091 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13092 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13093 (ftfont_list): Remove unused local.
49eaafba
PE
13094 (get_adstyle_property, ftfont_pattern_entity):
13095 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13096 Rename locals to avoid shadowing.
8ff096c1 13097
e2be39f6
PE
13098 * xfont.c (xfont_list_family): Mark var as initialized.
13099
c9735e30
PE
13100 * xml.c (make_dom): Now static.
13101
8f5201ae
PE
13102 * composite.c (composition_compute_stop_pos): Rename local to
13103 avoid shadowing.
b246f932
PE
13104 (composition_reseat_it): Remove unused locals.
13105 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13106 (composition_update_it): Mark var as initialized.
11b61122
PE
13107 (find_automatic_composition): Mark vars as initialized,
13108 with a FIXME (Bug#8290).
8f5201ae 13109
760fbc2c
PE
13110 character.h: Rename locals to avoid shadowing.
13111 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13112 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13113 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13114 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13115 to avoid shadowing.
13116
ff08eb85
PE
13117 * textprop.c (property_change_between_p): Remove; unused.
13118
fc7bf025
PE
13119 * intervals.c (interval_start_pos): Now static.
13120
235d7abc
PE
13121 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13122
44f230aa
SM
13123 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13124 Rename locals to avoid shadowing.
3e7d6594 13125
50060332
PE
13126 * sound.c (wav_play, au_play, Fplay_sound_internal):
13127 Fix pointer signedness.
d01f234b 13128 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13129 (wav_play): Initialize a variable to 0, to prevent undefined
13130 behavior (Bug#8278).
50060332 13131
c4fc4e30
PE
13132 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13133
918436ed
PE
13134 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13135
c939f91b
PE
13136 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13137 clobbering (Bug#8298).
b9c7f648
PE
13138 * sysdep.c (sys_subshell): Likewise.
13139 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13140
6bd8c144
PE
13141 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13142 This should get cleaned up, so that child_setup has the
13143 same signature on all platforms.
13144
7710357c 13145 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13146 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13147
c59da222
CY
131482011-03-22 Chong Yidong <cyd@stupidchicken.com>
13149
13150 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13151 not to be necessary, and produces flickering.
13152
66b87493
GM
131532011-03-20 Glenn Morris <rgm@gnu.org>
13154
13155 * config.in: Remove file.
13156
45b6f6d5
JB
131572011-03-20 Juanma Barranquero <lekktu@gmail.com>
13158
13159 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13160 are now in src/globals.h.
13161 (syms_of_minibuf): Remove spurious & from previous change.
13162
cd394be1 131632011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13164
13165 * minibuf.c (completing-read-function): New variable.
13166 (completing-read-default): Rename from completing-read.
13167 (completing-read): Call completing-read-function.
13168
b14e3e21
CY
131692011-03-19 Juanma Barranquero <lekktu@gmail.com>
13170
13171 * xfaces.c (Fx_load_color_file):
13172 Read color file from absolute filename (bug#8250).
13173
f2b726e6
JB
131742011-03-19 Juanma Barranquero <lekktu@gmail.com>
13175
13176 * makefile.w32-in: Update dependencies.
13177
09f6ff02
EZ
131782011-03-17 Eli Zaretskii <eliz@gnu.org>
13179
13180 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13181
29a6015a
PE
131822011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13183
a3a6c54e
PE
13184 Fix more problems found by GCC 4.5.2's static checks.
13185
b766f867
PE
13186 * process.c (make_serial_process_unwind, send_process_trap):
13187 (sigchld_handler): Now static.
13188
be02381c
PE
13189 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13190 That way, the code declares only the vars that it needs.
13191 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13192 * s/cygwin.h (PTY_ITERATION): Likewise.
13193 * s/darwin.h (PTY_ITERATION): Likewise.
13194 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13195
57048744
PE
13196 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13197 * process.c (allocate_pty): Don't declare stb unless it's needed.
13198
7914961c 13199 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13200 (CONSTANTLIM): Remove; unused.
13201 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13202 Define only if needed.
7914961c 13203
b3967b18
PE
13204 * unexelf.c (unexec): Name an expression,
13205 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13206 Use a different way to cause a compilation error if anyone uses
13207 n rather than nn, a way that does not involve shadowing.
73366a00 13208 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13209
29a6015a
PE
13210 * deps.mk (unexalpha.o): Remove; unused.
13211
43cfc33e 13212 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13213 * unexec.h: New file.
ce701a33
PE
13214 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13215 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13216 Depend on unexec.h.
13217 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13218 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13219 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13220 Change as necessary to match prototype in unexec.h.
ce701a33 13221
01f44d5a
PE
13222 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13223 shadowing.
4f63c6bb 13224 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13225
a6670b0b
PE
13226 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13227 Rename locals to avoid shadowing.
13228
cef2010d 13229 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13230 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13231
d4d7173a
PE
13232 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13233
f08b802a
PE
13234 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13235 warning when compiling print.c.
13236
3ddb0639
PE
13237 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13238 instead of using an uninitialized var.
5ad03b97 13239 (font_sort_entities): Mark var as initialized.
3ddb0639 13240
170a2692
PE
13241 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13242
e663c700
PE
13243 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13244 pointers to constants.
89bc529a 13245 (font_parse_fcname): Remove unused vars.
7b81e2d0 13246 (font_delete_unmatched): Now static.
ea838e10 13247 (font_get_spec): Remove; unused.
13a547c6
PE
13248 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13249 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13250 Rename or move locals to avoid shadowing.
e663c700 13251
2a80c887 13252 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13253 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13254
1384fa33 13255 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13256 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13257
8b2c52e9
PE
13258 * alloc.c (mark_backtrace): Move decl from here ...
13259 * lisp.h: ... to here, so that it can be checked.
13260
475545b5 13261 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13262 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13263 (lisp_indirect_variable): Name an expression,
13264 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13265 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13266
b1349114 13267 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13268 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13269 Use const pointer when appropriate.
b1349114 13270
a2928364
PE
13271 * lisp.h (get_system_name, get_operating_system_release):
13272 Move decls here, to check interfaces.
13273 * process.c (get_operating_system_release): Move decl to lisp.h.
13274 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13275 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13276 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13277 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13278 (Fformat_time_string, Fencode_time, Finsert_char):
13279 (Ftranslate_region_internal, Fformat):
13280 Rename or remove local vars to avoid shadowing.
9710023e 13281 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13282
a415e694
PE
13283 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13284 avoid shadowing.
13285
8ef4622d
PE
13286 * lisp.h (eassert): Check that the argument compiles, even if
13287 ENABLE_CHECKING is not defined.
13288
946f9a5b
PE
13289 * data.c (Findirect_variable): Name an expression, to avoid
13290 gcc -Wbad-function-cast warning.
112396d6 13291 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13292 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13293 (Fmake_variable_buffer_local, Fmake_local_variable):
13294 Mark variables as initialized.
52746918 13295 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13296
e5aab7e7 13297 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13298 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13299 Rename locals to avoid shadowing.
dff45157
PE
13300 (mark_stack): Move local variables into the #ifdef region where
13301 they're used.
7bc26fdb
PE
13302 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13303 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13304 needed otherwise.
13305 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13306 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13307 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13308
e5aab7e7
PE
13309 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13310 avoids undefined behavior in theory.
13311
4da60324
PE
13312 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13313
88043301
PE
13314 Use functions, not macros, for up- and down-casing (Bug#8254).
13315 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13316 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13317 to use the following functions instead of these macros.
13318 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13319 EMACS_INT, since callers assume the returned value fits in int.
13320 (upcase1): Likewise, for UPCASE_TABLE.
13321 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13322 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13323 the race-condition problem in the old DOWNCASE.
88043301 13324
19ed5445
PE
13325 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13326 Rename locals to avoid shadowing.
13327 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13328 (regex_compile, re_search_2, re_match_2_internal):
13329 Remove unused local vars.
952db0d7
PE
13330 (FREE_VAR): Rewrite so as not to use empty "else",
13331 which gcc can warn about.
da053e48 13332 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13333 (RETALLOC_IF): Define only if needed.
13334 (WORDCHAR_P): Likewise. This one is never needed, but is used
13335 only in a comment talking about a compiler bug, so put inside
13336 the #if 0 of that comment.
13337 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13338 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13339 Remove; unused.
19ed5445 13340
1f3561e4 13341 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13342 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13343 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13344
ded6f8f7
PE
13345 * search.c (simple_search): Remove unused var.
13346
dbd37a95
PE
13347 * dired.c (compile_pattern): Move decl from here ...
13348 * lisp.h: ... to here, so that it can be checked.
13349 (struct re_registers): New forward decl.
13350
7e47afad
PE
13351 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13352
85f24f61
PE
13353 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13354 All uses changed.
13355 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13356 Rename locals to avoid shadowing.
5671df8f 13357 (Fvertical_motion): Mark locals as initialized.
85f24f61 13358
181aa2be 13359 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13360 (casify_region): Mark local as initialized.
181aa2be 13361
930d429c
PE
13362 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13363
7082eac6
PE
13364 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13365 New macros, so that the caller can use some names other than
13366 gcpro1, gcpro2, etc.
13367 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13368 of the new macros.
13369 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13370 argument, for consistency with GCPRO2_VAR, etc: it is now the
13371 prefix of the variable, not the variable itself. All uses
13372 changed.
38b2c076
PE
13373 * dired.c (directory_files_internal, file_name_completion):
13374 Rename locals to avoid shadowing.
13375
15206ed9
PE
13376 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13377 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13378 dired.c's scmp function, had undefined behavior.
13379 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13380 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13381 * buffer.h: ... to here, because these macros use current_buffer,
13382 and the new implementation with inline functions needs to have
13383 current_buffer in scope now, rather than later when the macros
13384 are used.
13385 (downcase, upcase1): New static inline functions.
13386 (DOWNCASE, UPCASE1): Reimplement using these functions.
13387 This avoids undefined behavior in expressions like
13388 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13389 from race conditions in accessing the global variables
13390 case_temp1 and case_temp2.
13391 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13392 * lisp.h (case_temp1, case_temp2): Remove their decls.
13393 * character.h (ASCII_CHAR_P): Move from here ...
13394 * lisp.h: ... to here, so that the inline functions mentioned
13395 above can use them.
13396
4a6bea26
PE
13397 * dired.c (directory_files_internal_unwind): Now static.
13398
f14b7e14
PE
13399 * fileio.c (file_name_as_directory, directory_file_name):
13400 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13401 Now static.
2893f146
PE
13402 (file_name_as_directory): Use const pointers when appropriate.
13403 (Fexpand_file_name): Likewise. In particular, newdir might
13404 point at constant storage, so make it a const pointer.
fd4ead52 13405 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13406 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13407 signedness issues.
f839df0c
PE
13408 (Fset_file_times, Finsert_file_contents, auto_save_error):
13409 Rename locals to avoid shadowing.
f14b7e14 13410
5716756e 13411 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13412 (Ftry_completion, Fall_completions): Rename or remove locals
13413 to avoid shadowing.
5716756e 13414
b4c3046a
PE
13415 * marker.c (bytepos_to_charpos): Remove; unused.
13416
b45db522
PE
13417 * lisp.h (verify_bytepos, count_markers): New decls,
13418 so that gcc does not warn that these functions aren't declared.
13419
85876d07
PE
13420 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13421 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13422 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13423 (copy_text): Remove unused local var.
85876d07 13424
03d78a21 13425 * filelock.c (within_one_second): Now static.
b3dd38ab 13426 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13427
5df8f01b
PE
13428 * buffer.c (fix_overlays_before): Mark locals as initialized.
13429 (fix_start_end_in_overlays): Likewise. This function should be
13430 simplified by using pointers-to-pointers, but that's a different
13431 matter.
b1d876f1 13432 (switch_to_buffer_1): Now static.
8f54f30a
PE
13433 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13434 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13435
a70072c9 13436 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13437 Fix pointer signedness issue.
edced198
PE
13438 (sys_subshell): Mark local as volatile if checking for lint,
13439 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13440 (MAXPATHLEN): Define only if needed.
a70072c9 13441
a0977c44
PE
13442 * process.c (serial_open, serial_configure): Move decls from here ...
13443 * systty.h: ... to here, so that they can be checked.
13444
a884fdcc
PE
13445 * fns.c (get_random, seed_random): Move extern decls from here ...
13446 * lisp.h: ... to here, so that they can be checked.
13447
604efe86 13448 * sysdep.c (reset_io): Now static.
b8950c94 13449 (wait_for_termination_signal): Remove; unused.
604efe86 13450
38fc62d9
PE
13451 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13452 (copy_keymap_item, append_key, push_text_char_description):
13453 Now static.
1004a21a 13454 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13455 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13456 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13457 (describe_map_tree):
13458 Rename locals to avoid shadowing.
38fc62d9 13459
2f2650da
PE
13460 * keyboard.c: Declare functions static if they are not used elsewhere.
13461 (echo_char, echo_dash, cmd_error, top_level_2):
13462 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13463 (read_char, kbd_buffer_get_event, make_lispy_position):
13464 (make_lispy_event, make_lispy_movement, apply_modifiers):
13465 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13466 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13467 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13468 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13469 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13470
a053e86c 13471 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13472 (mark_kboards): Move decl here ...
13473 * alloc.c (mark_kboards): ... from here.
a053e86c 13474
4752793e
PE
13475 * lisp.h (force_auto_save_soon): New decl.
13476
74f10ca7 13477 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13478 (DEFINE_DUMMY_FUNCTION): New macro.
13479 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13480 Use it.
c03cd23f
PE
13481 (main): Add casts to avoid warnings
13482 if GCC considers string literals to be constants.
74f10ca7 13483
022e70d4
PE
13484 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13485
59d6fe83
PE
13486 * dbusbind.c: Pointer signedness fixes.
13487 (xd_signature, xd_append_arg, xd_initialize):
13488 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13489 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13490 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13491 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13492
78320123
PE
13493 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13494 if GCC considers string literals to be constants.
49cebcca 13495 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13496
35ac2a97
SM
134972011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13498
fb103ca9
SM
13499 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13500 (print_preprocess, print_object): New macro to fix last change.
13501
35ac2a97
SM
13502 * print.c (print_preprocess): Don't forget font objects.
13503
62973b41
JB
135042011-03-16 Juanma Barranquero <lekktu@gmail.com>
13505
13506 * emacs.c (USAGE3): Doc fixes.
13507
0e48bb22
AS
135082011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13509
13510 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13511 structure.
13512
7684e57b
JB
135132011-03-14 Juanma Barranquero <lekktu@gmail.com>
13514
13515 * lisp.h (VWindow_system, Qfile_name_history):
13516 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13517 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13518 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13519
13520 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13521 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13522
13523 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13524 * w32console.c (detect_input_pending, read_input_pending)
13525 (encode_terminal_code):
13526 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13527 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13528 (w32_system_caret_y, Qfile_name_history):
13529 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13530 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13531 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13532 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13533 * w32proc.c (Qlocal, report_file_error):
13534 * w32term.c (Vwindow_system, updating_frame):
13535 * w32uniscribe.c (initialized, uniscribe_font_driver):
13536 Remove unneeded extern declarations.
13537
2aa46d6c
CY
135382011-03-14 Chong Yidong <cyd@stupidchicken.com>
13539
c96bbc66 13540 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13541
cffc6f3b
CY
135422011-03-13 Chong Yidong <cyd@stupidchicken.com>
13543
13544 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13545 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13546 These macros can no longer be used for assignment.
13547
44f230aa
SM
13548 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13549 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13550 (record_buffer_markers, fetch_buffer_markers): New functions for
13551 recording and fetching special buffer markers.
13552 (set_buffer_internal_1, set_buffer_temp): Use them.
13553
13554 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13555
13556 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13557
13558 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13559 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13560
13561 * xdisp.c (hscroll_window_tree):
13562 (reconsider_clip_changes): Use PT instead of BUF_PT.
13563
d251f04b
EZ
135642011-03-13 Eli Zaretskii <eliz@gnu.org>
13565
13566 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13567 $(EMACS_ROOT)/lib/intprops.h.
13568
f0c77cd1
PE
135692011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13570
3eca4629
PE
13571 Fix more problems found by GCC 4.5.2's static checks.
13572
7c86ee98
PE
13573 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13574 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13575 (xg_free_frame_widgets): Make it clear that a local variable is
13576 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13577 (gdk_window_get_screen): Make it clear that this macro is needed
13578 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13579 (int_gtk_range_get_value): New function, which avoids a diagnostic
13580 from gcc -Wbad-function-cast.
13581 (xg_set_toolkit_scroll_bar_thumb): Use it.
13582 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13583 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13584 (get_utf8_string, xg_get_file_with_chooser):
13585 Rename locals to avoid shadowing.
13586 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13587
41729b81
PE
13588 * xgselect.c (xg_select): Remove unused var.
13589
f0c77cd1
PE
13590 * image.c (four_corners_best): Mark locals as initialized.
13591 (gif_load): Initialize transparent_p to zero (Bug#8238).
13592 Mark another local as initialized.
ec6cf4c6 13593 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13594
ce0ad53d 13595 * image.c (clear_image_cache): Now static.
d5d5a617 13596 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13597 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13598 (x_edge_detection): Remove unnecessary cast that
13599 gcc -Wbad-function-cast diagnoses.
2037898d 13600 (gif_load): Fix pointer signedness.
6ae141d6
PE
13601 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13602 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13603
33383987 136042011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13605
d32df629
PE
13606 Improve quality of tests for time stamp overflow.
13607 For example, without this patch (encode-time 0 0 0 1 1
13608 1152921504606846976) returns the obviously-bogus value (-948597
13609 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13610 reports time overflow. See
13611 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13612 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13613 * editfns.c: Include limits.h and intprops.h.
13614 (TIME_T_MIN, TIME_T_MAX): New macros.
13615 (time_overflow): Move earlier, to before first use.
13616 (hi_time, lo_time): New functions, for an accurate test for
13617 out-of-range times.
13618 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13619 (Fget_internal_run_time): Don't assume time_t fits in int.
13620 (make_time): Use list2 instead of Fcons twice.
13621 (Fdecode_time): More accurate test for out-of-range times.
13622 (check_tm_member): New function.
13623 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13624 (lisp_time_argument): Don't rely on undefined left-shift and
13625 right-shift behavior when checking for time stamp overflow.
8be6f318 13626
fe31d94c
PE
13627 * editfns.c (time_overflow): New function, refactoring common code.
13628 (Fformat_time_string, Fdecode_time, Fencode_time):
13629 (Fcurrent_time_string): Use it.
13630
8be6f318
PE
13631 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13632 * dired.c (make_time): Move to ...
13633 * editfns.c (make_time): ... here.
13634 * systime.h: Note the move.
13635
09d9db2c 136362011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13637
126bc0dc
YM
13638 * fringe.c (update_window_fringes): Remove unused variables.
13639
c47cbdfd
YM
13640 * unexmacosx.c (copy_data_segment): Also copy __got section.
13641 (Bug#8223)
13642
7ac80be9
EZ
136432011-03-12 Eli Zaretskii <eliz@gnu.org>
13644
c96bbc66 13645 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13646 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13647 Constify `char *' arguments and their references according to
13648 prototypes in tparam.h.
13649
ecb0f94d 13650 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13651
7ac80be9
EZ
13652 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13653 Adapt all references accordingly.
13654
13655 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13656
ef1fd07e
TT
136572011-03-11 Tom Tromey <tromey@redhat.com>
13658
13659 * buffer.c (syms_of_buffer): Remove obsolete comment.
13660
7ef4b50c
EZ
136612011-03-11 Eli Zaretskii <eliz@gnu.org>
13662
13663 * termhooks.h (encode_terminal_code): Declare prototype.
13664
13665 * msdos.c (encode_terminal_code): Don't declare prototype.
13666
13667 * term.c (encode_terminal_code): Now external again, used by
13668 w32console.c and msdos.c.
13669
44f230aa
SM
13670 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13671 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13672
4b1ec863 136732011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13674
1714f52b 13675 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13676
4b1ec863
PE
13677 * fringe.c (update_window_fringes): Mark locals as initialized
13678 (Bug#8227).
13679 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13680
524c7aa6
PE
13681 * alloc.c (mark_fringe_data): Move decl from here ...
13682 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13683 to check its interface.
13684 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13685
a5c0af81 13686 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13687 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13688 (fontset_font): Mark local as initialized.
a9a06e0b 13689 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13690
b4716021
PE
13691 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13692
811e9bac 13693 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13694 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13695 (x_own_selection, Fx_disown_selection_internal): Rename locals
13696 to avoid shadowing.
13697 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13698
7e3ab302
PE
13699 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13700 so that the caller can use some name other than gcpro1.
13701 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13702 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13703 (Fx_backspace_delete_keys_p):
13704 Use them to avoid shadowing, and rename vars to avoid shadowing.
13705 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13706 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13707 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13708 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13709 Remove unused locals.
7e3ab302
PE
13710 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13711 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13712 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13713 macros.
f78faa98 13714
e2b13473
PE
13715 * xterm.h (x_mouse_leave): New decl.
13716
77f23912
PE
13717 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13718 Remove unused functions.
cdf4ba58
PE
13719 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13720 (x_calc_absolute_position): Now static.
7411c686 13721 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13722 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13723 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13724 unless they are used.
38d0b34a
PE
13725 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13726 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13727 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13728 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13729 (x_error_catcher, x_connection_closed, x_error_handler):
13730 (x_error_quitter, xembed_send_message, x_iconify_frame):
13731 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13732 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13733 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13734
44f230aa
SM
13735 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13736 Rename or move locals to avoid shadowing.
6b463e58 13737 (tty_defined_color, merge_face_heights): Now static.
5967d051 13738 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13739 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13740 does not deduce is never used uninitialized.
73719eba
PE
13741 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13742 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13743
426994c3 13744 * terminal.c (store_terminal_param): Now static.
5489860b 13745
032f1620 13746 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13747 (set_frame_menubar): Remove unused local.
d4323972 13748 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13749 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13750 since they might point to immutable storage.
281585b0
PE
13751 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13752 since it's unused otherwise.
032f1620 13753
367c19e5 13754 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13755 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13756 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13757 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13758 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13759 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13760 does not deduce are never used uninitialized.
70739cbe 13761
07b48fa9
PE
13762 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13763
8868a238 13764 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13765 * window.c (window_loop, size_window):
13766 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13767
7e5cf297 13768 * window.c (display_buffer): Now static.
d6550a9f
PE
13769 (size_window): Mark variables that gcc -Wuninitialized
13770 does not deduce are never used uninitialized.
a586633d
PE
13771 * window.h (check_all_windows): New decl, to forestall
13772 gcc -Wmissing-prototypes diagnostic.
5b555da1 13773 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13774
f6095868
PE
13775 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13776 shadowing.
13777 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13778 Include <limits.h>.
13779 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13780 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13781 (load_charset_map): Mark variables that gcc -Wuninitialized
13782 does not deduce are never used uninitialized.
53df7c11 13783 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13784
f38b440c
PE
13785 * coding.c (coding_set_source, coding_set_destination):
13786 Use "else { /* comment */ }" rather than "else /* comment */;"
13787 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13788 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13789 a block, when the outer 'i' will do.
13790 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13791 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13792 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13793 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13794 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13795 Rename locals to avoid shadowing.
13796 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13797 * coding.c (emacs_mule_char, encode_invocation_designation):
13798 Now static, since they're not used elsewhere.
413bb2db 13799 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13800 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13801 (decode_coding_emacs_mule): Mark variables that gcc
13802 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13803 (detect_coding_iso_2022): Initialize a local variable that might
13804 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13805 this initialization is needed. (Bug#8211)
5f58e762
PE
13806 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13807 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13808 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13809 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13810 Remove unused macros.
f38b440c 13811
232b38b9 13812 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13813 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13814 * character.c (string_count_byte8): Likewise.
232b38b9 13815
fb90da1b
PE
13816 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13817 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13818
fb93dbc2
PE
13819 * chartab.c (copy_sub_char_table): Now static, since it's not used
13820 elsewhere.
5c156ace
PE
13821 (sub_char_table_ref_and_range, char_table_ref_and_range):
13822 Rename locals to avoid shadowing.
bbcd0949 13823 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13824
7d3b3862 13825 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13826 (BIDI_BOB): Remove unused macro.
7d3b3862 13827
6be7d3da
PE
13828 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13829 deduce are never used uninitialized.
c2ed9c8b 13830 * term.c (encode_terminal_code): Likewise.
6be7d3da 13831
75f8807f 13832 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13833
50938595
PE
13834 * tparam.h: New file.
13835 * term.c, tparam.h: Include it.
13836 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13837 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13838 Move these decls to tparam.h, and make them agree with what
13839 is actually in tparam.c. The previous trick of using incompatible
13840 decls in different modules does not conform to the C standard.
13841 All callers of tparam changed to use tparam's actual API.
13842 * tparam.c (tparam1, tparam, tgoto):
13843 Use const pointers where appropriate.
13844
fbceeba2
PE
13845 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13846 * cm.h (struct cm): Likewise.
13847 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13848 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13849 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13850 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13851 (turn_on_face, init_tty): Likewise.
13852 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13853
7f3f1250
PE
13854 * term.c (term_mouse_position): Rename local to avoid shadowing.
13855
e6ca6543
PE
13856 * alloc.c (mark_ttys): Move decl from here ...
13857 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13858
c40f8d15
AS
138592011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13860
13861 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13862
cfe0661d
JB
138632011-03-09 Juanma Barranquero <lekktu@gmail.com>
13864
13865 * search.c (compile_pattern_1): Remove argument regp, unused since
13866 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13867 (compile_pattern): Don't pass it.
13868
0afb4571
J
138692011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13870
13871 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13872 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13873 for ! HAVE_GTK3.
13874 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13875
13876 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13877
13878 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13879 gdk_window_get_screen, gdk_window_get_geometry,
13880 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13881 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13882 (xg_get_pixbuf_from_pixmap): New function.
13883 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13884 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13885 Call xg_get_pixbuf_from_pixmap instead of
13886 gdk_pixbuf_get_from_drawable.
13887 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13888 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13889 (xg_check_special_colors): Use GtkStyleContext and its functions
13890 for HAVE_GTK3.
13891 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13892 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13893 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13894 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13895 Call gtk_widget_get_preferred_size.
0afb4571
J
13896 (xg_frame_resized): gdk_window_get_geometry only takes 5
13897 parameters.
44f230aa
SM
13898 (xg_win_to_widget, xg_event_is_for_menubar):
13899 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13900 (xg_set_widget_bg): New function.
13901 (delete_cb): New function.
895009e1 13902 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13903 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13904 (xg_set_background_color): Call xg_set_widget_bg.
13905 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13906 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13907 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13908 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13909 if ! HAVE_GTK3.
13910 (update_frame_tool_bar): Call gtk_widget_hide.
13911 (xg_initialize): Use GDK_KEY_g.
13912
13913 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13914 if ! HAVE_GTK3
13915 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13916
13917 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13918 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13919 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13920
1c2cc4ef
JB
139212011-03-08 Juanma Barranquero <lekktu@gmail.com>
13922
13923 * w32xfns.c (select_palette): Check success of RealizePalette against
13924 GDI_ERROR, not zero.
13925
33383987 13926See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13927
13928;; Local Variables:
13929;; coding: utf-8
aac0c6e3
MR
13930;; End:
13931
2f097256 13932 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13933
13934 This file is part of GNU Emacs.
13935
13936 GNU Emacs is free software: you can redistribute it and/or modify
13937 it under the terms of the GNU General Public License as published by
13938 the Free Software Foundation, either version 3 of the License, or
13939 (at your option) any later version.
13940
13941 GNU Emacs is distributed in the hope that it will be useful,
13942 but WITHOUT ANY WARRANTY; without even the implied warranty of
13943 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13944 GNU General Public License for more details.
13945
13946 You should have received a copy of the GNU General Public License
13947 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.