Add news for exclamation-mark and flymake
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2e2d2a13
LL
12012-07-15 Leo Liu <sdl.web@gmail.com>
2
3 * fringe.c: Fix typo in comments.
4
cd276f6e
LL
52012-07-14 Leo Liu <sdl.web@gmail.com>
6
7 * fringe.c: Add a new bitmap exclamation-mark.
8
5a1131d9
EZ
92012-07-14 Eli Zaretskii <eliz@gnu.org>
10
11 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
12
13 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
14 (HAVE_MENUS): Don't define, defined by editing config.in with
15 msdos/sed2v2.inp.
16 (GMALLOC_INHIBIT_VALLOC): Don't define.
17 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
18
22e983b7
JB
192012-07-14 Juanma Barranquero <lekktu@gmail.com>
20
21 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
22
5b3f250f
GM
232012-07-14 Glenn Morris <rgm@gnu.org>
24
25 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
26 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
27 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
28
33d63ff4
GM
292012-07-13 Glenn Morris <rgm@gnu.org>
30
5b633342
GM
31 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
32
33d63ff4
GM
33 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
34 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
35
b55b9f85
JD
362012-07-13 Jan Djärv <jan.h.d@swipnet.se>
37
0dc8cf50
JD
38 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
39 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
40 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
41 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
42 where appropriate.
43 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
44 as boolean expression.
45 (x_set_window_size): Remove unused variable toolbar.
46 (ns_get_color_default, ns_mod_to_lisp): Remove.
47 (ns_mouse_position): Remove unused variables xchar and ychar.
48 (ns_compute_glyph_string_overhangs): Remove unused variable face.
49 (ns_set_vertical_scroll_bar): Remove unused variable count.
50 (ns_delete_terminal): Remove unused variable i.
51 (ns_term_init): Remove unused variables r, g and b.
52 (mouseDown): Remove unused variable window.
53 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
54 (initFrameFromEmacs): Remove unused variable vbextra.
55 (mouseEntered): Remove unused variables p and dpyinfo.
56 (mouseExited): Remove unused variables p and r.
57 (ns_define_frame_cursor, ns_clear_frame_area)
58 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
59 (menuDown): Assign [sender tag] to variable and cast the variable.
60
61 * nsterm.h (menuDown): Add id as type to argument sender.
62 (ns_display_info_for_name): Add Lisp_Object argument.
63 (ns_term_init): Add Lisp_Object argument.
64 (ns_map_event_to_object): Add void argument.
65 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
66 prototype with arguments and only declare if __OBJC__.
67 (nxatoms_of_nsselect): Add void argument.
68 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
69 (ns_alloc_autorelease_pool): Add void argument.
70 (ns_release_autorelease_pool): Add void* argument.
71 (ns_get_defaults_value): Add const char* argument.
72
73 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
74 (initFromContents): Use SSDATA where appropriate.
75 (ns_update_menubar): Add braces to ambigous if-else.
76 (initWithTitle): Put () around assignment in if statement.
77 (ns_menu_show): Remove unused variables window and keymap.
78 (update_frame_tool_bar): Remove unused variable selected_p.
79 (initWithContentRect): Remove unused variable this_cmd_name.
80
81 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
82 appropriate.
83 (setXBMColor): Remove unused variable len.
84 (setPixmapData): Put () around assignment in loop statement.
85
86 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
87 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
88 where appropriate.
89 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
90 around assignment in loop statement.
91 (nsfont_open): Remove unused variable i.
92 (nsfont_open): Remove unused variable len.
93 (nsfont_draw): Remove unused variable cs.
94
95 * nsfns.m (x_set_icon_name, ns_set_name_internal)
96 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
97 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
98 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
99 (Fns_font_name, Fns_perform_service)
100 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
101 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
102 (ns_set_name): Remove unused variable view.
103 (x_set_menu_bar_lines): Remove unused variable olines.
104 (x_set_tool_bar_lines): Remove unused variable root_window.
105 (Fns_list_colors): Put () around assignment in while statement.
106 (Fns_perform_service): Remove unused variable len.
107 (Fns_display_usable_bounds): Remove unused variable top.
108 (syms_of_nsfns): Remove unused variable i.
109
b55b9f85
JD
110 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
111 memcpy (Bug#11907).
112
ed9265fc 1132012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
114
115 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
116 and free it with DestroyExceptionInfo (Bug#11558).
117
ef099b57
JB
1182012-07-13 Juanma Barranquero <lekktu@gmail.com>
119
120 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
121 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
122 Set here, not in nt/config.nt.
123
ea814a5d
EZ
1242012-07-13 Eli Zaretskii <eliz@gnu.org>
125
126 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
127 cursor overflow into the last glyph on display line when the right
128 fringe is off. (Bug#11832)
129
1a952767
PE
1302012-07-13 Paul Eggert <eggert@cs.ucla.edu>
131
132 * xdisp.c (produce_special_glyphs): Now static.
133 * dispextern.h (produce_special_glyphs): Remove decl.
134
983188fd
GM
1352012-07-13 Glenn Morris <rgm@gnu.org>
136
32fb4bb6
GM
137 * s/bsd-common, s/cygwin.h: Remove empty files.
138 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
139
983188fd
GM
140 * s/usg5-4-common.h (USG, USG5):
141 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
142 * s/sol2-6.h (SOLARIS2):
143 * s/irix6-5.h (IRIX6_5):
144 * s/hpux10-20.h (USG, USG5, HPUX):
145 * s/gnu-linux.h (USG, GNU_LINUX):
146 * s/freebsd.h (BSD_SYSTEM):
147 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
148 * s/cygwin.h (CYGWIN):
149 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
150 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
151
d1e68667 1522012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
153
154 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 155
6de0e799
GM
1562012-07-13 Glenn Morris <rgm@gnu.org>
157
739ae010
GM
158 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
159
dbee5793
GM
160 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
161
6de0e799
GM
162 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
163 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
164
b82da769
GM
1652012-07-12 Glenn Morris <rgm@gnu.org>
166
4fae5a7a 167 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
168
169 * process.c (init_process_emacs): Rename from init_process.
170 The old name is also the name of a Mach system call.
171 * lisp.h, emacs.c: Update for this name change.
172 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
173 longer needed.
174
5a979817
EZ
1752012-07-12 Eli Zaretskii <eliz@gnu.org>
176
177 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
178 memmove call that removes glyphs covered by the left truncation
179 glyph. Improve commentary.
180 (display_line): Fix display of continuation glyphs on GUI frames
181 when the right fringe is turned off and variable-size fonts are
182 used in the window. Move the code that appends a stretch glyph to
183 produce_special_glyphs, so that it could be used for truncation
184 and continuation glyphs alike.
185 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
186 glyph of a suitably computed width, to align the special glyphs at
187 the window margin. Code moved from display_line. (Bug#11832)
188
3e91a053
GM
1892012-07-12 Glenn Morris <rgm@gnu.org>
190
ba9e4b84
GM
191 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
192
193 * s/gnu-linux.h, s/hpux10-20.h:
194 Do not unconditionally define HAVE_XRMSETDATABASE.
195
3e91a053
GM
196 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
197
b300b1f4
PE
1982012-07-12 Paul Eggert <eggert@cs.ucla.edu>
199
200 Fix typos that broke OS X build.
201 Reported by Randal L. Schwartz in
202 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
203 * nsterm.m (ns_timeout): Add missing local decl.
204 (ns_get_color): snprintf -> sprintf, to fix typo.
205
6e777848
GM
2062012-07-12 Glenn Morris <rgm@gnu.org>
207
3f922c37
GM
208 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
209 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
210 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
211 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
212
0ab7b23a
GM
213 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
214 Move PTY_OPEN to configure.
215
6e777848
GM
216 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
217 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
218 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
219
4a7edc24
DA
2202012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
221
222 Use empty_unibyte_string where applicable.
223 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
224 * lread.c (read1): Likewise.
225 * xsettings.c (syms_of_xsettings): Likewise.
226
308aab79
GM
2272012-07-12 Glenn Morris <rgm@gnu.org>
228
42bd1719
GM
229 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
230 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
231 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
232 * s/hpux10-20.h (RUN_TIME_REMAP):
233 * s/bsd-common.h (TABDLY): Move to configure.
234
235 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
236
237 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
238
ea0bbd17 239 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 240 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
241
242 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 243
308aab79
GM
244 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
245 * s/template.h: Move NARROWPROTO to configure.
246
ee1cf5cf
GM
2472012-07-11 Glenn Morris <rgm@gnu.org>
248
30fe9bf4
GM
249 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
250 unused since 2011-01-17 change to systty.h.
251
ee1cf5cf
GM
252 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
253 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
254 Move HAVE_PTYS and HAVE_SOCKETS to configure.
255
63e47e07
PE
2562012-07-11 Paul Eggert <eggert@cs.ucla.edu>
257
258 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
259
c43fb4c3
GM
2602012-07-11 Glenn Morris <rgm@gnu.org>
261
262 * s/darwin.h, s/gnu-linux.h, s/template.h:
263 Move INTERRUPT_INPUT to configure.
264
e8df9267
DA
2652012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
266
267 Minor adjustments to interning code.
268 * lisp.h (intern, intern_c_string): Redefine as static inline
269 wrappers for intern_1 and intern_c_string_1, respectively.
270 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
271 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
272 Vobarray checking.
e8df9267
DA
273 * font.c (font_intern_prop): Likewise. Adjust comment.
274 * w32font.c (intern_font_name): Likewise.
275
34348bd4
AS
2762012-07-11 Andreas Schwab <schwab@linux-m68k.org>
277
d96a1e0c
AS
278 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
279
34348bd4
AS
280 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
281 of Fcar/Fcdr if possible.
282 * font.c (check_otf_features): Likewise.
283 * fontset.c (Fnew_fontset): Likewise.
284 * gnutls.c (Fgnutls_boot): Likewise.
285 * minibuf.c (read_minibuf): Likewise.
286 * msdos.c (IT_set_frame_parameters): Likewise.
287 * xmenu.c (Fx_popup_dialog): Likewise.
288 * w32menu.c (Fx_popup_dialog): Likewise.
289
c8add24e
GM
2902012-07-11 Glenn Morris <rgm@gnu.org>
291
4b575b3c
GM
292 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
293 since nothing has defined it on these platforms.
294
09f4e3b0
GM
295 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
296 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
297
172bedef
GM
298 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
299 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
300 Move CLASH_DETECTION to configure.
301
249685df
GM
302 * s/gnu.h: Remove file, which is now empty.
303
c8add24e
GM
304 * s/gnu.h, s/gnu-linux.h:
305 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
306
b41253a3
JW
3072012-07-11 John Wiegley <johnw@newartisans.com>
308
309 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
310 function attribute, so we only use it if it exists in the
311 compiler.
312
d923b542
DA
3132012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
314
315 Avoid call to strlen in fast_c_string_match_ignore_case.
316 * search.c (fast_c_string_match_ignore_case): Change to use
317 length argument. Adjust users accordingly.
318 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
319
5ebbef1d
PE
3202012-07-11 Paul Eggert <eggert@cs.ucla.edu>
321
bb352260
PE
322 Assume mkdir, rmdir.
323 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
324 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
325
57054ddd
PE
326 Assume rename.
327 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
328
b747d3f7
PE
329 Assume perror.
330 * s/hpux10-20.h (HAVE_PERROR): Remove.
331 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
332 Remove dummy definition, as this problem was obsolete long ago.
333
5ebbef1d
PE
334 Assume strerror.
335 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
336
984e7f30
DA
3372012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
338
339 Avoid calls to strlen in font processing functions.
340 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 341 (font_open_by_name): Change to use length argument. Adjust
984e7f30 342 users accordingly.
d923b542
DA
343 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
344 Adjust prototypes.
345 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
346 Change to return ptrdiff_t.
984e7f30
DA
347 (xfont_list_pattern, xfont_match): Use length returned by
348 xfont_decode_coding_xlfd.
349 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
350
20e94fdd
GM
3512012-07-11 Glenn Morris <rgm@gnu.org>
352
9d596af3
GM
353 * s/darwin.h, s/freebsd.h, s/netbsd.h:
354 Move DONT_REOPEN_PTY to configure.
355
20e94fdd
GM
356 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
357 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
358
e99a530f
PE
3592012-07-10 Paul Eggert <eggert@cs.ucla.edu>
360
22ffb973
PE
361 Remove "#define unix" that is no longer needed (Bug#11905).
362 * s/aix4-2.h (unix): Remove; no longer needed.
363
e9a9ae03
PE
364 EMACS_TIME simplification (Bug#11875).
365 This replaces macros (which typically do not work in GDB)
366 with functions, typedefs and enums, making the code easier to debug.
367 The functional style also makes code easier to read and maintain.
368 * systime.h: Include <sys/time.h> on all hosts, not just if
369 WINDOWSNT, since 'struct timeval' is needed in general.
370 (EMACS_TIME): Now a typedef, not a macro.
371 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
372 not macros.
373 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
374 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
375 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
376 (EMACS_TIME_LE): Now functions, not macros.
377 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
378 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
379 which are not functions. All uses rewritten to use:
380 (make_emacs_time): New function.
381 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
382 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
383 not functions. All uses rewritten to use the following, respectively:
384 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
385 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 386 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
387 * fileio.c (Fcopy_file):
388 * xterm.c (XTflash): Get the current time closer to when it's used.
389 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
390
ffacb126
PE
391 * bytecode.c (targets): Suppress -Woverride-init warnings.
392
e99a530f
PE
393 Simplify by avoiding confusing use of strncpy etc.
394 * doc.c (Fsnarf_documentation):
395 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
396 * frame.c (Fmake_terminal_frame):
397 * gtkutil.c (get_utf8_string):
398 * lread.c (openp):
399 * nsmenu.m (ns_update_menubar):
400 * regex.c (regerror):
401 Prefer memcpy to strncpy and strncat when either will do.
402 * fileio.c (Fsubstitute_in_file_name):
403 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
404 (menu_separator_name_p):
405 * nsmenu.m (ns_update_menubar):
406 Prefer memcmp to strncmp when either will do.
407 * nsterm.m: Include <ftoastr.h>.
408 (ns_get_color):
409 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
410 Prefer snprintf to strncpy.
411 * nsterm.m (ns_term_init):
412 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
413 * nsterm.m (ns_term_init):
414 Avoid the need for strncpy, by using build_string or
415 make_unibyte_string directly. Use dtoastr, not snprintf.
416 * process.c (Fmake_network_process): Diagnose service names that
417 are too long, rather than silently truncating them or creating
418 non-null-terminated names.
419 (Fnetwork_interface_info): Likewise, for interface names.
420 * sysdep.c (system_process_attributes) [GNU_LINUX]:
421 Prefer sprintf to strncat.
422 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
423 Prefer vsnprintf to vsprintf + strncpy.
424
c59592b3
GM
4252012-07-10 Glenn Morris <rgm@gnu.org>
426
427 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
428 Clarify fallback case.
429
7d7bbefd
DA
4302012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
431
432 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
433 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
434 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 435 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
436 where argument type is known to be a Lisp_Cons.
437
3a4c8000
TT
4382012-07-10 Tom Tromey <tromey@redhat.com>
439
440 * bytecode.c (BYTE_CODE_THREADED): New macro.
441 (BYTE_CODES): New macro. Replaces all old byte-code defines.
442 (enum byte_code_op): New type.
443 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
444 (exec_byte_code): Use them. Use token threading when applicable.
445
2a0213a6
DA
4462012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
447
448 Optimize pure C strings initialization.
449 * lisp.h (make_pure_string): Fix prototype.
450 (build_pure_c_string): New function, defined as static inline. This
451 provides a better opportunity to optimize away calls to strlen when
452 the function is called with compile-time constant argument.
453 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
454 argument, adjust users accordingly. Use build_pure_c_string where
455 appropriate.
456 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
457 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
458 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
459
cb1caeaf
DA
4602012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
461
462 Avoid calls to strlen in miscellaneous functions.
463 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
464 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
465 * lread.c (openp): Likewise.
466
c293e30c
DA
4672012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
468
469 Avoid calls to strlen in path processing functions.
470 * fileio.c (file_name_as_directory): Add comment. Change to add
471 srclen argument and return the length of result. Adjust users
472 accordingly.
473 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 474 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
475 users accordingly.
476 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
477
9e059e3f
GM
4782012-07-10 Glenn Morris <rgm@gnu.org>
479
d02eb359
GM
480 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
481 Move PENDING_OUTPUT_COUNT definition to configure.
482
882cf227
GM
483 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
484 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
485 * s/gnu.h (DATA_START): Move definitions to configure.
486
af6e839f
GM
487 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
488 We include usg5-4-common.h, which defines them both.
489
40289a12
GM
490 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
491 O_RDONLY already includes it).
492
9e059e3f
GM
493 Stop ns builds setting the EMACSLOADPATH environment variable.
494 * nsterm.m (ns_load_path): Rename from ns_init_paths.
495 Now it does not set EMACSLOADPATH, just returns the load-path string.
496 * nsterm.h: Update accordingly.
497 * lread.c [HAVE_NS]: Include nsterm.h.
498 (init_lread) [HAVE_NS]: Use ns_load_path.
499 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
500
7c4e8ec0
GM
5012012-07-09 Glenn Morris <rgm@gnu.org>
502
d4f600ff
GM
503 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
504 since the included bsd-common.h does so.
505
cbb31951
GM
506 Stop ns builds setting the EMACSPATH environment variable.
507 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
508 (ns_init_paths): Do not set EMACSPATH.
509 * nsterm.h (ns_exec_path): Add it.
510 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
511 Use ns_exec_path.
512
7c4e8ec0
GM
513 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
514
26bccfae
PE
5152012-07-09 Paul Eggert <eggert@cs.ucla.edu>
516
a0bee46f
PE
517 * process.c (wait_reading_process_output): 'waitchannels' was unset
518 when read_kbd || !NILP (wait_for_cell); fix this.
519
5994c183
PE
520 Add GCC-style 'const' attribute to functions that can use it.
521 * character.h (char_resolve_modifier_mask):
522 * keyboard.h (make_ctrl_char):
523 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
524 (init_character_once, next_almost_prime, init_fns, init_image)
525 (flush_pending_output, init_sound):
526 * mem-limits.h (start_of_data):
527 * menu.h (finish_menu_items):
528 Add ATTRIBUTE_CONST.
529 * emacs.c (DEFINE_DUMMY_FUNCTION):
530 Declare the dummy function with ATTRIBUTE_CONST.
531 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
532 Add decls with ATTRIBUTE_CONST.
533
26bccfae
PE
534 Minor improvements to make_formatted_string.
535 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
536 where int is good enough, as vsprintf returns an int.
537 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
538
a8290ec3
DA
5392012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
540
541 Use make_formatted_string to avoid double length calculation.
542 * lisp.h (make_formatted_string): New prototype.
543 * alloc.c (make_formatted_string): New function.
544 * buffer.c (Fgenerate_new_buffer_name): Use it.
545 * dbus.c (syms_of_dbusbind): Likewise.
546 * editfns.c (Fcurrent_time_zone): Likewise.
547 * filelock.c (get_boot_time): Likewise.
548 * frame.c (make_terminal_frame, set_term_frame_name)
549 (x_report_frame_params): Likewise.
550 * image.c (gs_load): Likewise.
551 * minibuf.c (get_minibuffer): Likewise.
552 * msdos.c (dos_set_window_size): Likewise.
553 * process.c (make_process): Likewise.
554 * xdisp.c (ensure_echo_area_buffers): Likewise.
555 * xsettings.c (apply_xft_settings): Likewise.
556
d01ba2f1
GM
5572012-07-09 Glenn Morris <rgm@gnu.org>
558
559 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
560 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
561 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
562 * nsterm.h (ns_etc_directory): Add it.
563 * callproc.c [HAVE_NS]: Include nsterm.h.
564 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
565
f1f924b6
DA
5662012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
567
568 Move marker debugging code under MARKER_DEBUG.
569 * marker.c (MARKER_DEBUG): Move marker debugging code under
570 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
571 for bootstrap with --enable-checking (~3x slowdown reported
572 by Juanma Barranquero <lekktu@gmail.com>).
573 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
574
ab531b66
PE
5752012-07-08 Paul Eggert <eggert@cs.ucla.edu>
576
577 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
578 See <http://bugs.gnu.org/11825#29>.
579
c4b3bc8a
EZ
5802012-07-08 Eli Zaretskii <eliz@gnu.org>
581
582 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
583 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
584 (display_line): Add commentary about displaying truncation glyphs
585 on GUI frames.
586 (produce_special_glyphs): Move here from term.c.
587
588 * term.c (produce_special_glyphs): Move to xdisp.c.
589
590 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
591 section.
c4b3bc8a 592
b676b881
AS
5932012-07-07 Andreas Schwab <schwab@linux-m68k.org>
594
f17c5273
AS
595 * xdisp.c (display_line): Avoid warning about implicit declaration
596 of FRAME_FONT.
597
298819b9
AS
598 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
599
b676b881
AS
600 * lisp.h: Remove empty conditional.
601
6045c4fd
PE
6022012-07-07 Paul Eggert <eggert@cs.ucla.edu>
603
b3350bf9
PE
604 * lread.c (load_path_check): Now static.
605
6045c4fd
PE
606 Fix some minor --with-ns problems found by static checking.
607 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
608 (x_set_font) [!HAVE_X_WINDOWS]:
609 * image.c (xpm_load_image) [HAVE_NS]:
610 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
611 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
612 Remove unused local.
613 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
614 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
615 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
616 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
617 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
618 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
619 Fix pointer signedness problem.
620 * xfaces.c (FRAME_X_FONT_TABLE):
621 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
622
929e7845
GM
6232012-07-07 Glenn Morris <rgm@gnu.org>
624
625 * lread.c (load_path_check): New function, split from init_lread.
626 (init_lread): Reorganize. Motivation:
627 If EMACSLOADPATH is set, check/warn about that rather than the
628 defaults, which we are not going to use. Hence we can remove
629 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
630 Don't warn if site-lisp directories are missing.
631 If not installed, start from a blank load-path, since
632 PATH_LOADSEARCH refers to the eventual installation directories.
633
58dd0aa4
EZ
6342012-07-07 Eli Zaretskii <eliz@gnu.org>
635
636 Support truncation and continuation glyphs on GUI frames, when
637 fringes are disabled. (Bug#11832)
638 * xdisp.c (init_iterator): Get dimensions of truncation and
639 continuation glyphs even if on GUI frames. Adjust
640 it->last_visible_x on GUI frames when the left or right fringes,
641 or both, are absent.
642 (start_display, move_it_in_display_line_to): Handle the case of a
643 GUI frame without a fringe to display continuation or truncation
644 glyphs.
645 (insert_left_trunc_glyphs): Support GUI frames: make sure
646 truncation glyphs overwrite enough glyphs from the current line to
647 have sufficient space in pixels.
648 (display_line): Support truncation and continuation glyphs on GUI
649 frames. If some spare pixels are left on the line after inserting
650 the truncation glyphs, fill that space with a stretch glyph of a
651 suitably computed width.
652
653 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
654 produce_glyphs, to support GUI sessions.
655
31571fd7
PE
6562012-07-07 Paul Eggert <eggert@cs.ucla.edu>
657
5a16b9bc
PE
658 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
659
f3047c75
PE
660 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
661
31571fd7
PE
662 Do not require float-time's arg to fit in time_t (Bug#11825).
663 This works better on hosts where time_t is unsigned, and where
664 float-time is applied to the (negative) difference between two times.
665 * editfns.c (decode_time_components): Last arg is now double *,
666 not int *, and means to store all the result as a double, without
667 worrying about whether the seconds part fits in time_t.
668 All callers changed.
669 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
670 All callers changed.
671 (Ffloat_time): Do not fail merely because the specified time falls
672 outside of time_t range.
673
4516fbef
GM
6742012-07-07 Glenn Morris <rgm@gnu.org>
675
676 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
677 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
678 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
679
07adc2c6
JB
6802012-07-07 Juanma Barranquero <lekktu@gmail.com>
681
682 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
683 Update dependencies.
684
685 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
686
fd573f31
PE
6872012-07-06 Paul Eggert <eggert@cs.ucla.edu>
688
fee5959d
PE
689 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
690 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
691 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
692 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
693 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
694 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
695
fd573f31
PE
696 * xfont.c (compare_font_names): Redo to omit the need for casts.
697
ddadbc0e
AS
6982012-07-06 Andreas Schwab <schwab@linux-m68k.org>
699
fca8d6b6
AS
700 * xfns.c (Fx_change_window_property): Doc fix.
701 * w32fns.c (Fx_change_window_property): Doc fix.
702
ddadbc0e
AS
703 * w32fns.c (Fx_window_property): Accept the same arguments as the
704 X Windows version. Doc fix.
705 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
706
ed9265fc 7072012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
708 Eli Zaretskii <eliz@gnu.org>
709
710 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
711 Windows-specific code from nt/config.nt moved here.
712 Obsolete settings removed.
713
216ee680
PE
7142012-07-06 Paul Eggert <eggert@cs.ucla.edu>
715
716 * process.c: Avoid unnecessary calls to gettime.
717 (wait_reading_process_output): Don't get the time of day
718 when gobbling data immediately and not waiting, as there's no need
719 for it in that case. This removes a FIXME.
720
bdd091e4
JD
7212012-07-06 Jan Djärv <jan.h.d@swipnet.se>
722
723 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
724 is defined (Bug#11768).
725
9d44f8ce
DA
7262012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
727
728 Fix marker debugging code.
729 * marker.c (byte_char_debug_check): Do not perform the check
730 if buffer is not multibyte.
090bd7cb
JB
731 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
732 Call byte_char_debug_check with correct arguments.
9d44f8ce 733
90fc4786
DA
7342012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
735
736 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
737 * marker.c (byte_char_debug_check, count_markers):
738 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
739 (byte_debug_flag): Remove.
740 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
741 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
742
7b7ae965
DA
7432012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
744
4e57b342
DA
745 Avoid code repetition in marker-related functions.
746 * marker.c (attach_marker): New function.
747 (Fset_marker, set_marker_restricted, set_marker_both)
748 (set_marker_restricted_both): Use it.
749 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
750 Consistently rename charno to charpos.
751 (marker_position): Add eassert.
752 (marker_byte_position): Convert to eassert.
753
7542012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
755
756 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 757 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 758 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 759
657924ff
DA
7602012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
761
762 Introduce fast path for the widely used marker operation.
763 * alloc.c (build_marker): New function.
764 * lisp.h (build_marker): New prototype.
765 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
766 * composite.c (autocmp_chars): Likewise.
767 * editfns.c (buildmark): Remove.
768 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
769 (save_restriction_save): Use build_marker.
770 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
771 * window.c (save_window_save): Likewise.
772
041a49a6
DA
7732012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
774
775 Do not use Fdelete_overlay in delete_all_overlays
776 to avoid redundant calls to unchain_overlay.
777 * buffer.c (drop_overlay): New function.
778 (delete_all_overlays, Fdelete_overlay): Use it.
779 * minibuf.c (get_minibuffer): Fix comment.
780
7dca65a4
PE
7812012-07-06 Paul Eggert <eggert@cs.ucla.edu>
782
783 Port to OpenBSD 5.1 amd64.
784 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
785 This is needed for OpenBSD, and should be harmless on all BSD systems.
786 Also, include <sys/sysctl.h>, as it should be available on all
787 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
788 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
789 use p_pid member, not kp_proc.pid.
790
8eb876e2
GM
7912012-07-06 Glenn Morris <rgm@gnu.org>
792
793 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
794
38182d90
PE
7952012-07-05 Paul Eggert <eggert@cs.ucla.edu>
796
797 More xmalloc and related cleanup.
798 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
799 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
800 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
801 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
802 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
803 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
804 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
805 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
806 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
807 * xterm.c:
808 Omit needless casts involving void * pointers and allocation.
809 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
810 as the former is more robust if P's type is changed.
811 Prefer xzalloc to xmalloc + memset 0.
812 Simplify malloc-or-realloc to realloc.
813 Don't worry about xmalloc returning a null pointer.
814 Prefer xstrdup to xmalloc + strcpy.
815 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
816 growing it.
817 * keyboard.c (apply_modifiers_uncached): Prefer local array to
818 alloca of a constant.
819
6dd5a677
EZ
8202012-07-05 Eli Zaretskii <eliz@gnu.org>
821
822 * xdisp.c (display_line): Fix horizontal pixel coordinates when
823 hscroll is larger than the line width. Fixes long and futile
824 looping inside extend_face_to_end_of_line (on a TTY) producing
825 glyphs that are not needed and thrown away.
826
6b312f0f
DA
8272012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
828
829 * marker.c (set_marker_restricted_both): Simplify by using
830 clip_to_bounds.
831
f520ef9b
PE
8322012-07-05 Paul Eggert <eggert@cs.ucla.edu>
833
834 * editfns.c (region_limit): Simplify by using clip_to_bounds.
835
383b7c95
JD
8362012-07-05 Jan Djärv <jan.h.d@swipnet.se>
837
838 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
839 not defined (Bug#11768).
840 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
841 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
842 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
843 followed by gtk_box_set_homogeneous (Bug#11768).
844 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
845 (update_theme_scrollbar_width, xg_create_scroll_bar):
846 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
847 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
848 (is_box_type): New function (Bug#11768).
849 (xg_tool_item_stale_p): Call is_box_type.
5293d758 850 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
851 with default display (Bug#11768).
852
d6e7bf45
EZ
8532012-07-05 Eli Zaretskii <eliz@gnu.org>
854
855 * xdisp.c (window_hscroll_limited): New function.
856 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
857 coordinates when window's hscroll is set to insanely large
858 values. (Bug#11857)
859
431391ec
JB
8602012-07-05 Juanma Barranquero <lekktu@gmail.com>
861
862 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
863 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
864
23f86fce
DA
8652012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
866
867 Cleanup xmalloc.
868 * lisp.h (xzalloc): New prototype. Omit needless casts.
869 * alloc.c (xzalloc): New function. Omit needless casts.
870 * charset.c: Omit needless casts. Convert all calls to
871 xmalloc with following memset to xzalloc.
872 * dispnew.c: Likewise.
873 * fringe.c: Likewise.
874 * image.c: Likewise.
875 * sound.c: Likewise.
876 * term.c: Likewise.
877 * w32fns.c: Likewise.
878 * w32font.c: Likewise.
879 * w32term.c: Likewise.
880 * xfaces.c: Likewise.
881 * xfns.c: Likewise.
882 * xterm.c: Likewise.
883 * atimer.c: Omit needless casts.
884 * buffer.c: Likewise.
885 * callproc.c: Likewise.
886 * ccl.c: Likewise.
887 * coding.c: Likewise.
888 * composite.c: Likewise.
889 * doc.c: Likewise.
890 * doprnt.c: Likewise.
891 * editfns.c: Likewise.
892 * emacs.c: Likewise.
893 * eval.c: Likewise.
894 * filelock.c: Likewise.
895 * fns.c: Likewise.
896 * gtkutil.c: Likewise.
897 * keyboard.c: Likewise.
898 * lisp.h: Likewise.
899 * lread.c: Likewise.
900 * minibuf.c: Likewise.
901 * msdos.c: Likewise.
902 * print.c: Likewise.
903 * process.c: Likewise.
904 * region-cache.c: Likewise.
905 * search.c: Likewise.
906 * sysdep.c: Likewise.
907 * termcap.c: Likewise.
908 * terminal.c: Likewise.
909 * tparam.c: Likewise.
910 * w16select.c: Likewise.
911 * w32.c: Likewise.
912 * w32reg.c: Likewise.
913 * w32select.c: Likewise.
914 * w32uniscribe.c: Likewise.
915 * widget.c: Likewise.
916 * xdisp.c: Likewise.
917 * xmenu.c: Likewise.
918 * xrdb.c: Likewise.
919 * xselect.c: Likewise.
920
0497dc44
PE
9212012-07-05 Paul Eggert <eggert@cs.ucla.edu>
922
923 * fileio.c (time_error_value): Check the right error number.
924 Problem reported by Troels Nielsen in
925 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
926
356e7178
PE
9272012-07-04 Paul Eggert <eggert@cs.ucla.edu>
928
4e71fd89
PE
929 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
930 This should be fixed in a better way; see Eli Zaretskii in
931 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
932 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
933
f0941253
PE
934 * fileio.c (time_error_value): Rename from special_mtime.
935 The old name's problems were noted by Eli Zaretskii in
936 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
937
065c9eb4
PE
938 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
939 This variable's comment says Emacs needs at least one GDB-visible
940 symbol of type enum pvec_type, to work around GDB problems.
941 The symbol's value doesn't matter.
942
356e7178
PE
943 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
944 that causes compilation to fail on pre-C99 compilers.
945
ed9265fc 9462012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
947
948 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
949 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
950
3884d954
DA
9512012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
952
d209e2fb 953 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
954 headers for buffer_defaults and buffer_local_symbols.
955 Reported by Juanma Barranquero <lekktu@gmail.com>.
956
ee28be33
SM
9572012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
958
959 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
960 * lisp.h (enum pvec_type): Use fewer bits.
961 (PSEUDOVECTOR_SIZE_BITS): New constant.
962 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
963 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
964 change in pvec_type.
965 (PSEUDOVECTOR_TYPEP): New macro.
966 (TYPED_PSEUDOVECTORP): Use it.
967 * fns.c (internal_equal): Adapt code to extract pvectype.
968 * emacs.c (gdb_pvec_type): Update type.
969 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
970 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
971 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
972 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
973 (sweep_vectors): Use it. Use local var `total_bytes' instead of
974 abusing vector->header.next.nbytes.
975 (live_vector_p): Use PVEC_TYPE.
976 (mark_object): Adapt code to extract pvectype. Use switch.
977
c7f2cd7f
PE
9782012-07-04 Paul Eggert <eggert@cs.ucla.edu>
979
980 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
981 Tighten new eassert a bit.
982
8ce70ed2
DA
9832012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
984
985 Fix compilation with --enable-gcc-warnings and -O1
986 optimization level.
987 * doprnt.c (doprnt): Change type of tem to int, initialize
988 to avoid compiler warning. Add eassert.
989 * search.c (simple_search): Initialize match_byte to avoid
990 compiler warning. Add eassert.
991
dea7f1e5
PE
9922012-07-04 Paul Eggert <eggert@cs.ucla.edu>
993
24a212eb
PE
994 Avoid weird behavior with large horizontal scrolls.
995 Without this change, for example, large hscroll values would
996 mess up Emacs's display on Fedora 15 x86, presumably due to
997 overflows in int calculations in the display code.
998 Also, if buffers had long lines, Emacs would freeze.
999 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1000 (set_window_hscroll): New function, containing the old guts of
1001 Fset_window_hscroll. Return the clipped value.
1002 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1003 This avoids the need to check against PTRDIFF_MAX.
1004
dea7f1e5
PE
1005 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1006
76046526
DA
10072012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1008
1009 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1010
39adff0d
PE
10112012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1012
63807d47
PE
1013 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1014 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1015 since GCC 4.4.6 issues a bogus warning for them.
1016
39adff0d
PE
1017 Fix bugs in file timestamp newness comparisons.
1018 * fileio.c (Ffile_newer_than_file_p):
1019 * lread.c (Fload): Use full timestamp resolution of files,
1020 not just the 1-second resolution, so that files that are only
1021 slightly newer still count as newer.
1022 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1023 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1024
dbeed9a6
PE
10252012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1026
1027 * fileio.c: Improve handling of file time marker. (Bug#11852)
1028 (special_mtime): New function.
1029 (Finsert_file_contents, Fverify_visited_file_modtime):
1030 Use it to set special mtime values consistently.
1031
636334d6
AS
10322012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1033
1034 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1035 marker for non-existing file. (Bug#11852)
1036
e2017fe2
GM
10372012-07-03 Glenn Morris <rgm@gnu.org>
1038
1039 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1040 and did not make it into globals.h).
1041
404dbd37
TT
10422012-07-03 Tom Tromey <tromey@redhat.com>
1043
1044 * window.c (Fset_window_margins, Fset_window_fringes)
1045 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1046 * textprop.c (Fprevious_property_change): No longer static.
1047 * syntax.c (Fsyntax_table_p): No longer static.
1048 * process.c (Fget_process, Fprocess_datagram_address): No longer
1049 static.
1050 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1051 * keyboard.c (Fcommand_execute): No longer static.
1052 Remove EXFUN.
1053 * insdel.c (Fcombine_after_change_execute): No longer static.
1054 * image.c (Finit_image_library): No longer static.
1055 * fileio.c (Fmake_symbolic_link): No longer static.
1056 * eval.c (Ffetch_bytecode): No longer static.
1057 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1058 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1059 No longer static.
404dbd37
TT
1060 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1061 static.
1062 * dired.c (Ffile_attributes): No longer static.
1063 * composite.c (Fcomposition_get_gstring): No longer static.
1064 * callproc.c (Fgetenv_internal): No longer static.
1065
1066 * ccl.h: Remove EXFUNs.
1067 * buffer.h: Remove EXFUNs.
1068 * dispextern.h: Remove EXFUNs.
1069 * intervals.h: Remove EXFUNs.
1070 * fontset.h: Remove EXFUN.
1071 * font.h: Remove EXFUNs.
1072 * dosfns.c (system_process_attributes): Remove EXFUN.
1073 * keymap.h: Remove EXFUNs.
1074 * lisp.h: Remove EXFUNs.
1075 * w32term.h: Remove EXFUNs.
1076 * window.h: Remove EXFUNs.
1077 * xsettings.h: Remove EXFUN.
1078 * xterm.h: Remove EXFUN.
1079
8e4fd1e1
GM
10802012-07-03 Glenn Morris <rgm@gnu.org>
1081
1082 * lisp.h (Frandom): Make it visible to C.
1083 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1084 buffer for invisible buffers. (Bug#1229)
1085
ca95b3eb
DA
10862012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1087
1088 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1089 values which aren't power of 2.
1090 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1091 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1092 accordingly.
1093
7555c33f
SM
10942012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1095
1096 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1097
1098 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1099
d12e8f5a
DA
11002012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1101
1102 * alloc.c (allocate_vector_block): Remove redundant
1103 calls to mallopt if DOUG_LEA_MALLOC is defined.
1104 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1105 avoid calls to mallopt if zero_vector is returned.
1106
296094c3
DA
11072012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1108
1109 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1110 is enabled, avoid dereferencing NULL current_sblock if
1111 running undumped.
1112
36429c89
DA
11132012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1114
1115 Cleanup basic buffer management.
1116 * buffer.h (struct buffer): Change layout to use generic vector
1117 marking code. Fix some comments. Change type of 'clip_changed'
1118 to bitfield. Remove unused #ifndef old.
1119 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1120 (GET_OVERLAYS_AT): Fix indentation.
1121 (for_each_per_buffer_object_at): New macro.
1122 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1123 (Fbuffer_local_variables): Use it.
1124 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1125 * alloc.c (allocate_buffer): Adjust to match new layout of
1126 struct buffer. Fix comment.
1127 (mark_overlay): New function.
1128 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1129 Lisp area of struct buffer.
1130 (mark_object): Use it. Adjust marking of misc objects
1131 and related comments.
1132
3b3e4cac
PE
11332012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1134
1135 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1136 wrapper that is not needed because the wrapped code is a no-op (zero
1137 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1138 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1139
cf5c0175
DA
11402012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1141
1142 * alloc.c (mark_buffer): Simplify. Remove prototype.
1143 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1144 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1145 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1146 redundant calls to mark_vectorlike for bool vectors.
1147
ca26824c
GM
11482012-06-30 Glenn Morris <rgm@gnu.org>
1149
2e4c5312
GM
1150 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1151
ca26824c
GM
1152 * epaths.in (PATH_SITELOADSEARCH): New.
1153 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1154 This is rather than relying on --enable-locallisppath elements
1155 having "site-lisp" in their names. (Bug#10208#25, 11658)
1156
0d23c240
EZ
11572012-06-30 Eli Zaretskii <eliz@gnu.org>
1158
c9240d7a
EZ
1159 * w32proc.c (sys_select): Accept and ignore one more argument.
1160
1161 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1162
0d23c240 1163 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1164 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1165
1166 * sysdep.c: Don't include dos.h and dosfns.h.
1167
1168 * process.c (sys_select):
1169 * msdos.c (sys_select): Accept one more argument and ignore it.
1170
1171 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1172 adapt data types and code to that.
1173
1174 * dosfns.c:
1175 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1176 which clashes with the gnulib function of the same name.
1177
af5a5a98
AS
11782012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1179
c5e4379c
AS
1180 * font.c (font_style_to_value, font_style_symbolic)
1181 (font_prop_validate_style): Add type checks for values in
1182 font_style_table.
1183
af5a5a98
AS
1184 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1185 argument.
1186 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1187 uses.
1188
8d38f461
EZ
11892012-06-29 Eli Zaretskii <eliz@gnu.org>
1190
2e5a6631
EZ
1191 * xdisp.c (try_window_id): Undo last change.
1192
8d38f461
EZ
1193 * w32.c (getwd): Adjust commentary about startup_dir.
1194 (init_environment): Always call sys_access, even in non-MSVC
1195 builds. Don't chdir to the directory of the Emacs executable.
1196 This undoes code from 1997 which was justified by the need to
1197 "avoid conflicts when removing and renaming directories". But its
1198 downside was that every relative file name was being interpreted
1199 relative to the directory of the Emacs executable, which can never
1200 be TRT. In particular, it broke sys_access when called with
1201 relative file names.
1202 (sys_access): Map GetLastError to errno.
1203
2af3565e
DA
12042012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1205
1206 * window.h (struct window): Change type of 'fringes_outside_margins'
1207 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1208 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1209 Adjust comment.
1210 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1211 to ptrdiff_t.
1212
c8d3a25c 12132012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1214
c8d3a25c
GM
1215 * gnutls.c (emacs_gnutls_handshake):
1216 Add QUIT to make the loop interruptible.
57570cd3 1217
c8d3a25c 12182012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1219
c8d3a25c
GM
1220 * charset.c (init_charset): Make lack of etc/charsets fatal.
1221
3e984ee8
DA
12222012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1223
1224 * editfns.c (region_limit): Fix type mismatch.
1225
ef884f23
DA
12262012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1227
1228 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1229 undefined. Convert from xassert to eassert.
1230 * nsmenu.m: Convert from xassert to eassert.
1231 * nsterm.m: Likewise.
1232
7d7e0027
SM
12332012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1234
1235 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1236
aa754e6a
PE
12372012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1238
1239 Avoid integer overflow on scroll-left and scroll-right.
1240 * window.c (HSCROLL_MAX): New macro.
1241 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1242 overflow when requested scroll falls outside ptrdiff_t range.
1243
80b00b08
DA
12442012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1245
1246 * window.h (struct window): Change type of 'hscroll',
1247 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1248 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1249 Adjust users accordingly.
1250 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1251 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1252 from EMACS_INT to ptrdiff_t.
1253 (make_window): Omit redundant initialization.
1254
62b2bcf6
JB
12552012-06-28 Juanma Barranquero <lekktu@gmail.com>
1256
1257 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1258
45942c7d
DA
12592012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1260
1261 * window.h (struct window): Change type of 'use_time' and
1262 'sequence_number' from Lisp_Object to int.
1263 * frame.c (make_frame): Adjust users accordingly.
1264 * print.c (print_object): Likewise.
1265 * window.c (select_window, Fwindow_use_time, make_parent_window)
1266 (make_window): Likewise.
1267
e509cfa6
DA
12682012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1269
1270 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1271 enabled with --enable-checking=[all,glyphs] configure option.
1272 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1273 adjust comments accordingly.
1274 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1275 undefined, adjust comments accordingly.
1276 * image.c: Likewise.
1277 * scroll.c: Likewise.
1278 * w32fns.c: Likewise.
1279 * w32term.c: Likewise.
1280 * xdisp.c: Likewise.
1281 * xfaces.c: Likewise.
1282 * xfns.c: Likewise.
1283 * xterm.c: Likewise.
1284
a54e2c05
DA
12852012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1286
1287 Generalize run-time debugging checks.
1288 * dispextern.h (XASSERTS): Remove.
1289 * fontset.c (xassert): Remove.
1290 Convert from xassert to eassert.
1291 * alloc.c: Convert from xassert to eassert.
1292 * bidi.c: Likewise.
1293 * dispnew.c: Likewise.
1294 * fns.c: Likewise.
1295 * fringe.c: Likewise.
1296 * ftfont.c: Likewise.
1297 * gtkutil.c: Likewise.
1298 * image.c: Likewise.
1299 * keyboard.c: Likewise.
1300 * menu.c: Likewise.
1301 * process.c: Likewise.
1302 * scroll.c: Likewise.
1303 * sound.c: Likewise.
1304 * term.c: Likewise.
1305 * w32console.c: Likewise.
1306 * w32fns.c: Likewise.
1307 * w32term.c: Likewise.
1308 * window.c: Likewise.
1309 * xdisp.c: Likewise.
1310 * xfaces.c: Likewise.
1311 * xfns.c: Likewise.
1312 * xselect.c: Likewise.
1313 * xterm.c: Likewise.
1314
1ec4b7b2
SM
13152012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1316
1317 * fns.c (maybe_resize_hash_table): Output message when growing the
1318 purify-hashtable.
1319
2014308a
DA
13202012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1321
1322 * alloc.c (allocate_string_data): Remove dead code.
1323 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1324 avoid GCC warning about unused macro.
1325
246155eb
DA
13262012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1327
1328 * alloc.c (allocate_string): Omit intervals initialization.
1329 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1330 as in make_pure_string and make_pure_c_string.
1331
43184b7b
DA
13322012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1333
d209e2fb 1334 * alloc.c (allocate_string): Fix last change.
43184b7b 1335
3fe6dd74
DA
13362012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1337
d209e2fb 1338 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1339 to memset, add explicit initialization where appropriate.
1340
1ba6038a
GM
13412012-06-27 Glenn Morris <rgm@gnu.org>
1342
1343 * lisp.mk (lisp): Remove paths.elc.
1344
c89926a5
CY
13452012-06-27 Chong Yidong <cyd@gnu.org>
1346
1347 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1348
ed6b3510
JW
13492012-06-26 John Wiegley <johnw@newartisans.com>
1350
1ec4b7b2 1351 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1352 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1353
ed6b3510
JW
1354 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1355 when building with Clang.
1356
8edd4a2b
SM
13572012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1358
1359 * eval.c (Fapply): Allow calling it with a single argument.
1360
f6f62d1b
EZ
13612012-06-26 Eli Zaretskii <eliz@gnu.org>
1362
1363 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1364 _stricmp and _strnicmp.
1365 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1366
62efea5e
DA
13672012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1368
1369 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1370 allocated window.
1371 (allocate_process): Likewise for new process.
8edd4a2b 1372 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1373 (allocate_frame): Likewise.
1374 * frame.c (make_frame): Omit redundant initialization.
1375 * window.c (make_parent_window): Use memset.
1376 (make_window): Omit redundant initialization.
1377 * process.c (make_process): Omit redundant initialization.
1378 * terminal.c (create_terminal): Likewise.
1379
42997f4d
DA
13802012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1381
1382 * term.c (delete_tty): Remove redundant call to memset.
1383
1130ecfc
DA
13842012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1385
1386 * alloc.c: Remove build_string.
1387 * lisp.h: Define build_string as static inline. This provides
1388 a better opportunity to optimize away calls to strlen when the
1389 function is called with compile-time constant argument.
1390 * image.c (imagemagick_error): Convert to build_string.
1391 * w32proc.c (sys_spawnve): Likewise.
1392 * xterm.c (x_term_init): Likewise.
1393
cf38a720
PE
13942012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1395
99027bdd
PE
1396 Use sprintf return value instead of invoking strlen on result.
1397 In the old days this wasn't portable, since some sprintf
1398 implementations returned char *. But they died out years ago and
1399 Emacs already assumes sprintf returns int.
1400 Similarly for float_to_string.
1401 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1402 * ccl.c (ccl_driver):
1403 * character.c (string_escape_byte8):
1404 * data.c (Fnumber_to_string):
1405 * doprnt.c (doprnt):
1406 * print.c (print_object):
1407 * xdisp.c (message_dolog):
1408 * xfns.c (syms_of_xfns):
1409 Use sprintf or float_to_string result to avoid need to call strlen.
1410 * data.c (Fnumber_to_string):
1411 Use make_unibyte_string, since the string must be ASCII.
1412 * lisp.h, print.c (float_to_string): Now returns int length.
1413 * term.c (produce_glyphless_glyph):
1414 Use sprintf result rather than recomputing it.
1415
cf38a720
PE
1416 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1417 * Makefile.in (ALL_CFLAGS):
1418 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1419 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1420
3511c784
DA
14212012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1422
0a08eb21 1423 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1424 strcasecmp if available.
1425 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1426
fb7da12e
AS
14272012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1428
1429 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1430 Avoid comma operator.
1431 * menu.c (push_submenu_start, push_submenu_end)
1432 (push_left_right_boundary, push_menu_pane): Likewise.
1433 * msdos.c (dos_rawgetc): Likewise.
1434
afa2ffd8
DA
14352012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1436
1437 * xfns.c (xic_create_fontsetname): Remove redundant calls
1438 to memset.
1439
b3b4476b
PE
14402012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1441
4495ff38
PE
1442 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1443 sprintf already null-terminates its output.
1444
b3b4476b
PE
1445 * xfns.c (x_window): Remove redundant cast.
1446
b00876c9
DA
14472012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1448
1449 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1450 `const char *' to `char *' to avoid compiler warning.
1451
d188e26b
PE
14522012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1453
885d1d74
PE
1454 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1455 instead of truncating it to 63 (admittedly a generous limit).
1456
d188e26b
PE
1457 * process.c: Fix spelling and caps in comments.
1458
e2f560b1
DN
14592012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1460
e86db54b 1461 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1462 * sysdep.c (setpgrp): Remove definition, not used in this file.
1463
7583a3a1
JB
14642012-06-24 Juanma Barranquero <lekktu@gmail.com>
1465
1466 * makefile.w32-in: Update dependencies.
1467
696056c2
EZ
14682012-06-24 Eli Zaretskii <eliz@gnu.org>
1469
1470 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1471 (SYSTIME_H): Add nt/inc/sys/time.h.
1472
1473 * systime.h [WINDOWSNT]: Include sys/time.h.
1474
1475 * s/ms-w32.h (struct timespec): Definition moved from
1476 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1477
845ca893
PE
14782012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1479
1480 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1481 * buffer.h (buffer_slot_type_mismatch):
1482 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1483 * eval.c (unwind_to_catch):
1484 * image.c (my_png_error, my_error_exit):
1485 * keyboard.c (quit_throw_to_read_char, user_error)
1486 (Fexit_recursive_edit, Fabort_recursive_edit):
1487 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1488 (wrong_type_argument, buffer_overflow, __executable_start)
1489 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1490 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1491 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1492 (fatal):
1493 (child_setup) [!DOS_NT]:
1494 * lread.c (end_of_file_error, invalid_syntax):
1495 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1496 * puresize.h (pure_write_error):
1497 * search.c (matcher_overflow):
1498 * sound.c (sound_perror, alsa_sound_perror):
1499 * sysdep.c, syssignal.h (croak):
1500 * term.c (maybe_fatal, vfatal):
1501 * textprop.c (text_read_only):
1502 * undo.c (user_error):
1503 * unexmacosx.c (unexec_error):
1504 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1505 Use _Noreturn rather than NO_RETURN.
1506 No need for separate decl merely because of _Noreturn.
1507 * sound.c (sound_warning, parse_sound):
1508 Remove unnecessary forward decls.
1509
f1dd8073
PE
15102012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1511
1512 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1513 * lisp.h (WAIT_READING_MAX): New macro.
1514 * dispnew.c (Fsleep_for, sit_for):
1515 * keyboard.c (kbd_buffer_get_event):
1516 * process.c (Faccept_process_output):
1517 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1518 This improves on the previous patch, which introduced a bug
1519 when time_t is unsigned and as wide as intmax_t.
1520 See <http://bugs.gnu.org/9000#51>.
1521
b82c1755
EZ
15222012-06-23 Eli Zaretskii <eliz@gnu.org>
1523
1524 * dispnew.c (sit_for, Fsleep_for):
1525 * keyboard.c (kbd_buffer_get_event):
1526 * process.c (Faccept_process_output): Avoid compiler warnings when
1527 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1528
ca300656
JB
15292012-06-23 Juanma Barranquero <lekktu@gmail.com>
1530
049ec95b
JB
1531 * makefile.w32-in: Update dependencies.
1532
ca300656
JB
1533 * w32.c (ltime): Add return type and declare static.
1534 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1535
db7b8d06
PE
15362012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1537
1538 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1539 Privately reported by Herbert J. Skuhra.
1540 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1541 All uses changed.
1542 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1543 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1544
0bd8297f
EZ
15452012-06-23 Eli Zaretskii <eliz@gnu.org>
1546
96512555
EZ
1547 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1548 last argument of make_unibyte_string.
1549
0bd8297f
EZ
1550 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1551 language ID in the event parameters.
1552
1553 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1554 event.code, not the obscure "character set ID".
1555
63def6b6
CY
15562012-06-23 Chong Yidong <cyd@gnu.org>
1557
1558 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1559
e8a02204
EZ
15602012-06-23 Eli Zaretskii <eliz@gnu.org>
1561
388cdec0
EZ
1562 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1563 * w32.c (fdutimens): New function.
1564
1565 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1566
1567 * s/ms-w32.h (pselect): Redirect to sys_select.
1568
1569 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1570
e8a02204
EZ
1571 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1572 in the logic of incrementing and decrementing the value of
1573 use_relocatable_buffers.
1574
d054f3fb
PE
15752012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1576
1577 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1578 Privately reported by Herbert J. Skuhra.
1579 [__FreeBSD__]: Remove "*/" typo after "#include".
1580 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1581 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1582 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1583 Don't assume EMACS_TIME and struct timeval are the same type.
1584
d35af63c
PE
15852012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1586
1587 Support higher-resolution time stamps (Bug#9000).
1588 The time stamps are only nanosecond-resolution at the C level,
1589 since that's the best that any real-world system supports now.
1590 But they are picosecond-resolution at the Lisp level, as that's
1591 easy, and leaves room for future OS improvements.
1592
1593 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1594 (LIBES): Use it.
1595
1596 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1597 Don't get current time unless it's needed.
1598
1599 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1600 now provides it if it's absent.
1601 (start_atimer): Port to higher-res time stamps.
1602 Check for time stamp overflow. Don't get current time more
1603 often than is needed.
1604
1605 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1606 Include systime.h, not time.h.
1607 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1608
1609 * dired.c: Include stat-time.h.
1610 (Ffile-attributes): File times now have higher resolution.
1611
1612 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1613 (struct image): Timestamp now has higher resolution.
1614
1615 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1616 has at least microseconds now. All uses removed.
1617 (update_frame, update_single_window, update_window, update_frame_1)
1618 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1619
1620 * editfns.c (time_overflow): Now extern.
1621 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1622 (float-time, Fformat_time_string, Fcurrent_time_string)
1623 (Fcurrent_time_zone): Accept and generate higher-resolution
1624 time stamps.
1625 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1626 (decode_time_components, lisp_seconds_argument): New functions.
1627 (make_time): Now static.
1628 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1629 Report an error if the time is invalid, rather than having the caller
1630 do that.
1631
1632 * fileio.c: Include <stat-time.h>
1633 (Fcopy_file): Copy higher-resolution time stamps.
1634 Prefer to set the time stamp via a file descriptor if that works.
1635 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1636 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1637 (Fvisited_file_modtime, Fset_visited_file_modtime):
1638 Support higher-resolution time stamps.
1639
1640 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1641
1642 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1643
1644 * image.c (prepare_image_for_display, clear_image_cache)
1645 (lookup_image): Port to higer-resolution time stamps.
1646
1647 * keyboard.c (start_polling, bind_polling_period):
1648 Check for time stamp overflow.
1649 (read_char, kbd_buffer_get_event, timer_start_idle)
1650 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1651 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1652 Port to higher-resolution time stamps. Do not assume time_t is signed.
1653 (decode_timer): New function. Timers are now vectors of length 9,
1654 not 8, to accommodate the picosecond component.
1655 (timer_check_2): Use it.
1656
1657 * nsterm.m (select_timeout, timeval_subtract): Remove.
1658 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1659 as they're a bit more accurate and handle overflow better.
1660 (ns_select): Change prototype to be compatible with pselect.
1661 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1662 * nsterm.h (ns_select): Adjust prototype.
1663
1664 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1665 us-resolution time stamps.
1666 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1667
1668 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1669
1670 * lisp.h (time_overflow): New decl.
1671 (wait_reading_process_output): First arg is now intmax_t, not int,
1672 to accommodate larger waits.
1673
1674 * process.h (struct Lisp_Process.read_output_delay):
1675 Now counts nanoseconds, not microseconds.
1676 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1677 EMACS_HAS_USECS.
1678 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1679 (wait_reading_process_output):
1680 Port to ns-resolution time stamps.
1681 (Faccept_process_output, wait_reading_process_output):
1682 Check for time stamp overflow. Do not assume time_t is signed.
1683 (select_wrapper): Remove; we now use pselect.
1684 (Fprocess_attributes): Now generates ns-resolution time stamps.
1685
1686 * sysdep.c: Include utimens.h. Don't include utime.h
1687 or worry about struct utimbuf; gnulib does that for us now.
1688 (gettimeofday): Remove; gnulib provides a substitute.
1689 (make_timeval): New function.
1690 (set_file_times): Now sets ns-resolution time stamps.
1691 New arg FD; all uses changed.
1692 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1693 (system_process_attributes):
1694 Now returns ns-resolution time stamp. All uses changed.
1695 Check for time stamp overflow.
1696
1697 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1698 provides a substitute now.
1699
1700 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1701 since it guarantees struct timespec.
1702 (EMACS_TIME): Now struct timespec, so that we can support
1703 ns-resolution time stamps.
1704 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1705 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1706 (EMACS_USECS): Remove.
1707 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1708 so multiply the arg by 1000 before storing it.
1709 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1710 New macros.
1711 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1712 Port to ns-resolution time stamps.
1713 (EMACS_TIME_NEG_P): Remove; replaced by....
1714 (EMACS_TIME_SIGN): New macro.
1715 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1716 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1717 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1718 (make_timeval, make_lisp_time, decode_time_components): New decls.
1719 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1720 that it mishandled time_t overflow. You can't compare by subtracting!
1721 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1722 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1723
1724 * term.c: Include <sys/time.h>.
1725 (timeval_to_Time): New function, for proper overflow wraparound.
1726 (term_mouse_position, term_mouse_click): Use it.
1727
1728 * undo.c (record_first_change): Support higher-resolution time stamps
1729 in the undo buffer.
1730 (Fprimitive_undo): Use them when restoring time stamps.
1731
1732 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1733 (w32_get_internal_run_time):
1734 Port to higher-resolution Emacs time stamps.
1735 (ltime): Now accepts single 64-bit integer, as that's more convenient
1736 for callers.
1737
1738 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1739
1740 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1741 for compatibility with pselect. Support ns-resolution time stamps.
1742
1743 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1744
1745 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1746 Check for time stamp overflow, and support ns-resolution time stamps.
1747
1748 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1749 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1750 (timeval_subtract): Remove; no longer needed.
1751 (XTflash, XTring_bell, x_wait_for_event):
1752 Port to ns-resolution time stamps. Don't assume time_t is signed.
1753
b6a92dfe
CY
17542012-06-22 Chong Yidong <cyd@gnu.org>
1755
1756 * xdisp.c (x_consider_frame_title): Revert last change.
1757
d251c37c
EZ
17582012-06-22 Eli Zaretskii <eliz@gnu.org>
1759
1760 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1761 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1762 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1763 staticidx goes up to 1597 out of 1600 = 0x640.)
1764
f10deafb
PE
17652012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1766
1767 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1768 Otherwise, the umask might be mistakenly 0 while handling input signals.
1769
ec6de1e2
SM
17702012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1771
1772 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1773
28be1ada
DA
17742012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1775
1776 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1777 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1778 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1779 access to `contents' member of Lisp_Vector objects with AREF and ASET
1780 where appropriate.
1781
c6bf3022
CY
17822012-06-19 Chong Yidong <cyd@gnu.org>
1783
1784 * frame.c (delete_frame): When selecting a frame on a different
1785 text terminal, do not alter the terminal's top-frame.
1786
1787 * xdisp.c (format_mode_line_unwind_data): Record the target
1788 frame's selected window and its terminal's top-frame.
1789 (unwind_format_mode_line): Restore them.
1790 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1791 Callers changed.
1792 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1793 since tty frames can be explicitly named.
1794 (prepare_menu_bars): Likewise.
1795
1796 * term.c (Ftty_top_frame): New function.
1797
defd4196
PE
17982012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1799
1800 Port byte-code-meter to modern targets.
1801 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1802 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1803 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1804 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1805 (METER_1, METER_2): Simplify.
1806
1053a871
SM
18072012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1808
1809 * data.c (Fdefalias): Return `symbol' (bug#11686).
1810
b7e8d081
MR
18112012-06-18 Martin Rudalics <rudalics@gmx.at>
1812
1813 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1814 gets killed during executing of this function (Bug#11665).
1815 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1816 (Vkill_buffer_query_functions): In doc-string say that functions
1817 run by this hook should not change the current buffer.
1818
7ea2b339
PE
18192012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1820
1821 Fix recently-introduced process.c problems found by static checking.
1822 * process.c (write_queue_push, write_queue_pop, send_process):
1823 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1824 (write_queue_pop): Fix pointer signedness problem.
1825 (send_process): Remove unused local.
1826
96a313a1
CY
18272012-06-17 Chong Yidong <cyd@gnu.org>
1828
1829 * xdisp.c (redisplay_internal): No need to redisplay terminal
1830 frames that are not on top.
1831
20ca2e94
TN
18322012-06-17 Troels Nielsen <bn.troels@gmail.com>
1833
1834 * process.c (make_process): Initialize write_queue.
1835 (write_queue_push, write_queue_pop): New functions.
1836 (send_process): Use them to maintain correct ordering of process
1837 writes (Bug#10815).
1838
9a900ca9
PE
18392012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1840
310fbfa8
PE
1841 * lisp.h (eassert): Assume C89 or later.
1842 This removes the need for CHECK.
1843 (CHECK): Remove. Its comments about always evaluating its
1844 argument were confusing, as 'eassert' typically does not evaluate
1845 its argument.
1846
27bb1ca4
PE
1847 * coding.c (produce_chars): Use ptrdiff_t, not int.
1848
9a900ca9
PE
1849 * xterm.c (x_draw_underwave): Check for integer overflow.
1850 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1851
41b7f8bc 18522012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1853
1854 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1855 referenced (Bug#11583).
1856
9b0e3eba
AA
18572012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1858
1859 Implement wave-style variant of underlining.
1860 * dispextern.h (face_underline_type): New enum.
1861 (face): Add field for underline type.
1862 * nsterm.m (ns_draw_underwave): New function.
1863 (ns_draw_text_decoration): Use it.
1864 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1865 New functions.
1866 (x_draw_glyph_string): Use them.
1867 * xfaces.c (Qline, Qwave): New Lisp objects.
1868 (check_lface_attrs, merge_face_ref)
1053a871
SM
1869 (Finternal_set_lisp_face_attribute, realize_x_face):
1870 Handle wave-style underline face attributes.
9b0e3eba
AA
1871 * xterm.c (x_draw_underwave): New function.
1872 (x_draw_glyph_string): Use it.
1873
0fb52f11
JB
18742012-06-16 Juanma Barranquero <lekktu@gmail.com>
1875
1876 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1877 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1878 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1879 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1880 ($(BLD)/w32select.$(O)): Update dependencies.
1881
e5560ff7
AS
18822012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1883
1884 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1885 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1886 * character.c (_fetch_multibyte_char_p): Remove.
1887 * alloc.c: Include "character.h" before "buffer.h".
1888 * bidi.c: Likewise.
1889 * buffer.c: Likewise.
1890 * bytecode.c: Likewise.
1891 * callint.c: Likewise.
1892 * callproc.c: Likewise.
1893 * casefiddle.c: Likewise.
1894 * casetab.c: Likewise.
1895 * category.c: Likewise.
1896 * cmds.c: Likewise.
1897 * coding.c: Likewise.
1898 * composite.c: Likewise.
1899 * dired.c: Likewise.
1900 * dispnew.c: Likewise.
1901 * doc.c: Likewise.
1902 * dosfns.c: Likewise.
1903 * editfns.c: Likewise.
1904 * emacs.c: Likewise.
1905 * fileio.c: Likewise.
1906 * filelock.c: Likewise.
1907 * font.c: Likewise.
1908 * fontset.c: Likewise.
1909 * fringe.c: Likewise.
1910 * indent.c: Likewise.
1911 * insdel.c: Likewise.
1912 * intervals.c: Likewise.
1913 * keyboard.c: Likewise.
1914 * keymap.c: Likewise.
1915 * lread.c: Likewise.
1916 * macros.c: Likewise.
1917 * marker.c: Likewise.
1918 * minibuf.c: Likewise.
1919 * nsfns.m: Likewise.
1920 * nsmenu.m: Likewise.
1921 * print.c: Likewise.
1922 * process.c: Likewise.
1923 * regex.c: Likewise.
1924 * region-cache.c: Likewise.
1925 * search.c: Likewise.
1926 * syntax.c: Likewise.
1927 * term.c: Likewise.
1928 * textprop.c: Likewise.
1929 * undo.c: Likewise.
1930 * unexsol.c: Likewise.
1931 * w16select.c: Likewise.
1932 * w32fns.c: Likewise.
1933 * w32menu.c: Likewise.
1934 * window.c: Likewise.
1935 * xdisp.c: Likewise.
1936 * xfns.c: Likewise.
1937 * xmenu.c: Likewise.
1938 * xml.c: Likewise.
1939 * xselect.c: Likewise.
1940
2f07e6af
EZ
19412012-06-16 Eli Zaretskii <eliz@gnu.org>
1942
1053a871
SM
1943 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1944 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1945 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1946 row.
1947 (handle_face_prop): Use chunk-relative overlay string index when
1948 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1949 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1950 the rightmost. (Bug#11720)
2f07e6af 1951
29b83cec
AS
19522012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1953
1954 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1955 (CATEGORY_MEMBER): Enforce 1/0 value.
1956 * category.c (_temp_category_set): Remove.
1957
4c5501e9
EZ
19582012-06-16 Eli Zaretskii <eliz@gnu.org>
1959
1960 * window.c (Fdelete_other_windows_internal)
1961 (Fdelete_window_internal): Don't access frame's mouse highlight
1962 info of the initial frame. (Bug#11677)
1963
2b570124
PE
19642012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1965
e93864f9
PE
1966 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1967 Assume USE_2_TAGS_FOR_INTS.
1968 (xreload): Adjust $tagmask width to match recent lisp.h change.
1969
2b570124
PE
1970 Simplify lisp.h in minor ways that should not affect code.
1971 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1972 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1973 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1974 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1975 (INTTYPEBITS): New macro, for clarity.
1976 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1977 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1978 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1979 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1980 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1981
81755f69
JB
19822012-06-13 Juanma Barranquero <lekktu@gmail.com>
1983
1984 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1985
16192a57
GM
19862012-06-13 Glenn Morris <rgm@gnu.org>
1987
1988 * s/bsd-common.h (BSD4_3):
1989 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1990
646b5f55
AS
19912012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1992
1993 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1994 instead of union.
1995 (XLI, XIL): Define.
1053a871
SM
1996 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1997 Use them.
1998 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1999 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2000 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2001 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2002 * frame.c (delete_frame): Remove outdated comment.
2003 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2004 USE_LISP_UNION_TYPE.
2005 (Fw32_unregister_hot_key): Likewise.
2006 (Fw32_toggle_lock_key): Likewise.
2007 * w32menu.c (add_menu_item): Likewise.
2008 (w32_menu_display_help): Use XIL instead of checking
2009 USE_LISP_UNION_TYPE.
2010 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2011 (init_heap): Likewise.
2012 * w32term.c (w32_read_socket): Update comment.
2013
1d3823c9
GM
20142012-06-13 Glenn Morris <rgm@gnu.org>
2015
c62ff706
GM
2016 * s/usg5-4-common.h, src/s/unixware.h:
2017 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2018
1d3823c9
GM
2019 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2020
bfe3e0a2
PE
20212012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2022
2023 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2024 * alloc.c (make_number) [!defined make_number]:
2025 Remove, as lisp.h always defines this now.
2026 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2027 (roundup_size): Verify that it is a power of 2.
2028 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2029 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2030 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2031 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2032 USE_LSB_TAG now is always defined to be either 0 or 1.
2033 All uses changed.
2034 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2035 code works fine either way, and efficiency is not a concern here,
2036 as the union type is for debugging, not for production.
2037 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2038 Use an inline function on all platforms when using the union type,
2039 since this is simpler and 'static inline' can be used portably
2040 within Emacs now.
2041 (LISP_INITIALLY_ZERO): New macro.
2042 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2043 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2044
45fa9c0f
GM
20452012-06-12 Glenn Morris <rgm@gnu.org>
2046
b4492cba
GM
2047 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2048
2049 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2050
45fa9c0f
GM
2051 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2052 Move BROKEN_SIGIO to configure.
2053
2054 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2055 Move NO_TERMIO to configure.
2056
0e25d334
CY
20572012-06-12 Chong Yidong <cyd@gnu.org>
2058
2059 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2060 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2061 MagickExportImagePixels is undefined.
2062
43682bb6
PE
20632012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2064
2065 * image.c (imagemagick_load_image): Remove unused label.
2066
a9be7d2b
GM
20672012-06-11 Glenn Morris <rgm@gnu.org>
2068
2069 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2070 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2071 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2072 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2073
3017f87f
SM
20742012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2075
2076 * alloc.c (make_byte_code): New function.
2077 (Fmake_byte_code): Use it. Don't purify here.
2078 * lread.c (read1): Use it as well to avoid extra allocation.
2079
1b9b4cf4
CY
20802012-06-11 Chong Yidong <cyd@gnu.org>
2081
2082 * image.c (imagemagick_load_image): Implement transparency.
2083
95988fcf
AS
20842012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2085
2086 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2087 account for preceding backslashes. (Bug#11663)
2088
cd4eb164
CY
20892012-06-09 Chong Yidong <cyd@gnu.org>
2090
2091 * term.c: Support italics in capable terminals (Bug#9652).
2092 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2093 (turn_on_face): Output using TS_enter_italic_mode if available.
2094 Don't handle unused blinking and alt-charset cases.
2095 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2096 and tty_alt_charset_p cases.
2097 (tty_capable_p, init_tty): Support italics.
2098
2099 * termchar.h (struct tty_display_info): Add field for italics.
2100 Remove unused blink field.
2101
2102 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2103 Handle slant.
2104
2105 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2106 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2107 tty_alt_charset_p. Add tty_italic_p.
2108
ff88beb8
MA
21092012-06-09 Michael Albinus <michael.albinus@gmx.de>
2110
2111 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2112 dbus_type_is_basic if available.
2113 (xd_extract_signed, xd_extract_unsigned): Rename from
2114 extract_signed and extract_unsigned, respectively. Adapt callers.
2115
44286096
CY
21162012-06-09 Chong Yidong <cyd@gnu.org>
2117
1682701f
CY
2118 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2119
44286096
CY
2120 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2121 case (Bug#9752).
2122
d86feb17
PE
21232012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2124
2125 * xdisp.c (vmessage): Treat frame message as multibyte.
2126 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2127 would generate the diagnostic "Making \302\247 buffer-local while
2128 let-bound!".
2129
d5c20fe8
EZ
21302012-06-08 Eli Zaretskii <eliz@gnu.org>
2131
2132 * dispnew.c (showing_window_margins_p): Undo last change, which
2133 was done due to an inadvertent commit.
2134 (adjust_frame_glyphs_for_frame_redisplay): Do call
2135 showing_window_margins_p.
2136
513749ee
SM
21372012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2138
2139 * eval.c (Fmake_var_non_special): New primitive.
2140 (syms_of_eval): Defsubr it.
2141 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2142
d4a8f5c1
JB
21432012-06-08 Juanma Barranquero <lekktu@gmail.com>
2144
2145 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2146 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2147
8bbbc977
EZ
21482012-06-08 Eli Zaretskii <eliz@gnu.org>
2149
2150 * alloc.c (allocate_vectorlike): Fix last change.
2151
f3372c87
DA
21522012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2153
2154 Block-based vector allocation of small vectors.
2155 * lisp.h (struct vectorlike_header): New field `nbytes',
2156 adjust comment accordingly.
2157 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2158 to denote vector blocks. Adjust users (live_vector_p,
2159 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2160 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2161 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2162 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2163 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2164 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2165 (roundup_size): New constant.
2166 (struct vector_block): New data type.
2167 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2168 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2169 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2170 (sweep_vectors): New functions.
2171 (allocate_vectorlike): Return `zero_vector' as the only vector of
2172 0 items. Allocate new vector from block if vector size is less than
2173 or equal to VBLOCK_BYTES_MAX.
2174 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2175 (init_alloc_once): Add call to init_vectors.
2176
4f18a4ed
SM
21772012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2178
2179 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2180
86f158bc
PE
21812012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2182
2183 * doprnt.c (doprnt): Truncate multibyte char correctly.
2184 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2185 would mishandle a string argument "Xc" if X was a multibyte
2186 character of length 2: it would truncate after X's first byte
2187 rather than including all of X.
2188
c5cfcbe0
CY
21892012-06-06 Chong Yidong <cyd@gnu.org>
2190
2191 * buffer.c (word_wrap): Doc fix.
2192
c05cf390
PE
21932012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2194
2195 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2196
0c3461de
GM
21972012-06-03 Glenn Morris <rgm@gnu.org>
2198
2199 * xdisp.c (tool-bar-style): Doc fix.
2200
c71232db
UM
22012012-06-03 Ulrich Müller <ulm@gentoo.org>
2202
2203 * Makefile.in (PAXCTL): Define.
2204 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2205 binary via PaX flags if the paxctl utility is available.
2206 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2207 Restore PaX flags to their default. (Bug#11398)
2208
383f7350
CY
22092012-06-03 Chong Yidong <cyd@gnu.org>
2210
2211 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2212 buffer (Bug#11226).
2213
5f2c76c6
CY
22142012-06-03 Chong Yidong <cyd@gnu.org>
2215
2216 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2217 (note_mode_line_or_margin_highlight): If there is no help echo,
2218 use mode-line-default-help-echo. Handle the case where the mouse
2219 position is past the end of the mode line string.
2220
2221 * buffer.c (buffer_local_value_1): New function, split from
2222 Fbuffer_local_value; can return Qunbound.
2223 (Fbuffer_local_value): Use it.
2224 (Vmode_line_format): Docstring tweaks.
2225
773d47f6
PE
22262012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2227
2228 * sysdep.c (system_process_attributes): Improve comment.
2229
f2d6a3df
SM
22302012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2231
2232 * keyboard.c: Export real-this-command to Elisp.
2233 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2234 and DEFVAR it. Update all users.
2235
63810350
PE
22362012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2237
7bd5c1f4
PE
2238 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2239
63810350
PE
2240 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2241 Convert pctcpu and pctmem to Lisp float properly.
2242 Let the compiler fold better, as 100.0/0x8000 is exact.
2243
a2821611
AS
22442012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2245
2246 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2247 cons_block.
2248
5fceba1d
PE
22492012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2250
2251 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2252
c98ff5dd
DA
22532012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2254
2255 For a 'struct window', replace some Lisp_Object fields to
2256 bitfields where appropriate, remove unused fields.
2257 * window.h (struct window): Remove unused 'last_mark_x' and
2258 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2259 change it's type from Lisp_Object to bitfield.
2260 Change type of 'force_start', 'optional_new_start',
2261 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2262 fields from Lisp_Object to bitfield. Adjust users accordingly.
2263
ca34e0be
PE
22642012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2265
2266 Pacify gcc -Wdouble-precision when using Xaw.
2267 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2268 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2269 Use 'float' consistently, rather than 'float' in most places
2270 and 'double' in a couple of places.
2271
efc00ab1 22722012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2273
2274 * xdisp.c (handle_stop): Detect whether we have overlay strings
2275 loaded by testing it->current.overlay_string_index to be
2276 non-negative, instead of checking whether n_overlay_strings is
2277 positive. (Bug#11587)
2278
efc00ab1 22792012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2280
2281 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2282
2283 * doc.c (Fsubstitute_command_keys): Doc fix.
2284
efc00ab1 22852012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2286
2287 * search.c (search_buffer): Remove calls to
2288 r_alloc_inhibit_buffer_relocation, as it is now called by
2289 maybe_unify_char, which was the cause of relocation of buffer text
2290 in bug#11519.
2291
efc00ab1 22922012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2293
2294 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2295 for the duration of call to load_charset, to avoid problems with
2296 callers of maybe_unify_char that access buffer text through C
2297 pointers.
2298
2299 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2300 decrement the inhibition flag, instead of just setting or
2301 resetting it.
2302
ba93a187
PE
23032012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2304
2305 Remove obsolete '#define static' cruft.
2306 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2307 This #undef was "temporary" in 2000; it is no longer needed
2308 now that '#define static' has gone away.
2309 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2310 (gray_bitmap_bits): Remove; no longer needed.
2311 All uses replaced with definiens.
2312 * xterm.c: Include "bitmaps/gray.xbm".
2313
9e4bf381
PE
23142012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2315
2316 Clean up __executable_start, monstartup when --enable-profiling.
2317 The following changes affect the code only when profiling.
2318 * dispnew.c (__executable_start): Rename from safe_bcopy.
2319 Define only on platforms that need it.
2320 * emacs.c: Include <sys/gmon.h> when profiling.
2321 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2322 (__executable_start): Remove decl, since lisp.h does it now.
2323 (safe_bcopy): Remove decl; no longer has that name.
2324 (main): Coalesce #if into single bit of code, for simplicity.
2325 Cast pointers to uintptr_t, since standard libraries want integers
2326 and not pointers.
2327 * lisp.h (__executable_start): New decl.
2328
32d72c2f
GM
23292012-05-31 Glenn Morris <rgm@gnu.org>
2330
2331 * image.c (Fimagemagick_types): Doc fix.
2332
baac5bc7
JM
23332012-05-30 Jim Meyering <meyering@redhat.com>
2334
2335 * callproc.c (Fcall_process_region): Include directory component
2336 in mkstemp error message (Bug#11586).
2337
72cb32cf
PE
23382012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2339
2340 * alloc.c, lisp.h (make_pure_vector): Now static.
2341
61b108cc
SM
23422012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2343
2344 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2345 Move to byte-run.el.
2346 (Fautoload): Do the hash-doc more carefully.
2347 * data.c (Fdefalias): Purify definition, except for keymaps.
2348 (Qdefun): Move from eval.c.
2349 * lisp.h (Qdefun): Remove.
2350 * lread.c (read1): Tiny simplification.
2351
471fe23d
TN
23522012-05-29 Troels Nielsen <bn.troels@gmail.com>
2353
934f3f58 2354 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2355 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2356 Bug#9642, but explicitly check that the buffer the overlay would
2357 be moved to is live and rearrange lines to make sure that errors
2358 will not put the overlay in an inconsistent state.
2359 (Fdelete_overlay): Cosmetics.
2360
85d0efd1
EZ
23612012-05-28 Eli Zaretskii <eliz@gnu.org>
2362
2363 * w32term.c (my_bring_window_to_top): New function.
2364 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2365 could be different from the original one.
2366 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2367 (Bug#11513)
2368
2369 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2370 by calling BringWindowToTop.
2371
2372 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2373 (WM_EMACS_END): Increase by one.
2374
da92a98c
PE
23752012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2376
2377 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2378 This avoids undefined behavior that might cause the eassert
2379 to not catch an out-of-range value.
2380
74d1f848
JB
23812012-05-28 Juanma Barranquero <lekktu@gmail.com>
2382
2383 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2384 Update dependencies.
2385
9e1a06fc
EZ
23862012-05-27 Eli Zaretskii <eliz@gnu.org>
2387
2388 * bidi.c (bidi_mirror_char): Fix last change.
2389
f3dd7312
AS
23902012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2391
2392 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2393 when referring to sectname field in printf format.
2394
81899c91
PE
23952012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2396
57b81a9f
PE
2397 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2398 Only r_alloc_inhibit_buffer_relocation needed to be added;
2399 the others were already declared.
2400
81899c91
PE
2401 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2402 before checking whether it's out of range. Put the check inside
2403 eassert. See
2404 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2405
33017faf 24062012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2407
2408 * callproc.c (Fcall_process): Restore a line that was accidentally
2409 commented out in the 2011-02-13 change (bug#11547).
2410
33017faf 24112012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2412
2413 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2414 defined on ralloc.c.
2415
2416 * buffer.c [REL_ALLOC]: Remove prototypes of
2417 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2418 they are now on lisp.h.
2419
2420 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2421
2422 * search.c (search_buffer): Use it to inhibit relocation of buffer
2423 text while re_search_2 is doing its job, because re_search_2 is
2424 passed C pointers to buffer text. (Bug#11519)
2425
23415acf
EZ
2426 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2427 Update value to 24.
2428
44e27368
EZ
2429 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2430 state after an additional call to move_it_in_display_line_to, keep
2431 the values of it->max_ascent and it->max_descent found for the
2432 entire line.
2433 (pos_visible_p): Revert the comparison against bottom_y to what it
2434 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2435 (Bug#11464)
2436
c1892f11
PE
24372012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2438
2439 Fix coding-related core dumps with gcc -ftrapv.
2440 The code was computing A - B, where A and B are pointers, and B is
2441 random garbage. This can lead to core dumps on platforms that
2442 have special pointer registers, and it also leads to core dumps on
2443 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2444 A - B only when B is initialized properly.
2445 * coding.c (coding_set_source, coding_set_destination): Return void.
2446 (coding_change_source, coding_change_destinations): New functions,
2447 with the old behaviors of coding_set_source and coding_set_destination.
2448 All callers that need an offset changed to use these new functions.
2449
eb7afdad
GM
24502012-05-26 Glenn Morris <rgm@gnu.org>
2451
2452 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2453
f12fdf02
EZ
24542012-05-26 Eli Zaretskii <eliz@gnu.org>
2455
53a63be6 2456 Extend mouse support on W32 text-mode console.
61b108cc
SM
2457 * xdisp.c (draw_row_with_mouse_face):
2458 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2459
eb3f6f01 2460 * w32console.c: Include window.h.
61b108cc
SM
2461 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2462 New functions.
eb3f6f01
EZ
2463 (initialize_w32_display): Initialize mouse-highlight data.
2464
53a63be6
EZ
2465 * w32inevt.c: Include termchar.h and window.h.
2466 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2467 moves, call note_mouse_highlight. If help_echo changed, call
2468 gen_help_event to produce help-echo message in the echo area.
2469 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2470 highlight info.
2471
4cfd81f6
PE
24722012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2473
2474 * lread.c (read1): Simplify slightly to avoid an overflow warning
2475 with GCC 4.7.0 on x86-64.
2476
4446092a
EZ
24772012-05-26 Eli Zaretskii <eliz@gnu.org>
2478
2479 * bidi.c (bidi_mirror_char): Revert last change: an int is
2480 definitely wide enough here.
2481
42b2a986 24822012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2483
42b2a986 2484 Fix integer width and related bugs (Bug#9874).
eb106a49 2485 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2486 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2487 (string_bytes, check_sblock, allocate_string_data):
2488 (compact_small_strings, Fmake_bool_vector, make_string)
2489 (make_unibyte_string, make_multibyte_string)
2490 (make_string_from_bytes, make_specified_string)
2491 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2492 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2493 (mark_vectorlike):
2494 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2495 (allocate_pseudovector):
2496 Use int, not EMACS_INT, where int is wide enough.
2497 (inhibit_garbage_collection, Fgarbage_collect):
2498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2499 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2500 int might not be wide enough.
2501 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2502 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2503 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2504 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2505 (bidi_level_of_next_char, bidi_move_to_visually_next):
2506 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2507 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2508 (Fkill_buffer, Fset_buffer_major_mode)
2509 (advance_to_char_boundary, Fbuffer_swap_text)
2510 (Fset_buffer_multibyte, overlays_at, overlays_in)
2511 (overlay_touches_p, struct sortvec, record_overlay_string)
2512 (overlay_strings, recenter_overlay_lists)
2513 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2514 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2515 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2516 (Foverlay_recenter, last_overlay_modification_hooks_used)
2517 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2519 (validate_region): Omit unnecessary test for b <= e,
2520 since that's guaranteed by the previous test.
d311d28c
PE
2521 (adjust_overlays_for_delete): Avoid pos + length overflow.
2522 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2523 (report_overlay_modification):
2524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2525 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2526 Omit pointer cast, which isn't needed anyway, and doesn't work
2527 after the EMACS_INT -> ptrdiff_t change.
02481186 2528 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2529 * buffer.h: Adjust decls to match defn changes elsewhere.
2530 (struct buffer_text, struct buffer):
2531 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2532 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2533 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2534 not int, to avoid needless 32-bit limit on 64-bit hosts.
2535 (exec_byte_code): Use tighter memory-full test, one that checks
2536 for alloca overflow. Don't compute the address of the object just
2537 before an array, as that's not portable. Use EMACS_INT, not
2538 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2539 * callint.c (Fcall_interactively):
2540 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2541 * callproc.c (call_process_kill, Fcall_process):
2542 Don't assume pid_t fits into an Emacs fixnum.
2543 (call_process_cleanup, Fcall_process, child_setup):
2544 Don't assume pid_t fits into int.
2545 (call_process_cleanup, Fcall_process, delete_temp_file)
2546 (Fcall_process_region):
2547 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2548 (Fcall_process): Simplify handling of volatile integers.
2549 Use int, not EMACS_INT, where int will do.
2550 * casefiddle.c (casify_object, casify_region, operate_on_word)
2551 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2552 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2553 (casify_object): Avoid integer overflow when overallocating buffer.
2554 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2555 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2556 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2557 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2558 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2559 integers are now checked earlier. All uses replaced with XINT.
2560 (ccl_driver):
2561 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2562 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2563 (ccl_driver, Fregister_code_conversion_map):
2564 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2565 (resolve_symbol_ccl_program): Check that vector header is in range.
2566 Always copy the vector, so that we can check its contents reliably
2567 now rather than having to recheck each instruction as it's being
2568 executed. Check that vector words fit in 'int'.
2569 (ccl_get_compiled_code, Fregister_ccl_program)
2570 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2571 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2572 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2573 contents are in range.
2574 (Fccl_execute_on_string): Check that status is in range.
2575 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2576 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2577 Accept and return EMACS_INT, not int, because callers can pass values
2578 out of 'int' range.
2579 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2580 (multibyte_chars_in_text, parse_str_as_multibyte)
2581 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2582 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2583 (string_escape_byte8, Fget_byte):
2584 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2585 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2586 avoid mishandling large integers.
2587 * character.h: Adjust decls to match defn changes elsewhere.
2588 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2589 (Ffind_charset_region):
2590 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2591 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2592 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2593 Don't assume fixnum fits in int.
d311d28c
PE
2594 (load_charset_map_from_vector, Fmap_charset_chars):
2595 Remove now-unnecessary CHECK_NATNUMs.
2596 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2597 Don't rely on undefined behavior with signed left shift overflow.
2598 Don't assume unsigned int fits into fixnum, or that fixnum fits
2599 into unsigned int. Don't require max_code to be a valid fixnum;
2600 that's not true for gb10830 4-byte on a 32-bit host. Allow
2601 invalid_code to be a cons, for the same reason. Require code_offset
2602 to be a character. Avoid int overflow if max_char is close
2603 to INT_MAX.
2604 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2605 this is intended anyway and avoids some undefined behavior.
2606 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2607 INDEX_TO_CODE_POINT, as that's what it expects.
2608 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2609 * charset.h (DECODE_CHAR): Return int, not unsigned;
2610 this is what was intended anyway, and it avoids undefined behavior.
2611 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2612 integer-overflow issues.
2613 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2614 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2615 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2616 * chartab.c (Fmake_char_table, Fset_char_table_range)
2617 (uniprop_get_decoder, uniprop_get_encoder):
2618 Don't assume fixnum fits in int.
2619 * cmds.c (move_point): New function, that does the gist of
2620 Fforward_char and Fbackward_char, but does so while checking
2621 for integer overflow more accurately.
c96e5d6a 2622 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2623 (Fforward_line, Fend_of_line, internal_self_insert)
2624 (internal_self_insert):
2625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2626 Fix a FIXME, by checking for integer overflow when calculating
2627 target_clm and actual_clm.
2628 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2629 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2630 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2631 (coding_alloc_by_making_gap, alloc_destination)
2632 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2633 (encode_coding_utf_16, detect_coding_emacs_mule)
2634 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2635 (detect_coding_iso_2022, decode_coding_iso_2022)
2636 (encode_invocation_designation, encode_designation_at_bol)
2637 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2638 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2639 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2640 (encode_coding_ccl, encode_coding_raw_text)
2641 (detect_coding_charset, decode_coding_charset)
2642 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2643 (produce_composition, produce_charset, produce_annotation)
2644 (decode_coding, handle_composition_annotation)
2645 (handle_charset_annotation, consume_chars, decode_coding_gap)
2646 (decode_coding_object, encode_coding_object, detect_coding_system)
2647 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2648 (code_convert_region, code_convert_string)
8f50130c
PE
2649 (Fdefine_coding_system_internal)
2650 (coding_set_source, coding_set_destination):
d311d28c
PE
2651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2652 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2653 (Fdefine_coding_system_internal):
2654 Don't assume fixnums fit in int.
2655 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2656 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2657 (Funencodable_char_position, Fcheck_coding_systems_region)
2658 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2660 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2661 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2662 Don't access memory outside of the args array.
d311d28c 2663 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2664 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2665 result of ENCODE_CHAR.
d311d28c
PE
2666 * coding.h: Adjust decls to match defn changes elsewhere.
2667 (struct coding_system):
2668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2669 * composite.c (get_composition_id, find_composition)
2670 (run_composition_function, update_compositions)
2671 (compose_text, composition_gstring_put_cache)
2672 (composition_gstring_p, composition_gstring_width)
2673 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2674 (composition_compute_stop_pos, composition_reseat_it)
2675 (composition_update_it, struct position_record)
2676 (find_automatic_composition, composition_adjust_point)
2677 (Fcomposition_get_gstring, Ffind_composition_internal):
2678 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2679 (update_compositions):
2680 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2681 * composite.h: Adjust decls to match defn changes elsewhere.
2682 (struct composition):
2683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2684 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2685 Do not attempt to compute the address of the object just before a
2686 buffer; this is not portable.
2687 (Faref, Faset):
2688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2689 (Faset): Use int, not EMACS_INT, where int is wide enough.
2690 (Fstring_to_number): Don't assume fixnums fit in int.
2691 (Frem): Don't assume arg is nonnegative.
2692 * dbusbind.c (xd_append_arg): Check for integers out of range.
2693 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2694 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2695 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2696 (xd_get_connection_references): Return ptrdiff_t, not int.
2697 All uses changed.
2698 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2699 (xd_read_message_1):
2700 Use int, not unsigned, where the dbus API uses int.
2701 (Fdbus_message_internal): Don't overflow mtype.
2702 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2703 * dired.c (directory_files_internal, file_name_completion, scmp)
2704 (file_name_completion_stat):
2705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2706 (file_name_completion): Don't overflow matchcount.
2707 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2708 * dispextern.h: Adjust decls to match defn changes elsewhere.
2709 (struct text_pos, struct glyph, struct bidi_saved_info)
2710 (struct bidi_string_data, struct bidi_it, struct composition_it)
2711 (struct it):
2712 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2713 (struct display_pos, struct composition_it, struct it):
2714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2715 * dispnew.c (increment_matrix_positions)
2716 (increment_row_positions, mode_line_string)
2717 (marginal_area_string):
2718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2719 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2720 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2721 (duration_to_sec_usec): New function, to check for overflow better.
2722 (Fsleep_for, sit_for): Use it.
2723 * doc.c (get_doc_string, store_function_docstring):
2724 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2725 (get_doc_string, Fsnarf_documentation):
2726 Use int, not EMACS_INT, where int is wide enough.
2727 (get_doc_string):
2728 Use SAFE_ALLOCA, not alloca.
2729 Check for overflow when converting EMACS_INT to off_t.
2730 * doprnt.c (doprnt):
2731 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2732 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2733 Don't assume uid_t fits into fixnum.
2734 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2735 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2736 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2737 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2738 (general_insert_function)
2739 (Finsert_char, make_buffer_string, make_buffer_string_both)
2740 (update_buffer_properties, Fbuffer_substring)
2741 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2742 (Fsubst_char_in_region, check_translation)
2743 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2744 (transpose_markers, Ftranspose_regions):
2745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2746 (clip_to_bounds): Move to lisp.h as an inline function).
2747 (Fconstrain_to_field): Don't assume integers are nonnegative.
2748 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2749 (Fsubst_char_in_region, Fsave_restriction):
2750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2751 (Femacs_pid): Don't assume pid_t fits into fixnum.
2752 (lo_time): Use int, not EMACS_INT, when int suffices.
2753 (lisp_time_argument): Check for usec out of range.
2754 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2755 (Fuser_login_name, Fuser_full_name): Signal an error
2756 if a uid argument is out of range, rather than relying on
2757 undefined behavior.
c8d5c857
PE
2758 (Fformat_time_string): Remove now-unnecessary check.
2759 lisp_time_argument checks for out-of-range usec now.
243e0530 2760 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2761 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2762 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2763 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2764 (init_cmdargs, Fdump_emacs):
2765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2766 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2767 the bottom (typically) 32 bits of the fixnum.
2768 * eval.c (specpdl_size, call_debugger):
2769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2770 (when_entered_debugger, Fbacktrace_debug):
2771 Don't assume fixnum can fit in int.
2772 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2773 the object just before a buffer; this is not portable.
2774 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2775 (grow_specpdl, unbind_to):
2776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2777 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2778 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2779 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2780 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2781 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2783 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2784 (a_write, e_write):
2785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2786 (Fcopy_file, non_regular_nbytes, read_non_regular)
2787 (Finsert_file_contents):
2788 Use int, not EMACS_INT, where int is wide enough.
2789 (READ_BUF_SIZE): Verify that it fits in int.
2790 (Finsert_file_contents): Check that counts are in proper range,
2791 rather than assuming fixnums fit into ptrdiff_t etc.
2792 Don't assume fixnums fit into int.
125b3835 2793 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2794 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2795 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2796 (string_char_to_byte, string_byte_to_char)
2797 (string_make_multibyte, string_to_multibyte)
2798 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2799 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2800 (substring_both, Fdelete, internal_equal, Ffillarray)
2801 (Fclear_string, mapcar1)
2802 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2803 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2804 (larger_vector, make_hash_table, maybe_resize_hash_table)
2805 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2806 (Fmaphash, secure_hash):
2807 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2808 (concat): Check for string index and length overflow.
2809 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2810 (Frequire):
2811 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2812 (larger_vector): New API (vec, incr_min, size_max) replaces old
2813 one (vec, new_size, init). This catches size overflow.
2814 INIT was removed because it was always Qnil.
2815 All callers changed.
2816 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2817 the upper bound on a hash table index size.
2818 (make_hash_table, maybe_resize_hash_table): Use it.
2819 (secure_hash): Computer start_byte and end_byte only after
2820 they're known to be in ptrdiff_t range.
2821 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2822 (Ffont_get_glyphs, Ffont_at):
2823 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2824 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2825 (Flist_fonts, Fopen_font):
2826 Don't assume fixnum can fit in int.
2827 (check_gstring): Don't assume index can fit in int.
2828 (font_match_p): Check that fixnum is a character, not a nonnegative
2829 fixnum, since the later code needs to stuff it into an int.
2830 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2831 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2832 conversion overflow issues.
2833 (Fopen_font): Check for integer out of range.
2834 (Ffont_get_glyphs): Don't assume index can fit in int.
2835 * font.h: Adjust decls to match defn changes elsewhere.
2836 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2837 integer overflow.
2838 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2839 printmax_t, where ptrdiff_t is wide enough.
2840 (Finternal_char_font):
2841 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2842 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2843 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2844 (Fset_frame_position, x_set_frame_parameters)
2845 (x_set_line_spacing, x_set_border_width)
2846 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2847 Check that fixnums are in proper range for system types.
2848 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2850 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2851 Use SAFE_ALLOCA_LISP, not alloca.
2852 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2853 intptr_t is wide enough.
2854 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2855 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2856 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2857 Check for fixnum out of range.
2858 * ftfont.c (ftfont_list): Don't assume index fits in int.
2859 Check that fixnums are in proper range for system types.
2860 (ftfont_shape_by_flt):
2861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2862 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2863 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2864 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2865 Check that fixnums are in proper range for system types.
2866 * gnutls.h: Adjust decls to match defn changes elsewhere.
2867 * gtkutil.c (xg_dialog_run):
2868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2869 (update_frame_tool_bar):
2870 Check that fixnums are in proper range for system types.
2871 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2872 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2873 * indent.c (last_known_column, last_known_column_point):
2874 (current_column_bol_cache):
2875 (skip_invisible, current_column, check_display_width):
2876 (check_display_width, scan_for_column, current_column_1)
2877 (Findent_to, Fcurrent_indentation, position_indentation)
2878 (indented_beyond_p, Fmove_to_column, compute_motion):
2879 (Fcompute_motion, Fvertical_motion):
2880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2881 (last_known_column_modified): Use EMACS_INT, not int.
2882 (check_display_width):
2883 (Fcompute_motion):
2884 Check that fixnums and floats are in proper range for system types.
2885 (compute_motion): Don't assume index or fixnum fits in int.
2886 (compute_motion, Fcompute_motion):
2887 Use int, not EMACS_INT, when it is wide enough.
2888 (vmotion): Omit local var start_hpos that is always 0; that way
2889 we don't need to worry about overflow in expressions involving it.
2890 * indent.h: Adjust decls to match defn changes elsewhere.
2891 (struct position):
2892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2893 Use int, not EMACS_INT, where int is wide enough.
2894 Remove unused members ovstring_chars_done and tab_offset;
2895 all uses removed.
2896 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2897 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2898 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2899 (make_gap, copy_text, insert, insert_and_inherit)
2900 (insert_before_markers, insert_before_markers_and_inherit)
2901 (insert_1, count_combining_before, count_combining_after)
2902 (insert_1_both, insert_from_string)
2903 (insert_from_string_before_markers, insert_from_string_1)
2904 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2905 (adjust_after_replace, adjust_after_insert, replace_range)
2906 (replace_range_2, del_range, del_range_1, del_range_byte)
2907 (del_range_both, del_range_2, modify_region)
2908 (prepare_to_modify_buffer, signal_before_change)
2909 (signal_after_change, Fcombine_after_change_execute):
2910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2911 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2912 (balance_an_interval, split_interval_right, split_interval_left)
2913 (find_interval, next_interval, update_interval)
2914 (adjust_intervals_for_insertion, delete_node, delete_interval)
2915 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2916 (static_offset_intervals, offset_intervals)
2917 (merge_interval_right, merge_interval_left, make_new_interval)
2918 (graft_intervals_into_buffer, temp_set_point_both)
2919 (temp_set_point, set_point, adjust_for_invis_intang)
2920 (set_point_both, move_if_not_intangible, get_property_and_range)
2921 (get_local_map, copy_intervals, copy_intervals_to_string)
2922 (compare_string_intervals, set_intervals_multibyte_1):
2923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2924 * intervals.h: Adjust decls to match defn changes elsewhere.
2925 (struct interval):
2926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2927 * keyboard.c (this_command_key_count, this_single_command_key_start)
2928 (before_command_key_count, before_command_echo_length, echo_now)
2929 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2930 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2931 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2932 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2933 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2934 (last_non_minibuf_size, last_point_position, echo_truncate)
2935 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2936 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2937 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2938 (stuff_buffered_input):
2939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2940 (last_auto_save, command_loop_1, read_char):
2941 Use EMACS_INT, not int, to avoid integer overflow.
2942 (record_char): Avoid overflow in total_keys computation.
2943 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2944 * keyboard.h: Adjust decls to match defn changes elsewhere.
2945 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2946 (Fkey_description, Fdescribe_vector, Flookup_key):
2947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2948 (click_position): New function, to check that positions are in range.
2949 (Fcurrent_active_maps):
2950 (describe_command):
2951 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2952 (Faccessible_keymaps, Fkey_description):
2953 (preferred_sequence_p):
2954 Don't assume fixnum can fit into int.
2955 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2956 Check for integer overflow in size calculations.
2957 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2958 avoid mishandling large integers.
2959 * lisp.h: Adjust decls to match defn changes elsewhere.
2960 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2961 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2962 (struct Lisp_Marker):
2963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2964 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2965 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2966 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2967 All callers changed.
2968 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2969 Assume the arg has valid form, since it always does.
2970 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2971 unsigned integer system type.
2972 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2973 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2974 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2975 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2976 (duration_to_sec_usec): New decl.
2977 * lread.c (read_from_string_index, read_from_string_index_byte)
2978 (read_from_string_limit, readchar, unreadchar, openp)
2979 (read_internal_start, read1, oblookup):
2980 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2981 (Fload, readevalloop, Feval_buffer, Feval_region):
2982 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2983 (openp): Check for out-of-range argument to 'access'.
2984 (read1): Use int, not EMACS_INT, where int is wide enough.
2985 Don't assume fixnum fits into int.
6efdadfd 2986 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2987 (read_filtered_event): Use duration_to_sec_usec
2988 to do proper overflow checking on durations.
d311d28c
PE
2989 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2990 in size calculation.
2991 (Fexecute_kbd_macro):
2992 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2993 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2994 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2995 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2996 (set_marker_both, set_marker_restricted_both, marker_position)
2997 (marker_byte_position, Fbuffer_has_markers_at):
2998 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2999 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3000 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3001 It now merely ensures that the menu is large enough, without
3002 necessarily growing it, as this avoids some integer overflow issues.
3003 All callers changed.
3004 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3005 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3006 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3007 Use SAFE_ALLOCA_LISP, not alloca.
3008 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3009 to EMACS_INT. Check that fixnums are in proper range for system types.
3010 * minibuf.c (minibuf_prompt_width, string_to_object)
3011 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3012 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3013 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3014 (get_minibuffer, read_minibuf_unwind):
3015 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3016 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3017 this simplifies overflow checking. All callers changed.
3018 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3019 (Ftest_completion):
3020 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3021 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3022 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3023 Check that fixnums are in proper range for system types.
3024 (Fx_create_frame, Fx_show_tip):
3025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3026 * nsfont.m (ns_findfonts, nsfont_list_family):
3027 Don't assume fixnum fits in long.
3028 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3030 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3031 wide enough.
17fdb222 3032 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3033 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3034 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3035 (PRINTDECLARE, PRINTPREPARE):
3036 (strout, print_string):
3037 (print, print_preprocess, print_check_string_charset_prop)
3038 (print_object):
3039 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3040 (PRINTDECLARE):
3041 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3043 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3044 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3045 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3046 (print_error_message): Use SAFE_ALLOCA, not alloca.
3047 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3048 (print_depth, new_backquote_output, print_number_index):
3049 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3050 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3051 (Fset_process_window_size, Fformat_network_address)
3052 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3053 (sigchld_handler):
d311d28c 3054 Check that fixnums are in proper range for system types.
d44287d4 3055 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3056 Check for process-ids out of pid_t range rather than relying on
3057 undefined behavior.
e4d81efc 3058 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3059 (Fformat_network_address, read_process_output, send_process)
3060 (Fprocess_send_region, status_notify):
3061 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3062 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3063 (wait_reading_process_output, read_process_output, exec_sentinel):
3064 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3065 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3066 (Faccept_process_output): Use duration_to_sec_usec to do proper
3067 overflow checking on durations.
dde14581
PE
3068 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3069 Don't assume pid_t fits in int.
02481186
PE
3070 * process.h (struct Lisp_Process): Members tick and update_tick
3071 are now of type EMACS_INT, not int.
b62b53e8
PE
3072 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3073 configured --with-wide-int.
d311d28c
PE
3074 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3075 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3076 * search.c (looking_at_1, string_match_1):
3077 (fast_string_match, fast_c_string_match_ignore_case)
3078 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3079 (scan_newline, find_before_next_newline, search_command)
3080 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3081 (set_search_regs, wordify):
3082 (Freplace_match):
3083 (Fmatch_data):
3084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3085 (string_match_1, search_buffer, set_search_regs):
3086 (Fmatch_data):
3087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3088 (wordify): Check for overflow in size calculation.
3089 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3090 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3091 Check that fixnums are in proper range for system types.
3092 * sound.c (struct sound_device)
3093 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3095 (Fplay_sound_internal):
3096 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3097 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3098 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3099 (Fparse_partial_sexp):
3100 Don't assume fixnums can fit in int.
3101 (struct lisp_parse_state, find_start_pos, find_start_value)
3102 (find_start_value_byte, find_start_begv)
3103 (update_syntax_table, char_quoted, dec_bytepos)
3104 (find_defun_start, prev_char_comend_first, back_comment):
3105 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3106 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3107 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3108 (Finternal_describe_syntax_value): Check that match_lisp is a
3109 character, not an integer, since the code stuffs it into int.
3110 (scan_words, scan_sexps_forward):
3111 Check that fixnums are in proper range for system types.
3112 (Fforward_word):
3113 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3114 (scan_sexps_forward):
3115 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3116 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3117 * syntax.h: Adjust decls to match defn changes elsewhere.
3118 (struct gl_state_s):
3119 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3120 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3121 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3122 * sysdep.c (wait_for_termination_1, wait_for_termination)
3123 (interruptible_wait_for_termination, mkdir):
3124 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3125 (emacs_read, emacs_write):
3126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3127 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3128 and double all fit in int.
d311d28c
PE
3129 * term.c (set_tty_color_mode):
3130 Check that fixnums are in proper range for system types.
3131 * termhooks.h (struct input_event):
3132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3133 * textprop.c (validate_interval_range, interval_of)
3134 (Fadd_text_properties, set_text_properties_1)
3135 (Fremove_text_properties, Fremove_list_of_text_properties)
3136 (Ftext_property_any, Ftext_property_not_all)
3137 (copy_text_properties, text_property_list, extend_property_ranges)
3138 (verify_interval_modification):
3139 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3140 (Fnext_single_char_property_change)
3141 (Fprevious_single_char_property_change):
3142 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3143 (copy_text_properties):
3144 Check for integer overflow in index calculation.
d311d28c
PE
3145 * undo.c (last_boundary_position, record_point, record_insert)
3146 (record_delete, record_marker_adjustment, record_change)
3147 (record_property_change):
3148 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3149 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3151 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3152 (Fx_hide_tip, Fx_file_dialog):
3153 * w32menu.c (set_frame_menubar):
3154 Use ptrdiff_t, not int, for consistency with rest of code.
3155 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3156 (select_window, Fdelete_other_windows_internal)
3157 (window_scroll_pixel_based, window_scroll_line_based)
3158 (Frecenter, Fset_window_configuration):
3159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3160 (Fset_window_hscroll, run_window_configuration_change_hook)
3161 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3162 (Fscroll_other_window, Frecenter):
d311d28c
PE
3163 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3164 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3165 Don't assume fixnum fits in int.
3166 (Fset_window_scroll_bars):
3167 Check that fixnums are in proper range for system types.
3168 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3169 (string_pos, c_string_pos, number_of_chars, init_iterator)
3170 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3171 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3172 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3173 (face_before_or_after_it_pos, handle_invisible_prop)
3174 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3175 (display_prop_intangible_p, string_buffer_position_lim)
3176 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3177 (get_overlay_strings_1, get_overlay_strings)
3178 (iterate_out_of_display_property, forward_to_next_line_start)
3179 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3180 (get_next_display_element, set_iterator_to_next)
3181 (get_visually_first_element, compute_stop_pos_backwards)
3182 (handle_stop_backwards, next_element_from_buffer)
3183 (move_it_in_display_line_to, move_it_in_display_line)
3184 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3185 (add_to_log, message_dolog, message_log_check_duplicate)
3186 (message2, message2_nolog, message3, message3_nolog
3187 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3188 (current_message_1, truncate_echo_area, truncate_message_1)
3189 (set_message, set_message_1, store_mode_line_noprop)
3190 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3191 (text_outside_line_unchanged_p, check_point_in_composition)
3192 (reconsider_clip_changes)
3193 (redisplay_internal, set_cursor_from_row, try_scrolling)
3194 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3195 (redisplay_window, find_last_unchanged_at_beg_row)
3196 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3197 (trailing_whitespace_p, find_row_edges, display_line)
3198 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3199 (display_mode_element, store_mode_line_string)
3200 (pint2str, pint2hrstr, decode_mode_spec)
3201 (display_count_lines, display_string, draw_glyphs)
3202 (x_produce_glyphs, x_insert_glyphs)
3203 (rows_from_pos_range, mouse_face_from_buffer_pos)
3204 (fast_find_string_pos, mouse_face_from_string_pos)
3205 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3206 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3207 (safe_call, init_from_display_pos, handle_fontified_prop)
3208 (handle_single_display_spec, load_overlay_strings)
3209 (with_echo_area_buffer, setup_echo_area_for_printing)
3210 (display_echo_area, echo_area_display)
3211 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3212 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3213 (redisplay_window, dump_glyph_row, display_mode_line)
3214 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3215 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3216 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3217 (handle_single_display_spec, build_desired_tool_bar_string)
3218 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3219 (get_specified_cursor_type):
3220 Check that fixnums are in proper range for system types.
3221 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3222 (Flookup_image_map):
3223 Don't assume fixnums fit in int.
3224 (compare_overlay_entries):
3225 Avoid mishandling comparisons due to subtraction overflow.
3226 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3227 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3228 (handle_tool_bar_click):
3229 Use int, not unsigned, since we prefer signed and the signedness
3230 doesn't matter here.
3231 (get_next_display_element, next_element_from_display_vector):
3232 Use int, not EMACS_INT, when int is wide enough.
3233 (start_hourglass): Use duration_to_sec_usec to do proper
3234 overflow checking on durations.
3235 * xfaces.c (Fbitmap_spec_p):
3236 Check that fixnums are in proper range for system types.
3237 (compare_fonts_by_sort_order):
3238 Avoid mishandling comparisons due to subtraction overflow.
3239 (Fx_family_fonts, realize_basic_faces):
3240 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3241 (Fx_family_fonts):
3242 Don't assume fixnum fits in int.
3243 Use SAFE_ALLOCA_LISP, not alloca.
3244 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3245 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3246 (face_at_buffer_position, face_for_overlay_string)
3247 (face_at_string_position):
3248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3249 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3250 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3251 (Fx_show_tip):
3252 Check that fixnums are in proper range for system types.
3253 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3254 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3255 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3256 (Fx_change_window_property): Don't assume fixnums fit in int.
3257 * xfont.c (xfont_chars_supported):
3258 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3259 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3260 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3261 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3262 * xml.c (parse_region):
3263 * xrdb.c (magic_file_p):
3264 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3265 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3266 (x_get_local_selection, x_reply_selection_request)
3267 (x_handle_selection_request, wait_for_property_change):
3268 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3269 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3270 short is wide enough.
3271 (x_send_client_event): Don't assume fixnum fits in int.
3272 * xterm.c (x_x_to_emacs_modifiers):
3273 Don't assume EMACS_INT overflows nicely into int.
3274 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3275 may come from Lisp.
3276 (handle_one_xevent): NATNUMP can eval its arg twice.
3277 (x_connection_closed):
3278 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3279 * xterm.h: Adjust decls to match defn changes elsewhere.
3280 (struct scroll_bar): Use struct vectorlike_header
3281 rather than rolling our own approximation.
3282 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3283
c6574eb5
GM
32842012-05-25 Glenn Morris <rgm@gnu.org>
3285
3286 * lisp.mk (lisp): Update for more files being compiled now.
3287
e8d32c7e
SM
32882012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3289
48def666
SM
3290 * lread.c: Remove `read_pure' which makes no difference.
3291 (read_pure): Remove var.
3292 (unreadpure): Remove function.
3293 (readevalloop): Don't call read_list with -1 flag.
3294 (read1, read_vector): Don't test read_pure any more.
3295 (read_list): Simplify.
3296
e8d32c7e
SM
3297 * fileio.c, character.h: Minor style tweaks.
3298
4b2addb7
DA
32992012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3300
3301 * window.h (clip_changed): Remove useless declaration.
3302
584461b2
JB
33032012-05-22 Juanma Barranquero <lekktu@gmail.com>
3304
3305 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3306 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3307
34374650
PE
33082012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3309
3310 Remove src/m/*.
3311 This directory predates autoconf and is no longer needed nowadays.
3312 Move its few remaining bits of functionality to where they're needed.
3313 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3314 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3315 * m/template.h: Remove.
3316 * Makefile.in (M_FILE): Remove. All uses removed.
3317 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3318 * lisp.h (USE_LSB_TAG):
3319 * mem-limits.h (EXCEEDS_LISP_PTR):
3320 Use VAL_MAX, not VALBITS, in #if.
3321 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3322 (EMACS_UINT): Define unconditionally now.
3323 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3324 (BITS_PER_EMACS_INT): New constants, replacing
3325 what used to be in config.h, but not useful in #if.
3326 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3327 define them any more.
3328 (VAL_MAX): New macro.
3329 (VALMASK): Use it.
3330 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3331 BITS_PER_EMACS_INT, in #if.
3332 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3333 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3334 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3335 * s/ms-w32.h (DATA_START):
3336 Move here from removed file m/intel386.h.
3337 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3338 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3339
261cb4bb
PE
33402012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3341
3342 Assume C89 or later.
3343 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3344 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3345 (xrealloc):
3346 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3347 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3348 * textprop.c, tparam.c (NULL): Remove.
3349 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3350 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3351 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3352 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3353 * xterm.c (input_signal_count): Assume volatile works.
3354
ff23cd9f
KB
33552012-05-21 Ken Brown <kbrown@cornell.edu>
3356
3357 * xgselect.c (xg_select): Fix first argument in call to 'select'
3358 (bug#11508).
3359
1b170bc6
KB
33602012-05-20 Ken Brown <kbrown@cornell.edu>
3361
3362 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3363 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3364
b2f4d39f
KB
33652012-05-19 Ken Brown <kbrown@cornell.edu>
3366
3367 * xfns.c (x_in_use): Remove `static' qualifier.
3368 * xterm.h (x_in_use): Declare.
3369 * xgselect.c: Include xterm.h.
3370 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3371 and `display_arg' (bug#9754).
3372
003fdae2
PE
33732012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3374
9232a6d9
PE
3375 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3376
003fdae2
PE
3377 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3378 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3379
784b56e2
EZ
33802012-05-18 Eli Zaretskii <eliz@gnu.org>
3381
3382 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3383
3384 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3385 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3386
3387 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3388 reference to image_cache->refcount.
3389 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3390
a0a79cde
JL
33912012-05-17 Juri Linkov <juri@jurta.org>
3392
3393 * search.c (Fword_search_regexp, Fword_search_backward)
3394 (Fword_search_forward, Fword_search_backward_lax)
3395 (Fword_search_forward_lax): Move functions to isearch.el
3396 (bug#10145, bug#11381).
3397
b0572523
PE
33982012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3399
3400 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3401
9660f5fc
SM
34022012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3403
3404 * lread.c (init_obarray): Declare Qt and Qnil as special.
3405
4374de83
GM
34062012-05-14 Glenn Morris <rgm@gnu.org>
3407
3408 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3409 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3410
dc44c39a
PE
34112012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3412
078c97cb
PE
3413 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3414
dc44c39a
PE
3415 * unexaix.c: Port to more-recent AIX compilers.
3416 (report_error, report_error_1, make_hdr, copy_sym)
3417 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3418 Make arguments const char *, not char *, to avoid violations of C
3419 standard and to fix some AIX warnings reported by Gilles Pion.
3420
e18afed7 34212012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3422
3423 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3424 already have overlays loaded.
3425 (handle_single_display_spec): Before returning without displaying
3426 fringe bitmap, synchronize the bidi iterator with the main display
3427 iterator, by calling iterate_out_of_display_property.
3428 (iterate_out_of_display_property): Detect buffer iteration by
3429 testing that it->string is a Lisp string.
3430 (get_next_display_element): When the current object is exhausted,
3431 and there's something on it->stack, call set_iterator_to_next to
3432 proceed with what's on the stack, instead of returning zero.
3433 (set_iterator_to_next): If called at the end of a Lisp string,
3434 proceed to consider_string_end without incrementing string
3435 position. Don't increment display vector index past the end of
3436 the display vector. (Bug#11417)
c8fb9dc6
EZ
3437 (pos_visible_p): Don't report a position visible when move_it_to
3438 stopped at the last line of window, which happens to be scanned
3439 backwards by the bidi iteration. (Bug#11464)
ac268e67 3440
e18afed7 34412012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3442
3443 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3444 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3445 are on a TTY, and thus unable to display on the fringes.
3446 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3447 so we need to signal to the caller that this is a "replacing"
3448 display spec. This fixes display when the spec is invalid or we
3449 are on a TTY.
3450
e18afed7 34512012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3452
3453 * unexaix.c (make_hdr): Fix typo in prototype.
3454 This bug broke the build on AIX. Problem reported by Gilles Pion.
3455
9d0a235a
MA
34562012-05-14 Michael Albinus <michael.albinus@gmx.de>
3457
3458 * keyboard.c (kbd_buffer_get_event): Read special events also in
3459 batch mode. (Bug#11415)
3460
9e6b06ed
GM
34612012-05-12 Glenn Morris <rgm@gnu.org>
3462
3463 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3464
c1a1d7a3
EZ
34652012-05-12 Eli Zaretskii <eliz@gnu.org>
3466
3467 * lisp.mk (lisp): Add newcomment.elc.
3468
3fe7cdc8
GM
34692012-05-12 Glenn Morris <rgm@gnu.org>
3470
3471 * Makefile.in (MKDIR_P): New, set by configure.
3472 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3473
53f7d2c0
PE
34742012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3475
3476 Remove unused function hourglass_started.
3477 * dispextern.h (hourglass_started):
3478 * w32fns.c (hourglass_started):
3479 * xdisp.c (hourglass_started): Remove.
3480
75aafb17
JB
34812012-05-10 Juanma Barranquero <lekktu@gmail.com>
3482
3483 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3484 Update dependencies.
3485
12959e8e
PE
34862012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3487
97107e2e
PE
3488 * xgselect.c (xg_select): Put maxfds+1 into a var.
3489 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3490
12959e8e
PE
3491 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3492
836d29b3
DA
34932012-05-10 Dave Abrahams <dave@boostpro.com>
3494
3495 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3496 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3497
5cb67954
MA
34982012-05-09 Michael Albinus <michael.albinus@gmx.de>
3499
3500 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3501 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3502 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3503 Initialize xd_registered_buses.
3504
3478ec45
PE
35052012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3506
b263a6b0
PE
3507 Untag more efficiently if USE_LSB_TAG.
3508 This is based on a proposal by YAMAMOTO Mitsuharu in
3509 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3510 For an admittedly artificial (nth 8000 longlist) benchmark on
3511 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3512 Emacs's overall text size by 1%.
3513 * lisp.h (XUNTAG): New macro.
3514 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3515 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3516 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3517 * eval.c (Fautoload):
3518 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3519 * frame.h (XFRAME): Use XUNTAG.
3520
3478ec45
PE
3521 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3522 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3523 Remove unportable assumptions about print widths of types like
3524 dbus_uint32_t.
3525 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3526 intptr_t when converting between pointer and integer, to avoid GCC
3527 warnings about wrong width.
3528
666b903b 35292012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3530
3531 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3532 stack for each reader_thread, instead of defaulting to 8MB
3533 determined by the linker. This avoids failures in creating
3534 subprocesses on Windows 7, see the discussion in this thread:
3535 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3536
b120cc17
JC
35372012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3538
3539 Fix up display of the *Minibuf-0* buffer in the mini window.
3540 * keyboard.c (read_char): Don't clear the echo area if there's no
3541 message to clear.
3542 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3543 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3544
9a4b36f8
MA
35452012-05-07 Michael Albinus <michael.albinus@gmx.de>
3546
3547 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3548 batch mode.
3549
e5f9458f
CY
35502012-05-06 Chong Yidong <cyd@gnu.org>
3551
3552 * lisp.mk (lisp): Update.
3553
eceeb5fc 35542012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3555
3556 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3557
71873e2b
SM
35582012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3559
3560 * data.c (PUT_ERROR): New macro.
3561 (syms_of_data): Use it. Add new error type `user-error'.
3562 * undo.c (user_error): New function.
3563 (Fprimitive_undo): Use it.
3564 * print.c (print_error_message): Adjust print style for `user-error'.
3565 * keyboard.c (user_error): New function.
3566 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3567
ab0fa4e4
PE
35682012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3569
3570 Do not limit current-time-string to years 1000..9999.
3571 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3572 (Fcurrent_time_string): Support any year that is supported by the
3573 underlying localtime representation. Don't use asctime, as it
3574 has undefined behavior for years outside the range -999..9999.
3575
7ed806a7
PE
35762012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3577
3578 Fix race conditions involving setenv, gmtime, localtime, asctime.
3579 Without this fix, interrupts could mess up code that uses these
3580 nonreentrant functions, since setting TZ invalidates existing
3581 tm_zone or tzname values, and since most of these functions return
3582 pointers to static storage.
3583 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3584 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3585 Grow the critical sections to include not just invoking
3586 localtime/gmtime, but also accessing these functions' results
3587 including their tm_zone values if any, and any related TZ setting.
3588 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3589 so that the struct tm is saved in the critical section.
3590 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3591 motivated by the fact that memory allocation needs to be outside
3592 the critical section.
3593
0c16dfed
DA
35942012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3595
3596 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3597 with RESET_INTERVAL.
3598
3599 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3600 Remove duplicated buffer name initialization.
3601
3f83ace8
JM
36022012-05-02 Jim Meyering <jim@meyering.net>
3603
3604 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3605
c7b8541e
JM
3606 * xfns.c (x_window): Use xstrdup (Bug#11375).
3607
90207a15 36082012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3609
3610 * xdisp.c (pos_visible_p): If already at a newline from the
3611 display string before the 'while' loop, don't walk back the glyphs
3612 from it3.glyph_row. Solves assertion violation when the display
3613 string begins with a newline (egg.el). (Bug#11367)
3614
b593d6a9
AH
36152012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3616
3617 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3618 Move to simple.el.
3619
4737362e
GM
36202012-05-01 Glenn Morris <rgm@gnu.org>
3621
99cf43f9
GM
3622 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3623 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3624 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3625 All were removed before 23.1.
3626
9311dcff
GM
3627 * dispnew.c: Remove HAVE_LIBNCURSES test;
3628 it is always true on relevant platforms.
3629
4d5c6349
GM
3630 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3631 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3632
4737362e
GM
3633 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3634
74dd3a6b
AS
36352012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3636
3637 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3638 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3639 Remove.
3640
13c379ee
PE
36412012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3642
3643 Do not avoid creating empty evaporating overlays (Bug#9642).
3644 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3645 That is, do not delete an evaporating overlay if it becomes
3646 empty after its bounds are adjusted to fit within its buffer.
3647 This fix caused other problems, and I'm reverting it until we get
3648 to the bottom of them.
3649
a8e7d6d7 36502012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3651
3652 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3653
a8e7d6d7 36542012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3655
3656 * xdisp.c (pos_visible_p): If the window start position is beyond
3657 ZV, start the display from buffer beginning. Prevents assertion
3658 violation in init_iterator when the minibuffer window is scrolled
3659 via the scroll bar.
3660
3661 * window.c (window_scroll_pixel_based): Likewise.
3662
a8e7d6d7 36632012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3664
3665 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3666
a8e7d6d7 36672012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3668
3669 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3670 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3671
a8e7d6d7 36722012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3673
b593d6a9
AH
3674 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3675 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3676
1c6900d9
EZ
36772012-04-26 Eli Zaretskii <eliz@gnu.org>
3678
4c3fa1d9
EZ
3679 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3680 display element, check also the underlying string or buffer
3681 character. (Bug#11341)
3682
1c6900d9
EZ
3683 * w32menu.c: Include w32heap.h.
3684 (add_menu_item): If the call to AppendMenuW (via
3685 unicode_append_menu) fails, disable Unicode menus only if we are
3686 running on Windows 9X/Me.
3687
42bf8205
AS
36882012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3689
3690 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3691 (xgetint): Add missing shift for LSB tags.
3692
b1bac16e
MR
36932012-04-24 Martin Rudalics <rudalics@gmx.at>
3694
3695 * keyboard.c (read_char): Don't wipe echo area for select window
3696 events: These might get delayed via `mouse-autoselect-window'
3697 (Bug#11304).
3698
d69621cc
JB
36992012-04-24 Juanma Barranquero <lekktu@gmail.com>
3700
3701 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3702 manipulation of :loaded-from data.
3703
02fd101b
JB
37042012-04-23 Juanma Barranquero <lekktu@gmail.com>
3705
3706 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3707 now a cons (bug#11311).
3708
888bec30
PE
37092012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3710
89a438bd
PE
3711 Do not create empty overlays with the evaporate property (Bug#9642).
3712 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3713 if it becomes empty after its bounds are adjusted to fit within
3714 its buffer. Without this fix, in a nonempty buffer (let ((o
3715 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3716 yields an empty overlay that has the evaporate property, which is
3717 not supposed to happen.
3718
1068fe4d
PE
3719 Fix minor GTK3 problems found by static checking.
3720 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3721 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3722 (struct _EmacsFixedClass, emacs_fixed_get_type):
3723 Move decls here from emacsgtkfixed.h, since they needn't be public.
3724 (emacs_fixed_get_type): Now static.
3725 (emacs_fixed_class_init): Omit unused local.
3726 (emacs_fixed_child_type): Remove; unused.
3727 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3728 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3729 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3730 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3731 (EMACS_FIXED_GET_CLASS): Remove; unused.
3732 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3733
888bec30
PE
3734 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3735 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3736
de85e130
PE
37372012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3738
d0baac98 3739 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3740 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3741 (__malloc_size_t, __malloc_ptrdiff_t):
3742 Remove. All uses removed, replaced by the definiens if needed,
3743 since we can assume C89 or better now.
3744 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3745 (protect_malloc_state, align, get_contiguous_space)
3746 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3747 (malloc_atfork_handler_child, malloc_enable_thread)
3748 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3749 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3750 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3751 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3752 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3753 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3754 Define using prototypes, not old style.
3755 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3756 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3757 (align): Don't assume that signed integer overflow wraps around.
3758 Omit unused local var.
3759 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3760 (_free_internal_nolock, memalign, mallochook, reallochook):
3761 Omit no-longer-needed casts.
3762 (valloc): Use getpagesize, not __getpagesize.
3763 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3764 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3765
de85e130
PE
3766 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3767
dcbf5805
MA
37682012-04-22 Michael Albinus <michael.albinus@gmx.de>
3769
3770 Move functions from C to Lisp. Make non-blocking method calls
3771 the default. Implement further D-Bus standard interfaces.
3772
3773 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3774 (QCdbus_request_name_allow_replacement)
3775 (QCdbus_request_name_replace_existing)
3776 (QCdbus_request_name_do_not_queue)
3777 (QCdbus_request_name_reply_primary_owner)
3778 (QCdbus_request_name_reply_in_queue)
3779 (QCdbus_request_name_reply_exists)
3780 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3781 (QCdbus_registered_serial, QCdbus_registered_method)
3782 (QCdbus_registered_signal): New Lisp objects.
3783 (XD_DEBUG_MESSAGE): Use sizeof.
3784 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3785 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3786 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3787 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3788 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3789 (xd_signature, xd_append_arg): Allow float for integer types.
3790 (xd_get_connection_references): New function.
b593d6a9
AH
3791 (xd_get_connection_address): Rename from xd_initialize.
3792 Return cached address.
dcbf5805
MA
3793 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3794 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3795 level.
3796 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3797 Return number of refcounts.
dcbf5805
MA
3798 (Fdbus_get_unique_name): Make stronger parameter check.
3799 (Fdbus_message_internal): New defun.
3800 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3801 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3802 (Fdbus_send_signal, Fdbus_register_service)
3803 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3804 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3805 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3806 (Vdbus_compiled_version, Vdbus_runtime_version)
3807 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3808 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3809 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3810 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3811 Adapt docstring.
dcbf5805 3812
52828e02
PE
38132012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3814
da05bc4c
PE
3815 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3816 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3817 Do not assume ptrdiff_t is the same width as 'int'.
3818
52828e02
PE
3819 * alloc.c: Handle unusual debugging option combinations.
3820 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3821 since the two debugging options are incompatible.
3822 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3823 is defined.
3824 (mem_init, mem_insert, mem_insert_fixup):
3825 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3826 (NEED_MEM_INSERT): Remove; no longer needed.
3827
f01769f9
LL
38282012-04-22 Leo Liu <sdl.web@gmail.com>
3829
3830 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3831
5790543d
PE
38322012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3833
3834 * sysdep.c [__FreeBSD__]: Minor cleanups.
3835 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3836 Use Emacs indenting style more consistently. Avoid some casts.
3837 Use 'double' consistently rather than mixing 'float' and 'double'.
3838
b91b7e4d
EW
38392012-04-21 Eduard Wiebe <usenet@pusto.de>
3840
b593d6a9
AH
3841 * sysdep.c (list_system_processes, system_process_attributes):
3842 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3843
6114eb15
AS
38442012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3845
3846 * lisp.mk (lisp): Update.
3847
2f38dff7
PE
38482012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3849
3850 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3851 It is never used otherwise.
3852
4ae29f89
SM
38532012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3854
3855 * print.c (print_preprocess): Only check print_depth if print-circle
3856 is nil.
3857 (print_object): Check for cycles even when print-circle is nil and
3858 print-gensym is t, but only check print_depth if print-circle is nil.
3859
f30d612a
CY
38602012-04-20 Chong Yidong <cyd@gnu.org>
3861
3862 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3863 set the status to "failed" and ensure that sentinel is run.
3864
c07a4c0b 38652012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3866
3867 * process.c (Fset_process_inherit_coding_system_flag)
3868 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3869 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3870
c07a4c0b 38712012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3872
3873 * xdisp.c (string_buffer_position_lim): Limit starting position to
3874 BEGV.
3875 (set_cursor_from_row): If called for a mode-line or header-line
3876 row, return zero immediately.
3877 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3878 farther than the first row after the header line, if any.
3879 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3880 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3881
c07a4c0b 38822012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3883
4ae29f89
SM
3884 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3885 (bug#11238).
ad3a2b41 3886
c07a4c0b 38872012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 38882012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3889
3890 configure: new option --enable-gcc-warnings (Bug#11207)
3891 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3892 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3893 (ALL_CFLAGS): Use new macros rather than old.
3894 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3895 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3896 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3897 -Wunused-result, -Wunused-variable. This should go away once
3898 the Emacs and Gnulib regex code is merged.
3899 (xmalloc, xrealloc): Now static.
3900
aba027e8
PE
39012012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3902
3903 * dired.c (Fsystem_groups): Remove unused local.
3904
e5a36063
GM
39052012-04-17 Glenn Morris <rgm@gnu.org>
3906
3907 * dired.c (Fsystem_users): Doc fix.
3908
316411f0
DA
39092012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3910
3911 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3912 (syms_of_dired): Add them.
3913
9426aba4
PE
39142012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3915
b62a57be
PE
3916 Fix minor alloc.c problems found by static checking.
3917 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3918 New extern decls, to avoid calling undeclared functions.
3919 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3920 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3921 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3922 (NEED_MEM_INSERT): New macro.
3923 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3924 Remove one incorrect comment and fix another.
b62a57be 3925
3539f31f
PE
3926 Fix minor ralloc.c problems found by static checking.
3927 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3928 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3929 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3930 (r_alloc_sbrk): Now static.
3931
a041960a
PE
3932 Improve ralloc.c interface checking.
3933 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3934 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3935 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3936 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3937 [REL_ALLOC]: ... to here, to check interface.
3938 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3939 Remove decls. This fixes an "It stinks!".
3940
9426aba4
PE
3941 * alloc.c (which_symbols): Fix alignment issue / type clash.
3942
d55c12ed
AS
39432012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3944
3945 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3946 (struct Lisp_Misc_Any): Likewise.
3947 (struct Lisp_Free): Likewise.
3948 * alloc.c (union aligned_Lisp_Symbol): Define.
3949 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3950 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3951 (union aligned_Lisp_Misc): Define.
3952 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3953 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3954 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3955
b948ce8b
PE
39562012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3957
3958 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3959 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3960 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3961 * s/netbsd.h, s/sol2-6.h:
3962 Remove definition of GC_MARK_STACK, since the default now works.
3963 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3964 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3965 no longer the default.
3966 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3967
35dc09a1 39682012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3969
35dc09a1
GM
3970 * lread.c (lisp_file_lexically_bound_p):
3971 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3972
35dc09a1
GM
39732012-04-14 Eli Zaretskii <eliz@gnu.org>
3974
3975 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3976 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3977
39782012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3979
3980 * nsterm.m (constrainFrameRect): Always constrain when there is only
3981 one screen (Bug#10962).
3982
bcd86815
KB
39832012-04-13 Ken Brown <kbrown@cornell.edu>
3984
3985 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3986
c25df26e
RT
39872012-04-13 Reuben Thomas <rrt@sc3d.org>
3988
3989 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3990
0fc59f1e
DC
39912012-04-11 Daniel Colascione <dancol@dancol.org>
3992
3993 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3994 against is gone. It's better to use vfork now so that when Cygwin
3995 gains a new, working vfork, we use it automatically (bug#10398).
3996
de8c03dc
SM
39972012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3998
3999 * window.c (save_window_save): Obey window-point-insertion-type.
4000
2f097256
GM
40012012-04-11 Glenn Morris <rgm@gnu.org>
4002
4003 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4004
453b951e
SM
40052012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4006
4007 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4008
75f1671a 40092012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4010
4011 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4012 (force_quit_count): New var.
4013 (handle_interrupt): Use it.
4014
2a8ce227
JB
40152012-04-10 Juanma Barranquero <lekktu@gmail.com>
4016
4017 * w32.c (w32_delayed_load): Record the full path of the library
4018 being loaded (bug#10424).
4019
935396c0
GM
40202012-04-09 Glenn Morris <rgm@gnu.org>
4021
05920a43
GM
4022 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4023 not just in the obarray, before snarfing them. (Bug#11036)
4024
935396c0
GM
4025 * Makefile.in ($(leimdir)/leim-list.el):
4026 Pass EMACS rather than BUILT_EMACS.
4027
a18ecafa
TZ
40282012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4029
4030 * process.c (make_process):
4031 * process.h: Add integer `gnutls_handshakes_tried' member to
4032 process struct.
4033
6bbef4e5
JC
4034 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4035 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4036
4037 * gnutls.c (gnutls_log_function2i): Convenience log function.
4038 (emacs_gnutls_read): Use new log functions,
4039 `gnutls_handshakes_tried' process member, and
4040 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4041 attempts per process (connection).
4042
b4d3bc10
CY
40432012-04-09 Chong Yidong <cyd@gnu.org>
4044
4045 * eval.c (Fuser_variable_p, user_variable_p_eh)
4046 (lisp_indirect_variable): Functions deleted.
4047 (Fdefvar): Caller changed.
4048
4049 * callint.c (Finteractive, Fcall_interactively):
4050 * minibuf.c (Fread_variable): Callers changed.
4051
70f4d973
EZ
40522012-04-09 Eli Zaretskii <eliz@gnu.org>
4053
4054 * xdisp.c (set_cursor_from_row): If the display string appears in
4055 the buffer at position that is closer to point than the position
4056 after the display string, display the cursor on the first glyph of
4057 the display string. Fixes cursor display when a 'display' text
4058 property immediately follows invisible text. (Bug#11094)
4059
cb3c2e3e
PE
40602012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4061
4062 composite.c: use 'double' consistently
4063 * composite.c (get_composition_id): Use 'double' consistently
4064 instead of converting 'float' to 'double' and vice versa; this is
4065 easier to understand and avoids a GCC warning.
4066
fd06db5d
GM
40672012-04-09 Glenn Morris <rgm@gnu.org>
4068
50fe702a
GM
4069 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4070 preparation for dumping it with emacs. (Bug#4789)
4071 (leimdir): New variable.
4072 ($(leimdir)/leim-list.el): New rule.
4073 (emacs$(EXEEXT)): Depend on leim-list.el.
4074
fd06db5d
GM
4075 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4076 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4077 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4078
55c131ee
AS
40792012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4080
4081 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4082 proper alignment.
4083
9209588f
JB
40842012-04-07 Juanma Barranquero <lekktu@gmail.com>
4085
4086 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4087 Remove unused local variable.
4088
e3fb2efb
PE
40892012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4090
4091 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4092 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4093 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4094 objects, as mark_maybe_pointer will catch them otherwise.
4095 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4096 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4097
b5385551
PE
40982012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4099
4100 Fix typo that broke non-Windows builds.
4101 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4102
9078ead6
EZ
41032012-04-07 Eli Zaretskii <eliz@gnu.org>
4104
4105 Support building on MS-Windows with libxml2.
4106
4107 * makefile.w32-in (OBJ2): Add xml.$(O).
4108 (GLOBAL_SOURCES): Add xml.c.
4109 ($(BLD)/xml.$(O)): New dependency list.
4110
4111 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4112 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4113 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4114 [!WINDOWSNT]: New macros.
4115 (init_libxml2_functions, libxml2_loaded_p): New functions.
4116 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4117 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4118 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4119 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4120 linked in).
6bbef4e5
JC
4121 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4122 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4123 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4124
4125 * emacs.c: Don't include libxml/parser.h.
4126 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4127 xmlCleanupParser directly.
4128
4129 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4130
3811fdf3
EZ
41312012-04-07 Eli Zaretskii <eliz@gnu.org>
4132
4133 * indent.c (Fvertical_motion): If there is a display string at
4134 point, use it.vpos to compute how many lines to backtrack after
4135 move_it_to point. (Bug#11133)
4136
2f8e16b2
EZ
41372012-04-06 Eli Zaretskii <eliz@gnu.org>
4138
4139 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4140 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4141 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4142 macros related to unification of CJK characters. For the details,
4143 see the discussion following the message here:
4144 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4145
3d439cd1
CY
41462012-04-04 Chong Yidong <cyd@gnu.org>
4147
4148 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4149
8bc53d00
EZ
41502012-04-01 Eli Zaretskii <eliz@gnu.org>
4151
4152 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4153 instead of alloca. (Bug#11138)
4154
3b0512a3
AS
41552012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4156
4157 * w32menu.c (is_simple_dialog): Properly check lisp types.
4158 (Bug#11141)
4159
8427ddd2
EZ
41602012-03-31 Eli Zaretskii <eliz@gnu.org>
4161
979022ef
EZ
4162 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4163 position we get to after a call to move_it_to fails the
4164 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4165 only if we wind up in a string from display property. (Bug#11063)
4166
a6b1c7cc
EZ
4167 * window.c (Fdelete_other_windows_internal): Invalidate the row
4168 and column information about mouse highlight, so that redisplay
4169 restores it after reallocating the glyph matrices. (Bug#7464)
4170
8427ddd2
EZ
4171 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4172 string comes from a `display' text property, use the buffer
4173 position of that property as if we actually saw that position in
4174 the row's glyphs.
697ba24b
EZ
4175 (move_it_by_lines): Remove the assertion that
4176 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4177 violated when there's a before-string at the beginning of a line.
4178 (Bug#11063)
8427ddd2 4179
65a0a738
EZ
41802012-03-30 Eli Zaretskii <eliz@gnu.org>
4181
4182 * xdisp.c (append_space_for_newline): If the default face was
4183 remapped, use the remapped face for the appended newline.
4184 (extend_face_to_end_of_line): Use the remapped default face for
4185 extending the face to the end of the line.
4186 (display_line): Call extend_face_to_end_of_line when the default
4187 face was remapped. (Bug#11068)
4188
581355cc
EZ
41892012-03-29 Eli Zaretskii <eliz@gnu.org>
4190
4191 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4192
e8fc049f
SM
41932012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4194
4195 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4196
4fb9a543
GM
41972012-03-27 Glenn Morris <rgm@gnu.org>
4198
4199 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4200 Doc fixes.
4201
679910f1
KH
42022012-03-26 Kenichi Handa <handa@m17n.org>
4203
4204 * dispextern.h (struct glyph): Fix previous change. Change the
4205 bit length of glyphless.ch to 25 (Bug#11082).
4206
90d49b7f
CY
42072012-03-26 Chong Yidong <cyd@gnu.org>
4208
4209 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4210 (command_loop_1): Use it; inhibit selection update for
4211 handle-select-window too (Bug#8996).
4212
f514f6f0
FP
42132012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4214
e8fc049f 4215 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4216
bf43fa51
KH
42172012-03-25 Kenichi Handa <handa@m17n.org>
4218
4219 * dispextern.h (struct glyph): Change the bit length of
4220 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4221
8a0c01dd
EZ
42222012-03-24 Eli Zaretskii <eliz@gnu.org>
4223
4224 * s/ms-w32.h (tzname): Include time.h before redirecting to
4225 _tzname. Fixes the MSVC build. (Bug#9960)
4226
7d1c3a76
AS
42272012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4228
8ed79523
AS
4229 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4230 characters.
4231
7d1c3a76
AS
4232 * xterm.c (XTread_socket): Only modify handling_signal if
4233 !SYNC_INPUT. (Bug#11080)
4234
e99a9b8b
EZ
42352012-03-23 Eli Zaretskii <eliz@gnu.org>
4236
4237 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4238 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4239 when fetching a multibyte character consumes more bytes than
4240 CHAR_BYTES returns, due to unification of CJK characters in
4241 string_char. (Bug#11073)
4242
5063c0e1
TN
42432012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4244
4245 * process.c (wait_reading_process_output): Handle pty disconnect
4246 by refraining from sending oneself a SIGCHLD (bug#10933).
4247
9f851fbd
CY
42482012-03-22 Chong Yidong <cyd@gnu.org>
4249
4250 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4251
5063c0e1 4252 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4253 Mark string as coming from a prefix property.
4254 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4255 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4256
fb5b8aca
CY
42572012-03-21 Chong Yidong <cyd@gnu.org>
4258
4259 * xfaces.c (Vface_remapping_alist): Doc fix.
4260
62356a1b
EZ
42612012-03-20 Eli Zaretskii <eliz@gnu.org>
4262
4263 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4264 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4265 Doc fixes.
62356a1b 4266
025de85b
CY
42672012-03-20 Chong Yidong <cyd@gnu.org>
4268
4269 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4270 to reflect default non-nil value of redisplay-dont-pause.
4271
4827f94e
KH
42722012-03-19 Kenichi Handa <handa@m17n.org>
4273
4274 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4275 it fit in a valid range (Bug#11003).
4276
e50a24a2
EZ
42772012-03-18 Eli Zaretskii <eliz@gnu.org>
4278
4279 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4280 that is not from display property, accept the row as a "cursor
4281 row" if one of the string's character has a non-nil `cursor'
4282 property. Fixes cursor positioning when there are newlines in
4283 overlay strings, e.g. in icomplete.el. (Bug#11035)
4284
9af5ed87
PE
42852012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4286
4287 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4288
d1f55f16
CY
42892012-03-12 Chong Yidong <cyd@gnu.org>
4290
4291 * eval.c (inhibit_lisp_code): Rename from
4292 inhibit_window_configuration_change_hook; move from window.c.
4293
4294 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4295 * window.c (run_window_configuration_change_hook)
4296 (syms_of_window): Callers changed.
4297
66c5eebd
CY
42982012-03-11 Chong Yidong <cyd@gnu.org>
4299
413df973
CY
4300 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4301
66c5eebd
CY
4302 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4303
1de11f56
CY
43042012-03-10 Chong Yidong <cyd@gnu.org>
4305
4306 * frame.c (other_visible_frames): Don't assume the selected frame
4307 is visible (Bug#10955).
4308
cae07000
SM
43092012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4310
4311 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4312
89c94350
JD
43132012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4314
4315 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4316 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4317 zero (Bug#10954).
4318
999dd333
GM
43192012-03-03 Glenn Morris <rgm@gnu.org>
4320
01a6dcc8 4321 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4322
de0100f2
EZ
43232012-03-02 Eli Zaretskii <eliz@gnu.org>
4324
4325 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4326 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4327 (redisplay_window, next_element_from_string): Fix typos in
4328 comments.
3e441275
EZ
4329 (redisplay_window): Pass to move_it_vertically the margin in
4330 pixels, not in screen lines.
de0100f2 4331
96a72ee9
GM
43322012-03-02 Glenn Morris <rgm@gnu.org>
4333
4334 * buffer.c (buffer-list-update-hook): Doc fix.
4335
312508d7
EZ
43362012-02-29 Eli Zaretskii <eliz@gnu.org>
4337
4338 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4339 push_it before setting up the iterator for the first overlay
4340 string, even if we have an empty string loaded.
4341 (next_overlay_string): If there's an empty string on the iterator
4342 stack, pop the stack. (Bug#10903)
4343
27f3c637
PE
43442012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4345
4346 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4347 Suggested by Stefan Monnier in
4348 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4349 * alloc.c (widen_to_Lisp_Object): New static function.
4350 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4351 and widening them to Lisp_Objects. This would work even if
4352 USE_LSB_TAG is defined and wide integers are used, which might
4353 happen in a future version of Emacs.
4354
3c9dfce6
CY
43552012-02-25 Chong Yidong <cyd@gnu.org>
4356
fa74b241
CY
4357 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4358 Doc fix.
4359
3c9dfce6
CY
4360 * xselect.c (Fx_selection_exists_p): Doc fix.
4361 (x_clipboard_manager_save_all): Print an informative message
4362 before saving to clipboard manager.
4363
9486df08
CY
43642012-02-24 Chong Yidong <cyd@gnu.org>
4365
4366 * keyboard.c (process_special_events): Handle all X selection
4367 requests in kbd_buffer, not just the next one (Bug#8869).
4368
f01d3321
CY
43692012-02-23 Chong Yidong <cyd@gnu.org>
4370
4371 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4372 call when setting menu-bar-lines and tool-bar-lines parameters.
4373 (unwind_create_frame_1): New helper function.
4374
4375 * window.c (inhibit_window_configuration_change_hook): New var.
4376 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4377 (syms_of_window): Initialize it.
f01d3321 4378
86b847b6
CY
43792012-02-22 Chong Yidong <cyd@gnu.org>
4380
4381 * xterm.c (x_draw_image_relief): Add missing type check for
4382 Vtool_bar_button_margin (Bug#10743).
4383
a59225b1
CY
43842012-02-21 Chong Yidong <cyd@gnu.org>
4385
4386 * fileio.c (Vfile_name_handler_alist): Doc fix.
4387
4388 * buffer.c (Fget_file_buffer): Protect against invalid file
4389 handler return value.
4390
310f5bd4
PE
43912012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4392
cb3a28cc
PE
4393 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4394 when computing $valmask.
4395
310f5bd4
PE
4396 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4397 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4398 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4399 It's useless in that case, and it can cause problems on hosts
4400 that allocate halves of EMACS_INT values separately.
4401 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4402 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4403 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4404 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4405 it avoids undefined behavior on hosts where shifting right by more
4406 than the word width has undefined behavior.
4407
2375c96a
CY
44082012-02-19 Chong Yidong <cyd@gnu.org>
4409
4410 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4411 (Funhandled_file_name_directory, Ffile_name_as_directory)
4412 (Fdirectory_file_name, Fexpand_file_name)
4413 (Fsubstitute_in_file_name): Protect against invalid file handler
4414 return values (Bug#10845).
4415
3eb49e71
EZ
44162012-02-18 Eli Zaretskii <eliz@gnu.org>
4417
4418 * .gdbinit (pitx): Fix incorrect references to fields of the
4419 iterator stack.
4420
7b926f3f
CY
44212012-02-17 Chong Yidong <cyd@gnu.org>
4422
4423 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4424
11273115
PE
44252012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4426
4427 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4428 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4429
c3a70e2b
CY
44302012-02-15 Chong Yidong <cyd@gnu.org>
4431
4432 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4433 marked as special. Also, starting docstrings with * is obsolete.
4434
0ca43699
AS
44352012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4436
4437 * gnutls.c (emacs_gnutls_write): Fix last change.
4438
2e8f3c56
LI
44392012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4440
4441 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4442 send_process.
4443
af70074f
SM
44442012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4445
4446 * keymap.c (Fsingle_key_description): Handle char ranges.
4447
95986d52
CY
44482012-02-12 Chong Yidong <cyd@gnu.org>
4449
afd83bd1
CY
4450 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4451 as that creates a dangerous corner case.
4452
95986d52
CY
4453 * window.c (Fdelete_window_internal): Invalidate the mouse
4454 highlight (Bug#9904).
4455
bd7da63e
GM
44562012-02-12 Glenn Morris <rgm@gnu.org>
4457
4458 * xselect.c (Fx_own_selection_internal)
4459 (Fx_get_selection_internal, Fx_disown_selection_internal)
4460 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4461 * nsselect.m (Fx_own_selection_internal)
4462 (Fx_disown_selection_internal, Fx_selection_exists_p)
4463 (Fx_selection_owner_p, Fx_get_selection_internal):
4464 Sync docs and argument specs with the xselect.c versions.
4465
77abcbc2
LI
44662012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4467
4468 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4469
90b671e2
EZ
44702012-02-11 Eli Zaretskii <eliz@gnu.org>
4471
1c0ca0b7
EZ
4472 * w32select.c (Fx_selection_exists_p): Sync doc string and
4473 argument list with xselect.c. (Bug#10783)
4474
4475 * w16select.c (Fx_selection_exists_p): Sync doc string and
4476 argument list with xselect.c. (Bug#10783)
90b671e2 4477
49241268
GM
44782012-02-10 Glenn Morris <rgm@gnu.org>
4479
4480 * fns.c (Fsecure_hash): Doc fix.
4481
f998bbe7 44822012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4483
4484 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4485
0992bd9c
CY
44862012-02-07 Chong Yidong <cyd@gnu.org>
4487
4488 * buffer.c (Fbuffer_local_variables)
4489 (buffer_lisp_local_variables): Handle unbound vars correctly;
4490 don't let Qunbound leak into Lisp.
4491
af008560
GM
44922012-02-07 Glenn Morris <rgm@gnu.org>
4493
dd605cc4
GM
4494 * image.c (Fimagemagick_types): Doc fix.
4495
af008560
GM
4496 * image.c (imagemagick-render-type): Change it from a lisp object
4497 to an integer. Move the doc here from the lisp manual.
4498 Treat all values not equal to 0 the same.
4499
1449fa1d
CY
45002012-02-06 Chong Yidong <cyd@gnu.org>
4501
4502 * doc.c (store_function_docstring): Avoid applying docstring of
4503 alias to base function (Bug#2603).
4504
3723ec07
AS
45052012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4506
4507 * .gdbinit (pp1, pv1): Remove redundant defines.
4508 (pr): Use pp.
4509
79c1cc1e
CY
45102012-02-04 Chong Yidong <cyd@gnu.org>
4511
4512 * nsterm.m: Declare a global (Bug#10694).
4513
d7f29f8e
EZ
45142012-02-04 Eli Zaretskii <eliz@gnu.org>
4515
cae07000
SM
4516 * w32.c (get_emacs_configuration_options):
4517 Include --enable-checking, if specified, in the return value.
d7f29f8e 4518
3b95a6f9
MR
45192012-02-04 Martin Rudalics <rudalics@gmx.at>
4520
4521 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4522 after rounding frame sizes. (Bug#9723)
4523
d6fa96a6
EZ
45242012-02-04 Eli Zaretskii <eliz@gnu.org>
4525
4526 * keyboard.c (adjust_point_for_property): Don't position point
4527 before BEGV. (Bug#10696)
4528
df0b2940
PE
45292012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4530
4531 Handle overflow when computing char display width (Bug#9496).
4532 * character.c (char_width): Return EMACS_INT, not int.
4533 (char_width, c_string_width): Check for overflow when
4534 computing the width; this is possible now that individual
4535 characters can have unbounded width. Problem introduced
4536 by merge from Emacs 23 on 2012-01-19.
4537
6bee44d6
MA
45382012-02-02 Michael Albinus <michael.albinus@gmx.de>
4539
4540 * dbusbind.c (Fdbus_register_method): Mention the return value
4541 :ignore in the docstring.
4542
44f92739
GM
45432012-02-02 Glenn Morris <rgm@gnu.org>
4544
1b9f60cc
GM
4545 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4546
44f92739
GM
4547 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4548 Unconditionally set to t. (Bug#10673)
4549 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4550 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4551 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4552
c5d3843c
KH
45532012-02-02 Kenichi Handa <handa@m17n.org>
4554
4555 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4556 0, do not call append_composite_glyph.
4557
159462d4 45582012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4559
4560 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4561 NULL (Bug#6988).
4562 (x_produce_glyphs): If the component of a composition is a null
4563 string, set it->pixel_width to 1 to avoid zero-width glyph.
4564
78cef877
EZ
45652012-02-01 Eli Zaretskii <eliz@gnu.org>
4566
4567 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4568 first 2 arguments are identical. This makes inserting large
4569 output from a subprocess an order of magnitude faster on
4570 MS-Windows, where all sbrk'ed memory is always contiguous.
4571
97897668
GM
45722012-01-31 Glenn Morris <rgm@gnu.org>
4573
4574 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4575 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4576 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4577
31fd3586
GM
45782012-01-29 Glenn Morris <rgm@gnu.org>
4579
4580 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4581
0e24a8b2
CY
45822012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4583
4584 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4585
cc0adcb0
CY
45862012-01-28 Chong Yidong <cyd@gnu.org>
4587
4588 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4589
acc28cb9
CY
45902012-01-26 Chong Yidong <cyd@gnu.org>
4591
9c69cfb7
CY
4592 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4593
acc28cb9
CY
4594 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4595 repeat counts (Bug#10507).
4596
48da7392
GM
45972012-01-26 Glenn Morris <rgm@gnu.org>
4598
4599 * lread.c (syms_of_lread): Doc fix.
4600
14af5f7f
CY
46012012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4602
4603 * coding.c (encode_designation_at_bol): Change return value to
4604 EMACS_INT.
4605
0b21c100
CY
46062012-01-25 Chong Yidong <cyd@gnu.org>
4607
4608 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4609
3c2907f7
CY
46102012-01-21 Chong Yidong <cyd@gnu.org>
4611
4612 * floatfns.c (Fcopysign): Make the second argument non-optional,
4613 since nil is not allowed anyway.
4614
959ad23f
AS
46152012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4616
4617 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4618 (send_process): Likewise.
4619
34a02f46
MR
46202012-01-19 Martin Rudalics <rudalics@gmx.at>
4621
4622 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4623 (Vwindow_persistent_parameters): Do not use Qstate.
4624 Rewrite doc-strings.
34a02f46 4625
1259009a 46262012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4627
4628 * character.c (char_width): New function.
70d4fdf6
GM
4629 (Fchar_width, c_string_width, lisp_string_width):
4630 Use char_width (Bug#9496).
25ed9e61 4631
6a6ee00d
MR
46322012-01-16 Martin Rudalics <rudalics@gmx.at>
4633
4634 * window.c (Vwindow_persistent_parameters): New variable.
4635 (Fset_window_configuration, save_window_save): Handle persistent
4636 window parameters.
4637
c85efaf7
EZ
46382012-01-14 Eli Zaretskii <eliz@gnu.org>
4639
4640 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4641 thrashing the stack of the thread. (Bug#9087)
4642
5944709e
PE
46432012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4644
4645 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4646
e71f5d99
EZ
46472012-01-11 Eli Zaretskii <eliz@gnu.org>
4648
4649 * xdisp.c (rows_from_pos_range): Handle the case where the
4650 highlight ends on a newline. (Bug#10464)
4651 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4652 he end column for display of highlight that ends on a newline
4653 before a R2L line.
4654
ce316182
GM
46552012-01-11 Glenn Morris <rgm@gnu.org>
4656
4657 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4658 from load-path also when installation-directory is nil. (Bug#10208)
4659
5b43da69
GM
46602012-01-10 Glenn Morris <rgm@gnu.org>
4661
74cc8ff9
GM
4662 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4663
7d8d6e4e
GM
4664 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4665 Update template values to be closer to their typical values these days.
5b43da69 4666
a0db8d43
EZ
46672012-01-09 Eli Zaretskii <eliz@gnu.org>
4668
4669 * xdisp.c (rows_from_pos_range): Accept additional argument
4670 DISP_STRING, and accept any glyph in a row whose object is that
4671 string as eligible for mouse highlight. Fixes mouse highlight of
4672 display strings from overlays. (Bug#10464)
4673
9a0115ab 46742012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4675
b9110d6a 4676 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4677 * fileio.c (auto_saving_dir_umask): New static var.
4678 (Fmake_directory_internal): Use it.
4679 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4680 creating the directory. The old code temporarily assigns
4681 too-generous permissions to the directory.
4682 (do_auto_save_eh): Clear it.
b9110d6a 4683 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4684 that the var is always cleared.
4685
6c1bd3f3
EZ
46862012-01-07 Eli Zaretskii <eliz@gnu.org>
4687
4688 * search.c (scan_buffer): Pass character positions to
4689 know_region_cache, not byte positions. (Bug#6540)
4690
069d2b50
L
46912012-01-07 LynX <_LynX@bk.ru> (tiny change)
4692
4693 * w32.c (sys_rename): Report EXDEV when rename of a directory
4694 fails because the target is on another logical disk. (Bug#10284)
4695
75bf0d33
DB
46962012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4697
4698 * xterm.c (x_embed_request_focus): New function.
4699
4700 * xterm.h: Add prototype.
4701
4702 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4703
1c6e5a32
GM
47042012-01-05 Glenn Morris <rgm@gnu.org>
4705
4706 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4707
651e947e
EZ
47082012-01-01 Eli Zaretskii <eliz@gnu.org>
4709
4710 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4711 Load gnutls_transport_set_lowat only if GnuTLS version is below
4712 2.11.1.
4713 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4714 GnuTLS versions below 2.11.1.
4715
3778cdd8
AL
47162011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4717
4718 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4719 to the doc string advising against its use for altering the way
4720 windows are scrolled.
4721
0e5317f7
KH
47222011-12-28 Kenichi Handa <handa@m17n.org>
4723
4724 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4725 coding-system ASCII compatible only when it does not produce BOM
4726 on encoding (Bug#10383).
4727
93d5ca1f
JD
47282011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4729
4730 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4731 can scroll.
4732 (create_and_show_popup_menu): Always use menu_position_func for
4733 Gtk3 (Bug#10361).
4734
ca22b785
AS
47352011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4736
4737 * callint.c (Fcall_interactively): Don't truncate prompt string.
4738
d048e1e6
EZ
47392011-12-23 Eli Zaretskii <eliz@gnu.org>
4740
4741 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4742 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4743 resumed from there (after widening). (Bug#10360)
d048e1e6 4744
5ccaba1f
JD
47452011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4746
4747 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4748
204ee57f
JD
47492011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4750
b81d40f0
JB
4751 * nsterm.m (x_free_frame_resources):
4752 Release f->output_data.ns->miniimage.
204ee57f
JD
4753 (ns_index_color): Fix indentation. Do not retain
4754 color_table->colors[i].
4755
4756 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4757 before returning.
4758
4759 * nsfns.m (x_set_background_color): Assign return value from
4760 ns_index_color to face-background instead of NSColor*.
4761 (ns_implicitly_set_icon_type): Fix indentation.
4762 Change assignment in for loop to comparison.
4763
4764 * emacs.c (ns_pool): New variable.
4765 (main): Assign ns_pool.
4766 (Fkill_emacs): Call ns_release_autorelease_pool.
4767
4768 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4769 autorelease fdesc, release fdAttrs and tdict.
4770 (ns_get_covering_families): Release charset.
4771 (ns_findfonts): Release NSFontDescriptor created with new.
4772 (ns_uni_to_glyphs): Fix indentation.
4773 (setString): Release attrStr before assigning new value.
4774
c803b2b7
JD
47752011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4776
678f4426
JD
4777 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4778 and NS_IMPL_COCOA.
4779 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4780 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4781
cd394be1 47822011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4783
5fecd5fc
JD
4784 * nsterm.m (ns_term_init): Subscribe for notifications
4785 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4786 to method trackingNotification in EmacsMenu.
4787
4788 * nsmenu.m (trackingMenu): New variable.
3771cb17 4789 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4790 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4791 from Aquamacs (Bug#7030).
678f4426
JD
4792
47932011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4794
c803b2b7
JD
4795 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4796 (symbol_to_nsstring): Fix indentation.
4797 (ns_symbol_to_pb): New function.
cae07000
SM
4798 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4799 (Fns_rotate_cut_buffers_internal): Remove.
4800 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4801 Fns_store_cut_buffer_internal.
4802 (ns_get_foreign_selection, Fx_own_selection_internal)
4803 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4804 (Fns_get_selection_internal, Fns_store_selection_internal):
4805 Use ns_symbol_to_pb and check if return value is nil.
4806 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4807 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4808 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4809 renamed to Sns_store_selection_internal.
4810 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4811 and remove this function.
4812 (ns_handle_selection_clear): Remove, never used.
4813 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4814 here.
4815
e1b01a3a
KB
48162011-12-17 Ken Brown <kbrown@cornell.edu>
4817
4818 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4819 GID is unknown (Bug#10257).
4820
2adb6e85
PE
48212011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4822
4823 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4824 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4825 which caused a build failure on GNU/Linux IA-64. This problem was
4826 introduced by my 2011-10-07 patch.
4827
d1d7b339
JL
48282011-12-15 Juri Linkov <juri@jurta.org>
4829
4830 * image.c (imagemagick_error): New function. (Bug#10112)
4831 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4832 Use `imagemagick_error' where ImageMagick functions return
4833 `MagickFalse'.
4834 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4835 proper order.
4836
100d5755
KH
48372011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4838
4839 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4840 fill background (Bug#8992).
4841
454592a6
MR
48422011-12-13 Martin Rudalics <rudalics@gmx.at>
4843
4844 * window.c (Vwindow_combination_resize)
4845 (Vwindow_combination_limit): Use t instead of non-nil in
4846 doc-strings.
61d4b438
MR
4847 (Vrecenter_redisplay): Add first sentence of doc-string on
4848 separate line.
53524d93 4849 (Frecenter): Fix doc-string typo.
454592a6 4850
3633e3aa
KH
48512011-12-11 Kenichi Handa <handa@m17n.org>
4852
4853 * coding.c (Funencodable_char_position): Pay attention to the
4854 buffer text relocation (Bug#9389).
4855
7b9d523a 48562011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4857
7b9d523a
JD
4858 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4859 gtk_init (Bug#10100).
4860
b73189c6
EZ
48612011-12-10 Eli Zaretskii <eliz@gnu.org>
4862
4863 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4864 IT->string is nil. (Bug#10263)
4865
f7dfe5d6
JD
48662011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4867
83faebb4
JD
4868 * nsterm.h (x_free_frame_resources): Declare.
4869
f7dfe5d6
JD
4870 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4871 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4872
4873 * nsterm.h (ns_get_defaults_value): Declare.
4874
4875 * nsterm.m (ns_default): Call ns_get_defaults_value.
4876
7cd4e72c
EZ
48772011-12-09 Eli Zaretskii <eliz@gnu.org>
4878
4879 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4880 (Bug#10170)
4881
b34d7317
YM
48822011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4883
4884 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4885 that where the value of an _OBJC_* symbol points to is in the .bss
4886 section (Bug#10240).
4887
76470ad1
KH
48882011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4889
4890 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4891 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4892
745fff94
KH
48932011-12-08 Kenichi Handa <handa@m17n.org>
4894
4895 * ftfont.c (get_adstyle_property): Fix previous change
4896 (Bug#10233).
4897
6e44397c
JB
48982011-12-07 Juanma Barranquero <lekktu@gmail.com>
4899
4900 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4901 dirs from the default value of EMACSLOADPATH (bug#10208).
4902
7efa6272
GM
49032011-12-07 Glenn Morris <rgm@gnu.org>
4904
4905 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4906 installation and source directories as well. (Bug#10208)
4907
f6fc4d87
CY
49082011-12-06 Chong Yidong <cyd@gnu.org>
4909
4910 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4911
2bf26180
GM
49122011-12-06 Glenn Morris <rgm@gnu.org>
4913
4914 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4915 as an error, not just -1. (Bug#10217)
4916
3a6ad4f0
CY
49172011-12-05 Chong Yidong <cyd@gnu.org>
4918
4919 * keyboard.c (process_special_events): New function.
4920 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4921
75a3b399
PE
49222011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4923
4924 * coding.c (encode_designation_at_bol): Don't use uninitialized
4925 local variable (Bug#9318).
4926
c3c9e25e
KH
49272011-12-05 Kenichi Handa <handa@m17n.org>
4928
4929 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4930 return Qnil (Bug#8046, Bug#10193).
4931
5eb05ea3
KH
49322011-12-05 Kenichi Handa <handa@m17n.org>
4933
4934 * coding.c (encode_designation_at_bol): New args charbuf_end and
4935 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4936 (coding_set_source): Return how many bytes coding->source was
4937 relocated.
4938 (coding_set_destination): Return how many bytes
4939 coding->destination was relocated.
4940 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4941 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4942
49432011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4944
4945 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4946 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4947 macro (Bug#9318).
4948
49492011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4950
4951 The following changes are to fix Bug#9318.
4952
a79703f5 4953 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4954 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4955 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4956 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4957
7dbda6df
JB
49582011-12-05 Juanma Barranquero <lekktu@gmail.com>
4959
4960 * lisp.h (process_quit_flag): Fix external declaration.
4961
6d5eb5b0
SM
49622011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4963
4964 Don't macro-inline non-performance-critical code.
4965 * eval.c (process_quit_flag): New function.
4966 * lisp.h (QUIT): Use it.
4967
a0c3fad0
JD
49682011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4969
4970 * nsfns.m (get_geometry_from_preferences): New function.
4971 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4972
6c07aac2
AS
49732011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4974
4975 * emacs.c (Qkill_emacs): Define.
4976 (syms_of_emacs): Initialize it.
4977 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4978 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4979 (quit_throw_to_read_char): Add parameter `from_signal'.
4980 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4981 * lisp.h (QUIT): Call Fkill_emacs if requested.
4982
c052ead4
JD
49832011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4984
4985 * widget.c (update_wm_hints): Return if wmshell is null.
4986 (widget_update_wm_size_hints): New function.
4987
4988 * widget.h (widget_update_wm_size_hints): Declare.
4989
4990 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4991 widget_update_wm_size_hints (Bug#10104).
4992
9e49252b
EZ
49932011-12-03 Eli Zaretskii <eliz@gnu.org>
4994
4995 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4996 before a newline, prepare the bidi iterator for consuming the
4997 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4998 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4999
02b16839
JL
50002011-12-02 Juri Linkov <juri@jurta.org>
5001
5002 * search.c (Fword_search_regexp): New Lisp function created from
5003 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5004 (Fword_search_backward, Fword_search_forward)
5005 (Fword_search_backward_lax, Fword_search_forward_lax):
5006 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5007 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5008
0068070e
SM
50092011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5010
5011 * fileio.c (Finsert_file_contents): Move after-change-function call
5012 to before the "handled:" label, since all "goto handled" appear in
5013 cases where the *-change-functions have already been properly called
5014 (bug#10117).
5015
3360a3fc
AS
50162011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5017
5018 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5019 waiting for input. (Bug#10169)
5020
73d6c093
EZ
50212011-11-30 Eli Zaretskii <eliz@gnu.org>
5022
5023 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5024 verifies glyph row's hash code--we have just reallocated the
5025 glyphs, so their contents can be complete garbage. (Bug#10164)
5026
febe6bea
JB
50272011-11-30 Juanma Barranquero <lekktu@gmail.com>
5028
5029 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5030
801a4313
EZ
50312011-11-30 Eli Zaretskii <eliz@gnu.org>
5032
5033 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5034 attributes are tested _before_ calling verify_row_hash, to protect
5035 against GCC re-ordering of the tests. (Bug#10164)
5036
2b56b87e
JD
50372011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5038
5039 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5040
5041 * xterm.c (handle_one_xevent): Only set async_visible and friends
5042 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5043 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5044 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5045
dbf31225
PE
50462011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5047
5048 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5049 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5050 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5051 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5052 All uses changed to use GCPRO1 etc.
5053 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5054 Revert to old implementation (i.e., before 2011-03-11).
5055
1305621b
YM
50562011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5057
5058 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5059 of scroll runs so as to avoid assigning disabled bogus rows and
5060 unnecessary graphics copy operations.
5061
8c9afb46
EZ
50622011-11-27 Eli Zaretskii <eliz@gnu.org>
5063
5064 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5065 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5066 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5067 (malloc, free, realloc, calloc): Redirect to e_* only when
5068 compiling Emacs.
5069
5070 * lisp.h (GCTYPEBITS): Move before first use.
5071 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5072 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5073 this macro definition.
5074
5075 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5076 _MSC_VER.
5077
54e9e3bf
JD
50782011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5079
6d5eb5b0
SM
5080 * gtkutil.c (xg_create_frame_widgets):
5081 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5082 present with Gtk+ 2.0.
5083
83aca1cb
PE
50842011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5085
5086 * fileio.c (Finsert_file_contents): Undo previous change; see
5087 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5088
5b76caa4
PE
50892011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5090
5091 Rename locals to avoid shadowing.
5092 * fileio.c (Finsert_file_contents):
5093 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5094 * process.c (wait_reading_process_output):
5095 Rename inner 'proc' to 'p' to avoid shadowing.
5096 Indent for consistency with usual Emacs style.
5097
8c535114
EZ
50982011-11-25 Eli Zaretskii <eliz@gnu.org>
5099
5100 * xdisp.c (redisplay_window): If cursor row is not fully visible
5101 after recentering, and scroll-conservatively is set to a large
5102 number, scroll window by a few more lines to make the cursor fully
5103 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5104 (start_display): Don't move to the next line if the display should
5105 start at a newline that is part of a display vector or an overlay
5106 string. (Bug#10119)
8c535114 5107
fa4fdb5c
JL
51082011-11-24 Juri Linkov <juri@jurta.org>
5109
5110 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5111 after the `MagickPingImage' call. (Bug#10112)
5112
90ec88df
CY
51132011-11-23 Chong Yidong <cyd@gnu.org>
5114
5115 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5116
56e2e794
MR
51172011-11-23 Martin Rudalics <rudalics@gmx.at>
5118
5119 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5120 making another buffer current. (Bug#10114)
5121
b6e64c41
GM
51222011-11-23 Glenn Morris <rgm@gnu.org>
5123
5124 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5125
6b21de18
CY
51262011-11-23 Chong Yidong <cyd@gnu.org>
5127
5128 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5129 using it (Bug#5984).
5130
b12cd789
EZ
51312011-11-22 Eli Zaretskii <eliz@gnu.org>
5132
5133 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5134 and header-lines, as they don't have one computed for them.
5135 (Bug#10098)
5136
5137 * .gdbinit (prow): Make displayed values more self-explaining.
5138 Add row's hash code.
5139
261b6fd4
LMI
51402011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5141
5142 * process.c (wait_reading_process_output): Fix asynchrounous
5143 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5144 (wait_reading_process_output): Add comment and URL.
261b6fd4 5145
e7cfd277
JD
51462011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5147
5148 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5149
a9b9b7f5
CY
51502011-11-21 Chong Yidong <cyd@gnu.org>
5151
5152 * window.c (Fnext_window, Fprevious_window): Doc fix.
5153
b0d15b4f
SM
51542011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5155
5156 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5157
fe7a3057
JB
51582011-11-20 Juanma Barranquero <lekktu@gmail.com>
5159
5160 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5161
d2999b1a
MR
51622011-11-20 Martin Rudalics <rudalics@gmx.at>
5163
5164 * window.c (Fset_window_combination_limit): Rename argument
5165 STATUS to LIMIT.
5166 (Vwindow_combination_limit): Remove "status" from doc-string.
5167
d5ff9cd0
AS
51682011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5169
5170 * m/ibms390.h: Remove.
5171 * m/ibms390x.h: Don't include "ibms390.h".
5172
a5bb9bd3
SM
51732011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5174
5175 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5176 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5177
cd1181db
JB
51782011-11-20 Juanma Barranquero <lekktu@gmail.com>
5179
5180 * casetab.c (Fset_case_table):
5181 * charset.c (Fcharset_after): Fix typos.
5182
615a3b8d 51832011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5184
17e845af
PE
5185 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5186 Otherwise, valgrind does not work on some platforms.
5187 Problem reported by Andreas Schwab in
6a0bf43d
PE
5188 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5189 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5190 is set, removing the need for VIRT_ADDRESS_VARIES.
5191 (PURE_P): Use a more-efficient implementation that needs just one
5192 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5193 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5194 to 4 (xorl, subq, cmpq, setbe).
5195 * alloc.c (pure): Always extern now, since that's the
5196 VIRT_ADDR_VARIES behavior.
5197 (PURE_POINTER_P): Use a single comparison, not two, for
5198 consistency with the new puresize.h.
5199 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5200 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5201 Remove VIRT_ADDR_VARIES no longer needed.
5202
f8fe6f96
EZ
52032011-11-19 Eli Zaretskii <eliz@gnu.org>
5204
5205 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5206 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5207 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5208 behave as if the cursor position were at the window margin.
5209
5210 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5211 and the cursor position is out of bounds, behave as if the cursor
5212 position were at the window margin. (Bug#10075)
5213
df05a53c
CY
52142011-11-18 Chong Yidong <cyd@gnu.org>
5215
5216 * window.c (Fwindow_combination_limit): Make first argument
5217 non-optional, since it is meaningless for live windows like the
5218 selected window.
61ccba97 5219
2071918e
DA
52202011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5221
5222 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5223
b50a28de
SM
52242011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5225
5226 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5227 (graft_intervals_into_buffer): Simplify.
5228
015137db
EZ
52292011-11-18 Eli Zaretskii <eliz@gnu.org>
5230
5231 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5232 hash values of the two rows.
5233 (copy_row_except_pointers): Preserve the used[] arrays and the
5234 hash values of the two rows. (Bug#10035)
68c95424 5235 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5236
5237 * xdisp.c (row_hash): New function, body extracted from
5238 compute_line_metrics.
5239 (compute_line_metrics): Call row_hash, instead of computing the
5240 hash code inline.
5241
5242 * dispnew.c (verify_row_hash): Call row_hash for computing the
5243 hash code of a row, instead of duplicating code from xdisp.c.
5244
5245 * dispextern.h (row_hash): Add prototype.
5246
a2addb04
TH
52472011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5248
5249 * frame.c (delete_frame): Don't delete the terminal when the last
5250 X frame is closed if emacs is built with GTK toolkit.
5251
df85d315
JB
52522011-11-17 Juanma Barranquero <lekktu@gmail.com>
5253
5254 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5255
a0c2d0ae
MR
52562011-11-17 Martin Rudalics <rudalics@gmx.at>
5257
5258 * window.c (Vwindow_splits): Rename to
5259 Vwindow_combination_resize. Suggested by Juri Linkov.
5260 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5261 of Vwindow_splits.
5262
58179cce
JB
52632011-11-16 Juanma Barranquero <lekktu@gmail.com>
5264
7877f373
JB
5265 * nsfns.m (Fns_font_name):
5266 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5267
b6f67890
MR
52682011-11-16 Martin Rudalics <rudalics@gmx.at>
5269
5270 * window.h (window): Rename slot "nest" to "combination_limit".
5271 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5272 (Fset_window_nest): Rename to Fset_window_combination_limit.
5273 (Vwindow_nest): Rename to Vwindow_combination_limit.
5274 (recombine_windows, make_parent_window, make_window)
5275 (Fsplit_window_internal, saved_window)
5276 (Fset_window_configuration, save_window_save): Rename all
5277 occurrences of window_nest to window_combination_limit.
5278
c7015153
JB
52792011-11-15 Juanma Barranquero <lekktu@gmail.com>
5280
5281 * image.c (imagemagick_load_image): Fix typo.
5282
322ad6ec
EZ
52832011-11-14 Eli Zaretskii <eliz@gnu.org>
5284
5285 * xdisp.c (display_line): Move the call to
5286 highlight_trailing_whitespace before the call to
5287 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5288 faces of all the glyphs to compute ROW's hash value.
5289 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5290
f067b8ec
JB
52912011-11-14 Juanma Barranquero <lekktu@gmail.com>
5292
5293 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5294 just return (bug#10044).
5295
1e5b2111
EZ
52962011-11-12 Eli Zaretskii <eliz@gnu.org>
5297
7ef3cbd5
EZ
5298 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5299 with user-defined heap size. Bump the default size of the temacs
5300 heap to 27MB, to avoid memory warning when running temacs.
5301 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5302
1e5b2111
EZ
5303 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5304 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5305 (verify_row_hash) [XASSERTS]: New function.
5306 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5307 that the hash value of glyph rows is correct.
1e5b2111 5308
89d61221
MR
53092011-11-12 Martin Rudalics <rudalics@gmx.at>
5310
5311 * window.h (window): Remove splits slot.
5312 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5313 (Fdelete_other_windows_internal, make_parent_window)
5314 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5315 (Fset_window_configuration, save_window_save): Don't deal with
5316 split status of windows.
5317 (saved_window): Remove splits slot.
5318 (Vwindow_splits): Rewrite doc-string.
5319
97f18cc8
JD
53202011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5321
5322 * xfns.c (unwind_create_frame):
5323 * nsfns.m (unwind_create_frame):
5324 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5325 Vframe_list (Bug#9999).
5326
22a648b4
DA
53272011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5328
0b381c7e 5329 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5330
659afede
KH
53312011-11-11 Kenichi Handa <handa@m17n.org>
5332
5333 * callproc.c (Fcall_process): Set the member dst_multibyte of
5334 process_coding.
5335
9ac0394b
KH
53362011-11-11 Johan Bockgård <bojohan@gnu.org>
5337
5338 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5339 avoid a crash (bug#9496).
5340
2fbdc249
CY
53412011-11-09 Chong Yidong <cyd@gnu.org>
5342
5343 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5344 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5345
ac6b1f81
PE
53462011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5347
5348 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5349
09db192c
PE
53502011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5351
5352 Avoid some portability problems by eschewing 'extern inline' functions.
5353 The trivial performance wins aren't worth the portability hassles; see
5354 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5355 et seq.
5356 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5357 (window_box_width, window_box_left, window_box_left_offset)
5358 (window_box_right, window_box_right_offset): Undo previous change,
5359 by removing the "extern"s.
5360 * intervals.c (adjust_intervals_for_insertion)
5361 (adjust_intervals_for_deletion): Undo previous change,
5362 making these static again.
5363 (offset_intervals, temp_set_point_both, temp_set_point)
5364 (copy_intervals_to_string): No longer inline.
5365 * xdisp.c (window_text_bottom_y, window_box_width)
5366 (window_box_height, window_box_left_offset)
5367 (window_box_right_offset, window_box_left, window_box_right)
5368 (window_box): No longer inline.
5369
105216ed
CY
53702011-11-08 Chong Yidong <cyd@gnu.org>
5371
5372 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5373 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5374 Signal an error if not a live window.
105216ed
CY
5375 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5376 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5377
ae9e237f
JB
53782011-11-07 Juanma Barranquero <lekktu@gmail.com>
5379
5380 * lisp.h (syms_of_abbrev): Remove declaration.
5381 Reported by CHENG Gao <chenggao@royau.me>.
5382
c7aa8333
EZ
53832011-11-07 Eli Zaretskii <eliz@gnu.org>
5384
5385 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5386 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5387 of temacs in GUI mode.
5388
be7f5545
MR
53892011-11-07 Martin Rudalics <rudalics@gmx.at>
5390
5391 * window.h: Declare delete_all_child_windows instead of
5392 delete_all_subwindows.
5393 * window.c (Fwindow_nest, Fset_window_nest)
5394 (Fset_window_new_total, Fset_window_new_normal)
5395 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5396 (delete_all_subwindows): Rename to delete_all_child_windows.
5397 (Fdelete_other_windows_internal, Fset_window_configuration):
5398 Call delete_all_child_windows instead of delete_all_subwindows.
5399 * frame.c (delete_frame): Call delete_all_child_windows instead
5400 of delete_all_subwindows.
5401
ca78dc43
PE
54022011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5403
5404 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5405 This is also needed for porting to any host where GC_MARK_STACK is
5406 not GC_MAKE_GCPROS_NOOPS.
5407 (which_symbols): Use it.
5408
a0241d01
KH
54092011-11-07 Kenichi Handa <handa@m17n.org>
5410
5411 * coding.c (coding_set_destination): Check coding->src_pos only
5412 when coding->src_object is a buffer (bug#9910).
5413
5414 * process.c (send_process): Set the member src_multibyte of coding
5415 to 0 (bug#9911) when sending a unibyte text.
5416
5417 * callproc.c (Fcall_process): Set the member src_multibyte of
5418 process_coding to 0 (bug#9912).
5419
a64bfdfa 54202011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5421
5422 * xmenu.c (cleanup_widget_value_tree): New function.
5423 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5424 calling free_menubar_widget_value_tree directly (Bug#9830).
5425
cb41b32a
PE
54262011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5427
5428 Fix some portability problems with 'inline'.
5429 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5430 (window_box_width, window_box_left, window_box_left_offset)
5431 (window_box_right, window_box_right_offset): Declare extern.
5432 Otherwise, these inline functions do not conform to C99 and
5433 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5434 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5435 * intervals.c (adjust_intervals_for_insertion)
5436 (adjust_intervals_for_deletion): Now extern, because otherwise the
5437 extern inline functions 'offset_intervals' couldn't refer to it.
5438 (static_offset_intervals): Remove.
5439 (offset_intervals): Rewrite using the old contents of
5440 static_offset_intervals. The old version didn't conform to C99
5441 because an extern inline function contained a reference to an
5442 identifier with static linkage.
5443
b7041366
AS
54442011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5445
5446 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5447 GC.
5448
88a37c4d
EZ
54492011-11-06 Eli Zaretskii <eliz@gnu.org>
5450
5451 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5452 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5453 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5454 return Qleft_to_right.
5455
49745b39
CY
54562011-11-06 Chong Yidong <cyd@gnu.org>
5457
5458 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5459 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5460 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5461 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5462 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5463 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5464 (Fwindow_vscroll): Doc fix.
5465 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5466 argument, since it makes no sense to pass a live window and for
5467 consistency with window-child.
5468
1f05cd82
CS
54692011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5470
5471 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5472 support MSVC.
5473
22610910
JR
54742011-11-05 Jason Rumney <jasonr@gnu.org>
5475
5476 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5477 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5478 fonts (Bug#6029).
5479 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5480 bitwise arithmetic preventing use of unicode-sip and non-truetype
5481 opentype fonts.
5482
a06776b2
EZ
54832011-11-05 Eli Zaretskii <eliz@gnu.org>
5484
3ad924ba
EZ
5485 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5486 "emacs"-only part.
5487
a06776b2
EZ
5488 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5489 initialization code to keep similarity to xfns.c after changes
5490 from 2011-11-05.
5491
c9e7db78
JD
54922011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5493
a97f8f3f
JD
5494 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5495 (unwind_create_frame): New function (Bug#9943).
5496 (Fx_create_frame): Restructure code to be more similar to the one in
5497 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5498 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5499 Move terminal->reference_count++ just before making the frame official
5500 (Bug#9943).
5501
5502 * nsterm.m (x_free_frame_resources): New function.
5503 (x_destroy_window): Move code to x_free_frame_resources.
5504
c9e7db78 5505 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5506 (Fx_create_frame, x_create_tip_frame):
5507 Move terminal->reference_count++ just before making the frame
75f1671a 5508 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5509 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5510
a6fc3b5c
EZ
55112011-11-05 Eli Zaretskii <eliz@gnu.org>
5512
5513 Support MSVC build with newer versions of Visual Studio.
5514 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5515 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5516 nt/gmake.defs.
5517
5518 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5519 which are not supported by MSVC.
5520 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5521 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5522 bitfields.
5523 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5524 types in bitfields.
5525 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5526
5527 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5528
58179cce 55292011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5530
5531 Support MSVC build with newer versions of Visual Studio.
5532 * w32.c: Don't include w32api.h for MSVC.
5533 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5534
5535 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5536 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5537 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5538 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5539 e_* cousins.
5540 (alloca) [_MSC_VER]: Define to _alloca.
5541
5542 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5543
5544 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5545
a58c13ed
EZ
55462011-11-04 Eli Zaretskii <eliz@gnu.org>
5547
5548 * xdisp.c (note_mouse_highlight): If either of
5549 previous/next-single-property-change returns nil, treat that as
5550 the beginning or the end of the buffer. (Bug#9955)
5551
fe0b6370
JD
55522011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5553
a58c13ed 5554 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5555 label is not null (Bug#9951).
5556 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5557 may be NULL.
5558
89bd5ee1
EZ
55592011-11-04 Eli Zaretskii <eliz@gnu.org>
5560
5561 * window.c (Fwindow_body_size): Mention in the doc string that the
5562 return value is in frame's canonical units. (Bug#9949)
5563
84c3edb9
EZ
55642011-11-03 Eli Zaretskii <eliz@gnu.org>
5565
4e2fb5c7
EZ
5566 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5567
84c3edb9 5568 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5569 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5570 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5571
bc17a887
EZ
55722011-11-01 Eli Zaretskii <eliz@gnu.org>
5573
5574 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5575 Don't stop backward scan on the continuation glyph, even though
5576 its CHARPOS is positive.
6d5eb5b0
SM
5577 (mouse_face_from_buffer_pos, note_mouse_highlight):
5578 Rename cover_string to disp_string.
bc17a887 5579
4ee88440
MR
55802011-11-01 Martin Rudalics <rudalics@gmx.at>
5581
5582 * window.c (temp_output_buffer_show): Don't use
5583 Vtemp_buffer_show_specifiers.
5584 (Vtemp_buffer_show_specifiers): Remove unused variable.
5585
c2ff3c02
EZ
55862011-10-30 Eli Zaretskii <eliz@gnu.org>
5587
5588 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5589 past the beginning of the current glyph matrix.
5590
58179cce 55912011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5592
5593 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5594 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5595 HAVE_GTK3 (Bug#9869).
b77a6a7f 5596
3b574623
JD
5597 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5598 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5599
b77a6a7f
JD
5600 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5601
5602 * xterm.c: Declare x_handle_net_wm_state to return int.
5603 (handle_one_xevent): Check if we are iconified but don't have
5604 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5605 (get_current_wm_state): Return non-zero if not hidden,
5606 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5607 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5608 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5609 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5610
196e41e4
PE
56112011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5612
5613 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5614 so that this new function doesn't get optimized away by a
5615 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5616
021f2e1a
AS
56172011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5618
5619 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5620
8b058d44
EZ
56212011-10-29 Eli Zaretskii <eliz@gnu.org>
5622
5623 Fix the `xbytecode' command.
5624 * .gdbinit (xprintbytestr): New command.
b50a28de 5625 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5626 (xbytecode): Print the byte-code string as well.
5627
4452fb80
EZ
56282011-10-29 Kim Storm <storm@cua.dk>
5629
8b058d44
EZ
5630 * alloc.c (which_symbols): New function.
5631
21b72067
AS
56322011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5633
5634 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5635 line. (Bug#9903)
5636
83ed7b5c
GM
56372011-10-29 Glenn Morris <rgm@gnu.org>
5638
5639 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5640 Not clear what it was for, and it causes various bugs. (Bug#9839)
5641
5a7a728b
EZ
56422011-10-28 Eli Zaretskii <eliz@gnu.org>
5643
5644 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5645 possible random value that matches one of those tested as
5646 condition to clear the mouse face.
5647
d3d0842f
CY
56482011-10-28 Chong Yidong <cyd@gnu.org>
5649
5650 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5651
31b39d13
DN
56522011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5653
5654 * window.c (make_window): Initialize phys_cursor_on_p.
5655
9aba6043
SM
56562011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5657
5658 * lisp.h (struct Lisp_Symbol): Update comments.
5659
c20992f4
JB
56602011-10-28 Juanma Barranquero <lekktu@gmail.com>
5661
5662 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5663
db4f02f2
EZ
56642011-10-28 Eli Zaretskii <eliz@gnu.org>
5665
5666 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5667 <oslsachem@gmail.com> for helping to debug this.
5668
5669 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5670 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5671 (g_b_init_get_glyph_outline_w): New static variables.
5672 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5673 (GetGlyphOutlineW_Proc): New typedefs.
5674 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5675 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5676 New functions.
5677 (w32font_open_internal, compute_metrics):
5678 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5679 instead of calling the "wide" APIs directly.
5680
5681 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5682
5683 * w32.h (syms_of_w32font): Add prototype.
5684
87e68db4
JB
56852011-10-27 Juanma Barranquero <lekktu@gmail.com>
5686
5687 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5688 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5689 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5690 (Fmove_to_window_line): Doc fix.
5691
435c1d67
CY
56922011-10-27 Chong Yidong <cyd@gnu.org>
5693
5694 * process.c (make_process): Set gnutls_state to NULL.
5695
5696 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5697 non-NULL, regardless of GNUTLS_INITSTAGE.
5698 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5699 an error. Set process slots as soon as we allocate them.
5700
5701 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5702
9c6c6f49
CY
57032011-10-27 Chong Yidong <cyd@gnu.org>
5704
9aba6043
SM
5705 * gnutls.c (emacs_gnutls_deinit): New function.
5706 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5707 (Fgnutls_deinit, Fgnutls_boot): Use it.
5708
5709 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5710 (deactivate_process): Call emacs_gnutls_deinit.
5711
657d08d3
JB
57122011-10-27 Juanma Barranquero <lekktu@gmail.com>
5713
5714 * image.c (x_create_x_image_and_pixmap):
5715 * w32.c (sys_rename, w32_delayed_load):
5716 * w32font.c (fill_in_logfont):
5717 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5718
5430d399
JB
57192011-10-26 Juanma Barranquero <lekktu@gmail.com>
5720
5721 * w32fns.c (w32_default_color_map): New function,
5722 extracted from Fw32_default_color_map.
a7ef684b 5723 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5724
fe0055fa
PE
57252011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5726
5727 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5728
e6346438
SM
57292011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5730
5731 * keyboard.c (test_undefined): New function (bug#9751).
5732 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5733
e112cc37
ET
57342011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5735
5736 * sysdep.c (init_sys_modes): Fix the check for the controlling
5737 terminal (Bug#6649).
5738
7b5d6677
EZ
57392011-10-20 Eli Zaretskii <eliz@gnu.org>
5740
5741 * dispextern.h (struct bidi_it): New member next_en_type.
5742
5743 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5744 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5745 current character, check also for next_en_type being WEAK_EN.
5746 (bidi_resolve_weak): Don't enter the expensive loop if the current
5747 position is before next_en_pos. Record the bidi type of the first
5748 non-ET, non-BN character we find, in addition to its position.
5749 (bidi_level_of_next_char): Invalidate next_en_type when
5750 next_en_pos is over-stepped.
5751
7da0b018
PE
57522011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5753
5754 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5755 * editfns.c: Rewrite current-time-zone so that it invokes
5756 the equivalent of (format-time-string "%Z") to get the time zone name.
5757 This fixes a bug when the time zone name contains characters that
5758 need converting from the system time locale to Emacs internal format.
5759 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5760 that patch fixed format-time-string to do the conversion, but
5761 I forgot to fix current-time-zone.
5762 (format_time_string): New function, containing most of
5763 what Fformat_time_string used to contain.
5764 (Fformat_time_string): Rewrite in terms of format_time_string.
5765 This doesn't change this function's behavior.
5766 (current-time-zone): Rewrite to use format_time_string.
5767 This fixes the bug reported by Michael Schierl in
5768 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5769 Jason Rumney's 2007-06-07 change worked around this bug, but
5770 didn't fix it.
5771 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5772
8547b010
EZ
57732011-10-19 Eli Zaretskii <eliz@gnu.org>
5774
5775 * xdisp.c (start_display): If the character at POS is displayed
5776 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5777 (try_window_reusing_current_matrix): If a line ends in a display
5778 vector or the next line starts in a display vector, continue
5779 redrawing the window even though the character position of
5780 start_row was reached.
8547b010
EZ
5781 (Bug#9771, part 2)
5782
4e948d15
CY
57832011-10-18 Chong Yidong <cyd@gnu.org>
5784
5785 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5786 with nobreak-char-display too.
5787
4787455f
EZ
57882011-10-18 Eli Zaretskii <eliz@gnu.org>
5789
5790 Fix part 3 of bug#9771.
5791 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5792 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5793 non-neutral characters if the current character is a paragraph
5794 separator (a.k.a. Newline). This avoids running the same
5795 expensive loop twice, once when we consume the preceding newline
5796 and the other time when the line actually needs to be displayed.
5797 Avoid the loop when we see neutrals on the base embedding level
5798 following a character whose directionality is the same as the
5799 paragraph's. This avoids running the expensive loop when a line
5800 ends in a long sequence of neutrals, like control characters.
5801 Add assertion against STRONG_AL type. Slightly rearrange code
5802 that determines the type of a neutral given the first non-neutral
5803 that follows it.
5804 (bidi_level_of_next_char): Set next_en_pos to zero when
5805 invalidating its info.
5806
2c91f553
EZ
58072011-10-17 Eli Zaretskii <eliz@gnu.org>
5808
5809 * xdisp.c (push_display_prop): Determine whether to record string
5810 or buffer position by IT->string, not by IT->method. Allow
5811 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5812 (move_it_vertically_backward): Don't look for character position
5813 immediately after the newline when in a continuation line.
5814 (Bug#9771, part 1)
2c91f553 5815
c7b08b0d
MR
58162011-10-15 Martin Rudalics <rudalics@gmx.at>
5817
5818 * window.c (coordinates_in_window): Rewrite and delabelize
5819 vertical border check. (Bug#5357) (Bug#9618)
5820
6b02f655
SM
58212011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5822
5823 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5824 errors in XSetWindowBorder (bug#9310).
5825
81d40c92
DA
58262011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5827
5828 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5829 avoid crash when xmalloc overrun checking is enabled.
5830
d4172c3b
EZ
58312011-10-13 Eli Zaretskii <eliz@gnu.org>
5832
5833 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5834 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5835 cursor motion with <left> and <right> arrow keys.
5836
5837 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5838 some callers set that themselves.
5839
b00eea75
EZ
58402011-10-12 Eli Zaretskii <eliz@gnu.org>
5841
5842 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5843 display string and the previous row comes from the same string and
5844 is empty. (Bug#9739) (Bug#9738)
5845
8fe012c4
SM
58462011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5847
5848 * doc.c (get_doc_string): Encode file name (bug#9735).
5849
0074aef2
EZ
58502011-10-12 Eli Zaretskii <eliz@gnu.org>
5851
79beb178
EZ
5852 * bidi.c (bidi_level_of_next_char):
5853 * xdisp.c (get_visually_first_element): Remove old incorrect
5854 comments regarding the Unicode Line Separator character.
5855
0074aef2
EZ
5856 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5857
6e4b3fbe
DA
58582011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5859
5860 * alloc.c (Fgc_status): Do not access beyond zombies array
5861 boundary if nzombies > MAX_ZOMBIES.
5862 * alloc.c (dump_zombies): Add missing format specifier.
5863
0324f3af
PE
58642011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5865
b5525cac
PE
5866 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5867 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5868
0324f3af
PE
5869 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5870 Some packages use them to denote characters with modifiers.
5871
e9b5f888
AS
58722011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5873
5874 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5875 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5876 matching a pp-number. Rename parameter var to var1.
5877
127827c0
SM
58782011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5879
5880 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5881
c8fd3bd0
GM
58822011-10-08 Glenn Morris <rgm@gnu.org>
5883
5884 * callint.c (Fcall_interactively): Give a more explicit error for the
5885 'c' case with a non-character input. (Bug#8479)
5886
352ec8ff
EZ
58872011-10-08 Eli Zaretskii <eliz@gnu.org>
5888
03669ccb
EZ
5889 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5890 lines.
7061c986
EZ
5891 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5892 lines that are hscrolled on the left.
03669ccb 5893
352ec8ff
EZ
5894 * dispnew.c (buffer_posn_from_coords): Account for a possible
5895 presence of header-line. (Bug#4426)
5896
a66cfb1c
SM
58972011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5898
6b02f655
SM
5899 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5900 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5901
7c5ee88e
PE
59022011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5903
5904 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5905 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5906 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5907 this makes Emacs dump core during garbage collection on rare
5908 occasions. sizeof is obviously inferior to offsetof here, so
5909 stick with offsetof.
5910 (GC_POINTER_ALIGNMENT): New macro.
5911 (mark_memory): Omit 3rd (offset) arg; caller changed.
5912 Don't assume EMACS_INT alignment is the same as pointer alignment.
5913
df1bbe5b
SM
59142011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5915
5916 * keyboard.c (read_key_sequence_remapped): New var.
5917 (read_key_sequence): Compute remapping in the right buffer.
5918 (command_loop_1): Use read_key_sequence's remapping directly.
5919
51553db6
SM
59202011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5921
32c1fffd
SM
5922 * dired.c (file_name_completion): Don't expand file name.
5923 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5924 before checking file name handler.
5925
51553db6
SM
5926 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5927 they've been requested explicitly (bug#9591).
5928
b6bd1599 59292011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5930
5931 * keymap.c (Fsingle_key_description): Use make_specified_string
5932 instead of build_string to build string from push_key_description.
5933 (Bug#5193)
5934
f701dc2a
PE
59352011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5936
4222c55d
PE
5937 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5938 This fixes a Y2038 bug on 64-bit hosts.
5939 * buffer.c (reset_buffer):
5940 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5941 (Fclear_buffer_auto_save_failure):
5942 Use 0, not -1, to represent an unset failure time, since time_t
5943 might not be signed.
5944
f701dc2a
PE
5945 Remove dependency on glibc malloc internals.
5946 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5947 Move back here from lisp.h, but with their new implementations.
5948 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5949 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5950 * charset.c (charset_table_init): New static var.
5951 (syms_of_charset): Use it instead of xmalloc. This removes a
5952 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5953 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5954 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5955 Move back to alloc.c.
5956 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5957 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5958
9ceebf39
JD
59592011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5960
5961 * nsterm.m (windowDidResize): Call x_set_window_size only when
5962 ns_in_resize is true. Otherwise set pixelwidth/height and
5963 call change_frame_size (Bug#9628).
5964
cb993c58
PE
59652011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5966
3930c88b
PE
5967 Port --enable-checking=all to Fedora 14 x86-64.
5968 * charset.c (syms_of_charset): Also account for glibc malloc's
5969 internal overhead when calculating the initial malloc maximum.
5970
cb993c58
PE
5971 Port --enable-checking=all to Fedora 14 x86.
5972 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5973 Move to lisp.h.
5974 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5975 (overrun_check_realloc, overrun_check_free):
5976 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5977 That way, xmalloc returns a properly-aligned pointer even if
5978 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5979 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5980 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5981 into account when calculating the initial malloc maximum.
5982 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5983 Move here from alloc.c, so that charset.c can use it too.
5984 Properly align; the old code wasn't right for common 32-bit hosts
5985 when configured with --enable-checking=all.
5986 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5987 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5988
31bed486
EZ
59892011-09-29 Eli Zaretskii <eliz@gnu.org>
5990
04c70788 5991 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5992 use EDOM.
5993
fbcaa2f3
EZ
59942011-09-28 Eli Zaretskii <eliz@gnu.org>
5995
5996 * xdisp.c (compute_display_string_end): If there's no display
5997 string at CHARPOS, return -1.
5998
5999 * bidi.c (bidi_fetch_char): When compute_display_string_end
6000 returns a negative value, treat the character as a normal
6001 character not covered by a display string. (Bug#9624)
6002
a239d4e9
JB
60032011-09-28 Juanma Barranquero <lekktu@gmail.com>
6004
6005 * lread.c (Fread_from_string): Fix typo in docstring.
6006
88652fd5
EZ
60072011-09-27 Eli Zaretskii <eliz@gnu.org>
6008
6009 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6010 newline, reseat the iterator instead of bidi-iterating there one
6011 character at a time. (Bug#9610)
32c1fffd
SM
6012 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6013 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6014
ed497dd4
AS
60152011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6016
6017 * lread.c (readevalloop): Use correct code for NBSP.
6018 (read1): Likewise. (Bug#9608)
6019
b2bf61aa
MA
60202011-09-25 Michael Albinus <michael.albinus@gmx.de>
6021
6022 * dbusbind.c (Fdbus_register_signal): When service is not
6023 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6024
32bbb17c
GM
60252011-09-25 Glenn Morris <rgm@gnu.org>
6026
6027 * buffer.c (truncate-lines): Doc fix.
6028
94e0933e
CY
60292011-09-24 Chong Yidong <cyd@stupidchicken.com>
6030
6031 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6032 (Fset_window_next_buffers): Doc fix.
6033
cddde921
GM
60342011-09-24 Glenn Morris <rgm@gnu.org>
6035
6036 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6037
1260aef1
PE
60382011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6039
25b4bfa0
PE
6040 Fix minor problems found by static checking.
6041 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6042 * indent.c (Fvertical_motion): Fix == vs = typo.
6043
e3cbd34b
EZ
60442011-09-24 Eli Zaretskii <eliz@gnu.org>
6045
a66cfb1c
SM
6046 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6047 Default value is now t. Doc fix.
6bf7006f 6048
e3cbd34b 6049 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6050 logic when moving up, not only when moving down. Fix the
e3cbd34b 6051 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6052 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6053
6054 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6055 CHARPOS is covered by a display string which includes newlines.
6056 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6057 is covered by a display string with embedded newlines.
6058
a3de0cbd
MA
60592011-09-24 Michael Albinus <michael.albinus@gmx.de>
6060
6061 * dbusbind.c (Fdbus_register_signal): Add match rule to
6062 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6063 (Fdbus_register_method, Vdbus_registered_objects_table):
6064 Fix docstring.
a3de0cbd 6065
b260039d
JM
60662011-09-24 Jim Meyering <meyering@redhat.com>
6067
32c1fffd 6068 do not ignore write error for any output size
b260039d
JM
6069 The previous change was incomplete.
6070 While it makes emacs --batch detect the vast majority of stdout
6071 write failures, errors were still ignored whenever the output size is
6072 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6073 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6074 && echo FAIL: ignored write error
6075 FAIL: ignored write error
6076 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6077 && echo FAIL: ignored write error
6078 FAIL: ignored write error
6079 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6080
8eca8a7c
AS
60812011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6082
6083 * emacs.c (Fkill_emacs): In noninteractive mode exit
6084 non-successfully if a write error occurred on stdout. (Bug#9574)
6085
3341db62
EZ
60862011-09-21 Eli Zaretskii <eliz@gnu.org>
6087
6088 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6089 the xassert test.
6090
6091 * dispextern.h (struct it): Update the comment documenting what
6092 can it->OBJECT be.
6093
8c203dbf
EZ
60942011-09-20 Eli Zaretskii <eliz@gnu.org>
6095
6096 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6097 a display string, extend search for cursor position to end of row.
6098 (find_row_edges): If the row ends in a newline from a display
6099 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6100 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6101 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6102 non-empty line. Fixes confusing cursor motion with arrow keys at
6103 the beginning of a line that starts with whitespace.
8c203dbf 6104
a4824228
LMI
61052011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6106
6107 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6108 (bug#9493).
6109
33ed493b
CY
61102011-09-18 Chong Yidong <cyd@stupidchicken.com>
6111
6112 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6113 boolean (Bug#9154).
6114
56cd55c8
EZ
61152011-09-18 Eli Zaretskii <eliz@gnu.org>
6116
6117 * xdisp.c (display_line): Record maximum and minimum buffer
6118 positions even if no glyphs were produced (e.g., by a zero-width
6119 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6120 buffer positions that will be removed from the glyph row because
6121 they don't fit.
c02dcedf
EZ
6122 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6123 column is beyond frame width: don't subtract 1 "pixel" when
6124 computing width of the stretch.
3e62b7e0
EZ
6125 (reseat_at_next_visible_line_start): Undo the change made on
6126 2011-09-17 that saved paragraph information and restored it after
6127 the call to `reseat'. (Bug#9545)
56cd55c8 6128
5ed99d36 61292011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6130
6131 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6132 and turn window cursor on if cleared (Bug#9415).
6133
5ed99d36 61342011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6135
6136 * search.c (boyer_moore): Take unibyte characters from pattern
6137 literally. (Bug#9458)
6138
9bade7b2
EZ
61392011-09-18 Eli Zaretskii <eliz@gnu.org>
6140
6141 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6142
e5e9d610
PE
61432011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6144
87e4427a
PE
6145 Fix minor problem found by static checking.
6146 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6147 initialized, to pacify gcc -Wuninitialized.
6148
e5e9d610
PE
6149 * fileio.c: Report proper errno when syscall falls.
6150 (Finsert_file_contents): Save and restore errno,
6151 so that report_file_error outputs the correct diagnostic.
6152 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6153
a1674f0b
EZ
61542011-09-18 Eli Zaretskii <eliz@gnu.org>
6155
6156 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6157
fbfb6dd4
EZ
61582011-09-17 Eli Zaretskii <eliz@gnu.org>
6159
6160 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6161 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6162
bb187662
EZ
61632011-09-17 Eli Zaretskii <eliz@gnu.org>
6164
1137e8b8 6165 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6166 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6167
6168 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6169 (bidi_find_paragraph_start): Search back for paragraph beginning
6170 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6171 (bidi_move_to_visually_next): Only trigger paragraph-related
6172 computations when the last character is a newline or at EOB, not
6173 just any NEUTRAL_B. (Bug#9470)
6174
bb187662
EZ
6175 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6176 truncated lines if point is covered by a display string. (Bug#9524)
6177
2e621251
PE
61782011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6179
6180 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6181 (cons_to_x_long): New function.
6182 (lisp_data_to_selection_data): Use it. Correct the test for
6183 short-versus-long data; it was negated. Break out of vector
6184 loop, for efficiency, when a long datum is discovered.
6185
91a15bc6
SM
61862011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6187
6188 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6189
b41c3a35
EZ
61902011-09-16 Eli Zaretskii <eliz@gnu.org>
6191
6192 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6193 GCC PR/17406) by declaring this function with external scope.
6194
7812ba2d
PE
61952011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6196
6197 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6198 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6199
cf7edc2a
AS
62002011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6201
6202 * editfns.c (Fformat): Correctly handle text properties on "%%".
6203
bd01620e
EZ
62042011-09-15 Eli Zaretskii <eliz@gnu.org>
6205
6206 * xterm.c (x_draw_composite_glyph_string_foreground):
6207 * w32term.c (x_draw_composite_glyph_string_foreground):
6208 * term.c (encode_terminal_code):
6209 * composite.c (composition_update_it, get_composition_id):
6210 * xdisp.c (get_next_display_element)
6211 (fill_composite_glyph_string): Add comments about special meaning
6212 of TAB characters in a composition.
6213
a02719a3
PE
62142011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6215
6216 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6217 This occurs when processing a multibyte format.
6218 Problem reported by Wolfgang Jenker.
a02719a3 6219
72589a3c
JB
62202011-09-15 Johan Bockgård <bojohan@gnu.org>
6221
6222 * xdisp.c (try_cursor_movement): Only check for exact match if
6223 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6224
1c14176c
PE
62252011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6226
6227 Remove unused external symbols.
6228 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6229 * xdisp.c (calc_pixel_width_or_height): Now static.
6230 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6231 * indent.c (check_display_width):
6232 * w32term.c: Fix comment to match code.
6233 * xterm.c, xterm.h (x_catching_errors): Remove.
6234
d2eea5b5
PE
62352011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6236
6237 * xselect.c: Use signed conversions more consistently (Bug#9498).
6238 (selection_data_to_lisp_data): Assume incoming selection data are
6239 signed integers, not unsigned. This is to be consistent with
6240 outgoing selection data, which was modified to use signed integers
6241 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6242 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6243 expects long, not unsigned long.
6244
46888499
EZ
62452011-09-14 Eli Zaretskii <eliz@gnu.org>
6246
6247 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6248 computation of loop end. Reported by Johan Bockgård
6249 <bojohan@gnu.org>.
6250
ef8ef9fb
CY
62512011-09-13 Chong Yidong <cyd@stupidchicken.com>
6252
6253 * frame.c (Fother_visible_frames_p): Function deleted.
6254
fa819fed
EZ
62552011-09-12 Eli Zaretskii <eliz@gnu.org>
6256
6257 * indent.c (compute_motion): Process display vector front to back
6258 rather than the other way around. (Bug#2496)
6259
2ba8e008
SM
62602011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6261
6262 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6263
20f53c69
CY
62642011-09-11 Chong Yidong <cyd@stupidchicken.com>
6265
6266 * minibuf.c (Fread_from_minibuffer): Doc fix.
6267
d562d7a4
EZ
62682011-09-11 Eli Zaretskii <eliz@gnu.org>
6269
6270 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6271 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6272
1c4d7f3d
LMI
62732011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6274
6275 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6276 value for non-existent files.
6277
b885bf36
EZ
62782011-09-11 Eli Zaretskii <eliz@gnu.org>
6279
6280 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6281 set its "size" to -1. This will set the modtime_size field of
6282 the corresponding buffer to -1, which is what
6283 verify-visited-file-modtime expects for files that do not exist.
6284 (Bug#9139)
6285
6612f0bf
PE
62862011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6287
6288 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6289 here ...
6290 * lisp.h: ... from here. push_key_description is no longer
6291 defined in keyboard.c, so its declaration should not be in
6292 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6293 logically belongs with push_key_description.
6294
dfb3f755
PE
62952011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6296
6297 * buffer.h: Include <sys/types.h> instead of <time.h>.
6298 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6299 Problem reported by Herbert J. Skuhra.
6300
3134906c
LMI
63012011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6302
6303 * xml.c (parse_region): Make the parsing work for
6304 non-comment-starting XML files again (bug#9144).
6305
8d903f4e
AS
63062011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6307
6308 * image.c (gif_load): Fix calculation of bottom and right corner.
6309 (Bug#9468)
6310
80ad64f4
EZ
63112011-09-10 Eli Zaretskii <eliz@gnu.org>
6312
6313 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6314 redisplay in small windows.
6315
208a048d
EZ
63162011-09-09 Eli Zaretskii <eliz@gnu.org>
6317
6318 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6319
9b1c252e
MR
63202011-09-08 Martin Rudalics <rudalics@gmx.at>
6321
6322 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6323 Operate on live windows only.
6324
2949f33b
JB
63252011-09-08 Juanma Barranquero <lekktu@gmail.com>
6326
6327 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6328
e08dcafd
EZ
63292011-09-07 Eli Zaretskii <eliz@gnu.org>
6330
6331 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6332 only under bidi iteration.
6333
115b96bd
JD
63342011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6335
6336 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6337
c8199d0f
PE
63382011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6339
6340 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6341 Without this fix, the command to link temacs failed due to an
6342 undefined symbol __builtin_isnan. This is because
6343 /usr/include/iso/math_c99.h #defines isnan(x) to
6344 __builtin_isnan(x), but the bundled gcc, which identifies itself
6345 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6346 a __builtin_isnan.
6347 * floatfns.c (isnan): #undef, and then #define to a clone of
6348 what's in data.c.
6349 (Fisnan): Always define, since it's always available now.
6350 (syms_of_floatfns): Always define isnan at the Lisp level.
6351
e39b275c 63522011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6353
6354 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6355
b2db44d9 63562011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6357
f4af5137 6358 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6359 The previous code assumed that file offsets (off_t values) fit in
6360 EMACS_INT variables, which is not true on typical 32-bit hosts.
6361 The code messed up by falsely reporting buffer overflow in cases
6362 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6363 when "big" contains more than 2**29 bytes, even though this
6364 inserts just one byte and does not overflow the buffer.
6365 (Finsert_file_contents): Store file offsets as off_t
6366 values, not as EMACS_INT values. Check for overflow when
6367 converting between EMACS_INT and off_t. When checking for
6368 buffer overflow or for overlap, take the offsets into account.
6369 Don't use EMACS_INT for small values where int suffices.
6370 When checking for overlap, fix a typo: ZV was used where
6371 ZV_BYTE was intended.
6372 (Fwrite_region): Don't assume off_t fits into 'long'.
6373 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6374
ecfc0a49
MA
63752011-09-05 Michael Albinus <michael.albinus@gmx.de>
6376
6377 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6378
6511acf2 63792011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6380
0999621a 6381 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6382
6383 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6384 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6385 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6386 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6387 (modify_event_symbol): Do not assume that the length of
6388 name_alist_or_stem is safe to alloca and fits in int.
6389 (Fexecute_extended_command): Likewise for function name and binding.
6390 (Frecursion_depth): Wrap around reliably on integer overflow.
6391 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6392 since some callers pass EMACS_INT values.
6393 (Fsingle_key_description): Don't crash if symbol name contains more
6394 than MAX_ALLOCA bytes.
6395 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6396 (get_minibuffer): Arg is now EMACS_INT, not int.
6397 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6398 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6399 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6400
2be7d702
PE
6401 * dbusbind.c (signature_cat): New function.
6402 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6403 Do not overrun buffer; instead, report string overflow.
6404
9d1df220
PE
6405 * dispnew.c (add_window_display_history): Don't overrun buffer.
6406 Truncate instead; this is OK since it's just a log.
6407
33ef5c64
PE
6408 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6409 even if the time zone offset is outlandishly large.
6410 Don't mishandle offset == INT_MIN.
6411
66c6fdd5
PE
6412 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6413 when creating daemon; the previous buffer-overflow check was incorrect.
6414
d749b01b
PE
6415 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6416 which has the guts of the old verror function.
6417
b5cd1905
PE
6418 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6419 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6420
6e1a67fb
PE
6421 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6422 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6423 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6424 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6425 length of string rather than counting it via multiple sprintfs;
6426 that's simpler and more reliable.
c21721cc
PE
6427 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6428 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6429 sprintf, in case result does not fit in int.
6430
c57b67fc
PE
6431 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6432 (fontset_from_font): Print it.
6433
8a401434
PE
6434 * frame.c (tty_frame_count): Now printmax_t, not int.
6435 (make_terminal_frame, set_term_frame_name): Print it.
6436 (x_report_frame_params): In X, window IDs are unsigned long,
6437 not signed long, so print them as unsigned.
6438 (validate_x_resource_name): Check for implausibly long names,
6439 and don't assume name length fits in 'int'.
6440 (x_get_resource_string): Don't blindly alloca invocation name;
6441 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6442 not fit in int.
6443
6e1a67fb
PE
6444 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6445 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6446 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6447
0df02bf3
PE
6448 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6449 Use esprintf, not sprintf, in case result does not fit in int.
6450
48e30793
PE
6451 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6452 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6453 it as a large positive number.
6454 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6455 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6456
a66ff6d8
PE
6457 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6458 in case result does not fit in int.
6459
aca216ff
PE
6460 * print.c (float_to_string): Detect width overflow more reliably.
6461 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6462 buffer overrun. Don't assume list length fits in 'int'. Treat
6463 print length of 0 as 0, not as infinity; to be consistent with other
6464 uses of print length in this function. Don't overflow print length
6465 index. Don't assume hash table size fits in 'long', or that
6466 vectorlike size fits in 'unsigned long'.
6467
31c286f7
PE
6468 * process.c (make_process): Use printmax_t, not int, to format
6469 process-name gensyms.
6470
55e5faa1
PE
6471 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6472
80f2e268
PE
6473 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6474 to avoid potential buffer overrun.
6475
670741ab
PE
6476 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6477 if X resource line is longer than 512 bytes.
6478
b7163a50
PE
6479 * xfns.c (x_window): Make sprintf buffer a bit bigger
6480 to avoid potential buffer overrun.
6481
ae58ff1f
PE
6482 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6483
c43c8a6a
PE
6484 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6485
3f8236f4
PE
64862011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6487
53e9fe90 6488 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6489 Without these, Emacs silently mishandles large integers sometimes.
6490 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6491 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6492
6511acf2
PE
6493 * xdisp.c (try_window_id): Check Emacs fixnum range before
6494 converting to 'int'.
806add1d 6495
6511acf2 6496 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6497 Check that an Emacs fixnum is in range before assigning it to 'int'.
6498 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6499 values converted from Emacs fixnums.
6500 (Frecenter): Don't wrap around a line count if it is out of 'int'
6501 range; instead, treat it as an extreme value.
6502 (Fset_window_configuration, compare_window_configurations):
6503 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6504
6511acf2
PE
6505 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6506 that can exceed INT_MAX. Check that EMACS_INT value is in range
6507 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6508 (match_limit): Don't assume that a fixnum can fit in 'int'.
6509
6511acf2 6510 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6511 exceed INT_MAX.
6512
6511acf2 6513 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6514 (Fvertical_motion): Don't wrap around LINES values that don't fit
6515 in 'int'. Instead, treat them as extreme values. This is good
6516 enough for windows, which can't have more than INT_MAX lines anyway.
6517
fcb901a7
LMI
65182011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6519
0f2f6b6d
LMI
6520 * Require libxml/parser.h to avoid compilation warning.
6521
fcb901a7
LMI
6522 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6523
6524 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6525 since this reportedly can destroy thread storage.
6526
6e20a0d4
CY
65272011-08-30 Chong Yidong <cyd@stupidchicken.com>
6528
6529 * syntax.c (find_defun_start): Update all cache variables if
6530 exiting early (Bug#9401).
6531
148ae00e
EZ
65322011-08-30 Eli Zaretskii <eliz@gnu.org>
6533
f6cfbd8f
EZ
6534 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6535
148ae00e
EZ
6536 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6537 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6538 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6539
6540 * term.c (tty_append_glyph): New function.
6541 (produce_stretch_glyph): Static function and its prototype deleted.
6542
a66cfb1c
SM
6543 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6544 Add prototypes.
148ae00e 6545
c4a07a4c
PE
65462011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6547
6548 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6549 when checking :margin (Bug#9390).
6550 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6551 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6552 so that the name doesn't mislead. All uses changed.
6553
6bc8cd65
JB
65542011-08-28 Johan Bockgård <bojohan@gnu.org>
6555
6556 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6557 set_tty_hooks.
6558
dca4927e
EZ
65592011-08-27 Eli Zaretskii <eliz@gnu.org>
6560
6561 * xdisp.c (move_it_to): Don't bail out early when reaching
6562 position beyond to_charpos, if we are scanning backwards.
6563 (move_it_vertically_backward): When DY == 0, make sure we get to
6564 the first character in the line after the newline.
6565
f2cad773
PE
65662011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6567
6568 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6569 (ccl_driver): Do not generate an out-of-range pointer.
6570 (Fccl_execute_on_string): Remove unnecessary check for
6571 integer overflow, noted by Stefan Monnier in
6572 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6573 Remove a FIXME that didn't need fixing.
6574 Simplify the newly-introduced buffer reallocation code.
6575
0cae2cdb
JB
65762011-08-27 Juanma Barranquero <lekktu@gmail.com>
6577
6578 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6579
5fc295a4 65802011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6581
70c60eb2 6582 Integer and memory overflow issues (Bug#9196).
726e0ab1 6583
d31850da
PE
6584 * doc.c (get_doc_string): Rework so that
6585 get_doc_string_buffer_size is the actual buffer size, rather than
6586 being 1 less than the actual buffer size; this makes xpalloc more
6587 convenient.
6588
a69fbedb
PE
6589 * image.c (x_allocate_bitmap_record, cache_image):
6590 * xselect.c (Fx_register_dnd_atom):
6591 Simplify previous changes by using xpalloc.
6592
fe5c5d37
PE
6593 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6594 since either will do and ptrdiff_t is convenient with xpalloc.
6595
0065d054
PE
6596 * charset.c (charset_table_size)
6597 (struct charset_sort_data.priority): Now ptrdiff_t.
6598 (charset_compare): Don't overflow if priorities differ greatly.
6599 (Fsort_charsets): Don't assume list length fits in int.
6600 Check for size-calculation overflow when allocating sort data.
6601 (syms_of_charset): Allocate an initial charset table that is
6602 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6603
6604 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6605
6606 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6607 The actual value is always <= INT_MAX, and leaving it unsigned made
6608 overflow checking harder.
6609
6610 * dispextern.h (struct glyph_matrix.rows_allocated)
6611 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6612 with xpalloc. The values are still always <= INT_MAX.
6613
6614 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6615
6616 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6617 (SAFE_NALLOCA): New macro.
6618
6619 * region-cache.c (struct boundary.pos, find_cache_boundary)
6620 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6621 (set_cache_region, invalidate_region_cache)
6622 (revalidate_region_cache, know_region_cache, region_cache_forward)
6623 (region_cache_backward, pp_cache):
6624 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6625 so that ptrdiff_t * can be passed to xpalloc.
6626 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6627 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6628 (pp_cache): Don't assume cache_len fits in int.
6629 * region-cache.h: Adjust extern decls to match.
6630
6631 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6632 EMACS_INT, since either will do, for xpalloc.
6633
6634 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6635 (xnmalloc, xnrealloc, xpalloc): New functions.
6636
726e0ab1
PE
6637 * bidi.c (bidi_shelve_header_size): New constant.
6638 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6639 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6640
51f30bc5 6641 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6642 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6643 (overlay_strings):
6644 Don't update size of array until after memory allocation succeeds,
6645 because xmalloc/xrealloc may not return.
0065d054
PE
6646 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6647 now that we have proper integer overflow checking.
6648 (record_overlay_string, overlay_strings): Catch overflows when
6649 calculating size of overlay_str_buf.
726e0ab1 6650
0065d054
PE
6651 * callproc.c (Fcall_process): Check for size overflow when
6652 calculating size of args2.
6653 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6654 Normally we prefer signed values, but sticking with ptrdiff_t would
6655 require adding more-complicated checks.
726e0ab1
PE
6656
6657 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6658 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6659 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6660 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6661
6662 * character.c (Fstring): Check for size-calculation overflow.
6663
6664 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6665 unnecessary integer overflow. Check for size overflow.
6666 (encode_coding_object): Don't update size until xmalloc succeeds.
6667
6668 * composite.c (get_composition_id): Check for overflow in glyph
6669 length calculations.
6670
6671 Integer and memory overflow fixes for display code.
6672 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6673 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6674 (scrolling_window): Check for overflow in size calculations.
6675 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6676 Don't assume glyph table len fits in int.
6677 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6678 (row_table_size): Now ptrdiff_t, not int.
6679 (scrolling_window): Avoid overflow in size calculations.
6680 Don't update size until allocation succeeds.
6681 * fns.c (concat): Check for overflow in size calculations.
6682 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6683 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6684 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6685
6686 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6687 (get_doc_string): Check for size calculation overflow.
6688 Don't update size until allocation succeeds.
6689 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6690 EMACS_INT, where ptrdiff_t will do.
6691 (Fsubstitute_command_keys): Check for string overflow.
6692
6693 * editfns.c (set_time_zone_rule): Don't assume environment length
6694 fits in int.
6695 (message_length): Now ptrdiff_t, not int.
6696 (Fmessage_box): Don't update size until allocation succeeds.
6697 Don't assume message length fits in int.
6698 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6699
0065d054
PE
6700 * emacs.c (main): Do not reallocate argv, since there is a null at
6701 the end that can be overwritten, and this way there's no need to
6702 worry about size-calculation overflow.
6703 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6704
6705 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6706 alloc succeeds.
6707 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6708
6709 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6710 (x_set_scroll_bar_width, x_figure_window_size):
6711 Check for integer overflow.
6712 (x_set_alpha): Do not assume XINT fits in int.
6713
6714 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6715 This is for the members text_lines, text_cols, total_lines, total_cols,
6716 where the system imposes an 'int' limit.
6717
6718 * fringe.c (Fdefine_fringe_bitmap):
6719 Don't update size until alloc works.
6720
6721 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6722 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6723
6724 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6725 Check for size-calculation overflow.
6726 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6727 do, as we prefer signed integers.
6728 (id_to_widget.max_size, id_to_widget.used)
6729 (xg_store_widget_in_map, xg_remove_widget_from_map)
6730 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6731 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6732 Use and return ptrdiff_t, not int.
6733 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6734 * gtkutil.h: Change prototypes to match the above.
6735
6736 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6737 are duplicate now that they've been promoted to lisp.h.
6738 (x_allocate_bitmap_record, x_alloc_image_color)
6739 (make_image_cache, cache_image, xpm_load):
6740 Don't update size until alloc is done.
6741 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6742 (x_detect_edges):
3256efce 6743 Check for size calculation overflow.
726e0ab1
PE
6744 (ct_colors_allocated_max): New constant.
6745 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6746 overflow.
3256efce 6747
726e0ab1
PE
6748 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6749 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6750 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6751 Use ptrdiff_t, not int, to count maps.
6752 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6753 calculations. Don't update size until allocation succeeds.
6754 Redo calculations to avoid overflow.
726e0ab1
PE
6755 * keyboard.h: Change prototypes to match the above.
6756
6757 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6758 to count maps.
6759 (current_minor_maps): Check for size calculation overflow.
6760 * keymap.h: Change prototypes to match the above.
6761
6762 * lread.c (read1, init_obarray): Don't update size until alloc done.
6763
6764 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6765 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6766
726e0ab1
PE
6767 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6768 Now ptrdiff_t, not int.
6769 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6770 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6771
6772 * process.c (Fnetwork_interface_list): Check for overflow
6773 in size calculation.
6774
6775 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6776
6777 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6778 overflow. Don't bother calling xmalloc when xrealloc will do.
6779
6780 * search.c (Freplace_match): Check for size calculation overflow.
6781 (Fset_match_data): Don't assume list lengths fit in 'int'.
6782
6783 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6784 for command line length. Do not attempt to address one before the
6785 beginning of an array, as that's not portable.
6786
6787 * term.c (max_frame_lines): Remove; unused.
6788 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6789 not int.
6790 (encode_terminal_code, calculate_costs): Check for size
6791 calculation overflow.
6792 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6793 table lengths and related sizes. Don't update size until alloc
6794 done. Redo calculations to avoid overflow.
6795 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6796
6797 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6798 subtracting pointers.
6799 (gobble_line): Check for overflow more carefully. Don't update size
6800 until alloc done.
6801
6802 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6803 Don't update size until alloc done.
6804 Redo size calculations to avoid overflow.
6805 Check for size calculation overflow.
0065d054 6806 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6807
6808 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6809 Use ptrdiff_t, not int, for sizes.
6810 (store_mode_line_noprop_char): Don't update size until alloc done.
6811
0065d054
PE
6812 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6813 Use ptrdiff_t, not int, for sizes.
6814 (Finternal_make_lisp_face, cache_face):
6815 Check for size calculation overflow.
6816 (cache_face): Treat size calculation overflows as if they were
6817 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6818
6819 * xfns.c (x_encode_text, x_set_name_internal)
6820 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6821 sizes, since they can exceed INT_MAX in size. Check for size
6822 calculation overflow.
6823
0065d054
PE
6824 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6825 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6826 Don't update size until alloc done.
6827
0065d054 6828 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6829 as sprintf is limited to int lengths.
1d526e2f 6830
252c5ee1
PE
6831 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6832 (X_LONG_MIN): New macros.
864d7ce7
PE
6833 Use them to make the following changes clearer.
6834 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6835 This change doesn't affect the value now, but it may help remind
6836 future maintainers not to raise the value too much later.
6837 (SELECTION_QUANTUM): Remove, replacing with ...
6838 (selection_quantum): ... new function, which avoids overflow.
6839 All uses changed.
6840 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6841 assumption that selection length fits in 'int'.
6842 (x_reply_selection_request, x_handle_selection_request)
6843 (x_get_window_property, receive_incremental_selection)
6844 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6845 (lisp_data_to_selection_data, clean_local_selection_data):
6846 Use ptrdiff_t, not int, to record length of selection.
6847 (x_reply_selection_request, x_get_window_property)
6848 (receive_incremental_selection, x_property_data_to_lisp):
6849 Redo calculations to avoid overflow.
6850 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6851 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6852 something.
6853 (x_get_window_property, receive_incremental_selection)
6854 (lisp_data_to_selection_data, x_property_data_to_lisp):
6855 Check for size-calculation overflow.
6856 (x_get_window_property, receive_incremental_selection)
6857 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6858 Don't store size until memory allocation succeeds.
6859 (x_get_window_property): Plug memory leak on memory exhaustion.
6860 Don't double-block input; malloc is safe here. Don't assume 2**34
6861 - 4 fits in unsigned long. Add an xassert to check
6862 XGetWindowProperty overflow. Be more careful about overflow
6863 calculations, and distinguish size from memory overflow better.
6864 (receive_incremental_selection): When tracing, don't assume
6865 unsigned int is less than INT_MAX.
6866 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6867 harmful) conversions of unsigned short to int.
6868 (lisp_data_to_selection_data): Don't assume that integers
6869 in the range -65535 through -1 fit in an X unsigned short.
6870 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6871 result parameters unless successful. Rely on cons_to_unsigned
6872 to report problems with elements; the old code wasn't right anyway.
6873 (x_check_property_data): Check for int overflow; we cannot use
6874 a wider type due to X limits.
6875 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6876
726e0ab1 6877 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6878
0065d054
PE
6879 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6880 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6881 (x_color_cells): Don't store size until memory allocation succeeds.
6882 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6883 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6884 (x_term_init): Don't assume length fits in int (sprintf is limited
6885 to int size).
bc18e09d 6886
ebfa62c0
PE
6887 Use ptrdiff_t for composition IDs.
6888 * character.c (lisp_string_width):
6889 * composite.c (composition_table_size, n_compositions)
6890 (get_composition_id, composition_gstring_from_id):
6891 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6892 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6893 * window.c (Frecenter):
6894 Use ptrdiff_t, not int, for composition IDs.
6895 * composite.c (get_composition_id): Check for integer overflow.
6896 * composite.h: Adjust prototypes to match the above changes.
6897
d3411f89
PE
6898 Use ptrdiff_t for hash table indexes.
6899 * category.c (hash_get_category_set):
6900 * ccl.c (ccl_driver):
6901 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6902 * coding.c (coding_system_charset_list, detect_coding_system):
6903 * coding.h (struct coding_system.id):
6904 * composite.c (get_composition_id, gstring_lookup_cache):
6905 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6906 * image.c (xpm_get_color_table_h):
6907 * lisp.h (hash_lookup, hash_put):
6908 * minibuf.c (Ftest_completion):
6909 Use ptrdiff_t for hash table indexes, not int (which is too
6910 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6911 32-bit --with-wide-int hosts).
6912
e097a6fa
PE
6913 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6914 Add a FIXME comment about memory leaks.
6915 (syms_of_charset): Don't assume xmalloc returns.
6916
5637687f
PE
6917 Don't assume that stated character widths fit in int.
6918 * character.c (Fchar_width, c_string_width, lisp_string_width):
6919 * character.h (CHAR_WIDTH):
6920 * indent.c (MULTIBYTE_BYTES_WIDTH):
6921 Use sanitize_char_width to avoid undefined and/or bad behavior
6922 with outlandish widths.
a66cfb1c 6923 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6924 now that we have two such functions. All uses changed.
6925 (sanitize_char_width): New inline function.
6926
a2271ba2
PE
6927 Don't assume that tab-width fits in int.
6928 * character.h (sanitize_width): New inline function.
6929 (SANE_TAB_WIDTH): New macro.
6930 (ASCII_CHAR_WIDTH): Use it.
6931 * indent.c (sane_tab_width): Remove. All uses replaced by
6932 SANE_TAB_WIDTH (current_buffer).
6933 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6934
18c52557
PE
6935 * fileio.c: Integer overflow issues with file modes.
6936 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6937
caeeedc1
PE
6938 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6939 Remove unreachable code.
6940 (read_hex, load_charset_map_from_file): Check for integer overflow.
6941
6df6ae42 6942 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6943 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6944 (x_send_scroll_bar_event): Likewise. Check that the size does not
6945 exceed limits imposed by XClientMessageEvent, as well as the usual
6946 ptrdiff_t and size_t limits.
6947
b13995db
PE
6948 * keyboard.c: Overflow, signedness and related fixes.
6949 (make_lispy_movement): Use same integer type in forward decl
6950 that is used in the definition.
6951 (read_key_sequence, keyremap_step):
6952 Change bufsize argument back to int, undoing my 2011-03-30 change.
6953 We prefer signed types, and int is wide enough here.
6954 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6955 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6956 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6957 length, not size_t. Use ptrdiff_t for index, not int.
6958 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6959 possibility of integer overflow.
6960
13464394
PE
6961 Overflow, signedness and related fixes for images.
6962
6963 * dispextern.h (struct it.stack[0].u.image.image_id)
6964 (struct_it.image_id, struct image.id, struct image_cache.size)
6965 (struct image_cache.used, struct image_cache.ref_count):
6966 * gtkutil.c (update_frame_tool_bar):
6967 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6968 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6969 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6970 * nsmenu.m (update_frame_tool_bar):
6971 * xdisp.c (calc_pixel_width_or_height):
6972 * xfns.c (image_cache_refcount):
6973 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6974 on typical 64-bit hosts.
6975
6976 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6977 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6978 Omit unnecessary casts to int.
6979 (parse_image_spec): Check that integers fall into 'int' range
6980 when the callers expect that.
6981 (image_ascent): Redo ascent calculation to avoid int overflow.
6982 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6983 (lookup_image): Remove unnecessary tests.
6984 (xbm_image_p): Locals are now of int, not EMACS_INT,
6985 since parse_image_check makes sure they fit into int.
6986 (png_load, gif_load, svg_load_image):
6987 Prefer int to unsigned where either will do.
6988 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6989 old tiff_error_handler and tiff_warning_handler.
6990 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6991 stack buffer overflows. It uses only the features of vsnprintf
6992 that are common to both POSIX and native Microsoft.
6993 (tiff_error_handler, tiff_warning_handler): Use it.
6994 (tiff_load, gif_load, imagemagick_load_image):
6995 Don't assume :index value fits in 'int'.
6996 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6997 (imagemagick_load_image): Check that crop parameters fit into
6998 the integer types that MagickCropImage accepts. Don't assume
6999 Vimagemagick_render_type has a nonnegative value. Don't assume
7000 size_t fits in 'long'.
7001 (gs_load): Use printmax_t to print the widest integers possible.
7002 Check for integer overflow when computing image height and width.
7003
c11821d4
EZ
70042011-08-26 Eli Zaretskii <eliz@gnu.org>
7005
7006 * xdisp.c (redisplay_window): Don't force window start if point
7007 will be invisible in the resulting window. (Bug#9324)
7008
0c95fcf7
EZ
70092011-08-25 Eli Zaretskii <eliz@gnu.org>
7010
7011 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7012 the display spec is of the form `(space ...)'.
7013 (handle_display_spec): Return the value returned by
7014 handle_single_display_spec, not just 1 or zero.
7015 (handle_single_display_spec): If the display spec is of the form
7016 `(space ...)', and specifies display in the text area, return 2
7017 rather than 1.
fee65a97 7018 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7019 accurately, and prefer exact match for point under bidi.
7020 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7021
7022 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7023 into disp_prop; all users changed.
7024
7025 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7026 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7027 for the text covered by the display property.
7028
e4ed06f1
CY
70292011-08-25 Chong Yidong <cyd@stupidchicken.com>
7030
7031 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7032 Change return value to nil.
7033 (Frecord_buffer): Delete unused function.
7034
f67cdd7f
EZ
70352011-08-24 Eli Zaretskii <eliz@gnu.org>
7036
5980d4c6
EZ
7037 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7038 buffers, return left-to-right.
8610fe8b
EZ
7039 (set_cursor_from_row): Consider candidate row a win if its glyph
7040 represents a newline and point is on that newline. Fixes cursor
7041 positioning on the newline at EOL of R2L text within L2R
7042 paragraph, and vice versa.
7043 (try_cursor_movement): Check continued rows, in addition to
7044 continuation rows. Fixes unwarranted scroll when point enters a
7045 continued line of R2L text within an L2R paragraph, or vice versa.
7046 (cursor_row_p): Consider the case of point being equal to
7047 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7048 from the end of a short line to the beginning of a continued line
7049 of R2L text within L2R paragraph.
7050 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7051 composed characters.
5980d4c6 7052
f67cdd7f
EZ
7053 * bidi.c (bidi_check_type): Use xassert.
7054 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7055 members.
7056
bca633fb
EZ
70572011-08-23 Eli Zaretskii <eliz@gnu.org>
7058
7059 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7060 a character.
7061
4a5885a7
CY
70622011-08-23 Chong Yidong <cyd@stupidchicken.com>
7063
7064 * nsfont.m (ns_otf_to_script): Fix typo.
7065
0902a04e
KH
70662011-08-22 Kenichi Handa <handa@m17n.org>
7067
7068 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7069 extra slot even if the purpose is char-code-property-table.
7070
1a2e6670
EZ
70712011-08-23 Eli Zaretskii <eliz@gnu.org>
7072
8ddde651
EZ
7073 * xdisp.c (redisplay_window): When computing centering_position,
7074 account for the height of the header line. (Bug#8874)
7075
425cc014
EZ
7076 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7077 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7078 candidate is selected by the mouse, and that candidate has a
7079 composed character under the mouse.
7080
1a2e6670
EZ
7081 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7082 coordinates reported by pos-visible-in-window-p for a composed
7083 character in column zero.
7084
8b76d6f8
SM
70852011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7086
7087 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7088
dac347dd
EZ
70892011-08-22 Eli Zaretskii <eliz@gnu.org>
7090
7091 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7092 consider it a hit if to_charpos is anywhere in the range of the
7093 composed buffer positions.
7094
e013fb34
CY
70952011-08-22 Chong Yidong <cyd@stupidchicken.com>
7096
7097 * image.c (gif_load): Don't assume that each subimage has the same
7098 dimensions as the base image. Handle disposal method that is
7099 "undefined" by the gif spec (Bug#9335).
7100
bd1ba3e8
CY
71012011-08-20 Chong Yidong <cyd@stupidchicken.com>
7102
7103 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7104 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7105
54a1215b
EZ
71062011-08-19 Eli Zaretskii <eliz@gnu.org>
7107
823564e5
EZ
7108 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7109 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7110 from an Org mode buffer to a Speedbar frame.
7111
54a1215b
EZ
7112 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7113 a composition, take its buffer position from IT->cmp_it.charpos.
7114 Fixes cursor positioning at the beginning of a line that begins
7115 with a composed character.
7116
9778ebcc
EZ
71172011-08-18 Eli Zaretskii <eliz@gnu.org>
7118
0be6ee06
EZ
7119 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7120 character bidirectional type, use STRONG_L instead. Fixes crashes
7121 in a buffer produced by `describe-categories'.
7122
9778ebcc
EZ
7123 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7124 members before the level stack, so they would be saved and
7125 restored when copying iterator state. Fixes incorrect reordering
7126 around TABs covered by display properties.
7127
156bffbe
AS
71282011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7129
6b02f655 7130 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7131
72ad093b
CY
71322011-08-17 Chong Yidong <cyd@stupidchicken.com>
7133
7134 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7135 (internal_condition_case_2, internal_condition_case_n):
7136 Remove unnecessary aborts (Bug#9081).
72ad093b 7137
35774242
EZ
71382011-08-17 Eli Zaretskii <eliz@gnu.org>
7139
7140 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7141 has no `load' handler, try opening the file locally. (Bug#9311)
7142
db76dd85
KB
71432011-08-16 Ken Brown <kbrown@cornell.edu>
7144
7145 * gmalloc.c: Expand comment.
7146
b215eee5
EZ
71472011-08-16 Eli Zaretskii <eliz@gnu.org>
7148
7149 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7150 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7151
a4579d33
KB
71522011-08-16 Ken Brown <kbrown@cornell.edu>
7153
7154 Fix memory allocation problems in Cygwin build (Bug#9273).
7155
7156 * unexcw.c ( __malloc_initialized): Declare external variable.
7157 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7158
8b76d6f8
SM
7159 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7160 New variables.
a4579d33
KB
7161 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7162 dumped emacs.
7163 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7164 in the static heap.
7165 [CYGWIN] (special_realloc): New function.
7166 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7167 requests to realloc storage in the static heap.
7168
3ebec551
PE
71692011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7170
7171 * bidi.c (bidi_initialize): Remove unused local.
7172
9fd8be00
EZ
71732011-08-15 Eli Zaretskii <eliz@gnu.org>
7174
6b02f655
SM
7175 * bidimirror.h:
7176 * biditype.h: Remove file.
7177 * makefile.w32-in ($(BLD)/bidi.$(O)):
7178 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7179
7180 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7181
7182 * chartab.c: Improve commentary for the uniprop_table API.
7183
32413314
EZ
7184 * bidi.c (bidi_paragraph_init): Support zero value of
7185 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7186 (bidi_initialize): Use uniprop_table instead of including
7187 biditype.h and bidimirror.h.
32413314 7188
9fd8be00
EZ
7189 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7190 coordinates of the iterator when restoring from ppos_it.
7191 (Bug#9296)
7192
5cf2b69b
KH
71932011-08-14 Kenichi Handa <handa@m17n.org>
7194
7195 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7196 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7197
daf17d00
EZ
71982011-08-14 Eli Zaretskii <eliz@gnu.org>
7199
7200 * xdisp.c (move_it_in_display_line_to): Don't invoke
7201 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7202 ppos_it. Fixes vertical cursor motion when line beginning is
7203 covered by an image. (Bug#9296)
7204
08e3161a
JD
72052011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7206
7207 * nsterm.h (ns_run_ascript): Declare.
7208 (NSAPP_DATA2_RUNASSCRIPT): Define.
7209
7210 * nsfns.m (as_script, as_result, as_status): New static variables.
7211 (ns_run_ascript): New function.
5e617bc2 7212 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7213 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7214 the event loop. Get status from as_status (Bug#7276).
7215
7216 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7217 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7218 the event loop (Bug#7276).
7219
a3720aa2
AS
72202011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7221
7222 * gnutls.c (QCgnutls_bootprop_priority)
7223 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7224 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7225 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7226 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7227 (QCgnutls_bootprop_verify_hostname_error)
7228 (QCgnutls_bootprop_callbacks_verify): Rename from
7229 Qgnutls_bootprop_..., all uses changed.
7230
7231 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7232 uses changed.
7233
0a0d27fb
PE
72342011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7235
19d5c50c
PE
7236 * xfaces.c (Qframe_set_background_mode): Now static.
7237 * dispextern.h (Qframe_set_background_mode): Remove decl.
7238
0a0d27fb
PE
7239 * process.c (Fnetwork_interface_info): Declare local only if needed.
7240
377538cb
JD
72412011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7242
7243 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7244 (Fnetwork_interface_list): Allocate in increments of bytes instead
7245 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7246 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7247 sockaddr.
7248 (struct ifflag_def): notrailers is smart on OSX.
7249 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7250 Get hardware address with getifaddrs if available.
7251
08fff70c
EZ
72522011-08-12 Eli Zaretskii <eliz@gnu.org>
7253
7254 * xdisp.c (iterate_out_of_display_property): xassert that
7255 IT->position is set to within IT->object's boundaries. Break from
7256 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7257 when IT->position is set up wrongly due to some bug.
7258 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7259 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7260 entry. Force push_it to save on the stack the current
7261 buffer/string position, to be restored by pop_it. Fix flags in
7262 the iterator structure wrt the object coming from a display
7263 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7264 properties. (Bug#9284)
7265
7be1c708 72662011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7267
7be1c708
CY
7268 * fontset.c (fontset_get_font_group): Add proper type checks.
7269 (Bug#9172)
aac0c6e3 7270
7be1c708 72712011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7272
7be1c708
CY
7273 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7274 and LC_VERSION_MIN_MACOSX.
7275 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7276 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7277
97bb72a6
EZ
72782011-08-08 Eli Zaretskii <eliz@gnu.org>
7279
7280 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7281 no-display-properties-and-no-overlays under bidi display.
7282 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7283 properties and overlays.
97bb72a6 7284
d5617611
CY
72852011-08-08 Chong Yidong <cyd@stupidchicken.com>
7286
37e11a63
CY
7287 * editfns.c (Fset_time_zone_rule): Document relationship with the
7288 setenv function.
7289
d5617611
CY
7290 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7291 the font entity extracted from the cache (Bug#8109).
7292
58872834
CY
72932011-08-07 Chong Yidong <cyd@stupidchicken.com>
7294
7295 * composite.c (autocmp_chars): Don't reset point. That is done by
7296 restore_point_unwind (Bug#5984).
7297
75bfc667
JL
72982011-08-07 Juri Linkov <juri@jurta.org>
7299
7300 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7301 to show the arg `TIME' instead of `TIMEVAL'.
7302
d1410150
EZ
73032011-08-06 Eli Zaretskii <eliz@gnu.org>
7304
7305 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7306 display property strides EOL and includes a newline, as in
7307 longlines-mode. (Bug#9254)
75b771e4
EZ
7308 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7309 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7310
7311 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7312 is non-zero, even if the data buffer is NULL. Fixes a crash in
7313 vertical-motion with longlines-mode. (Bug#9254)
7314
35928349
EZ
73152011-08-05 Eli Zaretskii <eliz@gnu.org>
7316
ec7cc85b
EZ
7317 * bidi.c <bidi_cache_total_alloc>: Now static.
7318 (bidi_initialize): Initialize bidi_cache_total_alloc.
7319
8b76d6f8 7320 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7321 cache. (Bug#9221)
7322
7323 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7324 amount allocated this far in `bidi_cache_total_alloc'.
7325 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7326 non-zero, only free the data buffer without restoring the cache
7327 contents. All callers changed.
7328
7329 * dispextern.h (bidi_unshelve_cache): Update prototype.
7330
7331 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7332 (move_it_in_display_line, move_it_to)
7333 (move_it_vertically_backward, move_it_by_lines): Replace the call
7334 to xfree to an equivalent call to bidi_unshelve_cache.
7335 (move_it_in_display_line_to): Fix logic of returning
412b6358 7336 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7337
e2e2423b
EZ
73382011-08-05 Eli Zaretskii <eliz@gnu.org>
7339
7340 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7341 came from a string character with a `cursor' property. (Bug#9229)
7342
ae9e757a
JD
73432011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7344
7345 * Makefile.in (LIB_PTHREAD): New variable.
7346 (LIBES): Add LIB_PTHREAD (Bug#9216).
7347
7348 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7349 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7350
213bd7f2
AS
73512011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7352
6b02f655 7353 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7354
99aaf75f
JD
73552011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7356
7357 * xterm.c (x_find_topmost_parent): New function.
7358 (x_set_frame_alpha): Find topmost parent window with
7359 x_find_topmost_parent and set the property there also (bug#9181).
7360 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7361
c74e9d86
PE
73622011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7363
7364 * callproc.c (Fcall_process): Avoid vfork clobbering
7365 the local vars buffer, coding_systems, current_dir.
7366
640c8776
SM
73672011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7368
7369 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7370
f26d0e4c
PE
73712011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7372
8a10d76c
PE
7373 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7374 so that it is not optimized away.
7375
f26d0e4c
PE
7376 * xdisp.c (compute_display_string_pos): Remove unused local.
7377
55439c61
EZ
73782011-08-02 Eli Zaretskii <eliz@gnu.org>
7379
7380 Fix slow cursor motion and scrolling in large buffers with
7381 selective display, like Org Mode buffers. (Bug#9218)
7382
7383 * dispextern.h (struct bidi_it): New member disp_prop_p.
7384
7385 * xdisp.c: Remove one-slot cache of display string positions.
7386 (compute_display_string_pos): Accept an additional argument
5e617bc2 7387 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7388 for a display string or property. If found, set DISP_PROP_P
7389 non-zero.
7390
7391 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7392 DISP_PROP_P, and pass it to compute_display_string_pos.
7393 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7394 non-zero. All callers of bidi_fetch_char changed.
7395
fb33fa43
SM
73962011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7397
7398 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7399
b099e063
DM
74002010-12-03 Don March <don@ohspite.net>
7401
7402 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7403 last character M-[char] is translated to ESC [char] (bug#7541).
7404
5cc7f7af
KH
74052011-08-02 Kenichi Handa <handa@m17n.org>
7406
d0fffa3f 7407 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7408
7409 * chartab.c (uniprop_table): Make it non-static.
7410
525d5e6e
EZ
74112011-08-01 Eli Zaretskii <eliz@gnu.org>
7412
7413 * xdisp.c (forward_to_next_line_start): Accept additional argument
7414 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7415 on the newline.
7416 (reseat_at_next_visible_line_start): Use the bidi iterator state
7417 returned by forward_to_next_line_start to restore the state of
7418 it->bidi_it after backing up to previous newline. (Bug#9212)
7419
31011111
AS
74202011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7421
7422 * regex.c (re_comp): Protoize.
7423 (re_exec): Fix return type.
7424 (regexec): Fix type of `ret'. (Bug#9203)
7425
476371c4
PE
74262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7427
e5d76069
PE
7428 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7429 This is needed if max-image-size is a floating-point number.
7430
9a79b20c
AS
74312011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7432
7433 * print.c (print_object): Print empty symbol as ##.
7434
7435 * lread.c (read1): Read ## as empty symbol.
7436
d8c2fa78
AA
74372011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7438
7439 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7440 setting frame foreground color (Bug#9175).
7441 (x_set_background_color): Likewise.
7442
ffe57a7a
AA
7443 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7444 contents (Bug#9176).
7445 (EmacsTooltip -init): Remove bezels and add shadows to
7446 tooltip windows.
7447
bf3492a5
AA
7448 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7449 or scroll bar (Bug#8470).
7450
d55e9c53
AA
7451 * nsfont.m (nsfont_open): Remove assignment to voffset and
7452 unnecessary vars hshink, expand, hd, full_height, min_height.
7453 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7454
7455 * nsterm.h (nsfont_info): Remove voffset field.
7456
d8c2fa78 74572011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7458
7459 Implement strike-through and overline on NextStep (Bug#8863).
7460
7461 * nsfont.m (nsfont_open): Use underline position provided by font,
7462 instead of hard-coded value of 2.
7463 (nsfont_draw): Call ns_draw_text_decoration instead.
7464
7465 * nsterm.h: Add declaration for ns_draw_text_decoration.
7466
7467 * nsterm.m (ns_draw_text_decoration): New function for drawing
7468 underline, overline, and strike-through.
7469 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7470 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7471 accommodate underlining, etc.
4843aac3 7472
4cc60b9b
EZ
74732011-07-28 Eli Zaretskii <eliz@gnu.org>
7474
bc7ece87
EZ
7475 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7476 default.
4cc60b9b 7477
476371c4
PE
74782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7479
66606eea
PE
7480 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7481 Without this fix, if a signal arrives just after memory fills up,
7482 'malloc' might be invoked reentrantly.
7483
476371c4
PE
7484 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7485 In other words, assume that every image size is allowed, on non-X
7486 hosts. This assumption is probably wrong, but it lets Emacs compile.
7487
f3fcc40d
AS
74882011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7489
7490 * regex.c (re_iswctype): Convert return values to boolean.
7491
350c992f
EZ
74922011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7493
7494 * xdisp.c (compute_display_string_pos): Don't use cached display
7495 string position if the buffer had its restriction changed.
7496 (Bug#9184)
7497
5266b4bb
PE
74982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7499
7500 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7501
2573a837 75022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7503
41f55ccd 7504 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7505
39e378da
PE
7506 * bidi.c: Integer size and overflow fixes.
7507 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7508 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7509 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7510 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7511 (bidi_find_other_level_edge):
7512 Use ptrdiff_t instead of EMACS_INT where either will do.
7513 This works better on 32-bit hosts configured --with-wide-int.
7514 (bidi_cache_ensure_space): Check for size-calculation overflow.
7515 Use % rather than repeated addition, for better worst-case speed.
7516 Don't set bidi_cache_size until after xrealloc returns, because it
7517 might not return.
7518 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7519 (bidi_cache_ensure_space): Also check that the bidi cache size
7520 does not exceed that of the largest Lisp string or buffer. See Eli
7521 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7522
5e927815
PE
7523 * alloc.c (__malloc_size_t): Remove.
7524 All uses replaced by size_t. See Andreas Schwab's note
7525 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7526
ca4aa935
PE
7527 * image.c: Improve checking for integer overflow.
7528 (check_image_size): Assume that f is nonnull, since
7529 it is always nonnull in practice. This is one less thing to
7530 worry about when checking for integer overflow later.
7531 (x_check_image_size): New function, which checks for integer
7532 overflow issues inside X.
7533 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7534 This removes the need for a memory_full check.
7535 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7536 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7537 (xbm_read_bitmap_data): Change locals back to 'int', since
7538 their values must fit in 'int'.
7539 (xpm_load_image, png_load, tiff_load):
7540 Invoke x_create_x_image_and_pixmap earlier,
7541 to avoid much needless work if the image is too large.
7542 (tiff_load): Treat overly large images as if
7543 x_create_x_image_and_pixmap failed, not as malloc failures.
7544 (gs_load): Use x_check_image_size.
7545
5f8f9cc2
PE
7546 * gtkutil.c: Omit integer casts.
7547 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7548 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7549
5adf60bc
PE
7550 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7551
c8907a93
PE
7552 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7553 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7554 would wrongly return t on a 64-bit host.
7555
e3c25c68
PE
7556 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7557 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7558 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7559 and therefore cause GCC to emit a bogus diagnostic in some cases.
7560
3f791afe
PE
7561 * image.c: Integer signedness and overflow and related fixes.
7562 This is not an exhaustive set of fixes, but it's time to
7563 record what I've got.
7564 (lookup_pixel_color, check_image_size): Remove redundant decls.
7565 (check_image_size): Don't assume that arbitrary EMACS_INT values
7566 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7567 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7568 (tiff_load, imagemagick_load_image):
7569 Check for overflow in size calculations.
7570 (x_create_x_image_and_pixmap): Remove unnecessary test for
7571 xmalloc returning NULL; that can't happen.
7572 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7573 (xpm_color_bucket): Use better integer hashing function.
7574 (xpm_cache_color): Don't possibly over-allocate memory.
7575 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7576 (gif_memory_source):
7577 Use ptrdiff_t, not int or size_t, to record sizes.
7578 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7579 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7580 either works, as we prefer signed integers.
7581 (tiff_read_from_memory, tiff_write_from_memory):
7582 Return tsize_t, not size_t, since that's what the TIFF API wants.
7583 (tiff_read_from_memory): Don't fail simply because the read would
7584 go past EOF; instead, return a short read.
7585 (tiff_load): Omit no-longer-needed casts.
7586 (Fimagemagick_types): Don't assume size fits into 'int'.
7587
3cc5a532
PE
7588 Improve hashing quality when configured --with-wide-int.
7589 * fns.c (hash_string): New function, taken from sxhash_string.
7590 Do not discard information about ASCII character case; this
7591 discarding is no longer needed.
7592 (sxhash-string): Use it. Change sig to match it. Caller changed.
7593 * lisp.h: Declare it.
7594 * lread.c (hash_string): Remove, since we now use fns.c's version.
7595 The fns.c version returns a wider integer if --with-wide-int is
7596 specified, so this should help the quality of the hashing a bit.
7597
b312a492
PE
7598 * emacs.c: Integer overflow minor fix.
7599 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7600 Define only if GNU_LINUX.
7601 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7602
dfd153ae
PE
7603 * dispnew.c: Integer signedness and overflow fixes.
7604 Remove unnecessary forward decls, that were a maintenance hassle.
7605 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7606 All uses changed.
7607 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7608 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7609 (prepare_desired_row, line_draw_cost):
7610 Use int, not unsigned, where either works.
7611 (save_current_matrix, restore_current_matrix):
7612 Use ptrdiff_t, not size_t, where either works.
7613 (init_display): Check for overflow more accurately, and without
7614 relying on undefined behavior.
7615
a81d11a3
PE
7616 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7617 Remove, replacing with the new symbols in lisp.h. All uses changed.
7618 * fileio.c (make_temp_name):
7619 * filelock.c (lock_file_1, lock_file):
7620 * xdisp.c (message_dolog):
7621 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7622 Use pMd etc. instead.
7623 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7624 replacing the pWIDE etc. symbols removed from editfns.c.
7625
3300e6fd
PE
7626 * keyboard.h (num_input_events): Now uintmax_t.
7627 This is (very slightly) less likely to mess up due to wraparound.
7628 All uses changed.
7629
fd05c7e9
PE
7630 * buffer.c: Integer signedness fixes.
7631 (alloc_buffer_text, enlarge_buffer_text):
7632 Use ptrdiff_t rather than size_t when either will do, as we prefer
7633 signed integers.
7634
903fe15d
PE
7635 * alloc.c: Integer signedness and overflow fixes.
7636 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7637 (__malloc_size_t): Default to size_t, not to int.
7638 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7639 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7640 Prefer ptrdiff_t to size_t when either would do, as we prefer
7641 signed integers.
7642 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7643 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7644 Now const. Initialize with values that are in range even if char
7645 is signed.
7646 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7647 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7648 These functions do the right thing with sizes > 2**32.
7649 (check_depth): Now ptrdiff_t, not int.
7650 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7651 Adjust to new way of storing sizes. Check for size overflow bugs
7652 in rest of code.
7653 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7654 slightly wrong anyway, as it missed one instance of
7655 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7656 (refill_memory_reserve): Omit needless cast to size_t.
7657 (mark_object_loop_halt): Mark as externally visible.
7658
ac82cc6a
PE
7659 * xselect.c: Integer signedness and overflow fixes.
7660 (Fx_register_dnd_atom, x_handle_dnd_message):
7661 Use ptrdiff_t, not size_t, since we prefer signed.
7662 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7663 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7664 x_dnd_atoms_size and x_dnd_atoms_length.
7665
c2d1e36d
PE
7666 * doprnt.c: Prefer signed to unsigned when either works.
7667 * eval.c (verror):
7668 * doprnt.c (doprnt):
7669 * lisp.h (doprnt):
7670 * xdisp.c (vmessage):
7671 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7672 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7673 prefer signed arithmetic to avoid comparison confusion.
7674 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7675 but is a bit tricky.
7676
0e926e56
PE
7677 Assume freestanding C89 headers, string.h, stdlib.h.
7678 * data.c, doprnt.c, floatfns.c, print.c:
7679 Include float.h unconditionally.
7680 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7681 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7682 * regex.c: Likewise for stddef.h, string.h.
7683 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7684 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7685 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7686 (STDC_HEADERS): Remove obsolete defines.
7687 * sysdep.c: Include limits.h unconditionally.
7688
9cfdb3ec
PE
7689 Assume support for memcmp, memcpy, memmove, memset.
7690 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7691 * regex.c (memcmp, memcpy):
7692 Remove; we assume C89 now.
7693
7694 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7695 (__malloc_safe_bcopy): Remove; no longer needed.
7696
cf950e6b 7697 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7698 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7699 well either way, and we prefer signed to unsigned.
7700
dbf38e02
LMI
77012011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7702
7703 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7704 closes the connection while we're reading (bug#9182).
7705
d6f0886c 77062011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7707
d6f0886c
JD
7708 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7709 are specified (Bug#9168).
24e0f6b1 7710
2eb1f9e6
PE
77112011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7712
7713 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7714 Found by GCC static checking and --with-wide-int on a 32-bit host.
7715
22381272 77162011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7717
7718 * xdisp.c (compute_display_string_pos): Fix logic of caching
7719 previous display string position. Initialize cached_prev_pos to
7720 -1. Fixes slow-down at the beginning of a buffer.
7721
f25e39b4
EZ
77222011-07-24 Eli Zaretskii <eliz@gnu.org>
7723
7724 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7725 for attrs[LFACE_FONTSET_INDEX].
7726
04c4b52e
PE
77272011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7728
7729 * xml.c (parse_region): Remove unused local
7730 that was recently introduced.
7731
c1734fbd
EZ
77322011-07-23 Eli Zaretskii <eliz@gnu.org>
7733
be18c5a5
EZ
7734 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7735 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7736
c1734fbd
EZ
7737 * xdisp.c (move_it_in_display_line_to): Record the best matching
7738 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7739 exit if none of the characters scanned was an exact match.
7740 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7741 when exact match is impossible due to invisible text, and the
7742 lines are truncated.
7743
a258d627
JD
77442011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7745
7746 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7747 for OSX >= 10.7.
7748
b6d5a689
EZ
77492011-07-22 Eli Zaretskii <eliz@gnu.org>
7750
0f74f785
EZ
7751 Fix a significant slow-down of cursor motion with C-n, C-p,
7752 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7753 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7754 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7755 (next_element_from_buffer): Call compute_stop_pos_backwards to
7756 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7757 base_level_stop.
7758 (reseat): Don't look for prev_stop, as that could mean a very long
7759 run.
7760 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7761 <cached_disp_overlay_modiff>: Cache for last found display string
7762 position.
551918c1 7763 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7764 about the same buffer in the same area of character positions, and
7765 the buffer wasn't changed since the time the display string
7766 position was cached.
551918c1 7767
b2d0c91a
EZ
77682011-07-22 Eli Zaretskii <eliz@gnu.org>
7769
7770 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7771 is an integer, which is important for empty lines. (Bug#9149)
7772
043604ee
CY
77732011-07-22 Chong Yidong <cyd@stupidchicken.com>
7774
7775 * frame.c (Fmodify_frame_parameters): In tty case, update the
7776 default face if necessary (Bug#4238).
7777
da4adb04
CY
77782011-07-21 Chong Yidong <cyd@stupidchicken.com>
7779
7780 * editfns.c (Fstring_to_char): No need to explain what a character
7781 is in the docstring (Bug#6576).
7782
9abd0532
LMI
77832011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7784
7785 * xml.c (parse_region): Make sure we always return a tree.
7786
36881d16
HK
77872011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7788
7789 * xml.c (parse_region): If a document contains only comments,
7790 return that, too.
7791
1e98674d
LMI
77922011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7793
7794 * xml.c (make_dom): Return comments, too.
7795
590bd467
PE
77962011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7797
7798 Port to OpenBSD.
7799 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7800 and the surrounding thread.
7801 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7802 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7803 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7804 timer goes off.
7805 * s/openbsd.h (BROKEN_SIGIO): Define.
7806 * unexelf.c (unexec) [__OpenBSD__]:
7807 Don't update the .mdebug section of the Alpha COFF symbol table.
7808
f41628b2
LMI
78092011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7810
7811 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7812 (bug#8460).
7813
b59b67c5
PE
78142011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7815
15e3a074
PE
7816 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7817 This fixes some race conditions on the permissions of any newly
7818 created file.
7819
41bed37d
PE
7820 * alloc.c (valid_pointer_p): Use pipe, not open.
7821 This fixes some permissions issues when debugging.
7822
b59b67c5
PE
7823 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7824 If fchown fails to set both uid and gid, try to set just gid,
7825 as that is sometimes allowed. Adjust the file's mode to eliminate
7826 setuid or setgid bits that are inappropriate if fchown fails.
7827
925a6be7
SM
78282011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7829
7830 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7831 to compare Lisp_Objects.
7832 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7833 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7834 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7835
52968808
AS
78362011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7837
0a6a104b
AS
7838 * lread.c (read_integer): Unread even EOF character.
7839 (read1): Likewise. Properly record start position of symbol.
7840
52968808
AS
7841 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7842 symbol character follows.
7843
9e381cdd
PE
78442011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7845
7846 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7847 This works around a problem with the previous change to Fcopy_file.
7848 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7849 and without this change, GCC might complain about discarding
7850 fchown's return value.
7851
b5641435
JB
78522011-07-16 Juanma Barranquero <lekktu@gmail.com>
7853
7854 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7855
a8031457
PE
78562011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7857
7858 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7859
dd889327
LMI
78602011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7861
750c33f7
LMI
7862 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7863 it's used from the C level.
7864
dd889327
LMI
7865 * process.c: Use the same condition for POLL_FOR_INPUT in both
7866 keyboard.c and process.c (bug#1858).
7867
87e86684
LM
78682011-07-09 Lawrence Mitchell <wence@gmx.li>
7869
7870 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7871 (Fgnutls_boot): Use it.
7872
64348f40
AS
78732011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7874
7875 * doc.c (Fsubstitute_command_keys): Revert last change.
7876
1d698799
LMI
78772011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7878
f863868c
LMI
7879 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7880 quotes the next character, and doesn't affect other longer
7881 sequences (bug#8935).
7882
1d698799
LMI
7883 * lread.c (syms_of_lread): Clarify that is isn't only
7884 `eval-buffer' and `eval-defun' that's affected by
7885 `lexical-binding' (bug#8460).
7886
aa4b6df6
EZ
78872011-07-15 Eli Zaretskii <eliz@gnu.org>
7888
7889 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7890 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7891
5d856da6
PE
78922011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7893
ad6042bb
PE
7894 Fix minor problems found by static checking.
7895 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7896 (elsz): Now a signed constant, not a size_t var. We prefer signed
7897 types to unsigned, to avoid integer comparison confusion. Without
7898 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7899 "cannot optimize loop, the loop counter may overflow", a symptom
7900 of the confusion.
f00bbb22 7901 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7902 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7903
6468f31c
LMI
79042011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7905
49080b10
LMI
7906 * search.c (Fre_search_backward): Mention `case-fold-search' in
7907 all the re_search_* functions (bug#8138).
7908
6468f31c
LMI
7909 * keyboard.c (Fopen_dribble_file): Document when the file is
7910 closed (bug#8056).
7911
c965adc5
EZ
79122011-07-14 Eli Zaretskii <eliz@gnu.org>
7913
df9733bf
EZ
7914 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7915 bidi_cache_idx.
7916
0bb23927
EZ
7917 Support bidi reordering of display and overlay strings.
7918 * xdisp.c (compute_display_string_pos)
7919 (compute_display_string_end): Accept additional argument STRING.
7920 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7921 (reseat_to_string): Initialize bidi_it->string.s and
7922 bidi_it->string.schars.
7923 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7924 NULL (avoids a crash in bidi_paragraph_init).
7925 Initialize itb.string.lstring.
0bb23927
EZ
7926 (init_iterator): Call bidi_init_it only of a valid
7927 buffer position was specified. Initialize paragraph_embedding to
7928 L2R.
7929 (reseat_to_string): Initialize the bidi iterator.
7930 (display_string): If we need to ignore text properties of
7931 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7932 original value of -1 will not work with bidi.)
7933 (compute_display_string_pos): First arg is now struct
7934 `text_pos *'; all callers changed. Support display properties on
7935 Lisp strings.
7936 (compute_display_string_end): Support display properties on Lisp
7937 strings.
7938 (init_iterator, reseat_1, reseat_to_string): Initialize the
7939 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7940 when iterating on a string not from display properties).
640c8776
SM
7941 (compute_display_string_pos, compute_display_string_end):
7942 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7943 arrow keys.
7944 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7945 base_level_stop; instead, set base_level_stop to BEGV.
7946 Fixes crashes in vertical-motion.
0bb23927
EZ
7947 (next_element_from_buffer): Improve commentary for when
7948 the iterator is before prev_stop.
7949 (init_iterator): Initialize bidi_p from the default value of
7950 bidi-display-reordering, not from buffer-local value. Use the
7951 buffer-local value only if initializing for buffer iteration.
7952 (handle_invisible_prop): Support invisible properties on strings
7953 that are being bidi-reordered.
7954 (set_iterator_to_next): Support bidi reordering of C strings and
7955 Lisp strings.
7956 (next_element_from_string): Support bidi reordering of Lisp
7957 strings.
7958 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7959 (display_string): Support display of R2L glyph rows.
7960 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7961 (init_iterator): Don't initialize it->bidi_p for strings
7962 here.
7963 (reseat_to_string): Initialize it->bidi_p for strings here.
7964 (next_element_from_string, next_element_from_c_string)
7965 (next_element_from_buffer): Add xassert's for correspondence
7966 between IT's object being iterated and it->bidi_it.string
7967 structure.
7968 (face_before_or_after_it_pos): Support bidi iteration.
7969 (next_element_from_c_string): Handle the case of the first string
7970 character that is not the first one in the visual order.
7971 (get_visually_first_element): New function, refactored from common
7972 parts of next_element_from_buffer, next_element_from_string, and
7973 next_element_from_c_string.
7974 (tool_bar_lines_needed, redisplay_tool_bar)
7975 (display_menu_bar): Force left-to-right direction. Add a FIXME
7976 comment for making that be controlled by a user option.
7977 (push_it, pop_it): Save and restore the state of the
7978 bidi iterator. Save and restore the bidi_p flag.
7979 (pop_it): Iterate out of display property for string iteration as
7980 well.
7981 (iterate_out_of_display_property): Support iteration over strings.
7982 (handle_single_display_spec): Set up it->bidi_it for iteration
7983 over a display string, and call bidi_init_it.
7984 (handle_single_display_spec, next_overlay_string)
7985 (get_overlay_strings_1, push_display_prop): Set up the bidi
7986 iterator for displaying display or overlay strings.
7987 (forward_to_next_line_start): Don't use the shortcut if
7988 bidi-iterating.
7989 (back_to_previous_visible_line_start): If handle_display_prop
7990 pushed the iterator stack, restore the internal state of the bidi
7991 iterator by calling bidi_pop_it same number of times.
7992 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7993 and we are bidi-iterating, don't decrement the iterator position;
7994 instead, set the first_elt flag in the bidi iterator, to produce
7995 the same effect.
7996 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7997 (push_display_prop): xassert that we are iterating a buffer.
7998 (push_it, pop_it): Save and restore paragraph_embedding member.
7999 (handle_single_display_spec, next_overlay_string)
8000 (get_overlay_strings_1, reseat_1, reseat_to_string)
8001 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8002 correctly. Don't assume unibyte strings are not bidi-reordered.
8003 (compute_display_string_pos)
8004 (compute_display_string_end): Fix handling the case of C string.
8005 (push_it, pop_it): Save and restore from_disp_prop_p.
8006 (handle_single_display_spec, push_display_prop): Set the
8007 from_disp_prop_p flag.
8008 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8009 (pop_it): Call iterate_out_of_display_property only if we are
8010 popping after iteration over a string that came from a display
8011 property. Fix a typo in popping stretch info. Add an assertion
8012 for verifying that the iterator position is in sync with the bidi
8013 iterator.
8014 (handle_single_display_spec, get_overlay_strings_1)
8015 (push_display_prop): Fix initialization of paragraph direction for
8016 string when that of the parent object is not yet determined.
8017 (reseat_1): Call bidi_init_it to resync the bidi
8018 iterator with IT's position. (Bug#7616)
8019 (find_row_edges): If ROW->start.pos gives position
8020 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8021 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8022 Reset the from_disp_prop_p flag.
8023 (SAVE_IT, RESTORE_IT): New macros.
8024 (pos_visible_p, face_before_or_after_it_pos)
8025 (back_to_previous_visible_line_start)
8026 (move_it_in_display_line_to, move_it_in_display_line)
8027 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8028 (try_scrolling, redisplay_window, display_line): Use them when
8029 saving a temporary copy of the iterator and restoring it back.
8030 (back_to_previous_visible_line_start, reseat_1)
8031 (init_iterator): Empty the bidi cache "stack".
8032 (move_it_in_display_line_to): If iterator ended up at
8033 EOL, but we never saw any buffer positions smaller than
8034 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8035 motion in bidi-reordered lines.
8036 (move_it_in_display_line_to): Record prev_method and prev_pos
8037 immediately before the call to set_iterator_to_next. Fixes cursor
8038 motion in bidi-reordered lines with stretch glyphs and strings
8039 displayed in margins. (Bug#8133) (Bug#8867)
8040 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8041 TO_CHARPOS.
640c8776
SM
8042 (pos_visible_p): Support positions in bidi-reordered lines.
8043 Save and restore bidi cache.
0bb23927
EZ
8044
8045 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8046 (bidi_paragraph_info): Delete unused struct.
8047 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8048 (bidi_cache_start): New variable.
8049 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8050 to zero.
8051 (bidi_cache_fetch_state, bidi_cache_search)
8052 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8053 (bidi_cache_find, bidi_peek_at_next_level)
8054 (bidi_level_of_next_char, bidi_find_other_level_edge)
8055 (bidi_move_to_visually_next): Compare cache index with
8056 bidi_cache_start rather than with zero.
8057 (bidi_fetch_char): Accept new argument STRING; all callers
8058 changed. Support iteration over a string. Support strings with
8059 display properties. Support unibyte strings. Fix the type of
8060 `len' according to what STRING_CHAR_AND_LENGTH expects.
8061 (bidi_paragraph_init, bidi_resolve_explicit_1)
8062 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8063 (bidi_level_of_next_char, bidi_move_to_visually_next):
8064 Support iteration over a string.
0bb23927
EZ
8065 (bidi_set_sor_type, bidi_resolve_explicit_1)
8066 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8067 can now be zero (for strings); special values 0 and -1 were
8068 changed to -1 and -2, respectively.
8069 (bidi_char_at_pos): New function.
8070 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8071 Call it instead of FETCH_MULTIBYTE_CHAR.
8072 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8073 initialized to valid values.
8074 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8075 values.
8076 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8077 the test for valid cached positions. Fix the logic for looking up
8078 the sentinel state in the cache. GCPRO the Lisp string we are
8079 iterating.
8080 (bidi_push_it, bidi_pop_it): New functions.
8081 (bidi_initialize): Initialize the bidi cache start stack pointer.
8082 (bidi_cache_ensure_space): New function, refactored from part of
8083 bidi_cache_iterator_state. Don't assume the required size is just
8084 one BIDI_CACHE_CHUNK away.
8085 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8086 (bidi_count_bytes, bidi_char_at_pos): New functions.
8087 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8088 always valid if bidi_cache_idx is valid.
8089 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8090 is valid if it's going to be used.
8091 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8092 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8093 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8094 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8095 (bidi_find_other_level_edge, bidi_cache_start_stack):
8096 All variables related to cache indices are now EMACS_INT.
c965adc5 8097
0bb23927
EZ
8098 * dispextern.h (struct bidi_string_data): New structure.
8099 (struct bidi_it): New member `string'. Make flag members be 1-bit
8100 fields, and put them last in the struct.
640c8776
SM
8101 (compute_display_string_pos, compute_display_string_end):
8102 Update prototypes.
0bb23927
EZ
8103 (bidi_push_it, bidi_pop_it): Add prototypes.
8104 (struct iterator_stack_entry): New members bidi_p,
8105 paragraph_embedding, and from_disp_prop_p.
8106 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8107 (bidi_shelve_cache, bidi_unshelve_cache):
8108 Declare prototypes.
0bb23927
EZ
8109
8110 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8111 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8112 and vector-like objects.
8113
8114 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8115 cache around display iteration.
8116
8117 * window.c (Fwindow_end, window_scroll_pixel_based)
8118 (displayed_window_lines, Frecenter): Save and restore the bidi
8119 cache around display iteration.
8120
3bbd2265
LMI
81212011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8122
8123 * editfns.c (Fdelete_region): Clarify the use of the named
8124 parameters (bug#6788).
8125
adc47434
MR
81262011-07-14 Martin Rudalics <rudalics@gmx.at>
8127
8128 * indent.c (Fvertical_motion): Set and restore w->pointm when
8129 saving and restoring the window's buffer (Bug#9006).
8130
837c31f8
LMI
81312011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8132
8133 * editfns.c (Fstring_to_char): Clarify just what is returned
8134 (bug#6576). Text by Eli Zaretskii.
8135
ac389d0c
JB
81362011-07-13 Juanma Barranquero <lekktu@gmail.com>
8137
8138 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8139
0be0ce47
EZ
81402011-07-13 Eli Zaretskii <eliz@gnu.org>
8141
8142 * buffer.c (mmap_find): Fix a typo.
8143
cd18e7e3
JB
81442011-07-13 Johan Bockgård <bojohan@gnu.org>
8145
8146 Fix execution of x selection hooks.
8147 * xselect.c (Qx_lost_selection_functions)
8148 (Qx_sent_selection_functions): New vars.
8149 (syms_of_xselect): DEFSYM them.
8150 (x_handle_selection_request): Pass Qx_sent_selection_functions
8151 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8152 (x_handle_selection_clear,x_clear_frame_selections):
8153 Pass Qx_lost_selection_functions rather than
8154 Vx_lost_selection_functions to Frun_hook_with_args.
8155
47ea7f44
PE
81562011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8157
ac389d0c 8158 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8159 The old code sometimes used this field without initializing it.
8160
47ea7f44
PE
8161 * alloc.c (gc_sweep): Don't read past end of array.
8162 In theory, the old code could also have corrupted Emacs internals,
8163 though it'd be very unlikely.
8164
bc985c87
AS
81652011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8166
8167 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8168 argument. (Bug#4026)
bc985c87 8169
0cf34688
LMI
81702011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8171
b3dadd76
LMI
8172 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8173 key" (bug#4257).
8174
0cf34688
LMI
8175 * window.c (Fset_window_start): Doc fix (bug#4199).
8176 (Fset_window_hscroll): Ditto.
8177
270768cd
PE
81782011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8179
077e3dda 8180 Fix minor new problems caught by GCC 4.6.1.
270768cd 8181 * term.c (init_tty): Remove unused local.
490011a6 8182 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8183 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8184 not used otherwise.
270768cd 8185
b1f58454
CY
81862011-07-12 Chong Yidong <cyd@stupidchicken.com>
8187
8188 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8189
22b9578d
LMI
81902011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8191
6e70ab07
LMI
8192 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8193 are the mini-buffer and the echo area (bug#3320).
8194
22b9578d
LMI
8195 * term.c (init_tty): Remove support for supdup, c10 and perq
8196 terminals, which are no longer supported (bug#1482).
8197
8974cc9f
JB
81982011-07-10 Johan Bockgård <bojohan@gnu.org>
8199
8200 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8201
a560d974
JD
82022011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8203
8204 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8205 for non-popups (Bug#3642).
8206
1dae0f0a
AS
82072011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8208
268c2c36 8209 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8210 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8211 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8212 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8213 * data.c (fmod): Likewise.
8214 * dispnew.c (swap_glyphs_in_rows): Likewise.
8215 * emacs.c (memory_warning_signal): Likewise.
8216 * floatfns.c (float_error): Likewise.
8217 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8218 (otf_open, font_otf_capability, generate_otf_features)
8219 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8220 Likewise.
8221 * image.c (pbm_read_file): Likewise.
8222 * indent.c (string_display_width): Likewise.
8223 * intervals.c (check_for_interval, search_for_interval)
8224 (inc_interval_count, count_intervals, root_interval)
8225 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8226 * lread.c (defalias): Likewise.
268c2c36 8227 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8228 * regex.c (set_image_of_range_1, set_image_of_range)
8229 (regex_grow_registers): Likewise.
8230 * sysdep.c (strerror): Likewise.
8231 * termcap.c (valid_filename_p, tprint, main): Likewise.
8232 * tparam.c (main): Likewise.
8233 * unexhp9k800.c (run_time_remap, save_data_space)
8234 (update_file_ptrs, read_header, write_header, calculate_checksum)
8235 (copy_file, copy_rest, display_header): Likewise.
8236 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8237 Likewise.
8238 * xdisp.c (check_it): Likewise.
8239 * xfaces.c (register_color, unregister_color, unregister_colors):
8240 Likewise.
8241 * xfns.c (print_fontset_result): Likewise.
8242 * xrdb.c (member, fatal, main): Likewise.
8243
99033785
PE
82442011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8245
8246 Fix minor problems found by static checking (Bug#9031).
8247 * chartab.c (char_table_set_range, map_sub_char_table):
8248 Remove unused locals.
8249 (uniprop_table): Now static.
8250 * composite.c (_work_char): Remove unused static var.
8251
9cb2ac56
JB
82522011-07-09 Juanma Barranquero <lekktu@gmail.com>
8253
8254 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8255
f25661f0
JD
82562011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8257
8258 * gtkutil.c (qttip_cb): Remove code without function.
8259
8278c4fe
EZ
82602011-07-09 Eli Zaretskii <eliz@gnu.org>
8261
8262 * w32.c (pthread_sigmask): New stub.
8263
1692ae2d 82642011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8265
8a6ebd58 8266 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8267 sigprocmask is portable only for single-threaded applications, and
8268 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8269 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8270 (LIBES): Use it.
8271 * callproc.c (Fcall_process):
8272 * process.c (create_process):
8273 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8274 Use pthread_sigmask, not sigprocmask.
123403e4 8275
1b854618
JD
82762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8277
8278 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8279 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8280 wrong (Bug#8591).
8281
3fe4b549
JD
82822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8283
0ce7e563
JD
8284 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8285 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8286 (xg_hide_tooltip): Fix comment.
8287
3fe4b549
JD
8288 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8289 in registerServicesMenuSendTypes.
8290 (validRequestorForSendType): Don't check ns_return_types.
8291
8292 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8293 ns_return_type.
8294
5df75e47
JR
82952011-07-08 Jason Rumney <jasonr@gnu.org>
8296
22610910
JR
8297 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8298 SH_SHOW for hidden windows (Bug#5482).
8299
5df75e47
JR
8300 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8301 frame struct members of non-existent frames (Bug#6284).
8302
699c10bd
JD
83032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8304
4393663b
JD
8305 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8306 variable firstTime not needed on OSX >= 10.6.
8307 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8308 >= 10.5. Use setKnobProportion, setDoubleValue.
8309
8310 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8311 (MAC_OS_X_VERSION_10_5): Define if not defined.
8312 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8313 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8314 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8315
8316 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8317 cString and lossyCString on OSX >= 10.4.
4393663b 8318
58179cce 8319 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8320 sizeToFit on OSX >= 10.2.
8321
8322 * nsimage.m (allocInitFromFile): Don't use deprecated method
8323 bestRepresentationForDevice on OSX >= 10.6.
8324
8325 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8326 to avoid warning.
8327
8328 * emacs.c: Declare unexec_init_emacs_zone.
8329
a63e0781
JD
8330 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8331
699c10bd
JD
8332 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8333
8334 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8335 on svcsMenu (Bug#8842).
8336
8337 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8338 ns_return_types.
8339 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8340
8341 * nsterm.m (QUTF8_STRING): Declare.
8342 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8343 (validRequestorForSendType): Return type is (id).
8344 Change indexOfObjectIdenticalTo to indexOfObject.
8345 Check if we have local selection before returning self (Bug#8842).
8346 (writeSelectionToPasteboard): Put local selection into paste board
8347 if we have a local selection (Bug#8842).
8348 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8349
8350 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8351 (ns_get_local_selection): Declare.
8352
54e10184
LMI
83532011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8354
9888ff71
LMI
8355 * keymap.c (describe_map_tree): Don't insert a double newline at
8356 the end of the buffer (bug#1169) and return whether we inserted
8357 something.
8358
54e10184
LMI
8359 * callint.c (Fcall_interactively): Change "reading args" to
8360 "providing args" to try to clarify what it does (bug#1010).
8361
15fa4783
KH
83622011-07-07 Kenichi Handa <handa@m17n.org>
8363
8364 * composite.c (composition_compute_stop_pos): Ignore a static
8365 composition starting before CHARPOS (Bug#8915).
8366
8367 * xdisp.c (handle_composition_prop): Likewise.
8368
a8815b00
EZ
83692011-07-07 Eli Zaretskii <eliz@gnu.org>
8370
8371 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8372 (Bug#9015)
8373
ef7b981d 83742011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8375
8376 * character.h (unicode_category_t): New enum type.
8377
8378 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8379 (Qchar_code_property_table): New variable.
8380 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8381 (UNIPROP_COMPRESSED_FORM_P): New macros.
8382 (char_table_ascii): Uncompress the compressed values.
8383 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8384 Uncompress the compressed values.
ac389d0c 8385 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8386 (char_table_ref_and_range): Uncompress the compressed values.
8387 (sub_char_table_set): New arg is_uniprop. Callers changed.
8388 Uncompress the compressed values.
8389 (sub_char_table_set_range): Args changed. Callers changed.
8390 (char_table_set_range): Adjuted for the above change.
8391 (map_sub_char_table): Delete args default_val and parent. Add arg
8392 top. Give decoded values to a Lisp function.
640c8776 8393 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8394 values to a Lisp function. Gcpro more variables.
8395 (uniprop_table_uncompress)
8396 (uniprop_decode_value_run_length): New functions.
8397 (uniprop_decoder, uniprop_decoder_count): New variables.
8398 (uniprop_get_decoder, uniprop_encode_value_character)
8399 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8400 New functions.
8401 (uniprop_encoder, uniprop_encoder_count): New variables.
8402 (uniprop_get_encoder, uniprop_table)
8403 (Funicode_property_table_internal, Fget_unicode_property_internal)
8404 (Fput_unicode_property_internal): New functions.
8405 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8406 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8407 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8408 char-code-property-alist.
8409
640c8776 8410 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8411 Vunicode_category_table.
8412
640c8776 8413 * font.c (font_range): Adjust for the change of
c805dec0
KH
8414 Vunicode_category_table.
8415
76b397fb
DN
84162011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8417
8418 * m/iris4d.h: Remove file, move contents ...
8419 * s/irix6-5.h: ... here.
8420
22b4128e
PE
84212011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8422
8423 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8424 * alloc.c (mark_buffer):
8425 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8426 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8427 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8428 This isn't true in general, and it's particularly not true
8429 if Emacs is configured with --with-wide-int.
8430 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8431 New macros, used in the buffer.c change.
8432
869795d6
JD
84332011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8434
8435 * xsettings.c: Use both GConf and GSettings if both are available.
8436 (store_config_changed_event): Add comment.
8437 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8438 (store_tool_bar_style_changed): New functions.
5e617bc2 8439 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8440 (struct xsettings): Move font inside HAVE_XFT.
8441 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8442 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8443 Move inside HAVE_XFT.
640c8776 8444 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8445 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8446 also.
8447 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8448 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8449 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8450 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8451 (parse_settings): Move check for font inside HAVE_XFT.
8452 (read_settings, apply_xft_settings): Add comment.
8453 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8454 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8455 call store_font_name_changed.
8456 (xft_settings_event): Add comment.
8457 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8458 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8459 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8460 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8461 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8462 (xsettings_get_system_font, xsettings_get_system_normal_font):
8463 Add comment.
869795d6 8464
d8ed26bd
PE
84652011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8466
8467 Random fixes. E.g., (random) never returned negative values.
8468 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8469 subseconds part to the entropy, as that's a bit more random.
8470 Prefer signed to unsigned, since the signedness doesn't matter and
8471 in general we prefer signed. When given a limit, use a
8472 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8473 latter isn't right if USE_2_TAGS_FOR_INTS.
8474 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8475 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8476
cabf1cac
SM
84772011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8478
8479 * textprop.c (text_property_stickiness):
8480 Obey Vtext_property_default_nonsticky.
8481 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8482 * w32fns.c (syms_of_w32fns):
8483 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8484
6e9b2be9
PE
84852011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8486
8487 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8488 This is more efficient than Ffile_directory_p and avoids a minor race.
8489
90186c68
LMI
84902011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8491
7c301272
LMI
8492 * buffer.c (Foverlay_put): Say what the return value is
8493 (bug#7835).
8494
c4f2d8d4
LMI
8495 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8496 is a directory before asking whether to use the file name
8497 (bug#7564).
ad637907
LMI
8498 (barf_or_query_if_file_exists): Make the "File is a directory"
8499 error be more correct.
c4f2d8d4 8500
90186c68
LMI
8501 * fns.c (Frequire): Remove the mention of the .gz files, since
8502 that's installation-specific, but keep the mention of
8503 `get-load-suffixes'.
8504
da64016e
PE
85052011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8506
8507 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8508 Report string overflow if the output is too long.
8509
7d47b580
JB
85102011-07-04 Juanma Barranquero <lekktu@gmail.com>
8511
a555cb87
JB
8512 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8513 (syms_of_gnutls): Remove duplicate DEFSYM for
8514 Qgnutls_bootprop_verify_hostname_error, an error for
8515 Qgnutls_bootprop_verify_error (which is no longer used).
8516
7d47b580
JB
8517 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8518 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8519 Also (re)move comments that are misplaced or no longer relevant.
8520
1e49bfab
LMI
85212011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8522
8523 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8524
1485f4c0
CY
85252011-07-03 Chong Yidong <cyd@stupidchicken.com>
8526
8527 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8528 and background color parameters if they have been changed.
8529
a9ab721e
LMI
85302011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8531
8532 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8533
cf7cff57
PE
85342011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8535
2e13213d
PE
8536 * xsettings.c (SYSTEM_FONT): Define only when used.
8537 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8538
cf7cff57
PE
8539 * keymap.c (access_keymap_1): Now static.
8540
7a8e04f7
CY
85412011-07-02 Chong Yidong <cyd@stupidchicken.com>
8542
8543 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8544 leave any prefix arg for the up event (Bug#1586).
8545
61352f62
LMI
85462011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8547
69bb1ef7
LMI
8548 * lread.c (syms_of_lread): Mention single symbols defined by
8549 `defvar' or `defconst' (bug#7154).
8550
61352f62 8551 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8552 (Frequire): Mention get-load-suffixes.
61352f62 8553
28545e04
MR
85542011-07-02 Martin Rudalics <rudalics@gmx.at>
8555
8556 * window.h (window): Remove clone_number slot.
8557 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8558 Remove.
8559 (make_parent_window, make_window, saved_window)
8560 (Fset_window_configuration, save_window_save): Don't deal with
8561 clone numbers.
8562 * buffer.c (Qclone_number): Remove declaration.
8563 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8564
3349e122
SM
85652011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8566
8567 Add multiple inheritance to keymaps.
8568 * keymap.c (Fmake_composed_keymap): New function.
8569 (Fset_keymap_parent): Simplify.
8570 (fix_submap_inheritance): Remove.
8571 (access_keymap_1): New function extracted from access_keymap to handle
8572 embedded parents and handle lists of maps.
8573 (access_keymap): Use it.
8574 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8575 (Fcopy_keymap): Handle embedded parents.
8576 (Fcommand_remapping, define_as_prefix): Simplify.
8577 (Fkey_binding): Simplify.
8578 (syms_of_keymap): Move minibuffer-local-completion-map,
8579 minibuffer-local-filename-completion-map,
8580 minibuffer-local-must-match-map, and
8581 minibuffer-local-filename-must-match-map to Elisp.
8582 (syms_of_keymap): Defsubr make-composed-keymap.
8583 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8584 (parse_menu_item): Trivial simplification.
8585
3279eb87
GM
85862011-07-01 Glenn Morris <rgm@gnu.org>
8587
8588 * Makefile.in (SETTINGS_LIBS): Fix typo.
8589
4550efdf
KI
85902011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8591
8592 * coding.c (Fencode_coding_string): Record the last coding system
8593 used, as the function doc string says (bug#8738).
8594
0949d2b6
JD
85952011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8596
8597 * xsettings.c (store_monospaced_changed): Take new font as arg and
8598 check for change against current_mono_font.
8599 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8600 (emacs_settings_constructor, emacs_settings_get_property)
8601 (emacs_settings_set_property, emacs_settings_class_init)
8602 (emacs_settings_init, gsettings_obj): Remove.
8603 (something_changedCB): New function for HAVE_GSETTINGS.
8604 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8605 with value as argument.
8606 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8607 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8608 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8609 "changed".
8610
8611 * xgselect.c: Add defined (HAVE_GSETTINGS).
8612 (xgselect_initialize): Ditto.
8613
8614 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8615 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8616 xg_select.
8617
bbc6b304
PE
86182011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8619
8620 * eval.c (struct backtrace): Simplify and port the data structure.
8621 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8622 signed bit field, as this assumption is not portable and it makes
8623 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8624 "char debug_on_exit : 1" as this is not portable either; instead,
8625 use the portable "unsigned int debug_on_exit : 1". Remove unused
8626 member evalargs. Remove obsolete comments about cc bombing out.
8627
9851bfc5
JD
86282011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8629
51bb811f 8630 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8631 Let HAVE_GSETTINGS override HAVE_GCONF.
8632 (store_monospaced_changed): New function.
8633 (EMACS_SETTINGS): A new type derived from GObject to handle
8634 GSettings notifications.
8635 (emacs_settings_constructor, emacs_settings_get_property)
8636 (emacs_settings_set_property, emacs_settings_class_init):
8637 New functions.
8638 (gsettings_client, gsettings_obj): New variables.
8639 (GSETTINGS_SCHEMA): New define.
8640 (something_changedCB): Call store_monospaced_changed.
8641 (init_gsettings): New function.
8642 (xsettings_initialize): Call init_gsettings.
8643 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8644 to NULL.
8645
640c8776 8646 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8647 GCONF_CFLAGS/LIBS.
8648
5386012d
MR
86492011-06-29 Martin Rudalics <rudalics@gmx.at>
8650
8651 * window.c (resize_root_window, grow_mini_window)
8652 (shrink_mini_window): Rename Qresize_root_window to
8653 Qwindow_resize_root_window and Qresize_root_window_vertically to
8654 Qwindow_resize_root_window_vertically.
8655
f13e0b08
PE
86562011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8657
8658 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8659
94515237
JB
86602011-06-27 Juanma Barranquero <lekktu@gmail.com>
8661
8662 * makefile.w32-in: Redesign dependencies so they reflect more
8663 clearly which files are directly included by each source file,
8664 and not through other includes.
8665
e43b6e43
MR
86662011-06-27 Martin Rudalics <rudalics@gmx.at>
8667
8668 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8669 (sort_overlays, overlay_strings): When an overlay's clone number
8670 matches the window's clone number process the overlay even if
8671 the overlay's window property doesn't match the current window.
8672
d68443dc
MR
8673 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8674 (Fwindow_hchild): Rename to Fwindow_left_child.
8675 (Fwindow_next): Rename to Fwindow_next_sibling.
8676 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8677 (resize_window_check): Rename to window_resize_check.
8678 (resize_window_apply): Rename to window_resize_apply.
8679 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8680 (Fdelete_other_windows_internal, resize_frame_windows)
8681 (Fsplit_window_internal, Fdelete_window_internal)
8682 (grow_mini_window, shrink_mini_window)
8683 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8684
c7e73be5
JD
86852011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8686
8687 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8688 (emacs_fixed_set_min_size): Remove.
8689 (emacs_fixed_new): Take frame as argument.
8690
8691 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8692 (_EmacsFixedPrivate): Remove minwidth/height.
8693 Add struct frame *f.
8694 (emacs_fixed_init): Initialize priv->f.
8695 (get_parent_class, emacs_fixed_set_min_size): Remove.
8696 (emacs_fixed_new): Set priv->f to argument.
8697 (emacs_fixed_get_preferred_width)
8698 (emacs_fixed_get_preferred_height): Use min_width/height from
8699 frames size_hint to set minimum and natural (Bug#8919).
8700 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8701 and use min_width/height from frames size_hint to set
8702 min_width/height (Bug#8919).
8703
8704 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8705 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8706 Fix indentation.
c7e73be5 8707
cf99dcf8
EZ
87082011-06-26 Eli Zaretskii <eliz@gnu.org>
8709
8710 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8711 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8712 called at ZV.
8713
029529ac
CY
87142011-06-26 Chong Yidong <cyd@stupidchicken.com>
8715
8716 * process.c (wait_reading_process_output): Bypass select if
8717 waiting for a cell while ignoring keyboard input, and input is
8718 pending. Suggested by Jan Djärv (Bug#8869).
8719
7a7ef429
PE
87202011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8721
8722 Use gnulib's dup2 module instead of rolling our own.
8723 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8724
11fdef7d 87252011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8726
8727 * dispnew.c (scrolling_window): Before scrolling, turn off a
8728 mouse-highlight in the window being scrolled.
8729
cd3520a4
JB
87302011-06-24 Juanma Barranquero <lekktu@gmail.com>
8731
8732 Move DEFSYM to lisp.h and use everywhere.
8733
8734 * character.h (DEFSYM): Move declaration...
8735 * lisp.h (DEFSYM): ...here.
8736
8737 * gnutls.c:
8738 * minibuf.c:
8739 * w32menu.c:
8740 * w32proc.c:
8741 * w32select.c: Don't include character.h.
8742
8743 * alloc.c (syms_of_alloc):
8744 * buffer.c (syms_of_buffer):
8745 * bytecode.c (syms_of_bytecode):
8746 * callint.c (syms_of_callint):
8747 * casefiddle.c (syms_of_casefiddle):
8748 * casetab.c (init_casetab_once):
8749 * category.c (init_category_once, syms_of_category):
8750 * ccl.c (syms_of_ccl):
8751 * cmds.c (syms_of_cmds):
8752 * composite.c (syms_of_composite):
8753 * dbusbind.c (syms_of_dbusbind):
8754 * dired.c (syms_of_dired):
8755 * dispnew.c (syms_of_display):
8756 * doc.c (syms_of_doc):
8757 * editfns.c (syms_of_editfns):
8758 * emacs.c (syms_of_emacs):
8759 * eval.c (syms_of_eval):
8760 * fileio.c (syms_of_fileio):
8761 * fns.c (syms_of_fns):
8762 * frame.c (syms_of_frame):
8763 * fringe.c (syms_of_fringe):
8764 * insdel.c (syms_of_insdel):
8765 * keymap.c (syms_of_keymap):
8766 * lread.c (init_obarray, syms_of_lread):
8767 * macros.c (syms_of_macros):
8768 * msdos.c (syms_of_msdos):
8769 * print.c (syms_of_print):
8770 * process.c (syms_of_process):
8771 * search.c (syms_of_search):
8772 * sound.c (syms_of_sound):
8773 * syntax.c (init_syntax_once, syms_of_syntax):
8774 * terminal.c (syms_of_terminal):
8775 * textprop.c (syms_of_textprop):
8776 * undo.c (syms_of_undo):
8777 * w32.c (globals_of_w32):
8778 * window.c (syms_of_window):
8779 * xdisp.c (syms_of_xdisp):
8780 * xfaces.c (syms_of_xfaces):
8781 * xfns.c (syms_of_xfns):
8782 * xmenu.c (syms_of_xmenu):
8783 * xsettings.c (syms_of_xsettings):
8784 * xterm.c (syms_of_xterm): Use DEFSYM.
8785
4228cf16
TZ
87862011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8787
cd3520a4 8788 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8789
7fcccf1e
PE
87902011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8791
7efb4e0e
PE
8792 Integer and buffer overflow fixes (Bug#8873).
8793
ff5844ad
PE
8794 * print.c (printchar, strout): Check for string overflow.
8795 (PRINTPREPARE, printchar, strout):
8796 Don't set size unless allocation succeeds.
8797
90532f02
PE
8798 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8799 for sizes. Check for string overflow more accurately.
8800 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8801
6d84508d
PE
8802 * macros.c: Integer and buffer overflow fixes.
8803 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8804 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8805 Use ptrdiff_t, not int, for sizes.
8806 Don't increment bufsize until after realloc succeeds.
8807 Check for size-calculation overflow.
8808 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8809
437b2cb4
PE
8810 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8811
8b9ac8b4
PE
8812 * lread.c: Integer overflow fixes.
8813 (read_integer): Radix is now EMACS_INT, not int,
8814 to improve quality of diagnostics for out-of-range radices.
8815 Calculate buffer size correctly for out-of-range radices.
8816 (read1): Check for integer overflow in radices, and in
8817 read-circle numbers.
82cb60d3
PE
8818 (read_escape): Avoid int overflow.
8819 (Fload, openp, read_buffer_size, read1)
8820 (substitute_object_recurse, read_vector, read_list, map_obarray):
8821 Use ptrdiff_t, not int, for sizes.
8822 (read1): Use EMACS_INT, not int, for sizes.
20270765 8823 Check for size overflow.
8b9ac8b4 8824
7fcccf1e
PE
8825 * image.c (cache_image): Check for size arithmetic overflow.
8826
bfbbd7e7
PE
8827 * lread.c: Integer overflow issues.
8828 (saved_doc_string_size, saved_doc_string_length)
8829 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8830 Now ptrdiff_t, not int.
8831 (read1): Don't assume doc string length fits in int. Check for
8832 out-of-range doc string lengths.
8833 (read_list): Don't assume file position fits in int.
39019e54 8834 (read_escape): Check for hex character overflow.
bfbbd7e7 8835
4e323265
LL
88362011-06-22 Leo Liu <sdl.web@gmail.com>
8837
8838 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8839 Move to minibuffer.el.
8840
85fece3e
PE
88412011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8842
20b84ce9 8843 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8844 The following patches are for when GLYPH_DEBUG && !XASSERT.
8845 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8846 * dispnew.c (flush_stdout):
8847 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8848 Mark as externally visible.
8849 * dispnew.c (check_window_matrix_pointers): Now static.
8850 * dispnew.c (window_to_frame_vpos):
8851 * xfns.c (unwind_create_frame):
8852 * xterm.c (x_check_font): Remove unused local.
8853 * scroll.c (CHECK_BOUNDS):
8854 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8855 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8856 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8857 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8858 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8859 Now static.
8860 (debug_method_add): Use va_list and vsprintf rather than relying
8861 on undefined behavior with wrong number of arguments.
8862 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8863 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8864 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8865 since we're not interested in debugging glyphs with old libraries.
8866 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8867 GCC 4.6.0's static checking.
8868
0766b489
PE
88692011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8870
31fd4b32
PE
8871 Integer overflow and signedness fixes (Bug#8873).
8872 A few related buffer overrun fixes, too.
8873
b79e8648
PE
8874 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8875
0766b489
PE
8876 * dispextern.h (struct face.stipple):
8877 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8878 (x_bitmap_mask, x_allocate_bitmap_record)
8879 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8880 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8881 (x_create_bitmap_from_xpm_data):
8882 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8883 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8884 (.bitmaps_last):
8885 * xfaces.c (load_pixmap):
8886 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8887 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8888 (.bitmaps_last, struct x_output.icon_bitmap):
8889 Use ptrdiff_t, not int, for bitmap indexes.
8890 (x_allocate_bitmap_record): Check for size overflow.
8891 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8892
b081724f
PE
8893 Use ptrdiff_t, not int, for overlay counts.
8894 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8895 * editfns.c (overlays_around, get_pos_property):
8896 * textprop.c (get_char_property_and_overlay):
8897 * xdisp.c (next_overlay_change, note_mouse_highlight):
8898 * xfaces.c (face_at_buffer_position):
21514da7
PE
8899 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8900 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8901 (Fnext_overlay_change, Fprevious_overlay_change)
8902 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8903 Use ptrdiff_t, not int, for sizes.
21514da7 8904 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8905
3de73e5e
PE
8906 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8907
2606c57b
PE
8908 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8909 (x_session_initialize): Do not assume string length fits in int.
8910
aaafe47a
PE
8911 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8912 This is unlikely, but can occur if DPI is outlandish.
8913
2674ddc8 8914 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8915 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8916
28154962
PE
8917 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8918 * xrdb.c (magic_file_p, search_magic_path):
8919 Omit last arg SUFFIX; it was always 0. All callers changed.
8920 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8921
7de51af5
PE
8922 * xfont.c (xfont_match): Avoid need for strlen.
8923
25ed6cc3
PE
8924 * xfns.c: Don't assume strlen fits in int.
8925 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8926
4eab31dd
PE
8927 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8928 not unsigned long, as we prefer signed integers. All callers changed.
8929 Detect integer overflow in repeat count.
8930 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8931 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8932
171e2a58
PE
8933 * termcap.c: Don't assume sizes fit in int and never overflow.
8934 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8935 (gobble_line): Check for size-calculation overflow.
8936
ad39faca 8937 * minibuf.c (Fread_buffer):
6e5bb2dc 8938 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8939 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8940 Don't assume string length fits in int.
8941
52c61c22 8942 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8943 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8944
b5b8c9e5
PE
8945 * font.c: Don't assume string length fits in int.
8946 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8947 Use ptrdiff_t, not int.
ccd6111c
PE
8948 (font_intern_prop): Don't assume string length fits in int.
8949 Don't assume integer property fits in fixnum.
8950 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8951
882f0d81 8952 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8953 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8954 Reformulate so as not to need the command string.
8955 Invoke gzip -cd rather than gunzip, as it's more portable.
8956 (lock_info_type, lock_file_1, lock_file):
8957 Don't assume pid_t and time_t fit in unsigned long.
8958 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8959 (current_lock_owner): Prefer signed type for sizes.
8960 Use memcpy, not strncpy, where memcpy is what is really wanted.
8961 Don't assume (via atoi) that time_t and pid_t fit in int.
8962 Check for time_t and/or pid_t out of range, e.g., via a network share.
8963 Don't alloca where an auto var works fine.
8964
93f4cf88
PE
8965 * fileio.c: Fix some integer overflow issues.
8966 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8967 Don't assume string length fits in int.
8968 (directory_file_name): Don't assume string length fits in long.
8969 (make_temp_name): Don't assume pid fits in int, or that its print
8970 length is less than 20.
8971
f3e92b69
PE
8972 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8973
1bfdaf10
PE
8974 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8975
35016e9a
PE
8976 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8977
3d1e65a1
PE
8978 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8979 We prefer signed integers, even for size calculations.
8980
0b963a93
PE
8981 * emacs.c: Don't assume string length fits in 'int'.
8982 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8983 (main): Don't invoke strlen when not needed.
8984
573f4b54
PE
8985 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8986 (XD_DEBUG_MESSAGE): Don't waste a byte.
8987
989f33ba
PE
8988 * callproc.c (getenv_internal_1, getenv_internal)
8989 (Fgetenv_internal):
965d34eb
PE
8990 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8991
e4d29b33
PE
8992 * lread.c (invalid_syntax): Omit length argument.
8993 All uses changed. This doesn't fix a bug, but it simplifies the
8994 code away from its former Hollerith-constant appearance, and it's
8995 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8996 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8997
eb49b136
PE
8998 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8999 This didn't break anything, but it didn't help either.
9000 It's confusing to put a bogus integer in a place where the actual
9001 value does not matter.
9f62aeb1 9002 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9003 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9004
15375a22
PE
9005 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9006 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9007 implementation.
b61cc01c
PE
9008 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9009 We prefer signed types, and the value cannot exceed the EMACS_INT
9010 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9011 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9012 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9013 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9014
53b2623d
PE
9015 * indent.c (sane_tab_width): New function.
9016 (current_column, scan_for_column, Findent_to, position_indentation)
9017 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9018 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9019
51cab52b 9020 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9021
f2ed8a70
PE
9022 * lisp.h (lint_assume): New macro.
9023 * composite.c (composition_gstring_put_cache):
9024 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9025
abe80cc6
PE
9026 * editfns.c, insdel.c:
9027 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9028
b02c740e
PE
9029 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9030
ebc96716
PE
9031 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9032
b4e50fa0 9033 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9034 Use much-faster test for byte-length change.
311d5d7c 9035 Don't assume string byte-length fits in 'int'.
a4cf38e4 9036 Check that character arg fits in 'int'.
85461888 9037 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9038
c0c1ee9f
PE
9039 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9040
a498d7f4
PE
9041 * fns.c (concat): Catch string overflow earlier.
9042 Do not rely on integer wraparound.
9043
51cab52b
PE
9044 * dispextern.h (struct it.overlay_strings_charpos)
9045 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9046 * xdisp.c (forward_to_next_line_start)
9047 (back_to_previous_visible_line_start)
9048 (reseat_at_next_visible_line_start, next_element_from_buffer):
9049 Don't arbitrarily truncate the value of 'selective' to int.
9050
76031fad
PE
9051 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9052
5eb55db9
PE
9053 * composite.c: Don't truncate sizes to 'int'.
9054 (composition_gstring_p, composition_reseat_it)
9055 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9056 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9057 not EMACS_UINT, for indexes.
5eb55db9 9058
0703a717
PE
9059 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9060
d6202519
PE
9061 * buffer.c: Include <verify.h>.
9062 (struct sortvec.priority, struct sortstr.priority):
8961a454 9063 Now EMACS_INT, not int.
c20998a7 9064 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9065 (struct sortstr.size, record_overlay_string)
9066 (struct sortstrlist.size, struct sortlist.used):
9067 Don't truncate size to int.
9068 (record_overlay_string): Check for size-calculation overflow.
d6202519 9069 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9070
d5a19415
JM
90712011-06-22 Jim Meyering <meyering@redhat.com>
9072
029529ac 9073 Don't leak an XBM-image-sized buffer
d5a19415
JM
9074 * image.c (xbm_load): Free the image buffer after using it.
9075
a9041e6c
PE
90762011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9077
9078 Port to Sun C.
9079 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9080 that Sun C diagnosed.
9081 * fns.c (secure_hash): Fix pointer signedness issue.
9082 * intervals.c (static_offset_intervals): New function.
9083 (offset_intervals): Use it.
9084
7f3f739f
LL
90852011-06-21 Leo Liu <sdl.web@gmail.com>
9086
9087 * deps.mk (fns.o):
9088 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9089 sha512.h.
9090
9091 * fns.c (secure_hash): Rename from crypto_hash_function and change
9092 the first arg to accept symbols.
5b66d427 9093 (Fsecure_hash): New primitive.
7f3f739f
LL
9094 (syms_of_fns): New symbols.
9095
76147d94
DD
90962011-06-20 Deniz Dogan <deniz@dogan.se>
9097
9098 * process.c (Fset_process_buffer): Clarify return value in
9099 docstring.
9100
7d7d0045
CY
91012011-06-18 Chong Yidong <cyd@stupidchicken.com>
9102
9103 * dispnew.c (add_window_display_history): Use BVAR.
9104
9105 * xdisp.c (debug_method_add): Use BVAR.
9106 (check_window_end, dump_glyph_matrix, dump_glyph)
9107 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9108
9109 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9110 Likewise.
9111
9112 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9113 check till after the cache is created in init_frame_faces.
9114
ff2bc410
SM
91152011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9116
9117 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9118
28177add
PE
91192011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9120
dd3482fe
PE
9121 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9122 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9123 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9124
393d71f3 9125 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9126 * fileio.c (Finsert_file_contents):
9127 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9128 Remove the old (too-loose) buffer overflow checks.
9129 They weren't needed, since make_gap checks for buffer overflow.
9130 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9131 The old code merely checked for Emacs fixnum overflow, and relied
9132 on undefined (wraparound) behavior. The new code avoids undefined
9133 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9134
2e6813b0 9135 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9136 Tune. Don't use wider integers than needed. Don't use alloca.
9137 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9138
599a9e4f
PE
9139 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9140
99561444
PE
9141 * insdel.c, lisp.h (buffer_overflow): New function.
9142 (insert_from_buffer_1, replace_range, replace_range_2):
9143 * insdel.c (make_gap_larger):
9144 * editfns.c (Finsert_char):
9145 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9146
28177add
PE
9147 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9148
e69dafad
PE
91492011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9150
4baa020d 9151 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9152
b1c46f02
PE
9153 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9154 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9155
e69dafad
PE
9156 * fileio.c: Don't assume EMACS_INT fits in off_t.
9157 (emacs_lseek): New static function.
9158 (Finsert_file_contents, Fwrite_region): Use it.
9159 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9160
566684ea
PE
9161 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9162
e6966cd6
PE
9163 * fns.c: Don't overflow int when computing a list length.
9164 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9165 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9166 truncation on 64-bit hosts. Check for QUIT every
9167 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9168 faster and is responsive enough.
9169 (Flength): Report an error instead of overflowing an integer.
9170 (Fsafe_length): Return a float if the value is not representable
9171 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9172 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9173 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9174
dd0b0efb
PE
9175 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9176 (header_size, word_size): New constants.
9177 (allocate_vectorlike): Don't check size overflow here.
9178 (allocate_vector): Check it here instead, since this is the only
9179 caller of allocate_vectorlike that could cause overflow.
9180 Check that the new vector's length is representable as a fixnum.
9181
86fe5cfe
PE
9182 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9183 The previous code was bogus. For example, next_almost_prime (32)
9184 returned 39, which is undesirable as it is a multiple of 3; and
9185 next_almost_prime (24) returned 25, which is a multiple of 5 so
9186 why was the code bothering to check for multiples of 7?
9187
80e88859
PE
9188 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9189
4a2f0ad6
PE
9190 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9191
f66c7cf8
PE
9192 Variadic C functions now count arguments with ptrdiff_t.
9193 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9194 Back then I didn't know that the Emacs coding style prefers signed int.
9195 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9196 were being counted with int, which may truncate counts on 64-bit
9197 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9198 * lisp.h (struct Lisp_Subr.function.aMANY)
9199 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9200 Arg counts are now ptrdiff_t, not size_t.
9201 All variadic functions and their callers changed accordingly.
9202 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9203 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9204 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9205 * callint.c (Fcall_interactively): Check arg count for overflow,
9206 to avoid potential buffer overrun. Use signed char, not 'int',
9207 for 'varies' array, so that we needn't bother to check its size
9208 calculation for overflow.
9209 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9210 * eval.c (apply_lambda):
9211 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9212 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9213 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9214
a1759b76
PE
9215 * callint.c (Fcall_interactively): Don't use index var as event count.
9216
d96be9fc
PE
9217 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9218 * mem-limits.h (SIZE): Remove; no longer used.
9219
a690a978 9220 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9221
578c21e6
PE
9222 Remove unnecessary casts.
9223 * xterm.c (x_term_init):
9224 * xfns.c (x_set_border_pixel):
9225 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9226 These aren't needed now that we assume ANSI C.
9227
96f53c6c
PE
9228 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9229 It's more likely to cause problems (due to unsigned overflow)
9230 than to cure them.
9231
83c77d31
PE
9232 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9233
ee2079f1
PE
9234 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9235
6da65536
PE
9236 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9237
7147c4a4
PE
9238 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9239
193e32d9
PE
9240 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9241
e5533da6
PE
9242 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9243
9910e595
PE
9244 GLYPH_CODE_FACE returns EMACS_INT, not int.
9245 * dispextern.h (merge_faces):
9246 * xfaces.c (merge_faces):
01103c44
PE
9247 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9248 Don't assume EMACS_INT fits in int.
9910e595 9249
2638320e
PE
9250 * character.h (CHAR_VALID_P): Remove unused parameter.
9251 * fontset.c, lisp.h, xdisp.c: All uses changed.
9252
045eb8d9
PE
9253 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9254
c1f134b5
PE
9255 * fns.c (concat): Minor tuning based on overflow analysis.
9256 This doesn't fix any bugs. Use int to hold character, instead
9257 of constantly refetching from Emacs object. Use XFASTINT, not
9258 XINT, for value known to be a character. Don't bother comparing
9259 a single byte to 0400, as it's always less.
9260
395fcb93 9261 * floatfns.c (Fexpt):
327eeec8
PE
9262 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9263
abbd3d23
PE
9264 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9265 for characters.
9266
684a03ef
PE
9267 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9268
0fed43f3
PE
9269 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9270 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9271 incorrectly succeed when S was a string, because 4294967386 was
9272 truncated before it was used.
9273
8fd02eb7
PE
9274 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9275 Otherwise, an out-of-range integer could cause undefined behavior
9276 on a 64-bit host.
9277
f8c86b69
PE
9278 * composite.c: Use int, not EMACS_INT, for characters.
9279 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9280 EMACS_INT, for values that are known to be in character range.
9281 This doesn't fix any bugs but is the usual style inside Emacs and
9282 may generate better code on 32-bit machines.
9283
34206dd2
PE
9284 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9285 This is for reasons similar to the recent CHAR_STRING fix.
9286 * charset.c (Fencode_char): Check that character arg is actually
9287 a character. Pass an int to ENCODE_CHAR.
9288 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9289 wider than 'int', as a compile-time check to prevent future regressions
9290 in this area.
9291
c5958d4c 9292 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9293
9294 Make sure a 64-bit char is never passed to CHAR_STRING.
9295 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9296 by silently ignoring the top 32 bits, allowing some values
9297 that were far too large to be valid characters.
9298 * character.h: Include <verify.h>.
9299 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9300 arguments are no wider than unsigned, as a compile-time check
9301 to prevent future regressions in this area.
9302 * data.c (Faset):
01103c44 9303 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9304 (Fsubst_char_in_region):
9305 * fns.c (concat):
9306 * xdisp.c (decode_mode_spec_coding):
9307 Adjust to CHAR_STRING's new requirement.
9308 * editfns.c (Finsert_char, Fsubst_char_in_region):
9309 * fns.c (concat): Check that character args are actually
9310 characters. Without this test, these functions did the wrong
9311 thing with wildly out-of-range values on 64-bit hosts.
9312
d37ca623
PE
9313 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9314 These casts should not be needed on 32-bit hosts, either.
9315 * keyboard.c (read_char):
9316 * lread.c (Fload): Remove casts to unsigned.
9317
ea204efb
PE
9318 * lisp.h (UNSIGNED_CMP): New macro.
9319 This fixes comparison bugs on 64-bit hosts.
9320 (ASCII_CHAR_P): Use it.
9321 * casefiddle.c (casify_object):
01103c44 9322 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9323 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9324 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9325 * dispextern.h (FACE_FROM_ID):
9326 * keyboard.c (read_char): Use UNSIGNED_CMP.
9327
41cb286c
PE
9328 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9329 not to EMACS_INT, to avoid GCC warning.
9330
4a1b9832
PE
9331 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9332
55daad71
PE
9333 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9334 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9335 isn't needed on 32-bit machines.
8f95c75c 9336
01103c44
PE
9337 * buffer.c (Fgenerate_new_buffer_name):
9338 Use EMACS_INT for count, not int.
0ceccced 9339 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9340
9341 * data.c (Qcompiled_function): Now static.
9342
c6f072e7
PE
9343 * window.c (window_body_lines): Now static.
9344
20ce5912
PE
9345 * image.c (gif_load): Rename local to avoid shadowing.
9346
9c4c5f81
PE
9347 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9348 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9349 * alloc.c (make_save_value): Integer argument is now of type
9350 ptrdiff_t, not int.
9351 (mark_object): Use ptrdiff_t, not int.
9352 * lisp.h (pD): New macro.
9353 * print.c (print_object): Use it.
9354
c0c5c8ae
PE
9355 * alloc.c: Use EMACS_INT, not int, to count objects.
9356 (total_conses, total_markers, total_symbols, total_vector_size)
9357 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9358 (total_free_floats, total_floats, total_free_intervals)
9359 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9360 Now EMACS_INT, not int. All uses changed.
9361 (Fgarbage_collect): Compute overall total using a double, so that
9362 integer overflow is less likely to be a problem. Check for overflow
9363 when converting back to an integer.
5a25e253
PE
9364 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9365 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9366 These were 'int' variables that could overflow on 64-bit hosts;
9367 they were never used, so remove them instead of repairing them.
211a0b2a 9368 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9369 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9370 Previously, this ceilinged at INT_MAX, but that doesn't work on
9371 64-bit machines.
e46bb31a 9372 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9373
c78baabf 9374 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9375 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9376 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9377 when a (possibly-narrower) signed value would do just as well.
9378 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9379
c9d624c6
PE
9380 * alloc.c: Catch some string size overflows that we were missing.
9381 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9382 for convenience in STRING_BYTES_MAX.
9383 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9384 The definition here is exact; the one in lisp.h was approximate.
9385 (allocate_string_data): Check for string overflow. This catches
9386 some instances we weren't catching before. Also, it catches
9387 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9388 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9389 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9390
c9d624c6
PE
9391 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9392 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9393 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9394
353032ce
PE
9395 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9396
2bccce07
PE
9397 * alloc.c (Fmake_string): Check for out-of-range init.
9398
0ac30604
SM
93992011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9400
9401 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9402
c195f2de
JD
94032011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9404
9405 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9406 xg_get_default_scrollbar_width.
9407
9408 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9409 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9410 (style_changed_cb): Call update_theme_scrollbar_width and call
9411 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9412 all frames (Bug#8505).
9413 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9414 Call gtk_window_set_resizable if HAVE_GTK3.
9415 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9416 and height if HAVE_GTK3 (Bug#8505).
9417 (scroll_bar_width_for_theme): New variable.
9418 (update_theme_scrollbar_width): New function.
9419 (xg_get_default_scrollbar_width): Move code to
9420 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9421 (xg_initialize): Call update_theme_scrollbar_width.
9422
9423 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9424
9425 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9426
e10ac9f1
MR
94272011-06-12 Martin Rudalics <rudalics@gmx.at>
9428
9429 * frame.c (make_frame): Call other_buffer_safely instead of
9430 other_buffer.
9431
9432 * window.c (temp_output_buffer_show): Call display_buffer with
9433 second argument Vtemp_buffer_show_specifiers and reset latter
9434 immediately after the call.
9435 (Vtemp_buffer_show_specifiers): New variable.
9436 (auto_window_vscroll_p, next_screen_context_lines)
9437 (Vscroll_preserve_screen_position): Remove leading asterisks from
9438 doc-strings.
9439
2d3c217e 94402011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9441
7b7f97e8 9442 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9443 * buffer.c (Qclone_number): Remove for now, as it's unused.
9444 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9445 (record_buffer): Remove unused local.
9446 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9447 (set_frame_buffer_list): Remove; unused.
9448 * frame.h (other_visible_frames): Remove decl.
9449 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9450 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9451 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9452 if HAVE_GPM.
9453 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9454 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9455 Define only if HAVE_GPM.
9456 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9457 (update_hints_inhibit): Remove; never set. All uses removed.
9458 * widgetprv.h (emacsFrameClassRec): Remove decl.
9459 * window.c (delete_deletable_window): Now returns void, since it
9460 wasn't returning anything.
9461 (compare_window_configurations): Remove unused locals.
9462 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9463 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9464 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9465 the same widths as pointers. This follows up on the 2011-05-06 patch.
9466 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9467 * xterm.h: Likewise.
9468 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9469
1384b89e
JB
94702011-06-12 Juanma Barranquero <lekktu@gmail.com>
9471
9472 * makefile.w32-in: Update dependencies.
9473 (LISP_H): Add lib/intprops.h.
9474
1100a63c
CY
94752011-06-11 Chong Yidong <cyd@stupidchicken.com>
9476
9477 * image.c (gif_load): Add animation frame delay to the metadata.
9478 (syms_of_image): Use DEFSYM. New symbol `delay'.
9479
6198ccd0
MR
94802011-06-11 Martin Rudalics <rudalics@gmx.at>
9481
9482 * window.c (delete_deletable_window): Re-add.
9483 (Fset_window_configuration): Rewrite to handle dead buffers and
9484 consequently deletable windows.
9485 (window_tree, Fwindow_tree): Remove. Supply functionality in
9486 window.el.
9487 (compare_window_configurations): Simplify code.
9488
b6e3633c
AS
94892011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9490
1ab0dee5
AS
9491 * image.c (imagemagick_load_image): Fix type mismatch.
9492 (Fimagemagick_types): Likewise.
9493
b6e3633c
AS
9494 * window.h (replace_buffer_in_windows): Declare.
9495
9397e56f
MR
94962011-06-11 Martin Rudalics <rudalics@gmx.at>
9497
9498 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9499 Qclone_number. Remove external declaration of Qdelete_window.
9500 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9501 code.
640c8776
SM
9502 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9503 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9504 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9505 buffer list implementation.
9506 (other_buffer_safely): New function.
9507 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9508 calls to replace_buffer_in_windows and
9509 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9510 if allowed.
9511 (record_buffer): Inhibit quitting and rewrite using quittable
9512 functions. Run Qbuffer_list_update_hook if allowed.
9513 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9514 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9515 Move switch-to-buffer to window.el.
9397e56f
MR
9516 (bury-buffer): Move to window.el.
9517 (Vbuffer_list_update_hook): New variable.
9518
9519 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9520 section.
9521
9522 * window.h (resize_frame_windows): Move up in code.
9523 (Fwindow_frame): Remove EXFUN.
9524 (replace_buffer_in_all_windows): Remove prototype.
9525 (replace_buffer_in_windows_safely): Add prototype.
9526
9527 * window.c: Declare Qdelete_window static again. Move down
9528 declaration of select_count.
9529 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9530 (Fother_window): Move to window.el.
9531 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9532 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9533 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9534 window.el.
9535 (replace_buffer_in_windows): Implement by calling
9536 Qreplace_buffer_in_windows.
9537 (replace_buffer_in_all_windows): Remove with some functionality
9538 moved into replace_buffer_in_windows_safely.
9539 (replace_buffer_in_windows_safely): New function.
9540 (select_window_norecord, select_frame_norecord): Move in front
9541 of run_window_configuration_change_hook. Remove now obsolete
9542 declarations.
640c8776
SM
9543 (Fset_window_buffer): Rewrite doc-string.
9544 Call Qrecord_window_buffer.
9397e56f
MR
9545 (keys_of_window): Move binding for other-window to window.el.
9546
b50691aa
CY
95472011-06-11 Chong Yidong <cyd@stupidchicken.com>
9548
9549 * dispextern.h (struct image): Replace data member, whose int_val
9550 and ptr_val fields were not used by anything, with a single
9551 lisp_val object.
9552
9553 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9554 (gif_clear_image, gif_load, imagemagick_load_image)
9555 (gs_clear_image, gs_load): Callers changed.
9556
3f754b86
PE
95572011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9558
cca69397
PE
9559 * buffer.h: Include <time.h>, for time_t.
9560 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9561
109e28d0
PE
9562 Fix minor problems found by static checking.
9563
60737f02
PE
9564 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9565
4b66faf3
PE
9566 Make identifiers static if they are not used in other modules.
9567 * data.c (Qcompiled_function, Qframe, Qvector):
9568 * image.c (QimageMagick, Qsvg):
9569 * minibuf.c (Qmetadata):
9570 * window.c (resize_window_check, resize_root_window): Now static.
9571 * window.h (resize_window_check, resize_root_window): Remove decls.
9572
109e28d0
PE
9573 * window.c (window_deletion_count, delete_deletable_window):
9574 Remove; unused.
46a4ce9e
PE
9575 (window_body_lines): Now static.
9576 (Fdelete_other_windows_internal): Mark vars as initialized.
9577 Make sure 'resize_failed' is initialized.
9578 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9579 (resize_window_apply): Remove unused local.
9580 * window.h (delete_deletable_window): Remove decl.
9581
109e28d0 9582 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9583 (imagemagick_load_image): Fix pointer signedness problem by changing
9584 last arg from unsigned char * to char *. All uses changed.
9585 Also, fix a local for similar reasons.
9586 Remove unused locals. Remove locals to avoid shadowing.
9587 (fn_rsvg_handle_free): Remove; unused.
9588 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9589 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9590
3f754b86
PE
9591 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9592
2547adb1
CY
95932011-06-10 Chong Yidong <cyd@stupidchicken.com>
9594
9595 * image.c (gif_load): Fix omitted cast error introduced by
9596 2011-06-06 change.
9597
2c8e37d4
MR
95982011-06-10 Martin Rudalics <rudalics@gmx.at>
9599
9600 * window.h (resize_proportionally, orig_total_lines)
9601 (orig_top_line): Remove from window structure.
9602 (set_window_height, set_window_width, change_window_heights)
9603 (Fdelete_window): Remove prototypes.
9604 (resize_frame_windows): Remove duplicate declaration.
9605
440a42e3
EZ
96062011-06-10 Eli Zaretskii <eliz@gnu.org>
9607
9608 * window.h (resize_frame_windows, resize_window_check)
9609 (delete_deletable_window, resize_root_window)
9610 (resize_frame_windows): Declare prototypes.
9611
9612 * window.c (resize_window_apply): Make definition be "static" to
9613 match the prototype.
9614
562dd5e9
MR
96152011-06-10 Martin Rudalics <rudalics@gmx.at>
9616
9617 * window.c: Remove declarations of Qwindow_size_fixed,
9618 window_min_size_1, window_min_size_2, window_min_size,
9619 size_window, window_fixed_size_p, enlarge_window, delete_window.
9620 Remove static from declaration of Qdelete_window, it's
9621 temporarily needed by Fbury_buffer.
9622 (replace_window): Don't assign orig_top_line and
9623 orig_total_lines.
9624 (Fdelete_window, delete_window): Remove. Window deletion is
9625 handled by window.el.
640c8776
SM
9626 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9627 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9628 (Fdelete_other_windows): Remove. Deleting other windows is
9629 handled by window.el.
9630 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9631 handled in window.el.
9632 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9633 Window minimum sizes are handled in window.el.
9634 (shrink_windows, size_window, set_window_height)
9635 (set_window_width, change_window_heights, window_height)
9636 (window_width, CURBEG, CURSIZE, enlarge_window)
9637 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9638 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9639 handled in window.el.
9640 (make_dummy_parent): Rename to make_parent_window and give it a
9641 second argument horflag.
9642 (make_window): Don't set resize_proportionally any more.
9643 (Fsplit_window): Remove. Windows are split in window.el.
9644 (save_restore_action, save_restore_orig_size)
9645 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9646 Resize mini windows in window.el.
9647 (grow_mini_window, shrink_mini_window): Implement by calling
9648 Qresize_root_window_vertically, resize_window_check and
9649 resize_window_apply.
640c8776
SM
9650 (saved_window, Fset_window_configuration, save_window_save):
9651 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9652 resize_proportionally.
9653 (window_min_height, window_min_width): Move to window.el.
9654 (keys_of_window): Move bindings for delete-other-windows,
9655 split-window, delete-window and enlarge-window to window.el.
9656
9657 * buffer.c: Temporarily extern Qdelete_window.
9658 (Fbury_buffer): Temporarily call Qdelete_window instead of
9659 Fdelete_window (Fbury_buffer will move to window.el soon).
9660
9661 * frame.c (set_menu_bar_lines_1): Remove code handling
9662 orig_top_line and orig_total_lines.
9663
9664 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9665 set_window_height but set heights directly.
9666 (change_frame_size_1): Use resize_frame_windows.
9667
9668 * xdisp.c (init_xdisp): Don't use set_window_height but set
9669 heights directly.
9670
640c8776
SM
9671 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9672 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9673 run_window_configuration_change_hook.
9674
9675 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9676 instead of change_window_heights and run
9677 run_window_configuration_change_hook.
9678
1a13852e
MR
96792011-06-09 Martin Rudalics <rudalics@gmx.at>
9680
9681 * window.c (replace_window): Rename second argument REPLACEMENT to
9682 NEW. New third argument SETFLAG. Rewrite.
9683 (delete_window, make_dummy_parent): Call replace_window with
9684 third argument 1.
9685 (window_list_1): Move down in code.
9686 (run_window_configuration_change_hook): Move set_buffer part
9687 before select_frame_norecord part in order to unwind correctly.
9688 Rename count1 to count.
9689 (recombine_windows, delete_deletable_window, resize_root_window)
9690 (Fdelete_other_windows_internal)
9691 (Frun_window_configuration_change_hook, make_parent_window)
9692 (resize_window_check, resize_window_apply, Fresize_window_apply)
9693 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9694 (Fdelete_window_internal, Fresize_mini_window_internal):
9695 New functions.
1a13852e
MR
9696 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9697
f3d1777e
MR
96982011-06-08 Martin Rudalics <rudalics@gmx.at>
9699
496e208e
MR
9700 * window.h (window): Add some new members to window structure -
9701 normal_lines, normal_cols, new_total, new_normal, clone_number,
9702 splits, nest, prev_buffers, next_buffers.
9703 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9704 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9705
f3d1777e
MR
9706 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9707 Remove.
496e208e
MR
9708 (make_dummy_parent): Set new members of windows structure.
9709 (make_window): Move down in code. Handle new members of window
9710 structure.
9711 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9712 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9713 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9714 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9715 (Fset_window_next_buffers, Fset_window_clone_number):
9716 New functions.
496e208e
MR
9717 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9718 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9719 Doc-string fixes.
9720 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9721 Argument WINDOW can be now internal window too.
9722 (Fwindow_use_time): Move up in code.
9723 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9724 Rewrite doc-string.
9725 (Fset_window_configuration, saved_window)
9726 (Fcurrent_window_configuration, save_window_save): Handle new
9727 members of window structure.
b9e809c2
MR
9728 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9729 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9730 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9731 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9732 Qget_mru_window, Qresize_root_window,
9733 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9734 Qauto_buffer_name; staticpro them.
f3d1777e 9735
abde8f8c
MR
97362011-06-07 Martin Rudalics <rudalics@gmx.at>
9737
9738 * window.c (Fwindow_total_size, Fwindow_left_column)
9739 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9740 (Fwindow_list_1): New functions.
9741 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9742 (Fwindow_width, Fscroll_left, Fscroll_right):
9743 Use window_body_cols instead of window_box_text_cols.
9744 (delete_window, Fset_window_configuration):
9745 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9746 (delete_all_subwindows): Take a window as argument and not a
9747 structure. Rewrite.
190b47e6
MR
9748 (window_loop): Remove handling of GET_LRU_WINDOW and
9749 GET_LARGEST_WINDOW.
9750 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9751
9752 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9753 window_box_text_cols. delete_all_subwindows now takes a
9754 Lisp_Object as argument.
abde8f8c 9755
640c8776
SM
9756 * indent.c (compute_motion, Fcompute_motion):
9757 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9758
fa8a67e6
MR
9759 * frame.c (delete_frame): Call delete_all_subwindows with root
9760 window as argument.
9761
a54e3482
DC
97622011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9763
9764 * fns.c (Fputhash): Document return value.
9765
60002bf5
CY
97662011-06-06 Chong Yidong <cyd@stupidchicken.com>
9767
9768 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9769
0c671da6 97702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9771
b862a52a 9772 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9773
be44ca6c
PE
9774 Check for overflow when converting integer to cons and back.
9775 * charset.c (Fdefine_charset_internal, Fdecode_char):
9776 Use cons_to_unsigned to catch overflow.
9777 (Fencode_char): Use INTEGER_TO_CONS.
9778 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9779 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9780 * data.c (long_to_cons, cons_to_long): Remove.
9781 (cons_to_unsigned, cons_to_signed): New functions.
9782 These signal an error for invalid or out-of-range values.
9783 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9784 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9785 * font.c (Ffont_variation_glyphs):
9786 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9787 * lisp.h: Include <intprops.h>.
9788 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9789 (cons_to_signed, cons_to_unsigned): New decls.
9790 (long_to_cons, cons_to_long): Remove decls.
9791 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9792 (Fprimitive_undo): Use CONS_TO_INTEGER.
9793 * xfns.c (Fx_window_property): Likewise.
9794 * xselect.c: Include <limits.h>.
9795 (x_own_selection, selection_data_to_lisp_data):
9796 Use INTEGER_TO_CONS.
9797 (x_handle_selection_request, x_handle_selection_clear)
9798 (x_get_foreign_selection, Fx_disown_selection_internal)
9799 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9800 (lisp_data_to_selection_data): Use cons_to_unsigned.
9801 (x_fill_property_data): Use cons_to_signed.
9802 Report values out of range.
9803
d1f3d2af
PE
9804 Check for buffer and string overflow more precisely.
9805 * buffer.h (BUF_BYTES_MAX): New macro.
9806 * lisp.h (STRING_BYTES_MAX): New macro.
9807 * alloc.c (Fmake_string):
9808 * character.c (string_escape_byte8):
9809 * coding.c (coding_alloc_by_realloc):
9810 * doprnt.c (doprnt):
9811 * editfns.c (Fformat):
9812 * eval.c (verror):
9813 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9814 since they may not be the same number.
9815 * editfns.c (Finsert_char):
9816 * fileio.c (Finsert_file_contents):
9817 Likewise for BUF_BYTES_MAX.
9818
dd52fcea
PE
9819 * image.c: Use ptrdiff_t, not int, for sizes.
9820 (slurp_file): Switch from int to ptrdiff_t.
9821 All uses changed.
9822 (slurp_file): Check that file size fits in both size_t (for
9823 malloc) and ptrdiff_t (for sanity and safety).
9824
7f9bbdbb
PE
9825 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9826 if b->modtime has its maximal value.
9827
dfe18f82
PE
9828 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9829
84acfcf0
PE
9830 Don't assume time_t can fit into int.
9831 * buffer.h (struct buffer.modtime): Now time_t, not int.
9832 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9833 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9834
ccd9a01a
PE
9835 Minor fixes for signed vs unsigned integers.
9836 * character.h (MAYBE_UNIFY_CHAR):
9837 * charset.c (maybe_unify_char):
9838 * keyboard.c (read_char, reorder_modifiers):
9839 XINT -> XFASTINT, since the integer must be nonnegative.
9840 * ftfont.c (ftfont_spec_pattern):
9841 * keymap.c (access_keymap, silly_event_symbol_error):
9842 XUINT -> XFASTINT, since the integer must be nonnegative.
9843 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9844 since it makes no difference and we prefer signed.
9845 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9846 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9847 nonnegative.
9848
d6d100dd
SM
98492011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9850
9851 * window.h (Fwindow_frame): Declare.
9852
2b6148e4
PE
98532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9854
9855 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9856 (SPARE_MEMORY): Always define.
9857 (LARGE_REQUEST): Remove.
9858 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9859
f230ecc9
MR
98602011-06-06 Martin Rudalics <rudalics@gmx.at>
9861
727e958e
MR
9862 * lisp.h: Move EXFUNS for Fframe_root_window,
9863 Fframe_first_window and Fset_frame_selected_window to window.h.
9864
9865 * window.h: Move EXFUNS for Fframe_root_window,
9866 Fframe_first_window and Fset_frame_selected_window here from
9867 lisp.h.
9868
9869 * frame.c (Fwindow_frame, Fframe_first_window)
9870 (Fframe_root_window, Fframe_selected_window)
9871 (Fset_frame_selected_window): Move to window.c.
9872 (Factive_minibuffer_window): Move to minibuf.c.
9873 (Fother_visible_frames_p): New function.
9874
9875 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9876
f230ecc9
MR
9877 * window.c (decode_window, decode_any_window): Move up in code.
9878 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9879 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9880 (Fwindow_buffer): Move up and rewrite doc-string.
9881 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9882 (Fwindow_prev): New functions.
727e958e
MR
9883 (Fwindow_frame): Move here from frame.c. Accept any window as
9884 argument.
9885 (Fframe_root_window, Fframe_first_window)
9886 (Fframe_selected_window): Move here from frame.c. Accept frame
9887 or arbitrary window as argument. Update doc-strings.
9888 (Fminibuffer_window): Move up in code.
9889 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9890 (Fset_frame_selected_window): Move here from frame.c.
9891 Marginal rewrite.
727e958e
MR
9892 (Fselected_window, select_window, Fselect_window): Move up in
9893 code. Minor doc-string fixes.
f230ecc9 9894
4d09bcf6
PE
98952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9896
9897 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9898 Do not assume that spare memory exists; that assumption is valid
9899 only if SYSTEM_MALLOC.
9900 (LARGE_REQUEST): New macro, so that the issue of large requests
9901 is separated from the issue of spare memory.
9902
810928a2
AS
99032011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9904
172418ad
AS
9905 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9906 format. (Bug#8806)
9907
43f862f7
AS
9908 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9909
810928a2
AS
9910 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9911 before statements.
9912
a059fe24
JD
99132011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9914
9915 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9916
9917 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9918
9919 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9920 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9921
989bf368
JB
99222011-06-05 Juanma Barranquero <lekktu@gmail.com>
9923
9924 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9925
4b80f674
CY
99262011-06-04 Chong Yidong <cyd@stupidchicken.com>
9927
9928 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9929 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9930 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9931 New error handlers.
4b80f674
CY
9932 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9933 Obey Vx_select_enable_clipboard_manager. Catch errors in
9934 x_clipboard_manager_save (Bug#8779).
9935 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9936 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9937
99a33b77 99382011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9939
9940 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9941
99a33b77 99422011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9943
9944 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9945 in the current matrix if keep_current_p is non-zero.
9946
8264569d
EZ
99472011-06-04 Eli Zaretskii <eliz@gnu.org>
9948
9949 * bidi.c (bidi_level_of_next_char): Fix last change.
9950
57f97249
EZ
99512011-06-03 Eli Zaretskii <eliz@gnu.org>
9952
fec2107c 9953 Support bidi reordering of text covered by display properties.
57f97249 9954
fec2107c
EZ
9955 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9956 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9957 (bidi_cache_search, bidi_cache_iterator_state)
9958 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9959 (bidi_level_of_next_char, bidi_move_to_visually_next):
9960 Support character positions inside a run of characters covered by a
fec2107c
EZ
9961 display string.
9962 (bidi_paragraph_init, bidi_resolve_explicit_1)
9963 (bidi_level_of_next_char): Call bidi_fetch_char and
9964 bidi_fetch_char_advance instead of FETCH_CHAR and
9965 FETCH_CHAR_ADVANCE.
9966 (bidi_init_it): Initialize new members.
9967 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9968 definitions.
9969 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9970 instead of using explicit *_CHAR codes.
d6d100dd
SM
9971 (bidi_resolve_explicit, bidi_resolve_weak):
9972 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9973 bidirectional text is supported only in multibyte buffers.
9974 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9975 it to initialize the frame_window_p member of struct bidi_it.
9976 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9977 (bidi_resolve_explicit, bidi_resolve_weak)
9978 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9979 bidi_it->nchars is non-positive.
9980 (bidi_level_of_next_char): Don't try to lookup the cache for the
9981 next/previous character if nothing is cached there yet, or if we
9982 were just reseat()'ed to a new position.
c40e2fb2 9983
0e14fe90
EZ
9984 * xdisp.c (set_cursor_from_row): Set start and stop points
9985 according to the row's direction when priming the loop that looks
9986 for the glyph on which to display cursor.
9987 (single_display_spec_intangible_p): Function deleted.
9988 (display_prop_intangible_p): Reimplement to call
9989 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9990 Accept 3 additional arguments needed by handle_display_spec.
9991 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9992 values: lists, `(when COND...)' forms, etc.
9993 (single_display_spec_string_p): Support property values that are
9994 lists with the argument STRING its top-level element.
9995 (display_prop_string_p): Fix the condition for processing a
9996 property that is a list to be consistent with handle_display_spec.
fec2107c 9997 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9998 last portion of handle_display_prop.
9999 (compute_display_string_pos): Accept additional argument
10000 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10001 value of a `display' property is a "replacing spec".
10002 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10003 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10004 the display property, but just return a value indicating whether
10005 the display property will replace the characters it covers.
10006 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10007 frame_window_p members of struct bidi_it.
d6d100dd
SM
10008 (compute_display_string_pos, compute_display_string_end):
10009 New functions.
fec2107c
EZ
10010 (push_it): Accept second argument POSITION, where pop_it should
10011 jump to continue iteration.
10012 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10013
fec2107c
EZ
10014 * keyboard.c (adjust_point_for_property): Adjust the call to
10015 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10016
10017 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10018 (bidi_init_it): Update prototypes.
10019 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10020 (compute_display_string_pos, compute_display_string_end):
10021 Declare prototypes.
fec2107c
EZ
10022 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10023 EMACS_INT.
fc6f18ce 10024
40087514 100252011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10026
57f53182
PE
10027 Malloc failure behavior now depends on size of allocation.
10028 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10029 * lisp.h: Change signatures accordingly.
10030 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10031 All callers changed. (Bug#8762)
10032
10033 * gnutls.c: Use Emacs's memory allocators.
10034 Without this change, the gnutls library would invoke malloc etc.
10035 directly, which causes problems on non-SYNC_INPUT hosts, and which
10036 runs afoul of improving memory_full behavior. (Bug#8761)
10037 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10038 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10039 xfree instead of the default malloc, realloc, free.
10040 (Fgnutls_boot): No need to check for memory allocation failure,
10041 since xmalloc does that for us.
10042
ac32cd99 10043 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10044 * category.c (hash_get_category_set):
10045 * ccl.c (ccl_driver):
10046 * charset.c (Fdefine_charset_internal):
10047 * charset.h (struct charset.hash_index):
10048 * composite.c (get_composition_id, gstring_lookup_cache)
10049 (composition_gstring_put_cache):
10050 * composite.h (struct composition.hash_index):
10051 * dispextern.h (struct image.hash):
10052 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10053 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10054 (hashfn_equal, hashfn_user_defined, make_hash_table)
10055 (maybe_resize_hash_table, hash_lookup, hash_put)
10056 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10057 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10058 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10059 * image.c (make_image, search_image_cache, lookup_image)
10060 (xpm_put_color_table_h):
10061 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10062 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10063 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10064 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10065 * alloc.c (allocate_vectorlike):
10066 Check for overflow in vector size calculations.
10067 * ccl.c (ccl_driver):
10068 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10069 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10070 need to be updated by these changes.
40087514
PE
10071 * fns.c (make_hash_table, maybe_resize_hash_table):
10072 Check for integer overflow with large hash tables.
0de4bb68
PE
10073 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10074 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10075 (SXHASH_REDUCE): New macro.
10076 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10077 Use it instead of discarding useful hash info with large hash values.
10078 (sxhash_float): New function.
10079 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10080 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10081 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10082 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10083 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10084 Adjust signatures to match updated version of code.
10085 (consing_since_gc): Now EMACS_INT, since a single hash table can
10086 use more than INT_MAX bytes.
10087
698d32e2
DN
100882011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10089
10090 Make it possible to build with GCC-4.6+ -O2 -flto.
10091
10092 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10093
fd6fa53f
SM
100942011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10095
10096 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10097 Call minibuffer-inactive-mode.
10098
864db017
JB
100992011-05-31 Juanma Barranquero <lekktu@gmail.com>
10100
10101 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10102 Update dependencies.
10103
2ad0baf4
DN
101042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10105
10106 * data.c (init_data): Remove code for UTS, this system is not
10107 supported anymore.
10108
4fcc2638
DN
101092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10110
10111 Don't force ./temacs to start in terminal mode.
10112
10113 * frame.c (make_initial_frame): Initialize faces in all cases, not
10114 only when CANNOT_DUMP is defined.
10115 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10116
c56e0fd5
DN
101172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10118
10119 * dispnew.c (add_window_display_history): Use const for the string
10120 pointer. Remove declaration, not needed.
10121
333d54da 101222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10123
55d4c1b2 10124 Use 'inline', not 'INLINE'.
333d54da 10125 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10126 * alloc.c, fontset.c (INLINE): Remove.
10127 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10128 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10129 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10130 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10131 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10132
738db178
DN
101332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10134
10135 Make it possible to run ./temacs.
10136
10137 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10138 syms_of_callproc does the same thing. Remove test for
10139 "initialized", do it in the caller.
10140 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10141
620c53a6
SM
101422011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10143
10144 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10145 (read_minibuf): Use get_minibuffer.
10146 (syms_of_minibuf): Use DEFSYM.
10147 (Qmetadata): New var.
10148 * data.c (Qbuffer): Don't make it static.
10149 (syms_of_data): Use DEFSYM.
10150
e003a292
PE
101512011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10152
10153 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10154 (CCL_CODE_MIN): New macro.
10155
ed008a6d
PE
101562011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10157
3687c2ef
PE
10158 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10159
ed008a6d
PE
10160 * eval.c (Qdebug): Now static.
10161 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10162 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10163 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10164
d66c4c7c
CY
101652011-05-29 Chong Yidong <cyd@stupidchicken.com>
10166
10167 * image.c: Various fixes to ImageMagick code comments.
10168 (Fimagemagick_types): Doc fix.
10169
5fbc2025
PE
101702011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10171
0196f88a
PE
10172 Minor fixes prompted by GCC 4.6.0 warnings.
10173
10174 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10175
5fbc2025
PE
10176 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10177 (x_clipboard_manager_save_all): Move extern decl to ...
10178 * xterm.h: ... here, so that it can be checked for consistency.
10179
1dd3c2d9
CY
101802011-05-29 Chong Yidong <cyd@stupidchicken.com>
10181
10182 * xselect.c (x_clipboard_manager_save_frame)
10183 (x_clipboard_manager_save_all): New functions.
10184 (Fx_clipboard_manager_save): Lisp function deleted.
10185
10186 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10187 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10188
10189 * xterm.h: Update prototype.
10190
5ba6571d
WX
101912011-05-28 William Xu <william.xwl@gmail.com>
10192
10193 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10194 exiting (Bug#8239).
10195
3eaff834
JM
101962011-05-28 Jim Meyering <meyering@redhat.com>
10197
e1900994 10198 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10199 * fns.c (to_uchar): Define.
10200 (crypto_hash_function): Use it to convert some newly-signed
10201 variables to unsigned, to avoid sign-extension bugs. For example,
10202 without this change, (md5 "truc") would evaluate to
10203 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10204 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10205 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10206
0f6990a7
PE
102072011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10208
10209 Integer overflow fixes.
c8a9ca5a 10210
08686060
PE
10211 * dbusbind.c: Serial number integer overflow fixes.
10212 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10213 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10214 to hold a serial number that is too large for a fixnum.
10215 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10216 Check for serial numbers out of range. Decode any serial number
59568bf0 10217 that was so large that it became a float. (Bug#8722)
08686060 10218
2d1fc3c7
PE
10219 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10220 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10221 Use XFASTINT rather than XUINT when numbers are nonnegative.
10222 (xd_append_arg, Fdbus_method_return_internal):
10223 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10224 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10225 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10226 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10227 (Bug#8722)
2d1fc3c7 10228
c8a9ca5a
PE
10229 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10230
519e1d69
PE
10231 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10232
6df6ae42 10233 ccl: Add integer overflow checks.
30569699
PE
10234 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10235 (IN_INT_RANGE): New macros.
10236 (ccl_driver): Use them to check for integer overflow when
10237 decoding a CCL program. Many of the new checks are whether XINT (x)
10238 fits in int; it doesn't always, on 64-bit hosts. The new version
10239 doesn't catch all possible integer overflows, but it's an
847044ea 10240 improvement. (Bug#8719)
30569699 10241
c11285dc
PE
10242 * alloc.c (make_event_array): Use XINT, not XUINT.
10243 There's no need for unsigned here.
10244
fdccd48e
PE
10245 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10246 This follows up to the 2011-05-06 change that substituted uintptr_t
10247 for EMACS_INT. This case wasn't caught back then.
10248
37910ab2
PE
10249 Rework Fformat to avoid integer overflow issues.
10250 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10251 now (part of C89). Include <verify.h>.
10252 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10253 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10254 (Fformat): Avoid the prepass trying to compute sizes; it was only
10255 approximate and thus did not catch overflow reliably. Instead, walk
10256 through the format just once, formatting and computing sizes as we go,
10257 checking for integer overflow at every step, and allocating a larger
10258 buffer as needed. Keep track separately whether the format is
10259 multibyte. Keep only the most-recently calculated precision, rather
10260 than them all. Record whether each argument has been converted to
10261 string. Use EMACS_INT, not int, for byte and char and arg counts.
10262 Support field widths and precisions larger than INT_MAX. Avoid
10263 sprintf's undefined behavior with conversion specifications such as %#d
10264 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10265 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10266 formatting out-of-range floating point numbers with int
9173deec 10267 formats. (Bug#8668)
37910ab2 10268
2e6578fb
PE
10269 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10270
0ae6bdee
PE
10271 * data.c: Avoid integer truncation in expressions involving floats.
10272 * data.c: Include <intprops.h>.
10273 (arith_driver): When there's an integer overflow in an expression
10274 involving floating point, convert the integers to floating point
10275 so that the resulting value does not suffer from catastrophic
10276 integer truncation. For example, on a 64-bit host (* 4
10277 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10278 Do not rely on undefined behavior after integer overflow.
10279
de883a70
PE
10280 merge count_size_as_multibyte, parse_str_to_multibyte
10281 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10282 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10283 Check for integer overflow.
10284 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10285 since it's now a duplicate of the other. This is more of
10286 a character than a buffer op, so better that it's in character.c.
10287 * fns.c, print.c: Adjust to above changes.
10288
2ff916cb
PE
102892011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10290
10291 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10292
f1b54466
PE
102932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10294
fb1ac845
PE
10295 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10296 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10297 (x_clipboard_manager_save): Now static.
10298 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10299
f1b54466
PE
10300 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10301 (crypto_hash_function): Now static.
10302 Fix pointer signedness problems. Avoid unnecessary initializations.
10303
a9f737ee
CY
103042011-05-27 Chong Yidong <cyd@stupidchicken.com>
10305
10306 * termhooks.h (Vselection_alist): Make it terminal-local.
10307
10308 * terminal.c (create_terminal): Initialize it.
10309
10310 * xselect.c: Support for clipboard managers.
10311 (Vselection_alist): Move to termhooks.h as terminal-local var.
10312 (LOCAL_SELECTION): New macro.
10313 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10314 (symbol_to_x_atom): Remove gratuitous arg.
10315 (x_handle_selection_request, lisp_data_to_selection_data)
10316 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10317 (x_own_selection, x_get_local_selection, x_convert_selection):
10318 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10319 (some_frame_on_display): Delete unused function.
10320 (Fx_own_selection_internal, Fx_get_selection_internal)
10321 (Fx_disown_selection_internal, Fx_selection_owner_p)
10322 (Fx_selection_exists_p): New optional frame arg.
10323 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10324 (x_handle_selection_clear): Don't treat other terminals with the
10325 same keyboard specially. Use the terminal-local Vselection_alist.
10326 (x_clear_frame_selections): Use Frun_hook_with_args.
10327
10328 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10329
10330 * xterm.h: Add support for those atoms.
10331
e067f0c1
CY
103322011-05-26 Chong Yidong <cyd@stupidchicken.com>
10333
10334 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10335 (converted_selections, conversion_fail_tag): New global variables.
10336 (x_selection_request_lisp_error): Free the above.
10337 (x_get_local_selection): Remove unnecessary code.
10338 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10339 of converted selections stored in converted_selections.
10340 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10341 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10342 (x_convert_selection): New function.
10343 (x_handle_selection_event): Simplify.
10344 (x_get_foreign_selection): Don't ignore incoming requests while
10345 waiting for an answer; this will fail when we implement
10346 SAVE_TARGETS, and seems unnecessary anyway.
10347 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10348 (Vx_sent_selection_functions): Doc fix.
10349
0f4aebc0
LL
103502011-05-26 Leo Liu <sdl.web@gmail.com>
10351
10352 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10353
e61124cd
YM
103542011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10355
10356 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10357
10358 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10359 for fringe update if it has periodic bitmap.
ac389d0c 10360 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10361 and fringe_bitmap_periodic_p.
10362
10363 * fringe.c (get_fringe_bitmap_data): New function.
10364 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10365 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10366 row. Mark glyph row for fringe update if periodicity changed.
10367
10368 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10369 for fringe update unless it has periodic bitmap.
10370
f16d9837
KH
103712011-05-25 Kenichi Handa <handa@m17n.org>
10372
10373 * xdisp.c (get_next_display_element): Set correct it->face_id for
10374 a static composition.
10375
e1b90ef6
LL
103762011-05-24 Leo Liu <sdl.web@gmail.com>
10377
10378 * deps.mk (fns.o):
10379 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10380
10381 * fns.c (crypto_hash_function, Fsha1): New function.
10382 (Fmd5): Use crypto_hash_function.
10383 (syms_of_fns): Add Ssha1.
10384
7400048f
PE
103852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10386
10387 * gnutls.c: Remove unused macros.
10388 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10389 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10390 Remove macros that are defined and never used.
10391 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10392
abb71cf4
CY
103932011-05-22 Chong Yidong <cyd@stupidchicken.com>
10394
10395 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10396 (Fx_get_selection_internal): Minor cleanup.
10397 (Fx_own_selection_internal): Rename arguments for consistency with
10398 select.el.
10399
6307db39
PE
104002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10401
10402 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10403
f3d4e0a4
CY
104042011-05-22 Chong Yidong <cyd@stupidchicken.com>
10405
10406 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10407
4d8ade89
YM
104082011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10409
10410 * dispnew.c (scrolling_window): Don't exclude the case that the
10411 last enabled row in the desired matrix touches the bottom boundary.
10412
32078c8d
GM
104132011-05-21 Glenn Morris <rgm@gnu.org>
10414
10415 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10416 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10417 and add some more files.
32078c8d 10418
7285dc67
EZ
104192011-05-20 Eli Zaretskii <eliz@gnu.org>
10420
10421 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10422 report_file_error introduced by the change from 2011-05-07.
10423
89d1bd22
PE
104242011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10425
10426 * systime.h (Time): Define only if emacs is defined.
10427 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10428 where the include path doesn't have X11/X.h by default. See
10429 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10430
cd394be1 104312011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10432
10433 * composite.c (find_automatic_composition): Fix previous change.
10434
b9704ad9
GM
104352011-05-20 Glenn Morris <rgm@gnu.org>
10436
10437 * lisp.mk: New file, split from Makefile.in.
10438 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10439 (shortlisp): Remove.
10440 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10441
4a720484
GM
104422011-05-19 Glenn Morris <rgm@gnu.org>
10443
10444 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10445 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10446 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10447 (lisp): Set the order to that of loadup.el.
10448 (shortlisp): Make it a copy of $lisp.
10449 (SOME_MACHINE_LISP): Remove.
10450 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10451 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10452
a28d4396
KH
104532011-05-18 Kenichi Handa <handa@m17n.org>
10454
10455 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10456 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10457 (find_automatic_composition): Mostly rewrite for efficiency.
10458
a2b1fa8e
JB
104592011-05-18 Juanma Barranquero <lekktu@gmail.com>
10460
10461 * makefile.w32-in: Update dependencies.
10462
8e1f5610
CS
104632011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10464
10465 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10466 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10467
7025ee00 104682011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10469
cdfa6eab
PE
10470 Fix some integer overflow issues, such as string length overflow.
10471
06d6db33
PE
10472 * insdel.c (count_size_as_multibyte): Check for string overflow.
10473
2b4560a8
PE
10474 * character.c (lisp_string_width): Check for string overflow.
10475 Use EMACS_INT, not int, for string indexes and lengths; in
10476 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10477 the resulting string length overflows an EMACS_INT; instead,
10478 report a string overflow if no precision given. When checking for
10479 precision exhaustion, use a check that cannot possibly have
10480 integer overflow. (Bug#8675)
10481 * character.h (lisp_string_width): Adjust to new signature.
10482
cb93f9be
PE
10483 * alloc.c (string_overflow): New function.
10484 (Fmake_string): Use it. This doesn't change behavior, but saves
10485 a few bytes and will simplify future changes.
10486 * character.c (string_escape_byte8): Likewise.
10487 * lisp.h (string_overflow): New decl.
10488
1a1f3366
PE
10489 Fixups, following up to the user-interface timestamp change.
10490 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10491 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10492 * msdos.c (mouse_get_pos): Likewise.
10493 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10494 * w32gui.h (Time): Define by including "systime.h" rather than by
10495 declaring it ourselves. (Bug#8664)
10496
d4e3e4d3
PE
10497 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10498 * image.c (clear_image_cache): Likewise.
10499
f6a24d19
PE
10500 * term.c (term_mouse_position): Don't assume time_t wraparound.
10501
08dc5ae6
PE
10502 Be more systematic about user-interface timestamps.
10503 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10504 and sometimes 'EMACS_UINT', to represent these timestamps.
10505 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10506 This makes the code easier to follow, and makes it easier to catch
10507 integer overflow bugs such as Bug#8664.
10508 * frame.c (Fmouse_position, Fmouse_pixel_position):
10509 Use Time, not unsigned long, for user-interface timestamps.
10510 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10511 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10512 * keyboard.h (last_event_timestamp): Likewise.
10513 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10514 * menu.h (xmenu_show): Likewise.
10515 * term.c (term_mouse_position): Likewise.
10516 * termhooks.h (struct input_event.timestamp): Likewise.
10517 (struct terminal.mouse_position_hook): Likewise.
10518 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10519 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10520 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10521 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10522 what it was before.
10523 * menu.h, termhooks.h: Include "systime.h", for Time.
10524
8e55734a
PE
10525 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10526 Don't assume that the difference between two unsigned long values
10527 can fit into an integer. At this point, we know button_down_time
10528 <= event->timestamp, so the difference must be nonnegative, so
10529 there's no need to cast the result if double-click-time is
10530 nonnegative, as it should be; check that it's nonnegative, just in
10531 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10532 apart (about 25 days). (Bug#8664)
8e55734a 10533
841f1b75 10534 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10535 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10536
3e26f69c
PE
10537 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10538 that always fit in int. Use a sentinel instead of a counter, to
10539 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10540 * frame.h (struct frame): Use int for menu_bar_items_used
10541 instead of EMACS_INT, since it always fits in int.
3e26f69c 10542
5cc152c0
PE
10543 * menu.c (grow_menu_items): Check for int overflow.
10544
d89eb65e
PE
10545 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10546
5235bd3e
PE
10547 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10548 Before, the code was not consistent. These values cannot exceed
10549 2**31 - 1 so there's no need to make them unsigned.
10550 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10551 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10552 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10553 as modifiers.
10554 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10555
bc827e23
PE
10556 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10557 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10558 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10559 presumably because the widths might not match.
10560
78eb494e
PE
10561 * window.c (size_window): Avoid needless test at loop start.
10562
04f2d78b
CB
105632011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10564
10565 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10566
d2fc7e3d 105672011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10568
10569 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10570
d2fc7e3d 105712011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10572
10573 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10574 `width' to `bar_area_x' and `bar_area_width', respectively.
10575 (x_scroll_run): Take account of fringe background extension.
10576
04f2d78b
CB
10577 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10578 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10579 `bar_area_width', respectively.
10580 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10581 background extension.
10582
79b70037
GM
105832011-05-10 Jim Meyering <meyering@redhat.com>
10584
10585 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10586
2f142cc5
JB
105872011-05-10 Juanma Barranquero <lekktu@gmail.com>
10588
10589 * image.c (Finit_image_library): Return t for built-in image types,
10590 like pbm and xbm. (Bug#8640)
10591
57679c86
AS
105922011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10593
10594 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10595
888c9e86
EZ
105962011-05-07 Eli Zaretskii <eliz@gnu.org>
10597
b0512a1d
EZ
10598 * w32console.c (Fset_screen_color): Doc fix.
10599 (Fget_screen_color): New function.
10600 (syms_of_ntterm): Defsubr it.
10601
7285dc67
EZ
10602 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10603 unlink the temporary file if Fcall_process didn't create it in the
10604 first place.
10605 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10606 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10607 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10608 cue to call_process_cleanup not to close that handle.
10609
4d3fcc8e
BK
106102011-05-07 Ben Key <bkey76@gmail.com>
10611
10612 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10613 one of two shell specific rules, either bootstrap-temacs-CMD or
10614 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10615 to the previous implementation of the bootstrap-temacs rule.
10616 The bootstrap-temacs-CMD rule is similar to the previous
10617 implementation of the bootstrap-temacs rule except that it
10618 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10619 variable.
10620
10621 These changes, along with some changes to nt/configure.bat,
10622 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10623 earlier fix to add support for --cflags and --ldflags options
10624 that include quotes so that it works whether make uses cmd or
10625 sh as the shell.
10626
b4289b64
MA
106272011-05-06 Michael Albinus <michael.albinus@gmx.de>
10628
10629 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10630 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10631 is a constant.
10632 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10633 a string. Handle both cases.
10634 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10635 (Fdbus_register_method): Use Qinvalid_function.
10636
af4c0e28
JB
106372011-05-06 Juanma Barranquero <lekktu@gmail.com>
10638
10639 * makefile.w32-in: Update dependencies.
10640 (LISP_H): Add inttypes.h and stdin.h.
10641 (PROCESS_H): Add unistd.h.
10642
c51453d9
EZ
106432011-05-06 Eli Zaretskii <eliz@gnu.org>
10644
10645 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10646 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10647
8ff0ac3c 106482011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10649
4c4b566b
PE
10650 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10651
aab2b9b5
PE
10652 * term.c (vfatal): Remove stray call to va_end.
10653 It's not needed and the C Standard doesn't allow it here anyway.
10654
c378da0b
PE
10655 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10656 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10657
288b08c7
PE
10658 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10659 bytes.
10660
e3601888
PE
10661 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10662
db6c0e74
PE
10663 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10664
dd5963ea
PE
10665 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10666
88c9450f
PE
10667 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10668
2f9442b8
PE
10669 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10670
c032b5f8
PE
10671 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10672 * charset.c (Fdefine_charset_internal): Don't initialize
10673 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10674 32-bit int (Bug#8600).
a108c10b
PE
10675
10676 * lread.c (read_integer): Be more consistent with string-to-number.
10677 Use string_to_number to do the actual conversion; this avoids
10678 rounding errors and fixes some other screwups. Without this fix,
10679 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10680 (digit_to_number): Move earlier, for benefit of read_integer.
10681 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10682 not a digit in any supported base. (Bug#8602)
a108c10b 10683
ad5f9eea
PE
10684 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10685
aec1708a
PE
10686 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10687 to match comment at start of function. This also removes a
10688 GCC warning about overflow in a 32+64-bit port.
10689
47be4ab5
PE
10690 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10691
371cac43
PE
10692 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10693 Reported by Stefan Monnier in
10694 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10695 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10696 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10697
d01a7826
PE
10698 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10699 (EMACS_UINTPTR): Likewise, with uintptr_t.
10700
7fd47d5c
PE
10701 * lisp.h: Prefer 64-bit EMACS_INT if available.
10702 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10703 on 32-bit hosts that have 64-bit int, so that they can access
10704 large files.
122b0c86
PE
10705 However, temporarily disable this change unless the temporary
10706 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10707
8727937b
PE
10708 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10709
8ac068ac
PE
10710 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10711 This removes an assumption that EMACS_INT and long are the same
10712 width as pointers. The assumption is true for Emacs porting targets
10713 now, but we want to make other targets possible.
10714 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10715 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10716 In the rest of the code, change types of integers that hold casted
10717 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10718 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10719 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10720 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10721 No need to cast type when ORing.
10722 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10723 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10724 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10725 assume EMACS_INT is the same width as char *.
10726 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10727 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10728 Remove no-longer-needed casts.
10729 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10730 (xg_tool_bar_help_callback, xg_make_tool_item):
10731 Use EMACS_INTPTR to hold an integer
10732 that will be cast to void *; this can avoid a GCC warning
10733 if EMACS_INT is not the same width as void *.
10734 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10735 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10736 (current_message_1, set_message_1):
10737 Use a local to convert to proper width without a cast.
10738 * xmenu.c (dialog_selection_callback): Likewise.
10739
ede49d71
PE
10740 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10741 Also, don't assume VALBITS / RAND_BITS is less than 5,
10742 and don't rely on undefined behavior when shifting a 1 left into
10743 the sign bit.
10744 * lisp.h (get_random): Change signature to match.
10745
2f30ecd0
PE
10746 * lread.c (hash_string): Use size_t, not int, for hash computation.
10747 Normally we prefer signed values; but hashing is special, because
10748 it's better to use unsigned division on hash table sizes so that
10749 the remainder is nonnegative. Also, size_t is the natural width
10750 for hashing into memory. The previous code used 'int', which doesn't
10751 retain enough info to hash well into very large tables.
10752 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10753
2a866e7b
PE
10754 * dbusbind.c: Don't possibly lose pointer info when converting.
10755 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10756 Use XPNTR rather than XHASH, so that the high-order bits of
10757 the pointer aren't lost when converting through void *.
10758
51639eac
PE
10759 * eval.c (Fautoload): Don't double-shift a pointer.
10760
92394119
PE
10761 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10762
dbdb9a7c
JB
107632011-05-06 Juanma Barranquero <lekktu@gmail.com>
10764
10765 * gnutls.c (DEF_GNUTLS_FN):
10766 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10767
db7a0b4f
AS
107682011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10769
10770 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10771 marker. (Bug#8610)
10772
cd394be1 107732011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10774
10775 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10776 New version that can reserve upto 2GB of heap space.
10777
f7ff1b0f 107782011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10779
10780 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10781
639c109b
TZ
107822011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10783
10784 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10785 `gnutls_certificate_set_x509_key_file'.
10786
d2127135
JB
107872011-05-05 Juanma Barranquero <lekktu@gmail.com>
10788
10789 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10790 Update dependencies.
10791
e968f4f3
JB
107922011-05-04 Juanma Barranquero <lekktu@gmail.com>
10793
10794 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10795 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10796 Remove unused parameter `fildes'.
10797 * process.c (read_process_output, send_process): Don't pass it.
10798
84d358f0
JB
107992011-05-04 Juanma Barranquero <lekktu@gmail.com>
10800
10801 Fix previous change: the library cache is defined in w32.c.
10802 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10803 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10804
0898ca10
JB
108052011-05-04 Juanma Barranquero <lekktu@gmail.com>
10806
10807 Implement dynamic loading of GnuTLS on Windows.
10808
10809 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10810 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10811 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10812 Declare.
10813
10814 * gnutls.c (Qgnutls_dll): Define.
10815 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10816 (gnutls_*): Declare function pointers.
10817 (init_gnutls_functions): New function to initialize function pointers.
10818 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10819 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10820 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10821 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10822 (emacs_gnutls_write, emacs_gnutls_read)
10823 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10824 (Fgnutls_available_p): New function.
10825 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10826 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10827 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10828
10829 * image.c: Include w32.h.
10830 (Vimage_type_cache): Delete.
10831 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10832 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10833 (w32_delayed_load): Move to w32.c.
10834
10835 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10836
10837 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10838 (w32_delayed_load): Move from image.c. When loading a library, record
10839 its filename in the :loaded-from property of the library id.
10840 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10841 Initialize and staticpro them.
10842 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10843
10844 * process.c: Include lisp.h before w32.h, not after.
10845 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10846 instead of gnutls_record_check_pending.
10847
10848 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10849
ff4de4aa
TZ
108502011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10851
10852 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10853 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10854 as passed in.
10855
abe95abb
JD
108562011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10857
10858 * xterm.c (x_set_frame_alpha): Do not set property on anything
10859 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10860
e16e55d4
JB
108612011-05-02 Juanma Barranquero <lekktu@gmail.com>
10862
10863 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10864
bafcf6a5
JB
108652011-05-02 Juanma Barranquero <lekktu@gmail.com>
10866
10867 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10868 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10869 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10870 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10871 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10872 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10873 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10874 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10875 (Qgnutls_bootprop_callbacks_verify): Make static.
10876
e7a6747f
AS
108772011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10878
19ed11ba
AS
10879 * callproc.c: Indentation fixup.
10880
e7a6747f 10881 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10882 (wait_for_termination, interruptible_wait_for_termination):
10883 Move after wait_for_termination_1.
e7a6747f 10884
1ef14cb4
LMI
108852011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10886
10887 * sysdep.c (interruptible_wait_for_termination): New function
10888 which is like wait_for_termination, but allows keyboard
10889 interruptions.
10890
10891 * callproc.c (Fcall_process): Add (:file "file") as an option for
10892 the STDOUT buffer.
10893 (Fcall_process_region): Ditto.
10894
330d880c
EZ
108952011-04-30 Eli Zaretskii <eliz@gnu.org>
10896
8db90b73
EZ
10897 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10898 rather than `XVECTOR (FOO)->size'.
10899
330d880c
EZ
10900 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10901 inttypes.h, as a gnulib replacement is used if it not available in
10902 system headers.
10903
15cbd324
EZ
109042011-04-21 Eli Zaretskii <eliz@gnu.org>
10905
10906 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10907 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10908 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10909
10910 * coding.c (coding_alloc_by_realloc): Error out if destination
10911 will grow beyond MOST_POSITIVE_FIXNUM.
10912 (decode_coding_emacs_mule): Abort if there isn't enough place in
10913 charbuf for the composition carryover bytes. Reserve an extra
10914 space for up to 2 characters produced in a loop.
10915 (decode_coding_iso_2022): Abort if there isn't enough place in
10916 charbuf for the composition carryover bytes.
10917
109182011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10919
ae940cca
EZ
10920 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10921 aborting when %lld or %lll format is passed.
10922 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10923 %llo or %llx format is passed. (Bug#8545)
10924
03ab8921
EZ
10925 * window.c (window_scroll_line_based): Use a marker instead of
10926 simple variables to record original value of point. (Bug#7952)
10927
afda1437
EZ
10928 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10929 produced by %s or %c overflows available buffer space. (Bug#8545)
10930
f76dee0c
PE
109312011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10932
10933 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10934 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10935
fdc5744d
JB
109362011-04-28 Juanma Barranquero <lekktu@gmail.com>
10937
10938 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10939
638f053a
JB
109402011-04-28 Juanma Barranquero <lekktu@gmail.com>
10941
10942 * keyboard.c (Qdelayed_warnings_hook): Define.
10943 (command_loop_1): Run `delayed-warnings-hook'
10944 if Vdelayed_warnings_list is non-nil.
10945 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10946 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10947
d178f871
EZ
109482011-04-28 Eli Zaretskii <eliz@gnu.org>
10949
10950 * doprnt.c (doprnt): Don't return value smaller than the buffer
10951 size if the message was truncated. (Bug#8545).
10952
b124fd93
JB
109532011-04-28 Juanma Barranquero <lekktu@gmail.com>
10954
10955 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10956 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10957
e810457d
PE
109582011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10959
10960 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10961
ea51cceb
JB
109622011-04-27 Juanma Barranquero <lekktu@gmail.com>
10963
10964 * makefile.w32-in: Update dependencies.
10965
94dcfacf
EZ
109662011-04-27 Eli Zaretskii <eliz@gnu.org>
10967
10968 Improve `doprnt' and its usage. (Bug#8545)
10969 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10970 `format_end'. Remove support for %l as a conversion specifier.
10971 Don't use xrealloc. Improve diagnostics when the %l size modifier
10972 is used. Update the commentary.
10973
10974 * eval.c (verror): Simplify calculation of size_t.
10975
10976 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10977 messages.
10978
f61f41d7
PE
109792011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10980
10981 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10982 change.
10983
96fb4434
PE
109842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10985
10986 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10987 This makes this file independent of the recent pseudovector change.
10988
671875da 109892011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10990
69e9b5a3
PE
10991 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10992
b5f869a7 10993 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10994 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10995 Remove unused local.
c8926152 10996 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10997
841a1577 10998 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10999 GCC 4.6.0 optimizes based on type-based alias analysis.
11000 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11001 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11002 != &v->size, and therefore "v->size = 1; b->size = 2; return
11003 v->size;" must therefore return 1. This assumption is incorrect
11004 for Emacs, since it type-puns struct Lisp_Vector * with many other
11005 types. To fix this problem, this patch adds a new type struct
f904488f 11006 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11007 and pseudovectors, and helps optimizing compilers not get fooled
11008 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11009 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11010 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11011 the size member.
eab3844f
PE
11012 (XSETPVECTYPE): Rewrite in terms of new macro.
11013 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11014 This is a bit clearer, and further avoids the possibility of
11015 undesirable aliasing.
11016 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11017 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11018 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11019 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11020 (ASIZE): Now uses header.size rather than size.
11021 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11022 to avoid the hassle of writing XVECTOR (foo)->header.size.
11023 (struct vectorlike_header): New type.
eab3844f
PE
11024 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11025 object, to help avoid aliasing.
11026 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11027 (SUBRP): Likewise, since Lisp_Subr is a special case.
11028 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11029 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11030 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11031 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11032 changed to be "header.size" and "header.next".
11033 * buffer.h (struct buffer): Likewise.
11034 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11035 * frame.h (struct frame): Likewise.
11036 * process.h (struct Lisp_Process): Likewise.
11037 * termhooks.h (struct terminal): Likewise.
11038 * window.c (struct save_window_data, struct saved_window): Likewise.
11039 * window.h (struct window): Likewise.
11040 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11041 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11042 * buffer.c (init_buffer_once): Likewise.
11043 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11044 special case.
11045 * process.c (Fformat_network_address): Use local var for size,
11046 for brevity.
11047
0df1eac5
PE
11048 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11049
847ab9d1 11050 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11051 * data.c (atof): Remove decl; no longer used or needed.
11052 (digit_to_number): Move to lread.c.
11053 (Fstring_to_number): Use new string_to_number function, to be
11054 consistent with how the Lisp reader treats infinities and NaNs.
11055 Do not assume that floating-point numbers represent EMACS_INT
11056 without losing information; this is not true on most 64-bit hosts.
11057 Avoid double-rounding errors, by insisting on integers when
11058 parsing non-base-10 numbers, as the documentation specifies.
11059 * lisp.h (string_to_number): New decl, replacing ...
11060 (isfloat_string): Remove.
bc0a5c13 11061 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11062 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11063 appears to have been a coding error. Similarly, do not accept
11064 strings like +-1e0 as floating point numbers. Do not report
11065 overflow for integer overflows unless the base is not 10 which
11066 means we have no simple and reliable way to continue.
11067 Break out the floating-point parsing into a new
11068 function string_to_number, so that Fstring_to_number parses
11069 floating point numbers consistently with the Lisp reader.
04f2d78b 11070 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11071 (E_CHAR, EXP_INT): Remove, replacing with ...
11072 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11073 (string_to_number): New function, replacing isfloat_string.
11074 This function checks for valid syntax and produces the resulting
11075 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11076 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11077 so that overflow for non-base-10 numbers is reported only when
11078 there's no portable and simple way to convert to floating point.
452f4150 11079
67769ffc
PE
11080 * textprop.c (set_text_properties_1): Rewrite for clarity,
11081 and to avoid GCC warning about integer overflow.
11082
c20db43f
PE
11083 * intervals.h (struct interval): Use EMACS_INT for members
11084 where EMACS_UINT might cause problems. See
11085 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11086 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11087 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11088 All uses changed.
37aa2f85
PE
11089 (offset_intervals): Tell GCC not to worry about length overflow
11090 when negating a negative length.
c20db43f 11091
2538aa2f
PE
11092 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11093 (overrun_check_free): Likewise.
11094
f2d3008d
PE
11095 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11096 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11097 word size.
11098
ec8df744
PE
11099 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11100 (gnutls_make_error): Rename local to avoid shadowing.
11101 (gnutls_emacs_global_deinit): ifdef out; not used.
11102 (Fgnutls_boot): Use const for pointer to readonly storage.
11103 Comment out unused local. Fix pointer signedness problems.
11104
640ee02d
PE
11105 * lread.c (openp): Don't stuff size_t into an 'int'.
11106 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11107 about possible signed overflow.
11108
6048fb2a
PE
11109 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11110 (GDK_KEY_g): Don't define if already defined.
11111 (xg_prepare_tooltip): Avoid pointer signedness problem.
11112 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11113
fa3c87e1
PE
11114 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11115 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11116
2172544b
PE
11117 * xfns.c (Fx_window_property): Simplify a bit,
11118 to make a bit faster and to avoid GCC 4.6.0 warning.
11119 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11120
9b821a21
PE
11121 * fns.c (internal_equal): Don't assume size_t fits in int.
11122
3c616cfa
PE
11123 * alloc.c (compact_small_strings): Tighten assertion a little.
11124
c2982e87
PE
11125 Replace pEd with more-general pI, and fix some printf arg casts.
11126 * lisp.h (pI): New macro, generalizing old pEd macro to other
11127 conversion specifiers. For example, use "...%"pI"d..." rather
11128 than "...%"pEd"...".
11129 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11130 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11131 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11132 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11133 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11134 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11135 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11136 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11137 64-bit hosts.
11138 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11139 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11140 * print.c (safe_debug_print, print_object): Likewise.
11141 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11142 to int.
6f04d126
PE
11143 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11144 avoiding the 0 flag, which is not portable.
c2982e87
PE
11145 * process.c (Fmake_network_process): Use pI to avoid cast.
11146 * region-cache.c (pp_cache): Likewise.
11147 * xdisp.c (decode_mode_spec): Likewise.
11148 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11149 behavior on 64-bit hosts with printf arg.
6f04d126 11150 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11151 (x_stop_queuing_selection_requests): Likewise.
11152 (x_get_window_property): Don't truncate byte count to an 'int'
11153 when tracing.
0b432f21 11154
5e073ec7
PE
11155 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11156 here, since it parses constructs like leading '-' and spaces,
11157 which are not wanted; and it overflows with large numbers.
11158 Instead, simply match F[0-9]+, which is what is wanted anyway.
11159
36372bf9
PE
11160 * alloc.c: Remove unportable assumptions about struct layout.
11161 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11162 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11163 (allocate_vectorlike, make_pure_vector): Use the new macros,
11164 plus offsetof, to remove unportable assumptions about struct layout.
11165 These assumptions hold on all porting targets that I know of, but
11166 they are not guaranteed, they're easy to remove, and removing them
11167 makes further changes easier.
11168
0b432f21
PE
11169 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11170 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11171 (string_overrun_cookie): Now const. Use initializers that
11172 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11173 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11174 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11175 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11176 multiple of sizeof (EMACS_INT); it need not be, if
11177 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11178 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11179
895009e1
JB
111802011-04-26 Juanma Barranquero <lekktu@gmail.com>
11181
11182 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11183
6a7a1b0b
TZ
111842011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11185
11186 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11187 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11188 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11189
841a1577 111902011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11191
11192 * lisp.h (Qdebug): List symbol.
895009e1 11193 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11194 * keyboard.c (debug-on-event): New variable.
11195 (handle_user_signal): Break into debugger when debug-on-event
11196 matches the current signal symbol.
11197
f2d3ba6f
DN
111982011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11199
11200 * alloc.c (check_sblock, check_string_bytes)
11201 (check_string_free_list): Convert to standard C.
11202
42ce4c63
TZ
112032011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11204
11205 * w32.c (emacs_gnutls_push): Fix typo.
11206
825cd63c
EZ
112072011-04-25 Eli Zaretskii <eliz@gnu.org>
11208
fb11d64d
EZ
11209 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11210 "cast to pointer from integer of different size".
11211
825cd63c
EZ
11212 Improve doprnt and its use in verror. (Bug#8545)
11213 * doprnt.c (doprnt): Document the set of format control sequences
11214 supported by the function. Use SAFE_ALLOCA instead of always
11215 using `alloca'.
11216
11217 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11218 is one byte too soon. Don't use xrealloc; instead xfree and
11219 xmalloc anew.
11220
e061a11b
TZ
112212011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11222
11223 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11224 callbacks stage.
11225
11226 * gnutls.c: Renamed global_initialized to
11227 gnutls_global_initialized. Added internals for the
11228 :verify-hostname-error, :verify-error, and :verify-flags
11229 parameters of `gnutls-boot' and documented those parameters in the
11230 docstring. Start callback support.
9173deec
JB
11231 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11232 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11233 on error. Return error code.
e061a11b
TZ
11234 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11235 (emacs_gnutls_read): Likewise.
11236 (Fgnutls_boot): Return handshake error code.
11237 (emacs_gnutls_handle_error): New function.
11238 (wsaerror_to_errno): Likewise.
11239
11240 * w32.h (emacs_gnutls_pull): Add prototype.
11241 (emacs_gnutls_push): Likewise.
11242
11243 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11244 (emacs_gnutls_push): Likewise.
11245
112462011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11247
11248 * process.c (wait_reading_process_output): Check if GnuTLS
11249 buffered some data internally if no FDs are set for TLS
11250 connections.
11251
11252 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11253 (LIBS): Link to USER_LIBS.
11254 ($(BLD)/gnutls.$(0)): New target.
11255
fa6996bc
EZ
112562011-04-24 Eli Zaretskii <eliz@gnu.org>
11257
eb35682e
EZ
11258 * xdisp.c (handle_single_display_spec): Rename the
11259 display_replaced_before_p argument into display_replaced_p, to
11260 make it consistent with the commentary. Fix typos in the
11261 commentary.
11262
e2ad650c
EZ
11263 * textprop.c (syms_of_textprop): Remove dead code.
11264 (copy_text_properties): Delete obsolete commentary about an
11265 interface that was deleted long ago. Fix typos in the description
11266 of arguments.
11267
1b2de274
EZ
11268 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11269 to changes in oldXMenu/XMenu.h from 2011-04-16.
11270 <menu_help_message, prev_menu_help_message>: Constify.
11271 (IT_menu_make_room): menu->help_text is now `const char **';
11272 adjust.
11273
11274 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11275 to changes in oldXMenu/XMenu.h from 2011-04-16.
11276 (struct XMenu): Declare `help_text' `const char **'.
11277
11278 * xfaces.c <Qunspecified>: Make extern again.
11279
11280 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11281 required by POSIX.
1b2de274 11282
762b15be
EZ
11283 * doc.c (get_doc_string): Improve the format passed to `error'.
11284
11285 * doprnt.c (doprnt): Improve commentary.
11286
11287 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11288
11289 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11290 them with etags.
11291
f1052e5d
EZ
11292 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11293 changes in globals.h immediately force recompilation.
762b15be
EZ
11294 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11295 $(CURDIR)/s/ms-w32.h.
11296 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11297
fa6996bc
EZ
11298 * character.c (Fchar_direction): Function deleted.
11299 (syms_of_character): Don't defsubr it.
11300 <char-direction-table>: Deleted.
11301
e6c3da20
EZ
113022011-04-23 Eli Zaretskii <eliz@gnu.org>
11303
11304 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11305 * doprnt.c: Include limits.h.
11306 (SIZE_MAX): New macro.
04f2d78b
CB
11307 (doprnt): Return a size_t value. 2nd arg is now size_t.
11308 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11309 Improve overflow protection. Support `l' modifier for integer
11310 conversions. Support %l conversion. Don't assume an EMACS_INT
11311 argument for integer conversions and for %c.
11312
11313 * lisp.h (doprnt): Restore prototype.
11314
11315 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11316 $(SRC)/character.h.
11317
11318 * Makefile.in (base_obj): Add back doprnt.o.
11319
11320 * deps.mk (doprnt.o): Add back prerequisites.
11321 (callint.o): Depend on character.h.
11322
11323 * eval.c (internal_lisp_condition_case): Include the handler
11324 representation in the error message.
11325 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11326 when breaking from the loop.
11327
11328 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11329
11330 * callint.c (Fcall_interactively): When displaying error message
11331 about invalid control letter, pass the character's codepoint, not
11332 a pointer to its multibyte form. Improve display of the character
11333 in octal and display also its hex code.
11334
11335 * character.c (char_string): Use %x to display the (unsigned)
11336 codepoint of an invalid character, to avoid displaying a bogus
11337 negative value.
11338
11339 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11340 `error', not SYMBOL_NAME itself.
11341
11342 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11343 character arguments to `error'.
11344
11345 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11346 to `error' in error message about FINAL_CHAR argument. Make sure
11347 FINAL_CHAR is a character, and use %c when it is passed as
11348 argument to `error'.
11349
4ffd0d6b 113502011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11351
11352 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11353
11354 * w32.c: Include <time.h>.
11355 (sys_localtime): New function.
11356
4ffd0d6b 113572011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11358
11359 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11360
4ffd0d6b 11361 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11362
4ffd0d6b 113632011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11364
4ffd0d6b
GM
11365 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11366 zombies (Bug#8467).
aac0c6e3 11367
04c56954
EZ
113682011-04-19 Eli Zaretskii <eliz@gnu.org>
11369
11370 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11371 gl_state.e_property when gl_state.object is Qt.
11372
11373 * insdel.c (make_gap_larger): Remove limitation of buffer size
11374 to <= INT_MAX.
11375
16a43933
CY
113762011-04-18 Chong Yidong <cyd@stupidchicken.com>
11377
11378 * xdisp.c (lookup_glyphless_char_display)
11379 (produce_glyphless_glyph): Handle cons cell entry in
11380 glyphless-char-display.
11381 (Vglyphless_char_display): Document it.
11382
11383 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11384 glyphless-char-display.
11385
4581706e
CY
113862011-04-17 Chong Yidong <cyd@stupidchicken.com>
11387
11388 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11389
11390 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11391
11392 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11393 definition for no-X builds.
11394
4887c6e2 113952011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11396
fd35b6f9
PE
11397 Static checks with GCC 4.6.0 and non-default toolkits.
11398
5c1ccb01
PE
11399 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11400
006c5daa
PE
11401 * process.c (keyboard_bit_set): Define only if SIGIO.
11402 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11403 (send_process): Repair possible setjmp clobbering.
11404
efc736d3
PE
11405 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11406
4e2fe2e6
PE
11407 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11408
f97334a2
PE
11409 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11410
4e75f29d
PE
11411 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11412 Define only if needed.
11413
90efadd1
PE
11414 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11415 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11416 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11417
3c647824
PE
11418 * dispextern.h (struct redisplay_interface): Rename param
11419 to avoid shadowing.
e264f262 11420 * termhooks.h (struct terminal): Likewise.
761383f4 11421 * xterm.c (xembed_send_message): Likewise.
3c647824 11422
b58c5c4a
PE
11423 * insdel.c (make_gap_smaller): Define only if
11424 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11425
cad59032
PE
11426 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11427 it.
11428
c339dc2e
PE
11429 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11430 so that we aren't warned about unused symbols.
11431
91a3e27b
PE
11432 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11433
399c71d3 11434 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11435
8ffc96f5
PE
11436 * xfns.c (x_real_positions): Mark locals as initialized.
11437
eef9bc79
PE
11438 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11439
098db9dd
PE
11440 * xterm.c: Fix problems found by static analysis with other toolkits.
11441 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11442 (x_dispatch_event): Declare static if USE_GTK, and
11443 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11444 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11445 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11446 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11447 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11448
eb18f6cc
PE
11449 * xmenu.c (menu_help_callback): Pointer type fixes.
11450 Use const pointers when pointing at readonly data. Avoid pointer
11451 signedness clashes.
11452 (FALSE): Remove unused macro.
11453 (update_frame_menubar): Remove unused decl.
11454
1fe72bf8
PE
11455 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11456
60d9e1db
PE
11457 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11458 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11459 (single_menu_item): Rename local to avoid shadowing.
11460
39261c26
PE
11461 * keyboard.c (make_lispy_event): Remove unused local var.
11462
018c5e19
PE
11463 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11464 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11465
63d2b86e
PE
11466 * bitmaps: Change bitmaps from unsigned char back to the X11
11467 compatible char. Avoid the old compiler warnings about
11468 out-of-range initializers by using, for example, '\xab' rather
11469 than 0xab.
11470
aefd87e1
PE
11471 * xgselect.c (xgselect_initialize): Check vs interface
11472 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11473
bf501fb9
PE
11474 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11475
e9829fdf
PE
11476 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11477 to read-only memory.
11478
1086c095
PE
11479 * fns.c (vector): Remove; this old hack is no longer needed.
11480
2baccd04 11481 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11482 Remove unused var.
dde42981 11483 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11484
72391843 11485 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11486
436c16df 11487 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11488 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11489 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11490
92bb796d 11491 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11492 (x_term_init): Remove local to avoid shadowing.
92bb796d 11493
764430a3 11494 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11495
11496 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11497 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11498
d1dfb56c
EZ
114992011-04-16 Eli Zaretskii <eliz@gnu.org>
11500
c4354cb4
EZ
11501 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11502
d1dfb56c
EZ
11503 Fix regex.c, syntax.c and friends for buffers > 2GB.
11504 * syntax.h (struct gl_state_s): Declare character position members
11505 EMACS_INT.
11506
11507 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11508
04f2d78b
CB
11509 * textprop.c (verify_interval_modification, interval_of):
11510 Declare arguments EMACS_INT.
d1dfb56c
EZ
11511
11512 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11513 EMACS_INT.
11514
11515 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11516
11517 * indent.c (Fvertical_motion): Local variable it_start is now
11518 EMACS_INT.
11519
11520 * regex.c (re_match, re_match_2, re_match_2_internal)
11521 (bcmp_translate, regcomp, regexec, print_double_string)
11522 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11523 (re_compile_pattern, re_exec): Declare arguments and local
11524 variables `size_t' and `ssize_t' and return values `regoff_t', as
11525 appropriate.
11526 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11527 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11528 <compile_stack_type>: `size' and `avail' are now `size_t'.
11529
11530 * regex.h <regoff_t>: Use ssize_t, not int.
11531 (re_search, re_search_2, re_match, re_match_2): Arguments that
11532 specify buffer/string position and length are now ssize_t and
11533 size_t. Return type is regoff_t.
11534
613052cd
BK
115352011-04-16 Ben Key <bkey76@gmail.com>
11536
11537 * nsfont.m: Fixed bugs in ns_get_family and
11538 ns_descriptor_to_entity that were caused by using free to
11539 deallocate memory blocks that were allocated by xmalloc (via
11540 xstrdup). This caused Emacs to crash when compiled with
11541 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11542 --enable-checking=xmallocoverrun). xfree is now used to
11543 deallocate these memory blocks.
11544
4170f62f 115452011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11546
71b41406
PE
11547 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11548
9587a89d
PE
11549 emacs_write: Accept and return EMACS_INT for sizes.
11550 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11551 et seq.
11552 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11553 Accept and return EMACS_INT.
11554 (emacs_gnutls_write): Return the number of bytes written on
11555 partial writes.
11556 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11557 (emacs_read, emacs_write): Remove check for negative size, as the
11558 Emacs source code has been audited now.
9587a89d
PE
11559 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11560 (emacs_read, emacs_write): Use it.
273a5f82
PE
11561 * process.c (send_process): Adjust to the new signatures of
11562 emacs_write and emacs_gnutls_write. Do not attempt to store
11563 a byte offset into an 'int'; it might overflow.
9587a89d 11564 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11565
3e047f51
PE
11566 * sound.c: Don't assume sizes fit in 'int'.
11567 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11568 Return EMACS_INT, not int.
3e047f51 11569 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11570 Accept EMACS_INT, not int.
11571 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11572 record read return values.
11573
cc39a9db
BK
115742011-04-15 Ben Key <bkey76@gmail.com>
11575
c9d0ec6d
JB
11576 * keyboard.c (Qundefined): Don't declare static since it is used
11577 in nsfns.m.
11578 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11579 static since they are used in nsfont.m.
cc39a9db 11580
6c60eb9f
SM
115812011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11582
11583 * process.c (Qprocessp): Don't declare static.
11584 * lisp.h (Qprocessp): Declare again.
11585
7990b61a
JB
115862011-04-15 Juanma Barranquero <lekktu@gmail.com>
11587
11588 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11589
5d4cb038
PE
115902011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11591
8bd7b830 11592 Improve C-level modularity by making more things 'static'.
cd64ea1d 11593
e3b27b31
PE
11594 Don't publish debugger-only interfaces to other modules.
11595 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11596 (verify_bytepos, count_markers): Move decls to the only modules
11597 that need them.
11598 * region-cache.h (pp_cache): Likewise.
11599 * window.h (check_all_windows): Likewise.
11600 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11601
5d4cb038
PE
11602 * sysdep.c (croak): Now static, if
11603 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11604 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11605
11606 * alloc.c (refill_memory_reserve): Now static if
11607 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11608 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11609
e87b6180
PE
11610 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11611 Define only if USE_LUCID.
11612
ac64929e
PE
11613 * xrdb.c (x_customization_string, x_rm_string): Now static.
11614
6f37259d
PE
11615 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11616 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11617
1683e3ab
PE
11618 * xdisp.c (draw_row_with_mouse_face): Now static.
11619 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11620
de9c2632
PE
11621 * window.h (check_all_windows): Mark externally visible.
11622
2b96acb7
PE
11623 * window.c (window_deletion_count): Now static.
11624
11625 * undo.c: Make symbols static if they're not exported.
11626 (last_undo_buffer, last_boundary_position, pending_boundary):
11627 Now static.
11628
50436f33
PE
11629 * textprop.c (interval_insert_behind_hooks): Now static.
11630 (interval_insert_in_front_hooks): Likewise.
11631
64520e5c
PE
11632 * term.c: Make symbols static if they're not exported.
11633 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11634 (max_frame_lines, tty_set_terminal_modes):
11635 (tty_reset_terminal_modes, tty_turn_off_highlight):
11636 (get_tty_terminal): Now static.
11637 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11638 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11639 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11640 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11641 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11642
1fa53021
PE
11643 * sysdep.c: Make symbols static if they're not exported.
11644 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11645 Now static.
11646 (sigprocmask_set, full_mask): Remove; unused.
11647 (wait_debugging): Mark as visible.
11648 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11649 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11650
d4b43b22
PE
11651 * syntax.c (syntax_temp): Define only if !__GNUC__.
11652
b7c513d0
PE
11653 * sound.c (current_sound_device, current_sound): Now static.
11654
989b29ad
PE
11655 * search.c (searchbufs, searchbuf_head): Now static.
11656
13a55a78
PE
11657 * scroll.c (scroll_cost): Remove; unused.
11658 * dispextern.h (scroll_cost): Remove decl.
11659
de68a1fc
PE
11660 * region-cache.h (pp_cache): Mark as externally visible.
11661
40ccffa6
PE
11662 * process.c: Make symbols static if they're not exported.
11663 (process_tick, update_tick, create_process, chan_process):
11664 (Vprocess_alist, proc_buffered_char, datagram_access):
11665 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11666 (deactivate_process): Mark defn as static, as well as decl.
11667 * lisp.h (create_process): Remove decl.
11668 * process.h (chan_process, Vprocess_alist): Remove decls.
11669
ad64fc97
PE
11670 * print.c: Make symbols static if they're not exported.
11671 (print_depth, new_backquote_output, being_printed, print_buffer):
11672 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11673 (print_interval, print_number_index, initial_stderr_stream):
11674 Now static.
11675 * lisp.h (Fprinc): Remove decl.
11676 (debug_output_compilation_hack): Mark as externally visible.
11677
adddb265
PE
11678 * sysdep.c (croak): Move decl from here to syssignal.h.
11679 * syssignal.h (croak): Put it here, so the API can be checked when
11680 'croak' is called from dissociate_if_controlling_tty.
11681
1717ede2
PE
11682 * minibuf.c: Make symbols static if they're not exported.
11683 (minibuf_save_list, choose_minibuf_frame): Now static.
11684 * lisp.h (choose_minibuf_frame): Remove decl.
11685
fa5fb2bc
PE
11686 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11687
1e3890d1
PE
11688 * lread.c: Make symbols static if they're not exported.
11689 (read_objects, initial_obarray, oblookup_last_bucket_number):
11690 Now static.
11691 (make_symbol): Remove; unused.
11692 * lisp.h (initial_obarray, make_symbol): Remove decls.
11693
8a1414fa
PE
11694 * keyboard.c: Make symbols static if they're not exported.
11695 (single_kboard, recent_keys_index, total_keys, recent_keys):
11696 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11697 (this_single_command_key_start, echoing, last_auto_save):
11698 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11699 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11700 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11701 (Vlispy_mouse_stem, double_click_count):
11702 Now static.
11703 (force_auto_save_soon): Define only if SIGDANGER.
11704 (ignore_mouse_drag_p): Now static if
11705 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11706 (print_help): Remove; unused.
11707 (stop_character, last_timer_event): Mark as externally visible.
11708 * keyboard.h (ignore_mouse_drag_p): Declare only if
11709 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11710 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11711 * lisp.h (echoing): Remove decl.
11712 (force_auto_save_soon): Declare only if SIGDANGER.
11713 * xdisp.c (redisplay_window): Simplify code, to make it more
11714 obvious that ignore_mouse_drag_p is not accessed if !defined
11715 USE_GTK && !defined HAVE_NS.
11716
93ea6e8f
PE
11717 * intervals.c: Make symbols static if they're not exported.
11718 (merge_properties_sticky, merge_interval_right, delete_interval):
11719 Now static.
11720 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11721
77382fcc
PE
11722 * insdel.c: Make symbols static if they're not exported.
11723 However, leave prepare_to_modify_buffer alone. It's never
11724 called from outside this function, but that appears to be a bug.
11725 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11726 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11727 (adjust_after_replace_noundo): Remove; unused.
11728 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11729 (signal_before_change): Remove decls.
77382fcc 11730
9306c32e
PE
11731 * indent.c (val_compute_motion, val_vmotion): Now static.
11732
cd44d2eb
PE
11733 * image.c: Make symbols static if they're not exported.
11734 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11735 if USE_GTK.
11736 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11737 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11738
ad9a7a06
PE
11739 * fringe.c (standard_bitmaps): Now static.
11740 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11741
81626931
PE
11742 * frame.c: Make symbols static if they're not exported.
11743 (x_report_frame_params, make_terminal_frame): Now static.
11744 (get_frame_param): Now static, unless HAVE_NS.
11745 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11746 (x_get_resource_string): Remove; not used.
11747 * frame.h (make_terminal_frame, x_report_frame_params):
11748 (x_get_resource_string); Remove decls.
11749 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11750 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11751
239f9db9
PE
11752 * font.c, fontset.c: Make symbols static if they're not exported.
11753 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11754 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11755 * font.c (font_close_object): Now static.
11756 * font.h (font_close_object): Remove.
11757 * fontset.c (FONTSET_OBJLIST): Remove.
11758 (free_realized_fontset) #if-0 the body, which does nothing.
11759 (face_suitable_for_char_p): #if-0, as it's never called.
11760 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11761 * xfaces.c (face_at_string_position):
11762 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11763 since 0 is always ASCII.
11764
dfcf3579
PE
11765 * fns.c (weak_hash_tables): Now static.
11766
5045092b
PE
11767 * fileio.c: Make symbols static if they're not exported.
11768 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11769 (Vwrite_region_annotation_buffers): Now static.
11770
57a96f5c
PE
11771 * eval.c: Make symbols static if they're not exported.
11772 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11773 * lisp.h (backtrace_list): Remove decl.
11774
35f08c38
PE
11775 * emacs.c: Make symbols static if they're not exported.
11776 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11777 (fatal_error_code, fatal_error_signal_hook, standard_args):
11778 Now static.
11779 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11780 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11781 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11782 * lisp.h (fatal_error_signal_hook): Remove decl.
11783 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11784
f44bd759
PE
11785 * editfns.c: Move a (normally-unused) function to its only use.
11786 * editfns.c, lisp.h (get_operating_system_release): Remove.
11787 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11788 worth the hassle of breaking this out.
11789
b532497d
PE
11790 * xterm.c: Make symbols static if they're not exported.
11791 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11792 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11793 (x_destroy_window, x_delete_display):
11794 Now static.
11795 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11796 (x_mouse_leave): Remove; unused.
11797 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11798 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11799 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11800 Remove decls.
11801 (x_mouse_leave): Declare only if WINDOWSNT.
11802 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11803 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11804 USE_X_TOOLKIT.
11805
1675728f
PE
11806 * ftxfont.c: Make symbols static if they're not exported.
11807 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11808 HAVE_FREETYPE.
11809 * font.h (ftxfont_driver): Likewise.
11810
e4cebfca
PE
11811 * xfns.c: Make symbols static if they're not exported.
11812 (x_last_font_name, x_display_info_for_name):
11813 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11814 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11815 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11816 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11817 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11818 (last_show_tip_args): Now static.
11819 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11820 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11821 (x_screen_planes): Remove; unused.
11822 * dispextern.h (x_screen_planes): Remove decl.
11823
5bf46f05
PE
11824 * dispnew.c: Make symbols static if they're not exported.
11825 * dispextern.h (redraw_garbaged_frames, scrolling):
11826 (increment_row_positions): Remove.
11827 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11828 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11829 Now static.
11830 (redraw_garbaged_frames): Remove; unused.
11831
435f4c28
PE
11832 * xfaces.c: Make symbols static if they're not exported.
11833 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11834 Remove decls.
11835 * xterm.h (defined_color): Remove decls.
11836 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11837 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11838 (menu_face_changed_default, defined_color, free_realized_face):
11839 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11840 (ascii_face_of_lisp_face): Remove; unused.
11841
8524aef3
PE
11842 * xdisp.c: Make symbols static if they're not exported.
11843 * dispextern.h (scratch_glyph_row, window_box_edges):
11844 (glyph_to_pixel_coords, set_cursor_from_row):
11845 (get_next_display_element, set_iterator_to_next):
11846 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11847 (show_mouse_face): Remove decls
11848 * frame.h (message_buf_print): Likewise.
11849 * lisp.h (pop_message, set_message, check_point_in_composition):
11850 Likewise.
11851 * xterm.h (set_vertical_scroll_bar): Likewise.
11852 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11853 (message_buf_print, scratch_glyph_row, displayed_buffer):
11854 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11855 (get_next_display_element, show_mouse_face, window_box_edges):
11856 (frame_to_window_pixel_xy, check_point_in_composition):
11857 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11858 (glyph_to_pixel_coords): Remove; unused.
11859
16390cd2
PE
11860 * dired.c (file_name_completion): Now static.
11861
11862 * dbusbind.c (xd_in_read_queued_messages): Now static.
11863
a25f4dfa
PE
11864 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11865 * data.c (circular_list_error): Remove.
11866
14a9c8df
PE
11867 * commands.h (last_point_position, last_point_position_buffer):
11868 (last_point_position_window): Remove decls.
11869 * keyboard.c: Make these variables static.
11870
04f2d78b
CB
11871 * coding.h (coding, code_convert_region, encode_coding_gap):
11872 Remove decls.
74ab6df5
PE
11873 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11874 (iso_code_class, detect_coding, code_convert_region): Now static.
11875 (encode_coding_gap): Remove; unused.
11876
38dfbee1
PE
11877 * chartab.c (chartab_chars, chartab_bits): Now static.
11878
a2cb4e63
PE
11879 * charset.h (charset_iso_8859_1): Remove decl.
11880 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11881 Now static.
11882
127198fd
PE
11883 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11884 * ccl.c (Vccl_program_table): Now static.
11885 (check_ccl_update): Remove; unused.
11886
d85b608f
PE
11887 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11888 * category.h: ... from here.
11889 * category.c (check_category_table, set_category_set): Now static.
11890
31cd66f3
PE
11891 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11892 * lisp.h: Remove these decls.
11893
c358e587
PE
11894 * buffer.c (buffer_count): Remove unused var.
11895
e78aecca
PE
11896 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11897 so that it's not optimized away.
11898 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11899 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11900 exported only to the debugger.
11901
e192d7d3 11902 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11903 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11904
92470028
PE
11905 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11906 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11907 was inaccessible from Lisp.
11908 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11909 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11910
244ed907
PE
11911 alloc.c: Import and export fewer symbols, and remove unused items.
11912 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11913 is defined.
11914 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11915 it's not optimized away by whole-program optimization.
11916 (message_enable_multibyte, free_misc): Remove.
11917 (catchlist, handlerlist, mark_backtrace):
11918 Declare only if BYTE_MARK_STACK.
11919 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11920 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11921 (message_enable_multibyte): Remove decl.
11922 (free_misc, interval_free_list, float_block, float_block_index):
11923 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11924 (cons_free_list, last_marked_index):
11925 Now static.
11926 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11927 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11928 (mark_backtrace): Define only if BYTE_MARK_STACK.
11929 * xdisp.c (message_enable_multibyte): Now static.
11930
61c2b50e 11931 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11932 This makes it easier for human readers (and static analyzers)
11933 to see whether these variables are used from other modules.
11934 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11935 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11936 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11937 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11938 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11939 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11940 * xmenu.c, xselect.c:
11941 Declare Q* vars static if they are not used in other modules.
11942 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11943 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11944 Remove decls of unexported vars.
11945 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11946
95c82688
PE
11947 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11948
16a97296
PE
11949 Make Emacs functions such as Fatom 'static' by default.
11950 This makes it easier for human readers (and static analyzers)
11951 to see whether these functions can be called from other modules.
11952 DEFUN now defines a static function. To make the function external
11953 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11954 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11955 (Finit_image_library):
16a97296
PE
11956 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11957 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11958 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11959 Remove decls, since these functions are now static.
11960 (Funintern, Fget_internal_run_time): New decls, since these functions
11961 were already external.
95c82688 11962
16a97296
PE
11963 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11964 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11965 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11966 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11967 * keyboard.c, keymap.c, lread.c:
11968 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11969 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11970 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11971 Mark functions with DEFUE instead of DEFUN,
11972 if they are used in other modules.
11973 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11974 decls for now-static functions.
11975 * buffer.h (Fdelete_overlay): Remove decl.
11976 * callproc.c (Fgetenv_internal): Mark as internal.
11977 * composite.c (Fremove_list_of_text_properties): Remove decl.
11978 (Fcomposition_get_gstring): New forward static decl.
11979 * composite.h (Fcomposite_get_gstring): Remove decl.
11980 * dired.c (Ffile_attributes): New forward static decl.
11981 * doc.c (Fdocumntation_property): New forward static decl.
11982 * eval.c (Ffetch_bytecode): New forward static decl.
11983 (Funintern): Remove extern decl; now in .h file where it belongs.
11984 * fileio.c (Fmake_symbolic_link): New forward static decl.
11985 * image.c (Finit_image_library): New forward static decl.
11986 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11987 * intervals.h (Fprevious_property_change):
11988 (Fremove_list_of_text_properties): Remove decls.
11989 * keyboard.c (Fthis_command_keys): Remove decl.
11990 (Fcommand_execute): New forward static decl.
11991 * keymap.c (Flookup_key): New forward static decl.
11992 (Fcopy_keymap): Now static.
11993 * keymap.h (Flookup_key): Remove decl.
11994 * process.c (Fget_process): New forward static decl.
11995 (Fprocess_datagram_address): Mark as internal.
11996 * syntax.c (Fsyntax_table_p): New forward static decl.
11997 (skip_chars): Remove duplicate decl.
11998 * textprop.c (Fprevious_property_change): New forward static decl.
11999 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12000 Now internal.
12001 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12002 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12003
785bbd42
PE
12004 * editfns.c (Fformat): Remove unreachable code.
12005
8b913b57
AS
120062011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12007
12008 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12009 change. (Bug#8496)
12010
a6744a35
EZ
120112011-04-13 Eli Zaretskii <eliz@gnu.org>
12012
12013 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12014 when at ZV. (Bug#8487)
12015
e7974947
AS
120162011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12017
baad03f0
AS
12018 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12019 (Bug#8437)
12020 * keyboard.c (parse_tool_bar_item): Likewise.
12021 * sound.c (sound_cleanup, alsa_close): Likewise.
12022 * termcap.c (tgetent): Likewise.
12023 * xfns.c (x_default_font_parameter): Likewise.
12024 * xsettings.c (read_and_apply_settings): Likewise.
12025
e7974947
AS
12026 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12027 (overrun_check_free): Protoize.
12028
28272684
PE
120292011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12030
12031 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12032 since callers should never pass a negative size.
12033 Change the signature to match that of plain 'read' and 'write'; see
12034 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12035 * lisp.h: Update prototypes of emacs_write and emacs_read.
12036
11997c76
EZ
120372011-04-11 Eli Zaretskii <eliz@gnu.org>
12038
12039 * xdisp.c (redisplay_window): Don't try to determine the character
12040 position of the scroll margin if the window start point w->startp
e896f03c 12041 is outside the buffer's accessible region. (Bug#8468)
11997c76 12042
8a2cbd72
EZ
120432011-04-10 Eli Zaretskii <eliz@gnu.org>
12044
12045 Fix write-region and its subroutines for buffers > 2GB.
12046 * fileio.c (a_write, e_write): Modify declaration of arguments and
12047 local variables to support buffers larger than 2GB.
12048 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12049
12050 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12051 argument, local variables, and return value.
12052
12053 * lisp.h: Update prototypes of emacs_write and emacs_read.
12054
12055 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12056
4073e537 120572011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12058
1ebfdcb6
PE
12059 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12060
b2ded58d
PE
12061 Fix more problems found by GCC 4.6.0's static checks.
12062
7d66342c
PE
12063 * xdisp.c (vmessage): Use a better test for character truncation.
12064
bbf47d44
PE
12065 * charset.c (load_charset_map): <, not <=, for optimization,
12066 and to avoid potential problems with integer overflow.
9248994d 12067 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12068 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12069 * editfns.c (Fformat): Likewise.
1e69125e 12070 * syntax.c (skip_chars): Likewise.
3befa583 12071
e3019616
PE
12072 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12073 This also lets GCC 4.6.0 generate slightly better loop code.
12074
becfa255
PE
12075 * callint.c (Fcall_interactively): <, not <=, for optimization.
12076 (Fcall_interactively): Count the number of arguments produced,
12077 not the number of arguments given. This is simpler and lets GCC
12078 4.6.0 generate slightly better code.
12079
dae0cd48
PE
12080 * ftfont.c: Distingish more carefully between FcChar8 and char.
12081 The previous code passed unsigned char * to a functions like
12082 strlen and xstrcasecmp that expect char *, which does not
12083 conform to the C standard.
12084 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12085 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12086 char * when the C standard requires it.
12087
76032d70
PE
12088 * keyboard.c (read_char): Remove unused var.
12089
eb3f1cc8
PE
12090 * eval.c: Port to Windows vsnprintf (Bug#8435).
12091 Include <limits.h>.
12092 (SIZE_MAX): Define if the headers do not.
12093 (verror): Do not give up if vsnprintf returns a negative count.
12094 Instead, grow the buffer. This ports to Windows vsnprintf, which
12095 does not conform to C99. Problem reported by Eli Zaretskii.
12096 Also, simplify the allocation scheme, by avoiding the need for
12097 calling realloc, and removing the ALLOCATED variable.
12098
70476b54
PE
12099 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12100
12020a9e
PE
12101 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12102 But keep the doprint source code for now, as we might revamp it
12103 and use it again (Bug#8435).
ea6c7ae6
PE
12104 * lisp.h (doprnt): Remove.
12105 * Makefile.in (base_obj): Remove doprnt.o.
12106 * deps.mk (doprnt.o): Remove.
12107
5fdb398c
PE
12108 error: Print 32- and 64-bit integers portably (Bug#8435).
12109 Without this change, on typical 64-bit hosts error ("...%d...", N)
12110 was used to print both 32- and 64-bit integers N, which relied on
12111 undefined behavior.
61bdb816 12112 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12113 * lisp.h (error, verror): Mark as printf-like functions.
12114 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12115 Report overflow in size calculations when allocating printf buffer.
12116 Do not truncate output string at its first null byte.
12117 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12118 Truncate the output at a character boundary, since vsnprintf does not
12119 do that.
12120 * charset.c (check_iso_charset_parameter): Convert internal
12121 character to string before calling 'error', since %c now has the
12122 printf meaning.
12123 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12124 overflow when computing char to be passed to 'error'. Do not
12125 pass Lisp_Object to 'error'; pass the integer instead.
12126 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12127 formatted with plain %d.
12128
b189fa66
PE
12129 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12130
bff87ef0
PE
12131 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12132
7e2cac20
PE
12133 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12134
ce4d90b5
PE
12135 * xterm.c (x_catch_errors): Remove duplicate declaration.
12136
266c9547
PE
12137 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12138
79c49ad2
PE
12139 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12140
368f4090
JM
121412011-04-10 Jim Meyering <meyering@redhat.com>
12142
12143 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12144 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12145 return ssize_t not "int", and use size_t as the buffer length.
12146 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12147 * gnutls.h: Update declarations.
12148 * process.c (read_process_output): Use ssize_t, to match.
12149 (send_process): Likewise.
12150
a32d4040
CY
121512011-04-09 Chong Yidong <cyd@stupidchicken.com>
12152
12153 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12154
8546720e 121552011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12156
04f2d78b
CB
12157 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12158 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12159
8546720e
GM
12160 * xterm.c (handle_one_xevent):
12161 * xmenu.c (create_and_show_popup_menu):
12162 * xselect.c (x_decline_selection_request)
12163 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12164
0a2f5c1a 121652011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12166
12167 Fix some uses of `int' instead of EMACS_INT.
12168 * search.c (string_match_1, fast_string_match)
12169 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12170 (scan_buffer, find_next_newline_no_quit)
12171 (find_before_next_newline, search_command, Freplace_match)
12172 (Fmatch_data): Make some `int' variables be EMACS_INT.
12173
12174 * xdisp.c (display_count_lines): 3rd argument and return value now
12175 EMACS_INT. All callers changed.
12176 (pint2hrstr): Last argument is now EMACS_INT.
12177
12178 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12179 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12180 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12181 (decode_coding_utf_16, decode_coding_emacs_mule)
12182 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12183 (decode_coding_ccl, decode_coding_charset)
12184 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12185 (decode_coding_iso_2022, decode_coding_emacs_mule)
12186 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12187 <char_offset, last_offset>: Declare EMACS_INT.
12188 (encode_coding_utf_8, encode_coding_utf_16)
12189 (encode_coding_emacs_mule, encode_invocation_designation)
12190 (encode_designation_at_bol, encode_coding_iso_2022)
12191 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12192 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12193 Declare EMACS_INT.
12194 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12195 (encode_invocation_designation): Last argument P_NCHARS is now
12196 EMACS_INT.
12197 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12198 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12199
12200 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12201 All users changed.
12202
12203 * ccl.c (Fccl_execute_on_string): Declare some variables
12204 EMACS_INT.
12205
8546720e 122062011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12207
12208 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12209
4e19a977
CS
122102011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12211
12212 * process.c (Fformat_network_address): Doc fix.
12213
87302331
R
122142011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12215
ee7683eb 12216 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12217
cbb59342
CY
122182011-04-08 Chong Yidong <cyd@stupidchicken.com>
12219
12220 * keyboard.c (read_char): Call Lisp function help-form-show,
12221 instead of using internal_with_output_to_temp_buffer.
12222 (Qhelp_form_show): New var.
e0d38eeb 12223 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12224
12225 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12226
12227 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12228
e67a13ab
CY
122292011-04-06 Chong Yidong <cyd@stupidchicken.com>
12230
04f2d78b
CB
12231 * process.c (Flist_processes): Remove to Lisp.
12232 (list_processes_1): Delete.
e67a13ab 12233
973f782d
EZ
122342011-04-06 Eli Zaretskii <eliz@gnu.org>
12235
7c106b1e
EZ
12236 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12237
973f782d
EZ
12238 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12239
41cf7d1a 122402011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12241
ca23cc88
PE
12242 Fix more problems found by GCC 4.6.0's static checks.
12243
f390e2d5
PE
12244 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12245
42eea0d0
PE
12246 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12247
b69769da 12248 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12249
f9541e84
PE
12250 * xdisp.c (vmessage): Mark as a printf-like function.
12251
13841b55
PE
12252 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12253
c136c10f
PE
12254 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12255
5e2d4a30
PE
12256 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12257 printf-like functions.
12258 (tiff_load): Add casts to remove these marks before passing them
12259 to system-supplied API.
12260
583f48b9
PE
12261 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12262
b25d760e
PE
12263 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12264 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12265 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12266 directly, rather than having caller test rule sign. This avoids
12267 some unnecessary tests.
12268 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12269 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12270 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12271
bc7b6697 12272 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12273 (xfont_open): Avoid unnecessary tests.
bc7b6697 12274
27ccc379
PE
12275 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12276
dcd5c89a
PE
12277 * composite.h, composite.c (composition_gstring_put_cache):
12278 Use EMACS_INT, not int, for length.
12279
b13a45c6
PE
12280 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12281 breaking out part of COMPOSITION_DECODE_RULE.
12282 (COMPOSITION_DECODE_RULE): Use it.
12283 * composite.c (get_composition_id): Remove unused local vars,
12284 by using the new macro.
12285
1e792e4d
PE
12286 * textprop.c (set_text_properties_1): Change while to do-while,
12287 since the condition is always true at first.
12288
dc6c6455 12289 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12290 (interval_deletion_adjustment): Return unsigned value.
12291 All uses changed.
dc6c6455 12292
aba7731a
PE
12293 * process.c (list_processes_1, create_pty, read_process_output):
12294 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12295 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12296 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12297 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12298 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12299
fdfc4bf3
PE
12300 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12301
fca8fe46 12302 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12303 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12304
06a0259a 12305 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12306 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12307 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12308
e7b9e80f
PE
12309 * print.c (print_error_message): Avoid int overflow.
12310
56201685
PE
12311 * font.c (font_list_entities): Redo for clarity,
12312 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12313
78834453 12314 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12315 (font_score): Avoid potential overflow in diff calculation.
78834453 12316
0bc0b309 12317 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12318 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12319
e610eaca
PE
12320 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12321
b895abce
PE
12322 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12323 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12324 can always succeed if overflow has undefined behavior.
12325
1f1d9321 12326 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12327 (wordify): Omit three unnecessary tests.
1f1d9321 12328
c59478bc
PE
12329 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12330 All callers changed. This avoids the need for an unused var.
12331
79b73827
PE
12332 * casefiddle.c (casify_region): Remove var that is set but not used.
12333
a4db5dfe
PE
12334 * dired.c (file_name_completion): Remove var that is set but not used.
12335
43aae36e
PE
12336 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12337
2a47c44d 12338 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12339 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12340
a37c69bf
PE
12341 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12342 Check for integer overflow on size calculations.
12343
328ab8e7
PE
12344 * buffer.c (Fprevious_overlay_change): Remove var that is set
12345 but not used.
12346
e5a2a5cb
PE
12347 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12348 Remove vars that are set but not used.
8d84a6eb 12349 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12350 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12351
a60e5f68
PE
12352 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12353
f661cb61 12354 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12355 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12356
f0397f5a
PE
12357 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12358 that are set but not used.
12359
8664db06 12360 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12361 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12362
6abdaa4a
PE
12363 * xselect.c (x_get_local_selection, x_handle_property_notify):
12364 Remove vars that are set but not used.
12365
0ce7538d 12366 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12367 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12368
9ae848fc
PE
12369 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12370 Remove var that is set but not used.
0b918413
PE
12371 (scroll_bar_windows_size): Now size_t, not int.
12372 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12373 Check for overflow.
9ae848fc 12374
a5a62657
PE
12375 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12376 (map_tty_color) [!defined MSDOS]: Likewise.
12377
5c5cdd39
PE
12378 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12379
66ebf983
PE
12380 * coding.c: Remove vars that are set but not used.
12381 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12382 All callers changed.
12383 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12384 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12385 (decode_coding_charset): Remove vars that are set but not used.
12386
1be4d761
PE
12387 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12388 that is set but not used.
12389
47553fa8
PE
12390 * print.c (print_object): Remove var that is set but not used.
12391
1f7196bf 12392 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12393 The gnulib version avoids calling malloc in the usual case,
12394 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12395 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12396 * filelock.c (current_lock_owner): Likewise.
12397 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12398 * sysdep.c: Include allocator.h, careadlinkat.h.
12399 (emacs_no_realloc_allocator): New static constant.
12400 (emacs_readlink): New function.
fdb61804
PE
12401 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12402 ../lib/careadlinkat.h.
d1fdcab7 12403
f84c17c7
SM
124042011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12405
12406 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12407 first non-nil return value).
12408
ef3862ad
JD
124092011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12410
12411 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12412 if not defined (Bug#8403).
12413
376a7006
JB
124142011-04-02 Juanma Barranquero <lekktu@gmail.com>
12415
12416 * xdisp.c (display_count_lines): Remove parameter `start',
12417 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12418 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12419 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12420 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12421 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12422 and thereabouts. All callers changed.
12423 (get_per_char_metric): Remove parameter `f', unused since
12424 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12425
6ca3801d
JM
124262011-04-02 Jim Meyering <meyering@redhat.com>
12427
12428 do not dereference NULL upon failed strdup
12429 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12430 (ns_get_family): Likewise.
12431
d8e2b5ba
JB
124322011-04-02 Juanma Barranquero <lekktu@gmail.com>
12433
12434 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12435
8c74fcbd
JD
124362011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12437
12438 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12439 later (Bug#8403).
12440
7200d79c
SM
124412011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12442
03408648 12443 Add lexical binding.
7200d79c 12444
03408648
SM
12445 * window.c (Ftemp_output_buffer_show): New fun.
12446 (Fsave_window_excursion):
12447 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12448
12449 * lread.c (lisp_file_lexically_bound_p): New function.
12450 (Fload): Bind Qlexical_binding.
12451 (readevalloop): Remove `evalfun' arg.
12452 Bind Qinternal_interpreter_environment.
12453 (Feval_buffer): Bind Qlexical_binding.
12454 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12455 Mark as dynamic.
12456 (syms_of_lread): Declare `lexical-binding'.
12457
12458 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12459
12460 * keyboard.c (eval_dyn): New fun.
12461 (menu_item_eval_property): Use it.
ca105506
SM
12462
12463 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12464
03408648
SM
12465 * fns.c (concat, mapcar1): Accept byte-code-functions.
12466
12467 * eval.c (Fsetq): Handle lexical vars.
12468 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12469 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12470 (FletX, Flet): Obey lexical binding.
12471 (Fcommandp): Handle closures.
12472 (Feval): New `lexical' arg.
12473 (eval_sub): New function extracted from Feval. Use it almost
12474 everywhere where Feval was used. Look up vars in lexical env.
12475 Handle closures.
12476 (Ffunctionp): Move from subr.el.
12477 (Ffuncall): Handle closures.
12478 (apply_lambda): Remove `eval_flags'.
12479 (funcall_lambda): Handle closures and new byte-code-functions.
12480 (Fspecial_variable_p): New function.
12481 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12482 but without exporting it to Lisp.
23aba0ea 12483
23aba0ea 12484 * doc.c (Fdocumentation, store_function_docstring):
03408648 12485 * data.c (Finteractive_form): Handle closures.
23aba0ea 12486
03408648
SM
12487 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12488 interactive spec.
ba83908c 12489
04f2d78b
CB
12490 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12491 New byte-codes.
03408648
SM
12492 (exec_byte_code): New function extracted from Fbyte_code to handle new
12493 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12494
03408648 12495 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12496
03408648 12497 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12498
e2abce01
JB
124992011-03-31 Juanma Barranquero <lekktu@gmail.com>
12500
12501 * xdisp.c (redisplay_internal): Fix prototype.
12502
63696a73 125032011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12504
63696a73 12505 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12506 (try_scrolling): Use it when setting scroll_limit.
12507 Limit scrolling to 100 screen lines.
63696a73
EZ
12508 (redisplay_window): Even when falling back on "recentering",
12509 position point in the window according to scroll-conservatively,
12510 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12511
12512 (try_scrolling): When point is above the window, allow searching
12513 as far as scroll_max, or one screenful, to compute vertical
12514 distance from PT to the scroll margin position. This prevents
12515 try_scrolling from unnecessarily failing when
12516 scroll-conservatively is set to a value slightly larger than the
12517 window height. Clean up the case of PT below the margin at bottom
12518 of window: scroll_max can no longer be INT_MAX. When aggressive
12519 scrolling is in use, don't let point enter the opposite scroll
12520 margin as result of the scroll.
12521 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12522 threshold of 100 lines for never-recentering scrolling.
12523
e4cc2dfc
JB
125242011-03-31 Juanma Barranquero <lekktu@gmail.com>
12525
12526 * dispextern.h (move_it_by_lines):
12527 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12528 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12529 (message_log_check_duplicate): Remove parameters `prev_bol' and
12530 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12531 (redisplay_internal): Remove parameter `preserve_echo_area',
12532 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12533
12534 * indent.c (Fvertical_motion):
12535 * window.c (window_scroll_pixel_based, Frecenter):
12536 Don't pass `need_y_p' to `move_it_by_lines'.
12537
1c470562
SM
125382011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12539
44f230aa
SM
12540 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12541 steal a few bits to be more compact.
12542 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12543 Remove unneeded casts.
12544
1c470562
SM
12545 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12546
888adce9
ZK
125472011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12548
12549 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12550 binding" message (bug#7967).
12551
f838ed7b
PE
125522011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12553
77861b95
PE
12554 Fix more problems found by GCC 4.6.0's static checks.
12555
de6dbc14
PE
12556 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12557 Remove unused local var.
12558
f838ed7b
PE
12559 * editfns.c (Fmessage_box): Remove unused local var.
12560
792c7b2b
PE
12561 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12562 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12563 Omit unused local vars.
c499e557 12564 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12565 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12566 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12567 Omit unused local var.
12568
ba0165e1
PE
12569 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12570 Don't assume string length fits in int.
32ad8845 12571 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12572 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12573
3c59b4c9
PE
12574 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12575 instead of alloca (Bug#8344).
12576
a3eed478 12577 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12578 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12579
eb4d412d
PE
12580 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12581
1658b401
PE
12582 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12583 concerns.
12584
12585 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12586
12587 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12588
9a2c6e05
PE
12589 * keyboard.c (syms_of_keyboard): Use the same style as later
12590 in this function when indexing through an array. This also
12591 works around GCC bug 48267.
12592
03d0a109
PE
12593 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12594
44f730c8
PE
12595 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12596
fe75f926
PE
12597 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12598 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12599
ffa8c828
PE
12600 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12601 This avoids undefined behavior on integer overflow, and is a bit
12602 more convenient anyway since it is compared to a size_t variable.
12603
c5101a77
PE
12604 Variadic C functions now count arguments with size_t, not int.
12605 This avoids an unnecessary limitation on 64-bit machines, which
12606 caused (substring ...) to crash on large vectors (Bug#8344).
12607 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12608 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12609 All variadic functions and their callers changed accordingly.
c5101a77
PE
12610 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12611 * data.c (arith_driver, float_arith_driver): Likewise.
12612 * editfns.c (general_insert_function): Likewise.
12613 * eval.c (struct backtrace.nargs, interactive_p)
12614 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12615 (funcall_lambda, mark_backtrace): Likewise.
12616 * fns.c (concat): Likewise.
12617 * frame.c (x_set_frame_parameters): Likewise.
12618 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12619 0 if not found, not -1. All callers changed.
12620
dd3f25f7
PE
12621 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12622 (stack_copy_size): Now size_t, not int.
12623 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12624
461c2ab9
JB
126252011-03-28 Juanma Barranquero <lekktu@gmail.com>
12626
12627 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12628 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12629 All callers changed.
12630
12631 * lisp.h (multibyte_char_to_unibyte):
12632 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12633 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12634 * character.h (CHAR_TO_BYTE8):
12635 * cmds.c (internal_self_insert):
12636 * editfns.c (general_insert_function):
12637 * keymap.c (push_key_description):
12638 * search.c (Freplace_match):
12639 * xdisp.c (message_dolog, set_message_1): All callers changed.
12640
f6d62986
SM
126412011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12642
12643 * keyboard.c (safe_run_hook_funcall): New function.
12644 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12645 don't set the hook to nil, but remove the offending function instead.
12646 (Qcommand_hook_internal): Remove, unused.
12647 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12648 Vcommand_hook_internal.
12649
12650 * eval.c (enum run_hooks_condition): Remove.
12651 (funcall_nil, funcall_not): New functions.
12652 (run_hook_with_args): Call each function through a `funcall' argument.
12653 Remove `cond' argument, now redundant.
12654 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12655 (Frun_hook_with_args_until_failure): Adjust accordingly.
12656 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12657
1db5b1ad
JB
126582011-03-28 Juanma Barranquero <lekktu@gmail.com>
12659
12660 * dispextern.h (string_buffer_position): Remove declaration.
12661
12662 * print.c (strout): Remove parameter `multibyte', unused since
12663 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12664
12665 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12666 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12667 All callers changed.
12668
12669 * w32.c (_wsa_errlist): Use braces for struct initializers.
12670
12671 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12672 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12673 All callers changed.
12674 (string_buffer_position): Likewise. Also, make static (it's never
12675 used outside xdisp.c).
12676 (cursor_row_p): Remove parameter `w', unused since
12677 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12678 (decode_mode_spec): Remove parameter `precision', introduced during
12679 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12680 All callers changed.
12681
5ffb62aa
JD
126822011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12683
12684 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12685
461c2ab9 126862011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12687
12688 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12689 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12690 (ns_update_auto_hide_menu_bar): New functions.
12691 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12692 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12693 ns_constrain_all_frames.
12694 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12695 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12696
5c380ffb
JD
126972011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12698
12699 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12700
9af30bdf
GM
127012011-03-27 Glenn Morris <rgm@gnu.org>
12702
12703 * syssignal.h: Replace RETSIGTYPE with void.
12704 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12705 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12706 Replace SIGTYPE with void everywhere.
12707 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12708 * s/template.h (SIGTYPE): Remove commented out definition.
12709
e2abce01
JB
127102011-03-26 Eli Zaretskii <eliz@gnu.org>
12711
12712 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12713 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12714
f868cd8a
JB
127152011-03-26 Juanma Barranquero <lekktu@gmail.com>
12716
59eb0929
JB
12717 * w32.c (read_unc_volume): Use parameter `henum', instead of
12718 global variable `wget_enum_handle'.
12719
12720 * keymap.c (describe_vector): Remove parameters `indices' and
12721 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12722 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12723
f868cd8a
JB
12724 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12725
12726 * keyboard.c (timer_check): Remove parameter `do_it_now',
12727 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12728 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12729 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12730
12731 * keyboard.c (read_char):
12732 * w32menu.c (w32_menu_display_help):
12733 * xmenu.c (show_help_event, menu_help_callback):
12734 Adjust calls to `show_help_echo'.
12735
12736 * gtkutil.c (xg_maybe_add_timer):
12737 * keyboard.c (readable_events):
12738 * process.c (wait_reading_process_output):
12739 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12740
12741 * insdel.c (adjust_markers_gap_motion):
12742 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12743 (gap_left, gap_right): Don't call it.
12744
2ecf6fdb
CY
127452011-03-25 Chong Yidong <cyd@stupidchicken.com>
12746
12747 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12748 incurred during fontification.
12749
6b1f9ba4
JB
127502011-03-25 Juanma Barranquero <lekktu@gmail.com>
12751
12752 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12753 (DEFVAR_PER_BUFFER): Don't pass it.
12754
12755 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12756 (scrolling_window): Don't pass it.
12757
0f4a96b5
JB
127582011-03-25 Juanma Barranquero <lekktu@gmail.com>
12759
12760 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12761
12762 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12763 and `suffix'.
12764 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12765 of variables specific to SELinux and computation of `encoded_absname'.
12766
12767 * image.c (XPutPixel): Remove unused variable `height'.
12768
12769 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12770
12771 * unexw32.c (get_section_info): Remove unused variable `section'.
12772
12773 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12774 (system_process_attributes): Remove unused variable `sess'.
12775 (sys_read): Remove unused variable `err'.
12776
12777 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12778 (w32_wnd_proc): Remove unused variable `isdead'.
12779 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12780 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12781 (x_create_tip_frame): Remove unused variable `tem'.
12782
12783 * w32inevt.c (w32_console_read_socket):
12784 Remove unused variable `no_events'.
12785
12786 * w32term.c (x_draw_composite_glyph_string_foreground):
12787 Remove unused variable `width'.
12788
1149507c
JB
127892011-03-24 Juanma Barranquero <lekktu@gmail.com>
12790
12791 * w32term.c (x_set_glyph_string_clipping):
12792 Don't pass uninitialized region to CombineRgn.
12793
9c88f339
JB
127942011-03-23 Juanma Barranquero <lekktu@gmail.com>
12795
12796 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12797 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12798 (Fx_close_connection): Remove unused variable `i'.
12799
12800 * w32font.c (w32font_draw): Return number of glyphs.
12801 (w32font_open_internal): Remove unused variable `i'.
12802 (w32font_driver): Add missing initializer.
12803
12804 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12805 (fill_in_menu): Remove unused variable `items_added'.
12806
12807 * w32term.c (last_mouse_press_frame): Remove static global variable.
12808 (w32_clip_to_row): Remove unused variable `f'.
12809 (x_delete_terminal): Remove unused variable `i'.
12810
12811 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12812 (NOTHING): Remove unused static global variable.
12813 (uniscribe_check_otf): Remove unused variable `table'.
12814 (uniscribe_font_driver): Add missing initializers.
12815
dee091a3
JD
128162011-03-23 Julien Danjou <julien@danjou.info>
12817
12818 * term.c (Fsuspend_tty, Fresume_tty):
12819 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12820 * window.c (temp_output_buffer_show):
12821 * insdel.c (signal_before_change):
12822 * frame.c (Fhandle_switch_frame):
12823 * fileio.c (Fdo_auto_save):
12824 * emacs.c (Fkill_emacs):
12825 * editfns.c (save_excursion_restore):
12826 * cmds.c (internal_self_insert):
12827 * callint.c (Fcall_interactively):
12828 * buffer.c (Fkill_all_local_variables):
12829 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12830 Use Frun_hooks.
0f4a96b5 12831 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12832 unconditionally since it does the check itself.
dee091a3 12833
2c520ab5 128342011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12835
c9c49752
PE
12836 Fix more problems found by GCC 4.5.2's static checks.
12837
8abc3f12
PE
12838 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12839 the first time through the loop, since we know p0 < p1 then.
12840 This also avoids a gcc -Wstrict-overflow warning.
12841
a2d26660
PE
12842 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12843 leading to a memory leak, possible in functions like
12844 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12845 of objects (Bug#8318).
a2d26660 12846
916c72e9
PE
12847 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12848 that could (at least in theory) be that large.
12849
19ab8a18
PE
12850 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12851 This is less likely to overflow, and avoids undefined behavior if
12852 overflow does occur. All callers changed. Use strtoul to scan
12853 for the unsigned long integer.
b7cbbd6f
PE
12854 (pint2hrstr): Simplify and tune code slightly.
12855 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12856
f0641eff
PE
12857 * scroll.c (do_scrolling): Work around GCC bug 48228.
12858 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12859
7f650bb9
PE
12860 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12861 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12862 (validate_x_resource_name): Simplify count usage.
12863 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12864
37dd57d1
PE
12865 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12866 fail (Bug#8306).
81e56e61 12867
699979fc 12868 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12869
401bf9b4
PE
12870 * process.c (Fmake_network_process): Use socklen_t, not int,
12871 where POSIX says socklen_t is required in portable programs.
12872 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12873 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12874 (Fmake_network_process, server_accept_connection):
12875 (wait_reading_process_output, read_process_output):
12876 Likewise.
12877
b93aacde
PE
12878 * process.c: Rename or move locals to avoid shadowing.
12879 (list_processes_1, Fmake_network_process):
12880 (read_process_output_error_handler, exec_sentinel_error_handler):
12881 Rename or move locals.
4dc343ee 12882 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12883 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12884 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12885 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12886 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12887
af8a867c 12888 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12889 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12890 Include tparam.h instead, since it declares them.
af8a867c
PE
12891 * cm.h (PC): Remove extern decl; tparam.h now does this.
12892 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12893 * terminfo.c: Include tparam.h, to check interfaces.
12894 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12895 (tparam): Adjust signature to match interface in tparam.h;
12896 this removes some undefined behavior. Check that outstring and len
12897 are zero, which they always are with Emacs.
12898 * tparam.h (PC, BC, UP): New extern decls.
12899
0248044d 12900 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12901 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12902
8ff096c1 12903 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12904 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12905 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12906 (ftfont_list): Remove unused local.
49eaafba
PE
12907 (get_adstyle_property, ftfont_pattern_entity):
12908 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12909 Rename locals to avoid shadowing.
8ff096c1 12910
e2be39f6
PE
12911 * xfont.c (xfont_list_family): Mark var as initialized.
12912
c9735e30
PE
12913 * xml.c (make_dom): Now static.
12914
8f5201ae
PE
12915 * composite.c (composition_compute_stop_pos): Rename local to
12916 avoid shadowing.
b246f932
PE
12917 (composition_reseat_it): Remove unused locals.
12918 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12919 (composition_update_it): Mark var as initialized.
11b61122
PE
12920 (find_automatic_composition): Mark vars as initialized,
12921 with a FIXME (Bug#8290).
8f5201ae 12922
760fbc2c
PE
12923 character.h: Rename locals to avoid shadowing.
12924 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12925 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12926 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12927 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12928 to avoid shadowing.
12929
ff08eb85
PE
12930 * textprop.c (property_change_between_p): Remove; unused.
12931
fc7bf025
PE
12932 * intervals.c (interval_start_pos): Now static.
12933
235d7abc
PE
12934 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12935
44f230aa
SM
12936 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12937 Rename locals to avoid shadowing.
3e7d6594 12938
50060332
PE
12939 * sound.c (wav_play, au_play, Fplay_sound_internal):
12940 Fix pointer signedness.
d01f234b 12941 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12942 (wav_play): Initialize a variable to 0, to prevent undefined
12943 behavior (Bug#8278).
50060332 12944
c4fc4e30
PE
12945 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12946
918436ed
PE
12947 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12948
c939f91b
PE
12949 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12950 clobbering (Bug#8298).
b9c7f648
PE
12951 * sysdep.c (sys_subshell): Likewise.
12952 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12953
6bd8c144
PE
12954 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12955 This should get cleaned up, so that child_setup has the
12956 same signature on all platforms.
12957
7710357c 12958 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12959 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12960
c59da222
CY
129612011-03-22 Chong Yidong <cyd@stupidchicken.com>
12962
12963 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12964 not to be necessary, and produces flickering.
12965
66b87493
GM
129662011-03-20 Glenn Morris <rgm@gnu.org>
12967
12968 * config.in: Remove file.
12969
45b6f6d5
JB
129702011-03-20 Juanma Barranquero <lekktu@gmail.com>
12971
12972 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12973 are now in src/globals.h.
12974 (syms_of_minibuf): Remove spurious & from previous change.
12975
cd394be1 129762011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12977
12978 * minibuf.c (completing-read-function): New variable.
12979 (completing-read-default): Rename from completing-read.
12980 (completing-read): Call completing-read-function.
12981
b14e3e21
CY
129822011-03-19 Juanma Barranquero <lekktu@gmail.com>
12983
12984 * xfaces.c (Fx_load_color_file):
12985 Read color file from absolute filename (bug#8250).
12986
f2b726e6
JB
129872011-03-19 Juanma Barranquero <lekktu@gmail.com>
12988
12989 * makefile.w32-in: Update dependencies.
12990
09f6ff02
EZ
129912011-03-17 Eli Zaretskii <eliz@gnu.org>
12992
12993 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12994
29a6015a
PE
129952011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12996
a3a6c54e
PE
12997 Fix more problems found by GCC 4.5.2's static checks.
12998
b766f867
PE
12999 * process.c (make_serial_process_unwind, send_process_trap):
13000 (sigchld_handler): Now static.
13001
be02381c
PE
13002 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13003 That way, the code declares only the vars that it needs.
13004 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13005 * s/cygwin.h (PTY_ITERATION): Likewise.
13006 * s/darwin.h (PTY_ITERATION): Likewise.
13007 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13008
57048744
PE
13009 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13010 * process.c (allocate_pty): Don't declare stb unless it's needed.
13011
7914961c 13012 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13013 (CONSTANTLIM): Remove; unused.
13014 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13015 Define only if needed.
7914961c 13016
b3967b18
PE
13017 * unexelf.c (unexec): Name an expression,
13018 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13019 Use a different way to cause a compilation error if anyone uses
13020 n rather than nn, a way that does not involve shadowing.
73366a00 13021 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13022
29a6015a
PE
13023 * deps.mk (unexalpha.o): Remove; unused.
13024
43cfc33e 13025 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13026 * unexec.h: New file.
ce701a33
PE
13027 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13028 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13029 Depend on unexec.h.
13030 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13031 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13032 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13033 Change as necessary to match prototype in unexec.h.
ce701a33 13034
01f44d5a
PE
13035 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13036 shadowing.
4f63c6bb 13037 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13038
a6670b0b
PE
13039 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13040 Rename locals to avoid shadowing.
13041
cef2010d 13042 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13043 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13044
d4d7173a
PE
13045 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13046
f08b802a
PE
13047 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13048 warning when compiling print.c.
13049
3ddb0639
PE
13050 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13051 instead of using an uninitialized var.
5ad03b97 13052 (font_sort_entities): Mark var as initialized.
3ddb0639 13053
170a2692
PE
13054 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13055
e663c700
PE
13056 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13057 pointers to constants.
89bc529a 13058 (font_parse_fcname): Remove unused vars.
7b81e2d0 13059 (font_delete_unmatched): Now static.
ea838e10 13060 (font_get_spec): Remove; unused.
13a547c6
PE
13061 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13062 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13063 Rename or move locals to avoid shadowing.
e663c700 13064
2a80c887 13065 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13066 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13067
1384fa33 13068 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13069 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13070
8b2c52e9
PE
13071 * alloc.c (mark_backtrace): Move decl from here ...
13072 * lisp.h: ... to here, so that it can be checked.
13073
475545b5 13074 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13075 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13076 (lisp_indirect_variable): Name an expression,
13077 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13078 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13079
b1349114 13080 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13081 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13082 Use const pointer when appropriate.
b1349114 13083
a2928364
PE
13084 * lisp.h (get_system_name, get_operating_system_release):
13085 Move decls here, to check interfaces.
13086 * process.c (get_operating_system_release): Move decl to lisp.h.
13087 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13088 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13089 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13090 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13091 (Fformat_time_string, Fencode_time, Finsert_char):
13092 (Ftranslate_region_internal, Fformat):
13093 Rename or remove local vars to avoid shadowing.
9710023e 13094 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13095
a415e694
PE
13096 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13097 avoid shadowing.
13098
8ef4622d
PE
13099 * lisp.h (eassert): Check that the argument compiles, even if
13100 ENABLE_CHECKING is not defined.
13101
946f9a5b
PE
13102 * data.c (Findirect_variable): Name an expression, to avoid
13103 gcc -Wbad-function-cast warning.
112396d6 13104 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13105 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13106 (Fmake_variable_buffer_local, Fmake_local_variable):
13107 Mark variables as initialized.
52746918 13108 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13109
e5aab7e7 13110 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13111 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13112 Rename locals to avoid shadowing.
dff45157
PE
13113 (mark_stack): Move local variables into the #ifdef region where
13114 they're used.
7bc26fdb
PE
13115 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13116 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13117 needed otherwise.
13118 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13119 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13120 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13121
e5aab7e7
PE
13122 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13123 avoids undefined behavior in theory.
13124
4da60324
PE
13125 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13126
88043301
PE
13127 Use functions, not macros, for up- and down-casing (Bug#8254).
13128 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13129 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13130 to use the following functions instead of these macros.
13131 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13132 EMACS_INT, since callers assume the returned value fits in int.
13133 (upcase1): Likewise, for UPCASE_TABLE.
13134 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13135 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13136 the race-condition problem in the old DOWNCASE.
88043301 13137
19ed5445
PE
13138 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13139 Rename locals to avoid shadowing.
13140 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13141 (regex_compile, re_search_2, re_match_2_internal):
13142 Remove unused local vars.
952db0d7
PE
13143 (FREE_VAR): Rewrite so as not to use empty "else",
13144 which gcc can warn about.
da053e48 13145 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13146 (RETALLOC_IF): Define only if needed.
13147 (WORDCHAR_P): Likewise. This one is never needed, but is used
13148 only in a comment talking about a compiler bug, so put inside
13149 the #if 0 of that comment.
13150 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13151 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13152 Remove; unused.
19ed5445 13153
1f3561e4 13154 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13155 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13156 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13157
ded6f8f7
PE
13158 * search.c (simple_search): Remove unused var.
13159
dbd37a95
PE
13160 * dired.c (compile_pattern): Move decl from here ...
13161 * lisp.h: ... to here, so that it can be checked.
13162 (struct re_registers): New forward decl.
13163
7e47afad
PE
13164 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13165
85f24f61
PE
13166 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13167 All uses changed.
13168 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13169 Rename locals to avoid shadowing.
5671df8f 13170 (Fvertical_motion): Mark locals as initialized.
85f24f61 13171
181aa2be 13172 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13173 (casify_region): Mark local as initialized.
181aa2be 13174
930d429c
PE
13175 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13176
7082eac6
PE
13177 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13178 New macros, so that the caller can use some names other than
13179 gcpro1, gcpro2, etc.
13180 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13181 of the new macros.
13182 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13183 argument, for consistency with GCPRO2_VAR, etc: it is now the
13184 prefix of the variable, not the variable itself. All uses
13185 changed.
38b2c076
PE
13186 * dired.c (directory_files_internal, file_name_completion):
13187 Rename locals to avoid shadowing.
13188
15206ed9
PE
13189 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13190 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13191 dired.c's scmp function, had undefined behavior.
13192 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13193 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13194 * buffer.h: ... to here, because these macros use current_buffer,
13195 and the new implementation with inline functions needs to have
13196 current_buffer in scope now, rather than later when the macros
13197 are used.
13198 (downcase, upcase1): New static inline functions.
13199 (DOWNCASE, UPCASE1): Reimplement using these functions.
13200 This avoids undefined behavior in expressions like
13201 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13202 from race conditions in accessing the global variables
13203 case_temp1 and case_temp2.
13204 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13205 * lisp.h (case_temp1, case_temp2): Remove their decls.
13206 * character.h (ASCII_CHAR_P): Move from here ...
13207 * lisp.h: ... to here, so that the inline functions mentioned
13208 above can use them.
13209
4a6bea26
PE
13210 * dired.c (directory_files_internal_unwind): Now static.
13211
f14b7e14
PE
13212 * fileio.c (file_name_as_directory, directory_file_name):
13213 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13214 Now static.
2893f146
PE
13215 (file_name_as_directory): Use const pointers when appropriate.
13216 (Fexpand_file_name): Likewise. In particular, newdir might
13217 point at constant storage, so make it a const pointer.
fd4ead52 13218 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13219 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13220 signedness issues.
f839df0c
PE
13221 (Fset_file_times, Finsert_file_contents, auto_save_error):
13222 Rename locals to avoid shadowing.
f14b7e14 13223
5716756e 13224 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13225 (Ftry_completion, Fall_completions): Rename or remove locals
13226 to avoid shadowing.
5716756e 13227
b4c3046a
PE
13228 * marker.c (bytepos_to_charpos): Remove; unused.
13229
b45db522
PE
13230 * lisp.h (verify_bytepos, count_markers): New decls,
13231 so that gcc does not warn that these functions aren't declared.
13232
85876d07
PE
13233 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13234 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13235 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13236 (copy_text): Remove unused local var.
85876d07 13237
03d78a21 13238 * filelock.c (within_one_second): Now static.
b3dd38ab 13239 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13240
5df8f01b
PE
13241 * buffer.c (fix_overlays_before): Mark locals as initialized.
13242 (fix_start_end_in_overlays): Likewise. This function should be
13243 simplified by using pointers-to-pointers, but that's a different
13244 matter.
b1d876f1 13245 (switch_to_buffer_1): Now static.
8f54f30a
PE
13246 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13247 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13248
a70072c9 13249 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13250 Fix pointer signedness issue.
edced198
PE
13251 (sys_subshell): Mark local as volatile if checking for lint,
13252 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13253 (MAXPATHLEN): Define only if needed.
a70072c9 13254
a0977c44
PE
13255 * process.c (serial_open, serial_configure): Move decls from here ...
13256 * systty.h: ... to here, so that they can be checked.
13257
a884fdcc
PE
13258 * fns.c (get_random, seed_random): Move extern decls from here ...
13259 * lisp.h: ... to here, so that they can be checked.
13260
604efe86 13261 * sysdep.c (reset_io): Now static.
b8950c94 13262 (wait_for_termination_signal): Remove; unused.
604efe86 13263
38fc62d9
PE
13264 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13265 (copy_keymap_item, append_key, push_text_char_description):
13266 Now static.
1004a21a 13267 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13268 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13269 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13270 (describe_map_tree):
13271 Rename locals to avoid shadowing.
38fc62d9 13272
2f2650da
PE
13273 * keyboard.c: Declare functions static if they are not used elsewhere.
13274 (echo_char, echo_dash, cmd_error, top_level_2):
13275 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13276 (read_char, kbd_buffer_get_event, make_lispy_position):
13277 (make_lispy_event, make_lispy_movement, apply_modifiers):
13278 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13279 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13280 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13281 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13282 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13283
a053e86c 13284 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13285 (mark_kboards): Move decl here ...
13286 * alloc.c (mark_kboards): ... from here.
a053e86c 13287
4752793e
PE
13288 * lisp.h (force_auto_save_soon): New decl.
13289
74f10ca7 13290 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13291 (DEFINE_DUMMY_FUNCTION): New macro.
13292 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13293 Use it.
c03cd23f
PE
13294 (main): Add casts to avoid warnings
13295 if GCC considers string literals to be constants.
74f10ca7 13296
022e70d4
PE
13297 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13298
59d6fe83
PE
13299 * dbusbind.c: Pointer signedness fixes.
13300 (xd_signature, xd_append_arg, xd_initialize):
13301 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13302 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13303 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13304 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13305
78320123
PE
13306 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13307 if GCC considers string literals to be constants.
49cebcca 13308 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13309
35ac2a97
SM
133102011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13311
fb103ca9
SM
13312 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13313 (print_preprocess, print_object): New macro to fix last change.
13314
35ac2a97
SM
13315 * print.c (print_preprocess): Don't forget font objects.
13316
62973b41
JB
133172011-03-16 Juanma Barranquero <lekktu@gmail.com>
13318
13319 * emacs.c (USAGE3): Doc fixes.
13320
0e48bb22
AS
133212011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13322
13323 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13324 structure.
13325
7684e57b
JB
133262011-03-14 Juanma Barranquero <lekktu@gmail.com>
13327
13328 * lisp.h (VWindow_system, Qfile_name_history):
13329 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13330 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13331 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13332
13333 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13334 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13335
13336 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13337 * w32console.c (detect_input_pending, read_input_pending)
13338 (encode_terminal_code):
13339 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13340 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13341 (w32_system_caret_y, Qfile_name_history):
13342 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13343 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13344 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13345 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13346 * w32proc.c (Qlocal, report_file_error):
13347 * w32term.c (Vwindow_system, updating_frame):
13348 * w32uniscribe.c (initialized, uniscribe_font_driver):
13349 Remove unneeded extern declarations.
13350
2aa46d6c
CY
133512011-03-14 Chong Yidong <cyd@stupidchicken.com>
13352
c96bbc66 13353 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13354
cffc6f3b
CY
133552011-03-13 Chong Yidong <cyd@stupidchicken.com>
13356
13357 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13358 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13359 These macros can no longer be used for assignment.
13360
44f230aa
SM
13361 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13362 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13363 (record_buffer_markers, fetch_buffer_markers): New functions for
13364 recording and fetching special buffer markers.
13365 (set_buffer_internal_1, set_buffer_temp): Use them.
13366
13367 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13368
13369 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13370
13371 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13372 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13373
13374 * xdisp.c (hscroll_window_tree):
13375 (reconsider_clip_changes): Use PT instead of BUF_PT.
13376
d251f04b
EZ
133772011-03-13 Eli Zaretskii <eliz@gnu.org>
13378
13379 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13380 $(EMACS_ROOT)/lib/intprops.h.
13381
f0c77cd1
PE
133822011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13383
3eca4629
PE
13384 Fix more problems found by GCC 4.5.2's static checks.
13385
7c86ee98
PE
13386 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13387 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13388 (xg_free_frame_widgets): Make it clear that a local variable is
13389 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13390 (gdk_window_get_screen): Make it clear that this macro is needed
13391 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13392 (int_gtk_range_get_value): New function, which avoids a diagnostic
13393 from gcc -Wbad-function-cast.
13394 (xg_set_toolkit_scroll_bar_thumb): Use it.
13395 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13396 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13397 (get_utf8_string, xg_get_file_with_chooser):
13398 Rename locals to avoid shadowing.
13399 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13400
41729b81
PE
13401 * xgselect.c (xg_select): Remove unused var.
13402
f0c77cd1
PE
13403 * image.c (four_corners_best): Mark locals as initialized.
13404 (gif_load): Initialize transparent_p to zero (Bug#8238).
13405 Mark another local as initialized.
ec6cf4c6 13406 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13407
ce0ad53d 13408 * image.c (clear_image_cache): Now static.
d5d5a617 13409 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13410 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13411 (x_edge_detection): Remove unnecessary cast that
13412 gcc -Wbad-function-cast diagnoses.
2037898d 13413 (gif_load): Fix pointer signedness.
6ae141d6
PE
13414 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13415 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13416
33383987 134172011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13418
d32df629
PE
13419 Improve quality of tests for time stamp overflow.
13420 For example, without this patch (encode-time 0 0 0 1 1
13421 1152921504606846976) returns the obviously-bogus value (-948597
13422 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13423 reports time overflow. See
13424 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13425 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13426 * editfns.c: Include limits.h and intprops.h.
13427 (TIME_T_MIN, TIME_T_MAX): New macros.
13428 (time_overflow): Move earlier, to before first use.
13429 (hi_time, lo_time): New functions, for an accurate test for
13430 out-of-range times.
13431 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13432 (Fget_internal_run_time): Don't assume time_t fits in int.
13433 (make_time): Use list2 instead of Fcons twice.
13434 (Fdecode_time): More accurate test for out-of-range times.
13435 (check_tm_member): New function.
13436 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13437 (lisp_time_argument): Don't rely on undefined left-shift and
13438 right-shift behavior when checking for time stamp overflow.
8be6f318 13439
fe31d94c
PE
13440 * editfns.c (time_overflow): New function, refactoring common code.
13441 (Fformat_time_string, Fdecode_time, Fencode_time):
13442 (Fcurrent_time_string): Use it.
13443
8be6f318
PE
13444 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13445 * dired.c (make_time): Move to ...
13446 * editfns.c (make_time): ... here.
13447 * systime.h: Note the move.
13448
09d9db2c 134492011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13450
126bc0dc
YM
13451 * fringe.c (update_window_fringes): Remove unused variables.
13452
c47cbdfd
YM
13453 * unexmacosx.c (copy_data_segment): Also copy __got section.
13454 (Bug#8223)
13455
7ac80be9
EZ
134562011-03-12 Eli Zaretskii <eliz@gnu.org>
13457
c96bbc66 13458 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13459 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13460 Constify `char *' arguments and their references according to
13461 prototypes in tparam.h.
13462
ecb0f94d 13463 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13464
7ac80be9
EZ
13465 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13466 Adapt all references accordingly.
13467
13468 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13469
ef1fd07e
TT
134702011-03-11 Tom Tromey <tromey@redhat.com>
13471
13472 * buffer.c (syms_of_buffer): Remove obsolete comment.
13473
7ef4b50c
EZ
134742011-03-11 Eli Zaretskii <eliz@gnu.org>
13475
13476 * termhooks.h (encode_terminal_code): Declare prototype.
13477
13478 * msdos.c (encode_terminal_code): Don't declare prototype.
13479
13480 * term.c (encode_terminal_code): Now external again, used by
13481 w32console.c and msdos.c.
13482
44f230aa
SM
13483 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13484 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13485
4b1ec863 134862011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13487
1714f52b 13488 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13489
4b1ec863
PE
13490 * fringe.c (update_window_fringes): Mark locals as initialized
13491 (Bug#8227).
13492 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13493
524c7aa6
PE
13494 * alloc.c (mark_fringe_data): Move decl from here ...
13495 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13496 to check its interface.
13497 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13498
a5c0af81 13499 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13500 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13501 (fontset_font): Mark local as initialized.
a9a06e0b 13502 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13503
b4716021
PE
13504 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13505
811e9bac 13506 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13507 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13508 (x_own_selection, Fx_disown_selection_internal): Rename locals
13509 to avoid shadowing.
13510 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13511
7e3ab302
PE
13512 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13513 so that the caller can use some name other than gcpro1.
13514 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13515 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13516 (Fx_backspace_delete_keys_p):
13517 Use them to avoid shadowing, and rename vars to avoid shadowing.
13518 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13519 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13520 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13521 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13522 Remove unused locals.
7e3ab302
PE
13523 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13524 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13525 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13526 macros.
f78faa98 13527
e2b13473
PE
13528 * xterm.h (x_mouse_leave): New decl.
13529
77f23912
PE
13530 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13531 Remove unused functions.
cdf4ba58
PE
13532 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13533 (x_calc_absolute_position): Now static.
7411c686 13534 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13535 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13536 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13537 unless they are used.
38d0b34a
PE
13538 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13539 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13540 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13541 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13542 (x_error_catcher, x_connection_closed, x_error_handler):
13543 (x_error_quitter, xembed_send_message, x_iconify_frame):
13544 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13545 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13546 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13547
44f230aa
SM
13548 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13549 Rename or move locals to avoid shadowing.
6b463e58 13550 (tty_defined_color, merge_face_heights): Now static.
5967d051 13551 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13552 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13553 does not deduce is never used uninitialized.
73719eba
PE
13554 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13555 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13556
426994c3 13557 * terminal.c (store_terminal_param): Now static.
5489860b 13558
032f1620 13559 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13560 (set_frame_menubar): Remove unused local.
d4323972 13561 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13562 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13563 since they might point to immutable storage.
281585b0
PE
13564 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13565 since it's unused otherwise.
032f1620 13566
367c19e5 13567 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13568 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13569 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13570 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13571 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13572 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13573 does not deduce are never used uninitialized.
70739cbe 13574
07b48fa9
PE
13575 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13576
8868a238 13577 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13578 * window.c (window_loop, size_window):
13579 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13580
7e5cf297 13581 * window.c (display_buffer): Now static.
d6550a9f
PE
13582 (size_window): Mark variables that gcc -Wuninitialized
13583 does not deduce are never used uninitialized.
a586633d
PE
13584 * window.h (check_all_windows): New decl, to forestall
13585 gcc -Wmissing-prototypes diagnostic.
5b555da1 13586 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13587
f6095868
PE
13588 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13589 shadowing.
13590 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13591 Include <limits.h>.
13592 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13593 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13594 (load_charset_map): Mark variables that gcc -Wuninitialized
13595 does not deduce are never used uninitialized.
53df7c11 13596 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13597
f38b440c
PE
13598 * coding.c (coding_set_source, coding_set_destination):
13599 Use "else { /* comment */ }" rather than "else /* comment */;"
13600 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13601 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13602 a block, when the outer 'i' will do.
13603 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13604 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13605 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13606 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13607 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13608 Rename locals to avoid shadowing.
13609 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13610 * coding.c (emacs_mule_char, encode_invocation_designation):
13611 Now static, since they're not used elsewhere.
413bb2db 13612 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13613 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13614 (decode_coding_emacs_mule): Mark variables that gcc
13615 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13616 (detect_coding_iso_2022): Initialize a local variable that might
13617 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13618 this initialization is needed. (Bug#8211)
5f58e762
PE
13619 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13620 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13621 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13622 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13623 Remove unused macros.
f38b440c 13624
232b38b9 13625 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13626 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13627 * character.c (string_count_byte8): Likewise.
232b38b9 13628
fb90da1b
PE
13629 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13630 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13631
fb93dbc2
PE
13632 * chartab.c (copy_sub_char_table): Now static, since it's not used
13633 elsewhere.
5c156ace
PE
13634 (sub_char_table_ref_and_range, char_table_ref_and_range):
13635 Rename locals to avoid shadowing.
bbcd0949 13636 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13637
7d3b3862 13638 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13639 (BIDI_BOB): Remove unused macro.
7d3b3862 13640
6be7d3da
PE
13641 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13642 deduce are never used uninitialized.
c2ed9c8b 13643 * term.c (encode_terminal_code): Likewise.
6be7d3da 13644
75f8807f 13645 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13646
50938595
PE
13647 * tparam.h: New file.
13648 * term.c, tparam.h: Include it.
13649 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13650 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13651 Move these decls to tparam.h, and make them agree with what
13652 is actually in tparam.c. The previous trick of using incompatible
13653 decls in different modules does not conform to the C standard.
13654 All callers of tparam changed to use tparam's actual API.
13655 * tparam.c (tparam1, tparam, tgoto):
13656 Use const pointers where appropriate.
13657
fbceeba2
PE
13658 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13659 * cm.h (struct cm): Likewise.
13660 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13661 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13662 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13663 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13664 (turn_on_face, init_tty): Likewise.
13665 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13666
7f3f1250
PE
13667 * term.c (term_mouse_position): Rename local to avoid shadowing.
13668
e6ca6543
PE
13669 * alloc.c (mark_ttys): Move decl from here ...
13670 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13671
c40f8d15
AS
136722011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13673
13674 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13675
cfe0661d
JB
136762011-03-09 Juanma Barranquero <lekktu@gmail.com>
13677
13678 * search.c (compile_pattern_1): Remove argument regp, unused since
13679 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13680 (compile_pattern): Don't pass it.
13681
0afb4571
J
136822011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13683
13684 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13685 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13686 for ! HAVE_GTK3.
13687 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13688
13689 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13690
13691 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13692 gdk_window_get_screen, gdk_window_get_geometry,
13693 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13694 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13695 (xg_get_pixbuf_from_pixmap): New function.
13696 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13697 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13698 Call xg_get_pixbuf_from_pixmap instead of
13699 gdk_pixbuf_get_from_drawable.
13700 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13701 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13702 (xg_check_special_colors): Use GtkStyleContext and its functions
13703 for HAVE_GTK3.
13704 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13705 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13706 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13707 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13708 Call gtk_widget_get_preferred_size.
0afb4571
J
13709 (xg_frame_resized): gdk_window_get_geometry only takes 5
13710 parameters.
44f230aa
SM
13711 (xg_win_to_widget, xg_event_is_for_menubar):
13712 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13713 (xg_set_widget_bg): New function.
13714 (delete_cb): New function.
895009e1 13715 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13716 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13717 (xg_set_background_color): Call xg_set_widget_bg.
13718 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13719 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13720 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13721 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13722 if ! HAVE_GTK3.
13723 (update_frame_tool_bar): Call gtk_widget_hide.
13724 (xg_initialize): Use GDK_KEY_g.
13725
13726 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13727 if ! HAVE_GTK3
13728 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13729
13730 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13731 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13732 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13733
1c2cc4ef
JB
137342011-03-08 Juanma Barranquero <lekktu@gmail.com>
13735
13736 * w32xfns.c (select_palette): Check success of RealizePalette against
13737 GDI_ERROR, not zero.
13738
33383987 13739See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13740
13741;; Local Variables:
13742;; coding: utf-8
aac0c6e3
MR
13743;; End:
13744
2f097256 13745 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13746
13747 This file is part of GNU Emacs.
13748
13749 GNU Emacs is free software: you can redistribute it and/or modify
13750 it under the terms of the GNU General Public License as published by
13751 the Free Software Foundation, either version 3 of the License, or
13752 (at your option) any later version.
13753
13754 GNU Emacs is distributed in the hope that it will be useful,
13755 but WITHOUT ANY WARRANTY; without even the implied warranty of
13756 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13757 GNU General Public License for more details.
13758
13759 You should have received a copy of the GNU General Public License
13760 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.