nndraft.el (nndraft-update-unread-articles): Don't show group having no unread articl...
[bpt/emacs.git] / src / ChangeLog
CommitLineData
7d47b580
JB
12011-07-04 Juanma Barranquero <lekktu@gmail.com>
2
3 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5 Also (re)move comments that are misplaced or no longer relevant.
6
1e49bfab
LMI
72011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8
9 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10
1485f4c0
CY
112011-07-03 Chong Yidong <cyd@stupidchicken.com>
12
13 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
14 and background color parameters if they have been changed.
15
a9ab721e
LMI
162011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
17
18 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
19
cf7cff57
PE
202011-07-03 Paul Eggert <eggert@cs.ucla.edu>
21
2e13213d
PE
22 * xsettings.c (SYSTEM_FONT): Define only when used.
23 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
24
cf7cff57
PE
25 * keymap.c (access_keymap_1): Now static.
26
7a8e04f7
CY
272011-07-02 Chong Yidong <cyd@stupidchicken.com>
28
29 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
30 leave any prefix arg for the up event (Bug#1586).
31
61352f62
LMI
322011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
33
69bb1ef7
LMI
34 * lread.c (syms_of_lread): Mention single symbols defined by
35 `defvar' or `defconst' (bug#7154).
36
61352f62 37 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 38 (Frequire): Mention get-load-suffixes.
61352f62 39
28545e04
MR
402011-07-02 Martin Rudalics <rudalics@gmx.at>
41
42 * window.h (window): Remove clone_number slot.
43 * window.c (Fwindow_clone_number, Fset_window_clone_number):
44 Remove.
45 (make_parent_window, make_window, saved_window)
46 (Fset_window_configuration, save_window_save): Don't deal with
47 clone numbers.
48 * buffer.c (Qclone_number): Remove declaration.
49 (sort_overlays, overlay_strings): Don't deal with clone numbers.
50
3349e122
SM
512011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
52
53 Add multiple inheritance to keymaps.
54 * keymap.c (Fmake_composed_keymap): New function.
55 (Fset_keymap_parent): Simplify.
56 (fix_submap_inheritance): Remove.
57 (access_keymap_1): New function extracted from access_keymap to handle
58 embedded parents and handle lists of maps.
59 (access_keymap): Use it.
60 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
61 (Fcopy_keymap): Handle embedded parents.
62 (Fcommand_remapping, define_as_prefix): Simplify.
63 (Fkey_binding): Simplify.
64 (syms_of_keymap): Move minibuffer-local-completion-map,
65 minibuffer-local-filename-completion-map,
66 minibuffer-local-must-match-map, and
67 minibuffer-local-filename-must-match-map to Elisp.
68 (syms_of_keymap): Defsubr make-composed-keymap.
69 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
70 (parse_menu_item): Trivial simplification.
71
3279eb87
GM
722011-07-01 Glenn Morris <rgm@gnu.org>
73
74 * Makefile.in (SETTINGS_LIBS): Fix typo.
75
4550efdf
KI
762011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
77
78 * coding.c (Fencode_coding_string): Record the last coding system
79 used, as the function doc string says (bug#8738).
80
0949d2b6
JD
812011-07-01 Jan Djärv <jan.h.d@swipnet.se>
82
83 * xsettings.c (store_monospaced_changed): Take new font as arg and
84 check for change against current_mono_font.
85 (EMACS_TYPE_SETTINGS): Remove this and related defines.
86 (emacs_settings_constructor, emacs_settings_get_property)
87 (emacs_settings_set_property, emacs_settings_class_init)
88 (emacs_settings_init, gsettings_obj): Remove.
89 (something_changedCB): New function for HAVE_GSETTINGS.
90 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
91 with value as argument.
92 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
93 g_settings_new (Bug#8967). Do not create gsettings_obj.
94 Remove calls to g_settings_bind. Connect something_changedCB to
95 "changed".
96
97 * xgselect.c: Add defined (HAVE_GSETTINGS).
98 (xgselect_initialize): Ditto.
99
100 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
101 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
102 xg_select.
103
bbc6b304
PE
1042011-07-01 Paul Eggert <eggert@cs.ucla.edu>
105
106 * eval.c (struct backtrace): Simplify and port the data structure.
107 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
108 signed bit field, as this assumption is not portable and it makes
109 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
110 "char debug_on_exit : 1" as this is not portable either; instead,
111 use the portable "unsigned int debug_on_exit : 1". Remove unused
112 member evalargs. Remove obsolete comments about cc bombing out.
113
9851bfc5
JD
1142011-06-30 Jan Djärv <jan.h.d@swipnet.se>
115
51bb811f 116 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
117 Let HAVE_GSETTINGS override HAVE_GCONF.
118 (store_monospaced_changed): New function.
119 (EMACS_SETTINGS): A new type derived from GObject to handle
120 GSettings notifications.
121 (emacs_settings_constructor, emacs_settings_get_property)
122 (emacs_settings_set_property, emacs_settings_class_init):
123 New functions.
124 (gsettings_client, gsettings_obj): New variables.
125 (GSETTINGS_SCHEMA): New define.
126 (something_changedCB): Call store_monospaced_changed.
127 (init_gsettings): New function.
128 (xsettings_initialize): Call init_gsettings.
129 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
130 to NULL.
131
132 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
133 GCONF_CFLAGS/LIBS.
134
5386012d
MR
1352011-06-29 Martin Rudalics <rudalics@gmx.at>
136
137 * window.c (resize_root_window, grow_mini_window)
138 (shrink_mini_window): Rename Qresize_root_window to
139 Qwindow_resize_root_window and Qresize_root_window_vertically to
140 Qwindow_resize_root_window_vertically.
141
f13e0b08
PE
1422011-06-28 Paul Eggert <eggert@cs.ucla.edu>
143
144 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
145
94515237
JB
1462011-06-27 Juanma Barranquero <lekktu@gmail.com>
147
148 * makefile.w32-in: Redesign dependencies so they reflect more
149 clearly which files are directly included by each source file,
150 and not through other includes.
151
e43b6e43
MR
1522011-06-27 Martin Rudalics <rudalics@gmx.at>
153
154 * buffer.c (Qclone_number): Declare static and DEFSYM it.
155 (sort_overlays, overlay_strings): When an overlay's clone number
156 matches the window's clone number process the overlay even if
157 the overlay's window property doesn't match the current window.
158
d68443dc
MR
159 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
160 (Fwindow_hchild): Rename to Fwindow_left_child.
161 (Fwindow_next): Rename to Fwindow_next_sibling.
162 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
163 (resize_window_check): Rename to window_resize_check.
164 (resize_window_apply): Rename to window_resize_apply.
165 (Fresize_window_apply): Rename to Fwindow_resize_apply.
166 (Fdelete_other_windows_internal, resize_frame_windows)
167 (Fsplit_window_internal, Fdelete_window_internal)
168 (grow_mini_window, shrink_mini_window)
169 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 170
c7e73be5
JD
1712011-06-26 Jan Djärv <jan.h.d@swipnet.se>
172
173 * emacsgtkfixed.h: State that this is only used with Gtk+3.
174 (emacs_fixed_set_min_size): Remove.
175 (emacs_fixed_new): Take frame as argument.
176
177 * emacsgtkfixed.c: State that this is only used with Gtk+3.
178 (_EmacsFixedPrivate): Remove minwidth/height.
179 Add struct frame *f.
180 (emacs_fixed_init): Initialize priv->f.
181 (get_parent_class, emacs_fixed_set_min_size): Remove.
182 (emacs_fixed_new): Set priv->f to argument.
183 (emacs_fixed_get_preferred_width)
184 (emacs_fixed_get_preferred_height): Use min_width/height from
185 frames size_hint to set minimum and natural (Bug#8919).
186 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
187 and use min_width/height from frames size_hint to set
188 min_width/height (Bug#8919).
189
190 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
191 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size. Fix
192 indentation.
193
cf99dcf8
EZ
1942011-06-26 Eli Zaretskii <eliz@gnu.org>
195
196 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
197 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
198 called at ZV.
199
029529ac
CY
2002011-06-26 Chong Yidong <cyd@stupidchicken.com>
201
202 * process.c (wait_reading_process_output): Bypass select if
203 waiting for a cell while ignoring keyboard input, and input is
204 pending. Suggested by Jan Djärv (Bug#8869).
205
7a7ef429
PE
2062011-06-25 Paul Eggert <eggert@cs.ucla.edu>
207
208 Use gnulib's dup2 module instead of rolling our own.
209 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
210
11fdef7d 2112011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
212
213 * dispnew.c (scrolling_window): Before scrolling, turn off a
214 mouse-highlight in the window being scrolled.
215
cd3520a4
JB
2162011-06-24 Juanma Barranquero <lekktu@gmail.com>
217
218 Move DEFSYM to lisp.h and use everywhere.
219
220 * character.h (DEFSYM): Move declaration...
221 * lisp.h (DEFSYM): ...here.
222
223 * gnutls.c:
224 * minibuf.c:
225 * w32menu.c:
226 * w32proc.c:
227 * w32select.c: Don't include character.h.
228
229 * alloc.c (syms_of_alloc):
230 * buffer.c (syms_of_buffer):
231 * bytecode.c (syms_of_bytecode):
232 * callint.c (syms_of_callint):
233 * casefiddle.c (syms_of_casefiddle):
234 * casetab.c (init_casetab_once):
235 * category.c (init_category_once, syms_of_category):
236 * ccl.c (syms_of_ccl):
237 * cmds.c (syms_of_cmds):
238 * composite.c (syms_of_composite):
239 * dbusbind.c (syms_of_dbusbind):
240 * dired.c (syms_of_dired):
241 * dispnew.c (syms_of_display):
242 * doc.c (syms_of_doc):
243 * editfns.c (syms_of_editfns):
244 * emacs.c (syms_of_emacs):
245 * eval.c (syms_of_eval):
246 * fileio.c (syms_of_fileio):
247 * fns.c (syms_of_fns):
248 * frame.c (syms_of_frame):
249 * fringe.c (syms_of_fringe):
250 * insdel.c (syms_of_insdel):
251 * keymap.c (syms_of_keymap):
252 * lread.c (init_obarray, syms_of_lread):
253 * macros.c (syms_of_macros):
254 * msdos.c (syms_of_msdos):
255 * print.c (syms_of_print):
256 * process.c (syms_of_process):
257 * search.c (syms_of_search):
258 * sound.c (syms_of_sound):
259 * syntax.c (init_syntax_once, syms_of_syntax):
260 * terminal.c (syms_of_terminal):
261 * textprop.c (syms_of_textprop):
262 * undo.c (syms_of_undo):
263 * w32.c (globals_of_w32):
264 * window.c (syms_of_window):
265 * xdisp.c (syms_of_xdisp):
266 * xfaces.c (syms_of_xfaces):
267 * xfns.c (syms_of_xfns):
268 * xmenu.c (syms_of_xmenu):
269 * xsettings.c (syms_of_xsettings):
270 * xterm.c (syms_of_xterm): Use DEFSYM.
271
4228cf16
TZ
2722011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
273
cd3520a4 274 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 275
7fcccf1e
PE
2762011-06-23 Paul Eggert <eggert@cs.ucla.edu>
277
7efb4e0e
PE
278 Integer and buffer overflow fixes (Bug#8873).
279
ff5844ad
PE
280 * print.c (printchar, strout): Check for string overflow.
281 (PRINTPREPARE, printchar, strout):
282 Don't set size unless allocation succeeds.
283
90532f02
PE
284 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
285 for sizes. Check for string overflow more accurately.
286 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
287
6d84508d
PE
288 * macros.c: Integer and buffer overflow fixes.
289 * keyboard.h (struct keyboard.kbd_macro_bufsize):
290 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
291 Use ptrdiff_t, not int, for sizes.
292 Don't increment bufsize until after realloc succeeds.
293 Check for size-calculation overflow.
294 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
295
437b2cb4
PE
296 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
297
8b9ac8b4
PE
298 * lread.c: Integer overflow fixes.
299 (read_integer): Radix is now EMACS_INT, not int,
300 to improve quality of diagnostics for out-of-range radices.
301 Calculate buffer size correctly for out-of-range radices.
302 (read1): Check for integer overflow in radices, and in
303 read-circle numbers.
82cb60d3
PE
304 (read_escape): Avoid int overflow.
305 (Fload, openp, read_buffer_size, read1)
306 (substitute_object_recurse, read_vector, read_list, map_obarray):
307 Use ptrdiff_t, not int, for sizes.
308 (read1): Use EMACS_INT, not int, for sizes.
20270765 309 Check for size overflow.
8b9ac8b4 310
7fcccf1e
PE
311 * image.c (cache_image): Check for size arithmetic overflow.
312
bfbbd7e7
PE
313 * lread.c: Integer overflow issues.
314 (saved_doc_string_size, saved_doc_string_length)
315 (prev_saved_doc_string_size, prev_saved_doc_string_length):
316 Now ptrdiff_t, not int.
317 (read1): Don't assume doc string length fits in int. Check for
318 out-of-range doc string lengths.
319 (read_list): Don't assume file position fits in int.
39019e54 320 (read_escape): Check for hex character overflow.
bfbbd7e7 321
4e323265
LL
3222011-06-22 Leo Liu <sdl.web@gmail.com>
323
324 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
325 Move to minibuffer.el.
326
85fece3e
PE
3272011-06-22 Paul Eggert <eggert@cs.ucla.edu>
328
20b84ce9 329 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
330 The following patches are for when GLYPH_DEBUG && !XASSERT.
331 * dispextern.h (trace_redisplay_p, dump_glyph_string):
332 * dispnew.c (flush_stdout):
333 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
334 Mark as externally visible.
335 * dispnew.c (check_window_matrix_pointers): Now static.
336 * dispnew.c (window_to_frame_vpos):
337 * xfns.c (unwind_create_frame):
338 * xterm.c (x_check_font): Remove unused local.
339 * scroll.c (CHECK_BOUNDS):
340 * xfaces.c (cache_fache): Rename local to avoid shadowing.
341 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
342 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
343 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
344 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
345 Now static.
346 (debug_method_add): Use va_list and vsprintf rather than relying
347 on undefined behavior with wrong number of arguments.
348 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
349 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
350 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
351 since we're not interested in debugging glyphs with old libraries.
352 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
353 GCC 4.6.0's static checking.
354
0766b489
PE
3552011-06-22 Paul Eggert <eggert@cs.ucla.edu>
356
31fd4b32
PE
357 Integer overflow and signedness fixes (Bug#8873).
358 A few related buffer overrun fixes, too.
359
b79e8648
PE
360 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
361
0766b489
PE
362 * dispextern.h (struct face.stipple):
363 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
364 (x_bitmap_mask, x_allocate_bitmap_record)
365 (x_create_bitmap_from_data, x_create_bitmap_from_file)
366 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
367 (x_create_bitmap_from_xpm_data):
368 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
369 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
370 (.bitmaps_last):
371 * xfaces.c (load_pixmap):
372 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
373 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
374 (.bitmaps_last, struct x_output.icon_bitmap):
375 Use ptrdiff_t, not int, for bitmap indexes.
376 (x_allocate_bitmap_record): Check for size overflow.
377 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
378
b081724f
PE
379 Use ptrdiff_t, not int, for overlay counts.
380 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
381 * editfns.c (overlays_around, get_pos_property):
382 * textprop.c (get_char_property_and_overlay):
383 * xdisp.c (next_overlay_change, note_mouse_highlight):
384 * xfaces.c (face_at_buffer_position):
21514da7
PE
385 * buffer.c (OVERLAY_COUNT_MAX): New macro.
386 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
387 (Fnext_overlay_change, Fprevious_overlay_change)
388 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 389 Use ptrdiff_t, not int, for sizes.
21514da7 390 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 391
3de73e5e
PE
392 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
393
2606c57b
PE
394 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
395 (x_session_initialize): Do not assume string length fits in int.
396
aaafe47a
PE
397 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
398 This is unlikely, but can occur if DPI is outlandish.
399
2674ddc8 400 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
401 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
402
28154962
PE
403 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
404 * xrdb.c (magic_file_p, search_magic_path):
405 Omit last arg SUFFIX; it was always 0. All callers changed.
406 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
407
7de51af5
PE
408 * xfont.c (xfont_match): Avoid need for strlen.
409
25ed6cc3
PE
410 * xfns.c: Don't assume strlen fits in int.
411 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
412
4eab31dd
PE
413 * xdisp.c (message_log_check_duplicate): Return intmax_t,
414 not unsigned long, as we prefer signed integers. All callers changed.
415 Detect integer overflow in repeat count.
416 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 417 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 418
171e2a58
PE
419 * termcap.c: Don't assume sizes fit in int and never overflow.
420 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
421 (gobble_line): Check for size-calculation overflow.
422
ad39faca 423 * minibuf.c (Fread_buffer):
6e5bb2dc 424 * lread.c (intern, intern_c_string):
74ca2eb3
PE
425 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
426 Don't assume string length fits in int.
427
52c61c22 428 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
429 * gtkutil.c (style_changed_cb): Avoid need for strlen.
430
b5b8c9e5
PE
431 * font.c: Don't assume string length fits in int.
432 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
433 Use ptrdiff_t, not int.
ccd6111c
PE
434 (font_intern_prop): Don't assume string length fits in int.
435 Don't assume integer property fits in fixnum.
436 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 437
882f0d81 438 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 439 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
440 Reformulate so as not to need the command string.
441 Invoke gzip -cd rather than gunzip, as it's more portable.
442 (lock_info_type, lock_file_1, lock_file):
443 Don't assume pid_t and time_t fit in unsigned long.
444 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
445 (current_lock_owner): Prefer signed type for sizes.
446 Use memcpy, not strncpy, where memcpy is what is really wanted.
447 Don't assume (via atoi) that time_t and pid_t fit in int.
448 Check for time_t and/or pid_t out of range, e.g., via a network share.
449 Don't alloca where an auto var works fine.
450
93f4cf88
PE
451 * fileio.c: Fix some integer overflow issues.
452 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
453 Don't assume string length fits in int.
454 (directory_file_name): Don't assume string length fits in long.
455 (make_temp_name): Don't assume pid fits in int, or that its print
456 length is less than 20.
457
f3e92b69
PE
458 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
459
1bfdaf10
PE
460 * coding.c (make_subsidiaries): Don't assume string length fits in int.
461
35016e9a
PE
462 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
463
3d1e65a1
PE
464 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
465 We prefer signed integers, even for size calculations.
466
0b963a93
PE
467 * emacs.c: Don't assume string length fits in 'int'.
468 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
469 (main): Don't invoke strlen when not needed.
470
573f4b54
PE
471 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
472 (XD_DEBUG_MESSAGE): Don't waste a byte.
473
989f33ba
PE
474 * callproc.c (getenv_internal_1, getenv_internal)
475 (Fgetenv_internal):
965d34eb
PE
476 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
477
e4d29b33
PE
478 * lread.c (invalid_syntax): Omit length argument.
479 All uses changed. This doesn't fix a bug, but it simplifies the
480 code away from its former Hollerith-constant appearance, and it's
481 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 482 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 483
eb49b136
PE
484 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
485 This didn't break anything, but it didn't help either.
486 It's confusing to put a bogus integer in a place where the actual
487 value does not matter.
9f62aeb1 488 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 489 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 490
15375a22
PE
491 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
492 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
493 implementation.
b61cc01c
PE
494 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
495 We prefer signed types, and the value cannot exceed the EMACS_INT
496 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
497 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
498 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
499 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 500
53b2623d
PE
501 * indent.c (sane_tab_width): New function.
502 (current_column, scan_for_column, Findent_to, position_indentation)
503 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 504 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 505
51cab52b 506 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 507
f2ed8a70
PE
508 * lisp.h (lint_assume): New macro.
509 * composite.c (composition_gstring_put_cache):
510 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
511
abe80cc6
PE
512 * editfns.c, insdel.c:
513 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 514
b02c740e
PE
515 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
516
ebc96716
PE
517 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
518
b4e50fa0 519 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 520 Use much-faster test for byte-length change.
311d5d7c 521 Don't assume string byte-length fits in 'int'.
a4cf38e4 522 Check that character arg fits in 'int'.
85461888 523 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 524
c0c1ee9f
PE
525 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
526
a498d7f4
PE
527 * fns.c (concat): Catch string overflow earlier.
528 Do not rely on integer wraparound.
529
51cab52b
PE
530 * dispextern.h (struct it.overlay_strings_charpos)
531 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
532 * xdisp.c (forward_to_next_line_start)
533 (back_to_previous_visible_line_start)
534 (reseat_at_next_visible_line_start, next_element_from_buffer):
535 Don't arbitrarily truncate the value of 'selective' to int.
536
76031fad
PE
537 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
538
5eb55db9
PE
539 * composite.c: Don't truncate sizes to 'int'.
540 (composition_gstring_p, composition_reseat_it)
541 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
542 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
543 not EMACS_UINT, for indexes.
5eb55db9 544
0703a717
PE
545 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
546
d6202519
PE
547 * buffer.c: Include <verify.h>.
548 (struct sortvec.priority, struct sortstr.priority):
8961a454 549 Now EMACS_INT, not int.
c20998a7 550 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
551 (struct sortstr.size, record_overlay_string)
552 (struct sortstrlist.size, struct sortlist.used):
553 Don't truncate size to int.
554 (record_overlay_string): Check for size-calculation overflow.
d6202519 555 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 556
d5a19415
JM
5572011-06-22 Jim Meyering <meyering@redhat.com>
558
029529ac 559 Don't leak an XBM-image-sized buffer
d5a19415
JM
560 * image.c (xbm_load): Free the image buffer after using it.
561
a9041e6c
PE
5622011-06-21 Paul Eggert <eggert@cs.ucla.edu>
563
564 Port to Sun C.
565 * composite.c (find_automatic_composition): Omit needless 'return 0;'
566 that Sun C diagnosed.
567 * fns.c (secure_hash): Fix pointer signedness issue.
568 * intervals.c (static_offset_intervals): New function.
569 (offset_intervals): Use it.
570
7f3f739f
LL
5712011-06-21 Leo Liu <sdl.web@gmail.com>
572
573 * deps.mk (fns.o):
574 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
575 sha512.h.
576
577 * fns.c (secure_hash): Rename from crypto_hash_function and change
578 the first arg to accept symbols.
5b66d427 579 (Fsecure_hash): New primitive.
7f3f739f
LL
580 (syms_of_fns): New symbols.
581
76147d94
DD
5822011-06-20 Deniz Dogan <deniz@dogan.se>
583
584 * process.c (Fset_process_buffer): Clarify return value in
585 docstring.
586
7d7d0045
CY
5872011-06-18 Chong Yidong <cyd@stupidchicken.com>
588
589 * dispnew.c (add_window_display_history): Use BVAR.
590
591 * xdisp.c (debug_method_add): Use BVAR.
592 (check_window_end, dump_glyph_matrix, dump_glyph)
593 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
594
595 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
596 Likewise.
597
598 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
599 check till after the cache is created in init_frame_faces.
600
ff2bc410
SM
6012011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
602
603 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
604
28177add
PE
6052011-06-16 Paul Eggert <eggert@cs.ucla.edu>
606
dd3482fe
PE
607 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
608 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
609 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
610
393d71f3 611 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
612 * fileio.c (Finsert_file_contents):
613 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
614 Remove the old (too-loose) buffer overflow checks.
615 They weren't needed, since make_gap checks for buffer overflow.
616 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
617 The old code merely checked for Emacs fixnum overflow, and relied
618 on undefined (wraparound) behavior. The new code avoids undefined
619 behavior, and also checks for ptrdiff_t and/or size_t overflow.
620
2e6813b0 621 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
622 Tune. Don't use wider integers than needed. Don't use alloca.
623 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 624
599a9e4f
PE
625 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
626
99561444
PE
627 * insdel.c, lisp.h (buffer_overflow): New function.
628 (insert_from_buffer_1, replace_range, replace_range_2):
629 * insdel.c (make_gap_larger):
630 * editfns.c (Finsert_char):
631 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
632
28177add
PE
633 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
634
e69dafad
PE
6352011-06-15 Paul Eggert <eggert@cs.ucla.edu>
636
a7af7fde 637 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 638
b1c46f02
PE
639 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
640 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
641
e69dafad
PE
642 * fileio.c: Don't assume EMACS_INT fits in off_t.
643 (emacs_lseek): New static function.
644 (Finsert_file_contents, Fwrite_region): Use it.
645 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
646
566684ea
PE
647 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
648
e6966cd6
PE
649 * fns.c: Don't overflow int when computing a list length.
650 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
651 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
652 truncation on 64-bit hosts. Check for QUIT every
653 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
654 faster and is responsive enough.
655 (Flength): Report an error instead of overflowing an integer.
656 (Fsafe_length): Return a float if the value is not representable
657 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 658 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 659 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 660
dd0b0efb
PE
661 * alloc.c: Check that resized vectors' lengths fit in fixnums.
662 (header_size, word_size): New constants.
663 (allocate_vectorlike): Don't check size overflow here.
664 (allocate_vector): Check it here instead, since this is the only
665 caller of allocate_vectorlike that could cause overflow.
666 Check that the new vector's length is representable as a fixnum.
667
86fe5cfe
PE
668 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
669 The previous code was bogus. For example, next_almost_prime (32)
670 returned 39, which is undesirable as it is a multiple of 3; and
671 next_almost_prime (24) returned 25, which is a multiple of 5 so
672 why was the code bothering to check for multiples of 7?
673
80e88859
PE
674 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
675
4a2f0ad6
PE
676 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
677
f66c7cf8
PE
678 Variadic C functions now count arguments with ptrdiff_t.
679 This partly undoes my 2011-03-30 change, which replaced int with size_t.
680 Back then I didn't know that the Emacs coding style prefers signed int.
681 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
682 were being counted with int, which may truncate counts on 64-bit
683 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
684 * lisp.h (struct Lisp_Subr.function.aMANY)
685 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
686 Arg counts are now ptrdiff_t, not size_t.
687 All variadic functions and their callers changed accordingly.
688 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
689 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
690 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
691 * callint.c (Fcall_interactively): Check arg count for overflow,
692 to avoid potential buffer overrun. Use signed char, not 'int',
693 for 'varies' array, so that we needn't bother to check its size
694 calculation for overflow.
695 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
696 * eval.c (apply_lambda):
697 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
698 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
699 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
700
a1759b76
PE
701 * callint.c (Fcall_interactively): Don't use index var as event count.
702
d96be9fc
PE
703 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
704 * mem-limits.h (SIZE): Remove; no longer used.
705
a690a978 706 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 707
578c21e6
PE
708 Remove unnecessary casts.
709 * xterm.c (x_term_init):
710 * xfns.c (x_set_border_pixel):
711 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
712 These aren't needed now that we assume ANSI C.
713
96f53c6c
PE
714 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
715 It's more likely to cause problems (due to unsigned overflow)
716 than to cure them.
717
83c77d31
PE
718 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
719
ee2079f1
PE
720 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
721
6da65536
PE
722 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
723
7147c4a4
PE
724 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
725
193e32d9
PE
726 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
727
e5533da6
PE
728 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
729
9910e595
PE
730 GLYPH_CODE_FACE returns EMACS_INT, not int.
731 * dispextern.h (merge_faces):
732 * xfaces.c (merge_faces):
01103c44
PE
733 * xdisp.c (get_next_display_element, next_element_from_display_vector):
734 Don't assume EMACS_INT fits in int.
9910e595 735
2638320e
PE
736 * character.h (CHAR_VALID_P): Remove unused parameter.
737 * fontset.c, lisp.h, xdisp.c: All uses changed.
738
045eb8d9
PE
739 * editfns.c (Ftranslate_region_internal): Omit redundant test.
740
c1f134b5
PE
741 * fns.c (concat): Minor tuning based on overflow analysis.
742 This doesn't fix any bugs. Use int to hold character, instead
743 of constantly refetching from Emacs object. Use XFASTINT, not
744 XINT, for value known to be a character. Don't bother comparing
745 a single byte to 0400, as it's always less.
746
395fcb93 747 * floatfns.c (Fexpt):
327eeec8
PE
748 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
749
abbd3d23
PE
750 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
751 for characters.
752
684a03ef
PE
753 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
754
0fed43f3
PE
755 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
756 Without this fix, on a 64-bit host (aset S 0 4294967386) would
757 incorrectly succeed when S was a string, because 4294967386 was
758 truncated before it was used.
759
8fd02eb7
PE
760 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
761 Otherwise, an out-of-range integer could cause undefined behavior
762 on a 64-bit host.
763
f8c86b69
PE
764 * composite.c: Use int, not EMACS_INT, for characters.
765 (fill_gstring_body, composition_compute_stop_pos): Use int, not
766 EMACS_INT, for values that are known to be in character range.
767 This doesn't fix any bugs but is the usual style inside Emacs and
768 may generate better code on 32-bit machines.
769
34206dd2
PE
770 Make sure a 64-bit char is never passed to ENCODE_CHAR.
771 This is for reasons similar to the recent CHAR_STRING fix.
772 * charset.c (Fencode_char): Check that character arg is actually
773 a character. Pass an int to ENCODE_CHAR.
774 * charset.h (ENCODE_CHAR): Verify that the character argument is no
775 wider than 'int', as a compile-time check to prevent future regressions
776 in this area.
777
c5958d4c 778 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
779
780 Make sure a 64-bit char is never passed to CHAR_STRING.
781 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
782 by silently ignoring the top 32 bits, allowing some values
783 that were far too large to be valid characters.
784 * character.h: Include <verify.h>.
785 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
786 arguments are no wider than unsigned, as a compile-time check
787 to prevent future regressions in this area.
788 * data.c (Faset):
01103c44 789 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
790 (Fsubst_char_in_region):
791 * fns.c (concat):
792 * xdisp.c (decode_mode_spec_coding):
793 Adjust to CHAR_STRING's new requirement.
794 * editfns.c (Finsert_char, Fsubst_char_in_region):
795 * fns.c (concat): Check that character args are actually
796 characters. Without this test, these functions did the wrong
797 thing with wildly out-of-range values on 64-bit hosts.
798
d37ca623
PE
799 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
800 These casts should not be needed on 32-bit hosts, either.
801 * keyboard.c (read_char):
802 * lread.c (Fload): Remove casts to unsigned.
803
ea204efb
PE
804 * lisp.h (UNSIGNED_CMP): New macro.
805 This fixes comparison bugs on 64-bit hosts.
806 (ASCII_CHAR_P): Use it.
807 * casefiddle.c (casify_object):
01103c44 808 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
809 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
810 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
811 * dispextern.h (FACE_FROM_ID):
812 * keyboard.c (read_char): Use UNSIGNED_CMP.
813
41cb286c
PE
814 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
815 not to EMACS_INT, to avoid GCC warning.
816
4a1b9832
PE
817 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
818
55daad71
PE
819 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
820 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
821 isn't needed on 32-bit machines.
8f95c75c 822
01103c44
PE
823 * buffer.c (Fgenerate_new_buffer_name):
824 Use EMACS_INT for count, not int.
0ceccced 825 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
826
827 * data.c (Qcompiled_function): Now static.
828
c6f072e7
PE
829 * window.c (window_body_lines): Now static.
830
20ce5912
PE
831 * image.c (gif_load): Rename local to avoid shadowing.
832
9c4c5f81
PE
833 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
834 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
835 * alloc.c (make_save_value): Integer argument is now of type
836 ptrdiff_t, not int.
837 (mark_object): Use ptrdiff_t, not int.
838 * lisp.h (pD): New macro.
839 * print.c (print_object): Use it.
840
c0c5c8ae
PE
841 * alloc.c: Use EMACS_INT, not int, to count objects.
842 (total_conses, total_markers, total_symbols, total_vector_size)
843 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
844 (total_free_floats, total_floats, total_free_intervals)
845 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
846 Now EMACS_INT, not int. All uses changed.
847 (Fgarbage_collect): Compute overall total using a double, so that
848 integer overflow is less likely to be a problem. Check for overflow
849 when converting back to an integer.
5a25e253
PE
850 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
851 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
852 These were 'int' variables that could overflow on 64-bit hosts;
853 they were never used, so remove them instead of repairing them.
211a0b2a 854 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
855 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
856 Previously, this ceilinged at INT_MAX, but that doesn't work on
857 64-bit machines.
e46bb31a 858 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 859
c78baabf 860 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 861 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
862 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
863 when a (possibly-narrower) signed value would do just as well.
864 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 865
c9d624c6
PE
866 * alloc.c: Catch some string size overflows that we were missing.
867 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
868 for convenience in STRING_BYTES_MAX.
869 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
870 The definition here is exact; the one in lisp.h was approximate.
871 (allocate_string_data): Check for string overflow. This catches
872 some instances we weren't catching before. Also, it catches
873 size_t overflow on (unusual) hosts where SIZE_MAX <= min
874 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
875 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 876
c9d624c6
PE
877 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
878 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
879 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
880
353032ce
PE
881 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
882
2bccce07
PE
883 * alloc.c (Fmake_string): Check for out-of-range init.
884
0ac30604
SM
8852011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
886
887 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
888
c195f2de
JD
8892011-06-14 Jan Djärv <jan.h.d@swipnet.se>
890
891 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
892 xg_get_default_scrollbar_width.
893
894 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
895 (int_gtk_range_get_value): Move to the scroll bar part of the file.
896 (style_changed_cb): Call update_theme_scrollbar_width and call
897 x_set_scroll_bar_default_width and xg_frame_set_char_size for
898 all frames (Bug#8505).
899 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
900 Call gtk_window_set_resizable if HAVE_GTK3.
901 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
902 and height if HAVE_GTK3 (Bug#8505).
903 (scroll_bar_width_for_theme): New variable.
904 (update_theme_scrollbar_width): New function.
905 (xg_get_default_scrollbar_width): Move code to
906 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
907 (xg_initialize): Call update_theme_scrollbar_width.
908
909 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
910
911 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
912
e10ac9f1
MR
9132011-06-12 Martin Rudalics <rudalics@gmx.at>
914
915 * frame.c (make_frame): Call other_buffer_safely instead of
916 other_buffer.
917
918 * window.c (temp_output_buffer_show): Call display_buffer with
919 second argument Vtemp_buffer_show_specifiers and reset latter
920 immediately after the call.
921 (Vtemp_buffer_show_specifiers): New variable.
922 (auto_window_vscroll_p, next_screen_context_lines)
923 (Vscroll_preserve_screen_position): Remove leading asterisks from
924 doc-strings.
925
2d3c217e 9262011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 927
7b7f97e8 928 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
929 * buffer.c (Qclone_number): Remove for now, as it's unused.
930 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
931 (record_buffer): Remove unused local.
932 * frame.c (other_visible_frames, frame_buffer_list): Now static.
933 (set_frame_buffer_list): Remove; unused.
934 * frame.h (other_visible_frames): Remove decl.
935 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
936 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
937 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
938 if HAVE_GPM.
939 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
940 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
941 Define only if HAVE_GPM.
942 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
943 (update_hints_inhibit): Remove; never set. All uses removed.
944 * widgetprv.h (emacsFrameClassRec): Remove decl.
945 * window.c (delete_deletable_window): Now returns void, since it
946 wasn't returning anything.
947 (compare_window_configurations): Remove unused locals.
948 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
949 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
950 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
951 the same widths as pointers. This follows up on the 2011-05-06 patch.
952 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
953 * xterm.h: Likewise.
954 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
955
1384b89e
JB
9562011-06-12 Juanma Barranquero <lekktu@gmail.com>
957
958 * makefile.w32-in: Update dependencies.
959 (LISP_H): Add lib/intprops.h.
960
1100a63c
CY
9612011-06-11 Chong Yidong <cyd@stupidchicken.com>
962
963 * image.c (gif_load): Add animation frame delay to the metadata.
964 (syms_of_image): Use DEFSYM. New symbol `delay'.
965
6198ccd0
MR
9662011-06-11 Martin Rudalics <rudalics@gmx.at>
967
968 * window.c (delete_deletable_window): Re-add.
969 (Fset_window_configuration): Rewrite to handle dead buffers and
970 consequently deletable windows.
971 (window_tree, Fwindow_tree): Remove. Supply functionality in
972 window.el.
973 (compare_window_configurations): Simplify code.
974
b6e3633c
AS
9752011-06-11 Andreas Schwab <schwab@linux-m68k.org>
976
1ab0dee5
AS
977 * image.c (imagemagick_load_image): Fix type mismatch.
978 (Fimagemagick_types): Likewise.
979
b6e3633c
AS
980 * window.h (replace_buffer_in_windows): Declare.
981
9397e56f
MR
9822011-06-11 Martin Rudalics <rudalics@gmx.at>
983
984 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
985 Qclone_number. Remove external declaration of Qdelete_window.
986 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
987 code.
988 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
989 Qbuffer_list_update_hook if allowed.
990 (Fother_buffer): Rewrite doc-string. Major rewrite for new
991 buffer list implementation.
992 (other_buffer_safely): New function.
993 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
994 calls to replace_buffer_in_windows and
995 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
996 if allowed.
997 (record_buffer): Inhibit quitting and rewrite using quittable
998 functions. Run Qbuffer_list_update_hook if allowed.
999 (Frecord_buffer, Funrecord_buffer): New functions.
1000 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1001 switch-to-buffer to window.el.
1002 (bury-buffer): Move to window.el.
1003 (Vbuffer_list_update_hook): New variable.
1004
1005 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1006 section.
1007
1008 * window.h (resize_frame_windows): Move up in code.
1009 (Fwindow_frame): Remove EXFUN.
1010 (replace_buffer_in_all_windows): Remove prototype.
1011 (replace_buffer_in_windows_safely): Add prototype.
1012
1013 * window.c: Declare Qdelete_window static again. Move down
1014 declaration of select_count.
1015 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1016 (Fother_window): Move to window.el.
1017 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1018 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1019 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1020 window.el.
1021 (replace_buffer_in_windows): Implement by calling
1022 Qreplace_buffer_in_windows.
1023 (replace_buffer_in_all_windows): Remove with some functionality
1024 moved into replace_buffer_in_windows_safely.
1025 (replace_buffer_in_windows_safely): New function.
1026 (select_window_norecord, select_frame_norecord): Move in front
1027 of run_window_configuration_change_hook. Remove now obsolete
1028 declarations.
1029 (Fset_window_buffer): Rewrite doc-string. Call
1030 Qrecord_window_buffer.
1031 (keys_of_window): Move binding for other-window to window.el.
1032
b50691aa
CY
10332011-06-11 Chong Yidong <cyd@stupidchicken.com>
1034
1035 * dispextern.h (struct image): Replace data member, whose int_val
1036 and ptr_val fields were not used by anything, with a single
1037 lisp_val object.
1038
1039 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1040 (gif_clear_image, gif_load, imagemagick_load_image)
1041 (gs_clear_image, gs_load): Callers changed.
1042
3f754b86
PE
10432011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1044
cca69397
PE
1045 * buffer.h: Include <time.h>, for time_t.
1046 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1047
109e28d0
PE
1048 Fix minor problems found by static checking.
1049
60737f02
PE
1050 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1051
4b66faf3
PE
1052 Make identifiers static if they are not used in other modules.
1053 * data.c (Qcompiled_function, Qframe, Qvector):
1054 * image.c (QimageMagick, Qsvg):
1055 * minibuf.c (Qmetadata):
1056 * window.c (resize_window_check, resize_root_window): Now static.
1057 * window.h (resize_window_check, resize_root_window): Remove decls.
1058
109e28d0
PE
1059 * window.c (window_deletion_count, delete_deletable_window):
1060 Remove; unused.
46a4ce9e
PE
1061 (window_body_lines): Now static.
1062 (Fdelete_other_windows_internal): Mark vars as initialized.
1063 Make sure 'resize_failed' is initialized.
1064 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1065 (resize_window_apply): Remove unused local.
1066 * window.h (delete_deletable_window): Remove decl.
1067
109e28d0 1068 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1069 (imagemagick_load_image): Fix pointer signedness problem by changing
1070 last arg from unsigned char * to char *. All uses changed.
1071 Also, fix a local for similar reasons.
1072 Remove unused locals. Remove locals to avoid shadowing.
1073 (fn_rsvg_handle_free): Remove; unused.
1074 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1075 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1076
3f754b86
PE
1077 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1078
2547adb1
CY
10792011-06-10 Chong Yidong <cyd@stupidchicken.com>
1080
1081 * image.c (gif_load): Fix omitted cast error introduced by
1082 2011-06-06 change.
1083
2c8e37d4
MR
10842011-06-10 Martin Rudalics <rudalics@gmx.at>
1085
1086 * window.h (resize_proportionally, orig_total_lines)
1087 (orig_top_line): Remove from window structure.
1088 (set_window_height, set_window_width, change_window_heights)
1089 (Fdelete_window): Remove prototypes.
1090 (resize_frame_windows): Remove duplicate declaration.
1091
440a42e3
EZ
10922011-06-10 Eli Zaretskii <eliz@gnu.org>
1093
1094 * window.h (resize_frame_windows, resize_window_check)
1095 (delete_deletable_window, resize_root_window)
1096 (resize_frame_windows): Declare prototypes.
1097
1098 * window.c (resize_window_apply): Make definition be "static" to
1099 match the prototype.
1100
562dd5e9
MR
11012011-06-10 Martin Rudalics <rudalics@gmx.at>
1102
1103 * window.c: Remove declarations of Qwindow_size_fixed,
1104 window_min_size_1, window_min_size_2, window_min_size,
1105 size_window, window_fixed_size_p, enlarge_window, delete_window.
1106 Remove static from declaration of Qdelete_window, it's
1107 temporarily needed by Fbury_buffer.
1108 (replace_window): Don't assign orig_top_line and
1109 orig_total_lines.
1110 (Fdelete_window, delete_window): Remove. Window deletion is
1111 handled by window.el.
1112 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1113 Fdelete_window calls with calls to Qdelete_window.
1114 (Fdelete_other_windows): Remove. Deleting other windows is
1115 handled by window.el.
1116 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1117 handled in window.el.
1118 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1119 Window minimum sizes are handled in window.el.
1120 (shrink_windows, size_window, set_window_height)
1121 (set_window_width, change_window_heights, window_height)
1122 (window_width, CURBEG, CURSIZE, enlarge_window)
1123 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1124 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1125 handled in window.el.
1126 (make_dummy_parent): Rename to make_parent_window and give it a
1127 second argument horflag.
1128 (make_window): Don't set resize_proportionally any more.
1129 (Fsplit_window): Remove. Windows are split in window.el.
1130 (save_restore_action, save_restore_orig_size)
1131 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1132 Resize mini windows in window.el.
1133 (grow_mini_window, shrink_mini_window): Implement by calling
1134 Qresize_root_window_vertically, resize_window_check and
1135 resize_window_apply.
1136 (saved_window, Fset_window_configuration, save_window_save): Do
1137 not handle orig_top_line, orig_total_lines, and
1138 resize_proportionally.
1139 (window_min_height, window_min_width): Move to window.el.
1140 (keys_of_window): Move bindings for delete-other-windows,
1141 split-window, delete-window and enlarge-window to window.el.
1142
1143 * buffer.c: Temporarily extern Qdelete_window.
1144 (Fbury_buffer): Temporarily call Qdelete_window instead of
1145 Fdelete_window (Fbury_buffer will move to window.el soon).
1146
1147 * frame.c (set_menu_bar_lines_1): Remove code handling
1148 orig_top_line and orig_total_lines.
1149
1150 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1151 set_window_height but set heights directly.
1152 (change_frame_size_1): Use resize_frame_windows.
1153
1154 * xdisp.c (init_xdisp): Don't use set_window_height but set
1155 heights directly.
1156
1157 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1158 resize_frame_windows instead of change_window_heights and run
1159 run_window_configuration_change_hook.
1160
1161 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1162 instead of change_window_heights and run
1163 run_window_configuration_change_hook.
1164
1a13852e
MR
11652011-06-09 Martin Rudalics <rudalics@gmx.at>
1166
1167 * window.c (replace_window): Rename second argument REPLACEMENT to
1168 NEW. New third argument SETFLAG. Rewrite.
1169 (delete_window, make_dummy_parent): Call replace_window with
1170 third argument 1.
1171 (window_list_1): Move down in code.
1172 (run_window_configuration_change_hook): Move set_buffer part
1173 before select_frame_norecord part in order to unwind correctly.
1174 Rename count1 to count.
1175 (recombine_windows, delete_deletable_window, resize_root_window)
1176 (Fdelete_other_windows_internal)
1177 (Frun_window_configuration_change_hook, make_parent_window)
1178 (resize_window_check, resize_window_apply, Fresize_window_apply)
1179 (resize_frame_windows, Fsplit_window_internal)
1180 (Fdelete_window_internal, Fresize_mini_window_internal): New
1181 functions.
1182 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1183
f3d1777e
MR
11842011-06-08 Martin Rudalics <rudalics@gmx.at>
1185
496e208e
MR
1186 * window.h (window): Add some new members to window structure -
1187 normal_lines, normal_cols, new_total, new_normal, clone_number,
1188 splits, nest, prev_buffers, next_buffers.
1189 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1190 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1191
f3d1777e
MR
1192 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1193 Remove.
496e208e
MR
1194 (make_dummy_parent): Set new members of windows structure.
1195 (make_window): Move down in code. Handle new members of window
1196 structure.
1197 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1198 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1199 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1200 (Fset_window_prev_buffers, Fwindow_next_buffers)
1201 (Fset_window_next_buffers, Fset_window_clone_number): New
1202 functions.
1203 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1204 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1205 Doc-string fixes.
1206 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1207 Argument WINDOW can be now internal window too.
1208 (Fwindow_use_time): Move up in code.
1209 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1210 Rewrite doc-string.
1211 (Fset_window_configuration, saved_window)
1212 (Fcurrent_window_configuration, save_window_save): Handle new
1213 members of window structure.
b9e809c2
MR
1214 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1215 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1216 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1217 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1218 Qget_mru_window, Qresize_root_window,
1219 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1220 Qauto_buffer_name; staticpro them.
f3d1777e 1221
abde8f8c
MR
12222011-06-07 Martin Rudalics <rudalics@gmx.at>
1223
1224 * window.c (Fwindow_total_size, Fwindow_left_column)
1225 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1226 (Fwindow_list_1): New functions.
1227 (window_box_text_cols): Replace with window_body_cols.
1228 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1229 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1230 (delete_window, Fset_window_configuration): Call
1231 delete_all_subwindows with window as argument.
1232 (delete_all_subwindows): Take a window as argument and not a
1233 structure. Rewrite.
190b47e6
MR
1234 (window_loop): Remove handling of GET_LRU_WINDOW and
1235 GET_LARGEST_WINDOW.
1236 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1237
1238 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1239 window_box_text_cols. delete_all_subwindows now takes a
1240 Lisp_Object as argument.
abde8f8c
MR
1241
1242 * indent.c (compute_motion, Fcompute_motion): Use
1243 window_body_cols instead of window_box_text_cols.
1244
fa8a67e6
MR
1245 * frame.c (delete_frame): Call delete_all_subwindows with root
1246 window as argument.
1247
a54e3482
DC
12482011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1249
1250 * fns.c (Fputhash): Document return value.
1251
60002bf5
CY
12522011-06-06 Chong Yidong <cyd@stupidchicken.com>
1253
1254 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1255
0c671da6 12562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1257
b862a52a 1258 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1259
be44ca6c
PE
1260 Check for overflow when converting integer to cons and back.
1261 * charset.c (Fdefine_charset_internal, Fdecode_char):
1262 Use cons_to_unsigned to catch overflow.
1263 (Fencode_char): Use INTEGER_TO_CONS.
1264 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1265 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1266 * data.c (long_to_cons, cons_to_long): Remove.
1267 (cons_to_unsigned, cons_to_signed): New functions.
1268 These signal an error for invalid or out-of-range values.
1269 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1270 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1271 * font.c (Ffont_variation_glyphs):
1272 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1273 * lisp.h: Include <intprops.h>.
1274 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1275 (cons_to_signed, cons_to_unsigned): New decls.
1276 (long_to_cons, cons_to_long): Remove decls.
1277 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1278 (Fprimitive_undo): Use CONS_TO_INTEGER.
1279 * xfns.c (Fx_window_property): Likewise.
1280 * xselect.c: Include <limits.h>.
1281 (x_own_selection, selection_data_to_lisp_data):
1282 Use INTEGER_TO_CONS.
1283 (x_handle_selection_request, x_handle_selection_clear)
1284 (x_get_foreign_selection, Fx_disown_selection_internal)
1285 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1286 (lisp_data_to_selection_data): Use cons_to_unsigned.
1287 (x_fill_property_data): Use cons_to_signed.
1288 Report values out of range.
1289
d1f3d2af
PE
1290 Check for buffer and string overflow more precisely.
1291 * buffer.h (BUF_BYTES_MAX): New macro.
1292 * lisp.h (STRING_BYTES_MAX): New macro.
1293 * alloc.c (Fmake_string):
1294 * character.c (string_escape_byte8):
1295 * coding.c (coding_alloc_by_realloc):
1296 * doprnt.c (doprnt):
1297 * editfns.c (Fformat):
1298 * eval.c (verror):
1299 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1300 since they may not be the same number.
1301 * editfns.c (Finsert_char):
1302 * fileio.c (Finsert_file_contents):
1303 Likewise for BUF_BYTES_MAX.
1304
dd52fcea
PE
1305 * image.c: Use ptrdiff_t, not int, for sizes.
1306 (slurp_file): Switch from int to ptrdiff_t.
1307 All uses changed.
1308 (slurp_file): Check that file size fits in both size_t (for
1309 malloc) and ptrdiff_t (for sanity and safety).
1310
7f9bbdbb
PE
1311 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1312 if b->modtime has its maximal value.
1313
dfe18f82
PE
1314 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1315
84acfcf0
PE
1316 Don't assume time_t can fit into int.
1317 * buffer.h (struct buffer.modtime): Now time_t, not int.
1318 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1319 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1320
ccd9a01a
PE
1321 Minor fixes for signed vs unsigned integers.
1322 * character.h (MAYBE_UNIFY_CHAR):
1323 * charset.c (maybe_unify_char):
1324 * keyboard.c (read_char, reorder_modifiers):
1325 XINT -> XFASTINT, since the integer must be nonnegative.
1326 * ftfont.c (ftfont_spec_pattern):
1327 * keymap.c (access_keymap, silly_event_symbol_error):
1328 XUINT -> XFASTINT, since the integer must be nonnegative.
1329 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1330 since it makes no difference and we prefer signed.
1331 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1332 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1333 nonnegative.
1334
d6d100dd
SM
13352011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1336
1337 * window.h (Fwindow_frame): Declare.
1338
2b6148e4
PE
13392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1340
1341 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1342 (SPARE_MEMORY): Always define.
1343 (LARGE_REQUEST): Remove.
1344 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1345
f230ecc9
MR
13462011-06-06 Martin Rudalics <rudalics@gmx.at>
1347
727e958e
MR
1348 * lisp.h: Move EXFUNS for Fframe_root_window,
1349 Fframe_first_window and Fset_frame_selected_window to window.h.
1350
1351 * window.h: Move EXFUNS for Fframe_root_window,
1352 Fframe_first_window and Fset_frame_selected_window here from
1353 lisp.h.
1354
1355 * frame.c (Fwindow_frame, Fframe_first_window)
1356 (Fframe_root_window, Fframe_selected_window)
1357 (Fset_frame_selected_window): Move to window.c.
1358 (Factive_minibuffer_window): Move to minibuf.c.
1359 (Fother_visible_frames_p): New function.
1360
1361 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1362
f230ecc9
MR
1363 * window.c (decode_window, decode_any_window): Move up in code.
1364 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1365 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1366 (Fwindow_buffer): Move up and rewrite doc-string.
1367 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1368 (Fwindow_prev): New functions.
727e958e
MR
1369 (Fwindow_frame): Move here from frame.c. Accept any window as
1370 argument.
1371 (Fframe_root_window, Fframe_first_window)
1372 (Fframe_selected_window): Move here from frame.c. Accept frame
1373 or arbitrary window as argument. Update doc-strings.
1374 (Fminibuffer_window): Move up in code.
1375 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1376 (Fset_frame_selected_window): Move here from frame.c.
1377 Marginal rewrite.
727e958e
MR
1378 (Fselected_window, select_window, Fselect_window): Move up in
1379 code. Minor doc-string fixes.
f230ecc9 1380
4d09bcf6
PE
13812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1382
1383 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1384 Do not assume that spare memory exists; that assumption is valid
1385 only if SYSTEM_MALLOC.
1386 (LARGE_REQUEST): New macro, so that the issue of large requests
1387 is separated from the issue of spare memory.
1388
810928a2
AS
13892011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1390
172418ad
AS
1391 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1392 format. (Bug#8806)
1393
43f862f7
AS
1394 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1395
810928a2
AS
1396 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1397 before statements.
1398
a059fe24
JD
13992011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1400
1401 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1402
1403 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1404
1405 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1406 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1407
989bf368
JB
14082011-06-05 Juanma Barranquero <lekktu@gmail.com>
1409
1410 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1411
4b80f674
CY
14122011-06-04 Chong Yidong <cyd@stupidchicken.com>
1413
1414 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1415 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1416 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1417 New error handlers.
4b80f674
CY
1418 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1419 Obey Vx_select_enable_clipboard_manager. Catch errors in
1420 x_clipboard_manager_save (Bug#8779).
1421 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1422 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1423
99a33b77 14242011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1425
1426 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1427
99a33b77 14282011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1429
1430 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1431 in the current matrix if keep_current_p is non-zero.
1432
8264569d
EZ
14332011-06-04 Eli Zaretskii <eliz@gnu.org>
1434
1435 * bidi.c (bidi_level_of_next_char): Fix last change.
1436
57f97249
EZ
14372011-06-03 Eli Zaretskii <eliz@gnu.org>
1438
fec2107c 1439 Support bidi reordering of text covered by display properties.
57f97249 1440
fec2107c
EZ
1441 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1442 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1443 (bidi_cache_search, bidi_cache_iterator_state)
1444 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1445 (bidi_level_of_next_char, bidi_move_to_visually_next):
1446 Support character positions inside a run of characters covered by a
fec2107c
EZ
1447 display string.
1448 (bidi_paragraph_init, bidi_resolve_explicit_1)
1449 (bidi_level_of_next_char): Call bidi_fetch_char and
1450 bidi_fetch_char_advance instead of FETCH_CHAR and
1451 FETCH_CHAR_ADVANCE.
1452 (bidi_init_it): Initialize new members.
1453 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1454 definitions.
1455 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1456 instead of using explicit *_CHAR codes.
d6d100dd
SM
1457 (bidi_resolve_explicit, bidi_resolve_weak):
1458 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1459 bidirectional text is supported only in multibyte buffers.
1460 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1461 it to initialize the frame_window_p member of struct bidi_it.
1462 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1463 (bidi_resolve_explicit, bidi_resolve_weak)
1464 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1465 bidi_it->nchars is non-positive.
1466 (bidi_level_of_next_char): Don't try to lookup the cache for the
1467 next/previous character if nothing is cached there yet, or if we
1468 were just reseat()'ed to a new position.
c40e2fb2 1469
0e14fe90
EZ
1470 * xdisp.c (set_cursor_from_row): Set start and stop points
1471 according to the row's direction when priming the loop that looks
1472 for the glyph on which to display cursor.
1473 (single_display_spec_intangible_p): Function deleted.
1474 (display_prop_intangible_p): Reimplement to call
1475 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1476 Accept 3 additional arguments needed by handle_display_spec.
1477 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1478 values: lists, `(when COND...)' forms, etc.
1479 (single_display_spec_string_p): Support property values that are
1480 lists with the argument STRING its top-level element.
1481 (display_prop_string_p): Fix the condition for processing a
1482 property that is a list to be consistent with handle_display_spec.
fec2107c 1483 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1484 last portion of handle_display_prop.
1485 (compute_display_string_pos): Accept additional argument
1486 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1487 value of a `display' property is a "replacing spec".
1488 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1489 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1490 the display property, but just return a value indicating whether
1491 the display property will replace the characters it covers.
1492 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1493 frame_window_p members of struct bidi_it.
d6d100dd
SM
1494 (compute_display_string_pos, compute_display_string_end):
1495 New functions.
fec2107c
EZ
1496 (push_it): Accept second argument POSITION, where pop_it should
1497 jump to continue iteration.
1498 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1499
fec2107c
EZ
1500 * keyboard.c (adjust_point_for_property): Adjust the call to
1501 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1502
1503 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1504 (bidi_init_it): Update prototypes.
1505 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1506 (compute_display_string_pos, compute_display_string_end):
1507 Declare prototypes.
fec2107c
EZ
1508 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1509 EMACS_INT.
fc6f18ce 1510
40087514 15112011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1512
57f53182
PE
1513 Malloc failure behavior now depends on size of allocation.
1514 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1515 * lisp.h: Change signatures accordingly.
1516 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1517 All callers changed. (Bug#8762)
1518
1519 * gnutls.c: Use Emacs's memory allocators.
1520 Without this change, the gnutls library would invoke malloc etc.
1521 directly, which causes problems on non-SYNC_INPUT hosts, and which
1522 runs afoul of improving memory_full behavior. (Bug#8761)
1523 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1524 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1525 xfree instead of the default malloc, realloc, free.
1526 (Fgnutls_boot): No need to check for memory allocation failure,
1527 since xmalloc does that for us.
1528
ac32cd99 1529 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1530 * category.c (hash_get_category_set):
1531 * ccl.c (ccl_driver):
1532 * charset.c (Fdefine_charset_internal):
1533 * charset.h (struct charset.hash_index):
1534 * composite.c (get_composition_id, gstring_lookup_cache)
1535 (composition_gstring_put_cache):
1536 * composite.h (struct composition.hash_index):
1537 * dispextern.h (struct image.hash):
1538 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1539 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1540 (hashfn_equal, hashfn_user_defined, make_hash_table)
1541 (maybe_resize_hash_table, hash_lookup, hash_put)
1542 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1543 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1544 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1545 * image.c (make_image, search_image_cache, lookup_image)
1546 (xpm_put_color_table_h):
1547 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1548 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1549 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1550 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1551 * alloc.c (allocate_vectorlike):
1552 Check for overflow in vector size calculations.
1553 * ccl.c (ccl_driver):
1554 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1555 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1556 need to be updated by these changes.
40087514
PE
1557 * fns.c (make_hash_table, maybe_resize_hash_table):
1558 Check for integer overflow with large hash tables.
0de4bb68
PE
1559 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1560 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1561 (SXHASH_REDUCE): New macro.
1562 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1563 Use it instead of discarding useful hash info with large hash values.
1564 (sxhash_float): New function.
1565 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1566 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1567 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1568 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1569 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1570 Adjust signatures to match updated version of code.
1571 (consing_since_gc): Now EMACS_INT, since a single hash table can
1572 use more than INT_MAX bytes.
1573
698d32e2
DN
15742011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1575
1576 Make it possible to build with GCC-4.6+ -O2 -flto.
1577
1578 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1579
fd6fa53f
SM
15802011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1581
1582 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1583 Call minibuffer-inactive-mode.
1584
864db017
JB
15852011-05-31 Juanma Barranquero <lekktu@gmail.com>
1586
1587 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1588 Update dependencies.
1589
2ad0baf4
DN
15902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1591
1592 * data.c (init_data): Remove code for UTS, this system is not
1593 supported anymore.
1594
4fcc2638
DN
15952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1596
1597 Don't force ./temacs to start in terminal mode.
1598
1599 * frame.c (make_initial_frame): Initialize faces in all cases, not
1600 only when CANNOT_DUMP is defined.
1601 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1602
c56e0fd5
DN
16032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1604
1605 * dispnew.c (add_window_display_history): Use const for the string
1606 pointer. Remove declaration, not needed.
1607
333d54da 16082011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1609
55d4c1b2 1610 Use 'inline', not 'INLINE'.
333d54da 1611 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1612 * alloc.c, fontset.c (INLINE): Remove.
1613 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1614 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1615 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1616 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1617 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1618
738db178
DN
16192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1620
1621 Make it possible to run ./temacs.
1622
1623 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1624 syms_of_callproc does the same thing. Remove test for
1625 "initialized", do it in the caller.
1626 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1627
620c53a6
SM
16282011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1629
1630 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1631 (read_minibuf): Use get_minibuffer.
1632 (syms_of_minibuf): Use DEFSYM.
1633 (Qmetadata): New var.
1634 * data.c (Qbuffer): Don't make it static.
1635 (syms_of_data): Use DEFSYM.
1636
e003a292
PE
16372011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1638
1639 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1640 (CCL_CODE_MIN): New macro.
1641
ed008a6d
PE
16422011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1643
3687c2ef
PE
1644 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1645
ed008a6d
PE
1646 * eval.c (Qdebug): Now static.
1647 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1648 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1649 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1650
d66c4c7c
CY
16512011-05-29 Chong Yidong <cyd@stupidchicken.com>
1652
1653 * image.c: Various fixes to ImageMagick code comments.
1654 (Fimagemagick_types): Doc fix.
1655
5fbc2025
PE
16562011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1657
0196f88a
PE
1658 Minor fixes prompted by GCC 4.6.0 warnings.
1659
1660 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1661
5fbc2025
PE
1662 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1663 (x_clipboard_manager_save_all): Move extern decl to ...
1664 * xterm.h: ... here, so that it can be checked for consistency.
1665
1dd3c2d9
CY
16662011-05-29 Chong Yidong <cyd@stupidchicken.com>
1667
1668 * xselect.c (x_clipboard_manager_save_frame)
1669 (x_clipboard_manager_save_all): New functions.
1670 (Fx_clipboard_manager_save): Lisp function deleted.
1671
1672 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1673 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1674
1675 * xterm.h: Update prototype.
1676
5ba6571d
WX
16772011-05-28 William Xu <william.xwl@gmail.com>
1678
1679 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1680 exiting (Bug#8239).
1681
3eaff834
JM
16822011-05-28 Jim Meyering <meyering@redhat.com>
1683
e1900994 1684 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1685 * fns.c (to_uchar): Define.
1686 (crypto_hash_function): Use it to convert some newly-signed
1687 variables to unsigned, to avoid sign-extension bugs. For example,
1688 without this change, (md5 "truc") would evaluate to
1689 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1690 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1691 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1692
0f6990a7
PE
16932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1694
1695 Integer overflow fixes.
c8a9ca5a 1696
08686060
PE
1697 * dbusbind.c: Serial number integer overflow fixes.
1698 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1699 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1700 to hold a serial number that is too large for a fixnum.
1701 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1702 Check for serial numbers out of range. Decode any serial number
59568bf0 1703 that was so large that it became a float. (Bug#8722)
08686060 1704
2d1fc3c7
PE
1705 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1706 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1707 Use XFASTINT rather than XUINT when numbers are nonnegative.
1708 (xd_append_arg, Fdbus_method_return_internal):
1709 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1710 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1711 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1712 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1713 (Bug#8722)
2d1fc3c7 1714
c8a9ca5a
PE
1715 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1716
519e1d69
PE
1717 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1718
30569699
PE
1719 ccl: add integer overflow checks
1720 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1721 (IN_INT_RANGE): New macros.
1722 (ccl_driver): Use them to check for integer overflow when
1723 decoding a CCL program. Many of the new checks are whether XINT (x)
1724 fits in int; it doesn't always, on 64-bit hosts. The new version
1725 doesn't catch all possible integer overflows, but it's an
847044ea 1726 improvement. (Bug#8719)
30569699 1727
c11285dc
PE
1728 * alloc.c (make_event_array): Use XINT, not XUINT.
1729 There's no need for unsigned here.
1730
fdccd48e
PE
1731 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1732 This follows up to the 2011-05-06 change that substituted uintptr_t
1733 for EMACS_INT. This case wasn't caught back then.
1734
37910ab2
PE
1735 Rework Fformat to avoid integer overflow issues.
1736 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1737 now (part of C89). Include <verify.h>.
1738 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1739 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1740 (Fformat): Avoid the prepass trying to compute sizes; it was only
1741 approximate and thus did not catch overflow reliably. Instead, walk
1742 through the format just once, formatting and computing sizes as we go,
1743 checking for integer overflow at every step, and allocating a larger
1744 buffer as needed. Keep track separately whether the format is
1745 multibyte. Keep only the most-recently calculated precision, rather
1746 than them all. Record whether each argument has been converted to
1747 string. Use EMACS_INT, not int, for byte and char and arg counts.
1748 Support field widths and precisions larger than INT_MAX. Avoid
1749 sprintf's undefined behavior with conversion specifications such as %#d
1750 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1751 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1752 formatting out-of-range floating point numbers with int
1753 formats. (Bug#8668)
1754
2e6578fb
PE
1755 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1756
0ae6bdee
PE
1757 * data.c: Avoid integer truncation in expressions involving floats.
1758 * data.c: Include <intprops.h>.
1759 (arith_driver): When there's an integer overflow in an expression
1760 involving floating point, convert the integers to floating point
1761 so that the resulting value does not suffer from catastrophic
1762 integer truncation. For example, on a 64-bit host (* 4
1763 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1764 Do not rely on undefined behavior after integer overflow.
1765
de883a70
PE
1766 merge count_size_as_multibyte, parse_str_to_multibyte
1767 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1768 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1769 Check for integer overflow.
1770 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1771 since it's now a duplicate of the other. This is more of
1772 a character than a buffer op, so better that it's in character.c.
1773 * fns.c, print.c: Adjust to above changes.
1774
2ff916cb
PE
17752011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1776
1777 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1778
f1b54466
PE
17792011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1780
fb1ac845
PE
1781 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1782 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1783 (x_clipboard_manager_save): Now static.
1784 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1785
f1b54466
PE
1786 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1787 (crypto_hash_function): Now static.
1788 Fix pointer signedness problems. Avoid unnecessary initializations.
1789
a9f737ee
CY
17902011-05-27 Chong Yidong <cyd@stupidchicken.com>
1791
1792 * termhooks.h (Vselection_alist): Make it terminal-local.
1793
1794 * terminal.c (create_terminal): Initialize it.
1795
1796 * xselect.c: Support for clipboard managers.
1797 (Vselection_alist): Move to termhooks.h as terminal-local var.
1798 (LOCAL_SELECTION): New macro.
1799 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1800 (symbol_to_x_atom): Remove gratuitous arg.
1801 (x_handle_selection_request, lisp_data_to_selection_data)
1802 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1803 (x_own_selection, x_get_local_selection, x_convert_selection):
1804 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1805 (some_frame_on_display): Delete unused function.
1806 (Fx_own_selection_internal, Fx_get_selection_internal)
1807 (Fx_disown_selection_internal, Fx_selection_owner_p)
1808 (Fx_selection_exists_p): New optional frame arg.
1809 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1810 (x_handle_selection_clear): Don't treat other terminals with the
1811 same keyboard specially. Use the terminal-local Vselection_alist.
1812 (x_clear_frame_selections): Use Frun_hook_with_args.
1813
1814 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1815
1816 * xterm.h: Add support for those atoms.
1817
e067f0c1
CY
18182011-05-26 Chong Yidong <cyd@stupidchicken.com>
1819
1820 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1821 (converted_selections, conversion_fail_tag): New global variables.
1822 (x_selection_request_lisp_error): Free the above.
1823 (x_get_local_selection): Remove unnecessary code.
1824 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1825 of converted selections stored in converted_selections.
1826 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1827 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1828 (x_convert_selection): New function.
1829 (x_handle_selection_event): Simplify.
1830 (x_get_foreign_selection): Don't ignore incoming requests while
1831 waiting for an answer; this will fail when we implement
1832 SAVE_TARGETS, and seems unnecessary anyway.
1833 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1834 (Vx_sent_selection_functions): Doc fix.
1835
0f4aebc0
LL
18362011-05-26 Leo Liu <sdl.web@gmail.com>
1837
1838 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1839
e61124cd
YM
18402011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1841
1842 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1843
1844 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1845 for fringe update if it has periodic bitmap.
1846 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1847 and fringe_bitmap_periodic_p.
1848
1849 * fringe.c (get_fringe_bitmap_data): New function.
1850 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1851 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1852 row. Mark glyph row for fringe update if periodicity changed.
1853
1854 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1855 for fringe update unless it has periodic bitmap.
1856
f16d9837
KH
18572011-05-25 Kenichi Handa <handa@m17n.org>
1858
1859 * xdisp.c (get_next_display_element): Set correct it->face_id for
1860 a static composition.
1861
e1b90ef6
LL
18622011-05-24 Leo Liu <sdl.web@gmail.com>
1863
1864 * deps.mk (fns.o):
1865 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1866
1867 * fns.c (crypto_hash_function, Fsha1): New function.
1868 (Fmd5): Use crypto_hash_function.
1869 (syms_of_fns): Add Ssha1.
1870
7400048f
PE
18712011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1872
1873 * gnutls.c: Remove unused macros.
1874 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1875 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1876 Remove macros that are defined and never used.
1877 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1878
abb71cf4
CY
18792011-05-22 Chong Yidong <cyd@stupidchicken.com>
1880
1881 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1882 (Fx_get_selection_internal): Minor cleanup.
1883 (Fx_own_selection_internal): Rename arguments for consistency with
1884 select.el.
1885
6307db39
PE
18862011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1887
1888 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1889
f3d4e0a4
CY
18902011-05-22 Chong Yidong <cyd@stupidchicken.com>
1891
1892 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1893
4d8ade89
YM
18942011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1895
1896 * dispnew.c (scrolling_window): Don't exclude the case that the
1897 last enabled row in the desired matrix touches the bottom boundary.
1898
32078c8d
GM
18992011-05-21 Glenn Morris <rgm@gnu.org>
1900
1901 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1902 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1903 and add some more files.
32078c8d 1904
7285dc67
EZ
19052011-05-20 Eli Zaretskii <eliz@gnu.org>
1906
1907 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1908 report_file_error introduced by the change from 2011-05-07.
1909
89d1bd22
PE
19102011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1911
1912 * systime.h (Time): Define only if emacs is defined.
1913 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1914 where the include path doesn't have X11/X.h by default. See
1915 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1916
e23640bb 19172011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1918
1919 * composite.c (find_automatic_composition): Fix previous change.
1920
b9704ad9
GM
19212011-05-20 Glenn Morris <rgm@gnu.org>
1922
1923 * lisp.mk: New file, split from Makefile.in.
1924 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1925 (shortlisp): Remove.
1926 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1927
4a720484
GM
19282011-05-19 Glenn Morris <rgm@gnu.org>
1929
1930 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1931 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1932 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1933 (lisp): Set the order to that of loadup.el.
1934 (shortlisp): Make it a copy of $lisp.
1935 (SOME_MACHINE_LISP): Remove.
1936 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1937 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1938
a28d4396
KH
19392011-05-18 Kenichi Handa <handa@m17n.org>
1940
1941 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1942 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1943 (find_automatic_composition): Mostly rewrite for efficiency.
1944
a2b1fa8e
JB
19452011-05-18 Juanma Barranquero <lekktu@gmail.com>
1946
1947 * makefile.w32-in: Update dependencies.
1948
8e1f5610
CS
19492011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1950
1951 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 1952 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1953
7025ee00 19542011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1955
cdfa6eab
PE
1956 Fix some integer overflow issues, such as string length overflow.
1957
06d6db33
PE
1958 * insdel.c (count_size_as_multibyte): Check for string overflow.
1959
2b4560a8
PE
1960 * character.c (lisp_string_width): Check for string overflow.
1961 Use EMACS_INT, not int, for string indexes and lengths; in
1962 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1963 the resulting string length overflows an EMACS_INT; instead,
1964 report a string overflow if no precision given. When checking for
1965 precision exhaustion, use a check that cannot possibly have
1966 integer overflow. (Bug#8675)
1967 * character.h (lisp_string_width): Adjust to new signature.
1968
cb93f9be
PE
1969 * alloc.c (string_overflow): New function.
1970 (Fmake_string): Use it. This doesn't change behavior, but saves
1971 a few bytes and will simplify future changes.
1972 * character.c (string_escape_byte8): Likewise.
1973 * lisp.h (string_overflow): New decl.
1974
1a1f3366
PE
1975 Fixups, following up to the user-interface timestamp change.
1976 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1977 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1978 * msdos.c (mouse_get_pos): Likewise.
1979 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1980 * w32gui.h (Time): Define by including "systime.h" rather than by
1981 declaring it ourselves. (Bug#8664)
1982
d4e3e4d3
PE
1983 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1984 * image.c (clear_image_cache): Likewise.
1985
f6a24d19
PE
1986 * term.c (term_mouse_position): Don't assume time_t wraparound.
1987
08dc5ae6
PE
1988 Be more systematic about user-interface timestamps.
1989 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1990 and sometimes 'EMACS_UINT', to represent these timestamps.
1991 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1992 This makes the code easier to follow, and makes it easier to catch
1993 integer overflow bugs such as Bug#8664.
1994 * frame.c (Fmouse_position, Fmouse_pixel_position):
1995 Use Time, not unsigned long, for user-interface timestamps.
1996 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1997 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1998 * keyboard.h (last_event_timestamp): Likewise.
1999 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2000 * menu.h (xmenu_show): Likewise.
2001 * term.c (term_mouse_position): Likewise.
2002 * termhooks.h (struct input_event.timestamp): Likewise.
2003 (struct terminal.mouse_position_hook): Likewise.
2004 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2005 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2006 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2007 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2008 what it was before.
2009 * menu.h, termhooks.h: Include "systime.h", for Time.
2010
8e55734a
PE
2011 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2012 Don't assume that the difference between two unsigned long values
2013 can fit into an integer. At this point, we know button_down_time
2014 <= event->timestamp, so the difference must be nonnegative, so
2015 there's no need to cast the result if double-click-time is
2016 nonnegative, as it should be; check that it's nonnegative, just in
2017 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2018 apart (about 25 days). (Bug#8664)
8e55734a 2019
841f1b75 2020 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2021 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2022
3e26f69c
PE
2023 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2024 that always fit in int. Use a sentinel instead of a counter, to
2025 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2026 * frame.h (struct frame): Use int for menu_bar_items_used
2027 instead of EMACS_INT, since it always fits in int.
3e26f69c 2028
5cc152c0
PE
2029 * menu.c (grow_menu_items): Check for int overflow.
2030
d89eb65e
PE
2031 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2032
5235bd3e
PE
2033 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2034 Before, the code was not consistent. These values cannot exceed
2035 2**31 - 1 so there's no need to make them unsigned.
2036 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2037 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2038 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2039 as modifiers.
2040 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2041
bc827e23
PE
2042 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2043 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2044 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2045 presumably because the widths might not match.
2046
78eb494e
PE
2047 * window.c (size_window): Avoid needless test at loop start.
2048
04f2d78b
CB
20492011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2050
2051 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2052
d2fc7e3d 20532011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2054
2055 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2056
d2fc7e3d 20572011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2058
2059 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2060 `width' to `bar_area_x' and `bar_area_width', respectively.
2061 (x_scroll_run): Take account of fringe background extension.
2062
04f2d78b
CB
2063 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2064 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2065 `bar_area_width', respectively.
2066 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2067 background extension.
2068
79b70037
GM
20692011-05-10 Jim Meyering <meyering@redhat.com>
2070
2071 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2072
2f142cc5
JB
20732011-05-10 Juanma Barranquero <lekktu@gmail.com>
2074
2075 * image.c (Finit_image_library): Return t for built-in image types,
2076 like pbm and xbm. (Bug#8640)
2077
57679c86
AS
20782011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2079
2080 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2081
888c9e86
EZ
20822011-05-07 Eli Zaretskii <eliz@gnu.org>
2083
b0512a1d
EZ
2084 * w32console.c (Fset_screen_color): Doc fix.
2085 (Fget_screen_color): New function.
2086 (syms_of_ntterm): Defsubr it.
2087
7285dc67
EZ
2088 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2089 unlink the temporary file if Fcall_process didn't create it in the
2090 first place.
2091 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2092 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2093 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2094 cue to call_process_cleanup not to close that handle.
2095
4d3fcc8e
BK
20962011-05-07 Ben Key <bkey76@gmail.com>
2097
2098 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2099 one of two shell specific rules, either bootstrap-temacs-CMD or
2100 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2101 to the previous implementation of the bootstrap-temacs rule.
2102 The bootstrap-temacs-CMD rule is similar to the previous
2103 implementation of the bootstrap-temacs rule except that it
2104 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2105 variable.
2106
2107 These changes, along with some changes to nt/configure.bat,
2108 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2109 earlier fix to add support for --cflags and --ldflags options
2110 that include quotes so that it works whether make uses cmd or
2111 sh as the shell.
2112
b4289b64
MA
21132011-05-06 Michael Albinus <michael.albinus@gmx.de>
2114
2115 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2116 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2117 is a constant.
2118 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2119 a string. Handle both cases.
2120 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2121 (Fdbus_register_method): Use Qinvalid_function.
2122
af4c0e28
JB
21232011-05-06 Juanma Barranquero <lekktu@gmail.com>
2124
2125 * makefile.w32-in: Update dependencies.
2126 (LISP_H): Add inttypes.h and stdin.h.
2127 (PROCESS_H): Add unistd.h.
2128
c51453d9
EZ
21292011-05-06 Eli Zaretskii <eliz@gnu.org>
2130
2131 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2132 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2133
8ff0ac3c 21342011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2135
4c4b566b
PE
2136 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2137
aab2b9b5
PE
2138 * term.c (vfatal): Remove stray call to va_end.
2139 It's not needed and the C Standard doesn't allow it here anyway.
2140
c378da0b
PE
2141 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2142 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2143
288b08c7
PE
2144 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2145 bytes.
2146
e3601888
PE
2147 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2148
db6c0e74
PE
2149 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2150
dd5963ea
PE
2151 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2152
88c9450f
PE
2153 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2154
2f9442b8
PE
2155 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2156
c032b5f8
PE
2157 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2158 * charset.c (Fdefine_charset_internal): Don't initialize
2159 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2160 32-bit int (Bug#8600).
a108c10b
PE
2161
2162 * lread.c (read_integer): Be more consistent with string-to-number.
2163 Use string_to_number to do the actual conversion; this avoids
2164 rounding errors and fixes some other screwups. Without this fix,
2165 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2166 (digit_to_number): Move earlier, for benefit of read_integer.
2167 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2168 not a digit in any supported base. (Bug#8602)
a108c10b 2169
ad5f9eea
PE
2170 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2171
aec1708a
PE
2172 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2173 to match comment at start of function. This also removes a
2174 GCC warning about overflow in a 32+64-bit port.
2175
47be4ab5
PE
2176 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2177
371cac43
PE
2178 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2179 Reported by Stefan Monnier in
2180 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2181 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2182 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2183
d01a7826
PE
2184 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2185 (EMACS_UINTPTR): Likewise, with uintptr_t.
2186
7fd47d5c
PE
2187 * lisp.h: Prefer 64-bit EMACS_INT if available.
2188 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2189 on 32-bit hosts that have 64-bit int, so that they can access
2190 large files.
122b0c86
PE
2191 However, temporarily disable this change unless the temporary
2192 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2193
8727937b
PE
2194 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2195
8ac068ac
PE
2196 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2197 This removes an assumption that EMACS_INT and long are the same
2198 width as pointers. The assumption is true for Emacs porting targets
2199 now, but we want to make other targets possible.
2200 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2201 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2202 In the rest of the code, change types of integers that hold casted
2203 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2204 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2205 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2206 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2207 No need to cast type when ORing.
2208 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2209 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2210 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2211 assume EMACS_INT is the same width as char *.
2212 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2213 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2214 Remove no-longer-needed casts.
2215 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2216 (xg_tool_bar_help_callback, xg_make_tool_item):
2217 Use EMACS_INTPTR to hold an integer
2218 that will be cast to void *; this can avoid a GCC warning
2219 if EMACS_INT is not the same width as void *.
2220 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2221 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2222 (current_message_1, set_message_1):
2223 Use a local to convert to proper width without a cast.
2224 * xmenu.c (dialog_selection_callback): Likewise.
2225
ede49d71
PE
2226 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2227 Also, don't assume VALBITS / RAND_BITS is less than 5,
2228 and don't rely on undefined behavior when shifting a 1 left into
2229 the sign bit.
2230 * lisp.h (get_random): Change signature to match.
2231
2f30ecd0
PE
2232 * lread.c (hash_string): Use size_t, not int, for hash computation.
2233 Normally we prefer signed values; but hashing is special, because
2234 it's better to use unsigned division on hash table sizes so that
2235 the remainder is nonnegative. Also, size_t is the natural width
2236 for hashing into memory. The previous code used 'int', which doesn't
2237 retain enough info to hash well into very large tables.
2238 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2239
2a866e7b
PE
2240 * dbusbind.c: Don't possibly lose pointer info when converting.
2241 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2242 Use XPNTR rather than XHASH, so that the high-order bits of
2243 the pointer aren't lost when converting through void *.
2244
51639eac
PE
2245 * eval.c (Fautoload): Don't double-shift a pointer.
2246
92394119
PE
2247 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2248
dbdb9a7c
JB
22492011-05-06 Juanma Barranquero <lekktu@gmail.com>
2250
2251 * gnutls.c (DEF_GNUTLS_FN):
2252 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2253
db7a0b4f
AS
22542011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2255
2256 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2257 marker. (Bug#8610)
2258
f7ff1b0f 22592011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2260
2261 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2262 New version that can reserve upto 2GB of heap space.
2263
f7ff1b0f 22642011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2265
2266 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2267
639c109b
TZ
22682011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2269
2270 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2271 `gnutls_certificate_set_x509_key_file'.
2272
d2127135
JB
22732011-05-05 Juanma Barranquero <lekktu@gmail.com>
2274
2275 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2276 Update dependencies.
2277
e968f4f3
JB
22782011-05-04 Juanma Barranquero <lekktu@gmail.com>
2279
2280 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2281 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2282 Remove unused parameter `fildes'.
2283 * process.c (read_process_output, send_process): Don't pass it.
2284
84d358f0
JB
22852011-05-04 Juanma Barranquero <lekktu@gmail.com>
2286
2287 Fix previous change: the library cache is defined in w32.c.
2288 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2289 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2290
0898ca10
JB
22912011-05-04 Juanma Barranquero <lekktu@gmail.com>
2292
2293 Implement dynamic loading of GnuTLS on Windows.
2294
2295 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2296 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2297 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2298 Declare.
2299
2300 * gnutls.c (Qgnutls_dll): Define.
2301 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2302 (gnutls_*): Declare function pointers.
2303 (init_gnutls_functions): New function to initialize function pointers.
2304 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2305 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2306 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2307 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2308 (emacs_gnutls_write, emacs_gnutls_read)
2309 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2310 (Fgnutls_available_p): New function.
2311 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2312 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2313 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2314
2315 * image.c: Include w32.h.
2316 (Vimage_type_cache): Delete.
2317 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2318 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2319 (w32_delayed_load): Move to w32.c.
2320
2321 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2322
2323 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2324 (w32_delayed_load): Move from image.c. When loading a library, record
2325 its filename in the :loaded-from property of the library id.
2326 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2327 Initialize and staticpro them.
2328 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2329
2330 * process.c: Include lisp.h before w32.h, not after.
2331 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2332 instead of gnutls_record_check_pending.
2333
2334 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2335
ff4de4aa
TZ
23362011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2337
2338 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2339 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2340 as passed in.
2341
abe95abb
JD
23422011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2343
2344 * xterm.c (x_set_frame_alpha): Do not set property on anything
2345 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2346
e16e55d4
JB
23472011-05-02 Juanma Barranquero <lekktu@gmail.com>
2348
2349 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2350
bafcf6a5
JB
23512011-05-02 Juanma Barranquero <lekktu@gmail.com>
2352
2353 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2354 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2355 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2356 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2357 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2358 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2359 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2360 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2361 (Qgnutls_bootprop_callbacks_verify): Make static.
2362
e7a6747f
AS
23632011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2364
19ed11ba
AS
2365 * callproc.c: Indentation fixup.
2366
e7a6747f 2367 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2368 (wait_for_termination, interruptible_wait_for_termination):
2369 Move after wait_for_termination_1.
e7a6747f 2370
1ef14cb4
LMI
23712011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2372
2373 * sysdep.c (interruptible_wait_for_termination): New function
2374 which is like wait_for_termination, but allows keyboard
2375 interruptions.
2376
2377 * callproc.c (Fcall_process): Add (:file "file") as an option for
2378 the STDOUT buffer.
2379 (Fcall_process_region): Ditto.
2380
330d880c
EZ
23812011-04-30 Eli Zaretskii <eliz@gnu.org>
2382
8db90b73
EZ
2383 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2384 rather than `XVECTOR (FOO)->size'.
2385
330d880c
EZ
2386 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2387 inttypes.h, as a gnulib replacement is used if it not available in
2388 system headers.
2389
15cbd324
EZ
23902011-04-21 Eli Zaretskii <eliz@gnu.org>
2391
2392 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2393 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2394 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2395
2396 * coding.c (coding_alloc_by_realloc): Error out if destination
2397 will grow beyond MOST_POSITIVE_FIXNUM.
2398 (decode_coding_emacs_mule): Abort if there isn't enough place in
2399 charbuf for the composition carryover bytes. Reserve an extra
2400 space for up to 2 characters produced in a loop.
2401 (decode_coding_iso_2022): Abort if there isn't enough place in
2402 charbuf for the composition carryover bytes.
2403
24042011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2405
ae940cca
EZ
2406 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2407 aborting when %lld or %lll format is passed.
2408 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2409 %llo or %llx format is passed. (Bug#8545)
2410
03ab8921
EZ
2411 * window.c (window_scroll_line_based): Use a marker instead of
2412 simple variables to record original value of point. (Bug#7952)
2413
afda1437
EZ
2414 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2415 produced by %s or %c overflows available buffer space. (Bug#8545)
2416
f76dee0c
PE
24172011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2418
2419 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2420 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2421
fdc5744d
JB
24222011-04-28 Juanma Barranquero <lekktu@gmail.com>
2423
2424 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2425
638f053a
JB
24262011-04-28 Juanma Barranquero <lekktu@gmail.com>
2427
2428 * keyboard.c (Qdelayed_warnings_hook): Define.
2429 (command_loop_1): Run `delayed-warnings-hook'
2430 if Vdelayed_warnings_list is non-nil.
2431 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2432 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2433
d178f871
EZ
24342011-04-28 Eli Zaretskii <eliz@gnu.org>
2435
2436 * doprnt.c (doprnt): Don't return value smaller than the buffer
2437 size if the message was truncated. (Bug#8545).
2438
b124fd93
JB
24392011-04-28 Juanma Barranquero <lekktu@gmail.com>
2440
2441 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2442 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2443
e810457d
PE
24442011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2445
2446 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2447
ea51cceb
JB
24482011-04-27 Juanma Barranquero <lekktu@gmail.com>
2449
2450 * makefile.w32-in: Update dependencies.
2451
94dcfacf
EZ
24522011-04-27 Eli Zaretskii <eliz@gnu.org>
2453
2454 Improve `doprnt' and its usage. (Bug#8545)
2455 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2456 `format_end'. Remove support for %l as a conversion specifier.
2457 Don't use xrealloc. Improve diagnostics when the %l size modifier
2458 is used. Update the commentary.
2459
2460 * eval.c (verror): Simplify calculation of size_t.
2461
2462 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2463 messages.
2464
f61f41d7
PE
24652011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2466
2467 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2468 change.
2469
96fb4434
PE
24702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2471
2472 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2473 This makes this file independent of the recent pseudovector change.
2474
671875da 24752011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2476
69e9b5a3
PE
2477 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2478
b5f869a7 2479 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2480 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2481 Remove unused local.
c8926152 2482 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2483
841a1577 2484 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2485 GCC 4.6.0 optimizes based on type-based alias analysis.
2486 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2487 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2488 != &v->size, and therefore "v->size = 1; b->size = 2; return
2489 v->size;" must therefore return 1. This assumption is incorrect
2490 for Emacs, since it type-puns struct Lisp_Vector * with many other
2491 types. To fix this problem, this patch adds a new type struct
f904488f 2492 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2493 and pseudovectors, and helps optimizing compilers not get fooled
2494 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2495 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2496 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2497 the size member.
eab3844f
PE
2498 (XSETPVECTYPE): Rewrite in terms of new macro.
2499 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2500 This is a bit clearer, and further avoids the possibility of
2501 undesirable aliasing.
2502 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2503 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2504 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2505 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2506 (ASIZE): Now uses header.size rather than size.
2507 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2508 to avoid the hassle of writing XVECTOR (foo)->header.size.
2509 (struct vectorlike_header): New type.
eab3844f
PE
2510 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2511 object, to help avoid aliasing.
2512 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2513 (SUBRP): Likewise, since Lisp_Subr is a special case.
2514 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2515 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2516 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2517 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2518 changed to be "header.size" and "header.next".
2519 * buffer.h (struct buffer): Likewise.
2520 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2521 * frame.h (struct frame): Likewise.
2522 * process.h (struct Lisp_Process): Likewise.
2523 * termhooks.h (struct terminal): Likewise.
2524 * window.c (struct save_window_data, struct saved_window): Likewise.
2525 * window.h (struct window): Likewise.
2526 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2527 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2528 * buffer.c (init_buffer_once): Likewise.
2529 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2530 special case.
2531 * process.c (Fformat_network_address): Use local var for size,
2532 for brevity.
2533
0df1eac5
PE
2534 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2535
847ab9d1 2536 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2537 * data.c (atof): Remove decl; no longer used or needed.
2538 (digit_to_number): Move to lread.c.
2539 (Fstring_to_number): Use new string_to_number function, to be
2540 consistent with how the Lisp reader treats infinities and NaNs.
2541 Do not assume that floating-point numbers represent EMACS_INT
2542 without losing information; this is not true on most 64-bit hosts.
2543 Avoid double-rounding errors, by insisting on integers when
2544 parsing non-base-10 numbers, as the documentation specifies.
2545 * lisp.h (string_to_number): New decl, replacing ...
2546 (isfloat_string): Remove.
bc0a5c13 2547 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2548 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2549 appears to have been a coding error. Similarly, do not accept
2550 strings like +-1e0 as floating point numbers. Do not report
2551 overflow for integer overflows unless the base is not 10 which
2552 means we have no simple and reliable way to continue.
2553 Break out the floating-point parsing into a new
2554 function string_to_number, so that Fstring_to_number parses
2555 floating point numbers consistently with the Lisp reader.
04f2d78b 2556 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2557 (E_CHAR, EXP_INT): Remove, replacing with ...
2558 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2559 (string_to_number): New function, replacing isfloat_string.
2560 This function checks for valid syntax and produces the resulting
2561 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2562 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2563 so that overflow for non-base-10 numbers is reported only when
2564 there's no portable and simple way to convert to floating point.
452f4150 2565
67769ffc
PE
2566 * textprop.c (set_text_properties_1): Rewrite for clarity,
2567 and to avoid GCC warning about integer overflow.
2568
c20db43f
PE
2569 * intervals.h (struct interval): Use EMACS_INT for members
2570 where EMACS_UINT might cause problems. See
2571 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2572 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2573 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2574 All uses changed.
37aa2f85
PE
2575 (offset_intervals): Tell GCC not to worry about length overflow
2576 when negating a negative length.
c20db43f 2577
2538aa2f
PE
2578 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2579 (overrun_check_free): Likewise.
2580
f2d3008d
PE
2581 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2582 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2583 word size.
2584
ec8df744
PE
2585 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2586 (gnutls_make_error): Rename local to avoid shadowing.
2587 (gnutls_emacs_global_deinit): ifdef out; not used.
2588 (Fgnutls_boot): Use const for pointer to readonly storage.
2589 Comment out unused local. Fix pointer signedness problems.
2590
640ee02d
PE
2591 * lread.c (openp): Don't stuff size_t into an 'int'.
2592 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2593 about possible signed overflow.
2594
6048fb2a
PE
2595 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2596 (GDK_KEY_g): Don't define if already defined.
2597 (xg_prepare_tooltip): Avoid pointer signedness problem.
2598 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2599
fa3c87e1
PE
2600 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2601 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2602
2172544b
PE
2603 * xfns.c (Fx_window_property): Simplify a bit,
2604 to make a bit faster and to avoid GCC 4.6.0 warning.
2605 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2606
9b821a21
PE
2607 * fns.c (internal_equal): Don't assume size_t fits in int.
2608
3c616cfa
PE
2609 * alloc.c (compact_small_strings): Tighten assertion a little.
2610
c2982e87
PE
2611 Replace pEd with more-general pI, and fix some printf arg casts.
2612 * lisp.h (pI): New macro, generalizing old pEd macro to other
2613 conversion specifiers. For example, use "...%"pI"d..." rather
2614 than "...%"pEd"...".
2615 (pEd): Remove. All uses replaced with similar uses of pI.
2616 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2617 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2618 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2619 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2620 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2621 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2622 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2623 64-bit hosts.
2624 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2625 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2626 * print.c (safe_debug_print, print_object): Likewise.
2627 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2628 to int.
6f04d126
PE
2629 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2630 avoiding the 0 flag, which is not portable.
c2982e87
PE
2631 * process.c (Fmake_network_process): Use pI to avoid cast.
2632 * region-cache.c (pp_cache): Likewise.
2633 * xdisp.c (decode_mode_spec): Likewise.
2634 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2635 behavior on 64-bit hosts with printf arg.
6f04d126 2636 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2637 (x_stop_queuing_selection_requests): Likewise.
2638 (x_get_window_property): Don't truncate byte count to an 'int'
2639 when tracing.
0b432f21 2640
5e073ec7
PE
2641 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2642 here, since it parses constructs like leading '-' and spaces,
2643 which are not wanted; and it overflows with large numbers.
2644 Instead, simply match F[0-9]+, which is what is wanted anyway.
2645
36372bf9
PE
2646 * alloc.c: Remove unportable assumptions about struct layout.
2647 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2648 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2649 (allocate_vectorlike, make_pure_vector): Use the new macros,
2650 plus offsetof, to remove unportable assumptions about struct layout.
2651 These assumptions hold on all porting targets that I know of, but
2652 they are not guaranteed, they're easy to remove, and removing them
2653 makes further changes easier.
2654
0b432f21
PE
2655 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2656 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2657 (string_overrun_cookie): Now const. Use initializers that
2658 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2659 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2660 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2661 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2662 multiple of sizeof (EMACS_INT); it need not be, if
2663 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2664 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2665
895009e1
JB
26662011-04-26 Juanma Barranquero <lekktu@gmail.com>
2667
2668 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2669
6a7a1b0b
TZ
26702011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2671
2672 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2673 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2674 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2675
841a1577 26762011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2677
2678 * lisp.h (Qdebug): List symbol.
895009e1 2679 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2680 * keyboard.c (debug-on-event): New variable.
2681 (handle_user_signal): Break into debugger when debug-on-event
2682 matches the current signal symbol.
2683
f2d3ba6f
DN
26842011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2685
2686 * alloc.c (check_sblock, check_string_bytes)
2687 (check_string_free_list): Convert to standard C.
2688
42ce4c63
TZ
26892011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2690
2691 * w32.c (emacs_gnutls_push): Fix typo.
2692
825cd63c
EZ
26932011-04-25 Eli Zaretskii <eliz@gnu.org>
2694
fb11d64d
EZ
2695 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2696 "cast to pointer from integer of different size".
2697
825cd63c
EZ
2698 Improve doprnt and its use in verror. (Bug#8545)
2699 * doprnt.c (doprnt): Document the set of format control sequences
2700 supported by the function. Use SAFE_ALLOCA instead of always
2701 using `alloca'.
2702
2703 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2704 is one byte too soon. Don't use xrealloc; instead xfree and
2705 xmalloc anew.
2706
e061a11b
TZ
27072011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2708
2709 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2710 callbacks stage.
2711
2712 * gnutls.c: Renamed global_initialized to
2713 gnutls_global_initialized. Added internals for the
2714 :verify-hostname-error, :verify-error, and :verify-flags
2715 parameters of `gnutls-boot' and documented those parameters in the
2716 docstring. Start callback support.
2717 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2718 unless a fatal error occured. Call gnutls_alert_send_appropriate
2719 on error. Return error code.
2720 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2721 (emacs_gnutls_read): Likewise.
2722 (Fgnutls_boot): Return handshake error code.
2723 (emacs_gnutls_handle_error): New function.
2724 (wsaerror_to_errno): Likewise.
2725
2726 * w32.h (emacs_gnutls_pull): Add prototype.
2727 (emacs_gnutls_push): Likewise.
2728
2729 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2730 (emacs_gnutls_push): Likewise.
2731
27322011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2733
2734 * process.c (wait_reading_process_output): Check if GnuTLS
2735 buffered some data internally if no FDs are set for TLS
2736 connections.
2737
2738 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2739 (LIBS): Link to USER_LIBS.
2740 ($(BLD)/gnutls.$(0)): New target.
2741
fa6996bc
EZ
27422011-04-24 Eli Zaretskii <eliz@gnu.org>
2743
eb35682e
EZ
2744 * xdisp.c (handle_single_display_spec): Rename the
2745 display_replaced_before_p argument into display_replaced_p, to
2746 make it consistent with the commentary. Fix typos in the
2747 commentary.
2748
e2ad650c
EZ
2749 * textprop.c (syms_of_textprop): Remove dead code.
2750 (copy_text_properties): Delete obsolete commentary about an
2751 interface that was deleted long ago. Fix typos in the description
2752 of arguments.
2753
1b2de274
EZ
2754 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2755 to changes in oldXMenu/XMenu.h from 2011-04-16.
2756 <menu_help_message, prev_menu_help_message>: Constify.
2757 (IT_menu_make_room): menu->help_text is now `const char **';
2758 adjust.
2759
2760 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2761 to changes in oldXMenu/XMenu.h from 2011-04-16.
2762 (struct XMenu): Declare `help_text' `const char **'.
2763
2764 * xfaces.c <Qunspecified>: Make extern again.
2765
2766 * syntax.c: Include sys/types.h before including regex.h, as
2767 required by Posix.
2768
762b15be
EZ
2769 * doc.c (get_doc_string): Improve the format passed to `error'.
2770
2771 * doprnt.c (doprnt): Improve commentary.
2772
2773 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2774
2775 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2776 them with etags.
2777
f1052e5d
EZ
2778 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2779 changes in globals.h immediately force recompilation.
762b15be
EZ
2780 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2781 $(CURDIR)/s/ms-w32.h.
2782 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2783
fa6996bc
EZ
2784 * character.c (Fchar_direction): Function deleted.
2785 (syms_of_character): Don't defsubr it.
2786 <char-direction-table>: Deleted.
2787
e6c3da20
EZ
27882011-04-23 Eli Zaretskii <eliz@gnu.org>
2789
2790 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2791 * doprnt.c: Include limits.h.
2792 (SIZE_MAX): New macro.
04f2d78b
CB
2793 (doprnt): Return a size_t value. 2nd arg is now size_t.
2794 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2795 Improve overflow protection. Support `l' modifier for integer
2796 conversions. Support %l conversion. Don't assume an EMACS_INT
2797 argument for integer conversions and for %c.
2798
2799 * lisp.h (doprnt): Restore prototype.
2800
2801 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2802 $(SRC)/character.h.
2803
2804 * Makefile.in (base_obj): Add back doprnt.o.
2805
2806 * deps.mk (doprnt.o): Add back prerequisites.
2807 (callint.o): Depend on character.h.
2808
2809 * eval.c (internal_lisp_condition_case): Include the handler
2810 representation in the error message.
2811 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2812 when breaking from the loop.
2813
2814 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2815
2816 * callint.c (Fcall_interactively): When displaying error message
2817 about invalid control letter, pass the character's codepoint, not
2818 a pointer to its multibyte form. Improve display of the character
2819 in octal and display also its hex code.
2820
2821 * character.c (char_string): Use %x to display the (unsigned)
2822 codepoint of an invalid character, to avoid displaying a bogus
2823 negative value.
2824
2825 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2826 `error', not SYMBOL_NAME itself.
2827
2828 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2829 character arguments to `error'.
2830
2831 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2832 to `error' in error message about FINAL_CHAR argument. Make sure
2833 FINAL_CHAR is a character, and use %c when it is passed as
2834 argument to `error'.
2835
4ffd0d6b 28362011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2837
2838 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2839
2840 * w32.c: Include <time.h>.
2841 (sys_localtime): New function.
2842
4ffd0d6b 28432011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2844
2845 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2846
4ffd0d6b 2847 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2848
4ffd0d6b 28492011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2850
4ffd0d6b
GM
2851 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2852 zombies (Bug#8467).
aac0c6e3 2853
04c56954
EZ
28542011-04-19 Eli Zaretskii <eliz@gnu.org>
2855
2856 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2857 gl_state.e_property when gl_state.object is Qt.
2858
2859 * insdel.c (make_gap_larger): Remove limitation of buffer size
2860 to <= INT_MAX.
2861
16a43933
CY
28622011-04-18 Chong Yidong <cyd@stupidchicken.com>
2863
2864 * xdisp.c (lookup_glyphless_char_display)
2865 (produce_glyphless_glyph): Handle cons cell entry in
2866 glyphless-char-display.
2867 (Vglyphless_char_display): Document it.
2868
2869 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2870 glyphless-char-display.
2871
4581706e
CY
28722011-04-17 Chong Yidong <cyd@stupidchicken.com>
2873
2874 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2875
2876 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2877
2878 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2879 definition for no-X builds.
2880
4887c6e2 28812011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2882
fd35b6f9
PE
2883 Static checks with GCC 4.6.0 and non-default toolkits.
2884
5c1ccb01
PE
2885 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2886
006c5daa
PE
2887 * process.c (keyboard_bit_set): Define only if SIGIO.
2888 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2889 (send_process): Repair possible setjmp clobbering.
2890
efc736d3
PE
2891 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2892
4e2fe2e6
PE
2893 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2894
f97334a2
PE
2895 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2896
4e75f29d
PE
2897 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2898 Define only if needed.
2899
90efadd1
PE
2900 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2901 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2902 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2903
3c647824
PE
2904 * dispextern.h (struct redisplay_interface): Rename param
2905 to avoid shadowing.
e264f262 2906 * termhooks.h (struct terminal): Likewise.
761383f4 2907 * xterm.c (xembed_send_message): Likewise.
3c647824 2908
b58c5c4a
PE
2909 * insdel.c (make_gap_smaller): Define only if
2910 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2911
cad59032
PE
2912 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2913 it.
2914
c339dc2e
PE
2915 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2916 so that we aren't warned about unused symbols.
2917
91a3e27b
PE
2918 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2919
399c71d3 2920 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2921
8ffc96f5
PE
2922 * xfns.c (x_real_positions): Mark locals as initialized.
2923
eef9bc79
PE
2924 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2925
098db9dd
PE
2926 * xterm.c: Fix problems found by static analysis with other toolkits.
2927 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2928 (x_dispatch_event): Declare static if USE_GTK, and
2929 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2930 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2931 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2932 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2933 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2934
eb18f6cc
PE
2935 * xmenu.c (menu_help_callback): Pointer type fixes.
2936 Use const pointers when pointing at readonly data. Avoid pointer
2937 signedness clashes.
2938 (FALSE): Remove unused macro.
2939 (update_frame_menubar): Remove unused decl.
2940
1fe72bf8
PE
2941 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2942
60d9e1db
PE
2943 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2944 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2945 (single_menu_item): Rename local to avoid shadowing.
2946
39261c26
PE
2947 * keyboard.c (make_lispy_event): Remove unused local var.
2948
018c5e19
PE
2949 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2950 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2951
63d2b86e
PE
2952 * bitmaps: Change bitmaps from unsigned char back to the X11
2953 compatible char. Avoid the old compiler warnings about
2954 out-of-range initializers by using, for example, '\xab' rather
2955 than 0xab.
2956
aefd87e1
PE
2957 * xgselect.c (xgselect_initialize): Check vs interface
2958 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2959
bf501fb9
PE
2960 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2961
e9829fdf
PE
2962 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2963 to read-only memory.
2964
1086c095
PE
2965 * fns.c (vector): Remove; this old hack is no longer needed.
2966
2baccd04 2967 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2968 Remove unused var.
dde42981 2969 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2970
72391843 2971 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2972
436c16df 2973 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2974 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2975 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2976
92bb796d 2977 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2978 (x_term_init): Remove local to avoid shadowing.
92bb796d 2979
764430a3 2980 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2981
2982 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2983 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2984
d1dfb56c
EZ
29852011-04-16 Eli Zaretskii <eliz@gnu.org>
2986
c4354cb4
EZ
2987 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2988
d1dfb56c
EZ
2989 Fix regex.c, syntax.c and friends for buffers > 2GB.
2990 * syntax.h (struct gl_state_s): Declare character position members
2991 EMACS_INT.
2992
2993 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2994
04f2d78b
CB
2995 * textprop.c (verify_interval_modification, interval_of):
2996 Declare arguments EMACS_INT.
d1dfb56c
EZ
2997
2998 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2999 EMACS_INT.
3000
3001 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3002
3003 * indent.c (Fvertical_motion): Local variable it_start is now
3004 EMACS_INT.
3005
3006 * regex.c (re_match, re_match_2, re_match_2_internal)
3007 (bcmp_translate, regcomp, regexec, print_double_string)
3008 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3009 (re_compile_pattern, re_exec): Declare arguments and local
3010 variables `size_t' and `ssize_t' and return values `regoff_t', as
3011 appropriate.
3012 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3013 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3014 <compile_stack_type>: `size' and `avail' are now `size_t'.
3015
3016 * regex.h <regoff_t>: Use ssize_t, not int.
3017 (re_search, re_search_2, re_match, re_match_2): Arguments that
3018 specify buffer/string position and length are now ssize_t and
3019 size_t. Return type is regoff_t.
3020
613052cd
BK
30212011-04-16 Ben Key <bkey76@gmail.com>
3022
3023 * nsfont.m: Fixed bugs in ns_get_family and
3024 ns_descriptor_to_entity that were caused by using free to
3025 deallocate memory blocks that were allocated by xmalloc (via
3026 xstrdup). This caused Emacs to crash when compiled with
3027 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3028 --enable-checking=xmallocoverrun). xfree is now used to
3029 deallocate these memory blocks.
3030
4170f62f 30312011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3032
71b41406
PE
3033 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3034
9587a89d
PE
3035 emacs_write: Accept and return EMACS_INT for sizes.
3036 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3037 et seq.
3038 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3039 Accept and return EMACS_INT.
3040 (emacs_gnutls_write): Return the number of bytes written on
3041 partial writes.
3042 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3043 (emacs_read, emacs_write): Remove check for negative size, as the
3044 Emacs source code has been audited now.
9587a89d
PE
3045 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3046 (emacs_read, emacs_write): Use it.
273a5f82
PE
3047 * process.c (send_process): Adjust to the new signatures of
3048 emacs_write and emacs_gnutls_write. Do not attempt to store
3049 a byte offset into an 'int'; it might overflow.
9587a89d 3050 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3051
3e047f51
PE
3052 * sound.c: Don't assume sizes fit in 'int'.
3053 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3054 Return EMACS_INT, not int.
3e047f51 3055 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3056 Accept EMACS_INT, not int.
3057 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3058 record read return values.
3059
cc39a9db
BK
30602011-04-15 Ben Key <bkey76@gmail.com>
3061
c9d0ec6d
JB
3062 * keyboard.c (Qundefined): Don't declare static since it is used
3063 in nsfns.m.
3064 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3065 static since they are used in nsfont.m.
cc39a9db 3066
6c60eb9f
SM
30672011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3068
3069 * process.c (Qprocessp): Don't declare static.
3070 * lisp.h (Qprocessp): Declare again.
3071
7990b61a
JB
30722011-04-15 Juanma Barranquero <lekktu@gmail.com>
3073
3074 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3075
5d4cb038
PE
30762011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3077
8bd7b830 3078 Improve C-level modularity by making more things 'static'.
cd64ea1d 3079
e3b27b31
PE
3080 Don't publish debugger-only interfaces to other modules.
3081 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3082 (verify_bytepos, count_markers): Move decls to the only modules
3083 that need them.
3084 * region-cache.h (pp_cache): Likewise.
3085 * window.h (check_all_windows): Likewise.
3086 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3087
5d4cb038
PE
3088 * sysdep.c (croak): Now static, if
3089 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3090 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3091
3092 * alloc.c (refill_memory_reserve): Now static if
3093 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3094 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3095
e87b6180
PE
3096 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3097 Define only if USE_LUCID.
3098
ac64929e
PE
3099 * xrdb.c (x_customization_string, x_rm_string): Now static.
3100
6f37259d
PE
3101 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3102 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3103
1683e3ab
PE
3104 * xdisp.c (draw_row_with_mouse_face): Now static.
3105 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3106
de9c2632
PE
3107 * window.h (check_all_windows): Mark externally visible.
3108
2b96acb7
PE
3109 * window.c (window_deletion_count): Now static.
3110
3111 * undo.c: Make symbols static if they're not exported.
3112 (last_undo_buffer, last_boundary_position, pending_boundary):
3113 Now static.
3114
50436f33
PE
3115 * textprop.c (interval_insert_behind_hooks): Now static.
3116 (interval_insert_in_front_hooks): Likewise.
3117
64520e5c
PE
3118 * term.c: Make symbols static if they're not exported.
3119 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3120 (max_frame_lines, tty_set_terminal_modes):
3121 (tty_reset_terminal_modes, tty_turn_off_highlight):
3122 (get_tty_terminal): Now static.
3123 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3124 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3125 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3126 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3127 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3128
1fa53021
PE
3129 * sysdep.c: Make symbols static if they're not exported.
3130 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3131 Now static.
3132 (sigprocmask_set, full_mask): Remove; unused.
3133 (wait_debugging): Mark as visible.
3134 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3135 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3136
d4b43b22
PE
3137 * syntax.c (syntax_temp): Define only if !__GNUC__.
3138
b7c513d0
PE
3139 * sound.c (current_sound_device, current_sound): Now static.
3140
989b29ad
PE
3141 * search.c (searchbufs, searchbuf_head): Now static.
3142
13a55a78
PE
3143 * scroll.c (scroll_cost): Remove; unused.
3144 * dispextern.h (scroll_cost): Remove decl.
3145
de68a1fc
PE
3146 * region-cache.h (pp_cache): Mark as externally visible.
3147
40ccffa6
PE
3148 * process.c: Make symbols static if they're not exported.
3149 (process_tick, update_tick, create_process, chan_process):
3150 (Vprocess_alist, proc_buffered_char, datagram_access):
3151 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3152 (deactivate_process): Mark defn as static, as well as decl.
3153 * lisp.h (create_process): Remove decl.
3154 * process.h (chan_process, Vprocess_alist): Remove decls.
3155
ad64fc97
PE
3156 * print.c: Make symbols static if they're not exported.
3157 (print_depth, new_backquote_output, being_printed, print_buffer):
3158 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3159 (print_interval, print_number_index, initial_stderr_stream):
3160 Now static.
3161 * lisp.h (Fprinc): Remove decl.
3162 (debug_output_compilation_hack): Mark as externally visible.
3163
adddb265
PE
3164 * sysdep.c (croak): Move decl from here to syssignal.h.
3165 * syssignal.h (croak): Put it here, so the API can be checked when
3166 'croak' is called from dissociate_if_controlling_tty.
3167
1717ede2
PE
3168 * minibuf.c: Make symbols static if they're not exported.
3169 (minibuf_save_list, choose_minibuf_frame): Now static.
3170 * lisp.h (choose_minibuf_frame): Remove decl.
3171
fa5fb2bc
PE
3172 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3173
1e3890d1
PE
3174 * lread.c: Make symbols static if they're not exported.
3175 (read_objects, initial_obarray, oblookup_last_bucket_number):
3176 Now static.
3177 (make_symbol): Remove; unused.
3178 * lisp.h (initial_obarray, make_symbol): Remove decls.
3179
8a1414fa
PE
3180 * keyboard.c: Make symbols static if they're not exported.
3181 (single_kboard, recent_keys_index, total_keys, recent_keys):
3182 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3183 (this_single_command_key_start, echoing, last_auto_save):
3184 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3185 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3186 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3187 (Vlispy_mouse_stem, double_click_count):
3188 Now static.
3189 (force_auto_save_soon): Define only if SIGDANGER.
3190 (ignore_mouse_drag_p): Now static if
3191 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3192 (print_help): Remove; unused.
3193 (stop_character, last_timer_event): Mark as externally visible.
3194 * keyboard.h (ignore_mouse_drag_p): Declare only if
3195 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3196 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3197 * lisp.h (echoing): Remove decl.
3198 (force_auto_save_soon): Declare only if SIGDANGER.
3199 * xdisp.c (redisplay_window): Simplify code, to make it more
3200 obvious that ignore_mouse_drag_p is not accessed if !defined
3201 USE_GTK && !defined HAVE_NS.
3202
93ea6e8f
PE
3203 * intervals.c: Make symbols static if they're not exported.
3204 (merge_properties_sticky, merge_interval_right, delete_interval):
3205 Now static.
3206 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3207
77382fcc
PE
3208 * insdel.c: Make symbols static if they're not exported.
3209 However, leave prepare_to_modify_buffer alone. It's never
3210 called from outside this function, but that appears to be a bug.
3211 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3212 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3213 (adjust_after_replace_noundo): Remove; unused.
3214 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3215 (signal_before_change): Remove decls.
77382fcc 3216
9306c32e
PE
3217 * indent.c (val_compute_motion, val_vmotion): Now static.
3218
cd44d2eb
PE
3219 * image.c: Make symbols static if they're not exported.
3220 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3221 if USE_GTK.
3222 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3223 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3224
ad9a7a06
PE
3225 * fringe.c (standard_bitmaps): Now static.
3226 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3227
81626931
PE
3228 * frame.c: Make symbols static if they're not exported.
3229 (x_report_frame_params, make_terminal_frame): Now static.
3230 (get_frame_param): Now static, unless HAVE_NS.
3231 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3232 (x_get_resource_string): Remove; not used.
3233 * frame.h (make_terminal_frame, x_report_frame_params):
3234 (x_get_resource_string); Remove decls.
3235 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3236 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3237
239f9db9
PE
3238 * font.c, fontset.c: Make symbols static if they're not exported.
3239 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3240 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3241 * font.c (font_close_object): Now static.
3242 * font.h (font_close_object): Remove.
3243 * fontset.c (FONTSET_OBJLIST): Remove.
3244 (free_realized_fontset) #if-0 the body, which does nothing.
3245 (face_suitable_for_char_p): #if-0, as it's never called.
3246 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3247 * xfaces.c (face_at_string_position):
3248 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3249 since 0 is always ASCII.
3250
dfcf3579
PE
3251 * fns.c (weak_hash_tables): Now static.
3252
5045092b
PE
3253 * fileio.c: Make symbols static if they're not exported.
3254 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3255 (Vwrite_region_annotation_buffers): Now static.
3256
57a96f5c
PE
3257 * eval.c: Make symbols static if they're not exported.
3258 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3259 * lisp.h (backtrace_list): Remove decl.
3260
35f08c38
PE
3261 * emacs.c: Make symbols static if they're not exported.
3262 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3263 (fatal_error_code, fatal_error_signal_hook, standard_args):
3264 Now static.
3265 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3266 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3267 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3268 * lisp.h (fatal_error_signal_hook): Remove decl.
3269 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3270
f44bd759
PE
3271 * editfns.c: Move a (normally-unused) function to its only use.
3272 * editfns.c, lisp.h (get_operating_system_release): Remove.
3273 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3274 worth the hassle of breaking this out.
3275
b532497d
PE
3276 * xterm.c: Make symbols static if they're not exported.
3277 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3278 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3279 (x_destroy_window, x_delete_display):
3280 Now static.
3281 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3282 (x_mouse_leave): Remove; unused.
3283 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3284 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3285 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3286 Remove decls.
3287 (x_mouse_leave): Declare only if WINDOWSNT.
3288 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3289 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3290 USE_X_TOOLKIT.
3291
1675728f
PE
3292 * ftxfont.c: Make symbols static if they're not exported.
3293 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3294 HAVE_FREETYPE.
3295 * font.h (ftxfont_driver): Likewise.
3296
e4cebfca
PE
3297 * xfns.c: Make symbols static if they're not exported.
3298 (x_last_font_name, x_display_info_for_name):
3299 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3300 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3301 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3302 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3303 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3304 (last_show_tip_args): Now static.
3305 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3306 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3307 (x_screen_planes): Remove; unused.
3308 * dispextern.h (x_screen_planes): Remove decl.
3309
5bf46f05
PE
3310 * dispnew.c: Make symbols static if they're not exported.
3311 * dispextern.h (redraw_garbaged_frames, scrolling):
3312 (increment_row_positions): Remove.
3313 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3314 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3315 Now static.
3316 (redraw_garbaged_frames): Remove; unused.
3317
435f4c28
PE
3318 * xfaces.c: Make symbols static if they're not exported.
3319 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3320 Remove decls.
3321 * xterm.h (defined_color): Remove decls.
3322 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3323 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3324 (menu_face_changed_default, defined_color, free_realized_face):
3325 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3326 (ascii_face_of_lisp_face): Remove; unused.
3327
8524aef3
PE
3328 * xdisp.c: Make symbols static if they're not exported.
3329 * dispextern.h (scratch_glyph_row, window_box_edges):
3330 (glyph_to_pixel_coords, set_cursor_from_row):
3331 (get_next_display_element, set_iterator_to_next):
3332 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3333 (show_mouse_face): Remove decls
3334 * frame.h (message_buf_print): Likewise.
3335 * lisp.h (pop_message, set_message, check_point_in_composition):
3336 Likewise.
3337 * xterm.h (set_vertical_scroll_bar): Likewise.
3338 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3339 (message_buf_print, scratch_glyph_row, displayed_buffer):
3340 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3341 (get_next_display_element, show_mouse_face, window_box_edges):
3342 (frame_to_window_pixel_xy, check_point_in_composition):
3343 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3344 (glyph_to_pixel_coords): Remove; unused.
3345
16390cd2
PE
3346 * dired.c (file_name_completion): Now static.
3347
3348 * dbusbind.c (xd_in_read_queued_messages): Now static.
3349
a25f4dfa
PE
3350 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3351 * data.c (circular_list_error): Remove.
3352
14a9c8df
PE
3353 * commands.h (last_point_position, last_point_position_buffer):
3354 (last_point_position_window): Remove decls.
3355 * keyboard.c: Make these variables static.
3356
04f2d78b
CB
3357 * coding.h (coding, code_convert_region, encode_coding_gap):
3358 Remove decls.
74ab6df5
PE
3359 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3360 (iso_code_class, detect_coding, code_convert_region): Now static.
3361 (encode_coding_gap): Remove; unused.
3362
38dfbee1
PE
3363 * chartab.c (chartab_chars, chartab_bits): Now static.
3364
a2cb4e63
PE
3365 * charset.h (charset_iso_8859_1): Remove decl.
3366 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3367 Now static.
3368
127198fd
PE
3369 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3370 * ccl.c (Vccl_program_table): Now static.
3371 (check_ccl_update): Remove; unused.
3372
d85b608f
PE
3373 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3374 * category.h: ... from here.
3375 * category.c (check_category_table, set_category_set): Now static.
3376
31cd66f3
PE
3377 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3378 * lisp.h: Remove these decls.
3379
c358e587
PE
3380 * buffer.c (buffer_count): Remove unused var.
3381
e78aecca
PE
3382 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3383 so that it's not optimized away.
3384 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3385 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3386 exported only to the debugger.
3387
e192d7d3 3388 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3389 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3390
92470028
PE
3391 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3392 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3393 was inaccessible from Lisp.
3394 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3395 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3396
244ed907
PE
3397 alloc.c: Import and export fewer symbols, and remove unused items.
3398 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3399 is defined.
3400 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3401 it's not optimized away by whole-program optimization.
3402 (message_enable_multibyte, free_misc): Remove.
3403 (catchlist, handlerlist, mark_backtrace):
3404 Declare only if BYTE_MARK_STACK.
3405 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3406 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3407 (message_enable_multibyte): Remove decl.
3408 (free_misc, interval_free_list, float_block, float_block_index):
3409 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3410 (cons_free_list, last_marked_index):
3411 Now static.
3412 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3413 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3414 (mark_backtrace): Define only if BYTE_MARK_STACK.
3415 * xdisp.c (message_enable_multibyte): Now static.
3416
61c2b50e 3417 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3418 This makes it easier for human readers (and static analyzers)
3419 to see whether these variables are used from other modules.
3420 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3421 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3422 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3423 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3424 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3425 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3426 * xmenu.c, xselect.c:
3427 Declare Q* vars static if they are not used in other modules.
3428 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3429 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3430 Remove decls of unexported vars.
3431 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3432
95c82688
PE
3433 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3434
16a97296
PE
3435 Make Emacs functions such as Fatom 'static' by default.
3436 This makes it easier for human readers (and static analyzers)
3437 to see whether these functions can be called from other modules.
3438 DEFUN now defines a static function. To make the function external
3439 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3440 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3441 (Finit_image_library):
16a97296
PE
3442 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3443 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3444 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3445 Remove decls, since these functions are now static.
3446 (Funintern, Fget_internal_run_time): New decls, since these functions
3447 were already external.
95c82688 3448
16a97296
PE
3449 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3450 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3451 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3452 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3453 * keyboard.c, keymap.c, lread.c:
3454 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3455 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3456 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3457 Mark functions with DEFUE instead of DEFUN,
3458 if they are used in other modules.
3459 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3460 decls for now-static functions.
3461 * buffer.h (Fdelete_overlay): Remove decl.
3462 * callproc.c (Fgetenv_internal): Mark as internal.
3463 * composite.c (Fremove_list_of_text_properties): Remove decl.
3464 (Fcomposition_get_gstring): New forward static decl.
3465 * composite.h (Fcomposite_get_gstring): Remove decl.
3466 * dired.c (Ffile_attributes): New forward static decl.
3467 * doc.c (Fdocumntation_property): New forward static decl.
3468 * eval.c (Ffetch_bytecode): New forward static decl.
3469 (Funintern): Remove extern decl; now in .h file where it belongs.
3470 * fileio.c (Fmake_symbolic_link): New forward static decl.
3471 * image.c (Finit_image_library): New forward static decl.
3472 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3473 * intervals.h (Fprevious_property_change):
3474 (Fremove_list_of_text_properties): Remove decls.
3475 * keyboard.c (Fthis_command_keys): Remove decl.
3476 (Fcommand_execute): New forward static decl.
3477 * keymap.c (Flookup_key): New forward static decl.
3478 (Fcopy_keymap): Now static.
3479 * keymap.h (Flookup_key): Remove decl.
3480 * process.c (Fget_process): New forward static decl.
3481 (Fprocess_datagram_address): Mark as internal.
3482 * syntax.c (Fsyntax_table_p): New forward static decl.
3483 (skip_chars): Remove duplicate decl.
3484 * textprop.c (Fprevious_property_change): New forward static decl.
3485 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3486 Now internal.
3487 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3488 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3489
785bbd42
PE
3490 * editfns.c (Fformat): Remove unreachable code.
3491
8b913b57
AS
34922011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3493
3494 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3495 change. (Bug#8496)
3496
a6744a35
EZ
34972011-04-13 Eli Zaretskii <eliz@gnu.org>
3498
3499 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3500 when at ZV. (Bug#8487)
3501
e7974947
AS
35022011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3503
baad03f0
AS
3504 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3505 (Bug#8437)
3506 * keyboard.c (parse_tool_bar_item): Likewise.
3507 * sound.c (sound_cleanup, alsa_close): Likewise.
3508 * termcap.c (tgetent): Likewise.
3509 * xfns.c (x_default_font_parameter): Likewise.
3510 * xsettings.c (read_and_apply_settings): Likewise.
3511
e7974947
AS
3512 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3513 (overrun_check_free): Protoize.
3514
28272684
PE
35152011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3516
3517 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3518 since callers should never pass a negative size.
3519 Change the signature to match that of plain 'read' and 'write'; see
3520 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3521 * lisp.h: Update prototypes of emacs_write and emacs_read.
3522
11997c76
EZ
35232011-04-11 Eli Zaretskii <eliz@gnu.org>
3524
3525 * xdisp.c (redisplay_window): Don't try to determine the character
3526 position of the scroll margin if the window start point w->startp
e896f03c 3527 is outside the buffer's accessible region. (Bug#8468)
11997c76 3528
8a2cbd72
EZ
35292011-04-10 Eli Zaretskii <eliz@gnu.org>
3530
3531 Fix write-region and its subroutines for buffers > 2GB.
3532 * fileio.c (a_write, e_write): Modify declaration of arguments and
3533 local variables to support buffers larger than 2GB.
3534 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3535
3536 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3537 argument, local variables, and return value.
3538
3539 * lisp.h: Update prototypes of emacs_write and emacs_read.
3540
3541 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3542
4073e537 35432011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3544
1ebfdcb6
PE
3545 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3546
b2ded58d
PE
3547 Fix more problems found by GCC 4.6.0's static checks.
3548
7d66342c
PE
3549 * xdisp.c (vmessage): Use a better test for character truncation.
3550
bbf47d44
PE
3551 * charset.c (load_charset_map): <, not <=, for optimization,
3552 and to avoid potential problems with integer overflow.
9248994d 3553 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3554 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3555 * editfns.c (Fformat): Likewise.
1e69125e 3556 * syntax.c (skip_chars): Likewise.
3befa583 3557
e3019616
PE
3558 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3559 This also lets GCC 4.6.0 generate slightly better loop code.
3560
becfa255
PE
3561 * callint.c (Fcall_interactively): <, not <=, for optimization.
3562 (Fcall_interactively): Count the number of arguments produced,
3563 not the number of arguments given. This is simpler and lets GCC
3564 4.6.0 generate slightly better code.
3565
dae0cd48
PE
3566 * ftfont.c: Distingish more carefully between FcChar8 and char.
3567 The previous code passed unsigned char * to a functions like
3568 strlen and xstrcasecmp that expect char *, which does not
3569 conform to the C standard.
3570 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3571 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3572 char * when the C standard requires it.
3573
76032d70
PE
3574 * keyboard.c (read_char): Remove unused var.
3575
eb3f1cc8
PE
3576 * eval.c: Port to Windows vsnprintf (Bug#8435).
3577 Include <limits.h>.
3578 (SIZE_MAX): Define if the headers do not.
3579 (verror): Do not give up if vsnprintf returns a negative count.
3580 Instead, grow the buffer. This ports to Windows vsnprintf, which
3581 does not conform to C99. Problem reported by Eli Zaretskii.
3582 Also, simplify the allocation scheme, by avoiding the need for
3583 calling realloc, and removing the ALLOCATED variable.
3584
70476b54
PE
3585 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3586
12020a9e
PE
3587 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3588 But keep the doprint source code for now, as we might revamp it
3589 and use it again (Bug#8435).
ea6c7ae6
PE
3590 * lisp.h (doprnt): Remove.
3591 * Makefile.in (base_obj): Remove doprnt.o.
3592 * deps.mk (doprnt.o): Remove.
3593
5fdb398c
PE
3594 error: Print 32- and 64-bit integers portably (Bug#8435).
3595 Without this change, on typical 64-bit hosts error ("...%d...", N)
3596 was used to print both 32- and 64-bit integers N, which relied on
3597 undefined behavior.
3598 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3599 New macro.
3600 * lisp.h (error, verror): Mark as printf-like functions.
3601 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3602 Report overflow in size calculations when allocating printf buffer.
3603 Do not truncate output string at its first null byte.
3604 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3605 Truncate the output at a character boundary, since vsnprintf does not
3606 do that.
3607 * charset.c (check_iso_charset_parameter): Convert internal
3608 character to string before calling 'error', since %c now has the
3609 printf meaning.
3610 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3611 overflow when computing char to be passed to 'error'. Do not
3612 pass Lisp_Object to 'error'; pass the integer instead.
3613 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3614 formatted with plain %d.
3615
b189fa66
PE
3616 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3617
bff87ef0
PE
3618 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3619
7e2cac20
PE
3620 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3621
ce4d90b5
PE
3622 * xterm.c (x_catch_errors): Remove duplicate declaration.
3623
266c9547
PE
3624 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3625
79c49ad2
PE
3626 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3627
368f4090
JM
36282011-04-10 Jim Meyering <meyering@redhat.com>
3629
3630 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3631 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3632 return ssize_t not "int", and use size_t as the buffer length.
3633 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3634 * gnutls.h: Update declarations.
3635 * process.c (read_process_output): Use ssize_t, to match.
3636 (send_process): Likewise.
3637
a32d4040
CY
36382011-04-09 Chong Yidong <cyd@stupidchicken.com>
3639
3640 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3641
8546720e 36422011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3643
04f2d78b
CB
3644 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3645 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3646
8546720e
GM
3647 * xterm.c (handle_one_xevent):
3648 * xmenu.c (create_and_show_popup_menu):
3649 * xselect.c (x_decline_selection_request)
3650 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3651
0a2f5c1a 36522011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3653
3654 Fix some uses of `int' instead of EMACS_INT.
3655 * search.c (string_match_1, fast_string_match)
3656 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3657 (scan_buffer, find_next_newline_no_quit)
3658 (find_before_next_newline, search_command, Freplace_match)
3659 (Fmatch_data): Make some `int' variables be EMACS_INT.
3660
3661 * xdisp.c (display_count_lines): 3rd argument and return value now
3662 EMACS_INT. All callers changed.
3663 (pint2hrstr): Last argument is now EMACS_INT.
3664
3665 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3666 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3667 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3668 (decode_coding_utf_16, decode_coding_emacs_mule)
3669 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3670 (decode_coding_ccl, decode_coding_charset)
3671 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3672 (decode_coding_iso_2022, decode_coding_emacs_mule)
3673 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3674 <char_offset, last_offset>: Declare EMACS_INT.
3675 (encode_coding_utf_8, encode_coding_utf_16)
3676 (encode_coding_emacs_mule, encode_invocation_designation)
3677 (encode_designation_at_bol, encode_coding_iso_2022)
3678 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3679 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3680 Declare EMACS_INT.
3681 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3682 (encode_invocation_designation): Last argument P_NCHARS is now
3683 EMACS_INT.
3684 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3685 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3686
3687 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3688 All users changed.
3689
3690 * ccl.c (Fccl_execute_on_string): Declare some variables
3691 EMACS_INT.
3692
8546720e 36932011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3694
3695 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3696
4e19a977
CS
36972011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3698
3699 * process.c (Fformat_network_address): Doc fix.
3700
87302331
R
37012011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3702
3703 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3704
cbb59342
CY
37052011-04-08 Chong Yidong <cyd@stupidchicken.com>
3706
3707 * keyboard.c (read_char): Call Lisp function help-form-show,
3708 instead of using internal_with_output_to_temp_buffer.
3709 (Qhelp_form_show): New var.
e0d38eeb 3710 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3711
3712 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3713
3714 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3715
e67a13ab
CY
37162011-04-06 Chong Yidong <cyd@stupidchicken.com>
3717
04f2d78b
CB
3718 * process.c (Flist_processes): Remove to Lisp.
3719 (list_processes_1): Delete.
e67a13ab 3720
973f782d
EZ
37212011-04-06 Eli Zaretskii <eliz@gnu.org>
3722
7c106b1e
EZ
3723 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3724
973f782d
EZ
3725 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3726
41cf7d1a 37272011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3728
ca23cc88
PE
3729 Fix more problems found by GCC 4.6.0's static checks.
3730
f390e2d5
PE
3731 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3732
42eea0d0
PE
3733 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3734
b69769da 3735 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3736
f9541e84
PE
3737 * xdisp.c (vmessage): Mark as a printf-like function.
3738
13841b55
PE
3739 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3740
c136c10f
PE
3741 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3742
5e2d4a30
PE
3743 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3744 printf-like functions.
3745 (tiff_load): Add casts to remove these marks before passing them
3746 to system-supplied API.
3747
583f48b9
PE
3748 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3749
b25d760e
PE
3750 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3751 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3752 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3753 directly, rather than having caller test rule sign. This avoids
3754 some unnecessary tests.
3755 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3756 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3757 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3758
bc7b6697 3759 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3760 (xfont_open): Avoid unnecessary tests.
bc7b6697 3761
27ccc379
PE
3762 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3763
dcd5c89a
PE
3764 * composite.h, composite.c (composition_gstring_put_cache):
3765 Use EMACS_INT, not int, for length.
3766
b13a45c6
PE
3767 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3768 breaking out part of COMPOSITION_DECODE_RULE.
3769 (COMPOSITION_DECODE_RULE): Use it.
3770 * composite.c (get_composition_id): Remove unused local vars,
3771 by using the new macro.
3772
1e792e4d
PE
3773 * textprop.c (set_text_properties_1): Change while to do-while,
3774 since the condition is always true at first.
3775
dc6c6455 3776 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3777 (interval_deletion_adjustment): Return unsigned value.
3778 All uses changed.
dc6c6455 3779
aba7731a
PE
3780 * process.c (list_processes_1, create_pty, read_process_output):
3781 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3782 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3783 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3784 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3785 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3786
fdfc4bf3
PE
3787 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3788
fca8fe46 3789 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3790 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3791
06a0259a 3792 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3793 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3794 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3795
e7b9e80f
PE
3796 * print.c (print_error_message): Avoid int overflow.
3797
56201685
PE
3798 * font.c (font_list_entities): Redo for clarity,
3799 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3800
78834453 3801 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3802 (font_score): Avoid potential overflow in diff calculation.
78834453 3803
0bc0b309 3804 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3805 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3806
e610eaca
PE
3807 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3808
b895abce
PE
3809 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3810 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3811 can always succeed if overflow has undefined behavior.
3812
1f1d9321 3813 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3814 (wordify): Omit three unnecessary tests.
1f1d9321 3815
c59478bc
PE
3816 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3817 All callers changed. This avoids the need for an unused var.
3818
79b73827
PE
3819 * casefiddle.c (casify_region): Remove var that is set but not used.
3820
a4db5dfe
PE
3821 * dired.c (file_name_completion): Remove var that is set but not used.
3822
43aae36e
PE
3823 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3824
2a47c44d 3825 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3826 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3827
a37c69bf
PE
3828 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3829 Check for integer overflow on size calculations.
3830
328ab8e7
PE
3831 * buffer.c (Fprevious_overlay_change): Remove var that is set
3832 but not used.
3833
e5a2a5cb
PE
3834 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3835 Remove vars that are set but not used.
8d84a6eb 3836 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3837 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3838
a60e5f68
PE
3839 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3840
f661cb61 3841 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3842 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3843
f0397f5a
PE
3844 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3845 that are set but not used.
3846
8664db06 3847 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3848 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3849
6abdaa4a
PE
3850 * xselect.c (x_get_local_selection, x_handle_property_notify):
3851 Remove vars that are set but not used.
3852
0ce7538d 3853 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3854 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3855
9ae848fc
PE
3856 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3857 Remove var that is set but not used.
0b918413
PE
3858 (scroll_bar_windows_size): Now size_t, not int.
3859 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3860 Check for overflow.
9ae848fc 3861
a5a62657
PE
3862 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3863 (map_tty_color) [!defined MSDOS]: Likewise.
3864
5c5cdd39
PE
3865 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3866
66ebf983
PE
3867 * coding.c: Remove vars that are set but not used.
3868 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3869 All callers changed.
3870 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3871 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3872 (decode_coding_charset): Remove vars that are set but not used.
3873
1be4d761
PE
3874 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3875 that is set but not used.
3876
47553fa8
PE
3877 * print.c (print_object): Remove var that is set but not used.
3878
1f7196bf 3879 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3880 The gnulib version avoids calling malloc in the usual case,
3881 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3882 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3883 * filelock.c (current_lock_owner): Likewise.
3884 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3885 * sysdep.c: Include allocator.h, careadlinkat.h.
3886 (emacs_no_realloc_allocator): New static constant.
3887 (emacs_readlink): New function.
fdb61804
PE
3888 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3889 ../lib/careadlinkat.h.
d1fdcab7 3890
f84c17c7
SM
38912011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3892
3893 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3894 first non-nil return value).
3895
ef3862ad
JD
38962011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3897
3898 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3899 if not defined (Bug#8403).
3900
376a7006
JB
39012011-04-02 Juanma Barranquero <lekktu@gmail.com>
3902
3903 * xdisp.c (display_count_lines): Remove parameter `start',
3904 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3905 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3906 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3907 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3908 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3909 and thereabouts. All callers changed.
3910 (get_per_char_metric): Remove parameter `f', unused since
3911 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3912
6ca3801d
JM
39132011-04-02 Jim Meyering <meyering@redhat.com>
3914
3915 do not dereference NULL upon failed strdup
3916 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3917 (ns_get_family): Likewise.
3918
d8e2b5ba
JB
39192011-04-02 Juanma Barranquero <lekktu@gmail.com>
3920
3921 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3922
8c74fcbd
JD
39232011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3924
3925 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3926 later (Bug#8403).
3927
7200d79c
SM
39282011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3929
03408648 3930 Add lexical binding.
7200d79c 3931
03408648
SM
3932 * window.c (Ftemp_output_buffer_show): New fun.
3933 (Fsave_window_excursion):
3934 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3935
3936 * lread.c (lisp_file_lexically_bound_p): New function.
3937 (Fload): Bind Qlexical_binding.
3938 (readevalloop): Remove `evalfun' arg.
3939 Bind Qinternal_interpreter_environment.
3940 (Feval_buffer): Bind Qlexical_binding.
3941 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3942 Mark as dynamic.
3943 (syms_of_lread): Declare `lexical-binding'.
3944
3945 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3946
3947 * keyboard.c (eval_dyn): New fun.
3948 (menu_item_eval_property): Use it.
ca105506
SM
3949
3950 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3951
03408648
SM
3952 * fns.c (concat, mapcar1): Accept byte-code-functions.
3953
3954 * eval.c (Fsetq): Handle lexical vars.
3955 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3956 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3957 (FletX, Flet): Obey lexical binding.
3958 (Fcommandp): Handle closures.
3959 (Feval): New `lexical' arg.
3960 (eval_sub): New function extracted from Feval. Use it almost
3961 everywhere where Feval was used. Look up vars in lexical env.
3962 Handle closures.
3963 (Ffunctionp): Move from subr.el.
3964 (Ffuncall): Handle closures.
3965 (apply_lambda): Remove `eval_flags'.
3966 (funcall_lambda): Handle closures and new byte-code-functions.
3967 (Fspecial_variable_p): New function.
3968 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3969 but without exporting it to Lisp.
23aba0ea 3970
23aba0ea 3971 * doc.c (Fdocumentation, store_function_docstring):
03408648 3972 * data.c (Finteractive_form): Handle closures.
23aba0ea 3973
03408648
SM
3974 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3975 interactive spec.
ba83908c 3976
04f2d78b
CB
3977 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3978 New byte-codes.
03408648
SM
3979 (exec_byte_code): New function extracted from Fbyte_code to handle new
3980 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3981
03408648 3982 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3983
03408648 3984 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3985
e2abce01
JB
39862011-03-31 Juanma Barranquero <lekktu@gmail.com>
3987
3988 * xdisp.c (redisplay_internal): Fix prototype.
3989
63696a73 39902011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3991
63696a73 3992 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3993 (try_scrolling): Use it when setting scroll_limit.
3994 Limit scrolling to 100 screen lines.
63696a73
EZ
3995 (redisplay_window): Even when falling back on "recentering",
3996 position point in the window according to scroll-conservatively,
3997 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3998
3999 (try_scrolling): When point is above the window, allow searching
4000 as far as scroll_max, or one screenful, to compute vertical
4001 distance from PT to the scroll margin position. This prevents
4002 try_scrolling from unnecessarily failing when
4003 scroll-conservatively is set to a value slightly larger than the
4004 window height. Clean up the case of PT below the margin at bottom
4005 of window: scroll_max can no longer be INT_MAX. When aggressive
4006 scrolling is in use, don't let point enter the opposite scroll
4007 margin as result of the scroll.
4008 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4009 threshold of 100 lines for never-recentering scrolling.
4010
e4cc2dfc
JB
40112011-03-31 Juanma Barranquero <lekktu@gmail.com>
4012
4013 * dispextern.h (move_it_by_lines):
4014 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4015 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4016 (message_log_check_duplicate): Remove parameters `prev_bol' and
4017 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4018 (redisplay_internal): Remove parameter `preserve_echo_area',
4019 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4020
4021 * indent.c (Fvertical_motion):
4022 * window.c (window_scroll_pixel_based, Frecenter):
4023 Don't pass `need_y_p' to `move_it_by_lines'.
4024
1c470562
SM
40252011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4026
44f230aa
SM
4027 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4028 steal a few bits to be more compact.
4029 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4030 Remove unneeded casts.
4031
1c470562
SM
4032 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4033
888adce9
ZK
40342011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4035
4036 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4037 binding" message (bug#7967).
4038
f838ed7b
PE
40392011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4040
77861b95
PE
4041 Fix more problems found by GCC 4.6.0's static checks.
4042
de6dbc14
PE
4043 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4044 Remove unused local var.
4045
f838ed7b
PE
4046 * editfns.c (Fmessage_box): Remove unused local var.
4047
792c7b2b
PE
4048 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4049 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4050 Omit unused local vars.
c499e557 4051 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4052 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4053 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4054 Omit unused local var.
4055
ba0165e1
PE
4056 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4057 Don't assume string length fits in int.
32ad8845 4058 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4059 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4060
3c59b4c9
PE
4061 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4062 instead of alloca (Bug#8344).
4063
a3eed478 4064 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4065 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4066
eb4d412d
PE
4067 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4068
1658b401
PE
4069 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4070 concerns.
4071
4072 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4073
4074 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4075
9a2c6e05
PE
4076 * keyboard.c (syms_of_keyboard): Use the same style as later
4077 in this function when indexing through an array. This also
4078 works around GCC bug 48267.
4079
03d0a109
PE
4080 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4081
44f730c8
PE
4082 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4083
fe75f926
PE
4084 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4085 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4086
ffa8c828
PE
4087 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4088 This avoids undefined behavior on integer overflow, and is a bit
4089 more convenient anyway since it is compared to a size_t variable.
4090
c5101a77
PE
4091 Variadic C functions now count arguments with size_t, not int.
4092 This avoids an unnecessary limitation on 64-bit machines, which
4093 caused (substring ...) to crash on large vectors (Bug#8344).
4094 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4095 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4096 All variadic functions and their callers changed accordingly.
c5101a77
PE
4097 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4098 * data.c (arith_driver, float_arith_driver): Likewise.
4099 * editfns.c (general_insert_function): Likewise.
4100 * eval.c (struct backtrace.nargs, interactive_p)
4101 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4102 (funcall_lambda, mark_backtrace): Likewise.
4103 * fns.c (concat): Likewise.
4104 * frame.c (x_set_frame_parameters): Likewise.
4105 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4106 0 if not found, not -1. All callers changed.
4107
dd3f25f7
PE
4108 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4109 (stack_copy_size): Now size_t, not int.
4110 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4111
461c2ab9
JB
41122011-03-28 Juanma Barranquero <lekktu@gmail.com>
4113
4114 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4115 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4116 All callers changed.
4117
4118 * lisp.h (multibyte_char_to_unibyte):
4119 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4120 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4121 * character.h (CHAR_TO_BYTE8):
4122 * cmds.c (internal_self_insert):
4123 * editfns.c (general_insert_function):
4124 * keymap.c (push_key_description):
4125 * search.c (Freplace_match):
4126 * xdisp.c (message_dolog, set_message_1): All callers changed.
4127
f6d62986
SM
41282011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4129
4130 * keyboard.c (safe_run_hook_funcall): New function.
4131 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4132 don't set the hook to nil, but remove the offending function instead.
4133 (Qcommand_hook_internal): Remove, unused.
4134 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4135 Vcommand_hook_internal.
4136
4137 * eval.c (enum run_hooks_condition): Remove.
4138 (funcall_nil, funcall_not): New functions.
4139 (run_hook_with_args): Call each function through a `funcall' argument.
4140 Remove `cond' argument, now redundant.
4141 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4142 (Frun_hook_with_args_until_failure): Adjust accordingly.
4143 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4144
1db5b1ad
JB
41452011-03-28 Juanma Barranquero <lekktu@gmail.com>
4146
4147 * dispextern.h (string_buffer_position): Remove declaration.
4148
4149 * print.c (strout): Remove parameter `multibyte', unused since
4150 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4151
4152 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4153 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4154 All callers changed.
4155
4156 * w32.c (_wsa_errlist): Use braces for struct initializers.
4157
4158 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4159 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4160 All callers changed.
4161 (string_buffer_position): Likewise. Also, make static (it's never
4162 used outside xdisp.c).
4163 (cursor_row_p): Remove parameter `w', unused since
4164 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4165 (decode_mode_spec): Remove parameter `precision', introduced during
4166 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4167 All callers changed.
4168
5ffb62aa
JD
41692011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4170
4171 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4172
461c2ab9 41732011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4174
4175 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4176 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4177 (ns_update_auto_hide_menu_bar): New functions.
4178 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4179 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4180 ns_constrain_all_frames.
4181 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4182 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4183
5c380ffb
JD
41842011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4185
4186 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4187
9af30bdf
GM
41882011-03-27 Glenn Morris <rgm@gnu.org>
4189
4190 * syssignal.h: Replace RETSIGTYPE with void.
4191 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4192 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4193 Replace SIGTYPE with void everywhere.
4194 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4195 * s/template.h (SIGTYPE): Remove commented out definition.
4196
e2abce01
JB
41972011-03-26 Eli Zaretskii <eliz@gnu.org>
4198
4199 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4200 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4201
f868cd8a
JB
42022011-03-26 Juanma Barranquero <lekktu@gmail.com>
4203
59eb0929
JB
4204 * w32.c (read_unc_volume): Use parameter `henum', instead of
4205 global variable `wget_enum_handle'.
4206
4207 * keymap.c (describe_vector): Remove parameters `indices' and
4208 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4209 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4210
f868cd8a
JB
4211 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4212
4213 * keyboard.c (timer_check): Remove parameter `do_it_now',
4214 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4215 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4216 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4217
4218 * keyboard.c (read_char):
4219 * w32menu.c (w32_menu_display_help):
4220 * xmenu.c (show_help_event, menu_help_callback):
4221 Adjust calls to `show_help_echo'.
4222
4223 * gtkutil.c (xg_maybe_add_timer):
4224 * keyboard.c (readable_events):
4225 * process.c (wait_reading_process_output):
4226 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4227
4228 * insdel.c (adjust_markers_gap_motion):
4229 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4230 (gap_left, gap_right): Don't call it.
4231
2ecf6fdb
CY
42322011-03-25 Chong Yidong <cyd@stupidchicken.com>
4233
4234 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4235 incurred during fontification.
4236
6b1f9ba4
JB
42372011-03-25 Juanma Barranquero <lekktu@gmail.com>
4238
4239 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4240 (DEFVAR_PER_BUFFER): Don't pass it.
4241
4242 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4243 (scrolling_window): Don't pass it.
4244
0f4a96b5
JB
42452011-03-25 Juanma Barranquero <lekktu@gmail.com>
4246
4247 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4248
4249 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4250 and `suffix'.
4251 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4252 of variables specific to SELinux and computation of `encoded_absname'.
4253
4254 * image.c (XPutPixel): Remove unused variable `height'.
4255
4256 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4257
4258 * unexw32.c (get_section_info): Remove unused variable `section'.
4259
4260 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4261 (system_process_attributes): Remove unused variable `sess'.
4262 (sys_read): Remove unused variable `err'.
4263
4264 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4265 (w32_wnd_proc): Remove unused variable `isdead'.
4266 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4267 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4268 (x_create_tip_frame): Remove unused variable `tem'.
4269
4270 * w32inevt.c (w32_console_read_socket):
4271 Remove unused variable `no_events'.
4272
4273 * w32term.c (x_draw_composite_glyph_string_foreground):
4274 Remove unused variable `width'.
4275
1149507c
JB
42762011-03-24 Juanma Barranquero <lekktu@gmail.com>
4277
4278 * w32term.c (x_set_glyph_string_clipping):
4279 Don't pass uninitialized region to CombineRgn.
4280
9c88f339
JB
42812011-03-23 Juanma Barranquero <lekktu@gmail.com>
4282
4283 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4284 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4285 (Fx_close_connection): Remove unused variable `i'.
4286
4287 * w32font.c (w32font_draw): Return number of glyphs.
4288 (w32font_open_internal): Remove unused variable `i'.
4289 (w32font_driver): Add missing initializer.
4290
4291 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4292 (fill_in_menu): Remove unused variable `items_added'.
4293
4294 * w32term.c (last_mouse_press_frame): Remove static global variable.
4295 (w32_clip_to_row): Remove unused variable `f'.
4296 (x_delete_terminal): Remove unused variable `i'.
4297
4298 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4299 (NOTHING): Remove unused static global variable.
4300 (uniscribe_check_otf): Remove unused variable `table'.
4301 (uniscribe_font_driver): Add missing initializers.
4302
dee091a3
JD
43032011-03-23 Julien Danjou <julien@danjou.info>
4304
4305 * term.c (Fsuspend_tty, Fresume_tty):
4306 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4307 * window.c (temp_output_buffer_show):
4308 * insdel.c (signal_before_change):
4309 * frame.c (Fhandle_switch_frame):
4310 * fileio.c (Fdo_auto_save):
4311 * emacs.c (Fkill_emacs):
4312 * editfns.c (save_excursion_restore):
4313 * cmds.c (internal_self_insert):
4314 * callint.c (Fcall_interactively):
4315 * buffer.c (Fkill_all_local_variables):
4316 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4317 Use Frun_hooks.
0f4a96b5 4318 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4319 unconditionnaly since it does the check itself.
4320
2c520ab5 43212011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4322
c9c49752
PE
4323 Fix more problems found by GCC 4.5.2's static checks.
4324
8abc3f12
PE
4325 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4326 the first time through the loop, since we know p0 < p1 then.
4327 This also avoids a gcc -Wstrict-overflow warning.
4328
a2d26660
PE
4329 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4330 leading to a memory leak, possible in functions like
4331 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4332 of objects (Bug#8318).
a2d26660 4333
916c72e9
PE
4334 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4335 that could (at least in theory) be that large.
4336
19ab8a18
PE
4337 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4338 This is less likely to overflow, and avoids undefined behavior if
4339 overflow does occur. All callers changed. Use strtoul to scan
4340 for the unsigned long integer.
b7cbbd6f
PE
4341 (pint2hrstr): Simplify and tune code slightly.
4342 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4343
f0641eff
PE
4344 * scroll.c (do_scrolling): Work around GCC bug 48228.
4345 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4346
7f650bb9
PE
4347 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4348 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4349 (validate_x_resource_name): Simplify count usage.
4350 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4351
37dd57d1
PE
4352 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4353 fail (Bug#8306).
81e56e61 4354
699979fc 4355 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4356
401bf9b4
PE
4357 * process.c (Fmake_network_process): Use socklen_t, not int,
4358 where POSIX says socklen_t is required in portable programs.
4359 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4360 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4361 (Fmake_network_process, server_accept_connection):
4362 (wait_reading_process_output, read_process_output):
4363 Likewise.
4364
b93aacde
PE
4365 * process.c: Rename or move locals to avoid shadowing.
4366 (list_processes_1, Fmake_network_process):
4367 (read_process_output_error_handler, exec_sentinel_error_handler):
4368 Rename or move locals.
4dc343ee 4369 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4370 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4371 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4372 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4373 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4374
af8a867c 4375 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4376 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4377 Include tparam.h instead, since it declares them.
af8a867c
PE
4378 * cm.h (PC): Remove extern decl; tparam.h now does this.
4379 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4380 * terminfo.c: Include tparam.h, to check interfaces.
4381 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4382 (tparam): Adjust signature to match interface in tparam.h;
4383 this removes some undefined behavior. Check that outstring and len
4384 are zero, which they always are with Emacs.
4385 * tparam.h (PC, BC, UP): New extern decls.
4386
0248044d 4387 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4388 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4389
8ff096c1 4390 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4391 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4392 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4393 (ftfont_list): Remove unused local.
49eaafba
PE
4394 (get_adstyle_property, ftfont_pattern_entity):
4395 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4396 Rename locals to avoid shadowing.
8ff096c1 4397
e2be39f6
PE
4398 * xfont.c (xfont_list_family): Mark var as initialized.
4399
c9735e30
PE
4400 * xml.c (make_dom): Now static.
4401
8f5201ae
PE
4402 * composite.c (composition_compute_stop_pos): Rename local to
4403 avoid shadowing.
b246f932
PE
4404 (composition_reseat_it): Remove unused locals.
4405 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4406 (composition_update_it): Mark var as initialized.
11b61122
PE
4407 (find_automatic_composition): Mark vars as initialized,
4408 with a FIXME (Bug#8290).
8f5201ae 4409
760fbc2c
PE
4410 character.h: Rename locals to avoid shadowing.
4411 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4412 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4413 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4414 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4415 to avoid shadowing.
4416
ff08eb85
PE
4417 * textprop.c (property_change_between_p): Remove; unused.
4418
fc7bf025
PE
4419 * intervals.c (interval_start_pos): Now static.
4420
235d7abc
PE
4421 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4422
44f230aa
SM
4423 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4424 Rename locals to avoid shadowing.
3e7d6594 4425
50060332
PE
4426 * sound.c (wav_play, au_play, Fplay_sound_internal):
4427 Fix pointer signedness.
d01f234b 4428 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4429 (wav_play): Initialize a variable to 0, to prevent undefined
4430 behavior (Bug#8278).
50060332 4431
c4fc4e30
PE
4432 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4433
918436ed
PE
4434 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4435
c939f91b
PE
4436 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4437 clobbering (Bug#8298).
b9c7f648
PE
4438 * sysdep.c (sys_subshell): Likewise.
4439 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4440
6bd8c144
PE
4441 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4442 This should get cleaned up, so that child_setup has the
4443 same signature on all platforms.
4444
7710357c 4445 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4446 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4447
c59da222
CY
44482011-03-22 Chong Yidong <cyd@stupidchicken.com>
4449
4450 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4451 not to be necessary, and produces flickering.
4452
66b87493
GM
44532011-03-20 Glenn Morris <rgm@gnu.org>
4454
4455 * config.in: Remove file.
4456
45b6f6d5
JB
44572011-03-20 Juanma Barranquero <lekktu@gmail.com>
4458
4459 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4460 are now in src/globals.h.
4461 (syms_of_minibuf): Remove spurious & from previous change.
4462
3ec03f7e
LL
44632011-03-20 Leo <sdl.web@gmail.com>
4464
4465 * minibuf.c (completing-read-function): New variable.
4466 (completing-read-default): Rename from completing-read.
4467 (completing-read): Call completing-read-function.
4468
b14e3e21
CY
44692011-03-19 Juanma Barranquero <lekktu@gmail.com>
4470
4471 * xfaces.c (Fx_load_color_file):
4472 Read color file from absolute filename (bug#8250).
4473
f2b726e6
JB
44742011-03-19 Juanma Barranquero <lekktu@gmail.com>
4475
4476 * makefile.w32-in: Update dependencies.
4477
09f6ff02
EZ
44782011-03-17 Eli Zaretskii <eliz@gnu.org>
4479
4480 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4481
29a6015a
PE
44822011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4483
a3a6c54e
PE
4484 Fix more problems found by GCC 4.5.2's static checks.
4485
b766f867
PE
4486 * process.c (make_serial_process_unwind, send_process_trap):
4487 (sigchld_handler): Now static.
4488
be02381c
PE
4489 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4490 That way, the code declares only the vars that it needs.
4491 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4492 * s/cygwin.h (PTY_ITERATION): Likewise.
4493 * s/darwin.h (PTY_ITERATION): Likewise.
4494 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4495
57048744
PE
4496 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4497 * process.c (allocate_pty): Don't declare stb unless it's needed.
4498
7914961c 4499 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4500 (CONSTANTLIM): Remove; unused.
4501 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4502 Define only if needed.
7914961c 4503
b3967b18
PE
4504 * unexelf.c (unexec): Name an expression,
4505 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4506 Use a different way to cause a compilation error if anyone uses
4507 n rather than nn, a way that does not involve shadowing.
73366a00 4508 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4509
29a6015a
PE
4510 * deps.mk (unexalpha.o): Remove; unused.
4511
43cfc33e 4512 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4513 * unexec.h: New file.
ce701a33
PE
4514 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4515 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4516 Depend on unexec.h.
4517 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4518 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4519 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4520 Change as necessary to match prototype in unexec.h.
ce701a33 4521
01f44d5a
PE
4522 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4523 shadowing.
4f63c6bb 4524 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4525
a6670b0b
PE
4526 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4527 Rename locals to avoid shadowing.
4528
cef2010d 4529 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4530 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4531
d4d7173a
PE
4532 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4533
f08b802a
PE
4534 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4535 warning when compiling print.c.
4536
3ddb0639
PE
4537 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4538 instead of using an uninitialized var.
5ad03b97 4539 (font_sort_entities): Mark var as initialized.
3ddb0639 4540
170a2692
PE
4541 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4542
e663c700
PE
4543 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4544 pointers to constants.
89bc529a 4545 (font_parse_fcname): Remove unused vars.
7b81e2d0 4546 (font_delete_unmatched): Now static.
ea838e10 4547 (font_get_spec): Remove; unused.
13a547c6
PE
4548 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4549 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4550 Rename or move locals to avoid shadowing.
e663c700 4551
2a80c887 4552 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4553 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4554
1384fa33 4555 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4556 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4557
8b2c52e9
PE
4558 * alloc.c (mark_backtrace): Move decl from here ...
4559 * lisp.h: ... to here, so that it can be checked.
4560
475545b5 4561 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4562 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4563 (lisp_indirect_variable): Name an expression,
4564 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4565 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4566
b1349114 4567 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4568 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4569 Use const pointer when appropriate.
b1349114 4570
a2928364
PE
4571 * lisp.h (get_system_name, get_operating_system_release):
4572 Move decls here, to check interfaces.
4573 * process.c (get_operating_system_release): Move decl to lisp.h.
4574 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4575 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4576 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4577 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4578 (Fformat_time_string, Fencode_time, Finsert_char):
4579 (Ftranslate_region_internal, Fformat):
4580 Rename or remove local vars to avoid shadowing.
9710023e 4581 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4582
a415e694
PE
4583 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4584 avoid shadowing.
4585
8ef4622d
PE
4586 * lisp.h (eassert): Check that the argument compiles, even if
4587 ENABLE_CHECKING is not defined.
4588
946f9a5b
PE
4589 * data.c (Findirect_variable): Name an expression, to avoid
4590 gcc -Wbad-function-cast warning.
112396d6 4591 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4592 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4593 (Fmake_variable_buffer_local, Fmake_local_variable):
4594 Mark variables as initialized.
52746918 4595 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4596
e5aab7e7 4597 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4598 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4599 Rename locals to avoid shadowing.
dff45157
PE
4600 (mark_stack): Move local variables into the #ifdef region where
4601 they're used.
7bc26fdb
PE
4602 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4603 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4604 needed otherwise.
4605 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4606 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4607 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4608
e5aab7e7
PE
4609 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4610 avoids undefined behavior in theory.
4611
4da60324
PE
4612 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4613
88043301
PE
4614 Use functions, not macros, for up- and down-casing (Bug#8254).
4615 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4616 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4617 to use the following functions instead of these macros.
4618 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4619 EMACS_INT, since callers assume the returned value fits in int.
4620 (upcase1): Likewise, for UPCASE_TABLE.
4621 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4622 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4623 the race-condition problem in the old DOWNCASE.
88043301 4624
19ed5445
PE
4625 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4626 Rename locals to avoid shadowing.
4627 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4628 (regex_compile, re_search_2, re_match_2_internal):
4629 Remove unused local vars.
952db0d7
PE
4630 (FREE_VAR): Rewrite so as not to use empty "else",
4631 which gcc can warn about.
da053e48 4632 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4633 (RETALLOC_IF): Define only if needed.
4634 (WORDCHAR_P): Likewise. This one is never needed, but is used
4635 only in a comment talking about a compiler bug, so put inside
4636 the #if 0 of that comment.
4637 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4638 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4639 Remove; unused.
19ed5445 4640
1f3561e4 4641 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4642 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4643 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4644
ded6f8f7
PE
4645 * search.c (simple_search): Remove unused var.
4646
dbd37a95
PE
4647 * dired.c (compile_pattern): Move decl from here ...
4648 * lisp.h: ... to here, so that it can be checked.
4649 (struct re_registers): New forward decl.
4650
7e47afad
PE
4651 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4652
85f24f61
PE
4653 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4654 All uses changed.
4655 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4656 Rename locals to avoid shadowing.
5671df8f 4657 (Fvertical_motion): Mark locals as initialized.
85f24f61 4658
181aa2be 4659 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4660 (casify_region): Mark local as initialized.
181aa2be 4661
930d429c
PE
4662 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4663
7082eac6
PE
4664 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4665 New macros, so that the caller can use some names other than
4666 gcpro1, gcpro2, etc.
4667 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4668 of the new macros.
4669 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4670 argument, for consistency with GCPRO2_VAR, etc: it is now the
4671 prefix of the variable, not the variable itself. All uses
4672 changed.
38b2c076
PE
4673 * dired.c (directory_files_internal, file_name_completion):
4674 Rename locals to avoid shadowing.
4675
15206ed9
PE
4676 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4677 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4678 dired.c's scmp function, had undefined behavior.
4679 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4680 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4681 * buffer.h: ... to here, because these macros use current_buffer,
4682 and the new implementation with inline functions needs to have
4683 current_buffer in scope now, rather than later when the macros
4684 are used.
4685 (downcase, upcase1): New static inline functions.
4686 (DOWNCASE, UPCASE1): Reimplement using these functions.
4687 This avoids undefined behavior in expressions like
4688 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4689 from race conditions in accessing the global variables
4690 case_temp1 and case_temp2.
4691 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4692 * lisp.h (case_temp1, case_temp2): Remove their decls.
4693 * character.h (ASCII_CHAR_P): Move from here ...
4694 * lisp.h: ... to here, so that the inline functions mentioned
4695 above can use them.
4696
4a6bea26
PE
4697 * dired.c (directory_files_internal_unwind): Now static.
4698
f14b7e14
PE
4699 * fileio.c (file_name_as_directory, directory_file_name):
4700 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4701 Now static.
2893f146
PE
4702 (file_name_as_directory): Use const pointers when appropriate.
4703 (Fexpand_file_name): Likewise. In particular, newdir might
4704 point at constant storage, so make it a const pointer.
fd4ead52 4705 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4706 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4707 signedness issues.
f839df0c
PE
4708 (Fset_file_times, Finsert_file_contents, auto_save_error):
4709 Rename locals to avoid shadowing.
f14b7e14 4710
5716756e 4711 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4712 (Ftry_completion, Fall_completions): Rename or remove locals
4713 to avoid shadowing.
5716756e 4714
b4c3046a
PE
4715 * marker.c (bytepos_to_charpos): Remove; unused.
4716
b45db522
PE
4717 * lisp.h (verify_bytepos, count_markers): New decls,
4718 so that gcc does not warn that these functions aren't declared.
4719
85876d07
PE
4720 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4721 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4722 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4723 (copy_text): Remove unused local var.
85876d07 4724
03d78a21 4725 * filelock.c (within_one_second): Now static.
b3dd38ab 4726 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4727
5df8f01b
PE
4728 * buffer.c (fix_overlays_before): Mark locals as initialized.
4729 (fix_start_end_in_overlays): Likewise. This function should be
4730 simplified by using pointers-to-pointers, but that's a different
4731 matter.
b1d876f1 4732 (switch_to_buffer_1): Now static.
8f54f30a
PE
4733 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4734 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4735
a70072c9 4736 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4737 Fix pointer signedness issue.
edced198
PE
4738 (sys_subshell): Mark local as volatile if checking for lint,
4739 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4740 (MAXPATHLEN): Define only if needed.
a70072c9 4741
a0977c44
PE
4742 * process.c (serial_open, serial_configure): Move decls from here ...
4743 * systty.h: ... to here, so that they can be checked.
4744
a884fdcc
PE
4745 * fns.c (get_random, seed_random): Move extern decls from here ...
4746 * lisp.h: ... to here, so that they can be checked.
4747
604efe86 4748 * sysdep.c (reset_io): Now static.
b8950c94 4749 (wait_for_termination_signal): Remove; unused.
604efe86 4750
38fc62d9
PE
4751 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4752 (copy_keymap_item, append_key, push_text_char_description):
4753 Now static.
1004a21a 4754 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4755 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4756 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4757 (describe_map_tree):
4758 Rename locals to avoid shadowing.
38fc62d9 4759
2f2650da
PE
4760 * keyboard.c: Declare functions static if they are not used elsewhere.
4761 (echo_char, echo_dash, cmd_error, top_level_2):
4762 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4763 (read_char, kbd_buffer_get_event, make_lispy_position):
4764 (make_lispy_event, make_lispy_movement, apply_modifiers):
4765 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4766 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4767 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4768 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4769 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4770
a053e86c 4771 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4772 (mark_kboards): Move decl here ...
4773 * alloc.c (mark_kboards): ... from here.
a053e86c 4774
4752793e
PE
4775 * lisp.h (force_auto_save_soon): New decl.
4776
74f10ca7 4777 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4778 (DEFINE_DUMMY_FUNCTION): New macro.
4779 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4780 Use it.
c03cd23f
PE
4781 (main): Add casts to avoid warnings
4782 if GCC considers string literals to be constants.
74f10ca7 4783
022e70d4
PE
4784 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4785
59d6fe83
PE
4786 * dbusbind.c: Pointer signedness fixes.
4787 (xd_signature, xd_append_arg, xd_initialize):
4788 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4789 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4790 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4791 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4792
78320123
PE
4793 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4794 if GCC considers string literals to be constants.
49cebcca 4795 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4796
35ac2a97
SM
47972011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4798
fb103ca9
SM
4799 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4800 (print_preprocess, print_object): New macro to fix last change.
4801
35ac2a97
SM
4802 * print.c (print_preprocess): Don't forget font objects.
4803
62973b41
JB
48042011-03-16 Juanma Barranquero <lekktu@gmail.com>
4805
4806 * emacs.c (USAGE3): Doc fixes.
4807
0e48bb22
AS
48082011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4809
4810 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4811 structure.
4812
7684e57b
JB
48132011-03-14 Juanma Barranquero <lekktu@gmail.com>
4814
4815 * lisp.h (VWindow_system, Qfile_name_history):
4816 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4817 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4818 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4819
4820 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4821 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4822
4823 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4824 * w32console.c (detect_input_pending, read_input_pending)
4825 (encode_terminal_code):
4826 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4827 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4828 (w32_system_caret_y, Qfile_name_history):
4829 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4830 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4831 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4832 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4833 * w32proc.c (Qlocal, report_file_error):
4834 * w32term.c (Vwindow_system, updating_frame):
4835 * w32uniscribe.c (initialized, uniscribe_font_driver):
4836 Remove unneeded extern declarations.
4837
2aa46d6c
CY
48382011-03-14 Chong Yidong <cyd@stupidchicken.com>
4839
c96bbc66 4840 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4841
cffc6f3b
CY
48422011-03-13 Chong Yidong <cyd@stupidchicken.com>
4843
4844 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4845 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4846 These macros can no longer be used for assignment.
4847
44f230aa
SM
4848 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4849 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4850 (record_buffer_markers, fetch_buffer_markers): New functions for
4851 recording and fetching special buffer markers.
4852 (set_buffer_internal_1, set_buffer_temp): Use them.
4853
4854 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4855
4856 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4857
4858 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4859 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4860
4861 * xdisp.c (hscroll_window_tree):
4862 (reconsider_clip_changes): Use PT instead of BUF_PT.
4863
d251f04b
EZ
48642011-03-13 Eli Zaretskii <eliz@gnu.org>
4865
4866 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4867 $(EMACS_ROOT)/lib/intprops.h.
4868
f0c77cd1
PE
48692011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4870
3eca4629
PE
4871 Fix more problems found by GCC 4.5.2's static checks.
4872
7c86ee98
PE
4873 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4874 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4875 (xg_free_frame_widgets): Make it clear that a local variable is
4876 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4877 (gdk_window_get_screen): Make it clear that this macro is needed
4878 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4879 (int_gtk_range_get_value): New function, which avoids a diagnostic
4880 from gcc -Wbad-function-cast.
4881 (xg_set_toolkit_scroll_bar_thumb): Use it.
4882 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4883 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4884 (get_utf8_string, xg_get_file_with_chooser):
4885 Rename locals to avoid shadowing.
4886 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4887
41729b81
PE
4888 * xgselect.c (xg_select): Remove unused var.
4889
f0c77cd1
PE
4890 * image.c (four_corners_best): Mark locals as initialized.
4891 (gif_load): Initialize transparent_p to zero (Bug#8238).
4892 Mark another local as initialized.
ec6cf4c6 4893 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4894
ce0ad53d 4895 * image.c (clear_image_cache): Now static.
d5d5a617 4896 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4897 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4898 (x_edge_detection): Remove unnecessary cast that
4899 gcc -Wbad-function-cast diagnoses.
2037898d 4900 (gif_load): Fix pointer signedness.
6ae141d6
PE
4901 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4902 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4903
33383987 49042011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4905
d32df629
PE
4906 Improve quality of tests for time stamp overflow.
4907 For example, without this patch (encode-time 0 0 0 1 1
4908 1152921504606846976) returns the obviously-bogus value (-948597
4909 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4910 reports time overflow. See
4911 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4912 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4913 * editfns.c: Include limits.h and intprops.h.
4914 (TIME_T_MIN, TIME_T_MAX): New macros.
4915 (time_overflow): Move earlier, to before first use.
4916 (hi_time, lo_time): New functions, for an accurate test for
4917 out-of-range times.
4918 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4919 (Fget_internal_run_time): Don't assume time_t fits in int.
4920 (make_time): Use list2 instead of Fcons twice.
4921 (Fdecode_time): More accurate test for out-of-range times.
4922 (check_tm_member): New function.
4923 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4924 (lisp_time_argument): Don't rely on undefined left-shift and
4925 right-shift behavior when checking for time stamp overflow.
8be6f318 4926
fe31d94c
PE
4927 * editfns.c (time_overflow): New function, refactoring common code.
4928 (Fformat_time_string, Fdecode_time, Fencode_time):
4929 (Fcurrent_time_string): Use it.
4930
8be6f318
PE
4931 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4932 * dired.c (make_time): Move to ...
4933 * editfns.c (make_time): ... here.
4934 * systime.h: Note the move.
4935
09d9db2c 49362011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4937
126bc0dc
YM
4938 * fringe.c (update_window_fringes): Remove unused variables.
4939
c47cbdfd
YM
4940 * unexmacosx.c (copy_data_segment): Also copy __got section.
4941 (Bug#8223)
4942
7ac80be9
EZ
49432011-03-12 Eli Zaretskii <eliz@gnu.org>
4944
c96bbc66 4945 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4946 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4947 Constify `char *' arguments and their references according to
4948 prototypes in tparam.h.
4949
ecb0f94d 4950 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4951
7ac80be9
EZ
4952 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4953 Adapt all references accordingly.
4954
4955 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4956
ef1fd07e
TT
49572011-03-11 Tom Tromey <tromey@redhat.com>
4958
4959 * buffer.c (syms_of_buffer): Remove obsolete comment.
4960
7ef4b50c
EZ
49612011-03-11 Eli Zaretskii <eliz@gnu.org>
4962
4963 * termhooks.h (encode_terminal_code): Declare prototype.
4964
4965 * msdos.c (encode_terminal_code): Don't declare prototype.
4966
4967 * term.c (encode_terminal_code): Now external again, used by
4968 w32console.c and msdos.c.
4969
44f230aa
SM
4970 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4971 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4972
4b1ec863 49732011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4974
1714f52b 4975 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4976
4b1ec863
PE
4977 * fringe.c (update_window_fringes): Mark locals as initialized
4978 (Bug#8227).
4979 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4980
524c7aa6
PE
4981 * alloc.c (mark_fringe_data): Move decl from here ...
4982 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4983 to check its interface.
4984 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4985
a5c0af81 4986 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4987 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4988 (fontset_font): Mark local as initialized.
a9a06e0b 4989 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4990
b4716021
PE
4991 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4992
811e9bac 4993 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4994 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4995 (x_own_selection, Fx_disown_selection_internal): Rename locals
4996 to avoid shadowing.
4997 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4998
7e3ab302
PE
4999 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5000 so that the caller can use some name other than gcpro1.
5001 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5002 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5003 (Fx_backspace_delete_keys_p):
5004 Use them to avoid shadowing, and rename vars to avoid shadowing.
5005 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5006 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5007 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5008 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5009 Remove unused locals.
7e3ab302
PE
5010 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5011 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5012 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5013 macros.
f78faa98 5014
e2b13473
PE
5015 * xterm.h (x_mouse_leave): New decl.
5016
77f23912
PE
5017 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5018 Remove unused functions.
cdf4ba58
PE
5019 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5020 (x_calc_absolute_position): Now static.
7411c686 5021 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5022 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5023 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5024 unless they are used.
38d0b34a
PE
5025 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5026 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5027 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5028 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5029 (x_error_catcher, x_connection_closed, x_error_handler):
5030 (x_error_quitter, xembed_send_message, x_iconify_frame):
5031 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5032 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5033 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5034
44f230aa
SM
5035 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5036 Rename or move locals to avoid shadowing.
6b463e58 5037 (tty_defined_color, merge_face_heights): Now static.
5967d051 5038 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5039 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5040 does not deduce is never used uninitialized.
73719eba
PE
5041 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5042 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5043
426994c3 5044 * terminal.c (store_terminal_param): Now static.
5489860b 5045
032f1620 5046 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5047 (set_frame_menubar): Remove unused local.
d4323972 5048 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5049 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5050 since they might point to immutable storage.
281585b0
PE
5051 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5052 since it's unused otherwise.
032f1620 5053
367c19e5 5054 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5055 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5056 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5057 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5058 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5059 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5060 does not deduce are never used uninitialized.
70739cbe 5061
07b48fa9
PE
5062 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5063
8868a238 5064 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5065 * window.c (window_loop, size_window):
5066 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5067
7e5cf297 5068 * window.c (display_buffer): Now static.
d6550a9f
PE
5069 (size_window): Mark variables that gcc -Wuninitialized
5070 does not deduce are never used uninitialized.
a586633d
PE
5071 * window.h (check_all_windows): New decl, to forestall
5072 gcc -Wmissing-prototypes diagnostic.
5b555da1 5073 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5074
f6095868
PE
5075 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5076 shadowing.
5077 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5078 Include <limits.h>.
5079 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5080 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5081 (load_charset_map): Mark variables that gcc -Wuninitialized
5082 does not deduce are never used uninitialized.
53df7c11 5083 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5084
f38b440c
PE
5085 * coding.c (coding_set_source, coding_set_destination):
5086 Use "else { /* comment */ }" rather than "else /* comment */;"
5087 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5088 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5089 a block, when the outer 'i' will do.
5090 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5091 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5092 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5093 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5094 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5095 Rename locals to avoid shadowing.
5096 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5097 * coding.c (emacs_mule_char, encode_invocation_designation):
5098 Now static, since they're not used elsewhere.
413bb2db 5099 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5100 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5101 (decode_coding_emacs_mule): Mark variables that gcc
5102 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5103 (detect_coding_iso_2022): Initialize a local variable that might
5104 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5105 this initialization is needed. (Bug#8211)
5f58e762
PE
5106 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5107 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5108 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5109 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5110 Remove unused macros.
f38b440c 5111
232b38b9 5112 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5113 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5114 * character.c (string_count_byte8): Likewise.
232b38b9 5115
fb90da1b
PE
5116 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5117 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5118
fb93dbc2
PE
5119 * chartab.c (copy_sub_char_table): Now static, since it's not used
5120 elsewhere.
5c156ace
PE
5121 (sub_char_table_ref_and_range, char_table_ref_and_range):
5122 Rename locals to avoid shadowing.
bbcd0949 5123 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5124
7d3b3862 5125 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5126 (BIDI_BOB): Remove unused macro.
7d3b3862 5127
6be7d3da
PE
5128 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5129 deduce are never used uninitialized.
c2ed9c8b 5130 * term.c (encode_terminal_code): Likewise.
6be7d3da 5131
75f8807f 5132 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5133
50938595
PE
5134 * tparam.h: New file.
5135 * term.c, tparam.h: Include it.
5136 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5137 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5138 Move these decls to tparam.h, and make them agree with what
5139 is actually in tparam.c. The previous trick of using incompatible
5140 decls in different modules does not conform to the C standard.
5141 All callers of tparam changed to use tparam's actual API.
5142 * tparam.c (tparam1, tparam, tgoto):
5143 Use const pointers where appropriate.
5144
fbceeba2
PE
5145 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5146 * cm.h (struct cm): Likewise.
5147 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5148 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5149 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5150 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5151 (turn_on_face, init_tty): Likewise.
5152 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5153
7f3f1250
PE
5154 * term.c (term_mouse_position): Rename local to avoid shadowing.
5155
e6ca6543
PE
5156 * alloc.c (mark_ttys): Move decl from here ...
5157 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5158
c40f8d15
AS
51592011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5160
5161 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5162
cfe0661d
JB
51632011-03-09 Juanma Barranquero <lekktu@gmail.com>
5164
5165 * search.c (compile_pattern_1): Remove argument regp, unused since
5166 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5167 (compile_pattern): Don't pass it.
5168
0afb4571
J
51692011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5170
5171 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5172 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5173 for ! HAVE_GTK3.
5174 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5175
5176 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5177
5178 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5179 gdk_window_get_screen, gdk_window_get_geometry,
5180 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5181 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5182 (xg_get_pixbuf_from_pixmap): New function.
5183 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5184 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5185 Call xg_get_pixbuf_from_pixmap instead of
5186 gdk_pixbuf_get_from_drawable.
5187 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5188 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5189 (xg_check_special_colors): Use GtkStyleContext and its functions
5190 for HAVE_GTK3.
5191 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5192 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5193 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5194 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5195 Call gtk_widget_get_preferred_size.
0afb4571
J
5196 (xg_frame_resized): gdk_window_get_geometry only takes 5
5197 parameters.
44f230aa
SM
5198 (xg_win_to_widget, xg_event_is_for_menubar):
5199 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5200 (xg_set_widget_bg): New function.
5201 (delete_cb): New function.
895009e1 5202 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5203 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5204 (xg_set_background_color): Call xg_set_widget_bg.
5205 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5206 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5207 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5208 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5209 if ! HAVE_GTK3.
5210 (update_frame_tool_bar): Call gtk_widget_hide.
5211 (xg_initialize): Use GDK_KEY_g.
5212
5213 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5214 if ! HAVE_GTK3
5215 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5216
5217 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5218 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5219 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5220
1c2cc4ef
JB
52212011-03-08 Juanma Barranquero <lekktu@gmail.com>
5222
5223 * w32xfns.c (select_palette): Check success of RealizePalette against
5224 GDI_ERROR, not zero.
5225
33383987 5226See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5227
5228;; Local Variables:
5229;; coding: utf-8
aac0c6e3
MR
5230;; End:
5231
33383987 5232 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5233
5234 This file is part of GNU Emacs.
5235
5236 GNU Emacs is free software: you can redistribute it and/or modify
5237 it under the terms of the GNU General Public License as published by
5238 the Free Software Foundation, either version 3 of the License, or
5239 (at your option) any later version.
5240
5241 GNU Emacs is distributed in the hope that it will be useful,
5242 but WITHOUT ANY WARRANTY; without even the implied warranty of
5243 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5244 GNU General Public License for more details.
5245
5246 You should have received a copy of the GNU General Public License
5247 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.