Auto-commit of generated files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
b00eea75
EZ
12011-10-12 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4 display string and the previous row comes from the same string and
5 is empty. (Bug#9739) (Bug#9738)
6
8fe012c4
SM
72011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
8
9 * doc.c (get_doc_string): Encode file name (bug#9735).
10
0074aef2
EZ
112011-10-12 Eli Zaretskii <eliz@gnu.org>
12
79beb178
EZ
13 * bidi.c (bidi_level_of_next_char):
14 * xdisp.c (get_visually_first_element): Remove old incorrect
15 comments regarding the Unicode Line Separator character.
16
0074aef2
EZ
17 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
18
6e4b3fbe
DA
192011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
20
21 * alloc.c (Fgc_status): Do not access beyond zombies array
22 boundary if nzombies > MAX_ZOMBIES.
23 * alloc.c (dump_zombies): Add missing format specifier.
24
0324f3af
PE
252011-10-12 Paul Eggert <eggert@cs.ucla.edu>
26
b5525cac
PE
27 * xdisp.c (set_cursor_from_row): Simplify conditionals,
28 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
29
0324f3af
PE
30 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
31 Some packages use them to denote characters with modifiers.
32
e9b5f888
AS
332011-10-11 Andreas Schwab <schwab@linux-m68k.org>
34
35 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
36 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
37 matching a pp-number. Rename parameter var to var1.
38
127827c0
SM
392011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
40
41 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
42
c8fd3bd0
GM
432011-10-08 Glenn Morris <rgm@gnu.org>
44
45 * callint.c (Fcall_interactively): Give a more explicit error for the
46 'c' case with a non-character input. (Bug#8479)
47
352ec8ff
EZ
482011-10-08 Eli Zaretskii <eliz@gnu.org>
49
03669ccb
EZ
50 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
51 lines.
7061c986
EZ
52 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
53 lines that are hscrolled on the left.
03669ccb 54
352ec8ff
EZ
55 * dispnew.c (buffer_posn_from_coords): Account for a possible
56 presence of header-line. (Bug#4426)
57
a66cfb1c
SM
582011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
59
60 * buffer.c (syms_of_buffer) <enable-multibyte-characters>: Don't
61 advertise functionality which we discourage or doesn't work.
62
7c5ee88e
PE
632011-10-07 Paul Eggert <eggert@cs.ucla.edu>
64
65 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
66 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
67 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
68 this makes Emacs dump core during garbage collection on rare
69 occasions. sizeof is obviously inferior to offsetof here, so
70 stick with offsetof.
71 (GC_POINTER_ALIGNMENT): New macro.
72 (mark_memory): Omit 3rd (offset) arg; caller changed.
73 Don't assume EMACS_INT alignment is the same as pointer alignment.
74
df1bbe5b
SM
752011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
76
77 * keyboard.c (read_key_sequence_remapped): New var.
78 (read_key_sequence): Compute remapping in the right buffer.
79 (command_loop_1): Use read_key_sequence's remapping directly.
80
51553db6
SM
812011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
82
32c1fffd
SM
83 * dired.c (file_name_completion): Don't expand file name.
84 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
85 before checking file name handler.
86
51553db6
SM
87 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
88 they've been requested explicitly (bug#9591).
89
b6bd1599 902011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
91
92 * keymap.c (Fsingle_key_description): Use make_specified_string
93 instead of build_string to build string from push_key_description.
94 (Bug#5193)
95
f701dc2a
PE
962011-09-30 Paul Eggert <eggert@cs.ucla.edu>
97
4222c55d
PE
98 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
99 This fixes a Y2038 bug on 64-bit hosts.
100 * buffer.c (reset_buffer):
101 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
102 (Fclear_buffer_auto_save_failure):
103 Use 0, not -1, to represent an unset failure time, since time_t
104 might not be signed.
105
f701dc2a
PE
106 Remove dependency on glibc malloc internals.
107 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
108 Move back here from lisp.h, but with their new implementations.
109 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
110 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
111 * charset.c (charset_table_init): New static var.
112 (syms_of_charset): Use it instead of xmalloc. This removes a
113 dependency on glibc malloc internals. See Eli Zaretskii's comment in
114 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
115 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
116 Move back to alloc.c.
117 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
118 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
119
9ceebf39
JD
1202011-09-30 Jan Djärv <jan.h.d@swipnet.se>
121
122 * nsterm.m (windowDidResize): Call x_set_window_size only when
123 ns_in_resize is true. Otherwise set pixelwidth/height and
124 call change_frame_size (Bug#9628).
125
cb993c58
PE
1262011-09-30 Paul Eggert <eggert@cs.ucla.edu>
127
3930c88b
PE
128 Port --enable-checking=all to Fedora 14 x86-64.
129 * charset.c (syms_of_charset): Also account for glibc malloc's
130 internal overhead when calculating the initial malloc maximum.
131
cb993c58
PE
132 Port --enable-checking=all to Fedora 14 x86.
133 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
134 Move to lisp.h.
135 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
136 (overrun_check_realloc, overrun_check_free):
137 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
138 That way, xmalloc returns a properly-aligned pointer even if
139 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
140 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
141 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
142 into account when calculating the initial malloc maximum.
143 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
144 Move here from alloc.c, so that charset.c can use it too.
145 Properly align; the old code wasn't right for common 32-bit hosts
146 when configured with --enable-checking=all.
147 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
148 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
149
31bed486
EZ
1502011-09-29 Eli Zaretskii <eliz@gnu.org>
151
04c70788 152 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
153 use EDOM.
154
fbcaa2f3
EZ
1552011-09-28 Eli Zaretskii <eliz@gnu.org>
156
157 * xdisp.c (compute_display_string_end): If there's no display
158 string at CHARPOS, return -1.
159
160 * bidi.c (bidi_fetch_char): When compute_display_string_end
161 returns a negative value, treat the character as a normal
162 character not covered by a display string. (Bug#9624)
163
a239d4e9
JB
1642011-09-28 Juanma Barranquero <lekktu@gmail.com>
165
166 * lread.c (Fread_from_string): Fix typo in docstring.
167
88652fd5
EZ
1682011-09-27 Eli Zaretskii <eliz@gnu.org>
169
170 * xdisp.c (handle_invisible_prop): If invisible text ends on a
171 newline, reseat the iterator instead of bidi-iterating there one
172 character at a time. (Bug#9610)
32c1fffd
SM
173 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
174 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 175
ed497dd4
AS
1762011-09-27 Andreas Schwab <schwab@linux-m68k.org>
177
178 * lread.c (readevalloop): Use correct code for NBSP.
179 (read1): Likewise. (Bug#9608)
180
b2bf61aa
MA
1812011-09-25 Michael Albinus <michael.albinus@gmx.de>
182
183 * dbusbind.c (Fdbus_register_signal): When service is not
184 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
185
32bbb17c
GM
1862011-09-25 Glenn Morris <rgm@gnu.org>
187
188 * buffer.c (truncate-lines): Doc fix.
189
94e0933e
CY
1902011-09-24 Chong Yidong <cyd@stupidchicken.com>
191
192 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
193 (Fset_window_next_buffers): Doc fix.
194
cddde921
GM
1952011-09-24 Glenn Morris <rgm@gnu.org>
196
197 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
198
1260aef1
PE
1992011-09-24 Paul Eggert <eggert@cs.ucla.edu>
200
25b4bfa0
PE
201 Fix minor problems found by static checking.
202 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
203 * indent.c (Fvertical_motion): Fix == vs = typo.
204
e3cbd34b
EZ
2052011-09-24 Eli Zaretskii <eliz@gnu.org>
206
a66cfb1c
SM
207 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
208 Default value is now t. Doc fix.
6bf7006f 209
e3cbd34b 210 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 211 logic when moving up, not only when moving down. Fix the
e3cbd34b 212 confusing name and values of the it_overshoot_expected variable;
32c1fffd 213 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
214
215 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
216 CHARPOS is covered by a display string which includes newlines.
217 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
218 is covered by a display string with embedded newlines.
219
a3de0cbd
MA
2202011-09-24 Michael Albinus <michael.albinus@gmx.de>
221
222 * dbusbind.c (Fdbus_register_signal): Add match rule to
223 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
224 (Fdbus_register_method, Vdbus_registered_objects_table):
225 Fix docstring.
a3de0cbd 226
b260039d
JM
2272011-09-24 Jim Meyering <meyering@redhat.com>
228
32c1fffd 229 do not ignore write error for any output size
b260039d
JM
230 The previous change was incomplete.
231 While it makes emacs --batch detect the vast majority of stdout
232 write failures, errors were still ignored whenever the output size is
233 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
234 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
235 && echo FAIL: ignored write error
236 FAIL: ignored write error
237 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
238 && echo FAIL: ignored write error
239 FAIL: ignored write error
240 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
241
8eca8a7c
AS
2422011-09-23 Andreas Schwab <schwab@linux-m68k.org>
243
244 * emacs.c (Fkill_emacs): In noninteractive mode exit
245 non-successfully if a write error occurred on stdout. (Bug#9574)
246
3341db62
EZ
2472011-09-21 Eli Zaretskii <eliz@gnu.org>
248
249 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
250 the xassert test.
251
252 * dispextern.h (struct it): Update the comment documenting what
253 can it->OBJECT be.
254
8c203dbf
EZ
2552011-09-20 Eli Zaretskii <eliz@gnu.org>
256
257 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
258 a display string, extend search for cursor position to end of row.
259 (find_row_edges): If the row ends in a newline from a display
260 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
261 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
262 (Fcurrent_bidi_paragraph_direction): Fix search for previous
263 non-empty line. Fixes confusing cursor motion with arrow keys at
264 the beginning of a line that starts with whitespace.
8c203dbf 265
a4824228
LMI
2662011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
267
268 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
269 (bug#9493).
270
33ed493b
CY
2712011-09-18 Chong Yidong <cyd@stupidchicken.com>
272
273 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
274 boolean (Bug#9154).
275
56cd55c8
EZ
2762011-09-18 Eli Zaretskii <eliz@gnu.org>
277
278 * xdisp.c (display_line): Record maximum and minimum buffer
279 positions even if no glyphs were produced (e.g., by a zero-width
280 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
281 buffer positions that will be removed from the glyph row because
282 they don't fit.
c02dcedf
EZ
283 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
284 column is beyond frame width: don't subtract 1 "pixel" when
285 computing width of the stretch.
3e62b7e0
EZ
286 (reseat_at_next_visible_line_start): Undo the change made on
287 2011-09-17 that saved paragraph information and restored it after
288 the call to `reseat'. (Bug#9545)
56cd55c8 289
5ed99d36 2902011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
291
292 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
293 and turn window cursor on if cleared (Bug#9415).
294
5ed99d36 2952011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
296
297 * search.c (boyer_moore): Take unibyte characters from pattern
298 literally. (Bug#9458)
299
9bade7b2
EZ
3002011-09-18 Eli Zaretskii <eliz@gnu.org>
301
302 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
303
e5e9d610
PE
3042011-09-18 Paul Eggert <eggert@cs.ucla.edu>
305
87e4427a
PE
306 Fix minor problem found by static checking.
307 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
308 initialized, to pacify gcc -Wuninitialized.
309
e5e9d610
PE
310 * fileio.c: Report proper errno when syscall falls.
311 (Finsert_file_contents): Save and restore errno,
312 so that report_file_error outputs the correct diagnostic.
313 (Fwrite_region) [CLASH_DETECTION]: Likewise.
314
a1674f0b
EZ
3152011-09-18 Eli Zaretskii <eliz@gnu.org>
316
317 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
318
fbfb6dd4
EZ
3192011-09-17 Eli Zaretskii <eliz@gnu.org>
320
321 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
322 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
323
bb187662
EZ
3242011-09-17 Eli Zaretskii <eliz@gnu.org>
325
1137e8b8
EZ
326 * xdisp.c (reseat_at_next_visible_line_start): Keep information
327 about the current paragraph and restore it after the call to
328 reseat.
329
330 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
331 (bidi_find_paragraph_start): Search back for paragraph beginning
332 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
333 (bidi_move_to_visually_next): Only trigger paragraph-related
334 computations when the last character is a newline or at EOB, not
335 just any NEUTRAL_B. (Bug#9470)
336
bb187662
EZ
337 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
338 truncated lines if point is covered by a display string. (Bug#9524)
339
2e621251
PE
3402011-09-16 Paul Eggert <eggert@cs.ucla.edu>
341
342 * xselect.c: Relax test for outgoing X longs (Bug#9498).
343 (cons_to_x_long): New function.
344 (lisp_data_to_selection_data): Use it. Correct the test for
345 short-versus-long data; it was negated. Break out of vector
346 loop, for efficiency, when a long datum is discovered.
347
91a15bc6
SM
3482011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
349
350 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
351
b41c3a35
EZ
3522011-09-16 Eli Zaretskii <eliz@gnu.org>
353
354 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
355 GCC PR/17406) by declaring this function with external scope.
356
7812ba2d
PE
3572011-09-15 Paul Eggert <eggert@cs.ucla.edu>
358
359 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
360 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
361
cf7edc2a
AS
3622011-09-15 Andreas Schwab <schwab@linux-m68k.org>
363
364 * editfns.c (Fformat): Correctly handle text properties on "%%".
365
bd01620e
EZ
3662011-09-15 Eli Zaretskii <eliz@gnu.org>
367
368 * xterm.c (x_draw_composite_glyph_string_foreground):
369 * w32term.c (x_draw_composite_glyph_string_foreground):
370 * term.c (encode_terminal_code):
371 * composite.c (composition_update_it, get_composition_id):
372 * xdisp.c (get_next_display_element)
373 (fill_composite_glyph_string): Add comments about special meaning
374 of TAB characters in a composition.
375
a02719a3
PE
3762011-09-15 Paul Eggert <eggert@cs.ucla.edu>
377
378 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
379 This occurs when processing a multibyte format.
380 Problem reported by Wolfgang Jenker.
a02719a3 381
72589a3c
JB
3822011-09-15 Johan Bockgård <bojohan@gnu.org>
383
384 * xdisp.c (try_cursor_movement): Only check for exact match if
385 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
386
1c14176c
PE
3872011-09-14 Paul Eggert <eggert@cs.ucla.edu>
388
389 Remove unused external symbols.
390 * dispextern.h (calc_pixel_width_or_height): Remove decl.
391 * xdisp.c (calc_pixel_width_or_height): Now static.
392 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
393 * indent.c (check_display_width):
394 * w32term.c: Fix comment to match code.
395 * xterm.c, xterm.h (x_catching_errors): Remove.
396
d2eea5b5
PE
3972011-09-14 Paul Eggert <eggert@cs.ucla.edu>
398
399 * xselect.c: Use signed conversions more consistently (Bug#9498).
400 (selection_data_to_lisp_data): Assume incoming selection data are
401 signed integers, not unsigned. This is to be consistent with
402 outgoing selection data, which was modified to use signed integers
403 in as part of the fix to Bug#9196 in response to Jan D.'s comment
404 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
405 expects long, not unsigned long.
406
46888499
EZ
4072011-09-14 Eli Zaretskii <eliz@gnu.org>
408
409 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
410 computation of loop end. Reported by Johan Bockgård
411 <bojohan@gnu.org>.
412
ef8ef9fb
CY
4132011-09-13 Chong Yidong <cyd@stupidchicken.com>
414
415 * frame.c (Fother_visible_frames_p): Function deleted.
416
fa819fed
EZ
4172011-09-12 Eli Zaretskii <eliz@gnu.org>
418
419 * indent.c (compute_motion): Process display vector front to back
420 rather than the other way around. (Bug#2496)
421
2ba8e008
SM
4222011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
423
424 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
425
20f53c69
CY
4262011-09-11 Chong Yidong <cyd@stupidchicken.com>
427
428 * minibuf.c (Fread_from_minibuffer): Doc fix.
429
d562d7a4
EZ
4302011-09-11 Eli Zaretskii <eliz@gnu.org>
431
432 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
433 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
434
1c4d7f3d
LMI
4352011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
436
437 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
438 value for non-existent files.
439
b885bf36
EZ
4402011-09-11 Eli Zaretskii <eliz@gnu.org>
441
442 * fileio.c (Finsert_file_contents): If the file cannot be opened,
443 set its "size" to -1. This will set the modtime_size field of
444 the corresponding buffer to -1, which is what
445 verify-visited-file-modtime expects for files that do not exist.
446 (Bug#9139)
447
6612f0bf
PE
4482011-09-11 Paul Eggert <eggert@cs.ucla.edu>
449
450 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
451 here ...
452 * lisp.h: ... from here. push_key_description is no longer
453 defined in keyboard.c, so its declaration should not be in
454 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
455 logically belongs with push_key_description.
456
dfb3f755
PE
4572011-09-10 Paul Eggert <eggert@cs.ucla.edu>
458
459 * buffer.h: Include <sys/types.h> instead of <time.h>.
460 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
461 Problem reported by Herbert J. Skuhra.
462
3134906c
LMI
4632011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
464
465 * xml.c (parse_region): Make the parsing work for
466 non-comment-starting XML files again (bug#9144).
467
8d903f4e
AS
4682011-09-10 Andreas Schwab <schwab@linux-m68k.org>
469
470 * image.c (gif_load): Fix calculation of bottom and right corner.
471 (Bug#9468)
472
80ad64f4
EZ
4732011-09-10 Eli Zaretskii <eliz@gnu.org>
474
475 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
476 redisplay in small windows.
477
208a048d
EZ
4782011-09-09 Eli Zaretskii <eliz@gnu.org>
479
480 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
481
9b1c252e
MR
4822011-09-08 Martin Rudalics <rudalics@gmx.at>
483
484 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
485 Operate on live windows only.
486
2949f33b
JB
4872011-09-08 Juanma Barranquero <lekktu@gmail.com>
488
489 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
490
e08dcafd
EZ
4912011-09-07 Eli Zaretskii <eliz@gnu.org>
492
493 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
494 only under bidi iteration.
495
115b96bd
JD
4962011-09-07 Jan Djärv <jan.h.d@swipnet.se>
497
498 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
499
c8199d0f
PE
5002011-09-06 Paul Eggert <eggert@cs.ucla.edu>
501
502 isnan: Fix porting problem to Solaris 10 with bundled gcc.
503 Without this fix, the command to link temacs failed due to an
504 undefined symbol __builtin_isnan. This is because
505 /usr/include/iso/math_c99.h #defines isnan(x) to
506 __builtin_isnan(x), but the bundled gcc, which identifies itself
507 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
508 a __builtin_isnan.
509 * floatfns.c (isnan): #undef, and then #define to a clone of
510 what's in data.c.
511 (Fisnan): Always define, since it's always available now.
512 (syms_of_floatfns): Always define isnan at the Lisp level.
513
e39b275c 5142011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
515
516 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
517
b2db44d9 5182011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 519
f4af5137 520 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
521 The previous code assumed that file offsets (off_t values) fit in
522 EMACS_INT variables, which is not true on typical 32-bit hosts.
523 The code messed up by falsely reporting buffer overflow in cases
524 such as (insert-file-contents "big" nil 1 2) into an empty buffer
525 when "big" contains more than 2**29 bytes, even though this
526 inserts just one byte and does not overflow the buffer.
527 (Finsert_file_contents): Store file offsets as off_t
528 values, not as EMACS_INT values. Check for overflow when
529 converting between EMACS_INT and off_t. When checking for
530 buffer overflow or for overlap, take the offsets into account.
531 Don't use EMACS_INT for small values where int suffices.
532 When checking for overlap, fix a typo: ZV was used where
533 ZV_BYTE was intended.
534 (Fwrite_region): Don't assume off_t fits into 'long'.
535 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
536
ecfc0a49
MA
5372011-09-05 Michael Albinus <michael.albinus@gmx.de>
538
539 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
540
6511acf2 5412011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 542
0999621a 543 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
544
545 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 546 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
547 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
548 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
549 (modify_event_symbol): Do not assume that the length of
550 name_alist_or_stem is safe to alloca and fits in int.
551 (Fexecute_extended_command): Likewise for function name and binding.
552 (Frecursion_depth): Wrap around reliably on integer overflow.
553 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
554 since some callers pass EMACS_INT values.
555 (Fsingle_key_description): Don't crash if symbol name contains more
556 than MAX_ALLOCA bytes.
557 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
558 (get_minibuffer): Arg is now EMACS_INT, not int.
559 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 560 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
561 * window.h (command_loop_level, minibuf_level): Reflect API changes.
562
2be7d702
PE
563 * dbusbind.c (signature_cat): New function.
564 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
565 Do not overrun buffer; instead, report string overflow.
566
9d1df220
PE
567 * dispnew.c (add_window_display_history): Don't overrun buffer.
568 Truncate instead; this is OK since it's just a log.
569
33ef5c64
PE
570 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
571 even if the time zone offset is outlandishly large.
572 Don't mishandle offset == INT_MIN.
573
66c6fdd5
PE
574 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
575 when creating daemon; the previous buffer-overflow check was incorrect.
576
d749b01b
PE
577 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
578 which has the guts of the old verror function.
579
b5cd1905
PE
580 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
581 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
582
6e1a67fb
PE
583 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
584 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 585 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 586 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
587 length of string rather than counting it via multiple sprintfs;
588 that's simpler and more reliable.
c21721cc
PE
589 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
590 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
591 sprintf, in case result does not fit in int.
592
c57b67fc
PE
593 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
594 (fontset_from_font): Print it.
595
8a401434
PE
596 * frame.c (tty_frame_count): Now printmax_t, not int.
597 (make_terminal_frame, set_term_frame_name): Print it.
598 (x_report_frame_params): In X, window IDs are unsigned long,
599 not signed long, so print them as unsigned.
600 (validate_x_resource_name): Check for implausibly long names,
601 and don't assume name length fits in 'int'.
602 (x_get_resource_string): Don't blindly alloca invocation name;
603 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
604 not fit in int.
605
6e1a67fb
PE
606 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
607 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
608 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
609
0df02bf3
PE
610 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
611 Use esprintf, not sprintf, in case result does not fit in int.
612
48e30793
PE
613 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
614 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
615 it as a large positive number.
616 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
617 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
618
a66ff6d8
PE
619 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
620 in case result does not fit in int.
621
aca216ff
PE
622 * print.c (float_to_string): Detect width overflow more reliably.
623 (print_object): Make sprintf buffer a bit bigger, to avoid potential
624 buffer overrun. Don't assume list length fits in 'int'. Treat
625 print length of 0 as 0, not as infinity; to be consistent with other
626 uses of print length in this function. Don't overflow print length
627 index. Don't assume hash table size fits in 'long', or that
628 vectorlike size fits in 'unsigned long'.
629
31c286f7
PE
630 * process.c (make_process): Use printmax_t, not int, to format
631 process-name gensyms.
632
55e5faa1
PE
633 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
634
80f2e268
PE
635 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
636 to avoid potential buffer overrun.
637
670741ab
PE
638 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
639 if X resource line is longer than 512 bytes.
640
b7163a50
PE
641 * xfns.c (x_window): Make sprintf buffer a bit bigger
642 to avoid potential buffer overrun.
643
ae58ff1f
PE
644 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
645
c43c8a6a
PE
646 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
647
3f8236f4
PE
6482011-09-04 Paul Eggert <eggert@cs.ucla.edu>
649
53e9fe90 650 Integer overflow fixes for scrolling, etc.
6511acf2
PE
651 Without these, Emacs silently mishandles large integers sometimes.
652 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
653 it were "C-u 1 M-x recenter" on a typical 64-bit host.
654
6511acf2
PE
655 * xdisp.c (try_window_id): Check Emacs fixnum range before
656 converting to 'int'.
806add1d 657
6511acf2 658 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
659 Check that an Emacs fixnum is in range before assigning it to 'int'.
660 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
661 values converted from Emacs fixnums.
662 (Frecenter): Don't wrap around a line count if it is out of 'int'
663 range; instead, treat it as an extreme value.
664 (Fset_window_configuration, compare_window_configurations):
665 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
666
6511acf2
PE
667 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
668 that can exceed INT_MAX. Check that EMACS_INT value is in range
669 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
670 (match_limit): Don't assume that a fixnum can fit in 'int'.
671
6511acf2 672 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
673 exceed INT_MAX.
674
6511acf2 675 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
676 (Fvertical_motion): Don't wrap around LINES values that don't fit
677 in 'int'. Instead, treat them as extreme values. This is good
678 enough for windows, which can't have more than INT_MAX lines anyway.
679
fcb901a7
LMI
6802011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
681
0f2f6b6d
LMI
682 * Require libxml/parser.h to avoid compilation warning.
683
fcb901a7
LMI
684 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
685
686 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
687 since this reportedly can destroy thread storage.
688
6e20a0d4
CY
6892011-08-30 Chong Yidong <cyd@stupidchicken.com>
690
691 * syntax.c (find_defun_start): Update all cache variables if
692 exiting early (Bug#9401).
693
148ae00e
EZ
6942011-08-30 Eli Zaretskii <eliz@gnu.org>
695
f6cfbd8f
EZ
696 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
697
148ae00e
EZ
698 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
699 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
700 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
701
702 * term.c (tty_append_glyph): New function.
703 (produce_stretch_glyph): Static function and its prototype deleted.
704
a66cfb1c
SM
705 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
706 Add prototypes.
148ae00e 707
c4a07a4c
PE
7082011-08-29 Paul Eggert <eggert@cs.ucla.edu>
709
710 * image.c (parse_image_spec): Check for nonnegative, not for positive,
711 when checking :margin (Bug#9390).
712 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 713 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
714 so that the name doesn't mislead. All uses changed.
715
6bc8cd65
JB
7162011-08-28 Johan Bockgård <bojohan@gnu.org>
717
718 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
719 set_tty_hooks.
720
dca4927e
EZ
7212011-08-27 Eli Zaretskii <eliz@gnu.org>
722
723 * xdisp.c (move_it_to): Don't bail out early when reaching
724 position beyond to_charpos, if we are scanning backwards.
725 (move_it_vertically_backward): When DY == 0, make sure we get to
726 the first character in the line after the newline.
727
f2cad773
PE
7282011-08-27 Paul Eggert <eggert@cs.ucla.edu>
729
730 * ccl.c: Improve and simplify overflow checking (Bug#9196).
731 (ccl_driver): Do not generate an out-of-range pointer.
732 (Fccl_execute_on_string): Remove unnecessary check for
733 integer overflow, noted by Stefan Monnier in
734 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
735 Remove a FIXME that didn't need fixing.
736 Simplify the newly-introduced buffer reallocation code.
737
0cae2cdb
JB
7382011-08-27 Juanma Barranquero <lekktu@gmail.com>
739
740 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
741
5fc295a4 7422011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 743
70c60eb2 744 Integer and memory overflow issues (Bug#9196).
726e0ab1 745
d31850da
PE
746 * doc.c (get_doc_string): Rework so that
747 get_doc_string_buffer_size is the actual buffer size, rather than
748 being 1 less than the actual buffer size; this makes xpalloc more
749 convenient.
750
a69fbedb
PE
751 * image.c (x_allocate_bitmap_record, cache_image):
752 * xselect.c (Fx_register_dnd_atom):
753 Simplify previous changes by using xpalloc.
754
fe5c5d37
PE
755 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
756 since either will do and ptrdiff_t is convenient with xpalloc.
757
0065d054
PE
758 * charset.c (charset_table_size)
759 (struct charset_sort_data.priority): Now ptrdiff_t.
760 (charset_compare): Don't overflow if priorities differ greatly.
761 (Fsort_charsets): Don't assume list length fits in int.
762 Check for size-calculation overflow when allocating sort data.
763 (syms_of_charset): Allocate an initial charset table that is
764 just under 64 KiB, to avoid problems with glibc malloc and mmap.
765
766 * cmds.c (internal_self_insert): Check for size-calculation overflow.
767
768 * composite.h (struct composition.glyph_len): Now int, not unsigned.
769 The actual value is always <= INT_MAX, and leaving it unsigned made
770 overflow checking harder.
771
772 * dispextern.h (struct glyph_matrix.rows_allocated)
773 (struct face_cache.size): Now ptrdiff_t, for convenience in use
774 with xpalloc. The values are still always <= INT_MAX.
775
776 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
777
778 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
779 (SAFE_NALLOCA): New macro.
780
781 * region-cache.c (struct boundary.pos, find_cache_boundary)
782 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
783 (set_cache_region, invalidate_region_cache)
784 (revalidate_region_cache, know_region_cache, region_cache_forward)
785 (region_cache_backward, pp_cache):
786 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
787 so that ptrdiff_t * can be passed to xpalloc.
788 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
789 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
790 (pp_cache): Don't assume cache_len fits in int.
791 * region-cache.h: Adjust extern decls to match.
792
793 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
794 EMACS_INT, since either will do, for xpalloc.
795
796 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
797 (xnmalloc, xnrealloc, xpalloc): New functions.
798
726e0ab1
PE
799 * bidi.c (bidi_shelve_header_size): New constant.
800 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
801 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
802
51f30bc5 803 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
804 * buffer.c (overlays_at, overlays_in, record_overlay_string)
805 (overlay_strings):
806 Don't update size of array until after memory allocation succeeds,
807 because xmalloc/xrealloc may not return.
0065d054
PE
808 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
809 now that we have proper integer overflow checking.
810 (record_overlay_string, overlay_strings): Catch overflows when
811 calculating size of overlay_str_buf.
726e0ab1 812
0065d054
PE
813 * callproc.c (Fcall_process): Check for size overflow when
814 calculating size of args2.
815 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
816 Normally we prefer signed values, but sticking with ptrdiff_t would
817 require adding more-complicated checks.
726e0ab1
PE
818
819 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
820 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
821 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 822 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
823
824 * character.c (Fstring): Check for size-calculation overflow.
825
826 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
827 unnecessary integer overflow. Check for size overflow.
828 (encode_coding_object): Don't update size until xmalloc succeeds.
829
830 * composite.c (get_composition_id): Check for overflow in glyph
831 length calculations.
832
833 Integer and memory overflow fixes for display code.
834 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
835 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
836 (scrolling_window): Check for overflow in size calculations.
837 (line_draw_cost, realloc_glyph_pool, add_row_entry):
838 Don't assume glyph table len fits in int.
839 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
840 (row_table_size): Now ptrdiff_t, not int.
841 (scrolling_window): Avoid overflow in size calculations.
842 Don't update size until allocation succeeds.
843 * fns.c (concat): Check for overflow in size calculations.
844 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
845 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
846 (NEXT_ALMOST_PRIME_LIMIT): New constant.
847
848 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
849 (get_doc_string): Check for size calculation overflow.
850 Don't update size until allocation succeeds.
851 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
852 EMACS_INT, where ptrdiff_t will do.
853 (Fsubstitute_command_keys): Check for string overflow.
854
855 * editfns.c (set_time_zone_rule): Don't assume environment length
856 fits in int.
857 (message_length): Now ptrdiff_t, not int.
858 (Fmessage_box): Don't update size until allocation succeeds.
859 Don't assume message length fits in int.
860 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
861
0065d054
PE
862 * emacs.c (main): Do not reallocate argv, since there is a null at
863 the end that can be overwritten, and this way there's no need to
864 worry about size-calculation overflow.
865 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
866
867 * eval.c (init_eval_once, grow_specpdl): Don't update size until
868 alloc succeeds.
869 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
870
871 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
872 (x_set_scroll_bar_width, x_figure_window_size):
873 Check for integer overflow.
874 (x_set_alpha): Do not assume XINT fits in int.
875
876 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
877 This is for the members text_lines, text_cols, total_lines, total_cols,
878 where the system imposes an 'int' limit.
879
880 * fringe.c (Fdefine_fringe_bitmap):
881 Don't update size until alloc works.
882
883 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
884 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
885
886 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
887 Check for size-calculation overflow.
888 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
889 do, as we prefer signed integers.
890 (id_to_widget.max_size, id_to_widget.used)
891 (xg_store_widget_in_map, xg_remove_widget_from_map)
892 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
893 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
894 Use and return ptrdiff_t, not int.
895 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
896 * gtkutil.h: Change prototypes to match the above.
897
898 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
899 are duplicate now that they've been promoted to lisp.h.
900 (x_allocate_bitmap_record, x_alloc_image_color)
901 (make_image_cache, cache_image, xpm_load):
902 Don't update size until alloc is done.
903 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
904 (x_detect_edges):
3256efce 905 Check for size calculation overflow.
726e0ab1
PE
906 (ct_colors_allocated_max): New constant.
907 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
908 overflow.
3256efce 909
726e0ab1
PE
910 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
911 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
912 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
913 Use ptrdiff_t, not int, to count maps.
914 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
915 calculations. Don't update size until allocation succeeds.
916 Redo calculations to avoid overflow.
726e0ab1
PE
917 * keyboard.h: Change prototypes to match the above.
918
919 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
920 to count maps.
921 (current_minor_maps): Check for size calculation overflow.
922 * keymap.h: Change prototypes to match the above.
923
924 * lread.c (read1, init_obarray): Don't update size until alloc done.
925
926 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
927 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
928
726e0ab1
PE
929 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
930 Now ptrdiff_t, not int.
931 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
932 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
933
934 * process.c (Fnetwork_interface_list): Check for overflow
935 in size calculation.
936
937 * region-cache.c (move_cache_gap): Check for size calculation overflow.
938
939 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
940 overflow. Don't bother calling xmalloc when xrealloc will do.
941
942 * search.c (Freplace_match): Check for size calculation overflow.
943 (Fset_match_data): Don't assume list lengths fit in 'int'.
944
945 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
946 for command line length. Do not attempt to address one before the
947 beginning of an array, as that's not portable.
948
949 * term.c (max_frame_lines): Remove; unused.
950 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
951 not int.
952 (encode_terminal_code, calculate_costs): Check for size
953 calculation overflow.
954 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
955 table lengths and related sizes. Don't update size until alloc
956 done. Redo calculations to avoid overflow.
957 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
958
959 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
960 subtracting pointers.
961 (gobble_line): Check for overflow more carefully. Don't update size
962 until alloc done.
963
964 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
965 Don't update size until alloc done.
966 Redo size calculations to avoid overflow.
967 Check for size calculation overflow.
0065d054 968 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
969
970 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
971 Use ptrdiff_t, not int, for sizes.
972 (store_mode_line_noprop_char): Don't update size until alloc done.
973
0065d054
PE
974 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
975 Use ptrdiff_t, not int, for sizes.
976 (Finternal_make_lisp_face, cache_face):
977 Check for size calculation overflow.
978 (cache_face): Treat size calculation overflows as if they were
979 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
980
981 * xfns.c (x_encode_text, x_set_name_internal)
982 (Fx_change_window_property): Use ptrdiff_t, not int, to count
983 sizes, since they can exceed INT_MAX in size. Check for size
984 calculation overflow.
985
0065d054
PE
986 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
987 (xg_select): Check for size calculation overflow.
726e0ab1
PE
988 Don't update size until alloc done.
989
0065d054 990 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 991 as sprintf is limited to int lengths.
1d526e2f 992
252c5ee1
PE
993 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
994 (X_LONG_MIN): New macros.
864d7ce7
PE
995 Use them to make the following changes clearer.
996 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
997 This change doesn't affect the value now, but it may help remind
998 future maintainers not to raise the value too much later.
999 (SELECTION_QUANTUM): Remove, replacing with ...
1000 (selection_quantum): ... new function, which avoids overflow.
1001 All uses changed.
1002 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1003 assumption that selection length fits in 'int'.
1004 (x_reply_selection_request, x_handle_selection_request)
1005 (x_get_window_property, receive_incremental_selection)
1006 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1007 (lisp_data_to_selection_data, clean_local_selection_data):
1008 Use ptrdiff_t, not int, to record length of selection.
1009 (x_reply_selection_request, x_get_window_property)
1010 (receive_incremental_selection, x_property_data_to_lisp):
1011 Redo calculations to avoid overflow.
1012 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1013 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1014 something.
1015 (x_get_window_property, receive_incremental_selection)
1016 (lisp_data_to_selection_data, x_property_data_to_lisp):
1017 Check for size-calculation overflow.
1018 (x_get_window_property, receive_incremental_selection)
1019 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1020 Don't store size until memory allocation succeeds.
1021 (x_get_window_property): Plug memory leak on memory exhaustion.
1022 Don't double-block input; malloc is safe here. Don't assume 2**34
1023 - 4 fits in unsigned long. Add an xassert to check
1024 XGetWindowProperty overflow. Be more careful about overflow
1025 calculations, and distinguish size from memory overflow better.
1026 (receive_incremental_selection): When tracing, don't assume
1027 unsigned int is less than INT_MAX.
1028 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1029 harmful) conversions of unsigned short to int.
1030 (lisp_data_to_selection_data): Don't assume that integers
1031 in the range -65535 through -1 fit in an X unsigned short.
1032 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1033 result parameters unless successful. Rely on cons_to_unsigned
1034 to report problems with elements; the old code wasn't right anyway.
1035 (x_check_property_data): Check for int overflow; we cannot use
1036 a wider type due to X limits.
1037 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1038
726e0ab1 1039 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1040
0065d054
PE
1041 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1042 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1043 (x_color_cells): Don't store size until memory allocation succeeds.
1044 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1045 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1046 (x_term_init): Don't assume length fits in int (sprintf is limited
1047 to int size).
bc18e09d 1048
ebfa62c0
PE
1049 Use ptrdiff_t for composition IDs.
1050 * character.c (lisp_string_width):
1051 * composite.c (composition_table_size, n_compositions)
1052 (get_composition_id, composition_gstring_from_id):
1053 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1054 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1055 * window.c (Frecenter):
1056 Use ptrdiff_t, not int, for composition IDs.
1057 * composite.c (get_composition_id): Check for integer overflow.
1058 * composite.h: Adjust prototypes to match the above changes.
1059
d3411f89
PE
1060 Use ptrdiff_t for hash table indexes.
1061 * category.c (hash_get_category_set):
1062 * ccl.c (ccl_driver):
1063 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1064 * coding.c (coding_system_charset_list, detect_coding_system):
1065 * coding.h (struct coding_system.id):
1066 * composite.c (get_composition_id, gstring_lookup_cache):
1067 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1068 * image.c (xpm_get_color_table_h):
1069 * lisp.h (hash_lookup, hash_put):
1070 * minibuf.c (Ftest_completion):
1071 Use ptrdiff_t for hash table indexes, not int (which is too
1072 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1073 32-bit --with-wide-int hosts).
1074
e097a6fa
PE
1075 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1076 Add a FIXME comment about memory leaks.
1077 (syms_of_charset): Don't assume xmalloc returns.
1078
5637687f
PE
1079 Don't assume that stated character widths fit in int.
1080 * character.c (Fchar_width, c_string_width, lisp_string_width):
1081 * character.h (CHAR_WIDTH):
1082 * indent.c (MULTIBYTE_BYTES_WIDTH):
1083 Use sanitize_char_width to avoid undefined and/or bad behavior
1084 with outlandish widths.
a66cfb1c 1085 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1086 now that we have two such functions. All uses changed.
1087 (sanitize_char_width): New inline function.
1088
a2271ba2
PE
1089 Don't assume that tab-width fits in int.
1090 * character.h (sanitize_width): New inline function.
1091 (SANE_TAB_WIDTH): New macro.
1092 (ASCII_CHAR_WIDTH): Use it.
1093 * indent.c (sane_tab_width): Remove. All uses replaced by
1094 SANE_TAB_WIDTH (current_buffer).
1095 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1096
18c52557
PE
1097 * fileio.c: Integer overflow issues with file modes.
1098 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1099
caeeedc1
PE
1100 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1101 Remove unreachable code.
1102 (read_hex, load_charset_map_from_file): Check for integer overflow.
1103
50849c52
PE
1104 * xterm.c: don't go over XClientMessageEvent limit
1105 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1106 (x_send_scroll_bar_event): Likewise. Check that the size does not
1107 exceed limits imposed by XClientMessageEvent, as well as the usual
1108 ptrdiff_t and size_t limits.
1109
b13995db
PE
1110 * keyboard.c: Overflow, signedness and related fixes.
1111 (make_lispy_movement): Use same integer type in forward decl
1112 that is used in the definition.
1113 (read_key_sequence, keyremap_step):
1114 Change bufsize argument back to int, undoing my 2011-03-30 change.
1115 We prefer signed types, and int is wide enough here.
1116 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1117 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1118 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1119 length, not size_t. Use ptrdiff_t for index, not int.
1120 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1121 possibility of integer overflow.
1122
13464394
PE
1123 Overflow, signedness and related fixes for images.
1124
1125 * dispextern.h (struct it.stack[0].u.image.image_id)
1126 (struct_it.image_id, struct image.id, struct image_cache.size)
1127 (struct image_cache.used, struct image_cache.ref_count):
1128 * gtkutil.c (update_frame_tool_bar):
1129 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1130 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1131 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1132 * nsmenu.m (update_frame_tool_bar):
1133 * xdisp.c (calc_pixel_width_or_height):
1134 * xfns.c (image_cache_refcount):
1135 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1136 on typical 64-bit hosts.
1137
1138 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1139 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1140 Omit unnecessary casts to int.
1141 (parse_image_spec): Check that integers fall into 'int' range
1142 when the callers expect that.
1143 (image_ascent): Redo ascent calculation to avoid int overflow.
1144 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1145 (lookup_image): Remove unnecessary tests.
1146 (xbm_image_p): Locals are now of int, not EMACS_INT,
1147 since parse_image_check makes sure they fit into int.
1148 (png_load, gif_load, svg_load_image):
1149 Prefer int to unsigned where either will do.
1150 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1151 old tiff_error_handler and tiff_warning_handler.
1152 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1153 stack buffer overflows. It uses only the features of vsnprintf
1154 that are common to both POSIX and native Microsoft.
1155 (tiff_error_handler, tiff_warning_handler): Use it.
1156 (tiff_load, gif_load, imagemagick_load_image):
1157 Don't assume :index value fits in 'int'.
1158 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1159 (imagemagick_load_image): Check that crop parameters fit into
1160 the integer types that MagickCropImage accepts. Don't assume
1161 Vimagemagick_render_type has a nonnegative value. Don't assume
1162 size_t fits in 'long'.
1163 (gs_load): Use printmax_t to print the widest integers possible.
1164 Check for integer overflow when computing image height and width.
1165
c11821d4
EZ
11662011-08-26 Eli Zaretskii <eliz@gnu.org>
1167
1168 * xdisp.c (redisplay_window): Don't force window start if point
1169 will be invisible in the resulting window. (Bug#9324)
1170
0c95fcf7
EZ
11712011-08-25 Eli Zaretskii <eliz@gnu.org>
1172
1173 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1174 the display spec is of the form `(space ...)'.
1175 (handle_display_spec): Return the value returned by
1176 handle_single_display_spec, not just 1 or zero.
1177 (handle_single_display_spec): If the display spec is of the form
1178 `(space ...)', and specifies display in the text area, return 2
1179 rather than 1.
fee65a97 1180 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1181 accurately, and prefer exact match for point under bidi.
1182 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1183
1184 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1185 into disp_prop; all users changed.
1186
1187 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1188 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1189 for the text covered by the display property.
1190
e4ed06f1
CY
11912011-08-25 Chong Yidong <cyd@stupidchicken.com>
1192
1193 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1194 Change return value to nil.
1195 (Frecord_buffer): Delete unused function.
1196
f67cdd7f
EZ
11972011-08-24 Eli Zaretskii <eliz@gnu.org>
1198
5980d4c6
EZ
1199 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1200 buffers, return left-to-right.
8610fe8b
EZ
1201 (set_cursor_from_row): Consider candidate row a win if its glyph
1202 represents a newline and point is on that newline. Fixes cursor
1203 positioning on the newline at EOL of R2L text within L2R
1204 paragraph, and vice versa.
1205 (try_cursor_movement): Check continued rows, in addition to
1206 continuation rows. Fixes unwarranted scroll when point enters a
1207 continued line of R2L text within an L2R paragraph, or vice versa.
1208 (cursor_row_p): Consider the case of point being equal to
1209 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1210 from the end of a short line to the beginning of a continued line
1211 of R2L text within L2R paragraph.
1212 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1213 composed characters.
5980d4c6 1214
f67cdd7f
EZ
1215 * bidi.c (bidi_check_type): Use xassert.
1216 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1217 members.
1218
bca633fb
EZ
12192011-08-23 Eli Zaretskii <eliz@gnu.org>
1220
1221 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1222 a character.
1223
4a5885a7
CY
12242011-08-23 Chong Yidong <cyd@stupidchicken.com>
1225
1226 * nsfont.m (ns_otf_to_script): Fix typo.
1227
0902a04e
KH
12282011-08-22 Kenichi Handa <handa@m17n.org>
1229
1230 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1231 extra slot even if the purpose is char-code-property-table.
1232
1a2e6670
EZ
12332011-08-23 Eli Zaretskii <eliz@gnu.org>
1234
8ddde651
EZ
1235 * xdisp.c (redisplay_window): When computing centering_position,
1236 account for the height of the header line. (Bug#8874)
1237
425cc014
EZ
1238 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1239 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1240 candidate is selected by the mouse, and that candidate has a
1241 composed character under the mouse.
1242
1a2e6670
EZ
1243 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1244 coordinates reported by pos-visible-in-window-p for a composed
1245 character in column zero.
1246
8b76d6f8
SM
12472011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1248
1249 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1250
dac347dd
EZ
12512011-08-22 Eli Zaretskii <eliz@gnu.org>
1252
1253 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1254 consider it a hit if to_charpos is anywhere in the range of the
1255 composed buffer positions.
1256
e013fb34
CY
12572011-08-22 Chong Yidong <cyd@stupidchicken.com>
1258
1259 * image.c (gif_load): Don't assume that each subimage has the same
1260 dimensions as the base image. Handle disposal method that is
1261 "undefined" by the gif spec (Bug#9335).
1262
bd1ba3e8
CY
12632011-08-20 Chong Yidong <cyd@stupidchicken.com>
1264
1265 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1266 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1267
54a1215b
EZ
12682011-08-19 Eli Zaretskii <eliz@gnu.org>
1269
823564e5
EZ
1270 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1271 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1272 from an Org mode buffer to a Speedbar frame.
1273
54a1215b
EZ
1274 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1275 a composition, take its buffer position from IT->cmp_it.charpos.
1276 Fixes cursor positioning at the beginning of a line that begins
1277 with a composed character.
1278
9778ebcc
EZ
12792011-08-18 Eli Zaretskii <eliz@gnu.org>
1280
0be6ee06
EZ
1281 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1282 character bidirectional type, use STRONG_L instead. Fixes crashes
1283 in a buffer produced by `describe-categories'.
1284
9778ebcc
EZ
1285 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1286 members before the level stack, so they would be saved and
1287 restored when copying iterator state. Fixes incorrect reordering
1288 around TABs covered by display properties.
1289
156bffbe
AS
12902011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1291
1292 * process.c (Fnetwork_interface_list): Correctly determine buffer
1293 size.
1294
72ad093b
CY
12952011-08-17 Chong Yidong <cyd@stupidchicken.com>
1296
1297 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1298 (internal_condition_case_2, internal_condition_case_n):
1299 Remove unnecessary aborts (Bug#9081).
72ad093b 1300
35774242
EZ
13012011-08-17 Eli Zaretskii <eliz@gnu.org>
1302
1303 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1304 has no `load' handler, try opening the file locally. (Bug#9311)
1305
db76dd85
KB
13062011-08-16 Ken Brown <kbrown@cornell.edu>
1307
1308 * gmalloc.c: Expand comment.
1309
b215eee5
EZ
13102011-08-16 Eli Zaretskii <eliz@gnu.org>
1311
1312 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1313 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1314
a4579d33
KB
13152011-08-16 Ken Brown <kbrown@cornell.edu>
1316
1317 Fix memory allocation problems in Cygwin build (Bug#9273).
1318
1319 * unexcw.c ( __malloc_initialized): Declare external variable.
1320 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1321
8b76d6f8
SM
1322 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1323 New variables.
a4579d33
KB
1324 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1325 dumped emacs.
1326 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1327 in the static heap.
1328 [CYGWIN] (special_realloc): New function.
1329 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1330 requests to realloc storage in the static heap.
1331
3ebec551
PE
13322011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1333
1334 * bidi.c (bidi_initialize): Remove unused local.
1335
9fd8be00
EZ
13362011-08-15 Eli Zaretskii <eliz@gnu.org>
1337
474a8465
EZ
1338 * biditype.h: File removed.
1339
1340 * bidimirror.h: File removed.
1341
1342 * deps.mk (bidi.o): Remove biditype.h and
1343 bidimirror.h.
1344
1345 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1346 bidimirror.h.
1347
1348 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1349
1350 * chartab.c: Improve commentary for the uniprop_table API.
1351
32413314
EZ
1352 * bidi.c (bidi_paragraph_init): Support zero value of
1353 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1354 (bidi_initialize): Use uniprop_table instead of including
1355 biditype.h and bidimirror.h.
32413314 1356
9fd8be00
EZ
1357 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1358 coordinates of the iterator when restoring from ppos_it.
1359 (Bug#9296)
1360
5cf2b69b
KH
13612011-08-14 Kenichi Handa <handa@m17n.org>
1362
1363 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1364 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1365
daf17d00
EZ
13662011-08-14 Eli Zaretskii <eliz@gnu.org>
1367
1368 * xdisp.c (move_it_in_display_line_to): Don't invoke
1369 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1370 ppos_it. Fixes vertical cursor motion when line beginning is
1371 covered by an image. (Bug#9296)
1372
08e3161a
JD
13732011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1374
1375 * nsterm.h (ns_run_ascript): Declare.
1376 (NSAPP_DATA2_RUNASSCRIPT): Define.
1377
1378 * nsfns.m (as_script, as_result, as_status): New static variables.
1379 (ns_run_ascript): New function.
5e617bc2 1380 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1381 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1382 the event loop. Get status from as_status (Bug#7276).
1383
1384 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1385 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1386 the event loop (Bug#7276).
1387
a3720aa2
AS
13882011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1389
1390 * gnutls.c (QCgnutls_bootprop_priority)
1391 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1392 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1393 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1394 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1395 (QCgnutls_bootprop_verify_hostname_error)
1396 (QCgnutls_bootprop_callbacks_verify): Rename from
1397 Qgnutls_bootprop_..., all uses changed.
1398
1399 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1400 uses changed.
1401
0a0d27fb
PE
14022011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1403
19d5c50c
PE
1404 * xfaces.c (Qframe_set_background_mode): Now static.
1405 * dispextern.h (Qframe_set_background_mode): Remove decl.
1406
0a0d27fb
PE
1407 * process.c (Fnetwork_interface_info): Declare local only if needed.
1408
377538cb
JD
14092011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1410
1411 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1412 (Fnetwork_interface_list): Allocate in increments of bytes instead
1413 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1414 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1415 sockaddr.
1416 (struct ifflag_def): notrailers is smart on OSX.
1417 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1418 Get hardware address with getifaddrs if available.
1419
08fff70c
EZ
14202011-08-12 Eli Zaretskii <eliz@gnu.org>
1421
1422 * xdisp.c (iterate_out_of_display_property): xassert that
1423 IT->position is set to within IT->object's boundaries. Break from
1424 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1425 when IT->position is set up wrongly due to some bug.
1426 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1427 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1428 entry. Force push_it to save on the stack the current
1429 buffer/string position, to be restored by pop_it. Fix flags in
1430 the iterator structure wrt the object coming from a display
1431 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1432 properties. (Bug#9284)
1433
7be1c708 14342011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1435
7be1c708
CY
1436 * fontset.c (fontset_get_font_group): Add proper type checks.
1437 (Bug#9172)
aac0c6e3 1438
7be1c708 14392011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1440
7be1c708
CY
1441 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1442 and LC_VERSION_MIN_MACOSX.
1443 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1444 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1445
97bb72a6
EZ
14462011-08-08 Eli Zaretskii <eliz@gnu.org>
1447
1448 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1449 no-display-properties-and-no-overlays under bidi display.
1450 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1451 properties and overlays.
97bb72a6 1452
d5617611
CY
14532011-08-08 Chong Yidong <cyd@stupidchicken.com>
1454
37e11a63
CY
1455 * editfns.c (Fset_time_zone_rule): Document relationship with the
1456 setenv function.
1457
d5617611
CY
1458 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1459 the font entity extracted from the cache (Bug#8109).
1460
58872834
CY
14612011-08-07 Chong Yidong <cyd@stupidchicken.com>
1462
1463 * composite.c (autocmp_chars): Don't reset point. That is done by
1464 restore_point_unwind (Bug#5984).
1465
75bfc667
JL
14662011-08-07 Juri Linkov <juri@jurta.org>
1467
1468 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1469 to show the arg `TIME' instead of `TIMEVAL'.
1470
d1410150
EZ
14712011-08-06 Eli Zaretskii <eliz@gnu.org>
1472
1473 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1474 display property strides EOL and includes a newline, as in
1475 longlines-mode. (Bug#9254)
75b771e4
EZ
1476 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1477 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1478
1479 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1480 is non-zero, even if the data buffer is NULL. Fixes a crash in
1481 vertical-motion with longlines-mode. (Bug#9254)
1482
35928349
EZ
14832011-08-05 Eli Zaretskii <eliz@gnu.org>
1484
ec7cc85b
EZ
1485 * bidi.c <bidi_cache_total_alloc>: Now static.
1486 (bidi_initialize): Initialize bidi_cache_total_alloc.
1487
8b76d6f8 1488 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1489 cache. (Bug#9221)
1490
1491 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1492 amount allocated this far in `bidi_cache_total_alloc'.
1493 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1494 non-zero, only free the data buffer without restoring the cache
1495 contents. All callers changed.
1496
1497 * dispextern.h (bidi_unshelve_cache): Update prototype.
1498
1499 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1500 (move_it_in_display_line, move_it_to)
1501 (move_it_vertically_backward, move_it_by_lines): Replace the call
1502 to xfree to an equivalent call to bidi_unshelve_cache.
1503 (move_it_in_display_line_to): Fix logic of returning
412b6358 1504 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1505
e2e2423b
EZ
15062011-08-05 Eli Zaretskii <eliz@gnu.org>
1507
1508 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1509 came from a string character with a `cursor' property. (Bug#9229)
1510
ae9e757a
JD
15112011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1512
1513 * Makefile.in (LIB_PTHREAD): New variable.
1514 (LIBES): Add LIB_PTHREAD (Bug#9216).
1515
1516 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1517 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1518
213bd7f2
AS
15192011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1520
1521 * regex.c (re_iswctype): Remove some redundant boolean
1522 conversions.
1523
99aaf75f
JD
15242011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1525
1526 * xterm.c (x_find_topmost_parent): New function.
1527 (x_set_frame_alpha): Find topmost parent window with
1528 x_find_topmost_parent and set the property there also (bug#9181).
1529 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1530
c74e9d86
PE
15312011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1532
1533 * callproc.c (Fcall_process): Avoid vfork clobbering
1534 the local vars buffer, coding_systems, current_dir.
1535
640c8776
SM
15362011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1537
1538 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1539
f26d0e4c
PE
15402011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1541
8a10d76c
PE
1542 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1543 so that it is not optimized away.
1544
f26d0e4c
PE
1545 * xdisp.c (compute_display_string_pos): Remove unused local.
1546
55439c61
EZ
15472011-08-02 Eli Zaretskii <eliz@gnu.org>
1548
1549 Fix slow cursor motion and scrolling in large buffers with
1550 selective display, like Org Mode buffers. (Bug#9218)
1551
1552 * dispextern.h (struct bidi_it): New member disp_prop_p.
1553
1554 * xdisp.c: Remove one-slot cache of display string positions.
1555 (compute_display_string_pos): Accept an additional argument
5e617bc2 1556 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1557 for a display string or property. If found, set DISP_PROP_P
1558 non-zero.
1559
1560 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1561 DISP_PROP_P, and pass it to compute_display_string_pos.
1562 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1563 non-zero. All callers of bidi_fetch_char changed.
1564
fb33fa43
SM
15652011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1566
1567 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1568
b099e063
DM
15692010-12-03 Don March <don@ohspite.net>
1570
1571 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1572 last character M-[char] is translated to ESC [char] (bug#7541).
1573
5cc7f7af
KH
15742011-08-02 Kenichi Handa <handa@m17n.org>
1575
d0fffa3f 1576 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1577
1578 * chartab.c (uniprop_table): Make it non-static.
1579
525d5e6e
EZ
15802011-08-01 Eli Zaretskii <eliz@gnu.org>
1581
1582 * xdisp.c (forward_to_next_line_start): Accept additional argument
1583 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1584 on the newline.
1585 (reseat_at_next_visible_line_start): Use the bidi iterator state
1586 returned by forward_to_next_line_start to restore the state of
1587 it->bidi_it after backing up to previous newline. (Bug#9212)
1588
31011111
AS
15892011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1590
1591 * regex.c (re_comp): Protoize.
1592 (re_exec): Fix return type.
1593 (regexec): Fix type of `ret'. (Bug#9203)
1594
476371c4
PE
15952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1596
e5d76069
PE
1597 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1598 This is needed if max-image-size is a floating-point number.
1599
9a79b20c
AS
16002011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1601
1602 * print.c (print_object): Print empty symbol as ##.
1603
1604 * lread.c (read1): Read ## as empty symbol.
1605
d8c2fa78
AA
16062011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1607
1608 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1609 setting frame foreground color (Bug#9175).
1610 (x_set_background_color): Likewise.
1611
ffe57a7a
AA
1612 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1613 contents (Bug#9176).
1614 (EmacsTooltip -init): Remove bezels and add shadows to
1615 tooltip windows.
1616
bf3492a5
AA
1617 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1618 or scroll bar (Bug#8470).
1619
d55e9c53
AA
1620 * nsfont.m (nsfont_open): Remove assignment to voffset and
1621 unnecessary vars hshink, expand, hd, full_height, min_height.
1622 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1623
1624 * nsterm.h (nsfont_info): Remove voffset field.
1625
d8c2fa78 16262011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1627
1628 Implement strike-through and overline on NextStep (Bug#8863).
1629
1630 * nsfont.m (nsfont_open): Use underline position provided by font,
1631 instead of hard-coded value of 2.
1632 (nsfont_draw): Call ns_draw_text_decoration instead.
1633
1634 * nsterm.h: Add declaration for ns_draw_text_decoration.
1635
1636 * nsterm.m (ns_draw_text_decoration): New function for drawing
1637 underline, overline, and strike-through.
1638 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1639 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1640 accommodate underlining, etc.
4843aac3 1641
4cc60b9b
EZ
16422011-07-28 Eli Zaretskii <eliz@gnu.org>
1643
bc7ece87
EZ
1644 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1645 default.
4cc60b9b 1646
476371c4
PE
16472011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1648
66606eea
PE
1649 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1650 Without this fix, if a signal arrives just after memory fills up,
1651 'malloc' might be invoked reentrantly.
1652
476371c4
PE
1653 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1654 In other words, assume that every image size is allowed, on non-X
1655 hosts. This assumption is probably wrong, but it lets Emacs compile.
1656
f3fcc40d
AS
16572011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1658
1659 * regex.c (re_iswctype): Convert return values to boolean.
1660
350c992f
EZ
16612011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1662
1663 * xdisp.c (compute_display_string_pos): Don't use cached display
1664 string position if the buffer had its restriction changed.
1665 (Bug#9184)
1666
5266b4bb
PE
16672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1668
1669 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1670
2573a837 16712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1672
41f55ccd 1673 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1674
39e378da
PE
1675 * bidi.c: Integer size and overflow fixes.
1676 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1677 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1678 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1679 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1680 (bidi_find_other_level_edge):
1681 Use ptrdiff_t instead of EMACS_INT where either will do.
1682 This works better on 32-bit hosts configured --with-wide-int.
1683 (bidi_cache_ensure_space): Check for size-calculation overflow.
1684 Use % rather than repeated addition, for better worst-case speed.
1685 Don't set bidi_cache_size until after xrealloc returns, because it
1686 might not return.
1687 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1688 (bidi_cache_ensure_space): Also check that the bidi cache size
1689 does not exceed that of the largest Lisp string or buffer. See Eli
1690 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1691
5e927815
PE
1692 * alloc.c (__malloc_size_t): Remove.
1693 All uses replaced by size_t. See Andreas Schwab's note
1694 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1695
ca4aa935
PE
1696 * image.c: Improve checking for integer overflow.
1697 (check_image_size): Assume that f is nonnull, since
1698 it is always nonnull in practice. This is one less thing to
1699 worry about when checking for integer overflow later.
1700 (x_check_image_size): New function, which checks for integer
1701 overflow issues inside X.
1702 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1703 This removes the need for a memory_full check.
1704 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1705 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1706 (xbm_read_bitmap_data): Change locals back to 'int', since
1707 their values must fit in 'int'.
1708 (xpm_load_image, png_load, tiff_load):
1709 Invoke x_create_x_image_and_pixmap earlier,
1710 to avoid much needless work if the image is too large.
1711 (tiff_load): Treat overly large images as if
1712 x_create_x_image_and_pixmap failed, not as malloc failures.
1713 (gs_load): Use x_check_image_size.
1714
5f8f9cc2
PE
1715 * gtkutil.c: Omit integer casts.
1716 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1717 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1718
5adf60bc
PE
1719 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1720
c8907a93
PE
1721 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1722 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1723 would wrongly return t on a 64-bit host.
1724
e3c25c68
PE
1725 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1726 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1727 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1728 and therefore cause GCC to emit a bogus diagnostic in some cases.
1729
3f791afe
PE
1730 * image.c: Integer signedness and overflow and related fixes.
1731 This is not an exhaustive set of fixes, but it's time to
1732 record what I've got.
1733 (lookup_pixel_color, check_image_size): Remove redundant decls.
1734 (check_image_size): Don't assume that arbitrary EMACS_INT values
1735 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1736 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1737 (tiff_load, imagemagick_load_image):
1738 Check for overflow in size calculations.
1739 (x_create_x_image_and_pixmap): Remove unnecessary test for
1740 xmalloc returning NULL; that can't happen.
1741 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1742 (xpm_color_bucket): Use better integer hashing function.
1743 (xpm_cache_color): Don't possibly over-allocate memory.
1744 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1745 (gif_memory_source):
1746 Use ptrdiff_t, not int or size_t, to record sizes.
1747 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1748 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1749 either works, as we prefer signed integers.
1750 (tiff_read_from_memory, tiff_write_from_memory):
1751 Return tsize_t, not size_t, since that's what the TIFF API wants.
1752 (tiff_read_from_memory): Don't fail simply because the read would
1753 go past EOF; instead, return a short read.
1754 (tiff_load): Omit no-longer-needed casts.
1755 (Fimagemagick_types): Don't assume size fits into 'int'.
1756
3cc5a532
PE
1757 Improve hashing quality when configured --with-wide-int.
1758 * fns.c (hash_string): New function, taken from sxhash_string.
1759 Do not discard information about ASCII character case; this
1760 discarding is no longer needed.
1761 (sxhash-string): Use it. Change sig to match it. Caller changed.
1762 * lisp.h: Declare it.
1763 * lread.c (hash_string): Remove, since we now use fns.c's version.
1764 The fns.c version returns a wider integer if --with-wide-int is
1765 specified, so this should help the quality of the hashing a bit.
1766
b312a492
PE
1767 * emacs.c: Integer overflow minor fix.
1768 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1769 Define only if GNU_LINUX.
1770 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1771
dfd153ae
PE
1772 * dispnew.c: Integer signedness and overflow fixes.
1773 Remove unnecessary forward decls, that were a maintenance hassle.
1774 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1775 All uses changed.
1776 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1777 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1778 (prepare_desired_row, line_draw_cost):
1779 Use int, not unsigned, where either works.
1780 (save_current_matrix, restore_current_matrix):
1781 Use ptrdiff_t, not size_t, where either works.
1782 (init_display): Check for overflow more accurately, and without
1783 relying on undefined behavior.
1784
a81d11a3
PE
1785 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1786 Remove, replacing with the new symbols in lisp.h. All uses changed.
1787 * fileio.c (make_temp_name):
1788 * filelock.c (lock_file_1, lock_file):
1789 * xdisp.c (message_dolog):
1790 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1791 Use pMd etc. instead.
1792 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1793 replacing the pWIDE etc. symbols removed from editfns.c.
1794
3300e6fd
PE
1795 * keyboard.h (num_input_events): Now uintmax_t.
1796 This is (very slightly) less likely to mess up due to wraparound.
1797 All uses changed.
1798
fd05c7e9
PE
1799 * buffer.c: Integer signedness fixes.
1800 (alloc_buffer_text, enlarge_buffer_text):
1801 Use ptrdiff_t rather than size_t when either will do, as we prefer
1802 signed integers.
1803
903fe15d
PE
1804 * alloc.c: Integer signedness and overflow fixes.
1805 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1806 (__malloc_size_t): Default to size_t, not to int.
1807 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1808 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1809 Prefer ptrdiff_t to size_t when either would do, as we prefer
1810 signed integers.
1811 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1812 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1813 Now const. Initialize with values that are in range even if char
1814 is signed.
1815 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1816 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1817 These functions do the right thing with sizes > 2**32.
1818 (check_depth): Now ptrdiff_t, not int.
1819 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1820 Adjust to new way of storing sizes. Check for size overflow bugs
1821 in rest of code.
1822 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1823 slightly wrong anyway, as it missed one instance of
1824 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1825 (refill_memory_reserve): Omit needless cast to size_t.
1826 (mark_object_loop_halt): Mark as externally visible.
1827
ac82cc6a
PE
1828 * xselect.c: Integer signedness and overflow fixes.
1829 (Fx_register_dnd_atom, x_handle_dnd_message):
1830 Use ptrdiff_t, not size_t, since we prefer signed.
1831 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1832 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1833 x_dnd_atoms_size and x_dnd_atoms_length.
1834
c2d1e36d
PE
1835 * doprnt.c: Prefer signed to unsigned when either works.
1836 * eval.c (verror):
1837 * doprnt.c (doprnt):
1838 * lisp.h (doprnt):
1839 * xdisp.c (vmessage):
1840 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1841 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1842 prefer signed arithmetic to avoid comparison confusion.
1843 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1844 but is a bit tricky.
1845
0e926e56
PE
1846 Assume freestanding C89 headers, string.h, stdlib.h.
1847 * data.c, doprnt.c, floatfns.c, print.c:
1848 Include float.h unconditionally.
1849 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1850 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1851 * regex.c: Likewise for stddef.h, string.h.
1852 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1853 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1854 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1855 (STDC_HEADERS): Remove obsolete defines.
1856 * sysdep.c: Include limits.h unconditionally.
1857
9cfdb3ec
PE
1858 Assume support for memcmp, memcpy, memmove, memset.
1859 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1860 * regex.c (memcmp, memcpy):
1861 Remove; we assume C89 now.
1862
1863 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1864 (__malloc_safe_bcopy): Remove; no longer needed.
1865
cf950e6b 1866 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1867 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1868 well either way, and we prefer signed to unsigned.
1869
dbf38e02
LMI
18702011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1871
1872 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1873 closes the connection while we're reading (bug#9182).
1874
d6f0886c 18752011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1876
d6f0886c
JD
1877 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1878 are specified (Bug#9168).
24e0f6b1 1879
2eb1f9e6
PE
18802011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1881
1882 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1883 Found by GCC static checking and --with-wide-int on a 32-bit host.
1884
22381272 18852011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1886
1887 * xdisp.c (compute_display_string_pos): Fix logic of caching
1888 previous display string position. Initialize cached_prev_pos to
1889 -1. Fixes slow-down at the beginning of a buffer.
1890
f25e39b4
EZ
18912011-07-24 Eli Zaretskii <eliz@gnu.org>
1892
1893 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1894 for attrs[LFACE_FONTSET_INDEX].
1895
04c4b52e
PE
18962011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1897
1898 * xml.c (parse_region): Remove unused local
1899 that was recently introduced.
1900
c1734fbd
EZ
19012011-07-23 Eli Zaretskii <eliz@gnu.org>
1902
be18c5a5
EZ
1903 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1904 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1905
c1734fbd
EZ
1906 * xdisp.c (move_it_in_display_line_to): Record the best matching
1907 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1908 exit if none of the characters scanned was an exact match.
1909 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1910 when exact match is impossible due to invisible text, and the
1911 lines are truncated.
1912
a258d627
JD
19132011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1914
1915 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1916 for OSX >= 10.7.
1917
b6d5a689
EZ
19182011-07-22 Eli Zaretskii <eliz@gnu.org>
1919
0f74f785
EZ
1920 Fix a significant slow-down of cursor motion with C-n, C-p,
1921 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1922 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1923 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1924 (next_element_from_buffer): Call compute_stop_pos_backwards to
1925 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1926 base_level_stop.
1927 (reseat): Don't look for prev_stop, as that could mean a very long
1928 run.
1929 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1930 <cached_disp_overlay_modiff>: Cache for last found display string
1931 position.
551918c1 1932 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1933 about the same buffer in the same area of character positions, and
1934 the buffer wasn't changed since the time the display string
1935 position was cached.
551918c1 1936
b2d0c91a
EZ
19372011-07-22 Eli Zaretskii <eliz@gnu.org>
1938
1939 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1940 is an integer, which is important for empty lines. (Bug#9149)
1941
043604ee
CY
19422011-07-22 Chong Yidong <cyd@stupidchicken.com>
1943
1944 * frame.c (Fmodify_frame_parameters): In tty case, update the
1945 default face if necessary (Bug#4238).
1946
da4adb04
CY
19472011-07-21 Chong Yidong <cyd@stupidchicken.com>
1948
1949 * editfns.c (Fstring_to_char): No need to explain what a character
1950 is in the docstring (Bug#6576).
1951
9abd0532
LMI
19522011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1953
1954 * xml.c (parse_region): Make sure we always return a tree.
1955
36881d16
HK
19562011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1957
1958 * xml.c (parse_region): If a document contains only comments,
1959 return that, too.
1960
1e98674d
LMI
19612011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1962
1963 * xml.c (make_dom): Return comments, too.
1964
590bd467
PE
19652011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1966
1967 Port to OpenBSD.
1968 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1969 and the surrounding thread.
1970 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1971 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1972 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1973 timer goes off.
1974 * s/openbsd.h (BROKEN_SIGIO): Define.
1975 * unexelf.c (unexec) [__OpenBSD__]:
1976 Don't update the .mdebug section of the Alpha COFF symbol table.
1977
f41628b2
LMI
19782011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1979
1980 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1981 (bug#8460).
1982
b59b67c5
PE
19832011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1984
15e3a074
PE
1985 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1986 This fixes some race conditions on the permissions of any newly
1987 created file.
1988
41bed37d
PE
1989 * alloc.c (valid_pointer_p): Use pipe, not open.
1990 This fixes some permissions issues when debugging.
1991
b59b67c5
PE
1992 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1993 If fchown fails to set both uid and gid, try to set just gid,
1994 as that is sometimes allowed. Adjust the file's mode to eliminate
1995 setuid or setgid bits that are inappropriate if fchown fails.
1996
925a6be7
SM
19972011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1998
1999 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2000 to compare Lisp_Objects.
2001 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2002 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2003 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2004
52968808
AS
20052011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2006
0a6a104b
AS
2007 * lread.c (read_integer): Unread even EOF character.
2008 (read1): Likewise. Properly record start position of symbol.
2009
52968808
AS
2010 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2011 symbol character follows.
2012
9e381cdd
PE
20132011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2014
2015 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2016 This works around a problem with the previous change to Fcopy_file.
2017 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2018 and without this change, GCC might complain about discarding
2019 fchown's return value.
2020
b5641435
JB
20212011-07-16 Juanma Barranquero <lekktu@gmail.com>
2022
2023 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2024
a8031457
PE
20252011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2026
2027 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2028
dd889327
LMI
20292011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2030
750c33f7
LMI
2031 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2032 it's used from the C level.
2033
dd889327
LMI
2034 * process.c: Use the same condition for POLL_FOR_INPUT in both
2035 keyboard.c and process.c (bug#1858).
2036
87e86684
LM
20372011-07-09 Lawrence Mitchell <wence@gmx.li>
2038
2039 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2040 (Fgnutls_boot): Use it.
2041
64348f40
AS
20422011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2043
2044 * doc.c (Fsubstitute_command_keys): Revert last change.
2045
1d698799
LMI
20462011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2047
f863868c
LMI
2048 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2049 quotes the next character, and doesn't affect other longer
2050 sequences (bug#8935).
2051
1d698799
LMI
2052 * lread.c (syms_of_lread): Clarify that is isn't only
2053 `eval-buffer' and `eval-defun' that's affected by
2054 `lexical-binding' (bug#8460).
2055
aa4b6df6
EZ
20562011-07-15 Eli Zaretskii <eliz@gnu.org>
2057
2058 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2059 bidi redisplay when a line includes both an image and is
2060 truncated.
2061
5d856da6
PE
20622011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2063
ad6042bb
PE
2064 Fix minor problems found by static checking.
2065 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2066 (elsz): Now a signed constant, not a size_t var. We prefer signed
2067 types to unsigned, to avoid integer comparison confusion. Without
2068 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2069 "cannot optimize loop, the loop counter may overflow", a symptom
2070 of the confusion.
f00bbb22 2071 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2072 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2073
6468f31c
LMI
20742011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2075
49080b10
LMI
2076 * search.c (Fre_search_backward): Mention `case-fold-search' in
2077 all the re_search_* functions (bug#8138).
2078
6468f31c
LMI
2079 * keyboard.c (Fopen_dribble_file): Document when the file is
2080 closed (bug#8056).
2081
c965adc5
EZ
20822011-07-14 Eli Zaretskii <eliz@gnu.org>
2083
df9733bf
EZ
2084 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2085 bidi_cache_idx.
2086
0bb23927
EZ
2087 Support bidi reordering of display and overlay strings.
2088 * xdisp.c (compute_display_string_pos)
2089 (compute_display_string_end): Accept additional argument STRING.
2090 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2091 (reseat_to_string): Initialize bidi_it->string.s and
2092 bidi_it->string.schars.
2093 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2094 NULL (avoids a crash in bidi_paragraph_init).
2095 Initialize itb.string.lstring.
0bb23927
EZ
2096 (init_iterator): Call bidi_init_it only of a valid
2097 buffer position was specified. Initialize paragraph_embedding to
2098 L2R.
2099 (reseat_to_string): Initialize the bidi iterator.
2100 (display_string): If we need to ignore text properties of
2101 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2102 original value of -1 will not work with bidi.)
2103 (compute_display_string_pos): First arg is now struct
2104 `text_pos *'; all callers changed. Support display properties on
2105 Lisp strings.
2106 (compute_display_string_end): Support display properties on Lisp
2107 strings.
2108 (init_iterator, reseat_1, reseat_to_string): Initialize the
2109 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2110 when iterating on a string not from display properties).
640c8776
SM
2111 (compute_display_string_pos, compute_display_string_end):
2112 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2113 arrow keys.
2114 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2115 base_level_stop; instead, set base_level_stop to BEGV.
2116 Fixes crashes in vertical-motion.
0bb23927
EZ
2117 (next_element_from_buffer): Improve commentary for when
2118 the iterator is before prev_stop.
2119 (init_iterator): Initialize bidi_p from the default value of
2120 bidi-display-reordering, not from buffer-local value. Use the
2121 buffer-local value only if initializing for buffer iteration.
2122 (handle_invisible_prop): Support invisible properties on strings
2123 that are being bidi-reordered.
2124 (set_iterator_to_next): Support bidi reordering of C strings and
2125 Lisp strings.
2126 (next_element_from_string): Support bidi reordering of Lisp
2127 strings.
2128 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2129 (display_string): Support display of R2L glyph rows.
2130 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2131 (init_iterator): Don't initialize it->bidi_p for strings
2132 here.
2133 (reseat_to_string): Initialize it->bidi_p for strings here.
2134 (next_element_from_string, next_element_from_c_string)
2135 (next_element_from_buffer): Add xassert's for correspondence
2136 between IT's object being iterated and it->bidi_it.string
2137 structure.
2138 (face_before_or_after_it_pos): Support bidi iteration.
2139 (next_element_from_c_string): Handle the case of the first string
2140 character that is not the first one in the visual order.
2141 (get_visually_first_element): New function, refactored from common
2142 parts of next_element_from_buffer, next_element_from_string, and
2143 next_element_from_c_string.
2144 (tool_bar_lines_needed, redisplay_tool_bar)
2145 (display_menu_bar): Force left-to-right direction. Add a FIXME
2146 comment for making that be controlled by a user option.
2147 (push_it, pop_it): Save and restore the state of the
2148 bidi iterator. Save and restore the bidi_p flag.
2149 (pop_it): Iterate out of display property for string iteration as
2150 well.
2151 (iterate_out_of_display_property): Support iteration over strings.
2152 (handle_single_display_spec): Set up it->bidi_it for iteration
2153 over a display string, and call bidi_init_it.
2154 (handle_single_display_spec, next_overlay_string)
2155 (get_overlay_strings_1, push_display_prop): Set up the bidi
2156 iterator for displaying display or overlay strings.
2157 (forward_to_next_line_start): Don't use the shortcut if
2158 bidi-iterating.
2159 (back_to_previous_visible_line_start): If handle_display_prop
2160 pushed the iterator stack, restore the internal state of the bidi
2161 iterator by calling bidi_pop_it same number of times.
2162 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2163 and we are bidi-iterating, don't decrement the iterator position;
2164 instead, set the first_elt flag in the bidi iterator, to produce
2165 the same effect.
2166 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2167 (push_display_prop): xassert that we are iterating a buffer.
2168 (push_it, pop_it): Save and restore paragraph_embedding member.
2169 (handle_single_display_spec, next_overlay_string)
2170 (get_overlay_strings_1, reseat_1, reseat_to_string)
2171 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2172 correctly. Don't assume unibyte strings are not bidi-reordered.
2173 (compute_display_string_pos)
2174 (compute_display_string_end): Fix handling the case of C string.
2175 (push_it, pop_it): Save and restore from_disp_prop_p.
2176 (handle_single_display_spec, push_display_prop): Set the
2177 from_disp_prop_p flag.
2178 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2179 (pop_it): Call iterate_out_of_display_property only if we are
2180 popping after iteration over a string that came from a display
2181 property. Fix a typo in popping stretch info. Add an assertion
2182 for verifying that the iterator position is in sync with the bidi
2183 iterator.
2184 (handle_single_display_spec, get_overlay_strings_1)
2185 (push_display_prop): Fix initialization of paragraph direction for
2186 string when that of the parent object is not yet determined.
2187 (reseat_1): Call bidi_init_it to resync the bidi
2188 iterator with IT's position. (Bug#7616)
2189 (find_row_edges): If ROW->start.pos gives position
2190 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2191 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2192 Reset the from_disp_prop_p flag.
2193 (SAVE_IT, RESTORE_IT): New macros.
2194 (pos_visible_p, face_before_or_after_it_pos)
2195 (back_to_previous_visible_line_start)
2196 (move_it_in_display_line_to, move_it_in_display_line)
2197 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2198 (try_scrolling, redisplay_window, display_line): Use them when
2199 saving a temporary copy of the iterator and restoring it back.
2200 (back_to_previous_visible_line_start, reseat_1)
2201 (init_iterator): Empty the bidi cache "stack".
2202 (move_it_in_display_line_to): If iterator ended up at
2203 EOL, but we never saw any buffer positions smaller than
2204 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2205 motion in bidi-reordered lines.
2206 (move_it_in_display_line_to): Record prev_method and prev_pos
2207 immediately before the call to set_iterator_to_next. Fixes cursor
2208 motion in bidi-reordered lines with stretch glyphs and strings
2209 displayed in margins. (Bug#8133) (Bug#8867)
2210 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2211 TO_CHARPOS.
640c8776
SM
2212 (pos_visible_p): Support positions in bidi-reordered lines.
2213 Save and restore bidi cache.
0bb23927
EZ
2214
2215 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2216 (bidi_paragraph_info): Delete unused struct.
2217 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2218 (bidi_cache_start): New variable.
2219 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2220 to zero.
2221 (bidi_cache_fetch_state, bidi_cache_search)
2222 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2223 (bidi_cache_find, bidi_peek_at_next_level)
2224 (bidi_level_of_next_char, bidi_find_other_level_edge)
2225 (bidi_move_to_visually_next): Compare cache index with
2226 bidi_cache_start rather than with zero.
2227 (bidi_fetch_char): Accept new argument STRING; all callers
2228 changed. Support iteration over a string. Support strings with
2229 display properties. Support unibyte strings. Fix the type of
2230 `len' according to what STRING_CHAR_AND_LENGTH expects.
2231 (bidi_paragraph_init, bidi_resolve_explicit_1)
2232 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2233 (bidi_level_of_next_char, bidi_move_to_visually_next):
2234 Support iteration over a string.
0bb23927
EZ
2235 (bidi_set_sor_type, bidi_resolve_explicit_1)
2236 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2237 can now be zero (for strings); special values 0 and -1 were
2238 changed to -1 and -2, respectively.
2239 (bidi_char_at_pos): New function.
2240 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2241 Call it instead of FETCH_MULTIBYTE_CHAR.
2242 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2243 initialized to valid values.
2244 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2245 values.
2246 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2247 the test for valid cached positions. Fix the logic for looking up
2248 the sentinel state in the cache. GCPRO the Lisp string we are
2249 iterating.
2250 (bidi_push_it, bidi_pop_it): New functions.
2251 (bidi_initialize): Initialize the bidi cache start stack pointer.
2252 (bidi_cache_ensure_space): New function, refactored from part of
2253 bidi_cache_iterator_state. Don't assume the required size is just
2254 one BIDI_CACHE_CHUNK away.
2255 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2256 (bidi_count_bytes, bidi_char_at_pos): New functions.
2257 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2258 always valid if bidi_cache_idx is valid.
2259 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2260 is valid if it's going to be used.
2261 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2262 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2263 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2264 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2265 (bidi_find_other_level_edge, bidi_cache_start_stack):
2266 All variables related to cache indices are now EMACS_INT.
c965adc5 2267
0bb23927
EZ
2268 * dispextern.h (struct bidi_string_data): New structure.
2269 (struct bidi_it): New member `string'. Make flag members be 1-bit
2270 fields, and put them last in the struct.
640c8776
SM
2271 (compute_display_string_pos, compute_display_string_end):
2272 Update prototypes.
0bb23927
EZ
2273 (bidi_push_it, bidi_pop_it): Add prototypes.
2274 (struct iterator_stack_entry): New members bidi_p,
2275 paragraph_embedding, and from_disp_prop_p.
2276 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2277 (bidi_shelve_cache, bidi_unshelve_cache):
2278 Declare prototypes.
0bb23927
EZ
2279
2280 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2281 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2282 and vector-like objects.
2283
2284 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2285 cache around display iteration.
2286
2287 * window.c (Fwindow_end, window_scroll_pixel_based)
2288 (displayed_window_lines, Frecenter): Save and restore the bidi
2289 cache around display iteration.
2290
3bbd2265
LMI
22912011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2292
2293 * editfns.c (Fdelete_region): Clarify the use of the named
2294 parameters (bug#6788).
2295
adc47434
MR
22962011-07-14 Martin Rudalics <rudalics@gmx.at>
2297
2298 * indent.c (Fvertical_motion): Set and restore w->pointm when
2299 saving and restoring the window's buffer (Bug#9006).
2300
837c31f8
LMI
23012011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2302
2303 * editfns.c (Fstring_to_char): Clarify just what is returned
2304 (bug#6576). Text by Eli Zaretskii.
2305
ac389d0c
JB
23062011-07-13 Juanma Barranquero <lekktu@gmail.com>
2307
2308 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2309
0be0ce47
EZ
23102011-07-13 Eli Zaretskii <eliz@gnu.org>
2311
2312 * buffer.c (mmap_find): Fix a typo.
2313
cd18e7e3
JB
23142011-07-13 Johan Bockgård <bojohan@gnu.org>
2315
2316 Fix execution of x selection hooks.
2317 * xselect.c (Qx_lost_selection_functions)
2318 (Qx_sent_selection_functions): New vars.
2319 (syms_of_xselect): DEFSYM them.
2320 (x_handle_selection_request): Pass Qx_sent_selection_functions
2321 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2322 (x_handle_selection_clear,x_clear_frame_selections):
2323 Pass Qx_lost_selection_functions rather than
2324 Vx_lost_selection_functions to Frun_hook_with_args.
2325
47ea7f44
PE
23262011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2327
ac389d0c 2328 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2329 The old code sometimes used this field without initializing it.
2330
47ea7f44
PE
2331 * alloc.c (gc_sweep): Don't read past end of array.
2332 In theory, the old code could also have corrupted Emacs internals,
2333 though it'd be very unlikely.
2334
bc985c87
AS
23352011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2336
2337 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2338 argument. (Bug#4026)
bc985c87 2339
0cf34688
LMI
23402011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2341
b3dadd76
LMI
2342 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2343 key" (bug#4257).
2344
0cf34688
LMI
2345 * window.c (Fset_window_start): Doc fix (bug#4199).
2346 (Fset_window_hscroll): Ditto.
2347
270768cd
PE
23482011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2349
077e3dda 2350 Fix minor new problems caught by GCC 4.6.1.
270768cd 2351 * term.c (init_tty): Remove unused local.
490011a6 2352 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2353 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2354 not used otherwise.
270768cd 2355
b1f58454
CY
23562011-07-12 Chong Yidong <cyd@stupidchicken.com>
2357
2358 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2359
22b9578d
LMI
23602011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2361
6e70ab07
LMI
2362 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2363 are the mini-buffer and the echo area (bug#3320).
2364
22b9578d
LMI
2365 * term.c (init_tty): Remove support for supdup, c10 and perq
2366 terminals, which are no longer supported (bug#1482).
2367
8974cc9f
JB
23682011-07-10 Johan Bockgård <bojohan@gnu.org>
2369
2370 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2371
a560d974
JD
23722011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2373
2374 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2375 for non-popups (Bug#3642).
2376
1dae0f0a
AS
23772011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2378
268c2c36 2379 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2380 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2381 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2382 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2383 * data.c (fmod): Likewise.
2384 * dispnew.c (swap_glyphs_in_rows): Likewise.
2385 * emacs.c (memory_warning_signal): Likewise.
2386 * floatfns.c (float_error): Likewise.
2387 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2388 (otf_open, font_otf_capability, generate_otf_features)
2389 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2390 Likewise.
2391 * image.c (pbm_read_file): Likewise.
2392 * indent.c (string_display_width): Likewise.
2393 * intervals.c (check_for_interval, search_for_interval)
2394 (inc_interval_count, count_intervals, root_interval)
2395 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2396 * lread.c (defalias): Likewise.
268c2c36 2397 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2398 * regex.c (set_image_of_range_1, set_image_of_range)
2399 (regex_grow_registers): Likewise.
2400 * sysdep.c (strerror): Likewise.
2401 * termcap.c (valid_filename_p, tprint, main): Likewise.
2402 * tparam.c (main): Likewise.
2403 * unexhp9k800.c (run_time_remap, save_data_space)
2404 (update_file_ptrs, read_header, write_header, calculate_checksum)
2405 (copy_file, copy_rest, display_header): Likewise.
2406 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2407 Likewise.
2408 * xdisp.c (check_it): Likewise.
2409 * xfaces.c (register_color, unregister_color, unregister_colors):
2410 Likewise.
2411 * xfns.c (print_fontset_result): Likewise.
2412 * xrdb.c (member, fatal, main): Likewise.
2413
99033785
PE
24142011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2415
2416 Fix minor problems found by static checking (Bug#9031).
2417 * chartab.c (char_table_set_range, map_sub_char_table):
2418 Remove unused locals.
2419 (uniprop_table): Now static.
2420 * composite.c (_work_char): Remove unused static var.
2421
9cb2ac56
JB
24222011-07-09 Juanma Barranquero <lekktu@gmail.com>
2423
2424 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2425
f25661f0
JD
24262011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2427
2428 * gtkutil.c (qttip_cb): Remove code without function.
2429
8278c4fe
EZ
24302011-07-09 Eli Zaretskii <eliz@gnu.org>
2431
2432 * w32.c (pthread_sigmask): New stub.
2433
1692ae2d 24342011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2435
8a6ebd58 2436 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2437 sigprocmask is portable only for single-threaded applications, and
2438 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2439 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2440 (LIBES): Use it.
2441 * callproc.c (Fcall_process):
2442 * process.c (create_process):
2443 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2444 Use pthread_sigmask, not sigprocmask.
123403e4 2445
1b854618
JD
24462011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2447
2448 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2449 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2450 wrong (Bug#8591).
2451
3fe4b549
JD
24522011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2453
0ce7e563
JD
2454 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2455 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2456 (xg_hide_tooltip): Fix comment.
2457
3fe4b549
JD
2458 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2459 in registerServicesMenuSendTypes.
2460 (validRequestorForSendType): Don't check ns_return_types.
2461
2462 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2463 ns_return_type.
2464
5df75e47
JR
24652011-07-08 Jason Rumney <jasonr@gnu.org>
2466
2467 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2468 frame struct members of non-existent frames (Bug#6284).
2469
699c10bd
JD
24702011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2471
4393663b
JD
2472 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2473 variable firstTime not needed on OSX >= 10.6.
2474 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2475 >= 10.5. Use setKnobProportion, setDoubleValue.
2476
2477 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2478 (MAC_OS_X_VERSION_10_5): Define if not defined.
2479 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2480 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2481 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2482
2483 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2484 cString and lossyCString on OSX >= 10.4
2485
2486 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2487 sizeToFit on OSX >= 10.2.
2488
2489 * nsimage.m (allocInitFromFile): Don't use deprecated method
2490 bestRepresentationForDevice on OSX >= 10.6.
2491
2492 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2493 to avoid warning.
2494
2495 * emacs.c: Declare unexec_init_emacs_zone.
2496
a63e0781
JD
2497 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2498
699c10bd
JD
2499 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2500
2501 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2502 on svcsMenu (Bug#8842).
2503
2504 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2505 ns_return_types.
2506 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2507
2508 * nsterm.m (QUTF8_STRING): Declare.
2509 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2510 (validRequestorForSendType): Return type is (id).
2511 Change indexOfObjectIdenticalTo to indexOfObject.
2512 Check if we have local selection before returning self (Bug#8842).
2513 (writeSelectionToPasteboard): Put local selection into paste board
2514 if we have a local selection (Bug#8842).
2515 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2516
2517 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2518 (ns_get_local_selection): Declare.
2519
54e10184
LMI
25202011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2521
9888ff71
LMI
2522 * keymap.c (describe_map_tree): Don't insert a double newline at
2523 the end of the buffer (bug#1169) and return whether we inserted
2524 something.
2525
54e10184
LMI
2526 * callint.c (Fcall_interactively): Change "reading args" to
2527 "providing args" to try to clarify what it does (bug#1010).
2528
15fa4783
KH
25292011-07-07 Kenichi Handa <handa@m17n.org>
2530
2531 * composite.c (composition_compute_stop_pos): Ignore a static
2532 composition starting before CHARPOS (Bug#8915).
2533
2534 * xdisp.c (handle_composition_prop): Likewise.
2535
a8815b00
EZ
25362011-07-07 Eli Zaretskii <eliz@gnu.org>
2537
2538 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2539 (Bug#9015)
2540
ef7b981d 25412011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2542
2543 * character.h (unicode_category_t): New enum type.
2544
2545 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2546 (Qchar_code_property_table): New variable.
2547 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2548 (UNIPROP_COMPRESSED_FORM_P): New macros.
2549 (char_table_ascii): Uncompress the compressed values.
2550 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2551 Uncompress the compressed values.
ac389d0c 2552 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2553 (char_table_ref_and_range): Uncompress the compressed values.
2554 (sub_char_table_set): New arg is_uniprop. Callers changed.
2555 Uncompress the compressed values.
2556 (sub_char_table_set_range): Args changed. Callers changed.
2557 (char_table_set_range): Adjuted for the above change.
2558 (map_sub_char_table): Delete args default_val and parent. Add arg
2559 top. Give decoded values to a Lisp function.
640c8776 2560 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2561 values to a Lisp function. Gcpro more variables.
2562 (uniprop_table_uncompress)
2563 (uniprop_decode_value_run_length): New functions.
2564 (uniprop_decoder, uniprop_decoder_count): New variables.
2565 (uniprop_get_decoder, uniprop_encode_value_character)
2566 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2567 New functions.
2568 (uniprop_encoder, uniprop_encoder_count): New variables.
2569 (uniprop_get_encoder, uniprop_table)
2570 (Funicode_property_table_internal, Fget_unicode_property_internal)
2571 (Fput_unicode_property_internal): New functions.
2572 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2573 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2574 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2575 char-code-property-alist.
2576
640c8776 2577 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2578 Vunicode_category_table.
2579
640c8776 2580 * font.c (font_range): Adjust for the change of
c805dec0
KH
2581 Vunicode_category_table.
2582
76b397fb
DN
25832011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2584
2585 * m/iris4d.h: Remove file, move contents ...
2586 * s/irix6-5.h: ... here.
2587
22b4128e
PE
25882011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2589
2590 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2591 * alloc.c (mark_buffer):
2592 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2593 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2594 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2595 This isn't true in general, and it's particularly not true
2596 if Emacs is configured with --with-wide-int.
2597 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2598 New macros, used in the buffer.c change.
2599
869795d6
JD
26002011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2601
2602 * xsettings.c: Use both GConf and GSettings if both are available.
2603 (store_config_changed_event): Add comment.
2604 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2605 (store_tool_bar_style_changed): New functions.
5e617bc2 2606 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2607 (struct xsettings): Move font inside HAVE_XFT.
2608 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2609 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2610 Move inside HAVE_XFT.
640c8776 2611 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2612 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2613 also.
2614 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2615 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2616 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2617 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2618 (parse_settings): Move check for font inside HAVE_XFT.
2619 (read_settings, apply_xft_settings): Add comment.
2620 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2621 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2622 call store_font_name_changed.
2623 (xft_settings_event): Add comment.
2624 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2625 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2626 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2627 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2628 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2629 (xsettings_get_system_font, xsettings_get_system_normal_font):
2630 Add comment.
869795d6 2631
d8ed26bd
PE
26322011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2633
2634 Random fixes. E.g., (random) never returned negative values.
2635 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2636 subseconds part to the entropy, as that's a bit more random.
2637 Prefer signed to unsigned, since the signedness doesn't matter and
2638 in general we prefer signed. When given a limit, use a
2639 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2640 latter isn't right if USE_2_TAGS_FOR_INTS.
2641 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2642 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2643
cabf1cac
SM
26442011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2645
2646 * textprop.c (text_property_stickiness):
2647 Obey Vtext_property_default_nonsticky.
2648 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2649 * w32fns.c (syms_of_w32fns):
2650 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2651
6e9b2be9
PE
26522011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2653
2654 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2655 This is more efficient than Ffile_directory_p and avoids a minor race.
2656
90186c68
LMI
26572011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2658
7c301272
LMI
2659 * buffer.c (Foverlay_put): Say what the return value is
2660 (bug#7835).
2661
c4f2d8d4
LMI
2662 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2663 is a directory before asking whether to use the file name
2664 (bug#7564).
ad637907
LMI
2665 (barf_or_query_if_file_exists): Make the "File is a directory"
2666 error be more correct.
c4f2d8d4 2667
90186c68
LMI
2668 * fns.c (Frequire): Remove the mention of the .gz files, since
2669 that's installation-specific, but keep the mention of
2670 `get-load-suffixes'.
2671
da64016e
PE
26722011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2673
2674 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2675 Report string overflow if the output is too long.
2676
7d47b580
JB
26772011-07-04 Juanma Barranquero <lekktu@gmail.com>
2678
a555cb87
JB
2679 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2680 (syms_of_gnutls): Remove duplicate DEFSYM for
2681 Qgnutls_bootprop_verify_hostname_error, an error for
2682 Qgnutls_bootprop_verify_error (which is no longer used).
2683
7d47b580
JB
2684 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2685 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2686 Also (re)move comments that are misplaced or no longer relevant.
2687
1e49bfab
LMI
26882011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2689
2690 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2691
1485f4c0
CY
26922011-07-03 Chong Yidong <cyd@stupidchicken.com>
2693
2694 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2695 and background color parameters if they have been changed.
2696
a9ab721e
LMI
26972011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2698
2699 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2700
cf7cff57
PE
27012011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2702
2e13213d
PE
2703 * xsettings.c (SYSTEM_FONT): Define only when used.
2704 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2705
cf7cff57
PE
2706 * keymap.c (access_keymap_1): Now static.
2707
7a8e04f7
CY
27082011-07-02 Chong Yidong <cyd@stupidchicken.com>
2709
2710 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2711 leave any prefix arg for the up event (Bug#1586).
2712
61352f62
LMI
27132011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2714
69bb1ef7
LMI
2715 * lread.c (syms_of_lread): Mention single symbols defined by
2716 `defvar' or `defconst' (bug#7154).
2717
61352f62 2718 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2719 (Frequire): Mention get-load-suffixes.
61352f62 2720
28545e04
MR
27212011-07-02 Martin Rudalics <rudalics@gmx.at>
2722
2723 * window.h (window): Remove clone_number slot.
2724 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2725 Remove.
2726 (make_parent_window, make_window, saved_window)
2727 (Fset_window_configuration, save_window_save): Don't deal with
2728 clone numbers.
2729 * buffer.c (Qclone_number): Remove declaration.
2730 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2731
3349e122
SM
27322011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2733
2734 Add multiple inheritance to keymaps.
2735 * keymap.c (Fmake_composed_keymap): New function.
2736 (Fset_keymap_parent): Simplify.
2737 (fix_submap_inheritance): Remove.
2738 (access_keymap_1): New function extracted from access_keymap to handle
2739 embedded parents and handle lists of maps.
2740 (access_keymap): Use it.
2741 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2742 (Fcopy_keymap): Handle embedded parents.
2743 (Fcommand_remapping, define_as_prefix): Simplify.
2744 (Fkey_binding): Simplify.
2745 (syms_of_keymap): Move minibuffer-local-completion-map,
2746 minibuffer-local-filename-completion-map,
2747 minibuffer-local-must-match-map, and
2748 minibuffer-local-filename-must-match-map to Elisp.
2749 (syms_of_keymap): Defsubr make-composed-keymap.
2750 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2751 (parse_menu_item): Trivial simplification.
2752
3279eb87
GM
27532011-07-01 Glenn Morris <rgm@gnu.org>
2754
2755 * Makefile.in (SETTINGS_LIBS): Fix typo.
2756
4550efdf
KI
27572011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2758
2759 * coding.c (Fencode_coding_string): Record the last coding system
2760 used, as the function doc string says (bug#8738).
2761
0949d2b6
JD
27622011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2763
2764 * xsettings.c (store_monospaced_changed): Take new font as arg and
2765 check for change against current_mono_font.
2766 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2767 (emacs_settings_constructor, emacs_settings_get_property)
2768 (emacs_settings_set_property, emacs_settings_class_init)
2769 (emacs_settings_init, gsettings_obj): Remove.
2770 (something_changedCB): New function for HAVE_GSETTINGS.
2771 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2772 with value as argument.
2773 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2774 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2775 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2776 "changed".
2777
2778 * xgselect.c: Add defined (HAVE_GSETTINGS).
2779 (xgselect_initialize): Ditto.
2780
2781 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2782 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2783 xg_select.
2784
bbc6b304
PE
27852011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2786
2787 * eval.c (struct backtrace): Simplify and port the data structure.
2788 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2789 signed bit field, as this assumption is not portable and it makes
2790 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2791 "char debug_on_exit : 1" as this is not portable either; instead,
2792 use the portable "unsigned int debug_on_exit : 1". Remove unused
2793 member evalargs. Remove obsolete comments about cc bombing out.
2794
9851bfc5
JD
27952011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2796
51bb811f 2797 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2798 Let HAVE_GSETTINGS override HAVE_GCONF.
2799 (store_monospaced_changed): New function.
2800 (EMACS_SETTINGS): A new type derived from GObject to handle
2801 GSettings notifications.
2802 (emacs_settings_constructor, emacs_settings_get_property)
2803 (emacs_settings_set_property, emacs_settings_class_init):
2804 New functions.
2805 (gsettings_client, gsettings_obj): New variables.
2806 (GSETTINGS_SCHEMA): New define.
2807 (something_changedCB): Call store_monospaced_changed.
2808 (init_gsettings): New function.
2809 (xsettings_initialize): Call init_gsettings.
2810 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2811 to NULL.
2812
640c8776 2813 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2814 GCONF_CFLAGS/LIBS.
2815
5386012d
MR
28162011-06-29 Martin Rudalics <rudalics@gmx.at>
2817
2818 * window.c (resize_root_window, grow_mini_window)
2819 (shrink_mini_window): Rename Qresize_root_window to
2820 Qwindow_resize_root_window and Qresize_root_window_vertically to
2821 Qwindow_resize_root_window_vertically.
2822
f13e0b08
PE
28232011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2824
2825 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2826
94515237
JB
28272011-06-27 Juanma Barranquero <lekktu@gmail.com>
2828
2829 * makefile.w32-in: Redesign dependencies so they reflect more
2830 clearly which files are directly included by each source file,
2831 and not through other includes.
2832
e43b6e43
MR
28332011-06-27 Martin Rudalics <rudalics@gmx.at>
2834
2835 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2836 (sort_overlays, overlay_strings): When an overlay's clone number
2837 matches the window's clone number process the overlay even if
2838 the overlay's window property doesn't match the current window.
2839
d68443dc
MR
2840 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2841 (Fwindow_hchild): Rename to Fwindow_left_child.
2842 (Fwindow_next): Rename to Fwindow_next_sibling.
2843 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2844 (resize_window_check): Rename to window_resize_check.
2845 (resize_window_apply): Rename to window_resize_apply.
2846 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2847 (Fdelete_other_windows_internal, resize_frame_windows)
2848 (Fsplit_window_internal, Fdelete_window_internal)
2849 (grow_mini_window, shrink_mini_window)
2850 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2851
c7e73be5
JD
28522011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2853
2854 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2855 (emacs_fixed_set_min_size): Remove.
2856 (emacs_fixed_new): Take frame as argument.
2857
2858 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2859 (_EmacsFixedPrivate): Remove minwidth/height.
2860 Add struct frame *f.
2861 (emacs_fixed_init): Initialize priv->f.
2862 (get_parent_class, emacs_fixed_set_min_size): Remove.
2863 (emacs_fixed_new): Set priv->f to argument.
2864 (emacs_fixed_get_preferred_width)
2865 (emacs_fixed_get_preferred_height): Use min_width/height from
2866 frames size_hint to set minimum and natural (Bug#8919).
2867 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2868 and use min_width/height from frames size_hint to set
2869 min_width/height (Bug#8919).
2870
2871 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2872 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2873 Fix indentation.
c7e73be5 2874
cf99dcf8
EZ
28752011-06-26 Eli Zaretskii <eliz@gnu.org>
2876
2877 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2878 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2879 called at ZV.
2880
029529ac
CY
28812011-06-26 Chong Yidong <cyd@stupidchicken.com>
2882
2883 * process.c (wait_reading_process_output): Bypass select if
2884 waiting for a cell while ignoring keyboard input, and input is
2885 pending. Suggested by Jan Djärv (Bug#8869).
2886
7a7ef429
PE
28872011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2888
2889 Use gnulib's dup2 module instead of rolling our own.
2890 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2891
11fdef7d 28922011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2893
2894 * dispnew.c (scrolling_window): Before scrolling, turn off a
2895 mouse-highlight in the window being scrolled.
2896
cd3520a4
JB
28972011-06-24 Juanma Barranquero <lekktu@gmail.com>
2898
2899 Move DEFSYM to lisp.h and use everywhere.
2900
2901 * character.h (DEFSYM): Move declaration...
2902 * lisp.h (DEFSYM): ...here.
2903
2904 * gnutls.c:
2905 * minibuf.c:
2906 * w32menu.c:
2907 * w32proc.c:
2908 * w32select.c: Don't include character.h.
2909
2910 * alloc.c (syms_of_alloc):
2911 * buffer.c (syms_of_buffer):
2912 * bytecode.c (syms_of_bytecode):
2913 * callint.c (syms_of_callint):
2914 * casefiddle.c (syms_of_casefiddle):
2915 * casetab.c (init_casetab_once):
2916 * category.c (init_category_once, syms_of_category):
2917 * ccl.c (syms_of_ccl):
2918 * cmds.c (syms_of_cmds):
2919 * composite.c (syms_of_composite):
2920 * dbusbind.c (syms_of_dbusbind):
2921 * dired.c (syms_of_dired):
2922 * dispnew.c (syms_of_display):
2923 * doc.c (syms_of_doc):
2924 * editfns.c (syms_of_editfns):
2925 * emacs.c (syms_of_emacs):
2926 * eval.c (syms_of_eval):
2927 * fileio.c (syms_of_fileio):
2928 * fns.c (syms_of_fns):
2929 * frame.c (syms_of_frame):
2930 * fringe.c (syms_of_fringe):
2931 * insdel.c (syms_of_insdel):
2932 * keymap.c (syms_of_keymap):
2933 * lread.c (init_obarray, syms_of_lread):
2934 * macros.c (syms_of_macros):
2935 * msdos.c (syms_of_msdos):
2936 * print.c (syms_of_print):
2937 * process.c (syms_of_process):
2938 * search.c (syms_of_search):
2939 * sound.c (syms_of_sound):
2940 * syntax.c (init_syntax_once, syms_of_syntax):
2941 * terminal.c (syms_of_terminal):
2942 * textprop.c (syms_of_textprop):
2943 * undo.c (syms_of_undo):
2944 * w32.c (globals_of_w32):
2945 * window.c (syms_of_window):
2946 * xdisp.c (syms_of_xdisp):
2947 * xfaces.c (syms_of_xfaces):
2948 * xfns.c (syms_of_xfns):
2949 * xmenu.c (syms_of_xmenu):
2950 * xsettings.c (syms_of_xsettings):
2951 * xterm.c (syms_of_xterm): Use DEFSYM.
2952
4228cf16
TZ
29532011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2954
cd3520a4 2955 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2956
7fcccf1e
PE
29572011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2958
7efb4e0e
PE
2959 Integer and buffer overflow fixes (Bug#8873).
2960
ff5844ad
PE
2961 * print.c (printchar, strout): Check for string overflow.
2962 (PRINTPREPARE, printchar, strout):
2963 Don't set size unless allocation succeeds.
2964
90532f02
PE
2965 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2966 for sizes. Check for string overflow more accurately.
2967 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2968
6d84508d
PE
2969 * macros.c: Integer and buffer overflow fixes.
2970 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2971 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2972 Use ptrdiff_t, not int, for sizes.
2973 Don't increment bufsize until after realloc succeeds.
2974 Check for size-calculation overflow.
2975 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2976
437b2cb4
PE
2977 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2978
8b9ac8b4
PE
2979 * lread.c: Integer overflow fixes.
2980 (read_integer): Radix is now EMACS_INT, not int,
2981 to improve quality of diagnostics for out-of-range radices.
2982 Calculate buffer size correctly for out-of-range radices.
2983 (read1): Check for integer overflow in radices, and in
2984 read-circle numbers.
82cb60d3
PE
2985 (read_escape): Avoid int overflow.
2986 (Fload, openp, read_buffer_size, read1)
2987 (substitute_object_recurse, read_vector, read_list, map_obarray):
2988 Use ptrdiff_t, not int, for sizes.
2989 (read1): Use EMACS_INT, not int, for sizes.
20270765 2990 Check for size overflow.
8b9ac8b4 2991
7fcccf1e
PE
2992 * image.c (cache_image): Check for size arithmetic overflow.
2993
bfbbd7e7
PE
2994 * lread.c: Integer overflow issues.
2995 (saved_doc_string_size, saved_doc_string_length)
2996 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2997 Now ptrdiff_t, not int.
2998 (read1): Don't assume doc string length fits in int. Check for
2999 out-of-range doc string lengths.
3000 (read_list): Don't assume file position fits in int.
39019e54 3001 (read_escape): Check for hex character overflow.
bfbbd7e7 3002
4e323265
LL
30032011-06-22 Leo Liu <sdl.web@gmail.com>
3004
3005 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3006 Move to minibuffer.el.
3007
85fece3e
PE
30082011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3009
20b84ce9 3010 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3011 The following patches are for when GLYPH_DEBUG && !XASSERT.
3012 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3013 * dispnew.c (flush_stdout):
3014 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3015 Mark as externally visible.
3016 * dispnew.c (check_window_matrix_pointers): Now static.
3017 * dispnew.c (window_to_frame_vpos):
3018 * xfns.c (unwind_create_frame):
3019 * xterm.c (x_check_font): Remove unused local.
3020 * scroll.c (CHECK_BOUNDS):
3021 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3022 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3023 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3024 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3025 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3026 Now static.
3027 (debug_method_add): Use va_list and vsprintf rather than relying
3028 on undefined behavior with wrong number of arguments.
3029 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3030 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3031 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3032 since we're not interested in debugging glyphs with old libraries.
3033 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3034 GCC 4.6.0's static checking.
3035
0766b489
PE
30362011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3037
31fd4b32
PE
3038 Integer overflow and signedness fixes (Bug#8873).
3039 A few related buffer overrun fixes, too.
3040
b79e8648
PE
3041 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3042
0766b489
PE
3043 * dispextern.h (struct face.stipple):
3044 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3045 (x_bitmap_mask, x_allocate_bitmap_record)
3046 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3047 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3048 (x_create_bitmap_from_xpm_data):
3049 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3050 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3051 (.bitmaps_last):
3052 * xfaces.c (load_pixmap):
3053 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3054 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3055 (.bitmaps_last, struct x_output.icon_bitmap):
3056 Use ptrdiff_t, not int, for bitmap indexes.
3057 (x_allocate_bitmap_record): Check for size overflow.
3058 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3059
b081724f
PE
3060 Use ptrdiff_t, not int, for overlay counts.
3061 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3062 * editfns.c (overlays_around, get_pos_property):
3063 * textprop.c (get_char_property_and_overlay):
3064 * xdisp.c (next_overlay_change, note_mouse_highlight):
3065 * xfaces.c (face_at_buffer_position):
21514da7
PE
3066 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3067 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3068 (Fnext_overlay_change, Fprevious_overlay_change)
3069 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3070 Use ptrdiff_t, not int, for sizes.
21514da7 3071 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3072
3de73e5e
PE
3073 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3074
2606c57b
PE
3075 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3076 (x_session_initialize): Do not assume string length fits in int.
3077
aaafe47a
PE
3078 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3079 This is unlikely, but can occur if DPI is outlandish.
3080
2674ddc8 3081 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3082 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3083
28154962
PE
3084 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3085 * xrdb.c (magic_file_p, search_magic_path):
3086 Omit last arg SUFFIX; it was always 0. All callers changed.
3087 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3088
7de51af5
PE
3089 * xfont.c (xfont_match): Avoid need for strlen.
3090
25ed6cc3
PE
3091 * xfns.c: Don't assume strlen fits in int.
3092 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3093
4eab31dd
PE
3094 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3095 not unsigned long, as we prefer signed integers. All callers changed.
3096 Detect integer overflow in repeat count.
3097 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3098 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3099
171e2a58
PE
3100 * termcap.c: Don't assume sizes fit in int and never overflow.
3101 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3102 (gobble_line): Check for size-calculation overflow.
3103
ad39faca 3104 * minibuf.c (Fread_buffer):
6e5bb2dc 3105 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3106 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3107 Don't assume string length fits in int.
3108
52c61c22 3109 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3110 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3111
b5b8c9e5
PE
3112 * font.c: Don't assume string length fits in int.
3113 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3114 Use ptrdiff_t, not int.
ccd6111c
PE
3115 (font_intern_prop): Don't assume string length fits in int.
3116 Don't assume integer property fits in fixnum.
3117 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3118
882f0d81 3119 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3120 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3121 Reformulate so as not to need the command string.
3122 Invoke gzip -cd rather than gunzip, as it's more portable.
3123 (lock_info_type, lock_file_1, lock_file):
3124 Don't assume pid_t and time_t fit in unsigned long.
3125 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3126 (current_lock_owner): Prefer signed type for sizes.
3127 Use memcpy, not strncpy, where memcpy is what is really wanted.
3128 Don't assume (via atoi) that time_t and pid_t fit in int.
3129 Check for time_t and/or pid_t out of range, e.g., via a network share.
3130 Don't alloca where an auto var works fine.
3131
93f4cf88
PE
3132 * fileio.c: Fix some integer overflow issues.
3133 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3134 Don't assume string length fits in int.
3135 (directory_file_name): Don't assume string length fits in long.
3136 (make_temp_name): Don't assume pid fits in int, or that its print
3137 length is less than 20.
3138
f3e92b69
PE
3139 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3140
1bfdaf10
PE
3141 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3142
35016e9a
PE
3143 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3144
3d1e65a1
PE
3145 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3146 We prefer signed integers, even for size calculations.
3147
0b963a93
PE
3148 * emacs.c: Don't assume string length fits in 'int'.
3149 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3150 (main): Don't invoke strlen when not needed.
3151
573f4b54
PE
3152 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3153 (XD_DEBUG_MESSAGE): Don't waste a byte.
3154
989f33ba
PE
3155 * callproc.c (getenv_internal_1, getenv_internal)
3156 (Fgetenv_internal):
965d34eb
PE
3157 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3158
e4d29b33
PE
3159 * lread.c (invalid_syntax): Omit length argument.
3160 All uses changed. This doesn't fix a bug, but it simplifies the
3161 code away from its former Hollerith-constant appearance, and it's
3162 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3163 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3164
eb49b136
PE
3165 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3166 This didn't break anything, but it didn't help either.
3167 It's confusing to put a bogus integer in a place where the actual
3168 value does not matter.
9f62aeb1 3169 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3170 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3171
15375a22
PE
3172 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3173 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3174 implementation.
b61cc01c
PE
3175 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3176 We prefer signed types, and the value cannot exceed the EMACS_INT
3177 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3178 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3179 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3180 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3181
53b2623d
PE
3182 * indent.c (sane_tab_width): New function.
3183 (current_column, scan_for_column, Findent_to, position_indentation)
3184 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3185 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3186
51cab52b 3187 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3188
f2ed8a70
PE
3189 * lisp.h (lint_assume): New macro.
3190 * composite.c (composition_gstring_put_cache):
3191 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3192
abe80cc6
PE
3193 * editfns.c, insdel.c:
3194 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3195
b02c740e
PE
3196 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3197
ebc96716
PE
3198 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3199
b4e50fa0 3200 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3201 Use much-faster test for byte-length change.
311d5d7c 3202 Don't assume string byte-length fits in 'int'.
a4cf38e4 3203 Check that character arg fits in 'int'.
85461888 3204 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3205
c0c1ee9f
PE
3206 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3207
a498d7f4
PE
3208 * fns.c (concat): Catch string overflow earlier.
3209 Do not rely on integer wraparound.
3210
51cab52b
PE
3211 * dispextern.h (struct it.overlay_strings_charpos)
3212 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3213 * xdisp.c (forward_to_next_line_start)
3214 (back_to_previous_visible_line_start)
3215 (reseat_at_next_visible_line_start, next_element_from_buffer):
3216 Don't arbitrarily truncate the value of 'selective' to int.
3217
76031fad
PE
3218 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3219
5eb55db9
PE
3220 * composite.c: Don't truncate sizes to 'int'.
3221 (composition_gstring_p, composition_reseat_it)
3222 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3223 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3224 not EMACS_UINT, for indexes.
5eb55db9 3225
0703a717
PE
3226 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3227
d6202519
PE
3228 * buffer.c: Include <verify.h>.
3229 (struct sortvec.priority, struct sortstr.priority):
8961a454 3230 Now EMACS_INT, not int.
c20998a7 3231 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3232 (struct sortstr.size, record_overlay_string)
3233 (struct sortstrlist.size, struct sortlist.used):
3234 Don't truncate size to int.
3235 (record_overlay_string): Check for size-calculation overflow.
d6202519 3236 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3237
d5a19415
JM
32382011-06-22 Jim Meyering <meyering@redhat.com>
3239
029529ac 3240 Don't leak an XBM-image-sized buffer
d5a19415
JM
3241 * image.c (xbm_load): Free the image buffer after using it.
3242
a9041e6c
PE
32432011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3244
3245 Port to Sun C.
3246 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3247 that Sun C diagnosed.
3248 * fns.c (secure_hash): Fix pointer signedness issue.
3249 * intervals.c (static_offset_intervals): New function.
3250 (offset_intervals): Use it.
3251
7f3f739f
LL
32522011-06-21 Leo Liu <sdl.web@gmail.com>
3253
3254 * deps.mk (fns.o):
3255 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3256 sha512.h.
3257
3258 * fns.c (secure_hash): Rename from crypto_hash_function and change
3259 the first arg to accept symbols.
5b66d427 3260 (Fsecure_hash): New primitive.
7f3f739f
LL
3261 (syms_of_fns): New symbols.
3262
76147d94
DD
32632011-06-20 Deniz Dogan <deniz@dogan.se>
3264
3265 * process.c (Fset_process_buffer): Clarify return value in
3266 docstring.
3267
7d7d0045
CY
32682011-06-18 Chong Yidong <cyd@stupidchicken.com>
3269
3270 * dispnew.c (add_window_display_history): Use BVAR.
3271
3272 * xdisp.c (debug_method_add): Use BVAR.
3273 (check_window_end, dump_glyph_matrix, dump_glyph)
3274 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3275
3276 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3277 Likewise.
3278
3279 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3280 check till after the cache is created in init_frame_faces.
3281
ff2bc410
SM
32822011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3283
3284 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3285
28177add
PE
32862011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3287
dd3482fe
PE
3288 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3289 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3290 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3291
393d71f3 3292 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3293 * fileio.c (Finsert_file_contents):
3294 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3295 Remove the old (too-loose) buffer overflow checks.
3296 They weren't needed, since make_gap checks for buffer overflow.
3297 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3298 The old code merely checked for Emacs fixnum overflow, and relied
3299 on undefined (wraparound) behavior. The new code avoids undefined
3300 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3301
2e6813b0 3302 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3303 Tune. Don't use wider integers than needed. Don't use alloca.
3304 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3305
599a9e4f
PE
3306 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3307
99561444
PE
3308 * insdel.c, lisp.h (buffer_overflow): New function.
3309 (insert_from_buffer_1, replace_range, replace_range_2):
3310 * insdel.c (make_gap_larger):
3311 * editfns.c (Finsert_char):
3312 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3313
28177add
PE
3314 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3315
e69dafad
PE
33162011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3317
a7af7fde 3318 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3319
b1c46f02
PE
3320 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3321 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3322
e69dafad
PE
3323 * fileio.c: Don't assume EMACS_INT fits in off_t.
3324 (emacs_lseek): New static function.
3325 (Finsert_file_contents, Fwrite_region): Use it.
3326 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3327
566684ea
PE
3328 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3329
e6966cd6
PE
3330 * fns.c: Don't overflow int when computing a list length.
3331 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3332 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3333 truncation on 64-bit hosts. Check for QUIT every
3334 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3335 faster and is responsive enough.
3336 (Flength): Report an error instead of overflowing an integer.
3337 (Fsafe_length): Return a float if the value is not representable
3338 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3339 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3340 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3341
dd0b0efb
PE
3342 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3343 (header_size, word_size): New constants.
3344 (allocate_vectorlike): Don't check size overflow here.
3345 (allocate_vector): Check it here instead, since this is the only
3346 caller of allocate_vectorlike that could cause overflow.
3347 Check that the new vector's length is representable as a fixnum.
3348
86fe5cfe
PE
3349 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3350 The previous code was bogus. For example, next_almost_prime (32)
3351 returned 39, which is undesirable as it is a multiple of 3; and
3352 next_almost_prime (24) returned 25, which is a multiple of 5 so
3353 why was the code bothering to check for multiples of 7?
3354
80e88859
PE
3355 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3356
4a2f0ad6
PE
3357 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3358
f66c7cf8
PE
3359 Variadic C functions now count arguments with ptrdiff_t.
3360 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3361 Back then I didn't know that the Emacs coding style prefers signed int.
3362 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3363 were being counted with int, which may truncate counts on 64-bit
3364 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3365 * lisp.h (struct Lisp_Subr.function.aMANY)
3366 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3367 Arg counts are now ptrdiff_t, not size_t.
3368 All variadic functions and their callers changed accordingly.
3369 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3370 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3371 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3372 * callint.c (Fcall_interactively): Check arg count for overflow,
3373 to avoid potential buffer overrun. Use signed char, not 'int',
3374 for 'varies' array, so that we needn't bother to check its size
3375 calculation for overflow.
3376 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3377 * eval.c (apply_lambda):
3378 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3379 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3380 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3381
a1759b76
PE
3382 * callint.c (Fcall_interactively): Don't use index var as event count.
3383
d96be9fc
PE
3384 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3385 * mem-limits.h (SIZE): Remove; no longer used.
3386
a690a978 3387 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3388
578c21e6
PE
3389 Remove unnecessary casts.
3390 * xterm.c (x_term_init):
3391 * xfns.c (x_set_border_pixel):
3392 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3393 These aren't needed now that we assume ANSI C.
3394
96f53c6c
PE
3395 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3396 It's more likely to cause problems (due to unsigned overflow)
3397 than to cure them.
3398
83c77d31
PE
3399 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3400
ee2079f1
PE
3401 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3402
6da65536
PE
3403 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3404
7147c4a4
PE
3405 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3406
193e32d9
PE
3407 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3408
e5533da6
PE
3409 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3410
9910e595
PE
3411 GLYPH_CODE_FACE returns EMACS_INT, not int.
3412 * dispextern.h (merge_faces):
3413 * xfaces.c (merge_faces):
01103c44
PE
3414 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3415 Don't assume EMACS_INT fits in int.
9910e595 3416
2638320e
PE
3417 * character.h (CHAR_VALID_P): Remove unused parameter.
3418 * fontset.c, lisp.h, xdisp.c: All uses changed.
3419
045eb8d9
PE
3420 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3421
c1f134b5
PE
3422 * fns.c (concat): Minor tuning based on overflow analysis.
3423 This doesn't fix any bugs. Use int to hold character, instead
3424 of constantly refetching from Emacs object. Use XFASTINT, not
3425 XINT, for value known to be a character. Don't bother comparing
3426 a single byte to 0400, as it's always less.
3427
395fcb93 3428 * floatfns.c (Fexpt):
327eeec8
PE
3429 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3430
abbd3d23
PE
3431 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3432 for characters.
3433
684a03ef
PE
3434 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3435
0fed43f3
PE
3436 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3437 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3438 incorrectly succeed when S was a string, because 4294967386 was
3439 truncated before it was used.
3440
8fd02eb7
PE
3441 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3442 Otherwise, an out-of-range integer could cause undefined behavior
3443 on a 64-bit host.
3444
f8c86b69
PE
3445 * composite.c: Use int, not EMACS_INT, for characters.
3446 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3447 EMACS_INT, for values that are known to be in character range.
3448 This doesn't fix any bugs but is the usual style inside Emacs and
3449 may generate better code on 32-bit machines.
3450
34206dd2
PE
3451 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3452 This is for reasons similar to the recent CHAR_STRING fix.
3453 * charset.c (Fencode_char): Check that character arg is actually
3454 a character. Pass an int to ENCODE_CHAR.
3455 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3456 wider than 'int', as a compile-time check to prevent future regressions
3457 in this area.
3458
c5958d4c 3459 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3460
3461 Make sure a 64-bit char is never passed to CHAR_STRING.
3462 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3463 by silently ignoring the top 32 bits, allowing some values
3464 that were far too large to be valid characters.
3465 * character.h: Include <verify.h>.
3466 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3467 arguments are no wider than unsigned, as a compile-time check
3468 to prevent future regressions in this area.
3469 * data.c (Faset):
01103c44 3470 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3471 (Fsubst_char_in_region):
3472 * fns.c (concat):
3473 * xdisp.c (decode_mode_spec_coding):
3474 Adjust to CHAR_STRING's new requirement.
3475 * editfns.c (Finsert_char, Fsubst_char_in_region):
3476 * fns.c (concat): Check that character args are actually
3477 characters. Without this test, these functions did the wrong
3478 thing with wildly out-of-range values on 64-bit hosts.
3479
d37ca623
PE
3480 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3481 These casts should not be needed on 32-bit hosts, either.
3482 * keyboard.c (read_char):
3483 * lread.c (Fload): Remove casts to unsigned.
3484
ea204efb
PE
3485 * lisp.h (UNSIGNED_CMP): New macro.
3486 This fixes comparison bugs on 64-bit hosts.
3487 (ASCII_CHAR_P): Use it.
3488 * casefiddle.c (casify_object):
01103c44 3489 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3490 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3491 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3492 * dispextern.h (FACE_FROM_ID):
3493 * keyboard.c (read_char): Use UNSIGNED_CMP.
3494
41cb286c
PE
3495 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3496 not to EMACS_INT, to avoid GCC warning.
3497
4a1b9832
PE
3498 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3499
55daad71
PE
3500 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3501 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3502 isn't needed on 32-bit machines.
8f95c75c 3503
01103c44
PE
3504 * buffer.c (Fgenerate_new_buffer_name):
3505 Use EMACS_INT for count, not int.
0ceccced 3506 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3507
3508 * data.c (Qcompiled_function): Now static.
3509
c6f072e7
PE
3510 * window.c (window_body_lines): Now static.
3511
20ce5912
PE
3512 * image.c (gif_load): Rename local to avoid shadowing.
3513
9c4c5f81
PE
3514 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3515 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3516 * alloc.c (make_save_value): Integer argument is now of type
3517 ptrdiff_t, not int.
3518 (mark_object): Use ptrdiff_t, not int.
3519 * lisp.h (pD): New macro.
3520 * print.c (print_object): Use it.
3521
c0c5c8ae
PE
3522 * alloc.c: Use EMACS_INT, not int, to count objects.
3523 (total_conses, total_markers, total_symbols, total_vector_size)
3524 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3525 (total_free_floats, total_floats, total_free_intervals)
3526 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3527 Now EMACS_INT, not int. All uses changed.
3528 (Fgarbage_collect): Compute overall total using a double, so that
3529 integer overflow is less likely to be a problem. Check for overflow
3530 when converting back to an integer.
5a25e253
PE
3531 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3532 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3533 These were 'int' variables that could overflow on 64-bit hosts;
3534 they were never used, so remove them instead of repairing them.
211a0b2a 3535 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3536 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3537 Previously, this ceilinged at INT_MAX, but that doesn't work on
3538 64-bit machines.
e46bb31a 3539 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3540
c78baabf 3541 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3542 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3543 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3544 when a (possibly-narrower) signed value would do just as well.
3545 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3546
c9d624c6
PE
3547 * alloc.c: Catch some string size overflows that we were missing.
3548 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3549 for convenience in STRING_BYTES_MAX.
3550 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3551 The definition here is exact; the one in lisp.h was approximate.
3552 (allocate_string_data): Check for string overflow. This catches
3553 some instances we weren't catching before. Also, it catches
3554 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3555 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3556 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3557
c9d624c6
PE
3558 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3559 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3560 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3561
353032ce
PE
3562 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3563
2bccce07
PE
3564 * alloc.c (Fmake_string): Check for out-of-range init.
3565
0ac30604
SM
35662011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3567
3568 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3569
c195f2de
JD
35702011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3571
3572 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3573 xg_get_default_scrollbar_width.
3574
3575 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3576 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3577 (style_changed_cb): Call update_theme_scrollbar_width and call
3578 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3579 all frames (Bug#8505).
3580 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3581 Call gtk_window_set_resizable if HAVE_GTK3.
3582 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3583 and height if HAVE_GTK3 (Bug#8505).
3584 (scroll_bar_width_for_theme): New variable.
3585 (update_theme_scrollbar_width): New function.
3586 (xg_get_default_scrollbar_width): Move code to
3587 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3588 (xg_initialize): Call update_theme_scrollbar_width.
3589
3590 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3591
3592 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3593
e10ac9f1
MR
35942011-06-12 Martin Rudalics <rudalics@gmx.at>
3595
3596 * frame.c (make_frame): Call other_buffer_safely instead of
3597 other_buffer.
3598
3599 * window.c (temp_output_buffer_show): Call display_buffer with
3600 second argument Vtemp_buffer_show_specifiers and reset latter
3601 immediately after the call.
3602 (Vtemp_buffer_show_specifiers): New variable.
3603 (auto_window_vscroll_p, next_screen_context_lines)
3604 (Vscroll_preserve_screen_position): Remove leading asterisks from
3605 doc-strings.
3606
2d3c217e 36072011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3608
7b7f97e8 3609 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3610 * buffer.c (Qclone_number): Remove for now, as it's unused.
3611 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3612 (record_buffer): Remove unused local.
3613 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3614 (set_frame_buffer_list): Remove; unused.
3615 * frame.h (other_visible_frames): Remove decl.
3616 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3617 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3618 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3619 if HAVE_GPM.
3620 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3621 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3622 Define only if HAVE_GPM.
3623 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3624 (update_hints_inhibit): Remove; never set. All uses removed.
3625 * widgetprv.h (emacsFrameClassRec): Remove decl.
3626 * window.c (delete_deletable_window): Now returns void, since it
3627 wasn't returning anything.
3628 (compare_window_configurations): Remove unused locals.
3629 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3630 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3631 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3632 the same widths as pointers. This follows up on the 2011-05-06 patch.
3633 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3634 * xterm.h: Likewise.
3635 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3636
1384b89e
JB
36372011-06-12 Juanma Barranquero <lekktu@gmail.com>
3638
3639 * makefile.w32-in: Update dependencies.
3640 (LISP_H): Add lib/intprops.h.
3641
1100a63c
CY
36422011-06-11 Chong Yidong <cyd@stupidchicken.com>
3643
3644 * image.c (gif_load): Add animation frame delay to the metadata.
3645 (syms_of_image): Use DEFSYM. New symbol `delay'.
3646
6198ccd0
MR
36472011-06-11 Martin Rudalics <rudalics@gmx.at>
3648
3649 * window.c (delete_deletable_window): Re-add.
3650 (Fset_window_configuration): Rewrite to handle dead buffers and
3651 consequently deletable windows.
3652 (window_tree, Fwindow_tree): Remove. Supply functionality in
3653 window.el.
3654 (compare_window_configurations): Simplify code.
3655
b6e3633c
AS
36562011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3657
1ab0dee5
AS
3658 * image.c (imagemagick_load_image): Fix type mismatch.
3659 (Fimagemagick_types): Likewise.
3660
b6e3633c
AS
3661 * window.h (replace_buffer_in_windows): Declare.
3662
9397e56f
MR
36632011-06-11 Martin Rudalics <rudalics@gmx.at>
3664
3665 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3666 Qclone_number. Remove external declaration of Qdelete_window.
3667 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3668 code.
640c8776
SM
3669 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3670 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3671 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3672 buffer list implementation.
3673 (other_buffer_safely): New function.
3674 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3675 calls to replace_buffer_in_windows and
3676 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3677 if allowed.
3678 (record_buffer): Inhibit quitting and rewrite using quittable
3679 functions. Run Qbuffer_list_update_hook if allowed.
3680 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3681 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3682 Move switch-to-buffer to window.el.
9397e56f
MR
3683 (bury-buffer): Move to window.el.
3684 (Vbuffer_list_update_hook): New variable.
3685
3686 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3687 section.
3688
3689 * window.h (resize_frame_windows): Move up in code.
3690 (Fwindow_frame): Remove EXFUN.
3691 (replace_buffer_in_all_windows): Remove prototype.
3692 (replace_buffer_in_windows_safely): Add prototype.
3693
3694 * window.c: Declare Qdelete_window static again. Move down
3695 declaration of select_count.
3696 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3697 (Fother_window): Move to window.el.
3698 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3699 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3700 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3701 window.el.
3702 (replace_buffer_in_windows): Implement by calling
3703 Qreplace_buffer_in_windows.
3704 (replace_buffer_in_all_windows): Remove with some functionality
3705 moved into replace_buffer_in_windows_safely.
3706 (replace_buffer_in_windows_safely): New function.
3707 (select_window_norecord, select_frame_norecord): Move in front
3708 of run_window_configuration_change_hook. Remove now obsolete
3709 declarations.
640c8776
SM
3710 (Fset_window_buffer): Rewrite doc-string.
3711 Call Qrecord_window_buffer.
9397e56f
MR
3712 (keys_of_window): Move binding for other-window to window.el.
3713
b50691aa
CY
37142011-06-11 Chong Yidong <cyd@stupidchicken.com>
3715
3716 * dispextern.h (struct image): Replace data member, whose int_val
3717 and ptr_val fields were not used by anything, with a single
3718 lisp_val object.
3719
3720 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3721 (gif_clear_image, gif_load, imagemagick_load_image)
3722 (gs_clear_image, gs_load): Callers changed.
3723
3f754b86
PE
37242011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3725
cca69397
PE
3726 * buffer.h: Include <time.h>, for time_t.
3727 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3728
109e28d0
PE
3729 Fix minor problems found by static checking.
3730
60737f02
PE
3731 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3732
4b66faf3
PE
3733 Make identifiers static if they are not used in other modules.
3734 * data.c (Qcompiled_function, Qframe, Qvector):
3735 * image.c (QimageMagick, Qsvg):
3736 * minibuf.c (Qmetadata):
3737 * window.c (resize_window_check, resize_root_window): Now static.
3738 * window.h (resize_window_check, resize_root_window): Remove decls.
3739
109e28d0
PE
3740 * window.c (window_deletion_count, delete_deletable_window):
3741 Remove; unused.
46a4ce9e
PE
3742 (window_body_lines): Now static.
3743 (Fdelete_other_windows_internal): Mark vars as initialized.
3744 Make sure 'resize_failed' is initialized.
3745 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3746 (resize_window_apply): Remove unused local.
3747 * window.h (delete_deletable_window): Remove decl.
3748
109e28d0 3749 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3750 (imagemagick_load_image): Fix pointer signedness problem by changing
3751 last arg from unsigned char * to char *. All uses changed.
3752 Also, fix a local for similar reasons.
3753 Remove unused locals. Remove locals to avoid shadowing.
3754 (fn_rsvg_handle_free): Remove; unused.
3755 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3756 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3757
3f754b86
PE
3758 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3759
2547adb1
CY
37602011-06-10 Chong Yidong <cyd@stupidchicken.com>
3761
3762 * image.c (gif_load): Fix omitted cast error introduced by
3763 2011-06-06 change.
3764
2c8e37d4
MR
37652011-06-10 Martin Rudalics <rudalics@gmx.at>
3766
3767 * window.h (resize_proportionally, orig_total_lines)
3768 (orig_top_line): Remove from window structure.
3769 (set_window_height, set_window_width, change_window_heights)
3770 (Fdelete_window): Remove prototypes.
3771 (resize_frame_windows): Remove duplicate declaration.
3772
440a42e3
EZ
37732011-06-10 Eli Zaretskii <eliz@gnu.org>
3774
3775 * window.h (resize_frame_windows, resize_window_check)
3776 (delete_deletable_window, resize_root_window)
3777 (resize_frame_windows): Declare prototypes.
3778
3779 * window.c (resize_window_apply): Make definition be "static" to
3780 match the prototype.
3781
562dd5e9
MR
37822011-06-10 Martin Rudalics <rudalics@gmx.at>
3783
3784 * window.c: Remove declarations of Qwindow_size_fixed,
3785 window_min_size_1, window_min_size_2, window_min_size,
3786 size_window, window_fixed_size_p, enlarge_window, delete_window.
3787 Remove static from declaration of Qdelete_window, it's
3788 temporarily needed by Fbury_buffer.
3789 (replace_window): Don't assign orig_top_line and
3790 orig_total_lines.
3791 (Fdelete_window, delete_window): Remove. Window deletion is
3792 handled by window.el.
640c8776
SM
3793 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3794 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3795 (Fdelete_other_windows): Remove. Deleting other windows is
3796 handled by window.el.
3797 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3798 handled in window.el.
3799 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3800 Window minimum sizes are handled in window.el.
3801 (shrink_windows, size_window, set_window_height)
3802 (set_window_width, change_window_heights, window_height)
3803 (window_width, CURBEG, CURSIZE, enlarge_window)
3804 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3805 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3806 handled in window.el.
3807 (make_dummy_parent): Rename to make_parent_window and give it a
3808 second argument horflag.
3809 (make_window): Don't set resize_proportionally any more.
3810 (Fsplit_window): Remove. Windows are split in window.el.
3811 (save_restore_action, save_restore_orig_size)
3812 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3813 Resize mini windows in window.el.
3814 (grow_mini_window, shrink_mini_window): Implement by calling
3815 Qresize_root_window_vertically, resize_window_check and
3816 resize_window_apply.
640c8776
SM
3817 (saved_window, Fset_window_configuration, save_window_save):
3818 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3819 resize_proportionally.
3820 (window_min_height, window_min_width): Move to window.el.
3821 (keys_of_window): Move bindings for delete-other-windows,
3822 split-window, delete-window and enlarge-window to window.el.
3823
3824 * buffer.c: Temporarily extern Qdelete_window.
3825 (Fbury_buffer): Temporarily call Qdelete_window instead of
3826 Fdelete_window (Fbury_buffer will move to window.el soon).
3827
3828 * frame.c (set_menu_bar_lines_1): Remove code handling
3829 orig_top_line and orig_total_lines.
3830
3831 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3832 set_window_height but set heights directly.
3833 (change_frame_size_1): Use resize_frame_windows.
3834
3835 * xdisp.c (init_xdisp): Don't use set_window_height but set
3836 heights directly.
3837
640c8776
SM
3838 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3839 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3840 run_window_configuration_change_hook.
3841
3842 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3843 instead of change_window_heights and run
3844 run_window_configuration_change_hook.
3845
1a13852e
MR
38462011-06-09 Martin Rudalics <rudalics@gmx.at>
3847
3848 * window.c (replace_window): Rename second argument REPLACEMENT to
3849 NEW. New third argument SETFLAG. Rewrite.
3850 (delete_window, make_dummy_parent): Call replace_window with
3851 third argument 1.
3852 (window_list_1): Move down in code.
3853 (run_window_configuration_change_hook): Move set_buffer part
3854 before select_frame_norecord part in order to unwind correctly.
3855 Rename count1 to count.
3856 (recombine_windows, delete_deletable_window, resize_root_window)
3857 (Fdelete_other_windows_internal)
3858 (Frun_window_configuration_change_hook, make_parent_window)
3859 (resize_window_check, resize_window_apply, Fresize_window_apply)
3860 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3861 (Fdelete_window_internal, Fresize_mini_window_internal):
3862 New functions.
1a13852e
MR
3863 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3864
f3d1777e
MR
38652011-06-08 Martin Rudalics <rudalics@gmx.at>
3866
496e208e
MR
3867 * window.h (window): Add some new members to window structure -
3868 normal_lines, normal_cols, new_total, new_normal, clone_number,
3869 splits, nest, prev_buffers, next_buffers.
3870 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3871 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3872
f3d1777e
MR
3873 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3874 Remove.
496e208e
MR
3875 (make_dummy_parent): Set new members of windows structure.
3876 (make_window): Move down in code. Handle new members of window
3877 structure.
3878 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3879 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3880 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3881 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3882 (Fset_window_next_buffers, Fset_window_clone_number):
3883 New functions.
496e208e
MR
3884 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3885 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3886 Doc-string fixes.
3887 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3888 Argument WINDOW can be now internal window too.
3889 (Fwindow_use_time): Move up in code.
3890 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3891 Rewrite doc-string.
3892 (Fset_window_configuration, saved_window)
3893 (Fcurrent_window_configuration, save_window_save): Handle new
3894 members of window structure.
b9e809c2
MR
3895 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3896 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3897 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3898 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3899 Qget_mru_window, Qresize_root_window,
3900 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3901 Qauto_buffer_name; staticpro them.
f3d1777e 3902
abde8f8c
MR
39032011-06-07 Martin Rudalics <rudalics@gmx.at>
3904
3905 * window.c (Fwindow_total_size, Fwindow_left_column)
3906 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3907 (Fwindow_list_1): New functions.
3908 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3909 (Fwindow_width, Fscroll_left, Fscroll_right):
3910 Use window_body_cols instead of window_box_text_cols.
3911 (delete_window, Fset_window_configuration):
3912 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3913 (delete_all_subwindows): Take a window as argument and not a
3914 structure. Rewrite.
190b47e6
MR
3915 (window_loop): Remove handling of GET_LRU_WINDOW and
3916 GET_LARGEST_WINDOW.
3917 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3918
3919 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3920 window_box_text_cols. delete_all_subwindows now takes a
3921 Lisp_Object as argument.
abde8f8c 3922
640c8776
SM
3923 * indent.c (compute_motion, Fcompute_motion):
3924 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3925
fa8a67e6
MR
3926 * frame.c (delete_frame): Call delete_all_subwindows with root
3927 window as argument.
3928
a54e3482
DC
39292011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3930
3931 * fns.c (Fputhash): Document return value.
3932
60002bf5
CY
39332011-06-06 Chong Yidong <cyd@stupidchicken.com>
3934
3935 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3936
0c671da6 39372011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3938
b862a52a 3939 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3940
be44ca6c
PE
3941 Check for overflow when converting integer to cons and back.
3942 * charset.c (Fdefine_charset_internal, Fdecode_char):
3943 Use cons_to_unsigned to catch overflow.
3944 (Fencode_char): Use INTEGER_TO_CONS.
3945 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3946 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3947 * data.c (long_to_cons, cons_to_long): Remove.
3948 (cons_to_unsigned, cons_to_signed): New functions.
3949 These signal an error for invalid or out-of-range values.
3950 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3951 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3952 * font.c (Ffont_variation_glyphs):
3953 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3954 * lisp.h: Include <intprops.h>.
3955 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3956 (cons_to_signed, cons_to_unsigned): New decls.
3957 (long_to_cons, cons_to_long): Remove decls.
3958 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3959 (Fprimitive_undo): Use CONS_TO_INTEGER.
3960 * xfns.c (Fx_window_property): Likewise.
3961 * xselect.c: Include <limits.h>.
3962 (x_own_selection, selection_data_to_lisp_data):
3963 Use INTEGER_TO_CONS.
3964 (x_handle_selection_request, x_handle_selection_clear)
3965 (x_get_foreign_selection, Fx_disown_selection_internal)
3966 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3967 (lisp_data_to_selection_data): Use cons_to_unsigned.
3968 (x_fill_property_data): Use cons_to_signed.
3969 Report values out of range.
3970
d1f3d2af
PE
3971 Check for buffer and string overflow more precisely.
3972 * buffer.h (BUF_BYTES_MAX): New macro.
3973 * lisp.h (STRING_BYTES_MAX): New macro.
3974 * alloc.c (Fmake_string):
3975 * character.c (string_escape_byte8):
3976 * coding.c (coding_alloc_by_realloc):
3977 * doprnt.c (doprnt):
3978 * editfns.c (Fformat):
3979 * eval.c (verror):
3980 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3981 since they may not be the same number.
3982 * editfns.c (Finsert_char):
3983 * fileio.c (Finsert_file_contents):
3984 Likewise for BUF_BYTES_MAX.
3985
dd52fcea
PE
3986 * image.c: Use ptrdiff_t, not int, for sizes.
3987 (slurp_file): Switch from int to ptrdiff_t.
3988 All uses changed.
3989 (slurp_file): Check that file size fits in both size_t (for
3990 malloc) and ptrdiff_t (for sanity and safety).
3991
7f9bbdbb
PE
3992 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3993 if b->modtime has its maximal value.
3994
dfe18f82
PE
3995 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3996
84acfcf0
PE
3997 Don't assume time_t can fit into int.
3998 * buffer.h (struct buffer.modtime): Now time_t, not int.
3999 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4000 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4001
ccd9a01a
PE
4002 Minor fixes for signed vs unsigned integers.
4003 * character.h (MAYBE_UNIFY_CHAR):
4004 * charset.c (maybe_unify_char):
4005 * keyboard.c (read_char, reorder_modifiers):
4006 XINT -> XFASTINT, since the integer must be nonnegative.
4007 * ftfont.c (ftfont_spec_pattern):
4008 * keymap.c (access_keymap, silly_event_symbol_error):
4009 XUINT -> XFASTINT, since the integer must be nonnegative.
4010 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4011 since it makes no difference and we prefer signed.
4012 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4013 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4014 nonnegative.
4015
d6d100dd
SM
40162011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4017
4018 * window.h (Fwindow_frame): Declare.
4019
2b6148e4
PE
40202011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4021
4022 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4023 (SPARE_MEMORY): Always define.
4024 (LARGE_REQUEST): Remove.
4025 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4026
f230ecc9
MR
40272011-06-06 Martin Rudalics <rudalics@gmx.at>
4028
727e958e
MR
4029 * lisp.h: Move EXFUNS for Fframe_root_window,
4030 Fframe_first_window and Fset_frame_selected_window to window.h.
4031
4032 * window.h: Move EXFUNS for Fframe_root_window,
4033 Fframe_first_window and Fset_frame_selected_window here from
4034 lisp.h.
4035
4036 * frame.c (Fwindow_frame, Fframe_first_window)
4037 (Fframe_root_window, Fframe_selected_window)
4038 (Fset_frame_selected_window): Move to window.c.
4039 (Factive_minibuffer_window): Move to minibuf.c.
4040 (Fother_visible_frames_p): New function.
4041
4042 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4043
f230ecc9
MR
4044 * window.c (decode_window, decode_any_window): Move up in code.
4045 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4046 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4047 (Fwindow_buffer): Move up and rewrite doc-string.
4048 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4049 (Fwindow_prev): New functions.
727e958e
MR
4050 (Fwindow_frame): Move here from frame.c. Accept any window as
4051 argument.
4052 (Fframe_root_window, Fframe_first_window)
4053 (Fframe_selected_window): Move here from frame.c. Accept frame
4054 or arbitrary window as argument. Update doc-strings.
4055 (Fminibuffer_window): Move up in code.
4056 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4057 (Fset_frame_selected_window): Move here from frame.c.
4058 Marginal rewrite.
727e958e
MR
4059 (Fselected_window, select_window, Fselect_window): Move up in
4060 code. Minor doc-string fixes.
f230ecc9 4061
4d09bcf6
PE
40622011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4063
4064 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4065 Do not assume that spare memory exists; that assumption is valid
4066 only if SYSTEM_MALLOC.
4067 (LARGE_REQUEST): New macro, so that the issue of large requests
4068 is separated from the issue of spare memory.
4069
810928a2
AS
40702011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4071
172418ad
AS
4072 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4073 format. (Bug#8806)
4074
43f862f7
AS
4075 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4076
810928a2
AS
4077 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4078 before statements.
4079
a059fe24
JD
40802011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4081
4082 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4083
4084 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4085
4086 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4087 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4088
989bf368
JB
40892011-06-05 Juanma Barranquero <lekktu@gmail.com>
4090
4091 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4092
4b80f674
CY
40932011-06-04 Chong Yidong <cyd@stupidchicken.com>
4094
4095 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4096 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4097 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4098 New error handlers.
4b80f674
CY
4099 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4100 Obey Vx_select_enable_clipboard_manager. Catch errors in
4101 x_clipboard_manager_save (Bug#8779).
4102 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4103 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4104
99a33b77 41052011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4106
4107 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4108
99a33b77 41092011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4110
4111 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4112 in the current matrix if keep_current_p is non-zero.
4113
8264569d
EZ
41142011-06-04 Eli Zaretskii <eliz@gnu.org>
4115
4116 * bidi.c (bidi_level_of_next_char): Fix last change.
4117
57f97249
EZ
41182011-06-03 Eli Zaretskii <eliz@gnu.org>
4119
fec2107c 4120 Support bidi reordering of text covered by display properties.
57f97249 4121
fec2107c
EZ
4122 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4123 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4124 (bidi_cache_search, bidi_cache_iterator_state)
4125 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4126 (bidi_level_of_next_char, bidi_move_to_visually_next):
4127 Support character positions inside a run of characters covered by a
fec2107c
EZ
4128 display string.
4129 (bidi_paragraph_init, bidi_resolve_explicit_1)
4130 (bidi_level_of_next_char): Call bidi_fetch_char and
4131 bidi_fetch_char_advance instead of FETCH_CHAR and
4132 FETCH_CHAR_ADVANCE.
4133 (bidi_init_it): Initialize new members.
4134 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4135 definitions.
4136 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4137 instead of using explicit *_CHAR codes.
d6d100dd
SM
4138 (bidi_resolve_explicit, bidi_resolve_weak):
4139 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4140 bidirectional text is supported only in multibyte buffers.
4141 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4142 it to initialize the frame_window_p member of struct bidi_it.
4143 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4144 (bidi_resolve_explicit, bidi_resolve_weak)
4145 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4146 bidi_it->nchars is non-positive.
4147 (bidi_level_of_next_char): Don't try to lookup the cache for the
4148 next/previous character if nothing is cached there yet, or if we
4149 were just reseat()'ed to a new position.
c40e2fb2 4150
0e14fe90
EZ
4151 * xdisp.c (set_cursor_from_row): Set start and stop points
4152 according to the row's direction when priming the loop that looks
4153 for the glyph on which to display cursor.
4154 (single_display_spec_intangible_p): Function deleted.
4155 (display_prop_intangible_p): Reimplement to call
4156 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4157 Accept 3 additional arguments needed by handle_display_spec.
4158 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4159 values: lists, `(when COND...)' forms, etc.
4160 (single_display_spec_string_p): Support property values that are
4161 lists with the argument STRING its top-level element.
4162 (display_prop_string_p): Fix the condition for processing a
4163 property that is a list to be consistent with handle_display_spec.
fec2107c 4164 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4165 last portion of handle_display_prop.
4166 (compute_display_string_pos): Accept additional argument
4167 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4168 value of a `display' property is a "replacing spec".
4169 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4170 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4171 the display property, but just return a value indicating whether
4172 the display property will replace the characters it covers.
4173 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4174 frame_window_p members of struct bidi_it.
d6d100dd
SM
4175 (compute_display_string_pos, compute_display_string_end):
4176 New functions.
fec2107c
EZ
4177 (push_it): Accept second argument POSITION, where pop_it should
4178 jump to continue iteration.
4179 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4180
fec2107c
EZ
4181 * keyboard.c (adjust_point_for_property): Adjust the call to
4182 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4183
4184 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4185 (bidi_init_it): Update prototypes.
4186 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4187 (compute_display_string_pos, compute_display_string_end):
4188 Declare prototypes.
fec2107c
EZ
4189 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4190 EMACS_INT.
fc6f18ce 4191
40087514 41922011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4193
57f53182
PE
4194 Malloc failure behavior now depends on size of allocation.
4195 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4196 * lisp.h: Change signatures accordingly.
4197 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4198 All callers changed. (Bug#8762)
4199
4200 * gnutls.c: Use Emacs's memory allocators.
4201 Without this change, the gnutls library would invoke malloc etc.
4202 directly, which causes problems on non-SYNC_INPUT hosts, and which
4203 runs afoul of improving memory_full behavior. (Bug#8761)
4204 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4205 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4206 xfree instead of the default malloc, realloc, free.
4207 (Fgnutls_boot): No need to check for memory allocation failure,
4208 since xmalloc does that for us.
4209
ac32cd99 4210 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4211 * category.c (hash_get_category_set):
4212 * ccl.c (ccl_driver):
4213 * charset.c (Fdefine_charset_internal):
4214 * charset.h (struct charset.hash_index):
4215 * composite.c (get_composition_id, gstring_lookup_cache)
4216 (composition_gstring_put_cache):
4217 * composite.h (struct composition.hash_index):
4218 * dispextern.h (struct image.hash):
4219 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4220 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4221 (hashfn_equal, hashfn_user_defined, make_hash_table)
4222 (maybe_resize_hash_table, hash_lookup, hash_put)
4223 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4224 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4225 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4226 * image.c (make_image, search_image_cache, lookup_image)
4227 (xpm_put_color_table_h):
4228 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4229 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4230 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4231 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4232 * alloc.c (allocate_vectorlike):
4233 Check for overflow in vector size calculations.
4234 * ccl.c (ccl_driver):
4235 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4236 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4237 need to be updated by these changes.
40087514
PE
4238 * fns.c (make_hash_table, maybe_resize_hash_table):
4239 Check for integer overflow with large hash tables.
0de4bb68
PE
4240 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4241 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4242 (SXHASH_REDUCE): New macro.
4243 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4244 Use it instead of discarding useful hash info with large hash values.
4245 (sxhash_float): New function.
4246 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4247 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4248 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4249 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4250 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4251 Adjust signatures to match updated version of code.
4252 (consing_since_gc): Now EMACS_INT, since a single hash table can
4253 use more than INT_MAX bytes.
4254
698d32e2
DN
42552011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4256
4257 Make it possible to build with GCC-4.6+ -O2 -flto.
4258
4259 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4260
fd6fa53f
SM
42612011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4262
4263 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4264 Call minibuffer-inactive-mode.
4265
864db017
JB
42662011-05-31 Juanma Barranquero <lekktu@gmail.com>
4267
4268 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4269 Update dependencies.
4270
2ad0baf4
DN
42712011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4272
4273 * data.c (init_data): Remove code for UTS, this system is not
4274 supported anymore.
4275
4fcc2638
DN
42762011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4277
4278 Don't force ./temacs to start in terminal mode.
4279
4280 * frame.c (make_initial_frame): Initialize faces in all cases, not
4281 only when CANNOT_DUMP is defined.
4282 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4283
c56e0fd5
DN
42842011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4285
4286 * dispnew.c (add_window_display_history): Use const for the string
4287 pointer. Remove declaration, not needed.
4288
333d54da 42892011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4290
55d4c1b2 4291 Use 'inline', not 'INLINE'.
333d54da 4292 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4293 * alloc.c, fontset.c (INLINE): Remove.
4294 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4295 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4296 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4297 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4298 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4299
738db178
DN
43002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4301
4302 Make it possible to run ./temacs.
4303
4304 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4305 syms_of_callproc does the same thing. Remove test for
4306 "initialized", do it in the caller.
4307 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4308
620c53a6
SM
43092011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4310
4311 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4312 (read_minibuf): Use get_minibuffer.
4313 (syms_of_minibuf): Use DEFSYM.
4314 (Qmetadata): New var.
4315 * data.c (Qbuffer): Don't make it static.
4316 (syms_of_data): Use DEFSYM.
4317
e003a292
PE
43182011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4319
4320 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4321 (CCL_CODE_MIN): New macro.
4322
ed008a6d
PE
43232011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4324
3687c2ef
PE
4325 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4326
ed008a6d
PE
4327 * eval.c (Qdebug): Now static.
4328 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4329 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4330 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4331
d66c4c7c
CY
43322011-05-29 Chong Yidong <cyd@stupidchicken.com>
4333
4334 * image.c: Various fixes to ImageMagick code comments.
4335 (Fimagemagick_types): Doc fix.
4336
5fbc2025
PE
43372011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4338
0196f88a
PE
4339 Minor fixes prompted by GCC 4.6.0 warnings.
4340
4341 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4342
5fbc2025
PE
4343 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4344 (x_clipboard_manager_save_all): Move extern decl to ...
4345 * xterm.h: ... here, so that it can be checked for consistency.
4346
1dd3c2d9
CY
43472011-05-29 Chong Yidong <cyd@stupidchicken.com>
4348
4349 * xselect.c (x_clipboard_manager_save_frame)
4350 (x_clipboard_manager_save_all): New functions.
4351 (Fx_clipboard_manager_save): Lisp function deleted.
4352
4353 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4354 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4355
4356 * xterm.h: Update prototype.
4357
5ba6571d
WX
43582011-05-28 William Xu <william.xwl@gmail.com>
4359
4360 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4361 exiting (Bug#8239).
4362
3eaff834
JM
43632011-05-28 Jim Meyering <meyering@redhat.com>
4364
e1900994 4365 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4366 * fns.c (to_uchar): Define.
4367 (crypto_hash_function): Use it to convert some newly-signed
4368 variables to unsigned, to avoid sign-extension bugs. For example,
4369 without this change, (md5 "truc") would evaluate to
4370 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4371 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4372 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4373
0f6990a7
PE
43742011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4375
4376 Integer overflow fixes.
c8a9ca5a 4377
08686060
PE
4378 * dbusbind.c: Serial number integer overflow fixes.
4379 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4380 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4381 to hold a serial number that is too large for a fixnum.
4382 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4383 Check for serial numbers out of range. Decode any serial number
59568bf0 4384 that was so large that it became a float. (Bug#8722)
08686060 4385
2d1fc3c7
PE
4386 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4387 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4388 Use XFASTINT rather than XUINT when numbers are nonnegative.
4389 (xd_append_arg, Fdbus_method_return_internal):
4390 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4391 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4392 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4393 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4394 (Bug#8722)
2d1fc3c7 4395
c8a9ca5a
PE
4396 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4397
519e1d69
PE
4398 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4399
30569699
PE
4400 ccl: add integer overflow checks
4401 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4402 (IN_INT_RANGE): New macros.
4403 (ccl_driver): Use them to check for integer overflow when
4404 decoding a CCL program. Many of the new checks are whether XINT (x)
4405 fits in int; it doesn't always, on 64-bit hosts. The new version
4406 doesn't catch all possible integer overflows, but it's an
847044ea 4407 improvement. (Bug#8719)
30569699 4408
c11285dc
PE
4409 * alloc.c (make_event_array): Use XINT, not XUINT.
4410 There's no need for unsigned here.
4411
fdccd48e
PE
4412 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4413 This follows up to the 2011-05-06 change that substituted uintptr_t
4414 for EMACS_INT. This case wasn't caught back then.
4415
37910ab2
PE
4416 Rework Fformat to avoid integer overflow issues.
4417 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4418 now (part of C89). Include <verify.h>.
4419 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4420 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4421 (Fformat): Avoid the prepass trying to compute sizes; it was only
4422 approximate and thus did not catch overflow reliably. Instead, walk
4423 through the format just once, formatting and computing sizes as we go,
4424 checking for integer overflow at every step, and allocating a larger
4425 buffer as needed. Keep track separately whether the format is
4426 multibyte. Keep only the most-recently calculated precision, rather
4427 than them all. Record whether each argument has been converted to
4428 string. Use EMACS_INT, not int, for byte and char and arg counts.
4429 Support field widths and precisions larger than INT_MAX. Avoid
4430 sprintf's undefined behavior with conversion specifications such as %#d
4431 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4432 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4433 formatting out-of-range floating point numbers with int
9173deec 4434 formats. (Bug#8668)
37910ab2 4435
2e6578fb
PE
4436 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4437
0ae6bdee
PE
4438 * data.c: Avoid integer truncation in expressions involving floats.
4439 * data.c: Include <intprops.h>.
4440 (arith_driver): When there's an integer overflow in an expression
4441 involving floating point, convert the integers to floating point
4442 so that the resulting value does not suffer from catastrophic
4443 integer truncation. For example, on a 64-bit host (* 4
4444 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4445 Do not rely on undefined behavior after integer overflow.
4446
de883a70
PE
4447 merge count_size_as_multibyte, parse_str_to_multibyte
4448 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4449 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4450 Check for integer overflow.
4451 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4452 since it's now a duplicate of the other. This is more of
4453 a character than a buffer op, so better that it's in character.c.
4454 * fns.c, print.c: Adjust to above changes.
4455
2ff916cb
PE
44562011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4457
4458 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4459
f1b54466
PE
44602011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4461
fb1ac845
PE
4462 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4463 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4464 (x_clipboard_manager_save): Now static.
4465 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4466
f1b54466
PE
4467 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4468 (crypto_hash_function): Now static.
4469 Fix pointer signedness problems. Avoid unnecessary initializations.
4470
a9f737ee
CY
44712011-05-27 Chong Yidong <cyd@stupidchicken.com>
4472
4473 * termhooks.h (Vselection_alist): Make it terminal-local.
4474
4475 * terminal.c (create_terminal): Initialize it.
4476
4477 * xselect.c: Support for clipboard managers.
4478 (Vselection_alist): Move to termhooks.h as terminal-local var.
4479 (LOCAL_SELECTION): New macro.
4480 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4481 (symbol_to_x_atom): Remove gratuitous arg.
4482 (x_handle_selection_request, lisp_data_to_selection_data)
4483 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4484 (x_own_selection, x_get_local_selection, x_convert_selection):
4485 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4486 (some_frame_on_display): Delete unused function.
4487 (Fx_own_selection_internal, Fx_get_selection_internal)
4488 (Fx_disown_selection_internal, Fx_selection_owner_p)
4489 (Fx_selection_exists_p): New optional frame arg.
4490 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4491 (x_handle_selection_clear): Don't treat other terminals with the
4492 same keyboard specially. Use the terminal-local Vselection_alist.
4493 (x_clear_frame_selections): Use Frun_hook_with_args.
4494
4495 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4496
4497 * xterm.h: Add support for those atoms.
4498
e067f0c1
CY
44992011-05-26 Chong Yidong <cyd@stupidchicken.com>
4500
4501 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4502 (converted_selections, conversion_fail_tag): New global variables.
4503 (x_selection_request_lisp_error): Free the above.
4504 (x_get_local_selection): Remove unnecessary code.
4505 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4506 of converted selections stored in converted_selections.
4507 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4508 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4509 (x_convert_selection): New function.
4510 (x_handle_selection_event): Simplify.
4511 (x_get_foreign_selection): Don't ignore incoming requests while
4512 waiting for an answer; this will fail when we implement
4513 SAVE_TARGETS, and seems unnecessary anyway.
4514 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4515 (Vx_sent_selection_functions): Doc fix.
4516
0f4aebc0
LL
45172011-05-26 Leo Liu <sdl.web@gmail.com>
4518
4519 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4520
e61124cd
YM
45212011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4522
4523 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4524
4525 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4526 for fringe update if it has periodic bitmap.
ac389d0c 4527 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4528 and fringe_bitmap_periodic_p.
4529
4530 * fringe.c (get_fringe_bitmap_data): New function.
4531 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4532 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4533 row. Mark glyph row for fringe update if periodicity changed.
4534
4535 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4536 for fringe update unless it has periodic bitmap.
4537
f16d9837
KH
45382011-05-25 Kenichi Handa <handa@m17n.org>
4539
4540 * xdisp.c (get_next_display_element): Set correct it->face_id for
4541 a static composition.
4542
e1b90ef6
LL
45432011-05-24 Leo Liu <sdl.web@gmail.com>
4544
4545 * deps.mk (fns.o):
4546 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4547
4548 * fns.c (crypto_hash_function, Fsha1): New function.
4549 (Fmd5): Use crypto_hash_function.
4550 (syms_of_fns): Add Ssha1.
4551
7400048f
PE
45522011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4553
4554 * gnutls.c: Remove unused macros.
4555 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4556 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4557 Remove macros that are defined and never used.
4558 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4559
abb71cf4
CY
45602011-05-22 Chong Yidong <cyd@stupidchicken.com>
4561
4562 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4563 (Fx_get_selection_internal): Minor cleanup.
4564 (Fx_own_selection_internal): Rename arguments for consistency with
4565 select.el.
4566
6307db39
PE
45672011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4568
4569 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4570
f3d4e0a4
CY
45712011-05-22 Chong Yidong <cyd@stupidchicken.com>
4572
4573 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4574
4d8ade89
YM
45752011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4576
4577 * dispnew.c (scrolling_window): Don't exclude the case that the
4578 last enabled row in the desired matrix touches the bottom boundary.
4579
32078c8d
GM
45802011-05-21 Glenn Morris <rgm@gnu.org>
4581
4582 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4583 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4584 and add some more files.
32078c8d 4585
7285dc67
EZ
45862011-05-20 Eli Zaretskii <eliz@gnu.org>
4587
4588 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4589 report_file_error introduced by the change from 2011-05-07.
4590
89d1bd22
PE
45912011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4592
4593 * systime.h (Time): Define only if emacs is defined.
4594 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4595 where the include path doesn't have X11/X.h by default. See
4596 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4597
e23640bb 45982011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4599
4600 * composite.c (find_automatic_composition): Fix previous change.
4601
b9704ad9
GM
46022011-05-20 Glenn Morris <rgm@gnu.org>
4603
4604 * lisp.mk: New file, split from Makefile.in.
4605 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4606 (shortlisp): Remove.
4607 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4608
4a720484
GM
46092011-05-19 Glenn Morris <rgm@gnu.org>
4610
4611 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4612 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4613 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4614 (lisp): Set the order to that of loadup.el.
4615 (shortlisp): Make it a copy of $lisp.
4616 (SOME_MACHINE_LISP): Remove.
4617 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4618 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4619
a28d4396
KH
46202011-05-18 Kenichi Handa <handa@m17n.org>
4621
4622 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4623 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4624 (find_automatic_composition): Mostly rewrite for efficiency.
4625
a2b1fa8e
JB
46262011-05-18 Juanma Barranquero <lekktu@gmail.com>
4627
4628 * makefile.w32-in: Update dependencies.
4629
8e1f5610
CS
46302011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4631
4632 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4633 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4634
7025ee00 46352011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4636
cdfa6eab
PE
4637 Fix some integer overflow issues, such as string length overflow.
4638
06d6db33
PE
4639 * insdel.c (count_size_as_multibyte): Check for string overflow.
4640
2b4560a8
PE
4641 * character.c (lisp_string_width): Check for string overflow.
4642 Use EMACS_INT, not int, for string indexes and lengths; in
4643 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4644 the resulting string length overflows an EMACS_INT; instead,
4645 report a string overflow if no precision given. When checking for
4646 precision exhaustion, use a check that cannot possibly have
4647 integer overflow. (Bug#8675)
4648 * character.h (lisp_string_width): Adjust to new signature.
4649
cb93f9be
PE
4650 * alloc.c (string_overflow): New function.
4651 (Fmake_string): Use it. This doesn't change behavior, but saves
4652 a few bytes and will simplify future changes.
4653 * character.c (string_escape_byte8): Likewise.
4654 * lisp.h (string_overflow): New decl.
4655
1a1f3366
PE
4656 Fixups, following up to the user-interface timestamp change.
4657 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4658 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4659 * msdos.c (mouse_get_pos): Likewise.
4660 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4661 * w32gui.h (Time): Define by including "systime.h" rather than by
4662 declaring it ourselves. (Bug#8664)
4663
d4e3e4d3
PE
4664 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4665 * image.c (clear_image_cache): Likewise.
4666
f6a24d19
PE
4667 * term.c (term_mouse_position): Don't assume time_t wraparound.
4668
08dc5ae6
PE
4669 Be more systematic about user-interface timestamps.
4670 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4671 and sometimes 'EMACS_UINT', to represent these timestamps.
4672 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4673 This makes the code easier to follow, and makes it easier to catch
4674 integer overflow bugs such as Bug#8664.
4675 * frame.c (Fmouse_position, Fmouse_pixel_position):
4676 Use Time, not unsigned long, for user-interface timestamps.
4677 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4678 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4679 * keyboard.h (last_event_timestamp): Likewise.
4680 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4681 * menu.h (xmenu_show): Likewise.
4682 * term.c (term_mouse_position): Likewise.
4683 * termhooks.h (struct input_event.timestamp): Likewise.
4684 (struct terminal.mouse_position_hook): Likewise.
4685 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4686 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4687 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4688 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4689 what it was before.
4690 * menu.h, termhooks.h: Include "systime.h", for Time.
4691
8e55734a
PE
4692 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4693 Don't assume that the difference between two unsigned long values
4694 can fit into an integer. At this point, we know button_down_time
4695 <= event->timestamp, so the difference must be nonnegative, so
4696 there's no need to cast the result if double-click-time is
4697 nonnegative, as it should be; check that it's nonnegative, just in
4698 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4699 apart (about 25 days). (Bug#8664)
8e55734a 4700
841f1b75 4701 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4702 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4703
3e26f69c
PE
4704 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4705 that always fit in int. Use a sentinel instead of a counter, to
4706 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4707 * frame.h (struct frame): Use int for menu_bar_items_used
4708 instead of EMACS_INT, since it always fits in int.
3e26f69c 4709
5cc152c0
PE
4710 * menu.c (grow_menu_items): Check for int overflow.
4711
d89eb65e
PE
4712 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4713
5235bd3e
PE
4714 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4715 Before, the code was not consistent. These values cannot exceed
4716 2**31 - 1 so there's no need to make them unsigned.
4717 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4718 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4719 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4720 as modifiers.
4721 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4722
bc827e23
PE
4723 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4724 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4725 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4726 presumably because the widths might not match.
4727
78eb494e
PE
4728 * window.c (size_window): Avoid needless test at loop start.
4729
04f2d78b
CB
47302011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4731
4732 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4733
d2fc7e3d 47342011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4735
4736 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4737
d2fc7e3d 47382011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4739
4740 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4741 `width' to `bar_area_x' and `bar_area_width', respectively.
4742 (x_scroll_run): Take account of fringe background extension.
4743
04f2d78b
CB
4744 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4745 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4746 `bar_area_width', respectively.
4747 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4748 background extension.
4749
79b70037
GM
47502011-05-10 Jim Meyering <meyering@redhat.com>
4751
4752 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4753
2f142cc5
JB
47542011-05-10 Juanma Barranquero <lekktu@gmail.com>
4755
4756 * image.c (Finit_image_library): Return t for built-in image types,
4757 like pbm and xbm. (Bug#8640)
4758
57679c86
AS
47592011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4760
4761 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4762
888c9e86
EZ
47632011-05-07 Eli Zaretskii <eliz@gnu.org>
4764
b0512a1d
EZ
4765 * w32console.c (Fset_screen_color): Doc fix.
4766 (Fget_screen_color): New function.
4767 (syms_of_ntterm): Defsubr it.
4768
7285dc67
EZ
4769 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4770 unlink the temporary file if Fcall_process didn't create it in the
4771 first place.
4772 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4773 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4774 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4775 cue to call_process_cleanup not to close that handle.
4776
4d3fcc8e
BK
47772011-05-07 Ben Key <bkey76@gmail.com>
4778
4779 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4780 one of two shell specific rules, either bootstrap-temacs-CMD or
4781 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4782 to the previous implementation of the bootstrap-temacs rule.
4783 The bootstrap-temacs-CMD rule is similar to the previous
4784 implementation of the bootstrap-temacs rule except that it
4785 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4786 variable.
4787
4788 These changes, along with some changes to nt/configure.bat,
4789 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4790 earlier fix to add support for --cflags and --ldflags options
4791 that include quotes so that it works whether make uses cmd or
4792 sh as the shell.
4793
b4289b64
MA
47942011-05-06 Michael Albinus <michael.albinus@gmx.de>
4795
4796 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4797 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4798 is a constant.
4799 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4800 a string. Handle both cases.
4801 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4802 (Fdbus_register_method): Use Qinvalid_function.
4803
af4c0e28
JB
48042011-05-06 Juanma Barranquero <lekktu@gmail.com>
4805
4806 * makefile.w32-in: Update dependencies.
4807 (LISP_H): Add inttypes.h and stdin.h.
4808 (PROCESS_H): Add unistd.h.
4809
c51453d9
EZ
48102011-05-06 Eli Zaretskii <eliz@gnu.org>
4811
4812 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4813 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4814
8ff0ac3c 48152011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4816
4c4b566b
PE
4817 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4818
aab2b9b5
PE
4819 * term.c (vfatal): Remove stray call to va_end.
4820 It's not needed and the C Standard doesn't allow it here anyway.
4821
c378da0b
PE
4822 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4823 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4824
288b08c7
PE
4825 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4826 bytes.
4827
e3601888
PE
4828 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4829
db6c0e74
PE
4830 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4831
dd5963ea
PE
4832 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4833
88c9450f
PE
4834 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4835
2f9442b8
PE
4836 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4837
c032b5f8
PE
4838 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4839 * charset.c (Fdefine_charset_internal): Don't initialize
4840 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4841 32-bit int (Bug#8600).
a108c10b
PE
4842
4843 * lread.c (read_integer): Be more consistent with string-to-number.
4844 Use string_to_number to do the actual conversion; this avoids
4845 rounding errors and fixes some other screwups. Without this fix,
4846 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4847 (digit_to_number): Move earlier, for benefit of read_integer.
4848 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4849 not a digit in any supported base. (Bug#8602)
a108c10b 4850
ad5f9eea
PE
4851 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4852
aec1708a
PE
4853 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4854 to match comment at start of function. This also removes a
4855 GCC warning about overflow in a 32+64-bit port.
4856
47be4ab5
PE
4857 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4858
371cac43
PE
4859 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4860 Reported by Stefan Monnier in
4861 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4862 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4863 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4864
d01a7826
PE
4865 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4866 (EMACS_UINTPTR): Likewise, with uintptr_t.
4867
7fd47d5c
PE
4868 * lisp.h: Prefer 64-bit EMACS_INT if available.
4869 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4870 on 32-bit hosts that have 64-bit int, so that they can access
4871 large files.
122b0c86
PE
4872 However, temporarily disable this change unless the temporary
4873 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4874
8727937b
PE
4875 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4876
8ac068ac
PE
4877 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4878 This removes an assumption that EMACS_INT and long are the same
4879 width as pointers. The assumption is true for Emacs porting targets
4880 now, but we want to make other targets possible.
4881 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4882 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4883 In the rest of the code, change types of integers that hold casted
4884 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4885 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4886 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4887 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4888 No need to cast type when ORing.
4889 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4890 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4891 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4892 assume EMACS_INT is the same width as char *.
4893 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4894 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4895 Remove no-longer-needed casts.
4896 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4897 (xg_tool_bar_help_callback, xg_make_tool_item):
4898 Use EMACS_INTPTR to hold an integer
4899 that will be cast to void *; this can avoid a GCC warning
4900 if EMACS_INT is not the same width as void *.
4901 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4902 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4903 (current_message_1, set_message_1):
4904 Use a local to convert to proper width without a cast.
4905 * xmenu.c (dialog_selection_callback): Likewise.
4906
ede49d71
PE
4907 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4908 Also, don't assume VALBITS / RAND_BITS is less than 5,
4909 and don't rely on undefined behavior when shifting a 1 left into
4910 the sign bit.
4911 * lisp.h (get_random): Change signature to match.
4912
2f30ecd0
PE
4913 * lread.c (hash_string): Use size_t, not int, for hash computation.
4914 Normally we prefer signed values; but hashing is special, because
4915 it's better to use unsigned division on hash table sizes so that
4916 the remainder is nonnegative. Also, size_t is the natural width
4917 for hashing into memory. The previous code used 'int', which doesn't
4918 retain enough info to hash well into very large tables.
4919 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4920
2a866e7b
PE
4921 * dbusbind.c: Don't possibly lose pointer info when converting.
4922 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4923 Use XPNTR rather than XHASH, so that the high-order bits of
4924 the pointer aren't lost when converting through void *.
4925
51639eac
PE
4926 * eval.c (Fautoload): Don't double-shift a pointer.
4927
92394119
PE
4928 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4929
dbdb9a7c
JB
49302011-05-06 Juanma Barranquero <lekktu@gmail.com>
4931
4932 * gnutls.c (DEF_GNUTLS_FN):
4933 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4934
db7a0b4f
AS
49352011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4936
4937 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4938 marker. (Bug#8610)
4939
f7ff1b0f 49402011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4941
4942 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4943 New version that can reserve upto 2GB of heap space.
4944
f7ff1b0f 49452011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4946
4947 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4948
639c109b
TZ
49492011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4950
4951 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4952 `gnutls_certificate_set_x509_key_file'.
4953
d2127135
JB
49542011-05-05 Juanma Barranquero <lekktu@gmail.com>
4955
4956 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4957 Update dependencies.
4958
e968f4f3
JB
49592011-05-04 Juanma Barranquero <lekktu@gmail.com>
4960
4961 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4962 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4963 Remove unused parameter `fildes'.
4964 * process.c (read_process_output, send_process): Don't pass it.
4965
84d358f0
JB
49662011-05-04 Juanma Barranquero <lekktu@gmail.com>
4967
4968 Fix previous change: the library cache is defined in w32.c.
4969 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4970 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4971
0898ca10
JB
49722011-05-04 Juanma Barranquero <lekktu@gmail.com>
4973
4974 Implement dynamic loading of GnuTLS on Windows.
4975
4976 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4977 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4978 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4979 Declare.
4980
4981 * gnutls.c (Qgnutls_dll): Define.
4982 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4983 (gnutls_*): Declare function pointers.
4984 (init_gnutls_functions): New function to initialize function pointers.
4985 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4986 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4987 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4988 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4989 (emacs_gnutls_write, emacs_gnutls_read)
4990 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4991 (Fgnutls_available_p): New function.
4992 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4993 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4994 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4995
4996 * image.c: Include w32.h.
4997 (Vimage_type_cache): Delete.
4998 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4999 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5000 (w32_delayed_load): Move to w32.c.
5001
5002 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5003
5004 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5005 (w32_delayed_load): Move from image.c. When loading a library, record
5006 its filename in the :loaded-from property of the library id.
5007 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5008 Initialize and staticpro them.
5009 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5010
5011 * process.c: Include lisp.h before w32.h, not after.
5012 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5013 instead of gnutls_record_check_pending.
5014
5015 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5016
ff4de4aa
TZ
50172011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5018
5019 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5020 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5021 as passed in.
5022
abe95abb
JD
50232011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5024
5025 * xterm.c (x_set_frame_alpha): Do not set property on anything
5026 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5027
e16e55d4
JB
50282011-05-02 Juanma Barranquero <lekktu@gmail.com>
5029
5030 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5031
bafcf6a5
JB
50322011-05-02 Juanma Barranquero <lekktu@gmail.com>
5033
5034 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5035 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5036 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5037 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5038 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5039 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5040 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5041 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5042 (Qgnutls_bootprop_callbacks_verify): Make static.
5043
e7a6747f
AS
50442011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5045
19ed11ba
AS
5046 * callproc.c: Indentation fixup.
5047
e7a6747f 5048 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5049 (wait_for_termination, interruptible_wait_for_termination):
5050 Move after wait_for_termination_1.
e7a6747f 5051
1ef14cb4
LMI
50522011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5053
5054 * sysdep.c (interruptible_wait_for_termination): New function
5055 which is like wait_for_termination, but allows keyboard
5056 interruptions.
5057
5058 * callproc.c (Fcall_process): Add (:file "file") as an option for
5059 the STDOUT buffer.
5060 (Fcall_process_region): Ditto.
5061
330d880c
EZ
50622011-04-30 Eli Zaretskii <eliz@gnu.org>
5063
8db90b73
EZ
5064 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5065 rather than `XVECTOR (FOO)->size'.
5066
330d880c
EZ
5067 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5068 inttypes.h, as a gnulib replacement is used if it not available in
5069 system headers.
5070
15cbd324
EZ
50712011-04-21 Eli Zaretskii <eliz@gnu.org>
5072
5073 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5074 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5075 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5076
5077 * coding.c (coding_alloc_by_realloc): Error out if destination
5078 will grow beyond MOST_POSITIVE_FIXNUM.
5079 (decode_coding_emacs_mule): Abort if there isn't enough place in
5080 charbuf for the composition carryover bytes. Reserve an extra
5081 space for up to 2 characters produced in a loop.
5082 (decode_coding_iso_2022): Abort if there isn't enough place in
5083 charbuf for the composition carryover bytes.
5084
50852011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5086
ae940cca
EZ
5087 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5088 aborting when %lld or %lll format is passed.
5089 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5090 %llo or %llx format is passed. (Bug#8545)
5091
03ab8921
EZ
5092 * window.c (window_scroll_line_based): Use a marker instead of
5093 simple variables to record original value of point. (Bug#7952)
5094
afda1437
EZ
5095 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5096 produced by %s or %c overflows available buffer space. (Bug#8545)
5097
f76dee0c
PE
50982011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5099
5100 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5101 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5102
fdc5744d
JB
51032011-04-28 Juanma Barranquero <lekktu@gmail.com>
5104
5105 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5106
638f053a
JB
51072011-04-28 Juanma Barranquero <lekktu@gmail.com>
5108
5109 * keyboard.c (Qdelayed_warnings_hook): Define.
5110 (command_loop_1): Run `delayed-warnings-hook'
5111 if Vdelayed_warnings_list is non-nil.
5112 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5113 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5114
d178f871
EZ
51152011-04-28 Eli Zaretskii <eliz@gnu.org>
5116
5117 * doprnt.c (doprnt): Don't return value smaller than the buffer
5118 size if the message was truncated. (Bug#8545).
5119
b124fd93
JB
51202011-04-28 Juanma Barranquero <lekktu@gmail.com>
5121
5122 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5123 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5124
e810457d
PE
51252011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5126
5127 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5128
ea51cceb
JB
51292011-04-27 Juanma Barranquero <lekktu@gmail.com>
5130
5131 * makefile.w32-in: Update dependencies.
5132
94dcfacf
EZ
51332011-04-27 Eli Zaretskii <eliz@gnu.org>
5134
5135 Improve `doprnt' and its usage. (Bug#8545)
5136 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5137 `format_end'. Remove support for %l as a conversion specifier.
5138 Don't use xrealloc. Improve diagnostics when the %l size modifier
5139 is used. Update the commentary.
5140
5141 * eval.c (verror): Simplify calculation of size_t.
5142
5143 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5144 messages.
5145
f61f41d7
PE
51462011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5147
5148 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5149 change.
5150
96fb4434
PE
51512011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5152
5153 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5154 This makes this file independent of the recent pseudovector change.
5155
671875da 51562011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5157
69e9b5a3
PE
5158 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5159
b5f869a7 5160 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5161 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5162 Remove unused local.
c8926152 5163 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5164
841a1577 5165 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5166 GCC 4.6.0 optimizes based on type-based alias analysis.
5167 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5168 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5169 != &v->size, and therefore "v->size = 1; b->size = 2; return
5170 v->size;" must therefore return 1. This assumption is incorrect
5171 for Emacs, since it type-puns struct Lisp_Vector * with many other
5172 types. To fix this problem, this patch adds a new type struct
f904488f 5173 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5174 and pseudovectors, and helps optimizing compilers not get fooled
5175 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5176 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5177 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5178 the size member.
eab3844f
PE
5179 (XSETPVECTYPE): Rewrite in terms of new macro.
5180 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5181 This is a bit clearer, and further avoids the possibility of
5182 undesirable aliasing.
5183 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5184 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5185 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5186 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5187 (ASIZE): Now uses header.size rather than size.
5188 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5189 to avoid the hassle of writing XVECTOR (foo)->header.size.
5190 (struct vectorlike_header): New type.
eab3844f
PE
5191 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5192 object, to help avoid aliasing.
5193 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5194 (SUBRP): Likewise, since Lisp_Subr is a special case.
5195 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5196 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5197 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5198 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5199 changed to be "header.size" and "header.next".
5200 * buffer.h (struct buffer): Likewise.
5201 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5202 * frame.h (struct frame): Likewise.
5203 * process.h (struct Lisp_Process): Likewise.
5204 * termhooks.h (struct terminal): Likewise.
5205 * window.c (struct save_window_data, struct saved_window): Likewise.
5206 * window.h (struct window): Likewise.
5207 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5208 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5209 * buffer.c (init_buffer_once): Likewise.
5210 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5211 special case.
5212 * process.c (Fformat_network_address): Use local var for size,
5213 for brevity.
5214
0df1eac5
PE
5215 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5216
847ab9d1 5217 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5218 * data.c (atof): Remove decl; no longer used or needed.
5219 (digit_to_number): Move to lread.c.
5220 (Fstring_to_number): Use new string_to_number function, to be
5221 consistent with how the Lisp reader treats infinities and NaNs.
5222 Do not assume that floating-point numbers represent EMACS_INT
5223 without losing information; this is not true on most 64-bit hosts.
5224 Avoid double-rounding errors, by insisting on integers when
5225 parsing non-base-10 numbers, as the documentation specifies.
5226 * lisp.h (string_to_number): New decl, replacing ...
5227 (isfloat_string): Remove.
bc0a5c13 5228 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5229 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5230 appears to have been a coding error. Similarly, do not accept
5231 strings like +-1e0 as floating point numbers. Do not report
5232 overflow for integer overflows unless the base is not 10 which
5233 means we have no simple and reliable way to continue.
5234 Break out the floating-point parsing into a new
5235 function string_to_number, so that Fstring_to_number parses
5236 floating point numbers consistently with the Lisp reader.
04f2d78b 5237 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5238 (E_CHAR, EXP_INT): Remove, replacing with ...
5239 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5240 (string_to_number): New function, replacing isfloat_string.
5241 This function checks for valid syntax and produces the resulting
5242 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5243 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5244 so that overflow for non-base-10 numbers is reported only when
5245 there's no portable and simple way to convert to floating point.
452f4150 5246
67769ffc
PE
5247 * textprop.c (set_text_properties_1): Rewrite for clarity,
5248 and to avoid GCC warning about integer overflow.
5249
c20db43f
PE
5250 * intervals.h (struct interval): Use EMACS_INT for members
5251 where EMACS_UINT might cause problems. See
5252 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5253 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5254 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5255 All uses changed.
37aa2f85
PE
5256 (offset_intervals): Tell GCC not to worry about length overflow
5257 when negating a negative length.
c20db43f 5258
2538aa2f
PE
5259 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5260 (overrun_check_free): Likewise.
5261
f2d3008d
PE
5262 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5263 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5264 word size.
5265
ec8df744
PE
5266 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5267 (gnutls_make_error): Rename local to avoid shadowing.
5268 (gnutls_emacs_global_deinit): ifdef out; not used.
5269 (Fgnutls_boot): Use const for pointer to readonly storage.
5270 Comment out unused local. Fix pointer signedness problems.
5271
640ee02d
PE
5272 * lread.c (openp): Don't stuff size_t into an 'int'.
5273 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5274 about possible signed overflow.
5275
6048fb2a
PE
5276 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5277 (GDK_KEY_g): Don't define if already defined.
5278 (xg_prepare_tooltip): Avoid pointer signedness problem.
5279 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5280
fa3c87e1
PE
5281 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5282 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5283
2172544b
PE
5284 * xfns.c (Fx_window_property): Simplify a bit,
5285 to make a bit faster and to avoid GCC 4.6.0 warning.
5286 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5287
9b821a21
PE
5288 * fns.c (internal_equal): Don't assume size_t fits in int.
5289
3c616cfa
PE
5290 * alloc.c (compact_small_strings): Tighten assertion a little.
5291
c2982e87
PE
5292 Replace pEd with more-general pI, and fix some printf arg casts.
5293 * lisp.h (pI): New macro, generalizing old pEd macro to other
5294 conversion specifiers. For example, use "...%"pI"d..." rather
5295 than "...%"pEd"...".
5296 (pEd): Remove. All uses replaced with similar uses of pI.
5297 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5298 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5299 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5300 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5301 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5302 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5303 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5304 64-bit hosts.
5305 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5306 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5307 * print.c (safe_debug_print, print_object): Likewise.
5308 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5309 to int.
6f04d126
PE
5310 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5311 avoiding the 0 flag, which is not portable.
c2982e87
PE
5312 * process.c (Fmake_network_process): Use pI to avoid cast.
5313 * region-cache.c (pp_cache): Likewise.
5314 * xdisp.c (decode_mode_spec): Likewise.
5315 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5316 behavior on 64-bit hosts with printf arg.
6f04d126 5317 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5318 (x_stop_queuing_selection_requests): Likewise.
5319 (x_get_window_property): Don't truncate byte count to an 'int'
5320 when tracing.
0b432f21 5321
5e073ec7
PE
5322 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5323 here, since it parses constructs like leading '-' and spaces,
5324 which are not wanted; and it overflows with large numbers.
5325 Instead, simply match F[0-9]+, which is what is wanted anyway.
5326
36372bf9
PE
5327 * alloc.c: Remove unportable assumptions about struct layout.
5328 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5329 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5330 (allocate_vectorlike, make_pure_vector): Use the new macros,
5331 plus offsetof, to remove unportable assumptions about struct layout.
5332 These assumptions hold on all porting targets that I know of, but
5333 they are not guaranteed, they're easy to remove, and removing them
5334 makes further changes easier.
5335
0b432f21
PE
5336 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5337 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5338 (string_overrun_cookie): Now const. Use initializers that
5339 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5340 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5341 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5342 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5343 multiple of sizeof (EMACS_INT); it need not be, if
5344 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5345 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5346
895009e1
JB
53472011-04-26 Juanma Barranquero <lekktu@gmail.com>
5348
5349 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5350
6a7a1b0b
TZ
53512011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5352
5353 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5354 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5355 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5356
841a1577 53572011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5358
5359 * lisp.h (Qdebug): List symbol.
895009e1 5360 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5361 * keyboard.c (debug-on-event): New variable.
5362 (handle_user_signal): Break into debugger when debug-on-event
5363 matches the current signal symbol.
5364
f2d3ba6f
DN
53652011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5366
5367 * alloc.c (check_sblock, check_string_bytes)
5368 (check_string_free_list): Convert to standard C.
5369
42ce4c63
TZ
53702011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5371
5372 * w32.c (emacs_gnutls_push): Fix typo.
5373
825cd63c
EZ
53742011-04-25 Eli Zaretskii <eliz@gnu.org>
5375
fb11d64d
EZ
5376 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5377 "cast to pointer from integer of different size".
5378
825cd63c
EZ
5379 Improve doprnt and its use in verror. (Bug#8545)
5380 * doprnt.c (doprnt): Document the set of format control sequences
5381 supported by the function. Use SAFE_ALLOCA instead of always
5382 using `alloca'.
5383
5384 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5385 is one byte too soon. Don't use xrealloc; instead xfree and
5386 xmalloc anew.
5387
e061a11b
TZ
53882011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5389
5390 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5391 callbacks stage.
5392
5393 * gnutls.c: Renamed global_initialized to
5394 gnutls_global_initialized. Added internals for the
5395 :verify-hostname-error, :verify-error, and :verify-flags
5396 parameters of `gnutls-boot' and documented those parameters in the
5397 docstring. Start callback support.
9173deec
JB
5398 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5399 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5400 on error. Return error code.
e061a11b
TZ
5401 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5402 (emacs_gnutls_read): Likewise.
5403 (Fgnutls_boot): Return handshake error code.
5404 (emacs_gnutls_handle_error): New function.
5405 (wsaerror_to_errno): Likewise.
5406
5407 * w32.h (emacs_gnutls_pull): Add prototype.
5408 (emacs_gnutls_push): Likewise.
5409
5410 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5411 (emacs_gnutls_push): Likewise.
5412
54132011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5414
5415 * process.c (wait_reading_process_output): Check if GnuTLS
5416 buffered some data internally if no FDs are set for TLS
5417 connections.
5418
5419 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5420 (LIBS): Link to USER_LIBS.
5421 ($(BLD)/gnutls.$(0)): New target.
5422
fa6996bc
EZ
54232011-04-24 Eli Zaretskii <eliz@gnu.org>
5424
eb35682e
EZ
5425 * xdisp.c (handle_single_display_spec): Rename the
5426 display_replaced_before_p argument into display_replaced_p, to
5427 make it consistent with the commentary. Fix typos in the
5428 commentary.
5429
e2ad650c
EZ
5430 * textprop.c (syms_of_textprop): Remove dead code.
5431 (copy_text_properties): Delete obsolete commentary about an
5432 interface that was deleted long ago. Fix typos in the description
5433 of arguments.
5434
1b2de274
EZ
5435 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5436 to changes in oldXMenu/XMenu.h from 2011-04-16.
5437 <menu_help_message, prev_menu_help_message>: Constify.
5438 (IT_menu_make_room): menu->help_text is now `const char **';
5439 adjust.
5440
5441 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5442 to changes in oldXMenu/XMenu.h from 2011-04-16.
5443 (struct XMenu): Declare `help_text' `const char **'.
5444
5445 * xfaces.c <Qunspecified>: Make extern again.
5446
5447 * syntax.c: Include sys/types.h before including regex.h, as
5448 required by Posix.
5449
762b15be
EZ
5450 * doc.c (get_doc_string): Improve the format passed to `error'.
5451
5452 * doprnt.c (doprnt): Improve commentary.
5453
5454 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5455
5456 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5457 them with etags.
5458
f1052e5d
EZ
5459 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5460 changes in globals.h immediately force recompilation.
762b15be
EZ
5461 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5462 $(CURDIR)/s/ms-w32.h.
5463 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5464
fa6996bc
EZ
5465 * character.c (Fchar_direction): Function deleted.
5466 (syms_of_character): Don't defsubr it.
5467 <char-direction-table>: Deleted.
5468
e6c3da20
EZ
54692011-04-23 Eli Zaretskii <eliz@gnu.org>
5470
5471 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5472 * doprnt.c: Include limits.h.
5473 (SIZE_MAX): New macro.
04f2d78b
CB
5474 (doprnt): Return a size_t value. 2nd arg is now size_t.
5475 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5476 Improve overflow protection. Support `l' modifier for integer
5477 conversions. Support %l conversion. Don't assume an EMACS_INT
5478 argument for integer conversions and for %c.
5479
5480 * lisp.h (doprnt): Restore prototype.
5481
5482 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5483 $(SRC)/character.h.
5484
5485 * Makefile.in (base_obj): Add back doprnt.o.
5486
5487 * deps.mk (doprnt.o): Add back prerequisites.
5488 (callint.o): Depend on character.h.
5489
5490 * eval.c (internal_lisp_condition_case): Include the handler
5491 representation in the error message.
5492 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5493 when breaking from the loop.
5494
5495 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5496
5497 * callint.c (Fcall_interactively): When displaying error message
5498 about invalid control letter, pass the character's codepoint, not
5499 a pointer to its multibyte form. Improve display of the character
5500 in octal and display also its hex code.
5501
5502 * character.c (char_string): Use %x to display the (unsigned)
5503 codepoint of an invalid character, to avoid displaying a bogus
5504 negative value.
5505
5506 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5507 `error', not SYMBOL_NAME itself.
5508
5509 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5510 character arguments to `error'.
5511
5512 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5513 to `error' in error message about FINAL_CHAR argument. Make sure
5514 FINAL_CHAR is a character, and use %c when it is passed as
5515 argument to `error'.
5516
4ffd0d6b 55172011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5518
5519 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5520
5521 * w32.c: Include <time.h>.
5522 (sys_localtime): New function.
5523
4ffd0d6b 55242011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5525
5526 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5527
4ffd0d6b 5528 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5529
4ffd0d6b 55302011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5531
4ffd0d6b
GM
5532 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5533 zombies (Bug#8467).
aac0c6e3 5534
04c56954
EZ
55352011-04-19 Eli Zaretskii <eliz@gnu.org>
5536
5537 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5538 gl_state.e_property when gl_state.object is Qt.
5539
5540 * insdel.c (make_gap_larger): Remove limitation of buffer size
5541 to <= INT_MAX.
5542
16a43933
CY
55432011-04-18 Chong Yidong <cyd@stupidchicken.com>
5544
5545 * xdisp.c (lookup_glyphless_char_display)
5546 (produce_glyphless_glyph): Handle cons cell entry in
5547 glyphless-char-display.
5548 (Vglyphless_char_display): Document it.
5549
5550 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5551 glyphless-char-display.
5552
4581706e
CY
55532011-04-17 Chong Yidong <cyd@stupidchicken.com>
5554
5555 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5556
5557 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5558
5559 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5560 definition for no-X builds.
5561
4887c6e2 55622011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5563
fd35b6f9
PE
5564 Static checks with GCC 4.6.0 and non-default toolkits.
5565
5c1ccb01
PE
5566 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5567
006c5daa
PE
5568 * process.c (keyboard_bit_set): Define only if SIGIO.
5569 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5570 (send_process): Repair possible setjmp clobbering.
5571
efc736d3
PE
5572 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5573
4e2fe2e6
PE
5574 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5575
f97334a2
PE
5576 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5577
4e75f29d
PE
5578 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5579 Define only if needed.
5580
90efadd1
PE
5581 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5582 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5583 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5584
3c647824
PE
5585 * dispextern.h (struct redisplay_interface): Rename param
5586 to avoid shadowing.
e264f262 5587 * termhooks.h (struct terminal): Likewise.
761383f4 5588 * xterm.c (xembed_send_message): Likewise.
3c647824 5589
b58c5c4a
PE
5590 * insdel.c (make_gap_smaller): Define only if
5591 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5592
cad59032
PE
5593 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5594 it.
5595
c339dc2e
PE
5596 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5597 so that we aren't warned about unused symbols.
5598
91a3e27b
PE
5599 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5600
399c71d3 5601 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5602
8ffc96f5
PE
5603 * xfns.c (x_real_positions): Mark locals as initialized.
5604
eef9bc79
PE
5605 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5606
098db9dd
PE
5607 * xterm.c: Fix problems found by static analysis with other toolkits.
5608 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5609 (x_dispatch_event): Declare static if USE_GTK, and
5610 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5611 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5612 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5613 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5614 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5615
eb18f6cc
PE
5616 * xmenu.c (menu_help_callback): Pointer type fixes.
5617 Use const pointers when pointing at readonly data. Avoid pointer
5618 signedness clashes.
5619 (FALSE): Remove unused macro.
5620 (update_frame_menubar): Remove unused decl.
5621
1fe72bf8
PE
5622 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5623
60d9e1db
PE
5624 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5625 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5626 (single_menu_item): Rename local to avoid shadowing.
5627
39261c26
PE
5628 * keyboard.c (make_lispy_event): Remove unused local var.
5629
018c5e19
PE
5630 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5631 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5632
63d2b86e
PE
5633 * bitmaps: Change bitmaps from unsigned char back to the X11
5634 compatible char. Avoid the old compiler warnings about
5635 out-of-range initializers by using, for example, '\xab' rather
5636 than 0xab.
5637
aefd87e1
PE
5638 * xgselect.c (xgselect_initialize): Check vs interface
5639 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5640
bf501fb9
PE
5641 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5642
e9829fdf
PE
5643 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5644 to read-only memory.
5645
1086c095
PE
5646 * fns.c (vector): Remove; this old hack is no longer needed.
5647
2baccd04 5648 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5649 Remove unused var.
dde42981 5650 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5651
72391843 5652 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5653
436c16df 5654 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5655 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5656 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5657
92bb796d 5658 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5659 (x_term_init): Remove local to avoid shadowing.
92bb796d 5660
764430a3 5661 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5662
5663 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5664 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5665
d1dfb56c
EZ
56662011-04-16 Eli Zaretskii <eliz@gnu.org>
5667
c4354cb4
EZ
5668 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5669
d1dfb56c
EZ
5670 Fix regex.c, syntax.c and friends for buffers > 2GB.
5671 * syntax.h (struct gl_state_s): Declare character position members
5672 EMACS_INT.
5673
5674 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5675
04f2d78b
CB
5676 * textprop.c (verify_interval_modification, interval_of):
5677 Declare arguments EMACS_INT.
d1dfb56c
EZ
5678
5679 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5680 EMACS_INT.
5681
5682 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5683
5684 * indent.c (Fvertical_motion): Local variable it_start is now
5685 EMACS_INT.
5686
5687 * regex.c (re_match, re_match_2, re_match_2_internal)
5688 (bcmp_translate, regcomp, regexec, print_double_string)
5689 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5690 (re_compile_pattern, re_exec): Declare arguments and local
5691 variables `size_t' and `ssize_t' and return values `regoff_t', as
5692 appropriate.
5693 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5694 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5695 <compile_stack_type>: `size' and `avail' are now `size_t'.
5696
5697 * regex.h <regoff_t>: Use ssize_t, not int.
5698 (re_search, re_search_2, re_match, re_match_2): Arguments that
5699 specify buffer/string position and length are now ssize_t and
5700 size_t. Return type is regoff_t.
5701
613052cd
BK
57022011-04-16 Ben Key <bkey76@gmail.com>
5703
5704 * nsfont.m: Fixed bugs in ns_get_family and
5705 ns_descriptor_to_entity that were caused by using free to
5706 deallocate memory blocks that were allocated by xmalloc (via
5707 xstrdup). This caused Emacs to crash when compiled with
5708 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5709 --enable-checking=xmallocoverrun). xfree is now used to
5710 deallocate these memory blocks.
5711
4170f62f 57122011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5713
71b41406
PE
5714 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5715
9587a89d
PE
5716 emacs_write: Accept and return EMACS_INT for sizes.
5717 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5718 et seq.
5719 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5720 Accept and return EMACS_INT.
5721 (emacs_gnutls_write): Return the number of bytes written on
5722 partial writes.
5723 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5724 (emacs_read, emacs_write): Remove check for negative size, as the
5725 Emacs source code has been audited now.
9587a89d
PE
5726 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5727 (emacs_read, emacs_write): Use it.
273a5f82
PE
5728 * process.c (send_process): Adjust to the new signatures of
5729 emacs_write and emacs_gnutls_write. Do not attempt to store
5730 a byte offset into an 'int'; it might overflow.
9587a89d 5731 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5732
3e047f51
PE
5733 * sound.c: Don't assume sizes fit in 'int'.
5734 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5735 Return EMACS_INT, not int.
3e047f51 5736 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5737 Accept EMACS_INT, not int.
5738 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5739 record read return values.
5740
cc39a9db
BK
57412011-04-15 Ben Key <bkey76@gmail.com>
5742
c9d0ec6d
JB
5743 * keyboard.c (Qundefined): Don't declare static since it is used
5744 in nsfns.m.
5745 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5746 static since they are used in nsfont.m.
cc39a9db 5747
6c60eb9f
SM
57482011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5749
5750 * process.c (Qprocessp): Don't declare static.
5751 * lisp.h (Qprocessp): Declare again.
5752
7990b61a
JB
57532011-04-15 Juanma Barranquero <lekktu@gmail.com>
5754
5755 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5756
5d4cb038
PE
57572011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5758
8bd7b830 5759 Improve C-level modularity by making more things 'static'.
cd64ea1d 5760
e3b27b31
PE
5761 Don't publish debugger-only interfaces to other modules.
5762 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5763 (verify_bytepos, count_markers): Move decls to the only modules
5764 that need them.
5765 * region-cache.h (pp_cache): Likewise.
5766 * window.h (check_all_windows): Likewise.
5767 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5768
5d4cb038
PE
5769 * sysdep.c (croak): Now static, if
5770 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5771 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5772
5773 * alloc.c (refill_memory_reserve): Now static if
5774 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5775 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5776
e87b6180
PE
5777 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5778 Define only if USE_LUCID.
5779
ac64929e
PE
5780 * xrdb.c (x_customization_string, x_rm_string): Now static.
5781
6f37259d
PE
5782 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5783 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5784
1683e3ab
PE
5785 * xdisp.c (draw_row_with_mouse_face): Now static.
5786 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5787
de9c2632
PE
5788 * window.h (check_all_windows): Mark externally visible.
5789
2b96acb7
PE
5790 * window.c (window_deletion_count): Now static.
5791
5792 * undo.c: Make symbols static if they're not exported.
5793 (last_undo_buffer, last_boundary_position, pending_boundary):
5794 Now static.
5795
50436f33
PE
5796 * textprop.c (interval_insert_behind_hooks): Now static.
5797 (interval_insert_in_front_hooks): Likewise.
5798
64520e5c
PE
5799 * term.c: Make symbols static if they're not exported.
5800 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5801 (max_frame_lines, tty_set_terminal_modes):
5802 (tty_reset_terminal_modes, tty_turn_off_highlight):
5803 (get_tty_terminal): Now static.
5804 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5805 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5806 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5807 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5808 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5809
1fa53021
PE
5810 * sysdep.c: Make symbols static if they're not exported.
5811 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5812 Now static.
5813 (sigprocmask_set, full_mask): Remove; unused.
5814 (wait_debugging): Mark as visible.
5815 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5816 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5817
d4b43b22
PE
5818 * syntax.c (syntax_temp): Define only if !__GNUC__.
5819
b7c513d0
PE
5820 * sound.c (current_sound_device, current_sound): Now static.
5821
989b29ad
PE
5822 * search.c (searchbufs, searchbuf_head): Now static.
5823
13a55a78
PE
5824 * scroll.c (scroll_cost): Remove; unused.
5825 * dispextern.h (scroll_cost): Remove decl.
5826
de68a1fc
PE
5827 * region-cache.h (pp_cache): Mark as externally visible.
5828
40ccffa6
PE
5829 * process.c: Make symbols static if they're not exported.
5830 (process_tick, update_tick, create_process, chan_process):
5831 (Vprocess_alist, proc_buffered_char, datagram_access):
5832 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5833 (deactivate_process): Mark defn as static, as well as decl.
5834 * lisp.h (create_process): Remove decl.
5835 * process.h (chan_process, Vprocess_alist): Remove decls.
5836
ad64fc97
PE
5837 * print.c: Make symbols static if they're not exported.
5838 (print_depth, new_backquote_output, being_printed, print_buffer):
5839 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5840 (print_interval, print_number_index, initial_stderr_stream):
5841 Now static.
5842 * lisp.h (Fprinc): Remove decl.
5843 (debug_output_compilation_hack): Mark as externally visible.
5844
adddb265
PE
5845 * sysdep.c (croak): Move decl from here to syssignal.h.
5846 * syssignal.h (croak): Put it here, so the API can be checked when
5847 'croak' is called from dissociate_if_controlling_tty.
5848
1717ede2
PE
5849 * minibuf.c: Make symbols static if they're not exported.
5850 (minibuf_save_list, choose_minibuf_frame): Now static.
5851 * lisp.h (choose_minibuf_frame): Remove decl.
5852
fa5fb2bc
PE
5853 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5854
1e3890d1
PE
5855 * lread.c: Make symbols static if they're not exported.
5856 (read_objects, initial_obarray, oblookup_last_bucket_number):
5857 Now static.
5858 (make_symbol): Remove; unused.
5859 * lisp.h (initial_obarray, make_symbol): Remove decls.
5860
8a1414fa
PE
5861 * keyboard.c: Make symbols static if they're not exported.
5862 (single_kboard, recent_keys_index, total_keys, recent_keys):
5863 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5864 (this_single_command_key_start, echoing, last_auto_save):
5865 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5866 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5867 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5868 (Vlispy_mouse_stem, double_click_count):
5869 Now static.
5870 (force_auto_save_soon): Define only if SIGDANGER.
5871 (ignore_mouse_drag_p): Now static if
5872 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5873 (print_help): Remove; unused.
5874 (stop_character, last_timer_event): Mark as externally visible.
5875 * keyboard.h (ignore_mouse_drag_p): Declare only if
5876 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5877 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5878 * lisp.h (echoing): Remove decl.
5879 (force_auto_save_soon): Declare only if SIGDANGER.
5880 * xdisp.c (redisplay_window): Simplify code, to make it more
5881 obvious that ignore_mouse_drag_p is not accessed if !defined
5882 USE_GTK && !defined HAVE_NS.
5883
93ea6e8f
PE
5884 * intervals.c: Make symbols static if they're not exported.
5885 (merge_properties_sticky, merge_interval_right, delete_interval):
5886 Now static.
5887 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5888
77382fcc
PE
5889 * insdel.c: Make symbols static if they're not exported.
5890 However, leave prepare_to_modify_buffer alone. It's never
5891 called from outside this function, but that appears to be a bug.
5892 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5893 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5894 (adjust_after_replace_noundo): Remove; unused.
5895 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5896 (signal_before_change): Remove decls.
77382fcc 5897
9306c32e
PE
5898 * indent.c (val_compute_motion, val_vmotion): Now static.
5899
cd44d2eb
PE
5900 * image.c: Make symbols static if they're not exported.
5901 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5902 if USE_GTK.
5903 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5904 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5905
ad9a7a06
PE
5906 * fringe.c (standard_bitmaps): Now static.
5907 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5908
81626931
PE
5909 * frame.c: Make symbols static if they're not exported.
5910 (x_report_frame_params, make_terminal_frame): Now static.
5911 (get_frame_param): Now static, unless HAVE_NS.
5912 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5913 (x_get_resource_string): Remove; not used.
5914 * frame.h (make_terminal_frame, x_report_frame_params):
5915 (x_get_resource_string); Remove decls.
5916 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5917 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5918
239f9db9
PE
5919 * font.c, fontset.c: Make symbols static if they're not exported.
5920 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5921 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5922 * font.c (font_close_object): Now static.
5923 * font.h (font_close_object): Remove.
5924 * fontset.c (FONTSET_OBJLIST): Remove.
5925 (free_realized_fontset) #if-0 the body, which does nothing.
5926 (face_suitable_for_char_p): #if-0, as it's never called.
5927 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5928 * xfaces.c (face_at_string_position):
5929 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5930 since 0 is always ASCII.
5931
dfcf3579
PE
5932 * fns.c (weak_hash_tables): Now static.
5933
5045092b
PE
5934 * fileio.c: Make symbols static if they're not exported.
5935 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5936 (Vwrite_region_annotation_buffers): Now static.
5937
57a96f5c
PE
5938 * eval.c: Make symbols static if they're not exported.
5939 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5940 * lisp.h (backtrace_list): Remove decl.
5941
35f08c38
PE
5942 * emacs.c: Make symbols static if they're not exported.
5943 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5944 (fatal_error_code, fatal_error_signal_hook, standard_args):
5945 Now static.
5946 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5947 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5948 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5949 * lisp.h (fatal_error_signal_hook): Remove decl.
5950 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5951
f44bd759
PE
5952 * editfns.c: Move a (normally-unused) function to its only use.
5953 * editfns.c, lisp.h (get_operating_system_release): Remove.
5954 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5955 worth the hassle of breaking this out.
5956
b532497d
PE
5957 * xterm.c: Make symbols static if they're not exported.
5958 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5959 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5960 (x_destroy_window, x_delete_display):
5961 Now static.
5962 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5963 (x_mouse_leave): Remove; unused.
5964 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5965 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5966 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5967 Remove decls.
5968 (x_mouse_leave): Declare only if WINDOWSNT.
5969 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5970 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5971 USE_X_TOOLKIT.
5972
1675728f
PE
5973 * ftxfont.c: Make symbols static if they're not exported.
5974 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5975 HAVE_FREETYPE.
5976 * font.h (ftxfont_driver): Likewise.
5977
e4cebfca
PE
5978 * xfns.c: Make symbols static if they're not exported.
5979 (x_last_font_name, x_display_info_for_name):
5980 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5981 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5982 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5983 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5984 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5985 (last_show_tip_args): Now static.
5986 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5987 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5988 (x_screen_planes): Remove; unused.
5989 * dispextern.h (x_screen_planes): Remove decl.
5990
5bf46f05
PE
5991 * dispnew.c: Make symbols static if they're not exported.
5992 * dispextern.h (redraw_garbaged_frames, scrolling):
5993 (increment_row_positions): Remove.
5994 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5995 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5996 Now static.
5997 (redraw_garbaged_frames): Remove; unused.
5998
435f4c28
PE
5999 * xfaces.c: Make symbols static if they're not exported.
6000 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6001 Remove decls.
6002 * xterm.h (defined_color): Remove decls.
6003 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6004 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6005 (menu_face_changed_default, defined_color, free_realized_face):
6006 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6007 (ascii_face_of_lisp_face): Remove; unused.
6008
8524aef3
PE
6009 * xdisp.c: Make symbols static if they're not exported.
6010 * dispextern.h (scratch_glyph_row, window_box_edges):
6011 (glyph_to_pixel_coords, set_cursor_from_row):
6012 (get_next_display_element, set_iterator_to_next):
6013 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6014 (show_mouse_face): Remove decls
6015 * frame.h (message_buf_print): Likewise.
6016 * lisp.h (pop_message, set_message, check_point_in_composition):
6017 Likewise.
6018 * xterm.h (set_vertical_scroll_bar): Likewise.
6019 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6020 (message_buf_print, scratch_glyph_row, displayed_buffer):
6021 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6022 (get_next_display_element, show_mouse_face, window_box_edges):
6023 (frame_to_window_pixel_xy, check_point_in_composition):
6024 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6025 (glyph_to_pixel_coords): Remove; unused.
6026
16390cd2
PE
6027 * dired.c (file_name_completion): Now static.
6028
6029 * dbusbind.c (xd_in_read_queued_messages): Now static.
6030
a25f4dfa
PE
6031 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6032 * data.c (circular_list_error): Remove.
6033
14a9c8df
PE
6034 * commands.h (last_point_position, last_point_position_buffer):
6035 (last_point_position_window): Remove decls.
6036 * keyboard.c: Make these variables static.
6037
04f2d78b
CB
6038 * coding.h (coding, code_convert_region, encode_coding_gap):
6039 Remove decls.
74ab6df5
PE
6040 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6041 (iso_code_class, detect_coding, code_convert_region): Now static.
6042 (encode_coding_gap): Remove; unused.
6043
38dfbee1
PE
6044 * chartab.c (chartab_chars, chartab_bits): Now static.
6045
a2cb4e63
PE
6046 * charset.h (charset_iso_8859_1): Remove decl.
6047 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6048 Now static.
6049
127198fd
PE
6050 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6051 * ccl.c (Vccl_program_table): Now static.
6052 (check_ccl_update): Remove; unused.
6053
d85b608f
PE
6054 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6055 * category.h: ... from here.
6056 * category.c (check_category_table, set_category_set): Now static.
6057
31cd66f3
PE
6058 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6059 * lisp.h: Remove these decls.
6060
c358e587
PE
6061 * buffer.c (buffer_count): Remove unused var.
6062
e78aecca
PE
6063 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6064 so that it's not optimized away.
6065 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6066 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6067 exported only to the debugger.
6068
e192d7d3 6069 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6070 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6071
92470028
PE
6072 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6073 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6074 was inaccessible from Lisp.
6075 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6076 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6077
244ed907
PE
6078 alloc.c: Import and export fewer symbols, and remove unused items.
6079 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6080 is defined.
6081 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6082 it's not optimized away by whole-program optimization.
6083 (message_enable_multibyte, free_misc): Remove.
6084 (catchlist, handlerlist, mark_backtrace):
6085 Declare only if BYTE_MARK_STACK.
6086 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6087 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6088 (message_enable_multibyte): Remove decl.
6089 (free_misc, interval_free_list, float_block, float_block_index):
6090 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6091 (cons_free_list, last_marked_index):
6092 Now static.
6093 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6094 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6095 (mark_backtrace): Define only if BYTE_MARK_STACK.
6096 * xdisp.c (message_enable_multibyte): Now static.
6097
61c2b50e 6098 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6099 This makes it easier for human readers (and static analyzers)
6100 to see whether these variables are used from other modules.
6101 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6102 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6103 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6104 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6105 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6106 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6107 * xmenu.c, xselect.c:
6108 Declare Q* vars static if they are not used in other modules.
6109 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6110 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6111 Remove decls of unexported vars.
6112 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6113
95c82688
PE
6114 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6115
16a97296
PE
6116 Make Emacs functions such as Fatom 'static' by default.
6117 This makes it easier for human readers (and static analyzers)
6118 to see whether these functions can be called from other modules.
6119 DEFUN now defines a static function. To make the function external
6120 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6121 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6122 (Finit_image_library):
16a97296
PE
6123 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6124 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6125 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6126 Remove decls, since these functions are now static.
6127 (Funintern, Fget_internal_run_time): New decls, since these functions
6128 were already external.
95c82688 6129
16a97296
PE
6130 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6131 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6132 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6133 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6134 * keyboard.c, keymap.c, lread.c:
6135 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6136 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6137 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6138 Mark functions with DEFUE instead of DEFUN,
6139 if they are used in other modules.
6140 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6141 decls for now-static functions.
6142 * buffer.h (Fdelete_overlay): Remove decl.
6143 * callproc.c (Fgetenv_internal): Mark as internal.
6144 * composite.c (Fremove_list_of_text_properties): Remove decl.
6145 (Fcomposition_get_gstring): New forward static decl.
6146 * composite.h (Fcomposite_get_gstring): Remove decl.
6147 * dired.c (Ffile_attributes): New forward static decl.
6148 * doc.c (Fdocumntation_property): New forward static decl.
6149 * eval.c (Ffetch_bytecode): New forward static decl.
6150 (Funintern): Remove extern decl; now in .h file where it belongs.
6151 * fileio.c (Fmake_symbolic_link): New forward static decl.
6152 * image.c (Finit_image_library): New forward static decl.
6153 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6154 * intervals.h (Fprevious_property_change):
6155 (Fremove_list_of_text_properties): Remove decls.
6156 * keyboard.c (Fthis_command_keys): Remove decl.
6157 (Fcommand_execute): New forward static decl.
6158 * keymap.c (Flookup_key): New forward static decl.
6159 (Fcopy_keymap): Now static.
6160 * keymap.h (Flookup_key): Remove decl.
6161 * process.c (Fget_process): New forward static decl.
6162 (Fprocess_datagram_address): Mark as internal.
6163 * syntax.c (Fsyntax_table_p): New forward static decl.
6164 (skip_chars): Remove duplicate decl.
6165 * textprop.c (Fprevious_property_change): New forward static decl.
6166 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6167 Now internal.
6168 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6169 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6170
785bbd42
PE
6171 * editfns.c (Fformat): Remove unreachable code.
6172
8b913b57
AS
61732011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6174
6175 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6176 change. (Bug#8496)
6177
a6744a35
EZ
61782011-04-13 Eli Zaretskii <eliz@gnu.org>
6179
6180 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6181 when at ZV. (Bug#8487)
6182
e7974947
AS
61832011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6184
baad03f0
AS
6185 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6186 (Bug#8437)
6187 * keyboard.c (parse_tool_bar_item): Likewise.
6188 * sound.c (sound_cleanup, alsa_close): Likewise.
6189 * termcap.c (tgetent): Likewise.
6190 * xfns.c (x_default_font_parameter): Likewise.
6191 * xsettings.c (read_and_apply_settings): Likewise.
6192
e7974947
AS
6193 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6194 (overrun_check_free): Protoize.
6195
28272684
PE
61962011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6197
6198 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6199 since callers should never pass a negative size.
6200 Change the signature to match that of plain 'read' and 'write'; see
6201 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6202 * lisp.h: Update prototypes of emacs_write and emacs_read.
6203
11997c76
EZ
62042011-04-11 Eli Zaretskii <eliz@gnu.org>
6205
6206 * xdisp.c (redisplay_window): Don't try to determine the character
6207 position of the scroll margin if the window start point w->startp
e896f03c 6208 is outside the buffer's accessible region. (Bug#8468)
11997c76 6209
8a2cbd72
EZ
62102011-04-10 Eli Zaretskii <eliz@gnu.org>
6211
6212 Fix write-region and its subroutines for buffers > 2GB.
6213 * fileio.c (a_write, e_write): Modify declaration of arguments and
6214 local variables to support buffers larger than 2GB.
6215 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6216
6217 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6218 argument, local variables, and return value.
6219
6220 * lisp.h: Update prototypes of emacs_write and emacs_read.
6221
6222 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6223
4073e537 62242011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6225
1ebfdcb6
PE
6226 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6227
b2ded58d
PE
6228 Fix more problems found by GCC 4.6.0's static checks.
6229
7d66342c
PE
6230 * xdisp.c (vmessage): Use a better test for character truncation.
6231
bbf47d44
PE
6232 * charset.c (load_charset_map): <, not <=, for optimization,
6233 and to avoid potential problems with integer overflow.
9248994d 6234 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6235 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6236 * editfns.c (Fformat): Likewise.
1e69125e 6237 * syntax.c (skip_chars): Likewise.
3befa583 6238
e3019616
PE
6239 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6240 This also lets GCC 4.6.0 generate slightly better loop code.
6241
becfa255
PE
6242 * callint.c (Fcall_interactively): <, not <=, for optimization.
6243 (Fcall_interactively): Count the number of arguments produced,
6244 not the number of arguments given. This is simpler and lets GCC
6245 4.6.0 generate slightly better code.
6246
dae0cd48
PE
6247 * ftfont.c: Distingish more carefully between FcChar8 and char.
6248 The previous code passed unsigned char * to a functions like
6249 strlen and xstrcasecmp that expect char *, which does not
6250 conform to the C standard.
6251 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6252 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6253 char * when the C standard requires it.
6254
76032d70
PE
6255 * keyboard.c (read_char): Remove unused var.
6256
eb3f1cc8
PE
6257 * eval.c: Port to Windows vsnprintf (Bug#8435).
6258 Include <limits.h>.
6259 (SIZE_MAX): Define if the headers do not.
6260 (verror): Do not give up if vsnprintf returns a negative count.
6261 Instead, grow the buffer. This ports to Windows vsnprintf, which
6262 does not conform to C99. Problem reported by Eli Zaretskii.
6263 Also, simplify the allocation scheme, by avoiding the need for
6264 calling realloc, and removing the ALLOCATED variable.
6265
70476b54
PE
6266 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6267
12020a9e
PE
6268 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6269 But keep the doprint source code for now, as we might revamp it
6270 and use it again (Bug#8435).
ea6c7ae6
PE
6271 * lisp.h (doprnt): Remove.
6272 * Makefile.in (base_obj): Remove doprnt.o.
6273 * deps.mk (doprnt.o): Remove.
6274
5fdb398c
PE
6275 error: Print 32- and 64-bit integers portably (Bug#8435).
6276 Without this change, on typical 64-bit hosts error ("...%d...", N)
6277 was used to print both 32- and 64-bit integers N, which relied on
6278 undefined behavior.
6279 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6280 New macro.
6281 * lisp.h (error, verror): Mark as printf-like functions.
6282 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6283 Report overflow in size calculations when allocating printf buffer.
6284 Do not truncate output string at its first null byte.
6285 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6286 Truncate the output at a character boundary, since vsnprintf does not
6287 do that.
6288 * charset.c (check_iso_charset_parameter): Convert internal
6289 character to string before calling 'error', since %c now has the
6290 printf meaning.
6291 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6292 overflow when computing char to be passed to 'error'. Do not
6293 pass Lisp_Object to 'error'; pass the integer instead.
6294 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6295 formatted with plain %d.
6296
b189fa66
PE
6297 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6298
bff87ef0
PE
6299 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6300
7e2cac20
PE
6301 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6302
ce4d90b5
PE
6303 * xterm.c (x_catch_errors): Remove duplicate declaration.
6304
266c9547
PE
6305 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6306
79c49ad2
PE
6307 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6308
368f4090
JM
63092011-04-10 Jim Meyering <meyering@redhat.com>
6310
6311 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6312 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6313 return ssize_t not "int", and use size_t as the buffer length.
6314 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6315 * gnutls.h: Update declarations.
6316 * process.c (read_process_output): Use ssize_t, to match.
6317 (send_process): Likewise.
6318
a32d4040
CY
63192011-04-09 Chong Yidong <cyd@stupidchicken.com>
6320
6321 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6322
8546720e 63232011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6324
04f2d78b
CB
6325 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6326 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6327
8546720e
GM
6328 * xterm.c (handle_one_xevent):
6329 * xmenu.c (create_and_show_popup_menu):
6330 * xselect.c (x_decline_selection_request)
6331 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6332
0a2f5c1a 63332011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6334
6335 Fix some uses of `int' instead of EMACS_INT.
6336 * search.c (string_match_1, fast_string_match)
6337 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6338 (scan_buffer, find_next_newline_no_quit)
6339 (find_before_next_newline, search_command, Freplace_match)
6340 (Fmatch_data): Make some `int' variables be EMACS_INT.
6341
6342 * xdisp.c (display_count_lines): 3rd argument and return value now
6343 EMACS_INT. All callers changed.
6344 (pint2hrstr): Last argument is now EMACS_INT.
6345
6346 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6347 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6348 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6349 (decode_coding_utf_16, decode_coding_emacs_mule)
6350 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6351 (decode_coding_ccl, decode_coding_charset)
6352 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6353 (decode_coding_iso_2022, decode_coding_emacs_mule)
6354 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6355 <char_offset, last_offset>: Declare EMACS_INT.
6356 (encode_coding_utf_8, encode_coding_utf_16)
6357 (encode_coding_emacs_mule, encode_invocation_designation)
6358 (encode_designation_at_bol, encode_coding_iso_2022)
6359 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6360 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6361 Declare EMACS_INT.
6362 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6363 (encode_invocation_designation): Last argument P_NCHARS is now
6364 EMACS_INT.
6365 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6366 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6367
6368 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6369 All users changed.
6370
6371 * ccl.c (Fccl_execute_on_string): Declare some variables
6372 EMACS_INT.
6373
8546720e 63742011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6375
6376 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6377
4e19a977
CS
63782011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6379
6380 * process.c (Fformat_network_address): Doc fix.
6381
87302331
R
63822011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6383
6384 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6385
cbb59342
CY
63862011-04-08 Chong Yidong <cyd@stupidchicken.com>
6387
6388 * keyboard.c (read_char): Call Lisp function help-form-show,
6389 instead of using internal_with_output_to_temp_buffer.
6390 (Qhelp_form_show): New var.
e0d38eeb 6391 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6392
6393 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6394
6395 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6396
e67a13ab
CY
63972011-04-06 Chong Yidong <cyd@stupidchicken.com>
6398
04f2d78b
CB
6399 * process.c (Flist_processes): Remove to Lisp.
6400 (list_processes_1): Delete.
e67a13ab 6401
973f782d
EZ
64022011-04-06 Eli Zaretskii <eliz@gnu.org>
6403
7c106b1e
EZ
6404 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6405
973f782d
EZ
6406 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6407
41cf7d1a 64082011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6409
ca23cc88
PE
6410 Fix more problems found by GCC 4.6.0's static checks.
6411
f390e2d5
PE
6412 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6413
42eea0d0
PE
6414 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6415
b69769da 6416 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6417
f9541e84
PE
6418 * xdisp.c (vmessage): Mark as a printf-like function.
6419
13841b55
PE
6420 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6421
c136c10f
PE
6422 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6423
5e2d4a30
PE
6424 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6425 printf-like functions.
6426 (tiff_load): Add casts to remove these marks before passing them
6427 to system-supplied API.
6428
583f48b9
PE
6429 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6430
b25d760e
PE
6431 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6432 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6433 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6434 directly, rather than having caller test rule sign. This avoids
6435 some unnecessary tests.
6436 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6437 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6438 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6439
bc7b6697 6440 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6441 (xfont_open): Avoid unnecessary tests.
bc7b6697 6442
27ccc379
PE
6443 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6444
dcd5c89a
PE
6445 * composite.h, composite.c (composition_gstring_put_cache):
6446 Use EMACS_INT, not int, for length.
6447
b13a45c6
PE
6448 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6449 breaking out part of COMPOSITION_DECODE_RULE.
6450 (COMPOSITION_DECODE_RULE): Use it.
6451 * composite.c (get_composition_id): Remove unused local vars,
6452 by using the new macro.
6453
1e792e4d
PE
6454 * textprop.c (set_text_properties_1): Change while to do-while,
6455 since the condition is always true at first.
6456
dc6c6455 6457 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6458 (interval_deletion_adjustment): Return unsigned value.
6459 All uses changed.
dc6c6455 6460
aba7731a
PE
6461 * process.c (list_processes_1, create_pty, read_process_output):
6462 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6463 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6464 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6465 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6466 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6467
fdfc4bf3
PE
6468 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6469
fca8fe46 6470 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6471 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6472
06a0259a 6473 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6474 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6475 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6476
e7b9e80f
PE
6477 * print.c (print_error_message): Avoid int overflow.
6478
56201685
PE
6479 * font.c (font_list_entities): Redo for clarity,
6480 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6481
78834453 6482 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6483 (font_score): Avoid potential overflow in diff calculation.
78834453 6484
0bc0b309 6485 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6486 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6487
e610eaca
PE
6488 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6489
b895abce
PE
6490 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6491 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6492 can always succeed if overflow has undefined behavior.
6493
1f1d9321 6494 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6495 (wordify): Omit three unnecessary tests.
1f1d9321 6496
c59478bc
PE
6497 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6498 All callers changed. This avoids the need for an unused var.
6499
79b73827
PE
6500 * casefiddle.c (casify_region): Remove var that is set but not used.
6501
a4db5dfe
PE
6502 * dired.c (file_name_completion): Remove var that is set but not used.
6503
43aae36e
PE
6504 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6505
2a47c44d 6506 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6507 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6508
a37c69bf
PE
6509 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6510 Check for integer overflow on size calculations.
6511
328ab8e7
PE
6512 * buffer.c (Fprevious_overlay_change): Remove var that is set
6513 but not used.
6514
e5a2a5cb
PE
6515 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6516 Remove vars that are set but not used.
8d84a6eb 6517 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6518 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6519
a60e5f68
PE
6520 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6521
f661cb61 6522 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6523 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6524
f0397f5a
PE
6525 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6526 that are set but not used.
6527
8664db06 6528 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6529 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6530
6abdaa4a
PE
6531 * xselect.c (x_get_local_selection, x_handle_property_notify):
6532 Remove vars that are set but not used.
6533
0ce7538d 6534 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6535 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6536
9ae848fc
PE
6537 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6538 Remove var that is set but not used.
0b918413
PE
6539 (scroll_bar_windows_size): Now size_t, not int.
6540 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6541 Check for overflow.
9ae848fc 6542
a5a62657
PE
6543 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6544 (map_tty_color) [!defined MSDOS]: Likewise.
6545
5c5cdd39
PE
6546 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6547
66ebf983
PE
6548 * coding.c: Remove vars that are set but not used.
6549 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6550 All callers changed.
6551 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6552 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6553 (decode_coding_charset): Remove vars that are set but not used.
6554
1be4d761
PE
6555 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6556 that is set but not used.
6557
47553fa8
PE
6558 * print.c (print_object): Remove var that is set but not used.
6559
1f7196bf 6560 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6561 The gnulib version avoids calling malloc in the usual case,
6562 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6563 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6564 * filelock.c (current_lock_owner): Likewise.
6565 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6566 * sysdep.c: Include allocator.h, careadlinkat.h.
6567 (emacs_no_realloc_allocator): New static constant.
6568 (emacs_readlink): New function.
fdb61804
PE
6569 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6570 ../lib/careadlinkat.h.
d1fdcab7 6571
f84c17c7
SM
65722011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6573
6574 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6575 first non-nil return value).
6576
ef3862ad
JD
65772011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6578
6579 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6580 if not defined (Bug#8403).
6581
376a7006
JB
65822011-04-02 Juanma Barranquero <lekktu@gmail.com>
6583
6584 * xdisp.c (display_count_lines): Remove parameter `start',
6585 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6586 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6587 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6588 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6589 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6590 and thereabouts. All callers changed.
6591 (get_per_char_metric): Remove parameter `f', unused since
6592 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6593
6ca3801d
JM
65942011-04-02 Jim Meyering <meyering@redhat.com>
6595
6596 do not dereference NULL upon failed strdup
6597 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6598 (ns_get_family): Likewise.
6599
d8e2b5ba
JB
66002011-04-02 Juanma Barranquero <lekktu@gmail.com>
6601
6602 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6603
8c74fcbd
JD
66042011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6605
6606 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6607 later (Bug#8403).
6608
7200d79c
SM
66092011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6610
03408648 6611 Add lexical binding.
7200d79c 6612
03408648
SM
6613 * window.c (Ftemp_output_buffer_show): New fun.
6614 (Fsave_window_excursion):
6615 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6616
6617 * lread.c (lisp_file_lexically_bound_p): New function.
6618 (Fload): Bind Qlexical_binding.
6619 (readevalloop): Remove `evalfun' arg.
6620 Bind Qinternal_interpreter_environment.
6621 (Feval_buffer): Bind Qlexical_binding.
6622 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6623 Mark as dynamic.
6624 (syms_of_lread): Declare `lexical-binding'.
6625
6626 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6627
6628 * keyboard.c (eval_dyn): New fun.
6629 (menu_item_eval_property): Use it.
ca105506
SM
6630
6631 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6632
03408648
SM
6633 * fns.c (concat, mapcar1): Accept byte-code-functions.
6634
6635 * eval.c (Fsetq): Handle lexical vars.
6636 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6637 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6638 (FletX, Flet): Obey lexical binding.
6639 (Fcommandp): Handle closures.
6640 (Feval): New `lexical' arg.
6641 (eval_sub): New function extracted from Feval. Use it almost
6642 everywhere where Feval was used. Look up vars in lexical env.
6643 Handle closures.
6644 (Ffunctionp): Move from subr.el.
6645 (Ffuncall): Handle closures.
6646 (apply_lambda): Remove `eval_flags'.
6647 (funcall_lambda): Handle closures and new byte-code-functions.
6648 (Fspecial_variable_p): New function.
6649 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6650 but without exporting it to Lisp.
23aba0ea 6651
23aba0ea 6652 * doc.c (Fdocumentation, store_function_docstring):
03408648 6653 * data.c (Finteractive_form): Handle closures.
23aba0ea 6654
03408648
SM
6655 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6656 interactive spec.
ba83908c 6657
04f2d78b
CB
6658 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6659 New byte-codes.
03408648
SM
6660 (exec_byte_code): New function extracted from Fbyte_code to handle new
6661 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6662
03408648 6663 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6664
03408648 6665 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6666
e2abce01
JB
66672011-03-31 Juanma Barranquero <lekktu@gmail.com>
6668
6669 * xdisp.c (redisplay_internal): Fix prototype.
6670
63696a73 66712011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6672
63696a73 6673 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6674 (try_scrolling): Use it when setting scroll_limit.
6675 Limit scrolling to 100 screen lines.
63696a73
EZ
6676 (redisplay_window): Even when falling back on "recentering",
6677 position point in the window according to scroll-conservatively,
6678 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6679
6680 (try_scrolling): When point is above the window, allow searching
6681 as far as scroll_max, or one screenful, to compute vertical
6682 distance from PT to the scroll margin position. This prevents
6683 try_scrolling from unnecessarily failing when
6684 scroll-conservatively is set to a value slightly larger than the
6685 window height. Clean up the case of PT below the margin at bottom
6686 of window: scroll_max can no longer be INT_MAX. When aggressive
6687 scrolling is in use, don't let point enter the opposite scroll
6688 margin as result of the scroll.
6689 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6690 threshold of 100 lines for never-recentering scrolling.
6691
e4cc2dfc
JB
66922011-03-31 Juanma Barranquero <lekktu@gmail.com>
6693
6694 * dispextern.h (move_it_by_lines):
6695 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6696 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6697 (message_log_check_duplicate): Remove parameters `prev_bol' and
6698 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6699 (redisplay_internal): Remove parameter `preserve_echo_area',
6700 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6701
6702 * indent.c (Fvertical_motion):
6703 * window.c (window_scroll_pixel_based, Frecenter):
6704 Don't pass `need_y_p' to `move_it_by_lines'.
6705
1c470562
SM
67062011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6707
44f230aa
SM
6708 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6709 steal a few bits to be more compact.
6710 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6711 Remove unneeded casts.
6712
1c470562
SM
6713 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6714
888adce9
ZK
67152011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6716
6717 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6718 binding" message (bug#7967).
6719
f838ed7b
PE
67202011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6721
77861b95
PE
6722 Fix more problems found by GCC 4.6.0's static checks.
6723
de6dbc14
PE
6724 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6725 Remove unused local var.
6726
f838ed7b
PE
6727 * editfns.c (Fmessage_box): Remove unused local var.
6728
792c7b2b
PE
6729 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6730 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6731 Omit unused local vars.
c499e557 6732 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6733 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6734 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6735 Omit unused local var.
6736
ba0165e1
PE
6737 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6738 Don't assume string length fits in int.
32ad8845 6739 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6740 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6741
3c59b4c9
PE
6742 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6743 instead of alloca (Bug#8344).
6744
a3eed478 6745 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6746 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6747
eb4d412d
PE
6748 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6749
1658b401
PE
6750 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6751 concerns.
6752
6753 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6754
6755 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6756
9a2c6e05
PE
6757 * keyboard.c (syms_of_keyboard): Use the same style as later
6758 in this function when indexing through an array. This also
6759 works around GCC bug 48267.
6760
03d0a109
PE
6761 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6762
44f730c8
PE
6763 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6764
fe75f926
PE
6765 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6766 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6767
ffa8c828
PE
6768 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6769 This avoids undefined behavior on integer overflow, and is a bit
6770 more convenient anyway since it is compared to a size_t variable.
6771
c5101a77
PE
6772 Variadic C functions now count arguments with size_t, not int.
6773 This avoids an unnecessary limitation on 64-bit machines, which
6774 caused (substring ...) to crash on large vectors (Bug#8344).
6775 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6776 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6777 All variadic functions and their callers changed accordingly.
c5101a77
PE
6778 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6779 * data.c (arith_driver, float_arith_driver): Likewise.
6780 * editfns.c (general_insert_function): Likewise.
6781 * eval.c (struct backtrace.nargs, interactive_p)
6782 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6783 (funcall_lambda, mark_backtrace): Likewise.
6784 * fns.c (concat): Likewise.
6785 * frame.c (x_set_frame_parameters): Likewise.
6786 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6787 0 if not found, not -1. All callers changed.
6788
dd3f25f7
PE
6789 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6790 (stack_copy_size): Now size_t, not int.
6791 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6792
461c2ab9
JB
67932011-03-28 Juanma Barranquero <lekktu@gmail.com>
6794
6795 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6796 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6797 All callers changed.
6798
6799 * lisp.h (multibyte_char_to_unibyte):
6800 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6801 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6802 * character.h (CHAR_TO_BYTE8):
6803 * cmds.c (internal_self_insert):
6804 * editfns.c (general_insert_function):
6805 * keymap.c (push_key_description):
6806 * search.c (Freplace_match):
6807 * xdisp.c (message_dolog, set_message_1): All callers changed.
6808
f6d62986
SM
68092011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6810
6811 * keyboard.c (safe_run_hook_funcall): New function.
6812 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6813 don't set the hook to nil, but remove the offending function instead.
6814 (Qcommand_hook_internal): Remove, unused.
6815 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6816 Vcommand_hook_internal.
6817
6818 * eval.c (enum run_hooks_condition): Remove.
6819 (funcall_nil, funcall_not): New functions.
6820 (run_hook_with_args): Call each function through a `funcall' argument.
6821 Remove `cond' argument, now redundant.
6822 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6823 (Frun_hook_with_args_until_failure): Adjust accordingly.
6824 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6825
1db5b1ad
JB
68262011-03-28 Juanma Barranquero <lekktu@gmail.com>
6827
6828 * dispextern.h (string_buffer_position): Remove declaration.
6829
6830 * print.c (strout): Remove parameter `multibyte', unused since
6831 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6832
6833 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6834 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6835 All callers changed.
6836
6837 * w32.c (_wsa_errlist): Use braces for struct initializers.
6838
6839 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6840 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6841 All callers changed.
6842 (string_buffer_position): Likewise. Also, make static (it's never
6843 used outside xdisp.c).
6844 (cursor_row_p): Remove parameter `w', unused since
6845 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6846 (decode_mode_spec): Remove parameter `precision', introduced during
6847 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6848 All callers changed.
6849
5ffb62aa
JD
68502011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6851
6852 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6853
461c2ab9 68542011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6855
6856 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6857 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6858 (ns_update_auto_hide_menu_bar): New functions.
6859 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6860 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6861 ns_constrain_all_frames.
6862 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6863 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6864
5c380ffb
JD
68652011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6866
6867 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6868
9af30bdf
GM
68692011-03-27 Glenn Morris <rgm@gnu.org>
6870
6871 * syssignal.h: Replace RETSIGTYPE with void.
6872 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6873 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6874 Replace SIGTYPE with void everywhere.
6875 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6876 * s/template.h (SIGTYPE): Remove commented out definition.
6877
e2abce01
JB
68782011-03-26 Eli Zaretskii <eliz@gnu.org>
6879
6880 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6881 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6882
f868cd8a
JB
68832011-03-26 Juanma Barranquero <lekktu@gmail.com>
6884
59eb0929
JB
6885 * w32.c (read_unc_volume): Use parameter `henum', instead of
6886 global variable `wget_enum_handle'.
6887
6888 * keymap.c (describe_vector): Remove parameters `indices' and
6889 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6890 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6891
f868cd8a
JB
6892 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6893
6894 * keyboard.c (timer_check): Remove parameter `do_it_now',
6895 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6896 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6897 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6898
6899 * keyboard.c (read_char):
6900 * w32menu.c (w32_menu_display_help):
6901 * xmenu.c (show_help_event, menu_help_callback):
6902 Adjust calls to `show_help_echo'.
6903
6904 * gtkutil.c (xg_maybe_add_timer):
6905 * keyboard.c (readable_events):
6906 * process.c (wait_reading_process_output):
6907 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6908
6909 * insdel.c (adjust_markers_gap_motion):
6910 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6911 (gap_left, gap_right): Don't call it.
6912
2ecf6fdb
CY
69132011-03-25 Chong Yidong <cyd@stupidchicken.com>
6914
6915 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6916 incurred during fontification.
6917
6b1f9ba4
JB
69182011-03-25 Juanma Barranquero <lekktu@gmail.com>
6919
6920 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6921 (DEFVAR_PER_BUFFER): Don't pass it.
6922
6923 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6924 (scrolling_window): Don't pass it.
6925
0f4a96b5
JB
69262011-03-25 Juanma Barranquero <lekktu@gmail.com>
6927
6928 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6929
6930 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6931 and `suffix'.
6932 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6933 of variables specific to SELinux and computation of `encoded_absname'.
6934
6935 * image.c (XPutPixel): Remove unused variable `height'.
6936
6937 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6938
6939 * unexw32.c (get_section_info): Remove unused variable `section'.
6940
6941 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6942 (system_process_attributes): Remove unused variable `sess'.
6943 (sys_read): Remove unused variable `err'.
6944
6945 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6946 (w32_wnd_proc): Remove unused variable `isdead'.
6947 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6948 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6949 (x_create_tip_frame): Remove unused variable `tem'.
6950
6951 * w32inevt.c (w32_console_read_socket):
6952 Remove unused variable `no_events'.
6953
6954 * w32term.c (x_draw_composite_glyph_string_foreground):
6955 Remove unused variable `width'.
6956
1149507c
JB
69572011-03-24 Juanma Barranquero <lekktu@gmail.com>
6958
6959 * w32term.c (x_set_glyph_string_clipping):
6960 Don't pass uninitialized region to CombineRgn.
6961
9c88f339
JB
69622011-03-23 Juanma Barranquero <lekktu@gmail.com>
6963
6964 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6965 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6966 (Fx_close_connection): Remove unused variable `i'.
6967
6968 * w32font.c (w32font_draw): Return number of glyphs.
6969 (w32font_open_internal): Remove unused variable `i'.
6970 (w32font_driver): Add missing initializer.
6971
6972 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6973 (fill_in_menu): Remove unused variable `items_added'.
6974
6975 * w32term.c (last_mouse_press_frame): Remove static global variable.
6976 (w32_clip_to_row): Remove unused variable `f'.
6977 (x_delete_terminal): Remove unused variable `i'.
6978
6979 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6980 (NOTHING): Remove unused static global variable.
6981 (uniscribe_check_otf): Remove unused variable `table'.
6982 (uniscribe_font_driver): Add missing initializers.
6983
dee091a3
JD
69842011-03-23 Julien Danjou <julien@danjou.info>
6985
6986 * term.c (Fsuspend_tty, Fresume_tty):
6987 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6988 * window.c (temp_output_buffer_show):
6989 * insdel.c (signal_before_change):
6990 * frame.c (Fhandle_switch_frame):
6991 * fileio.c (Fdo_auto_save):
6992 * emacs.c (Fkill_emacs):
6993 * editfns.c (save_excursion_restore):
6994 * cmds.c (internal_self_insert):
6995 * callint.c (Fcall_interactively):
6996 * buffer.c (Fkill_all_local_variables):
6997 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6998 Use Frun_hooks.
0f4a96b5 6999 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
7000 unconditionnaly since it does the check itself.
7001
2c520ab5 70022011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7003
c9c49752
PE
7004 Fix more problems found by GCC 4.5.2's static checks.
7005
8abc3f12
PE
7006 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7007 the first time through the loop, since we know p0 < p1 then.
7008 This also avoids a gcc -Wstrict-overflow warning.
7009
a2d26660
PE
7010 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7011 leading to a memory leak, possible in functions like
7012 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7013 of objects (Bug#8318).
a2d26660 7014
916c72e9
PE
7015 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7016 that could (at least in theory) be that large.
7017
19ab8a18
PE
7018 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7019 This is less likely to overflow, and avoids undefined behavior if
7020 overflow does occur. All callers changed. Use strtoul to scan
7021 for the unsigned long integer.
b7cbbd6f
PE
7022 (pint2hrstr): Simplify and tune code slightly.
7023 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7024
f0641eff
PE
7025 * scroll.c (do_scrolling): Work around GCC bug 48228.
7026 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7027
7f650bb9
PE
7028 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7029 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7030 (validate_x_resource_name): Simplify count usage.
7031 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7032
37dd57d1
PE
7033 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7034 fail (Bug#8306).
81e56e61 7035
699979fc 7036 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7037
401bf9b4
PE
7038 * process.c (Fmake_network_process): Use socklen_t, not int,
7039 where POSIX says socklen_t is required in portable programs.
7040 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7041 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7042 (Fmake_network_process, server_accept_connection):
7043 (wait_reading_process_output, read_process_output):
7044 Likewise.
7045
b93aacde
PE
7046 * process.c: Rename or move locals to avoid shadowing.
7047 (list_processes_1, Fmake_network_process):
7048 (read_process_output_error_handler, exec_sentinel_error_handler):
7049 Rename or move locals.
4dc343ee 7050 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7051 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7052 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7053 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7054 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7055
af8a867c 7056 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7057 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7058 Include tparam.h instead, since it declares them.
af8a867c
PE
7059 * cm.h (PC): Remove extern decl; tparam.h now does this.
7060 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7061 * terminfo.c: Include tparam.h, to check interfaces.
7062 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7063 (tparam): Adjust signature to match interface in tparam.h;
7064 this removes some undefined behavior. Check that outstring and len
7065 are zero, which they always are with Emacs.
7066 * tparam.h (PC, BC, UP): New extern decls.
7067
0248044d 7068 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7069 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7070
8ff096c1 7071 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7072 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7073 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7074 (ftfont_list): Remove unused local.
49eaafba
PE
7075 (get_adstyle_property, ftfont_pattern_entity):
7076 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7077 Rename locals to avoid shadowing.
8ff096c1 7078
e2be39f6
PE
7079 * xfont.c (xfont_list_family): Mark var as initialized.
7080
c9735e30
PE
7081 * xml.c (make_dom): Now static.
7082
8f5201ae
PE
7083 * composite.c (composition_compute_stop_pos): Rename local to
7084 avoid shadowing.
b246f932
PE
7085 (composition_reseat_it): Remove unused locals.
7086 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7087 (composition_update_it): Mark var as initialized.
11b61122
PE
7088 (find_automatic_composition): Mark vars as initialized,
7089 with a FIXME (Bug#8290).
8f5201ae 7090
760fbc2c
PE
7091 character.h: Rename locals to avoid shadowing.
7092 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7093 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7094 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7095 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7096 to avoid shadowing.
7097
ff08eb85
PE
7098 * textprop.c (property_change_between_p): Remove; unused.
7099
fc7bf025
PE
7100 * intervals.c (interval_start_pos): Now static.
7101
235d7abc
PE
7102 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7103
44f230aa
SM
7104 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7105 Rename locals to avoid shadowing.
3e7d6594 7106
50060332
PE
7107 * sound.c (wav_play, au_play, Fplay_sound_internal):
7108 Fix pointer signedness.
d01f234b 7109 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7110 (wav_play): Initialize a variable to 0, to prevent undefined
7111 behavior (Bug#8278).
50060332 7112
c4fc4e30
PE
7113 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7114
918436ed
PE
7115 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7116
c939f91b
PE
7117 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7118 clobbering (Bug#8298).
b9c7f648
PE
7119 * sysdep.c (sys_subshell): Likewise.
7120 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7121
6bd8c144
PE
7122 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7123 This should get cleaned up, so that child_setup has the
7124 same signature on all platforms.
7125
7710357c 7126 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7127 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7128
c59da222
CY
71292011-03-22 Chong Yidong <cyd@stupidchicken.com>
7130
7131 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7132 not to be necessary, and produces flickering.
7133
66b87493
GM
71342011-03-20 Glenn Morris <rgm@gnu.org>
7135
7136 * config.in: Remove file.
7137
45b6f6d5
JB
71382011-03-20 Juanma Barranquero <lekktu@gmail.com>
7139
7140 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7141 are now in src/globals.h.
7142 (syms_of_minibuf): Remove spurious & from previous change.
7143
3ec03f7e
LL
71442011-03-20 Leo <sdl.web@gmail.com>
7145
7146 * minibuf.c (completing-read-function): New variable.
7147 (completing-read-default): Rename from completing-read.
7148 (completing-read): Call completing-read-function.
7149
b14e3e21
CY
71502011-03-19 Juanma Barranquero <lekktu@gmail.com>
7151
7152 * xfaces.c (Fx_load_color_file):
7153 Read color file from absolute filename (bug#8250).
7154
f2b726e6
JB
71552011-03-19 Juanma Barranquero <lekktu@gmail.com>
7156
7157 * makefile.w32-in: Update dependencies.
7158
09f6ff02
EZ
71592011-03-17 Eli Zaretskii <eliz@gnu.org>
7160
7161 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7162
29a6015a
PE
71632011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7164
a3a6c54e
PE
7165 Fix more problems found by GCC 4.5.2's static checks.
7166
b766f867
PE
7167 * process.c (make_serial_process_unwind, send_process_trap):
7168 (sigchld_handler): Now static.
7169
be02381c
PE
7170 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7171 That way, the code declares only the vars that it needs.
7172 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7173 * s/cygwin.h (PTY_ITERATION): Likewise.
7174 * s/darwin.h (PTY_ITERATION): Likewise.
7175 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7176
57048744
PE
7177 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7178 * process.c (allocate_pty): Don't declare stb unless it's needed.
7179
7914961c 7180 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7181 (CONSTANTLIM): Remove; unused.
7182 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7183 Define only if needed.
7914961c 7184
b3967b18
PE
7185 * unexelf.c (unexec): Name an expression,
7186 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7187 Use a different way to cause a compilation error if anyone uses
7188 n rather than nn, a way that does not involve shadowing.
73366a00 7189 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7190
29a6015a
PE
7191 * deps.mk (unexalpha.o): Remove; unused.
7192
43cfc33e 7193 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7194 * unexec.h: New file.
ce701a33
PE
7195 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7196 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7197 Depend on unexec.h.
7198 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7199 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7200 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7201 Change as necessary to match prototype in unexec.h.
ce701a33 7202
01f44d5a
PE
7203 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7204 shadowing.
4f63c6bb 7205 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7206
a6670b0b
PE
7207 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7208 Rename locals to avoid shadowing.
7209
cef2010d 7210 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7211 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7212
d4d7173a
PE
7213 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7214
f08b802a
PE
7215 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7216 warning when compiling print.c.
7217
3ddb0639
PE
7218 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7219 instead of using an uninitialized var.
5ad03b97 7220 (font_sort_entities): Mark var as initialized.
3ddb0639 7221
170a2692
PE
7222 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7223
e663c700
PE
7224 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7225 pointers to constants.
89bc529a 7226 (font_parse_fcname): Remove unused vars.
7b81e2d0 7227 (font_delete_unmatched): Now static.
ea838e10 7228 (font_get_spec): Remove; unused.
13a547c6
PE
7229 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7230 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7231 Rename or move locals to avoid shadowing.
e663c700 7232
2a80c887 7233 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7234 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7235
1384fa33 7236 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7237 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7238
8b2c52e9
PE
7239 * alloc.c (mark_backtrace): Move decl from here ...
7240 * lisp.h: ... to here, so that it can be checked.
7241
475545b5 7242 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7243 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7244 (lisp_indirect_variable): Name an expression,
7245 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7246 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7247
b1349114 7248 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7249 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7250 Use const pointer when appropriate.
b1349114 7251
a2928364
PE
7252 * lisp.h (get_system_name, get_operating_system_release):
7253 Move decls here, to check interfaces.
7254 * process.c (get_operating_system_release): Move decl to lisp.h.
7255 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7256 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7257 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7258 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7259 (Fformat_time_string, Fencode_time, Finsert_char):
7260 (Ftranslate_region_internal, Fformat):
7261 Rename or remove local vars to avoid shadowing.
9710023e 7262 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7263
a415e694
PE
7264 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7265 avoid shadowing.
7266
8ef4622d
PE
7267 * lisp.h (eassert): Check that the argument compiles, even if
7268 ENABLE_CHECKING is not defined.
7269
946f9a5b
PE
7270 * data.c (Findirect_variable): Name an expression, to avoid
7271 gcc -Wbad-function-cast warning.
112396d6 7272 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7273 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7274 (Fmake_variable_buffer_local, Fmake_local_variable):
7275 Mark variables as initialized.
52746918 7276 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7277
e5aab7e7 7278 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7279 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7280 Rename locals to avoid shadowing.
dff45157
PE
7281 (mark_stack): Move local variables into the #ifdef region where
7282 they're used.
7bc26fdb
PE
7283 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7284 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7285 needed otherwise.
7286 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7287 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7288 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7289
e5aab7e7
PE
7290 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7291 avoids undefined behavior in theory.
7292
4da60324
PE
7293 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7294
88043301
PE
7295 Use functions, not macros, for up- and down-casing (Bug#8254).
7296 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7297 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7298 to use the following functions instead of these macros.
7299 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7300 EMACS_INT, since callers assume the returned value fits in int.
7301 (upcase1): Likewise, for UPCASE_TABLE.
7302 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7303 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7304 the race-condition problem in the old DOWNCASE.
88043301 7305
19ed5445
PE
7306 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7307 Rename locals to avoid shadowing.
7308 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7309 (regex_compile, re_search_2, re_match_2_internal):
7310 Remove unused local vars.
952db0d7
PE
7311 (FREE_VAR): Rewrite so as not to use empty "else",
7312 which gcc can warn about.
da053e48 7313 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7314 (RETALLOC_IF): Define only if needed.
7315 (WORDCHAR_P): Likewise. This one is never needed, but is used
7316 only in a comment talking about a compiler bug, so put inside
7317 the #if 0 of that comment.
7318 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7319 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7320 Remove; unused.
19ed5445 7321
1f3561e4 7322 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7323 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7324 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7325
ded6f8f7
PE
7326 * search.c (simple_search): Remove unused var.
7327
dbd37a95
PE
7328 * dired.c (compile_pattern): Move decl from here ...
7329 * lisp.h: ... to here, so that it can be checked.
7330 (struct re_registers): New forward decl.
7331
7e47afad
PE
7332 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7333
85f24f61
PE
7334 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7335 All uses changed.
7336 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7337 Rename locals to avoid shadowing.
5671df8f 7338 (Fvertical_motion): Mark locals as initialized.
85f24f61 7339
181aa2be 7340 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7341 (casify_region): Mark local as initialized.
181aa2be 7342
930d429c
PE
7343 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7344
7082eac6
PE
7345 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7346 New macros, so that the caller can use some names other than
7347 gcpro1, gcpro2, etc.
7348 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7349 of the new macros.
7350 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7351 argument, for consistency with GCPRO2_VAR, etc: it is now the
7352 prefix of the variable, not the variable itself. All uses
7353 changed.
38b2c076
PE
7354 * dired.c (directory_files_internal, file_name_completion):
7355 Rename locals to avoid shadowing.
7356
15206ed9
PE
7357 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7358 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7359 dired.c's scmp function, had undefined behavior.
7360 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7361 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7362 * buffer.h: ... to here, because these macros use current_buffer,
7363 and the new implementation with inline functions needs to have
7364 current_buffer in scope now, rather than later when the macros
7365 are used.
7366 (downcase, upcase1): New static inline functions.
7367 (DOWNCASE, UPCASE1): Reimplement using these functions.
7368 This avoids undefined behavior in expressions like
7369 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7370 from race conditions in accessing the global variables
7371 case_temp1 and case_temp2.
7372 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7373 * lisp.h (case_temp1, case_temp2): Remove their decls.
7374 * character.h (ASCII_CHAR_P): Move from here ...
7375 * lisp.h: ... to here, so that the inline functions mentioned
7376 above can use them.
7377
4a6bea26
PE
7378 * dired.c (directory_files_internal_unwind): Now static.
7379
f14b7e14
PE
7380 * fileio.c (file_name_as_directory, directory_file_name):
7381 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7382 Now static.
2893f146
PE
7383 (file_name_as_directory): Use const pointers when appropriate.
7384 (Fexpand_file_name): Likewise. In particular, newdir might
7385 point at constant storage, so make it a const pointer.
fd4ead52 7386 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7387 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7388 signedness issues.
f839df0c
PE
7389 (Fset_file_times, Finsert_file_contents, auto_save_error):
7390 Rename locals to avoid shadowing.
f14b7e14 7391
5716756e 7392 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7393 (Ftry_completion, Fall_completions): Rename or remove locals
7394 to avoid shadowing.
5716756e 7395
b4c3046a
PE
7396 * marker.c (bytepos_to_charpos): Remove; unused.
7397
b45db522
PE
7398 * lisp.h (verify_bytepos, count_markers): New decls,
7399 so that gcc does not warn that these functions aren't declared.
7400
85876d07
PE
7401 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7402 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7403 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7404 (copy_text): Remove unused local var.
85876d07 7405
03d78a21 7406 * filelock.c (within_one_second): Now static.
b3dd38ab 7407 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7408
5df8f01b
PE
7409 * buffer.c (fix_overlays_before): Mark locals as initialized.
7410 (fix_start_end_in_overlays): Likewise. This function should be
7411 simplified by using pointers-to-pointers, but that's a different
7412 matter.
b1d876f1 7413 (switch_to_buffer_1): Now static.
8f54f30a
PE
7414 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7415 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7416
a70072c9 7417 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7418 Fix pointer signedness issue.
edced198
PE
7419 (sys_subshell): Mark local as volatile if checking for lint,
7420 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7421 (MAXPATHLEN): Define only if needed.
a70072c9 7422
a0977c44
PE
7423 * process.c (serial_open, serial_configure): Move decls from here ...
7424 * systty.h: ... to here, so that they can be checked.
7425
a884fdcc
PE
7426 * fns.c (get_random, seed_random): Move extern decls from here ...
7427 * lisp.h: ... to here, so that they can be checked.
7428
604efe86 7429 * sysdep.c (reset_io): Now static.
b8950c94 7430 (wait_for_termination_signal): Remove; unused.
604efe86 7431
38fc62d9
PE
7432 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7433 (copy_keymap_item, append_key, push_text_char_description):
7434 Now static.
1004a21a 7435 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7436 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7437 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7438 (describe_map_tree):
7439 Rename locals to avoid shadowing.
38fc62d9 7440
2f2650da
PE
7441 * keyboard.c: Declare functions static if they are not used elsewhere.
7442 (echo_char, echo_dash, cmd_error, top_level_2):
7443 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7444 (read_char, kbd_buffer_get_event, make_lispy_position):
7445 (make_lispy_event, make_lispy_movement, apply_modifiers):
7446 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7447 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7448 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7449 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7450 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7451
a053e86c 7452 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7453 (mark_kboards): Move decl here ...
7454 * alloc.c (mark_kboards): ... from here.
a053e86c 7455
4752793e
PE
7456 * lisp.h (force_auto_save_soon): New decl.
7457
74f10ca7 7458 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7459 (DEFINE_DUMMY_FUNCTION): New macro.
7460 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7461 Use it.
c03cd23f
PE
7462 (main): Add casts to avoid warnings
7463 if GCC considers string literals to be constants.
74f10ca7 7464
022e70d4
PE
7465 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7466
59d6fe83
PE
7467 * dbusbind.c: Pointer signedness fixes.
7468 (xd_signature, xd_append_arg, xd_initialize):
7469 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7470 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7471 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7472 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7473
78320123
PE
7474 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7475 if GCC considers string literals to be constants.
49cebcca 7476 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7477
35ac2a97
SM
74782011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7479
fb103ca9
SM
7480 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7481 (print_preprocess, print_object): New macro to fix last change.
7482
35ac2a97
SM
7483 * print.c (print_preprocess): Don't forget font objects.
7484
62973b41
JB
74852011-03-16 Juanma Barranquero <lekktu@gmail.com>
7486
7487 * emacs.c (USAGE3): Doc fixes.
7488
0e48bb22
AS
74892011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7490
7491 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7492 structure.
7493
7684e57b
JB
74942011-03-14 Juanma Barranquero <lekktu@gmail.com>
7495
7496 * lisp.h (VWindow_system, Qfile_name_history):
7497 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7498 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7499 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7500
7501 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7502 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7503
7504 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7505 * w32console.c (detect_input_pending, read_input_pending)
7506 (encode_terminal_code):
7507 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7508 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7509 (w32_system_caret_y, Qfile_name_history):
7510 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7511 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7512 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7513 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7514 * w32proc.c (Qlocal, report_file_error):
7515 * w32term.c (Vwindow_system, updating_frame):
7516 * w32uniscribe.c (initialized, uniscribe_font_driver):
7517 Remove unneeded extern declarations.
7518
2aa46d6c
CY
75192011-03-14 Chong Yidong <cyd@stupidchicken.com>
7520
c96bbc66 7521 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7522
cffc6f3b
CY
75232011-03-13 Chong Yidong <cyd@stupidchicken.com>
7524
7525 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7526 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7527 These macros can no longer be used for assignment.
7528
44f230aa
SM
7529 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7530 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7531 (record_buffer_markers, fetch_buffer_markers): New functions for
7532 recording and fetching special buffer markers.
7533 (set_buffer_internal_1, set_buffer_temp): Use them.
7534
7535 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7536
7537 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7538
7539 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7540 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7541
7542 * xdisp.c (hscroll_window_tree):
7543 (reconsider_clip_changes): Use PT instead of BUF_PT.
7544
d251f04b
EZ
75452011-03-13 Eli Zaretskii <eliz@gnu.org>
7546
7547 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7548 $(EMACS_ROOT)/lib/intprops.h.
7549
f0c77cd1
PE
75502011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7551
3eca4629
PE
7552 Fix more problems found by GCC 4.5.2's static checks.
7553
7c86ee98
PE
7554 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7555 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7556 (xg_free_frame_widgets): Make it clear that a local variable is
7557 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7558 (gdk_window_get_screen): Make it clear that this macro is needed
7559 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7560 (int_gtk_range_get_value): New function, which avoids a diagnostic
7561 from gcc -Wbad-function-cast.
7562 (xg_set_toolkit_scroll_bar_thumb): Use it.
7563 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7564 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7565 (get_utf8_string, xg_get_file_with_chooser):
7566 Rename locals to avoid shadowing.
7567 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7568
41729b81
PE
7569 * xgselect.c (xg_select): Remove unused var.
7570
f0c77cd1
PE
7571 * image.c (four_corners_best): Mark locals as initialized.
7572 (gif_load): Initialize transparent_p to zero (Bug#8238).
7573 Mark another local as initialized.
ec6cf4c6 7574 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7575
ce0ad53d 7576 * image.c (clear_image_cache): Now static.
d5d5a617 7577 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7578 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7579 (x_edge_detection): Remove unnecessary cast that
7580 gcc -Wbad-function-cast diagnoses.
2037898d 7581 (gif_load): Fix pointer signedness.
6ae141d6
PE
7582 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7583 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7584
33383987 75852011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7586
d32df629
PE
7587 Improve quality of tests for time stamp overflow.
7588 For example, without this patch (encode-time 0 0 0 1 1
7589 1152921504606846976) returns the obviously-bogus value (-948597
7590 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7591 reports time overflow. See
7592 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7593 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7594 * editfns.c: Include limits.h and intprops.h.
7595 (TIME_T_MIN, TIME_T_MAX): New macros.
7596 (time_overflow): Move earlier, to before first use.
7597 (hi_time, lo_time): New functions, for an accurate test for
7598 out-of-range times.
7599 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7600 (Fget_internal_run_time): Don't assume time_t fits in int.
7601 (make_time): Use list2 instead of Fcons twice.
7602 (Fdecode_time): More accurate test for out-of-range times.
7603 (check_tm_member): New function.
7604 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7605 (lisp_time_argument): Don't rely on undefined left-shift and
7606 right-shift behavior when checking for time stamp overflow.
8be6f318 7607
fe31d94c
PE
7608 * editfns.c (time_overflow): New function, refactoring common code.
7609 (Fformat_time_string, Fdecode_time, Fencode_time):
7610 (Fcurrent_time_string): Use it.
7611
8be6f318
PE
7612 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7613 * dired.c (make_time): Move to ...
7614 * editfns.c (make_time): ... here.
7615 * systime.h: Note the move.
7616
09d9db2c 76172011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7618
126bc0dc
YM
7619 * fringe.c (update_window_fringes): Remove unused variables.
7620
c47cbdfd
YM
7621 * unexmacosx.c (copy_data_segment): Also copy __got section.
7622 (Bug#8223)
7623
7ac80be9
EZ
76242011-03-12 Eli Zaretskii <eliz@gnu.org>
7625
c96bbc66 7626 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7627 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7628 Constify `char *' arguments and their references according to
7629 prototypes in tparam.h.
7630
ecb0f94d 7631 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7632
7ac80be9
EZ
7633 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7634 Adapt all references accordingly.
7635
7636 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7637
ef1fd07e
TT
76382011-03-11 Tom Tromey <tromey@redhat.com>
7639
7640 * buffer.c (syms_of_buffer): Remove obsolete comment.
7641
7ef4b50c
EZ
76422011-03-11 Eli Zaretskii <eliz@gnu.org>
7643
7644 * termhooks.h (encode_terminal_code): Declare prototype.
7645
7646 * msdos.c (encode_terminal_code): Don't declare prototype.
7647
7648 * term.c (encode_terminal_code): Now external again, used by
7649 w32console.c and msdos.c.
7650
44f230aa
SM
7651 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7652 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7653
4b1ec863 76542011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7655
1714f52b 7656 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7657
4b1ec863
PE
7658 * fringe.c (update_window_fringes): Mark locals as initialized
7659 (Bug#8227).
7660 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7661
524c7aa6
PE
7662 * alloc.c (mark_fringe_data): Move decl from here ...
7663 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7664 to check its interface.
7665 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7666
a5c0af81 7667 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7668 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7669 (fontset_font): Mark local as initialized.
a9a06e0b 7670 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7671
b4716021
PE
7672 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7673
811e9bac 7674 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7675 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7676 (x_own_selection, Fx_disown_selection_internal): Rename locals
7677 to avoid shadowing.
7678 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7679
7e3ab302
PE
7680 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7681 so that the caller can use some name other than gcpro1.
7682 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7683 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7684 (Fx_backspace_delete_keys_p):
7685 Use them to avoid shadowing, and rename vars to avoid shadowing.
7686 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7687 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7688 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7689 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7690 Remove unused locals.
7e3ab302
PE
7691 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7692 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7693 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7694 macros.
f78faa98 7695
e2b13473
PE
7696 * xterm.h (x_mouse_leave): New decl.
7697
77f23912
PE
7698 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7699 Remove unused functions.
cdf4ba58
PE
7700 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7701 (x_calc_absolute_position): Now static.
7411c686 7702 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7703 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7704 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7705 unless they are used.
38d0b34a
PE
7706 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7707 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7708 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7709 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7710 (x_error_catcher, x_connection_closed, x_error_handler):
7711 (x_error_quitter, xembed_send_message, x_iconify_frame):
7712 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7713 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7714 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7715
44f230aa
SM
7716 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7717 Rename or move locals to avoid shadowing.
6b463e58 7718 (tty_defined_color, merge_face_heights): Now static.
5967d051 7719 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7720 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7721 does not deduce is never used uninitialized.
73719eba
PE
7722 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7723 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7724
426994c3 7725 * terminal.c (store_terminal_param): Now static.
5489860b 7726
032f1620 7727 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7728 (set_frame_menubar): Remove unused local.
d4323972 7729 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7730 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7731 since they might point to immutable storage.
281585b0
PE
7732 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7733 since it's unused otherwise.
032f1620 7734
367c19e5 7735 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7736 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7737 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7738 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7739 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7740 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7741 does not deduce are never used uninitialized.
70739cbe 7742
07b48fa9
PE
7743 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7744
8868a238 7745 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7746 * window.c (window_loop, size_window):
7747 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7748
7e5cf297 7749 * window.c (display_buffer): Now static.
d6550a9f
PE
7750 (size_window): Mark variables that gcc -Wuninitialized
7751 does not deduce are never used uninitialized.
a586633d
PE
7752 * window.h (check_all_windows): New decl, to forestall
7753 gcc -Wmissing-prototypes diagnostic.
5b555da1 7754 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7755
f6095868
PE
7756 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7757 shadowing.
7758 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7759 Include <limits.h>.
7760 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7761 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7762 (load_charset_map): Mark variables that gcc -Wuninitialized
7763 does not deduce are never used uninitialized.
53df7c11 7764 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7765
f38b440c
PE
7766 * coding.c (coding_set_source, coding_set_destination):
7767 Use "else { /* comment */ }" rather than "else /* comment */;"
7768 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7769 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7770 a block, when the outer 'i' will do.
7771 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7772 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7773 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7774 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7775 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7776 Rename locals to avoid shadowing.
7777 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7778 * coding.c (emacs_mule_char, encode_invocation_designation):
7779 Now static, since they're not used elsewhere.
413bb2db 7780 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7781 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7782 (decode_coding_emacs_mule): Mark variables that gcc
7783 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7784 (detect_coding_iso_2022): Initialize a local variable that might
7785 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7786 this initialization is needed. (Bug#8211)
5f58e762
PE
7787 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7788 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7789 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7790 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7791 Remove unused macros.
f38b440c 7792
232b38b9 7793 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7794 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7795 * character.c (string_count_byte8): Likewise.
232b38b9 7796
fb90da1b
PE
7797 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7798 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7799
fb93dbc2
PE
7800 * chartab.c (copy_sub_char_table): Now static, since it's not used
7801 elsewhere.
5c156ace
PE
7802 (sub_char_table_ref_and_range, char_table_ref_and_range):
7803 Rename locals to avoid shadowing.
bbcd0949 7804 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7805
7d3b3862 7806 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7807 (BIDI_BOB): Remove unused macro.
7d3b3862 7808
6be7d3da
PE
7809 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7810 deduce are never used uninitialized.
c2ed9c8b 7811 * term.c (encode_terminal_code): Likewise.
6be7d3da 7812
75f8807f 7813 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7814
50938595
PE
7815 * tparam.h: New file.
7816 * term.c, tparam.h: Include it.
7817 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7818 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7819 Move these decls to tparam.h, and make them agree with what
7820 is actually in tparam.c. The previous trick of using incompatible
7821 decls in different modules does not conform to the C standard.
7822 All callers of tparam changed to use tparam's actual API.
7823 * tparam.c (tparam1, tparam, tgoto):
7824 Use const pointers where appropriate.
7825
fbceeba2
PE
7826 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7827 * cm.h (struct cm): Likewise.
7828 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7829 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7830 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7831 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7832 (turn_on_face, init_tty): Likewise.
7833 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7834
7f3f1250
PE
7835 * term.c (term_mouse_position): Rename local to avoid shadowing.
7836
e6ca6543
PE
7837 * alloc.c (mark_ttys): Move decl from here ...
7838 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7839
c40f8d15
AS
78402011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7841
7842 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7843
cfe0661d
JB
78442011-03-09 Juanma Barranquero <lekktu@gmail.com>
7845
7846 * search.c (compile_pattern_1): Remove argument regp, unused since
7847 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7848 (compile_pattern): Don't pass it.
7849
0afb4571
J
78502011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7851
7852 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7853 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7854 for ! HAVE_GTK3.
7855 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7856
7857 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7858
7859 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7860 gdk_window_get_screen, gdk_window_get_geometry,
7861 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7862 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7863 (xg_get_pixbuf_from_pixmap): New function.
7864 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7865 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7866 Call xg_get_pixbuf_from_pixmap instead of
7867 gdk_pixbuf_get_from_drawable.
7868 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7869 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7870 (xg_check_special_colors): Use GtkStyleContext and its functions
7871 for HAVE_GTK3.
7872 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7873 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7874 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7875 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7876 Call gtk_widget_get_preferred_size.
0afb4571
J
7877 (xg_frame_resized): gdk_window_get_geometry only takes 5
7878 parameters.
44f230aa
SM
7879 (xg_win_to_widget, xg_event_is_for_menubar):
7880 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7881 (xg_set_widget_bg): New function.
7882 (delete_cb): New function.
895009e1 7883 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7884 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7885 (xg_set_background_color): Call xg_set_widget_bg.
7886 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7887 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7888 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7889 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7890 if ! HAVE_GTK3.
7891 (update_frame_tool_bar): Call gtk_widget_hide.
7892 (xg_initialize): Use GDK_KEY_g.
7893
7894 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7895 if ! HAVE_GTK3
7896 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7897
7898 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7899 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7900 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7901
1c2cc4ef
JB
79022011-03-08 Juanma Barranquero <lekktu@gmail.com>
7903
7904 * w32xfns.c (select_palette): Check success of RealizePalette against
7905 GDI_ERROR, not zero.
7906
33383987 7907See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7908
7909;; Local Variables:
7910;; coding: utf-8
aac0c6e3
MR
7911;; End:
7912
33383987 7913 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7914
7915 This file is part of GNU Emacs.
7916
7917 GNU Emacs is free software: you can redistribute it and/or modify
7918 it under the terms of the GNU General Public License as published by
7919 the Free Software Foundation, either version 3 of the License, or
7920 (at your option) any later version.
7921
7922 GNU Emacs is distributed in the hope that it will be useful,
7923 but WITHOUT ANY WARRANTY; without even the implied warranty of
7924 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7925 GNU General Public License for more details.
7926
7927 You should have received a copy of the GNU General Public License
7928 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.