* lisp/man.el (Man-completion-table): Fix the lambda case.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
3360a3fc
AS
12011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2
3 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4 waiting for input. (Bug#10169)
5
73d6c093
EZ
62011-11-30 Eli Zaretskii <eliz@gnu.org>
7
8 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
9 verifies glyph row's hash code--we have just reallocated the
10 glyphs, so their contents can be complete garbage. (Bug#10164)
11
febe6bea
JB
122011-11-30 Juanma Barranquero <lekktu@gmail.com>
13
14 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
15
801a4313
EZ
162011-11-30 Eli Zaretskii <eliz@gnu.org>
17
18 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
19 attributes are tested _before_ calling verify_row_hash, to protect
20 against GCC re-ordering of the tests. (Bug#10164)
21
2b56b87e
JD
222011-11-29 Jan Djärv <jan.h.d@swipnet.se>
23
24 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
25
26 * xterm.c (handle_one_xevent): Only set async_visible and friends
27 if net_wm_state_hidden_seen is non-zero (Bug#10002)
28 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
29 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
30
dbf31225
PE
312011-11-28 Paul Eggert <eggert@cs.ucla.edu>
32
33 Remove GCPRO-related macros that exist only to avoid shadowing locals.
34 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
35 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
36 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
37 All uses changed to use GCPRO1 etc.
38 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
39 Revert to old implementation (i.e., before 2011-03-11).
40
1305621b
YM
412011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
42
43 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
44 of scroll runs so as to avoid assigning disabled bogus rows and
45 unnecessary graphics copy operations.
46
8c9afb46
EZ
472011-11-27 Eli Zaretskii <eliz@gnu.org>
48
49 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
50 (snprintf) [_MSC_VER]: Redirect to _snprintf.
51 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
52 (malloc, free, realloc, calloc): Redirect to e_* only when
53 compiling Emacs.
54
55 * lisp.h (GCTYPEBITS): Move before first use.
56 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
57 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
58 this macro definition.
59
60 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
61 _MSC_VER.
62
54e9e3bf
JD
632011-11-27 Jan Djärv <jan.h.d@swipnet.se>
64
65 * gtkutil.c (xg_create_frame_widgets): Call
66 gtk_window_set_has_resize_grip (FALSE) if that function is
67 present with Gtk+ 2.0.
68
83aca1cb
PE
692011-11-26 Paul Eggert <eggert@cs.ucla.edu>
70
71 * fileio.c (Finsert_file_contents): Undo previous change; see
72 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
73
5b76caa4
PE
742011-11-26 Paul Eggert <eggert@cs.ucla.edu>
75
76 Rename locals to avoid shadowing.
77 * fileio.c (Finsert_file_contents):
78 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
79 * process.c (wait_reading_process_output):
80 Rename inner 'proc' to 'p' to avoid shadowing.
81 Indent for consistency with usual Emacs style.
82
8c535114
EZ
832011-11-25 Eli Zaretskii <eliz@gnu.org>
84
85 * xdisp.c (redisplay_window): If cursor row is not fully visible
86 after recentering, and scroll-conservatively is set to a large
87 number, scroll window by a few more lines to make the cursor fully
88 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
89 (start_display): Don't move to the next line if the display should
90 start at a newline that is part of a display vector or an overlay
91 string. (Bug#10119)
8c535114 92
fa4fdb5c
JL
932011-11-24 Juri Linkov <juri@jurta.org>
94
95 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
96 after the `MagickPingImage' call. (Bug#10112)
97
90ec88df
CY
982011-11-23 Chong Yidong <cyd@gnu.org>
99
100 * window.c (Fcoordinates_in_window_p): Accept only live windows.
101
56e2e794
MR
1022011-11-23 Martin Rudalics <rudalics@gmx.at>
103
104 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
105 making another buffer current. (Bug#10114)
106
b6e64c41
GM
1072011-11-23 Glenn Morris <rgm@gnu.org>
108
109 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
110
6b21de18
CY
1112011-11-23 Chong Yidong <cyd@gnu.org>
112
113 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
114 using it (Bug#5984).
115
b12cd789
EZ
1162011-11-22 Eli Zaretskii <eliz@gnu.org>
117
118 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
119 and header-lines, as they don't have one computed for them.
120 (Bug#10098)
121
122 * .gdbinit (prow): Make displayed values more self-explaining.
123 Add row's hash code.
124
261b6fd4
LMI
1252011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
126
127 * process.c (wait_reading_process_output): Fix asynchrounous
128 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 129 (wait_reading_process_output): Add comment and URL.
261b6fd4 130
e7cfd277
JD
1312011-11-21 Jan Djärv <jan.h.d@swipnet.se>
132
133 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
134
a9b9b7f5
CY
1352011-11-21 Chong Yidong <cyd@gnu.org>
136
137 * window.c (Fnext_window, Fprevious_window): Doc fix.
138
b0d15b4f
SM
1392011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
140
141 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
142
fe7a3057
JB
1432011-11-20 Juanma Barranquero <lekktu@gmail.com>
144
145 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
146
d2999b1a
MR
1472011-11-20 Martin Rudalics <rudalics@gmx.at>
148
149 * window.c (Fset_window_combination_limit): Rename argument
150 STATUS to LIMIT.
151 (Vwindow_combination_limit): Remove "status" from doc-string.
152
d5ff9cd0
AS
1532011-11-20 Andreas Schwab <schwab@linux-m68k.org>
154
155 * m/ibms390.h: Remove.
156 * m/ibms390x.h: Don't include "ibms390.h".
157
a5bb9bd3
SM
1582011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
159
160 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
161 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
162
cd1181db
JB
1632011-11-20 Juanma Barranquero <lekktu@gmail.com>
164
165 * casetab.c (Fset_case_table):
166 * charset.c (Fcharset_after): Fix typos.
167
615a3b8d 1682011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 169
17e845af
PE
170 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
171 Otherwise, valgrind does not work on some platforms.
172 Problem reported by Andreas Schwab in
6a0bf43d
PE
173 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
174 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
175 is set, removing the need for VIRT_ADDRESS_VARIES.
176 (PURE_P): Use a more-efficient implementation that needs just one
177 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
178 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
179 to 4 (xorl, subq, cmpq, setbe).
180 * alloc.c (pure): Always extern now, since that's the
181 VIRT_ADDR_VARIES behavior.
182 (PURE_POINTER_P): Use a single comparison, not two, for
183 consistency with the new puresize.h.
184 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
185 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
186 Remove VIRT_ADDR_VARIES no longer needed.
187
f8fe6f96
EZ
1882011-11-19 Eli Zaretskii <eliz@gnu.org>
189
190 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
191 (erase_phys_cursor, update_window_cursor, show_mouse_face)
192 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
193 behave as if the cursor position were at the window margin.
194
195 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
196 and the cursor position is out of bounds, behave as if the cursor
197 position were at the window margin. (Bug#10075)
198
df05a53c
CY
1992011-11-18 Chong Yidong <cyd@gnu.org>
200
201 * window.c (Fwindow_combination_limit): Make first argument
202 non-optional, since it is meaningless for live windows like the
203 selected window.
204
2071918e
DA
2052011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
206
207 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
208
b50a28de
SM
2092011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
210
211 * intervals.c: Fix grafting over the whole buffer (bug#10071).
212 (graft_intervals_into_buffer): Simplify.
213
015137db
EZ
2142011-11-18 Eli Zaretskii <eliz@gnu.org>
215
216 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
217 hash values of the two rows.
218 (copy_row_except_pointers): Preserve the used[] arrays and the
219 hash values of the two rows. (Bug#10035)
68c95424 220 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
221
222 * xdisp.c (row_hash): New function, body extracted from
223 compute_line_metrics.
224 (compute_line_metrics): Call row_hash, instead of computing the
225 hash code inline.
226
227 * dispnew.c (verify_row_hash): Call row_hash for computing the
228 hash code of a row, instead of duplicating code from xdisp.c.
229
230 * dispextern.h (row_hash): Add prototype.
231
a2addb04
TH
2322011-11-18 Tassilo Horn <tassilo@member.fsf.org>
233
234 * frame.c (delete_frame): Don't delete the terminal when the last
235 X frame is closed if emacs is built with GTK toolkit.
236
df85d315
JB
2372011-11-17 Juanma Barranquero <lekktu@gmail.com>
238
239 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
240
a0c2d0ae
MR
2412011-11-17 Martin Rudalics <rudalics@gmx.at>
242
243 * window.c (Vwindow_splits): Rename to
244 Vwindow_combination_resize. Suggested by Juri Linkov.
245 (Fsplit_window_internal): Use Vwindow_combination_resize instead
246 of Vwindow_splits.
247
58179cce
JB
2482011-11-16 Juanma Barranquero <lekktu@gmail.com>
249
7877f373
JB
250 * nsfns.m (Fns_font_name):
251 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 252
b6f67890
MR
2532011-11-16 Martin Rudalics <rudalics@gmx.at>
254
255 * window.h (window): Rename slot "nest" to "combination_limit".
256 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
257 (Fset_window_nest): Rename to Fset_window_combination_limit.
258 (Vwindow_nest): Rename to Vwindow_combination_limit.
259 (recombine_windows, make_parent_window, make_window)
260 (Fsplit_window_internal, saved_window)
261 (Fset_window_configuration, save_window_save): Rename all
262 occurrences of window_nest to window_combination_limit.
263
c7015153
JB
2642011-11-15 Juanma Barranquero <lekktu@gmail.com>
265
266 * image.c (imagemagick_load_image): Fix typo.
267
322ad6ec
EZ
2682011-11-14 Eli Zaretskii <eliz@gnu.org>
269
270 * xdisp.c (display_line): Move the call to
271 highlight_trailing_whitespace before the call to
272 compute_line_metrics, since the latter needs to see the final
273 faces of all the glyphs to compute ROW's hash value. Fixes
274 assertion violations in row_equal_p. (Bug#10035)
275
f067b8ec
JB
2762011-11-14 Juanma Barranquero <lekktu@gmail.com>
277
278 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
279 just return (bug#10044).
280
1e5b2111
EZ
2812011-11-12 Eli Zaretskii <eliz@gnu.org>
282
7ef3cbd5
EZ
283 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
284 with user-defined heap size. Bump the default size of the temacs
285 heap to 27MB, to avoid memory warning when running temacs.
286 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
287
1e5b2111
EZ
288 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
289 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
290 (verify_row_hash) [XASSERTS]: New function.
291 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
292 that the hash value of glyph rows is correct.
1e5b2111 293
89d61221
MR
2942011-11-12 Martin Rudalics <rudalics@gmx.at>
295
296 * window.h (window): Remove splits slot.
297 * window.c (Fwindow_splits, Fset_window_splits): Remove.
298 (Fdelete_other_windows_internal, make_parent_window)
299 (make_window, Fsplit_window_internal, Fdelete_window_internal)
300 (Fset_window_configuration, save_window_save): Don't deal with
301 split status of windows.
302 (saved_window): Remove splits slot.
303 (Vwindow_splits): Rewrite doc-string.
304
97f18cc8
JD
3052011-11-11 Jan Djärv <jan.h.d@swipnet.se>
306
307 * xfns.c (unwind_create_frame):
308 * nsfns.m (unwind_create_frame):
309 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
310 Vframe_list (Bug#9999).
311
22a648b4
DA
3122011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
313
0b381c7e 314 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 315
659afede
KH
3162011-11-11 Kenichi Handa <handa@m17n.org>
317
318 * callproc.c (Fcall_process): Set the member dst_multibyte of
319 process_coding.
320
9ac0394b
KH
3212011-11-11 Johan Bockgård <bojohan@gnu.org>
322
323 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
324 avoid a crash (bug#9496).
325
2fbdc249
CY
3262011-11-09 Chong Yidong <cyd@gnu.org>
327
328 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
329 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
330
ac6b1f81
PE
3312011-11-08 Paul Eggert <eggert@cs.ucla.edu>
332
333 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
334
09db192c
PE
3352011-11-08 Paul Eggert <eggert@cs.ucla.edu>
336
337 Avoid some portability problems by eschewing 'extern inline' functions.
338 The trivial performance wins aren't worth the portability hassles; see
339 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
340 et seq.
341 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
342 (window_box_width, window_box_left, window_box_left_offset)
343 (window_box_right, window_box_right_offset): Undo previous change,
344 by removing the "extern"s.
345 * intervals.c (adjust_intervals_for_insertion)
346 (adjust_intervals_for_deletion): Undo previous change,
347 making these static again.
348 (offset_intervals, temp_set_point_both, temp_set_point)
349 (copy_intervals_to_string): No longer inline.
350 * xdisp.c (window_text_bottom_y, window_box_width)
351 (window_box_height, window_box_left_offset)
352 (window_box_right_offset, window_box_left, window_box_right)
353 (window_box): No longer inline.
354
105216ed
CY
3552011-11-08 Chong Yidong <cyd@gnu.org>
356
357 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
358 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
359 an error if not a live window.
360 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
361 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
362
ae9e237f
JB
3632011-11-07 Juanma Barranquero <lekktu@gmail.com>
364
365 * lisp.h (syms_of_abbrev): Remove declaration.
366 Reported by CHENG Gao <chenggao@royau.me>.
367
c7aa8333
EZ
3682011-11-07 Eli Zaretskii <eliz@gnu.org>
369
370 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
371 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
372 of temacs in GUI mode.
373
be7f5545
MR
3742011-11-07 Martin Rudalics <rudalics@gmx.at>
375
376 * window.h: Declare delete_all_child_windows instead of
377 delete_all_subwindows.
378 * window.c (Fwindow_nest, Fset_window_nest)
379 (Fset_window_new_total, Fset_window_new_normal)
380 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
381 (delete_all_subwindows): Rename to delete_all_child_windows.
382 (Fdelete_other_windows_internal, Fset_window_configuration):
383 Call delete_all_child_windows instead of delete_all_subwindows.
384 * frame.c (delete_frame): Call delete_all_child_windows instead
385 of delete_all_subwindows.
386
ca78dc43
PE
3872011-11-07 Paul Eggert <eggert@cs.ucla.edu>
388
389 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
390 This is also needed for porting to any host where GC_MARK_STACK is
391 not GC_MAKE_GCPROS_NOOPS.
392 (which_symbols): Use it.
393
a0241d01
KH
3942011-11-07 Kenichi Handa <handa@m17n.org>
395
396 * coding.c (coding_set_destination): Check coding->src_pos only
397 when coding->src_object is a buffer (bug#9910).
398
399 * process.c (send_process): Set the member src_multibyte of coding
400 to 0 (bug#9911) when sending a unibyte text.
401
402 * callproc.c (Fcall_process): Set the member src_multibyte of
403 process_coding to 0 (bug#9912).
404
a64bfdfa 4052011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
406
407 * xmenu.c (cleanup_widget_value_tree): New function.
408 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
409 calling free_menubar_widget_value_tree directly (Bug#9830).
410
cb41b32a
PE
4112011-11-06 Paul Eggert <eggert@cs.ucla.edu>
412
413 Fix some portability problems with 'inline'.
414 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
415 (window_box_width, window_box_left, window_box_left_offset)
416 (window_box_right, window_box_right_offset): Declare extern.
417 Otherwise, these inline functions do not conform to C99 and
418 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
419 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
420 * intervals.c (adjust_intervals_for_insertion)
421 (adjust_intervals_for_deletion): Now extern, because otherwise the
422 extern inline functions 'offset_intervals' couldn't refer to it.
423 (static_offset_intervals): Remove.
424 (offset_intervals): Rewrite using the old contents of
425 static_offset_intervals. The old version didn't conform to C99
426 because an extern inline function contained a reference to an
427 identifier with static linkage.
428
b7041366
AS
4292011-11-06 Andreas Schwab <schwab@linux-m68k.org>
430
431 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
432 GC.
433
88a37c4d
EZ
4342011-11-06 Eli Zaretskii <eliz@gnu.org>
435
436 * xdisp.c (init_iterator, reseat_to_string): Don't set the
437 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
438 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
439 return Qleft_to_right.
440
49745b39
CY
4412011-11-06 Chong Yidong <cyd@gnu.org>
442
443 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
444 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
445 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
446 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
447 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
448 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
449 (Fwindow_vscroll): Doc fix.
450 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
451 argument, since it makes no sense to pass a live window and for
452 consistency with window-child.
453
1f05cd82
CS
4542011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
455
456 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
457 support MSVC.
458
22610910
JR
4592011-11-05 Jason Rumney <jasonr@gnu.org>
460
461 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
462 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
463 fonts (Bug#6029).
464 (add_font_entity_to_list): Fix logic errors in mixed boolean and
465 bitwise arithmetic preventing use of unicode-sip and non-truetype
466 opentype fonts.
467
a06776b2
EZ
4682011-11-05 Eli Zaretskii <eliz@gnu.org>
469
3ad924ba
EZ
470 * s/ms-w32.h (fstat, stat, utime): Move redirections to
471 "emacs"-only part.
472
a06776b2
EZ
473 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
474 initialization code to keep similarity to xfns.c after changes
475 from 2011-11-05.
476
c9e7db78
JD
4772011-11-05 Jan Djärv <jan.h.d@swipnet.se>
478
a97f8f3f
JD
479 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
480 (unwind_create_frame): New function (Bug#9943).
481 (Fx_create_frame): Restructure code to be more similar to the one in
482 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
483 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
484 Move terminal->reference_count++ just before making the frame official
485 (Bug#9943).
486
487 * nsterm.m (x_free_frame_resources): New function.
488 (x_destroy_window): Move code to x_free_frame_resources.
489
c9e7db78
JD
490 * xfns.c (unwind_create_frame): Fix comment.
491 (Fx_create_frame, x_create_tip_frame): Move
492 terminal->reference_count++ just before making the frame
493 official. Move initialization of image_cache_refcount and
494 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
495
a6fc3b5c
EZ
4962011-11-05 Eli Zaretskii <eliz@gnu.org>
497
498 Support MSVC build with newer versions of Visual Studio.
499 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
500 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
501 nt/gmake.defs.
502
503 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
504 which are not supported by MSVC.
505 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
506 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
507 bitfields.
508 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
509 types in bitfields.
510 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
511
512 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
513
58179cce 5142011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
515
516 Support MSVC build with newer versions of Visual Studio.
517 * w32.c: Don't include w32api.h for MSVC.
518 (init_environment) [_MSC_VER]: Call sys_access, not _access.
519
520 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
521 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
522 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
523 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
524 e_* cousins.
525 (alloca) [_MSC_VER]: Define to _alloca.
526
527 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
528
529 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
530
a58c13ed
EZ
5312011-11-04 Eli Zaretskii <eliz@gnu.org>
532
533 * xdisp.c (note_mouse_highlight): If either of
534 previous/next-single-property-change returns nil, treat that as
535 the beginning or the end of the buffer. (Bug#9955)
536
fe0b6370
JD
5372011-11-04 Jan Djärv <jan.h.d@swipnet.se>
538
a58c13ed 539 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
540 label is not null (Bug#9951).
541 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
542 may be NULL.
543
89bd5ee1
EZ
5442011-11-04 Eli Zaretskii <eliz@gnu.org>
545
546 * window.c (Fwindow_body_size): Mention in the doc string that the
547 return value is in frame's canonical units. (Bug#9949)
548
84c3edb9
EZ
5492011-11-03 Eli Zaretskii <eliz@gnu.org>
550
4e2fb5c7
EZ
551 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
552
84c3edb9 553 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 554 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 555 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 556
bc17a887
EZ
5572011-11-01 Eli Zaretskii <eliz@gnu.org>
558
559 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
560 Don't stop backward scan on the continuation glyph, even though
561 its CHARPOS is positive.
26b46e51
EZ
562 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
563 cover_string to disp_string.
bc17a887 564
4ee88440
MR
5652011-11-01 Martin Rudalics <rudalics@gmx.at>
566
567 * window.c (temp_output_buffer_show): Don't use
568 Vtemp_buffer_show_specifiers.
569 (Vtemp_buffer_show_specifiers): Remove unused variable.
570
c2ff3c02
EZ
5712011-10-30 Eli Zaretskii <eliz@gnu.org>
572
573 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
574 past the beginning of the current glyph matrix.
575
58179cce 5762011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
577
578 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
579 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
580 HAVE_GTK3 (Bug#9869).
b77a6a7f 581
3b574623
JD
582 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
583 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
584
b77a6a7f
JD
585 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
586
587 * xterm.c: Declare x_handle_net_wm_state to return int.
588 (handle_one_xevent): Check if we are iconified but don't have
589 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
590 (get_current_wm_state): Return non-zero if not hidden,
591 check for _NET_WM_STATE_HIDDEN (Bug#9893).
592 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
593 (x_handle_net_wm_state): Return what get_current_wm_state returns.
594 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
595
196e41e4
PE
5962011-10-29 Paul Eggert <eggert@cs.ucla.edu>
597
598 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
599 so that this new function doesn't get optimized away by a
600 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
601
021f2e1a
AS
6022011-10-29 Andreas Schwab <schwab@linux-m68k.org>
603
604 * frame.h (MOUSE_HL_INFO): Remove excess parens.
605
8b058d44
EZ
6062011-10-29 Eli Zaretskii <eliz@gnu.org>
607
608 Fix the `xbytecode' command.
609 * .gdbinit (xprintbytestr): New command.
b50a28de 610 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
611 (xbytecode): Print the byte-code string as well.
612
4452fb80
EZ
6132011-10-29 Kim Storm <storm@cua.dk>
614
8b058d44
EZ
615 * alloc.c (which_symbols): New function.
616
21b72067
AS
6172011-10-29 Andreas Schwab <schwab@linux-m68k.org>
618
619 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
620 line. (Bug#9903)
621
83ed7b5c
GM
6222011-10-29 Glenn Morris <rgm@gnu.org>
623
624 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
625 Not clear what it was for, and it causes various bugs. (Bug#9839)
626
5a7a728b
EZ
6272011-10-28 Eli Zaretskii <eliz@gnu.org>
628
629 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
630 possible random value that matches one of those tested as
631 condition to clear the mouse face.
632
d3d0842f
CY
6332011-10-28 Chong Yidong <cyd@gnu.org>
634
635 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
636
31b39d13
DN
6372011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
638
639 * window.c (make_window): Initialize phys_cursor_on_p.
640
9aba6043
SM
6412011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
642
643 * lisp.h (struct Lisp_Symbol): Update comments.
644
c20992f4
JB
6452011-10-28 Juanma Barranquero <lekktu@gmail.com>
646
647 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
648
db4f02f2
EZ
6492011-10-28 Eli Zaretskii <eliz@gnu.org>
650
651 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
652 <oslsachem@gmail.com> for helping to debug this.
653
654 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
655 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
656 (g_b_init_get_glyph_outline_w): New static variables.
657 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
658 (GetGlyphOutlineW_Proc): New typedefs.
659 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
660 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
661 New functions.
662 (w32font_open_internal, compute_metrics):
663 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
664 instead of calling the "wide" APIs directly.
665
666 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
667
668 * w32.h (syms_of_w32font): Add prototype.
669
87e68db4
JB
6702011-10-27 Juanma Barranquero <lekktu@gmail.com>
671
672 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
673 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
674 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
675 (Fmove_to_window_line): Doc fix.
676
435c1d67
CY
6772011-10-27 Chong Yidong <cyd@gnu.org>
678
679 * process.c (make_process): Set gnutls_state to NULL.
680
681 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
682 non-NULL, regardless of GNUTLS_INITSTAGE.
683 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
684 an error. Set process slots as soon as we allocate them.
685
686 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
687
9c6c6f49
CY
6882011-10-27 Chong Yidong <cyd@gnu.org>
689
9aba6043
SM
690 * gnutls.c (emacs_gnutls_deinit): New function.
691 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
692 (Fgnutls_deinit, Fgnutls_boot): Use it.
693
694 * process.c (make_process): Initialize GnuTLS credentials to NULL.
695 (deactivate_process): Call emacs_gnutls_deinit.
696
657d08d3
JB
6972011-10-27 Juanma Barranquero <lekktu@gmail.com>
698
699 * image.c (x_create_x_image_and_pixmap):
700 * w32.c (sys_rename, w32_delayed_load):
701 * w32font.c (fill_in_logfont):
702 * w32reg.c (x_get_string_resource): Silence compiler warnings.
703
5430d399
JB
7042011-10-26 Juanma Barranquero <lekktu@gmail.com>
705
706 * w32fns.c (w32_default_color_map): New function,
707 extracted from Fw32_default_color_map.
a7ef684b 708 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 709
fe0055fa
PE
7102011-10-25 Paul Eggert <eggert@cs.ucla.edu>
711
712 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
713
e6346438
SM
7142011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
715
716 * keyboard.c (test_undefined): New function (bug#9751).
717 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
718
e112cc37
ET
7192011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
720
721 * sysdep.c (init_sys_modes): Fix the check for the controlling
722 terminal (Bug#6649).
723
7b5d6677
EZ
7242011-10-20 Eli Zaretskii <eliz@gnu.org>
725
726 * dispextern.h (struct bidi_it): New member next_en_type.
727
728 * bidi.c (bidi_line_init): Initialize the next_en_type member.
729 (bidi_resolve_explicit_1): When next_en_pos is valid for the
730 current character, check also for next_en_type being WEAK_EN.
731 (bidi_resolve_weak): Don't enter the expensive loop if the current
732 position is before next_en_pos. Record the bidi type of the first
733 non-ET, non-BN character we find, in addition to its position.
734 (bidi_level_of_next_char): Invalidate next_en_type when
735 next_en_pos is over-stepped.
736
7da0b018
PE
7372011-10-20 Paul Eggert <eggert@cs.ucla.edu>
738
739 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
740 * editfns.c: Rewrite current-time-zone so that it invokes
741 the equivalent of (format-time-string "%Z") to get the time zone name.
742 This fixes a bug when the time zone name contains characters that
743 need converting from the system time locale to Emacs internal format.
744 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
745 that patch fixed format-time-string to do the conversion, but
746 I forgot to fix current-time-zone.
747 (format_time_string): New function, containing most of
748 what Fformat_time_string used to contain.
749 (Fformat_time_string): Rewrite in terms of format_time_string.
750 This doesn't change this function's behavior.
751 (current-time-zone): Rewrite to use format_time_string.
752 This fixes the bug reported by Michael Schierl in
753 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
754 Jason Rumney's 2007-06-07 change worked around this bug, but
755 didn't fix it.
756 * systime.h (tzname, timezone): Remove no-longer-used declarations.
757
8547b010
EZ
7582011-10-19 Eli Zaretskii <eliz@gnu.org>
759
760 * xdisp.c (start_display): If the character at POS is displayed
761 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
762 (try_window_reusing_current_matrix): If a line ends in a display
763 vector or the next line starts in a display vector, continue
764 redrawing the window even though the character position of
765 start_row was reached.
8547b010
EZ
766 (Bug#9771, part 2)
767
4e948d15
CY
7682011-10-18 Chong Yidong <cyd@gnu.org>
769
770 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
771 with nobreak-char-display too.
772
4787455f
EZ
7732011-10-18 Eli Zaretskii <eliz@gnu.org>
774
775 Fix part 3 of bug#9771.
776 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
777 (bidi_resolve_neutral): Don't enter the expensive loop looking for
778 non-neutral characters if the current character is a paragraph
779 separator (a.k.a. Newline). This avoids running the same
780 expensive loop twice, once when we consume the preceding newline
781 and the other time when the line actually needs to be displayed.
782 Avoid the loop when we see neutrals on the base embedding level
783 following a character whose directionality is the same as the
784 paragraph's. This avoids running the expensive loop when a line
785 ends in a long sequence of neutrals, like control characters.
786 Add assertion against STRONG_AL type. Slightly rearrange code
787 that determines the type of a neutral given the first non-neutral
788 that follows it.
789 (bidi_level_of_next_char): Set next_en_pos to zero when
790 invalidating its info.
791
2c91f553
EZ
7922011-10-17 Eli Zaretskii <eliz@gnu.org>
793
794 * xdisp.c (push_display_prop): Determine whether to record string
795 or buffer position by IT->string, not by IT->method. Allow
796 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
797 (move_it_vertically_backward): Don't look for character position
798 immediately after the newline when in a continuation line.
799 (Bug#9771, part 1)
2c91f553 800
c7b08b0d
MR
8012011-10-15 Martin Rudalics <rudalics@gmx.at>
802
803 * window.c (coordinates_in_window): Rewrite and delabelize
804 vertical border check. (Bug#5357) (Bug#9618)
805
6b02f655
SM
8062011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
807
808 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
809 errors in XSetWindowBorder (bug#9310).
810
81d40c92
DA
8112011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
812
813 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
814 avoid crash when xmalloc overrun checking is enabled.
815
d4172c3b
EZ
8162011-10-13 Eli Zaretskii <eliz@gnu.org>
817
818 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
819 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
820 cursor motion with <left> and <right> arrow keys.
821
822 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
823 some callers set that themselves.
824
b00eea75
EZ
8252011-10-12 Eli Zaretskii <eliz@gnu.org>
826
827 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
828 display string and the previous row comes from the same string and
829 is empty. (Bug#9739) (Bug#9738)
830
8fe012c4
SM
8312011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
832
833 * doc.c (get_doc_string): Encode file name (bug#9735).
834
0074aef2
EZ
8352011-10-12 Eli Zaretskii <eliz@gnu.org>
836
79beb178
EZ
837 * bidi.c (bidi_level_of_next_char):
838 * xdisp.c (get_visually_first_element): Remove old incorrect
839 comments regarding the Unicode Line Separator character.
840
0074aef2
EZ
841 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
842
6e4b3fbe
DA
8432011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
844
845 * alloc.c (Fgc_status): Do not access beyond zombies array
846 boundary if nzombies > MAX_ZOMBIES.
847 * alloc.c (dump_zombies): Add missing format specifier.
848
0324f3af
PE
8492011-10-12 Paul Eggert <eggert@cs.ucla.edu>
850
b5525cac
PE
851 * xdisp.c (set_cursor_from_row): Simplify conditionals,
852 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
853
0324f3af
PE
854 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
855 Some packages use them to denote characters with modifiers.
856
e9b5f888
AS
8572011-10-11 Andreas Schwab <schwab@linux-m68k.org>
858
859 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
860 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
861 matching a pp-number. Rename parameter var to var1.
862
127827c0
SM
8632011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
864
865 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
866
c8fd3bd0
GM
8672011-10-08 Glenn Morris <rgm@gnu.org>
868
869 * callint.c (Fcall_interactively): Give a more explicit error for the
870 'c' case with a non-character input. (Bug#8479)
871
352ec8ff
EZ
8722011-10-08 Eli Zaretskii <eliz@gnu.org>
873
03669ccb
EZ
874 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
875 lines.
7061c986
EZ
876 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
877 lines that are hscrolled on the left.
03669ccb 878
352ec8ff
EZ
879 * dispnew.c (buffer_posn_from_coords): Account for a possible
880 presence of header-line. (Bug#4426)
881
a66cfb1c
SM
8822011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
883
6b02f655
SM
884 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
885 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 886
7c5ee88e
PE
8872011-10-07 Paul Eggert <eggert@cs.ucla.edu>
888
889 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
890 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
891 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
892 this makes Emacs dump core during garbage collection on rare
893 occasions. sizeof is obviously inferior to offsetof here, so
894 stick with offsetof.
895 (GC_POINTER_ALIGNMENT): New macro.
896 (mark_memory): Omit 3rd (offset) arg; caller changed.
897 Don't assume EMACS_INT alignment is the same as pointer alignment.
898
df1bbe5b
SM
8992011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
900
901 * keyboard.c (read_key_sequence_remapped): New var.
902 (read_key_sequence): Compute remapping in the right buffer.
903 (command_loop_1): Use read_key_sequence's remapping directly.
904
51553db6
SM
9052011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
906
32c1fffd
SM
907 * dired.c (file_name_completion): Don't expand file name.
908 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
909 before checking file name handler.
910
51553db6
SM
911 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
912 they've been requested explicitly (bug#9591).
913
b6bd1599 9142011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
915
916 * keymap.c (Fsingle_key_description): Use make_specified_string
917 instead of build_string to build string from push_key_description.
918 (Bug#5193)
919
f701dc2a
PE
9202011-09-30 Paul Eggert <eggert@cs.ucla.edu>
921
4222c55d
PE
922 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
923 This fixes a Y2038 bug on 64-bit hosts.
924 * buffer.c (reset_buffer):
925 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
926 (Fclear_buffer_auto_save_failure):
927 Use 0, not -1, to represent an unset failure time, since time_t
928 might not be signed.
929
f701dc2a
PE
930 Remove dependency on glibc malloc internals.
931 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
932 Move back here from lisp.h, but with their new implementations.
933 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
934 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
935 * charset.c (charset_table_init): New static var.
936 (syms_of_charset): Use it instead of xmalloc. This removes a
937 dependency on glibc malloc internals. See Eli Zaretskii's comment in
938 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
939 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
940 Move back to alloc.c.
941 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
942 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
943
9ceebf39
JD
9442011-09-30 Jan Djärv <jan.h.d@swipnet.se>
945
946 * nsterm.m (windowDidResize): Call x_set_window_size only when
947 ns_in_resize is true. Otherwise set pixelwidth/height and
948 call change_frame_size (Bug#9628).
949
cb993c58
PE
9502011-09-30 Paul Eggert <eggert@cs.ucla.edu>
951
3930c88b
PE
952 Port --enable-checking=all to Fedora 14 x86-64.
953 * charset.c (syms_of_charset): Also account for glibc malloc's
954 internal overhead when calculating the initial malloc maximum.
955
cb993c58
PE
956 Port --enable-checking=all to Fedora 14 x86.
957 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
958 Move to lisp.h.
959 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
960 (overrun_check_realloc, overrun_check_free):
961 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
962 That way, xmalloc returns a properly-aligned pointer even if
963 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
964 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
965 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
966 into account when calculating the initial malloc maximum.
967 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
968 Move here from alloc.c, so that charset.c can use it too.
969 Properly align; the old code wasn't right for common 32-bit hosts
970 when configured with --enable-checking=all.
971 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
972 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
973
31bed486
EZ
9742011-09-29 Eli Zaretskii <eliz@gnu.org>
975
04c70788 976 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
977 use EDOM.
978
fbcaa2f3
EZ
9792011-09-28 Eli Zaretskii <eliz@gnu.org>
980
981 * xdisp.c (compute_display_string_end): If there's no display
982 string at CHARPOS, return -1.
983
984 * bidi.c (bidi_fetch_char): When compute_display_string_end
985 returns a negative value, treat the character as a normal
986 character not covered by a display string. (Bug#9624)
987
a239d4e9
JB
9882011-09-28 Juanma Barranquero <lekktu@gmail.com>
989
990 * lread.c (Fread_from_string): Fix typo in docstring.
991
88652fd5
EZ
9922011-09-27 Eli Zaretskii <eliz@gnu.org>
993
994 * xdisp.c (handle_invisible_prop): If invisible text ends on a
995 newline, reseat the iterator instead of bidi-iterating there one
996 character at a time. (Bug#9610)
32c1fffd
SM
997 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
998 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 999
ed497dd4
AS
10002011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1001
1002 * lread.c (readevalloop): Use correct code for NBSP.
1003 (read1): Likewise. (Bug#9608)
1004
b2bf61aa
MA
10052011-09-25 Michael Albinus <michael.albinus@gmx.de>
1006
1007 * dbusbind.c (Fdbus_register_signal): When service is not
1008 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1009
32bbb17c
GM
10102011-09-25 Glenn Morris <rgm@gnu.org>
1011
1012 * buffer.c (truncate-lines): Doc fix.
1013
94e0933e
CY
10142011-09-24 Chong Yidong <cyd@stupidchicken.com>
1015
1016 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1017 (Fset_window_next_buffers): Doc fix.
1018
cddde921
GM
10192011-09-24 Glenn Morris <rgm@gnu.org>
1020
1021 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1022
1260aef1
PE
10232011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1024
25b4bfa0
PE
1025 Fix minor problems found by static checking.
1026 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1027 * indent.c (Fvertical_motion): Fix == vs = typo.
1028
e3cbd34b
EZ
10292011-09-24 Eli Zaretskii <eliz@gnu.org>
1030
a66cfb1c
SM
1031 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1032 Default value is now t. Doc fix.
6bf7006f 1033
e3cbd34b 1034 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1035 logic when moving up, not only when moving down. Fix the
e3cbd34b 1036 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1037 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1038
1039 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1040 CHARPOS is covered by a display string which includes newlines.
1041 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1042 is covered by a display string with embedded newlines.
1043
a3de0cbd
MA
10442011-09-24 Michael Albinus <michael.albinus@gmx.de>
1045
1046 * dbusbind.c (Fdbus_register_signal): Add match rule to
1047 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1048 (Fdbus_register_method, Vdbus_registered_objects_table):
1049 Fix docstring.
a3de0cbd 1050
b260039d
JM
10512011-09-24 Jim Meyering <meyering@redhat.com>
1052
32c1fffd 1053 do not ignore write error for any output size
b260039d
JM
1054 The previous change was incomplete.
1055 While it makes emacs --batch detect the vast majority of stdout
1056 write failures, errors were still ignored whenever the output size is
1057 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1058 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1059 && echo FAIL: ignored write error
1060 FAIL: ignored write error
1061 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1062 && echo FAIL: ignored write error
1063 FAIL: ignored write error
1064 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1065
8eca8a7c
AS
10662011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1067
1068 * emacs.c (Fkill_emacs): In noninteractive mode exit
1069 non-successfully if a write error occurred on stdout. (Bug#9574)
1070
3341db62
EZ
10712011-09-21 Eli Zaretskii <eliz@gnu.org>
1072
1073 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1074 the xassert test.
1075
1076 * dispextern.h (struct it): Update the comment documenting what
1077 can it->OBJECT be.
1078
8c203dbf
EZ
10792011-09-20 Eli Zaretskii <eliz@gnu.org>
1080
1081 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1082 a display string, extend search for cursor position to end of row.
1083 (find_row_edges): If the row ends in a newline from a display
1084 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1085 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1086 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1087 non-empty line. Fixes confusing cursor motion with arrow keys at
1088 the beginning of a line that starts with whitespace.
8c203dbf 1089
a4824228
LMI
10902011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1091
1092 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1093 (bug#9493).
1094
33ed493b
CY
10952011-09-18 Chong Yidong <cyd@stupidchicken.com>
1096
1097 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1098 boolean (Bug#9154).
1099
56cd55c8
EZ
11002011-09-18 Eli Zaretskii <eliz@gnu.org>
1101
1102 * xdisp.c (display_line): Record maximum and minimum buffer
1103 positions even if no glyphs were produced (e.g., by a zero-width
1104 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1105 buffer positions that will be removed from the glyph row because
1106 they don't fit.
c02dcedf
EZ
1107 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1108 column is beyond frame width: don't subtract 1 "pixel" when
1109 computing width of the stretch.
3e62b7e0
EZ
1110 (reseat_at_next_visible_line_start): Undo the change made on
1111 2011-09-17 that saved paragraph information and restored it after
1112 the call to `reseat'. (Bug#9545)
56cd55c8 1113
5ed99d36 11142011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1115
1116 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1117 and turn window cursor on if cleared (Bug#9415).
1118
5ed99d36 11192011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1120
1121 * search.c (boyer_moore): Take unibyte characters from pattern
1122 literally. (Bug#9458)
1123
9bade7b2
EZ
11242011-09-18 Eli Zaretskii <eliz@gnu.org>
1125
1126 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1127
e5e9d610
PE
11282011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1129
87e4427a
PE
1130 Fix minor problem found by static checking.
1131 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1132 initialized, to pacify gcc -Wuninitialized.
1133
e5e9d610
PE
1134 * fileio.c: Report proper errno when syscall falls.
1135 (Finsert_file_contents): Save and restore errno,
1136 so that report_file_error outputs the correct diagnostic.
1137 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1138
a1674f0b
EZ
11392011-09-18 Eli Zaretskii <eliz@gnu.org>
1140
1141 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1142
fbfb6dd4
EZ
11432011-09-17 Eli Zaretskii <eliz@gnu.org>
1144
1145 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1146 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1147
bb187662
EZ
11482011-09-17 Eli Zaretskii <eliz@gnu.org>
1149
1137e8b8 1150 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1151 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1152
1153 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1154 (bidi_find_paragraph_start): Search back for paragraph beginning
1155 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1156 (bidi_move_to_visually_next): Only trigger paragraph-related
1157 computations when the last character is a newline or at EOB, not
1158 just any NEUTRAL_B. (Bug#9470)
1159
bb187662
EZ
1160 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1161 truncated lines if point is covered by a display string. (Bug#9524)
1162
2e621251
PE
11632011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1164
1165 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1166 (cons_to_x_long): New function.
1167 (lisp_data_to_selection_data): Use it. Correct the test for
1168 short-versus-long data; it was negated. Break out of vector
1169 loop, for efficiency, when a long datum is discovered.
1170
91a15bc6
SM
11712011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1172
1173 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1174
b41c3a35
EZ
11752011-09-16 Eli Zaretskii <eliz@gnu.org>
1176
1177 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1178 GCC PR/17406) by declaring this function with external scope.
1179
7812ba2d
PE
11802011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1181
1182 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1183 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1184
cf7edc2a
AS
11852011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1186
1187 * editfns.c (Fformat): Correctly handle text properties on "%%".
1188
bd01620e
EZ
11892011-09-15 Eli Zaretskii <eliz@gnu.org>
1190
1191 * xterm.c (x_draw_composite_glyph_string_foreground):
1192 * w32term.c (x_draw_composite_glyph_string_foreground):
1193 * term.c (encode_terminal_code):
1194 * composite.c (composition_update_it, get_composition_id):
1195 * xdisp.c (get_next_display_element)
1196 (fill_composite_glyph_string): Add comments about special meaning
1197 of TAB characters in a composition.
1198
a02719a3
PE
11992011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1200
1201 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1202 This occurs when processing a multibyte format.
1203 Problem reported by Wolfgang Jenker.
a02719a3 1204
72589a3c
JB
12052011-09-15 Johan Bockgård <bojohan@gnu.org>
1206
1207 * xdisp.c (try_cursor_movement): Only check for exact match if
1208 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1209
1c14176c
PE
12102011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1211
1212 Remove unused external symbols.
1213 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1214 * xdisp.c (calc_pixel_width_or_height): Now static.
1215 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1216 * indent.c (check_display_width):
1217 * w32term.c: Fix comment to match code.
1218 * xterm.c, xterm.h (x_catching_errors): Remove.
1219
d2eea5b5
PE
12202011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1221
1222 * xselect.c: Use signed conversions more consistently (Bug#9498).
1223 (selection_data_to_lisp_data): Assume incoming selection data are
1224 signed integers, not unsigned. This is to be consistent with
1225 outgoing selection data, which was modified to use signed integers
1226 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1227 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1228 expects long, not unsigned long.
1229
46888499
EZ
12302011-09-14 Eli Zaretskii <eliz@gnu.org>
1231
1232 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1233 computation of loop end. Reported by Johan Bockgård
1234 <bojohan@gnu.org>.
1235
ef8ef9fb
CY
12362011-09-13 Chong Yidong <cyd@stupidchicken.com>
1237
1238 * frame.c (Fother_visible_frames_p): Function deleted.
1239
fa819fed
EZ
12402011-09-12 Eli Zaretskii <eliz@gnu.org>
1241
1242 * indent.c (compute_motion): Process display vector front to back
1243 rather than the other way around. (Bug#2496)
1244
2ba8e008
SM
12452011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1246
1247 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1248
20f53c69
CY
12492011-09-11 Chong Yidong <cyd@stupidchicken.com>
1250
1251 * minibuf.c (Fread_from_minibuffer): Doc fix.
1252
d562d7a4
EZ
12532011-09-11 Eli Zaretskii <eliz@gnu.org>
1254
1255 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1256 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1257
1c4d7f3d
LMI
12582011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1259
1260 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1261 value for non-existent files.
1262
b885bf36
EZ
12632011-09-11 Eli Zaretskii <eliz@gnu.org>
1264
1265 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1266 set its "size" to -1. This will set the modtime_size field of
1267 the corresponding buffer to -1, which is what
1268 verify-visited-file-modtime expects for files that do not exist.
1269 (Bug#9139)
1270
6612f0bf
PE
12712011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1272
1273 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1274 here ...
1275 * lisp.h: ... from here. push_key_description is no longer
1276 defined in keyboard.c, so its declaration should not be in
1277 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1278 logically belongs with push_key_description.
1279
dfb3f755
PE
12802011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1281
1282 * buffer.h: Include <sys/types.h> instead of <time.h>.
1283 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1284 Problem reported by Herbert J. Skuhra.
1285
3134906c
LMI
12862011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1287
1288 * xml.c (parse_region): Make the parsing work for
1289 non-comment-starting XML files again (bug#9144).
1290
8d903f4e
AS
12912011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1292
1293 * image.c (gif_load): Fix calculation of bottom and right corner.
1294 (Bug#9468)
1295
80ad64f4
EZ
12962011-09-10 Eli Zaretskii <eliz@gnu.org>
1297
1298 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1299 redisplay in small windows.
1300
208a048d
EZ
13012011-09-09 Eli Zaretskii <eliz@gnu.org>
1302
1303 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1304
9b1c252e
MR
13052011-09-08 Martin Rudalics <rudalics@gmx.at>
1306
1307 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1308 Operate on live windows only.
1309
2949f33b
JB
13102011-09-08 Juanma Barranquero <lekktu@gmail.com>
1311
1312 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1313
e08dcafd
EZ
13142011-09-07 Eli Zaretskii <eliz@gnu.org>
1315
1316 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1317 only under bidi iteration.
1318
115b96bd
JD
13192011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1320
1321 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1322
c8199d0f
PE
13232011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1324
1325 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1326 Without this fix, the command to link temacs failed due to an
1327 undefined symbol __builtin_isnan. This is because
1328 /usr/include/iso/math_c99.h #defines isnan(x) to
1329 __builtin_isnan(x), but the bundled gcc, which identifies itself
1330 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1331 a __builtin_isnan.
1332 * floatfns.c (isnan): #undef, and then #define to a clone of
1333 what's in data.c.
1334 (Fisnan): Always define, since it's always available now.
1335 (syms_of_floatfns): Always define isnan at the Lisp level.
1336
e39b275c 13372011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1338
1339 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1340
b2db44d9 13412011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1342
f4af5137 1343 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1344 The previous code assumed that file offsets (off_t values) fit in
1345 EMACS_INT variables, which is not true on typical 32-bit hosts.
1346 The code messed up by falsely reporting buffer overflow in cases
1347 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1348 when "big" contains more than 2**29 bytes, even though this
1349 inserts just one byte and does not overflow the buffer.
1350 (Finsert_file_contents): Store file offsets as off_t
1351 values, not as EMACS_INT values. Check for overflow when
1352 converting between EMACS_INT and off_t. When checking for
1353 buffer overflow or for overlap, take the offsets into account.
1354 Don't use EMACS_INT for small values where int suffices.
1355 When checking for overlap, fix a typo: ZV was used where
1356 ZV_BYTE was intended.
1357 (Fwrite_region): Don't assume off_t fits into 'long'.
1358 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1359
ecfc0a49
MA
13602011-09-05 Michael Albinus <michael.albinus@gmx.de>
1361
1362 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1363
6511acf2 13642011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1365
0999621a 1366 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1367
1368 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1369 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1370 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1371 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1372 (modify_event_symbol): Do not assume that the length of
1373 name_alist_or_stem is safe to alloca and fits in int.
1374 (Fexecute_extended_command): Likewise for function name and binding.
1375 (Frecursion_depth): Wrap around reliably on integer overflow.
1376 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1377 since some callers pass EMACS_INT values.
1378 (Fsingle_key_description): Don't crash if symbol name contains more
1379 than MAX_ALLOCA bytes.
1380 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1381 (get_minibuffer): Arg is now EMACS_INT, not int.
1382 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1383 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1384 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1385
2be7d702
PE
1386 * dbusbind.c (signature_cat): New function.
1387 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1388 Do not overrun buffer; instead, report string overflow.
1389
9d1df220
PE
1390 * dispnew.c (add_window_display_history): Don't overrun buffer.
1391 Truncate instead; this is OK since it's just a log.
1392
33ef5c64
PE
1393 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1394 even if the time zone offset is outlandishly large.
1395 Don't mishandle offset == INT_MIN.
1396
66c6fdd5
PE
1397 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1398 when creating daemon; the previous buffer-overflow check was incorrect.
1399
d749b01b
PE
1400 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1401 which has the guts of the old verror function.
1402
b5cd1905
PE
1403 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1404 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1405
6e1a67fb
PE
1406 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1407 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1408 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1409 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1410 length of string rather than counting it via multiple sprintfs;
1411 that's simpler and more reliable.
c21721cc
PE
1412 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1413 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1414 sprintf, in case result does not fit in int.
1415
c57b67fc
PE
1416 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1417 (fontset_from_font): Print it.
1418
8a401434
PE
1419 * frame.c (tty_frame_count): Now printmax_t, not int.
1420 (make_terminal_frame, set_term_frame_name): Print it.
1421 (x_report_frame_params): In X, window IDs are unsigned long,
1422 not signed long, so print them as unsigned.
1423 (validate_x_resource_name): Check for implausibly long names,
1424 and don't assume name length fits in 'int'.
1425 (x_get_resource_string): Don't blindly alloca invocation name;
1426 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1427 not fit in int.
1428
6e1a67fb
PE
1429 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1430 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1431 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1432
0df02bf3
PE
1433 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1434 Use esprintf, not sprintf, in case result does not fit in int.
1435
48e30793
PE
1436 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1437 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1438 it as a large positive number.
1439 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1440 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1441
a66ff6d8
PE
1442 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1443 in case result does not fit in int.
1444
aca216ff
PE
1445 * print.c (float_to_string): Detect width overflow more reliably.
1446 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1447 buffer overrun. Don't assume list length fits in 'int'. Treat
1448 print length of 0 as 0, not as infinity; to be consistent with other
1449 uses of print length in this function. Don't overflow print length
1450 index. Don't assume hash table size fits in 'long', or that
1451 vectorlike size fits in 'unsigned long'.
1452
31c286f7
PE
1453 * process.c (make_process): Use printmax_t, not int, to format
1454 process-name gensyms.
1455
55e5faa1
PE
1456 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1457
80f2e268
PE
1458 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1459 to avoid potential buffer overrun.
1460
670741ab
PE
1461 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1462 if X resource line is longer than 512 bytes.
1463
b7163a50
PE
1464 * xfns.c (x_window): Make sprintf buffer a bit bigger
1465 to avoid potential buffer overrun.
1466
ae58ff1f
PE
1467 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1468
c43c8a6a
PE
1469 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1470
3f8236f4
PE
14712011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1472
53e9fe90 1473 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1474 Without these, Emacs silently mishandles large integers sometimes.
1475 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1476 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1477
6511acf2
PE
1478 * xdisp.c (try_window_id): Check Emacs fixnum range before
1479 converting to 'int'.
806add1d 1480
6511acf2 1481 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1482 Check that an Emacs fixnum is in range before assigning it to 'int'.
1483 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1484 values converted from Emacs fixnums.
1485 (Frecenter): Don't wrap around a line count if it is out of 'int'
1486 range; instead, treat it as an extreme value.
1487 (Fset_window_configuration, compare_window_configurations):
1488 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1489
6511acf2
PE
1490 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1491 that can exceed INT_MAX. Check that EMACS_INT value is in range
1492 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1493 (match_limit): Don't assume that a fixnum can fit in 'int'.
1494
6511acf2 1495 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1496 exceed INT_MAX.
1497
6511acf2 1498 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1499 (Fvertical_motion): Don't wrap around LINES values that don't fit
1500 in 'int'. Instead, treat them as extreme values. This is good
1501 enough for windows, which can't have more than INT_MAX lines anyway.
1502
fcb901a7
LMI
15032011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1504
0f2f6b6d
LMI
1505 * Require libxml/parser.h to avoid compilation warning.
1506
fcb901a7
LMI
1507 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1508
1509 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1510 since this reportedly can destroy thread storage.
1511
6e20a0d4
CY
15122011-08-30 Chong Yidong <cyd@stupidchicken.com>
1513
1514 * syntax.c (find_defun_start): Update all cache variables if
1515 exiting early (Bug#9401).
1516
148ae00e
EZ
15172011-08-30 Eli Zaretskii <eliz@gnu.org>
1518
f6cfbd8f
EZ
1519 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1520
148ae00e
EZ
1521 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1522 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1523 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1524
1525 * term.c (tty_append_glyph): New function.
1526 (produce_stretch_glyph): Static function and its prototype deleted.
1527
a66cfb1c
SM
1528 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1529 Add prototypes.
148ae00e 1530
c4a07a4c
PE
15312011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1532
1533 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1534 when checking :margin (Bug#9390).
1535 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1536 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1537 so that the name doesn't mislead. All uses changed.
1538
6bc8cd65
JB
15392011-08-28 Johan Bockgård <bojohan@gnu.org>
1540
1541 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1542 set_tty_hooks.
1543
dca4927e
EZ
15442011-08-27 Eli Zaretskii <eliz@gnu.org>
1545
1546 * xdisp.c (move_it_to): Don't bail out early when reaching
1547 position beyond to_charpos, if we are scanning backwards.
1548 (move_it_vertically_backward): When DY == 0, make sure we get to
1549 the first character in the line after the newline.
1550
f2cad773
PE
15512011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1552
1553 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1554 (ccl_driver): Do not generate an out-of-range pointer.
1555 (Fccl_execute_on_string): Remove unnecessary check for
1556 integer overflow, noted by Stefan Monnier in
1557 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1558 Remove a FIXME that didn't need fixing.
1559 Simplify the newly-introduced buffer reallocation code.
1560
0cae2cdb
JB
15612011-08-27 Juanma Barranquero <lekktu@gmail.com>
1562
1563 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1564
5fc295a4 15652011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1566
70c60eb2 1567 Integer and memory overflow issues (Bug#9196).
726e0ab1 1568
d31850da
PE
1569 * doc.c (get_doc_string): Rework so that
1570 get_doc_string_buffer_size is the actual buffer size, rather than
1571 being 1 less than the actual buffer size; this makes xpalloc more
1572 convenient.
1573
a69fbedb
PE
1574 * image.c (x_allocate_bitmap_record, cache_image):
1575 * xselect.c (Fx_register_dnd_atom):
1576 Simplify previous changes by using xpalloc.
1577
fe5c5d37
PE
1578 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1579 since either will do and ptrdiff_t is convenient with xpalloc.
1580
0065d054
PE
1581 * charset.c (charset_table_size)
1582 (struct charset_sort_data.priority): Now ptrdiff_t.
1583 (charset_compare): Don't overflow if priorities differ greatly.
1584 (Fsort_charsets): Don't assume list length fits in int.
1585 Check for size-calculation overflow when allocating sort data.
1586 (syms_of_charset): Allocate an initial charset table that is
1587 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1588
1589 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1590
1591 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1592 The actual value is always <= INT_MAX, and leaving it unsigned made
1593 overflow checking harder.
1594
1595 * dispextern.h (struct glyph_matrix.rows_allocated)
1596 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1597 with xpalloc. The values are still always <= INT_MAX.
1598
1599 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1600
1601 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1602 (SAFE_NALLOCA): New macro.
1603
1604 * region-cache.c (struct boundary.pos, find_cache_boundary)
1605 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1606 (set_cache_region, invalidate_region_cache)
1607 (revalidate_region_cache, know_region_cache, region_cache_forward)
1608 (region_cache_backward, pp_cache):
1609 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1610 so that ptrdiff_t * can be passed to xpalloc.
1611 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1612 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1613 (pp_cache): Don't assume cache_len fits in int.
1614 * region-cache.h: Adjust extern decls to match.
1615
1616 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1617 EMACS_INT, since either will do, for xpalloc.
1618
1619 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1620 (xnmalloc, xnrealloc, xpalloc): New functions.
1621
726e0ab1
PE
1622 * bidi.c (bidi_shelve_header_size): New constant.
1623 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1624 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1625
51f30bc5 1626 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1627 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1628 (overlay_strings):
1629 Don't update size of array until after memory allocation succeeds,
1630 because xmalloc/xrealloc may not return.
0065d054
PE
1631 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1632 now that we have proper integer overflow checking.
1633 (record_overlay_string, overlay_strings): Catch overflows when
1634 calculating size of overlay_str_buf.
726e0ab1 1635
0065d054
PE
1636 * callproc.c (Fcall_process): Check for size overflow when
1637 calculating size of args2.
1638 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1639 Normally we prefer signed values, but sticking with ptrdiff_t would
1640 require adding more-complicated checks.
726e0ab1
PE
1641
1642 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1643 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1644 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1645 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1646
1647 * character.c (Fstring): Check for size-calculation overflow.
1648
1649 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1650 unnecessary integer overflow. Check for size overflow.
1651 (encode_coding_object): Don't update size until xmalloc succeeds.
1652
1653 * composite.c (get_composition_id): Check for overflow in glyph
1654 length calculations.
1655
1656 Integer and memory overflow fixes for display code.
1657 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1658 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1659 (scrolling_window): Check for overflow in size calculations.
1660 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1661 Don't assume glyph table len fits in int.
1662 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1663 (row_table_size): Now ptrdiff_t, not int.
1664 (scrolling_window): Avoid overflow in size calculations.
1665 Don't update size until allocation succeeds.
1666 * fns.c (concat): Check for overflow in size calculations.
1667 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1668 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1669 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1670
1671 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1672 (get_doc_string): Check for size calculation overflow.
1673 Don't update size until allocation succeeds.
1674 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1675 EMACS_INT, where ptrdiff_t will do.
1676 (Fsubstitute_command_keys): Check for string overflow.
1677
1678 * editfns.c (set_time_zone_rule): Don't assume environment length
1679 fits in int.
1680 (message_length): Now ptrdiff_t, not int.
1681 (Fmessage_box): Don't update size until allocation succeeds.
1682 Don't assume message length fits in int.
1683 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1684
0065d054
PE
1685 * emacs.c (main): Do not reallocate argv, since there is a null at
1686 the end that can be overwritten, and this way there's no need to
1687 worry about size-calculation overflow.
1688 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1689
1690 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1691 alloc succeeds.
1692 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1693
1694 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1695 (x_set_scroll_bar_width, x_figure_window_size):
1696 Check for integer overflow.
1697 (x_set_alpha): Do not assume XINT fits in int.
1698
1699 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1700 This is for the members text_lines, text_cols, total_lines, total_cols,
1701 where the system imposes an 'int' limit.
1702
1703 * fringe.c (Fdefine_fringe_bitmap):
1704 Don't update size until alloc works.
1705
1706 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1707 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1708
1709 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1710 Check for size-calculation overflow.
1711 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1712 do, as we prefer signed integers.
1713 (id_to_widget.max_size, id_to_widget.used)
1714 (xg_store_widget_in_map, xg_remove_widget_from_map)
1715 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1716 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1717 Use and return ptrdiff_t, not int.
1718 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1719 * gtkutil.h: Change prototypes to match the above.
1720
1721 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1722 are duplicate now that they've been promoted to lisp.h.
1723 (x_allocate_bitmap_record, x_alloc_image_color)
1724 (make_image_cache, cache_image, xpm_load):
1725 Don't update size until alloc is done.
1726 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1727 (x_detect_edges):
3256efce 1728 Check for size calculation overflow.
726e0ab1
PE
1729 (ct_colors_allocated_max): New constant.
1730 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1731 overflow.
3256efce 1732
726e0ab1
PE
1733 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1734 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1735 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1736 Use ptrdiff_t, not int, to count maps.
1737 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1738 calculations. Don't update size until allocation succeeds.
1739 Redo calculations to avoid overflow.
726e0ab1
PE
1740 * keyboard.h: Change prototypes to match the above.
1741
1742 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1743 to count maps.
1744 (current_minor_maps): Check for size calculation overflow.
1745 * keymap.h: Change prototypes to match the above.
1746
1747 * lread.c (read1, init_obarray): Don't update size until alloc done.
1748
1749 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1750 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1751
726e0ab1
PE
1752 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1753 Now ptrdiff_t, not int.
1754 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1755 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1756
1757 * process.c (Fnetwork_interface_list): Check for overflow
1758 in size calculation.
1759
1760 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1761
1762 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1763 overflow. Don't bother calling xmalloc when xrealloc will do.
1764
1765 * search.c (Freplace_match): Check for size calculation overflow.
1766 (Fset_match_data): Don't assume list lengths fit in 'int'.
1767
1768 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1769 for command line length. Do not attempt to address one before the
1770 beginning of an array, as that's not portable.
1771
1772 * term.c (max_frame_lines): Remove; unused.
1773 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1774 not int.
1775 (encode_terminal_code, calculate_costs): Check for size
1776 calculation overflow.
1777 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1778 table lengths and related sizes. Don't update size until alloc
1779 done. Redo calculations to avoid overflow.
1780 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1781
1782 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1783 subtracting pointers.
1784 (gobble_line): Check for overflow more carefully. Don't update size
1785 until alloc done.
1786
1787 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1788 Don't update size until alloc done.
1789 Redo size calculations to avoid overflow.
1790 Check for size calculation overflow.
0065d054 1791 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1792
1793 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1794 Use ptrdiff_t, not int, for sizes.
1795 (store_mode_line_noprop_char): Don't update size until alloc done.
1796
0065d054
PE
1797 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1798 Use ptrdiff_t, not int, for sizes.
1799 (Finternal_make_lisp_face, cache_face):
1800 Check for size calculation overflow.
1801 (cache_face): Treat size calculation overflows as if they were
1802 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1803
1804 * xfns.c (x_encode_text, x_set_name_internal)
1805 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1806 sizes, since they can exceed INT_MAX in size. Check for size
1807 calculation overflow.
1808
0065d054
PE
1809 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1810 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1811 Don't update size until alloc done.
1812
0065d054 1813 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1814 as sprintf is limited to int lengths.
1d526e2f 1815
252c5ee1
PE
1816 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1817 (X_LONG_MIN): New macros.
864d7ce7
PE
1818 Use them to make the following changes clearer.
1819 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1820 This change doesn't affect the value now, but it may help remind
1821 future maintainers not to raise the value too much later.
1822 (SELECTION_QUANTUM): Remove, replacing with ...
1823 (selection_quantum): ... new function, which avoids overflow.
1824 All uses changed.
1825 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1826 assumption that selection length fits in 'int'.
1827 (x_reply_selection_request, x_handle_selection_request)
1828 (x_get_window_property, receive_incremental_selection)
1829 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1830 (lisp_data_to_selection_data, clean_local_selection_data):
1831 Use ptrdiff_t, not int, to record length of selection.
1832 (x_reply_selection_request, x_get_window_property)
1833 (receive_incremental_selection, x_property_data_to_lisp):
1834 Redo calculations to avoid overflow.
1835 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1836 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1837 something.
1838 (x_get_window_property, receive_incremental_selection)
1839 (lisp_data_to_selection_data, x_property_data_to_lisp):
1840 Check for size-calculation overflow.
1841 (x_get_window_property, receive_incremental_selection)
1842 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1843 Don't store size until memory allocation succeeds.
1844 (x_get_window_property): Plug memory leak on memory exhaustion.
1845 Don't double-block input; malloc is safe here. Don't assume 2**34
1846 - 4 fits in unsigned long. Add an xassert to check
1847 XGetWindowProperty overflow. Be more careful about overflow
1848 calculations, and distinguish size from memory overflow better.
1849 (receive_incremental_selection): When tracing, don't assume
1850 unsigned int is less than INT_MAX.
1851 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1852 harmful) conversions of unsigned short to int.
1853 (lisp_data_to_selection_data): Don't assume that integers
1854 in the range -65535 through -1 fit in an X unsigned short.
1855 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1856 result parameters unless successful. Rely on cons_to_unsigned
1857 to report problems with elements; the old code wasn't right anyway.
1858 (x_check_property_data): Check for int overflow; we cannot use
1859 a wider type due to X limits.
1860 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1861
726e0ab1 1862 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1863
0065d054
PE
1864 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1865 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1866 (x_color_cells): Don't store size until memory allocation succeeds.
1867 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1868 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1869 (x_term_init): Don't assume length fits in int (sprintf is limited
1870 to int size).
bc18e09d 1871
ebfa62c0
PE
1872 Use ptrdiff_t for composition IDs.
1873 * character.c (lisp_string_width):
1874 * composite.c (composition_table_size, n_compositions)
1875 (get_composition_id, composition_gstring_from_id):
1876 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1877 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1878 * window.c (Frecenter):
1879 Use ptrdiff_t, not int, for composition IDs.
1880 * composite.c (get_composition_id): Check for integer overflow.
1881 * composite.h: Adjust prototypes to match the above changes.
1882
d3411f89
PE
1883 Use ptrdiff_t for hash table indexes.
1884 * category.c (hash_get_category_set):
1885 * ccl.c (ccl_driver):
1886 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1887 * coding.c (coding_system_charset_list, detect_coding_system):
1888 * coding.h (struct coding_system.id):
1889 * composite.c (get_composition_id, gstring_lookup_cache):
1890 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1891 * image.c (xpm_get_color_table_h):
1892 * lisp.h (hash_lookup, hash_put):
1893 * minibuf.c (Ftest_completion):
1894 Use ptrdiff_t for hash table indexes, not int (which is too
1895 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1896 32-bit --with-wide-int hosts).
1897
e097a6fa
PE
1898 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1899 Add a FIXME comment about memory leaks.
1900 (syms_of_charset): Don't assume xmalloc returns.
1901
5637687f
PE
1902 Don't assume that stated character widths fit in int.
1903 * character.c (Fchar_width, c_string_width, lisp_string_width):
1904 * character.h (CHAR_WIDTH):
1905 * indent.c (MULTIBYTE_BYTES_WIDTH):
1906 Use sanitize_char_width to avoid undefined and/or bad behavior
1907 with outlandish widths.
a66cfb1c 1908 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1909 now that we have two such functions. All uses changed.
1910 (sanitize_char_width): New inline function.
1911
a2271ba2
PE
1912 Don't assume that tab-width fits in int.
1913 * character.h (sanitize_width): New inline function.
1914 (SANE_TAB_WIDTH): New macro.
1915 (ASCII_CHAR_WIDTH): Use it.
1916 * indent.c (sane_tab_width): Remove. All uses replaced by
1917 SANE_TAB_WIDTH (current_buffer).
1918 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1919
18c52557
PE
1920 * fileio.c: Integer overflow issues with file modes.
1921 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1922
caeeedc1
PE
1923 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1924 Remove unreachable code.
1925 (read_hex, load_charset_map_from_file): Check for integer overflow.
1926
50849c52
PE
1927 * xterm.c: don't go over XClientMessageEvent limit
1928 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1929 (x_send_scroll_bar_event): Likewise. Check that the size does not
1930 exceed limits imposed by XClientMessageEvent, as well as the usual
1931 ptrdiff_t and size_t limits.
1932
b13995db
PE
1933 * keyboard.c: Overflow, signedness and related fixes.
1934 (make_lispy_movement): Use same integer type in forward decl
1935 that is used in the definition.
1936 (read_key_sequence, keyremap_step):
1937 Change bufsize argument back to int, undoing my 2011-03-30 change.
1938 We prefer signed types, and int is wide enough here.
1939 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1940 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1941 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1942 length, not size_t. Use ptrdiff_t for index, not int.
1943 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1944 possibility of integer overflow.
1945
13464394
PE
1946 Overflow, signedness and related fixes for images.
1947
1948 * dispextern.h (struct it.stack[0].u.image.image_id)
1949 (struct_it.image_id, struct image.id, struct image_cache.size)
1950 (struct image_cache.used, struct image_cache.ref_count):
1951 * gtkutil.c (update_frame_tool_bar):
1952 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1953 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1954 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1955 * nsmenu.m (update_frame_tool_bar):
1956 * xdisp.c (calc_pixel_width_or_height):
1957 * xfns.c (image_cache_refcount):
1958 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1959 on typical 64-bit hosts.
1960
1961 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1962 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1963 Omit unnecessary casts to int.
1964 (parse_image_spec): Check that integers fall into 'int' range
1965 when the callers expect that.
1966 (image_ascent): Redo ascent calculation to avoid int overflow.
1967 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1968 (lookup_image): Remove unnecessary tests.
1969 (xbm_image_p): Locals are now of int, not EMACS_INT,
1970 since parse_image_check makes sure they fit into int.
1971 (png_load, gif_load, svg_load_image):
1972 Prefer int to unsigned where either will do.
1973 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1974 old tiff_error_handler and tiff_warning_handler.
1975 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1976 stack buffer overflows. It uses only the features of vsnprintf
1977 that are common to both POSIX and native Microsoft.
1978 (tiff_error_handler, tiff_warning_handler): Use it.
1979 (tiff_load, gif_load, imagemagick_load_image):
1980 Don't assume :index value fits in 'int'.
1981 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1982 (imagemagick_load_image): Check that crop parameters fit into
1983 the integer types that MagickCropImage accepts. Don't assume
1984 Vimagemagick_render_type has a nonnegative value. Don't assume
1985 size_t fits in 'long'.
1986 (gs_load): Use printmax_t to print the widest integers possible.
1987 Check for integer overflow when computing image height and width.
1988
c11821d4
EZ
19892011-08-26 Eli Zaretskii <eliz@gnu.org>
1990
1991 * xdisp.c (redisplay_window): Don't force window start if point
1992 will be invisible in the resulting window. (Bug#9324)
1993
0c95fcf7
EZ
19942011-08-25 Eli Zaretskii <eliz@gnu.org>
1995
1996 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1997 the display spec is of the form `(space ...)'.
1998 (handle_display_spec): Return the value returned by
1999 handle_single_display_spec, not just 1 or zero.
2000 (handle_single_display_spec): If the display spec is of the form
2001 `(space ...)', and specifies display in the text area, return 2
2002 rather than 1.
fee65a97 2003 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2004 accurately, and prefer exact match for point under bidi.
2005 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2006
2007 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2008 into disp_prop; all users changed.
2009
2010 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2011 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2012 for the text covered by the display property.
2013
e4ed06f1
CY
20142011-08-25 Chong Yidong <cyd@stupidchicken.com>
2015
2016 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2017 Change return value to nil.
2018 (Frecord_buffer): Delete unused function.
2019
f67cdd7f
EZ
20202011-08-24 Eli Zaretskii <eliz@gnu.org>
2021
5980d4c6
EZ
2022 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2023 buffers, return left-to-right.
8610fe8b
EZ
2024 (set_cursor_from_row): Consider candidate row a win if its glyph
2025 represents a newline and point is on that newline. Fixes cursor
2026 positioning on the newline at EOL of R2L text within L2R
2027 paragraph, and vice versa.
2028 (try_cursor_movement): Check continued rows, in addition to
2029 continuation rows. Fixes unwarranted scroll when point enters a
2030 continued line of R2L text within an L2R paragraph, or vice versa.
2031 (cursor_row_p): Consider the case of point being equal to
2032 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2033 from the end of a short line to the beginning of a continued line
2034 of R2L text within L2R paragraph.
2035 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2036 composed characters.
5980d4c6 2037
f67cdd7f
EZ
2038 * bidi.c (bidi_check_type): Use xassert.
2039 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2040 members.
2041
bca633fb
EZ
20422011-08-23 Eli Zaretskii <eliz@gnu.org>
2043
2044 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2045 a character.
2046
4a5885a7
CY
20472011-08-23 Chong Yidong <cyd@stupidchicken.com>
2048
2049 * nsfont.m (ns_otf_to_script): Fix typo.
2050
0902a04e
KH
20512011-08-22 Kenichi Handa <handa@m17n.org>
2052
2053 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2054 extra slot even if the purpose is char-code-property-table.
2055
1a2e6670
EZ
20562011-08-23 Eli Zaretskii <eliz@gnu.org>
2057
8ddde651
EZ
2058 * xdisp.c (redisplay_window): When computing centering_position,
2059 account for the height of the header line. (Bug#8874)
2060
425cc014
EZ
2061 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2062 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2063 candidate is selected by the mouse, and that candidate has a
2064 composed character under the mouse.
2065
1a2e6670
EZ
2066 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2067 coordinates reported by pos-visible-in-window-p for a composed
2068 character in column zero.
2069
8b76d6f8
SM
20702011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2071
2072 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2073
dac347dd
EZ
20742011-08-22 Eli Zaretskii <eliz@gnu.org>
2075
2076 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2077 consider it a hit if to_charpos is anywhere in the range of the
2078 composed buffer positions.
2079
e013fb34
CY
20802011-08-22 Chong Yidong <cyd@stupidchicken.com>
2081
2082 * image.c (gif_load): Don't assume that each subimage has the same
2083 dimensions as the base image. Handle disposal method that is
2084 "undefined" by the gif spec (Bug#9335).
2085
bd1ba3e8
CY
20862011-08-20 Chong Yidong <cyd@stupidchicken.com>
2087
2088 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2089 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2090
54a1215b
EZ
20912011-08-19 Eli Zaretskii <eliz@gnu.org>
2092
823564e5
EZ
2093 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2094 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2095 from an Org mode buffer to a Speedbar frame.
2096
54a1215b
EZ
2097 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2098 a composition, take its buffer position from IT->cmp_it.charpos.
2099 Fixes cursor positioning at the beginning of a line that begins
2100 with a composed character.
2101
9778ebcc
EZ
21022011-08-18 Eli Zaretskii <eliz@gnu.org>
2103
0be6ee06
EZ
2104 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2105 character bidirectional type, use STRONG_L instead. Fixes crashes
2106 in a buffer produced by `describe-categories'.
2107
9778ebcc
EZ
2108 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2109 members before the level stack, so they would be saved and
2110 restored when copying iterator state. Fixes incorrect reordering
2111 around TABs covered by display properties.
2112
156bffbe
AS
21132011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2114
6b02f655 2115 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2116
72ad093b
CY
21172011-08-17 Chong Yidong <cyd@stupidchicken.com>
2118
2119 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2120 (internal_condition_case_2, internal_condition_case_n):
2121 Remove unnecessary aborts (Bug#9081).
72ad093b 2122
35774242
EZ
21232011-08-17 Eli Zaretskii <eliz@gnu.org>
2124
2125 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2126 has no `load' handler, try opening the file locally. (Bug#9311)
2127
db76dd85
KB
21282011-08-16 Ken Brown <kbrown@cornell.edu>
2129
2130 * gmalloc.c: Expand comment.
2131
b215eee5
EZ
21322011-08-16 Eli Zaretskii <eliz@gnu.org>
2133
2134 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2135 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2136
a4579d33
KB
21372011-08-16 Ken Brown <kbrown@cornell.edu>
2138
2139 Fix memory allocation problems in Cygwin build (Bug#9273).
2140
2141 * unexcw.c ( __malloc_initialized): Declare external variable.
2142 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2143
8b76d6f8
SM
2144 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2145 New variables.
a4579d33
KB
2146 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2147 dumped emacs.
2148 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2149 in the static heap.
2150 [CYGWIN] (special_realloc): New function.
2151 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2152 requests to realloc storage in the static heap.
2153
3ebec551
PE
21542011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2155
2156 * bidi.c (bidi_initialize): Remove unused local.
2157
9fd8be00
EZ
21582011-08-15 Eli Zaretskii <eliz@gnu.org>
2159
6b02f655
SM
2160 * bidimirror.h:
2161 * biditype.h: Remove file.
2162 * makefile.w32-in ($(BLD)/bidi.$(O)):
2163 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2164
2165 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2166
2167 * chartab.c: Improve commentary for the uniprop_table API.
2168
32413314
EZ
2169 * bidi.c (bidi_paragraph_init): Support zero value of
2170 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2171 (bidi_initialize): Use uniprop_table instead of including
2172 biditype.h and bidimirror.h.
32413314 2173
9fd8be00
EZ
2174 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2175 coordinates of the iterator when restoring from ppos_it.
2176 (Bug#9296)
2177
5cf2b69b
KH
21782011-08-14 Kenichi Handa <handa@m17n.org>
2179
2180 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2181 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2182
daf17d00
EZ
21832011-08-14 Eli Zaretskii <eliz@gnu.org>
2184
2185 * xdisp.c (move_it_in_display_line_to): Don't invoke
2186 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2187 ppos_it. Fixes vertical cursor motion when line beginning is
2188 covered by an image. (Bug#9296)
2189
08e3161a
JD
21902011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2191
2192 * nsterm.h (ns_run_ascript): Declare.
2193 (NSAPP_DATA2_RUNASSCRIPT): Define.
2194
2195 * nsfns.m (as_script, as_result, as_status): New static variables.
2196 (ns_run_ascript): New function.
5e617bc2 2197 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2198 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2199 the event loop. Get status from as_status (Bug#7276).
2200
2201 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2202 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2203 the event loop (Bug#7276).
2204
a3720aa2
AS
22052011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2206
2207 * gnutls.c (QCgnutls_bootprop_priority)
2208 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2209 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2210 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2211 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2212 (QCgnutls_bootprop_verify_hostname_error)
2213 (QCgnutls_bootprop_callbacks_verify): Rename from
2214 Qgnutls_bootprop_..., all uses changed.
2215
2216 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2217 uses changed.
2218
0a0d27fb
PE
22192011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2220
19d5c50c
PE
2221 * xfaces.c (Qframe_set_background_mode): Now static.
2222 * dispextern.h (Qframe_set_background_mode): Remove decl.
2223
0a0d27fb
PE
2224 * process.c (Fnetwork_interface_info): Declare local only if needed.
2225
377538cb
JD
22262011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2227
2228 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2229 (Fnetwork_interface_list): Allocate in increments of bytes instead
2230 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2231 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2232 sockaddr.
2233 (struct ifflag_def): notrailers is smart on OSX.
2234 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2235 Get hardware address with getifaddrs if available.
2236
08fff70c
EZ
22372011-08-12 Eli Zaretskii <eliz@gnu.org>
2238
2239 * xdisp.c (iterate_out_of_display_property): xassert that
2240 IT->position is set to within IT->object's boundaries. Break from
2241 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2242 when IT->position is set up wrongly due to some bug.
2243 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2244 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2245 entry. Force push_it to save on the stack the current
2246 buffer/string position, to be restored by pop_it. Fix flags in
2247 the iterator structure wrt the object coming from a display
2248 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2249 properties. (Bug#9284)
2250
7be1c708 22512011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2252
7be1c708
CY
2253 * fontset.c (fontset_get_font_group): Add proper type checks.
2254 (Bug#9172)
aac0c6e3 2255
7be1c708 22562011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2257
7be1c708
CY
2258 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2259 and LC_VERSION_MIN_MACOSX.
2260 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2261 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2262
97bb72a6
EZ
22632011-08-08 Eli Zaretskii <eliz@gnu.org>
2264
2265 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2266 no-display-properties-and-no-overlays under bidi display.
2267 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2268 properties and overlays.
97bb72a6 2269
d5617611
CY
22702011-08-08 Chong Yidong <cyd@stupidchicken.com>
2271
37e11a63
CY
2272 * editfns.c (Fset_time_zone_rule): Document relationship with the
2273 setenv function.
2274
d5617611
CY
2275 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2276 the font entity extracted from the cache (Bug#8109).
2277
58872834
CY
22782011-08-07 Chong Yidong <cyd@stupidchicken.com>
2279
2280 * composite.c (autocmp_chars): Don't reset point. That is done by
2281 restore_point_unwind (Bug#5984).
2282
75bfc667
JL
22832011-08-07 Juri Linkov <juri@jurta.org>
2284
2285 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2286 to show the arg `TIME' instead of `TIMEVAL'.
2287
d1410150
EZ
22882011-08-06 Eli Zaretskii <eliz@gnu.org>
2289
2290 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2291 display property strides EOL and includes a newline, as in
2292 longlines-mode. (Bug#9254)
75b771e4
EZ
2293 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2294 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2295
2296 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2297 is non-zero, even if the data buffer is NULL. Fixes a crash in
2298 vertical-motion with longlines-mode. (Bug#9254)
2299
35928349
EZ
23002011-08-05 Eli Zaretskii <eliz@gnu.org>
2301
ec7cc85b
EZ
2302 * bidi.c <bidi_cache_total_alloc>: Now static.
2303 (bidi_initialize): Initialize bidi_cache_total_alloc.
2304
8b76d6f8 2305 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2306 cache. (Bug#9221)
2307
2308 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2309 amount allocated this far in `bidi_cache_total_alloc'.
2310 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2311 non-zero, only free the data buffer without restoring the cache
2312 contents. All callers changed.
2313
2314 * dispextern.h (bidi_unshelve_cache): Update prototype.
2315
2316 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2317 (move_it_in_display_line, move_it_to)
2318 (move_it_vertically_backward, move_it_by_lines): Replace the call
2319 to xfree to an equivalent call to bidi_unshelve_cache.
2320 (move_it_in_display_line_to): Fix logic of returning
412b6358 2321 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2322
e2e2423b
EZ
23232011-08-05 Eli Zaretskii <eliz@gnu.org>
2324
2325 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2326 came from a string character with a `cursor' property. (Bug#9229)
2327
ae9e757a
JD
23282011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2329
2330 * Makefile.in (LIB_PTHREAD): New variable.
2331 (LIBES): Add LIB_PTHREAD (Bug#9216).
2332
2333 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2334 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2335
213bd7f2
AS
23362011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2337
6b02f655 2338 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2339
99aaf75f
JD
23402011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2341
2342 * xterm.c (x_find_topmost_parent): New function.
2343 (x_set_frame_alpha): Find topmost parent window with
2344 x_find_topmost_parent and set the property there also (bug#9181).
2345 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2346
c74e9d86
PE
23472011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2348
2349 * callproc.c (Fcall_process): Avoid vfork clobbering
2350 the local vars buffer, coding_systems, current_dir.
2351
640c8776
SM
23522011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2353
2354 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2355
f26d0e4c
PE
23562011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2357
8a10d76c
PE
2358 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2359 so that it is not optimized away.
2360
f26d0e4c
PE
2361 * xdisp.c (compute_display_string_pos): Remove unused local.
2362
55439c61
EZ
23632011-08-02 Eli Zaretskii <eliz@gnu.org>
2364
2365 Fix slow cursor motion and scrolling in large buffers with
2366 selective display, like Org Mode buffers. (Bug#9218)
2367
2368 * dispextern.h (struct bidi_it): New member disp_prop_p.
2369
2370 * xdisp.c: Remove one-slot cache of display string positions.
2371 (compute_display_string_pos): Accept an additional argument
5e617bc2 2372 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2373 for a display string or property. If found, set DISP_PROP_P
2374 non-zero.
2375
2376 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2377 DISP_PROP_P, and pass it to compute_display_string_pos.
2378 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2379 non-zero. All callers of bidi_fetch_char changed.
2380
fb33fa43
SM
23812011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2382
2383 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2384
b099e063
DM
23852010-12-03 Don March <don@ohspite.net>
2386
2387 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2388 last character M-[char] is translated to ESC [char] (bug#7541).
2389
5cc7f7af
KH
23902011-08-02 Kenichi Handa <handa@m17n.org>
2391
d0fffa3f 2392 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2393
2394 * chartab.c (uniprop_table): Make it non-static.
2395
525d5e6e
EZ
23962011-08-01 Eli Zaretskii <eliz@gnu.org>
2397
2398 * xdisp.c (forward_to_next_line_start): Accept additional argument
2399 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2400 on the newline.
2401 (reseat_at_next_visible_line_start): Use the bidi iterator state
2402 returned by forward_to_next_line_start to restore the state of
2403 it->bidi_it after backing up to previous newline. (Bug#9212)
2404
31011111
AS
24052011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2406
2407 * regex.c (re_comp): Protoize.
2408 (re_exec): Fix return type.
2409 (regexec): Fix type of `ret'. (Bug#9203)
2410
476371c4
PE
24112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2412
e5d76069
PE
2413 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2414 This is needed if max-image-size is a floating-point number.
2415
9a79b20c
AS
24162011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2417
2418 * print.c (print_object): Print empty symbol as ##.
2419
2420 * lread.c (read1): Read ## as empty symbol.
2421
d8c2fa78
AA
24222011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2423
2424 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2425 setting frame foreground color (Bug#9175).
2426 (x_set_background_color): Likewise.
2427
ffe57a7a
AA
2428 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2429 contents (Bug#9176).
2430 (EmacsTooltip -init): Remove bezels and add shadows to
2431 tooltip windows.
2432
bf3492a5
AA
2433 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2434 or scroll bar (Bug#8470).
2435
d55e9c53
AA
2436 * nsfont.m (nsfont_open): Remove assignment to voffset and
2437 unnecessary vars hshink, expand, hd, full_height, min_height.
2438 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2439
2440 * nsterm.h (nsfont_info): Remove voffset field.
2441
d8c2fa78 24422011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2443
2444 Implement strike-through and overline on NextStep (Bug#8863).
2445
2446 * nsfont.m (nsfont_open): Use underline position provided by font,
2447 instead of hard-coded value of 2.
2448 (nsfont_draw): Call ns_draw_text_decoration instead.
2449
2450 * nsterm.h: Add declaration for ns_draw_text_decoration.
2451
2452 * nsterm.m (ns_draw_text_decoration): New function for drawing
2453 underline, overline, and strike-through.
2454 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2455 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2456 accommodate underlining, etc.
4843aac3 2457
4cc60b9b
EZ
24582011-07-28 Eli Zaretskii <eliz@gnu.org>
2459
bc7ece87
EZ
2460 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2461 default.
4cc60b9b 2462
476371c4
PE
24632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2464
66606eea
PE
2465 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2466 Without this fix, if a signal arrives just after memory fills up,
2467 'malloc' might be invoked reentrantly.
2468
476371c4
PE
2469 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2470 In other words, assume that every image size is allowed, on non-X
2471 hosts. This assumption is probably wrong, but it lets Emacs compile.
2472
f3fcc40d
AS
24732011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2474
2475 * regex.c (re_iswctype): Convert return values to boolean.
2476
350c992f
EZ
24772011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2478
2479 * xdisp.c (compute_display_string_pos): Don't use cached display
2480 string position if the buffer had its restriction changed.
2481 (Bug#9184)
2482
5266b4bb
PE
24832011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2484
2485 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2486
2573a837 24872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2488
41f55ccd 2489 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2490
39e378da
PE
2491 * bidi.c: Integer size and overflow fixes.
2492 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2493 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2494 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2495 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2496 (bidi_find_other_level_edge):
2497 Use ptrdiff_t instead of EMACS_INT where either will do.
2498 This works better on 32-bit hosts configured --with-wide-int.
2499 (bidi_cache_ensure_space): Check for size-calculation overflow.
2500 Use % rather than repeated addition, for better worst-case speed.
2501 Don't set bidi_cache_size until after xrealloc returns, because it
2502 might not return.
2503 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2504 (bidi_cache_ensure_space): Also check that the bidi cache size
2505 does not exceed that of the largest Lisp string or buffer. See Eli
2506 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2507
5e927815
PE
2508 * alloc.c (__malloc_size_t): Remove.
2509 All uses replaced by size_t. See Andreas Schwab's note
2510 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2511
ca4aa935
PE
2512 * image.c: Improve checking for integer overflow.
2513 (check_image_size): Assume that f is nonnull, since
2514 it is always nonnull in practice. This is one less thing to
2515 worry about when checking for integer overflow later.
2516 (x_check_image_size): New function, which checks for integer
2517 overflow issues inside X.
2518 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2519 This removes the need for a memory_full check.
2520 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2521 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2522 (xbm_read_bitmap_data): Change locals back to 'int', since
2523 their values must fit in 'int'.
2524 (xpm_load_image, png_load, tiff_load):
2525 Invoke x_create_x_image_and_pixmap earlier,
2526 to avoid much needless work if the image is too large.
2527 (tiff_load): Treat overly large images as if
2528 x_create_x_image_and_pixmap failed, not as malloc failures.
2529 (gs_load): Use x_check_image_size.
2530
5f8f9cc2
PE
2531 * gtkutil.c: Omit integer casts.
2532 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2533 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2534
5adf60bc
PE
2535 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2536
c8907a93
PE
2537 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2538 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2539 would wrongly return t on a 64-bit host.
2540
e3c25c68
PE
2541 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2542 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2543 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2544 and therefore cause GCC to emit a bogus diagnostic in some cases.
2545
3f791afe
PE
2546 * image.c: Integer signedness and overflow and related fixes.
2547 This is not an exhaustive set of fixes, but it's time to
2548 record what I've got.
2549 (lookup_pixel_color, check_image_size): Remove redundant decls.
2550 (check_image_size): Don't assume that arbitrary EMACS_INT values
2551 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2552 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2553 (tiff_load, imagemagick_load_image):
2554 Check for overflow in size calculations.
2555 (x_create_x_image_and_pixmap): Remove unnecessary test for
2556 xmalloc returning NULL; that can't happen.
2557 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2558 (xpm_color_bucket): Use better integer hashing function.
2559 (xpm_cache_color): Don't possibly over-allocate memory.
2560 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2561 (gif_memory_source):
2562 Use ptrdiff_t, not int or size_t, to record sizes.
2563 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2564 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2565 either works, as we prefer signed integers.
2566 (tiff_read_from_memory, tiff_write_from_memory):
2567 Return tsize_t, not size_t, since that's what the TIFF API wants.
2568 (tiff_read_from_memory): Don't fail simply because the read would
2569 go past EOF; instead, return a short read.
2570 (tiff_load): Omit no-longer-needed casts.
2571 (Fimagemagick_types): Don't assume size fits into 'int'.
2572
3cc5a532
PE
2573 Improve hashing quality when configured --with-wide-int.
2574 * fns.c (hash_string): New function, taken from sxhash_string.
2575 Do not discard information about ASCII character case; this
2576 discarding is no longer needed.
2577 (sxhash-string): Use it. Change sig to match it. Caller changed.
2578 * lisp.h: Declare it.
2579 * lread.c (hash_string): Remove, since we now use fns.c's version.
2580 The fns.c version returns a wider integer if --with-wide-int is
2581 specified, so this should help the quality of the hashing a bit.
2582
b312a492
PE
2583 * emacs.c: Integer overflow minor fix.
2584 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2585 Define only if GNU_LINUX.
2586 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2587
dfd153ae
PE
2588 * dispnew.c: Integer signedness and overflow fixes.
2589 Remove unnecessary forward decls, that were a maintenance hassle.
2590 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2591 All uses changed.
2592 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2593 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2594 (prepare_desired_row, line_draw_cost):
2595 Use int, not unsigned, where either works.
2596 (save_current_matrix, restore_current_matrix):
2597 Use ptrdiff_t, not size_t, where either works.
2598 (init_display): Check for overflow more accurately, and without
2599 relying on undefined behavior.
2600
a81d11a3
PE
2601 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2602 Remove, replacing with the new symbols in lisp.h. All uses changed.
2603 * fileio.c (make_temp_name):
2604 * filelock.c (lock_file_1, lock_file):
2605 * xdisp.c (message_dolog):
2606 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2607 Use pMd etc. instead.
2608 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2609 replacing the pWIDE etc. symbols removed from editfns.c.
2610
3300e6fd
PE
2611 * keyboard.h (num_input_events): Now uintmax_t.
2612 This is (very slightly) less likely to mess up due to wraparound.
2613 All uses changed.
2614
fd05c7e9
PE
2615 * buffer.c: Integer signedness fixes.
2616 (alloc_buffer_text, enlarge_buffer_text):
2617 Use ptrdiff_t rather than size_t when either will do, as we prefer
2618 signed integers.
2619
903fe15d
PE
2620 * alloc.c: Integer signedness and overflow fixes.
2621 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2622 (__malloc_size_t): Default to size_t, not to int.
2623 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2624 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2625 Prefer ptrdiff_t to size_t when either would do, as we prefer
2626 signed integers.
2627 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2628 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2629 Now const. Initialize with values that are in range even if char
2630 is signed.
2631 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2632 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2633 These functions do the right thing with sizes > 2**32.
2634 (check_depth): Now ptrdiff_t, not int.
2635 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2636 Adjust to new way of storing sizes. Check for size overflow bugs
2637 in rest of code.
2638 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2639 slightly wrong anyway, as it missed one instance of
2640 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2641 (refill_memory_reserve): Omit needless cast to size_t.
2642 (mark_object_loop_halt): Mark as externally visible.
2643
ac82cc6a
PE
2644 * xselect.c: Integer signedness and overflow fixes.
2645 (Fx_register_dnd_atom, x_handle_dnd_message):
2646 Use ptrdiff_t, not size_t, since we prefer signed.
2647 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2648 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2649 x_dnd_atoms_size and x_dnd_atoms_length.
2650
c2d1e36d
PE
2651 * doprnt.c: Prefer signed to unsigned when either works.
2652 * eval.c (verror):
2653 * doprnt.c (doprnt):
2654 * lisp.h (doprnt):
2655 * xdisp.c (vmessage):
2656 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2657 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2658 prefer signed arithmetic to avoid comparison confusion.
2659 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2660 but is a bit tricky.
2661
0e926e56
PE
2662 Assume freestanding C89 headers, string.h, stdlib.h.
2663 * data.c, doprnt.c, floatfns.c, print.c:
2664 Include float.h unconditionally.
2665 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2666 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2667 * regex.c: Likewise for stddef.h, string.h.
2668 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2669 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2670 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2671 (STDC_HEADERS): Remove obsolete defines.
2672 * sysdep.c: Include limits.h unconditionally.
2673
9cfdb3ec
PE
2674 Assume support for memcmp, memcpy, memmove, memset.
2675 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2676 * regex.c (memcmp, memcpy):
2677 Remove; we assume C89 now.
2678
2679 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2680 (__malloc_safe_bcopy): Remove; no longer needed.
2681
cf950e6b 2682 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2683 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2684 well either way, and we prefer signed to unsigned.
2685
dbf38e02
LMI
26862011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2687
2688 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2689 closes the connection while we're reading (bug#9182).
2690
d6f0886c 26912011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2692
d6f0886c
JD
2693 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2694 are specified (Bug#9168).
24e0f6b1 2695
2eb1f9e6
PE
26962011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2697
2698 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2699 Found by GCC static checking and --with-wide-int on a 32-bit host.
2700
22381272 27012011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2702
2703 * xdisp.c (compute_display_string_pos): Fix logic of caching
2704 previous display string position. Initialize cached_prev_pos to
2705 -1. Fixes slow-down at the beginning of a buffer.
2706
f25e39b4
EZ
27072011-07-24 Eli Zaretskii <eliz@gnu.org>
2708
2709 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2710 for attrs[LFACE_FONTSET_INDEX].
2711
04c4b52e
PE
27122011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2713
2714 * xml.c (parse_region): Remove unused local
2715 that was recently introduced.
2716
c1734fbd
EZ
27172011-07-23 Eli Zaretskii <eliz@gnu.org>
2718
be18c5a5
EZ
2719 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2720 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2721
c1734fbd
EZ
2722 * xdisp.c (move_it_in_display_line_to): Record the best matching
2723 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2724 exit if none of the characters scanned was an exact match.
2725 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2726 when exact match is impossible due to invisible text, and the
2727 lines are truncated.
2728
a258d627
JD
27292011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2730
2731 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2732 for OSX >= 10.7.
2733
b6d5a689
EZ
27342011-07-22 Eli Zaretskii <eliz@gnu.org>
2735
0f74f785
EZ
2736 Fix a significant slow-down of cursor motion with C-n, C-p,
2737 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2738 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2739 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2740 (next_element_from_buffer): Call compute_stop_pos_backwards to
2741 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2742 base_level_stop.
2743 (reseat): Don't look for prev_stop, as that could mean a very long
2744 run.
2745 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2746 <cached_disp_overlay_modiff>: Cache for last found display string
2747 position.
551918c1 2748 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2749 about the same buffer in the same area of character positions, and
2750 the buffer wasn't changed since the time the display string
2751 position was cached.
551918c1 2752
b2d0c91a
EZ
27532011-07-22 Eli Zaretskii <eliz@gnu.org>
2754
2755 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2756 is an integer, which is important for empty lines. (Bug#9149)
2757
043604ee
CY
27582011-07-22 Chong Yidong <cyd@stupidchicken.com>
2759
2760 * frame.c (Fmodify_frame_parameters): In tty case, update the
2761 default face if necessary (Bug#4238).
2762
da4adb04
CY
27632011-07-21 Chong Yidong <cyd@stupidchicken.com>
2764
2765 * editfns.c (Fstring_to_char): No need to explain what a character
2766 is in the docstring (Bug#6576).
2767
9abd0532
LMI
27682011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2769
2770 * xml.c (parse_region): Make sure we always return a tree.
2771
36881d16
HK
27722011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2773
2774 * xml.c (parse_region): If a document contains only comments,
2775 return that, too.
2776
1e98674d
LMI
27772011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2778
2779 * xml.c (make_dom): Return comments, too.
2780
590bd467
PE
27812011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2782
2783 Port to OpenBSD.
2784 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2785 and the surrounding thread.
2786 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2787 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2788 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2789 timer goes off.
2790 * s/openbsd.h (BROKEN_SIGIO): Define.
2791 * unexelf.c (unexec) [__OpenBSD__]:
2792 Don't update the .mdebug section of the Alpha COFF symbol table.
2793
f41628b2
LMI
27942011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2795
2796 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2797 (bug#8460).
2798
b59b67c5
PE
27992011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2800
15e3a074
PE
2801 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2802 This fixes some race conditions on the permissions of any newly
2803 created file.
2804
41bed37d
PE
2805 * alloc.c (valid_pointer_p): Use pipe, not open.
2806 This fixes some permissions issues when debugging.
2807
b59b67c5
PE
2808 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2809 If fchown fails to set both uid and gid, try to set just gid,
2810 as that is sometimes allowed. Adjust the file's mode to eliminate
2811 setuid or setgid bits that are inappropriate if fchown fails.
2812
925a6be7
SM
28132011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2814
2815 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2816 to compare Lisp_Objects.
2817 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2818 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2819 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2820
52968808
AS
28212011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2822
0a6a104b
AS
2823 * lread.c (read_integer): Unread even EOF character.
2824 (read1): Likewise. Properly record start position of symbol.
2825
52968808
AS
2826 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2827 symbol character follows.
2828
9e381cdd
PE
28292011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2830
2831 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2832 This works around a problem with the previous change to Fcopy_file.
2833 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2834 and without this change, GCC might complain about discarding
2835 fchown's return value.
2836
b5641435
JB
28372011-07-16 Juanma Barranquero <lekktu@gmail.com>
2838
2839 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2840
a8031457
PE
28412011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2842
2843 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2844
dd889327
LMI
28452011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2846
750c33f7
LMI
2847 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2848 it's used from the C level.
2849
dd889327
LMI
2850 * process.c: Use the same condition for POLL_FOR_INPUT in both
2851 keyboard.c and process.c (bug#1858).
2852
87e86684
LM
28532011-07-09 Lawrence Mitchell <wence@gmx.li>
2854
2855 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2856 (Fgnutls_boot): Use it.
2857
64348f40
AS
28582011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2859
2860 * doc.c (Fsubstitute_command_keys): Revert last change.
2861
1d698799
LMI
28622011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2863
f863868c
LMI
2864 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2865 quotes the next character, and doesn't affect other longer
2866 sequences (bug#8935).
2867
1d698799
LMI
2868 * lread.c (syms_of_lread): Clarify that is isn't only
2869 `eval-buffer' and `eval-defun' that's affected by
2870 `lexical-binding' (bug#8460).
2871
aa4b6df6
EZ
28722011-07-15 Eli Zaretskii <eliz@gnu.org>
2873
2874 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2875 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2876
5d856da6
PE
28772011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2878
ad6042bb
PE
2879 Fix minor problems found by static checking.
2880 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2881 (elsz): Now a signed constant, not a size_t var. We prefer signed
2882 types to unsigned, to avoid integer comparison confusion. Without
2883 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2884 "cannot optimize loop, the loop counter may overflow", a symptom
2885 of the confusion.
f00bbb22 2886 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2887 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2888
6468f31c
LMI
28892011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2890
49080b10
LMI
2891 * search.c (Fre_search_backward): Mention `case-fold-search' in
2892 all the re_search_* functions (bug#8138).
2893
6468f31c
LMI
2894 * keyboard.c (Fopen_dribble_file): Document when the file is
2895 closed (bug#8056).
2896
c965adc5
EZ
28972011-07-14 Eli Zaretskii <eliz@gnu.org>
2898
df9733bf
EZ
2899 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2900 bidi_cache_idx.
2901
0bb23927
EZ
2902 Support bidi reordering of display and overlay strings.
2903 * xdisp.c (compute_display_string_pos)
2904 (compute_display_string_end): Accept additional argument STRING.
2905 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2906 (reseat_to_string): Initialize bidi_it->string.s and
2907 bidi_it->string.schars.
2908 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2909 NULL (avoids a crash in bidi_paragraph_init).
2910 Initialize itb.string.lstring.
0bb23927
EZ
2911 (init_iterator): Call bidi_init_it only of a valid
2912 buffer position was specified. Initialize paragraph_embedding to
2913 L2R.
2914 (reseat_to_string): Initialize the bidi iterator.
2915 (display_string): If we need to ignore text properties of
2916 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2917 original value of -1 will not work with bidi.)
2918 (compute_display_string_pos): First arg is now struct
2919 `text_pos *'; all callers changed. Support display properties on
2920 Lisp strings.
2921 (compute_display_string_end): Support display properties on Lisp
2922 strings.
2923 (init_iterator, reseat_1, reseat_to_string): Initialize the
2924 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2925 when iterating on a string not from display properties).
640c8776
SM
2926 (compute_display_string_pos, compute_display_string_end):
2927 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2928 arrow keys.
2929 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2930 base_level_stop; instead, set base_level_stop to BEGV.
2931 Fixes crashes in vertical-motion.
0bb23927
EZ
2932 (next_element_from_buffer): Improve commentary for when
2933 the iterator is before prev_stop.
2934 (init_iterator): Initialize bidi_p from the default value of
2935 bidi-display-reordering, not from buffer-local value. Use the
2936 buffer-local value only if initializing for buffer iteration.
2937 (handle_invisible_prop): Support invisible properties on strings
2938 that are being bidi-reordered.
2939 (set_iterator_to_next): Support bidi reordering of C strings and
2940 Lisp strings.
2941 (next_element_from_string): Support bidi reordering of Lisp
2942 strings.
2943 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2944 (display_string): Support display of R2L glyph rows.
2945 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2946 (init_iterator): Don't initialize it->bidi_p for strings
2947 here.
2948 (reseat_to_string): Initialize it->bidi_p for strings here.
2949 (next_element_from_string, next_element_from_c_string)
2950 (next_element_from_buffer): Add xassert's for correspondence
2951 between IT's object being iterated and it->bidi_it.string
2952 structure.
2953 (face_before_or_after_it_pos): Support bidi iteration.
2954 (next_element_from_c_string): Handle the case of the first string
2955 character that is not the first one in the visual order.
2956 (get_visually_first_element): New function, refactored from common
2957 parts of next_element_from_buffer, next_element_from_string, and
2958 next_element_from_c_string.
2959 (tool_bar_lines_needed, redisplay_tool_bar)
2960 (display_menu_bar): Force left-to-right direction. Add a FIXME
2961 comment for making that be controlled by a user option.
2962 (push_it, pop_it): Save and restore the state of the
2963 bidi iterator. Save and restore the bidi_p flag.
2964 (pop_it): Iterate out of display property for string iteration as
2965 well.
2966 (iterate_out_of_display_property): Support iteration over strings.
2967 (handle_single_display_spec): Set up it->bidi_it for iteration
2968 over a display string, and call bidi_init_it.
2969 (handle_single_display_spec, next_overlay_string)
2970 (get_overlay_strings_1, push_display_prop): Set up the bidi
2971 iterator for displaying display or overlay strings.
2972 (forward_to_next_line_start): Don't use the shortcut if
2973 bidi-iterating.
2974 (back_to_previous_visible_line_start): If handle_display_prop
2975 pushed the iterator stack, restore the internal state of the bidi
2976 iterator by calling bidi_pop_it same number of times.
2977 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2978 and we are bidi-iterating, don't decrement the iterator position;
2979 instead, set the first_elt flag in the bidi iterator, to produce
2980 the same effect.
2981 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2982 (push_display_prop): xassert that we are iterating a buffer.
2983 (push_it, pop_it): Save and restore paragraph_embedding member.
2984 (handle_single_display_spec, next_overlay_string)
2985 (get_overlay_strings_1, reseat_1, reseat_to_string)
2986 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2987 correctly. Don't assume unibyte strings are not bidi-reordered.
2988 (compute_display_string_pos)
2989 (compute_display_string_end): Fix handling the case of C string.
2990 (push_it, pop_it): Save and restore from_disp_prop_p.
2991 (handle_single_display_spec, push_display_prop): Set the
2992 from_disp_prop_p flag.
2993 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2994 (pop_it): Call iterate_out_of_display_property only if we are
2995 popping after iteration over a string that came from a display
2996 property. Fix a typo in popping stretch info. Add an assertion
2997 for verifying that the iterator position is in sync with the bidi
2998 iterator.
2999 (handle_single_display_spec, get_overlay_strings_1)
3000 (push_display_prop): Fix initialization of paragraph direction for
3001 string when that of the parent object is not yet determined.
3002 (reseat_1): Call bidi_init_it to resync the bidi
3003 iterator with IT's position. (Bug#7616)
3004 (find_row_edges): If ROW->start.pos gives position
3005 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3006 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3007 Reset the from_disp_prop_p flag.
3008 (SAVE_IT, RESTORE_IT): New macros.
3009 (pos_visible_p, face_before_or_after_it_pos)
3010 (back_to_previous_visible_line_start)
3011 (move_it_in_display_line_to, move_it_in_display_line)
3012 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3013 (try_scrolling, redisplay_window, display_line): Use them when
3014 saving a temporary copy of the iterator and restoring it back.
3015 (back_to_previous_visible_line_start, reseat_1)
3016 (init_iterator): Empty the bidi cache "stack".
3017 (move_it_in_display_line_to): If iterator ended up at
3018 EOL, but we never saw any buffer positions smaller than
3019 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3020 motion in bidi-reordered lines.
3021 (move_it_in_display_line_to): Record prev_method and prev_pos
3022 immediately before the call to set_iterator_to_next. Fixes cursor
3023 motion in bidi-reordered lines with stretch glyphs and strings
3024 displayed in margins. (Bug#8133) (Bug#8867)
3025 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3026 TO_CHARPOS.
640c8776
SM
3027 (pos_visible_p): Support positions in bidi-reordered lines.
3028 Save and restore bidi cache.
0bb23927
EZ
3029
3030 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3031 (bidi_paragraph_info): Delete unused struct.
3032 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3033 (bidi_cache_start): New variable.
3034 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3035 to zero.
3036 (bidi_cache_fetch_state, bidi_cache_search)
3037 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3038 (bidi_cache_find, bidi_peek_at_next_level)
3039 (bidi_level_of_next_char, bidi_find_other_level_edge)
3040 (bidi_move_to_visually_next): Compare cache index with
3041 bidi_cache_start rather than with zero.
3042 (bidi_fetch_char): Accept new argument STRING; all callers
3043 changed. Support iteration over a string. Support strings with
3044 display properties. Support unibyte strings. Fix the type of
3045 `len' according to what STRING_CHAR_AND_LENGTH expects.
3046 (bidi_paragraph_init, bidi_resolve_explicit_1)
3047 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3048 (bidi_level_of_next_char, bidi_move_to_visually_next):
3049 Support iteration over a string.
0bb23927
EZ
3050 (bidi_set_sor_type, bidi_resolve_explicit_1)
3051 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3052 can now be zero (for strings); special values 0 and -1 were
3053 changed to -1 and -2, respectively.
3054 (bidi_char_at_pos): New function.
3055 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3056 Call it instead of FETCH_MULTIBYTE_CHAR.
3057 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3058 initialized to valid values.
3059 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3060 values.
3061 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3062 the test for valid cached positions. Fix the logic for looking up
3063 the sentinel state in the cache. GCPRO the Lisp string we are
3064 iterating.
3065 (bidi_push_it, bidi_pop_it): New functions.
3066 (bidi_initialize): Initialize the bidi cache start stack pointer.
3067 (bidi_cache_ensure_space): New function, refactored from part of
3068 bidi_cache_iterator_state. Don't assume the required size is just
3069 one BIDI_CACHE_CHUNK away.
3070 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3071 (bidi_count_bytes, bidi_char_at_pos): New functions.
3072 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3073 always valid if bidi_cache_idx is valid.
3074 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3075 is valid if it's going to be used.
3076 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3077 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3078 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3079 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3080 (bidi_find_other_level_edge, bidi_cache_start_stack):
3081 All variables related to cache indices are now EMACS_INT.
c965adc5 3082
0bb23927
EZ
3083 * dispextern.h (struct bidi_string_data): New structure.
3084 (struct bidi_it): New member `string'. Make flag members be 1-bit
3085 fields, and put them last in the struct.
640c8776
SM
3086 (compute_display_string_pos, compute_display_string_end):
3087 Update prototypes.
0bb23927
EZ
3088 (bidi_push_it, bidi_pop_it): Add prototypes.
3089 (struct iterator_stack_entry): New members bidi_p,
3090 paragraph_embedding, and from_disp_prop_p.
3091 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3092 (bidi_shelve_cache, bidi_unshelve_cache):
3093 Declare prototypes.
0bb23927
EZ
3094
3095 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3096 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3097 and vector-like objects.
3098
3099 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3100 cache around display iteration.
3101
3102 * window.c (Fwindow_end, window_scroll_pixel_based)
3103 (displayed_window_lines, Frecenter): Save and restore the bidi
3104 cache around display iteration.
3105
3bbd2265
LMI
31062011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3107
3108 * editfns.c (Fdelete_region): Clarify the use of the named
3109 parameters (bug#6788).
3110
adc47434
MR
31112011-07-14 Martin Rudalics <rudalics@gmx.at>
3112
3113 * indent.c (Fvertical_motion): Set and restore w->pointm when
3114 saving and restoring the window's buffer (Bug#9006).
3115
837c31f8
LMI
31162011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3117
3118 * editfns.c (Fstring_to_char): Clarify just what is returned
3119 (bug#6576). Text by Eli Zaretskii.
3120
ac389d0c
JB
31212011-07-13 Juanma Barranquero <lekktu@gmail.com>
3122
3123 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3124
0be0ce47
EZ
31252011-07-13 Eli Zaretskii <eliz@gnu.org>
3126
3127 * buffer.c (mmap_find): Fix a typo.
3128
cd18e7e3
JB
31292011-07-13 Johan Bockgård <bojohan@gnu.org>
3130
3131 Fix execution of x selection hooks.
3132 * xselect.c (Qx_lost_selection_functions)
3133 (Qx_sent_selection_functions): New vars.
3134 (syms_of_xselect): DEFSYM them.
3135 (x_handle_selection_request): Pass Qx_sent_selection_functions
3136 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3137 (x_handle_selection_clear,x_clear_frame_selections):
3138 Pass Qx_lost_selection_functions rather than
3139 Vx_lost_selection_functions to Frun_hook_with_args.
3140
47ea7f44
PE
31412011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3142
ac389d0c 3143 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3144 The old code sometimes used this field without initializing it.
3145
47ea7f44
PE
3146 * alloc.c (gc_sweep): Don't read past end of array.
3147 In theory, the old code could also have corrupted Emacs internals,
3148 though it'd be very unlikely.
3149
bc985c87
AS
31502011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3151
3152 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3153 argument. (Bug#4026)
bc985c87 3154
0cf34688
LMI
31552011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3156
b3dadd76
LMI
3157 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3158 key" (bug#4257).
3159
0cf34688
LMI
3160 * window.c (Fset_window_start): Doc fix (bug#4199).
3161 (Fset_window_hscroll): Ditto.
3162
270768cd
PE
31632011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3164
077e3dda 3165 Fix minor new problems caught by GCC 4.6.1.
270768cd 3166 * term.c (init_tty): Remove unused local.
490011a6 3167 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3168 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3169 not used otherwise.
270768cd 3170
b1f58454
CY
31712011-07-12 Chong Yidong <cyd@stupidchicken.com>
3172
3173 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3174
22b9578d
LMI
31752011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3176
6e70ab07
LMI
3177 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3178 are the mini-buffer and the echo area (bug#3320).
3179
22b9578d
LMI
3180 * term.c (init_tty): Remove support for supdup, c10 and perq
3181 terminals, which are no longer supported (bug#1482).
3182
8974cc9f
JB
31832011-07-10 Johan Bockgård <bojohan@gnu.org>
3184
3185 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3186
a560d974
JD
31872011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3188
3189 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3190 for non-popups (Bug#3642).
3191
1dae0f0a
AS
31922011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3193
268c2c36 3194 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3195 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3196 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3197 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3198 * data.c (fmod): Likewise.
3199 * dispnew.c (swap_glyphs_in_rows): Likewise.
3200 * emacs.c (memory_warning_signal): Likewise.
3201 * floatfns.c (float_error): Likewise.
3202 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3203 (otf_open, font_otf_capability, generate_otf_features)
3204 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3205 Likewise.
3206 * image.c (pbm_read_file): Likewise.
3207 * indent.c (string_display_width): Likewise.
3208 * intervals.c (check_for_interval, search_for_interval)
3209 (inc_interval_count, count_intervals, root_interval)
3210 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3211 * lread.c (defalias): Likewise.
268c2c36 3212 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3213 * regex.c (set_image_of_range_1, set_image_of_range)
3214 (regex_grow_registers): Likewise.
3215 * sysdep.c (strerror): Likewise.
3216 * termcap.c (valid_filename_p, tprint, main): Likewise.
3217 * tparam.c (main): Likewise.
3218 * unexhp9k800.c (run_time_remap, save_data_space)
3219 (update_file_ptrs, read_header, write_header, calculate_checksum)
3220 (copy_file, copy_rest, display_header): Likewise.
3221 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3222 Likewise.
3223 * xdisp.c (check_it): Likewise.
3224 * xfaces.c (register_color, unregister_color, unregister_colors):
3225 Likewise.
3226 * xfns.c (print_fontset_result): Likewise.
3227 * xrdb.c (member, fatal, main): Likewise.
3228
99033785
PE
32292011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3230
3231 Fix minor problems found by static checking (Bug#9031).
3232 * chartab.c (char_table_set_range, map_sub_char_table):
3233 Remove unused locals.
3234 (uniprop_table): Now static.
3235 * composite.c (_work_char): Remove unused static var.
3236
9cb2ac56
JB
32372011-07-09 Juanma Barranquero <lekktu@gmail.com>
3238
3239 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3240
f25661f0
JD
32412011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3242
3243 * gtkutil.c (qttip_cb): Remove code without function.
3244
8278c4fe
EZ
32452011-07-09 Eli Zaretskii <eliz@gnu.org>
3246
3247 * w32.c (pthread_sigmask): New stub.
3248
1692ae2d 32492011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3250
8a6ebd58 3251 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3252 sigprocmask is portable only for single-threaded applications, and
3253 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3254 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3255 (LIBES): Use it.
3256 * callproc.c (Fcall_process):
3257 * process.c (create_process):
3258 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3259 Use pthread_sigmask, not sigprocmask.
123403e4 3260
1b854618
JD
32612011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3262
3263 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3264 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3265 wrong (Bug#8591).
3266
3fe4b549
JD
32672011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3268
0ce7e563
JD
3269 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3270 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3271 (xg_hide_tooltip): Fix comment.
3272
3fe4b549
JD
3273 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3274 in registerServicesMenuSendTypes.
3275 (validRequestorForSendType): Don't check ns_return_types.
3276
3277 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3278 ns_return_type.
3279
5df75e47
JR
32802011-07-08 Jason Rumney <jasonr@gnu.org>
3281
22610910
JR
3282 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3283 SH_SHOW for hidden windows (Bug#5482).
3284
5df75e47
JR
3285 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3286 frame struct members of non-existent frames (Bug#6284).
3287
699c10bd
JD
32882011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3289
4393663b
JD
3290 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3291 variable firstTime not needed on OSX >= 10.6.
3292 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3293 >= 10.5. Use setKnobProportion, setDoubleValue.
3294
3295 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3296 (MAC_OS_X_VERSION_10_5): Define if not defined.
3297 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3298 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3299 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3300
3301 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3302 cString and lossyCString on OSX >= 10.4
3303
58179cce 3304 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3305 sizeToFit on OSX >= 10.2.
3306
3307 * nsimage.m (allocInitFromFile): Don't use deprecated method
3308 bestRepresentationForDevice on OSX >= 10.6.
3309
3310 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3311 to avoid warning.
3312
3313 * emacs.c: Declare unexec_init_emacs_zone.
3314
a63e0781
JD
3315 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3316
699c10bd
JD
3317 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3318
3319 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3320 on svcsMenu (Bug#8842).
3321
3322 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3323 ns_return_types.
3324 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3325
3326 * nsterm.m (QUTF8_STRING): Declare.
3327 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3328 (validRequestorForSendType): Return type is (id).
3329 Change indexOfObjectIdenticalTo to indexOfObject.
3330 Check if we have local selection before returning self (Bug#8842).
3331 (writeSelectionToPasteboard): Put local selection into paste board
3332 if we have a local selection (Bug#8842).
3333 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3334
3335 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3336 (ns_get_local_selection): Declare.
3337
54e10184
LMI
33382011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3339
9888ff71
LMI
3340 * keymap.c (describe_map_tree): Don't insert a double newline at
3341 the end of the buffer (bug#1169) and return whether we inserted
3342 something.
3343
54e10184
LMI
3344 * callint.c (Fcall_interactively): Change "reading args" to
3345 "providing args" to try to clarify what it does (bug#1010).
3346
15fa4783
KH
33472011-07-07 Kenichi Handa <handa@m17n.org>
3348
3349 * composite.c (composition_compute_stop_pos): Ignore a static
3350 composition starting before CHARPOS (Bug#8915).
3351
3352 * xdisp.c (handle_composition_prop): Likewise.
3353
a8815b00
EZ
33542011-07-07 Eli Zaretskii <eliz@gnu.org>
3355
3356 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3357 (Bug#9015)
3358
ef7b981d 33592011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3360
3361 * character.h (unicode_category_t): New enum type.
3362
3363 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3364 (Qchar_code_property_table): New variable.
3365 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3366 (UNIPROP_COMPRESSED_FORM_P): New macros.
3367 (char_table_ascii): Uncompress the compressed values.
3368 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3369 Uncompress the compressed values.
ac389d0c 3370 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3371 (char_table_ref_and_range): Uncompress the compressed values.
3372 (sub_char_table_set): New arg is_uniprop. Callers changed.
3373 Uncompress the compressed values.
3374 (sub_char_table_set_range): Args changed. Callers changed.
3375 (char_table_set_range): Adjuted for the above change.
3376 (map_sub_char_table): Delete args default_val and parent. Add arg
3377 top. Give decoded values to a Lisp function.
640c8776 3378 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3379 values to a Lisp function. Gcpro more variables.
3380 (uniprop_table_uncompress)
3381 (uniprop_decode_value_run_length): New functions.
3382 (uniprop_decoder, uniprop_decoder_count): New variables.
3383 (uniprop_get_decoder, uniprop_encode_value_character)
3384 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3385 New functions.
3386 (uniprop_encoder, uniprop_encoder_count): New variables.
3387 (uniprop_get_encoder, uniprop_table)
3388 (Funicode_property_table_internal, Fget_unicode_property_internal)
3389 (Fput_unicode_property_internal): New functions.
3390 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3391 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3392 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3393 char-code-property-alist.
3394
640c8776 3395 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3396 Vunicode_category_table.
3397
640c8776 3398 * font.c (font_range): Adjust for the change of
c805dec0
KH
3399 Vunicode_category_table.
3400
76b397fb
DN
34012011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3402
3403 * m/iris4d.h: Remove file, move contents ...
3404 * s/irix6-5.h: ... here.
3405
22b4128e
PE
34062011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3407
3408 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3409 * alloc.c (mark_buffer):
3410 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3411 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3412 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3413 This isn't true in general, and it's particularly not true
3414 if Emacs is configured with --with-wide-int.
3415 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3416 New macros, used in the buffer.c change.
3417
869795d6
JD
34182011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3419
3420 * xsettings.c: Use both GConf and GSettings if both are available.
3421 (store_config_changed_event): Add comment.
3422 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3423 (store_tool_bar_style_changed): New functions.
5e617bc2 3424 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3425 (struct xsettings): Move font inside HAVE_XFT.
3426 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3427 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3428 Move inside HAVE_XFT.
640c8776 3429 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3430 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3431 also.
3432 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3433 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3434 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3435 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3436 (parse_settings): Move check for font inside HAVE_XFT.
3437 (read_settings, apply_xft_settings): Add comment.
3438 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3439 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3440 call store_font_name_changed.
3441 (xft_settings_event): Add comment.
3442 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3443 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3444 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3445 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3446 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3447 (xsettings_get_system_font, xsettings_get_system_normal_font):
3448 Add comment.
869795d6 3449
d8ed26bd
PE
34502011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3451
3452 Random fixes. E.g., (random) never returned negative values.
3453 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3454 subseconds part to the entropy, as that's a bit more random.
3455 Prefer signed to unsigned, since the signedness doesn't matter and
3456 in general we prefer signed. When given a limit, use a
3457 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3458 latter isn't right if USE_2_TAGS_FOR_INTS.
3459 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3460 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3461
cabf1cac
SM
34622011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3463
3464 * textprop.c (text_property_stickiness):
3465 Obey Vtext_property_default_nonsticky.
3466 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3467 * w32fns.c (syms_of_w32fns):
3468 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3469
6e9b2be9
PE
34702011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3471
3472 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3473 This is more efficient than Ffile_directory_p and avoids a minor race.
3474
90186c68
LMI
34752011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3476
7c301272
LMI
3477 * buffer.c (Foverlay_put): Say what the return value is
3478 (bug#7835).
3479
c4f2d8d4
LMI
3480 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3481 is a directory before asking whether to use the file name
3482 (bug#7564).
ad637907
LMI
3483 (barf_or_query_if_file_exists): Make the "File is a directory"
3484 error be more correct.
c4f2d8d4 3485
90186c68
LMI
3486 * fns.c (Frequire): Remove the mention of the .gz files, since
3487 that's installation-specific, but keep the mention of
3488 `get-load-suffixes'.
3489
da64016e
PE
34902011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3491
3492 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3493 Report string overflow if the output is too long.
3494
7d47b580
JB
34952011-07-04 Juanma Barranquero <lekktu@gmail.com>
3496
a555cb87
JB
3497 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3498 (syms_of_gnutls): Remove duplicate DEFSYM for
3499 Qgnutls_bootprop_verify_hostname_error, an error for
3500 Qgnutls_bootprop_verify_error (which is no longer used).
3501
7d47b580
JB
3502 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3503 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3504 Also (re)move comments that are misplaced or no longer relevant.
3505
1e49bfab
LMI
35062011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3507
3508 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3509
1485f4c0
CY
35102011-07-03 Chong Yidong <cyd@stupidchicken.com>
3511
3512 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3513 and background color parameters if they have been changed.
3514
a9ab721e
LMI
35152011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3516
3517 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3518
cf7cff57
PE
35192011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3520
2e13213d
PE
3521 * xsettings.c (SYSTEM_FONT): Define only when used.
3522 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3523
cf7cff57
PE
3524 * keymap.c (access_keymap_1): Now static.
3525
7a8e04f7
CY
35262011-07-02 Chong Yidong <cyd@stupidchicken.com>
3527
3528 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3529 leave any prefix arg for the up event (Bug#1586).
3530
61352f62
LMI
35312011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3532
69bb1ef7
LMI
3533 * lread.c (syms_of_lread): Mention single symbols defined by
3534 `defvar' or `defconst' (bug#7154).
3535
61352f62 3536 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3537 (Frequire): Mention get-load-suffixes.
61352f62 3538
28545e04
MR
35392011-07-02 Martin Rudalics <rudalics@gmx.at>
3540
3541 * window.h (window): Remove clone_number slot.
3542 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3543 Remove.
3544 (make_parent_window, make_window, saved_window)
3545 (Fset_window_configuration, save_window_save): Don't deal with
3546 clone numbers.
3547 * buffer.c (Qclone_number): Remove declaration.
3548 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3549
3349e122
SM
35502011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3551
3552 Add multiple inheritance to keymaps.
3553 * keymap.c (Fmake_composed_keymap): New function.
3554 (Fset_keymap_parent): Simplify.
3555 (fix_submap_inheritance): Remove.
3556 (access_keymap_1): New function extracted from access_keymap to handle
3557 embedded parents and handle lists of maps.
3558 (access_keymap): Use it.
3559 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3560 (Fcopy_keymap): Handle embedded parents.
3561 (Fcommand_remapping, define_as_prefix): Simplify.
3562 (Fkey_binding): Simplify.
3563 (syms_of_keymap): Move minibuffer-local-completion-map,
3564 minibuffer-local-filename-completion-map,
3565 minibuffer-local-must-match-map, and
3566 minibuffer-local-filename-must-match-map to Elisp.
3567 (syms_of_keymap): Defsubr make-composed-keymap.
3568 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3569 (parse_menu_item): Trivial simplification.
3570
3279eb87
GM
35712011-07-01 Glenn Morris <rgm@gnu.org>
3572
3573 * Makefile.in (SETTINGS_LIBS): Fix typo.
3574
4550efdf
KI
35752011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3576
3577 * coding.c (Fencode_coding_string): Record the last coding system
3578 used, as the function doc string says (bug#8738).
3579
0949d2b6
JD
35802011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3581
3582 * xsettings.c (store_monospaced_changed): Take new font as arg and
3583 check for change against current_mono_font.
3584 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3585 (emacs_settings_constructor, emacs_settings_get_property)
3586 (emacs_settings_set_property, emacs_settings_class_init)
3587 (emacs_settings_init, gsettings_obj): Remove.
3588 (something_changedCB): New function for HAVE_GSETTINGS.
3589 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3590 with value as argument.
3591 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3592 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3593 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3594 "changed".
3595
3596 * xgselect.c: Add defined (HAVE_GSETTINGS).
3597 (xgselect_initialize): Ditto.
3598
3599 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3600 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3601 xg_select.
3602
bbc6b304
PE
36032011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3604
3605 * eval.c (struct backtrace): Simplify and port the data structure.
3606 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3607 signed bit field, as this assumption is not portable and it makes
3608 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3609 "char debug_on_exit : 1" as this is not portable either; instead,
3610 use the portable "unsigned int debug_on_exit : 1". Remove unused
3611 member evalargs. Remove obsolete comments about cc bombing out.
3612
9851bfc5
JD
36132011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3614
51bb811f 3615 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3616 Let HAVE_GSETTINGS override HAVE_GCONF.
3617 (store_monospaced_changed): New function.
3618 (EMACS_SETTINGS): A new type derived from GObject to handle
3619 GSettings notifications.
3620 (emacs_settings_constructor, emacs_settings_get_property)
3621 (emacs_settings_set_property, emacs_settings_class_init):
3622 New functions.
3623 (gsettings_client, gsettings_obj): New variables.
3624 (GSETTINGS_SCHEMA): New define.
3625 (something_changedCB): Call store_monospaced_changed.
3626 (init_gsettings): New function.
3627 (xsettings_initialize): Call init_gsettings.
3628 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3629 to NULL.
3630
640c8776 3631 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3632 GCONF_CFLAGS/LIBS.
3633
5386012d
MR
36342011-06-29 Martin Rudalics <rudalics@gmx.at>
3635
3636 * window.c (resize_root_window, grow_mini_window)
3637 (shrink_mini_window): Rename Qresize_root_window to
3638 Qwindow_resize_root_window and Qresize_root_window_vertically to
3639 Qwindow_resize_root_window_vertically.
3640
f13e0b08
PE
36412011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3642
3643 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3644
94515237
JB
36452011-06-27 Juanma Barranquero <lekktu@gmail.com>
3646
3647 * makefile.w32-in: Redesign dependencies so they reflect more
3648 clearly which files are directly included by each source file,
3649 and not through other includes.
3650
e43b6e43
MR
36512011-06-27 Martin Rudalics <rudalics@gmx.at>
3652
3653 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3654 (sort_overlays, overlay_strings): When an overlay's clone number
3655 matches the window's clone number process the overlay even if
3656 the overlay's window property doesn't match the current window.
3657
d68443dc
MR
3658 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3659 (Fwindow_hchild): Rename to Fwindow_left_child.
3660 (Fwindow_next): Rename to Fwindow_next_sibling.
3661 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3662 (resize_window_check): Rename to window_resize_check.
3663 (resize_window_apply): Rename to window_resize_apply.
3664 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3665 (Fdelete_other_windows_internal, resize_frame_windows)
3666 (Fsplit_window_internal, Fdelete_window_internal)
3667 (grow_mini_window, shrink_mini_window)
3668 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3669
c7e73be5
JD
36702011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3671
3672 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3673 (emacs_fixed_set_min_size): Remove.
3674 (emacs_fixed_new): Take frame as argument.
3675
3676 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3677 (_EmacsFixedPrivate): Remove minwidth/height.
3678 Add struct frame *f.
3679 (emacs_fixed_init): Initialize priv->f.
3680 (get_parent_class, emacs_fixed_set_min_size): Remove.
3681 (emacs_fixed_new): Set priv->f to argument.
3682 (emacs_fixed_get_preferred_width)
3683 (emacs_fixed_get_preferred_height): Use min_width/height from
3684 frames size_hint to set minimum and natural (Bug#8919).
3685 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3686 and use min_width/height from frames size_hint to set
3687 min_width/height (Bug#8919).
3688
3689 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3690 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3691 Fix indentation.
c7e73be5 3692
cf99dcf8
EZ
36932011-06-26 Eli Zaretskii <eliz@gnu.org>
3694
3695 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3696 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3697 called at ZV.
3698
029529ac
CY
36992011-06-26 Chong Yidong <cyd@stupidchicken.com>
3700
3701 * process.c (wait_reading_process_output): Bypass select if
3702 waiting for a cell while ignoring keyboard input, and input is
3703 pending. Suggested by Jan Djärv (Bug#8869).
3704
7a7ef429
PE
37052011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3706
3707 Use gnulib's dup2 module instead of rolling our own.
3708 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3709
11fdef7d 37102011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3711
3712 * dispnew.c (scrolling_window): Before scrolling, turn off a
3713 mouse-highlight in the window being scrolled.
3714
cd3520a4
JB
37152011-06-24 Juanma Barranquero <lekktu@gmail.com>
3716
3717 Move DEFSYM to lisp.h and use everywhere.
3718
3719 * character.h (DEFSYM): Move declaration...
3720 * lisp.h (DEFSYM): ...here.
3721
3722 * gnutls.c:
3723 * minibuf.c:
3724 * w32menu.c:
3725 * w32proc.c:
3726 * w32select.c: Don't include character.h.
3727
3728 * alloc.c (syms_of_alloc):
3729 * buffer.c (syms_of_buffer):
3730 * bytecode.c (syms_of_bytecode):
3731 * callint.c (syms_of_callint):
3732 * casefiddle.c (syms_of_casefiddle):
3733 * casetab.c (init_casetab_once):
3734 * category.c (init_category_once, syms_of_category):
3735 * ccl.c (syms_of_ccl):
3736 * cmds.c (syms_of_cmds):
3737 * composite.c (syms_of_composite):
3738 * dbusbind.c (syms_of_dbusbind):
3739 * dired.c (syms_of_dired):
3740 * dispnew.c (syms_of_display):
3741 * doc.c (syms_of_doc):
3742 * editfns.c (syms_of_editfns):
3743 * emacs.c (syms_of_emacs):
3744 * eval.c (syms_of_eval):
3745 * fileio.c (syms_of_fileio):
3746 * fns.c (syms_of_fns):
3747 * frame.c (syms_of_frame):
3748 * fringe.c (syms_of_fringe):
3749 * insdel.c (syms_of_insdel):
3750 * keymap.c (syms_of_keymap):
3751 * lread.c (init_obarray, syms_of_lread):
3752 * macros.c (syms_of_macros):
3753 * msdos.c (syms_of_msdos):
3754 * print.c (syms_of_print):
3755 * process.c (syms_of_process):
3756 * search.c (syms_of_search):
3757 * sound.c (syms_of_sound):
3758 * syntax.c (init_syntax_once, syms_of_syntax):
3759 * terminal.c (syms_of_terminal):
3760 * textprop.c (syms_of_textprop):
3761 * undo.c (syms_of_undo):
3762 * w32.c (globals_of_w32):
3763 * window.c (syms_of_window):
3764 * xdisp.c (syms_of_xdisp):
3765 * xfaces.c (syms_of_xfaces):
3766 * xfns.c (syms_of_xfns):
3767 * xmenu.c (syms_of_xmenu):
3768 * xsettings.c (syms_of_xsettings):
3769 * xterm.c (syms_of_xterm): Use DEFSYM.
3770
4228cf16
TZ
37712011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3772
cd3520a4 3773 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3774
7fcccf1e
PE
37752011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3776
7efb4e0e
PE
3777 Integer and buffer overflow fixes (Bug#8873).
3778
ff5844ad
PE
3779 * print.c (printchar, strout): Check for string overflow.
3780 (PRINTPREPARE, printchar, strout):
3781 Don't set size unless allocation succeeds.
3782
90532f02
PE
3783 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3784 for sizes. Check for string overflow more accurately.
3785 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3786
6d84508d
PE
3787 * macros.c: Integer and buffer overflow fixes.
3788 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3789 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3790 Use ptrdiff_t, not int, for sizes.
3791 Don't increment bufsize until after realloc succeeds.
3792 Check for size-calculation overflow.
3793 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3794
437b2cb4
PE
3795 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3796
8b9ac8b4
PE
3797 * lread.c: Integer overflow fixes.
3798 (read_integer): Radix is now EMACS_INT, not int,
3799 to improve quality of diagnostics for out-of-range radices.
3800 Calculate buffer size correctly for out-of-range radices.
3801 (read1): Check for integer overflow in radices, and in
3802 read-circle numbers.
82cb60d3
PE
3803 (read_escape): Avoid int overflow.
3804 (Fload, openp, read_buffer_size, read1)
3805 (substitute_object_recurse, read_vector, read_list, map_obarray):
3806 Use ptrdiff_t, not int, for sizes.
3807 (read1): Use EMACS_INT, not int, for sizes.
20270765 3808 Check for size overflow.
8b9ac8b4 3809
7fcccf1e
PE
3810 * image.c (cache_image): Check for size arithmetic overflow.
3811
bfbbd7e7
PE
3812 * lread.c: Integer overflow issues.
3813 (saved_doc_string_size, saved_doc_string_length)
3814 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3815 Now ptrdiff_t, not int.
3816 (read1): Don't assume doc string length fits in int. Check for
3817 out-of-range doc string lengths.
3818 (read_list): Don't assume file position fits in int.
39019e54 3819 (read_escape): Check for hex character overflow.
bfbbd7e7 3820
4e323265
LL
38212011-06-22 Leo Liu <sdl.web@gmail.com>
3822
3823 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3824 Move to minibuffer.el.
3825
85fece3e
PE
38262011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3827
20b84ce9 3828 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3829 The following patches are for when GLYPH_DEBUG && !XASSERT.
3830 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3831 * dispnew.c (flush_stdout):
3832 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3833 Mark as externally visible.
3834 * dispnew.c (check_window_matrix_pointers): Now static.
3835 * dispnew.c (window_to_frame_vpos):
3836 * xfns.c (unwind_create_frame):
3837 * xterm.c (x_check_font): Remove unused local.
3838 * scroll.c (CHECK_BOUNDS):
3839 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3840 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3841 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3842 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3843 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3844 Now static.
3845 (debug_method_add): Use va_list and vsprintf rather than relying
3846 on undefined behavior with wrong number of arguments.
3847 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3848 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3849 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3850 since we're not interested in debugging glyphs with old libraries.
3851 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3852 GCC 4.6.0's static checking.
3853
0766b489
PE
38542011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3855
31fd4b32
PE
3856 Integer overflow and signedness fixes (Bug#8873).
3857 A few related buffer overrun fixes, too.
3858
b79e8648
PE
3859 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3860
0766b489
PE
3861 * dispextern.h (struct face.stipple):
3862 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3863 (x_bitmap_mask, x_allocate_bitmap_record)
3864 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3865 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3866 (x_create_bitmap_from_xpm_data):
3867 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3868 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3869 (.bitmaps_last):
3870 * xfaces.c (load_pixmap):
3871 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3872 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3873 (.bitmaps_last, struct x_output.icon_bitmap):
3874 Use ptrdiff_t, not int, for bitmap indexes.
3875 (x_allocate_bitmap_record): Check for size overflow.
3876 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3877
b081724f
PE
3878 Use ptrdiff_t, not int, for overlay counts.
3879 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3880 * editfns.c (overlays_around, get_pos_property):
3881 * textprop.c (get_char_property_and_overlay):
3882 * xdisp.c (next_overlay_change, note_mouse_highlight):
3883 * xfaces.c (face_at_buffer_position):
21514da7
PE
3884 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3885 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3886 (Fnext_overlay_change, Fprevious_overlay_change)
3887 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3888 Use ptrdiff_t, not int, for sizes.
21514da7 3889 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3890
3de73e5e
PE
3891 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3892
2606c57b
PE
3893 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3894 (x_session_initialize): Do not assume string length fits in int.
3895
aaafe47a
PE
3896 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3897 This is unlikely, but can occur if DPI is outlandish.
3898
2674ddc8 3899 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3900 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3901
28154962
PE
3902 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3903 * xrdb.c (magic_file_p, search_magic_path):
3904 Omit last arg SUFFIX; it was always 0. All callers changed.
3905 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3906
7de51af5
PE
3907 * xfont.c (xfont_match): Avoid need for strlen.
3908
25ed6cc3
PE
3909 * xfns.c: Don't assume strlen fits in int.
3910 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3911
4eab31dd
PE
3912 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3913 not unsigned long, as we prefer signed integers. All callers changed.
3914 Detect integer overflow in repeat count.
3915 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3916 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3917
171e2a58
PE
3918 * termcap.c: Don't assume sizes fit in int and never overflow.
3919 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3920 (gobble_line): Check for size-calculation overflow.
3921
ad39faca 3922 * minibuf.c (Fread_buffer):
6e5bb2dc 3923 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3924 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3925 Don't assume string length fits in int.
3926
52c61c22 3927 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3928 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3929
b5b8c9e5
PE
3930 * font.c: Don't assume string length fits in int.
3931 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3932 Use ptrdiff_t, not int.
ccd6111c
PE
3933 (font_intern_prop): Don't assume string length fits in int.
3934 Don't assume integer property fits in fixnum.
3935 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3936
882f0d81 3937 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3938 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3939 Reformulate so as not to need the command string.
3940 Invoke gzip -cd rather than gunzip, as it's more portable.
3941 (lock_info_type, lock_file_1, lock_file):
3942 Don't assume pid_t and time_t fit in unsigned long.
3943 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3944 (current_lock_owner): Prefer signed type for sizes.
3945 Use memcpy, not strncpy, where memcpy is what is really wanted.
3946 Don't assume (via atoi) that time_t and pid_t fit in int.
3947 Check for time_t and/or pid_t out of range, e.g., via a network share.
3948 Don't alloca where an auto var works fine.
3949
93f4cf88
PE
3950 * fileio.c: Fix some integer overflow issues.
3951 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3952 Don't assume string length fits in int.
3953 (directory_file_name): Don't assume string length fits in long.
3954 (make_temp_name): Don't assume pid fits in int, or that its print
3955 length is less than 20.
3956
f3e92b69
PE
3957 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3958
1bfdaf10
PE
3959 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3960
35016e9a
PE
3961 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3962
3d1e65a1
PE
3963 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3964 We prefer signed integers, even for size calculations.
3965
0b963a93
PE
3966 * emacs.c: Don't assume string length fits in 'int'.
3967 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3968 (main): Don't invoke strlen when not needed.
3969
573f4b54
PE
3970 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3971 (XD_DEBUG_MESSAGE): Don't waste a byte.
3972
989f33ba
PE
3973 * callproc.c (getenv_internal_1, getenv_internal)
3974 (Fgetenv_internal):
965d34eb
PE
3975 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3976
e4d29b33
PE
3977 * lread.c (invalid_syntax): Omit length argument.
3978 All uses changed. This doesn't fix a bug, but it simplifies the
3979 code away from its former Hollerith-constant appearance, and it's
3980 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3981 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3982
eb49b136
PE
3983 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3984 This didn't break anything, but it didn't help either.
3985 It's confusing to put a bogus integer in a place where the actual
3986 value does not matter.
9f62aeb1 3987 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3988 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3989
15375a22
PE
3990 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3991 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3992 implementation.
b61cc01c
PE
3993 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3994 We prefer signed types, and the value cannot exceed the EMACS_INT
3995 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3996 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3997 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3998 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3999
53b2623d
PE
4000 * indent.c (sane_tab_width): New function.
4001 (current_column, scan_for_column, Findent_to, position_indentation)
4002 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4003 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4004
51cab52b 4005 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4006
f2ed8a70
PE
4007 * lisp.h (lint_assume): New macro.
4008 * composite.c (composition_gstring_put_cache):
4009 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4010
abe80cc6
PE
4011 * editfns.c, insdel.c:
4012 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4013
b02c740e
PE
4014 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4015
ebc96716
PE
4016 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4017
b4e50fa0 4018 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4019 Use much-faster test for byte-length change.
311d5d7c 4020 Don't assume string byte-length fits in 'int'.
a4cf38e4 4021 Check that character arg fits in 'int'.
85461888 4022 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4023
c0c1ee9f
PE
4024 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4025
a498d7f4
PE
4026 * fns.c (concat): Catch string overflow earlier.
4027 Do not rely on integer wraparound.
4028
51cab52b
PE
4029 * dispextern.h (struct it.overlay_strings_charpos)
4030 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4031 * xdisp.c (forward_to_next_line_start)
4032 (back_to_previous_visible_line_start)
4033 (reseat_at_next_visible_line_start, next_element_from_buffer):
4034 Don't arbitrarily truncate the value of 'selective' to int.
4035
76031fad
PE
4036 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4037
5eb55db9
PE
4038 * composite.c: Don't truncate sizes to 'int'.
4039 (composition_gstring_p, composition_reseat_it)
4040 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4041 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4042 not EMACS_UINT, for indexes.
5eb55db9 4043
0703a717
PE
4044 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4045
d6202519
PE
4046 * buffer.c: Include <verify.h>.
4047 (struct sortvec.priority, struct sortstr.priority):
8961a454 4048 Now EMACS_INT, not int.
c20998a7 4049 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4050 (struct sortstr.size, record_overlay_string)
4051 (struct sortstrlist.size, struct sortlist.used):
4052 Don't truncate size to int.
4053 (record_overlay_string): Check for size-calculation overflow.
d6202519 4054 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4055
d5a19415
JM
40562011-06-22 Jim Meyering <meyering@redhat.com>
4057
029529ac 4058 Don't leak an XBM-image-sized buffer
d5a19415
JM
4059 * image.c (xbm_load): Free the image buffer after using it.
4060
a9041e6c
PE
40612011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4062
4063 Port to Sun C.
4064 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4065 that Sun C diagnosed.
4066 * fns.c (secure_hash): Fix pointer signedness issue.
4067 * intervals.c (static_offset_intervals): New function.
4068 (offset_intervals): Use it.
4069
7f3f739f
LL
40702011-06-21 Leo Liu <sdl.web@gmail.com>
4071
4072 * deps.mk (fns.o):
4073 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4074 sha512.h.
4075
4076 * fns.c (secure_hash): Rename from crypto_hash_function and change
4077 the first arg to accept symbols.
5b66d427 4078 (Fsecure_hash): New primitive.
7f3f739f
LL
4079 (syms_of_fns): New symbols.
4080
76147d94
DD
40812011-06-20 Deniz Dogan <deniz@dogan.se>
4082
4083 * process.c (Fset_process_buffer): Clarify return value in
4084 docstring.
4085
7d7d0045
CY
40862011-06-18 Chong Yidong <cyd@stupidchicken.com>
4087
4088 * dispnew.c (add_window_display_history): Use BVAR.
4089
4090 * xdisp.c (debug_method_add): Use BVAR.
4091 (check_window_end, dump_glyph_matrix, dump_glyph)
4092 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4093
4094 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4095 Likewise.
4096
4097 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4098 check till after the cache is created in init_frame_faces.
4099
ff2bc410
SM
41002011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4101
4102 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4103
28177add
PE
41042011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4105
dd3482fe
PE
4106 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4107 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4108 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4109
393d71f3 4110 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4111 * fileio.c (Finsert_file_contents):
4112 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4113 Remove the old (too-loose) buffer overflow checks.
4114 They weren't needed, since make_gap checks for buffer overflow.
4115 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4116 The old code merely checked for Emacs fixnum overflow, and relied
4117 on undefined (wraparound) behavior. The new code avoids undefined
4118 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4119
2e6813b0 4120 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4121 Tune. Don't use wider integers than needed. Don't use alloca.
4122 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4123
599a9e4f
PE
4124 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4125
99561444
PE
4126 * insdel.c, lisp.h (buffer_overflow): New function.
4127 (insert_from_buffer_1, replace_range, replace_range_2):
4128 * insdel.c (make_gap_larger):
4129 * editfns.c (Finsert_char):
4130 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4131
28177add
PE
4132 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4133
e69dafad
PE
41342011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4135
a7af7fde 4136 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4137
b1c46f02
PE
4138 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4139 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4140
e69dafad
PE
4141 * fileio.c: Don't assume EMACS_INT fits in off_t.
4142 (emacs_lseek): New static function.
4143 (Finsert_file_contents, Fwrite_region): Use it.
4144 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4145
566684ea
PE
4146 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4147
e6966cd6
PE
4148 * fns.c: Don't overflow int when computing a list length.
4149 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4150 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4151 truncation on 64-bit hosts. Check for QUIT every
4152 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4153 faster and is responsive enough.
4154 (Flength): Report an error instead of overflowing an integer.
4155 (Fsafe_length): Return a float if the value is not representable
4156 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4157 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4158 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4159
dd0b0efb
PE
4160 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4161 (header_size, word_size): New constants.
4162 (allocate_vectorlike): Don't check size overflow here.
4163 (allocate_vector): Check it here instead, since this is the only
4164 caller of allocate_vectorlike that could cause overflow.
4165 Check that the new vector's length is representable as a fixnum.
4166
86fe5cfe
PE
4167 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4168 The previous code was bogus. For example, next_almost_prime (32)
4169 returned 39, which is undesirable as it is a multiple of 3; and
4170 next_almost_prime (24) returned 25, which is a multiple of 5 so
4171 why was the code bothering to check for multiples of 7?
4172
80e88859
PE
4173 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4174
4a2f0ad6
PE
4175 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4176
f66c7cf8
PE
4177 Variadic C functions now count arguments with ptrdiff_t.
4178 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4179 Back then I didn't know that the Emacs coding style prefers signed int.
4180 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4181 were being counted with int, which may truncate counts on 64-bit
4182 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4183 * lisp.h (struct Lisp_Subr.function.aMANY)
4184 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4185 Arg counts are now ptrdiff_t, not size_t.
4186 All variadic functions and their callers changed accordingly.
4187 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4188 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4189 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4190 * callint.c (Fcall_interactively): Check arg count for overflow,
4191 to avoid potential buffer overrun. Use signed char, not 'int',
4192 for 'varies' array, so that we needn't bother to check its size
4193 calculation for overflow.
4194 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4195 * eval.c (apply_lambda):
4196 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4197 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4198 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4199
a1759b76
PE
4200 * callint.c (Fcall_interactively): Don't use index var as event count.
4201
d96be9fc
PE
4202 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4203 * mem-limits.h (SIZE): Remove; no longer used.
4204
a690a978 4205 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4206
578c21e6
PE
4207 Remove unnecessary casts.
4208 * xterm.c (x_term_init):
4209 * xfns.c (x_set_border_pixel):
4210 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4211 These aren't needed now that we assume ANSI C.
4212
96f53c6c
PE
4213 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4214 It's more likely to cause problems (due to unsigned overflow)
4215 than to cure them.
4216
83c77d31
PE
4217 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4218
ee2079f1
PE
4219 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4220
6da65536
PE
4221 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4222
7147c4a4
PE
4223 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4224
193e32d9
PE
4225 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4226
e5533da6
PE
4227 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4228
9910e595
PE
4229 GLYPH_CODE_FACE returns EMACS_INT, not int.
4230 * dispextern.h (merge_faces):
4231 * xfaces.c (merge_faces):
01103c44
PE
4232 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4233 Don't assume EMACS_INT fits in int.
9910e595 4234
2638320e
PE
4235 * character.h (CHAR_VALID_P): Remove unused parameter.
4236 * fontset.c, lisp.h, xdisp.c: All uses changed.
4237
045eb8d9
PE
4238 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4239
c1f134b5
PE
4240 * fns.c (concat): Minor tuning based on overflow analysis.
4241 This doesn't fix any bugs. Use int to hold character, instead
4242 of constantly refetching from Emacs object. Use XFASTINT, not
4243 XINT, for value known to be a character. Don't bother comparing
4244 a single byte to 0400, as it's always less.
4245
395fcb93 4246 * floatfns.c (Fexpt):
327eeec8
PE
4247 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4248
abbd3d23
PE
4249 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4250 for characters.
4251
684a03ef
PE
4252 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4253
0fed43f3
PE
4254 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4255 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4256 incorrectly succeed when S was a string, because 4294967386 was
4257 truncated before it was used.
4258
8fd02eb7
PE
4259 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4260 Otherwise, an out-of-range integer could cause undefined behavior
4261 on a 64-bit host.
4262
f8c86b69
PE
4263 * composite.c: Use int, not EMACS_INT, for characters.
4264 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4265 EMACS_INT, for values that are known to be in character range.
4266 This doesn't fix any bugs but is the usual style inside Emacs and
4267 may generate better code on 32-bit machines.
4268
34206dd2
PE
4269 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4270 This is for reasons similar to the recent CHAR_STRING fix.
4271 * charset.c (Fencode_char): Check that character arg is actually
4272 a character. Pass an int to ENCODE_CHAR.
4273 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4274 wider than 'int', as a compile-time check to prevent future regressions
4275 in this area.
4276
c5958d4c 4277 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4278
4279 Make sure a 64-bit char is never passed to CHAR_STRING.
4280 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4281 by silently ignoring the top 32 bits, allowing some values
4282 that were far too large to be valid characters.
4283 * character.h: Include <verify.h>.
4284 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4285 arguments are no wider than unsigned, as a compile-time check
4286 to prevent future regressions in this area.
4287 * data.c (Faset):
01103c44 4288 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4289 (Fsubst_char_in_region):
4290 * fns.c (concat):
4291 * xdisp.c (decode_mode_spec_coding):
4292 Adjust to CHAR_STRING's new requirement.
4293 * editfns.c (Finsert_char, Fsubst_char_in_region):
4294 * fns.c (concat): Check that character args are actually
4295 characters. Without this test, these functions did the wrong
4296 thing with wildly out-of-range values on 64-bit hosts.
4297
d37ca623
PE
4298 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4299 These casts should not be needed on 32-bit hosts, either.
4300 * keyboard.c (read_char):
4301 * lread.c (Fload): Remove casts to unsigned.
4302
ea204efb
PE
4303 * lisp.h (UNSIGNED_CMP): New macro.
4304 This fixes comparison bugs on 64-bit hosts.
4305 (ASCII_CHAR_P): Use it.
4306 * casefiddle.c (casify_object):
01103c44 4307 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4308 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4309 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4310 * dispextern.h (FACE_FROM_ID):
4311 * keyboard.c (read_char): Use UNSIGNED_CMP.
4312
41cb286c
PE
4313 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4314 not to EMACS_INT, to avoid GCC warning.
4315
4a1b9832
PE
4316 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4317
55daad71
PE
4318 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4319 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4320 isn't needed on 32-bit machines.
8f95c75c 4321
01103c44
PE
4322 * buffer.c (Fgenerate_new_buffer_name):
4323 Use EMACS_INT for count, not int.
0ceccced 4324 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4325
4326 * data.c (Qcompiled_function): Now static.
4327
c6f072e7
PE
4328 * window.c (window_body_lines): Now static.
4329
20ce5912
PE
4330 * image.c (gif_load): Rename local to avoid shadowing.
4331
9c4c5f81
PE
4332 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4333 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4334 * alloc.c (make_save_value): Integer argument is now of type
4335 ptrdiff_t, not int.
4336 (mark_object): Use ptrdiff_t, not int.
4337 * lisp.h (pD): New macro.
4338 * print.c (print_object): Use it.
4339
c0c5c8ae
PE
4340 * alloc.c: Use EMACS_INT, not int, to count objects.
4341 (total_conses, total_markers, total_symbols, total_vector_size)
4342 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4343 (total_free_floats, total_floats, total_free_intervals)
4344 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4345 Now EMACS_INT, not int. All uses changed.
4346 (Fgarbage_collect): Compute overall total using a double, so that
4347 integer overflow is less likely to be a problem. Check for overflow
4348 when converting back to an integer.
5a25e253
PE
4349 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4350 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4351 These were 'int' variables that could overflow on 64-bit hosts;
4352 they were never used, so remove them instead of repairing them.
211a0b2a 4353 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4354 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4355 Previously, this ceilinged at INT_MAX, but that doesn't work on
4356 64-bit machines.
e46bb31a 4357 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4358
c78baabf 4359 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4360 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4361 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4362 when a (possibly-narrower) signed value would do just as well.
4363 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4364
c9d624c6
PE
4365 * alloc.c: Catch some string size overflows that we were missing.
4366 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4367 for convenience in STRING_BYTES_MAX.
4368 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4369 The definition here is exact; the one in lisp.h was approximate.
4370 (allocate_string_data): Check for string overflow. This catches
4371 some instances we weren't catching before. Also, it catches
4372 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4373 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4374 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4375
c9d624c6
PE
4376 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4377 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4378 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4379
353032ce
PE
4380 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4381
2bccce07
PE
4382 * alloc.c (Fmake_string): Check for out-of-range init.
4383
0ac30604
SM
43842011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4385
4386 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4387
c195f2de
JD
43882011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4389
4390 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4391 xg_get_default_scrollbar_width.
4392
4393 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4394 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4395 (style_changed_cb): Call update_theme_scrollbar_width and call
4396 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4397 all frames (Bug#8505).
4398 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4399 Call gtk_window_set_resizable if HAVE_GTK3.
4400 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4401 and height if HAVE_GTK3 (Bug#8505).
4402 (scroll_bar_width_for_theme): New variable.
4403 (update_theme_scrollbar_width): New function.
4404 (xg_get_default_scrollbar_width): Move code to
4405 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4406 (xg_initialize): Call update_theme_scrollbar_width.
4407
4408 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4409
4410 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4411
e10ac9f1
MR
44122011-06-12 Martin Rudalics <rudalics@gmx.at>
4413
4414 * frame.c (make_frame): Call other_buffer_safely instead of
4415 other_buffer.
4416
4417 * window.c (temp_output_buffer_show): Call display_buffer with
4418 second argument Vtemp_buffer_show_specifiers and reset latter
4419 immediately after the call.
4420 (Vtemp_buffer_show_specifiers): New variable.
4421 (auto_window_vscroll_p, next_screen_context_lines)
4422 (Vscroll_preserve_screen_position): Remove leading asterisks from
4423 doc-strings.
4424
2d3c217e 44252011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4426
7b7f97e8 4427 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4428 * buffer.c (Qclone_number): Remove for now, as it's unused.
4429 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4430 (record_buffer): Remove unused local.
4431 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4432 (set_frame_buffer_list): Remove; unused.
4433 * frame.h (other_visible_frames): Remove decl.
4434 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4435 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4436 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4437 if HAVE_GPM.
4438 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4439 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4440 Define only if HAVE_GPM.
4441 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4442 (update_hints_inhibit): Remove; never set. All uses removed.
4443 * widgetprv.h (emacsFrameClassRec): Remove decl.
4444 * window.c (delete_deletable_window): Now returns void, since it
4445 wasn't returning anything.
4446 (compare_window_configurations): Remove unused locals.
4447 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4448 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4449 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4450 the same widths as pointers. This follows up on the 2011-05-06 patch.
4451 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4452 * xterm.h: Likewise.
4453 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4454
1384b89e
JB
44552011-06-12 Juanma Barranquero <lekktu@gmail.com>
4456
4457 * makefile.w32-in: Update dependencies.
4458 (LISP_H): Add lib/intprops.h.
4459
1100a63c
CY
44602011-06-11 Chong Yidong <cyd@stupidchicken.com>
4461
4462 * image.c (gif_load): Add animation frame delay to the metadata.
4463 (syms_of_image): Use DEFSYM. New symbol `delay'.
4464
6198ccd0
MR
44652011-06-11 Martin Rudalics <rudalics@gmx.at>
4466
4467 * window.c (delete_deletable_window): Re-add.
4468 (Fset_window_configuration): Rewrite to handle dead buffers and
4469 consequently deletable windows.
4470 (window_tree, Fwindow_tree): Remove. Supply functionality in
4471 window.el.
4472 (compare_window_configurations): Simplify code.
4473
b6e3633c
AS
44742011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4475
1ab0dee5
AS
4476 * image.c (imagemagick_load_image): Fix type mismatch.
4477 (Fimagemagick_types): Likewise.
4478
b6e3633c
AS
4479 * window.h (replace_buffer_in_windows): Declare.
4480
9397e56f
MR
44812011-06-11 Martin Rudalics <rudalics@gmx.at>
4482
4483 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4484 Qclone_number. Remove external declaration of Qdelete_window.
4485 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4486 code.
640c8776
SM
4487 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4488 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4489 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4490 buffer list implementation.
4491 (other_buffer_safely): New function.
4492 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4493 calls to replace_buffer_in_windows and
4494 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4495 if allowed.
4496 (record_buffer): Inhibit quitting and rewrite using quittable
4497 functions. Run Qbuffer_list_update_hook if allowed.
4498 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4499 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4500 Move switch-to-buffer to window.el.
9397e56f
MR
4501 (bury-buffer): Move to window.el.
4502 (Vbuffer_list_update_hook): New variable.
4503
4504 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4505 section.
4506
4507 * window.h (resize_frame_windows): Move up in code.
4508 (Fwindow_frame): Remove EXFUN.
4509 (replace_buffer_in_all_windows): Remove prototype.
4510 (replace_buffer_in_windows_safely): Add prototype.
4511
4512 * window.c: Declare Qdelete_window static again. Move down
4513 declaration of select_count.
4514 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4515 (Fother_window): Move to window.el.
4516 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4517 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4518 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4519 window.el.
4520 (replace_buffer_in_windows): Implement by calling
4521 Qreplace_buffer_in_windows.
4522 (replace_buffer_in_all_windows): Remove with some functionality
4523 moved into replace_buffer_in_windows_safely.
4524 (replace_buffer_in_windows_safely): New function.
4525 (select_window_norecord, select_frame_norecord): Move in front
4526 of run_window_configuration_change_hook. Remove now obsolete
4527 declarations.
640c8776
SM
4528 (Fset_window_buffer): Rewrite doc-string.
4529 Call Qrecord_window_buffer.
9397e56f
MR
4530 (keys_of_window): Move binding for other-window to window.el.
4531
b50691aa
CY
45322011-06-11 Chong Yidong <cyd@stupidchicken.com>
4533
4534 * dispextern.h (struct image): Replace data member, whose int_val
4535 and ptr_val fields were not used by anything, with a single
4536 lisp_val object.
4537
4538 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4539 (gif_clear_image, gif_load, imagemagick_load_image)
4540 (gs_clear_image, gs_load): Callers changed.
4541
3f754b86
PE
45422011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4543
cca69397
PE
4544 * buffer.h: Include <time.h>, for time_t.
4545 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4546
109e28d0
PE
4547 Fix minor problems found by static checking.
4548
60737f02
PE
4549 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4550
4b66faf3
PE
4551 Make identifiers static if they are not used in other modules.
4552 * data.c (Qcompiled_function, Qframe, Qvector):
4553 * image.c (QimageMagick, Qsvg):
4554 * minibuf.c (Qmetadata):
4555 * window.c (resize_window_check, resize_root_window): Now static.
4556 * window.h (resize_window_check, resize_root_window): Remove decls.
4557
109e28d0
PE
4558 * window.c (window_deletion_count, delete_deletable_window):
4559 Remove; unused.
46a4ce9e
PE
4560 (window_body_lines): Now static.
4561 (Fdelete_other_windows_internal): Mark vars as initialized.
4562 Make sure 'resize_failed' is initialized.
4563 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4564 (resize_window_apply): Remove unused local.
4565 * window.h (delete_deletable_window): Remove decl.
4566
109e28d0 4567 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4568 (imagemagick_load_image): Fix pointer signedness problem by changing
4569 last arg from unsigned char * to char *. All uses changed.
4570 Also, fix a local for similar reasons.
4571 Remove unused locals. Remove locals to avoid shadowing.
4572 (fn_rsvg_handle_free): Remove; unused.
4573 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4574 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4575
3f754b86
PE
4576 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4577
2547adb1
CY
45782011-06-10 Chong Yidong <cyd@stupidchicken.com>
4579
4580 * image.c (gif_load): Fix omitted cast error introduced by
4581 2011-06-06 change.
4582
2c8e37d4
MR
45832011-06-10 Martin Rudalics <rudalics@gmx.at>
4584
4585 * window.h (resize_proportionally, orig_total_lines)
4586 (orig_top_line): Remove from window structure.
4587 (set_window_height, set_window_width, change_window_heights)
4588 (Fdelete_window): Remove prototypes.
4589 (resize_frame_windows): Remove duplicate declaration.
4590
440a42e3
EZ
45912011-06-10 Eli Zaretskii <eliz@gnu.org>
4592
4593 * window.h (resize_frame_windows, resize_window_check)
4594 (delete_deletable_window, resize_root_window)
4595 (resize_frame_windows): Declare prototypes.
4596
4597 * window.c (resize_window_apply): Make definition be "static" to
4598 match the prototype.
4599
562dd5e9
MR
46002011-06-10 Martin Rudalics <rudalics@gmx.at>
4601
4602 * window.c: Remove declarations of Qwindow_size_fixed,
4603 window_min_size_1, window_min_size_2, window_min_size,
4604 size_window, window_fixed_size_p, enlarge_window, delete_window.
4605 Remove static from declaration of Qdelete_window, it's
4606 temporarily needed by Fbury_buffer.
4607 (replace_window): Don't assign orig_top_line and
4608 orig_total_lines.
4609 (Fdelete_window, delete_window): Remove. Window deletion is
4610 handled by window.el.
640c8776
SM
4611 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4612 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4613 (Fdelete_other_windows): Remove. Deleting other windows is
4614 handled by window.el.
4615 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4616 handled in window.el.
4617 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4618 Window minimum sizes are handled in window.el.
4619 (shrink_windows, size_window, set_window_height)
4620 (set_window_width, change_window_heights, window_height)
4621 (window_width, CURBEG, CURSIZE, enlarge_window)
4622 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4623 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4624 handled in window.el.
4625 (make_dummy_parent): Rename to make_parent_window and give it a
4626 second argument horflag.
4627 (make_window): Don't set resize_proportionally any more.
4628 (Fsplit_window): Remove. Windows are split in window.el.
4629 (save_restore_action, save_restore_orig_size)
4630 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4631 Resize mini windows in window.el.
4632 (grow_mini_window, shrink_mini_window): Implement by calling
4633 Qresize_root_window_vertically, resize_window_check and
4634 resize_window_apply.
640c8776
SM
4635 (saved_window, Fset_window_configuration, save_window_save):
4636 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4637 resize_proportionally.
4638 (window_min_height, window_min_width): Move to window.el.
4639 (keys_of_window): Move bindings for delete-other-windows,
4640 split-window, delete-window and enlarge-window to window.el.
4641
4642 * buffer.c: Temporarily extern Qdelete_window.
4643 (Fbury_buffer): Temporarily call Qdelete_window instead of
4644 Fdelete_window (Fbury_buffer will move to window.el soon).
4645
4646 * frame.c (set_menu_bar_lines_1): Remove code handling
4647 orig_top_line and orig_total_lines.
4648
4649 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4650 set_window_height but set heights directly.
4651 (change_frame_size_1): Use resize_frame_windows.
4652
4653 * xdisp.c (init_xdisp): Don't use set_window_height but set
4654 heights directly.
4655
640c8776
SM
4656 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4657 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4658 run_window_configuration_change_hook.
4659
4660 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4661 instead of change_window_heights and run
4662 run_window_configuration_change_hook.
4663
1a13852e
MR
46642011-06-09 Martin Rudalics <rudalics@gmx.at>
4665
4666 * window.c (replace_window): Rename second argument REPLACEMENT to
4667 NEW. New third argument SETFLAG. Rewrite.
4668 (delete_window, make_dummy_parent): Call replace_window with
4669 third argument 1.
4670 (window_list_1): Move down in code.
4671 (run_window_configuration_change_hook): Move set_buffer part
4672 before select_frame_norecord part in order to unwind correctly.
4673 Rename count1 to count.
4674 (recombine_windows, delete_deletable_window, resize_root_window)
4675 (Fdelete_other_windows_internal)
4676 (Frun_window_configuration_change_hook, make_parent_window)
4677 (resize_window_check, resize_window_apply, Fresize_window_apply)
4678 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4679 (Fdelete_window_internal, Fresize_mini_window_internal):
4680 New functions.
1a13852e
MR
4681 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4682
f3d1777e
MR
46832011-06-08 Martin Rudalics <rudalics@gmx.at>
4684
496e208e
MR
4685 * window.h (window): Add some new members to window structure -
4686 normal_lines, normal_cols, new_total, new_normal, clone_number,
4687 splits, nest, prev_buffers, next_buffers.
4688 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4689 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4690
f3d1777e
MR
4691 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4692 Remove.
496e208e
MR
4693 (make_dummy_parent): Set new members of windows structure.
4694 (make_window): Move down in code. Handle new members of window
4695 structure.
4696 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4697 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4698 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4699 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4700 (Fset_window_next_buffers, Fset_window_clone_number):
4701 New functions.
496e208e
MR
4702 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4703 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4704 Doc-string fixes.
4705 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4706 Argument WINDOW can be now internal window too.
4707 (Fwindow_use_time): Move up in code.
4708 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4709 Rewrite doc-string.
4710 (Fset_window_configuration, saved_window)
4711 (Fcurrent_window_configuration, save_window_save): Handle new
4712 members of window structure.
b9e809c2
MR
4713 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4714 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4715 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4716 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4717 Qget_mru_window, Qresize_root_window,
4718 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4719 Qauto_buffer_name; staticpro them.
f3d1777e 4720
abde8f8c
MR
47212011-06-07 Martin Rudalics <rudalics@gmx.at>
4722
4723 * window.c (Fwindow_total_size, Fwindow_left_column)
4724 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4725 (Fwindow_list_1): New functions.
4726 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4727 (Fwindow_width, Fscroll_left, Fscroll_right):
4728 Use window_body_cols instead of window_box_text_cols.
4729 (delete_window, Fset_window_configuration):
4730 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4731 (delete_all_subwindows): Take a window as argument and not a
4732 structure. Rewrite.
190b47e6
MR
4733 (window_loop): Remove handling of GET_LRU_WINDOW and
4734 GET_LARGEST_WINDOW.
4735 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4736
4737 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4738 window_box_text_cols. delete_all_subwindows now takes a
4739 Lisp_Object as argument.
abde8f8c 4740
640c8776
SM
4741 * indent.c (compute_motion, Fcompute_motion):
4742 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4743
fa8a67e6
MR
4744 * frame.c (delete_frame): Call delete_all_subwindows with root
4745 window as argument.
4746
a54e3482
DC
47472011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4748
4749 * fns.c (Fputhash): Document return value.
4750
60002bf5
CY
47512011-06-06 Chong Yidong <cyd@stupidchicken.com>
4752
4753 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4754
0c671da6 47552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4756
b862a52a 4757 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4758
be44ca6c
PE
4759 Check for overflow when converting integer to cons and back.
4760 * charset.c (Fdefine_charset_internal, Fdecode_char):
4761 Use cons_to_unsigned to catch overflow.
4762 (Fencode_char): Use INTEGER_TO_CONS.
4763 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4764 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4765 * data.c (long_to_cons, cons_to_long): Remove.
4766 (cons_to_unsigned, cons_to_signed): New functions.
4767 These signal an error for invalid or out-of-range values.
4768 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4769 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4770 * font.c (Ffont_variation_glyphs):
4771 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4772 * lisp.h: Include <intprops.h>.
4773 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4774 (cons_to_signed, cons_to_unsigned): New decls.
4775 (long_to_cons, cons_to_long): Remove decls.
4776 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4777 (Fprimitive_undo): Use CONS_TO_INTEGER.
4778 * xfns.c (Fx_window_property): Likewise.
4779 * xselect.c: Include <limits.h>.
4780 (x_own_selection, selection_data_to_lisp_data):
4781 Use INTEGER_TO_CONS.
4782 (x_handle_selection_request, x_handle_selection_clear)
4783 (x_get_foreign_selection, Fx_disown_selection_internal)
4784 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4785 (lisp_data_to_selection_data): Use cons_to_unsigned.
4786 (x_fill_property_data): Use cons_to_signed.
4787 Report values out of range.
4788
d1f3d2af
PE
4789 Check for buffer and string overflow more precisely.
4790 * buffer.h (BUF_BYTES_MAX): New macro.
4791 * lisp.h (STRING_BYTES_MAX): New macro.
4792 * alloc.c (Fmake_string):
4793 * character.c (string_escape_byte8):
4794 * coding.c (coding_alloc_by_realloc):
4795 * doprnt.c (doprnt):
4796 * editfns.c (Fformat):
4797 * eval.c (verror):
4798 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4799 since they may not be the same number.
4800 * editfns.c (Finsert_char):
4801 * fileio.c (Finsert_file_contents):
4802 Likewise for BUF_BYTES_MAX.
4803
dd52fcea
PE
4804 * image.c: Use ptrdiff_t, not int, for sizes.
4805 (slurp_file): Switch from int to ptrdiff_t.
4806 All uses changed.
4807 (slurp_file): Check that file size fits in both size_t (for
4808 malloc) and ptrdiff_t (for sanity and safety).
4809
7f9bbdbb
PE
4810 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4811 if b->modtime has its maximal value.
4812
dfe18f82
PE
4813 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4814
84acfcf0
PE
4815 Don't assume time_t can fit into int.
4816 * buffer.h (struct buffer.modtime): Now time_t, not int.
4817 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4818 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4819
ccd9a01a
PE
4820 Minor fixes for signed vs unsigned integers.
4821 * character.h (MAYBE_UNIFY_CHAR):
4822 * charset.c (maybe_unify_char):
4823 * keyboard.c (read_char, reorder_modifiers):
4824 XINT -> XFASTINT, since the integer must be nonnegative.
4825 * ftfont.c (ftfont_spec_pattern):
4826 * keymap.c (access_keymap, silly_event_symbol_error):
4827 XUINT -> XFASTINT, since the integer must be nonnegative.
4828 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4829 since it makes no difference and we prefer signed.
4830 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4831 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4832 nonnegative.
4833
d6d100dd
SM
48342011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4835
4836 * window.h (Fwindow_frame): Declare.
4837
2b6148e4
PE
48382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4839
4840 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4841 (SPARE_MEMORY): Always define.
4842 (LARGE_REQUEST): Remove.
4843 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4844
f230ecc9
MR
48452011-06-06 Martin Rudalics <rudalics@gmx.at>
4846
727e958e
MR
4847 * lisp.h: Move EXFUNS for Fframe_root_window,
4848 Fframe_first_window and Fset_frame_selected_window to window.h.
4849
4850 * window.h: Move EXFUNS for Fframe_root_window,
4851 Fframe_first_window and Fset_frame_selected_window here from
4852 lisp.h.
4853
4854 * frame.c (Fwindow_frame, Fframe_first_window)
4855 (Fframe_root_window, Fframe_selected_window)
4856 (Fset_frame_selected_window): Move to window.c.
4857 (Factive_minibuffer_window): Move to minibuf.c.
4858 (Fother_visible_frames_p): New function.
4859
4860 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4861
f230ecc9
MR
4862 * window.c (decode_window, decode_any_window): Move up in code.
4863 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4864 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4865 (Fwindow_buffer): Move up and rewrite doc-string.
4866 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4867 (Fwindow_prev): New functions.
727e958e
MR
4868 (Fwindow_frame): Move here from frame.c. Accept any window as
4869 argument.
4870 (Fframe_root_window, Fframe_first_window)
4871 (Fframe_selected_window): Move here from frame.c. Accept frame
4872 or arbitrary window as argument. Update doc-strings.
4873 (Fminibuffer_window): Move up in code.
4874 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4875 (Fset_frame_selected_window): Move here from frame.c.
4876 Marginal rewrite.
727e958e
MR
4877 (Fselected_window, select_window, Fselect_window): Move up in
4878 code. Minor doc-string fixes.
f230ecc9 4879
4d09bcf6
PE
48802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4881
4882 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4883 Do not assume that spare memory exists; that assumption is valid
4884 only if SYSTEM_MALLOC.
4885 (LARGE_REQUEST): New macro, so that the issue of large requests
4886 is separated from the issue of spare memory.
4887
810928a2
AS
48882011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4889
172418ad
AS
4890 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4891 format. (Bug#8806)
4892
43f862f7
AS
4893 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4894
810928a2
AS
4895 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4896 before statements.
4897
a059fe24
JD
48982011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4899
4900 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4901
4902 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4903
4904 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4905 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4906
989bf368
JB
49072011-06-05 Juanma Barranquero <lekktu@gmail.com>
4908
4909 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4910
4b80f674
CY
49112011-06-04 Chong Yidong <cyd@stupidchicken.com>
4912
4913 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4914 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4915 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4916 New error handlers.
4b80f674
CY
4917 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4918 Obey Vx_select_enable_clipboard_manager. Catch errors in
4919 x_clipboard_manager_save (Bug#8779).
4920 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4921 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4922
99a33b77 49232011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4924
4925 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4926
99a33b77 49272011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4928
4929 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4930 in the current matrix if keep_current_p is non-zero.
4931
8264569d
EZ
49322011-06-04 Eli Zaretskii <eliz@gnu.org>
4933
4934 * bidi.c (bidi_level_of_next_char): Fix last change.
4935
57f97249
EZ
49362011-06-03 Eli Zaretskii <eliz@gnu.org>
4937
fec2107c 4938 Support bidi reordering of text covered by display properties.
57f97249 4939
fec2107c
EZ
4940 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4941 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4942 (bidi_cache_search, bidi_cache_iterator_state)
4943 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4944 (bidi_level_of_next_char, bidi_move_to_visually_next):
4945 Support character positions inside a run of characters covered by a
fec2107c
EZ
4946 display string.
4947 (bidi_paragraph_init, bidi_resolve_explicit_1)
4948 (bidi_level_of_next_char): Call bidi_fetch_char and
4949 bidi_fetch_char_advance instead of FETCH_CHAR and
4950 FETCH_CHAR_ADVANCE.
4951 (bidi_init_it): Initialize new members.
4952 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4953 definitions.
4954 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4955 instead of using explicit *_CHAR codes.
d6d100dd
SM
4956 (bidi_resolve_explicit, bidi_resolve_weak):
4957 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4958 bidirectional text is supported only in multibyte buffers.
4959 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4960 it to initialize the frame_window_p member of struct bidi_it.
4961 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4962 (bidi_resolve_explicit, bidi_resolve_weak)
4963 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4964 bidi_it->nchars is non-positive.
4965 (bidi_level_of_next_char): Don't try to lookup the cache for the
4966 next/previous character if nothing is cached there yet, or if we
4967 were just reseat()'ed to a new position.
c40e2fb2 4968
0e14fe90
EZ
4969 * xdisp.c (set_cursor_from_row): Set start and stop points
4970 according to the row's direction when priming the loop that looks
4971 for the glyph on which to display cursor.
4972 (single_display_spec_intangible_p): Function deleted.
4973 (display_prop_intangible_p): Reimplement to call
4974 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4975 Accept 3 additional arguments needed by handle_display_spec.
4976 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4977 values: lists, `(when COND...)' forms, etc.
4978 (single_display_spec_string_p): Support property values that are
4979 lists with the argument STRING its top-level element.
4980 (display_prop_string_p): Fix the condition for processing a
4981 property that is a list to be consistent with handle_display_spec.
fec2107c 4982 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4983 last portion of handle_display_prop.
4984 (compute_display_string_pos): Accept additional argument
4985 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4986 value of a `display' property is a "replacing spec".
4987 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4988 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4989 the display property, but just return a value indicating whether
4990 the display property will replace the characters it covers.
4991 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4992 frame_window_p members of struct bidi_it.
d6d100dd
SM
4993 (compute_display_string_pos, compute_display_string_end):
4994 New functions.
fec2107c
EZ
4995 (push_it): Accept second argument POSITION, where pop_it should
4996 jump to continue iteration.
4997 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4998
fec2107c
EZ
4999 * keyboard.c (adjust_point_for_property): Adjust the call to
5000 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5001
5002 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5003 (bidi_init_it): Update prototypes.
5004 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5005 (compute_display_string_pos, compute_display_string_end):
5006 Declare prototypes.
fec2107c
EZ
5007 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5008 EMACS_INT.
fc6f18ce 5009
40087514 50102011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5011
57f53182
PE
5012 Malloc failure behavior now depends on size of allocation.
5013 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5014 * lisp.h: Change signatures accordingly.
5015 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5016 All callers changed. (Bug#8762)
5017
5018 * gnutls.c: Use Emacs's memory allocators.
5019 Without this change, the gnutls library would invoke malloc etc.
5020 directly, which causes problems on non-SYNC_INPUT hosts, and which
5021 runs afoul of improving memory_full behavior. (Bug#8761)
5022 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5023 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5024 xfree instead of the default malloc, realloc, free.
5025 (Fgnutls_boot): No need to check for memory allocation failure,
5026 since xmalloc does that for us.
5027
ac32cd99 5028 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5029 * category.c (hash_get_category_set):
5030 * ccl.c (ccl_driver):
5031 * charset.c (Fdefine_charset_internal):
5032 * charset.h (struct charset.hash_index):
5033 * composite.c (get_composition_id, gstring_lookup_cache)
5034 (composition_gstring_put_cache):
5035 * composite.h (struct composition.hash_index):
5036 * dispextern.h (struct image.hash):
5037 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5038 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5039 (hashfn_equal, hashfn_user_defined, make_hash_table)
5040 (maybe_resize_hash_table, hash_lookup, hash_put)
5041 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5042 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5043 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5044 * image.c (make_image, search_image_cache, lookup_image)
5045 (xpm_put_color_table_h):
5046 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5047 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5048 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5049 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5050 * alloc.c (allocate_vectorlike):
5051 Check for overflow in vector size calculations.
5052 * ccl.c (ccl_driver):
5053 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5054 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5055 need to be updated by these changes.
40087514
PE
5056 * fns.c (make_hash_table, maybe_resize_hash_table):
5057 Check for integer overflow with large hash tables.
0de4bb68
PE
5058 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5059 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5060 (SXHASH_REDUCE): New macro.
5061 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5062 Use it instead of discarding useful hash info with large hash values.
5063 (sxhash_float): New function.
5064 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5065 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5066 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5067 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5068 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5069 Adjust signatures to match updated version of code.
5070 (consing_since_gc): Now EMACS_INT, since a single hash table can
5071 use more than INT_MAX bytes.
5072
698d32e2
DN
50732011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5074
5075 Make it possible to build with GCC-4.6+ -O2 -flto.
5076
5077 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5078
fd6fa53f
SM
50792011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5080
5081 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5082 Call minibuffer-inactive-mode.
5083
864db017
JB
50842011-05-31 Juanma Barranquero <lekktu@gmail.com>
5085
5086 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5087 Update dependencies.
5088
2ad0baf4
DN
50892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5090
5091 * data.c (init_data): Remove code for UTS, this system is not
5092 supported anymore.
5093
4fcc2638
DN
50942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5095
5096 Don't force ./temacs to start in terminal mode.
5097
5098 * frame.c (make_initial_frame): Initialize faces in all cases, not
5099 only when CANNOT_DUMP is defined.
5100 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5101
c56e0fd5
DN
51022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5103
5104 * dispnew.c (add_window_display_history): Use const for the string
5105 pointer. Remove declaration, not needed.
5106
333d54da 51072011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5108
55d4c1b2 5109 Use 'inline', not 'INLINE'.
333d54da 5110 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5111 * alloc.c, fontset.c (INLINE): Remove.
5112 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5113 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5114 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5115 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5116 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5117
738db178
DN
51182011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5119
5120 Make it possible to run ./temacs.
5121
5122 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5123 syms_of_callproc does the same thing. Remove test for
5124 "initialized", do it in the caller.
5125 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5126
620c53a6
SM
51272011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5128
5129 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5130 (read_minibuf): Use get_minibuffer.
5131 (syms_of_minibuf): Use DEFSYM.
5132 (Qmetadata): New var.
5133 * data.c (Qbuffer): Don't make it static.
5134 (syms_of_data): Use DEFSYM.
5135
e003a292
PE
51362011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5137
5138 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5139 (CCL_CODE_MIN): New macro.
5140
ed008a6d
PE
51412011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5142
3687c2ef
PE
5143 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5144
ed008a6d
PE
5145 * eval.c (Qdebug): Now static.
5146 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5147 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5148 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5149
d66c4c7c
CY
51502011-05-29 Chong Yidong <cyd@stupidchicken.com>
5151
5152 * image.c: Various fixes to ImageMagick code comments.
5153 (Fimagemagick_types): Doc fix.
5154
5fbc2025
PE
51552011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5156
0196f88a
PE
5157 Minor fixes prompted by GCC 4.6.0 warnings.
5158
5159 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5160
5fbc2025
PE
5161 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5162 (x_clipboard_manager_save_all): Move extern decl to ...
5163 * xterm.h: ... here, so that it can be checked for consistency.
5164
1dd3c2d9
CY
51652011-05-29 Chong Yidong <cyd@stupidchicken.com>
5166
5167 * xselect.c (x_clipboard_manager_save_frame)
5168 (x_clipboard_manager_save_all): New functions.
5169 (Fx_clipboard_manager_save): Lisp function deleted.
5170
5171 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5172 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5173
5174 * xterm.h: Update prototype.
5175
5ba6571d
WX
51762011-05-28 William Xu <william.xwl@gmail.com>
5177
5178 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5179 exiting (Bug#8239).
5180
3eaff834
JM
51812011-05-28 Jim Meyering <meyering@redhat.com>
5182
e1900994 5183 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5184 * fns.c (to_uchar): Define.
5185 (crypto_hash_function): Use it to convert some newly-signed
5186 variables to unsigned, to avoid sign-extension bugs. For example,
5187 without this change, (md5 "truc") would evaluate to
5188 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5189 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5190 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5191
0f6990a7
PE
51922011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5193
5194 Integer overflow fixes.
c8a9ca5a 5195
08686060
PE
5196 * dbusbind.c: Serial number integer overflow fixes.
5197 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5198 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5199 to hold a serial number that is too large for a fixnum.
5200 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5201 Check for serial numbers out of range. Decode any serial number
59568bf0 5202 that was so large that it became a float. (Bug#8722)
08686060 5203
2d1fc3c7
PE
5204 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5205 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5206 Use XFASTINT rather than XUINT when numbers are nonnegative.
5207 (xd_append_arg, Fdbus_method_return_internal):
5208 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5209 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5210 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5211 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5212 (Bug#8722)
2d1fc3c7 5213
c8a9ca5a
PE
5214 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5215
519e1d69
PE
5216 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5217
30569699
PE
5218 ccl: add integer overflow checks
5219 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5220 (IN_INT_RANGE): New macros.
5221 (ccl_driver): Use them to check for integer overflow when
5222 decoding a CCL program. Many of the new checks are whether XINT (x)
5223 fits in int; it doesn't always, on 64-bit hosts. The new version
5224 doesn't catch all possible integer overflows, but it's an
847044ea 5225 improvement. (Bug#8719)
30569699 5226
c11285dc
PE
5227 * alloc.c (make_event_array): Use XINT, not XUINT.
5228 There's no need for unsigned here.
5229
fdccd48e
PE
5230 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5231 This follows up to the 2011-05-06 change that substituted uintptr_t
5232 for EMACS_INT. This case wasn't caught back then.
5233
37910ab2
PE
5234 Rework Fformat to avoid integer overflow issues.
5235 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5236 now (part of C89). Include <verify.h>.
5237 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5238 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5239 (Fformat): Avoid the prepass trying to compute sizes; it was only
5240 approximate and thus did not catch overflow reliably. Instead, walk
5241 through the format just once, formatting and computing sizes as we go,
5242 checking for integer overflow at every step, and allocating a larger
5243 buffer as needed. Keep track separately whether the format is
5244 multibyte. Keep only the most-recently calculated precision, rather
5245 than them all. Record whether each argument has been converted to
5246 string. Use EMACS_INT, not int, for byte and char and arg counts.
5247 Support field widths and precisions larger than INT_MAX. Avoid
5248 sprintf's undefined behavior with conversion specifications such as %#d
5249 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5250 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5251 formatting out-of-range floating point numbers with int
9173deec 5252 formats. (Bug#8668)
37910ab2 5253
2e6578fb
PE
5254 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5255
0ae6bdee
PE
5256 * data.c: Avoid integer truncation in expressions involving floats.
5257 * data.c: Include <intprops.h>.
5258 (arith_driver): When there's an integer overflow in an expression
5259 involving floating point, convert the integers to floating point
5260 so that the resulting value does not suffer from catastrophic
5261 integer truncation. For example, on a 64-bit host (* 4
5262 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5263 Do not rely on undefined behavior after integer overflow.
5264
de883a70
PE
5265 merge count_size_as_multibyte, parse_str_to_multibyte
5266 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5267 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5268 Check for integer overflow.
5269 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5270 since it's now a duplicate of the other. This is more of
5271 a character than a buffer op, so better that it's in character.c.
5272 * fns.c, print.c: Adjust to above changes.
5273
2ff916cb
PE
52742011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5275
5276 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5277
f1b54466
PE
52782011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5279
fb1ac845
PE
5280 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5281 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5282 (x_clipboard_manager_save): Now static.
5283 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5284
f1b54466
PE
5285 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5286 (crypto_hash_function): Now static.
5287 Fix pointer signedness problems. Avoid unnecessary initializations.
5288
a9f737ee
CY
52892011-05-27 Chong Yidong <cyd@stupidchicken.com>
5290
5291 * termhooks.h (Vselection_alist): Make it terminal-local.
5292
5293 * terminal.c (create_terminal): Initialize it.
5294
5295 * xselect.c: Support for clipboard managers.
5296 (Vselection_alist): Move to termhooks.h as terminal-local var.
5297 (LOCAL_SELECTION): New macro.
5298 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5299 (symbol_to_x_atom): Remove gratuitous arg.
5300 (x_handle_selection_request, lisp_data_to_selection_data)
5301 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5302 (x_own_selection, x_get_local_selection, x_convert_selection):
5303 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5304 (some_frame_on_display): Delete unused function.
5305 (Fx_own_selection_internal, Fx_get_selection_internal)
5306 (Fx_disown_selection_internal, Fx_selection_owner_p)
5307 (Fx_selection_exists_p): New optional frame arg.
5308 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5309 (x_handle_selection_clear): Don't treat other terminals with the
5310 same keyboard specially. Use the terminal-local Vselection_alist.
5311 (x_clear_frame_selections): Use Frun_hook_with_args.
5312
5313 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5314
5315 * xterm.h: Add support for those atoms.
5316
e067f0c1
CY
53172011-05-26 Chong Yidong <cyd@stupidchicken.com>
5318
5319 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5320 (converted_selections, conversion_fail_tag): New global variables.
5321 (x_selection_request_lisp_error): Free the above.
5322 (x_get_local_selection): Remove unnecessary code.
5323 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5324 of converted selections stored in converted_selections.
5325 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5326 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5327 (x_convert_selection): New function.
5328 (x_handle_selection_event): Simplify.
5329 (x_get_foreign_selection): Don't ignore incoming requests while
5330 waiting for an answer; this will fail when we implement
5331 SAVE_TARGETS, and seems unnecessary anyway.
5332 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5333 (Vx_sent_selection_functions): Doc fix.
5334
0f4aebc0
LL
53352011-05-26 Leo Liu <sdl.web@gmail.com>
5336
5337 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5338
e61124cd
YM
53392011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5340
5341 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5342
5343 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5344 for fringe update if it has periodic bitmap.
ac389d0c 5345 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5346 and fringe_bitmap_periodic_p.
5347
5348 * fringe.c (get_fringe_bitmap_data): New function.
5349 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5350 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5351 row. Mark glyph row for fringe update if periodicity changed.
5352
5353 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5354 for fringe update unless it has periodic bitmap.
5355
f16d9837
KH
53562011-05-25 Kenichi Handa <handa@m17n.org>
5357
5358 * xdisp.c (get_next_display_element): Set correct it->face_id for
5359 a static composition.
5360
e1b90ef6
LL
53612011-05-24 Leo Liu <sdl.web@gmail.com>
5362
5363 * deps.mk (fns.o):
5364 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5365
5366 * fns.c (crypto_hash_function, Fsha1): New function.
5367 (Fmd5): Use crypto_hash_function.
5368 (syms_of_fns): Add Ssha1.
5369
7400048f
PE
53702011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5371
5372 * gnutls.c: Remove unused macros.
5373 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5374 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5375 Remove macros that are defined and never used.
5376 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5377
abb71cf4
CY
53782011-05-22 Chong Yidong <cyd@stupidchicken.com>
5379
5380 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5381 (Fx_get_selection_internal): Minor cleanup.
5382 (Fx_own_selection_internal): Rename arguments for consistency with
5383 select.el.
5384
6307db39
PE
53852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5386
5387 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5388
f3d4e0a4
CY
53892011-05-22 Chong Yidong <cyd@stupidchicken.com>
5390
5391 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5392
4d8ade89
YM
53932011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5394
5395 * dispnew.c (scrolling_window): Don't exclude the case that the
5396 last enabled row in the desired matrix touches the bottom boundary.
5397
32078c8d
GM
53982011-05-21 Glenn Morris <rgm@gnu.org>
5399
5400 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5401 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5402 and add some more files.
32078c8d 5403
7285dc67
EZ
54042011-05-20 Eli Zaretskii <eliz@gnu.org>
5405
5406 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5407 report_file_error introduced by the change from 2011-05-07.
5408
89d1bd22
PE
54092011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5410
5411 * systime.h (Time): Define only if emacs is defined.
5412 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5413 where the include path doesn't have X11/X.h by default. See
5414 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5415
e23640bb 54162011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5417
5418 * composite.c (find_automatic_composition): Fix previous change.
5419
b9704ad9
GM
54202011-05-20 Glenn Morris <rgm@gnu.org>
5421
5422 * lisp.mk: New file, split from Makefile.in.
5423 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5424 (shortlisp): Remove.
5425 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5426
4a720484
GM
54272011-05-19 Glenn Morris <rgm@gnu.org>
5428
5429 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5430 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5431 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5432 (lisp): Set the order to that of loadup.el.
5433 (shortlisp): Make it a copy of $lisp.
5434 (SOME_MACHINE_LISP): Remove.
5435 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5436 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5437
a28d4396
KH
54382011-05-18 Kenichi Handa <handa@m17n.org>
5439
5440 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5441 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5442 (find_automatic_composition): Mostly rewrite for efficiency.
5443
a2b1fa8e
JB
54442011-05-18 Juanma Barranquero <lekktu@gmail.com>
5445
5446 * makefile.w32-in: Update dependencies.
5447
8e1f5610
CS
54482011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5449
5450 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5451 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5452
7025ee00 54532011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5454
cdfa6eab
PE
5455 Fix some integer overflow issues, such as string length overflow.
5456
06d6db33
PE
5457 * insdel.c (count_size_as_multibyte): Check for string overflow.
5458
2b4560a8
PE
5459 * character.c (lisp_string_width): Check for string overflow.
5460 Use EMACS_INT, not int, for string indexes and lengths; in
5461 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5462 the resulting string length overflows an EMACS_INT; instead,
5463 report a string overflow if no precision given. When checking for
5464 precision exhaustion, use a check that cannot possibly have
5465 integer overflow. (Bug#8675)
5466 * character.h (lisp_string_width): Adjust to new signature.
5467
cb93f9be
PE
5468 * alloc.c (string_overflow): New function.
5469 (Fmake_string): Use it. This doesn't change behavior, but saves
5470 a few bytes and will simplify future changes.
5471 * character.c (string_escape_byte8): Likewise.
5472 * lisp.h (string_overflow): New decl.
5473
1a1f3366
PE
5474 Fixups, following up to the user-interface timestamp change.
5475 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5476 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5477 * msdos.c (mouse_get_pos): Likewise.
5478 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5479 * w32gui.h (Time): Define by including "systime.h" rather than by
5480 declaring it ourselves. (Bug#8664)
5481
d4e3e4d3
PE
5482 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5483 * image.c (clear_image_cache): Likewise.
5484
f6a24d19
PE
5485 * term.c (term_mouse_position): Don't assume time_t wraparound.
5486
08dc5ae6
PE
5487 Be more systematic about user-interface timestamps.
5488 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5489 and sometimes 'EMACS_UINT', to represent these timestamps.
5490 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5491 This makes the code easier to follow, and makes it easier to catch
5492 integer overflow bugs such as Bug#8664.
5493 * frame.c (Fmouse_position, Fmouse_pixel_position):
5494 Use Time, not unsigned long, for user-interface timestamps.
5495 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5496 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5497 * keyboard.h (last_event_timestamp): Likewise.
5498 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5499 * menu.h (xmenu_show): Likewise.
5500 * term.c (term_mouse_position): Likewise.
5501 * termhooks.h (struct input_event.timestamp): Likewise.
5502 (struct terminal.mouse_position_hook): Likewise.
5503 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5504 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5505 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5506 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5507 what it was before.
5508 * menu.h, termhooks.h: Include "systime.h", for Time.
5509
8e55734a
PE
5510 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5511 Don't assume that the difference between two unsigned long values
5512 can fit into an integer. At this point, we know button_down_time
5513 <= event->timestamp, so the difference must be nonnegative, so
5514 there's no need to cast the result if double-click-time is
5515 nonnegative, as it should be; check that it's nonnegative, just in
5516 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5517 apart (about 25 days). (Bug#8664)
8e55734a 5518
841f1b75 5519 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5520 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5521
3e26f69c
PE
5522 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5523 that always fit in int. Use a sentinel instead of a counter, to
5524 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5525 * frame.h (struct frame): Use int for menu_bar_items_used
5526 instead of EMACS_INT, since it always fits in int.
3e26f69c 5527
5cc152c0
PE
5528 * menu.c (grow_menu_items): Check for int overflow.
5529
d89eb65e
PE
5530 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5531
5235bd3e
PE
5532 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5533 Before, the code was not consistent. These values cannot exceed
5534 2**31 - 1 so there's no need to make them unsigned.
5535 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5536 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5537 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5538 as modifiers.
5539 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5540
bc827e23
PE
5541 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5542 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5543 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5544 presumably because the widths might not match.
5545
78eb494e
PE
5546 * window.c (size_window): Avoid needless test at loop start.
5547
04f2d78b
CB
55482011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5549
5550 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5551
d2fc7e3d 55522011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5553
5554 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5555
d2fc7e3d 55562011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5557
5558 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5559 `width' to `bar_area_x' and `bar_area_width', respectively.
5560 (x_scroll_run): Take account of fringe background extension.
5561
04f2d78b
CB
5562 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5563 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5564 `bar_area_width', respectively.
5565 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5566 background extension.
5567
79b70037
GM
55682011-05-10 Jim Meyering <meyering@redhat.com>
5569
5570 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5571
2f142cc5
JB
55722011-05-10 Juanma Barranquero <lekktu@gmail.com>
5573
5574 * image.c (Finit_image_library): Return t for built-in image types,
5575 like pbm and xbm. (Bug#8640)
5576
57679c86
AS
55772011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5578
5579 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5580
888c9e86
EZ
55812011-05-07 Eli Zaretskii <eliz@gnu.org>
5582
b0512a1d
EZ
5583 * w32console.c (Fset_screen_color): Doc fix.
5584 (Fget_screen_color): New function.
5585 (syms_of_ntterm): Defsubr it.
5586
7285dc67
EZ
5587 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5588 unlink the temporary file if Fcall_process didn't create it in the
5589 first place.
5590 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5591 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5592 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5593 cue to call_process_cleanup not to close that handle.
5594
4d3fcc8e
BK
55952011-05-07 Ben Key <bkey76@gmail.com>
5596
5597 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5598 one of two shell specific rules, either bootstrap-temacs-CMD or
5599 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5600 to the previous implementation of the bootstrap-temacs rule.
5601 The bootstrap-temacs-CMD rule is similar to the previous
5602 implementation of the bootstrap-temacs rule except that it
5603 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5604 variable.
5605
5606 These changes, along with some changes to nt/configure.bat,
5607 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5608 earlier fix to add support for --cflags and --ldflags options
5609 that include quotes so that it works whether make uses cmd or
5610 sh as the shell.
5611
b4289b64
MA
56122011-05-06 Michael Albinus <michael.albinus@gmx.de>
5613
5614 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5615 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5616 is a constant.
5617 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5618 a string. Handle both cases.
5619 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5620 (Fdbus_register_method): Use Qinvalid_function.
5621
af4c0e28
JB
56222011-05-06 Juanma Barranquero <lekktu@gmail.com>
5623
5624 * makefile.w32-in: Update dependencies.
5625 (LISP_H): Add inttypes.h and stdin.h.
5626 (PROCESS_H): Add unistd.h.
5627
c51453d9
EZ
56282011-05-06 Eli Zaretskii <eliz@gnu.org>
5629
5630 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5631 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5632
8ff0ac3c 56332011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5634
4c4b566b
PE
5635 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5636
aab2b9b5
PE
5637 * term.c (vfatal): Remove stray call to va_end.
5638 It's not needed and the C Standard doesn't allow it here anyway.
5639
c378da0b
PE
5640 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5641 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5642
288b08c7
PE
5643 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5644 bytes.
5645
e3601888
PE
5646 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5647
db6c0e74
PE
5648 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5649
dd5963ea
PE
5650 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5651
88c9450f
PE
5652 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5653
2f9442b8
PE
5654 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5655
c032b5f8
PE
5656 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5657 * charset.c (Fdefine_charset_internal): Don't initialize
5658 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5659 32-bit int (Bug#8600).
a108c10b
PE
5660
5661 * lread.c (read_integer): Be more consistent with string-to-number.
5662 Use string_to_number to do the actual conversion; this avoids
5663 rounding errors and fixes some other screwups. Without this fix,
5664 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5665 (digit_to_number): Move earlier, for benefit of read_integer.
5666 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5667 not a digit in any supported base. (Bug#8602)
a108c10b 5668
ad5f9eea
PE
5669 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5670
aec1708a
PE
5671 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5672 to match comment at start of function. This also removes a
5673 GCC warning about overflow in a 32+64-bit port.
5674
47be4ab5
PE
5675 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5676
371cac43
PE
5677 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5678 Reported by Stefan Monnier in
5679 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5680 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5681 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5682
d01a7826
PE
5683 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5684 (EMACS_UINTPTR): Likewise, with uintptr_t.
5685
7fd47d5c
PE
5686 * lisp.h: Prefer 64-bit EMACS_INT if available.
5687 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5688 on 32-bit hosts that have 64-bit int, so that they can access
5689 large files.
122b0c86
PE
5690 However, temporarily disable this change unless the temporary
5691 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5692
8727937b
PE
5693 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5694
8ac068ac
PE
5695 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5696 This removes an assumption that EMACS_INT and long are the same
5697 width as pointers. The assumption is true for Emacs porting targets
5698 now, but we want to make other targets possible.
5699 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5700 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5701 In the rest of the code, change types of integers that hold casted
5702 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5703 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5704 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5705 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5706 No need to cast type when ORing.
5707 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5708 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5709 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5710 assume EMACS_INT is the same width as char *.
5711 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5712 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5713 Remove no-longer-needed casts.
5714 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5715 (xg_tool_bar_help_callback, xg_make_tool_item):
5716 Use EMACS_INTPTR to hold an integer
5717 that will be cast to void *; this can avoid a GCC warning
5718 if EMACS_INT is not the same width as void *.
5719 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5720 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5721 (current_message_1, set_message_1):
5722 Use a local to convert to proper width without a cast.
5723 * xmenu.c (dialog_selection_callback): Likewise.
5724
ede49d71
PE
5725 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5726 Also, don't assume VALBITS / RAND_BITS is less than 5,
5727 and don't rely on undefined behavior when shifting a 1 left into
5728 the sign bit.
5729 * lisp.h (get_random): Change signature to match.
5730
2f30ecd0
PE
5731 * lread.c (hash_string): Use size_t, not int, for hash computation.
5732 Normally we prefer signed values; but hashing is special, because
5733 it's better to use unsigned division on hash table sizes so that
5734 the remainder is nonnegative. Also, size_t is the natural width
5735 for hashing into memory. The previous code used 'int', which doesn't
5736 retain enough info to hash well into very large tables.
5737 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5738
2a866e7b
PE
5739 * dbusbind.c: Don't possibly lose pointer info when converting.
5740 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5741 Use XPNTR rather than XHASH, so that the high-order bits of
5742 the pointer aren't lost when converting through void *.
5743
51639eac
PE
5744 * eval.c (Fautoload): Don't double-shift a pointer.
5745
92394119
PE
5746 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5747
dbdb9a7c
JB
57482011-05-06 Juanma Barranquero <lekktu@gmail.com>
5749
5750 * gnutls.c (DEF_GNUTLS_FN):
5751 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5752
db7a0b4f
AS
57532011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5754
5755 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5756 marker. (Bug#8610)
5757
f7ff1b0f 57582011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5759
5760 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5761 New version that can reserve upto 2GB of heap space.
5762
f7ff1b0f 57632011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5764
5765 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5766
639c109b
TZ
57672011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5768
5769 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5770 `gnutls_certificate_set_x509_key_file'.
5771
d2127135
JB
57722011-05-05 Juanma Barranquero <lekktu@gmail.com>
5773
5774 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5775 Update dependencies.
5776
e968f4f3
JB
57772011-05-04 Juanma Barranquero <lekktu@gmail.com>
5778
5779 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5780 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5781 Remove unused parameter `fildes'.
5782 * process.c (read_process_output, send_process): Don't pass it.
5783
84d358f0
JB
57842011-05-04 Juanma Barranquero <lekktu@gmail.com>
5785
5786 Fix previous change: the library cache is defined in w32.c.
5787 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5788 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5789
0898ca10
JB
57902011-05-04 Juanma Barranquero <lekktu@gmail.com>
5791
5792 Implement dynamic loading of GnuTLS on Windows.
5793
5794 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5795 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5796 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5797 Declare.
5798
5799 * gnutls.c (Qgnutls_dll): Define.
5800 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5801 (gnutls_*): Declare function pointers.
5802 (init_gnutls_functions): New function to initialize function pointers.
5803 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5804 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5805 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5806 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5807 (emacs_gnutls_write, emacs_gnutls_read)
5808 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5809 (Fgnutls_available_p): New function.
5810 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5811 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5812 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5813
5814 * image.c: Include w32.h.
5815 (Vimage_type_cache): Delete.
5816 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5817 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5818 (w32_delayed_load): Move to w32.c.
5819
5820 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5821
5822 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5823 (w32_delayed_load): Move from image.c. When loading a library, record
5824 its filename in the :loaded-from property of the library id.
5825 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5826 Initialize and staticpro them.
5827 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5828
5829 * process.c: Include lisp.h before w32.h, not after.
5830 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5831 instead of gnutls_record_check_pending.
5832
5833 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5834
ff4de4aa
TZ
58352011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5836
5837 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5838 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5839 as passed in.
5840
abe95abb
JD
58412011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5842
5843 * xterm.c (x_set_frame_alpha): Do not set property on anything
5844 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5845
e16e55d4
JB
58462011-05-02 Juanma Barranquero <lekktu@gmail.com>
5847
5848 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5849
bafcf6a5
JB
58502011-05-02 Juanma Barranquero <lekktu@gmail.com>
5851
5852 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5853 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5854 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5855 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5856 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5857 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5858 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5859 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5860 (Qgnutls_bootprop_callbacks_verify): Make static.
5861
e7a6747f
AS
58622011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5863
19ed11ba
AS
5864 * callproc.c: Indentation fixup.
5865
e7a6747f 5866 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5867 (wait_for_termination, interruptible_wait_for_termination):
5868 Move after wait_for_termination_1.
e7a6747f 5869
1ef14cb4
LMI
58702011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5871
5872 * sysdep.c (interruptible_wait_for_termination): New function
5873 which is like wait_for_termination, but allows keyboard
5874 interruptions.
5875
5876 * callproc.c (Fcall_process): Add (:file "file") as an option for
5877 the STDOUT buffer.
5878 (Fcall_process_region): Ditto.
5879
330d880c
EZ
58802011-04-30 Eli Zaretskii <eliz@gnu.org>
5881
8db90b73
EZ
5882 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5883 rather than `XVECTOR (FOO)->size'.
5884
330d880c
EZ
5885 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5886 inttypes.h, as a gnulib replacement is used if it not available in
5887 system headers.
5888
15cbd324
EZ
58892011-04-21 Eli Zaretskii <eliz@gnu.org>
5890
5891 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5892 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5893 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5894
5895 * coding.c (coding_alloc_by_realloc): Error out if destination
5896 will grow beyond MOST_POSITIVE_FIXNUM.
5897 (decode_coding_emacs_mule): Abort if there isn't enough place in
5898 charbuf for the composition carryover bytes. Reserve an extra
5899 space for up to 2 characters produced in a loop.
5900 (decode_coding_iso_2022): Abort if there isn't enough place in
5901 charbuf for the composition carryover bytes.
5902
59032011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5904
ae940cca
EZ
5905 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5906 aborting when %lld or %lll format is passed.
5907 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5908 %llo or %llx format is passed. (Bug#8545)
5909
03ab8921
EZ
5910 * window.c (window_scroll_line_based): Use a marker instead of
5911 simple variables to record original value of point. (Bug#7952)
5912
afda1437
EZ
5913 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5914 produced by %s or %c overflows available buffer space. (Bug#8545)
5915
f76dee0c
PE
59162011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5917
5918 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5919 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5920
fdc5744d
JB
59212011-04-28 Juanma Barranquero <lekktu@gmail.com>
5922
5923 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5924
638f053a
JB
59252011-04-28 Juanma Barranquero <lekktu@gmail.com>
5926
5927 * keyboard.c (Qdelayed_warnings_hook): Define.
5928 (command_loop_1): Run `delayed-warnings-hook'
5929 if Vdelayed_warnings_list is non-nil.
5930 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5931 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5932
d178f871
EZ
59332011-04-28 Eli Zaretskii <eliz@gnu.org>
5934
5935 * doprnt.c (doprnt): Don't return value smaller than the buffer
5936 size if the message was truncated. (Bug#8545).
5937
b124fd93
JB
59382011-04-28 Juanma Barranquero <lekktu@gmail.com>
5939
5940 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5941 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5942
e810457d
PE
59432011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5944
5945 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5946
ea51cceb
JB
59472011-04-27 Juanma Barranquero <lekktu@gmail.com>
5948
5949 * makefile.w32-in: Update dependencies.
5950
94dcfacf
EZ
59512011-04-27 Eli Zaretskii <eliz@gnu.org>
5952
5953 Improve `doprnt' and its usage. (Bug#8545)
5954 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5955 `format_end'. Remove support for %l as a conversion specifier.
5956 Don't use xrealloc. Improve diagnostics when the %l size modifier
5957 is used. Update the commentary.
5958
5959 * eval.c (verror): Simplify calculation of size_t.
5960
5961 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5962 messages.
5963
f61f41d7
PE
59642011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5965
5966 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5967 change.
5968
96fb4434
PE
59692011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5970
5971 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5972 This makes this file independent of the recent pseudovector change.
5973
671875da 59742011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5975
69e9b5a3
PE
5976 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5977
b5f869a7 5978 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5979 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5980 Remove unused local.
c8926152 5981 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5982
841a1577 5983 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5984 GCC 4.6.0 optimizes based on type-based alias analysis.
5985 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5986 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5987 != &v->size, and therefore "v->size = 1; b->size = 2; return
5988 v->size;" must therefore return 1. This assumption is incorrect
5989 for Emacs, since it type-puns struct Lisp_Vector * with many other
5990 types. To fix this problem, this patch adds a new type struct
f904488f 5991 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5992 and pseudovectors, and helps optimizing compilers not get fooled
5993 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5994 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5995 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5996 the size member.
eab3844f
PE
5997 (XSETPVECTYPE): Rewrite in terms of new macro.
5998 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5999 This is a bit clearer, and further avoids the possibility of
6000 undesirable aliasing.
6001 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6002 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6003 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6004 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6005 (ASIZE): Now uses header.size rather than size.
6006 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6007 to avoid the hassle of writing XVECTOR (foo)->header.size.
6008 (struct vectorlike_header): New type.
eab3844f
PE
6009 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6010 object, to help avoid aliasing.
6011 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6012 (SUBRP): Likewise, since Lisp_Subr is a special case.
6013 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6014 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6015 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6016 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6017 changed to be "header.size" and "header.next".
6018 * buffer.h (struct buffer): Likewise.
6019 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6020 * frame.h (struct frame): Likewise.
6021 * process.h (struct Lisp_Process): Likewise.
6022 * termhooks.h (struct terminal): Likewise.
6023 * window.c (struct save_window_data, struct saved_window): Likewise.
6024 * window.h (struct window): Likewise.
6025 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6026 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6027 * buffer.c (init_buffer_once): Likewise.
6028 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6029 special case.
6030 * process.c (Fformat_network_address): Use local var for size,
6031 for brevity.
6032
0df1eac5
PE
6033 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6034
847ab9d1 6035 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6036 * data.c (atof): Remove decl; no longer used or needed.
6037 (digit_to_number): Move to lread.c.
6038 (Fstring_to_number): Use new string_to_number function, to be
6039 consistent with how the Lisp reader treats infinities and NaNs.
6040 Do not assume that floating-point numbers represent EMACS_INT
6041 without losing information; this is not true on most 64-bit hosts.
6042 Avoid double-rounding errors, by insisting on integers when
6043 parsing non-base-10 numbers, as the documentation specifies.
6044 * lisp.h (string_to_number): New decl, replacing ...
6045 (isfloat_string): Remove.
bc0a5c13 6046 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6047 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6048 appears to have been a coding error. Similarly, do not accept
6049 strings like +-1e0 as floating point numbers. Do not report
6050 overflow for integer overflows unless the base is not 10 which
6051 means we have no simple and reliable way to continue.
6052 Break out the floating-point parsing into a new
6053 function string_to_number, so that Fstring_to_number parses
6054 floating point numbers consistently with the Lisp reader.
04f2d78b 6055 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6056 (E_CHAR, EXP_INT): Remove, replacing with ...
6057 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6058 (string_to_number): New function, replacing isfloat_string.
6059 This function checks for valid syntax and produces the resulting
6060 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6061 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6062 so that overflow for non-base-10 numbers is reported only when
6063 there's no portable and simple way to convert to floating point.
452f4150 6064
67769ffc
PE
6065 * textprop.c (set_text_properties_1): Rewrite for clarity,
6066 and to avoid GCC warning about integer overflow.
6067
c20db43f
PE
6068 * intervals.h (struct interval): Use EMACS_INT for members
6069 where EMACS_UINT might cause problems. See
6070 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6071 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6072 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6073 All uses changed.
37aa2f85
PE
6074 (offset_intervals): Tell GCC not to worry about length overflow
6075 when negating a negative length.
c20db43f 6076
2538aa2f
PE
6077 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6078 (overrun_check_free): Likewise.
6079
f2d3008d
PE
6080 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6081 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6082 word size.
6083
ec8df744
PE
6084 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6085 (gnutls_make_error): Rename local to avoid shadowing.
6086 (gnutls_emacs_global_deinit): ifdef out; not used.
6087 (Fgnutls_boot): Use const for pointer to readonly storage.
6088 Comment out unused local. Fix pointer signedness problems.
6089
640ee02d
PE
6090 * lread.c (openp): Don't stuff size_t into an 'int'.
6091 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6092 about possible signed overflow.
6093
6048fb2a
PE
6094 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6095 (GDK_KEY_g): Don't define if already defined.
6096 (xg_prepare_tooltip): Avoid pointer signedness problem.
6097 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6098
fa3c87e1
PE
6099 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6100 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6101
2172544b
PE
6102 * xfns.c (Fx_window_property): Simplify a bit,
6103 to make a bit faster and to avoid GCC 4.6.0 warning.
6104 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6105
9b821a21
PE
6106 * fns.c (internal_equal): Don't assume size_t fits in int.
6107
3c616cfa
PE
6108 * alloc.c (compact_small_strings): Tighten assertion a little.
6109
c2982e87
PE
6110 Replace pEd with more-general pI, and fix some printf arg casts.
6111 * lisp.h (pI): New macro, generalizing old pEd macro to other
6112 conversion specifiers. For example, use "...%"pI"d..." rather
6113 than "...%"pEd"...".
6114 (pEd): Remove. All uses replaced with similar uses of pI.
6115 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6116 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6117 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6118 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6119 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6120 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6121 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6122 64-bit hosts.
6123 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6124 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6125 * print.c (safe_debug_print, print_object): Likewise.
6126 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6127 to int.
6f04d126
PE
6128 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6129 avoiding the 0 flag, which is not portable.
c2982e87
PE
6130 * process.c (Fmake_network_process): Use pI to avoid cast.
6131 * region-cache.c (pp_cache): Likewise.
6132 * xdisp.c (decode_mode_spec): Likewise.
6133 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6134 behavior on 64-bit hosts with printf arg.
6f04d126 6135 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6136 (x_stop_queuing_selection_requests): Likewise.
6137 (x_get_window_property): Don't truncate byte count to an 'int'
6138 when tracing.
0b432f21 6139
5e073ec7
PE
6140 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6141 here, since it parses constructs like leading '-' and spaces,
6142 which are not wanted; and it overflows with large numbers.
6143 Instead, simply match F[0-9]+, which is what is wanted anyway.
6144
36372bf9
PE
6145 * alloc.c: Remove unportable assumptions about struct layout.
6146 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6147 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6148 (allocate_vectorlike, make_pure_vector): Use the new macros,
6149 plus offsetof, to remove unportable assumptions about struct layout.
6150 These assumptions hold on all porting targets that I know of, but
6151 they are not guaranteed, they're easy to remove, and removing them
6152 makes further changes easier.
6153
0b432f21
PE
6154 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6155 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6156 (string_overrun_cookie): Now const. Use initializers that
6157 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6158 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6159 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6160 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6161 multiple of sizeof (EMACS_INT); it need not be, if
6162 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6163 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6164
895009e1
JB
61652011-04-26 Juanma Barranquero <lekktu@gmail.com>
6166
6167 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6168
6a7a1b0b
TZ
61692011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6170
6171 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6172 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6173 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6174
841a1577 61752011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6176
6177 * lisp.h (Qdebug): List symbol.
895009e1 6178 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6179 * keyboard.c (debug-on-event): New variable.
6180 (handle_user_signal): Break into debugger when debug-on-event
6181 matches the current signal symbol.
6182
f2d3ba6f
DN
61832011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6184
6185 * alloc.c (check_sblock, check_string_bytes)
6186 (check_string_free_list): Convert to standard C.
6187
42ce4c63
TZ
61882011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6189
6190 * w32.c (emacs_gnutls_push): Fix typo.
6191
825cd63c
EZ
61922011-04-25 Eli Zaretskii <eliz@gnu.org>
6193
fb11d64d
EZ
6194 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6195 "cast to pointer from integer of different size".
6196
825cd63c
EZ
6197 Improve doprnt and its use in verror. (Bug#8545)
6198 * doprnt.c (doprnt): Document the set of format control sequences
6199 supported by the function. Use SAFE_ALLOCA instead of always
6200 using `alloca'.
6201
6202 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6203 is one byte too soon. Don't use xrealloc; instead xfree and
6204 xmalloc anew.
6205
e061a11b
TZ
62062011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6207
6208 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6209 callbacks stage.
6210
6211 * gnutls.c: Renamed global_initialized to
6212 gnutls_global_initialized. Added internals for the
6213 :verify-hostname-error, :verify-error, and :verify-flags
6214 parameters of `gnutls-boot' and documented those parameters in the
6215 docstring. Start callback support.
9173deec
JB
6216 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6217 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6218 on error. Return error code.
e061a11b
TZ
6219 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6220 (emacs_gnutls_read): Likewise.
6221 (Fgnutls_boot): Return handshake error code.
6222 (emacs_gnutls_handle_error): New function.
6223 (wsaerror_to_errno): Likewise.
6224
6225 * w32.h (emacs_gnutls_pull): Add prototype.
6226 (emacs_gnutls_push): Likewise.
6227
6228 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6229 (emacs_gnutls_push): Likewise.
6230
62312011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6232
6233 * process.c (wait_reading_process_output): Check if GnuTLS
6234 buffered some data internally if no FDs are set for TLS
6235 connections.
6236
6237 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6238 (LIBS): Link to USER_LIBS.
6239 ($(BLD)/gnutls.$(0)): New target.
6240
fa6996bc
EZ
62412011-04-24 Eli Zaretskii <eliz@gnu.org>
6242
eb35682e
EZ
6243 * xdisp.c (handle_single_display_spec): Rename the
6244 display_replaced_before_p argument into display_replaced_p, to
6245 make it consistent with the commentary. Fix typos in the
6246 commentary.
6247
e2ad650c
EZ
6248 * textprop.c (syms_of_textprop): Remove dead code.
6249 (copy_text_properties): Delete obsolete commentary about an
6250 interface that was deleted long ago. Fix typos in the description
6251 of arguments.
6252
1b2de274
EZ
6253 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6254 to changes in oldXMenu/XMenu.h from 2011-04-16.
6255 <menu_help_message, prev_menu_help_message>: Constify.
6256 (IT_menu_make_room): menu->help_text is now `const char **';
6257 adjust.
6258
6259 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6260 to changes in oldXMenu/XMenu.h from 2011-04-16.
6261 (struct XMenu): Declare `help_text' `const char **'.
6262
6263 * xfaces.c <Qunspecified>: Make extern again.
6264
6265 * syntax.c: Include sys/types.h before including regex.h, as
6266 required by Posix.
6267
762b15be
EZ
6268 * doc.c (get_doc_string): Improve the format passed to `error'.
6269
6270 * doprnt.c (doprnt): Improve commentary.
6271
6272 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6273
6274 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6275 them with etags.
6276
f1052e5d
EZ
6277 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6278 changes in globals.h immediately force recompilation.
762b15be
EZ
6279 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6280 $(CURDIR)/s/ms-w32.h.
6281 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6282
fa6996bc
EZ
6283 * character.c (Fchar_direction): Function deleted.
6284 (syms_of_character): Don't defsubr it.
6285 <char-direction-table>: Deleted.
6286
e6c3da20
EZ
62872011-04-23 Eli Zaretskii <eliz@gnu.org>
6288
6289 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6290 * doprnt.c: Include limits.h.
6291 (SIZE_MAX): New macro.
04f2d78b
CB
6292 (doprnt): Return a size_t value. 2nd arg is now size_t.
6293 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6294 Improve overflow protection. Support `l' modifier for integer
6295 conversions. Support %l conversion. Don't assume an EMACS_INT
6296 argument for integer conversions and for %c.
6297
6298 * lisp.h (doprnt): Restore prototype.
6299
6300 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6301 $(SRC)/character.h.
6302
6303 * Makefile.in (base_obj): Add back doprnt.o.
6304
6305 * deps.mk (doprnt.o): Add back prerequisites.
6306 (callint.o): Depend on character.h.
6307
6308 * eval.c (internal_lisp_condition_case): Include the handler
6309 representation in the error message.
6310 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6311 when breaking from the loop.
6312
6313 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6314
6315 * callint.c (Fcall_interactively): When displaying error message
6316 about invalid control letter, pass the character's codepoint, not
6317 a pointer to its multibyte form. Improve display of the character
6318 in octal and display also its hex code.
6319
6320 * character.c (char_string): Use %x to display the (unsigned)
6321 codepoint of an invalid character, to avoid displaying a bogus
6322 negative value.
6323
6324 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6325 `error', not SYMBOL_NAME itself.
6326
6327 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6328 character arguments to `error'.
6329
6330 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6331 to `error' in error message about FINAL_CHAR argument. Make sure
6332 FINAL_CHAR is a character, and use %c when it is passed as
6333 argument to `error'.
6334
4ffd0d6b 63352011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6336
6337 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6338
6339 * w32.c: Include <time.h>.
6340 (sys_localtime): New function.
6341
4ffd0d6b 63422011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6343
6344 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6345
4ffd0d6b 6346 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6347
4ffd0d6b 63482011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6349
4ffd0d6b
GM
6350 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6351 zombies (Bug#8467).
aac0c6e3 6352
04c56954
EZ
63532011-04-19 Eli Zaretskii <eliz@gnu.org>
6354
6355 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6356 gl_state.e_property when gl_state.object is Qt.
6357
6358 * insdel.c (make_gap_larger): Remove limitation of buffer size
6359 to <= INT_MAX.
6360
16a43933
CY
63612011-04-18 Chong Yidong <cyd@stupidchicken.com>
6362
6363 * xdisp.c (lookup_glyphless_char_display)
6364 (produce_glyphless_glyph): Handle cons cell entry in
6365 glyphless-char-display.
6366 (Vglyphless_char_display): Document it.
6367
6368 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6369 glyphless-char-display.
6370
4581706e
CY
63712011-04-17 Chong Yidong <cyd@stupidchicken.com>
6372
6373 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6374
6375 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6376
6377 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6378 definition for no-X builds.
6379
4887c6e2 63802011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6381
fd35b6f9
PE
6382 Static checks with GCC 4.6.0 and non-default toolkits.
6383
5c1ccb01
PE
6384 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6385
006c5daa
PE
6386 * process.c (keyboard_bit_set): Define only if SIGIO.
6387 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6388 (send_process): Repair possible setjmp clobbering.
6389
efc736d3
PE
6390 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6391
4e2fe2e6
PE
6392 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6393
f97334a2
PE
6394 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6395
4e75f29d
PE
6396 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6397 Define only if needed.
6398
90efadd1
PE
6399 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6400 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6401 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6402
3c647824
PE
6403 * dispextern.h (struct redisplay_interface): Rename param
6404 to avoid shadowing.
e264f262 6405 * termhooks.h (struct terminal): Likewise.
761383f4 6406 * xterm.c (xembed_send_message): Likewise.
3c647824 6407
b58c5c4a
PE
6408 * insdel.c (make_gap_smaller): Define only if
6409 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6410
cad59032
PE
6411 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6412 it.
6413
c339dc2e
PE
6414 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6415 so that we aren't warned about unused symbols.
6416
91a3e27b
PE
6417 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6418
399c71d3 6419 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6420
8ffc96f5
PE
6421 * xfns.c (x_real_positions): Mark locals as initialized.
6422
eef9bc79
PE
6423 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6424
098db9dd
PE
6425 * xterm.c: Fix problems found by static analysis with other toolkits.
6426 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6427 (x_dispatch_event): Declare static if USE_GTK, and
6428 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6429 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6430 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6431 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6432 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6433
eb18f6cc
PE
6434 * xmenu.c (menu_help_callback): Pointer type fixes.
6435 Use const pointers when pointing at readonly data. Avoid pointer
6436 signedness clashes.
6437 (FALSE): Remove unused macro.
6438 (update_frame_menubar): Remove unused decl.
6439
1fe72bf8
PE
6440 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6441
60d9e1db
PE
6442 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6443 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6444 (single_menu_item): Rename local to avoid shadowing.
6445
39261c26
PE
6446 * keyboard.c (make_lispy_event): Remove unused local var.
6447
018c5e19
PE
6448 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6449 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6450
63d2b86e
PE
6451 * bitmaps: Change bitmaps from unsigned char back to the X11
6452 compatible char. Avoid the old compiler warnings about
6453 out-of-range initializers by using, for example, '\xab' rather
6454 than 0xab.
6455
aefd87e1
PE
6456 * xgselect.c (xgselect_initialize): Check vs interface
6457 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6458
bf501fb9
PE
6459 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6460
e9829fdf
PE
6461 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6462 to read-only memory.
6463
1086c095
PE
6464 * fns.c (vector): Remove; this old hack is no longer needed.
6465
2baccd04 6466 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6467 Remove unused var.
dde42981 6468 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6469
72391843 6470 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6471
436c16df 6472 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6473 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6474 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6475
92bb796d 6476 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6477 (x_term_init): Remove local to avoid shadowing.
92bb796d 6478
764430a3 6479 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6480
6481 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6482 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6483
d1dfb56c
EZ
64842011-04-16 Eli Zaretskii <eliz@gnu.org>
6485
c4354cb4
EZ
6486 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6487
d1dfb56c
EZ
6488 Fix regex.c, syntax.c and friends for buffers > 2GB.
6489 * syntax.h (struct gl_state_s): Declare character position members
6490 EMACS_INT.
6491
6492 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6493
04f2d78b
CB
6494 * textprop.c (verify_interval_modification, interval_of):
6495 Declare arguments EMACS_INT.
d1dfb56c
EZ
6496
6497 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6498 EMACS_INT.
6499
6500 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6501
6502 * indent.c (Fvertical_motion): Local variable it_start is now
6503 EMACS_INT.
6504
6505 * regex.c (re_match, re_match_2, re_match_2_internal)
6506 (bcmp_translate, regcomp, regexec, print_double_string)
6507 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6508 (re_compile_pattern, re_exec): Declare arguments and local
6509 variables `size_t' and `ssize_t' and return values `regoff_t', as
6510 appropriate.
6511 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6512 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6513 <compile_stack_type>: `size' and `avail' are now `size_t'.
6514
6515 * regex.h <regoff_t>: Use ssize_t, not int.
6516 (re_search, re_search_2, re_match, re_match_2): Arguments that
6517 specify buffer/string position and length are now ssize_t and
6518 size_t. Return type is regoff_t.
6519
613052cd
BK
65202011-04-16 Ben Key <bkey76@gmail.com>
6521
6522 * nsfont.m: Fixed bugs in ns_get_family and
6523 ns_descriptor_to_entity that were caused by using free to
6524 deallocate memory blocks that were allocated by xmalloc (via
6525 xstrdup). This caused Emacs to crash when compiled with
6526 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6527 --enable-checking=xmallocoverrun). xfree is now used to
6528 deallocate these memory blocks.
6529
4170f62f 65302011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6531
71b41406
PE
6532 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6533
9587a89d
PE
6534 emacs_write: Accept and return EMACS_INT for sizes.
6535 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6536 et seq.
6537 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6538 Accept and return EMACS_INT.
6539 (emacs_gnutls_write): Return the number of bytes written on
6540 partial writes.
6541 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6542 (emacs_read, emacs_write): Remove check for negative size, as the
6543 Emacs source code has been audited now.
9587a89d
PE
6544 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6545 (emacs_read, emacs_write): Use it.
273a5f82
PE
6546 * process.c (send_process): Adjust to the new signatures of
6547 emacs_write and emacs_gnutls_write. Do not attempt to store
6548 a byte offset into an 'int'; it might overflow.
9587a89d 6549 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6550
3e047f51
PE
6551 * sound.c: Don't assume sizes fit in 'int'.
6552 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6553 Return EMACS_INT, not int.
3e047f51 6554 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6555 Accept EMACS_INT, not int.
6556 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6557 record read return values.
6558
cc39a9db
BK
65592011-04-15 Ben Key <bkey76@gmail.com>
6560
c9d0ec6d
JB
6561 * keyboard.c (Qundefined): Don't declare static since it is used
6562 in nsfns.m.
6563 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6564 static since they are used in nsfont.m.
cc39a9db 6565
6c60eb9f
SM
65662011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6567
6568 * process.c (Qprocessp): Don't declare static.
6569 * lisp.h (Qprocessp): Declare again.
6570
7990b61a
JB
65712011-04-15 Juanma Barranquero <lekktu@gmail.com>
6572
6573 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6574
5d4cb038
PE
65752011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6576
8bd7b830 6577 Improve C-level modularity by making more things 'static'.
cd64ea1d 6578
e3b27b31
PE
6579 Don't publish debugger-only interfaces to other modules.
6580 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6581 (verify_bytepos, count_markers): Move decls to the only modules
6582 that need them.
6583 * region-cache.h (pp_cache): Likewise.
6584 * window.h (check_all_windows): Likewise.
6585 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6586
5d4cb038
PE
6587 * sysdep.c (croak): Now static, if
6588 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6589 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6590
6591 * alloc.c (refill_memory_reserve): Now static if
6592 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6593 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6594
e87b6180
PE
6595 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6596 Define only if USE_LUCID.
6597
ac64929e
PE
6598 * xrdb.c (x_customization_string, x_rm_string): Now static.
6599
6f37259d
PE
6600 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6601 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6602
1683e3ab
PE
6603 * xdisp.c (draw_row_with_mouse_face): Now static.
6604 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6605
de9c2632
PE
6606 * window.h (check_all_windows): Mark externally visible.
6607
2b96acb7
PE
6608 * window.c (window_deletion_count): Now static.
6609
6610 * undo.c: Make symbols static if they're not exported.
6611 (last_undo_buffer, last_boundary_position, pending_boundary):
6612 Now static.
6613
50436f33
PE
6614 * textprop.c (interval_insert_behind_hooks): Now static.
6615 (interval_insert_in_front_hooks): Likewise.
6616
64520e5c
PE
6617 * term.c: Make symbols static if they're not exported.
6618 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6619 (max_frame_lines, tty_set_terminal_modes):
6620 (tty_reset_terminal_modes, tty_turn_off_highlight):
6621 (get_tty_terminal): Now static.
6622 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6623 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6624 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6625 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6626 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6627
1fa53021
PE
6628 * sysdep.c: Make symbols static if they're not exported.
6629 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6630 Now static.
6631 (sigprocmask_set, full_mask): Remove; unused.
6632 (wait_debugging): Mark as visible.
6633 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6634 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6635
d4b43b22
PE
6636 * syntax.c (syntax_temp): Define only if !__GNUC__.
6637
b7c513d0
PE
6638 * sound.c (current_sound_device, current_sound): Now static.
6639
989b29ad
PE
6640 * search.c (searchbufs, searchbuf_head): Now static.
6641
13a55a78
PE
6642 * scroll.c (scroll_cost): Remove; unused.
6643 * dispextern.h (scroll_cost): Remove decl.
6644
de68a1fc
PE
6645 * region-cache.h (pp_cache): Mark as externally visible.
6646
40ccffa6
PE
6647 * process.c: Make symbols static if they're not exported.
6648 (process_tick, update_tick, create_process, chan_process):
6649 (Vprocess_alist, proc_buffered_char, datagram_access):
6650 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6651 (deactivate_process): Mark defn as static, as well as decl.
6652 * lisp.h (create_process): Remove decl.
6653 * process.h (chan_process, Vprocess_alist): Remove decls.
6654
ad64fc97
PE
6655 * print.c: Make symbols static if they're not exported.
6656 (print_depth, new_backquote_output, being_printed, print_buffer):
6657 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6658 (print_interval, print_number_index, initial_stderr_stream):
6659 Now static.
6660 * lisp.h (Fprinc): Remove decl.
6661 (debug_output_compilation_hack): Mark as externally visible.
6662
adddb265
PE
6663 * sysdep.c (croak): Move decl from here to syssignal.h.
6664 * syssignal.h (croak): Put it here, so the API can be checked when
6665 'croak' is called from dissociate_if_controlling_tty.
6666
1717ede2
PE
6667 * minibuf.c: Make symbols static if they're not exported.
6668 (minibuf_save_list, choose_minibuf_frame): Now static.
6669 * lisp.h (choose_minibuf_frame): Remove decl.
6670
fa5fb2bc
PE
6671 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6672
1e3890d1
PE
6673 * lread.c: Make symbols static if they're not exported.
6674 (read_objects, initial_obarray, oblookup_last_bucket_number):
6675 Now static.
6676 (make_symbol): Remove; unused.
6677 * lisp.h (initial_obarray, make_symbol): Remove decls.
6678
8a1414fa
PE
6679 * keyboard.c: Make symbols static if they're not exported.
6680 (single_kboard, recent_keys_index, total_keys, recent_keys):
6681 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6682 (this_single_command_key_start, echoing, last_auto_save):
6683 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6684 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6685 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6686 (Vlispy_mouse_stem, double_click_count):
6687 Now static.
6688 (force_auto_save_soon): Define only if SIGDANGER.
6689 (ignore_mouse_drag_p): Now static if
6690 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6691 (print_help): Remove; unused.
6692 (stop_character, last_timer_event): Mark as externally visible.
6693 * keyboard.h (ignore_mouse_drag_p): Declare only if
6694 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6695 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6696 * lisp.h (echoing): Remove decl.
6697 (force_auto_save_soon): Declare only if SIGDANGER.
6698 * xdisp.c (redisplay_window): Simplify code, to make it more
6699 obvious that ignore_mouse_drag_p is not accessed if !defined
6700 USE_GTK && !defined HAVE_NS.
6701
93ea6e8f
PE
6702 * intervals.c: Make symbols static if they're not exported.
6703 (merge_properties_sticky, merge_interval_right, delete_interval):
6704 Now static.
6705 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6706
77382fcc
PE
6707 * insdel.c: Make symbols static if they're not exported.
6708 However, leave prepare_to_modify_buffer alone. It's never
6709 called from outside this function, but that appears to be a bug.
6710 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6711 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6712 (adjust_after_replace_noundo): Remove; unused.
6713 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6714 (signal_before_change): Remove decls.
77382fcc 6715
9306c32e
PE
6716 * indent.c (val_compute_motion, val_vmotion): Now static.
6717
cd44d2eb
PE
6718 * image.c: Make symbols static if they're not exported.
6719 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6720 if USE_GTK.
6721 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6722 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6723
ad9a7a06
PE
6724 * fringe.c (standard_bitmaps): Now static.
6725 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6726
81626931
PE
6727 * frame.c: Make symbols static if they're not exported.
6728 (x_report_frame_params, make_terminal_frame): Now static.
6729 (get_frame_param): Now static, unless HAVE_NS.
6730 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6731 (x_get_resource_string): Remove; not used.
6732 * frame.h (make_terminal_frame, x_report_frame_params):
6733 (x_get_resource_string); Remove decls.
6734 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6735 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6736
239f9db9
PE
6737 * font.c, fontset.c: Make symbols static if they're not exported.
6738 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6739 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6740 * font.c (font_close_object): Now static.
6741 * font.h (font_close_object): Remove.
6742 * fontset.c (FONTSET_OBJLIST): Remove.
6743 (free_realized_fontset) #if-0 the body, which does nothing.
6744 (face_suitable_for_char_p): #if-0, as it's never called.
6745 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6746 * xfaces.c (face_at_string_position):
6747 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6748 since 0 is always ASCII.
6749
dfcf3579
PE
6750 * fns.c (weak_hash_tables): Now static.
6751
5045092b
PE
6752 * fileio.c: Make symbols static if they're not exported.
6753 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6754 (Vwrite_region_annotation_buffers): Now static.
6755
57a96f5c
PE
6756 * eval.c: Make symbols static if they're not exported.
6757 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6758 * lisp.h (backtrace_list): Remove decl.
6759
35f08c38
PE
6760 * emacs.c: Make symbols static if they're not exported.
6761 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6762 (fatal_error_code, fatal_error_signal_hook, standard_args):
6763 Now static.
6764 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6765 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6766 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6767 * lisp.h (fatal_error_signal_hook): Remove decl.
6768 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6769
f44bd759
PE
6770 * editfns.c: Move a (normally-unused) function to its only use.
6771 * editfns.c, lisp.h (get_operating_system_release): Remove.
6772 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6773 worth the hassle of breaking this out.
6774
b532497d
PE
6775 * xterm.c: Make symbols static if they're not exported.
6776 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6777 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6778 (x_destroy_window, x_delete_display):
6779 Now static.
6780 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6781 (x_mouse_leave): Remove; unused.
6782 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6783 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6784 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6785 Remove decls.
6786 (x_mouse_leave): Declare only if WINDOWSNT.
6787 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6788 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6789 USE_X_TOOLKIT.
6790
1675728f
PE
6791 * ftxfont.c: Make symbols static if they're not exported.
6792 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6793 HAVE_FREETYPE.
6794 * font.h (ftxfont_driver): Likewise.
6795
e4cebfca
PE
6796 * xfns.c: Make symbols static if they're not exported.
6797 (x_last_font_name, x_display_info_for_name):
6798 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6799 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6800 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6801 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6802 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6803 (last_show_tip_args): Now static.
6804 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6805 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6806 (x_screen_planes): Remove; unused.
6807 * dispextern.h (x_screen_planes): Remove decl.
6808
5bf46f05
PE
6809 * dispnew.c: Make symbols static if they're not exported.
6810 * dispextern.h (redraw_garbaged_frames, scrolling):
6811 (increment_row_positions): Remove.
6812 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6813 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6814 Now static.
6815 (redraw_garbaged_frames): Remove; unused.
6816
435f4c28
PE
6817 * xfaces.c: Make symbols static if they're not exported.
6818 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6819 Remove decls.
6820 * xterm.h (defined_color): Remove decls.
6821 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6822 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6823 (menu_face_changed_default, defined_color, free_realized_face):
6824 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6825 (ascii_face_of_lisp_face): Remove; unused.
6826
8524aef3
PE
6827 * xdisp.c: Make symbols static if they're not exported.
6828 * dispextern.h (scratch_glyph_row, window_box_edges):
6829 (glyph_to_pixel_coords, set_cursor_from_row):
6830 (get_next_display_element, set_iterator_to_next):
6831 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6832 (show_mouse_face): Remove decls
6833 * frame.h (message_buf_print): Likewise.
6834 * lisp.h (pop_message, set_message, check_point_in_composition):
6835 Likewise.
6836 * xterm.h (set_vertical_scroll_bar): Likewise.
6837 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6838 (message_buf_print, scratch_glyph_row, displayed_buffer):
6839 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6840 (get_next_display_element, show_mouse_face, window_box_edges):
6841 (frame_to_window_pixel_xy, check_point_in_composition):
6842 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6843 (glyph_to_pixel_coords): Remove; unused.
6844
16390cd2
PE
6845 * dired.c (file_name_completion): Now static.
6846
6847 * dbusbind.c (xd_in_read_queued_messages): Now static.
6848
a25f4dfa
PE
6849 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6850 * data.c (circular_list_error): Remove.
6851
14a9c8df
PE
6852 * commands.h (last_point_position, last_point_position_buffer):
6853 (last_point_position_window): Remove decls.
6854 * keyboard.c: Make these variables static.
6855
04f2d78b
CB
6856 * coding.h (coding, code_convert_region, encode_coding_gap):
6857 Remove decls.
74ab6df5
PE
6858 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6859 (iso_code_class, detect_coding, code_convert_region): Now static.
6860 (encode_coding_gap): Remove; unused.
6861
38dfbee1
PE
6862 * chartab.c (chartab_chars, chartab_bits): Now static.
6863
a2cb4e63
PE
6864 * charset.h (charset_iso_8859_1): Remove decl.
6865 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6866 Now static.
6867
127198fd
PE
6868 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6869 * ccl.c (Vccl_program_table): Now static.
6870 (check_ccl_update): Remove; unused.
6871
d85b608f
PE
6872 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6873 * category.h: ... from here.
6874 * category.c (check_category_table, set_category_set): Now static.
6875
31cd66f3
PE
6876 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6877 * lisp.h: Remove these decls.
6878
c358e587
PE
6879 * buffer.c (buffer_count): Remove unused var.
6880
e78aecca
PE
6881 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6882 so that it's not optimized away.
6883 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6884 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6885 exported only to the debugger.
6886
e192d7d3 6887 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6888 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6889
92470028
PE
6890 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6891 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6892 was inaccessible from Lisp.
6893 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6894 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6895
244ed907
PE
6896 alloc.c: Import and export fewer symbols, and remove unused items.
6897 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6898 is defined.
6899 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6900 it's not optimized away by whole-program optimization.
6901 (message_enable_multibyte, free_misc): Remove.
6902 (catchlist, handlerlist, mark_backtrace):
6903 Declare only if BYTE_MARK_STACK.
6904 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6905 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6906 (message_enable_multibyte): Remove decl.
6907 (free_misc, interval_free_list, float_block, float_block_index):
6908 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6909 (cons_free_list, last_marked_index):
6910 Now static.
6911 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6912 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6913 (mark_backtrace): Define only if BYTE_MARK_STACK.
6914 * xdisp.c (message_enable_multibyte): Now static.
6915
61c2b50e 6916 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6917 This makes it easier for human readers (and static analyzers)
6918 to see whether these variables are used from other modules.
6919 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6920 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6921 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6922 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6923 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6924 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6925 * xmenu.c, xselect.c:
6926 Declare Q* vars static if they are not used in other modules.
6927 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6928 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6929 Remove decls of unexported vars.
6930 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6931
95c82688
PE
6932 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6933
16a97296
PE
6934 Make Emacs functions such as Fatom 'static' by default.
6935 This makes it easier for human readers (and static analyzers)
6936 to see whether these functions can be called from other modules.
6937 DEFUN now defines a static function. To make the function external
6938 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6939 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6940 (Finit_image_library):
16a97296
PE
6941 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6942 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6943 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6944 Remove decls, since these functions are now static.
6945 (Funintern, Fget_internal_run_time): New decls, since these functions
6946 were already external.
95c82688 6947
16a97296
PE
6948 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6949 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6950 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6951 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6952 * keyboard.c, keymap.c, lread.c:
6953 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6954 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6955 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6956 Mark functions with DEFUE instead of DEFUN,
6957 if they are used in other modules.
6958 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6959 decls for now-static functions.
6960 * buffer.h (Fdelete_overlay): Remove decl.
6961 * callproc.c (Fgetenv_internal): Mark as internal.
6962 * composite.c (Fremove_list_of_text_properties): Remove decl.
6963 (Fcomposition_get_gstring): New forward static decl.
6964 * composite.h (Fcomposite_get_gstring): Remove decl.
6965 * dired.c (Ffile_attributes): New forward static decl.
6966 * doc.c (Fdocumntation_property): New forward static decl.
6967 * eval.c (Ffetch_bytecode): New forward static decl.
6968 (Funintern): Remove extern decl; now in .h file where it belongs.
6969 * fileio.c (Fmake_symbolic_link): New forward static decl.
6970 * image.c (Finit_image_library): New forward static decl.
6971 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6972 * intervals.h (Fprevious_property_change):
6973 (Fremove_list_of_text_properties): Remove decls.
6974 * keyboard.c (Fthis_command_keys): Remove decl.
6975 (Fcommand_execute): New forward static decl.
6976 * keymap.c (Flookup_key): New forward static decl.
6977 (Fcopy_keymap): Now static.
6978 * keymap.h (Flookup_key): Remove decl.
6979 * process.c (Fget_process): New forward static decl.
6980 (Fprocess_datagram_address): Mark as internal.
6981 * syntax.c (Fsyntax_table_p): New forward static decl.
6982 (skip_chars): Remove duplicate decl.
6983 * textprop.c (Fprevious_property_change): New forward static decl.
6984 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6985 Now internal.
6986 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6987 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6988
785bbd42
PE
6989 * editfns.c (Fformat): Remove unreachable code.
6990
8b913b57
AS
69912011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6992
6993 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6994 change. (Bug#8496)
6995
a6744a35
EZ
69962011-04-13 Eli Zaretskii <eliz@gnu.org>
6997
6998 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6999 when at ZV. (Bug#8487)
7000
e7974947
AS
70012011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7002
baad03f0
AS
7003 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7004 (Bug#8437)
7005 * keyboard.c (parse_tool_bar_item): Likewise.
7006 * sound.c (sound_cleanup, alsa_close): Likewise.
7007 * termcap.c (tgetent): Likewise.
7008 * xfns.c (x_default_font_parameter): Likewise.
7009 * xsettings.c (read_and_apply_settings): Likewise.
7010
e7974947
AS
7011 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7012 (overrun_check_free): Protoize.
7013
28272684
PE
70142011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7015
7016 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7017 since callers should never pass a negative size.
7018 Change the signature to match that of plain 'read' and 'write'; see
7019 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7020 * lisp.h: Update prototypes of emacs_write and emacs_read.
7021
11997c76
EZ
70222011-04-11 Eli Zaretskii <eliz@gnu.org>
7023
7024 * xdisp.c (redisplay_window): Don't try to determine the character
7025 position of the scroll margin if the window start point w->startp
e896f03c 7026 is outside the buffer's accessible region. (Bug#8468)
11997c76 7027
8a2cbd72
EZ
70282011-04-10 Eli Zaretskii <eliz@gnu.org>
7029
7030 Fix write-region and its subroutines for buffers > 2GB.
7031 * fileio.c (a_write, e_write): Modify declaration of arguments and
7032 local variables to support buffers larger than 2GB.
7033 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7034
7035 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7036 argument, local variables, and return value.
7037
7038 * lisp.h: Update prototypes of emacs_write and emacs_read.
7039
7040 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7041
4073e537 70422011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7043
1ebfdcb6
PE
7044 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7045
b2ded58d
PE
7046 Fix more problems found by GCC 4.6.0's static checks.
7047
7d66342c
PE
7048 * xdisp.c (vmessage): Use a better test for character truncation.
7049
bbf47d44
PE
7050 * charset.c (load_charset_map): <, not <=, for optimization,
7051 and to avoid potential problems with integer overflow.
9248994d 7052 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7053 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7054 * editfns.c (Fformat): Likewise.
1e69125e 7055 * syntax.c (skip_chars): Likewise.
3befa583 7056
e3019616
PE
7057 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7058 This also lets GCC 4.6.0 generate slightly better loop code.
7059
becfa255
PE
7060 * callint.c (Fcall_interactively): <, not <=, for optimization.
7061 (Fcall_interactively): Count the number of arguments produced,
7062 not the number of arguments given. This is simpler and lets GCC
7063 4.6.0 generate slightly better code.
7064
dae0cd48
PE
7065 * ftfont.c: Distingish more carefully between FcChar8 and char.
7066 The previous code passed unsigned char * to a functions like
7067 strlen and xstrcasecmp that expect char *, which does not
7068 conform to the C standard.
7069 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7070 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7071 char * when the C standard requires it.
7072
76032d70
PE
7073 * keyboard.c (read_char): Remove unused var.
7074
eb3f1cc8
PE
7075 * eval.c: Port to Windows vsnprintf (Bug#8435).
7076 Include <limits.h>.
7077 (SIZE_MAX): Define if the headers do not.
7078 (verror): Do not give up if vsnprintf returns a negative count.
7079 Instead, grow the buffer. This ports to Windows vsnprintf, which
7080 does not conform to C99. Problem reported by Eli Zaretskii.
7081 Also, simplify the allocation scheme, by avoiding the need for
7082 calling realloc, and removing the ALLOCATED variable.
7083
70476b54
PE
7084 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7085
12020a9e
PE
7086 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7087 But keep the doprint source code for now, as we might revamp it
7088 and use it again (Bug#8435).
ea6c7ae6
PE
7089 * lisp.h (doprnt): Remove.
7090 * Makefile.in (base_obj): Remove doprnt.o.
7091 * deps.mk (doprnt.o): Remove.
7092
5fdb398c
PE
7093 error: Print 32- and 64-bit integers portably (Bug#8435).
7094 Without this change, on typical 64-bit hosts error ("...%d...", N)
7095 was used to print both 32- and 64-bit integers N, which relied on
7096 undefined behavior.
7097 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7098 New macro.
7099 * lisp.h (error, verror): Mark as printf-like functions.
7100 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7101 Report overflow in size calculations when allocating printf buffer.
7102 Do not truncate output string at its first null byte.
7103 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7104 Truncate the output at a character boundary, since vsnprintf does not
7105 do that.
7106 * charset.c (check_iso_charset_parameter): Convert internal
7107 character to string before calling 'error', since %c now has the
7108 printf meaning.
7109 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7110 overflow when computing char to be passed to 'error'. Do not
7111 pass Lisp_Object to 'error'; pass the integer instead.
7112 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7113 formatted with plain %d.
7114
b189fa66
PE
7115 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7116
bff87ef0
PE
7117 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7118
7e2cac20
PE
7119 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7120
ce4d90b5
PE
7121 * xterm.c (x_catch_errors): Remove duplicate declaration.
7122
266c9547
PE
7123 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7124
79c49ad2
PE
7125 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7126
368f4090
JM
71272011-04-10 Jim Meyering <meyering@redhat.com>
7128
7129 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7130 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7131 return ssize_t not "int", and use size_t as the buffer length.
7132 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7133 * gnutls.h: Update declarations.
7134 * process.c (read_process_output): Use ssize_t, to match.
7135 (send_process): Likewise.
7136
a32d4040
CY
71372011-04-09 Chong Yidong <cyd@stupidchicken.com>
7138
7139 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7140
8546720e 71412011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7142
04f2d78b
CB
7143 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7144 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7145
8546720e
GM
7146 * xterm.c (handle_one_xevent):
7147 * xmenu.c (create_and_show_popup_menu):
7148 * xselect.c (x_decline_selection_request)
7149 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7150
0a2f5c1a 71512011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7152
7153 Fix some uses of `int' instead of EMACS_INT.
7154 * search.c (string_match_1, fast_string_match)
7155 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7156 (scan_buffer, find_next_newline_no_quit)
7157 (find_before_next_newline, search_command, Freplace_match)
7158 (Fmatch_data): Make some `int' variables be EMACS_INT.
7159
7160 * xdisp.c (display_count_lines): 3rd argument and return value now
7161 EMACS_INT. All callers changed.
7162 (pint2hrstr): Last argument is now EMACS_INT.
7163
7164 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7165 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7166 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7167 (decode_coding_utf_16, decode_coding_emacs_mule)
7168 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7169 (decode_coding_ccl, decode_coding_charset)
7170 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7171 (decode_coding_iso_2022, decode_coding_emacs_mule)
7172 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7173 <char_offset, last_offset>: Declare EMACS_INT.
7174 (encode_coding_utf_8, encode_coding_utf_16)
7175 (encode_coding_emacs_mule, encode_invocation_designation)
7176 (encode_designation_at_bol, encode_coding_iso_2022)
7177 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7178 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7179 Declare EMACS_INT.
7180 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7181 (encode_invocation_designation): Last argument P_NCHARS is now
7182 EMACS_INT.
7183 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7184 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7185
7186 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7187 All users changed.
7188
7189 * ccl.c (Fccl_execute_on_string): Declare some variables
7190 EMACS_INT.
7191
8546720e 71922011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7193
7194 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7195
4e19a977
CS
71962011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7197
7198 * process.c (Fformat_network_address): Doc fix.
7199
87302331
R
72002011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7201
ee7683eb 7202 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7203
cbb59342
CY
72042011-04-08 Chong Yidong <cyd@stupidchicken.com>
7205
7206 * keyboard.c (read_char): Call Lisp function help-form-show,
7207 instead of using internal_with_output_to_temp_buffer.
7208 (Qhelp_form_show): New var.
e0d38eeb 7209 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7210
7211 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7212
7213 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7214
e67a13ab
CY
72152011-04-06 Chong Yidong <cyd@stupidchicken.com>
7216
04f2d78b
CB
7217 * process.c (Flist_processes): Remove to Lisp.
7218 (list_processes_1): Delete.
e67a13ab 7219
973f782d
EZ
72202011-04-06 Eli Zaretskii <eliz@gnu.org>
7221
7c106b1e
EZ
7222 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7223
973f782d
EZ
7224 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7225
41cf7d1a 72262011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7227
ca23cc88
PE
7228 Fix more problems found by GCC 4.6.0's static checks.
7229
f390e2d5
PE
7230 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7231
42eea0d0
PE
7232 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7233
b69769da 7234 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7235
f9541e84
PE
7236 * xdisp.c (vmessage): Mark as a printf-like function.
7237
13841b55
PE
7238 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7239
c136c10f
PE
7240 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7241
5e2d4a30
PE
7242 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7243 printf-like functions.
7244 (tiff_load): Add casts to remove these marks before passing them
7245 to system-supplied API.
7246
583f48b9
PE
7247 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7248
b25d760e
PE
7249 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7250 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7251 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7252 directly, rather than having caller test rule sign. This avoids
7253 some unnecessary tests.
7254 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7255 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7256 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7257
bc7b6697 7258 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7259 (xfont_open): Avoid unnecessary tests.
bc7b6697 7260
27ccc379
PE
7261 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7262
dcd5c89a
PE
7263 * composite.h, composite.c (composition_gstring_put_cache):
7264 Use EMACS_INT, not int, for length.
7265
b13a45c6
PE
7266 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7267 breaking out part of COMPOSITION_DECODE_RULE.
7268 (COMPOSITION_DECODE_RULE): Use it.
7269 * composite.c (get_composition_id): Remove unused local vars,
7270 by using the new macro.
7271
1e792e4d
PE
7272 * textprop.c (set_text_properties_1): Change while to do-while,
7273 since the condition is always true at first.
7274
dc6c6455 7275 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7276 (interval_deletion_adjustment): Return unsigned value.
7277 All uses changed.
dc6c6455 7278
aba7731a
PE
7279 * process.c (list_processes_1, create_pty, read_process_output):
7280 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7281 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7282 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7283 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7284 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7285
fdfc4bf3
PE
7286 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7287
fca8fe46 7288 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7289 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7290
06a0259a 7291 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7292 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7293 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7294
e7b9e80f
PE
7295 * print.c (print_error_message): Avoid int overflow.
7296
56201685
PE
7297 * font.c (font_list_entities): Redo for clarity,
7298 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7299
78834453 7300 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7301 (font_score): Avoid potential overflow in diff calculation.
78834453 7302
0bc0b309 7303 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7304 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7305
e610eaca
PE
7306 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7307
b895abce
PE
7308 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7309 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7310 can always succeed if overflow has undefined behavior.
7311
1f1d9321 7312 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7313 (wordify): Omit three unnecessary tests.
1f1d9321 7314
c59478bc
PE
7315 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7316 All callers changed. This avoids the need for an unused var.
7317
79b73827
PE
7318 * casefiddle.c (casify_region): Remove var that is set but not used.
7319
a4db5dfe
PE
7320 * dired.c (file_name_completion): Remove var that is set but not used.
7321
43aae36e
PE
7322 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7323
2a47c44d 7324 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7325 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7326
a37c69bf
PE
7327 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7328 Check for integer overflow on size calculations.
7329
328ab8e7
PE
7330 * buffer.c (Fprevious_overlay_change): Remove var that is set
7331 but not used.
7332
e5a2a5cb
PE
7333 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7334 Remove vars that are set but not used.
8d84a6eb 7335 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7336 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7337
a60e5f68
PE
7338 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7339
f661cb61 7340 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7341 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7342
f0397f5a
PE
7343 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7344 that are set but not used.
7345
8664db06 7346 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7347 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7348
6abdaa4a
PE
7349 * xselect.c (x_get_local_selection, x_handle_property_notify):
7350 Remove vars that are set but not used.
7351
0ce7538d 7352 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7353 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7354
9ae848fc
PE
7355 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7356 Remove var that is set but not used.
0b918413
PE
7357 (scroll_bar_windows_size): Now size_t, not int.
7358 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7359 Check for overflow.
9ae848fc 7360
a5a62657
PE
7361 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7362 (map_tty_color) [!defined MSDOS]: Likewise.
7363
5c5cdd39
PE
7364 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7365
66ebf983
PE
7366 * coding.c: Remove vars that are set but not used.
7367 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7368 All callers changed.
7369 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7370 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7371 (decode_coding_charset): Remove vars that are set but not used.
7372
1be4d761
PE
7373 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7374 that is set but not used.
7375
47553fa8
PE
7376 * print.c (print_object): Remove var that is set but not used.
7377
1f7196bf 7378 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7379 The gnulib version avoids calling malloc in the usual case,
7380 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7381 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7382 * filelock.c (current_lock_owner): Likewise.
7383 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7384 * sysdep.c: Include allocator.h, careadlinkat.h.
7385 (emacs_no_realloc_allocator): New static constant.
7386 (emacs_readlink): New function.
fdb61804
PE
7387 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7388 ../lib/careadlinkat.h.
d1fdcab7 7389
f84c17c7
SM
73902011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7391
7392 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7393 first non-nil return value).
7394
ef3862ad
JD
73952011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7396
7397 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7398 if not defined (Bug#8403).
7399
376a7006
JB
74002011-04-02 Juanma Barranquero <lekktu@gmail.com>
7401
7402 * xdisp.c (display_count_lines): Remove parameter `start',
7403 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7404 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7405 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7406 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7407 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7408 and thereabouts. All callers changed.
7409 (get_per_char_metric): Remove parameter `f', unused since
7410 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7411
6ca3801d
JM
74122011-04-02 Jim Meyering <meyering@redhat.com>
7413
7414 do not dereference NULL upon failed strdup
7415 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7416 (ns_get_family): Likewise.
7417
d8e2b5ba
JB
74182011-04-02 Juanma Barranquero <lekktu@gmail.com>
7419
7420 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7421
8c74fcbd
JD
74222011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7423
7424 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7425 later (Bug#8403).
7426
7200d79c
SM
74272011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7428
03408648 7429 Add lexical binding.
7200d79c 7430
03408648
SM
7431 * window.c (Ftemp_output_buffer_show): New fun.
7432 (Fsave_window_excursion):
7433 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7434
7435 * lread.c (lisp_file_lexically_bound_p): New function.
7436 (Fload): Bind Qlexical_binding.
7437 (readevalloop): Remove `evalfun' arg.
7438 Bind Qinternal_interpreter_environment.
7439 (Feval_buffer): Bind Qlexical_binding.
7440 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7441 Mark as dynamic.
7442 (syms_of_lread): Declare `lexical-binding'.
7443
7444 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7445
7446 * keyboard.c (eval_dyn): New fun.
7447 (menu_item_eval_property): Use it.
ca105506
SM
7448
7449 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7450
03408648
SM
7451 * fns.c (concat, mapcar1): Accept byte-code-functions.
7452
7453 * eval.c (Fsetq): Handle lexical vars.
7454 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7455 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7456 (FletX, Flet): Obey lexical binding.
7457 (Fcommandp): Handle closures.
7458 (Feval): New `lexical' arg.
7459 (eval_sub): New function extracted from Feval. Use it almost
7460 everywhere where Feval was used. Look up vars in lexical env.
7461 Handle closures.
7462 (Ffunctionp): Move from subr.el.
7463 (Ffuncall): Handle closures.
7464 (apply_lambda): Remove `eval_flags'.
7465 (funcall_lambda): Handle closures and new byte-code-functions.
7466 (Fspecial_variable_p): New function.
7467 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7468 but without exporting it to Lisp.
23aba0ea 7469
23aba0ea 7470 * doc.c (Fdocumentation, store_function_docstring):
03408648 7471 * data.c (Finteractive_form): Handle closures.
23aba0ea 7472
03408648
SM
7473 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7474 interactive spec.
ba83908c 7475
04f2d78b
CB
7476 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7477 New byte-codes.
03408648
SM
7478 (exec_byte_code): New function extracted from Fbyte_code to handle new
7479 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7480
03408648 7481 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7482
03408648 7483 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7484
e2abce01
JB
74852011-03-31 Juanma Barranquero <lekktu@gmail.com>
7486
7487 * xdisp.c (redisplay_internal): Fix prototype.
7488
63696a73 74892011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7490
63696a73 7491 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7492 (try_scrolling): Use it when setting scroll_limit.
7493 Limit scrolling to 100 screen lines.
63696a73
EZ
7494 (redisplay_window): Even when falling back on "recentering",
7495 position point in the window according to scroll-conservatively,
7496 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7497
7498 (try_scrolling): When point is above the window, allow searching
7499 as far as scroll_max, or one screenful, to compute vertical
7500 distance from PT to the scroll margin position. This prevents
7501 try_scrolling from unnecessarily failing when
7502 scroll-conservatively is set to a value slightly larger than the
7503 window height. Clean up the case of PT below the margin at bottom
7504 of window: scroll_max can no longer be INT_MAX. When aggressive
7505 scrolling is in use, don't let point enter the opposite scroll
7506 margin as result of the scroll.
7507 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7508 threshold of 100 lines for never-recentering scrolling.
7509
e4cc2dfc
JB
75102011-03-31 Juanma Barranquero <lekktu@gmail.com>
7511
7512 * dispextern.h (move_it_by_lines):
7513 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7514 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7515 (message_log_check_duplicate): Remove parameters `prev_bol' and
7516 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7517 (redisplay_internal): Remove parameter `preserve_echo_area',
7518 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7519
7520 * indent.c (Fvertical_motion):
7521 * window.c (window_scroll_pixel_based, Frecenter):
7522 Don't pass `need_y_p' to `move_it_by_lines'.
7523
1c470562
SM
75242011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7525
44f230aa
SM
7526 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7527 steal a few bits to be more compact.
7528 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7529 Remove unneeded casts.
7530
1c470562
SM
7531 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7532
888adce9
ZK
75332011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7534
7535 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7536 binding" message (bug#7967).
7537
f838ed7b
PE
75382011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7539
77861b95
PE
7540 Fix more problems found by GCC 4.6.0's static checks.
7541
de6dbc14
PE
7542 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7543 Remove unused local var.
7544
f838ed7b
PE
7545 * editfns.c (Fmessage_box): Remove unused local var.
7546
792c7b2b
PE
7547 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7548 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7549 Omit unused local vars.
c499e557 7550 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7551 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7552 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7553 Omit unused local var.
7554
ba0165e1
PE
7555 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7556 Don't assume string length fits in int.
32ad8845 7557 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7558 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7559
3c59b4c9
PE
7560 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7561 instead of alloca (Bug#8344).
7562
a3eed478 7563 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7564 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7565
eb4d412d
PE
7566 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7567
1658b401
PE
7568 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7569 concerns.
7570
7571 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7572
7573 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7574
9a2c6e05
PE
7575 * keyboard.c (syms_of_keyboard): Use the same style as later
7576 in this function when indexing through an array. This also
7577 works around GCC bug 48267.
7578
03d0a109
PE
7579 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7580
44f730c8
PE
7581 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7582
fe75f926
PE
7583 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7584 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7585
ffa8c828
PE
7586 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7587 This avoids undefined behavior on integer overflow, and is a bit
7588 more convenient anyway since it is compared to a size_t variable.
7589
c5101a77
PE
7590 Variadic C functions now count arguments with size_t, not int.
7591 This avoids an unnecessary limitation on 64-bit machines, which
7592 caused (substring ...) to crash on large vectors (Bug#8344).
7593 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7594 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7595 All variadic functions and their callers changed accordingly.
c5101a77
PE
7596 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7597 * data.c (arith_driver, float_arith_driver): Likewise.
7598 * editfns.c (general_insert_function): Likewise.
7599 * eval.c (struct backtrace.nargs, interactive_p)
7600 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7601 (funcall_lambda, mark_backtrace): Likewise.
7602 * fns.c (concat): Likewise.
7603 * frame.c (x_set_frame_parameters): Likewise.
7604 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7605 0 if not found, not -1. All callers changed.
7606
dd3f25f7
PE
7607 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7608 (stack_copy_size): Now size_t, not int.
7609 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7610
461c2ab9
JB
76112011-03-28 Juanma Barranquero <lekktu@gmail.com>
7612
7613 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7614 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7615 All callers changed.
7616
7617 * lisp.h (multibyte_char_to_unibyte):
7618 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7619 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7620 * character.h (CHAR_TO_BYTE8):
7621 * cmds.c (internal_self_insert):
7622 * editfns.c (general_insert_function):
7623 * keymap.c (push_key_description):
7624 * search.c (Freplace_match):
7625 * xdisp.c (message_dolog, set_message_1): All callers changed.
7626
f6d62986
SM
76272011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7628
7629 * keyboard.c (safe_run_hook_funcall): New function.
7630 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7631 don't set the hook to nil, but remove the offending function instead.
7632 (Qcommand_hook_internal): Remove, unused.
7633 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7634 Vcommand_hook_internal.
7635
7636 * eval.c (enum run_hooks_condition): Remove.
7637 (funcall_nil, funcall_not): New functions.
7638 (run_hook_with_args): Call each function through a `funcall' argument.
7639 Remove `cond' argument, now redundant.
7640 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7641 (Frun_hook_with_args_until_failure): Adjust accordingly.
7642 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7643
1db5b1ad
JB
76442011-03-28 Juanma Barranquero <lekktu@gmail.com>
7645
7646 * dispextern.h (string_buffer_position): Remove declaration.
7647
7648 * print.c (strout): Remove parameter `multibyte', unused since
7649 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7650
7651 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7652 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7653 All callers changed.
7654
7655 * w32.c (_wsa_errlist): Use braces for struct initializers.
7656
7657 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7658 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7659 All callers changed.
7660 (string_buffer_position): Likewise. Also, make static (it's never
7661 used outside xdisp.c).
7662 (cursor_row_p): Remove parameter `w', unused since
7663 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7664 (decode_mode_spec): Remove parameter `precision', introduced during
7665 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7666 All callers changed.
7667
5ffb62aa
JD
76682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7669
7670 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7671
461c2ab9 76722011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7673
7674 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7675 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7676 (ns_update_auto_hide_menu_bar): New functions.
7677 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7678 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7679 ns_constrain_all_frames.
7680 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7681 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7682
5c380ffb
JD
76832011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7684
7685 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7686
9af30bdf
GM
76872011-03-27 Glenn Morris <rgm@gnu.org>
7688
7689 * syssignal.h: Replace RETSIGTYPE with void.
7690 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7691 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7692 Replace SIGTYPE with void everywhere.
7693 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7694 * s/template.h (SIGTYPE): Remove commented out definition.
7695
e2abce01
JB
76962011-03-26 Eli Zaretskii <eliz@gnu.org>
7697
7698 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7699 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7700
f868cd8a
JB
77012011-03-26 Juanma Barranquero <lekktu@gmail.com>
7702
59eb0929
JB
7703 * w32.c (read_unc_volume): Use parameter `henum', instead of
7704 global variable `wget_enum_handle'.
7705
7706 * keymap.c (describe_vector): Remove parameters `indices' and
7707 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7708 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7709
f868cd8a
JB
7710 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7711
7712 * keyboard.c (timer_check): Remove parameter `do_it_now',
7713 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7714 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7715 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7716
7717 * keyboard.c (read_char):
7718 * w32menu.c (w32_menu_display_help):
7719 * xmenu.c (show_help_event, menu_help_callback):
7720 Adjust calls to `show_help_echo'.
7721
7722 * gtkutil.c (xg_maybe_add_timer):
7723 * keyboard.c (readable_events):
7724 * process.c (wait_reading_process_output):
7725 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7726
7727 * insdel.c (adjust_markers_gap_motion):
7728 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7729 (gap_left, gap_right): Don't call it.
7730
2ecf6fdb
CY
77312011-03-25 Chong Yidong <cyd@stupidchicken.com>
7732
7733 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7734 incurred during fontification.
7735
6b1f9ba4
JB
77362011-03-25 Juanma Barranquero <lekktu@gmail.com>
7737
7738 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7739 (DEFVAR_PER_BUFFER): Don't pass it.
7740
7741 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7742 (scrolling_window): Don't pass it.
7743
0f4a96b5
JB
77442011-03-25 Juanma Barranquero <lekktu@gmail.com>
7745
7746 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7747
7748 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7749 and `suffix'.
7750 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7751 of variables specific to SELinux and computation of `encoded_absname'.
7752
7753 * image.c (XPutPixel): Remove unused variable `height'.
7754
7755 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7756
7757 * unexw32.c (get_section_info): Remove unused variable `section'.
7758
7759 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7760 (system_process_attributes): Remove unused variable `sess'.
7761 (sys_read): Remove unused variable `err'.
7762
7763 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7764 (w32_wnd_proc): Remove unused variable `isdead'.
7765 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7766 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7767 (x_create_tip_frame): Remove unused variable `tem'.
7768
7769 * w32inevt.c (w32_console_read_socket):
7770 Remove unused variable `no_events'.
7771
7772 * w32term.c (x_draw_composite_glyph_string_foreground):
7773 Remove unused variable `width'.
7774
1149507c
JB
77752011-03-24 Juanma Barranquero <lekktu@gmail.com>
7776
7777 * w32term.c (x_set_glyph_string_clipping):
7778 Don't pass uninitialized region to CombineRgn.
7779
9c88f339
JB
77802011-03-23 Juanma Barranquero <lekktu@gmail.com>
7781
7782 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7783 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7784 (Fx_close_connection): Remove unused variable `i'.
7785
7786 * w32font.c (w32font_draw): Return number of glyphs.
7787 (w32font_open_internal): Remove unused variable `i'.
7788 (w32font_driver): Add missing initializer.
7789
7790 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7791 (fill_in_menu): Remove unused variable `items_added'.
7792
7793 * w32term.c (last_mouse_press_frame): Remove static global variable.
7794 (w32_clip_to_row): Remove unused variable `f'.
7795 (x_delete_terminal): Remove unused variable `i'.
7796
7797 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7798 (NOTHING): Remove unused static global variable.
7799 (uniscribe_check_otf): Remove unused variable `table'.
7800 (uniscribe_font_driver): Add missing initializers.
7801
dee091a3
JD
78022011-03-23 Julien Danjou <julien@danjou.info>
7803
7804 * term.c (Fsuspend_tty, Fresume_tty):
7805 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7806 * window.c (temp_output_buffer_show):
7807 * insdel.c (signal_before_change):
7808 * frame.c (Fhandle_switch_frame):
7809 * fileio.c (Fdo_auto_save):
7810 * emacs.c (Fkill_emacs):
7811 * editfns.c (save_excursion_restore):
7812 * cmds.c (internal_self_insert):
7813 * callint.c (Fcall_interactively):
7814 * buffer.c (Fkill_all_local_variables):
7815 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7816 Use Frun_hooks.
0f4a96b5 7817 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7818 unconditionally since it does the check itself.
dee091a3 7819
2c520ab5 78202011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7821
c9c49752
PE
7822 Fix more problems found by GCC 4.5.2's static checks.
7823
8abc3f12
PE
7824 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7825 the first time through the loop, since we know p0 < p1 then.
7826 This also avoids a gcc -Wstrict-overflow warning.
7827
a2d26660
PE
7828 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7829 leading to a memory leak, possible in functions like
7830 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7831 of objects (Bug#8318).
a2d26660 7832
916c72e9
PE
7833 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7834 that could (at least in theory) be that large.
7835
19ab8a18
PE
7836 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7837 This is less likely to overflow, and avoids undefined behavior if
7838 overflow does occur. All callers changed. Use strtoul to scan
7839 for the unsigned long integer.
b7cbbd6f
PE
7840 (pint2hrstr): Simplify and tune code slightly.
7841 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7842
f0641eff
PE
7843 * scroll.c (do_scrolling): Work around GCC bug 48228.
7844 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7845
7f650bb9
PE
7846 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7847 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7848 (validate_x_resource_name): Simplify count usage.
7849 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7850
37dd57d1
PE
7851 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7852 fail (Bug#8306).
81e56e61 7853
699979fc 7854 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7855
401bf9b4
PE
7856 * process.c (Fmake_network_process): Use socklen_t, not int,
7857 where POSIX says socklen_t is required in portable programs.
7858 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7859 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7860 (Fmake_network_process, server_accept_connection):
7861 (wait_reading_process_output, read_process_output):
7862 Likewise.
7863
b93aacde
PE
7864 * process.c: Rename or move locals to avoid shadowing.
7865 (list_processes_1, Fmake_network_process):
7866 (read_process_output_error_handler, exec_sentinel_error_handler):
7867 Rename or move locals.
4dc343ee 7868 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7869 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7870 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7871 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7872 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7873
af8a867c 7874 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7875 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7876 Include tparam.h instead, since it declares them.
af8a867c
PE
7877 * cm.h (PC): Remove extern decl; tparam.h now does this.
7878 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7879 * terminfo.c: Include tparam.h, to check interfaces.
7880 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7881 (tparam): Adjust signature to match interface in tparam.h;
7882 this removes some undefined behavior. Check that outstring and len
7883 are zero, which they always are with Emacs.
7884 * tparam.h (PC, BC, UP): New extern decls.
7885
0248044d 7886 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7887 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7888
8ff096c1 7889 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7890 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7891 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7892 (ftfont_list): Remove unused local.
49eaafba
PE
7893 (get_adstyle_property, ftfont_pattern_entity):
7894 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7895 Rename locals to avoid shadowing.
8ff096c1 7896
e2be39f6
PE
7897 * xfont.c (xfont_list_family): Mark var as initialized.
7898
c9735e30
PE
7899 * xml.c (make_dom): Now static.
7900
8f5201ae
PE
7901 * composite.c (composition_compute_stop_pos): Rename local to
7902 avoid shadowing.
b246f932
PE
7903 (composition_reseat_it): Remove unused locals.
7904 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7905 (composition_update_it): Mark var as initialized.
11b61122
PE
7906 (find_automatic_composition): Mark vars as initialized,
7907 with a FIXME (Bug#8290).
8f5201ae 7908
760fbc2c
PE
7909 character.h: Rename locals to avoid shadowing.
7910 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7911 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7912 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7913 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7914 to avoid shadowing.
7915
ff08eb85
PE
7916 * textprop.c (property_change_between_p): Remove; unused.
7917
fc7bf025
PE
7918 * intervals.c (interval_start_pos): Now static.
7919
235d7abc
PE
7920 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7921
44f230aa
SM
7922 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7923 Rename locals to avoid shadowing.
3e7d6594 7924
50060332
PE
7925 * sound.c (wav_play, au_play, Fplay_sound_internal):
7926 Fix pointer signedness.
d01f234b 7927 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7928 (wav_play): Initialize a variable to 0, to prevent undefined
7929 behavior (Bug#8278).
50060332 7930
c4fc4e30
PE
7931 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7932
918436ed
PE
7933 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7934
c939f91b
PE
7935 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7936 clobbering (Bug#8298).
b9c7f648
PE
7937 * sysdep.c (sys_subshell): Likewise.
7938 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7939
6bd8c144
PE
7940 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7941 This should get cleaned up, so that child_setup has the
7942 same signature on all platforms.
7943
7710357c 7944 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7945 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7946
c59da222
CY
79472011-03-22 Chong Yidong <cyd@stupidchicken.com>
7948
7949 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7950 not to be necessary, and produces flickering.
7951
66b87493
GM
79522011-03-20 Glenn Morris <rgm@gnu.org>
7953
7954 * config.in: Remove file.
7955
45b6f6d5
JB
79562011-03-20 Juanma Barranquero <lekktu@gmail.com>
7957
7958 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7959 are now in src/globals.h.
7960 (syms_of_minibuf): Remove spurious & from previous change.
7961
3ec03f7e
LL
79622011-03-20 Leo <sdl.web@gmail.com>
7963
7964 * minibuf.c (completing-read-function): New variable.
7965 (completing-read-default): Rename from completing-read.
7966 (completing-read): Call completing-read-function.
7967
b14e3e21
CY
79682011-03-19 Juanma Barranquero <lekktu@gmail.com>
7969
7970 * xfaces.c (Fx_load_color_file):
7971 Read color file from absolute filename (bug#8250).
7972
f2b726e6
JB
79732011-03-19 Juanma Barranquero <lekktu@gmail.com>
7974
7975 * makefile.w32-in: Update dependencies.
7976
09f6ff02
EZ
79772011-03-17 Eli Zaretskii <eliz@gnu.org>
7978
7979 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7980
29a6015a
PE
79812011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7982
a3a6c54e
PE
7983 Fix more problems found by GCC 4.5.2's static checks.
7984
b766f867
PE
7985 * process.c (make_serial_process_unwind, send_process_trap):
7986 (sigchld_handler): Now static.
7987
be02381c
PE
7988 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7989 That way, the code declares only the vars that it needs.
7990 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7991 * s/cygwin.h (PTY_ITERATION): Likewise.
7992 * s/darwin.h (PTY_ITERATION): Likewise.
7993 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7994
57048744
PE
7995 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7996 * process.c (allocate_pty): Don't declare stb unless it's needed.
7997
7914961c 7998 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7999 (CONSTANTLIM): Remove; unused.
8000 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8001 Define only if needed.
7914961c 8002
b3967b18
PE
8003 * unexelf.c (unexec): Name an expression,
8004 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8005 Use a different way to cause a compilation error if anyone uses
8006 n rather than nn, a way that does not involve shadowing.
73366a00 8007 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8008
29a6015a
PE
8009 * deps.mk (unexalpha.o): Remove; unused.
8010
43cfc33e 8011 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8012 * unexec.h: New file.
ce701a33
PE
8013 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8014 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8015 Depend on unexec.h.
8016 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8017 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8018 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8019 Change as necessary to match prototype in unexec.h.
ce701a33 8020
01f44d5a
PE
8021 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8022 shadowing.
4f63c6bb 8023 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8024
a6670b0b
PE
8025 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8026 Rename locals to avoid shadowing.
8027
cef2010d 8028 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8029 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8030
d4d7173a
PE
8031 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8032
f08b802a
PE
8033 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8034 warning when compiling print.c.
8035
3ddb0639
PE
8036 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8037 instead of using an uninitialized var.
5ad03b97 8038 (font_sort_entities): Mark var as initialized.
3ddb0639 8039
170a2692
PE
8040 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8041
e663c700
PE
8042 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8043 pointers to constants.
89bc529a 8044 (font_parse_fcname): Remove unused vars.
7b81e2d0 8045 (font_delete_unmatched): Now static.
ea838e10 8046 (font_get_spec): Remove; unused.
13a547c6
PE
8047 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8048 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8049 Rename or move locals to avoid shadowing.
e663c700 8050
2a80c887 8051 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8052 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8053
1384fa33 8054 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8055 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8056
8b2c52e9
PE
8057 * alloc.c (mark_backtrace): Move decl from here ...
8058 * lisp.h: ... to here, so that it can be checked.
8059
475545b5 8060 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8061 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8062 (lisp_indirect_variable): Name an expression,
8063 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8064 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8065
b1349114 8066 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8067 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8068 Use const pointer when appropriate.
b1349114 8069
a2928364
PE
8070 * lisp.h (get_system_name, get_operating_system_release):
8071 Move decls here, to check interfaces.
8072 * process.c (get_operating_system_release): Move decl to lisp.h.
8073 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8074 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8075 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8076 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8077 (Fformat_time_string, Fencode_time, Finsert_char):
8078 (Ftranslate_region_internal, Fformat):
8079 Rename or remove local vars to avoid shadowing.
9710023e 8080 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8081
a415e694
PE
8082 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8083 avoid shadowing.
8084
8ef4622d
PE
8085 * lisp.h (eassert): Check that the argument compiles, even if
8086 ENABLE_CHECKING is not defined.
8087
946f9a5b
PE
8088 * data.c (Findirect_variable): Name an expression, to avoid
8089 gcc -Wbad-function-cast warning.
112396d6 8090 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8091 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8092 (Fmake_variable_buffer_local, Fmake_local_variable):
8093 Mark variables as initialized.
52746918 8094 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8095
e5aab7e7 8096 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8097 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8098 Rename locals to avoid shadowing.
dff45157
PE
8099 (mark_stack): Move local variables into the #ifdef region where
8100 they're used.
7bc26fdb
PE
8101 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8102 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8103 needed otherwise.
8104 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8105 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8106 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8107
e5aab7e7
PE
8108 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8109 avoids undefined behavior in theory.
8110
4da60324
PE
8111 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8112
88043301
PE
8113 Use functions, not macros, for up- and down-casing (Bug#8254).
8114 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8115 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8116 to use the following functions instead of these macros.
8117 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8118 EMACS_INT, since callers assume the returned value fits in int.
8119 (upcase1): Likewise, for UPCASE_TABLE.
8120 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8121 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8122 the race-condition problem in the old DOWNCASE.
88043301 8123
19ed5445
PE
8124 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8125 Rename locals to avoid shadowing.
8126 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8127 (regex_compile, re_search_2, re_match_2_internal):
8128 Remove unused local vars.
952db0d7
PE
8129 (FREE_VAR): Rewrite so as not to use empty "else",
8130 which gcc can warn about.
da053e48 8131 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8132 (RETALLOC_IF): Define only if needed.
8133 (WORDCHAR_P): Likewise. This one is never needed, but is used
8134 only in a comment talking about a compiler bug, so put inside
8135 the #if 0 of that comment.
8136 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8137 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8138 Remove; unused.
19ed5445 8139
1f3561e4 8140 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8141 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8142 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8143
ded6f8f7
PE
8144 * search.c (simple_search): Remove unused var.
8145
dbd37a95
PE
8146 * dired.c (compile_pattern): Move decl from here ...
8147 * lisp.h: ... to here, so that it can be checked.
8148 (struct re_registers): New forward decl.
8149
7e47afad
PE
8150 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8151
85f24f61
PE
8152 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8153 All uses changed.
8154 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8155 Rename locals to avoid shadowing.
5671df8f 8156 (Fvertical_motion): Mark locals as initialized.
85f24f61 8157
181aa2be 8158 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8159 (casify_region): Mark local as initialized.
181aa2be 8160
930d429c
PE
8161 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8162
7082eac6
PE
8163 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8164 New macros, so that the caller can use some names other than
8165 gcpro1, gcpro2, etc.
8166 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8167 of the new macros.
8168 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8169 argument, for consistency with GCPRO2_VAR, etc: it is now the
8170 prefix of the variable, not the variable itself. All uses
8171 changed.
38b2c076
PE
8172 * dired.c (directory_files_internal, file_name_completion):
8173 Rename locals to avoid shadowing.
8174
15206ed9
PE
8175 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8176 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8177 dired.c's scmp function, had undefined behavior.
8178 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8179 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8180 * buffer.h: ... to here, because these macros use current_buffer,
8181 and the new implementation with inline functions needs to have
8182 current_buffer in scope now, rather than later when the macros
8183 are used.
8184 (downcase, upcase1): New static inline functions.
8185 (DOWNCASE, UPCASE1): Reimplement using these functions.
8186 This avoids undefined behavior in expressions like
8187 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8188 from race conditions in accessing the global variables
8189 case_temp1 and case_temp2.
8190 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8191 * lisp.h (case_temp1, case_temp2): Remove their decls.
8192 * character.h (ASCII_CHAR_P): Move from here ...
8193 * lisp.h: ... to here, so that the inline functions mentioned
8194 above can use them.
8195
4a6bea26
PE
8196 * dired.c (directory_files_internal_unwind): Now static.
8197
f14b7e14
PE
8198 * fileio.c (file_name_as_directory, directory_file_name):
8199 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8200 Now static.
2893f146
PE
8201 (file_name_as_directory): Use const pointers when appropriate.
8202 (Fexpand_file_name): Likewise. In particular, newdir might
8203 point at constant storage, so make it a const pointer.
fd4ead52 8204 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8205 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8206 signedness issues.
f839df0c
PE
8207 (Fset_file_times, Finsert_file_contents, auto_save_error):
8208 Rename locals to avoid shadowing.
f14b7e14 8209
5716756e 8210 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8211 (Ftry_completion, Fall_completions): Rename or remove locals
8212 to avoid shadowing.
5716756e 8213
b4c3046a
PE
8214 * marker.c (bytepos_to_charpos): Remove; unused.
8215
b45db522
PE
8216 * lisp.h (verify_bytepos, count_markers): New decls,
8217 so that gcc does not warn that these functions aren't declared.
8218
85876d07
PE
8219 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8220 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8221 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8222 (copy_text): Remove unused local var.
85876d07 8223
03d78a21 8224 * filelock.c (within_one_second): Now static.
b3dd38ab 8225 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8226
5df8f01b
PE
8227 * buffer.c (fix_overlays_before): Mark locals as initialized.
8228 (fix_start_end_in_overlays): Likewise. This function should be
8229 simplified by using pointers-to-pointers, but that's a different
8230 matter.
b1d876f1 8231 (switch_to_buffer_1): Now static.
8f54f30a
PE
8232 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8233 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8234
a70072c9 8235 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8236 Fix pointer signedness issue.
edced198
PE
8237 (sys_subshell): Mark local as volatile if checking for lint,
8238 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8239 (MAXPATHLEN): Define only if needed.
a70072c9 8240
a0977c44
PE
8241 * process.c (serial_open, serial_configure): Move decls from here ...
8242 * systty.h: ... to here, so that they can be checked.
8243
a884fdcc
PE
8244 * fns.c (get_random, seed_random): Move extern decls from here ...
8245 * lisp.h: ... to here, so that they can be checked.
8246
604efe86 8247 * sysdep.c (reset_io): Now static.
b8950c94 8248 (wait_for_termination_signal): Remove; unused.
604efe86 8249
38fc62d9
PE
8250 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8251 (copy_keymap_item, append_key, push_text_char_description):
8252 Now static.
1004a21a 8253 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8254 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8255 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8256 (describe_map_tree):
8257 Rename locals to avoid shadowing.
38fc62d9 8258
2f2650da
PE
8259 * keyboard.c: Declare functions static if they are not used elsewhere.
8260 (echo_char, echo_dash, cmd_error, top_level_2):
8261 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8262 (read_char, kbd_buffer_get_event, make_lispy_position):
8263 (make_lispy_event, make_lispy_movement, apply_modifiers):
8264 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8265 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8266 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8267 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8268 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8269
a053e86c 8270 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8271 (mark_kboards): Move decl here ...
8272 * alloc.c (mark_kboards): ... from here.
a053e86c 8273
4752793e
PE
8274 * lisp.h (force_auto_save_soon): New decl.
8275
74f10ca7 8276 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8277 (DEFINE_DUMMY_FUNCTION): New macro.
8278 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8279 Use it.
c03cd23f
PE
8280 (main): Add casts to avoid warnings
8281 if GCC considers string literals to be constants.
74f10ca7 8282
022e70d4
PE
8283 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8284
59d6fe83
PE
8285 * dbusbind.c: Pointer signedness fixes.
8286 (xd_signature, xd_append_arg, xd_initialize):
8287 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8288 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8289 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8290 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8291
78320123
PE
8292 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8293 if GCC considers string literals to be constants.
49cebcca 8294 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8295
35ac2a97
SM
82962011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8297
fb103ca9
SM
8298 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8299 (print_preprocess, print_object): New macro to fix last change.
8300
35ac2a97
SM
8301 * print.c (print_preprocess): Don't forget font objects.
8302
62973b41
JB
83032011-03-16 Juanma Barranquero <lekktu@gmail.com>
8304
8305 * emacs.c (USAGE3): Doc fixes.
8306
0e48bb22
AS
83072011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8308
8309 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8310 structure.
8311
7684e57b
JB
83122011-03-14 Juanma Barranquero <lekktu@gmail.com>
8313
8314 * lisp.h (VWindow_system, Qfile_name_history):
8315 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8316 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8317 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8318
8319 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8320 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8321
8322 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8323 * w32console.c (detect_input_pending, read_input_pending)
8324 (encode_terminal_code):
8325 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8326 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8327 (w32_system_caret_y, Qfile_name_history):
8328 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8329 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8330 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8331 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8332 * w32proc.c (Qlocal, report_file_error):
8333 * w32term.c (Vwindow_system, updating_frame):
8334 * w32uniscribe.c (initialized, uniscribe_font_driver):
8335 Remove unneeded extern declarations.
8336
2aa46d6c
CY
83372011-03-14 Chong Yidong <cyd@stupidchicken.com>
8338
c96bbc66 8339 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8340
cffc6f3b
CY
83412011-03-13 Chong Yidong <cyd@stupidchicken.com>
8342
8343 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8344 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8345 These macros can no longer be used for assignment.
8346
44f230aa
SM
8347 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8348 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8349 (record_buffer_markers, fetch_buffer_markers): New functions for
8350 recording and fetching special buffer markers.
8351 (set_buffer_internal_1, set_buffer_temp): Use them.
8352
8353 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8354
8355 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8356
8357 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8358 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8359
8360 * xdisp.c (hscroll_window_tree):
8361 (reconsider_clip_changes): Use PT instead of BUF_PT.
8362
d251f04b
EZ
83632011-03-13 Eli Zaretskii <eliz@gnu.org>
8364
8365 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8366 $(EMACS_ROOT)/lib/intprops.h.
8367
f0c77cd1
PE
83682011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8369
3eca4629
PE
8370 Fix more problems found by GCC 4.5.2's static checks.
8371
7c86ee98
PE
8372 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8373 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8374 (xg_free_frame_widgets): Make it clear that a local variable is
8375 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8376 (gdk_window_get_screen): Make it clear that this macro is needed
8377 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8378 (int_gtk_range_get_value): New function, which avoids a diagnostic
8379 from gcc -Wbad-function-cast.
8380 (xg_set_toolkit_scroll_bar_thumb): Use it.
8381 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8382 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8383 (get_utf8_string, xg_get_file_with_chooser):
8384 Rename locals to avoid shadowing.
8385 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8386
41729b81
PE
8387 * xgselect.c (xg_select): Remove unused var.
8388
f0c77cd1
PE
8389 * image.c (four_corners_best): Mark locals as initialized.
8390 (gif_load): Initialize transparent_p to zero (Bug#8238).
8391 Mark another local as initialized.
ec6cf4c6 8392 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8393
ce0ad53d 8394 * image.c (clear_image_cache): Now static.
d5d5a617 8395 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8396 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8397 (x_edge_detection): Remove unnecessary cast that
8398 gcc -Wbad-function-cast diagnoses.
2037898d 8399 (gif_load): Fix pointer signedness.
6ae141d6
PE
8400 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8401 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8402
33383987 84032011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8404
d32df629
PE
8405 Improve quality of tests for time stamp overflow.
8406 For example, without this patch (encode-time 0 0 0 1 1
8407 1152921504606846976) returns the obviously-bogus value (-948597
8408 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8409 reports time overflow. See
8410 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8411 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8412 * editfns.c: Include limits.h and intprops.h.
8413 (TIME_T_MIN, TIME_T_MAX): New macros.
8414 (time_overflow): Move earlier, to before first use.
8415 (hi_time, lo_time): New functions, for an accurate test for
8416 out-of-range times.
8417 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8418 (Fget_internal_run_time): Don't assume time_t fits in int.
8419 (make_time): Use list2 instead of Fcons twice.
8420 (Fdecode_time): More accurate test for out-of-range times.
8421 (check_tm_member): New function.
8422 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8423 (lisp_time_argument): Don't rely on undefined left-shift and
8424 right-shift behavior when checking for time stamp overflow.
8be6f318 8425
fe31d94c
PE
8426 * editfns.c (time_overflow): New function, refactoring common code.
8427 (Fformat_time_string, Fdecode_time, Fencode_time):
8428 (Fcurrent_time_string): Use it.
8429
8be6f318
PE
8430 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8431 * dired.c (make_time): Move to ...
8432 * editfns.c (make_time): ... here.
8433 * systime.h: Note the move.
8434
09d9db2c 84352011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8436
126bc0dc
YM
8437 * fringe.c (update_window_fringes): Remove unused variables.
8438
c47cbdfd
YM
8439 * unexmacosx.c (copy_data_segment): Also copy __got section.
8440 (Bug#8223)
8441
7ac80be9
EZ
84422011-03-12 Eli Zaretskii <eliz@gnu.org>
8443
c96bbc66 8444 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8445 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8446 Constify `char *' arguments and their references according to
8447 prototypes in tparam.h.
8448
ecb0f94d 8449 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8450
7ac80be9
EZ
8451 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8452 Adapt all references accordingly.
8453
8454 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8455
ef1fd07e
TT
84562011-03-11 Tom Tromey <tromey@redhat.com>
8457
8458 * buffer.c (syms_of_buffer): Remove obsolete comment.
8459
7ef4b50c
EZ
84602011-03-11 Eli Zaretskii <eliz@gnu.org>
8461
8462 * termhooks.h (encode_terminal_code): Declare prototype.
8463
8464 * msdos.c (encode_terminal_code): Don't declare prototype.
8465
8466 * term.c (encode_terminal_code): Now external again, used by
8467 w32console.c and msdos.c.
8468
44f230aa
SM
8469 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8470 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8471
4b1ec863 84722011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8473
1714f52b 8474 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8475
4b1ec863
PE
8476 * fringe.c (update_window_fringes): Mark locals as initialized
8477 (Bug#8227).
8478 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8479
524c7aa6
PE
8480 * alloc.c (mark_fringe_data): Move decl from here ...
8481 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8482 to check its interface.
8483 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8484
a5c0af81 8485 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8486 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8487 (fontset_font): Mark local as initialized.
a9a06e0b 8488 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8489
b4716021
PE
8490 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8491
811e9bac 8492 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8493 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8494 (x_own_selection, Fx_disown_selection_internal): Rename locals
8495 to avoid shadowing.
8496 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8497
7e3ab302
PE
8498 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8499 so that the caller can use some name other than gcpro1.
8500 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8501 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8502 (Fx_backspace_delete_keys_p):
8503 Use them to avoid shadowing, and rename vars to avoid shadowing.
8504 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8505 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8506 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8507 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8508 Remove unused locals.
7e3ab302
PE
8509 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8510 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8511 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8512 macros.
f78faa98 8513
e2b13473
PE
8514 * xterm.h (x_mouse_leave): New decl.
8515
77f23912
PE
8516 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8517 Remove unused functions.
cdf4ba58
PE
8518 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8519 (x_calc_absolute_position): Now static.
7411c686 8520 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8521 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8522 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8523 unless they are used.
38d0b34a
PE
8524 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8525 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8526 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8527 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8528 (x_error_catcher, x_connection_closed, x_error_handler):
8529 (x_error_quitter, xembed_send_message, x_iconify_frame):
8530 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8531 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8532 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8533
44f230aa
SM
8534 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8535 Rename or move locals to avoid shadowing.
6b463e58 8536 (tty_defined_color, merge_face_heights): Now static.
5967d051 8537 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8538 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8539 does not deduce is never used uninitialized.
73719eba
PE
8540 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8541 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8542
426994c3 8543 * terminal.c (store_terminal_param): Now static.
5489860b 8544
032f1620 8545 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8546 (set_frame_menubar): Remove unused local.
d4323972 8547 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8548 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8549 since they might point to immutable storage.
281585b0
PE
8550 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8551 since it's unused otherwise.
032f1620 8552
367c19e5 8553 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8554 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8555 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8556 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8557 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8558 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8559 does not deduce are never used uninitialized.
70739cbe 8560
07b48fa9
PE
8561 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8562
8868a238 8563 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8564 * window.c (window_loop, size_window):
8565 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8566
7e5cf297 8567 * window.c (display_buffer): Now static.
d6550a9f
PE
8568 (size_window): Mark variables that gcc -Wuninitialized
8569 does not deduce are never used uninitialized.
a586633d
PE
8570 * window.h (check_all_windows): New decl, to forestall
8571 gcc -Wmissing-prototypes diagnostic.
5b555da1 8572 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8573
f6095868
PE
8574 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8575 shadowing.
8576 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8577 Include <limits.h>.
8578 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8579 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8580 (load_charset_map): Mark variables that gcc -Wuninitialized
8581 does not deduce are never used uninitialized.
53df7c11 8582 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8583
f38b440c
PE
8584 * coding.c (coding_set_source, coding_set_destination):
8585 Use "else { /* comment */ }" rather than "else /* comment */;"
8586 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8587 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8588 a block, when the outer 'i' will do.
8589 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8590 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8591 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8592 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8593 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8594 Rename locals to avoid shadowing.
8595 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8596 * coding.c (emacs_mule_char, encode_invocation_designation):
8597 Now static, since they're not used elsewhere.
413bb2db 8598 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8599 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8600 (decode_coding_emacs_mule): Mark variables that gcc
8601 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8602 (detect_coding_iso_2022): Initialize a local variable that might
8603 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8604 this initialization is needed. (Bug#8211)
5f58e762
PE
8605 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8606 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8607 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8608 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8609 Remove unused macros.
f38b440c 8610
232b38b9 8611 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8612 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8613 * character.c (string_count_byte8): Likewise.
232b38b9 8614
fb90da1b
PE
8615 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8616 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8617
fb93dbc2
PE
8618 * chartab.c (copy_sub_char_table): Now static, since it's not used
8619 elsewhere.
5c156ace
PE
8620 (sub_char_table_ref_and_range, char_table_ref_and_range):
8621 Rename locals to avoid shadowing.
bbcd0949 8622 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8623
7d3b3862 8624 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8625 (BIDI_BOB): Remove unused macro.
7d3b3862 8626
6be7d3da
PE
8627 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8628 deduce are never used uninitialized.
c2ed9c8b 8629 * term.c (encode_terminal_code): Likewise.
6be7d3da 8630
75f8807f 8631 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8632
50938595
PE
8633 * tparam.h: New file.
8634 * term.c, tparam.h: Include it.
8635 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8636 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8637 Move these decls to tparam.h, and make them agree with what
8638 is actually in tparam.c. The previous trick of using incompatible
8639 decls in different modules does not conform to the C standard.
8640 All callers of tparam changed to use tparam's actual API.
8641 * tparam.c (tparam1, tparam, tgoto):
8642 Use const pointers where appropriate.
8643
fbceeba2
PE
8644 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8645 * cm.h (struct cm): Likewise.
8646 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8647 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8648 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8649 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8650 (turn_on_face, init_tty): Likewise.
8651 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8652
7f3f1250
PE
8653 * term.c (term_mouse_position): Rename local to avoid shadowing.
8654
e6ca6543
PE
8655 * alloc.c (mark_ttys): Move decl from here ...
8656 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8657
c40f8d15
AS
86582011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8659
8660 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8661
cfe0661d
JB
86622011-03-09 Juanma Barranquero <lekktu@gmail.com>
8663
8664 * search.c (compile_pattern_1): Remove argument regp, unused since
8665 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8666 (compile_pattern): Don't pass it.
8667
0afb4571
J
86682011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8669
8670 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8671 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8672 for ! HAVE_GTK3.
8673 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8674
8675 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8676
8677 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8678 gdk_window_get_screen, gdk_window_get_geometry,
8679 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8680 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8681 (xg_get_pixbuf_from_pixmap): New function.
8682 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8683 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8684 Call xg_get_pixbuf_from_pixmap instead of
8685 gdk_pixbuf_get_from_drawable.
8686 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8687 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8688 (xg_check_special_colors): Use GtkStyleContext and its functions
8689 for HAVE_GTK3.
8690 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8691 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8692 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8693 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8694 Call gtk_widget_get_preferred_size.
0afb4571
J
8695 (xg_frame_resized): gdk_window_get_geometry only takes 5
8696 parameters.
44f230aa
SM
8697 (xg_win_to_widget, xg_event_is_for_menubar):
8698 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8699 (xg_set_widget_bg): New function.
8700 (delete_cb): New function.
895009e1 8701 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8702 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8703 (xg_set_background_color): Call xg_set_widget_bg.
8704 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8705 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8706 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8707 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8708 if ! HAVE_GTK3.
8709 (update_frame_tool_bar): Call gtk_widget_hide.
8710 (xg_initialize): Use GDK_KEY_g.
8711
8712 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8713 if ! HAVE_GTK3
8714 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8715
8716 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8717 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8718 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8719
1c2cc4ef
JB
87202011-03-08 Juanma Barranquero <lekktu@gmail.com>
8721
8722 * w32xfns.c (select_palette): Check success of RealizePalette against
8723 GDI_ERROR, not zero.
8724
33383987 8725See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8726
8727;; Local Variables:
8728;; coding: utf-8
aac0c6e3
MR
8729;; End:
8730
33383987 8731 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8732
8733 This file is part of GNU Emacs.
8734
8735 GNU Emacs is free software: you can redistribute it and/or modify
8736 it under the terms of the GNU General Public License as published by
8737 the Free Software Foundation, either version 3 of the License, or
8738 (at your option) any later version.
8739
8740 GNU Emacs is distributed in the hope that it will be useful,
8741 but WITHOUT ANY WARRANTY; without even the implied warranty of
8742 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8743 GNU General Public License for more details.
8744
8745 You should have received a copy of the GNU General Public License
8746 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.