merge count_size_as_multibyte, parse_str_to_multibyte
[bpt/emacs.git] / src / ChangeLog
CommitLineData
de883a70
PE
12011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2
3 merge count_size_as_multibyte, parse_str_to_multibyte
4 * character.c, character.h (count_size_as_multibyte):
5 Renamed from parse_str_to_multibyte; all uses changed.
6 Check for integer overflow.
7 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8 since it's now a duplicate of the other. This is more of
9 a character than a buffer op, so better that it's in character.c.
10 * fns.c, print.c: Adjust to above changes.
11
7285dc67
EZ
122011-05-20 Eli Zaretskii <eliz@gnu.org>
13
14 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
15 report_file_error introduced by the change from 2011-05-07.
16
89d1bd22
PE
172011-05-20 Paul Eggert <eggert@cs.ucla.edu>
18
19 * systime.h (Time): Define only if emacs is defined.
20 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
21 where the include path doesn't have X11/X.h by default. See
22 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
23
e23640bb 242011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
25
26 * composite.c (find_automatic_composition): Fix previous change.
27
b9704ad9
GM
282011-05-20 Glenn Morris <rgm@gnu.org>
29
30 * lisp.mk: New file, split from Makefile.in.
31 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
32 (shortlisp): Remove.
33 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
34
4a720484
GM
352011-05-19 Glenn Morris <rgm@gnu.org>
36
37 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
38 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
39 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
40 (lisp): Set the order to that of loadup.el.
41 (shortlisp): Make it a copy of $lisp.
42 (SOME_MACHINE_LISP): Remove.
43 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
44 Use just $shortlisp, not $SOME_MACHINE_LISP too.
45
a28d4396
KH
462011-05-18 Kenichi Handa <handa@m17n.org>
47
48 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
49 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
50 (find_automatic_composition): Mostly rewrite for efficiency.
51
a2b1fa8e
JB
522011-05-18 Juanma Barranquero <lekktu@gmail.com>
53
54 * makefile.w32-in: Update dependencies.
55
8e1f5610
CS
562011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
57
58 * menu.c: Include limits.h (fixes the MS-Windows build broken by
59 revision 104625).
60
7025ee00 612011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 62
cdfa6eab
PE
63 Fix some integer overflow issues, such as string length overflow.
64
06d6db33
PE
65 * insdel.c (count_size_as_multibyte): Check for string overflow.
66
2b4560a8
PE
67 * character.c (lisp_string_width): Check for string overflow.
68 Use EMACS_INT, not int, for string indexes and lengths; in
69 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
70 the resulting string length overflows an EMACS_INT; instead,
71 report a string overflow if no precision given. When checking for
72 precision exhaustion, use a check that cannot possibly have
73 integer overflow. (Bug#8675)
74 * character.h (lisp_string_width): Adjust to new signature.
75
cb93f9be
PE
76 * alloc.c (string_overflow): New function.
77 (Fmake_string): Use it. This doesn't change behavior, but saves
78 a few bytes and will simplify future changes.
79 * character.c (string_escape_byte8): Likewise.
80 * lisp.h (string_overflow): New decl.
81
1a1f3366
PE
82 Fixups, following up to the user-interface timestamp change.
83 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
84 for UI timestamps, instead of unsigned long.
9fbd6841
PE
85 * msdos.c (mouse_get_pos): Likewise.
86 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
87 * w32gui.h (Time): Define by including "systime.h" rather than by
88 declaring it ourselves. (Bug#8664)
89
d4e3e4d3
PE
90 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
91 * image.c (clear_image_cache): Likewise.
92
f6a24d19
PE
93 * term.c (term_mouse_position): Don't assume time_t wraparound.
94
08dc5ae6
PE
95 Be more systematic about user-interface timestamps.
96 Before, the code sometimes used 'Time', sometimes 'unsigned long',
97 and sometimes 'EMACS_UINT', to represent these timestamps. This
98 change causes it to use 'Time' uniformly, as that's what X uses.
99 This makes the code easier to follow, and makes it easier to catch
100 integer overflow bugs such as Bug#8664.
101 * frame.c (Fmouse_position, Fmouse_pixel_position):
102 Use Time, not unsigned long, for user-interface timestamps.
103 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
104 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
105 * keyboard.h (last_event_timestamp): Likewise.
106 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
107 * menu.h (xmenu_show): Likewise.
108 * term.c (term_mouse_position): Likewise.
109 * termhooks.h (struct input_event.timestamp): Likewise.
110 (struct terminal.mouse_position_hook): Likewise.
111 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
112 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
113 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
114 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
115 what it was before.
116 * menu.h, termhooks.h: Include "systime.h", for Time.
117
8e55734a
PE
118 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
119 Don't assume that the difference between two unsigned long values
120 can fit into an integer. At this point, we know button_down_time
121 <= event->timestamp, so the difference must be nonnegative, so
122 there's no need to cast the result if double-click-time is
123 nonnegative, as it should be; check that it's nonnegative, just in
124 case. This bug is triggered when events are more than 2**31 ms
86db42d2 125 apart (about 25 days). (Bug#8664)
8e55734a 126
841f1b75 127 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 128 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 129
3e26f69c
PE
130 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
131 that always fit in int. Use a sentinel instead of a counter, to
132 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
133 * frame.h (struct frame): Use int for menu_bar_items_used
134 instead of EMACS_INT, since it always fits in int.
3e26f69c 135
5cc152c0
PE
136 * menu.c (grow_menu_items): Check for int overflow.
137
d89eb65e
PE
138 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
139
5235bd3e
PE
140 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
141 Before, the code was not consistent. These values cannot exceed
142 2**31 - 1 so there's no need to make them unsigned.
143 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
144 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
145 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
146 as modifiers.
147 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
148
bc827e23
PE
149 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
150 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
151 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
152 presumably because the widths might not match.
153
78eb494e
PE
154 * window.c (size_window): Avoid needless test at loop start.
155
04f2d78b
CB
1562011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
157
158 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
159
d2fc7e3d 1602011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
161
162 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
163
d2fc7e3d 1642011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
165
166 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
167 `width' to `bar_area_x' and `bar_area_width', respectively.
168 (x_scroll_run): Take account of fringe background extension.
169
04f2d78b
CB
170 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
171 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
172 `bar_area_width', respectively.
173 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
174 background extension.
175
79b70037
GM
1762011-05-10 Jim Meyering <meyering@redhat.com>
177
178 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
179
2f142cc5
JB
1802011-05-10 Juanma Barranquero <lekktu@gmail.com>
181
182 * image.c (Finit_image_library): Return t for built-in image types,
183 like pbm and xbm. (Bug#8640)
184
57679c86
AS
1852011-05-09 Andreas Schwab <schwab@linux-m68k.org>
186
187 * w32menu.c (set_frame_menubar): Fix submenu allocation.
188
888c9e86
EZ
1892011-05-07 Eli Zaretskii <eliz@gnu.org>
190
b0512a1d
EZ
191 * w32console.c (Fset_screen_color): Doc fix.
192 (Fget_screen_color): New function.
193 (syms_of_ntterm): Defsubr it.
194
7285dc67
EZ
195 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
196 unlink the temporary file if Fcall_process didn't create it in the
197 first place.
198 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
199 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
200 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
201 cue to call_process_cleanup not to close that handle.
202
4d3fcc8e
BK
2032011-05-07 Ben Key <bkey76@gmail.com>
204
205 * makefile.w32-in: The bootstrap-temacs rule now makes use of
206 one of two shell specific rules, either bootstrap-temacs-CMD or
207 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
208 to the previous implementation of the bootstrap-temacs rule.
209 The bootstrap-temacs-CMD rule is similar to the previous
210 implementation of the bootstrap-temacs rule except that it
211 makes use of the ESC_CFLAGS variable instead of the CFLAGS
212 variable.
213
214 These changes, along with some changes to nt/configure.bat,
215 nt/gmake.defs, and nt/nmake.defs, are required to extend my
216 earlier fix to add support for --cflags and --ldflags options
217 that include quotes so that it works whether make uses cmd or
218 sh as the shell.
219
b4289b64
MA
2202011-05-06 Michael Albinus <michael.albinus@gmx.de>
221
222 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
223 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
224 is a constant.
225 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
226 a string. Handle both cases.
227 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
228 (Fdbus_register_method): Use Qinvalid_function.
229
af4c0e28
JB
2302011-05-06 Juanma Barranquero <lekktu@gmail.com>
231
232 * makefile.w32-in: Update dependencies.
233 (LISP_H): Add inttypes.h and stdin.h.
234 (PROCESS_H): Add unistd.h.
235
c51453d9
EZ
2362011-05-06 Eli Zaretskii <eliz@gnu.org>
237
238 * lread.c: Include limits.h (fixes the MS-Windows build broken by
239 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
240
8ff0ac3c 2412011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 242
4c4b566b
PE
243 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
244
aab2b9b5
PE
245 * term.c (vfatal): Remove stray call to va_end.
246 It's not needed and the C Standard doesn't allow it here anyway.
247
c378da0b
PE
248 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
249 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
250
288b08c7
PE
251 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
252 bytes.
253
e3601888
PE
254 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
255
db6c0e74
PE
256 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
257
dd5963ea
PE
258 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
259
88c9450f
PE
260 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
261
2f9442b8
PE
262 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
263
c032b5f8
PE
264 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
265 * charset.c (Fdefine_charset_internal): Don't initialize
266 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 267 32-bit int (Bug#8600).
a108c10b
PE
268
269 * lread.c (read_integer): Be more consistent with string-to-number.
270 Use string_to_number to do the actual conversion; this avoids
271 rounding errors and fixes some other screwups. Without this fix,
272 for example, #x1fffffffffffffff was misread as -2305843009213693952.
273 (digit_to_number): Move earlier, for benefit of read_integer.
274 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 275 not a digit in any supported base. (Bug#8602)
a108c10b 276
ad5f9eea
PE
277 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
278
aec1708a
PE
279 * dispnew.c (scrolling_window): Return 1 if we scrolled,
280 to match comment at start of function. This also removes a
281 GCC warning about overflow in a 32+64-bit port.
282
47be4ab5
PE
283 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
284
371cac43
PE
285 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
286 Reported by Stefan Monnier in
287 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
288 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
289 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 290
d01a7826
PE
291 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
292 (EMACS_UINTPTR): Likewise, with uintptr_t.
293
7fd47d5c
PE
294 * lisp.h: Prefer 64-bit EMACS_INT if available.
295 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
296 on 32-bit hosts that have 64-bit int, so that they can access
297 large files.
122b0c86
PE
298 However, temporarily disable this change unless the temporary
299 symbol WIDE_EMACS_INT is defined.
7fd47d5c 300
8727937b
PE
301 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
302
8ac068ac
PE
303 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
304 This removes an assumption that EMACS_INT and long are the same
305 width as pointers. The assumption is true for Emacs porting targets
306 now, but we want to make other targets possible.
307 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
308 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
309 In the rest of the code, change types of integers that hold casted
310 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
311 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
312 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
313 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
314 No need to cast type when ORing.
315 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
316 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
317 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
318 assume EMACS_INT is the same width as char *.
319 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
320 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
321 Remove no-longer-needed casts.
322 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
323 (xg_tool_bar_help_callback, xg_make_tool_item):
324 Use EMACS_INTPTR to hold an integer
325 that will be cast to void *; this can avoid a GCC warning
326 if EMACS_INT is not the same width as void *.
327 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
328 * xdisp.c (display_echo_area_1, resize_mini_window_1):
329 (current_message_1, set_message_1):
330 Use a local to convert to proper width without a cast.
331 * xmenu.c (dialog_selection_callback): Likewise.
332
ede49d71
PE
333 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
334 Also, don't assume VALBITS / RAND_BITS is less than 5,
335 and don't rely on undefined behavior when shifting a 1 left into
336 the sign bit.
337 * lisp.h (get_random): Change signature to match.
338
2f30ecd0
PE
339 * lread.c (hash_string): Use size_t, not int, for hash computation.
340 Normally we prefer signed values; but hashing is special, because
341 it's better to use unsigned division on hash table sizes so that
342 the remainder is nonnegative. Also, size_t is the natural width
343 for hashing into memory. The previous code used 'int', which doesn't
344 retain enough info to hash well into very large tables.
345 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
346
2a866e7b
PE
347 * dbusbind.c: Don't possibly lose pointer info when converting.
348 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
349 Use XPNTR rather than XHASH, so that the high-order bits of
350 the pointer aren't lost when converting through void *.
351
51639eac
PE
352 * eval.c (Fautoload): Don't double-shift a pointer.
353
92394119
PE
354 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
355
dbdb9a7c
JB
3562011-05-06 Juanma Barranquero <lekktu@gmail.com>
357
358 * gnutls.c (DEF_GNUTLS_FN):
359 * image.c (DEF_IMGLIB_FN): Make function pointers static.
360
db7a0b4f
AS
3612011-05-05 Andreas Schwab <schwab@linux-m68k.org>
362
363 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
364 marker. (Bug#8610)
365
f7ff1b0f 3662011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
367
368 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
369 New version that can reserve upto 2GB of heap space.
370
f7ff1b0f 3712011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
372
373 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
374
639c109b
TZ
3752011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
376
377 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
378 `gnutls_certificate_set_x509_key_file'.
379
d2127135
JB
3802011-05-05 Juanma Barranquero <lekktu@gmail.com>
381
382 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
383 Update dependencies.
384
e968f4f3
JB
3852011-05-04 Juanma Barranquero <lekktu@gmail.com>
386
387 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
388 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
389 Remove unused parameter `fildes'.
390 * process.c (read_process_output, send_process): Don't pass it.
391
84d358f0
JB
3922011-05-04 Juanma Barranquero <lekktu@gmail.com>
393
394 Fix previous change: the library cache is defined in w32.c.
395 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
396 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
397
0898ca10
JB
3982011-05-04 Juanma Barranquero <lekktu@gmail.com>
399
400 Implement dynamic loading of GnuTLS on Windows.
401
402 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
403 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
404 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
405 Declare.
406
407 * gnutls.c (Qgnutls_dll): Define.
408 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
409 (gnutls_*): Declare function pointers.
410 (init_gnutls_functions): New function to initialize function pointers.
411 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
412 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
413 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
414 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
415 (emacs_gnutls_write, emacs_gnutls_read)
416 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
417 (Fgnutls_available_p): New function.
418 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
419 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
420 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
421
422 * image.c: Include w32.h.
423 (Vimage_type_cache): Delete.
424 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
425 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
426 (w32_delayed_load): Move to w32.c.
427
428 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
429
430 * w32.c (QCloaded_from, Vlibrary_cache): Define.
431 (w32_delayed_load): Move from image.c. When loading a library, record
432 its filename in the :loaded-from property of the library id.
433 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
434 Initialize and staticpro them.
435 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
436
437 * process.c: Include lisp.h before w32.h, not after.
438 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
439 instead of gnutls_record_check_pending.
440
441 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
442
ff4de4aa
TZ
4432011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
444
445 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
446 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
447 as passed in.
448
abe95abb
JD
4492011-05-03 Jan Djärv <jan.h.d@swipnet.se>
450
451 * xterm.c (x_set_frame_alpha): Do not set property on anything
452 else than FRAME_X_OUTER_WINDOW (Bug#8608).
453
e16e55d4
JB
4542011-05-02 Juanma Barranquero <lekktu@gmail.com>
455
456 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
457
bafcf6a5
JB
4582011-05-02 Juanma Barranquero <lekktu@gmail.com>
459
460 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
461 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
462 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
463 (gnutls_global_initialized, Qgnutls_bootprop_priority)
464 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
465 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
466 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
467 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
468 (Qgnutls_bootprop_callbacks_verify): Make static.
469
e7a6747f
AS
4702011-05-01 Andreas Schwab <schwab@linux-m68k.org>
471
19ed11ba
AS
472 * callproc.c: Indentation fixup.
473
e7a6747f 474 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
475 (wait_for_termination, interruptible_wait_for_termination):
476 Move after wait_for_termination_1.
e7a6747f 477
1ef14cb4
LMI
4782011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
479
480 * sysdep.c (interruptible_wait_for_termination): New function
481 which is like wait_for_termination, but allows keyboard
482 interruptions.
483
484 * callproc.c (Fcall_process): Add (:file "file") as an option for
485 the STDOUT buffer.
486 (Fcall_process_region): Ditto.
487
330d880c
EZ
4882011-04-30 Eli Zaretskii <eliz@gnu.org>
489
8db90b73
EZ
490 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
491 rather than `XVECTOR (FOO)->size'.
492
330d880c
EZ
493 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
494 inttypes.h, as a gnulib replacement is used if it not available in
495 system headers.
496
15cbd324
EZ
4972011-04-21 Eli Zaretskii <eliz@gnu.org>
498
499 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
500 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
501 of MOST_POSITIVE_FIXNUM. (Bug#8528)
502
503 * coding.c (coding_alloc_by_realloc): Error out if destination
504 will grow beyond MOST_POSITIVE_FIXNUM.
505 (decode_coding_emacs_mule): Abort if there isn't enough place in
506 charbuf for the composition carryover bytes. Reserve an extra
507 space for up to 2 characters produced in a loop.
508 (decode_coding_iso_2022): Abort if there isn't enough place in
509 charbuf for the composition carryover bytes.
510
5112011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 512
ae940cca
EZ
513 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
514 aborting when %lld or %lll format is passed.
515 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
516 %llo or %llx format is passed. (Bug#8545)
517
03ab8921
EZ
518 * window.c (window_scroll_line_based): Use a marker instead of
519 simple variables to record original value of point. (Bug#7952)
520
afda1437
EZ
521 * doprnt.c (doprnt): Fix the case where a multibyte sequence
522 produced by %s or %c overflows available buffer space. (Bug#8545)
523
f76dee0c
PE
5242011-04-28 Paul Eggert <eggert@cs.ucla.edu>
525
526 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 527 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 528
fdc5744d
JB
5292011-04-28 Juanma Barranquero <lekktu@gmail.com>
530
531 * w32.c (init_environment): Warn about defaulting HOME to C:\.
532
638f053a
JB
5332011-04-28 Juanma Barranquero <lekktu@gmail.com>
534
535 * keyboard.c (Qdelayed_warnings_hook): Define.
536 (command_loop_1): Run `delayed-warnings-hook'
537 if Vdelayed_warnings_list is non-nil.
538 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
539 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
540
d178f871
EZ
5412011-04-28 Eli Zaretskii <eliz@gnu.org>
542
543 * doprnt.c (doprnt): Don't return value smaller than the buffer
544 size if the message was truncated. (Bug#8545).
545
b124fd93
JB
5462011-04-28 Juanma Barranquero <lekktu@gmail.com>
547
548 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
549 (Fx_window_property): #if-0 the whole functions, not just the bodies.
550
e810457d
PE
5512011-04-27 Paul Eggert <eggert@cs.ucla.edu>
552
553 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
554
ea51cceb
JB
5552011-04-27 Juanma Barranquero <lekktu@gmail.com>
556
557 * makefile.w32-in: Update dependencies.
558
94dcfacf
EZ
5592011-04-27 Eli Zaretskii <eliz@gnu.org>
560
561 Improve `doprnt' and its usage. (Bug#8545)
562 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
563 `format_end'. Remove support for %l as a conversion specifier.
564 Don't use xrealloc. Improve diagnostics when the %l size modifier
565 is used. Update the commentary.
566
567 * eval.c (verror): Simplify calculation of size_t.
568
569 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
570 messages.
571
f61f41d7
PE
5722011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
573
574 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
575 change.
576
96fb4434
PE
5772011-04-27 Paul Eggert <eggert@cs.ucla.edu>
578
579 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
580 This makes this file independent of the recent pseudovector change.
581
671875da 5822011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 583
69e9b5a3
PE
584 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
585
b5f869a7 586 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 587 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 588 Remove unused local.
c8926152 589 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 590
841a1577 591 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
592 GCC 4.6.0 optimizes based on type-based alias analysis.
593 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
594 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
595 != &v->size, and therefore "v->size = 1; b->size = 2; return
596 v->size;" must therefore return 1. This assumption is incorrect
597 for Emacs, since it type-puns struct Lisp_Vector * with many other
598 types. To fix this problem, this patch adds a new type struct
f904488f 599 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
600 and pseudovectors, and helps optimizing compilers not get fooled
601 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
602 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
603 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
604 the size member.
eab3844f
PE
605 (XSETPVECTYPE): Rewrite in terms of new macro.
606 (XSETPVECTYPESIZE): New macro, specifying both type and size.
607 This is a bit clearer, and further avoids the possibility of
608 undesirable aliasing.
609 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 610 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
611 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
612 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
613 (ASIZE): Now uses header.size rather than size.
614 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
615 to avoid the hassle of writing XVECTOR (foo)->header.size.
616 (struct vectorlike_header): New type.
eab3844f
PE
617 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
618 object, to help avoid aliasing.
619 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
620 (SUBRP): Likewise, since Lisp_Subr is a special case.
621 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
622 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
623 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 624 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
625 changed to be "header.size" and "header.next".
626 * buffer.h (struct buffer): Likewise.
627 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
628 * frame.h (struct frame): Likewise.
629 * process.h (struct Lisp_Process): Likewise.
630 * termhooks.h (struct terminal): Likewise.
631 * window.c (struct save_window_data, struct saved_window): Likewise.
632 * window.h (struct window): Likewise.
633 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
634 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
635 * buffer.c (init_buffer_once): Likewise.
636 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
637 special case.
638 * process.c (Fformat_network_address): Use local var for size,
639 for brevity.
640
0df1eac5
PE
641 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
642
847ab9d1 643 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
644 * data.c (atof): Remove decl; no longer used or needed.
645 (digit_to_number): Move to lread.c.
646 (Fstring_to_number): Use new string_to_number function, to be
647 consistent with how the Lisp reader treats infinities and NaNs.
648 Do not assume that floating-point numbers represent EMACS_INT
649 without losing information; this is not true on most 64-bit hosts.
650 Avoid double-rounding errors, by insisting on integers when
651 parsing non-base-10 numbers, as the documentation specifies.
652 * lisp.h (string_to_number): New decl, replacing ...
653 (isfloat_string): Remove.
bc0a5c13 654 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 655 (read1): Do not accept +. and -. as integers; this
452f4150
PE
656 appears to have been a coding error. Similarly, do not accept
657 strings like +-1e0 as floating point numbers. Do not report
658 overflow for integer overflows unless the base is not 10 which
659 means we have no simple and reliable way to continue.
660 Break out the floating-point parsing into a new
661 function string_to_number, so that Fstring_to_number parses
662 floating point numbers consistently with the Lisp reader.
04f2d78b 663 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
664 (E_CHAR, EXP_INT): Remove, replacing with ...
665 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
666 (string_to_number): New function, replacing isfloat_string.
667 This function checks for valid syntax and produces the resulting
668 Lisp float number too. Rework it so that string-to-number
bc0a5c13 669 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
670 so that overflow for non-base-10 numbers is reported only when
671 there's no portable and simple way to convert to floating point.
452f4150 672
67769ffc
PE
673 * textprop.c (set_text_properties_1): Rewrite for clarity,
674 and to avoid GCC warning about integer overflow.
675
c20db43f
PE
676 * intervals.h (struct interval): Use EMACS_INT for members
677 where EMACS_UINT might cause problems. See
678 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
679 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
680 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
681 All uses changed.
37aa2f85
PE
682 (offset_intervals): Tell GCC not to worry about length overflow
683 when negating a negative length.
c20db43f 684
2538aa2f
PE
685 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
686 (overrun_check_free): Likewise.
687
f2d3008d
PE
688 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
689 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
690 word size.
691
ec8df744
PE
692 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
693 (gnutls_make_error): Rename local to avoid shadowing.
694 (gnutls_emacs_global_deinit): ifdef out; not used.
695 (Fgnutls_boot): Use const for pointer to readonly storage.
696 Comment out unused local. Fix pointer signedness problems.
697
640ee02d
PE
698 * lread.c (openp): Don't stuff size_t into an 'int'.
699 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
700 about possible signed overflow.
701
6048fb2a
PE
702 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
703 (GDK_KEY_g): Don't define if already defined.
704 (xg_prepare_tooltip): Avoid pointer signedness problem.
705 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
706
fa3c87e1
PE
707 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
708 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
709
2172544b
PE
710 * xfns.c (Fx_window_property): Simplify a bit,
711 to make a bit faster and to avoid GCC 4.6.0 warning.
712 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
713
9b821a21
PE
714 * fns.c (internal_equal): Don't assume size_t fits in int.
715
3c616cfa
PE
716 * alloc.c (compact_small_strings): Tighten assertion a little.
717
c2982e87
PE
718 Replace pEd with more-general pI, and fix some printf arg casts.
719 * lisp.h (pI): New macro, generalizing old pEd macro to other
720 conversion specifiers. For example, use "...%"pI"d..." rather
721 than "...%"pEd"...".
722 (pEd): Remove. All uses replaced with similar uses of pI.
723 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
724 * alloc.c (check_pure_size): Don't overflow by converting size to int.
725 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
726 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
727 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
728 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
729 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
730 64-bit hosts.
731 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
732 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
733 * print.c (safe_debug_print, print_object): Likewise.
734 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
735 to int.
6f04d126
PE
736 Use pI instead of if-then-else-abort. Use %p to avoid casts,
737 avoiding the 0 flag, which is not portable.
c2982e87
PE
738 * process.c (Fmake_network_process): Use pI to avoid cast.
739 * region-cache.c (pp_cache): Likewise.
740 * xdisp.c (decode_mode_spec): Likewise.
741 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
742 behavior on 64-bit hosts with printf arg.
6f04d126 743 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
744 (x_stop_queuing_selection_requests): Likewise.
745 (x_get_window_property): Don't truncate byte count to an 'int'
746 when tracing.
0b432f21 747
5e073ec7
PE
748 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
749 here, since it parses constructs like leading '-' and spaces,
750 which are not wanted; and it overflows with large numbers.
751 Instead, simply match F[0-9]+, which is what is wanted anyway.
752
36372bf9
PE
753 * alloc.c: Remove unportable assumptions about struct layout.
754 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
755 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
756 (allocate_vectorlike, make_pure_vector): Use the new macros,
757 plus offsetof, to remove unportable assumptions about struct layout.
758 These assumptions hold on all porting targets that I know of, but
759 they are not guaranteed, they're easy to remove, and removing them
760 makes further changes easier.
761
0b432f21
PE
762 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
763 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
764 (string_overrun_cookie): Now const. Use initializers that
765 don't formally overflow signed char, to avoid warnings.
000098c1
PE
766 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
767 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
768 (allocate_buffer): Don't assume sizeof (struct buffer) is a
769 multiple of sizeof (EMACS_INT); it need not be, if
770 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 771 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 772
895009e1
JB
7732011-04-26 Juanma Barranquero <lekktu@gmail.com>
774
775 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
776
6a7a1b0b
TZ
7772011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
778
779 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 780 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
781 Reported by Paul Eggert <eggert@cs.ucla.edu>.
782
841a1577 7832011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
784
785 * lisp.h (Qdebug): List symbol.
895009e1 786 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
787 * keyboard.c (debug-on-event): New variable.
788 (handle_user_signal): Break into debugger when debug-on-event
789 matches the current signal symbol.
790
f2d3ba6f
DN
7912011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
792
793 * alloc.c (check_sblock, check_string_bytes)
794 (check_string_free_list): Convert to standard C.
795
42ce4c63
TZ
7962011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
797
798 * w32.c (emacs_gnutls_push): Fix typo.
799
825cd63c
EZ
8002011-04-25 Eli Zaretskii <eliz@gnu.org>
801
fb11d64d
EZ
802 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
803 "cast to pointer from integer of different size".
804
825cd63c
EZ
805 Improve doprnt and its use in verror. (Bug#8545)
806 * doprnt.c (doprnt): Document the set of format control sequences
807 supported by the function. Use SAFE_ALLOCA instead of always
808 using `alloca'.
809
810 * eval.c (verror): Don't limit the buffer size at size_max-1, that
811 is one byte too soon. Don't use xrealloc; instead xfree and
812 xmalloc anew.
813
e061a11b
TZ
8142011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
815
816 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
817 callbacks stage.
818
819 * gnutls.c: Renamed global_initialized to
820 gnutls_global_initialized. Added internals for the
821 :verify-hostname-error, :verify-error, and :verify-flags
822 parameters of `gnutls-boot' and documented those parameters in the
823 docstring. Start callback support.
824 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
825 unless a fatal error occured. Call gnutls_alert_send_appropriate
826 on error. Return error code.
827 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
828 (emacs_gnutls_read): Likewise.
829 (Fgnutls_boot): Return handshake error code.
830 (emacs_gnutls_handle_error): New function.
831 (wsaerror_to_errno): Likewise.
832
833 * w32.h (emacs_gnutls_pull): Add prototype.
834 (emacs_gnutls_push): Likewise.
835
836 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
837 (emacs_gnutls_push): Likewise.
838
8392011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
840
841 * process.c (wait_reading_process_output): Check if GnuTLS
842 buffered some data internally if no FDs are set for TLS
843 connections.
844
845 * makefile.w32-in (OBJ2): Add gnutls.$(O).
846 (LIBS): Link to USER_LIBS.
847 ($(BLD)/gnutls.$(0)): New target.
848
fa6996bc
EZ
8492011-04-24 Eli Zaretskii <eliz@gnu.org>
850
eb35682e
EZ
851 * xdisp.c (handle_single_display_spec): Rename the
852 display_replaced_before_p argument into display_replaced_p, to
853 make it consistent with the commentary. Fix typos in the
854 commentary.
855
e2ad650c
EZ
856 * textprop.c (syms_of_textprop): Remove dead code.
857 (copy_text_properties): Delete obsolete commentary about an
858 interface that was deleted long ago. Fix typos in the description
859 of arguments.
860
1b2de274
EZ
861 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
862 to changes in oldXMenu/XMenu.h from 2011-04-16.
863 <menu_help_message, prev_menu_help_message>: Constify.
864 (IT_menu_make_room): menu->help_text is now `const char **';
865 adjust.
866
867 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
868 to changes in oldXMenu/XMenu.h from 2011-04-16.
869 (struct XMenu): Declare `help_text' `const char **'.
870
871 * xfaces.c <Qunspecified>: Make extern again.
872
873 * syntax.c: Include sys/types.h before including regex.h, as
874 required by Posix.
875
762b15be
EZ
876 * doc.c (get_doc_string): Improve the format passed to `error'.
877
878 * doprnt.c (doprnt): Improve commentary.
879
880 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
881
882 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
883 them with etags.
884
f1052e5d
EZ
885 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
886 changes in globals.h immediately force recompilation.
762b15be
EZ
887 (TAGS): Depend on $(CURDIR)/m/intel386.h and
888 $(CURDIR)/s/ms-w32.h.
889 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 890
fa6996bc
EZ
891 * character.c (Fchar_direction): Function deleted.
892 (syms_of_character): Don't defsubr it.
893 <char-direction-table>: Deleted.
894
e6c3da20
EZ
8952011-04-23 Eli Zaretskii <eliz@gnu.org>
896
897 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
898 * doprnt.c: Include limits.h.
899 (SIZE_MAX): New macro.
04f2d78b
CB
900 (doprnt): Return a size_t value. 2nd arg is now size_t.
901 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
902 Improve overflow protection. Support `l' modifier for integer
903 conversions. Support %l conversion. Don't assume an EMACS_INT
904 argument for integer conversions and for %c.
905
906 * lisp.h (doprnt): Restore prototype.
907
908 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
909 $(SRC)/character.h.
910
911 * Makefile.in (base_obj): Add back doprnt.o.
912
913 * deps.mk (doprnt.o): Add back prerequisites.
914 (callint.o): Depend on character.h.
915
916 * eval.c (internal_lisp_condition_case): Include the handler
917 representation in the error message.
918 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
919 when breaking from the loop.
920
921 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
922
923 * callint.c (Fcall_interactively): When displaying error message
924 about invalid control letter, pass the character's codepoint, not
925 a pointer to its multibyte form. Improve display of the character
926 in octal and display also its hex code.
927
928 * character.c (char_string): Use %x to display the (unsigned)
929 codepoint of an invalid character, to avoid displaying a bogus
930 negative value.
931
932 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
933 `error', not SYMBOL_NAME itself.
934
935 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
936 character arguments to `error'.
937
938 * charset.c (check_iso_charset_parameter): Fix incorrect argument
939 to `error' in error message about FINAL_CHAR argument. Make sure
940 FINAL_CHAR is a character, and use %c when it is passed as
941 argument to `error'.
942
4ffd0d6b 9432011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
944
945 * s/ms-w32.h (localtime): Redirect to sys_localtime.
946
947 * w32.c: Include <time.h>.
948 (sys_localtime): New function.
949
4ffd0d6b 9502011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
951
952 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
953
4ffd0d6b 954 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 955
4ffd0d6b 9562011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 957
4ffd0d6b
GM
958 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
959 zombies (Bug#8467).
aac0c6e3 960
04c56954
EZ
9612011-04-19 Eli Zaretskii <eliz@gnu.org>
962
963 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
964 gl_state.e_property when gl_state.object is Qt.
965
966 * insdel.c (make_gap_larger): Remove limitation of buffer size
967 to <= INT_MAX.
968
16a43933
CY
9692011-04-18 Chong Yidong <cyd@stupidchicken.com>
970
971 * xdisp.c (lookup_glyphless_char_display)
972 (produce_glyphless_glyph): Handle cons cell entry in
973 glyphless-char-display.
974 (Vglyphless_char_display): Document it.
975
976 * term.c (produce_glyphless_glyph): Handle cons cell entry in
977 glyphless-char-display.
978
4581706e
CY
9792011-04-17 Chong Yidong <cyd@stupidchicken.com>
980
981 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
982
983 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
984
985 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
986 definition for no-X builds.
987
4887c6e2 9882011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 989
fd35b6f9
PE
990 Static checks with GCC 4.6.0 and non-default toolkits.
991
5c1ccb01
PE
992 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
993
006c5daa
PE
994 * process.c (keyboard_bit_set): Define only if SIGIO.
995 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
996 (send_process): Repair possible setjmp clobbering.
997
efc736d3
PE
998 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
999
4e2fe2e6
PE
1000 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1001
f97334a2
PE
1002 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1003
4e75f29d
PE
1004 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1005 Define only if needed.
1006
90efadd1
PE
1007 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1008 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1009 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1010
3c647824
PE
1011 * dispextern.h (struct redisplay_interface): Rename param
1012 to avoid shadowing.
e264f262 1013 * termhooks.h (struct terminal): Likewise.
761383f4 1014 * xterm.c (xembed_send_message): Likewise.
3c647824 1015
b58c5c4a
PE
1016 * insdel.c (make_gap_smaller): Define only if
1017 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1018
cad59032
PE
1019 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1020 it.
1021
c339dc2e
PE
1022 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1023 so that we aren't warned about unused symbols.
1024
91a3e27b
PE
1025 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1026
399c71d3 1027 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1028
8ffc96f5
PE
1029 * xfns.c (x_real_positions): Mark locals as initialized.
1030
eef9bc79
PE
1031 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1032
098db9dd
PE
1033 * xterm.c: Fix problems found by static analysis with other toolkits.
1034 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1035 (x_dispatch_event): Declare static if USE_GTK, and
1036 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1037 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1038 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1039 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1040 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1041
eb18f6cc
PE
1042 * xmenu.c (menu_help_callback): Pointer type fixes.
1043 Use const pointers when pointing at readonly data. Avoid pointer
1044 signedness clashes.
1045 (FALSE): Remove unused macro.
1046 (update_frame_menubar): Remove unused decl.
1047
1fe72bf8
PE
1048 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1049
60d9e1db
PE
1050 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1051 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1052 (single_menu_item): Rename local to avoid shadowing.
1053
39261c26
PE
1054 * keyboard.c (make_lispy_event): Remove unused local var.
1055
018c5e19
PE
1056 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1057 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1058
63d2b86e
PE
1059 * bitmaps: Change bitmaps from unsigned char back to the X11
1060 compatible char. Avoid the old compiler warnings about
1061 out-of-range initializers by using, for example, '\xab' rather
1062 than 0xab.
1063
aefd87e1
PE
1064 * xgselect.c (xgselect_initialize): Check vs interface
1065 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1066
bf501fb9
PE
1067 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1068
e9829fdf
PE
1069 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1070 to read-only memory.
1071
1086c095
PE
1072 * fns.c (vector): Remove; this old hack is no longer needed.
1073
2baccd04 1074 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1075 Remove unused var.
dde42981 1076 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1077
72391843 1078 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1079
436c16df 1080 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1081 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1082 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1083
92bb796d 1084 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1085 (x_term_init): Remove local to avoid shadowing.
92bb796d 1086
764430a3 1087 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1088
1089 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1090 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1091
d1dfb56c
EZ
10922011-04-16 Eli Zaretskii <eliz@gnu.org>
1093
c4354cb4
EZ
1094 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1095
d1dfb56c
EZ
1096 Fix regex.c, syntax.c and friends for buffers > 2GB.
1097 * syntax.h (struct gl_state_s): Declare character position members
1098 EMACS_INT.
1099
1100 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1101
04f2d78b
CB
1102 * textprop.c (verify_interval_modification, interval_of):
1103 Declare arguments EMACS_INT.
d1dfb56c
EZ
1104
1105 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1106 EMACS_INT.
1107
1108 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1109
1110 * indent.c (Fvertical_motion): Local variable it_start is now
1111 EMACS_INT.
1112
1113 * regex.c (re_match, re_match_2, re_match_2_internal)
1114 (bcmp_translate, regcomp, regexec, print_double_string)
1115 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1116 (re_compile_pattern, re_exec): Declare arguments and local
1117 variables `size_t' and `ssize_t' and return values `regoff_t', as
1118 appropriate.
1119 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1120 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1121 <compile_stack_type>: `size' and `avail' are now `size_t'.
1122
1123 * regex.h <regoff_t>: Use ssize_t, not int.
1124 (re_search, re_search_2, re_match, re_match_2): Arguments that
1125 specify buffer/string position and length are now ssize_t and
1126 size_t. Return type is regoff_t.
1127
613052cd
BK
11282011-04-16 Ben Key <bkey76@gmail.com>
1129
1130 * nsfont.m: Fixed bugs in ns_get_family and
1131 ns_descriptor_to_entity that were caused by using free to
1132 deallocate memory blocks that were allocated by xmalloc (via
1133 xstrdup). This caused Emacs to crash when compiled with
1134 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1135 --enable-checking=xmallocoverrun). xfree is now used to
1136 deallocate these memory blocks.
1137
4170f62f 11382011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1139
71b41406
PE
1140 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1141
9587a89d
PE
1142 emacs_write: Accept and return EMACS_INT for sizes.
1143 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1144 et seq.
1145 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1146 Accept and return EMACS_INT.
1147 (emacs_gnutls_write): Return the number of bytes written on
1148 partial writes.
1149 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1150 (emacs_read, emacs_write): Remove check for negative size, as the
1151 Emacs source code has been audited now.
9587a89d
PE
1152 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1153 (emacs_read, emacs_write): Use it.
273a5f82
PE
1154 * process.c (send_process): Adjust to the new signatures of
1155 emacs_write and emacs_gnutls_write. Do not attempt to store
1156 a byte offset into an 'int'; it might overflow.
9587a89d 1157 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1158
3e047f51
PE
1159 * sound.c: Don't assume sizes fit in 'int'.
1160 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1161 Return EMACS_INT, not int.
3e047f51 1162 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1163 Accept EMACS_INT, not int.
1164 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1165 record read return values.
1166
cc39a9db
BK
11672011-04-15 Ben Key <bkey76@gmail.com>
1168
c9d0ec6d
JB
1169 * keyboard.c (Qundefined): Don't declare static since it is used
1170 in nsfns.m.
1171 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1172 static since they are used in nsfont.m.
cc39a9db 1173
6c60eb9f
SM
11742011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1175
1176 * process.c (Qprocessp): Don't declare static.
1177 * lisp.h (Qprocessp): Declare again.
1178
7990b61a
JB
11792011-04-15 Juanma Barranquero <lekktu@gmail.com>
1180
1181 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1182
5d4cb038
PE
11832011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1184
8bd7b830 1185 Improve C-level modularity by making more things 'static'.
cd64ea1d 1186
e3b27b31
PE
1187 Don't publish debugger-only interfaces to other modules.
1188 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1189 (verify_bytepos, count_markers): Move decls to the only modules
1190 that need them.
1191 * region-cache.h (pp_cache): Likewise.
1192 * window.h (check_all_windows): Likewise.
1193 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1194
5d4cb038
PE
1195 * sysdep.c (croak): Now static, if
1196 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1197 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1198
1199 * alloc.c (refill_memory_reserve): Now static if
1200 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1201 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1202
e87b6180
PE
1203 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1204 Define only if USE_LUCID.
1205
ac64929e
PE
1206 * xrdb.c (x_customization_string, x_rm_string): Now static.
1207
6f37259d
PE
1208 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1209 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1210
1683e3ab
PE
1211 * xdisp.c (draw_row_with_mouse_face): Now static.
1212 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1213
de9c2632
PE
1214 * window.h (check_all_windows): Mark externally visible.
1215
2b96acb7
PE
1216 * window.c (window_deletion_count): Now static.
1217
1218 * undo.c: Make symbols static if they're not exported.
1219 (last_undo_buffer, last_boundary_position, pending_boundary):
1220 Now static.
1221
50436f33
PE
1222 * textprop.c (interval_insert_behind_hooks): Now static.
1223 (interval_insert_in_front_hooks): Likewise.
1224
64520e5c
PE
1225 * term.c: Make symbols static if they're not exported.
1226 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1227 (max_frame_lines, tty_set_terminal_modes):
1228 (tty_reset_terminal_modes, tty_turn_off_highlight):
1229 (get_tty_terminal): Now static.
1230 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1231 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1232 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1233 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1234 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1235
1fa53021
PE
1236 * sysdep.c: Make symbols static if they're not exported.
1237 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1238 Now static.
1239 (sigprocmask_set, full_mask): Remove; unused.
1240 (wait_debugging): Mark as visible.
1241 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1242 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1243
d4b43b22
PE
1244 * syntax.c (syntax_temp): Define only if !__GNUC__.
1245
b7c513d0
PE
1246 * sound.c (current_sound_device, current_sound): Now static.
1247
989b29ad
PE
1248 * search.c (searchbufs, searchbuf_head): Now static.
1249
13a55a78
PE
1250 * scroll.c (scroll_cost): Remove; unused.
1251 * dispextern.h (scroll_cost): Remove decl.
1252
de68a1fc
PE
1253 * region-cache.h (pp_cache): Mark as externally visible.
1254
40ccffa6
PE
1255 * process.c: Make symbols static if they're not exported.
1256 (process_tick, update_tick, create_process, chan_process):
1257 (Vprocess_alist, proc_buffered_char, datagram_access):
1258 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1259 (deactivate_process): Mark defn as static, as well as decl.
1260 * lisp.h (create_process): Remove decl.
1261 * process.h (chan_process, Vprocess_alist): Remove decls.
1262
ad64fc97
PE
1263 * print.c: Make symbols static if they're not exported.
1264 (print_depth, new_backquote_output, being_printed, print_buffer):
1265 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1266 (print_interval, print_number_index, initial_stderr_stream):
1267 Now static.
1268 * lisp.h (Fprinc): Remove decl.
1269 (debug_output_compilation_hack): Mark as externally visible.
1270
adddb265
PE
1271 * sysdep.c (croak): Move decl from here to syssignal.h.
1272 * syssignal.h (croak): Put it here, so the API can be checked when
1273 'croak' is called from dissociate_if_controlling_tty.
1274
1717ede2
PE
1275 * minibuf.c: Make symbols static if they're not exported.
1276 (minibuf_save_list, choose_minibuf_frame): Now static.
1277 * lisp.h (choose_minibuf_frame): Remove decl.
1278
fa5fb2bc
PE
1279 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1280
1e3890d1
PE
1281 * lread.c: Make symbols static if they're not exported.
1282 (read_objects, initial_obarray, oblookup_last_bucket_number):
1283 Now static.
1284 (make_symbol): Remove; unused.
1285 * lisp.h (initial_obarray, make_symbol): Remove decls.
1286
8a1414fa
PE
1287 * keyboard.c: Make symbols static if they're not exported.
1288 (single_kboard, recent_keys_index, total_keys, recent_keys):
1289 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1290 (this_single_command_key_start, echoing, last_auto_save):
1291 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1292 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1293 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1294 (Vlispy_mouse_stem, double_click_count):
1295 Now static.
1296 (force_auto_save_soon): Define only if SIGDANGER.
1297 (ignore_mouse_drag_p): Now static if
1298 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1299 (print_help): Remove; unused.
1300 (stop_character, last_timer_event): Mark as externally visible.
1301 * keyboard.h (ignore_mouse_drag_p): Declare only if
1302 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1303 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1304 * lisp.h (echoing): Remove decl.
1305 (force_auto_save_soon): Declare only if SIGDANGER.
1306 * xdisp.c (redisplay_window): Simplify code, to make it more
1307 obvious that ignore_mouse_drag_p is not accessed if !defined
1308 USE_GTK && !defined HAVE_NS.
1309
93ea6e8f
PE
1310 * intervals.c: Make symbols static if they're not exported.
1311 (merge_properties_sticky, merge_interval_right, delete_interval):
1312 Now static.
1313 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1314
77382fcc
PE
1315 * insdel.c: Make symbols static if they're not exported.
1316 However, leave prepare_to_modify_buffer alone. It's never
1317 called from outside this function, but that appears to be a bug.
1318 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1319 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1320 (adjust_after_replace_noundo): Remove; unused.
1321 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1322 (signal_before_change): Remove decls.
77382fcc 1323
9306c32e
PE
1324 * indent.c (val_compute_motion, val_vmotion): Now static.
1325
cd44d2eb
PE
1326 * image.c: Make symbols static if they're not exported.
1327 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1328 if USE_GTK.
1329 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1330 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1331
ad9a7a06
PE
1332 * fringe.c (standard_bitmaps): Now static.
1333 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1334
81626931
PE
1335 * frame.c: Make symbols static if they're not exported.
1336 (x_report_frame_params, make_terminal_frame): Now static.
1337 (get_frame_param): Now static, unless HAVE_NS.
1338 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1339 (x_get_resource_string): Remove; not used.
1340 * frame.h (make_terminal_frame, x_report_frame_params):
1341 (x_get_resource_string); Remove decls.
1342 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1343 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1344
239f9db9
PE
1345 * font.c, fontset.c: Make symbols static if they're not exported.
1346 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1347 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1348 * font.c (font_close_object): Now static.
1349 * font.h (font_close_object): Remove.
1350 * fontset.c (FONTSET_OBJLIST): Remove.
1351 (free_realized_fontset) #if-0 the body, which does nothing.
1352 (face_suitable_for_char_p): #if-0, as it's never called.
1353 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1354 * xfaces.c (face_at_string_position):
1355 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1356 since 0 is always ASCII.
1357
dfcf3579
PE
1358 * fns.c (weak_hash_tables): Now static.
1359
5045092b
PE
1360 * fileio.c: Make symbols static if they're not exported.
1361 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1362 (Vwrite_region_annotation_buffers): Now static.
1363
57a96f5c
PE
1364 * eval.c: Make symbols static if they're not exported.
1365 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1366 * lisp.h (backtrace_list): Remove decl.
1367
35f08c38
PE
1368 * emacs.c: Make symbols static if they're not exported.
1369 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1370 (fatal_error_code, fatal_error_signal_hook, standard_args):
1371 Now static.
1372 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1373 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1374 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1375 * lisp.h (fatal_error_signal_hook): Remove decl.
1376 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1377
f44bd759
PE
1378 * editfns.c: Move a (normally-unused) function to its only use.
1379 * editfns.c, lisp.h (get_operating_system_release): Remove.
1380 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1381 worth the hassle of breaking this out.
1382
b532497d
PE
1383 * xterm.c: Make symbols static if they're not exported.
1384 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1385 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1386 (x_destroy_window, x_delete_display):
1387 Now static.
1388 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1389 (x_mouse_leave): Remove; unused.
1390 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1391 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1392 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1393 Remove decls.
1394 (x_mouse_leave): Declare only if WINDOWSNT.
1395 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1396 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1397 USE_X_TOOLKIT.
1398
1675728f
PE
1399 * ftxfont.c: Make symbols static if they're not exported.
1400 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1401 HAVE_FREETYPE.
1402 * font.h (ftxfont_driver): Likewise.
1403
e4cebfca
PE
1404 * xfns.c: Make symbols static if they're not exported.
1405 (x_last_font_name, x_display_info_for_name):
1406 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1407 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1408 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1409 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1410 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1411 (last_show_tip_args): Now static.
1412 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1413 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1414 (x_screen_planes): Remove; unused.
1415 * dispextern.h (x_screen_planes): Remove decl.
1416
5bf46f05
PE
1417 * dispnew.c: Make symbols static if they're not exported.
1418 * dispextern.h (redraw_garbaged_frames, scrolling):
1419 (increment_row_positions): Remove.
1420 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1421 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1422 Now static.
1423 (redraw_garbaged_frames): Remove; unused.
1424
435f4c28
PE
1425 * xfaces.c: Make symbols static if they're not exported.
1426 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1427 Remove decls.
1428 * xterm.h (defined_color): Remove decls.
1429 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1430 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1431 (menu_face_changed_default, defined_color, free_realized_face):
1432 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1433 (ascii_face_of_lisp_face): Remove; unused.
1434
8524aef3
PE
1435 * xdisp.c: Make symbols static if they're not exported.
1436 * dispextern.h (scratch_glyph_row, window_box_edges):
1437 (glyph_to_pixel_coords, set_cursor_from_row):
1438 (get_next_display_element, set_iterator_to_next):
1439 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1440 (show_mouse_face): Remove decls
1441 * frame.h (message_buf_print): Likewise.
1442 * lisp.h (pop_message, set_message, check_point_in_composition):
1443 Likewise.
1444 * xterm.h (set_vertical_scroll_bar): Likewise.
1445 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1446 (message_buf_print, scratch_glyph_row, displayed_buffer):
1447 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1448 (get_next_display_element, show_mouse_face, window_box_edges):
1449 (frame_to_window_pixel_xy, check_point_in_composition):
1450 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1451 (glyph_to_pixel_coords): Remove; unused.
1452
16390cd2
PE
1453 * dired.c (file_name_completion): Now static.
1454
1455 * dbusbind.c (xd_in_read_queued_messages): Now static.
1456
a25f4dfa
PE
1457 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1458 * data.c (circular_list_error): Remove.
1459
14a9c8df
PE
1460 * commands.h (last_point_position, last_point_position_buffer):
1461 (last_point_position_window): Remove decls.
1462 * keyboard.c: Make these variables static.
1463
04f2d78b
CB
1464 * coding.h (coding, code_convert_region, encode_coding_gap):
1465 Remove decls.
74ab6df5
PE
1466 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1467 (iso_code_class, detect_coding, code_convert_region): Now static.
1468 (encode_coding_gap): Remove; unused.
1469
38dfbee1
PE
1470 * chartab.c (chartab_chars, chartab_bits): Now static.
1471
a2cb4e63
PE
1472 * charset.h (charset_iso_8859_1): Remove decl.
1473 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1474 Now static.
1475
127198fd
PE
1476 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1477 * ccl.c (Vccl_program_table): Now static.
1478 (check_ccl_update): Remove; unused.
1479
d85b608f
PE
1480 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1481 * category.h: ... from here.
1482 * category.c (check_category_table, set_category_set): Now static.
1483
31cd66f3
PE
1484 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1485 * lisp.h: Remove these decls.
1486
c358e587
PE
1487 * buffer.c (buffer_count): Remove unused var.
1488
e78aecca
PE
1489 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1490 so that it's not optimized away.
1491 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1492 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1493 exported only to the debugger.
1494
e192d7d3 1495 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1496 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1497
92470028
PE
1498 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1499 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1500 was inaccessible from Lisp.
1501 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1502 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1503
244ed907
PE
1504 alloc.c: Import and export fewer symbols, and remove unused items.
1505 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1506 is defined.
1507 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1508 it's not optimized away by whole-program optimization.
1509 (message_enable_multibyte, free_misc): Remove.
1510 (catchlist, handlerlist, mark_backtrace):
1511 Declare only if BYTE_MARK_STACK.
1512 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1513 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1514 (message_enable_multibyte): Remove decl.
1515 (free_misc, interval_free_list, float_block, float_block_index):
1516 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1517 (cons_free_list, last_marked_index):
1518 Now static.
1519 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1520 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1521 (mark_backtrace): Define only if BYTE_MARK_STACK.
1522 * xdisp.c (message_enable_multibyte): Now static.
1523
61c2b50e 1524 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1525 This makes it easier for human readers (and static analyzers)
1526 to see whether these variables are used from other modules.
1527 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1528 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1529 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1530 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1531 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1532 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1533 * xmenu.c, xselect.c:
1534 Declare Q* vars static if they are not used in other modules.
1535 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1536 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1537 Remove decls of unexported vars.
1538 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1539
95c82688
PE
1540 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1541
16a97296
PE
1542 Make Emacs functions such as Fatom 'static' by default.
1543 This makes it easier for human readers (and static analyzers)
1544 to see whether these functions can be called from other modules.
1545 DEFUN now defines a static function. To make the function external
1546 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1547 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1548 (Finit_image_library):
16a97296
PE
1549 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1550 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1551 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1552 Remove decls, since these functions are now static.
1553 (Funintern, Fget_internal_run_time): New decls, since these functions
1554 were already external.
95c82688 1555
16a97296
PE
1556 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1557 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1558 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1559 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1560 * keyboard.c, keymap.c, lread.c:
1561 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1562 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1563 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1564 Mark functions with DEFUE instead of DEFUN,
1565 if they are used in other modules.
1566 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1567 decls for now-static functions.
1568 * buffer.h (Fdelete_overlay): Remove decl.
1569 * callproc.c (Fgetenv_internal): Mark as internal.
1570 * composite.c (Fremove_list_of_text_properties): Remove decl.
1571 (Fcomposition_get_gstring): New forward static decl.
1572 * composite.h (Fcomposite_get_gstring): Remove decl.
1573 * dired.c (Ffile_attributes): New forward static decl.
1574 * doc.c (Fdocumntation_property): New forward static decl.
1575 * eval.c (Ffetch_bytecode): New forward static decl.
1576 (Funintern): Remove extern decl; now in .h file where it belongs.
1577 * fileio.c (Fmake_symbolic_link): New forward static decl.
1578 * image.c (Finit_image_library): New forward static decl.
1579 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1580 * intervals.h (Fprevious_property_change):
1581 (Fremove_list_of_text_properties): Remove decls.
1582 * keyboard.c (Fthis_command_keys): Remove decl.
1583 (Fcommand_execute): New forward static decl.
1584 * keymap.c (Flookup_key): New forward static decl.
1585 (Fcopy_keymap): Now static.
1586 * keymap.h (Flookup_key): Remove decl.
1587 * process.c (Fget_process): New forward static decl.
1588 (Fprocess_datagram_address): Mark as internal.
1589 * syntax.c (Fsyntax_table_p): New forward static decl.
1590 (skip_chars): Remove duplicate decl.
1591 * textprop.c (Fprevious_property_change): New forward static decl.
1592 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1593 Now internal.
1594 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1595 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1596
785bbd42
PE
1597 * editfns.c (Fformat): Remove unreachable code.
1598
8b913b57
AS
15992011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1600
1601 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1602 change. (Bug#8496)
1603
a6744a35
EZ
16042011-04-13 Eli Zaretskii <eliz@gnu.org>
1605
1606 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1607 when at ZV. (Bug#8487)
1608
e7974947
AS
16092011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1610
baad03f0
AS
1611 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1612 (Bug#8437)
1613 * keyboard.c (parse_tool_bar_item): Likewise.
1614 * sound.c (sound_cleanup, alsa_close): Likewise.
1615 * termcap.c (tgetent): Likewise.
1616 * xfns.c (x_default_font_parameter): Likewise.
1617 * xsettings.c (read_and_apply_settings): Likewise.
1618
e7974947
AS
1619 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1620 (overrun_check_free): Protoize.
1621
28272684
PE
16222011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1623
1624 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1625 since callers should never pass a negative size.
1626 Change the signature to match that of plain 'read' and 'write'; see
1627 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1628 * lisp.h: Update prototypes of emacs_write and emacs_read.
1629
11997c76
EZ
16302011-04-11 Eli Zaretskii <eliz@gnu.org>
1631
1632 * xdisp.c (redisplay_window): Don't try to determine the character
1633 position of the scroll margin if the window start point w->startp
e896f03c 1634 is outside the buffer's accessible region. (Bug#8468)
11997c76 1635
8a2cbd72
EZ
16362011-04-10 Eli Zaretskii <eliz@gnu.org>
1637
1638 Fix write-region and its subroutines for buffers > 2GB.
1639 * fileio.c (a_write, e_write): Modify declaration of arguments and
1640 local variables to support buffers larger than 2GB.
1641 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1642
1643 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1644 argument, local variables, and return value.
1645
1646 * lisp.h: Update prototypes of emacs_write and emacs_read.
1647
1648 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1649
4073e537 16502011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1651
1ebfdcb6
PE
1652 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1653
b2ded58d
PE
1654 Fix more problems found by GCC 4.6.0's static checks.
1655
7d66342c
PE
1656 * xdisp.c (vmessage): Use a better test for character truncation.
1657
bbf47d44
PE
1658 * charset.c (load_charset_map): <, not <=, for optimization,
1659 and to avoid potential problems with integer overflow.
9248994d 1660 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1661 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1662 * editfns.c (Fformat): Likewise.
1e69125e 1663 * syntax.c (skip_chars): Likewise.
3befa583 1664
e3019616
PE
1665 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1666 This also lets GCC 4.6.0 generate slightly better loop code.
1667
becfa255
PE
1668 * callint.c (Fcall_interactively): <, not <=, for optimization.
1669 (Fcall_interactively): Count the number of arguments produced,
1670 not the number of arguments given. This is simpler and lets GCC
1671 4.6.0 generate slightly better code.
1672
dae0cd48
PE
1673 * ftfont.c: Distingish more carefully between FcChar8 and char.
1674 The previous code passed unsigned char * to a functions like
1675 strlen and xstrcasecmp that expect char *, which does not
1676 conform to the C standard.
1677 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1678 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1679 char * when the C standard requires it.
1680
76032d70
PE
1681 * keyboard.c (read_char): Remove unused var.
1682
eb3f1cc8
PE
1683 * eval.c: Port to Windows vsnprintf (Bug#8435).
1684 Include <limits.h>.
1685 (SIZE_MAX): Define if the headers do not.
1686 (verror): Do not give up if vsnprintf returns a negative count.
1687 Instead, grow the buffer. This ports to Windows vsnprintf, which
1688 does not conform to C99. Problem reported by Eli Zaretskii.
1689 Also, simplify the allocation scheme, by avoiding the need for
1690 calling realloc, and removing the ALLOCATED variable.
1691
70476b54
PE
1692 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1693
12020a9e
PE
1694 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1695 But keep the doprint source code for now, as we might revamp it
1696 and use it again (Bug#8435).
ea6c7ae6
PE
1697 * lisp.h (doprnt): Remove.
1698 * Makefile.in (base_obj): Remove doprnt.o.
1699 * deps.mk (doprnt.o): Remove.
1700
5fdb398c
PE
1701 error: Print 32- and 64-bit integers portably (Bug#8435).
1702 Without this change, on typical 64-bit hosts error ("...%d...", N)
1703 was used to print both 32- and 64-bit integers N, which relied on
1704 undefined behavior.
1705 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1706 New macro.
1707 * lisp.h (error, verror): Mark as printf-like functions.
1708 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1709 Report overflow in size calculations when allocating printf buffer.
1710 Do not truncate output string at its first null byte.
1711 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1712 Truncate the output at a character boundary, since vsnprintf does not
1713 do that.
1714 * charset.c (check_iso_charset_parameter): Convert internal
1715 character to string before calling 'error', since %c now has the
1716 printf meaning.
1717 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1718 overflow when computing char to be passed to 'error'. Do not
1719 pass Lisp_Object to 'error'; pass the integer instead.
1720 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1721 formatted with plain %d.
1722
b189fa66
PE
1723 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1724
bff87ef0
PE
1725 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1726
7e2cac20
PE
1727 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1728
ce4d90b5
PE
1729 * xterm.c (x_catch_errors): Remove duplicate declaration.
1730
266c9547
PE
1731 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1732
79c49ad2
PE
1733 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1734
368f4090
JM
17352011-04-10 Jim Meyering <meyering@redhat.com>
1736
1737 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1738 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1739 return ssize_t not "int", and use size_t as the buffer length.
1740 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1741 * gnutls.h: Update declarations.
1742 * process.c (read_process_output): Use ssize_t, to match.
1743 (send_process): Likewise.
1744
a32d4040
CY
17452011-04-09 Chong Yidong <cyd@stupidchicken.com>
1746
1747 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1748
8546720e 17492011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1750
04f2d78b
CB
1751 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1752 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 1753
8546720e
GM
1754 * xterm.c (handle_one_xevent):
1755 * xmenu.c (create_and_show_popup_menu):
1756 * xselect.c (x_decline_selection_request)
1757 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1758
0a2f5c1a 17592011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1760
1761 Fix some uses of `int' instead of EMACS_INT.
1762 * search.c (string_match_1, fast_string_match)
1763 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1764 (scan_buffer, find_next_newline_no_quit)
1765 (find_before_next_newline, search_command, Freplace_match)
1766 (Fmatch_data): Make some `int' variables be EMACS_INT.
1767
1768 * xdisp.c (display_count_lines): 3rd argument and return value now
1769 EMACS_INT. All callers changed.
1770 (pint2hrstr): Last argument is now EMACS_INT.
1771
1772 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1773 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1774 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1775 (decode_coding_utf_16, decode_coding_emacs_mule)
1776 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1777 (decode_coding_ccl, decode_coding_charset)
1778 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1779 (decode_coding_iso_2022, decode_coding_emacs_mule)
1780 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1781 <char_offset, last_offset>: Declare EMACS_INT.
1782 (encode_coding_utf_8, encode_coding_utf_16)
1783 (encode_coding_emacs_mule, encode_invocation_designation)
1784 (encode_designation_at_bol, encode_coding_iso_2022)
1785 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1786 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1787 Declare EMACS_INT.
1788 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1789 (encode_invocation_designation): Last argument P_NCHARS is now
1790 EMACS_INT.
1791 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1792 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1793
1794 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1795 All users changed.
1796
1797 * ccl.c (Fccl_execute_on_string): Declare some variables
1798 EMACS_INT.
1799
8546720e 18002011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1801
1802 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1803
4e19a977
CS
18042011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1805
1806 * process.c (Fformat_network_address): Doc fix.
1807
87302331
R
18082011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1809
1810 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1811
cbb59342
CY
18122011-04-08 Chong Yidong <cyd@stupidchicken.com>
1813
1814 * keyboard.c (read_char): Call Lisp function help-form-show,
1815 instead of using internal_with_output_to_temp_buffer.
1816 (Qhelp_form_show): New var.
e0d38eeb 1817 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1818
1819 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1820
1821 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1822
e67a13ab
CY
18232011-04-06 Chong Yidong <cyd@stupidchicken.com>
1824
04f2d78b
CB
1825 * process.c (Flist_processes): Remove to Lisp.
1826 (list_processes_1): Delete.
e67a13ab 1827
973f782d
EZ
18282011-04-06 Eli Zaretskii <eliz@gnu.org>
1829
7c106b1e
EZ
1830 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1831
973f782d
EZ
1832 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1833
41cf7d1a 18342011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1835
ca23cc88
PE
1836 Fix more problems found by GCC 4.6.0's static checks.
1837
f390e2d5
PE
1838 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1839
42eea0d0
PE
1840 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1841
b69769da 1842 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1843
f9541e84
PE
1844 * xdisp.c (vmessage): Mark as a printf-like function.
1845
13841b55
PE
1846 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1847
c136c10f
PE
1848 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1849
5e2d4a30
PE
1850 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1851 printf-like functions.
1852 (tiff_load): Add casts to remove these marks before passing them
1853 to system-supplied API.
1854
583f48b9
PE
1855 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1856
b25d760e
PE
1857 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1858 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1859 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1860 directly, rather than having caller test rule sign. This avoids
1861 some unnecessary tests.
1862 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1863 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1864 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1865
bc7b6697 1866 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1867 (xfont_open): Avoid unnecessary tests.
bc7b6697 1868
27ccc379
PE
1869 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1870
dcd5c89a
PE
1871 * composite.h, composite.c (composition_gstring_put_cache):
1872 Use EMACS_INT, not int, for length.
1873
b13a45c6
PE
1874 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1875 breaking out part of COMPOSITION_DECODE_RULE.
1876 (COMPOSITION_DECODE_RULE): Use it.
1877 * composite.c (get_composition_id): Remove unused local vars,
1878 by using the new macro.
1879
1e792e4d
PE
1880 * textprop.c (set_text_properties_1): Change while to do-while,
1881 since the condition is always true at first.
1882
dc6c6455 1883 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1884 (interval_deletion_adjustment): Return unsigned value.
1885 All uses changed.
dc6c6455 1886
aba7731a
PE
1887 * process.c (list_processes_1, create_pty, read_process_output):
1888 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1889 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1890 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1891 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1892 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1893
fdfc4bf3
PE
1894 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1895
fca8fe46 1896 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1897 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1898
06a0259a 1899 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1900 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1901 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1902
e7b9e80f
PE
1903 * print.c (print_error_message): Avoid int overflow.
1904
56201685
PE
1905 * font.c (font_list_entities): Redo for clarity,
1906 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1907
78834453 1908 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1909 (font_score): Avoid potential overflow in diff calculation.
78834453 1910
0bc0b309 1911 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1912 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1913
e610eaca
PE
1914 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1915
b895abce
PE
1916 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1917 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1918 can always succeed if overflow has undefined behavior.
1919
1f1d9321 1920 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1921 (wordify): Omit three unnecessary tests.
1f1d9321 1922
c59478bc
PE
1923 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1924 All callers changed. This avoids the need for an unused var.
1925
79b73827
PE
1926 * casefiddle.c (casify_region): Remove var that is set but not used.
1927
a4db5dfe
PE
1928 * dired.c (file_name_completion): Remove var that is set but not used.
1929
43aae36e
PE
1930 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1931
2a47c44d 1932 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1933 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1934
a37c69bf
PE
1935 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1936 Check for integer overflow on size calculations.
1937
328ab8e7
PE
1938 * buffer.c (Fprevious_overlay_change): Remove var that is set
1939 but not used.
1940
e5a2a5cb
PE
1941 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1942 Remove vars that are set but not used.
8d84a6eb 1943 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1944 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1945
a60e5f68
PE
1946 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1947
f661cb61 1948 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1949 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1950
f0397f5a
PE
1951 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1952 that are set but not used.
1953
8664db06 1954 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1955 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1956
6abdaa4a
PE
1957 * xselect.c (x_get_local_selection, x_handle_property_notify):
1958 Remove vars that are set but not used.
1959
0ce7538d 1960 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1961 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1962
9ae848fc
PE
1963 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1964 Remove var that is set but not used.
0b918413
PE
1965 (scroll_bar_windows_size): Now size_t, not int.
1966 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1967 Check for overflow.
9ae848fc 1968
a5a62657
PE
1969 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1970 (map_tty_color) [!defined MSDOS]: Likewise.
1971
5c5cdd39
PE
1972 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1973
66ebf983
PE
1974 * coding.c: Remove vars that are set but not used.
1975 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1976 All callers changed.
1977 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1978 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1979 (decode_coding_charset): Remove vars that are set but not used.
1980
1be4d761
PE
1981 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1982 that is set but not used.
1983
47553fa8
PE
1984 * print.c (print_object): Remove var that is set but not used.
1985
1f7196bf 1986 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1987 The gnulib version avoids calling malloc in the usual case,
1988 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1989 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1990 * filelock.c (current_lock_owner): Likewise.
1991 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1992 * sysdep.c: Include allocator.h, careadlinkat.h.
1993 (emacs_no_realloc_allocator): New static constant.
1994 (emacs_readlink): New function.
fdb61804
PE
1995 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1996 ../lib/careadlinkat.h.
d1fdcab7 1997
f84c17c7
SM
19982011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1999
2000 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2001 first non-nil return value).
2002
ef3862ad
JD
20032011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2004
2005 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2006 if not defined (Bug#8403).
2007
376a7006
JB
20082011-04-02 Juanma Barranquero <lekktu@gmail.com>
2009
2010 * xdisp.c (display_count_lines): Remove parameter `start',
2011 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2012 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2013 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2014 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2015 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2016 and thereabouts. All callers changed.
2017 (get_per_char_metric): Remove parameter `f', unused since
2018 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2019
6ca3801d
JM
20202011-04-02 Jim Meyering <meyering@redhat.com>
2021
2022 do not dereference NULL upon failed strdup
2023 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2024 (ns_get_family): Likewise.
2025
d8e2b5ba
JB
20262011-04-02 Juanma Barranquero <lekktu@gmail.com>
2027
2028 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2029
8c74fcbd
JD
20302011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2031
2032 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2033 later (Bug#8403).
2034
7200d79c
SM
20352011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2036
03408648 2037 Add lexical binding.
7200d79c 2038
03408648
SM
2039 * window.c (Ftemp_output_buffer_show): New fun.
2040 (Fsave_window_excursion):
2041 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2042
2043 * lread.c (lisp_file_lexically_bound_p): New function.
2044 (Fload): Bind Qlexical_binding.
2045 (readevalloop): Remove `evalfun' arg.
2046 Bind Qinternal_interpreter_environment.
2047 (Feval_buffer): Bind Qlexical_binding.
2048 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2049 Mark as dynamic.
2050 (syms_of_lread): Declare `lexical-binding'.
2051
2052 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2053
2054 * keyboard.c (eval_dyn): New fun.
2055 (menu_item_eval_property): Use it.
ca105506
SM
2056
2057 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2058
03408648
SM
2059 * fns.c (concat, mapcar1): Accept byte-code-functions.
2060
2061 * eval.c (Fsetq): Handle lexical vars.
2062 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2063 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2064 (FletX, Flet): Obey lexical binding.
2065 (Fcommandp): Handle closures.
2066 (Feval): New `lexical' arg.
2067 (eval_sub): New function extracted from Feval. Use it almost
2068 everywhere where Feval was used. Look up vars in lexical env.
2069 Handle closures.
2070 (Ffunctionp): Move from subr.el.
2071 (Ffuncall): Handle closures.
2072 (apply_lambda): Remove `eval_flags'.
2073 (funcall_lambda): Handle closures and new byte-code-functions.
2074 (Fspecial_variable_p): New function.
2075 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2076 but without exporting it to Lisp.
23aba0ea 2077
23aba0ea 2078 * doc.c (Fdocumentation, store_function_docstring):
03408648 2079 * data.c (Finteractive_form): Handle closures.
23aba0ea 2080
03408648
SM
2081 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2082 interactive spec.
ba83908c 2083
04f2d78b
CB
2084 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2085 New byte-codes.
03408648
SM
2086 (exec_byte_code): New function extracted from Fbyte_code to handle new
2087 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2088
03408648 2089 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2090
03408648 2091 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2092
e2abce01
JB
20932011-03-31 Juanma Barranquero <lekktu@gmail.com>
2094
2095 * xdisp.c (redisplay_internal): Fix prototype.
2096
63696a73 20972011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2098
63696a73 2099 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2100 (try_scrolling): Use it when setting scroll_limit.
2101 Limit scrolling to 100 screen lines.
63696a73
EZ
2102 (redisplay_window): Even when falling back on "recentering",
2103 position point in the window according to scroll-conservatively,
2104 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2105
2106 (try_scrolling): When point is above the window, allow searching
2107 as far as scroll_max, or one screenful, to compute vertical
2108 distance from PT to the scroll margin position. This prevents
2109 try_scrolling from unnecessarily failing when
2110 scroll-conservatively is set to a value slightly larger than the
2111 window height. Clean up the case of PT below the margin at bottom
2112 of window: scroll_max can no longer be INT_MAX. When aggressive
2113 scrolling is in use, don't let point enter the opposite scroll
2114 margin as result of the scroll.
2115 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2116 threshold of 100 lines for never-recentering scrolling.
2117
e4cc2dfc
JB
21182011-03-31 Juanma Barranquero <lekktu@gmail.com>
2119
2120 * dispextern.h (move_it_by_lines):
2121 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2122 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2123 (message_log_check_duplicate): Remove parameters `prev_bol' and
2124 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2125 (redisplay_internal): Remove parameter `preserve_echo_area',
2126 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2127
2128 * indent.c (Fvertical_motion):
2129 * window.c (window_scroll_pixel_based, Frecenter):
2130 Don't pass `need_y_p' to `move_it_by_lines'.
2131
1c470562
SM
21322011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2133
44f230aa
SM
2134 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2135 steal a few bits to be more compact.
2136 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2137 Remove unneeded casts.
2138
1c470562
SM
2139 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2140
888adce9
ZK
21412011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2142
2143 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2144 binding" message (bug#7967).
2145
f838ed7b
PE
21462011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2147
77861b95
PE
2148 Fix more problems found by GCC 4.6.0's static checks.
2149
de6dbc14
PE
2150 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2151 Remove unused local var.
2152
f838ed7b
PE
2153 * editfns.c (Fmessage_box): Remove unused local var.
2154
792c7b2b
PE
2155 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2156 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2157 Omit unused local vars.
c499e557 2158 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2159 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2160 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2161 Omit unused local var.
2162
ba0165e1
PE
2163 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2164 Don't assume string length fits in int.
32ad8845 2165 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2166 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2167
3c59b4c9
PE
2168 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2169 instead of alloca (Bug#8344).
2170
a3eed478 2171 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2172 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2173
eb4d412d
PE
2174 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2175
1658b401
PE
2176 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2177 concerns.
2178
2179 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2180
2181 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2182
9a2c6e05
PE
2183 * keyboard.c (syms_of_keyboard): Use the same style as later
2184 in this function when indexing through an array. This also
2185 works around GCC bug 48267.
2186
03d0a109
PE
2187 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2188
44f730c8
PE
2189 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2190
fe75f926
PE
2191 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2192 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2193
ffa8c828
PE
2194 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2195 This avoids undefined behavior on integer overflow, and is a bit
2196 more convenient anyway since it is compared to a size_t variable.
2197
c5101a77
PE
2198 Variadic C functions now count arguments with size_t, not int.
2199 This avoids an unnecessary limitation on 64-bit machines, which
2200 caused (substring ...) to crash on large vectors (Bug#8344).
2201 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2202 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2203 All variadic functions and their callers changed accordingly.
c5101a77
PE
2204 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2205 * data.c (arith_driver, float_arith_driver): Likewise.
2206 * editfns.c (general_insert_function): Likewise.
2207 * eval.c (struct backtrace.nargs, interactive_p)
2208 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2209 (funcall_lambda, mark_backtrace): Likewise.
2210 * fns.c (concat): Likewise.
2211 * frame.c (x_set_frame_parameters): Likewise.
2212 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2213 0 if not found, not -1. All callers changed.
2214
dd3f25f7
PE
2215 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2216 (stack_copy_size): Now size_t, not int.
2217 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2218
461c2ab9
JB
22192011-03-28 Juanma Barranquero <lekktu@gmail.com>
2220
2221 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2222 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2223 All callers changed.
2224
2225 * lisp.h (multibyte_char_to_unibyte):
2226 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2227 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2228 * character.h (CHAR_TO_BYTE8):
2229 * cmds.c (internal_self_insert):
2230 * editfns.c (general_insert_function):
2231 * keymap.c (push_key_description):
2232 * search.c (Freplace_match):
2233 * xdisp.c (message_dolog, set_message_1): All callers changed.
2234
f6d62986
SM
22352011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2236
2237 * keyboard.c (safe_run_hook_funcall): New function.
2238 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2239 don't set the hook to nil, but remove the offending function instead.
2240 (Qcommand_hook_internal): Remove, unused.
2241 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2242 Vcommand_hook_internal.
2243
2244 * eval.c (enum run_hooks_condition): Remove.
2245 (funcall_nil, funcall_not): New functions.
2246 (run_hook_with_args): Call each function through a `funcall' argument.
2247 Remove `cond' argument, now redundant.
2248 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2249 (Frun_hook_with_args_until_failure): Adjust accordingly.
2250 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2251
1db5b1ad
JB
22522011-03-28 Juanma Barranquero <lekktu@gmail.com>
2253
2254 * dispextern.h (string_buffer_position): Remove declaration.
2255
2256 * print.c (strout): Remove parameter `multibyte', unused since
2257 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2258
2259 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2260 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2261 All callers changed.
2262
2263 * w32.c (_wsa_errlist): Use braces for struct initializers.
2264
2265 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2266 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2267 All callers changed.
2268 (string_buffer_position): Likewise. Also, make static (it's never
2269 used outside xdisp.c).
2270 (cursor_row_p): Remove parameter `w', unused since
2271 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2272 (decode_mode_spec): Remove parameter `precision', introduced during
2273 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2274 All callers changed.
2275
5ffb62aa
JD
22762011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2277
2278 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2279
461c2ab9 22802011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2281
2282 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2283 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2284 (ns_update_auto_hide_menu_bar): New functions.
2285 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2286 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2287 ns_constrain_all_frames.
2288 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2289 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2290
5c380ffb
JD
22912011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2292
2293 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2294
9af30bdf
GM
22952011-03-27 Glenn Morris <rgm@gnu.org>
2296
2297 * syssignal.h: Replace RETSIGTYPE with void.
2298 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2299 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2300 Replace SIGTYPE with void everywhere.
2301 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2302 * s/template.h (SIGTYPE): Remove commented out definition.
2303
e2abce01
JB
23042011-03-26 Eli Zaretskii <eliz@gnu.org>
2305
2306 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2307 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2308
f868cd8a
JB
23092011-03-26 Juanma Barranquero <lekktu@gmail.com>
2310
59eb0929
JB
2311 * w32.c (read_unc_volume): Use parameter `henum', instead of
2312 global variable `wget_enum_handle'.
2313
2314 * keymap.c (describe_vector): Remove parameters `indices' and
2315 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2316 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2317
f868cd8a
JB
2318 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2319
2320 * keyboard.c (timer_check): Remove parameter `do_it_now',
2321 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2322 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2323 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2324
2325 * keyboard.c (read_char):
2326 * w32menu.c (w32_menu_display_help):
2327 * xmenu.c (show_help_event, menu_help_callback):
2328 Adjust calls to `show_help_echo'.
2329
2330 * gtkutil.c (xg_maybe_add_timer):
2331 * keyboard.c (readable_events):
2332 * process.c (wait_reading_process_output):
2333 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2334
2335 * insdel.c (adjust_markers_gap_motion):
2336 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2337 (gap_left, gap_right): Don't call it.
2338
2ecf6fdb
CY
23392011-03-25 Chong Yidong <cyd@stupidchicken.com>
2340
2341 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2342 incurred during fontification.
2343
6b1f9ba4
JB
23442011-03-25 Juanma Barranquero <lekktu@gmail.com>
2345
2346 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2347 (DEFVAR_PER_BUFFER): Don't pass it.
2348
2349 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2350 (scrolling_window): Don't pass it.
2351
0f4a96b5
JB
23522011-03-25 Juanma Barranquero <lekktu@gmail.com>
2353
2354 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2355
2356 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2357 and `suffix'.
2358 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2359 of variables specific to SELinux and computation of `encoded_absname'.
2360
2361 * image.c (XPutPixel): Remove unused variable `height'.
2362
2363 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2364
2365 * unexw32.c (get_section_info): Remove unused variable `section'.
2366
2367 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2368 (system_process_attributes): Remove unused variable `sess'.
2369 (sys_read): Remove unused variable `err'.
2370
2371 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2372 (w32_wnd_proc): Remove unused variable `isdead'.
2373 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2374 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2375 (x_create_tip_frame): Remove unused variable `tem'.
2376
2377 * w32inevt.c (w32_console_read_socket):
2378 Remove unused variable `no_events'.
2379
2380 * w32term.c (x_draw_composite_glyph_string_foreground):
2381 Remove unused variable `width'.
2382
1149507c
JB
23832011-03-24 Juanma Barranquero <lekktu@gmail.com>
2384
2385 * w32term.c (x_set_glyph_string_clipping):
2386 Don't pass uninitialized region to CombineRgn.
2387
9c88f339
JB
23882011-03-23 Juanma Barranquero <lekktu@gmail.com>
2389
2390 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2391 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2392 (Fx_close_connection): Remove unused variable `i'.
2393
2394 * w32font.c (w32font_draw): Return number of glyphs.
2395 (w32font_open_internal): Remove unused variable `i'.
2396 (w32font_driver): Add missing initializer.
2397
2398 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2399 (fill_in_menu): Remove unused variable `items_added'.
2400
2401 * w32term.c (last_mouse_press_frame): Remove static global variable.
2402 (w32_clip_to_row): Remove unused variable `f'.
2403 (x_delete_terminal): Remove unused variable `i'.
2404
2405 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2406 (NOTHING): Remove unused static global variable.
2407 (uniscribe_check_otf): Remove unused variable `table'.
2408 (uniscribe_font_driver): Add missing initializers.
2409
dee091a3
JD
24102011-03-23 Julien Danjou <julien@danjou.info>
2411
2412 * term.c (Fsuspend_tty, Fresume_tty):
2413 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2414 * window.c (temp_output_buffer_show):
2415 * insdel.c (signal_before_change):
2416 * frame.c (Fhandle_switch_frame):
2417 * fileio.c (Fdo_auto_save):
2418 * emacs.c (Fkill_emacs):
2419 * editfns.c (save_excursion_restore):
2420 * cmds.c (internal_self_insert):
2421 * callint.c (Fcall_interactively):
2422 * buffer.c (Fkill_all_local_variables):
2423 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2424 Use Frun_hooks.
0f4a96b5 2425 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2426 unconditionnaly since it does the check itself.
2427
2c520ab5 24282011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2429
c9c49752
PE
2430 Fix more problems found by GCC 4.5.2's static checks.
2431
8abc3f12
PE
2432 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2433 the first time through the loop, since we know p0 < p1 then.
2434 This also avoids a gcc -Wstrict-overflow warning.
2435
a2d26660
PE
2436 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2437 leading to a memory leak, possible in functions like
2438 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2439 of objects (Bug#8318).
a2d26660 2440
916c72e9
PE
2441 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2442 that could (at least in theory) be that large.
2443
19ab8a18
PE
2444 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2445 This is less likely to overflow, and avoids undefined behavior if
2446 overflow does occur. All callers changed. Use strtoul to scan
2447 for the unsigned long integer.
b7cbbd6f
PE
2448 (pint2hrstr): Simplify and tune code slightly.
2449 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2450
f0641eff
PE
2451 * scroll.c (do_scrolling): Work around GCC bug 48228.
2452 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2453
7f650bb9
PE
2454 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2455 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2456 (validate_x_resource_name): Simplify count usage.
2457 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2458
37dd57d1
PE
2459 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2460 fail (Bug#8306).
81e56e61 2461
699979fc 2462 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2463
401bf9b4
PE
2464 * process.c (Fmake_network_process): Use socklen_t, not int,
2465 where POSIX says socklen_t is required in portable programs.
2466 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2467 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2468 (Fmake_network_process, server_accept_connection):
2469 (wait_reading_process_output, read_process_output):
2470 Likewise.
2471
b93aacde
PE
2472 * process.c: Rename or move locals to avoid shadowing.
2473 (list_processes_1, Fmake_network_process):
2474 (read_process_output_error_handler, exec_sentinel_error_handler):
2475 Rename or move locals.
4dc343ee 2476 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2477 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2478 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2479 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2480 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2481
af8a867c 2482 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2483 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2484 Include tparam.h instead, since it declares them.
af8a867c
PE
2485 * cm.h (PC): Remove extern decl; tparam.h now does this.
2486 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2487 * terminfo.c: Include tparam.h, to check interfaces.
2488 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2489 (tparam): Adjust signature to match interface in tparam.h;
2490 this removes some undefined behavior. Check that outstring and len
2491 are zero, which they always are with Emacs.
2492 * tparam.h (PC, BC, UP): New extern decls.
2493
0248044d 2494 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2495 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2496
8ff096c1 2497 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2498 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2499 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2500 (ftfont_list): Remove unused local.
49eaafba
PE
2501 (get_adstyle_property, ftfont_pattern_entity):
2502 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2503 Rename locals to avoid shadowing.
8ff096c1 2504
e2be39f6
PE
2505 * xfont.c (xfont_list_family): Mark var as initialized.
2506
c9735e30
PE
2507 * xml.c (make_dom): Now static.
2508
8f5201ae
PE
2509 * composite.c (composition_compute_stop_pos): Rename local to
2510 avoid shadowing.
b246f932
PE
2511 (composition_reseat_it): Remove unused locals.
2512 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2513 (composition_update_it): Mark var as initialized.
11b61122
PE
2514 (find_automatic_composition): Mark vars as initialized,
2515 with a FIXME (Bug#8290).
8f5201ae 2516
760fbc2c
PE
2517 character.h: Rename locals to avoid shadowing.
2518 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2519 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2520 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2521 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2522 to avoid shadowing.
2523
ff08eb85
PE
2524 * textprop.c (property_change_between_p): Remove; unused.
2525
fc7bf025
PE
2526 * intervals.c (interval_start_pos): Now static.
2527
235d7abc
PE
2528 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2529
44f230aa
SM
2530 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2531 Rename locals to avoid shadowing.
3e7d6594 2532
50060332
PE
2533 * sound.c (wav_play, au_play, Fplay_sound_internal):
2534 Fix pointer signedness.
d01f234b 2535 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2536 (wav_play): Initialize a variable to 0, to prevent undefined
2537 behavior (Bug#8278).
50060332 2538
c4fc4e30
PE
2539 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2540
918436ed
PE
2541 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2542
c939f91b
PE
2543 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2544 clobbering (Bug#8298).
b9c7f648
PE
2545 * sysdep.c (sys_subshell): Likewise.
2546 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2547
6bd8c144
PE
2548 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2549 This should get cleaned up, so that child_setup has the
2550 same signature on all platforms.
2551
7710357c 2552 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2553 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2554
c59da222
CY
25552011-03-22 Chong Yidong <cyd@stupidchicken.com>
2556
2557 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2558 not to be necessary, and produces flickering.
2559
66b87493
GM
25602011-03-20 Glenn Morris <rgm@gnu.org>
2561
2562 * config.in: Remove file.
2563
45b6f6d5
JB
25642011-03-20 Juanma Barranquero <lekktu@gmail.com>
2565
2566 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2567 are now in src/globals.h.
2568 (syms_of_minibuf): Remove spurious & from previous change.
2569
3ec03f7e
LL
25702011-03-20 Leo <sdl.web@gmail.com>
2571
2572 * minibuf.c (completing-read-function): New variable.
2573 (completing-read-default): Rename from completing-read.
2574 (completing-read): Call completing-read-function.
2575
b14e3e21
CY
25762011-03-19 Juanma Barranquero <lekktu@gmail.com>
2577
2578 * xfaces.c (Fx_load_color_file):
2579 Read color file from absolute filename (bug#8250).
2580
f2b726e6
JB
25812011-03-19 Juanma Barranquero <lekktu@gmail.com>
2582
2583 * makefile.w32-in: Update dependencies.
2584
09f6ff02
EZ
25852011-03-17 Eli Zaretskii <eliz@gnu.org>
2586
2587 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2588
29a6015a
PE
25892011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2590
a3a6c54e
PE
2591 Fix more problems found by GCC 4.5.2's static checks.
2592
b766f867
PE
2593 * process.c (make_serial_process_unwind, send_process_trap):
2594 (sigchld_handler): Now static.
2595
be02381c
PE
2596 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2597 That way, the code declares only the vars that it needs.
2598 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2599 * s/cygwin.h (PTY_ITERATION): Likewise.
2600 * s/darwin.h (PTY_ITERATION): Likewise.
2601 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2602
57048744
PE
2603 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2604 * process.c (allocate_pty): Don't declare stb unless it's needed.
2605
7914961c 2606 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2607 (CONSTANTLIM): Remove; unused.
2608 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2609 Define only if needed.
7914961c 2610
b3967b18
PE
2611 * unexelf.c (unexec): Name an expression,
2612 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2613 Use a different way to cause a compilation error if anyone uses
2614 n rather than nn, a way that does not involve shadowing.
73366a00 2615 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2616
29a6015a
PE
2617 * deps.mk (unexalpha.o): Remove; unused.
2618
43cfc33e 2619 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2620 * unexec.h: New file.
ce701a33
PE
2621 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2622 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2623 Depend on unexec.h.
2624 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2625 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2626 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2627 Change as necessary to match prototype in unexec.h.
ce701a33 2628
01f44d5a
PE
2629 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2630 shadowing.
4f63c6bb 2631 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2632
a6670b0b
PE
2633 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2634 Rename locals to avoid shadowing.
2635
cef2010d 2636 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2637 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2638
d4d7173a
PE
2639 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2640
f08b802a
PE
2641 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2642 warning when compiling print.c.
2643
3ddb0639
PE
2644 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2645 instead of using an uninitialized var.
5ad03b97 2646 (font_sort_entities): Mark var as initialized.
3ddb0639 2647
170a2692
PE
2648 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2649
e663c700
PE
2650 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2651 pointers to constants.
89bc529a 2652 (font_parse_fcname): Remove unused vars.
7b81e2d0 2653 (font_delete_unmatched): Now static.
ea838e10 2654 (font_get_spec): Remove; unused.
13a547c6
PE
2655 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2656 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2657 Rename or move locals to avoid shadowing.
e663c700 2658
2a80c887 2659 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2660 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2661
1384fa33 2662 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2663 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2664
8b2c52e9
PE
2665 * alloc.c (mark_backtrace): Move decl from here ...
2666 * lisp.h: ... to here, so that it can be checked.
2667
475545b5 2668 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2669 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2670 (lisp_indirect_variable): Name an expression,
2671 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2672 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2673
b1349114 2674 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2675 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2676 Use const pointer when appropriate.
b1349114 2677
a2928364
PE
2678 * lisp.h (get_system_name, get_operating_system_release):
2679 Move decls here, to check interfaces.
2680 * process.c (get_operating_system_release): Move decl to lisp.h.
2681 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2682 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2683 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2684 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2685 (Fformat_time_string, Fencode_time, Finsert_char):
2686 (Ftranslate_region_internal, Fformat):
2687 Rename or remove local vars to avoid shadowing.
9710023e 2688 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2689
a415e694
PE
2690 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2691 avoid shadowing.
2692
8ef4622d
PE
2693 * lisp.h (eassert): Check that the argument compiles, even if
2694 ENABLE_CHECKING is not defined.
2695
946f9a5b
PE
2696 * data.c (Findirect_variable): Name an expression, to avoid
2697 gcc -Wbad-function-cast warning.
112396d6 2698 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2699 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2700 (Fmake_variable_buffer_local, Fmake_local_variable):
2701 Mark variables as initialized.
52746918 2702 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2703
e5aab7e7 2704 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2705 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2706 Rename locals to avoid shadowing.
dff45157
PE
2707 (mark_stack): Move local variables into the #ifdef region where
2708 they're used.
7bc26fdb
PE
2709 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2710 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2711 needed otherwise.
2712 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2713 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2714 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2715
e5aab7e7
PE
2716 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2717 avoids undefined behavior in theory.
2718
4da60324
PE
2719 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2720
88043301
PE
2721 Use functions, not macros, for up- and down-casing (Bug#8254).
2722 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2723 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2724 to use the following functions instead of these macros.
2725 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2726 EMACS_INT, since callers assume the returned value fits in int.
2727 (upcase1): Likewise, for UPCASE_TABLE.
2728 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2729 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2730 the race-condition problem in the old DOWNCASE.
88043301 2731
19ed5445
PE
2732 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2733 Rename locals to avoid shadowing.
2734 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2735 (regex_compile, re_search_2, re_match_2_internal):
2736 Remove unused local vars.
952db0d7
PE
2737 (FREE_VAR): Rewrite so as not to use empty "else",
2738 which gcc can warn about.
da053e48 2739 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2740 (RETALLOC_IF): Define only if needed.
2741 (WORDCHAR_P): Likewise. This one is never needed, but is used
2742 only in a comment talking about a compiler bug, so put inside
2743 the #if 0 of that comment.
2744 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2745 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2746 Remove; unused.
19ed5445 2747
1f3561e4 2748 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2749 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2750 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2751
ded6f8f7
PE
2752 * search.c (simple_search): Remove unused var.
2753
dbd37a95
PE
2754 * dired.c (compile_pattern): Move decl from here ...
2755 * lisp.h: ... to here, so that it can be checked.
2756 (struct re_registers): New forward decl.
2757
7e47afad
PE
2758 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2759
85f24f61
PE
2760 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2761 All uses changed.
2762 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2763 Rename locals to avoid shadowing.
5671df8f 2764 (Fvertical_motion): Mark locals as initialized.
85f24f61 2765
181aa2be 2766 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2767 (casify_region): Mark local as initialized.
181aa2be 2768
930d429c
PE
2769 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2770
7082eac6
PE
2771 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2772 New macros, so that the caller can use some names other than
2773 gcpro1, gcpro2, etc.
2774 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2775 of the new macros.
2776 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2777 argument, for consistency with GCPRO2_VAR, etc: it is now the
2778 prefix of the variable, not the variable itself. All uses
2779 changed.
38b2c076
PE
2780 * dired.c (directory_files_internal, file_name_completion):
2781 Rename locals to avoid shadowing.
2782
15206ed9
PE
2783 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2784 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2785 dired.c's scmp function, had undefined behavior.
2786 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2787 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2788 * buffer.h: ... to here, because these macros use current_buffer,
2789 and the new implementation with inline functions needs to have
2790 current_buffer in scope now, rather than later when the macros
2791 are used.
2792 (downcase, upcase1): New static inline functions.
2793 (DOWNCASE, UPCASE1): Reimplement using these functions.
2794 This avoids undefined behavior in expressions like
2795 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2796 from race conditions in accessing the global variables
2797 case_temp1 and case_temp2.
2798 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2799 * lisp.h (case_temp1, case_temp2): Remove their decls.
2800 * character.h (ASCII_CHAR_P): Move from here ...
2801 * lisp.h: ... to here, so that the inline functions mentioned
2802 above can use them.
2803
4a6bea26
PE
2804 * dired.c (directory_files_internal_unwind): Now static.
2805
f14b7e14
PE
2806 * fileio.c (file_name_as_directory, directory_file_name):
2807 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2808 Now static.
2893f146
PE
2809 (file_name_as_directory): Use const pointers when appropriate.
2810 (Fexpand_file_name): Likewise. In particular, newdir might
2811 point at constant storage, so make it a const pointer.
fd4ead52 2812 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2813 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2814 signedness issues.
f839df0c
PE
2815 (Fset_file_times, Finsert_file_contents, auto_save_error):
2816 Rename locals to avoid shadowing.
f14b7e14 2817
5716756e 2818 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2819 (Ftry_completion, Fall_completions): Rename or remove locals
2820 to avoid shadowing.
5716756e 2821
b4c3046a
PE
2822 * marker.c (bytepos_to_charpos): Remove; unused.
2823
b45db522
PE
2824 * lisp.h (verify_bytepos, count_markers): New decls,
2825 so that gcc does not warn that these functions aren't declared.
2826
85876d07
PE
2827 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2828 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2829 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2830 (copy_text): Remove unused local var.
85876d07 2831
03d78a21 2832 * filelock.c (within_one_second): Now static.
b3dd38ab 2833 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2834
5df8f01b
PE
2835 * buffer.c (fix_overlays_before): Mark locals as initialized.
2836 (fix_start_end_in_overlays): Likewise. This function should be
2837 simplified by using pointers-to-pointers, but that's a different
2838 matter.
b1d876f1 2839 (switch_to_buffer_1): Now static.
8f54f30a
PE
2840 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2841 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2842
a70072c9 2843 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2844 Fix pointer signedness issue.
edced198
PE
2845 (sys_subshell): Mark local as volatile if checking for lint,
2846 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2847 (MAXPATHLEN): Define only if needed.
a70072c9 2848
a0977c44
PE
2849 * process.c (serial_open, serial_configure): Move decls from here ...
2850 * systty.h: ... to here, so that they can be checked.
2851
a884fdcc
PE
2852 * fns.c (get_random, seed_random): Move extern decls from here ...
2853 * lisp.h: ... to here, so that they can be checked.
2854
604efe86 2855 * sysdep.c (reset_io): Now static.
b8950c94 2856 (wait_for_termination_signal): Remove; unused.
604efe86 2857
38fc62d9
PE
2858 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2859 (copy_keymap_item, append_key, push_text_char_description):
2860 Now static.
1004a21a 2861 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2862 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2863 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2864 (describe_map_tree):
2865 Rename locals to avoid shadowing.
38fc62d9 2866
2f2650da
PE
2867 * keyboard.c: Declare functions static if they are not used elsewhere.
2868 (echo_char, echo_dash, cmd_error, top_level_2):
2869 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2870 (read_char, kbd_buffer_get_event, make_lispy_position):
2871 (make_lispy_event, make_lispy_movement, apply_modifiers):
2872 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2873 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2874 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2875 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2876 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2877
a053e86c 2878 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2879 (mark_kboards): Move decl here ...
2880 * alloc.c (mark_kboards): ... from here.
a053e86c 2881
4752793e
PE
2882 * lisp.h (force_auto_save_soon): New decl.
2883
74f10ca7 2884 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2885 (DEFINE_DUMMY_FUNCTION): New macro.
2886 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2887 Use it.
c03cd23f
PE
2888 (main): Add casts to avoid warnings
2889 if GCC considers string literals to be constants.
74f10ca7 2890
022e70d4
PE
2891 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2892
59d6fe83
PE
2893 * dbusbind.c: Pointer signedness fixes.
2894 (xd_signature, xd_append_arg, xd_initialize):
2895 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2896 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2897 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2898 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2899
78320123
PE
2900 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2901 if GCC considers string literals to be constants.
49cebcca 2902 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2903
35ac2a97
SM
29042011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2905
fb103ca9
SM
2906 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2907 (print_preprocess, print_object): New macro to fix last change.
2908
35ac2a97
SM
2909 * print.c (print_preprocess): Don't forget font objects.
2910
62973b41
JB
29112011-03-16 Juanma Barranquero <lekktu@gmail.com>
2912
2913 * emacs.c (USAGE3): Doc fixes.
2914
0e48bb22
AS
29152011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2916
2917 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2918 structure.
2919
7684e57b
JB
29202011-03-14 Juanma Barranquero <lekktu@gmail.com>
2921
2922 * lisp.h (VWindow_system, Qfile_name_history):
2923 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2924 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2925 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2926
2927 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2928 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2929
2930 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2931 * w32console.c (detect_input_pending, read_input_pending)
2932 (encode_terminal_code):
2933 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2934 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2935 (w32_system_caret_y, Qfile_name_history):
2936 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2937 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2938 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2939 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2940 * w32proc.c (Qlocal, report_file_error):
2941 * w32term.c (Vwindow_system, updating_frame):
2942 * w32uniscribe.c (initialized, uniscribe_font_driver):
2943 Remove unneeded extern declarations.
2944
2aa46d6c
CY
29452011-03-14 Chong Yidong <cyd@stupidchicken.com>
2946
c96bbc66 2947 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2948
cffc6f3b
CY
29492011-03-13 Chong Yidong <cyd@stupidchicken.com>
2950
2951 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2952 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2953 These macros can no longer be used for assignment.
2954
44f230aa
SM
2955 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2956 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2957 (record_buffer_markers, fetch_buffer_markers): New functions for
2958 recording and fetching special buffer markers.
2959 (set_buffer_internal_1, set_buffer_temp): Use them.
2960
2961 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2962
2963 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2964
2965 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2966 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2967
2968 * xdisp.c (hscroll_window_tree):
2969 (reconsider_clip_changes): Use PT instead of BUF_PT.
2970
d251f04b
EZ
29712011-03-13 Eli Zaretskii <eliz@gnu.org>
2972
2973 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2974 $(EMACS_ROOT)/lib/intprops.h.
2975
f0c77cd1
PE
29762011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2977
3eca4629
PE
2978 Fix more problems found by GCC 4.5.2's static checks.
2979
7c86ee98
PE
2980 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2981 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2982 (xg_free_frame_widgets): Make it clear that a local variable is
2983 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2984 (gdk_window_get_screen): Make it clear that this macro is needed
2985 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2986 (int_gtk_range_get_value): New function, which avoids a diagnostic
2987 from gcc -Wbad-function-cast.
2988 (xg_set_toolkit_scroll_bar_thumb): Use it.
2989 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2990 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2991 (get_utf8_string, xg_get_file_with_chooser):
2992 Rename locals to avoid shadowing.
2993 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2994
41729b81
PE
2995 * xgselect.c (xg_select): Remove unused var.
2996
f0c77cd1
PE
2997 * image.c (four_corners_best): Mark locals as initialized.
2998 (gif_load): Initialize transparent_p to zero (Bug#8238).
2999 Mark another local as initialized.
ec6cf4c6 3000 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3001
ce0ad53d 3002 * image.c (clear_image_cache): Now static.
d5d5a617 3003 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3004 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3005 (x_edge_detection): Remove unnecessary cast that
3006 gcc -Wbad-function-cast diagnoses.
2037898d 3007 (gif_load): Fix pointer signedness.
6ae141d6
PE
3008 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3009 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3010
33383987 30112011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3012
d32df629
PE
3013 Improve quality of tests for time stamp overflow.
3014 For example, without this patch (encode-time 0 0 0 1 1
3015 1152921504606846976) returns the obviously-bogus value (-948597
3016 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3017 reports time overflow. See
3018 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3019 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3020 * editfns.c: Include limits.h and intprops.h.
3021 (TIME_T_MIN, TIME_T_MAX): New macros.
3022 (time_overflow): Move earlier, to before first use.
3023 (hi_time, lo_time): New functions, for an accurate test for
3024 out-of-range times.
3025 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3026 (Fget_internal_run_time): Don't assume time_t fits in int.
3027 (make_time): Use list2 instead of Fcons twice.
3028 (Fdecode_time): More accurate test for out-of-range times.
3029 (check_tm_member): New function.
3030 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3031 (lisp_time_argument): Don't rely on undefined left-shift and
3032 right-shift behavior when checking for time stamp overflow.
8be6f318 3033
fe31d94c
PE
3034 * editfns.c (time_overflow): New function, refactoring common code.
3035 (Fformat_time_string, Fdecode_time, Fencode_time):
3036 (Fcurrent_time_string): Use it.
3037
8be6f318
PE
3038 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3039 * dired.c (make_time): Move to ...
3040 * editfns.c (make_time): ... here.
3041 * systime.h: Note the move.
3042
09d9db2c 30432011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3044
126bc0dc
YM
3045 * fringe.c (update_window_fringes): Remove unused variables.
3046
c47cbdfd
YM
3047 * unexmacosx.c (copy_data_segment): Also copy __got section.
3048 (Bug#8223)
3049
7ac80be9
EZ
30502011-03-12 Eli Zaretskii <eliz@gnu.org>
3051
c96bbc66 3052 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3053 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3054 Constify `char *' arguments and their references according to
3055 prototypes in tparam.h.
3056
ecb0f94d 3057 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3058
7ac80be9
EZ
3059 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3060 Adapt all references accordingly.
3061
3062 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3063
ef1fd07e
TT
30642011-03-11 Tom Tromey <tromey@redhat.com>
3065
3066 * buffer.c (syms_of_buffer): Remove obsolete comment.
3067
7ef4b50c
EZ
30682011-03-11 Eli Zaretskii <eliz@gnu.org>
3069
3070 * termhooks.h (encode_terminal_code): Declare prototype.
3071
3072 * msdos.c (encode_terminal_code): Don't declare prototype.
3073
3074 * term.c (encode_terminal_code): Now external again, used by
3075 w32console.c and msdos.c.
3076
44f230aa
SM
3077 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3078 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3079
4b1ec863 30802011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3081
1714f52b 3082 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3083
4b1ec863
PE
3084 * fringe.c (update_window_fringes): Mark locals as initialized
3085 (Bug#8227).
3086 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3087
524c7aa6
PE
3088 * alloc.c (mark_fringe_data): Move decl from here ...
3089 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3090 to check its interface.
3091 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3092
a5c0af81 3093 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3094 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3095 (fontset_font): Mark local as initialized.
a9a06e0b 3096 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3097
b4716021
PE
3098 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3099
811e9bac 3100 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3101 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3102 (x_own_selection, Fx_disown_selection_internal): Rename locals
3103 to avoid shadowing.
3104 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3105
7e3ab302
PE
3106 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3107 so that the caller can use some name other than gcpro1.
3108 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3109 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3110 (Fx_backspace_delete_keys_p):
3111 Use them to avoid shadowing, and rename vars to avoid shadowing.
3112 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3113 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3114 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3115 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3116 Remove unused locals.
7e3ab302
PE
3117 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3118 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3119 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3120 macros.
f78faa98 3121
e2b13473
PE
3122 * xterm.h (x_mouse_leave): New decl.
3123
77f23912
PE
3124 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3125 Remove unused functions.
cdf4ba58
PE
3126 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3127 (x_calc_absolute_position): Now static.
7411c686 3128 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3129 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3130 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3131 unless they are used.
38d0b34a
PE
3132 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3133 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3134 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3135 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3136 (x_error_catcher, x_connection_closed, x_error_handler):
3137 (x_error_quitter, xembed_send_message, x_iconify_frame):
3138 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3139 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3140 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3141
44f230aa
SM
3142 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3143 Rename or move locals to avoid shadowing.
6b463e58 3144 (tty_defined_color, merge_face_heights): Now static.
5967d051 3145 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3146 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3147 does not deduce is never used uninitialized.
73719eba
PE
3148 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3149 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3150
426994c3 3151 * terminal.c (store_terminal_param): Now static.
5489860b 3152
032f1620 3153 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3154 (set_frame_menubar): Remove unused local.
d4323972 3155 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3156 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3157 since they might point to immutable storage.
281585b0
PE
3158 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3159 since it's unused otherwise.
032f1620 3160
367c19e5 3161 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3162 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3163 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3164 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3165 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3166 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3167 does not deduce are never used uninitialized.
70739cbe 3168
07b48fa9
PE
3169 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3170
8868a238 3171 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3172 * window.c (window_loop, size_window):
3173 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3174
7e5cf297 3175 * window.c (display_buffer): Now static.
d6550a9f
PE
3176 (size_window): Mark variables that gcc -Wuninitialized
3177 does not deduce are never used uninitialized.
a586633d
PE
3178 * window.h (check_all_windows): New decl, to forestall
3179 gcc -Wmissing-prototypes diagnostic.
5b555da1 3180 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3181
f6095868
PE
3182 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3183 shadowing.
3184 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3185 Include <limits.h>.
3186 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3187 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3188 (load_charset_map): Mark variables that gcc -Wuninitialized
3189 does not deduce are never used uninitialized.
53df7c11 3190 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3191
f38b440c
PE
3192 * coding.c (coding_set_source, coding_set_destination):
3193 Use "else { /* comment */ }" rather than "else /* comment */;"
3194 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3195 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3196 a block, when the outer 'i' will do.
3197 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3198 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3199 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3200 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3201 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3202 Rename locals to avoid shadowing.
3203 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3204 * coding.c (emacs_mule_char, encode_invocation_designation):
3205 Now static, since they're not used elsewhere.
413bb2db 3206 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3207 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3208 (decode_coding_emacs_mule): Mark variables that gcc
3209 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3210 (detect_coding_iso_2022): Initialize a local variable that might
3211 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3212 this initialization is needed. (Bug#8211)
5f58e762
PE
3213 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3214 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3215 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3216 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3217 Remove unused macros.
f38b440c 3218
232b38b9 3219 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3220 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3221 * character.c (string_count_byte8): Likewise.
232b38b9 3222
fb90da1b
PE
3223 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3224 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3225
fb93dbc2
PE
3226 * chartab.c (copy_sub_char_table): Now static, since it's not used
3227 elsewhere.
5c156ace
PE
3228 (sub_char_table_ref_and_range, char_table_ref_and_range):
3229 Rename locals to avoid shadowing.
bbcd0949 3230 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3231
7d3b3862 3232 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3233 (BIDI_BOB): Remove unused macro.
7d3b3862 3234
6be7d3da
PE
3235 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3236 deduce are never used uninitialized.
c2ed9c8b 3237 * term.c (encode_terminal_code): Likewise.
6be7d3da 3238
75f8807f 3239 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3240
50938595
PE
3241 * tparam.h: New file.
3242 * term.c, tparam.h: Include it.
3243 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3244 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3245 Move these decls to tparam.h, and make them agree with what
3246 is actually in tparam.c. The previous trick of using incompatible
3247 decls in different modules does not conform to the C standard.
3248 All callers of tparam changed to use tparam's actual API.
3249 * tparam.c (tparam1, tparam, tgoto):
3250 Use const pointers where appropriate.
3251
fbceeba2
PE
3252 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3253 * cm.h (struct cm): Likewise.
3254 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3255 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3256 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3257 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3258 (turn_on_face, init_tty): Likewise.
3259 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3260
7f3f1250
PE
3261 * term.c (term_mouse_position): Rename local to avoid shadowing.
3262
e6ca6543
PE
3263 * alloc.c (mark_ttys): Move decl from here ...
3264 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3265
c40f8d15
AS
32662011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3267
3268 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3269
cfe0661d
JB
32702011-03-09 Juanma Barranquero <lekktu@gmail.com>
3271
3272 * search.c (compile_pattern_1): Remove argument regp, unused since
3273 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3274 (compile_pattern): Don't pass it.
3275
0afb4571
J
32762011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3277
3278 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3279 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3280 for ! HAVE_GTK3.
3281 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3282
3283 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3284
3285 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3286 gdk_window_get_screen, gdk_window_get_geometry,
3287 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3288 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3289 (xg_get_pixbuf_from_pixmap): New function.
3290 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3291 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3292 Call xg_get_pixbuf_from_pixmap instead of
3293 gdk_pixbuf_get_from_drawable.
3294 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3295 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3296 (xg_check_special_colors): Use GtkStyleContext and its functions
3297 for HAVE_GTK3.
3298 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3299 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3300 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3301 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3302 Call gtk_widget_get_preferred_size.
0afb4571
J
3303 (xg_frame_resized): gdk_window_get_geometry only takes 5
3304 parameters.
44f230aa
SM
3305 (xg_win_to_widget, xg_event_is_for_menubar):
3306 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3307 (xg_set_widget_bg): New function.
3308 (delete_cb): New function.
895009e1 3309 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3310 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3311 (xg_set_background_color): Call xg_set_widget_bg.
3312 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3313 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3314 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3315 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3316 if ! HAVE_GTK3.
3317 (update_frame_tool_bar): Call gtk_widget_hide.
3318 (xg_initialize): Use GDK_KEY_g.
3319
3320 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3321 if ! HAVE_GTK3
3322 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3323
3324 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3325 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3326 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3327
1c2cc4ef
JB
33282011-03-08 Juanma Barranquero <lekktu@gmail.com>
3329
3330 * w32xfns.c (select_palette): Check success of RealizePalette against
3331 GDI_ERROR, not zero.
3332
33383987 3333See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3334
3335;; Local Variables:
3336;; coding: utf-8
aac0c6e3
MR
3337;; End:
3338
33383987 3339 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3340
3341 This file is part of GNU Emacs.
3342
3343 GNU Emacs is free software: you can redistribute it and/or modify
3344 it under the terms of the GNU General Public License as published by
3345 the Free Software Foundation, either version 3 of the License, or
3346 (at your option) any later version.
3347
3348 GNU Emacs is distributed in the hope that it will be useful,
3349 but WITHOUT ANY WARRANTY; without even the implied warranty of
3350 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3351 GNU General Public License for more details.
3352
3353 You should have received a copy of the GNU General Public License
3354 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.