Revert to wraparound integer arithmetic, instead of going to float.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
852a74a5 12011-05-05 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2
aab2b9b5
PE
3 * term.c (vfatal): Remove stray call to va_end.
4 It's not needed and the C Standard doesn't allow it here anyway.
5
c378da0b
PE
6 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8
288b08c7
PE
9 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10 bytes.
11
e3601888
PE
12 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
13
db6c0e74
PE
14 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
15
dd5963ea
PE
16 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
17
88c9450f
PE
18 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
19
2f9442b8
PE
20 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
21
c032b5f8
PE
22 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
23 * charset.c (Fdefine_charset_internal): Don't initialize
24 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 25 32-bit int (Bug#8600).
a108c10b
PE
26
27 * lread.c (read_integer): Be more consistent with string-to-number.
28 Use string_to_number to do the actual conversion; this avoids
29 rounding errors and fixes some other screwups. Without this fix,
30 for example, #x1fffffffffffffff was misread as -2305843009213693952.
31 (digit_to_number): Move earlier, for benefit of read_integer.
32 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 33 not a digit in any supported base. (Bug#8602)
a108c10b 34
ad5f9eea
PE
35 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
36
aec1708a
PE
37 * dispnew.c (scrolling_window): Return 1 if we scrolled,
38 to match comment at start of function. This also removes a
39 GCC warning about overflow in a 32+64-bit port.
40
47be4ab5
PE
41 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
42
371cac43
PE
43 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
44 Reported by Stefan Monnier in
45 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
46 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
47 SYMBOLP-guarded XSYMBOL, not XPNTR.
48
d01a7826
PE
49 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
50 (EMACS_UINTPTR): Likewise, with uintptr_t.
51
7fd47d5c
PE
52 * lisp.h: Prefer 64-bit EMACS_INT if available.
53 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
54 on 32-bit hosts that have 64-bit int, so that they can access
55 large files.
56
8727937b
PE
57 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
58
8ac068ac
PE
59 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
60 This removes an assumption that EMACS_INT and long are the same
61 width as pointers. The assumption is true for Emacs porting targets
62 now, but we want to make other targets possible.
63 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
64 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
65 In the rest of the code, change types of integers that hold casted
66 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
67 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
68 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
69 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
70 No need to cast type when ORing.
71 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
72 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
73 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
74 assume EMACS_INT is the same width as char *.
75 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
76 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
77 Remove no-longer-needed casts.
78 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
79 (xg_tool_bar_help_callback, xg_make_tool_item):
80 Use EMACS_INTPTR to hold an integer
81 that will be cast to void *; this can avoid a GCC warning
82 if EMACS_INT is not the same width as void *.
83 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
84 * xdisp.c (display_echo_area_1, resize_mini_window_1):
85 (current_message_1, set_message_1):
86 Use a local to convert to proper width without a cast.
87 * xmenu.c (dialog_selection_callback): Likewise.
88
ede49d71
PE
89 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
90 Also, don't assume VALBITS / RAND_BITS is less than 5,
91 and don't rely on undefined behavior when shifting a 1 left into
92 the sign bit.
93 * lisp.h (get_random): Change signature to match.
94
2f30ecd0
PE
95 * lread.c (hash_string): Use size_t, not int, for hash computation.
96 Normally we prefer signed values; but hashing is special, because
97 it's better to use unsigned division on hash table sizes so that
98 the remainder is nonnegative. Also, size_t is the natural width
99 for hashing into memory. The previous code used 'int', which doesn't
100 retain enough info to hash well into very large tables.
101 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
102
2a866e7b
PE
103 * dbusbind.c: Don't possibly lose pointer info when converting.
104 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
105 Use XPNTR rather than XHASH, so that the high-order bits of
106 the pointer aren't lost when converting through void *.
107
51639eac
PE
108 * eval.c (Fautoload): Don't double-shift a pointer.
109
92394119
PE
110 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
111
f7ff1b0f 1122011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
113
114 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
115 New version that can reserve upto 2GB of heap space.
116
f7ff1b0f 1172011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
118
119 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
120
639c109b
TZ
1212011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
122
123 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
124 `gnutls_certificate_set_x509_key_file'.
125
d2127135
JB
1262011-05-05 Juanma Barranquero <lekktu@gmail.com>
127
128 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
129 Update dependencies.
130
e968f4f3
JB
1312011-05-04 Juanma Barranquero <lekktu@gmail.com>
132
133 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
134 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
135 Remove unused parameter `fildes'.
136 * process.c (read_process_output, send_process): Don't pass it.
137
84d358f0
JB
1382011-05-04 Juanma Barranquero <lekktu@gmail.com>
139
140 Fix previous change: the library cache is defined in w32.c.
141 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
142 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
143
0898ca10
JB
1442011-05-04 Juanma Barranquero <lekktu@gmail.com>
145
146 Implement dynamic loading of GnuTLS on Windows.
147
148 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
149 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
150 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
151 Declare.
152
153 * gnutls.c (Qgnutls_dll): Define.
154 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
155 (gnutls_*): Declare function pointers.
156 (init_gnutls_functions): New function to initialize function pointers.
157 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
158 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
159 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
160 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
161 (emacs_gnutls_write, emacs_gnutls_read)
162 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
163 (Fgnutls_available_p): New function.
164 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
165 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
166 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
167
168 * image.c: Include w32.h.
169 (Vimage_type_cache): Delete.
170 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
171 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
172 (w32_delayed_load): Move to w32.c.
173
174 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
175
176 * w32.c (QCloaded_from, Vlibrary_cache): Define.
177 (w32_delayed_load): Move from image.c. When loading a library, record
178 its filename in the :loaded-from property of the library id.
179 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
180 Initialize and staticpro them.
181 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
182
183 * process.c: Include lisp.h before w32.h, not after.
184 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
185 instead of gnutls_record_check_pending.
186
187 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
188
ff4de4aa
TZ
1892011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
190
191 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
192 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
193 as passed in.
194
abe95abb
JD
1952011-05-03 Jan Djärv <jan.h.d@swipnet.se>
196
197 * xterm.c (x_set_frame_alpha): Do not set property on anything
198 else than FRAME_X_OUTER_WINDOW (Bug#8608).
199
e16e55d4
JB
2002011-05-02 Juanma Barranquero <lekktu@gmail.com>
201
202 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
203
bafcf6a5
JB
2042011-05-02 Juanma Barranquero <lekktu@gmail.com>
205
206 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
207 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
208 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
209 (gnutls_global_initialized, Qgnutls_bootprop_priority)
210 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
211 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
212 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
213 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
214 (Qgnutls_bootprop_callbacks_verify): Make static.
215
e7a6747f
AS
2162011-05-01 Andreas Schwab <schwab@linux-m68k.org>
217
19ed11ba
AS
218 * callproc.c: Indentation fixup.
219
e7a6747f
AS
220 * sysdep.c (wait_for_termination_1): Make static.
221 (wait_for_termination, interruptible_wait_for_termination): Move
222 after wait_for_termination_1.
223
1ef14cb4
LMI
2242011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
225
226 * sysdep.c (interruptible_wait_for_termination): New function
227 which is like wait_for_termination, but allows keyboard
228 interruptions.
229
230 * callproc.c (Fcall_process): Add (:file "file") as an option for
231 the STDOUT buffer.
232 (Fcall_process_region): Ditto.
233
330d880c
EZ
2342011-04-30 Eli Zaretskii <eliz@gnu.org>
235
8db90b73
EZ
236 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
237 rather than `XVECTOR (FOO)->size'.
238
330d880c
EZ
239 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
240 inttypes.h, as a gnulib replacement is used if it not available in
241 system headers.
242
15cbd324
EZ
2432011-04-21 Eli Zaretskii <eliz@gnu.org>
244
245 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
246 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
247 of MOST_POSITIVE_FIXNUM. (Bug#8528)
248
249 * coding.c (coding_alloc_by_realloc): Error out if destination
250 will grow beyond MOST_POSITIVE_FIXNUM.
251 (decode_coding_emacs_mule): Abort if there isn't enough place in
252 charbuf for the composition carryover bytes. Reserve an extra
253 space for up to 2 characters produced in a loop.
254 (decode_coding_iso_2022): Abort if there isn't enough place in
255 charbuf for the composition carryover bytes.
256
2572011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 258
ae940cca
EZ
259 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
260 aborting when %lld or %lll format is passed.
261 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
262 %llo or %llx format is passed. (Bug#8545)
263
03ab8921
EZ
264 * window.c (window_scroll_line_based): Use a marker instead of
265 simple variables to record original value of point. (Bug#7952)
266
afda1437
EZ
267 * doprnt.c (doprnt): Fix the case where a multibyte sequence
268 produced by %s or %c overflows available buffer space. (Bug#8545)
269
f76dee0c
PE
2702011-04-28 Paul Eggert <eggert@cs.ucla.edu>
271
272 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 273 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 274
fdc5744d
JB
2752011-04-28 Juanma Barranquero <lekktu@gmail.com>
276
277 * w32.c (init_environment): Warn about defaulting HOME to C:\.
278
638f053a
JB
2792011-04-28 Juanma Barranquero <lekktu@gmail.com>
280
281 * keyboard.c (Qdelayed_warnings_hook): Define.
282 (command_loop_1): Run `delayed-warnings-hook'
283 if Vdelayed_warnings_list is non-nil.
284 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
285 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
286
d178f871
EZ
2872011-04-28 Eli Zaretskii <eliz@gnu.org>
288
289 * doprnt.c (doprnt): Don't return value smaller than the buffer
290 size if the message was truncated. (Bug#8545).
291
b124fd93
JB
2922011-04-28 Juanma Barranquero <lekktu@gmail.com>
293
294 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
295 (Fx_window_property): #if-0 the whole functions, not just the bodies.
296
e810457d
PE
2972011-04-27 Paul Eggert <eggert@cs.ucla.edu>
298
299 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
300
ea51cceb
JB
3012011-04-27 Juanma Barranquero <lekktu@gmail.com>
302
303 * makefile.w32-in: Update dependencies.
304
94dcfacf
EZ
3052011-04-27 Eli Zaretskii <eliz@gnu.org>
306
307 Improve `doprnt' and its usage. (Bug#8545)
308 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
309 `format_end'. Remove support for %l as a conversion specifier.
310 Don't use xrealloc. Improve diagnostics when the %l size modifier
311 is used. Update the commentary.
312
313 * eval.c (verror): Simplify calculation of size_t.
314
315 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
316 messages.
317
f61f41d7
PE
3182011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
319
320 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
321 change.
322
96fb4434
PE
3232011-04-27 Paul Eggert <eggert@cs.ucla.edu>
324
325 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
326 This makes this file independent of the recent pseudovector change.
327
671875da 3282011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 329
69e9b5a3
PE
330 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
331
b5f869a7 332 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 333 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 334 Remove unused local.
c8926152 335 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 336
841a1577 337 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
338 GCC 4.6.0 optimizes based on type-based alias analysis. For
339 example, if b is of type struct buffer * and v of type struct
340 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
341 != &v->size, and therefore "v->size = 1; b->size = 2; return
342 v->size;" must therefore return 1. This assumption is incorrect
343 for Emacs, since it type-puns struct Lisp_Vector * with many other
344 types. To fix this problem, this patch adds a new type struct
f904488f 345 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
346 and pseudovectors, and helps optimizing compilers not get fooled
347 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
348 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
349 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
350 the size member.
eab3844f
PE
351 (XSETPVECTYPE): Rewrite in terms of new macro.
352 (XSETPVECTYPESIZE): New macro, specifying both type and size.
353 This is a bit clearer, and further avoids the possibility of
354 undesirable aliasing.
355 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 356 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
357 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
358 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
359 (ASIZE): Now uses header.size rather than size. All
360 previous uses of XVECTOR (foo)->size replaced to use this macro,
361 to avoid the hassle of writing XVECTOR (foo)->header.size.
362 (struct vectorlike_header): New type.
eab3844f
PE
363 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
364 object, to help avoid aliasing.
365 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
366 (SUBRP): Likewise, since Lisp_Subr is a special case.
367 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
368 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
369 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 370 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
371 changed to be "header.size" and "header.next".
372 * buffer.h (struct buffer): Likewise.
373 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
374 * frame.h (struct frame): Likewise.
375 * process.h (struct Lisp_Process): Likewise.
376 * termhooks.h (struct terminal): Likewise.
377 * window.c (struct save_window_data, struct saved_window): Likewise.
378 * window.h (struct window): Likewise.
379 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
380 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
381 * buffer.c (init_buffer_once): Likewise.
382 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
383 special case.
384 * process.c (Fformat_network_address): Use local var for size,
385 for brevity.
386
0df1eac5
PE
387 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
388
847ab9d1 389 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
390 * data.c (atof): Remove decl; no longer used or needed.
391 (digit_to_number): Move to lread.c.
392 (Fstring_to_number): Use new string_to_number function, to be
393 consistent with how the Lisp reader treats infinities and NaNs.
394 Do not assume that floating-point numbers represent EMACS_INT
395 without losing information; this is not true on most 64-bit hosts.
396 Avoid double-rounding errors, by insisting on integers when
397 parsing non-base-10 numbers, as the documentation specifies.
398 * lisp.h (string_to_number): New decl, replacing ...
399 (isfloat_string): Remove.
bc0a5c13 400 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 401 (read1): Do not accept +. and -. as integers; this
452f4150
PE
402 appears to have been a coding error. Similarly, do not accept
403 strings like +-1e0 as floating point numbers. Do not report
404 overflow for integer overflows unless the base is not 10 which
405 means we have no simple and reliable way to continue.
406 Break out the floating-point parsing into a new
407 function string_to_number, so that Fstring_to_number parses
408 floating point numbers consistently with the Lisp reader.
409 (digit_to_number): Moved here from data.c. Make it static inline.
410 (E_CHAR, EXP_INT): Remove, replacing with ...
411 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
412 (string_to_number): New function, replacing isfloat_string.
413 This function checks for valid syntax and produces the resulting
414 Lisp float number too. Rework it so that string-to-number
bc0a5c13 415 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
416 so that overflow for non-base-10 numbers is reported only when
417 there's no portable and simple way to convert to floating point.
452f4150 418
67769ffc
PE
419 * textprop.c (set_text_properties_1): Rewrite for clarity,
420 and to avoid GCC warning about integer overflow.
421
c20db43f
PE
422 * intervals.h (struct interval): Use EMACS_INT for members
423 where EMACS_UINT might cause problems. See
424 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
425 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
426 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
427 All uses changed.
37aa2f85
PE
428 (offset_intervals): Tell GCC not to worry about length overflow
429 when negating a negative length.
c20db43f 430
2538aa2f
PE
431 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
432 (overrun_check_free): Likewise.
433
f2d3008d
PE
434 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
435 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
436 word size.
437
ec8df744
PE
438 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
439 (gnutls_make_error): Rename local to avoid shadowing.
440 (gnutls_emacs_global_deinit): ifdef out; not used.
441 (Fgnutls_boot): Use const for pointer to readonly storage.
442 Comment out unused local. Fix pointer signedness problems.
443
640ee02d
PE
444 * lread.c (openp): Don't stuff size_t into an 'int'.
445 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
446 about possible signed overflow.
447
6048fb2a
PE
448 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
449 (GDK_KEY_g): Don't define if already defined.
450 (xg_prepare_tooltip): Avoid pointer signedness problem.
451 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
452
fa3c87e1
PE
453 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
454 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
455
2172544b
PE
456 * xfns.c (Fx_window_property): Simplify a bit,
457 to make a bit faster and to avoid GCC 4.6.0 warning.
458 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
459
9b821a21
PE
460 * fns.c (internal_equal): Don't assume size_t fits in int.
461
3c616cfa
PE
462 * alloc.c (compact_small_strings): Tighten assertion a little.
463
c2982e87
PE
464 Replace pEd with more-general pI, and fix some printf arg casts.
465 * lisp.h (pI): New macro, generalizing old pEd macro to other
466 conversion specifiers. For example, use "...%"pI"d..." rather
467 than "...%"pEd"...".
468 (pEd): Remove. All uses replaced with similar uses of pI.
469 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
470 * alloc.c (check_pure_size): Don't overflow by converting size to int.
471 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
472 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
473 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
474 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
475 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
476 64-bit hosts.
477 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
478 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
479 * print.c (safe_debug_print, print_object): Likewise.
480 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
481 to int.
6f04d126
PE
482 Use pI instead of if-then-else-abort. Use %p to avoid casts,
483 avoiding the 0 flag, which is not portable.
c2982e87
PE
484 * process.c (Fmake_network_process): Use pI to avoid cast.
485 * region-cache.c (pp_cache): Likewise.
486 * xdisp.c (decode_mode_spec): Likewise.
487 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
488 behavior on 64-bit hosts with printf arg.
6f04d126 489 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
490 (x_stop_queuing_selection_requests): Likewise.
491 (x_get_window_property): Don't truncate byte count to an 'int'
492 when tracing.
0b432f21 493
5e073ec7
PE
494 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
495 here, since it parses constructs like leading '-' and spaces,
496 which are not wanted; and it overflows with large numbers.
497 Instead, simply match F[0-9]+, which is what is wanted anyway.
498
36372bf9
PE
499 * alloc.c: Remove unportable assumptions about struct layout.
500 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
501 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
502 (allocate_vectorlike, make_pure_vector): Use the new macros,
503 plus offsetof, to remove unportable assumptions about struct layout.
504 These assumptions hold on all porting targets that I know of, but
505 they are not guaranteed, they're easy to remove, and removing them
506 makes further changes easier.
507
0b432f21
PE
508 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
509 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
510 (string_overrun_cookie): Now const. Use initializers that
511 don't formally overflow signed char, to avoid warnings.
000098c1
PE
512 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
513 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
514 (allocate_buffer): Don't assume sizeof (struct buffer) is a
515 multiple of sizeof (EMACS_INT); it need not be, if
516 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 517 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 518
895009e1
JB
5192011-04-26 Juanma Barranquero <lekktu@gmail.com>
520
521 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
522
6a7a1b0b
TZ
5232011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
524
525 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 526 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
527 Reported by Paul Eggert <eggert@cs.ucla.edu>.
528
841a1577 5292011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
530
531 * lisp.h (Qdebug): List symbol.
895009e1 532 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
533 * keyboard.c (debug-on-event): New variable.
534 (handle_user_signal): Break into debugger when debug-on-event
535 matches the current signal symbol.
536
f2d3ba6f
DN
5372011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
538
539 * alloc.c (check_sblock, check_string_bytes)
540 (check_string_free_list): Convert to standard C.
541
42ce4c63
TZ
5422011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
543
544 * w32.c (emacs_gnutls_push): Fix typo.
545
825cd63c
EZ
5462011-04-25 Eli Zaretskii <eliz@gnu.org>
547
fb11d64d
EZ
548 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
549 "cast to pointer from integer of different size".
550
825cd63c
EZ
551 Improve doprnt and its use in verror. (Bug#8545)
552 * doprnt.c (doprnt): Document the set of format control sequences
553 supported by the function. Use SAFE_ALLOCA instead of always
554 using `alloca'.
555
556 * eval.c (verror): Don't limit the buffer size at size_max-1, that
557 is one byte too soon. Don't use xrealloc; instead xfree and
558 xmalloc anew.
559
e061a11b
TZ
5602011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
561
562 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
563 callbacks stage.
564
565 * gnutls.c: Renamed global_initialized to
566 gnutls_global_initialized. Added internals for the
567 :verify-hostname-error, :verify-error, and :verify-flags
568 parameters of `gnutls-boot' and documented those parameters in the
569 docstring. Start callback support.
570 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
571 unless a fatal error occured. Call gnutls_alert_send_appropriate
572 on error. Return error code.
573 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
574 (emacs_gnutls_read): Likewise.
575 (Fgnutls_boot): Return handshake error code.
576 (emacs_gnutls_handle_error): New function.
577 (wsaerror_to_errno): Likewise.
578
579 * w32.h (emacs_gnutls_pull): Add prototype.
580 (emacs_gnutls_push): Likewise.
581
582 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
583 (emacs_gnutls_push): Likewise.
584
5852011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
586
587 * process.c (wait_reading_process_output): Check if GnuTLS
588 buffered some data internally if no FDs are set for TLS
589 connections.
590
591 * makefile.w32-in (OBJ2): Add gnutls.$(O).
592 (LIBS): Link to USER_LIBS.
593 ($(BLD)/gnutls.$(0)): New target.
594
fa6996bc
EZ
5952011-04-24 Eli Zaretskii <eliz@gnu.org>
596
eb35682e
EZ
597 * xdisp.c (handle_single_display_spec): Rename the
598 display_replaced_before_p argument into display_replaced_p, to
599 make it consistent with the commentary. Fix typos in the
600 commentary.
601
e2ad650c
EZ
602 * textprop.c (syms_of_textprop): Remove dead code.
603 (copy_text_properties): Delete obsolete commentary about an
604 interface that was deleted long ago. Fix typos in the description
605 of arguments.
606
1b2de274
EZ
607 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
608 to changes in oldXMenu/XMenu.h from 2011-04-16.
609 <menu_help_message, prev_menu_help_message>: Constify.
610 (IT_menu_make_room): menu->help_text is now `const char **';
611 adjust.
612
613 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
614 to changes in oldXMenu/XMenu.h from 2011-04-16.
615 (struct XMenu): Declare `help_text' `const char **'.
616
617 * xfaces.c <Qunspecified>: Make extern again.
618
619 * syntax.c: Include sys/types.h before including regex.h, as
620 required by Posix.
621
762b15be
EZ
622 * doc.c (get_doc_string): Improve the format passed to `error'.
623
624 * doprnt.c (doprnt): Improve commentary.
625
626 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
627
628 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
629 them with etags.
630
f1052e5d
EZ
631 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
632 changes in globals.h immediately force recompilation.
762b15be
EZ
633 (TAGS): Depend on $(CURDIR)/m/intel386.h and
634 $(CURDIR)/s/ms-w32.h.
635 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 636
fa6996bc
EZ
637 * character.c (Fchar_direction): Function deleted.
638 (syms_of_character): Don't defsubr it.
639 <char-direction-table>: Deleted.
640
e6c3da20
EZ
6412011-04-23 Eli Zaretskii <eliz@gnu.org>
642
643 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
644 * doprnt.c: Include limits.h.
645 (SIZE_MAX): New macro.
646 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
647 local variables are now size_t instead of int or unsigned.
648 Improve overflow protection. Support `l' modifier for integer
649 conversions. Support %l conversion. Don't assume an EMACS_INT
650 argument for integer conversions and for %c.
651
652 * lisp.h (doprnt): Restore prototype.
653
654 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
655 $(SRC)/character.h.
656
657 * Makefile.in (base_obj): Add back doprnt.o.
658
659 * deps.mk (doprnt.o): Add back prerequisites.
660 (callint.o): Depend on character.h.
661
662 * eval.c (internal_lisp_condition_case): Include the handler
663 representation in the error message.
664 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
665 when breaking from the loop.
666
667 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
668
669 * callint.c (Fcall_interactively): When displaying error message
670 about invalid control letter, pass the character's codepoint, not
671 a pointer to its multibyte form. Improve display of the character
672 in octal and display also its hex code.
673
674 * character.c (char_string): Use %x to display the (unsigned)
675 codepoint of an invalid character, to avoid displaying a bogus
676 negative value.
677
678 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
679 `error', not SYMBOL_NAME itself.
680
681 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
682 character arguments to `error'.
683
684 * charset.c (check_iso_charset_parameter): Fix incorrect argument
685 to `error' in error message about FINAL_CHAR argument. Make sure
686 FINAL_CHAR is a character, and use %c when it is passed as
687 argument to `error'.
688
4ffd0d6b 6892011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
690
691 * s/ms-w32.h (localtime): Redirect to sys_localtime.
692
693 * w32.c: Include <time.h>.
694 (sys_localtime): New function.
695
4ffd0d6b 6962011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
697
698 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
699
4ffd0d6b 700 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 701
4ffd0d6b 7022011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 703
4ffd0d6b
GM
704 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
705 zombies (Bug#8467).
aac0c6e3 706
04c56954
EZ
7072011-04-19 Eli Zaretskii <eliz@gnu.org>
708
709 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
710 gl_state.e_property when gl_state.object is Qt.
711
712 * insdel.c (make_gap_larger): Remove limitation of buffer size
713 to <= INT_MAX.
714
16a43933
CY
7152011-04-18 Chong Yidong <cyd@stupidchicken.com>
716
717 * xdisp.c (lookup_glyphless_char_display)
718 (produce_glyphless_glyph): Handle cons cell entry in
719 glyphless-char-display.
720 (Vglyphless_char_display): Document it.
721
722 * term.c (produce_glyphless_glyph): Handle cons cell entry in
723 glyphless-char-display.
724
4581706e
CY
7252011-04-17 Chong Yidong <cyd@stupidchicken.com>
726
727 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
728
729 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
730
731 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
732 definition for no-X builds.
733
4887c6e2 7342011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 735
fd35b6f9
PE
736 Static checks with GCC 4.6.0 and non-default toolkits.
737
5c1ccb01
PE
738 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
739
006c5daa
PE
740 * process.c (keyboard_bit_set): Define only if SIGIO.
741 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
742 (send_process): Repair possible setjmp clobbering.
743
efc736d3
PE
744 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
745
4e2fe2e6
PE
746 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
747
f97334a2
PE
748 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
749
4e75f29d
PE
750 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
751 Define only if needed.
752
90efadd1
PE
753 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
754 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 755 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 756
3c647824
PE
757 * dispextern.h (struct redisplay_interface): Rename param
758 to avoid shadowing.
e264f262 759 * termhooks.h (struct terminal): Likewise.
761383f4 760 * xterm.c (xembed_send_message): Likewise.
3c647824 761
b58c5c4a
PE
762 * insdel.c (make_gap_smaller): Define only if
763 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
764
cad59032
PE
765 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
766 it.
767
c339dc2e
PE
768 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
769 so that we aren't warned about unused symbols.
770
91a3e27b
PE
771 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
772
399c71d3 773 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 774
8ffc96f5
PE
775 * xfns.c (x_real_positions): Mark locals as initialized.
776
eef9bc79
PE
777 * xmenu.c (xmenu_show): Don't use uninitialized vars.
778
098db9dd
PE
779 * xterm.c: Fix problems found by static analysis with other toolkits.
780 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
781 (x_dispatch_event): Declare static if USE_GTK, and
782 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 783 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 784 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
785 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
786 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 787
eb18f6cc
PE
788 * xmenu.c (menu_help_callback): Pointer type fixes.
789 Use const pointers when pointing at readonly data. Avoid pointer
790 signedness clashes.
791 (FALSE): Remove unused macro.
792 (update_frame_menubar): Remove unused decl.
793
1fe72bf8
PE
794 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
795
60d9e1db
PE
796 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
797 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
798 (single_menu_item): Rename local to avoid shadowing.
799
39261c26
PE
800 * keyboard.c (make_lispy_event): Remove unused local var.
801
018c5e19
PE
802 * frame.c, frame.h (x_get_resource_string): Bring this back, but
803 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
804
63d2b86e
PE
805 * bitmaps: Change bitmaps from unsigned char back to the X11
806 compatible char. Avoid the old compiler warnings about
807 out-of-range initializers by using, for example, '\xab' rather
808 than 0xab.
809
aefd87e1
PE
810 * xgselect.c (xgselect_initialize): Check vs interface
811 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
812
bf501fb9
PE
813 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
814
e9829fdf
PE
815 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
816 to read-only memory.
817
1086c095
PE
818 * fns.c (vector): Remove; this old hack is no longer needed.
819
2baccd04 820 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 821 Remove unused var.
dde42981 822 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 823
72391843 824 * xrdb.c (x_load_resources): Omit unused local.
3565b346 825
436c16df 826 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 827 (x_window): Rename locals to avoid shadowing.
dc5ddd85 828 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 829
92bb796d 830 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 831 (x_term_init): Remove local to avoid shadowing.
92bb796d 832
764430a3 833 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
834
835 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
836 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
837
d1dfb56c
EZ
8382011-04-16 Eli Zaretskii <eliz@gnu.org>
839
c4354cb4
EZ
840 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
841
d1dfb56c
EZ
842 Fix regex.c, syntax.c and friends for buffers > 2GB.
843 * syntax.h (struct gl_state_s): Declare character position members
844 EMACS_INT.
845
846 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
847
848 * textprop.c (verify_interval_modification, interval_of): Declare
849 arguments EMACS_INT.
850
851 * intervals.c (adjust_intervals_for_insertion): Declare arguments
852 EMACS_INT.
853
854 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
855
856 * indent.c (Fvertical_motion): Local variable it_start is now
857 EMACS_INT.
858
859 * regex.c (re_match, re_match_2, re_match_2_internal)
860 (bcmp_translate, regcomp, regexec, print_double_string)
861 (group_in_compile_stack, re_search, re_search_2, regex_compile)
862 (re_compile_pattern, re_exec): Declare arguments and local
863 variables `size_t' and `ssize_t' and return values `regoff_t', as
864 appropriate.
865 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
866 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
867 <compile_stack_type>: `size' and `avail' are now `size_t'.
868
869 * regex.h <regoff_t>: Use ssize_t, not int.
870 (re_search, re_search_2, re_match, re_match_2): Arguments that
871 specify buffer/string position and length are now ssize_t and
872 size_t. Return type is regoff_t.
873
613052cd
BK
8742011-04-16 Ben Key <bkey76@gmail.com>
875
876 * nsfont.m: Fixed bugs in ns_get_family and
877 ns_descriptor_to_entity that were caused by using free to
878 deallocate memory blocks that were allocated by xmalloc (via
879 xstrdup). This caused Emacs to crash when compiled with
880 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
881 --enable-checking=xmallocoverrun). xfree is now used to
882 deallocate these memory blocks.
883
4170f62f 8842011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 885
71b41406
PE
886 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
887
9587a89d
PE
888 emacs_write: Accept and return EMACS_INT for sizes.
889 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
890 et seq.
891 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
892 Accept and return EMACS_INT.
893 (emacs_gnutls_write): Return the number of bytes written on
894 partial writes.
895 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
896 (emacs_read, emacs_write): Remove check for negative size, as the
897 Emacs source code has been audited now.
9587a89d
PE
898 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
899 (emacs_read, emacs_write): Use it.
273a5f82
PE
900 * process.c (send_process): Adjust to the new signatures of
901 emacs_write and emacs_gnutls_write. Do not attempt to store
902 a byte offset into an 'int'; it might overflow.
9587a89d 903 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 904
3e047f51
PE
905 * sound.c: Don't assume sizes fit in 'int'.
906 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 907 Return EMACS_INT, not int.
3e047f51 908 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
909 Accept EMACS_INT, not int.
910 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
911 record read return values.
912
cc39a9db
BK
9132011-04-15 Ben Key <bkey76@gmail.com>
914
c9d0ec6d
JB
915 * keyboard.c (Qundefined): Don't declare static since it is used
916 in nsfns.m.
917 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
918 static since they are used in nsfont.m.
cc39a9db 919
6c60eb9f
SM
9202011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
921
922 * process.c (Qprocessp): Don't declare static.
923 * lisp.h (Qprocessp): Declare again.
924
7990b61a
JB
9252011-04-15 Juanma Barranquero <lekktu@gmail.com>
926
927 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
928
5d4cb038
PE
9292011-04-14 Paul Eggert <eggert@cs.ucla.edu>
930
8bd7b830 931 Improve C-level modularity by making more things 'static'.
cd64ea1d 932
e3b27b31
PE
933 Don't publish debugger-only interfaces to other modules.
934 * lisp.h (safe_debug_print, debug_output_compilation_hack):
935 (verify_bytepos, count_markers): Move decls to the only modules
936 that need them.
937 * region-cache.h (pp_cache): Likewise.
938 * window.h (check_all_windows): Likewise.
939 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
940
5d4cb038
PE
941 * sysdep.c (croak): Now static, if
942 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
943 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
944
945 * alloc.c (refill_memory_reserve): Now static if
946 !defined REL_ALLOC || defined SYSTEM_MALLOC.
947 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 948
e87b6180
PE
949 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
950 Define only if USE_LUCID.
951
ac64929e
PE
952 * xrdb.c (x_customization_string, x_rm_string): Now static.
953
6f37259d
PE
954 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
955 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
956
1683e3ab
PE
957 * xdisp.c (draw_row_with_mouse_face): Now static.
958 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
959
de9c2632
PE
960 * window.h (check_all_windows): Mark externally visible.
961
2b96acb7
PE
962 * window.c (window_deletion_count): Now static.
963
964 * undo.c: Make symbols static if they're not exported.
965 (last_undo_buffer, last_boundary_position, pending_boundary):
966 Now static.
967
50436f33
PE
968 * textprop.c (interval_insert_behind_hooks): Now static.
969 (interval_insert_in_front_hooks): Likewise.
970
64520e5c
PE
971 * term.c: Make symbols static if they're not exported.
972 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
973 (max_frame_lines, tty_set_terminal_modes):
974 (tty_reset_terminal_modes, tty_turn_off_highlight):
975 (get_tty_terminal): Now static.
976 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
977 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 978 HAVE_WINDOW_SYSTEM.
64520e5c
PE
979 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
980 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
981
1fa53021
PE
982 * sysdep.c: Make symbols static if they're not exported.
983 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
984 Now static.
985 (sigprocmask_set, full_mask): Remove; unused.
986 (wait_debugging): Mark as visible.
987 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
988 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
989
d4b43b22
PE
990 * syntax.c (syntax_temp): Define only if !__GNUC__.
991
b7c513d0
PE
992 * sound.c (current_sound_device, current_sound): Now static.
993
989b29ad
PE
994 * search.c (searchbufs, searchbuf_head): Now static.
995
13a55a78
PE
996 * scroll.c (scroll_cost): Remove; unused.
997 * dispextern.h (scroll_cost): Remove decl.
998
de68a1fc
PE
999 * region-cache.h (pp_cache): Mark as externally visible.
1000
40ccffa6
PE
1001 * process.c: Make symbols static if they're not exported.
1002 (process_tick, update_tick, create_process, chan_process):
1003 (Vprocess_alist, proc_buffered_char, datagram_access):
1004 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1005 (deactivate_process): Mark defn as static, as well as decl.
1006 * lisp.h (create_process): Remove decl.
1007 * process.h (chan_process, Vprocess_alist): Remove decls.
1008
ad64fc97
PE
1009 * print.c: Make symbols static if they're not exported.
1010 (print_depth, new_backquote_output, being_printed, print_buffer):
1011 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1012 (print_interval, print_number_index, initial_stderr_stream):
1013 Now static.
1014 * lisp.h (Fprinc): Remove decl.
1015 (debug_output_compilation_hack): Mark as externally visible.
1016
adddb265
PE
1017 * sysdep.c (croak): Move decl from here to syssignal.h.
1018 * syssignal.h (croak): Put it here, so the API can be checked when
1019 'croak' is called from dissociate_if_controlling_tty.
1020
1717ede2
PE
1021 * minibuf.c: Make symbols static if they're not exported.
1022 (minibuf_save_list, choose_minibuf_frame): Now static.
1023 * lisp.h (choose_minibuf_frame): Remove decl.
1024
fa5fb2bc
PE
1025 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1026
1e3890d1
PE
1027 * lread.c: Make symbols static if they're not exported.
1028 (read_objects, initial_obarray, oblookup_last_bucket_number):
1029 Now static.
1030 (make_symbol): Remove; unused.
1031 * lisp.h (initial_obarray, make_symbol): Remove decls.
1032
8a1414fa
PE
1033 * keyboard.c: Make symbols static if they're not exported.
1034 (single_kboard, recent_keys_index, total_keys, recent_keys):
1035 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1036 (this_single_command_key_start, echoing, last_auto_save):
1037 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1038 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1039 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1040 (Vlispy_mouse_stem, double_click_count):
1041 Now static.
1042 (force_auto_save_soon): Define only if SIGDANGER.
1043 (ignore_mouse_drag_p): Now static if
1044 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1045 (print_help): Remove; unused.
1046 (stop_character, last_timer_event): Mark as externally visible.
1047 * keyboard.h (ignore_mouse_drag_p): Declare only if
1048 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1049 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1050 * lisp.h (echoing): Remove decl.
1051 (force_auto_save_soon): Declare only if SIGDANGER.
1052 * xdisp.c (redisplay_window): Simplify code, to make it more
1053 obvious that ignore_mouse_drag_p is not accessed if !defined
1054 USE_GTK && !defined HAVE_NS.
1055
93ea6e8f
PE
1056 * intervals.c: Make symbols static if they're not exported.
1057 (merge_properties_sticky, merge_interval_right, delete_interval):
1058 Now static.
1059 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1060
77382fcc
PE
1061 * insdel.c: Make symbols static if they're not exported.
1062 However, leave prepare_to_modify_buffer alone. It's never
1063 called from outside this function, but that appears to be a bug.
1064 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1065 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1066 (adjust_after_replace_noundo): Remove; unused.
1067 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1068 (signal_before_change): Remove decls.
77382fcc 1069
9306c32e
PE
1070 * indent.c (val_compute_motion, val_vmotion): Now static.
1071
cd44d2eb
PE
1072 * image.c: Make symbols static if they're not exported.
1073 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1074 if USE_GTK.
1075 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1076 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1077
ad9a7a06
PE
1078 * fringe.c (standard_bitmaps): Now static.
1079 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1080
81626931
PE
1081 * frame.c: Make symbols static if they're not exported.
1082 (x_report_frame_params, make_terminal_frame): Now static.
1083 (get_frame_param): Now static, unless HAVE_NS.
1084 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1085 (x_get_resource_string): Remove; not used.
1086 * frame.h (make_terminal_frame, x_report_frame_params):
1087 (x_get_resource_string); Remove decls.
1088 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1089 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1090
239f9db9
PE
1091 * font.c, fontset.c: Make symbols static if they're not exported.
1092 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1093 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1094 * font.c (font_close_object): Now static.
1095 * font.h (font_close_object): Remove.
1096 * fontset.c (FONTSET_OBJLIST): Remove.
1097 (free_realized_fontset) #if-0 the body, which does nothing.
1098 (face_suitable_for_char_p): #if-0, as it's never called.
1099 * fontset.h (face_suitable_for_char_p): Remove decl.
1100 * xfaces.c (face_at_string_position): Use
1101 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1102 since 0 is always ASCII.
1103
dfcf3579
PE
1104 * fns.c (weak_hash_tables): Now static.
1105
5045092b
PE
1106 * fileio.c: Make symbols static if they're not exported.
1107 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1108 (Vwrite_region_annotation_buffers): Now static.
1109
57a96f5c
PE
1110 * eval.c: Make symbols static if they're not exported.
1111 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1112 * lisp.h (backtrace_list): Remove decl.
1113
35f08c38
PE
1114 * emacs.c: Make symbols static if they're not exported.
1115 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1116 (fatal_error_code, fatal_error_signal_hook, standard_args):
1117 Now static.
1118 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1119 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1120 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1121 * lisp.h (fatal_error_signal_hook): Remove decl.
1122 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1123
f44bd759
PE
1124 * editfns.c: Move a (normally-unused) function to its only use.
1125 * editfns.c, lisp.h (get_operating_system_release): Remove.
1126 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1127 worth the hassle of breaking this out.
1128
b532497d
PE
1129 * xterm.c: Make symbols static if they're not exported.
1130 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1131 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1132 (x_destroy_window, x_delete_display):
1133 Now static.
1134 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1135 (x_mouse_leave): Remove; unused.
1136 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1137 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1138 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1139 Remove decls.
1140 (x_mouse_leave): Declare only if WINDOWSNT.
1141 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1142 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1143 USE_X_TOOLKIT.
1144
1675728f
PE
1145 * ftxfont.c: Make symbols static if they're not exported.
1146 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1147 HAVE_FREETYPE.
1148 * font.h (ftxfont_driver): Likewise.
1149
e4cebfca
PE
1150 * xfns.c: Make symbols static if they're not exported.
1151 (x_last_font_name, x_display_info_for_name):
1152 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1153 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1154 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1155 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1156 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1157 (last_show_tip_args): Now static.
1158 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1159 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1160 (x_screen_planes): Remove; unused.
1161 * dispextern.h (x_screen_planes): Remove decl.
1162
5bf46f05
PE
1163 * dispnew.c: Make symbols static if they're not exported.
1164 * dispextern.h (redraw_garbaged_frames, scrolling):
1165 (increment_row_positions): Remove.
1166 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1167 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1168 Now static.
1169 (redraw_garbaged_frames): Remove; unused.
1170
435f4c28
PE
1171 * xfaces.c: Make symbols static if they're not exported.
1172 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1173 Remove decls.
1174 * xterm.h (defined_color): Remove decls.
1175 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1176 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1177 (menu_face_changed_default, defined_color, free_realized_face):
1178 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1179 (ascii_face_of_lisp_face): Remove; unused.
1180
8524aef3
PE
1181 * xdisp.c: Make symbols static if they're not exported.
1182 * dispextern.h (scratch_glyph_row, window_box_edges):
1183 (glyph_to_pixel_coords, set_cursor_from_row):
1184 (get_next_display_element, set_iterator_to_next):
1185 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1186 (show_mouse_face): Remove decls
1187 * frame.h (message_buf_print): Likewise.
1188 * lisp.h (pop_message, set_message, check_point_in_composition):
1189 Likewise.
1190 * xterm.h (set_vertical_scroll_bar): Likewise.
1191 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1192 (message_buf_print, scratch_glyph_row, displayed_buffer):
1193 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1194 (get_next_display_element, show_mouse_face, window_box_edges):
1195 (frame_to_window_pixel_xy, check_point_in_composition):
1196 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1197 (glyph_to_pixel_coords): Remove; unused.
1198
16390cd2
PE
1199 * dired.c (file_name_completion): Now static.
1200
1201 * dbusbind.c (xd_in_read_queued_messages): Now static.
1202
a25f4dfa
PE
1203 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1204 * data.c (circular_list_error): Remove.
1205
14a9c8df
PE
1206 * commands.h (last_point_position, last_point_position_buffer):
1207 (last_point_position_window): Remove decls.
1208 * keyboard.c: Make these variables static.
1209
74ab6df5
PE
1210 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1211 decls.
1212 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1213 (iso_code_class, detect_coding, code_convert_region): Now static.
1214 (encode_coding_gap): Remove; unused.
1215
38dfbee1
PE
1216 * chartab.c (chartab_chars, chartab_bits): Now static.
1217
a2cb4e63
PE
1218 * charset.h (charset_iso_8859_1): Remove decl.
1219 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1220 Now static.
1221
127198fd
PE
1222 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1223 * ccl.c (Vccl_program_table): Now static.
1224 (check_ccl_update): Remove; unused.
1225
d85b608f
PE
1226 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1227 * category.h: ... from here.
1228 * category.c (check_category_table, set_category_set): Now static.
1229
31cd66f3
PE
1230 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1231 * lisp.h: Remove these decls.
1232
c358e587
PE
1233 * buffer.c (buffer_count): Remove unused var.
1234
e78aecca
PE
1235 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1236 so that it's not optimized away.
1237 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1238 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1239 exported only to the debugger.
1240
e192d7d3
PE
1241 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1242 * atimer.h (run_all_atimers): Removed; not exported.
1243
92470028
PE
1244 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1245 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1246 was inaccessible from Lisp.
1247 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1248 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1249
244ed907
PE
1250 alloc.c: Import and export fewer symbols, and remove unused items.
1251 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1252 is defined.
1253 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1254 it's not optimized away by whole-program optimization.
1255 (message_enable_multibyte, free_misc): Remove.
1256 (catchlist, handlerlist, mark_backtrace):
1257 Declare only if BYTE_MARK_STACK.
1258 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1259 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1260 (message_enable_multibyte): Remove decl.
1261 (free_misc, interval_free_list, float_block, float_block_index):
1262 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1263 (cons_free_list, last_marked_index):
1264 Now static.
1265 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1266 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1267 (mark_backtrace): Define only if BYTE_MARK_STACK.
1268 * xdisp.c (message_enable_multibyte): Now static.
1269
61c2b50e 1270 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1271 This makes it easier for human readers (and static analyzers)
1272 to see whether these variables are used from other modules.
1273 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1274 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1275 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1276 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1277 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1278 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1279 * xmenu.c, xselect.c:
1280 Declare Q* vars static if they are not used in other modules.
1281 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1282 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1283 Remove decls of unexported vars.
1284 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1285
95c82688
PE
1286 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1287
16a97296
PE
1288 Make Emacs functions such as Fatom 'static' by default.
1289 This makes it easier for human readers (and static analyzers)
1290 to see whether these functions can be called from other modules.
1291 DEFUN now defines a static function. To make the function external
1292 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1293 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1294 (Finit_image_library):
16a97296
PE
1295 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1296 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1297 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1298 Remove decls, since these functions are now static.
1299 (Funintern, Fget_internal_run_time): New decls, since these functions
1300 were already external.
95c82688 1301
16a97296
PE
1302 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1303 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1304 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1305 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1306 * keyboard.c, keymap.c, lread.c:
1307 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1308 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1309 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1310 Mark functions with DEFUE instead of DEFUN,
1311 if they are used in other modules.
1312 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1313 decls for now-static functions.
1314 * buffer.h (Fdelete_overlay): Remove decl.
1315 * callproc.c (Fgetenv_internal): Mark as internal.
1316 * composite.c (Fremove_list_of_text_properties): Remove decl.
1317 (Fcomposition_get_gstring): New forward static decl.
1318 * composite.h (Fcomposite_get_gstring): Remove decl.
1319 * dired.c (Ffile_attributes): New forward static decl.
1320 * doc.c (Fdocumntation_property): New forward static decl.
1321 * eval.c (Ffetch_bytecode): New forward static decl.
1322 (Funintern): Remove extern decl; now in .h file where it belongs.
1323 * fileio.c (Fmake_symbolic_link): New forward static decl.
1324 * image.c (Finit_image_library): New forward static decl.
1325 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1326 * intervals.h (Fprevious_property_change):
1327 (Fremove_list_of_text_properties): Remove decls.
1328 * keyboard.c (Fthis_command_keys): Remove decl.
1329 (Fcommand_execute): New forward static decl.
1330 * keymap.c (Flookup_key): New forward static decl.
1331 (Fcopy_keymap): Now static.
1332 * keymap.h (Flookup_key): Remove decl.
1333 * process.c (Fget_process): New forward static decl.
1334 (Fprocess_datagram_address): Mark as internal.
1335 * syntax.c (Fsyntax_table_p): New forward static decl.
1336 (skip_chars): Remove duplicate decl.
1337 * textprop.c (Fprevious_property_change): New forward static decl.
1338 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1339 Now internal.
1340 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1341 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1342
785bbd42
PE
1343 * editfns.c (Fformat): Remove unreachable code.
1344
8b913b57
AS
13452011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1346
1347 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1348 change. (Bug#8496)
1349
a6744a35
EZ
13502011-04-13 Eli Zaretskii <eliz@gnu.org>
1351
1352 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1353 when at ZV. (Bug#8487)
1354
e7974947
AS
13552011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1356
baad03f0
AS
1357 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1358 (Bug#8437)
1359 * keyboard.c (parse_tool_bar_item): Likewise.
1360 * sound.c (sound_cleanup, alsa_close): Likewise.
1361 * termcap.c (tgetent): Likewise.
1362 * xfns.c (x_default_font_parameter): Likewise.
1363 * xsettings.c (read_and_apply_settings): Likewise.
1364
e7974947
AS
1365 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1366 (overrun_check_free): Protoize.
1367
28272684
PE
13682011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1369
1370 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1371 since callers should never pass a negative size.
1372 Change the signature to match that of plain 'read' and 'write'; see
1373 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1374 * lisp.h: Update prototypes of emacs_write and emacs_read.
1375
11997c76
EZ
13762011-04-11 Eli Zaretskii <eliz@gnu.org>
1377
1378 * xdisp.c (redisplay_window): Don't try to determine the character
1379 position of the scroll margin if the window start point w->startp
e896f03c 1380 is outside the buffer's accessible region. (Bug#8468)
11997c76 1381
8a2cbd72
EZ
13822011-04-10 Eli Zaretskii <eliz@gnu.org>
1383
1384 Fix write-region and its subroutines for buffers > 2GB.
1385 * fileio.c (a_write, e_write): Modify declaration of arguments and
1386 local variables to support buffers larger than 2GB.
1387 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1388
1389 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1390 argument, local variables, and return value.
1391
1392 * lisp.h: Update prototypes of emacs_write and emacs_read.
1393
1394 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1395
4073e537 13962011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1397
1ebfdcb6
PE
1398 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1399
b2ded58d
PE
1400 Fix more problems found by GCC 4.6.0's static checks.
1401
7d66342c
PE
1402 * xdisp.c (vmessage): Use a better test for character truncation.
1403
bbf47d44
PE
1404 * charset.c (load_charset_map): <, not <=, for optimization,
1405 and to avoid potential problems with integer overflow.
9248994d 1406 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1407 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1408 * editfns.c (Fformat): Likewise.
1e69125e 1409 * syntax.c (skip_chars): Likewise.
3befa583 1410
e3019616
PE
1411 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1412 This also lets GCC 4.6.0 generate slightly better loop code.
1413
becfa255
PE
1414 * callint.c (Fcall_interactively): <, not <=, for optimization.
1415 (Fcall_interactively): Count the number of arguments produced,
1416 not the number of arguments given. This is simpler and lets GCC
1417 4.6.0 generate slightly better code.
1418
dae0cd48
PE
1419 * ftfont.c: Distingish more carefully between FcChar8 and char.
1420 The previous code passed unsigned char * to a functions like
1421 strlen and xstrcasecmp that expect char *, which does not
1422 conform to the C standard.
1423 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1424 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1425 char * when the C standard requires it.
1426
76032d70
PE
1427 * keyboard.c (read_char): Remove unused var.
1428
eb3f1cc8
PE
1429 * eval.c: Port to Windows vsnprintf (Bug#8435).
1430 Include <limits.h>.
1431 (SIZE_MAX): Define if the headers do not.
1432 (verror): Do not give up if vsnprintf returns a negative count.
1433 Instead, grow the buffer. This ports to Windows vsnprintf, which
1434 does not conform to C99. Problem reported by Eli Zaretskii.
1435 Also, simplify the allocation scheme, by avoiding the need for
1436 calling realloc, and removing the ALLOCATED variable.
1437
70476b54
PE
1438 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1439
12020a9e
PE
1440 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1441 But keep the doprint source code for now, as we might revamp it
1442 and use it again (Bug#8435).
ea6c7ae6
PE
1443 * lisp.h (doprnt): Remove.
1444 * Makefile.in (base_obj): Remove doprnt.o.
1445 * deps.mk (doprnt.o): Remove.
1446
5fdb398c
PE
1447 error: Print 32- and 64-bit integers portably (Bug#8435).
1448 Without this change, on typical 64-bit hosts error ("...%d...", N)
1449 was used to print both 32- and 64-bit integers N, which relied on
1450 undefined behavior.
1451 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1452 New macro.
1453 * lisp.h (error, verror): Mark as printf-like functions.
1454 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1455 Report overflow in size calculations when allocating printf buffer.
1456 Do not truncate output string at its first null byte.
1457 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1458 Truncate the output at a character boundary, since vsnprintf does not
1459 do that.
1460 * charset.c (check_iso_charset_parameter): Convert internal
1461 character to string before calling 'error', since %c now has the
1462 printf meaning.
1463 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1464 overflow when computing char to be passed to 'error'. Do not
1465 pass Lisp_Object to 'error'; pass the integer instead.
1466 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1467 formatted with plain %d.
1468
b189fa66
PE
1469 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1470
bff87ef0
PE
1471 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1472
7e2cac20
PE
1473 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1474
ce4d90b5
PE
1475 * xterm.c (x_catch_errors): Remove duplicate declaration.
1476
266c9547
PE
1477 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1478
79c49ad2
PE
1479 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1480
368f4090
JM
14812011-04-10 Jim Meyering <meyering@redhat.com>
1482
1483 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1484 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1485 return ssize_t not "int", and use size_t as the buffer length.
1486 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1487 * gnutls.h: Update declarations.
1488 * process.c (read_process_output): Use ssize_t, to match.
1489 (send_process): Likewise.
1490
a32d4040
CY
14912011-04-09 Chong Yidong <cyd@stupidchicken.com>
1492
1493 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1494
8546720e 14952011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1496
8546720e
GM
1497 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1498 unsigned char, to match FcChar8 type definition.
aac0c6e3 1499
8546720e
GM
1500 * xterm.c (handle_one_xevent):
1501 * xmenu.c (create_and_show_popup_menu):
1502 * xselect.c (x_decline_selection_request)
1503 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1504
0a2f5c1a 15052011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1506
1507 Fix some uses of `int' instead of EMACS_INT.
1508 * search.c (string_match_1, fast_string_match)
1509 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1510 (scan_buffer, find_next_newline_no_quit)
1511 (find_before_next_newline, search_command, Freplace_match)
1512 (Fmatch_data): Make some `int' variables be EMACS_INT.
1513
1514 * xdisp.c (display_count_lines): 3rd argument and return value now
1515 EMACS_INT. All callers changed.
1516 (pint2hrstr): Last argument is now EMACS_INT.
1517
1518 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1519 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1520 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1521 (decode_coding_utf_16, decode_coding_emacs_mule)
1522 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1523 (decode_coding_ccl, decode_coding_charset)
1524 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1525 (decode_coding_iso_2022, decode_coding_emacs_mule)
1526 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1527 <char_offset, last_offset>: Declare EMACS_INT.
1528 (encode_coding_utf_8, encode_coding_utf_16)
1529 (encode_coding_emacs_mule, encode_invocation_designation)
1530 (encode_designation_at_bol, encode_coding_iso_2022)
1531 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1532 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1533 Declare EMACS_INT.
1534 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1535 (encode_invocation_designation): Last argument P_NCHARS is now
1536 EMACS_INT.
1537 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1538 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1539
1540 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1541 All users changed.
1542
1543 * ccl.c (Fccl_execute_on_string): Declare some variables
1544 EMACS_INT.
1545
8546720e 15462011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1547
1548 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1549
4e19a977
CS
15502011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1551
1552 * process.c (Fformat_network_address): Doc fix.
1553
87302331
R
15542011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1555
1556 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1557
cbb59342
CY
15582011-04-08 Chong Yidong <cyd@stupidchicken.com>
1559
1560 * keyboard.c (read_char): Call Lisp function help-form-show,
1561 instead of using internal_with_output_to_temp_buffer.
1562 (Qhelp_form_show): New var.
e0d38eeb 1563 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1564
1565 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1566
1567 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1568
e67a13ab
CY
15692011-04-06 Chong Yidong <cyd@stupidchicken.com>
1570
1571 * process.c (Flist_processes): Removed to Lisp.
1572 (list_processes_1): Deleted.
1573
973f782d
EZ
15742011-04-06 Eli Zaretskii <eliz@gnu.org>
1575
7c106b1e
EZ
1576 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1577
973f782d
EZ
1578 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1579
41cf7d1a 15802011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1581
ca23cc88
PE
1582 Fix more problems found by GCC 4.6.0's static checks.
1583
f390e2d5
PE
1584 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1585
42eea0d0
PE
1586 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1587
b69769da 1588 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1589
f9541e84
PE
1590 * xdisp.c (vmessage): Mark as a printf-like function.
1591
13841b55
PE
1592 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1593
c136c10f
PE
1594 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1595
5e2d4a30
PE
1596 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1597 printf-like functions.
1598 (tiff_load): Add casts to remove these marks before passing them
1599 to system-supplied API.
1600
583f48b9
PE
1601 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1602
b25d760e
PE
1603 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1604 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1605 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1606 directly, rather than having caller test rule sign. This avoids
1607 some unnecessary tests.
1608 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1609 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1610 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1611
bc7b6697 1612 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1613 (xfont_open): Avoid unnecessary tests.
bc7b6697 1614
27ccc379
PE
1615 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1616
dcd5c89a
PE
1617 * composite.h, composite.c (composition_gstring_put_cache):
1618 Use EMACS_INT, not int, for length.
1619
b13a45c6
PE
1620 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1621 breaking out part of COMPOSITION_DECODE_RULE.
1622 (COMPOSITION_DECODE_RULE): Use it.
1623 * composite.c (get_composition_id): Remove unused local vars,
1624 by using the new macro.
1625
1e792e4d
PE
1626 * textprop.c (set_text_properties_1): Change while to do-while,
1627 since the condition is always true at first.
1628
dc6c6455 1629 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1630 (interval_deletion_adjustment): Return unsigned value.
1631 All uses changed.
dc6c6455 1632
aba7731a
PE
1633 * process.c (list_processes_1, create_pty, read_process_output):
1634 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1635 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1636 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1637 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1638 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1639
fdfc4bf3
PE
1640 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1641
fca8fe46 1642 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1643 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1644
06a0259a 1645 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1646 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1647 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1648
e7b9e80f
PE
1649 * print.c (print_error_message): Avoid int overflow.
1650
56201685
PE
1651 * font.c (font_list_entities): Redo for clarity,
1652 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1653
78834453 1654 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1655 (font_score): Avoid potential overflow in diff calculation.
78834453 1656
0bc0b309 1657 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1658 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1659
e610eaca
PE
1660 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1661
b895abce
PE
1662 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1663 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1664 can always succeed if overflow has undefined behavior.
1665
1f1d9321 1666 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1667 (wordify): Omit three unnecessary tests.
1f1d9321 1668
c59478bc
PE
1669 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1670 All callers changed. This avoids the need for an unused var.
1671
79b73827
PE
1672 * casefiddle.c (casify_region): Remove var that is set but not used.
1673
a4db5dfe
PE
1674 * dired.c (file_name_completion): Remove var that is set but not used.
1675
43aae36e
PE
1676 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1677
2a47c44d 1678 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1679 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1680
a37c69bf
PE
1681 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1682 Check for integer overflow on size calculations.
1683
328ab8e7
PE
1684 * buffer.c (Fprevious_overlay_change): Remove var that is set
1685 but not used.
1686
e5a2a5cb
PE
1687 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1688 Remove vars that are set but not used.
8d84a6eb 1689 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1690 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1691
a60e5f68
PE
1692 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1693
f661cb61 1694 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1695 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1696
f0397f5a
PE
1697 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1698 that are set but not used.
1699
8664db06 1700 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1701 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1702
6abdaa4a
PE
1703 * xselect.c (x_get_local_selection, x_handle_property_notify):
1704 Remove vars that are set but not used.
1705
0ce7538d 1706 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1707 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1708
9ae848fc
PE
1709 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1710 Remove var that is set but not used.
0b918413
PE
1711 (scroll_bar_windows_size): Now size_t, not int.
1712 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1713 Check for overflow.
9ae848fc 1714
a5a62657
PE
1715 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1716 (map_tty_color) [!defined MSDOS]: Likewise.
1717
5c5cdd39
PE
1718 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1719
66ebf983
PE
1720 * coding.c: Remove vars that are set but not used.
1721 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1722 All callers changed.
1723 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1724 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1725 (decode_coding_charset): Remove vars that are set but not used.
1726
1be4d761
PE
1727 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1728 that is set but not used.
1729
47553fa8
PE
1730 * print.c (print_object): Remove var that is set but not used.
1731
1f7196bf 1732 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1733 The gnulib version avoids calling malloc in the usual case,
1734 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1735 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1736 * filelock.c (current_lock_owner): Likewise.
1737 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1738 * sysdep.c: Include allocator.h, careadlinkat.h.
1739 (emacs_no_realloc_allocator): New static constant.
1740 (emacs_readlink): New function.
fdb61804
PE
1741 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1742 ../lib/careadlinkat.h.
d1fdcab7 1743
f84c17c7
SM
17442011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1745
1746 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1747 first non-nil return value).
1748
ef3862ad
JD
17492011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1750
1751 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1752 if not defined (Bug#8403).
1753
376a7006
JB
17542011-04-02 Juanma Barranquero <lekktu@gmail.com>
1755
1756 * xdisp.c (display_count_lines): Remove parameter `start',
1757 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1758 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1759 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1760 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1761 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1762 and thereabouts. All callers changed.
1763 (get_per_char_metric): Remove parameter `f', unused since
1764 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1765
6ca3801d
JM
17662011-04-02 Jim Meyering <meyering@redhat.com>
1767
1768 do not dereference NULL upon failed strdup
1769 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1770 (ns_get_family): Likewise.
1771
d8e2b5ba
JB
17722011-04-02 Juanma Barranquero <lekktu@gmail.com>
1773
1774 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1775
8c74fcbd
JD
17762011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1777
1778 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1779 later (Bug#8403).
1780
7200d79c
SM
17812011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1782
03408648 1783 Add lexical binding.
7200d79c 1784
03408648
SM
1785 * window.c (Ftemp_output_buffer_show): New fun.
1786 (Fsave_window_excursion):
1787 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1788
1789 * lread.c (lisp_file_lexically_bound_p): New function.
1790 (Fload): Bind Qlexical_binding.
1791 (readevalloop): Remove `evalfun' arg.
1792 Bind Qinternal_interpreter_environment.
1793 (Feval_buffer): Bind Qlexical_binding.
1794 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1795 Mark as dynamic.
1796 (syms_of_lread): Declare `lexical-binding'.
1797
1798 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1799
1800 * keyboard.c (eval_dyn): New fun.
1801 (menu_item_eval_property): Use it.
ca105506
SM
1802
1803 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1804
03408648
SM
1805 * fns.c (concat, mapcar1): Accept byte-code-functions.
1806
1807 * eval.c (Fsetq): Handle lexical vars.
1808 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1809 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1810 (FletX, Flet): Obey lexical binding.
1811 (Fcommandp): Handle closures.
1812 (Feval): New `lexical' arg.
1813 (eval_sub): New function extracted from Feval. Use it almost
1814 everywhere where Feval was used. Look up vars in lexical env.
1815 Handle closures.
1816 (Ffunctionp): Move from subr.el.
1817 (Ffuncall): Handle closures.
1818 (apply_lambda): Remove `eval_flags'.
1819 (funcall_lambda): Handle closures and new byte-code-functions.
1820 (Fspecial_variable_p): New function.
1821 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1822 but without exporting it to Lisp.
23aba0ea 1823
23aba0ea 1824 * doc.c (Fdocumentation, store_function_docstring):
03408648 1825 * data.c (Finteractive_form): Handle closures.
23aba0ea 1826
03408648
SM
1827 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1828 interactive spec.
ba83908c 1829
03408648
SM
1830 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1831 byte-codes.
1832 (exec_byte_code): New function extracted from Fbyte_code to handle new
1833 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1834
03408648 1835 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1836
03408648 1837 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1838
e2abce01
JB
18392011-03-31 Juanma Barranquero <lekktu@gmail.com>
1840
1841 * xdisp.c (redisplay_internal): Fix prototype.
1842
63696a73 18432011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1844
63696a73
EZ
1845 * xdisp.c (SCROLL_LIMIT): New macro.
1846 (try_scrolling): Use it when setting scroll_limit. Limit
1847 scrolling to 100 screen lines.
1848 (redisplay_window): Even when falling back on "recentering",
1849 position point in the window according to scroll-conservatively,
1850 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1851
1852 (try_scrolling): When point is above the window, allow searching
1853 as far as scroll_max, or one screenful, to compute vertical
1854 distance from PT to the scroll margin position. This prevents
1855 try_scrolling from unnecessarily failing when
1856 scroll-conservatively is set to a value slightly larger than the
1857 window height. Clean up the case of PT below the margin at bottom
1858 of window: scroll_max can no longer be INT_MAX. When aggressive
1859 scrolling is in use, don't let point enter the opposite scroll
1860 margin as result of the scroll.
1861 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1862 threshold of 100 lines for never-recentering scrolling.
1863
e4cc2dfc
JB
18642011-03-31 Juanma Barranquero <lekktu@gmail.com>
1865
1866 * dispextern.h (move_it_by_lines):
1867 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1868 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1869 (message_log_check_duplicate): Remove parameters `prev_bol' and
1870 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1871 (redisplay_internal): Remove parameter `preserve_echo_area',
1872 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1873
1874 * indent.c (Fvertical_motion):
1875 * window.c (window_scroll_pixel_based, Frecenter):
1876 Don't pass `need_y_p' to `move_it_by_lines'.
1877
1c470562
SM
18782011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1879
44f230aa
SM
1880 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1881 steal a few bits to be more compact.
1882 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1883 Remove unneeded casts.
1884
1c470562
SM
1885 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1886
888adce9
ZK
18872011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1888
1889 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1890 binding" message (bug#7967).
1891
f838ed7b
PE
18922011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1893
77861b95
PE
1894 Fix more problems found by GCC 4.6.0's static checks.
1895
de6dbc14
PE
1896 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1897 Remove unused local var.
1898
f838ed7b
PE
1899 * editfns.c (Fmessage_box): Remove unused local var.
1900
792c7b2b
PE
1901 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1902 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1903 Omit unused local vars.
c499e557 1904 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1905 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1906 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1907 Omit unused local var.
1908
ba0165e1
PE
1909 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1910 Don't assume string length fits in int.
32ad8845 1911 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1912 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1913
3c59b4c9
PE
1914 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1915 instead of alloca (Bug#8344).
1916
a3eed478 1917 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1918 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1919
eb4d412d
PE
1920 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1921
1658b401
PE
1922 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1923 concerns.
1924
1925 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1926
1927 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1928
9a2c6e05
PE
1929 * keyboard.c (syms_of_keyboard): Use the same style as later
1930 in this function when indexing through an array. This also
1931 works around GCC bug 48267.
1932
03d0a109
PE
1933 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1934
44f730c8
PE
1935 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1936
fe75f926
PE
1937 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1938 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1939
ffa8c828
PE
1940 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1941 This avoids undefined behavior on integer overflow, and is a bit
1942 more convenient anyway since it is compared to a size_t variable.
1943
c5101a77
PE
1944 Variadic C functions now count arguments with size_t, not int.
1945 This avoids an unnecessary limitation on 64-bit machines, which
1946 caused (substring ...) to crash on large vectors (Bug#8344).
1947 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1948 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1949 All variadic functions and their callers changed accordingly.
c5101a77
PE
1950 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1951 * data.c (arith_driver, float_arith_driver): Likewise.
1952 * editfns.c (general_insert_function): Likewise.
1953 * eval.c (struct backtrace.nargs, interactive_p)
1954 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1955 (funcall_lambda, mark_backtrace): Likewise.
1956 * fns.c (concat): Likewise.
1957 * frame.c (x_set_frame_parameters): Likewise.
1958 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1959 0 if not found, not -1. All callers changed.
1960
dd3f25f7
PE
1961 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1962 (stack_copy_size): Now size_t, not int.
1963 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1964
461c2ab9
JB
19652011-03-28 Juanma Barranquero <lekktu@gmail.com>
1966
1967 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1968 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1969 All callers changed.
1970
1971 * lisp.h (multibyte_char_to_unibyte):
1972 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1973 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1974 * character.h (CHAR_TO_BYTE8):
1975 * cmds.c (internal_self_insert):
1976 * editfns.c (general_insert_function):
1977 * keymap.c (push_key_description):
1978 * search.c (Freplace_match):
1979 * xdisp.c (message_dolog, set_message_1): All callers changed.
1980
f6d62986
SM
19812011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1982
1983 * keyboard.c (safe_run_hook_funcall): New function.
1984 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1985 don't set the hook to nil, but remove the offending function instead.
1986 (Qcommand_hook_internal): Remove, unused.
1987 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1988 Vcommand_hook_internal.
1989
1990 * eval.c (enum run_hooks_condition): Remove.
1991 (funcall_nil, funcall_not): New functions.
1992 (run_hook_with_args): Call each function through a `funcall' argument.
1993 Remove `cond' argument, now redundant.
1994 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1995 (Frun_hook_with_args_until_failure): Adjust accordingly.
1996 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1997
1db5b1ad
JB
19982011-03-28 Juanma Barranquero <lekktu@gmail.com>
1999
2000 * dispextern.h (string_buffer_position): Remove declaration.
2001
2002 * print.c (strout): Remove parameter `multibyte', unused since
2003 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2004
2005 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2006 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2007 All callers changed.
2008
2009 * w32.c (_wsa_errlist): Use braces for struct initializers.
2010
2011 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2012 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2013 All callers changed.
2014 (string_buffer_position): Likewise. Also, make static (it's never
2015 used outside xdisp.c).
2016 (cursor_row_p): Remove parameter `w', unused since
2017 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2018 (decode_mode_spec): Remove parameter `precision', introduced during
2019 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2020 All callers changed.
2021
5ffb62aa
JD
20222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2023
2024 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2025
461c2ab9 20262011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2027
2028 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2029 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2030 (ns_update_auto_hide_menu_bar): New functions.
2031 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2032 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2033 ns_constrain_all_frames.
2034 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2035 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2036
5c380ffb
JD
20372011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2038
2039 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2040
9af30bdf
GM
20412011-03-27 Glenn Morris <rgm@gnu.org>
2042
2043 * syssignal.h: Replace RETSIGTYPE with void.
2044 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2045 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2046 Replace SIGTYPE with void everywhere.
2047 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2048 * s/template.h (SIGTYPE): Remove commented out definition.
2049
e2abce01
JB
20502011-03-26 Eli Zaretskii <eliz@gnu.org>
2051
2052 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2053 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2054
f868cd8a
JB
20552011-03-26 Juanma Barranquero <lekktu@gmail.com>
2056
59eb0929
JB
2057 * w32.c (read_unc_volume): Use parameter `henum', instead of
2058 global variable `wget_enum_handle'.
2059
2060 * keymap.c (describe_vector): Remove parameters `indices' and
2061 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2062 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2063
f868cd8a
JB
2064 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2065
2066 * keyboard.c (timer_check): Remove parameter `do_it_now',
2067 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2068 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2069 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2070
2071 * keyboard.c (read_char):
2072 * w32menu.c (w32_menu_display_help):
2073 * xmenu.c (show_help_event, menu_help_callback):
2074 Adjust calls to `show_help_echo'.
2075
2076 * gtkutil.c (xg_maybe_add_timer):
2077 * keyboard.c (readable_events):
2078 * process.c (wait_reading_process_output):
2079 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2080
2081 * insdel.c (adjust_markers_gap_motion):
2082 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2083 (gap_left, gap_right): Don't call it.
2084
2ecf6fdb
CY
20852011-03-25 Chong Yidong <cyd@stupidchicken.com>
2086
2087 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2088 incurred during fontification.
2089
6b1f9ba4
JB
20902011-03-25 Juanma Barranquero <lekktu@gmail.com>
2091
2092 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2093 (DEFVAR_PER_BUFFER): Don't pass it.
2094
2095 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2096 (scrolling_window): Don't pass it.
2097
0f4a96b5
JB
20982011-03-25 Juanma Barranquero <lekktu@gmail.com>
2099
2100 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2101
2102 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2103 and `suffix'.
2104 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2105 of variables specific to SELinux and computation of `encoded_absname'.
2106
2107 * image.c (XPutPixel): Remove unused variable `height'.
2108
2109 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2110
2111 * unexw32.c (get_section_info): Remove unused variable `section'.
2112
2113 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2114 (system_process_attributes): Remove unused variable `sess'.
2115 (sys_read): Remove unused variable `err'.
2116
2117 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2118 (w32_wnd_proc): Remove unused variable `isdead'.
2119 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2120 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2121 (x_create_tip_frame): Remove unused variable `tem'.
2122
2123 * w32inevt.c (w32_console_read_socket):
2124 Remove unused variable `no_events'.
2125
2126 * w32term.c (x_draw_composite_glyph_string_foreground):
2127 Remove unused variable `width'.
2128
1149507c
JB
21292011-03-24 Juanma Barranquero <lekktu@gmail.com>
2130
2131 * w32term.c (x_set_glyph_string_clipping):
2132 Don't pass uninitialized region to CombineRgn.
2133
9c88f339
JB
21342011-03-23 Juanma Barranquero <lekktu@gmail.com>
2135
2136 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2137 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2138 (Fx_close_connection): Remove unused variable `i'.
2139
2140 * w32font.c (w32font_draw): Return number of glyphs.
2141 (w32font_open_internal): Remove unused variable `i'.
2142 (w32font_driver): Add missing initializer.
2143
2144 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2145 (fill_in_menu): Remove unused variable `items_added'.
2146
2147 * w32term.c (last_mouse_press_frame): Remove static global variable.
2148 (w32_clip_to_row): Remove unused variable `f'.
2149 (x_delete_terminal): Remove unused variable `i'.
2150
2151 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2152 (NOTHING): Remove unused static global variable.
2153 (uniscribe_check_otf): Remove unused variable `table'.
2154 (uniscribe_font_driver): Add missing initializers.
2155
dee091a3
JD
21562011-03-23 Julien Danjou <julien@danjou.info>
2157
2158 * term.c (Fsuspend_tty, Fresume_tty):
2159 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2160 * window.c (temp_output_buffer_show):
2161 * insdel.c (signal_before_change):
2162 * frame.c (Fhandle_switch_frame):
2163 * fileio.c (Fdo_auto_save):
2164 * emacs.c (Fkill_emacs):
2165 * editfns.c (save_excursion_restore):
2166 * cmds.c (internal_self_insert):
2167 * callint.c (Fcall_interactively):
2168 * buffer.c (Fkill_all_local_variables):
2169 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2170 Use Frun_hooks.
0f4a96b5 2171 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2172 unconditionnaly since it does the check itself.
2173
2c520ab5 21742011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2175
c9c49752
PE
2176 Fix more problems found by GCC 4.5.2's static checks.
2177
8abc3f12
PE
2178 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2179 the first time through the loop, since we know p0 < p1 then.
2180 This also avoids a gcc -Wstrict-overflow warning.
2181
a2d26660
PE
2182 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2183 leading to a memory leak, possible in functions like
2184 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2185 of objects (Bug#8318).
a2d26660 2186
916c72e9
PE
2187 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2188 that could (at least in theory) be that large.
2189
19ab8a18
PE
2190 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2191 This is less likely to overflow, and avoids undefined behavior if
2192 overflow does occur. All callers changed. Use strtoul to scan
2193 for the unsigned long integer.
b7cbbd6f
PE
2194 (pint2hrstr): Simplify and tune code slightly.
2195 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2196
f0641eff
PE
2197 * scroll.c (do_scrolling): Work around GCC bug 48228.
2198 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2199
7f650bb9
PE
2200 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2201 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2202 (validate_x_resource_name): Simplify count usage.
2203 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2204
37dd57d1
PE
2205 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2206 fail (Bug#8306).
81e56e61 2207
699979fc 2208 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2209
401bf9b4
PE
2210 * process.c (Fmake_network_process): Use socklen_t, not int,
2211 where POSIX says socklen_t is required in portable programs.
2212 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2213 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2214 (Fmake_network_process, server_accept_connection):
2215 (wait_reading_process_output, read_process_output):
2216 Likewise.
2217
b93aacde
PE
2218 * process.c: Rename or move locals to avoid shadowing.
2219 (list_processes_1, Fmake_network_process):
2220 (read_process_output_error_handler, exec_sentinel_error_handler):
2221 Rename or move locals.
4dc343ee 2222 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2223 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2224 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2225 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2226 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2227
af8a867c 2228 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2229 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2230 Include tparam.h instead, since it declares them.
af8a867c
PE
2231 * cm.h (PC): Remove extern decl; tparam.h now does this.
2232 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2233 * terminfo.c: Include tparam.h, to check interfaces.
2234 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2235 (tparam): Adjust signature to match interface in tparam.h;
2236 this removes some undefined behavior. Check that outstring and len
2237 are zero, which they always are with Emacs.
2238 * tparam.h (PC, BC, UP): New extern decls.
2239
0248044d 2240 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2241 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2242
8ff096c1 2243 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2244 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2245 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2246 (ftfont_list): Remove unused local.
49eaafba
PE
2247 (get_adstyle_property, ftfont_pattern_entity):
2248 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2249 Rename locals to avoid shadowing.
8ff096c1 2250
e2be39f6
PE
2251 * xfont.c (xfont_list_family): Mark var as initialized.
2252
c9735e30
PE
2253 * xml.c (make_dom): Now static.
2254
8f5201ae
PE
2255 * composite.c (composition_compute_stop_pos): Rename local to
2256 avoid shadowing.
b246f932
PE
2257 (composition_reseat_it): Remove unused locals.
2258 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2259 (composition_update_it): Mark var as initialized.
11b61122
PE
2260 (find_automatic_composition): Mark vars as initialized,
2261 with a FIXME (Bug#8290).
8f5201ae 2262
760fbc2c
PE
2263 character.h: Rename locals to avoid shadowing.
2264 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2265 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2266 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2267 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2268 to avoid shadowing.
2269
ff08eb85
PE
2270 * textprop.c (property_change_between_p): Remove; unused.
2271
fc7bf025
PE
2272 * intervals.c (interval_start_pos): Now static.
2273
235d7abc
PE
2274 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2275
44f230aa
SM
2276 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2277 Rename locals to avoid shadowing.
3e7d6594 2278
50060332
PE
2279 * sound.c (wav_play, au_play, Fplay_sound_internal):
2280 Fix pointer signedness.
d01f234b 2281 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2282 (wav_play): Initialize a variable to 0, to prevent undefined
2283 behavior (Bug#8278).
50060332 2284
c4fc4e30
PE
2285 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2286
918436ed
PE
2287 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2288
c939f91b
PE
2289 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2290 clobbering (Bug#8298).
b9c7f648
PE
2291 * sysdep.c (sys_subshell): Likewise.
2292 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2293
6bd8c144
PE
2294 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2295 This should get cleaned up, so that child_setup has the
2296 same signature on all platforms.
2297
7710357c 2298 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2299 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2300
c59da222
CY
23012011-03-22 Chong Yidong <cyd@stupidchicken.com>
2302
2303 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2304 not to be necessary, and produces flickering.
2305
66b87493
GM
23062011-03-20 Glenn Morris <rgm@gnu.org>
2307
2308 * config.in: Remove file.
2309
45b6f6d5
JB
23102011-03-20 Juanma Barranquero <lekktu@gmail.com>
2311
2312 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2313 are now in src/globals.h.
2314 (syms_of_minibuf): Remove spurious & from previous change.
2315
3ec03f7e
LL
23162011-03-20 Leo <sdl.web@gmail.com>
2317
2318 * minibuf.c (completing-read-function): New variable.
2319 (completing-read-default): Rename from completing-read.
2320 (completing-read): Call completing-read-function.
2321
b14e3e21
CY
23222011-03-19 Juanma Barranquero <lekktu@gmail.com>
2323
2324 * xfaces.c (Fx_load_color_file):
2325 Read color file from absolute filename (bug#8250).
2326
f2b726e6
JB
23272011-03-19 Juanma Barranquero <lekktu@gmail.com>
2328
2329 * makefile.w32-in: Update dependencies.
2330
09f6ff02
EZ
23312011-03-17 Eli Zaretskii <eliz@gnu.org>
2332
2333 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2334
29a6015a
PE
23352011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2336
a3a6c54e
PE
2337 Fix more problems found by GCC 4.5.2's static checks.
2338
b766f867
PE
2339 * process.c (make_serial_process_unwind, send_process_trap):
2340 (sigchld_handler): Now static.
2341
be02381c
PE
2342 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2343 That way, the code declares only the vars that it needs.
2344 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2345 * s/cygwin.h (PTY_ITERATION): Likewise.
2346 * s/darwin.h (PTY_ITERATION): Likewise.
2347 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2348
57048744
PE
2349 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2350 * process.c (allocate_pty): Don't declare stb unless it's needed.
2351
7914961c 2352 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2353 (CONSTANTLIM): Remove; unused.
2354 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2355 Define only if needed.
7914961c 2356
b3967b18
PE
2357 * unexelf.c (unexec): Name an expression,
2358 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2359 Use a different way to cause a compilation error if anyone uses
2360 n rather than nn, a way that does not involve shadowing.
73366a00 2361 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2362
29a6015a
PE
2363 * deps.mk (unexalpha.o): Remove; unused.
2364
43cfc33e 2365 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2366 * unexec.h: New file.
ce701a33
PE
2367 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2368 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2369 Depend on unexec.h.
2370 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2371 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2372 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2373 Change as necessary to match prototype in unexec.h.
ce701a33 2374
01f44d5a
PE
2375 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2376 shadowing.
4f63c6bb 2377 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2378
a6670b0b
PE
2379 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2380 Rename locals to avoid shadowing.
2381
cef2010d 2382 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2383 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2384
d4d7173a
PE
2385 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2386
f08b802a
PE
2387 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2388 warning when compiling print.c.
2389
3ddb0639
PE
2390 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2391 instead of using an uninitialized var.
5ad03b97 2392 (font_sort_entities): Mark var as initialized.
3ddb0639 2393
170a2692
PE
2394 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2395
e663c700
PE
2396 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2397 pointers to constants.
89bc529a 2398 (font_parse_fcname): Remove unused vars.
7b81e2d0 2399 (font_delete_unmatched): Now static.
ea838e10 2400 (font_get_spec): Remove; unused.
13a547c6
PE
2401 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2402 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2403 Rename or move locals to avoid shadowing.
e663c700 2404
2a80c887 2405 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2406 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2407
1384fa33 2408 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2409 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2410
8b2c52e9
PE
2411 * alloc.c (mark_backtrace): Move decl from here ...
2412 * lisp.h: ... to here, so that it can be checked.
2413
475545b5 2414 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2415 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2416 (lisp_indirect_variable): Name an expression,
2417 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2418 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2419
b1349114 2420 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2421 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2422 Use const pointer when appropriate.
b1349114 2423
a2928364
PE
2424 * lisp.h (get_system_name, get_operating_system_release):
2425 Move decls here, to check interfaces.
2426 * process.c (get_operating_system_release): Move decl to lisp.h.
2427 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2428 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2429 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2430 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2431 (Fformat_time_string, Fencode_time, Finsert_char):
2432 (Ftranslate_region_internal, Fformat):
2433 Rename or remove local vars to avoid shadowing.
9710023e 2434 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2435
a415e694
PE
2436 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2437 avoid shadowing.
2438
8ef4622d
PE
2439 * lisp.h (eassert): Check that the argument compiles, even if
2440 ENABLE_CHECKING is not defined.
2441
946f9a5b
PE
2442 * data.c (Findirect_variable): Name an expression, to avoid
2443 gcc -Wbad-function-cast warning.
112396d6 2444 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2445 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2446 (Fmake_variable_buffer_local, Fmake_local_variable):
2447 Mark variables as initialized.
52746918 2448 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2449
e5aab7e7 2450 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2451 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2452 Rename locals to avoid shadowing.
dff45157
PE
2453 (mark_stack): Move local variables into the #ifdef region where
2454 they're used.
7bc26fdb
PE
2455 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2456 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2457 needed otherwise.
2458 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2459 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2460 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2461
e5aab7e7
PE
2462 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2463 avoids undefined behavior in theory.
2464
4da60324
PE
2465 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2466
88043301
PE
2467 Use functions, not macros, for up- and down-casing (Bug#8254).
2468 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2469 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2470 to use the following functions instead of these macros.
2471 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2472 EMACS_INT, since callers assume the returned value fits in int.
2473 (upcase1): Likewise, for UPCASE_TABLE.
2474 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2475 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2476 the race-condition problem in the old DOWNCASE.
88043301 2477
19ed5445
PE
2478 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2479 Rename locals to avoid shadowing.
2480 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2481 (regex_compile, re_search_2, re_match_2_internal):
2482 Remove unused local vars.
952db0d7
PE
2483 (FREE_VAR): Rewrite so as not to use empty "else",
2484 which gcc can warn about.
da053e48 2485 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2486 (RETALLOC_IF): Define only if needed.
2487 (WORDCHAR_P): Likewise. This one is never needed, but is used
2488 only in a comment talking about a compiler bug, so put inside
2489 the #if 0 of that comment.
2490 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2491 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2492 Remove; unused.
19ed5445 2493
1f3561e4 2494 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2495 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2496 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2497
ded6f8f7
PE
2498 * search.c (simple_search): Remove unused var.
2499
dbd37a95
PE
2500 * dired.c (compile_pattern): Move decl from here ...
2501 * lisp.h: ... to here, so that it can be checked.
2502 (struct re_registers): New forward decl.
2503
7e47afad
PE
2504 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2505
85f24f61
PE
2506 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2507 All uses changed.
2508 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2509 Rename locals to avoid shadowing.
5671df8f 2510 (Fvertical_motion): Mark locals as initialized.
85f24f61 2511
181aa2be 2512 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2513 (casify_region): Mark local as initialized.
181aa2be 2514
930d429c
PE
2515 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2516
7082eac6
PE
2517 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2518 New macros, so that the caller can use some names other than
2519 gcpro1, gcpro2, etc.
2520 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2521 of the new macros.
2522 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2523 argument, for consistency with GCPRO2_VAR, etc: it is now the
2524 prefix of the variable, not the variable itself. All uses
2525 changed.
38b2c076
PE
2526 * dired.c (directory_files_internal, file_name_completion):
2527 Rename locals to avoid shadowing.
2528
15206ed9
PE
2529 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2530 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2531 dired.c's scmp function, had undefined behavior.
2532 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2533 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2534 * buffer.h: ... to here, because these macros use current_buffer,
2535 and the new implementation with inline functions needs to have
2536 current_buffer in scope now, rather than later when the macros
2537 are used.
2538 (downcase, upcase1): New static inline functions.
2539 (DOWNCASE, UPCASE1): Reimplement using these functions.
2540 This avoids undefined behavior in expressions like
2541 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2542 from race conditions in accessing the global variables
2543 case_temp1 and case_temp2.
2544 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2545 * lisp.h (case_temp1, case_temp2): Remove their decls.
2546 * character.h (ASCII_CHAR_P): Move from here ...
2547 * lisp.h: ... to here, so that the inline functions mentioned
2548 above can use them.
2549
4a6bea26
PE
2550 * dired.c (directory_files_internal_unwind): Now static.
2551
f14b7e14
PE
2552 * fileio.c (file_name_as_directory, directory_file_name):
2553 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2554 Now static.
2893f146
PE
2555 (file_name_as_directory): Use const pointers when appropriate.
2556 (Fexpand_file_name): Likewise. In particular, newdir might
2557 point at constant storage, so make it a const pointer.
fd4ead52 2558 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2559 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2560 signedness issues.
f839df0c
PE
2561 (Fset_file_times, Finsert_file_contents, auto_save_error):
2562 Rename locals to avoid shadowing.
f14b7e14 2563
5716756e 2564 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2565 (Ftry_completion, Fall_completions): Rename or remove locals
2566 to avoid shadowing.
5716756e 2567
b4c3046a
PE
2568 * marker.c (bytepos_to_charpos): Remove; unused.
2569
b45db522
PE
2570 * lisp.h (verify_bytepos, count_markers): New decls,
2571 so that gcc does not warn that these functions aren't declared.
2572
85876d07
PE
2573 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2574 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2575 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2576 (copy_text): Remove unused local var.
85876d07 2577
03d78a21 2578 * filelock.c (within_one_second): Now static.
b3dd38ab 2579 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2580
5df8f01b
PE
2581 * buffer.c (fix_overlays_before): Mark locals as initialized.
2582 (fix_start_end_in_overlays): Likewise. This function should be
2583 simplified by using pointers-to-pointers, but that's a different
2584 matter.
b1d876f1 2585 (switch_to_buffer_1): Now static.
8f54f30a
PE
2586 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2587 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2588
a70072c9 2589 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2590 Fix pointer signedness issue.
edced198
PE
2591 (sys_subshell): Mark local as volatile if checking for lint,
2592 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2593 (MAXPATHLEN): Define only if needed.
a70072c9 2594
a0977c44
PE
2595 * process.c (serial_open, serial_configure): Move decls from here ...
2596 * systty.h: ... to here, so that they can be checked.
2597
a884fdcc
PE
2598 * fns.c (get_random, seed_random): Move extern decls from here ...
2599 * lisp.h: ... to here, so that they can be checked.
2600
604efe86 2601 * sysdep.c (reset_io): Now static.
b8950c94 2602 (wait_for_termination_signal): Remove; unused.
604efe86 2603
38fc62d9
PE
2604 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2605 (copy_keymap_item, append_key, push_text_char_description):
2606 Now static.
1004a21a 2607 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2608 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2609 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2610 (describe_map_tree):
2611 Rename locals to avoid shadowing.
38fc62d9 2612
2f2650da
PE
2613 * keyboard.c: Declare functions static if they are not used elsewhere.
2614 (echo_char, echo_dash, cmd_error, top_level_2):
2615 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2616 (read_char, kbd_buffer_get_event, make_lispy_position):
2617 (make_lispy_event, make_lispy_movement, apply_modifiers):
2618 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2619 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2620 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2621 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2622 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2623
a053e86c 2624 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2625 (mark_kboards): Move decl here ...
2626 * alloc.c (mark_kboards): ... from here.
a053e86c 2627
4752793e
PE
2628 * lisp.h (force_auto_save_soon): New decl.
2629
74f10ca7 2630 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2631 (DEFINE_DUMMY_FUNCTION): New macro.
2632 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2633 Use it.
c03cd23f
PE
2634 (main): Add casts to avoid warnings
2635 if GCC considers string literals to be constants.
74f10ca7 2636
022e70d4
PE
2637 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2638
59d6fe83
PE
2639 * dbusbind.c: Pointer signedness fixes.
2640 (xd_signature, xd_append_arg, xd_initialize):
2641 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2642 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2643 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2644 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2645
78320123
PE
2646 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2647 if GCC considers string literals to be constants.
49cebcca 2648 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2649
35ac2a97
SM
26502011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2651
fb103ca9
SM
2652 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2653 (print_preprocess, print_object): New macro to fix last change.
2654
35ac2a97
SM
2655 * print.c (print_preprocess): Don't forget font objects.
2656
62973b41
JB
26572011-03-16 Juanma Barranquero <lekktu@gmail.com>
2658
2659 * emacs.c (USAGE3): Doc fixes.
2660
0e48bb22
AS
26612011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2662
2663 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2664 structure.
2665
7684e57b
JB
26662011-03-14 Juanma Barranquero <lekktu@gmail.com>
2667
2668 * lisp.h (VWindow_system, Qfile_name_history):
2669 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2670 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2671 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2672
2673 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2674 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2675
2676 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2677 * w32console.c (detect_input_pending, read_input_pending)
2678 (encode_terminal_code):
2679 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2680 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2681 (w32_system_caret_y, Qfile_name_history):
2682 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2683 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2684 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2685 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2686 * w32proc.c (Qlocal, report_file_error):
2687 * w32term.c (Vwindow_system, updating_frame):
2688 * w32uniscribe.c (initialized, uniscribe_font_driver):
2689 Remove unneeded extern declarations.
2690
2aa46d6c
CY
26912011-03-14 Chong Yidong <cyd@stupidchicken.com>
2692
c96bbc66 2693 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2694
cffc6f3b
CY
26952011-03-13 Chong Yidong <cyd@stupidchicken.com>
2696
2697 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2698 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2699 These macros can no longer be used for assignment.
2700
44f230aa
SM
2701 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2702 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2703 (record_buffer_markers, fetch_buffer_markers): New functions for
2704 recording and fetching special buffer markers.
2705 (set_buffer_internal_1, set_buffer_temp): Use them.
2706
2707 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2708
2709 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2710
2711 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2712 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2713
2714 * xdisp.c (hscroll_window_tree):
2715 (reconsider_clip_changes): Use PT instead of BUF_PT.
2716
d251f04b
EZ
27172011-03-13 Eli Zaretskii <eliz@gnu.org>
2718
2719 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2720 $(EMACS_ROOT)/lib/intprops.h.
2721
f0c77cd1
PE
27222011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2723
3eca4629
PE
2724 Fix more problems found by GCC 4.5.2's static checks.
2725
7c86ee98
PE
2726 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2727 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2728 (xg_free_frame_widgets): Make it clear that a local variable is
2729 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2730 (gdk_window_get_screen): Make it clear that this macro is needed
2731 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2732 (int_gtk_range_get_value): New function, which avoids a diagnostic
2733 from gcc -Wbad-function-cast.
2734 (xg_set_toolkit_scroll_bar_thumb): Use it.
2735 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2736 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2737 (get_utf8_string, xg_get_file_with_chooser):
2738 Rename locals to avoid shadowing.
2739 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2740
41729b81
PE
2741 * xgselect.c (xg_select): Remove unused var.
2742
f0c77cd1
PE
2743 * image.c (four_corners_best): Mark locals as initialized.
2744 (gif_load): Initialize transparent_p to zero (Bug#8238).
2745 Mark another local as initialized.
ec6cf4c6 2746 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2747
ce0ad53d 2748 * image.c (clear_image_cache): Now static.
d5d5a617 2749 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2750 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2751 (x_edge_detection): Remove unnecessary cast that
2752 gcc -Wbad-function-cast diagnoses.
2037898d 2753 (gif_load): Fix pointer signedness.
6ae141d6
PE
2754 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2755 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2756
33383987 27572011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2758
d32df629
PE
2759 Improve quality of tests for time stamp overflow.
2760 For example, without this patch (encode-time 0 0 0 1 1
2761 1152921504606846976) returns the obviously-bogus value (-948597
2762 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2763 reports time overflow. See
2764 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2765 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2766 * editfns.c: Include limits.h and intprops.h.
2767 (TIME_T_MIN, TIME_T_MAX): New macros.
2768 (time_overflow): Move earlier, to before first use.
2769 (hi_time, lo_time): New functions, for an accurate test for
2770 out-of-range times.
2771 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2772 (Fget_internal_run_time): Don't assume time_t fits in int.
2773 (make_time): Use list2 instead of Fcons twice.
2774 (Fdecode_time): More accurate test for out-of-range times.
2775 (check_tm_member): New function.
2776 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2777 (lisp_time_argument): Don't rely on undefined left-shift and
2778 right-shift behavior when checking for time stamp overflow.
8be6f318 2779
fe31d94c
PE
2780 * editfns.c (time_overflow): New function, refactoring common code.
2781 (Fformat_time_string, Fdecode_time, Fencode_time):
2782 (Fcurrent_time_string): Use it.
2783
8be6f318
PE
2784 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2785 * dired.c (make_time): Move to ...
2786 * editfns.c (make_time): ... here.
2787 * systime.h: Note the move.
2788
09d9db2c 27892011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2790
126bc0dc
YM
2791 * fringe.c (update_window_fringes): Remove unused variables.
2792
c47cbdfd
YM
2793 * unexmacosx.c (copy_data_segment): Also copy __got section.
2794 (Bug#8223)
2795
7ac80be9
EZ
27962011-03-12 Eli Zaretskii <eliz@gnu.org>
2797
c96bbc66 2798 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2799 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2800 Constify `char *' arguments and their references according to
2801 prototypes in tparam.h.
2802
ecb0f94d 2803 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2804
7ac80be9
EZ
2805 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2806 Adapt all references accordingly.
2807
2808 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2809
ef1fd07e
TT
28102011-03-11 Tom Tromey <tromey@redhat.com>
2811
2812 * buffer.c (syms_of_buffer): Remove obsolete comment.
2813
7ef4b50c
EZ
28142011-03-11 Eli Zaretskii <eliz@gnu.org>
2815
2816 * termhooks.h (encode_terminal_code): Declare prototype.
2817
2818 * msdos.c (encode_terminal_code): Don't declare prototype.
2819
2820 * term.c (encode_terminal_code): Now external again, used by
2821 w32console.c and msdos.c.
2822
44f230aa
SM
2823 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2824 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2825
4b1ec863 28262011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2827
1714f52b 2828 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2829
4b1ec863
PE
2830 * fringe.c (update_window_fringes): Mark locals as initialized
2831 (Bug#8227).
2832 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2833
524c7aa6
PE
2834 * alloc.c (mark_fringe_data): Move decl from here ...
2835 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2836 to check its interface.
2837 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2838
a5c0af81 2839 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2840 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2841 (fontset_font): Mark local as initialized.
a9a06e0b 2842 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2843
b4716021
PE
2844 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2845
811e9bac 2846 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2847 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2848 (x_own_selection, Fx_disown_selection_internal): Rename locals
2849 to avoid shadowing.
2850 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2851
7e3ab302
PE
2852 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2853 so that the caller can use some name other than gcpro1.
2854 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2855 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2856 (Fx_backspace_delete_keys_p):
2857 Use them to avoid shadowing, and rename vars to avoid shadowing.
2858 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2859 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2860 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2861 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2862 Remove unused locals.
7e3ab302
PE
2863 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2864 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2865 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2866 macros.
f78faa98 2867
e2b13473
PE
2868 * xterm.h (x_mouse_leave): New decl.
2869
77f23912
PE
2870 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2871 Remove unused functions.
cdf4ba58
PE
2872 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2873 (x_calc_absolute_position): Now static.
7411c686 2874 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2875 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2876 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2877 unless they are used.
38d0b34a
PE
2878 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2879 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2880 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2881 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2882 (x_error_catcher, x_connection_closed, x_error_handler):
2883 (x_error_quitter, xembed_send_message, x_iconify_frame):
2884 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2885 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2886 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2887
44f230aa
SM
2888 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2889 Rename or move locals to avoid shadowing.
6b463e58 2890 (tty_defined_color, merge_face_heights): Now static.
5967d051 2891 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2892 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2893 does not deduce is never used uninitialized.
73719eba
PE
2894 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2895 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2896
426994c3 2897 * terminal.c (store_terminal_param): Now static.
5489860b 2898
032f1620 2899 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2900 (set_frame_menubar): Remove unused local.
d4323972 2901 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2902 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2903 since they might point to immutable storage.
281585b0
PE
2904 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2905 since it's unused otherwise.
032f1620 2906
367c19e5 2907 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2908 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2909 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2910 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2911 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2912 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2913 does not deduce are never used uninitialized.
70739cbe 2914
07b48fa9
PE
2915 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2916
8868a238 2917 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2918 * window.c (window_loop, size_window):
2919 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2920
7e5cf297 2921 * window.c (display_buffer): Now static.
d6550a9f
PE
2922 (size_window): Mark variables that gcc -Wuninitialized
2923 does not deduce are never used uninitialized.
a586633d
PE
2924 * window.h (check_all_windows): New decl, to forestall
2925 gcc -Wmissing-prototypes diagnostic.
5b555da1 2926 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2927
f6095868
PE
2928 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2929 shadowing.
2930 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2931 Include <limits.h>.
2932 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2933 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2934 (load_charset_map): Mark variables that gcc -Wuninitialized
2935 does not deduce are never used uninitialized.
53df7c11 2936 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2937
f38b440c
PE
2938 * coding.c (coding_set_source, coding_set_destination):
2939 Use "else { /* comment */ }" rather than "else /* comment */;"
2940 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2941 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2942 a block, when the outer 'i' will do.
2943 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2944 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2945 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2946 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2947 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2948 Rename locals to avoid shadowing.
2949 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2950 * coding.c (emacs_mule_char, encode_invocation_designation):
2951 Now static, since they're not used elsewhere.
413bb2db 2952 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2953 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2954 (decode_coding_emacs_mule): Mark variables that gcc
2955 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2956 (detect_coding_iso_2022): Initialize a local variable that might
2957 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2958 this initialization is needed. (Bug#8211)
5f58e762
PE
2959 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2960 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2961 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2962 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2963 Remove unused macros.
f38b440c 2964
232b38b9 2965 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2966 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2967 * character.c (string_count_byte8): Likewise.
232b38b9 2968
fb90da1b
PE
2969 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2970 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2971
fb93dbc2
PE
2972 * chartab.c (copy_sub_char_table): Now static, since it's not used
2973 elsewhere.
5c156ace
PE
2974 (sub_char_table_ref_and_range, char_table_ref_and_range):
2975 Rename locals to avoid shadowing.
bbcd0949 2976 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2977
7d3b3862 2978 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2979 (BIDI_BOB): Remove unused macro.
7d3b3862 2980
6be7d3da
PE
2981 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2982 deduce are never used uninitialized.
c2ed9c8b 2983 * term.c (encode_terminal_code): Likewise.
6be7d3da 2984
75f8807f 2985 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2986
50938595
PE
2987 * tparam.h: New file.
2988 * term.c, tparam.h: Include it.
2989 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2990 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2991 Move these decls to tparam.h, and make them agree with what
2992 is actually in tparam.c. The previous trick of using incompatible
2993 decls in different modules does not conform to the C standard.
2994 All callers of tparam changed to use tparam's actual API.
2995 * tparam.c (tparam1, tparam, tgoto):
2996 Use const pointers where appropriate.
2997
fbceeba2
PE
2998 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2999 * cm.h (struct cm): Likewise.
3000 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3001 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3002 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3003 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3004 (turn_on_face, init_tty): Likewise.
3005 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3006
7f3f1250
PE
3007 * term.c (term_mouse_position): Rename local to avoid shadowing.
3008
e6ca6543
PE
3009 * alloc.c (mark_ttys): Move decl from here ...
3010 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3011
c40f8d15
AS
30122011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3013
3014 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3015
cfe0661d
JB
30162011-03-09 Juanma Barranquero <lekktu@gmail.com>
3017
3018 * search.c (compile_pattern_1): Remove argument regp, unused since
3019 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3020 (compile_pattern): Don't pass it.
3021
0afb4571
J
30222011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3023
3024 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3025 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3026 for ! HAVE_GTK3.
3027 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3028
3029 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3030
3031 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3032 gdk_window_get_screen, gdk_window_get_geometry,
3033 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3034 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3035 (xg_get_pixbuf_from_pixmap): New function.
3036 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3037 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3038 Call xg_get_pixbuf_from_pixmap instead of
3039 gdk_pixbuf_get_from_drawable.
3040 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3041 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3042 (xg_check_special_colors): Use GtkStyleContext and its functions
3043 for HAVE_GTK3.
3044 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3045 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3046 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3047 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3048 Call gtk_widget_get_preferred_size.
0afb4571
J
3049 (xg_frame_resized): gdk_window_get_geometry only takes 5
3050 parameters.
44f230aa
SM
3051 (xg_win_to_widget, xg_event_is_for_menubar):
3052 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3053 (xg_set_widget_bg): New function.
3054 (delete_cb): New function.
895009e1 3055 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3056 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3057 (xg_set_background_color): Call xg_set_widget_bg.
3058 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3059 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3060 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3061 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3062 if ! HAVE_GTK3.
3063 (update_frame_tool_bar): Call gtk_widget_hide.
3064 (xg_initialize): Use GDK_KEY_g.
3065
3066 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3067 if ! HAVE_GTK3
3068 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3069
3070 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3071 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3072 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3073
1c2cc4ef
JB
30742011-03-08 Juanma Barranquero <lekktu@gmail.com>
3075
3076 * w32xfns.c (select_palette): Check success of RealizePalette against
3077 GDI_ERROR, not zero.
3078
33383987 3079See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3080
3081;; Local Variables:
3082;; coding: utf-8
aac0c6e3
MR
3083;; End:
3084
33383987 3085 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3086
3087 This file is part of GNU Emacs.
3088
3089 GNU Emacs is free software: you can redistribute it and/or modify
3090 it under the terms of the GNU General Public License as published by
3091 the Free Software Foundation, either version 3 of the License, or
3092 (at your option) any later version.
3093
3094 GNU Emacs is distributed in the hope that it will be useful,
3095 but WITHOUT ANY WARRANTY; without even the implied warranty of
3096 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3097 GNU General Public License for more details.
3098
3099 You should have received a copy of the GNU General Public License
3100 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.