Sync with Tramp 2.2.6-pre.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
23f86fce
DA
12012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Cleanup xmalloc.
4 * lisp.h (xzalloc): New prototype. Omit needless casts.
5 * alloc.c (xzalloc): New function. Omit needless casts.
6 * charset.c: Omit needless casts. Convert all calls to
7 xmalloc with following memset to xzalloc.
8 * dispnew.c: Likewise.
9 * fringe.c: Likewise.
10 * image.c: Likewise.
11 * sound.c: Likewise.
12 * term.c: Likewise.
13 * w32fns.c: Likewise.
14 * w32font.c: Likewise.
15 * w32term.c: Likewise.
16 * xfaces.c: Likewise.
17 * xfns.c: Likewise.
18 * xterm.c: Likewise.
19 * atimer.c: Omit needless casts.
20 * buffer.c: Likewise.
21 * callproc.c: Likewise.
22 * ccl.c: Likewise.
23 * coding.c: Likewise.
24 * composite.c: Likewise.
25 * doc.c: Likewise.
26 * doprnt.c: Likewise.
27 * editfns.c: Likewise.
28 * emacs.c: Likewise.
29 * eval.c: Likewise.
30 * filelock.c: Likewise.
31 * fns.c: Likewise.
32 * gtkutil.c: Likewise.
33 * keyboard.c: Likewise.
34 * lisp.h: Likewise.
35 * lread.c: Likewise.
36 * minibuf.c: Likewise.
37 * msdos.c: Likewise.
38 * print.c: Likewise.
39 * process.c: Likewise.
40 * region-cache.c: Likewise.
41 * search.c: Likewise.
42 * sysdep.c: Likewise.
43 * termcap.c: Likewise.
44 * terminal.c: Likewise.
45 * tparam.c: Likewise.
46 * w16select.c: Likewise.
47 * w32.c: Likewise.
48 * w32reg.c: Likewise.
49 * w32select.c: Likewise.
50 * w32uniscribe.c: Likewise.
51 * widget.c: Likewise.
52 * xdisp.c: Likewise.
53 * xmenu.c: Likewise.
54 * xrdb.c: Likewise.
55 * xselect.c: Likewise.
56
0497dc44
PE
572012-07-05 Paul Eggert <eggert@cs.ucla.edu>
58
59 * fileio.c (time_error_value): Check the right error number.
60 Problem reported by Troels Nielsen in
61 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
62
356e7178
PE
632012-07-04 Paul Eggert <eggert@cs.ucla.edu>
64
4e71fd89
PE
65 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
66 This should be fixed in a better way; see Eli Zaretskii in
67 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
68 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
69
f0941253
PE
70 * fileio.c (time_error_value): Rename from special_mtime.
71 The old name's problems were noted by Eli Zaretskii in
72 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
73
065c9eb4
PE
74 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
75 This variable's comment says Emacs needs at least one GDB-visible
76 symbol of type enum pvec_type, to work around GDB problems.
77 The symbol's value doesn't matter.
78
356e7178
PE
79 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
80 that causes compilation to fail on pre-C99 compilers.
81
95f61aa2
JB
822012-07-04 Juanma Barranquero <lekktu@gmail.com>
83
84 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
85 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
86
3884d954
DA
872012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
88
d209e2fb 89 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
90 headers for buffer_defaults and buffer_local_symbols.
91 Reported by Juanma Barranquero <lekktu@gmail.com>.
92
ee28be33
SM
932012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
94
95 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
96 * lisp.h (enum pvec_type): Use fewer bits.
97 (PSEUDOVECTOR_SIZE_BITS): New constant.
98 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
99 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
100 change in pvec_type.
101 (PSEUDOVECTOR_TYPEP): New macro.
102 (TYPED_PSEUDOVECTORP): Use it.
103 * fns.c (internal_equal): Adapt code to extract pvectype.
104 * emacs.c (gdb_pvec_type): Update type.
105 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
106 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
107 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
108 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
109 (sweep_vectors): Use it. Use local var `total_bytes' instead of
110 abusing vector->header.next.nbytes.
111 (live_vector_p): Use PVEC_TYPE.
112 (mark_object): Adapt code to extract pvectype. Use switch.
113
c7f2cd7f
PE
1142012-07-04 Paul Eggert <eggert@cs.ucla.edu>
115
116 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
117 Tighten new eassert a bit.
118
8ce70ed2
DA
1192012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
120
121 Fix compilation with --enable-gcc-warnings and -O1
122 optimization level.
123 * doprnt.c (doprnt): Change type of tem to int, initialize
124 to avoid compiler warning. Add eassert.
125 * search.c (simple_search): Initialize match_byte to avoid
126 compiler warning. Add eassert.
127
dea7f1e5
PE
1282012-07-04 Paul Eggert <eggert@cs.ucla.edu>
129
24a212eb
PE
130 Avoid weird behavior with large horizontal scrolls.
131 Without this change, for example, large hscroll values would
132 mess up Emacs's display on Fedora 15 x86, presumably due to
133 overflows in int calculations in the display code.
134 Also, if buffers had long lines, Emacs would freeze.
135 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
136 (set_window_hscroll): New function, containing the old guts of
137 Fset_window_hscroll. Return the clipped value.
138 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
139 This avoids the need to check against PTRDIFF_MAX.
140
dea7f1e5
PE
141 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
142
76046526
DA
1432012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
144
145 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
146
39adff0d
PE
1472012-07-04 Paul Eggert <eggert@cs.ucla.edu>
148
63807d47
PE
149 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
150 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
151 since GCC 4.4.6 issues a bogus warning for them.
152
39adff0d
PE
153 Fix bugs in file timestamp newness comparisons.
154 * fileio.c (Ffile_newer_than_file_p):
155 * lread.c (Fload): Use full timestamp resolution of files,
156 not just the 1-second resolution, so that files that are only
157 slightly newer still count as newer.
158 * fileio.c (Ffile_newer_than_file_p): Don't assume file
159 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
160
dbeed9a6
PE
1612012-07-03 Paul Eggert <eggert@cs.ucla.edu>
162
163 * fileio.c: Improve handling of file time marker. (Bug#11852)
164 (special_mtime): New function.
165 (Finsert_file_contents, Fverify_visited_file_modtime):
166 Use it to set special mtime values consistently.
167
636334d6
AS
1682012-07-03 Andreas Schwab <schwab@linux-m68k.org>
169
170 * fileio.c (Finsert_file_contents): Properly handle st_mtime
171 marker for non-existing file. (Bug#11852)
172
e2017fe2
GM
1732012-07-03 Glenn Morris <rgm@gnu.org>
174
175 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
176 and did not make it into globals.h).
177
404dbd37
TT
1782012-07-03 Tom Tromey <tromey@redhat.com>
179
180 * window.c (Fset_window_margins, Fset_window_fringes)
181 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
182 * textprop.c (Fprevious_property_change): No longer static.
183 * syntax.c (Fsyntax_table_p): No longer static.
184 * process.c (Fget_process, Fprocess_datagram_address): No longer
185 static.
186 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
187 * keyboard.c (Fcommand_execute): No longer static.
188 Remove EXFUN.
189 * insdel.c (Fcombine_after_change_execute): No longer static.
190 * image.c (Finit_image_library): No longer static.
191 * fileio.c (Fmake_symbolic_link): No longer static.
192 * eval.c (Ffetch_bytecode): No longer static.
193 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
194 * doc.c (Fdocumentation_property, Fsnarf_documentation):
195 No longer static.
404dbd37
TT
196 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
197 static.
198 * dired.c (Ffile_attributes): No longer static.
199 * composite.c (Fcomposition_get_gstring): No longer static.
200 * callproc.c (Fgetenv_internal): No longer static.
201
202 * ccl.h: Remove EXFUNs.
203 * buffer.h: Remove EXFUNs.
204 * dispextern.h: Remove EXFUNs.
205 * intervals.h: Remove EXFUNs.
206 * fontset.h: Remove EXFUN.
207 * font.h: Remove EXFUNs.
208 * dosfns.c (system_process_attributes): Remove EXFUN.
209 * keymap.h: Remove EXFUNs.
210 * lisp.h: Remove EXFUNs.
211 * w32term.h: Remove EXFUNs.
212 * window.h: Remove EXFUNs.
213 * xsettings.h: Remove EXFUN.
214 * xterm.h: Remove EXFUN.
215
8e4fd1e1
GM
2162012-07-03 Glenn Morris <rgm@gnu.org>
217
218 * lisp.h (Frandom): Make it visible to C.
219 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
220 buffer for invisible buffers. (Bug#1229)
221
ca95b3eb
DA
2222012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
223
224 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
225 values which aren't power of 2.
226 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
227 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
228 accordingly.
229
7555c33f
SM
2302012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
231
232 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
233
234 * alloc.c (mark_object): Revert part of last patch to use `switch'.
235
d12e8f5a
DA
2362012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
237
238 * alloc.c (allocate_vector_block): Remove redundant
239 calls to mallopt if DOUG_LEA_MALLOC is defined.
240 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
241 avoid calls to mallopt if zero_vector is returned.
242
296094c3
DA
2432012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
244
245 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
246 is enabled, avoid dereferencing NULL current_sblock if
247 running undumped.
248
36429c89
DA
2492012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
250
251 Cleanup basic buffer management.
252 * buffer.h (struct buffer): Change layout to use generic vector
253 marking code. Fix some comments. Change type of 'clip_changed'
254 to bitfield. Remove unused #ifndef old.
255 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
256 (GET_OVERLAYS_AT): Fix indentation.
257 (for_each_per_buffer_object_at): New macro.
258 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
259 (Fbuffer_local_variables): Use it.
260 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
261 * alloc.c (allocate_buffer): Adjust to match new layout of
262 struct buffer. Fix comment.
263 (mark_overlay): New function.
264 (mark_buffer): Use it. Use mark_vectorlike to mark normal
265 Lisp area of struct buffer.
266 (mark_object): Use it. Adjust marking of misc objects
267 and related comments.
268
3b3e4cac
PE
2692012-07-02 Paul Eggert <eggert@cs.ucla.edu>
270
271 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
272 wrapper that is not needed because the wrapped code is a no-op (zero
273 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
274 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
275
cf5c0175
DA
2762012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
277
278 * alloc.c (mark_buffer): Simplify. Remove prototype.
279 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 280 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
281 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
282 redundant calls to mark_vectorlike for bool vectors.
283
ca26824c
GM
2842012-06-30 Glenn Morris <rgm@gnu.org>
285
2e4c5312
GM
286 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
287
ca26824c
GM
288 * epaths.in (PATH_SITELOADSEARCH): New.
289 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
290 This is rather than relying on --enable-locallisppath elements
291 having "site-lisp" in their names. (Bug#10208#25, 11658)
292
0d23c240
EZ
2932012-06-30 Eli Zaretskii <eliz@gnu.org>
294
c9240d7a
EZ
295 * w32proc.c (sys_select): Accept and ignore one more argument.
296
297 * w32.c (emacs_gnutls_pull): Call select with one more argument.
298
0d23c240 299 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 300 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
301
302 * sysdep.c: Don't include dos.h and dosfns.h.
303
304 * process.c (sys_select):
305 * msdos.c (sys_select): Accept one more argument and ignore it.
306
307 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
308 adapt data types and code to that.
309
310 * dosfns.c:
311 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
312 which clashes with the gnulib function of the same name.
313
af5a5a98
AS
3142012-06-30 Andreas Schwab <schwab@linux-m68k.org>
315
c5e4379c
AS
316 * font.c (font_style_to_value, font_style_symbolic)
317 (font_prop_validate_style): Add type checks for values in
318 font_style_table.
319
af5a5a98
AS
320 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
321 argument.
322 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
323 uses.
324
8d38f461
EZ
3252012-06-29 Eli Zaretskii <eliz@gnu.org>
326
2e5a6631
EZ
327 * xdisp.c (try_window_id): Undo last change.
328
8d38f461
EZ
329 * w32.c (getwd): Adjust commentary about startup_dir.
330 (init_environment): Always call sys_access, even in non-MSVC
331 builds. Don't chdir to the directory of the Emacs executable.
332 This undoes code from 1997 which was justified by the need to
333 "avoid conflicts when removing and renaming directories". But its
334 downside was that every relative file name was being interpreted
335 relative to the directory of the Emacs executable, which can never
336 be TRT. In particular, it broke sys_access when called with
337 relative file names.
338 (sys_access): Map GetLastError to errno.
339
2af3565e
DA
3402012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
341
342 * window.h (struct window): Change type of 'fringes_outside_margins'
343 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 344 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
345 Adjust comment.
346 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
347 to ptrdiff_t.
348
c8d3a25c 3492012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 350
c8d3a25c
GM
351 * gnutls.c (emacs_gnutls_handshake):
352 Add QUIT to make the loop interruptible.
57570cd3 353
c8d3a25c 3542012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 355
c8d3a25c
GM
356 * charset.c (init_charset): Make lack of etc/charsets fatal.
357
3e984ee8
DA
3582012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
359
360 * editfns.c (region_limit): Fix type mismatch.
361
ef884f23
DA
3622012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
363
364 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
365 undefined. Convert from xassert to eassert.
366 * nsmenu.m: Convert from xassert to eassert.
367 * nsterm.m: Likewise.
368
7d7e0027
SM
3692012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
370
371 * editfns.c (region_limit): Clip to narrowing (bug#11770).
372
aa754e6a
PE
3732012-06-28 Paul Eggert <eggert@cs.ucla.edu>
374
375 Avoid integer overflow on scroll-left and scroll-right.
376 * window.c (HSCROLL_MAX): New macro.
377 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
378 overflow when requested scroll falls outside ptrdiff_t range.
379
80b00b08
DA
3802012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
381
382 * window.h (struct window): Change type of 'hscroll',
383 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
384 'last_modified' and 'last_overlay_modified' to EMACS_INT.
385 Adjust users accordingly.
386 * xdisp.c (try_cursor_movement): Replace type check with eassert.
387 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
388 from EMACS_INT to ptrdiff_t.
389 (make_window): Omit redundant initialization.
390
62b2bcf6
JB
3912012-06-28 Juanma Barranquero <lekktu@gmail.com>
392
393 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
394
45942c7d
DA
3952012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
396
397 * window.h (struct window): Change type of 'use_time' and
398 'sequence_number' from Lisp_Object to int.
399 * frame.c (make_frame): Adjust users accordingly.
400 * print.c (print_object): Likewise.
401 * window.c (select_window, Fwindow_use_time, make_parent_window)
402 (make_window): Likewise.
403
e509cfa6
DA
4042012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
405
406 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
407 enabled with --enable-checking=[all,glyphs] configure option.
408 Fix GLYPH_DEBUG usage assuming that it may be undefined,
409 adjust comments accordingly.
410 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
411 undefined, adjust comments accordingly.
412 * image.c: Likewise.
413 * scroll.c: Likewise.
414 * w32fns.c: Likewise.
415 * w32term.c: Likewise.
416 * xdisp.c: Likewise.
417 * xfaces.c: Likewise.
418 * xfns.c: Likewise.
419 * xterm.c: Likewise.
420
a54e2c05
DA
4212012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
422
423 Generalize run-time debugging checks.
424 * dispextern.h (XASSERTS): Remove.
425 * fontset.c (xassert): Remove.
426 Convert from xassert to eassert.
427 * alloc.c: Convert from xassert to eassert.
428 * bidi.c: Likewise.
429 * dispnew.c: Likewise.
430 * fns.c: Likewise.
431 * fringe.c: Likewise.
432 * ftfont.c: Likewise.
433 * gtkutil.c: Likewise.
434 * image.c: Likewise.
435 * keyboard.c: Likewise.
436 * menu.c: Likewise.
437 * process.c: Likewise.
438 * scroll.c: Likewise.
439 * sound.c: Likewise.
440 * term.c: Likewise.
441 * w32console.c: Likewise.
442 * w32fns.c: Likewise.
443 * w32term.c: Likewise.
444 * window.c: Likewise.
445 * xdisp.c: Likewise.
446 * xfaces.c: Likewise.
447 * xfns.c: Likewise.
448 * xselect.c: Likewise.
449 * xterm.c: Likewise.
450
1ec4b7b2
SM
4512012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
452
453 * fns.c (maybe_resize_hash_table): Output message when growing the
454 purify-hashtable.
455
2014308a
DA
4562012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
457
458 * alloc.c (allocate_string_data): Remove dead code.
459 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
460 avoid GCC warning about unused macro.
461
246155eb
DA
4622012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
463
464 * alloc.c (allocate_string): Omit intervals initialization.
465 * alloc.c (make_uninit_multibyte_string): Initialize intervals
466 as in make_pure_string and make_pure_c_string.
467
43184b7b
DA
4682012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
469
d209e2fb 470 * alloc.c (allocate_string): Fix last change.
43184b7b 471
3fe6dd74
DA
4722012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
473
d209e2fb 474 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
475 to memset, add explicit initialization where appropriate.
476
1ba6038a
GM
4772012-06-27 Glenn Morris <rgm@gnu.org>
478
479 * lisp.mk (lisp): Remove paths.elc.
480
c89926a5
CY
4812012-06-27 Chong Yidong <cyd@gnu.org>
482
483 * doc.c (Fsubstitute_command_keys): Fix punctuation.
484
ed6b3510
JW
4852012-06-26 John Wiegley <johnw@newartisans.com>
486
1ec4b7b2 487 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
488 on Mac OS X Lion: __mod_init_func and __mod_term_func.
489
ed6b3510
JW
490 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
491 when building with Clang.
492
8edd4a2b
SM
4932012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
494
495 * eval.c (Fapply): Allow calling it with a single argument.
496
f6f62d1b
EZ
4972012-06-26 Eli Zaretskii <eliz@gnu.org>
498
499 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
500 _stricmp and _strnicmp.
501 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
502
62efea5e
DA
5032012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
504
505 * alloc.c (allocate_window): Zero out non-Lisp part of newly
506 allocated window.
507 (allocate_process): Likewise for new process.
8edd4a2b 508 (allocate_terminal): Change to use offsetof.
62efea5e
DA
509 (allocate_frame): Likewise.
510 * frame.c (make_frame): Omit redundant initialization.
511 * window.c (make_parent_window): Use memset.
512 (make_window): Omit redundant initialization.
513 * process.c (make_process): Omit redundant initialization.
514 * terminal.c (create_terminal): Likewise.
515
42997f4d
DA
5162012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
517
518 * term.c (delete_tty): Remove redundant call to memset.
519
1130ecfc
DA
5202012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
521
522 * alloc.c: Remove build_string.
523 * lisp.h: Define build_string as static inline. This provides
524 a better opportunity to optimize away calls to strlen when the
525 function is called with compile-time constant argument.
526 * image.c (imagemagick_error): Convert to build_string.
527 * w32proc.c (sys_spawnve): Likewise.
528 * xterm.c (x_term_init): Likewise.
529
cf38a720
PE
5302012-06-26 Paul Eggert <eggert@cs.ucla.edu>
531
99027bdd
PE
532 Use sprintf return value instead of invoking strlen on result.
533 In the old days this wasn't portable, since some sprintf
534 implementations returned char *. But they died out years ago and
535 Emacs already assumes sprintf returns int.
536 Similarly for float_to_string.
537 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
538 * ccl.c (ccl_driver):
539 * character.c (string_escape_byte8):
540 * data.c (Fnumber_to_string):
541 * doprnt.c (doprnt):
542 * print.c (print_object):
543 * xdisp.c (message_dolog):
544 * xfns.c (syms_of_xfns):
545 Use sprintf or float_to_string result to avoid need to call strlen.
546 * data.c (Fnumber_to_string):
547 Use make_unibyte_string, since the string must be ASCII.
548 * lisp.h, print.c (float_to_string): Now returns int length.
549 * term.c (produce_glyphless_glyph):
550 Use sprintf result rather than recomputing it.
551
cf38a720
PE
552 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
553 * Makefile.in (ALL_CFLAGS):
554 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
555 * gmalloc.c, regex.c: Include <config.h> unconditionally.
556
3511c784
DA
5572012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
558
0a08eb21 559 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
560 strcasecmp if available.
561 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
562
fb7da12e
AS
5632012-06-25 Andreas Schwab <schwab@linux-m68k.org>
564
565 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
566 Avoid comma operator.
567 * menu.c (push_submenu_start, push_submenu_end)
568 (push_left_right_boundary, push_menu_pane): Likewise.
569 * msdos.c (dos_rawgetc): Likewise.
570
afa2ffd8
DA
5712012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
572
573 * xfns.c (xic_create_fontsetname): Remove redundant calls
574 to memset.
575
b3b4476b
PE
5762012-06-25 Paul Eggert <eggert@cs.ucla.edu>
577
4495ff38
PE
578 * gtkutil.c (get_utf8_string): Remove redundant assignment.
579 sprintf already null-terminates its output.
580
b3b4476b
PE
581 * xfns.c (x_window): Remove redundant cast.
582
b00876c9
DA
5832012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
584
585 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
586 `const char *' to `char *' to avoid compiler warning.
587
d188e26b
PE
5882012-06-24 Paul Eggert <eggert@cs.ucla.edu>
589
885d1d74
PE
590 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
591 instead of truncating it to 63 (admittedly a generous limit).
592
d188e26b
PE
593 * process.c: Fix spelling and caps in comments.
594
e2f560b1
DN
5952012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
596
e86db54b 597 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
598 * sysdep.c (setpgrp): Remove definition, not used in this file.
599
7583a3a1
JB
6002012-06-24 Juanma Barranquero <lekktu@gmail.com>
601
602 * makefile.w32-in: Update dependencies.
603
696056c2
EZ
6042012-06-24 Eli Zaretskii <eliz@gnu.org>
605
606 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
607 (SYSTIME_H): Add nt/inc/sys/time.h.
608
609 * systime.h [WINDOWSNT]: Include sys/time.h.
610
611 * s/ms-w32.h (struct timespec): Definition moved from
612 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
613
845ca893
PE
6142012-06-24 Paul Eggert <eggert@cs.ucla.edu>
615
616 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
617 * buffer.h (buffer_slot_type_mismatch):
618 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
619 * eval.c (unwind_to_catch):
620 * image.c (my_png_error, my_error_exit):
621 * keyboard.c (quit_throw_to_read_char, user_error)
622 (Fexit_recursive_edit, Fabort_recursive_edit):
623 * lisp.h (die, args_out_of_range, args_out_of_range_3)
624 (wrong_type_argument, buffer_overflow, __executable_start)
625 (memory_full, buffer_memory_full, string_overflow, Fthrow)
626 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
627 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
628 (fatal):
629 (child_setup) [!DOS_NT]:
630 * lread.c (end_of_file_error, invalid_syntax):
631 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
632 * puresize.h (pure_write_error):
633 * search.c (matcher_overflow):
634 * sound.c (sound_perror, alsa_sound_perror):
635 * sysdep.c, syssignal.h (croak):
636 * term.c (maybe_fatal, vfatal):
637 * textprop.c (text_read_only):
638 * undo.c (user_error):
639 * unexmacosx.c (unexec_error):
640 * xterm.c (x_ins_del_lines, x_delete_glyphs):
641 Use _Noreturn rather than NO_RETURN.
642 No need for separate decl merely because of _Noreturn.
643 * sound.c (sound_warning, parse_sound):
644 Remove unnecessary forward decls.
645
f1dd8073
PE
6462012-06-24 Paul Eggert <eggert@cs.ucla.edu>
647
648 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
649 * lisp.h (WAIT_READING_MAX): New macro.
650 * dispnew.c (Fsleep_for, sit_for):
651 * keyboard.c (kbd_buffer_get_event):
652 * process.c (Faccept_process_output):
653 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
654 This improves on the previous patch, which introduced a bug
655 when time_t is unsigned and as wide as intmax_t.
656 See <http://bugs.gnu.org/9000#51>.
657
b82c1755
EZ
6582012-06-23 Eli Zaretskii <eliz@gnu.org>
659
660 * dispnew.c (sit_for, Fsleep_for):
661 * keyboard.c (kbd_buffer_get_event):
662 * process.c (Faccept_process_output): Avoid compiler warnings when
663 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
664
ca300656
JB
6652012-06-23 Juanma Barranquero <lekktu@gmail.com>
666
049ec95b
JB
667 * makefile.w32-in: Update dependencies.
668
ca300656
JB
669 * w32.c (ltime): Add return type and declare static.
670 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
671
db7b8d06
PE
6722012-06-23 Paul Eggert <eggert@cs.ucla.edu>
673
674 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
675 Privately reported by Herbert J. Skuhra.
676 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
677 All uses changed.
678 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
679 not make_lisp_timeval, when the argument is of type EMACS_TIME.
680
0bd8297f
EZ
6812012-06-23 Eli Zaretskii <eliz@gnu.org>
682
96512555
EZ
683 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
684 last argument of make_unibyte_string.
685
0bd8297f
EZ
686 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
687 language ID in the event parameters.
688
689 * w32term.c (w32_read_socket): Put the new keyboard codepage into
690 event.code, not the obscure "character set ID".
691
63def6b6
CY
6922012-06-23 Chong Yidong <cyd@gnu.org>
693
694 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
695
e8a02204
EZ
6962012-06-23 Eli Zaretskii <eliz@gnu.org>
697
388cdec0
EZ
698 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
699 * w32.c (fdutimens): New function.
700
701 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
702
703 * s/ms-w32.h (pselect): Redirect to sys_select.
704
705 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
706
e8a02204
EZ
707 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
708 in the logic of incrementing and decrementing the value of
709 use_relocatable_buffers.
710
d054f3fb
PE
7112012-06-23 Paul Eggert <eggert@cs.ucla.edu>
712
713 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
714 Privately reported by Herbert J. Skuhra.
715 [__FreeBSD__]: Remove "*/" typo after "#include".
716 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
717 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
718 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
719 Don't assume EMACS_TIME and struct timeval are the same type.
720
d35af63c
PE
7212012-06-22 Paul Eggert <eggert@cs.ucla.edu>
722
723 Support higher-resolution time stamps (Bug#9000).
724 The time stamps are only nanosecond-resolution at the C level,
725 since that's the best that any real-world system supports now.
726 But they are picosecond-resolution at the Lisp level, as that's
727 easy, and leaves room for future OS improvements.
728
729 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
730 (LIBES): Use it.
731
732 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
733 Don't get current time unless it's needed.
734
735 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
736 now provides it if it's absent.
737 (start_atimer): Port to higher-res time stamps.
738 Check for time stamp overflow. Don't get current time more
739 often than is needed.
740
741 * buffer.h (struct buffer): Buffer modtime now has high resolution.
742 Include systime.h, not time.h.
743 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
744
745 * dired.c: Include stat-time.h.
746 (Ffile-attributes): File times now have higher resolution.
747
748 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
749 (struct image): Timestamp now has higher resolution.
750
751 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
752 has at least microseconds now. All uses removed.
753 (update_frame, update_single_window, update_window, update_frame_1)
754 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
755
756 * editfns.c (time_overflow): Now extern.
757 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
758 (float-time, Fformat_time_string, Fcurrent_time_string)
759 (Fcurrent_time_zone): Accept and generate higher-resolution
760 time stamps.
761 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
762 (decode_time_components, lisp_seconds_argument): New functions.
763 (make_time): Now static.
764 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
765 Report an error if the time is invalid, rather than having the caller
766 do that.
767
768 * fileio.c: Include <stat-time.h>
769 (Fcopy_file): Copy higher-resolution time stamps.
770 Prefer to set the time stamp via a file descriptor if that works.
771 (Fset_file_times, Finsert_file_contents, Fwrite_region)
772 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
773 (Fvisited_file_modtime, Fset_visited_file_modtime):
774 Support higher-resolution time stamps.
775
776 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
777
778 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
779
780 * image.c (prepare_image_for_display, clear_image_cache)
781 (lookup_image): Port to higer-resolution time stamps.
782
783 * keyboard.c (start_polling, bind_polling_period):
784 Check for time stamp overflow.
785 (read_char, kbd_buffer_get_event, timer_start_idle)
786 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
787 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
788 Port to higher-resolution time stamps. Do not assume time_t is signed.
789 (decode_timer): New function. Timers are now vectors of length 9,
790 not 8, to accommodate the picosecond component.
791 (timer_check_2): Use it.
792
793 * nsterm.m (select_timeout, timeval_subtract): Remove.
794 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
795 as they're a bit more accurate and handle overflow better.
796 (ns_select): Change prototype to be compatible with pselect.
797 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
798 * nsterm.h (ns_select): Adjust prototype.
799
800 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
801 us-resolution time stamps.
802 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
803
804 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
805
806 * lisp.h (time_overflow): New decl.
807 (wait_reading_process_output): First arg is now intmax_t, not int,
808 to accommodate larger waits.
809
810 * process.h (struct Lisp_Process.read_output_delay):
811 Now counts nanoseconds, not microseconds.
812 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
813 EMACS_HAS_USECS.
814 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
815 (wait_reading_process_output):
816 Port to ns-resolution time stamps.
817 (Faccept_process_output, wait_reading_process_output):
818 Check for time stamp overflow. Do not assume time_t is signed.
819 (select_wrapper): Remove; we now use pselect.
820 (Fprocess_attributes): Now generates ns-resolution time stamps.
821
822 * sysdep.c: Include utimens.h. Don't include utime.h
823 or worry about struct utimbuf; gnulib does that for us now.
824 (gettimeofday): Remove; gnulib provides a substitute.
825 (make_timeval): New function.
826 (set_file_times): Now sets ns-resolution time stamps.
827 New arg FD; all uses changed.
828 (time_from_jiffies, ltime_from_jiffies, get_up_time)
829 (system_process_attributes):
830 Now returns ns-resolution time stamp. All uses changed.
831 Check for time stamp overflow.
832
833 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
834 provides a substitute now.
835
836 * systime.h: Include timespec.h rather than sys/time.h and time.h,
837 since it guarantees struct timespec.
838 (EMACS_TIME): Now struct timespec, so that we can support
839 ns-resolution time stamps.
840 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
841 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
842 (EMACS_USECS): Remove.
843 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
844 so multiply the arg by 1000 before storing it.
845 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
846 New macros.
847 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
848 Port to ns-resolution time stamps.
849 (EMACS_TIME_NEG_P): Remove; replaced by....
850 (EMACS_TIME_SIGN): New macro.
851 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
852 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
853 (set_file_times, make_time, lisp_time_argument): Adjust signature.
854 (make_timeval, make_lisp_time, decode_time_components): New decls.
855 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
856 that it mishandled time_t overflow. You can't compare by subtracting!
857 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
858 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
859
860 * term.c: Include <sys/time.h>.
861 (timeval_to_Time): New function, for proper overflow wraparound.
862 (term_mouse_position, term_mouse_click): Use it.
863
864 * undo.c (record_first_change): Support higher-resolution time stamps
865 in the undo buffer.
866 (Fprimitive_undo): Use them when restoring time stamps.
867
868 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
869 (w32_get_internal_run_time):
870 Port to higher-resolution Emacs time stamps.
871 (ltime): Now accepts single 64-bit integer, as that's more convenient
872 for callers.
873
874 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
875
876 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
877 for compatibility with pselect. Support ns-resolution time stamps.
878
879 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
880
881 * xselect.c (wait_for_property_change, x_get_foreign_selection):
882 Check for time stamp overflow, and support ns-resolution time stamps.
883
884 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
885 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
886 (timeval_subtract): Remove; no longer needed.
887 (XTflash, XTring_bell, x_wait_for_event):
888 Port to ns-resolution time stamps. Don't assume time_t is signed.
889
b6a92dfe
CY
8902012-06-22 Chong Yidong <cyd@gnu.org>
891
892 * xdisp.c (x_consider_frame_title): Revert last change.
893
d251c37c
EZ
8942012-06-22 Eli Zaretskii <eliz@gnu.org>
895
896 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
897 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
898 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
899 staticidx goes up to 1597 out of 1600 = 0x640.)
900
f10deafb
PE
9012012-06-20 Paul Eggert <eggert@cs.ucla.edu>
902
903 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
904 Otherwise, the umask might be mistakenly 0 while handling input signals.
905
ec6de1e2
SM
9062012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
907
908 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
909
28be1ada
DA
9102012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
911
912 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
913 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
914 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
915 access to `contents' member of Lisp_Vector objects with AREF and ASET
916 where appropriate.
917
c6bf3022
CY
9182012-06-19 Chong Yidong <cyd@gnu.org>
919
920 * frame.c (delete_frame): When selecting a frame on a different
921 text terminal, do not alter the terminal's top-frame.
922
923 * xdisp.c (format_mode_line_unwind_data): Record the target
924 frame's selected window and its terminal's top-frame.
925 (unwind_format_mode_line): Restore them.
926 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
927 Callers changed.
928 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
929 since tty frames can be explicitly named.
930 (prepare_menu_bars): Likewise.
931
932 * term.c (Ftty_top_frame): New function.
933
defd4196
PE
9342012-06-18 Paul Eggert <eggert@cs.ucla.edu>
935
936 Port byte-code-meter to modern targets.
937 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
938 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 939 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
940 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
941 (METER_1, METER_2): Simplify.
942
1053a871
SM
9432012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
944
945 * data.c (Fdefalias): Return `symbol' (bug#11686).
946
b7e8d081
MR
9472012-06-18 Martin Rudalics <rudalics@gmx.at>
948
949 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
950 gets killed during executing of this function (Bug#11665).
951 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
952 (Vkill_buffer_query_functions): In doc-string say that functions
953 run by this hook should not change the current buffer.
954
7ea2b339
PE
9552012-06-18 Paul Eggert <eggert@cs.ucla.edu>
956
957 Fix recently-introduced process.c problems found by static checking.
958 * process.c (write_queue_push, write_queue_pop, send_process):
959 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
960 (write_queue_pop): Fix pointer signedness problem.
961 (send_process): Remove unused local.
962
96a313a1
CY
9632012-06-17 Chong Yidong <cyd@gnu.org>
964
965 * xdisp.c (redisplay_internal): No need to redisplay terminal
966 frames that are not on top.
967
20ca2e94
TN
9682012-06-17 Troels Nielsen <bn.troels@gmail.com>
969
970 * process.c (make_process): Initialize write_queue.
971 (write_queue_push, write_queue_pop): New functions.
972 (send_process): Use them to maintain correct ordering of process
973 writes (Bug#10815).
974
9a900ca9
PE
9752012-06-17 Paul Eggert <eggert@cs.ucla.edu>
976
310fbfa8
PE
977 * lisp.h (eassert): Assume C89 or later.
978 This removes the need for CHECK.
979 (CHECK): Remove. Its comments about always evaluating its
980 argument were confusing, as 'eassert' typically does not evaluate
981 its argument.
982
27bb1ca4
PE
983 * coding.c (produce_chars): Use ptrdiff_t, not int.
984
9a900ca9
PE
985 * xterm.c (x_draw_underwave): Check for integer overflow.
986 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
987
41b7f8bc 9882012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
989
990 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
991 referenced (Bug#11583).
992
9b0e3eba
AA
9932012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
994
995 Implement wave-style variant of underlining.
996 * dispextern.h (face_underline_type): New enum.
997 (face): Add field for underline type.
998 * nsterm.m (ns_draw_underwave): New function.
999 (ns_draw_text_decoration): Use it.
1000 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1001 New functions.
1002 (x_draw_glyph_string): Use them.
1003 * xfaces.c (Qline, Qwave): New Lisp objects.
1004 (check_lface_attrs, merge_face_ref)
1053a871
SM
1005 (Finternal_set_lisp_face_attribute, realize_x_face):
1006 Handle wave-style underline face attributes.
9b0e3eba
AA
1007 * xterm.c (x_draw_underwave): New function.
1008 (x_draw_glyph_string): Use it.
1009
0fb52f11
JB
10102012-06-16 Juanma Barranquero <lekktu@gmail.com>
1011
1012 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1013 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1014 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1015 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1016 ($(BLD)/w32select.$(O)): Update dependencies.
1017
e5560ff7
AS
10182012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1019
1020 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1021 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1022 * character.c (_fetch_multibyte_char_p): Remove.
1023 * alloc.c: Include "character.h" before "buffer.h".
1024 * bidi.c: Likewise.
1025 * buffer.c: Likewise.
1026 * bytecode.c: Likewise.
1027 * callint.c: Likewise.
1028 * callproc.c: Likewise.
1029 * casefiddle.c: Likewise.
1030 * casetab.c: Likewise.
1031 * category.c: Likewise.
1032 * cmds.c: Likewise.
1033 * coding.c: Likewise.
1034 * composite.c: Likewise.
1035 * dired.c: Likewise.
1036 * dispnew.c: Likewise.
1037 * doc.c: Likewise.
1038 * dosfns.c: Likewise.
1039 * editfns.c: Likewise.
1040 * emacs.c: Likewise.
1041 * fileio.c: Likewise.
1042 * filelock.c: Likewise.
1043 * font.c: Likewise.
1044 * fontset.c: Likewise.
1045 * fringe.c: Likewise.
1046 * indent.c: Likewise.
1047 * insdel.c: Likewise.
1048 * intervals.c: Likewise.
1049 * keyboard.c: Likewise.
1050 * keymap.c: Likewise.
1051 * lread.c: Likewise.
1052 * macros.c: Likewise.
1053 * marker.c: Likewise.
1054 * minibuf.c: Likewise.
1055 * nsfns.m: Likewise.
1056 * nsmenu.m: Likewise.
1057 * print.c: Likewise.
1058 * process.c: Likewise.
1059 * regex.c: Likewise.
1060 * region-cache.c: Likewise.
1061 * search.c: Likewise.
1062 * syntax.c: Likewise.
1063 * term.c: Likewise.
1064 * textprop.c: Likewise.
1065 * undo.c: Likewise.
1066 * unexsol.c: Likewise.
1067 * w16select.c: Likewise.
1068 * w32fns.c: Likewise.
1069 * w32menu.c: Likewise.
1070 * window.c: Likewise.
1071 * xdisp.c: Likewise.
1072 * xfns.c: Likewise.
1073 * xmenu.c: Likewise.
1074 * xml.c: Likewise.
1075 * xselect.c: Likewise.
1076
2f07e6af
EZ
10772012-06-16 Eli Zaretskii <eliz@gnu.org>
1078
1053a871
SM
1079 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1080 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1081 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1082 row.
1083 (handle_face_prop): Use chunk-relative overlay string index when
1084 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1085 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1086 the rightmost. (Bug#11720)
2f07e6af 1087
29b83cec
AS
10882012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1089
1090 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1091 (CATEGORY_MEMBER): Enforce 1/0 value.
1092 * category.c (_temp_category_set): Remove.
1093
4c5501e9
EZ
10942012-06-16 Eli Zaretskii <eliz@gnu.org>
1095
1096 * window.c (Fdelete_other_windows_internal)
1097 (Fdelete_window_internal): Don't access frame's mouse highlight
1098 info of the initial frame. (Bug#11677)
1099
2b570124
PE
11002012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1101
e93864f9
PE
1102 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1103 Assume USE_2_TAGS_FOR_INTS.
1104 (xreload): Adjust $tagmask width to match recent lisp.h change.
1105
2b570124
PE
1106 Simplify lisp.h in minor ways that should not affect code.
1107 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1108 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1109 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1110 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1111 (INTTYPEBITS): New macro, for clarity.
1112 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1113 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1114 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1115 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1116 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1117
81755f69
JB
11182012-06-13 Juanma Barranquero <lekktu@gmail.com>
1119
1120 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1121
16192a57
GM
11222012-06-13 Glenn Morris <rgm@gnu.org>
1123
1124 * s/bsd-common.h (BSD4_3):
1125 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1126
646b5f55
AS
11272012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1128
1129 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1130 instead of union.
1131 (XLI, XIL): Define.
1053a871
SM
1132 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1133 Use them.
1134 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1135 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1136 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1137 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1138 * frame.c (delete_frame): Remove outdated comment.
1139 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1140 USE_LISP_UNION_TYPE.
1141 (Fw32_unregister_hot_key): Likewise.
1142 (Fw32_toggle_lock_key): Likewise.
1143 * w32menu.c (add_menu_item): Likewise.
1144 (w32_menu_display_help): Use XIL instead of checking
1145 USE_LISP_UNION_TYPE.
1146 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1147 (init_heap): Likewise.
1148 * w32term.c (w32_read_socket): Update comment.
1149
1d3823c9
GM
11502012-06-13 Glenn Morris <rgm@gnu.org>
1151
c62ff706
GM
1152 * s/usg5-4-common.h, src/s/unixware.h:
1153 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1154
1d3823c9
GM
1155 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1156
bfe3e0a2
PE
11572012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1158
1159 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1160 * alloc.c (make_number) [!defined make_number]:
1161 Remove, as lisp.h always defines this now.
1162 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1163 (roundup_size): Verify that it is a power of 2.
1164 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1165 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1166 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1167 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1168 USE_LSB_TAG now is always defined to be either 0 or 1.
1169 All uses changed.
1170 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1171 code works fine either way, and efficiency is not a concern here,
1172 as the union type is for debugging, not for production.
1173 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1174 Use an inline function on all platforms when using the union type,
1175 since this is simpler and 'static inline' can be used portably
1176 within Emacs now.
1177 (LISP_INITIALLY_ZERO): New macro.
1178 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1179 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1180
45fa9c0f
GM
11812012-06-12 Glenn Morris <rgm@gnu.org>
1182
b4492cba
GM
1183 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1184
1185 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1186
45fa9c0f
GM
1187 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1188 Move BROKEN_SIGIO to configure.
1189
1190 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1191 Move NO_TERMIO to configure.
1192
0e25d334
CY
11932012-06-12 Chong Yidong <cyd@gnu.org>
1194
1195 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1196 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1197 MagickExportImagePixels is undefined.
1198
43682bb6
PE
11992012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1200
1201 * image.c (imagemagick_load_image): Remove unused label.
1202
a9be7d2b
GM
12032012-06-11 Glenn Morris <rgm@gnu.org>
1204
1205 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1206 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1207 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1208 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1209
3017f87f
SM
12102012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1211
1212 * alloc.c (make_byte_code): New function.
1213 (Fmake_byte_code): Use it. Don't purify here.
1214 * lread.c (read1): Use it as well to avoid extra allocation.
1215
1b9b4cf4
CY
12162012-06-11 Chong Yidong <cyd@gnu.org>
1217
1218 * image.c (imagemagick_load_image): Implement transparency.
1219
95988fcf
AS
12202012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1221
1222 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1223 account for preceding backslashes. (Bug#11663)
1224
cd4eb164
CY
12252012-06-09 Chong Yidong <cyd@gnu.org>
1226
1227 * term.c: Support italics in capable terminals (Bug#9652).
1228 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1229 (turn_on_face): Output using TS_enter_italic_mode if available.
1230 Don't handle unused blinking and alt-charset cases.
1231 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1232 and tty_alt_charset_p cases.
1233 (tty_capable_p, init_tty): Support italics.
1234
1235 * termchar.h (struct tty_display_info): Add field for italics.
1236 Remove unused blink field.
1237
1238 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1239 Handle slant.
1240
1241 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1242 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1243 tty_alt_charset_p. Add tty_italic_p.
1244
ff88beb8
MA
12452012-06-09 Michael Albinus <michael.albinus@gmx.de>
1246
1247 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1248 dbus_type_is_basic if available.
1249 (xd_extract_signed, xd_extract_unsigned): Rename from
1250 extract_signed and extract_unsigned, respectively. Adapt callers.
1251
44286096
CY
12522012-06-09 Chong Yidong <cyd@gnu.org>
1253
1682701f
CY
1254 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1255
44286096
CY
1256 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1257 case (Bug#9752).
1258
d86feb17
PE
12592012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1260
1261 * xdisp.c (vmessage): Treat frame message as multibyte.
1262 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1263 would generate the diagnostic "Making \302\247 buffer-local while
1264 let-bound!".
1265
d5c20fe8
EZ
12662012-06-08 Eli Zaretskii <eliz@gnu.org>
1267
1268 * dispnew.c (showing_window_margins_p): Undo last change, which
1269 was done due to an inadvertent commit.
1270 (adjust_frame_glyphs_for_frame_redisplay): Do call
1271 showing_window_margins_p.
1272
513749ee
SM
12732012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1274
1275 * eval.c (Fmake_var_non_special): New primitive.
1276 (syms_of_eval): Defsubr it.
1277 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1278
d4a8f5c1
JB
12792012-06-08 Juanma Barranquero <lekktu@gmail.com>
1280
1281 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1282 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1283
8bbbc977
EZ
12842012-06-08 Eli Zaretskii <eliz@gnu.org>
1285
1286 * alloc.c (allocate_vectorlike): Fix last change.
1287
f3372c87
DA
12882012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1289
1290 Block-based vector allocation of small vectors.
1291 * lisp.h (struct vectorlike_header): New field `nbytes',
1292 adjust comment accordingly.
1293 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1294 to denote vector blocks. Adjust users (live_vector_p,
1295 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1296 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1297 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1298 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1299 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1300 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1301 (roundup_size): New constant.
1302 (struct vector_block): New data type.
1303 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1304 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1305 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1306 (sweep_vectors): New functions.
1307 (allocate_vectorlike): Return `zero_vector' as the only vector of
1308 0 items. Allocate new vector from block if vector size is less than
1309 or equal to VBLOCK_BYTES_MAX.
1310 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1311 (init_alloc_once): Add call to init_vectors.
1312
4f18a4ed
SM
13132012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1314
1315 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1316
86f158bc
PE
13172012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1318
1319 * doprnt.c (doprnt): Truncate multibyte char correctly.
1320 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1321 would mishandle a string argument "Xc" if X was a multibyte
1322 character of length 2: it would truncate after X's first byte
1323 rather than including all of X.
1324
c5cfcbe0
CY
13252012-06-06 Chong Yidong <cyd@gnu.org>
1326
1327 * buffer.c (word_wrap): Doc fix.
1328
c05cf390
PE
13292012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1330
1331 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1332
0c3461de
GM
13332012-06-03 Glenn Morris <rgm@gnu.org>
1334
1335 * xdisp.c (tool-bar-style): Doc fix.
1336
c71232db
UM
13372012-06-03 Ulrich Müller <ulm@gentoo.org>
1338
1339 * Makefile.in (PAXCTL): Define.
1340 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1341 binary via PaX flags if the paxctl utility is available.
1342 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1343 Restore PaX flags to their default. (Bug#11398)
1344
383f7350
CY
13452012-06-03 Chong Yidong <cyd@gnu.org>
1346
1347 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1348 buffer (Bug#11226).
1349
5f2c76c6
CY
13502012-06-03 Chong Yidong <cyd@gnu.org>
1351
1352 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1353 (note_mode_line_or_margin_highlight): If there is no help echo,
1354 use mode-line-default-help-echo. Handle the case where the mouse
1355 position is past the end of the mode line string.
1356
1357 * buffer.c (buffer_local_value_1): New function, split from
1358 Fbuffer_local_value; can return Qunbound.
1359 (Fbuffer_local_value): Use it.
1360 (Vmode_line_format): Docstring tweaks.
1361
773d47f6
PE
13622012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1363
1364 * sysdep.c (system_process_attributes): Improve comment.
1365
f2d6a3df
SM
13662012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1367
1368 * keyboard.c: Export real-this-command to Elisp.
1369 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1370 and DEFVAR it. Update all users.
1371
63810350
PE
13722012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1373
7bd5c1f4
PE
1374 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1375
63810350
PE
1376 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1377 Convert pctcpu and pctmem to Lisp float properly.
1378 Let the compiler fold better, as 100.0/0x8000 is exact.
1379
a2821611
AS
13802012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1381
1382 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1383 cons_block.
1384
5fceba1d
PE
13852012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1386
1387 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1388
c98ff5dd
DA
13892012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1390
1391 For a 'struct window', replace some Lisp_Object fields to
1392 bitfields where appropriate, remove unused fields.
1393 * window.h (struct window): Remove unused 'last_mark_x' and
1394 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1395 change it's type from Lisp_Object to bitfield.
1396 Change type of 'force_start', 'optional_new_start',
1397 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1398 fields from Lisp_Object to bitfield. Adjust users accordingly.
1399
ca34e0be
PE
14002012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1401
1402 Pacify gcc -Wdouble-precision when using Xaw.
1403 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1404 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1405 Use 'float' consistently, rather than 'float' in most places
1406 and 'double' in a couple of places.
1407
efc00ab1 14082012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1409
1410 * xdisp.c (handle_stop): Detect whether we have overlay strings
1411 loaded by testing it->current.overlay_string_index to be
1412 non-negative, instead of checking whether n_overlay_strings is
1413 positive. (Bug#11587)
1414
efc00ab1 14152012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1416
1417 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1418
1419 * doc.c (Fsubstitute_command_keys): Doc fix.
1420
efc00ab1 14212012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1422
1423 * search.c (search_buffer): Remove calls to
1424 r_alloc_inhibit_buffer_relocation, as it is now called by
1425 maybe_unify_char, which was the cause of relocation of buffer text
1426 in bug#11519.
1427
efc00ab1 14282012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1429
1430 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1431 for the duration of call to load_charset, to avoid problems with
1432 callers of maybe_unify_char that access buffer text through C
1433 pointers.
1434
1435 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1436 decrement the inhibition flag, instead of just setting or
1437 resetting it.
1438
ba93a187
PE
14392012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1440
1441 Remove obsolete '#define static' cruft.
1442 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1443 This #undef was "temporary" in 2000; it is no longer needed
1444 now that '#define static' has gone away.
1445 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1446 (gray_bitmap_bits): Remove; no longer needed.
1447 All uses replaced with definiens.
1448 * xterm.c: Include "bitmaps/gray.xbm".
1449
9e4bf381
PE
14502012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1451
1452 Clean up __executable_start, monstartup when --enable-profiling.
1453 The following changes affect the code only when profiling.
1454 * dispnew.c (__executable_start): Rename from safe_bcopy.
1455 Define only on platforms that need it.
1456 * emacs.c: Include <sys/gmon.h> when profiling.
1457 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1458 (__executable_start): Remove decl, since lisp.h does it now.
1459 (safe_bcopy): Remove decl; no longer has that name.
1460 (main): Coalesce #if into single bit of code, for simplicity.
1461 Cast pointers to uintptr_t, since standard libraries want integers
1462 and not pointers.
1463 * lisp.h (__executable_start): New decl.
1464
32d72c2f
GM
14652012-05-31 Glenn Morris <rgm@gnu.org>
1466
1467 * image.c (Fimagemagick_types): Doc fix.
1468
baac5bc7
JM
14692012-05-30 Jim Meyering <meyering@redhat.com>
1470
1471 * callproc.c (Fcall_process_region): Include directory component
1472 in mkstemp error message (Bug#11586).
1473
72cb32cf
PE
14742012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1475
1476 * alloc.c, lisp.h (make_pure_vector): Now static.
1477
61b108cc
SM
14782012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1479
1480 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1481 Move to byte-run.el.
1482 (Fautoload): Do the hash-doc more carefully.
1483 * data.c (Fdefalias): Purify definition, except for keymaps.
1484 (Qdefun): Move from eval.c.
1485 * lisp.h (Qdefun): Remove.
1486 * lread.c (read1): Tiny simplification.
1487
471fe23d
TN
14882012-05-29 Troels Nielsen <bn.troels@gmail.com>
1489
934f3f58 1490 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1491 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1492 Bug#9642, but explicitly check that the buffer the overlay would
1493 be moved to is live and rearrange lines to make sure that errors
1494 will not put the overlay in an inconsistent state.
1495 (Fdelete_overlay): Cosmetics.
1496
85d0efd1
EZ
14972012-05-28 Eli Zaretskii <eliz@gnu.org>
1498
1499 * w32term.c (my_bring_window_to_top): New function.
1500 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1501 could be different from the original one.
1502 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1503 (Bug#11513)
1504
1505 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1506 by calling BringWindowToTop.
1507
1508 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1509 (WM_EMACS_END): Increase by one.
1510
da92a98c
PE
15112012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1512
1513 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1514 This avoids undefined behavior that might cause the eassert
1515 to not catch an out-of-range value.
1516
74d1f848
JB
15172012-05-28 Juanma Barranquero <lekktu@gmail.com>
1518
1519 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1520 Update dependencies.
1521
9e1a06fc
EZ
15222012-05-27 Eli Zaretskii <eliz@gnu.org>
1523
1524 * bidi.c (bidi_mirror_char): Fix last change.
1525
f3dd7312
AS
15262012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1527
1528 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1529 when referring to sectname field in printf format.
1530
81899c91
PE
15312012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1532
57b81a9f
PE
1533 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1534 Only r_alloc_inhibit_buffer_relocation needed to be added;
1535 the others were already declared.
1536
81899c91
PE
1537 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1538 before checking whether it's out of range. Put the check inside
1539 eassert. See
1540 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1541
33017faf 15422012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1543
1544 * callproc.c (Fcall_process): Restore a line that was accidentally
1545 commented out in the 2011-02-13 change (bug#11547).
1546
33017faf 15472012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1548
1549 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1550 defined on ralloc.c.
1551
1552 * buffer.c [REL_ALLOC]: Remove prototypes of
1553 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1554 they are now on lisp.h.
1555
1556 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1557
1558 * search.c (search_buffer): Use it to inhibit relocation of buffer
1559 text while re_search_2 is doing its job, because re_search_2 is
1560 passed C pointers to buffer text. (Bug#11519)
1561
23415acf
EZ
1562 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1563 Update value to 24.
1564
44e27368
EZ
1565 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1566 state after an additional call to move_it_in_display_line_to, keep
1567 the values of it->max_ascent and it->max_descent found for the
1568 entire line.
1569 (pos_visible_p): Revert the comparison against bottom_y to what it
1570 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1571 (Bug#11464)
1572
c1892f11
PE
15732012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1574
1575 Fix coding-related core dumps with gcc -ftrapv.
1576 The code was computing A - B, where A and B are pointers, and B is
1577 random garbage. This can lead to core dumps on platforms that
1578 have special pointer registers, and it also leads to core dumps on
1579 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1580 A - B only when B is initialized properly.
1581 * coding.c (coding_set_source, coding_set_destination): Return void.
1582 (coding_change_source, coding_change_destinations): New functions,
1583 with the old behaviors of coding_set_source and coding_set_destination.
1584 All callers that need an offset changed to use these new functions.
1585
eb7afdad
GM
15862012-05-26 Glenn Morris <rgm@gnu.org>
1587
1588 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1589
f12fdf02
EZ
15902012-05-26 Eli Zaretskii <eliz@gnu.org>
1591
53a63be6 1592 Extend mouse support on W32 text-mode console.
61b108cc
SM
1593 * xdisp.c (draw_row_with_mouse_face):
1594 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1595
eb3f6f01 1596 * w32console.c: Include window.h.
61b108cc
SM
1597 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1598 New functions.
eb3f6f01
EZ
1599 (initialize_w32_display): Initialize mouse-highlight data.
1600
53a63be6
EZ
1601 * w32inevt.c: Include termchar.h and window.h.
1602 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1603 moves, call note_mouse_highlight. If help_echo changed, call
1604 gen_help_event to produce help-echo message in the echo area.
1605 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1606 highlight info.
1607
4cfd81f6
PE
16082012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1609
1610 * lread.c (read1): Simplify slightly to avoid an overflow warning
1611 with GCC 4.7.0 on x86-64.
1612
4446092a
EZ
16132012-05-26 Eli Zaretskii <eliz@gnu.org>
1614
1615 * bidi.c (bidi_mirror_char): Revert last change: an int is
1616 definitely wide enough here.
1617
42b2a986 16182012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1619
42b2a986 1620 Fix integer width and related bugs (Bug#9874).
eb106a49 1621 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1622 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1623 (string_bytes, check_sblock, allocate_string_data):
1624 (compact_small_strings, Fmake_bool_vector, make_string)
1625 (make_unibyte_string, make_multibyte_string)
1626 (make_string_from_bytes, make_specified_string)
1627 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1628 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1629 (mark_vectorlike):
1630 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1631 (allocate_pseudovector):
1632 Use int, not EMACS_INT, where int is wide enough.
1633 (inhibit_garbage_collection, Fgarbage_collect):
1634 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1635 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1636 int might not be wide enough.
1637 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1638 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1639 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1640 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1641 (bidi_level_of_next_char, bidi_move_to_visually_next):
1642 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1643 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1644 (Fkill_buffer, Fset_buffer_major_mode)
1645 (advance_to_char_boundary, Fbuffer_swap_text)
1646 (Fset_buffer_multibyte, overlays_at, overlays_in)
1647 (overlay_touches_p, struct sortvec, record_overlay_string)
1648 (overlay_strings, recenter_overlay_lists)
1649 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1650 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1651 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1652 (Foverlay_recenter, last_overlay_modification_hooks_used)
1653 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1654 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1655 (validate_region): Omit unnecessary test for b <= e,
1656 since that's guaranteed by the previous test.
d311d28c
PE
1657 (adjust_overlays_for_delete): Avoid pos + length overflow.
1658 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1659 (report_overlay_modification):
1660 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1661 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1662 Omit pointer cast, which isn't needed anyway, and doesn't work
1663 after the EMACS_INT -> ptrdiff_t change.
02481186 1664 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1665 * buffer.h: Adjust decls to match defn changes elsewhere.
1666 (struct buffer_text, struct buffer):
1667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1668 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1669 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1670 not int, to avoid needless 32-bit limit on 64-bit hosts.
1671 (exec_byte_code): Use tighter memory-full test, one that checks
1672 for alloca overflow. Don't compute the address of the object just
1673 before an array, as that's not portable. Use EMACS_INT, not
1674 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1675 * callint.c (Fcall_interactively):
1676 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1677 * callproc.c (call_process_kill, Fcall_process):
1678 Don't assume pid_t fits into an Emacs fixnum.
1679 (call_process_cleanup, Fcall_process, child_setup):
1680 Don't assume pid_t fits into int.
1681 (call_process_cleanup, Fcall_process, delete_temp_file)
1682 (Fcall_process_region):
1683 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1684 (Fcall_process): Simplify handling of volatile integers.
1685 Use int, not EMACS_INT, where int will do.
1686 * casefiddle.c (casify_object, casify_region, operate_on_word)
1687 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1689 (casify_object): Avoid integer overflow when overallocating buffer.
1690 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1691 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1692 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1693 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1694 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1695 integers are now checked earlier. All uses replaced with XINT.
1696 (ccl_driver):
1697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1698 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1699 (ccl_driver, Fregister_code_conversion_map):
1700 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1701 (resolve_symbol_ccl_program): Check that vector header is in range.
1702 Always copy the vector, so that we can check its contents reliably
1703 now rather than having to recheck each instruction as it's being
1704 executed. Check that vector words fit in 'int'.
1705 (ccl_get_compiled_code, Fregister_ccl_program)
1706 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1707 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1708 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1709 contents are in range.
1710 (Fccl_execute_on_string): Check that status is in range.
1711 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1712 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1713 Accept and return EMACS_INT, not int, because callers can pass values
1714 out of 'int' range.
1715 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1716 (multibyte_chars_in_text, parse_str_as_multibyte)
1717 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1718 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1719 (string_escape_byte8, Fget_byte):
1720 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1721 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1722 avoid mishandling large integers.
1723 * character.h: Adjust decls to match defn changes elsewhere.
1724 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1725 (Ffind_charset_region):
1726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1727 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1728 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1729 Don't assume fixnum fits in int.
d311d28c
PE
1730 (load_charset_map_from_vector, Fmap_charset_chars):
1731 Remove now-unnecessary CHECK_NATNUMs.
1732 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1733 Don't rely on undefined behavior with signed left shift overflow.
1734 Don't assume unsigned int fits into fixnum, or that fixnum fits
1735 into unsigned int. Don't require max_code to be a valid fixnum;
1736 that's not true for gb10830 4-byte on a 32-bit host. Allow
1737 invalid_code to be a cons, for the same reason. Require code_offset
1738 to be a character. Avoid int overflow if max_char is close
1739 to INT_MAX.
1740 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1741 this is intended anyway and avoids some undefined behavior.
1742 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1743 INDEX_TO_CODE_POINT, as that's what it expects.
1744 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1745 * charset.h (DECODE_CHAR): Return int, not unsigned;
1746 this is what was intended anyway, and it avoids undefined behavior.
1747 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1748 integer-overflow issues.
1749 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1750 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1751 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1752 * chartab.c (Fmake_char_table, Fset_char_table_range)
1753 (uniprop_get_decoder, uniprop_get_encoder):
1754 Don't assume fixnum fits in int.
1755 * cmds.c (move_point): New function, that does the gist of
1756 Fforward_char and Fbackward_char, but does so while checking
1757 for integer overflow more accurately.
c96e5d6a 1758 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1759 (Fforward_line, Fend_of_line, internal_self_insert)
1760 (internal_self_insert):
1761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1762 Fix a FIXME, by checking for integer overflow when calculating
1763 target_clm and actual_clm.
1764 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1765 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1766 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1767 (coding_alloc_by_making_gap, alloc_destination)
1768 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1769 (encode_coding_utf_16, detect_coding_emacs_mule)
1770 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1771 (detect_coding_iso_2022, decode_coding_iso_2022)
1772 (encode_invocation_designation, encode_designation_at_bol)
1773 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1774 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1775 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1776 (encode_coding_ccl, encode_coding_raw_text)
1777 (detect_coding_charset, decode_coding_charset)
1778 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1779 (produce_composition, produce_charset, produce_annotation)
1780 (decode_coding, handle_composition_annotation)
1781 (handle_charset_annotation, consume_chars, decode_coding_gap)
1782 (decode_coding_object, encode_coding_object, detect_coding_system)
1783 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1784 (code_convert_region, code_convert_string)
8f50130c
PE
1785 (Fdefine_coding_system_internal)
1786 (coding_set_source, coding_set_destination):
d311d28c
PE
1787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1788 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1789 (Fdefine_coding_system_internal):
1790 Don't assume fixnums fit in int.
1791 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1792 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1793 (Funencodable_char_position, Fcheck_coding_systems_region)
1794 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1795 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1796 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1797 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1798 Don't access memory outside of the args array.
d311d28c 1799 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1800 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1801 result of ENCODE_CHAR.
d311d28c
PE
1802 * coding.h: Adjust decls to match defn changes elsewhere.
1803 (struct coding_system):
1804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1805 * composite.c (get_composition_id, find_composition)
1806 (run_composition_function, update_compositions)
1807 (compose_text, composition_gstring_put_cache)
1808 (composition_gstring_p, composition_gstring_width)
1809 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1810 (composition_compute_stop_pos, composition_reseat_it)
1811 (composition_update_it, struct position_record)
1812 (find_automatic_composition, composition_adjust_point)
1813 (Fcomposition_get_gstring, Ffind_composition_internal):
1814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1815 (update_compositions):
1816 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1817 * composite.h: Adjust decls to match defn changes elsewhere.
1818 (struct composition):
1819 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1820 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1821 Do not attempt to compute the address of the object just before a
1822 buffer; this is not portable.
1823 (Faref, Faset):
1824 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1825 (Faset): Use int, not EMACS_INT, where int is wide enough.
1826 (Fstring_to_number): Don't assume fixnums fit in int.
1827 (Frem): Don't assume arg is nonnegative.
1828 * dbusbind.c (xd_append_arg): Check for integers out of range.
1829 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1830 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1831 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1832 (xd_get_connection_references): Return ptrdiff_t, not int.
1833 All uses changed.
1834 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1835 (xd_read_message_1):
1836 Use int, not unsigned, where the dbus API uses int.
1837 (Fdbus_message_internal): Don't overflow mtype.
1838 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1839 * dired.c (directory_files_internal, file_name_completion, scmp)
1840 (file_name_completion_stat):
1841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1842 (file_name_completion): Don't overflow matchcount.
1843 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1844 * dispextern.h: Adjust decls to match defn changes elsewhere.
1845 (struct text_pos, struct glyph, struct bidi_saved_info)
1846 (struct bidi_string_data, struct bidi_it, struct composition_it)
1847 (struct it):
1848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1849 (struct display_pos, struct composition_it, struct it):
1850 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1851 * dispnew.c (increment_matrix_positions)
1852 (increment_row_positions, mode_line_string)
1853 (marginal_area_string):
1854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1855 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1856 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1857 (duration_to_sec_usec): New function, to check for overflow better.
1858 (Fsleep_for, sit_for): Use it.
1859 * doc.c (get_doc_string, store_function_docstring):
1860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1861 (get_doc_string, Fsnarf_documentation):
1862 Use int, not EMACS_INT, where int is wide enough.
1863 (get_doc_string):
1864 Use SAFE_ALLOCA, not alloca.
1865 Check for overflow when converting EMACS_INT to off_t.
1866 * doprnt.c (doprnt):
1867 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1868 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1869 Don't assume uid_t fits into fixnum.
1870 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1871 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1872 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1873 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1874 (general_insert_function)
1875 (Finsert_char, make_buffer_string, make_buffer_string_both)
1876 (update_buffer_properties, Fbuffer_substring)
1877 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1878 (Fsubst_char_in_region, check_translation)
1879 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1880 (transpose_markers, Ftranspose_regions):
1881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1882 (clip_to_bounds): Move to lisp.h as an inline function).
1883 (Fconstrain_to_field): Don't assume integers are nonnegative.
1884 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1885 (Fsubst_char_in_region, Fsave_restriction):
1886 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1887 (Femacs_pid): Don't assume pid_t fits into fixnum.
1888 (lo_time): Use int, not EMACS_INT, when int suffices.
1889 (lisp_time_argument): Check for usec out of range.
1890 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1891 (Fuser_login_name, Fuser_full_name): Signal an error
1892 if a uid argument is out of range, rather than relying on
1893 undefined behavior.
c8d5c857
PE
1894 (Fformat_time_string): Remove now-unnecessary check.
1895 lisp_time_argument checks for out-of-range usec now.
243e0530 1896 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1897 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1898 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1899 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1900 (init_cmdargs, Fdump_emacs):
1901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1902 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1903 the bottom (typically) 32 bits of the fixnum.
1904 * eval.c (specpdl_size, call_debugger):
1905 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1906 (when_entered_debugger, Fbacktrace_debug):
1907 Don't assume fixnum can fit in int.
1908 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1909 the object just before a buffer; this is not portable.
1910 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1911 (grow_specpdl, unbind_to):
1912 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1913 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1914 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1915 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1916 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1917 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1918 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1919 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1920 (a_write, e_write):
1921 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1922 (Fcopy_file, non_regular_nbytes, read_non_regular)
1923 (Finsert_file_contents):
1924 Use int, not EMACS_INT, where int is wide enough.
1925 (READ_BUF_SIZE): Verify that it fits in int.
1926 (Finsert_file_contents): Check that counts are in proper range,
1927 rather than assuming fixnums fit into ptrdiff_t etc.
1928 Don't assume fixnums fit into int.
125b3835 1929 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1930 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1931 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1932 (string_char_to_byte, string_byte_to_char)
1933 (string_make_multibyte, string_to_multibyte)
1934 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1935 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1936 (substring_both, Fdelete, internal_equal, Ffillarray)
1937 (Fclear_string, mapcar1)
1938 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1939 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1940 (larger_vector, make_hash_table, maybe_resize_hash_table)
1941 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1942 (Fmaphash, secure_hash):
1943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1944 (concat): Check for string index and length overflow.
1945 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1946 (Frequire):
1947 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1948 (larger_vector): New API (vec, incr_min, size_max) replaces old
1949 one (vec, new_size, init). This catches size overflow.
1950 INIT was removed because it was always Qnil.
1951 All callers changed.
1952 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1953 the upper bound on a hash table index size.
1954 (make_hash_table, maybe_resize_hash_table): Use it.
1955 (secure_hash): Computer start_byte and end_byte only after
1956 they're known to be in ptrdiff_t range.
1957 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1958 (Ffont_get_glyphs, Ffont_at):
1959 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1960 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1961 (Flist_fonts, Fopen_font):
1962 Don't assume fixnum can fit in int.
1963 (check_gstring): Don't assume index can fit in int.
1964 (font_match_p): Check that fixnum is a character, not a nonnegative
1965 fixnum, since the later code needs to stuff it into an int.
1966 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1967 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1968 conversion overflow issues.
1969 (Fopen_font): Check for integer out of range.
1970 (Ffont_get_glyphs): Don't assume index can fit in int.
1971 * font.h: Adjust decls to match defn changes elsewhere.
1972 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1973 integer overflow.
1974 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1975 printmax_t, where ptrdiff_t is wide enough.
1976 (Finternal_char_font):
1977 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1978 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1979 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1980 (Fset_frame_position, x_set_frame_parameters)
1981 (x_set_line_spacing, x_set_border_width)
1982 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1983 Check that fixnums are in proper range for system types.
1984 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1986 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1987 Use SAFE_ALLOCA_LISP, not alloca.
1988 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1989 intptr_t is wide enough.
1990 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1991 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1992 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1993 Check for fixnum out of range.
1994 * ftfont.c (ftfont_list): Don't assume index fits in int.
1995 Check that fixnums are in proper range for system types.
1996 (ftfont_shape_by_flt):
1997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1998 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2000 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2001 Check that fixnums are in proper range for system types.
2002 * gnutls.h: Adjust decls to match defn changes elsewhere.
2003 * gtkutil.c (xg_dialog_run):
2004 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2005 (update_frame_tool_bar):
2006 Check that fixnums are in proper range for system types.
2007 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2008 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2009 * indent.c (last_known_column, last_known_column_point):
2010 (current_column_bol_cache):
2011 (skip_invisible, current_column, check_display_width):
2012 (check_display_width, scan_for_column, current_column_1)
2013 (Findent_to, Fcurrent_indentation, position_indentation)
2014 (indented_beyond_p, Fmove_to_column, compute_motion):
2015 (Fcompute_motion, Fvertical_motion):
2016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2017 (last_known_column_modified): Use EMACS_INT, not int.
2018 (check_display_width):
2019 (Fcompute_motion):
2020 Check that fixnums and floats are in proper range for system types.
2021 (compute_motion): Don't assume index or fixnum fits in int.
2022 (compute_motion, Fcompute_motion):
2023 Use int, not EMACS_INT, when it is wide enough.
2024 (vmotion): Omit local var start_hpos that is always 0; that way
2025 we don't need to worry about overflow in expressions involving it.
2026 * indent.h: Adjust decls to match defn changes elsewhere.
2027 (struct position):
2028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2029 Use int, not EMACS_INT, where int is wide enough.
2030 Remove unused members ovstring_chars_done and tab_offset;
2031 all uses removed.
2032 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2033 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2034 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2035 (make_gap, copy_text, insert, insert_and_inherit)
2036 (insert_before_markers, insert_before_markers_and_inherit)
2037 (insert_1, count_combining_before, count_combining_after)
2038 (insert_1_both, insert_from_string)
2039 (insert_from_string_before_markers, insert_from_string_1)
2040 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2041 (adjust_after_replace, adjust_after_insert, replace_range)
2042 (replace_range_2, del_range, del_range_1, del_range_byte)
2043 (del_range_both, del_range_2, modify_region)
2044 (prepare_to_modify_buffer, signal_before_change)
2045 (signal_after_change, Fcombine_after_change_execute):
2046 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2047 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2048 (balance_an_interval, split_interval_right, split_interval_left)
2049 (find_interval, next_interval, update_interval)
2050 (adjust_intervals_for_insertion, delete_node, delete_interval)
2051 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2052 (static_offset_intervals, offset_intervals)
2053 (merge_interval_right, merge_interval_left, make_new_interval)
2054 (graft_intervals_into_buffer, temp_set_point_both)
2055 (temp_set_point, set_point, adjust_for_invis_intang)
2056 (set_point_both, move_if_not_intangible, get_property_and_range)
2057 (get_local_map, copy_intervals, copy_intervals_to_string)
2058 (compare_string_intervals, set_intervals_multibyte_1):
2059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2060 * intervals.h: Adjust decls to match defn changes elsewhere.
2061 (struct interval):
2062 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2063 * keyboard.c (this_command_key_count, this_single_command_key_start)
2064 (before_command_key_count, before_command_echo_length, echo_now)
2065 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2066 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2067 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2068 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2069 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2070 (last_non_minibuf_size, last_point_position, echo_truncate)
2071 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2072 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2073 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2074 (stuff_buffered_input):
2075 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2076 (last_auto_save, command_loop_1, read_char):
2077 Use EMACS_INT, not int, to avoid integer overflow.
2078 (record_char): Avoid overflow in total_keys computation.
2079 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2080 * keyboard.h: Adjust decls to match defn changes elsewhere.
2081 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2082 (Fkey_description, Fdescribe_vector, Flookup_key):
2083 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2084 (click_position): New function, to check that positions are in range.
2085 (Fcurrent_active_maps):
2086 (describe_command):
2087 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2088 (Faccessible_keymaps, Fkey_description):
2089 (preferred_sequence_p):
2090 Don't assume fixnum can fit into int.
2091 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2092 Check for integer overflow in size calculations.
2093 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2094 avoid mishandling large integers.
2095 * lisp.h: Adjust decls to match defn changes elsewhere.
2096 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2097 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2098 (struct Lisp_Marker):
2099 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2100 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2101 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2102 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2103 All callers changed.
2104 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2105 Assume the arg has valid form, since it always does.
2106 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2107 unsigned integer system type.
2108 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2109 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2110 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2111 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2112 (duration_to_sec_usec): New decl.
2113 * lread.c (read_from_string_index, read_from_string_index_byte)
2114 (read_from_string_limit, readchar, unreadchar, openp)
2115 (read_internal_start, read1, oblookup):
2116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2117 (Fload, readevalloop, Feval_buffer, Feval_region):
2118 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2119 (openp): Check for out-of-range argument to 'access'.
2120 (read1): Use int, not EMACS_INT, where int is wide enough.
2121 Don't assume fixnum fits into int.
6efdadfd 2122 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2123 (read_filtered_event): Use duration_to_sec_usec
2124 to do proper overflow checking on durations.
d311d28c
PE
2125 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2126 in size calculation.
2127 (Fexecute_kbd_macro):
2128 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2129 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2130 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2131 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2132 (set_marker_both, set_marker_restricted_both, marker_position)
2133 (marker_byte_position, Fbuffer_has_markers_at):
2134 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2135 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2136 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2137 It now merely ensures that the menu is large enough, without
2138 necessarily growing it, as this avoids some integer overflow issues.
2139 All callers changed.
2140 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2141 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2142 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2143 Use SAFE_ALLOCA_LISP, not alloca.
2144 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2145 to EMACS_INT. Check that fixnums are in proper range for system types.
2146 * minibuf.c (minibuf_prompt_width, string_to_object)
2147 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2148 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2150 (get_minibuffer, read_minibuf_unwind):
2151 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2152 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2153 this simplifies overflow checking. All callers changed.
2154 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2155 (Ftest_completion):
2156 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2157 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2158 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2159 Check that fixnums are in proper range for system types.
2160 (Fx_create_frame, Fx_show_tip):
2161 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2162 * nsfont.m (ns_findfonts, nsfont_list_family):
2163 Don't assume fixnum fits in long.
2164 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2165 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2166 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2167 wide enough.
17fdb222 2168 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2169 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2170 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2171 (PRINTDECLARE, PRINTPREPARE):
2172 (strout, print_string):
2173 (print, print_preprocess, print_check_string_charset_prop)
2174 (print_object):
2175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2176 (PRINTDECLARE):
2177 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2178 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2179 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2180 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2181 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2182 (print_error_message): Use SAFE_ALLOCA, not alloca.
2183 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2184 (print_depth, new_backquote_output, print_number_index):
2185 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2186 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2187 (Fset_process_window_size, Fformat_network_address)
2188 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2189 (sigchld_handler):
d311d28c 2190 Check that fixnums are in proper range for system types.
d44287d4 2191 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2192 Check for process-ids out of pid_t range rather than relying on
2193 undefined behavior.
e4d81efc 2194 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2195 (Fformat_network_address, read_process_output, send_process)
2196 (Fprocess_send_region, status_notify):
2197 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2198 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2199 (wait_reading_process_output, read_process_output, exec_sentinel):
2200 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2201 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2202 (Faccept_process_output): Use duration_to_sec_usec to do proper
2203 overflow checking on durations.
dde14581
PE
2204 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2205 Don't assume pid_t fits in int.
02481186
PE
2206 * process.h (struct Lisp_Process): Members tick and update_tick
2207 are now of type EMACS_INT, not int.
b62b53e8
PE
2208 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2209 configured --with-wide-int.
d311d28c
PE
2210 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2211 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2212 * search.c (looking_at_1, string_match_1):
2213 (fast_string_match, fast_c_string_match_ignore_case)
2214 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2215 (scan_newline, find_before_next_newline, search_command)
2216 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2217 (set_search_regs, wordify):
2218 (Freplace_match):
2219 (Fmatch_data):
2220 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2221 (string_match_1, search_buffer, set_search_regs):
2222 (Fmatch_data):
2223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2224 (wordify): Check for overflow in size calculation.
2225 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2226 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2227 Check that fixnums are in proper range for system types.
2228 * sound.c (struct sound_device)
2229 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2231 (Fplay_sound_internal):
2232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2233 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2234 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2235 (Fparse_partial_sexp):
2236 Don't assume fixnums can fit in int.
2237 (struct lisp_parse_state, find_start_pos, find_start_value)
2238 (find_start_value_byte, find_start_begv)
2239 (update_syntax_table, char_quoted, dec_bytepos)
2240 (find_defun_start, prev_char_comend_first, back_comment):
2241 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2242 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2243 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2244 (Finternal_describe_syntax_value): Check that match_lisp is a
2245 character, not an integer, since the code stuffs it into int.
2246 (scan_words, scan_sexps_forward):
2247 Check that fixnums are in proper range for system types.
2248 (Fforward_word):
2249 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2250 (scan_sexps_forward):
2251 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2252 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2253 * syntax.h: Adjust decls to match defn changes elsewhere.
2254 (struct gl_state_s):
2255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2256 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2257 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2258 * sysdep.c (wait_for_termination_1, wait_for_termination)
2259 (interruptible_wait_for_termination, mkdir):
2260 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2261 (emacs_read, emacs_write):
2262 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2263 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2264 and double all fit in int.
d311d28c
PE
2265 * term.c (set_tty_color_mode):
2266 Check that fixnums are in proper range for system types.
2267 * termhooks.h (struct input_event):
2268 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2269 * textprop.c (validate_interval_range, interval_of)
2270 (Fadd_text_properties, set_text_properties_1)
2271 (Fremove_text_properties, Fremove_list_of_text_properties)
2272 (Ftext_property_any, Ftext_property_not_all)
2273 (copy_text_properties, text_property_list, extend_property_ranges)
2274 (verify_interval_modification):
2275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2276 (Fnext_single_char_property_change)
2277 (Fprevious_single_char_property_change):
2278 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2279 (copy_text_properties):
2280 Check for integer overflow in index calculation.
d311d28c
PE
2281 * undo.c (last_boundary_position, record_point, record_insert)
2282 (record_delete, record_marker_adjustment, record_change)
2283 (record_property_change):
2284 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2285 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2286 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2287 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2288 (Fx_hide_tip, Fx_file_dialog):
2289 * w32menu.c (set_frame_menubar):
2290 Use ptrdiff_t, not int, for consistency with rest of code.
2291 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2292 (select_window, Fdelete_other_windows_internal)
2293 (window_scroll_pixel_based, window_scroll_line_based)
2294 (Frecenter, Fset_window_configuration):
2295 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2296 (Fset_window_hscroll, run_window_configuration_change_hook)
2297 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2298 (Fscroll_other_window, Frecenter):
d311d28c
PE
2299 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2300 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2301 Don't assume fixnum fits in int.
2302 (Fset_window_scroll_bars):
2303 Check that fixnums are in proper range for system types.
2304 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2305 (string_pos, c_string_pos, number_of_chars, init_iterator)
2306 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2307 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2308 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2309 (face_before_or_after_it_pos, handle_invisible_prop)
2310 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2311 (display_prop_intangible_p, string_buffer_position_lim)
2312 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2313 (get_overlay_strings_1, get_overlay_strings)
2314 (iterate_out_of_display_property, forward_to_next_line_start)
2315 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2316 (get_next_display_element, set_iterator_to_next)
2317 (get_visually_first_element, compute_stop_pos_backwards)
2318 (handle_stop_backwards, next_element_from_buffer)
2319 (move_it_in_display_line_to, move_it_in_display_line)
2320 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2321 (add_to_log, message_dolog, message_log_check_duplicate)
2322 (message2, message2_nolog, message3, message3_nolog
2323 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2324 (current_message_1, truncate_echo_area, truncate_message_1)
2325 (set_message, set_message_1, store_mode_line_noprop)
2326 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2327 (text_outside_line_unchanged_p, check_point_in_composition)
2328 (reconsider_clip_changes)
2329 (redisplay_internal, set_cursor_from_row, try_scrolling)
2330 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2331 (redisplay_window, find_last_unchanged_at_beg_row)
2332 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2333 (trailing_whitespace_p, find_row_edges, display_line)
2334 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2335 (display_mode_element, store_mode_line_string)
2336 (pint2str, pint2hrstr, decode_mode_spec)
2337 (display_count_lines, display_string, draw_glyphs)
2338 (x_produce_glyphs, x_insert_glyphs)
2339 (rows_from_pos_range, mouse_face_from_buffer_pos)
2340 (fast_find_string_pos, mouse_face_from_string_pos)
2341 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2343 (safe_call, init_from_display_pos, handle_fontified_prop)
2344 (handle_single_display_spec, load_overlay_strings)
2345 (with_echo_area_buffer, setup_echo_area_for_printing)
2346 (display_echo_area, echo_area_display)
2347 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2348 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2349 (redisplay_window, dump_glyph_row, display_mode_line)
2350 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2351 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2352 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2353 (handle_single_display_spec, build_desired_tool_bar_string)
2354 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2355 (get_specified_cursor_type):
2356 Check that fixnums are in proper range for system types.
2357 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2358 (Flookup_image_map):
2359 Don't assume fixnums fit in int.
2360 (compare_overlay_entries):
2361 Avoid mishandling comparisons due to subtraction overflow.
2362 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2363 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2364 (handle_tool_bar_click):
2365 Use int, not unsigned, since we prefer signed and the signedness
2366 doesn't matter here.
2367 (get_next_display_element, next_element_from_display_vector):
2368 Use int, not EMACS_INT, when int is wide enough.
2369 (start_hourglass): Use duration_to_sec_usec to do proper
2370 overflow checking on durations.
2371 * xfaces.c (Fbitmap_spec_p):
2372 Check that fixnums are in proper range for system types.
2373 (compare_fonts_by_sort_order):
2374 Avoid mishandling comparisons due to subtraction overflow.
2375 (Fx_family_fonts, realize_basic_faces):
2376 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2377 (Fx_family_fonts):
2378 Don't assume fixnum fits in int.
2379 Use SAFE_ALLOCA_LISP, not alloca.
2380 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2381 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2382 (face_at_buffer_position, face_for_overlay_string)
2383 (face_at_string_position):
2384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2385 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2386 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2387 (Fx_show_tip):
2388 Check that fixnums are in proper range for system types.
2389 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2390 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2391 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2392 (Fx_change_window_property): Don't assume fixnums fit in int.
2393 * xfont.c (xfont_chars_supported):
2394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2395 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2396 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2397 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2398 * xml.c (parse_region):
2399 * xrdb.c (magic_file_p):
2400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2401 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2402 (x_get_local_selection, x_reply_selection_request)
2403 (x_handle_selection_request, wait_for_property_change):
2404 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2405 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2406 short is wide enough.
2407 (x_send_client_event): Don't assume fixnum fits in int.
2408 * xterm.c (x_x_to_emacs_modifiers):
2409 Don't assume EMACS_INT overflows nicely into int.
2410 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2411 may come from Lisp.
2412 (handle_one_xevent): NATNUMP can eval its arg twice.
2413 (x_connection_closed):
2414 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2415 * xterm.h: Adjust decls to match defn changes elsewhere.
2416 (struct scroll_bar): Use struct vectorlike_header
2417 rather than rolling our own approximation.
2418 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2419
c6574eb5
GM
24202012-05-25 Glenn Morris <rgm@gnu.org>
2421
2422 * lisp.mk (lisp): Update for more files being compiled now.
2423
e8d32c7e
SM
24242012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2425
48def666
SM
2426 * lread.c: Remove `read_pure' which makes no difference.
2427 (read_pure): Remove var.
2428 (unreadpure): Remove function.
2429 (readevalloop): Don't call read_list with -1 flag.
2430 (read1, read_vector): Don't test read_pure any more.
2431 (read_list): Simplify.
2432
e8d32c7e
SM
2433 * fileio.c, character.h: Minor style tweaks.
2434
4b2addb7
DA
24352012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2436
2437 * window.h (clip_changed): Remove useless declaration.
2438
584461b2
JB
24392012-05-22 Juanma Barranquero <lekktu@gmail.com>
2440
2441 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2442 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2443
34374650
PE
24442012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2445
2446 Remove src/m/*.
2447 This directory predates autoconf and is no longer needed nowadays.
2448 Move its few remaining bits of functionality to where they're needed.
2449 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2450 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2451 * m/template.h: Remove.
2452 * Makefile.in (M_FILE): Remove. All uses removed.
2453 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2454 * lisp.h (USE_LSB_TAG):
2455 * mem-limits.h (EXCEEDS_LISP_PTR):
2456 Use VAL_MAX, not VALBITS, in #if.
2457 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2458 (EMACS_UINT): Define unconditionally now.
2459 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2460 (BITS_PER_EMACS_INT): New constants, replacing
2461 what used to be in config.h, but not useful in #if.
2462 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2463 define them any more.
2464 (VAL_MAX): New macro.
2465 (VALMASK): Use it.
2466 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2467 BITS_PER_EMACS_INT, in #if.
2468 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2469 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2470 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2471 * s/ms-w32.h (DATA_START):
2472 Move here from removed file m/intel386.h.
2473 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2474 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2475
261cb4bb
PE
24762012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2477
2478 Assume C89 or later.
2479 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2480 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2481 (xrealloc):
2482 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2483 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2484 * textprop.c, tparam.c (NULL): Remove.
2485 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2486 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2487 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2488 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2489 * xterm.c (input_signal_count): Assume volatile works.
2490
ff23cd9f
KB
24912012-05-21 Ken Brown <kbrown@cornell.edu>
2492
2493 * xgselect.c (xg_select): Fix first argument in call to 'select'
2494 (bug#11508).
2495
1b170bc6
KB
24962012-05-20 Ken Brown <kbrown@cornell.edu>
2497
2498 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2499 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2500
b2f4d39f
KB
25012012-05-19 Ken Brown <kbrown@cornell.edu>
2502
2503 * xfns.c (x_in_use): Remove `static' qualifier.
2504 * xterm.h (x_in_use): Declare.
2505 * xgselect.c: Include xterm.h.
2506 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2507 and `display_arg' (bug#9754).
2508
003fdae2
PE
25092012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2510
9232a6d9
PE
2511 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2512
003fdae2
PE
2513 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2514 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2515
784b56e2
EZ
25162012-05-18 Eli Zaretskii <eliz@gnu.org>
2517
2518 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2519
2520 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2521 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2522
2523 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2524 reference to image_cache->refcount.
2525 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2526
a0a79cde
JL
25272012-05-17 Juri Linkov <juri@jurta.org>
2528
2529 * search.c (Fword_search_regexp, Fword_search_backward)
2530 (Fword_search_forward, Fword_search_backward_lax)
2531 (Fword_search_forward_lax): Move functions to isearch.el
2532 (bug#10145, bug#11381).
2533
b0572523
PE
25342012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2535
2536 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2537
9660f5fc
SM
25382012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2539
2540 * lread.c (init_obarray): Declare Qt and Qnil as special.
2541
4374de83
GM
25422012-05-14 Glenn Morris <rgm@gnu.org>
2543
2544 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2545 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2546
dc44c39a
PE
25472012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2548
078c97cb
PE
2549 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2550
dc44c39a
PE
2551 * unexaix.c: Port to more-recent AIX compilers.
2552 (report_error, report_error_1, make_hdr, copy_sym)
2553 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2554 Make arguments const char *, not char *, to avoid violations of C
2555 standard and to fix some AIX warnings reported by Gilles Pion.
2556
e18afed7 25572012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2558
2559 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2560 already have overlays loaded.
2561 (handle_single_display_spec): Before returning without displaying
2562 fringe bitmap, synchronize the bidi iterator with the main display
2563 iterator, by calling iterate_out_of_display_property.
2564 (iterate_out_of_display_property): Detect buffer iteration by
2565 testing that it->string is a Lisp string.
2566 (get_next_display_element): When the current object is exhausted,
2567 and there's something on it->stack, call set_iterator_to_next to
2568 proceed with what's on the stack, instead of returning zero.
2569 (set_iterator_to_next): If called at the end of a Lisp string,
2570 proceed to consider_string_end without incrementing string
2571 position. Don't increment display vector index past the end of
2572 the display vector. (Bug#11417)
c8fb9dc6
EZ
2573 (pos_visible_p): Don't report a position visible when move_it_to
2574 stopped at the last line of window, which happens to be scanned
2575 backwards by the bidi iteration. (Bug#11464)
ac268e67 2576
e18afed7 25772012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2578
2579 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2580 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2581 are on a TTY, and thus unable to display on the fringes.
2582 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2583 so we need to signal to the caller that this is a "replacing"
2584 display spec. This fixes display when the spec is invalid or we
2585 are on a TTY.
2586
e18afed7 25872012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2588
2589 * unexaix.c (make_hdr): Fix typo in prototype.
2590 This bug broke the build on AIX. Problem reported by Gilles Pion.
2591
9d0a235a
MA
25922012-05-14 Michael Albinus <michael.albinus@gmx.de>
2593
2594 * keyboard.c (kbd_buffer_get_event): Read special events also in
2595 batch mode. (Bug#11415)
2596
9e6b06ed
GM
25972012-05-12 Glenn Morris <rgm@gnu.org>
2598
2599 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2600
c1a1d7a3
EZ
26012012-05-12 Eli Zaretskii <eliz@gnu.org>
2602
2603 * lisp.mk (lisp): Add newcomment.elc.
2604
3fe7cdc8
GM
26052012-05-12 Glenn Morris <rgm@gnu.org>
2606
2607 * Makefile.in (MKDIR_P): New, set by configure.
2608 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2609
53f7d2c0
PE
26102012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2611
2612 Remove unused function hourglass_started.
2613 * dispextern.h (hourglass_started):
2614 * w32fns.c (hourglass_started):
2615 * xdisp.c (hourglass_started): Remove.
2616
75aafb17
JB
26172012-05-10 Juanma Barranquero <lekktu@gmail.com>
2618
2619 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2620 Update dependencies.
2621
12959e8e
PE
26222012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2623
97107e2e
PE
2624 * xgselect.c (xg_select): Put maxfds+1 into a var.
2625 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2626
12959e8e
PE
2627 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2628
836d29b3
DA
26292012-05-10 Dave Abrahams <dave@boostpro.com>
2630
2631 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2632 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2633
5cb67954
MA
26342012-05-09 Michael Albinus <michael.albinus@gmx.de>
2635
2636 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2637 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2638 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2639 Initialize xd_registered_buses.
2640
3478ec45
PE
26412012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2642
b263a6b0
PE
2643 Untag more efficiently if USE_LSB_TAG.
2644 This is based on a proposal by YAMAMOTO Mitsuharu in
2645 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2646 For an admittedly artificial (nth 8000 longlist) benchmark on
2647 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2648 Emacs's overall text size by 1%.
2649 * lisp.h (XUNTAG): New macro.
2650 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2651 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2652 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2653 * eval.c (Fautoload):
2654 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2655 * frame.h (XFRAME): Use XUNTAG.
2656
3478ec45
PE
2657 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2658 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2659 Remove unportable assumptions about print widths of types like
2660 dbus_uint32_t.
2661 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2662 intptr_t when converting between pointer and integer, to avoid GCC
2663 warnings about wrong width.
2664
666b903b 26652012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2666
2667 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2668 stack for each reader_thread, instead of defaulting to 8MB
2669 determined by the linker. This avoids failures in creating
2670 subprocesses on Windows 7, see the discussion in this thread:
2671 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2672
b120cc17
JC
26732012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2674
2675 Fix up display of the *Minibuf-0* buffer in the mini window.
2676 * keyboard.c (read_char): Don't clear the echo area if there's no
2677 message to clear.
2678 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2679 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2680
9a4b36f8
MA
26812012-05-07 Michael Albinus <michael.albinus@gmx.de>
2682
2683 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2684 batch mode.
2685
e5f9458f
CY
26862012-05-06 Chong Yidong <cyd@gnu.org>
2687
2688 * lisp.mk (lisp): Update.
2689
eceeb5fc 26902012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2691
2692 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2693
71873e2b
SM
26942012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2695
2696 * data.c (PUT_ERROR): New macro.
2697 (syms_of_data): Use it. Add new error type `user-error'.
2698 * undo.c (user_error): New function.
2699 (Fprimitive_undo): Use it.
2700 * print.c (print_error_message): Adjust print style for `user-error'.
2701 * keyboard.c (user_error): New function.
2702 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2703
ab0fa4e4
PE
27042012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2705
2706 Do not limit current-time-string to years 1000..9999.
2707 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2708 (Fcurrent_time_string): Support any year that is supported by the
2709 underlying localtime representation. Don't use asctime, as it
2710 has undefined behavior for years outside the range -999..9999.
2711
7ed806a7
PE
27122012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2713
2714 Fix race conditions involving setenv, gmtime, localtime, asctime.
2715 Without this fix, interrupts could mess up code that uses these
2716 nonreentrant functions, since setting TZ invalidates existing
2717 tm_zone or tzname values, and since most of these functions return
2718 pointers to static storage.
2719 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2720 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2721 Grow the critical sections to include not just invoking
2722 localtime/gmtime, but also accessing these functions' results
2723 including their tm_zone values if any, and any related TZ setting.
2724 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2725 so that the struct tm is saved in the critical section.
2726 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2727 motivated by the fact that memory allocation needs to be outside
2728 the critical section.
2729
0c16dfed
DA
27302012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2731
2732 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2733 with RESET_INTERVAL.
2734
2735 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2736 Remove duplicated buffer name initialization.
2737
3f83ace8
JM
27382012-05-02 Jim Meyering <jim@meyering.net>
2739
2740 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2741
c7b8541e
JM
2742 * xfns.c (x_window): Use xstrdup (Bug#11375).
2743
90207a15 27442012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2745
2746 * xdisp.c (pos_visible_p): If already at a newline from the
2747 display string before the 'while' loop, don't walk back the glyphs
2748 from it3.glyph_row. Solves assertion violation when the display
2749 string begins with a newline (egg.el). (Bug#11367)
2750
b593d6a9
AH
27512012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2752
2753 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2754 Move to simple.el.
2755
4737362e
GM
27562012-05-01 Glenn Morris <rgm@gnu.org>
2757
99cf43f9
GM
2758 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2759 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2760 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2761 All were removed before 23.1.
2762
9311dcff
GM
2763 * dispnew.c: Remove HAVE_LIBNCURSES test;
2764 it is always true on relevant platforms.
2765
4d5c6349
GM
2766 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2767 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2768
4737362e
GM
2769 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2770
74dd3a6b
AS
27712012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2772
2773 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2774 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2775 Remove.
2776
13c379ee
PE
27772012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2778
2779 Do not avoid creating empty evaporating overlays (Bug#9642).
2780 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2781 That is, do not delete an evaporating overlay if it becomes
2782 empty after its bounds are adjusted to fit within its buffer.
2783 This fix caused other problems, and I'm reverting it until we get
2784 to the bottom of them.
2785
a8e7d6d7 27862012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2787
2788 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2789
a8e7d6d7 27902012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2791
2792 * xdisp.c (pos_visible_p): If the window start position is beyond
2793 ZV, start the display from buffer beginning. Prevents assertion
2794 violation in init_iterator when the minibuffer window is scrolled
2795 via the scroll bar.
2796
2797 * window.c (window_scroll_pixel_based): Likewise.
2798
a8e7d6d7 27992012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2800
2801 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2802
a8e7d6d7 28032012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2804
2805 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2806 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2807
a8e7d6d7 28082012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2809
b593d6a9
AH
2810 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2811 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2812
1c6900d9
EZ
28132012-04-26 Eli Zaretskii <eliz@gnu.org>
2814
4c3fa1d9
EZ
2815 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2816 display element, check also the underlying string or buffer
2817 character. (Bug#11341)
2818
1c6900d9
EZ
2819 * w32menu.c: Include w32heap.h.
2820 (add_menu_item): If the call to AppendMenuW (via
2821 unicode_append_menu) fails, disable Unicode menus only if we are
2822 running on Windows 9X/Me.
2823
42bf8205
AS
28242012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2825
2826 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2827 (xgetint): Add missing shift for LSB tags.
2828
b1bac16e
MR
28292012-04-24 Martin Rudalics <rudalics@gmx.at>
2830
2831 * keyboard.c (read_char): Don't wipe echo area for select window
2832 events: These might get delayed via `mouse-autoselect-window'
2833 (Bug#11304).
2834
d69621cc
JB
28352012-04-24 Juanma Barranquero <lekktu@gmail.com>
2836
2837 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2838 manipulation of :loaded-from data.
2839
02fd101b
JB
28402012-04-23 Juanma Barranquero <lekktu@gmail.com>
2841
2842 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2843 now a cons (bug#11311).
2844
888bec30
PE
28452012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2846
89a438bd
PE
2847 Do not create empty overlays with the evaporate property (Bug#9642).
2848 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2849 if it becomes empty after its bounds are adjusted to fit within
2850 its buffer. Without this fix, in a nonempty buffer (let ((o
2851 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2852 yields an empty overlay that has the evaporate property, which is
2853 not supposed to happen.
2854
1068fe4d
PE
2855 Fix minor GTK3 problems found by static checking.
2856 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2857 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2858 (struct _EmacsFixedClass, emacs_fixed_get_type):
2859 Move decls here from emacsgtkfixed.h, since they needn't be public.
2860 (emacs_fixed_get_type): Now static.
2861 (emacs_fixed_class_init): Omit unused local.
2862 (emacs_fixed_child_type): Remove; unused.
2863 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2864 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2865 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2866 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2867 (EMACS_FIXED_GET_CLASS): Remove; unused.
2868 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2869
888bec30
PE
2870 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2871 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2872
de85e130
PE
28732012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2874
d0baac98 2875 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2876 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2877 (__malloc_size_t, __malloc_ptrdiff_t):
2878 Remove. All uses removed, replaced by the definiens if needed,
2879 since we can assume C89 or better now.
2880 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2881 (protect_malloc_state, align, get_contiguous_space)
2882 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2883 (malloc_atfork_handler_child, malloc_enable_thread)
2884 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2885 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2886 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2887 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2888 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2889 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2890 Define using prototypes, not old style.
2891 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2892 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2893 (align): Don't assume that signed integer overflow wraps around.
2894 Omit unused local var.
2895 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2896 (_free_internal_nolock, memalign, mallochook, reallochook):
2897 Omit no-longer-needed casts.
2898 (valloc): Use getpagesize, not __getpagesize.
2899 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2900 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2901
de85e130
PE
2902 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2903
dcbf5805
MA
29042012-04-22 Michael Albinus <michael.albinus@gmx.de>
2905
2906 Move functions from C to Lisp. Make non-blocking method calls
2907 the default. Implement further D-Bus standard interfaces.
2908
2909 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2910 (QCdbus_request_name_allow_replacement)
2911 (QCdbus_request_name_replace_existing)
2912 (QCdbus_request_name_do_not_queue)
2913 (QCdbus_request_name_reply_primary_owner)
2914 (QCdbus_request_name_reply_in_queue)
2915 (QCdbus_request_name_reply_exists)
2916 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2917 (QCdbus_registered_serial, QCdbus_registered_method)
2918 (QCdbus_registered_signal): New Lisp objects.
2919 (XD_DEBUG_MESSAGE): Use sizeof.
2920 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2921 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2922 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2923 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2924 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2925 (xd_signature, xd_append_arg): Allow float for integer types.
2926 (xd_get_connection_references): New function.
b593d6a9
AH
2927 (xd_get_connection_address): Rename from xd_initialize.
2928 Return cached address.
dcbf5805
MA
2929 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2930 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2931 level.
2932 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2933 Return number of refcounts.
dcbf5805
MA
2934 (Fdbus_get_unique_name): Make stronger parameter check.
2935 (Fdbus_message_internal): New defun.
2936 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2937 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2938 (Fdbus_send_signal, Fdbus_register_service)
2939 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2940 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2941 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2942 (Vdbus_compiled_version, Vdbus_runtime_version)
2943 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2944 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2945 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2946 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2947 Adapt docstring.
dcbf5805 2948
52828e02
PE
29492012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2950
da05bc4c
PE
2951 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2952 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2953 Do not assume ptrdiff_t is the same width as 'int'.
2954
52828e02
PE
2955 * alloc.c: Handle unusual debugging option combinations.
2956 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2957 since the two debugging options are incompatible.
2958 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2959 is defined.
2960 (mem_init, mem_insert, mem_insert_fixup):
2961 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2962 (NEED_MEM_INSERT): Remove; no longer needed.
2963
f01769f9
LL
29642012-04-22 Leo Liu <sdl.web@gmail.com>
2965
2966 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2967
5790543d
PE
29682012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2969
2970 * sysdep.c [__FreeBSD__]: Minor cleanups.
2971 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2972 Use Emacs indenting style more consistently. Avoid some casts.
2973 Use 'double' consistently rather than mixing 'float' and 'double'.
2974
b91b7e4d
EW
29752012-04-21 Eduard Wiebe <usenet@pusto.de>
2976
b593d6a9
AH
2977 * sysdep.c (list_system_processes, system_process_attributes):
2978 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2979
6114eb15
AS
29802012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2981
2982 * lisp.mk (lisp): Update.
2983
2f38dff7
PE
29842012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2985
2986 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2987 It is never used otherwise.
2988
4ae29f89
SM
29892012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2990
2991 * print.c (print_preprocess): Only check print_depth if print-circle
2992 is nil.
2993 (print_object): Check for cycles even when print-circle is nil and
2994 print-gensym is t, but only check print_depth if print-circle is nil.
2995
f30d612a
CY
29962012-04-20 Chong Yidong <cyd@gnu.org>
2997
2998 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2999 set the status to "failed" and ensure that sentinel is run.
3000
c07a4c0b 30012012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3002
3003 * process.c (Fset_process_inherit_coding_system_flag)
3004 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3005 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3006
c07a4c0b 30072012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3008
3009 * xdisp.c (string_buffer_position_lim): Limit starting position to
3010 BEGV.
3011 (set_cursor_from_row): If called for a mode-line or header-line
3012 row, return zero immediately.
3013 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3014 farther than the first row after the header line, if any.
3015 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3016 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3017
c07a4c0b 30182012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3019
4ae29f89
SM
3020 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3021 (bug#11238).
ad3a2b41 3022
c07a4c0b 30232012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 30242012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3025
3026 configure: new option --enable-gcc-warnings (Bug#11207)
3027 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3028 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3029 (ALL_CFLAGS): Use new macros rather than old.
3030 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3031 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3032 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3033 -Wunused-result, -Wunused-variable. This should go away once
3034 the Emacs and Gnulib regex code is merged.
3035 (xmalloc, xrealloc): Now static.
3036
aba027e8
PE
30372012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3038
3039 * dired.c (Fsystem_groups): Remove unused local.
3040
e5a36063
GM
30412012-04-17 Glenn Morris <rgm@gnu.org>
3042
3043 * dired.c (Fsystem_users): Doc fix.
3044
316411f0
DA
30452012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3046
3047 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3048 (syms_of_dired): Add them.
3049
9426aba4
PE
30502012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3051
b62a57be
PE
3052 Fix minor alloc.c problems found by static checking.
3053 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3054 New extern decls, to avoid calling undeclared functions.
3055 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3056 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3057 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3058 (NEED_MEM_INSERT): New macro.
3059 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3060 Remove one incorrect comment and fix another.
b62a57be 3061
3539f31f
PE
3062 Fix minor ralloc.c problems found by static checking.
3063 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3064 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3065 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3066 (r_alloc_sbrk): Now static.
3067
a041960a
PE
3068 Improve ralloc.c interface checking.
3069 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3070 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3071 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3072 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3073 [REL_ALLOC]: ... to here, to check interface.
3074 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3075 Remove decls. This fixes an "It stinks!".
3076
9426aba4
PE
3077 * alloc.c (which_symbols): Fix alignment issue / type clash.
3078
d55c12ed
AS
30792012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3080
3081 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3082 (struct Lisp_Misc_Any): Likewise.
3083 (struct Lisp_Free): Likewise.
3084 * alloc.c (union aligned_Lisp_Symbol): Define.
3085 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3086 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3087 (union aligned_Lisp_Misc): Define.
3088 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3089 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3090 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3091
b948ce8b
PE
30922012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3093
3094 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3095 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3096 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3097 * s/netbsd.h, s/sol2-6.h:
3098 Remove definition of GC_MARK_STACK, since the default now works.
3099 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3100 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3101 no longer the default.
3102 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3103
35dc09a1 31042012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3105
35dc09a1
GM
3106 * lread.c (lisp_file_lexically_bound_p):
3107 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3108
35dc09a1
GM
31092012-04-14 Eli Zaretskii <eliz@gnu.org>
3110
3111 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3112 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3113
31142012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3115
3116 * nsterm.m (constrainFrameRect): Always constrain when there is only
3117 one screen (Bug#10962).
3118
bcd86815
KB
31192012-04-13 Ken Brown <kbrown@cornell.edu>
3120
3121 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3122
c25df26e
RT
31232012-04-13 Reuben Thomas <rrt@sc3d.org>
3124
3125 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3126
0fc59f1e
DC
31272012-04-11 Daniel Colascione <dancol@dancol.org>
3128
3129 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3130 against is gone. It's better to use vfork now so that when Cygwin
3131 gains a new, working vfork, we use it automatically (bug#10398).
3132
de8c03dc
SM
31332012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3134
3135 * window.c (save_window_save): Obey window-point-insertion-type.
3136
2f097256
GM
31372012-04-11 Glenn Morris <rgm@gnu.org>
3138
3139 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3140
453b951e
SM
31412012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3142
3143 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3144
75f1671a 31452012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3146
3147 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3148 (force_quit_count): New var.
3149 (handle_interrupt): Use it.
3150
2a8ce227
JB
31512012-04-10 Juanma Barranquero <lekktu@gmail.com>
3152
3153 * w32.c (w32_delayed_load): Record the full path of the library
3154 being loaded (bug#10424).
3155
935396c0
GM
31562012-04-09 Glenn Morris <rgm@gnu.org>
3157
05920a43
GM
3158 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3159 not just in the obarray, before snarfing them. (Bug#11036)
3160
935396c0
GM
3161 * Makefile.in ($(leimdir)/leim-list.el):
3162 Pass EMACS rather than BUILT_EMACS.
3163
a18ecafa
TZ
31642012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3165
3166 * process.c (make_process):
3167 * process.h: Add integer `gnutls_handshakes_tried' member to
3168 process struct.
3169
6bbef4e5
JC
3170 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3171 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3172
3173 * gnutls.c (gnutls_log_function2i): Convenience log function.
3174 (emacs_gnutls_read): Use new log functions,
3175 `gnutls_handshakes_tried' process member, and
3176 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3177 attempts per process (connection).
3178
b4d3bc10
CY
31792012-04-09 Chong Yidong <cyd@gnu.org>
3180
3181 * eval.c (Fuser_variable_p, user_variable_p_eh)
3182 (lisp_indirect_variable): Functions deleted.
3183 (Fdefvar): Caller changed.
3184
3185 * callint.c (Finteractive, Fcall_interactively):
3186 * minibuf.c (Fread_variable): Callers changed.
3187
70f4d973
EZ
31882012-04-09 Eli Zaretskii <eliz@gnu.org>
3189
3190 * xdisp.c (set_cursor_from_row): If the display string appears in
3191 the buffer at position that is closer to point than the position
3192 after the display string, display the cursor on the first glyph of
3193 the display string. Fixes cursor display when a 'display' text
3194 property immediately follows invisible text. (Bug#11094)
3195
cb3c2e3e
PE
31962012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3197
3198 composite.c: use 'double' consistently
3199 * composite.c (get_composition_id): Use 'double' consistently
3200 instead of converting 'float' to 'double' and vice versa; this is
3201 easier to understand and avoids a GCC warning.
3202
fd06db5d
GM
32032012-04-09 Glenn Morris <rgm@gnu.org>
3204
50fe702a
GM
3205 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3206 preparation for dumping it with emacs. (Bug#4789)
3207 (leimdir): New variable.
3208 ($(leimdir)/leim-list.el): New rule.
3209 (emacs$(EXEEXT)): Depend on leim-list.el.
3210
fd06db5d
GM
3211 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3212 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3213 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3214
55c131ee
AS
32152012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3216
3217 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3218 proper alignment.
3219
9209588f
JB
32202012-04-07 Juanma Barranquero <lekktu@gmail.com>
3221
3222 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3223 Remove unused local variable.
3224
e3fb2efb
PE
32252012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3226
3227 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3228 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3229 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3230 objects, as mark_maybe_pointer will catch them otherwise.
3231 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3232 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3233
b5385551
PE
32342012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3235
3236 Fix typo that broke non-Windows builds.
3237 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3238
9078ead6
EZ
32392012-04-07 Eli Zaretskii <eliz@gnu.org>
3240
3241 Support building on MS-Windows with libxml2.
3242
3243 * makefile.w32-in (OBJ2): Add xml.$(O).
3244 (GLOBAL_SOURCES): Add xml.c.
3245 ($(BLD)/xml.$(O)): New dependency list.
3246
3247 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3248 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3249 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3250 [!WINDOWSNT]: New macros.
3251 (init_libxml2_functions, libxml2_loaded_p): New functions.
3252 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3253 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3254 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3255 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3256 linked in).
6bbef4e5
JC
3257 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3258 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3259 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3260
3261 * emacs.c: Don't include libxml/parser.h.
3262 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3263 xmlCleanupParser directly.
3264
3265 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3266
3811fdf3
EZ
32672012-04-07 Eli Zaretskii <eliz@gnu.org>
3268
3269 * indent.c (Fvertical_motion): If there is a display string at
3270 point, use it.vpos to compute how many lines to backtrack after
3271 move_it_to point. (Bug#11133)
3272
2f8e16b2
EZ
32732012-04-06 Eli Zaretskii <eliz@gnu.org>
3274
3275 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3276 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3277 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3278 macros related to unification of CJK characters. For the details,
3279 see the discussion following the message here:
3280 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3281
3d439cd1
CY
32822012-04-04 Chong Yidong <cyd@gnu.org>
3283
3284 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3285
8bc53d00
EZ
32862012-04-01 Eli Zaretskii <eliz@gnu.org>
3287
3288 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3289 instead of alloca. (Bug#11138)
3290
3b0512a3
AS
32912012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3292
3293 * w32menu.c (is_simple_dialog): Properly check lisp types.
3294 (Bug#11141)
3295
8427ddd2
EZ
32962012-03-31 Eli Zaretskii <eliz@gnu.org>
3297
979022ef
EZ
3298 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3299 position we get to after a call to move_it_to fails the
3300 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3301 only if we wind up in a string from display property. (Bug#11063)
3302
a6b1c7cc
EZ
3303 * window.c (Fdelete_other_windows_internal): Invalidate the row
3304 and column information about mouse highlight, so that redisplay
3305 restores it after reallocating the glyph matrices. (Bug#7464)
3306
8427ddd2
EZ
3307 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3308 string comes from a `display' text property, use the buffer
3309 position of that property as if we actually saw that position in
3310 the row's glyphs.
697ba24b
EZ
3311 (move_it_by_lines): Remove the assertion that
3312 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3313 violated when there's a before-string at the beginning of a line.
3314 (Bug#11063)
8427ddd2 3315
65a0a738
EZ
33162012-03-30 Eli Zaretskii <eliz@gnu.org>
3317
3318 * xdisp.c (append_space_for_newline): If the default face was
3319 remapped, use the remapped face for the appended newline.
3320 (extend_face_to_end_of_line): Use the remapped default face for
3321 extending the face to the end of the line.
3322 (display_line): Call extend_face_to_end_of_line when the default
3323 face was remapped. (Bug#11068)
3324
581355cc
EZ
33252012-03-29 Eli Zaretskii <eliz@gnu.org>
3326
3327 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3328
e8fc049f
SM
33292012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3330
3331 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3332
4fb9a543
GM
33332012-03-27 Glenn Morris <rgm@gnu.org>
3334
3335 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3336 Doc fixes.
3337
679910f1
KH
33382012-03-26 Kenichi Handa <handa@m17n.org>
3339
3340 * dispextern.h (struct glyph): Fix previous change. Change the
3341 bit length of glyphless.ch to 25 (Bug#11082).
3342
90d49b7f
CY
33432012-03-26 Chong Yidong <cyd@gnu.org>
3344
3345 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3346 (command_loop_1): Use it; inhibit selection update for
3347 handle-select-window too (Bug#8996).
3348
f514f6f0
FP
33492012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3350
e8fc049f 3351 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3352
bf43fa51
KH
33532012-03-25 Kenichi Handa <handa@m17n.org>
3354
3355 * dispextern.h (struct glyph): Change the bit length of
3356 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3357
8a0c01dd
EZ
33582012-03-24 Eli Zaretskii <eliz@gnu.org>
3359
3360 * s/ms-w32.h (tzname): Include time.h before redirecting to
3361 _tzname. Fixes the MSVC build. (Bug#9960)
3362
7d1c3a76
AS
33632012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3364
8ed79523
AS
3365 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3366 characters.
3367
7d1c3a76
AS
3368 * xterm.c (XTread_socket): Only modify handling_signal if
3369 !SYNC_INPUT. (Bug#11080)
3370
e99a9b8b
EZ
33712012-03-23 Eli Zaretskii <eliz@gnu.org>
3372
3373 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3374 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3375 when fetching a multibyte character consumes more bytes than
3376 CHAR_BYTES returns, due to unification of CJK characters in
3377 string_char. (Bug#11073)
3378
5063c0e1
TN
33792012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3380
3381 * process.c (wait_reading_process_output): Handle pty disconnect
3382 by refraining from sending oneself a SIGCHLD (bug#10933).
3383
9f851fbd
CY
33842012-03-22 Chong Yidong <cyd@gnu.org>
3385
3386 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3387
5063c0e1 3388 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3389 Mark string as coming from a prefix property.
3390 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3391 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3392
fb5b8aca
CY
33932012-03-21 Chong Yidong <cyd@gnu.org>
3394
3395 * xfaces.c (Vface_remapping_alist): Doc fix.
3396
62356a1b
EZ
33972012-03-20 Eli Zaretskii <eliz@gnu.org>
3398
3399 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3400 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3401 Doc fixes.
62356a1b 3402
025de85b
CY
34032012-03-20 Chong Yidong <cyd@gnu.org>
3404
3405 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3406 to reflect default non-nil value of redisplay-dont-pause.
3407
4827f94e
KH
34082012-03-19 Kenichi Handa <handa@m17n.org>
3409
3410 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3411 it fit in a valid range (Bug#11003).
3412
e50a24a2
EZ
34132012-03-18 Eli Zaretskii <eliz@gnu.org>
3414
3415 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3416 that is not from display property, accept the row as a "cursor
3417 row" if one of the string's character has a non-nil `cursor'
3418 property. Fixes cursor positioning when there are newlines in
3419 overlay strings, e.g. in icomplete.el. (Bug#11035)
3420
9af5ed87
PE
34212012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3422
3423 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3424
d1f55f16
CY
34252012-03-12 Chong Yidong <cyd@gnu.org>
3426
3427 * eval.c (inhibit_lisp_code): Rename from
3428 inhibit_window_configuration_change_hook; move from window.c.
3429
3430 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3431 * window.c (run_window_configuration_change_hook)
3432 (syms_of_window): Callers changed.
3433
66c5eebd
CY
34342012-03-11 Chong Yidong <cyd@gnu.org>
3435
413df973
CY
3436 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3437
66c5eebd
CY
3438 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3439
1de11f56
CY
34402012-03-10 Chong Yidong <cyd@gnu.org>
3441
3442 * frame.c (other_visible_frames): Don't assume the selected frame
3443 is visible (Bug#10955).
3444
cae07000
SM
34452012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3446
3447 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3448
89c94350
JD
34492012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3450
3451 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3452 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3453 zero (Bug#10954).
3454
999dd333
GM
34552012-03-03 Glenn Morris <rgm@gnu.org>
3456
01a6dcc8 3457 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3458
de0100f2
EZ
34592012-03-02 Eli Zaretskii <eliz@gnu.org>
3460
3461 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3462 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3463 (redisplay_window, next_element_from_string): Fix typos in
3464 comments.
3e441275
EZ
3465 (redisplay_window): Pass to move_it_vertically the margin in
3466 pixels, not in screen lines.
de0100f2 3467
96a72ee9
GM
34682012-03-02 Glenn Morris <rgm@gnu.org>
3469
3470 * buffer.c (buffer-list-update-hook): Doc fix.
3471
312508d7
EZ
34722012-02-29 Eli Zaretskii <eliz@gnu.org>
3473
3474 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3475 push_it before setting up the iterator for the first overlay
3476 string, even if we have an empty string loaded.
3477 (next_overlay_string): If there's an empty string on the iterator
3478 stack, pop the stack. (Bug#10903)
3479
27f3c637
PE
34802012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3481
3482 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3483 Suggested by Stefan Monnier in
3484 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3485 * alloc.c (widen_to_Lisp_Object): New static function.
3486 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3487 and widening them to Lisp_Objects. This would work even if
3488 USE_LSB_TAG is defined and wide integers are used, which might
3489 happen in a future version of Emacs.
3490
3c9dfce6
CY
34912012-02-25 Chong Yidong <cyd@gnu.org>
3492
fa74b241
CY
3493 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3494 Doc fix.
3495
3c9dfce6
CY
3496 * xselect.c (Fx_selection_exists_p): Doc fix.
3497 (x_clipboard_manager_save_all): Print an informative message
3498 before saving to clipboard manager.
3499
9486df08
CY
35002012-02-24 Chong Yidong <cyd@gnu.org>
3501
3502 * keyboard.c (process_special_events): Handle all X selection
3503 requests in kbd_buffer, not just the next one (Bug#8869).
3504
f01d3321
CY
35052012-02-23 Chong Yidong <cyd@gnu.org>
3506
3507 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3508 call when setting menu-bar-lines and tool-bar-lines parameters.
3509 (unwind_create_frame_1): New helper function.
3510
3511 * window.c (inhibit_window_configuration_change_hook): New var.
3512 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3513 (syms_of_window): Initialize it.
f01d3321 3514
86b847b6
CY
35152012-02-22 Chong Yidong <cyd@gnu.org>
3516
3517 * xterm.c (x_draw_image_relief): Add missing type check for
3518 Vtool_bar_button_margin (Bug#10743).
3519
a59225b1
CY
35202012-02-21 Chong Yidong <cyd@gnu.org>
3521
3522 * fileio.c (Vfile_name_handler_alist): Doc fix.
3523
3524 * buffer.c (Fget_file_buffer): Protect against invalid file
3525 handler return value.
3526
310f5bd4
PE
35272012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3528
cb3a28cc
PE
3529 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3530 when computing $valmask.
3531
310f5bd4
PE
3532 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3533 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3534 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3535 It's useless in that case, and it can cause problems on hosts
3536 that allocate halves of EMACS_INT values separately.
3537 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3538 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3539 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3540 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3541 it avoids undefined behavior on hosts where shifting right by more
3542 than the word width has undefined behavior.
3543
2375c96a
CY
35442012-02-19 Chong Yidong <cyd@gnu.org>
3545
3546 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3547 (Funhandled_file_name_directory, Ffile_name_as_directory)
3548 (Fdirectory_file_name, Fexpand_file_name)
3549 (Fsubstitute_in_file_name): Protect against invalid file handler
3550 return values (Bug#10845).
3551
3eb49e71
EZ
35522012-02-18 Eli Zaretskii <eliz@gnu.org>
3553
3554 * .gdbinit (pitx): Fix incorrect references to fields of the
3555 iterator stack.
3556
7b926f3f
CY
35572012-02-17 Chong Yidong <cyd@gnu.org>
3558
3559 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3560
11273115
PE
35612012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3562
3563 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3564 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3565
c3a70e2b
CY
35662012-02-15 Chong Yidong <cyd@gnu.org>
3567
3568 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3569 marked as special. Also, starting docstrings with * is obsolete.
3570
0ca43699
AS
35712012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3572
3573 * gnutls.c (emacs_gnutls_write): Fix last change.
3574
2e8f3c56
LI
35752012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3576
3577 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3578 send_process.
3579
af70074f
SM
35802012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3581
3582 * keymap.c (Fsingle_key_description): Handle char ranges.
3583
95986d52
CY
35842012-02-12 Chong Yidong <cyd@gnu.org>
3585
afd83bd1
CY
3586 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3587 as that creates a dangerous corner case.
3588
95986d52
CY
3589 * window.c (Fdelete_window_internal): Invalidate the mouse
3590 highlight (Bug#9904).
3591
bd7da63e
GM
35922012-02-12 Glenn Morris <rgm@gnu.org>
3593
3594 * xselect.c (Fx_own_selection_internal)
3595 (Fx_get_selection_internal, Fx_disown_selection_internal)
3596 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3597 * nsselect.m (Fx_own_selection_internal)
3598 (Fx_disown_selection_internal, Fx_selection_exists_p)
3599 (Fx_selection_owner_p, Fx_get_selection_internal):
3600 Sync docs and argument specs with the xselect.c versions.
3601
77abcbc2
LI
36022012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3603
3604 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3605
90b671e2
EZ
36062012-02-11 Eli Zaretskii <eliz@gnu.org>
3607
1c0ca0b7
EZ
3608 * w32select.c (Fx_selection_exists_p): Sync doc string and
3609 argument list with xselect.c. (Bug#10783)
3610
3611 * w16select.c (Fx_selection_exists_p): Sync doc string and
3612 argument list with xselect.c. (Bug#10783)
90b671e2 3613
49241268
GM
36142012-02-10 Glenn Morris <rgm@gnu.org>
3615
3616 * fns.c (Fsecure_hash): Doc fix.
3617
f998bbe7 36182012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3619
3620 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3621
0992bd9c
CY
36222012-02-07 Chong Yidong <cyd@gnu.org>
3623
3624 * buffer.c (Fbuffer_local_variables)
3625 (buffer_lisp_local_variables): Handle unbound vars correctly;
3626 don't let Qunbound leak into Lisp.
3627
af008560
GM
36282012-02-07 Glenn Morris <rgm@gnu.org>
3629
dd605cc4
GM
3630 * image.c (Fimagemagick_types): Doc fix.
3631
af008560
GM
3632 * image.c (imagemagick-render-type): Change it from a lisp object
3633 to an integer. Move the doc here from the lisp manual.
3634 Treat all values not equal to 0 the same.
3635
1449fa1d
CY
36362012-02-06 Chong Yidong <cyd@gnu.org>
3637
3638 * doc.c (store_function_docstring): Avoid applying docstring of
3639 alias to base function (Bug#2603).
3640
3723ec07
AS
36412012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3642
3643 * .gdbinit (pp1, pv1): Remove redundant defines.
3644 (pr): Use pp.
3645
79c1cc1e
CY
36462012-02-04 Chong Yidong <cyd@gnu.org>
3647
3648 * nsterm.m: Declare a global (Bug#10694).
3649
d7f29f8e
EZ
36502012-02-04 Eli Zaretskii <eliz@gnu.org>
3651
cae07000
SM
3652 * w32.c (get_emacs_configuration_options):
3653 Include --enable-checking, if specified, in the return value.
d7f29f8e 3654
3b95a6f9
MR
36552012-02-04 Martin Rudalics <rudalics@gmx.at>
3656
3657 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3658 after rounding frame sizes. (Bug#9723)
3659
d6fa96a6
EZ
36602012-02-04 Eli Zaretskii <eliz@gnu.org>
3661
3662 * keyboard.c (adjust_point_for_property): Don't position point
3663 before BEGV. (Bug#10696)
3664
df0b2940
PE
36652012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3666
3667 Handle overflow when computing char display width (Bug#9496).
3668 * character.c (char_width): Return EMACS_INT, not int.
3669 (char_width, c_string_width): Check for overflow when
3670 computing the width; this is possible now that individual
3671 characters can have unbounded width. Problem introduced
3672 by merge from Emacs 23 on 2012-01-19.
3673
6bee44d6
MA
36742012-02-02 Michael Albinus <michael.albinus@gmx.de>
3675
3676 * dbusbind.c (Fdbus_register_method): Mention the return value
3677 :ignore in the docstring.
3678
44f92739
GM
36792012-02-02 Glenn Morris <rgm@gnu.org>
3680
1b9f60cc
GM
3681 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3682
44f92739
GM
3683 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3684 Unconditionally set to t. (Bug#10673)
3685 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3686 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3687 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3688
c5d3843c
KH
36892012-02-02 Kenichi Handa <handa@m17n.org>
3690
3691 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3692 0, do not call append_composite_glyph.
3693
159462d4 36942012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3695
3696 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3697 NULL (Bug#6988).
3698 (x_produce_glyphs): If the component of a composition is a null
3699 string, set it->pixel_width to 1 to avoid zero-width glyph.
3700
78cef877
EZ
37012012-02-01 Eli Zaretskii <eliz@gnu.org>
3702
3703 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3704 first 2 arguments are identical. This makes inserting large
3705 output from a subprocess an order of magnitude faster on
3706 MS-Windows, where all sbrk'ed memory is always contiguous.
3707
97897668
GM
37082012-01-31 Glenn Morris <rgm@gnu.org>
3709
3710 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3711 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3712 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3713
31fd3586
GM
37142012-01-29 Glenn Morris <rgm@gnu.org>
3715
3716 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3717
0e24a8b2
CY
37182012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3719
3720 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3721
cc0adcb0
CY
37222012-01-28 Chong Yidong <cyd@gnu.org>
3723
3724 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3725
acc28cb9
CY
37262012-01-26 Chong Yidong <cyd@gnu.org>
3727
9c69cfb7
CY
3728 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3729
acc28cb9
CY
3730 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3731 repeat counts (Bug#10507).
3732
48da7392
GM
37332012-01-26 Glenn Morris <rgm@gnu.org>
3734
3735 * lread.c (syms_of_lread): Doc fix.
3736
14af5f7f
CY
37372012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3738
3739 * coding.c (encode_designation_at_bol): Change return value to
3740 EMACS_INT.
3741
0b21c100
CY
37422012-01-25 Chong Yidong <cyd@gnu.org>
3743
3744 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3745
3c2907f7
CY
37462012-01-21 Chong Yidong <cyd@gnu.org>
3747
3748 * floatfns.c (Fcopysign): Make the second argument non-optional,
3749 since nil is not allowed anyway.
3750
959ad23f
AS
37512012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3752
3753 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3754 (send_process): Likewise.
3755
34a02f46
MR
37562012-01-19 Martin Rudalics <rudalics@gmx.at>
3757
3758 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3759 (Vwindow_persistent_parameters): Do not use Qstate.
3760 Rewrite doc-strings.
34a02f46 3761
1259009a 37622012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3763
3764 * character.c (char_width): New function.
70d4fdf6
GM
3765 (Fchar_width, c_string_width, lisp_string_width):
3766 Use char_width (Bug#9496).
25ed9e61 3767
6a6ee00d
MR
37682012-01-16 Martin Rudalics <rudalics@gmx.at>
3769
3770 * window.c (Vwindow_persistent_parameters): New variable.
3771 (Fset_window_configuration, save_window_save): Handle persistent
3772 window parameters.
3773
c85efaf7
EZ
37742012-01-14 Eli Zaretskii <eliz@gnu.org>
3775
3776 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3777 thrashing the stack of the thread. (Bug#9087)
3778
5944709e
PE
37792012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3780
3781 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3782
e71f5d99
EZ
37832012-01-11 Eli Zaretskii <eliz@gnu.org>
3784
3785 * xdisp.c (rows_from_pos_range): Handle the case where the
3786 highlight ends on a newline. (Bug#10464)
3787 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3788 he end column for display of highlight that ends on a newline
3789 before a R2L line.
3790
ce316182
GM
37912012-01-11 Glenn Morris <rgm@gnu.org>
3792
3793 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3794 from load-path also when installation-directory is nil. (Bug#10208)
3795
5b43da69
GM
37962012-01-10 Glenn Morris <rgm@gnu.org>
3797
74cc8ff9
GM
3798 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3799
7d8d6e4e
GM
3800 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3801 Update template values to be closer to their typical values these days.
5b43da69 3802
a0db8d43
EZ
38032012-01-09 Eli Zaretskii <eliz@gnu.org>
3804
3805 * xdisp.c (rows_from_pos_range): Accept additional argument
3806 DISP_STRING, and accept any glyph in a row whose object is that
3807 string as eligible for mouse highlight. Fixes mouse highlight of
3808 display strings from overlays. (Bug#10464)
3809
9a0115ab 38102012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3811
b9110d6a 3812 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3813 * fileio.c (auto_saving_dir_umask): New static var.
3814 (Fmake_directory_internal): Use it.
3815 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3816 creating the directory. The old code temporarily assigns
3817 too-generous permissions to the directory.
3818 (do_auto_save_eh): Clear it.
b9110d6a 3819 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3820 that the var is always cleared.
3821
6c1bd3f3
EZ
38222012-01-07 Eli Zaretskii <eliz@gnu.org>
3823
3824 * search.c (scan_buffer): Pass character positions to
3825 know_region_cache, not byte positions. (Bug#6540)
3826
069d2b50
L
38272012-01-07 LynX <_LynX@bk.ru> (tiny change)
3828
3829 * w32.c (sys_rename): Report EXDEV when rename of a directory
3830 fails because the target is on another logical disk. (Bug#10284)
3831
75bf0d33
DB
38322012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3833
3834 * xterm.c (x_embed_request_focus): New function.
3835
3836 * xterm.h: Add prototype.
3837
3838 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3839
1c6e5a32
GM
38402012-01-05 Glenn Morris <rgm@gnu.org>
3841
3842 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3843
651e947e
EZ
38442012-01-01 Eli Zaretskii <eliz@gnu.org>
3845
3846 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3847 Load gnutls_transport_set_lowat only if GnuTLS version is below
3848 2.11.1.
3849 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3850 GnuTLS versions below 2.11.1.
3851
3778cdd8
AL
38522011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3853
3854 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3855 to the doc string advising against its use for altering the way
3856 windows are scrolled.
3857
0e5317f7
KH
38582011-12-28 Kenichi Handa <handa@m17n.org>
3859
3860 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3861 coding-system ASCII compatible only when it does not produce BOM
3862 on encoding (Bug#10383).
3863
93d5ca1f
JD
38642011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3865
3866 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3867 can scroll.
3868 (create_and_show_popup_menu): Always use menu_position_func for
3869 Gtk3 (Bug#10361).
3870
ca22b785
AS
38712011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3872
3873 * callint.c (Fcall_interactively): Don't truncate prompt string.
3874
d048e1e6
EZ
38752011-12-23 Eli Zaretskii <eliz@gnu.org>
3876
3877 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3878 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3879 resumed from there (after widening). (Bug#10360)
d048e1e6 3880
5ccaba1f
JD
38812011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3882
3883 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3884
204ee57f
JD
38852011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3886
b81d40f0
JB
3887 * nsterm.m (x_free_frame_resources):
3888 Release f->output_data.ns->miniimage.
204ee57f
JD
3889 (ns_index_color): Fix indentation. Do not retain
3890 color_table->colors[i].
3891
3892 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3893 before returning.
3894
3895 * nsfns.m (x_set_background_color): Assign return value from
3896 ns_index_color to face-background instead of NSColor*.
3897 (ns_implicitly_set_icon_type): Fix indentation.
3898 Change assignment in for loop to comparison.
3899
3900 * emacs.c (ns_pool): New variable.
3901 (main): Assign ns_pool.
3902 (Fkill_emacs): Call ns_release_autorelease_pool.
3903
3904 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3905 autorelease fdesc, release fdAttrs and tdict.
3906 (ns_get_covering_families): Release charset.
3907 (ns_findfonts): Release NSFontDescriptor created with new.
3908 (ns_uni_to_glyphs): Fix indentation.
3909 (setString): Release attrStr before assigning new value.
3910
c803b2b7
JD
39112011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3912
678f4426
JD
3913 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3914 and NS_IMPL_COCOA.
3915 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3916 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3917
cd394be1 39182011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3919
5fecd5fc
JD
3920 * nsterm.m (ns_term_init): Subscribe for notifications
3921 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3922 to method trackingNotification in EmacsMenu.
3923
3924 * nsmenu.m (trackingMenu): New variable.
3771cb17 3925 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3926 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3927 from Aquamacs (Bug#7030).
678f4426
JD
3928
39292011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3930
c803b2b7
JD
3931 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3932 (symbol_to_nsstring): Fix indentation.
3933 (ns_symbol_to_pb): New function.
cae07000
SM
3934 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3935 (Fns_rotate_cut_buffers_internal): Remove.
3936 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3937 Fns_store_cut_buffer_internal.
3938 (ns_get_foreign_selection, Fx_own_selection_internal)
3939 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3940 (Fns_get_selection_internal, Fns_store_selection_internal):
3941 Use ns_symbol_to_pb and check if return value is nil.
3942 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3943 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3944 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3945 renamed to Sns_store_selection_internal.
3946 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3947 and remove this function.
3948 (ns_handle_selection_clear): Remove, never used.
3949 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3950 here.
3951
e1b01a3a
KB
39522011-12-17 Ken Brown <kbrown@cornell.edu>
3953
3954 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3955 GID is unknown (Bug#10257).
3956
2adb6e85
PE
39572011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3958
3959 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3960 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3961 which caused a build failure on GNU/Linux IA-64. This problem was
3962 introduced by my 2011-10-07 patch.
3963
d1d7b339
JL
39642011-12-15 Juri Linkov <juri@jurta.org>
3965
3966 * image.c (imagemagick_error): New function. (Bug#10112)
3967 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3968 Use `imagemagick_error' where ImageMagick functions return
3969 `MagickFalse'.
3970 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3971 proper order.
3972
100d5755
KH
39732011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3974
3975 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3976 fill background (Bug#8992).
3977
454592a6
MR
39782011-12-13 Martin Rudalics <rudalics@gmx.at>
3979
3980 * window.c (Vwindow_combination_resize)
3981 (Vwindow_combination_limit): Use t instead of non-nil in
3982 doc-strings.
61d4b438
MR
3983 (Vrecenter_redisplay): Add first sentence of doc-string on
3984 separate line.
53524d93 3985 (Frecenter): Fix doc-string typo.
454592a6 3986
3633e3aa
KH
39872011-12-11 Kenichi Handa <handa@m17n.org>
3988
3989 * coding.c (Funencodable_char_position): Pay attention to the
3990 buffer text relocation (Bug#9389).
3991
7b9d523a 39922011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3993
7b9d523a
JD
3994 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3995 gtk_init (Bug#10100).
3996
b73189c6
EZ
39972011-12-10 Eli Zaretskii <eliz@gnu.org>
3998
3999 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4000 IT->string is nil. (Bug#10263)
4001
f7dfe5d6
JD
40022011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4003
83faebb4
JD
4004 * nsterm.h (x_free_frame_resources): Declare.
4005
f7dfe5d6
JD
4006 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4007 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4008
4009 * nsterm.h (ns_get_defaults_value): Declare.
4010
4011 * nsterm.m (ns_default): Call ns_get_defaults_value.
4012
7cd4e72c
EZ
40132011-12-09 Eli Zaretskii <eliz@gnu.org>
4014
4015 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4016 (Bug#10170)
4017
b34d7317
YM
40182011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4019
4020 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4021 that where the value of an _OBJC_* symbol points to is in the .bss
4022 section (Bug#10240).
4023
76470ad1
KH
40242011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4025
4026 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4027 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4028
745fff94
KH
40292011-12-08 Kenichi Handa <handa@m17n.org>
4030
4031 * ftfont.c (get_adstyle_property): Fix previous change
4032 (Bug#10233).
4033
6e44397c
JB
40342011-12-07 Juanma Barranquero <lekktu@gmail.com>
4035
4036 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4037 dirs from the default value of EMACSLOADPATH (bug#10208).
4038
7efa6272
GM
40392011-12-07 Glenn Morris <rgm@gnu.org>
4040
4041 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4042 installation and source directories as well. (Bug#10208)
4043
f6fc4d87
CY
40442011-12-06 Chong Yidong <cyd@gnu.org>
4045
4046 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4047
2bf26180
GM
40482011-12-06 Glenn Morris <rgm@gnu.org>
4049
4050 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4051 as an error, not just -1. (Bug#10217)
4052
3a6ad4f0
CY
40532011-12-05 Chong Yidong <cyd@gnu.org>
4054
4055 * keyboard.c (process_special_events): New function.
4056 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4057
75a3b399
PE
40582011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4059
4060 * coding.c (encode_designation_at_bol): Don't use uninitialized
4061 local variable (Bug#9318).
4062
c3c9e25e
KH
40632011-12-05 Kenichi Handa <handa@m17n.org>
4064
4065 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4066 return Qnil (Bug#8046, Bug#10193).
4067
5eb05ea3
KH
40682011-12-05 Kenichi Handa <handa@m17n.org>
4069
4070 * coding.c (encode_designation_at_bol): New args charbuf_end and
4071 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4072 (coding_set_source): Return how many bytes coding->source was
4073 relocated.
4074 (coding_set_destination): Return how many bytes
4075 coding->destination was relocated.
4076 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4077 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4078
40792011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4080
4081 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4082 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4083 macro (Bug#9318).
4084
40852011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4086
4087 The following changes are to fix Bug#9318.
4088
a79703f5 4089 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4090 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4091 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4092 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4093
7dbda6df
JB
40942011-12-05 Juanma Barranquero <lekktu@gmail.com>
4095
4096 * lisp.h (process_quit_flag): Fix external declaration.
4097
6d5eb5b0
SM
40982011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4099
4100 Don't macro-inline non-performance-critical code.
4101 * eval.c (process_quit_flag): New function.
4102 * lisp.h (QUIT): Use it.
4103
a0c3fad0
JD
41042011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4105
4106 * nsfns.m (get_geometry_from_preferences): New function.
4107 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4108
6c07aac2
AS
41092011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4110
4111 * emacs.c (Qkill_emacs): Define.
4112 (syms_of_emacs): Initialize it.
4113 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4114 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4115 (quit_throw_to_read_char): Add parameter `from_signal'.
4116 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4117 * lisp.h (QUIT): Call Fkill_emacs if requested.
4118
c052ead4
JD
41192011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4120
4121 * widget.c (update_wm_hints): Return if wmshell is null.
4122 (widget_update_wm_size_hints): New function.
4123
4124 * widget.h (widget_update_wm_size_hints): Declare.
4125
4126 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4127 widget_update_wm_size_hints (Bug#10104).
4128
9e49252b
EZ
41292011-12-03 Eli Zaretskii <eliz@gnu.org>
4130
4131 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4132 before a newline, prepare the bidi iterator for consuming the
4133 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4134 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4135
02b16839
JL
41362011-12-02 Juri Linkov <juri@jurta.org>
4137
4138 * search.c (Fword_search_regexp): New Lisp function created from
4139 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4140 (Fword_search_backward, Fword_search_forward)
4141 (Fword_search_backward_lax, Fword_search_forward_lax):
4142 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4143 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4144
0068070e
SM
41452011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4146
4147 * fileio.c (Finsert_file_contents): Move after-change-function call
4148 to before the "handled:" label, since all "goto handled" appear in
4149 cases where the *-change-functions have already been properly called
4150 (bug#10117).
4151
3360a3fc
AS
41522011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4153
4154 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4155 waiting for input. (Bug#10169)
4156
73d6c093
EZ
41572011-11-30 Eli Zaretskii <eliz@gnu.org>
4158
4159 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4160 verifies glyph row's hash code--we have just reallocated the
4161 glyphs, so their contents can be complete garbage. (Bug#10164)
4162
febe6bea
JB
41632011-11-30 Juanma Barranquero <lekktu@gmail.com>
4164
4165 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4166
801a4313
EZ
41672011-11-30 Eli Zaretskii <eliz@gnu.org>
4168
4169 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4170 attributes are tested _before_ calling verify_row_hash, to protect
4171 against GCC re-ordering of the tests. (Bug#10164)
4172
2b56b87e
JD
41732011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4174
4175 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4176
4177 * xterm.c (handle_one_xevent): Only set async_visible and friends
4178 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4179 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4180 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4181
dbf31225
PE
41822011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4183
4184 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4185 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4186 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4187 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4188 All uses changed to use GCPRO1 etc.
4189 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4190 Revert to old implementation (i.e., before 2011-03-11).
4191
1305621b
YM
41922011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4193
4194 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4195 of scroll runs so as to avoid assigning disabled bogus rows and
4196 unnecessary graphics copy operations.
4197
8c9afb46
EZ
41982011-11-27 Eli Zaretskii <eliz@gnu.org>
4199
4200 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4201 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4202 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4203 (malloc, free, realloc, calloc): Redirect to e_* only when
4204 compiling Emacs.
4205
4206 * lisp.h (GCTYPEBITS): Move before first use.
4207 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4208 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4209 this macro definition.
4210
4211 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4212 _MSC_VER.
4213
54e9e3bf
JD
42142011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4215
6d5eb5b0
SM
4216 * gtkutil.c (xg_create_frame_widgets):
4217 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4218 present with Gtk+ 2.0.
4219
83aca1cb
PE
42202011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4221
4222 * fileio.c (Finsert_file_contents): Undo previous change; see
4223 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4224
5b76caa4
PE
42252011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4226
4227 Rename locals to avoid shadowing.
4228 * fileio.c (Finsert_file_contents):
4229 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4230 * process.c (wait_reading_process_output):
4231 Rename inner 'proc' to 'p' to avoid shadowing.
4232 Indent for consistency with usual Emacs style.
4233
8c535114
EZ
42342011-11-25 Eli Zaretskii <eliz@gnu.org>
4235
4236 * xdisp.c (redisplay_window): If cursor row is not fully visible
4237 after recentering, and scroll-conservatively is set to a large
4238 number, scroll window by a few more lines to make the cursor fully
4239 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4240 (start_display): Don't move to the next line if the display should
4241 start at a newline that is part of a display vector or an overlay
4242 string. (Bug#10119)
8c535114 4243
fa4fdb5c
JL
42442011-11-24 Juri Linkov <juri@jurta.org>
4245
4246 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4247 after the `MagickPingImage' call. (Bug#10112)
4248
90ec88df
CY
42492011-11-23 Chong Yidong <cyd@gnu.org>
4250
4251 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4252
56e2e794
MR
42532011-11-23 Martin Rudalics <rudalics@gmx.at>
4254
4255 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4256 making another buffer current. (Bug#10114)
4257
b6e64c41
GM
42582011-11-23 Glenn Morris <rgm@gnu.org>
4259
4260 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4261
6b21de18
CY
42622011-11-23 Chong Yidong <cyd@gnu.org>
4263
4264 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4265 using it (Bug#5984).
4266
b12cd789
EZ
42672011-11-22 Eli Zaretskii <eliz@gnu.org>
4268
4269 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4270 and header-lines, as they don't have one computed for them.
4271 (Bug#10098)
4272
4273 * .gdbinit (prow): Make displayed values more self-explaining.
4274 Add row's hash code.
4275
261b6fd4
LMI
42762011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4277
4278 * process.c (wait_reading_process_output): Fix asynchrounous
4279 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4280 (wait_reading_process_output): Add comment and URL.
261b6fd4 4281
e7cfd277
JD
42822011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4283
4284 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4285
a9b9b7f5
CY
42862011-11-21 Chong Yidong <cyd@gnu.org>
4287
4288 * window.c (Fnext_window, Fprevious_window): Doc fix.
4289
b0d15b4f
SM
42902011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4291
4292 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4293
fe7a3057
JB
42942011-11-20 Juanma Barranquero <lekktu@gmail.com>
4295
4296 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4297
d2999b1a
MR
42982011-11-20 Martin Rudalics <rudalics@gmx.at>
4299
4300 * window.c (Fset_window_combination_limit): Rename argument
4301 STATUS to LIMIT.
4302 (Vwindow_combination_limit): Remove "status" from doc-string.
4303
d5ff9cd0
AS
43042011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4305
4306 * m/ibms390.h: Remove.
4307 * m/ibms390x.h: Don't include "ibms390.h".
4308
a5bb9bd3
SM
43092011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4310
4311 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4312 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4313
cd1181db
JB
43142011-11-20 Juanma Barranquero <lekktu@gmail.com>
4315
4316 * casetab.c (Fset_case_table):
4317 * charset.c (Fcharset_after): Fix typos.
4318
615a3b8d 43192011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4320
17e845af
PE
4321 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4322 Otherwise, valgrind does not work on some platforms.
4323 Problem reported by Andreas Schwab in
6a0bf43d
PE
4324 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4325 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4326 is set, removing the need for VIRT_ADDRESS_VARIES.
4327 (PURE_P): Use a more-efficient implementation that needs just one
4328 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4329 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4330 to 4 (xorl, subq, cmpq, setbe).
4331 * alloc.c (pure): Always extern now, since that's the
4332 VIRT_ADDR_VARIES behavior.
4333 (PURE_POINTER_P): Use a single comparison, not two, for
4334 consistency with the new puresize.h.
4335 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4336 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4337 Remove VIRT_ADDR_VARIES no longer needed.
4338
f8fe6f96
EZ
43392011-11-19 Eli Zaretskii <eliz@gnu.org>
4340
4341 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4342 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4343 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4344 behave as if the cursor position were at the window margin.
4345
4346 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4347 and the cursor position is out of bounds, behave as if the cursor
4348 position were at the window margin. (Bug#10075)
4349
df05a53c
CY
43502011-11-18 Chong Yidong <cyd@gnu.org>
4351
4352 * window.c (Fwindow_combination_limit): Make first argument
4353 non-optional, since it is meaningless for live windows like the
4354 selected window.
61ccba97 4355
2071918e
DA
43562011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4357
4358 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4359
b50a28de
SM
43602011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4361
4362 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4363 (graft_intervals_into_buffer): Simplify.
4364
015137db
EZ
43652011-11-18 Eli Zaretskii <eliz@gnu.org>
4366
4367 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4368 hash values of the two rows.
4369 (copy_row_except_pointers): Preserve the used[] arrays and the
4370 hash values of the two rows. (Bug#10035)
68c95424 4371 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4372
4373 * xdisp.c (row_hash): New function, body extracted from
4374 compute_line_metrics.
4375 (compute_line_metrics): Call row_hash, instead of computing the
4376 hash code inline.
4377
4378 * dispnew.c (verify_row_hash): Call row_hash for computing the
4379 hash code of a row, instead of duplicating code from xdisp.c.
4380
4381 * dispextern.h (row_hash): Add prototype.
4382
a2addb04
TH
43832011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4384
4385 * frame.c (delete_frame): Don't delete the terminal when the last
4386 X frame is closed if emacs is built with GTK toolkit.
4387
df85d315
JB
43882011-11-17 Juanma Barranquero <lekktu@gmail.com>
4389
4390 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4391
a0c2d0ae
MR
43922011-11-17 Martin Rudalics <rudalics@gmx.at>
4393
4394 * window.c (Vwindow_splits): Rename to
4395 Vwindow_combination_resize. Suggested by Juri Linkov.
4396 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4397 of Vwindow_splits.
4398
58179cce
JB
43992011-11-16 Juanma Barranquero <lekktu@gmail.com>
4400
7877f373
JB
4401 * nsfns.m (Fns_font_name):
4402 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4403
b6f67890
MR
44042011-11-16 Martin Rudalics <rudalics@gmx.at>
4405
4406 * window.h (window): Rename slot "nest" to "combination_limit".
4407 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4408 (Fset_window_nest): Rename to Fset_window_combination_limit.
4409 (Vwindow_nest): Rename to Vwindow_combination_limit.
4410 (recombine_windows, make_parent_window, make_window)
4411 (Fsplit_window_internal, saved_window)
4412 (Fset_window_configuration, save_window_save): Rename all
4413 occurrences of window_nest to window_combination_limit.
4414
c7015153
JB
44152011-11-15 Juanma Barranquero <lekktu@gmail.com>
4416
4417 * image.c (imagemagick_load_image): Fix typo.
4418
322ad6ec
EZ
44192011-11-14 Eli Zaretskii <eliz@gnu.org>
4420
4421 * xdisp.c (display_line): Move the call to
4422 highlight_trailing_whitespace before the call to
4423 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4424 faces of all the glyphs to compute ROW's hash value.
4425 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4426
f067b8ec
JB
44272011-11-14 Juanma Barranquero <lekktu@gmail.com>
4428
4429 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4430 just return (bug#10044).
4431
1e5b2111
EZ
44322011-11-12 Eli Zaretskii <eliz@gnu.org>
4433
7ef3cbd5
EZ
4434 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4435 with user-defined heap size. Bump the default size of the temacs
4436 heap to 27MB, to avoid memory warning when running temacs.
4437 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4438
1e5b2111
EZ
4439 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4440 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4441 (verify_row_hash) [XASSERTS]: New function.
4442 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4443 that the hash value of glyph rows is correct.
1e5b2111 4444
89d61221
MR
44452011-11-12 Martin Rudalics <rudalics@gmx.at>
4446
4447 * window.h (window): Remove splits slot.
4448 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4449 (Fdelete_other_windows_internal, make_parent_window)
4450 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4451 (Fset_window_configuration, save_window_save): Don't deal with
4452 split status of windows.
4453 (saved_window): Remove splits slot.
4454 (Vwindow_splits): Rewrite doc-string.
4455
97f18cc8
JD
44562011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4457
4458 * xfns.c (unwind_create_frame):
4459 * nsfns.m (unwind_create_frame):
4460 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4461 Vframe_list (Bug#9999).
4462
22a648b4
DA
44632011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4464
0b381c7e 4465 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4466
659afede
KH
44672011-11-11 Kenichi Handa <handa@m17n.org>
4468
4469 * callproc.c (Fcall_process): Set the member dst_multibyte of
4470 process_coding.
4471
9ac0394b
KH
44722011-11-11 Johan Bockgård <bojohan@gnu.org>
4473
4474 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4475 avoid a crash (bug#9496).
4476
2fbdc249
CY
44772011-11-09 Chong Yidong <cyd@gnu.org>
4478
4479 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4480 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4481
ac6b1f81
PE
44822011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4483
4484 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4485
09db192c
PE
44862011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4487
4488 Avoid some portability problems by eschewing 'extern inline' functions.
4489 The trivial performance wins aren't worth the portability hassles; see
4490 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4491 et seq.
4492 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4493 (window_box_width, window_box_left, window_box_left_offset)
4494 (window_box_right, window_box_right_offset): Undo previous change,
4495 by removing the "extern"s.
4496 * intervals.c (adjust_intervals_for_insertion)
4497 (adjust_intervals_for_deletion): Undo previous change,
4498 making these static again.
4499 (offset_intervals, temp_set_point_both, temp_set_point)
4500 (copy_intervals_to_string): No longer inline.
4501 * xdisp.c (window_text_bottom_y, window_box_width)
4502 (window_box_height, window_box_left_offset)
4503 (window_box_right_offset, window_box_left, window_box_right)
4504 (window_box): No longer inline.
4505
105216ed
CY
45062011-11-08 Chong Yidong <cyd@gnu.org>
4507
4508 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4509 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4510 Signal an error if not a live window.
105216ed
CY
4511 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4512 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4513
ae9e237f
JB
45142011-11-07 Juanma Barranquero <lekktu@gmail.com>
4515
4516 * lisp.h (syms_of_abbrev): Remove declaration.
4517 Reported by CHENG Gao <chenggao@royau.me>.
4518
c7aa8333
EZ
45192011-11-07 Eli Zaretskii <eliz@gnu.org>
4520
4521 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4522 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4523 of temacs in GUI mode.
4524
be7f5545
MR
45252011-11-07 Martin Rudalics <rudalics@gmx.at>
4526
4527 * window.h: Declare delete_all_child_windows instead of
4528 delete_all_subwindows.
4529 * window.c (Fwindow_nest, Fset_window_nest)
4530 (Fset_window_new_total, Fset_window_new_normal)
4531 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4532 (delete_all_subwindows): Rename to delete_all_child_windows.
4533 (Fdelete_other_windows_internal, Fset_window_configuration):
4534 Call delete_all_child_windows instead of delete_all_subwindows.
4535 * frame.c (delete_frame): Call delete_all_child_windows instead
4536 of delete_all_subwindows.
4537
ca78dc43
PE
45382011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4539
4540 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4541 This is also needed for porting to any host where GC_MARK_STACK is
4542 not GC_MAKE_GCPROS_NOOPS.
4543 (which_symbols): Use it.
4544
a0241d01
KH
45452011-11-07 Kenichi Handa <handa@m17n.org>
4546
4547 * coding.c (coding_set_destination): Check coding->src_pos only
4548 when coding->src_object is a buffer (bug#9910).
4549
4550 * process.c (send_process): Set the member src_multibyte of coding
4551 to 0 (bug#9911) when sending a unibyte text.
4552
4553 * callproc.c (Fcall_process): Set the member src_multibyte of
4554 process_coding to 0 (bug#9912).
4555
a64bfdfa 45562011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4557
4558 * xmenu.c (cleanup_widget_value_tree): New function.
4559 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4560 calling free_menubar_widget_value_tree directly (Bug#9830).
4561
cb41b32a
PE
45622011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4563
4564 Fix some portability problems with 'inline'.
4565 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4566 (window_box_width, window_box_left, window_box_left_offset)
4567 (window_box_right, window_box_right_offset): Declare extern.
4568 Otherwise, these inline functions do not conform to C99 and
4569 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4570 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4571 * intervals.c (adjust_intervals_for_insertion)
4572 (adjust_intervals_for_deletion): Now extern, because otherwise the
4573 extern inline functions 'offset_intervals' couldn't refer to it.
4574 (static_offset_intervals): Remove.
4575 (offset_intervals): Rewrite using the old contents of
4576 static_offset_intervals. The old version didn't conform to C99
4577 because an extern inline function contained a reference to an
4578 identifier with static linkage.
4579
b7041366
AS
45802011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4581
4582 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4583 GC.
4584
88a37c4d
EZ
45852011-11-06 Eli Zaretskii <eliz@gnu.org>
4586
4587 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4588 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4589 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4590 return Qleft_to_right.
4591
49745b39
CY
45922011-11-06 Chong Yidong <cyd@gnu.org>
4593
4594 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4595 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4596 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4597 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4598 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4599 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4600 (Fwindow_vscroll): Doc fix.
4601 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4602 argument, since it makes no sense to pass a live window and for
4603 consistency with window-child.
4604
1f05cd82
CS
46052011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4606
4607 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4608 support MSVC.
4609
22610910
JR
46102011-11-05 Jason Rumney <jasonr@gnu.org>
4611
4612 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4613 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4614 fonts (Bug#6029).
4615 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4616 bitwise arithmetic preventing use of unicode-sip and non-truetype
4617 opentype fonts.
4618
a06776b2
EZ
46192011-11-05 Eli Zaretskii <eliz@gnu.org>
4620
3ad924ba
EZ
4621 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4622 "emacs"-only part.
4623
a06776b2
EZ
4624 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4625 initialization code to keep similarity to xfns.c after changes
4626 from 2011-11-05.
4627
c9e7db78
JD
46282011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4629
a97f8f3f
JD
4630 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4631 (unwind_create_frame): New function (Bug#9943).
4632 (Fx_create_frame): Restructure code to be more similar to the one in
4633 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4634 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4635 Move terminal->reference_count++ just before making the frame official
4636 (Bug#9943).
4637
4638 * nsterm.m (x_free_frame_resources): New function.
4639 (x_destroy_window): Move code to x_free_frame_resources.
4640
c9e7db78 4641 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4642 (Fx_create_frame, x_create_tip_frame):
4643 Move terminal->reference_count++ just before making the frame
75f1671a 4644 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4645 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4646
a6fc3b5c
EZ
46472011-11-05 Eli Zaretskii <eliz@gnu.org>
4648
4649 Support MSVC build with newer versions of Visual Studio.
4650 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4651 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4652 nt/gmake.defs.
4653
4654 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4655 which are not supported by MSVC.
4656 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4657 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4658 bitfields.
4659 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4660 types in bitfields.
4661 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4662
4663 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4664
58179cce 46652011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4666
4667 Support MSVC build with newer versions of Visual Studio.
4668 * w32.c: Don't include w32api.h for MSVC.
4669 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4670
4671 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4672 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4673 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4674 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4675 e_* cousins.
4676 (alloca) [_MSC_VER]: Define to _alloca.
4677
4678 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4679
4680 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4681
a58c13ed
EZ
46822011-11-04 Eli Zaretskii <eliz@gnu.org>
4683
4684 * xdisp.c (note_mouse_highlight): If either of
4685 previous/next-single-property-change returns nil, treat that as
4686 the beginning or the end of the buffer. (Bug#9955)
4687
fe0b6370
JD
46882011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4689
a58c13ed 4690 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4691 label is not null (Bug#9951).
4692 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4693 may be NULL.
4694
89bd5ee1
EZ
46952011-11-04 Eli Zaretskii <eliz@gnu.org>
4696
4697 * window.c (Fwindow_body_size): Mention in the doc string that the
4698 return value is in frame's canonical units. (Bug#9949)
4699
84c3edb9
EZ
47002011-11-03 Eli Zaretskii <eliz@gnu.org>
4701
4e2fb5c7
EZ
4702 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4703
84c3edb9 4704 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4705 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4706 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4707
bc17a887
EZ
47082011-11-01 Eli Zaretskii <eliz@gnu.org>
4709
4710 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4711 Don't stop backward scan on the continuation glyph, even though
4712 its CHARPOS is positive.
6d5eb5b0
SM
4713 (mouse_face_from_buffer_pos, note_mouse_highlight):
4714 Rename cover_string to disp_string.
bc17a887 4715
4ee88440
MR
47162011-11-01 Martin Rudalics <rudalics@gmx.at>
4717
4718 * window.c (temp_output_buffer_show): Don't use
4719 Vtemp_buffer_show_specifiers.
4720 (Vtemp_buffer_show_specifiers): Remove unused variable.
4721
c2ff3c02
EZ
47222011-10-30 Eli Zaretskii <eliz@gnu.org>
4723
4724 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4725 past the beginning of the current glyph matrix.
4726
58179cce 47272011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4728
4729 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4730 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4731 HAVE_GTK3 (Bug#9869).
b77a6a7f 4732
3b574623
JD
4733 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4734 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4735
b77a6a7f
JD
4736 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4737
4738 * xterm.c: Declare x_handle_net_wm_state to return int.
4739 (handle_one_xevent): Check if we are iconified but don't have
4740 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4741 (get_current_wm_state): Return non-zero if not hidden,
4742 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4743 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4744 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4745 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4746
196e41e4
PE
47472011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4748
4749 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4750 so that this new function doesn't get optimized away by a
4751 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4752
021f2e1a
AS
47532011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4754
4755 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4756
8b058d44
EZ
47572011-10-29 Eli Zaretskii <eliz@gnu.org>
4758
4759 Fix the `xbytecode' command.
4760 * .gdbinit (xprintbytestr): New command.
b50a28de 4761 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4762 (xbytecode): Print the byte-code string as well.
4763
4452fb80
EZ
47642011-10-29 Kim Storm <storm@cua.dk>
4765
8b058d44
EZ
4766 * alloc.c (which_symbols): New function.
4767
21b72067
AS
47682011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4769
4770 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4771 line. (Bug#9903)
4772
83ed7b5c
GM
47732011-10-29 Glenn Morris <rgm@gnu.org>
4774
4775 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4776 Not clear what it was for, and it causes various bugs. (Bug#9839)
4777
5a7a728b
EZ
47782011-10-28 Eli Zaretskii <eliz@gnu.org>
4779
4780 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4781 possible random value that matches one of those tested as
4782 condition to clear the mouse face.
4783
d3d0842f
CY
47842011-10-28 Chong Yidong <cyd@gnu.org>
4785
4786 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4787
31b39d13
DN
47882011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4789
4790 * window.c (make_window): Initialize phys_cursor_on_p.
4791
9aba6043
SM
47922011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4793
4794 * lisp.h (struct Lisp_Symbol): Update comments.
4795
c20992f4
JB
47962011-10-28 Juanma Barranquero <lekktu@gmail.com>
4797
4798 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4799
db4f02f2
EZ
48002011-10-28 Eli Zaretskii <eliz@gnu.org>
4801
4802 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4803 <oslsachem@gmail.com> for helping to debug this.
4804
4805 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4806 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4807 (g_b_init_get_glyph_outline_w): New static variables.
4808 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4809 (GetGlyphOutlineW_Proc): New typedefs.
4810 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4811 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4812 New functions.
4813 (w32font_open_internal, compute_metrics):
4814 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4815 instead of calling the "wide" APIs directly.
4816
4817 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4818
4819 * w32.h (syms_of_w32font): Add prototype.
4820
87e68db4
JB
48212011-10-27 Juanma Barranquero <lekktu@gmail.com>
4822
4823 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4824 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4825 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4826 (Fmove_to_window_line): Doc fix.
4827
435c1d67
CY
48282011-10-27 Chong Yidong <cyd@gnu.org>
4829
4830 * process.c (make_process): Set gnutls_state to NULL.
4831
4832 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4833 non-NULL, regardless of GNUTLS_INITSTAGE.
4834 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4835 an error. Set process slots as soon as we allocate them.
4836
4837 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4838
9c6c6f49
CY
48392011-10-27 Chong Yidong <cyd@gnu.org>
4840
9aba6043
SM
4841 * gnutls.c (emacs_gnutls_deinit): New function.
4842 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4843 (Fgnutls_deinit, Fgnutls_boot): Use it.
4844
4845 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4846 (deactivate_process): Call emacs_gnutls_deinit.
4847
657d08d3
JB
48482011-10-27 Juanma Barranquero <lekktu@gmail.com>
4849
4850 * image.c (x_create_x_image_and_pixmap):
4851 * w32.c (sys_rename, w32_delayed_load):
4852 * w32font.c (fill_in_logfont):
4853 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4854
5430d399
JB
48552011-10-26 Juanma Barranquero <lekktu@gmail.com>
4856
4857 * w32fns.c (w32_default_color_map): New function,
4858 extracted from Fw32_default_color_map.
a7ef684b 4859 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4860
fe0055fa
PE
48612011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4862
4863 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4864
e6346438
SM
48652011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4866
4867 * keyboard.c (test_undefined): New function (bug#9751).
4868 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4869
e112cc37
ET
48702011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4871
4872 * sysdep.c (init_sys_modes): Fix the check for the controlling
4873 terminal (Bug#6649).
4874
7b5d6677
EZ
48752011-10-20 Eli Zaretskii <eliz@gnu.org>
4876
4877 * dispextern.h (struct bidi_it): New member next_en_type.
4878
4879 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4880 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4881 current character, check also for next_en_type being WEAK_EN.
4882 (bidi_resolve_weak): Don't enter the expensive loop if the current
4883 position is before next_en_pos. Record the bidi type of the first
4884 non-ET, non-BN character we find, in addition to its position.
4885 (bidi_level_of_next_char): Invalidate next_en_type when
4886 next_en_pos is over-stepped.
4887
7da0b018
PE
48882011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4889
4890 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4891 * editfns.c: Rewrite current-time-zone so that it invokes
4892 the equivalent of (format-time-string "%Z") to get the time zone name.
4893 This fixes a bug when the time zone name contains characters that
4894 need converting from the system time locale to Emacs internal format.
4895 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4896 that patch fixed format-time-string to do the conversion, but
4897 I forgot to fix current-time-zone.
4898 (format_time_string): New function, containing most of
4899 what Fformat_time_string used to contain.
4900 (Fformat_time_string): Rewrite in terms of format_time_string.
4901 This doesn't change this function's behavior.
4902 (current-time-zone): Rewrite to use format_time_string.
4903 This fixes the bug reported by Michael Schierl in
4904 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4905 Jason Rumney's 2007-06-07 change worked around this bug, but
4906 didn't fix it.
4907 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4908
8547b010
EZ
49092011-10-19 Eli Zaretskii <eliz@gnu.org>
4910
4911 * xdisp.c (start_display): If the character at POS is displayed
4912 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4913 (try_window_reusing_current_matrix): If a line ends in a display
4914 vector or the next line starts in a display vector, continue
4915 redrawing the window even though the character position of
4916 start_row was reached.
8547b010
EZ
4917 (Bug#9771, part 2)
4918
4e948d15
CY
49192011-10-18 Chong Yidong <cyd@gnu.org>
4920
4921 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4922 with nobreak-char-display too.
4923
4787455f
EZ
49242011-10-18 Eli Zaretskii <eliz@gnu.org>
4925
4926 Fix part 3 of bug#9771.
4927 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4928 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4929 non-neutral characters if the current character is a paragraph
4930 separator (a.k.a. Newline). This avoids running the same
4931 expensive loop twice, once when we consume the preceding newline
4932 and the other time when the line actually needs to be displayed.
4933 Avoid the loop when we see neutrals on the base embedding level
4934 following a character whose directionality is the same as the
4935 paragraph's. This avoids running the expensive loop when a line
4936 ends in a long sequence of neutrals, like control characters.
4937 Add assertion against STRONG_AL type. Slightly rearrange code
4938 that determines the type of a neutral given the first non-neutral
4939 that follows it.
4940 (bidi_level_of_next_char): Set next_en_pos to zero when
4941 invalidating its info.
4942
2c91f553
EZ
49432011-10-17 Eli Zaretskii <eliz@gnu.org>
4944
4945 * xdisp.c (push_display_prop): Determine whether to record string
4946 or buffer position by IT->string, not by IT->method. Allow
4947 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4948 (move_it_vertically_backward): Don't look for character position
4949 immediately after the newline when in a continuation line.
4950 (Bug#9771, part 1)
2c91f553 4951
c7b08b0d
MR
49522011-10-15 Martin Rudalics <rudalics@gmx.at>
4953
4954 * window.c (coordinates_in_window): Rewrite and delabelize
4955 vertical border check. (Bug#5357) (Bug#9618)
4956
6b02f655
SM
49572011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4958
4959 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4960 errors in XSetWindowBorder (bug#9310).
4961
81d40c92
DA
49622011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4963
4964 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4965 avoid crash when xmalloc overrun checking is enabled.
4966
d4172c3b
EZ
49672011-10-13 Eli Zaretskii <eliz@gnu.org>
4968
4969 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4970 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4971 cursor motion with <left> and <right> arrow keys.
4972
4973 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4974 some callers set that themselves.
4975
b00eea75
EZ
49762011-10-12 Eli Zaretskii <eliz@gnu.org>
4977
4978 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4979 display string and the previous row comes from the same string and
4980 is empty. (Bug#9739) (Bug#9738)
4981
8fe012c4
SM
49822011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4983
4984 * doc.c (get_doc_string): Encode file name (bug#9735).
4985
0074aef2
EZ
49862011-10-12 Eli Zaretskii <eliz@gnu.org>
4987
79beb178
EZ
4988 * bidi.c (bidi_level_of_next_char):
4989 * xdisp.c (get_visually_first_element): Remove old incorrect
4990 comments regarding the Unicode Line Separator character.
4991
0074aef2
EZ
4992 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4993
6e4b3fbe
DA
49942011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4995
4996 * alloc.c (Fgc_status): Do not access beyond zombies array
4997 boundary if nzombies > MAX_ZOMBIES.
4998 * alloc.c (dump_zombies): Add missing format specifier.
4999
0324f3af
PE
50002011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5001
b5525cac
PE
5002 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5003 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5004
0324f3af
PE
5005 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5006 Some packages use them to denote characters with modifiers.
5007
e9b5f888
AS
50082011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5009
5010 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5011 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5012 matching a pp-number. Rename parameter var to var1.
5013
127827c0
SM
50142011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5015
5016 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5017
c8fd3bd0
GM
50182011-10-08 Glenn Morris <rgm@gnu.org>
5019
5020 * callint.c (Fcall_interactively): Give a more explicit error for the
5021 'c' case with a non-character input. (Bug#8479)
5022
352ec8ff
EZ
50232011-10-08 Eli Zaretskii <eliz@gnu.org>
5024
03669ccb
EZ
5025 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5026 lines.
7061c986
EZ
5027 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5028 lines that are hscrolled on the left.
03669ccb 5029
352ec8ff
EZ
5030 * dispnew.c (buffer_posn_from_coords): Account for a possible
5031 presence of header-line. (Bug#4426)
5032
a66cfb1c
SM
50332011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5034
6b02f655
SM
5035 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5036 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5037
7c5ee88e
PE
50382011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5039
5040 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5041 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5042 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5043 this makes Emacs dump core during garbage collection on rare
5044 occasions. sizeof is obviously inferior to offsetof here, so
5045 stick with offsetof.
5046 (GC_POINTER_ALIGNMENT): New macro.
5047 (mark_memory): Omit 3rd (offset) arg; caller changed.
5048 Don't assume EMACS_INT alignment is the same as pointer alignment.
5049
df1bbe5b
SM
50502011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5051
5052 * keyboard.c (read_key_sequence_remapped): New var.
5053 (read_key_sequence): Compute remapping in the right buffer.
5054 (command_loop_1): Use read_key_sequence's remapping directly.
5055
51553db6
SM
50562011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5057
32c1fffd
SM
5058 * dired.c (file_name_completion): Don't expand file name.
5059 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5060 before checking file name handler.
5061
51553db6
SM
5062 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5063 they've been requested explicitly (bug#9591).
5064
b6bd1599 50652011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5066
5067 * keymap.c (Fsingle_key_description): Use make_specified_string
5068 instead of build_string to build string from push_key_description.
5069 (Bug#5193)
5070
f701dc2a
PE
50712011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5072
4222c55d
PE
5073 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5074 This fixes a Y2038 bug on 64-bit hosts.
5075 * buffer.c (reset_buffer):
5076 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5077 (Fclear_buffer_auto_save_failure):
5078 Use 0, not -1, to represent an unset failure time, since time_t
5079 might not be signed.
5080
f701dc2a
PE
5081 Remove dependency on glibc malloc internals.
5082 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5083 Move back here from lisp.h, but with their new implementations.
5084 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5085 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5086 * charset.c (charset_table_init): New static var.
5087 (syms_of_charset): Use it instead of xmalloc. This removes a
5088 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5089 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5090 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5091 Move back to alloc.c.
5092 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5093 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5094
9ceebf39
JD
50952011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5096
5097 * nsterm.m (windowDidResize): Call x_set_window_size only when
5098 ns_in_resize is true. Otherwise set pixelwidth/height and
5099 call change_frame_size (Bug#9628).
5100
cb993c58
PE
51012011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5102
3930c88b
PE
5103 Port --enable-checking=all to Fedora 14 x86-64.
5104 * charset.c (syms_of_charset): Also account for glibc malloc's
5105 internal overhead when calculating the initial malloc maximum.
5106
cb993c58
PE
5107 Port --enable-checking=all to Fedora 14 x86.
5108 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5109 Move to lisp.h.
5110 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5111 (overrun_check_realloc, overrun_check_free):
5112 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5113 That way, xmalloc returns a properly-aligned pointer even if
5114 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5115 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5116 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5117 into account when calculating the initial malloc maximum.
5118 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5119 Move here from alloc.c, so that charset.c can use it too.
5120 Properly align; the old code wasn't right for common 32-bit hosts
5121 when configured with --enable-checking=all.
5122 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5123 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5124
31bed486
EZ
51252011-09-29 Eli Zaretskii <eliz@gnu.org>
5126
04c70788 5127 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5128 use EDOM.
5129
fbcaa2f3
EZ
51302011-09-28 Eli Zaretskii <eliz@gnu.org>
5131
5132 * xdisp.c (compute_display_string_end): If there's no display
5133 string at CHARPOS, return -1.
5134
5135 * bidi.c (bidi_fetch_char): When compute_display_string_end
5136 returns a negative value, treat the character as a normal
5137 character not covered by a display string. (Bug#9624)
5138
a239d4e9
JB
51392011-09-28 Juanma Barranquero <lekktu@gmail.com>
5140
5141 * lread.c (Fread_from_string): Fix typo in docstring.
5142
88652fd5
EZ
51432011-09-27 Eli Zaretskii <eliz@gnu.org>
5144
5145 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5146 newline, reseat the iterator instead of bidi-iterating there one
5147 character at a time. (Bug#9610)
32c1fffd
SM
5148 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5149 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5150
ed497dd4
AS
51512011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5152
5153 * lread.c (readevalloop): Use correct code for NBSP.
5154 (read1): Likewise. (Bug#9608)
5155
b2bf61aa
MA
51562011-09-25 Michael Albinus <michael.albinus@gmx.de>
5157
5158 * dbusbind.c (Fdbus_register_signal): When service is not
5159 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5160
32bbb17c
GM
51612011-09-25 Glenn Morris <rgm@gnu.org>
5162
5163 * buffer.c (truncate-lines): Doc fix.
5164
94e0933e
CY
51652011-09-24 Chong Yidong <cyd@stupidchicken.com>
5166
5167 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5168 (Fset_window_next_buffers): Doc fix.
5169
cddde921
GM
51702011-09-24 Glenn Morris <rgm@gnu.org>
5171
5172 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5173
1260aef1
PE
51742011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5175
25b4bfa0
PE
5176 Fix minor problems found by static checking.
5177 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5178 * indent.c (Fvertical_motion): Fix == vs = typo.
5179
e3cbd34b
EZ
51802011-09-24 Eli Zaretskii <eliz@gnu.org>
5181
a66cfb1c
SM
5182 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5183 Default value is now t. Doc fix.
6bf7006f 5184
e3cbd34b 5185 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5186 logic when moving up, not only when moving down. Fix the
e3cbd34b 5187 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5188 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5189
5190 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5191 CHARPOS is covered by a display string which includes newlines.
5192 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5193 is covered by a display string with embedded newlines.
5194
a3de0cbd
MA
51952011-09-24 Michael Albinus <michael.albinus@gmx.de>
5196
5197 * dbusbind.c (Fdbus_register_signal): Add match rule to
5198 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5199 (Fdbus_register_method, Vdbus_registered_objects_table):
5200 Fix docstring.
a3de0cbd 5201
b260039d
JM
52022011-09-24 Jim Meyering <meyering@redhat.com>
5203
32c1fffd 5204 do not ignore write error for any output size
b260039d
JM
5205 The previous change was incomplete.
5206 While it makes emacs --batch detect the vast majority of stdout
5207 write failures, errors were still ignored whenever the output size is
5208 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5209 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5210 && echo FAIL: ignored write error
5211 FAIL: ignored write error
5212 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5213 && echo FAIL: ignored write error
5214 FAIL: ignored write error
5215 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5216
8eca8a7c
AS
52172011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5218
5219 * emacs.c (Fkill_emacs): In noninteractive mode exit
5220 non-successfully if a write error occurred on stdout. (Bug#9574)
5221
3341db62
EZ
52222011-09-21 Eli Zaretskii <eliz@gnu.org>
5223
5224 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5225 the xassert test.
5226
5227 * dispextern.h (struct it): Update the comment documenting what
5228 can it->OBJECT be.
5229
8c203dbf
EZ
52302011-09-20 Eli Zaretskii <eliz@gnu.org>
5231
5232 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5233 a display string, extend search for cursor position to end of row.
5234 (find_row_edges): If the row ends in a newline from a display
5235 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5236 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5237 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5238 non-empty line. Fixes confusing cursor motion with arrow keys at
5239 the beginning of a line that starts with whitespace.
8c203dbf 5240
a4824228
LMI
52412011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5242
5243 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5244 (bug#9493).
5245
33ed493b
CY
52462011-09-18 Chong Yidong <cyd@stupidchicken.com>
5247
5248 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5249 boolean (Bug#9154).
5250
56cd55c8
EZ
52512011-09-18 Eli Zaretskii <eliz@gnu.org>
5252
5253 * xdisp.c (display_line): Record maximum and minimum buffer
5254 positions even if no glyphs were produced (e.g., by a zero-width
5255 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5256 buffer positions that will be removed from the glyph row because
5257 they don't fit.
c02dcedf
EZ
5258 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5259 column is beyond frame width: don't subtract 1 "pixel" when
5260 computing width of the stretch.
3e62b7e0
EZ
5261 (reseat_at_next_visible_line_start): Undo the change made on
5262 2011-09-17 that saved paragraph information and restored it after
5263 the call to `reseat'. (Bug#9545)
56cd55c8 5264
5ed99d36 52652011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5266
5267 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5268 and turn window cursor on if cleared (Bug#9415).
5269
5ed99d36 52702011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5271
5272 * search.c (boyer_moore): Take unibyte characters from pattern
5273 literally. (Bug#9458)
5274
9bade7b2
EZ
52752011-09-18 Eli Zaretskii <eliz@gnu.org>
5276
5277 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5278
e5e9d610
PE
52792011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5280
87e4427a
PE
5281 Fix minor problem found by static checking.
5282 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5283 initialized, to pacify gcc -Wuninitialized.
5284
e5e9d610
PE
5285 * fileio.c: Report proper errno when syscall falls.
5286 (Finsert_file_contents): Save and restore errno,
5287 so that report_file_error outputs the correct diagnostic.
5288 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5289
a1674f0b
EZ
52902011-09-18 Eli Zaretskii <eliz@gnu.org>
5291
5292 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5293
fbfb6dd4
EZ
52942011-09-17 Eli Zaretskii <eliz@gnu.org>
5295
5296 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5297 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5298
bb187662
EZ
52992011-09-17 Eli Zaretskii <eliz@gnu.org>
5300
1137e8b8 5301 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5302 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5303
5304 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5305 (bidi_find_paragraph_start): Search back for paragraph beginning
5306 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5307 (bidi_move_to_visually_next): Only trigger paragraph-related
5308 computations when the last character is a newline or at EOB, not
5309 just any NEUTRAL_B. (Bug#9470)
5310
bb187662
EZ
5311 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5312 truncated lines if point is covered by a display string. (Bug#9524)
5313
2e621251
PE
53142011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5315
5316 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5317 (cons_to_x_long): New function.
5318 (lisp_data_to_selection_data): Use it. Correct the test for
5319 short-versus-long data; it was negated. Break out of vector
5320 loop, for efficiency, when a long datum is discovered.
5321
91a15bc6
SM
53222011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5323
5324 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5325
b41c3a35
EZ
53262011-09-16 Eli Zaretskii <eliz@gnu.org>
5327
5328 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5329 GCC PR/17406) by declaring this function with external scope.
5330
7812ba2d
PE
53312011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5332
5333 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5334 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5335
cf7edc2a
AS
53362011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5337
5338 * editfns.c (Fformat): Correctly handle text properties on "%%".
5339
bd01620e
EZ
53402011-09-15 Eli Zaretskii <eliz@gnu.org>
5341
5342 * xterm.c (x_draw_composite_glyph_string_foreground):
5343 * w32term.c (x_draw_composite_glyph_string_foreground):
5344 * term.c (encode_terminal_code):
5345 * composite.c (composition_update_it, get_composition_id):
5346 * xdisp.c (get_next_display_element)
5347 (fill_composite_glyph_string): Add comments about special meaning
5348 of TAB characters in a composition.
5349
a02719a3
PE
53502011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5351
5352 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5353 This occurs when processing a multibyte format.
5354 Problem reported by Wolfgang Jenker.
a02719a3 5355
72589a3c
JB
53562011-09-15 Johan Bockgård <bojohan@gnu.org>
5357
5358 * xdisp.c (try_cursor_movement): Only check for exact match if
5359 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5360
1c14176c
PE
53612011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5362
5363 Remove unused external symbols.
5364 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5365 * xdisp.c (calc_pixel_width_or_height): Now static.
5366 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5367 * indent.c (check_display_width):
5368 * w32term.c: Fix comment to match code.
5369 * xterm.c, xterm.h (x_catching_errors): Remove.
5370
d2eea5b5
PE
53712011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5372
5373 * xselect.c: Use signed conversions more consistently (Bug#9498).
5374 (selection_data_to_lisp_data): Assume incoming selection data are
5375 signed integers, not unsigned. This is to be consistent with
5376 outgoing selection data, which was modified to use signed integers
5377 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5378 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5379 expects long, not unsigned long.
5380
46888499
EZ
53812011-09-14 Eli Zaretskii <eliz@gnu.org>
5382
5383 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5384 computation of loop end. Reported by Johan Bockgård
5385 <bojohan@gnu.org>.
5386
ef8ef9fb
CY
53872011-09-13 Chong Yidong <cyd@stupidchicken.com>
5388
5389 * frame.c (Fother_visible_frames_p): Function deleted.
5390
fa819fed
EZ
53912011-09-12 Eli Zaretskii <eliz@gnu.org>
5392
5393 * indent.c (compute_motion): Process display vector front to back
5394 rather than the other way around. (Bug#2496)
5395
2ba8e008
SM
53962011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5397
5398 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5399
20f53c69
CY
54002011-09-11 Chong Yidong <cyd@stupidchicken.com>
5401
5402 * minibuf.c (Fread_from_minibuffer): Doc fix.
5403
d562d7a4
EZ
54042011-09-11 Eli Zaretskii <eliz@gnu.org>
5405
5406 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5407 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5408
1c4d7f3d
LMI
54092011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5410
5411 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5412 value for non-existent files.
5413
b885bf36
EZ
54142011-09-11 Eli Zaretskii <eliz@gnu.org>
5415
5416 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5417 set its "size" to -1. This will set the modtime_size field of
5418 the corresponding buffer to -1, which is what
5419 verify-visited-file-modtime expects for files that do not exist.
5420 (Bug#9139)
5421
6612f0bf
PE
54222011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5423
5424 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5425 here ...
5426 * lisp.h: ... from here. push_key_description is no longer
5427 defined in keyboard.c, so its declaration should not be in
5428 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5429 logically belongs with push_key_description.
5430
dfb3f755
PE
54312011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5432
5433 * buffer.h: Include <sys/types.h> instead of <time.h>.
5434 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5435 Problem reported by Herbert J. Skuhra.
5436
3134906c
LMI
54372011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5438
5439 * xml.c (parse_region): Make the parsing work for
5440 non-comment-starting XML files again (bug#9144).
5441
8d903f4e
AS
54422011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5443
5444 * image.c (gif_load): Fix calculation of bottom and right corner.
5445 (Bug#9468)
5446
80ad64f4
EZ
54472011-09-10 Eli Zaretskii <eliz@gnu.org>
5448
5449 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5450 redisplay in small windows.
5451
208a048d
EZ
54522011-09-09 Eli Zaretskii <eliz@gnu.org>
5453
5454 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5455
9b1c252e
MR
54562011-09-08 Martin Rudalics <rudalics@gmx.at>
5457
5458 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5459 Operate on live windows only.
5460
2949f33b
JB
54612011-09-08 Juanma Barranquero <lekktu@gmail.com>
5462
5463 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5464
e08dcafd
EZ
54652011-09-07 Eli Zaretskii <eliz@gnu.org>
5466
5467 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5468 only under bidi iteration.
5469
115b96bd
JD
54702011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5471
5472 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5473
c8199d0f
PE
54742011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5475
5476 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5477 Without this fix, the command to link temacs failed due to an
5478 undefined symbol __builtin_isnan. This is because
5479 /usr/include/iso/math_c99.h #defines isnan(x) to
5480 __builtin_isnan(x), but the bundled gcc, which identifies itself
5481 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5482 a __builtin_isnan.
5483 * floatfns.c (isnan): #undef, and then #define to a clone of
5484 what's in data.c.
5485 (Fisnan): Always define, since it's always available now.
5486 (syms_of_floatfns): Always define isnan at the Lisp level.
5487
e39b275c 54882011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5489
5490 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5491
b2db44d9 54922011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5493
f4af5137 5494 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5495 The previous code assumed that file offsets (off_t values) fit in
5496 EMACS_INT variables, which is not true on typical 32-bit hosts.
5497 The code messed up by falsely reporting buffer overflow in cases
5498 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5499 when "big" contains more than 2**29 bytes, even though this
5500 inserts just one byte and does not overflow the buffer.
5501 (Finsert_file_contents): Store file offsets as off_t
5502 values, not as EMACS_INT values. Check for overflow when
5503 converting between EMACS_INT and off_t. When checking for
5504 buffer overflow or for overlap, take the offsets into account.
5505 Don't use EMACS_INT for small values where int suffices.
5506 When checking for overlap, fix a typo: ZV was used where
5507 ZV_BYTE was intended.
5508 (Fwrite_region): Don't assume off_t fits into 'long'.
5509 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5510
ecfc0a49
MA
55112011-09-05 Michael Albinus <michael.albinus@gmx.de>
5512
5513 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5514
6511acf2 55152011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5516
0999621a 5517 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5518
5519 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5520 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5521 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5522 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5523 (modify_event_symbol): Do not assume that the length of
5524 name_alist_or_stem is safe to alloca and fits in int.
5525 (Fexecute_extended_command): Likewise for function name and binding.
5526 (Frecursion_depth): Wrap around reliably on integer overflow.
5527 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5528 since some callers pass EMACS_INT values.
5529 (Fsingle_key_description): Don't crash if symbol name contains more
5530 than MAX_ALLOCA bytes.
5531 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5532 (get_minibuffer): Arg is now EMACS_INT, not int.
5533 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5534 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5535 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5536
2be7d702
PE
5537 * dbusbind.c (signature_cat): New function.
5538 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5539 Do not overrun buffer; instead, report string overflow.
5540
9d1df220
PE
5541 * dispnew.c (add_window_display_history): Don't overrun buffer.
5542 Truncate instead; this is OK since it's just a log.
5543
33ef5c64
PE
5544 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5545 even if the time zone offset is outlandishly large.
5546 Don't mishandle offset == INT_MIN.
5547
66c6fdd5
PE
5548 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5549 when creating daemon; the previous buffer-overflow check was incorrect.
5550
d749b01b
PE
5551 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5552 which has the guts of the old verror function.
5553
b5cd1905
PE
5554 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5555 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5556
6e1a67fb
PE
5557 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5558 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5559 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5560 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5561 length of string rather than counting it via multiple sprintfs;
5562 that's simpler and more reliable.
c21721cc
PE
5563 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5564 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5565 sprintf, in case result does not fit in int.
5566
c57b67fc
PE
5567 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5568 (fontset_from_font): Print it.
5569
8a401434
PE
5570 * frame.c (tty_frame_count): Now printmax_t, not int.
5571 (make_terminal_frame, set_term_frame_name): Print it.
5572 (x_report_frame_params): In X, window IDs are unsigned long,
5573 not signed long, so print them as unsigned.
5574 (validate_x_resource_name): Check for implausibly long names,
5575 and don't assume name length fits in 'int'.
5576 (x_get_resource_string): Don't blindly alloca invocation name;
5577 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5578 not fit in int.
5579
6e1a67fb
PE
5580 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5581 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5582 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5583
0df02bf3
PE
5584 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5585 Use esprintf, not sprintf, in case result does not fit in int.
5586
48e30793
PE
5587 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5588 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5589 it as a large positive number.
5590 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5591 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5592
a66ff6d8
PE
5593 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5594 in case result does not fit in int.
5595
aca216ff
PE
5596 * print.c (float_to_string): Detect width overflow more reliably.
5597 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5598 buffer overrun. Don't assume list length fits in 'int'. Treat
5599 print length of 0 as 0, not as infinity; to be consistent with other
5600 uses of print length in this function. Don't overflow print length
5601 index. Don't assume hash table size fits in 'long', or that
5602 vectorlike size fits in 'unsigned long'.
5603
31c286f7
PE
5604 * process.c (make_process): Use printmax_t, not int, to format
5605 process-name gensyms.
5606
55e5faa1
PE
5607 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5608
80f2e268
PE
5609 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5610 to avoid potential buffer overrun.
5611
670741ab
PE
5612 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5613 if X resource line is longer than 512 bytes.
5614
b7163a50
PE
5615 * xfns.c (x_window): Make sprintf buffer a bit bigger
5616 to avoid potential buffer overrun.
5617
ae58ff1f
PE
5618 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5619
c43c8a6a
PE
5620 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5621
3f8236f4
PE
56222011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5623
53e9fe90 5624 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5625 Without these, Emacs silently mishandles large integers sometimes.
5626 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5627 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5628
6511acf2
PE
5629 * xdisp.c (try_window_id): Check Emacs fixnum range before
5630 converting to 'int'.
806add1d 5631
6511acf2 5632 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5633 Check that an Emacs fixnum is in range before assigning it to 'int'.
5634 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5635 values converted from Emacs fixnums.
5636 (Frecenter): Don't wrap around a line count if it is out of 'int'
5637 range; instead, treat it as an extreme value.
5638 (Fset_window_configuration, compare_window_configurations):
5639 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5640
6511acf2
PE
5641 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5642 that can exceed INT_MAX. Check that EMACS_INT value is in range
5643 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5644 (match_limit): Don't assume that a fixnum can fit in 'int'.
5645
6511acf2 5646 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5647 exceed INT_MAX.
5648
6511acf2 5649 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5650 (Fvertical_motion): Don't wrap around LINES values that don't fit
5651 in 'int'. Instead, treat them as extreme values. This is good
5652 enough for windows, which can't have more than INT_MAX lines anyway.
5653
fcb901a7
LMI
56542011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5655
0f2f6b6d
LMI
5656 * Require libxml/parser.h to avoid compilation warning.
5657
fcb901a7
LMI
5658 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5659
5660 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5661 since this reportedly can destroy thread storage.
5662
6e20a0d4
CY
56632011-08-30 Chong Yidong <cyd@stupidchicken.com>
5664
5665 * syntax.c (find_defun_start): Update all cache variables if
5666 exiting early (Bug#9401).
5667
148ae00e
EZ
56682011-08-30 Eli Zaretskii <eliz@gnu.org>
5669
f6cfbd8f
EZ
5670 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5671
148ae00e
EZ
5672 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5673 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5674 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5675
5676 * term.c (tty_append_glyph): New function.
5677 (produce_stretch_glyph): Static function and its prototype deleted.
5678
a66cfb1c
SM
5679 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5680 Add prototypes.
148ae00e 5681
c4a07a4c
PE
56822011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5683
5684 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5685 when checking :margin (Bug#9390).
5686 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5687 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5688 so that the name doesn't mislead. All uses changed.
5689
6bc8cd65
JB
56902011-08-28 Johan Bockgård <bojohan@gnu.org>
5691
5692 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5693 set_tty_hooks.
5694
dca4927e
EZ
56952011-08-27 Eli Zaretskii <eliz@gnu.org>
5696
5697 * xdisp.c (move_it_to): Don't bail out early when reaching
5698 position beyond to_charpos, if we are scanning backwards.
5699 (move_it_vertically_backward): When DY == 0, make sure we get to
5700 the first character in the line after the newline.
5701
f2cad773
PE
57022011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5703
5704 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5705 (ccl_driver): Do not generate an out-of-range pointer.
5706 (Fccl_execute_on_string): Remove unnecessary check for
5707 integer overflow, noted by Stefan Monnier in
5708 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5709 Remove a FIXME that didn't need fixing.
5710 Simplify the newly-introduced buffer reallocation code.
5711
0cae2cdb
JB
57122011-08-27 Juanma Barranquero <lekktu@gmail.com>
5713
5714 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5715
5fc295a4 57162011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5717
70c60eb2 5718 Integer and memory overflow issues (Bug#9196).
726e0ab1 5719
d31850da
PE
5720 * doc.c (get_doc_string): Rework so that
5721 get_doc_string_buffer_size is the actual buffer size, rather than
5722 being 1 less than the actual buffer size; this makes xpalloc more
5723 convenient.
5724
a69fbedb
PE
5725 * image.c (x_allocate_bitmap_record, cache_image):
5726 * xselect.c (Fx_register_dnd_atom):
5727 Simplify previous changes by using xpalloc.
5728
fe5c5d37
PE
5729 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5730 since either will do and ptrdiff_t is convenient with xpalloc.
5731
0065d054
PE
5732 * charset.c (charset_table_size)
5733 (struct charset_sort_data.priority): Now ptrdiff_t.
5734 (charset_compare): Don't overflow if priorities differ greatly.
5735 (Fsort_charsets): Don't assume list length fits in int.
5736 Check for size-calculation overflow when allocating sort data.
5737 (syms_of_charset): Allocate an initial charset table that is
5738 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5739
5740 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5741
5742 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5743 The actual value is always <= INT_MAX, and leaving it unsigned made
5744 overflow checking harder.
5745
5746 * dispextern.h (struct glyph_matrix.rows_allocated)
5747 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5748 with xpalloc. The values are still always <= INT_MAX.
5749
5750 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5751
5752 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5753 (SAFE_NALLOCA): New macro.
5754
5755 * region-cache.c (struct boundary.pos, find_cache_boundary)
5756 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5757 (set_cache_region, invalidate_region_cache)
5758 (revalidate_region_cache, know_region_cache, region_cache_forward)
5759 (region_cache_backward, pp_cache):
5760 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5761 so that ptrdiff_t * can be passed to xpalloc.
5762 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5763 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5764 (pp_cache): Don't assume cache_len fits in int.
5765 * region-cache.h: Adjust extern decls to match.
5766
5767 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5768 EMACS_INT, since either will do, for xpalloc.
5769
5770 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5771 (xnmalloc, xnrealloc, xpalloc): New functions.
5772
726e0ab1
PE
5773 * bidi.c (bidi_shelve_header_size): New constant.
5774 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5775 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5776
51f30bc5 5777 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5778 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5779 (overlay_strings):
5780 Don't update size of array until after memory allocation succeeds,
5781 because xmalloc/xrealloc may not return.
0065d054
PE
5782 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5783 now that we have proper integer overflow checking.
5784 (record_overlay_string, overlay_strings): Catch overflows when
5785 calculating size of overlay_str_buf.
726e0ab1 5786
0065d054
PE
5787 * callproc.c (Fcall_process): Check for size overflow when
5788 calculating size of args2.
5789 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5790 Normally we prefer signed values, but sticking with ptrdiff_t would
5791 require adding more-complicated checks.
726e0ab1
PE
5792
5793 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5794 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5795 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5796 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5797
5798 * character.c (Fstring): Check for size-calculation overflow.
5799
5800 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5801 unnecessary integer overflow. Check for size overflow.
5802 (encode_coding_object): Don't update size until xmalloc succeeds.
5803
5804 * composite.c (get_composition_id): Check for overflow in glyph
5805 length calculations.
5806
5807 Integer and memory overflow fixes for display code.
5808 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5809 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5810 (scrolling_window): Check for overflow in size calculations.
5811 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5812 Don't assume glyph table len fits in int.
5813 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5814 (row_table_size): Now ptrdiff_t, not int.
5815 (scrolling_window): Avoid overflow in size calculations.
5816 Don't update size until allocation succeeds.
5817 * fns.c (concat): Check for overflow in size calculations.
5818 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5819 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5820 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5821
5822 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5823 (get_doc_string): Check for size calculation overflow.
5824 Don't update size until allocation succeeds.
5825 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5826 EMACS_INT, where ptrdiff_t will do.
5827 (Fsubstitute_command_keys): Check for string overflow.
5828
5829 * editfns.c (set_time_zone_rule): Don't assume environment length
5830 fits in int.
5831 (message_length): Now ptrdiff_t, not int.
5832 (Fmessage_box): Don't update size until allocation succeeds.
5833 Don't assume message length fits in int.
5834 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5835
0065d054
PE
5836 * emacs.c (main): Do not reallocate argv, since there is a null at
5837 the end that can be overwritten, and this way there's no need to
5838 worry about size-calculation overflow.
5839 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5840
5841 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5842 alloc succeeds.
5843 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5844
5845 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5846 (x_set_scroll_bar_width, x_figure_window_size):
5847 Check for integer overflow.
5848 (x_set_alpha): Do not assume XINT fits in int.
5849
5850 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5851 This is for the members text_lines, text_cols, total_lines, total_cols,
5852 where the system imposes an 'int' limit.
5853
5854 * fringe.c (Fdefine_fringe_bitmap):
5855 Don't update size until alloc works.
5856
5857 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5858 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5859
5860 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5861 Check for size-calculation overflow.
5862 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5863 do, as we prefer signed integers.
5864 (id_to_widget.max_size, id_to_widget.used)
5865 (xg_store_widget_in_map, xg_remove_widget_from_map)
5866 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5867 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5868 Use and return ptrdiff_t, not int.
5869 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5870 * gtkutil.h: Change prototypes to match the above.
5871
5872 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5873 are duplicate now that they've been promoted to lisp.h.
5874 (x_allocate_bitmap_record, x_alloc_image_color)
5875 (make_image_cache, cache_image, xpm_load):
5876 Don't update size until alloc is done.
5877 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5878 (x_detect_edges):
3256efce 5879 Check for size calculation overflow.
726e0ab1
PE
5880 (ct_colors_allocated_max): New constant.
5881 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5882 overflow.
3256efce 5883
726e0ab1
PE
5884 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5885 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5886 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5887 Use ptrdiff_t, not int, to count maps.
5888 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5889 calculations. Don't update size until allocation succeeds.
5890 Redo calculations to avoid overflow.
726e0ab1
PE
5891 * keyboard.h: Change prototypes to match the above.
5892
5893 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5894 to count maps.
5895 (current_minor_maps): Check for size calculation overflow.
5896 * keymap.h: Change prototypes to match the above.
5897
5898 * lread.c (read1, init_obarray): Don't update size until alloc done.
5899
5900 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5901 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5902
726e0ab1
PE
5903 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5904 Now ptrdiff_t, not int.
5905 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5906 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5907
5908 * process.c (Fnetwork_interface_list): Check for overflow
5909 in size calculation.
5910
5911 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5912
5913 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5914 overflow. Don't bother calling xmalloc when xrealloc will do.
5915
5916 * search.c (Freplace_match): Check for size calculation overflow.
5917 (Fset_match_data): Don't assume list lengths fit in 'int'.
5918
5919 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5920 for command line length. Do not attempt to address one before the
5921 beginning of an array, as that's not portable.
5922
5923 * term.c (max_frame_lines): Remove; unused.
5924 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5925 not int.
5926 (encode_terminal_code, calculate_costs): Check for size
5927 calculation overflow.
5928 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5929 table lengths and related sizes. Don't update size until alloc
5930 done. Redo calculations to avoid overflow.
5931 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5932
5933 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5934 subtracting pointers.
5935 (gobble_line): Check for overflow more carefully. Don't update size
5936 until alloc done.
5937
5938 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5939 Don't update size until alloc done.
5940 Redo size calculations to avoid overflow.
5941 Check for size calculation overflow.
0065d054 5942 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5943
5944 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5945 Use ptrdiff_t, not int, for sizes.
5946 (store_mode_line_noprop_char): Don't update size until alloc done.
5947
0065d054
PE
5948 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5949 Use ptrdiff_t, not int, for sizes.
5950 (Finternal_make_lisp_face, cache_face):
5951 Check for size calculation overflow.
5952 (cache_face): Treat size calculation overflows as if they were
5953 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5954
5955 * xfns.c (x_encode_text, x_set_name_internal)
5956 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5957 sizes, since they can exceed INT_MAX in size. Check for size
5958 calculation overflow.
5959
0065d054
PE
5960 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5961 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5962 Don't update size until alloc done.
5963
0065d054 5964 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5965 as sprintf is limited to int lengths.
1d526e2f 5966
252c5ee1
PE
5967 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5968 (X_LONG_MIN): New macros.
864d7ce7
PE
5969 Use them to make the following changes clearer.
5970 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5971 This change doesn't affect the value now, but it may help remind
5972 future maintainers not to raise the value too much later.
5973 (SELECTION_QUANTUM): Remove, replacing with ...
5974 (selection_quantum): ... new function, which avoids overflow.
5975 All uses changed.
5976 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5977 assumption that selection length fits in 'int'.
5978 (x_reply_selection_request, x_handle_selection_request)
5979 (x_get_window_property, receive_incremental_selection)
5980 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5981 (lisp_data_to_selection_data, clean_local_selection_data):
5982 Use ptrdiff_t, not int, to record length of selection.
5983 (x_reply_selection_request, x_get_window_property)
5984 (receive_incremental_selection, x_property_data_to_lisp):
5985 Redo calculations to avoid overflow.
5986 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5987 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5988 something.
5989 (x_get_window_property, receive_incremental_selection)
5990 (lisp_data_to_selection_data, x_property_data_to_lisp):
5991 Check for size-calculation overflow.
5992 (x_get_window_property, receive_incremental_selection)
5993 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5994 Don't store size until memory allocation succeeds.
5995 (x_get_window_property): Plug memory leak on memory exhaustion.
5996 Don't double-block input; malloc is safe here. Don't assume 2**34
5997 - 4 fits in unsigned long. Add an xassert to check
5998 XGetWindowProperty overflow. Be more careful about overflow
5999 calculations, and distinguish size from memory overflow better.
6000 (receive_incremental_selection): When tracing, don't assume
6001 unsigned int is less than INT_MAX.
6002 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6003 harmful) conversions of unsigned short to int.
6004 (lisp_data_to_selection_data): Don't assume that integers
6005 in the range -65535 through -1 fit in an X unsigned short.
6006 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6007 result parameters unless successful. Rely on cons_to_unsigned
6008 to report problems with elements; the old code wasn't right anyway.
6009 (x_check_property_data): Check for int overflow; we cannot use
6010 a wider type due to X limits.
6011 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6012
726e0ab1 6013 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6014
0065d054
PE
6015 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6016 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6017 (x_color_cells): Don't store size until memory allocation succeeds.
6018 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6019 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6020 (x_term_init): Don't assume length fits in int (sprintf is limited
6021 to int size).
bc18e09d 6022
ebfa62c0
PE
6023 Use ptrdiff_t for composition IDs.
6024 * character.c (lisp_string_width):
6025 * composite.c (composition_table_size, n_compositions)
6026 (get_composition_id, composition_gstring_from_id):
6027 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6028 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6029 * window.c (Frecenter):
6030 Use ptrdiff_t, not int, for composition IDs.
6031 * composite.c (get_composition_id): Check for integer overflow.
6032 * composite.h: Adjust prototypes to match the above changes.
6033
d3411f89
PE
6034 Use ptrdiff_t for hash table indexes.
6035 * category.c (hash_get_category_set):
6036 * ccl.c (ccl_driver):
6037 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6038 * coding.c (coding_system_charset_list, detect_coding_system):
6039 * coding.h (struct coding_system.id):
6040 * composite.c (get_composition_id, gstring_lookup_cache):
6041 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6042 * image.c (xpm_get_color_table_h):
6043 * lisp.h (hash_lookup, hash_put):
6044 * minibuf.c (Ftest_completion):
6045 Use ptrdiff_t for hash table indexes, not int (which is too
6046 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6047 32-bit --with-wide-int hosts).
6048
e097a6fa
PE
6049 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6050 Add a FIXME comment about memory leaks.
6051 (syms_of_charset): Don't assume xmalloc returns.
6052
5637687f
PE
6053 Don't assume that stated character widths fit in int.
6054 * character.c (Fchar_width, c_string_width, lisp_string_width):
6055 * character.h (CHAR_WIDTH):
6056 * indent.c (MULTIBYTE_BYTES_WIDTH):
6057 Use sanitize_char_width to avoid undefined and/or bad behavior
6058 with outlandish widths.
a66cfb1c 6059 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6060 now that we have two such functions. All uses changed.
6061 (sanitize_char_width): New inline function.
6062
a2271ba2
PE
6063 Don't assume that tab-width fits in int.
6064 * character.h (sanitize_width): New inline function.
6065 (SANE_TAB_WIDTH): New macro.
6066 (ASCII_CHAR_WIDTH): Use it.
6067 * indent.c (sane_tab_width): Remove. All uses replaced by
6068 SANE_TAB_WIDTH (current_buffer).
6069 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6070
18c52557
PE
6071 * fileio.c: Integer overflow issues with file modes.
6072 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6073
caeeedc1
PE
6074 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6075 Remove unreachable code.
6076 (read_hex, load_charset_map_from_file): Check for integer overflow.
6077
6df6ae42 6078 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6079 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6080 (x_send_scroll_bar_event): Likewise. Check that the size does not
6081 exceed limits imposed by XClientMessageEvent, as well as the usual
6082 ptrdiff_t and size_t limits.
6083
b13995db
PE
6084 * keyboard.c: Overflow, signedness and related fixes.
6085 (make_lispy_movement): Use same integer type in forward decl
6086 that is used in the definition.
6087 (read_key_sequence, keyremap_step):
6088 Change bufsize argument back to int, undoing my 2011-03-30 change.
6089 We prefer signed types, and int is wide enough here.
6090 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6091 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6092 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6093 length, not size_t. Use ptrdiff_t for index, not int.
6094 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6095 possibility of integer overflow.
6096
13464394
PE
6097 Overflow, signedness and related fixes for images.
6098
6099 * dispextern.h (struct it.stack[0].u.image.image_id)
6100 (struct_it.image_id, struct image.id, struct image_cache.size)
6101 (struct image_cache.used, struct image_cache.ref_count):
6102 * gtkutil.c (update_frame_tool_bar):
6103 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6104 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6105 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6106 * nsmenu.m (update_frame_tool_bar):
6107 * xdisp.c (calc_pixel_width_or_height):
6108 * xfns.c (image_cache_refcount):
6109 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6110 on typical 64-bit hosts.
6111
6112 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6113 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6114 Omit unnecessary casts to int.
6115 (parse_image_spec): Check that integers fall into 'int' range
6116 when the callers expect that.
6117 (image_ascent): Redo ascent calculation to avoid int overflow.
6118 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6119 (lookup_image): Remove unnecessary tests.
6120 (xbm_image_p): Locals are now of int, not EMACS_INT,
6121 since parse_image_check makes sure they fit into int.
6122 (png_load, gif_load, svg_load_image):
6123 Prefer int to unsigned where either will do.
6124 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6125 old tiff_error_handler and tiff_warning_handler.
6126 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6127 stack buffer overflows. It uses only the features of vsnprintf
6128 that are common to both POSIX and native Microsoft.
6129 (tiff_error_handler, tiff_warning_handler): Use it.
6130 (tiff_load, gif_load, imagemagick_load_image):
6131 Don't assume :index value fits in 'int'.
6132 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6133 (imagemagick_load_image): Check that crop parameters fit into
6134 the integer types that MagickCropImage accepts. Don't assume
6135 Vimagemagick_render_type has a nonnegative value. Don't assume
6136 size_t fits in 'long'.
6137 (gs_load): Use printmax_t to print the widest integers possible.
6138 Check for integer overflow when computing image height and width.
6139
c11821d4
EZ
61402011-08-26 Eli Zaretskii <eliz@gnu.org>
6141
6142 * xdisp.c (redisplay_window): Don't force window start if point
6143 will be invisible in the resulting window. (Bug#9324)
6144
0c95fcf7
EZ
61452011-08-25 Eli Zaretskii <eliz@gnu.org>
6146
6147 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6148 the display spec is of the form `(space ...)'.
6149 (handle_display_spec): Return the value returned by
6150 handle_single_display_spec, not just 1 or zero.
6151 (handle_single_display_spec): If the display spec is of the form
6152 `(space ...)', and specifies display in the text area, return 2
6153 rather than 1.
fee65a97 6154 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6155 accurately, and prefer exact match for point under bidi.
6156 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6157
6158 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6159 into disp_prop; all users changed.
6160
6161 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6162 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6163 for the text covered by the display property.
6164
e4ed06f1
CY
61652011-08-25 Chong Yidong <cyd@stupidchicken.com>
6166
6167 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6168 Change return value to nil.
6169 (Frecord_buffer): Delete unused function.
6170
f67cdd7f
EZ
61712011-08-24 Eli Zaretskii <eliz@gnu.org>
6172
5980d4c6
EZ
6173 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6174 buffers, return left-to-right.
8610fe8b
EZ
6175 (set_cursor_from_row): Consider candidate row a win if its glyph
6176 represents a newline and point is on that newline. Fixes cursor
6177 positioning on the newline at EOL of R2L text within L2R
6178 paragraph, and vice versa.
6179 (try_cursor_movement): Check continued rows, in addition to
6180 continuation rows. Fixes unwarranted scroll when point enters a
6181 continued line of R2L text within an L2R paragraph, or vice versa.
6182 (cursor_row_p): Consider the case of point being equal to
6183 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6184 from the end of a short line to the beginning of a continued line
6185 of R2L text within L2R paragraph.
6186 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6187 composed characters.
5980d4c6 6188
f67cdd7f
EZ
6189 * bidi.c (bidi_check_type): Use xassert.
6190 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6191 members.
6192
bca633fb
EZ
61932011-08-23 Eli Zaretskii <eliz@gnu.org>
6194
6195 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6196 a character.
6197
4a5885a7
CY
61982011-08-23 Chong Yidong <cyd@stupidchicken.com>
6199
6200 * nsfont.m (ns_otf_to_script): Fix typo.
6201
0902a04e
KH
62022011-08-22 Kenichi Handa <handa@m17n.org>
6203
6204 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6205 extra slot even if the purpose is char-code-property-table.
6206
1a2e6670
EZ
62072011-08-23 Eli Zaretskii <eliz@gnu.org>
6208
8ddde651
EZ
6209 * xdisp.c (redisplay_window): When computing centering_position,
6210 account for the height of the header line. (Bug#8874)
6211
425cc014
EZ
6212 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6213 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6214 candidate is selected by the mouse, and that candidate has a
6215 composed character under the mouse.
6216
1a2e6670
EZ
6217 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6218 coordinates reported by pos-visible-in-window-p for a composed
6219 character in column zero.
6220
8b76d6f8
SM
62212011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6222
6223 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6224
dac347dd
EZ
62252011-08-22 Eli Zaretskii <eliz@gnu.org>
6226
6227 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6228 consider it a hit if to_charpos is anywhere in the range of the
6229 composed buffer positions.
6230
e013fb34
CY
62312011-08-22 Chong Yidong <cyd@stupidchicken.com>
6232
6233 * image.c (gif_load): Don't assume that each subimage has the same
6234 dimensions as the base image. Handle disposal method that is
6235 "undefined" by the gif spec (Bug#9335).
6236
bd1ba3e8
CY
62372011-08-20 Chong Yidong <cyd@stupidchicken.com>
6238
6239 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6240 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6241
54a1215b
EZ
62422011-08-19 Eli Zaretskii <eliz@gnu.org>
6243
823564e5
EZ
6244 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6245 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6246 from an Org mode buffer to a Speedbar frame.
6247
54a1215b
EZ
6248 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6249 a composition, take its buffer position from IT->cmp_it.charpos.
6250 Fixes cursor positioning at the beginning of a line that begins
6251 with a composed character.
6252
9778ebcc
EZ
62532011-08-18 Eli Zaretskii <eliz@gnu.org>
6254
0be6ee06
EZ
6255 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6256 character bidirectional type, use STRONG_L instead. Fixes crashes
6257 in a buffer produced by `describe-categories'.
6258
9778ebcc
EZ
6259 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6260 members before the level stack, so they would be saved and
6261 restored when copying iterator state. Fixes incorrect reordering
6262 around TABs covered by display properties.
6263
156bffbe
AS
62642011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6265
6b02f655 6266 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6267
72ad093b
CY
62682011-08-17 Chong Yidong <cyd@stupidchicken.com>
6269
6270 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6271 (internal_condition_case_2, internal_condition_case_n):
6272 Remove unnecessary aborts (Bug#9081).
72ad093b 6273
35774242
EZ
62742011-08-17 Eli Zaretskii <eliz@gnu.org>
6275
6276 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6277 has no `load' handler, try opening the file locally. (Bug#9311)
6278
db76dd85
KB
62792011-08-16 Ken Brown <kbrown@cornell.edu>
6280
6281 * gmalloc.c: Expand comment.
6282
b215eee5
EZ
62832011-08-16 Eli Zaretskii <eliz@gnu.org>
6284
6285 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6286 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6287
a4579d33
KB
62882011-08-16 Ken Brown <kbrown@cornell.edu>
6289
6290 Fix memory allocation problems in Cygwin build (Bug#9273).
6291
6292 * unexcw.c ( __malloc_initialized): Declare external variable.
6293 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6294
8b76d6f8
SM
6295 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6296 New variables.
a4579d33
KB
6297 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6298 dumped emacs.
6299 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6300 in the static heap.
6301 [CYGWIN] (special_realloc): New function.
6302 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6303 requests to realloc storage in the static heap.
6304
3ebec551
PE
63052011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6306
6307 * bidi.c (bidi_initialize): Remove unused local.
6308
9fd8be00
EZ
63092011-08-15 Eli Zaretskii <eliz@gnu.org>
6310
6b02f655
SM
6311 * bidimirror.h:
6312 * biditype.h: Remove file.
6313 * makefile.w32-in ($(BLD)/bidi.$(O)):
6314 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6315
6316 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6317
6318 * chartab.c: Improve commentary for the uniprop_table API.
6319
32413314
EZ
6320 * bidi.c (bidi_paragraph_init): Support zero value of
6321 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6322 (bidi_initialize): Use uniprop_table instead of including
6323 biditype.h and bidimirror.h.
32413314 6324
9fd8be00
EZ
6325 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6326 coordinates of the iterator when restoring from ppos_it.
6327 (Bug#9296)
6328
5cf2b69b
KH
63292011-08-14 Kenichi Handa <handa@m17n.org>
6330
6331 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6332 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6333
daf17d00
EZ
63342011-08-14 Eli Zaretskii <eliz@gnu.org>
6335
6336 * xdisp.c (move_it_in_display_line_to): Don't invoke
6337 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6338 ppos_it. Fixes vertical cursor motion when line beginning is
6339 covered by an image. (Bug#9296)
6340
08e3161a
JD
63412011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6342
6343 * nsterm.h (ns_run_ascript): Declare.
6344 (NSAPP_DATA2_RUNASSCRIPT): Define.
6345
6346 * nsfns.m (as_script, as_result, as_status): New static variables.
6347 (ns_run_ascript): New function.
5e617bc2 6348 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6349 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6350 the event loop. Get status from as_status (Bug#7276).
6351
6352 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6353 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6354 the event loop (Bug#7276).
6355
a3720aa2
AS
63562011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6357
6358 * gnutls.c (QCgnutls_bootprop_priority)
6359 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6360 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6361 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6362 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6363 (QCgnutls_bootprop_verify_hostname_error)
6364 (QCgnutls_bootprop_callbacks_verify): Rename from
6365 Qgnutls_bootprop_..., all uses changed.
6366
6367 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6368 uses changed.
6369
0a0d27fb
PE
63702011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6371
19d5c50c
PE
6372 * xfaces.c (Qframe_set_background_mode): Now static.
6373 * dispextern.h (Qframe_set_background_mode): Remove decl.
6374
0a0d27fb
PE
6375 * process.c (Fnetwork_interface_info): Declare local only if needed.
6376
377538cb
JD
63772011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6378
6379 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6380 (Fnetwork_interface_list): Allocate in increments of bytes instead
6381 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6382 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6383 sockaddr.
6384 (struct ifflag_def): notrailers is smart on OSX.
6385 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6386 Get hardware address with getifaddrs if available.
6387
08fff70c
EZ
63882011-08-12 Eli Zaretskii <eliz@gnu.org>
6389
6390 * xdisp.c (iterate_out_of_display_property): xassert that
6391 IT->position is set to within IT->object's boundaries. Break from
6392 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6393 when IT->position is set up wrongly due to some bug.
6394 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6395 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6396 entry. Force push_it to save on the stack the current
6397 buffer/string position, to be restored by pop_it. Fix flags in
6398 the iterator structure wrt the object coming from a display
6399 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6400 properties. (Bug#9284)
6401
7be1c708 64022011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6403
7be1c708
CY
6404 * fontset.c (fontset_get_font_group): Add proper type checks.
6405 (Bug#9172)
aac0c6e3 6406
7be1c708 64072011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6408
7be1c708
CY
6409 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6410 and LC_VERSION_MIN_MACOSX.
6411 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6412 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6413
97bb72a6
EZ
64142011-08-08 Eli Zaretskii <eliz@gnu.org>
6415
6416 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6417 no-display-properties-and-no-overlays under bidi display.
6418 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6419 properties and overlays.
97bb72a6 6420
d5617611
CY
64212011-08-08 Chong Yidong <cyd@stupidchicken.com>
6422
37e11a63
CY
6423 * editfns.c (Fset_time_zone_rule): Document relationship with the
6424 setenv function.
6425
d5617611
CY
6426 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6427 the font entity extracted from the cache (Bug#8109).
6428
58872834
CY
64292011-08-07 Chong Yidong <cyd@stupidchicken.com>
6430
6431 * composite.c (autocmp_chars): Don't reset point. That is done by
6432 restore_point_unwind (Bug#5984).
6433
75bfc667
JL
64342011-08-07 Juri Linkov <juri@jurta.org>
6435
6436 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6437 to show the arg `TIME' instead of `TIMEVAL'.
6438
d1410150
EZ
64392011-08-06 Eli Zaretskii <eliz@gnu.org>
6440
6441 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6442 display property strides EOL and includes a newline, as in
6443 longlines-mode. (Bug#9254)
75b771e4
EZ
6444 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6445 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6446
6447 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6448 is non-zero, even if the data buffer is NULL. Fixes a crash in
6449 vertical-motion with longlines-mode. (Bug#9254)
6450
35928349
EZ
64512011-08-05 Eli Zaretskii <eliz@gnu.org>
6452
ec7cc85b
EZ
6453 * bidi.c <bidi_cache_total_alloc>: Now static.
6454 (bidi_initialize): Initialize bidi_cache_total_alloc.
6455
8b76d6f8 6456 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6457 cache. (Bug#9221)
6458
6459 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6460 amount allocated this far in `bidi_cache_total_alloc'.
6461 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6462 non-zero, only free the data buffer without restoring the cache
6463 contents. All callers changed.
6464
6465 * dispextern.h (bidi_unshelve_cache): Update prototype.
6466
6467 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6468 (move_it_in_display_line, move_it_to)
6469 (move_it_vertically_backward, move_it_by_lines): Replace the call
6470 to xfree to an equivalent call to bidi_unshelve_cache.
6471 (move_it_in_display_line_to): Fix logic of returning
412b6358 6472 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6473
e2e2423b
EZ
64742011-08-05 Eli Zaretskii <eliz@gnu.org>
6475
6476 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6477 came from a string character with a `cursor' property. (Bug#9229)
6478
ae9e757a
JD
64792011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6480
6481 * Makefile.in (LIB_PTHREAD): New variable.
6482 (LIBES): Add LIB_PTHREAD (Bug#9216).
6483
6484 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6485 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6486
213bd7f2
AS
64872011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6488
6b02f655 6489 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6490
99aaf75f
JD
64912011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6492
6493 * xterm.c (x_find_topmost_parent): New function.
6494 (x_set_frame_alpha): Find topmost parent window with
6495 x_find_topmost_parent and set the property there also (bug#9181).
6496 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6497
c74e9d86
PE
64982011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6499
6500 * callproc.c (Fcall_process): Avoid vfork clobbering
6501 the local vars buffer, coding_systems, current_dir.
6502
640c8776
SM
65032011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6504
6505 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6506
f26d0e4c
PE
65072011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6508
8a10d76c
PE
6509 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6510 so that it is not optimized away.
6511
f26d0e4c
PE
6512 * xdisp.c (compute_display_string_pos): Remove unused local.
6513
55439c61
EZ
65142011-08-02 Eli Zaretskii <eliz@gnu.org>
6515
6516 Fix slow cursor motion and scrolling in large buffers with
6517 selective display, like Org Mode buffers. (Bug#9218)
6518
6519 * dispextern.h (struct bidi_it): New member disp_prop_p.
6520
6521 * xdisp.c: Remove one-slot cache of display string positions.
6522 (compute_display_string_pos): Accept an additional argument
5e617bc2 6523 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6524 for a display string or property. If found, set DISP_PROP_P
6525 non-zero.
6526
6527 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6528 DISP_PROP_P, and pass it to compute_display_string_pos.
6529 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6530 non-zero. All callers of bidi_fetch_char changed.
6531
fb33fa43
SM
65322011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6533
6534 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6535
b099e063
DM
65362010-12-03 Don March <don@ohspite.net>
6537
6538 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6539 last character M-[char] is translated to ESC [char] (bug#7541).
6540
5cc7f7af
KH
65412011-08-02 Kenichi Handa <handa@m17n.org>
6542
d0fffa3f 6543 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6544
6545 * chartab.c (uniprop_table): Make it non-static.
6546
525d5e6e
EZ
65472011-08-01 Eli Zaretskii <eliz@gnu.org>
6548
6549 * xdisp.c (forward_to_next_line_start): Accept additional argument
6550 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6551 on the newline.
6552 (reseat_at_next_visible_line_start): Use the bidi iterator state
6553 returned by forward_to_next_line_start to restore the state of
6554 it->bidi_it after backing up to previous newline. (Bug#9212)
6555
31011111
AS
65562011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6557
6558 * regex.c (re_comp): Protoize.
6559 (re_exec): Fix return type.
6560 (regexec): Fix type of `ret'. (Bug#9203)
6561
476371c4
PE
65622011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6563
e5d76069
PE
6564 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6565 This is needed if max-image-size is a floating-point number.
6566
9a79b20c
AS
65672011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6568
6569 * print.c (print_object): Print empty symbol as ##.
6570
6571 * lread.c (read1): Read ## as empty symbol.
6572
d8c2fa78
AA
65732011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6574
6575 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6576 setting frame foreground color (Bug#9175).
6577 (x_set_background_color): Likewise.
6578
ffe57a7a
AA
6579 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6580 contents (Bug#9176).
6581 (EmacsTooltip -init): Remove bezels and add shadows to
6582 tooltip windows.
6583
bf3492a5
AA
6584 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6585 or scroll bar (Bug#8470).
6586
d55e9c53
AA
6587 * nsfont.m (nsfont_open): Remove assignment to voffset and
6588 unnecessary vars hshink, expand, hd, full_height, min_height.
6589 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6590
6591 * nsterm.h (nsfont_info): Remove voffset field.
6592
d8c2fa78 65932011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6594
6595 Implement strike-through and overline on NextStep (Bug#8863).
6596
6597 * nsfont.m (nsfont_open): Use underline position provided by font,
6598 instead of hard-coded value of 2.
6599 (nsfont_draw): Call ns_draw_text_decoration instead.
6600
6601 * nsterm.h: Add declaration for ns_draw_text_decoration.
6602
6603 * nsterm.m (ns_draw_text_decoration): New function for drawing
6604 underline, overline, and strike-through.
6605 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6606 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6607 accommodate underlining, etc.
4843aac3 6608
4cc60b9b
EZ
66092011-07-28 Eli Zaretskii <eliz@gnu.org>
6610
bc7ece87
EZ
6611 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6612 default.
4cc60b9b 6613
476371c4
PE
66142011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6615
66606eea
PE
6616 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6617 Without this fix, if a signal arrives just after memory fills up,
6618 'malloc' might be invoked reentrantly.
6619
476371c4
PE
6620 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6621 In other words, assume that every image size is allowed, on non-X
6622 hosts. This assumption is probably wrong, but it lets Emacs compile.
6623
f3fcc40d
AS
66242011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6625
6626 * regex.c (re_iswctype): Convert return values to boolean.
6627
350c992f
EZ
66282011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6629
6630 * xdisp.c (compute_display_string_pos): Don't use cached display
6631 string position if the buffer had its restriction changed.
6632 (Bug#9184)
6633
5266b4bb
PE
66342011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6635
6636 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6637
2573a837 66382011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6639
41f55ccd 6640 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6641
39e378da
PE
6642 * bidi.c: Integer size and overflow fixes.
6643 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6644 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6645 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6646 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6647 (bidi_find_other_level_edge):
6648 Use ptrdiff_t instead of EMACS_INT where either will do.
6649 This works better on 32-bit hosts configured --with-wide-int.
6650 (bidi_cache_ensure_space): Check for size-calculation overflow.
6651 Use % rather than repeated addition, for better worst-case speed.
6652 Don't set bidi_cache_size until after xrealloc returns, because it
6653 might not return.
6654 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6655 (bidi_cache_ensure_space): Also check that the bidi cache size
6656 does not exceed that of the largest Lisp string or buffer. See Eli
6657 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6658
5e927815
PE
6659 * alloc.c (__malloc_size_t): Remove.
6660 All uses replaced by size_t. See Andreas Schwab's note
6661 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6662
ca4aa935
PE
6663 * image.c: Improve checking for integer overflow.
6664 (check_image_size): Assume that f is nonnull, since
6665 it is always nonnull in practice. This is one less thing to
6666 worry about when checking for integer overflow later.
6667 (x_check_image_size): New function, which checks for integer
6668 overflow issues inside X.
6669 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6670 This removes the need for a memory_full check.
6671 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6672 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6673 (xbm_read_bitmap_data): Change locals back to 'int', since
6674 their values must fit in 'int'.
6675 (xpm_load_image, png_load, tiff_load):
6676 Invoke x_create_x_image_and_pixmap earlier,
6677 to avoid much needless work if the image is too large.
6678 (tiff_load): Treat overly large images as if
6679 x_create_x_image_and_pixmap failed, not as malloc failures.
6680 (gs_load): Use x_check_image_size.
6681
5f8f9cc2
PE
6682 * gtkutil.c: Omit integer casts.
6683 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6684 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6685
5adf60bc
PE
6686 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6687
c8907a93
PE
6688 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6689 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6690 would wrongly return t on a 64-bit host.
6691
e3c25c68
PE
6692 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6693 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6694 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6695 and therefore cause GCC to emit a bogus diagnostic in some cases.
6696
3f791afe
PE
6697 * image.c: Integer signedness and overflow and related fixes.
6698 This is not an exhaustive set of fixes, but it's time to
6699 record what I've got.
6700 (lookup_pixel_color, check_image_size): Remove redundant decls.
6701 (check_image_size): Don't assume that arbitrary EMACS_INT values
6702 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6703 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6704 (tiff_load, imagemagick_load_image):
6705 Check for overflow in size calculations.
6706 (x_create_x_image_and_pixmap): Remove unnecessary test for
6707 xmalloc returning NULL; that can't happen.
6708 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6709 (xpm_color_bucket): Use better integer hashing function.
6710 (xpm_cache_color): Don't possibly over-allocate memory.
6711 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6712 (gif_memory_source):
6713 Use ptrdiff_t, not int or size_t, to record sizes.
6714 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6715 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6716 either works, as we prefer signed integers.
6717 (tiff_read_from_memory, tiff_write_from_memory):
6718 Return tsize_t, not size_t, since that's what the TIFF API wants.
6719 (tiff_read_from_memory): Don't fail simply because the read would
6720 go past EOF; instead, return a short read.
6721 (tiff_load): Omit no-longer-needed casts.
6722 (Fimagemagick_types): Don't assume size fits into 'int'.
6723
3cc5a532
PE
6724 Improve hashing quality when configured --with-wide-int.
6725 * fns.c (hash_string): New function, taken from sxhash_string.
6726 Do not discard information about ASCII character case; this
6727 discarding is no longer needed.
6728 (sxhash-string): Use it. Change sig to match it. Caller changed.
6729 * lisp.h: Declare it.
6730 * lread.c (hash_string): Remove, since we now use fns.c's version.
6731 The fns.c version returns a wider integer if --with-wide-int is
6732 specified, so this should help the quality of the hashing a bit.
6733
b312a492
PE
6734 * emacs.c: Integer overflow minor fix.
6735 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6736 Define only if GNU_LINUX.
6737 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6738
dfd153ae
PE
6739 * dispnew.c: Integer signedness and overflow fixes.
6740 Remove unnecessary forward decls, that were a maintenance hassle.
6741 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6742 All uses changed.
6743 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6744 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6745 (prepare_desired_row, line_draw_cost):
6746 Use int, not unsigned, where either works.
6747 (save_current_matrix, restore_current_matrix):
6748 Use ptrdiff_t, not size_t, where either works.
6749 (init_display): Check for overflow more accurately, and without
6750 relying on undefined behavior.
6751
a81d11a3
PE
6752 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6753 Remove, replacing with the new symbols in lisp.h. All uses changed.
6754 * fileio.c (make_temp_name):
6755 * filelock.c (lock_file_1, lock_file):
6756 * xdisp.c (message_dolog):
6757 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6758 Use pMd etc. instead.
6759 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6760 replacing the pWIDE etc. symbols removed from editfns.c.
6761
3300e6fd
PE
6762 * keyboard.h (num_input_events): Now uintmax_t.
6763 This is (very slightly) less likely to mess up due to wraparound.
6764 All uses changed.
6765
fd05c7e9
PE
6766 * buffer.c: Integer signedness fixes.
6767 (alloc_buffer_text, enlarge_buffer_text):
6768 Use ptrdiff_t rather than size_t when either will do, as we prefer
6769 signed integers.
6770
903fe15d
PE
6771 * alloc.c: Integer signedness and overflow fixes.
6772 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6773 (__malloc_size_t): Default to size_t, not to int.
6774 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6775 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6776 Prefer ptrdiff_t to size_t when either would do, as we prefer
6777 signed integers.
6778 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6779 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6780 Now const. Initialize with values that are in range even if char
6781 is signed.
6782 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6783 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6784 These functions do the right thing with sizes > 2**32.
6785 (check_depth): Now ptrdiff_t, not int.
6786 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6787 Adjust to new way of storing sizes. Check for size overflow bugs
6788 in rest of code.
6789 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6790 slightly wrong anyway, as it missed one instance of
6791 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6792 (refill_memory_reserve): Omit needless cast to size_t.
6793 (mark_object_loop_halt): Mark as externally visible.
6794
ac82cc6a
PE
6795 * xselect.c: Integer signedness and overflow fixes.
6796 (Fx_register_dnd_atom, x_handle_dnd_message):
6797 Use ptrdiff_t, not size_t, since we prefer signed.
6798 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6799 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6800 x_dnd_atoms_size and x_dnd_atoms_length.
6801
c2d1e36d
PE
6802 * doprnt.c: Prefer signed to unsigned when either works.
6803 * eval.c (verror):
6804 * doprnt.c (doprnt):
6805 * lisp.h (doprnt):
6806 * xdisp.c (vmessage):
6807 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6808 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6809 prefer signed arithmetic to avoid comparison confusion.
6810 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6811 but is a bit tricky.
6812
0e926e56
PE
6813 Assume freestanding C89 headers, string.h, stdlib.h.
6814 * data.c, doprnt.c, floatfns.c, print.c:
6815 Include float.h unconditionally.
6816 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6817 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6818 * regex.c: Likewise for stddef.h, string.h.
6819 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6820 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6821 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6822 (STDC_HEADERS): Remove obsolete defines.
6823 * sysdep.c: Include limits.h unconditionally.
6824
9cfdb3ec
PE
6825 Assume support for memcmp, memcpy, memmove, memset.
6826 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6827 * regex.c (memcmp, memcpy):
6828 Remove; we assume C89 now.
6829
6830 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6831 (__malloc_safe_bcopy): Remove; no longer needed.
6832
cf950e6b 6833 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6834 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6835 well either way, and we prefer signed to unsigned.
6836
dbf38e02
LMI
68372011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6838
6839 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6840 closes the connection while we're reading (bug#9182).
6841
d6f0886c 68422011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6843
d6f0886c
JD
6844 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6845 are specified (Bug#9168).
24e0f6b1 6846
2eb1f9e6
PE
68472011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6848
6849 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6850 Found by GCC static checking and --with-wide-int on a 32-bit host.
6851
22381272 68522011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6853
6854 * xdisp.c (compute_display_string_pos): Fix logic of caching
6855 previous display string position. Initialize cached_prev_pos to
6856 -1. Fixes slow-down at the beginning of a buffer.
6857
f25e39b4
EZ
68582011-07-24 Eli Zaretskii <eliz@gnu.org>
6859
6860 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6861 for attrs[LFACE_FONTSET_INDEX].
6862
04c4b52e
PE
68632011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6864
6865 * xml.c (parse_region): Remove unused local
6866 that was recently introduced.
6867
c1734fbd
EZ
68682011-07-23 Eli Zaretskii <eliz@gnu.org>
6869
be18c5a5
EZ
6870 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6871 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6872
c1734fbd
EZ
6873 * xdisp.c (move_it_in_display_line_to): Record the best matching
6874 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6875 exit if none of the characters scanned was an exact match.
6876 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6877 when exact match is impossible due to invisible text, and the
6878 lines are truncated.
6879
a258d627
JD
68802011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6881
6882 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6883 for OSX >= 10.7.
6884
b6d5a689
EZ
68852011-07-22 Eli Zaretskii <eliz@gnu.org>
6886
0f74f785
EZ
6887 Fix a significant slow-down of cursor motion with C-n, C-p,
6888 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6889 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6890 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6891 (next_element_from_buffer): Call compute_stop_pos_backwards to
6892 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6893 base_level_stop.
6894 (reseat): Don't look for prev_stop, as that could mean a very long
6895 run.
6896 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6897 <cached_disp_overlay_modiff>: Cache for last found display string
6898 position.
551918c1 6899 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6900 about the same buffer in the same area of character positions, and
6901 the buffer wasn't changed since the time the display string
6902 position was cached.
551918c1 6903
b2d0c91a
EZ
69042011-07-22 Eli Zaretskii <eliz@gnu.org>
6905
6906 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6907 is an integer, which is important for empty lines. (Bug#9149)
6908
043604ee
CY
69092011-07-22 Chong Yidong <cyd@stupidchicken.com>
6910
6911 * frame.c (Fmodify_frame_parameters): In tty case, update the
6912 default face if necessary (Bug#4238).
6913
da4adb04
CY
69142011-07-21 Chong Yidong <cyd@stupidchicken.com>
6915
6916 * editfns.c (Fstring_to_char): No need to explain what a character
6917 is in the docstring (Bug#6576).
6918
9abd0532
LMI
69192011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6920
6921 * xml.c (parse_region): Make sure we always return a tree.
6922
36881d16
HK
69232011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6924
6925 * xml.c (parse_region): If a document contains only comments,
6926 return that, too.
6927
1e98674d
LMI
69282011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6929
6930 * xml.c (make_dom): Return comments, too.
6931
590bd467
PE
69322011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6933
6934 Port to OpenBSD.
6935 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6936 and the surrounding thread.
6937 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6938 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6939 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6940 timer goes off.
6941 * s/openbsd.h (BROKEN_SIGIO): Define.
6942 * unexelf.c (unexec) [__OpenBSD__]:
6943 Don't update the .mdebug section of the Alpha COFF symbol table.
6944
f41628b2
LMI
69452011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6946
6947 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6948 (bug#8460).
6949
b59b67c5
PE
69502011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6951
15e3a074
PE
6952 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6953 This fixes some race conditions on the permissions of any newly
6954 created file.
6955
41bed37d
PE
6956 * alloc.c (valid_pointer_p): Use pipe, not open.
6957 This fixes some permissions issues when debugging.
6958
b59b67c5
PE
6959 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6960 If fchown fails to set both uid and gid, try to set just gid,
6961 as that is sometimes allowed. Adjust the file's mode to eliminate
6962 setuid or setgid bits that are inappropriate if fchown fails.
6963
925a6be7
SM
69642011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6965
6966 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6967 to compare Lisp_Objects.
6968 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6969 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6970 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6971
52968808
AS
69722011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6973
0a6a104b
AS
6974 * lread.c (read_integer): Unread even EOF character.
6975 (read1): Likewise. Properly record start position of symbol.
6976
52968808
AS
6977 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6978 symbol character follows.
6979
9e381cdd
PE
69802011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6981
6982 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6983 This works around a problem with the previous change to Fcopy_file.
6984 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6985 and without this change, GCC might complain about discarding
6986 fchown's return value.
6987
b5641435
JB
69882011-07-16 Juanma Barranquero <lekktu@gmail.com>
6989
6990 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6991
a8031457
PE
69922011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6993
6994 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6995
dd889327
LMI
69962011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6997
750c33f7
LMI
6998 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6999 it's used from the C level.
7000
dd889327
LMI
7001 * process.c: Use the same condition for POLL_FOR_INPUT in both
7002 keyboard.c and process.c (bug#1858).
7003
87e86684
LM
70042011-07-09 Lawrence Mitchell <wence@gmx.li>
7005
7006 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7007 (Fgnutls_boot): Use it.
7008
64348f40
AS
70092011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7010
7011 * doc.c (Fsubstitute_command_keys): Revert last change.
7012
1d698799
LMI
70132011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7014
f863868c
LMI
7015 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7016 quotes the next character, and doesn't affect other longer
7017 sequences (bug#8935).
7018
1d698799
LMI
7019 * lread.c (syms_of_lread): Clarify that is isn't only
7020 `eval-buffer' and `eval-defun' that's affected by
7021 `lexical-binding' (bug#8460).
7022
aa4b6df6
EZ
70232011-07-15 Eli Zaretskii <eliz@gnu.org>
7024
7025 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7026 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7027
5d856da6
PE
70282011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7029
ad6042bb
PE
7030 Fix minor problems found by static checking.
7031 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7032 (elsz): Now a signed constant, not a size_t var. We prefer signed
7033 types to unsigned, to avoid integer comparison confusion. Without
7034 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7035 "cannot optimize loop, the loop counter may overflow", a symptom
7036 of the confusion.
f00bbb22 7037 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7038 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7039
6468f31c
LMI
70402011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7041
49080b10
LMI
7042 * search.c (Fre_search_backward): Mention `case-fold-search' in
7043 all the re_search_* functions (bug#8138).
7044
6468f31c
LMI
7045 * keyboard.c (Fopen_dribble_file): Document when the file is
7046 closed (bug#8056).
7047
c965adc5
EZ
70482011-07-14 Eli Zaretskii <eliz@gnu.org>
7049
df9733bf
EZ
7050 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7051 bidi_cache_idx.
7052
0bb23927
EZ
7053 Support bidi reordering of display and overlay strings.
7054 * xdisp.c (compute_display_string_pos)
7055 (compute_display_string_end): Accept additional argument STRING.
7056 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7057 (reseat_to_string): Initialize bidi_it->string.s and
7058 bidi_it->string.schars.
7059 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7060 NULL (avoids a crash in bidi_paragraph_init).
7061 Initialize itb.string.lstring.
0bb23927
EZ
7062 (init_iterator): Call bidi_init_it only of a valid
7063 buffer position was specified. Initialize paragraph_embedding to
7064 L2R.
7065 (reseat_to_string): Initialize the bidi iterator.
7066 (display_string): If we need to ignore text properties of
7067 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7068 original value of -1 will not work with bidi.)
7069 (compute_display_string_pos): First arg is now struct
7070 `text_pos *'; all callers changed. Support display properties on
7071 Lisp strings.
7072 (compute_display_string_end): Support display properties on Lisp
7073 strings.
7074 (init_iterator, reseat_1, reseat_to_string): Initialize the
7075 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7076 when iterating on a string not from display properties).
640c8776
SM
7077 (compute_display_string_pos, compute_display_string_end):
7078 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7079 arrow keys.
7080 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7081 base_level_stop; instead, set base_level_stop to BEGV.
7082 Fixes crashes in vertical-motion.
0bb23927
EZ
7083 (next_element_from_buffer): Improve commentary for when
7084 the iterator is before prev_stop.
7085 (init_iterator): Initialize bidi_p from the default value of
7086 bidi-display-reordering, not from buffer-local value. Use the
7087 buffer-local value only if initializing for buffer iteration.
7088 (handle_invisible_prop): Support invisible properties on strings
7089 that are being bidi-reordered.
7090 (set_iterator_to_next): Support bidi reordering of C strings and
7091 Lisp strings.
7092 (next_element_from_string): Support bidi reordering of Lisp
7093 strings.
7094 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7095 (display_string): Support display of R2L glyph rows.
7096 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7097 (init_iterator): Don't initialize it->bidi_p for strings
7098 here.
7099 (reseat_to_string): Initialize it->bidi_p for strings here.
7100 (next_element_from_string, next_element_from_c_string)
7101 (next_element_from_buffer): Add xassert's for correspondence
7102 between IT's object being iterated and it->bidi_it.string
7103 structure.
7104 (face_before_or_after_it_pos): Support bidi iteration.
7105 (next_element_from_c_string): Handle the case of the first string
7106 character that is not the first one in the visual order.
7107 (get_visually_first_element): New function, refactored from common
7108 parts of next_element_from_buffer, next_element_from_string, and
7109 next_element_from_c_string.
7110 (tool_bar_lines_needed, redisplay_tool_bar)
7111 (display_menu_bar): Force left-to-right direction. Add a FIXME
7112 comment for making that be controlled by a user option.
7113 (push_it, pop_it): Save and restore the state of the
7114 bidi iterator. Save and restore the bidi_p flag.
7115 (pop_it): Iterate out of display property for string iteration as
7116 well.
7117 (iterate_out_of_display_property): Support iteration over strings.
7118 (handle_single_display_spec): Set up it->bidi_it for iteration
7119 over a display string, and call bidi_init_it.
7120 (handle_single_display_spec, next_overlay_string)
7121 (get_overlay_strings_1, push_display_prop): Set up the bidi
7122 iterator for displaying display or overlay strings.
7123 (forward_to_next_line_start): Don't use the shortcut if
7124 bidi-iterating.
7125 (back_to_previous_visible_line_start): If handle_display_prop
7126 pushed the iterator stack, restore the internal state of the bidi
7127 iterator by calling bidi_pop_it same number of times.
7128 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7129 and we are bidi-iterating, don't decrement the iterator position;
7130 instead, set the first_elt flag in the bidi iterator, to produce
7131 the same effect.
7132 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7133 (push_display_prop): xassert that we are iterating a buffer.
7134 (push_it, pop_it): Save and restore paragraph_embedding member.
7135 (handle_single_display_spec, next_overlay_string)
7136 (get_overlay_strings_1, reseat_1, reseat_to_string)
7137 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7138 correctly. Don't assume unibyte strings are not bidi-reordered.
7139 (compute_display_string_pos)
7140 (compute_display_string_end): Fix handling the case of C string.
7141 (push_it, pop_it): Save and restore from_disp_prop_p.
7142 (handle_single_display_spec, push_display_prop): Set the
7143 from_disp_prop_p flag.
7144 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7145 (pop_it): Call iterate_out_of_display_property only if we are
7146 popping after iteration over a string that came from a display
7147 property. Fix a typo in popping stretch info. Add an assertion
7148 for verifying that the iterator position is in sync with the bidi
7149 iterator.
7150 (handle_single_display_spec, get_overlay_strings_1)
7151 (push_display_prop): Fix initialization of paragraph direction for
7152 string when that of the parent object is not yet determined.
7153 (reseat_1): Call bidi_init_it to resync the bidi
7154 iterator with IT's position. (Bug#7616)
7155 (find_row_edges): If ROW->start.pos gives position
7156 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7157 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7158 Reset the from_disp_prop_p flag.
7159 (SAVE_IT, RESTORE_IT): New macros.
7160 (pos_visible_p, face_before_or_after_it_pos)
7161 (back_to_previous_visible_line_start)
7162 (move_it_in_display_line_to, move_it_in_display_line)
7163 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7164 (try_scrolling, redisplay_window, display_line): Use them when
7165 saving a temporary copy of the iterator and restoring it back.
7166 (back_to_previous_visible_line_start, reseat_1)
7167 (init_iterator): Empty the bidi cache "stack".
7168 (move_it_in_display_line_to): If iterator ended up at
7169 EOL, but we never saw any buffer positions smaller than
7170 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7171 motion in bidi-reordered lines.
7172 (move_it_in_display_line_to): Record prev_method and prev_pos
7173 immediately before the call to set_iterator_to_next. Fixes cursor
7174 motion in bidi-reordered lines with stretch glyphs and strings
7175 displayed in margins. (Bug#8133) (Bug#8867)
7176 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7177 TO_CHARPOS.
640c8776
SM
7178 (pos_visible_p): Support positions in bidi-reordered lines.
7179 Save and restore bidi cache.
0bb23927
EZ
7180
7181 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7182 (bidi_paragraph_info): Delete unused struct.
7183 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7184 (bidi_cache_start): New variable.
7185 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7186 to zero.
7187 (bidi_cache_fetch_state, bidi_cache_search)
7188 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7189 (bidi_cache_find, bidi_peek_at_next_level)
7190 (bidi_level_of_next_char, bidi_find_other_level_edge)
7191 (bidi_move_to_visually_next): Compare cache index with
7192 bidi_cache_start rather than with zero.
7193 (bidi_fetch_char): Accept new argument STRING; all callers
7194 changed. Support iteration over a string. Support strings with
7195 display properties. Support unibyte strings. Fix the type of
7196 `len' according to what STRING_CHAR_AND_LENGTH expects.
7197 (bidi_paragraph_init, bidi_resolve_explicit_1)
7198 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7199 (bidi_level_of_next_char, bidi_move_to_visually_next):
7200 Support iteration over a string.
0bb23927
EZ
7201 (bidi_set_sor_type, bidi_resolve_explicit_1)
7202 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7203 can now be zero (for strings); special values 0 and -1 were
7204 changed to -1 and -2, respectively.
7205 (bidi_char_at_pos): New function.
7206 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7207 Call it instead of FETCH_MULTIBYTE_CHAR.
7208 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7209 initialized to valid values.
7210 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7211 values.
7212 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7213 the test for valid cached positions. Fix the logic for looking up
7214 the sentinel state in the cache. GCPRO the Lisp string we are
7215 iterating.
7216 (bidi_push_it, bidi_pop_it): New functions.
7217 (bidi_initialize): Initialize the bidi cache start stack pointer.
7218 (bidi_cache_ensure_space): New function, refactored from part of
7219 bidi_cache_iterator_state. Don't assume the required size is just
7220 one BIDI_CACHE_CHUNK away.
7221 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7222 (bidi_count_bytes, bidi_char_at_pos): New functions.
7223 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7224 always valid if bidi_cache_idx is valid.
7225 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7226 is valid if it's going to be used.
7227 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7228 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7229 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7230 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7231 (bidi_find_other_level_edge, bidi_cache_start_stack):
7232 All variables related to cache indices are now EMACS_INT.
c965adc5 7233
0bb23927
EZ
7234 * dispextern.h (struct bidi_string_data): New structure.
7235 (struct bidi_it): New member `string'. Make flag members be 1-bit
7236 fields, and put them last in the struct.
640c8776
SM
7237 (compute_display_string_pos, compute_display_string_end):
7238 Update prototypes.
0bb23927
EZ
7239 (bidi_push_it, bidi_pop_it): Add prototypes.
7240 (struct iterator_stack_entry): New members bidi_p,
7241 paragraph_embedding, and from_disp_prop_p.
7242 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7243 (bidi_shelve_cache, bidi_unshelve_cache):
7244 Declare prototypes.
0bb23927
EZ
7245
7246 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7247 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7248 and vector-like objects.
7249
7250 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7251 cache around display iteration.
7252
7253 * window.c (Fwindow_end, window_scroll_pixel_based)
7254 (displayed_window_lines, Frecenter): Save and restore the bidi
7255 cache around display iteration.
7256
3bbd2265
LMI
72572011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7258
7259 * editfns.c (Fdelete_region): Clarify the use of the named
7260 parameters (bug#6788).
7261
adc47434
MR
72622011-07-14 Martin Rudalics <rudalics@gmx.at>
7263
7264 * indent.c (Fvertical_motion): Set and restore w->pointm when
7265 saving and restoring the window's buffer (Bug#9006).
7266
837c31f8
LMI
72672011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7268
7269 * editfns.c (Fstring_to_char): Clarify just what is returned
7270 (bug#6576). Text by Eli Zaretskii.
7271
ac389d0c
JB
72722011-07-13 Juanma Barranquero <lekktu@gmail.com>
7273
7274 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7275
0be0ce47
EZ
72762011-07-13 Eli Zaretskii <eliz@gnu.org>
7277
7278 * buffer.c (mmap_find): Fix a typo.
7279
cd18e7e3
JB
72802011-07-13 Johan Bockgård <bojohan@gnu.org>
7281
7282 Fix execution of x selection hooks.
7283 * xselect.c (Qx_lost_selection_functions)
7284 (Qx_sent_selection_functions): New vars.
7285 (syms_of_xselect): DEFSYM them.
7286 (x_handle_selection_request): Pass Qx_sent_selection_functions
7287 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7288 (x_handle_selection_clear,x_clear_frame_selections):
7289 Pass Qx_lost_selection_functions rather than
7290 Vx_lost_selection_functions to Frun_hook_with_args.
7291
47ea7f44
PE
72922011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7293
ac389d0c 7294 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7295 The old code sometimes used this field without initializing it.
7296
47ea7f44
PE
7297 * alloc.c (gc_sweep): Don't read past end of array.
7298 In theory, the old code could also have corrupted Emacs internals,
7299 though it'd be very unlikely.
7300
bc985c87
AS
73012011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7302
7303 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7304 argument. (Bug#4026)
bc985c87 7305
0cf34688
LMI
73062011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7307
b3dadd76
LMI
7308 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7309 key" (bug#4257).
7310
0cf34688
LMI
7311 * window.c (Fset_window_start): Doc fix (bug#4199).
7312 (Fset_window_hscroll): Ditto.
7313
270768cd
PE
73142011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7315
077e3dda 7316 Fix minor new problems caught by GCC 4.6.1.
270768cd 7317 * term.c (init_tty): Remove unused local.
490011a6 7318 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7319 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7320 not used otherwise.
270768cd 7321
b1f58454
CY
73222011-07-12 Chong Yidong <cyd@stupidchicken.com>
7323
7324 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7325
22b9578d
LMI
73262011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7327
6e70ab07
LMI
7328 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7329 are the mini-buffer and the echo area (bug#3320).
7330
22b9578d
LMI
7331 * term.c (init_tty): Remove support for supdup, c10 and perq
7332 terminals, which are no longer supported (bug#1482).
7333
8974cc9f
JB
73342011-07-10 Johan Bockgård <bojohan@gnu.org>
7335
7336 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7337
a560d974
JD
73382011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7339
7340 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7341 for non-popups (Bug#3642).
7342
1dae0f0a
AS
73432011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7344
268c2c36 7345 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7346 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7347 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7348 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7349 * data.c (fmod): Likewise.
7350 * dispnew.c (swap_glyphs_in_rows): Likewise.
7351 * emacs.c (memory_warning_signal): Likewise.
7352 * floatfns.c (float_error): Likewise.
7353 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7354 (otf_open, font_otf_capability, generate_otf_features)
7355 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7356 Likewise.
7357 * image.c (pbm_read_file): Likewise.
7358 * indent.c (string_display_width): Likewise.
7359 * intervals.c (check_for_interval, search_for_interval)
7360 (inc_interval_count, count_intervals, root_interval)
7361 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7362 * lread.c (defalias): Likewise.
268c2c36 7363 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7364 * regex.c (set_image_of_range_1, set_image_of_range)
7365 (regex_grow_registers): Likewise.
7366 * sysdep.c (strerror): Likewise.
7367 * termcap.c (valid_filename_p, tprint, main): Likewise.
7368 * tparam.c (main): Likewise.
7369 * unexhp9k800.c (run_time_remap, save_data_space)
7370 (update_file_ptrs, read_header, write_header, calculate_checksum)
7371 (copy_file, copy_rest, display_header): Likewise.
7372 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7373 Likewise.
7374 * xdisp.c (check_it): Likewise.
7375 * xfaces.c (register_color, unregister_color, unregister_colors):
7376 Likewise.
7377 * xfns.c (print_fontset_result): Likewise.
7378 * xrdb.c (member, fatal, main): Likewise.
7379
99033785
PE
73802011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7381
7382 Fix minor problems found by static checking (Bug#9031).
7383 * chartab.c (char_table_set_range, map_sub_char_table):
7384 Remove unused locals.
7385 (uniprop_table): Now static.
7386 * composite.c (_work_char): Remove unused static var.
7387
9cb2ac56
JB
73882011-07-09 Juanma Barranquero <lekktu@gmail.com>
7389
7390 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7391
f25661f0
JD
73922011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7393
7394 * gtkutil.c (qttip_cb): Remove code without function.
7395
8278c4fe
EZ
73962011-07-09 Eli Zaretskii <eliz@gnu.org>
7397
7398 * w32.c (pthread_sigmask): New stub.
7399
1692ae2d 74002011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7401
8a6ebd58 7402 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7403 sigprocmask is portable only for single-threaded applications, and
7404 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7405 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7406 (LIBES): Use it.
7407 * callproc.c (Fcall_process):
7408 * process.c (create_process):
7409 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7410 Use pthread_sigmask, not sigprocmask.
123403e4 7411
1b854618
JD
74122011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7413
7414 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7415 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7416 wrong (Bug#8591).
7417
3fe4b549
JD
74182011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7419
0ce7e563
JD
7420 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7421 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7422 (xg_hide_tooltip): Fix comment.
7423
3fe4b549
JD
7424 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7425 in registerServicesMenuSendTypes.
7426 (validRequestorForSendType): Don't check ns_return_types.
7427
7428 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7429 ns_return_type.
7430
5df75e47
JR
74312011-07-08 Jason Rumney <jasonr@gnu.org>
7432
22610910
JR
7433 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7434 SH_SHOW for hidden windows (Bug#5482).
7435
5df75e47
JR
7436 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7437 frame struct members of non-existent frames (Bug#6284).
7438
699c10bd
JD
74392011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7440
4393663b
JD
7441 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7442 variable firstTime not needed on OSX >= 10.6.
7443 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7444 >= 10.5. Use setKnobProportion, setDoubleValue.
7445
7446 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7447 (MAC_OS_X_VERSION_10_5): Define if not defined.
7448 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7449 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7450 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7451
7452 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7453 cString and lossyCString on OSX >= 10.4
7454
58179cce 7455 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7456 sizeToFit on OSX >= 10.2.
7457
7458 * nsimage.m (allocInitFromFile): Don't use deprecated method
7459 bestRepresentationForDevice on OSX >= 10.6.
7460
7461 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7462 to avoid warning.
7463
7464 * emacs.c: Declare unexec_init_emacs_zone.
7465
a63e0781
JD
7466 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7467
699c10bd
JD
7468 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7469
7470 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7471 on svcsMenu (Bug#8842).
7472
7473 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7474 ns_return_types.
7475 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7476
7477 * nsterm.m (QUTF8_STRING): Declare.
7478 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7479 (validRequestorForSendType): Return type is (id).
7480 Change indexOfObjectIdenticalTo to indexOfObject.
7481 Check if we have local selection before returning self (Bug#8842).
7482 (writeSelectionToPasteboard): Put local selection into paste board
7483 if we have a local selection (Bug#8842).
7484 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7485
7486 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7487 (ns_get_local_selection): Declare.
7488
54e10184
LMI
74892011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7490
9888ff71
LMI
7491 * keymap.c (describe_map_tree): Don't insert a double newline at
7492 the end of the buffer (bug#1169) and return whether we inserted
7493 something.
7494
54e10184
LMI
7495 * callint.c (Fcall_interactively): Change "reading args" to
7496 "providing args" to try to clarify what it does (bug#1010).
7497
15fa4783
KH
74982011-07-07 Kenichi Handa <handa@m17n.org>
7499
7500 * composite.c (composition_compute_stop_pos): Ignore a static
7501 composition starting before CHARPOS (Bug#8915).
7502
7503 * xdisp.c (handle_composition_prop): Likewise.
7504
a8815b00
EZ
75052011-07-07 Eli Zaretskii <eliz@gnu.org>
7506
7507 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7508 (Bug#9015)
7509
ef7b981d 75102011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7511
7512 * character.h (unicode_category_t): New enum type.
7513
7514 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7515 (Qchar_code_property_table): New variable.
7516 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7517 (UNIPROP_COMPRESSED_FORM_P): New macros.
7518 (char_table_ascii): Uncompress the compressed values.
7519 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7520 Uncompress the compressed values.
ac389d0c 7521 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7522 (char_table_ref_and_range): Uncompress the compressed values.
7523 (sub_char_table_set): New arg is_uniprop. Callers changed.
7524 Uncompress the compressed values.
7525 (sub_char_table_set_range): Args changed. Callers changed.
7526 (char_table_set_range): Adjuted for the above change.
7527 (map_sub_char_table): Delete args default_val and parent. Add arg
7528 top. Give decoded values to a Lisp function.
640c8776 7529 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7530 values to a Lisp function. Gcpro more variables.
7531 (uniprop_table_uncompress)
7532 (uniprop_decode_value_run_length): New functions.
7533 (uniprop_decoder, uniprop_decoder_count): New variables.
7534 (uniprop_get_decoder, uniprop_encode_value_character)
7535 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7536 New functions.
7537 (uniprop_encoder, uniprop_encoder_count): New variables.
7538 (uniprop_get_encoder, uniprop_table)
7539 (Funicode_property_table_internal, Fget_unicode_property_internal)
7540 (Fput_unicode_property_internal): New functions.
7541 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7542 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7543 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7544 char-code-property-alist.
7545
640c8776 7546 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7547 Vunicode_category_table.
7548
640c8776 7549 * font.c (font_range): Adjust for the change of
c805dec0
KH
7550 Vunicode_category_table.
7551
76b397fb
DN
75522011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7553
7554 * m/iris4d.h: Remove file, move contents ...
7555 * s/irix6-5.h: ... here.
7556
22b4128e
PE
75572011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7558
7559 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7560 * alloc.c (mark_buffer):
7561 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7562 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7563 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7564 This isn't true in general, and it's particularly not true
7565 if Emacs is configured with --with-wide-int.
7566 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7567 New macros, used in the buffer.c change.
7568
869795d6
JD
75692011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7570
7571 * xsettings.c: Use both GConf and GSettings if both are available.
7572 (store_config_changed_event): Add comment.
7573 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7574 (store_tool_bar_style_changed): New functions.
5e617bc2 7575 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7576 (struct xsettings): Move font inside HAVE_XFT.
7577 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7578 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7579 Move inside HAVE_XFT.
640c8776 7580 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7581 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7582 also.
7583 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7584 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7585 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7586 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7587 (parse_settings): Move check for font inside HAVE_XFT.
7588 (read_settings, apply_xft_settings): Add comment.
7589 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7590 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7591 call store_font_name_changed.
7592 (xft_settings_event): Add comment.
7593 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7594 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7595 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7596 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7597 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7598 (xsettings_get_system_font, xsettings_get_system_normal_font):
7599 Add comment.
869795d6 7600
d8ed26bd
PE
76012011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7602
7603 Random fixes. E.g., (random) never returned negative values.
7604 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7605 subseconds part to the entropy, as that's a bit more random.
7606 Prefer signed to unsigned, since the signedness doesn't matter and
7607 in general we prefer signed. When given a limit, use a
7608 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7609 latter isn't right if USE_2_TAGS_FOR_INTS.
7610 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7611 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7612
cabf1cac
SM
76132011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7614
7615 * textprop.c (text_property_stickiness):
7616 Obey Vtext_property_default_nonsticky.
7617 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7618 * w32fns.c (syms_of_w32fns):
7619 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7620
6e9b2be9
PE
76212011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7622
7623 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7624 This is more efficient than Ffile_directory_p and avoids a minor race.
7625
90186c68
LMI
76262011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7627
7c301272
LMI
7628 * buffer.c (Foverlay_put): Say what the return value is
7629 (bug#7835).
7630
c4f2d8d4
LMI
7631 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7632 is a directory before asking whether to use the file name
7633 (bug#7564).
ad637907
LMI
7634 (barf_or_query_if_file_exists): Make the "File is a directory"
7635 error be more correct.
c4f2d8d4 7636
90186c68
LMI
7637 * fns.c (Frequire): Remove the mention of the .gz files, since
7638 that's installation-specific, but keep the mention of
7639 `get-load-suffixes'.
7640
da64016e
PE
76412011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7642
7643 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7644 Report string overflow if the output is too long.
7645
7d47b580
JB
76462011-07-04 Juanma Barranquero <lekktu@gmail.com>
7647
a555cb87
JB
7648 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7649 (syms_of_gnutls): Remove duplicate DEFSYM for
7650 Qgnutls_bootprop_verify_hostname_error, an error for
7651 Qgnutls_bootprop_verify_error (which is no longer used).
7652
7d47b580
JB
7653 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7654 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7655 Also (re)move comments that are misplaced or no longer relevant.
7656
1e49bfab
LMI
76572011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7658
7659 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7660
1485f4c0
CY
76612011-07-03 Chong Yidong <cyd@stupidchicken.com>
7662
7663 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7664 and background color parameters if they have been changed.
7665
a9ab721e
LMI
76662011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7667
7668 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7669
cf7cff57
PE
76702011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7671
2e13213d
PE
7672 * xsettings.c (SYSTEM_FONT): Define only when used.
7673 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7674
cf7cff57
PE
7675 * keymap.c (access_keymap_1): Now static.
7676
7a8e04f7
CY
76772011-07-02 Chong Yidong <cyd@stupidchicken.com>
7678
7679 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7680 leave any prefix arg for the up event (Bug#1586).
7681
61352f62
LMI
76822011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7683
69bb1ef7
LMI
7684 * lread.c (syms_of_lread): Mention single symbols defined by
7685 `defvar' or `defconst' (bug#7154).
7686
61352f62 7687 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7688 (Frequire): Mention get-load-suffixes.
61352f62 7689
28545e04
MR
76902011-07-02 Martin Rudalics <rudalics@gmx.at>
7691
7692 * window.h (window): Remove clone_number slot.
7693 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7694 Remove.
7695 (make_parent_window, make_window, saved_window)
7696 (Fset_window_configuration, save_window_save): Don't deal with
7697 clone numbers.
7698 * buffer.c (Qclone_number): Remove declaration.
7699 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7700
3349e122
SM
77012011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7702
7703 Add multiple inheritance to keymaps.
7704 * keymap.c (Fmake_composed_keymap): New function.
7705 (Fset_keymap_parent): Simplify.
7706 (fix_submap_inheritance): Remove.
7707 (access_keymap_1): New function extracted from access_keymap to handle
7708 embedded parents and handle lists of maps.
7709 (access_keymap): Use it.
7710 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7711 (Fcopy_keymap): Handle embedded parents.
7712 (Fcommand_remapping, define_as_prefix): Simplify.
7713 (Fkey_binding): Simplify.
7714 (syms_of_keymap): Move minibuffer-local-completion-map,
7715 minibuffer-local-filename-completion-map,
7716 minibuffer-local-must-match-map, and
7717 minibuffer-local-filename-must-match-map to Elisp.
7718 (syms_of_keymap): Defsubr make-composed-keymap.
7719 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7720 (parse_menu_item): Trivial simplification.
7721
3279eb87
GM
77222011-07-01 Glenn Morris <rgm@gnu.org>
7723
7724 * Makefile.in (SETTINGS_LIBS): Fix typo.
7725
4550efdf
KI
77262011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7727
7728 * coding.c (Fencode_coding_string): Record the last coding system
7729 used, as the function doc string says (bug#8738).
7730
0949d2b6
JD
77312011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7732
7733 * xsettings.c (store_monospaced_changed): Take new font as arg and
7734 check for change against current_mono_font.
7735 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7736 (emacs_settings_constructor, emacs_settings_get_property)
7737 (emacs_settings_set_property, emacs_settings_class_init)
7738 (emacs_settings_init, gsettings_obj): Remove.
7739 (something_changedCB): New function for HAVE_GSETTINGS.
7740 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7741 with value as argument.
7742 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7743 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7744 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7745 "changed".
7746
7747 * xgselect.c: Add defined (HAVE_GSETTINGS).
7748 (xgselect_initialize): Ditto.
7749
7750 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7751 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7752 xg_select.
7753
bbc6b304
PE
77542011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7755
7756 * eval.c (struct backtrace): Simplify and port the data structure.
7757 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7758 signed bit field, as this assumption is not portable and it makes
7759 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7760 "char debug_on_exit : 1" as this is not portable either; instead,
7761 use the portable "unsigned int debug_on_exit : 1". Remove unused
7762 member evalargs. Remove obsolete comments about cc bombing out.
7763
9851bfc5
JD
77642011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7765
51bb811f 7766 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7767 Let HAVE_GSETTINGS override HAVE_GCONF.
7768 (store_monospaced_changed): New function.
7769 (EMACS_SETTINGS): A new type derived from GObject to handle
7770 GSettings notifications.
7771 (emacs_settings_constructor, emacs_settings_get_property)
7772 (emacs_settings_set_property, emacs_settings_class_init):
7773 New functions.
7774 (gsettings_client, gsettings_obj): New variables.
7775 (GSETTINGS_SCHEMA): New define.
7776 (something_changedCB): Call store_monospaced_changed.
7777 (init_gsettings): New function.
7778 (xsettings_initialize): Call init_gsettings.
7779 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7780 to NULL.
7781
640c8776 7782 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7783 GCONF_CFLAGS/LIBS.
7784
5386012d
MR
77852011-06-29 Martin Rudalics <rudalics@gmx.at>
7786
7787 * window.c (resize_root_window, grow_mini_window)
7788 (shrink_mini_window): Rename Qresize_root_window to
7789 Qwindow_resize_root_window and Qresize_root_window_vertically to
7790 Qwindow_resize_root_window_vertically.
7791
f13e0b08
PE
77922011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7793
7794 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7795
94515237
JB
77962011-06-27 Juanma Barranquero <lekktu@gmail.com>
7797
7798 * makefile.w32-in: Redesign dependencies so they reflect more
7799 clearly which files are directly included by each source file,
7800 and not through other includes.
7801
e43b6e43
MR
78022011-06-27 Martin Rudalics <rudalics@gmx.at>
7803
7804 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7805 (sort_overlays, overlay_strings): When an overlay's clone number
7806 matches the window's clone number process the overlay even if
7807 the overlay's window property doesn't match the current window.
7808
d68443dc
MR
7809 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7810 (Fwindow_hchild): Rename to Fwindow_left_child.
7811 (Fwindow_next): Rename to Fwindow_next_sibling.
7812 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7813 (resize_window_check): Rename to window_resize_check.
7814 (resize_window_apply): Rename to window_resize_apply.
7815 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7816 (Fdelete_other_windows_internal, resize_frame_windows)
7817 (Fsplit_window_internal, Fdelete_window_internal)
7818 (grow_mini_window, shrink_mini_window)
7819 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7820
c7e73be5
JD
78212011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7822
7823 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7824 (emacs_fixed_set_min_size): Remove.
7825 (emacs_fixed_new): Take frame as argument.
7826
7827 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7828 (_EmacsFixedPrivate): Remove minwidth/height.
7829 Add struct frame *f.
7830 (emacs_fixed_init): Initialize priv->f.
7831 (get_parent_class, emacs_fixed_set_min_size): Remove.
7832 (emacs_fixed_new): Set priv->f to argument.
7833 (emacs_fixed_get_preferred_width)
7834 (emacs_fixed_get_preferred_height): Use min_width/height from
7835 frames size_hint to set minimum and natural (Bug#8919).
7836 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7837 and use min_width/height from frames size_hint to set
7838 min_width/height (Bug#8919).
7839
7840 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7841 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7842 Fix indentation.
c7e73be5 7843
cf99dcf8
EZ
78442011-06-26 Eli Zaretskii <eliz@gnu.org>
7845
7846 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7847 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7848 called at ZV.
7849
029529ac
CY
78502011-06-26 Chong Yidong <cyd@stupidchicken.com>
7851
7852 * process.c (wait_reading_process_output): Bypass select if
7853 waiting for a cell while ignoring keyboard input, and input is
7854 pending. Suggested by Jan Djärv (Bug#8869).
7855
7a7ef429
PE
78562011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7857
7858 Use gnulib's dup2 module instead of rolling our own.
7859 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7860
11fdef7d 78612011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7862
7863 * dispnew.c (scrolling_window): Before scrolling, turn off a
7864 mouse-highlight in the window being scrolled.
7865
cd3520a4
JB
78662011-06-24 Juanma Barranquero <lekktu@gmail.com>
7867
7868 Move DEFSYM to lisp.h and use everywhere.
7869
7870 * character.h (DEFSYM): Move declaration...
7871 * lisp.h (DEFSYM): ...here.
7872
7873 * gnutls.c:
7874 * minibuf.c:
7875 * w32menu.c:
7876 * w32proc.c:
7877 * w32select.c: Don't include character.h.
7878
7879 * alloc.c (syms_of_alloc):
7880 * buffer.c (syms_of_buffer):
7881 * bytecode.c (syms_of_bytecode):
7882 * callint.c (syms_of_callint):
7883 * casefiddle.c (syms_of_casefiddle):
7884 * casetab.c (init_casetab_once):
7885 * category.c (init_category_once, syms_of_category):
7886 * ccl.c (syms_of_ccl):
7887 * cmds.c (syms_of_cmds):
7888 * composite.c (syms_of_composite):
7889 * dbusbind.c (syms_of_dbusbind):
7890 * dired.c (syms_of_dired):
7891 * dispnew.c (syms_of_display):
7892 * doc.c (syms_of_doc):
7893 * editfns.c (syms_of_editfns):
7894 * emacs.c (syms_of_emacs):
7895 * eval.c (syms_of_eval):
7896 * fileio.c (syms_of_fileio):
7897 * fns.c (syms_of_fns):
7898 * frame.c (syms_of_frame):
7899 * fringe.c (syms_of_fringe):
7900 * insdel.c (syms_of_insdel):
7901 * keymap.c (syms_of_keymap):
7902 * lread.c (init_obarray, syms_of_lread):
7903 * macros.c (syms_of_macros):
7904 * msdos.c (syms_of_msdos):
7905 * print.c (syms_of_print):
7906 * process.c (syms_of_process):
7907 * search.c (syms_of_search):
7908 * sound.c (syms_of_sound):
7909 * syntax.c (init_syntax_once, syms_of_syntax):
7910 * terminal.c (syms_of_terminal):
7911 * textprop.c (syms_of_textprop):
7912 * undo.c (syms_of_undo):
7913 * w32.c (globals_of_w32):
7914 * window.c (syms_of_window):
7915 * xdisp.c (syms_of_xdisp):
7916 * xfaces.c (syms_of_xfaces):
7917 * xfns.c (syms_of_xfns):
7918 * xmenu.c (syms_of_xmenu):
7919 * xsettings.c (syms_of_xsettings):
7920 * xterm.c (syms_of_xterm): Use DEFSYM.
7921
4228cf16
TZ
79222011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7923
cd3520a4 7924 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7925
7fcccf1e
PE
79262011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7927
7efb4e0e
PE
7928 Integer and buffer overflow fixes (Bug#8873).
7929
ff5844ad
PE
7930 * print.c (printchar, strout): Check for string overflow.
7931 (PRINTPREPARE, printchar, strout):
7932 Don't set size unless allocation succeeds.
7933
90532f02
PE
7934 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7935 for sizes. Check for string overflow more accurately.
7936 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7937
6d84508d
PE
7938 * macros.c: Integer and buffer overflow fixes.
7939 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7940 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7941 Use ptrdiff_t, not int, for sizes.
7942 Don't increment bufsize until after realloc succeeds.
7943 Check for size-calculation overflow.
7944 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7945
437b2cb4
PE
7946 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7947
8b9ac8b4
PE
7948 * lread.c: Integer overflow fixes.
7949 (read_integer): Radix is now EMACS_INT, not int,
7950 to improve quality of diagnostics for out-of-range radices.
7951 Calculate buffer size correctly for out-of-range radices.
7952 (read1): Check for integer overflow in radices, and in
7953 read-circle numbers.
82cb60d3
PE
7954 (read_escape): Avoid int overflow.
7955 (Fload, openp, read_buffer_size, read1)
7956 (substitute_object_recurse, read_vector, read_list, map_obarray):
7957 Use ptrdiff_t, not int, for sizes.
7958 (read1): Use EMACS_INT, not int, for sizes.
20270765 7959 Check for size overflow.
8b9ac8b4 7960
7fcccf1e
PE
7961 * image.c (cache_image): Check for size arithmetic overflow.
7962
bfbbd7e7
PE
7963 * lread.c: Integer overflow issues.
7964 (saved_doc_string_size, saved_doc_string_length)
7965 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7966 Now ptrdiff_t, not int.
7967 (read1): Don't assume doc string length fits in int. Check for
7968 out-of-range doc string lengths.
7969 (read_list): Don't assume file position fits in int.
39019e54 7970 (read_escape): Check for hex character overflow.
bfbbd7e7 7971
4e323265
LL
79722011-06-22 Leo Liu <sdl.web@gmail.com>
7973
7974 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7975 Move to minibuffer.el.
7976
85fece3e
PE
79772011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7978
20b84ce9 7979 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7980 The following patches are for when GLYPH_DEBUG && !XASSERT.
7981 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7982 * dispnew.c (flush_stdout):
7983 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7984 Mark as externally visible.
7985 * dispnew.c (check_window_matrix_pointers): Now static.
7986 * dispnew.c (window_to_frame_vpos):
7987 * xfns.c (unwind_create_frame):
7988 * xterm.c (x_check_font): Remove unused local.
7989 * scroll.c (CHECK_BOUNDS):
7990 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7991 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7992 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7993 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7994 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7995 Now static.
7996 (debug_method_add): Use va_list and vsprintf rather than relying
7997 on undefined behavior with wrong number of arguments.
7998 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7999 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8000 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8001 since we're not interested in debugging glyphs with old libraries.
8002 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8003 GCC 4.6.0's static checking.
8004
0766b489
PE
80052011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8006
31fd4b32
PE
8007 Integer overflow and signedness fixes (Bug#8873).
8008 A few related buffer overrun fixes, too.
8009
b79e8648
PE
8010 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8011
0766b489
PE
8012 * dispextern.h (struct face.stipple):
8013 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8014 (x_bitmap_mask, x_allocate_bitmap_record)
8015 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8016 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8017 (x_create_bitmap_from_xpm_data):
8018 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8019 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8020 (.bitmaps_last):
8021 * xfaces.c (load_pixmap):
8022 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8023 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8024 (.bitmaps_last, struct x_output.icon_bitmap):
8025 Use ptrdiff_t, not int, for bitmap indexes.
8026 (x_allocate_bitmap_record): Check for size overflow.
8027 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8028
b081724f
PE
8029 Use ptrdiff_t, not int, for overlay counts.
8030 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8031 * editfns.c (overlays_around, get_pos_property):
8032 * textprop.c (get_char_property_and_overlay):
8033 * xdisp.c (next_overlay_change, note_mouse_highlight):
8034 * xfaces.c (face_at_buffer_position):
21514da7
PE
8035 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8036 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8037 (Fnext_overlay_change, Fprevious_overlay_change)
8038 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8039 Use ptrdiff_t, not int, for sizes.
21514da7 8040 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8041
3de73e5e
PE
8042 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8043
2606c57b
PE
8044 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8045 (x_session_initialize): Do not assume string length fits in int.
8046
aaafe47a
PE
8047 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8048 This is unlikely, but can occur if DPI is outlandish.
8049
2674ddc8 8050 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8051 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8052
28154962
PE
8053 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8054 * xrdb.c (magic_file_p, search_magic_path):
8055 Omit last arg SUFFIX; it was always 0. All callers changed.
8056 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8057
7de51af5
PE
8058 * xfont.c (xfont_match): Avoid need for strlen.
8059
25ed6cc3
PE
8060 * xfns.c: Don't assume strlen fits in int.
8061 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8062
4eab31dd
PE
8063 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8064 not unsigned long, as we prefer signed integers. All callers changed.
8065 Detect integer overflow in repeat count.
8066 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8067 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8068
171e2a58
PE
8069 * termcap.c: Don't assume sizes fit in int and never overflow.
8070 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8071 (gobble_line): Check for size-calculation overflow.
8072
ad39faca 8073 * minibuf.c (Fread_buffer):
6e5bb2dc 8074 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8075 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8076 Don't assume string length fits in int.
8077
52c61c22 8078 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8079 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8080
b5b8c9e5
PE
8081 * font.c: Don't assume string length fits in int.
8082 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8083 Use ptrdiff_t, not int.
ccd6111c
PE
8084 (font_intern_prop): Don't assume string length fits in int.
8085 Don't assume integer property fits in fixnum.
8086 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8087
882f0d81 8088 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8089 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8090 Reformulate so as not to need the command string.
8091 Invoke gzip -cd rather than gunzip, as it's more portable.
8092 (lock_info_type, lock_file_1, lock_file):
8093 Don't assume pid_t and time_t fit in unsigned long.
8094 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8095 (current_lock_owner): Prefer signed type for sizes.
8096 Use memcpy, not strncpy, where memcpy is what is really wanted.
8097 Don't assume (via atoi) that time_t and pid_t fit in int.
8098 Check for time_t and/or pid_t out of range, e.g., via a network share.
8099 Don't alloca where an auto var works fine.
8100
93f4cf88
PE
8101 * fileio.c: Fix some integer overflow issues.
8102 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8103 Don't assume string length fits in int.
8104 (directory_file_name): Don't assume string length fits in long.
8105 (make_temp_name): Don't assume pid fits in int, or that its print
8106 length is less than 20.
8107
f3e92b69
PE
8108 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8109
1bfdaf10
PE
8110 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8111
35016e9a
PE
8112 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8113
3d1e65a1
PE
8114 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8115 We prefer signed integers, even for size calculations.
8116
0b963a93
PE
8117 * emacs.c: Don't assume string length fits in 'int'.
8118 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8119 (main): Don't invoke strlen when not needed.
8120
573f4b54
PE
8121 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8122 (XD_DEBUG_MESSAGE): Don't waste a byte.
8123
989f33ba
PE
8124 * callproc.c (getenv_internal_1, getenv_internal)
8125 (Fgetenv_internal):
965d34eb
PE
8126 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8127
e4d29b33
PE
8128 * lread.c (invalid_syntax): Omit length argument.
8129 All uses changed. This doesn't fix a bug, but it simplifies the
8130 code away from its former Hollerith-constant appearance, and it's
8131 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8132 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8133
eb49b136
PE
8134 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8135 This didn't break anything, but it didn't help either.
8136 It's confusing to put a bogus integer in a place where the actual
8137 value does not matter.
9f62aeb1 8138 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8139 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8140
15375a22
PE
8141 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8142 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8143 implementation.
b61cc01c
PE
8144 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8145 We prefer signed types, and the value cannot exceed the EMACS_INT
8146 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8147 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8148 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8149 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8150
53b2623d
PE
8151 * indent.c (sane_tab_width): New function.
8152 (current_column, scan_for_column, Findent_to, position_indentation)
8153 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8154 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8155
51cab52b 8156 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8157
f2ed8a70
PE
8158 * lisp.h (lint_assume): New macro.
8159 * composite.c (composition_gstring_put_cache):
8160 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8161
abe80cc6
PE
8162 * editfns.c, insdel.c:
8163 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8164
b02c740e
PE
8165 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8166
ebc96716
PE
8167 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8168
b4e50fa0 8169 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8170 Use much-faster test for byte-length change.
311d5d7c 8171 Don't assume string byte-length fits in 'int'.
a4cf38e4 8172 Check that character arg fits in 'int'.
85461888 8173 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8174
c0c1ee9f
PE
8175 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8176
a498d7f4
PE
8177 * fns.c (concat): Catch string overflow earlier.
8178 Do not rely on integer wraparound.
8179
51cab52b
PE
8180 * dispextern.h (struct it.overlay_strings_charpos)
8181 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8182 * xdisp.c (forward_to_next_line_start)
8183 (back_to_previous_visible_line_start)
8184 (reseat_at_next_visible_line_start, next_element_from_buffer):
8185 Don't arbitrarily truncate the value of 'selective' to int.
8186
76031fad
PE
8187 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8188
5eb55db9
PE
8189 * composite.c: Don't truncate sizes to 'int'.
8190 (composition_gstring_p, composition_reseat_it)
8191 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8192 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8193 not EMACS_UINT, for indexes.
5eb55db9 8194
0703a717
PE
8195 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8196
d6202519
PE
8197 * buffer.c: Include <verify.h>.
8198 (struct sortvec.priority, struct sortstr.priority):
8961a454 8199 Now EMACS_INT, not int.
c20998a7 8200 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8201 (struct sortstr.size, record_overlay_string)
8202 (struct sortstrlist.size, struct sortlist.used):
8203 Don't truncate size to int.
8204 (record_overlay_string): Check for size-calculation overflow.
d6202519 8205 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8206
d5a19415
JM
82072011-06-22 Jim Meyering <meyering@redhat.com>
8208
029529ac 8209 Don't leak an XBM-image-sized buffer
d5a19415
JM
8210 * image.c (xbm_load): Free the image buffer after using it.
8211
a9041e6c
PE
82122011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8213
8214 Port to Sun C.
8215 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8216 that Sun C diagnosed.
8217 * fns.c (secure_hash): Fix pointer signedness issue.
8218 * intervals.c (static_offset_intervals): New function.
8219 (offset_intervals): Use it.
8220
7f3f739f
LL
82212011-06-21 Leo Liu <sdl.web@gmail.com>
8222
8223 * deps.mk (fns.o):
8224 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8225 sha512.h.
8226
8227 * fns.c (secure_hash): Rename from crypto_hash_function and change
8228 the first arg to accept symbols.
5b66d427 8229 (Fsecure_hash): New primitive.
7f3f739f
LL
8230 (syms_of_fns): New symbols.
8231
76147d94
DD
82322011-06-20 Deniz Dogan <deniz@dogan.se>
8233
8234 * process.c (Fset_process_buffer): Clarify return value in
8235 docstring.
8236
7d7d0045
CY
82372011-06-18 Chong Yidong <cyd@stupidchicken.com>
8238
8239 * dispnew.c (add_window_display_history): Use BVAR.
8240
8241 * xdisp.c (debug_method_add): Use BVAR.
8242 (check_window_end, dump_glyph_matrix, dump_glyph)
8243 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8244
8245 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8246 Likewise.
8247
8248 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8249 check till after the cache is created in init_frame_faces.
8250
ff2bc410
SM
82512011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8252
8253 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8254
28177add
PE
82552011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8256
dd3482fe
PE
8257 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8258 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8259 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8260
393d71f3 8261 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8262 * fileio.c (Finsert_file_contents):
8263 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8264 Remove the old (too-loose) buffer overflow checks.
8265 They weren't needed, since make_gap checks for buffer overflow.
8266 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8267 The old code merely checked for Emacs fixnum overflow, and relied
8268 on undefined (wraparound) behavior. The new code avoids undefined
8269 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8270
2e6813b0 8271 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8272 Tune. Don't use wider integers than needed. Don't use alloca.
8273 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8274
599a9e4f
PE
8275 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8276
99561444
PE
8277 * insdel.c, lisp.h (buffer_overflow): New function.
8278 (insert_from_buffer_1, replace_range, replace_range_2):
8279 * insdel.c (make_gap_larger):
8280 * editfns.c (Finsert_char):
8281 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8282
28177add
PE
8283 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8284
e69dafad
PE
82852011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8286
4baa020d 8287 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8288
b1c46f02
PE
8289 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8290 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8291
e69dafad
PE
8292 * fileio.c: Don't assume EMACS_INT fits in off_t.
8293 (emacs_lseek): New static function.
8294 (Finsert_file_contents, Fwrite_region): Use it.
8295 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8296
566684ea
PE
8297 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8298
e6966cd6
PE
8299 * fns.c: Don't overflow int when computing a list length.
8300 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8301 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8302 truncation on 64-bit hosts. Check for QUIT every
8303 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8304 faster and is responsive enough.
8305 (Flength): Report an error instead of overflowing an integer.
8306 (Fsafe_length): Return a float if the value is not representable
8307 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8308 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8309 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8310
dd0b0efb
PE
8311 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8312 (header_size, word_size): New constants.
8313 (allocate_vectorlike): Don't check size overflow here.
8314 (allocate_vector): Check it here instead, since this is the only
8315 caller of allocate_vectorlike that could cause overflow.
8316 Check that the new vector's length is representable as a fixnum.
8317
86fe5cfe
PE
8318 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8319 The previous code was bogus. For example, next_almost_prime (32)
8320 returned 39, which is undesirable as it is a multiple of 3; and
8321 next_almost_prime (24) returned 25, which is a multiple of 5 so
8322 why was the code bothering to check for multiples of 7?
8323
80e88859
PE
8324 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8325
4a2f0ad6
PE
8326 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8327
f66c7cf8
PE
8328 Variadic C functions now count arguments with ptrdiff_t.
8329 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8330 Back then I didn't know that the Emacs coding style prefers signed int.
8331 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8332 were being counted with int, which may truncate counts on 64-bit
8333 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8334 * lisp.h (struct Lisp_Subr.function.aMANY)
8335 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8336 Arg counts are now ptrdiff_t, not size_t.
8337 All variadic functions and their callers changed accordingly.
8338 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8339 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8340 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8341 * callint.c (Fcall_interactively): Check arg count for overflow,
8342 to avoid potential buffer overrun. Use signed char, not 'int',
8343 for 'varies' array, so that we needn't bother to check its size
8344 calculation for overflow.
8345 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8346 * eval.c (apply_lambda):
8347 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8348 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8349 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8350
a1759b76
PE
8351 * callint.c (Fcall_interactively): Don't use index var as event count.
8352
d96be9fc
PE
8353 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8354 * mem-limits.h (SIZE): Remove; no longer used.
8355
a690a978 8356 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8357
578c21e6
PE
8358 Remove unnecessary casts.
8359 * xterm.c (x_term_init):
8360 * xfns.c (x_set_border_pixel):
8361 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8362 These aren't needed now that we assume ANSI C.
8363
96f53c6c
PE
8364 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8365 It's more likely to cause problems (due to unsigned overflow)
8366 than to cure them.
8367
83c77d31
PE
8368 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8369
ee2079f1
PE
8370 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8371
6da65536
PE
8372 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8373
7147c4a4
PE
8374 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8375
193e32d9
PE
8376 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8377
e5533da6
PE
8378 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8379
9910e595
PE
8380 GLYPH_CODE_FACE returns EMACS_INT, not int.
8381 * dispextern.h (merge_faces):
8382 * xfaces.c (merge_faces):
01103c44
PE
8383 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8384 Don't assume EMACS_INT fits in int.
9910e595 8385
2638320e
PE
8386 * character.h (CHAR_VALID_P): Remove unused parameter.
8387 * fontset.c, lisp.h, xdisp.c: All uses changed.
8388
045eb8d9
PE
8389 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8390
c1f134b5
PE
8391 * fns.c (concat): Minor tuning based on overflow analysis.
8392 This doesn't fix any bugs. Use int to hold character, instead
8393 of constantly refetching from Emacs object. Use XFASTINT, not
8394 XINT, for value known to be a character. Don't bother comparing
8395 a single byte to 0400, as it's always less.
8396
395fcb93 8397 * floatfns.c (Fexpt):
327eeec8
PE
8398 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8399
abbd3d23
PE
8400 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8401 for characters.
8402
684a03ef
PE
8403 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8404
0fed43f3
PE
8405 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8406 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8407 incorrectly succeed when S was a string, because 4294967386 was
8408 truncated before it was used.
8409
8fd02eb7
PE
8410 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8411 Otherwise, an out-of-range integer could cause undefined behavior
8412 on a 64-bit host.
8413
f8c86b69
PE
8414 * composite.c: Use int, not EMACS_INT, for characters.
8415 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8416 EMACS_INT, for values that are known to be in character range.
8417 This doesn't fix any bugs but is the usual style inside Emacs and
8418 may generate better code on 32-bit machines.
8419
34206dd2
PE
8420 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8421 This is for reasons similar to the recent CHAR_STRING fix.
8422 * charset.c (Fencode_char): Check that character arg is actually
8423 a character. Pass an int to ENCODE_CHAR.
8424 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8425 wider than 'int', as a compile-time check to prevent future regressions
8426 in this area.
8427
c5958d4c 8428 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8429
8430 Make sure a 64-bit char is never passed to CHAR_STRING.
8431 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8432 by silently ignoring the top 32 bits, allowing some values
8433 that were far too large to be valid characters.
8434 * character.h: Include <verify.h>.
8435 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8436 arguments are no wider than unsigned, as a compile-time check
8437 to prevent future regressions in this area.
8438 * data.c (Faset):
01103c44 8439 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8440 (Fsubst_char_in_region):
8441 * fns.c (concat):
8442 * xdisp.c (decode_mode_spec_coding):
8443 Adjust to CHAR_STRING's new requirement.
8444 * editfns.c (Finsert_char, Fsubst_char_in_region):
8445 * fns.c (concat): Check that character args are actually
8446 characters. Without this test, these functions did the wrong
8447 thing with wildly out-of-range values on 64-bit hosts.
8448
d37ca623
PE
8449 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8450 These casts should not be needed on 32-bit hosts, either.
8451 * keyboard.c (read_char):
8452 * lread.c (Fload): Remove casts to unsigned.
8453
ea204efb
PE
8454 * lisp.h (UNSIGNED_CMP): New macro.
8455 This fixes comparison bugs on 64-bit hosts.
8456 (ASCII_CHAR_P): Use it.
8457 * casefiddle.c (casify_object):
01103c44 8458 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8459 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8460 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8461 * dispextern.h (FACE_FROM_ID):
8462 * keyboard.c (read_char): Use UNSIGNED_CMP.
8463
41cb286c
PE
8464 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8465 not to EMACS_INT, to avoid GCC warning.
8466
4a1b9832
PE
8467 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8468
55daad71
PE
8469 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8470 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8471 isn't needed on 32-bit machines.
8f95c75c 8472
01103c44
PE
8473 * buffer.c (Fgenerate_new_buffer_name):
8474 Use EMACS_INT for count, not int.
0ceccced 8475 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8476
8477 * data.c (Qcompiled_function): Now static.
8478
c6f072e7
PE
8479 * window.c (window_body_lines): Now static.
8480
20ce5912
PE
8481 * image.c (gif_load): Rename local to avoid shadowing.
8482
9c4c5f81
PE
8483 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8484 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8485 * alloc.c (make_save_value): Integer argument is now of type
8486 ptrdiff_t, not int.
8487 (mark_object): Use ptrdiff_t, not int.
8488 * lisp.h (pD): New macro.
8489 * print.c (print_object): Use it.
8490
c0c5c8ae
PE
8491 * alloc.c: Use EMACS_INT, not int, to count objects.
8492 (total_conses, total_markers, total_symbols, total_vector_size)
8493 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8494 (total_free_floats, total_floats, total_free_intervals)
8495 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8496 Now EMACS_INT, not int. All uses changed.
8497 (Fgarbage_collect): Compute overall total using a double, so that
8498 integer overflow is less likely to be a problem. Check for overflow
8499 when converting back to an integer.
5a25e253
PE
8500 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8501 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8502 These were 'int' variables that could overflow on 64-bit hosts;
8503 they were never used, so remove them instead of repairing them.
211a0b2a 8504 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8505 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8506 Previously, this ceilinged at INT_MAX, but that doesn't work on
8507 64-bit machines.
e46bb31a 8508 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8509
c78baabf 8510 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8511 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8512 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8513 when a (possibly-narrower) signed value would do just as well.
8514 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8515
c9d624c6
PE
8516 * alloc.c: Catch some string size overflows that we were missing.
8517 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8518 for convenience in STRING_BYTES_MAX.
8519 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8520 The definition here is exact; the one in lisp.h was approximate.
8521 (allocate_string_data): Check for string overflow. This catches
8522 some instances we weren't catching before. Also, it catches
8523 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8524 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8525 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8526
c9d624c6
PE
8527 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8528 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8529 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8530
353032ce
PE
8531 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8532
2bccce07
PE
8533 * alloc.c (Fmake_string): Check for out-of-range init.
8534
0ac30604
SM
85352011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8536
8537 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8538
c195f2de
JD
85392011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8540
8541 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8542 xg_get_default_scrollbar_width.
8543
8544 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8545 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8546 (style_changed_cb): Call update_theme_scrollbar_width and call
8547 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8548 all frames (Bug#8505).
8549 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8550 Call gtk_window_set_resizable if HAVE_GTK3.
8551 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8552 and height if HAVE_GTK3 (Bug#8505).
8553 (scroll_bar_width_for_theme): New variable.
8554 (update_theme_scrollbar_width): New function.
8555 (xg_get_default_scrollbar_width): Move code to
8556 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8557 (xg_initialize): Call update_theme_scrollbar_width.
8558
8559 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8560
8561 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8562
e10ac9f1
MR
85632011-06-12 Martin Rudalics <rudalics@gmx.at>
8564
8565 * frame.c (make_frame): Call other_buffer_safely instead of
8566 other_buffer.
8567
8568 * window.c (temp_output_buffer_show): Call display_buffer with
8569 second argument Vtemp_buffer_show_specifiers and reset latter
8570 immediately after the call.
8571 (Vtemp_buffer_show_specifiers): New variable.
8572 (auto_window_vscroll_p, next_screen_context_lines)
8573 (Vscroll_preserve_screen_position): Remove leading asterisks from
8574 doc-strings.
8575
2d3c217e 85762011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8577
7b7f97e8 8578 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8579 * buffer.c (Qclone_number): Remove for now, as it's unused.
8580 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8581 (record_buffer): Remove unused local.
8582 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8583 (set_frame_buffer_list): Remove; unused.
8584 * frame.h (other_visible_frames): Remove decl.
8585 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8586 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8587 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8588 if HAVE_GPM.
8589 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8590 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8591 Define only if HAVE_GPM.
8592 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8593 (update_hints_inhibit): Remove; never set. All uses removed.
8594 * widgetprv.h (emacsFrameClassRec): Remove decl.
8595 * window.c (delete_deletable_window): Now returns void, since it
8596 wasn't returning anything.
8597 (compare_window_configurations): Remove unused locals.
8598 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8599 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8600 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8601 the same widths as pointers. This follows up on the 2011-05-06 patch.
8602 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8603 * xterm.h: Likewise.
8604 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8605
1384b89e
JB
86062011-06-12 Juanma Barranquero <lekktu@gmail.com>
8607
8608 * makefile.w32-in: Update dependencies.
8609 (LISP_H): Add lib/intprops.h.
8610
1100a63c
CY
86112011-06-11 Chong Yidong <cyd@stupidchicken.com>
8612
8613 * image.c (gif_load): Add animation frame delay to the metadata.
8614 (syms_of_image): Use DEFSYM. New symbol `delay'.
8615
6198ccd0
MR
86162011-06-11 Martin Rudalics <rudalics@gmx.at>
8617
8618 * window.c (delete_deletable_window): Re-add.
8619 (Fset_window_configuration): Rewrite to handle dead buffers and
8620 consequently deletable windows.
8621 (window_tree, Fwindow_tree): Remove. Supply functionality in
8622 window.el.
8623 (compare_window_configurations): Simplify code.
8624
b6e3633c
AS
86252011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8626
1ab0dee5
AS
8627 * image.c (imagemagick_load_image): Fix type mismatch.
8628 (Fimagemagick_types): Likewise.
8629
b6e3633c
AS
8630 * window.h (replace_buffer_in_windows): Declare.
8631
9397e56f
MR
86322011-06-11 Martin Rudalics <rudalics@gmx.at>
8633
8634 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8635 Qclone_number. Remove external declaration of Qdelete_window.
8636 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8637 code.
640c8776
SM
8638 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8639 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8640 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8641 buffer list implementation.
8642 (other_buffer_safely): New function.
8643 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8644 calls to replace_buffer_in_windows and
8645 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8646 if allowed.
8647 (record_buffer): Inhibit quitting and rewrite using quittable
8648 functions. Run Qbuffer_list_update_hook if allowed.
8649 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8650 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8651 Move switch-to-buffer to window.el.
9397e56f
MR
8652 (bury-buffer): Move to window.el.
8653 (Vbuffer_list_update_hook): New variable.
8654
8655 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8656 section.
8657
8658 * window.h (resize_frame_windows): Move up in code.
8659 (Fwindow_frame): Remove EXFUN.
8660 (replace_buffer_in_all_windows): Remove prototype.
8661 (replace_buffer_in_windows_safely): Add prototype.
8662
8663 * window.c: Declare Qdelete_window static again. Move down
8664 declaration of select_count.
8665 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8666 (Fother_window): Move to window.el.
8667 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8668 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8669 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8670 window.el.
8671 (replace_buffer_in_windows): Implement by calling
8672 Qreplace_buffer_in_windows.
8673 (replace_buffer_in_all_windows): Remove with some functionality
8674 moved into replace_buffer_in_windows_safely.
8675 (replace_buffer_in_windows_safely): New function.
8676 (select_window_norecord, select_frame_norecord): Move in front
8677 of run_window_configuration_change_hook. Remove now obsolete
8678 declarations.
640c8776
SM
8679 (Fset_window_buffer): Rewrite doc-string.
8680 Call Qrecord_window_buffer.
9397e56f
MR
8681 (keys_of_window): Move binding for other-window to window.el.
8682
b50691aa
CY
86832011-06-11 Chong Yidong <cyd@stupidchicken.com>
8684
8685 * dispextern.h (struct image): Replace data member, whose int_val
8686 and ptr_val fields were not used by anything, with a single
8687 lisp_val object.
8688
8689 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8690 (gif_clear_image, gif_load, imagemagick_load_image)
8691 (gs_clear_image, gs_load): Callers changed.
8692
3f754b86
PE
86932011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8694
cca69397
PE
8695 * buffer.h: Include <time.h>, for time_t.
8696 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8697
109e28d0
PE
8698 Fix minor problems found by static checking.
8699
60737f02
PE
8700 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8701
4b66faf3
PE
8702 Make identifiers static if they are not used in other modules.
8703 * data.c (Qcompiled_function, Qframe, Qvector):
8704 * image.c (QimageMagick, Qsvg):
8705 * minibuf.c (Qmetadata):
8706 * window.c (resize_window_check, resize_root_window): Now static.
8707 * window.h (resize_window_check, resize_root_window): Remove decls.
8708
109e28d0
PE
8709 * window.c (window_deletion_count, delete_deletable_window):
8710 Remove; unused.
46a4ce9e
PE
8711 (window_body_lines): Now static.
8712 (Fdelete_other_windows_internal): Mark vars as initialized.
8713 Make sure 'resize_failed' is initialized.
8714 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8715 (resize_window_apply): Remove unused local.
8716 * window.h (delete_deletable_window): Remove decl.
8717
109e28d0 8718 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8719 (imagemagick_load_image): Fix pointer signedness problem by changing
8720 last arg from unsigned char * to char *. All uses changed.
8721 Also, fix a local for similar reasons.
8722 Remove unused locals. Remove locals to avoid shadowing.
8723 (fn_rsvg_handle_free): Remove; unused.
8724 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8725 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8726
3f754b86
PE
8727 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8728
2547adb1
CY
87292011-06-10 Chong Yidong <cyd@stupidchicken.com>
8730
8731 * image.c (gif_load): Fix omitted cast error introduced by
8732 2011-06-06 change.
8733
2c8e37d4
MR
87342011-06-10 Martin Rudalics <rudalics@gmx.at>
8735
8736 * window.h (resize_proportionally, orig_total_lines)
8737 (orig_top_line): Remove from window structure.
8738 (set_window_height, set_window_width, change_window_heights)
8739 (Fdelete_window): Remove prototypes.
8740 (resize_frame_windows): Remove duplicate declaration.
8741
440a42e3
EZ
87422011-06-10 Eli Zaretskii <eliz@gnu.org>
8743
8744 * window.h (resize_frame_windows, resize_window_check)
8745 (delete_deletable_window, resize_root_window)
8746 (resize_frame_windows): Declare prototypes.
8747
8748 * window.c (resize_window_apply): Make definition be "static" to
8749 match the prototype.
8750
562dd5e9
MR
87512011-06-10 Martin Rudalics <rudalics@gmx.at>
8752
8753 * window.c: Remove declarations of Qwindow_size_fixed,
8754 window_min_size_1, window_min_size_2, window_min_size,
8755 size_window, window_fixed_size_p, enlarge_window, delete_window.
8756 Remove static from declaration of Qdelete_window, it's
8757 temporarily needed by Fbury_buffer.
8758 (replace_window): Don't assign orig_top_line and
8759 orig_total_lines.
8760 (Fdelete_window, delete_window): Remove. Window deletion is
8761 handled by window.el.
640c8776
SM
8762 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8763 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8764 (Fdelete_other_windows): Remove. Deleting other windows is
8765 handled by window.el.
8766 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8767 handled in window.el.
8768 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8769 Window minimum sizes are handled in window.el.
8770 (shrink_windows, size_window, set_window_height)
8771 (set_window_width, change_window_heights, window_height)
8772 (window_width, CURBEG, CURSIZE, enlarge_window)
8773 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8774 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8775 handled in window.el.
8776 (make_dummy_parent): Rename to make_parent_window and give it a
8777 second argument horflag.
8778 (make_window): Don't set resize_proportionally any more.
8779 (Fsplit_window): Remove. Windows are split in window.el.
8780 (save_restore_action, save_restore_orig_size)
8781 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8782 Resize mini windows in window.el.
8783 (grow_mini_window, shrink_mini_window): Implement by calling
8784 Qresize_root_window_vertically, resize_window_check and
8785 resize_window_apply.
640c8776
SM
8786 (saved_window, Fset_window_configuration, save_window_save):
8787 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8788 resize_proportionally.
8789 (window_min_height, window_min_width): Move to window.el.
8790 (keys_of_window): Move bindings for delete-other-windows,
8791 split-window, delete-window and enlarge-window to window.el.
8792
8793 * buffer.c: Temporarily extern Qdelete_window.
8794 (Fbury_buffer): Temporarily call Qdelete_window instead of
8795 Fdelete_window (Fbury_buffer will move to window.el soon).
8796
8797 * frame.c (set_menu_bar_lines_1): Remove code handling
8798 orig_top_line and orig_total_lines.
8799
8800 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8801 set_window_height but set heights directly.
8802 (change_frame_size_1): Use resize_frame_windows.
8803
8804 * xdisp.c (init_xdisp): Don't use set_window_height but set
8805 heights directly.
8806
640c8776
SM
8807 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8808 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8809 run_window_configuration_change_hook.
8810
8811 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8812 instead of change_window_heights and run
8813 run_window_configuration_change_hook.
8814
1a13852e
MR
88152011-06-09 Martin Rudalics <rudalics@gmx.at>
8816
8817 * window.c (replace_window): Rename second argument REPLACEMENT to
8818 NEW. New third argument SETFLAG. Rewrite.
8819 (delete_window, make_dummy_parent): Call replace_window with
8820 third argument 1.
8821 (window_list_1): Move down in code.
8822 (run_window_configuration_change_hook): Move set_buffer part
8823 before select_frame_norecord part in order to unwind correctly.
8824 Rename count1 to count.
8825 (recombine_windows, delete_deletable_window, resize_root_window)
8826 (Fdelete_other_windows_internal)
8827 (Frun_window_configuration_change_hook, make_parent_window)
8828 (resize_window_check, resize_window_apply, Fresize_window_apply)
8829 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8830 (Fdelete_window_internal, Fresize_mini_window_internal):
8831 New functions.
1a13852e
MR
8832 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8833
f3d1777e
MR
88342011-06-08 Martin Rudalics <rudalics@gmx.at>
8835
496e208e
MR
8836 * window.h (window): Add some new members to window structure -
8837 normal_lines, normal_cols, new_total, new_normal, clone_number,
8838 splits, nest, prev_buffers, next_buffers.
8839 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8840 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8841
f3d1777e
MR
8842 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8843 Remove.
496e208e
MR
8844 (make_dummy_parent): Set new members of windows structure.
8845 (make_window): Move down in code. Handle new members of window
8846 structure.
8847 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8848 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8849 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8850 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8851 (Fset_window_next_buffers, Fset_window_clone_number):
8852 New functions.
496e208e
MR
8853 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8854 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8855 Doc-string fixes.
8856 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8857 Argument WINDOW can be now internal window too.
8858 (Fwindow_use_time): Move up in code.
8859 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8860 Rewrite doc-string.
8861 (Fset_window_configuration, saved_window)
8862 (Fcurrent_window_configuration, save_window_save): Handle new
8863 members of window structure.
b9e809c2
MR
8864 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8865 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8866 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8867 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8868 Qget_mru_window, Qresize_root_window,
8869 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8870 Qauto_buffer_name; staticpro them.
f3d1777e 8871
abde8f8c
MR
88722011-06-07 Martin Rudalics <rudalics@gmx.at>
8873
8874 * window.c (Fwindow_total_size, Fwindow_left_column)
8875 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8876 (Fwindow_list_1): New functions.
8877 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8878 (Fwindow_width, Fscroll_left, Fscroll_right):
8879 Use window_body_cols instead of window_box_text_cols.
8880 (delete_window, Fset_window_configuration):
8881 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8882 (delete_all_subwindows): Take a window as argument and not a
8883 structure. Rewrite.
190b47e6
MR
8884 (window_loop): Remove handling of GET_LRU_WINDOW and
8885 GET_LARGEST_WINDOW.
8886 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8887
8888 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8889 window_box_text_cols. delete_all_subwindows now takes a
8890 Lisp_Object as argument.
abde8f8c 8891
640c8776
SM
8892 * indent.c (compute_motion, Fcompute_motion):
8893 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8894
fa8a67e6
MR
8895 * frame.c (delete_frame): Call delete_all_subwindows with root
8896 window as argument.
8897
a54e3482
DC
88982011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8899
8900 * fns.c (Fputhash): Document return value.
8901
60002bf5
CY
89022011-06-06 Chong Yidong <cyd@stupidchicken.com>
8903
8904 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8905
0c671da6 89062011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8907
b862a52a 8908 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8909
be44ca6c
PE
8910 Check for overflow when converting integer to cons and back.
8911 * charset.c (Fdefine_charset_internal, Fdecode_char):
8912 Use cons_to_unsigned to catch overflow.
8913 (Fencode_char): Use INTEGER_TO_CONS.
8914 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8915 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8916 * data.c (long_to_cons, cons_to_long): Remove.
8917 (cons_to_unsigned, cons_to_signed): New functions.
8918 These signal an error for invalid or out-of-range values.
8919 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8920 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8921 * font.c (Ffont_variation_glyphs):
8922 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8923 * lisp.h: Include <intprops.h>.
8924 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8925 (cons_to_signed, cons_to_unsigned): New decls.
8926 (long_to_cons, cons_to_long): Remove decls.
8927 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8928 (Fprimitive_undo): Use CONS_TO_INTEGER.
8929 * xfns.c (Fx_window_property): Likewise.
8930 * xselect.c: Include <limits.h>.
8931 (x_own_selection, selection_data_to_lisp_data):
8932 Use INTEGER_TO_CONS.
8933 (x_handle_selection_request, x_handle_selection_clear)
8934 (x_get_foreign_selection, Fx_disown_selection_internal)
8935 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8936 (lisp_data_to_selection_data): Use cons_to_unsigned.
8937 (x_fill_property_data): Use cons_to_signed.
8938 Report values out of range.
8939
d1f3d2af
PE
8940 Check for buffer and string overflow more precisely.
8941 * buffer.h (BUF_BYTES_MAX): New macro.
8942 * lisp.h (STRING_BYTES_MAX): New macro.
8943 * alloc.c (Fmake_string):
8944 * character.c (string_escape_byte8):
8945 * coding.c (coding_alloc_by_realloc):
8946 * doprnt.c (doprnt):
8947 * editfns.c (Fformat):
8948 * eval.c (verror):
8949 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8950 since they may not be the same number.
8951 * editfns.c (Finsert_char):
8952 * fileio.c (Finsert_file_contents):
8953 Likewise for BUF_BYTES_MAX.
8954
dd52fcea
PE
8955 * image.c: Use ptrdiff_t, not int, for sizes.
8956 (slurp_file): Switch from int to ptrdiff_t.
8957 All uses changed.
8958 (slurp_file): Check that file size fits in both size_t (for
8959 malloc) and ptrdiff_t (for sanity and safety).
8960
7f9bbdbb
PE
8961 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8962 if b->modtime has its maximal value.
8963
dfe18f82
PE
8964 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8965
84acfcf0
PE
8966 Don't assume time_t can fit into int.
8967 * buffer.h (struct buffer.modtime): Now time_t, not int.
8968 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8969 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8970
ccd9a01a
PE
8971 Minor fixes for signed vs unsigned integers.
8972 * character.h (MAYBE_UNIFY_CHAR):
8973 * charset.c (maybe_unify_char):
8974 * keyboard.c (read_char, reorder_modifiers):
8975 XINT -> XFASTINT, since the integer must be nonnegative.
8976 * ftfont.c (ftfont_spec_pattern):
8977 * keymap.c (access_keymap, silly_event_symbol_error):
8978 XUINT -> XFASTINT, since the integer must be nonnegative.
8979 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8980 since it makes no difference and we prefer signed.
8981 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8982 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8983 nonnegative.
8984
d6d100dd
SM
89852011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8986
8987 * window.h (Fwindow_frame): Declare.
8988
2b6148e4
PE
89892011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8990
8991 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8992 (SPARE_MEMORY): Always define.
8993 (LARGE_REQUEST): Remove.
8994 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8995
f230ecc9
MR
89962011-06-06 Martin Rudalics <rudalics@gmx.at>
8997
727e958e
MR
8998 * lisp.h: Move EXFUNS for Fframe_root_window,
8999 Fframe_first_window and Fset_frame_selected_window to window.h.
9000
9001 * window.h: Move EXFUNS for Fframe_root_window,
9002 Fframe_first_window and Fset_frame_selected_window here from
9003 lisp.h.
9004
9005 * frame.c (Fwindow_frame, Fframe_first_window)
9006 (Fframe_root_window, Fframe_selected_window)
9007 (Fset_frame_selected_window): Move to window.c.
9008 (Factive_minibuffer_window): Move to minibuf.c.
9009 (Fother_visible_frames_p): New function.
9010
9011 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9012
f230ecc9
MR
9013 * window.c (decode_window, decode_any_window): Move up in code.
9014 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9015 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9016 (Fwindow_buffer): Move up and rewrite doc-string.
9017 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9018 (Fwindow_prev): New functions.
727e958e
MR
9019 (Fwindow_frame): Move here from frame.c. Accept any window as
9020 argument.
9021 (Fframe_root_window, Fframe_first_window)
9022 (Fframe_selected_window): Move here from frame.c. Accept frame
9023 or arbitrary window as argument. Update doc-strings.
9024 (Fminibuffer_window): Move up in code.
9025 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9026 (Fset_frame_selected_window): Move here from frame.c.
9027 Marginal rewrite.
727e958e
MR
9028 (Fselected_window, select_window, Fselect_window): Move up in
9029 code. Minor doc-string fixes.
f230ecc9 9030
4d09bcf6
PE
90312011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9032
9033 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9034 Do not assume that spare memory exists; that assumption is valid
9035 only if SYSTEM_MALLOC.
9036 (LARGE_REQUEST): New macro, so that the issue of large requests
9037 is separated from the issue of spare memory.
9038
810928a2
AS
90392011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9040
172418ad
AS
9041 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9042 format. (Bug#8806)
9043
43f862f7
AS
9044 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9045
810928a2
AS
9046 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9047 before statements.
9048
a059fe24
JD
90492011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9050
9051 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9052
9053 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9054
9055 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9056 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9057
989bf368
JB
90582011-06-05 Juanma Barranquero <lekktu@gmail.com>
9059
9060 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9061
4b80f674
CY
90622011-06-04 Chong Yidong <cyd@stupidchicken.com>
9063
9064 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9065 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9066 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9067 New error handlers.
4b80f674
CY
9068 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9069 Obey Vx_select_enable_clipboard_manager. Catch errors in
9070 x_clipboard_manager_save (Bug#8779).
9071 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9072 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9073
99a33b77 90742011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9075
9076 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9077
99a33b77 90782011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9079
9080 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9081 in the current matrix if keep_current_p is non-zero.
9082
8264569d
EZ
90832011-06-04 Eli Zaretskii <eliz@gnu.org>
9084
9085 * bidi.c (bidi_level_of_next_char): Fix last change.
9086
57f97249
EZ
90872011-06-03 Eli Zaretskii <eliz@gnu.org>
9088
fec2107c 9089 Support bidi reordering of text covered by display properties.
57f97249 9090
fec2107c
EZ
9091 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9092 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9093 (bidi_cache_search, bidi_cache_iterator_state)
9094 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9095 (bidi_level_of_next_char, bidi_move_to_visually_next):
9096 Support character positions inside a run of characters covered by a
fec2107c
EZ
9097 display string.
9098 (bidi_paragraph_init, bidi_resolve_explicit_1)
9099 (bidi_level_of_next_char): Call bidi_fetch_char and
9100 bidi_fetch_char_advance instead of FETCH_CHAR and
9101 FETCH_CHAR_ADVANCE.
9102 (bidi_init_it): Initialize new members.
9103 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9104 definitions.
9105 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9106 instead of using explicit *_CHAR codes.
d6d100dd
SM
9107 (bidi_resolve_explicit, bidi_resolve_weak):
9108 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9109 bidirectional text is supported only in multibyte buffers.
9110 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9111 it to initialize the frame_window_p member of struct bidi_it.
9112 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9113 (bidi_resolve_explicit, bidi_resolve_weak)
9114 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9115 bidi_it->nchars is non-positive.
9116 (bidi_level_of_next_char): Don't try to lookup the cache for the
9117 next/previous character if nothing is cached there yet, or if we
9118 were just reseat()'ed to a new position.
c40e2fb2 9119
0e14fe90
EZ
9120 * xdisp.c (set_cursor_from_row): Set start and stop points
9121 according to the row's direction when priming the loop that looks
9122 for the glyph on which to display cursor.
9123 (single_display_spec_intangible_p): Function deleted.
9124 (display_prop_intangible_p): Reimplement to call
9125 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9126 Accept 3 additional arguments needed by handle_display_spec.
9127 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9128 values: lists, `(when COND...)' forms, etc.
9129 (single_display_spec_string_p): Support property values that are
9130 lists with the argument STRING its top-level element.
9131 (display_prop_string_p): Fix the condition for processing a
9132 property that is a list to be consistent with handle_display_spec.
fec2107c 9133 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9134 last portion of handle_display_prop.
9135 (compute_display_string_pos): Accept additional argument
9136 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9137 value of a `display' property is a "replacing spec".
9138 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9139 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9140 the display property, but just return a value indicating whether
9141 the display property will replace the characters it covers.
9142 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9143 frame_window_p members of struct bidi_it.
d6d100dd
SM
9144 (compute_display_string_pos, compute_display_string_end):
9145 New functions.
fec2107c
EZ
9146 (push_it): Accept second argument POSITION, where pop_it should
9147 jump to continue iteration.
9148 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9149
fec2107c
EZ
9150 * keyboard.c (adjust_point_for_property): Adjust the call to
9151 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9152
9153 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9154 (bidi_init_it): Update prototypes.
9155 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9156 (compute_display_string_pos, compute_display_string_end):
9157 Declare prototypes.
fec2107c
EZ
9158 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9159 EMACS_INT.
fc6f18ce 9160
40087514 91612011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9162
57f53182
PE
9163 Malloc failure behavior now depends on size of allocation.
9164 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9165 * lisp.h: Change signatures accordingly.
9166 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9167 All callers changed. (Bug#8762)
9168
9169 * gnutls.c: Use Emacs's memory allocators.
9170 Without this change, the gnutls library would invoke malloc etc.
9171 directly, which causes problems on non-SYNC_INPUT hosts, and which
9172 runs afoul of improving memory_full behavior. (Bug#8761)
9173 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9174 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9175 xfree instead of the default malloc, realloc, free.
9176 (Fgnutls_boot): No need to check for memory allocation failure,
9177 since xmalloc does that for us.
9178
ac32cd99 9179 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9180 * category.c (hash_get_category_set):
9181 * ccl.c (ccl_driver):
9182 * charset.c (Fdefine_charset_internal):
9183 * charset.h (struct charset.hash_index):
9184 * composite.c (get_composition_id, gstring_lookup_cache)
9185 (composition_gstring_put_cache):
9186 * composite.h (struct composition.hash_index):
9187 * dispextern.h (struct image.hash):
9188 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9189 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9190 (hashfn_equal, hashfn_user_defined, make_hash_table)
9191 (maybe_resize_hash_table, hash_lookup, hash_put)
9192 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9193 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9194 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9195 * image.c (make_image, search_image_cache, lookup_image)
9196 (xpm_put_color_table_h):
9197 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9198 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9199 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9200 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9201 * alloc.c (allocate_vectorlike):
9202 Check for overflow in vector size calculations.
9203 * ccl.c (ccl_driver):
9204 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9205 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9206 need to be updated by these changes.
40087514
PE
9207 * fns.c (make_hash_table, maybe_resize_hash_table):
9208 Check for integer overflow with large hash tables.
0de4bb68
PE
9209 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9210 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9211 (SXHASH_REDUCE): New macro.
9212 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9213 Use it instead of discarding useful hash info with large hash values.
9214 (sxhash_float): New function.
9215 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9216 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9217 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9218 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9219 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9220 Adjust signatures to match updated version of code.
9221 (consing_since_gc): Now EMACS_INT, since a single hash table can
9222 use more than INT_MAX bytes.
9223
698d32e2
DN
92242011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9225
9226 Make it possible to build with GCC-4.6+ -O2 -flto.
9227
9228 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9229
fd6fa53f
SM
92302011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9231
9232 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9233 Call minibuffer-inactive-mode.
9234
864db017
JB
92352011-05-31 Juanma Barranquero <lekktu@gmail.com>
9236
9237 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9238 Update dependencies.
9239
2ad0baf4
DN
92402011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9241
9242 * data.c (init_data): Remove code for UTS, this system is not
9243 supported anymore.
9244
4fcc2638
DN
92452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9246
9247 Don't force ./temacs to start in terminal mode.
9248
9249 * frame.c (make_initial_frame): Initialize faces in all cases, not
9250 only when CANNOT_DUMP is defined.
9251 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9252
c56e0fd5
DN
92532011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9254
9255 * dispnew.c (add_window_display_history): Use const for the string
9256 pointer. Remove declaration, not needed.
9257
333d54da 92582011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9259
55d4c1b2 9260 Use 'inline', not 'INLINE'.
333d54da 9261 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9262 * alloc.c, fontset.c (INLINE): Remove.
9263 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9264 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9265 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9266 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9267 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9268
738db178
DN
92692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9270
9271 Make it possible to run ./temacs.
9272
9273 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9274 syms_of_callproc does the same thing. Remove test for
9275 "initialized", do it in the caller.
9276 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9277
620c53a6
SM
92782011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9279
9280 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9281 (read_minibuf): Use get_minibuffer.
9282 (syms_of_minibuf): Use DEFSYM.
9283 (Qmetadata): New var.
9284 * data.c (Qbuffer): Don't make it static.
9285 (syms_of_data): Use DEFSYM.
9286
e003a292
PE
92872011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9288
9289 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9290 (CCL_CODE_MIN): New macro.
9291
ed008a6d
PE
92922011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9293
3687c2ef
PE
9294 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9295
ed008a6d
PE
9296 * eval.c (Qdebug): Now static.
9297 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9298 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9299 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9300
d66c4c7c
CY
93012011-05-29 Chong Yidong <cyd@stupidchicken.com>
9302
9303 * image.c: Various fixes to ImageMagick code comments.
9304 (Fimagemagick_types): Doc fix.
9305
5fbc2025
PE
93062011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9307
0196f88a
PE
9308 Minor fixes prompted by GCC 4.6.0 warnings.
9309
9310 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9311
5fbc2025
PE
9312 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9313 (x_clipboard_manager_save_all): Move extern decl to ...
9314 * xterm.h: ... here, so that it can be checked for consistency.
9315
1dd3c2d9
CY
93162011-05-29 Chong Yidong <cyd@stupidchicken.com>
9317
9318 * xselect.c (x_clipboard_manager_save_frame)
9319 (x_clipboard_manager_save_all): New functions.
9320 (Fx_clipboard_manager_save): Lisp function deleted.
9321
9322 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9323 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9324
9325 * xterm.h: Update prototype.
9326
5ba6571d
WX
93272011-05-28 William Xu <william.xwl@gmail.com>
9328
9329 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9330 exiting (Bug#8239).
9331
3eaff834
JM
93322011-05-28 Jim Meyering <meyering@redhat.com>
9333
e1900994 9334 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9335 * fns.c (to_uchar): Define.
9336 (crypto_hash_function): Use it to convert some newly-signed
9337 variables to unsigned, to avoid sign-extension bugs. For example,
9338 without this change, (md5 "truc") would evaluate to
9339 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9340 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9341 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9342
0f6990a7
PE
93432011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9344
9345 Integer overflow fixes.
c8a9ca5a 9346
08686060
PE
9347 * dbusbind.c: Serial number integer overflow fixes.
9348 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9349 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9350 to hold a serial number that is too large for a fixnum.
9351 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9352 Check for serial numbers out of range. Decode any serial number
59568bf0 9353 that was so large that it became a float. (Bug#8722)
08686060 9354
2d1fc3c7
PE
9355 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9356 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9357 Use XFASTINT rather than XUINT when numbers are nonnegative.
9358 (xd_append_arg, Fdbus_method_return_internal):
9359 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9360 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9361 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9362 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9363 (Bug#8722)
2d1fc3c7 9364
c8a9ca5a
PE
9365 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9366
519e1d69
PE
9367 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9368
6df6ae42 9369 ccl: Add integer overflow checks.
30569699
PE
9370 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9371 (IN_INT_RANGE): New macros.
9372 (ccl_driver): Use them to check for integer overflow when
9373 decoding a CCL program. Many of the new checks are whether XINT (x)
9374 fits in int; it doesn't always, on 64-bit hosts. The new version
9375 doesn't catch all possible integer overflows, but it's an
847044ea 9376 improvement. (Bug#8719)
30569699 9377
c11285dc
PE
9378 * alloc.c (make_event_array): Use XINT, not XUINT.
9379 There's no need for unsigned here.
9380
fdccd48e
PE
9381 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9382 This follows up to the 2011-05-06 change that substituted uintptr_t
9383 for EMACS_INT. This case wasn't caught back then.
9384
37910ab2
PE
9385 Rework Fformat to avoid integer overflow issues.
9386 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9387 now (part of C89). Include <verify.h>.
9388 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9389 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9390 (Fformat): Avoid the prepass trying to compute sizes; it was only
9391 approximate and thus did not catch overflow reliably. Instead, walk
9392 through the format just once, formatting and computing sizes as we go,
9393 checking for integer overflow at every step, and allocating a larger
9394 buffer as needed. Keep track separately whether the format is
9395 multibyte. Keep only the most-recently calculated precision, rather
9396 than them all. Record whether each argument has been converted to
9397 string. Use EMACS_INT, not int, for byte and char and arg counts.
9398 Support field widths and precisions larger than INT_MAX. Avoid
9399 sprintf's undefined behavior with conversion specifications such as %#d
9400 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9401 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9402 formatting out-of-range floating point numbers with int
9173deec 9403 formats. (Bug#8668)
37910ab2 9404
2e6578fb
PE
9405 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9406
0ae6bdee
PE
9407 * data.c: Avoid integer truncation in expressions involving floats.
9408 * data.c: Include <intprops.h>.
9409 (arith_driver): When there's an integer overflow in an expression
9410 involving floating point, convert the integers to floating point
9411 so that the resulting value does not suffer from catastrophic
9412 integer truncation. For example, on a 64-bit host (* 4
9413 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9414 Do not rely on undefined behavior after integer overflow.
9415
de883a70
PE
9416 merge count_size_as_multibyte, parse_str_to_multibyte
9417 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9418 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9419 Check for integer overflow.
9420 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9421 since it's now a duplicate of the other. This is more of
9422 a character than a buffer op, so better that it's in character.c.
9423 * fns.c, print.c: Adjust to above changes.
9424
2ff916cb
PE
94252011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9426
9427 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9428
f1b54466
PE
94292011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9430
fb1ac845
PE
9431 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9432 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9433 (x_clipboard_manager_save): Now static.
9434 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9435
f1b54466
PE
9436 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9437 (crypto_hash_function): Now static.
9438 Fix pointer signedness problems. Avoid unnecessary initializations.
9439
a9f737ee
CY
94402011-05-27 Chong Yidong <cyd@stupidchicken.com>
9441
9442 * termhooks.h (Vselection_alist): Make it terminal-local.
9443
9444 * terminal.c (create_terminal): Initialize it.
9445
9446 * xselect.c: Support for clipboard managers.
9447 (Vselection_alist): Move to termhooks.h as terminal-local var.
9448 (LOCAL_SELECTION): New macro.
9449 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9450 (symbol_to_x_atom): Remove gratuitous arg.
9451 (x_handle_selection_request, lisp_data_to_selection_data)
9452 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9453 (x_own_selection, x_get_local_selection, x_convert_selection):
9454 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9455 (some_frame_on_display): Delete unused function.
9456 (Fx_own_selection_internal, Fx_get_selection_internal)
9457 (Fx_disown_selection_internal, Fx_selection_owner_p)
9458 (Fx_selection_exists_p): New optional frame arg.
9459 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9460 (x_handle_selection_clear): Don't treat other terminals with the
9461 same keyboard specially. Use the terminal-local Vselection_alist.
9462 (x_clear_frame_selections): Use Frun_hook_with_args.
9463
9464 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9465
9466 * xterm.h: Add support for those atoms.
9467
e067f0c1
CY
94682011-05-26 Chong Yidong <cyd@stupidchicken.com>
9469
9470 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9471 (converted_selections, conversion_fail_tag): New global variables.
9472 (x_selection_request_lisp_error): Free the above.
9473 (x_get_local_selection): Remove unnecessary code.
9474 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9475 of converted selections stored in converted_selections.
9476 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9477 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9478 (x_convert_selection): New function.
9479 (x_handle_selection_event): Simplify.
9480 (x_get_foreign_selection): Don't ignore incoming requests while
9481 waiting for an answer; this will fail when we implement
9482 SAVE_TARGETS, and seems unnecessary anyway.
9483 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9484 (Vx_sent_selection_functions): Doc fix.
9485
0f4aebc0
LL
94862011-05-26 Leo Liu <sdl.web@gmail.com>
9487
9488 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9489
e61124cd
YM
94902011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9491
9492 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9493
9494 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9495 for fringe update if it has periodic bitmap.
ac389d0c 9496 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9497 and fringe_bitmap_periodic_p.
9498
9499 * fringe.c (get_fringe_bitmap_data): New function.
9500 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9501 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9502 row. Mark glyph row for fringe update if periodicity changed.
9503
9504 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9505 for fringe update unless it has periodic bitmap.
9506
f16d9837
KH
95072011-05-25 Kenichi Handa <handa@m17n.org>
9508
9509 * xdisp.c (get_next_display_element): Set correct it->face_id for
9510 a static composition.
9511
e1b90ef6
LL
95122011-05-24 Leo Liu <sdl.web@gmail.com>
9513
9514 * deps.mk (fns.o):
9515 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9516
9517 * fns.c (crypto_hash_function, Fsha1): New function.
9518 (Fmd5): Use crypto_hash_function.
9519 (syms_of_fns): Add Ssha1.
9520
7400048f
PE
95212011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9522
9523 * gnutls.c: Remove unused macros.
9524 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9525 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9526 Remove macros that are defined and never used.
9527 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9528
abb71cf4
CY
95292011-05-22 Chong Yidong <cyd@stupidchicken.com>
9530
9531 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9532 (Fx_get_selection_internal): Minor cleanup.
9533 (Fx_own_selection_internal): Rename arguments for consistency with
9534 select.el.
9535
6307db39
PE
95362011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9537
9538 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9539
f3d4e0a4
CY
95402011-05-22 Chong Yidong <cyd@stupidchicken.com>
9541
9542 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9543
4d8ade89
YM
95442011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9545
9546 * dispnew.c (scrolling_window): Don't exclude the case that the
9547 last enabled row in the desired matrix touches the bottom boundary.
9548
32078c8d
GM
95492011-05-21 Glenn Morris <rgm@gnu.org>
9550
9551 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9552 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9553 and add some more files.
32078c8d 9554
7285dc67
EZ
95552011-05-20 Eli Zaretskii <eliz@gnu.org>
9556
9557 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9558 report_file_error introduced by the change from 2011-05-07.
9559
89d1bd22
PE
95602011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9561
9562 * systime.h (Time): Define only if emacs is defined.
9563 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9564 where the include path doesn't have X11/X.h by default. See
9565 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9566
cd394be1 95672011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9568
9569 * composite.c (find_automatic_composition): Fix previous change.
9570
b9704ad9
GM
95712011-05-20 Glenn Morris <rgm@gnu.org>
9572
9573 * lisp.mk: New file, split from Makefile.in.
9574 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9575 (shortlisp): Remove.
9576 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9577
4a720484
GM
95782011-05-19 Glenn Morris <rgm@gnu.org>
9579
9580 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9581 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9582 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9583 (lisp): Set the order to that of loadup.el.
9584 (shortlisp): Make it a copy of $lisp.
9585 (SOME_MACHINE_LISP): Remove.
9586 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9587 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9588
a28d4396
KH
95892011-05-18 Kenichi Handa <handa@m17n.org>
9590
9591 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9592 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9593 (find_automatic_composition): Mostly rewrite for efficiency.
9594
a2b1fa8e
JB
95952011-05-18 Juanma Barranquero <lekktu@gmail.com>
9596
9597 * makefile.w32-in: Update dependencies.
9598
8e1f5610
CS
95992011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9600
9601 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9602 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9603
7025ee00 96042011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9605
cdfa6eab
PE
9606 Fix some integer overflow issues, such as string length overflow.
9607
06d6db33
PE
9608 * insdel.c (count_size_as_multibyte): Check for string overflow.
9609
2b4560a8
PE
9610 * character.c (lisp_string_width): Check for string overflow.
9611 Use EMACS_INT, not int, for string indexes and lengths; in
9612 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9613 the resulting string length overflows an EMACS_INT; instead,
9614 report a string overflow if no precision given. When checking for
9615 precision exhaustion, use a check that cannot possibly have
9616 integer overflow. (Bug#8675)
9617 * character.h (lisp_string_width): Adjust to new signature.
9618
cb93f9be
PE
9619 * alloc.c (string_overflow): New function.
9620 (Fmake_string): Use it. This doesn't change behavior, but saves
9621 a few bytes and will simplify future changes.
9622 * character.c (string_escape_byte8): Likewise.
9623 * lisp.h (string_overflow): New decl.
9624
1a1f3366
PE
9625 Fixups, following up to the user-interface timestamp change.
9626 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9627 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9628 * msdos.c (mouse_get_pos): Likewise.
9629 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9630 * w32gui.h (Time): Define by including "systime.h" rather than by
9631 declaring it ourselves. (Bug#8664)
9632
d4e3e4d3
PE
9633 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9634 * image.c (clear_image_cache): Likewise.
9635
f6a24d19
PE
9636 * term.c (term_mouse_position): Don't assume time_t wraparound.
9637
08dc5ae6
PE
9638 Be more systematic about user-interface timestamps.
9639 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9640 and sometimes 'EMACS_UINT', to represent these timestamps.
9641 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9642 This makes the code easier to follow, and makes it easier to catch
9643 integer overflow bugs such as Bug#8664.
9644 * frame.c (Fmouse_position, Fmouse_pixel_position):
9645 Use Time, not unsigned long, for user-interface timestamps.
9646 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9647 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9648 * keyboard.h (last_event_timestamp): Likewise.
9649 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9650 * menu.h (xmenu_show): Likewise.
9651 * term.c (term_mouse_position): Likewise.
9652 * termhooks.h (struct input_event.timestamp): Likewise.
9653 (struct terminal.mouse_position_hook): Likewise.
9654 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9655 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9656 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9657 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9658 what it was before.
9659 * menu.h, termhooks.h: Include "systime.h", for Time.
9660
8e55734a
PE
9661 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9662 Don't assume that the difference between two unsigned long values
9663 can fit into an integer. At this point, we know button_down_time
9664 <= event->timestamp, so the difference must be nonnegative, so
9665 there's no need to cast the result if double-click-time is
9666 nonnegative, as it should be; check that it's nonnegative, just in
9667 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9668 apart (about 25 days). (Bug#8664)
8e55734a 9669
841f1b75 9670 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9671 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9672
3e26f69c
PE
9673 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9674 that always fit in int. Use a sentinel instead of a counter, to
9675 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9676 * frame.h (struct frame): Use int for menu_bar_items_used
9677 instead of EMACS_INT, since it always fits in int.
3e26f69c 9678
5cc152c0
PE
9679 * menu.c (grow_menu_items): Check for int overflow.
9680
d89eb65e
PE
9681 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9682
5235bd3e
PE
9683 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9684 Before, the code was not consistent. These values cannot exceed
9685 2**31 - 1 so there's no need to make them unsigned.
9686 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9687 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9688 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9689 as modifiers.
9690 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9691
bc827e23
PE
9692 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9693 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9694 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9695 presumably because the widths might not match.
9696
78eb494e
PE
9697 * window.c (size_window): Avoid needless test at loop start.
9698
04f2d78b
CB
96992011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9700
9701 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9702
d2fc7e3d 97032011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9704
9705 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9706
d2fc7e3d 97072011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9708
9709 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9710 `width' to `bar_area_x' and `bar_area_width', respectively.
9711 (x_scroll_run): Take account of fringe background extension.
9712
04f2d78b
CB
9713 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9714 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9715 `bar_area_width', respectively.
9716 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9717 background extension.
9718
79b70037
GM
97192011-05-10 Jim Meyering <meyering@redhat.com>
9720
9721 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9722
2f142cc5
JB
97232011-05-10 Juanma Barranquero <lekktu@gmail.com>
9724
9725 * image.c (Finit_image_library): Return t for built-in image types,
9726 like pbm and xbm. (Bug#8640)
9727
57679c86
AS
97282011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9729
9730 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9731
888c9e86
EZ
97322011-05-07 Eli Zaretskii <eliz@gnu.org>
9733
b0512a1d
EZ
9734 * w32console.c (Fset_screen_color): Doc fix.
9735 (Fget_screen_color): New function.
9736 (syms_of_ntterm): Defsubr it.
9737
7285dc67
EZ
9738 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9739 unlink the temporary file if Fcall_process didn't create it in the
9740 first place.
9741 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9742 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9743 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9744 cue to call_process_cleanup not to close that handle.
9745
4d3fcc8e
BK
97462011-05-07 Ben Key <bkey76@gmail.com>
9747
9748 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9749 one of two shell specific rules, either bootstrap-temacs-CMD or
9750 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9751 to the previous implementation of the bootstrap-temacs rule.
9752 The bootstrap-temacs-CMD rule is similar to the previous
9753 implementation of the bootstrap-temacs rule except that it
9754 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9755 variable.
9756
9757 These changes, along with some changes to nt/configure.bat,
9758 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9759 earlier fix to add support for --cflags and --ldflags options
9760 that include quotes so that it works whether make uses cmd or
9761 sh as the shell.
9762
b4289b64
MA
97632011-05-06 Michael Albinus <michael.albinus@gmx.de>
9764
9765 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9766 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9767 is a constant.
9768 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9769 a string. Handle both cases.
9770 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9771 (Fdbus_register_method): Use Qinvalid_function.
9772
af4c0e28
JB
97732011-05-06 Juanma Barranquero <lekktu@gmail.com>
9774
9775 * makefile.w32-in: Update dependencies.
9776 (LISP_H): Add inttypes.h and stdin.h.
9777 (PROCESS_H): Add unistd.h.
9778
c51453d9
EZ
97792011-05-06 Eli Zaretskii <eliz@gnu.org>
9780
9781 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9782 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9783
8ff0ac3c 97842011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9785
4c4b566b
PE
9786 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9787
aab2b9b5
PE
9788 * term.c (vfatal): Remove stray call to va_end.
9789 It's not needed and the C Standard doesn't allow it here anyway.
9790
c378da0b
PE
9791 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9792 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9793
288b08c7
PE
9794 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9795 bytes.
9796
e3601888
PE
9797 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9798
db6c0e74
PE
9799 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9800
dd5963ea
PE
9801 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9802
88c9450f
PE
9803 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9804
2f9442b8
PE
9805 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9806
c032b5f8
PE
9807 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9808 * charset.c (Fdefine_charset_internal): Don't initialize
9809 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9810 32-bit int (Bug#8600).
a108c10b
PE
9811
9812 * lread.c (read_integer): Be more consistent with string-to-number.
9813 Use string_to_number to do the actual conversion; this avoids
9814 rounding errors and fixes some other screwups. Without this fix,
9815 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9816 (digit_to_number): Move earlier, for benefit of read_integer.
9817 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9818 not a digit in any supported base. (Bug#8602)
a108c10b 9819
ad5f9eea
PE
9820 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9821
aec1708a
PE
9822 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9823 to match comment at start of function. This also removes a
9824 GCC warning about overflow in a 32+64-bit port.
9825
47be4ab5
PE
9826 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9827
371cac43
PE
9828 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9829 Reported by Stefan Monnier in
9830 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9831 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9832 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9833
d01a7826
PE
9834 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9835 (EMACS_UINTPTR): Likewise, with uintptr_t.
9836
7fd47d5c
PE
9837 * lisp.h: Prefer 64-bit EMACS_INT if available.
9838 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9839 on 32-bit hosts that have 64-bit int, so that they can access
9840 large files.
122b0c86
PE
9841 However, temporarily disable this change unless the temporary
9842 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9843
8727937b
PE
9844 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9845
8ac068ac
PE
9846 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9847 This removes an assumption that EMACS_INT and long are the same
9848 width as pointers. The assumption is true for Emacs porting targets
9849 now, but we want to make other targets possible.
9850 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9851 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9852 In the rest of the code, change types of integers that hold casted
9853 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9854 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9855 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9856 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9857 No need to cast type when ORing.
9858 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9859 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9860 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9861 assume EMACS_INT is the same width as char *.
9862 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9863 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9864 Remove no-longer-needed casts.
9865 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9866 (xg_tool_bar_help_callback, xg_make_tool_item):
9867 Use EMACS_INTPTR to hold an integer
9868 that will be cast to void *; this can avoid a GCC warning
9869 if EMACS_INT is not the same width as void *.
9870 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9871 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9872 (current_message_1, set_message_1):
9873 Use a local to convert to proper width without a cast.
9874 * xmenu.c (dialog_selection_callback): Likewise.
9875
ede49d71
PE
9876 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9877 Also, don't assume VALBITS / RAND_BITS is less than 5,
9878 and don't rely on undefined behavior when shifting a 1 left into
9879 the sign bit.
9880 * lisp.h (get_random): Change signature to match.
9881
2f30ecd0
PE
9882 * lread.c (hash_string): Use size_t, not int, for hash computation.
9883 Normally we prefer signed values; but hashing is special, because
9884 it's better to use unsigned division on hash table sizes so that
9885 the remainder is nonnegative. Also, size_t is the natural width
9886 for hashing into memory. The previous code used 'int', which doesn't
9887 retain enough info to hash well into very large tables.
9888 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9889
2a866e7b
PE
9890 * dbusbind.c: Don't possibly lose pointer info when converting.
9891 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9892 Use XPNTR rather than XHASH, so that the high-order bits of
9893 the pointer aren't lost when converting through void *.
9894
51639eac
PE
9895 * eval.c (Fautoload): Don't double-shift a pointer.
9896
92394119
PE
9897 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9898
dbdb9a7c
JB
98992011-05-06 Juanma Barranquero <lekktu@gmail.com>
9900
9901 * gnutls.c (DEF_GNUTLS_FN):
9902 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9903
db7a0b4f
AS
99042011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9905
9906 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9907 marker. (Bug#8610)
9908
cd394be1 99092011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9910
9911 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9912 New version that can reserve upto 2GB of heap space.
9913
f7ff1b0f 99142011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9915
9916 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9917
639c109b
TZ
99182011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9919
9920 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9921 `gnutls_certificate_set_x509_key_file'.
9922
d2127135
JB
99232011-05-05 Juanma Barranquero <lekktu@gmail.com>
9924
9925 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9926 Update dependencies.
9927
e968f4f3
JB
99282011-05-04 Juanma Barranquero <lekktu@gmail.com>
9929
9930 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9931 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9932 Remove unused parameter `fildes'.
9933 * process.c (read_process_output, send_process): Don't pass it.
9934
84d358f0
JB
99352011-05-04 Juanma Barranquero <lekktu@gmail.com>
9936
9937 Fix previous change: the library cache is defined in w32.c.
9938 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9939 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9940
0898ca10
JB
99412011-05-04 Juanma Barranquero <lekktu@gmail.com>
9942
9943 Implement dynamic loading of GnuTLS on Windows.
9944
9945 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9946 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9947 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9948 Declare.
9949
9950 * gnutls.c (Qgnutls_dll): Define.
9951 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9952 (gnutls_*): Declare function pointers.
9953 (init_gnutls_functions): New function to initialize function pointers.
9954 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9955 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9956 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9957 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9958 (emacs_gnutls_write, emacs_gnutls_read)
9959 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9960 (Fgnutls_available_p): New function.
9961 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9962 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9963 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9964
9965 * image.c: Include w32.h.
9966 (Vimage_type_cache): Delete.
9967 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9968 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9969 (w32_delayed_load): Move to w32.c.
9970
9971 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9972
9973 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9974 (w32_delayed_load): Move from image.c. When loading a library, record
9975 its filename in the :loaded-from property of the library id.
9976 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9977 Initialize and staticpro them.
9978 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9979
9980 * process.c: Include lisp.h before w32.h, not after.
9981 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9982 instead of gnutls_record_check_pending.
9983
9984 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9985
ff4de4aa
TZ
99862011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9987
9988 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9989 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9990 as passed in.
9991
abe95abb
JD
99922011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9993
9994 * xterm.c (x_set_frame_alpha): Do not set property on anything
9995 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9996
e16e55d4
JB
99972011-05-02 Juanma Barranquero <lekktu@gmail.com>
9998
9999 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10000
bafcf6a5
JB
100012011-05-02 Juanma Barranquero <lekktu@gmail.com>
10002
10003 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10004 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10005 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10006 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10007 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10008 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10009 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10010 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10011 (Qgnutls_bootprop_callbacks_verify): Make static.
10012
e7a6747f
AS
100132011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10014
19ed11ba
AS
10015 * callproc.c: Indentation fixup.
10016
e7a6747f 10017 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10018 (wait_for_termination, interruptible_wait_for_termination):
10019 Move after wait_for_termination_1.
e7a6747f 10020
1ef14cb4
LMI
100212011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10022
10023 * sysdep.c (interruptible_wait_for_termination): New function
10024 which is like wait_for_termination, but allows keyboard
10025 interruptions.
10026
10027 * callproc.c (Fcall_process): Add (:file "file") as an option for
10028 the STDOUT buffer.
10029 (Fcall_process_region): Ditto.
10030
330d880c
EZ
100312011-04-30 Eli Zaretskii <eliz@gnu.org>
10032
8db90b73
EZ
10033 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10034 rather than `XVECTOR (FOO)->size'.
10035
330d880c
EZ
10036 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10037 inttypes.h, as a gnulib replacement is used if it not available in
10038 system headers.
10039
15cbd324
EZ
100402011-04-21 Eli Zaretskii <eliz@gnu.org>
10041
10042 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10043 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10044 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10045
10046 * coding.c (coding_alloc_by_realloc): Error out if destination
10047 will grow beyond MOST_POSITIVE_FIXNUM.
10048 (decode_coding_emacs_mule): Abort if there isn't enough place in
10049 charbuf for the composition carryover bytes. Reserve an extra
10050 space for up to 2 characters produced in a loop.
10051 (decode_coding_iso_2022): Abort if there isn't enough place in
10052 charbuf for the composition carryover bytes.
10053
100542011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10055
ae940cca
EZ
10056 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10057 aborting when %lld or %lll format is passed.
10058 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10059 %llo or %llx format is passed. (Bug#8545)
10060
03ab8921
EZ
10061 * window.c (window_scroll_line_based): Use a marker instead of
10062 simple variables to record original value of point. (Bug#7952)
10063
afda1437
EZ
10064 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10065 produced by %s or %c overflows available buffer space. (Bug#8545)
10066
f76dee0c
PE
100672011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10068
10069 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10070 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10071
fdc5744d
JB
100722011-04-28 Juanma Barranquero <lekktu@gmail.com>
10073
10074 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10075
638f053a
JB
100762011-04-28 Juanma Barranquero <lekktu@gmail.com>
10077
10078 * keyboard.c (Qdelayed_warnings_hook): Define.
10079 (command_loop_1): Run `delayed-warnings-hook'
10080 if Vdelayed_warnings_list is non-nil.
10081 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10082 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10083
d178f871
EZ
100842011-04-28 Eli Zaretskii <eliz@gnu.org>
10085
10086 * doprnt.c (doprnt): Don't return value smaller than the buffer
10087 size if the message was truncated. (Bug#8545).
10088
b124fd93
JB
100892011-04-28 Juanma Barranquero <lekktu@gmail.com>
10090
10091 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10092 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10093
e810457d
PE
100942011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10095
10096 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10097
ea51cceb
JB
100982011-04-27 Juanma Barranquero <lekktu@gmail.com>
10099
10100 * makefile.w32-in: Update dependencies.
10101
94dcfacf
EZ
101022011-04-27 Eli Zaretskii <eliz@gnu.org>
10103
10104 Improve `doprnt' and its usage. (Bug#8545)
10105 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10106 `format_end'. Remove support for %l as a conversion specifier.
10107 Don't use xrealloc. Improve diagnostics when the %l size modifier
10108 is used. Update the commentary.
10109
10110 * eval.c (verror): Simplify calculation of size_t.
10111
10112 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10113 messages.
10114
f61f41d7
PE
101152011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10116
10117 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10118 change.
10119
96fb4434
PE
101202011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10121
10122 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10123 This makes this file independent of the recent pseudovector change.
10124
671875da 101252011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10126
69e9b5a3
PE
10127 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10128
b5f869a7 10129 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10130 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10131 Remove unused local.
c8926152 10132 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10133
841a1577 10134 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10135 GCC 4.6.0 optimizes based on type-based alias analysis.
10136 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10137 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10138 != &v->size, and therefore "v->size = 1; b->size = 2; return
10139 v->size;" must therefore return 1. This assumption is incorrect
10140 for Emacs, since it type-puns struct Lisp_Vector * with many other
10141 types. To fix this problem, this patch adds a new type struct
f904488f 10142 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10143 and pseudovectors, and helps optimizing compilers not get fooled
10144 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10145 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10146 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10147 the size member.
eab3844f
PE
10148 (XSETPVECTYPE): Rewrite in terms of new macro.
10149 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10150 This is a bit clearer, and further avoids the possibility of
10151 undesirable aliasing.
10152 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10153 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10154 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10155 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10156 (ASIZE): Now uses header.size rather than size.
10157 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10158 to avoid the hassle of writing XVECTOR (foo)->header.size.
10159 (struct vectorlike_header): New type.
eab3844f
PE
10160 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10161 object, to help avoid aliasing.
10162 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10163 (SUBRP): Likewise, since Lisp_Subr is a special case.
10164 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10165 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10166 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10167 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10168 changed to be "header.size" and "header.next".
10169 * buffer.h (struct buffer): Likewise.
10170 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10171 * frame.h (struct frame): Likewise.
10172 * process.h (struct Lisp_Process): Likewise.
10173 * termhooks.h (struct terminal): Likewise.
10174 * window.c (struct save_window_data, struct saved_window): Likewise.
10175 * window.h (struct window): Likewise.
10176 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10177 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10178 * buffer.c (init_buffer_once): Likewise.
10179 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10180 special case.
10181 * process.c (Fformat_network_address): Use local var for size,
10182 for brevity.
10183
0df1eac5
PE
10184 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10185
847ab9d1 10186 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10187 * data.c (atof): Remove decl; no longer used or needed.
10188 (digit_to_number): Move to lread.c.
10189 (Fstring_to_number): Use new string_to_number function, to be
10190 consistent with how the Lisp reader treats infinities and NaNs.
10191 Do not assume that floating-point numbers represent EMACS_INT
10192 without losing information; this is not true on most 64-bit hosts.
10193 Avoid double-rounding errors, by insisting on integers when
10194 parsing non-base-10 numbers, as the documentation specifies.
10195 * lisp.h (string_to_number): New decl, replacing ...
10196 (isfloat_string): Remove.
bc0a5c13 10197 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10198 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10199 appears to have been a coding error. Similarly, do not accept
10200 strings like +-1e0 as floating point numbers. Do not report
10201 overflow for integer overflows unless the base is not 10 which
10202 means we have no simple and reliable way to continue.
10203 Break out the floating-point parsing into a new
10204 function string_to_number, so that Fstring_to_number parses
10205 floating point numbers consistently with the Lisp reader.
04f2d78b 10206 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10207 (E_CHAR, EXP_INT): Remove, replacing with ...
10208 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10209 (string_to_number): New function, replacing isfloat_string.
10210 This function checks for valid syntax and produces the resulting
10211 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10212 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10213 so that overflow for non-base-10 numbers is reported only when
10214 there's no portable and simple way to convert to floating point.
452f4150 10215
67769ffc
PE
10216 * textprop.c (set_text_properties_1): Rewrite for clarity,
10217 and to avoid GCC warning about integer overflow.
10218
c20db43f
PE
10219 * intervals.h (struct interval): Use EMACS_INT for members
10220 where EMACS_UINT might cause problems. See
10221 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10222 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10223 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10224 All uses changed.
37aa2f85
PE
10225 (offset_intervals): Tell GCC not to worry about length overflow
10226 when negating a negative length.
c20db43f 10227
2538aa2f
PE
10228 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10229 (overrun_check_free): Likewise.
10230
f2d3008d
PE
10231 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10232 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10233 word size.
10234
ec8df744
PE
10235 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10236 (gnutls_make_error): Rename local to avoid shadowing.
10237 (gnutls_emacs_global_deinit): ifdef out; not used.
10238 (Fgnutls_boot): Use const for pointer to readonly storage.
10239 Comment out unused local. Fix pointer signedness problems.
10240
640ee02d
PE
10241 * lread.c (openp): Don't stuff size_t into an 'int'.
10242 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10243 about possible signed overflow.
10244
6048fb2a
PE
10245 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10246 (GDK_KEY_g): Don't define if already defined.
10247 (xg_prepare_tooltip): Avoid pointer signedness problem.
10248 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10249
fa3c87e1
PE
10250 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10251 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10252
2172544b
PE
10253 * xfns.c (Fx_window_property): Simplify a bit,
10254 to make a bit faster and to avoid GCC 4.6.0 warning.
10255 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10256
9b821a21
PE
10257 * fns.c (internal_equal): Don't assume size_t fits in int.
10258
3c616cfa
PE
10259 * alloc.c (compact_small_strings): Tighten assertion a little.
10260
c2982e87
PE
10261 Replace pEd with more-general pI, and fix some printf arg casts.
10262 * lisp.h (pI): New macro, generalizing old pEd macro to other
10263 conversion specifiers. For example, use "...%"pI"d..." rather
10264 than "...%"pEd"...".
10265 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10266 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10267 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10268 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10269 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10270 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10271 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10272 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10273 64-bit hosts.
10274 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10275 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10276 * print.c (safe_debug_print, print_object): Likewise.
10277 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10278 to int.
6f04d126
PE
10279 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10280 avoiding the 0 flag, which is not portable.
c2982e87
PE
10281 * process.c (Fmake_network_process): Use pI to avoid cast.
10282 * region-cache.c (pp_cache): Likewise.
10283 * xdisp.c (decode_mode_spec): Likewise.
10284 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10285 behavior on 64-bit hosts with printf arg.
6f04d126 10286 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10287 (x_stop_queuing_selection_requests): Likewise.
10288 (x_get_window_property): Don't truncate byte count to an 'int'
10289 when tracing.
0b432f21 10290
5e073ec7
PE
10291 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10292 here, since it parses constructs like leading '-' and spaces,
10293 which are not wanted; and it overflows with large numbers.
10294 Instead, simply match F[0-9]+, which is what is wanted anyway.
10295
36372bf9
PE
10296 * alloc.c: Remove unportable assumptions about struct layout.
10297 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10298 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10299 (allocate_vectorlike, make_pure_vector): Use the new macros,
10300 plus offsetof, to remove unportable assumptions about struct layout.
10301 These assumptions hold on all porting targets that I know of, but
10302 they are not guaranteed, they're easy to remove, and removing them
10303 makes further changes easier.
10304
0b432f21
PE
10305 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10306 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10307 (string_overrun_cookie): Now const. Use initializers that
10308 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10309 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10310 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10311 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10312 multiple of sizeof (EMACS_INT); it need not be, if
10313 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10314 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10315
895009e1
JB
103162011-04-26 Juanma Barranquero <lekktu@gmail.com>
10317
10318 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10319
6a7a1b0b
TZ
103202011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10321
10322 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10323 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10324 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10325
841a1577 103262011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10327
10328 * lisp.h (Qdebug): List symbol.
895009e1 10329 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10330 * keyboard.c (debug-on-event): New variable.
10331 (handle_user_signal): Break into debugger when debug-on-event
10332 matches the current signal symbol.
10333
f2d3ba6f
DN
103342011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10335
10336 * alloc.c (check_sblock, check_string_bytes)
10337 (check_string_free_list): Convert to standard C.
10338
42ce4c63
TZ
103392011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10340
10341 * w32.c (emacs_gnutls_push): Fix typo.
10342
825cd63c
EZ
103432011-04-25 Eli Zaretskii <eliz@gnu.org>
10344
fb11d64d
EZ
10345 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10346 "cast to pointer from integer of different size".
10347
825cd63c
EZ
10348 Improve doprnt and its use in verror. (Bug#8545)
10349 * doprnt.c (doprnt): Document the set of format control sequences
10350 supported by the function. Use SAFE_ALLOCA instead of always
10351 using `alloca'.
10352
10353 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10354 is one byte too soon. Don't use xrealloc; instead xfree and
10355 xmalloc anew.
10356
e061a11b
TZ
103572011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10358
10359 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10360 callbacks stage.
10361
10362 * gnutls.c: Renamed global_initialized to
10363 gnutls_global_initialized. Added internals for the
10364 :verify-hostname-error, :verify-error, and :verify-flags
10365 parameters of `gnutls-boot' and documented those parameters in the
10366 docstring. Start callback support.
9173deec
JB
10367 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10368 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10369 on error. Return error code.
e061a11b
TZ
10370 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10371 (emacs_gnutls_read): Likewise.
10372 (Fgnutls_boot): Return handshake error code.
10373 (emacs_gnutls_handle_error): New function.
10374 (wsaerror_to_errno): Likewise.
10375
10376 * w32.h (emacs_gnutls_pull): Add prototype.
10377 (emacs_gnutls_push): Likewise.
10378
10379 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10380 (emacs_gnutls_push): Likewise.
10381
103822011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10383
10384 * process.c (wait_reading_process_output): Check if GnuTLS
10385 buffered some data internally if no FDs are set for TLS
10386 connections.
10387
10388 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10389 (LIBS): Link to USER_LIBS.
10390 ($(BLD)/gnutls.$(0)): New target.
10391
fa6996bc
EZ
103922011-04-24 Eli Zaretskii <eliz@gnu.org>
10393
eb35682e
EZ
10394 * xdisp.c (handle_single_display_spec): Rename the
10395 display_replaced_before_p argument into display_replaced_p, to
10396 make it consistent with the commentary. Fix typos in the
10397 commentary.
10398
e2ad650c
EZ
10399 * textprop.c (syms_of_textprop): Remove dead code.
10400 (copy_text_properties): Delete obsolete commentary about an
10401 interface that was deleted long ago. Fix typos in the description
10402 of arguments.
10403
1b2de274
EZ
10404 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10405 to changes in oldXMenu/XMenu.h from 2011-04-16.
10406 <menu_help_message, prev_menu_help_message>: Constify.
10407 (IT_menu_make_room): menu->help_text is now `const char **';
10408 adjust.
10409
10410 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10411 to changes in oldXMenu/XMenu.h from 2011-04-16.
10412 (struct XMenu): Declare `help_text' `const char **'.
10413
10414 * xfaces.c <Qunspecified>: Make extern again.
10415
10416 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10417 required by POSIX.
1b2de274 10418
762b15be
EZ
10419 * doc.c (get_doc_string): Improve the format passed to `error'.
10420
10421 * doprnt.c (doprnt): Improve commentary.
10422
10423 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10424
10425 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10426 them with etags.
10427
f1052e5d
EZ
10428 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10429 changes in globals.h immediately force recompilation.
762b15be
EZ
10430 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10431 $(CURDIR)/s/ms-w32.h.
10432 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10433
fa6996bc
EZ
10434 * character.c (Fchar_direction): Function deleted.
10435 (syms_of_character): Don't defsubr it.
10436 <char-direction-table>: Deleted.
10437
e6c3da20
EZ
104382011-04-23 Eli Zaretskii <eliz@gnu.org>
10439
10440 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10441 * doprnt.c: Include limits.h.
10442 (SIZE_MAX): New macro.
04f2d78b
CB
10443 (doprnt): Return a size_t value. 2nd arg is now size_t.
10444 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10445 Improve overflow protection. Support `l' modifier for integer
10446 conversions. Support %l conversion. Don't assume an EMACS_INT
10447 argument for integer conversions and for %c.
10448
10449 * lisp.h (doprnt): Restore prototype.
10450
10451 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10452 $(SRC)/character.h.
10453
10454 * Makefile.in (base_obj): Add back doprnt.o.
10455
10456 * deps.mk (doprnt.o): Add back prerequisites.
10457 (callint.o): Depend on character.h.
10458
10459 * eval.c (internal_lisp_condition_case): Include the handler
10460 representation in the error message.
10461 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10462 when breaking from the loop.
10463
10464 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10465
10466 * callint.c (Fcall_interactively): When displaying error message
10467 about invalid control letter, pass the character's codepoint, not
10468 a pointer to its multibyte form. Improve display of the character
10469 in octal and display also its hex code.
10470
10471 * character.c (char_string): Use %x to display the (unsigned)
10472 codepoint of an invalid character, to avoid displaying a bogus
10473 negative value.
10474
10475 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10476 `error', not SYMBOL_NAME itself.
10477
10478 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10479 character arguments to `error'.
10480
10481 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10482 to `error' in error message about FINAL_CHAR argument. Make sure
10483 FINAL_CHAR is a character, and use %c when it is passed as
10484 argument to `error'.
10485
4ffd0d6b 104862011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10487
10488 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10489
10490 * w32.c: Include <time.h>.
10491 (sys_localtime): New function.
10492
4ffd0d6b 104932011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10494
10495 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10496
4ffd0d6b 10497 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10498
4ffd0d6b 104992011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10500
4ffd0d6b
GM
10501 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10502 zombies (Bug#8467).
aac0c6e3 10503
04c56954
EZ
105042011-04-19 Eli Zaretskii <eliz@gnu.org>
10505
10506 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10507 gl_state.e_property when gl_state.object is Qt.
10508
10509 * insdel.c (make_gap_larger): Remove limitation of buffer size
10510 to <= INT_MAX.
10511
16a43933
CY
105122011-04-18 Chong Yidong <cyd@stupidchicken.com>
10513
10514 * xdisp.c (lookup_glyphless_char_display)
10515 (produce_glyphless_glyph): Handle cons cell entry in
10516 glyphless-char-display.
10517 (Vglyphless_char_display): Document it.
10518
10519 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10520 glyphless-char-display.
10521
4581706e
CY
105222011-04-17 Chong Yidong <cyd@stupidchicken.com>
10523
10524 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10525
10526 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10527
10528 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10529 definition for no-X builds.
10530
4887c6e2 105312011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10532
fd35b6f9
PE
10533 Static checks with GCC 4.6.0 and non-default toolkits.
10534
5c1ccb01
PE
10535 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10536
006c5daa
PE
10537 * process.c (keyboard_bit_set): Define only if SIGIO.
10538 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10539 (send_process): Repair possible setjmp clobbering.
10540
efc736d3
PE
10541 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10542
4e2fe2e6
PE
10543 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10544
f97334a2
PE
10545 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10546
4e75f29d
PE
10547 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10548 Define only if needed.
10549
90efadd1
PE
10550 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10551 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10552 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10553
3c647824
PE
10554 * dispextern.h (struct redisplay_interface): Rename param
10555 to avoid shadowing.
e264f262 10556 * termhooks.h (struct terminal): Likewise.
761383f4 10557 * xterm.c (xembed_send_message): Likewise.
3c647824 10558
b58c5c4a
PE
10559 * insdel.c (make_gap_smaller): Define only if
10560 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10561
cad59032
PE
10562 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10563 it.
10564
c339dc2e
PE
10565 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10566 so that we aren't warned about unused symbols.
10567
91a3e27b
PE
10568 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10569
399c71d3 10570 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10571
8ffc96f5
PE
10572 * xfns.c (x_real_positions): Mark locals as initialized.
10573
eef9bc79
PE
10574 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10575
098db9dd
PE
10576 * xterm.c: Fix problems found by static analysis with other toolkits.
10577 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10578 (x_dispatch_event): Declare static if USE_GTK, and
10579 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10580 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10581 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10582 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10583 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10584
eb18f6cc
PE
10585 * xmenu.c (menu_help_callback): Pointer type fixes.
10586 Use const pointers when pointing at readonly data. Avoid pointer
10587 signedness clashes.
10588 (FALSE): Remove unused macro.
10589 (update_frame_menubar): Remove unused decl.
10590
1fe72bf8
PE
10591 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10592
60d9e1db
PE
10593 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10594 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10595 (single_menu_item): Rename local to avoid shadowing.
10596
39261c26
PE
10597 * keyboard.c (make_lispy_event): Remove unused local var.
10598
018c5e19
PE
10599 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10600 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10601
63d2b86e
PE
10602 * bitmaps: Change bitmaps from unsigned char back to the X11
10603 compatible char. Avoid the old compiler warnings about
10604 out-of-range initializers by using, for example, '\xab' rather
10605 than 0xab.
10606
aefd87e1
PE
10607 * xgselect.c (xgselect_initialize): Check vs interface
10608 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10609
bf501fb9
PE
10610 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10611
e9829fdf
PE
10612 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10613 to read-only memory.
10614
1086c095
PE
10615 * fns.c (vector): Remove; this old hack is no longer needed.
10616
2baccd04 10617 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10618 Remove unused var.
dde42981 10619 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10620
72391843 10621 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10622
436c16df 10623 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10624 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10625 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10626
92bb796d 10627 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10628 (x_term_init): Remove local to avoid shadowing.
92bb796d 10629
764430a3 10630 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10631
10632 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10633 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10634
d1dfb56c
EZ
106352011-04-16 Eli Zaretskii <eliz@gnu.org>
10636
c4354cb4
EZ
10637 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10638
d1dfb56c
EZ
10639 Fix regex.c, syntax.c and friends for buffers > 2GB.
10640 * syntax.h (struct gl_state_s): Declare character position members
10641 EMACS_INT.
10642
10643 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10644
04f2d78b
CB
10645 * textprop.c (verify_interval_modification, interval_of):
10646 Declare arguments EMACS_INT.
d1dfb56c
EZ
10647
10648 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10649 EMACS_INT.
10650
10651 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10652
10653 * indent.c (Fvertical_motion): Local variable it_start is now
10654 EMACS_INT.
10655
10656 * regex.c (re_match, re_match_2, re_match_2_internal)
10657 (bcmp_translate, regcomp, regexec, print_double_string)
10658 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10659 (re_compile_pattern, re_exec): Declare arguments and local
10660 variables `size_t' and `ssize_t' and return values `regoff_t', as
10661 appropriate.
10662 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10663 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10664 <compile_stack_type>: `size' and `avail' are now `size_t'.
10665
10666 * regex.h <regoff_t>: Use ssize_t, not int.
10667 (re_search, re_search_2, re_match, re_match_2): Arguments that
10668 specify buffer/string position and length are now ssize_t and
10669 size_t. Return type is regoff_t.
10670
613052cd
BK
106712011-04-16 Ben Key <bkey76@gmail.com>
10672
10673 * nsfont.m: Fixed bugs in ns_get_family and
10674 ns_descriptor_to_entity that were caused by using free to
10675 deallocate memory blocks that were allocated by xmalloc (via
10676 xstrdup). This caused Emacs to crash when compiled with
10677 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10678 --enable-checking=xmallocoverrun). xfree is now used to
10679 deallocate these memory blocks.
10680
4170f62f 106812011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10682
71b41406
PE
10683 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10684
9587a89d
PE
10685 emacs_write: Accept and return EMACS_INT for sizes.
10686 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10687 et seq.
10688 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10689 Accept and return EMACS_INT.
10690 (emacs_gnutls_write): Return the number of bytes written on
10691 partial writes.
10692 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10693 (emacs_read, emacs_write): Remove check for negative size, as the
10694 Emacs source code has been audited now.
9587a89d
PE
10695 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10696 (emacs_read, emacs_write): Use it.
273a5f82
PE
10697 * process.c (send_process): Adjust to the new signatures of
10698 emacs_write and emacs_gnutls_write. Do not attempt to store
10699 a byte offset into an 'int'; it might overflow.
9587a89d 10700 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10701
3e047f51
PE
10702 * sound.c: Don't assume sizes fit in 'int'.
10703 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10704 Return EMACS_INT, not int.
3e047f51 10705 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10706 Accept EMACS_INT, not int.
10707 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10708 record read return values.
10709
cc39a9db
BK
107102011-04-15 Ben Key <bkey76@gmail.com>
10711
c9d0ec6d
JB
10712 * keyboard.c (Qundefined): Don't declare static since it is used
10713 in nsfns.m.
10714 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10715 static since they are used in nsfont.m.
cc39a9db 10716
6c60eb9f
SM
107172011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10718
10719 * process.c (Qprocessp): Don't declare static.
10720 * lisp.h (Qprocessp): Declare again.
10721
7990b61a
JB
107222011-04-15 Juanma Barranquero <lekktu@gmail.com>
10723
10724 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10725
5d4cb038
PE
107262011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10727
8bd7b830 10728 Improve C-level modularity by making more things 'static'.
cd64ea1d 10729
e3b27b31
PE
10730 Don't publish debugger-only interfaces to other modules.
10731 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10732 (verify_bytepos, count_markers): Move decls to the only modules
10733 that need them.
10734 * region-cache.h (pp_cache): Likewise.
10735 * window.h (check_all_windows): Likewise.
10736 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10737
5d4cb038
PE
10738 * sysdep.c (croak): Now static, if
10739 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10740 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10741
10742 * alloc.c (refill_memory_reserve): Now static if
10743 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10744 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10745
e87b6180
PE
10746 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10747 Define only if USE_LUCID.
10748
ac64929e
PE
10749 * xrdb.c (x_customization_string, x_rm_string): Now static.
10750
6f37259d
PE
10751 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10752 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10753
1683e3ab
PE
10754 * xdisp.c (draw_row_with_mouse_face): Now static.
10755 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10756
de9c2632
PE
10757 * window.h (check_all_windows): Mark externally visible.
10758
2b96acb7
PE
10759 * window.c (window_deletion_count): Now static.
10760
10761 * undo.c: Make symbols static if they're not exported.
10762 (last_undo_buffer, last_boundary_position, pending_boundary):
10763 Now static.
10764
50436f33
PE
10765 * textprop.c (interval_insert_behind_hooks): Now static.
10766 (interval_insert_in_front_hooks): Likewise.
10767
64520e5c
PE
10768 * term.c: Make symbols static if they're not exported.
10769 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10770 (max_frame_lines, tty_set_terminal_modes):
10771 (tty_reset_terminal_modes, tty_turn_off_highlight):
10772 (get_tty_terminal): Now static.
10773 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10774 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10775 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10776 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10777 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10778
1fa53021
PE
10779 * sysdep.c: Make symbols static if they're not exported.
10780 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10781 Now static.
10782 (sigprocmask_set, full_mask): Remove; unused.
10783 (wait_debugging): Mark as visible.
10784 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10785 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10786
d4b43b22
PE
10787 * syntax.c (syntax_temp): Define only if !__GNUC__.
10788
b7c513d0
PE
10789 * sound.c (current_sound_device, current_sound): Now static.
10790
989b29ad
PE
10791 * search.c (searchbufs, searchbuf_head): Now static.
10792
13a55a78
PE
10793 * scroll.c (scroll_cost): Remove; unused.
10794 * dispextern.h (scroll_cost): Remove decl.
10795
de68a1fc
PE
10796 * region-cache.h (pp_cache): Mark as externally visible.
10797
40ccffa6
PE
10798 * process.c: Make symbols static if they're not exported.
10799 (process_tick, update_tick, create_process, chan_process):
10800 (Vprocess_alist, proc_buffered_char, datagram_access):
10801 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10802 (deactivate_process): Mark defn as static, as well as decl.
10803 * lisp.h (create_process): Remove decl.
10804 * process.h (chan_process, Vprocess_alist): Remove decls.
10805
ad64fc97
PE
10806 * print.c: Make symbols static if they're not exported.
10807 (print_depth, new_backquote_output, being_printed, print_buffer):
10808 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10809 (print_interval, print_number_index, initial_stderr_stream):
10810 Now static.
10811 * lisp.h (Fprinc): Remove decl.
10812 (debug_output_compilation_hack): Mark as externally visible.
10813
adddb265
PE
10814 * sysdep.c (croak): Move decl from here to syssignal.h.
10815 * syssignal.h (croak): Put it here, so the API can be checked when
10816 'croak' is called from dissociate_if_controlling_tty.
10817
1717ede2
PE
10818 * minibuf.c: Make symbols static if they're not exported.
10819 (minibuf_save_list, choose_minibuf_frame): Now static.
10820 * lisp.h (choose_minibuf_frame): Remove decl.
10821
fa5fb2bc
PE
10822 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10823
1e3890d1
PE
10824 * lread.c: Make symbols static if they're not exported.
10825 (read_objects, initial_obarray, oblookup_last_bucket_number):
10826 Now static.
10827 (make_symbol): Remove; unused.
10828 * lisp.h (initial_obarray, make_symbol): Remove decls.
10829
8a1414fa
PE
10830 * keyboard.c: Make symbols static if they're not exported.
10831 (single_kboard, recent_keys_index, total_keys, recent_keys):
10832 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10833 (this_single_command_key_start, echoing, last_auto_save):
10834 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10835 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10836 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10837 (Vlispy_mouse_stem, double_click_count):
10838 Now static.
10839 (force_auto_save_soon): Define only if SIGDANGER.
10840 (ignore_mouse_drag_p): Now static if
10841 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10842 (print_help): Remove; unused.
10843 (stop_character, last_timer_event): Mark as externally visible.
10844 * keyboard.h (ignore_mouse_drag_p): Declare only if
10845 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10846 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10847 * lisp.h (echoing): Remove decl.
10848 (force_auto_save_soon): Declare only if SIGDANGER.
10849 * xdisp.c (redisplay_window): Simplify code, to make it more
10850 obvious that ignore_mouse_drag_p is not accessed if !defined
10851 USE_GTK && !defined HAVE_NS.
10852
93ea6e8f
PE
10853 * intervals.c: Make symbols static if they're not exported.
10854 (merge_properties_sticky, merge_interval_right, delete_interval):
10855 Now static.
10856 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10857
77382fcc
PE
10858 * insdel.c: Make symbols static if they're not exported.
10859 However, leave prepare_to_modify_buffer alone. It's never
10860 called from outside this function, but that appears to be a bug.
10861 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10862 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10863 (adjust_after_replace_noundo): Remove; unused.
10864 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10865 (signal_before_change): Remove decls.
77382fcc 10866
9306c32e
PE
10867 * indent.c (val_compute_motion, val_vmotion): Now static.
10868
cd44d2eb
PE
10869 * image.c: Make symbols static if they're not exported.
10870 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10871 if USE_GTK.
10872 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10873 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10874
ad9a7a06
PE
10875 * fringe.c (standard_bitmaps): Now static.
10876 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10877
81626931
PE
10878 * frame.c: Make symbols static if they're not exported.
10879 (x_report_frame_params, make_terminal_frame): Now static.
10880 (get_frame_param): Now static, unless HAVE_NS.
10881 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10882 (x_get_resource_string): Remove; not used.
10883 * frame.h (make_terminal_frame, x_report_frame_params):
10884 (x_get_resource_string); Remove decls.
10885 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10886 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10887
239f9db9
PE
10888 * font.c, fontset.c: Make symbols static if they're not exported.
10889 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10890 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10891 * font.c (font_close_object): Now static.
10892 * font.h (font_close_object): Remove.
10893 * fontset.c (FONTSET_OBJLIST): Remove.
10894 (free_realized_fontset) #if-0 the body, which does nothing.
10895 (face_suitable_for_char_p): #if-0, as it's never called.
10896 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10897 * xfaces.c (face_at_string_position):
10898 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10899 since 0 is always ASCII.
10900
dfcf3579
PE
10901 * fns.c (weak_hash_tables): Now static.
10902
5045092b
PE
10903 * fileio.c: Make symbols static if they're not exported.
10904 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10905 (Vwrite_region_annotation_buffers): Now static.
10906
57a96f5c
PE
10907 * eval.c: Make symbols static if they're not exported.
10908 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10909 * lisp.h (backtrace_list): Remove decl.
10910
35f08c38
PE
10911 * emacs.c: Make symbols static if they're not exported.
10912 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10913 (fatal_error_code, fatal_error_signal_hook, standard_args):
10914 Now static.
10915 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10916 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10917 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10918 * lisp.h (fatal_error_signal_hook): Remove decl.
10919 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10920
f44bd759
PE
10921 * editfns.c: Move a (normally-unused) function to its only use.
10922 * editfns.c, lisp.h (get_operating_system_release): Remove.
10923 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10924 worth the hassle of breaking this out.
10925
b532497d
PE
10926 * xterm.c: Make symbols static if they're not exported.
10927 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10928 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10929 (x_destroy_window, x_delete_display):
10930 Now static.
10931 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10932 (x_mouse_leave): Remove; unused.
10933 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10934 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10935 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10936 Remove decls.
10937 (x_mouse_leave): Declare only if WINDOWSNT.
10938 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10939 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10940 USE_X_TOOLKIT.
10941
1675728f
PE
10942 * ftxfont.c: Make symbols static if they're not exported.
10943 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10944 HAVE_FREETYPE.
10945 * font.h (ftxfont_driver): Likewise.
10946
e4cebfca
PE
10947 * xfns.c: Make symbols static if they're not exported.
10948 (x_last_font_name, x_display_info_for_name):
10949 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10950 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10951 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10952 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10953 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10954 (last_show_tip_args): Now static.
10955 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10956 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10957 (x_screen_planes): Remove; unused.
10958 * dispextern.h (x_screen_planes): Remove decl.
10959
5bf46f05
PE
10960 * dispnew.c: Make symbols static if they're not exported.
10961 * dispextern.h (redraw_garbaged_frames, scrolling):
10962 (increment_row_positions): Remove.
10963 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10964 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10965 Now static.
10966 (redraw_garbaged_frames): Remove; unused.
10967
435f4c28
PE
10968 * xfaces.c: Make symbols static if they're not exported.
10969 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10970 Remove decls.
10971 * xterm.h (defined_color): Remove decls.
10972 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10973 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10974 (menu_face_changed_default, defined_color, free_realized_face):
10975 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10976 (ascii_face_of_lisp_face): Remove; unused.
10977
8524aef3
PE
10978 * xdisp.c: Make symbols static if they're not exported.
10979 * dispextern.h (scratch_glyph_row, window_box_edges):
10980 (glyph_to_pixel_coords, set_cursor_from_row):
10981 (get_next_display_element, set_iterator_to_next):
10982 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10983 (show_mouse_face): Remove decls
10984 * frame.h (message_buf_print): Likewise.
10985 * lisp.h (pop_message, set_message, check_point_in_composition):
10986 Likewise.
10987 * xterm.h (set_vertical_scroll_bar): Likewise.
10988 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10989 (message_buf_print, scratch_glyph_row, displayed_buffer):
10990 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10991 (get_next_display_element, show_mouse_face, window_box_edges):
10992 (frame_to_window_pixel_xy, check_point_in_composition):
10993 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10994 (glyph_to_pixel_coords): Remove; unused.
10995
16390cd2
PE
10996 * dired.c (file_name_completion): Now static.
10997
10998 * dbusbind.c (xd_in_read_queued_messages): Now static.
10999
a25f4dfa
PE
11000 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11001 * data.c (circular_list_error): Remove.
11002
14a9c8df
PE
11003 * commands.h (last_point_position, last_point_position_buffer):
11004 (last_point_position_window): Remove decls.
11005 * keyboard.c: Make these variables static.
11006
04f2d78b
CB
11007 * coding.h (coding, code_convert_region, encode_coding_gap):
11008 Remove decls.
74ab6df5
PE
11009 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11010 (iso_code_class, detect_coding, code_convert_region): Now static.
11011 (encode_coding_gap): Remove; unused.
11012
38dfbee1
PE
11013 * chartab.c (chartab_chars, chartab_bits): Now static.
11014
a2cb4e63
PE
11015 * charset.h (charset_iso_8859_1): Remove decl.
11016 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11017 Now static.
11018
127198fd
PE
11019 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11020 * ccl.c (Vccl_program_table): Now static.
11021 (check_ccl_update): Remove; unused.
11022
d85b608f
PE
11023 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11024 * category.h: ... from here.
11025 * category.c (check_category_table, set_category_set): Now static.
11026
31cd66f3
PE
11027 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11028 * lisp.h: Remove these decls.
11029
c358e587
PE
11030 * buffer.c (buffer_count): Remove unused var.
11031
e78aecca
PE
11032 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11033 so that it's not optimized away.
11034 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11035 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11036 exported only to the debugger.
11037
e192d7d3 11038 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11039 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11040
92470028
PE
11041 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11042 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11043 was inaccessible from Lisp.
11044 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11045 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11046
244ed907
PE
11047 alloc.c: Import and export fewer symbols, and remove unused items.
11048 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11049 is defined.
11050 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11051 it's not optimized away by whole-program optimization.
11052 (message_enable_multibyte, free_misc): Remove.
11053 (catchlist, handlerlist, mark_backtrace):
11054 Declare only if BYTE_MARK_STACK.
11055 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11056 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11057 (message_enable_multibyte): Remove decl.
11058 (free_misc, interval_free_list, float_block, float_block_index):
11059 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11060 (cons_free_list, last_marked_index):
11061 Now static.
11062 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11063 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11064 (mark_backtrace): Define only if BYTE_MARK_STACK.
11065 * xdisp.c (message_enable_multibyte): Now static.
11066
61c2b50e 11067 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11068 This makes it easier for human readers (and static analyzers)
11069 to see whether these variables are used from other modules.
11070 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11071 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11072 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11073 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11074 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11075 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11076 * xmenu.c, xselect.c:
11077 Declare Q* vars static if they are not used in other modules.
11078 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11079 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11080 Remove decls of unexported vars.
11081 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11082
95c82688
PE
11083 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11084
16a97296
PE
11085 Make Emacs functions such as Fatom 'static' by default.
11086 This makes it easier for human readers (and static analyzers)
11087 to see whether these functions can be called from other modules.
11088 DEFUN now defines a static function. To make the function external
11089 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11090 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11091 (Finit_image_library):
16a97296
PE
11092 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11093 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11094 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11095 Remove decls, since these functions are now static.
11096 (Funintern, Fget_internal_run_time): New decls, since these functions
11097 were already external.
95c82688 11098
16a97296
PE
11099 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11100 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11101 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11102 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11103 * keyboard.c, keymap.c, lread.c:
11104 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11105 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11106 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11107 Mark functions with DEFUE instead of DEFUN,
11108 if they are used in other modules.
11109 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11110 decls for now-static functions.
11111 * buffer.h (Fdelete_overlay): Remove decl.
11112 * callproc.c (Fgetenv_internal): Mark as internal.
11113 * composite.c (Fremove_list_of_text_properties): Remove decl.
11114 (Fcomposition_get_gstring): New forward static decl.
11115 * composite.h (Fcomposite_get_gstring): Remove decl.
11116 * dired.c (Ffile_attributes): New forward static decl.
11117 * doc.c (Fdocumntation_property): New forward static decl.
11118 * eval.c (Ffetch_bytecode): New forward static decl.
11119 (Funintern): Remove extern decl; now in .h file where it belongs.
11120 * fileio.c (Fmake_symbolic_link): New forward static decl.
11121 * image.c (Finit_image_library): New forward static decl.
11122 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11123 * intervals.h (Fprevious_property_change):
11124 (Fremove_list_of_text_properties): Remove decls.
11125 * keyboard.c (Fthis_command_keys): Remove decl.
11126 (Fcommand_execute): New forward static decl.
11127 * keymap.c (Flookup_key): New forward static decl.
11128 (Fcopy_keymap): Now static.
11129 * keymap.h (Flookup_key): Remove decl.
11130 * process.c (Fget_process): New forward static decl.
11131 (Fprocess_datagram_address): Mark as internal.
11132 * syntax.c (Fsyntax_table_p): New forward static decl.
11133 (skip_chars): Remove duplicate decl.
11134 * textprop.c (Fprevious_property_change): New forward static decl.
11135 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11136 Now internal.
11137 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11138 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11139
785bbd42
PE
11140 * editfns.c (Fformat): Remove unreachable code.
11141
8b913b57
AS
111422011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11143
11144 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11145 change. (Bug#8496)
11146
a6744a35
EZ
111472011-04-13 Eli Zaretskii <eliz@gnu.org>
11148
11149 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11150 when at ZV. (Bug#8487)
11151
e7974947
AS
111522011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11153
baad03f0
AS
11154 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11155 (Bug#8437)
11156 * keyboard.c (parse_tool_bar_item): Likewise.
11157 * sound.c (sound_cleanup, alsa_close): Likewise.
11158 * termcap.c (tgetent): Likewise.
11159 * xfns.c (x_default_font_parameter): Likewise.
11160 * xsettings.c (read_and_apply_settings): Likewise.
11161
e7974947
AS
11162 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11163 (overrun_check_free): Protoize.
11164
28272684
PE
111652011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11166
11167 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11168 since callers should never pass a negative size.
11169 Change the signature to match that of plain 'read' and 'write'; see
11170 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11171 * lisp.h: Update prototypes of emacs_write and emacs_read.
11172
11997c76
EZ
111732011-04-11 Eli Zaretskii <eliz@gnu.org>
11174
11175 * xdisp.c (redisplay_window): Don't try to determine the character
11176 position of the scroll margin if the window start point w->startp
e896f03c 11177 is outside the buffer's accessible region. (Bug#8468)
11997c76 11178
8a2cbd72
EZ
111792011-04-10 Eli Zaretskii <eliz@gnu.org>
11180
11181 Fix write-region and its subroutines for buffers > 2GB.
11182 * fileio.c (a_write, e_write): Modify declaration of arguments and
11183 local variables to support buffers larger than 2GB.
11184 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11185
11186 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11187 argument, local variables, and return value.
11188
11189 * lisp.h: Update prototypes of emacs_write and emacs_read.
11190
11191 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11192
4073e537 111932011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11194
1ebfdcb6
PE
11195 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11196
b2ded58d
PE
11197 Fix more problems found by GCC 4.6.0's static checks.
11198
7d66342c
PE
11199 * xdisp.c (vmessage): Use a better test for character truncation.
11200
bbf47d44
PE
11201 * charset.c (load_charset_map): <, not <=, for optimization,
11202 and to avoid potential problems with integer overflow.
9248994d 11203 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11204 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11205 * editfns.c (Fformat): Likewise.
1e69125e 11206 * syntax.c (skip_chars): Likewise.
3befa583 11207
e3019616
PE
11208 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11209 This also lets GCC 4.6.0 generate slightly better loop code.
11210
becfa255
PE
11211 * callint.c (Fcall_interactively): <, not <=, for optimization.
11212 (Fcall_interactively): Count the number of arguments produced,
11213 not the number of arguments given. This is simpler and lets GCC
11214 4.6.0 generate slightly better code.
11215
dae0cd48
PE
11216 * ftfont.c: Distingish more carefully between FcChar8 and char.
11217 The previous code passed unsigned char * to a functions like
11218 strlen and xstrcasecmp that expect char *, which does not
11219 conform to the C standard.
11220 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11221 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11222 char * when the C standard requires it.
11223
76032d70
PE
11224 * keyboard.c (read_char): Remove unused var.
11225
eb3f1cc8
PE
11226 * eval.c: Port to Windows vsnprintf (Bug#8435).
11227 Include <limits.h>.
11228 (SIZE_MAX): Define if the headers do not.
11229 (verror): Do not give up if vsnprintf returns a negative count.
11230 Instead, grow the buffer. This ports to Windows vsnprintf, which
11231 does not conform to C99. Problem reported by Eli Zaretskii.
11232 Also, simplify the allocation scheme, by avoiding the need for
11233 calling realloc, and removing the ALLOCATED variable.
11234
70476b54
PE
11235 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11236
12020a9e
PE
11237 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11238 But keep the doprint source code for now, as we might revamp it
11239 and use it again (Bug#8435).
ea6c7ae6
PE
11240 * lisp.h (doprnt): Remove.
11241 * Makefile.in (base_obj): Remove doprnt.o.
11242 * deps.mk (doprnt.o): Remove.
11243
5fdb398c
PE
11244 error: Print 32- and 64-bit integers portably (Bug#8435).
11245 Without this change, on typical 64-bit hosts error ("...%d...", N)
11246 was used to print both 32- and 64-bit integers N, which relied on
11247 undefined behavior.
61bdb816 11248 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11249 * lisp.h (error, verror): Mark as printf-like functions.
11250 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11251 Report overflow in size calculations when allocating printf buffer.
11252 Do not truncate output string at its first null byte.
11253 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11254 Truncate the output at a character boundary, since vsnprintf does not
11255 do that.
11256 * charset.c (check_iso_charset_parameter): Convert internal
11257 character to string before calling 'error', since %c now has the
11258 printf meaning.
11259 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11260 overflow when computing char to be passed to 'error'. Do not
11261 pass Lisp_Object to 'error'; pass the integer instead.
11262 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11263 formatted with plain %d.
11264
b189fa66
PE
11265 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11266
bff87ef0
PE
11267 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11268
7e2cac20
PE
11269 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11270
ce4d90b5
PE
11271 * xterm.c (x_catch_errors): Remove duplicate declaration.
11272
266c9547
PE
11273 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11274
79c49ad2
PE
11275 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11276
368f4090
JM
112772011-04-10 Jim Meyering <meyering@redhat.com>
11278
11279 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11280 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11281 return ssize_t not "int", and use size_t as the buffer length.
11282 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11283 * gnutls.h: Update declarations.
11284 * process.c (read_process_output): Use ssize_t, to match.
11285 (send_process): Likewise.
11286
a32d4040
CY
112872011-04-09 Chong Yidong <cyd@stupidchicken.com>
11288
11289 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11290
8546720e 112912011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11292
04f2d78b
CB
11293 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11294 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11295
8546720e
GM
11296 * xterm.c (handle_one_xevent):
11297 * xmenu.c (create_and_show_popup_menu):
11298 * xselect.c (x_decline_selection_request)
11299 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11300
0a2f5c1a 113012011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11302
11303 Fix some uses of `int' instead of EMACS_INT.
11304 * search.c (string_match_1, fast_string_match)
11305 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11306 (scan_buffer, find_next_newline_no_quit)
11307 (find_before_next_newline, search_command, Freplace_match)
11308 (Fmatch_data): Make some `int' variables be EMACS_INT.
11309
11310 * xdisp.c (display_count_lines): 3rd argument and return value now
11311 EMACS_INT. All callers changed.
11312 (pint2hrstr): Last argument is now EMACS_INT.
11313
11314 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11315 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11316 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11317 (decode_coding_utf_16, decode_coding_emacs_mule)
11318 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11319 (decode_coding_ccl, decode_coding_charset)
11320 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11321 (decode_coding_iso_2022, decode_coding_emacs_mule)
11322 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11323 <char_offset, last_offset>: Declare EMACS_INT.
11324 (encode_coding_utf_8, encode_coding_utf_16)
11325 (encode_coding_emacs_mule, encode_invocation_designation)
11326 (encode_designation_at_bol, encode_coding_iso_2022)
11327 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11328 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11329 Declare EMACS_INT.
11330 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11331 (encode_invocation_designation): Last argument P_NCHARS is now
11332 EMACS_INT.
11333 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11334 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11335
11336 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11337 All users changed.
11338
11339 * ccl.c (Fccl_execute_on_string): Declare some variables
11340 EMACS_INT.
11341
8546720e 113422011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11343
11344 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11345
4e19a977
CS
113462011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11347
11348 * process.c (Fformat_network_address): Doc fix.
11349
87302331
R
113502011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11351
ee7683eb 11352 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11353
cbb59342
CY
113542011-04-08 Chong Yidong <cyd@stupidchicken.com>
11355
11356 * keyboard.c (read_char): Call Lisp function help-form-show,
11357 instead of using internal_with_output_to_temp_buffer.
11358 (Qhelp_form_show): New var.
e0d38eeb 11359 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11360
11361 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11362
11363 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11364
e67a13ab
CY
113652011-04-06 Chong Yidong <cyd@stupidchicken.com>
11366
04f2d78b
CB
11367 * process.c (Flist_processes): Remove to Lisp.
11368 (list_processes_1): Delete.
e67a13ab 11369
973f782d
EZ
113702011-04-06 Eli Zaretskii <eliz@gnu.org>
11371
7c106b1e
EZ
11372 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11373
973f782d
EZ
11374 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11375
41cf7d1a 113762011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11377
ca23cc88
PE
11378 Fix more problems found by GCC 4.6.0's static checks.
11379
f390e2d5
PE
11380 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11381
42eea0d0
PE
11382 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11383
b69769da 11384 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11385
f9541e84
PE
11386 * xdisp.c (vmessage): Mark as a printf-like function.
11387
13841b55
PE
11388 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11389
c136c10f
PE
11390 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11391
5e2d4a30
PE
11392 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11393 printf-like functions.
11394 (tiff_load): Add casts to remove these marks before passing them
11395 to system-supplied API.
11396
583f48b9
PE
11397 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11398
b25d760e
PE
11399 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11400 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11401 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11402 directly, rather than having caller test rule sign. This avoids
11403 some unnecessary tests.
11404 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11405 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11406 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11407
bc7b6697 11408 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11409 (xfont_open): Avoid unnecessary tests.
bc7b6697 11410
27ccc379
PE
11411 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11412
dcd5c89a
PE
11413 * composite.h, composite.c (composition_gstring_put_cache):
11414 Use EMACS_INT, not int, for length.
11415
b13a45c6
PE
11416 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11417 breaking out part of COMPOSITION_DECODE_RULE.
11418 (COMPOSITION_DECODE_RULE): Use it.
11419 * composite.c (get_composition_id): Remove unused local vars,
11420 by using the new macro.
11421
1e792e4d
PE
11422 * textprop.c (set_text_properties_1): Change while to do-while,
11423 since the condition is always true at first.
11424
dc6c6455 11425 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11426 (interval_deletion_adjustment): Return unsigned value.
11427 All uses changed.
dc6c6455 11428
aba7731a
PE
11429 * process.c (list_processes_1, create_pty, read_process_output):
11430 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11431 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11432 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11433 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11434 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11435
fdfc4bf3
PE
11436 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11437
fca8fe46 11438 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11439 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11440
06a0259a 11441 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11442 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11443 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11444
e7b9e80f
PE
11445 * print.c (print_error_message): Avoid int overflow.
11446
56201685
PE
11447 * font.c (font_list_entities): Redo for clarity,
11448 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11449
78834453 11450 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11451 (font_score): Avoid potential overflow in diff calculation.
78834453 11452
0bc0b309 11453 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11454 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11455
e610eaca
PE
11456 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11457
b895abce
PE
11458 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11459 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11460 can always succeed if overflow has undefined behavior.
11461
1f1d9321 11462 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11463 (wordify): Omit three unnecessary tests.
1f1d9321 11464
c59478bc
PE
11465 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11466 All callers changed. This avoids the need for an unused var.
11467
79b73827
PE
11468 * casefiddle.c (casify_region): Remove var that is set but not used.
11469
a4db5dfe
PE
11470 * dired.c (file_name_completion): Remove var that is set but not used.
11471
43aae36e
PE
11472 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11473
2a47c44d 11474 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11475 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11476
a37c69bf
PE
11477 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11478 Check for integer overflow on size calculations.
11479
328ab8e7
PE
11480 * buffer.c (Fprevious_overlay_change): Remove var that is set
11481 but not used.
11482
e5a2a5cb
PE
11483 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11484 Remove vars that are set but not used.
8d84a6eb 11485 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11486 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11487
a60e5f68
PE
11488 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11489
f661cb61 11490 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11491 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11492
f0397f5a
PE
11493 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11494 that are set but not used.
11495
8664db06 11496 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11497 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11498
6abdaa4a
PE
11499 * xselect.c (x_get_local_selection, x_handle_property_notify):
11500 Remove vars that are set but not used.
11501
0ce7538d 11502 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11503 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11504
9ae848fc
PE
11505 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11506 Remove var that is set but not used.
0b918413
PE
11507 (scroll_bar_windows_size): Now size_t, not int.
11508 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11509 Check for overflow.
9ae848fc 11510
a5a62657
PE
11511 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11512 (map_tty_color) [!defined MSDOS]: Likewise.
11513
5c5cdd39
PE
11514 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11515
66ebf983
PE
11516 * coding.c: Remove vars that are set but not used.
11517 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11518 All callers changed.
11519 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11520 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11521 (decode_coding_charset): Remove vars that are set but not used.
11522
1be4d761
PE
11523 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11524 that is set but not used.
11525
47553fa8
PE
11526 * print.c (print_object): Remove var that is set but not used.
11527
1f7196bf 11528 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11529 The gnulib version avoids calling malloc in the usual case,
11530 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11531 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11532 * filelock.c (current_lock_owner): Likewise.
11533 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11534 * sysdep.c: Include allocator.h, careadlinkat.h.
11535 (emacs_no_realloc_allocator): New static constant.
11536 (emacs_readlink): New function.
fdb61804
PE
11537 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11538 ../lib/careadlinkat.h.
d1fdcab7 11539
f84c17c7
SM
115402011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11541
11542 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11543 first non-nil return value).
11544
ef3862ad
JD
115452011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11546
11547 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11548 if not defined (Bug#8403).
11549
376a7006
JB
115502011-04-02 Juanma Barranquero <lekktu@gmail.com>
11551
11552 * xdisp.c (display_count_lines): Remove parameter `start',
11553 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11554 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11555 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11556 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11557 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11558 and thereabouts. All callers changed.
11559 (get_per_char_metric): Remove parameter `f', unused since
11560 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11561
6ca3801d
JM
115622011-04-02 Jim Meyering <meyering@redhat.com>
11563
11564 do not dereference NULL upon failed strdup
11565 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11566 (ns_get_family): Likewise.
11567
d8e2b5ba
JB
115682011-04-02 Juanma Barranquero <lekktu@gmail.com>
11569
11570 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11571
8c74fcbd
JD
115722011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11573
11574 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11575 later (Bug#8403).
11576
7200d79c
SM
115772011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11578
03408648 11579 Add lexical binding.
7200d79c 11580
03408648
SM
11581 * window.c (Ftemp_output_buffer_show): New fun.
11582 (Fsave_window_excursion):
11583 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11584
11585 * lread.c (lisp_file_lexically_bound_p): New function.
11586 (Fload): Bind Qlexical_binding.
11587 (readevalloop): Remove `evalfun' arg.
11588 Bind Qinternal_interpreter_environment.
11589 (Feval_buffer): Bind Qlexical_binding.
11590 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11591 Mark as dynamic.
11592 (syms_of_lread): Declare `lexical-binding'.
11593
11594 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11595
11596 * keyboard.c (eval_dyn): New fun.
11597 (menu_item_eval_property): Use it.
ca105506
SM
11598
11599 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11600
03408648
SM
11601 * fns.c (concat, mapcar1): Accept byte-code-functions.
11602
11603 * eval.c (Fsetq): Handle lexical vars.
11604 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11605 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11606 (FletX, Flet): Obey lexical binding.
11607 (Fcommandp): Handle closures.
11608 (Feval): New `lexical' arg.
11609 (eval_sub): New function extracted from Feval. Use it almost
11610 everywhere where Feval was used. Look up vars in lexical env.
11611 Handle closures.
11612 (Ffunctionp): Move from subr.el.
11613 (Ffuncall): Handle closures.
11614 (apply_lambda): Remove `eval_flags'.
11615 (funcall_lambda): Handle closures and new byte-code-functions.
11616 (Fspecial_variable_p): New function.
11617 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11618 but without exporting it to Lisp.
23aba0ea 11619
23aba0ea 11620 * doc.c (Fdocumentation, store_function_docstring):
03408648 11621 * data.c (Finteractive_form): Handle closures.
23aba0ea 11622
03408648
SM
11623 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11624 interactive spec.
ba83908c 11625
04f2d78b
CB
11626 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11627 New byte-codes.
03408648
SM
11628 (exec_byte_code): New function extracted from Fbyte_code to handle new
11629 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11630
03408648 11631 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11632
03408648 11633 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11634
e2abce01
JB
116352011-03-31 Juanma Barranquero <lekktu@gmail.com>
11636
11637 * xdisp.c (redisplay_internal): Fix prototype.
11638
63696a73 116392011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11640
63696a73 11641 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11642 (try_scrolling): Use it when setting scroll_limit.
11643 Limit scrolling to 100 screen lines.
63696a73
EZ
11644 (redisplay_window): Even when falling back on "recentering",
11645 position point in the window according to scroll-conservatively,
11646 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11647
11648 (try_scrolling): When point is above the window, allow searching
11649 as far as scroll_max, or one screenful, to compute vertical
11650 distance from PT to the scroll margin position. This prevents
11651 try_scrolling from unnecessarily failing when
11652 scroll-conservatively is set to a value slightly larger than the
11653 window height. Clean up the case of PT below the margin at bottom
11654 of window: scroll_max can no longer be INT_MAX. When aggressive
11655 scrolling is in use, don't let point enter the opposite scroll
11656 margin as result of the scroll.
11657 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11658 threshold of 100 lines for never-recentering scrolling.
11659
e4cc2dfc
JB
116602011-03-31 Juanma Barranquero <lekktu@gmail.com>
11661
11662 * dispextern.h (move_it_by_lines):
11663 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11664 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11665 (message_log_check_duplicate): Remove parameters `prev_bol' and
11666 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11667 (redisplay_internal): Remove parameter `preserve_echo_area',
11668 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11669
11670 * indent.c (Fvertical_motion):
11671 * window.c (window_scroll_pixel_based, Frecenter):
11672 Don't pass `need_y_p' to `move_it_by_lines'.
11673
1c470562
SM
116742011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11675
44f230aa
SM
11676 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11677 steal a few bits to be more compact.
11678 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11679 Remove unneeded casts.
11680
1c470562
SM
11681 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11682
888adce9
ZK
116832011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11684
11685 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11686 binding" message (bug#7967).
11687
f838ed7b
PE
116882011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11689
77861b95
PE
11690 Fix more problems found by GCC 4.6.0's static checks.
11691
de6dbc14
PE
11692 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11693 Remove unused local var.
11694
f838ed7b
PE
11695 * editfns.c (Fmessage_box): Remove unused local var.
11696
792c7b2b
PE
11697 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11698 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11699 Omit unused local vars.
c499e557 11700 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11701 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11702 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11703 Omit unused local var.
11704
ba0165e1
PE
11705 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11706 Don't assume string length fits in int.
32ad8845 11707 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11708 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11709
3c59b4c9
PE
11710 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11711 instead of alloca (Bug#8344).
11712
a3eed478 11713 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11714 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11715
eb4d412d
PE
11716 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11717
1658b401
PE
11718 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11719 concerns.
11720
11721 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11722
11723 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11724
9a2c6e05
PE
11725 * keyboard.c (syms_of_keyboard): Use the same style as later
11726 in this function when indexing through an array. This also
11727 works around GCC bug 48267.
11728
03d0a109
PE
11729 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11730
44f730c8
PE
11731 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11732
fe75f926
PE
11733 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11734 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11735
ffa8c828
PE
11736 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11737 This avoids undefined behavior on integer overflow, and is a bit
11738 more convenient anyway since it is compared to a size_t variable.
11739
c5101a77
PE
11740 Variadic C functions now count arguments with size_t, not int.
11741 This avoids an unnecessary limitation on 64-bit machines, which
11742 caused (substring ...) to crash on large vectors (Bug#8344).
11743 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11744 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11745 All variadic functions and their callers changed accordingly.
c5101a77
PE
11746 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11747 * data.c (arith_driver, float_arith_driver): Likewise.
11748 * editfns.c (general_insert_function): Likewise.
11749 * eval.c (struct backtrace.nargs, interactive_p)
11750 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11751 (funcall_lambda, mark_backtrace): Likewise.
11752 * fns.c (concat): Likewise.
11753 * frame.c (x_set_frame_parameters): Likewise.
11754 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11755 0 if not found, not -1. All callers changed.
11756
dd3f25f7
PE
11757 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11758 (stack_copy_size): Now size_t, not int.
11759 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11760
461c2ab9
JB
117612011-03-28 Juanma Barranquero <lekktu@gmail.com>
11762
11763 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11764 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11765 All callers changed.
11766
11767 * lisp.h (multibyte_char_to_unibyte):
11768 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11769 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11770 * character.h (CHAR_TO_BYTE8):
11771 * cmds.c (internal_self_insert):
11772 * editfns.c (general_insert_function):
11773 * keymap.c (push_key_description):
11774 * search.c (Freplace_match):
11775 * xdisp.c (message_dolog, set_message_1): All callers changed.
11776
f6d62986
SM
117772011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11778
11779 * keyboard.c (safe_run_hook_funcall): New function.
11780 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11781 don't set the hook to nil, but remove the offending function instead.
11782 (Qcommand_hook_internal): Remove, unused.
11783 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11784 Vcommand_hook_internal.
11785
11786 * eval.c (enum run_hooks_condition): Remove.
11787 (funcall_nil, funcall_not): New functions.
11788 (run_hook_with_args): Call each function through a `funcall' argument.
11789 Remove `cond' argument, now redundant.
11790 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11791 (Frun_hook_with_args_until_failure): Adjust accordingly.
11792 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11793
1db5b1ad
JB
117942011-03-28 Juanma Barranquero <lekktu@gmail.com>
11795
11796 * dispextern.h (string_buffer_position): Remove declaration.
11797
11798 * print.c (strout): Remove parameter `multibyte', unused since
11799 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11800
11801 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11802 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11803 All callers changed.
11804
11805 * w32.c (_wsa_errlist): Use braces for struct initializers.
11806
11807 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11808 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11809 All callers changed.
11810 (string_buffer_position): Likewise. Also, make static (it's never
11811 used outside xdisp.c).
11812 (cursor_row_p): Remove parameter `w', unused since
11813 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11814 (decode_mode_spec): Remove parameter `precision', introduced during
11815 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11816 All callers changed.
11817
5ffb62aa
JD
118182011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11819
11820 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11821
461c2ab9 118222011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11823
11824 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11825 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11826 (ns_update_auto_hide_menu_bar): New functions.
11827 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11828 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11829 ns_constrain_all_frames.
11830 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11831 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11832
5c380ffb
JD
118332011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11834
11835 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11836
9af30bdf
GM
118372011-03-27 Glenn Morris <rgm@gnu.org>
11838
11839 * syssignal.h: Replace RETSIGTYPE with void.
11840 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11841 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11842 Replace SIGTYPE with void everywhere.
11843 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11844 * s/template.h (SIGTYPE): Remove commented out definition.
11845
e2abce01
JB
118462011-03-26 Eli Zaretskii <eliz@gnu.org>
11847
11848 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11849 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11850
f868cd8a
JB
118512011-03-26 Juanma Barranquero <lekktu@gmail.com>
11852
59eb0929
JB
11853 * w32.c (read_unc_volume): Use parameter `henum', instead of
11854 global variable `wget_enum_handle'.
11855
11856 * keymap.c (describe_vector): Remove parameters `indices' and
11857 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11858 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11859
f868cd8a
JB
11860 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11861
11862 * keyboard.c (timer_check): Remove parameter `do_it_now',
11863 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11864 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11865 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11866
11867 * keyboard.c (read_char):
11868 * w32menu.c (w32_menu_display_help):
11869 * xmenu.c (show_help_event, menu_help_callback):
11870 Adjust calls to `show_help_echo'.
11871
11872 * gtkutil.c (xg_maybe_add_timer):
11873 * keyboard.c (readable_events):
11874 * process.c (wait_reading_process_output):
11875 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11876
11877 * insdel.c (adjust_markers_gap_motion):
11878 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11879 (gap_left, gap_right): Don't call it.
11880
2ecf6fdb
CY
118812011-03-25 Chong Yidong <cyd@stupidchicken.com>
11882
11883 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11884 incurred during fontification.
11885
6b1f9ba4
JB
118862011-03-25 Juanma Barranquero <lekktu@gmail.com>
11887
11888 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11889 (DEFVAR_PER_BUFFER): Don't pass it.
11890
11891 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11892 (scrolling_window): Don't pass it.
11893
0f4a96b5
JB
118942011-03-25 Juanma Barranquero <lekktu@gmail.com>
11895
11896 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11897
11898 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11899 and `suffix'.
11900 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11901 of variables specific to SELinux and computation of `encoded_absname'.
11902
11903 * image.c (XPutPixel): Remove unused variable `height'.
11904
11905 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11906
11907 * unexw32.c (get_section_info): Remove unused variable `section'.
11908
11909 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11910 (system_process_attributes): Remove unused variable `sess'.
11911 (sys_read): Remove unused variable `err'.
11912
11913 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11914 (w32_wnd_proc): Remove unused variable `isdead'.
11915 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11916 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11917 (x_create_tip_frame): Remove unused variable `tem'.
11918
11919 * w32inevt.c (w32_console_read_socket):
11920 Remove unused variable `no_events'.
11921
11922 * w32term.c (x_draw_composite_glyph_string_foreground):
11923 Remove unused variable `width'.
11924
1149507c
JB
119252011-03-24 Juanma Barranquero <lekktu@gmail.com>
11926
11927 * w32term.c (x_set_glyph_string_clipping):
11928 Don't pass uninitialized region to CombineRgn.
11929
9c88f339
JB
119302011-03-23 Juanma Barranquero <lekktu@gmail.com>
11931
11932 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11933 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11934 (Fx_close_connection): Remove unused variable `i'.
11935
11936 * w32font.c (w32font_draw): Return number of glyphs.
11937 (w32font_open_internal): Remove unused variable `i'.
11938 (w32font_driver): Add missing initializer.
11939
11940 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11941 (fill_in_menu): Remove unused variable `items_added'.
11942
11943 * w32term.c (last_mouse_press_frame): Remove static global variable.
11944 (w32_clip_to_row): Remove unused variable `f'.
11945 (x_delete_terminal): Remove unused variable `i'.
11946
11947 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11948 (NOTHING): Remove unused static global variable.
11949 (uniscribe_check_otf): Remove unused variable `table'.
11950 (uniscribe_font_driver): Add missing initializers.
11951
dee091a3
JD
119522011-03-23 Julien Danjou <julien@danjou.info>
11953
11954 * term.c (Fsuspend_tty, Fresume_tty):
11955 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11956 * window.c (temp_output_buffer_show):
11957 * insdel.c (signal_before_change):
11958 * frame.c (Fhandle_switch_frame):
11959 * fileio.c (Fdo_auto_save):
11960 * emacs.c (Fkill_emacs):
11961 * editfns.c (save_excursion_restore):
11962 * cmds.c (internal_self_insert):
11963 * callint.c (Fcall_interactively):
11964 * buffer.c (Fkill_all_local_variables):
11965 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11966 Use Frun_hooks.
0f4a96b5 11967 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11968 unconditionally since it does the check itself.
dee091a3 11969
2c520ab5 119702011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11971
c9c49752
PE
11972 Fix more problems found by GCC 4.5.2's static checks.
11973
8abc3f12
PE
11974 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11975 the first time through the loop, since we know p0 < p1 then.
11976 This also avoids a gcc -Wstrict-overflow warning.
11977
a2d26660
PE
11978 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11979 leading to a memory leak, possible in functions like
11980 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11981 of objects (Bug#8318).
a2d26660 11982
916c72e9
PE
11983 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11984 that could (at least in theory) be that large.
11985
19ab8a18
PE
11986 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11987 This is less likely to overflow, and avoids undefined behavior if
11988 overflow does occur. All callers changed. Use strtoul to scan
11989 for the unsigned long integer.
b7cbbd6f
PE
11990 (pint2hrstr): Simplify and tune code slightly.
11991 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11992
f0641eff
PE
11993 * scroll.c (do_scrolling): Work around GCC bug 48228.
11994 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11995
7f650bb9
PE
11996 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11997 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11998 (validate_x_resource_name): Simplify count usage.
11999 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12000
37dd57d1
PE
12001 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12002 fail (Bug#8306).
81e56e61 12003
699979fc 12004 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12005
401bf9b4
PE
12006 * process.c (Fmake_network_process): Use socklen_t, not int,
12007 where POSIX says socklen_t is required in portable programs.
12008 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12009 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12010 (Fmake_network_process, server_accept_connection):
12011 (wait_reading_process_output, read_process_output):
12012 Likewise.
12013
b93aacde
PE
12014 * process.c: Rename or move locals to avoid shadowing.
12015 (list_processes_1, Fmake_network_process):
12016 (read_process_output_error_handler, exec_sentinel_error_handler):
12017 Rename or move locals.
4dc343ee 12018 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12019 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12020 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12021 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12022 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12023
af8a867c 12024 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12025 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12026 Include tparam.h instead, since it declares them.
af8a867c
PE
12027 * cm.h (PC): Remove extern decl; tparam.h now does this.
12028 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12029 * terminfo.c: Include tparam.h, to check interfaces.
12030 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12031 (tparam): Adjust signature to match interface in tparam.h;
12032 this removes some undefined behavior. Check that outstring and len
12033 are zero, which they always are with Emacs.
12034 * tparam.h (PC, BC, UP): New extern decls.
12035
0248044d 12036 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12037 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12038
8ff096c1 12039 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12040 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12041 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12042 (ftfont_list): Remove unused local.
49eaafba
PE
12043 (get_adstyle_property, ftfont_pattern_entity):
12044 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12045 Rename locals to avoid shadowing.
8ff096c1 12046
e2be39f6
PE
12047 * xfont.c (xfont_list_family): Mark var as initialized.
12048
c9735e30
PE
12049 * xml.c (make_dom): Now static.
12050
8f5201ae
PE
12051 * composite.c (composition_compute_stop_pos): Rename local to
12052 avoid shadowing.
b246f932
PE
12053 (composition_reseat_it): Remove unused locals.
12054 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12055 (composition_update_it): Mark var as initialized.
11b61122
PE
12056 (find_automatic_composition): Mark vars as initialized,
12057 with a FIXME (Bug#8290).
8f5201ae 12058
760fbc2c
PE
12059 character.h: Rename locals to avoid shadowing.
12060 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12061 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12062 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12063 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12064 to avoid shadowing.
12065
ff08eb85
PE
12066 * textprop.c (property_change_between_p): Remove; unused.
12067
fc7bf025
PE
12068 * intervals.c (interval_start_pos): Now static.
12069
235d7abc
PE
12070 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12071
44f230aa
SM
12072 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12073 Rename locals to avoid shadowing.
3e7d6594 12074
50060332
PE
12075 * sound.c (wav_play, au_play, Fplay_sound_internal):
12076 Fix pointer signedness.
d01f234b 12077 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12078 (wav_play): Initialize a variable to 0, to prevent undefined
12079 behavior (Bug#8278).
50060332 12080
c4fc4e30
PE
12081 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12082
918436ed
PE
12083 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12084
c939f91b
PE
12085 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12086 clobbering (Bug#8298).
b9c7f648
PE
12087 * sysdep.c (sys_subshell): Likewise.
12088 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12089
6bd8c144
PE
12090 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12091 This should get cleaned up, so that child_setup has the
12092 same signature on all platforms.
12093
7710357c 12094 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12095 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12096
c59da222
CY
120972011-03-22 Chong Yidong <cyd@stupidchicken.com>
12098
12099 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12100 not to be necessary, and produces flickering.
12101
66b87493
GM
121022011-03-20 Glenn Morris <rgm@gnu.org>
12103
12104 * config.in: Remove file.
12105
45b6f6d5
JB
121062011-03-20 Juanma Barranquero <lekktu@gmail.com>
12107
12108 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12109 are now in src/globals.h.
12110 (syms_of_minibuf): Remove spurious & from previous change.
12111
cd394be1 121122011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12113
12114 * minibuf.c (completing-read-function): New variable.
12115 (completing-read-default): Rename from completing-read.
12116 (completing-read): Call completing-read-function.
12117
b14e3e21
CY
121182011-03-19 Juanma Barranquero <lekktu@gmail.com>
12119
12120 * xfaces.c (Fx_load_color_file):
12121 Read color file from absolute filename (bug#8250).
12122
f2b726e6
JB
121232011-03-19 Juanma Barranquero <lekktu@gmail.com>
12124
12125 * makefile.w32-in: Update dependencies.
12126
09f6ff02
EZ
121272011-03-17 Eli Zaretskii <eliz@gnu.org>
12128
12129 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12130
29a6015a
PE
121312011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12132
a3a6c54e
PE
12133 Fix more problems found by GCC 4.5.2's static checks.
12134
b766f867
PE
12135 * process.c (make_serial_process_unwind, send_process_trap):
12136 (sigchld_handler): Now static.
12137
be02381c
PE
12138 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12139 That way, the code declares only the vars that it needs.
12140 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12141 * s/cygwin.h (PTY_ITERATION): Likewise.
12142 * s/darwin.h (PTY_ITERATION): Likewise.
12143 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12144
57048744
PE
12145 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12146 * process.c (allocate_pty): Don't declare stb unless it's needed.
12147
7914961c 12148 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12149 (CONSTANTLIM): Remove; unused.
12150 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12151 Define only if needed.
7914961c 12152
b3967b18
PE
12153 * unexelf.c (unexec): Name an expression,
12154 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12155 Use a different way to cause a compilation error if anyone uses
12156 n rather than nn, a way that does not involve shadowing.
73366a00 12157 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12158
29a6015a
PE
12159 * deps.mk (unexalpha.o): Remove; unused.
12160
43cfc33e 12161 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12162 * unexec.h: New file.
ce701a33
PE
12163 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12164 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12165 Depend on unexec.h.
12166 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12167 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12168 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12169 Change as necessary to match prototype in unexec.h.
ce701a33 12170
01f44d5a
PE
12171 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12172 shadowing.
4f63c6bb 12173 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12174
a6670b0b
PE
12175 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12176 Rename locals to avoid shadowing.
12177
cef2010d 12178 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12179 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12180
d4d7173a
PE
12181 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12182
f08b802a
PE
12183 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12184 warning when compiling print.c.
12185
3ddb0639
PE
12186 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12187 instead of using an uninitialized var.
5ad03b97 12188 (font_sort_entities): Mark var as initialized.
3ddb0639 12189
170a2692
PE
12190 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12191
e663c700
PE
12192 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12193 pointers to constants.
89bc529a 12194 (font_parse_fcname): Remove unused vars.
7b81e2d0 12195 (font_delete_unmatched): Now static.
ea838e10 12196 (font_get_spec): Remove; unused.
13a547c6
PE
12197 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12198 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12199 Rename or move locals to avoid shadowing.
e663c700 12200
2a80c887 12201 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12202 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12203
1384fa33 12204 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12205 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12206
8b2c52e9
PE
12207 * alloc.c (mark_backtrace): Move decl from here ...
12208 * lisp.h: ... to here, so that it can be checked.
12209
475545b5 12210 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12211 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12212 (lisp_indirect_variable): Name an expression,
12213 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12214 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12215
b1349114 12216 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12217 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12218 Use const pointer when appropriate.
b1349114 12219
a2928364
PE
12220 * lisp.h (get_system_name, get_operating_system_release):
12221 Move decls here, to check interfaces.
12222 * process.c (get_operating_system_release): Move decl to lisp.h.
12223 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12224 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12225 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12226 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12227 (Fformat_time_string, Fencode_time, Finsert_char):
12228 (Ftranslate_region_internal, Fformat):
12229 Rename or remove local vars to avoid shadowing.
9710023e 12230 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12231
a415e694
PE
12232 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12233 avoid shadowing.
12234
8ef4622d
PE
12235 * lisp.h (eassert): Check that the argument compiles, even if
12236 ENABLE_CHECKING is not defined.
12237
946f9a5b
PE
12238 * data.c (Findirect_variable): Name an expression, to avoid
12239 gcc -Wbad-function-cast warning.
112396d6 12240 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12241 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12242 (Fmake_variable_buffer_local, Fmake_local_variable):
12243 Mark variables as initialized.
52746918 12244 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12245
e5aab7e7 12246 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12247 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12248 Rename locals to avoid shadowing.
dff45157
PE
12249 (mark_stack): Move local variables into the #ifdef region where
12250 they're used.
7bc26fdb
PE
12251 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12252 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12253 needed otherwise.
12254 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12255 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12256 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12257
e5aab7e7
PE
12258 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12259 avoids undefined behavior in theory.
12260
4da60324
PE
12261 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12262
88043301
PE
12263 Use functions, not macros, for up- and down-casing (Bug#8254).
12264 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12265 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12266 to use the following functions instead of these macros.
12267 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12268 EMACS_INT, since callers assume the returned value fits in int.
12269 (upcase1): Likewise, for UPCASE_TABLE.
12270 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12271 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12272 the race-condition problem in the old DOWNCASE.
88043301 12273
19ed5445
PE
12274 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12275 Rename locals to avoid shadowing.
12276 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12277 (regex_compile, re_search_2, re_match_2_internal):
12278 Remove unused local vars.
952db0d7
PE
12279 (FREE_VAR): Rewrite so as not to use empty "else",
12280 which gcc can warn about.
da053e48 12281 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12282 (RETALLOC_IF): Define only if needed.
12283 (WORDCHAR_P): Likewise. This one is never needed, but is used
12284 only in a comment talking about a compiler bug, so put inside
12285 the #if 0 of that comment.
12286 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12287 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12288 Remove; unused.
19ed5445 12289
1f3561e4 12290 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12291 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12292 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12293
ded6f8f7
PE
12294 * search.c (simple_search): Remove unused var.
12295
dbd37a95
PE
12296 * dired.c (compile_pattern): Move decl from here ...
12297 * lisp.h: ... to here, so that it can be checked.
12298 (struct re_registers): New forward decl.
12299
7e47afad
PE
12300 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12301
85f24f61
PE
12302 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12303 All uses changed.
12304 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12305 Rename locals to avoid shadowing.
5671df8f 12306 (Fvertical_motion): Mark locals as initialized.
85f24f61 12307
181aa2be 12308 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12309 (casify_region): Mark local as initialized.
181aa2be 12310
930d429c
PE
12311 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12312
7082eac6
PE
12313 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12314 New macros, so that the caller can use some names other than
12315 gcpro1, gcpro2, etc.
12316 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12317 of the new macros.
12318 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12319 argument, for consistency with GCPRO2_VAR, etc: it is now the
12320 prefix of the variable, not the variable itself. All uses
12321 changed.
38b2c076
PE
12322 * dired.c (directory_files_internal, file_name_completion):
12323 Rename locals to avoid shadowing.
12324
15206ed9
PE
12325 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12326 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12327 dired.c's scmp function, had undefined behavior.
12328 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12329 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12330 * buffer.h: ... to here, because these macros use current_buffer,
12331 and the new implementation with inline functions needs to have
12332 current_buffer in scope now, rather than later when the macros
12333 are used.
12334 (downcase, upcase1): New static inline functions.
12335 (DOWNCASE, UPCASE1): Reimplement using these functions.
12336 This avoids undefined behavior in expressions like
12337 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12338 from race conditions in accessing the global variables
12339 case_temp1 and case_temp2.
12340 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12341 * lisp.h (case_temp1, case_temp2): Remove their decls.
12342 * character.h (ASCII_CHAR_P): Move from here ...
12343 * lisp.h: ... to here, so that the inline functions mentioned
12344 above can use them.
12345
4a6bea26
PE
12346 * dired.c (directory_files_internal_unwind): Now static.
12347
f14b7e14
PE
12348 * fileio.c (file_name_as_directory, directory_file_name):
12349 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12350 Now static.
2893f146
PE
12351 (file_name_as_directory): Use const pointers when appropriate.
12352 (Fexpand_file_name): Likewise. In particular, newdir might
12353 point at constant storage, so make it a const pointer.
fd4ead52 12354 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12355 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12356 signedness issues.
f839df0c
PE
12357 (Fset_file_times, Finsert_file_contents, auto_save_error):
12358 Rename locals to avoid shadowing.
f14b7e14 12359
5716756e 12360 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12361 (Ftry_completion, Fall_completions): Rename or remove locals
12362 to avoid shadowing.
5716756e 12363
b4c3046a
PE
12364 * marker.c (bytepos_to_charpos): Remove; unused.
12365
b45db522
PE
12366 * lisp.h (verify_bytepos, count_markers): New decls,
12367 so that gcc does not warn that these functions aren't declared.
12368
85876d07
PE
12369 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12370 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12371 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12372 (copy_text): Remove unused local var.
85876d07 12373
03d78a21 12374 * filelock.c (within_one_second): Now static.
b3dd38ab 12375 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12376
5df8f01b
PE
12377 * buffer.c (fix_overlays_before): Mark locals as initialized.
12378 (fix_start_end_in_overlays): Likewise. This function should be
12379 simplified by using pointers-to-pointers, but that's a different
12380 matter.
b1d876f1 12381 (switch_to_buffer_1): Now static.
8f54f30a
PE
12382 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12383 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12384
a70072c9 12385 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12386 Fix pointer signedness issue.
edced198
PE
12387 (sys_subshell): Mark local as volatile if checking for lint,
12388 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12389 (MAXPATHLEN): Define only if needed.
a70072c9 12390
a0977c44
PE
12391 * process.c (serial_open, serial_configure): Move decls from here ...
12392 * systty.h: ... to here, so that they can be checked.
12393
a884fdcc
PE
12394 * fns.c (get_random, seed_random): Move extern decls from here ...
12395 * lisp.h: ... to here, so that they can be checked.
12396
604efe86 12397 * sysdep.c (reset_io): Now static.
b8950c94 12398 (wait_for_termination_signal): Remove; unused.
604efe86 12399
38fc62d9
PE
12400 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12401 (copy_keymap_item, append_key, push_text_char_description):
12402 Now static.
1004a21a 12403 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12404 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12405 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12406 (describe_map_tree):
12407 Rename locals to avoid shadowing.
38fc62d9 12408
2f2650da
PE
12409 * keyboard.c: Declare functions static if they are not used elsewhere.
12410 (echo_char, echo_dash, cmd_error, top_level_2):
12411 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12412 (read_char, kbd_buffer_get_event, make_lispy_position):
12413 (make_lispy_event, make_lispy_movement, apply_modifiers):
12414 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12415 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12416 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12417 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12418 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12419
a053e86c 12420 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12421 (mark_kboards): Move decl here ...
12422 * alloc.c (mark_kboards): ... from here.
a053e86c 12423
4752793e
PE
12424 * lisp.h (force_auto_save_soon): New decl.
12425
74f10ca7 12426 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12427 (DEFINE_DUMMY_FUNCTION): New macro.
12428 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12429 Use it.
c03cd23f
PE
12430 (main): Add casts to avoid warnings
12431 if GCC considers string literals to be constants.
74f10ca7 12432
022e70d4
PE
12433 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12434
59d6fe83
PE
12435 * dbusbind.c: Pointer signedness fixes.
12436 (xd_signature, xd_append_arg, xd_initialize):
12437 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12438 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12439 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12440 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12441
78320123
PE
12442 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12443 if GCC considers string literals to be constants.
49cebcca 12444 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12445
35ac2a97
SM
124462011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12447
fb103ca9
SM
12448 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12449 (print_preprocess, print_object): New macro to fix last change.
12450
35ac2a97
SM
12451 * print.c (print_preprocess): Don't forget font objects.
12452
62973b41
JB
124532011-03-16 Juanma Barranquero <lekktu@gmail.com>
12454
12455 * emacs.c (USAGE3): Doc fixes.
12456
0e48bb22
AS
124572011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12458
12459 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12460 structure.
12461
7684e57b
JB
124622011-03-14 Juanma Barranquero <lekktu@gmail.com>
12463
12464 * lisp.h (VWindow_system, Qfile_name_history):
12465 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12466 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12467 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12468
12469 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12470 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12471
12472 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12473 * w32console.c (detect_input_pending, read_input_pending)
12474 (encode_terminal_code):
12475 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12476 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12477 (w32_system_caret_y, Qfile_name_history):
12478 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12479 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12480 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12481 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12482 * w32proc.c (Qlocal, report_file_error):
12483 * w32term.c (Vwindow_system, updating_frame):
12484 * w32uniscribe.c (initialized, uniscribe_font_driver):
12485 Remove unneeded extern declarations.
12486
2aa46d6c
CY
124872011-03-14 Chong Yidong <cyd@stupidchicken.com>
12488
c96bbc66 12489 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12490
cffc6f3b
CY
124912011-03-13 Chong Yidong <cyd@stupidchicken.com>
12492
12493 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12494 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12495 These macros can no longer be used for assignment.
12496
44f230aa
SM
12497 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12498 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12499 (record_buffer_markers, fetch_buffer_markers): New functions for
12500 recording and fetching special buffer markers.
12501 (set_buffer_internal_1, set_buffer_temp): Use them.
12502
12503 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12504
12505 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12506
12507 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12508 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12509
12510 * xdisp.c (hscroll_window_tree):
12511 (reconsider_clip_changes): Use PT instead of BUF_PT.
12512
d251f04b
EZ
125132011-03-13 Eli Zaretskii <eliz@gnu.org>
12514
12515 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12516 $(EMACS_ROOT)/lib/intprops.h.
12517
f0c77cd1
PE
125182011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12519
3eca4629
PE
12520 Fix more problems found by GCC 4.5.2's static checks.
12521
7c86ee98
PE
12522 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12523 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12524 (xg_free_frame_widgets): Make it clear that a local variable is
12525 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12526 (gdk_window_get_screen): Make it clear that this macro is needed
12527 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12528 (int_gtk_range_get_value): New function, which avoids a diagnostic
12529 from gcc -Wbad-function-cast.
12530 (xg_set_toolkit_scroll_bar_thumb): Use it.
12531 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12532 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12533 (get_utf8_string, xg_get_file_with_chooser):
12534 Rename locals to avoid shadowing.
12535 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12536
41729b81
PE
12537 * xgselect.c (xg_select): Remove unused var.
12538
f0c77cd1
PE
12539 * image.c (four_corners_best): Mark locals as initialized.
12540 (gif_load): Initialize transparent_p to zero (Bug#8238).
12541 Mark another local as initialized.
ec6cf4c6 12542 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12543
ce0ad53d 12544 * image.c (clear_image_cache): Now static.
d5d5a617 12545 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12546 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12547 (x_edge_detection): Remove unnecessary cast that
12548 gcc -Wbad-function-cast diagnoses.
2037898d 12549 (gif_load): Fix pointer signedness.
6ae141d6
PE
12550 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12551 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12552
33383987 125532011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12554
d32df629
PE
12555 Improve quality of tests for time stamp overflow.
12556 For example, without this patch (encode-time 0 0 0 1 1
12557 1152921504606846976) returns the obviously-bogus value (-948597
12558 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12559 reports time overflow. See
12560 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12561 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12562 * editfns.c: Include limits.h and intprops.h.
12563 (TIME_T_MIN, TIME_T_MAX): New macros.
12564 (time_overflow): Move earlier, to before first use.
12565 (hi_time, lo_time): New functions, for an accurate test for
12566 out-of-range times.
12567 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12568 (Fget_internal_run_time): Don't assume time_t fits in int.
12569 (make_time): Use list2 instead of Fcons twice.
12570 (Fdecode_time): More accurate test for out-of-range times.
12571 (check_tm_member): New function.
12572 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12573 (lisp_time_argument): Don't rely on undefined left-shift and
12574 right-shift behavior when checking for time stamp overflow.
8be6f318 12575
fe31d94c
PE
12576 * editfns.c (time_overflow): New function, refactoring common code.
12577 (Fformat_time_string, Fdecode_time, Fencode_time):
12578 (Fcurrent_time_string): Use it.
12579
8be6f318
PE
12580 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12581 * dired.c (make_time): Move to ...
12582 * editfns.c (make_time): ... here.
12583 * systime.h: Note the move.
12584
09d9db2c 125852011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12586
126bc0dc
YM
12587 * fringe.c (update_window_fringes): Remove unused variables.
12588
c47cbdfd
YM
12589 * unexmacosx.c (copy_data_segment): Also copy __got section.
12590 (Bug#8223)
12591
7ac80be9
EZ
125922011-03-12 Eli Zaretskii <eliz@gnu.org>
12593
c96bbc66 12594 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12595 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12596 Constify `char *' arguments and their references according to
12597 prototypes in tparam.h.
12598
ecb0f94d 12599 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12600
7ac80be9
EZ
12601 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12602 Adapt all references accordingly.
12603
12604 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12605
ef1fd07e
TT
126062011-03-11 Tom Tromey <tromey@redhat.com>
12607
12608 * buffer.c (syms_of_buffer): Remove obsolete comment.
12609
7ef4b50c
EZ
126102011-03-11 Eli Zaretskii <eliz@gnu.org>
12611
12612 * termhooks.h (encode_terminal_code): Declare prototype.
12613
12614 * msdos.c (encode_terminal_code): Don't declare prototype.
12615
12616 * term.c (encode_terminal_code): Now external again, used by
12617 w32console.c and msdos.c.
12618
44f230aa
SM
12619 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12620 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12621
4b1ec863 126222011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12623
1714f52b 12624 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12625
4b1ec863
PE
12626 * fringe.c (update_window_fringes): Mark locals as initialized
12627 (Bug#8227).
12628 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12629
524c7aa6
PE
12630 * alloc.c (mark_fringe_data): Move decl from here ...
12631 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12632 to check its interface.
12633 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12634
a5c0af81 12635 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12636 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12637 (fontset_font): Mark local as initialized.
a9a06e0b 12638 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12639
b4716021
PE
12640 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12641
811e9bac 12642 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12643 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12644 (x_own_selection, Fx_disown_selection_internal): Rename locals
12645 to avoid shadowing.
12646 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12647
7e3ab302
PE
12648 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12649 so that the caller can use some name other than gcpro1.
12650 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12651 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12652 (Fx_backspace_delete_keys_p):
12653 Use them to avoid shadowing, and rename vars to avoid shadowing.
12654 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12655 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12656 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12657 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12658 Remove unused locals.
7e3ab302
PE
12659 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12660 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12661 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12662 macros.
f78faa98 12663
e2b13473
PE
12664 * xterm.h (x_mouse_leave): New decl.
12665
77f23912
PE
12666 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12667 Remove unused functions.
cdf4ba58
PE
12668 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12669 (x_calc_absolute_position): Now static.
7411c686 12670 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12671 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12672 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12673 unless they are used.
38d0b34a
PE
12674 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12675 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12676 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12677 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12678 (x_error_catcher, x_connection_closed, x_error_handler):
12679 (x_error_quitter, xembed_send_message, x_iconify_frame):
12680 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12681 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12682 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12683
44f230aa
SM
12684 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12685 Rename or move locals to avoid shadowing.
6b463e58 12686 (tty_defined_color, merge_face_heights): Now static.
5967d051 12687 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12688 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12689 does not deduce is never used uninitialized.
73719eba
PE
12690 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12691 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12692
426994c3 12693 * terminal.c (store_terminal_param): Now static.
5489860b 12694
032f1620 12695 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12696 (set_frame_menubar): Remove unused local.
d4323972 12697 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12698 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12699 since they might point to immutable storage.
281585b0
PE
12700 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12701 since it's unused otherwise.
032f1620 12702
367c19e5 12703 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12704 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12705 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12706 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12707 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12708 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12709 does not deduce are never used uninitialized.
70739cbe 12710
07b48fa9
PE
12711 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12712
8868a238 12713 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12714 * window.c (window_loop, size_window):
12715 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12716
7e5cf297 12717 * window.c (display_buffer): Now static.
d6550a9f
PE
12718 (size_window): Mark variables that gcc -Wuninitialized
12719 does not deduce are never used uninitialized.
a586633d
PE
12720 * window.h (check_all_windows): New decl, to forestall
12721 gcc -Wmissing-prototypes diagnostic.
5b555da1 12722 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12723
f6095868
PE
12724 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12725 shadowing.
12726 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12727 Include <limits.h>.
12728 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12729 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12730 (load_charset_map): Mark variables that gcc -Wuninitialized
12731 does not deduce are never used uninitialized.
53df7c11 12732 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12733
f38b440c
PE
12734 * coding.c (coding_set_source, coding_set_destination):
12735 Use "else { /* comment */ }" rather than "else /* comment */;"
12736 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12737 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12738 a block, when the outer 'i' will do.
12739 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12740 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12741 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12742 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12743 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12744 Rename locals to avoid shadowing.
12745 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12746 * coding.c (emacs_mule_char, encode_invocation_designation):
12747 Now static, since they're not used elsewhere.
413bb2db 12748 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12749 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12750 (decode_coding_emacs_mule): Mark variables that gcc
12751 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12752 (detect_coding_iso_2022): Initialize a local variable that might
12753 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12754 this initialization is needed. (Bug#8211)
5f58e762
PE
12755 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12756 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12757 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12758 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12759 Remove unused macros.
f38b440c 12760
232b38b9 12761 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12762 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12763 * character.c (string_count_byte8): Likewise.
232b38b9 12764
fb90da1b
PE
12765 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12766 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12767
fb93dbc2
PE
12768 * chartab.c (copy_sub_char_table): Now static, since it's not used
12769 elsewhere.
5c156ace
PE
12770 (sub_char_table_ref_and_range, char_table_ref_and_range):
12771 Rename locals to avoid shadowing.
bbcd0949 12772 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12773
7d3b3862 12774 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12775 (BIDI_BOB): Remove unused macro.
7d3b3862 12776
6be7d3da
PE
12777 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12778 deduce are never used uninitialized.
c2ed9c8b 12779 * term.c (encode_terminal_code): Likewise.
6be7d3da 12780
75f8807f 12781 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12782
50938595
PE
12783 * tparam.h: New file.
12784 * term.c, tparam.h: Include it.
12785 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12786 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12787 Move these decls to tparam.h, and make them agree with what
12788 is actually in tparam.c. The previous trick of using incompatible
12789 decls in different modules does not conform to the C standard.
12790 All callers of tparam changed to use tparam's actual API.
12791 * tparam.c (tparam1, tparam, tgoto):
12792 Use const pointers where appropriate.
12793
fbceeba2
PE
12794 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12795 * cm.h (struct cm): Likewise.
12796 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12797 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12798 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12799 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12800 (turn_on_face, init_tty): Likewise.
12801 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12802
7f3f1250
PE
12803 * term.c (term_mouse_position): Rename local to avoid shadowing.
12804
e6ca6543
PE
12805 * alloc.c (mark_ttys): Move decl from here ...
12806 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12807
c40f8d15
AS
128082011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12809
12810 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12811
cfe0661d
JB
128122011-03-09 Juanma Barranquero <lekktu@gmail.com>
12813
12814 * search.c (compile_pattern_1): Remove argument regp, unused since
12815 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12816 (compile_pattern): Don't pass it.
12817
0afb4571
J
128182011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12819
12820 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12821 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12822 for ! HAVE_GTK3.
12823 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12824
12825 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12826
12827 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12828 gdk_window_get_screen, gdk_window_get_geometry,
12829 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12830 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12831 (xg_get_pixbuf_from_pixmap): New function.
12832 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12833 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12834 Call xg_get_pixbuf_from_pixmap instead of
12835 gdk_pixbuf_get_from_drawable.
12836 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12837 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12838 (xg_check_special_colors): Use GtkStyleContext and its functions
12839 for HAVE_GTK3.
12840 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12841 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12842 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12843 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12844 Call gtk_widget_get_preferred_size.
0afb4571
J
12845 (xg_frame_resized): gdk_window_get_geometry only takes 5
12846 parameters.
44f230aa
SM
12847 (xg_win_to_widget, xg_event_is_for_menubar):
12848 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12849 (xg_set_widget_bg): New function.
12850 (delete_cb): New function.
895009e1 12851 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12852 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12853 (xg_set_background_color): Call xg_set_widget_bg.
12854 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12855 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12856 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12857 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12858 if ! HAVE_GTK3.
12859 (update_frame_tool_bar): Call gtk_widget_hide.
12860 (xg_initialize): Use GDK_KEY_g.
12861
12862 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12863 if ! HAVE_GTK3
12864 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12865
12866 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12867 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12868 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12869
1c2cc4ef
JB
128702011-03-08 Juanma Barranquero <lekktu@gmail.com>
12871
12872 * w32xfns.c (select_palette): Check success of RealizePalette against
12873 GDI_ERROR, not zero.
12874
33383987 12875See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12876
12877;; Local Variables:
12878;; coding: utf-8
aac0c6e3
MR
12879;; End:
12880
2f097256 12881 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12882
12883 This file is part of GNU Emacs.
12884
12885 GNU Emacs is free software: you can redistribute it and/or modify
12886 it under the terms of the GNU General Public License as published by
12887 the Free Software Foundation, either version 3 of the License, or
12888 (at your option) any later version.
12889
12890 GNU Emacs is distributed in the hope that it will be useful,
12891 but WITHOUT ANY WARRANTY; without even the implied warranty of
12892 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12893 GNU General Public License for more details.
12894
12895 You should have received a copy of the GNU General Public License
12896 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.