Make first mode-line dash an empty space on graphical terminals (Bug#7295).
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5ba6571d
WX
12011-05-28 William Xu <william.xwl@gmail.com>
2
3 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4 exiting (Bug#8239).
5
3eaff834
JM
62011-05-28 Jim Meyering <meyering@redhat.com>
7
e1900994 8 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9 * fns.c (to_uchar): Define.
10 (crypto_hash_function): Use it to convert some newly-signed
11 variables to unsigned, to avoid sign-extension bugs. For example,
12 without this change, (md5 "truc") would evaluate to
13 45723a2aff78ff4fff7fff1114760e62 rather than the expected
14 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 15 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 16
0f6990a7
PE
172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
18
19 Integer overflow fixes.
c8a9ca5a 20
08686060
PE
21 * dbusbind.c: Serial number integer overflow fixes.
22 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
23 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
24 to hold a serial number that is too large for a fixnum.
25 (Fdbus_method_return_internal, Fdbus_method_error_internal):
26 Check for serial numbers out of range. Decode any serial number
59568bf0 27 that was so large that it became a float. (Bug#8722)
08686060 28
2d1fc3c7
PE
29 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
30 (Fdbus_call_method, Fdbus_call_method_asynchronously):
31 Use XFASTINT rather than XUINT when numbers are nonnegative.
32 (xd_append_arg, Fdbus_method_return_internal):
33 (Fdbus_method_error_internal): Likewise. Also, for unsigned
34 arguments, check that Lisp number is nonnegative, rather than
59568bf0 35 silently wrapping negative numbers around. (Bug#8722)
30217ff0 36 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 37 (Bug#8722)
2d1fc3c7 38
c8a9ca5a
PE
39 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
40
519e1d69
PE
41 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
42
30569699
PE
43 ccl: add integer overflow checks
44 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
45 (IN_INT_RANGE): New macros.
46 (ccl_driver): Use them to check for integer overflow when
47 decoding a CCL program. Many of the new checks are whether XINT (x)
48 fits in int; it doesn't always, on 64-bit hosts. The new version
49 doesn't catch all possible integer overflows, but it's an
847044ea 50 improvement. (Bug#8719)
30569699 51
c11285dc
PE
52 * alloc.c (make_event_array): Use XINT, not XUINT.
53 There's no need for unsigned here.
54
fdccd48e
PE
55 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
56 This follows up to the 2011-05-06 change that substituted uintptr_t
57 for EMACS_INT. This case wasn't caught back then.
58
37910ab2
PE
59 Rework Fformat to avoid integer overflow issues.
60 * editfns.c: Include <float.h> unconditionally, as it's everywhere
61 now (part of C89). Include <verify.h>.
62 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
63 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
64 (Fformat): Avoid the prepass trying to compute sizes; it was only
65 approximate and thus did not catch overflow reliably. Instead, walk
66 through the format just once, formatting and computing sizes as we go,
67 checking for integer overflow at every step, and allocating a larger
68 buffer as needed. Keep track separately whether the format is
69 multibyte. Keep only the most-recently calculated precision, rather
70 than them all. Record whether each argument has been converted to
71 string. Use EMACS_INT, not int, for byte and char and arg counts.
72 Support field widths and precisions larger than INT_MAX. Avoid
73 sprintf's undefined behavior with conversion specifications such as %#d
74 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
75 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
76 formatting out-of-range floating point numbers with int
77 formats. (Bug#8668)
78
2e6578fb
PE
79 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
80
0ae6bdee
PE
81 * data.c: Avoid integer truncation in expressions involving floats.
82 * data.c: Include <intprops.h>.
83 (arith_driver): When there's an integer overflow in an expression
84 involving floating point, convert the integers to floating point
85 so that the resulting value does not suffer from catastrophic
86 integer truncation. For example, on a 64-bit host (* 4
87 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
88 Do not rely on undefined behavior after integer overflow.
89
de883a70
PE
90 merge count_size_as_multibyte, parse_str_to_multibyte
91 * character.c, character.h (count_size_as_multibyte):
92 Renamed from parse_str_to_multibyte; all uses changed.
93 Check for integer overflow.
94 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
95 since it's now a duplicate of the other. This is more of
96 a character than a buffer op, so better that it's in character.c.
97 * fns.c, print.c: Adjust to above changes.
98
2ff916cb
PE
992011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
100
101 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
102
f1b54466
PE
1032011-05-27 Paul Eggert <eggert@cs.ucla.edu>
104
fb1ac845
PE
105 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
106 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
107 (x_clipboard_manager_save): Now static.
108 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
109
f1b54466
PE
110 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
111 (crypto_hash_function): Now static.
112 Fix pointer signedness problems. Avoid unnecessary initializations.
113
a9f737ee
CY
1142011-05-27 Chong Yidong <cyd@stupidchicken.com>
115
116 * termhooks.h (Vselection_alist): Make it terminal-local.
117
118 * terminal.c (create_terminal): Initialize it.
119
120 * xselect.c: Support for clipboard managers.
121 (Vselection_alist): Move to termhooks.h as terminal-local var.
122 (LOCAL_SELECTION): New macro.
123 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
124 (symbol_to_x_atom): Remove gratuitous arg.
125 (x_handle_selection_request, lisp_data_to_selection_data)
126 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
127 (x_own_selection, x_get_local_selection, x_convert_selection): New
128 arg, specifying work frame. Use terminal-local Vselection_alist.
129 (some_frame_on_display): Delete unused function.
130 (Fx_own_selection_internal, Fx_get_selection_internal)
131 (Fx_disown_selection_internal, Fx_selection_owner_p)
132 (Fx_selection_exists_p): New optional frame arg.
133 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
134 (x_handle_selection_clear): Don't treat other terminals with the
135 same keyboard specially. Use the terminal-local Vselection_alist.
136 (x_clear_frame_selections): Use Frun_hook_with_args.
137
138 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
139
140 * xterm.h: Add support for those atoms.
141
e067f0c1
CY
1422011-05-26 Chong Yidong <cyd@stupidchicken.com>
143
144 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
145 (converted_selections, conversion_fail_tag): New global variables.
146 (x_selection_request_lisp_error): Free the above.
147 (x_get_local_selection): Remove unnecessary code.
148 (x_reply_selection_request): Args changed; handle arbitrary array
149 of converted selections stored in converted_selections. Separate
150 the XChangeProperty and SelectionNotify steps.
151 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
152 (x_convert_selection): New function.
153 (x_handle_selection_event): Simplify.
154 (x_get_foreign_selection): Don't ignore incoming requests while
155 waiting for an answer; this will fail when we implement
156 SAVE_TARGETS, and seems unnecessary anyway.
157 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
158 (Vx_sent_selection_functions): Doc fix.
159
0f4aebc0
LL
1602011-05-26 Leo Liu <sdl.web@gmail.com>
161
162 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
163
e61124cd
YM
1642011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
165
166 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
167
168 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
169 for fringe update if it has periodic bitmap.
170 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
171 and fringe_bitmap_periodic_p.
172
173 * fringe.c (get_fringe_bitmap_data): New function.
174 (draw_fringe_bitmap_1, update_window_fringes): Use it.
175 (update_window_fringes): Record periodicity of fringe bitmap in glyph
176 row. Mark glyph row for fringe update if periodicity changed.
177
178 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
179 for fringe update unless it has periodic bitmap.
180
f16d9837
KH
1812011-05-25 Kenichi Handa <handa@m17n.org>
182
183 * xdisp.c (get_next_display_element): Set correct it->face_id for
184 a static composition.
185
e1b90ef6
LL
1862011-05-24 Leo Liu <sdl.web@gmail.com>
187
188 * deps.mk (fns.o):
189 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
190
191 * fns.c (crypto_hash_function, Fsha1): New function.
192 (Fmd5): Use crypto_hash_function.
193 (syms_of_fns): Add Ssha1.
194
7400048f
PE
1952011-05-22 Paul Eggert <eggert@cs.ucla.edu>
196
197 * gnutls.c: Remove unused macros.
198 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
199 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
200 Remove macros that are defined and never used.
201 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
202
abb71cf4
CY
2032011-05-22 Chong Yidong <cyd@stupidchicken.com>
204
205 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
206 (Fx_get_selection_internal): Minor cleanup.
207 (Fx_own_selection_internal): Rename arguments for consistency with
208 select.el.
209
6307db39
PE
2102011-05-22 Paul Eggert <eggert@cs.ucla.edu>
211
212 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
213
f3d4e0a4
CY
2142011-05-22 Chong Yidong <cyd@stupidchicken.com>
215
216 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
217
4d8ade89
YM
2182011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
219
220 * dispnew.c (scrolling_window): Don't exclude the case that the
221 last enabled row in the desired matrix touches the bottom boundary.
222
32078c8d
GM
2232011-05-21 Glenn Morris <rgm@gnu.org>
224
225 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
226 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
227 and add some more files.
32078c8d 228
7285dc67
EZ
2292011-05-20 Eli Zaretskii <eliz@gnu.org>
230
231 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
232 report_file_error introduced by the change from 2011-05-07.
233
89d1bd22
PE
2342011-05-20 Paul Eggert <eggert@cs.ucla.edu>
235
236 * systime.h (Time): Define only if emacs is defined.
237 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
238 where the include path doesn't have X11/X.h by default. See
239 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
240
e23640bb 2412011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
242
243 * composite.c (find_automatic_composition): Fix previous change.
244
b9704ad9
GM
2452011-05-20 Glenn Morris <rgm@gnu.org>
246
247 * lisp.mk: New file, split from Makefile.in.
248 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
249 (shortlisp): Remove.
250 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
251
4a720484
GM
2522011-05-19 Glenn Morris <rgm@gnu.org>
253
254 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
255 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
256 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
257 (lisp): Set the order to that of loadup.el.
258 (shortlisp): Make it a copy of $lisp.
259 (SOME_MACHINE_LISP): Remove.
260 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
261 Use just $shortlisp, not $SOME_MACHINE_LISP too.
262
a28d4396
KH
2632011-05-18 Kenichi Handa <handa@m17n.org>
264
265 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
266 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
267 (find_automatic_composition): Mostly rewrite for efficiency.
268
a2b1fa8e
JB
2692011-05-18 Juanma Barranquero <lekktu@gmail.com>
270
271 * makefile.w32-in: Update dependencies.
272
8e1f5610
CS
2732011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
274
275 * menu.c: Include limits.h (fixes the MS-Windows build broken by
276 revision 104625).
277
7025ee00 2782011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 279
cdfa6eab
PE
280 Fix some integer overflow issues, such as string length overflow.
281
06d6db33
PE
282 * insdel.c (count_size_as_multibyte): Check for string overflow.
283
2b4560a8
PE
284 * character.c (lisp_string_width): Check for string overflow.
285 Use EMACS_INT, not int, for string indexes and lengths; in
286 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
287 the resulting string length overflows an EMACS_INT; instead,
288 report a string overflow if no precision given. When checking for
289 precision exhaustion, use a check that cannot possibly have
290 integer overflow. (Bug#8675)
291 * character.h (lisp_string_width): Adjust to new signature.
292
cb93f9be
PE
293 * alloc.c (string_overflow): New function.
294 (Fmake_string): Use it. This doesn't change behavior, but saves
295 a few bytes and will simplify future changes.
296 * character.c (string_escape_byte8): Likewise.
297 * lisp.h (string_overflow): New decl.
298
1a1f3366
PE
299 Fixups, following up to the user-interface timestamp change.
300 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
301 for UI timestamps, instead of unsigned long.
9fbd6841
PE
302 * msdos.c (mouse_get_pos): Likewise.
303 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
304 * w32gui.h (Time): Define by including "systime.h" rather than by
305 declaring it ourselves. (Bug#8664)
306
d4e3e4d3
PE
307 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
308 * image.c (clear_image_cache): Likewise.
309
f6a24d19
PE
310 * term.c (term_mouse_position): Don't assume time_t wraparound.
311
08dc5ae6
PE
312 Be more systematic about user-interface timestamps.
313 Before, the code sometimes used 'Time', sometimes 'unsigned long',
314 and sometimes 'EMACS_UINT', to represent these timestamps. This
315 change causes it to use 'Time' uniformly, as that's what X uses.
316 This makes the code easier to follow, and makes it easier to catch
317 integer overflow bugs such as Bug#8664.
318 * frame.c (Fmouse_position, Fmouse_pixel_position):
319 Use Time, not unsigned long, for user-interface timestamps.
320 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
321 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
322 * keyboard.h (last_event_timestamp): Likewise.
323 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
324 * menu.h (xmenu_show): Likewise.
325 * term.c (term_mouse_position): Likewise.
326 * termhooks.h (struct input_event.timestamp): Likewise.
327 (struct terminal.mouse_position_hook): Likewise.
328 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
329 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
330 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
331 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
332 what it was before.
333 * menu.h, termhooks.h: Include "systime.h", for Time.
334
8e55734a
PE
335 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
336 Don't assume that the difference between two unsigned long values
337 can fit into an integer. At this point, we know button_down_time
338 <= event->timestamp, so the difference must be nonnegative, so
339 there's no need to cast the result if double-click-time is
340 nonnegative, as it should be; check that it's nonnegative, just in
341 case. This bug is triggered when events are more than 2**31 ms
86db42d2 342 apart (about 25 days). (Bug#8664)
8e55734a 343
841f1b75 344 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 345 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 346
3e26f69c
PE
347 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
348 that always fit in int. Use a sentinel instead of a counter, to
349 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
350 * frame.h (struct frame): Use int for menu_bar_items_used
351 instead of EMACS_INT, since it always fits in int.
3e26f69c 352
5cc152c0
PE
353 * menu.c (grow_menu_items): Check for int overflow.
354
d89eb65e
PE
355 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
356
5235bd3e
PE
357 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
358 Before, the code was not consistent. These values cannot exceed
359 2**31 - 1 so there's no need to make them unsigned.
360 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
361 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
362 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
363 as modifiers.
364 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
365
bc827e23
PE
366 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
367 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
368 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
369 presumably because the widths might not match.
370
78eb494e
PE
371 * window.c (size_window): Avoid needless test at loop start.
372
04f2d78b
CB
3732011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
374
375 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
376
d2fc7e3d 3772011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
378
379 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
380
d2fc7e3d 3812011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
382
383 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
384 `width' to `bar_area_x' and `bar_area_width', respectively.
385 (x_scroll_run): Take account of fringe background extension.
386
04f2d78b
CB
387 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
388 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
389 `bar_area_width', respectively.
390 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
391 background extension.
392
79b70037
GM
3932011-05-10 Jim Meyering <meyering@redhat.com>
394
395 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
396
2f142cc5
JB
3972011-05-10 Juanma Barranquero <lekktu@gmail.com>
398
399 * image.c (Finit_image_library): Return t for built-in image types,
400 like pbm and xbm. (Bug#8640)
401
57679c86
AS
4022011-05-09 Andreas Schwab <schwab@linux-m68k.org>
403
404 * w32menu.c (set_frame_menubar): Fix submenu allocation.
405
888c9e86
EZ
4062011-05-07 Eli Zaretskii <eliz@gnu.org>
407
b0512a1d
EZ
408 * w32console.c (Fset_screen_color): Doc fix.
409 (Fget_screen_color): New function.
410 (syms_of_ntterm): Defsubr it.
411
7285dc67
EZ
412 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
413 unlink the temporary file if Fcall_process didn't create it in the
414 first place.
415 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
416 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
417 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
418 cue to call_process_cleanup not to close that handle.
419
4d3fcc8e
BK
4202011-05-07 Ben Key <bkey76@gmail.com>
421
422 * makefile.w32-in: The bootstrap-temacs rule now makes use of
423 one of two shell specific rules, either bootstrap-temacs-CMD or
424 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
425 to the previous implementation of the bootstrap-temacs rule.
426 The bootstrap-temacs-CMD rule is similar to the previous
427 implementation of the bootstrap-temacs rule except that it
428 makes use of the ESC_CFLAGS variable instead of the CFLAGS
429 variable.
430
431 These changes, along with some changes to nt/configure.bat,
432 nt/gmake.defs, and nt/nmake.defs, are required to extend my
433 earlier fix to add support for --cflags and --ldflags options
434 that include quotes so that it works whether make uses cmd or
435 sh as the shell.
436
b4289b64
MA
4372011-05-06 Michael Albinus <michael.albinus@gmx.de>
438
439 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
440 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
441 is a constant.
442 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
443 a string. Handle both cases.
444 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
445 (Fdbus_register_method): Use Qinvalid_function.
446
af4c0e28
JB
4472011-05-06 Juanma Barranquero <lekktu@gmail.com>
448
449 * makefile.w32-in: Update dependencies.
450 (LISP_H): Add inttypes.h and stdin.h.
451 (PROCESS_H): Add unistd.h.
452
c51453d9
EZ
4532011-05-06 Eli Zaretskii <eliz@gnu.org>
454
455 * lread.c: Include limits.h (fixes the MS-Windows build broken by
456 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
457
8ff0ac3c 4582011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 459
4c4b566b
PE
460 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
461
aab2b9b5
PE
462 * term.c (vfatal): Remove stray call to va_end.
463 It's not needed and the C Standard doesn't allow it here anyway.
464
c378da0b
PE
465 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
466 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
467
288b08c7
PE
468 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
469 bytes.
470
e3601888
PE
471 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
472
db6c0e74
PE
473 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
474
dd5963ea
PE
475 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
476
88c9450f
PE
477 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
478
2f9442b8
PE
479 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
480
c032b5f8
PE
481 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
482 * charset.c (Fdefine_charset_internal): Don't initialize
483 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 484 32-bit int (Bug#8600).
a108c10b
PE
485
486 * lread.c (read_integer): Be more consistent with string-to-number.
487 Use string_to_number to do the actual conversion; this avoids
488 rounding errors and fixes some other screwups. Without this fix,
489 for example, #x1fffffffffffffff was misread as -2305843009213693952.
490 (digit_to_number): Move earlier, for benefit of read_integer.
491 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 492 not a digit in any supported base. (Bug#8602)
a108c10b 493
ad5f9eea
PE
494 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
495
aec1708a
PE
496 * dispnew.c (scrolling_window): Return 1 if we scrolled,
497 to match comment at start of function. This also removes a
498 GCC warning about overflow in a 32+64-bit port.
499
47be4ab5
PE
500 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
501
371cac43
PE
502 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
503 Reported by Stefan Monnier in
504 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
505 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
506 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 507
d01a7826
PE
508 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
509 (EMACS_UINTPTR): Likewise, with uintptr_t.
510
7fd47d5c
PE
511 * lisp.h: Prefer 64-bit EMACS_INT if available.
512 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
513 on 32-bit hosts that have 64-bit int, so that they can access
514 large files.
122b0c86
PE
515 However, temporarily disable this change unless the temporary
516 symbol WIDE_EMACS_INT is defined.
7fd47d5c 517
8727937b
PE
518 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
519
8ac068ac
PE
520 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
521 This removes an assumption that EMACS_INT and long are the same
522 width as pointers. The assumption is true for Emacs porting targets
523 now, but we want to make other targets possible.
524 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
525 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
526 In the rest of the code, change types of integers that hold casted
527 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
528 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
529 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
530 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
531 No need to cast type when ORing.
532 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
533 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
534 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
535 assume EMACS_INT is the same width as char *.
536 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
537 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
538 Remove no-longer-needed casts.
539 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
540 (xg_tool_bar_help_callback, xg_make_tool_item):
541 Use EMACS_INTPTR to hold an integer
542 that will be cast to void *; this can avoid a GCC warning
543 if EMACS_INT is not the same width as void *.
544 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
545 * xdisp.c (display_echo_area_1, resize_mini_window_1):
546 (current_message_1, set_message_1):
547 Use a local to convert to proper width without a cast.
548 * xmenu.c (dialog_selection_callback): Likewise.
549
ede49d71
PE
550 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
551 Also, don't assume VALBITS / RAND_BITS is less than 5,
552 and don't rely on undefined behavior when shifting a 1 left into
553 the sign bit.
554 * lisp.h (get_random): Change signature to match.
555
2f30ecd0
PE
556 * lread.c (hash_string): Use size_t, not int, for hash computation.
557 Normally we prefer signed values; but hashing is special, because
558 it's better to use unsigned division on hash table sizes so that
559 the remainder is nonnegative. Also, size_t is the natural width
560 for hashing into memory. The previous code used 'int', which doesn't
561 retain enough info to hash well into very large tables.
562 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
563
2a866e7b
PE
564 * dbusbind.c: Don't possibly lose pointer info when converting.
565 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
566 Use XPNTR rather than XHASH, so that the high-order bits of
567 the pointer aren't lost when converting through void *.
568
51639eac
PE
569 * eval.c (Fautoload): Don't double-shift a pointer.
570
92394119
PE
571 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
572
dbdb9a7c
JB
5732011-05-06 Juanma Barranquero <lekktu@gmail.com>
574
575 * gnutls.c (DEF_GNUTLS_FN):
576 * image.c (DEF_IMGLIB_FN): Make function pointers static.
577
db7a0b4f
AS
5782011-05-05 Andreas Schwab <schwab@linux-m68k.org>
579
580 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
581 marker. (Bug#8610)
582
f7ff1b0f 5832011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
584
585 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
586 New version that can reserve upto 2GB of heap space.
587
f7ff1b0f 5882011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
589
590 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
591
639c109b
TZ
5922011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
593
594 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
595 `gnutls_certificate_set_x509_key_file'.
596
d2127135
JB
5972011-05-05 Juanma Barranquero <lekktu@gmail.com>
598
599 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
600 Update dependencies.
601
e968f4f3
JB
6022011-05-04 Juanma Barranquero <lekktu@gmail.com>
603
604 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
605 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
606 Remove unused parameter `fildes'.
607 * process.c (read_process_output, send_process): Don't pass it.
608
84d358f0
JB
6092011-05-04 Juanma Barranquero <lekktu@gmail.com>
610
611 Fix previous change: the library cache is defined in w32.c.
612 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
613 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
614
0898ca10
JB
6152011-05-04 Juanma Barranquero <lekktu@gmail.com>
616
617 Implement dynamic loading of GnuTLS on Windows.
618
619 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
620 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
621 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
622 Declare.
623
624 * gnutls.c (Qgnutls_dll): Define.
625 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
626 (gnutls_*): Declare function pointers.
627 (init_gnutls_functions): New function to initialize function pointers.
628 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
629 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
630 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
631 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
632 (emacs_gnutls_write, emacs_gnutls_read)
633 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
634 (Fgnutls_available_p): New function.
635 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
636 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
637 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
638
639 * image.c: Include w32.h.
640 (Vimage_type_cache): Delete.
641 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
642 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
643 (w32_delayed_load): Move to w32.c.
644
645 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
646
647 * w32.c (QCloaded_from, Vlibrary_cache): Define.
648 (w32_delayed_load): Move from image.c. When loading a library, record
649 its filename in the :loaded-from property of the library id.
650 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
651 Initialize and staticpro them.
652 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
653
654 * process.c: Include lisp.h before w32.h, not after.
655 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
656 instead of gnutls_record_check_pending.
657
658 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
659
ff4de4aa
TZ
6602011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
661
662 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
663 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
664 as passed in.
665
abe95abb
JD
6662011-05-03 Jan Djärv <jan.h.d@swipnet.se>
667
668 * xterm.c (x_set_frame_alpha): Do not set property on anything
669 else than FRAME_X_OUTER_WINDOW (Bug#8608).
670
e16e55d4
JB
6712011-05-02 Juanma Barranquero <lekktu@gmail.com>
672
673 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
674
bafcf6a5
JB
6752011-05-02 Juanma Barranquero <lekktu@gmail.com>
676
677 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
678 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
679 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
680 (gnutls_global_initialized, Qgnutls_bootprop_priority)
681 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
682 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
683 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
684 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
685 (Qgnutls_bootprop_callbacks_verify): Make static.
686
e7a6747f
AS
6872011-05-01 Andreas Schwab <schwab@linux-m68k.org>
688
19ed11ba
AS
689 * callproc.c: Indentation fixup.
690
e7a6747f 691 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
692 (wait_for_termination, interruptible_wait_for_termination):
693 Move after wait_for_termination_1.
e7a6747f 694
1ef14cb4
LMI
6952011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
696
697 * sysdep.c (interruptible_wait_for_termination): New function
698 which is like wait_for_termination, but allows keyboard
699 interruptions.
700
701 * callproc.c (Fcall_process): Add (:file "file") as an option for
702 the STDOUT buffer.
703 (Fcall_process_region): Ditto.
704
330d880c
EZ
7052011-04-30 Eli Zaretskii <eliz@gnu.org>
706
8db90b73
EZ
707 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
708 rather than `XVECTOR (FOO)->size'.
709
330d880c
EZ
710 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
711 inttypes.h, as a gnulib replacement is used if it not available in
712 system headers.
713
15cbd324
EZ
7142011-04-21 Eli Zaretskii <eliz@gnu.org>
715
716 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
717 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
718 of MOST_POSITIVE_FIXNUM. (Bug#8528)
719
720 * coding.c (coding_alloc_by_realloc): Error out if destination
721 will grow beyond MOST_POSITIVE_FIXNUM.
722 (decode_coding_emacs_mule): Abort if there isn't enough place in
723 charbuf for the composition carryover bytes. Reserve an extra
724 space for up to 2 characters produced in a loop.
725 (decode_coding_iso_2022): Abort if there isn't enough place in
726 charbuf for the composition carryover bytes.
727
7282011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 729
ae940cca
EZ
730 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
731 aborting when %lld or %lll format is passed.
732 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
733 %llo or %llx format is passed. (Bug#8545)
734
03ab8921
EZ
735 * window.c (window_scroll_line_based): Use a marker instead of
736 simple variables to record original value of point. (Bug#7952)
737
afda1437
EZ
738 * doprnt.c (doprnt): Fix the case where a multibyte sequence
739 produced by %s or %c overflows available buffer space. (Bug#8545)
740
f76dee0c
PE
7412011-04-28 Paul Eggert <eggert@cs.ucla.edu>
742
743 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 744 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 745
fdc5744d
JB
7462011-04-28 Juanma Barranquero <lekktu@gmail.com>
747
748 * w32.c (init_environment): Warn about defaulting HOME to C:\.
749
638f053a
JB
7502011-04-28 Juanma Barranquero <lekktu@gmail.com>
751
752 * keyboard.c (Qdelayed_warnings_hook): Define.
753 (command_loop_1): Run `delayed-warnings-hook'
754 if Vdelayed_warnings_list is non-nil.
755 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
756 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
757
d178f871
EZ
7582011-04-28 Eli Zaretskii <eliz@gnu.org>
759
760 * doprnt.c (doprnt): Don't return value smaller than the buffer
761 size if the message was truncated. (Bug#8545).
762
b124fd93
JB
7632011-04-28 Juanma Barranquero <lekktu@gmail.com>
764
765 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
766 (Fx_window_property): #if-0 the whole functions, not just the bodies.
767
e810457d
PE
7682011-04-27 Paul Eggert <eggert@cs.ucla.edu>
769
770 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
771
ea51cceb
JB
7722011-04-27 Juanma Barranquero <lekktu@gmail.com>
773
774 * makefile.w32-in: Update dependencies.
775
94dcfacf
EZ
7762011-04-27 Eli Zaretskii <eliz@gnu.org>
777
778 Improve `doprnt' and its usage. (Bug#8545)
779 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
780 `format_end'. Remove support for %l as a conversion specifier.
781 Don't use xrealloc. Improve diagnostics when the %l size modifier
782 is used. Update the commentary.
783
784 * eval.c (verror): Simplify calculation of size_t.
785
786 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
787 messages.
788
f61f41d7
PE
7892011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
790
791 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
792 change.
793
96fb4434
PE
7942011-04-27 Paul Eggert <eggert@cs.ucla.edu>
795
796 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
797 This makes this file independent of the recent pseudovector change.
798
671875da 7992011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 800
69e9b5a3
PE
801 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
802
b5f869a7 803 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 804 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 805 Remove unused local.
c8926152 806 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 807
841a1577 808 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
809 GCC 4.6.0 optimizes based on type-based alias analysis.
810 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
811 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
812 != &v->size, and therefore "v->size = 1; b->size = 2; return
813 v->size;" must therefore return 1. This assumption is incorrect
814 for Emacs, since it type-puns struct Lisp_Vector * with many other
815 types. To fix this problem, this patch adds a new type struct
f904488f 816 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
817 and pseudovectors, and helps optimizing compilers not get fooled
818 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
819 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
820 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
821 the size member.
eab3844f
PE
822 (XSETPVECTYPE): Rewrite in terms of new macro.
823 (XSETPVECTYPESIZE): New macro, specifying both type and size.
824 This is a bit clearer, and further avoids the possibility of
825 undesirable aliasing.
826 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 827 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
828 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
829 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
830 (ASIZE): Now uses header.size rather than size.
831 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
832 to avoid the hassle of writing XVECTOR (foo)->header.size.
833 (struct vectorlike_header): New type.
eab3844f
PE
834 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
835 object, to help avoid aliasing.
836 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
837 (SUBRP): Likewise, since Lisp_Subr is a special case.
838 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
839 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
840 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 841 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
842 changed to be "header.size" and "header.next".
843 * buffer.h (struct buffer): Likewise.
844 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
845 * frame.h (struct frame): Likewise.
846 * process.h (struct Lisp_Process): Likewise.
847 * termhooks.h (struct terminal): Likewise.
848 * window.c (struct save_window_data, struct saved_window): Likewise.
849 * window.h (struct window): Likewise.
850 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
851 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
852 * buffer.c (init_buffer_once): Likewise.
853 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
854 special case.
855 * process.c (Fformat_network_address): Use local var for size,
856 for brevity.
857
0df1eac5
PE
858 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
859
847ab9d1 860 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
861 * data.c (atof): Remove decl; no longer used or needed.
862 (digit_to_number): Move to lread.c.
863 (Fstring_to_number): Use new string_to_number function, to be
864 consistent with how the Lisp reader treats infinities and NaNs.
865 Do not assume that floating-point numbers represent EMACS_INT
866 without losing information; this is not true on most 64-bit hosts.
867 Avoid double-rounding errors, by insisting on integers when
868 parsing non-base-10 numbers, as the documentation specifies.
869 * lisp.h (string_to_number): New decl, replacing ...
870 (isfloat_string): Remove.
bc0a5c13 871 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 872 (read1): Do not accept +. and -. as integers; this
452f4150
PE
873 appears to have been a coding error. Similarly, do not accept
874 strings like +-1e0 as floating point numbers. Do not report
875 overflow for integer overflows unless the base is not 10 which
876 means we have no simple and reliable way to continue.
877 Break out the floating-point parsing into a new
878 function string_to_number, so that Fstring_to_number parses
879 floating point numbers consistently with the Lisp reader.
04f2d78b 880 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
881 (E_CHAR, EXP_INT): Remove, replacing with ...
882 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
883 (string_to_number): New function, replacing isfloat_string.
884 This function checks for valid syntax and produces the resulting
885 Lisp float number too. Rework it so that string-to-number
bc0a5c13 886 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
887 so that overflow for non-base-10 numbers is reported only when
888 there's no portable and simple way to convert to floating point.
452f4150 889
67769ffc
PE
890 * textprop.c (set_text_properties_1): Rewrite for clarity,
891 and to avoid GCC warning about integer overflow.
892
c20db43f
PE
893 * intervals.h (struct interval): Use EMACS_INT for members
894 where EMACS_UINT might cause problems. See
895 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
896 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
897 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
898 All uses changed.
37aa2f85
PE
899 (offset_intervals): Tell GCC not to worry about length overflow
900 when negating a negative length.
c20db43f 901
2538aa2f
PE
902 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
903 (overrun_check_free): Likewise.
904
f2d3008d
PE
905 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
906 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
907 word size.
908
ec8df744
PE
909 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
910 (gnutls_make_error): Rename local to avoid shadowing.
911 (gnutls_emacs_global_deinit): ifdef out; not used.
912 (Fgnutls_boot): Use const for pointer to readonly storage.
913 Comment out unused local. Fix pointer signedness problems.
914
640ee02d
PE
915 * lread.c (openp): Don't stuff size_t into an 'int'.
916 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
917 about possible signed overflow.
918
6048fb2a
PE
919 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
920 (GDK_KEY_g): Don't define if already defined.
921 (xg_prepare_tooltip): Avoid pointer signedness problem.
922 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
923
fa3c87e1
PE
924 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
925 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
926
2172544b
PE
927 * xfns.c (Fx_window_property): Simplify a bit,
928 to make a bit faster and to avoid GCC 4.6.0 warning.
929 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
930
9b821a21
PE
931 * fns.c (internal_equal): Don't assume size_t fits in int.
932
3c616cfa
PE
933 * alloc.c (compact_small_strings): Tighten assertion a little.
934
c2982e87
PE
935 Replace pEd with more-general pI, and fix some printf arg casts.
936 * lisp.h (pI): New macro, generalizing old pEd macro to other
937 conversion specifiers. For example, use "...%"pI"d..." rather
938 than "...%"pEd"...".
939 (pEd): Remove. All uses replaced with similar uses of pI.
940 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
941 * alloc.c (check_pure_size): Don't overflow by converting size to int.
942 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
943 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
944 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
945 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
946 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
947 64-bit hosts.
948 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
949 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
950 * print.c (safe_debug_print, print_object): Likewise.
951 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
952 to int.
6f04d126
PE
953 Use pI instead of if-then-else-abort. Use %p to avoid casts,
954 avoiding the 0 flag, which is not portable.
c2982e87
PE
955 * process.c (Fmake_network_process): Use pI to avoid cast.
956 * region-cache.c (pp_cache): Likewise.
957 * xdisp.c (decode_mode_spec): Likewise.
958 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
959 behavior on 64-bit hosts with printf arg.
6f04d126 960 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
961 (x_stop_queuing_selection_requests): Likewise.
962 (x_get_window_property): Don't truncate byte count to an 'int'
963 when tracing.
0b432f21 964
5e073ec7
PE
965 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
966 here, since it parses constructs like leading '-' and spaces,
967 which are not wanted; and it overflows with large numbers.
968 Instead, simply match F[0-9]+, which is what is wanted anyway.
969
36372bf9
PE
970 * alloc.c: Remove unportable assumptions about struct layout.
971 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
972 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
973 (allocate_vectorlike, make_pure_vector): Use the new macros,
974 plus offsetof, to remove unportable assumptions about struct layout.
975 These assumptions hold on all porting targets that I know of, but
976 they are not guaranteed, they're easy to remove, and removing them
977 makes further changes easier.
978
0b432f21
PE
979 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
980 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
981 (string_overrun_cookie): Now const. Use initializers that
982 don't formally overflow signed char, to avoid warnings.
000098c1
PE
983 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
984 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
985 (allocate_buffer): Don't assume sizeof (struct buffer) is a
986 multiple of sizeof (EMACS_INT); it need not be, if
987 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 988 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 989
895009e1
JB
9902011-04-26 Juanma Barranquero <lekktu@gmail.com>
991
992 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
993
6a7a1b0b
TZ
9942011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
995
996 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 997 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
998 Reported by Paul Eggert <eggert@cs.ucla.edu>.
999
841a1577 10002011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1001
1002 * lisp.h (Qdebug): List symbol.
895009e1 1003 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1004 * keyboard.c (debug-on-event): New variable.
1005 (handle_user_signal): Break into debugger when debug-on-event
1006 matches the current signal symbol.
1007
f2d3ba6f
DN
10082011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1009
1010 * alloc.c (check_sblock, check_string_bytes)
1011 (check_string_free_list): Convert to standard C.
1012
42ce4c63
TZ
10132011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1014
1015 * w32.c (emacs_gnutls_push): Fix typo.
1016
825cd63c
EZ
10172011-04-25 Eli Zaretskii <eliz@gnu.org>
1018
fb11d64d
EZ
1019 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1020 "cast to pointer from integer of different size".
1021
825cd63c
EZ
1022 Improve doprnt and its use in verror. (Bug#8545)
1023 * doprnt.c (doprnt): Document the set of format control sequences
1024 supported by the function. Use SAFE_ALLOCA instead of always
1025 using `alloca'.
1026
1027 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1028 is one byte too soon. Don't use xrealloc; instead xfree and
1029 xmalloc anew.
1030
e061a11b
TZ
10312011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1032
1033 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1034 callbacks stage.
1035
1036 * gnutls.c: Renamed global_initialized to
1037 gnutls_global_initialized. Added internals for the
1038 :verify-hostname-error, :verify-error, and :verify-flags
1039 parameters of `gnutls-boot' and documented those parameters in the
1040 docstring. Start callback support.
1041 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1042 unless a fatal error occured. Call gnutls_alert_send_appropriate
1043 on error. Return error code.
1044 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1045 (emacs_gnutls_read): Likewise.
1046 (Fgnutls_boot): Return handshake error code.
1047 (emacs_gnutls_handle_error): New function.
1048 (wsaerror_to_errno): Likewise.
1049
1050 * w32.h (emacs_gnutls_pull): Add prototype.
1051 (emacs_gnutls_push): Likewise.
1052
1053 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1054 (emacs_gnutls_push): Likewise.
1055
10562011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1057
1058 * process.c (wait_reading_process_output): Check if GnuTLS
1059 buffered some data internally if no FDs are set for TLS
1060 connections.
1061
1062 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1063 (LIBS): Link to USER_LIBS.
1064 ($(BLD)/gnutls.$(0)): New target.
1065
fa6996bc
EZ
10662011-04-24 Eli Zaretskii <eliz@gnu.org>
1067
eb35682e
EZ
1068 * xdisp.c (handle_single_display_spec): Rename the
1069 display_replaced_before_p argument into display_replaced_p, to
1070 make it consistent with the commentary. Fix typos in the
1071 commentary.
1072
e2ad650c
EZ
1073 * textprop.c (syms_of_textprop): Remove dead code.
1074 (copy_text_properties): Delete obsolete commentary about an
1075 interface that was deleted long ago. Fix typos in the description
1076 of arguments.
1077
1b2de274
EZ
1078 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1079 to changes in oldXMenu/XMenu.h from 2011-04-16.
1080 <menu_help_message, prev_menu_help_message>: Constify.
1081 (IT_menu_make_room): menu->help_text is now `const char **';
1082 adjust.
1083
1084 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1085 to changes in oldXMenu/XMenu.h from 2011-04-16.
1086 (struct XMenu): Declare `help_text' `const char **'.
1087
1088 * xfaces.c <Qunspecified>: Make extern again.
1089
1090 * syntax.c: Include sys/types.h before including regex.h, as
1091 required by Posix.
1092
762b15be
EZ
1093 * doc.c (get_doc_string): Improve the format passed to `error'.
1094
1095 * doprnt.c (doprnt): Improve commentary.
1096
1097 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1098
1099 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1100 them with etags.
1101
f1052e5d
EZ
1102 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1103 changes in globals.h immediately force recompilation.
762b15be
EZ
1104 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1105 $(CURDIR)/s/ms-w32.h.
1106 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1107
fa6996bc
EZ
1108 * character.c (Fchar_direction): Function deleted.
1109 (syms_of_character): Don't defsubr it.
1110 <char-direction-table>: Deleted.
1111
e6c3da20
EZ
11122011-04-23 Eli Zaretskii <eliz@gnu.org>
1113
1114 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1115 * doprnt.c: Include limits.h.
1116 (SIZE_MAX): New macro.
04f2d78b
CB
1117 (doprnt): Return a size_t value. 2nd arg is now size_t.
1118 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1119 Improve overflow protection. Support `l' modifier for integer
1120 conversions. Support %l conversion. Don't assume an EMACS_INT
1121 argument for integer conversions and for %c.
1122
1123 * lisp.h (doprnt): Restore prototype.
1124
1125 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1126 $(SRC)/character.h.
1127
1128 * Makefile.in (base_obj): Add back doprnt.o.
1129
1130 * deps.mk (doprnt.o): Add back prerequisites.
1131 (callint.o): Depend on character.h.
1132
1133 * eval.c (internal_lisp_condition_case): Include the handler
1134 representation in the error message.
1135 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1136 when breaking from the loop.
1137
1138 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1139
1140 * callint.c (Fcall_interactively): When displaying error message
1141 about invalid control letter, pass the character's codepoint, not
1142 a pointer to its multibyte form. Improve display of the character
1143 in octal and display also its hex code.
1144
1145 * character.c (char_string): Use %x to display the (unsigned)
1146 codepoint of an invalid character, to avoid displaying a bogus
1147 negative value.
1148
1149 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1150 `error', not SYMBOL_NAME itself.
1151
1152 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1153 character arguments to `error'.
1154
1155 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1156 to `error' in error message about FINAL_CHAR argument. Make sure
1157 FINAL_CHAR is a character, and use %c when it is passed as
1158 argument to `error'.
1159
4ffd0d6b 11602011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1161
1162 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1163
1164 * w32.c: Include <time.h>.
1165 (sys_localtime): New function.
1166
4ffd0d6b 11672011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1168
1169 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1170
4ffd0d6b 1171 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1172
4ffd0d6b 11732011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1174
4ffd0d6b
GM
1175 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1176 zombies (Bug#8467).
aac0c6e3 1177
04c56954
EZ
11782011-04-19 Eli Zaretskii <eliz@gnu.org>
1179
1180 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1181 gl_state.e_property when gl_state.object is Qt.
1182
1183 * insdel.c (make_gap_larger): Remove limitation of buffer size
1184 to <= INT_MAX.
1185
16a43933
CY
11862011-04-18 Chong Yidong <cyd@stupidchicken.com>
1187
1188 * xdisp.c (lookup_glyphless_char_display)
1189 (produce_glyphless_glyph): Handle cons cell entry in
1190 glyphless-char-display.
1191 (Vglyphless_char_display): Document it.
1192
1193 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1194 glyphless-char-display.
1195
4581706e
CY
11962011-04-17 Chong Yidong <cyd@stupidchicken.com>
1197
1198 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1199
1200 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1201
1202 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1203 definition for no-X builds.
1204
4887c6e2 12052011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1206
fd35b6f9
PE
1207 Static checks with GCC 4.6.0 and non-default toolkits.
1208
5c1ccb01
PE
1209 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1210
006c5daa
PE
1211 * process.c (keyboard_bit_set): Define only if SIGIO.
1212 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1213 (send_process): Repair possible setjmp clobbering.
1214
efc736d3
PE
1215 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1216
4e2fe2e6
PE
1217 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1218
f97334a2
PE
1219 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1220
4e75f29d
PE
1221 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1222 Define only if needed.
1223
90efadd1
PE
1224 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1225 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1226 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1227
3c647824
PE
1228 * dispextern.h (struct redisplay_interface): Rename param
1229 to avoid shadowing.
e264f262 1230 * termhooks.h (struct terminal): Likewise.
761383f4 1231 * xterm.c (xembed_send_message): Likewise.
3c647824 1232
b58c5c4a
PE
1233 * insdel.c (make_gap_smaller): Define only if
1234 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1235
cad59032
PE
1236 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1237 it.
1238
c339dc2e
PE
1239 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1240 so that we aren't warned about unused symbols.
1241
91a3e27b
PE
1242 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1243
399c71d3 1244 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 1245
8ffc96f5
PE
1246 * xfns.c (x_real_positions): Mark locals as initialized.
1247
eef9bc79
PE
1248 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1249
098db9dd
PE
1250 * xterm.c: Fix problems found by static analysis with other toolkits.
1251 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
1252 (x_dispatch_event): Declare static if USE_GTK, and
1253 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 1254 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 1255 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
1256 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1257 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 1258
eb18f6cc
PE
1259 * xmenu.c (menu_help_callback): Pointer type fixes.
1260 Use const pointers when pointing at readonly data. Avoid pointer
1261 signedness clashes.
1262 (FALSE): Remove unused macro.
1263 (update_frame_menubar): Remove unused decl.
1264
1fe72bf8
PE
1265 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1266
60d9e1db
PE
1267 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1268 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1269 (single_menu_item): Rename local to avoid shadowing.
1270
39261c26
PE
1271 * keyboard.c (make_lispy_event): Remove unused local var.
1272
018c5e19
PE
1273 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1274 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1275
63d2b86e
PE
1276 * bitmaps: Change bitmaps from unsigned char back to the X11
1277 compatible char. Avoid the old compiler warnings about
1278 out-of-range initializers by using, for example, '\xab' rather
1279 than 0xab.
1280
aefd87e1
PE
1281 * xgselect.c (xgselect_initialize): Check vs interface
1282 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1283
bf501fb9
PE
1284 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1285
e9829fdf
PE
1286 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1287 to read-only memory.
1288
1086c095
PE
1289 * fns.c (vector): Remove; this old hack is no longer needed.
1290
2baccd04 1291 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 1292 Remove unused var.
dde42981 1293 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 1294
72391843 1295 * xrdb.c (x_load_resources): Omit unused local.
3565b346 1296
436c16df 1297 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 1298 (x_window): Rename locals to avoid shadowing.
dc5ddd85 1299 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 1300
92bb796d 1301 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 1302 (x_term_init): Remove local to avoid shadowing.
92bb796d 1303
764430a3 1304 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
1305
1306 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1307 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1308
d1dfb56c
EZ
13092011-04-16 Eli Zaretskii <eliz@gnu.org>
1310
c4354cb4
EZ
1311 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1312
d1dfb56c
EZ
1313 Fix regex.c, syntax.c and friends for buffers > 2GB.
1314 * syntax.h (struct gl_state_s): Declare character position members
1315 EMACS_INT.
1316
1317 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1318
04f2d78b
CB
1319 * textprop.c (verify_interval_modification, interval_of):
1320 Declare arguments EMACS_INT.
d1dfb56c
EZ
1321
1322 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1323 EMACS_INT.
1324
1325 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1326
1327 * indent.c (Fvertical_motion): Local variable it_start is now
1328 EMACS_INT.
1329
1330 * regex.c (re_match, re_match_2, re_match_2_internal)
1331 (bcmp_translate, regcomp, regexec, print_double_string)
1332 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1333 (re_compile_pattern, re_exec): Declare arguments and local
1334 variables `size_t' and `ssize_t' and return values `regoff_t', as
1335 appropriate.
1336 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1337 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1338 <compile_stack_type>: `size' and `avail' are now `size_t'.
1339
1340 * regex.h <regoff_t>: Use ssize_t, not int.
1341 (re_search, re_search_2, re_match, re_match_2): Arguments that
1342 specify buffer/string position and length are now ssize_t and
1343 size_t. Return type is regoff_t.
1344
613052cd
BK
13452011-04-16 Ben Key <bkey76@gmail.com>
1346
1347 * nsfont.m: Fixed bugs in ns_get_family and
1348 ns_descriptor_to_entity that were caused by using free to
1349 deallocate memory blocks that were allocated by xmalloc (via
1350 xstrdup). This caused Emacs to crash when compiled with
1351 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1352 --enable-checking=xmallocoverrun). xfree is now used to
1353 deallocate these memory blocks.
1354
4170f62f 13552011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 1356
71b41406
PE
1357 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1358
9587a89d
PE
1359 emacs_write: Accept and return EMACS_INT for sizes.
1360 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1361 et seq.
1362 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1363 Accept and return EMACS_INT.
1364 (emacs_gnutls_write): Return the number of bytes written on
1365 partial writes.
1366 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
1367 (emacs_read, emacs_write): Remove check for negative size, as the
1368 Emacs source code has been audited now.
9587a89d
PE
1369 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1370 (emacs_read, emacs_write): Use it.
273a5f82
PE
1371 * process.c (send_process): Adjust to the new signatures of
1372 emacs_write and emacs_gnutls_write. Do not attempt to store
1373 a byte offset into an 'int'; it might overflow.
9587a89d 1374 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 1375
3e047f51
PE
1376 * sound.c: Don't assume sizes fit in 'int'.
1377 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 1378 Return EMACS_INT, not int.
3e047f51 1379 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
1380 Accept EMACS_INT, not int.
1381 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
1382 record read return values.
1383
cc39a9db
BK
13842011-04-15 Ben Key <bkey76@gmail.com>
1385
c9d0ec6d
JB
1386 * keyboard.c (Qundefined): Don't declare static since it is used
1387 in nsfns.m.
1388 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1389 static since they are used in nsfont.m.
cc39a9db 1390
6c60eb9f
SM
13912011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1392
1393 * process.c (Qprocessp): Don't declare static.
1394 * lisp.h (Qprocessp): Declare again.
1395
7990b61a
JB
13962011-04-15 Juanma Barranquero <lekktu@gmail.com>
1397
1398 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1399
5d4cb038
PE
14002011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1401
8bd7b830 1402 Improve C-level modularity by making more things 'static'.
cd64ea1d 1403
e3b27b31
PE
1404 Don't publish debugger-only interfaces to other modules.
1405 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1406 (verify_bytepos, count_markers): Move decls to the only modules
1407 that need them.
1408 * region-cache.h (pp_cache): Likewise.
1409 * window.h (check_all_windows): Likewise.
1410 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1411
5d4cb038
PE
1412 * sysdep.c (croak): Now static, if
1413 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1414 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
1415
1416 * alloc.c (refill_memory_reserve): Now static if
1417 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1418 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 1419
e87b6180
PE
1420 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1421 Define only if USE_LUCID.
1422
ac64929e
PE
1423 * xrdb.c (x_customization_string, x_rm_string): Now static.
1424
6f37259d
PE
1425 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1426 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1427
1683e3ab
PE
1428 * xdisp.c (draw_row_with_mouse_face): Now static.
1429 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1430
de9c2632
PE
1431 * window.h (check_all_windows): Mark externally visible.
1432
2b96acb7
PE
1433 * window.c (window_deletion_count): Now static.
1434
1435 * undo.c: Make symbols static if they're not exported.
1436 (last_undo_buffer, last_boundary_position, pending_boundary):
1437 Now static.
1438
50436f33
PE
1439 * textprop.c (interval_insert_behind_hooks): Now static.
1440 (interval_insert_in_front_hooks): Likewise.
1441
64520e5c
PE
1442 * term.c: Make symbols static if they're not exported.
1443 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1444 (max_frame_lines, tty_set_terminal_modes):
1445 (tty_reset_terminal_modes, tty_turn_off_highlight):
1446 (get_tty_terminal): Now static.
1447 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1448 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 1449 HAVE_WINDOW_SYSTEM.
64520e5c
PE
1450 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1451 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1452
1fa53021
PE
1453 * sysdep.c: Make symbols static if they're not exported.
1454 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1455 Now static.
1456 (sigprocmask_set, full_mask): Remove; unused.
1457 (wait_debugging): Mark as visible.
1458 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1459 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1460
d4b43b22
PE
1461 * syntax.c (syntax_temp): Define only if !__GNUC__.
1462
b7c513d0
PE
1463 * sound.c (current_sound_device, current_sound): Now static.
1464
989b29ad
PE
1465 * search.c (searchbufs, searchbuf_head): Now static.
1466
13a55a78
PE
1467 * scroll.c (scroll_cost): Remove; unused.
1468 * dispextern.h (scroll_cost): Remove decl.
1469
de68a1fc
PE
1470 * region-cache.h (pp_cache): Mark as externally visible.
1471
40ccffa6
PE
1472 * process.c: Make symbols static if they're not exported.
1473 (process_tick, update_tick, create_process, chan_process):
1474 (Vprocess_alist, proc_buffered_char, datagram_access):
1475 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1476 (deactivate_process): Mark defn as static, as well as decl.
1477 * lisp.h (create_process): Remove decl.
1478 * process.h (chan_process, Vprocess_alist): Remove decls.
1479
ad64fc97
PE
1480 * print.c: Make symbols static if they're not exported.
1481 (print_depth, new_backquote_output, being_printed, print_buffer):
1482 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1483 (print_interval, print_number_index, initial_stderr_stream):
1484 Now static.
1485 * lisp.h (Fprinc): Remove decl.
1486 (debug_output_compilation_hack): Mark as externally visible.
1487
adddb265
PE
1488 * sysdep.c (croak): Move decl from here to syssignal.h.
1489 * syssignal.h (croak): Put it here, so the API can be checked when
1490 'croak' is called from dissociate_if_controlling_tty.
1491
1717ede2
PE
1492 * minibuf.c: Make symbols static if they're not exported.
1493 (minibuf_save_list, choose_minibuf_frame): Now static.
1494 * lisp.h (choose_minibuf_frame): Remove decl.
1495
fa5fb2bc
PE
1496 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1497
1e3890d1
PE
1498 * lread.c: Make symbols static if they're not exported.
1499 (read_objects, initial_obarray, oblookup_last_bucket_number):
1500 Now static.
1501 (make_symbol): Remove; unused.
1502 * lisp.h (initial_obarray, make_symbol): Remove decls.
1503
8a1414fa
PE
1504 * keyboard.c: Make symbols static if they're not exported.
1505 (single_kboard, recent_keys_index, total_keys, recent_keys):
1506 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1507 (this_single_command_key_start, echoing, last_auto_save):
1508 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1509 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1510 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1511 (Vlispy_mouse_stem, double_click_count):
1512 Now static.
1513 (force_auto_save_soon): Define only if SIGDANGER.
1514 (ignore_mouse_drag_p): Now static if
1515 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1516 (print_help): Remove; unused.
1517 (stop_character, last_timer_event): Mark as externally visible.
1518 * keyboard.h (ignore_mouse_drag_p): Declare only if
1519 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1520 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1521 * lisp.h (echoing): Remove decl.
1522 (force_auto_save_soon): Declare only if SIGDANGER.
1523 * xdisp.c (redisplay_window): Simplify code, to make it more
1524 obvious that ignore_mouse_drag_p is not accessed if !defined
1525 USE_GTK && !defined HAVE_NS.
1526
93ea6e8f
PE
1527 * intervals.c: Make symbols static if they're not exported.
1528 (merge_properties_sticky, merge_interval_right, delete_interval):
1529 Now static.
1530 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1531
77382fcc
PE
1532 * insdel.c: Make symbols static if they're not exported.
1533 However, leave prepare_to_modify_buffer alone. It's never
1534 called from outside this function, but that appears to be a bug.
1535 (combine_after_change_list, combine_after_change_buffer):
4889fc82 1536 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
1537 (adjust_after_replace_noundo): Remove; unused.
1538 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 1539 (signal_before_change): Remove decls.
77382fcc 1540
9306c32e
PE
1541 * indent.c (val_compute_motion, val_vmotion): Now static.
1542
cd44d2eb
PE
1543 * image.c: Make symbols static if they're not exported.
1544 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1545 if USE_GTK.
1546 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1547 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1548
ad9a7a06
PE
1549 * fringe.c (standard_bitmaps): Now static.
1550 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1551
81626931
PE
1552 * frame.c: Make symbols static if they're not exported.
1553 (x_report_frame_params, make_terminal_frame): Now static.
1554 (get_frame_param): Now static, unless HAVE_NS.
1555 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1556 (x_get_resource_string): Remove; not used.
1557 * frame.h (make_terminal_frame, x_report_frame_params):
1558 (x_get_resource_string); Remove decls.
1559 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1560 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1561
239f9db9
PE
1562 * font.c, fontset.c: Make symbols static if they're not exported.
1563 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1564 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1565 * font.c (font_close_object): Now static.
1566 * font.h (font_close_object): Remove.
1567 * fontset.c (FONTSET_OBJLIST): Remove.
1568 (free_realized_fontset) #if-0 the body, which does nothing.
1569 (face_suitable_for_char_p): #if-0, as it's never called.
1570 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
1571 * xfaces.c (face_at_string_position):
1572 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
1573 since 0 is always ASCII.
1574
dfcf3579
PE
1575 * fns.c (weak_hash_tables): Now static.
1576
5045092b
PE
1577 * fileio.c: Make symbols static if they're not exported.
1578 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1579 (Vwrite_region_annotation_buffers): Now static.
1580
57a96f5c
PE
1581 * eval.c: Make symbols static if they're not exported.
1582 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1583 * lisp.h (backtrace_list): Remove decl.
1584
35f08c38
PE
1585 * emacs.c: Make symbols static if they're not exported.
1586 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1587 (fatal_error_code, fatal_error_signal_hook, standard_args):
1588 Now static.
1589 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1590 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1591 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1592 * lisp.h (fatal_error_signal_hook): Remove decl.
1593 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1594
f44bd759
PE
1595 * editfns.c: Move a (normally-unused) function to its only use.
1596 * editfns.c, lisp.h (get_operating_system_release): Remove.
1597 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1598 worth the hassle of breaking this out.
1599
b532497d
PE
1600 * xterm.c: Make symbols static if they're not exported.
1601 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1602 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1603 (x_destroy_window, x_delete_display):
1604 Now static.
1605 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1606 (x_mouse_leave): Remove; unused.
1607 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1608 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1609 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1610 Remove decls.
1611 (x_mouse_leave): Declare only if WINDOWSNT.
1612 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1613 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1614 USE_X_TOOLKIT.
1615
1675728f
PE
1616 * ftxfont.c: Make symbols static if they're not exported.
1617 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1618 HAVE_FREETYPE.
1619 * font.h (ftxfont_driver): Likewise.
1620
e4cebfca
PE
1621 * xfns.c: Make symbols static if they're not exported.
1622 (x_last_font_name, x_display_info_for_name):
1623 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1624 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1625 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1626 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1627 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1628 (last_show_tip_args): Now static.
1629 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1630 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1631 (x_screen_planes): Remove; unused.
1632 * dispextern.h (x_screen_planes): Remove decl.
1633
5bf46f05
PE
1634 * dispnew.c: Make symbols static if they're not exported.
1635 * dispextern.h (redraw_garbaged_frames, scrolling):
1636 (increment_row_positions): Remove.
1637 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1638 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1639 Now static.
1640 (redraw_garbaged_frames): Remove; unused.
1641
435f4c28
PE
1642 * xfaces.c: Make symbols static if they're not exported.
1643 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1644 Remove decls.
1645 * xterm.h (defined_color): Remove decls.
1646 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1647 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1648 (menu_face_changed_default, defined_color, free_realized_face):
1649 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1650 (ascii_face_of_lisp_face): Remove; unused.
1651
8524aef3
PE
1652 * xdisp.c: Make symbols static if they're not exported.
1653 * dispextern.h (scratch_glyph_row, window_box_edges):
1654 (glyph_to_pixel_coords, set_cursor_from_row):
1655 (get_next_display_element, set_iterator_to_next):
1656 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1657 (show_mouse_face): Remove decls
1658 * frame.h (message_buf_print): Likewise.
1659 * lisp.h (pop_message, set_message, check_point_in_composition):
1660 Likewise.
1661 * xterm.h (set_vertical_scroll_bar): Likewise.
1662 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1663 (message_buf_print, scratch_glyph_row, displayed_buffer):
1664 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1665 (get_next_display_element, show_mouse_face, window_box_edges):
1666 (frame_to_window_pixel_xy, check_point_in_composition):
1667 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1668 (glyph_to_pixel_coords): Remove; unused.
1669
16390cd2
PE
1670 * dired.c (file_name_completion): Now static.
1671
1672 * dbusbind.c (xd_in_read_queued_messages): Now static.
1673
a25f4dfa
PE
1674 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1675 * data.c (circular_list_error): Remove.
1676
14a9c8df
PE
1677 * commands.h (last_point_position, last_point_position_buffer):
1678 (last_point_position_window): Remove decls.
1679 * keyboard.c: Make these variables static.
1680
04f2d78b
CB
1681 * coding.h (coding, code_convert_region, encode_coding_gap):
1682 Remove decls.
74ab6df5
PE
1683 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1684 (iso_code_class, detect_coding, code_convert_region): Now static.
1685 (encode_coding_gap): Remove; unused.
1686
38dfbee1
PE
1687 * chartab.c (chartab_chars, chartab_bits): Now static.
1688
a2cb4e63
PE
1689 * charset.h (charset_iso_8859_1): Remove decl.
1690 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1691 Now static.
1692
127198fd
PE
1693 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1694 * ccl.c (Vccl_program_table): Now static.
1695 (check_ccl_update): Remove; unused.
1696
d85b608f
PE
1697 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1698 * category.h: ... from here.
1699 * category.c (check_category_table, set_category_set): Now static.
1700
31cd66f3
PE
1701 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1702 * lisp.h: Remove these decls.
1703
c358e587
PE
1704 * buffer.c (buffer_count): Remove unused var.
1705
e78aecca
PE
1706 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1707 so that it's not optimized away.
1708 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1709 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1710 exported only to the debugger.
1711
e192d7d3 1712 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 1713 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 1714
92470028
PE
1715 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1716 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1717 was inaccessible from Lisp.
1718 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1719 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1720
244ed907
PE
1721 alloc.c: Import and export fewer symbols, and remove unused items.
1722 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1723 is defined.
1724 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1725 it's not optimized away by whole-program optimization.
1726 (message_enable_multibyte, free_misc): Remove.
1727 (catchlist, handlerlist, mark_backtrace):
1728 Declare only if BYTE_MARK_STACK.
1729 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1730 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1731 (message_enable_multibyte): Remove decl.
1732 (free_misc, interval_free_list, float_block, float_block_index):
1733 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1734 (cons_free_list, last_marked_index):
1735 Now static.
1736 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1737 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1738 (mark_backtrace): Define only if BYTE_MARK_STACK.
1739 * xdisp.c (message_enable_multibyte): Now static.
1740
61c2b50e 1741 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
1742 This makes it easier for human readers (and static analyzers)
1743 to see whether these variables are used from other modules.
1744 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1745 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1746 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1747 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1748 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1749 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1750 * xmenu.c, xselect.c:
1751 Declare Q* vars static if they are not used in other modules.
1752 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1753 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1754 Remove decls of unexported vars.
1755 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1756
95c82688
PE
1757 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1758
16a97296
PE
1759 Make Emacs functions such as Fatom 'static' by default.
1760 This makes it easier for human readers (and static analyzers)
1761 to see whether these functions can be called from other modules.
1762 DEFUN now defines a static function. To make the function external
1763 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
1764 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1765 (Finit_image_library):
16a97296
PE
1766 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1767 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1768 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1769 Remove decls, since these functions are now static.
1770 (Funintern, Fget_internal_run_time): New decls, since these functions
1771 were already external.
95c82688 1772
16a97296
PE
1773 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1774 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1775 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1776 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1777 * keyboard.c, keymap.c, lread.c:
1778 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1779 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1780 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1781 Mark functions with DEFUE instead of DEFUN,
1782 if they are used in other modules.
1783 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1784 decls for now-static functions.
1785 * buffer.h (Fdelete_overlay): Remove decl.
1786 * callproc.c (Fgetenv_internal): Mark as internal.
1787 * composite.c (Fremove_list_of_text_properties): Remove decl.
1788 (Fcomposition_get_gstring): New forward static decl.
1789 * composite.h (Fcomposite_get_gstring): Remove decl.
1790 * dired.c (Ffile_attributes): New forward static decl.
1791 * doc.c (Fdocumntation_property): New forward static decl.
1792 * eval.c (Ffetch_bytecode): New forward static decl.
1793 (Funintern): Remove extern decl; now in .h file where it belongs.
1794 * fileio.c (Fmake_symbolic_link): New forward static decl.
1795 * image.c (Finit_image_library): New forward static decl.
1796 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1797 * intervals.h (Fprevious_property_change):
1798 (Fremove_list_of_text_properties): Remove decls.
1799 * keyboard.c (Fthis_command_keys): Remove decl.
1800 (Fcommand_execute): New forward static decl.
1801 * keymap.c (Flookup_key): New forward static decl.
1802 (Fcopy_keymap): Now static.
1803 * keymap.h (Flookup_key): Remove decl.
1804 * process.c (Fget_process): New forward static decl.
1805 (Fprocess_datagram_address): Mark as internal.
1806 * syntax.c (Fsyntax_table_p): New forward static decl.
1807 (skip_chars): Remove duplicate decl.
1808 * textprop.c (Fprevious_property_change): New forward static decl.
1809 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1810 Now internal.
1811 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1812 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1813
785bbd42
PE
1814 * editfns.c (Fformat): Remove unreachable code.
1815
8b913b57
AS
18162011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1817
1818 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1819 change. (Bug#8496)
1820
a6744a35
EZ
18212011-04-13 Eli Zaretskii <eliz@gnu.org>
1822
1823 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1824 when at ZV. (Bug#8487)
1825
e7974947
AS
18262011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1827
baad03f0
AS
1828 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1829 (Bug#8437)
1830 * keyboard.c (parse_tool_bar_item): Likewise.
1831 * sound.c (sound_cleanup, alsa_close): Likewise.
1832 * termcap.c (tgetent): Likewise.
1833 * xfns.c (x_default_font_parameter): Likewise.
1834 * xsettings.c (read_and_apply_settings): Likewise.
1835
e7974947
AS
1836 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1837 (overrun_check_free): Protoize.
1838
28272684
PE
18392011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1840
1841 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1842 since callers should never pass a negative size.
1843 Change the signature to match that of plain 'read' and 'write'; see
1844 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1845 * lisp.h: Update prototypes of emacs_write and emacs_read.
1846
11997c76
EZ
18472011-04-11 Eli Zaretskii <eliz@gnu.org>
1848
1849 * xdisp.c (redisplay_window): Don't try to determine the character
1850 position of the scroll margin if the window start point w->startp
e896f03c 1851 is outside the buffer's accessible region. (Bug#8468)
11997c76 1852
8a2cbd72
EZ
18532011-04-10 Eli Zaretskii <eliz@gnu.org>
1854
1855 Fix write-region and its subroutines for buffers > 2GB.
1856 * fileio.c (a_write, e_write): Modify declaration of arguments and
1857 local variables to support buffers larger than 2GB.
1858 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1859
1860 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1861 argument, local variables, and return value.
1862
1863 * lisp.h: Update prototypes of emacs_write and emacs_read.
1864
1865 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1866
4073e537 18672011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1868
1ebfdcb6
PE
1869 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1870
b2ded58d
PE
1871 Fix more problems found by GCC 4.6.0's static checks.
1872
7d66342c
PE
1873 * xdisp.c (vmessage): Use a better test for character truncation.
1874
bbf47d44
PE
1875 * charset.c (load_charset_map): <, not <=, for optimization,
1876 and to avoid potential problems with integer overflow.
9248994d 1877 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1878 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1879 * editfns.c (Fformat): Likewise.
1e69125e 1880 * syntax.c (skip_chars): Likewise.
3befa583 1881
e3019616
PE
1882 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1883 This also lets GCC 4.6.0 generate slightly better loop code.
1884
becfa255
PE
1885 * callint.c (Fcall_interactively): <, not <=, for optimization.
1886 (Fcall_interactively): Count the number of arguments produced,
1887 not the number of arguments given. This is simpler and lets GCC
1888 4.6.0 generate slightly better code.
1889
dae0cd48
PE
1890 * ftfont.c: Distingish more carefully between FcChar8 and char.
1891 The previous code passed unsigned char * to a functions like
1892 strlen and xstrcasecmp that expect char *, which does not
1893 conform to the C standard.
1894 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1895 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1896 char * when the C standard requires it.
1897
76032d70
PE
1898 * keyboard.c (read_char): Remove unused var.
1899
eb3f1cc8
PE
1900 * eval.c: Port to Windows vsnprintf (Bug#8435).
1901 Include <limits.h>.
1902 (SIZE_MAX): Define if the headers do not.
1903 (verror): Do not give up if vsnprintf returns a negative count.
1904 Instead, grow the buffer. This ports to Windows vsnprintf, which
1905 does not conform to C99. Problem reported by Eli Zaretskii.
1906 Also, simplify the allocation scheme, by avoiding the need for
1907 calling realloc, and removing the ALLOCATED variable.
1908
70476b54
PE
1909 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1910
12020a9e
PE
1911 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1912 But keep the doprint source code for now, as we might revamp it
1913 and use it again (Bug#8435).
ea6c7ae6
PE
1914 * lisp.h (doprnt): Remove.
1915 * Makefile.in (base_obj): Remove doprnt.o.
1916 * deps.mk (doprnt.o): Remove.
1917
5fdb398c
PE
1918 error: Print 32- and 64-bit integers portably (Bug#8435).
1919 Without this change, on typical 64-bit hosts error ("...%d...", N)
1920 was used to print both 32- and 64-bit integers N, which relied on
1921 undefined behavior.
1922 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1923 New macro.
1924 * lisp.h (error, verror): Mark as printf-like functions.
1925 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1926 Report overflow in size calculations when allocating printf buffer.
1927 Do not truncate output string at its first null byte.
1928 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1929 Truncate the output at a character boundary, since vsnprintf does not
1930 do that.
1931 * charset.c (check_iso_charset_parameter): Convert internal
1932 character to string before calling 'error', since %c now has the
1933 printf meaning.
1934 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1935 overflow when computing char to be passed to 'error'. Do not
1936 pass Lisp_Object to 'error'; pass the integer instead.
1937 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1938 formatted with plain %d.
1939
b189fa66
PE
1940 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1941
bff87ef0
PE
1942 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1943
7e2cac20
PE
1944 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1945
ce4d90b5
PE
1946 * xterm.c (x_catch_errors): Remove duplicate declaration.
1947
266c9547
PE
1948 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1949
79c49ad2
PE
1950 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1951
368f4090
JM
19522011-04-10 Jim Meyering <meyering@redhat.com>
1953
1954 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1955 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1956 return ssize_t not "int", and use size_t as the buffer length.
1957 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1958 * gnutls.h: Update declarations.
1959 * process.c (read_process_output): Use ssize_t, to match.
1960 (send_process): Likewise.
1961
a32d4040
CY
19622011-04-09 Chong Yidong <cyd@stupidchicken.com>
1963
1964 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1965
8546720e 19662011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1967
04f2d78b
CB
1968 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1969 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 1970
8546720e
GM
1971 * xterm.c (handle_one_xevent):
1972 * xmenu.c (create_and_show_popup_menu):
1973 * xselect.c (x_decline_selection_request)
1974 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1975
0a2f5c1a 19762011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1977
1978 Fix some uses of `int' instead of EMACS_INT.
1979 * search.c (string_match_1, fast_string_match)
1980 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1981 (scan_buffer, find_next_newline_no_quit)
1982 (find_before_next_newline, search_command, Freplace_match)
1983 (Fmatch_data): Make some `int' variables be EMACS_INT.
1984
1985 * xdisp.c (display_count_lines): 3rd argument and return value now
1986 EMACS_INT. All callers changed.
1987 (pint2hrstr): Last argument is now EMACS_INT.
1988
1989 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1990 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1991 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1992 (decode_coding_utf_16, decode_coding_emacs_mule)
1993 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1994 (decode_coding_ccl, decode_coding_charset)
1995 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1996 (decode_coding_iso_2022, decode_coding_emacs_mule)
1997 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1998 <char_offset, last_offset>: Declare EMACS_INT.
1999 (encode_coding_utf_8, encode_coding_utf_16)
2000 (encode_coding_emacs_mule, encode_invocation_designation)
2001 (encode_designation_at_bol, encode_coding_iso_2022)
2002 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2003 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2004 Declare EMACS_INT.
2005 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2006 (encode_invocation_designation): Last argument P_NCHARS is now
2007 EMACS_INT.
2008 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2009 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2010
2011 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2012 All users changed.
2013
2014 * ccl.c (Fccl_execute_on_string): Declare some variables
2015 EMACS_INT.
2016
8546720e 20172011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2018
2019 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2020
4e19a977
CS
20212011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2022
2023 * process.c (Fformat_network_address): Doc fix.
2024
87302331
R
20252011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2026
2027 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2028
cbb59342
CY
20292011-04-08 Chong Yidong <cyd@stupidchicken.com>
2030
2031 * keyboard.c (read_char): Call Lisp function help-form-show,
2032 instead of using internal_with_output_to_temp_buffer.
2033 (Qhelp_form_show): New var.
e0d38eeb 2034 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2035
2036 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2037
2038 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2039
e67a13ab
CY
20402011-04-06 Chong Yidong <cyd@stupidchicken.com>
2041
04f2d78b
CB
2042 * process.c (Flist_processes): Remove to Lisp.
2043 (list_processes_1): Delete.
e67a13ab 2044
973f782d
EZ
20452011-04-06 Eli Zaretskii <eliz@gnu.org>
2046
7c106b1e
EZ
2047 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2048
973f782d
EZ
2049 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2050
41cf7d1a 20512011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2052
ca23cc88
PE
2053 Fix more problems found by GCC 4.6.0's static checks.
2054
f390e2d5
PE
2055 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2056
42eea0d0
PE
2057 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2058
b69769da 2059 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2060
f9541e84
PE
2061 * xdisp.c (vmessage): Mark as a printf-like function.
2062
13841b55
PE
2063 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2064
c136c10f
PE
2065 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2066
5e2d4a30
PE
2067 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2068 printf-like functions.
2069 (tiff_load): Add casts to remove these marks before passing them
2070 to system-supplied API.
2071
583f48b9
PE
2072 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2073
b25d760e
PE
2074 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2075 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2076 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2077 directly, rather than having caller test rule sign. This avoids
2078 some unnecessary tests.
2079 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2080 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2081 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2082
bc7b6697 2083 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2084 (xfont_open): Avoid unnecessary tests.
bc7b6697 2085
27ccc379
PE
2086 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2087
dcd5c89a
PE
2088 * composite.h, composite.c (composition_gstring_put_cache):
2089 Use EMACS_INT, not int, for length.
2090
b13a45c6
PE
2091 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2092 breaking out part of COMPOSITION_DECODE_RULE.
2093 (COMPOSITION_DECODE_RULE): Use it.
2094 * composite.c (get_composition_id): Remove unused local vars,
2095 by using the new macro.
2096
1e792e4d
PE
2097 * textprop.c (set_text_properties_1): Change while to do-while,
2098 since the condition is always true at first.
2099
dc6c6455 2100 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2101 (interval_deletion_adjustment): Return unsigned value.
2102 All uses changed.
dc6c6455 2103
aba7731a
PE
2104 * process.c (list_processes_1, create_pty, read_process_output):
2105 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2106 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2107 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2108 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2109 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2110
fdfc4bf3
PE
2111 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2112
fca8fe46 2113 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2114 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2115
06a0259a 2116 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2117 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2118 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2119
e7b9e80f
PE
2120 * print.c (print_error_message): Avoid int overflow.
2121
56201685
PE
2122 * font.c (font_list_entities): Redo for clarity,
2123 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2124
78834453 2125 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2126 (font_score): Avoid potential overflow in diff calculation.
78834453 2127
0bc0b309 2128 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2129 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2130
e610eaca
PE
2131 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2132
b895abce
PE
2133 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2134 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2135 can always succeed if overflow has undefined behavior.
2136
1f1d9321 2137 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2138 (wordify): Omit three unnecessary tests.
1f1d9321 2139
c59478bc
PE
2140 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2141 All callers changed. This avoids the need for an unused var.
2142
79b73827
PE
2143 * casefiddle.c (casify_region): Remove var that is set but not used.
2144
a4db5dfe
PE
2145 * dired.c (file_name_completion): Remove var that is set but not used.
2146
43aae36e
PE
2147 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2148
2a47c44d 2149 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2150 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2151
a37c69bf
PE
2152 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2153 Check for integer overflow on size calculations.
2154
328ab8e7
PE
2155 * buffer.c (Fprevious_overlay_change): Remove var that is set
2156 but not used.
2157
e5a2a5cb
PE
2158 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2159 Remove vars that are set but not used.
8d84a6eb 2160 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2161 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2162
a60e5f68
PE
2163 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2164
f661cb61 2165 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2166 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2167
f0397f5a
PE
2168 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2169 that are set but not used.
2170
8664db06 2171 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2172 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2173
6abdaa4a
PE
2174 * xselect.c (x_get_local_selection, x_handle_property_notify):
2175 Remove vars that are set but not used.
2176
0ce7538d 2177 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2178 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2179
9ae848fc
PE
2180 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2181 Remove var that is set but not used.
0b918413
PE
2182 (scroll_bar_windows_size): Now size_t, not int.
2183 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2184 Check for overflow.
9ae848fc 2185
a5a62657
PE
2186 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2187 (map_tty_color) [!defined MSDOS]: Likewise.
2188
5c5cdd39
PE
2189 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2190
66ebf983
PE
2191 * coding.c: Remove vars that are set but not used.
2192 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2193 All callers changed.
2194 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2195 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2196 (decode_coding_charset): Remove vars that are set but not used.
2197
1be4d761
PE
2198 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2199 that is set but not used.
2200
47553fa8
PE
2201 * print.c (print_object): Remove var that is set but not used.
2202
1f7196bf 2203 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2204 The gnulib version avoids calling malloc in the usual case,
2205 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2206 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2207 * filelock.c (current_lock_owner): Likewise.
2208 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2209 * sysdep.c: Include allocator.h, careadlinkat.h.
2210 (emacs_no_realloc_allocator): New static constant.
2211 (emacs_readlink): New function.
fdb61804
PE
2212 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2213 ../lib/careadlinkat.h.
d1fdcab7 2214
f84c17c7
SM
22152011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2216
2217 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2218 first non-nil return value).
2219
ef3862ad
JD
22202011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2221
2222 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2223 if not defined (Bug#8403).
2224
376a7006
JB
22252011-04-02 Juanma Barranquero <lekktu@gmail.com>
2226
2227 * xdisp.c (display_count_lines): Remove parameter `start',
2228 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2229 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2230 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2231 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2232 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2233 and thereabouts. All callers changed.
2234 (get_per_char_metric): Remove parameter `f', unused since
2235 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2236
6ca3801d
JM
22372011-04-02 Jim Meyering <meyering@redhat.com>
2238
2239 do not dereference NULL upon failed strdup
2240 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2241 (ns_get_family): Likewise.
2242
d8e2b5ba
JB
22432011-04-02 Juanma Barranquero <lekktu@gmail.com>
2244
2245 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2246
8c74fcbd
JD
22472011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2248
2249 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2250 later (Bug#8403).
2251
7200d79c
SM
22522011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2253
03408648 2254 Add lexical binding.
7200d79c 2255
03408648
SM
2256 * window.c (Ftemp_output_buffer_show): New fun.
2257 (Fsave_window_excursion):
2258 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2259
2260 * lread.c (lisp_file_lexically_bound_p): New function.
2261 (Fload): Bind Qlexical_binding.
2262 (readevalloop): Remove `evalfun' arg.
2263 Bind Qinternal_interpreter_environment.
2264 (Feval_buffer): Bind Qlexical_binding.
2265 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2266 Mark as dynamic.
2267 (syms_of_lread): Declare `lexical-binding'.
2268
2269 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2270
2271 * keyboard.c (eval_dyn): New fun.
2272 (menu_item_eval_property): Use it.
ca105506
SM
2273
2274 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 2275
03408648
SM
2276 * fns.c (concat, mapcar1): Accept byte-code-functions.
2277
2278 * eval.c (Fsetq): Handle lexical vars.
2279 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2280 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2281 (FletX, Flet): Obey lexical binding.
2282 (Fcommandp): Handle closures.
2283 (Feval): New `lexical' arg.
2284 (eval_sub): New function extracted from Feval. Use it almost
2285 everywhere where Feval was used. Look up vars in lexical env.
2286 Handle closures.
2287 (Ffunctionp): Move from subr.el.
2288 (Ffuncall): Handle closures.
2289 (apply_lambda): Remove `eval_flags'.
2290 (funcall_lambda): Handle closures and new byte-code-functions.
2291 (Fspecial_variable_p): New function.
2292 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2293 but without exporting it to Lisp.
23aba0ea 2294
23aba0ea 2295 * doc.c (Fdocumentation, store_function_docstring):
03408648 2296 * data.c (Finteractive_form): Handle closures.
23aba0ea 2297
03408648
SM
2298 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2299 interactive spec.
ba83908c 2300
04f2d78b
CB
2301 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2302 New byte-codes.
03408648
SM
2303 (exec_byte_code): New function extracted from Fbyte_code to handle new
2304 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 2305
03408648 2306 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 2307
03408648 2308 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 2309
e2abce01
JB
23102011-03-31 Juanma Barranquero <lekktu@gmail.com>
2311
2312 * xdisp.c (redisplay_internal): Fix prototype.
2313
63696a73 23142011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 2315
63696a73 2316 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
2317 (try_scrolling): Use it when setting scroll_limit.
2318 Limit scrolling to 100 screen lines.
63696a73
EZ
2319 (redisplay_window): Even when falling back on "recentering",
2320 position point in the window according to scroll-conservatively,
2321 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2322
2323 (try_scrolling): When point is above the window, allow searching
2324 as far as scroll_max, or one screenful, to compute vertical
2325 distance from PT to the scroll margin position. This prevents
2326 try_scrolling from unnecessarily failing when
2327 scroll-conservatively is set to a value slightly larger than the
2328 window height. Clean up the case of PT below the margin at bottom
2329 of window: scroll_max can no longer be INT_MAX. When aggressive
2330 scrolling is in use, don't let point enter the opposite scroll
2331 margin as result of the scroll.
2332 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
2333 threshold of 100 lines for never-recentering scrolling.
2334
e4cc2dfc
JB
23352011-03-31 Juanma Barranquero <lekktu@gmail.com>
2336
2337 * dispextern.h (move_it_by_lines):
2338 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2339 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2340 (message_log_check_duplicate): Remove parameters `prev_bol' and
2341 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2342 (redisplay_internal): Remove parameter `preserve_echo_area',
2343 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2344
2345 * indent.c (Fvertical_motion):
2346 * window.c (window_scroll_pixel_based, Frecenter):
2347 Don't pass `need_y_p' to `move_it_by_lines'.
2348
1c470562
SM
23492011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2350
44f230aa
SM
2351 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2352 steal a few bits to be more compact.
2353 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2354 Remove unneeded casts.
2355
1c470562
SM
2356 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2357
888adce9
ZK
23582011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2359
2360 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2361 binding" message (bug#7967).
2362
f838ed7b
PE
23632011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2364
77861b95
PE
2365 Fix more problems found by GCC 4.6.0's static checks.
2366
de6dbc14
PE
2367 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2368 Remove unused local var.
2369
f838ed7b
PE
2370 * editfns.c (Fmessage_box): Remove unused local var.
2371
792c7b2b
PE
2372 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2373 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2374 Omit unused local vars.
c499e557 2375 * window.c (shrink_windows): Omit unused local var.
b01a1c29 2376 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
2377 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2378 Omit unused local var.
2379
ba0165e1
PE
2380 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2381 Don't assume string length fits in int.
32ad8845 2382 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 2383 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 2384
3c59b4c9
PE
2385 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2386 instead of alloca (Bug#8344).
2387
a3eed478 2388 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 2389 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 2390
eb4d412d
PE
2391 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2392
1658b401
PE
2393 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2394 concerns.
2395
2396 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2397
2398 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 2399
9a2c6e05
PE
2400 * keyboard.c (syms_of_keyboard): Use the same style as later
2401 in this function when indexing through an array. This also
2402 works around GCC bug 48267.
2403
03d0a109
PE
2404 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2405
44f730c8
PE
2406 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2407
fe75f926
PE
2408 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2409 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2410
ffa8c828
PE
2411 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2412 This avoids undefined behavior on integer overflow, and is a bit
2413 more convenient anyway since it is compared to a size_t variable.
2414
c5101a77
PE
2415 Variadic C functions now count arguments with size_t, not int.
2416 This avoids an unnecessary limitation on 64-bit machines, which
2417 caused (substring ...) to crash on large vectors (Bug#8344).
2418 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2419 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 2420 All variadic functions and their callers changed accordingly.
c5101a77
PE
2421 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2422 * data.c (arith_driver, float_arith_driver): Likewise.
2423 * editfns.c (general_insert_function): Likewise.
2424 * eval.c (struct backtrace.nargs, interactive_p)
2425 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2426 (funcall_lambda, mark_backtrace): Likewise.
2427 * fns.c (concat): Likewise.
2428 * frame.c (x_set_frame_parameters): Likewise.
2429 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2430 0 if not found, not -1. All callers changed.
2431
dd3f25f7
PE
2432 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2433 (stack_copy_size): Now size_t, not int.
2434 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2435
461c2ab9
JB
24362011-03-28 Juanma Barranquero <lekktu@gmail.com>
2437
2438 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2439 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2440 All callers changed.
2441
2442 * lisp.h (multibyte_char_to_unibyte):
2443 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2444 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2445 * character.h (CHAR_TO_BYTE8):
2446 * cmds.c (internal_self_insert):
2447 * editfns.c (general_insert_function):
2448 * keymap.c (push_key_description):
2449 * search.c (Freplace_match):
2450 * xdisp.c (message_dolog, set_message_1): All callers changed.
2451
f6d62986
SM
24522011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2453
2454 * keyboard.c (safe_run_hook_funcall): New function.
2455 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2456 don't set the hook to nil, but remove the offending function instead.
2457 (Qcommand_hook_internal): Remove, unused.
2458 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2459 Vcommand_hook_internal.
2460
2461 * eval.c (enum run_hooks_condition): Remove.
2462 (funcall_nil, funcall_not): New functions.
2463 (run_hook_with_args): Call each function through a `funcall' argument.
2464 Remove `cond' argument, now redundant.
2465 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2466 (Frun_hook_with_args_until_failure): Adjust accordingly.
2467 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2468
1db5b1ad
JB
24692011-03-28 Juanma Barranquero <lekktu@gmail.com>
2470
2471 * dispextern.h (string_buffer_position): Remove declaration.
2472
2473 * print.c (strout): Remove parameter `multibyte', unused since
2474 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2475
2476 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2477 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2478 All callers changed.
2479
2480 * w32.c (_wsa_errlist): Use braces for struct initializers.
2481
2482 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2483 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2484 All callers changed.
2485 (string_buffer_position): Likewise. Also, make static (it's never
2486 used outside xdisp.c).
2487 (cursor_row_p): Remove parameter `w', unused since
2488 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2489 (decode_mode_spec): Remove parameter `precision', introduced during
2490 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2491 All callers changed.
2492
5ffb62aa
JD
24932011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2494
2495 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2496
461c2ab9 24972011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
2498
2499 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2500 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2501 (ns_update_auto_hide_menu_bar): New functions.
2502 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2503 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2504 ns_constrain_all_frames.
2505 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2506 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2507
5c380ffb
JD
25082011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2509
2510 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2511
9af30bdf
GM
25122011-03-27 Glenn Morris <rgm@gnu.org>
2513
2514 * syssignal.h: Replace RETSIGTYPE with void.
2515 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2516 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2517 Replace SIGTYPE with void everywhere.
2518 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2519 * s/template.h (SIGTYPE): Remove commented out definition.
2520
e2abce01
JB
25212011-03-26 Eli Zaretskii <eliz@gnu.org>
2522
2523 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2524 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2525
f868cd8a
JB
25262011-03-26 Juanma Barranquero <lekktu@gmail.com>
2527
59eb0929
JB
2528 * w32.c (read_unc_volume): Use parameter `henum', instead of
2529 global variable `wget_enum_handle'.
2530
2531 * keymap.c (describe_vector): Remove parameters `indices' and
2532 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2533 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2534
f868cd8a
JB
2535 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2536
2537 * keyboard.c (timer_check): Remove parameter `do_it_now',
2538 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2539 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2540 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2541
2542 * keyboard.c (read_char):
2543 * w32menu.c (w32_menu_display_help):
2544 * xmenu.c (show_help_event, menu_help_callback):
2545 Adjust calls to `show_help_echo'.
2546
2547 * gtkutil.c (xg_maybe_add_timer):
2548 * keyboard.c (readable_events):
2549 * process.c (wait_reading_process_output):
2550 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2551
2552 * insdel.c (adjust_markers_gap_motion):
2553 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2554 (gap_left, gap_right): Don't call it.
2555
2ecf6fdb
CY
25562011-03-25 Chong Yidong <cyd@stupidchicken.com>
2557
2558 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2559 incurred during fontification.
2560
6b1f9ba4
JB
25612011-03-25 Juanma Barranquero <lekktu@gmail.com>
2562
2563 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2564 (DEFVAR_PER_BUFFER): Don't pass it.
2565
2566 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2567 (scrolling_window): Don't pass it.
2568
0f4a96b5
JB
25692011-03-25 Juanma Barranquero <lekktu@gmail.com>
2570
2571 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2572
2573 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2574 and `suffix'.
2575 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2576 of variables specific to SELinux and computation of `encoded_absname'.
2577
2578 * image.c (XPutPixel): Remove unused variable `height'.
2579
2580 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2581
2582 * unexw32.c (get_section_info): Remove unused variable `section'.
2583
2584 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2585 (system_process_attributes): Remove unused variable `sess'.
2586 (sys_read): Remove unused variable `err'.
2587
2588 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2589 (w32_wnd_proc): Remove unused variable `isdead'.
2590 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2591 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2592 (x_create_tip_frame): Remove unused variable `tem'.
2593
2594 * w32inevt.c (w32_console_read_socket):
2595 Remove unused variable `no_events'.
2596
2597 * w32term.c (x_draw_composite_glyph_string_foreground):
2598 Remove unused variable `width'.
2599
1149507c
JB
26002011-03-24 Juanma Barranquero <lekktu@gmail.com>
2601
2602 * w32term.c (x_set_glyph_string_clipping):
2603 Don't pass uninitialized region to CombineRgn.
2604
9c88f339
JB
26052011-03-23 Juanma Barranquero <lekktu@gmail.com>
2606
2607 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2608 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2609 (Fx_close_connection): Remove unused variable `i'.
2610
2611 * w32font.c (w32font_draw): Return number of glyphs.
2612 (w32font_open_internal): Remove unused variable `i'.
2613 (w32font_driver): Add missing initializer.
2614
2615 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2616 (fill_in_menu): Remove unused variable `items_added'.
2617
2618 * w32term.c (last_mouse_press_frame): Remove static global variable.
2619 (w32_clip_to_row): Remove unused variable `f'.
2620 (x_delete_terminal): Remove unused variable `i'.
2621
2622 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2623 (NOTHING): Remove unused static global variable.
2624 (uniscribe_check_otf): Remove unused variable `table'.
2625 (uniscribe_font_driver): Add missing initializers.
2626
dee091a3
JD
26272011-03-23 Julien Danjou <julien@danjou.info>
2628
2629 * term.c (Fsuspend_tty, Fresume_tty):
2630 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2631 * window.c (temp_output_buffer_show):
2632 * insdel.c (signal_before_change):
2633 * frame.c (Fhandle_switch_frame):
2634 * fileio.c (Fdo_auto_save):
2635 * emacs.c (Fkill_emacs):
2636 * editfns.c (save_excursion_restore):
2637 * cmds.c (internal_self_insert):
2638 * callint.c (Fcall_interactively):
2639 * buffer.c (Fkill_all_local_variables):
2640 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2641 Use Frun_hooks.
0f4a96b5 2642 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
2643 unconditionnaly since it does the check itself.
2644
2c520ab5 26452011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 2646
c9c49752
PE
2647 Fix more problems found by GCC 4.5.2's static checks.
2648
8abc3f12
PE
2649 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2650 the first time through the loop, since we know p0 < p1 then.
2651 This also avoids a gcc -Wstrict-overflow warning.
2652
a2d26660
PE
2653 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2654 leading to a memory leak, possible in functions like
2655 load_charset_map_from_file that can allocate an unbounded number
b12ef411 2656 of objects (Bug#8318).
a2d26660 2657
916c72e9
PE
2658 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2659 that could (at least in theory) be that large.
2660
19ab8a18
PE
2661 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2662 This is less likely to overflow, and avoids undefined behavior if
2663 overflow does occur. All callers changed. Use strtoul to scan
2664 for the unsigned long integer.
b7cbbd6f
PE
2665 (pint2hrstr): Simplify and tune code slightly.
2666 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 2667
f0641eff
PE
2668 * scroll.c (do_scrolling): Work around GCC bug 48228.
2669 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2670
7f650bb9
PE
2671 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2672 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
2673 (validate_x_resource_name): Simplify count usage.
2674 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 2675
37dd57d1
PE
2676 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2677 fail (Bug#8306).
81e56e61 2678
699979fc 2679 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 2680
401bf9b4
PE
2681 * process.c (Fmake_network_process): Use socklen_t, not int,
2682 where POSIX says socklen_t is required in portable programs.
2683 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 2684 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
2685 (Fmake_network_process, server_accept_connection):
2686 (wait_reading_process_output, read_process_output):
2687 Likewise.
2688
b93aacde
PE
2689 * process.c: Rename or move locals to avoid shadowing.
2690 (list_processes_1, Fmake_network_process):
2691 (read_process_output_error_handler, exec_sentinel_error_handler):
2692 Rename or move locals.
4dc343ee 2693 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 2694 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 2695 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 2696 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 2697 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 2698
af8a867c 2699 Make tparam.h and terminfo.c consistent.
44f230aa
SM
2700 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2701 Include tparam.h instead, since it declares them.
af8a867c
PE
2702 * cm.h (PC): Remove extern decl; tparam.h now does this.
2703 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2704 * terminfo.c: Include tparam.h, to check interfaces.
2705 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2706 (tparam): Adjust signature to match interface in tparam.h;
2707 this removes some undefined behavior. Check that outstring and len
2708 are zero, which they always are with Emacs.
2709 * tparam.h (PC, BC, UP): New extern decls.
2710
0248044d 2711 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 2712 (xftfont_open): Rename locals to avoid shadowing.
0248044d 2713
8ff096c1 2714 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
2715 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2716 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 2717 (ftfont_list): Remove unused local.
49eaafba
PE
2718 (get_adstyle_property, ftfont_pattern_entity):
2719 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2720 Rename locals to avoid shadowing.
8ff096c1 2721
e2be39f6
PE
2722 * xfont.c (xfont_list_family): Mark var as initialized.
2723
c9735e30
PE
2724 * xml.c (make_dom): Now static.
2725
8f5201ae
PE
2726 * composite.c (composition_compute_stop_pos): Rename local to
2727 avoid shadowing.
b246f932
PE
2728 (composition_reseat_it): Remove unused locals.
2729 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 2730 (composition_update_it): Mark var as initialized.
11b61122
PE
2731 (find_automatic_composition): Mark vars as initialized,
2732 with a FIXME (Bug#8290).
8f5201ae 2733
760fbc2c
PE
2734 character.h: Rename locals to avoid shadowing.
2735 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2736 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2737 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2738 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2739 to avoid shadowing.
2740
ff08eb85
PE
2741 * textprop.c (property_change_between_p): Remove; unused.
2742
fc7bf025
PE
2743 * intervals.c (interval_start_pos): Now static.
2744
235d7abc
PE
2745 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2746
44f230aa
SM
2747 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2748 Rename locals to avoid shadowing.
3e7d6594 2749
50060332
PE
2750 * sound.c (wav_play, au_play, Fplay_sound_internal):
2751 Fix pointer signedness.
d01f234b 2752 (alsa_choose_format): Remove unused local var.
c83b8872
PE
2753 (wav_play): Initialize a variable to 0, to prevent undefined
2754 behavior (Bug#8278).
50060332 2755
c4fc4e30
PE
2756 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2757
918436ed
PE
2758 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2759
c939f91b
PE
2760 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2761 clobbering (Bug#8298).
b9c7f648
PE
2762 * sysdep.c (sys_subshell): Likewise.
2763 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 2764
6bd8c144
PE
2765 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2766 This should get cleaned up, so that child_setup has the
2767 same signature on all platforms.
2768
7710357c 2769 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 2770 (relocate_fd): Rename locals to avoid shadowing.
7710357c 2771
c59da222
CY
27722011-03-22 Chong Yidong <cyd@stupidchicken.com>
2773
2774 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2775 not to be necessary, and produces flickering.
2776
66b87493
GM
27772011-03-20 Glenn Morris <rgm@gnu.org>
2778
2779 * config.in: Remove file.
2780
45b6f6d5
JB
27812011-03-20 Juanma Barranquero <lekktu@gmail.com>
2782
2783 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2784 are now in src/globals.h.
2785 (syms_of_minibuf): Remove spurious & from previous change.
2786
3ec03f7e
LL
27872011-03-20 Leo <sdl.web@gmail.com>
2788
2789 * minibuf.c (completing-read-function): New variable.
2790 (completing-read-default): Rename from completing-read.
2791 (completing-read): Call completing-read-function.
2792
b14e3e21
CY
27932011-03-19 Juanma Barranquero <lekktu@gmail.com>
2794
2795 * xfaces.c (Fx_load_color_file):
2796 Read color file from absolute filename (bug#8250).
2797
f2b726e6
JB
27982011-03-19 Juanma Barranquero <lekktu@gmail.com>
2799
2800 * makefile.w32-in: Update dependencies.
2801
09f6ff02
EZ
28022011-03-17 Eli Zaretskii <eliz@gnu.org>
2803
2804 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2805
29a6015a
PE
28062011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2807
a3a6c54e
PE
2808 Fix more problems found by GCC 4.5.2's static checks.
2809
b766f867
PE
2810 * process.c (make_serial_process_unwind, send_process_trap):
2811 (sigchld_handler): Now static.
2812
be02381c
PE
2813 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2814 That way, the code declares only the vars that it needs.
2815 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2816 * s/cygwin.h (PTY_ITERATION): Likewise.
2817 * s/darwin.h (PTY_ITERATION): Likewise.
2818 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2819
57048744
PE
2820 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2821 * process.c (allocate_pty): Don't declare stb unless it's needed.
2822
7914961c 2823 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2824 (CONSTANTLIM): Remove; unused.
2825 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2826 Define only if needed.
7914961c 2827
b3967b18
PE
2828 * unexelf.c (unexec): Name an expression,
2829 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2830 Use a different way to cause a compilation error if anyone uses
2831 n rather than nn, a way that does not involve shadowing.
73366a00 2832 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2833
29a6015a
PE
2834 * deps.mk (unexalpha.o): Remove; unused.
2835
43cfc33e 2836 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2837 * unexec.h: New file.
ce701a33
PE
2838 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2839 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2840 Depend on unexec.h.
2841 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2842 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2843 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2844 Change as necessary to match prototype in unexec.h.
ce701a33 2845
01f44d5a
PE
2846 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2847 shadowing.
4f63c6bb 2848 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2849
a6670b0b
PE
2850 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2851 Rename locals to avoid shadowing.
2852
cef2010d 2853 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2854 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2855
d4d7173a
PE
2856 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2857
f08b802a
PE
2858 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2859 warning when compiling print.c.
2860
3ddb0639
PE
2861 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2862 instead of using an uninitialized var.
5ad03b97 2863 (font_sort_entities): Mark var as initialized.
3ddb0639 2864
170a2692
PE
2865 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2866
e663c700
PE
2867 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2868 pointers to constants.
89bc529a 2869 (font_parse_fcname): Remove unused vars.
7b81e2d0 2870 (font_delete_unmatched): Now static.
ea838e10 2871 (font_get_spec): Remove; unused.
13a547c6
PE
2872 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2873 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2874 Rename or move locals to avoid shadowing.
e663c700 2875
2a80c887 2876 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2877 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2878
1384fa33 2879 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2880 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2881
8b2c52e9
PE
2882 * alloc.c (mark_backtrace): Move decl from here ...
2883 * lisp.h: ... to here, so that it can be checked.
2884
475545b5 2885 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2886 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2887 (lisp_indirect_variable): Name an expression,
2888 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2889 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2890
b1349114 2891 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2892 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2893 Use const pointer when appropriate.
b1349114 2894
a2928364
PE
2895 * lisp.h (get_system_name, get_operating_system_release):
2896 Move decls here, to check interfaces.
2897 * process.c (get_operating_system_release): Move decl to lisp.h.
2898 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2899 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2900 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2901 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2902 (Fformat_time_string, Fencode_time, Finsert_char):
2903 (Ftranslate_region_internal, Fformat):
2904 Rename or remove local vars to avoid shadowing.
9710023e 2905 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2906
a415e694
PE
2907 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2908 avoid shadowing.
2909
8ef4622d
PE
2910 * lisp.h (eassert): Check that the argument compiles, even if
2911 ENABLE_CHECKING is not defined.
2912
946f9a5b
PE
2913 * data.c (Findirect_variable): Name an expression, to avoid
2914 gcc -Wbad-function-cast warning.
112396d6 2915 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2916 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2917 (Fmake_variable_buffer_local, Fmake_local_variable):
2918 Mark variables as initialized.
52746918 2919 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2920
e5aab7e7 2921 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2922 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2923 Rename locals to avoid shadowing.
dff45157
PE
2924 (mark_stack): Move local variables into the #ifdef region where
2925 they're used.
7bc26fdb
PE
2926 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2927 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2928 needed otherwise.
2929 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2930 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2931 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2932
e5aab7e7
PE
2933 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2934 avoids undefined behavior in theory.
2935
4da60324
PE
2936 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2937
88043301
PE
2938 Use functions, not macros, for up- and down-casing (Bug#8254).
2939 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2940 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2941 to use the following functions instead of these macros.
2942 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2943 EMACS_INT, since callers assume the returned value fits in int.
2944 (upcase1): Likewise, for UPCASE_TABLE.
2945 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2946 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2947 the race-condition problem in the old DOWNCASE.
88043301 2948
19ed5445
PE
2949 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2950 Rename locals to avoid shadowing.
2951 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2952 (regex_compile, re_search_2, re_match_2_internal):
2953 Remove unused local vars.
952db0d7
PE
2954 (FREE_VAR): Rewrite so as not to use empty "else",
2955 which gcc can warn about.
da053e48 2956 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2957 (RETALLOC_IF): Define only if needed.
2958 (WORDCHAR_P): Likewise. This one is never needed, but is used
2959 only in a comment talking about a compiler bug, so put inside
2960 the #if 0 of that comment.
2961 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2962 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2963 Remove; unused.
19ed5445 2964
1f3561e4 2965 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2966 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2967 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2968
ded6f8f7
PE
2969 * search.c (simple_search): Remove unused var.
2970
dbd37a95
PE
2971 * dired.c (compile_pattern): Move decl from here ...
2972 * lisp.h: ... to here, so that it can be checked.
2973 (struct re_registers): New forward decl.
2974
7e47afad
PE
2975 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2976
85f24f61
PE
2977 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2978 All uses changed.
2979 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2980 Rename locals to avoid shadowing.
5671df8f 2981 (Fvertical_motion): Mark locals as initialized.
85f24f61 2982
181aa2be 2983 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2984 (casify_region): Mark local as initialized.
181aa2be 2985
930d429c
PE
2986 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2987
7082eac6
PE
2988 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2989 New macros, so that the caller can use some names other than
2990 gcpro1, gcpro2, etc.
2991 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2992 of the new macros.
2993 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2994 argument, for consistency with GCPRO2_VAR, etc: it is now the
2995 prefix of the variable, not the variable itself. All uses
2996 changed.
38b2c076
PE
2997 * dired.c (directory_files_internal, file_name_completion):
2998 Rename locals to avoid shadowing.
2999
15206ed9
PE
3000 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3001 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3002 dired.c's scmp function, had undefined behavior.
3003 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3004 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3005 * buffer.h: ... to here, because these macros use current_buffer,
3006 and the new implementation with inline functions needs to have
3007 current_buffer in scope now, rather than later when the macros
3008 are used.
3009 (downcase, upcase1): New static inline functions.
3010 (DOWNCASE, UPCASE1): Reimplement using these functions.
3011 This avoids undefined behavior in expressions like
3012 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3013 from race conditions in accessing the global variables
3014 case_temp1 and case_temp2.
3015 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3016 * lisp.h (case_temp1, case_temp2): Remove their decls.
3017 * character.h (ASCII_CHAR_P): Move from here ...
3018 * lisp.h: ... to here, so that the inline functions mentioned
3019 above can use them.
3020
4a6bea26
PE
3021 * dired.c (directory_files_internal_unwind): Now static.
3022
f14b7e14
PE
3023 * fileio.c (file_name_as_directory, directory_file_name):
3024 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3025 Now static.
2893f146
PE
3026 (file_name_as_directory): Use const pointers when appropriate.
3027 (Fexpand_file_name): Likewise. In particular, newdir might
3028 point at constant storage, so make it a const pointer.
fd4ead52 3029 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3030 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3031 signedness issues.
f839df0c
PE
3032 (Fset_file_times, Finsert_file_contents, auto_save_error):
3033 Rename locals to avoid shadowing.
f14b7e14 3034
5716756e 3035 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3036 (Ftry_completion, Fall_completions): Rename or remove locals
3037 to avoid shadowing.
5716756e 3038
b4c3046a
PE
3039 * marker.c (bytepos_to_charpos): Remove; unused.
3040
b45db522
PE
3041 * lisp.h (verify_bytepos, count_markers): New decls,
3042 so that gcc does not warn that these functions aren't declared.
3043
85876d07
PE
3044 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3045 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3046 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3047 (copy_text): Remove unused local var.
85876d07 3048
03d78a21 3049 * filelock.c (within_one_second): Now static.
b3dd38ab 3050 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3051
5df8f01b
PE
3052 * buffer.c (fix_overlays_before): Mark locals as initialized.
3053 (fix_start_end_in_overlays): Likewise. This function should be
3054 simplified by using pointers-to-pointers, but that's a different
3055 matter.
b1d876f1 3056 (switch_to_buffer_1): Now static.
8f54f30a
PE
3057 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3058 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3059
a70072c9 3060 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3061 Fix pointer signedness issue.
edced198
PE
3062 (sys_subshell): Mark local as volatile if checking for lint,
3063 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3064 (MAXPATHLEN): Define only if needed.
a70072c9 3065
a0977c44
PE
3066 * process.c (serial_open, serial_configure): Move decls from here ...
3067 * systty.h: ... to here, so that they can be checked.
3068
a884fdcc
PE
3069 * fns.c (get_random, seed_random): Move extern decls from here ...
3070 * lisp.h: ... to here, so that they can be checked.
3071
604efe86 3072 * sysdep.c (reset_io): Now static.
b8950c94 3073 (wait_for_termination_signal): Remove; unused.
604efe86 3074
38fc62d9
PE
3075 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3076 (copy_keymap_item, append_key, push_text_char_description):
3077 Now static.
1004a21a 3078 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3079 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3080 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3081 (describe_map_tree):
3082 Rename locals to avoid shadowing.
38fc62d9 3083
2f2650da
PE
3084 * keyboard.c: Declare functions static if they are not used elsewhere.
3085 (echo_char, echo_dash, cmd_error, top_level_2):
3086 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3087 (read_char, kbd_buffer_get_event, make_lispy_position):
3088 (make_lispy_event, make_lispy_movement, apply_modifiers):
3089 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3090 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3091 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3092 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3093 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3094
a053e86c 3095 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3096 (mark_kboards): Move decl here ...
3097 * alloc.c (mark_kboards): ... from here.
a053e86c 3098
4752793e
PE
3099 * lisp.h (force_auto_save_soon): New decl.
3100
74f10ca7 3101 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3102 (DEFINE_DUMMY_FUNCTION): New macro.
3103 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3104 Use it.
c03cd23f
PE
3105 (main): Add casts to avoid warnings
3106 if GCC considers string literals to be constants.
74f10ca7 3107
022e70d4
PE
3108 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3109
59d6fe83
PE
3110 * dbusbind.c: Pointer signedness fixes.
3111 (xd_signature, xd_append_arg, xd_initialize):
3112 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3113 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3114 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3115 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3116
78320123
PE
3117 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3118 if GCC considers string literals to be constants.
49cebcca 3119 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3120
35ac2a97
SM
31212011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3122
fb103ca9
SM
3123 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3124 (print_preprocess, print_object): New macro to fix last change.
3125
35ac2a97
SM
3126 * print.c (print_preprocess): Don't forget font objects.
3127
62973b41
JB
31282011-03-16 Juanma Barranquero <lekktu@gmail.com>
3129
3130 * emacs.c (USAGE3): Doc fixes.
3131
0e48bb22
AS
31322011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3133
3134 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3135 structure.
3136
7684e57b
JB
31372011-03-14 Juanma Barranquero <lekktu@gmail.com>
3138
3139 * lisp.h (VWindow_system, Qfile_name_history):
3140 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3141 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3142 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3143
3144 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3145 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3146
3147 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3148 * w32console.c (detect_input_pending, read_input_pending)
3149 (encode_terminal_code):
3150 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3151 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3152 (w32_system_caret_y, Qfile_name_history):
3153 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3154 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3155 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3156 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3157 * w32proc.c (Qlocal, report_file_error):
3158 * w32term.c (Vwindow_system, updating_frame):
3159 * w32uniscribe.c (initialized, uniscribe_font_driver):
3160 Remove unneeded extern declarations.
3161
2aa46d6c
CY
31622011-03-14 Chong Yidong <cyd@stupidchicken.com>
3163
c96bbc66 3164 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3165
cffc6f3b
CY
31662011-03-13 Chong Yidong <cyd@stupidchicken.com>
3167
3168 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3169 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3170 These macros can no longer be used for assignment.
3171
44f230aa
SM
3172 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3173 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3174 (record_buffer_markers, fetch_buffer_markers): New functions for
3175 recording and fetching special buffer markers.
3176 (set_buffer_internal_1, set_buffer_temp): Use them.
3177
3178 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3179
3180 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3181
3182 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3183 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3184
3185 * xdisp.c (hscroll_window_tree):
3186 (reconsider_clip_changes): Use PT instead of BUF_PT.
3187
d251f04b
EZ
31882011-03-13 Eli Zaretskii <eliz@gnu.org>
3189
3190 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3191 $(EMACS_ROOT)/lib/intprops.h.
3192
f0c77cd1
PE
31932011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3194
3eca4629
PE
3195 Fix more problems found by GCC 4.5.2's static checks.
3196
7c86ee98
PE
3197 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3198 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3199 (xg_free_frame_widgets): Make it clear that a local variable is
3200 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3201 (gdk_window_get_screen): Make it clear that this macro is needed
3202 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3203 (int_gtk_range_get_value): New function, which avoids a diagnostic
3204 from gcc -Wbad-function-cast.
3205 (xg_set_toolkit_scroll_bar_thumb): Use it.
3206 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3207 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3208 (get_utf8_string, xg_get_file_with_chooser):
3209 Rename locals to avoid shadowing.
3210 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3211
41729b81
PE
3212 * xgselect.c (xg_select): Remove unused var.
3213
f0c77cd1
PE
3214 * image.c (four_corners_best): Mark locals as initialized.
3215 (gif_load): Initialize transparent_p to zero (Bug#8238).
3216 Mark another local as initialized.
ec6cf4c6 3217 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3218
ce0ad53d 3219 * image.c (clear_image_cache): Now static.
d5d5a617 3220 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3221 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3222 (x_edge_detection): Remove unnecessary cast that
3223 gcc -Wbad-function-cast diagnoses.
2037898d 3224 (gif_load): Fix pointer signedness.
6ae141d6
PE
3225 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3226 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3227
33383987 32282011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3229
d32df629
PE
3230 Improve quality of tests for time stamp overflow.
3231 For example, without this patch (encode-time 0 0 0 1 1
3232 1152921504606846976) returns the obviously-bogus value (-948597
3233 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3234 reports time overflow. See
3235 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3236 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3237 * editfns.c: Include limits.h and intprops.h.
3238 (TIME_T_MIN, TIME_T_MAX): New macros.
3239 (time_overflow): Move earlier, to before first use.
3240 (hi_time, lo_time): New functions, for an accurate test for
3241 out-of-range times.
3242 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3243 (Fget_internal_run_time): Don't assume time_t fits in int.
3244 (make_time): Use list2 instead of Fcons twice.
3245 (Fdecode_time): More accurate test for out-of-range times.
3246 (check_tm_member): New function.
3247 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
3248 (lisp_time_argument): Don't rely on undefined left-shift and
3249 right-shift behavior when checking for time stamp overflow.
8be6f318 3250
fe31d94c
PE
3251 * editfns.c (time_overflow): New function, refactoring common code.
3252 (Fformat_time_string, Fdecode_time, Fencode_time):
3253 (Fcurrent_time_string): Use it.
3254
8be6f318
PE
3255 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3256 * dired.c (make_time): Move to ...
3257 * editfns.c (make_time): ... here.
3258 * systime.h: Note the move.
3259
09d9db2c 32602011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 3261
126bc0dc
YM
3262 * fringe.c (update_window_fringes): Remove unused variables.
3263
c47cbdfd
YM
3264 * unexmacosx.c (copy_data_segment): Also copy __got section.
3265 (Bug#8223)
3266
7ac80be9
EZ
32672011-03-12 Eli Zaretskii <eliz@gnu.org>
3268
c96bbc66 3269 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
3270 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3271 Constify `char *' arguments and their references according to
3272 prototypes in tparam.h.
3273
ecb0f94d 3274 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 3275
7ac80be9
EZ
3276 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3277 Adapt all references accordingly.
3278
3279 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3280
ef1fd07e
TT
32812011-03-11 Tom Tromey <tromey@redhat.com>
3282
3283 * buffer.c (syms_of_buffer): Remove obsolete comment.
3284
7ef4b50c
EZ
32852011-03-11 Eli Zaretskii <eliz@gnu.org>
3286
3287 * termhooks.h (encode_terminal_code): Declare prototype.
3288
3289 * msdos.c (encode_terminal_code): Don't declare prototype.
3290
3291 * term.c (encode_terminal_code): Now external again, used by
3292 w32console.c and msdos.c.
3293
44f230aa
SM
3294 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3295 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 3296
4b1ec863 32972011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 3298
1714f52b 3299 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 3300
4b1ec863
PE
3301 * fringe.c (update_window_fringes): Mark locals as initialized
3302 (Bug#8227).
3303 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 3304
524c7aa6
PE
3305 * alloc.c (mark_fringe_data): Move decl from here ...
3306 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3307 to check its interface.
3308 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3309
a5c0af81 3310 * fontset.c (free_realized_fontset): Now static.
7519b8cd 3311 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 3312 (fontset_font): Mark local as initialized.
a9a06e0b 3313 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 3314
b4716021
PE
3315 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3316
811e9bac 3317 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 3318 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
3319 (x_own_selection, Fx_disown_selection_internal): Rename locals
3320 to avoid shadowing.
3321 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 3322
7e3ab302
PE
3323 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3324 so that the caller can use some name other than gcpro1.
3325 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
3326 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3327 (Fx_backspace_delete_keys_p):
3328 Use them to avoid shadowing, and rename vars to avoid shadowing.
3329 (x_decode_color, x_set_name, x_window): Now static.
6b437900 3330 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 3331 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
3332 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3333 Remove unused locals.
7e3ab302
PE
3334 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3335 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3336 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3337 macros.
f78faa98 3338
e2b13473
PE
3339 * xterm.h (x_mouse_leave): New decl.
3340
77f23912
PE
3341 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3342 Remove unused functions.
cdf4ba58
PE
3343 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3344 (x_calc_absolute_position): Now static.
7411c686 3345 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 3346 Don't declare local "event" unless it's used.
ed7bf3a5
PE
3347 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3348 unless they are used.
38d0b34a
PE
3349 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3350 (x_fatal_error_signal): Remove; not used.
a6067996
PE
3351 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3352 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3353 (x_error_catcher, x_connection_closed, x_error_handler):
3354 (x_error_quitter, xembed_send_message, x_iconify_frame):
3355 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 3356 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 3357 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 3358
44f230aa
SM
3359 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3360 Rename or move locals to avoid shadowing.
6b463e58 3361 (tty_defined_color, merge_face_heights): Now static.
5967d051 3362 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
3363 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3364 does not deduce is never used uninitialized.
73719eba
PE
3365 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3366 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 3367
426994c3 3368 * terminal.c (store_terminal_param): Now static.
5489860b 3369
032f1620 3370 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 3371 (set_frame_menubar): Remove unused local.
d4323972 3372 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
3373 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3374 since they might point to immutable storage.
281585b0
PE
3375 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3376 since it's unused otherwise.
032f1620 3377
367c19e5 3378 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 3379 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
3380 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3381 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 3382 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
3383 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3384 does not deduce are never used uninitialized.
70739cbe 3385
07b48fa9
PE
3386 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3387
8868a238 3388 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
3389 * window.c (window_loop, size_window):
3390 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 3391
7e5cf297 3392 * window.c (display_buffer): Now static.
d6550a9f
PE
3393 (size_window): Mark variables that gcc -Wuninitialized
3394 does not deduce are never used uninitialized.
a586633d
PE
3395 * window.h (check_all_windows): New decl, to forestall
3396 gcc -Wmissing-prototypes diagnostic.
5b555da1 3397 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 3398
f6095868
PE
3399 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3400 shadowing.
3401 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
3402 Include <limits.h>.
3403 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3404 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
3405 (load_charset_map): Mark variables that gcc -Wuninitialized
3406 does not deduce are never used uninitialized.
53df7c11 3407 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 3408
f38b440c
PE
3409 * coding.c (coding_set_source, coding_set_destination):
3410 Use "else { /* comment */ }" rather than "else /* comment */;"
3411 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
3412 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3413 a block, when the outer 'i' will do.
3414 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3415 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3416 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3417 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3418 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3419 Rename locals to avoid shadowing.
3420 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
3421 * coding.c (emacs_mule_char, encode_invocation_designation):
3422 Now static, since they're not used elsewhere.
413bb2db 3423 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 3424 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
3425 (decode_coding_emacs_mule): Mark variables that gcc
3426 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
3427 (detect_coding_iso_2022): Initialize a local variable that might
3428 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 3429 this initialization is needed. (Bug#8211)
5f58e762
PE
3430 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3431 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3432 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3433 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3434 Remove unused macros.
f38b440c 3435
232b38b9 3436 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 3437 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 3438 * character.c (string_count_byte8): Likewise.
232b38b9 3439
fb90da1b
PE
3440 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3441 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3442
fb93dbc2
PE
3443 * chartab.c (copy_sub_char_table): Now static, since it's not used
3444 elsewhere.
5c156ace
PE
3445 (sub_char_table_ref_and_range, char_table_ref_and_range):
3446 Rename locals to avoid shadowing.
bbcd0949 3447 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 3448
7d3b3862 3449 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 3450 (BIDI_BOB): Remove unused macro.
7d3b3862 3451
6be7d3da
PE
3452 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3453 deduce are never used uninitialized.
c2ed9c8b 3454 * term.c (encode_terminal_code): Likewise.
6be7d3da 3455
75f8807f 3456 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 3457
50938595
PE
3458 * tparam.h: New file.
3459 * term.c, tparam.h: Include it.
3460 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3461 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3462 Move these decls to tparam.h, and make them agree with what
3463 is actually in tparam.c. The previous trick of using incompatible
3464 decls in different modules does not conform to the C standard.
3465 All callers of tparam changed to use tparam's actual API.
3466 * tparam.c (tparam1, tparam, tgoto):
3467 Use const pointers where appropriate.
3468
fbceeba2
PE
3469 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3470 * cm.h (struct cm): Likewise.
3471 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3472 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3473 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3474 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3475 (turn_on_face, init_tty): Likewise.
3476 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 3477
7f3f1250
PE
3478 * term.c (term_mouse_position): Rename local to avoid shadowing.
3479
e6ca6543
PE
3480 * alloc.c (mark_ttys): Move decl from here ...
3481 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3482
c40f8d15
AS
34832011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3484
3485 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3486
cfe0661d
JB
34872011-03-09 Juanma Barranquero <lekktu@gmail.com>
3488
3489 * search.c (compile_pattern_1): Remove argument regp, unused since
3490 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3491 (compile_pattern): Don't pass it.
3492
0afb4571
J
34932011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3494
3495 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3496 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3497 for ! HAVE_GTK3.
3498 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3499
3500 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3501
3502 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3503 gdk_window_get_screen, gdk_window_get_geometry,
3504 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3505 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3506 (xg_get_pixbuf_from_pixmap): New function.
3507 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3508 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3509 Call xg_get_pixbuf_from_pixmap instead of
3510 gdk_pixbuf_get_from_drawable.
3511 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3512 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3513 (xg_check_special_colors): Use GtkStyleContext and its functions
3514 for HAVE_GTK3.
3515 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3516 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3517 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
3518 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3519 Call gtk_widget_get_preferred_size.
0afb4571
J
3520 (xg_frame_resized): gdk_window_get_geometry only takes 5
3521 parameters.
44f230aa
SM
3522 (xg_win_to_widget, xg_event_is_for_menubar):
3523 Call gdk_x11_window_lookup_for_display.
0afb4571
J
3524 (xg_set_widget_bg): New function.
3525 (delete_cb): New function.
895009e1 3526 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
3527 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3528 (xg_set_background_color): Call xg_set_widget_bg.
3529 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3530 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3531 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3532 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3533 if ! HAVE_GTK3.
3534 (update_frame_tool_bar): Call gtk_widget_hide.
3535 (xg_initialize): Use GDK_KEY_g.
3536
3537 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3538 if ! HAVE_GTK3
3539 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3540
3541 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3542 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3543 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3544
1c2cc4ef
JB
35452011-03-08 Juanma Barranquero <lekktu@gmail.com>
3546
3547 * w32xfns.c (select_palette): Check success of RealizePalette against
3548 GDI_ERROR, not zero.
3549
33383987 3550See ChangeLog.11 for earlier changes.
aac0c6e3
MR
3551
3552;; Local Variables:
3553;; coding: utf-8
aac0c6e3
MR
3554;; End:
3555
33383987 3556 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
3557
3558 This file is part of GNU Emacs.
3559
3560 GNU Emacs is free software: you can redistribute it and/or modify
3561 it under the terms of the GNU General Public License as published by
3562 the Free Software Foundation, either version 3 of the License, or
3563 (at your option) any later version.
3564
3565 GNU Emacs is distributed in the hope that it will be useful,
3566 but WITHOUT ANY WARRANTY; without even the implied warranty of
3567 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3568 GNU General Public License for more details.
3569
3570 You should have received a copy of the GNU General Public License
3571 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.