Generalize marker debugging code under MARKER_DEBUG and use eassert.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e2688e4a
DA
12012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Generalize marker debugging code under MARKER_DEBUG and use eassert.
4 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
5 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
6 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
7 (replace_range, replace_range_2, del_range_2): Change to eassert.
8 * marker.c (byte_char_debug_check): Adjust style.
9
b46a6a83
PE
102012-07-29 Paul Eggert <eggert@cs.ucla.edu>
11
12 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
13 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
14 long-ago-commented-out code that talks about "WIN32".
15 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
16 All uses changed.
17
e32a5799
PE
182012-07-28 Paul Eggert <eggert@cs.ucla.edu>
19
20 Use Gnulib stdalign module (Bug#9772, Bug#9960).
21 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
22 Simplify by using alignof.
23 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
24 * lisp.h: Include <stdalign.h>.
25 (GCALIGNMENT): New macro and constant.
26 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
27 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
28 (stdalign): New macro, if not already defined.
29
df81cd29
EZ
302012-07-28 Eli Zaretskii <eliz@gnu.org>
31
01bd1b0d
EZ
32 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
33 * w32inevt.c: Include w32inevt.h.
34 (w32_read_console_input): New inline function, calls either
35 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
36 w32_console_unicode_input.
37 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
38 (w32_kbd_patch_key, key_event): Use the codepage returned by
39 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
40 (key_event): use uChar.UnicodeChar only if
41 w32_console_unicode_input is non-zero.
42
43 * w32console.c: Include w32heap.h.
44 <w32_console_unicode_input>: New global variable.
45 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
46 family of Windows, zero otherwise.
47
48 * w32inevt.h: Declare w32_console_unicode_input.
49
df81cd29
EZ
50 * xdisp.c (init_iterator): Don't reference tip_frame in a build
51 --without-x. (Bug#11742)
52
c20fdd9e
PE
532012-07-27 Paul Eggert <eggert@cs.ucla.edu>
54
55 Adjust GDB to reflect pvec_type changes (Bug#12036).
56 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
57 2012-07-04 changes to pseudovector representation. Problem
58 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
59
32770973 602012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
61
62 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
63 bus address.
64 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
65
3438fe21
EZ
662012-07-27 Eli Zaretskii <eliz@gnu.org>
67
bcfbc9de
EZ
68 * alloc.c (listn): Fix the order the arguments are consed onto the
69 list.
70
3438fe21
EZ
71 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
72 enumeration constants, as PURE and HEAP are too general, and clash
73 with other headers and sources, such as gmalloc.c and the
74 MS-Windows system headers. All users changed.
75
eeaea515
DA
762012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
77
78 Revert last save_excursion_save and save_excursion_restore changes.
79 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
80 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
81
073c88c2
DA
822012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
83
84 Fix recently-introduced typos in Windows port.
85 Reported by Martin Rudalics <rudalics@gmx.at>.
86 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 87 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 88
4706125e
PE
892012-07-27 Paul Eggert <eggert@cs.ucla.edu>
90
91 Improve GDB symbol export (Bug#12036).
92 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
93 arms of an 'if', not using conditional expressions; otherwise GDB
94 complains about the types in the unevaluated arm when the argument
95 is an integer literal.
96 (xgetint): Simplify expression.
97 * alloc.c (gdb_make_enums_visible): New constant. This ports to
98 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
99 Zaretskii in <http://bugs.gnu.org/12036#13>.
100 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
101 needed now that we have gdb_make_enums_visible.
102 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
103 (enum enum_USE_LSB_TAG):
104 New enum types, packaging up enums that need to be exported to GDB.
105
694b6c97
DA
1062012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
107
108 Utility function to make a list from specified amount of objects.
109 * lisp.h (enum constype): New datatype.
110 (listn): New prototype.
111 * alloc.c (listn): New function.
112 (Fmemory_use_count, syms_of_alloc): Use it.
113 * buffer.c (syms_of_buffer): Likewise.
114 * callint.c (syms_of_callint): Likewise.
115 * charset.c (define_charset_internal): Likewise.
116 * coding.c (syms_of_coding): Likewise.
117 * keymap.c (syms_of_keymap): Likewise.
118 * search.c (syms_of_search): Likewise.
119 * syntax.c (syms_of_syntax): Likewise.
120 * w32.c (init_environment): Likewise.
121 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
122 * xdisp.c (syms_of_xdisp): Likewise.
123 * xfns.c (syms_of_xfns): Likewise.
124
6195f384
DA
1252012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
126
127 Fast save_excursion_save and save_excursion_restore.
128 * lisp.h (struct Lisp_Excursion): New data type.
129 (PVEC_EXCURSION): New pseudovector type.
130 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
131 to deal with it. Adjust comments.
132 (init_marker, attach_marker): New prototype.
133 (unchain_marker): Adjust prototype.
134 * marker.c (attach_marker): Change to global.
135 (init_marker): New function.
136 * alloc.c (Fmake_marker, build_marker): Use it.
137 (build_marker): More easserts.
138 (mark_object): Handle struct Lisp_Excursion.
139 * editfns.c (save_excursion_save, save_excursion_restore):
140 Reimplement to use struct Lisp_Excursion. Add comments.
141
5eceb8fb
PE
1422012-07-26 Paul Eggert <eggert@cs.ucla.edu>
143
144 Fix export of symbols to GDB (Bug#12036).
145 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
146 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
147 emacs.c, as this is a more-suitable home. Had this been done earlier
148 the fix for 12036 would have avoided some of the problems noted in
149 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
150 would have been more obvious.
562157c8
PE
151 * emacs.c: Do not include <verify.h>; no longer needed.
152 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
153 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
154 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
155 Remove; now done in lisp.h.
156 * lisp.h (PUBLISH_TO_GDB): New macro.
157 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
158 (DATA_SEG_BITS): Use it.
159 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
160 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
161 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
162 not be usable in #if. This simplifies things.
163
d6749401
JB
1642012-07-26 Juanma Barranquero <lekktu@gmail.com>
165
166 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
167
1781b9e9
PE
1682012-07-26 Paul Eggert <eggert@cs.ucla.edu>
169
d89518db 170 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
171 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
172 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
173 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
174 Adjust to changes in lisp.h and emacs.c, by using
175 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
176 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
177 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
178 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
179 instead of gdb_valbits.
180 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
181 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
182 instead of gdb_array_mark_flag.
183 (xboolvector): Get size from $->size, not $->header.size.
184 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
185 (xreload, hook-run, hookpost-run): Remove.
186 * emacs.c: Include <verify.h>.
187 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
188 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
189 Remove.
190 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
191 (gdb_USE_LSB_TAG): New enum constants.
192 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
193 Also define these as enum constants, so they're visible to GDB.
194 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
195 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
196 as constants, so they're visible to GDB.
197 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
198 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
199 Now enum constants, not macros, so they're visible to GDB.
200 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
201 more convenient now. All uses changed.
202 (VALMASK) [USE_LSB_TAG]: Also define in this case.
203 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
204
3628596a
DA
2052012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
206
207 Explicitly free restriction data that are not needed anymore.
208 * editfns.c (save_restriction_restore): Free restriction data.
209
7abaf5cc
SM
2102012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
211
212 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
213 add argument, tune behavior, and adjust all callers.
214
71f88e00
PE
2152012-07-25 Paul Eggert <eggert@cs.ucla.edu>
216
217 Use typedef for EMACS_INT, EMACS_UINT.
218 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
219 than macros. This simplifies debugging in the usual case, since
220 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
221 and it allows expressions involving EMACS_INT casts.
222 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
223
57ec3034
JD
2242012-07-25 Jan Djärv <jan.h.d@swipnet.se>
225
226 * nsterm.m (ns_read_socket): Return early if there is a modal
227 window (Bug#12043).
228
8137e7b3
MR
2292012-07-25 Martin Rudalics <rudalics@gmx.at>
230
231 * frame.c (Fredirect_frame_focus): In doc-string don't mention
232 that FOCUS-FRAME can be omitted.
233
04e9897c
DA
2342012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
235
236 Adjust buffer text indirection counters at the end of Fkill_buffer.
237 * buffer.c (Fkill_buffer): Adjust indirection counters when the
238 buffer is definitely dead. This should really fix an issue reported
239 by Christoph Scholtes again. (Bug#12007).
240 (init_buffer_once): Initialize indirection counters of
241 buffer_defaults and buffer_local_symbols (for sanity and safety).
242
8a0484e1
EZ
2432012-07-24 Eli Zaretskii <eliz@gnu.org>
244
245 * xdisp.c (init_iterator): Don't compute dimensions of truncation
246 and continuation glyphs on tooltip frames, leave them at zero.
247 Avoids continued lines in tooltips. (Bug#11832)
248
fa691a83
DA
2492012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
250
251 Simplify copy_overlay.
04e9897c 252 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
253 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
254
436bc8e0
EZ
2552012-07-23 Eli Zaretskii <eliz@gnu.org>
256
257 * print.c (print_object): Don't crash when a frame's name is nil
258 or invalid. (Bug#12025)
259
260 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
261 it signals an error when a tooltip frame is being created.
262
d7a7fda3
DA
2632012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
264
265 Cleanup miscellaneous objects allocation and initialization.
266 * alloc.c (allocate_misc): Change to static. Add argument to
267 specify the subtype. Adjust comment and users.
268 (build_overlay): New function.
269 * buffer.c (copy_overlays, Fmake_overlay): Use it.
270 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
271 (allocate_misc): Remove prototype.
272 (build_overlay): Add prototype.
273
2742012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
275
276 Swap buffer text indirection counters in Fbuffer_swap_text.
277 * buffer.c (Fbuffer_swap_text): Swap indirections too.
278 This avoids crash reported by Christoph Scholtes at
279 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
280
9d7fa573
JD
2812012-07-22 Jan Djärv <jan.h.d@swipnet.se>
282
283 * nsmenu.m (Popdown_data): New struct.
284 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
285 free Popdown_data.
286 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
287 (initWithContentRect): Make imgView and contentView non-static
288 and autorelease them. Also autorelease img and matrix (Bug#12005).
289 (dealloc): Remove (Bug#12005).
290
0dd6d66d
DA
2912012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
292
293 Adjust consing_since_gc when objects are explicitly freed.
294 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
295 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
296 (free_cons, free_misc): Subtract object size from consing_since_gc.
297
d36d71df
DA
2982012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
299
300 Simplify and cleanup markers positioning code.
301 * marker.c (attach_marker): More useful eassert.
302 (live_buffer, set_marker_internal): New function.
303 (Fset_marker, set_marker_restricted): Use set_marker_internal.
304 (set_marker_both, set_marker_restricted_both): Use live_buffer.
305
fb9ea40f
PE
3062012-07-22 Paul Eggert <eggert@cs.ucla.edu>
307
308 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
309 as it's limited by the amount of memory, not by INT_MAX.
310
2d5c5f7d
EZ
3112012-07-21 Eli Zaretskii <eliz@gnu.org>
312
07fb592e
EZ
313 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
314 in special-event-map. See the discussion at
315 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
316 for the reasons.
317
37a9eac8 318 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
319 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
320 Fabrice Popineau <fabrice.popineau@supelec.fr>.
321
c4328746
JD
3222012-07-21 Jan Djärv <jan.h.d@swipnet.se>
323
324 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 325 (conversationIdentifier): Return value is NSInteger.
784051c4 326 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 327
6e5d1c12
CY
3282012-07-21 Chong Yidong <cyd@gnu.org>
329
330 * window.c (decode_any_window): Signal an error if the window is
331 on a dead frame (Bug#11984).
332
9928463d
DA
3332012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
334
335 Add indirection counting to speed up Fkill_buffer.
336 * buffer.h (struct buffer): New member.
337 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
338 (Fmake_indirect_buffer): Set indirection counter to -1, increment
339 base buffer indirection counter.
340 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
341 (Fkill_buffer): Adjust indirection counters as needed, don't walk
342 through buffer list if indirection counter is 0.
343
f8643a6b
DA
3442012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
345
346 Extend the value returned by Fgarbage_collect with heap statistics.
347 * alloc.c (Qheap): New symbol.
348 (syms_of_alloc): DEFSYM it.
349 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
350 (Fmemory_free): Remove.
351 (syms_of_alloc): Don't defsubr it.
352 * buffer.c (Fcompact_buffer): Remove.
353 (syms_of_buffer): Don't defsubr it.
354
dac616ff
DA
3552012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
356
357 Make maybe_gc inline.
358 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
359 * lisp.h (consing_since_gc, gc_relative_threshold)
360 (memory_full_cons_threshold): Revert declaration.
361 (maybe_gc): Remove prototype, define as inline.
362 * alloc.c: Remove old commented-out code.
363 (consing_since_gc, gc_relative_threshold)
364 (memory_full_cons_threshold): Revert to global.
365 (maybe_gc): Remove.
366
d7ea76b4
DA
3672012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
368
369 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
370 * lisp.h (build_unibyte_string): New function.
371 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
372 * sysdep.c, w32fns.c, xfns.c: Use it.
373 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
374 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
375 Adjust users accordingly.
376 * font.h (font_open_by_name): Adjust prototype.
377
765e61e3
DA
3782012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
379
380 Cleanup calls to Fgarbage_collect.
381 * lisp.h (maybe_gc): New prototype.
382 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
383 Remove declarations.
384 * alloc.c (maybe_gc): New function.
385 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
386 Make them static.
387 * bytecode.c (MAYBE_GC): Use maybe_gc.
388 * eval.c (eval_sub, Ffuncall): Likewise.
389 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
390 to avoid dependency from auto-save feature.
391
52b852c7
PE
3922012-07-19 Paul Eggert <eggert@cs.ucla.edu>
393
394 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
395 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
396 'for_each_per_buffer_object_at'.
397 All uses changed. It's better to use upper-case for macros that
398 cannot be implemented as functions, to give the reader a clue
399 that they're special.
400
5db81e33
SM
4012012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
402
403 * alloc.c (Fgarbage_collect): Tweak docstring.
404
5b835e1d
DA
4052012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
406
407 Tweak the value returned from Fgarbage_collect again.
408 * alloc.c (Fgarbage_collect): New return value, as confirmed in
409 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
410 Adjust documentation.
411 (total_vector_bytes): Rename to total_vector_slots, adjust
412 accounting.
413 (total_free_vector_bytes): Rename to total_free_vector_slots,
414 adjust accounting.
415 (Qstring_bytes, Qvector_slots): New symbols.
416 (syms_of_alloc): DEFSYM them.
417
9cd47b72
DA
4182012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
419
420 Buffer compaction primitive which may be used from Lisp.
421 * buffer.c (compact_buffer, Fcompact_buffer): New function.
422 (syms_of_buffer): Register Fcompact_buffer.
423 * alloc.c (Fgarbage_collect): Use compact_buffer.
424 * buffer.h (compact_buffer): New prototype.
425 (struct buffer_text): New member.
426
d17337e5
DA
4272012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
428
429 New macro to iterate over all buffers, miscellaneous cleanups.
430 * lisp.h (all_buffers): Remove declaration.
431 * buffer.h (all_buffers): Add declaration, with comment.
432 (for_each_buffer): New macro.
433 * alloc.c (Fgarbage_collect, mark_object): Use it.
434 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
435 (init_buffer): Likewise.
436 * data.c (Fset_default): Likewise.
437 * coding.c (code_conversion_restore): Remove redundant check
438 for dead buffer.
439 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
440
60cfd278
AS
4412012-07-18 Andreas Schwab <schwab@linux-m68k.org>
442
443 Fix bug that created negative-length intervals.
444 * intervals.c (merge_interval_right, merge_interval_left):
445 Do not zero out this interval if it is absorbed by its children,
446 as this interval's total length doesn't change in that case. See
447 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
448
d06714cb
PE
4492012-07-18 Paul Eggert <eggert@cs.ucla.edu>
450
83713154
PE
451 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
452 when invoking (make-bool-vector N t) and N is a positive
453 multiple of 8 -- the last 8 bits were mistakenly cleared.
454
d06714cb
PE
455 Remove some struct layout assumptions in bool vectors.
456 * alloc.c (bool_header_size): New constant.
457 (header_size, word_size): Move earlier, as they're now used earlier.
458 Use 'word_size' in a few more places, where it's appropriate.
459 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
460 padding before the data member of a bool vector.
461 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
462 than doing the check by hand with an abort ().
463
464d5a5e
SM
4642012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
465
5fbc0409
SM
466 * eval.c (Fdefvar): Don't check constants since we only set the var if
467 it's not yet defined anyway (bug#11904).
468
464d5a5e
SM
469 * lisp.h (last_undo_boundary): Declare new var.
470 * keyboard.c (command_loop_1): Set it.
471 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
472 were auto-added by the command loop (bug#11774).
473
8dc2e44a
AS
4742012-07-18 Andreas Schwab <schwab@linux-m68k.org>
475
476 * w32font.c (Qsymbol): Remove local definition.
477 (syms_of_w32font): Don't DEFSYM it.
478
169925ec
DA
4792012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
480
481 Fix sweep_vectors to handle large bool vectors correctly.
482 * alloc.c (sweep_vectors): Account total_vector_bytes for
483 bool vectors larger than VBLOCK_BYTES_MAX.
484
5fbfb018
CY
4852012-07-18 Chong Yidong <cyd@gnu.org>
486
487 * frame.c (x_set_frame_parameters): Revert bogus change introduced
488 in 2012-05-25 commit by Paul Eggert (Bug#11738).
489
3ab6e069
DA
4902012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
491
492 Return more descriptive data from Fgarbage_collect.
493 Suggested by Stefan Monnier in
494 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
495 * alloc.c (bounded_number): New function.
496 (total_buffers, total_vectors): New variable.
497 (total_string_size): Rename to total_string_bytes, adjust users.
498 (total_vector_size): Rename to total_vector_bytes, adjust users.
499 (sweep_vectors): Account total_vectors and total_vector_bytes.
500 (Fgarbage_collect): New return value. Adjust documentation.
501 (gc_sweep): Account total_buffers.
502 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
503 (VECTOR_SIZE): Remove.
504 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
505 (Qinterval, Qmisc): New symbols.
506 (syms_of_data): Initialize them.
507 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
508 (Qcons, Qbuffer): New declarations.
509
6d02fe5b
PE
5102012-07-17 Paul Eggert <eggert@cs.ucla.edu>
511
512 * alloc.c (Fmemory_free): Account for memory-free's own storage.
513 Round up, not down. Improve doc.
514
b7ffe040
DA
5152012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
516
517 Restore old code in allocate_string_data to avoid Faset breakage.
518 Reported by Julien Danjou <julien@danjou.info> in
519 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
520 * alloc.c (allocate_string_data): Restore old code with minor
521 adjustments, fix comment to explain this subtle issue.
522
4dc7c8d5
SM
5232012-07-17 Eli Zaretskii <eliz@gnu.org>
524
525 Remove FILE_SYSTEM_CASE.
526 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
527
528 * fileio.c (FILE_SYSTEM_CASE): Don't define.
529 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
530 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
531 call-process-region passes it through expand-file-name.
532
533 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
534
5352012-07-17 Andreas Schwab <schwab@linux-m68k.org>
536
537 Fix crash when creating indirect buffer (Bug#11917)
538 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
539 Don't handle unbound variables specially if non-zero.
540 (Fbuffer_local_variables): Pass zero.
541 (clone_per_buffer_values): Pass non-zero.
542
5432012-07-17 Andreas Schwab <schwab@linux-m68k.org>
544
545 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
546 to make the loop interruptible.
547
5482012-07-17 Andreas Schwab <schwab@linux-m68k.org>
549
550 * gnutls.c (emacs_gnutls_handshake): Only retry if
551 GNUTLS_E_INTERRUPTED.
552
cce7fefc
DA
5532012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
554
555 Cleanup and convert miscellaneous checks to eassert.
556 * alloc.c (mark_interval): Fix comment, partially rephrase
557 old comment from intervals.h (see below).
558 * intervals.c (find_interval, adjust_intervals_for_insertion)
559 (delete_interval, adjust_intervals_for_deletion)
560 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
561 Convert to eassert.
562 (adjust_intervals_for_insertion, make_new_interval):
563 Remove obsolete and unused code.
564 * intervals.h (struct interval): Remove obsolete comment.
565 * textprotp.c (erase_properties): Remove unused code.
566 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
567 (Fremove_list_of_text_properties): Convert to eassert.
568
9ea10cc3
CY
5692012-07-17 Chong Yidong <cyd@gnu.org>
570
571 * editfns.c (Finsert_char): Doc fix.
572
3900d5de
DA
5732012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
574
575 Fix previous change to make Fmemory_free always accurate.
576 * alloc.c (make_interval): Update total_free_intervals.
577 (make_float): Likewise for total_free_floats.
578 (free_cons, Fcons): Likewise for total_free_conses.
579 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
580 Likewise for total_free_vector_bytes.
581 (Fmake_symbol): Likewise for total_free_symbols.
582 (bytes_free): Remove.
583
7098646f
DA
5842012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
585
586 Simple free memory accounting feature.
587 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
588 (sweep_vectors): Accumulate size of free vectors.
589 (Fgarbage_collect): Setup bytes_free.
590 (Fmemory_free): New function.
591 (syms_of_alloc): Register it.
592
22657b40
DA
5932012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
594
595 Cleanup overlays checking.
596 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
597 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
598 eassert and OVERLAYP.
599 (sort_overlays): Change to use OVERLAYP.
600
ddfc8813
RK
6012012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
602
603 * editfns.c (Finsert_char): Make it interactive, and make the
604 second arg optional. Copy interactive spec and docstring from
605 ucs-insert.
606
7c26cf3c
PE
6072012-07-17 Paul Eggert <eggert@cs.ucla.edu>
608
609 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
610 Unlike the other wrapped functions, fabs has an unspecified
611 effect on errno.
612
5d127af9
JD
6132012-07-16 Jan Djärv <jan.h.d@swipnet.se>
614
615 * nsterm.m (keyDown): Interpret flags without left/right bits
616 as the left key (Bug#11670).
617
6a0dd1d7
DA
6182012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
619
620 Remove empty and useless init functions.
621 * lisp.h (init_character_once, init_fns, init_image)
622 (init_filelock, init_sound): Remove prototype.
623 * character.c (init_character_once): Remove.
624 * filelock.c (init_filelock): Likewise.
625 * fns.c (init_fns): Likewise.
626 * image.c (init_image): Likewise.
627 * sound.c (init_sound): Likewise.
628 * emacs.c (main): Adjust accordingly.
629
7a6136fd
DA
6302012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
631
632 * gtkutil.h: Tiny cleanups.
633 (use_old_gtk_file_dialog): Remove useless declaration.
634 (xg_uses_old_file_dialog): Add suggested const attribute.
635
ce811ad9
EZ
6362012-07-15 Eli Zaretskii <eliz@gnu.org>
637
638 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
639 (bidi_paragraph_init): Use it to limit search forward for a strong
640 directional character in abnormally large paragraphs full of
641 neutral or weak characters. (Bug#11943)
642
c9adfeaa
SF
6432012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
644
645 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
646 the toolbar (Bug#9451).
647 (xg_make_tool_item): Give the widget event box a transparent
648 background.
649
fff62aa9
DA
6502012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
651
652 Cleanup basic allocation variables and functions.
653 * alloc.c (ignore_warnings, init_intervals, init_float)
654 (init_cons, init_symbol, init_marker): Remove.
655 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
656 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
657 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
658 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
659 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
660 (staticidx, init_alloc_once, init_strings, free_ablock):
661 Remove redundant initialization.
662 * fns.c (init_weak_hash_tables): Remove.
663 * lisp.h (init_weak_hash_tables): Remove prototype.
664
9730daca
DA
6652012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
666
667 Use zero_vector where appropriate.
668 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
669 accordingly.
670 * lisp.h (zero_vector): New declaration.
671 * font.c (null_vector): Remove.
672 (syms_of_font): Remove initialization and staticpro.
673 (font_list_entities, font_find_for_lface): Change to use zero_vector.
674 * keymap.c (Faccessible_keymaps): Likewise.
675
2e2d2a13
LL
6762012-07-15 Leo Liu <sdl.web@gmail.com>
677
678 * fringe.c: Fix typo in comments.
679
cd276f6e
LL
6802012-07-14 Leo Liu <sdl.web@gmail.com>
681
682 * fringe.c: Add a new bitmap exclamation-mark.
683
5a1131d9
EZ
6842012-07-14 Eli Zaretskii <eliz@gnu.org>
685
686 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
687
688 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
689 (HAVE_MENUS): Don't define, defined by editing config.in with
690 msdos/sed2v2.inp.
691 (GMALLOC_INHIBIT_VALLOC): Don't define.
692 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
693
22e983b7
JB
6942012-07-14 Juanma Barranquero <lekktu@gmail.com>
695
696 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
697
5b3f250f
GM
6982012-07-14 Glenn Morris <rgm@gnu.org>
699
700 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
701 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
702 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
703
33d63ff4
GM
7042012-07-13 Glenn Morris <rgm@gnu.org>
705
5b633342
GM
706 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
707
33d63ff4
GM
708 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
709 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
710
b55b9f85
JD
7112012-07-13 Jan Djärv <jan.h.d@swipnet.se>
712
0dc8cf50
JD
713 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
714 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
715 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
716 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
717 where appropriate.
718 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
719 as boolean expression.
720 (x_set_window_size): Remove unused variable toolbar.
721 (ns_get_color_default, ns_mod_to_lisp): Remove.
722 (ns_mouse_position): Remove unused variables xchar and ychar.
723 (ns_compute_glyph_string_overhangs): Remove unused variable face.
724 (ns_set_vertical_scroll_bar): Remove unused variable count.
725 (ns_delete_terminal): Remove unused variable i.
726 (ns_term_init): Remove unused variables r, g and b.
727 (mouseDown): Remove unused variable window.
728 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
729 (initFrameFromEmacs): Remove unused variable vbextra.
730 (mouseEntered): Remove unused variables p and dpyinfo.
731 (mouseExited): Remove unused variables p and r.
732 (ns_define_frame_cursor, ns_clear_frame_area)
733 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
734 (menuDown): Assign [sender tag] to variable and cast the variable.
735
736 * nsterm.h (menuDown): Add id as type to argument sender.
737 (ns_display_info_for_name): Add Lisp_Object argument.
738 (ns_term_init): Add Lisp_Object argument.
739 (ns_map_event_to_object): Add void argument.
740 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
741 prototype with arguments and only declare if __OBJC__.
742 (nxatoms_of_nsselect): Add void argument.
743 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
744 (ns_alloc_autorelease_pool): Add void argument.
745 (ns_release_autorelease_pool): Add void* argument.
746 (ns_get_defaults_value): Add const char* argument.
747
748 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
749 (initFromContents): Use SSDATA where appropriate.
750 (ns_update_menubar): Add braces to ambigous if-else.
751 (initWithTitle): Put () around assignment in if statement.
752 (ns_menu_show): Remove unused variables window and keymap.
753 (update_frame_tool_bar): Remove unused variable selected_p.
754 (initWithContentRect): Remove unused variable this_cmd_name.
755
756 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
757 appropriate.
758 (setXBMColor): Remove unused variable len.
759 (setPixmapData): Put () around assignment in loop statement.
760
761 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
762 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
763 where appropriate.
764 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
765 around assignment in loop statement.
766 (nsfont_open): Remove unused variable i.
767 (nsfont_open): Remove unused variable len.
768 (nsfont_draw): Remove unused variable cs.
769
770 * nsfns.m (x_set_icon_name, ns_set_name_internal)
771 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
772 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
773 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
774 (Fns_font_name, Fns_perform_service)
775 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
776 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
777 (ns_set_name): Remove unused variable view.
778 (x_set_menu_bar_lines): Remove unused variable olines.
779 (x_set_tool_bar_lines): Remove unused variable root_window.
780 (Fns_list_colors): Put () around assignment in while statement.
781 (Fns_perform_service): Remove unused variable len.
782 (Fns_display_usable_bounds): Remove unused variable top.
783 (syms_of_nsfns): Remove unused variable i.
784
b55b9f85
JD
785 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
786 memcpy (Bug#11907).
787
ed9265fc 7882012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
789
790 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
791 and free it with DestroyExceptionInfo (Bug#11558).
792
ef099b57
JB
7932012-07-13 Juanma Barranquero <lekktu@gmail.com>
794
795 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
796 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
797 Set here, not in nt/config.nt.
798
ea814a5d
EZ
7992012-07-13 Eli Zaretskii <eliz@gnu.org>
800
801 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
802 cursor overflow into the last glyph on display line when the right
803 fringe is off. (Bug#11832)
804
1a952767
PE
8052012-07-13 Paul Eggert <eggert@cs.ucla.edu>
806
807 * xdisp.c (produce_special_glyphs): Now static.
808 * dispextern.h (produce_special_glyphs): Remove decl.
809
983188fd
GM
8102012-07-13 Glenn Morris <rgm@gnu.org>
811
32fb4bb6
GM
812 * s/bsd-common, s/cygwin.h: Remove empty files.
813 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
814
983188fd
GM
815 * s/usg5-4-common.h (USG, USG5):
816 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
817 * s/sol2-6.h (SOLARIS2):
818 * s/irix6-5.h (IRIX6_5):
819 * s/hpux10-20.h (USG, USG5, HPUX):
820 * s/gnu-linux.h (USG, GNU_LINUX):
821 * s/freebsd.h (BSD_SYSTEM):
822 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
823 * s/cygwin.h (CYGWIN):
824 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
825 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
826
d1e68667 8272012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
828
829 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 830
6de0e799
GM
8312012-07-13 Glenn Morris <rgm@gnu.org>
832
739ae010
GM
833 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
834
dbee5793
GM
835 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
836
6de0e799
GM
837 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
838 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
839
b82da769
GM
8402012-07-12 Glenn Morris <rgm@gnu.org>
841
4fae5a7a 842 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
843
844 * process.c (init_process_emacs): Rename from init_process.
845 The old name is also the name of a Mach system call.
846 * lisp.h, emacs.c: Update for this name change.
847 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
848 longer needed.
849
5a979817
EZ
8502012-07-12 Eli Zaretskii <eliz@gnu.org>
851
852 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
853 memmove call that removes glyphs covered by the left truncation
854 glyph. Improve commentary.
855 (display_line): Fix display of continuation glyphs on GUI frames
856 when the right fringe is turned off and variable-size fonts are
857 used in the window. Move the code that appends a stretch glyph to
858 produce_special_glyphs, so that it could be used for truncation
859 and continuation glyphs alike.
860 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
861 glyph of a suitably computed width, to align the special glyphs at
862 the window margin. Code moved from display_line. (Bug#11832)
863
3e91a053
GM
8642012-07-12 Glenn Morris <rgm@gnu.org>
865
ba9e4b84
GM
866 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
867
868 * s/gnu-linux.h, s/hpux10-20.h:
869 Do not unconditionally define HAVE_XRMSETDATABASE.
870
3e91a053
GM
871 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
872
b300b1f4
PE
8732012-07-12 Paul Eggert <eggert@cs.ucla.edu>
874
875 Fix typos that broke OS X build.
876 Reported by Randal L. Schwartz in
877 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
878 * nsterm.m (ns_timeout): Add missing local decl.
879 (ns_get_color): snprintf -> sprintf, to fix typo.
880
6e777848
GM
8812012-07-12 Glenn Morris <rgm@gnu.org>
882
3f922c37
GM
883 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
884 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
885 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
886 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
887
0ab7b23a
GM
888 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
889 Move PTY_OPEN to configure.
890
6e777848
GM
891 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
892 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
893 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
894
4a7edc24
DA
8952012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
896
897 Use empty_unibyte_string where applicable.
898 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
899 * lread.c (read1): Likewise.
900 * xsettings.c (syms_of_xsettings): Likewise.
901
308aab79
GM
9022012-07-12 Glenn Morris <rgm@gnu.org>
903
42bd1719
GM
904 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
905 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
906 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
907 * s/hpux10-20.h (RUN_TIME_REMAP):
908 * s/bsd-common.h (TABDLY): Move to configure.
909
910 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
911
912 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
913
ea0bbd17 914 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 915 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
916
917 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 918
308aab79
GM
919 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
920 * s/template.h: Move NARROWPROTO to configure.
921
ee1cf5cf
GM
9222012-07-11 Glenn Morris <rgm@gnu.org>
923
30fe9bf4
GM
924 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
925 unused since 2011-01-17 change to systty.h.
926
ee1cf5cf
GM
927 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
928 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
929 Move HAVE_PTYS and HAVE_SOCKETS to configure.
930
63e47e07
PE
9312012-07-11 Paul Eggert <eggert@cs.ucla.edu>
932
933 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
934
c43fb4c3
GM
9352012-07-11 Glenn Morris <rgm@gnu.org>
936
937 * s/darwin.h, s/gnu-linux.h, s/template.h:
938 Move INTERRUPT_INPUT to configure.
939
e8df9267
DA
9402012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
941
942 Minor adjustments to interning code.
943 * lisp.h (intern, intern_c_string): Redefine as static inline
944 wrappers for intern_1 and intern_c_string_1, respectively.
945 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
946 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
947 Vobarray checking.
e8df9267
DA
948 * font.c (font_intern_prop): Likewise. Adjust comment.
949 * w32font.c (intern_font_name): Likewise.
950
34348bd4
AS
9512012-07-11 Andreas Schwab <schwab@linux-m68k.org>
952
d96a1e0c
AS
953 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
954
34348bd4
AS
955 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
956 of Fcar/Fcdr if possible.
957 * font.c (check_otf_features): Likewise.
958 * fontset.c (Fnew_fontset): Likewise.
959 * gnutls.c (Fgnutls_boot): Likewise.
960 * minibuf.c (read_minibuf): Likewise.
961 * msdos.c (IT_set_frame_parameters): Likewise.
962 * xmenu.c (Fx_popup_dialog): Likewise.
963 * w32menu.c (Fx_popup_dialog): Likewise.
964
c8add24e
GM
9652012-07-11 Glenn Morris <rgm@gnu.org>
966
4b575b3c
GM
967 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
968 since nothing has defined it on these platforms.
969
09f4e3b0
GM
970 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
971 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
972
172bedef
GM
973 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
974 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
975 Move CLASH_DETECTION to configure.
976
249685df
GM
977 * s/gnu.h: Remove file, which is now empty.
978
c8add24e
GM
979 * s/gnu.h, s/gnu-linux.h:
980 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
981
b41253a3
JW
9822012-07-11 John Wiegley <johnw@newartisans.com>
983
984 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
985 function attribute, so we only use it if it exists in the
986 compiler.
987
d923b542
DA
9882012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
989
990 Avoid call to strlen in fast_c_string_match_ignore_case.
991 * search.c (fast_c_string_match_ignore_case): Change to use
992 length argument. Adjust users accordingly.
993 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
994
5ebbef1d
PE
9952012-07-11 Paul Eggert <eggert@cs.ucla.edu>
996
bb352260
PE
997 Assume mkdir, rmdir.
998 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
999 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1000
57054ddd
PE
1001 Assume rename.
1002 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1003
b747d3f7
PE
1004 Assume perror.
1005 * s/hpux10-20.h (HAVE_PERROR): Remove.
1006 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1007 Remove dummy definition, as this problem was obsolete long ago.
1008
5ebbef1d
PE
1009 Assume strerror.
1010 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1011
984e7f30
DA
10122012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1013
1014 Avoid calls to strlen in font processing functions.
1015 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1016 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1017 users accordingly.
d923b542
DA
1018 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1019 Adjust prototypes.
1020 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1021 Change to return ptrdiff_t.
984e7f30
DA
1022 (xfont_list_pattern, xfont_match): Use length returned by
1023 xfont_decode_coding_xlfd.
1024 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1025
20e94fdd
GM
10262012-07-11 Glenn Morris <rgm@gnu.org>
1027
9d596af3
GM
1028 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1029 Move DONT_REOPEN_PTY to configure.
1030
20e94fdd
GM
1031 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1032 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1033
e99a530f
PE
10342012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1035
22ffb973
PE
1036 Remove "#define unix" that is no longer needed (Bug#11905).
1037 * s/aix4-2.h (unix): Remove; no longer needed.
1038
e9a9ae03
PE
1039 EMACS_TIME simplification (Bug#11875).
1040 This replaces macros (which typically do not work in GDB)
1041 with functions, typedefs and enums, making the code easier to debug.
1042 The functional style also makes code easier to read and maintain.
1043 * systime.h: Include <sys/time.h> on all hosts, not just if
1044 WINDOWSNT, since 'struct timeval' is needed in general.
1045 (EMACS_TIME): Now a typedef, not a macro.
1046 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1047 not macros.
1048 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1049 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1050 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1051 (EMACS_TIME_LE): Now functions, not macros.
1052 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1053 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1054 which are not functions. All uses rewritten to use:
1055 (make_emacs_time): New function.
1056 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1057 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1058 not functions. All uses rewritten to use the following, respectively:
1059 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1060 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1061 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1062 * fileio.c (Fcopy_file):
1063 * xterm.c (XTflash): Get the current time closer to when it's used.
1064 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1065
ffacb126
PE
1066 * bytecode.c (targets): Suppress -Woverride-init warnings.
1067
e99a530f
PE
1068 Simplify by avoiding confusing use of strncpy etc.
1069 * doc.c (Fsnarf_documentation):
1070 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1071 * frame.c (Fmake_terminal_frame):
1072 * gtkutil.c (get_utf8_string):
1073 * lread.c (openp):
1074 * nsmenu.m (ns_update_menubar):
1075 * regex.c (regerror):
1076 Prefer memcpy to strncpy and strncat when either will do.
1077 * fileio.c (Fsubstitute_in_file_name):
1078 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1079 (menu_separator_name_p):
1080 * nsmenu.m (ns_update_menubar):
1081 Prefer memcmp to strncmp when either will do.
1082 * nsterm.m: Include <ftoastr.h>.
1083 (ns_get_color):
1084 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1085 Prefer snprintf to strncpy.
1086 * nsterm.m (ns_term_init):
1087 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1088 * nsterm.m (ns_term_init):
1089 Avoid the need for strncpy, by using build_string or
1090 make_unibyte_string directly. Use dtoastr, not snprintf.
1091 * process.c (Fmake_network_process): Diagnose service names that
1092 are too long, rather than silently truncating them or creating
1093 non-null-terminated names.
1094 (Fnetwork_interface_info): Likewise, for interface names.
1095 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1096 Prefer sprintf to strncat.
1097 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1098 Prefer vsnprintf to vsprintf + strncpy.
1099
c59592b3
GM
11002012-07-10 Glenn Morris <rgm@gnu.org>
1101
1102 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1103 Clarify fallback case.
1104
7d7bbefd
DA
11052012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1106
1107 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1108 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1109 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1110 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1111 where argument type is known to be a Lisp_Cons.
1112
3a4c8000
TT
11132012-07-10 Tom Tromey <tromey@redhat.com>
1114
1115 * bytecode.c (BYTE_CODE_THREADED): New macro.
1116 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1117 (enum byte_code_op): New type.
1118 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1119 (exec_byte_code): Use them. Use token threading when applicable.
1120
2a0213a6
DA
11212012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1122
1123 Optimize pure C strings initialization.
1124 * lisp.h (make_pure_string): Fix prototype.
1125 (build_pure_c_string): New function, defined as static inline. This
1126 provides a better opportunity to optimize away calls to strlen when
1127 the function is called with compile-time constant argument.
1128 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1129 argument, adjust users accordingly. Use build_pure_c_string where
1130 appropriate.
1131 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1132 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1133 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1134
cb1caeaf
DA
11352012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1136
1137 Avoid calls to strlen in miscellaneous functions.
1138 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1139 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1140 * lread.c (openp): Likewise.
1141
c293e30c
DA
11422012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1143
1144 Avoid calls to strlen in path processing functions.
1145 * fileio.c (file_name_as_directory): Add comment. Change to add
1146 srclen argument and return the length of result. Adjust users
1147 accordingly.
1148 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1149 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1150 users accordingly.
1151 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1152
9e059e3f
GM
11532012-07-10 Glenn Morris <rgm@gnu.org>
1154
d02eb359
GM
1155 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1156 Move PENDING_OUTPUT_COUNT definition to configure.
1157
882cf227
GM
1158 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1159 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1160 * s/gnu.h (DATA_START): Move definitions to configure.
1161
af6e839f
GM
1162 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1163 We include usg5-4-common.h, which defines them both.
1164
40289a12
GM
1165 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1166 O_RDONLY already includes it).
1167
9e059e3f
GM
1168 Stop ns builds setting the EMACSLOADPATH environment variable.
1169 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1170 Now it does not set EMACSLOADPATH, just returns the load-path string.
1171 * nsterm.h: Update accordingly.
1172 * lread.c [HAVE_NS]: Include nsterm.h.
1173 (init_lread) [HAVE_NS]: Use ns_load_path.
1174 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1175
7c4e8ec0
GM
11762012-07-09 Glenn Morris <rgm@gnu.org>
1177
d4f600ff
GM
1178 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1179 since the included bsd-common.h does so.
1180
cbb31951
GM
1181 Stop ns builds setting the EMACSPATH environment variable.
1182 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1183 (ns_init_paths): Do not set EMACSPATH.
1184 * nsterm.h (ns_exec_path): Add it.
1185 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1186 Use ns_exec_path.
1187
7c4e8ec0
GM
1188 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1189
26bccfae
PE
11902012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1191
a0bee46f
PE
1192 * process.c (wait_reading_process_output): 'waitchannels' was unset
1193 when read_kbd || !NILP (wait_for_cell); fix this.
1194
5994c183
PE
1195 Add GCC-style 'const' attribute to functions that can use it.
1196 * character.h (char_resolve_modifier_mask):
1197 * keyboard.h (make_ctrl_char):
1198 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1199 (init_character_once, next_almost_prime, init_fns, init_image)
1200 (flush_pending_output, init_sound):
1201 * mem-limits.h (start_of_data):
1202 * menu.h (finish_menu_items):
1203 Add ATTRIBUTE_CONST.
1204 * emacs.c (DEFINE_DUMMY_FUNCTION):
1205 Declare the dummy function with ATTRIBUTE_CONST.
1206 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1207 Add decls with ATTRIBUTE_CONST.
1208
26bccfae
PE
1209 Minor improvements to make_formatted_string.
1210 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1211 where int is good enough, as vsprintf returns an int.
1212 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1213
a8290ec3
DA
12142012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1215
1216 Use make_formatted_string to avoid double length calculation.
1217 * lisp.h (make_formatted_string): New prototype.
1218 * alloc.c (make_formatted_string): New function.
1219 * buffer.c (Fgenerate_new_buffer_name): Use it.
1220 * dbus.c (syms_of_dbusbind): Likewise.
1221 * editfns.c (Fcurrent_time_zone): Likewise.
1222 * filelock.c (get_boot_time): Likewise.
1223 * frame.c (make_terminal_frame, set_term_frame_name)
1224 (x_report_frame_params): Likewise.
1225 * image.c (gs_load): Likewise.
1226 * minibuf.c (get_minibuffer): Likewise.
1227 * msdos.c (dos_set_window_size): Likewise.
1228 * process.c (make_process): Likewise.
1229 * xdisp.c (ensure_echo_area_buffers): Likewise.
1230 * xsettings.c (apply_xft_settings): Likewise.
1231
d01ba2f1
GM
12322012-07-09 Glenn Morris <rgm@gnu.org>
1233
1234 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1235 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1236 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1237 * nsterm.h (ns_etc_directory): Add it.
1238 * callproc.c [HAVE_NS]: Include nsterm.h.
1239 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1240
f1f924b6
DA
12412012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1242
1243 Move marker debugging code under MARKER_DEBUG.
1244 * marker.c (MARKER_DEBUG): Move marker debugging code under
1245 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1246 for bootstrap with --enable-checking (~3x slowdown reported
1247 by Juanma Barranquero <lekktu@gmail.com>).
1248 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1249
ab531b66
PE
12502012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1251
1252 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1253 See <http://bugs.gnu.org/11825#29>.
1254
c4b3bc8a
EZ
12552012-07-08 Eli Zaretskii <eliz@gnu.org>
1256
1257 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1258 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1259 (display_line): Add commentary about displaying truncation glyphs
1260 on GUI frames.
1261 (produce_special_glyphs): Move here from term.c.
1262
1263 * term.c (produce_special_glyphs): Move to xdisp.c.
1264
1265 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1266 section.
c4b3bc8a 1267
b676b881
AS
12682012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1269
f17c5273
AS
1270 * xdisp.c (display_line): Avoid warning about implicit declaration
1271 of FRAME_FONT.
1272
298819b9
AS
1273 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1274
b676b881
AS
1275 * lisp.h: Remove empty conditional.
1276
6045c4fd
PE
12772012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1278
b3350bf9
PE
1279 * lread.c (load_path_check): Now static.
1280
6045c4fd
PE
1281 Fix some minor --with-ns problems found by static checking.
1282 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1283 (x_set_font) [!HAVE_X_WINDOWS]:
1284 * image.c (xpm_load_image) [HAVE_NS]:
1285 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1286 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1287 Remove unused local.
1288 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1289 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1290 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1291 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1292 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1293 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1294 Fix pointer signedness problem.
1295 * xfaces.c (FRAME_X_FONT_TABLE):
1296 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1297
929e7845
GM
12982012-07-07 Glenn Morris <rgm@gnu.org>
1299
1300 * lread.c (load_path_check): New function, split from init_lread.
1301 (init_lread): Reorganize. Motivation:
1302 If EMACSLOADPATH is set, check/warn about that rather than the
1303 defaults, which we are not going to use. Hence we can remove
1304 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1305 Don't warn if site-lisp directories are missing.
1306 If not installed, start from a blank load-path, since
1307 PATH_LOADSEARCH refers to the eventual installation directories.
1308
58dd0aa4
EZ
13092012-07-07 Eli Zaretskii <eliz@gnu.org>
1310
1311 Support truncation and continuation glyphs on GUI frames, when
1312 fringes are disabled. (Bug#11832)
1313 * xdisp.c (init_iterator): Get dimensions of truncation and
1314 continuation glyphs even if on GUI frames. Adjust
1315 it->last_visible_x on GUI frames when the left or right fringes,
1316 or both, are absent.
1317 (start_display, move_it_in_display_line_to): Handle the case of a
1318 GUI frame without a fringe to display continuation or truncation
1319 glyphs.
1320 (insert_left_trunc_glyphs): Support GUI frames: make sure
1321 truncation glyphs overwrite enough glyphs from the current line to
1322 have sufficient space in pixels.
1323 (display_line): Support truncation and continuation glyphs on GUI
1324 frames. If some spare pixels are left on the line after inserting
1325 the truncation glyphs, fill that space with a stretch glyph of a
1326 suitably computed width.
1327
1328 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1329 produce_glyphs, to support GUI sessions.
1330
31571fd7
PE
13312012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1332
5a16b9bc
PE
1333 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1334
f3047c75
PE
1335 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1336
31571fd7
PE
1337 Do not require float-time's arg to fit in time_t (Bug#11825).
1338 This works better on hosts where time_t is unsigned, and where
1339 float-time is applied to the (negative) difference between two times.
1340 * editfns.c (decode_time_components): Last arg is now double *,
1341 not int *, and means to store all the result as a double, without
1342 worrying about whether the seconds part fits in time_t.
1343 All callers changed.
1344 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1345 All callers changed.
1346 (Ffloat_time): Do not fail merely because the specified time falls
1347 outside of time_t range.
1348
4516fbef
GM
13492012-07-07 Glenn Morris <rgm@gnu.org>
1350
1351 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1352 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1353 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1354
07adc2c6
JB
13552012-07-07 Juanma Barranquero <lekktu@gmail.com>
1356
1357 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1358 Update dependencies.
1359
1360 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1361
fd573f31
PE
13622012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1363
fee5959d
PE
1364 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1365 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1366 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1367 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1368 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1369 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1370
fd573f31
PE
1371 * xfont.c (compare_font_names): Redo to omit the need for casts.
1372
ddadbc0e
AS
13732012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1374
fca8d6b6
AS
1375 * xfns.c (Fx_change_window_property): Doc fix.
1376 * w32fns.c (Fx_change_window_property): Doc fix.
1377
ddadbc0e
AS
1378 * w32fns.c (Fx_window_property): Accept the same arguments as the
1379 X Windows version. Doc fix.
1380 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1381
ed9265fc 13822012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1383 Eli Zaretskii <eliz@gnu.org>
1384
1385 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1386 Windows-specific code from nt/config.nt moved here.
1387 Obsolete settings removed.
1388
216ee680
PE
13892012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1390
1391 * process.c: Avoid unnecessary calls to gettime.
1392 (wait_reading_process_output): Don't get the time of day
1393 when gobbling data immediately and not waiting, as there's no need
1394 for it in that case. This removes a FIXME.
1395
bdd091e4
JD
13962012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1397
1398 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1399 is defined (Bug#11768).
1400
9d44f8ce
DA
14012012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1402
1403 Fix marker debugging code.
1404 * marker.c (byte_char_debug_check): Do not perform the check
1405 if buffer is not multibyte.
090bd7cb
JB
1406 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1407 Call byte_char_debug_check with correct arguments.
9d44f8ce 1408
90fc4786
DA
14092012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1410
1411 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1412 * marker.c (byte_char_debug_check, count_markers):
1413 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1414 (byte_debug_flag): Remove.
1415 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1416 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1417
7b7ae965
DA
14182012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1419
4e57b342
DA
1420 Avoid code repetition in marker-related functions.
1421 * marker.c (attach_marker): New function.
1422 (Fset_marker, set_marker_restricted, set_marker_both)
1423 (set_marker_restricted_both): Use it.
1424 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1425 Consistently rename charno to charpos.
1426 (marker_position): Add eassert.
1427 (marker_byte_position): Convert to eassert.
1428
14292012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1430
1431 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1432 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1433 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1434
657924ff
DA
14352012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1436
1437 Introduce fast path for the widely used marker operation.
1438 * alloc.c (build_marker): New function.
1439 * lisp.h (build_marker): New prototype.
1440 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1441 * composite.c (autocmp_chars): Likewise.
1442 * editfns.c (buildmark): Remove.
1443 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1444 (save_restriction_save): Use build_marker.
1445 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1446 * window.c (save_window_save): Likewise.
1447
041a49a6
DA
14482012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1449
1450 Do not use Fdelete_overlay in delete_all_overlays
1451 to avoid redundant calls to unchain_overlay.
1452 * buffer.c (drop_overlay): New function.
1453 (delete_all_overlays, Fdelete_overlay): Use it.
1454 * minibuf.c (get_minibuffer): Fix comment.
1455
7dca65a4
PE
14562012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1457
1458 Port to OpenBSD 5.1 amd64.
1459 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1460 This is needed for OpenBSD, and should be harmless on all BSD systems.
1461 Also, include <sys/sysctl.h>, as it should be available on all
1462 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1463 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1464 use p_pid member, not kp_proc.pid.
1465
8eb876e2
GM
14662012-07-06 Glenn Morris <rgm@gnu.org>
1467
1468 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1469
38182d90
PE
14702012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1471
1472 More xmalloc and related cleanup.
1473 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1474 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1475 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1476 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1477 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1478 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1479 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1480 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1481 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1482 * xterm.c:
1483 Omit needless casts involving void * pointers and allocation.
1484 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1485 as the former is more robust if P's type is changed.
1486 Prefer xzalloc to xmalloc + memset 0.
1487 Simplify malloc-or-realloc to realloc.
1488 Don't worry about xmalloc returning a null pointer.
1489 Prefer xstrdup to xmalloc + strcpy.
1490 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1491 growing it.
1492 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1493 alloca of a constant.
1494
6dd5a677
EZ
14952012-07-05 Eli Zaretskii <eliz@gnu.org>
1496
1497 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1498 hscroll is larger than the line width. Fixes long and futile
1499 looping inside extend_face_to_end_of_line (on a TTY) producing
1500 glyphs that are not needed and thrown away.
1501
6b312f0f
DA
15022012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1503
1504 * marker.c (set_marker_restricted_both): Simplify by using
1505 clip_to_bounds.
1506
f520ef9b
PE
15072012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1508
1509 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1510
383b7c95
JD
15112012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1512
1513 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1514 not defined (Bug#11768).
1515 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1516 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1517 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1518 followed by gtk_box_set_homogeneous (Bug#11768).
1519 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1520 (update_theme_scrollbar_width, xg_create_scroll_bar):
1521 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1522 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1523 (is_box_type): New function (Bug#11768).
1524 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1525 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1526 with default display (Bug#11768).
1527
d6e7bf45
EZ
15282012-07-05 Eli Zaretskii <eliz@gnu.org>
1529
1530 * xdisp.c (window_hscroll_limited): New function.
1531 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1532 coordinates when window's hscroll is set to insanely large
1533 values. (Bug#11857)
1534
431391ec
JB
15352012-07-05 Juanma Barranquero <lekktu@gmail.com>
1536
1537 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1538 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1539
23f86fce
DA
15402012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1541
1542 Cleanup xmalloc.
1543 * lisp.h (xzalloc): New prototype. Omit needless casts.
1544 * alloc.c (xzalloc): New function. Omit needless casts.
1545 * charset.c: Omit needless casts. Convert all calls to
1546 xmalloc with following memset to xzalloc.
1547 * dispnew.c: Likewise.
1548 * fringe.c: Likewise.
1549 * image.c: Likewise.
1550 * sound.c: Likewise.
1551 * term.c: Likewise.
1552 * w32fns.c: Likewise.
1553 * w32font.c: Likewise.
1554 * w32term.c: Likewise.
1555 * xfaces.c: Likewise.
1556 * xfns.c: Likewise.
1557 * xterm.c: Likewise.
1558 * atimer.c: Omit needless casts.
1559 * buffer.c: Likewise.
1560 * callproc.c: Likewise.
1561 * ccl.c: Likewise.
1562 * coding.c: Likewise.
1563 * composite.c: Likewise.
1564 * doc.c: Likewise.
1565 * doprnt.c: Likewise.
1566 * editfns.c: Likewise.
1567 * emacs.c: Likewise.
1568 * eval.c: Likewise.
1569 * filelock.c: Likewise.
1570 * fns.c: Likewise.
1571 * gtkutil.c: Likewise.
1572 * keyboard.c: Likewise.
1573 * lisp.h: Likewise.
1574 * lread.c: Likewise.
1575 * minibuf.c: Likewise.
1576 * msdos.c: Likewise.
1577 * print.c: Likewise.
1578 * process.c: Likewise.
1579 * region-cache.c: Likewise.
1580 * search.c: Likewise.
1581 * sysdep.c: Likewise.
1582 * termcap.c: Likewise.
1583 * terminal.c: Likewise.
1584 * tparam.c: Likewise.
1585 * w16select.c: Likewise.
1586 * w32.c: Likewise.
1587 * w32reg.c: Likewise.
1588 * w32select.c: Likewise.
1589 * w32uniscribe.c: Likewise.
1590 * widget.c: Likewise.
1591 * xdisp.c: Likewise.
1592 * xmenu.c: Likewise.
1593 * xrdb.c: Likewise.
1594 * xselect.c: Likewise.
1595
0497dc44
PE
15962012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1597
1598 * fileio.c (time_error_value): Check the right error number.
1599 Problem reported by Troels Nielsen in
1600 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1601
356e7178
PE
16022012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1603
4e71fd89
PE
1604 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1605 This should be fixed in a better way; see Eli Zaretskii in
1606 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1607 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1608
f0941253
PE
1609 * fileio.c (time_error_value): Rename from special_mtime.
1610 The old name's problems were noted by Eli Zaretskii in
1611 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1612
065c9eb4
PE
1613 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1614 This variable's comment says Emacs needs at least one GDB-visible
1615 symbol of type enum pvec_type, to work around GDB problems.
1616 The symbol's value doesn't matter.
1617
356e7178
PE
1618 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1619 that causes compilation to fail on pre-C99 compilers.
1620
ed9265fc 16212012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1622
1623 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1624 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1625
3884d954
DA
16262012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1627
d209e2fb 1628 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1629 headers for buffer_defaults and buffer_local_symbols.
1630 Reported by Juanma Barranquero <lekktu@gmail.com>.
1631
ee28be33
SM
16322012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1633
1634 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1635 * lisp.h (enum pvec_type): Use fewer bits.
1636 (PSEUDOVECTOR_SIZE_BITS): New constant.
1637 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1638 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1639 change in pvec_type.
1640 (PSEUDOVECTOR_TYPEP): New macro.
1641 (TYPED_PSEUDOVECTORP): Use it.
1642 * fns.c (internal_equal): Adapt code to extract pvectype.
1643 * emacs.c (gdb_pvec_type): Update type.
1644 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1645 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1646 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1647 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1648 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1649 abusing vector->header.next.nbytes.
1650 (live_vector_p): Use PVEC_TYPE.
1651 (mark_object): Adapt code to extract pvectype. Use switch.
1652
c7f2cd7f
PE
16532012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1654
1655 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1656 Tighten new eassert a bit.
1657
8ce70ed2
DA
16582012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1659
1660 Fix compilation with --enable-gcc-warnings and -O1
1661 optimization level.
1662 * doprnt.c (doprnt): Change type of tem to int, initialize
1663 to avoid compiler warning. Add eassert.
1664 * search.c (simple_search): Initialize match_byte to avoid
1665 compiler warning. Add eassert.
1666
dea7f1e5
PE
16672012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1668
24a212eb
PE
1669 Avoid weird behavior with large horizontal scrolls.
1670 Without this change, for example, large hscroll values would
1671 mess up Emacs's display on Fedora 15 x86, presumably due to
1672 overflows in int calculations in the display code.
1673 Also, if buffers had long lines, Emacs would freeze.
1674 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1675 (set_window_hscroll): New function, containing the old guts of
1676 Fset_window_hscroll. Return the clipped value.
1677 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1678 This avoids the need to check against PTRDIFF_MAX.
1679
dea7f1e5
PE
1680 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1681
76046526
DA
16822012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1683
1684 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1685
39adff0d
PE
16862012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1687
63807d47
PE
1688 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1689 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1690 since GCC 4.4.6 issues a bogus warning for them.
1691
39adff0d
PE
1692 Fix bugs in file timestamp newness comparisons.
1693 * fileio.c (Ffile_newer_than_file_p):
1694 * lread.c (Fload): Use full timestamp resolution of files,
1695 not just the 1-second resolution, so that files that are only
1696 slightly newer still count as newer.
1697 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1698 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1699
dbeed9a6
PE
17002012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1701
1702 * fileio.c: Improve handling of file time marker. (Bug#11852)
1703 (special_mtime): New function.
1704 (Finsert_file_contents, Fverify_visited_file_modtime):
1705 Use it to set special mtime values consistently.
1706
636334d6
AS
17072012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1708
1709 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1710 marker for non-existing file. (Bug#11852)
1711
e2017fe2
GM
17122012-07-03 Glenn Morris <rgm@gnu.org>
1713
1714 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1715 and did not make it into globals.h).
1716
404dbd37
TT
17172012-07-03 Tom Tromey <tromey@redhat.com>
1718
1719 * window.c (Fset_window_margins, Fset_window_fringes)
1720 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1721 * textprop.c (Fprevious_property_change): No longer static.
1722 * syntax.c (Fsyntax_table_p): No longer static.
1723 * process.c (Fget_process, Fprocess_datagram_address): No longer
1724 static.
1725 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1726 * keyboard.c (Fcommand_execute): No longer static.
1727 Remove EXFUN.
1728 * insdel.c (Fcombine_after_change_execute): No longer static.
1729 * image.c (Finit_image_library): No longer static.
1730 * fileio.c (Fmake_symbolic_link): No longer static.
1731 * eval.c (Ffetch_bytecode): No longer static.
1732 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1733 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1734 No longer static.
404dbd37
TT
1735 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1736 static.
1737 * dired.c (Ffile_attributes): No longer static.
1738 * composite.c (Fcomposition_get_gstring): No longer static.
1739 * callproc.c (Fgetenv_internal): No longer static.
1740
1741 * ccl.h: Remove EXFUNs.
1742 * buffer.h: Remove EXFUNs.
1743 * dispextern.h: Remove EXFUNs.
1744 * intervals.h: Remove EXFUNs.
1745 * fontset.h: Remove EXFUN.
1746 * font.h: Remove EXFUNs.
1747 * dosfns.c (system_process_attributes): Remove EXFUN.
1748 * keymap.h: Remove EXFUNs.
1749 * lisp.h: Remove EXFUNs.
1750 * w32term.h: Remove EXFUNs.
1751 * window.h: Remove EXFUNs.
1752 * xsettings.h: Remove EXFUN.
1753 * xterm.h: Remove EXFUN.
1754
8e4fd1e1
GM
17552012-07-03 Glenn Morris <rgm@gnu.org>
1756
1757 * lisp.h (Frandom): Make it visible to C.
1758 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1759 buffer for invisible buffers. (Bug#1229)
1760
ca95b3eb
DA
17612012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1762
1763 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1764 values which aren't power of 2.
1765 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1766 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1767 accordingly.
1768
7555c33f
SM
17692012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1770
1771 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1772
1773 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1774
d12e8f5a
DA
17752012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1776
1777 * alloc.c (allocate_vector_block): Remove redundant
1778 calls to mallopt if DOUG_LEA_MALLOC is defined.
1779 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1780 avoid calls to mallopt if zero_vector is returned.
1781
296094c3
DA
17822012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1783
1784 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1785 is enabled, avoid dereferencing NULL current_sblock if
1786 running undumped.
1787
36429c89
DA
17882012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1789
1790 Cleanup basic buffer management.
1791 * buffer.h (struct buffer): Change layout to use generic vector
1792 marking code. Fix some comments. Change type of 'clip_changed'
1793 to bitfield. Remove unused #ifndef old.
1794 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1795 (GET_OVERLAYS_AT): Fix indentation.
1796 (for_each_per_buffer_object_at): New macro.
1797 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1798 (Fbuffer_local_variables): Use it.
1799 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1800 * alloc.c (allocate_buffer): Adjust to match new layout of
1801 struct buffer. Fix comment.
1802 (mark_overlay): New function.
1803 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1804 Lisp area of struct buffer.
1805 (mark_object): Use it. Adjust marking of misc objects
1806 and related comments.
1807
3b3e4cac
PE
18082012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1809
1810 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1811 wrapper that is not needed because the wrapped code is a no-op (zero
1812 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1813 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1814
cf5c0175
DA
18152012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1816
1817 * alloc.c (mark_buffer): Simplify. Remove prototype.
1818 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1819 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1820 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1821 redundant calls to mark_vectorlike for bool vectors.
1822
ca26824c
GM
18232012-06-30 Glenn Morris <rgm@gnu.org>
1824
2e4c5312
GM
1825 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1826
ca26824c
GM
1827 * epaths.in (PATH_SITELOADSEARCH): New.
1828 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1829 This is rather than relying on --enable-locallisppath elements
1830 having "site-lisp" in their names. (Bug#10208#25, 11658)
1831
0d23c240
EZ
18322012-06-30 Eli Zaretskii <eliz@gnu.org>
1833
c9240d7a
EZ
1834 * w32proc.c (sys_select): Accept and ignore one more argument.
1835
1836 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1837
0d23c240 1838 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1839 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1840
1841 * sysdep.c: Don't include dos.h and dosfns.h.
1842
1843 * process.c (sys_select):
1844 * msdos.c (sys_select): Accept one more argument and ignore it.
1845
1846 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1847 adapt data types and code to that.
1848
1849 * dosfns.c:
1850 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1851 which clashes with the gnulib function of the same name.
1852
af5a5a98
AS
18532012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1854
c5e4379c
AS
1855 * font.c (font_style_to_value, font_style_symbolic)
1856 (font_prop_validate_style): Add type checks for values in
1857 font_style_table.
1858
af5a5a98
AS
1859 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1860 argument.
1861 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1862 uses.
1863
8d38f461
EZ
18642012-06-29 Eli Zaretskii <eliz@gnu.org>
1865
2e5a6631
EZ
1866 * xdisp.c (try_window_id): Undo last change.
1867
8d38f461
EZ
1868 * w32.c (getwd): Adjust commentary about startup_dir.
1869 (init_environment): Always call sys_access, even in non-MSVC
1870 builds. Don't chdir to the directory of the Emacs executable.
1871 This undoes code from 1997 which was justified by the need to
1872 "avoid conflicts when removing and renaming directories". But its
1873 downside was that every relative file name was being interpreted
1874 relative to the directory of the Emacs executable, which can never
1875 be TRT. In particular, it broke sys_access when called with
1876 relative file names.
1877 (sys_access): Map GetLastError to errno.
1878
2af3565e
DA
18792012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1880
1881 * window.h (struct window): Change type of 'fringes_outside_margins'
1882 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1883 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1884 Adjust comment.
1885 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1886 to ptrdiff_t.
1887
c8d3a25c 18882012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1889
c8d3a25c
GM
1890 * gnutls.c (emacs_gnutls_handshake):
1891 Add QUIT to make the loop interruptible.
57570cd3 1892
c8d3a25c 18932012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1894
c8d3a25c
GM
1895 * charset.c (init_charset): Make lack of etc/charsets fatal.
1896
3e984ee8
DA
18972012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1898
1899 * editfns.c (region_limit): Fix type mismatch.
1900
ef884f23
DA
19012012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1902
1903 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1904 undefined. Convert from xassert to eassert.
1905 * nsmenu.m: Convert from xassert to eassert.
1906 * nsterm.m: Likewise.
1907
7d7e0027
SM
19082012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1909
1910 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1911
aa754e6a
PE
19122012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1913
1914 Avoid integer overflow on scroll-left and scroll-right.
1915 * window.c (HSCROLL_MAX): New macro.
1916 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1917 overflow when requested scroll falls outside ptrdiff_t range.
1918
80b00b08
DA
19192012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1920
1921 * window.h (struct window): Change type of 'hscroll',
1922 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1923 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1924 Adjust users accordingly.
1925 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1926 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1927 from EMACS_INT to ptrdiff_t.
1928 (make_window): Omit redundant initialization.
1929
62b2bcf6
JB
19302012-06-28 Juanma Barranquero <lekktu@gmail.com>
1931
1932 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1933
45942c7d
DA
19342012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1935
1936 * window.h (struct window): Change type of 'use_time' and
1937 'sequence_number' from Lisp_Object to int.
1938 * frame.c (make_frame): Adjust users accordingly.
1939 * print.c (print_object): Likewise.
1940 * window.c (select_window, Fwindow_use_time, make_parent_window)
1941 (make_window): Likewise.
1942
e509cfa6
DA
19432012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1944
1945 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1946 enabled with --enable-checking=[all,glyphs] configure option.
1947 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1948 adjust comments accordingly.
1949 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1950 undefined, adjust comments accordingly.
1951 * image.c: Likewise.
1952 * scroll.c: Likewise.
1953 * w32fns.c: Likewise.
1954 * w32term.c: Likewise.
1955 * xdisp.c: Likewise.
1956 * xfaces.c: Likewise.
1957 * xfns.c: Likewise.
1958 * xterm.c: Likewise.
1959
a54e2c05
DA
19602012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1961
1962 Generalize run-time debugging checks.
1963 * dispextern.h (XASSERTS): Remove.
1964 * fontset.c (xassert): Remove.
1965 Convert from xassert to eassert.
1966 * alloc.c: Convert from xassert to eassert.
1967 * bidi.c: Likewise.
1968 * dispnew.c: Likewise.
1969 * fns.c: Likewise.
1970 * fringe.c: Likewise.
1971 * ftfont.c: Likewise.
1972 * gtkutil.c: Likewise.
1973 * image.c: Likewise.
1974 * keyboard.c: Likewise.
1975 * menu.c: Likewise.
1976 * process.c: Likewise.
1977 * scroll.c: Likewise.
1978 * sound.c: Likewise.
1979 * term.c: Likewise.
1980 * w32console.c: Likewise.
1981 * w32fns.c: Likewise.
1982 * w32term.c: Likewise.
1983 * window.c: Likewise.
1984 * xdisp.c: Likewise.
1985 * xfaces.c: Likewise.
1986 * xfns.c: Likewise.
1987 * xselect.c: Likewise.
1988 * xterm.c: Likewise.
1989
1ec4b7b2
SM
19902012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1991
1992 * fns.c (maybe_resize_hash_table): Output message when growing the
1993 purify-hashtable.
1994
2014308a
DA
19952012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1996
1997 * alloc.c (allocate_string_data): Remove dead code.
1998 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1999 avoid GCC warning about unused macro.
2000
246155eb
DA
20012012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2002
2003 * alloc.c (allocate_string): Omit intervals initialization.
2004 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2005 as in make_pure_string and make_pure_c_string.
2006
43184b7b
DA
20072012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2008
d209e2fb 2009 * alloc.c (allocate_string): Fix last change.
43184b7b 2010
3fe6dd74
DA
20112012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2012
d209e2fb 2013 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2014 to memset, add explicit initialization where appropriate.
2015
1ba6038a
GM
20162012-06-27 Glenn Morris <rgm@gnu.org>
2017
2018 * lisp.mk (lisp): Remove paths.elc.
2019
c89926a5
CY
20202012-06-27 Chong Yidong <cyd@gnu.org>
2021
2022 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2023
ed6b3510
JW
20242012-06-26 John Wiegley <johnw@newartisans.com>
2025
1ec4b7b2 2026 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2027 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2028
ed6b3510
JW
2029 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2030 when building with Clang.
2031
8edd4a2b
SM
20322012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2033
2034 * eval.c (Fapply): Allow calling it with a single argument.
2035
f6f62d1b
EZ
20362012-06-26 Eli Zaretskii <eliz@gnu.org>
2037
2038 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2039 _stricmp and _strnicmp.
2040 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2041
62efea5e
DA
20422012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2043
2044 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2045 allocated window.
2046 (allocate_process): Likewise for new process.
8edd4a2b 2047 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2048 (allocate_frame): Likewise.
2049 * frame.c (make_frame): Omit redundant initialization.
2050 * window.c (make_parent_window): Use memset.
2051 (make_window): Omit redundant initialization.
2052 * process.c (make_process): Omit redundant initialization.
2053 * terminal.c (create_terminal): Likewise.
2054
42997f4d
DA
20552012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2056
2057 * term.c (delete_tty): Remove redundant call to memset.
2058
1130ecfc
DA
20592012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2060
2061 * alloc.c: Remove build_string.
2062 * lisp.h: Define build_string as static inline. This provides
2063 a better opportunity to optimize away calls to strlen when the
2064 function is called with compile-time constant argument.
2065 * image.c (imagemagick_error): Convert to build_string.
2066 * w32proc.c (sys_spawnve): Likewise.
2067 * xterm.c (x_term_init): Likewise.
2068
cf38a720
PE
20692012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2070
99027bdd
PE
2071 Use sprintf return value instead of invoking strlen on result.
2072 In the old days this wasn't portable, since some sprintf
2073 implementations returned char *. But they died out years ago and
2074 Emacs already assumes sprintf returns int.
2075 Similarly for float_to_string.
2076 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2077 * ccl.c (ccl_driver):
2078 * character.c (string_escape_byte8):
2079 * data.c (Fnumber_to_string):
2080 * doprnt.c (doprnt):
2081 * print.c (print_object):
2082 * xdisp.c (message_dolog):
2083 * xfns.c (syms_of_xfns):
2084 Use sprintf or float_to_string result to avoid need to call strlen.
2085 * data.c (Fnumber_to_string):
2086 Use make_unibyte_string, since the string must be ASCII.
2087 * lisp.h, print.c (float_to_string): Now returns int length.
2088 * term.c (produce_glyphless_glyph):
2089 Use sprintf result rather than recomputing it.
2090
cf38a720
PE
2091 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2092 * Makefile.in (ALL_CFLAGS):
2093 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2094 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2095
3511c784
DA
20962012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2097
0a08eb21 2098 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2099 strcasecmp if available.
2100 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2101
fb7da12e
AS
21022012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2103
2104 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2105 Avoid comma operator.
2106 * menu.c (push_submenu_start, push_submenu_end)
2107 (push_left_right_boundary, push_menu_pane): Likewise.
2108 * msdos.c (dos_rawgetc): Likewise.
2109
afa2ffd8
DA
21102012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2111
2112 * xfns.c (xic_create_fontsetname): Remove redundant calls
2113 to memset.
2114
b3b4476b
PE
21152012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2116
4495ff38
PE
2117 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2118 sprintf already null-terminates its output.
2119
b3b4476b
PE
2120 * xfns.c (x_window): Remove redundant cast.
2121
b00876c9
DA
21222012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2123
2124 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2125 `const char *' to `char *' to avoid compiler warning.
2126
d188e26b
PE
21272012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2128
885d1d74
PE
2129 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2130 instead of truncating it to 63 (admittedly a generous limit).
2131
d188e26b
PE
2132 * process.c: Fix spelling and caps in comments.
2133
e2f560b1
DN
21342012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2135
e86db54b 2136 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2137 * sysdep.c (setpgrp): Remove definition, not used in this file.
2138
7583a3a1
JB
21392012-06-24 Juanma Barranquero <lekktu@gmail.com>
2140
2141 * makefile.w32-in: Update dependencies.
2142
696056c2
EZ
21432012-06-24 Eli Zaretskii <eliz@gnu.org>
2144
2145 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2146 (SYSTIME_H): Add nt/inc/sys/time.h.
2147
2148 * systime.h [WINDOWSNT]: Include sys/time.h.
2149
2150 * s/ms-w32.h (struct timespec): Definition moved from
2151 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2152
845ca893
PE
21532012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2154
2155 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2156 * buffer.h (buffer_slot_type_mismatch):
2157 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2158 * eval.c (unwind_to_catch):
2159 * image.c (my_png_error, my_error_exit):
2160 * keyboard.c (quit_throw_to_read_char, user_error)
2161 (Fexit_recursive_edit, Fabort_recursive_edit):
2162 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2163 (wrong_type_argument, buffer_overflow, __executable_start)
2164 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2165 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2166 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2167 (fatal):
2168 (child_setup) [!DOS_NT]:
2169 * lread.c (end_of_file_error, invalid_syntax):
2170 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2171 * puresize.h (pure_write_error):
2172 * search.c (matcher_overflow):
2173 * sound.c (sound_perror, alsa_sound_perror):
2174 * sysdep.c, syssignal.h (croak):
2175 * term.c (maybe_fatal, vfatal):
2176 * textprop.c (text_read_only):
2177 * undo.c (user_error):
2178 * unexmacosx.c (unexec_error):
2179 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2180 Use _Noreturn rather than NO_RETURN.
2181 No need for separate decl merely because of _Noreturn.
2182 * sound.c (sound_warning, parse_sound):
2183 Remove unnecessary forward decls.
2184
f1dd8073
PE
21852012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2186
2187 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2188 * lisp.h (WAIT_READING_MAX): New macro.
2189 * dispnew.c (Fsleep_for, sit_for):
2190 * keyboard.c (kbd_buffer_get_event):
2191 * process.c (Faccept_process_output):
2192 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2193 This improves on the previous patch, which introduced a bug
2194 when time_t is unsigned and as wide as intmax_t.
2195 See <http://bugs.gnu.org/9000#51>.
2196
b82c1755
EZ
21972012-06-23 Eli Zaretskii <eliz@gnu.org>
2198
2199 * dispnew.c (sit_for, Fsleep_for):
2200 * keyboard.c (kbd_buffer_get_event):
2201 * process.c (Faccept_process_output): Avoid compiler warnings when
2202 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2203
ca300656
JB
22042012-06-23 Juanma Barranquero <lekktu@gmail.com>
2205
049ec95b
JB
2206 * makefile.w32-in: Update dependencies.
2207
ca300656
JB
2208 * w32.c (ltime): Add return type and declare static.
2209 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2210
db7b8d06
PE
22112012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2212
2213 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2214 Privately reported by Herbert J. Skuhra.
2215 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2216 All uses changed.
2217 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2218 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2219
0bd8297f
EZ
22202012-06-23 Eli Zaretskii <eliz@gnu.org>
2221
96512555
EZ
2222 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2223 last argument of make_unibyte_string.
2224
0bd8297f
EZ
2225 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2226 language ID in the event parameters.
2227
2228 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2229 event.code, not the obscure "character set ID".
2230
63def6b6
CY
22312012-06-23 Chong Yidong <cyd@gnu.org>
2232
2233 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2234
e8a02204
EZ
22352012-06-23 Eli Zaretskii <eliz@gnu.org>
2236
388cdec0
EZ
2237 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2238 * w32.c (fdutimens): New function.
2239
2240 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2241
2242 * s/ms-w32.h (pselect): Redirect to sys_select.
2243
2244 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2245
e8a02204
EZ
2246 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2247 in the logic of incrementing and decrementing the value of
2248 use_relocatable_buffers.
2249
d054f3fb
PE
22502012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2251
2252 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2253 Privately reported by Herbert J. Skuhra.
2254 [__FreeBSD__]: Remove "*/" typo after "#include".
2255 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2256 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2257 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2258 Don't assume EMACS_TIME and struct timeval are the same type.
2259
d35af63c
PE
22602012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2261
2262 Support higher-resolution time stamps (Bug#9000).
2263 The time stamps are only nanosecond-resolution at the C level,
2264 since that's the best that any real-world system supports now.
2265 But they are picosecond-resolution at the Lisp level, as that's
2266 easy, and leaves room for future OS improvements.
2267
2268 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2269 (LIBES): Use it.
2270
2271 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2272 Don't get current time unless it's needed.
2273
2274 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2275 now provides it if it's absent.
2276 (start_atimer): Port to higher-res time stamps.
2277 Check for time stamp overflow. Don't get current time more
2278 often than is needed.
2279
2280 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2281 Include systime.h, not time.h.
2282 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2283
2284 * dired.c: Include stat-time.h.
2285 (Ffile-attributes): File times now have higher resolution.
2286
2287 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2288 (struct image): Timestamp now has higher resolution.
2289
2290 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2291 has at least microseconds now. All uses removed.
2292 (update_frame, update_single_window, update_window, update_frame_1)
2293 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2294
2295 * editfns.c (time_overflow): Now extern.
2296 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2297 (float-time, Fformat_time_string, Fcurrent_time_string)
2298 (Fcurrent_time_zone): Accept and generate higher-resolution
2299 time stamps.
2300 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2301 (decode_time_components, lisp_seconds_argument): New functions.
2302 (make_time): Now static.
2303 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2304 Report an error if the time is invalid, rather than having the caller
2305 do that.
2306
2307 * fileio.c: Include <stat-time.h>
2308 (Fcopy_file): Copy higher-resolution time stamps.
2309 Prefer to set the time stamp via a file descriptor if that works.
2310 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2311 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2312 (Fvisited_file_modtime, Fset_visited_file_modtime):
2313 Support higher-resolution time stamps.
2314
2315 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2316
2317 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2318
2319 * image.c (prepare_image_for_display, clear_image_cache)
2320 (lookup_image): Port to higer-resolution time stamps.
2321
2322 * keyboard.c (start_polling, bind_polling_period):
2323 Check for time stamp overflow.
2324 (read_char, kbd_buffer_get_event, timer_start_idle)
2325 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2326 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2327 Port to higher-resolution time stamps. Do not assume time_t is signed.
2328 (decode_timer): New function. Timers are now vectors of length 9,
2329 not 8, to accommodate the picosecond component.
2330 (timer_check_2): Use it.
2331
2332 * nsterm.m (select_timeout, timeval_subtract): Remove.
2333 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2334 as they're a bit more accurate and handle overflow better.
2335 (ns_select): Change prototype to be compatible with pselect.
2336 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2337 * nsterm.h (ns_select): Adjust prototype.
2338
2339 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2340 us-resolution time stamps.
2341 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2342
2343 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2344
2345 * lisp.h (time_overflow): New decl.
2346 (wait_reading_process_output): First arg is now intmax_t, not int,
2347 to accommodate larger waits.
2348
2349 * process.h (struct Lisp_Process.read_output_delay):
2350 Now counts nanoseconds, not microseconds.
2351 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2352 EMACS_HAS_USECS.
2353 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2354 (wait_reading_process_output):
2355 Port to ns-resolution time stamps.
2356 (Faccept_process_output, wait_reading_process_output):
2357 Check for time stamp overflow. Do not assume time_t is signed.
2358 (select_wrapper): Remove; we now use pselect.
2359 (Fprocess_attributes): Now generates ns-resolution time stamps.
2360
2361 * sysdep.c: Include utimens.h. Don't include utime.h
2362 or worry about struct utimbuf; gnulib does that for us now.
2363 (gettimeofday): Remove; gnulib provides a substitute.
2364 (make_timeval): New function.
2365 (set_file_times): Now sets ns-resolution time stamps.
2366 New arg FD; all uses changed.
2367 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2368 (system_process_attributes):
2369 Now returns ns-resolution time stamp. All uses changed.
2370 Check for time stamp overflow.
2371
2372 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2373 provides a substitute now.
2374
2375 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2376 since it guarantees struct timespec.
2377 (EMACS_TIME): Now struct timespec, so that we can support
2378 ns-resolution time stamps.
2379 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2380 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2381 (EMACS_USECS): Remove.
2382 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2383 so multiply the arg by 1000 before storing it.
2384 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2385 New macros.
2386 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2387 Port to ns-resolution time stamps.
2388 (EMACS_TIME_NEG_P): Remove; replaced by....
2389 (EMACS_TIME_SIGN): New macro.
2390 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2391 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2392 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2393 (make_timeval, make_lisp_time, decode_time_components): New decls.
2394 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2395 that it mishandled time_t overflow. You can't compare by subtracting!
2396 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2397 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2398
2399 * term.c: Include <sys/time.h>.
2400 (timeval_to_Time): New function, for proper overflow wraparound.
2401 (term_mouse_position, term_mouse_click): Use it.
2402
2403 * undo.c (record_first_change): Support higher-resolution time stamps
2404 in the undo buffer.
2405 (Fprimitive_undo): Use them when restoring time stamps.
2406
2407 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2408 (w32_get_internal_run_time):
2409 Port to higher-resolution Emacs time stamps.
2410 (ltime): Now accepts single 64-bit integer, as that's more convenient
2411 for callers.
2412
2413 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2414
2415 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2416 for compatibility with pselect. Support ns-resolution time stamps.
2417
2418 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2419
2420 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2421 Check for time stamp overflow, and support ns-resolution time stamps.
2422
2423 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2424 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2425 (timeval_subtract): Remove; no longer needed.
2426 (XTflash, XTring_bell, x_wait_for_event):
2427 Port to ns-resolution time stamps. Don't assume time_t is signed.
2428
b6a92dfe
CY
24292012-06-22 Chong Yidong <cyd@gnu.org>
2430
2431 * xdisp.c (x_consider_frame_title): Revert last change.
2432
d251c37c
EZ
24332012-06-22 Eli Zaretskii <eliz@gnu.org>
2434
2435 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2436 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2437 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2438 staticidx goes up to 1597 out of 1600 = 0x640.)
2439
f10deafb
PE
24402012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2441
2442 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2443 Otherwise, the umask might be mistakenly 0 while handling input signals.
2444
ec6de1e2
SM
24452012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2446
2447 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2448
28be1ada
DA
24492012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2450
2451 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2452 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2453 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2454 access to `contents' member of Lisp_Vector objects with AREF and ASET
2455 where appropriate.
2456
c6bf3022
CY
24572012-06-19 Chong Yidong <cyd@gnu.org>
2458
2459 * frame.c (delete_frame): When selecting a frame on a different
2460 text terminal, do not alter the terminal's top-frame.
2461
2462 * xdisp.c (format_mode_line_unwind_data): Record the target
2463 frame's selected window and its terminal's top-frame.
2464 (unwind_format_mode_line): Restore them.
2465 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2466 Callers changed.
2467 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2468 since tty frames can be explicitly named.
2469 (prepare_menu_bars): Likewise.
2470
2471 * term.c (Ftty_top_frame): New function.
2472
defd4196
PE
24732012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2474
2475 Port byte-code-meter to modern targets.
2476 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2477 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2478 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2479 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2480 (METER_1, METER_2): Simplify.
2481
1053a871
SM
24822012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2483
2484 * data.c (Fdefalias): Return `symbol' (bug#11686).
2485
b7e8d081
MR
24862012-06-18 Martin Rudalics <rudalics@gmx.at>
2487
2488 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2489 gets killed during executing of this function (Bug#11665).
2490 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2491 (Vkill_buffer_query_functions): In doc-string say that functions
2492 run by this hook should not change the current buffer.
2493
7ea2b339
PE
24942012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2495
2496 Fix recently-introduced process.c problems found by static checking.
2497 * process.c (write_queue_push, write_queue_pop, send_process):
2498 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2499 (write_queue_pop): Fix pointer signedness problem.
2500 (send_process): Remove unused local.
2501
96a313a1
CY
25022012-06-17 Chong Yidong <cyd@gnu.org>
2503
2504 * xdisp.c (redisplay_internal): No need to redisplay terminal
2505 frames that are not on top.
2506
20ca2e94
TN
25072012-06-17 Troels Nielsen <bn.troels@gmail.com>
2508
2509 * process.c (make_process): Initialize write_queue.
2510 (write_queue_push, write_queue_pop): New functions.
2511 (send_process): Use them to maintain correct ordering of process
2512 writes (Bug#10815).
2513
9a900ca9
PE
25142012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2515
310fbfa8
PE
2516 * lisp.h (eassert): Assume C89 or later.
2517 This removes the need for CHECK.
2518 (CHECK): Remove. Its comments about always evaluating its
2519 argument were confusing, as 'eassert' typically does not evaluate
2520 its argument.
2521
27bb1ca4
PE
2522 * coding.c (produce_chars): Use ptrdiff_t, not int.
2523
9a900ca9
PE
2524 * xterm.c (x_draw_underwave): Check for integer overflow.
2525 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2526
41b7f8bc 25272012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2528
2529 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2530 referenced (Bug#11583).
2531
9b0e3eba
AA
25322012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2533
2534 Implement wave-style variant of underlining.
2535 * dispextern.h (face_underline_type): New enum.
2536 (face): Add field for underline type.
2537 * nsterm.m (ns_draw_underwave): New function.
2538 (ns_draw_text_decoration): Use it.
2539 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2540 New functions.
2541 (x_draw_glyph_string): Use them.
2542 * xfaces.c (Qline, Qwave): New Lisp objects.
2543 (check_lface_attrs, merge_face_ref)
1053a871
SM
2544 (Finternal_set_lisp_face_attribute, realize_x_face):
2545 Handle wave-style underline face attributes.
9b0e3eba
AA
2546 * xterm.c (x_draw_underwave): New function.
2547 (x_draw_glyph_string): Use it.
2548
0fb52f11
JB
25492012-06-16 Juanma Barranquero <lekktu@gmail.com>
2550
2551 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2552 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2553 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2554 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2555 ($(BLD)/w32select.$(O)): Update dependencies.
2556
e5560ff7
AS
25572012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2558
2559 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2560 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2561 * character.c (_fetch_multibyte_char_p): Remove.
2562 * alloc.c: Include "character.h" before "buffer.h".
2563 * bidi.c: Likewise.
2564 * buffer.c: Likewise.
2565 * bytecode.c: Likewise.
2566 * callint.c: Likewise.
2567 * callproc.c: Likewise.
2568 * casefiddle.c: Likewise.
2569 * casetab.c: Likewise.
2570 * category.c: Likewise.
2571 * cmds.c: Likewise.
2572 * coding.c: Likewise.
2573 * composite.c: Likewise.
2574 * dired.c: Likewise.
2575 * dispnew.c: Likewise.
2576 * doc.c: Likewise.
2577 * dosfns.c: Likewise.
2578 * editfns.c: Likewise.
2579 * emacs.c: Likewise.
2580 * fileio.c: Likewise.
2581 * filelock.c: Likewise.
2582 * font.c: Likewise.
2583 * fontset.c: Likewise.
2584 * fringe.c: Likewise.
2585 * indent.c: Likewise.
2586 * insdel.c: Likewise.
2587 * intervals.c: Likewise.
2588 * keyboard.c: Likewise.
2589 * keymap.c: Likewise.
2590 * lread.c: Likewise.
2591 * macros.c: Likewise.
2592 * marker.c: Likewise.
2593 * minibuf.c: Likewise.
2594 * nsfns.m: Likewise.
2595 * nsmenu.m: Likewise.
2596 * print.c: Likewise.
2597 * process.c: Likewise.
2598 * regex.c: Likewise.
2599 * region-cache.c: Likewise.
2600 * search.c: Likewise.
2601 * syntax.c: Likewise.
2602 * term.c: Likewise.
2603 * textprop.c: Likewise.
2604 * undo.c: Likewise.
2605 * unexsol.c: Likewise.
2606 * w16select.c: Likewise.
2607 * w32fns.c: Likewise.
2608 * w32menu.c: Likewise.
2609 * window.c: Likewise.
2610 * xdisp.c: Likewise.
2611 * xfns.c: Likewise.
2612 * xmenu.c: Likewise.
2613 * xml.c: Likewise.
2614 * xselect.c: Likewise.
2615
2f07e6af
EZ
26162012-06-16 Eli Zaretskii <eliz@gnu.org>
2617
1053a871
SM
2618 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2619 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2620 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2621 row.
2622 (handle_face_prop): Use chunk-relative overlay string index when
2623 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2624 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2625 the rightmost. (Bug#11720)
2f07e6af 2626
29b83cec
AS
26272012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2628
2629 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2630 (CATEGORY_MEMBER): Enforce 1/0 value.
2631 * category.c (_temp_category_set): Remove.
2632
4c5501e9
EZ
26332012-06-16 Eli Zaretskii <eliz@gnu.org>
2634
2635 * window.c (Fdelete_other_windows_internal)
2636 (Fdelete_window_internal): Don't access frame's mouse highlight
2637 info of the initial frame. (Bug#11677)
2638
2b570124
PE
26392012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2640
e93864f9
PE
2641 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2642 Assume USE_2_TAGS_FOR_INTS.
2643 (xreload): Adjust $tagmask width to match recent lisp.h change.
2644
2b570124
PE
2645 Simplify lisp.h in minor ways that should not affect code.
2646 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2647 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2648 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2649 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2650 (INTTYPEBITS): New macro, for clarity.
2651 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2652 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2653 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2654 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2655 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2656
81755f69
JB
26572012-06-13 Juanma Barranquero <lekktu@gmail.com>
2658
2659 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2660
16192a57
GM
26612012-06-13 Glenn Morris <rgm@gnu.org>
2662
2663 * s/bsd-common.h (BSD4_3):
2664 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2665
646b5f55
AS
26662012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2667
2668 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2669 instead of union.
2670 (XLI, XIL): Define.
1053a871
SM
2671 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2672 Use them.
2673 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2674 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2675 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2676 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2677 * frame.c (delete_frame): Remove outdated comment.
2678 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2679 USE_LISP_UNION_TYPE.
2680 (Fw32_unregister_hot_key): Likewise.
2681 (Fw32_toggle_lock_key): Likewise.
2682 * w32menu.c (add_menu_item): Likewise.
2683 (w32_menu_display_help): Use XIL instead of checking
2684 USE_LISP_UNION_TYPE.
2685 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2686 (init_heap): Likewise.
2687 * w32term.c (w32_read_socket): Update comment.
2688
1d3823c9
GM
26892012-06-13 Glenn Morris <rgm@gnu.org>
2690
c62ff706
GM
2691 * s/usg5-4-common.h, src/s/unixware.h:
2692 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2693
1d3823c9
GM
2694 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2695
bfe3e0a2
PE
26962012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2697
2698 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2699 * alloc.c (make_number) [!defined make_number]:
2700 Remove, as lisp.h always defines this now.
2701 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2702 (roundup_size): Verify that it is a power of 2.
2703 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2704 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2705 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2706 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2707 USE_LSB_TAG now is always defined to be either 0 or 1.
2708 All uses changed.
2709 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2710 code works fine either way, and efficiency is not a concern here,
2711 as the union type is for debugging, not for production.
2712 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2713 Use an inline function on all platforms when using the union type,
2714 since this is simpler and 'static inline' can be used portably
2715 within Emacs now.
2716 (LISP_INITIALLY_ZERO): New macro.
2717 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2718 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2719
45fa9c0f
GM
27202012-06-12 Glenn Morris <rgm@gnu.org>
2721
b4492cba
GM
2722 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2723
2724 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2725
45fa9c0f
GM
2726 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2727 Move BROKEN_SIGIO to configure.
2728
2729 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2730 Move NO_TERMIO to configure.
2731
0e25d334
CY
27322012-06-12 Chong Yidong <cyd@gnu.org>
2733
2734 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2735 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2736 MagickExportImagePixels is undefined.
2737
43682bb6
PE
27382012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2739
2740 * image.c (imagemagick_load_image): Remove unused label.
2741
a9be7d2b
GM
27422012-06-11 Glenn Morris <rgm@gnu.org>
2743
2744 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2745 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2746 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2747 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2748
3017f87f
SM
27492012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2750
2751 * alloc.c (make_byte_code): New function.
2752 (Fmake_byte_code): Use it. Don't purify here.
2753 * lread.c (read1): Use it as well to avoid extra allocation.
2754
1b9b4cf4
CY
27552012-06-11 Chong Yidong <cyd@gnu.org>
2756
2757 * image.c (imagemagick_load_image): Implement transparency.
2758
95988fcf
AS
27592012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2760
2761 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2762 account for preceding backslashes. (Bug#11663)
2763
cd4eb164
CY
27642012-06-09 Chong Yidong <cyd@gnu.org>
2765
2766 * term.c: Support italics in capable terminals (Bug#9652).
2767 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2768 (turn_on_face): Output using TS_enter_italic_mode if available.
2769 Don't handle unused blinking and alt-charset cases.
2770 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2771 and tty_alt_charset_p cases.
2772 (tty_capable_p, init_tty): Support italics.
2773
2774 * termchar.h (struct tty_display_info): Add field for italics.
2775 Remove unused blink field.
2776
2777 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2778 Handle slant.
2779
2780 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2781 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2782 tty_alt_charset_p. Add tty_italic_p.
2783
ff88beb8
MA
27842012-06-09 Michael Albinus <michael.albinus@gmx.de>
2785
2786 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2787 dbus_type_is_basic if available.
2788 (xd_extract_signed, xd_extract_unsigned): Rename from
2789 extract_signed and extract_unsigned, respectively. Adapt callers.
2790
44286096
CY
27912012-06-09 Chong Yidong <cyd@gnu.org>
2792
1682701f
CY
2793 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2794
44286096
CY
2795 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2796 case (Bug#9752).
2797
d86feb17
PE
27982012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2799
2800 * xdisp.c (vmessage): Treat frame message as multibyte.
2801 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2802 would generate the diagnostic "Making \302\247 buffer-local while
2803 let-bound!".
2804
d5c20fe8
EZ
28052012-06-08 Eli Zaretskii <eliz@gnu.org>
2806
2807 * dispnew.c (showing_window_margins_p): Undo last change, which
2808 was done due to an inadvertent commit.
2809 (adjust_frame_glyphs_for_frame_redisplay): Do call
2810 showing_window_margins_p.
2811
513749ee
SM
28122012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2813
2814 * eval.c (Fmake_var_non_special): New primitive.
2815 (syms_of_eval): Defsubr it.
2816 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2817
d4a8f5c1
JB
28182012-06-08 Juanma Barranquero <lekktu@gmail.com>
2819
2820 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2821 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2822
8bbbc977
EZ
28232012-06-08 Eli Zaretskii <eliz@gnu.org>
2824
2825 * alloc.c (allocate_vectorlike): Fix last change.
2826
f3372c87
DA
28272012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2828
2829 Block-based vector allocation of small vectors.
2830 * lisp.h (struct vectorlike_header): New field `nbytes',
2831 adjust comment accordingly.
2832 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2833 to denote vector blocks. Adjust users (live_vector_p,
2834 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2835 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2836 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2837 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2838 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2839 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2840 (roundup_size): New constant.
2841 (struct vector_block): New data type.
2842 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2843 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2844 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2845 (sweep_vectors): New functions.
2846 (allocate_vectorlike): Return `zero_vector' as the only vector of
2847 0 items. Allocate new vector from block if vector size is less than
2848 or equal to VBLOCK_BYTES_MAX.
2849 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2850 (init_alloc_once): Add call to init_vectors.
2851
4f18a4ed
SM
28522012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2853
2854 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2855
86f158bc
PE
28562012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2857
2858 * doprnt.c (doprnt): Truncate multibyte char correctly.
2859 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2860 would mishandle a string argument "Xc" if X was a multibyte
2861 character of length 2: it would truncate after X's first byte
2862 rather than including all of X.
2863
c5cfcbe0
CY
28642012-06-06 Chong Yidong <cyd@gnu.org>
2865
2866 * buffer.c (word_wrap): Doc fix.
2867
c05cf390
PE
28682012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2869
2870 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2871
0c3461de
GM
28722012-06-03 Glenn Morris <rgm@gnu.org>
2873
2874 * xdisp.c (tool-bar-style): Doc fix.
2875
c71232db
UM
28762012-06-03 Ulrich Müller <ulm@gentoo.org>
2877
2878 * Makefile.in (PAXCTL): Define.
2879 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2880 binary via PaX flags if the paxctl utility is available.
2881 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2882 Restore PaX flags to their default. (Bug#11398)
2883
383f7350
CY
28842012-06-03 Chong Yidong <cyd@gnu.org>
2885
2886 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2887 buffer (Bug#11226).
2888
5f2c76c6
CY
28892012-06-03 Chong Yidong <cyd@gnu.org>
2890
2891 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2892 (note_mode_line_or_margin_highlight): If there is no help echo,
2893 use mode-line-default-help-echo. Handle the case where the mouse
2894 position is past the end of the mode line string.
2895
2896 * buffer.c (buffer_local_value_1): New function, split from
2897 Fbuffer_local_value; can return Qunbound.
2898 (Fbuffer_local_value): Use it.
2899 (Vmode_line_format): Docstring tweaks.
2900
773d47f6
PE
29012012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2902
2903 * sysdep.c (system_process_attributes): Improve comment.
2904
f2d6a3df
SM
29052012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2906
2907 * keyboard.c: Export real-this-command to Elisp.
2908 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2909 and DEFVAR it. Update all users.
2910
63810350
PE
29112012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2912
7bd5c1f4
PE
2913 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2914
63810350
PE
2915 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2916 Convert pctcpu and pctmem to Lisp float properly.
2917 Let the compiler fold better, as 100.0/0x8000 is exact.
2918
a2821611
AS
29192012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2920
2921 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2922 cons_block.
2923
5fceba1d
PE
29242012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2925
2926 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2927
c98ff5dd
DA
29282012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2929
2930 For a 'struct window', replace some Lisp_Object fields to
2931 bitfields where appropriate, remove unused fields.
2932 * window.h (struct window): Remove unused 'last_mark_x' and
2933 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2934 change it's type from Lisp_Object to bitfield.
2935 Change type of 'force_start', 'optional_new_start',
2936 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2937 fields from Lisp_Object to bitfield. Adjust users accordingly.
2938
ca34e0be
PE
29392012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2940
2941 Pacify gcc -Wdouble-precision when using Xaw.
2942 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2943 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2944 Use 'float' consistently, rather than 'float' in most places
2945 and 'double' in a couple of places.
2946
efc00ab1 29472012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2948
2949 * xdisp.c (handle_stop): Detect whether we have overlay strings
2950 loaded by testing it->current.overlay_string_index to be
2951 non-negative, instead of checking whether n_overlay_strings is
2952 positive. (Bug#11587)
2953
efc00ab1 29542012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2955
2956 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2957
2958 * doc.c (Fsubstitute_command_keys): Doc fix.
2959
efc00ab1 29602012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2961
2962 * search.c (search_buffer): Remove calls to
2963 r_alloc_inhibit_buffer_relocation, as it is now called by
2964 maybe_unify_char, which was the cause of relocation of buffer text
2965 in bug#11519.
2966
efc00ab1 29672012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2968
2969 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2970 for the duration of call to load_charset, to avoid problems with
2971 callers of maybe_unify_char that access buffer text through C
2972 pointers.
2973
2974 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2975 decrement the inhibition flag, instead of just setting or
2976 resetting it.
2977
ba93a187
PE
29782012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2979
2980 Remove obsolete '#define static' cruft.
2981 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2982 This #undef was "temporary" in 2000; it is no longer needed
2983 now that '#define static' has gone away.
2984 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2985 (gray_bitmap_bits): Remove; no longer needed.
2986 All uses replaced with definiens.
2987 * xterm.c: Include "bitmaps/gray.xbm".
2988
9e4bf381
PE
29892012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2990
2991 Clean up __executable_start, monstartup when --enable-profiling.
2992 The following changes affect the code only when profiling.
2993 * dispnew.c (__executable_start): Rename from safe_bcopy.
2994 Define only on platforms that need it.
2995 * emacs.c: Include <sys/gmon.h> when profiling.
2996 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2997 (__executable_start): Remove decl, since lisp.h does it now.
2998 (safe_bcopy): Remove decl; no longer has that name.
2999 (main): Coalesce #if into single bit of code, for simplicity.
3000 Cast pointers to uintptr_t, since standard libraries want integers
3001 and not pointers.
3002 * lisp.h (__executable_start): New decl.
3003
32d72c2f
GM
30042012-05-31 Glenn Morris <rgm@gnu.org>
3005
3006 * image.c (Fimagemagick_types): Doc fix.
3007
baac5bc7
JM
30082012-05-30 Jim Meyering <meyering@redhat.com>
3009
3010 * callproc.c (Fcall_process_region): Include directory component
3011 in mkstemp error message (Bug#11586).
3012
72cb32cf
PE
30132012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3014
3015 * alloc.c, lisp.h (make_pure_vector): Now static.
3016
61b108cc
SM
30172012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3018
3019 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3020 Move to byte-run.el.
3021 (Fautoload): Do the hash-doc more carefully.
3022 * data.c (Fdefalias): Purify definition, except for keymaps.
3023 (Qdefun): Move from eval.c.
3024 * lisp.h (Qdefun): Remove.
3025 * lread.c (read1): Tiny simplification.
3026
471fe23d
TN
30272012-05-29 Troels Nielsen <bn.troels@gmail.com>
3028
934f3f58 3029 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3030 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3031 Bug#9642, but explicitly check that the buffer the overlay would
3032 be moved to is live and rearrange lines to make sure that errors
3033 will not put the overlay in an inconsistent state.
3034 (Fdelete_overlay): Cosmetics.
3035
85d0efd1
EZ
30362012-05-28 Eli Zaretskii <eliz@gnu.org>
3037
3038 * w32term.c (my_bring_window_to_top): New function.
3039 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3040 could be different from the original one.
3041 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3042 (Bug#11513)
3043
3044 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3045 by calling BringWindowToTop.
3046
3047 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3048 (WM_EMACS_END): Increase by one.
3049
da92a98c
PE
30502012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3051
3052 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3053 This avoids undefined behavior that might cause the eassert
3054 to not catch an out-of-range value.
3055
74d1f848
JB
30562012-05-28 Juanma Barranquero <lekktu@gmail.com>
3057
3058 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3059 Update dependencies.
3060
9e1a06fc
EZ
30612012-05-27 Eli Zaretskii <eliz@gnu.org>
3062
3063 * bidi.c (bidi_mirror_char): Fix last change.
3064
f3dd7312
AS
30652012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3066
3067 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3068 when referring to sectname field in printf format.
3069
81899c91
PE
30702012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3071
57b81a9f
PE
3072 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3073 Only r_alloc_inhibit_buffer_relocation needed to be added;
3074 the others were already declared.
3075
81899c91
PE
3076 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3077 before checking whether it's out of range. Put the check inside
3078 eassert. See
3079 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3080
33017faf 30812012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3082
3083 * callproc.c (Fcall_process): Restore a line that was accidentally
3084 commented out in the 2011-02-13 change (bug#11547).
3085
33017faf 30862012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3087
3088 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3089 defined on ralloc.c.
3090
3091 * buffer.c [REL_ALLOC]: Remove prototypes of
3092 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3093 they are now on lisp.h.
3094
3095 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3096
3097 * search.c (search_buffer): Use it to inhibit relocation of buffer
3098 text while re_search_2 is doing its job, because re_search_2 is
3099 passed C pointers to buffer text. (Bug#11519)
3100
23415acf
EZ
3101 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3102 Update value to 24.
3103
44e27368
EZ
3104 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3105 state after an additional call to move_it_in_display_line_to, keep
3106 the values of it->max_ascent and it->max_descent found for the
3107 entire line.
3108 (pos_visible_p): Revert the comparison against bottom_y to what it
3109 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3110 (Bug#11464)
3111
c1892f11
PE
31122012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3113
3114 Fix coding-related core dumps with gcc -ftrapv.
3115 The code was computing A - B, where A and B are pointers, and B is
3116 random garbage. This can lead to core dumps on platforms that
3117 have special pointer registers, and it also leads to core dumps on
3118 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3119 A - B only when B is initialized properly.
3120 * coding.c (coding_set_source, coding_set_destination): Return void.
3121 (coding_change_source, coding_change_destinations): New functions,
3122 with the old behaviors of coding_set_source and coding_set_destination.
3123 All callers that need an offset changed to use these new functions.
3124
eb7afdad
GM
31252012-05-26 Glenn Morris <rgm@gnu.org>
3126
3127 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3128
f12fdf02
EZ
31292012-05-26 Eli Zaretskii <eliz@gnu.org>
3130
53a63be6 3131 Extend mouse support on W32 text-mode console.
61b108cc
SM
3132 * xdisp.c (draw_row_with_mouse_face):
3133 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3134
eb3f6f01 3135 * w32console.c: Include window.h.
61b108cc
SM
3136 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3137 New functions.
eb3f6f01
EZ
3138 (initialize_w32_display): Initialize mouse-highlight data.
3139
53a63be6
EZ
3140 * w32inevt.c: Include termchar.h and window.h.
3141 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3142 moves, call note_mouse_highlight. If help_echo changed, call
3143 gen_help_event to produce help-echo message in the echo area.
3144 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3145 highlight info.
3146
4cfd81f6
PE
31472012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3148
3149 * lread.c (read1): Simplify slightly to avoid an overflow warning
3150 with GCC 4.7.0 on x86-64.
3151
4446092a
EZ
31522012-05-26 Eli Zaretskii <eliz@gnu.org>
3153
3154 * bidi.c (bidi_mirror_char): Revert last change: an int is
3155 definitely wide enough here.
3156
42b2a986 31572012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3158
42b2a986 3159 Fix integer width and related bugs (Bug#9874).
eb106a49 3160 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3161 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3162 (string_bytes, check_sblock, allocate_string_data):
3163 (compact_small_strings, Fmake_bool_vector, make_string)
3164 (make_unibyte_string, make_multibyte_string)
3165 (make_string_from_bytes, make_specified_string)
3166 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3167 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3168 (mark_vectorlike):
3169 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3170 (allocate_pseudovector):
3171 Use int, not EMACS_INT, where int is wide enough.
3172 (inhibit_garbage_collection, Fgarbage_collect):
3173 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3174 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3175 int might not be wide enough.
3176 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3177 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3178 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3179 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3180 (bidi_level_of_next_char, bidi_move_to_visually_next):
3181 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3182 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3183 (Fkill_buffer, Fset_buffer_major_mode)
3184 (advance_to_char_boundary, Fbuffer_swap_text)
3185 (Fset_buffer_multibyte, overlays_at, overlays_in)
3186 (overlay_touches_p, struct sortvec, record_overlay_string)
3187 (overlay_strings, recenter_overlay_lists)
3188 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3189 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3190 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3191 (Foverlay_recenter, last_overlay_modification_hooks_used)
3192 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3194 (validate_region): Omit unnecessary test for b <= e,
3195 since that's guaranteed by the previous test.
d311d28c
PE
3196 (adjust_overlays_for_delete): Avoid pos + length overflow.
3197 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3198 (report_overlay_modification):
3199 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3200 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3201 Omit pointer cast, which isn't needed anyway, and doesn't work
3202 after the EMACS_INT -> ptrdiff_t change.
02481186 3203 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3204 * buffer.h: Adjust decls to match defn changes elsewhere.
3205 (struct buffer_text, struct buffer):
3206 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3207 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3208 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3209 not int, to avoid needless 32-bit limit on 64-bit hosts.
3210 (exec_byte_code): Use tighter memory-full test, one that checks
3211 for alloca overflow. Don't compute the address of the object just
3212 before an array, as that's not portable. Use EMACS_INT, not
3213 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3214 * callint.c (Fcall_interactively):
3215 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3216 * callproc.c (call_process_kill, Fcall_process):
3217 Don't assume pid_t fits into an Emacs fixnum.
3218 (call_process_cleanup, Fcall_process, child_setup):
3219 Don't assume pid_t fits into int.
3220 (call_process_cleanup, Fcall_process, delete_temp_file)
3221 (Fcall_process_region):
3222 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3223 (Fcall_process): Simplify handling of volatile integers.
3224 Use int, not EMACS_INT, where int will do.
3225 * casefiddle.c (casify_object, casify_region, operate_on_word)
3226 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3227 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3228 (casify_object): Avoid integer overflow when overallocating buffer.
3229 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3230 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3231 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3232 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3233 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3234 integers are now checked earlier. All uses replaced with XINT.
3235 (ccl_driver):
3236 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3237 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3238 (ccl_driver, Fregister_code_conversion_map):
3239 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3240 (resolve_symbol_ccl_program): Check that vector header is in range.
3241 Always copy the vector, so that we can check its contents reliably
3242 now rather than having to recheck each instruction as it's being
3243 executed. Check that vector words fit in 'int'.
3244 (ccl_get_compiled_code, Fregister_ccl_program)
3245 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3246 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3247 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3248 contents are in range.
3249 (Fccl_execute_on_string): Check that status is in range.
3250 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3251 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3252 Accept and return EMACS_INT, not int, because callers can pass values
3253 out of 'int' range.
3254 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3255 (multibyte_chars_in_text, parse_str_as_multibyte)
3256 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3257 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3258 (string_escape_byte8, Fget_byte):
3259 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3260 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3261 avoid mishandling large integers.
3262 * character.h: Adjust decls to match defn changes elsewhere.
3263 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3264 (Ffind_charset_region):
3265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3266 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3267 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3268 Don't assume fixnum fits in int.
d311d28c
PE
3269 (load_charset_map_from_vector, Fmap_charset_chars):
3270 Remove now-unnecessary CHECK_NATNUMs.
3271 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3272 Don't rely on undefined behavior with signed left shift overflow.
3273 Don't assume unsigned int fits into fixnum, or that fixnum fits
3274 into unsigned int. Don't require max_code to be a valid fixnum;
3275 that's not true for gb10830 4-byte on a 32-bit host. Allow
3276 invalid_code to be a cons, for the same reason. Require code_offset
3277 to be a character. Avoid int overflow if max_char is close
3278 to INT_MAX.
3279 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3280 this is intended anyway and avoids some undefined behavior.
3281 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3282 INDEX_TO_CODE_POINT, as that's what it expects.
3283 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3284 * charset.h (DECODE_CHAR): Return int, not unsigned;
3285 this is what was intended anyway, and it avoids undefined behavior.
3286 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3287 integer-overflow issues.
3288 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3289 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3290 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3291 * chartab.c (Fmake_char_table, Fset_char_table_range)
3292 (uniprop_get_decoder, uniprop_get_encoder):
3293 Don't assume fixnum fits in int.
3294 * cmds.c (move_point): New function, that does the gist of
3295 Fforward_char and Fbackward_char, but does so while checking
3296 for integer overflow more accurately.
c96e5d6a 3297 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3298 (Fforward_line, Fend_of_line, internal_self_insert)
3299 (internal_self_insert):
3300 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3301 Fix a FIXME, by checking for integer overflow when calculating
3302 target_clm and actual_clm.
3303 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3304 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3305 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3306 (coding_alloc_by_making_gap, alloc_destination)
3307 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3308 (encode_coding_utf_16, detect_coding_emacs_mule)
3309 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3310 (detect_coding_iso_2022, decode_coding_iso_2022)
3311 (encode_invocation_designation, encode_designation_at_bol)
3312 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3313 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3314 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3315 (encode_coding_ccl, encode_coding_raw_text)
3316 (detect_coding_charset, decode_coding_charset)
3317 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3318 (produce_composition, produce_charset, produce_annotation)
3319 (decode_coding, handle_composition_annotation)
3320 (handle_charset_annotation, consume_chars, decode_coding_gap)
3321 (decode_coding_object, encode_coding_object, detect_coding_system)
3322 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3323 (code_convert_region, code_convert_string)
8f50130c
PE
3324 (Fdefine_coding_system_internal)
3325 (coding_set_source, coding_set_destination):
d311d28c
PE
3326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3327 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3328 (Fdefine_coding_system_internal):
3329 Don't assume fixnums fit in int.
3330 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3331 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3332 (Funencodable_char_position, Fcheck_coding_systems_region)
3333 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3334 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3335 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3336 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3337 Don't access memory outside of the args array.
d311d28c 3338 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3339 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3340 result of ENCODE_CHAR.
d311d28c
PE
3341 * coding.h: Adjust decls to match defn changes elsewhere.
3342 (struct coding_system):
3343 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3344 * composite.c (get_composition_id, find_composition)
3345 (run_composition_function, update_compositions)
3346 (compose_text, composition_gstring_put_cache)
3347 (composition_gstring_p, composition_gstring_width)
3348 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3349 (composition_compute_stop_pos, composition_reseat_it)
3350 (composition_update_it, struct position_record)
3351 (find_automatic_composition, composition_adjust_point)
3352 (Fcomposition_get_gstring, Ffind_composition_internal):
3353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3354 (update_compositions):
3355 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3356 * composite.h: Adjust decls to match defn changes elsewhere.
3357 (struct composition):
3358 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3359 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3360 Do not attempt to compute the address of the object just before a
3361 buffer; this is not portable.
3362 (Faref, Faset):
3363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3364 (Faset): Use int, not EMACS_INT, where int is wide enough.
3365 (Fstring_to_number): Don't assume fixnums fit in int.
3366 (Frem): Don't assume arg is nonnegative.
3367 * dbusbind.c (xd_append_arg): Check for integers out of range.
3368 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3369 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3370 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3371 (xd_get_connection_references): Return ptrdiff_t, not int.
3372 All uses changed.
3373 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3374 (xd_read_message_1):
3375 Use int, not unsigned, where the dbus API uses int.
3376 (Fdbus_message_internal): Don't overflow mtype.
3377 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3378 * dired.c (directory_files_internal, file_name_completion, scmp)
3379 (file_name_completion_stat):
3380 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3381 (file_name_completion): Don't overflow matchcount.
3382 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3383 * dispextern.h: Adjust decls to match defn changes elsewhere.
3384 (struct text_pos, struct glyph, struct bidi_saved_info)
3385 (struct bidi_string_data, struct bidi_it, struct composition_it)
3386 (struct it):
3387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3388 (struct display_pos, struct composition_it, struct it):
3389 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3390 * dispnew.c (increment_matrix_positions)
3391 (increment_row_positions, mode_line_string)
3392 (marginal_area_string):
3393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3394 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3395 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3396 (duration_to_sec_usec): New function, to check for overflow better.
3397 (Fsleep_for, sit_for): Use it.
3398 * doc.c (get_doc_string, store_function_docstring):
3399 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3400 (get_doc_string, Fsnarf_documentation):
3401 Use int, not EMACS_INT, where int is wide enough.
3402 (get_doc_string):
3403 Use SAFE_ALLOCA, not alloca.
3404 Check for overflow when converting EMACS_INT to off_t.
3405 * doprnt.c (doprnt):
3406 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3407 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3408 Don't assume uid_t fits into fixnum.
3409 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3410 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3411 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3412 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3413 (general_insert_function)
3414 (Finsert_char, make_buffer_string, make_buffer_string_both)
3415 (update_buffer_properties, Fbuffer_substring)
3416 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3417 (Fsubst_char_in_region, check_translation)
3418 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3419 (transpose_markers, Ftranspose_regions):
3420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3421 (clip_to_bounds): Move to lisp.h as an inline function).
3422 (Fconstrain_to_field): Don't assume integers are nonnegative.
3423 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3424 (Fsubst_char_in_region, Fsave_restriction):
3425 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3426 (Femacs_pid): Don't assume pid_t fits into fixnum.
3427 (lo_time): Use int, not EMACS_INT, when int suffices.
3428 (lisp_time_argument): Check for usec out of range.
3429 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3430 (Fuser_login_name, Fuser_full_name): Signal an error
3431 if a uid argument is out of range, rather than relying on
3432 undefined behavior.
c8d5c857
PE
3433 (Fformat_time_string): Remove now-unnecessary check.
3434 lisp_time_argument checks for out-of-range usec now.
243e0530 3435 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3436 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3437 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3438 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3439 (init_cmdargs, Fdump_emacs):
3440 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3441 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3442 the bottom (typically) 32 bits of the fixnum.
3443 * eval.c (specpdl_size, call_debugger):
3444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3445 (when_entered_debugger, Fbacktrace_debug):
3446 Don't assume fixnum can fit in int.
3447 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3448 the object just before a buffer; this is not portable.
3449 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3450 (grow_specpdl, unbind_to):
3451 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3452 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3453 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3454 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3455 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3456 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3458 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3459 (a_write, e_write):
3460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3461 (Fcopy_file, non_regular_nbytes, read_non_regular)
3462 (Finsert_file_contents):
3463 Use int, not EMACS_INT, where int is wide enough.
3464 (READ_BUF_SIZE): Verify that it fits in int.
3465 (Finsert_file_contents): Check that counts are in proper range,
3466 rather than assuming fixnums fit into ptrdiff_t etc.
3467 Don't assume fixnums fit into int.
125b3835 3468 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3469 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3470 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3471 (string_char_to_byte, string_byte_to_char)
3472 (string_make_multibyte, string_to_multibyte)
3473 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3474 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3475 (substring_both, Fdelete, internal_equal, Ffillarray)
3476 (Fclear_string, mapcar1)
3477 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3478 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3479 (larger_vector, make_hash_table, maybe_resize_hash_table)
3480 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3481 (Fmaphash, secure_hash):
3482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3483 (concat): Check for string index and length overflow.
3484 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3485 (Frequire):
3486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3487 (larger_vector): New API (vec, incr_min, size_max) replaces old
3488 one (vec, new_size, init). This catches size overflow.
3489 INIT was removed because it was always Qnil.
3490 All callers changed.
3491 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3492 the upper bound on a hash table index size.
3493 (make_hash_table, maybe_resize_hash_table): Use it.
3494 (secure_hash): Computer start_byte and end_byte only after
3495 they're known to be in ptrdiff_t range.
3496 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3497 (Ffont_get_glyphs, Ffont_at):
3498 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3499 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3500 (Flist_fonts, Fopen_font):
3501 Don't assume fixnum can fit in int.
3502 (check_gstring): Don't assume index can fit in int.
3503 (font_match_p): Check that fixnum is a character, not a nonnegative
3504 fixnum, since the later code needs to stuff it into an int.
3505 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3506 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3507 conversion overflow issues.
3508 (Fopen_font): Check for integer out of range.
3509 (Ffont_get_glyphs): Don't assume index can fit in int.
3510 * font.h: Adjust decls to match defn changes elsewhere.
3511 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3512 integer overflow.
3513 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3514 printmax_t, where ptrdiff_t is wide enough.
3515 (Finternal_char_font):
3516 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3517 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3518 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3519 (Fset_frame_position, x_set_frame_parameters)
3520 (x_set_line_spacing, x_set_border_width)
3521 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3522 Check that fixnums are in proper range for system types.
3523 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3525 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3526 Use SAFE_ALLOCA_LISP, not alloca.
3527 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3528 intptr_t is wide enough.
3529 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3530 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3531 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3532 Check for fixnum out of range.
3533 * ftfont.c (ftfont_list): Don't assume index fits in int.
3534 Check that fixnums are in proper range for system types.
3535 (ftfont_shape_by_flt):
3536 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3537 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3538 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3539 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3540 Check that fixnums are in proper range for system types.
3541 * gnutls.h: Adjust decls to match defn changes elsewhere.
3542 * gtkutil.c (xg_dialog_run):
3543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3544 (update_frame_tool_bar):
3545 Check that fixnums are in proper range for system types.
3546 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3547 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3548 * indent.c (last_known_column, last_known_column_point):
3549 (current_column_bol_cache):
3550 (skip_invisible, current_column, check_display_width):
3551 (check_display_width, scan_for_column, current_column_1)
3552 (Findent_to, Fcurrent_indentation, position_indentation)
3553 (indented_beyond_p, Fmove_to_column, compute_motion):
3554 (Fcompute_motion, Fvertical_motion):
3555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3556 (last_known_column_modified): Use EMACS_INT, not int.
3557 (check_display_width):
3558 (Fcompute_motion):
3559 Check that fixnums and floats are in proper range for system types.
3560 (compute_motion): Don't assume index or fixnum fits in int.
3561 (compute_motion, Fcompute_motion):
3562 Use int, not EMACS_INT, when it is wide enough.
3563 (vmotion): Omit local var start_hpos that is always 0; that way
3564 we don't need to worry about overflow in expressions involving it.
3565 * indent.h: Adjust decls to match defn changes elsewhere.
3566 (struct position):
3567 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3568 Use int, not EMACS_INT, where int is wide enough.
3569 Remove unused members ovstring_chars_done and tab_offset;
3570 all uses removed.
3571 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3572 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3573 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3574 (make_gap, copy_text, insert, insert_and_inherit)
3575 (insert_before_markers, insert_before_markers_and_inherit)
3576 (insert_1, count_combining_before, count_combining_after)
3577 (insert_1_both, insert_from_string)
3578 (insert_from_string_before_markers, insert_from_string_1)
3579 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3580 (adjust_after_replace, adjust_after_insert, replace_range)
3581 (replace_range_2, del_range, del_range_1, del_range_byte)
3582 (del_range_both, del_range_2, modify_region)
3583 (prepare_to_modify_buffer, signal_before_change)
3584 (signal_after_change, Fcombine_after_change_execute):
3585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3586 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3587 (balance_an_interval, split_interval_right, split_interval_left)
3588 (find_interval, next_interval, update_interval)
3589 (adjust_intervals_for_insertion, delete_node, delete_interval)
3590 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3591 (static_offset_intervals, offset_intervals)
3592 (merge_interval_right, merge_interval_left, make_new_interval)
3593 (graft_intervals_into_buffer, temp_set_point_both)
3594 (temp_set_point, set_point, adjust_for_invis_intang)
3595 (set_point_both, move_if_not_intangible, get_property_and_range)
3596 (get_local_map, copy_intervals, copy_intervals_to_string)
3597 (compare_string_intervals, set_intervals_multibyte_1):
3598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3599 * intervals.h: Adjust decls to match defn changes elsewhere.
3600 (struct interval):
3601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3602 * keyboard.c (this_command_key_count, this_single_command_key_start)
3603 (before_command_key_count, before_command_echo_length, echo_now)
3604 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3605 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3606 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3607 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3609 (last_non_minibuf_size, last_point_position, echo_truncate)
3610 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3611 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3612 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3613 (stuff_buffered_input):
3614 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3615 (last_auto_save, command_loop_1, read_char):
3616 Use EMACS_INT, not int, to avoid integer overflow.
3617 (record_char): Avoid overflow in total_keys computation.
3618 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3619 * keyboard.h: Adjust decls to match defn changes elsewhere.
3620 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3621 (Fkey_description, Fdescribe_vector, Flookup_key):
3622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3623 (click_position): New function, to check that positions are in range.
3624 (Fcurrent_active_maps):
3625 (describe_command):
3626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3627 (Faccessible_keymaps, Fkey_description):
3628 (preferred_sequence_p):
3629 Don't assume fixnum can fit into int.
3630 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3631 Check for integer overflow in size calculations.
3632 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3633 avoid mishandling large integers.
3634 * lisp.h: Adjust decls to match defn changes elsewhere.
3635 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3636 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3637 (struct Lisp_Marker):
3638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3639 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3640 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3641 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3642 All callers changed.
3643 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3644 Assume the arg has valid form, since it always does.
3645 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3646 unsigned integer system type.
3647 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3648 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3649 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3650 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3651 (duration_to_sec_usec): New decl.
3652 * lread.c (read_from_string_index, read_from_string_index_byte)
3653 (read_from_string_limit, readchar, unreadchar, openp)
3654 (read_internal_start, read1, oblookup):
3655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3656 (Fload, readevalloop, Feval_buffer, Feval_region):
3657 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3658 (openp): Check for out-of-range argument to 'access'.
3659 (read1): Use int, not EMACS_INT, where int is wide enough.
3660 Don't assume fixnum fits into int.
6efdadfd 3661 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3662 (read_filtered_event): Use duration_to_sec_usec
3663 to do proper overflow checking on durations.
d311d28c
PE
3664 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3665 in size calculation.
3666 (Fexecute_kbd_macro):
3667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3668 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3669 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3670 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3671 (set_marker_both, set_marker_restricted_both, marker_position)
3672 (marker_byte_position, Fbuffer_has_markers_at):
3673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3674 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3675 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3676 It now merely ensures that the menu is large enough, without
3677 necessarily growing it, as this avoids some integer overflow issues.
3678 All callers changed.
3679 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3680 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3681 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3682 Use SAFE_ALLOCA_LISP, not alloca.
3683 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3684 to EMACS_INT. Check that fixnums are in proper range for system types.
3685 * minibuf.c (minibuf_prompt_width, string_to_object)
3686 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3687 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3689 (get_minibuffer, read_minibuf_unwind):
3690 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3691 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3692 this simplifies overflow checking. All callers changed.
3693 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3694 (Ftest_completion):
3695 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3696 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3697 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3698 Check that fixnums are in proper range for system types.
3699 (Fx_create_frame, Fx_show_tip):
3700 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3701 * nsfont.m (ns_findfonts, nsfont_list_family):
3702 Don't assume fixnum fits in long.
3703 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3704 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3705 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3706 wide enough.
17fdb222 3707 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3708 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3709 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3710 (PRINTDECLARE, PRINTPREPARE):
3711 (strout, print_string):
3712 (print, print_preprocess, print_check_string_charset_prop)
3713 (print_object):
3714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3715 (PRINTDECLARE):
3716 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3718 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3719 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3720 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3721 (print_error_message): Use SAFE_ALLOCA, not alloca.
3722 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3723 (print_depth, new_backquote_output, print_number_index):
3724 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3725 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3726 (Fset_process_window_size, Fformat_network_address)
3727 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3728 (sigchld_handler):
d311d28c 3729 Check that fixnums are in proper range for system types.
d44287d4 3730 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3731 Check for process-ids out of pid_t range rather than relying on
3732 undefined behavior.
e4d81efc 3733 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3734 (Fformat_network_address, read_process_output, send_process)
3735 (Fprocess_send_region, status_notify):
3736 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3737 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3738 (wait_reading_process_output, read_process_output, exec_sentinel):
3739 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3740 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3741 (Faccept_process_output): Use duration_to_sec_usec to do proper
3742 overflow checking on durations.
dde14581
PE
3743 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3744 Don't assume pid_t fits in int.
02481186
PE
3745 * process.h (struct Lisp_Process): Members tick and update_tick
3746 are now of type EMACS_INT, not int.
b62b53e8
PE
3747 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3748 configured --with-wide-int.
d311d28c
PE
3749 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3750 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3751 * search.c (looking_at_1, string_match_1):
3752 (fast_string_match, fast_c_string_match_ignore_case)
3753 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3754 (scan_newline, find_before_next_newline, search_command)
3755 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3756 (set_search_regs, wordify):
3757 (Freplace_match):
3758 (Fmatch_data):
3759 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3760 (string_match_1, search_buffer, set_search_regs):
3761 (Fmatch_data):
3762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3763 (wordify): Check for overflow in size calculation.
3764 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3765 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3766 Check that fixnums are in proper range for system types.
3767 * sound.c (struct sound_device)
3768 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3770 (Fplay_sound_internal):
3771 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3772 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3773 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3774 (Fparse_partial_sexp):
3775 Don't assume fixnums can fit in int.
3776 (struct lisp_parse_state, find_start_pos, find_start_value)
3777 (find_start_value_byte, find_start_begv)
3778 (update_syntax_table, char_quoted, dec_bytepos)
3779 (find_defun_start, prev_char_comend_first, back_comment):
3780 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3781 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3782 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3783 (Finternal_describe_syntax_value): Check that match_lisp is a
3784 character, not an integer, since the code stuffs it into int.
3785 (scan_words, scan_sexps_forward):
3786 Check that fixnums are in proper range for system types.
3787 (Fforward_word):
3788 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3789 (scan_sexps_forward):
3790 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3791 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3792 * syntax.h: Adjust decls to match defn changes elsewhere.
3793 (struct gl_state_s):
3794 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3795 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3796 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3797 * sysdep.c (wait_for_termination_1, wait_for_termination)
3798 (interruptible_wait_for_termination, mkdir):
3799 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3800 (emacs_read, emacs_write):
3801 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3802 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3803 and double all fit in int.
d311d28c
PE
3804 * term.c (set_tty_color_mode):
3805 Check that fixnums are in proper range for system types.
3806 * termhooks.h (struct input_event):
3807 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3808 * textprop.c (validate_interval_range, interval_of)
3809 (Fadd_text_properties, set_text_properties_1)
3810 (Fremove_text_properties, Fremove_list_of_text_properties)
3811 (Ftext_property_any, Ftext_property_not_all)
3812 (copy_text_properties, text_property_list, extend_property_ranges)
3813 (verify_interval_modification):
3814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3815 (Fnext_single_char_property_change)
3816 (Fprevious_single_char_property_change):
3817 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3818 (copy_text_properties):
3819 Check for integer overflow in index calculation.
d311d28c
PE
3820 * undo.c (last_boundary_position, record_point, record_insert)
3821 (record_delete, record_marker_adjustment, record_change)
3822 (record_property_change):
3823 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3824 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3825 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3826 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3827 (Fx_hide_tip, Fx_file_dialog):
3828 * w32menu.c (set_frame_menubar):
3829 Use ptrdiff_t, not int, for consistency with rest of code.
3830 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3831 (select_window, Fdelete_other_windows_internal)
3832 (window_scroll_pixel_based, window_scroll_line_based)
3833 (Frecenter, Fset_window_configuration):
3834 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3835 (Fset_window_hscroll, run_window_configuration_change_hook)
3836 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3837 (Fscroll_other_window, Frecenter):
d311d28c
PE
3838 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3839 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3840 Don't assume fixnum fits in int.
3841 (Fset_window_scroll_bars):
3842 Check that fixnums are in proper range for system types.
3843 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3844 (string_pos, c_string_pos, number_of_chars, init_iterator)
3845 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3846 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3847 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3848 (face_before_or_after_it_pos, handle_invisible_prop)
3849 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3850 (display_prop_intangible_p, string_buffer_position_lim)
3851 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3852 (get_overlay_strings_1, get_overlay_strings)
3853 (iterate_out_of_display_property, forward_to_next_line_start)
3854 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3855 (get_next_display_element, set_iterator_to_next)
3856 (get_visually_first_element, compute_stop_pos_backwards)
3857 (handle_stop_backwards, next_element_from_buffer)
3858 (move_it_in_display_line_to, move_it_in_display_line)
3859 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3860 (add_to_log, message_dolog, message_log_check_duplicate)
3861 (message2, message2_nolog, message3, message3_nolog
3862 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3863 (current_message_1, truncate_echo_area, truncate_message_1)
3864 (set_message, set_message_1, store_mode_line_noprop)
3865 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3866 (text_outside_line_unchanged_p, check_point_in_composition)
3867 (reconsider_clip_changes)
3868 (redisplay_internal, set_cursor_from_row, try_scrolling)
3869 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3870 (redisplay_window, find_last_unchanged_at_beg_row)
3871 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3872 (trailing_whitespace_p, find_row_edges, display_line)
3873 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3874 (display_mode_element, store_mode_line_string)
3875 (pint2str, pint2hrstr, decode_mode_spec)
3876 (display_count_lines, display_string, draw_glyphs)
3877 (x_produce_glyphs, x_insert_glyphs)
3878 (rows_from_pos_range, mouse_face_from_buffer_pos)
3879 (fast_find_string_pos, mouse_face_from_string_pos)
3880 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3882 (safe_call, init_from_display_pos, handle_fontified_prop)
3883 (handle_single_display_spec, load_overlay_strings)
3884 (with_echo_area_buffer, setup_echo_area_for_printing)
3885 (display_echo_area, echo_area_display)
3886 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3887 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3888 (redisplay_window, dump_glyph_row, display_mode_line)
3889 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3890 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3891 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3892 (handle_single_display_spec, build_desired_tool_bar_string)
3893 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3894 (get_specified_cursor_type):
3895 Check that fixnums are in proper range for system types.
3896 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3897 (Flookup_image_map):
3898 Don't assume fixnums fit in int.
3899 (compare_overlay_entries):
3900 Avoid mishandling comparisons due to subtraction overflow.
3901 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3902 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3903 (handle_tool_bar_click):
3904 Use int, not unsigned, since we prefer signed and the signedness
3905 doesn't matter here.
3906 (get_next_display_element, next_element_from_display_vector):
3907 Use int, not EMACS_INT, when int is wide enough.
3908 (start_hourglass): Use duration_to_sec_usec to do proper
3909 overflow checking on durations.
3910 * xfaces.c (Fbitmap_spec_p):
3911 Check that fixnums are in proper range for system types.
3912 (compare_fonts_by_sort_order):
3913 Avoid mishandling comparisons due to subtraction overflow.
3914 (Fx_family_fonts, realize_basic_faces):
3915 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3916 (Fx_family_fonts):
3917 Don't assume fixnum fits in int.
3918 Use SAFE_ALLOCA_LISP, not alloca.
3919 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3920 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3921 (face_at_buffer_position, face_for_overlay_string)
3922 (face_at_string_position):
3923 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3924 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3925 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3926 (Fx_show_tip):
3927 Check that fixnums are in proper range for system types.
3928 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3929 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3930 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3931 (Fx_change_window_property): Don't assume fixnums fit in int.
3932 * xfont.c (xfont_chars_supported):
3933 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3934 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3935 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3936 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3937 * xml.c (parse_region):
3938 * xrdb.c (magic_file_p):
3939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3940 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3941 (x_get_local_selection, x_reply_selection_request)
3942 (x_handle_selection_request, wait_for_property_change):
3943 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3944 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3945 short is wide enough.
3946 (x_send_client_event): Don't assume fixnum fits in int.
3947 * xterm.c (x_x_to_emacs_modifiers):
3948 Don't assume EMACS_INT overflows nicely into int.
3949 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3950 may come from Lisp.
3951 (handle_one_xevent): NATNUMP can eval its arg twice.
3952 (x_connection_closed):
3953 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3954 * xterm.h: Adjust decls to match defn changes elsewhere.
3955 (struct scroll_bar): Use struct vectorlike_header
3956 rather than rolling our own approximation.
3957 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3958
c6574eb5
GM
39592012-05-25 Glenn Morris <rgm@gnu.org>
3960
3961 * lisp.mk (lisp): Update for more files being compiled now.
3962
e8d32c7e
SM
39632012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3964
48def666
SM
3965 * lread.c: Remove `read_pure' which makes no difference.
3966 (read_pure): Remove var.
3967 (unreadpure): Remove function.
3968 (readevalloop): Don't call read_list with -1 flag.
3969 (read1, read_vector): Don't test read_pure any more.
3970 (read_list): Simplify.
3971
e8d32c7e
SM
3972 * fileio.c, character.h: Minor style tweaks.
3973
4b2addb7
DA
39742012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3975
3976 * window.h (clip_changed): Remove useless declaration.
3977
584461b2
JB
39782012-05-22 Juanma Barranquero <lekktu@gmail.com>
3979
3980 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3981 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3982
34374650
PE
39832012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3984
3985 Remove src/m/*.
3986 This directory predates autoconf and is no longer needed nowadays.
3987 Move its few remaining bits of functionality to where they're needed.
3988 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3989 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3990 * m/template.h: Remove.
3991 * Makefile.in (M_FILE): Remove. All uses removed.
3992 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3993 * lisp.h (USE_LSB_TAG):
3994 * mem-limits.h (EXCEEDS_LISP_PTR):
3995 Use VAL_MAX, not VALBITS, in #if.
3996 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3997 (EMACS_UINT): Define unconditionally now.
3998 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3999 (BITS_PER_EMACS_INT): New constants, replacing
4000 what used to be in config.h, but not useful in #if.
4001 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4002 define them any more.
4003 (VAL_MAX): New macro.
4004 (VALMASK): Use it.
4005 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4006 BITS_PER_EMACS_INT, in #if.
4007 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4008 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4009 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4010 * s/ms-w32.h (DATA_START):
4011 Move here from removed file m/intel386.h.
4012 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4013 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4014
261cb4bb
PE
40152012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4016
4017 Assume C89 or later.
4018 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4019 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4020 (xrealloc):
4021 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4022 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4023 * textprop.c, tparam.c (NULL): Remove.
4024 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4025 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4026 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4027 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4028 * xterm.c (input_signal_count): Assume volatile works.
4029
ff23cd9f
KB
40302012-05-21 Ken Brown <kbrown@cornell.edu>
4031
4032 * xgselect.c (xg_select): Fix first argument in call to 'select'
4033 (bug#11508).
4034
1b170bc6
KB
40352012-05-20 Ken Brown <kbrown@cornell.edu>
4036
4037 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4038 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4039
b2f4d39f
KB
40402012-05-19 Ken Brown <kbrown@cornell.edu>
4041
4042 * xfns.c (x_in_use): Remove `static' qualifier.
4043 * xterm.h (x_in_use): Declare.
4044 * xgselect.c: Include xterm.h.
4045 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4046 and `display_arg' (bug#9754).
4047
003fdae2
PE
40482012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4049
9232a6d9
PE
4050 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4051
003fdae2
PE
4052 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4053 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4054
784b56e2
EZ
40552012-05-18 Eli Zaretskii <eliz@gnu.org>
4056
4057 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4058
4059 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4060 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4061
4062 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4063 reference to image_cache->refcount.
4064 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4065
a0a79cde
JL
40662012-05-17 Juri Linkov <juri@jurta.org>
4067
4068 * search.c (Fword_search_regexp, Fword_search_backward)
4069 (Fword_search_forward, Fword_search_backward_lax)
4070 (Fword_search_forward_lax): Move functions to isearch.el
4071 (bug#10145, bug#11381).
4072
b0572523
PE
40732012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4074
4075 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4076
9660f5fc
SM
40772012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4078
4079 * lread.c (init_obarray): Declare Qt and Qnil as special.
4080
4374de83
GM
40812012-05-14 Glenn Morris <rgm@gnu.org>
4082
4083 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4084 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4085
dc44c39a
PE
40862012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4087
078c97cb
PE
4088 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4089
dc44c39a
PE
4090 * unexaix.c: Port to more-recent AIX compilers.
4091 (report_error, report_error_1, make_hdr, copy_sym)
4092 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4093 Make arguments const char *, not char *, to avoid violations of C
4094 standard and to fix some AIX warnings reported by Gilles Pion.
4095
e18afed7 40962012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4097
4098 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4099 already have overlays loaded.
4100 (handle_single_display_spec): Before returning without displaying
4101 fringe bitmap, synchronize the bidi iterator with the main display
4102 iterator, by calling iterate_out_of_display_property.
4103 (iterate_out_of_display_property): Detect buffer iteration by
4104 testing that it->string is a Lisp string.
4105 (get_next_display_element): When the current object is exhausted,
4106 and there's something on it->stack, call set_iterator_to_next to
4107 proceed with what's on the stack, instead of returning zero.
4108 (set_iterator_to_next): If called at the end of a Lisp string,
4109 proceed to consider_string_end without incrementing string
4110 position. Don't increment display vector index past the end of
4111 the display vector. (Bug#11417)
c8fb9dc6
EZ
4112 (pos_visible_p): Don't report a position visible when move_it_to
4113 stopped at the last line of window, which happens to be scanned
4114 backwards by the bidi iteration. (Bug#11464)
ac268e67 4115
e18afed7 41162012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4117
4118 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4119 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4120 are on a TTY, and thus unable to display on the fringes.
4121 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4122 so we need to signal to the caller that this is a "replacing"
4123 display spec. This fixes display when the spec is invalid or we
4124 are on a TTY.
4125
e18afed7 41262012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4127
4128 * unexaix.c (make_hdr): Fix typo in prototype.
4129 This bug broke the build on AIX. Problem reported by Gilles Pion.
4130
9d0a235a
MA
41312012-05-14 Michael Albinus <michael.albinus@gmx.de>
4132
4133 * keyboard.c (kbd_buffer_get_event): Read special events also in
4134 batch mode. (Bug#11415)
4135
9e6b06ed
GM
41362012-05-12 Glenn Morris <rgm@gnu.org>
4137
4138 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4139
c1a1d7a3
EZ
41402012-05-12 Eli Zaretskii <eliz@gnu.org>
4141
4142 * lisp.mk (lisp): Add newcomment.elc.
4143
3fe7cdc8
GM
41442012-05-12 Glenn Morris <rgm@gnu.org>
4145
4146 * Makefile.in (MKDIR_P): New, set by configure.
4147 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4148
53f7d2c0
PE
41492012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4150
4151 Remove unused function hourglass_started.
4152 * dispextern.h (hourglass_started):
4153 * w32fns.c (hourglass_started):
4154 * xdisp.c (hourglass_started): Remove.
4155
75aafb17
JB
41562012-05-10 Juanma Barranquero <lekktu@gmail.com>
4157
4158 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4159 Update dependencies.
4160
12959e8e
PE
41612012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4162
97107e2e
PE
4163 * xgselect.c (xg_select): Put maxfds+1 into a var.
4164 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4165
12959e8e
PE
4166 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4167
836d29b3
DA
41682012-05-10 Dave Abrahams <dave@boostpro.com>
4169
4170 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4171 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4172
5cb67954
MA
41732012-05-09 Michael Albinus <michael.albinus@gmx.de>
4174
4175 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4176 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4177 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4178 Initialize xd_registered_buses.
4179
3478ec45
PE
41802012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4181
b263a6b0
PE
4182 Untag more efficiently if USE_LSB_TAG.
4183 This is based on a proposal by YAMAMOTO Mitsuharu in
4184 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4185 For an admittedly artificial (nth 8000 longlist) benchmark on
4186 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4187 Emacs's overall text size by 1%.
4188 * lisp.h (XUNTAG): New macro.
4189 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4190 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4191 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4192 * eval.c (Fautoload):
4193 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4194 * frame.h (XFRAME): Use XUNTAG.
4195
3478ec45
PE
4196 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4197 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4198 Remove unportable assumptions about print widths of types like
4199 dbus_uint32_t.
4200 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4201 intptr_t when converting between pointer and integer, to avoid GCC
4202 warnings about wrong width.
4203
666b903b 42042012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4205
4206 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4207 stack for each reader_thread, instead of defaulting to 8MB
4208 determined by the linker. This avoids failures in creating
4209 subprocesses on Windows 7, see the discussion in this thread:
4210 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4211
b120cc17
JC
42122012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4213
4214 Fix up display of the *Minibuf-0* buffer in the mini window.
4215 * keyboard.c (read_char): Don't clear the echo area if there's no
4216 message to clear.
4217 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4218 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4219
9a4b36f8
MA
42202012-05-07 Michael Albinus <michael.albinus@gmx.de>
4221
4222 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4223 batch mode.
4224
e5f9458f
CY
42252012-05-06 Chong Yidong <cyd@gnu.org>
4226
4227 * lisp.mk (lisp): Update.
4228
eceeb5fc 42292012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4230
4231 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4232
71873e2b
SM
42332012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4234
4235 * data.c (PUT_ERROR): New macro.
4236 (syms_of_data): Use it. Add new error type `user-error'.
4237 * undo.c (user_error): New function.
4238 (Fprimitive_undo): Use it.
4239 * print.c (print_error_message): Adjust print style for `user-error'.
4240 * keyboard.c (user_error): New function.
4241 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4242
ab0fa4e4
PE
42432012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4244
4245 Do not limit current-time-string to years 1000..9999.
4246 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4247 (Fcurrent_time_string): Support any year that is supported by the
4248 underlying localtime representation. Don't use asctime, as it
4249 has undefined behavior for years outside the range -999..9999.
4250
7ed806a7
PE
42512012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4252
4253 Fix race conditions involving setenv, gmtime, localtime, asctime.
4254 Without this fix, interrupts could mess up code that uses these
4255 nonreentrant functions, since setting TZ invalidates existing
4256 tm_zone or tzname values, and since most of these functions return
4257 pointers to static storage.
4258 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4259 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4260 Grow the critical sections to include not just invoking
4261 localtime/gmtime, but also accessing these functions' results
4262 including their tm_zone values if any, and any related TZ setting.
4263 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4264 so that the struct tm is saved in the critical section.
4265 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4266 motivated by the fact that memory allocation needs to be outside
4267 the critical section.
4268
0c16dfed
DA
42692012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4270
4271 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4272 with RESET_INTERVAL.
4273
4274 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4275 Remove duplicated buffer name initialization.
4276
3f83ace8
JM
42772012-05-02 Jim Meyering <jim@meyering.net>
4278
4279 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4280
c7b8541e
JM
4281 * xfns.c (x_window): Use xstrdup (Bug#11375).
4282
90207a15 42832012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4284
4285 * xdisp.c (pos_visible_p): If already at a newline from the
4286 display string before the 'while' loop, don't walk back the glyphs
4287 from it3.glyph_row. Solves assertion violation when the display
4288 string begins with a newline (egg.el). (Bug#11367)
4289
b593d6a9
AH
42902012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4291
4292 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4293 Move to simple.el.
4294
4737362e
GM
42952012-05-01 Glenn Morris <rgm@gnu.org>
4296
99cf43f9
GM
4297 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4298 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4299 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4300 All were removed before 23.1.
4301
9311dcff
GM
4302 * dispnew.c: Remove HAVE_LIBNCURSES test;
4303 it is always true on relevant platforms.
4304
4d5c6349
GM
4305 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4306 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4307
4737362e
GM
4308 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4309
74dd3a6b
AS
43102012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4311
4312 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4313 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4314 Remove.
4315
13c379ee
PE
43162012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4317
4318 Do not avoid creating empty evaporating overlays (Bug#9642).
4319 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4320 That is, do not delete an evaporating overlay if it becomes
4321 empty after its bounds are adjusted to fit within its buffer.
4322 This fix caused other problems, and I'm reverting it until we get
4323 to the bottom of them.
4324
a8e7d6d7 43252012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4326
4327 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4328
a8e7d6d7 43292012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4330
4331 * xdisp.c (pos_visible_p): If the window start position is beyond
4332 ZV, start the display from buffer beginning. Prevents assertion
4333 violation in init_iterator when the minibuffer window is scrolled
4334 via the scroll bar.
4335
4336 * window.c (window_scroll_pixel_based): Likewise.
4337
a8e7d6d7 43382012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4339
4340 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4341
a8e7d6d7 43422012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4343
4344 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4345 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4346
a8e7d6d7 43472012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4348
b593d6a9
AH
4349 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4350 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4351
1c6900d9
EZ
43522012-04-26 Eli Zaretskii <eliz@gnu.org>
4353
4c3fa1d9
EZ
4354 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4355 display element, check also the underlying string or buffer
4356 character. (Bug#11341)
4357
1c6900d9
EZ
4358 * w32menu.c: Include w32heap.h.
4359 (add_menu_item): If the call to AppendMenuW (via
4360 unicode_append_menu) fails, disable Unicode menus only if we are
4361 running on Windows 9X/Me.
4362
42bf8205
AS
43632012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4364
4365 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4366 (xgetint): Add missing shift for LSB tags.
4367
b1bac16e
MR
43682012-04-24 Martin Rudalics <rudalics@gmx.at>
4369
4370 * keyboard.c (read_char): Don't wipe echo area for select window
4371 events: These might get delayed via `mouse-autoselect-window'
4372 (Bug#11304).
4373
d69621cc
JB
43742012-04-24 Juanma Barranquero <lekktu@gmail.com>
4375
4376 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4377 manipulation of :loaded-from data.
4378
02fd101b
JB
43792012-04-23 Juanma Barranquero <lekktu@gmail.com>
4380
4381 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4382 now a cons (bug#11311).
4383
888bec30
PE
43842012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4385
89a438bd
PE
4386 Do not create empty overlays with the evaporate property (Bug#9642).
4387 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4388 if it becomes empty after its bounds are adjusted to fit within
4389 its buffer. Without this fix, in a nonempty buffer (let ((o
4390 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4391 yields an empty overlay that has the evaporate property, which is
4392 not supposed to happen.
4393
1068fe4d
PE
4394 Fix minor GTK3 problems found by static checking.
4395 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4396 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4397 (struct _EmacsFixedClass, emacs_fixed_get_type):
4398 Move decls here from emacsgtkfixed.h, since they needn't be public.
4399 (emacs_fixed_get_type): Now static.
4400 (emacs_fixed_class_init): Omit unused local.
4401 (emacs_fixed_child_type): Remove; unused.
4402 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4403 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4404 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4405 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4406 (EMACS_FIXED_GET_CLASS): Remove; unused.
4407 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4408
888bec30
PE
4409 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4410 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4411
de85e130
PE
44122012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4413
d0baac98 4414 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4415 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4416 (__malloc_size_t, __malloc_ptrdiff_t):
4417 Remove. All uses removed, replaced by the definiens if needed,
4418 since we can assume C89 or better now.
4419 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4420 (protect_malloc_state, align, get_contiguous_space)
4421 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4422 (malloc_atfork_handler_child, malloc_enable_thread)
4423 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4424 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4425 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4426 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4427 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4428 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4429 Define using prototypes, not old style.
4430 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4431 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4432 (align): Don't assume that signed integer overflow wraps around.
4433 Omit unused local var.
4434 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4435 (_free_internal_nolock, memalign, mallochook, reallochook):
4436 Omit no-longer-needed casts.
4437 (valloc): Use getpagesize, not __getpagesize.
4438 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4439 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4440
de85e130
PE
4441 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4442
dcbf5805
MA
44432012-04-22 Michael Albinus <michael.albinus@gmx.de>
4444
4445 Move functions from C to Lisp. Make non-blocking method calls
4446 the default. Implement further D-Bus standard interfaces.
4447
4448 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4449 (QCdbus_request_name_allow_replacement)
4450 (QCdbus_request_name_replace_existing)
4451 (QCdbus_request_name_do_not_queue)
4452 (QCdbus_request_name_reply_primary_owner)
4453 (QCdbus_request_name_reply_in_queue)
4454 (QCdbus_request_name_reply_exists)
4455 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4456 (QCdbus_registered_serial, QCdbus_registered_method)
4457 (QCdbus_registered_signal): New Lisp objects.
4458 (XD_DEBUG_MESSAGE): Use sizeof.
4459 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4460 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4461 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4462 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4463 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4464 (xd_signature, xd_append_arg): Allow float for integer types.
4465 (xd_get_connection_references): New function.
b593d6a9
AH
4466 (xd_get_connection_address): Rename from xd_initialize.
4467 Return cached address.
dcbf5805
MA
4468 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4469 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4470 level.
4471 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4472 Return number of refcounts.
dcbf5805
MA
4473 (Fdbus_get_unique_name): Make stronger parameter check.
4474 (Fdbus_message_internal): New defun.
4475 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4476 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4477 (Fdbus_send_signal, Fdbus_register_service)
4478 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4479 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4480 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4481 (Vdbus_compiled_version, Vdbus_runtime_version)
4482 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4483 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4484 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4485 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4486 Adapt docstring.
dcbf5805 4487
52828e02
PE
44882012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4489
da05bc4c
PE
4490 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4491 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4492 Do not assume ptrdiff_t is the same width as 'int'.
4493
52828e02
PE
4494 * alloc.c: Handle unusual debugging option combinations.
4495 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4496 since the two debugging options are incompatible.
4497 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4498 is defined.
4499 (mem_init, mem_insert, mem_insert_fixup):
4500 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4501 (NEED_MEM_INSERT): Remove; no longer needed.
4502
f01769f9
LL
45032012-04-22 Leo Liu <sdl.web@gmail.com>
4504
4505 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4506
5790543d
PE
45072012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4508
4509 * sysdep.c [__FreeBSD__]: Minor cleanups.
4510 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4511 Use Emacs indenting style more consistently. Avoid some casts.
4512 Use 'double' consistently rather than mixing 'float' and 'double'.
4513
b91b7e4d
EW
45142012-04-21 Eduard Wiebe <usenet@pusto.de>
4515
b593d6a9
AH
4516 * sysdep.c (list_system_processes, system_process_attributes):
4517 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4518
6114eb15
AS
45192012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4520
4521 * lisp.mk (lisp): Update.
4522
2f38dff7
PE
45232012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4524
4525 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4526 It is never used otherwise.
4527
4ae29f89
SM
45282012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4529
4530 * print.c (print_preprocess): Only check print_depth if print-circle
4531 is nil.
4532 (print_object): Check for cycles even when print-circle is nil and
4533 print-gensym is t, but only check print_depth if print-circle is nil.
4534
f30d612a
CY
45352012-04-20 Chong Yidong <cyd@gnu.org>
4536
4537 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4538 set the status to "failed" and ensure that sentinel is run.
4539
c07a4c0b 45402012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4541
4542 * process.c (Fset_process_inherit_coding_system_flag)
4543 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4544 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4545
c07a4c0b 45462012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4547
4548 * xdisp.c (string_buffer_position_lim): Limit starting position to
4549 BEGV.
4550 (set_cursor_from_row): If called for a mode-line or header-line
4551 row, return zero immediately.
4552 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4553 farther than the first row after the header line, if any.
4554 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4555 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4556
c07a4c0b 45572012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4558
4ae29f89
SM
4559 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4560 (bug#11238).
ad3a2b41 4561
c07a4c0b 45622012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 45632012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4564
4565 configure: new option --enable-gcc-warnings (Bug#11207)
4566 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4567 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4568 (ALL_CFLAGS): Use new macros rather than old.
4569 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4570 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4571 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4572 -Wunused-result, -Wunused-variable. This should go away once
4573 the Emacs and Gnulib regex code is merged.
4574 (xmalloc, xrealloc): Now static.
4575
aba027e8
PE
45762012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4577
4578 * dired.c (Fsystem_groups): Remove unused local.
4579
e5a36063
GM
45802012-04-17 Glenn Morris <rgm@gnu.org>
4581
4582 * dired.c (Fsystem_users): Doc fix.
4583
316411f0
DA
45842012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4585
4586 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4587 (syms_of_dired): Add them.
4588
9426aba4
PE
45892012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4590
b62a57be
PE
4591 Fix minor alloc.c problems found by static checking.
4592 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4593 New extern decls, to avoid calling undeclared functions.
4594 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4595 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4596 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4597 (NEED_MEM_INSERT): New macro.
4598 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4599 Remove one incorrect comment and fix another.
b62a57be 4600
3539f31f
PE
4601 Fix minor ralloc.c problems found by static checking.
4602 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4603 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4604 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4605 (r_alloc_sbrk): Now static.
4606
a041960a
PE
4607 Improve ralloc.c interface checking.
4608 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4609 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4610 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4611 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4612 [REL_ALLOC]: ... to here, to check interface.
4613 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4614 Remove decls. This fixes an "It stinks!".
4615
9426aba4
PE
4616 * alloc.c (which_symbols): Fix alignment issue / type clash.
4617
d55c12ed
AS
46182012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4619
4620 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4621 (struct Lisp_Misc_Any): Likewise.
4622 (struct Lisp_Free): Likewise.
4623 * alloc.c (union aligned_Lisp_Symbol): Define.
4624 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4625 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4626 (union aligned_Lisp_Misc): Define.
4627 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4628 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4629 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4630
b948ce8b
PE
46312012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4632
4633 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4634 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4635 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4636 * s/netbsd.h, s/sol2-6.h:
4637 Remove definition of GC_MARK_STACK, since the default now works.
4638 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4639 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4640 no longer the default.
4641 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4642
35dc09a1 46432012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4644
35dc09a1
GM
4645 * lread.c (lisp_file_lexically_bound_p):
4646 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4647
35dc09a1
GM
46482012-04-14 Eli Zaretskii <eliz@gnu.org>
4649
4650 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4651 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4652
46532012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4654
4655 * nsterm.m (constrainFrameRect): Always constrain when there is only
4656 one screen (Bug#10962).
4657
bcd86815
KB
46582012-04-13 Ken Brown <kbrown@cornell.edu>
4659
4660 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4661
c25df26e
RT
46622012-04-13 Reuben Thomas <rrt@sc3d.org>
4663
4664 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4665
0fc59f1e
DC
46662012-04-11 Daniel Colascione <dancol@dancol.org>
4667
4668 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4669 against is gone. It's better to use vfork now so that when Cygwin
4670 gains a new, working vfork, we use it automatically (bug#10398).
4671
de8c03dc
SM
46722012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4673
4674 * window.c (save_window_save): Obey window-point-insertion-type.
4675
2f097256
GM
46762012-04-11 Glenn Morris <rgm@gnu.org>
4677
4678 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4679
453b951e
SM
46802012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4681
4682 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4683
75f1671a 46842012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4685
4686 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4687 (force_quit_count): New var.
4688 (handle_interrupt): Use it.
4689
2a8ce227
JB
46902012-04-10 Juanma Barranquero <lekktu@gmail.com>
4691
4692 * w32.c (w32_delayed_load): Record the full path of the library
4693 being loaded (bug#10424).
4694
935396c0
GM
46952012-04-09 Glenn Morris <rgm@gnu.org>
4696
05920a43
GM
4697 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4698 not just in the obarray, before snarfing them. (Bug#11036)
4699
935396c0
GM
4700 * Makefile.in ($(leimdir)/leim-list.el):
4701 Pass EMACS rather than BUILT_EMACS.
4702
a18ecafa
TZ
47032012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4704
4705 * process.c (make_process):
4706 * process.h: Add integer `gnutls_handshakes_tried' member to
4707 process struct.
4708
6bbef4e5
JC
4709 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4710 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4711
4712 * gnutls.c (gnutls_log_function2i): Convenience log function.
4713 (emacs_gnutls_read): Use new log functions,
4714 `gnutls_handshakes_tried' process member, and
4715 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4716 attempts per process (connection).
4717
b4d3bc10
CY
47182012-04-09 Chong Yidong <cyd@gnu.org>
4719
4720 * eval.c (Fuser_variable_p, user_variable_p_eh)
4721 (lisp_indirect_variable): Functions deleted.
4722 (Fdefvar): Caller changed.
4723
4724 * callint.c (Finteractive, Fcall_interactively):
4725 * minibuf.c (Fread_variable): Callers changed.
4726
70f4d973
EZ
47272012-04-09 Eli Zaretskii <eliz@gnu.org>
4728
4729 * xdisp.c (set_cursor_from_row): If the display string appears in
4730 the buffer at position that is closer to point than the position
4731 after the display string, display the cursor on the first glyph of
4732 the display string. Fixes cursor display when a 'display' text
4733 property immediately follows invisible text. (Bug#11094)
4734
cb3c2e3e
PE
47352012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4736
4737 composite.c: use 'double' consistently
4738 * composite.c (get_composition_id): Use 'double' consistently
4739 instead of converting 'float' to 'double' and vice versa; this is
4740 easier to understand and avoids a GCC warning.
4741
fd06db5d
GM
47422012-04-09 Glenn Morris <rgm@gnu.org>
4743
50fe702a
GM
4744 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4745 preparation for dumping it with emacs. (Bug#4789)
4746 (leimdir): New variable.
4747 ($(leimdir)/leim-list.el): New rule.
4748 (emacs$(EXEEXT)): Depend on leim-list.el.
4749
fd06db5d
GM
4750 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4751 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4752 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4753
55c131ee
AS
47542012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4755
4756 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4757 proper alignment.
4758
9209588f
JB
47592012-04-07 Juanma Barranquero <lekktu@gmail.com>
4760
4761 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4762 Remove unused local variable.
4763
e3fb2efb
PE
47642012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4765
4766 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4767 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4768 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4769 objects, as mark_maybe_pointer will catch them otherwise.
4770 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4771 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4772
b5385551
PE
47732012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4774
4775 Fix typo that broke non-Windows builds.
4776 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4777
9078ead6
EZ
47782012-04-07 Eli Zaretskii <eliz@gnu.org>
4779
4780 Support building on MS-Windows with libxml2.
4781
4782 * makefile.w32-in (OBJ2): Add xml.$(O).
4783 (GLOBAL_SOURCES): Add xml.c.
4784 ($(BLD)/xml.$(O)): New dependency list.
4785
4786 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4787 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4788 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4789 [!WINDOWSNT]: New macros.
4790 (init_libxml2_functions, libxml2_loaded_p): New functions.
4791 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4792 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4793 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4794 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4795 linked in).
6bbef4e5
JC
4796 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4797 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4798 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4799
4800 * emacs.c: Don't include libxml/parser.h.
4801 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4802 xmlCleanupParser directly.
4803
4804 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4805
3811fdf3
EZ
48062012-04-07 Eli Zaretskii <eliz@gnu.org>
4807
4808 * indent.c (Fvertical_motion): If there is a display string at
4809 point, use it.vpos to compute how many lines to backtrack after
4810 move_it_to point. (Bug#11133)
4811
2f8e16b2
EZ
48122012-04-06 Eli Zaretskii <eliz@gnu.org>
4813
4814 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4815 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4816 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4817 macros related to unification of CJK characters. For the details,
4818 see the discussion following the message here:
4819 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4820
3d439cd1
CY
48212012-04-04 Chong Yidong <cyd@gnu.org>
4822
4823 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4824
8bc53d00
EZ
48252012-04-01 Eli Zaretskii <eliz@gnu.org>
4826
4827 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4828 instead of alloca. (Bug#11138)
4829
3b0512a3
AS
48302012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4831
4832 * w32menu.c (is_simple_dialog): Properly check lisp types.
4833 (Bug#11141)
4834
8427ddd2
EZ
48352012-03-31 Eli Zaretskii <eliz@gnu.org>
4836
979022ef
EZ
4837 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4838 position we get to after a call to move_it_to fails the
4839 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4840 only if we wind up in a string from display property. (Bug#11063)
4841
a6b1c7cc
EZ
4842 * window.c (Fdelete_other_windows_internal): Invalidate the row
4843 and column information about mouse highlight, so that redisplay
4844 restores it after reallocating the glyph matrices. (Bug#7464)
4845
8427ddd2
EZ
4846 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4847 string comes from a `display' text property, use the buffer
4848 position of that property as if we actually saw that position in
4849 the row's glyphs.
697ba24b
EZ
4850 (move_it_by_lines): Remove the assertion that
4851 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4852 violated when there's a before-string at the beginning of a line.
4853 (Bug#11063)
8427ddd2 4854
65a0a738
EZ
48552012-03-30 Eli Zaretskii <eliz@gnu.org>
4856
4857 * xdisp.c (append_space_for_newline): If the default face was
4858 remapped, use the remapped face for the appended newline.
4859 (extend_face_to_end_of_line): Use the remapped default face for
4860 extending the face to the end of the line.
4861 (display_line): Call extend_face_to_end_of_line when the default
4862 face was remapped. (Bug#11068)
4863
581355cc
EZ
48642012-03-29 Eli Zaretskii <eliz@gnu.org>
4865
4866 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4867
e8fc049f
SM
48682012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4869
4870 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4871
4fb9a543
GM
48722012-03-27 Glenn Morris <rgm@gnu.org>
4873
4874 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4875 Doc fixes.
4876
679910f1
KH
48772012-03-26 Kenichi Handa <handa@m17n.org>
4878
4879 * dispextern.h (struct glyph): Fix previous change. Change the
4880 bit length of glyphless.ch to 25 (Bug#11082).
4881
90d49b7f
CY
48822012-03-26 Chong Yidong <cyd@gnu.org>
4883
4884 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4885 (command_loop_1): Use it; inhibit selection update for
4886 handle-select-window too (Bug#8996).
4887
f514f6f0
FP
48882012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4889
e8fc049f 4890 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4891
bf43fa51
KH
48922012-03-25 Kenichi Handa <handa@m17n.org>
4893
4894 * dispextern.h (struct glyph): Change the bit length of
4895 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4896
8a0c01dd
EZ
48972012-03-24 Eli Zaretskii <eliz@gnu.org>
4898
4899 * s/ms-w32.h (tzname): Include time.h before redirecting to
4900 _tzname. Fixes the MSVC build. (Bug#9960)
4901
7d1c3a76
AS
49022012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4903
8ed79523
AS
4904 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4905 characters.
4906
7d1c3a76
AS
4907 * xterm.c (XTread_socket): Only modify handling_signal if
4908 !SYNC_INPUT. (Bug#11080)
4909
e99a9b8b
EZ
49102012-03-23 Eli Zaretskii <eliz@gnu.org>
4911
4912 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4913 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4914 when fetching a multibyte character consumes more bytes than
4915 CHAR_BYTES returns, due to unification of CJK characters in
4916 string_char. (Bug#11073)
4917
5063c0e1
TN
49182012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4919
4920 * process.c (wait_reading_process_output): Handle pty disconnect
4921 by refraining from sending oneself a SIGCHLD (bug#10933).
4922
9f851fbd
CY
49232012-03-22 Chong Yidong <cyd@gnu.org>
4924
4925 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4926
5063c0e1 4927 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4928 Mark string as coming from a prefix property.
4929 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4930 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4931
fb5b8aca
CY
49322012-03-21 Chong Yidong <cyd@gnu.org>
4933
4934 * xfaces.c (Vface_remapping_alist): Doc fix.
4935
62356a1b
EZ
49362012-03-20 Eli Zaretskii <eliz@gnu.org>
4937
4938 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4939 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4940 Doc fixes.
62356a1b 4941
025de85b
CY
49422012-03-20 Chong Yidong <cyd@gnu.org>
4943
4944 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4945 to reflect default non-nil value of redisplay-dont-pause.
4946
4827f94e
KH
49472012-03-19 Kenichi Handa <handa@m17n.org>
4948
4949 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4950 it fit in a valid range (Bug#11003).
4951
e50a24a2
EZ
49522012-03-18 Eli Zaretskii <eliz@gnu.org>
4953
4954 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4955 that is not from display property, accept the row as a "cursor
4956 row" if one of the string's character has a non-nil `cursor'
4957 property. Fixes cursor positioning when there are newlines in
4958 overlay strings, e.g. in icomplete.el. (Bug#11035)
4959
9af5ed87
PE
49602012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4961
4962 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4963
d1f55f16
CY
49642012-03-12 Chong Yidong <cyd@gnu.org>
4965
4966 * eval.c (inhibit_lisp_code): Rename from
4967 inhibit_window_configuration_change_hook; move from window.c.
4968
4969 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4970 * window.c (run_window_configuration_change_hook)
4971 (syms_of_window): Callers changed.
4972
66c5eebd
CY
49732012-03-11 Chong Yidong <cyd@gnu.org>
4974
413df973
CY
4975 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4976
66c5eebd
CY
4977 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4978
1de11f56
CY
49792012-03-10 Chong Yidong <cyd@gnu.org>
4980
4981 * frame.c (other_visible_frames): Don't assume the selected frame
4982 is visible (Bug#10955).
4983
cae07000
SM
49842012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4985
4986 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4987
89c94350
JD
49882012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4989
4990 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4991 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4992 zero (Bug#10954).
4993
999dd333
GM
49942012-03-03 Glenn Morris <rgm@gnu.org>
4995
01a6dcc8 4996 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4997
de0100f2
EZ
49982012-03-02 Eli Zaretskii <eliz@gnu.org>
4999
5000 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5001 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5002 (redisplay_window, next_element_from_string): Fix typos in
5003 comments.
3e441275
EZ
5004 (redisplay_window): Pass to move_it_vertically the margin in
5005 pixels, not in screen lines.
de0100f2 5006
96a72ee9
GM
50072012-03-02 Glenn Morris <rgm@gnu.org>
5008
5009 * buffer.c (buffer-list-update-hook): Doc fix.
5010
312508d7
EZ
50112012-02-29 Eli Zaretskii <eliz@gnu.org>
5012
5013 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5014 push_it before setting up the iterator for the first overlay
5015 string, even if we have an empty string loaded.
5016 (next_overlay_string): If there's an empty string on the iterator
5017 stack, pop the stack. (Bug#10903)
5018
27f3c637
PE
50192012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5020
5021 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5022 Suggested by Stefan Monnier in
5023 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5024 * alloc.c (widen_to_Lisp_Object): New static function.
5025 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5026 and widening them to Lisp_Objects. This would work even if
5027 USE_LSB_TAG is defined and wide integers are used, which might
5028 happen in a future version of Emacs.
5029
3c9dfce6
CY
50302012-02-25 Chong Yidong <cyd@gnu.org>
5031
fa74b241
CY
5032 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5033 Doc fix.
5034
3c9dfce6
CY
5035 * xselect.c (Fx_selection_exists_p): Doc fix.
5036 (x_clipboard_manager_save_all): Print an informative message
5037 before saving to clipboard manager.
5038
9486df08
CY
50392012-02-24 Chong Yidong <cyd@gnu.org>
5040
5041 * keyboard.c (process_special_events): Handle all X selection
5042 requests in kbd_buffer, not just the next one (Bug#8869).
5043
f01d3321
CY
50442012-02-23 Chong Yidong <cyd@gnu.org>
5045
5046 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5047 call when setting menu-bar-lines and tool-bar-lines parameters.
5048 (unwind_create_frame_1): New helper function.
5049
5050 * window.c (inhibit_window_configuration_change_hook): New var.
5051 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5052 (syms_of_window): Initialize it.
f01d3321 5053
86b847b6
CY
50542012-02-22 Chong Yidong <cyd@gnu.org>
5055
5056 * xterm.c (x_draw_image_relief): Add missing type check for
5057 Vtool_bar_button_margin (Bug#10743).
5058
a59225b1
CY
50592012-02-21 Chong Yidong <cyd@gnu.org>
5060
5061 * fileio.c (Vfile_name_handler_alist): Doc fix.
5062
5063 * buffer.c (Fget_file_buffer): Protect against invalid file
5064 handler return value.
5065
310f5bd4
PE
50662012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5067
cb3a28cc
PE
5068 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5069 when computing $valmask.
5070
310f5bd4
PE
5071 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5072 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5073 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5074 It's useless in that case, and it can cause problems on hosts
5075 that allocate halves of EMACS_INT values separately.
5076 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5077 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5078 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5079 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5080 it avoids undefined behavior on hosts where shifting right by more
5081 than the word width has undefined behavior.
5082
2375c96a
CY
50832012-02-19 Chong Yidong <cyd@gnu.org>
5084
5085 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5086 (Funhandled_file_name_directory, Ffile_name_as_directory)
5087 (Fdirectory_file_name, Fexpand_file_name)
5088 (Fsubstitute_in_file_name): Protect against invalid file handler
5089 return values (Bug#10845).
5090
3eb49e71
EZ
50912012-02-18 Eli Zaretskii <eliz@gnu.org>
5092
5093 * .gdbinit (pitx): Fix incorrect references to fields of the
5094 iterator stack.
5095
7b926f3f
CY
50962012-02-17 Chong Yidong <cyd@gnu.org>
5097
5098 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5099
11273115
PE
51002012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5101
5102 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5103 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5104
c3a70e2b
CY
51052012-02-15 Chong Yidong <cyd@gnu.org>
5106
5107 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5108 marked as special. Also, starting docstrings with * is obsolete.
5109
0ca43699
AS
51102012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5111
5112 * gnutls.c (emacs_gnutls_write): Fix last change.
5113
2e8f3c56
LI
51142012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5115
5116 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5117 send_process.
5118
af70074f
SM
51192012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5120
5121 * keymap.c (Fsingle_key_description): Handle char ranges.
5122
95986d52
CY
51232012-02-12 Chong Yidong <cyd@gnu.org>
5124
afd83bd1
CY
5125 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5126 as that creates a dangerous corner case.
5127
95986d52
CY
5128 * window.c (Fdelete_window_internal): Invalidate the mouse
5129 highlight (Bug#9904).
5130
bd7da63e
GM
51312012-02-12 Glenn Morris <rgm@gnu.org>
5132
5133 * xselect.c (Fx_own_selection_internal)
5134 (Fx_get_selection_internal, Fx_disown_selection_internal)
5135 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5136 * nsselect.m (Fx_own_selection_internal)
5137 (Fx_disown_selection_internal, Fx_selection_exists_p)
5138 (Fx_selection_owner_p, Fx_get_selection_internal):
5139 Sync docs and argument specs with the xselect.c versions.
5140
77abcbc2
LI
51412012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5142
5143 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5144
90b671e2
EZ
51452012-02-11 Eli Zaretskii <eliz@gnu.org>
5146
1c0ca0b7
EZ
5147 * w32select.c (Fx_selection_exists_p): Sync doc string and
5148 argument list with xselect.c. (Bug#10783)
5149
5150 * w16select.c (Fx_selection_exists_p): Sync doc string and
5151 argument list with xselect.c. (Bug#10783)
90b671e2 5152
49241268
GM
51532012-02-10 Glenn Morris <rgm@gnu.org>
5154
5155 * fns.c (Fsecure_hash): Doc fix.
5156
f998bbe7 51572012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5158
5159 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5160
0992bd9c
CY
51612012-02-07 Chong Yidong <cyd@gnu.org>
5162
5163 * buffer.c (Fbuffer_local_variables)
5164 (buffer_lisp_local_variables): Handle unbound vars correctly;
5165 don't let Qunbound leak into Lisp.
5166
af008560
GM
51672012-02-07 Glenn Morris <rgm@gnu.org>
5168
dd605cc4
GM
5169 * image.c (Fimagemagick_types): Doc fix.
5170
af008560
GM
5171 * image.c (imagemagick-render-type): Change it from a lisp object
5172 to an integer. Move the doc here from the lisp manual.
5173 Treat all values not equal to 0 the same.
5174
1449fa1d
CY
51752012-02-06 Chong Yidong <cyd@gnu.org>
5176
5177 * doc.c (store_function_docstring): Avoid applying docstring of
5178 alias to base function (Bug#2603).
5179
3723ec07
AS
51802012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5181
5182 * .gdbinit (pp1, pv1): Remove redundant defines.
5183 (pr): Use pp.
5184
79c1cc1e
CY
51852012-02-04 Chong Yidong <cyd@gnu.org>
5186
5187 * nsterm.m: Declare a global (Bug#10694).
5188
d7f29f8e
EZ
51892012-02-04 Eli Zaretskii <eliz@gnu.org>
5190
cae07000
SM
5191 * w32.c (get_emacs_configuration_options):
5192 Include --enable-checking, if specified, in the return value.
d7f29f8e 5193
3b95a6f9
MR
51942012-02-04 Martin Rudalics <rudalics@gmx.at>
5195
5196 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5197 after rounding frame sizes. (Bug#9723)
5198
d6fa96a6
EZ
51992012-02-04 Eli Zaretskii <eliz@gnu.org>
5200
5201 * keyboard.c (adjust_point_for_property): Don't position point
5202 before BEGV. (Bug#10696)
5203
df0b2940
PE
52042012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5205
5206 Handle overflow when computing char display width (Bug#9496).
5207 * character.c (char_width): Return EMACS_INT, not int.
5208 (char_width, c_string_width): Check for overflow when
5209 computing the width; this is possible now that individual
5210 characters can have unbounded width. Problem introduced
5211 by merge from Emacs 23 on 2012-01-19.
5212
6bee44d6
MA
52132012-02-02 Michael Albinus <michael.albinus@gmx.de>
5214
5215 * dbusbind.c (Fdbus_register_method): Mention the return value
5216 :ignore in the docstring.
5217
44f92739
GM
52182012-02-02 Glenn Morris <rgm@gnu.org>
5219
1b9f60cc
GM
5220 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5221
44f92739
GM
5222 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5223 Unconditionally set to t. (Bug#10673)
5224 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5225 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5226 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5227
c5d3843c
KH
52282012-02-02 Kenichi Handa <handa@m17n.org>
5229
5230 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5231 0, do not call append_composite_glyph.
5232
159462d4 52332012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5234
5235 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5236 NULL (Bug#6988).
5237 (x_produce_glyphs): If the component of a composition is a null
5238 string, set it->pixel_width to 1 to avoid zero-width glyph.
5239
78cef877
EZ
52402012-02-01 Eli Zaretskii <eliz@gnu.org>
5241
5242 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5243 first 2 arguments are identical. This makes inserting large
5244 output from a subprocess an order of magnitude faster on
5245 MS-Windows, where all sbrk'ed memory is always contiguous.
5246
97897668
GM
52472012-01-31 Glenn Morris <rgm@gnu.org>
5248
5249 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5250 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5251 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5252
31fd3586
GM
52532012-01-29 Glenn Morris <rgm@gnu.org>
5254
5255 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5256
0e24a8b2
CY
52572012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5258
5259 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5260
cc0adcb0
CY
52612012-01-28 Chong Yidong <cyd@gnu.org>
5262
5263 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5264
acc28cb9
CY
52652012-01-26 Chong Yidong <cyd@gnu.org>
5266
9c69cfb7
CY
5267 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5268
acc28cb9
CY
5269 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5270 repeat counts (Bug#10507).
5271
48da7392
GM
52722012-01-26 Glenn Morris <rgm@gnu.org>
5273
5274 * lread.c (syms_of_lread): Doc fix.
5275
14af5f7f
CY
52762012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5277
5278 * coding.c (encode_designation_at_bol): Change return value to
5279 EMACS_INT.
5280
0b21c100
CY
52812012-01-25 Chong Yidong <cyd@gnu.org>
5282
5283 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5284
3c2907f7
CY
52852012-01-21 Chong Yidong <cyd@gnu.org>
5286
5287 * floatfns.c (Fcopysign): Make the second argument non-optional,
5288 since nil is not allowed anyway.
5289
959ad23f
AS
52902012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5291
5292 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5293 (send_process): Likewise.
5294
34a02f46
MR
52952012-01-19 Martin Rudalics <rudalics@gmx.at>
5296
5297 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5298 (Vwindow_persistent_parameters): Do not use Qstate.
5299 Rewrite doc-strings.
34a02f46 5300
1259009a 53012012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5302
5303 * character.c (char_width): New function.
70d4fdf6
GM
5304 (Fchar_width, c_string_width, lisp_string_width):
5305 Use char_width (Bug#9496).
25ed9e61 5306
6a6ee00d
MR
53072012-01-16 Martin Rudalics <rudalics@gmx.at>
5308
5309 * window.c (Vwindow_persistent_parameters): New variable.
5310 (Fset_window_configuration, save_window_save): Handle persistent
5311 window parameters.
5312
c85efaf7
EZ
53132012-01-14 Eli Zaretskii <eliz@gnu.org>
5314
5315 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5316 thrashing the stack of the thread. (Bug#9087)
5317
5944709e
PE
53182012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5319
5320 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5321
e71f5d99
EZ
53222012-01-11 Eli Zaretskii <eliz@gnu.org>
5323
5324 * xdisp.c (rows_from_pos_range): Handle the case where the
5325 highlight ends on a newline. (Bug#10464)
5326 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5327 he end column for display of highlight that ends on a newline
5328 before a R2L line.
5329
ce316182
GM
53302012-01-11 Glenn Morris <rgm@gnu.org>
5331
5332 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5333 from load-path also when installation-directory is nil. (Bug#10208)
5334
5b43da69
GM
53352012-01-10 Glenn Morris <rgm@gnu.org>
5336
74cc8ff9
GM
5337 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5338
7d8d6e4e
GM
5339 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5340 Update template values to be closer to their typical values these days.
5b43da69 5341
a0db8d43
EZ
53422012-01-09 Eli Zaretskii <eliz@gnu.org>
5343
5344 * xdisp.c (rows_from_pos_range): Accept additional argument
5345 DISP_STRING, and accept any glyph in a row whose object is that
5346 string as eligible for mouse highlight. Fixes mouse highlight of
5347 display strings from overlays. (Bug#10464)
5348
9a0115ab 53492012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5350
b9110d6a 5351 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5352 * fileio.c (auto_saving_dir_umask): New static var.
5353 (Fmake_directory_internal): Use it.
5354 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5355 creating the directory. The old code temporarily assigns
5356 too-generous permissions to the directory.
5357 (do_auto_save_eh): Clear it.
b9110d6a 5358 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5359 that the var is always cleared.
5360
6c1bd3f3
EZ
53612012-01-07 Eli Zaretskii <eliz@gnu.org>
5362
5363 * search.c (scan_buffer): Pass character positions to
5364 know_region_cache, not byte positions. (Bug#6540)
5365
069d2b50
L
53662012-01-07 LynX <_LynX@bk.ru> (tiny change)
5367
5368 * w32.c (sys_rename): Report EXDEV when rename of a directory
5369 fails because the target is on another logical disk. (Bug#10284)
5370
75bf0d33
DB
53712012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5372
5373 * xterm.c (x_embed_request_focus): New function.
5374
5375 * xterm.h: Add prototype.
5376
5377 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5378
1c6e5a32
GM
53792012-01-05 Glenn Morris <rgm@gnu.org>
5380
5381 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5382
651e947e
EZ
53832012-01-01 Eli Zaretskii <eliz@gnu.org>
5384
5385 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5386 Load gnutls_transport_set_lowat only if GnuTLS version is below
5387 2.11.1.
5388 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5389 GnuTLS versions below 2.11.1.
5390
3778cdd8
AL
53912011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5392
5393 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5394 to the doc string advising against its use for altering the way
5395 windows are scrolled.
5396
0e5317f7
KH
53972011-12-28 Kenichi Handa <handa@m17n.org>
5398
5399 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5400 coding-system ASCII compatible only when it does not produce BOM
5401 on encoding (Bug#10383).
5402
93d5ca1f
JD
54032011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5404
5405 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5406 can scroll.
5407 (create_and_show_popup_menu): Always use menu_position_func for
5408 Gtk3 (Bug#10361).
5409
ca22b785
AS
54102011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5411
5412 * callint.c (Fcall_interactively): Don't truncate prompt string.
5413
d048e1e6
EZ
54142011-12-23 Eli Zaretskii <eliz@gnu.org>
5415
5416 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5417 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5418 resumed from there (after widening). (Bug#10360)
d048e1e6 5419
5ccaba1f
JD
54202011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5421
5422 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5423
204ee57f
JD
54242011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5425
b81d40f0
JB
5426 * nsterm.m (x_free_frame_resources):
5427 Release f->output_data.ns->miniimage.
204ee57f
JD
5428 (ns_index_color): Fix indentation. Do not retain
5429 color_table->colors[i].
5430
5431 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5432 before returning.
5433
5434 * nsfns.m (x_set_background_color): Assign return value from
5435 ns_index_color to face-background instead of NSColor*.
5436 (ns_implicitly_set_icon_type): Fix indentation.
5437 Change assignment in for loop to comparison.
5438
5439 * emacs.c (ns_pool): New variable.
5440 (main): Assign ns_pool.
5441 (Fkill_emacs): Call ns_release_autorelease_pool.
5442
5443 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5444 autorelease fdesc, release fdAttrs and tdict.
5445 (ns_get_covering_families): Release charset.
5446 (ns_findfonts): Release NSFontDescriptor created with new.
5447 (ns_uni_to_glyphs): Fix indentation.
5448 (setString): Release attrStr before assigning new value.
5449
c803b2b7
JD
54502011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5451
678f4426
JD
5452 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5453 and NS_IMPL_COCOA.
5454 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5455 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5456
cd394be1 54572011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5458
5fecd5fc
JD
5459 * nsterm.m (ns_term_init): Subscribe for notifications
5460 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5461 to method trackingNotification in EmacsMenu.
5462
5463 * nsmenu.m (trackingMenu): New variable.
3771cb17 5464 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5465 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5466 from Aquamacs (Bug#7030).
678f4426
JD
5467
54682011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5469
c803b2b7
JD
5470 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5471 (symbol_to_nsstring): Fix indentation.
5472 (ns_symbol_to_pb): New function.
cae07000
SM
5473 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5474 (Fns_rotate_cut_buffers_internal): Remove.
5475 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5476 Fns_store_cut_buffer_internal.
5477 (ns_get_foreign_selection, Fx_own_selection_internal)
5478 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5479 (Fns_get_selection_internal, Fns_store_selection_internal):
5480 Use ns_symbol_to_pb and check if return value is nil.
5481 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5482 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5483 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5484 renamed to Sns_store_selection_internal.
5485 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5486 and remove this function.
5487 (ns_handle_selection_clear): Remove, never used.
5488 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5489 here.
5490
e1b01a3a
KB
54912011-12-17 Ken Brown <kbrown@cornell.edu>
5492
5493 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5494 GID is unknown (Bug#10257).
5495
2adb6e85
PE
54962011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5497
5498 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5499 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5500 which caused a build failure on GNU/Linux IA-64. This problem was
5501 introduced by my 2011-10-07 patch.
5502
d1d7b339
JL
55032011-12-15 Juri Linkov <juri@jurta.org>
5504
5505 * image.c (imagemagick_error): New function. (Bug#10112)
5506 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5507 Use `imagemagick_error' where ImageMagick functions return
5508 `MagickFalse'.
5509 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5510 proper order.
5511
100d5755
KH
55122011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5513
5514 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5515 fill background (Bug#8992).
5516
454592a6
MR
55172011-12-13 Martin Rudalics <rudalics@gmx.at>
5518
5519 * window.c (Vwindow_combination_resize)
5520 (Vwindow_combination_limit): Use t instead of non-nil in
5521 doc-strings.
61d4b438
MR
5522 (Vrecenter_redisplay): Add first sentence of doc-string on
5523 separate line.
53524d93 5524 (Frecenter): Fix doc-string typo.
454592a6 5525
3633e3aa
KH
55262011-12-11 Kenichi Handa <handa@m17n.org>
5527
5528 * coding.c (Funencodable_char_position): Pay attention to the
5529 buffer text relocation (Bug#9389).
5530
7b9d523a 55312011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5532
7b9d523a
JD
5533 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5534 gtk_init (Bug#10100).
5535
b73189c6
EZ
55362011-12-10 Eli Zaretskii <eliz@gnu.org>
5537
5538 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5539 IT->string is nil. (Bug#10263)
5540
f7dfe5d6
JD
55412011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5542
83faebb4
JD
5543 * nsterm.h (x_free_frame_resources): Declare.
5544
f7dfe5d6
JD
5545 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5546 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5547
5548 * nsterm.h (ns_get_defaults_value): Declare.
5549
5550 * nsterm.m (ns_default): Call ns_get_defaults_value.
5551
7cd4e72c
EZ
55522011-12-09 Eli Zaretskii <eliz@gnu.org>
5553
5554 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5555 (Bug#10170)
5556
b34d7317
YM
55572011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5558
5559 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5560 that where the value of an _OBJC_* symbol points to is in the .bss
5561 section (Bug#10240).
5562
76470ad1
KH
55632011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5564
5565 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5566 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5567
745fff94
KH
55682011-12-08 Kenichi Handa <handa@m17n.org>
5569
5570 * ftfont.c (get_adstyle_property): Fix previous change
5571 (Bug#10233).
5572
6e44397c
JB
55732011-12-07 Juanma Barranquero <lekktu@gmail.com>
5574
5575 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5576 dirs from the default value of EMACSLOADPATH (bug#10208).
5577
7efa6272
GM
55782011-12-07 Glenn Morris <rgm@gnu.org>
5579
5580 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5581 installation and source directories as well. (Bug#10208)
5582
f6fc4d87
CY
55832011-12-06 Chong Yidong <cyd@gnu.org>
5584
5585 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5586
2bf26180
GM
55872011-12-06 Glenn Morris <rgm@gnu.org>
5588
5589 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5590 as an error, not just -1. (Bug#10217)
5591
3a6ad4f0
CY
55922011-12-05 Chong Yidong <cyd@gnu.org>
5593
5594 * keyboard.c (process_special_events): New function.
5595 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5596
75a3b399
PE
55972011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5598
5599 * coding.c (encode_designation_at_bol): Don't use uninitialized
5600 local variable (Bug#9318).
5601
c3c9e25e
KH
56022011-12-05 Kenichi Handa <handa@m17n.org>
5603
5604 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5605 return Qnil (Bug#8046, Bug#10193).
5606
5eb05ea3
KH
56072011-12-05 Kenichi Handa <handa@m17n.org>
5608
5609 * coding.c (encode_designation_at_bol): New args charbuf_end and
5610 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5611 (coding_set_source): Return how many bytes coding->source was
5612 relocated.
5613 (coding_set_destination): Return how many bytes
5614 coding->destination was relocated.
5615 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5616 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5617
56182011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5619
5620 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5621 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5622 macro (Bug#9318).
5623
56242011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5625
5626 The following changes are to fix Bug#9318.
5627
a79703f5 5628 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5629 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5630 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5631 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5632
7dbda6df
JB
56332011-12-05 Juanma Barranquero <lekktu@gmail.com>
5634
5635 * lisp.h (process_quit_flag): Fix external declaration.
5636
6d5eb5b0
SM
56372011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5638
5639 Don't macro-inline non-performance-critical code.
5640 * eval.c (process_quit_flag): New function.
5641 * lisp.h (QUIT): Use it.
5642
a0c3fad0
JD
56432011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5644
5645 * nsfns.m (get_geometry_from_preferences): New function.
5646 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5647
6c07aac2
AS
56482011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5649
5650 * emacs.c (Qkill_emacs): Define.
5651 (syms_of_emacs): Initialize it.
5652 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5653 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5654 (quit_throw_to_read_char): Add parameter `from_signal'.
5655 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5656 * lisp.h (QUIT): Call Fkill_emacs if requested.
5657
c052ead4
JD
56582011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5659
5660 * widget.c (update_wm_hints): Return if wmshell is null.
5661 (widget_update_wm_size_hints): New function.
5662
5663 * widget.h (widget_update_wm_size_hints): Declare.
5664
5665 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5666 widget_update_wm_size_hints (Bug#10104).
5667
9e49252b
EZ
56682011-12-03 Eli Zaretskii <eliz@gnu.org>
5669
5670 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5671 before a newline, prepare the bidi iterator for consuming the
5672 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5673 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5674
02b16839
JL
56752011-12-02 Juri Linkov <juri@jurta.org>
5676
5677 * search.c (Fword_search_regexp): New Lisp function created from
5678 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5679 (Fword_search_backward, Fword_search_forward)
5680 (Fword_search_backward_lax, Fword_search_forward_lax):
5681 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5682 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5683
0068070e
SM
56842011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5685
5686 * fileio.c (Finsert_file_contents): Move after-change-function call
5687 to before the "handled:" label, since all "goto handled" appear in
5688 cases where the *-change-functions have already been properly called
5689 (bug#10117).
5690
3360a3fc
AS
56912011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5692
5693 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5694 waiting for input. (Bug#10169)
5695
73d6c093
EZ
56962011-11-30 Eli Zaretskii <eliz@gnu.org>
5697
5698 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5699 verifies glyph row's hash code--we have just reallocated the
5700 glyphs, so their contents can be complete garbage. (Bug#10164)
5701
febe6bea
JB
57022011-11-30 Juanma Barranquero <lekktu@gmail.com>
5703
5704 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5705
801a4313
EZ
57062011-11-30 Eli Zaretskii <eliz@gnu.org>
5707
5708 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5709 attributes are tested _before_ calling verify_row_hash, to protect
5710 against GCC re-ordering of the tests. (Bug#10164)
5711
2b56b87e
JD
57122011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5713
5714 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5715
5716 * xterm.c (handle_one_xevent): Only set async_visible and friends
5717 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5718 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5719 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5720
dbf31225
PE
57212011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5722
5723 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5724 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5725 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5726 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5727 All uses changed to use GCPRO1 etc.
5728 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5729 Revert to old implementation (i.e., before 2011-03-11).
5730
1305621b
YM
57312011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5732
5733 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5734 of scroll runs so as to avoid assigning disabled bogus rows and
5735 unnecessary graphics copy operations.
5736
8c9afb46
EZ
57372011-11-27 Eli Zaretskii <eliz@gnu.org>
5738
5739 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5740 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5741 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5742 (malloc, free, realloc, calloc): Redirect to e_* only when
5743 compiling Emacs.
5744
5745 * lisp.h (GCTYPEBITS): Move before first use.
5746 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5747 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5748 this macro definition.
5749
5750 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5751 _MSC_VER.
5752
54e9e3bf
JD
57532011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5754
6d5eb5b0
SM
5755 * gtkutil.c (xg_create_frame_widgets):
5756 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5757 present with Gtk+ 2.0.
5758
83aca1cb
PE
57592011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5760
5761 * fileio.c (Finsert_file_contents): Undo previous change; see
5762 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5763
5b76caa4
PE
57642011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5765
5766 Rename locals to avoid shadowing.
5767 * fileio.c (Finsert_file_contents):
5768 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5769 * process.c (wait_reading_process_output):
5770 Rename inner 'proc' to 'p' to avoid shadowing.
5771 Indent for consistency with usual Emacs style.
5772
8c535114
EZ
57732011-11-25 Eli Zaretskii <eliz@gnu.org>
5774
5775 * xdisp.c (redisplay_window): If cursor row is not fully visible
5776 after recentering, and scroll-conservatively is set to a large
5777 number, scroll window by a few more lines to make the cursor fully
5778 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5779 (start_display): Don't move to the next line if the display should
5780 start at a newline that is part of a display vector or an overlay
5781 string. (Bug#10119)
8c535114 5782
fa4fdb5c
JL
57832011-11-24 Juri Linkov <juri@jurta.org>
5784
5785 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5786 after the `MagickPingImage' call. (Bug#10112)
5787
90ec88df
CY
57882011-11-23 Chong Yidong <cyd@gnu.org>
5789
5790 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5791
56e2e794
MR
57922011-11-23 Martin Rudalics <rudalics@gmx.at>
5793
5794 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5795 making another buffer current. (Bug#10114)
5796
b6e64c41
GM
57972011-11-23 Glenn Morris <rgm@gnu.org>
5798
5799 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5800
6b21de18
CY
58012011-11-23 Chong Yidong <cyd@gnu.org>
5802
5803 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5804 using it (Bug#5984).
5805
b12cd789
EZ
58062011-11-22 Eli Zaretskii <eliz@gnu.org>
5807
5808 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5809 and header-lines, as they don't have one computed for them.
5810 (Bug#10098)
5811
5812 * .gdbinit (prow): Make displayed values more self-explaining.
5813 Add row's hash code.
5814
261b6fd4
LMI
58152011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5816
5817 * process.c (wait_reading_process_output): Fix asynchrounous
5818 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5819 (wait_reading_process_output): Add comment and URL.
261b6fd4 5820
e7cfd277
JD
58212011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5822
5823 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5824
a9b9b7f5
CY
58252011-11-21 Chong Yidong <cyd@gnu.org>
5826
5827 * window.c (Fnext_window, Fprevious_window): Doc fix.
5828
b0d15b4f
SM
58292011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5830
5831 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5832
fe7a3057
JB
58332011-11-20 Juanma Barranquero <lekktu@gmail.com>
5834
5835 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5836
d2999b1a
MR
58372011-11-20 Martin Rudalics <rudalics@gmx.at>
5838
5839 * window.c (Fset_window_combination_limit): Rename argument
5840 STATUS to LIMIT.
5841 (Vwindow_combination_limit): Remove "status" from doc-string.
5842
d5ff9cd0
AS
58432011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5844
5845 * m/ibms390.h: Remove.
5846 * m/ibms390x.h: Don't include "ibms390.h".
5847
a5bb9bd3
SM
58482011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5849
5850 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5851 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5852
cd1181db
JB
58532011-11-20 Juanma Barranquero <lekktu@gmail.com>
5854
5855 * casetab.c (Fset_case_table):
5856 * charset.c (Fcharset_after): Fix typos.
5857
615a3b8d 58582011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5859
17e845af
PE
5860 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5861 Otherwise, valgrind does not work on some platforms.
5862 Problem reported by Andreas Schwab in
6a0bf43d
PE
5863 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5864 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5865 is set, removing the need for VIRT_ADDRESS_VARIES.
5866 (PURE_P): Use a more-efficient implementation that needs just one
5867 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5868 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5869 to 4 (xorl, subq, cmpq, setbe).
5870 * alloc.c (pure): Always extern now, since that's the
5871 VIRT_ADDR_VARIES behavior.
5872 (PURE_POINTER_P): Use a single comparison, not two, for
5873 consistency with the new puresize.h.
5874 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5875 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5876 Remove VIRT_ADDR_VARIES no longer needed.
5877
f8fe6f96
EZ
58782011-11-19 Eli Zaretskii <eliz@gnu.org>
5879
5880 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5881 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5882 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5883 behave as if the cursor position were at the window margin.
5884
5885 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5886 and the cursor position is out of bounds, behave as if the cursor
5887 position were at the window margin. (Bug#10075)
5888
df05a53c
CY
58892011-11-18 Chong Yidong <cyd@gnu.org>
5890
5891 * window.c (Fwindow_combination_limit): Make first argument
5892 non-optional, since it is meaningless for live windows like the
5893 selected window.
61ccba97 5894
2071918e
DA
58952011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5896
5897 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5898
b50a28de
SM
58992011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5900
5901 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5902 (graft_intervals_into_buffer): Simplify.
5903
015137db
EZ
59042011-11-18 Eli Zaretskii <eliz@gnu.org>
5905
5906 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5907 hash values of the two rows.
5908 (copy_row_except_pointers): Preserve the used[] arrays and the
5909 hash values of the two rows. (Bug#10035)
68c95424 5910 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5911
5912 * xdisp.c (row_hash): New function, body extracted from
5913 compute_line_metrics.
5914 (compute_line_metrics): Call row_hash, instead of computing the
5915 hash code inline.
5916
5917 * dispnew.c (verify_row_hash): Call row_hash for computing the
5918 hash code of a row, instead of duplicating code from xdisp.c.
5919
5920 * dispextern.h (row_hash): Add prototype.
5921
a2addb04
TH
59222011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5923
5924 * frame.c (delete_frame): Don't delete the terminal when the last
5925 X frame is closed if emacs is built with GTK toolkit.
5926
df85d315
JB
59272011-11-17 Juanma Barranquero <lekktu@gmail.com>
5928
5929 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5930
a0c2d0ae
MR
59312011-11-17 Martin Rudalics <rudalics@gmx.at>
5932
5933 * window.c (Vwindow_splits): Rename to
5934 Vwindow_combination_resize. Suggested by Juri Linkov.
5935 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5936 of Vwindow_splits.
5937
58179cce
JB
59382011-11-16 Juanma Barranquero <lekktu@gmail.com>
5939
7877f373
JB
5940 * nsfns.m (Fns_font_name):
5941 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5942
b6f67890
MR
59432011-11-16 Martin Rudalics <rudalics@gmx.at>
5944
5945 * window.h (window): Rename slot "nest" to "combination_limit".
5946 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5947 (Fset_window_nest): Rename to Fset_window_combination_limit.
5948 (Vwindow_nest): Rename to Vwindow_combination_limit.
5949 (recombine_windows, make_parent_window, make_window)
5950 (Fsplit_window_internal, saved_window)
5951 (Fset_window_configuration, save_window_save): Rename all
5952 occurrences of window_nest to window_combination_limit.
5953
c7015153
JB
59542011-11-15 Juanma Barranquero <lekktu@gmail.com>
5955
5956 * image.c (imagemagick_load_image): Fix typo.
5957
322ad6ec
EZ
59582011-11-14 Eli Zaretskii <eliz@gnu.org>
5959
5960 * xdisp.c (display_line): Move the call to
5961 highlight_trailing_whitespace before the call to
5962 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5963 faces of all the glyphs to compute ROW's hash value.
5964 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5965
f067b8ec
JB
59662011-11-14 Juanma Barranquero <lekktu@gmail.com>
5967
5968 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5969 just return (bug#10044).
5970
1e5b2111
EZ
59712011-11-12 Eli Zaretskii <eliz@gnu.org>
5972
7ef3cbd5
EZ
5973 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5974 with user-defined heap size. Bump the default size of the temacs
5975 heap to 27MB, to avoid memory warning when running temacs.
5976 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5977
1e5b2111
EZ
5978 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5979 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5980 (verify_row_hash) [XASSERTS]: New function.
5981 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5982 that the hash value of glyph rows is correct.
1e5b2111 5983
89d61221
MR
59842011-11-12 Martin Rudalics <rudalics@gmx.at>
5985
5986 * window.h (window): Remove splits slot.
5987 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5988 (Fdelete_other_windows_internal, make_parent_window)
5989 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5990 (Fset_window_configuration, save_window_save): Don't deal with
5991 split status of windows.
5992 (saved_window): Remove splits slot.
5993 (Vwindow_splits): Rewrite doc-string.
5994
97f18cc8
JD
59952011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5996
5997 * xfns.c (unwind_create_frame):
5998 * nsfns.m (unwind_create_frame):
5999 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6000 Vframe_list (Bug#9999).
6001
22a648b4
DA
60022011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6003
0b381c7e 6004 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6005
659afede
KH
60062011-11-11 Kenichi Handa <handa@m17n.org>
6007
6008 * callproc.c (Fcall_process): Set the member dst_multibyte of
6009 process_coding.
6010
9ac0394b
KH
60112011-11-11 Johan Bockgård <bojohan@gnu.org>
6012
6013 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6014 avoid a crash (bug#9496).
6015
2fbdc249
CY
60162011-11-09 Chong Yidong <cyd@gnu.org>
6017
6018 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6019 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6020
ac6b1f81
PE
60212011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6022
6023 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6024
09db192c
PE
60252011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6026
6027 Avoid some portability problems by eschewing 'extern inline' functions.
6028 The trivial performance wins aren't worth the portability hassles; see
6029 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6030 et seq.
6031 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6032 (window_box_width, window_box_left, window_box_left_offset)
6033 (window_box_right, window_box_right_offset): Undo previous change,
6034 by removing the "extern"s.
6035 * intervals.c (adjust_intervals_for_insertion)
6036 (adjust_intervals_for_deletion): Undo previous change,
6037 making these static again.
6038 (offset_intervals, temp_set_point_both, temp_set_point)
6039 (copy_intervals_to_string): No longer inline.
6040 * xdisp.c (window_text_bottom_y, window_box_width)
6041 (window_box_height, window_box_left_offset)
6042 (window_box_right_offset, window_box_left, window_box_right)
6043 (window_box): No longer inline.
6044
105216ed
CY
60452011-11-08 Chong Yidong <cyd@gnu.org>
6046
6047 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6048 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6049 Signal an error if not a live window.
105216ed
CY
6050 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6051 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6052
ae9e237f
JB
60532011-11-07 Juanma Barranquero <lekktu@gmail.com>
6054
6055 * lisp.h (syms_of_abbrev): Remove declaration.
6056 Reported by CHENG Gao <chenggao@royau.me>.
6057
c7aa8333
EZ
60582011-11-07 Eli Zaretskii <eliz@gnu.org>
6059
6060 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6061 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6062 of temacs in GUI mode.
6063
be7f5545
MR
60642011-11-07 Martin Rudalics <rudalics@gmx.at>
6065
6066 * window.h: Declare delete_all_child_windows instead of
6067 delete_all_subwindows.
6068 * window.c (Fwindow_nest, Fset_window_nest)
6069 (Fset_window_new_total, Fset_window_new_normal)
6070 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6071 (delete_all_subwindows): Rename to delete_all_child_windows.
6072 (Fdelete_other_windows_internal, Fset_window_configuration):
6073 Call delete_all_child_windows instead of delete_all_subwindows.
6074 * frame.c (delete_frame): Call delete_all_child_windows instead
6075 of delete_all_subwindows.
6076
ca78dc43
PE
60772011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6078
6079 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6080 This is also needed for porting to any host where GC_MARK_STACK is
6081 not GC_MAKE_GCPROS_NOOPS.
6082 (which_symbols): Use it.
6083
a0241d01
KH
60842011-11-07 Kenichi Handa <handa@m17n.org>
6085
6086 * coding.c (coding_set_destination): Check coding->src_pos only
6087 when coding->src_object is a buffer (bug#9910).
6088
6089 * process.c (send_process): Set the member src_multibyte of coding
6090 to 0 (bug#9911) when sending a unibyte text.
6091
6092 * callproc.c (Fcall_process): Set the member src_multibyte of
6093 process_coding to 0 (bug#9912).
6094
a64bfdfa 60952011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6096
6097 * xmenu.c (cleanup_widget_value_tree): New function.
6098 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6099 calling free_menubar_widget_value_tree directly (Bug#9830).
6100
cb41b32a
PE
61012011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6102
6103 Fix some portability problems with 'inline'.
6104 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6105 (window_box_width, window_box_left, window_box_left_offset)
6106 (window_box_right, window_box_right_offset): Declare extern.
6107 Otherwise, these inline functions do not conform to C99 and
6108 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6109 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6110 * intervals.c (adjust_intervals_for_insertion)
6111 (adjust_intervals_for_deletion): Now extern, because otherwise the
6112 extern inline functions 'offset_intervals' couldn't refer to it.
6113 (static_offset_intervals): Remove.
6114 (offset_intervals): Rewrite using the old contents of
6115 static_offset_intervals. The old version didn't conform to C99
6116 because an extern inline function contained a reference to an
6117 identifier with static linkage.
6118
b7041366
AS
61192011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6120
6121 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6122 GC.
6123
88a37c4d
EZ
61242011-11-06 Eli Zaretskii <eliz@gnu.org>
6125
6126 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6127 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6128 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6129 return Qleft_to_right.
6130
49745b39
CY
61312011-11-06 Chong Yidong <cyd@gnu.org>
6132
6133 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6134 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6135 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6136 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6137 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6138 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6139 (Fwindow_vscroll): Doc fix.
6140 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6141 argument, since it makes no sense to pass a live window and for
6142 consistency with window-child.
6143
1f05cd82
CS
61442011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6145
6146 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6147 support MSVC.
6148
22610910
JR
61492011-11-05 Jason Rumney <jasonr@gnu.org>
6150
6151 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6152 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6153 fonts (Bug#6029).
6154 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6155 bitwise arithmetic preventing use of unicode-sip and non-truetype
6156 opentype fonts.
6157
a06776b2
EZ
61582011-11-05 Eli Zaretskii <eliz@gnu.org>
6159
3ad924ba
EZ
6160 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6161 "emacs"-only part.
6162
a06776b2
EZ
6163 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6164 initialization code to keep similarity to xfns.c after changes
6165 from 2011-11-05.
6166
c9e7db78
JD
61672011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6168
a97f8f3f
JD
6169 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6170 (unwind_create_frame): New function (Bug#9943).
6171 (Fx_create_frame): Restructure code to be more similar to the one in
6172 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6173 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6174 Move terminal->reference_count++ just before making the frame official
6175 (Bug#9943).
6176
6177 * nsterm.m (x_free_frame_resources): New function.
6178 (x_destroy_window): Move code to x_free_frame_resources.
6179
c9e7db78 6180 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6181 (Fx_create_frame, x_create_tip_frame):
6182 Move terminal->reference_count++ just before making the frame
75f1671a 6183 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6184 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6185
a6fc3b5c
EZ
61862011-11-05 Eli Zaretskii <eliz@gnu.org>
6187
6188 Support MSVC build with newer versions of Visual Studio.
6189 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6190 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6191 nt/gmake.defs.
6192
6193 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6194 which are not supported by MSVC.
6195 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6196 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6197 bitfields.
6198 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6199 types in bitfields.
6200 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6201
6202 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6203
58179cce 62042011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6205
6206 Support MSVC build with newer versions of Visual Studio.
6207 * w32.c: Don't include w32api.h for MSVC.
6208 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6209
6210 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6211 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6212 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6213 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6214 e_* cousins.
6215 (alloca) [_MSC_VER]: Define to _alloca.
6216
6217 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6218
6219 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6220
a58c13ed
EZ
62212011-11-04 Eli Zaretskii <eliz@gnu.org>
6222
6223 * xdisp.c (note_mouse_highlight): If either of
6224 previous/next-single-property-change returns nil, treat that as
6225 the beginning or the end of the buffer. (Bug#9955)
6226
fe0b6370
JD
62272011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6228
a58c13ed 6229 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6230 label is not null (Bug#9951).
6231 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6232 may be NULL.
6233
89bd5ee1
EZ
62342011-11-04 Eli Zaretskii <eliz@gnu.org>
6235
6236 * window.c (Fwindow_body_size): Mention in the doc string that the
6237 return value is in frame's canonical units. (Bug#9949)
6238
84c3edb9
EZ
62392011-11-03 Eli Zaretskii <eliz@gnu.org>
6240
4e2fb5c7
EZ
6241 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6242
84c3edb9 6243 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6244 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6245 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6246
bc17a887
EZ
62472011-11-01 Eli Zaretskii <eliz@gnu.org>
6248
6249 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6250 Don't stop backward scan on the continuation glyph, even though
6251 its CHARPOS is positive.
6d5eb5b0
SM
6252 (mouse_face_from_buffer_pos, note_mouse_highlight):
6253 Rename cover_string to disp_string.
bc17a887 6254
4ee88440
MR
62552011-11-01 Martin Rudalics <rudalics@gmx.at>
6256
6257 * window.c (temp_output_buffer_show): Don't use
6258 Vtemp_buffer_show_specifiers.
6259 (Vtemp_buffer_show_specifiers): Remove unused variable.
6260
c2ff3c02
EZ
62612011-10-30 Eli Zaretskii <eliz@gnu.org>
6262
6263 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6264 past the beginning of the current glyph matrix.
6265
58179cce 62662011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6267
6268 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6269 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6270 HAVE_GTK3 (Bug#9869).
b77a6a7f 6271
3b574623
JD
6272 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6273 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6274
b77a6a7f
JD
6275 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6276
6277 * xterm.c: Declare x_handle_net_wm_state to return int.
6278 (handle_one_xevent): Check if we are iconified but don't have
6279 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6280 (get_current_wm_state): Return non-zero if not hidden,
6281 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6282 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6283 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6284 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6285
196e41e4
PE
62862011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6287
6288 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6289 so that this new function doesn't get optimized away by a
6290 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6291
021f2e1a
AS
62922011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6293
6294 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6295
8b058d44
EZ
62962011-10-29 Eli Zaretskii <eliz@gnu.org>
6297
6298 Fix the `xbytecode' command.
6299 * .gdbinit (xprintbytestr): New command.
b50a28de 6300 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6301 (xbytecode): Print the byte-code string as well.
6302
4452fb80
EZ
63032011-10-29 Kim Storm <storm@cua.dk>
6304
8b058d44
EZ
6305 * alloc.c (which_symbols): New function.
6306
21b72067
AS
63072011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6308
6309 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6310 line. (Bug#9903)
6311
83ed7b5c
GM
63122011-10-29 Glenn Morris <rgm@gnu.org>
6313
6314 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6315 Not clear what it was for, and it causes various bugs. (Bug#9839)
6316
5a7a728b
EZ
63172011-10-28 Eli Zaretskii <eliz@gnu.org>
6318
6319 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6320 possible random value that matches one of those tested as
6321 condition to clear the mouse face.
6322
d3d0842f
CY
63232011-10-28 Chong Yidong <cyd@gnu.org>
6324
6325 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6326
31b39d13
DN
63272011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6328
6329 * window.c (make_window): Initialize phys_cursor_on_p.
6330
9aba6043
SM
63312011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6332
6333 * lisp.h (struct Lisp_Symbol): Update comments.
6334
c20992f4
JB
63352011-10-28 Juanma Barranquero <lekktu@gmail.com>
6336
6337 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6338
db4f02f2
EZ
63392011-10-28 Eli Zaretskii <eliz@gnu.org>
6340
6341 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6342 <oslsachem@gmail.com> for helping to debug this.
6343
6344 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6345 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6346 (g_b_init_get_glyph_outline_w): New static variables.
6347 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6348 (GetGlyphOutlineW_Proc): New typedefs.
6349 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6350 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6351 New functions.
6352 (w32font_open_internal, compute_metrics):
6353 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6354 instead of calling the "wide" APIs directly.
6355
6356 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6357
6358 * w32.h (syms_of_w32font): Add prototype.
6359
87e68db4
JB
63602011-10-27 Juanma Barranquero <lekktu@gmail.com>
6361
6362 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6363 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6364 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6365 (Fmove_to_window_line): Doc fix.
6366
435c1d67
CY
63672011-10-27 Chong Yidong <cyd@gnu.org>
6368
6369 * process.c (make_process): Set gnutls_state to NULL.
6370
6371 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6372 non-NULL, regardless of GNUTLS_INITSTAGE.
6373 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6374 an error. Set process slots as soon as we allocate them.
6375
6376 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6377
9c6c6f49
CY
63782011-10-27 Chong Yidong <cyd@gnu.org>
6379
9aba6043
SM
6380 * gnutls.c (emacs_gnutls_deinit): New function.
6381 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6382 (Fgnutls_deinit, Fgnutls_boot): Use it.
6383
6384 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6385 (deactivate_process): Call emacs_gnutls_deinit.
6386
657d08d3
JB
63872011-10-27 Juanma Barranquero <lekktu@gmail.com>
6388
6389 * image.c (x_create_x_image_and_pixmap):
6390 * w32.c (sys_rename, w32_delayed_load):
6391 * w32font.c (fill_in_logfont):
6392 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6393
5430d399
JB
63942011-10-26 Juanma Barranquero <lekktu@gmail.com>
6395
6396 * w32fns.c (w32_default_color_map): New function,
6397 extracted from Fw32_default_color_map.
a7ef684b 6398 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6399
fe0055fa
PE
64002011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6401
6402 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6403
e6346438
SM
64042011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6405
6406 * keyboard.c (test_undefined): New function (bug#9751).
6407 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6408
e112cc37
ET
64092011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6410
6411 * sysdep.c (init_sys_modes): Fix the check for the controlling
6412 terminal (Bug#6649).
6413
7b5d6677
EZ
64142011-10-20 Eli Zaretskii <eliz@gnu.org>
6415
6416 * dispextern.h (struct bidi_it): New member next_en_type.
6417
6418 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6419 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6420 current character, check also for next_en_type being WEAK_EN.
6421 (bidi_resolve_weak): Don't enter the expensive loop if the current
6422 position is before next_en_pos. Record the bidi type of the first
6423 non-ET, non-BN character we find, in addition to its position.
6424 (bidi_level_of_next_char): Invalidate next_en_type when
6425 next_en_pos is over-stepped.
6426
7da0b018
PE
64272011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6428
6429 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6430 * editfns.c: Rewrite current-time-zone so that it invokes
6431 the equivalent of (format-time-string "%Z") to get the time zone name.
6432 This fixes a bug when the time zone name contains characters that
6433 need converting from the system time locale to Emacs internal format.
6434 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6435 that patch fixed format-time-string to do the conversion, but
6436 I forgot to fix current-time-zone.
6437 (format_time_string): New function, containing most of
6438 what Fformat_time_string used to contain.
6439 (Fformat_time_string): Rewrite in terms of format_time_string.
6440 This doesn't change this function's behavior.
6441 (current-time-zone): Rewrite to use format_time_string.
6442 This fixes the bug reported by Michael Schierl in
6443 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6444 Jason Rumney's 2007-06-07 change worked around this bug, but
6445 didn't fix it.
6446 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6447
8547b010
EZ
64482011-10-19 Eli Zaretskii <eliz@gnu.org>
6449
6450 * xdisp.c (start_display): If the character at POS is displayed
6451 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6452 (try_window_reusing_current_matrix): If a line ends in a display
6453 vector or the next line starts in a display vector, continue
6454 redrawing the window even though the character position of
6455 start_row was reached.
8547b010
EZ
6456 (Bug#9771, part 2)
6457
4e948d15
CY
64582011-10-18 Chong Yidong <cyd@gnu.org>
6459
6460 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6461 with nobreak-char-display too.
6462
4787455f
EZ
64632011-10-18 Eli Zaretskii <eliz@gnu.org>
6464
6465 Fix part 3 of bug#9771.
6466 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6467 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6468 non-neutral characters if the current character is a paragraph
6469 separator (a.k.a. Newline). This avoids running the same
6470 expensive loop twice, once when we consume the preceding newline
6471 and the other time when the line actually needs to be displayed.
6472 Avoid the loop when we see neutrals on the base embedding level
6473 following a character whose directionality is the same as the
6474 paragraph's. This avoids running the expensive loop when a line
6475 ends in a long sequence of neutrals, like control characters.
6476 Add assertion against STRONG_AL type. Slightly rearrange code
6477 that determines the type of a neutral given the first non-neutral
6478 that follows it.
6479 (bidi_level_of_next_char): Set next_en_pos to zero when
6480 invalidating its info.
6481
2c91f553
EZ
64822011-10-17 Eli Zaretskii <eliz@gnu.org>
6483
6484 * xdisp.c (push_display_prop): Determine whether to record string
6485 or buffer position by IT->string, not by IT->method. Allow
6486 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6487 (move_it_vertically_backward): Don't look for character position
6488 immediately after the newline when in a continuation line.
6489 (Bug#9771, part 1)
2c91f553 6490
c7b08b0d
MR
64912011-10-15 Martin Rudalics <rudalics@gmx.at>
6492
6493 * window.c (coordinates_in_window): Rewrite and delabelize
6494 vertical border check. (Bug#5357) (Bug#9618)
6495
6b02f655
SM
64962011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6497
6498 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6499 errors in XSetWindowBorder (bug#9310).
6500
81d40c92
DA
65012011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6502
6503 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6504 avoid crash when xmalloc overrun checking is enabled.
6505
d4172c3b
EZ
65062011-10-13 Eli Zaretskii <eliz@gnu.org>
6507
6508 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6509 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6510 cursor motion with <left> and <right> arrow keys.
6511
6512 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6513 some callers set that themselves.
6514
b00eea75
EZ
65152011-10-12 Eli Zaretskii <eliz@gnu.org>
6516
6517 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6518 display string and the previous row comes from the same string and
6519 is empty. (Bug#9739) (Bug#9738)
6520
8fe012c4
SM
65212011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6522
6523 * doc.c (get_doc_string): Encode file name (bug#9735).
6524
0074aef2
EZ
65252011-10-12 Eli Zaretskii <eliz@gnu.org>
6526
79beb178
EZ
6527 * bidi.c (bidi_level_of_next_char):
6528 * xdisp.c (get_visually_first_element): Remove old incorrect
6529 comments regarding the Unicode Line Separator character.
6530
0074aef2
EZ
6531 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6532
6e4b3fbe
DA
65332011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6534
6535 * alloc.c (Fgc_status): Do not access beyond zombies array
6536 boundary if nzombies > MAX_ZOMBIES.
6537 * alloc.c (dump_zombies): Add missing format specifier.
6538
0324f3af
PE
65392011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6540
b5525cac
PE
6541 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6542 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6543
0324f3af
PE
6544 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6545 Some packages use them to denote characters with modifiers.
6546
e9b5f888
AS
65472011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6548
6549 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6550 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6551 matching a pp-number. Rename parameter var to var1.
6552
127827c0
SM
65532011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6554
6555 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6556
c8fd3bd0
GM
65572011-10-08 Glenn Morris <rgm@gnu.org>
6558
6559 * callint.c (Fcall_interactively): Give a more explicit error for the
6560 'c' case with a non-character input. (Bug#8479)
6561
352ec8ff
EZ
65622011-10-08 Eli Zaretskii <eliz@gnu.org>
6563
03669ccb
EZ
6564 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6565 lines.
7061c986
EZ
6566 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6567 lines that are hscrolled on the left.
03669ccb 6568
352ec8ff
EZ
6569 * dispnew.c (buffer_posn_from_coords): Account for a possible
6570 presence of header-line. (Bug#4426)
6571
a66cfb1c
SM
65722011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6573
6b02f655
SM
6574 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6575 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6576
7c5ee88e
PE
65772011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6578
6579 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6580 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6581 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6582 this makes Emacs dump core during garbage collection on rare
6583 occasions. sizeof is obviously inferior to offsetof here, so
6584 stick with offsetof.
6585 (GC_POINTER_ALIGNMENT): New macro.
6586 (mark_memory): Omit 3rd (offset) arg; caller changed.
6587 Don't assume EMACS_INT alignment is the same as pointer alignment.
6588
df1bbe5b
SM
65892011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6590
6591 * keyboard.c (read_key_sequence_remapped): New var.
6592 (read_key_sequence): Compute remapping in the right buffer.
6593 (command_loop_1): Use read_key_sequence's remapping directly.
6594
51553db6
SM
65952011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6596
32c1fffd
SM
6597 * dired.c (file_name_completion): Don't expand file name.
6598 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6599 before checking file name handler.
6600
51553db6
SM
6601 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6602 they've been requested explicitly (bug#9591).
6603
b6bd1599 66042011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6605
6606 * keymap.c (Fsingle_key_description): Use make_specified_string
6607 instead of build_string to build string from push_key_description.
6608 (Bug#5193)
6609
f701dc2a
PE
66102011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6611
4222c55d
PE
6612 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6613 This fixes a Y2038 bug on 64-bit hosts.
6614 * buffer.c (reset_buffer):
6615 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6616 (Fclear_buffer_auto_save_failure):
6617 Use 0, not -1, to represent an unset failure time, since time_t
6618 might not be signed.
6619
f701dc2a
PE
6620 Remove dependency on glibc malloc internals.
6621 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6622 Move back here from lisp.h, but with their new implementations.
6623 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6624 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6625 * charset.c (charset_table_init): New static var.
6626 (syms_of_charset): Use it instead of xmalloc. This removes a
6627 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6628 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6629 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6630 Move back to alloc.c.
6631 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6632 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6633
9ceebf39
JD
66342011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6635
6636 * nsterm.m (windowDidResize): Call x_set_window_size only when
6637 ns_in_resize is true. Otherwise set pixelwidth/height and
6638 call change_frame_size (Bug#9628).
6639
cb993c58
PE
66402011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6641
3930c88b
PE
6642 Port --enable-checking=all to Fedora 14 x86-64.
6643 * charset.c (syms_of_charset): Also account for glibc malloc's
6644 internal overhead when calculating the initial malloc maximum.
6645
cb993c58
PE
6646 Port --enable-checking=all to Fedora 14 x86.
6647 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6648 Move to lisp.h.
6649 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6650 (overrun_check_realloc, overrun_check_free):
6651 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6652 That way, xmalloc returns a properly-aligned pointer even if
6653 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6654 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6655 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6656 into account when calculating the initial malloc maximum.
6657 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6658 Move here from alloc.c, so that charset.c can use it too.
6659 Properly align; the old code wasn't right for common 32-bit hosts
6660 when configured with --enable-checking=all.
6661 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6662 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6663
31bed486
EZ
66642011-09-29 Eli Zaretskii <eliz@gnu.org>
6665
04c70788 6666 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6667 use EDOM.
6668
fbcaa2f3
EZ
66692011-09-28 Eli Zaretskii <eliz@gnu.org>
6670
6671 * xdisp.c (compute_display_string_end): If there's no display
6672 string at CHARPOS, return -1.
6673
6674 * bidi.c (bidi_fetch_char): When compute_display_string_end
6675 returns a negative value, treat the character as a normal
6676 character not covered by a display string. (Bug#9624)
6677
a239d4e9
JB
66782011-09-28 Juanma Barranquero <lekktu@gmail.com>
6679
6680 * lread.c (Fread_from_string): Fix typo in docstring.
6681
88652fd5
EZ
66822011-09-27 Eli Zaretskii <eliz@gnu.org>
6683
6684 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6685 newline, reseat the iterator instead of bidi-iterating there one
6686 character at a time. (Bug#9610)
32c1fffd
SM
6687 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6688 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6689
ed497dd4
AS
66902011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6691
6692 * lread.c (readevalloop): Use correct code for NBSP.
6693 (read1): Likewise. (Bug#9608)
6694
b2bf61aa
MA
66952011-09-25 Michael Albinus <michael.albinus@gmx.de>
6696
6697 * dbusbind.c (Fdbus_register_signal): When service is not
6698 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6699
32bbb17c
GM
67002011-09-25 Glenn Morris <rgm@gnu.org>
6701
6702 * buffer.c (truncate-lines): Doc fix.
6703
94e0933e
CY
67042011-09-24 Chong Yidong <cyd@stupidchicken.com>
6705
6706 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6707 (Fset_window_next_buffers): Doc fix.
6708
cddde921
GM
67092011-09-24 Glenn Morris <rgm@gnu.org>
6710
6711 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6712
1260aef1
PE
67132011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6714
25b4bfa0
PE
6715 Fix minor problems found by static checking.
6716 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6717 * indent.c (Fvertical_motion): Fix == vs = typo.
6718
e3cbd34b
EZ
67192011-09-24 Eli Zaretskii <eliz@gnu.org>
6720
a66cfb1c
SM
6721 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6722 Default value is now t. Doc fix.
6bf7006f 6723
e3cbd34b 6724 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6725 logic when moving up, not only when moving down. Fix the
e3cbd34b 6726 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6727 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6728
6729 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6730 CHARPOS is covered by a display string which includes newlines.
6731 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6732 is covered by a display string with embedded newlines.
6733
a3de0cbd
MA
67342011-09-24 Michael Albinus <michael.albinus@gmx.de>
6735
6736 * dbusbind.c (Fdbus_register_signal): Add match rule to
6737 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6738 (Fdbus_register_method, Vdbus_registered_objects_table):
6739 Fix docstring.
a3de0cbd 6740
b260039d
JM
67412011-09-24 Jim Meyering <meyering@redhat.com>
6742
32c1fffd 6743 do not ignore write error for any output size
b260039d
JM
6744 The previous change was incomplete.
6745 While it makes emacs --batch detect the vast majority of stdout
6746 write failures, errors were still ignored whenever the output size is
6747 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6748 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6749 && echo FAIL: ignored write error
6750 FAIL: ignored write error
6751 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6752 && echo FAIL: ignored write error
6753 FAIL: ignored write error
6754 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6755
8eca8a7c
AS
67562011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6757
6758 * emacs.c (Fkill_emacs): In noninteractive mode exit
6759 non-successfully if a write error occurred on stdout. (Bug#9574)
6760
3341db62
EZ
67612011-09-21 Eli Zaretskii <eliz@gnu.org>
6762
6763 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6764 the xassert test.
6765
6766 * dispextern.h (struct it): Update the comment documenting what
6767 can it->OBJECT be.
6768
8c203dbf
EZ
67692011-09-20 Eli Zaretskii <eliz@gnu.org>
6770
6771 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6772 a display string, extend search for cursor position to end of row.
6773 (find_row_edges): If the row ends in a newline from a display
6774 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6775 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6776 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6777 non-empty line. Fixes confusing cursor motion with arrow keys at
6778 the beginning of a line that starts with whitespace.
8c203dbf 6779
a4824228
LMI
67802011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6781
6782 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6783 (bug#9493).
6784
33ed493b
CY
67852011-09-18 Chong Yidong <cyd@stupidchicken.com>
6786
6787 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6788 boolean (Bug#9154).
6789
56cd55c8
EZ
67902011-09-18 Eli Zaretskii <eliz@gnu.org>
6791
6792 * xdisp.c (display_line): Record maximum and minimum buffer
6793 positions even if no glyphs were produced (e.g., by a zero-width
6794 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6795 buffer positions that will be removed from the glyph row because
6796 they don't fit.
c02dcedf
EZ
6797 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6798 column is beyond frame width: don't subtract 1 "pixel" when
6799 computing width of the stretch.
3e62b7e0
EZ
6800 (reseat_at_next_visible_line_start): Undo the change made on
6801 2011-09-17 that saved paragraph information and restored it after
6802 the call to `reseat'. (Bug#9545)
56cd55c8 6803
5ed99d36 68042011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6805
6806 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6807 and turn window cursor on if cleared (Bug#9415).
6808
5ed99d36 68092011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6810
6811 * search.c (boyer_moore): Take unibyte characters from pattern
6812 literally. (Bug#9458)
6813
9bade7b2
EZ
68142011-09-18 Eli Zaretskii <eliz@gnu.org>
6815
6816 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6817
e5e9d610
PE
68182011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6819
87e4427a
PE
6820 Fix minor problem found by static checking.
6821 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6822 initialized, to pacify gcc -Wuninitialized.
6823
e5e9d610
PE
6824 * fileio.c: Report proper errno when syscall falls.
6825 (Finsert_file_contents): Save and restore errno,
6826 so that report_file_error outputs the correct diagnostic.
6827 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6828
a1674f0b
EZ
68292011-09-18 Eli Zaretskii <eliz@gnu.org>
6830
6831 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6832
fbfb6dd4
EZ
68332011-09-17 Eli Zaretskii <eliz@gnu.org>
6834
6835 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6836 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6837
bb187662
EZ
68382011-09-17 Eli Zaretskii <eliz@gnu.org>
6839
1137e8b8 6840 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6841 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6842
6843 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6844 (bidi_find_paragraph_start): Search back for paragraph beginning
6845 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6846 (bidi_move_to_visually_next): Only trigger paragraph-related
6847 computations when the last character is a newline or at EOB, not
6848 just any NEUTRAL_B. (Bug#9470)
6849
bb187662
EZ
6850 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6851 truncated lines if point is covered by a display string. (Bug#9524)
6852
2e621251
PE
68532011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6854
6855 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6856 (cons_to_x_long): New function.
6857 (lisp_data_to_selection_data): Use it. Correct the test for
6858 short-versus-long data; it was negated. Break out of vector
6859 loop, for efficiency, when a long datum is discovered.
6860
91a15bc6
SM
68612011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6862
6863 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6864
b41c3a35
EZ
68652011-09-16 Eli Zaretskii <eliz@gnu.org>
6866
6867 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6868 GCC PR/17406) by declaring this function with external scope.
6869
7812ba2d
PE
68702011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6871
6872 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6873 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6874
cf7edc2a
AS
68752011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6876
6877 * editfns.c (Fformat): Correctly handle text properties on "%%".
6878
bd01620e
EZ
68792011-09-15 Eli Zaretskii <eliz@gnu.org>
6880
6881 * xterm.c (x_draw_composite_glyph_string_foreground):
6882 * w32term.c (x_draw_composite_glyph_string_foreground):
6883 * term.c (encode_terminal_code):
6884 * composite.c (composition_update_it, get_composition_id):
6885 * xdisp.c (get_next_display_element)
6886 (fill_composite_glyph_string): Add comments about special meaning
6887 of TAB characters in a composition.
6888
a02719a3
PE
68892011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6890
6891 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6892 This occurs when processing a multibyte format.
6893 Problem reported by Wolfgang Jenker.
a02719a3 6894
72589a3c
JB
68952011-09-15 Johan Bockgård <bojohan@gnu.org>
6896
6897 * xdisp.c (try_cursor_movement): Only check for exact match if
6898 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6899
1c14176c
PE
69002011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6901
6902 Remove unused external symbols.
6903 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6904 * xdisp.c (calc_pixel_width_or_height): Now static.
6905 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6906 * indent.c (check_display_width):
6907 * w32term.c: Fix comment to match code.
6908 * xterm.c, xterm.h (x_catching_errors): Remove.
6909
d2eea5b5
PE
69102011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6911
6912 * xselect.c: Use signed conversions more consistently (Bug#9498).
6913 (selection_data_to_lisp_data): Assume incoming selection data are
6914 signed integers, not unsigned. This is to be consistent with
6915 outgoing selection data, which was modified to use signed integers
6916 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6917 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6918 expects long, not unsigned long.
6919
46888499
EZ
69202011-09-14 Eli Zaretskii <eliz@gnu.org>
6921
6922 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6923 computation of loop end. Reported by Johan Bockgård
6924 <bojohan@gnu.org>.
6925
ef8ef9fb
CY
69262011-09-13 Chong Yidong <cyd@stupidchicken.com>
6927
6928 * frame.c (Fother_visible_frames_p): Function deleted.
6929
fa819fed
EZ
69302011-09-12 Eli Zaretskii <eliz@gnu.org>
6931
6932 * indent.c (compute_motion): Process display vector front to back
6933 rather than the other way around. (Bug#2496)
6934
2ba8e008
SM
69352011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6936
6937 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6938
20f53c69
CY
69392011-09-11 Chong Yidong <cyd@stupidchicken.com>
6940
6941 * minibuf.c (Fread_from_minibuffer): Doc fix.
6942
d562d7a4
EZ
69432011-09-11 Eli Zaretskii <eliz@gnu.org>
6944
6945 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6946 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6947
1c4d7f3d
LMI
69482011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6949
6950 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6951 value for non-existent files.
6952
b885bf36
EZ
69532011-09-11 Eli Zaretskii <eliz@gnu.org>
6954
6955 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6956 set its "size" to -1. This will set the modtime_size field of
6957 the corresponding buffer to -1, which is what
6958 verify-visited-file-modtime expects for files that do not exist.
6959 (Bug#9139)
6960
6612f0bf
PE
69612011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6962
6963 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6964 here ...
6965 * lisp.h: ... from here. push_key_description is no longer
6966 defined in keyboard.c, so its declaration should not be in
6967 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6968 logically belongs with push_key_description.
6969
dfb3f755
PE
69702011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6971
6972 * buffer.h: Include <sys/types.h> instead of <time.h>.
6973 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6974 Problem reported by Herbert J. Skuhra.
6975
3134906c
LMI
69762011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6977
6978 * xml.c (parse_region): Make the parsing work for
6979 non-comment-starting XML files again (bug#9144).
6980
8d903f4e
AS
69812011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6982
6983 * image.c (gif_load): Fix calculation of bottom and right corner.
6984 (Bug#9468)
6985
80ad64f4
EZ
69862011-09-10 Eli Zaretskii <eliz@gnu.org>
6987
6988 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6989 redisplay in small windows.
6990
208a048d
EZ
69912011-09-09 Eli Zaretskii <eliz@gnu.org>
6992
6993 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6994
9b1c252e
MR
69952011-09-08 Martin Rudalics <rudalics@gmx.at>
6996
6997 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6998 Operate on live windows only.
6999
2949f33b
JB
70002011-09-08 Juanma Barranquero <lekktu@gmail.com>
7001
7002 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7003
e08dcafd
EZ
70042011-09-07 Eli Zaretskii <eliz@gnu.org>
7005
7006 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7007 only under bidi iteration.
7008
115b96bd
JD
70092011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7010
7011 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7012
c8199d0f
PE
70132011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7014
7015 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7016 Without this fix, the command to link temacs failed due to an
7017 undefined symbol __builtin_isnan. This is because
7018 /usr/include/iso/math_c99.h #defines isnan(x) to
7019 __builtin_isnan(x), but the bundled gcc, which identifies itself
7020 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7021 a __builtin_isnan.
7022 * floatfns.c (isnan): #undef, and then #define to a clone of
7023 what's in data.c.
7024 (Fisnan): Always define, since it's always available now.
7025 (syms_of_floatfns): Always define isnan at the Lisp level.
7026
e39b275c 70272011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7028
7029 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7030
b2db44d9 70312011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7032
f4af5137 7033 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7034 The previous code assumed that file offsets (off_t values) fit in
7035 EMACS_INT variables, which is not true on typical 32-bit hosts.
7036 The code messed up by falsely reporting buffer overflow in cases
7037 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7038 when "big" contains more than 2**29 bytes, even though this
7039 inserts just one byte and does not overflow the buffer.
7040 (Finsert_file_contents): Store file offsets as off_t
7041 values, not as EMACS_INT values. Check for overflow when
7042 converting between EMACS_INT and off_t. When checking for
7043 buffer overflow or for overlap, take the offsets into account.
7044 Don't use EMACS_INT for small values where int suffices.
7045 When checking for overlap, fix a typo: ZV was used where
7046 ZV_BYTE was intended.
7047 (Fwrite_region): Don't assume off_t fits into 'long'.
7048 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7049
ecfc0a49
MA
70502011-09-05 Michael Albinus <michael.albinus@gmx.de>
7051
7052 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7053
6511acf2 70542011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7055
0999621a 7056 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7057
7058 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7059 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7060 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7061 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7062 (modify_event_symbol): Do not assume that the length of
7063 name_alist_or_stem is safe to alloca and fits in int.
7064 (Fexecute_extended_command): Likewise for function name and binding.
7065 (Frecursion_depth): Wrap around reliably on integer overflow.
7066 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7067 since some callers pass EMACS_INT values.
7068 (Fsingle_key_description): Don't crash if symbol name contains more
7069 than MAX_ALLOCA bytes.
7070 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7071 (get_minibuffer): Arg is now EMACS_INT, not int.
7072 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7073 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7074 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7075
2be7d702
PE
7076 * dbusbind.c (signature_cat): New function.
7077 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7078 Do not overrun buffer; instead, report string overflow.
7079
9d1df220
PE
7080 * dispnew.c (add_window_display_history): Don't overrun buffer.
7081 Truncate instead; this is OK since it's just a log.
7082
33ef5c64
PE
7083 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7084 even if the time zone offset is outlandishly large.
7085 Don't mishandle offset == INT_MIN.
7086
66c6fdd5
PE
7087 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7088 when creating daemon; the previous buffer-overflow check was incorrect.
7089
d749b01b
PE
7090 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7091 which has the guts of the old verror function.
7092
b5cd1905
PE
7093 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7094 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7095
6e1a67fb
PE
7096 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7097 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7098 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7099 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7100 length of string rather than counting it via multiple sprintfs;
7101 that's simpler and more reliable.
c21721cc
PE
7102 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7103 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7104 sprintf, in case result does not fit in int.
7105
c57b67fc
PE
7106 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7107 (fontset_from_font): Print it.
7108
8a401434
PE
7109 * frame.c (tty_frame_count): Now printmax_t, not int.
7110 (make_terminal_frame, set_term_frame_name): Print it.
7111 (x_report_frame_params): In X, window IDs are unsigned long,
7112 not signed long, so print them as unsigned.
7113 (validate_x_resource_name): Check for implausibly long names,
7114 and don't assume name length fits in 'int'.
7115 (x_get_resource_string): Don't blindly alloca invocation name;
7116 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7117 not fit in int.
7118
6e1a67fb
PE
7119 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7120 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7121 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7122
0df02bf3
PE
7123 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7124 Use esprintf, not sprintf, in case result does not fit in int.
7125
48e30793
PE
7126 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7127 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7128 it as a large positive number.
7129 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7130 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7131
a66ff6d8
PE
7132 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7133 in case result does not fit in int.
7134
aca216ff
PE
7135 * print.c (float_to_string): Detect width overflow more reliably.
7136 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7137 buffer overrun. Don't assume list length fits in 'int'. Treat
7138 print length of 0 as 0, not as infinity; to be consistent with other
7139 uses of print length in this function. Don't overflow print length
7140 index. Don't assume hash table size fits in 'long', or that
7141 vectorlike size fits in 'unsigned long'.
7142
31c286f7
PE
7143 * process.c (make_process): Use printmax_t, not int, to format
7144 process-name gensyms.
7145
55e5faa1
PE
7146 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7147
80f2e268
PE
7148 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7149 to avoid potential buffer overrun.
7150
670741ab
PE
7151 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7152 if X resource line is longer than 512 bytes.
7153
b7163a50
PE
7154 * xfns.c (x_window): Make sprintf buffer a bit bigger
7155 to avoid potential buffer overrun.
7156
ae58ff1f
PE
7157 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7158
c43c8a6a
PE
7159 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7160
3f8236f4
PE
71612011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7162
53e9fe90 7163 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7164 Without these, Emacs silently mishandles large integers sometimes.
7165 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7166 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7167
6511acf2
PE
7168 * xdisp.c (try_window_id): Check Emacs fixnum range before
7169 converting to 'int'.
806add1d 7170
6511acf2 7171 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7172 Check that an Emacs fixnum is in range before assigning it to 'int'.
7173 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7174 values converted from Emacs fixnums.
7175 (Frecenter): Don't wrap around a line count if it is out of 'int'
7176 range; instead, treat it as an extreme value.
7177 (Fset_window_configuration, compare_window_configurations):
7178 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7179
6511acf2
PE
7180 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7181 that can exceed INT_MAX. Check that EMACS_INT value is in range
7182 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7183 (match_limit): Don't assume that a fixnum can fit in 'int'.
7184
6511acf2 7185 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7186 exceed INT_MAX.
7187
6511acf2 7188 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7189 (Fvertical_motion): Don't wrap around LINES values that don't fit
7190 in 'int'. Instead, treat them as extreme values. This is good
7191 enough for windows, which can't have more than INT_MAX lines anyway.
7192
fcb901a7
LMI
71932011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7194
0f2f6b6d
LMI
7195 * Require libxml/parser.h to avoid compilation warning.
7196
fcb901a7
LMI
7197 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7198
7199 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7200 since this reportedly can destroy thread storage.
7201
6e20a0d4
CY
72022011-08-30 Chong Yidong <cyd@stupidchicken.com>
7203
7204 * syntax.c (find_defun_start): Update all cache variables if
7205 exiting early (Bug#9401).
7206
148ae00e
EZ
72072011-08-30 Eli Zaretskii <eliz@gnu.org>
7208
f6cfbd8f
EZ
7209 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7210
148ae00e
EZ
7211 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7212 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7213 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7214
7215 * term.c (tty_append_glyph): New function.
7216 (produce_stretch_glyph): Static function and its prototype deleted.
7217
a66cfb1c
SM
7218 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7219 Add prototypes.
148ae00e 7220
c4a07a4c
PE
72212011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7222
7223 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7224 when checking :margin (Bug#9390).
7225 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7226 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7227 so that the name doesn't mislead. All uses changed.
7228
6bc8cd65
JB
72292011-08-28 Johan Bockgård <bojohan@gnu.org>
7230
7231 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7232 set_tty_hooks.
7233
dca4927e
EZ
72342011-08-27 Eli Zaretskii <eliz@gnu.org>
7235
7236 * xdisp.c (move_it_to): Don't bail out early when reaching
7237 position beyond to_charpos, if we are scanning backwards.
7238 (move_it_vertically_backward): When DY == 0, make sure we get to
7239 the first character in the line after the newline.
7240
f2cad773
PE
72412011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7242
7243 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7244 (ccl_driver): Do not generate an out-of-range pointer.
7245 (Fccl_execute_on_string): Remove unnecessary check for
7246 integer overflow, noted by Stefan Monnier in
7247 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7248 Remove a FIXME that didn't need fixing.
7249 Simplify the newly-introduced buffer reallocation code.
7250
0cae2cdb
JB
72512011-08-27 Juanma Barranquero <lekktu@gmail.com>
7252
7253 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7254
5fc295a4 72552011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7256
70c60eb2 7257 Integer and memory overflow issues (Bug#9196).
726e0ab1 7258
d31850da
PE
7259 * doc.c (get_doc_string): Rework so that
7260 get_doc_string_buffer_size is the actual buffer size, rather than
7261 being 1 less than the actual buffer size; this makes xpalloc more
7262 convenient.
7263
a69fbedb
PE
7264 * image.c (x_allocate_bitmap_record, cache_image):
7265 * xselect.c (Fx_register_dnd_atom):
7266 Simplify previous changes by using xpalloc.
7267
fe5c5d37
PE
7268 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7269 since either will do and ptrdiff_t is convenient with xpalloc.
7270
0065d054
PE
7271 * charset.c (charset_table_size)
7272 (struct charset_sort_data.priority): Now ptrdiff_t.
7273 (charset_compare): Don't overflow if priorities differ greatly.
7274 (Fsort_charsets): Don't assume list length fits in int.
7275 Check for size-calculation overflow when allocating sort data.
7276 (syms_of_charset): Allocate an initial charset table that is
7277 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7278
7279 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7280
7281 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7282 The actual value is always <= INT_MAX, and leaving it unsigned made
7283 overflow checking harder.
7284
7285 * dispextern.h (struct glyph_matrix.rows_allocated)
7286 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7287 with xpalloc. The values are still always <= INT_MAX.
7288
7289 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7290
7291 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7292 (SAFE_NALLOCA): New macro.
7293
7294 * region-cache.c (struct boundary.pos, find_cache_boundary)
7295 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7296 (set_cache_region, invalidate_region_cache)
7297 (revalidate_region_cache, know_region_cache, region_cache_forward)
7298 (region_cache_backward, pp_cache):
7299 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7300 so that ptrdiff_t * can be passed to xpalloc.
7301 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7302 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7303 (pp_cache): Don't assume cache_len fits in int.
7304 * region-cache.h: Adjust extern decls to match.
7305
7306 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7307 EMACS_INT, since either will do, for xpalloc.
7308
7309 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7310 (xnmalloc, xnrealloc, xpalloc): New functions.
7311
726e0ab1
PE
7312 * bidi.c (bidi_shelve_header_size): New constant.
7313 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7314 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7315
51f30bc5 7316 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7317 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7318 (overlay_strings):
7319 Don't update size of array until after memory allocation succeeds,
7320 because xmalloc/xrealloc may not return.
0065d054
PE
7321 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7322 now that we have proper integer overflow checking.
7323 (record_overlay_string, overlay_strings): Catch overflows when
7324 calculating size of overlay_str_buf.
726e0ab1 7325
0065d054
PE
7326 * callproc.c (Fcall_process): Check for size overflow when
7327 calculating size of args2.
7328 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7329 Normally we prefer signed values, but sticking with ptrdiff_t would
7330 require adding more-complicated checks.
726e0ab1
PE
7331
7332 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7333 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7334 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7335 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7336
7337 * character.c (Fstring): Check for size-calculation overflow.
7338
7339 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7340 unnecessary integer overflow. Check for size overflow.
7341 (encode_coding_object): Don't update size until xmalloc succeeds.
7342
7343 * composite.c (get_composition_id): Check for overflow in glyph
7344 length calculations.
7345
7346 Integer and memory overflow fixes for display code.
7347 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7348 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7349 (scrolling_window): Check for overflow in size calculations.
7350 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7351 Don't assume glyph table len fits in int.
7352 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7353 (row_table_size): Now ptrdiff_t, not int.
7354 (scrolling_window): Avoid overflow in size calculations.
7355 Don't update size until allocation succeeds.
7356 * fns.c (concat): Check for overflow in size calculations.
7357 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7358 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7359 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7360
7361 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7362 (get_doc_string): Check for size calculation overflow.
7363 Don't update size until allocation succeeds.
7364 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7365 EMACS_INT, where ptrdiff_t will do.
7366 (Fsubstitute_command_keys): Check for string overflow.
7367
7368 * editfns.c (set_time_zone_rule): Don't assume environment length
7369 fits in int.
7370 (message_length): Now ptrdiff_t, not int.
7371 (Fmessage_box): Don't update size until allocation succeeds.
7372 Don't assume message length fits in int.
7373 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7374
0065d054
PE
7375 * emacs.c (main): Do not reallocate argv, since there is a null at
7376 the end that can be overwritten, and this way there's no need to
7377 worry about size-calculation overflow.
7378 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7379
7380 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7381 alloc succeeds.
7382 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7383
7384 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7385 (x_set_scroll_bar_width, x_figure_window_size):
7386 Check for integer overflow.
7387 (x_set_alpha): Do not assume XINT fits in int.
7388
7389 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7390 This is for the members text_lines, text_cols, total_lines, total_cols,
7391 where the system imposes an 'int' limit.
7392
7393 * fringe.c (Fdefine_fringe_bitmap):
7394 Don't update size until alloc works.
7395
7396 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7397 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7398
7399 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7400 Check for size-calculation overflow.
7401 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7402 do, as we prefer signed integers.
7403 (id_to_widget.max_size, id_to_widget.used)
7404 (xg_store_widget_in_map, xg_remove_widget_from_map)
7405 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7406 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7407 Use and return ptrdiff_t, not int.
7408 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7409 * gtkutil.h: Change prototypes to match the above.
7410
7411 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7412 are duplicate now that they've been promoted to lisp.h.
7413 (x_allocate_bitmap_record, x_alloc_image_color)
7414 (make_image_cache, cache_image, xpm_load):
7415 Don't update size until alloc is done.
7416 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7417 (x_detect_edges):
3256efce 7418 Check for size calculation overflow.
726e0ab1
PE
7419 (ct_colors_allocated_max): New constant.
7420 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7421 overflow.
3256efce 7422
726e0ab1
PE
7423 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7424 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7425 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7426 Use ptrdiff_t, not int, to count maps.
7427 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7428 calculations. Don't update size until allocation succeeds.
7429 Redo calculations to avoid overflow.
726e0ab1
PE
7430 * keyboard.h: Change prototypes to match the above.
7431
7432 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7433 to count maps.
7434 (current_minor_maps): Check for size calculation overflow.
7435 * keymap.h: Change prototypes to match the above.
7436
7437 * lread.c (read1, init_obarray): Don't update size until alloc done.
7438
7439 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7440 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7441
726e0ab1
PE
7442 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7443 Now ptrdiff_t, not int.
7444 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7445 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7446
7447 * process.c (Fnetwork_interface_list): Check for overflow
7448 in size calculation.
7449
7450 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7451
7452 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7453 overflow. Don't bother calling xmalloc when xrealloc will do.
7454
7455 * search.c (Freplace_match): Check for size calculation overflow.
7456 (Fset_match_data): Don't assume list lengths fit in 'int'.
7457
7458 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7459 for command line length. Do not attempt to address one before the
7460 beginning of an array, as that's not portable.
7461
7462 * term.c (max_frame_lines): Remove; unused.
7463 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7464 not int.
7465 (encode_terminal_code, calculate_costs): Check for size
7466 calculation overflow.
7467 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7468 table lengths and related sizes. Don't update size until alloc
7469 done. Redo calculations to avoid overflow.
7470 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7471
7472 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7473 subtracting pointers.
7474 (gobble_line): Check for overflow more carefully. Don't update size
7475 until alloc done.
7476
7477 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7478 Don't update size until alloc done.
7479 Redo size calculations to avoid overflow.
7480 Check for size calculation overflow.
0065d054 7481 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7482
7483 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7484 Use ptrdiff_t, not int, for sizes.
7485 (store_mode_line_noprop_char): Don't update size until alloc done.
7486
0065d054
PE
7487 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7488 Use ptrdiff_t, not int, for sizes.
7489 (Finternal_make_lisp_face, cache_face):
7490 Check for size calculation overflow.
7491 (cache_face): Treat size calculation overflows as if they were
7492 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7493
7494 * xfns.c (x_encode_text, x_set_name_internal)
7495 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7496 sizes, since they can exceed INT_MAX in size. Check for size
7497 calculation overflow.
7498
0065d054
PE
7499 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7500 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7501 Don't update size until alloc done.
7502
0065d054 7503 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7504 as sprintf is limited to int lengths.
1d526e2f 7505
252c5ee1
PE
7506 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7507 (X_LONG_MIN): New macros.
864d7ce7
PE
7508 Use them to make the following changes clearer.
7509 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7510 This change doesn't affect the value now, but it may help remind
7511 future maintainers not to raise the value too much later.
7512 (SELECTION_QUANTUM): Remove, replacing with ...
7513 (selection_quantum): ... new function, which avoids overflow.
7514 All uses changed.
7515 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7516 assumption that selection length fits in 'int'.
7517 (x_reply_selection_request, x_handle_selection_request)
7518 (x_get_window_property, receive_incremental_selection)
7519 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7520 (lisp_data_to_selection_data, clean_local_selection_data):
7521 Use ptrdiff_t, not int, to record length of selection.
7522 (x_reply_selection_request, x_get_window_property)
7523 (receive_incremental_selection, x_property_data_to_lisp):
7524 Redo calculations to avoid overflow.
7525 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7526 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7527 something.
7528 (x_get_window_property, receive_incremental_selection)
7529 (lisp_data_to_selection_data, x_property_data_to_lisp):
7530 Check for size-calculation overflow.
7531 (x_get_window_property, receive_incremental_selection)
7532 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7533 Don't store size until memory allocation succeeds.
7534 (x_get_window_property): Plug memory leak on memory exhaustion.
7535 Don't double-block input; malloc is safe here. Don't assume 2**34
7536 - 4 fits in unsigned long. Add an xassert to check
7537 XGetWindowProperty overflow. Be more careful about overflow
7538 calculations, and distinguish size from memory overflow better.
7539 (receive_incremental_selection): When tracing, don't assume
7540 unsigned int is less than INT_MAX.
7541 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7542 harmful) conversions of unsigned short to int.
7543 (lisp_data_to_selection_data): Don't assume that integers
7544 in the range -65535 through -1 fit in an X unsigned short.
7545 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7546 result parameters unless successful. Rely on cons_to_unsigned
7547 to report problems with elements; the old code wasn't right anyway.
7548 (x_check_property_data): Check for int overflow; we cannot use
7549 a wider type due to X limits.
7550 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7551
726e0ab1 7552 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7553
0065d054
PE
7554 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7555 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7556 (x_color_cells): Don't store size until memory allocation succeeds.
7557 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7558 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7559 (x_term_init): Don't assume length fits in int (sprintf is limited
7560 to int size).
bc18e09d 7561
ebfa62c0
PE
7562 Use ptrdiff_t for composition IDs.
7563 * character.c (lisp_string_width):
7564 * composite.c (composition_table_size, n_compositions)
7565 (get_composition_id, composition_gstring_from_id):
7566 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7567 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7568 * window.c (Frecenter):
7569 Use ptrdiff_t, not int, for composition IDs.
7570 * composite.c (get_composition_id): Check for integer overflow.
7571 * composite.h: Adjust prototypes to match the above changes.
7572
d3411f89
PE
7573 Use ptrdiff_t for hash table indexes.
7574 * category.c (hash_get_category_set):
7575 * ccl.c (ccl_driver):
7576 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7577 * coding.c (coding_system_charset_list, detect_coding_system):
7578 * coding.h (struct coding_system.id):
7579 * composite.c (get_composition_id, gstring_lookup_cache):
7580 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7581 * image.c (xpm_get_color_table_h):
7582 * lisp.h (hash_lookup, hash_put):
7583 * minibuf.c (Ftest_completion):
7584 Use ptrdiff_t for hash table indexes, not int (which is too
7585 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7586 32-bit --with-wide-int hosts).
7587
e097a6fa
PE
7588 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7589 Add a FIXME comment about memory leaks.
7590 (syms_of_charset): Don't assume xmalloc returns.
7591
5637687f
PE
7592 Don't assume that stated character widths fit in int.
7593 * character.c (Fchar_width, c_string_width, lisp_string_width):
7594 * character.h (CHAR_WIDTH):
7595 * indent.c (MULTIBYTE_BYTES_WIDTH):
7596 Use sanitize_char_width to avoid undefined and/or bad behavior
7597 with outlandish widths.
a66cfb1c 7598 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7599 now that we have two such functions. All uses changed.
7600 (sanitize_char_width): New inline function.
7601
a2271ba2
PE
7602 Don't assume that tab-width fits in int.
7603 * character.h (sanitize_width): New inline function.
7604 (SANE_TAB_WIDTH): New macro.
7605 (ASCII_CHAR_WIDTH): Use it.
7606 * indent.c (sane_tab_width): Remove. All uses replaced by
7607 SANE_TAB_WIDTH (current_buffer).
7608 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7609
18c52557
PE
7610 * fileio.c: Integer overflow issues with file modes.
7611 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7612
caeeedc1
PE
7613 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7614 Remove unreachable code.
7615 (read_hex, load_charset_map_from_file): Check for integer overflow.
7616
6df6ae42 7617 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7618 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7619 (x_send_scroll_bar_event): Likewise. Check that the size does not
7620 exceed limits imposed by XClientMessageEvent, as well as the usual
7621 ptrdiff_t and size_t limits.
7622
b13995db
PE
7623 * keyboard.c: Overflow, signedness and related fixes.
7624 (make_lispy_movement): Use same integer type in forward decl
7625 that is used in the definition.
7626 (read_key_sequence, keyremap_step):
7627 Change bufsize argument back to int, undoing my 2011-03-30 change.
7628 We prefer signed types, and int is wide enough here.
7629 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7630 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7631 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7632 length, not size_t. Use ptrdiff_t for index, not int.
7633 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7634 possibility of integer overflow.
7635
13464394
PE
7636 Overflow, signedness and related fixes for images.
7637
7638 * dispextern.h (struct it.stack[0].u.image.image_id)
7639 (struct_it.image_id, struct image.id, struct image_cache.size)
7640 (struct image_cache.used, struct image_cache.ref_count):
7641 * gtkutil.c (update_frame_tool_bar):
7642 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7643 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7644 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7645 * nsmenu.m (update_frame_tool_bar):
7646 * xdisp.c (calc_pixel_width_or_height):
7647 * xfns.c (image_cache_refcount):
7648 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7649 on typical 64-bit hosts.
7650
7651 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7652 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7653 Omit unnecessary casts to int.
7654 (parse_image_spec): Check that integers fall into 'int' range
7655 when the callers expect that.
7656 (image_ascent): Redo ascent calculation to avoid int overflow.
7657 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7658 (lookup_image): Remove unnecessary tests.
7659 (xbm_image_p): Locals are now of int, not EMACS_INT,
7660 since parse_image_check makes sure they fit into int.
7661 (png_load, gif_load, svg_load_image):
7662 Prefer int to unsigned where either will do.
7663 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7664 old tiff_error_handler and tiff_warning_handler.
7665 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7666 stack buffer overflows. It uses only the features of vsnprintf
7667 that are common to both POSIX and native Microsoft.
7668 (tiff_error_handler, tiff_warning_handler): Use it.
7669 (tiff_load, gif_load, imagemagick_load_image):
7670 Don't assume :index value fits in 'int'.
7671 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7672 (imagemagick_load_image): Check that crop parameters fit into
7673 the integer types that MagickCropImage accepts. Don't assume
7674 Vimagemagick_render_type has a nonnegative value. Don't assume
7675 size_t fits in 'long'.
7676 (gs_load): Use printmax_t to print the widest integers possible.
7677 Check for integer overflow when computing image height and width.
7678
c11821d4
EZ
76792011-08-26 Eli Zaretskii <eliz@gnu.org>
7680
7681 * xdisp.c (redisplay_window): Don't force window start if point
7682 will be invisible in the resulting window. (Bug#9324)
7683
0c95fcf7
EZ
76842011-08-25 Eli Zaretskii <eliz@gnu.org>
7685
7686 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7687 the display spec is of the form `(space ...)'.
7688 (handle_display_spec): Return the value returned by
7689 handle_single_display_spec, not just 1 or zero.
7690 (handle_single_display_spec): If the display spec is of the form
7691 `(space ...)', and specifies display in the text area, return 2
7692 rather than 1.
fee65a97 7693 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7694 accurately, and prefer exact match for point under bidi.
7695 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7696
7697 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7698 into disp_prop; all users changed.
7699
7700 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7701 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7702 for the text covered by the display property.
7703
e4ed06f1
CY
77042011-08-25 Chong Yidong <cyd@stupidchicken.com>
7705
7706 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7707 Change return value to nil.
7708 (Frecord_buffer): Delete unused function.
7709
f67cdd7f
EZ
77102011-08-24 Eli Zaretskii <eliz@gnu.org>
7711
5980d4c6
EZ
7712 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7713 buffers, return left-to-right.
8610fe8b
EZ
7714 (set_cursor_from_row): Consider candidate row a win if its glyph
7715 represents a newline and point is on that newline. Fixes cursor
7716 positioning on the newline at EOL of R2L text within L2R
7717 paragraph, and vice versa.
7718 (try_cursor_movement): Check continued rows, in addition to
7719 continuation rows. Fixes unwarranted scroll when point enters a
7720 continued line of R2L text within an L2R paragraph, or vice versa.
7721 (cursor_row_p): Consider the case of point being equal to
7722 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7723 from the end of a short line to the beginning of a continued line
7724 of R2L text within L2R paragraph.
7725 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7726 composed characters.
5980d4c6 7727
f67cdd7f
EZ
7728 * bidi.c (bidi_check_type): Use xassert.
7729 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7730 members.
7731
bca633fb
EZ
77322011-08-23 Eli Zaretskii <eliz@gnu.org>
7733
7734 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7735 a character.
7736
4a5885a7
CY
77372011-08-23 Chong Yidong <cyd@stupidchicken.com>
7738
7739 * nsfont.m (ns_otf_to_script): Fix typo.
7740
0902a04e
KH
77412011-08-22 Kenichi Handa <handa@m17n.org>
7742
7743 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7744 extra slot even if the purpose is char-code-property-table.
7745
1a2e6670
EZ
77462011-08-23 Eli Zaretskii <eliz@gnu.org>
7747
8ddde651
EZ
7748 * xdisp.c (redisplay_window): When computing centering_position,
7749 account for the height of the header line. (Bug#8874)
7750
425cc014
EZ
7751 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7752 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7753 candidate is selected by the mouse, and that candidate has a
7754 composed character under the mouse.
7755
1a2e6670
EZ
7756 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7757 coordinates reported by pos-visible-in-window-p for a composed
7758 character in column zero.
7759
8b76d6f8
SM
77602011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7761
7762 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7763
dac347dd
EZ
77642011-08-22 Eli Zaretskii <eliz@gnu.org>
7765
7766 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7767 consider it a hit if to_charpos is anywhere in the range of the
7768 composed buffer positions.
7769
e013fb34
CY
77702011-08-22 Chong Yidong <cyd@stupidchicken.com>
7771
7772 * image.c (gif_load): Don't assume that each subimage has the same
7773 dimensions as the base image. Handle disposal method that is
7774 "undefined" by the gif spec (Bug#9335).
7775
bd1ba3e8
CY
77762011-08-20 Chong Yidong <cyd@stupidchicken.com>
7777
7778 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7779 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7780
54a1215b
EZ
77812011-08-19 Eli Zaretskii <eliz@gnu.org>
7782
823564e5
EZ
7783 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7784 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7785 from an Org mode buffer to a Speedbar frame.
7786
54a1215b
EZ
7787 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7788 a composition, take its buffer position from IT->cmp_it.charpos.
7789 Fixes cursor positioning at the beginning of a line that begins
7790 with a composed character.
7791
9778ebcc
EZ
77922011-08-18 Eli Zaretskii <eliz@gnu.org>
7793
0be6ee06
EZ
7794 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7795 character bidirectional type, use STRONG_L instead. Fixes crashes
7796 in a buffer produced by `describe-categories'.
7797
9778ebcc
EZ
7798 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7799 members before the level stack, so they would be saved and
7800 restored when copying iterator state. Fixes incorrect reordering
7801 around TABs covered by display properties.
7802
156bffbe
AS
78032011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7804
6b02f655 7805 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7806
72ad093b
CY
78072011-08-17 Chong Yidong <cyd@stupidchicken.com>
7808
7809 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7810 (internal_condition_case_2, internal_condition_case_n):
7811 Remove unnecessary aborts (Bug#9081).
72ad093b 7812
35774242
EZ
78132011-08-17 Eli Zaretskii <eliz@gnu.org>
7814
7815 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7816 has no `load' handler, try opening the file locally. (Bug#9311)
7817
db76dd85
KB
78182011-08-16 Ken Brown <kbrown@cornell.edu>
7819
7820 * gmalloc.c: Expand comment.
7821
b215eee5
EZ
78222011-08-16 Eli Zaretskii <eliz@gnu.org>
7823
7824 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7825 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7826
a4579d33
KB
78272011-08-16 Ken Brown <kbrown@cornell.edu>
7828
7829 Fix memory allocation problems in Cygwin build (Bug#9273).
7830
7831 * unexcw.c ( __malloc_initialized): Declare external variable.
7832 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7833
8b76d6f8
SM
7834 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7835 New variables.
a4579d33
KB
7836 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7837 dumped emacs.
7838 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7839 in the static heap.
7840 [CYGWIN] (special_realloc): New function.
7841 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7842 requests to realloc storage in the static heap.
7843
3ebec551
PE
78442011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7845
7846 * bidi.c (bidi_initialize): Remove unused local.
7847
9fd8be00
EZ
78482011-08-15 Eli Zaretskii <eliz@gnu.org>
7849
6b02f655
SM
7850 * bidimirror.h:
7851 * biditype.h: Remove file.
7852 * makefile.w32-in ($(BLD)/bidi.$(O)):
7853 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7854
7855 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7856
7857 * chartab.c: Improve commentary for the uniprop_table API.
7858
32413314
EZ
7859 * bidi.c (bidi_paragraph_init): Support zero value of
7860 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7861 (bidi_initialize): Use uniprop_table instead of including
7862 biditype.h and bidimirror.h.
32413314 7863
9fd8be00
EZ
7864 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7865 coordinates of the iterator when restoring from ppos_it.
7866 (Bug#9296)
7867
5cf2b69b
KH
78682011-08-14 Kenichi Handa <handa@m17n.org>
7869
7870 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7871 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7872
daf17d00
EZ
78732011-08-14 Eli Zaretskii <eliz@gnu.org>
7874
7875 * xdisp.c (move_it_in_display_line_to): Don't invoke
7876 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7877 ppos_it. Fixes vertical cursor motion when line beginning is
7878 covered by an image. (Bug#9296)
7879
08e3161a
JD
78802011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7881
7882 * nsterm.h (ns_run_ascript): Declare.
7883 (NSAPP_DATA2_RUNASSCRIPT): Define.
7884
7885 * nsfns.m (as_script, as_result, as_status): New static variables.
7886 (ns_run_ascript): New function.
5e617bc2 7887 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7888 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7889 the event loop. Get status from as_status (Bug#7276).
7890
7891 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7892 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7893 the event loop (Bug#7276).
7894
a3720aa2
AS
78952011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7896
7897 * gnutls.c (QCgnutls_bootprop_priority)
7898 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7899 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7900 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7901 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7902 (QCgnutls_bootprop_verify_hostname_error)
7903 (QCgnutls_bootprop_callbacks_verify): Rename from
7904 Qgnutls_bootprop_..., all uses changed.
7905
7906 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7907 uses changed.
7908
0a0d27fb
PE
79092011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7910
19d5c50c
PE
7911 * xfaces.c (Qframe_set_background_mode): Now static.
7912 * dispextern.h (Qframe_set_background_mode): Remove decl.
7913
0a0d27fb
PE
7914 * process.c (Fnetwork_interface_info): Declare local only if needed.
7915
377538cb
JD
79162011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7917
7918 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7919 (Fnetwork_interface_list): Allocate in increments of bytes instead
7920 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7921 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7922 sockaddr.
7923 (struct ifflag_def): notrailers is smart on OSX.
7924 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7925 Get hardware address with getifaddrs if available.
7926
08fff70c
EZ
79272011-08-12 Eli Zaretskii <eliz@gnu.org>
7928
7929 * xdisp.c (iterate_out_of_display_property): xassert that
7930 IT->position is set to within IT->object's boundaries. Break from
7931 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7932 when IT->position is set up wrongly due to some bug.
7933 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7934 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7935 entry. Force push_it to save on the stack the current
7936 buffer/string position, to be restored by pop_it. Fix flags in
7937 the iterator structure wrt the object coming from a display
7938 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7939 properties. (Bug#9284)
7940
7be1c708 79412011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7942
7be1c708
CY
7943 * fontset.c (fontset_get_font_group): Add proper type checks.
7944 (Bug#9172)
aac0c6e3 7945
7be1c708 79462011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7947
7be1c708
CY
7948 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7949 and LC_VERSION_MIN_MACOSX.
7950 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7951 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7952
97bb72a6
EZ
79532011-08-08 Eli Zaretskii <eliz@gnu.org>
7954
7955 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7956 no-display-properties-and-no-overlays under bidi display.
7957 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7958 properties and overlays.
97bb72a6 7959
d5617611
CY
79602011-08-08 Chong Yidong <cyd@stupidchicken.com>
7961
37e11a63
CY
7962 * editfns.c (Fset_time_zone_rule): Document relationship with the
7963 setenv function.
7964
d5617611
CY
7965 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7966 the font entity extracted from the cache (Bug#8109).
7967
58872834
CY
79682011-08-07 Chong Yidong <cyd@stupidchicken.com>
7969
7970 * composite.c (autocmp_chars): Don't reset point. That is done by
7971 restore_point_unwind (Bug#5984).
7972
75bfc667
JL
79732011-08-07 Juri Linkov <juri@jurta.org>
7974
7975 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7976 to show the arg `TIME' instead of `TIMEVAL'.
7977
d1410150
EZ
79782011-08-06 Eli Zaretskii <eliz@gnu.org>
7979
7980 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7981 display property strides EOL and includes a newline, as in
7982 longlines-mode. (Bug#9254)
75b771e4
EZ
7983 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7984 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7985
7986 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7987 is non-zero, even if the data buffer is NULL. Fixes a crash in
7988 vertical-motion with longlines-mode. (Bug#9254)
7989
35928349
EZ
79902011-08-05 Eli Zaretskii <eliz@gnu.org>
7991
ec7cc85b
EZ
7992 * bidi.c <bidi_cache_total_alloc>: Now static.
7993 (bidi_initialize): Initialize bidi_cache_total_alloc.
7994
8b76d6f8 7995 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7996 cache. (Bug#9221)
7997
7998 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7999 amount allocated this far in `bidi_cache_total_alloc'.
8000 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8001 non-zero, only free the data buffer without restoring the cache
8002 contents. All callers changed.
8003
8004 * dispextern.h (bidi_unshelve_cache): Update prototype.
8005
8006 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8007 (move_it_in_display_line, move_it_to)
8008 (move_it_vertically_backward, move_it_by_lines): Replace the call
8009 to xfree to an equivalent call to bidi_unshelve_cache.
8010 (move_it_in_display_line_to): Fix logic of returning
412b6358 8011 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8012
e2e2423b
EZ
80132011-08-05 Eli Zaretskii <eliz@gnu.org>
8014
8015 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8016 came from a string character with a `cursor' property. (Bug#9229)
8017
ae9e757a
JD
80182011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8019
8020 * Makefile.in (LIB_PTHREAD): New variable.
8021 (LIBES): Add LIB_PTHREAD (Bug#9216).
8022
8023 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8024 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8025
213bd7f2
AS
80262011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8027
6b02f655 8028 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8029
99aaf75f
JD
80302011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8031
8032 * xterm.c (x_find_topmost_parent): New function.
8033 (x_set_frame_alpha): Find topmost parent window with
8034 x_find_topmost_parent and set the property there also (bug#9181).
8035 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8036
c74e9d86
PE
80372011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8038
8039 * callproc.c (Fcall_process): Avoid vfork clobbering
8040 the local vars buffer, coding_systems, current_dir.
8041
640c8776
SM
80422011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8043
8044 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8045
f26d0e4c
PE
80462011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8047
8a10d76c
PE
8048 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8049 so that it is not optimized away.
8050
f26d0e4c
PE
8051 * xdisp.c (compute_display_string_pos): Remove unused local.
8052
55439c61
EZ
80532011-08-02 Eli Zaretskii <eliz@gnu.org>
8054
8055 Fix slow cursor motion and scrolling in large buffers with
8056 selective display, like Org Mode buffers. (Bug#9218)
8057
8058 * dispextern.h (struct bidi_it): New member disp_prop_p.
8059
8060 * xdisp.c: Remove one-slot cache of display string positions.
8061 (compute_display_string_pos): Accept an additional argument
5e617bc2 8062 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8063 for a display string or property. If found, set DISP_PROP_P
8064 non-zero.
8065
8066 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8067 DISP_PROP_P, and pass it to compute_display_string_pos.
8068 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8069 non-zero. All callers of bidi_fetch_char changed.
8070
fb33fa43
SM
80712011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8072
8073 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8074
b099e063
DM
80752010-12-03 Don March <don@ohspite.net>
8076
8077 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8078 last character M-[char] is translated to ESC [char] (bug#7541).
8079
5cc7f7af
KH
80802011-08-02 Kenichi Handa <handa@m17n.org>
8081
d0fffa3f 8082 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8083
8084 * chartab.c (uniprop_table): Make it non-static.
8085
525d5e6e
EZ
80862011-08-01 Eli Zaretskii <eliz@gnu.org>
8087
8088 * xdisp.c (forward_to_next_line_start): Accept additional argument
8089 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8090 on the newline.
8091 (reseat_at_next_visible_line_start): Use the bidi iterator state
8092 returned by forward_to_next_line_start to restore the state of
8093 it->bidi_it after backing up to previous newline. (Bug#9212)
8094
31011111
AS
80952011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8096
8097 * regex.c (re_comp): Protoize.
8098 (re_exec): Fix return type.
8099 (regexec): Fix type of `ret'. (Bug#9203)
8100
476371c4
PE
81012011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8102
e5d76069
PE
8103 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8104 This is needed if max-image-size is a floating-point number.
8105
9a79b20c
AS
81062011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8107
8108 * print.c (print_object): Print empty symbol as ##.
8109
8110 * lread.c (read1): Read ## as empty symbol.
8111
d8c2fa78
AA
81122011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8113
8114 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8115 setting frame foreground color (Bug#9175).
8116 (x_set_background_color): Likewise.
8117
ffe57a7a
AA
8118 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8119 contents (Bug#9176).
8120 (EmacsTooltip -init): Remove bezels and add shadows to
8121 tooltip windows.
8122
bf3492a5
AA
8123 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8124 or scroll bar (Bug#8470).
8125
d55e9c53
AA
8126 * nsfont.m (nsfont_open): Remove assignment to voffset and
8127 unnecessary vars hshink, expand, hd, full_height, min_height.
8128 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8129
8130 * nsterm.h (nsfont_info): Remove voffset field.
8131
d8c2fa78 81322011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8133
8134 Implement strike-through and overline on NextStep (Bug#8863).
8135
8136 * nsfont.m (nsfont_open): Use underline position provided by font,
8137 instead of hard-coded value of 2.
8138 (nsfont_draw): Call ns_draw_text_decoration instead.
8139
8140 * nsterm.h: Add declaration for ns_draw_text_decoration.
8141
8142 * nsterm.m (ns_draw_text_decoration): New function for drawing
8143 underline, overline, and strike-through.
8144 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8145 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8146 accommodate underlining, etc.
4843aac3 8147
4cc60b9b
EZ
81482011-07-28 Eli Zaretskii <eliz@gnu.org>
8149
bc7ece87
EZ
8150 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8151 default.
4cc60b9b 8152
476371c4
PE
81532011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8154
66606eea
PE
8155 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8156 Without this fix, if a signal arrives just after memory fills up,
8157 'malloc' might be invoked reentrantly.
8158
476371c4
PE
8159 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8160 In other words, assume that every image size is allowed, on non-X
8161 hosts. This assumption is probably wrong, but it lets Emacs compile.
8162
f3fcc40d
AS
81632011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8164
8165 * regex.c (re_iswctype): Convert return values to boolean.
8166
350c992f
EZ
81672011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8168
8169 * xdisp.c (compute_display_string_pos): Don't use cached display
8170 string position if the buffer had its restriction changed.
8171 (Bug#9184)
8172
5266b4bb
PE
81732011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8174
8175 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8176
2573a837 81772011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8178
41f55ccd 8179 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8180
39e378da
PE
8181 * bidi.c: Integer size and overflow fixes.
8182 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8183 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8184 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8185 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8186 (bidi_find_other_level_edge):
8187 Use ptrdiff_t instead of EMACS_INT where either will do.
8188 This works better on 32-bit hosts configured --with-wide-int.
8189 (bidi_cache_ensure_space): Check for size-calculation overflow.
8190 Use % rather than repeated addition, for better worst-case speed.
8191 Don't set bidi_cache_size until after xrealloc returns, because it
8192 might not return.
8193 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8194 (bidi_cache_ensure_space): Also check that the bidi cache size
8195 does not exceed that of the largest Lisp string or buffer. See Eli
8196 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8197
5e927815
PE
8198 * alloc.c (__malloc_size_t): Remove.
8199 All uses replaced by size_t. See Andreas Schwab's note
8200 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8201
ca4aa935
PE
8202 * image.c: Improve checking for integer overflow.
8203 (check_image_size): Assume that f is nonnull, since
8204 it is always nonnull in practice. This is one less thing to
8205 worry about when checking for integer overflow later.
8206 (x_check_image_size): New function, which checks for integer
8207 overflow issues inside X.
8208 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8209 This removes the need for a memory_full check.
8210 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8211 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8212 (xbm_read_bitmap_data): Change locals back to 'int', since
8213 their values must fit in 'int'.
8214 (xpm_load_image, png_load, tiff_load):
8215 Invoke x_create_x_image_and_pixmap earlier,
8216 to avoid much needless work if the image is too large.
8217 (tiff_load): Treat overly large images as if
8218 x_create_x_image_and_pixmap failed, not as malloc failures.
8219 (gs_load): Use x_check_image_size.
8220
5f8f9cc2
PE
8221 * gtkutil.c: Omit integer casts.
8222 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8223 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8224
5adf60bc
PE
8225 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8226
c8907a93
PE
8227 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8228 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8229 would wrongly return t on a 64-bit host.
8230
e3c25c68
PE
8231 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8232 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8233 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8234 and therefore cause GCC to emit a bogus diagnostic in some cases.
8235
3f791afe
PE
8236 * image.c: Integer signedness and overflow and related fixes.
8237 This is not an exhaustive set of fixes, but it's time to
8238 record what I've got.
8239 (lookup_pixel_color, check_image_size): Remove redundant decls.
8240 (check_image_size): Don't assume that arbitrary EMACS_INT values
8241 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8242 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8243 (tiff_load, imagemagick_load_image):
8244 Check for overflow in size calculations.
8245 (x_create_x_image_and_pixmap): Remove unnecessary test for
8246 xmalloc returning NULL; that can't happen.
8247 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8248 (xpm_color_bucket): Use better integer hashing function.
8249 (xpm_cache_color): Don't possibly over-allocate memory.
8250 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8251 (gif_memory_source):
8252 Use ptrdiff_t, not int or size_t, to record sizes.
8253 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8254 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8255 either works, as we prefer signed integers.
8256 (tiff_read_from_memory, tiff_write_from_memory):
8257 Return tsize_t, not size_t, since that's what the TIFF API wants.
8258 (tiff_read_from_memory): Don't fail simply because the read would
8259 go past EOF; instead, return a short read.
8260 (tiff_load): Omit no-longer-needed casts.
8261 (Fimagemagick_types): Don't assume size fits into 'int'.
8262
3cc5a532
PE
8263 Improve hashing quality when configured --with-wide-int.
8264 * fns.c (hash_string): New function, taken from sxhash_string.
8265 Do not discard information about ASCII character case; this
8266 discarding is no longer needed.
8267 (sxhash-string): Use it. Change sig to match it. Caller changed.
8268 * lisp.h: Declare it.
8269 * lread.c (hash_string): Remove, since we now use fns.c's version.
8270 The fns.c version returns a wider integer if --with-wide-int is
8271 specified, so this should help the quality of the hashing a bit.
8272
b312a492
PE
8273 * emacs.c: Integer overflow minor fix.
8274 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8275 Define only if GNU_LINUX.
8276 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8277
dfd153ae
PE
8278 * dispnew.c: Integer signedness and overflow fixes.
8279 Remove unnecessary forward decls, that were a maintenance hassle.
8280 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8281 All uses changed.
8282 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8283 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8284 (prepare_desired_row, line_draw_cost):
8285 Use int, not unsigned, where either works.
8286 (save_current_matrix, restore_current_matrix):
8287 Use ptrdiff_t, not size_t, where either works.
8288 (init_display): Check for overflow more accurately, and without
8289 relying on undefined behavior.
8290
a81d11a3
PE
8291 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8292 Remove, replacing with the new symbols in lisp.h. All uses changed.
8293 * fileio.c (make_temp_name):
8294 * filelock.c (lock_file_1, lock_file):
8295 * xdisp.c (message_dolog):
8296 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8297 Use pMd etc. instead.
8298 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8299 replacing the pWIDE etc. symbols removed from editfns.c.
8300
3300e6fd
PE
8301 * keyboard.h (num_input_events): Now uintmax_t.
8302 This is (very slightly) less likely to mess up due to wraparound.
8303 All uses changed.
8304
fd05c7e9
PE
8305 * buffer.c: Integer signedness fixes.
8306 (alloc_buffer_text, enlarge_buffer_text):
8307 Use ptrdiff_t rather than size_t when either will do, as we prefer
8308 signed integers.
8309
903fe15d
PE
8310 * alloc.c: Integer signedness and overflow fixes.
8311 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8312 (__malloc_size_t): Default to size_t, not to int.
8313 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8314 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8315 Prefer ptrdiff_t to size_t when either would do, as we prefer
8316 signed integers.
8317 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8318 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8319 Now const. Initialize with values that are in range even if char
8320 is signed.
8321 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8322 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8323 These functions do the right thing with sizes > 2**32.
8324 (check_depth): Now ptrdiff_t, not int.
8325 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8326 Adjust to new way of storing sizes. Check for size overflow bugs
8327 in rest of code.
8328 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8329 slightly wrong anyway, as it missed one instance of
8330 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8331 (refill_memory_reserve): Omit needless cast to size_t.
8332 (mark_object_loop_halt): Mark as externally visible.
8333
ac82cc6a
PE
8334 * xselect.c: Integer signedness and overflow fixes.
8335 (Fx_register_dnd_atom, x_handle_dnd_message):
8336 Use ptrdiff_t, not size_t, since we prefer signed.
8337 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8338 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8339 x_dnd_atoms_size and x_dnd_atoms_length.
8340
c2d1e36d
PE
8341 * doprnt.c: Prefer signed to unsigned when either works.
8342 * eval.c (verror):
8343 * doprnt.c (doprnt):
8344 * lisp.h (doprnt):
8345 * xdisp.c (vmessage):
8346 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8347 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8348 prefer signed arithmetic to avoid comparison confusion.
8349 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8350 but is a bit tricky.
8351
0e926e56
PE
8352 Assume freestanding C89 headers, string.h, stdlib.h.
8353 * data.c, doprnt.c, floatfns.c, print.c:
8354 Include float.h unconditionally.
8355 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8356 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8357 * regex.c: Likewise for stddef.h, string.h.
8358 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8359 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8360 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8361 (STDC_HEADERS): Remove obsolete defines.
8362 * sysdep.c: Include limits.h unconditionally.
8363
9cfdb3ec
PE
8364 Assume support for memcmp, memcpy, memmove, memset.
8365 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8366 * regex.c (memcmp, memcpy):
8367 Remove; we assume C89 now.
8368
8369 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8370 (__malloc_safe_bcopy): Remove; no longer needed.
8371
cf950e6b 8372 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8373 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8374 well either way, and we prefer signed to unsigned.
8375
dbf38e02
LMI
83762011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8377
8378 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8379 closes the connection while we're reading (bug#9182).
8380
d6f0886c 83812011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8382
d6f0886c
JD
8383 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8384 are specified (Bug#9168).
24e0f6b1 8385
2eb1f9e6
PE
83862011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8387
8388 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8389 Found by GCC static checking and --with-wide-int on a 32-bit host.
8390
22381272 83912011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8392
8393 * xdisp.c (compute_display_string_pos): Fix logic of caching
8394 previous display string position. Initialize cached_prev_pos to
8395 -1. Fixes slow-down at the beginning of a buffer.
8396
f25e39b4
EZ
83972011-07-24 Eli Zaretskii <eliz@gnu.org>
8398
8399 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8400 for attrs[LFACE_FONTSET_INDEX].
8401
04c4b52e
PE
84022011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8403
8404 * xml.c (parse_region): Remove unused local
8405 that was recently introduced.
8406
c1734fbd
EZ
84072011-07-23 Eli Zaretskii <eliz@gnu.org>
8408
be18c5a5
EZ
8409 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8410 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8411
c1734fbd
EZ
8412 * xdisp.c (move_it_in_display_line_to): Record the best matching
8413 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8414 exit if none of the characters scanned was an exact match.
8415 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8416 when exact match is impossible due to invisible text, and the
8417 lines are truncated.
8418
a258d627
JD
84192011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8420
8421 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8422 for OSX >= 10.7.
8423
b6d5a689
EZ
84242011-07-22 Eli Zaretskii <eliz@gnu.org>
8425
0f74f785
EZ
8426 Fix a significant slow-down of cursor motion with C-n, C-p,
8427 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8428 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8429 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8430 (next_element_from_buffer): Call compute_stop_pos_backwards to
8431 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8432 base_level_stop.
8433 (reseat): Don't look for prev_stop, as that could mean a very long
8434 run.
8435 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8436 <cached_disp_overlay_modiff>: Cache for last found display string
8437 position.
551918c1 8438 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8439 about the same buffer in the same area of character positions, and
8440 the buffer wasn't changed since the time the display string
8441 position was cached.
551918c1 8442
b2d0c91a
EZ
84432011-07-22 Eli Zaretskii <eliz@gnu.org>
8444
8445 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8446 is an integer, which is important for empty lines. (Bug#9149)
8447
043604ee
CY
84482011-07-22 Chong Yidong <cyd@stupidchicken.com>
8449
8450 * frame.c (Fmodify_frame_parameters): In tty case, update the
8451 default face if necessary (Bug#4238).
8452
da4adb04
CY
84532011-07-21 Chong Yidong <cyd@stupidchicken.com>
8454
8455 * editfns.c (Fstring_to_char): No need to explain what a character
8456 is in the docstring (Bug#6576).
8457
9abd0532
LMI
84582011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8459
8460 * xml.c (parse_region): Make sure we always return a tree.
8461
36881d16
HK
84622011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8463
8464 * xml.c (parse_region): If a document contains only comments,
8465 return that, too.
8466
1e98674d
LMI
84672011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8468
8469 * xml.c (make_dom): Return comments, too.
8470
590bd467
PE
84712011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8472
8473 Port to OpenBSD.
8474 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8475 and the surrounding thread.
8476 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8477 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8478 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8479 timer goes off.
8480 * s/openbsd.h (BROKEN_SIGIO): Define.
8481 * unexelf.c (unexec) [__OpenBSD__]:
8482 Don't update the .mdebug section of the Alpha COFF symbol table.
8483
f41628b2
LMI
84842011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8485
8486 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8487 (bug#8460).
8488
b59b67c5
PE
84892011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8490
15e3a074
PE
8491 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8492 This fixes some race conditions on the permissions of any newly
8493 created file.
8494
41bed37d
PE
8495 * alloc.c (valid_pointer_p): Use pipe, not open.
8496 This fixes some permissions issues when debugging.
8497
b59b67c5
PE
8498 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8499 If fchown fails to set both uid and gid, try to set just gid,
8500 as that is sometimes allowed. Adjust the file's mode to eliminate
8501 setuid or setgid bits that are inappropriate if fchown fails.
8502
925a6be7
SM
85032011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8504
8505 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8506 to compare Lisp_Objects.
8507 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8508 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8509 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8510
52968808
AS
85112011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8512
0a6a104b
AS
8513 * lread.c (read_integer): Unread even EOF character.
8514 (read1): Likewise. Properly record start position of symbol.
8515
52968808
AS
8516 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8517 symbol character follows.
8518
9e381cdd
PE
85192011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8520
8521 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8522 This works around a problem with the previous change to Fcopy_file.
8523 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8524 and without this change, GCC might complain about discarding
8525 fchown's return value.
8526
b5641435
JB
85272011-07-16 Juanma Barranquero <lekktu@gmail.com>
8528
8529 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8530
a8031457
PE
85312011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8532
8533 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8534
dd889327
LMI
85352011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8536
750c33f7
LMI
8537 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8538 it's used from the C level.
8539
dd889327
LMI
8540 * process.c: Use the same condition for POLL_FOR_INPUT in both
8541 keyboard.c and process.c (bug#1858).
8542
87e86684
LM
85432011-07-09 Lawrence Mitchell <wence@gmx.li>
8544
8545 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8546 (Fgnutls_boot): Use it.
8547
64348f40
AS
85482011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8549
8550 * doc.c (Fsubstitute_command_keys): Revert last change.
8551
1d698799
LMI
85522011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8553
f863868c
LMI
8554 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8555 quotes the next character, and doesn't affect other longer
8556 sequences (bug#8935).
8557
1d698799
LMI
8558 * lread.c (syms_of_lread): Clarify that is isn't only
8559 `eval-buffer' and `eval-defun' that's affected by
8560 `lexical-binding' (bug#8460).
8561
aa4b6df6
EZ
85622011-07-15 Eli Zaretskii <eliz@gnu.org>
8563
8564 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8565 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8566
5d856da6
PE
85672011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8568
ad6042bb
PE
8569 Fix minor problems found by static checking.
8570 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8571 (elsz): Now a signed constant, not a size_t var. We prefer signed
8572 types to unsigned, to avoid integer comparison confusion. Without
8573 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8574 "cannot optimize loop, the loop counter may overflow", a symptom
8575 of the confusion.
f00bbb22 8576 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8577 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8578
6468f31c
LMI
85792011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8580
49080b10
LMI
8581 * search.c (Fre_search_backward): Mention `case-fold-search' in
8582 all the re_search_* functions (bug#8138).
8583
6468f31c
LMI
8584 * keyboard.c (Fopen_dribble_file): Document when the file is
8585 closed (bug#8056).
8586
c965adc5
EZ
85872011-07-14 Eli Zaretskii <eliz@gnu.org>
8588
df9733bf
EZ
8589 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8590 bidi_cache_idx.
8591
0bb23927
EZ
8592 Support bidi reordering of display and overlay strings.
8593 * xdisp.c (compute_display_string_pos)
8594 (compute_display_string_end): Accept additional argument STRING.
8595 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8596 (reseat_to_string): Initialize bidi_it->string.s and
8597 bidi_it->string.schars.
8598 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8599 NULL (avoids a crash in bidi_paragraph_init).
8600 Initialize itb.string.lstring.
0bb23927
EZ
8601 (init_iterator): Call bidi_init_it only of a valid
8602 buffer position was specified. Initialize paragraph_embedding to
8603 L2R.
8604 (reseat_to_string): Initialize the bidi iterator.
8605 (display_string): If we need to ignore text properties of
8606 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8607 original value of -1 will not work with bidi.)
8608 (compute_display_string_pos): First arg is now struct
8609 `text_pos *'; all callers changed. Support display properties on
8610 Lisp strings.
8611 (compute_display_string_end): Support display properties on Lisp
8612 strings.
8613 (init_iterator, reseat_1, reseat_to_string): Initialize the
8614 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8615 when iterating on a string not from display properties).
640c8776
SM
8616 (compute_display_string_pos, compute_display_string_end):
8617 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8618 arrow keys.
8619 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8620 base_level_stop; instead, set base_level_stop to BEGV.
8621 Fixes crashes in vertical-motion.
0bb23927
EZ
8622 (next_element_from_buffer): Improve commentary for when
8623 the iterator is before prev_stop.
8624 (init_iterator): Initialize bidi_p from the default value of
8625 bidi-display-reordering, not from buffer-local value. Use the
8626 buffer-local value only if initializing for buffer iteration.
8627 (handle_invisible_prop): Support invisible properties on strings
8628 that are being bidi-reordered.
8629 (set_iterator_to_next): Support bidi reordering of C strings and
8630 Lisp strings.
8631 (next_element_from_string): Support bidi reordering of Lisp
8632 strings.
8633 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8634 (display_string): Support display of R2L glyph rows.
8635 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8636 (init_iterator): Don't initialize it->bidi_p for strings
8637 here.
8638 (reseat_to_string): Initialize it->bidi_p for strings here.
8639 (next_element_from_string, next_element_from_c_string)
8640 (next_element_from_buffer): Add xassert's for correspondence
8641 between IT's object being iterated and it->bidi_it.string
8642 structure.
8643 (face_before_or_after_it_pos): Support bidi iteration.
8644 (next_element_from_c_string): Handle the case of the first string
8645 character that is not the first one in the visual order.
8646 (get_visually_first_element): New function, refactored from common
8647 parts of next_element_from_buffer, next_element_from_string, and
8648 next_element_from_c_string.
8649 (tool_bar_lines_needed, redisplay_tool_bar)
8650 (display_menu_bar): Force left-to-right direction. Add a FIXME
8651 comment for making that be controlled by a user option.
8652 (push_it, pop_it): Save and restore the state of the
8653 bidi iterator. Save and restore the bidi_p flag.
8654 (pop_it): Iterate out of display property for string iteration as
8655 well.
8656 (iterate_out_of_display_property): Support iteration over strings.
8657 (handle_single_display_spec): Set up it->bidi_it for iteration
8658 over a display string, and call bidi_init_it.
8659 (handle_single_display_spec, next_overlay_string)
8660 (get_overlay_strings_1, push_display_prop): Set up the bidi
8661 iterator for displaying display or overlay strings.
8662 (forward_to_next_line_start): Don't use the shortcut if
8663 bidi-iterating.
8664 (back_to_previous_visible_line_start): If handle_display_prop
8665 pushed the iterator stack, restore the internal state of the bidi
8666 iterator by calling bidi_pop_it same number of times.
8667 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8668 and we are bidi-iterating, don't decrement the iterator position;
8669 instead, set the first_elt flag in the bidi iterator, to produce
8670 the same effect.
8671 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8672 (push_display_prop): xassert that we are iterating a buffer.
8673 (push_it, pop_it): Save and restore paragraph_embedding member.
8674 (handle_single_display_spec, next_overlay_string)
8675 (get_overlay_strings_1, reseat_1, reseat_to_string)
8676 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8677 correctly. Don't assume unibyte strings are not bidi-reordered.
8678 (compute_display_string_pos)
8679 (compute_display_string_end): Fix handling the case of C string.
8680 (push_it, pop_it): Save and restore from_disp_prop_p.
8681 (handle_single_display_spec, push_display_prop): Set the
8682 from_disp_prop_p flag.
8683 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8684 (pop_it): Call iterate_out_of_display_property only if we are
8685 popping after iteration over a string that came from a display
8686 property. Fix a typo in popping stretch info. Add an assertion
8687 for verifying that the iterator position is in sync with the bidi
8688 iterator.
8689 (handle_single_display_spec, get_overlay_strings_1)
8690 (push_display_prop): Fix initialization of paragraph direction for
8691 string when that of the parent object is not yet determined.
8692 (reseat_1): Call bidi_init_it to resync the bidi
8693 iterator with IT's position. (Bug#7616)
8694 (find_row_edges): If ROW->start.pos gives position
8695 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8696 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8697 Reset the from_disp_prop_p flag.
8698 (SAVE_IT, RESTORE_IT): New macros.
8699 (pos_visible_p, face_before_or_after_it_pos)
8700 (back_to_previous_visible_line_start)
8701 (move_it_in_display_line_to, move_it_in_display_line)
8702 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8703 (try_scrolling, redisplay_window, display_line): Use them when
8704 saving a temporary copy of the iterator and restoring it back.
8705 (back_to_previous_visible_line_start, reseat_1)
8706 (init_iterator): Empty the bidi cache "stack".
8707 (move_it_in_display_line_to): If iterator ended up at
8708 EOL, but we never saw any buffer positions smaller than
8709 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8710 motion in bidi-reordered lines.
8711 (move_it_in_display_line_to): Record prev_method and prev_pos
8712 immediately before the call to set_iterator_to_next. Fixes cursor
8713 motion in bidi-reordered lines with stretch glyphs and strings
8714 displayed in margins. (Bug#8133) (Bug#8867)
8715 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8716 TO_CHARPOS.
640c8776
SM
8717 (pos_visible_p): Support positions in bidi-reordered lines.
8718 Save and restore bidi cache.
0bb23927
EZ
8719
8720 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8721 (bidi_paragraph_info): Delete unused struct.
8722 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8723 (bidi_cache_start): New variable.
8724 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8725 to zero.
8726 (bidi_cache_fetch_state, bidi_cache_search)
8727 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8728 (bidi_cache_find, bidi_peek_at_next_level)
8729 (bidi_level_of_next_char, bidi_find_other_level_edge)
8730 (bidi_move_to_visually_next): Compare cache index with
8731 bidi_cache_start rather than with zero.
8732 (bidi_fetch_char): Accept new argument STRING; all callers
8733 changed. Support iteration over a string. Support strings with
8734 display properties. Support unibyte strings. Fix the type of
8735 `len' according to what STRING_CHAR_AND_LENGTH expects.
8736 (bidi_paragraph_init, bidi_resolve_explicit_1)
8737 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8738 (bidi_level_of_next_char, bidi_move_to_visually_next):
8739 Support iteration over a string.
0bb23927
EZ
8740 (bidi_set_sor_type, bidi_resolve_explicit_1)
8741 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8742 can now be zero (for strings); special values 0 and -1 were
8743 changed to -1 and -2, respectively.
8744 (bidi_char_at_pos): New function.
8745 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8746 Call it instead of FETCH_MULTIBYTE_CHAR.
8747 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8748 initialized to valid values.
8749 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8750 values.
8751 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8752 the test for valid cached positions. Fix the logic for looking up
8753 the sentinel state in the cache. GCPRO the Lisp string we are
8754 iterating.
8755 (bidi_push_it, bidi_pop_it): New functions.
8756 (bidi_initialize): Initialize the bidi cache start stack pointer.
8757 (bidi_cache_ensure_space): New function, refactored from part of
8758 bidi_cache_iterator_state. Don't assume the required size is just
8759 one BIDI_CACHE_CHUNK away.
8760 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8761 (bidi_count_bytes, bidi_char_at_pos): New functions.
8762 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8763 always valid if bidi_cache_idx is valid.
8764 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8765 is valid if it's going to be used.
8766 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8767 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8768 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8769 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8770 (bidi_find_other_level_edge, bidi_cache_start_stack):
8771 All variables related to cache indices are now EMACS_INT.
c965adc5 8772
0bb23927
EZ
8773 * dispextern.h (struct bidi_string_data): New structure.
8774 (struct bidi_it): New member `string'. Make flag members be 1-bit
8775 fields, and put them last in the struct.
640c8776
SM
8776 (compute_display_string_pos, compute_display_string_end):
8777 Update prototypes.
0bb23927
EZ
8778 (bidi_push_it, bidi_pop_it): Add prototypes.
8779 (struct iterator_stack_entry): New members bidi_p,
8780 paragraph_embedding, and from_disp_prop_p.
8781 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8782 (bidi_shelve_cache, bidi_unshelve_cache):
8783 Declare prototypes.
0bb23927
EZ
8784
8785 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8786 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8787 and vector-like objects.
8788
8789 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8790 cache around display iteration.
8791
8792 * window.c (Fwindow_end, window_scroll_pixel_based)
8793 (displayed_window_lines, Frecenter): Save and restore the bidi
8794 cache around display iteration.
8795
3bbd2265
LMI
87962011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8797
8798 * editfns.c (Fdelete_region): Clarify the use of the named
8799 parameters (bug#6788).
8800
adc47434
MR
88012011-07-14 Martin Rudalics <rudalics@gmx.at>
8802
8803 * indent.c (Fvertical_motion): Set and restore w->pointm when
8804 saving and restoring the window's buffer (Bug#9006).
8805
837c31f8
LMI
88062011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8807
8808 * editfns.c (Fstring_to_char): Clarify just what is returned
8809 (bug#6576). Text by Eli Zaretskii.
8810
ac389d0c
JB
88112011-07-13 Juanma Barranquero <lekktu@gmail.com>
8812
8813 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8814
0be0ce47
EZ
88152011-07-13 Eli Zaretskii <eliz@gnu.org>
8816
8817 * buffer.c (mmap_find): Fix a typo.
8818
cd18e7e3
JB
88192011-07-13 Johan Bockgård <bojohan@gnu.org>
8820
8821 Fix execution of x selection hooks.
8822 * xselect.c (Qx_lost_selection_functions)
8823 (Qx_sent_selection_functions): New vars.
8824 (syms_of_xselect): DEFSYM them.
8825 (x_handle_selection_request): Pass Qx_sent_selection_functions
8826 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8827 (x_handle_selection_clear,x_clear_frame_selections):
8828 Pass Qx_lost_selection_functions rather than
8829 Vx_lost_selection_functions to Frun_hook_with_args.
8830
47ea7f44
PE
88312011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8832
ac389d0c 8833 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8834 The old code sometimes used this field without initializing it.
8835
47ea7f44
PE
8836 * alloc.c (gc_sweep): Don't read past end of array.
8837 In theory, the old code could also have corrupted Emacs internals,
8838 though it'd be very unlikely.
8839
bc985c87
AS
88402011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8841
8842 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8843 argument. (Bug#4026)
bc985c87 8844
0cf34688
LMI
88452011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8846
b3dadd76
LMI
8847 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8848 key" (bug#4257).
8849
0cf34688
LMI
8850 * window.c (Fset_window_start): Doc fix (bug#4199).
8851 (Fset_window_hscroll): Ditto.
8852
270768cd
PE
88532011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8854
077e3dda 8855 Fix minor new problems caught by GCC 4.6.1.
270768cd 8856 * term.c (init_tty): Remove unused local.
490011a6 8857 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8858 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8859 not used otherwise.
270768cd 8860
b1f58454
CY
88612011-07-12 Chong Yidong <cyd@stupidchicken.com>
8862
8863 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8864
22b9578d
LMI
88652011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8866
6e70ab07
LMI
8867 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8868 are the mini-buffer and the echo area (bug#3320).
8869
22b9578d
LMI
8870 * term.c (init_tty): Remove support for supdup, c10 and perq
8871 terminals, which are no longer supported (bug#1482).
8872
8974cc9f
JB
88732011-07-10 Johan Bockgård <bojohan@gnu.org>
8874
8875 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8876
a560d974
JD
88772011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8878
8879 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8880 for non-popups (Bug#3642).
8881
1dae0f0a
AS
88822011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8883
268c2c36 8884 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8885 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8886 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8887 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8888 * data.c (fmod): Likewise.
8889 * dispnew.c (swap_glyphs_in_rows): Likewise.
8890 * emacs.c (memory_warning_signal): Likewise.
8891 * floatfns.c (float_error): Likewise.
8892 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8893 (otf_open, font_otf_capability, generate_otf_features)
8894 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8895 Likewise.
8896 * image.c (pbm_read_file): Likewise.
8897 * indent.c (string_display_width): Likewise.
8898 * intervals.c (check_for_interval, search_for_interval)
8899 (inc_interval_count, count_intervals, root_interval)
8900 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8901 * lread.c (defalias): Likewise.
268c2c36 8902 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8903 * regex.c (set_image_of_range_1, set_image_of_range)
8904 (regex_grow_registers): Likewise.
8905 * sysdep.c (strerror): Likewise.
8906 * termcap.c (valid_filename_p, tprint, main): Likewise.
8907 * tparam.c (main): Likewise.
8908 * unexhp9k800.c (run_time_remap, save_data_space)
8909 (update_file_ptrs, read_header, write_header, calculate_checksum)
8910 (copy_file, copy_rest, display_header): Likewise.
8911 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8912 Likewise.
8913 * xdisp.c (check_it): Likewise.
8914 * xfaces.c (register_color, unregister_color, unregister_colors):
8915 Likewise.
8916 * xfns.c (print_fontset_result): Likewise.
8917 * xrdb.c (member, fatal, main): Likewise.
8918
99033785
PE
89192011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8920
8921 Fix minor problems found by static checking (Bug#9031).
8922 * chartab.c (char_table_set_range, map_sub_char_table):
8923 Remove unused locals.
8924 (uniprop_table): Now static.
8925 * composite.c (_work_char): Remove unused static var.
8926
9cb2ac56
JB
89272011-07-09 Juanma Barranquero <lekktu@gmail.com>
8928
8929 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8930
f25661f0
JD
89312011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8932
8933 * gtkutil.c (qttip_cb): Remove code without function.
8934
8278c4fe
EZ
89352011-07-09 Eli Zaretskii <eliz@gnu.org>
8936
8937 * w32.c (pthread_sigmask): New stub.
8938
1692ae2d 89392011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8940
8a6ebd58 8941 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8942 sigprocmask is portable only for single-threaded applications, and
8943 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8944 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8945 (LIBES): Use it.
8946 * callproc.c (Fcall_process):
8947 * process.c (create_process):
8948 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8949 Use pthread_sigmask, not sigprocmask.
123403e4 8950
1b854618
JD
89512011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8952
8953 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8954 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8955 wrong (Bug#8591).
8956
3fe4b549
JD
89572011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8958
0ce7e563
JD
8959 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8960 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8961 (xg_hide_tooltip): Fix comment.
8962
3fe4b549
JD
8963 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8964 in registerServicesMenuSendTypes.
8965 (validRequestorForSendType): Don't check ns_return_types.
8966
8967 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8968 ns_return_type.
8969
5df75e47
JR
89702011-07-08 Jason Rumney <jasonr@gnu.org>
8971
22610910
JR
8972 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8973 SH_SHOW for hidden windows (Bug#5482).
8974
5df75e47
JR
8975 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8976 frame struct members of non-existent frames (Bug#6284).
8977
699c10bd
JD
89782011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8979
4393663b
JD
8980 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8981 variable firstTime not needed on OSX >= 10.6.
8982 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8983 >= 10.5. Use setKnobProportion, setDoubleValue.
8984
8985 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8986 (MAC_OS_X_VERSION_10_5): Define if not defined.
8987 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8988 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8989 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8990
8991 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8992 cString and lossyCString on OSX >= 10.4.
4393663b 8993
58179cce 8994 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8995 sizeToFit on OSX >= 10.2.
8996
8997 * nsimage.m (allocInitFromFile): Don't use deprecated method
8998 bestRepresentationForDevice on OSX >= 10.6.
8999
9000 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9001 to avoid warning.
9002
9003 * emacs.c: Declare unexec_init_emacs_zone.
9004
a63e0781
JD
9005 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9006
699c10bd
JD
9007 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9008
9009 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9010 on svcsMenu (Bug#8842).
9011
9012 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9013 ns_return_types.
9014 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9015
9016 * nsterm.m (QUTF8_STRING): Declare.
9017 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9018 (validRequestorForSendType): Return type is (id).
9019 Change indexOfObjectIdenticalTo to indexOfObject.
9020 Check if we have local selection before returning self (Bug#8842).
9021 (writeSelectionToPasteboard): Put local selection into paste board
9022 if we have a local selection (Bug#8842).
9023 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9024
9025 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9026 (ns_get_local_selection): Declare.
9027
54e10184
LMI
90282011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9029
9888ff71
LMI
9030 * keymap.c (describe_map_tree): Don't insert a double newline at
9031 the end of the buffer (bug#1169) and return whether we inserted
9032 something.
9033
54e10184
LMI
9034 * callint.c (Fcall_interactively): Change "reading args" to
9035 "providing args" to try to clarify what it does (bug#1010).
9036
15fa4783
KH
90372011-07-07 Kenichi Handa <handa@m17n.org>
9038
9039 * composite.c (composition_compute_stop_pos): Ignore a static
9040 composition starting before CHARPOS (Bug#8915).
9041
9042 * xdisp.c (handle_composition_prop): Likewise.
9043
a8815b00
EZ
90442011-07-07 Eli Zaretskii <eliz@gnu.org>
9045
9046 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9047 (Bug#9015)
9048
ef7b981d 90492011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9050
9051 * character.h (unicode_category_t): New enum type.
9052
9053 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9054 (Qchar_code_property_table): New variable.
9055 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9056 (UNIPROP_COMPRESSED_FORM_P): New macros.
9057 (char_table_ascii): Uncompress the compressed values.
9058 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9059 Uncompress the compressed values.
ac389d0c 9060 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9061 (char_table_ref_and_range): Uncompress the compressed values.
9062 (sub_char_table_set): New arg is_uniprop. Callers changed.
9063 Uncompress the compressed values.
9064 (sub_char_table_set_range): Args changed. Callers changed.
9065 (char_table_set_range): Adjuted for the above change.
9066 (map_sub_char_table): Delete args default_val and parent. Add arg
9067 top. Give decoded values to a Lisp function.
640c8776 9068 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9069 values to a Lisp function. Gcpro more variables.
9070 (uniprop_table_uncompress)
9071 (uniprop_decode_value_run_length): New functions.
9072 (uniprop_decoder, uniprop_decoder_count): New variables.
9073 (uniprop_get_decoder, uniprop_encode_value_character)
9074 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9075 New functions.
9076 (uniprop_encoder, uniprop_encoder_count): New variables.
9077 (uniprop_get_encoder, uniprop_table)
9078 (Funicode_property_table_internal, Fget_unicode_property_internal)
9079 (Fput_unicode_property_internal): New functions.
9080 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9081 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9082 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9083 char-code-property-alist.
9084
640c8776 9085 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9086 Vunicode_category_table.
9087
640c8776 9088 * font.c (font_range): Adjust for the change of
c805dec0
KH
9089 Vunicode_category_table.
9090
76b397fb
DN
90912011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9092
9093 * m/iris4d.h: Remove file, move contents ...
9094 * s/irix6-5.h: ... here.
9095
22b4128e
PE
90962011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9097
9098 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9099 * alloc.c (mark_buffer):
9100 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9101 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9102 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9103 This isn't true in general, and it's particularly not true
9104 if Emacs is configured with --with-wide-int.
9105 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9106 New macros, used in the buffer.c change.
9107
869795d6
JD
91082011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9109
9110 * xsettings.c: Use both GConf and GSettings if both are available.
9111 (store_config_changed_event): Add comment.
9112 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9113 (store_tool_bar_style_changed): New functions.
5e617bc2 9114 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9115 (struct xsettings): Move font inside HAVE_XFT.
9116 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9117 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9118 Move inside HAVE_XFT.
640c8776 9119 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9120 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9121 also.
9122 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9123 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9124 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9125 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9126 (parse_settings): Move check for font inside HAVE_XFT.
9127 (read_settings, apply_xft_settings): Add comment.
9128 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9129 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9130 call store_font_name_changed.
9131 (xft_settings_event): Add comment.
9132 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9133 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9134 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9135 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9136 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9137 (xsettings_get_system_font, xsettings_get_system_normal_font):
9138 Add comment.
869795d6 9139
d8ed26bd
PE
91402011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9141
9142 Random fixes. E.g., (random) never returned negative values.
9143 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9144 subseconds part to the entropy, as that's a bit more random.
9145 Prefer signed to unsigned, since the signedness doesn't matter and
9146 in general we prefer signed. When given a limit, use a
9147 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9148 latter isn't right if USE_2_TAGS_FOR_INTS.
9149 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9150 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9151
cabf1cac
SM
91522011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9153
9154 * textprop.c (text_property_stickiness):
9155 Obey Vtext_property_default_nonsticky.
9156 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9157 * w32fns.c (syms_of_w32fns):
9158 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9159
6e9b2be9
PE
91602011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9161
9162 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9163 This is more efficient than Ffile_directory_p and avoids a minor race.
9164
90186c68
LMI
91652011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9166
7c301272
LMI
9167 * buffer.c (Foverlay_put): Say what the return value is
9168 (bug#7835).
9169
c4f2d8d4
LMI
9170 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9171 is a directory before asking whether to use the file name
9172 (bug#7564).
ad637907
LMI
9173 (barf_or_query_if_file_exists): Make the "File is a directory"
9174 error be more correct.
c4f2d8d4 9175
90186c68
LMI
9176 * fns.c (Frequire): Remove the mention of the .gz files, since
9177 that's installation-specific, but keep the mention of
9178 `get-load-suffixes'.
9179
da64016e
PE
91802011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9181
9182 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9183 Report string overflow if the output is too long.
9184
7d47b580
JB
91852011-07-04 Juanma Barranquero <lekktu@gmail.com>
9186
a555cb87
JB
9187 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9188 (syms_of_gnutls): Remove duplicate DEFSYM for
9189 Qgnutls_bootprop_verify_hostname_error, an error for
9190 Qgnutls_bootprop_verify_error (which is no longer used).
9191
7d47b580
JB
9192 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9193 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9194 Also (re)move comments that are misplaced or no longer relevant.
9195
1e49bfab
LMI
91962011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9197
9198 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9199
1485f4c0
CY
92002011-07-03 Chong Yidong <cyd@stupidchicken.com>
9201
9202 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9203 and background color parameters if they have been changed.
9204
a9ab721e
LMI
92052011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9206
9207 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9208
cf7cff57
PE
92092011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9210
2e13213d
PE
9211 * xsettings.c (SYSTEM_FONT): Define only when used.
9212 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9213
cf7cff57
PE
9214 * keymap.c (access_keymap_1): Now static.
9215
7a8e04f7
CY
92162011-07-02 Chong Yidong <cyd@stupidchicken.com>
9217
9218 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9219 leave any prefix arg for the up event (Bug#1586).
9220
61352f62
LMI
92212011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9222
69bb1ef7
LMI
9223 * lread.c (syms_of_lread): Mention single symbols defined by
9224 `defvar' or `defconst' (bug#7154).
9225
61352f62 9226 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9227 (Frequire): Mention get-load-suffixes.
61352f62 9228
28545e04
MR
92292011-07-02 Martin Rudalics <rudalics@gmx.at>
9230
9231 * window.h (window): Remove clone_number slot.
9232 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9233 Remove.
9234 (make_parent_window, make_window, saved_window)
9235 (Fset_window_configuration, save_window_save): Don't deal with
9236 clone numbers.
9237 * buffer.c (Qclone_number): Remove declaration.
9238 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9239
3349e122
SM
92402011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9241
9242 Add multiple inheritance to keymaps.
9243 * keymap.c (Fmake_composed_keymap): New function.
9244 (Fset_keymap_parent): Simplify.
9245 (fix_submap_inheritance): Remove.
9246 (access_keymap_1): New function extracted from access_keymap to handle
9247 embedded parents and handle lists of maps.
9248 (access_keymap): Use it.
9249 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9250 (Fcopy_keymap): Handle embedded parents.
9251 (Fcommand_remapping, define_as_prefix): Simplify.
9252 (Fkey_binding): Simplify.
9253 (syms_of_keymap): Move minibuffer-local-completion-map,
9254 minibuffer-local-filename-completion-map,
9255 minibuffer-local-must-match-map, and
9256 minibuffer-local-filename-must-match-map to Elisp.
9257 (syms_of_keymap): Defsubr make-composed-keymap.
9258 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9259 (parse_menu_item): Trivial simplification.
9260
3279eb87
GM
92612011-07-01 Glenn Morris <rgm@gnu.org>
9262
9263 * Makefile.in (SETTINGS_LIBS): Fix typo.
9264
4550efdf
KI
92652011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9266
9267 * coding.c (Fencode_coding_string): Record the last coding system
9268 used, as the function doc string says (bug#8738).
9269
0949d2b6
JD
92702011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9271
9272 * xsettings.c (store_monospaced_changed): Take new font as arg and
9273 check for change against current_mono_font.
9274 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9275 (emacs_settings_constructor, emacs_settings_get_property)
9276 (emacs_settings_set_property, emacs_settings_class_init)
9277 (emacs_settings_init, gsettings_obj): Remove.
9278 (something_changedCB): New function for HAVE_GSETTINGS.
9279 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9280 with value as argument.
9281 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9282 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9283 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9284 "changed".
9285
9286 * xgselect.c: Add defined (HAVE_GSETTINGS).
9287 (xgselect_initialize): Ditto.
9288
9289 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9290 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9291 xg_select.
9292
bbc6b304
PE
92932011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9294
9295 * eval.c (struct backtrace): Simplify and port the data structure.
9296 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9297 signed bit field, as this assumption is not portable and it makes
9298 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9299 "char debug_on_exit : 1" as this is not portable either; instead,
9300 use the portable "unsigned int debug_on_exit : 1". Remove unused
9301 member evalargs. Remove obsolete comments about cc bombing out.
9302
9851bfc5
JD
93032011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9304
51bb811f 9305 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9306 Let HAVE_GSETTINGS override HAVE_GCONF.
9307 (store_monospaced_changed): New function.
9308 (EMACS_SETTINGS): A new type derived from GObject to handle
9309 GSettings notifications.
9310 (emacs_settings_constructor, emacs_settings_get_property)
9311 (emacs_settings_set_property, emacs_settings_class_init):
9312 New functions.
9313 (gsettings_client, gsettings_obj): New variables.
9314 (GSETTINGS_SCHEMA): New define.
9315 (something_changedCB): Call store_monospaced_changed.
9316 (init_gsettings): New function.
9317 (xsettings_initialize): Call init_gsettings.
9318 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9319 to NULL.
9320
640c8776 9321 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9322 GCONF_CFLAGS/LIBS.
9323
5386012d
MR
93242011-06-29 Martin Rudalics <rudalics@gmx.at>
9325
9326 * window.c (resize_root_window, grow_mini_window)
9327 (shrink_mini_window): Rename Qresize_root_window to
9328 Qwindow_resize_root_window and Qresize_root_window_vertically to
9329 Qwindow_resize_root_window_vertically.
9330
f13e0b08
PE
93312011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9332
9333 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9334
94515237
JB
93352011-06-27 Juanma Barranquero <lekktu@gmail.com>
9336
9337 * makefile.w32-in: Redesign dependencies so they reflect more
9338 clearly which files are directly included by each source file,
9339 and not through other includes.
9340
e43b6e43
MR
93412011-06-27 Martin Rudalics <rudalics@gmx.at>
9342
9343 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9344 (sort_overlays, overlay_strings): When an overlay's clone number
9345 matches the window's clone number process the overlay even if
9346 the overlay's window property doesn't match the current window.
9347
d68443dc
MR
9348 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9349 (Fwindow_hchild): Rename to Fwindow_left_child.
9350 (Fwindow_next): Rename to Fwindow_next_sibling.
9351 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9352 (resize_window_check): Rename to window_resize_check.
9353 (resize_window_apply): Rename to window_resize_apply.
9354 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9355 (Fdelete_other_windows_internal, resize_frame_windows)
9356 (Fsplit_window_internal, Fdelete_window_internal)
9357 (grow_mini_window, shrink_mini_window)
9358 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9359
c7e73be5
JD
93602011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9361
9362 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9363 (emacs_fixed_set_min_size): Remove.
9364 (emacs_fixed_new): Take frame as argument.
9365
9366 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9367 (_EmacsFixedPrivate): Remove minwidth/height.
9368 Add struct frame *f.
9369 (emacs_fixed_init): Initialize priv->f.
9370 (get_parent_class, emacs_fixed_set_min_size): Remove.
9371 (emacs_fixed_new): Set priv->f to argument.
9372 (emacs_fixed_get_preferred_width)
9373 (emacs_fixed_get_preferred_height): Use min_width/height from
9374 frames size_hint to set minimum and natural (Bug#8919).
9375 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9376 and use min_width/height from frames size_hint to set
9377 min_width/height (Bug#8919).
9378
9379 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9380 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9381 Fix indentation.
c7e73be5 9382
cf99dcf8
EZ
93832011-06-26 Eli Zaretskii <eliz@gnu.org>
9384
9385 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9386 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9387 called at ZV.
9388
029529ac
CY
93892011-06-26 Chong Yidong <cyd@stupidchicken.com>
9390
9391 * process.c (wait_reading_process_output): Bypass select if
9392 waiting for a cell while ignoring keyboard input, and input is
9393 pending. Suggested by Jan Djärv (Bug#8869).
9394
7a7ef429
PE
93952011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9396
9397 Use gnulib's dup2 module instead of rolling our own.
9398 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9399
11fdef7d 94002011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9401
9402 * dispnew.c (scrolling_window): Before scrolling, turn off a
9403 mouse-highlight in the window being scrolled.
9404
cd3520a4
JB
94052011-06-24 Juanma Barranquero <lekktu@gmail.com>
9406
9407 Move DEFSYM to lisp.h and use everywhere.
9408
9409 * character.h (DEFSYM): Move declaration...
9410 * lisp.h (DEFSYM): ...here.
9411
9412 * gnutls.c:
9413 * minibuf.c:
9414 * w32menu.c:
9415 * w32proc.c:
9416 * w32select.c: Don't include character.h.
9417
9418 * alloc.c (syms_of_alloc):
9419 * buffer.c (syms_of_buffer):
9420 * bytecode.c (syms_of_bytecode):
9421 * callint.c (syms_of_callint):
9422 * casefiddle.c (syms_of_casefiddle):
9423 * casetab.c (init_casetab_once):
9424 * category.c (init_category_once, syms_of_category):
9425 * ccl.c (syms_of_ccl):
9426 * cmds.c (syms_of_cmds):
9427 * composite.c (syms_of_composite):
9428 * dbusbind.c (syms_of_dbusbind):
9429 * dired.c (syms_of_dired):
9430 * dispnew.c (syms_of_display):
9431 * doc.c (syms_of_doc):
9432 * editfns.c (syms_of_editfns):
9433 * emacs.c (syms_of_emacs):
9434 * eval.c (syms_of_eval):
9435 * fileio.c (syms_of_fileio):
9436 * fns.c (syms_of_fns):
9437 * frame.c (syms_of_frame):
9438 * fringe.c (syms_of_fringe):
9439 * insdel.c (syms_of_insdel):
9440 * keymap.c (syms_of_keymap):
9441 * lread.c (init_obarray, syms_of_lread):
9442 * macros.c (syms_of_macros):
9443 * msdos.c (syms_of_msdos):
9444 * print.c (syms_of_print):
9445 * process.c (syms_of_process):
9446 * search.c (syms_of_search):
9447 * sound.c (syms_of_sound):
9448 * syntax.c (init_syntax_once, syms_of_syntax):
9449 * terminal.c (syms_of_terminal):
9450 * textprop.c (syms_of_textprop):
9451 * undo.c (syms_of_undo):
9452 * w32.c (globals_of_w32):
9453 * window.c (syms_of_window):
9454 * xdisp.c (syms_of_xdisp):
9455 * xfaces.c (syms_of_xfaces):
9456 * xfns.c (syms_of_xfns):
9457 * xmenu.c (syms_of_xmenu):
9458 * xsettings.c (syms_of_xsettings):
9459 * xterm.c (syms_of_xterm): Use DEFSYM.
9460
4228cf16
TZ
94612011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9462
cd3520a4 9463 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9464
7fcccf1e
PE
94652011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9466
7efb4e0e
PE
9467 Integer and buffer overflow fixes (Bug#8873).
9468
ff5844ad
PE
9469 * print.c (printchar, strout): Check for string overflow.
9470 (PRINTPREPARE, printchar, strout):
9471 Don't set size unless allocation succeeds.
9472
90532f02
PE
9473 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9474 for sizes. Check for string overflow more accurately.
9475 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9476
6d84508d
PE
9477 * macros.c: Integer and buffer overflow fixes.
9478 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9479 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9480 Use ptrdiff_t, not int, for sizes.
9481 Don't increment bufsize until after realloc succeeds.
9482 Check for size-calculation overflow.
9483 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9484
437b2cb4
PE
9485 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9486
8b9ac8b4
PE
9487 * lread.c: Integer overflow fixes.
9488 (read_integer): Radix is now EMACS_INT, not int,
9489 to improve quality of diagnostics for out-of-range radices.
9490 Calculate buffer size correctly for out-of-range radices.
9491 (read1): Check for integer overflow in radices, and in
9492 read-circle numbers.
82cb60d3
PE
9493 (read_escape): Avoid int overflow.
9494 (Fload, openp, read_buffer_size, read1)
9495 (substitute_object_recurse, read_vector, read_list, map_obarray):
9496 Use ptrdiff_t, not int, for sizes.
9497 (read1): Use EMACS_INT, not int, for sizes.
20270765 9498 Check for size overflow.
8b9ac8b4 9499
7fcccf1e
PE
9500 * image.c (cache_image): Check for size arithmetic overflow.
9501
bfbbd7e7
PE
9502 * lread.c: Integer overflow issues.
9503 (saved_doc_string_size, saved_doc_string_length)
9504 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9505 Now ptrdiff_t, not int.
9506 (read1): Don't assume doc string length fits in int. Check for
9507 out-of-range doc string lengths.
9508 (read_list): Don't assume file position fits in int.
39019e54 9509 (read_escape): Check for hex character overflow.
bfbbd7e7 9510
4e323265
LL
95112011-06-22 Leo Liu <sdl.web@gmail.com>
9512
9513 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9514 Move to minibuffer.el.
9515
85fece3e
PE
95162011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9517
20b84ce9 9518 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9519 The following patches are for when GLYPH_DEBUG && !XASSERT.
9520 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9521 * dispnew.c (flush_stdout):
9522 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9523 Mark as externally visible.
9524 * dispnew.c (check_window_matrix_pointers): Now static.
9525 * dispnew.c (window_to_frame_vpos):
9526 * xfns.c (unwind_create_frame):
9527 * xterm.c (x_check_font): Remove unused local.
9528 * scroll.c (CHECK_BOUNDS):
9529 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9530 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9531 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9532 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9533 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9534 Now static.
9535 (debug_method_add): Use va_list and vsprintf rather than relying
9536 on undefined behavior with wrong number of arguments.
9537 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9538 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9539 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9540 since we're not interested in debugging glyphs with old libraries.
9541 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9542 GCC 4.6.0's static checking.
9543
0766b489
PE
95442011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9545
31fd4b32
PE
9546 Integer overflow and signedness fixes (Bug#8873).
9547 A few related buffer overrun fixes, too.
9548
b79e8648
PE
9549 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9550
0766b489
PE
9551 * dispextern.h (struct face.stipple):
9552 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9553 (x_bitmap_mask, x_allocate_bitmap_record)
9554 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9555 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9556 (x_create_bitmap_from_xpm_data):
9557 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9558 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9559 (.bitmaps_last):
9560 * xfaces.c (load_pixmap):
9561 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9562 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9563 (.bitmaps_last, struct x_output.icon_bitmap):
9564 Use ptrdiff_t, not int, for bitmap indexes.
9565 (x_allocate_bitmap_record): Check for size overflow.
9566 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9567
b081724f
PE
9568 Use ptrdiff_t, not int, for overlay counts.
9569 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9570 * editfns.c (overlays_around, get_pos_property):
9571 * textprop.c (get_char_property_and_overlay):
9572 * xdisp.c (next_overlay_change, note_mouse_highlight):
9573 * xfaces.c (face_at_buffer_position):
21514da7
PE
9574 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9575 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9576 (Fnext_overlay_change, Fprevious_overlay_change)
9577 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9578 Use ptrdiff_t, not int, for sizes.
21514da7 9579 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9580
3de73e5e
PE
9581 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9582
2606c57b
PE
9583 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9584 (x_session_initialize): Do not assume string length fits in int.
9585
aaafe47a
PE
9586 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9587 This is unlikely, but can occur if DPI is outlandish.
9588
2674ddc8 9589 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9590 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9591
28154962
PE
9592 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9593 * xrdb.c (magic_file_p, search_magic_path):
9594 Omit last arg SUFFIX; it was always 0. All callers changed.
9595 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9596
7de51af5
PE
9597 * xfont.c (xfont_match): Avoid need for strlen.
9598
25ed6cc3
PE
9599 * xfns.c: Don't assume strlen fits in int.
9600 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9601
4eab31dd
PE
9602 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9603 not unsigned long, as we prefer signed integers. All callers changed.
9604 Detect integer overflow in repeat count.
9605 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9606 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9607
171e2a58
PE
9608 * termcap.c: Don't assume sizes fit in int and never overflow.
9609 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9610 (gobble_line): Check for size-calculation overflow.
9611
ad39faca 9612 * minibuf.c (Fread_buffer):
6e5bb2dc 9613 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9614 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9615 Don't assume string length fits in int.
9616
52c61c22 9617 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9618 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9619
b5b8c9e5
PE
9620 * font.c: Don't assume string length fits in int.
9621 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9622 Use ptrdiff_t, not int.
ccd6111c
PE
9623 (font_intern_prop): Don't assume string length fits in int.
9624 Don't assume integer property fits in fixnum.
9625 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9626
882f0d81 9627 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9628 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9629 Reformulate so as not to need the command string.
9630 Invoke gzip -cd rather than gunzip, as it's more portable.
9631 (lock_info_type, lock_file_1, lock_file):
9632 Don't assume pid_t and time_t fit in unsigned long.
9633 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9634 (current_lock_owner): Prefer signed type for sizes.
9635 Use memcpy, not strncpy, where memcpy is what is really wanted.
9636 Don't assume (via atoi) that time_t and pid_t fit in int.
9637 Check for time_t and/or pid_t out of range, e.g., via a network share.
9638 Don't alloca where an auto var works fine.
9639
93f4cf88
PE
9640 * fileio.c: Fix some integer overflow issues.
9641 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9642 Don't assume string length fits in int.
9643 (directory_file_name): Don't assume string length fits in long.
9644 (make_temp_name): Don't assume pid fits in int, or that its print
9645 length is less than 20.
9646
f3e92b69
PE
9647 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9648
1bfdaf10
PE
9649 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9650
35016e9a
PE
9651 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9652
3d1e65a1
PE
9653 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9654 We prefer signed integers, even for size calculations.
9655
0b963a93
PE
9656 * emacs.c: Don't assume string length fits in 'int'.
9657 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9658 (main): Don't invoke strlen when not needed.
9659
573f4b54
PE
9660 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9661 (XD_DEBUG_MESSAGE): Don't waste a byte.
9662
989f33ba
PE
9663 * callproc.c (getenv_internal_1, getenv_internal)
9664 (Fgetenv_internal):
965d34eb
PE
9665 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9666
e4d29b33
PE
9667 * lread.c (invalid_syntax): Omit length argument.
9668 All uses changed. This doesn't fix a bug, but it simplifies the
9669 code away from its former Hollerith-constant appearance, and it's
9670 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9671 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9672
eb49b136
PE
9673 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9674 This didn't break anything, but it didn't help either.
9675 It's confusing to put a bogus integer in a place where the actual
9676 value does not matter.
9f62aeb1 9677 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9678 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9679
15375a22
PE
9680 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9681 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9682 implementation.
b61cc01c
PE
9683 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9684 We prefer signed types, and the value cannot exceed the EMACS_INT
9685 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9686 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9687 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9688 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9689
53b2623d
PE
9690 * indent.c (sane_tab_width): New function.
9691 (current_column, scan_for_column, Findent_to, position_indentation)
9692 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9693 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9694
51cab52b 9695 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9696
f2ed8a70
PE
9697 * lisp.h (lint_assume): New macro.
9698 * composite.c (composition_gstring_put_cache):
9699 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9700
abe80cc6
PE
9701 * editfns.c, insdel.c:
9702 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9703
b02c740e
PE
9704 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9705
ebc96716
PE
9706 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9707
b4e50fa0 9708 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9709 Use much-faster test for byte-length change.
311d5d7c 9710 Don't assume string byte-length fits in 'int'.
a4cf38e4 9711 Check that character arg fits in 'int'.
85461888 9712 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9713
c0c1ee9f
PE
9714 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9715
a498d7f4
PE
9716 * fns.c (concat): Catch string overflow earlier.
9717 Do not rely on integer wraparound.
9718
51cab52b
PE
9719 * dispextern.h (struct it.overlay_strings_charpos)
9720 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9721 * xdisp.c (forward_to_next_line_start)
9722 (back_to_previous_visible_line_start)
9723 (reseat_at_next_visible_line_start, next_element_from_buffer):
9724 Don't arbitrarily truncate the value of 'selective' to int.
9725
76031fad
PE
9726 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9727
5eb55db9
PE
9728 * composite.c: Don't truncate sizes to 'int'.
9729 (composition_gstring_p, composition_reseat_it)
9730 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9731 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9732 not EMACS_UINT, for indexes.
5eb55db9 9733
0703a717
PE
9734 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9735
d6202519
PE
9736 * buffer.c: Include <verify.h>.
9737 (struct sortvec.priority, struct sortstr.priority):
8961a454 9738 Now EMACS_INT, not int.
c20998a7 9739 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9740 (struct sortstr.size, record_overlay_string)
9741 (struct sortstrlist.size, struct sortlist.used):
9742 Don't truncate size to int.
9743 (record_overlay_string): Check for size-calculation overflow.
d6202519 9744 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9745
d5a19415
JM
97462011-06-22 Jim Meyering <meyering@redhat.com>
9747
029529ac 9748 Don't leak an XBM-image-sized buffer
d5a19415
JM
9749 * image.c (xbm_load): Free the image buffer after using it.
9750
a9041e6c
PE
97512011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9752
9753 Port to Sun C.
9754 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9755 that Sun C diagnosed.
9756 * fns.c (secure_hash): Fix pointer signedness issue.
9757 * intervals.c (static_offset_intervals): New function.
9758 (offset_intervals): Use it.
9759
7f3f739f
LL
97602011-06-21 Leo Liu <sdl.web@gmail.com>
9761
9762 * deps.mk (fns.o):
9763 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9764 sha512.h.
9765
9766 * fns.c (secure_hash): Rename from crypto_hash_function and change
9767 the first arg to accept symbols.
5b66d427 9768 (Fsecure_hash): New primitive.
7f3f739f
LL
9769 (syms_of_fns): New symbols.
9770
76147d94
DD
97712011-06-20 Deniz Dogan <deniz@dogan.se>
9772
9773 * process.c (Fset_process_buffer): Clarify return value in
9774 docstring.
9775
7d7d0045
CY
97762011-06-18 Chong Yidong <cyd@stupidchicken.com>
9777
9778 * dispnew.c (add_window_display_history): Use BVAR.
9779
9780 * xdisp.c (debug_method_add): Use BVAR.
9781 (check_window_end, dump_glyph_matrix, dump_glyph)
9782 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9783
9784 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9785 Likewise.
9786
9787 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9788 check till after the cache is created in init_frame_faces.
9789
ff2bc410
SM
97902011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9791
9792 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9793
28177add
PE
97942011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9795
dd3482fe
PE
9796 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9797 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9798 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9799
393d71f3 9800 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9801 * fileio.c (Finsert_file_contents):
9802 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9803 Remove the old (too-loose) buffer overflow checks.
9804 They weren't needed, since make_gap checks for buffer overflow.
9805 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9806 The old code merely checked for Emacs fixnum overflow, and relied
9807 on undefined (wraparound) behavior. The new code avoids undefined
9808 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9809
2e6813b0 9810 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9811 Tune. Don't use wider integers than needed. Don't use alloca.
9812 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9813
599a9e4f
PE
9814 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9815
99561444
PE
9816 * insdel.c, lisp.h (buffer_overflow): New function.
9817 (insert_from_buffer_1, replace_range, replace_range_2):
9818 * insdel.c (make_gap_larger):
9819 * editfns.c (Finsert_char):
9820 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9821
28177add
PE
9822 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9823
e69dafad
PE
98242011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9825
4baa020d 9826 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9827
b1c46f02
PE
9828 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9829 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9830
e69dafad
PE
9831 * fileio.c: Don't assume EMACS_INT fits in off_t.
9832 (emacs_lseek): New static function.
9833 (Finsert_file_contents, Fwrite_region): Use it.
9834 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9835
566684ea
PE
9836 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9837
e6966cd6
PE
9838 * fns.c: Don't overflow int when computing a list length.
9839 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9840 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9841 truncation on 64-bit hosts. Check for QUIT every
9842 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9843 faster and is responsive enough.
9844 (Flength): Report an error instead of overflowing an integer.
9845 (Fsafe_length): Return a float if the value is not representable
9846 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9847 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9848 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9849
dd0b0efb
PE
9850 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9851 (header_size, word_size): New constants.
9852 (allocate_vectorlike): Don't check size overflow here.
9853 (allocate_vector): Check it here instead, since this is the only
9854 caller of allocate_vectorlike that could cause overflow.
9855 Check that the new vector's length is representable as a fixnum.
9856
86fe5cfe
PE
9857 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9858 The previous code was bogus. For example, next_almost_prime (32)
9859 returned 39, which is undesirable as it is a multiple of 3; and
9860 next_almost_prime (24) returned 25, which is a multiple of 5 so
9861 why was the code bothering to check for multiples of 7?
9862
80e88859
PE
9863 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9864
4a2f0ad6
PE
9865 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9866
f66c7cf8
PE
9867 Variadic C functions now count arguments with ptrdiff_t.
9868 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9869 Back then I didn't know that the Emacs coding style prefers signed int.
9870 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9871 were being counted with int, which may truncate counts on 64-bit
9872 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9873 * lisp.h (struct Lisp_Subr.function.aMANY)
9874 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9875 Arg counts are now ptrdiff_t, not size_t.
9876 All variadic functions and their callers changed accordingly.
9877 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9878 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9879 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9880 * callint.c (Fcall_interactively): Check arg count for overflow,
9881 to avoid potential buffer overrun. Use signed char, not 'int',
9882 for 'varies' array, so that we needn't bother to check its size
9883 calculation for overflow.
9884 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9885 * eval.c (apply_lambda):
9886 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9887 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9888 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9889
a1759b76
PE
9890 * callint.c (Fcall_interactively): Don't use index var as event count.
9891
d96be9fc
PE
9892 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9893 * mem-limits.h (SIZE): Remove; no longer used.
9894
a690a978 9895 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9896
578c21e6
PE
9897 Remove unnecessary casts.
9898 * xterm.c (x_term_init):
9899 * xfns.c (x_set_border_pixel):
9900 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9901 These aren't needed now that we assume ANSI C.
9902
96f53c6c
PE
9903 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9904 It's more likely to cause problems (due to unsigned overflow)
9905 than to cure them.
9906
83c77d31
PE
9907 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9908
ee2079f1
PE
9909 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9910
6da65536
PE
9911 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9912
7147c4a4
PE
9913 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9914
193e32d9
PE
9915 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9916
e5533da6
PE
9917 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9918
9910e595
PE
9919 GLYPH_CODE_FACE returns EMACS_INT, not int.
9920 * dispextern.h (merge_faces):
9921 * xfaces.c (merge_faces):
01103c44
PE
9922 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9923 Don't assume EMACS_INT fits in int.
9910e595 9924
2638320e
PE
9925 * character.h (CHAR_VALID_P): Remove unused parameter.
9926 * fontset.c, lisp.h, xdisp.c: All uses changed.
9927
045eb8d9
PE
9928 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9929
c1f134b5
PE
9930 * fns.c (concat): Minor tuning based on overflow analysis.
9931 This doesn't fix any bugs. Use int to hold character, instead
9932 of constantly refetching from Emacs object. Use XFASTINT, not
9933 XINT, for value known to be a character. Don't bother comparing
9934 a single byte to 0400, as it's always less.
9935
395fcb93 9936 * floatfns.c (Fexpt):
327eeec8
PE
9937 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9938
abbd3d23
PE
9939 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9940 for characters.
9941
684a03ef
PE
9942 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9943
0fed43f3
PE
9944 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9945 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9946 incorrectly succeed when S was a string, because 4294967386 was
9947 truncated before it was used.
9948
8fd02eb7
PE
9949 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9950 Otherwise, an out-of-range integer could cause undefined behavior
9951 on a 64-bit host.
9952
f8c86b69
PE
9953 * composite.c: Use int, not EMACS_INT, for characters.
9954 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9955 EMACS_INT, for values that are known to be in character range.
9956 This doesn't fix any bugs but is the usual style inside Emacs and
9957 may generate better code on 32-bit machines.
9958
34206dd2
PE
9959 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9960 This is for reasons similar to the recent CHAR_STRING fix.
9961 * charset.c (Fencode_char): Check that character arg is actually
9962 a character. Pass an int to ENCODE_CHAR.
9963 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9964 wider than 'int', as a compile-time check to prevent future regressions
9965 in this area.
9966
c5958d4c 9967 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9968
9969 Make sure a 64-bit char is never passed to CHAR_STRING.
9970 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9971 by silently ignoring the top 32 bits, allowing some values
9972 that were far too large to be valid characters.
9973 * character.h: Include <verify.h>.
9974 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9975 arguments are no wider than unsigned, as a compile-time check
9976 to prevent future regressions in this area.
9977 * data.c (Faset):
01103c44 9978 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9979 (Fsubst_char_in_region):
9980 * fns.c (concat):
9981 * xdisp.c (decode_mode_spec_coding):
9982 Adjust to CHAR_STRING's new requirement.
9983 * editfns.c (Finsert_char, Fsubst_char_in_region):
9984 * fns.c (concat): Check that character args are actually
9985 characters. Without this test, these functions did the wrong
9986 thing with wildly out-of-range values on 64-bit hosts.
9987
d37ca623
PE
9988 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9989 These casts should not be needed on 32-bit hosts, either.
9990 * keyboard.c (read_char):
9991 * lread.c (Fload): Remove casts to unsigned.
9992
ea204efb
PE
9993 * lisp.h (UNSIGNED_CMP): New macro.
9994 This fixes comparison bugs on 64-bit hosts.
9995 (ASCII_CHAR_P): Use it.
9996 * casefiddle.c (casify_object):
01103c44 9997 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9998 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9999 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10000 * dispextern.h (FACE_FROM_ID):
10001 * keyboard.c (read_char): Use UNSIGNED_CMP.
10002
41cb286c
PE
10003 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10004 not to EMACS_INT, to avoid GCC warning.
10005
4a1b9832
PE
10006 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10007
55daad71
PE
10008 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10009 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10010 isn't needed on 32-bit machines.
8f95c75c 10011
01103c44
PE
10012 * buffer.c (Fgenerate_new_buffer_name):
10013 Use EMACS_INT for count, not int.
0ceccced 10014 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10015
10016 * data.c (Qcompiled_function): Now static.
10017
c6f072e7
PE
10018 * window.c (window_body_lines): Now static.
10019
20ce5912
PE
10020 * image.c (gif_load): Rename local to avoid shadowing.
10021
9c4c5f81
PE
10022 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10023 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10024 * alloc.c (make_save_value): Integer argument is now of type
10025 ptrdiff_t, not int.
10026 (mark_object): Use ptrdiff_t, not int.
10027 * lisp.h (pD): New macro.
10028 * print.c (print_object): Use it.
10029
c0c5c8ae
PE
10030 * alloc.c: Use EMACS_INT, not int, to count objects.
10031 (total_conses, total_markers, total_symbols, total_vector_size)
10032 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10033 (total_free_floats, total_floats, total_free_intervals)
10034 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10035 Now EMACS_INT, not int. All uses changed.
10036 (Fgarbage_collect): Compute overall total using a double, so that
10037 integer overflow is less likely to be a problem. Check for overflow
10038 when converting back to an integer.
5a25e253
PE
10039 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10040 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10041 These were 'int' variables that could overflow on 64-bit hosts;
10042 they were never used, so remove them instead of repairing them.
211a0b2a 10043 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10044 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10045 Previously, this ceilinged at INT_MAX, but that doesn't work on
10046 64-bit machines.
e46bb31a 10047 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10048
c78baabf 10049 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10050 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10051 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10052 when a (possibly-narrower) signed value would do just as well.
10053 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10054
c9d624c6
PE
10055 * alloc.c: Catch some string size overflows that we were missing.
10056 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10057 for convenience in STRING_BYTES_MAX.
10058 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10059 The definition here is exact; the one in lisp.h was approximate.
10060 (allocate_string_data): Check for string overflow. This catches
10061 some instances we weren't catching before. Also, it catches
10062 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10063 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10064 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10065
c9d624c6
PE
10066 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10067 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10068 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10069
353032ce
PE
10070 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10071
2bccce07
PE
10072 * alloc.c (Fmake_string): Check for out-of-range init.
10073
0ac30604
SM
100742011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10075
10076 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10077
c195f2de
JD
100782011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10079
10080 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10081 xg_get_default_scrollbar_width.
10082
10083 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10084 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10085 (style_changed_cb): Call update_theme_scrollbar_width and call
10086 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10087 all frames (Bug#8505).
10088 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10089 Call gtk_window_set_resizable if HAVE_GTK3.
10090 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10091 and height if HAVE_GTK3 (Bug#8505).
10092 (scroll_bar_width_for_theme): New variable.
10093 (update_theme_scrollbar_width): New function.
10094 (xg_get_default_scrollbar_width): Move code to
10095 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10096 (xg_initialize): Call update_theme_scrollbar_width.
10097
10098 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10099
10100 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10101
e10ac9f1
MR
101022011-06-12 Martin Rudalics <rudalics@gmx.at>
10103
10104 * frame.c (make_frame): Call other_buffer_safely instead of
10105 other_buffer.
10106
10107 * window.c (temp_output_buffer_show): Call display_buffer with
10108 second argument Vtemp_buffer_show_specifiers and reset latter
10109 immediately after the call.
10110 (Vtemp_buffer_show_specifiers): New variable.
10111 (auto_window_vscroll_p, next_screen_context_lines)
10112 (Vscroll_preserve_screen_position): Remove leading asterisks from
10113 doc-strings.
10114
2d3c217e 101152011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10116
7b7f97e8 10117 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10118 * buffer.c (Qclone_number): Remove for now, as it's unused.
10119 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10120 (record_buffer): Remove unused local.
10121 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10122 (set_frame_buffer_list): Remove; unused.
10123 * frame.h (other_visible_frames): Remove decl.
10124 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10125 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10126 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10127 if HAVE_GPM.
10128 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10129 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10130 Define only if HAVE_GPM.
10131 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10132 (update_hints_inhibit): Remove; never set. All uses removed.
10133 * widgetprv.h (emacsFrameClassRec): Remove decl.
10134 * window.c (delete_deletable_window): Now returns void, since it
10135 wasn't returning anything.
10136 (compare_window_configurations): Remove unused locals.
10137 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10138 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10139 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10140 the same widths as pointers. This follows up on the 2011-05-06 patch.
10141 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10142 * xterm.h: Likewise.
10143 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10144
1384b89e
JB
101452011-06-12 Juanma Barranquero <lekktu@gmail.com>
10146
10147 * makefile.w32-in: Update dependencies.
10148 (LISP_H): Add lib/intprops.h.
10149
1100a63c
CY
101502011-06-11 Chong Yidong <cyd@stupidchicken.com>
10151
10152 * image.c (gif_load): Add animation frame delay to the metadata.
10153 (syms_of_image): Use DEFSYM. New symbol `delay'.
10154
6198ccd0
MR
101552011-06-11 Martin Rudalics <rudalics@gmx.at>
10156
10157 * window.c (delete_deletable_window): Re-add.
10158 (Fset_window_configuration): Rewrite to handle dead buffers and
10159 consequently deletable windows.
10160 (window_tree, Fwindow_tree): Remove. Supply functionality in
10161 window.el.
10162 (compare_window_configurations): Simplify code.
10163
b6e3633c
AS
101642011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10165
1ab0dee5
AS
10166 * image.c (imagemagick_load_image): Fix type mismatch.
10167 (Fimagemagick_types): Likewise.
10168
b6e3633c
AS
10169 * window.h (replace_buffer_in_windows): Declare.
10170
9397e56f
MR
101712011-06-11 Martin Rudalics <rudalics@gmx.at>
10172
10173 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10174 Qclone_number. Remove external declaration of Qdelete_window.
10175 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10176 code.
640c8776
SM
10177 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10178 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10179 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10180 buffer list implementation.
10181 (other_buffer_safely): New function.
10182 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10183 calls to replace_buffer_in_windows and
10184 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10185 if allowed.
10186 (record_buffer): Inhibit quitting and rewrite using quittable
10187 functions. Run Qbuffer_list_update_hook if allowed.
10188 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10189 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10190 Move switch-to-buffer to window.el.
9397e56f
MR
10191 (bury-buffer): Move to window.el.
10192 (Vbuffer_list_update_hook): New variable.
10193
10194 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10195 section.
10196
10197 * window.h (resize_frame_windows): Move up in code.
10198 (Fwindow_frame): Remove EXFUN.
10199 (replace_buffer_in_all_windows): Remove prototype.
10200 (replace_buffer_in_windows_safely): Add prototype.
10201
10202 * window.c: Declare Qdelete_window static again. Move down
10203 declaration of select_count.
10204 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10205 (Fother_window): Move to window.el.
10206 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10207 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10208 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10209 window.el.
10210 (replace_buffer_in_windows): Implement by calling
10211 Qreplace_buffer_in_windows.
10212 (replace_buffer_in_all_windows): Remove with some functionality
10213 moved into replace_buffer_in_windows_safely.
10214 (replace_buffer_in_windows_safely): New function.
10215 (select_window_norecord, select_frame_norecord): Move in front
10216 of run_window_configuration_change_hook. Remove now obsolete
10217 declarations.
640c8776
SM
10218 (Fset_window_buffer): Rewrite doc-string.
10219 Call Qrecord_window_buffer.
9397e56f
MR
10220 (keys_of_window): Move binding for other-window to window.el.
10221
b50691aa
CY
102222011-06-11 Chong Yidong <cyd@stupidchicken.com>
10223
10224 * dispextern.h (struct image): Replace data member, whose int_val
10225 and ptr_val fields were not used by anything, with a single
10226 lisp_val object.
10227
10228 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10229 (gif_clear_image, gif_load, imagemagick_load_image)
10230 (gs_clear_image, gs_load): Callers changed.
10231
3f754b86
PE
102322011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10233
cca69397
PE
10234 * buffer.h: Include <time.h>, for time_t.
10235 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10236
109e28d0
PE
10237 Fix minor problems found by static checking.
10238
60737f02
PE
10239 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10240
4b66faf3
PE
10241 Make identifiers static if they are not used in other modules.
10242 * data.c (Qcompiled_function, Qframe, Qvector):
10243 * image.c (QimageMagick, Qsvg):
10244 * minibuf.c (Qmetadata):
10245 * window.c (resize_window_check, resize_root_window): Now static.
10246 * window.h (resize_window_check, resize_root_window): Remove decls.
10247
109e28d0
PE
10248 * window.c (window_deletion_count, delete_deletable_window):
10249 Remove; unused.
46a4ce9e
PE
10250 (window_body_lines): Now static.
10251 (Fdelete_other_windows_internal): Mark vars as initialized.
10252 Make sure 'resize_failed' is initialized.
10253 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10254 (resize_window_apply): Remove unused local.
10255 * window.h (delete_deletable_window): Remove decl.
10256
109e28d0 10257 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10258 (imagemagick_load_image): Fix pointer signedness problem by changing
10259 last arg from unsigned char * to char *. All uses changed.
10260 Also, fix a local for similar reasons.
10261 Remove unused locals. Remove locals to avoid shadowing.
10262 (fn_rsvg_handle_free): Remove; unused.
10263 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10264 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10265
3f754b86
PE
10266 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10267
2547adb1
CY
102682011-06-10 Chong Yidong <cyd@stupidchicken.com>
10269
10270 * image.c (gif_load): Fix omitted cast error introduced by
10271 2011-06-06 change.
10272
2c8e37d4
MR
102732011-06-10 Martin Rudalics <rudalics@gmx.at>
10274
10275 * window.h (resize_proportionally, orig_total_lines)
10276 (orig_top_line): Remove from window structure.
10277 (set_window_height, set_window_width, change_window_heights)
10278 (Fdelete_window): Remove prototypes.
10279 (resize_frame_windows): Remove duplicate declaration.
10280
440a42e3
EZ
102812011-06-10 Eli Zaretskii <eliz@gnu.org>
10282
10283 * window.h (resize_frame_windows, resize_window_check)
10284 (delete_deletable_window, resize_root_window)
10285 (resize_frame_windows): Declare prototypes.
10286
10287 * window.c (resize_window_apply): Make definition be "static" to
10288 match the prototype.
10289
562dd5e9
MR
102902011-06-10 Martin Rudalics <rudalics@gmx.at>
10291
10292 * window.c: Remove declarations of Qwindow_size_fixed,
10293 window_min_size_1, window_min_size_2, window_min_size,
10294 size_window, window_fixed_size_p, enlarge_window, delete_window.
10295 Remove static from declaration of Qdelete_window, it's
10296 temporarily needed by Fbury_buffer.
10297 (replace_window): Don't assign orig_top_line and
10298 orig_total_lines.
10299 (Fdelete_window, delete_window): Remove. Window deletion is
10300 handled by window.el.
640c8776
SM
10301 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10302 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10303 (Fdelete_other_windows): Remove. Deleting other windows is
10304 handled by window.el.
10305 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10306 handled in window.el.
10307 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10308 Window minimum sizes are handled in window.el.
10309 (shrink_windows, size_window, set_window_height)
10310 (set_window_width, change_window_heights, window_height)
10311 (window_width, CURBEG, CURSIZE, enlarge_window)
10312 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10313 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10314 handled in window.el.
10315 (make_dummy_parent): Rename to make_parent_window and give it a
10316 second argument horflag.
10317 (make_window): Don't set resize_proportionally any more.
10318 (Fsplit_window): Remove. Windows are split in window.el.
10319 (save_restore_action, save_restore_orig_size)
10320 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10321 Resize mini windows in window.el.
10322 (grow_mini_window, shrink_mini_window): Implement by calling
10323 Qresize_root_window_vertically, resize_window_check and
10324 resize_window_apply.
640c8776
SM
10325 (saved_window, Fset_window_configuration, save_window_save):
10326 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10327 resize_proportionally.
10328 (window_min_height, window_min_width): Move to window.el.
10329 (keys_of_window): Move bindings for delete-other-windows,
10330 split-window, delete-window and enlarge-window to window.el.
10331
10332 * buffer.c: Temporarily extern Qdelete_window.
10333 (Fbury_buffer): Temporarily call Qdelete_window instead of
10334 Fdelete_window (Fbury_buffer will move to window.el soon).
10335
10336 * frame.c (set_menu_bar_lines_1): Remove code handling
10337 orig_top_line and orig_total_lines.
10338
10339 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10340 set_window_height but set heights directly.
10341 (change_frame_size_1): Use resize_frame_windows.
10342
10343 * xdisp.c (init_xdisp): Don't use set_window_height but set
10344 heights directly.
10345
640c8776
SM
10346 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10347 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10348 run_window_configuration_change_hook.
10349
10350 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10351 instead of change_window_heights and run
10352 run_window_configuration_change_hook.
10353
1a13852e
MR
103542011-06-09 Martin Rudalics <rudalics@gmx.at>
10355
10356 * window.c (replace_window): Rename second argument REPLACEMENT to
10357 NEW. New third argument SETFLAG. Rewrite.
10358 (delete_window, make_dummy_parent): Call replace_window with
10359 third argument 1.
10360 (window_list_1): Move down in code.
10361 (run_window_configuration_change_hook): Move set_buffer part
10362 before select_frame_norecord part in order to unwind correctly.
10363 Rename count1 to count.
10364 (recombine_windows, delete_deletable_window, resize_root_window)
10365 (Fdelete_other_windows_internal)
10366 (Frun_window_configuration_change_hook, make_parent_window)
10367 (resize_window_check, resize_window_apply, Fresize_window_apply)
10368 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10369 (Fdelete_window_internal, Fresize_mini_window_internal):
10370 New functions.
1a13852e
MR
10371 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10372
f3d1777e
MR
103732011-06-08 Martin Rudalics <rudalics@gmx.at>
10374
496e208e
MR
10375 * window.h (window): Add some new members to window structure -
10376 normal_lines, normal_cols, new_total, new_normal, clone_number,
10377 splits, nest, prev_buffers, next_buffers.
10378 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10379 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10380
f3d1777e
MR
10381 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10382 Remove.
496e208e
MR
10383 (make_dummy_parent): Set new members of windows structure.
10384 (make_window): Move down in code. Handle new members of window
10385 structure.
10386 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10387 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10388 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10389 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10390 (Fset_window_next_buffers, Fset_window_clone_number):
10391 New functions.
496e208e
MR
10392 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10393 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10394 Doc-string fixes.
10395 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10396 Argument WINDOW can be now internal window too.
10397 (Fwindow_use_time): Move up in code.
10398 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10399 Rewrite doc-string.
10400 (Fset_window_configuration, saved_window)
10401 (Fcurrent_window_configuration, save_window_save): Handle new
10402 members of window structure.
b9e809c2
MR
10403 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10404 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10405 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10406 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10407 Qget_mru_window, Qresize_root_window,
10408 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10409 Qauto_buffer_name; staticpro them.
f3d1777e 10410
abde8f8c
MR
104112011-06-07 Martin Rudalics <rudalics@gmx.at>
10412
10413 * window.c (Fwindow_total_size, Fwindow_left_column)
10414 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10415 (Fwindow_list_1): New functions.
10416 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10417 (Fwindow_width, Fscroll_left, Fscroll_right):
10418 Use window_body_cols instead of window_box_text_cols.
10419 (delete_window, Fset_window_configuration):
10420 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10421 (delete_all_subwindows): Take a window as argument and not a
10422 structure. Rewrite.
190b47e6
MR
10423 (window_loop): Remove handling of GET_LRU_WINDOW and
10424 GET_LARGEST_WINDOW.
10425 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10426
10427 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10428 window_box_text_cols. delete_all_subwindows now takes a
10429 Lisp_Object as argument.
abde8f8c 10430
640c8776
SM
10431 * indent.c (compute_motion, Fcompute_motion):
10432 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10433
fa8a67e6
MR
10434 * frame.c (delete_frame): Call delete_all_subwindows with root
10435 window as argument.
10436
a54e3482
DC
104372011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10438
10439 * fns.c (Fputhash): Document return value.
10440
60002bf5
CY
104412011-06-06 Chong Yidong <cyd@stupidchicken.com>
10442
10443 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10444
0c671da6 104452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10446
b862a52a 10447 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10448
be44ca6c
PE
10449 Check for overflow when converting integer to cons and back.
10450 * charset.c (Fdefine_charset_internal, Fdecode_char):
10451 Use cons_to_unsigned to catch overflow.
10452 (Fencode_char): Use INTEGER_TO_CONS.
10453 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10454 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10455 * data.c (long_to_cons, cons_to_long): Remove.
10456 (cons_to_unsigned, cons_to_signed): New functions.
10457 These signal an error for invalid or out-of-range values.
10458 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10459 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10460 * font.c (Ffont_variation_glyphs):
10461 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10462 * lisp.h: Include <intprops.h>.
10463 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10464 (cons_to_signed, cons_to_unsigned): New decls.
10465 (long_to_cons, cons_to_long): Remove decls.
10466 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10467 (Fprimitive_undo): Use CONS_TO_INTEGER.
10468 * xfns.c (Fx_window_property): Likewise.
10469 * xselect.c: Include <limits.h>.
10470 (x_own_selection, selection_data_to_lisp_data):
10471 Use INTEGER_TO_CONS.
10472 (x_handle_selection_request, x_handle_selection_clear)
10473 (x_get_foreign_selection, Fx_disown_selection_internal)
10474 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10475 (lisp_data_to_selection_data): Use cons_to_unsigned.
10476 (x_fill_property_data): Use cons_to_signed.
10477 Report values out of range.
10478
d1f3d2af
PE
10479 Check for buffer and string overflow more precisely.
10480 * buffer.h (BUF_BYTES_MAX): New macro.
10481 * lisp.h (STRING_BYTES_MAX): New macro.
10482 * alloc.c (Fmake_string):
10483 * character.c (string_escape_byte8):
10484 * coding.c (coding_alloc_by_realloc):
10485 * doprnt.c (doprnt):
10486 * editfns.c (Fformat):
10487 * eval.c (verror):
10488 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10489 since they may not be the same number.
10490 * editfns.c (Finsert_char):
10491 * fileio.c (Finsert_file_contents):
10492 Likewise for BUF_BYTES_MAX.
10493
dd52fcea
PE
10494 * image.c: Use ptrdiff_t, not int, for sizes.
10495 (slurp_file): Switch from int to ptrdiff_t.
10496 All uses changed.
10497 (slurp_file): Check that file size fits in both size_t (for
10498 malloc) and ptrdiff_t (for sanity and safety).
10499
7f9bbdbb
PE
10500 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10501 if b->modtime has its maximal value.
10502
dfe18f82
PE
10503 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10504
84acfcf0
PE
10505 Don't assume time_t can fit into int.
10506 * buffer.h (struct buffer.modtime): Now time_t, not int.
10507 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10508 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10509
ccd9a01a
PE
10510 Minor fixes for signed vs unsigned integers.
10511 * character.h (MAYBE_UNIFY_CHAR):
10512 * charset.c (maybe_unify_char):
10513 * keyboard.c (read_char, reorder_modifiers):
10514 XINT -> XFASTINT, since the integer must be nonnegative.
10515 * ftfont.c (ftfont_spec_pattern):
10516 * keymap.c (access_keymap, silly_event_symbol_error):
10517 XUINT -> XFASTINT, since the integer must be nonnegative.
10518 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10519 since it makes no difference and we prefer signed.
10520 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10521 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10522 nonnegative.
10523
d6d100dd
SM
105242011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10525
10526 * window.h (Fwindow_frame): Declare.
10527
2b6148e4
PE
105282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10529
10530 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10531 (SPARE_MEMORY): Always define.
10532 (LARGE_REQUEST): Remove.
10533 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10534
f230ecc9
MR
105352011-06-06 Martin Rudalics <rudalics@gmx.at>
10536
727e958e
MR
10537 * lisp.h: Move EXFUNS for Fframe_root_window,
10538 Fframe_first_window and Fset_frame_selected_window to window.h.
10539
10540 * window.h: Move EXFUNS for Fframe_root_window,
10541 Fframe_first_window and Fset_frame_selected_window here from
10542 lisp.h.
10543
10544 * frame.c (Fwindow_frame, Fframe_first_window)
10545 (Fframe_root_window, Fframe_selected_window)
10546 (Fset_frame_selected_window): Move to window.c.
10547 (Factive_minibuffer_window): Move to minibuf.c.
10548 (Fother_visible_frames_p): New function.
10549
10550 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10551
f230ecc9
MR
10552 * window.c (decode_window, decode_any_window): Move up in code.
10553 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10554 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10555 (Fwindow_buffer): Move up and rewrite doc-string.
10556 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10557 (Fwindow_prev): New functions.
727e958e
MR
10558 (Fwindow_frame): Move here from frame.c. Accept any window as
10559 argument.
10560 (Fframe_root_window, Fframe_first_window)
10561 (Fframe_selected_window): Move here from frame.c. Accept frame
10562 or arbitrary window as argument. Update doc-strings.
10563 (Fminibuffer_window): Move up in code.
10564 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10565 (Fset_frame_selected_window): Move here from frame.c.
10566 Marginal rewrite.
727e958e
MR
10567 (Fselected_window, select_window, Fselect_window): Move up in
10568 code. Minor doc-string fixes.
f230ecc9 10569
4d09bcf6
PE
105702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10571
10572 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10573 Do not assume that spare memory exists; that assumption is valid
10574 only if SYSTEM_MALLOC.
10575 (LARGE_REQUEST): New macro, so that the issue of large requests
10576 is separated from the issue of spare memory.
10577
810928a2
AS
105782011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10579
172418ad
AS
10580 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10581 format. (Bug#8806)
10582
43f862f7
AS
10583 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10584
810928a2
AS
10585 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10586 before statements.
10587
a059fe24
JD
105882011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10589
10590 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10591
10592 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10593
10594 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10595 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10596
989bf368
JB
105972011-06-05 Juanma Barranquero <lekktu@gmail.com>
10598
10599 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10600
4b80f674
CY
106012011-06-04 Chong Yidong <cyd@stupidchicken.com>
10602
10603 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10604 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10605 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10606 New error handlers.
4b80f674
CY
10607 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10608 Obey Vx_select_enable_clipboard_manager. Catch errors in
10609 x_clipboard_manager_save (Bug#8779).
10610 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10611 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10612
99a33b77 106132011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10614
10615 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10616
99a33b77 106172011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10618
10619 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10620 in the current matrix if keep_current_p is non-zero.
10621
8264569d
EZ
106222011-06-04 Eli Zaretskii <eliz@gnu.org>
10623
10624 * bidi.c (bidi_level_of_next_char): Fix last change.
10625
57f97249
EZ
106262011-06-03 Eli Zaretskii <eliz@gnu.org>
10627
fec2107c 10628 Support bidi reordering of text covered by display properties.
57f97249 10629
fec2107c
EZ
10630 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10631 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10632 (bidi_cache_search, bidi_cache_iterator_state)
10633 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10634 (bidi_level_of_next_char, bidi_move_to_visually_next):
10635 Support character positions inside a run of characters covered by a
fec2107c
EZ
10636 display string.
10637 (bidi_paragraph_init, bidi_resolve_explicit_1)
10638 (bidi_level_of_next_char): Call bidi_fetch_char and
10639 bidi_fetch_char_advance instead of FETCH_CHAR and
10640 FETCH_CHAR_ADVANCE.
10641 (bidi_init_it): Initialize new members.
10642 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10643 definitions.
10644 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10645 instead of using explicit *_CHAR codes.
d6d100dd
SM
10646 (bidi_resolve_explicit, bidi_resolve_weak):
10647 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10648 bidirectional text is supported only in multibyte buffers.
10649 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10650 it to initialize the frame_window_p member of struct bidi_it.
10651 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10652 (bidi_resolve_explicit, bidi_resolve_weak)
10653 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10654 bidi_it->nchars is non-positive.
10655 (bidi_level_of_next_char): Don't try to lookup the cache for the
10656 next/previous character if nothing is cached there yet, or if we
10657 were just reseat()'ed to a new position.
c40e2fb2 10658
0e14fe90
EZ
10659 * xdisp.c (set_cursor_from_row): Set start and stop points
10660 according to the row's direction when priming the loop that looks
10661 for the glyph on which to display cursor.
10662 (single_display_spec_intangible_p): Function deleted.
10663 (display_prop_intangible_p): Reimplement to call
10664 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10665 Accept 3 additional arguments needed by handle_display_spec.
10666 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10667 values: lists, `(when COND...)' forms, etc.
10668 (single_display_spec_string_p): Support property values that are
10669 lists with the argument STRING its top-level element.
10670 (display_prop_string_p): Fix the condition for processing a
10671 property that is a list to be consistent with handle_display_spec.
fec2107c 10672 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10673 last portion of handle_display_prop.
10674 (compute_display_string_pos): Accept additional argument
10675 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10676 value of a `display' property is a "replacing spec".
10677 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10678 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10679 the display property, but just return a value indicating whether
10680 the display property will replace the characters it covers.
10681 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10682 frame_window_p members of struct bidi_it.
d6d100dd
SM
10683 (compute_display_string_pos, compute_display_string_end):
10684 New functions.
fec2107c
EZ
10685 (push_it): Accept second argument POSITION, where pop_it should
10686 jump to continue iteration.
10687 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10688
fec2107c
EZ
10689 * keyboard.c (adjust_point_for_property): Adjust the call to
10690 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10691
10692 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10693 (bidi_init_it): Update prototypes.
10694 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10695 (compute_display_string_pos, compute_display_string_end):
10696 Declare prototypes.
fec2107c
EZ
10697 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10698 EMACS_INT.
fc6f18ce 10699
40087514 107002011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10701
57f53182
PE
10702 Malloc failure behavior now depends on size of allocation.
10703 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10704 * lisp.h: Change signatures accordingly.
10705 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10706 All callers changed. (Bug#8762)
10707
10708 * gnutls.c: Use Emacs's memory allocators.
10709 Without this change, the gnutls library would invoke malloc etc.
10710 directly, which causes problems on non-SYNC_INPUT hosts, and which
10711 runs afoul of improving memory_full behavior. (Bug#8761)
10712 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10713 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10714 xfree instead of the default malloc, realloc, free.
10715 (Fgnutls_boot): No need to check for memory allocation failure,
10716 since xmalloc does that for us.
10717
ac32cd99 10718 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10719 * category.c (hash_get_category_set):
10720 * ccl.c (ccl_driver):
10721 * charset.c (Fdefine_charset_internal):
10722 * charset.h (struct charset.hash_index):
10723 * composite.c (get_composition_id, gstring_lookup_cache)
10724 (composition_gstring_put_cache):
10725 * composite.h (struct composition.hash_index):
10726 * dispextern.h (struct image.hash):
10727 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10728 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10729 (hashfn_equal, hashfn_user_defined, make_hash_table)
10730 (maybe_resize_hash_table, hash_lookup, hash_put)
10731 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10732 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10733 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10734 * image.c (make_image, search_image_cache, lookup_image)
10735 (xpm_put_color_table_h):
10736 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10737 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10738 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10739 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10740 * alloc.c (allocate_vectorlike):
10741 Check for overflow in vector size calculations.
10742 * ccl.c (ccl_driver):
10743 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10744 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10745 need to be updated by these changes.
40087514
PE
10746 * fns.c (make_hash_table, maybe_resize_hash_table):
10747 Check for integer overflow with large hash tables.
0de4bb68
PE
10748 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10749 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10750 (SXHASH_REDUCE): New macro.
10751 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10752 Use it instead of discarding useful hash info with large hash values.
10753 (sxhash_float): New function.
10754 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10755 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10756 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10757 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10758 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10759 Adjust signatures to match updated version of code.
10760 (consing_since_gc): Now EMACS_INT, since a single hash table can
10761 use more than INT_MAX bytes.
10762
698d32e2
DN
107632011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10764
10765 Make it possible to build with GCC-4.6+ -O2 -flto.
10766
10767 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10768
fd6fa53f
SM
107692011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10770
10771 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10772 Call minibuffer-inactive-mode.
10773
864db017
JB
107742011-05-31 Juanma Barranquero <lekktu@gmail.com>
10775
10776 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10777 Update dependencies.
10778
2ad0baf4
DN
107792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10780
10781 * data.c (init_data): Remove code for UTS, this system is not
10782 supported anymore.
10783
4fcc2638
DN
107842011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10785
10786 Don't force ./temacs to start in terminal mode.
10787
10788 * frame.c (make_initial_frame): Initialize faces in all cases, not
10789 only when CANNOT_DUMP is defined.
10790 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10791
c56e0fd5
DN
107922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10793
10794 * dispnew.c (add_window_display_history): Use const for the string
10795 pointer. Remove declaration, not needed.
10796
333d54da 107972011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10798
55d4c1b2 10799 Use 'inline', not 'INLINE'.
333d54da 10800 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10801 * alloc.c, fontset.c (INLINE): Remove.
10802 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10803 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10804 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10805 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10806 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10807
738db178
DN
108082011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10809
10810 Make it possible to run ./temacs.
10811
10812 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10813 syms_of_callproc does the same thing. Remove test for
10814 "initialized", do it in the caller.
10815 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10816
620c53a6
SM
108172011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10818
10819 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10820 (read_minibuf): Use get_minibuffer.
10821 (syms_of_minibuf): Use DEFSYM.
10822 (Qmetadata): New var.
10823 * data.c (Qbuffer): Don't make it static.
10824 (syms_of_data): Use DEFSYM.
10825
e003a292
PE
108262011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10827
10828 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10829 (CCL_CODE_MIN): New macro.
10830
ed008a6d
PE
108312011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10832
3687c2ef
PE
10833 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10834
ed008a6d
PE
10835 * eval.c (Qdebug): Now static.
10836 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10837 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10838 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10839
d66c4c7c
CY
108402011-05-29 Chong Yidong <cyd@stupidchicken.com>
10841
10842 * image.c: Various fixes to ImageMagick code comments.
10843 (Fimagemagick_types): Doc fix.
10844
5fbc2025
PE
108452011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10846
0196f88a
PE
10847 Minor fixes prompted by GCC 4.6.0 warnings.
10848
10849 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10850
5fbc2025
PE
10851 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10852 (x_clipboard_manager_save_all): Move extern decl to ...
10853 * xterm.h: ... here, so that it can be checked for consistency.
10854
1dd3c2d9
CY
108552011-05-29 Chong Yidong <cyd@stupidchicken.com>
10856
10857 * xselect.c (x_clipboard_manager_save_frame)
10858 (x_clipboard_manager_save_all): New functions.
10859 (Fx_clipboard_manager_save): Lisp function deleted.
10860
10861 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10862 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10863
10864 * xterm.h: Update prototype.
10865
5ba6571d
WX
108662011-05-28 William Xu <william.xwl@gmail.com>
10867
10868 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10869 exiting (Bug#8239).
10870
3eaff834
JM
108712011-05-28 Jim Meyering <meyering@redhat.com>
10872
e1900994 10873 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10874 * fns.c (to_uchar): Define.
10875 (crypto_hash_function): Use it to convert some newly-signed
10876 variables to unsigned, to avoid sign-extension bugs. For example,
10877 without this change, (md5 "truc") would evaluate to
10878 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10879 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10880 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10881
0f6990a7
PE
108822011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10883
10884 Integer overflow fixes.
c8a9ca5a 10885
08686060
PE
10886 * dbusbind.c: Serial number integer overflow fixes.
10887 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10888 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10889 to hold a serial number that is too large for a fixnum.
10890 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10891 Check for serial numbers out of range. Decode any serial number
59568bf0 10892 that was so large that it became a float. (Bug#8722)
08686060 10893
2d1fc3c7
PE
10894 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10895 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10896 Use XFASTINT rather than XUINT when numbers are nonnegative.
10897 (xd_append_arg, Fdbus_method_return_internal):
10898 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10899 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10900 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10901 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10902 (Bug#8722)
2d1fc3c7 10903
c8a9ca5a
PE
10904 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10905
519e1d69
PE
10906 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10907
6df6ae42 10908 ccl: Add integer overflow checks.
30569699
PE
10909 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10910 (IN_INT_RANGE): New macros.
10911 (ccl_driver): Use them to check for integer overflow when
10912 decoding a CCL program. Many of the new checks are whether XINT (x)
10913 fits in int; it doesn't always, on 64-bit hosts. The new version
10914 doesn't catch all possible integer overflows, but it's an
847044ea 10915 improvement. (Bug#8719)
30569699 10916
c11285dc
PE
10917 * alloc.c (make_event_array): Use XINT, not XUINT.
10918 There's no need for unsigned here.
10919
fdccd48e
PE
10920 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10921 This follows up to the 2011-05-06 change that substituted uintptr_t
10922 for EMACS_INT. This case wasn't caught back then.
10923
37910ab2
PE
10924 Rework Fformat to avoid integer overflow issues.
10925 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10926 now (part of C89). Include <verify.h>.
10927 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10928 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10929 (Fformat): Avoid the prepass trying to compute sizes; it was only
10930 approximate and thus did not catch overflow reliably. Instead, walk
10931 through the format just once, formatting and computing sizes as we go,
10932 checking for integer overflow at every step, and allocating a larger
10933 buffer as needed. Keep track separately whether the format is
10934 multibyte. Keep only the most-recently calculated precision, rather
10935 than them all. Record whether each argument has been converted to
10936 string. Use EMACS_INT, not int, for byte and char and arg counts.
10937 Support field widths and precisions larger than INT_MAX. Avoid
10938 sprintf's undefined behavior with conversion specifications such as %#d
10939 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10940 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10941 formatting out-of-range floating point numbers with int
9173deec 10942 formats. (Bug#8668)
37910ab2 10943
2e6578fb
PE
10944 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10945
0ae6bdee
PE
10946 * data.c: Avoid integer truncation in expressions involving floats.
10947 * data.c: Include <intprops.h>.
10948 (arith_driver): When there's an integer overflow in an expression
10949 involving floating point, convert the integers to floating point
10950 so that the resulting value does not suffer from catastrophic
10951 integer truncation. For example, on a 64-bit host (* 4
10952 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10953 Do not rely on undefined behavior after integer overflow.
10954
de883a70
PE
10955 merge count_size_as_multibyte, parse_str_to_multibyte
10956 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10957 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10958 Check for integer overflow.
10959 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10960 since it's now a duplicate of the other. This is more of
10961 a character than a buffer op, so better that it's in character.c.
10962 * fns.c, print.c: Adjust to above changes.
10963
2ff916cb
PE
109642011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10965
10966 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10967
f1b54466
PE
109682011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10969
fb1ac845
PE
10970 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10971 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10972 (x_clipboard_manager_save): Now static.
10973 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10974
f1b54466
PE
10975 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10976 (crypto_hash_function): Now static.
10977 Fix pointer signedness problems. Avoid unnecessary initializations.
10978
a9f737ee
CY
109792011-05-27 Chong Yidong <cyd@stupidchicken.com>
10980
10981 * termhooks.h (Vselection_alist): Make it terminal-local.
10982
10983 * terminal.c (create_terminal): Initialize it.
10984
10985 * xselect.c: Support for clipboard managers.
10986 (Vselection_alist): Move to termhooks.h as terminal-local var.
10987 (LOCAL_SELECTION): New macro.
10988 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10989 (symbol_to_x_atom): Remove gratuitous arg.
10990 (x_handle_selection_request, lisp_data_to_selection_data)
10991 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10992 (x_own_selection, x_get_local_selection, x_convert_selection):
10993 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10994 (some_frame_on_display): Delete unused function.
10995 (Fx_own_selection_internal, Fx_get_selection_internal)
10996 (Fx_disown_selection_internal, Fx_selection_owner_p)
10997 (Fx_selection_exists_p): New optional frame arg.
10998 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10999 (x_handle_selection_clear): Don't treat other terminals with the
11000 same keyboard specially. Use the terminal-local Vselection_alist.
11001 (x_clear_frame_selections): Use Frun_hook_with_args.
11002
11003 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11004
11005 * xterm.h: Add support for those atoms.
11006
e067f0c1
CY
110072011-05-26 Chong Yidong <cyd@stupidchicken.com>
11008
11009 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11010 (converted_selections, conversion_fail_tag): New global variables.
11011 (x_selection_request_lisp_error): Free the above.
11012 (x_get_local_selection): Remove unnecessary code.
11013 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11014 of converted selections stored in converted_selections.
11015 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11016 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11017 (x_convert_selection): New function.
11018 (x_handle_selection_event): Simplify.
11019 (x_get_foreign_selection): Don't ignore incoming requests while
11020 waiting for an answer; this will fail when we implement
11021 SAVE_TARGETS, and seems unnecessary anyway.
11022 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11023 (Vx_sent_selection_functions): Doc fix.
11024
0f4aebc0
LL
110252011-05-26 Leo Liu <sdl.web@gmail.com>
11026
11027 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11028
e61124cd
YM
110292011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11030
11031 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11032
11033 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11034 for fringe update if it has periodic bitmap.
ac389d0c 11035 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11036 and fringe_bitmap_periodic_p.
11037
11038 * fringe.c (get_fringe_bitmap_data): New function.
11039 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11040 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11041 row. Mark glyph row for fringe update if periodicity changed.
11042
11043 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11044 for fringe update unless it has periodic bitmap.
11045
f16d9837
KH
110462011-05-25 Kenichi Handa <handa@m17n.org>
11047
11048 * xdisp.c (get_next_display_element): Set correct it->face_id for
11049 a static composition.
11050
e1b90ef6
LL
110512011-05-24 Leo Liu <sdl.web@gmail.com>
11052
11053 * deps.mk (fns.o):
11054 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11055
11056 * fns.c (crypto_hash_function, Fsha1): New function.
11057 (Fmd5): Use crypto_hash_function.
11058 (syms_of_fns): Add Ssha1.
11059
7400048f
PE
110602011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11061
11062 * gnutls.c: Remove unused macros.
11063 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11064 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11065 Remove macros that are defined and never used.
11066 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11067
abb71cf4
CY
110682011-05-22 Chong Yidong <cyd@stupidchicken.com>
11069
11070 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11071 (Fx_get_selection_internal): Minor cleanup.
11072 (Fx_own_selection_internal): Rename arguments for consistency with
11073 select.el.
11074
6307db39
PE
110752011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11076
11077 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11078
f3d4e0a4
CY
110792011-05-22 Chong Yidong <cyd@stupidchicken.com>
11080
11081 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11082
4d8ade89
YM
110832011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11084
11085 * dispnew.c (scrolling_window): Don't exclude the case that the
11086 last enabled row in the desired matrix touches the bottom boundary.
11087
32078c8d
GM
110882011-05-21 Glenn Morris <rgm@gnu.org>
11089
11090 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11091 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11092 and add some more files.
32078c8d 11093
7285dc67
EZ
110942011-05-20 Eli Zaretskii <eliz@gnu.org>
11095
11096 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11097 report_file_error introduced by the change from 2011-05-07.
11098
89d1bd22
PE
110992011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11100
11101 * systime.h (Time): Define only if emacs is defined.
11102 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11103 where the include path doesn't have X11/X.h by default. See
11104 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11105
cd394be1 111062011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11107
11108 * composite.c (find_automatic_composition): Fix previous change.
11109
b9704ad9
GM
111102011-05-20 Glenn Morris <rgm@gnu.org>
11111
11112 * lisp.mk: New file, split from Makefile.in.
11113 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11114 (shortlisp): Remove.
11115 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11116
4a720484
GM
111172011-05-19 Glenn Morris <rgm@gnu.org>
11118
11119 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11120 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11121 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11122 (lisp): Set the order to that of loadup.el.
11123 (shortlisp): Make it a copy of $lisp.
11124 (SOME_MACHINE_LISP): Remove.
11125 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11126 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11127
a28d4396
KH
111282011-05-18 Kenichi Handa <handa@m17n.org>
11129
11130 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11131 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11132 (find_automatic_composition): Mostly rewrite for efficiency.
11133
a2b1fa8e
JB
111342011-05-18 Juanma Barranquero <lekktu@gmail.com>
11135
11136 * makefile.w32-in: Update dependencies.
11137
8e1f5610
CS
111382011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11139
11140 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11141 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11142
7025ee00 111432011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11144
cdfa6eab
PE
11145 Fix some integer overflow issues, such as string length overflow.
11146
06d6db33
PE
11147 * insdel.c (count_size_as_multibyte): Check for string overflow.
11148
2b4560a8
PE
11149 * character.c (lisp_string_width): Check for string overflow.
11150 Use EMACS_INT, not int, for string indexes and lengths; in
11151 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11152 the resulting string length overflows an EMACS_INT; instead,
11153 report a string overflow if no precision given. When checking for
11154 precision exhaustion, use a check that cannot possibly have
11155 integer overflow. (Bug#8675)
11156 * character.h (lisp_string_width): Adjust to new signature.
11157
cb93f9be
PE
11158 * alloc.c (string_overflow): New function.
11159 (Fmake_string): Use it. This doesn't change behavior, but saves
11160 a few bytes and will simplify future changes.
11161 * character.c (string_escape_byte8): Likewise.
11162 * lisp.h (string_overflow): New decl.
11163
1a1f3366
PE
11164 Fixups, following up to the user-interface timestamp change.
11165 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11166 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11167 * msdos.c (mouse_get_pos): Likewise.
11168 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11169 * w32gui.h (Time): Define by including "systime.h" rather than by
11170 declaring it ourselves. (Bug#8664)
11171
d4e3e4d3
PE
11172 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11173 * image.c (clear_image_cache): Likewise.
11174
f6a24d19
PE
11175 * term.c (term_mouse_position): Don't assume time_t wraparound.
11176
08dc5ae6
PE
11177 Be more systematic about user-interface timestamps.
11178 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11179 and sometimes 'EMACS_UINT', to represent these timestamps.
11180 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11181 This makes the code easier to follow, and makes it easier to catch
11182 integer overflow bugs such as Bug#8664.
11183 * frame.c (Fmouse_position, Fmouse_pixel_position):
11184 Use Time, not unsigned long, for user-interface timestamps.
11185 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11186 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11187 * keyboard.h (last_event_timestamp): Likewise.
11188 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11189 * menu.h (xmenu_show): Likewise.
11190 * term.c (term_mouse_position): Likewise.
11191 * termhooks.h (struct input_event.timestamp): Likewise.
11192 (struct terminal.mouse_position_hook): Likewise.
11193 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11194 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11195 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11196 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11197 what it was before.
11198 * menu.h, termhooks.h: Include "systime.h", for Time.
11199
8e55734a
PE
11200 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11201 Don't assume that the difference between two unsigned long values
11202 can fit into an integer. At this point, we know button_down_time
11203 <= event->timestamp, so the difference must be nonnegative, so
11204 there's no need to cast the result if double-click-time is
11205 nonnegative, as it should be; check that it's nonnegative, just in
11206 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11207 apart (about 25 days). (Bug#8664)
8e55734a 11208
841f1b75 11209 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11210 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11211
3e26f69c
PE
11212 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11213 that always fit in int. Use a sentinel instead of a counter, to
11214 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11215 * frame.h (struct frame): Use int for menu_bar_items_used
11216 instead of EMACS_INT, since it always fits in int.
3e26f69c 11217
5cc152c0
PE
11218 * menu.c (grow_menu_items): Check for int overflow.
11219
d89eb65e
PE
11220 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11221
5235bd3e
PE
11222 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11223 Before, the code was not consistent. These values cannot exceed
11224 2**31 - 1 so there's no need to make them unsigned.
11225 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11226 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11227 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11228 as modifiers.
11229 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11230
bc827e23
PE
11231 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11232 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11233 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11234 presumably because the widths might not match.
11235
78eb494e
PE
11236 * window.c (size_window): Avoid needless test at loop start.
11237
04f2d78b
CB
112382011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11239
11240 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11241
d2fc7e3d 112422011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11243
11244 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11245
d2fc7e3d 112462011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11247
11248 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11249 `width' to `bar_area_x' and `bar_area_width', respectively.
11250 (x_scroll_run): Take account of fringe background extension.
11251
04f2d78b
CB
11252 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11253 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11254 `bar_area_width', respectively.
11255 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11256 background extension.
11257
79b70037
GM
112582011-05-10 Jim Meyering <meyering@redhat.com>
11259
11260 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11261
2f142cc5
JB
112622011-05-10 Juanma Barranquero <lekktu@gmail.com>
11263
11264 * image.c (Finit_image_library): Return t for built-in image types,
11265 like pbm and xbm. (Bug#8640)
11266
57679c86
AS
112672011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11268
11269 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11270
888c9e86
EZ
112712011-05-07 Eli Zaretskii <eliz@gnu.org>
11272
b0512a1d
EZ
11273 * w32console.c (Fset_screen_color): Doc fix.
11274 (Fget_screen_color): New function.
11275 (syms_of_ntterm): Defsubr it.
11276
7285dc67
EZ
11277 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11278 unlink the temporary file if Fcall_process didn't create it in the
11279 first place.
11280 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11281 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11282 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11283 cue to call_process_cleanup not to close that handle.
11284
4d3fcc8e
BK
112852011-05-07 Ben Key <bkey76@gmail.com>
11286
11287 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11288 one of two shell specific rules, either bootstrap-temacs-CMD or
11289 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11290 to the previous implementation of the bootstrap-temacs rule.
11291 The bootstrap-temacs-CMD rule is similar to the previous
11292 implementation of the bootstrap-temacs rule except that it
11293 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11294 variable.
11295
11296 These changes, along with some changes to nt/configure.bat,
11297 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11298 earlier fix to add support for --cflags and --ldflags options
11299 that include quotes so that it works whether make uses cmd or
11300 sh as the shell.
11301
b4289b64
MA
113022011-05-06 Michael Albinus <michael.albinus@gmx.de>
11303
11304 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11305 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11306 is a constant.
11307 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11308 a string. Handle both cases.
11309 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11310 (Fdbus_register_method): Use Qinvalid_function.
11311
af4c0e28
JB
113122011-05-06 Juanma Barranquero <lekktu@gmail.com>
11313
11314 * makefile.w32-in: Update dependencies.
11315 (LISP_H): Add inttypes.h and stdin.h.
11316 (PROCESS_H): Add unistd.h.
11317
c51453d9
EZ
113182011-05-06 Eli Zaretskii <eliz@gnu.org>
11319
11320 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11321 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11322
8ff0ac3c 113232011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11324
4c4b566b
PE
11325 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11326
aab2b9b5
PE
11327 * term.c (vfatal): Remove stray call to va_end.
11328 It's not needed and the C Standard doesn't allow it here anyway.
11329
c378da0b
PE
11330 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11331 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11332
288b08c7
PE
11333 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11334 bytes.
11335
e3601888
PE
11336 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11337
db6c0e74
PE
11338 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11339
dd5963ea
PE
11340 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11341
88c9450f
PE
11342 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11343
2f9442b8
PE
11344 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11345
c032b5f8
PE
11346 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11347 * charset.c (Fdefine_charset_internal): Don't initialize
11348 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11349 32-bit int (Bug#8600).
a108c10b
PE
11350
11351 * lread.c (read_integer): Be more consistent with string-to-number.
11352 Use string_to_number to do the actual conversion; this avoids
11353 rounding errors and fixes some other screwups. Without this fix,
11354 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11355 (digit_to_number): Move earlier, for benefit of read_integer.
11356 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11357 not a digit in any supported base. (Bug#8602)
a108c10b 11358
ad5f9eea
PE
11359 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11360
aec1708a
PE
11361 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11362 to match comment at start of function. This also removes a
11363 GCC warning about overflow in a 32+64-bit port.
11364
47be4ab5
PE
11365 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11366
371cac43
PE
11367 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11368 Reported by Stefan Monnier in
11369 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11370 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11371 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11372
d01a7826
PE
11373 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11374 (EMACS_UINTPTR): Likewise, with uintptr_t.
11375
7fd47d5c
PE
11376 * lisp.h: Prefer 64-bit EMACS_INT if available.
11377 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11378 on 32-bit hosts that have 64-bit int, so that they can access
11379 large files.
122b0c86
PE
11380 However, temporarily disable this change unless the temporary
11381 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11382
8727937b
PE
11383 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11384
8ac068ac
PE
11385 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11386 This removes an assumption that EMACS_INT and long are the same
11387 width as pointers. The assumption is true for Emacs porting targets
11388 now, but we want to make other targets possible.
11389 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11390 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11391 In the rest of the code, change types of integers that hold casted
11392 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11393 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11394 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11395 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11396 No need to cast type when ORing.
11397 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11398 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11399 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11400 assume EMACS_INT is the same width as char *.
11401 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11402 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11403 Remove no-longer-needed casts.
11404 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11405 (xg_tool_bar_help_callback, xg_make_tool_item):
11406 Use EMACS_INTPTR to hold an integer
11407 that will be cast to void *; this can avoid a GCC warning
11408 if EMACS_INT is not the same width as void *.
11409 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11410 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11411 (current_message_1, set_message_1):
11412 Use a local to convert to proper width without a cast.
11413 * xmenu.c (dialog_selection_callback): Likewise.
11414
ede49d71
PE
11415 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11416 Also, don't assume VALBITS / RAND_BITS is less than 5,
11417 and don't rely on undefined behavior when shifting a 1 left into
11418 the sign bit.
11419 * lisp.h (get_random): Change signature to match.
11420
2f30ecd0
PE
11421 * lread.c (hash_string): Use size_t, not int, for hash computation.
11422 Normally we prefer signed values; but hashing is special, because
11423 it's better to use unsigned division on hash table sizes so that
11424 the remainder is nonnegative. Also, size_t is the natural width
11425 for hashing into memory. The previous code used 'int', which doesn't
11426 retain enough info to hash well into very large tables.
11427 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11428
2a866e7b
PE
11429 * dbusbind.c: Don't possibly lose pointer info when converting.
11430 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11431 Use XPNTR rather than XHASH, so that the high-order bits of
11432 the pointer aren't lost when converting through void *.
11433
51639eac
PE
11434 * eval.c (Fautoload): Don't double-shift a pointer.
11435
92394119
PE
11436 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11437
dbdb9a7c
JB
114382011-05-06 Juanma Barranquero <lekktu@gmail.com>
11439
11440 * gnutls.c (DEF_GNUTLS_FN):
11441 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11442
db7a0b4f
AS
114432011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11444
11445 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11446 marker. (Bug#8610)
11447
cd394be1 114482011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11449
11450 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11451 New version that can reserve upto 2GB of heap space.
11452
f7ff1b0f 114532011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11454
11455 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11456
639c109b
TZ
114572011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11458
11459 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11460 `gnutls_certificate_set_x509_key_file'.
11461
d2127135
JB
114622011-05-05 Juanma Barranquero <lekktu@gmail.com>
11463
11464 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11465 Update dependencies.
11466
e968f4f3
JB
114672011-05-04 Juanma Barranquero <lekktu@gmail.com>
11468
11469 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11470 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11471 Remove unused parameter `fildes'.
11472 * process.c (read_process_output, send_process): Don't pass it.
11473
84d358f0
JB
114742011-05-04 Juanma Barranquero <lekktu@gmail.com>
11475
11476 Fix previous change: the library cache is defined in w32.c.
11477 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11478 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11479
0898ca10
JB
114802011-05-04 Juanma Barranquero <lekktu@gmail.com>
11481
11482 Implement dynamic loading of GnuTLS on Windows.
11483
11484 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11485 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11486 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11487 Declare.
11488
11489 * gnutls.c (Qgnutls_dll): Define.
11490 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11491 (gnutls_*): Declare function pointers.
11492 (init_gnutls_functions): New function to initialize function pointers.
11493 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11494 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11495 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11496 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11497 (emacs_gnutls_write, emacs_gnutls_read)
11498 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11499 (Fgnutls_available_p): New function.
11500 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11501 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11502 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11503
11504 * image.c: Include w32.h.
11505 (Vimage_type_cache): Delete.
11506 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11507 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11508 (w32_delayed_load): Move to w32.c.
11509
11510 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11511
11512 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11513 (w32_delayed_load): Move from image.c. When loading a library, record
11514 its filename in the :loaded-from property of the library id.
11515 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11516 Initialize and staticpro them.
11517 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11518
11519 * process.c: Include lisp.h before w32.h, not after.
11520 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11521 instead of gnutls_record_check_pending.
11522
11523 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11524
ff4de4aa
TZ
115252011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11526
11527 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11528 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11529 as passed in.
11530
abe95abb
JD
115312011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11532
11533 * xterm.c (x_set_frame_alpha): Do not set property on anything
11534 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11535
e16e55d4
JB
115362011-05-02 Juanma Barranquero <lekktu@gmail.com>
11537
11538 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11539
bafcf6a5
JB
115402011-05-02 Juanma Barranquero <lekktu@gmail.com>
11541
11542 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11543 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11544 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11545 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11546 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11547 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11548 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11549 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11550 (Qgnutls_bootprop_callbacks_verify): Make static.
11551
e7a6747f
AS
115522011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11553
19ed11ba
AS
11554 * callproc.c: Indentation fixup.
11555
e7a6747f 11556 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11557 (wait_for_termination, interruptible_wait_for_termination):
11558 Move after wait_for_termination_1.
e7a6747f 11559
1ef14cb4
LMI
115602011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11561
11562 * sysdep.c (interruptible_wait_for_termination): New function
11563 which is like wait_for_termination, but allows keyboard
11564 interruptions.
11565
11566 * callproc.c (Fcall_process): Add (:file "file") as an option for
11567 the STDOUT buffer.
11568 (Fcall_process_region): Ditto.
11569
330d880c
EZ
115702011-04-30 Eli Zaretskii <eliz@gnu.org>
11571
8db90b73
EZ
11572 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11573 rather than `XVECTOR (FOO)->size'.
11574
330d880c
EZ
11575 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11576 inttypes.h, as a gnulib replacement is used if it not available in
11577 system headers.
11578
15cbd324
EZ
115792011-04-21 Eli Zaretskii <eliz@gnu.org>
11580
11581 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11582 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11583 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11584
11585 * coding.c (coding_alloc_by_realloc): Error out if destination
11586 will grow beyond MOST_POSITIVE_FIXNUM.
11587 (decode_coding_emacs_mule): Abort if there isn't enough place in
11588 charbuf for the composition carryover bytes. Reserve an extra
11589 space for up to 2 characters produced in a loop.
11590 (decode_coding_iso_2022): Abort if there isn't enough place in
11591 charbuf for the composition carryover bytes.
11592
115932011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11594
ae940cca
EZ
11595 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11596 aborting when %lld or %lll format is passed.
11597 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11598 %llo or %llx format is passed. (Bug#8545)
11599
03ab8921
EZ
11600 * window.c (window_scroll_line_based): Use a marker instead of
11601 simple variables to record original value of point. (Bug#7952)
11602
afda1437
EZ
11603 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11604 produced by %s or %c overflows available buffer space. (Bug#8545)
11605
f76dee0c
PE
116062011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11607
11608 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11609 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11610
fdc5744d
JB
116112011-04-28 Juanma Barranquero <lekktu@gmail.com>
11612
11613 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11614
638f053a
JB
116152011-04-28 Juanma Barranquero <lekktu@gmail.com>
11616
11617 * keyboard.c (Qdelayed_warnings_hook): Define.
11618 (command_loop_1): Run `delayed-warnings-hook'
11619 if Vdelayed_warnings_list is non-nil.
11620 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11621 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11622
d178f871
EZ
116232011-04-28 Eli Zaretskii <eliz@gnu.org>
11624
11625 * doprnt.c (doprnt): Don't return value smaller than the buffer
11626 size if the message was truncated. (Bug#8545).
11627
b124fd93
JB
116282011-04-28 Juanma Barranquero <lekktu@gmail.com>
11629
11630 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11631 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11632
e810457d
PE
116332011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11634
11635 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11636
ea51cceb
JB
116372011-04-27 Juanma Barranquero <lekktu@gmail.com>
11638
11639 * makefile.w32-in: Update dependencies.
11640
94dcfacf
EZ
116412011-04-27 Eli Zaretskii <eliz@gnu.org>
11642
11643 Improve `doprnt' and its usage. (Bug#8545)
11644 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11645 `format_end'. Remove support for %l as a conversion specifier.
11646 Don't use xrealloc. Improve diagnostics when the %l size modifier
11647 is used. Update the commentary.
11648
11649 * eval.c (verror): Simplify calculation of size_t.
11650
11651 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11652 messages.
11653
f61f41d7
PE
116542011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11655
11656 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11657 change.
11658
96fb4434
PE
116592011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11660
11661 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11662 This makes this file independent of the recent pseudovector change.
11663
671875da 116642011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11665
69e9b5a3
PE
11666 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11667
b5f869a7 11668 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11669 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11670 Remove unused local.
c8926152 11671 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11672
841a1577 11673 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11674 GCC 4.6.0 optimizes based on type-based alias analysis.
11675 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11676 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11677 != &v->size, and therefore "v->size = 1; b->size = 2; return
11678 v->size;" must therefore return 1. This assumption is incorrect
11679 for Emacs, since it type-puns struct Lisp_Vector * with many other
11680 types. To fix this problem, this patch adds a new type struct
f904488f 11681 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11682 and pseudovectors, and helps optimizing compilers not get fooled
11683 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11684 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11685 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11686 the size member.
eab3844f
PE
11687 (XSETPVECTYPE): Rewrite in terms of new macro.
11688 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11689 This is a bit clearer, and further avoids the possibility of
11690 undesirable aliasing.
11691 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11692 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11693 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11694 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11695 (ASIZE): Now uses header.size rather than size.
11696 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11697 to avoid the hassle of writing XVECTOR (foo)->header.size.
11698 (struct vectorlike_header): New type.
eab3844f
PE
11699 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11700 object, to help avoid aliasing.
11701 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11702 (SUBRP): Likewise, since Lisp_Subr is a special case.
11703 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11704 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11705 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11706 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11707 changed to be "header.size" and "header.next".
11708 * buffer.h (struct buffer): Likewise.
11709 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11710 * frame.h (struct frame): Likewise.
11711 * process.h (struct Lisp_Process): Likewise.
11712 * termhooks.h (struct terminal): Likewise.
11713 * window.c (struct save_window_data, struct saved_window): Likewise.
11714 * window.h (struct window): Likewise.
11715 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11716 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11717 * buffer.c (init_buffer_once): Likewise.
11718 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11719 special case.
11720 * process.c (Fformat_network_address): Use local var for size,
11721 for brevity.
11722
0df1eac5
PE
11723 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11724
847ab9d1 11725 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11726 * data.c (atof): Remove decl; no longer used or needed.
11727 (digit_to_number): Move to lread.c.
11728 (Fstring_to_number): Use new string_to_number function, to be
11729 consistent with how the Lisp reader treats infinities and NaNs.
11730 Do not assume that floating-point numbers represent EMACS_INT
11731 without losing information; this is not true on most 64-bit hosts.
11732 Avoid double-rounding errors, by insisting on integers when
11733 parsing non-base-10 numbers, as the documentation specifies.
11734 * lisp.h (string_to_number): New decl, replacing ...
11735 (isfloat_string): Remove.
bc0a5c13 11736 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11737 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11738 appears to have been a coding error. Similarly, do not accept
11739 strings like +-1e0 as floating point numbers. Do not report
11740 overflow for integer overflows unless the base is not 10 which
11741 means we have no simple and reliable way to continue.
11742 Break out the floating-point parsing into a new
11743 function string_to_number, so that Fstring_to_number parses
11744 floating point numbers consistently with the Lisp reader.
04f2d78b 11745 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11746 (E_CHAR, EXP_INT): Remove, replacing with ...
11747 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11748 (string_to_number): New function, replacing isfloat_string.
11749 This function checks for valid syntax and produces the resulting
11750 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11751 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11752 so that overflow for non-base-10 numbers is reported only when
11753 there's no portable and simple way to convert to floating point.
452f4150 11754
67769ffc
PE
11755 * textprop.c (set_text_properties_1): Rewrite for clarity,
11756 and to avoid GCC warning about integer overflow.
11757
c20db43f
PE
11758 * intervals.h (struct interval): Use EMACS_INT for members
11759 where EMACS_UINT might cause problems. See
11760 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11761 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11762 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11763 All uses changed.
37aa2f85
PE
11764 (offset_intervals): Tell GCC not to worry about length overflow
11765 when negating a negative length.
c20db43f 11766
2538aa2f
PE
11767 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11768 (overrun_check_free): Likewise.
11769
f2d3008d
PE
11770 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11771 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11772 word size.
11773
ec8df744
PE
11774 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11775 (gnutls_make_error): Rename local to avoid shadowing.
11776 (gnutls_emacs_global_deinit): ifdef out; not used.
11777 (Fgnutls_boot): Use const for pointer to readonly storage.
11778 Comment out unused local. Fix pointer signedness problems.
11779
640ee02d
PE
11780 * lread.c (openp): Don't stuff size_t into an 'int'.
11781 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11782 about possible signed overflow.
11783
6048fb2a
PE
11784 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11785 (GDK_KEY_g): Don't define if already defined.
11786 (xg_prepare_tooltip): Avoid pointer signedness problem.
11787 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11788
fa3c87e1
PE
11789 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11790 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11791
2172544b
PE
11792 * xfns.c (Fx_window_property): Simplify a bit,
11793 to make a bit faster and to avoid GCC 4.6.0 warning.
11794 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11795
9b821a21
PE
11796 * fns.c (internal_equal): Don't assume size_t fits in int.
11797
3c616cfa
PE
11798 * alloc.c (compact_small_strings): Tighten assertion a little.
11799
c2982e87
PE
11800 Replace pEd with more-general pI, and fix some printf arg casts.
11801 * lisp.h (pI): New macro, generalizing old pEd macro to other
11802 conversion specifiers. For example, use "...%"pI"d..." rather
11803 than "...%"pEd"...".
11804 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11805 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11806 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11807 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11808 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11809 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11810 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11811 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11812 64-bit hosts.
11813 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11814 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11815 * print.c (safe_debug_print, print_object): Likewise.
11816 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11817 to int.
6f04d126
PE
11818 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11819 avoiding the 0 flag, which is not portable.
c2982e87
PE
11820 * process.c (Fmake_network_process): Use pI to avoid cast.
11821 * region-cache.c (pp_cache): Likewise.
11822 * xdisp.c (decode_mode_spec): Likewise.
11823 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11824 behavior on 64-bit hosts with printf arg.
6f04d126 11825 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11826 (x_stop_queuing_selection_requests): Likewise.
11827 (x_get_window_property): Don't truncate byte count to an 'int'
11828 when tracing.
0b432f21 11829
5e073ec7
PE
11830 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11831 here, since it parses constructs like leading '-' and spaces,
11832 which are not wanted; and it overflows with large numbers.
11833 Instead, simply match F[0-9]+, which is what is wanted anyway.
11834
36372bf9
PE
11835 * alloc.c: Remove unportable assumptions about struct layout.
11836 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11837 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11838 (allocate_vectorlike, make_pure_vector): Use the new macros,
11839 plus offsetof, to remove unportable assumptions about struct layout.
11840 These assumptions hold on all porting targets that I know of, but
11841 they are not guaranteed, they're easy to remove, and removing them
11842 makes further changes easier.
11843
0b432f21
PE
11844 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11845 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11846 (string_overrun_cookie): Now const. Use initializers that
11847 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11848 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11849 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11850 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11851 multiple of sizeof (EMACS_INT); it need not be, if
11852 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11853 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11854
895009e1
JB
118552011-04-26 Juanma Barranquero <lekktu@gmail.com>
11856
11857 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11858
6a7a1b0b
TZ
118592011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11860
11861 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11862 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11863 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11864
841a1577 118652011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11866
11867 * lisp.h (Qdebug): List symbol.
895009e1 11868 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11869 * keyboard.c (debug-on-event): New variable.
11870 (handle_user_signal): Break into debugger when debug-on-event
11871 matches the current signal symbol.
11872
f2d3ba6f
DN
118732011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11874
11875 * alloc.c (check_sblock, check_string_bytes)
11876 (check_string_free_list): Convert to standard C.
11877
42ce4c63
TZ
118782011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11879
11880 * w32.c (emacs_gnutls_push): Fix typo.
11881
825cd63c
EZ
118822011-04-25 Eli Zaretskii <eliz@gnu.org>
11883
fb11d64d
EZ
11884 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11885 "cast to pointer from integer of different size".
11886
825cd63c
EZ
11887 Improve doprnt and its use in verror. (Bug#8545)
11888 * doprnt.c (doprnt): Document the set of format control sequences
11889 supported by the function. Use SAFE_ALLOCA instead of always
11890 using `alloca'.
11891
11892 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11893 is one byte too soon. Don't use xrealloc; instead xfree and
11894 xmalloc anew.
11895
e061a11b
TZ
118962011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11897
11898 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11899 callbacks stage.
11900
11901 * gnutls.c: Renamed global_initialized to
11902 gnutls_global_initialized. Added internals for the
11903 :verify-hostname-error, :verify-error, and :verify-flags
11904 parameters of `gnutls-boot' and documented those parameters in the
11905 docstring. Start callback support.
9173deec
JB
11906 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11907 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11908 on error. Return error code.
e061a11b
TZ
11909 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11910 (emacs_gnutls_read): Likewise.
11911 (Fgnutls_boot): Return handshake error code.
11912 (emacs_gnutls_handle_error): New function.
11913 (wsaerror_to_errno): Likewise.
11914
11915 * w32.h (emacs_gnutls_pull): Add prototype.
11916 (emacs_gnutls_push): Likewise.
11917
11918 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11919 (emacs_gnutls_push): Likewise.
11920
119212011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11922
11923 * process.c (wait_reading_process_output): Check if GnuTLS
11924 buffered some data internally if no FDs are set for TLS
11925 connections.
11926
11927 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11928 (LIBS): Link to USER_LIBS.
11929 ($(BLD)/gnutls.$(0)): New target.
11930
fa6996bc
EZ
119312011-04-24 Eli Zaretskii <eliz@gnu.org>
11932
eb35682e
EZ
11933 * xdisp.c (handle_single_display_spec): Rename the
11934 display_replaced_before_p argument into display_replaced_p, to
11935 make it consistent with the commentary. Fix typos in the
11936 commentary.
11937
e2ad650c
EZ
11938 * textprop.c (syms_of_textprop): Remove dead code.
11939 (copy_text_properties): Delete obsolete commentary about an
11940 interface that was deleted long ago. Fix typos in the description
11941 of arguments.
11942
1b2de274
EZ
11943 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11944 to changes in oldXMenu/XMenu.h from 2011-04-16.
11945 <menu_help_message, prev_menu_help_message>: Constify.
11946 (IT_menu_make_room): menu->help_text is now `const char **';
11947 adjust.
11948
11949 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11950 to changes in oldXMenu/XMenu.h from 2011-04-16.
11951 (struct XMenu): Declare `help_text' `const char **'.
11952
11953 * xfaces.c <Qunspecified>: Make extern again.
11954
11955 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11956 required by POSIX.
1b2de274 11957
762b15be
EZ
11958 * doc.c (get_doc_string): Improve the format passed to `error'.
11959
11960 * doprnt.c (doprnt): Improve commentary.
11961
11962 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11963
11964 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11965 them with etags.
11966
f1052e5d
EZ
11967 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11968 changes in globals.h immediately force recompilation.
762b15be
EZ
11969 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11970 $(CURDIR)/s/ms-w32.h.
11971 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11972
fa6996bc
EZ
11973 * character.c (Fchar_direction): Function deleted.
11974 (syms_of_character): Don't defsubr it.
11975 <char-direction-table>: Deleted.
11976
e6c3da20
EZ
119772011-04-23 Eli Zaretskii <eliz@gnu.org>
11978
11979 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11980 * doprnt.c: Include limits.h.
11981 (SIZE_MAX): New macro.
04f2d78b
CB
11982 (doprnt): Return a size_t value. 2nd arg is now size_t.
11983 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11984 Improve overflow protection. Support `l' modifier for integer
11985 conversions. Support %l conversion. Don't assume an EMACS_INT
11986 argument for integer conversions and for %c.
11987
11988 * lisp.h (doprnt): Restore prototype.
11989
11990 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11991 $(SRC)/character.h.
11992
11993 * Makefile.in (base_obj): Add back doprnt.o.
11994
11995 * deps.mk (doprnt.o): Add back prerequisites.
11996 (callint.o): Depend on character.h.
11997
11998 * eval.c (internal_lisp_condition_case): Include the handler
11999 representation in the error message.
12000 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12001 when breaking from the loop.
12002
12003 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12004
12005 * callint.c (Fcall_interactively): When displaying error message
12006 about invalid control letter, pass the character's codepoint, not
12007 a pointer to its multibyte form. Improve display of the character
12008 in octal and display also its hex code.
12009
12010 * character.c (char_string): Use %x to display the (unsigned)
12011 codepoint of an invalid character, to avoid displaying a bogus
12012 negative value.
12013
12014 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12015 `error', not SYMBOL_NAME itself.
12016
12017 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12018 character arguments to `error'.
12019
12020 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12021 to `error' in error message about FINAL_CHAR argument. Make sure
12022 FINAL_CHAR is a character, and use %c when it is passed as
12023 argument to `error'.
12024
4ffd0d6b 120252011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12026
12027 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12028
12029 * w32.c: Include <time.h>.
12030 (sys_localtime): New function.
12031
4ffd0d6b 120322011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12033
12034 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12035
4ffd0d6b 12036 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12037
4ffd0d6b 120382011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12039
4ffd0d6b
GM
12040 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12041 zombies (Bug#8467).
aac0c6e3 12042
04c56954
EZ
120432011-04-19 Eli Zaretskii <eliz@gnu.org>
12044
12045 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12046 gl_state.e_property when gl_state.object is Qt.
12047
12048 * insdel.c (make_gap_larger): Remove limitation of buffer size
12049 to <= INT_MAX.
12050
16a43933
CY
120512011-04-18 Chong Yidong <cyd@stupidchicken.com>
12052
12053 * xdisp.c (lookup_glyphless_char_display)
12054 (produce_glyphless_glyph): Handle cons cell entry in
12055 glyphless-char-display.
12056 (Vglyphless_char_display): Document it.
12057
12058 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12059 glyphless-char-display.
12060
4581706e
CY
120612011-04-17 Chong Yidong <cyd@stupidchicken.com>
12062
12063 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12064
12065 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12066
12067 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12068 definition for no-X builds.
12069
4887c6e2 120702011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12071
fd35b6f9
PE
12072 Static checks with GCC 4.6.0 and non-default toolkits.
12073
5c1ccb01
PE
12074 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12075
006c5daa
PE
12076 * process.c (keyboard_bit_set): Define only if SIGIO.
12077 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12078 (send_process): Repair possible setjmp clobbering.
12079
efc736d3
PE
12080 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12081
4e2fe2e6
PE
12082 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12083
f97334a2
PE
12084 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12085
4e75f29d
PE
12086 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12087 Define only if needed.
12088
90efadd1
PE
12089 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12090 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12091 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12092
3c647824
PE
12093 * dispextern.h (struct redisplay_interface): Rename param
12094 to avoid shadowing.
e264f262 12095 * termhooks.h (struct terminal): Likewise.
761383f4 12096 * xterm.c (xembed_send_message): Likewise.
3c647824 12097
b58c5c4a
PE
12098 * insdel.c (make_gap_smaller): Define only if
12099 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12100
cad59032
PE
12101 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12102 it.
12103
c339dc2e
PE
12104 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12105 so that we aren't warned about unused symbols.
12106
91a3e27b
PE
12107 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12108
399c71d3 12109 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12110
8ffc96f5
PE
12111 * xfns.c (x_real_positions): Mark locals as initialized.
12112
eef9bc79
PE
12113 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12114
098db9dd
PE
12115 * xterm.c: Fix problems found by static analysis with other toolkits.
12116 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12117 (x_dispatch_event): Declare static if USE_GTK, and
12118 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12119 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12120 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12121 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12122 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12123
eb18f6cc
PE
12124 * xmenu.c (menu_help_callback): Pointer type fixes.
12125 Use const pointers when pointing at readonly data. Avoid pointer
12126 signedness clashes.
12127 (FALSE): Remove unused macro.
12128 (update_frame_menubar): Remove unused decl.
12129
1fe72bf8
PE
12130 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12131
60d9e1db
PE
12132 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12133 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12134 (single_menu_item): Rename local to avoid shadowing.
12135
39261c26
PE
12136 * keyboard.c (make_lispy_event): Remove unused local var.
12137
018c5e19
PE
12138 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12139 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12140
63d2b86e
PE
12141 * bitmaps: Change bitmaps from unsigned char back to the X11
12142 compatible char. Avoid the old compiler warnings about
12143 out-of-range initializers by using, for example, '\xab' rather
12144 than 0xab.
12145
aefd87e1
PE
12146 * xgselect.c (xgselect_initialize): Check vs interface
12147 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12148
bf501fb9
PE
12149 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12150
e9829fdf
PE
12151 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12152 to read-only memory.
12153
1086c095
PE
12154 * fns.c (vector): Remove; this old hack is no longer needed.
12155
2baccd04 12156 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12157 Remove unused var.
dde42981 12158 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12159
72391843 12160 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12161
436c16df 12162 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12163 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12164 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12165
92bb796d 12166 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12167 (x_term_init): Remove local to avoid shadowing.
92bb796d 12168
764430a3 12169 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12170
12171 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12172 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12173
d1dfb56c
EZ
121742011-04-16 Eli Zaretskii <eliz@gnu.org>
12175
c4354cb4
EZ
12176 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12177
d1dfb56c
EZ
12178 Fix regex.c, syntax.c and friends for buffers > 2GB.
12179 * syntax.h (struct gl_state_s): Declare character position members
12180 EMACS_INT.
12181
12182 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12183
04f2d78b
CB
12184 * textprop.c (verify_interval_modification, interval_of):
12185 Declare arguments EMACS_INT.
d1dfb56c
EZ
12186
12187 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12188 EMACS_INT.
12189
12190 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12191
12192 * indent.c (Fvertical_motion): Local variable it_start is now
12193 EMACS_INT.
12194
12195 * regex.c (re_match, re_match_2, re_match_2_internal)
12196 (bcmp_translate, regcomp, regexec, print_double_string)
12197 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12198 (re_compile_pattern, re_exec): Declare arguments and local
12199 variables `size_t' and `ssize_t' and return values `regoff_t', as
12200 appropriate.
12201 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12202 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12203 <compile_stack_type>: `size' and `avail' are now `size_t'.
12204
12205 * regex.h <regoff_t>: Use ssize_t, not int.
12206 (re_search, re_search_2, re_match, re_match_2): Arguments that
12207 specify buffer/string position and length are now ssize_t and
12208 size_t. Return type is regoff_t.
12209
613052cd
BK
122102011-04-16 Ben Key <bkey76@gmail.com>
12211
12212 * nsfont.m: Fixed bugs in ns_get_family and
12213 ns_descriptor_to_entity that were caused by using free to
12214 deallocate memory blocks that were allocated by xmalloc (via
12215 xstrdup). This caused Emacs to crash when compiled with
12216 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12217 --enable-checking=xmallocoverrun). xfree is now used to
12218 deallocate these memory blocks.
12219
4170f62f 122202011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12221
71b41406
PE
12222 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12223
9587a89d
PE
12224 emacs_write: Accept and return EMACS_INT for sizes.
12225 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12226 et seq.
12227 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12228 Accept and return EMACS_INT.
12229 (emacs_gnutls_write): Return the number of bytes written on
12230 partial writes.
12231 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12232 (emacs_read, emacs_write): Remove check for negative size, as the
12233 Emacs source code has been audited now.
9587a89d
PE
12234 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12235 (emacs_read, emacs_write): Use it.
273a5f82
PE
12236 * process.c (send_process): Adjust to the new signatures of
12237 emacs_write and emacs_gnutls_write. Do not attempt to store
12238 a byte offset into an 'int'; it might overflow.
9587a89d 12239 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12240
3e047f51
PE
12241 * sound.c: Don't assume sizes fit in 'int'.
12242 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12243 Return EMACS_INT, not int.
3e047f51 12244 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12245 Accept EMACS_INT, not int.
12246 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12247 record read return values.
12248
cc39a9db
BK
122492011-04-15 Ben Key <bkey76@gmail.com>
12250
c9d0ec6d
JB
12251 * keyboard.c (Qundefined): Don't declare static since it is used
12252 in nsfns.m.
12253 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12254 static since they are used in nsfont.m.
cc39a9db 12255
6c60eb9f
SM
122562011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12257
12258 * process.c (Qprocessp): Don't declare static.
12259 * lisp.h (Qprocessp): Declare again.
12260
7990b61a
JB
122612011-04-15 Juanma Barranquero <lekktu@gmail.com>
12262
12263 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12264
5d4cb038
PE
122652011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12266
8bd7b830 12267 Improve C-level modularity by making more things 'static'.
cd64ea1d 12268
e3b27b31
PE
12269 Don't publish debugger-only interfaces to other modules.
12270 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12271 (verify_bytepos, count_markers): Move decls to the only modules
12272 that need them.
12273 * region-cache.h (pp_cache): Likewise.
12274 * window.h (check_all_windows): Likewise.
12275 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12276
5d4cb038
PE
12277 * sysdep.c (croak): Now static, if
12278 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12279 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12280
12281 * alloc.c (refill_memory_reserve): Now static if
12282 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12283 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12284
e87b6180
PE
12285 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12286 Define only if USE_LUCID.
12287
ac64929e
PE
12288 * xrdb.c (x_customization_string, x_rm_string): Now static.
12289
6f37259d
PE
12290 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12291 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12292
1683e3ab
PE
12293 * xdisp.c (draw_row_with_mouse_face): Now static.
12294 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12295
de9c2632
PE
12296 * window.h (check_all_windows): Mark externally visible.
12297
2b96acb7
PE
12298 * window.c (window_deletion_count): Now static.
12299
12300 * undo.c: Make symbols static if they're not exported.
12301 (last_undo_buffer, last_boundary_position, pending_boundary):
12302 Now static.
12303
50436f33
PE
12304 * textprop.c (interval_insert_behind_hooks): Now static.
12305 (interval_insert_in_front_hooks): Likewise.
12306
64520e5c
PE
12307 * term.c: Make symbols static if they're not exported.
12308 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12309 (max_frame_lines, tty_set_terminal_modes):
12310 (tty_reset_terminal_modes, tty_turn_off_highlight):
12311 (get_tty_terminal): Now static.
12312 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12313 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12314 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12315 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12316 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12317
1fa53021
PE
12318 * sysdep.c: Make symbols static if they're not exported.
12319 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12320 Now static.
12321 (sigprocmask_set, full_mask): Remove; unused.
12322 (wait_debugging): Mark as visible.
12323 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12324 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12325
d4b43b22
PE
12326 * syntax.c (syntax_temp): Define only if !__GNUC__.
12327
b7c513d0
PE
12328 * sound.c (current_sound_device, current_sound): Now static.
12329
989b29ad
PE
12330 * search.c (searchbufs, searchbuf_head): Now static.
12331
13a55a78
PE
12332 * scroll.c (scroll_cost): Remove; unused.
12333 * dispextern.h (scroll_cost): Remove decl.
12334
de68a1fc
PE
12335 * region-cache.h (pp_cache): Mark as externally visible.
12336
40ccffa6
PE
12337 * process.c: Make symbols static if they're not exported.
12338 (process_tick, update_tick, create_process, chan_process):
12339 (Vprocess_alist, proc_buffered_char, datagram_access):
12340 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12341 (deactivate_process): Mark defn as static, as well as decl.
12342 * lisp.h (create_process): Remove decl.
12343 * process.h (chan_process, Vprocess_alist): Remove decls.
12344
ad64fc97
PE
12345 * print.c: Make symbols static if they're not exported.
12346 (print_depth, new_backquote_output, being_printed, print_buffer):
12347 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12348 (print_interval, print_number_index, initial_stderr_stream):
12349 Now static.
12350 * lisp.h (Fprinc): Remove decl.
12351 (debug_output_compilation_hack): Mark as externally visible.
12352
adddb265
PE
12353 * sysdep.c (croak): Move decl from here to syssignal.h.
12354 * syssignal.h (croak): Put it here, so the API can be checked when
12355 'croak' is called from dissociate_if_controlling_tty.
12356
1717ede2
PE
12357 * minibuf.c: Make symbols static if they're not exported.
12358 (minibuf_save_list, choose_minibuf_frame): Now static.
12359 * lisp.h (choose_minibuf_frame): Remove decl.
12360
fa5fb2bc
PE
12361 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12362
1e3890d1
PE
12363 * lread.c: Make symbols static if they're not exported.
12364 (read_objects, initial_obarray, oblookup_last_bucket_number):
12365 Now static.
12366 (make_symbol): Remove; unused.
12367 * lisp.h (initial_obarray, make_symbol): Remove decls.
12368
8a1414fa
PE
12369 * keyboard.c: Make symbols static if they're not exported.
12370 (single_kboard, recent_keys_index, total_keys, recent_keys):
12371 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12372 (this_single_command_key_start, echoing, last_auto_save):
12373 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12374 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12375 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12376 (Vlispy_mouse_stem, double_click_count):
12377 Now static.
12378 (force_auto_save_soon): Define only if SIGDANGER.
12379 (ignore_mouse_drag_p): Now static if
12380 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12381 (print_help): Remove; unused.
12382 (stop_character, last_timer_event): Mark as externally visible.
12383 * keyboard.h (ignore_mouse_drag_p): Declare only if
12384 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12385 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12386 * lisp.h (echoing): Remove decl.
12387 (force_auto_save_soon): Declare only if SIGDANGER.
12388 * xdisp.c (redisplay_window): Simplify code, to make it more
12389 obvious that ignore_mouse_drag_p is not accessed if !defined
12390 USE_GTK && !defined HAVE_NS.
12391
93ea6e8f
PE
12392 * intervals.c: Make symbols static if they're not exported.
12393 (merge_properties_sticky, merge_interval_right, delete_interval):
12394 Now static.
12395 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12396
77382fcc
PE
12397 * insdel.c: Make symbols static if they're not exported.
12398 However, leave prepare_to_modify_buffer alone. It's never
12399 called from outside this function, but that appears to be a bug.
12400 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12401 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12402 (adjust_after_replace_noundo): Remove; unused.
12403 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12404 (signal_before_change): Remove decls.
77382fcc 12405
9306c32e
PE
12406 * indent.c (val_compute_motion, val_vmotion): Now static.
12407
cd44d2eb
PE
12408 * image.c: Make symbols static if they're not exported.
12409 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12410 if USE_GTK.
12411 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12412 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12413
ad9a7a06
PE
12414 * fringe.c (standard_bitmaps): Now static.
12415 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12416
81626931
PE
12417 * frame.c: Make symbols static if they're not exported.
12418 (x_report_frame_params, make_terminal_frame): Now static.
12419 (get_frame_param): Now static, unless HAVE_NS.
12420 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12421 (x_get_resource_string): Remove; not used.
12422 * frame.h (make_terminal_frame, x_report_frame_params):
12423 (x_get_resource_string); Remove decls.
12424 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12425 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12426
239f9db9
PE
12427 * font.c, fontset.c: Make symbols static if they're not exported.
12428 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12429 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12430 * font.c (font_close_object): Now static.
12431 * font.h (font_close_object): Remove.
12432 * fontset.c (FONTSET_OBJLIST): Remove.
12433 (free_realized_fontset) #if-0 the body, which does nothing.
12434 (face_suitable_for_char_p): #if-0, as it's never called.
12435 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12436 * xfaces.c (face_at_string_position):
12437 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12438 since 0 is always ASCII.
12439
dfcf3579
PE
12440 * fns.c (weak_hash_tables): Now static.
12441
5045092b
PE
12442 * fileio.c: Make symbols static if they're not exported.
12443 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12444 (Vwrite_region_annotation_buffers): Now static.
12445
57a96f5c
PE
12446 * eval.c: Make symbols static if they're not exported.
12447 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12448 * lisp.h (backtrace_list): Remove decl.
12449
35f08c38
PE
12450 * emacs.c: Make symbols static if they're not exported.
12451 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12452 (fatal_error_code, fatal_error_signal_hook, standard_args):
12453 Now static.
12454 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12455 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12456 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12457 * lisp.h (fatal_error_signal_hook): Remove decl.
12458 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12459
f44bd759
PE
12460 * editfns.c: Move a (normally-unused) function to its only use.
12461 * editfns.c, lisp.h (get_operating_system_release): Remove.
12462 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12463 worth the hassle of breaking this out.
12464
b532497d
PE
12465 * xterm.c: Make symbols static if they're not exported.
12466 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12467 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12468 (x_destroy_window, x_delete_display):
12469 Now static.
12470 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12471 (x_mouse_leave): Remove; unused.
12472 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12473 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12474 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12475 Remove decls.
12476 (x_mouse_leave): Declare only if WINDOWSNT.
12477 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12478 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12479 USE_X_TOOLKIT.
12480
1675728f
PE
12481 * ftxfont.c: Make symbols static if they're not exported.
12482 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12483 HAVE_FREETYPE.
12484 * font.h (ftxfont_driver): Likewise.
12485
e4cebfca
PE
12486 * xfns.c: Make symbols static if they're not exported.
12487 (x_last_font_name, x_display_info_for_name):
12488 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12489 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12490 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12491 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12492 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12493 (last_show_tip_args): Now static.
12494 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12495 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12496 (x_screen_planes): Remove; unused.
12497 * dispextern.h (x_screen_planes): Remove decl.
12498
5bf46f05
PE
12499 * dispnew.c: Make symbols static if they're not exported.
12500 * dispextern.h (redraw_garbaged_frames, scrolling):
12501 (increment_row_positions): Remove.
12502 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12503 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12504 Now static.
12505 (redraw_garbaged_frames): Remove; unused.
12506
435f4c28
PE
12507 * xfaces.c: Make symbols static if they're not exported.
12508 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12509 Remove decls.
12510 * xterm.h (defined_color): Remove decls.
12511 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12512 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12513 (menu_face_changed_default, defined_color, free_realized_face):
12514 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12515 (ascii_face_of_lisp_face): Remove; unused.
12516
8524aef3
PE
12517 * xdisp.c: Make symbols static if they're not exported.
12518 * dispextern.h (scratch_glyph_row, window_box_edges):
12519 (glyph_to_pixel_coords, set_cursor_from_row):
12520 (get_next_display_element, set_iterator_to_next):
12521 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12522 (show_mouse_face): Remove decls
12523 * frame.h (message_buf_print): Likewise.
12524 * lisp.h (pop_message, set_message, check_point_in_composition):
12525 Likewise.
12526 * xterm.h (set_vertical_scroll_bar): Likewise.
12527 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12528 (message_buf_print, scratch_glyph_row, displayed_buffer):
12529 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12530 (get_next_display_element, show_mouse_face, window_box_edges):
12531 (frame_to_window_pixel_xy, check_point_in_composition):
12532 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12533 (glyph_to_pixel_coords): Remove; unused.
12534
16390cd2
PE
12535 * dired.c (file_name_completion): Now static.
12536
12537 * dbusbind.c (xd_in_read_queued_messages): Now static.
12538
a25f4dfa
PE
12539 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12540 * data.c (circular_list_error): Remove.
12541
14a9c8df
PE
12542 * commands.h (last_point_position, last_point_position_buffer):
12543 (last_point_position_window): Remove decls.
12544 * keyboard.c: Make these variables static.
12545
04f2d78b
CB
12546 * coding.h (coding, code_convert_region, encode_coding_gap):
12547 Remove decls.
74ab6df5
PE
12548 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12549 (iso_code_class, detect_coding, code_convert_region): Now static.
12550 (encode_coding_gap): Remove; unused.
12551
38dfbee1
PE
12552 * chartab.c (chartab_chars, chartab_bits): Now static.
12553
a2cb4e63
PE
12554 * charset.h (charset_iso_8859_1): Remove decl.
12555 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12556 Now static.
12557
127198fd
PE
12558 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12559 * ccl.c (Vccl_program_table): Now static.
12560 (check_ccl_update): Remove; unused.
12561
d85b608f
PE
12562 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12563 * category.h: ... from here.
12564 * category.c (check_category_table, set_category_set): Now static.
12565
31cd66f3
PE
12566 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12567 * lisp.h: Remove these decls.
12568
c358e587
PE
12569 * buffer.c (buffer_count): Remove unused var.
12570
e78aecca
PE
12571 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12572 so that it's not optimized away.
12573 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12574 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12575 exported only to the debugger.
12576
e192d7d3 12577 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12578 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12579
92470028
PE
12580 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12581 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12582 was inaccessible from Lisp.
12583 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12584 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12585
244ed907
PE
12586 alloc.c: Import and export fewer symbols, and remove unused items.
12587 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12588 is defined.
12589 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12590 it's not optimized away by whole-program optimization.
12591 (message_enable_multibyte, free_misc): Remove.
12592 (catchlist, handlerlist, mark_backtrace):
12593 Declare only if BYTE_MARK_STACK.
12594 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12595 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12596 (message_enable_multibyte): Remove decl.
12597 (free_misc, interval_free_list, float_block, float_block_index):
12598 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12599 (cons_free_list, last_marked_index):
12600 Now static.
12601 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12602 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12603 (mark_backtrace): Define only if BYTE_MARK_STACK.
12604 * xdisp.c (message_enable_multibyte): Now static.
12605
61c2b50e 12606 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12607 This makes it easier for human readers (and static analyzers)
12608 to see whether these variables are used from other modules.
12609 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12610 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12611 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12612 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12613 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12614 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12615 * xmenu.c, xselect.c:
12616 Declare Q* vars static if they are not used in other modules.
12617 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12618 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12619 Remove decls of unexported vars.
12620 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12621
95c82688
PE
12622 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12623
16a97296
PE
12624 Make Emacs functions such as Fatom 'static' by default.
12625 This makes it easier for human readers (and static analyzers)
12626 to see whether these functions can be called from other modules.
12627 DEFUN now defines a static function. To make the function external
12628 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12629 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12630 (Finit_image_library):
16a97296
PE
12631 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12632 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12633 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12634 Remove decls, since these functions are now static.
12635 (Funintern, Fget_internal_run_time): New decls, since these functions
12636 were already external.
95c82688 12637
16a97296
PE
12638 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12639 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12640 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12641 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12642 * keyboard.c, keymap.c, lread.c:
12643 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12644 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12645 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12646 Mark functions with DEFUE instead of DEFUN,
12647 if they are used in other modules.
12648 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12649 decls for now-static functions.
12650 * buffer.h (Fdelete_overlay): Remove decl.
12651 * callproc.c (Fgetenv_internal): Mark as internal.
12652 * composite.c (Fremove_list_of_text_properties): Remove decl.
12653 (Fcomposition_get_gstring): New forward static decl.
12654 * composite.h (Fcomposite_get_gstring): Remove decl.
12655 * dired.c (Ffile_attributes): New forward static decl.
12656 * doc.c (Fdocumntation_property): New forward static decl.
12657 * eval.c (Ffetch_bytecode): New forward static decl.
12658 (Funintern): Remove extern decl; now in .h file where it belongs.
12659 * fileio.c (Fmake_symbolic_link): New forward static decl.
12660 * image.c (Finit_image_library): New forward static decl.
12661 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12662 * intervals.h (Fprevious_property_change):
12663 (Fremove_list_of_text_properties): Remove decls.
12664 * keyboard.c (Fthis_command_keys): Remove decl.
12665 (Fcommand_execute): New forward static decl.
12666 * keymap.c (Flookup_key): New forward static decl.
12667 (Fcopy_keymap): Now static.
12668 * keymap.h (Flookup_key): Remove decl.
12669 * process.c (Fget_process): New forward static decl.
12670 (Fprocess_datagram_address): Mark as internal.
12671 * syntax.c (Fsyntax_table_p): New forward static decl.
12672 (skip_chars): Remove duplicate decl.
12673 * textprop.c (Fprevious_property_change): New forward static decl.
12674 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12675 Now internal.
12676 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12677 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12678
785bbd42
PE
12679 * editfns.c (Fformat): Remove unreachable code.
12680
8b913b57
AS
126812011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12682
12683 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12684 change. (Bug#8496)
12685
a6744a35
EZ
126862011-04-13 Eli Zaretskii <eliz@gnu.org>
12687
12688 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12689 when at ZV. (Bug#8487)
12690
e7974947
AS
126912011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12692
baad03f0
AS
12693 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12694 (Bug#8437)
12695 * keyboard.c (parse_tool_bar_item): Likewise.
12696 * sound.c (sound_cleanup, alsa_close): Likewise.
12697 * termcap.c (tgetent): Likewise.
12698 * xfns.c (x_default_font_parameter): Likewise.
12699 * xsettings.c (read_and_apply_settings): Likewise.
12700
e7974947
AS
12701 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12702 (overrun_check_free): Protoize.
12703
28272684
PE
127042011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12705
12706 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12707 since callers should never pass a negative size.
12708 Change the signature to match that of plain 'read' and 'write'; see
12709 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12710 * lisp.h: Update prototypes of emacs_write and emacs_read.
12711
11997c76
EZ
127122011-04-11 Eli Zaretskii <eliz@gnu.org>
12713
12714 * xdisp.c (redisplay_window): Don't try to determine the character
12715 position of the scroll margin if the window start point w->startp
e896f03c 12716 is outside the buffer's accessible region. (Bug#8468)
11997c76 12717
8a2cbd72
EZ
127182011-04-10 Eli Zaretskii <eliz@gnu.org>
12719
12720 Fix write-region and its subroutines for buffers > 2GB.
12721 * fileio.c (a_write, e_write): Modify declaration of arguments and
12722 local variables to support buffers larger than 2GB.
12723 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12724
12725 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12726 argument, local variables, and return value.
12727
12728 * lisp.h: Update prototypes of emacs_write and emacs_read.
12729
12730 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12731
4073e537 127322011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12733
1ebfdcb6
PE
12734 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12735
b2ded58d
PE
12736 Fix more problems found by GCC 4.6.0's static checks.
12737
7d66342c
PE
12738 * xdisp.c (vmessage): Use a better test for character truncation.
12739
bbf47d44
PE
12740 * charset.c (load_charset_map): <, not <=, for optimization,
12741 and to avoid potential problems with integer overflow.
9248994d 12742 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12743 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12744 * editfns.c (Fformat): Likewise.
1e69125e 12745 * syntax.c (skip_chars): Likewise.
3befa583 12746
e3019616
PE
12747 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12748 This also lets GCC 4.6.0 generate slightly better loop code.
12749
becfa255
PE
12750 * callint.c (Fcall_interactively): <, not <=, for optimization.
12751 (Fcall_interactively): Count the number of arguments produced,
12752 not the number of arguments given. This is simpler and lets GCC
12753 4.6.0 generate slightly better code.
12754
dae0cd48
PE
12755 * ftfont.c: Distingish more carefully between FcChar8 and char.
12756 The previous code passed unsigned char * to a functions like
12757 strlen and xstrcasecmp that expect char *, which does not
12758 conform to the C standard.
12759 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12760 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12761 char * when the C standard requires it.
12762
76032d70
PE
12763 * keyboard.c (read_char): Remove unused var.
12764
eb3f1cc8
PE
12765 * eval.c: Port to Windows vsnprintf (Bug#8435).
12766 Include <limits.h>.
12767 (SIZE_MAX): Define if the headers do not.
12768 (verror): Do not give up if vsnprintf returns a negative count.
12769 Instead, grow the buffer. This ports to Windows vsnprintf, which
12770 does not conform to C99. Problem reported by Eli Zaretskii.
12771 Also, simplify the allocation scheme, by avoiding the need for
12772 calling realloc, and removing the ALLOCATED variable.
12773
70476b54
PE
12774 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12775
12020a9e
PE
12776 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12777 But keep the doprint source code for now, as we might revamp it
12778 and use it again (Bug#8435).
ea6c7ae6
PE
12779 * lisp.h (doprnt): Remove.
12780 * Makefile.in (base_obj): Remove doprnt.o.
12781 * deps.mk (doprnt.o): Remove.
12782
5fdb398c
PE
12783 error: Print 32- and 64-bit integers portably (Bug#8435).
12784 Without this change, on typical 64-bit hosts error ("...%d...", N)
12785 was used to print both 32- and 64-bit integers N, which relied on
12786 undefined behavior.
61bdb816 12787 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12788 * lisp.h (error, verror): Mark as printf-like functions.
12789 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12790 Report overflow in size calculations when allocating printf buffer.
12791 Do not truncate output string at its first null byte.
12792 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12793 Truncate the output at a character boundary, since vsnprintf does not
12794 do that.
12795 * charset.c (check_iso_charset_parameter): Convert internal
12796 character to string before calling 'error', since %c now has the
12797 printf meaning.
12798 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12799 overflow when computing char to be passed to 'error'. Do not
12800 pass Lisp_Object to 'error'; pass the integer instead.
12801 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12802 formatted with plain %d.
12803
b189fa66
PE
12804 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12805
bff87ef0
PE
12806 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12807
7e2cac20
PE
12808 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12809
ce4d90b5
PE
12810 * xterm.c (x_catch_errors): Remove duplicate declaration.
12811
266c9547
PE
12812 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12813
79c49ad2
PE
12814 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12815
368f4090
JM
128162011-04-10 Jim Meyering <meyering@redhat.com>
12817
12818 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12819 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12820 return ssize_t not "int", and use size_t as the buffer length.
12821 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12822 * gnutls.h: Update declarations.
12823 * process.c (read_process_output): Use ssize_t, to match.
12824 (send_process): Likewise.
12825
a32d4040
CY
128262011-04-09 Chong Yidong <cyd@stupidchicken.com>
12827
12828 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12829
8546720e 128302011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12831
04f2d78b
CB
12832 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12833 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12834
8546720e
GM
12835 * xterm.c (handle_one_xevent):
12836 * xmenu.c (create_and_show_popup_menu):
12837 * xselect.c (x_decline_selection_request)
12838 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12839
0a2f5c1a 128402011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12841
12842 Fix some uses of `int' instead of EMACS_INT.
12843 * search.c (string_match_1, fast_string_match)
12844 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12845 (scan_buffer, find_next_newline_no_quit)
12846 (find_before_next_newline, search_command, Freplace_match)
12847 (Fmatch_data): Make some `int' variables be EMACS_INT.
12848
12849 * xdisp.c (display_count_lines): 3rd argument and return value now
12850 EMACS_INT. All callers changed.
12851 (pint2hrstr): Last argument is now EMACS_INT.
12852
12853 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12854 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12855 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12856 (decode_coding_utf_16, decode_coding_emacs_mule)
12857 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12858 (decode_coding_ccl, decode_coding_charset)
12859 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12860 (decode_coding_iso_2022, decode_coding_emacs_mule)
12861 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12862 <char_offset, last_offset>: Declare EMACS_INT.
12863 (encode_coding_utf_8, encode_coding_utf_16)
12864 (encode_coding_emacs_mule, encode_invocation_designation)
12865 (encode_designation_at_bol, encode_coding_iso_2022)
12866 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12867 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12868 Declare EMACS_INT.
12869 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12870 (encode_invocation_designation): Last argument P_NCHARS is now
12871 EMACS_INT.
12872 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12873 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12874
12875 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12876 All users changed.
12877
12878 * ccl.c (Fccl_execute_on_string): Declare some variables
12879 EMACS_INT.
12880
8546720e 128812011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12882
12883 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12884
4e19a977
CS
128852011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12886
12887 * process.c (Fformat_network_address): Doc fix.
12888
87302331
R
128892011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12890
ee7683eb 12891 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12892
cbb59342
CY
128932011-04-08 Chong Yidong <cyd@stupidchicken.com>
12894
12895 * keyboard.c (read_char): Call Lisp function help-form-show,
12896 instead of using internal_with_output_to_temp_buffer.
12897 (Qhelp_form_show): New var.
e0d38eeb 12898 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12899
12900 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12901
12902 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12903
e67a13ab
CY
129042011-04-06 Chong Yidong <cyd@stupidchicken.com>
12905
04f2d78b
CB
12906 * process.c (Flist_processes): Remove to Lisp.
12907 (list_processes_1): Delete.
e67a13ab 12908
973f782d
EZ
129092011-04-06 Eli Zaretskii <eliz@gnu.org>
12910
7c106b1e
EZ
12911 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12912
973f782d
EZ
12913 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12914
41cf7d1a 129152011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12916
ca23cc88
PE
12917 Fix more problems found by GCC 4.6.0's static checks.
12918
f390e2d5
PE
12919 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12920
42eea0d0
PE
12921 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12922
b69769da 12923 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12924
f9541e84
PE
12925 * xdisp.c (vmessage): Mark as a printf-like function.
12926
13841b55
PE
12927 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12928
c136c10f
PE
12929 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12930
5e2d4a30
PE
12931 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12932 printf-like functions.
12933 (tiff_load): Add casts to remove these marks before passing them
12934 to system-supplied API.
12935
583f48b9
PE
12936 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12937
b25d760e
PE
12938 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12939 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12940 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12941 directly, rather than having caller test rule sign. This avoids
12942 some unnecessary tests.
12943 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12944 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12945 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12946
bc7b6697 12947 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12948 (xfont_open): Avoid unnecessary tests.
bc7b6697 12949
27ccc379
PE
12950 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12951
dcd5c89a
PE
12952 * composite.h, composite.c (composition_gstring_put_cache):
12953 Use EMACS_INT, not int, for length.
12954
b13a45c6
PE
12955 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12956 breaking out part of COMPOSITION_DECODE_RULE.
12957 (COMPOSITION_DECODE_RULE): Use it.
12958 * composite.c (get_composition_id): Remove unused local vars,
12959 by using the new macro.
12960
1e792e4d
PE
12961 * textprop.c (set_text_properties_1): Change while to do-while,
12962 since the condition is always true at first.
12963
dc6c6455 12964 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12965 (interval_deletion_adjustment): Return unsigned value.
12966 All uses changed.
dc6c6455 12967
aba7731a
PE
12968 * process.c (list_processes_1, create_pty, read_process_output):
12969 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12970 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12971 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12972 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12973 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12974
fdfc4bf3
PE
12975 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12976
fca8fe46 12977 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12978 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12979
06a0259a 12980 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12981 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12982 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12983
e7b9e80f
PE
12984 * print.c (print_error_message): Avoid int overflow.
12985
56201685
PE
12986 * font.c (font_list_entities): Redo for clarity,
12987 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12988
78834453 12989 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12990 (font_score): Avoid potential overflow in diff calculation.
78834453 12991
0bc0b309 12992 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12993 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12994
e610eaca
PE
12995 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12996
b895abce
PE
12997 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12998 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12999 can always succeed if overflow has undefined behavior.
13000
1f1d9321 13001 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13002 (wordify): Omit three unnecessary tests.
1f1d9321 13003
c59478bc
PE
13004 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13005 All callers changed. This avoids the need for an unused var.
13006
79b73827
PE
13007 * casefiddle.c (casify_region): Remove var that is set but not used.
13008
a4db5dfe
PE
13009 * dired.c (file_name_completion): Remove var that is set but not used.
13010
43aae36e
PE
13011 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13012
2a47c44d 13013 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13014 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13015
a37c69bf
PE
13016 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13017 Check for integer overflow on size calculations.
13018
328ab8e7
PE
13019 * buffer.c (Fprevious_overlay_change): Remove var that is set
13020 but not used.
13021
e5a2a5cb
PE
13022 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13023 Remove vars that are set but not used.
8d84a6eb 13024 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13025 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13026
a60e5f68
PE
13027 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13028
f661cb61 13029 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13030 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13031
f0397f5a
PE
13032 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13033 that are set but not used.
13034
8664db06 13035 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13036 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13037
6abdaa4a
PE
13038 * xselect.c (x_get_local_selection, x_handle_property_notify):
13039 Remove vars that are set but not used.
13040
0ce7538d 13041 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13042 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13043
9ae848fc
PE
13044 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13045 Remove var that is set but not used.
0b918413
PE
13046 (scroll_bar_windows_size): Now size_t, not int.
13047 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13048 Check for overflow.
9ae848fc 13049
a5a62657
PE
13050 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13051 (map_tty_color) [!defined MSDOS]: Likewise.
13052
5c5cdd39
PE
13053 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13054
66ebf983
PE
13055 * coding.c: Remove vars that are set but not used.
13056 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13057 All callers changed.
13058 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13059 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13060 (decode_coding_charset): Remove vars that are set but not used.
13061
1be4d761
PE
13062 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13063 that is set but not used.
13064
47553fa8
PE
13065 * print.c (print_object): Remove var that is set but not used.
13066
1f7196bf 13067 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13068 The gnulib version avoids calling malloc in the usual case,
13069 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13070 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13071 * filelock.c (current_lock_owner): Likewise.
13072 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13073 * sysdep.c: Include allocator.h, careadlinkat.h.
13074 (emacs_no_realloc_allocator): New static constant.
13075 (emacs_readlink): New function.
fdb61804
PE
13076 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13077 ../lib/careadlinkat.h.
d1fdcab7 13078
f84c17c7
SM
130792011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13080
13081 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13082 first non-nil return value).
13083
ef3862ad
JD
130842011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13085
13086 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13087 if not defined (Bug#8403).
13088
376a7006
JB
130892011-04-02 Juanma Barranquero <lekktu@gmail.com>
13090
13091 * xdisp.c (display_count_lines): Remove parameter `start',
13092 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13093 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13094 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13095 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13096 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13097 and thereabouts. All callers changed.
13098 (get_per_char_metric): Remove parameter `f', unused since
13099 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13100
6ca3801d
JM
131012011-04-02 Jim Meyering <meyering@redhat.com>
13102
13103 do not dereference NULL upon failed strdup
13104 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13105 (ns_get_family): Likewise.
13106
d8e2b5ba
JB
131072011-04-02 Juanma Barranquero <lekktu@gmail.com>
13108
13109 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13110
8c74fcbd
JD
131112011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13112
13113 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13114 later (Bug#8403).
13115
7200d79c
SM
131162011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13117
03408648 13118 Add lexical binding.
7200d79c 13119
03408648
SM
13120 * window.c (Ftemp_output_buffer_show): New fun.
13121 (Fsave_window_excursion):
13122 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13123
13124 * lread.c (lisp_file_lexically_bound_p): New function.
13125 (Fload): Bind Qlexical_binding.
13126 (readevalloop): Remove `evalfun' arg.
13127 Bind Qinternal_interpreter_environment.
13128 (Feval_buffer): Bind Qlexical_binding.
13129 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13130 Mark as dynamic.
13131 (syms_of_lread): Declare `lexical-binding'.
13132
13133 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13134
13135 * keyboard.c (eval_dyn): New fun.
13136 (menu_item_eval_property): Use it.
ca105506
SM
13137
13138 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13139
03408648
SM
13140 * fns.c (concat, mapcar1): Accept byte-code-functions.
13141
13142 * eval.c (Fsetq): Handle lexical vars.
13143 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13144 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13145 (FletX, Flet): Obey lexical binding.
13146 (Fcommandp): Handle closures.
13147 (Feval): New `lexical' arg.
13148 (eval_sub): New function extracted from Feval. Use it almost
13149 everywhere where Feval was used. Look up vars in lexical env.
13150 Handle closures.
13151 (Ffunctionp): Move from subr.el.
13152 (Ffuncall): Handle closures.
13153 (apply_lambda): Remove `eval_flags'.
13154 (funcall_lambda): Handle closures and new byte-code-functions.
13155 (Fspecial_variable_p): New function.
13156 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13157 but without exporting it to Lisp.
23aba0ea 13158
23aba0ea 13159 * doc.c (Fdocumentation, store_function_docstring):
03408648 13160 * data.c (Finteractive_form): Handle closures.
23aba0ea 13161
03408648
SM
13162 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13163 interactive spec.
ba83908c 13164
04f2d78b
CB
13165 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13166 New byte-codes.
03408648
SM
13167 (exec_byte_code): New function extracted from Fbyte_code to handle new
13168 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13169
03408648 13170 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13171
03408648 13172 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13173
e2abce01
JB
131742011-03-31 Juanma Barranquero <lekktu@gmail.com>
13175
13176 * xdisp.c (redisplay_internal): Fix prototype.
13177
63696a73 131782011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13179
63696a73 13180 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13181 (try_scrolling): Use it when setting scroll_limit.
13182 Limit scrolling to 100 screen lines.
63696a73
EZ
13183 (redisplay_window): Even when falling back on "recentering",
13184 position point in the window according to scroll-conservatively,
13185 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13186
13187 (try_scrolling): When point is above the window, allow searching
13188 as far as scroll_max, or one screenful, to compute vertical
13189 distance from PT to the scroll margin position. This prevents
13190 try_scrolling from unnecessarily failing when
13191 scroll-conservatively is set to a value slightly larger than the
13192 window height. Clean up the case of PT below the margin at bottom
13193 of window: scroll_max can no longer be INT_MAX. When aggressive
13194 scrolling is in use, don't let point enter the opposite scroll
13195 margin as result of the scroll.
13196 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13197 threshold of 100 lines for never-recentering scrolling.
13198
e4cc2dfc
JB
131992011-03-31 Juanma Barranquero <lekktu@gmail.com>
13200
13201 * dispextern.h (move_it_by_lines):
13202 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13203 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13204 (message_log_check_duplicate): Remove parameters `prev_bol' and
13205 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13206 (redisplay_internal): Remove parameter `preserve_echo_area',
13207 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13208
13209 * indent.c (Fvertical_motion):
13210 * window.c (window_scroll_pixel_based, Frecenter):
13211 Don't pass `need_y_p' to `move_it_by_lines'.
13212
1c470562
SM
132132011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13214
44f230aa
SM
13215 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13216 steal a few bits to be more compact.
13217 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13218 Remove unneeded casts.
13219
1c470562
SM
13220 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13221
888adce9
ZK
132222011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13223
13224 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13225 binding" message (bug#7967).
13226
f838ed7b
PE
132272011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13228
77861b95
PE
13229 Fix more problems found by GCC 4.6.0's static checks.
13230
de6dbc14
PE
13231 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13232 Remove unused local var.
13233
f838ed7b
PE
13234 * editfns.c (Fmessage_box): Remove unused local var.
13235
792c7b2b
PE
13236 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13237 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13238 Omit unused local vars.
c499e557 13239 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13240 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13241 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13242 Omit unused local var.
13243
ba0165e1
PE
13244 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13245 Don't assume string length fits in int.
32ad8845 13246 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13247 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13248
3c59b4c9
PE
13249 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13250 instead of alloca (Bug#8344).
13251
a3eed478 13252 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13253 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13254
eb4d412d
PE
13255 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13256
1658b401
PE
13257 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13258 concerns.
13259
13260 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13261
13262 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13263
9a2c6e05
PE
13264 * keyboard.c (syms_of_keyboard): Use the same style as later
13265 in this function when indexing through an array. This also
13266 works around GCC bug 48267.
13267
03d0a109
PE
13268 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13269
44f730c8
PE
13270 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13271
fe75f926
PE
13272 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13273 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13274
ffa8c828
PE
13275 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13276 This avoids undefined behavior on integer overflow, and is a bit
13277 more convenient anyway since it is compared to a size_t variable.
13278
c5101a77
PE
13279 Variadic C functions now count arguments with size_t, not int.
13280 This avoids an unnecessary limitation on 64-bit machines, which
13281 caused (substring ...) to crash on large vectors (Bug#8344).
13282 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13283 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13284 All variadic functions and their callers changed accordingly.
c5101a77
PE
13285 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13286 * data.c (arith_driver, float_arith_driver): Likewise.
13287 * editfns.c (general_insert_function): Likewise.
13288 * eval.c (struct backtrace.nargs, interactive_p)
13289 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13290 (funcall_lambda, mark_backtrace): Likewise.
13291 * fns.c (concat): Likewise.
13292 * frame.c (x_set_frame_parameters): Likewise.
13293 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13294 0 if not found, not -1. All callers changed.
13295
dd3f25f7
PE
13296 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13297 (stack_copy_size): Now size_t, not int.
13298 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13299
461c2ab9
JB
133002011-03-28 Juanma Barranquero <lekktu@gmail.com>
13301
13302 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13303 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13304 All callers changed.
13305
13306 * lisp.h (multibyte_char_to_unibyte):
13307 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13308 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13309 * character.h (CHAR_TO_BYTE8):
13310 * cmds.c (internal_self_insert):
13311 * editfns.c (general_insert_function):
13312 * keymap.c (push_key_description):
13313 * search.c (Freplace_match):
13314 * xdisp.c (message_dolog, set_message_1): All callers changed.
13315
f6d62986
SM
133162011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13317
13318 * keyboard.c (safe_run_hook_funcall): New function.
13319 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13320 don't set the hook to nil, but remove the offending function instead.
13321 (Qcommand_hook_internal): Remove, unused.
13322 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13323 Vcommand_hook_internal.
13324
13325 * eval.c (enum run_hooks_condition): Remove.
13326 (funcall_nil, funcall_not): New functions.
13327 (run_hook_with_args): Call each function through a `funcall' argument.
13328 Remove `cond' argument, now redundant.
13329 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13330 (Frun_hook_with_args_until_failure): Adjust accordingly.
13331 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13332
1db5b1ad
JB
133332011-03-28 Juanma Barranquero <lekktu@gmail.com>
13334
13335 * dispextern.h (string_buffer_position): Remove declaration.
13336
13337 * print.c (strout): Remove parameter `multibyte', unused since
13338 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13339
13340 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13341 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13342 All callers changed.
13343
13344 * w32.c (_wsa_errlist): Use braces for struct initializers.
13345
13346 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13347 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13348 All callers changed.
13349 (string_buffer_position): Likewise. Also, make static (it's never
13350 used outside xdisp.c).
13351 (cursor_row_p): Remove parameter `w', unused since
13352 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13353 (decode_mode_spec): Remove parameter `precision', introduced during
13354 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13355 All callers changed.
13356
5ffb62aa
JD
133572011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13358
13359 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13360
461c2ab9 133612011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13362
13363 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13364 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13365 (ns_update_auto_hide_menu_bar): New functions.
13366 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13367 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13368 ns_constrain_all_frames.
13369 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13370 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13371
5c380ffb
JD
133722011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13373
13374 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13375
9af30bdf
GM
133762011-03-27 Glenn Morris <rgm@gnu.org>
13377
13378 * syssignal.h: Replace RETSIGTYPE with void.
13379 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13380 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13381 Replace SIGTYPE with void everywhere.
13382 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13383 * s/template.h (SIGTYPE): Remove commented out definition.
13384
e2abce01
JB
133852011-03-26 Eli Zaretskii <eliz@gnu.org>
13386
13387 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13388 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13389
f868cd8a
JB
133902011-03-26 Juanma Barranquero <lekktu@gmail.com>
13391
59eb0929
JB
13392 * w32.c (read_unc_volume): Use parameter `henum', instead of
13393 global variable `wget_enum_handle'.
13394
13395 * keymap.c (describe_vector): Remove parameters `indices' and
13396 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13397 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13398
f868cd8a
JB
13399 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13400
13401 * keyboard.c (timer_check): Remove parameter `do_it_now',
13402 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13403 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13404 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13405
13406 * keyboard.c (read_char):
13407 * w32menu.c (w32_menu_display_help):
13408 * xmenu.c (show_help_event, menu_help_callback):
13409 Adjust calls to `show_help_echo'.
13410
13411 * gtkutil.c (xg_maybe_add_timer):
13412 * keyboard.c (readable_events):
13413 * process.c (wait_reading_process_output):
13414 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13415
13416 * insdel.c (adjust_markers_gap_motion):
13417 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13418 (gap_left, gap_right): Don't call it.
13419
2ecf6fdb
CY
134202011-03-25 Chong Yidong <cyd@stupidchicken.com>
13421
13422 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13423 incurred during fontification.
13424
6b1f9ba4
JB
134252011-03-25 Juanma Barranquero <lekktu@gmail.com>
13426
13427 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13428 (DEFVAR_PER_BUFFER): Don't pass it.
13429
13430 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13431 (scrolling_window): Don't pass it.
13432
0f4a96b5
JB
134332011-03-25 Juanma Barranquero <lekktu@gmail.com>
13434
13435 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13436
13437 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13438 and `suffix'.
13439 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13440 of variables specific to SELinux and computation of `encoded_absname'.
13441
13442 * image.c (XPutPixel): Remove unused variable `height'.
13443
13444 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13445
13446 * unexw32.c (get_section_info): Remove unused variable `section'.
13447
13448 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13449 (system_process_attributes): Remove unused variable `sess'.
13450 (sys_read): Remove unused variable `err'.
13451
13452 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13453 (w32_wnd_proc): Remove unused variable `isdead'.
13454 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13455 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13456 (x_create_tip_frame): Remove unused variable `tem'.
13457
13458 * w32inevt.c (w32_console_read_socket):
13459 Remove unused variable `no_events'.
13460
13461 * w32term.c (x_draw_composite_glyph_string_foreground):
13462 Remove unused variable `width'.
13463
1149507c
JB
134642011-03-24 Juanma Barranquero <lekktu@gmail.com>
13465
13466 * w32term.c (x_set_glyph_string_clipping):
13467 Don't pass uninitialized region to CombineRgn.
13468
9c88f339
JB
134692011-03-23 Juanma Barranquero <lekktu@gmail.com>
13470
13471 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13472 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13473 (Fx_close_connection): Remove unused variable `i'.
13474
13475 * w32font.c (w32font_draw): Return number of glyphs.
13476 (w32font_open_internal): Remove unused variable `i'.
13477 (w32font_driver): Add missing initializer.
13478
13479 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13480 (fill_in_menu): Remove unused variable `items_added'.
13481
13482 * w32term.c (last_mouse_press_frame): Remove static global variable.
13483 (w32_clip_to_row): Remove unused variable `f'.
13484 (x_delete_terminal): Remove unused variable `i'.
13485
13486 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13487 (NOTHING): Remove unused static global variable.
13488 (uniscribe_check_otf): Remove unused variable `table'.
13489 (uniscribe_font_driver): Add missing initializers.
13490
dee091a3
JD
134912011-03-23 Julien Danjou <julien@danjou.info>
13492
13493 * term.c (Fsuspend_tty, Fresume_tty):
13494 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13495 * window.c (temp_output_buffer_show):
13496 * insdel.c (signal_before_change):
13497 * frame.c (Fhandle_switch_frame):
13498 * fileio.c (Fdo_auto_save):
13499 * emacs.c (Fkill_emacs):
13500 * editfns.c (save_excursion_restore):
13501 * cmds.c (internal_self_insert):
13502 * callint.c (Fcall_interactively):
13503 * buffer.c (Fkill_all_local_variables):
13504 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13505 Use Frun_hooks.
0f4a96b5 13506 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13507 unconditionally since it does the check itself.
dee091a3 13508
2c520ab5 135092011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13510
c9c49752
PE
13511 Fix more problems found by GCC 4.5.2's static checks.
13512
8abc3f12
PE
13513 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13514 the first time through the loop, since we know p0 < p1 then.
13515 This also avoids a gcc -Wstrict-overflow warning.
13516
a2d26660
PE
13517 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13518 leading to a memory leak, possible in functions like
13519 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13520 of objects (Bug#8318).
a2d26660 13521
916c72e9
PE
13522 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13523 that could (at least in theory) be that large.
13524
19ab8a18
PE
13525 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13526 This is less likely to overflow, and avoids undefined behavior if
13527 overflow does occur. All callers changed. Use strtoul to scan
13528 for the unsigned long integer.
b7cbbd6f
PE
13529 (pint2hrstr): Simplify and tune code slightly.
13530 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13531
f0641eff
PE
13532 * scroll.c (do_scrolling): Work around GCC bug 48228.
13533 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13534
7f650bb9
PE
13535 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13536 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13537 (validate_x_resource_name): Simplify count usage.
13538 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13539
37dd57d1
PE
13540 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13541 fail (Bug#8306).
81e56e61 13542
699979fc 13543 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13544
401bf9b4
PE
13545 * process.c (Fmake_network_process): Use socklen_t, not int,
13546 where POSIX says socklen_t is required in portable programs.
13547 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13548 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13549 (Fmake_network_process, server_accept_connection):
13550 (wait_reading_process_output, read_process_output):
13551 Likewise.
13552
b93aacde
PE
13553 * process.c: Rename or move locals to avoid shadowing.
13554 (list_processes_1, Fmake_network_process):
13555 (read_process_output_error_handler, exec_sentinel_error_handler):
13556 Rename or move locals.
4dc343ee 13557 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13558 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13559 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13560 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13561 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13562
af8a867c 13563 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13564 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13565 Include tparam.h instead, since it declares them.
af8a867c
PE
13566 * cm.h (PC): Remove extern decl; tparam.h now does this.
13567 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13568 * terminfo.c: Include tparam.h, to check interfaces.
13569 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13570 (tparam): Adjust signature to match interface in tparam.h;
13571 this removes some undefined behavior. Check that outstring and len
13572 are zero, which they always are with Emacs.
13573 * tparam.h (PC, BC, UP): New extern decls.
13574
0248044d 13575 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13576 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13577
8ff096c1 13578 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13579 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13580 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13581 (ftfont_list): Remove unused local.
49eaafba
PE
13582 (get_adstyle_property, ftfont_pattern_entity):
13583 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13584 Rename locals to avoid shadowing.
8ff096c1 13585
e2be39f6
PE
13586 * xfont.c (xfont_list_family): Mark var as initialized.
13587
c9735e30
PE
13588 * xml.c (make_dom): Now static.
13589
8f5201ae
PE
13590 * composite.c (composition_compute_stop_pos): Rename local to
13591 avoid shadowing.
b246f932
PE
13592 (composition_reseat_it): Remove unused locals.
13593 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13594 (composition_update_it): Mark var as initialized.
11b61122
PE
13595 (find_automatic_composition): Mark vars as initialized,
13596 with a FIXME (Bug#8290).
8f5201ae 13597
760fbc2c
PE
13598 character.h: Rename locals to avoid shadowing.
13599 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13600 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13601 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13602 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13603 to avoid shadowing.
13604
ff08eb85
PE
13605 * textprop.c (property_change_between_p): Remove; unused.
13606
fc7bf025
PE
13607 * intervals.c (interval_start_pos): Now static.
13608
235d7abc
PE
13609 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13610
44f230aa
SM
13611 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13612 Rename locals to avoid shadowing.
3e7d6594 13613
50060332
PE
13614 * sound.c (wav_play, au_play, Fplay_sound_internal):
13615 Fix pointer signedness.
d01f234b 13616 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13617 (wav_play): Initialize a variable to 0, to prevent undefined
13618 behavior (Bug#8278).
50060332 13619
c4fc4e30
PE
13620 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13621
918436ed
PE
13622 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13623
c939f91b
PE
13624 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13625 clobbering (Bug#8298).
b9c7f648
PE
13626 * sysdep.c (sys_subshell): Likewise.
13627 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13628
6bd8c144
PE
13629 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13630 This should get cleaned up, so that child_setup has the
13631 same signature on all platforms.
13632
7710357c 13633 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13634 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13635
c59da222
CY
136362011-03-22 Chong Yidong <cyd@stupidchicken.com>
13637
13638 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13639 not to be necessary, and produces flickering.
13640
66b87493
GM
136412011-03-20 Glenn Morris <rgm@gnu.org>
13642
13643 * config.in: Remove file.
13644
45b6f6d5
JB
136452011-03-20 Juanma Barranquero <lekktu@gmail.com>
13646
13647 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13648 are now in src/globals.h.
13649 (syms_of_minibuf): Remove spurious & from previous change.
13650
cd394be1 136512011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13652
13653 * minibuf.c (completing-read-function): New variable.
13654 (completing-read-default): Rename from completing-read.
13655 (completing-read): Call completing-read-function.
13656
b14e3e21
CY
136572011-03-19 Juanma Barranquero <lekktu@gmail.com>
13658
13659 * xfaces.c (Fx_load_color_file):
13660 Read color file from absolute filename (bug#8250).
13661
f2b726e6
JB
136622011-03-19 Juanma Barranquero <lekktu@gmail.com>
13663
13664 * makefile.w32-in: Update dependencies.
13665
09f6ff02
EZ
136662011-03-17 Eli Zaretskii <eliz@gnu.org>
13667
13668 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13669
29a6015a
PE
136702011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13671
a3a6c54e
PE
13672 Fix more problems found by GCC 4.5.2's static checks.
13673
b766f867
PE
13674 * process.c (make_serial_process_unwind, send_process_trap):
13675 (sigchld_handler): Now static.
13676
be02381c
PE
13677 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13678 That way, the code declares only the vars that it needs.
13679 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13680 * s/cygwin.h (PTY_ITERATION): Likewise.
13681 * s/darwin.h (PTY_ITERATION): Likewise.
13682 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13683
57048744
PE
13684 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13685 * process.c (allocate_pty): Don't declare stb unless it's needed.
13686
7914961c 13687 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13688 (CONSTANTLIM): Remove; unused.
13689 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13690 Define only if needed.
7914961c 13691
b3967b18
PE
13692 * unexelf.c (unexec): Name an expression,
13693 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13694 Use a different way to cause a compilation error if anyone uses
13695 n rather than nn, a way that does not involve shadowing.
73366a00 13696 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13697
29a6015a
PE
13698 * deps.mk (unexalpha.o): Remove; unused.
13699
43cfc33e 13700 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13701 * unexec.h: New file.
ce701a33
PE
13702 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13703 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13704 Depend on unexec.h.
13705 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13706 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13707 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13708 Change as necessary to match prototype in unexec.h.
ce701a33 13709
01f44d5a
PE
13710 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13711 shadowing.
4f63c6bb 13712 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13713
a6670b0b
PE
13714 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13715 Rename locals to avoid shadowing.
13716
cef2010d 13717 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13718 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13719
d4d7173a
PE
13720 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13721
f08b802a
PE
13722 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13723 warning when compiling print.c.
13724
3ddb0639
PE
13725 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13726 instead of using an uninitialized var.
5ad03b97 13727 (font_sort_entities): Mark var as initialized.
3ddb0639 13728
170a2692
PE
13729 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13730
e663c700
PE
13731 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13732 pointers to constants.
89bc529a 13733 (font_parse_fcname): Remove unused vars.
7b81e2d0 13734 (font_delete_unmatched): Now static.
ea838e10 13735 (font_get_spec): Remove; unused.
13a547c6
PE
13736 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13737 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13738 Rename or move locals to avoid shadowing.
e663c700 13739
2a80c887 13740 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13741 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13742
1384fa33 13743 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13744 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13745
8b2c52e9
PE
13746 * alloc.c (mark_backtrace): Move decl from here ...
13747 * lisp.h: ... to here, so that it can be checked.
13748
475545b5 13749 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13750 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13751 (lisp_indirect_variable): Name an expression,
13752 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13753 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13754
b1349114 13755 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13756 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13757 Use const pointer when appropriate.
b1349114 13758
a2928364
PE
13759 * lisp.h (get_system_name, get_operating_system_release):
13760 Move decls here, to check interfaces.
13761 * process.c (get_operating_system_release): Move decl to lisp.h.
13762 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13763 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13764 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13765 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13766 (Fformat_time_string, Fencode_time, Finsert_char):
13767 (Ftranslate_region_internal, Fformat):
13768 Rename or remove local vars to avoid shadowing.
9710023e 13769 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13770
a415e694
PE
13771 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13772 avoid shadowing.
13773
8ef4622d
PE
13774 * lisp.h (eassert): Check that the argument compiles, even if
13775 ENABLE_CHECKING is not defined.
13776
946f9a5b
PE
13777 * data.c (Findirect_variable): Name an expression, to avoid
13778 gcc -Wbad-function-cast warning.
112396d6 13779 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13780 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13781 (Fmake_variable_buffer_local, Fmake_local_variable):
13782 Mark variables as initialized.
52746918 13783 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13784
e5aab7e7 13785 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13786 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13787 Rename locals to avoid shadowing.
dff45157
PE
13788 (mark_stack): Move local variables into the #ifdef region where
13789 they're used.
7bc26fdb
PE
13790 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13791 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13792 needed otherwise.
13793 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13794 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13795 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13796
e5aab7e7
PE
13797 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13798 avoids undefined behavior in theory.
13799
4da60324
PE
13800 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13801
88043301
PE
13802 Use functions, not macros, for up- and down-casing (Bug#8254).
13803 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13804 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13805 to use the following functions instead of these macros.
13806 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13807 EMACS_INT, since callers assume the returned value fits in int.
13808 (upcase1): Likewise, for UPCASE_TABLE.
13809 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13810 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13811 the race-condition problem in the old DOWNCASE.
88043301 13812
19ed5445
PE
13813 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13814 Rename locals to avoid shadowing.
13815 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13816 (regex_compile, re_search_2, re_match_2_internal):
13817 Remove unused local vars.
952db0d7
PE
13818 (FREE_VAR): Rewrite so as not to use empty "else",
13819 which gcc can warn about.
da053e48 13820 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13821 (RETALLOC_IF): Define only if needed.
13822 (WORDCHAR_P): Likewise. This one is never needed, but is used
13823 only in a comment talking about a compiler bug, so put inside
13824 the #if 0 of that comment.
13825 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13826 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13827 Remove; unused.
19ed5445 13828
1f3561e4 13829 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13830 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13831 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13832
ded6f8f7
PE
13833 * search.c (simple_search): Remove unused var.
13834
dbd37a95
PE
13835 * dired.c (compile_pattern): Move decl from here ...
13836 * lisp.h: ... to here, so that it can be checked.
13837 (struct re_registers): New forward decl.
13838
7e47afad
PE
13839 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13840
85f24f61
PE
13841 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13842 All uses changed.
13843 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13844 Rename locals to avoid shadowing.
5671df8f 13845 (Fvertical_motion): Mark locals as initialized.
85f24f61 13846
181aa2be 13847 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13848 (casify_region): Mark local as initialized.
181aa2be 13849
930d429c
PE
13850 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13851
7082eac6
PE
13852 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13853 New macros, so that the caller can use some names other than
13854 gcpro1, gcpro2, etc.
13855 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13856 of the new macros.
13857 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13858 argument, for consistency with GCPRO2_VAR, etc: it is now the
13859 prefix of the variable, not the variable itself. All uses
13860 changed.
38b2c076
PE
13861 * dired.c (directory_files_internal, file_name_completion):
13862 Rename locals to avoid shadowing.
13863
15206ed9
PE
13864 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13865 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13866 dired.c's scmp function, had undefined behavior.
13867 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13868 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13869 * buffer.h: ... to here, because these macros use current_buffer,
13870 and the new implementation with inline functions needs to have
13871 current_buffer in scope now, rather than later when the macros
13872 are used.
13873 (downcase, upcase1): New static inline functions.
13874 (DOWNCASE, UPCASE1): Reimplement using these functions.
13875 This avoids undefined behavior in expressions like
13876 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13877 from race conditions in accessing the global variables
13878 case_temp1 and case_temp2.
13879 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13880 * lisp.h (case_temp1, case_temp2): Remove their decls.
13881 * character.h (ASCII_CHAR_P): Move from here ...
13882 * lisp.h: ... to here, so that the inline functions mentioned
13883 above can use them.
13884
4a6bea26
PE
13885 * dired.c (directory_files_internal_unwind): Now static.
13886
f14b7e14
PE
13887 * fileio.c (file_name_as_directory, directory_file_name):
13888 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13889 Now static.
2893f146
PE
13890 (file_name_as_directory): Use const pointers when appropriate.
13891 (Fexpand_file_name): Likewise. In particular, newdir might
13892 point at constant storage, so make it a const pointer.
fd4ead52 13893 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13894 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13895 signedness issues.
f839df0c
PE
13896 (Fset_file_times, Finsert_file_contents, auto_save_error):
13897 Rename locals to avoid shadowing.
f14b7e14 13898
5716756e 13899 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13900 (Ftry_completion, Fall_completions): Rename or remove locals
13901 to avoid shadowing.
5716756e 13902
b4c3046a
PE
13903 * marker.c (bytepos_to_charpos): Remove; unused.
13904
b45db522
PE
13905 * lisp.h (verify_bytepos, count_markers): New decls,
13906 so that gcc does not warn that these functions aren't declared.
13907
85876d07
PE
13908 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13909 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13910 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13911 (copy_text): Remove unused local var.
85876d07 13912
03d78a21 13913 * filelock.c (within_one_second): Now static.
b3dd38ab 13914 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13915
5df8f01b
PE
13916 * buffer.c (fix_overlays_before): Mark locals as initialized.
13917 (fix_start_end_in_overlays): Likewise. This function should be
13918 simplified by using pointers-to-pointers, but that's a different
13919 matter.
b1d876f1 13920 (switch_to_buffer_1): Now static.
8f54f30a
PE
13921 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13922 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13923
a70072c9 13924 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13925 Fix pointer signedness issue.
edced198
PE
13926 (sys_subshell): Mark local as volatile if checking for lint,
13927 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13928 (MAXPATHLEN): Define only if needed.
a70072c9 13929
a0977c44
PE
13930 * process.c (serial_open, serial_configure): Move decls from here ...
13931 * systty.h: ... to here, so that they can be checked.
13932
a884fdcc
PE
13933 * fns.c (get_random, seed_random): Move extern decls from here ...
13934 * lisp.h: ... to here, so that they can be checked.
13935
604efe86 13936 * sysdep.c (reset_io): Now static.
b8950c94 13937 (wait_for_termination_signal): Remove; unused.
604efe86 13938
38fc62d9
PE
13939 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13940 (copy_keymap_item, append_key, push_text_char_description):
13941 Now static.
1004a21a 13942 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13943 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13944 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13945 (describe_map_tree):
13946 Rename locals to avoid shadowing.
38fc62d9 13947
2f2650da
PE
13948 * keyboard.c: Declare functions static if they are not used elsewhere.
13949 (echo_char, echo_dash, cmd_error, top_level_2):
13950 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13951 (read_char, kbd_buffer_get_event, make_lispy_position):
13952 (make_lispy_event, make_lispy_movement, apply_modifiers):
13953 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13954 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13955 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13956 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13957 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13958
a053e86c 13959 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13960 (mark_kboards): Move decl here ...
13961 * alloc.c (mark_kboards): ... from here.
a053e86c 13962
4752793e
PE
13963 * lisp.h (force_auto_save_soon): New decl.
13964
74f10ca7 13965 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13966 (DEFINE_DUMMY_FUNCTION): New macro.
13967 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13968 Use it.
c03cd23f
PE
13969 (main): Add casts to avoid warnings
13970 if GCC considers string literals to be constants.
74f10ca7 13971
022e70d4
PE
13972 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13973
59d6fe83
PE
13974 * dbusbind.c: Pointer signedness fixes.
13975 (xd_signature, xd_append_arg, xd_initialize):
13976 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13977 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13978 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13979 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13980
78320123
PE
13981 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13982 if GCC considers string literals to be constants.
49cebcca 13983 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13984
35ac2a97
SM
139852011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13986
fb103ca9
SM
13987 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13988 (print_preprocess, print_object): New macro to fix last change.
13989
35ac2a97
SM
13990 * print.c (print_preprocess): Don't forget font objects.
13991
62973b41
JB
139922011-03-16 Juanma Barranquero <lekktu@gmail.com>
13993
13994 * emacs.c (USAGE3): Doc fixes.
13995
0e48bb22
AS
139962011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13997
13998 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13999 structure.
14000
7684e57b
JB
140012011-03-14 Juanma Barranquero <lekktu@gmail.com>
14002
14003 * lisp.h (VWindow_system, Qfile_name_history):
14004 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14005 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14006 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14007
14008 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14009 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14010
14011 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14012 * w32console.c (detect_input_pending, read_input_pending)
14013 (encode_terminal_code):
14014 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14015 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14016 (w32_system_caret_y, Qfile_name_history):
14017 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14018 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14019 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14020 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14021 * w32proc.c (Qlocal, report_file_error):
14022 * w32term.c (Vwindow_system, updating_frame):
14023 * w32uniscribe.c (initialized, uniscribe_font_driver):
14024 Remove unneeded extern declarations.
14025
2aa46d6c
CY
140262011-03-14 Chong Yidong <cyd@stupidchicken.com>
14027
c96bbc66 14028 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14029
cffc6f3b
CY
140302011-03-13 Chong Yidong <cyd@stupidchicken.com>
14031
14032 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14033 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14034 These macros can no longer be used for assignment.
14035
44f230aa
SM
14036 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14037 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14038 (record_buffer_markers, fetch_buffer_markers): New functions for
14039 recording and fetching special buffer markers.
14040 (set_buffer_internal_1, set_buffer_temp): Use them.
14041
14042 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14043
14044 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14045
14046 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14047 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14048
14049 * xdisp.c (hscroll_window_tree):
14050 (reconsider_clip_changes): Use PT instead of BUF_PT.
14051
d251f04b
EZ
140522011-03-13 Eli Zaretskii <eliz@gnu.org>
14053
14054 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14055 $(EMACS_ROOT)/lib/intprops.h.
14056
f0c77cd1
PE
140572011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14058
3eca4629
PE
14059 Fix more problems found by GCC 4.5.2's static checks.
14060
7c86ee98
PE
14061 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14062 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14063 (xg_free_frame_widgets): Make it clear that a local variable is
14064 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14065 (gdk_window_get_screen): Make it clear that this macro is needed
14066 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14067 (int_gtk_range_get_value): New function, which avoids a diagnostic
14068 from gcc -Wbad-function-cast.
14069 (xg_set_toolkit_scroll_bar_thumb): Use it.
14070 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14071 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14072 (get_utf8_string, xg_get_file_with_chooser):
14073 Rename locals to avoid shadowing.
14074 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14075
41729b81
PE
14076 * xgselect.c (xg_select): Remove unused var.
14077
f0c77cd1
PE
14078 * image.c (four_corners_best): Mark locals as initialized.
14079 (gif_load): Initialize transparent_p to zero (Bug#8238).
14080 Mark another local as initialized.
ec6cf4c6 14081 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14082
ce0ad53d 14083 * image.c (clear_image_cache): Now static.
d5d5a617 14084 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14085 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14086 (x_edge_detection): Remove unnecessary cast that
14087 gcc -Wbad-function-cast diagnoses.
2037898d 14088 (gif_load): Fix pointer signedness.
6ae141d6
PE
14089 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14090 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14091
33383987 140922011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14093
d32df629
PE
14094 Improve quality of tests for time stamp overflow.
14095 For example, without this patch (encode-time 0 0 0 1 1
14096 1152921504606846976) returns the obviously-bogus value (-948597
14097 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14098 reports time overflow. See
14099 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14100 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14101 * editfns.c: Include limits.h and intprops.h.
14102 (TIME_T_MIN, TIME_T_MAX): New macros.
14103 (time_overflow): Move earlier, to before first use.
14104 (hi_time, lo_time): New functions, for an accurate test for
14105 out-of-range times.
14106 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14107 (Fget_internal_run_time): Don't assume time_t fits in int.
14108 (make_time): Use list2 instead of Fcons twice.
14109 (Fdecode_time): More accurate test for out-of-range times.
14110 (check_tm_member): New function.
14111 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14112 (lisp_time_argument): Don't rely on undefined left-shift and
14113 right-shift behavior when checking for time stamp overflow.
8be6f318 14114
fe31d94c
PE
14115 * editfns.c (time_overflow): New function, refactoring common code.
14116 (Fformat_time_string, Fdecode_time, Fencode_time):
14117 (Fcurrent_time_string): Use it.
14118
8be6f318
PE
14119 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14120 * dired.c (make_time): Move to ...
14121 * editfns.c (make_time): ... here.
14122 * systime.h: Note the move.
14123
09d9db2c 141242011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14125
126bc0dc
YM
14126 * fringe.c (update_window_fringes): Remove unused variables.
14127
c47cbdfd
YM
14128 * unexmacosx.c (copy_data_segment): Also copy __got section.
14129 (Bug#8223)
14130
7ac80be9
EZ
141312011-03-12 Eli Zaretskii <eliz@gnu.org>
14132
c96bbc66 14133 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14134 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14135 Constify `char *' arguments and their references according to
14136 prototypes in tparam.h.
14137
ecb0f94d 14138 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14139
7ac80be9
EZ
14140 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14141 Adapt all references accordingly.
14142
14143 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14144
ef1fd07e
TT
141452011-03-11 Tom Tromey <tromey@redhat.com>
14146
14147 * buffer.c (syms_of_buffer): Remove obsolete comment.
14148
7ef4b50c
EZ
141492011-03-11 Eli Zaretskii <eliz@gnu.org>
14150
14151 * termhooks.h (encode_terminal_code): Declare prototype.
14152
14153 * msdos.c (encode_terminal_code): Don't declare prototype.
14154
14155 * term.c (encode_terminal_code): Now external again, used by
14156 w32console.c and msdos.c.
14157
44f230aa
SM
14158 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14159 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14160
4b1ec863 141612011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14162
1714f52b 14163 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14164
4b1ec863
PE
14165 * fringe.c (update_window_fringes): Mark locals as initialized
14166 (Bug#8227).
14167 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14168
524c7aa6
PE
14169 * alloc.c (mark_fringe_data): Move decl from here ...
14170 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14171 to check its interface.
14172 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14173
a5c0af81 14174 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14175 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14176 (fontset_font): Mark local as initialized.
a9a06e0b 14177 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14178
b4716021
PE
14179 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14180
811e9bac 14181 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14182 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14183 (x_own_selection, Fx_disown_selection_internal): Rename locals
14184 to avoid shadowing.
14185 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14186
7e3ab302
PE
14187 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14188 so that the caller can use some name other than gcpro1.
14189 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14190 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14191 (Fx_backspace_delete_keys_p):
14192 Use them to avoid shadowing, and rename vars to avoid shadowing.
14193 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14194 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14195 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14196 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14197 Remove unused locals.
7e3ab302
PE
14198 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14199 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14200 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14201 macros.
f78faa98 14202
e2b13473
PE
14203 * xterm.h (x_mouse_leave): New decl.
14204
77f23912
PE
14205 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14206 Remove unused functions.
cdf4ba58
PE
14207 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14208 (x_calc_absolute_position): Now static.
7411c686 14209 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14210 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14211 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14212 unless they are used.
38d0b34a
PE
14213 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14214 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14215 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14216 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14217 (x_error_catcher, x_connection_closed, x_error_handler):
14218 (x_error_quitter, xembed_send_message, x_iconify_frame):
14219 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14220 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14221 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14222
44f230aa
SM
14223 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14224 Rename or move locals to avoid shadowing.
6b463e58 14225 (tty_defined_color, merge_face_heights): Now static.
5967d051 14226 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14227 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14228 does not deduce is never used uninitialized.
73719eba
PE
14229 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14230 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14231
426994c3 14232 * terminal.c (store_terminal_param): Now static.
5489860b 14233
032f1620 14234 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14235 (set_frame_menubar): Remove unused local.
d4323972 14236 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14237 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14238 since they might point to immutable storage.
281585b0
PE
14239 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14240 since it's unused otherwise.
032f1620 14241
367c19e5 14242 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14243 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14244 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14245 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14246 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14247 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14248 does not deduce are never used uninitialized.
70739cbe 14249
07b48fa9
PE
14250 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14251
8868a238 14252 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14253 * window.c (window_loop, size_window):
14254 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14255
7e5cf297 14256 * window.c (display_buffer): Now static.
d6550a9f
PE
14257 (size_window): Mark variables that gcc -Wuninitialized
14258 does not deduce are never used uninitialized.
a586633d
PE
14259 * window.h (check_all_windows): New decl, to forestall
14260 gcc -Wmissing-prototypes diagnostic.
5b555da1 14261 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14262
f6095868
PE
14263 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14264 shadowing.
14265 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14266 Include <limits.h>.
14267 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14268 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14269 (load_charset_map): Mark variables that gcc -Wuninitialized
14270 does not deduce are never used uninitialized.
53df7c11 14271 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14272
f38b440c
PE
14273 * coding.c (coding_set_source, coding_set_destination):
14274 Use "else { /* comment */ }" rather than "else /* comment */;"
14275 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14276 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14277 a block, when the outer 'i' will do.
14278 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14279 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14280 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14281 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14282 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14283 Rename locals to avoid shadowing.
14284 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14285 * coding.c (emacs_mule_char, encode_invocation_designation):
14286 Now static, since they're not used elsewhere.
413bb2db 14287 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14288 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14289 (decode_coding_emacs_mule): Mark variables that gcc
14290 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14291 (detect_coding_iso_2022): Initialize a local variable that might
14292 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14293 this initialization is needed. (Bug#8211)
5f58e762
PE
14294 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14295 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14296 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14297 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14298 Remove unused macros.
f38b440c 14299
232b38b9 14300 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14301 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14302 * character.c (string_count_byte8): Likewise.
232b38b9 14303
fb90da1b
PE
14304 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14305 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14306
fb93dbc2
PE
14307 * chartab.c (copy_sub_char_table): Now static, since it's not used
14308 elsewhere.
5c156ace
PE
14309 (sub_char_table_ref_and_range, char_table_ref_and_range):
14310 Rename locals to avoid shadowing.
bbcd0949 14311 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14312
7d3b3862 14313 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14314 (BIDI_BOB): Remove unused macro.
7d3b3862 14315
6be7d3da
PE
14316 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14317 deduce are never used uninitialized.
c2ed9c8b 14318 * term.c (encode_terminal_code): Likewise.
6be7d3da 14319
75f8807f 14320 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14321
50938595
PE
14322 * tparam.h: New file.
14323 * term.c, tparam.h: Include it.
14324 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14325 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14326 Move these decls to tparam.h, and make them agree with what
14327 is actually in tparam.c. The previous trick of using incompatible
14328 decls in different modules does not conform to the C standard.
14329 All callers of tparam changed to use tparam's actual API.
14330 * tparam.c (tparam1, tparam, tgoto):
14331 Use const pointers where appropriate.
14332
fbceeba2
PE
14333 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14334 * cm.h (struct cm): Likewise.
14335 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14336 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14337 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14338 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14339 (turn_on_face, init_tty): Likewise.
14340 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14341
7f3f1250
PE
14342 * term.c (term_mouse_position): Rename local to avoid shadowing.
14343
e6ca6543
PE
14344 * alloc.c (mark_ttys): Move decl from here ...
14345 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14346
c40f8d15
AS
143472011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14348
14349 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14350
cfe0661d
JB
143512011-03-09 Juanma Barranquero <lekktu@gmail.com>
14352
14353 * search.c (compile_pattern_1): Remove argument regp, unused since
14354 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14355 (compile_pattern): Don't pass it.
14356
0afb4571
J
143572011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14358
14359 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14360 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14361 for ! HAVE_GTK3.
14362 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14363
14364 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14365
14366 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14367 gdk_window_get_screen, gdk_window_get_geometry,
14368 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14369 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14370 (xg_get_pixbuf_from_pixmap): New function.
14371 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14372 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14373 Call xg_get_pixbuf_from_pixmap instead of
14374 gdk_pixbuf_get_from_drawable.
14375 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14376 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14377 (xg_check_special_colors): Use GtkStyleContext and its functions
14378 for HAVE_GTK3.
14379 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14380 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14381 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14382 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14383 Call gtk_widget_get_preferred_size.
0afb4571
J
14384 (xg_frame_resized): gdk_window_get_geometry only takes 5
14385 parameters.
44f230aa
SM
14386 (xg_win_to_widget, xg_event_is_for_menubar):
14387 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14388 (xg_set_widget_bg): New function.
14389 (delete_cb): New function.
895009e1 14390 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14391 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14392 (xg_set_background_color): Call xg_set_widget_bg.
14393 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14394 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14395 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14396 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14397 if ! HAVE_GTK3.
14398 (update_frame_tool_bar): Call gtk_widget_hide.
14399 (xg_initialize): Use GDK_KEY_g.
14400
14401 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14402 if ! HAVE_GTK3
14403 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14404
14405 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14406 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14407 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14408
1c2cc4ef
JB
144092011-03-08 Juanma Barranquero <lekktu@gmail.com>
14410
14411 * w32xfns.c (select_palette): Check success of RealizePalette against
14412 GDI_ERROR, not zero.
14413
33383987 14414See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14415
14416;; Local Variables:
14417;; coding: utf-8
aac0c6e3
MR
14418;; End:
14419
2f097256 14420 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14421
14422 This file is part of GNU Emacs.
14423
14424 GNU Emacs is free software: you can redistribute it and/or modify
14425 it under the terms of the GNU General Public License as published by
14426 the Free Software Foundation, either version 3 of the License, or
14427 (at your option) any later version.
14428
14429 GNU Emacs is distributed in the hope that it will be useful,
14430 but WITHOUT ANY WARRANTY; without even the implied warranty of
14431 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14432 GNU General Public License for more details.
14433
14434 You should have received a copy of the GNU General Public License
14435 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.