* lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
e39e811e
PE
12011-06-18 Paul Eggert <eggert@cs.ucla.edu>
2
15375a22
PE
3 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5 implementation.
6
53b2623d
PE
7 * indent.c (sane_tab_width): New function.
8 (current_column, scan_for_column, Findent_to, position_indentation)
9 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 11
45aebb64
PE
12 * image.c (xbm_image_p): Don't assume stated width and height fit in int.
13
f2ed8a70
PE
14 * lisp.h (lint_assume): New macro.
15 * composite.c (composition_gstring_put_cache):
16 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
17
abe80cc6
PE
18 * editfns.c, insdel.c:
19 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 20
b02c740e
PE
21 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
22
ebc96716
PE
23 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
24
b4e50fa0 25 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 26 Use much-faster test for byte-length change.
311d5d7c 27 Don't assume string byte-length fits in 'int'.
a4cf38e4 28 Check that character arg fits in 'int'.
85461888 29 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 30
c0c1ee9f
PE
31 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
32
a498d7f4
PE
33 * fns.c (concat): Catch string overflow earlier.
34 Do not rely on integer wraparound.
35
e39e811e
PE
36 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
37
fadf4e30
PE
382011-06-17 Paul Eggert <eggert@cs.ucla.edu>
39
87830974
PE
40 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
41 * xdisp.c (forward_to_next_line_start)
42 (back_to_previous_visible_line_start)
43 (reseat_at_next_visible_line_start, next_element_from_buffer):
44 Don't arbitrarily truncate the value of 'selective' to int.
45
76031fad
PE
46 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
47
5eb55db9
PE
48 * composite.c: Don't truncate sizes to 'int'.
49 (composition_gstring_p, composition_reseat_it)
50 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
51 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
52 not EMACS_UINT, for indexes.
5eb55db9 53
0703a717
PE
54 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
55
d6202519
PE
56 * buffer.c: Include <verify.h>.
57 (struct sortvec.priority, struct sortstr.priority):
8961a454 58 Now EMACS_INT, not int.
c20998a7 59 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
60 (struct sortstr.size, record_overlay_string)
61 (struct sortstrlist.size, struct sortlist.used):
62 Don't truncate size to int.
63 (record_overlay_string): Check for size-calculation overflow.
d6202519 64 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 65
28177add
PE
662011-06-16 Paul Eggert <eggert@cs.ucla.edu>
67
dd3482fe
PE
68 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
69 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
70 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
71
393d71f3 72 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
73 * fileio.c (Finsert_file_contents):
74 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
75 Remove the old (too-loose) buffer overflow checks.
76 They weren't needed, since make_gap checks for buffer overflow.
77 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
78 The old code merely checked for Emacs fixnum overflow, and relied
79 on undefined (wraparound) behavior. The new code avoids undefined
80 behavior, and also checks for ptrdiff_t and/or size_t overflow.
81
2e6813b0 82 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
83 Tune. Don't use wider integers than needed. Don't use alloca.
84 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 85
599a9e4f
PE
86 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
87
99561444
PE
88 * insdel.c, lisp.h (buffer_overflow): New function.
89 (insert_from_buffer_1, replace_range, replace_range_2):
90 * insdel.c (make_gap_larger):
91 * editfns.c (Finsert_char):
92 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
93
28177add
PE
94 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
95
e69dafad
PE
962011-06-15 Paul Eggert <eggert@cs.ucla.edu>
97
a7af7fde 98 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 99
b1c46f02
PE
100 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
101 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
102
e69dafad
PE
103 * fileio.c: Don't assume EMACS_INT fits in off_t.
104 (emacs_lseek): New static function.
105 (Finsert_file_contents, Fwrite_region): Use it.
106 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
107
566684ea
PE
108 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
109
e6966cd6
PE
110 * fns.c: Don't overflow int when computing a list length.
111 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
112 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
113 truncation on 64-bit hosts. Check for QUIT every
114 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
115 faster and is responsive enough.
116 (Flength): Report an error instead of overflowing an integer.
117 (Fsafe_length): Return a float if the value is not representable
118 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 119 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 120 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 121
dd0b0efb
PE
122 * alloc.c: Check that resized vectors' lengths fit in fixnums.
123 (header_size, word_size): New constants.
124 (allocate_vectorlike): Don't check size overflow here.
125 (allocate_vector): Check it here instead, since this is the only
126 caller of allocate_vectorlike that could cause overflow.
127 Check that the new vector's length is representable as a fixnum.
128
86fe5cfe
PE
129 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
130 The previous code was bogus. For example, next_almost_prime (32)
131 returned 39, which is undesirable as it is a multiple of 3; and
132 next_almost_prime (24) returned 25, which is a multiple of 5 so
133 why was the code bothering to check for multiples of 7?
134
80e88859
PE
135 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
136
4a2f0ad6
PE
137 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
138
f66c7cf8
PE
139 Variadic C functions now count arguments with ptrdiff_t.
140 This partly undoes my 2011-03-30 change, which replaced int with size_t.
141 Back then I didn't know that the Emacs coding style prefers signed int.
142 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
143 were being counted with int, which may truncate counts on 64-bit
144 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
145 * lisp.h (struct Lisp_Subr.function.aMANY)
146 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
147 Arg counts are now ptrdiff_t, not size_t.
148 All variadic functions and their callers changed accordingly.
149 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
150 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
151 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
152 * callint.c (Fcall_interactively): Check arg count for overflow,
153 to avoid potential buffer overrun. Use signed char, not 'int',
154 for 'varies' array, so that we needn't bother to check its size
155 calculation for overflow.
156 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
157 * eval.c (apply_lambda):
158 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
159 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
160 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
161
a1759b76
PE
162 * callint.c (Fcall_interactively): Don't use index var as event count.
163
d96be9fc
PE
164 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
165 * mem-limits.h (SIZE): Remove; no longer used.
166
a690a978 167 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 168
578c21e6
PE
169 Remove unnecessary casts.
170 * xterm.c (x_term_init):
171 * xfns.c (x_set_border_pixel):
172 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
173 These aren't needed now that we assume ANSI C.
174
96f53c6c
PE
175 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
176 It's more likely to cause problems (due to unsigned overflow)
177 than to cure them.
178
83c77d31
PE
179 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
180
ee2079f1
PE
181 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
182
6da65536
PE
183 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
184
7147c4a4
PE
185 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
186
193e32d9
PE
187 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
188
e5533da6
PE
189 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
190
9910e595
PE
191 GLYPH_CODE_FACE returns EMACS_INT, not int.
192 * dispextern.h (merge_faces):
193 * xfaces.c (merge_faces):
01103c44
PE
194 * xdisp.c (get_next_display_element, next_element_from_display_vector):
195 Don't assume EMACS_INT fits in int.
9910e595 196
2638320e
PE
197 * character.h (CHAR_VALID_P): Remove unused parameter.
198 * fontset.c, lisp.h, xdisp.c: All uses changed.
199
045eb8d9
PE
200 * editfns.c (Ftranslate_region_internal): Omit redundant test.
201
c1f134b5
PE
202 * fns.c (concat): Minor tuning based on overflow analysis.
203 This doesn't fix any bugs. Use int to hold character, instead
204 of constantly refetching from Emacs object. Use XFASTINT, not
205 XINT, for value known to be a character. Don't bother comparing
206 a single byte to 0400, as it's always less.
207
395fcb93 208 * floatfns.c (Fexpt):
327eeec8
PE
209 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
210
abbd3d23
PE
211 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
212 for characters.
213
684a03ef
PE
214 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
215
0fed43f3
PE
216 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
217 Without this fix, on a 64-bit host (aset S 0 4294967386) would
218 incorrectly succeed when S was a string, because 4294967386 was
219 truncated before it was used.
220
8fd02eb7
PE
221 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
222 Otherwise, an out-of-range integer could cause undefined behavior
223 on a 64-bit host.
224
f8c86b69
PE
225 * composite.c: Use int, not EMACS_INT, for characters.
226 (fill_gstring_body, composition_compute_stop_pos): Use int, not
227 EMACS_INT, for values that are known to be in character range.
228 This doesn't fix any bugs but is the usual style inside Emacs and
229 may generate better code on 32-bit machines.
230
34206dd2
PE
231 Make sure a 64-bit char is never passed to ENCODE_CHAR.
232 This is for reasons similar to the recent CHAR_STRING fix.
233 * charset.c (Fencode_char): Check that character arg is actually
234 a character. Pass an int to ENCODE_CHAR.
235 * charset.h (ENCODE_CHAR): Verify that the character argument is no
236 wider than 'int', as a compile-time check to prevent future regressions
237 in this area.
238
c5958d4c 239 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
240
241 Make sure a 64-bit char is never passed to CHAR_STRING.
242 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
243 by silently ignoring the top 32 bits, allowing some values
244 that were far too large to be valid characters.
245 * character.h: Include <verify.h>.
246 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
247 arguments are no wider than unsigned, as a compile-time check
248 to prevent future regressions in this area.
249 * data.c (Faset):
01103c44 250 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
251 (Fsubst_char_in_region):
252 * fns.c (concat):
253 * xdisp.c (decode_mode_spec_coding):
254 Adjust to CHAR_STRING's new requirement.
255 * editfns.c (Finsert_char, Fsubst_char_in_region):
256 * fns.c (concat): Check that character args are actually
257 characters. Without this test, these functions did the wrong
258 thing with wildly out-of-range values on 64-bit hosts.
259
d37ca623
PE
260 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
261 These casts should not be needed on 32-bit hosts, either.
262 * keyboard.c (read_char):
263 * lread.c (Fload): Remove casts to unsigned.
264
ea204efb
PE
265 * lisp.h (UNSIGNED_CMP): New macro.
266 This fixes comparison bugs on 64-bit hosts.
267 (ASCII_CHAR_P): Use it.
268 * casefiddle.c (casify_object):
01103c44 269 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
270 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
271 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
272 * dispextern.h (FACE_FROM_ID):
273 * keyboard.c (read_char): Use UNSIGNED_CMP.
274
41cb286c
PE
275 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
276 not to EMACS_INT, to avoid GCC warning.
277
4a1b9832
PE
278 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
279
55daad71
PE
280 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
281 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
282 isn't needed on 32-bit machines.
8f95c75c 283
01103c44
PE
284 * buffer.c (Fgenerate_new_buffer_name):
285 Use EMACS_INT for count, not int.
0ceccced 286 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
287
288 * data.c (Qcompiled_function): Now static.
289
c6f072e7
PE
290 * window.c (window_body_lines): Now static.
291
20ce5912
PE
292 * image.c (gif_load): Rename local to avoid shadowing.
293
9c4c5f81
PE
294 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
295 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
296 * alloc.c (make_save_value): Integer argument is now of type
297 ptrdiff_t, not int.
298 (mark_object): Use ptrdiff_t, not int.
299 * lisp.h (pD): New macro.
300 * print.c (print_object): Use it.
301
c0c5c8ae
PE
302 * alloc.c: Use EMACS_INT, not int, to count objects.
303 (total_conses, total_markers, total_symbols, total_vector_size)
304 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
305 (total_free_floats, total_floats, total_free_intervals)
306 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
307 Now EMACS_INT, not int. All uses changed.
308 (Fgarbage_collect): Compute overall total using a double, so that
309 integer overflow is less likely to be a problem. Check for overflow
310 when converting back to an integer.
5a25e253
PE
311 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
312 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
313 These were 'int' variables that could overflow on 64-bit hosts;
314 they were never used, so remove them instead of repairing them.
211a0b2a 315 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
316 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
317 Previously, this ceilinged at INT_MAX, but that doesn't work on
318 64-bit machines.
e46bb31a 319 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 320
c78baabf 321 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 322 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
323 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
324 when a (possibly-narrower) signed value would do just as well.
325 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 326
c9d624c6
PE
327 * alloc.c: Catch some string size overflows that we were missing.
328 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
329 for convenience in STRING_BYTES_MAX.
330 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
331 The definition here is exact; the one in lisp.h was approximate.
332 (allocate_string_data): Check for string overflow. This catches
333 some instances we weren't catching before. Also, it catches
334 size_t overflow on (unusual) hosts where SIZE_MAX <= min
335 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
336 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 337
c9d624c6
PE
338 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
339 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
340 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
341
353032ce
PE
342 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
343
2bccce07
PE
344 * alloc.c (Fmake_string): Check for out-of-range init.
345
0ac30604
SM
3462011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
347
348 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
349
c195f2de
JD
3502011-06-14 Jan Djärv <jan.h.d@swipnet.se>
351
352 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
353 xg_get_default_scrollbar_width.
354
355 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
356 (int_gtk_range_get_value): Move to the scroll bar part of the file.
357 (style_changed_cb): Call update_theme_scrollbar_width and call
358 x_set_scroll_bar_default_width and xg_frame_set_char_size for
359 all frames (Bug#8505).
360 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
361 Call gtk_window_set_resizable if HAVE_GTK3.
362 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
363 and height if HAVE_GTK3 (Bug#8505).
364 (scroll_bar_width_for_theme): New variable.
365 (update_theme_scrollbar_width): New function.
366 (xg_get_default_scrollbar_width): Move code to
367 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
368 (xg_initialize): Call update_theme_scrollbar_width.
369
370 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
371
372 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
373
e10ac9f1
MR
3742011-06-12 Martin Rudalics <rudalics@gmx.at>
375
376 * frame.c (make_frame): Call other_buffer_safely instead of
377 other_buffer.
378
379 * window.c (temp_output_buffer_show): Call display_buffer with
380 second argument Vtemp_buffer_show_specifiers and reset latter
381 immediately after the call.
382 (Vtemp_buffer_show_specifiers): New variable.
383 (auto_window_vscroll_p, next_screen_context_lines)
384 (Vscroll_preserve_screen_position): Remove leading asterisks from
385 doc-strings.
386
2d3c217e 3872011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 388
7b7f97e8 389 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
390 * buffer.c (Qclone_number): Remove for now, as it's unused.
391 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
392 (record_buffer): Remove unused local.
393 * frame.c (other_visible_frames, frame_buffer_list): Now static.
394 (set_frame_buffer_list): Remove; unused.
395 * frame.h (other_visible_frames): Remove decl.
396 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
397 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
398 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
399 if HAVE_GPM.
400 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
401 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
402 Define only if HAVE_GPM.
403 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
404 (update_hints_inhibit): Remove; never set. All uses removed.
405 * widgetprv.h (emacsFrameClassRec): Remove decl.
406 * window.c (delete_deletable_window): Now returns void, since it
407 wasn't returning anything.
408 (compare_window_configurations): Remove unused locals.
409 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
410 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
411 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
412 the same widths as pointers. This follows up on the 2011-05-06 patch.
413 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
414 * xterm.h: Likewise.
415 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
416
1384b89e
JB
4172011-06-12 Juanma Barranquero <lekktu@gmail.com>
418
419 * makefile.w32-in: Update dependencies.
420 (LISP_H): Add lib/intprops.h.
421
1100a63c
CY
4222011-06-11 Chong Yidong <cyd@stupidchicken.com>
423
424 * image.c (gif_load): Add animation frame delay to the metadata.
425 (syms_of_image): Use DEFSYM. New symbol `delay'.
426
6198ccd0
MR
4272011-06-11 Martin Rudalics <rudalics@gmx.at>
428
429 * window.c (delete_deletable_window): Re-add.
430 (Fset_window_configuration): Rewrite to handle dead buffers and
431 consequently deletable windows.
432 (window_tree, Fwindow_tree): Remove. Supply functionality in
433 window.el.
434 (compare_window_configurations): Simplify code.
435
b6e3633c
AS
4362011-06-11 Andreas Schwab <schwab@linux-m68k.org>
437
1ab0dee5
AS
438 * image.c (imagemagick_load_image): Fix type mismatch.
439 (Fimagemagick_types): Likewise.
440
b6e3633c
AS
441 * window.h (replace_buffer_in_windows): Declare.
442
9397e56f
MR
4432011-06-11 Martin Rudalics <rudalics@gmx.at>
444
445 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
446 Qclone_number. Remove external declaration of Qdelete_window.
447 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
448 code.
449 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
450 Qbuffer_list_update_hook if allowed.
451 (Fother_buffer): Rewrite doc-string. Major rewrite for new
452 buffer list implementation.
453 (other_buffer_safely): New function.
454 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
455 calls to replace_buffer_in_windows and
456 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
457 if allowed.
458 (record_buffer): Inhibit quitting and rewrite using quittable
459 functions. Run Qbuffer_list_update_hook if allowed.
460 (Frecord_buffer, Funrecord_buffer): New functions.
461 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
462 switch-to-buffer to window.el.
463 (bury-buffer): Move to window.el.
464 (Vbuffer_list_update_hook): New variable.
465
466 * lisp.h (other_buffer_safely): Add prototype in buffer.c
467 section.
468
469 * window.h (resize_frame_windows): Move up in code.
470 (Fwindow_frame): Remove EXFUN.
471 (replace_buffer_in_all_windows): Remove prototype.
472 (replace_buffer_in_windows_safely): Add prototype.
473
474 * window.c: Declare Qdelete_window static again. Move down
475 declaration of select_count.
476 (Fnext_window, Fprevious_window): Rewrite doc-strings.
477 (Fother_window): Move to window.el.
478 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
479 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
480 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
481 window.el.
482 (replace_buffer_in_windows): Implement by calling
483 Qreplace_buffer_in_windows.
484 (replace_buffer_in_all_windows): Remove with some functionality
485 moved into replace_buffer_in_windows_safely.
486 (replace_buffer_in_windows_safely): New function.
487 (select_window_norecord, select_frame_norecord): Move in front
488 of run_window_configuration_change_hook. Remove now obsolete
489 declarations.
490 (Fset_window_buffer): Rewrite doc-string. Call
491 Qrecord_window_buffer.
492 (keys_of_window): Move binding for other-window to window.el.
493
b50691aa
CY
4942011-06-11 Chong Yidong <cyd@stupidchicken.com>
495
496 * dispextern.h (struct image): Replace data member, whose int_val
497 and ptr_val fields were not used by anything, with a single
498 lisp_val object.
499
500 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
501 (gif_clear_image, gif_load, imagemagick_load_image)
502 (gs_clear_image, gs_load): Callers changed.
503
3f754b86
PE
5042011-06-10 Paul Eggert <eggert@cs.ucla.edu>
505
cca69397
PE
506 * buffer.h: Include <time.h>, for time_t.
507 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
508
109e28d0
PE
509 Fix minor problems found by static checking.
510
60737f02
PE
511 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
512
4b66faf3
PE
513 Make identifiers static if they are not used in other modules.
514 * data.c (Qcompiled_function, Qframe, Qvector):
515 * image.c (QimageMagick, Qsvg):
516 * minibuf.c (Qmetadata):
517 * window.c (resize_window_check, resize_root_window): Now static.
518 * window.h (resize_window_check, resize_root_window): Remove decls.
519
109e28d0
PE
520 * window.c (window_deletion_count, delete_deletable_window):
521 Remove; unused.
46a4ce9e
PE
522 (window_body_lines): Now static.
523 (Fdelete_other_windows_internal): Mark vars as initialized.
524 Make sure 'resize_failed' is initialized.
525 (run_window_configuration_change_hook): Rename local to avoid shadowing.
526 (resize_window_apply): Remove unused local.
527 * window.h (delete_deletable_window): Remove decl.
528
109e28d0 529 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
530 (imagemagick_load_image): Fix pointer signedness problem by changing
531 last arg from unsigned char * to char *. All uses changed.
532 Also, fix a local for similar reasons.
533 Remove unused locals. Remove locals to avoid shadowing.
534 (fn_rsvg_handle_free): Remove; unused.
535 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 536 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 537
3f754b86
PE
538 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
539
2547adb1
CY
5402011-06-10 Chong Yidong <cyd@stupidchicken.com>
541
542 * image.c (gif_load): Fix omitted cast error introduced by
543 2011-06-06 change.
544
2c8e37d4
MR
5452011-06-10 Martin Rudalics <rudalics@gmx.at>
546
547 * window.h (resize_proportionally, orig_total_lines)
548 (orig_top_line): Remove from window structure.
549 (set_window_height, set_window_width, change_window_heights)
550 (Fdelete_window): Remove prototypes.
551 (resize_frame_windows): Remove duplicate declaration.
552
440a42e3
EZ
5532011-06-10 Eli Zaretskii <eliz@gnu.org>
554
555 * window.h (resize_frame_windows, resize_window_check)
556 (delete_deletable_window, resize_root_window)
557 (resize_frame_windows): Declare prototypes.
558
559 * window.c (resize_window_apply): Make definition be "static" to
560 match the prototype.
561
562dd5e9
MR
5622011-06-10 Martin Rudalics <rudalics@gmx.at>
563
564 * window.c: Remove declarations of Qwindow_size_fixed,
565 window_min_size_1, window_min_size_2, window_min_size,
566 size_window, window_fixed_size_p, enlarge_window, delete_window.
567 Remove static from declaration of Qdelete_window, it's
568 temporarily needed by Fbury_buffer.
569 (replace_window): Don't assign orig_top_line and
570 orig_total_lines.
571 (Fdelete_window, delete_window): Remove. Window deletion is
572 handled by window.el.
573 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
574 Fdelete_window calls with calls to Qdelete_window.
575 (Fdelete_other_windows): Remove. Deleting other windows is
576 handled by window.el.
577 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
578 handled in window.el.
579 (window_min_size_2, window_min_size_1, window_min_size): Remove.
580 Window minimum sizes are handled in window.el.
581 (shrink_windows, size_window, set_window_height)
582 (set_window_width, change_window_heights, window_height)
583 (window_width, CURBEG, CURSIZE, enlarge_window)
584 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
585 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
586 handled in window.el.
587 (make_dummy_parent): Rename to make_parent_window and give it a
588 second argument horflag.
589 (make_window): Don't set resize_proportionally any more.
590 (Fsplit_window): Remove. Windows are split in window.el.
591 (save_restore_action, save_restore_orig_size)
592 (shrink_window_lowest_first, save_restore_orig_size): Remove.
593 Resize mini windows in window.el.
594 (grow_mini_window, shrink_mini_window): Implement by calling
595 Qresize_root_window_vertically, resize_window_check and
596 resize_window_apply.
597 (saved_window, Fset_window_configuration, save_window_save): Do
598 not handle orig_top_line, orig_total_lines, and
599 resize_proportionally.
600 (window_min_height, window_min_width): Move to window.el.
601 (keys_of_window): Move bindings for delete-other-windows,
602 split-window, delete-window and enlarge-window to window.el.
603
604 * buffer.c: Temporarily extern Qdelete_window.
605 (Fbury_buffer): Temporarily call Qdelete_window instead of
606 Fdelete_window (Fbury_buffer will move to window.el soon).
607
608 * frame.c (set_menu_bar_lines_1): Remove code handling
609 orig_top_line and orig_total_lines.
610
611 * dispnew.c (adjust_frame_glyphs_initially): Don't use
612 set_window_height but set heights directly.
613 (change_frame_size_1): Use resize_frame_windows.
614
615 * xdisp.c (init_xdisp): Don't use set_window_height but set
616 heights directly.
617
618 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
619 resize_frame_windows instead of change_window_heights and run
620 run_window_configuration_change_hook.
621
622 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
623 instead of change_window_heights and run
624 run_window_configuration_change_hook.
625
1a13852e
MR
6262011-06-09 Martin Rudalics <rudalics@gmx.at>
627
628 * window.c (replace_window): Rename second argument REPLACEMENT to
629 NEW. New third argument SETFLAG. Rewrite.
630 (delete_window, make_dummy_parent): Call replace_window with
631 third argument 1.
632 (window_list_1): Move down in code.
633 (run_window_configuration_change_hook): Move set_buffer part
634 before select_frame_norecord part in order to unwind correctly.
635 Rename count1 to count.
636 (recombine_windows, delete_deletable_window, resize_root_window)
637 (Fdelete_other_windows_internal)
638 (Frun_window_configuration_change_hook, make_parent_window)
639 (resize_window_check, resize_window_apply, Fresize_window_apply)
640 (resize_frame_windows, Fsplit_window_internal)
641 (Fdelete_window_internal, Fresize_mini_window_internal): New
642 functions.
643 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
644
f3d1777e
MR
6452011-06-08 Martin Rudalics <rudalics@gmx.at>
646
496e208e
MR
647 * window.h (window): Add some new members to window structure -
648 normal_lines, normal_cols, new_total, new_normal, clone_number,
649 splits, nest, prev_buffers, next_buffers.
650 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 651 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 652
f3d1777e
MR
653 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
654 Remove.
496e208e
MR
655 (make_dummy_parent): Set new members of windows structure.
656 (make_window): Move down in code. Handle new members of window
657 structure.
658 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
659 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
660 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
661 (Fset_window_prev_buffers, Fwindow_next_buffers)
662 (Fset_window_next_buffers, Fset_window_clone_number): New
663 functions.
664 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
665 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
666 Doc-string fixes.
667 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
668 Argument WINDOW can be now internal window too.
669 (Fwindow_use_time): Move up in code.
670 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
671 Rewrite doc-string.
672 (Fset_window_configuration, saved_window)
673 (Fcurrent_window_configuration, save_window_save): Handle new
674 members of window structure.
b9e809c2
MR
675 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
676 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
677 (syms_of_window): New Lisp objects Qrecord_window_buffer,
678 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
679 Qget_mru_window, Qresize_root_window,
680 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
681 Qauto_buffer_name; staticpro them.
f3d1777e 682
abde8f8c
MR
6832011-06-07 Martin Rudalics <rudalics@gmx.at>
684
685 * window.c (Fwindow_total_size, Fwindow_left_column)
686 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
687 (Fwindow_list_1): New functions.
688 (window_box_text_cols): Replace with window_body_cols.
689 (Fwindow_width, Fscroll_left, Fscroll_right): Use
690 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
691 (delete_window, Fset_window_configuration): Call
692 delete_all_subwindows with window as argument.
693 (delete_all_subwindows): Take a window as argument and not a
694 structure. Rewrite.
190b47e6
MR
695 (window_loop): Remove handling of GET_LRU_WINDOW and
696 GET_LARGEST_WINDOW.
697 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
698
699 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
700 window_box_text_cols. delete_all_subwindows now takes a
701 Lisp_Object as argument.
abde8f8c
MR
702
703 * indent.c (compute_motion, Fcompute_motion): Use
704 window_body_cols instead of window_box_text_cols.
705
fa8a67e6
MR
706 * frame.c (delete_frame): Call delete_all_subwindows with root
707 window as argument.
708
a54e3482
DC
7092011-06-07 Daniel Colascione <dan.colascione@gmail.com>
710
711 * fns.c (Fputhash): Document return value.
712
60002bf5
CY
7132011-06-06 Chong Yidong <cyd@stupidchicken.com>
714
715 * image.c (gif_load): Implement gif89a spec "no disposal" method.
716
0c671da6 7172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 718
b862a52a 719 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 720
be44ca6c
PE
721 Check for overflow when converting integer to cons and back.
722 * charset.c (Fdefine_charset_internal, Fdecode_char):
723 Use cons_to_unsigned to catch overflow.
724 (Fencode_char): Use INTEGER_TO_CONS.
725 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
726 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
727 * data.c (long_to_cons, cons_to_long): Remove.
728 (cons_to_unsigned, cons_to_signed): New functions.
729 These signal an error for invalid or out-of-range values.
730 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
731 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
732 * font.c (Ffont_variation_glyphs):
733 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
734 * lisp.h: Include <intprops.h>.
735 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
736 (cons_to_signed, cons_to_unsigned): New decls.
737 (long_to_cons, cons_to_long): Remove decls.
738 * undo.c (record_first_change): Use INTEGER_TO_CONS.
739 (Fprimitive_undo): Use CONS_TO_INTEGER.
740 * xfns.c (Fx_window_property): Likewise.
741 * xselect.c: Include <limits.h>.
742 (x_own_selection, selection_data_to_lisp_data):
743 Use INTEGER_TO_CONS.
744 (x_handle_selection_request, x_handle_selection_clear)
745 (x_get_foreign_selection, Fx_disown_selection_internal)
746 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
747 (lisp_data_to_selection_data): Use cons_to_unsigned.
748 (x_fill_property_data): Use cons_to_signed.
749 Report values out of range.
750
d1f3d2af
PE
751 Check for buffer and string overflow more precisely.
752 * buffer.h (BUF_BYTES_MAX): New macro.
753 * lisp.h (STRING_BYTES_MAX): New macro.
754 * alloc.c (Fmake_string):
755 * character.c (string_escape_byte8):
756 * coding.c (coding_alloc_by_realloc):
757 * doprnt.c (doprnt):
758 * editfns.c (Fformat):
759 * eval.c (verror):
760 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
761 since they may not be the same number.
762 * editfns.c (Finsert_char):
763 * fileio.c (Finsert_file_contents):
764 Likewise for BUF_BYTES_MAX.
765
dd52fcea
PE
766 * image.c: Use ptrdiff_t, not int, for sizes.
767 (slurp_file): Switch from int to ptrdiff_t.
768 All uses changed.
769 (slurp_file): Check that file size fits in both size_t (for
770 malloc) and ptrdiff_t (for sanity and safety).
771
7f9bbdbb
PE
772 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
773 if b->modtime has its maximal value.
774
dfe18f82
PE
775 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
776
84acfcf0
PE
777 Don't assume time_t can fit into int.
778 * buffer.h (struct buffer.modtime): Now time_t, not int.
779 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
780 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
781
ccd9a01a
PE
782 Minor fixes for signed vs unsigned integers.
783 * character.h (MAYBE_UNIFY_CHAR):
784 * charset.c (maybe_unify_char):
785 * keyboard.c (read_char, reorder_modifiers):
786 XINT -> XFASTINT, since the integer must be nonnegative.
787 * ftfont.c (ftfont_spec_pattern):
788 * keymap.c (access_keymap, silly_event_symbol_error):
789 XUINT -> XFASTINT, since the integer must be nonnegative.
790 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
791 since it makes no difference and we prefer signed.
792 * keyboard.c (record_char): Use XUINT when all the neighbors do.
793 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
794 nonnegative.
795
d6d100dd
SM
7962011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
797
798 * window.h (Fwindow_frame): Declare.
799
2b6148e4
PE
8002011-06-06 Paul Eggert <eggert@cs.ucla.edu>
801
802 * alloc.c: Simplify handling of large-request failures (Bug#8800).
803 (SPARE_MEMORY): Always define.
804 (LARGE_REQUEST): Remove.
805 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
806
f230ecc9
MR
8072011-06-06 Martin Rudalics <rudalics@gmx.at>
808
727e958e
MR
809 * lisp.h: Move EXFUNS for Fframe_root_window,
810 Fframe_first_window and Fset_frame_selected_window to window.h.
811
812 * window.h: Move EXFUNS for Fframe_root_window,
813 Fframe_first_window and Fset_frame_selected_window here from
814 lisp.h.
815
816 * frame.c (Fwindow_frame, Fframe_first_window)
817 (Fframe_root_window, Fframe_selected_window)
818 (Fset_frame_selected_window): Move to window.c.
819 (Factive_minibuffer_window): Move to minibuf.c.
820 (Fother_visible_frames_p): New function.
821
822 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
823
f230ecc9
MR
824 * window.c (decode_window, decode_any_window): Move up in code.
825 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
826 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
827 (Fwindow_buffer): Move up and rewrite doc-string.
828 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
829 (Fwindow_prev): New functions.
727e958e
MR
830 (Fwindow_frame): Move here from frame.c. Accept any window as
831 argument.
832 (Fframe_root_window, Fframe_first_window)
833 (Fframe_selected_window): Move here from frame.c. Accept frame
834 or arbitrary window as argument. Update doc-strings.
835 (Fminibuffer_window): Move up in code.
836 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
837 (Fset_frame_selected_window): Move here from frame.c.
838 Marginal rewrite.
727e958e
MR
839 (Fselected_window, select_window, Fselect_window): Move up in
840 code. Minor doc-string fixes.
f230ecc9 841
4d09bcf6
PE
8422011-06-06 Paul Eggert <eggert@cs.ucla.edu>
843
844 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
845 Do not assume that spare memory exists; that assumption is valid
846 only if SYSTEM_MALLOC.
847 (LARGE_REQUEST): New macro, so that the issue of large requests
848 is separated from the issue of spare memory.
849
810928a2
AS
8502011-06-05 Andreas Schwab <schwab@linux-m68k.org>
851
172418ad
AS
852 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
853 format. (Bug#8806)
854
43f862f7
AS
855 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
856
810928a2
AS
857 * xfns.c (x_set_scroll_bar_default_width): Move declarations
858 before statements.
859
a059fe24
JD
8602011-06-05 Jan Djärv <jan.h.d@swipnet.se>
861
862 * gtkutil.c (xg_get_default_scrollbar_width): New function.
863
864 * gtkutil.h: Declare xg_get_default_scrollbar_width.
865
866 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
867 min width by calling x_set_scroll_bar_default_width (Bug#8505).
868
989bf368
JB
8692011-06-05 Juanma Barranquero <lekktu@gmail.com>
870
871 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
872
4b80f674
CY
8732011-06-04 Chong Yidong <cyd@stupidchicken.com>
874
875 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
876 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
877 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
878 New error handlers.
4b80f674
CY
879 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
880 Obey Vx_select_enable_clipboard_manager. Catch errors in
881 x_clipboard_manager_save (Bug#8779).
882 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 883 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 884
99a33b77 8852011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
886
887 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
888
99a33b77 8892011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
890
891 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
892 in the current matrix if keep_current_p is non-zero.
893
8264569d
EZ
8942011-06-04 Eli Zaretskii <eliz@gnu.org>
895
896 * bidi.c (bidi_level_of_next_char): Fix last change.
897
57f97249
EZ
8982011-06-03 Eli Zaretskii <eliz@gnu.org>
899
fec2107c 900 Support bidi reordering of text covered by display properties.
57f97249 901
fec2107c
EZ
902 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
903 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
904 (bidi_cache_search, bidi_cache_iterator_state)
905 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
906 (bidi_level_of_next_char, bidi_move_to_visually_next):
907 Support character positions inside a run of characters covered by a
fec2107c
EZ
908 display string.
909 (bidi_paragraph_init, bidi_resolve_explicit_1)
910 (bidi_level_of_next_char): Call bidi_fetch_char and
911 bidi_fetch_char_advance instead of FETCH_CHAR and
912 FETCH_CHAR_ADVANCE.
913 (bidi_init_it): Initialize new members.
914 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
915 definitions.
916 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
917 instead of using explicit *_CHAR codes.
d6d100dd
SM
918 (bidi_resolve_explicit, bidi_resolve_weak):
919 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
920 bidirectional text is supported only in multibyte buffers.
921 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
922 it to initialize the frame_window_p member of struct bidi_it.
923 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
924 (bidi_resolve_explicit, bidi_resolve_weak)
925 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
926 bidi_it->nchars is non-positive.
927 (bidi_level_of_next_char): Don't try to lookup the cache for the
928 next/previous character if nothing is cached there yet, or if we
929 were just reseat()'ed to a new position.
c40e2fb2 930
0e14fe90
EZ
931 * xdisp.c (set_cursor_from_row): Set start and stop points
932 according to the row's direction when priming the loop that looks
933 for the glyph on which to display cursor.
934 (single_display_spec_intangible_p): Function deleted.
935 (display_prop_intangible_p): Reimplement to call
936 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
937 Accept 3 additional arguments needed by handle_display_spec.
938 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
939 values: lists, `(when COND...)' forms, etc.
940 (single_display_spec_string_p): Support property values that are
941 lists with the argument STRING its top-level element.
942 (display_prop_string_p): Fix the condition for processing a
943 property that is a list to be consistent with handle_display_spec.
fec2107c 944 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
945 last portion of handle_display_prop.
946 (compute_display_string_pos): Accept additional argument
947 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
948 value of a `display' property is a "replacing spec".
949 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
950 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
951 the display property, but just return a value indicating whether
952 the display property will replace the characters it covers.
953 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
954 frame_window_p members of struct bidi_it.
d6d100dd
SM
955 (compute_display_string_pos, compute_display_string_end):
956 New functions.
fec2107c
EZ
957 (push_it): Accept second argument POSITION, where pop_it should
958 jump to continue iteration.
959 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 960
fec2107c
EZ
961 * keyboard.c (adjust_point_for_property): Adjust the call to
962 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
963
964 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
965 (bidi_init_it): Update prototypes.
966 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
967 (compute_display_string_pos, compute_display_string_end):
968 Declare prototypes.
fec2107c
EZ
969 (struct bidi_it): New members nchars and disp_pos. ch_len is now
970 EMACS_INT.
fc6f18ce 971
40087514 9722011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 973
57f53182
PE
974 Malloc failure behavior now depends on size of allocation.
975 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
976 * lisp.h: Change signatures accordingly.
977 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
978 All callers changed. (Bug#8762)
979
980 * gnutls.c: Use Emacs's memory allocators.
981 Without this change, the gnutls library would invoke malloc etc.
982 directly, which causes problems on non-SYNC_INPUT hosts, and which
983 runs afoul of improving memory_full behavior. (Bug#8761)
984 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
985 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
986 xfree instead of the default malloc, realloc, free.
987 (Fgnutls_boot): No need to check for memory allocation failure,
988 since xmalloc does that for us.
989
ac32cd99 990 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
991 * category.c (hash_get_category_set):
992 * ccl.c (ccl_driver):
993 * charset.c (Fdefine_charset_internal):
994 * charset.h (struct charset.hash_index):
995 * composite.c (get_composition_id, gstring_lookup_cache)
996 (composition_gstring_put_cache):
997 * composite.h (struct composition.hash_index):
998 * dispextern.h (struct image.hash):
999 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1000 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1001 (hashfn_equal, hashfn_user_defined, make_hash_table)
1002 (maybe_resize_hash_table, hash_lookup, hash_put)
1003 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1004 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1005 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1006 * image.c (make_image, search_image_cache, lookup_image)
1007 (xpm_put_color_table_h):
1008 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1009 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1010 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1011 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1012 * alloc.c (allocate_vectorlike):
1013 Check for overflow in vector size calculations.
1014 * ccl.c (ccl_driver):
1015 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1016 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1017 need to be updated by these changes.
40087514
PE
1018 * fns.c (make_hash_table, maybe_resize_hash_table):
1019 Check for integer overflow with large hash tables.
0de4bb68
PE
1020 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1021 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1022 (SXHASH_REDUCE): New macro.
1023 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1024 Use it instead of discarding useful hash info with large hash values.
1025 (sxhash_float): New function.
1026 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1027 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1028 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1029 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1030 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1031 Adjust signatures to match updated version of code.
1032 (consing_since_gc): Now EMACS_INT, since a single hash table can
1033 use more than INT_MAX bytes.
1034
698d32e2
DN
10352011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1036
1037 Make it possible to build with GCC-4.6+ -O2 -flto.
1038
1039 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1040
fd6fa53f
SM
10412011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1042
1043 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1044 Call minibuffer-inactive-mode.
1045
864db017
JB
10462011-05-31 Juanma Barranquero <lekktu@gmail.com>
1047
1048 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1049 Update dependencies.
1050
2ad0baf4
DN
10512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1052
1053 * data.c (init_data): Remove code for UTS, this system is not
1054 supported anymore.
1055
4fcc2638
DN
10562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1057
1058 Don't force ./temacs to start in terminal mode.
1059
1060 * frame.c (make_initial_frame): Initialize faces in all cases, not
1061 only when CANNOT_DUMP is defined.
1062 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1063
c56e0fd5
DN
10642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1065
1066 * dispnew.c (add_window_display_history): Use const for the string
1067 pointer. Remove declaration, not needed.
1068
333d54da 10692011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1070
55d4c1b2 1071 Use 'inline', not 'INLINE'.
333d54da 1072 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1073 * alloc.c, fontset.c (INLINE): Remove.
1074 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1075 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1076 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1077 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1078 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1079
738db178
DN
10802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1081
1082 Make it possible to run ./temacs.
1083
1084 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1085 syms_of_callproc does the same thing. Remove test for
1086 "initialized", do it in the caller.
1087 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1088
620c53a6
SM
10892011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1090
1091 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1092 (read_minibuf): Use get_minibuffer.
1093 (syms_of_minibuf): Use DEFSYM.
1094 (Qmetadata): New var.
1095 * data.c (Qbuffer): Don't make it static.
1096 (syms_of_data): Use DEFSYM.
1097
e003a292
PE
10982011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1099
1100 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1101 (CCL_CODE_MIN): New macro.
1102
ed008a6d
PE
11032011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1104
3687c2ef
PE
1105 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1106
ed008a6d
PE
1107 * eval.c (Qdebug): Now static.
1108 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1109 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1110 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1111
d66c4c7c
CY
11122011-05-29 Chong Yidong <cyd@stupidchicken.com>
1113
1114 * image.c: Various fixes to ImageMagick code comments.
1115 (Fimagemagick_types): Doc fix.
1116
5fbc2025
PE
11172011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1118
0196f88a
PE
1119 Minor fixes prompted by GCC 4.6.0 warnings.
1120
1121 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1122
5fbc2025
PE
1123 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1124 (x_clipboard_manager_save_all): Move extern decl to ...
1125 * xterm.h: ... here, so that it can be checked for consistency.
1126
1dd3c2d9
CY
11272011-05-29 Chong Yidong <cyd@stupidchicken.com>
1128
1129 * xselect.c (x_clipboard_manager_save_frame)
1130 (x_clipboard_manager_save_all): New functions.
1131 (Fx_clipboard_manager_save): Lisp function deleted.
1132
1133 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1134 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1135
1136 * xterm.h: Update prototype.
1137
5ba6571d
WX
11382011-05-28 William Xu <william.xwl@gmail.com>
1139
1140 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1141 exiting (Bug#8239).
1142
3eaff834
JM
11432011-05-28 Jim Meyering <meyering@redhat.com>
1144
e1900994 1145 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1146 * fns.c (to_uchar): Define.
1147 (crypto_hash_function): Use it to convert some newly-signed
1148 variables to unsigned, to avoid sign-extension bugs. For example,
1149 without this change, (md5 "truc") would evaluate to
1150 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1151 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1152 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1153
0f6990a7
PE
11542011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1155
1156 Integer overflow fixes.
c8a9ca5a 1157
08686060
PE
1158 * dbusbind.c: Serial number integer overflow fixes.
1159 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1160 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1161 to hold a serial number that is too large for a fixnum.
1162 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1163 Check for serial numbers out of range. Decode any serial number
59568bf0 1164 that was so large that it became a float. (Bug#8722)
08686060 1165
2d1fc3c7
PE
1166 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1167 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1168 Use XFASTINT rather than XUINT when numbers are nonnegative.
1169 (xd_append_arg, Fdbus_method_return_internal):
1170 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1171 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1172 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1173 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1174 (Bug#8722)
2d1fc3c7 1175
c8a9ca5a
PE
1176 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1177
519e1d69
PE
1178 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1179
30569699
PE
1180 ccl: add integer overflow checks
1181 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1182 (IN_INT_RANGE): New macros.
1183 (ccl_driver): Use them to check for integer overflow when
1184 decoding a CCL program. Many of the new checks are whether XINT (x)
1185 fits in int; it doesn't always, on 64-bit hosts. The new version
1186 doesn't catch all possible integer overflows, but it's an
847044ea 1187 improvement. (Bug#8719)
30569699 1188
c11285dc
PE
1189 * alloc.c (make_event_array): Use XINT, not XUINT.
1190 There's no need for unsigned here.
1191
fdccd48e
PE
1192 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1193 This follows up to the 2011-05-06 change that substituted uintptr_t
1194 for EMACS_INT. This case wasn't caught back then.
1195
37910ab2
PE
1196 Rework Fformat to avoid integer overflow issues.
1197 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1198 now (part of C89). Include <verify.h>.
1199 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1200 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1201 (Fformat): Avoid the prepass trying to compute sizes; it was only
1202 approximate and thus did not catch overflow reliably. Instead, walk
1203 through the format just once, formatting and computing sizes as we go,
1204 checking for integer overflow at every step, and allocating a larger
1205 buffer as needed. Keep track separately whether the format is
1206 multibyte. Keep only the most-recently calculated precision, rather
1207 than them all. Record whether each argument has been converted to
1208 string. Use EMACS_INT, not int, for byte and char and arg counts.
1209 Support field widths and precisions larger than INT_MAX. Avoid
1210 sprintf's undefined behavior with conversion specifications such as %#d
1211 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1212 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1213 formatting out-of-range floating point numbers with int
1214 formats. (Bug#8668)
1215
2e6578fb
PE
1216 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1217
0ae6bdee
PE
1218 * data.c: Avoid integer truncation in expressions involving floats.
1219 * data.c: Include <intprops.h>.
1220 (arith_driver): When there's an integer overflow in an expression
1221 involving floating point, convert the integers to floating point
1222 so that the resulting value does not suffer from catastrophic
1223 integer truncation. For example, on a 64-bit host (* 4
1224 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1225 Do not rely on undefined behavior after integer overflow.
1226
de883a70
PE
1227 merge count_size_as_multibyte, parse_str_to_multibyte
1228 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1229 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1230 Check for integer overflow.
1231 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1232 since it's now a duplicate of the other. This is more of
1233 a character than a buffer op, so better that it's in character.c.
1234 * fns.c, print.c: Adjust to above changes.
1235
2ff916cb
PE
12362011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1237
1238 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1239
f1b54466
PE
12402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1241
fb1ac845
PE
1242 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1243 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1244 (x_clipboard_manager_save): Now static.
1245 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1246
f1b54466
PE
1247 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1248 (crypto_hash_function): Now static.
1249 Fix pointer signedness problems. Avoid unnecessary initializations.
1250
a9f737ee
CY
12512011-05-27 Chong Yidong <cyd@stupidchicken.com>
1252
1253 * termhooks.h (Vselection_alist): Make it terminal-local.
1254
1255 * terminal.c (create_terminal): Initialize it.
1256
1257 * xselect.c: Support for clipboard managers.
1258 (Vselection_alist): Move to termhooks.h as terminal-local var.
1259 (LOCAL_SELECTION): New macro.
1260 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1261 (symbol_to_x_atom): Remove gratuitous arg.
1262 (x_handle_selection_request, lisp_data_to_selection_data)
1263 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1264 (x_own_selection, x_get_local_selection, x_convert_selection):
1265 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1266 (some_frame_on_display): Delete unused function.
1267 (Fx_own_selection_internal, Fx_get_selection_internal)
1268 (Fx_disown_selection_internal, Fx_selection_owner_p)
1269 (Fx_selection_exists_p): New optional frame arg.
1270 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1271 (x_handle_selection_clear): Don't treat other terminals with the
1272 same keyboard specially. Use the terminal-local Vselection_alist.
1273 (x_clear_frame_selections): Use Frun_hook_with_args.
1274
1275 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1276
1277 * xterm.h: Add support for those atoms.
1278
e067f0c1
CY
12792011-05-26 Chong Yidong <cyd@stupidchicken.com>
1280
1281 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1282 (converted_selections, conversion_fail_tag): New global variables.
1283 (x_selection_request_lisp_error): Free the above.
1284 (x_get_local_selection): Remove unnecessary code.
1285 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1286 of converted selections stored in converted_selections.
1287 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1288 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1289 (x_convert_selection): New function.
1290 (x_handle_selection_event): Simplify.
1291 (x_get_foreign_selection): Don't ignore incoming requests while
1292 waiting for an answer; this will fail when we implement
1293 SAVE_TARGETS, and seems unnecessary anyway.
1294 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1295 (Vx_sent_selection_functions): Doc fix.
1296
0f4aebc0
LL
12972011-05-26 Leo Liu <sdl.web@gmail.com>
1298
1299 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1300
e61124cd
YM
13012011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1302
1303 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1304
1305 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1306 for fringe update if it has periodic bitmap.
1307 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1308 and fringe_bitmap_periodic_p.
1309
1310 * fringe.c (get_fringe_bitmap_data): New function.
1311 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1312 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1313 row. Mark glyph row for fringe update if periodicity changed.
1314
1315 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1316 for fringe update unless it has periodic bitmap.
1317
f16d9837
KH
13182011-05-25 Kenichi Handa <handa@m17n.org>
1319
1320 * xdisp.c (get_next_display_element): Set correct it->face_id for
1321 a static composition.
1322
e1b90ef6
LL
13232011-05-24 Leo Liu <sdl.web@gmail.com>
1324
1325 * deps.mk (fns.o):
1326 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1327
1328 * fns.c (crypto_hash_function, Fsha1): New function.
1329 (Fmd5): Use crypto_hash_function.
1330 (syms_of_fns): Add Ssha1.
1331
7400048f
PE
13322011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1333
1334 * gnutls.c: Remove unused macros.
1335 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1336 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1337 Remove macros that are defined and never used.
1338 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1339
abb71cf4
CY
13402011-05-22 Chong Yidong <cyd@stupidchicken.com>
1341
1342 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1343 (Fx_get_selection_internal): Minor cleanup.
1344 (Fx_own_selection_internal): Rename arguments for consistency with
1345 select.el.
1346
6307db39
PE
13472011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1348
1349 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1350
f3d4e0a4
CY
13512011-05-22 Chong Yidong <cyd@stupidchicken.com>
1352
1353 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1354
4d8ade89
YM
13552011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1356
1357 * dispnew.c (scrolling_window): Don't exclude the case that the
1358 last enabled row in the desired matrix touches the bottom boundary.
1359
32078c8d
GM
13602011-05-21 Glenn Morris <rgm@gnu.org>
1361
1362 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1363 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1364 and add some more files.
32078c8d 1365
7285dc67
EZ
13662011-05-20 Eli Zaretskii <eliz@gnu.org>
1367
1368 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1369 report_file_error introduced by the change from 2011-05-07.
1370
89d1bd22
PE
13712011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1372
1373 * systime.h (Time): Define only if emacs is defined.
1374 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1375 where the include path doesn't have X11/X.h by default. See
1376 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1377
e23640bb 13782011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1379
1380 * composite.c (find_automatic_composition): Fix previous change.
1381
b9704ad9
GM
13822011-05-20 Glenn Morris <rgm@gnu.org>
1383
1384 * lisp.mk: New file, split from Makefile.in.
1385 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1386 (shortlisp): Remove.
1387 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1388
4a720484
GM
13892011-05-19 Glenn Morris <rgm@gnu.org>
1390
1391 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1392 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1393 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1394 (lisp): Set the order to that of loadup.el.
1395 (shortlisp): Make it a copy of $lisp.
1396 (SOME_MACHINE_LISP): Remove.
1397 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1398 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1399
a28d4396
KH
14002011-05-18 Kenichi Handa <handa@m17n.org>
1401
1402 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1403 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1404 (find_automatic_composition): Mostly rewrite for efficiency.
1405
a2b1fa8e
JB
14062011-05-18 Juanma Barranquero <lekktu@gmail.com>
1407
1408 * makefile.w32-in: Update dependencies.
1409
8e1f5610
CS
14102011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1411
1412 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1413 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1414
7025ee00 14152011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1416
cdfa6eab
PE
1417 Fix some integer overflow issues, such as string length overflow.
1418
06d6db33
PE
1419 * insdel.c (count_size_as_multibyte): Check for string overflow.
1420
2b4560a8
PE
1421 * character.c (lisp_string_width): Check for string overflow.
1422 Use EMACS_INT, not int, for string indexes and lengths; in
1423 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1424 the resulting string length overflows an EMACS_INT; instead,
1425 report a string overflow if no precision given. When checking for
1426 precision exhaustion, use a check that cannot possibly have
1427 integer overflow. (Bug#8675)
1428 * character.h (lisp_string_width): Adjust to new signature.
1429
cb93f9be
PE
1430 * alloc.c (string_overflow): New function.
1431 (Fmake_string): Use it. This doesn't change behavior, but saves
1432 a few bytes and will simplify future changes.
1433 * character.c (string_escape_byte8): Likewise.
1434 * lisp.h (string_overflow): New decl.
1435
1a1f3366
PE
1436 Fixups, following up to the user-interface timestamp change.
1437 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1438 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1439 * msdos.c (mouse_get_pos): Likewise.
1440 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1441 * w32gui.h (Time): Define by including "systime.h" rather than by
1442 declaring it ourselves. (Bug#8664)
1443
d4e3e4d3
PE
1444 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1445 * image.c (clear_image_cache): Likewise.
1446
f6a24d19
PE
1447 * term.c (term_mouse_position): Don't assume time_t wraparound.
1448
08dc5ae6
PE
1449 Be more systematic about user-interface timestamps.
1450 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1451 and sometimes 'EMACS_UINT', to represent these timestamps.
1452 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1453 This makes the code easier to follow, and makes it easier to catch
1454 integer overflow bugs such as Bug#8664.
1455 * frame.c (Fmouse_position, Fmouse_pixel_position):
1456 Use Time, not unsigned long, for user-interface timestamps.
1457 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1458 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1459 * keyboard.h (last_event_timestamp): Likewise.
1460 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1461 * menu.h (xmenu_show): Likewise.
1462 * term.c (term_mouse_position): Likewise.
1463 * termhooks.h (struct input_event.timestamp): Likewise.
1464 (struct terminal.mouse_position_hook): Likewise.
1465 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1466 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1467 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1468 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1469 what it was before.
1470 * menu.h, termhooks.h: Include "systime.h", for Time.
1471
8e55734a
PE
1472 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1473 Don't assume that the difference between two unsigned long values
1474 can fit into an integer. At this point, we know button_down_time
1475 <= event->timestamp, so the difference must be nonnegative, so
1476 there's no need to cast the result if double-click-time is
1477 nonnegative, as it should be; check that it's nonnegative, just in
1478 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1479 apart (about 25 days). (Bug#8664)
8e55734a 1480
841f1b75 1481 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1482 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1483
3e26f69c
PE
1484 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1485 that always fit in int. Use a sentinel instead of a counter, to
1486 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1487 * frame.h (struct frame): Use int for menu_bar_items_used
1488 instead of EMACS_INT, since it always fits in int.
3e26f69c 1489
5cc152c0
PE
1490 * menu.c (grow_menu_items): Check for int overflow.
1491
d89eb65e
PE
1492 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1493
5235bd3e
PE
1494 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1495 Before, the code was not consistent. These values cannot exceed
1496 2**31 - 1 so there's no need to make them unsigned.
1497 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1498 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1499 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1500 as modifiers.
1501 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1502
bc827e23
PE
1503 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1504 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1505 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1506 presumably because the widths might not match.
1507
78eb494e
PE
1508 * window.c (size_window): Avoid needless test at loop start.
1509
04f2d78b
CB
15102011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1511
1512 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1513
d2fc7e3d 15142011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1515
1516 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1517
d2fc7e3d 15182011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1519
1520 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1521 `width' to `bar_area_x' and `bar_area_width', respectively.
1522 (x_scroll_run): Take account of fringe background extension.
1523
04f2d78b
CB
1524 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1525 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1526 `bar_area_width', respectively.
1527 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1528 background extension.
1529
79b70037
GM
15302011-05-10 Jim Meyering <meyering@redhat.com>
1531
1532 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1533
2f142cc5
JB
15342011-05-10 Juanma Barranquero <lekktu@gmail.com>
1535
1536 * image.c (Finit_image_library): Return t for built-in image types,
1537 like pbm and xbm. (Bug#8640)
1538
57679c86
AS
15392011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1540
1541 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1542
888c9e86
EZ
15432011-05-07 Eli Zaretskii <eliz@gnu.org>
1544
b0512a1d
EZ
1545 * w32console.c (Fset_screen_color): Doc fix.
1546 (Fget_screen_color): New function.
1547 (syms_of_ntterm): Defsubr it.
1548
7285dc67
EZ
1549 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1550 unlink the temporary file if Fcall_process didn't create it in the
1551 first place.
1552 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1553 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1554 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1555 cue to call_process_cleanup not to close that handle.
1556
4d3fcc8e
BK
15572011-05-07 Ben Key <bkey76@gmail.com>
1558
1559 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1560 one of two shell specific rules, either bootstrap-temacs-CMD or
1561 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1562 to the previous implementation of the bootstrap-temacs rule.
1563 The bootstrap-temacs-CMD rule is similar to the previous
1564 implementation of the bootstrap-temacs rule except that it
1565 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1566 variable.
1567
1568 These changes, along with some changes to nt/configure.bat,
1569 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1570 earlier fix to add support for --cflags and --ldflags options
1571 that include quotes so that it works whether make uses cmd or
1572 sh as the shell.
1573
b4289b64
MA
15742011-05-06 Michael Albinus <michael.albinus@gmx.de>
1575
1576 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1577 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1578 is a constant.
1579 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1580 a string. Handle both cases.
1581 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1582 (Fdbus_register_method): Use Qinvalid_function.
1583
af4c0e28
JB
15842011-05-06 Juanma Barranquero <lekktu@gmail.com>
1585
1586 * makefile.w32-in: Update dependencies.
1587 (LISP_H): Add inttypes.h and stdin.h.
1588 (PROCESS_H): Add unistd.h.
1589
c51453d9
EZ
15902011-05-06 Eli Zaretskii <eliz@gnu.org>
1591
1592 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1593 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1594
8ff0ac3c 15952011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1596
4c4b566b
PE
1597 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1598
aab2b9b5
PE
1599 * term.c (vfatal): Remove stray call to va_end.
1600 It's not needed and the C Standard doesn't allow it here anyway.
1601
c378da0b
PE
1602 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1603 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1604
288b08c7
PE
1605 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1606 bytes.
1607
e3601888
PE
1608 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1609
db6c0e74
PE
1610 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1611
dd5963ea
PE
1612 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1613
88c9450f
PE
1614 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1615
2f9442b8
PE
1616 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1617
c032b5f8
PE
1618 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1619 * charset.c (Fdefine_charset_internal): Don't initialize
1620 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1621 32-bit int (Bug#8600).
a108c10b
PE
1622
1623 * lread.c (read_integer): Be more consistent with string-to-number.
1624 Use string_to_number to do the actual conversion; this avoids
1625 rounding errors and fixes some other screwups. Without this fix,
1626 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1627 (digit_to_number): Move earlier, for benefit of read_integer.
1628 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1629 not a digit in any supported base. (Bug#8602)
a108c10b 1630
ad5f9eea
PE
1631 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1632
aec1708a
PE
1633 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1634 to match comment at start of function. This also removes a
1635 GCC warning about overflow in a 32+64-bit port.
1636
47be4ab5
PE
1637 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1638
371cac43
PE
1639 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1640 Reported by Stefan Monnier in
1641 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1642 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1643 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1644
d01a7826
PE
1645 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1646 (EMACS_UINTPTR): Likewise, with uintptr_t.
1647
7fd47d5c
PE
1648 * lisp.h: Prefer 64-bit EMACS_INT if available.
1649 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1650 on 32-bit hosts that have 64-bit int, so that they can access
1651 large files.
122b0c86
PE
1652 However, temporarily disable this change unless the temporary
1653 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1654
8727937b
PE
1655 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1656
8ac068ac
PE
1657 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1658 This removes an assumption that EMACS_INT and long are the same
1659 width as pointers. The assumption is true for Emacs porting targets
1660 now, but we want to make other targets possible.
1661 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1662 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1663 In the rest of the code, change types of integers that hold casted
1664 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1665 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1666 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1667 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1668 No need to cast type when ORing.
1669 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1670 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1671 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1672 assume EMACS_INT is the same width as char *.
1673 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1674 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1675 Remove no-longer-needed casts.
1676 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1677 (xg_tool_bar_help_callback, xg_make_tool_item):
1678 Use EMACS_INTPTR to hold an integer
1679 that will be cast to void *; this can avoid a GCC warning
1680 if EMACS_INT is not the same width as void *.
1681 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1682 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1683 (current_message_1, set_message_1):
1684 Use a local to convert to proper width without a cast.
1685 * xmenu.c (dialog_selection_callback): Likewise.
1686
ede49d71
PE
1687 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1688 Also, don't assume VALBITS / RAND_BITS is less than 5,
1689 and don't rely on undefined behavior when shifting a 1 left into
1690 the sign bit.
1691 * lisp.h (get_random): Change signature to match.
1692
2f30ecd0
PE
1693 * lread.c (hash_string): Use size_t, not int, for hash computation.
1694 Normally we prefer signed values; but hashing is special, because
1695 it's better to use unsigned division on hash table sizes so that
1696 the remainder is nonnegative. Also, size_t is the natural width
1697 for hashing into memory. The previous code used 'int', which doesn't
1698 retain enough info to hash well into very large tables.
1699 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1700
2a866e7b
PE
1701 * dbusbind.c: Don't possibly lose pointer info when converting.
1702 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1703 Use XPNTR rather than XHASH, so that the high-order bits of
1704 the pointer aren't lost when converting through void *.
1705
51639eac
PE
1706 * eval.c (Fautoload): Don't double-shift a pointer.
1707
92394119
PE
1708 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1709
dbdb9a7c
JB
17102011-05-06 Juanma Barranquero <lekktu@gmail.com>
1711
1712 * gnutls.c (DEF_GNUTLS_FN):
1713 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1714
db7a0b4f
AS
17152011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1716
1717 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1718 marker. (Bug#8610)
1719
f7ff1b0f 17202011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1721
1722 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1723 New version that can reserve upto 2GB of heap space.
1724
f7ff1b0f 17252011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1726
1727 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1728
639c109b
TZ
17292011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1730
1731 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1732 `gnutls_certificate_set_x509_key_file'.
1733
d2127135
JB
17342011-05-05 Juanma Barranquero <lekktu@gmail.com>
1735
1736 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1737 Update dependencies.
1738
e968f4f3
JB
17392011-05-04 Juanma Barranquero <lekktu@gmail.com>
1740
1741 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1742 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1743 Remove unused parameter `fildes'.
1744 * process.c (read_process_output, send_process): Don't pass it.
1745
84d358f0
JB
17462011-05-04 Juanma Barranquero <lekktu@gmail.com>
1747
1748 Fix previous change: the library cache is defined in w32.c.
1749 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1750 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1751
0898ca10
JB
17522011-05-04 Juanma Barranquero <lekktu@gmail.com>
1753
1754 Implement dynamic loading of GnuTLS on Windows.
1755
1756 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1757 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1758 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1759 Declare.
1760
1761 * gnutls.c (Qgnutls_dll): Define.
1762 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1763 (gnutls_*): Declare function pointers.
1764 (init_gnutls_functions): New function to initialize function pointers.
1765 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1766 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1767 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1768 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1769 (emacs_gnutls_write, emacs_gnutls_read)
1770 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1771 (Fgnutls_available_p): New function.
1772 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1773 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1774 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1775
1776 * image.c: Include w32.h.
1777 (Vimage_type_cache): Delete.
1778 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1779 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1780 (w32_delayed_load): Move to w32.c.
1781
1782 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1783
1784 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1785 (w32_delayed_load): Move from image.c. When loading a library, record
1786 its filename in the :loaded-from property of the library id.
1787 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1788 Initialize and staticpro them.
1789 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1790
1791 * process.c: Include lisp.h before w32.h, not after.
1792 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1793 instead of gnutls_record_check_pending.
1794
1795 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1796
ff4de4aa
TZ
17972011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1798
1799 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1800 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1801 as passed in.
1802
abe95abb
JD
18032011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1804
1805 * xterm.c (x_set_frame_alpha): Do not set property on anything
1806 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1807
e16e55d4
JB
18082011-05-02 Juanma Barranquero <lekktu@gmail.com>
1809
1810 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1811
bafcf6a5
JB
18122011-05-02 Juanma Barranquero <lekktu@gmail.com>
1813
1814 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1815 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1816 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1817 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1818 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1819 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1820 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1821 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1822 (Qgnutls_bootprop_callbacks_verify): Make static.
1823
e7a6747f
AS
18242011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1825
19ed11ba
AS
1826 * callproc.c: Indentation fixup.
1827
e7a6747f 1828 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1829 (wait_for_termination, interruptible_wait_for_termination):
1830 Move after wait_for_termination_1.
e7a6747f 1831
1ef14cb4
LMI
18322011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1833
1834 * sysdep.c (interruptible_wait_for_termination): New function
1835 which is like wait_for_termination, but allows keyboard
1836 interruptions.
1837
1838 * callproc.c (Fcall_process): Add (:file "file") as an option for
1839 the STDOUT buffer.
1840 (Fcall_process_region): Ditto.
1841
330d880c
EZ
18422011-04-30 Eli Zaretskii <eliz@gnu.org>
1843
8db90b73
EZ
1844 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1845 rather than `XVECTOR (FOO)->size'.
1846
330d880c
EZ
1847 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1848 inttypes.h, as a gnulib replacement is used if it not available in
1849 system headers.
1850
15cbd324
EZ
18512011-04-21 Eli Zaretskii <eliz@gnu.org>
1852
1853 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1854 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1855 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1856
1857 * coding.c (coding_alloc_by_realloc): Error out if destination
1858 will grow beyond MOST_POSITIVE_FIXNUM.
1859 (decode_coding_emacs_mule): Abort if there isn't enough place in
1860 charbuf for the composition carryover bytes. Reserve an extra
1861 space for up to 2 characters produced in a loop.
1862 (decode_coding_iso_2022): Abort if there isn't enough place in
1863 charbuf for the composition carryover bytes.
1864
18652011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1866
ae940cca
EZ
1867 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1868 aborting when %lld or %lll format is passed.
1869 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1870 %llo or %llx format is passed. (Bug#8545)
1871
03ab8921
EZ
1872 * window.c (window_scroll_line_based): Use a marker instead of
1873 simple variables to record original value of point. (Bug#7952)
1874
afda1437
EZ
1875 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1876 produced by %s or %c overflows available buffer space. (Bug#8545)
1877
f76dee0c
PE
18782011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1879
1880 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1881 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1882
fdc5744d
JB
18832011-04-28 Juanma Barranquero <lekktu@gmail.com>
1884
1885 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1886
638f053a
JB
18872011-04-28 Juanma Barranquero <lekktu@gmail.com>
1888
1889 * keyboard.c (Qdelayed_warnings_hook): Define.
1890 (command_loop_1): Run `delayed-warnings-hook'
1891 if Vdelayed_warnings_list is non-nil.
1892 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1893 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1894
d178f871
EZ
18952011-04-28 Eli Zaretskii <eliz@gnu.org>
1896
1897 * doprnt.c (doprnt): Don't return value smaller than the buffer
1898 size if the message was truncated. (Bug#8545).
1899
b124fd93
JB
19002011-04-28 Juanma Barranquero <lekktu@gmail.com>
1901
1902 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1903 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1904
e810457d
PE
19052011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1906
1907 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1908
ea51cceb
JB
19092011-04-27 Juanma Barranquero <lekktu@gmail.com>
1910
1911 * makefile.w32-in: Update dependencies.
1912
94dcfacf
EZ
19132011-04-27 Eli Zaretskii <eliz@gnu.org>
1914
1915 Improve `doprnt' and its usage. (Bug#8545)
1916 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1917 `format_end'. Remove support for %l as a conversion specifier.
1918 Don't use xrealloc. Improve diagnostics when the %l size modifier
1919 is used. Update the commentary.
1920
1921 * eval.c (verror): Simplify calculation of size_t.
1922
1923 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1924 messages.
1925
f61f41d7
PE
19262011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1927
1928 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1929 change.
1930
96fb4434
PE
19312011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1932
1933 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1934 This makes this file independent of the recent pseudovector change.
1935
671875da 19362011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1937
69e9b5a3
PE
1938 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1939
b5f869a7 1940 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1941 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1942 Remove unused local.
c8926152 1943 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1944
841a1577 1945 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1946 GCC 4.6.0 optimizes based on type-based alias analysis.
1947 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1948 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1949 != &v->size, and therefore "v->size = 1; b->size = 2; return
1950 v->size;" must therefore return 1. This assumption is incorrect
1951 for Emacs, since it type-puns struct Lisp_Vector * with many other
1952 types. To fix this problem, this patch adds a new type struct
f904488f 1953 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1954 and pseudovectors, and helps optimizing compilers not get fooled
1955 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1956 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1957 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1958 the size member.
eab3844f
PE
1959 (XSETPVECTYPE): Rewrite in terms of new macro.
1960 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1961 This is a bit clearer, and further avoids the possibility of
1962 undesirable aliasing.
1963 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1964 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1965 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1966 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1967 (ASIZE): Now uses header.size rather than size.
1968 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1969 to avoid the hassle of writing XVECTOR (foo)->header.size.
1970 (struct vectorlike_header): New type.
eab3844f
PE
1971 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1972 object, to help avoid aliasing.
1973 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1974 (SUBRP): Likewise, since Lisp_Subr is a special case.
1975 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1976 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1977 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1978 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1979 changed to be "header.size" and "header.next".
1980 * buffer.h (struct buffer): Likewise.
1981 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1982 * frame.h (struct frame): Likewise.
1983 * process.h (struct Lisp_Process): Likewise.
1984 * termhooks.h (struct terminal): Likewise.
1985 * window.c (struct save_window_data, struct saved_window): Likewise.
1986 * window.h (struct window): Likewise.
1987 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1988 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1989 * buffer.c (init_buffer_once): Likewise.
1990 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1991 special case.
1992 * process.c (Fformat_network_address): Use local var for size,
1993 for brevity.
1994
0df1eac5
PE
1995 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1996
847ab9d1 1997 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1998 * data.c (atof): Remove decl; no longer used or needed.
1999 (digit_to_number): Move to lread.c.
2000 (Fstring_to_number): Use new string_to_number function, to be
2001 consistent with how the Lisp reader treats infinities and NaNs.
2002 Do not assume that floating-point numbers represent EMACS_INT
2003 without losing information; this is not true on most 64-bit hosts.
2004 Avoid double-rounding errors, by insisting on integers when
2005 parsing non-base-10 numbers, as the documentation specifies.
2006 * lisp.h (string_to_number): New decl, replacing ...
2007 (isfloat_string): Remove.
bc0a5c13 2008 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2009 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2010 appears to have been a coding error. Similarly, do not accept
2011 strings like +-1e0 as floating point numbers. Do not report
2012 overflow for integer overflows unless the base is not 10 which
2013 means we have no simple and reliable way to continue.
2014 Break out the floating-point parsing into a new
2015 function string_to_number, so that Fstring_to_number parses
2016 floating point numbers consistently with the Lisp reader.
04f2d78b 2017 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2018 (E_CHAR, EXP_INT): Remove, replacing with ...
2019 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2020 (string_to_number): New function, replacing isfloat_string.
2021 This function checks for valid syntax and produces the resulting
2022 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2023 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2024 so that overflow for non-base-10 numbers is reported only when
2025 there's no portable and simple way to convert to floating point.
452f4150 2026
67769ffc
PE
2027 * textprop.c (set_text_properties_1): Rewrite for clarity,
2028 and to avoid GCC warning about integer overflow.
2029
c20db43f
PE
2030 * intervals.h (struct interval): Use EMACS_INT for members
2031 where EMACS_UINT might cause problems. See
2032 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2033 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2034 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2035 All uses changed.
37aa2f85
PE
2036 (offset_intervals): Tell GCC not to worry about length overflow
2037 when negating a negative length.
c20db43f 2038
2538aa2f
PE
2039 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2040 (overrun_check_free): Likewise.
2041
f2d3008d
PE
2042 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2043 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2044 word size.
2045
ec8df744
PE
2046 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2047 (gnutls_make_error): Rename local to avoid shadowing.
2048 (gnutls_emacs_global_deinit): ifdef out; not used.
2049 (Fgnutls_boot): Use const for pointer to readonly storage.
2050 Comment out unused local. Fix pointer signedness problems.
2051
640ee02d
PE
2052 * lread.c (openp): Don't stuff size_t into an 'int'.
2053 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2054 about possible signed overflow.
2055
6048fb2a
PE
2056 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2057 (GDK_KEY_g): Don't define if already defined.
2058 (xg_prepare_tooltip): Avoid pointer signedness problem.
2059 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2060
fa3c87e1
PE
2061 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2062 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2063
2172544b
PE
2064 * xfns.c (Fx_window_property): Simplify a bit,
2065 to make a bit faster and to avoid GCC 4.6.0 warning.
2066 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2067
9b821a21
PE
2068 * fns.c (internal_equal): Don't assume size_t fits in int.
2069
3c616cfa
PE
2070 * alloc.c (compact_small_strings): Tighten assertion a little.
2071
c2982e87
PE
2072 Replace pEd with more-general pI, and fix some printf arg casts.
2073 * lisp.h (pI): New macro, generalizing old pEd macro to other
2074 conversion specifiers. For example, use "...%"pI"d..." rather
2075 than "...%"pEd"...".
2076 (pEd): Remove. All uses replaced with similar uses of pI.
2077 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2078 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2079 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2080 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2081 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2082 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2083 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2084 64-bit hosts.
2085 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2086 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2087 * print.c (safe_debug_print, print_object): Likewise.
2088 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2089 to int.
6f04d126
PE
2090 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2091 avoiding the 0 flag, which is not portable.
c2982e87
PE
2092 * process.c (Fmake_network_process): Use pI to avoid cast.
2093 * region-cache.c (pp_cache): Likewise.
2094 * xdisp.c (decode_mode_spec): Likewise.
2095 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2096 behavior on 64-bit hosts with printf arg.
6f04d126 2097 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2098 (x_stop_queuing_selection_requests): Likewise.
2099 (x_get_window_property): Don't truncate byte count to an 'int'
2100 when tracing.
0b432f21 2101
5e073ec7
PE
2102 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2103 here, since it parses constructs like leading '-' and spaces,
2104 which are not wanted; and it overflows with large numbers.
2105 Instead, simply match F[0-9]+, which is what is wanted anyway.
2106
36372bf9
PE
2107 * alloc.c: Remove unportable assumptions about struct layout.
2108 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2109 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2110 (allocate_vectorlike, make_pure_vector): Use the new macros,
2111 plus offsetof, to remove unportable assumptions about struct layout.
2112 These assumptions hold on all porting targets that I know of, but
2113 they are not guaranteed, they're easy to remove, and removing them
2114 makes further changes easier.
2115
0b432f21
PE
2116 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2117 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2118 (string_overrun_cookie): Now const. Use initializers that
2119 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2120 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2121 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2122 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2123 multiple of sizeof (EMACS_INT); it need not be, if
2124 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2125 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2126
895009e1
JB
21272011-04-26 Juanma Barranquero <lekktu@gmail.com>
2128
2129 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2130
6a7a1b0b
TZ
21312011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2132
2133 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2134 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2135 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2136
841a1577 21372011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2138
2139 * lisp.h (Qdebug): List symbol.
895009e1 2140 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2141 * keyboard.c (debug-on-event): New variable.
2142 (handle_user_signal): Break into debugger when debug-on-event
2143 matches the current signal symbol.
2144
f2d3ba6f
DN
21452011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2146
2147 * alloc.c (check_sblock, check_string_bytes)
2148 (check_string_free_list): Convert to standard C.
2149
42ce4c63
TZ
21502011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2151
2152 * w32.c (emacs_gnutls_push): Fix typo.
2153
825cd63c
EZ
21542011-04-25 Eli Zaretskii <eliz@gnu.org>
2155
fb11d64d
EZ
2156 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2157 "cast to pointer from integer of different size".
2158
825cd63c
EZ
2159 Improve doprnt and its use in verror. (Bug#8545)
2160 * doprnt.c (doprnt): Document the set of format control sequences
2161 supported by the function. Use SAFE_ALLOCA instead of always
2162 using `alloca'.
2163
2164 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2165 is one byte too soon. Don't use xrealloc; instead xfree and
2166 xmalloc anew.
2167
e061a11b
TZ
21682011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2169
2170 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2171 callbacks stage.
2172
2173 * gnutls.c: Renamed global_initialized to
2174 gnutls_global_initialized. Added internals for the
2175 :verify-hostname-error, :verify-error, and :verify-flags
2176 parameters of `gnutls-boot' and documented those parameters in the
2177 docstring. Start callback support.
2178 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2179 unless a fatal error occured. Call gnutls_alert_send_appropriate
2180 on error. Return error code.
2181 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2182 (emacs_gnutls_read): Likewise.
2183 (Fgnutls_boot): Return handshake error code.
2184 (emacs_gnutls_handle_error): New function.
2185 (wsaerror_to_errno): Likewise.
2186
2187 * w32.h (emacs_gnutls_pull): Add prototype.
2188 (emacs_gnutls_push): Likewise.
2189
2190 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2191 (emacs_gnutls_push): Likewise.
2192
21932011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2194
2195 * process.c (wait_reading_process_output): Check if GnuTLS
2196 buffered some data internally if no FDs are set for TLS
2197 connections.
2198
2199 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2200 (LIBS): Link to USER_LIBS.
2201 ($(BLD)/gnutls.$(0)): New target.
2202
fa6996bc
EZ
22032011-04-24 Eli Zaretskii <eliz@gnu.org>
2204
eb35682e
EZ
2205 * xdisp.c (handle_single_display_spec): Rename the
2206 display_replaced_before_p argument into display_replaced_p, to
2207 make it consistent with the commentary. Fix typos in the
2208 commentary.
2209
e2ad650c
EZ
2210 * textprop.c (syms_of_textprop): Remove dead code.
2211 (copy_text_properties): Delete obsolete commentary about an
2212 interface that was deleted long ago. Fix typos in the description
2213 of arguments.
2214
1b2de274
EZ
2215 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2216 to changes in oldXMenu/XMenu.h from 2011-04-16.
2217 <menu_help_message, prev_menu_help_message>: Constify.
2218 (IT_menu_make_room): menu->help_text is now `const char **';
2219 adjust.
2220
2221 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2222 to changes in oldXMenu/XMenu.h from 2011-04-16.
2223 (struct XMenu): Declare `help_text' `const char **'.
2224
2225 * xfaces.c <Qunspecified>: Make extern again.
2226
2227 * syntax.c: Include sys/types.h before including regex.h, as
2228 required by Posix.
2229
762b15be
EZ
2230 * doc.c (get_doc_string): Improve the format passed to `error'.
2231
2232 * doprnt.c (doprnt): Improve commentary.
2233
2234 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2235
2236 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2237 them with etags.
2238
f1052e5d
EZ
2239 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2240 changes in globals.h immediately force recompilation.
762b15be
EZ
2241 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2242 $(CURDIR)/s/ms-w32.h.
2243 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2244
fa6996bc
EZ
2245 * character.c (Fchar_direction): Function deleted.
2246 (syms_of_character): Don't defsubr it.
2247 <char-direction-table>: Deleted.
2248
e6c3da20
EZ
22492011-04-23 Eli Zaretskii <eliz@gnu.org>
2250
2251 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2252 * doprnt.c: Include limits.h.
2253 (SIZE_MAX): New macro.
04f2d78b
CB
2254 (doprnt): Return a size_t value. 2nd arg is now size_t.
2255 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2256 Improve overflow protection. Support `l' modifier for integer
2257 conversions. Support %l conversion. Don't assume an EMACS_INT
2258 argument for integer conversions and for %c.
2259
2260 * lisp.h (doprnt): Restore prototype.
2261
2262 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2263 $(SRC)/character.h.
2264
2265 * Makefile.in (base_obj): Add back doprnt.o.
2266
2267 * deps.mk (doprnt.o): Add back prerequisites.
2268 (callint.o): Depend on character.h.
2269
2270 * eval.c (internal_lisp_condition_case): Include the handler
2271 representation in the error message.
2272 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2273 when breaking from the loop.
2274
2275 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2276
2277 * callint.c (Fcall_interactively): When displaying error message
2278 about invalid control letter, pass the character's codepoint, not
2279 a pointer to its multibyte form. Improve display of the character
2280 in octal and display also its hex code.
2281
2282 * character.c (char_string): Use %x to display the (unsigned)
2283 codepoint of an invalid character, to avoid displaying a bogus
2284 negative value.
2285
2286 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2287 `error', not SYMBOL_NAME itself.
2288
2289 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2290 character arguments to `error'.
2291
2292 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2293 to `error' in error message about FINAL_CHAR argument. Make sure
2294 FINAL_CHAR is a character, and use %c when it is passed as
2295 argument to `error'.
2296
4ffd0d6b 22972011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2298
2299 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2300
2301 * w32.c: Include <time.h>.
2302 (sys_localtime): New function.
2303
4ffd0d6b 23042011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2305
2306 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2307
4ffd0d6b 2308 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2309
4ffd0d6b 23102011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2311
4ffd0d6b
GM
2312 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2313 zombies (Bug#8467).
aac0c6e3 2314
04c56954
EZ
23152011-04-19 Eli Zaretskii <eliz@gnu.org>
2316
2317 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2318 gl_state.e_property when gl_state.object is Qt.
2319
2320 * insdel.c (make_gap_larger): Remove limitation of buffer size
2321 to <= INT_MAX.
2322
16a43933
CY
23232011-04-18 Chong Yidong <cyd@stupidchicken.com>
2324
2325 * xdisp.c (lookup_glyphless_char_display)
2326 (produce_glyphless_glyph): Handle cons cell entry in
2327 glyphless-char-display.
2328 (Vglyphless_char_display): Document it.
2329
2330 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2331 glyphless-char-display.
2332
4581706e
CY
23332011-04-17 Chong Yidong <cyd@stupidchicken.com>
2334
2335 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2336
2337 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2338
2339 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2340 definition for no-X builds.
2341
4887c6e2 23422011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2343
fd35b6f9
PE
2344 Static checks with GCC 4.6.0 and non-default toolkits.
2345
5c1ccb01
PE
2346 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2347
006c5daa
PE
2348 * process.c (keyboard_bit_set): Define only if SIGIO.
2349 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2350 (send_process): Repair possible setjmp clobbering.
2351
efc736d3
PE
2352 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2353
4e2fe2e6
PE
2354 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2355
f97334a2
PE
2356 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2357
4e75f29d
PE
2358 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2359 Define only if needed.
2360
90efadd1
PE
2361 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2362 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2363 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2364
3c647824
PE
2365 * dispextern.h (struct redisplay_interface): Rename param
2366 to avoid shadowing.
e264f262 2367 * termhooks.h (struct terminal): Likewise.
761383f4 2368 * xterm.c (xembed_send_message): Likewise.
3c647824 2369
b58c5c4a
PE
2370 * insdel.c (make_gap_smaller): Define only if
2371 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2372
cad59032
PE
2373 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2374 it.
2375
c339dc2e
PE
2376 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2377 so that we aren't warned about unused symbols.
2378
91a3e27b
PE
2379 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2380
399c71d3 2381 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2382
8ffc96f5
PE
2383 * xfns.c (x_real_positions): Mark locals as initialized.
2384
eef9bc79
PE
2385 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2386
098db9dd
PE
2387 * xterm.c: Fix problems found by static analysis with other toolkits.
2388 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2389 (x_dispatch_event): Declare static if USE_GTK, and
2390 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2391 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2392 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2393 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2394 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2395
eb18f6cc
PE
2396 * xmenu.c (menu_help_callback): Pointer type fixes.
2397 Use const pointers when pointing at readonly data. Avoid pointer
2398 signedness clashes.
2399 (FALSE): Remove unused macro.
2400 (update_frame_menubar): Remove unused decl.
2401
1fe72bf8
PE
2402 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2403
60d9e1db
PE
2404 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2405 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2406 (single_menu_item): Rename local to avoid shadowing.
2407
39261c26
PE
2408 * keyboard.c (make_lispy_event): Remove unused local var.
2409
018c5e19
PE
2410 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2411 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2412
63d2b86e
PE
2413 * bitmaps: Change bitmaps from unsigned char back to the X11
2414 compatible char. Avoid the old compiler warnings about
2415 out-of-range initializers by using, for example, '\xab' rather
2416 than 0xab.
2417
aefd87e1
PE
2418 * xgselect.c (xgselect_initialize): Check vs interface
2419 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2420
bf501fb9
PE
2421 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2422
e9829fdf
PE
2423 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2424 to read-only memory.
2425
1086c095
PE
2426 * fns.c (vector): Remove; this old hack is no longer needed.
2427
2baccd04 2428 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2429 Remove unused var.
dde42981 2430 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2431
72391843 2432 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2433
436c16df 2434 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2435 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2436 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2437
92bb796d 2438 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2439 (x_term_init): Remove local to avoid shadowing.
92bb796d 2440
764430a3 2441 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2442
2443 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2444 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2445
d1dfb56c
EZ
24462011-04-16 Eli Zaretskii <eliz@gnu.org>
2447
c4354cb4
EZ
2448 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2449
d1dfb56c
EZ
2450 Fix regex.c, syntax.c and friends for buffers > 2GB.
2451 * syntax.h (struct gl_state_s): Declare character position members
2452 EMACS_INT.
2453
2454 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2455
04f2d78b
CB
2456 * textprop.c (verify_interval_modification, interval_of):
2457 Declare arguments EMACS_INT.
d1dfb56c
EZ
2458
2459 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2460 EMACS_INT.
2461
2462 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2463
2464 * indent.c (Fvertical_motion): Local variable it_start is now
2465 EMACS_INT.
2466
2467 * regex.c (re_match, re_match_2, re_match_2_internal)
2468 (bcmp_translate, regcomp, regexec, print_double_string)
2469 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2470 (re_compile_pattern, re_exec): Declare arguments and local
2471 variables `size_t' and `ssize_t' and return values `regoff_t', as
2472 appropriate.
2473 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2474 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2475 <compile_stack_type>: `size' and `avail' are now `size_t'.
2476
2477 * regex.h <regoff_t>: Use ssize_t, not int.
2478 (re_search, re_search_2, re_match, re_match_2): Arguments that
2479 specify buffer/string position and length are now ssize_t and
2480 size_t. Return type is regoff_t.
2481
613052cd
BK
24822011-04-16 Ben Key <bkey76@gmail.com>
2483
2484 * nsfont.m: Fixed bugs in ns_get_family and
2485 ns_descriptor_to_entity that were caused by using free to
2486 deallocate memory blocks that were allocated by xmalloc (via
2487 xstrdup). This caused Emacs to crash when compiled with
2488 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2489 --enable-checking=xmallocoverrun). xfree is now used to
2490 deallocate these memory blocks.
2491
4170f62f 24922011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2493
71b41406
PE
2494 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2495
9587a89d
PE
2496 emacs_write: Accept and return EMACS_INT for sizes.
2497 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2498 et seq.
2499 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2500 Accept and return EMACS_INT.
2501 (emacs_gnutls_write): Return the number of bytes written on
2502 partial writes.
2503 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2504 (emacs_read, emacs_write): Remove check for negative size, as the
2505 Emacs source code has been audited now.
9587a89d
PE
2506 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2507 (emacs_read, emacs_write): Use it.
273a5f82
PE
2508 * process.c (send_process): Adjust to the new signatures of
2509 emacs_write and emacs_gnutls_write. Do not attempt to store
2510 a byte offset into an 'int'; it might overflow.
9587a89d 2511 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2512
3e047f51
PE
2513 * sound.c: Don't assume sizes fit in 'int'.
2514 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2515 Return EMACS_INT, not int.
3e047f51 2516 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2517 Accept EMACS_INT, not int.
2518 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2519 record read return values.
2520
cc39a9db
BK
25212011-04-15 Ben Key <bkey76@gmail.com>
2522
c9d0ec6d
JB
2523 * keyboard.c (Qundefined): Don't declare static since it is used
2524 in nsfns.m.
2525 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2526 static since they are used in nsfont.m.
cc39a9db 2527
6c60eb9f
SM
25282011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2529
2530 * process.c (Qprocessp): Don't declare static.
2531 * lisp.h (Qprocessp): Declare again.
2532
7990b61a
JB
25332011-04-15 Juanma Barranquero <lekktu@gmail.com>
2534
2535 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2536
5d4cb038
PE
25372011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2538
8bd7b830 2539 Improve C-level modularity by making more things 'static'.
cd64ea1d 2540
e3b27b31
PE
2541 Don't publish debugger-only interfaces to other modules.
2542 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2543 (verify_bytepos, count_markers): Move decls to the only modules
2544 that need them.
2545 * region-cache.h (pp_cache): Likewise.
2546 * window.h (check_all_windows): Likewise.
2547 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2548
5d4cb038
PE
2549 * sysdep.c (croak): Now static, if
2550 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2551 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2552
2553 * alloc.c (refill_memory_reserve): Now static if
2554 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2555 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2556
e87b6180
PE
2557 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2558 Define only if USE_LUCID.
2559
ac64929e
PE
2560 * xrdb.c (x_customization_string, x_rm_string): Now static.
2561
6f37259d
PE
2562 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2563 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2564
1683e3ab
PE
2565 * xdisp.c (draw_row_with_mouse_face): Now static.
2566 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2567
de9c2632
PE
2568 * window.h (check_all_windows): Mark externally visible.
2569
2b96acb7
PE
2570 * window.c (window_deletion_count): Now static.
2571
2572 * undo.c: Make symbols static if they're not exported.
2573 (last_undo_buffer, last_boundary_position, pending_boundary):
2574 Now static.
2575
50436f33
PE
2576 * textprop.c (interval_insert_behind_hooks): Now static.
2577 (interval_insert_in_front_hooks): Likewise.
2578
64520e5c
PE
2579 * term.c: Make symbols static if they're not exported.
2580 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2581 (max_frame_lines, tty_set_terminal_modes):
2582 (tty_reset_terminal_modes, tty_turn_off_highlight):
2583 (get_tty_terminal): Now static.
2584 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2585 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2586 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2587 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2588 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2589
1fa53021
PE
2590 * sysdep.c: Make symbols static if they're not exported.
2591 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2592 Now static.
2593 (sigprocmask_set, full_mask): Remove; unused.
2594 (wait_debugging): Mark as visible.
2595 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2596 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2597
d4b43b22
PE
2598 * syntax.c (syntax_temp): Define only if !__GNUC__.
2599
b7c513d0
PE
2600 * sound.c (current_sound_device, current_sound): Now static.
2601
989b29ad
PE
2602 * search.c (searchbufs, searchbuf_head): Now static.
2603
13a55a78
PE
2604 * scroll.c (scroll_cost): Remove; unused.
2605 * dispextern.h (scroll_cost): Remove decl.
2606
de68a1fc
PE
2607 * region-cache.h (pp_cache): Mark as externally visible.
2608
40ccffa6
PE
2609 * process.c: Make symbols static if they're not exported.
2610 (process_tick, update_tick, create_process, chan_process):
2611 (Vprocess_alist, proc_buffered_char, datagram_access):
2612 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2613 (deactivate_process): Mark defn as static, as well as decl.
2614 * lisp.h (create_process): Remove decl.
2615 * process.h (chan_process, Vprocess_alist): Remove decls.
2616
ad64fc97
PE
2617 * print.c: Make symbols static if they're not exported.
2618 (print_depth, new_backquote_output, being_printed, print_buffer):
2619 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2620 (print_interval, print_number_index, initial_stderr_stream):
2621 Now static.
2622 * lisp.h (Fprinc): Remove decl.
2623 (debug_output_compilation_hack): Mark as externally visible.
2624
adddb265
PE
2625 * sysdep.c (croak): Move decl from here to syssignal.h.
2626 * syssignal.h (croak): Put it here, so the API can be checked when
2627 'croak' is called from dissociate_if_controlling_tty.
2628
1717ede2
PE
2629 * minibuf.c: Make symbols static if they're not exported.
2630 (minibuf_save_list, choose_minibuf_frame): Now static.
2631 * lisp.h (choose_minibuf_frame): Remove decl.
2632
fa5fb2bc
PE
2633 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2634
1e3890d1
PE
2635 * lread.c: Make symbols static if they're not exported.
2636 (read_objects, initial_obarray, oblookup_last_bucket_number):
2637 Now static.
2638 (make_symbol): Remove; unused.
2639 * lisp.h (initial_obarray, make_symbol): Remove decls.
2640
8a1414fa
PE
2641 * keyboard.c: Make symbols static if they're not exported.
2642 (single_kboard, recent_keys_index, total_keys, recent_keys):
2643 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2644 (this_single_command_key_start, echoing, last_auto_save):
2645 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2646 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2647 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2648 (Vlispy_mouse_stem, double_click_count):
2649 Now static.
2650 (force_auto_save_soon): Define only if SIGDANGER.
2651 (ignore_mouse_drag_p): Now static if
2652 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2653 (print_help): Remove; unused.
2654 (stop_character, last_timer_event): Mark as externally visible.
2655 * keyboard.h (ignore_mouse_drag_p): Declare only if
2656 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2657 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2658 * lisp.h (echoing): Remove decl.
2659 (force_auto_save_soon): Declare only if SIGDANGER.
2660 * xdisp.c (redisplay_window): Simplify code, to make it more
2661 obvious that ignore_mouse_drag_p is not accessed if !defined
2662 USE_GTK && !defined HAVE_NS.
2663
93ea6e8f
PE
2664 * intervals.c: Make symbols static if they're not exported.
2665 (merge_properties_sticky, merge_interval_right, delete_interval):
2666 Now static.
2667 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2668
77382fcc
PE
2669 * insdel.c: Make symbols static if they're not exported.
2670 However, leave prepare_to_modify_buffer alone. It's never
2671 called from outside this function, but that appears to be a bug.
2672 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2673 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2674 (adjust_after_replace_noundo): Remove; unused.
2675 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2676 (signal_before_change): Remove decls.
77382fcc 2677
9306c32e
PE
2678 * indent.c (val_compute_motion, val_vmotion): Now static.
2679
cd44d2eb
PE
2680 * image.c: Make symbols static if they're not exported.
2681 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2682 if USE_GTK.
2683 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2684 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2685
ad9a7a06
PE
2686 * fringe.c (standard_bitmaps): Now static.
2687 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2688
81626931
PE
2689 * frame.c: Make symbols static if they're not exported.
2690 (x_report_frame_params, make_terminal_frame): Now static.
2691 (get_frame_param): Now static, unless HAVE_NS.
2692 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2693 (x_get_resource_string): Remove; not used.
2694 * frame.h (make_terminal_frame, x_report_frame_params):
2695 (x_get_resource_string); Remove decls.
2696 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2697 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2698
239f9db9
PE
2699 * font.c, fontset.c: Make symbols static if they're not exported.
2700 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2701 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2702 * font.c (font_close_object): Now static.
2703 * font.h (font_close_object): Remove.
2704 * fontset.c (FONTSET_OBJLIST): Remove.
2705 (free_realized_fontset) #if-0 the body, which does nothing.
2706 (face_suitable_for_char_p): #if-0, as it's never called.
2707 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2708 * xfaces.c (face_at_string_position):
2709 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2710 since 0 is always ASCII.
2711
dfcf3579
PE
2712 * fns.c (weak_hash_tables): Now static.
2713
5045092b
PE
2714 * fileio.c: Make symbols static if they're not exported.
2715 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2716 (Vwrite_region_annotation_buffers): Now static.
2717
57a96f5c
PE
2718 * eval.c: Make symbols static if they're not exported.
2719 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2720 * lisp.h (backtrace_list): Remove decl.
2721
35f08c38
PE
2722 * emacs.c: Make symbols static if they're not exported.
2723 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2724 (fatal_error_code, fatal_error_signal_hook, standard_args):
2725 Now static.
2726 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2727 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2728 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2729 * lisp.h (fatal_error_signal_hook): Remove decl.
2730 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2731
f44bd759
PE
2732 * editfns.c: Move a (normally-unused) function to its only use.
2733 * editfns.c, lisp.h (get_operating_system_release): Remove.
2734 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2735 worth the hassle of breaking this out.
2736
b532497d
PE
2737 * xterm.c: Make symbols static if they're not exported.
2738 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2739 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2740 (x_destroy_window, x_delete_display):
2741 Now static.
2742 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2743 (x_mouse_leave): Remove; unused.
2744 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2745 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2746 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2747 Remove decls.
2748 (x_mouse_leave): Declare only if WINDOWSNT.
2749 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2750 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2751 USE_X_TOOLKIT.
2752
1675728f
PE
2753 * ftxfont.c: Make symbols static if they're not exported.
2754 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2755 HAVE_FREETYPE.
2756 * font.h (ftxfont_driver): Likewise.
2757
e4cebfca
PE
2758 * xfns.c: Make symbols static if they're not exported.
2759 (x_last_font_name, x_display_info_for_name):
2760 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2761 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2762 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2763 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2764 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2765 (last_show_tip_args): Now static.
2766 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2767 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2768 (x_screen_planes): Remove; unused.
2769 * dispextern.h (x_screen_planes): Remove decl.
2770
5bf46f05
PE
2771 * dispnew.c: Make symbols static if they're not exported.
2772 * dispextern.h (redraw_garbaged_frames, scrolling):
2773 (increment_row_positions): Remove.
2774 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2775 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2776 Now static.
2777 (redraw_garbaged_frames): Remove; unused.
2778
435f4c28
PE
2779 * xfaces.c: Make symbols static if they're not exported.
2780 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2781 Remove decls.
2782 * xterm.h (defined_color): Remove decls.
2783 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2784 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2785 (menu_face_changed_default, defined_color, free_realized_face):
2786 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2787 (ascii_face_of_lisp_face): Remove; unused.
2788
8524aef3
PE
2789 * xdisp.c: Make symbols static if they're not exported.
2790 * dispextern.h (scratch_glyph_row, window_box_edges):
2791 (glyph_to_pixel_coords, set_cursor_from_row):
2792 (get_next_display_element, set_iterator_to_next):
2793 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2794 (show_mouse_face): Remove decls
2795 * frame.h (message_buf_print): Likewise.
2796 * lisp.h (pop_message, set_message, check_point_in_composition):
2797 Likewise.
2798 * xterm.h (set_vertical_scroll_bar): Likewise.
2799 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2800 (message_buf_print, scratch_glyph_row, displayed_buffer):
2801 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2802 (get_next_display_element, show_mouse_face, window_box_edges):
2803 (frame_to_window_pixel_xy, check_point_in_composition):
2804 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2805 (glyph_to_pixel_coords): Remove; unused.
2806
16390cd2
PE
2807 * dired.c (file_name_completion): Now static.
2808
2809 * dbusbind.c (xd_in_read_queued_messages): Now static.
2810
a25f4dfa
PE
2811 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2812 * data.c (circular_list_error): Remove.
2813
14a9c8df
PE
2814 * commands.h (last_point_position, last_point_position_buffer):
2815 (last_point_position_window): Remove decls.
2816 * keyboard.c: Make these variables static.
2817
04f2d78b
CB
2818 * coding.h (coding, code_convert_region, encode_coding_gap):
2819 Remove decls.
74ab6df5
PE
2820 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2821 (iso_code_class, detect_coding, code_convert_region): Now static.
2822 (encode_coding_gap): Remove; unused.
2823
38dfbee1
PE
2824 * chartab.c (chartab_chars, chartab_bits): Now static.
2825
a2cb4e63
PE
2826 * charset.h (charset_iso_8859_1): Remove decl.
2827 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2828 Now static.
2829
127198fd
PE
2830 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2831 * ccl.c (Vccl_program_table): Now static.
2832 (check_ccl_update): Remove; unused.
2833
d85b608f
PE
2834 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2835 * category.h: ... from here.
2836 * category.c (check_category_table, set_category_set): Now static.
2837
31cd66f3
PE
2838 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2839 * lisp.h: Remove these decls.
2840
c358e587
PE
2841 * buffer.c (buffer_count): Remove unused var.
2842
e78aecca
PE
2843 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2844 so that it's not optimized away.
2845 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2846 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2847 exported only to the debugger.
2848
e192d7d3 2849 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2850 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2851
92470028
PE
2852 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2853 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2854 was inaccessible from Lisp.
2855 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2856 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2857
244ed907
PE
2858 alloc.c: Import and export fewer symbols, and remove unused items.
2859 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2860 is defined.
2861 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2862 it's not optimized away by whole-program optimization.
2863 (message_enable_multibyte, free_misc): Remove.
2864 (catchlist, handlerlist, mark_backtrace):
2865 Declare only if BYTE_MARK_STACK.
2866 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2867 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2868 (message_enable_multibyte): Remove decl.
2869 (free_misc, interval_free_list, float_block, float_block_index):
2870 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2871 (cons_free_list, last_marked_index):
2872 Now static.
2873 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2874 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2875 (mark_backtrace): Define only if BYTE_MARK_STACK.
2876 * xdisp.c (message_enable_multibyte): Now static.
2877
61c2b50e 2878 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2879 This makes it easier for human readers (and static analyzers)
2880 to see whether these variables are used from other modules.
2881 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2882 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2883 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2884 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2885 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2886 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2887 * xmenu.c, xselect.c:
2888 Declare Q* vars static if they are not used in other modules.
2889 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2890 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2891 Remove decls of unexported vars.
2892 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2893
95c82688
PE
2894 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2895
16a97296
PE
2896 Make Emacs functions such as Fatom 'static' by default.
2897 This makes it easier for human readers (and static analyzers)
2898 to see whether these functions can be called from other modules.
2899 DEFUN now defines a static function. To make the function external
2900 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2901 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2902 (Finit_image_library):
16a97296
PE
2903 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2904 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2905 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2906 Remove decls, since these functions are now static.
2907 (Funintern, Fget_internal_run_time): New decls, since these functions
2908 were already external.
95c82688 2909
16a97296
PE
2910 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2911 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2912 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2913 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2914 * keyboard.c, keymap.c, lread.c:
2915 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2916 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2917 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2918 Mark functions with DEFUE instead of DEFUN,
2919 if they are used in other modules.
2920 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2921 decls for now-static functions.
2922 * buffer.h (Fdelete_overlay): Remove decl.
2923 * callproc.c (Fgetenv_internal): Mark as internal.
2924 * composite.c (Fremove_list_of_text_properties): Remove decl.
2925 (Fcomposition_get_gstring): New forward static decl.
2926 * composite.h (Fcomposite_get_gstring): Remove decl.
2927 * dired.c (Ffile_attributes): New forward static decl.
2928 * doc.c (Fdocumntation_property): New forward static decl.
2929 * eval.c (Ffetch_bytecode): New forward static decl.
2930 (Funintern): Remove extern decl; now in .h file where it belongs.
2931 * fileio.c (Fmake_symbolic_link): New forward static decl.
2932 * image.c (Finit_image_library): New forward static decl.
2933 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2934 * intervals.h (Fprevious_property_change):
2935 (Fremove_list_of_text_properties): Remove decls.
2936 * keyboard.c (Fthis_command_keys): Remove decl.
2937 (Fcommand_execute): New forward static decl.
2938 * keymap.c (Flookup_key): New forward static decl.
2939 (Fcopy_keymap): Now static.
2940 * keymap.h (Flookup_key): Remove decl.
2941 * process.c (Fget_process): New forward static decl.
2942 (Fprocess_datagram_address): Mark as internal.
2943 * syntax.c (Fsyntax_table_p): New forward static decl.
2944 (skip_chars): Remove duplicate decl.
2945 * textprop.c (Fprevious_property_change): New forward static decl.
2946 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2947 Now internal.
2948 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2949 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2950
785bbd42
PE
2951 * editfns.c (Fformat): Remove unreachable code.
2952
8b913b57
AS
29532011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2954
2955 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2956 change. (Bug#8496)
2957
a6744a35
EZ
29582011-04-13 Eli Zaretskii <eliz@gnu.org>
2959
2960 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2961 when at ZV. (Bug#8487)
2962
e7974947
AS
29632011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2964
baad03f0
AS
2965 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2966 (Bug#8437)
2967 * keyboard.c (parse_tool_bar_item): Likewise.
2968 * sound.c (sound_cleanup, alsa_close): Likewise.
2969 * termcap.c (tgetent): Likewise.
2970 * xfns.c (x_default_font_parameter): Likewise.
2971 * xsettings.c (read_and_apply_settings): Likewise.
2972
e7974947
AS
2973 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2974 (overrun_check_free): Protoize.
2975
28272684
PE
29762011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2977
2978 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2979 since callers should never pass a negative size.
2980 Change the signature to match that of plain 'read' and 'write'; see
2981 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2982 * lisp.h: Update prototypes of emacs_write and emacs_read.
2983
11997c76
EZ
29842011-04-11 Eli Zaretskii <eliz@gnu.org>
2985
2986 * xdisp.c (redisplay_window): Don't try to determine the character
2987 position of the scroll margin if the window start point w->startp
e896f03c 2988 is outside the buffer's accessible region. (Bug#8468)
11997c76 2989
8a2cbd72
EZ
29902011-04-10 Eli Zaretskii <eliz@gnu.org>
2991
2992 Fix write-region and its subroutines for buffers > 2GB.
2993 * fileio.c (a_write, e_write): Modify declaration of arguments and
2994 local variables to support buffers larger than 2GB.
2995 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2996
2997 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2998 argument, local variables, and return value.
2999
3000 * lisp.h: Update prototypes of emacs_write and emacs_read.
3001
3002 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3003
4073e537 30042011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3005
1ebfdcb6
PE
3006 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3007
b2ded58d
PE
3008 Fix more problems found by GCC 4.6.0's static checks.
3009
7d66342c
PE
3010 * xdisp.c (vmessage): Use a better test for character truncation.
3011
bbf47d44
PE
3012 * charset.c (load_charset_map): <, not <=, for optimization,
3013 and to avoid potential problems with integer overflow.
9248994d 3014 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3015 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3016 * editfns.c (Fformat): Likewise.
1e69125e 3017 * syntax.c (skip_chars): Likewise.
3befa583 3018
e3019616
PE
3019 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3020 This also lets GCC 4.6.0 generate slightly better loop code.
3021
becfa255
PE
3022 * callint.c (Fcall_interactively): <, not <=, for optimization.
3023 (Fcall_interactively): Count the number of arguments produced,
3024 not the number of arguments given. This is simpler and lets GCC
3025 4.6.0 generate slightly better code.
3026
dae0cd48
PE
3027 * ftfont.c: Distingish more carefully between FcChar8 and char.
3028 The previous code passed unsigned char * to a functions like
3029 strlen and xstrcasecmp that expect char *, which does not
3030 conform to the C standard.
3031 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3032 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3033 char * when the C standard requires it.
3034
76032d70
PE
3035 * keyboard.c (read_char): Remove unused var.
3036
eb3f1cc8
PE
3037 * eval.c: Port to Windows vsnprintf (Bug#8435).
3038 Include <limits.h>.
3039 (SIZE_MAX): Define if the headers do not.
3040 (verror): Do not give up if vsnprintf returns a negative count.
3041 Instead, grow the buffer. This ports to Windows vsnprintf, which
3042 does not conform to C99. Problem reported by Eli Zaretskii.
3043 Also, simplify the allocation scheme, by avoiding the need for
3044 calling realloc, and removing the ALLOCATED variable.
3045
70476b54
PE
3046 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3047
12020a9e
PE
3048 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3049 But keep the doprint source code for now, as we might revamp it
3050 and use it again (Bug#8435).
ea6c7ae6
PE
3051 * lisp.h (doprnt): Remove.
3052 * Makefile.in (base_obj): Remove doprnt.o.
3053 * deps.mk (doprnt.o): Remove.
3054
5fdb398c
PE
3055 error: Print 32- and 64-bit integers portably (Bug#8435).
3056 Without this change, on typical 64-bit hosts error ("...%d...", N)
3057 was used to print both 32- and 64-bit integers N, which relied on
3058 undefined behavior.
3059 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3060 New macro.
3061 * lisp.h (error, verror): Mark as printf-like functions.
3062 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3063 Report overflow in size calculations when allocating printf buffer.
3064 Do not truncate output string at its first null byte.
3065 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3066 Truncate the output at a character boundary, since vsnprintf does not
3067 do that.
3068 * charset.c (check_iso_charset_parameter): Convert internal
3069 character to string before calling 'error', since %c now has the
3070 printf meaning.
3071 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3072 overflow when computing char to be passed to 'error'. Do not
3073 pass Lisp_Object to 'error'; pass the integer instead.
3074 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3075 formatted with plain %d.
3076
b189fa66
PE
3077 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3078
bff87ef0
PE
3079 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3080
7e2cac20
PE
3081 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3082
ce4d90b5
PE
3083 * xterm.c (x_catch_errors): Remove duplicate declaration.
3084
266c9547
PE
3085 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3086
79c49ad2
PE
3087 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3088
368f4090
JM
30892011-04-10 Jim Meyering <meyering@redhat.com>
3090
3091 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3092 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3093 return ssize_t not "int", and use size_t as the buffer length.
3094 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3095 * gnutls.h: Update declarations.
3096 * process.c (read_process_output): Use ssize_t, to match.
3097 (send_process): Likewise.
3098
a32d4040
CY
30992011-04-09 Chong Yidong <cyd@stupidchicken.com>
3100
3101 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3102
8546720e 31032011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3104
04f2d78b
CB
3105 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3106 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3107
8546720e
GM
3108 * xterm.c (handle_one_xevent):
3109 * xmenu.c (create_and_show_popup_menu):
3110 * xselect.c (x_decline_selection_request)
3111 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3112
0a2f5c1a 31132011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3114
3115 Fix some uses of `int' instead of EMACS_INT.
3116 * search.c (string_match_1, fast_string_match)
3117 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3118 (scan_buffer, find_next_newline_no_quit)
3119 (find_before_next_newline, search_command, Freplace_match)
3120 (Fmatch_data): Make some `int' variables be EMACS_INT.
3121
3122 * xdisp.c (display_count_lines): 3rd argument and return value now
3123 EMACS_INT. All callers changed.
3124 (pint2hrstr): Last argument is now EMACS_INT.
3125
3126 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3127 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3128 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3129 (decode_coding_utf_16, decode_coding_emacs_mule)
3130 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3131 (decode_coding_ccl, decode_coding_charset)
3132 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3133 (decode_coding_iso_2022, decode_coding_emacs_mule)
3134 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3135 <char_offset, last_offset>: Declare EMACS_INT.
3136 (encode_coding_utf_8, encode_coding_utf_16)
3137 (encode_coding_emacs_mule, encode_invocation_designation)
3138 (encode_designation_at_bol, encode_coding_iso_2022)
3139 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3140 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3141 Declare EMACS_INT.
3142 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3143 (encode_invocation_designation): Last argument P_NCHARS is now
3144 EMACS_INT.
3145 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3146 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3147
3148 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3149 All users changed.
3150
3151 * ccl.c (Fccl_execute_on_string): Declare some variables
3152 EMACS_INT.
3153
8546720e 31542011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3155
3156 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3157
4e19a977
CS
31582011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3159
3160 * process.c (Fformat_network_address): Doc fix.
3161
87302331
R
31622011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3163
3164 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3165
cbb59342
CY
31662011-04-08 Chong Yidong <cyd@stupidchicken.com>
3167
3168 * keyboard.c (read_char): Call Lisp function help-form-show,
3169 instead of using internal_with_output_to_temp_buffer.
3170 (Qhelp_form_show): New var.
e0d38eeb 3171 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3172
3173 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3174
3175 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3176
e67a13ab
CY
31772011-04-06 Chong Yidong <cyd@stupidchicken.com>
3178
04f2d78b
CB
3179 * process.c (Flist_processes): Remove to Lisp.
3180 (list_processes_1): Delete.
e67a13ab 3181
973f782d
EZ
31822011-04-06 Eli Zaretskii <eliz@gnu.org>
3183
7c106b1e
EZ
3184 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3185
973f782d
EZ
3186 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3187
41cf7d1a 31882011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3189
ca23cc88
PE
3190 Fix more problems found by GCC 4.6.0's static checks.
3191
f390e2d5
PE
3192 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3193
42eea0d0
PE
3194 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3195
b69769da 3196 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3197
f9541e84
PE
3198 * xdisp.c (vmessage): Mark as a printf-like function.
3199
13841b55
PE
3200 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3201
c136c10f
PE
3202 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3203
5e2d4a30
PE
3204 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3205 printf-like functions.
3206 (tiff_load): Add casts to remove these marks before passing them
3207 to system-supplied API.
3208
583f48b9
PE
3209 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3210
b25d760e
PE
3211 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3212 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3213 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3214 directly, rather than having caller test rule sign. This avoids
3215 some unnecessary tests.
3216 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3217 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3218 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3219
bc7b6697 3220 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3221 (xfont_open): Avoid unnecessary tests.
bc7b6697 3222
27ccc379
PE
3223 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3224
dcd5c89a
PE
3225 * composite.h, composite.c (composition_gstring_put_cache):
3226 Use EMACS_INT, not int, for length.
3227
b13a45c6
PE
3228 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3229 breaking out part of COMPOSITION_DECODE_RULE.
3230 (COMPOSITION_DECODE_RULE): Use it.
3231 * composite.c (get_composition_id): Remove unused local vars,
3232 by using the new macro.
3233
1e792e4d
PE
3234 * textprop.c (set_text_properties_1): Change while to do-while,
3235 since the condition is always true at first.
3236
dc6c6455 3237 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3238 (interval_deletion_adjustment): Return unsigned value.
3239 All uses changed.
dc6c6455 3240
aba7731a
PE
3241 * process.c (list_processes_1, create_pty, read_process_output):
3242 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3243 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3244 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3245 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3246 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3247
fdfc4bf3
PE
3248 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3249
fca8fe46 3250 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3251 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3252
06a0259a 3253 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3254 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3255 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3256
e7b9e80f
PE
3257 * print.c (print_error_message): Avoid int overflow.
3258
56201685
PE
3259 * font.c (font_list_entities): Redo for clarity,
3260 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3261
78834453 3262 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3263 (font_score): Avoid potential overflow in diff calculation.
78834453 3264
0bc0b309 3265 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3266 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3267
e610eaca
PE
3268 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3269
b895abce
PE
3270 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3271 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3272 can always succeed if overflow has undefined behavior.
3273
1f1d9321 3274 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3275 (wordify): Omit three unnecessary tests.
1f1d9321 3276
c59478bc
PE
3277 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3278 All callers changed. This avoids the need for an unused var.
3279
79b73827
PE
3280 * casefiddle.c (casify_region): Remove var that is set but not used.
3281
a4db5dfe
PE
3282 * dired.c (file_name_completion): Remove var that is set but not used.
3283
43aae36e
PE
3284 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3285
2a47c44d 3286 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3287 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3288
a37c69bf
PE
3289 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3290 Check for integer overflow on size calculations.
3291
328ab8e7
PE
3292 * buffer.c (Fprevious_overlay_change): Remove var that is set
3293 but not used.
3294
e5a2a5cb
PE
3295 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3296 Remove vars that are set but not used.
8d84a6eb 3297 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3298 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3299
a60e5f68
PE
3300 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3301
f661cb61 3302 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3303 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3304
f0397f5a
PE
3305 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3306 that are set but not used.
3307
8664db06 3308 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3309 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3310
6abdaa4a
PE
3311 * xselect.c (x_get_local_selection, x_handle_property_notify):
3312 Remove vars that are set but not used.
3313
0ce7538d 3314 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3315 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3316
9ae848fc
PE
3317 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3318 Remove var that is set but not used.
0b918413
PE
3319 (scroll_bar_windows_size): Now size_t, not int.
3320 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3321 Check for overflow.
9ae848fc 3322
a5a62657
PE
3323 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3324 (map_tty_color) [!defined MSDOS]: Likewise.
3325
5c5cdd39
PE
3326 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3327
66ebf983
PE
3328 * coding.c: Remove vars that are set but not used.
3329 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3330 All callers changed.
3331 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3332 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3333 (decode_coding_charset): Remove vars that are set but not used.
3334
1be4d761
PE
3335 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3336 that is set but not used.
3337
47553fa8
PE
3338 * print.c (print_object): Remove var that is set but not used.
3339
1f7196bf 3340 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3341 The gnulib version avoids calling malloc in the usual case,
3342 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3343 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3344 * filelock.c (current_lock_owner): Likewise.
3345 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3346 * sysdep.c: Include allocator.h, careadlinkat.h.
3347 (emacs_no_realloc_allocator): New static constant.
3348 (emacs_readlink): New function.
fdb61804
PE
3349 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3350 ../lib/careadlinkat.h.
d1fdcab7 3351
f84c17c7
SM
33522011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3353
3354 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3355 first non-nil return value).
3356
ef3862ad
JD
33572011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3358
3359 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3360 if not defined (Bug#8403).
3361
376a7006
JB
33622011-04-02 Juanma Barranquero <lekktu@gmail.com>
3363
3364 * xdisp.c (display_count_lines): Remove parameter `start',
3365 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3366 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3367 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3368 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3369 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3370 and thereabouts. All callers changed.
3371 (get_per_char_metric): Remove parameter `f', unused since
3372 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3373
6ca3801d
JM
33742011-04-02 Jim Meyering <meyering@redhat.com>
3375
3376 do not dereference NULL upon failed strdup
3377 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3378 (ns_get_family): Likewise.
3379
d8e2b5ba
JB
33802011-04-02 Juanma Barranquero <lekktu@gmail.com>
3381
3382 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3383
8c74fcbd
JD
33842011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3385
3386 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3387 later (Bug#8403).
3388
7200d79c
SM
33892011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3390
03408648 3391 Add lexical binding.
7200d79c 3392
03408648
SM
3393 * window.c (Ftemp_output_buffer_show): New fun.
3394 (Fsave_window_excursion):
3395 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3396
3397 * lread.c (lisp_file_lexically_bound_p): New function.
3398 (Fload): Bind Qlexical_binding.
3399 (readevalloop): Remove `evalfun' arg.
3400 Bind Qinternal_interpreter_environment.
3401 (Feval_buffer): Bind Qlexical_binding.
3402 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3403 Mark as dynamic.
3404 (syms_of_lread): Declare `lexical-binding'.
3405
3406 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3407
3408 * keyboard.c (eval_dyn): New fun.
3409 (menu_item_eval_property): Use it.
ca105506
SM
3410
3411 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3412
03408648
SM
3413 * fns.c (concat, mapcar1): Accept byte-code-functions.
3414
3415 * eval.c (Fsetq): Handle lexical vars.
3416 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3417 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3418 (FletX, Flet): Obey lexical binding.
3419 (Fcommandp): Handle closures.
3420 (Feval): New `lexical' arg.
3421 (eval_sub): New function extracted from Feval. Use it almost
3422 everywhere where Feval was used. Look up vars in lexical env.
3423 Handle closures.
3424 (Ffunctionp): Move from subr.el.
3425 (Ffuncall): Handle closures.
3426 (apply_lambda): Remove `eval_flags'.
3427 (funcall_lambda): Handle closures and new byte-code-functions.
3428 (Fspecial_variable_p): New function.
3429 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3430 but without exporting it to Lisp.
23aba0ea 3431
23aba0ea 3432 * doc.c (Fdocumentation, store_function_docstring):
03408648 3433 * data.c (Finteractive_form): Handle closures.
23aba0ea 3434
03408648
SM
3435 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3436 interactive spec.
ba83908c 3437
04f2d78b
CB
3438 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3439 New byte-codes.
03408648
SM
3440 (exec_byte_code): New function extracted from Fbyte_code to handle new
3441 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3442
03408648 3443 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3444
03408648 3445 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3446
e2abce01
JB
34472011-03-31 Juanma Barranquero <lekktu@gmail.com>
3448
3449 * xdisp.c (redisplay_internal): Fix prototype.
3450
63696a73 34512011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3452
63696a73 3453 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3454 (try_scrolling): Use it when setting scroll_limit.
3455 Limit scrolling to 100 screen lines.
63696a73
EZ
3456 (redisplay_window): Even when falling back on "recentering",
3457 position point in the window according to scroll-conservatively,
3458 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3459
3460 (try_scrolling): When point is above the window, allow searching
3461 as far as scroll_max, or one screenful, to compute vertical
3462 distance from PT to the scroll margin position. This prevents
3463 try_scrolling from unnecessarily failing when
3464 scroll-conservatively is set to a value slightly larger than the
3465 window height. Clean up the case of PT below the margin at bottom
3466 of window: scroll_max can no longer be INT_MAX. When aggressive
3467 scrolling is in use, don't let point enter the opposite scroll
3468 margin as result of the scroll.
3469 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3470 threshold of 100 lines for never-recentering scrolling.
3471
e4cc2dfc
JB
34722011-03-31 Juanma Barranquero <lekktu@gmail.com>
3473
3474 * dispextern.h (move_it_by_lines):
3475 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3476 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3477 (message_log_check_duplicate): Remove parameters `prev_bol' and
3478 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3479 (redisplay_internal): Remove parameter `preserve_echo_area',
3480 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3481
3482 * indent.c (Fvertical_motion):
3483 * window.c (window_scroll_pixel_based, Frecenter):
3484 Don't pass `need_y_p' to `move_it_by_lines'.
3485
1c470562
SM
34862011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3487
44f230aa
SM
3488 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3489 steal a few bits to be more compact.
3490 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3491 Remove unneeded casts.
3492
1c470562
SM
3493 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3494
888adce9
ZK
34952011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3496
3497 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3498 binding" message (bug#7967).
3499
f838ed7b
PE
35002011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3501
77861b95
PE
3502 Fix more problems found by GCC 4.6.0's static checks.
3503
de6dbc14
PE
3504 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3505 Remove unused local var.
3506
f838ed7b
PE
3507 * editfns.c (Fmessage_box): Remove unused local var.
3508
792c7b2b
PE
3509 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3510 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3511 Omit unused local vars.
c499e557 3512 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3513 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3514 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3515 Omit unused local var.
3516
ba0165e1
PE
3517 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3518 Don't assume string length fits in int.
32ad8845 3519 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3520 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3521
3c59b4c9
PE
3522 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3523 instead of alloca (Bug#8344).
3524
a3eed478 3525 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3526 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3527
eb4d412d
PE
3528 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3529
1658b401
PE
3530 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3531 concerns.
3532
3533 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3534
3535 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3536
9a2c6e05
PE
3537 * keyboard.c (syms_of_keyboard): Use the same style as later
3538 in this function when indexing through an array. This also
3539 works around GCC bug 48267.
3540
03d0a109
PE
3541 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3542
44f730c8
PE
3543 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3544
fe75f926
PE
3545 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3546 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3547
ffa8c828
PE
3548 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3549 This avoids undefined behavior on integer overflow, and is a bit
3550 more convenient anyway since it is compared to a size_t variable.
3551
c5101a77
PE
3552 Variadic C functions now count arguments with size_t, not int.
3553 This avoids an unnecessary limitation on 64-bit machines, which
3554 caused (substring ...) to crash on large vectors (Bug#8344).
3555 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3556 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3557 All variadic functions and their callers changed accordingly.
c5101a77
PE
3558 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3559 * data.c (arith_driver, float_arith_driver): Likewise.
3560 * editfns.c (general_insert_function): Likewise.
3561 * eval.c (struct backtrace.nargs, interactive_p)
3562 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3563 (funcall_lambda, mark_backtrace): Likewise.
3564 * fns.c (concat): Likewise.
3565 * frame.c (x_set_frame_parameters): Likewise.
3566 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3567 0 if not found, not -1. All callers changed.
3568
dd3f25f7
PE
3569 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3570 (stack_copy_size): Now size_t, not int.
3571 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3572
461c2ab9
JB
35732011-03-28 Juanma Barranquero <lekktu@gmail.com>
3574
3575 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3576 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3577 All callers changed.
3578
3579 * lisp.h (multibyte_char_to_unibyte):
3580 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3581 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3582 * character.h (CHAR_TO_BYTE8):
3583 * cmds.c (internal_self_insert):
3584 * editfns.c (general_insert_function):
3585 * keymap.c (push_key_description):
3586 * search.c (Freplace_match):
3587 * xdisp.c (message_dolog, set_message_1): All callers changed.
3588
f6d62986
SM
35892011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3590
3591 * keyboard.c (safe_run_hook_funcall): New function.
3592 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3593 don't set the hook to nil, but remove the offending function instead.
3594 (Qcommand_hook_internal): Remove, unused.
3595 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3596 Vcommand_hook_internal.
3597
3598 * eval.c (enum run_hooks_condition): Remove.
3599 (funcall_nil, funcall_not): New functions.
3600 (run_hook_with_args): Call each function through a `funcall' argument.
3601 Remove `cond' argument, now redundant.
3602 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3603 (Frun_hook_with_args_until_failure): Adjust accordingly.
3604 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3605
1db5b1ad
JB
36062011-03-28 Juanma Barranquero <lekktu@gmail.com>
3607
3608 * dispextern.h (string_buffer_position): Remove declaration.
3609
3610 * print.c (strout): Remove parameter `multibyte', unused since
3611 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3612
3613 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3614 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3615 All callers changed.
3616
3617 * w32.c (_wsa_errlist): Use braces for struct initializers.
3618
3619 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3620 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3621 All callers changed.
3622 (string_buffer_position): Likewise. Also, make static (it's never
3623 used outside xdisp.c).
3624 (cursor_row_p): Remove parameter `w', unused since
3625 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3626 (decode_mode_spec): Remove parameter `precision', introduced during
3627 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3628 All callers changed.
3629
5ffb62aa
JD
36302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3631
3632 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3633
461c2ab9 36342011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3635
3636 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3637 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3638 (ns_update_auto_hide_menu_bar): New functions.
3639 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3640 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3641 ns_constrain_all_frames.
3642 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3643 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3644
5c380ffb
JD
36452011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3646
3647 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3648
9af30bdf
GM
36492011-03-27 Glenn Morris <rgm@gnu.org>
3650
3651 * syssignal.h: Replace RETSIGTYPE with void.
3652 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3653 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3654 Replace SIGTYPE with void everywhere.
3655 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3656 * s/template.h (SIGTYPE): Remove commented out definition.
3657
e2abce01
JB
36582011-03-26 Eli Zaretskii <eliz@gnu.org>
3659
3660 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3661 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3662
f868cd8a
JB
36632011-03-26 Juanma Barranquero <lekktu@gmail.com>
3664
59eb0929
JB
3665 * w32.c (read_unc_volume): Use parameter `henum', instead of
3666 global variable `wget_enum_handle'.
3667
3668 * keymap.c (describe_vector): Remove parameters `indices' and
3669 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3670 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3671
f868cd8a
JB
3672 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3673
3674 * keyboard.c (timer_check): Remove parameter `do_it_now',
3675 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3676 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3677 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3678
3679 * keyboard.c (read_char):
3680 * w32menu.c (w32_menu_display_help):
3681 * xmenu.c (show_help_event, menu_help_callback):
3682 Adjust calls to `show_help_echo'.
3683
3684 * gtkutil.c (xg_maybe_add_timer):
3685 * keyboard.c (readable_events):
3686 * process.c (wait_reading_process_output):
3687 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3688
3689 * insdel.c (adjust_markers_gap_motion):
3690 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3691 (gap_left, gap_right): Don't call it.
3692
2ecf6fdb
CY
36932011-03-25 Chong Yidong <cyd@stupidchicken.com>
3694
3695 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3696 incurred during fontification.
3697
6b1f9ba4
JB
36982011-03-25 Juanma Barranquero <lekktu@gmail.com>
3699
3700 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3701 (DEFVAR_PER_BUFFER): Don't pass it.
3702
3703 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3704 (scrolling_window): Don't pass it.
3705
0f4a96b5
JB
37062011-03-25 Juanma Barranquero <lekktu@gmail.com>
3707
3708 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3709
3710 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3711 and `suffix'.
3712 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3713 of variables specific to SELinux and computation of `encoded_absname'.
3714
3715 * image.c (XPutPixel): Remove unused variable `height'.
3716
3717 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3718
3719 * unexw32.c (get_section_info): Remove unused variable `section'.
3720
3721 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3722 (system_process_attributes): Remove unused variable `sess'.
3723 (sys_read): Remove unused variable `err'.
3724
3725 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3726 (w32_wnd_proc): Remove unused variable `isdead'.
3727 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3728 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3729 (x_create_tip_frame): Remove unused variable `tem'.
3730
3731 * w32inevt.c (w32_console_read_socket):
3732 Remove unused variable `no_events'.
3733
3734 * w32term.c (x_draw_composite_glyph_string_foreground):
3735 Remove unused variable `width'.
3736
1149507c
JB
37372011-03-24 Juanma Barranquero <lekktu@gmail.com>
3738
3739 * w32term.c (x_set_glyph_string_clipping):
3740 Don't pass uninitialized region to CombineRgn.
3741
9c88f339
JB
37422011-03-23 Juanma Barranquero <lekktu@gmail.com>
3743
3744 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3745 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3746 (Fx_close_connection): Remove unused variable `i'.
3747
3748 * w32font.c (w32font_draw): Return number of glyphs.
3749 (w32font_open_internal): Remove unused variable `i'.
3750 (w32font_driver): Add missing initializer.
3751
3752 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3753 (fill_in_menu): Remove unused variable `items_added'.
3754
3755 * w32term.c (last_mouse_press_frame): Remove static global variable.
3756 (w32_clip_to_row): Remove unused variable `f'.
3757 (x_delete_terminal): Remove unused variable `i'.
3758
3759 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3760 (NOTHING): Remove unused static global variable.
3761 (uniscribe_check_otf): Remove unused variable `table'.
3762 (uniscribe_font_driver): Add missing initializers.
3763
dee091a3
JD
37642011-03-23 Julien Danjou <julien@danjou.info>
3765
3766 * term.c (Fsuspend_tty, Fresume_tty):
3767 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3768 * window.c (temp_output_buffer_show):
3769 * insdel.c (signal_before_change):
3770 * frame.c (Fhandle_switch_frame):
3771 * fileio.c (Fdo_auto_save):
3772 * emacs.c (Fkill_emacs):
3773 * editfns.c (save_excursion_restore):
3774 * cmds.c (internal_self_insert):
3775 * callint.c (Fcall_interactively):
3776 * buffer.c (Fkill_all_local_variables):
3777 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3778 Use Frun_hooks.
0f4a96b5 3779 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3780 unconditionnaly since it does the check itself.
3781
2c520ab5 37822011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3783
c9c49752
PE
3784 Fix more problems found by GCC 4.5.2's static checks.
3785
8abc3f12
PE
3786 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3787 the first time through the loop, since we know p0 < p1 then.
3788 This also avoids a gcc -Wstrict-overflow warning.
3789
a2d26660
PE
3790 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3791 leading to a memory leak, possible in functions like
3792 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3793 of objects (Bug#8318).
a2d26660 3794
916c72e9
PE
3795 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3796 that could (at least in theory) be that large.
3797
19ab8a18
PE
3798 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3799 This is less likely to overflow, and avoids undefined behavior if
3800 overflow does occur. All callers changed. Use strtoul to scan
3801 for the unsigned long integer.
b7cbbd6f
PE
3802 (pint2hrstr): Simplify and tune code slightly.
3803 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3804
f0641eff
PE
3805 * scroll.c (do_scrolling): Work around GCC bug 48228.
3806 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3807
7f650bb9
PE
3808 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3809 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3810 (validate_x_resource_name): Simplify count usage.
3811 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3812
37dd57d1
PE
3813 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3814 fail (Bug#8306).
81e56e61 3815
699979fc 3816 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3817
401bf9b4
PE
3818 * process.c (Fmake_network_process): Use socklen_t, not int,
3819 where POSIX says socklen_t is required in portable programs.
3820 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3821 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3822 (Fmake_network_process, server_accept_connection):
3823 (wait_reading_process_output, read_process_output):
3824 Likewise.
3825
b93aacde
PE
3826 * process.c: Rename or move locals to avoid shadowing.
3827 (list_processes_1, Fmake_network_process):
3828 (read_process_output_error_handler, exec_sentinel_error_handler):
3829 Rename or move locals.
4dc343ee 3830 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3831 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3832 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3833 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3834 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3835
af8a867c 3836 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3837 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3838 Include tparam.h instead, since it declares them.
af8a867c
PE
3839 * cm.h (PC): Remove extern decl; tparam.h now does this.
3840 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3841 * terminfo.c: Include tparam.h, to check interfaces.
3842 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3843 (tparam): Adjust signature to match interface in tparam.h;
3844 this removes some undefined behavior. Check that outstring and len
3845 are zero, which they always are with Emacs.
3846 * tparam.h (PC, BC, UP): New extern decls.
3847
0248044d 3848 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3849 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3850
8ff096c1 3851 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3852 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3853 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3854 (ftfont_list): Remove unused local.
49eaafba
PE
3855 (get_adstyle_property, ftfont_pattern_entity):
3856 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3857 Rename locals to avoid shadowing.
8ff096c1 3858
e2be39f6
PE
3859 * xfont.c (xfont_list_family): Mark var as initialized.
3860
c9735e30
PE
3861 * xml.c (make_dom): Now static.
3862
8f5201ae
PE
3863 * composite.c (composition_compute_stop_pos): Rename local to
3864 avoid shadowing.
b246f932
PE
3865 (composition_reseat_it): Remove unused locals.
3866 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3867 (composition_update_it): Mark var as initialized.
11b61122
PE
3868 (find_automatic_composition): Mark vars as initialized,
3869 with a FIXME (Bug#8290).
8f5201ae 3870
760fbc2c
PE
3871 character.h: Rename locals to avoid shadowing.
3872 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3873 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3874 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3875 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3876 to avoid shadowing.
3877
ff08eb85
PE
3878 * textprop.c (property_change_between_p): Remove; unused.
3879
fc7bf025
PE
3880 * intervals.c (interval_start_pos): Now static.
3881
235d7abc
PE
3882 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3883
44f230aa
SM
3884 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3885 Rename locals to avoid shadowing.
3e7d6594 3886
50060332
PE
3887 * sound.c (wav_play, au_play, Fplay_sound_internal):
3888 Fix pointer signedness.
d01f234b 3889 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3890 (wav_play): Initialize a variable to 0, to prevent undefined
3891 behavior (Bug#8278).
50060332 3892
c4fc4e30
PE
3893 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3894
918436ed
PE
3895 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3896
c939f91b
PE
3897 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3898 clobbering (Bug#8298).
b9c7f648
PE
3899 * sysdep.c (sys_subshell): Likewise.
3900 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3901
6bd8c144
PE
3902 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3903 This should get cleaned up, so that child_setup has the
3904 same signature on all platforms.
3905
7710357c 3906 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3907 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3908
c59da222
CY
39092011-03-22 Chong Yidong <cyd@stupidchicken.com>
3910
3911 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3912 not to be necessary, and produces flickering.
3913
66b87493
GM
39142011-03-20 Glenn Morris <rgm@gnu.org>
3915
3916 * config.in: Remove file.
3917
45b6f6d5
JB
39182011-03-20 Juanma Barranquero <lekktu@gmail.com>
3919
3920 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3921 are now in src/globals.h.
3922 (syms_of_minibuf): Remove spurious & from previous change.
3923
3ec03f7e
LL
39242011-03-20 Leo <sdl.web@gmail.com>
3925
3926 * minibuf.c (completing-read-function): New variable.
3927 (completing-read-default): Rename from completing-read.
3928 (completing-read): Call completing-read-function.
3929
b14e3e21
CY
39302011-03-19 Juanma Barranquero <lekktu@gmail.com>
3931
3932 * xfaces.c (Fx_load_color_file):
3933 Read color file from absolute filename (bug#8250).
3934
f2b726e6
JB
39352011-03-19 Juanma Barranquero <lekktu@gmail.com>
3936
3937 * makefile.w32-in: Update dependencies.
3938
09f6ff02
EZ
39392011-03-17 Eli Zaretskii <eliz@gnu.org>
3940
3941 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3942
29a6015a
PE
39432011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3944
a3a6c54e
PE
3945 Fix more problems found by GCC 4.5.2's static checks.
3946
b766f867
PE
3947 * process.c (make_serial_process_unwind, send_process_trap):
3948 (sigchld_handler): Now static.
3949
be02381c
PE
3950 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3951 That way, the code declares only the vars that it needs.
3952 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3953 * s/cygwin.h (PTY_ITERATION): Likewise.
3954 * s/darwin.h (PTY_ITERATION): Likewise.
3955 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3956
57048744
PE
3957 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3958 * process.c (allocate_pty): Don't declare stb unless it's needed.
3959
7914961c 3960 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3961 (CONSTANTLIM): Remove; unused.
3962 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3963 Define only if needed.
7914961c 3964
b3967b18
PE
3965 * unexelf.c (unexec): Name an expression,
3966 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3967 Use a different way to cause a compilation error if anyone uses
3968 n rather than nn, a way that does not involve shadowing.
73366a00 3969 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3970
29a6015a
PE
3971 * deps.mk (unexalpha.o): Remove; unused.
3972
43cfc33e 3973 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3974 * unexec.h: New file.
ce701a33
PE
3975 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3976 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3977 Depend on unexec.h.
3978 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3979 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3980 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3981 Change as necessary to match prototype in unexec.h.
ce701a33 3982
01f44d5a
PE
3983 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3984 shadowing.
4f63c6bb 3985 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3986
a6670b0b
PE
3987 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3988 Rename locals to avoid shadowing.
3989
cef2010d 3990 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3991 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3992
d4d7173a
PE
3993 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3994
f08b802a
PE
3995 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3996 warning when compiling print.c.
3997
3ddb0639
PE
3998 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3999 instead of using an uninitialized var.
5ad03b97 4000 (font_sort_entities): Mark var as initialized.
3ddb0639 4001
170a2692
PE
4002 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4003
e663c700
PE
4004 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4005 pointers to constants.
89bc529a 4006 (font_parse_fcname): Remove unused vars.
7b81e2d0 4007 (font_delete_unmatched): Now static.
ea838e10 4008 (font_get_spec): Remove; unused.
13a547c6
PE
4009 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4010 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4011 Rename or move locals to avoid shadowing.
e663c700 4012
2a80c887 4013 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4014 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4015
1384fa33 4016 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4017 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4018
8b2c52e9
PE
4019 * alloc.c (mark_backtrace): Move decl from here ...
4020 * lisp.h: ... to here, so that it can be checked.
4021
475545b5 4022 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4023 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4024 (lisp_indirect_variable): Name an expression,
4025 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4026 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4027
b1349114 4028 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4029 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4030 Use const pointer when appropriate.
b1349114 4031
a2928364
PE
4032 * lisp.h (get_system_name, get_operating_system_release):
4033 Move decls here, to check interfaces.
4034 * process.c (get_operating_system_release): Move decl to lisp.h.
4035 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4036 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4037 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4038 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4039 (Fformat_time_string, Fencode_time, Finsert_char):
4040 (Ftranslate_region_internal, Fformat):
4041 Rename or remove local vars to avoid shadowing.
9710023e 4042 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4043
a415e694
PE
4044 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4045 avoid shadowing.
4046
8ef4622d
PE
4047 * lisp.h (eassert): Check that the argument compiles, even if
4048 ENABLE_CHECKING is not defined.
4049
946f9a5b
PE
4050 * data.c (Findirect_variable): Name an expression, to avoid
4051 gcc -Wbad-function-cast warning.
112396d6 4052 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4053 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4054 (Fmake_variable_buffer_local, Fmake_local_variable):
4055 Mark variables as initialized.
52746918 4056 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4057
e5aab7e7 4058 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4059 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4060 Rename locals to avoid shadowing.
dff45157
PE
4061 (mark_stack): Move local variables into the #ifdef region where
4062 they're used.
7bc26fdb
PE
4063 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4064 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4065 needed otherwise.
4066 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4067 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4068 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4069
e5aab7e7
PE
4070 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4071 avoids undefined behavior in theory.
4072
4da60324
PE
4073 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4074
88043301
PE
4075 Use functions, not macros, for up- and down-casing (Bug#8254).
4076 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4077 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4078 to use the following functions instead of these macros.
4079 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4080 EMACS_INT, since callers assume the returned value fits in int.
4081 (upcase1): Likewise, for UPCASE_TABLE.
4082 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4083 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4084 the race-condition problem in the old DOWNCASE.
88043301 4085
19ed5445
PE
4086 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4087 Rename locals to avoid shadowing.
4088 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4089 (regex_compile, re_search_2, re_match_2_internal):
4090 Remove unused local vars.
952db0d7
PE
4091 (FREE_VAR): Rewrite so as not to use empty "else",
4092 which gcc can warn about.
da053e48 4093 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4094 (RETALLOC_IF): Define only if needed.
4095 (WORDCHAR_P): Likewise. This one is never needed, but is used
4096 only in a comment talking about a compiler bug, so put inside
4097 the #if 0 of that comment.
4098 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4099 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4100 Remove; unused.
19ed5445 4101
1f3561e4 4102 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4103 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4104 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4105
ded6f8f7
PE
4106 * search.c (simple_search): Remove unused var.
4107
dbd37a95
PE
4108 * dired.c (compile_pattern): Move decl from here ...
4109 * lisp.h: ... to here, so that it can be checked.
4110 (struct re_registers): New forward decl.
4111
7e47afad
PE
4112 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4113
85f24f61
PE
4114 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4115 All uses changed.
4116 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4117 Rename locals to avoid shadowing.
5671df8f 4118 (Fvertical_motion): Mark locals as initialized.
85f24f61 4119
181aa2be 4120 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4121 (casify_region): Mark local as initialized.
181aa2be 4122
930d429c
PE
4123 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4124
7082eac6
PE
4125 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4126 New macros, so that the caller can use some names other than
4127 gcpro1, gcpro2, etc.
4128 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4129 of the new macros.
4130 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4131 argument, for consistency with GCPRO2_VAR, etc: it is now the
4132 prefix of the variable, not the variable itself. All uses
4133 changed.
38b2c076
PE
4134 * dired.c (directory_files_internal, file_name_completion):
4135 Rename locals to avoid shadowing.
4136
15206ed9
PE
4137 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4138 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4139 dired.c's scmp function, had undefined behavior.
4140 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4141 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4142 * buffer.h: ... to here, because these macros use current_buffer,
4143 and the new implementation with inline functions needs to have
4144 current_buffer in scope now, rather than later when the macros
4145 are used.
4146 (downcase, upcase1): New static inline functions.
4147 (DOWNCASE, UPCASE1): Reimplement using these functions.
4148 This avoids undefined behavior in expressions like
4149 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4150 from race conditions in accessing the global variables
4151 case_temp1 and case_temp2.
4152 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4153 * lisp.h (case_temp1, case_temp2): Remove their decls.
4154 * character.h (ASCII_CHAR_P): Move from here ...
4155 * lisp.h: ... to here, so that the inline functions mentioned
4156 above can use them.
4157
4a6bea26
PE
4158 * dired.c (directory_files_internal_unwind): Now static.
4159
f14b7e14
PE
4160 * fileio.c (file_name_as_directory, directory_file_name):
4161 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4162 Now static.
2893f146
PE
4163 (file_name_as_directory): Use const pointers when appropriate.
4164 (Fexpand_file_name): Likewise. In particular, newdir might
4165 point at constant storage, so make it a const pointer.
fd4ead52 4166 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4167 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4168 signedness issues.
f839df0c
PE
4169 (Fset_file_times, Finsert_file_contents, auto_save_error):
4170 Rename locals to avoid shadowing.
f14b7e14 4171
5716756e 4172 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4173 (Ftry_completion, Fall_completions): Rename or remove locals
4174 to avoid shadowing.
5716756e 4175
b4c3046a
PE
4176 * marker.c (bytepos_to_charpos): Remove; unused.
4177
b45db522
PE
4178 * lisp.h (verify_bytepos, count_markers): New decls,
4179 so that gcc does not warn that these functions aren't declared.
4180
85876d07
PE
4181 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4182 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4183 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4184 (copy_text): Remove unused local var.
85876d07 4185
03d78a21 4186 * filelock.c (within_one_second): Now static.
b3dd38ab 4187 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4188
5df8f01b
PE
4189 * buffer.c (fix_overlays_before): Mark locals as initialized.
4190 (fix_start_end_in_overlays): Likewise. This function should be
4191 simplified by using pointers-to-pointers, but that's a different
4192 matter.
b1d876f1 4193 (switch_to_buffer_1): Now static.
8f54f30a
PE
4194 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4195 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4196
a70072c9 4197 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4198 Fix pointer signedness issue.
edced198
PE
4199 (sys_subshell): Mark local as volatile if checking for lint,
4200 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4201 (MAXPATHLEN): Define only if needed.
a70072c9 4202
a0977c44
PE
4203 * process.c (serial_open, serial_configure): Move decls from here ...
4204 * systty.h: ... to here, so that they can be checked.
4205
a884fdcc
PE
4206 * fns.c (get_random, seed_random): Move extern decls from here ...
4207 * lisp.h: ... to here, so that they can be checked.
4208
604efe86 4209 * sysdep.c (reset_io): Now static.
b8950c94 4210 (wait_for_termination_signal): Remove; unused.
604efe86 4211
38fc62d9
PE
4212 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4213 (copy_keymap_item, append_key, push_text_char_description):
4214 Now static.
1004a21a 4215 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4216 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4217 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4218 (describe_map_tree):
4219 Rename locals to avoid shadowing.
38fc62d9 4220
2f2650da
PE
4221 * keyboard.c: Declare functions static if they are not used elsewhere.
4222 (echo_char, echo_dash, cmd_error, top_level_2):
4223 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4224 (read_char, kbd_buffer_get_event, make_lispy_position):
4225 (make_lispy_event, make_lispy_movement, apply_modifiers):
4226 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4227 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4228 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4229 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4230 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4231
a053e86c 4232 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4233 (mark_kboards): Move decl here ...
4234 * alloc.c (mark_kboards): ... from here.
a053e86c 4235
4752793e
PE
4236 * lisp.h (force_auto_save_soon): New decl.
4237
74f10ca7 4238 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4239 (DEFINE_DUMMY_FUNCTION): New macro.
4240 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4241 Use it.
c03cd23f
PE
4242 (main): Add casts to avoid warnings
4243 if GCC considers string literals to be constants.
74f10ca7 4244
022e70d4
PE
4245 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4246
59d6fe83
PE
4247 * dbusbind.c: Pointer signedness fixes.
4248 (xd_signature, xd_append_arg, xd_initialize):
4249 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4250 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4251 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4252 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4253
78320123
PE
4254 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4255 if GCC considers string literals to be constants.
49cebcca 4256 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4257
35ac2a97
SM
42582011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4259
fb103ca9
SM
4260 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4261 (print_preprocess, print_object): New macro to fix last change.
4262
35ac2a97
SM
4263 * print.c (print_preprocess): Don't forget font objects.
4264
62973b41
JB
42652011-03-16 Juanma Barranquero <lekktu@gmail.com>
4266
4267 * emacs.c (USAGE3): Doc fixes.
4268
0e48bb22
AS
42692011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4270
4271 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4272 structure.
4273
7684e57b
JB
42742011-03-14 Juanma Barranquero <lekktu@gmail.com>
4275
4276 * lisp.h (VWindow_system, Qfile_name_history):
4277 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4278 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4279 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4280
4281 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4282 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4283
4284 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4285 * w32console.c (detect_input_pending, read_input_pending)
4286 (encode_terminal_code):
4287 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4288 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4289 (w32_system_caret_y, Qfile_name_history):
4290 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4291 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4292 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4293 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4294 * w32proc.c (Qlocal, report_file_error):
4295 * w32term.c (Vwindow_system, updating_frame):
4296 * w32uniscribe.c (initialized, uniscribe_font_driver):
4297 Remove unneeded extern declarations.
4298
2aa46d6c
CY
42992011-03-14 Chong Yidong <cyd@stupidchicken.com>
4300
c96bbc66 4301 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4302
cffc6f3b
CY
43032011-03-13 Chong Yidong <cyd@stupidchicken.com>
4304
4305 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4306 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4307 These macros can no longer be used for assignment.
4308
44f230aa
SM
4309 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4310 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4311 (record_buffer_markers, fetch_buffer_markers): New functions for
4312 recording and fetching special buffer markers.
4313 (set_buffer_internal_1, set_buffer_temp): Use them.
4314
4315 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4316
4317 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4318
4319 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4320 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4321
4322 * xdisp.c (hscroll_window_tree):
4323 (reconsider_clip_changes): Use PT instead of BUF_PT.
4324
d251f04b
EZ
43252011-03-13 Eli Zaretskii <eliz@gnu.org>
4326
4327 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4328 $(EMACS_ROOT)/lib/intprops.h.
4329
f0c77cd1
PE
43302011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4331
3eca4629
PE
4332 Fix more problems found by GCC 4.5.2's static checks.
4333
7c86ee98
PE
4334 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4335 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4336 (xg_free_frame_widgets): Make it clear that a local variable is
4337 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4338 (gdk_window_get_screen): Make it clear that this macro is needed
4339 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4340 (int_gtk_range_get_value): New function, which avoids a diagnostic
4341 from gcc -Wbad-function-cast.
4342 (xg_set_toolkit_scroll_bar_thumb): Use it.
4343 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4344 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4345 (get_utf8_string, xg_get_file_with_chooser):
4346 Rename locals to avoid shadowing.
4347 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4348
41729b81
PE
4349 * xgselect.c (xg_select): Remove unused var.
4350
f0c77cd1
PE
4351 * image.c (four_corners_best): Mark locals as initialized.
4352 (gif_load): Initialize transparent_p to zero (Bug#8238).
4353 Mark another local as initialized.
ec6cf4c6 4354 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4355
ce0ad53d 4356 * image.c (clear_image_cache): Now static.
d5d5a617 4357 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4358 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4359 (x_edge_detection): Remove unnecessary cast that
4360 gcc -Wbad-function-cast diagnoses.
2037898d 4361 (gif_load): Fix pointer signedness.
6ae141d6
PE
4362 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4363 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4364
33383987 43652011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4366
d32df629
PE
4367 Improve quality of tests for time stamp overflow.
4368 For example, without this patch (encode-time 0 0 0 1 1
4369 1152921504606846976) returns the obviously-bogus value (-948597
4370 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4371 reports time overflow. See
4372 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4373 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4374 * editfns.c: Include limits.h and intprops.h.
4375 (TIME_T_MIN, TIME_T_MAX): New macros.
4376 (time_overflow): Move earlier, to before first use.
4377 (hi_time, lo_time): New functions, for an accurate test for
4378 out-of-range times.
4379 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4380 (Fget_internal_run_time): Don't assume time_t fits in int.
4381 (make_time): Use list2 instead of Fcons twice.
4382 (Fdecode_time): More accurate test for out-of-range times.
4383 (check_tm_member): New function.
4384 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4385 (lisp_time_argument): Don't rely on undefined left-shift and
4386 right-shift behavior when checking for time stamp overflow.
8be6f318 4387
fe31d94c
PE
4388 * editfns.c (time_overflow): New function, refactoring common code.
4389 (Fformat_time_string, Fdecode_time, Fencode_time):
4390 (Fcurrent_time_string): Use it.
4391
8be6f318
PE
4392 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4393 * dired.c (make_time): Move to ...
4394 * editfns.c (make_time): ... here.
4395 * systime.h: Note the move.
4396
09d9db2c 43972011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4398
126bc0dc
YM
4399 * fringe.c (update_window_fringes): Remove unused variables.
4400
c47cbdfd
YM
4401 * unexmacosx.c (copy_data_segment): Also copy __got section.
4402 (Bug#8223)
4403
7ac80be9
EZ
44042011-03-12 Eli Zaretskii <eliz@gnu.org>
4405
c96bbc66 4406 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4407 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4408 Constify `char *' arguments and their references according to
4409 prototypes in tparam.h.
4410
ecb0f94d 4411 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4412
7ac80be9
EZ
4413 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4414 Adapt all references accordingly.
4415
4416 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4417
ef1fd07e
TT
44182011-03-11 Tom Tromey <tromey@redhat.com>
4419
4420 * buffer.c (syms_of_buffer): Remove obsolete comment.
4421
7ef4b50c
EZ
44222011-03-11 Eli Zaretskii <eliz@gnu.org>
4423
4424 * termhooks.h (encode_terminal_code): Declare prototype.
4425
4426 * msdos.c (encode_terminal_code): Don't declare prototype.
4427
4428 * term.c (encode_terminal_code): Now external again, used by
4429 w32console.c and msdos.c.
4430
44f230aa
SM
4431 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4432 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4433
4b1ec863 44342011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4435
1714f52b 4436 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4437
4b1ec863
PE
4438 * fringe.c (update_window_fringes): Mark locals as initialized
4439 (Bug#8227).
4440 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4441
524c7aa6
PE
4442 * alloc.c (mark_fringe_data): Move decl from here ...
4443 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4444 to check its interface.
4445 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4446
a5c0af81 4447 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4448 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4449 (fontset_font): Mark local as initialized.
a9a06e0b 4450 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4451
b4716021
PE
4452 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4453
811e9bac 4454 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4455 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4456 (x_own_selection, Fx_disown_selection_internal): Rename locals
4457 to avoid shadowing.
4458 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4459
7e3ab302
PE
4460 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4461 so that the caller can use some name other than gcpro1.
4462 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4463 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4464 (Fx_backspace_delete_keys_p):
4465 Use them to avoid shadowing, and rename vars to avoid shadowing.
4466 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4467 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4468 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4469 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4470 Remove unused locals.
7e3ab302
PE
4471 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4472 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4473 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4474 macros.
f78faa98 4475
e2b13473
PE
4476 * xterm.h (x_mouse_leave): New decl.
4477
77f23912
PE
4478 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4479 Remove unused functions.
cdf4ba58
PE
4480 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4481 (x_calc_absolute_position): Now static.
7411c686 4482 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4483 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4484 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4485 unless they are used.
38d0b34a
PE
4486 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4487 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4488 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4489 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4490 (x_error_catcher, x_connection_closed, x_error_handler):
4491 (x_error_quitter, xembed_send_message, x_iconify_frame):
4492 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4493 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4494 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4495
44f230aa
SM
4496 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4497 Rename or move locals to avoid shadowing.
6b463e58 4498 (tty_defined_color, merge_face_heights): Now static.
5967d051 4499 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4500 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4501 does not deduce is never used uninitialized.
73719eba
PE
4502 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4503 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4504
426994c3 4505 * terminal.c (store_terminal_param): Now static.
5489860b 4506
032f1620 4507 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4508 (set_frame_menubar): Remove unused local.
d4323972 4509 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4510 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4511 since they might point to immutable storage.
281585b0
PE
4512 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4513 since it's unused otherwise.
032f1620 4514
367c19e5 4515 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4516 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4517 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4518 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4519 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4520 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4521 does not deduce are never used uninitialized.
70739cbe 4522
07b48fa9
PE
4523 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4524
8868a238 4525 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4526 * window.c (window_loop, size_window):
4527 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4528
7e5cf297 4529 * window.c (display_buffer): Now static.
d6550a9f
PE
4530 (size_window): Mark variables that gcc -Wuninitialized
4531 does not deduce are never used uninitialized.
a586633d
PE
4532 * window.h (check_all_windows): New decl, to forestall
4533 gcc -Wmissing-prototypes diagnostic.
5b555da1 4534 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4535
f6095868
PE
4536 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4537 shadowing.
4538 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4539 Include <limits.h>.
4540 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4541 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4542 (load_charset_map): Mark variables that gcc -Wuninitialized
4543 does not deduce are never used uninitialized.
53df7c11 4544 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4545
f38b440c
PE
4546 * coding.c (coding_set_source, coding_set_destination):
4547 Use "else { /* comment */ }" rather than "else /* comment */;"
4548 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4549 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4550 a block, when the outer 'i' will do.
4551 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4552 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4553 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4554 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4555 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4556 Rename locals to avoid shadowing.
4557 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4558 * coding.c (emacs_mule_char, encode_invocation_designation):
4559 Now static, since they're not used elsewhere.
413bb2db 4560 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4561 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4562 (decode_coding_emacs_mule): Mark variables that gcc
4563 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4564 (detect_coding_iso_2022): Initialize a local variable that might
4565 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4566 this initialization is needed. (Bug#8211)
5f58e762
PE
4567 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4568 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4569 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4570 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4571 Remove unused macros.
f38b440c 4572
232b38b9 4573 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4574 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4575 * character.c (string_count_byte8): Likewise.
232b38b9 4576
fb90da1b
PE
4577 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4578 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4579
fb93dbc2
PE
4580 * chartab.c (copy_sub_char_table): Now static, since it's not used
4581 elsewhere.
5c156ace
PE
4582 (sub_char_table_ref_and_range, char_table_ref_and_range):
4583 Rename locals to avoid shadowing.
bbcd0949 4584 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4585
7d3b3862 4586 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4587 (BIDI_BOB): Remove unused macro.
7d3b3862 4588
6be7d3da
PE
4589 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4590 deduce are never used uninitialized.
c2ed9c8b 4591 * term.c (encode_terminal_code): Likewise.
6be7d3da 4592
75f8807f 4593 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4594
50938595
PE
4595 * tparam.h: New file.
4596 * term.c, tparam.h: Include it.
4597 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4598 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4599 Move these decls to tparam.h, and make them agree with what
4600 is actually in tparam.c. The previous trick of using incompatible
4601 decls in different modules does not conform to the C standard.
4602 All callers of tparam changed to use tparam's actual API.
4603 * tparam.c (tparam1, tparam, tgoto):
4604 Use const pointers where appropriate.
4605
fbceeba2
PE
4606 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4607 * cm.h (struct cm): Likewise.
4608 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4609 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4610 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4611 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4612 (turn_on_face, init_tty): Likewise.
4613 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4614
7f3f1250
PE
4615 * term.c (term_mouse_position): Rename local to avoid shadowing.
4616
e6ca6543
PE
4617 * alloc.c (mark_ttys): Move decl from here ...
4618 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4619
c40f8d15
AS
46202011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4621
4622 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4623
cfe0661d
JB
46242011-03-09 Juanma Barranquero <lekktu@gmail.com>
4625
4626 * search.c (compile_pattern_1): Remove argument regp, unused since
4627 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4628 (compile_pattern): Don't pass it.
4629
0afb4571
J
46302011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4631
4632 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4633 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4634 for ! HAVE_GTK3.
4635 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4636
4637 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4638
4639 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4640 gdk_window_get_screen, gdk_window_get_geometry,
4641 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4642 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4643 (xg_get_pixbuf_from_pixmap): New function.
4644 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4645 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4646 Call xg_get_pixbuf_from_pixmap instead of
4647 gdk_pixbuf_get_from_drawable.
4648 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4649 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4650 (xg_check_special_colors): Use GtkStyleContext and its functions
4651 for HAVE_GTK3.
4652 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4653 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4654 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4655 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4656 Call gtk_widget_get_preferred_size.
0afb4571
J
4657 (xg_frame_resized): gdk_window_get_geometry only takes 5
4658 parameters.
44f230aa
SM
4659 (xg_win_to_widget, xg_event_is_for_menubar):
4660 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4661 (xg_set_widget_bg): New function.
4662 (delete_cb): New function.
895009e1 4663 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4664 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4665 (xg_set_background_color): Call xg_set_widget_bg.
4666 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4667 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4668 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4669 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4670 if ! HAVE_GTK3.
4671 (update_frame_tool_bar): Call gtk_widget_hide.
4672 (xg_initialize): Use GDK_KEY_g.
4673
4674 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4675 if ! HAVE_GTK3
4676 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4677
4678 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4679 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4680 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4681
1c2cc4ef
JB
46822011-03-08 Juanma Barranquero <lekktu@gmail.com>
4683
4684 * w32xfns.c (select_palette): Check success of RealizePalette against
4685 GDI_ERROR, not zero.
4686
33383987 4687See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4688
4689;; Local Variables:
4690;; coding: utf-8
aac0c6e3
MR
4691;; End:
4692
33383987 4693 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4694
4695 This file is part of GNU Emacs.
4696
4697 GNU Emacs is free software: you can redistribute it and/or modify
4698 it under the terms of the GNU General Public License as published by
4699 the Free Software Foundation, either version 3 of the License, or
4700 (at your option) any later version.
4701
4702 GNU Emacs is distributed in the hope that it will be useful,
4703 but WITHOUT ANY WARRANTY; without even the implied warranty of
4704 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4705 GNU General Public License for more details.
4706
4707 You should have received a copy of the GNU General Public License
4708 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.