Fix logic of caching display string positions for bidi display.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
22381272 12011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2
3 * xdisp.c (compute_display_string_pos): Fix logic of caching
4 previous display string position. Initialize cached_prev_pos to
5 -1. Fixes slow-down at the beginning of a buffer.
6
f25e39b4
EZ
72011-07-24 Eli Zaretskii <eliz@gnu.org>
8
9 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
10 for attrs[LFACE_FONTSET_INDEX].
11
04c4b52e
PE
122011-07-23 Paul Eggert <eggert@cs.ucla.edu>
13
14 * xml.c (parse_region): Remove unused local
15 that was recently introduced.
16
c1734fbd
EZ
172011-07-23 Eli Zaretskii <eliz@gnu.org>
18
be18c5a5
EZ
19 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
20 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
21
c1734fbd
EZ
22 * xdisp.c (move_it_in_display_line_to): Record the best matching
23 position for TO_CHARPOS while scanning the line, and restore it on
24 exit if none of the characters scanned was an exact match. Fixes
a9269c18
EZ
25 vertical-motion and pos-visible-in-window-p under bidi redisplay
26 when exact match is impossible due to invisible text, and the
27 lines are truncated.
28
a258d627
JD
292011-07-23 Jan Djärv <jan.h.d@swipnet.se>
30
31 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
32 for OSX >= 10.7.
33
b6d5a689
EZ
342011-07-22 Eli Zaretskii <eliz@gnu.org>
35
0f74f785
EZ
36 Fix a significant slow-down of cursor motion with C-n, C-p,
37 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
38 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 39 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
40 (next_element_from_buffer): Call compute_stop_pos_backwards to
41 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
42 base_level_stop.
43 (reseat): Don't look for prev_stop, as that could mean a very long
44 run.
45 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
46 <cached_disp_overlay_modiff>: Cache for last found display string
47 position.
551918c1 48 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
49 about the same buffer in the same area of character positions, and
50 the buffer wasn't changed since the time the display string
51 position was cached.
551918c1 52
b2d0c91a
EZ
532011-07-22 Eli Zaretskii <eliz@gnu.org>
54
55 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
56 is an integer, which is important for empty lines. (Bug#9149)
57
043604ee
CY
582011-07-22 Chong Yidong <cyd@stupidchicken.com>
59
60 * frame.c (Fmodify_frame_parameters): In tty case, update the
61 default face if necessary (Bug#4238).
62
da4adb04
CY
632011-07-21 Chong Yidong <cyd@stupidchicken.com>
64
65 * editfns.c (Fstring_to_char): No need to explain what a character
66 is in the docstring (Bug#6576).
67
9abd0532
LMI
682011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
69
70 * xml.c (parse_region): Make sure we always return a tree.
71
36881d16
HK
722011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
73
74 * xml.c (parse_region): If a document contains only comments,
75 return that, too.
76
1e98674d
LMI
772011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
78
79 * xml.c (make_dom): Return comments, too.
80
590bd467
PE
812011-07-19 Paul Eggert <eggert@cs.ucla.edu>
82
83 Port to OpenBSD.
84 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
85 and the surrounding thread.
86 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
87 rather than fgets, and retry after EINTR. Otherwise, 'emacs
88 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
89 timer goes off.
90 * s/openbsd.h (BROKEN_SIGIO): Define.
91 * unexelf.c (unexec) [__OpenBSD__]:
92 Don't update the .mdebug section of the Alpha COFF symbol table.
93
f41628b2
LMI
942011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
95
96 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
97 (bug#8460).
98
b59b67c5
PE
992011-07-18 Paul Eggert <eggert@cs.ucla.edu>
100
15e3a074
PE
101 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
102 This fixes some race conditions on the permissions of any newly
103 created file.
104
41bed37d
PE
105 * alloc.c (valid_pointer_p): Use pipe, not open.
106 This fixes some permissions issues when debugging.
107
b59b67c5
PE
108 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
109 If fchown fails to set both uid and gid, try to set just gid,
110 as that is sometimes allowed. Adjust the file's mode to eliminate
111 setuid or setgid bits that are inappropriate if fchown fails.
112
925a6be7
SM
1132011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
114
115 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
116 to compare Lisp_Objects.
117 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
118 global_gnutls_log_level, don't mistake it for a Lisp_Object.
119 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
120
52968808
AS
1212011-07-17 Andreas Schwab <schwab@linux-m68k.org>
122
0a6a104b
AS
123 * lread.c (read_integer): Unread even EOF character.
124 (read1): Likewise. Properly record start position of symbol.
125
52968808
AS
126 * lread.c (read1): Read `#:' as empty uninterned symbol if no
127 symbol character follows.
128
9e381cdd
PE
1292011-07-17 Paul Eggert <eggert@cs.ucla.edu>
130
131 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
132 This works around a problem with the previous change to Fcopy_file.
133 Recent glibc declares fchown with __attribute__((warn_unused_result)),
134 and without this change, GCC might complain about discarding
135 fchown's return value.
136
b5641435
JB
1372011-07-16 Juanma Barranquero <lekktu@gmail.com>
138
139 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
140
a8031457
PE
1412011-07-16 Paul Eggert <eggert@cs.ucla.edu>
142
143 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
144
dd889327
LMI
1452011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
146
750c33f7
LMI
147 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
148 it's used from the C level.
149
dd889327
LMI
150 * process.c: Use the same condition for POLL_FOR_INPUT in both
151 keyboard.c and process.c (bug#1858).
152
87e86684
LM
1532011-07-09 Lawrence Mitchell <wence@gmx.li>
154
155 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
156 (Fgnutls_boot): Use it.
157
64348f40
AS
1582011-07-15 Andreas Schwab <schwab@linux-m68k.org>
159
160 * doc.c (Fsubstitute_command_keys): Revert last change.
161
1d698799
LMI
1622011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
163
f863868c
LMI
164 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
165 quotes the next character, and doesn't affect other longer
166 sequences (bug#8935).
167
1d698799
LMI
168 * lread.c (syms_of_lread): Clarify that is isn't only
169 `eval-buffer' and `eval-defun' that's affected by
170 `lexical-binding' (bug#8460).
171
aa4b6df6
EZ
1722011-07-15 Eli Zaretskii <eliz@gnu.org>
173
174 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
175 bidi redisplay when a line includes both an image and is
176 truncated.
177
5d856da6
PE
1782011-07-14 Paul Eggert <eggert@cs.ucla.edu>
179
ad6042bb
PE
180 Fix minor problems found by static checking.
181 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
182 (elsz): Now a signed constant, not a size_t var. We prefer signed
183 types to unsigned, to avoid integer comparison confusion. Without
184 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
185 "cannot optimize loop, the loop counter may overflow", a symptom
186 of the confusion.
f00bbb22 187 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
188 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
189
6468f31c
LMI
1902011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
191
49080b10
LMI
192 * search.c (Fre_search_backward): Mention `case-fold-search' in
193 all the re_search_* functions (bug#8138).
194
6468f31c
LMI
195 * keyboard.c (Fopen_dribble_file): Document when the file is
196 closed (bug#8056).
197
c965adc5
EZ
1982011-07-14 Eli Zaretskii <eliz@gnu.org>
199
df9733bf
EZ
200 * bidi.c (bidi_dump_cached_states): Fix format of displaying
201 bidi_cache_idx.
202
0bb23927
EZ
203 Support bidi reordering of display and overlay strings.
204 * xdisp.c (compute_display_string_pos)
205 (compute_display_string_end): Accept additional argument STRING.
206 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
207 (reseat_to_string): Initialize bidi_it->string.s and
208 bidi_it->string.schars.
209 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
210 NULL (avoids a crash in bidi_paragraph_init). Initialize
211 itb.string.lstring.
212 (init_iterator): Call bidi_init_it only of a valid
213 buffer position was specified. Initialize paragraph_embedding to
214 L2R.
215 (reseat_to_string): Initialize the bidi iterator.
216 (display_string): If we need to ignore text properties of
217 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
218 original value of -1 will not work with bidi.)
219 (compute_display_string_pos): First arg is now struct
220 `text_pos *'; all callers changed. Support display properties on
221 Lisp strings.
222 (compute_display_string_end): Support display properties on Lisp
223 strings.
224 (init_iterator, reseat_1, reseat_to_string): Initialize the
225 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
226 when iterating on a string not from display properties).
227 (compute_display_string_pos, compute_display_string_end): Fix
228 calculation of the object to scan. Fixes an error when using
229 arrow keys.
230 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
231 base_level_stop; instead, set base_level_stop to BEGV. Fixes
232 crashes in vertical-motion.
233 (next_element_from_buffer): Improve commentary for when
234 the iterator is before prev_stop.
235 (init_iterator): Initialize bidi_p from the default value of
236 bidi-display-reordering, not from buffer-local value. Use the
237 buffer-local value only if initializing for buffer iteration.
238 (handle_invisible_prop): Support invisible properties on strings
239 that are being bidi-reordered.
240 (set_iterator_to_next): Support bidi reordering of C strings and
241 Lisp strings.
242 (next_element_from_string): Support bidi reordering of Lisp
243 strings.
244 (handle_stop_backwards): Support Lisp strings as well.
245 (display_string): Support display of R2L glyph rows. Use
246 IT_STRING_CHARPOS when displaying from a Lisp string.
247 (init_iterator): Don't initialize it->bidi_p for strings
248 here.
249 (reseat_to_string): Initialize it->bidi_p for strings here.
250 (next_element_from_string, next_element_from_c_string)
251 (next_element_from_buffer): Add xassert's for correspondence
252 between IT's object being iterated and it->bidi_it.string
253 structure.
254 (face_before_or_after_it_pos): Support bidi iteration.
255 (next_element_from_c_string): Handle the case of the first string
256 character that is not the first one in the visual order.
257 (get_visually_first_element): New function, refactored from common
258 parts of next_element_from_buffer, next_element_from_string, and
259 next_element_from_c_string.
260 (tool_bar_lines_needed, redisplay_tool_bar)
261 (display_menu_bar): Force left-to-right direction. Add a FIXME
262 comment for making that be controlled by a user option.
263 (push_it, pop_it): Save and restore the state of the
264 bidi iterator. Save and restore the bidi_p flag.
265 (pop_it): Iterate out of display property for string iteration as
266 well.
267 (iterate_out_of_display_property): Support iteration over strings.
268 (handle_single_display_spec): Set up it->bidi_it for iteration
269 over a display string, and call bidi_init_it.
270 (handle_single_display_spec, next_overlay_string)
271 (get_overlay_strings_1, push_display_prop): Set up the bidi
272 iterator for displaying display or overlay strings.
273 (forward_to_next_line_start): Don't use the shortcut if
274 bidi-iterating.
275 (back_to_previous_visible_line_start): If handle_display_prop
276 pushed the iterator stack, restore the internal state of the bidi
277 iterator by calling bidi_pop_it same number of times.
278 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
279 and we are bidi-iterating, don't decrement the iterator position;
280 instead, set the first_elt flag in the bidi iterator, to produce
281 the same effect.
282 (reseat_1): Remove redundant setting of string_from_display_prop_p.
283 (push_display_prop): xassert that we are iterating a buffer.
284 (push_it, pop_it): Save and restore paragraph_embedding member.
285 (handle_single_display_spec, next_overlay_string)
286 (get_overlay_strings_1, reseat_1, reseat_to_string)
287 (push_display_prop): Set up the `unibyte' member of bidi_it.string
288 correctly. Don't assume unibyte strings are not bidi-reordered.
289 (compute_display_string_pos)
290 (compute_display_string_end): Fix handling the case of C string.
291 (push_it, pop_it): Save and restore from_disp_prop_p.
292 (handle_single_display_spec, push_display_prop): Set the
293 from_disp_prop_p flag.
294 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
295 (pop_it): Call iterate_out_of_display_property only if we are
296 popping after iteration over a string that came from a display
297 property. Fix a typo in popping stretch info. Add an assertion
298 for verifying that the iterator position is in sync with the bidi
299 iterator.
300 (handle_single_display_spec, get_overlay_strings_1)
301 (push_display_prop): Fix initialization of paragraph direction for
302 string when that of the parent object is not yet determined.
303 (reseat_1): Call bidi_init_it to resync the bidi
304 iterator with IT's position. (Bug#7616)
305 (find_row_edges): If ROW->start.pos gives position
306 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
307 (handle_stop, back_to_previous_visible_line_start, reseat_1):
308 Reset the from_disp_prop_p flag.
309 (SAVE_IT, RESTORE_IT): New macros.
310 (pos_visible_p, face_before_or_after_it_pos)
311 (back_to_previous_visible_line_start)
312 (move_it_in_display_line_to, move_it_in_display_line)
313 (move_it_to, move_it_vertically_backward, move_it_by_lines)
314 (try_scrolling, redisplay_window, display_line): Use them when
315 saving a temporary copy of the iterator and restoring it back.
316 (back_to_previous_visible_line_start, reseat_1)
317 (init_iterator): Empty the bidi cache "stack".
318 (move_it_in_display_line_to): If iterator ended up at
319 EOL, but we never saw any buffer positions smaller than
320 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
321 motion in bidi-reordered lines.
322 (move_it_in_display_line_to): Record prev_method and prev_pos
323 immediately before the call to set_iterator_to_next. Fixes cursor
324 motion in bidi-reordered lines with stretch glyphs and strings
325 displayed in margins. (Bug#8133) (Bug#8867)
326 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
327 TO_CHARPOS.
328 (pos_visible_p): Support positions in bidi-reordered lines. Save
329 and restore bidi cache.
330
331 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
332 (bidi_paragraph_info): Delete unused struct.
333 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
334 (bidi_cache_start): New variable.
335 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
336 to zero.
337 (bidi_cache_fetch_state, bidi_cache_search)
338 (bidi_cache_find_level_change, bidi_cache_iterator_state)
339 (bidi_cache_find, bidi_peek_at_next_level)
340 (bidi_level_of_next_char, bidi_find_other_level_edge)
341 (bidi_move_to_visually_next): Compare cache index with
342 bidi_cache_start rather than with zero.
343 (bidi_fetch_char): Accept new argument STRING; all callers
344 changed. Support iteration over a string. Support strings with
345 display properties. Support unibyte strings. Fix the type of
346 `len' according to what STRING_CHAR_AND_LENGTH expects.
347 (bidi_paragraph_init, bidi_resolve_explicit_1)
348 (bidi_resolve_explicit, bidi_resolve_weak)
349 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
350 iteration over a string.
351 (bidi_set_sor_type, bidi_resolve_explicit_1)
352 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
353 can now be zero (for strings); special values 0 and -1 were
354 changed to -1 and -2, respectively.
355 (bidi_char_at_pos): New function.
356 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
357 Call it instead of FETCH_MULTIBYTE_CHAR.
358 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
359 initialized to valid values.
360 (bidi_init_it): Don't initialize charpos and bytepos with invalid
361 values.
362 (bidi_level_of_next_char): Allow the sentinel "position" to pass
363 the test for valid cached positions. Fix the logic for looking up
364 the sentinel state in the cache. GCPRO the Lisp string we are
365 iterating.
366 (bidi_push_it, bidi_pop_it): New functions.
367 (bidi_initialize): Initialize the bidi cache start stack pointer.
368 (bidi_cache_ensure_space): New function, refactored from part of
369 bidi_cache_iterator_state. Don't assume the required size is just
370 one BIDI_CACHE_CHUNK away.
371 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
372 (bidi_count_bytes, bidi_char_at_pos): New functions.
373 (bidi_cache_search): Don't assume bidi_cache_last_idx is
374 always valid if bidi_cache_idx is valid.
375 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
376 is valid if it's going to be used.
377 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
378 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
379 (bidi_cache_find_level_change, bidi_cache_ensure_space)
380 (bidi_cache_iterator_state, bidi_cache_find)
381 (bidi_find_other_level_edge, bidi_cache_start_stack): All
382 variables related to cache indices are now EMACS_INT.
383
0bb23927
EZ
384 * dispextern.h (struct bidi_string_data): New structure.
385 (struct bidi_it): New member `string'. Make flag members be 1-bit
386 fields, and put them last in the struct.
387 (compute_display_string_pos, compute_display_string_end): Update
388 prototypes.
389 (bidi_push_it, bidi_pop_it): Add prototypes.
390 (struct iterator_stack_entry): New members bidi_p,
391 paragraph_embedding, and from_disp_prop_p.
392 (struct it): Member bidi_p is now a bit field 1 bit wide.
393 (bidi_shelve_cache, bidi_unshelve_cache): Declare
394 prototypes.
395
396 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
397 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
398 and vector-like objects.
399
400 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
401 cache around display iteration.
402
403 * window.c (Fwindow_end, window_scroll_pixel_based)
404 (displayed_window_lines, Frecenter): Save and restore the bidi
405 cache around display iteration.
406
3bbd2265
LMI
4072011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
408
409 * editfns.c (Fdelete_region): Clarify the use of the named
410 parameters (bug#6788).
411
adc47434
MR
4122011-07-14 Martin Rudalics <rudalics@gmx.at>
413
414 * indent.c (Fvertical_motion): Set and restore w->pointm when
415 saving and restoring the window's buffer (Bug#9006).
416
837c31f8
LMI
4172011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
418
419 * editfns.c (Fstring_to_char): Clarify just what is returned
420 (bug#6576). Text by Eli Zaretskii.
421
ac389d0c
JB
4222011-07-13 Juanma Barranquero <lekktu@gmail.com>
423
424 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
425
0be0ce47
EZ
4262011-07-13 Eli Zaretskii <eliz@gnu.org>
427
428 * buffer.c (mmap_find): Fix a typo.
429
cd18e7e3
JB
4302011-07-13 Johan Bockgård <bojohan@gnu.org>
431
432 Fix execution of x selection hooks.
433 * xselect.c (Qx_lost_selection_functions)
434 (Qx_sent_selection_functions): New vars.
435 (syms_of_xselect): DEFSYM them.
436 (x_handle_selection_request): Pass Qx_sent_selection_functions
437 rather than Vx_sent_selection_functions to Frun_hook_with_args.
438 (x_handle_selection_clear,x_clear_frame_selections):
439 Pass Qx_lost_selection_functions rather than
440 Vx_lost_selection_functions to Frun_hook_with_args.
441
47ea7f44
PE
4422011-07-13 Paul Eggert <eggert@cs.ucla.edu>
443
ac389d0c 444 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
445 The old code sometimes used this field without initializing it.
446
47ea7f44
PE
447 * alloc.c (gc_sweep): Don't read past end of array.
448 In theory, the old code could also have corrupted Emacs internals,
449 though it'd be very unlikely.
450
bc985c87
AS
4512011-07-12 Andreas Schwab <schwab@linux-m68k.org>
452
453 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 454 argument. (Bug#4026)
bc985c87 455
0cf34688
LMI
4562011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
457
b3dadd76
LMI
458 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
459 key" (bug#4257).
460
0cf34688
LMI
461 * window.c (Fset_window_start): Doc fix (bug#4199).
462 (Fset_window_hscroll): Ditto.
463
270768cd
PE
4642011-07-12 Paul Eggert <eggert@cs.ucla.edu>
465
077e3dda 466 Fix minor new problems caught by GCC 4.6.1.
270768cd 467 * term.c (init_tty): Remove unused local.
490011a6 468 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 469 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 470 not used otherwise.
270768cd 471
b1f58454
CY
4722011-07-12 Chong Yidong <cyd@stupidchicken.com>
473
474 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
475
22b9578d
LMI
4762011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
477
6e70ab07
LMI
478 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
479 are the mini-buffer and the echo area (bug#3320).
480
22b9578d
LMI
481 * term.c (init_tty): Remove support for supdup, c10 and perq
482 terminals, which are no longer supported (bug#1482).
483
8974cc9f
JB
4842011-07-10 Johan Bockgård <bojohan@gnu.org>
485
486 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
487
a560d974
JD
4882011-07-10 Jan Djärv <jan.h.d@swipnet.se>
489
490 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
491 for non-popups (Bug#3642).
492
1dae0f0a
AS
4932011-07-10 Andreas Schwab <schwab@linux-m68k.org>
494
268c2c36 495 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 496 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
497 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
498 * cm.c (losecursor): Likewise.
1dae0f0a
AS
499 * data.c (fmod): Likewise.
500 * dispnew.c (swap_glyphs_in_rows): Likewise.
501 * emacs.c (memory_warning_signal): Likewise.
502 * floatfns.c (float_error): Likewise.
503 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
504 (otf_open, font_otf_capability, generate_otf_features)
505 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
506 Likewise.
507 * image.c (pbm_read_file): Likewise.
508 * indent.c (string_display_width): Likewise.
509 * intervals.c (check_for_interval, search_for_interval)
510 (inc_interval_count, count_intervals, root_interval)
511 (adjust_intervals_for_insertion, make_new_interval): Likewise.
512 * lread.c (defalias): Likewise.
268c2c36 513 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
514 * regex.c (set_image_of_range_1, set_image_of_range)
515 (regex_grow_registers): Likewise.
516 * sysdep.c (strerror): Likewise.
517 * termcap.c (valid_filename_p, tprint, main): Likewise.
518 * tparam.c (main): Likewise.
519 * unexhp9k800.c (run_time_remap, save_data_space)
520 (update_file_ptrs, read_header, write_header, calculate_checksum)
521 (copy_file, copy_rest, display_header): Likewise.
522 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
523 Likewise.
524 * xdisp.c (check_it): Likewise.
525 * xfaces.c (register_color, unregister_color, unregister_colors):
526 Likewise.
527 * xfns.c (print_fontset_result): Likewise.
528 * xrdb.c (member, fatal, main): Likewise.
529
99033785
PE
5302011-07-10 Paul Eggert <eggert@cs.ucla.edu>
531
532 Fix minor problems found by static checking (Bug#9031).
533 * chartab.c (char_table_set_range, map_sub_char_table):
534 Remove unused locals.
535 (uniprop_table): Now static.
536 * composite.c (_work_char): Remove unused static var.
537
9cb2ac56
JB
5382011-07-09 Juanma Barranquero <lekktu@gmail.com>
539
540 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
541
f25661f0
JD
5422011-07-09 Jan Djärv <jan.h.d@swipnet.se>
543
544 * gtkutil.c (qttip_cb): Remove code without function.
545
8278c4fe
EZ
5462011-07-09 Eli Zaretskii <eliz@gnu.org>
547
548 * w32.c (pthread_sigmask): New stub.
549
1692ae2d 5502011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 551
8a6ebd58 552 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
553 sigprocmask is portable only for single-threaded applications, and
554 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
555 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
556 (LIBES): Use it.
557 * callproc.c (Fcall_process):
558 * process.c (create_process):
559 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
560 Use pthread_sigmask, not sigprocmask.
123403e4 561
1b854618
JD
5622011-07-08 Jan Djärv <jan.h.d@swipnet.se>
563
564 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
565 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
566 wrong (Bug#8591).
567
3fe4b549
JD
5682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
569
0ce7e563
JD
570 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
571 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
572 (xg_hide_tooltip): Fix comment.
573
3fe4b549
JD
574 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
575 in registerServicesMenuSendTypes.
576 (validRequestorForSendType): Don't check ns_return_types.
577
578 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
579 ns_return_type.
580
5df75e47
JR
5812011-07-08 Jason Rumney <jasonr@gnu.org>
582
583 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
584 frame struct members of non-existent frames (Bug#6284).
585
699c10bd
JD
5862011-07-08 Jan Djärv <jan.h.d@swipnet.se>
587
4393663b
JD
588 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
589 variable firstTime not needed on OSX >= 10.6.
590 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
591 >= 10.5. Use setKnobProportion, setDoubleValue.
592
593 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
594 (MAC_OS_X_VERSION_10_5): Define if not defined.
595 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
596 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
597 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
598
599 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
600 cString and lossyCString on OSX >= 10.4
601
602 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
603 sizeToFit on OSX >= 10.2.
604
605 * nsimage.m (allocInitFromFile): Don't use deprecated method
606 bestRepresentationForDevice on OSX >= 10.6.
607
608 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
609 to avoid warning.
610
611 * emacs.c: Declare unexec_init_emacs_zone.
612
a63e0781
JD
613 * nsgui.h: Fix compiler warning about gnulib redefining verify.
614
699c10bd
JD
615 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
616
617 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
618 on svcsMenu (Bug#8842).
619
620 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
621 ns_return_types.
622 (Fns_list_services): Just return Qnil on 10.6, code not working there.
623
624 * nsterm.m (QUTF8_STRING): Declare.
625 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
626 (validRequestorForSendType): Return type is (id).
627 Change indexOfObjectIdenticalTo to indexOfObject.
628 Check if we have local selection before returning self (Bug#8842).
629 (writeSelectionToPasteboard): Put local selection into paste board
630 if we have a local selection (Bug#8842).
631 (syms_of_nsterm): DEFSYM QUTF8_STRING.
632
633 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
634 (ns_get_local_selection): Declare.
635
54e10184
LMI
6362011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
637
9888ff71
LMI
638 * keymap.c (describe_map_tree): Don't insert a double newline at
639 the end of the buffer (bug#1169) and return whether we inserted
640 something.
641
54e10184
LMI
642 * callint.c (Fcall_interactively): Change "reading args" to
643 "providing args" to try to clarify what it does (bug#1010).
644
15fa4783
KH
6452011-07-07 Kenichi Handa <handa@m17n.org>
646
647 * composite.c (composition_compute_stop_pos): Ignore a static
648 composition starting before CHARPOS (Bug#8915).
649
650 * xdisp.c (handle_composition_prop): Likewise.
651
a8815b00
EZ
6522011-07-07 Eli Zaretskii <eliz@gnu.org>
653
654 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
655 (Bug#9015)
656
ef7b981d 6572011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
658
659 * character.h (unicode_category_t): New enum type.
660
661 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
662 (Qchar_code_property_table): New variable.
663 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
664 (UNIPROP_COMPRESSED_FORM_P): New macros.
665 (char_table_ascii): Uncompress the compressed values.
666 (sub_char_table_ref): New arg is_uniprop. Callers changed.
667 Uncompress the compressed values.
ac389d0c 668 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
669 (char_table_ref_and_range): Uncompress the compressed values.
670 (sub_char_table_set): New arg is_uniprop. Callers changed.
671 Uncompress the compressed values.
672 (sub_char_table_set_range): Args changed. Callers changed.
673 (char_table_set_range): Adjuted for the above change.
674 (map_sub_char_table): Delete args default_val and parent. Add arg
675 top. Give decoded values to a Lisp function.
676 (map_char_table): Adjusted for the above change. Give decoded
677 values to a Lisp function. Gcpro more variables.
678 (uniprop_table_uncompress)
679 (uniprop_decode_value_run_length): New functions.
680 (uniprop_decoder, uniprop_decoder_count): New variables.
681 (uniprop_get_decoder, uniprop_encode_value_character)
682 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
683 New functions.
684 (uniprop_encoder, uniprop_encoder_count): New variables.
685 (uniprop_get_encoder, uniprop_table)
686 (Funicode_property_table_internal, Fget_unicode_property_internal)
687 (Fput_unicode_property_internal): New functions.
688 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
689 Sunicode_property_table_internal, Sget_unicode_property_internal,
690 and Sput_unicode_property_internal. Defvar_lisp
691 char-code-property-alist.
692
693 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
694 Vunicode_category_table.
695
696 * font.c (font_range): Adjusted for the change of
697 Vunicode_category_table.
698
76b397fb
DN
6992011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
700
701 * m/iris4d.h: Remove file, move contents ...
702 * s/irix6-5.h: ... here.
703
22b4128e
PE
7042011-07-06 Paul Eggert <eggert@cs.ucla.edu>
705
706 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
707 * alloc.c (mark_buffer):
708 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
709 (clone_per_buffer_values): Don't assume that
22b4128e
PE
710 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
711 This isn't true in general, and it's particularly not true
712 if Emacs is configured with --with-wide-int.
713 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
714 New macros, used in the buffer.c change.
715
869795d6
JD
7162011-07-05 Jan Djärv <jan.h.d@swipnet.se>
717
718 * xsettings.c: Use both GConf and GSettings if both are available.
719 (store_config_changed_event): Add comment.
720 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
721 (store_tool_bar_style_changed): New functions.
722 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
723 (struct xsettings): Move font inside HAVE_XFT.
724 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
725 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
726 Move inside HAVE_XFT.
727 (something_changed_gsettingsCB): Renamed from something_changedCB.
728 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
729 also.
730 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
731 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
732 (something_changed_gconfCB): Renamed from something_changedCB.
733 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
734 (parse_settings): Move check for font inside HAVE_XFT.
735 (read_settings, apply_xft_settings): Add comment.
736 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
737 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
738 call store_font_name_changed.
739 (xft_settings_event): Add comment.
740 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
741 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
742 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
743 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
744 (xsettings_initialize): Call init_gsettings last.
745 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
746 comment.
747
d8ed26bd
PE
7482011-07-05 Paul Eggert <eggert@cs.ucla.edu>
749
750 Random fixes. E.g., (random) never returned negative values.
751 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
752 subseconds part to the entropy, as that's a bit more random.
753 Prefer signed to unsigned, since the signedness doesn't matter and
754 in general we prefer signed. When given a limit, use a
755 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
756 latter isn't right if USE_2_TAGS_FOR_INTS.
757 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
758 not 0..VALMASK. Don't discard "excess" bits that random () returns.
759
cabf1cac
SM
7602011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
761
762 * textprop.c (text_property_stickiness):
763 Obey Vtext_property_default_nonsticky.
764 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
765 * w32fns.c (syms_of_w32fns):
766 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
767
6e9b2be9
PE
7682011-07-04 Paul Eggert <eggert@cs.ucla.edu>
769
770 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
771 This is more efficient than Ffile_directory_p and avoids a minor race.
772
90186c68
LMI
7732011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
774
7c301272
LMI
775 * buffer.c (Foverlay_put): Say what the return value is
776 (bug#7835).
777
c4f2d8d4
LMI
778 * fileio.c (barf_or_query_if_file_exists): Check first if the file
779 is a directory before asking whether to use the file name
780 (bug#7564).
ad637907
LMI
781 (barf_or_query_if_file_exists): Make the "File is a directory"
782 error be more correct.
c4f2d8d4 783
90186c68
LMI
784 * fns.c (Frequire): Remove the mention of the .gz files, since
785 that's installation-specific, but keep the mention of
786 `get-load-suffixes'.
787
da64016e
PE
7882011-07-04 Paul Eggert <eggert@cs.ucla.edu>
789
790 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
791 Report string overflow if the output is too long.
792
7d47b580
JB
7932011-07-04 Juanma Barranquero <lekktu@gmail.com>
794
a555cb87
JB
795 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
796 (syms_of_gnutls): Remove duplicate DEFSYM for
797 Qgnutls_bootprop_verify_hostname_error, an error for
798 Qgnutls_bootprop_verify_error (which is no longer used).
799
7d47b580
JB
800 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
801 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
802 Also (re)move comments that are misplaced or no longer relevant.
803
1e49bfab
LMI
8042011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
805
806 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
807
1485f4c0
CY
8082011-07-03 Chong Yidong <cyd@stupidchicken.com>
809
810 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
811 and background color parameters if they have been changed.
812
a9ab721e
LMI
8132011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
814
815 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
816
cf7cff57
PE
8172011-07-03 Paul Eggert <eggert@cs.ucla.edu>
818
2e13213d
PE
819 * xsettings.c (SYSTEM_FONT): Define only when used.
820 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
821
cf7cff57
PE
822 * keymap.c (access_keymap_1): Now static.
823
7a8e04f7
CY
8242011-07-02 Chong Yidong <cyd@stupidchicken.com>
825
826 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
827 leave any prefix arg for the up event (Bug#1586).
828
61352f62
LMI
8292011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
830
69bb1ef7
LMI
831 * lread.c (syms_of_lread): Mention single symbols defined by
832 `defvar' or `defconst' (bug#7154).
833
61352f62 834 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 835 (Frequire): Mention get-load-suffixes.
61352f62 836
28545e04
MR
8372011-07-02 Martin Rudalics <rudalics@gmx.at>
838
839 * window.h (window): Remove clone_number slot.
840 * window.c (Fwindow_clone_number, Fset_window_clone_number):
841 Remove.
842 (make_parent_window, make_window, saved_window)
843 (Fset_window_configuration, save_window_save): Don't deal with
844 clone numbers.
845 * buffer.c (Qclone_number): Remove declaration.
846 (sort_overlays, overlay_strings): Don't deal with clone numbers.
847
3349e122
SM
8482011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
849
850 Add multiple inheritance to keymaps.
851 * keymap.c (Fmake_composed_keymap): New function.
852 (Fset_keymap_parent): Simplify.
853 (fix_submap_inheritance): Remove.
854 (access_keymap_1): New function extracted from access_keymap to handle
855 embedded parents and handle lists of maps.
856 (access_keymap): Use it.
857 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
858 (Fcopy_keymap): Handle embedded parents.
859 (Fcommand_remapping, define_as_prefix): Simplify.
860 (Fkey_binding): Simplify.
861 (syms_of_keymap): Move minibuffer-local-completion-map,
862 minibuffer-local-filename-completion-map,
863 minibuffer-local-must-match-map, and
864 minibuffer-local-filename-must-match-map to Elisp.
865 (syms_of_keymap): Defsubr make-composed-keymap.
866 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
867 (parse_menu_item): Trivial simplification.
868
3279eb87
GM
8692011-07-01 Glenn Morris <rgm@gnu.org>
870
871 * Makefile.in (SETTINGS_LIBS): Fix typo.
872
4550efdf
KI
8732011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
874
875 * coding.c (Fencode_coding_string): Record the last coding system
876 used, as the function doc string says (bug#8738).
877
0949d2b6
JD
8782011-07-01 Jan Djärv <jan.h.d@swipnet.se>
879
880 * xsettings.c (store_monospaced_changed): Take new font as arg and
881 check for change against current_mono_font.
882 (EMACS_TYPE_SETTINGS): Remove this and related defines.
883 (emacs_settings_constructor, emacs_settings_get_property)
884 (emacs_settings_set_property, emacs_settings_class_init)
885 (emacs_settings_init, gsettings_obj): Remove.
886 (something_changedCB): New function for HAVE_GSETTINGS.
887 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
888 with value as argument.
889 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
890 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 891 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
892 "changed".
893
894 * xgselect.c: Add defined (HAVE_GSETTINGS).
895 (xgselect_initialize): Ditto.
896
897 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
898 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
899 xg_select.
900
bbc6b304
PE
9012011-07-01 Paul Eggert <eggert@cs.ucla.edu>
902
903 * eval.c (struct backtrace): Simplify and port the data structure.
904 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
905 signed bit field, as this assumption is not portable and it makes
906 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
907 "char debug_on_exit : 1" as this is not portable either; instead,
908 use the portable "unsigned int debug_on_exit : 1". Remove unused
909 member evalargs. Remove obsolete comments about cc bombing out.
910
9851bfc5
JD
9112011-06-30 Jan Djärv <jan.h.d@swipnet.se>
912
51bb811f 913 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
914 Let HAVE_GSETTINGS override HAVE_GCONF.
915 (store_monospaced_changed): New function.
916 (EMACS_SETTINGS): A new type derived from GObject to handle
917 GSettings notifications.
918 (emacs_settings_constructor, emacs_settings_get_property)
919 (emacs_settings_set_property, emacs_settings_class_init):
920 New functions.
921 (gsettings_client, gsettings_obj): New variables.
922 (GSETTINGS_SCHEMA): New define.
923 (something_changedCB): Call store_monospaced_changed.
924 (init_gsettings): New function.
925 (xsettings_initialize): Call init_gsettings.
926 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
927 to NULL.
928
929 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
930 GCONF_CFLAGS/LIBS.
931
5386012d
MR
9322011-06-29 Martin Rudalics <rudalics@gmx.at>
933
934 * window.c (resize_root_window, grow_mini_window)
935 (shrink_mini_window): Rename Qresize_root_window to
936 Qwindow_resize_root_window and Qresize_root_window_vertically to
937 Qwindow_resize_root_window_vertically.
938
f13e0b08
PE
9392011-06-28 Paul Eggert <eggert@cs.ucla.edu>
940
941 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
942
94515237
JB
9432011-06-27 Juanma Barranquero <lekktu@gmail.com>
944
945 * makefile.w32-in: Redesign dependencies so they reflect more
946 clearly which files are directly included by each source file,
947 and not through other includes.
948
e43b6e43
MR
9492011-06-27 Martin Rudalics <rudalics@gmx.at>
950
951 * buffer.c (Qclone_number): Declare static and DEFSYM it.
952 (sort_overlays, overlay_strings): When an overlay's clone number
953 matches the window's clone number process the overlay even if
954 the overlay's window property doesn't match the current window.
955
d68443dc
MR
956 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
957 (Fwindow_hchild): Rename to Fwindow_left_child.
958 (Fwindow_next): Rename to Fwindow_next_sibling.
959 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
960 (resize_window_check): Rename to window_resize_check.
961 (resize_window_apply): Rename to window_resize_apply.
962 (Fresize_window_apply): Rename to Fwindow_resize_apply.
963 (Fdelete_other_windows_internal, resize_frame_windows)
964 (Fsplit_window_internal, Fdelete_window_internal)
965 (grow_mini_window, shrink_mini_window)
966 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 967
c7e73be5
JD
9682011-06-26 Jan Djärv <jan.h.d@swipnet.se>
969
970 * emacsgtkfixed.h: State that this is only used with Gtk+3.
971 (emacs_fixed_set_min_size): Remove.
972 (emacs_fixed_new): Take frame as argument.
973
974 * emacsgtkfixed.c: State that this is only used with Gtk+3.
975 (_EmacsFixedPrivate): Remove minwidth/height.
976 Add struct frame *f.
977 (emacs_fixed_init): Initialize priv->f.
978 (get_parent_class, emacs_fixed_set_min_size): Remove.
979 (emacs_fixed_new): Set priv->f to argument.
980 (emacs_fixed_get_preferred_width)
981 (emacs_fixed_get_preferred_height): Use min_width/height from
982 frames size_hint to set minimum and natural (Bug#8919).
983 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
984 and use min_width/height from frames size_hint to set
985 min_width/height (Bug#8919).
986
987 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
988 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
989 Fix indentation.
c7e73be5 990
cf99dcf8
EZ
9912011-06-26 Eli Zaretskii <eliz@gnu.org>
992
993 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
994 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
995 called at ZV.
996
029529ac
CY
9972011-06-26 Chong Yidong <cyd@stupidchicken.com>
998
999 * process.c (wait_reading_process_output): Bypass select if
1000 waiting for a cell while ignoring keyboard input, and input is
1001 pending. Suggested by Jan Djärv (Bug#8869).
1002
7a7ef429
PE
10032011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1004
1005 Use gnulib's dup2 module instead of rolling our own.
1006 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1007
11fdef7d 10082011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1009
1010 * dispnew.c (scrolling_window): Before scrolling, turn off a
1011 mouse-highlight in the window being scrolled.
1012
cd3520a4
JB
10132011-06-24 Juanma Barranquero <lekktu@gmail.com>
1014
1015 Move DEFSYM to lisp.h and use everywhere.
1016
1017 * character.h (DEFSYM): Move declaration...
1018 * lisp.h (DEFSYM): ...here.
1019
1020 * gnutls.c:
1021 * minibuf.c:
1022 * w32menu.c:
1023 * w32proc.c:
1024 * w32select.c: Don't include character.h.
1025
1026 * alloc.c (syms_of_alloc):
1027 * buffer.c (syms_of_buffer):
1028 * bytecode.c (syms_of_bytecode):
1029 * callint.c (syms_of_callint):
1030 * casefiddle.c (syms_of_casefiddle):
1031 * casetab.c (init_casetab_once):
1032 * category.c (init_category_once, syms_of_category):
1033 * ccl.c (syms_of_ccl):
1034 * cmds.c (syms_of_cmds):
1035 * composite.c (syms_of_composite):
1036 * dbusbind.c (syms_of_dbusbind):
1037 * dired.c (syms_of_dired):
1038 * dispnew.c (syms_of_display):
1039 * doc.c (syms_of_doc):
1040 * editfns.c (syms_of_editfns):
1041 * emacs.c (syms_of_emacs):
1042 * eval.c (syms_of_eval):
1043 * fileio.c (syms_of_fileio):
1044 * fns.c (syms_of_fns):
1045 * frame.c (syms_of_frame):
1046 * fringe.c (syms_of_fringe):
1047 * insdel.c (syms_of_insdel):
1048 * keymap.c (syms_of_keymap):
1049 * lread.c (init_obarray, syms_of_lread):
1050 * macros.c (syms_of_macros):
1051 * msdos.c (syms_of_msdos):
1052 * print.c (syms_of_print):
1053 * process.c (syms_of_process):
1054 * search.c (syms_of_search):
1055 * sound.c (syms_of_sound):
1056 * syntax.c (init_syntax_once, syms_of_syntax):
1057 * terminal.c (syms_of_terminal):
1058 * textprop.c (syms_of_textprop):
1059 * undo.c (syms_of_undo):
1060 * w32.c (globals_of_w32):
1061 * window.c (syms_of_window):
1062 * xdisp.c (syms_of_xdisp):
1063 * xfaces.c (syms_of_xfaces):
1064 * xfns.c (syms_of_xfns):
1065 * xmenu.c (syms_of_xmenu):
1066 * xsettings.c (syms_of_xsettings):
1067 * xterm.c (syms_of_xterm): Use DEFSYM.
1068
4228cf16
TZ
10692011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1070
cd3520a4 1071 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1072
7fcccf1e
PE
10732011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1074
7efb4e0e
PE
1075 Integer and buffer overflow fixes (Bug#8873).
1076
ff5844ad
PE
1077 * print.c (printchar, strout): Check for string overflow.
1078 (PRINTPREPARE, printchar, strout):
1079 Don't set size unless allocation succeeds.
1080
90532f02
PE
1081 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1082 for sizes. Check for string overflow more accurately.
1083 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1084
6d84508d
PE
1085 * macros.c: Integer and buffer overflow fixes.
1086 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1087 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1088 Use ptrdiff_t, not int, for sizes.
1089 Don't increment bufsize until after realloc succeeds.
1090 Check for size-calculation overflow.
1091 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1092
437b2cb4
PE
1093 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1094
8b9ac8b4
PE
1095 * lread.c: Integer overflow fixes.
1096 (read_integer): Radix is now EMACS_INT, not int,
1097 to improve quality of diagnostics for out-of-range radices.
1098 Calculate buffer size correctly for out-of-range radices.
1099 (read1): Check for integer overflow in radices, and in
1100 read-circle numbers.
82cb60d3
PE
1101 (read_escape): Avoid int overflow.
1102 (Fload, openp, read_buffer_size, read1)
1103 (substitute_object_recurse, read_vector, read_list, map_obarray):
1104 Use ptrdiff_t, not int, for sizes.
1105 (read1): Use EMACS_INT, not int, for sizes.
20270765 1106 Check for size overflow.
8b9ac8b4 1107
7fcccf1e
PE
1108 * image.c (cache_image): Check for size arithmetic overflow.
1109
bfbbd7e7
PE
1110 * lread.c: Integer overflow issues.
1111 (saved_doc_string_size, saved_doc_string_length)
1112 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1113 Now ptrdiff_t, not int.
1114 (read1): Don't assume doc string length fits in int. Check for
1115 out-of-range doc string lengths.
1116 (read_list): Don't assume file position fits in int.
39019e54 1117 (read_escape): Check for hex character overflow.
bfbbd7e7 1118
4e323265
LL
11192011-06-22 Leo Liu <sdl.web@gmail.com>
1120
1121 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1122 Move to minibuffer.el.
1123
85fece3e
PE
11242011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1125
20b84ce9 1126 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1127 The following patches are for when GLYPH_DEBUG && !XASSERT.
1128 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1129 * dispnew.c (flush_stdout):
1130 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1131 Mark as externally visible.
1132 * dispnew.c (check_window_matrix_pointers): Now static.
1133 * dispnew.c (window_to_frame_vpos):
1134 * xfns.c (unwind_create_frame):
1135 * xterm.c (x_check_font): Remove unused local.
1136 * scroll.c (CHECK_BOUNDS):
1137 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1138 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1139 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1140 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1141 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1142 Now static.
1143 (debug_method_add): Use va_list and vsprintf rather than relying
1144 on undefined behavior with wrong number of arguments.
1145 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1146 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1147 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1148 since we're not interested in debugging glyphs with old libraries.
1149 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1150 GCC 4.6.0's static checking.
1151
0766b489
PE
11522011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1153
31fd4b32
PE
1154 Integer overflow and signedness fixes (Bug#8873).
1155 A few related buffer overrun fixes, too.
1156
b79e8648
PE
1157 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1158
0766b489
PE
1159 * dispextern.h (struct face.stipple):
1160 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1161 (x_bitmap_mask, x_allocate_bitmap_record)
1162 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1163 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1164 (x_create_bitmap_from_xpm_data):
1165 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1166 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1167 (.bitmaps_last):
1168 * xfaces.c (load_pixmap):
1169 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1170 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1171 (.bitmaps_last, struct x_output.icon_bitmap):
1172 Use ptrdiff_t, not int, for bitmap indexes.
1173 (x_allocate_bitmap_record): Check for size overflow.
1174 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1175
b081724f
PE
1176 Use ptrdiff_t, not int, for overlay counts.
1177 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1178 * editfns.c (overlays_around, get_pos_property):
1179 * textprop.c (get_char_property_and_overlay):
1180 * xdisp.c (next_overlay_change, note_mouse_highlight):
1181 * xfaces.c (face_at_buffer_position):
21514da7
PE
1182 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1183 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1184 (Fnext_overlay_change, Fprevious_overlay_change)
1185 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1186 Use ptrdiff_t, not int, for sizes.
21514da7 1187 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1188
3de73e5e
PE
1189 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1190
2606c57b
PE
1191 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1192 (x_session_initialize): Do not assume string length fits in int.
1193
aaafe47a
PE
1194 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1195 This is unlikely, but can occur if DPI is outlandish.
1196
2674ddc8 1197 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1198 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1199
28154962
PE
1200 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1201 * xrdb.c (magic_file_p, search_magic_path):
1202 Omit last arg SUFFIX; it was always 0. All callers changed.
1203 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1204
7de51af5
PE
1205 * xfont.c (xfont_match): Avoid need for strlen.
1206
25ed6cc3
PE
1207 * xfns.c: Don't assume strlen fits in int.
1208 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1209
4eab31dd
PE
1210 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1211 not unsigned long, as we prefer signed integers. All callers changed.
1212 Detect integer overflow in repeat count.
1213 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1214 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1215
171e2a58
PE
1216 * termcap.c: Don't assume sizes fit in int and never overflow.
1217 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1218 (gobble_line): Check for size-calculation overflow.
1219
ad39faca 1220 * minibuf.c (Fread_buffer):
6e5bb2dc 1221 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1222 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1223 Don't assume string length fits in int.
1224
52c61c22 1225 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1226 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1227
b5b8c9e5
PE
1228 * font.c: Don't assume string length fits in int.
1229 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1230 Use ptrdiff_t, not int.
ccd6111c
PE
1231 (font_intern_prop): Don't assume string length fits in int.
1232 Don't assume integer property fits in fixnum.
1233 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1234
882f0d81 1235 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1236 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1237 Reformulate so as not to need the command string.
1238 Invoke gzip -cd rather than gunzip, as it's more portable.
1239 (lock_info_type, lock_file_1, lock_file):
1240 Don't assume pid_t and time_t fit in unsigned long.
1241 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1242 (current_lock_owner): Prefer signed type for sizes.
1243 Use memcpy, not strncpy, where memcpy is what is really wanted.
1244 Don't assume (via atoi) that time_t and pid_t fit in int.
1245 Check for time_t and/or pid_t out of range, e.g., via a network share.
1246 Don't alloca where an auto var works fine.
1247
93f4cf88
PE
1248 * fileio.c: Fix some integer overflow issues.
1249 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1250 Don't assume string length fits in int.
1251 (directory_file_name): Don't assume string length fits in long.
1252 (make_temp_name): Don't assume pid fits in int, or that its print
1253 length is less than 20.
1254
f3e92b69
PE
1255 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1256
1bfdaf10
PE
1257 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1258
35016e9a
PE
1259 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1260
3d1e65a1
PE
1261 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1262 We prefer signed integers, even for size calculations.
1263
0b963a93
PE
1264 * emacs.c: Don't assume string length fits in 'int'.
1265 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1266 (main): Don't invoke strlen when not needed.
1267
573f4b54
PE
1268 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1269 (XD_DEBUG_MESSAGE): Don't waste a byte.
1270
989f33ba
PE
1271 * callproc.c (getenv_internal_1, getenv_internal)
1272 (Fgetenv_internal):
965d34eb
PE
1273 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1274
e4d29b33
PE
1275 * lread.c (invalid_syntax): Omit length argument.
1276 All uses changed. This doesn't fix a bug, but it simplifies the
1277 code away from its former Hollerith-constant appearance, and it's
1278 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1279 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1280
eb49b136
PE
1281 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1282 This didn't break anything, but it didn't help either.
1283 It's confusing to put a bogus integer in a place where the actual
1284 value does not matter.
9f62aeb1 1285 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1286 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1287
15375a22
PE
1288 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1289 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1290 implementation.
b61cc01c
PE
1291 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1292 We prefer signed types, and the value cannot exceed the EMACS_INT
1293 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1294 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1295 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1296 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1297
53b2623d
PE
1298 * indent.c (sane_tab_width): New function.
1299 (current_column, scan_for_column, Findent_to, position_indentation)
1300 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1301 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1302
51cab52b 1303 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1304
f2ed8a70
PE
1305 * lisp.h (lint_assume): New macro.
1306 * composite.c (composition_gstring_put_cache):
1307 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1308
abe80cc6
PE
1309 * editfns.c, insdel.c:
1310 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1311
b02c740e
PE
1312 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1313
ebc96716
PE
1314 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1315
b4e50fa0 1316 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1317 Use much-faster test for byte-length change.
311d5d7c 1318 Don't assume string byte-length fits in 'int'.
a4cf38e4 1319 Check that character arg fits in 'int'.
85461888 1320 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1321
c0c1ee9f
PE
1322 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1323
a498d7f4
PE
1324 * fns.c (concat): Catch string overflow earlier.
1325 Do not rely on integer wraparound.
1326
51cab52b
PE
1327 * dispextern.h (struct it.overlay_strings_charpos)
1328 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1329 * xdisp.c (forward_to_next_line_start)
1330 (back_to_previous_visible_line_start)
1331 (reseat_at_next_visible_line_start, next_element_from_buffer):
1332 Don't arbitrarily truncate the value of 'selective' to int.
1333
76031fad
PE
1334 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1335
5eb55db9
PE
1336 * composite.c: Don't truncate sizes to 'int'.
1337 (composition_gstring_p, composition_reseat_it)
1338 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1339 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1340 not EMACS_UINT, for indexes.
5eb55db9 1341
0703a717
PE
1342 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1343
d6202519
PE
1344 * buffer.c: Include <verify.h>.
1345 (struct sortvec.priority, struct sortstr.priority):
8961a454 1346 Now EMACS_INT, not int.
c20998a7 1347 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1348 (struct sortstr.size, record_overlay_string)
1349 (struct sortstrlist.size, struct sortlist.used):
1350 Don't truncate size to int.
1351 (record_overlay_string): Check for size-calculation overflow.
d6202519 1352 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1353
d5a19415
JM
13542011-06-22 Jim Meyering <meyering@redhat.com>
1355
029529ac 1356 Don't leak an XBM-image-sized buffer
d5a19415
JM
1357 * image.c (xbm_load): Free the image buffer after using it.
1358
a9041e6c
PE
13592011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1360
1361 Port to Sun C.
1362 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1363 that Sun C diagnosed.
1364 * fns.c (secure_hash): Fix pointer signedness issue.
1365 * intervals.c (static_offset_intervals): New function.
1366 (offset_intervals): Use it.
1367
7f3f739f
LL
13682011-06-21 Leo Liu <sdl.web@gmail.com>
1369
1370 * deps.mk (fns.o):
1371 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1372 sha512.h.
1373
1374 * fns.c (secure_hash): Rename from crypto_hash_function and change
1375 the first arg to accept symbols.
5b66d427 1376 (Fsecure_hash): New primitive.
7f3f739f
LL
1377 (syms_of_fns): New symbols.
1378
76147d94
DD
13792011-06-20 Deniz Dogan <deniz@dogan.se>
1380
1381 * process.c (Fset_process_buffer): Clarify return value in
1382 docstring.
1383
7d7d0045
CY
13842011-06-18 Chong Yidong <cyd@stupidchicken.com>
1385
1386 * dispnew.c (add_window_display_history): Use BVAR.
1387
1388 * xdisp.c (debug_method_add): Use BVAR.
1389 (check_window_end, dump_glyph_matrix, dump_glyph)
1390 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1391
1392 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1393 Likewise.
1394
1395 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1396 check till after the cache is created in init_frame_faces.
1397
ff2bc410
SM
13982011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1399
1400 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1401
28177add
PE
14022011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1403
dd3482fe
PE
1404 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1405 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1406 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1407
393d71f3 1408 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1409 * fileio.c (Finsert_file_contents):
1410 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1411 Remove the old (too-loose) buffer overflow checks.
1412 They weren't needed, since make_gap checks for buffer overflow.
1413 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1414 The old code merely checked for Emacs fixnum overflow, and relied
1415 on undefined (wraparound) behavior. The new code avoids undefined
1416 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1417
2e6813b0 1418 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1419 Tune. Don't use wider integers than needed. Don't use alloca.
1420 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1421
599a9e4f
PE
1422 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1423
99561444
PE
1424 * insdel.c, lisp.h (buffer_overflow): New function.
1425 (insert_from_buffer_1, replace_range, replace_range_2):
1426 * insdel.c (make_gap_larger):
1427 * editfns.c (Finsert_char):
1428 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1429
28177add
PE
1430 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1431
e69dafad
PE
14322011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1433
a7af7fde 1434 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1435
b1c46f02
PE
1436 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1437 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1438
e69dafad
PE
1439 * fileio.c: Don't assume EMACS_INT fits in off_t.
1440 (emacs_lseek): New static function.
1441 (Finsert_file_contents, Fwrite_region): Use it.
1442 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1443
566684ea
PE
1444 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1445
e6966cd6
PE
1446 * fns.c: Don't overflow int when computing a list length.
1447 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1448 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1449 truncation on 64-bit hosts. Check for QUIT every
1450 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1451 faster and is responsive enough.
1452 (Flength): Report an error instead of overflowing an integer.
1453 (Fsafe_length): Return a float if the value is not representable
1454 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1455 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1456 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1457
dd0b0efb
PE
1458 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1459 (header_size, word_size): New constants.
1460 (allocate_vectorlike): Don't check size overflow here.
1461 (allocate_vector): Check it here instead, since this is the only
1462 caller of allocate_vectorlike that could cause overflow.
1463 Check that the new vector's length is representable as a fixnum.
1464
86fe5cfe
PE
1465 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1466 The previous code was bogus. For example, next_almost_prime (32)
1467 returned 39, which is undesirable as it is a multiple of 3; and
1468 next_almost_prime (24) returned 25, which is a multiple of 5 so
1469 why was the code bothering to check for multiples of 7?
1470
80e88859
PE
1471 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1472
4a2f0ad6
PE
1473 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1474
f66c7cf8
PE
1475 Variadic C functions now count arguments with ptrdiff_t.
1476 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1477 Back then I didn't know that the Emacs coding style prefers signed int.
1478 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1479 were being counted with int, which may truncate counts on 64-bit
1480 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1481 * lisp.h (struct Lisp_Subr.function.aMANY)
1482 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1483 Arg counts are now ptrdiff_t, not size_t.
1484 All variadic functions and their callers changed accordingly.
1485 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1486 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1487 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1488 * callint.c (Fcall_interactively): Check arg count for overflow,
1489 to avoid potential buffer overrun. Use signed char, not 'int',
1490 for 'varies' array, so that we needn't bother to check its size
1491 calculation for overflow.
1492 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1493 * eval.c (apply_lambda):
1494 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1495 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1496 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1497
a1759b76
PE
1498 * callint.c (Fcall_interactively): Don't use index var as event count.
1499
d96be9fc
PE
1500 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1501 * mem-limits.h (SIZE): Remove; no longer used.
1502
a690a978 1503 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1504
578c21e6
PE
1505 Remove unnecessary casts.
1506 * xterm.c (x_term_init):
1507 * xfns.c (x_set_border_pixel):
1508 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1509 These aren't needed now that we assume ANSI C.
1510
96f53c6c
PE
1511 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1512 It's more likely to cause problems (due to unsigned overflow)
1513 than to cure them.
1514
83c77d31
PE
1515 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1516
ee2079f1
PE
1517 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1518
6da65536
PE
1519 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1520
7147c4a4
PE
1521 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1522
193e32d9
PE
1523 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1524
e5533da6
PE
1525 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1526
9910e595
PE
1527 GLYPH_CODE_FACE returns EMACS_INT, not int.
1528 * dispextern.h (merge_faces):
1529 * xfaces.c (merge_faces):
01103c44
PE
1530 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1531 Don't assume EMACS_INT fits in int.
9910e595 1532
2638320e
PE
1533 * character.h (CHAR_VALID_P): Remove unused parameter.
1534 * fontset.c, lisp.h, xdisp.c: All uses changed.
1535
045eb8d9
PE
1536 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1537
c1f134b5
PE
1538 * fns.c (concat): Minor tuning based on overflow analysis.
1539 This doesn't fix any bugs. Use int to hold character, instead
1540 of constantly refetching from Emacs object. Use XFASTINT, not
1541 XINT, for value known to be a character. Don't bother comparing
1542 a single byte to 0400, as it's always less.
1543
395fcb93 1544 * floatfns.c (Fexpt):
327eeec8
PE
1545 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1546
abbd3d23
PE
1547 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1548 for characters.
1549
684a03ef
PE
1550 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1551
0fed43f3
PE
1552 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1553 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1554 incorrectly succeed when S was a string, because 4294967386 was
1555 truncated before it was used.
1556
8fd02eb7
PE
1557 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1558 Otherwise, an out-of-range integer could cause undefined behavior
1559 on a 64-bit host.
1560
f8c86b69
PE
1561 * composite.c: Use int, not EMACS_INT, for characters.
1562 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1563 EMACS_INT, for values that are known to be in character range.
1564 This doesn't fix any bugs but is the usual style inside Emacs and
1565 may generate better code on 32-bit machines.
1566
34206dd2
PE
1567 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1568 This is for reasons similar to the recent CHAR_STRING fix.
1569 * charset.c (Fencode_char): Check that character arg is actually
1570 a character. Pass an int to ENCODE_CHAR.
1571 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1572 wider than 'int', as a compile-time check to prevent future regressions
1573 in this area.
1574
c5958d4c 1575 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1576
1577 Make sure a 64-bit char is never passed to CHAR_STRING.
1578 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1579 by silently ignoring the top 32 bits, allowing some values
1580 that were far too large to be valid characters.
1581 * character.h: Include <verify.h>.
1582 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1583 arguments are no wider than unsigned, as a compile-time check
1584 to prevent future regressions in this area.
1585 * data.c (Faset):
01103c44 1586 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1587 (Fsubst_char_in_region):
1588 * fns.c (concat):
1589 * xdisp.c (decode_mode_spec_coding):
1590 Adjust to CHAR_STRING's new requirement.
1591 * editfns.c (Finsert_char, Fsubst_char_in_region):
1592 * fns.c (concat): Check that character args are actually
1593 characters. Without this test, these functions did the wrong
1594 thing with wildly out-of-range values on 64-bit hosts.
1595
d37ca623
PE
1596 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1597 These casts should not be needed on 32-bit hosts, either.
1598 * keyboard.c (read_char):
1599 * lread.c (Fload): Remove casts to unsigned.
1600
ea204efb
PE
1601 * lisp.h (UNSIGNED_CMP): New macro.
1602 This fixes comparison bugs on 64-bit hosts.
1603 (ASCII_CHAR_P): Use it.
1604 * casefiddle.c (casify_object):
01103c44 1605 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1606 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1607 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1608 * dispextern.h (FACE_FROM_ID):
1609 * keyboard.c (read_char): Use UNSIGNED_CMP.
1610
41cb286c
PE
1611 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1612 not to EMACS_INT, to avoid GCC warning.
1613
4a1b9832
PE
1614 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1615
55daad71
PE
1616 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1617 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1618 isn't needed on 32-bit machines.
8f95c75c 1619
01103c44
PE
1620 * buffer.c (Fgenerate_new_buffer_name):
1621 Use EMACS_INT for count, not int.
0ceccced 1622 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1623
1624 * data.c (Qcompiled_function): Now static.
1625
c6f072e7
PE
1626 * window.c (window_body_lines): Now static.
1627
20ce5912
PE
1628 * image.c (gif_load): Rename local to avoid shadowing.
1629
9c4c5f81
PE
1630 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1631 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1632 * alloc.c (make_save_value): Integer argument is now of type
1633 ptrdiff_t, not int.
1634 (mark_object): Use ptrdiff_t, not int.
1635 * lisp.h (pD): New macro.
1636 * print.c (print_object): Use it.
1637
c0c5c8ae
PE
1638 * alloc.c: Use EMACS_INT, not int, to count objects.
1639 (total_conses, total_markers, total_symbols, total_vector_size)
1640 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1641 (total_free_floats, total_floats, total_free_intervals)
1642 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1643 Now EMACS_INT, not int. All uses changed.
1644 (Fgarbage_collect): Compute overall total using a double, so that
1645 integer overflow is less likely to be a problem. Check for overflow
1646 when converting back to an integer.
5a25e253
PE
1647 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1648 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1649 These were 'int' variables that could overflow on 64-bit hosts;
1650 they were never used, so remove them instead of repairing them.
211a0b2a 1651 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1652 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1653 Previously, this ceilinged at INT_MAX, but that doesn't work on
1654 64-bit machines.
e46bb31a 1655 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1656
c78baabf 1657 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1658 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1659 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1660 when a (possibly-narrower) signed value would do just as well.
1661 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1662
c9d624c6
PE
1663 * alloc.c: Catch some string size overflows that we were missing.
1664 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1665 for convenience in STRING_BYTES_MAX.
1666 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1667 The definition here is exact; the one in lisp.h was approximate.
1668 (allocate_string_data): Check for string overflow. This catches
1669 some instances we weren't catching before. Also, it catches
1670 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1671 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1672 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1673
c9d624c6
PE
1674 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1675 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1676 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1677
353032ce
PE
1678 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1679
2bccce07
PE
1680 * alloc.c (Fmake_string): Check for out-of-range init.
1681
0ac30604
SM
16822011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1683
1684 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1685
c195f2de
JD
16862011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1687
1688 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1689 xg_get_default_scrollbar_width.
1690
1691 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1692 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1693 (style_changed_cb): Call update_theme_scrollbar_width and call
1694 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1695 all frames (Bug#8505).
1696 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1697 Call gtk_window_set_resizable if HAVE_GTK3.
1698 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1699 and height if HAVE_GTK3 (Bug#8505).
1700 (scroll_bar_width_for_theme): New variable.
1701 (update_theme_scrollbar_width): New function.
1702 (xg_get_default_scrollbar_width): Move code to
1703 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1704 (xg_initialize): Call update_theme_scrollbar_width.
1705
1706 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1707
1708 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1709
e10ac9f1
MR
17102011-06-12 Martin Rudalics <rudalics@gmx.at>
1711
1712 * frame.c (make_frame): Call other_buffer_safely instead of
1713 other_buffer.
1714
1715 * window.c (temp_output_buffer_show): Call display_buffer with
1716 second argument Vtemp_buffer_show_specifiers and reset latter
1717 immediately after the call.
1718 (Vtemp_buffer_show_specifiers): New variable.
1719 (auto_window_vscroll_p, next_screen_context_lines)
1720 (Vscroll_preserve_screen_position): Remove leading asterisks from
1721 doc-strings.
1722
2d3c217e 17232011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1724
7b7f97e8 1725 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1726 * buffer.c (Qclone_number): Remove for now, as it's unused.
1727 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1728 (record_buffer): Remove unused local.
1729 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1730 (set_frame_buffer_list): Remove; unused.
1731 * frame.h (other_visible_frames): Remove decl.
1732 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1733 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1734 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1735 if HAVE_GPM.
1736 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1737 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1738 Define only if HAVE_GPM.
1739 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1740 (update_hints_inhibit): Remove; never set. All uses removed.
1741 * widgetprv.h (emacsFrameClassRec): Remove decl.
1742 * window.c (delete_deletable_window): Now returns void, since it
1743 wasn't returning anything.
1744 (compare_window_configurations): Remove unused locals.
1745 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1746 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1747 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1748 the same widths as pointers. This follows up on the 2011-05-06 patch.
1749 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1750 * xterm.h: Likewise.
1751 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1752
1384b89e
JB
17532011-06-12 Juanma Barranquero <lekktu@gmail.com>
1754
1755 * makefile.w32-in: Update dependencies.
1756 (LISP_H): Add lib/intprops.h.
1757
1100a63c
CY
17582011-06-11 Chong Yidong <cyd@stupidchicken.com>
1759
1760 * image.c (gif_load): Add animation frame delay to the metadata.
1761 (syms_of_image): Use DEFSYM. New symbol `delay'.
1762
6198ccd0
MR
17632011-06-11 Martin Rudalics <rudalics@gmx.at>
1764
1765 * window.c (delete_deletable_window): Re-add.
1766 (Fset_window_configuration): Rewrite to handle dead buffers and
1767 consequently deletable windows.
1768 (window_tree, Fwindow_tree): Remove. Supply functionality in
1769 window.el.
1770 (compare_window_configurations): Simplify code.
1771
b6e3633c
AS
17722011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1773
1ab0dee5
AS
1774 * image.c (imagemagick_load_image): Fix type mismatch.
1775 (Fimagemagick_types): Likewise.
1776
b6e3633c
AS
1777 * window.h (replace_buffer_in_windows): Declare.
1778
9397e56f
MR
17792011-06-11 Martin Rudalics <rudalics@gmx.at>
1780
1781 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1782 Qclone_number. Remove external declaration of Qdelete_window.
1783 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1784 code.
1785 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1786 Qbuffer_list_update_hook if allowed.
1787 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1788 buffer list implementation.
1789 (other_buffer_safely): New function.
1790 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1791 calls to replace_buffer_in_windows and
1792 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1793 if allowed.
1794 (record_buffer): Inhibit quitting and rewrite using quittable
1795 functions. Run Qbuffer_list_update_hook if allowed.
1796 (Frecord_buffer, Funrecord_buffer): New functions.
1797 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1798 switch-to-buffer to window.el.
1799 (bury-buffer): Move to window.el.
1800 (Vbuffer_list_update_hook): New variable.
1801
1802 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1803 section.
1804
1805 * window.h (resize_frame_windows): Move up in code.
1806 (Fwindow_frame): Remove EXFUN.
1807 (replace_buffer_in_all_windows): Remove prototype.
1808 (replace_buffer_in_windows_safely): Add prototype.
1809
1810 * window.c: Declare Qdelete_window static again. Move down
1811 declaration of select_count.
1812 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1813 (Fother_window): Move to window.el.
1814 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1815 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1816 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1817 window.el.
1818 (replace_buffer_in_windows): Implement by calling
1819 Qreplace_buffer_in_windows.
1820 (replace_buffer_in_all_windows): Remove with some functionality
1821 moved into replace_buffer_in_windows_safely.
1822 (replace_buffer_in_windows_safely): New function.
1823 (select_window_norecord, select_frame_norecord): Move in front
1824 of run_window_configuration_change_hook. Remove now obsolete
1825 declarations.
1826 (Fset_window_buffer): Rewrite doc-string. Call
1827 Qrecord_window_buffer.
1828 (keys_of_window): Move binding for other-window to window.el.
1829
b50691aa
CY
18302011-06-11 Chong Yidong <cyd@stupidchicken.com>
1831
1832 * dispextern.h (struct image): Replace data member, whose int_val
1833 and ptr_val fields were not used by anything, with a single
1834 lisp_val object.
1835
1836 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1837 (gif_clear_image, gif_load, imagemagick_load_image)
1838 (gs_clear_image, gs_load): Callers changed.
1839
3f754b86
PE
18402011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1841
cca69397
PE
1842 * buffer.h: Include <time.h>, for time_t.
1843 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1844
109e28d0
PE
1845 Fix minor problems found by static checking.
1846
60737f02
PE
1847 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1848
4b66faf3
PE
1849 Make identifiers static if they are not used in other modules.
1850 * data.c (Qcompiled_function, Qframe, Qvector):
1851 * image.c (QimageMagick, Qsvg):
1852 * minibuf.c (Qmetadata):
1853 * window.c (resize_window_check, resize_root_window): Now static.
1854 * window.h (resize_window_check, resize_root_window): Remove decls.
1855
109e28d0
PE
1856 * window.c (window_deletion_count, delete_deletable_window):
1857 Remove; unused.
46a4ce9e
PE
1858 (window_body_lines): Now static.
1859 (Fdelete_other_windows_internal): Mark vars as initialized.
1860 Make sure 'resize_failed' is initialized.
1861 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1862 (resize_window_apply): Remove unused local.
1863 * window.h (delete_deletable_window): Remove decl.
1864
109e28d0 1865 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1866 (imagemagick_load_image): Fix pointer signedness problem by changing
1867 last arg from unsigned char * to char *. All uses changed.
1868 Also, fix a local for similar reasons.
1869 Remove unused locals. Remove locals to avoid shadowing.
1870 (fn_rsvg_handle_free): Remove; unused.
1871 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1872 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1873
3f754b86
PE
1874 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1875
2547adb1
CY
18762011-06-10 Chong Yidong <cyd@stupidchicken.com>
1877
1878 * image.c (gif_load): Fix omitted cast error introduced by
1879 2011-06-06 change.
1880
2c8e37d4
MR
18812011-06-10 Martin Rudalics <rudalics@gmx.at>
1882
1883 * window.h (resize_proportionally, orig_total_lines)
1884 (orig_top_line): Remove from window structure.
1885 (set_window_height, set_window_width, change_window_heights)
1886 (Fdelete_window): Remove prototypes.
1887 (resize_frame_windows): Remove duplicate declaration.
1888
440a42e3
EZ
18892011-06-10 Eli Zaretskii <eliz@gnu.org>
1890
1891 * window.h (resize_frame_windows, resize_window_check)
1892 (delete_deletable_window, resize_root_window)
1893 (resize_frame_windows): Declare prototypes.
1894
1895 * window.c (resize_window_apply): Make definition be "static" to
1896 match the prototype.
1897
562dd5e9
MR
18982011-06-10 Martin Rudalics <rudalics@gmx.at>
1899
1900 * window.c: Remove declarations of Qwindow_size_fixed,
1901 window_min_size_1, window_min_size_2, window_min_size,
1902 size_window, window_fixed_size_p, enlarge_window, delete_window.
1903 Remove static from declaration of Qdelete_window, it's
1904 temporarily needed by Fbury_buffer.
1905 (replace_window): Don't assign orig_top_line and
1906 orig_total_lines.
1907 (Fdelete_window, delete_window): Remove. Window deletion is
1908 handled by window.el.
1909 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1910 Fdelete_window calls with calls to Qdelete_window.
1911 (Fdelete_other_windows): Remove. Deleting other windows is
1912 handled by window.el.
1913 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1914 handled in window.el.
1915 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1916 Window minimum sizes are handled in window.el.
1917 (shrink_windows, size_window, set_window_height)
1918 (set_window_width, change_window_heights, window_height)
1919 (window_width, CURBEG, CURSIZE, enlarge_window)
1920 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1921 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1922 handled in window.el.
1923 (make_dummy_parent): Rename to make_parent_window and give it a
1924 second argument horflag.
1925 (make_window): Don't set resize_proportionally any more.
1926 (Fsplit_window): Remove. Windows are split in window.el.
1927 (save_restore_action, save_restore_orig_size)
1928 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1929 Resize mini windows in window.el.
1930 (grow_mini_window, shrink_mini_window): Implement by calling
1931 Qresize_root_window_vertically, resize_window_check and
1932 resize_window_apply.
1933 (saved_window, Fset_window_configuration, save_window_save): Do
1934 not handle orig_top_line, orig_total_lines, and
1935 resize_proportionally.
1936 (window_min_height, window_min_width): Move to window.el.
1937 (keys_of_window): Move bindings for delete-other-windows,
1938 split-window, delete-window and enlarge-window to window.el.
1939
1940 * buffer.c: Temporarily extern Qdelete_window.
1941 (Fbury_buffer): Temporarily call Qdelete_window instead of
1942 Fdelete_window (Fbury_buffer will move to window.el soon).
1943
1944 * frame.c (set_menu_bar_lines_1): Remove code handling
1945 orig_top_line and orig_total_lines.
1946
1947 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1948 set_window_height but set heights directly.
1949 (change_frame_size_1): Use resize_frame_windows.
1950
1951 * xdisp.c (init_xdisp): Don't use set_window_height but set
1952 heights directly.
1953
1954 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1955 resize_frame_windows instead of change_window_heights and run
1956 run_window_configuration_change_hook.
1957
1958 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1959 instead of change_window_heights and run
1960 run_window_configuration_change_hook.
1961
1a13852e
MR
19622011-06-09 Martin Rudalics <rudalics@gmx.at>
1963
1964 * window.c (replace_window): Rename second argument REPLACEMENT to
1965 NEW. New third argument SETFLAG. Rewrite.
1966 (delete_window, make_dummy_parent): Call replace_window with
1967 third argument 1.
1968 (window_list_1): Move down in code.
1969 (run_window_configuration_change_hook): Move set_buffer part
1970 before select_frame_norecord part in order to unwind correctly.
1971 Rename count1 to count.
1972 (recombine_windows, delete_deletable_window, resize_root_window)
1973 (Fdelete_other_windows_internal)
1974 (Frun_window_configuration_change_hook, make_parent_window)
1975 (resize_window_check, resize_window_apply, Fresize_window_apply)
1976 (resize_frame_windows, Fsplit_window_internal)
1977 (Fdelete_window_internal, Fresize_mini_window_internal): New
1978 functions.
1979 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1980
f3d1777e
MR
19812011-06-08 Martin Rudalics <rudalics@gmx.at>
1982
496e208e
MR
1983 * window.h (window): Add some new members to window structure -
1984 normal_lines, normal_cols, new_total, new_normal, clone_number,
1985 splits, nest, prev_buffers, next_buffers.
1986 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1987 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1988
f3d1777e
MR
1989 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1990 Remove.
496e208e
MR
1991 (make_dummy_parent): Set new members of windows structure.
1992 (make_window): Move down in code. Handle new members of window
1993 structure.
1994 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1995 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1996 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1997 (Fset_window_prev_buffers, Fwindow_next_buffers)
1998 (Fset_window_next_buffers, Fset_window_clone_number): New
1999 functions.
2000 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2001 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2002 Doc-string fixes.
2003 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2004 Argument WINDOW can be now internal window too.
2005 (Fwindow_use_time): Move up in code.
2006 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2007 Rewrite doc-string.
2008 (Fset_window_configuration, saved_window)
2009 (Fcurrent_window_configuration, save_window_save): Handle new
2010 members of window structure.
b9e809c2
MR
2011 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2012 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2013 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2014 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2015 Qget_mru_window, Qresize_root_window,
2016 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2017 Qauto_buffer_name; staticpro them.
f3d1777e 2018
abde8f8c
MR
20192011-06-07 Martin Rudalics <rudalics@gmx.at>
2020
2021 * window.c (Fwindow_total_size, Fwindow_left_column)
2022 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2023 (Fwindow_list_1): New functions.
2024 (window_box_text_cols): Replace with window_body_cols.
2025 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2026 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2027 (delete_window, Fset_window_configuration): Call
2028 delete_all_subwindows with window as argument.
2029 (delete_all_subwindows): Take a window as argument and not a
2030 structure. Rewrite.
190b47e6
MR
2031 (window_loop): Remove handling of GET_LRU_WINDOW and
2032 GET_LARGEST_WINDOW.
2033 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2034
2035 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2036 window_box_text_cols. delete_all_subwindows now takes a
2037 Lisp_Object as argument.
abde8f8c
MR
2038
2039 * indent.c (compute_motion, Fcompute_motion): Use
2040 window_body_cols instead of window_box_text_cols.
2041
fa8a67e6
MR
2042 * frame.c (delete_frame): Call delete_all_subwindows with root
2043 window as argument.
2044
a54e3482
DC
20452011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2046
2047 * fns.c (Fputhash): Document return value.
2048
60002bf5
CY
20492011-06-06 Chong Yidong <cyd@stupidchicken.com>
2050
2051 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2052
0c671da6 20532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2054
b862a52a 2055 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2056
be44ca6c
PE
2057 Check for overflow when converting integer to cons and back.
2058 * charset.c (Fdefine_charset_internal, Fdecode_char):
2059 Use cons_to_unsigned to catch overflow.
2060 (Fencode_char): Use INTEGER_TO_CONS.
2061 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2062 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2063 * data.c (long_to_cons, cons_to_long): Remove.
2064 (cons_to_unsigned, cons_to_signed): New functions.
2065 These signal an error for invalid or out-of-range values.
2066 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2067 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2068 * font.c (Ffont_variation_glyphs):
2069 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2070 * lisp.h: Include <intprops.h>.
2071 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2072 (cons_to_signed, cons_to_unsigned): New decls.
2073 (long_to_cons, cons_to_long): Remove decls.
2074 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2075 (Fprimitive_undo): Use CONS_TO_INTEGER.
2076 * xfns.c (Fx_window_property): Likewise.
2077 * xselect.c: Include <limits.h>.
2078 (x_own_selection, selection_data_to_lisp_data):
2079 Use INTEGER_TO_CONS.
2080 (x_handle_selection_request, x_handle_selection_clear)
2081 (x_get_foreign_selection, Fx_disown_selection_internal)
2082 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2083 (lisp_data_to_selection_data): Use cons_to_unsigned.
2084 (x_fill_property_data): Use cons_to_signed.
2085 Report values out of range.
2086
d1f3d2af
PE
2087 Check for buffer and string overflow more precisely.
2088 * buffer.h (BUF_BYTES_MAX): New macro.
2089 * lisp.h (STRING_BYTES_MAX): New macro.
2090 * alloc.c (Fmake_string):
2091 * character.c (string_escape_byte8):
2092 * coding.c (coding_alloc_by_realloc):
2093 * doprnt.c (doprnt):
2094 * editfns.c (Fformat):
2095 * eval.c (verror):
2096 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2097 since they may not be the same number.
2098 * editfns.c (Finsert_char):
2099 * fileio.c (Finsert_file_contents):
2100 Likewise for BUF_BYTES_MAX.
2101
dd52fcea
PE
2102 * image.c: Use ptrdiff_t, not int, for sizes.
2103 (slurp_file): Switch from int to ptrdiff_t.
2104 All uses changed.
2105 (slurp_file): Check that file size fits in both size_t (for
2106 malloc) and ptrdiff_t (for sanity and safety).
2107
7f9bbdbb
PE
2108 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2109 if b->modtime has its maximal value.
2110
dfe18f82
PE
2111 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2112
84acfcf0
PE
2113 Don't assume time_t can fit into int.
2114 * buffer.h (struct buffer.modtime): Now time_t, not int.
2115 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2116 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2117
ccd9a01a
PE
2118 Minor fixes for signed vs unsigned integers.
2119 * character.h (MAYBE_UNIFY_CHAR):
2120 * charset.c (maybe_unify_char):
2121 * keyboard.c (read_char, reorder_modifiers):
2122 XINT -> XFASTINT, since the integer must be nonnegative.
2123 * ftfont.c (ftfont_spec_pattern):
2124 * keymap.c (access_keymap, silly_event_symbol_error):
2125 XUINT -> XFASTINT, since the integer must be nonnegative.
2126 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2127 since it makes no difference and we prefer signed.
2128 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2129 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2130 nonnegative.
2131
d6d100dd
SM
21322011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2133
2134 * window.h (Fwindow_frame): Declare.
2135
2b6148e4
PE
21362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2137
2138 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2139 (SPARE_MEMORY): Always define.
2140 (LARGE_REQUEST): Remove.
2141 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2142
f230ecc9
MR
21432011-06-06 Martin Rudalics <rudalics@gmx.at>
2144
727e958e
MR
2145 * lisp.h: Move EXFUNS for Fframe_root_window,
2146 Fframe_first_window and Fset_frame_selected_window to window.h.
2147
2148 * window.h: Move EXFUNS for Fframe_root_window,
2149 Fframe_first_window and Fset_frame_selected_window here from
2150 lisp.h.
2151
2152 * frame.c (Fwindow_frame, Fframe_first_window)
2153 (Fframe_root_window, Fframe_selected_window)
2154 (Fset_frame_selected_window): Move to window.c.
2155 (Factive_minibuffer_window): Move to minibuf.c.
2156 (Fother_visible_frames_p): New function.
2157
2158 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2159
f230ecc9
MR
2160 * window.c (decode_window, decode_any_window): Move up in code.
2161 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2162 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2163 (Fwindow_buffer): Move up and rewrite doc-string.
2164 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2165 (Fwindow_prev): New functions.
727e958e
MR
2166 (Fwindow_frame): Move here from frame.c. Accept any window as
2167 argument.
2168 (Fframe_root_window, Fframe_first_window)
2169 (Fframe_selected_window): Move here from frame.c. Accept frame
2170 or arbitrary window as argument. Update doc-strings.
2171 (Fminibuffer_window): Move up in code.
2172 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2173 (Fset_frame_selected_window): Move here from frame.c.
2174 Marginal rewrite.
727e958e
MR
2175 (Fselected_window, select_window, Fselect_window): Move up in
2176 code. Minor doc-string fixes.
f230ecc9 2177
4d09bcf6
PE
21782011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2179
2180 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2181 Do not assume that spare memory exists; that assumption is valid
2182 only if SYSTEM_MALLOC.
2183 (LARGE_REQUEST): New macro, so that the issue of large requests
2184 is separated from the issue of spare memory.
2185
810928a2
AS
21862011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2187
172418ad
AS
2188 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2189 format. (Bug#8806)
2190
43f862f7
AS
2191 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2192
810928a2
AS
2193 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2194 before statements.
2195
a059fe24
JD
21962011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2197
2198 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2199
2200 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2201
2202 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2203 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2204
989bf368
JB
22052011-06-05 Juanma Barranquero <lekktu@gmail.com>
2206
2207 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2208
4b80f674
CY
22092011-06-04 Chong Yidong <cyd@stupidchicken.com>
2210
2211 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2212 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2213 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2214 New error handlers.
4b80f674
CY
2215 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2216 Obey Vx_select_enable_clipboard_manager. Catch errors in
2217 x_clipboard_manager_save (Bug#8779).
2218 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2219 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2220
99a33b77 22212011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2222
2223 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2224
99a33b77 22252011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2226
2227 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2228 in the current matrix if keep_current_p is non-zero.
2229
8264569d
EZ
22302011-06-04 Eli Zaretskii <eliz@gnu.org>
2231
2232 * bidi.c (bidi_level_of_next_char): Fix last change.
2233
57f97249
EZ
22342011-06-03 Eli Zaretskii <eliz@gnu.org>
2235
fec2107c 2236 Support bidi reordering of text covered by display properties.
57f97249 2237
fec2107c
EZ
2238 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2239 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2240 (bidi_cache_search, bidi_cache_iterator_state)
2241 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2242 (bidi_level_of_next_char, bidi_move_to_visually_next):
2243 Support character positions inside a run of characters covered by a
fec2107c
EZ
2244 display string.
2245 (bidi_paragraph_init, bidi_resolve_explicit_1)
2246 (bidi_level_of_next_char): Call bidi_fetch_char and
2247 bidi_fetch_char_advance instead of FETCH_CHAR and
2248 FETCH_CHAR_ADVANCE.
2249 (bidi_init_it): Initialize new members.
2250 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2251 definitions.
2252 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2253 instead of using explicit *_CHAR codes.
d6d100dd
SM
2254 (bidi_resolve_explicit, bidi_resolve_weak):
2255 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2256 bidirectional text is supported only in multibyte buffers.
2257 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2258 it to initialize the frame_window_p member of struct bidi_it.
2259 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2260 (bidi_resolve_explicit, bidi_resolve_weak)
2261 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2262 bidi_it->nchars is non-positive.
2263 (bidi_level_of_next_char): Don't try to lookup the cache for the
2264 next/previous character if nothing is cached there yet, or if we
2265 were just reseat()'ed to a new position.
c40e2fb2 2266
0e14fe90
EZ
2267 * xdisp.c (set_cursor_from_row): Set start and stop points
2268 according to the row's direction when priming the loop that looks
2269 for the glyph on which to display cursor.
2270 (single_display_spec_intangible_p): Function deleted.
2271 (display_prop_intangible_p): Reimplement to call
2272 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2273 Accept 3 additional arguments needed by handle_display_spec.
2274 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2275 values: lists, `(when COND...)' forms, etc.
2276 (single_display_spec_string_p): Support property values that are
2277 lists with the argument STRING its top-level element.
2278 (display_prop_string_p): Fix the condition for processing a
2279 property that is a list to be consistent with handle_display_spec.
fec2107c 2280 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2281 last portion of handle_display_prop.
2282 (compute_display_string_pos): Accept additional argument
2283 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2284 value of a `display' property is a "replacing spec".
2285 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2286 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2287 the display property, but just return a value indicating whether
2288 the display property will replace the characters it covers.
2289 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2290 frame_window_p members of struct bidi_it.
d6d100dd
SM
2291 (compute_display_string_pos, compute_display_string_end):
2292 New functions.
fec2107c
EZ
2293 (push_it): Accept second argument POSITION, where pop_it should
2294 jump to continue iteration.
2295 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2296
fec2107c
EZ
2297 * keyboard.c (adjust_point_for_property): Adjust the call to
2298 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2299
2300 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2301 (bidi_init_it): Update prototypes.
2302 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2303 (compute_display_string_pos, compute_display_string_end):
2304 Declare prototypes.
fec2107c
EZ
2305 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2306 EMACS_INT.
fc6f18ce 2307
40087514 23082011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2309
57f53182
PE
2310 Malloc failure behavior now depends on size of allocation.
2311 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2312 * lisp.h: Change signatures accordingly.
2313 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2314 All callers changed. (Bug#8762)
2315
2316 * gnutls.c: Use Emacs's memory allocators.
2317 Without this change, the gnutls library would invoke malloc etc.
2318 directly, which causes problems on non-SYNC_INPUT hosts, and which
2319 runs afoul of improving memory_full behavior. (Bug#8761)
2320 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2321 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2322 xfree instead of the default malloc, realloc, free.
2323 (Fgnutls_boot): No need to check for memory allocation failure,
2324 since xmalloc does that for us.
2325
ac32cd99 2326 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2327 * category.c (hash_get_category_set):
2328 * ccl.c (ccl_driver):
2329 * charset.c (Fdefine_charset_internal):
2330 * charset.h (struct charset.hash_index):
2331 * composite.c (get_composition_id, gstring_lookup_cache)
2332 (composition_gstring_put_cache):
2333 * composite.h (struct composition.hash_index):
2334 * dispextern.h (struct image.hash):
2335 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2336 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2337 (hashfn_equal, hashfn_user_defined, make_hash_table)
2338 (maybe_resize_hash_table, hash_lookup, hash_put)
2339 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2340 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2341 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2342 * image.c (make_image, search_image_cache, lookup_image)
2343 (xpm_put_color_table_h):
2344 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2345 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2346 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2347 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2348 * alloc.c (allocate_vectorlike):
2349 Check for overflow in vector size calculations.
2350 * ccl.c (ccl_driver):
2351 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2352 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2353 need to be updated by these changes.
40087514
PE
2354 * fns.c (make_hash_table, maybe_resize_hash_table):
2355 Check for integer overflow with large hash tables.
0de4bb68
PE
2356 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2357 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2358 (SXHASH_REDUCE): New macro.
2359 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2360 Use it instead of discarding useful hash info with large hash values.
2361 (sxhash_float): New function.
2362 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2363 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2364 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2365 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2366 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2367 Adjust signatures to match updated version of code.
2368 (consing_since_gc): Now EMACS_INT, since a single hash table can
2369 use more than INT_MAX bytes.
2370
698d32e2
DN
23712011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2372
2373 Make it possible to build with GCC-4.6+ -O2 -flto.
2374
2375 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2376
fd6fa53f
SM
23772011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2378
2379 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2380 Call minibuffer-inactive-mode.
2381
864db017
JB
23822011-05-31 Juanma Barranquero <lekktu@gmail.com>
2383
2384 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2385 Update dependencies.
2386
2ad0baf4
DN
23872011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2388
2389 * data.c (init_data): Remove code for UTS, this system is not
2390 supported anymore.
2391
4fcc2638
DN
23922011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2393
2394 Don't force ./temacs to start in terminal mode.
2395
2396 * frame.c (make_initial_frame): Initialize faces in all cases, not
2397 only when CANNOT_DUMP is defined.
2398 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2399
c56e0fd5
DN
24002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2401
2402 * dispnew.c (add_window_display_history): Use const for the string
2403 pointer. Remove declaration, not needed.
2404
333d54da 24052011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2406
55d4c1b2 2407 Use 'inline', not 'INLINE'.
333d54da 2408 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2409 * alloc.c, fontset.c (INLINE): Remove.
2410 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2411 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2412 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2413 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2414 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2415
738db178
DN
24162011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2417
2418 Make it possible to run ./temacs.
2419
2420 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2421 syms_of_callproc does the same thing. Remove test for
2422 "initialized", do it in the caller.
2423 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2424
620c53a6
SM
24252011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2426
2427 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2428 (read_minibuf): Use get_minibuffer.
2429 (syms_of_minibuf): Use DEFSYM.
2430 (Qmetadata): New var.
2431 * data.c (Qbuffer): Don't make it static.
2432 (syms_of_data): Use DEFSYM.
2433
e003a292
PE
24342011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2435
2436 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2437 (CCL_CODE_MIN): New macro.
2438
ed008a6d
PE
24392011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2440
3687c2ef
PE
2441 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2442
ed008a6d
PE
2443 * eval.c (Qdebug): Now static.
2444 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2445 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2446 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2447
d66c4c7c
CY
24482011-05-29 Chong Yidong <cyd@stupidchicken.com>
2449
2450 * image.c: Various fixes to ImageMagick code comments.
2451 (Fimagemagick_types): Doc fix.
2452
5fbc2025
PE
24532011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2454
0196f88a
PE
2455 Minor fixes prompted by GCC 4.6.0 warnings.
2456
2457 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2458
5fbc2025
PE
2459 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2460 (x_clipboard_manager_save_all): Move extern decl to ...
2461 * xterm.h: ... here, so that it can be checked for consistency.
2462
1dd3c2d9
CY
24632011-05-29 Chong Yidong <cyd@stupidchicken.com>
2464
2465 * xselect.c (x_clipboard_manager_save_frame)
2466 (x_clipboard_manager_save_all): New functions.
2467 (Fx_clipboard_manager_save): Lisp function deleted.
2468
2469 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2470 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2471
2472 * xterm.h: Update prototype.
2473
5ba6571d
WX
24742011-05-28 William Xu <william.xwl@gmail.com>
2475
2476 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2477 exiting (Bug#8239).
2478
3eaff834
JM
24792011-05-28 Jim Meyering <meyering@redhat.com>
2480
e1900994 2481 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2482 * fns.c (to_uchar): Define.
2483 (crypto_hash_function): Use it to convert some newly-signed
2484 variables to unsigned, to avoid sign-extension bugs. For example,
2485 without this change, (md5 "truc") would evaluate to
2486 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2487 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2488 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2489
0f6990a7
PE
24902011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2491
2492 Integer overflow fixes.
c8a9ca5a 2493
08686060
PE
2494 * dbusbind.c: Serial number integer overflow fixes.
2495 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2496 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2497 to hold a serial number that is too large for a fixnum.
2498 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2499 Check for serial numbers out of range. Decode any serial number
59568bf0 2500 that was so large that it became a float. (Bug#8722)
08686060 2501
2d1fc3c7
PE
2502 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2503 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2504 Use XFASTINT rather than XUINT when numbers are nonnegative.
2505 (xd_append_arg, Fdbus_method_return_internal):
2506 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2507 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2508 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2509 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2510 (Bug#8722)
2d1fc3c7 2511
c8a9ca5a
PE
2512 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2513
519e1d69
PE
2514 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2515
30569699
PE
2516 ccl: add integer overflow checks
2517 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2518 (IN_INT_RANGE): New macros.
2519 (ccl_driver): Use them to check for integer overflow when
2520 decoding a CCL program. Many of the new checks are whether XINT (x)
2521 fits in int; it doesn't always, on 64-bit hosts. The new version
2522 doesn't catch all possible integer overflows, but it's an
847044ea 2523 improvement. (Bug#8719)
30569699 2524
c11285dc
PE
2525 * alloc.c (make_event_array): Use XINT, not XUINT.
2526 There's no need for unsigned here.
2527
fdccd48e
PE
2528 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2529 This follows up to the 2011-05-06 change that substituted uintptr_t
2530 for EMACS_INT. This case wasn't caught back then.
2531
37910ab2
PE
2532 Rework Fformat to avoid integer overflow issues.
2533 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2534 now (part of C89). Include <verify.h>.
2535 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2536 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2537 (Fformat): Avoid the prepass trying to compute sizes; it was only
2538 approximate and thus did not catch overflow reliably. Instead, walk
2539 through the format just once, formatting and computing sizes as we go,
2540 checking for integer overflow at every step, and allocating a larger
2541 buffer as needed. Keep track separately whether the format is
2542 multibyte. Keep only the most-recently calculated precision, rather
2543 than them all. Record whether each argument has been converted to
2544 string. Use EMACS_INT, not int, for byte and char and arg counts.
2545 Support field widths and precisions larger than INT_MAX. Avoid
2546 sprintf's undefined behavior with conversion specifications such as %#d
2547 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2548 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2549 formatting out-of-range floating point numbers with int
9173deec 2550 formats. (Bug#8668)
37910ab2 2551
2e6578fb
PE
2552 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2553
0ae6bdee
PE
2554 * data.c: Avoid integer truncation in expressions involving floats.
2555 * data.c: Include <intprops.h>.
2556 (arith_driver): When there's an integer overflow in an expression
2557 involving floating point, convert the integers to floating point
2558 so that the resulting value does not suffer from catastrophic
2559 integer truncation. For example, on a 64-bit host (* 4
2560 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2561 Do not rely on undefined behavior after integer overflow.
2562
de883a70
PE
2563 merge count_size_as_multibyte, parse_str_to_multibyte
2564 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2565 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2566 Check for integer overflow.
2567 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2568 since it's now a duplicate of the other. This is more of
2569 a character than a buffer op, so better that it's in character.c.
2570 * fns.c, print.c: Adjust to above changes.
2571
2ff916cb
PE
25722011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2573
2574 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2575
f1b54466
PE
25762011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2577
fb1ac845
PE
2578 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2579 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2580 (x_clipboard_manager_save): Now static.
2581 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2582
f1b54466
PE
2583 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2584 (crypto_hash_function): Now static.
2585 Fix pointer signedness problems. Avoid unnecessary initializations.
2586
a9f737ee
CY
25872011-05-27 Chong Yidong <cyd@stupidchicken.com>
2588
2589 * termhooks.h (Vselection_alist): Make it terminal-local.
2590
2591 * terminal.c (create_terminal): Initialize it.
2592
2593 * xselect.c: Support for clipboard managers.
2594 (Vselection_alist): Move to termhooks.h as terminal-local var.
2595 (LOCAL_SELECTION): New macro.
2596 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2597 (symbol_to_x_atom): Remove gratuitous arg.
2598 (x_handle_selection_request, lisp_data_to_selection_data)
2599 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2600 (x_own_selection, x_get_local_selection, x_convert_selection):
2601 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2602 (some_frame_on_display): Delete unused function.
2603 (Fx_own_selection_internal, Fx_get_selection_internal)
2604 (Fx_disown_selection_internal, Fx_selection_owner_p)
2605 (Fx_selection_exists_p): New optional frame arg.
2606 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2607 (x_handle_selection_clear): Don't treat other terminals with the
2608 same keyboard specially. Use the terminal-local Vselection_alist.
2609 (x_clear_frame_selections): Use Frun_hook_with_args.
2610
2611 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2612
2613 * xterm.h: Add support for those atoms.
2614
e067f0c1
CY
26152011-05-26 Chong Yidong <cyd@stupidchicken.com>
2616
2617 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2618 (converted_selections, conversion_fail_tag): New global variables.
2619 (x_selection_request_lisp_error): Free the above.
2620 (x_get_local_selection): Remove unnecessary code.
2621 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2622 of converted selections stored in converted_selections.
2623 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2624 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2625 (x_convert_selection): New function.
2626 (x_handle_selection_event): Simplify.
2627 (x_get_foreign_selection): Don't ignore incoming requests while
2628 waiting for an answer; this will fail when we implement
2629 SAVE_TARGETS, and seems unnecessary anyway.
2630 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2631 (Vx_sent_selection_functions): Doc fix.
2632
0f4aebc0
LL
26332011-05-26 Leo Liu <sdl.web@gmail.com>
2634
2635 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2636
e61124cd
YM
26372011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2638
2639 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2640
2641 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2642 for fringe update if it has periodic bitmap.
ac389d0c 2643 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2644 and fringe_bitmap_periodic_p.
2645
2646 * fringe.c (get_fringe_bitmap_data): New function.
2647 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2648 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2649 row. Mark glyph row for fringe update if periodicity changed.
2650
2651 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2652 for fringe update unless it has periodic bitmap.
2653
f16d9837
KH
26542011-05-25 Kenichi Handa <handa@m17n.org>
2655
2656 * xdisp.c (get_next_display_element): Set correct it->face_id for
2657 a static composition.
2658
e1b90ef6
LL
26592011-05-24 Leo Liu <sdl.web@gmail.com>
2660
2661 * deps.mk (fns.o):
2662 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2663
2664 * fns.c (crypto_hash_function, Fsha1): New function.
2665 (Fmd5): Use crypto_hash_function.
2666 (syms_of_fns): Add Ssha1.
2667
7400048f
PE
26682011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2669
2670 * gnutls.c: Remove unused macros.
2671 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2672 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2673 Remove macros that are defined and never used.
2674 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2675
abb71cf4
CY
26762011-05-22 Chong Yidong <cyd@stupidchicken.com>
2677
2678 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2679 (Fx_get_selection_internal): Minor cleanup.
2680 (Fx_own_selection_internal): Rename arguments for consistency with
2681 select.el.
2682
6307db39
PE
26832011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2684
2685 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2686
f3d4e0a4
CY
26872011-05-22 Chong Yidong <cyd@stupidchicken.com>
2688
2689 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2690
4d8ade89
YM
26912011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2692
2693 * dispnew.c (scrolling_window): Don't exclude the case that the
2694 last enabled row in the desired matrix touches the bottom boundary.
2695
32078c8d
GM
26962011-05-21 Glenn Morris <rgm@gnu.org>
2697
2698 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2699 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2700 and add some more files.
32078c8d 2701
7285dc67
EZ
27022011-05-20 Eli Zaretskii <eliz@gnu.org>
2703
2704 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2705 report_file_error introduced by the change from 2011-05-07.
2706
89d1bd22
PE
27072011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2708
2709 * systime.h (Time): Define only if emacs is defined.
2710 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2711 where the include path doesn't have X11/X.h by default. See
2712 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2713
e23640bb 27142011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2715
2716 * composite.c (find_automatic_composition): Fix previous change.
2717
b9704ad9
GM
27182011-05-20 Glenn Morris <rgm@gnu.org>
2719
2720 * lisp.mk: New file, split from Makefile.in.
2721 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2722 (shortlisp): Remove.
2723 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2724
4a720484
GM
27252011-05-19 Glenn Morris <rgm@gnu.org>
2726
2727 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2728 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2729 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2730 (lisp): Set the order to that of loadup.el.
2731 (shortlisp): Make it a copy of $lisp.
2732 (SOME_MACHINE_LISP): Remove.
2733 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2734 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2735
a28d4396
KH
27362011-05-18 Kenichi Handa <handa@m17n.org>
2737
2738 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2739 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2740 (find_automatic_composition): Mostly rewrite for efficiency.
2741
a2b1fa8e
JB
27422011-05-18 Juanma Barranquero <lekktu@gmail.com>
2743
2744 * makefile.w32-in: Update dependencies.
2745
8e1f5610
CS
27462011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2747
2748 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2749 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2750
7025ee00 27512011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2752
cdfa6eab
PE
2753 Fix some integer overflow issues, such as string length overflow.
2754
06d6db33
PE
2755 * insdel.c (count_size_as_multibyte): Check for string overflow.
2756
2b4560a8
PE
2757 * character.c (lisp_string_width): Check for string overflow.
2758 Use EMACS_INT, not int, for string indexes and lengths; in
2759 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2760 the resulting string length overflows an EMACS_INT; instead,
2761 report a string overflow if no precision given. When checking for
2762 precision exhaustion, use a check that cannot possibly have
2763 integer overflow. (Bug#8675)
2764 * character.h (lisp_string_width): Adjust to new signature.
2765
cb93f9be
PE
2766 * alloc.c (string_overflow): New function.
2767 (Fmake_string): Use it. This doesn't change behavior, but saves
2768 a few bytes and will simplify future changes.
2769 * character.c (string_escape_byte8): Likewise.
2770 * lisp.h (string_overflow): New decl.
2771
1a1f3366
PE
2772 Fixups, following up to the user-interface timestamp change.
2773 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2774 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2775 * msdos.c (mouse_get_pos): Likewise.
2776 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2777 * w32gui.h (Time): Define by including "systime.h" rather than by
2778 declaring it ourselves. (Bug#8664)
2779
d4e3e4d3
PE
2780 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2781 * image.c (clear_image_cache): Likewise.
2782
f6a24d19
PE
2783 * term.c (term_mouse_position): Don't assume time_t wraparound.
2784
08dc5ae6
PE
2785 Be more systematic about user-interface timestamps.
2786 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2787 and sometimes 'EMACS_UINT', to represent these timestamps.
2788 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2789 This makes the code easier to follow, and makes it easier to catch
2790 integer overflow bugs such as Bug#8664.
2791 * frame.c (Fmouse_position, Fmouse_pixel_position):
2792 Use Time, not unsigned long, for user-interface timestamps.
2793 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2794 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2795 * keyboard.h (last_event_timestamp): Likewise.
2796 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2797 * menu.h (xmenu_show): Likewise.
2798 * term.c (term_mouse_position): Likewise.
2799 * termhooks.h (struct input_event.timestamp): Likewise.
2800 (struct terminal.mouse_position_hook): Likewise.
2801 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2802 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2803 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2804 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2805 what it was before.
2806 * menu.h, termhooks.h: Include "systime.h", for Time.
2807
8e55734a
PE
2808 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2809 Don't assume that the difference between two unsigned long values
2810 can fit into an integer. At this point, we know button_down_time
2811 <= event->timestamp, so the difference must be nonnegative, so
2812 there's no need to cast the result if double-click-time is
2813 nonnegative, as it should be; check that it's nonnegative, just in
2814 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2815 apart (about 25 days). (Bug#8664)
8e55734a 2816
841f1b75 2817 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2818 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2819
3e26f69c
PE
2820 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2821 that always fit in int. Use a sentinel instead of a counter, to
2822 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2823 * frame.h (struct frame): Use int for menu_bar_items_used
2824 instead of EMACS_INT, since it always fits in int.
3e26f69c 2825
5cc152c0
PE
2826 * menu.c (grow_menu_items): Check for int overflow.
2827
d89eb65e
PE
2828 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2829
5235bd3e
PE
2830 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2831 Before, the code was not consistent. These values cannot exceed
2832 2**31 - 1 so there's no need to make them unsigned.
2833 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2834 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2835 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2836 as modifiers.
2837 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2838
bc827e23
PE
2839 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2840 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2841 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2842 presumably because the widths might not match.
2843
78eb494e
PE
2844 * window.c (size_window): Avoid needless test at loop start.
2845
04f2d78b
CB
28462011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2847
2848 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2849
d2fc7e3d 28502011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2851
2852 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2853
d2fc7e3d 28542011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2855
2856 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2857 `width' to `bar_area_x' and `bar_area_width', respectively.
2858 (x_scroll_run): Take account of fringe background extension.
2859
04f2d78b
CB
2860 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2861 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2862 `bar_area_width', respectively.
2863 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2864 background extension.
2865
79b70037
GM
28662011-05-10 Jim Meyering <meyering@redhat.com>
2867
2868 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2869
2f142cc5
JB
28702011-05-10 Juanma Barranquero <lekktu@gmail.com>
2871
2872 * image.c (Finit_image_library): Return t for built-in image types,
2873 like pbm and xbm. (Bug#8640)
2874
57679c86
AS
28752011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2876
2877 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2878
888c9e86
EZ
28792011-05-07 Eli Zaretskii <eliz@gnu.org>
2880
b0512a1d
EZ
2881 * w32console.c (Fset_screen_color): Doc fix.
2882 (Fget_screen_color): New function.
2883 (syms_of_ntterm): Defsubr it.
2884
7285dc67
EZ
2885 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2886 unlink the temporary file if Fcall_process didn't create it in the
2887 first place.
2888 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2889 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2890 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2891 cue to call_process_cleanup not to close that handle.
2892
4d3fcc8e
BK
28932011-05-07 Ben Key <bkey76@gmail.com>
2894
2895 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2896 one of two shell specific rules, either bootstrap-temacs-CMD or
2897 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2898 to the previous implementation of the bootstrap-temacs rule.
2899 The bootstrap-temacs-CMD rule is similar to the previous
2900 implementation of the bootstrap-temacs rule except that it
2901 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2902 variable.
2903
2904 These changes, along with some changes to nt/configure.bat,
2905 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2906 earlier fix to add support for --cflags and --ldflags options
2907 that include quotes so that it works whether make uses cmd or
2908 sh as the shell.
2909
b4289b64
MA
29102011-05-06 Michael Albinus <michael.albinus@gmx.de>
2911
2912 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2913 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2914 is a constant.
2915 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2916 a string. Handle both cases.
2917 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2918 (Fdbus_register_method): Use Qinvalid_function.
2919
af4c0e28
JB
29202011-05-06 Juanma Barranquero <lekktu@gmail.com>
2921
2922 * makefile.w32-in: Update dependencies.
2923 (LISP_H): Add inttypes.h and stdin.h.
2924 (PROCESS_H): Add unistd.h.
2925
c51453d9
EZ
29262011-05-06 Eli Zaretskii <eliz@gnu.org>
2927
2928 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2929 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2930
8ff0ac3c 29312011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2932
4c4b566b
PE
2933 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2934
aab2b9b5
PE
2935 * term.c (vfatal): Remove stray call to va_end.
2936 It's not needed and the C Standard doesn't allow it here anyway.
2937
c378da0b
PE
2938 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2939 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2940
288b08c7
PE
2941 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2942 bytes.
2943
e3601888
PE
2944 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2945
db6c0e74
PE
2946 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2947
dd5963ea
PE
2948 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2949
88c9450f
PE
2950 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2951
2f9442b8
PE
2952 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2953
c032b5f8
PE
2954 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2955 * charset.c (Fdefine_charset_internal): Don't initialize
2956 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2957 32-bit int (Bug#8600).
a108c10b
PE
2958
2959 * lread.c (read_integer): Be more consistent with string-to-number.
2960 Use string_to_number to do the actual conversion; this avoids
2961 rounding errors and fixes some other screwups. Without this fix,
2962 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2963 (digit_to_number): Move earlier, for benefit of read_integer.
2964 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2965 not a digit in any supported base. (Bug#8602)
a108c10b 2966
ad5f9eea
PE
2967 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2968
aec1708a
PE
2969 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2970 to match comment at start of function. This also removes a
2971 GCC warning about overflow in a 32+64-bit port.
2972
47be4ab5
PE
2973 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2974
371cac43
PE
2975 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2976 Reported by Stefan Monnier in
2977 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2978 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2979 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2980
d01a7826
PE
2981 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2982 (EMACS_UINTPTR): Likewise, with uintptr_t.
2983
7fd47d5c
PE
2984 * lisp.h: Prefer 64-bit EMACS_INT if available.
2985 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2986 on 32-bit hosts that have 64-bit int, so that they can access
2987 large files.
122b0c86
PE
2988 However, temporarily disable this change unless the temporary
2989 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2990
8727937b
PE
2991 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2992
8ac068ac
PE
2993 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2994 This removes an assumption that EMACS_INT and long are the same
2995 width as pointers. The assumption is true for Emacs porting targets
2996 now, but we want to make other targets possible.
2997 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2998 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2999 In the rest of the code, change types of integers that hold casted
3000 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3001 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3002 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3003 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3004 No need to cast type when ORing.
3005 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3006 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3007 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3008 assume EMACS_INT is the same width as char *.
3009 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3010 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3011 Remove no-longer-needed casts.
3012 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3013 (xg_tool_bar_help_callback, xg_make_tool_item):
3014 Use EMACS_INTPTR to hold an integer
3015 that will be cast to void *; this can avoid a GCC warning
3016 if EMACS_INT is not the same width as void *.
3017 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3018 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3019 (current_message_1, set_message_1):
3020 Use a local to convert to proper width without a cast.
3021 * xmenu.c (dialog_selection_callback): Likewise.
3022
ede49d71
PE
3023 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3024 Also, don't assume VALBITS / RAND_BITS is less than 5,
3025 and don't rely on undefined behavior when shifting a 1 left into
3026 the sign bit.
3027 * lisp.h (get_random): Change signature to match.
3028
2f30ecd0
PE
3029 * lread.c (hash_string): Use size_t, not int, for hash computation.
3030 Normally we prefer signed values; but hashing is special, because
3031 it's better to use unsigned division on hash table sizes so that
3032 the remainder is nonnegative. Also, size_t is the natural width
3033 for hashing into memory. The previous code used 'int', which doesn't
3034 retain enough info to hash well into very large tables.
3035 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3036
2a866e7b
PE
3037 * dbusbind.c: Don't possibly lose pointer info when converting.
3038 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3039 Use XPNTR rather than XHASH, so that the high-order bits of
3040 the pointer aren't lost when converting through void *.
3041
51639eac
PE
3042 * eval.c (Fautoload): Don't double-shift a pointer.
3043
92394119
PE
3044 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3045
dbdb9a7c
JB
30462011-05-06 Juanma Barranquero <lekktu@gmail.com>
3047
3048 * gnutls.c (DEF_GNUTLS_FN):
3049 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3050
db7a0b4f
AS
30512011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3052
3053 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3054 marker. (Bug#8610)
3055
f7ff1b0f 30562011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3057
3058 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3059 New version that can reserve upto 2GB of heap space.
3060
f7ff1b0f 30612011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3062
3063 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3064
639c109b
TZ
30652011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3066
3067 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3068 `gnutls_certificate_set_x509_key_file'.
3069
d2127135
JB
30702011-05-05 Juanma Barranquero <lekktu@gmail.com>
3071
3072 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3073 Update dependencies.
3074
e968f4f3
JB
30752011-05-04 Juanma Barranquero <lekktu@gmail.com>
3076
3077 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3078 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3079 Remove unused parameter `fildes'.
3080 * process.c (read_process_output, send_process): Don't pass it.
3081
84d358f0
JB
30822011-05-04 Juanma Barranquero <lekktu@gmail.com>
3083
3084 Fix previous change: the library cache is defined in w32.c.
3085 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3086 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3087
0898ca10
JB
30882011-05-04 Juanma Barranquero <lekktu@gmail.com>
3089
3090 Implement dynamic loading of GnuTLS on Windows.
3091
3092 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3093 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3094 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3095 Declare.
3096
3097 * gnutls.c (Qgnutls_dll): Define.
3098 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3099 (gnutls_*): Declare function pointers.
3100 (init_gnutls_functions): New function to initialize function pointers.
3101 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3102 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3103 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3104 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3105 (emacs_gnutls_write, emacs_gnutls_read)
3106 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3107 (Fgnutls_available_p): New function.
3108 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3109 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3110 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3111
3112 * image.c: Include w32.h.
3113 (Vimage_type_cache): Delete.
3114 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3115 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3116 (w32_delayed_load): Move to w32.c.
3117
3118 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3119
3120 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3121 (w32_delayed_load): Move from image.c. When loading a library, record
3122 its filename in the :loaded-from property of the library id.
3123 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3124 Initialize and staticpro them.
3125 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3126
3127 * process.c: Include lisp.h before w32.h, not after.
3128 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3129 instead of gnutls_record_check_pending.
3130
3131 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3132
ff4de4aa
TZ
31332011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3134
3135 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3136 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3137 as passed in.
3138
abe95abb
JD
31392011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3140
3141 * xterm.c (x_set_frame_alpha): Do not set property on anything
3142 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3143
e16e55d4
JB
31442011-05-02 Juanma Barranquero <lekktu@gmail.com>
3145
3146 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3147
bafcf6a5
JB
31482011-05-02 Juanma Barranquero <lekktu@gmail.com>
3149
3150 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3151 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3152 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3153 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3154 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3155 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3156 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3157 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3158 (Qgnutls_bootprop_callbacks_verify): Make static.
3159
e7a6747f
AS
31602011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3161
19ed11ba
AS
3162 * callproc.c: Indentation fixup.
3163
e7a6747f 3164 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3165 (wait_for_termination, interruptible_wait_for_termination):
3166 Move after wait_for_termination_1.
e7a6747f 3167
1ef14cb4
LMI
31682011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3169
3170 * sysdep.c (interruptible_wait_for_termination): New function
3171 which is like wait_for_termination, but allows keyboard
3172 interruptions.
3173
3174 * callproc.c (Fcall_process): Add (:file "file") as an option for
3175 the STDOUT buffer.
3176 (Fcall_process_region): Ditto.
3177
330d880c
EZ
31782011-04-30 Eli Zaretskii <eliz@gnu.org>
3179
8db90b73
EZ
3180 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3181 rather than `XVECTOR (FOO)->size'.
3182
330d880c
EZ
3183 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3184 inttypes.h, as a gnulib replacement is used if it not available in
3185 system headers.
3186
15cbd324
EZ
31872011-04-21 Eli Zaretskii <eliz@gnu.org>
3188
3189 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3190 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3191 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3192
3193 * coding.c (coding_alloc_by_realloc): Error out if destination
3194 will grow beyond MOST_POSITIVE_FIXNUM.
3195 (decode_coding_emacs_mule): Abort if there isn't enough place in
3196 charbuf for the composition carryover bytes. Reserve an extra
3197 space for up to 2 characters produced in a loop.
3198 (decode_coding_iso_2022): Abort if there isn't enough place in
3199 charbuf for the composition carryover bytes.
3200
32012011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3202
ae940cca
EZ
3203 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3204 aborting when %lld or %lll format is passed.
3205 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3206 %llo or %llx format is passed. (Bug#8545)
3207
03ab8921
EZ
3208 * window.c (window_scroll_line_based): Use a marker instead of
3209 simple variables to record original value of point. (Bug#7952)
3210
afda1437
EZ
3211 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3212 produced by %s or %c overflows available buffer space. (Bug#8545)
3213
f76dee0c
PE
32142011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3215
3216 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3217 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3218
fdc5744d
JB
32192011-04-28 Juanma Barranquero <lekktu@gmail.com>
3220
3221 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3222
638f053a
JB
32232011-04-28 Juanma Barranquero <lekktu@gmail.com>
3224
3225 * keyboard.c (Qdelayed_warnings_hook): Define.
3226 (command_loop_1): Run `delayed-warnings-hook'
3227 if Vdelayed_warnings_list is non-nil.
3228 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3229 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3230
d178f871
EZ
32312011-04-28 Eli Zaretskii <eliz@gnu.org>
3232
3233 * doprnt.c (doprnt): Don't return value smaller than the buffer
3234 size if the message was truncated. (Bug#8545).
3235
b124fd93
JB
32362011-04-28 Juanma Barranquero <lekktu@gmail.com>
3237
3238 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3239 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3240
e810457d
PE
32412011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3242
3243 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3244
ea51cceb
JB
32452011-04-27 Juanma Barranquero <lekktu@gmail.com>
3246
3247 * makefile.w32-in: Update dependencies.
3248
94dcfacf
EZ
32492011-04-27 Eli Zaretskii <eliz@gnu.org>
3250
3251 Improve `doprnt' and its usage. (Bug#8545)
3252 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3253 `format_end'. Remove support for %l as a conversion specifier.
3254 Don't use xrealloc. Improve diagnostics when the %l size modifier
3255 is used. Update the commentary.
3256
3257 * eval.c (verror): Simplify calculation of size_t.
3258
3259 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3260 messages.
3261
f61f41d7
PE
32622011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3263
3264 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3265 change.
3266
96fb4434
PE
32672011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3268
3269 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3270 This makes this file independent of the recent pseudovector change.
3271
671875da 32722011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3273
69e9b5a3
PE
3274 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3275
b5f869a7 3276 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3277 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3278 Remove unused local.
c8926152 3279 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3280
841a1577 3281 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3282 GCC 4.6.0 optimizes based on type-based alias analysis.
3283 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3284 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3285 != &v->size, and therefore "v->size = 1; b->size = 2; return
3286 v->size;" must therefore return 1. This assumption is incorrect
3287 for Emacs, since it type-puns struct Lisp_Vector * with many other
3288 types. To fix this problem, this patch adds a new type struct
f904488f 3289 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3290 and pseudovectors, and helps optimizing compilers not get fooled
3291 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3292 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3293 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3294 the size member.
eab3844f
PE
3295 (XSETPVECTYPE): Rewrite in terms of new macro.
3296 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3297 This is a bit clearer, and further avoids the possibility of
3298 undesirable aliasing.
3299 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3300 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3301 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3302 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3303 (ASIZE): Now uses header.size rather than size.
3304 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3305 to avoid the hassle of writing XVECTOR (foo)->header.size.
3306 (struct vectorlike_header): New type.
eab3844f
PE
3307 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3308 object, to help avoid aliasing.
3309 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3310 (SUBRP): Likewise, since Lisp_Subr is a special case.
3311 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3312 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3313 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3314 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3315 changed to be "header.size" and "header.next".
3316 * buffer.h (struct buffer): Likewise.
3317 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3318 * frame.h (struct frame): Likewise.
3319 * process.h (struct Lisp_Process): Likewise.
3320 * termhooks.h (struct terminal): Likewise.
3321 * window.c (struct save_window_data, struct saved_window): Likewise.
3322 * window.h (struct window): Likewise.
3323 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3324 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3325 * buffer.c (init_buffer_once): Likewise.
3326 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3327 special case.
3328 * process.c (Fformat_network_address): Use local var for size,
3329 for brevity.
3330
0df1eac5
PE
3331 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3332
847ab9d1 3333 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3334 * data.c (atof): Remove decl; no longer used or needed.
3335 (digit_to_number): Move to lread.c.
3336 (Fstring_to_number): Use new string_to_number function, to be
3337 consistent with how the Lisp reader treats infinities and NaNs.
3338 Do not assume that floating-point numbers represent EMACS_INT
3339 without losing information; this is not true on most 64-bit hosts.
3340 Avoid double-rounding errors, by insisting on integers when
3341 parsing non-base-10 numbers, as the documentation specifies.
3342 * lisp.h (string_to_number): New decl, replacing ...
3343 (isfloat_string): Remove.
bc0a5c13 3344 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3345 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3346 appears to have been a coding error. Similarly, do not accept
3347 strings like +-1e0 as floating point numbers. Do not report
3348 overflow for integer overflows unless the base is not 10 which
3349 means we have no simple and reliable way to continue.
3350 Break out the floating-point parsing into a new
3351 function string_to_number, so that Fstring_to_number parses
3352 floating point numbers consistently with the Lisp reader.
04f2d78b 3353 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3354 (E_CHAR, EXP_INT): Remove, replacing with ...
3355 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3356 (string_to_number): New function, replacing isfloat_string.
3357 This function checks for valid syntax and produces the resulting
3358 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3359 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3360 so that overflow for non-base-10 numbers is reported only when
3361 there's no portable and simple way to convert to floating point.
452f4150 3362
67769ffc
PE
3363 * textprop.c (set_text_properties_1): Rewrite for clarity,
3364 and to avoid GCC warning about integer overflow.
3365
c20db43f
PE
3366 * intervals.h (struct interval): Use EMACS_INT for members
3367 where EMACS_UINT might cause problems. See
3368 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3369 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3370 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3371 All uses changed.
37aa2f85
PE
3372 (offset_intervals): Tell GCC not to worry about length overflow
3373 when negating a negative length.
c20db43f 3374
2538aa2f
PE
3375 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3376 (overrun_check_free): Likewise.
3377
f2d3008d
PE
3378 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3379 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3380 word size.
3381
ec8df744
PE
3382 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3383 (gnutls_make_error): Rename local to avoid shadowing.
3384 (gnutls_emacs_global_deinit): ifdef out; not used.
3385 (Fgnutls_boot): Use const for pointer to readonly storage.
3386 Comment out unused local. Fix pointer signedness problems.
3387
640ee02d
PE
3388 * lread.c (openp): Don't stuff size_t into an 'int'.
3389 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3390 about possible signed overflow.
3391
6048fb2a
PE
3392 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3393 (GDK_KEY_g): Don't define if already defined.
3394 (xg_prepare_tooltip): Avoid pointer signedness problem.
3395 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3396
fa3c87e1
PE
3397 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3398 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3399
2172544b
PE
3400 * xfns.c (Fx_window_property): Simplify a bit,
3401 to make a bit faster and to avoid GCC 4.6.0 warning.
3402 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3403
9b821a21
PE
3404 * fns.c (internal_equal): Don't assume size_t fits in int.
3405
3c616cfa
PE
3406 * alloc.c (compact_small_strings): Tighten assertion a little.
3407
c2982e87
PE
3408 Replace pEd with more-general pI, and fix some printf arg casts.
3409 * lisp.h (pI): New macro, generalizing old pEd macro to other
3410 conversion specifiers. For example, use "...%"pI"d..." rather
3411 than "...%"pEd"...".
3412 (pEd): Remove. All uses replaced with similar uses of pI.
3413 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3414 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3415 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3416 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3417 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3418 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3419 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3420 64-bit hosts.
3421 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3422 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3423 * print.c (safe_debug_print, print_object): Likewise.
3424 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3425 to int.
6f04d126
PE
3426 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3427 avoiding the 0 flag, which is not portable.
c2982e87
PE
3428 * process.c (Fmake_network_process): Use pI to avoid cast.
3429 * region-cache.c (pp_cache): Likewise.
3430 * xdisp.c (decode_mode_spec): Likewise.
3431 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3432 behavior on 64-bit hosts with printf arg.
6f04d126 3433 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3434 (x_stop_queuing_selection_requests): Likewise.
3435 (x_get_window_property): Don't truncate byte count to an 'int'
3436 when tracing.
0b432f21 3437
5e073ec7
PE
3438 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3439 here, since it parses constructs like leading '-' and spaces,
3440 which are not wanted; and it overflows with large numbers.
3441 Instead, simply match F[0-9]+, which is what is wanted anyway.
3442
36372bf9
PE
3443 * alloc.c: Remove unportable assumptions about struct layout.
3444 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3445 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3446 (allocate_vectorlike, make_pure_vector): Use the new macros,
3447 plus offsetof, to remove unportable assumptions about struct layout.
3448 These assumptions hold on all porting targets that I know of, but
3449 they are not guaranteed, they're easy to remove, and removing them
3450 makes further changes easier.
3451
0b432f21
PE
3452 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3453 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3454 (string_overrun_cookie): Now const. Use initializers that
3455 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3456 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3457 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3458 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3459 multiple of sizeof (EMACS_INT); it need not be, if
3460 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3461 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3462
895009e1
JB
34632011-04-26 Juanma Barranquero <lekktu@gmail.com>
3464
3465 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3466
6a7a1b0b
TZ
34672011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3468
3469 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3470 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3471 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3472
841a1577 34732011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3474
3475 * lisp.h (Qdebug): List symbol.
895009e1 3476 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3477 * keyboard.c (debug-on-event): New variable.
3478 (handle_user_signal): Break into debugger when debug-on-event
3479 matches the current signal symbol.
3480
f2d3ba6f
DN
34812011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3482
3483 * alloc.c (check_sblock, check_string_bytes)
3484 (check_string_free_list): Convert to standard C.
3485
42ce4c63
TZ
34862011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3487
3488 * w32.c (emacs_gnutls_push): Fix typo.
3489
825cd63c
EZ
34902011-04-25 Eli Zaretskii <eliz@gnu.org>
3491
fb11d64d
EZ
3492 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3493 "cast to pointer from integer of different size".
3494
825cd63c
EZ
3495 Improve doprnt and its use in verror. (Bug#8545)
3496 * doprnt.c (doprnt): Document the set of format control sequences
3497 supported by the function. Use SAFE_ALLOCA instead of always
3498 using `alloca'.
3499
3500 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3501 is one byte too soon. Don't use xrealloc; instead xfree and
3502 xmalloc anew.
3503
e061a11b
TZ
35042011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3505
3506 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3507 callbacks stage.
3508
3509 * gnutls.c: Renamed global_initialized to
3510 gnutls_global_initialized. Added internals for the
3511 :verify-hostname-error, :verify-error, and :verify-flags
3512 parameters of `gnutls-boot' and documented those parameters in the
3513 docstring. Start callback support.
9173deec
JB
3514 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3515 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3516 on error. Return error code.
e061a11b
TZ
3517 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3518 (emacs_gnutls_read): Likewise.
3519 (Fgnutls_boot): Return handshake error code.
3520 (emacs_gnutls_handle_error): New function.
3521 (wsaerror_to_errno): Likewise.
3522
3523 * w32.h (emacs_gnutls_pull): Add prototype.
3524 (emacs_gnutls_push): Likewise.
3525
3526 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3527 (emacs_gnutls_push): Likewise.
3528
35292011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3530
3531 * process.c (wait_reading_process_output): Check if GnuTLS
3532 buffered some data internally if no FDs are set for TLS
3533 connections.
3534
3535 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3536 (LIBS): Link to USER_LIBS.
3537 ($(BLD)/gnutls.$(0)): New target.
3538
fa6996bc
EZ
35392011-04-24 Eli Zaretskii <eliz@gnu.org>
3540
eb35682e
EZ
3541 * xdisp.c (handle_single_display_spec): Rename the
3542 display_replaced_before_p argument into display_replaced_p, to
3543 make it consistent with the commentary. Fix typos in the
3544 commentary.
3545
e2ad650c
EZ
3546 * textprop.c (syms_of_textprop): Remove dead code.
3547 (copy_text_properties): Delete obsolete commentary about an
3548 interface that was deleted long ago. Fix typos in the description
3549 of arguments.
3550
1b2de274
EZ
3551 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3552 to changes in oldXMenu/XMenu.h from 2011-04-16.
3553 <menu_help_message, prev_menu_help_message>: Constify.
3554 (IT_menu_make_room): menu->help_text is now `const char **';
3555 adjust.
3556
3557 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3558 to changes in oldXMenu/XMenu.h from 2011-04-16.
3559 (struct XMenu): Declare `help_text' `const char **'.
3560
3561 * xfaces.c <Qunspecified>: Make extern again.
3562
3563 * syntax.c: Include sys/types.h before including regex.h, as
3564 required by Posix.
3565
762b15be
EZ
3566 * doc.c (get_doc_string): Improve the format passed to `error'.
3567
3568 * doprnt.c (doprnt): Improve commentary.
3569
3570 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3571
3572 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3573 them with etags.
3574
f1052e5d
EZ
3575 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3576 changes in globals.h immediately force recompilation.
762b15be
EZ
3577 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3578 $(CURDIR)/s/ms-w32.h.
3579 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3580
fa6996bc
EZ
3581 * character.c (Fchar_direction): Function deleted.
3582 (syms_of_character): Don't defsubr it.
3583 <char-direction-table>: Deleted.
3584
e6c3da20
EZ
35852011-04-23 Eli Zaretskii <eliz@gnu.org>
3586
3587 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3588 * doprnt.c: Include limits.h.
3589 (SIZE_MAX): New macro.
04f2d78b
CB
3590 (doprnt): Return a size_t value. 2nd arg is now size_t.
3591 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3592 Improve overflow protection. Support `l' modifier for integer
3593 conversions. Support %l conversion. Don't assume an EMACS_INT
3594 argument for integer conversions and for %c.
3595
3596 * lisp.h (doprnt): Restore prototype.
3597
3598 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3599 $(SRC)/character.h.
3600
3601 * Makefile.in (base_obj): Add back doprnt.o.
3602
3603 * deps.mk (doprnt.o): Add back prerequisites.
3604 (callint.o): Depend on character.h.
3605
3606 * eval.c (internal_lisp_condition_case): Include the handler
3607 representation in the error message.
3608 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3609 when breaking from the loop.
3610
3611 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3612
3613 * callint.c (Fcall_interactively): When displaying error message
3614 about invalid control letter, pass the character's codepoint, not
3615 a pointer to its multibyte form. Improve display of the character
3616 in octal and display also its hex code.
3617
3618 * character.c (char_string): Use %x to display the (unsigned)
3619 codepoint of an invalid character, to avoid displaying a bogus
3620 negative value.
3621
3622 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3623 `error', not SYMBOL_NAME itself.
3624
3625 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3626 character arguments to `error'.
3627
3628 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3629 to `error' in error message about FINAL_CHAR argument. Make sure
3630 FINAL_CHAR is a character, and use %c when it is passed as
3631 argument to `error'.
3632
4ffd0d6b 36332011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3634
3635 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3636
3637 * w32.c: Include <time.h>.
3638 (sys_localtime): New function.
3639
4ffd0d6b 36402011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3641
3642 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3643
4ffd0d6b 3644 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3645
4ffd0d6b 36462011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3647
4ffd0d6b
GM
3648 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3649 zombies (Bug#8467).
aac0c6e3 3650
04c56954
EZ
36512011-04-19 Eli Zaretskii <eliz@gnu.org>
3652
3653 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3654 gl_state.e_property when gl_state.object is Qt.
3655
3656 * insdel.c (make_gap_larger): Remove limitation of buffer size
3657 to <= INT_MAX.
3658
16a43933
CY
36592011-04-18 Chong Yidong <cyd@stupidchicken.com>
3660
3661 * xdisp.c (lookup_glyphless_char_display)
3662 (produce_glyphless_glyph): Handle cons cell entry in
3663 glyphless-char-display.
3664 (Vglyphless_char_display): Document it.
3665
3666 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3667 glyphless-char-display.
3668
4581706e
CY
36692011-04-17 Chong Yidong <cyd@stupidchicken.com>
3670
3671 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3672
3673 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3674
3675 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3676 definition for no-X builds.
3677
4887c6e2 36782011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3679
fd35b6f9
PE
3680 Static checks with GCC 4.6.0 and non-default toolkits.
3681
5c1ccb01
PE
3682 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3683
006c5daa
PE
3684 * process.c (keyboard_bit_set): Define only if SIGIO.
3685 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3686 (send_process): Repair possible setjmp clobbering.
3687
efc736d3
PE
3688 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3689
4e2fe2e6
PE
3690 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3691
f97334a2
PE
3692 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3693
4e75f29d
PE
3694 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3695 Define only if needed.
3696
90efadd1
PE
3697 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3698 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3699 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3700
3c647824
PE
3701 * dispextern.h (struct redisplay_interface): Rename param
3702 to avoid shadowing.
e264f262 3703 * termhooks.h (struct terminal): Likewise.
761383f4 3704 * xterm.c (xembed_send_message): Likewise.
3c647824 3705
b58c5c4a
PE
3706 * insdel.c (make_gap_smaller): Define only if
3707 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3708
cad59032
PE
3709 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3710 it.
3711
c339dc2e
PE
3712 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3713 so that we aren't warned about unused symbols.
3714
91a3e27b
PE
3715 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3716
399c71d3 3717 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3718
8ffc96f5
PE
3719 * xfns.c (x_real_positions): Mark locals as initialized.
3720
eef9bc79
PE
3721 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3722
098db9dd
PE
3723 * xterm.c: Fix problems found by static analysis with other toolkits.
3724 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3725 (x_dispatch_event): Declare static if USE_GTK, and
3726 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3727 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3728 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3729 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3730 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3731
eb18f6cc
PE
3732 * xmenu.c (menu_help_callback): Pointer type fixes.
3733 Use const pointers when pointing at readonly data. Avoid pointer
3734 signedness clashes.
3735 (FALSE): Remove unused macro.
3736 (update_frame_menubar): Remove unused decl.
3737
1fe72bf8
PE
3738 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3739
60d9e1db
PE
3740 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3741 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3742 (single_menu_item): Rename local to avoid shadowing.
3743
39261c26
PE
3744 * keyboard.c (make_lispy_event): Remove unused local var.
3745
018c5e19
PE
3746 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3747 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3748
63d2b86e
PE
3749 * bitmaps: Change bitmaps from unsigned char back to the X11
3750 compatible char. Avoid the old compiler warnings about
3751 out-of-range initializers by using, for example, '\xab' rather
3752 than 0xab.
3753
aefd87e1
PE
3754 * xgselect.c (xgselect_initialize): Check vs interface
3755 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3756
bf501fb9
PE
3757 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3758
e9829fdf
PE
3759 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3760 to read-only memory.
3761
1086c095
PE
3762 * fns.c (vector): Remove; this old hack is no longer needed.
3763
2baccd04 3764 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3765 Remove unused var.
dde42981 3766 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3767
72391843 3768 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3769
436c16df 3770 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3771 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3772 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3773
92bb796d 3774 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3775 (x_term_init): Remove local to avoid shadowing.
92bb796d 3776
764430a3 3777 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3778
3779 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3780 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3781
d1dfb56c
EZ
37822011-04-16 Eli Zaretskii <eliz@gnu.org>
3783
c4354cb4
EZ
3784 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3785
d1dfb56c
EZ
3786 Fix regex.c, syntax.c and friends for buffers > 2GB.
3787 * syntax.h (struct gl_state_s): Declare character position members
3788 EMACS_INT.
3789
3790 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3791
04f2d78b
CB
3792 * textprop.c (verify_interval_modification, interval_of):
3793 Declare arguments EMACS_INT.
d1dfb56c
EZ
3794
3795 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3796 EMACS_INT.
3797
3798 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3799
3800 * indent.c (Fvertical_motion): Local variable it_start is now
3801 EMACS_INT.
3802
3803 * regex.c (re_match, re_match_2, re_match_2_internal)
3804 (bcmp_translate, regcomp, regexec, print_double_string)
3805 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3806 (re_compile_pattern, re_exec): Declare arguments and local
3807 variables `size_t' and `ssize_t' and return values `regoff_t', as
3808 appropriate.
3809 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3810 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3811 <compile_stack_type>: `size' and `avail' are now `size_t'.
3812
3813 * regex.h <regoff_t>: Use ssize_t, not int.
3814 (re_search, re_search_2, re_match, re_match_2): Arguments that
3815 specify buffer/string position and length are now ssize_t and
3816 size_t. Return type is regoff_t.
3817
613052cd
BK
38182011-04-16 Ben Key <bkey76@gmail.com>
3819
3820 * nsfont.m: Fixed bugs in ns_get_family and
3821 ns_descriptor_to_entity that were caused by using free to
3822 deallocate memory blocks that were allocated by xmalloc (via
3823 xstrdup). This caused Emacs to crash when compiled with
3824 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3825 --enable-checking=xmallocoverrun). xfree is now used to
3826 deallocate these memory blocks.
3827
4170f62f 38282011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3829
71b41406
PE
3830 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3831
9587a89d
PE
3832 emacs_write: Accept and return EMACS_INT for sizes.
3833 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3834 et seq.
3835 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3836 Accept and return EMACS_INT.
3837 (emacs_gnutls_write): Return the number of bytes written on
3838 partial writes.
3839 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3840 (emacs_read, emacs_write): Remove check for negative size, as the
3841 Emacs source code has been audited now.
9587a89d
PE
3842 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3843 (emacs_read, emacs_write): Use it.
273a5f82
PE
3844 * process.c (send_process): Adjust to the new signatures of
3845 emacs_write and emacs_gnutls_write. Do not attempt to store
3846 a byte offset into an 'int'; it might overflow.
9587a89d 3847 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3848
3e047f51
PE
3849 * sound.c: Don't assume sizes fit in 'int'.
3850 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3851 Return EMACS_INT, not int.
3e047f51 3852 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3853 Accept EMACS_INT, not int.
3854 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3855 record read return values.
3856
cc39a9db
BK
38572011-04-15 Ben Key <bkey76@gmail.com>
3858
c9d0ec6d
JB
3859 * keyboard.c (Qundefined): Don't declare static since it is used
3860 in nsfns.m.
3861 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3862 static since they are used in nsfont.m.
cc39a9db 3863
6c60eb9f
SM
38642011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3865
3866 * process.c (Qprocessp): Don't declare static.
3867 * lisp.h (Qprocessp): Declare again.
3868
7990b61a
JB
38692011-04-15 Juanma Barranquero <lekktu@gmail.com>
3870
3871 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3872
5d4cb038
PE
38732011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3874
8bd7b830 3875 Improve C-level modularity by making more things 'static'.
cd64ea1d 3876
e3b27b31
PE
3877 Don't publish debugger-only interfaces to other modules.
3878 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3879 (verify_bytepos, count_markers): Move decls to the only modules
3880 that need them.
3881 * region-cache.h (pp_cache): Likewise.
3882 * window.h (check_all_windows): Likewise.
3883 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3884
5d4cb038
PE
3885 * sysdep.c (croak): Now static, if
3886 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3887 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3888
3889 * alloc.c (refill_memory_reserve): Now static if
3890 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3891 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3892
e87b6180
PE
3893 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3894 Define only if USE_LUCID.
3895
ac64929e
PE
3896 * xrdb.c (x_customization_string, x_rm_string): Now static.
3897
6f37259d
PE
3898 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3899 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3900
1683e3ab
PE
3901 * xdisp.c (draw_row_with_mouse_face): Now static.
3902 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3903
de9c2632
PE
3904 * window.h (check_all_windows): Mark externally visible.
3905
2b96acb7
PE
3906 * window.c (window_deletion_count): Now static.
3907
3908 * undo.c: Make symbols static if they're not exported.
3909 (last_undo_buffer, last_boundary_position, pending_boundary):
3910 Now static.
3911
50436f33
PE
3912 * textprop.c (interval_insert_behind_hooks): Now static.
3913 (interval_insert_in_front_hooks): Likewise.
3914
64520e5c
PE
3915 * term.c: Make symbols static if they're not exported.
3916 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3917 (max_frame_lines, tty_set_terminal_modes):
3918 (tty_reset_terminal_modes, tty_turn_off_highlight):
3919 (get_tty_terminal): Now static.
3920 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3921 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3922 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3923 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3924 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3925
1fa53021
PE
3926 * sysdep.c: Make symbols static if they're not exported.
3927 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3928 Now static.
3929 (sigprocmask_set, full_mask): Remove; unused.
3930 (wait_debugging): Mark as visible.
3931 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3932 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3933
d4b43b22
PE
3934 * syntax.c (syntax_temp): Define only if !__GNUC__.
3935
b7c513d0
PE
3936 * sound.c (current_sound_device, current_sound): Now static.
3937
989b29ad
PE
3938 * search.c (searchbufs, searchbuf_head): Now static.
3939
13a55a78
PE
3940 * scroll.c (scroll_cost): Remove; unused.
3941 * dispextern.h (scroll_cost): Remove decl.
3942
de68a1fc
PE
3943 * region-cache.h (pp_cache): Mark as externally visible.
3944
40ccffa6
PE
3945 * process.c: Make symbols static if they're not exported.
3946 (process_tick, update_tick, create_process, chan_process):
3947 (Vprocess_alist, proc_buffered_char, datagram_access):
3948 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3949 (deactivate_process): Mark defn as static, as well as decl.
3950 * lisp.h (create_process): Remove decl.
3951 * process.h (chan_process, Vprocess_alist): Remove decls.
3952
ad64fc97
PE
3953 * print.c: Make symbols static if they're not exported.
3954 (print_depth, new_backquote_output, being_printed, print_buffer):
3955 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3956 (print_interval, print_number_index, initial_stderr_stream):
3957 Now static.
3958 * lisp.h (Fprinc): Remove decl.
3959 (debug_output_compilation_hack): Mark as externally visible.
3960
adddb265
PE
3961 * sysdep.c (croak): Move decl from here to syssignal.h.
3962 * syssignal.h (croak): Put it here, so the API can be checked when
3963 'croak' is called from dissociate_if_controlling_tty.
3964
1717ede2
PE
3965 * minibuf.c: Make symbols static if they're not exported.
3966 (minibuf_save_list, choose_minibuf_frame): Now static.
3967 * lisp.h (choose_minibuf_frame): Remove decl.
3968
fa5fb2bc
PE
3969 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3970
1e3890d1
PE
3971 * lread.c: Make symbols static if they're not exported.
3972 (read_objects, initial_obarray, oblookup_last_bucket_number):
3973 Now static.
3974 (make_symbol): Remove; unused.
3975 * lisp.h (initial_obarray, make_symbol): Remove decls.
3976
8a1414fa
PE
3977 * keyboard.c: Make symbols static if they're not exported.
3978 (single_kboard, recent_keys_index, total_keys, recent_keys):
3979 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3980 (this_single_command_key_start, echoing, last_auto_save):
3981 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3982 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3983 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3984 (Vlispy_mouse_stem, double_click_count):
3985 Now static.
3986 (force_auto_save_soon): Define only if SIGDANGER.
3987 (ignore_mouse_drag_p): Now static if
3988 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3989 (print_help): Remove; unused.
3990 (stop_character, last_timer_event): Mark as externally visible.
3991 * keyboard.h (ignore_mouse_drag_p): Declare only if
3992 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3993 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3994 * lisp.h (echoing): Remove decl.
3995 (force_auto_save_soon): Declare only if SIGDANGER.
3996 * xdisp.c (redisplay_window): Simplify code, to make it more
3997 obvious that ignore_mouse_drag_p is not accessed if !defined
3998 USE_GTK && !defined HAVE_NS.
3999
93ea6e8f
PE
4000 * intervals.c: Make symbols static if they're not exported.
4001 (merge_properties_sticky, merge_interval_right, delete_interval):
4002 Now static.
4003 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4004
77382fcc
PE
4005 * insdel.c: Make symbols static if they're not exported.
4006 However, leave prepare_to_modify_buffer alone. It's never
4007 called from outside this function, but that appears to be a bug.
4008 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4009 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4010 (adjust_after_replace_noundo): Remove; unused.
4011 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4012 (signal_before_change): Remove decls.
77382fcc 4013
9306c32e
PE
4014 * indent.c (val_compute_motion, val_vmotion): Now static.
4015
cd44d2eb
PE
4016 * image.c: Make symbols static if they're not exported.
4017 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4018 if USE_GTK.
4019 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4020 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4021
ad9a7a06
PE
4022 * fringe.c (standard_bitmaps): Now static.
4023 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4024
81626931
PE
4025 * frame.c: Make symbols static if they're not exported.
4026 (x_report_frame_params, make_terminal_frame): Now static.
4027 (get_frame_param): Now static, unless HAVE_NS.
4028 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4029 (x_get_resource_string): Remove; not used.
4030 * frame.h (make_terminal_frame, x_report_frame_params):
4031 (x_get_resource_string); Remove decls.
4032 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4033 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4034
239f9db9
PE
4035 * font.c, fontset.c: Make symbols static if they're not exported.
4036 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4037 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4038 * font.c (font_close_object): Now static.
4039 * font.h (font_close_object): Remove.
4040 * fontset.c (FONTSET_OBJLIST): Remove.
4041 (free_realized_fontset) #if-0 the body, which does nothing.
4042 (face_suitable_for_char_p): #if-0, as it's never called.
4043 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4044 * xfaces.c (face_at_string_position):
4045 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4046 since 0 is always ASCII.
4047
dfcf3579
PE
4048 * fns.c (weak_hash_tables): Now static.
4049
5045092b
PE
4050 * fileio.c: Make symbols static if they're not exported.
4051 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4052 (Vwrite_region_annotation_buffers): Now static.
4053
57a96f5c
PE
4054 * eval.c: Make symbols static if they're not exported.
4055 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4056 * lisp.h (backtrace_list): Remove decl.
4057
35f08c38
PE
4058 * emacs.c: Make symbols static if they're not exported.
4059 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4060 (fatal_error_code, fatal_error_signal_hook, standard_args):
4061 Now static.
4062 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4063 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4064 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4065 * lisp.h (fatal_error_signal_hook): Remove decl.
4066 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4067
f44bd759
PE
4068 * editfns.c: Move a (normally-unused) function to its only use.
4069 * editfns.c, lisp.h (get_operating_system_release): Remove.
4070 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4071 worth the hassle of breaking this out.
4072
b532497d
PE
4073 * xterm.c: Make symbols static if they're not exported.
4074 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4075 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4076 (x_destroy_window, x_delete_display):
4077 Now static.
4078 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4079 (x_mouse_leave): Remove; unused.
4080 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4081 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4082 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4083 Remove decls.
4084 (x_mouse_leave): Declare only if WINDOWSNT.
4085 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4086 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4087 USE_X_TOOLKIT.
4088
1675728f
PE
4089 * ftxfont.c: Make symbols static if they're not exported.
4090 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4091 HAVE_FREETYPE.
4092 * font.h (ftxfont_driver): Likewise.
4093
e4cebfca
PE
4094 * xfns.c: Make symbols static if they're not exported.
4095 (x_last_font_name, x_display_info_for_name):
4096 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4097 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4098 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4099 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4100 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4101 (last_show_tip_args): Now static.
4102 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4103 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4104 (x_screen_planes): Remove; unused.
4105 * dispextern.h (x_screen_planes): Remove decl.
4106
5bf46f05
PE
4107 * dispnew.c: Make symbols static if they're not exported.
4108 * dispextern.h (redraw_garbaged_frames, scrolling):
4109 (increment_row_positions): Remove.
4110 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4111 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4112 Now static.
4113 (redraw_garbaged_frames): Remove; unused.
4114
435f4c28
PE
4115 * xfaces.c: Make symbols static if they're not exported.
4116 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4117 Remove decls.
4118 * xterm.h (defined_color): Remove decls.
4119 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4120 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4121 (menu_face_changed_default, defined_color, free_realized_face):
4122 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4123 (ascii_face_of_lisp_face): Remove; unused.
4124
8524aef3
PE
4125 * xdisp.c: Make symbols static if they're not exported.
4126 * dispextern.h (scratch_glyph_row, window_box_edges):
4127 (glyph_to_pixel_coords, set_cursor_from_row):
4128 (get_next_display_element, set_iterator_to_next):
4129 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4130 (show_mouse_face): Remove decls
4131 * frame.h (message_buf_print): Likewise.
4132 * lisp.h (pop_message, set_message, check_point_in_composition):
4133 Likewise.
4134 * xterm.h (set_vertical_scroll_bar): Likewise.
4135 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4136 (message_buf_print, scratch_glyph_row, displayed_buffer):
4137 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4138 (get_next_display_element, show_mouse_face, window_box_edges):
4139 (frame_to_window_pixel_xy, check_point_in_composition):
4140 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4141 (glyph_to_pixel_coords): Remove; unused.
4142
16390cd2
PE
4143 * dired.c (file_name_completion): Now static.
4144
4145 * dbusbind.c (xd_in_read_queued_messages): Now static.
4146
a25f4dfa
PE
4147 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4148 * data.c (circular_list_error): Remove.
4149
14a9c8df
PE
4150 * commands.h (last_point_position, last_point_position_buffer):
4151 (last_point_position_window): Remove decls.
4152 * keyboard.c: Make these variables static.
4153
04f2d78b
CB
4154 * coding.h (coding, code_convert_region, encode_coding_gap):
4155 Remove decls.
74ab6df5
PE
4156 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4157 (iso_code_class, detect_coding, code_convert_region): Now static.
4158 (encode_coding_gap): Remove; unused.
4159
38dfbee1
PE
4160 * chartab.c (chartab_chars, chartab_bits): Now static.
4161
a2cb4e63
PE
4162 * charset.h (charset_iso_8859_1): Remove decl.
4163 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4164 Now static.
4165
127198fd
PE
4166 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4167 * ccl.c (Vccl_program_table): Now static.
4168 (check_ccl_update): Remove; unused.
4169
d85b608f
PE
4170 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4171 * category.h: ... from here.
4172 * category.c (check_category_table, set_category_set): Now static.
4173
31cd66f3
PE
4174 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4175 * lisp.h: Remove these decls.
4176
c358e587
PE
4177 * buffer.c (buffer_count): Remove unused var.
4178
e78aecca
PE
4179 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4180 so that it's not optimized away.
4181 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4182 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4183 exported only to the debugger.
4184
e192d7d3 4185 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4186 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4187
92470028
PE
4188 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4189 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4190 was inaccessible from Lisp.
4191 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4192 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4193
244ed907
PE
4194 alloc.c: Import and export fewer symbols, and remove unused items.
4195 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4196 is defined.
4197 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4198 it's not optimized away by whole-program optimization.
4199 (message_enable_multibyte, free_misc): Remove.
4200 (catchlist, handlerlist, mark_backtrace):
4201 Declare only if BYTE_MARK_STACK.
4202 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4203 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4204 (message_enable_multibyte): Remove decl.
4205 (free_misc, interval_free_list, float_block, float_block_index):
4206 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4207 (cons_free_list, last_marked_index):
4208 Now static.
4209 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4210 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4211 (mark_backtrace): Define only if BYTE_MARK_STACK.
4212 * xdisp.c (message_enable_multibyte): Now static.
4213
61c2b50e 4214 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4215 This makes it easier for human readers (and static analyzers)
4216 to see whether these variables are used from other modules.
4217 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4218 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4219 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4220 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4221 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4222 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4223 * xmenu.c, xselect.c:
4224 Declare Q* vars static if they are not used in other modules.
4225 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4226 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4227 Remove decls of unexported vars.
4228 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4229
95c82688
PE
4230 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4231
16a97296
PE
4232 Make Emacs functions such as Fatom 'static' by default.
4233 This makes it easier for human readers (and static analyzers)
4234 to see whether these functions can be called from other modules.
4235 DEFUN now defines a static function. To make the function external
4236 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4237 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4238 (Finit_image_library):
16a97296
PE
4239 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4240 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4241 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4242 Remove decls, since these functions are now static.
4243 (Funintern, Fget_internal_run_time): New decls, since these functions
4244 were already external.
95c82688 4245
16a97296
PE
4246 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4247 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4248 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4249 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4250 * keyboard.c, keymap.c, lread.c:
4251 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4252 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4253 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4254 Mark functions with DEFUE instead of DEFUN,
4255 if they are used in other modules.
4256 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4257 decls for now-static functions.
4258 * buffer.h (Fdelete_overlay): Remove decl.
4259 * callproc.c (Fgetenv_internal): Mark as internal.
4260 * composite.c (Fremove_list_of_text_properties): Remove decl.
4261 (Fcomposition_get_gstring): New forward static decl.
4262 * composite.h (Fcomposite_get_gstring): Remove decl.
4263 * dired.c (Ffile_attributes): New forward static decl.
4264 * doc.c (Fdocumntation_property): New forward static decl.
4265 * eval.c (Ffetch_bytecode): New forward static decl.
4266 (Funintern): Remove extern decl; now in .h file where it belongs.
4267 * fileio.c (Fmake_symbolic_link): New forward static decl.
4268 * image.c (Finit_image_library): New forward static decl.
4269 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4270 * intervals.h (Fprevious_property_change):
4271 (Fremove_list_of_text_properties): Remove decls.
4272 * keyboard.c (Fthis_command_keys): Remove decl.
4273 (Fcommand_execute): New forward static decl.
4274 * keymap.c (Flookup_key): New forward static decl.
4275 (Fcopy_keymap): Now static.
4276 * keymap.h (Flookup_key): Remove decl.
4277 * process.c (Fget_process): New forward static decl.
4278 (Fprocess_datagram_address): Mark as internal.
4279 * syntax.c (Fsyntax_table_p): New forward static decl.
4280 (skip_chars): Remove duplicate decl.
4281 * textprop.c (Fprevious_property_change): New forward static decl.
4282 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4283 Now internal.
4284 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4285 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4286
785bbd42
PE
4287 * editfns.c (Fformat): Remove unreachable code.
4288
8b913b57
AS
42892011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4290
4291 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4292 change. (Bug#8496)
4293
a6744a35
EZ
42942011-04-13 Eli Zaretskii <eliz@gnu.org>
4295
4296 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4297 when at ZV. (Bug#8487)
4298
e7974947
AS
42992011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4300
baad03f0
AS
4301 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4302 (Bug#8437)
4303 * keyboard.c (parse_tool_bar_item): Likewise.
4304 * sound.c (sound_cleanup, alsa_close): Likewise.
4305 * termcap.c (tgetent): Likewise.
4306 * xfns.c (x_default_font_parameter): Likewise.
4307 * xsettings.c (read_and_apply_settings): Likewise.
4308
e7974947
AS
4309 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4310 (overrun_check_free): Protoize.
4311
28272684
PE
43122011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4313
4314 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4315 since callers should never pass a negative size.
4316 Change the signature to match that of plain 'read' and 'write'; see
4317 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4318 * lisp.h: Update prototypes of emacs_write and emacs_read.
4319
11997c76
EZ
43202011-04-11 Eli Zaretskii <eliz@gnu.org>
4321
4322 * xdisp.c (redisplay_window): Don't try to determine the character
4323 position of the scroll margin if the window start point w->startp
e896f03c 4324 is outside the buffer's accessible region. (Bug#8468)
11997c76 4325
8a2cbd72
EZ
43262011-04-10 Eli Zaretskii <eliz@gnu.org>
4327
4328 Fix write-region and its subroutines for buffers > 2GB.
4329 * fileio.c (a_write, e_write): Modify declaration of arguments and
4330 local variables to support buffers larger than 2GB.
4331 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4332
4333 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4334 argument, local variables, and return value.
4335
4336 * lisp.h: Update prototypes of emacs_write and emacs_read.
4337
4338 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4339
4073e537 43402011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4341
1ebfdcb6
PE
4342 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4343
b2ded58d
PE
4344 Fix more problems found by GCC 4.6.0's static checks.
4345
7d66342c
PE
4346 * xdisp.c (vmessage): Use a better test for character truncation.
4347
bbf47d44
PE
4348 * charset.c (load_charset_map): <, not <=, for optimization,
4349 and to avoid potential problems with integer overflow.
9248994d 4350 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4351 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4352 * editfns.c (Fformat): Likewise.
1e69125e 4353 * syntax.c (skip_chars): Likewise.
3befa583 4354
e3019616
PE
4355 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4356 This also lets GCC 4.6.0 generate slightly better loop code.
4357
becfa255
PE
4358 * callint.c (Fcall_interactively): <, not <=, for optimization.
4359 (Fcall_interactively): Count the number of arguments produced,
4360 not the number of arguments given. This is simpler and lets GCC
4361 4.6.0 generate slightly better code.
4362
dae0cd48
PE
4363 * ftfont.c: Distingish more carefully between FcChar8 and char.
4364 The previous code passed unsigned char * to a functions like
4365 strlen and xstrcasecmp that expect char *, which does not
4366 conform to the C standard.
4367 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4368 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4369 char * when the C standard requires it.
4370
76032d70
PE
4371 * keyboard.c (read_char): Remove unused var.
4372
eb3f1cc8
PE
4373 * eval.c: Port to Windows vsnprintf (Bug#8435).
4374 Include <limits.h>.
4375 (SIZE_MAX): Define if the headers do not.
4376 (verror): Do not give up if vsnprintf returns a negative count.
4377 Instead, grow the buffer. This ports to Windows vsnprintf, which
4378 does not conform to C99. Problem reported by Eli Zaretskii.
4379 Also, simplify the allocation scheme, by avoiding the need for
4380 calling realloc, and removing the ALLOCATED variable.
4381
70476b54
PE
4382 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4383
12020a9e
PE
4384 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4385 But keep the doprint source code for now, as we might revamp it
4386 and use it again (Bug#8435).
ea6c7ae6
PE
4387 * lisp.h (doprnt): Remove.
4388 * Makefile.in (base_obj): Remove doprnt.o.
4389 * deps.mk (doprnt.o): Remove.
4390
5fdb398c
PE
4391 error: Print 32- and 64-bit integers portably (Bug#8435).
4392 Without this change, on typical 64-bit hosts error ("...%d...", N)
4393 was used to print both 32- and 64-bit integers N, which relied on
4394 undefined behavior.
4395 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4396 New macro.
4397 * lisp.h (error, verror): Mark as printf-like functions.
4398 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4399 Report overflow in size calculations when allocating printf buffer.
4400 Do not truncate output string at its first null byte.
4401 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4402 Truncate the output at a character boundary, since vsnprintf does not
4403 do that.
4404 * charset.c (check_iso_charset_parameter): Convert internal
4405 character to string before calling 'error', since %c now has the
4406 printf meaning.
4407 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4408 overflow when computing char to be passed to 'error'. Do not
4409 pass Lisp_Object to 'error'; pass the integer instead.
4410 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4411 formatted with plain %d.
4412
b189fa66
PE
4413 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4414
bff87ef0
PE
4415 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4416
7e2cac20
PE
4417 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4418
ce4d90b5
PE
4419 * xterm.c (x_catch_errors): Remove duplicate declaration.
4420
266c9547
PE
4421 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4422
79c49ad2
PE
4423 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4424
368f4090
JM
44252011-04-10 Jim Meyering <meyering@redhat.com>
4426
4427 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4428 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4429 return ssize_t not "int", and use size_t as the buffer length.
4430 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4431 * gnutls.h: Update declarations.
4432 * process.c (read_process_output): Use ssize_t, to match.
4433 (send_process): Likewise.
4434
a32d4040
CY
44352011-04-09 Chong Yidong <cyd@stupidchicken.com>
4436
4437 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4438
8546720e 44392011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4440
04f2d78b
CB
4441 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4442 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4443
8546720e
GM
4444 * xterm.c (handle_one_xevent):
4445 * xmenu.c (create_and_show_popup_menu):
4446 * xselect.c (x_decline_selection_request)
4447 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4448
0a2f5c1a 44492011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4450
4451 Fix some uses of `int' instead of EMACS_INT.
4452 * search.c (string_match_1, fast_string_match)
4453 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4454 (scan_buffer, find_next_newline_no_quit)
4455 (find_before_next_newline, search_command, Freplace_match)
4456 (Fmatch_data): Make some `int' variables be EMACS_INT.
4457
4458 * xdisp.c (display_count_lines): 3rd argument and return value now
4459 EMACS_INT. All callers changed.
4460 (pint2hrstr): Last argument is now EMACS_INT.
4461
4462 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4463 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4464 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4465 (decode_coding_utf_16, decode_coding_emacs_mule)
4466 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4467 (decode_coding_ccl, decode_coding_charset)
4468 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4469 (decode_coding_iso_2022, decode_coding_emacs_mule)
4470 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4471 <char_offset, last_offset>: Declare EMACS_INT.
4472 (encode_coding_utf_8, encode_coding_utf_16)
4473 (encode_coding_emacs_mule, encode_invocation_designation)
4474 (encode_designation_at_bol, encode_coding_iso_2022)
4475 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4476 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4477 Declare EMACS_INT.
4478 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4479 (encode_invocation_designation): Last argument P_NCHARS is now
4480 EMACS_INT.
4481 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4482 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4483
4484 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4485 All users changed.
4486
4487 * ccl.c (Fccl_execute_on_string): Declare some variables
4488 EMACS_INT.
4489
8546720e 44902011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4491
4492 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4493
4e19a977
CS
44942011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4495
4496 * process.c (Fformat_network_address): Doc fix.
4497
87302331
R
44982011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4499
4500 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4501
cbb59342
CY
45022011-04-08 Chong Yidong <cyd@stupidchicken.com>
4503
4504 * keyboard.c (read_char): Call Lisp function help-form-show,
4505 instead of using internal_with_output_to_temp_buffer.
4506 (Qhelp_form_show): New var.
e0d38eeb 4507 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4508
4509 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4510
4511 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4512
e67a13ab
CY
45132011-04-06 Chong Yidong <cyd@stupidchicken.com>
4514
04f2d78b
CB
4515 * process.c (Flist_processes): Remove to Lisp.
4516 (list_processes_1): Delete.
e67a13ab 4517
973f782d
EZ
45182011-04-06 Eli Zaretskii <eliz@gnu.org>
4519
7c106b1e
EZ
4520 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4521
973f782d
EZ
4522 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4523
41cf7d1a 45242011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4525
ca23cc88
PE
4526 Fix more problems found by GCC 4.6.0's static checks.
4527
f390e2d5
PE
4528 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4529
42eea0d0
PE
4530 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4531
b69769da 4532 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4533
f9541e84
PE
4534 * xdisp.c (vmessage): Mark as a printf-like function.
4535
13841b55
PE
4536 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4537
c136c10f
PE
4538 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4539
5e2d4a30
PE
4540 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4541 printf-like functions.
4542 (tiff_load): Add casts to remove these marks before passing them
4543 to system-supplied API.
4544
583f48b9
PE
4545 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4546
b25d760e
PE
4547 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4548 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4549 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4550 directly, rather than having caller test rule sign. This avoids
4551 some unnecessary tests.
4552 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4553 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4554 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4555
bc7b6697 4556 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4557 (xfont_open): Avoid unnecessary tests.
bc7b6697 4558
27ccc379
PE
4559 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4560
dcd5c89a
PE
4561 * composite.h, composite.c (composition_gstring_put_cache):
4562 Use EMACS_INT, not int, for length.
4563
b13a45c6
PE
4564 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4565 breaking out part of COMPOSITION_DECODE_RULE.
4566 (COMPOSITION_DECODE_RULE): Use it.
4567 * composite.c (get_composition_id): Remove unused local vars,
4568 by using the new macro.
4569
1e792e4d
PE
4570 * textprop.c (set_text_properties_1): Change while to do-while,
4571 since the condition is always true at first.
4572
dc6c6455 4573 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4574 (interval_deletion_adjustment): Return unsigned value.
4575 All uses changed.
dc6c6455 4576
aba7731a
PE
4577 * process.c (list_processes_1, create_pty, read_process_output):
4578 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4579 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4580 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4581 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4582 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4583
fdfc4bf3
PE
4584 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4585
fca8fe46 4586 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4587 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4588
06a0259a 4589 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4590 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4591 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4592
e7b9e80f
PE
4593 * print.c (print_error_message): Avoid int overflow.
4594
56201685
PE
4595 * font.c (font_list_entities): Redo for clarity,
4596 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4597
78834453 4598 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4599 (font_score): Avoid potential overflow in diff calculation.
78834453 4600
0bc0b309 4601 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4602 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4603
e610eaca
PE
4604 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4605
b895abce
PE
4606 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4607 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4608 can always succeed if overflow has undefined behavior.
4609
1f1d9321 4610 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4611 (wordify): Omit three unnecessary tests.
1f1d9321 4612
c59478bc
PE
4613 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4614 All callers changed. This avoids the need for an unused var.
4615
79b73827
PE
4616 * casefiddle.c (casify_region): Remove var that is set but not used.
4617
a4db5dfe
PE
4618 * dired.c (file_name_completion): Remove var that is set but not used.
4619
43aae36e
PE
4620 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4621
2a47c44d 4622 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4623 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4624
a37c69bf
PE
4625 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4626 Check for integer overflow on size calculations.
4627
328ab8e7
PE
4628 * buffer.c (Fprevious_overlay_change): Remove var that is set
4629 but not used.
4630
e5a2a5cb
PE
4631 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4632 Remove vars that are set but not used.
8d84a6eb 4633 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4634 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4635
a60e5f68
PE
4636 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4637
f661cb61 4638 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4639 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4640
f0397f5a
PE
4641 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4642 that are set but not used.
4643
8664db06 4644 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4645 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4646
6abdaa4a
PE
4647 * xselect.c (x_get_local_selection, x_handle_property_notify):
4648 Remove vars that are set but not used.
4649
0ce7538d 4650 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4651 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4652
9ae848fc
PE
4653 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4654 Remove var that is set but not used.
0b918413
PE
4655 (scroll_bar_windows_size): Now size_t, not int.
4656 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4657 Check for overflow.
9ae848fc 4658
a5a62657
PE
4659 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4660 (map_tty_color) [!defined MSDOS]: Likewise.
4661
5c5cdd39
PE
4662 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4663
66ebf983
PE
4664 * coding.c: Remove vars that are set but not used.
4665 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4666 All callers changed.
4667 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4668 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4669 (decode_coding_charset): Remove vars that are set but not used.
4670
1be4d761
PE
4671 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4672 that is set but not used.
4673
47553fa8
PE
4674 * print.c (print_object): Remove var that is set but not used.
4675
1f7196bf 4676 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4677 The gnulib version avoids calling malloc in the usual case,
4678 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4679 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4680 * filelock.c (current_lock_owner): Likewise.
4681 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4682 * sysdep.c: Include allocator.h, careadlinkat.h.
4683 (emacs_no_realloc_allocator): New static constant.
4684 (emacs_readlink): New function.
fdb61804
PE
4685 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4686 ../lib/careadlinkat.h.
d1fdcab7 4687
f84c17c7
SM
46882011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4689
4690 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4691 first non-nil return value).
4692
ef3862ad
JD
46932011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4694
4695 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4696 if not defined (Bug#8403).
4697
376a7006
JB
46982011-04-02 Juanma Barranquero <lekktu@gmail.com>
4699
4700 * xdisp.c (display_count_lines): Remove parameter `start',
4701 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4702 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4703 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4704 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4705 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4706 and thereabouts. All callers changed.
4707 (get_per_char_metric): Remove parameter `f', unused since
4708 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4709
6ca3801d
JM
47102011-04-02 Jim Meyering <meyering@redhat.com>
4711
4712 do not dereference NULL upon failed strdup
4713 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4714 (ns_get_family): Likewise.
4715
d8e2b5ba
JB
47162011-04-02 Juanma Barranquero <lekktu@gmail.com>
4717
4718 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4719
8c74fcbd
JD
47202011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4721
4722 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4723 later (Bug#8403).
4724
7200d79c
SM
47252011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4726
03408648 4727 Add lexical binding.
7200d79c 4728
03408648
SM
4729 * window.c (Ftemp_output_buffer_show): New fun.
4730 (Fsave_window_excursion):
4731 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4732
4733 * lread.c (lisp_file_lexically_bound_p): New function.
4734 (Fload): Bind Qlexical_binding.
4735 (readevalloop): Remove `evalfun' arg.
4736 Bind Qinternal_interpreter_environment.
4737 (Feval_buffer): Bind Qlexical_binding.
4738 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4739 Mark as dynamic.
4740 (syms_of_lread): Declare `lexical-binding'.
4741
4742 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4743
4744 * keyboard.c (eval_dyn): New fun.
4745 (menu_item_eval_property): Use it.
ca105506
SM
4746
4747 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4748
03408648
SM
4749 * fns.c (concat, mapcar1): Accept byte-code-functions.
4750
4751 * eval.c (Fsetq): Handle lexical vars.
4752 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4753 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4754 (FletX, Flet): Obey lexical binding.
4755 (Fcommandp): Handle closures.
4756 (Feval): New `lexical' arg.
4757 (eval_sub): New function extracted from Feval. Use it almost
4758 everywhere where Feval was used. Look up vars in lexical env.
4759 Handle closures.
4760 (Ffunctionp): Move from subr.el.
4761 (Ffuncall): Handle closures.
4762 (apply_lambda): Remove `eval_flags'.
4763 (funcall_lambda): Handle closures and new byte-code-functions.
4764 (Fspecial_variable_p): New function.
4765 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4766 but without exporting it to Lisp.
23aba0ea 4767
23aba0ea 4768 * doc.c (Fdocumentation, store_function_docstring):
03408648 4769 * data.c (Finteractive_form): Handle closures.
23aba0ea 4770
03408648
SM
4771 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4772 interactive spec.
ba83908c 4773
04f2d78b
CB
4774 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4775 New byte-codes.
03408648
SM
4776 (exec_byte_code): New function extracted from Fbyte_code to handle new
4777 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4778
03408648 4779 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4780
03408648 4781 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4782
e2abce01
JB
47832011-03-31 Juanma Barranquero <lekktu@gmail.com>
4784
4785 * xdisp.c (redisplay_internal): Fix prototype.
4786
63696a73 47872011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4788
63696a73 4789 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4790 (try_scrolling): Use it when setting scroll_limit.
4791 Limit scrolling to 100 screen lines.
63696a73
EZ
4792 (redisplay_window): Even when falling back on "recentering",
4793 position point in the window according to scroll-conservatively,
4794 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4795
4796 (try_scrolling): When point is above the window, allow searching
4797 as far as scroll_max, or one screenful, to compute vertical
4798 distance from PT to the scroll margin position. This prevents
4799 try_scrolling from unnecessarily failing when
4800 scroll-conservatively is set to a value slightly larger than the
4801 window height. Clean up the case of PT below the margin at bottom
4802 of window: scroll_max can no longer be INT_MAX. When aggressive
4803 scrolling is in use, don't let point enter the opposite scroll
4804 margin as result of the scroll.
4805 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4806 threshold of 100 lines for never-recentering scrolling.
4807
e4cc2dfc
JB
48082011-03-31 Juanma Barranquero <lekktu@gmail.com>
4809
4810 * dispextern.h (move_it_by_lines):
4811 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4812 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4813 (message_log_check_duplicate): Remove parameters `prev_bol' and
4814 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4815 (redisplay_internal): Remove parameter `preserve_echo_area',
4816 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4817
4818 * indent.c (Fvertical_motion):
4819 * window.c (window_scroll_pixel_based, Frecenter):
4820 Don't pass `need_y_p' to `move_it_by_lines'.
4821
1c470562
SM
48222011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4823
44f230aa
SM
4824 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4825 steal a few bits to be more compact.
4826 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4827 Remove unneeded casts.
4828
1c470562
SM
4829 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4830
888adce9
ZK
48312011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4832
4833 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4834 binding" message (bug#7967).
4835
f838ed7b
PE
48362011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4837
77861b95
PE
4838 Fix more problems found by GCC 4.6.0's static checks.
4839
de6dbc14
PE
4840 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4841 Remove unused local var.
4842
f838ed7b
PE
4843 * editfns.c (Fmessage_box): Remove unused local var.
4844
792c7b2b
PE
4845 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4846 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4847 Omit unused local vars.
c499e557 4848 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4849 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4850 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4851 Omit unused local var.
4852
ba0165e1
PE
4853 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4854 Don't assume string length fits in int.
32ad8845 4855 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4856 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4857
3c59b4c9
PE
4858 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4859 instead of alloca (Bug#8344).
4860
a3eed478 4861 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4862 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4863
eb4d412d
PE
4864 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4865
1658b401
PE
4866 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4867 concerns.
4868
4869 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4870
4871 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4872
9a2c6e05
PE
4873 * keyboard.c (syms_of_keyboard): Use the same style as later
4874 in this function when indexing through an array. This also
4875 works around GCC bug 48267.
4876
03d0a109
PE
4877 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4878
44f730c8
PE
4879 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4880
fe75f926
PE
4881 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4882 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4883
ffa8c828
PE
4884 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4885 This avoids undefined behavior on integer overflow, and is a bit
4886 more convenient anyway since it is compared to a size_t variable.
4887
c5101a77
PE
4888 Variadic C functions now count arguments with size_t, not int.
4889 This avoids an unnecessary limitation on 64-bit machines, which
4890 caused (substring ...) to crash on large vectors (Bug#8344).
4891 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4892 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4893 All variadic functions and their callers changed accordingly.
c5101a77
PE
4894 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4895 * data.c (arith_driver, float_arith_driver): Likewise.
4896 * editfns.c (general_insert_function): Likewise.
4897 * eval.c (struct backtrace.nargs, interactive_p)
4898 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4899 (funcall_lambda, mark_backtrace): Likewise.
4900 * fns.c (concat): Likewise.
4901 * frame.c (x_set_frame_parameters): Likewise.
4902 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4903 0 if not found, not -1. All callers changed.
4904
dd3f25f7
PE
4905 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4906 (stack_copy_size): Now size_t, not int.
4907 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4908
461c2ab9
JB
49092011-03-28 Juanma Barranquero <lekktu@gmail.com>
4910
4911 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4912 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4913 All callers changed.
4914
4915 * lisp.h (multibyte_char_to_unibyte):
4916 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4917 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4918 * character.h (CHAR_TO_BYTE8):
4919 * cmds.c (internal_self_insert):
4920 * editfns.c (general_insert_function):
4921 * keymap.c (push_key_description):
4922 * search.c (Freplace_match):
4923 * xdisp.c (message_dolog, set_message_1): All callers changed.
4924
f6d62986
SM
49252011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4926
4927 * keyboard.c (safe_run_hook_funcall): New function.
4928 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4929 don't set the hook to nil, but remove the offending function instead.
4930 (Qcommand_hook_internal): Remove, unused.
4931 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4932 Vcommand_hook_internal.
4933
4934 * eval.c (enum run_hooks_condition): Remove.
4935 (funcall_nil, funcall_not): New functions.
4936 (run_hook_with_args): Call each function through a `funcall' argument.
4937 Remove `cond' argument, now redundant.
4938 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4939 (Frun_hook_with_args_until_failure): Adjust accordingly.
4940 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4941
1db5b1ad
JB
49422011-03-28 Juanma Barranquero <lekktu@gmail.com>
4943
4944 * dispextern.h (string_buffer_position): Remove declaration.
4945
4946 * print.c (strout): Remove parameter `multibyte', unused since
4947 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4948
4949 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4950 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4951 All callers changed.
4952
4953 * w32.c (_wsa_errlist): Use braces for struct initializers.
4954
4955 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4956 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4957 All callers changed.
4958 (string_buffer_position): Likewise. Also, make static (it's never
4959 used outside xdisp.c).
4960 (cursor_row_p): Remove parameter `w', unused since
4961 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4962 (decode_mode_spec): Remove parameter `precision', introduced during
4963 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4964 All callers changed.
4965
5ffb62aa
JD
49662011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4967
4968 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4969
461c2ab9 49702011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4971
4972 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4973 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4974 (ns_update_auto_hide_menu_bar): New functions.
4975 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4976 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4977 ns_constrain_all_frames.
4978 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4979 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4980
5c380ffb
JD
49812011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4982
4983 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4984
9af30bdf
GM
49852011-03-27 Glenn Morris <rgm@gnu.org>
4986
4987 * syssignal.h: Replace RETSIGTYPE with void.
4988 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4989 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4990 Replace SIGTYPE with void everywhere.
4991 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4992 * s/template.h (SIGTYPE): Remove commented out definition.
4993
e2abce01
JB
49942011-03-26 Eli Zaretskii <eliz@gnu.org>
4995
4996 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4997 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4998
f868cd8a
JB
49992011-03-26 Juanma Barranquero <lekktu@gmail.com>
5000
59eb0929
JB
5001 * w32.c (read_unc_volume): Use parameter `henum', instead of
5002 global variable `wget_enum_handle'.
5003
5004 * keymap.c (describe_vector): Remove parameters `indices' and
5005 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5006 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5007
f868cd8a
JB
5008 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5009
5010 * keyboard.c (timer_check): Remove parameter `do_it_now',
5011 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5012 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5013 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5014
5015 * keyboard.c (read_char):
5016 * w32menu.c (w32_menu_display_help):
5017 * xmenu.c (show_help_event, menu_help_callback):
5018 Adjust calls to `show_help_echo'.
5019
5020 * gtkutil.c (xg_maybe_add_timer):
5021 * keyboard.c (readable_events):
5022 * process.c (wait_reading_process_output):
5023 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5024
5025 * insdel.c (adjust_markers_gap_motion):
5026 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5027 (gap_left, gap_right): Don't call it.
5028
2ecf6fdb
CY
50292011-03-25 Chong Yidong <cyd@stupidchicken.com>
5030
5031 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5032 incurred during fontification.
5033
6b1f9ba4
JB
50342011-03-25 Juanma Barranquero <lekktu@gmail.com>
5035
5036 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5037 (DEFVAR_PER_BUFFER): Don't pass it.
5038
5039 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5040 (scrolling_window): Don't pass it.
5041
0f4a96b5
JB
50422011-03-25 Juanma Barranquero <lekktu@gmail.com>
5043
5044 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5045
5046 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5047 and `suffix'.
5048 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5049 of variables specific to SELinux and computation of `encoded_absname'.
5050
5051 * image.c (XPutPixel): Remove unused variable `height'.
5052
5053 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5054
5055 * unexw32.c (get_section_info): Remove unused variable `section'.
5056
5057 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5058 (system_process_attributes): Remove unused variable `sess'.
5059 (sys_read): Remove unused variable `err'.
5060
5061 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5062 (w32_wnd_proc): Remove unused variable `isdead'.
5063 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5064 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5065 (x_create_tip_frame): Remove unused variable `tem'.
5066
5067 * w32inevt.c (w32_console_read_socket):
5068 Remove unused variable `no_events'.
5069
5070 * w32term.c (x_draw_composite_glyph_string_foreground):
5071 Remove unused variable `width'.
5072
1149507c
JB
50732011-03-24 Juanma Barranquero <lekktu@gmail.com>
5074
5075 * w32term.c (x_set_glyph_string_clipping):
5076 Don't pass uninitialized region to CombineRgn.
5077
9c88f339
JB
50782011-03-23 Juanma Barranquero <lekktu@gmail.com>
5079
5080 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5081 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5082 (Fx_close_connection): Remove unused variable `i'.
5083
5084 * w32font.c (w32font_draw): Return number of glyphs.
5085 (w32font_open_internal): Remove unused variable `i'.
5086 (w32font_driver): Add missing initializer.
5087
5088 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5089 (fill_in_menu): Remove unused variable `items_added'.
5090
5091 * w32term.c (last_mouse_press_frame): Remove static global variable.
5092 (w32_clip_to_row): Remove unused variable `f'.
5093 (x_delete_terminal): Remove unused variable `i'.
5094
5095 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5096 (NOTHING): Remove unused static global variable.
5097 (uniscribe_check_otf): Remove unused variable `table'.
5098 (uniscribe_font_driver): Add missing initializers.
5099
dee091a3
JD
51002011-03-23 Julien Danjou <julien@danjou.info>
5101
5102 * term.c (Fsuspend_tty, Fresume_tty):
5103 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5104 * window.c (temp_output_buffer_show):
5105 * insdel.c (signal_before_change):
5106 * frame.c (Fhandle_switch_frame):
5107 * fileio.c (Fdo_auto_save):
5108 * emacs.c (Fkill_emacs):
5109 * editfns.c (save_excursion_restore):
5110 * cmds.c (internal_self_insert):
5111 * callint.c (Fcall_interactively):
5112 * buffer.c (Fkill_all_local_variables):
5113 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5114 Use Frun_hooks.
0f4a96b5 5115 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5116 unconditionnaly since it does the check itself.
5117
2c520ab5 51182011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5119
c9c49752
PE
5120 Fix more problems found by GCC 4.5.2's static checks.
5121
8abc3f12
PE
5122 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5123 the first time through the loop, since we know p0 < p1 then.
5124 This also avoids a gcc -Wstrict-overflow warning.
5125
a2d26660
PE
5126 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5127 leading to a memory leak, possible in functions like
5128 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5129 of objects (Bug#8318).
a2d26660 5130
916c72e9
PE
5131 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5132 that could (at least in theory) be that large.
5133
19ab8a18
PE
5134 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5135 This is less likely to overflow, and avoids undefined behavior if
5136 overflow does occur. All callers changed. Use strtoul to scan
5137 for the unsigned long integer.
b7cbbd6f
PE
5138 (pint2hrstr): Simplify and tune code slightly.
5139 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5140
f0641eff
PE
5141 * scroll.c (do_scrolling): Work around GCC bug 48228.
5142 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5143
7f650bb9
PE
5144 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5145 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5146 (validate_x_resource_name): Simplify count usage.
5147 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5148
37dd57d1
PE
5149 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5150 fail (Bug#8306).
81e56e61 5151
699979fc 5152 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5153
401bf9b4
PE
5154 * process.c (Fmake_network_process): Use socklen_t, not int,
5155 where POSIX says socklen_t is required in portable programs.
5156 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5157 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5158 (Fmake_network_process, server_accept_connection):
5159 (wait_reading_process_output, read_process_output):
5160 Likewise.
5161
b93aacde
PE
5162 * process.c: Rename or move locals to avoid shadowing.
5163 (list_processes_1, Fmake_network_process):
5164 (read_process_output_error_handler, exec_sentinel_error_handler):
5165 Rename or move locals.
4dc343ee 5166 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5167 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5168 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5169 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5170 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5171
af8a867c 5172 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5173 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5174 Include tparam.h instead, since it declares them.
af8a867c
PE
5175 * cm.h (PC): Remove extern decl; tparam.h now does this.
5176 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5177 * terminfo.c: Include tparam.h, to check interfaces.
5178 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5179 (tparam): Adjust signature to match interface in tparam.h;
5180 this removes some undefined behavior. Check that outstring and len
5181 are zero, which they always are with Emacs.
5182 * tparam.h (PC, BC, UP): New extern decls.
5183
0248044d 5184 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5185 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5186
8ff096c1 5187 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5188 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5189 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5190 (ftfont_list): Remove unused local.
49eaafba
PE
5191 (get_adstyle_property, ftfont_pattern_entity):
5192 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5193 Rename locals to avoid shadowing.
8ff096c1 5194
e2be39f6
PE
5195 * xfont.c (xfont_list_family): Mark var as initialized.
5196
c9735e30
PE
5197 * xml.c (make_dom): Now static.
5198
8f5201ae
PE
5199 * composite.c (composition_compute_stop_pos): Rename local to
5200 avoid shadowing.
b246f932
PE
5201 (composition_reseat_it): Remove unused locals.
5202 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5203 (composition_update_it): Mark var as initialized.
11b61122
PE
5204 (find_automatic_composition): Mark vars as initialized,
5205 with a FIXME (Bug#8290).
8f5201ae 5206
760fbc2c
PE
5207 character.h: Rename locals to avoid shadowing.
5208 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5209 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5210 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5211 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5212 to avoid shadowing.
5213
ff08eb85
PE
5214 * textprop.c (property_change_between_p): Remove; unused.
5215
fc7bf025
PE
5216 * intervals.c (interval_start_pos): Now static.
5217
235d7abc
PE
5218 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5219
44f230aa
SM
5220 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5221 Rename locals to avoid shadowing.
3e7d6594 5222
50060332
PE
5223 * sound.c (wav_play, au_play, Fplay_sound_internal):
5224 Fix pointer signedness.
d01f234b 5225 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5226 (wav_play): Initialize a variable to 0, to prevent undefined
5227 behavior (Bug#8278).
50060332 5228
c4fc4e30
PE
5229 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5230
918436ed
PE
5231 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5232
c939f91b
PE
5233 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5234 clobbering (Bug#8298).
b9c7f648
PE
5235 * sysdep.c (sys_subshell): Likewise.
5236 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5237
6bd8c144
PE
5238 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5239 This should get cleaned up, so that child_setup has the
5240 same signature on all platforms.
5241
7710357c 5242 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5243 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5244
c59da222
CY
52452011-03-22 Chong Yidong <cyd@stupidchicken.com>
5246
5247 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5248 not to be necessary, and produces flickering.
5249
66b87493
GM
52502011-03-20 Glenn Morris <rgm@gnu.org>
5251
5252 * config.in: Remove file.
5253
45b6f6d5
JB
52542011-03-20 Juanma Barranquero <lekktu@gmail.com>
5255
5256 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5257 are now in src/globals.h.
5258 (syms_of_minibuf): Remove spurious & from previous change.
5259
3ec03f7e
LL
52602011-03-20 Leo <sdl.web@gmail.com>
5261
5262 * minibuf.c (completing-read-function): New variable.
5263 (completing-read-default): Rename from completing-read.
5264 (completing-read): Call completing-read-function.
5265
b14e3e21
CY
52662011-03-19 Juanma Barranquero <lekktu@gmail.com>
5267
5268 * xfaces.c (Fx_load_color_file):
5269 Read color file from absolute filename (bug#8250).
5270
f2b726e6
JB
52712011-03-19 Juanma Barranquero <lekktu@gmail.com>
5272
5273 * makefile.w32-in: Update dependencies.
5274
09f6ff02
EZ
52752011-03-17 Eli Zaretskii <eliz@gnu.org>
5276
5277 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5278
29a6015a
PE
52792011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5280
a3a6c54e
PE
5281 Fix more problems found by GCC 4.5.2's static checks.
5282
b766f867
PE
5283 * process.c (make_serial_process_unwind, send_process_trap):
5284 (sigchld_handler): Now static.
5285
be02381c
PE
5286 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5287 That way, the code declares only the vars that it needs.
5288 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5289 * s/cygwin.h (PTY_ITERATION): Likewise.
5290 * s/darwin.h (PTY_ITERATION): Likewise.
5291 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5292
57048744
PE
5293 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5294 * process.c (allocate_pty): Don't declare stb unless it's needed.
5295
7914961c 5296 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5297 (CONSTANTLIM): Remove; unused.
5298 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5299 Define only if needed.
7914961c 5300
b3967b18
PE
5301 * unexelf.c (unexec): Name an expression,
5302 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5303 Use a different way to cause a compilation error if anyone uses
5304 n rather than nn, a way that does not involve shadowing.
73366a00 5305 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5306
29a6015a
PE
5307 * deps.mk (unexalpha.o): Remove; unused.
5308
43cfc33e 5309 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5310 * unexec.h: New file.
ce701a33
PE
5311 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5312 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5313 Depend on unexec.h.
5314 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5315 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5316 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5317 Change as necessary to match prototype in unexec.h.
ce701a33 5318
01f44d5a
PE
5319 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5320 shadowing.
4f63c6bb 5321 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5322
a6670b0b
PE
5323 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5324 Rename locals to avoid shadowing.
5325
cef2010d 5326 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5327 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5328
d4d7173a
PE
5329 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5330
f08b802a
PE
5331 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5332 warning when compiling print.c.
5333
3ddb0639
PE
5334 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5335 instead of using an uninitialized var.
5ad03b97 5336 (font_sort_entities): Mark var as initialized.
3ddb0639 5337
170a2692
PE
5338 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5339
e663c700
PE
5340 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5341 pointers to constants.
89bc529a 5342 (font_parse_fcname): Remove unused vars.
7b81e2d0 5343 (font_delete_unmatched): Now static.
ea838e10 5344 (font_get_spec): Remove; unused.
13a547c6
PE
5345 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5346 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5347 Rename or move locals to avoid shadowing.
e663c700 5348
2a80c887 5349 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5350 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5351
1384fa33 5352 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5353 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5354
8b2c52e9
PE
5355 * alloc.c (mark_backtrace): Move decl from here ...
5356 * lisp.h: ... to here, so that it can be checked.
5357
475545b5 5358 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5359 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5360 (lisp_indirect_variable): Name an expression,
5361 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5362 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5363
b1349114 5364 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5365 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5366 Use const pointer when appropriate.
b1349114 5367
a2928364
PE
5368 * lisp.h (get_system_name, get_operating_system_release):
5369 Move decls here, to check interfaces.
5370 * process.c (get_operating_system_release): Move decl to lisp.h.
5371 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5372 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5373 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5374 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5375 (Fformat_time_string, Fencode_time, Finsert_char):
5376 (Ftranslate_region_internal, Fformat):
5377 Rename or remove local vars to avoid shadowing.
9710023e 5378 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5379
a415e694
PE
5380 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5381 avoid shadowing.
5382
8ef4622d
PE
5383 * lisp.h (eassert): Check that the argument compiles, even if
5384 ENABLE_CHECKING is not defined.
5385
946f9a5b
PE
5386 * data.c (Findirect_variable): Name an expression, to avoid
5387 gcc -Wbad-function-cast warning.
112396d6 5388 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5389 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5390 (Fmake_variable_buffer_local, Fmake_local_variable):
5391 Mark variables as initialized.
52746918 5392 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5393
e5aab7e7 5394 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5395 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5396 Rename locals to avoid shadowing.
dff45157
PE
5397 (mark_stack): Move local variables into the #ifdef region where
5398 they're used.
7bc26fdb
PE
5399 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5400 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5401 needed otherwise.
5402 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5403 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5404 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5405
e5aab7e7
PE
5406 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5407 avoids undefined behavior in theory.
5408
4da60324
PE
5409 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5410
88043301
PE
5411 Use functions, not macros, for up- and down-casing (Bug#8254).
5412 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5413 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5414 to use the following functions instead of these macros.
5415 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5416 EMACS_INT, since callers assume the returned value fits in int.
5417 (upcase1): Likewise, for UPCASE_TABLE.
5418 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5419 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5420 the race-condition problem in the old DOWNCASE.
88043301 5421
19ed5445
PE
5422 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5423 Rename locals to avoid shadowing.
5424 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5425 (regex_compile, re_search_2, re_match_2_internal):
5426 Remove unused local vars.
952db0d7
PE
5427 (FREE_VAR): Rewrite so as not to use empty "else",
5428 which gcc can warn about.
da053e48 5429 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5430 (RETALLOC_IF): Define only if needed.
5431 (WORDCHAR_P): Likewise. This one is never needed, but is used
5432 only in a comment talking about a compiler bug, so put inside
5433 the #if 0 of that comment.
5434 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5435 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5436 Remove; unused.
19ed5445 5437
1f3561e4 5438 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5439 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5440 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5441
ded6f8f7
PE
5442 * search.c (simple_search): Remove unused var.
5443
dbd37a95
PE
5444 * dired.c (compile_pattern): Move decl from here ...
5445 * lisp.h: ... to here, so that it can be checked.
5446 (struct re_registers): New forward decl.
5447
7e47afad
PE
5448 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5449
85f24f61
PE
5450 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5451 All uses changed.
5452 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5453 Rename locals to avoid shadowing.
5671df8f 5454 (Fvertical_motion): Mark locals as initialized.
85f24f61 5455
181aa2be 5456 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5457 (casify_region): Mark local as initialized.
181aa2be 5458
930d429c
PE
5459 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5460
7082eac6
PE
5461 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5462 New macros, so that the caller can use some names other than
5463 gcpro1, gcpro2, etc.
5464 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5465 of the new macros.
5466 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5467 argument, for consistency with GCPRO2_VAR, etc: it is now the
5468 prefix of the variable, not the variable itself. All uses
5469 changed.
38b2c076
PE
5470 * dired.c (directory_files_internal, file_name_completion):
5471 Rename locals to avoid shadowing.
5472
15206ed9
PE
5473 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5474 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5475 dired.c's scmp function, had undefined behavior.
5476 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5477 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5478 * buffer.h: ... to here, because these macros use current_buffer,
5479 and the new implementation with inline functions needs to have
5480 current_buffer in scope now, rather than later when the macros
5481 are used.
5482 (downcase, upcase1): New static inline functions.
5483 (DOWNCASE, UPCASE1): Reimplement using these functions.
5484 This avoids undefined behavior in expressions like
5485 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5486 from race conditions in accessing the global variables
5487 case_temp1 and case_temp2.
5488 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5489 * lisp.h (case_temp1, case_temp2): Remove their decls.
5490 * character.h (ASCII_CHAR_P): Move from here ...
5491 * lisp.h: ... to here, so that the inline functions mentioned
5492 above can use them.
5493
4a6bea26
PE
5494 * dired.c (directory_files_internal_unwind): Now static.
5495
f14b7e14
PE
5496 * fileio.c (file_name_as_directory, directory_file_name):
5497 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5498 Now static.
2893f146
PE
5499 (file_name_as_directory): Use const pointers when appropriate.
5500 (Fexpand_file_name): Likewise. In particular, newdir might
5501 point at constant storage, so make it a const pointer.
fd4ead52 5502 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5503 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5504 signedness issues.
f839df0c
PE
5505 (Fset_file_times, Finsert_file_contents, auto_save_error):
5506 Rename locals to avoid shadowing.
f14b7e14 5507
5716756e 5508 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5509 (Ftry_completion, Fall_completions): Rename or remove locals
5510 to avoid shadowing.
5716756e 5511
b4c3046a
PE
5512 * marker.c (bytepos_to_charpos): Remove; unused.
5513
b45db522
PE
5514 * lisp.h (verify_bytepos, count_markers): New decls,
5515 so that gcc does not warn that these functions aren't declared.
5516
85876d07
PE
5517 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5518 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5519 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5520 (copy_text): Remove unused local var.
85876d07 5521
03d78a21 5522 * filelock.c (within_one_second): Now static.
b3dd38ab 5523 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5524
5df8f01b
PE
5525 * buffer.c (fix_overlays_before): Mark locals as initialized.
5526 (fix_start_end_in_overlays): Likewise. This function should be
5527 simplified by using pointers-to-pointers, but that's a different
5528 matter.
b1d876f1 5529 (switch_to_buffer_1): Now static.
8f54f30a
PE
5530 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5531 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5532
a70072c9 5533 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5534 Fix pointer signedness issue.
edced198
PE
5535 (sys_subshell): Mark local as volatile if checking for lint,
5536 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5537 (MAXPATHLEN): Define only if needed.
a70072c9 5538
a0977c44
PE
5539 * process.c (serial_open, serial_configure): Move decls from here ...
5540 * systty.h: ... to here, so that they can be checked.
5541
a884fdcc
PE
5542 * fns.c (get_random, seed_random): Move extern decls from here ...
5543 * lisp.h: ... to here, so that they can be checked.
5544
604efe86 5545 * sysdep.c (reset_io): Now static.
b8950c94 5546 (wait_for_termination_signal): Remove; unused.
604efe86 5547
38fc62d9
PE
5548 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5549 (copy_keymap_item, append_key, push_text_char_description):
5550 Now static.
1004a21a 5551 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5552 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5553 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5554 (describe_map_tree):
5555 Rename locals to avoid shadowing.
38fc62d9 5556
2f2650da
PE
5557 * keyboard.c: Declare functions static if they are not used elsewhere.
5558 (echo_char, echo_dash, cmd_error, top_level_2):
5559 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5560 (read_char, kbd_buffer_get_event, make_lispy_position):
5561 (make_lispy_event, make_lispy_movement, apply_modifiers):
5562 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5563 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5564 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5565 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5566 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5567
a053e86c 5568 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5569 (mark_kboards): Move decl here ...
5570 * alloc.c (mark_kboards): ... from here.
a053e86c 5571
4752793e
PE
5572 * lisp.h (force_auto_save_soon): New decl.
5573
74f10ca7 5574 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5575 (DEFINE_DUMMY_FUNCTION): New macro.
5576 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5577 Use it.
c03cd23f
PE
5578 (main): Add casts to avoid warnings
5579 if GCC considers string literals to be constants.
74f10ca7 5580
022e70d4
PE
5581 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5582
59d6fe83
PE
5583 * dbusbind.c: Pointer signedness fixes.
5584 (xd_signature, xd_append_arg, xd_initialize):
5585 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5586 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5587 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5588 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5589
78320123
PE
5590 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5591 if GCC considers string literals to be constants.
49cebcca 5592 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5593
35ac2a97
SM
55942011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5595
fb103ca9
SM
5596 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5597 (print_preprocess, print_object): New macro to fix last change.
5598
35ac2a97
SM
5599 * print.c (print_preprocess): Don't forget font objects.
5600
62973b41
JB
56012011-03-16 Juanma Barranquero <lekktu@gmail.com>
5602
5603 * emacs.c (USAGE3): Doc fixes.
5604
0e48bb22
AS
56052011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5606
5607 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5608 structure.
5609
7684e57b
JB
56102011-03-14 Juanma Barranquero <lekktu@gmail.com>
5611
5612 * lisp.h (VWindow_system, Qfile_name_history):
5613 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5614 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5615 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5616
5617 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5618 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5619
5620 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5621 * w32console.c (detect_input_pending, read_input_pending)
5622 (encode_terminal_code):
5623 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5624 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5625 (w32_system_caret_y, Qfile_name_history):
5626 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5627 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5628 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5629 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5630 * w32proc.c (Qlocal, report_file_error):
5631 * w32term.c (Vwindow_system, updating_frame):
5632 * w32uniscribe.c (initialized, uniscribe_font_driver):
5633 Remove unneeded extern declarations.
5634
2aa46d6c
CY
56352011-03-14 Chong Yidong <cyd@stupidchicken.com>
5636
c96bbc66 5637 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5638
cffc6f3b
CY
56392011-03-13 Chong Yidong <cyd@stupidchicken.com>
5640
5641 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5642 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5643 These macros can no longer be used for assignment.
5644
44f230aa
SM
5645 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5646 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5647 (record_buffer_markers, fetch_buffer_markers): New functions for
5648 recording and fetching special buffer markers.
5649 (set_buffer_internal_1, set_buffer_temp): Use them.
5650
5651 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5652
5653 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5654
5655 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5656 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5657
5658 * xdisp.c (hscroll_window_tree):
5659 (reconsider_clip_changes): Use PT instead of BUF_PT.
5660
d251f04b
EZ
56612011-03-13 Eli Zaretskii <eliz@gnu.org>
5662
5663 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5664 $(EMACS_ROOT)/lib/intprops.h.
5665
f0c77cd1
PE
56662011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5667
3eca4629
PE
5668 Fix more problems found by GCC 4.5.2's static checks.
5669
7c86ee98
PE
5670 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5671 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5672 (xg_free_frame_widgets): Make it clear that a local variable is
5673 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5674 (gdk_window_get_screen): Make it clear that this macro is needed
5675 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5676 (int_gtk_range_get_value): New function, which avoids a diagnostic
5677 from gcc -Wbad-function-cast.
5678 (xg_set_toolkit_scroll_bar_thumb): Use it.
5679 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5680 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5681 (get_utf8_string, xg_get_file_with_chooser):
5682 Rename locals to avoid shadowing.
5683 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5684
41729b81
PE
5685 * xgselect.c (xg_select): Remove unused var.
5686
f0c77cd1
PE
5687 * image.c (four_corners_best): Mark locals as initialized.
5688 (gif_load): Initialize transparent_p to zero (Bug#8238).
5689 Mark another local as initialized.
ec6cf4c6 5690 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5691
ce0ad53d 5692 * image.c (clear_image_cache): Now static.
d5d5a617 5693 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5694 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5695 (x_edge_detection): Remove unnecessary cast that
5696 gcc -Wbad-function-cast diagnoses.
2037898d 5697 (gif_load): Fix pointer signedness.
6ae141d6
PE
5698 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5699 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5700
33383987 57012011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5702
d32df629
PE
5703 Improve quality of tests for time stamp overflow.
5704 For example, without this patch (encode-time 0 0 0 1 1
5705 1152921504606846976) returns the obviously-bogus value (-948597
5706 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5707 reports time overflow. See
5708 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5709 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5710 * editfns.c: Include limits.h and intprops.h.
5711 (TIME_T_MIN, TIME_T_MAX): New macros.
5712 (time_overflow): Move earlier, to before first use.
5713 (hi_time, lo_time): New functions, for an accurate test for
5714 out-of-range times.
5715 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5716 (Fget_internal_run_time): Don't assume time_t fits in int.
5717 (make_time): Use list2 instead of Fcons twice.
5718 (Fdecode_time): More accurate test for out-of-range times.
5719 (check_tm_member): New function.
5720 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5721 (lisp_time_argument): Don't rely on undefined left-shift and
5722 right-shift behavior when checking for time stamp overflow.
8be6f318 5723
fe31d94c
PE
5724 * editfns.c (time_overflow): New function, refactoring common code.
5725 (Fformat_time_string, Fdecode_time, Fencode_time):
5726 (Fcurrent_time_string): Use it.
5727
8be6f318
PE
5728 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5729 * dired.c (make_time): Move to ...
5730 * editfns.c (make_time): ... here.
5731 * systime.h: Note the move.
5732
09d9db2c 57332011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5734
126bc0dc
YM
5735 * fringe.c (update_window_fringes): Remove unused variables.
5736
c47cbdfd
YM
5737 * unexmacosx.c (copy_data_segment): Also copy __got section.
5738 (Bug#8223)
5739
7ac80be9
EZ
57402011-03-12 Eli Zaretskii <eliz@gnu.org>
5741
c96bbc66 5742 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5743 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5744 Constify `char *' arguments and their references according to
5745 prototypes in tparam.h.
5746
ecb0f94d 5747 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5748
7ac80be9
EZ
5749 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5750 Adapt all references accordingly.
5751
5752 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5753
ef1fd07e
TT
57542011-03-11 Tom Tromey <tromey@redhat.com>
5755
5756 * buffer.c (syms_of_buffer): Remove obsolete comment.
5757
7ef4b50c
EZ
57582011-03-11 Eli Zaretskii <eliz@gnu.org>
5759
5760 * termhooks.h (encode_terminal_code): Declare prototype.
5761
5762 * msdos.c (encode_terminal_code): Don't declare prototype.
5763
5764 * term.c (encode_terminal_code): Now external again, used by
5765 w32console.c and msdos.c.
5766
44f230aa
SM
5767 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5768 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5769
4b1ec863 57702011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5771
1714f52b 5772 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5773
4b1ec863
PE
5774 * fringe.c (update_window_fringes): Mark locals as initialized
5775 (Bug#8227).
5776 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5777
524c7aa6
PE
5778 * alloc.c (mark_fringe_data): Move decl from here ...
5779 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5780 to check its interface.
5781 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5782
a5c0af81 5783 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5784 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5785 (fontset_font): Mark local as initialized.
a9a06e0b 5786 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5787
b4716021
PE
5788 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5789
811e9bac 5790 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5791 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5792 (x_own_selection, Fx_disown_selection_internal): Rename locals
5793 to avoid shadowing.
5794 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5795
7e3ab302
PE
5796 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5797 so that the caller can use some name other than gcpro1.
5798 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5799 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5800 (Fx_backspace_delete_keys_p):
5801 Use them to avoid shadowing, and rename vars to avoid shadowing.
5802 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5803 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5804 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5805 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5806 Remove unused locals.
7e3ab302
PE
5807 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5808 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5809 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5810 macros.
f78faa98 5811
e2b13473
PE
5812 * xterm.h (x_mouse_leave): New decl.
5813
77f23912
PE
5814 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5815 Remove unused functions.
cdf4ba58
PE
5816 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5817 (x_calc_absolute_position): Now static.
7411c686 5818 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5819 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5820 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5821 unless they are used.
38d0b34a
PE
5822 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5823 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5824 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5825 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5826 (x_error_catcher, x_connection_closed, x_error_handler):
5827 (x_error_quitter, xembed_send_message, x_iconify_frame):
5828 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5829 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5830 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5831
44f230aa
SM
5832 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5833 Rename or move locals to avoid shadowing.
6b463e58 5834 (tty_defined_color, merge_face_heights): Now static.
5967d051 5835 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5836 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5837 does not deduce is never used uninitialized.
73719eba
PE
5838 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5839 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5840
426994c3 5841 * terminal.c (store_terminal_param): Now static.
5489860b 5842
032f1620 5843 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5844 (set_frame_menubar): Remove unused local.
d4323972 5845 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5846 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5847 since they might point to immutable storage.
281585b0
PE
5848 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5849 since it's unused otherwise.
032f1620 5850
367c19e5 5851 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5852 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5853 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5854 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5855 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5856 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5857 does not deduce are never used uninitialized.
70739cbe 5858
07b48fa9
PE
5859 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5860
8868a238 5861 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5862 * window.c (window_loop, size_window):
5863 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5864
7e5cf297 5865 * window.c (display_buffer): Now static.
d6550a9f
PE
5866 (size_window): Mark variables that gcc -Wuninitialized
5867 does not deduce are never used uninitialized.
a586633d
PE
5868 * window.h (check_all_windows): New decl, to forestall
5869 gcc -Wmissing-prototypes diagnostic.
5b555da1 5870 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5871
f6095868
PE
5872 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5873 shadowing.
5874 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5875 Include <limits.h>.
5876 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5877 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5878 (load_charset_map): Mark variables that gcc -Wuninitialized
5879 does not deduce are never used uninitialized.
53df7c11 5880 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5881
f38b440c
PE
5882 * coding.c (coding_set_source, coding_set_destination):
5883 Use "else { /* comment */ }" rather than "else /* comment */;"
5884 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5885 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5886 a block, when the outer 'i' will do.
5887 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5888 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5889 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5890 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5891 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5892 Rename locals to avoid shadowing.
5893 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5894 * coding.c (emacs_mule_char, encode_invocation_designation):
5895 Now static, since they're not used elsewhere.
413bb2db 5896 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5897 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5898 (decode_coding_emacs_mule): Mark variables that gcc
5899 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5900 (detect_coding_iso_2022): Initialize a local variable that might
5901 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5902 this initialization is needed. (Bug#8211)
5f58e762
PE
5903 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5904 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5905 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5906 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5907 Remove unused macros.
f38b440c 5908
232b38b9 5909 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5910 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5911 * character.c (string_count_byte8): Likewise.
232b38b9 5912
fb90da1b
PE
5913 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5914 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5915
fb93dbc2
PE
5916 * chartab.c (copy_sub_char_table): Now static, since it's not used
5917 elsewhere.
5c156ace
PE
5918 (sub_char_table_ref_and_range, char_table_ref_and_range):
5919 Rename locals to avoid shadowing.
bbcd0949 5920 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5921
7d3b3862 5922 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5923 (BIDI_BOB): Remove unused macro.
7d3b3862 5924
6be7d3da
PE
5925 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5926 deduce are never used uninitialized.
c2ed9c8b 5927 * term.c (encode_terminal_code): Likewise.
6be7d3da 5928
75f8807f 5929 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5930
50938595
PE
5931 * tparam.h: New file.
5932 * term.c, tparam.h: Include it.
5933 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5934 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5935 Move these decls to tparam.h, and make them agree with what
5936 is actually in tparam.c. The previous trick of using incompatible
5937 decls in different modules does not conform to the C standard.
5938 All callers of tparam changed to use tparam's actual API.
5939 * tparam.c (tparam1, tparam, tgoto):
5940 Use const pointers where appropriate.
5941
fbceeba2
PE
5942 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5943 * cm.h (struct cm): Likewise.
5944 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5945 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5946 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5947 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5948 (turn_on_face, init_tty): Likewise.
5949 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5950
7f3f1250
PE
5951 * term.c (term_mouse_position): Rename local to avoid shadowing.
5952
e6ca6543
PE
5953 * alloc.c (mark_ttys): Move decl from here ...
5954 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5955
c40f8d15
AS
59562011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5957
5958 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5959
cfe0661d
JB
59602011-03-09 Juanma Barranquero <lekktu@gmail.com>
5961
5962 * search.c (compile_pattern_1): Remove argument regp, unused since
5963 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5964 (compile_pattern): Don't pass it.
5965
0afb4571
J
59662011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5967
5968 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5969 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5970 for ! HAVE_GTK3.
5971 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5972
5973 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5974
5975 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5976 gdk_window_get_screen, gdk_window_get_geometry,
5977 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5978 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5979 (xg_get_pixbuf_from_pixmap): New function.
5980 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5981 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5982 Call xg_get_pixbuf_from_pixmap instead of
5983 gdk_pixbuf_get_from_drawable.
5984 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5985 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5986 (xg_check_special_colors): Use GtkStyleContext and its functions
5987 for HAVE_GTK3.
5988 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5989 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5990 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5991 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5992 Call gtk_widget_get_preferred_size.
0afb4571
J
5993 (xg_frame_resized): gdk_window_get_geometry only takes 5
5994 parameters.
44f230aa
SM
5995 (xg_win_to_widget, xg_event_is_for_menubar):
5996 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5997 (xg_set_widget_bg): New function.
5998 (delete_cb): New function.
895009e1 5999 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6000 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6001 (xg_set_background_color): Call xg_set_widget_bg.
6002 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6003 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6004 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6005 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6006 if ! HAVE_GTK3.
6007 (update_frame_tool_bar): Call gtk_widget_hide.
6008 (xg_initialize): Use GDK_KEY_g.
6009
6010 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6011 if ! HAVE_GTK3
6012 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6013
6014 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6015 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6016 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6017
1c2cc4ef
JB
60182011-03-08 Juanma Barranquero <lekktu@gmail.com>
6019
6020 * w32xfns.c (select_palette): Check success of RealizePalette against
6021 GDI_ERROR, not zero.
6022
33383987 6023See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6024
6025;; Local Variables:
6026;; coding: utf-8
aac0c6e3
MR
6027;; End:
6028
33383987 6029 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6030
6031 This file is part of GNU Emacs.
6032
6033 GNU Emacs is free software: you can redistribute it and/or modify
6034 it under the terms of the GNU General Public License as published by
6035 the Free Software Foundation, either version 3 of the License, or
6036 (at your option) any later version.
6037
6038 GNU Emacs is distributed in the hope that it will be useful,
6039 but WITHOUT ANY WARRANTY; without even the implied warranty of
6040 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6041 GNU General Public License for more details.
6042
6043 You should have received a copy of the GNU General Public License
6044 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.