Fix replacement typo.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
f99bac93
DA
12012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Fix replacement typo.
4 * window.c (replace_window): Set root_window instead of
5 selected_window. This fixes a total window subsystem
6 malfunction reported by Bastien Guerry <bzg@gnu.org>.
7
8c2a0f2d
GM
82012-08-06 Glenn Morris <rgm@gnu.org>
9
10 * lisp.mk (lisp): Add language/persian.elc.
11
edd74c35
DA
122012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
13
14 Separate read and write access to Lisp_Object slots of struct frame.
15 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
16 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
17 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
18 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
19 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
20
8671676c
AS
212012-08-05 Andreas Schwab <schwab@linux-m68k.org>
22
23 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
24
663e2b3f
DA
252012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
26
27 Generalize common compile-time constants.
28 * lisp.h (header_size, bool_header_size, word_size): Now here.
29 (struct Lisp_Vector): Add comment.
30 (struct Lisp_Bool_Vector): Move up to define handy constants.
31 (VECSIZE, PSEUDOVECSIZE): Simplify.
32 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
33 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
34 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
35 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
36 * xfont.c, xmenu.c: Use word_size where appropriate.
37
d32e47af
LM
382012-08-05 Lawrence Mitchell <wence@gmx.li>
39
40 * search.c (Freplace_match): Treat \? in the replacement text
41 literally (Bug#8161).
42
e5d9c0d1
CY
432012-08-05 Chong Yidong <cyd@gnu.org>
44
45 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
46 * frame.c (Vdelete_frame_functions):
47 * emacs.c (Vkill_emacs_hook): Doc fix.
48
8da0576b
EZ
492012-08-04 Eli Zaretskii <eliz@gnu.org>
50
51 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
52 --with-x-toolkit=no builds.
53 Reported by Carsten Mattner <carstenmattner@gmail.com>.
54
02676e5d
CY
552012-08-04 Chong Yidong <cyd@gnu.org>
56
57 * syntax.c (Fmodify_syntax_entry): Doc fix.
58
97147da9
EZ
592012-08-04 Eli Zaretskii <eliz@gnu.org>
60
76151e2c
EZ
61 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
62 * w32.c (init_environment): Change the default values of many
63 environment variables in dflt_envvars[] to NULL, to avoid pushing
64 them into environment when they were not already defined. Remove
65 the code that deletes site-lisp subdirectories from the default
66 value of EMACSLOADPATH, as it is no longer needed.
67 (check_windows_init_file): Now external, not static. Use
68 Vload_path as is, without adding anything, as this function is now
69 called when Vload_path is already set up.
70
71 * w32.h (check_windows_init_file): Add prototype.
72
73 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
74 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
75 compatibility with Posix platforms.
76 (main): Move the call to check_windows_init_file to here from
77 w32.c.
78 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
79 any, in the DEFALT argument into the root of the Emacs build or
80 installation tree, as appropriate.
81
82 * callproc.c (init_callproc_1): Call decode_env_path instead of
83 doing its equivalent by hand.
84 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
85 the code that sets Vexec_path run on MS-Windows.
86
87 * lread.c (init_lread): Add comments to #ifdef's.
88
97147da9
EZ
89 * msdos.c (dos_set_window_size, IT_update_begin)
90 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
91 instead of direct references.
92
185ee146
PE
932012-08-04 Paul Eggert <eggert@cs.ucla.edu>
94
95 Export DEFAULT_REHASH_* to GDB.
96 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
97 Now constants, not macros.
98
8834c57a
PE
992012-08-03 Paul Eggert <eggert@cs.ucla.edu>
100
98c6f1e3
PE
101 Remove unnecessary casts involving pointers.
102 These casts are no longer needed now that we assume C89 or later,
103 since they involve casting to or from void *.
104 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
105 (make_pure_float, make_pure_vector):
106 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
107 * macros.c (Fstart_kbd_macro):
108 * menu.c (find_and_return_menu_selection):
109 * minibuf.c (read_minibuf_noninteractive):
110 * sysdep.c (closedir):
111 * xdisp.c (x_produce_glyphs):
112 * xfaces.c (compare_fonts_by_sort_order):
113 * xfns.c (x_real_positions, select_visual):
114 * xselect.c (x_stop_queuing_selection_requests)
115 (x_get_window_property, x_get_window_property_as_lisp_data):
116 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
117 Remove unnecessary pointer casts.
118 * alloc.c (record_xmalloc): New function.
119 * lisp.h (record_xmalloc): New decl.
120 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
121 more like a function. This is because the pointer cast is not
122 needed. All uses changed.
123 * print.c (print_string, print_error_message): Avoid length recalc.
124
8834c57a
PE
125 Improve fix for macroexp crash with debugging (Bug#12118).
126 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
127 ARRAY_MARK_FLAG when checking subscripts, because ASET is
128 not supposed to be invoked from the garbage collector.
129 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
130 (gc_aset): New function, which is like ASET but can be
131 used in the garbage collector.
132 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
133 (set_hash_index): Use it instead of ASET.
134
6dad7178
EZ
1352012-08-03 Eli Zaretskii <eliz@gnu.org>
136
137 Support symlinks on latest versions of MS-Windows.
138 * w32.c: Include winioctl.h and aclapi.h.
139 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
140 (revert_to_self): Forward declarations of static functions.
141 <static BOOL g_b_init_get_security_info>:
142 <g_b_init_create_symbolic_link>: New static flags.
143 (globals_of_w32): Initialize them to zero.
144 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
145 (map_w32_filename): Improve commentary. Simplify switch.
146 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
147 headers (most versions of MinGW w32api don't).
148 (get_security_info, create_symbolic_link)
149 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
150 New functions.
151 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
152 in the argument file name.
153 (sys_access): Call unc_volume_file_attributes only if
154 GetFileAttributes fails with network-related error codes.
155 (sys_rename): Diagnose renaming of a symlink when the user doesn't
156 have the required privileges.
157 (get_file_security_desc_by_name): Renamed from
158 get_file_security_desc.
159 (stat_worker): New function, with most of the guts of 'stat', and
160 with addition of handling of symlinks and support for 'lstat'. If
161 possible, get file's attributes and security information by
162 handle, not by name. Produce S_IFLNK bit for symlinks, when
163 called from 'lstat'.
164 (stat, lstat): New functions, call 'stat_worker'.
165 (symlink, readlink, careadlinkat): Rewritten to create and resolve
166 symlinks when the underlying filesystem supports them.
167
f162bcc3
PE
1682012-08-02 Paul Eggert <eggert@cs.ucla.edu>
169
79ea6c20
PE
170 Fix macroexp crash on Windows with debugging (Bug#12118).
171 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
172 checking subscripts; problem introduced with the recent
173 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
174 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
175 since it's used in non-static inline functions now.
176
c0ce93fd
PE
177 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
178 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 179
f162bcc3
PE
180 Use C99-style 'extern inline' if available.
181 * buffer.h (BUFFER_INLINE):
182 * category.h (CATEGORY_INLINE):
183 * character.h (CHARACTER_INLINE):
184 * charset.h (CHARSET_INLINE):
185 * composite.h (COMPOSITE_INLINE):
186 * dispextern.h (DISPEXTERN_INLINE):
187 * lisp.h (LISP_INLINE):
188 * systime.h (SYSTIME_INLINE):
189 New macro, replacing 'static inline' in this header.
190 * buffer.h, category.h, character.h, charset.h, composite.h:
191 * dispextern.h, lisp.h, systime.h:
192 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
193 * alloc.c (LISP_INLINE):
194 * buffer.c (BUFFER_INLINE):
195 * category.c (CATEGORY_INLINE):
196 * character.c (CHARACTER_INLINE):
197 * charset.c (CHARSET_INLINE):
198 * composite.c (COMPOSITE_INLINE):
199 * dispnew.c (DISPEXTERN_INLINE):
200 * sysdep.c (SYSTIME_INLINE):
201 Define to EXTERN_INLINE, so that the corresponding functions
202 are compiled into code.
203 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
204 (INLINE_HEADER_END): New macros.
205 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
206 since it's used in non-static inline functions now.
a8333d03 207 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 208
837b365b
GM
2092012-08-02 Glenn Morris <rgm@gnu.org>
210
d66b744d
GM
211 * s/: Remove empty directory.
212
837b365b
GM
213 * s/ms-w32.h: Move to ../nt/inc.
214 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
215 Update for new ms-w32.h location.
216
13294f95
PE
2172012-08-02 Paul Eggert <eggert@cs.ucla.edu>
218
219 Port to Solaris 8.
220 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
221
90df0db3
GM
2222012-08-02 Glenn Morris <rgm@gnu.org>
223
224 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
225 hard-coding the path separator.
226
4939150c
PE
2272012-08-01 Paul Eggert <eggert@cs.ucla.edu>
228
229 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
230 This how ASET and AREF are supposed to work, and makes
231 it easier to think about future improvements. See
232 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
233 * charset.h (set_charset_attr): New function.
234 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
235 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
236 (aref_addr): New function. All uses of &AREF(...) changed.
237 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
238 (set_hash_index): New functions. All lvalue-style uses of
239 HASH_KEY etc. changed.
240 * keyboard.c (set_prop): New function. All lvalue-style uses
241 of PROP changed.
242
947b2afd
AA
2432012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
244
245 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
246 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
247 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
248 * nsfns.m (ns_set_name_as_filename): Likewise.
249 * nsmenu.m (ns_update_menubar): Likewise.
250 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
251
4f5d0325
EZ
2522012-08-01 Eli Zaretskii <eliz@gnu.org>
253
2008beae
EZ
254 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
255 Adapt to latest changes in field names of the corresponding Lisp
288479f6 256 objects.
2008beae 257
4f5d0325
EZ
258 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
259
fe3cc771
GM
2602012-08-01 Glenn Morris <rgm@gnu.org>
261
262 * s/msdos.h: Remove file.
263 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
264 * Makefile.in (S_FILE): Remove.
265 (config_h): Remove S_FILE.
266
c90acc54
JB
2672012-08-01 Juanma Barranquero <lekktu@gmail.com>
268
269 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
270 Remove; moved to nt/config.nt.
271
d8a05828
DA
2722012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
273
274 Use INTERNAL_FIELD for conses and overlays.
275 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
276 Remove obsolete comment.
277 (MVAR): New macro.
278 (struct Lisp_Overlay): Use INTERNAL_FIELD.
279 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
280
8271d590
DA
2812012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
282
283 Use INTERNAL_FIELD for symbols.
284 * lisp.h (SVAR): New macro. Adjust users.
285 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
286 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
287
3193acd2
DA
2882012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
289
290 Use INTERNAL_FIELD for processes.
291 * process.h (PVAR): New macro. Adjust style.
292 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
293 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
294
3a45383a
DA
2952012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
296
297 Use INTERNAL_FIELD for windows.
298 * window.h (WVAR): New macro.
299 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
300 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
301 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
302 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
303 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
304 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
305
c1dbc63c
PE
3062012-08-01 Paul Eggert <eggert@cs.ucla.edu>
307
308 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
309
5c0c0e8a
GM
3102012-08-01 Glenn Morris <rgm@gnu.org>
311
312 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
313 Move to configure.ac.
314
552a99b4
JB
3152012-08-01 Juanma Barranquero <lekktu@gmail.com>
316
317 * makefile.w32-in (CONFIG_H): Update dependencies.
318 (CONF_POST_H): New macro.
319
320 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
321
8d8e2dfe
GM
3222012-07-31 Glenn Morris <rgm@gnu.org>
323
bc96620a
GM
324 * Makefile.in (S_FILE): No longer set by configure.
325
476b1b2d
GM
326 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
327 is available.
328 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
329
b2c7a106
GM
330 * process.h (NULL_DEVICE):
331 * emacs.c (SEPCHAR):
332 * editfns.c (USER_FULL_NAME): Let configure set them.
333
d53d062a
GM
334 * s/README, s/template.h: Remove files.
335
4515017f
GM
336 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
337
8d8e2dfe
GM
338 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
339 Move to configure.ac.
340
5b20b3cc
EZ
3412012-07-31 Eli Zaretskii <eliz@gnu.org>
342
1e0afd9a
EZ
343 * .gdbinit (xframe): Adapt to introduction of FVAR and the
344 resulting renaming of 'struct frame' members.
345
5b20b3cc
EZ
346 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
347
348 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
349 after introduction of FVAR.
350
f1310128
JD
3512012-07-31 Jan Djärv <jan.h.d@swipnet.se>
352
79e721e0
JD
353 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
354
355 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
356 instead of compositeToPoint.
357 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
358
8d7c7eed 359 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 360
e34f7f79
DA
3612012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
362
363 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
364 * lisp.h (INTERNAL_FIELD): New macro.
365 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
366 (BVAR): Change to use INTERNAL_FIELD.
367 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
368 (KVAR): Change to use INTERNAL_FIELD.
369 * frame.h (FVAR): New macro.
370 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
371 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
372 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
373 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
374 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
375
c09bfb2f
DA
3762012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
377
378 Miscellaneous fixes for non-default X toolkits.
379 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
380 * xterm.c (x_frame_of_widget): Remove redundant prototype.
381 Move under #ifdef USE_LUCID.
382 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
383 definition and usage to avoid warnings.
384
14c114ae
JD
3852012-07-31 Jan Djärv <jan.h.d@swipnet.se>
386
387 * nsterm.m (openFiles): Fix previous checkin.
388
3bd21e82
PE
3892012-07-31 Paul Eggert <eggert@cs.ucla.edu>
390
391 * indent.c (compute_motion): Remove unused local.
392
c1529ded
GM
3932012-07-31 Glenn Morris <rgm@gnu.org>
394
400d5621
GM
395 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
396
268e2432
GM
397 * conf_post.h [USG5_4]:
398 Move remaining contents of s/usg5-4-common.h here.
399 * s/usg5-4-common.h: Remove file.
400
7552f3ee
GM
401 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
402 * s/irix6-5.h: Remove file.
403
6a381852
GM
404 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
405 * s/darwin.h: Remove file.
406
c1529ded
GM
407 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
408 * s/hpux10-20.h: Remove file, which is now empty.
409
b429a4ee
GM
4102012-07-30 Glenn Morris <rgm@gnu.org>
411
412 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
413 * Makefile.in (config_h): Add conf_post.h.
414 * makefile.w32-in (CONFIG_H): Add conf_post.h.
415
adff3182
JD
4162012-07-30 Jan Djärv <jan.h.d@swipnet.se>
417
418 * nsterm.m (ns_do_open_file): New variable.
b9031d69 419 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
420 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
421 files only if ns_do_open_file.
422
c32af1e4
PE
4232012-07-30 Paul Eggert <eggert@cs.ucla.edu>
424
7393bcbb
PE
425 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
426 This no-op macro hasn't been needed for many years.
427 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
428
c32af1e4
PE
429 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
430 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
431 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
432 gdb_make_enums_visible.
433 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
434 (DIRECTORY_SEP): Now a constant, not a macro.
435
302fc036
EZ
4362012-07-30 Eli Zaretskii <eliz@gnu.org>
437
438 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
439 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
440
441 * w32term.c <w32_keyboard_codepage>: Renamed from
442 keyboard_codepage and now external. All users changed.
443
444 * w32term.h: Add declaration of w32_keyboard_codepage.
445
446 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
447 the codepage to translate keys to Unicode. If this argument is
448 -1, use the value returned by GetConsoleCP. All callers changed.
449
88fb40b4
PE
4502012-07-30 Paul Eggert <eggert@cs.ucla.edu>
451
0aee6912
PE
452 Update .PHONY listings in makefiles.
453 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
454 bootstrap-clean, distclean, maintainer-clean, versioclean,
455 extraclean, frc.
456
88fb40b4
PE
457 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
458 This is a bit clearer. Fix some commentary typos.
459
0a763bd1
GM
4602012-07-30 Glenn Morris <rgm@gnu.org>
461
32bac6d6
GM
462 * s/netbsd.h: Let configure include signal.h if needed.
463 Remove file, which is now empty.
464
b65e7c46
GM
465 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
466 Let configure set them.
467 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
468 No more need to undefine.
0a763bd1 469
169304bd
AS
4702012-07-30 Andreas Schwab <schwab@linux-m68k.org>
471
472 * keymap.c (Fkey_description): Don't remove 0x80 bit from
473 non-single-byte char when adding meta modifier. (Bug#12090)
474
6cd7a139
DA
4752012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
476
477 Convert safe_call to use variable number of arguments.
478 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
479 (safe_call2): Fix comment.
480 * lisp.h (safe_call): Adjust prototype.
481 * coding.c (encode_coding_object): Change to use safe_call2.
482 * xfaces.c (merge_face_heights): Change to use safe_call1.
483
d34d6ffc
GM
4842012-07-30 Glenn Morris <rgm@gnu.org>
485
7b8a48e4 486 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 487 does that unconditionally. Remove file, which is now empty.
7b8a48e4 488
d34d6ffc
GM
489 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
490 Remove empty files.
491
03a660a6
PE
4922012-07-30 Paul Eggert <eggert@cs.ucla.edu>
493
494 Export to GDB most of lisp.h's remaining object-like macros.
495 * lisp.h (min, max): Move earlier, because they're used earlier now.
496 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
497 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
498 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
499 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
500 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
501 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
502 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
503 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
504 Now constants, for GDB. They need not be macros.
505 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
506 Now constants, for GDB, as well as macros, for static initializers.
507 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
508 Move to after the definition of struct Lisp_Char_Table,
509 since the former now needs that type defined.
510 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
511 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
512 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
513 New enums, for gdb_make_enums_visible.
514 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 515 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
516 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
517 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
518 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
519 enum maxargs, enum MAX_ALLOCA.
520 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
521 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
522 no longer needed, now that they are done in lisp.h.
523
e499d0ee
DA
5242012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
525
526 Cleanup string bytes checking.
527 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
528 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
529 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
530 (check_sblock, compact_small_strings): Simplify.
531
d5040d2d
PE
5322012-07-29 Paul Eggert <eggert@cs.ucla.edu>
533
534 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
535 These macros are confusing and no longer need to be defined, as
536 the enum values now suffice. All uses replaced with definiens.
537 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
538
7f259ae6
JB
5392012-07-29 Juanma Barranquero <lekktu@gmail.com>
540
541 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
542 ($(BLD)/w32console.$(O)): Update dependencies.
543
7e63e0c3
DA
5442012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
545
546 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
547 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
548 time. Adjust users.
549 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
550
ffd817eb
JD
5512012-07-29 Jan Djärv <jan.h.d@swipnet.se>
552
553 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
554 setting sitelisp (Bug#12010).
555
417a7a0e
EZ
5562012-07-29 Eli Zaretskii <eliz@gnu.org>
557
558 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
559
560 * w32heap.c (cache_system_info):
561 * w32.c (sys_rename):
562 * w32proc.c (find_child_console, sys_kill): All users changed.
563
387d4d92
PE
5642012-07-29 Paul Eggert <eggert@cs.ucla.edu>
565
566 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
567
55a6cca6
EZ
5682012-07-29 Eli Zaretskii <eliz@gnu.org>
569
570 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
571
dbcf001c
DA
5722012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
573
574 Cleanup statistics calculation in Fgarbage_collect.
575 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
576 zombies percentage calculation. Simplify elapsed time calculation.
577
e2688e4a
DA
5782012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
579
580 Generalize marker debugging code under MARKER_DEBUG and use eassert.
581 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
582 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
583 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
584 (replace_range, replace_range_2, del_range_2): Change to eassert.
585 * marker.c (byte_char_debug_check): Adjust style.
586
b46a6a83
PE
5872012-07-29 Paul Eggert <eggert@cs.ucla.edu>
588
589 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
590 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
591 long-ago-commented-out code that talks about "WIN32".
592 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
593 All uses changed.
594
e32a5799
PE
5952012-07-28 Paul Eggert <eggert@cs.ucla.edu>
596
597 Use Gnulib stdalign module (Bug#9772, Bug#9960).
598 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
599 Simplify by using alignof.
600 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
601 * lisp.h: Include <stdalign.h>.
602 (GCALIGNMENT): New macro and constant.
603 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
604 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
605 (stdalign): New macro, if not already defined.
606
df81cd29
EZ
6072012-07-28 Eli Zaretskii <eliz@gnu.org>
608
01bd1b0d
EZ
609 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
610 * w32inevt.c: Include w32inevt.h.
611 (w32_read_console_input): New inline function, calls either
612 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
613 w32_console_unicode_input.
614 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
615 (w32_kbd_patch_key, key_event): Use the codepage returned by
616 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
617 (key_event): use uChar.UnicodeChar only if
618 w32_console_unicode_input is non-zero.
619
620 * w32console.c: Include w32heap.h.
621 <w32_console_unicode_input>: New global variable.
622 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
623 family of Windows, zero otherwise.
624
625 * w32inevt.h: Declare w32_console_unicode_input.
626
df81cd29
EZ
627 * xdisp.c (init_iterator): Don't reference tip_frame in a build
628 --without-x. (Bug#11742)
629
c20fdd9e
PE
6302012-07-27 Paul Eggert <eggert@cs.ucla.edu>
631
632 Adjust GDB to reflect pvec_type changes (Bug#12036).
633 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
634 2012-07-04 changes to pseudovector representation. Problem
635 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
636
32770973 6372012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
638
639 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
640 bus address.
641 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
642
3438fe21
EZ
6432012-07-27 Eli Zaretskii <eliz@gnu.org>
644
bcfbc9de
EZ
645 * alloc.c (listn): Fix the order the arguments are consed onto the
646 list.
647
3438fe21
EZ
648 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
649 enumeration constants, as PURE and HEAP are too general, and clash
650 with other headers and sources, such as gmalloc.c and the
651 MS-Windows system headers. All users changed.
652
eeaea515
DA
6532012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
654
655 Revert last save_excursion_save and save_excursion_restore changes.
656 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
657 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
658
073c88c2
DA
6592012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
660
661 Fix recently-introduced typos in Windows port.
662 Reported by Martin Rudalics <rudalics@gmx.at>.
663 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 664 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 665
4706125e
PE
6662012-07-27 Paul Eggert <eggert@cs.ucla.edu>
667
668 Improve GDB symbol export (Bug#12036).
669 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
670 arms of an 'if', not using conditional expressions; otherwise GDB
671 complains about the types in the unevaluated arm when the argument
672 is an integer literal.
673 (xgetint): Simplify expression.
674 * alloc.c (gdb_make_enums_visible): New constant. This ports to
675 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
676 Zaretskii in <http://bugs.gnu.org/12036#13>.
677 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
678 needed now that we have gdb_make_enums_visible.
679 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
680 (enum enum_USE_LSB_TAG):
681 New enum types, packaging up enums that need to be exported to GDB.
682
694b6c97
DA
6832012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
684
685 Utility function to make a list from specified amount of objects.
686 * lisp.h (enum constype): New datatype.
687 (listn): New prototype.
688 * alloc.c (listn): New function.
689 (Fmemory_use_count, syms_of_alloc): Use it.
690 * buffer.c (syms_of_buffer): Likewise.
691 * callint.c (syms_of_callint): Likewise.
692 * charset.c (define_charset_internal): Likewise.
693 * coding.c (syms_of_coding): Likewise.
694 * keymap.c (syms_of_keymap): Likewise.
695 * search.c (syms_of_search): Likewise.
696 * syntax.c (syms_of_syntax): Likewise.
697 * w32.c (init_environment): Likewise.
698 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
699 * xdisp.c (syms_of_xdisp): Likewise.
700 * xfns.c (syms_of_xfns): Likewise.
701
6195f384
DA
7022012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
703
704 Fast save_excursion_save and save_excursion_restore.
705 * lisp.h (struct Lisp_Excursion): New data type.
706 (PVEC_EXCURSION): New pseudovector type.
707 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
708 to deal with it. Adjust comments.
709 (init_marker, attach_marker): New prototype.
710 (unchain_marker): Adjust prototype.
711 * marker.c (attach_marker): Change to global.
712 (init_marker): New function.
713 * alloc.c (Fmake_marker, build_marker): Use it.
714 (build_marker): More easserts.
715 (mark_object): Handle struct Lisp_Excursion.
716 * editfns.c (save_excursion_save, save_excursion_restore):
717 Reimplement to use struct Lisp_Excursion. Add comments.
718
5eceb8fb
PE
7192012-07-26 Paul Eggert <eggert@cs.ucla.edu>
720
721 Fix export of symbols to GDB (Bug#12036).
722 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
723 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
724 emacs.c, as this is a more-suitable home. Had this been done earlier
725 the fix for 12036 would have avoided some of the problems noted in
726 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
727 would have been more obvious.
562157c8
PE
728 * emacs.c: Do not include <verify.h>; no longer needed.
729 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
730 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
731 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
732 Remove; now done in lisp.h.
733 * lisp.h (PUBLISH_TO_GDB): New macro.
734 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
735 (DATA_SEG_BITS): Use it.
736 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
737 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
738 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
739 not be usable in #if. This simplifies things.
740
d6749401
JB
7412012-07-26 Juanma Barranquero <lekktu@gmail.com>
742
743 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
744
1781b9e9
PE
7452012-07-26 Paul Eggert <eggert@cs.ucla.edu>
746
d89518db 747 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
748 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
749 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
750 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
751 Adjust to changes in lisp.h and emacs.c, by using
752 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
753 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
754 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
755 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
756 instead of gdb_valbits.
757 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
758 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
759 instead of gdb_array_mark_flag.
760 (xboolvector): Get size from $->size, not $->header.size.
761 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
762 (xreload, hook-run, hookpost-run): Remove.
763 * emacs.c: Include <verify.h>.
764 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
765 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
766 Remove.
767 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
768 (gdb_USE_LSB_TAG): New enum constants.
769 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
770 Also define these as enum constants, so they're visible to GDB.
771 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
772 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
773 as constants, so they're visible to GDB.
774 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
775 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
776 Now enum constants, not macros, so they're visible to GDB.
777 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
778 more convenient now. All uses changed.
779 (VALMASK) [USE_LSB_TAG]: Also define in this case.
780 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
781
3628596a
DA
7822012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
783
784 Explicitly free restriction data that are not needed anymore.
785 * editfns.c (save_restriction_restore): Free restriction data.
786
7abaf5cc
SM
7872012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
788
789 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
790 add argument, tune behavior, and adjust all callers.
791
71f88e00
PE
7922012-07-25 Paul Eggert <eggert@cs.ucla.edu>
793
794 Use typedef for EMACS_INT, EMACS_UINT.
795 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
796 than macros. This simplifies debugging in the usual case, since
797 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
798 and it allows expressions involving EMACS_INT casts.
799 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
800
57ec3034
JD
8012012-07-25 Jan Djärv <jan.h.d@swipnet.se>
802
803 * nsterm.m (ns_read_socket): Return early if there is a modal
804 window (Bug#12043).
805
8137e7b3
MR
8062012-07-25 Martin Rudalics <rudalics@gmx.at>
807
808 * frame.c (Fredirect_frame_focus): In doc-string don't mention
809 that FOCUS-FRAME can be omitted.
810
04e9897c
DA
8112012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
812
813 Adjust buffer text indirection counters at the end of Fkill_buffer.
814 * buffer.c (Fkill_buffer): Adjust indirection counters when the
815 buffer is definitely dead. This should really fix an issue reported
816 by Christoph Scholtes again. (Bug#12007).
817 (init_buffer_once): Initialize indirection counters of
818 buffer_defaults and buffer_local_symbols (for sanity and safety).
819
8a0484e1
EZ
8202012-07-24 Eli Zaretskii <eliz@gnu.org>
821
822 * xdisp.c (init_iterator): Don't compute dimensions of truncation
823 and continuation glyphs on tooltip frames, leave them at zero.
824 Avoids continued lines in tooltips. (Bug#11832)
825
fa691a83
DA
8262012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
827
828 Simplify copy_overlay.
04e9897c 829 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
830 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
831
436bc8e0
EZ
8322012-07-23 Eli Zaretskii <eliz@gnu.org>
833
834 * print.c (print_object): Don't crash when a frame's name is nil
835 or invalid. (Bug#12025)
836
837 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
838 it signals an error when a tooltip frame is being created.
839
d7a7fda3
DA
8402012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
841
842 Cleanup miscellaneous objects allocation and initialization.
843 * alloc.c (allocate_misc): Change to static. Add argument to
844 specify the subtype. Adjust comment and users.
845 (build_overlay): New function.
846 * buffer.c (copy_overlays, Fmake_overlay): Use it.
847 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
848 (allocate_misc): Remove prototype.
849 (build_overlay): Add prototype.
850
8512012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
852
853 Swap buffer text indirection counters in Fbuffer_swap_text.
854 * buffer.c (Fbuffer_swap_text): Swap indirections too.
855 This avoids crash reported by Christoph Scholtes at
856 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
857
9d7fa573
JD
8582012-07-22 Jan Djärv <jan.h.d@swipnet.se>
859
860 * nsmenu.m (Popdown_data): New struct.
861 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
862 free Popdown_data.
863 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
864 (initWithContentRect): Make imgView and contentView non-static
865 and autorelease them. Also autorelease img and matrix (Bug#12005).
866 (dealloc): Remove (Bug#12005).
867
0dd6d66d
DA
8682012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
869
870 Adjust consing_since_gc when objects are explicitly freed.
871 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
872 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
873 (free_cons, free_misc): Subtract object size from consing_since_gc.
874
d36d71df
DA
8752012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
876
877 Simplify and cleanup markers positioning code.
878 * marker.c (attach_marker): More useful eassert.
879 (live_buffer, set_marker_internal): New function.
880 (Fset_marker, set_marker_restricted): Use set_marker_internal.
881 (set_marker_both, set_marker_restricted_both): Use live_buffer.
882
fb9ea40f
PE
8832012-07-22 Paul Eggert <eggert@cs.ucla.edu>
884
885 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
886 as it's limited by the amount of memory, not by INT_MAX.
887
2d5c5f7d
EZ
8882012-07-21 Eli Zaretskii <eliz@gnu.org>
889
07fb592e
EZ
890 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
891 in special-event-map. See the discussion at
892 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
893 for the reasons.
894
37a9eac8 895 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
896 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
897 Fabrice Popineau <fabrice.popineau@supelec.fr>.
898
c4328746
JD
8992012-07-21 Jan Djärv <jan.h.d@swipnet.se>
900
901 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 902 (conversationIdentifier): Return value is NSInteger.
784051c4 903 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 904
6e5d1c12
CY
9052012-07-21 Chong Yidong <cyd@gnu.org>
906
907 * window.c (decode_any_window): Signal an error if the window is
908 on a dead frame (Bug#11984).
909
9928463d
DA
9102012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
911
912 Add indirection counting to speed up Fkill_buffer.
913 * buffer.h (struct buffer): New member.
914 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
915 (Fmake_indirect_buffer): Set indirection counter to -1, increment
916 base buffer indirection counter.
917 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
918 (Fkill_buffer): Adjust indirection counters as needed, don't walk
919 through buffer list if indirection counter is 0.
920
f8643a6b
DA
9212012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
922
923 Extend the value returned by Fgarbage_collect with heap statistics.
924 * alloc.c (Qheap): New symbol.
925 (syms_of_alloc): DEFSYM it.
926 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
927 (Fmemory_free): Remove.
928 (syms_of_alloc): Don't defsubr it.
929 * buffer.c (Fcompact_buffer): Remove.
930 (syms_of_buffer): Don't defsubr it.
931
dac616ff
DA
9322012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
933
934 Make maybe_gc inline.
935 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
936 * lisp.h (consing_since_gc, gc_relative_threshold)
937 (memory_full_cons_threshold): Revert declaration.
938 (maybe_gc): Remove prototype, define as inline.
939 * alloc.c: Remove old commented-out code.
940 (consing_since_gc, gc_relative_threshold)
941 (memory_full_cons_threshold): Revert to global.
942 (maybe_gc): Remove.
943
d7ea76b4
DA
9442012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
945
946 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
947 * lisp.h (build_unibyte_string): New function.
948 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
949 * sysdep.c, w32fns.c, xfns.c: Use it.
950 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
951 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
952 Adjust users accordingly.
953 * font.h (font_open_by_name): Adjust prototype.
954
765e61e3
DA
9552012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
956
957 Cleanup calls to Fgarbage_collect.
958 * lisp.h (maybe_gc): New prototype.
959 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
960 Remove declarations.
961 * alloc.c (maybe_gc): New function.
962 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
963 Make them static.
964 * bytecode.c (MAYBE_GC): Use maybe_gc.
965 * eval.c (eval_sub, Ffuncall): Likewise.
966 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
967 to avoid dependency from auto-save feature.
968
52b852c7
PE
9692012-07-19 Paul Eggert <eggert@cs.ucla.edu>
970
971 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
972 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
973 'for_each_per_buffer_object_at'.
974 All uses changed. It's better to use upper-case for macros that
975 cannot be implemented as functions, to give the reader a clue
976 that they're special.
977
5db81e33
SM
9782012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
979
980 * alloc.c (Fgarbage_collect): Tweak docstring.
981
5b835e1d
DA
9822012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
983
984 Tweak the value returned from Fgarbage_collect again.
985 * alloc.c (Fgarbage_collect): New return value, as confirmed in
986 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
987 Adjust documentation.
988 (total_vector_bytes): Rename to total_vector_slots, adjust
989 accounting.
990 (total_free_vector_bytes): Rename to total_free_vector_slots,
991 adjust accounting.
992 (Qstring_bytes, Qvector_slots): New symbols.
993 (syms_of_alloc): DEFSYM them.
994
9cd47b72
DA
9952012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
996
997 Buffer compaction primitive which may be used from Lisp.
998 * buffer.c (compact_buffer, Fcompact_buffer): New function.
999 (syms_of_buffer): Register Fcompact_buffer.
1000 * alloc.c (Fgarbage_collect): Use compact_buffer.
1001 * buffer.h (compact_buffer): New prototype.
1002 (struct buffer_text): New member.
1003
d17337e5
DA
10042012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1005
1006 New macro to iterate over all buffers, miscellaneous cleanups.
1007 * lisp.h (all_buffers): Remove declaration.
1008 * buffer.h (all_buffers): Add declaration, with comment.
1009 (for_each_buffer): New macro.
1010 * alloc.c (Fgarbage_collect, mark_object): Use it.
1011 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1012 (init_buffer): Likewise.
1013 * data.c (Fset_default): Likewise.
1014 * coding.c (code_conversion_restore): Remove redundant check
1015 for dead buffer.
1016 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1017
60cfd278
AS
10182012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1019
1020 Fix bug that created negative-length intervals.
1021 * intervals.c (merge_interval_right, merge_interval_left):
1022 Do not zero out this interval if it is absorbed by its children,
1023 as this interval's total length doesn't change in that case. See
1024 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1025
d06714cb
PE
10262012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1027
83713154
PE
1028 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1029 when invoking (make-bool-vector N t) and N is a positive
1030 multiple of 8 -- the last 8 bits were mistakenly cleared.
1031
d06714cb
PE
1032 Remove some struct layout assumptions in bool vectors.
1033 * alloc.c (bool_header_size): New constant.
1034 (header_size, word_size): Move earlier, as they're now used earlier.
1035 Use 'word_size' in a few more places, where it's appropriate.
1036 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1037 padding before the data member of a bool vector.
1038 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1039 than doing the check by hand with an abort ().
1040
464d5a5e
SM
10412012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1042
5fbc0409
SM
1043 * eval.c (Fdefvar): Don't check constants since we only set the var if
1044 it's not yet defined anyway (bug#11904).
1045
464d5a5e
SM
1046 * lisp.h (last_undo_boundary): Declare new var.
1047 * keyboard.c (command_loop_1): Set it.
1048 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1049 were auto-added by the command loop (bug#11774).
1050
8dc2e44a
AS
10512012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1052
1053 * w32font.c (Qsymbol): Remove local definition.
1054 (syms_of_w32font): Don't DEFSYM it.
1055
169925ec
DA
10562012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1057
1058 Fix sweep_vectors to handle large bool vectors correctly.
1059 * alloc.c (sweep_vectors): Account total_vector_bytes for
1060 bool vectors larger than VBLOCK_BYTES_MAX.
1061
5fbfb018
CY
10622012-07-18 Chong Yidong <cyd@gnu.org>
1063
1064 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1065 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1066
3ab6e069
DA
10672012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1068
1069 Return more descriptive data from Fgarbage_collect.
1070 Suggested by Stefan Monnier in
1071 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1072 * alloc.c (bounded_number): New function.
1073 (total_buffers, total_vectors): New variable.
1074 (total_string_size): Rename to total_string_bytes, adjust users.
1075 (total_vector_size): Rename to total_vector_bytes, adjust users.
1076 (sweep_vectors): Account total_vectors and total_vector_bytes.
1077 (Fgarbage_collect): New return value. Adjust documentation.
1078 (gc_sweep): Account total_buffers.
1079 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1080 (VECTOR_SIZE): Remove.
1081 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1082 (Qinterval, Qmisc): New symbols.
1083 (syms_of_data): Initialize them.
1084 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1085 (Qcons, Qbuffer): New declarations.
1086
6d02fe5b
PE
10872012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1088
1089 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1090 Round up, not down. Improve doc.
1091
b7ffe040
DA
10922012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1093
1094 Restore old code in allocate_string_data to avoid Faset breakage.
1095 Reported by Julien Danjou <julien@danjou.info> in
1096 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1097 * alloc.c (allocate_string_data): Restore old code with minor
1098 adjustments, fix comment to explain this subtle issue.
1099
4dc7c8d5
SM
11002012-07-17 Eli Zaretskii <eliz@gnu.org>
1101
1102 Remove FILE_SYSTEM_CASE.
1103 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1104
1105 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1106 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1107 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1108 call-process-region passes it through expand-file-name.
1109
1110 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1111
11122012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1113
1114 Fix crash when creating indirect buffer (Bug#11917)
1115 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1116 Don't handle unbound variables specially if non-zero.
1117 (Fbuffer_local_variables): Pass zero.
1118 (clone_per_buffer_values): Pass non-zero.
1119
11202012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1121
1122 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1123 to make the loop interruptible.
1124
11252012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1126
1127 * gnutls.c (emacs_gnutls_handshake): Only retry if
1128 GNUTLS_E_INTERRUPTED.
1129
cce7fefc
DA
11302012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1131
1132 Cleanup and convert miscellaneous checks to eassert.
1133 * alloc.c (mark_interval): Fix comment, partially rephrase
1134 old comment from intervals.h (see below).
1135 * intervals.c (find_interval, adjust_intervals_for_insertion)
1136 (delete_interval, adjust_intervals_for_deletion)
1137 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1138 Convert to eassert.
1139 (adjust_intervals_for_insertion, make_new_interval):
1140 Remove obsolete and unused code.
1141 * intervals.h (struct interval): Remove obsolete comment.
1142 * textprotp.c (erase_properties): Remove unused code.
1143 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1144 (Fremove_list_of_text_properties): Convert to eassert.
1145
9ea10cc3
CY
11462012-07-17 Chong Yidong <cyd@gnu.org>
1147
1148 * editfns.c (Finsert_char): Doc fix.
1149
3900d5de
DA
11502012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1151
1152 Fix previous change to make Fmemory_free always accurate.
1153 * alloc.c (make_interval): Update total_free_intervals.
1154 (make_float): Likewise for total_free_floats.
1155 (free_cons, Fcons): Likewise for total_free_conses.
1156 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1157 Likewise for total_free_vector_bytes.
1158 (Fmake_symbol): Likewise for total_free_symbols.
1159 (bytes_free): Remove.
1160
7098646f
DA
11612012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1162
1163 Simple free memory accounting feature.
1164 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1165 (sweep_vectors): Accumulate size of free vectors.
1166 (Fgarbage_collect): Setup bytes_free.
1167 (Fmemory_free): New function.
1168 (syms_of_alloc): Register it.
1169
22657b40
DA
11702012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1171
1172 Cleanup overlays checking.
1173 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1174 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1175 eassert and OVERLAYP.
1176 (sort_overlays): Change to use OVERLAYP.
1177
ddfc8813
RK
11782012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1179
1180 * editfns.c (Finsert_char): Make it interactive, and make the
1181 second arg optional. Copy interactive spec and docstring from
1182 ucs-insert.
1183
7c26cf3c
PE
11842012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1185
1186 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1187 Unlike the other wrapped functions, fabs has an unspecified
1188 effect on errno.
1189
5d127af9
JD
11902012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1191
1192 * nsterm.m (keyDown): Interpret flags without left/right bits
1193 as the left key (Bug#11670).
1194
6a0dd1d7
DA
11952012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1196
1197 Remove empty and useless init functions.
1198 * lisp.h (init_character_once, init_fns, init_image)
1199 (init_filelock, init_sound): Remove prototype.
1200 * character.c (init_character_once): Remove.
1201 * filelock.c (init_filelock): Likewise.
1202 * fns.c (init_fns): Likewise.
1203 * image.c (init_image): Likewise.
1204 * sound.c (init_sound): Likewise.
1205 * emacs.c (main): Adjust accordingly.
1206
7a6136fd
DA
12072012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1208
1209 * gtkutil.h: Tiny cleanups.
1210 (use_old_gtk_file_dialog): Remove useless declaration.
1211 (xg_uses_old_file_dialog): Add suggested const attribute.
1212
ce811ad9
EZ
12132012-07-15 Eli Zaretskii <eliz@gnu.org>
1214
1215 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1216 (bidi_paragraph_init): Use it to limit search forward for a strong
1217 directional character in abnormally large paragraphs full of
1218 neutral or weak characters. (Bug#11943)
1219
c9adfeaa
SF
12202012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1221
1222 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1223 the toolbar (Bug#9451).
1224 (xg_make_tool_item): Give the widget event box a transparent
1225 background.
1226
fff62aa9
DA
12272012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1228
1229 Cleanup basic allocation variables and functions.
1230 * alloc.c (ignore_warnings, init_intervals, init_float)
1231 (init_cons, init_symbol, init_marker): Remove.
1232 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1233 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1234 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1235 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1236 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1237 (staticidx, init_alloc_once, init_strings, free_ablock):
1238 Remove redundant initialization.
1239 * fns.c (init_weak_hash_tables): Remove.
1240 * lisp.h (init_weak_hash_tables): Remove prototype.
1241
9730daca
DA
12422012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1243
1244 Use zero_vector where appropriate.
1245 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1246 accordingly.
1247 * lisp.h (zero_vector): New declaration.
1248 * font.c (null_vector): Remove.
1249 (syms_of_font): Remove initialization and staticpro.
1250 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1251 * keymap.c (Faccessible_keymaps): Likewise.
1252
2e2d2a13
LL
12532012-07-15 Leo Liu <sdl.web@gmail.com>
1254
1255 * fringe.c: Fix typo in comments.
1256
cd276f6e
LL
12572012-07-14 Leo Liu <sdl.web@gmail.com>
1258
1259 * fringe.c: Add a new bitmap exclamation-mark.
1260
5a1131d9
EZ
12612012-07-14 Eli Zaretskii <eliz@gnu.org>
1262
1263 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1264
1265 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1266 (HAVE_MENUS): Don't define, defined by editing config.in with
1267 msdos/sed2v2.inp.
1268 (GMALLOC_INHIBIT_VALLOC): Don't define.
1269 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1270
22e983b7
JB
12712012-07-14 Juanma Barranquero <lekktu@gmail.com>
1272
1273 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1274
5b3f250f
GM
12752012-07-14 Glenn Morris <rgm@gnu.org>
1276
1277 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1278 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1279 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1280
33d63ff4
GM
12812012-07-13 Glenn Morris <rgm@gnu.org>
1282
5b633342
GM
1283 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1284
33d63ff4
GM
1285 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1286 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1287
b55b9f85
JD
12882012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1289
0dc8cf50
JD
1290 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1291 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1292 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1293 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1294 where appropriate.
1295 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1296 as boolean expression.
1297 (x_set_window_size): Remove unused variable toolbar.
1298 (ns_get_color_default, ns_mod_to_lisp): Remove.
1299 (ns_mouse_position): Remove unused variables xchar and ychar.
1300 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1301 (ns_set_vertical_scroll_bar): Remove unused variable count.
1302 (ns_delete_terminal): Remove unused variable i.
1303 (ns_term_init): Remove unused variables r, g and b.
1304 (mouseDown): Remove unused variable window.
1305 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1306 (initFrameFromEmacs): Remove unused variable vbextra.
1307 (mouseEntered): Remove unused variables p and dpyinfo.
1308 (mouseExited): Remove unused variables p and r.
1309 (ns_define_frame_cursor, ns_clear_frame_area)
1310 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1311 (menuDown): Assign [sender tag] to variable and cast the variable.
1312
1313 * nsterm.h (menuDown): Add id as type to argument sender.
1314 (ns_display_info_for_name): Add Lisp_Object argument.
1315 (ns_term_init): Add Lisp_Object argument.
1316 (ns_map_event_to_object): Add void argument.
1317 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1318 prototype with arguments and only declare if __OBJC__.
1319 (nxatoms_of_nsselect): Add void argument.
1320 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1321 (ns_alloc_autorelease_pool): Add void argument.
1322 (ns_release_autorelease_pool): Add void* argument.
1323 (ns_get_defaults_value): Add const char* argument.
1324
1325 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1326 (initFromContents): Use SSDATA where appropriate.
1327 (ns_update_menubar): Add braces to ambigous if-else.
1328 (initWithTitle): Put () around assignment in if statement.
1329 (ns_menu_show): Remove unused variables window and keymap.
1330 (update_frame_tool_bar): Remove unused variable selected_p.
1331 (initWithContentRect): Remove unused variable this_cmd_name.
1332
1333 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1334 appropriate.
1335 (setXBMColor): Remove unused variable len.
1336 (setPixmapData): Put () around assignment in loop statement.
1337
1338 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1339 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1340 where appropriate.
1341 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1342 around assignment in loop statement.
1343 (nsfont_open): Remove unused variable i.
1344 (nsfont_open): Remove unused variable len.
1345 (nsfont_draw): Remove unused variable cs.
1346
1347 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1348 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1349 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1350 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1351 (Fns_font_name, Fns_perform_service)
1352 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1353 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1354 (ns_set_name): Remove unused variable view.
1355 (x_set_menu_bar_lines): Remove unused variable olines.
1356 (x_set_tool_bar_lines): Remove unused variable root_window.
1357 (Fns_list_colors): Put () around assignment in while statement.
1358 (Fns_perform_service): Remove unused variable len.
1359 (Fns_display_usable_bounds): Remove unused variable top.
1360 (syms_of_nsfns): Remove unused variable i.
1361
b55b9f85
JD
1362 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1363 memcpy (Bug#11907).
1364
ed9265fc 13652012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1366
1367 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1368 and free it with DestroyExceptionInfo (Bug#11558).
1369
ef099b57
JB
13702012-07-13 Juanma Barranquero <lekktu@gmail.com>
1371
1372 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1373 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1374 Set here, not in nt/config.nt.
1375
ea814a5d
EZ
13762012-07-13 Eli Zaretskii <eliz@gnu.org>
1377
1378 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1379 cursor overflow into the last glyph on display line when the right
1380 fringe is off. (Bug#11832)
1381
1a952767
PE
13822012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1383
1384 * xdisp.c (produce_special_glyphs): Now static.
1385 * dispextern.h (produce_special_glyphs): Remove decl.
1386
983188fd
GM
13872012-07-13 Glenn Morris <rgm@gnu.org>
1388
8d7c7eed 1389 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1390 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1391
983188fd
GM
1392 * s/usg5-4-common.h (USG, USG5):
1393 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1394 * s/sol2-6.h (SOLARIS2):
1395 * s/irix6-5.h (IRIX6_5):
1396 * s/hpux10-20.h (USG, USG5, HPUX):
1397 * s/gnu-linux.h (USG, GNU_LINUX):
1398 * s/freebsd.h (BSD_SYSTEM):
1399 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1400 * s/cygwin.h (CYGWIN):
1401 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1402 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1403
d1e68667 14042012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1405
1406 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1407
6de0e799
GM
14082012-07-13 Glenn Morris <rgm@gnu.org>
1409
739ae010
GM
1410 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1411
dbee5793
GM
1412 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1413
6de0e799
GM
1414 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1415 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1416
b82da769
GM
14172012-07-12 Glenn Morris <rgm@gnu.org>
1418
4fae5a7a 1419 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1420
1421 * process.c (init_process_emacs): Rename from init_process.
1422 The old name is also the name of a Mach system call.
1423 * lisp.h, emacs.c: Update for this name change.
1424 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1425 longer needed.
1426
5a979817
EZ
14272012-07-12 Eli Zaretskii <eliz@gnu.org>
1428
1429 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1430 memmove call that removes glyphs covered by the left truncation
1431 glyph. Improve commentary.
1432 (display_line): Fix display of continuation glyphs on GUI frames
1433 when the right fringe is turned off and variable-size fonts are
1434 used in the window. Move the code that appends a stretch glyph to
1435 produce_special_glyphs, so that it could be used for truncation
1436 and continuation glyphs alike.
1437 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1438 glyph of a suitably computed width, to align the special glyphs at
1439 the window margin. Code moved from display_line. (Bug#11832)
1440
3e91a053
GM
14412012-07-12 Glenn Morris <rgm@gnu.org>
1442
ba9e4b84
GM
1443 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1444
1445 * s/gnu-linux.h, s/hpux10-20.h:
1446 Do not unconditionally define HAVE_XRMSETDATABASE.
1447
3e91a053
GM
1448 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1449
b300b1f4
PE
14502012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1451
1452 Fix typos that broke OS X build.
1453 Reported by Randal L. Schwartz in
1454 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1455 * nsterm.m (ns_timeout): Add missing local decl.
1456 (ns_get_color): snprintf -> sprintf, to fix typo.
1457
6e777848
GM
14582012-07-12 Glenn Morris <rgm@gnu.org>
1459
3f922c37
GM
1460 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1461 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1462 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1463 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1464
0ab7b23a
GM
1465 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1466 Move PTY_OPEN to configure.
1467
6e777848
GM
1468 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1469 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1470 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1471
4a7edc24
DA
14722012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1473
1474 Use empty_unibyte_string where applicable.
1475 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1476 * lread.c (read1): Likewise.
1477 * xsettings.c (syms_of_xsettings): Likewise.
1478
308aab79
GM
14792012-07-12 Glenn Morris <rgm@gnu.org>
1480
42bd1719
GM
1481 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1482 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1483 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1484 * s/hpux10-20.h (RUN_TIME_REMAP):
1485 * s/bsd-common.h (TABDLY): Move to configure.
1486
1487 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1488
1489 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1490
ea0bbd17 1491 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1492 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1493
1494 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1495
308aab79
GM
1496 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1497 * s/template.h: Move NARROWPROTO to configure.
1498
ee1cf5cf
GM
14992012-07-11 Glenn Morris <rgm@gnu.org>
1500
30fe9bf4
GM
1501 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1502 unused since 2011-01-17 change to systty.h.
1503
ee1cf5cf
GM
1504 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1505 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1506 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1507
63e47e07
PE
15082012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1509
1510 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1511
c43fb4c3
GM
15122012-07-11 Glenn Morris <rgm@gnu.org>
1513
1514 * s/darwin.h, s/gnu-linux.h, s/template.h:
1515 Move INTERRUPT_INPUT to configure.
1516
e8df9267
DA
15172012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1518
1519 Minor adjustments to interning code.
1520 * lisp.h (intern, intern_c_string): Redefine as static inline
1521 wrappers for intern_1 and intern_c_string_1, respectively.
1522 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1523 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1524 Vobarray checking.
e8df9267
DA
1525 * font.c (font_intern_prop): Likewise. Adjust comment.
1526 * w32font.c (intern_font_name): Likewise.
1527
34348bd4
AS
15282012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1529
d96a1e0c
AS
1530 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1531
34348bd4
AS
1532 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1533 of Fcar/Fcdr if possible.
1534 * font.c (check_otf_features): Likewise.
1535 * fontset.c (Fnew_fontset): Likewise.
1536 * gnutls.c (Fgnutls_boot): Likewise.
1537 * minibuf.c (read_minibuf): Likewise.
1538 * msdos.c (IT_set_frame_parameters): Likewise.
1539 * xmenu.c (Fx_popup_dialog): Likewise.
1540 * w32menu.c (Fx_popup_dialog): Likewise.
1541
c8add24e
GM
15422012-07-11 Glenn Morris <rgm@gnu.org>
1543
4b575b3c
GM
1544 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1545 since nothing has defined it on these platforms.
1546
09f4e3b0
GM
1547 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1548 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1549
172bedef
GM
1550 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1551 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1552 Move CLASH_DETECTION to configure.
1553
249685df
GM
1554 * s/gnu.h: Remove file, which is now empty.
1555
c8add24e
GM
1556 * s/gnu.h, s/gnu-linux.h:
1557 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1558
b41253a3
JW
15592012-07-11 John Wiegley <johnw@newartisans.com>
1560
1561 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1562 function attribute, so we only use it if it exists in the
1563 compiler.
1564
d923b542
DA
15652012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1566
1567 Avoid call to strlen in fast_c_string_match_ignore_case.
1568 * search.c (fast_c_string_match_ignore_case): Change to use
1569 length argument. Adjust users accordingly.
1570 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1571
5ebbef1d
PE
15722012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1573
bb352260
PE
1574 Assume mkdir, rmdir.
1575 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1576 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1577
57054ddd
PE
1578 Assume rename.
1579 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1580
b747d3f7
PE
1581 Assume perror.
1582 * s/hpux10-20.h (HAVE_PERROR): Remove.
1583 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1584 Remove dummy definition, as this problem was obsolete long ago.
1585
5ebbef1d
PE
1586 Assume strerror.
1587 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1588
984e7f30
DA
15892012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1590
1591 Avoid calls to strlen in font processing functions.
1592 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1593 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1594 users accordingly.
d923b542
DA
1595 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1596 Adjust prototypes.
1597 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1598 Change to return ptrdiff_t.
984e7f30
DA
1599 (xfont_list_pattern, xfont_match): Use length returned by
1600 xfont_decode_coding_xlfd.
1601 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1602
20e94fdd
GM
16032012-07-11 Glenn Morris <rgm@gnu.org>
1604
9d596af3
GM
1605 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1606 Move DONT_REOPEN_PTY to configure.
1607
20e94fdd
GM
1608 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1609 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1610
e99a530f
PE
16112012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1612
22ffb973
PE
1613 Remove "#define unix" that is no longer needed (Bug#11905).
1614 * s/aix4-2.h (unix): Remove; no longer needed.
1615
e9a9ae03
PE
1616 EMACS_TIME simplification (Bug#11875).
1617 This replaces macros (which typically do not work in GDB)
1618 with functions, typedefs and enums, making the code easier to debug.
1619 The functional style also makes code easier to read and maintain.
1620 * systime.h: Include <sys/time.h> on all hosts, not just if
1621 WINDOWSNT, since 'struct timeval' is needed in general.
1622 (EMACS_TIME): Now a typedef, not a macro.
1623 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1624 not macros.
1625 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1626 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1627 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1628 (EMACS_TIME_LE): Now functions, not macros.
1629 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1630 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1631 which are not functions. All uses rewritten to use:
1632 (make_emacs_time): New function.
1633 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1634 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1635 not functions. All uses rewritten to use the following, respectively:
1636 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1637 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1638 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1639 * fileio.c (Fcopy_file):
1640 * xterm.c (XTflash): Get the current time closer to when it's used.
1641 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1642
ffacb126
PE
1643 * bytecode.c (targets): Suppress -Woverride-init warnings.
1644
e99a530f
PE
1645 Simplify by avoiding confusing use of strncpy etc.
1646 * doc.c (Fsnarf_documentation):
1647 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1648 * frame.c (Fmake_terminal_frame):
1649 * gtkutil.c (get_utf8_string):
1650 * lread.c (openp):
1651 * nsmenu.m (ns_update_menubar):
1652 * regex.c (regerror):
1653 Prefer memcpy to strncpy and strncat when either will do.
1654 * fileio.c (Fsubstitute_in_file_name):
1655 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1656 (menu_separator_name_p):
1657 * nsmenu.m (ns_update_menubar):
1658 Prefer memcmp to strncmp when either will do.
1659 * nsterm.m: Include <ftoastr.h>.
1660 (ns_get_color):
1661 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1662 Prefer snprintf to strncpy.
1663 * nsterm.m (ns_term_init):
1664 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1665 * nsterm.m (ns_term_init):
1666 Avoid the need for strncpy, by using build_string or
1667 make_unibyte_string directly. Use dtoastr, not snprintf.
1668 * process.c (Fmake_network_process): Diagnose service names that
1669 are too long, rather than silently truncating them or creating
1670 non-null-terminated names.
1671 (Fnetwork_interface_info): Likewise, for interface names.
1672 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1673 Prefer sprintf to strncat.
1674 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1675 Prefer vsnprintf to vsprintf + strncpy.
1676
c59592b3
GM
16772012-07-10 Glenn Morris <rgm@gnu.org>
1678
1679 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1680 Clarify fallback case.
1681
7d7bbefd
DA
16822012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1683
1684 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1685 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1686 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1687 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1688 where argument type is known to be a Lisp_Cons.
1689
3a4c8000
TT
16902012-07-10 Tom Tromey <tromey@redhat.com>
1691
1692 * bytecode.c (BYTE_CODE_THREADED): New macro.
1693 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1694 (enum byte_code_op): New type.
1695 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1696 (exec_byte_code): Use them. Use token threading when applicable.
1697
2a0213a6
DA
16982012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1699
1700 Optimize pure C strings initialization.
1701 * lisp.h (make_pure_string): Fix prototype.
1702 (build_pure_c_string): New function, defined as static inline. This
1703 provides a better opportunity to optimize away calls to strlen when
1704 the function is called with compile-time constant argument.
1705 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1706 argument, adjust users accordingly. Use build_pure_c_string where
1707 appropriate.
1708 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1709 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1710 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1711
cb1caeaf
DA
17122012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1713
1714 Avoid calls to strlen in miscellaneous functions.
1715 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1716 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1717 * lread.c (openp): Likewise.
1718
c293e30c
DA
17192012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1720
1721 Avoid calls to strlen in path processing functions.
1722 * fileio.c (file_name_as_directory): Add comment. Change to add
1723 srclen argument and return the length of result. Adjust users
1724 accordingly.
1725 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1726 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1727 users accordingly.
1728 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1729
9e059e3f
GM
17302012-07-10 Glenn Morris <rgm@gnu.org>
1731
d02eb359
GM
1732 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1733 Move PENDING_OUTPUT_COUNT definition to configure.
1734
882cf227
GM
1735 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1736 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1737 * s/gnu.h (DATA_START): Move definitions to configure.
1738
af6e839f
GM
1739 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1740 We include usg5-4-common.h, which defines them both.
1741
40289a12
GM
1742 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1743 O_RDONLY already includes it).
1744
9e059e3f
GM
1745 Stop ns builds setting the EMACSLOADPATH environment variable.
1746 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1747 Now it does not set EMACSLOADPATH, just returns the load-path string.
1748 * nsterm.h: Update accordingly.
1749 * lread.c [HAVE_NS]: Include nsterm.h.
1750 (init_lread) [HAVE_NS]: Use ns_load_path.
1751 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1752
7c4e8ec0
GM
17532012-07-09 Glenn Morris <rgm@gnu.org>
1754
d4f600ff
GM
1755 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1756 since the included bsd-common.h does so.
1757
cbb31951
GM
1758 Stop ns builds setting the EMACSPATH environment variable.
1759 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1760 (ns_init_paths): Do not set EMACSPATH.
1761 * nsterm.h (ns_exec_path): Add it.
1762 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1763 Use ns_exec_path.
1764
7c4e8ec0
GM
1765 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1766
26bccfae
PE
17672012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1768
a0bee46f
PE
1769 * process.c (wait_reading_process_output): 'waitchannels' was unset
1770 when read_kbd || !NILP (wait_for_cell); fix this.
1771
5994c183
PE
1772 Add GCC-style 'const' attribute to functions that can use it.
1773 * character.h (char_resolve_modifier_mask):
1774 * keyboard.h (make_ctrl_char):
1775 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1776 (init_character_once, next_almost_prime, init_fns, init_image)
1777 (flush_pending_output, init_sound):
1778 * mem-limits.h (start_of_data):
1779 * menu.h (finish_menu_items):
1780 Add ATTRIBUTE_CONST.
1781 * emacs.c (DEFINE_DUMMY_FUNCTION):
1782 Declare the dummy function with ATTRIBUTE_CONST.
1783 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1784 Add decls with ATTRIBUTE_CONST.
1785
26bccfae
PE
1786 Minor improvements to make_formatted_string.
1787 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1788 where int is good enough, as vsprintf returns an int.
1789 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1790
a8290ec3
DA
17912012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1792
1793 Use make_formatted_string to avoid double length calculation.
1794 * lisp.h (make_formatted_string): New prototype.
1795 * alloc.c (make_formatted_string): New function.
1796 * buffer.c (Fgenerate_new_buffer_name): Use it.
1797 * dbus.c (syms_of_dbusbind): Likewise.
1798 * editfns.c (Fcurrent_time_zone): Likewise.
1799 * filelock.c (get_boot_time): Likewise.
1800 * frame.c (make_terminal_frame, set_term_frame_name)
1801 (x_report_frame_params): Likewise.
1802 * image.c (gs_load): Likewise.
1803 * minibuf.c (get_minibuffer): Likewise.
1804 * msdos.c (dos_set_window_size): Likewise.
1805 * process.c (make_process): Likewise.
1806 * xdisp.c (ensure_echo_area_buffers): Likewise.
1807 * xsettings.c (apply_xft_settings): Likewise.
1808
d01ba2f1
GM
18092012-07-09 Glenn Morris <rgm@gnu.org>
1810
1811 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1812 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1813 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1814 * nsterm.h (ns_etc_directory): Add it.
1815 * callproc.c [HAVE_NS]: Include nsterm.h.
1816 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1817
f1f924b6
DA
18182012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1819
1820 Move marker debugging code under MARKER_DEBUG.
1821 * marker.c (MARKER_DEBUG): Move marker debugging code under
1822 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1823 for bootstrap with --enable-checking (~3x slowdown reported
1824 by Juanma Barranquero <lekktu@gmail.com>).
1825 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1826
ab531b66
PE
18272012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1828
1829 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1830 See <http://bugs.gnu.org/11825#29>.
1831
c4b3bc8a
EZ
18322012-07-08 Eli Zaretskii <eliz@gnu.org>
1833
1834 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1835 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1836 (display_line): Add commentary about displaying truncation glyphs
1837 on GUI frames.
1838 (produce_special_glyphs): Move here from term.c.
1839
1840 * term.c (produce_special_glyphs): Move to xdisp.c.
1841
1842 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1843 section.
c4b3bc8a 1844
b676b881
AS
18452012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1846
f17c5273
AS
1847 * xdisp.c (display_line): Avoid warning about implicit declaration
1848 of FRAME_FONT.
1849
298819b9
AS
1850 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1851
b676b881
AS
1852 * lisp.h: Remove empty conditional.
1853
6045c4fd
PE
18542012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1855
b3350bf9
PE
1856 * lread.c (load_path_check): Now static.
1857
6045c4fd
PE
1858 Fix some minor --with-ns problems found by static checking.
1859 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1860 (x_set_font) [!HAVE_X_WINDOWS]:
1861 * image.c (xpm_load_image) [HAVE_NS]:
1862 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1863 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1864 Remove unused local.
1865 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1866 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1867 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1868 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1869 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1870 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1871 Fix pointer signedness problem.
1872 * xfaces.c (FRAME_X_FONT_TABLE):
1873 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1874
929e7845
GM
18752012-07-07 Glenn Morris <rgm@gnu.org>
1876
1877 * lread.c (load_path_check): New function, split from init_lread.
1878 (init_lread): Reorganize. Motivation:
1879 If EMACSLOADPATH is set, check/warn about that rather than the
1880 defaults, which we are not going to use. Hence we can remove
1881 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1882 Don't warn if site-lisp directories are missing.
1883 If not installed, start from a blank load-path, since
1884 PATH_LOADSEARCH refers to the eventual installation directories.
1885
58dd0aa4
EZ
18862012-07-07 Eli Zaretskii <eliz@gnu.org>
1887
1888 Support truncation and continuation glyphs on GUI frames, when
1889 fringes are disabled. (Bug#11832)
1890 * xdisp.c (init_iterator): Get dimensions of truncation and
1891 continuation glyphs even if on GUI frames. Adjust
1892 it->last_visible_x on GUI frames when the left or right fringes,
1893 or both, are absent.
1894 (start_display, move_it_in_display_line_to): Handle the case of a
1895 GUI frame without a fringe to display continuation or truncation
1896 glyphs.
1897 (insert_left_trunc_glyphs): Support GUI frames: make sure
1898 truncation glyphs overwrite enough glyphs from the current line to
1899 have sufficient space in pixels.
1900 (display_line): Support truncation and continuation glyphs on GUI
1901 frames. If some spare pixels are left on the line after inserting
1902 the truncation glyphs, fill that space with a stretch glyph of a
1903 suitably computed width.
1904
1905 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1906 produce_glyphs, to support GUI sessions.
1907
31571fd7
PE
19082012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1909
5a16b9bc
PE
1910 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1911
f3047c75
PE
1912 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1913
31571fd7
PE
1914 Do not require float-time's arg to fit in time_t (Bug#11825).
1915 This works better on hosts where time_t is unsigned, and where
1916 float-time is applied to the (negative) difference between two times.
1917 * editfns.c (decode_time_components): Last arg is now double *,
1918 not int *, and means to store all the result as a double, without
1919 worrying about whether the seconds part fits in time_t.
1920 All callers changed.
1921 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1922 All callers changed.
1923 (Ffloat_time): Do not fail merely because the specified time falls
1924 outside of time_t range.
1925
4516fbef
GM
19262012-07-07 Glenn Morris <rgm@gnu.org>
1927
1928 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1929 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1930 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1931
07adc2c6
JB
19322012-07-07 Juanma Barranquero <lekktu@gmail.com>
1933
1934 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1935 Update dependencies.
1936
1937 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1938
fd573f31
PE
19392012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1940
fee5959d
PE
1941 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1942 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1943 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1944 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1945 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1946 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1947
fd573f31
PE
1948 * xfont.c (compare_font_names): Redo to omit the need for casts.
1949
ddadbc0e
AS
19502012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1951
fca8d6b6
AS
1952 * xfns.c (Fx_change_window_property): Doc fix.
1953 * w32fns.c (Fx_change_window_property): Doc fix.
1954
ddadbc0e
AS
1955 * w32fns.c (Fx_window_property): Accept the same arguments as the
1956 X Windows version. Doc fix.
1957 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1958
ed9265fc 19592012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1960 Eli Zaretskii <eliz@gnu.org>
1961
1962 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1963 Windows-specific code from nt/config.nt moved here.
1964 Obsolete settings removed.
1965
216ee680
PE
19662012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1967
1968 * process.c: Avoid unnecessary calls to gettime.
1969 (wait_reading_process_output): Don't get the time of day
1970 when gobbling data immediately and not waiting, as there's no need
1971 for it in that case. This removes a FIXME.
1972
bdd091e4
JD
19732012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1974
1975 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1976 is defined (Bug#11768).
1977
9d44f8ce
DA
19782012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1979
1980 Fix marker debugging code.
1981 * marker.c (byte_char_debug_check): Do not perform the check
1982 if buffer is not multibyte.
090bd7cb
JB
1983 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1984 Call byte_char_debug_check with correct arguments.
9d44f8ce 1985
90fc4786
DA
19862012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1987
1988 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1989 * marker.c (byte_char_debug_check, count_markers):
1990 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1991 (byte_debug_flag): Remove.
1992 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1993 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1994
7b7ae965
DA
19952012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1996
4e57b342
DA
1997 Avoid code repetition in marker-related functions.
1998 * marker.c (attach_marker): New function.
1999 (Fset_marker, set_marker_restricted, set_marker_both)
2000 (set_marker_restricted_both): Use it.
2001 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2002 Consistently rename charno to charpos.
2003 (marker_position): Add eassert.
2004 (marker_byte_position): Convert to eassert.
2005
20062012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2007
2008 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2009 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2010 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2011
657924ff
DA
20122012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2013
2014 Introduce fast path for the widely used marker operation.
2015 * alloc.c (build_marker): New function.
2016 * lisp.h (build_marker): New prototype.
2017 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2018 * composite.c (autocmp_chars): Likewise.
2019 * editfns.c (buildmark): Remove.
2020 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2021 (save_restriction_save): Use build_marker.
2022 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2023 * window.c (save_window_save): Likewise.
2024
041a49a6
DA
20252012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2026
2027 Do not use Fdelete_overlay in delete_all_overlays
2028 to avoid redundant calls to unchain_overlay.
2029 * buffer.c (drop_overlay): New function.
2030 (delete_all_overlays, Fdelete_overlay): Use it.
2031 * minibuf.c (get_minibuffer): Fix comment.
2032
7dca65a4
PE
20332012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2034
2035 Port to OpenBSD 5.1 amd64.
2036 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2037 This is needed for OpenBSD, and should be harmless on all BSD systems.
2038 Also, include <sys/sysctl.h>, as it should be available on all
2039 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2040 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2041 use p_pid member, not kp_proc.pid.
2042
8eb876e2
GM
20432012-07-06 Glenn Morris <rgm@gnu.org>
2044
2045 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2046
38182d90
PE
20472012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2048
2049 More xmalloc and related cleanup.
2050 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2051 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2052 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2053 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2054 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2055 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2056 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2057 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2058 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2059 * xterm.c:
2060 Omit needless casts involving void * pointers and allocation.
2061 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2062 as the former is more robust if P's type is changed.
2063 Prefer xzalloc to xmalloc + memset 0.
2064 Simplify malloc-or-realloc to realloc.
2065 Don't worry about xmalloc returning a null pointer.
2066 Prefer xstrdup to xmalloc + strcpy.
2067 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2068 growing it.
2069 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2070 alloca of a constant.
2071
6dd5a677
EZ
20722012-07-05 Eli Zaretskii <eliz@gnu.org>
2073
2074 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2075 hscroll is larger than the line width. Fixes long and futile
2076 looping inside extend_face_to_end_of_line (on a TTY) producing
2077 glyphs that are not needed and thrown away.
2078
6b312f0f
DA
20792012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2080
2081 * marker.c (set_marker_restricted_both): Simplify by using
2082 clip_to_bounds.
2083
f520ef9b
PE
20842012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2085
2086 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2087
383b7c95
JD
20882012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2089
2090 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2091 not defined (Bug#11768).
2092 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2093 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2094 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2095 followed by gtk_box_set_homogeneous (Bug#11768).
2096 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2097 (update_theme_scrollbar_width, xg_create_scroll_bar):
2098 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2099 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2100 (is_box_type): New function (Bug#11768).
2101 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2102 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2103 with default display (Bug#11768).
2104
d6e7bf45
EZ
21052012-07-05 Eli Zaretskii <eliz@gnu.org>
2106
2107 * xdisp.c (window_hscroll_limited): New function.
2108 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2109 coordinates when window's hscroll is set to insanely large
2110 values. (Bug#11857)
2111
431391ec
JB
21122012-07-05 Juanma Barranquero <lekktu@gmail.com>
2113
2114 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2115 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2116
23f86fce
DA
21172012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2118
2119 Cleanup xmalloc.
2120 * lisp.h (xzalloc): New prototype. Omit needless casts.
2121 * alloc.c (xzalloc): New function. Omit needless casts.
2122 * charset.c: Omit needless casts. Convert all calls to
2123 xmalloc with following memset to xzalloc.
2124 * dispnew.c: Likewise.
2125 * fringe.c: Likewise.
2126 * image.c: Likewise.
2127 * sound.c: Likewise.
2128 * term.c: Likewise.
2129 * w32fns.c: Likewise.
2130 * w32font.c: Likewise.
2131 * w32term.c: Likewise.
2132 * xfaces.c: Likewise.
2133 * xfns.c: Likewise.
2134 * xterm.c: Likewise.
2135 * atimer.c: Omit needless casts.
2136 * buffer.c: Likewise.
2137 * callproc.c: Likewise.
2138 * ccl.c: Likewise.
2139 * coding.c: Likewise.
2140 * composite.c: Likewise.
2141 * doc.c: Likewise.
2142 * doprnt.c: Likewise.
2143 * editfns.c: Likewise.
2144 * emacs.c: Likewise.
2145 * eval.c: Likewise.
2146 * filelock.c: Likewise.
2147 * fns.c: Likewise.
2148 * gtkutil.c: Likewise.
2149 * keyboard.c: Likewise.
2150 * lisp.h: Likewise.
2151 * lread.c: Likewise.
2152 * minibuf.c: Likewise.
2153 * msdos.c: Likewise.
2154 * print.c: Likewise.
2155 * process.c: Likewise.
2156 * region-cache.c: Likewise.
2157 * search.c: Likewise.
2158 * sysdep.c: Likewise.
2159 * termcap.c: Likewise.
2160 * terminal.c: Likewise.
2161 * tparam.c: Likewise.
2162 * w16select.c: Likewise.
2163 * w32.c: Likewise.
2164 * w32reg.c: Likewise.
2165 * w32select.c: Likewise.
2166 * w32uniscribe.c: Likewise.
2167 * widget.c: Likewise.
2168 * xdisp.c: Likewise.
2169 * xmenu.c: Likewise.
2170 * xrdb.c: Likewise.
2171 * xselect.c: Likewise.
2172
0497dc44
PE
21732012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2174
2175 * fileio.c (time_error_value): Check the right error number.
2176 Problem reported by Troels Nielsen in
2177 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2178
356e7178
PE
21792012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2180
4e71fd89
PE
2181 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2182 This should be fixed in a better way; see Eli Zaretskii in
2183 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2184 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2185
f0941253
PE
2186 * fileio.c (time_error_value): Rename from special_mtime.
2187 The old name's problems were noted by Eli Zaretskii in
2188 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2189
065c9eb4
PE
2190 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2191 This variable's comment says Emacs needs at least one GDB-visible
2192 symbol of type enum pvec_type, to work around GDB problems.
2193 The symbol's value doesn't matter.
2194
356e7178
PE
2195 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2196 that causes compilation to fail on pre-C99 compilers.
2197
ed9265fc 21982012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2199
2200 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2201 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2202
3884d954
DA
22032012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2204
d209e2fb 2205 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2206 headers for buffer_defaults and buffer_local_symbols.
2207 Reported by Juanma Barranquero <lekktu@gmail.com>.
2208
ee28be33
SM
22092012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2210
2211 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2212 * lisp.h (enum pvec_type): Use fewer bits.
2213 (PSEUDOVECTOR_SIZE_BITS): New constant.
2214 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2215 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2216 change in pvec_type.
2217 (PSEUDOVECTOR_TYPEP): New macro.
2218 (TYPED_PSEUDOVECTORP): Use it.
2219 * fns.c (internal_equal): Adapt code to extract pvectype.
2220 * emacs.c (gdb_pvec_type): Update type.
2221 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2222 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2223 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2224 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2225 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2226 abusing vector->header.next.nbytes.
2227 (live_vector_p): Use PVEC_TYPE.
2228 (mark_object): Adapt code to extract pvectype. Use switch.
2229
c7f2cd7f
PE
22302012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2231
2232 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2233 Tighten new eassert a bit.
2234
8ce70ed2
DA
22352012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2236
2237 Fix compilation with --enable-gcc-warnings and -O1
2238 optimization level.
2239 * doprnt.c (doprnt): Change type of tem to int, initialize
2240 to avoid compiler warning. Add eassert.
2241 * search.c (simple_search): Initialize match_byte to avoid
2242 compiler warning. Add eassert.
2243
dea7f1e5
PE
22442012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2245
24a212eb
PE
2246 Avoid weird behavior with large horizontal scrolls.
2247 Without this change, for example, large hscroll values would
2248 mess up Emacs's display on Fedora 15 x86, presumably due to
2249 overflows in int calculations in the display code.
2250 Also, if buffers had long lines, Emacs would freeze.
2251 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2252 (set_window_hscroll): New function, containing the old guts of
2253 Fset_window_hscroll. Return the clipped value.
2254 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2255 This avoids the need to check against PTRDIFF_MAX.
2256
dea7f1e5
PE
2257 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2258
76046526
DA
22592012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2260
2261 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2262
39adff0d
PE
22632012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2264
63807d47
PE
2265 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2266 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2267 since GCC 4.4.6 issues a bogus warning for them.
2268
39adff0d
PE
2269 Fix bugs in file timestamp newness comparisons.
2270 * fileio.c (Ffile_newer_than_file_p):
2271 * lread.c (Fload): Use full timestamp resolution of files,
2272 not just the 1-second resolution, so that files that are only
2273 slightly newer still count as newer.
2274 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2275 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2276
dbeed9a6
PE
22772012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2278
2279 * fileio.c: Improve handling of file time marker. (Bug#11852)
2280 (special_mtime): New function.
2281 (Finsert_file_contents, Fverify_visited_file_modtime):
2282 Use it to set special mtime values consistently.
2283
636334d6
AS
22842012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2285
2286 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2287 marker for non-existing file. (Bug#11852)
2288
e2017fe2
GM
22892012-07-03 Glenn Morris <rgm@gnu.org>
2290
2291 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2292 and did not make it into globals.h).
2293
404dbd37
TT
22942012-07-03 Tom Tromey <tromey@redhat.com>
2295
2296 * window.c (Fset_window_margins, Fset_window_fringes)
2297 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2298 * textprop.c (Fprevious_property_change): No longer static.
2299 * syntax.c (Fsyntax_table_p): No longer static.
2300 * process.c (Fget_process, Fprocess_datagram_address): No longer
2301 static.
2302 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2303 * keyboard.c (Fcommand_execute): No longer static.
2304 Remove EXFUN.
2305 * insdel.c (Fcombine_after_change_execute): No longer static.
2306 * image.c (Finit_image_library): No longer static.
2307 * fileio.c (Fmake_symbolic_link): No longer static.
2308 * eval.c (Ffetch_bytecode): No longer static.
2309 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2310 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2311 No longer static.
404dbd37
TT
2312 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2313 static.
2314 * dired.c (Ffile_attributes): No longer static.
2315 * composite.c (Fcomposition_get_gstring): No longer static.
2316 * callproc.c (Fgetenv_internal): No longer static.
2317
2318 * ccl.h: Remove EXFUNs.
2319 * buffer.h: Remove EXFUNs.
2320 * dispextern.h: Remove EXFUNs.
2321 * intervals.h: Remove EXFUNs.
2322 * fontset.h: Remove EXFUN.
2323 * font.h: Remove EXFUNs.
2324 * dosfns.c (system_process_attributes): Remove EXFUN.
2325 * keymap.h: Remove EXFUNs.
2326 * lisp.h: Remove EXFUNs.
2327 * w32term.h: Remove EXFUNs.
2328 * window.h: Remove EXFUNs.
2329 * xsettings.h: Remove EXFUN.
2330 * xterm.h: Remove EXFUN.
2331
8e4fd1e1
GM
23322012-07-03 Glenn Morris <rgm@gnu.org>
2333
2334 * lisp.h (Frandom): Make it visible to C.
2335 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2336 buffer for invisible buffers. (Bug#1229)
2337
ca95b3eb
DA
23382012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2339
2340 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2341 values which aren't power of 2.
2342 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2343 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2344 accordingly.
2345
7555c33f
SM
23462012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2347
2348 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2349
2350 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2351
d12e8f5a
DA
23522012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2353
2354 * alloc.c (allocate_vector_block): Remove redundant
2355 calls to mallopt if DOUG_LEA_MALLOC is defined.
2356 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2357 avoid calls to mallopt if zero_vector is returned.
2358
296094c3
DA
23592012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2360
2361 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2362 is enabled, avoid dereferencing NULL current_sblock if
2363 running undumped.
2364
36429c89
DA
23652012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2366
2367 Cleanup basic buffer management.
2368 * buffer.h (struct buffer): Change layout to use generic vector
2369 marking code. Fix some comments. Change type of 'clip_changed'
2370 to bitfield. Remove unused #ifndef old.
2371 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2372 (GET_OVERLAYS_AT): Fix indentation.
2373 (for_each_per_buffer_object_at): New macro.
2374 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2375 (Fbuffer_local_variables): Use it.
2376 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2377 * alloc.c (allocate_buffer): Adjust to match new layout of
2378 struct buffer. Fix comment.
2379 (mark_overlay): New function.
2380 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2381 Lisp area of struct buffer.
2382 (mark_object): Use it. Adjust marking of misc objects
2383 and related comments.
2384
3b3e4cac
PE
23852012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2386
2387 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2388 wrapper that is not needed because the wrapped code is a no-op (zero
2389 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2390 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2391
cf5c0175
DA
23922012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2393
2394 * alloc.c (mark_buffer): Simplify. Remove prototype.
2395 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2396 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2397 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2398 redundant calls to mark_vectorlike for bool vectors.
2399
ca26824c
GM
24002012-06-30 Glenn Morris <rgm@gnu.org>
2401
2e4c5312
GM
2402 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2403
ca26824c
GM
2404 * epaths.in (PATH_SITELOADSEARCH): New.
2405 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2406 This is rather than relying on --enable-locallisppath elements
2407 having "site-lisp" in their names. (Bug#10208#25, 11658)
2408
0d23c240
EZ
24092012-06-30 Eli Zaretskii <eliz@gnu.org>
2410
c9240d7a
EZ
2411 * w32proc.c (sys_select): Accept and ignore one more argument.
2412
2413 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2414
0d23c240 2415 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2416 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2417
2418 * sysdep.c: Don't include dos.h and dosfns.h.
2419
2420 * process.c (sys_select):
2421 * msdos.c (sys_select): Accept one more argument and ignore it.
2422
2423 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2424 adapt data types and code to that.
2425
2426 * dosfns.c:
2427 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2428 which clashes with the gnulib function of the same name.
2429
af5a5a98
AS
24302012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2431
c5e4379c
AS
2432 * font.c (font_style_to_value, font_style_symbolic)
2433 (font_prop_validate_style): Add type checks for values in
2434 font_style_table.
2435
af5a5a98
AS
2436 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2437 argument.
2438 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2439 uses.
2440
8d38f461
EZ
24412012-06-29 Eli Zaretskii <eliz@gnu.org>
2442
2e5a6631
EZ
2443 * xdisp.c (try_window_id): Undo last change.
2444
8d38f461
EZ
2445 * w32.c (getwd): Adjust commentary about startup_dir.
2446 (init_environment): Always call sys_access, even in non-MSVC
2447 builds. Don't chdir to the directory of the Emacs executable.
2448 This undoes code from 1997 which was justified by the need to
2449 "avoid conflicts when removing and renaming directories". But its
2450 downside was that every relative file name was being interpreted
2451 relative to the directory of the Emacs executable, which can never
2452 be TRT. In particular, it broke sys_access when called with
2453 relative file names.
2454 (sys_access): Map GetLastError to errno.
2455
2af3565e
DA
24562012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2457
2458 * window.h (struct window): Change type of 'fringes_outside_margins'
2459 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2460 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2461 Adjust comment.
2462 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2463 to ptrdiff_t.
2464
c8d3a25c 24652012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2466
c8d3a25c
GM
2467 * gnutls.c (emacs_gnutls_handshake):
2468 Add QUIT to make the loop interruptible.
57570cd3 2469
c8d3a25c 24702012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2471
c8d3a25c
GM
2472 * charset.c (init_charset): Make lack of etc/charsets fatal.
2473
3e984ee8
DA
24742012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2475
2476 * editfns.c (region_limit): Fix type mismatch.
2477
ef884f23
DA
24782012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2479
2480 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2481 undefined. Convert from xassert to eassert.
2482 * nsmenu.m: Convert from xassert to eassert.
2483 * nsterm.m: Likewise.
2484
7d7e0027
SM
24852012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2486
2487 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2488
aa754e6a
PE
24892012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2490
2491 Avoid integer overflow on scroll-left and scroll-right.
2492 * window.c (HSCROLL_MAX): New macro.
2493 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2494 overflow when requested scroll falls outside ptrdiff_t range.
2495
80b00b08
DA
24962012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2497
2498 * window.h (struct window): Change type of 'hscroll',
2499 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2500 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2501 Adjust users accordingly.
2502 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2503 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2504 from EMACS_INT to ptrdiff_t.
2505 (make_window): Omit redundant initialization.
2506
62b2bcf6
JB
25072012-06-28 Juanma Barranquero <lekktu@gmail.com>
2508
2509 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2510
45942c7d
DA
25112012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2512
2513 * window.h (struct window): Change type of 'use_time' and
2514 'sequence_number' from Lisp_Object to int.
2515 * frame.c (make_frame): Adjust users accordingly.
2516 * print.c (print_object): Likewise.
2517 * window.c (select_window, Fwindow_use_time, make_parent_window)
2518 (make_window): Likewise.
2519
e509cfa6
DA
25202012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2521
2522 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2523 enabled with --enable-checking=[all,glyphs] configure option.
2524 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2525 adjust comments accordingly.
2526 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2527 undefined, adjust comments accordingly.
2528 * image.c: Likewise.
2529 * scroll.c: Likewise.
2530 * w32fns.c: Likewise.
2531 * w32term.c: Likewise.
2532 * xdisp.c: Likewise.
2533 * xfaces.c: Likewise.
2534 * xfns.c: Likewise.
2535 * xterm.c: Likewise.
2536
a54e2c05
DA
25372012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2538
2539 Generalize run-time debugging checks.
2540 * dispextern.h (XASSERTS): Remove.
2541 * fontset.c (xassert): Remove.
2542 Convert from xassert to eassert.
2543 * alloc.c: Convert from xassert to eassert.
2544 * bidi.c: Likewise.
2545 * dispnew.c: Likewise.
2546 * fns.c: Likewise.
2547 * fringe.c: Likewise.
2548 * ftfont.c: Likewise.
2549 * gtkutil.c: Likewise.
2550 * image.c: Likewise.
2551 * keyboard.c: Likewise.
2552 * menu.c: Likewise.
2553 * process.c: Likewise.
2554 * scroll.c: Likewise.
2555 * sound.c: Likewise.
2556 * term.c: Likewise.
2557 * w32console.c: Likewise.
2558 * w32fns.c: Likewise.
2559 * w32term.c: Likewise.
2560 * window.c: Likewise.
2561 * xdisp.c: Likewise.
2562 * xfaces.c: Likewise.
2563 * xfns.c: Likewise.
2564 * xselect.c: Likewise.
2565 * xterm.c: Likewise.
2566
1ec4b7b2
SM
25672012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2568
2569 * fns.c (maybe_resize_hash_table): Output message when growing the
2570 purify-hashtable.
2571
2014308a
DA
25722012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2573
2574 * alloc.c (allocate_string_data): Remove dead code.
2575 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2576 avoid GCC warning about unused macro.
2577
246155eb
DA
25782012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2579
2580 * alloc.c (allocate_string): Omit intervals initialization.
2581 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2582 as in make_pure_string and make_pure_c_string.
2583
43184b7b
DA
25842012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2585
d209e2fb 2586 * alloc.c (allocate_string): Fix last change.
43184b7b 2587
3fe6dd74
DA
25882012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2589
d209e2fb 2590 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2591 to memset, add explicit initialization where appropriate.
2592
1ba6038a
GM
25932012-06-27 Glenn Morris <rgm@gnu.org>
2594
2595 * lisp.mk (lisp): Remove paths.elc.
2596
c89926a5
CY
25972012-06-27 Chong Yidong <cyd@gnu.org>
2598
2599 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2600
ed6b3510
JW
26012012-06-26 John Wiegley <johnw@newartisans.com>
2602
1ec4b7b2 2603 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2604 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2605
ed6b3510
JW
2606 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2607 when building with Clang.
2608
8edd4a2b
SM
26092012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2610
2611 * eval.c (Fapply): Allow calling it with a single argument.
2612
f6f62d1b
EZ
26132012-06-26 Eli Zaretskii <eliz@gnu.org>
2614
2615 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2616 _stricmp and _strnicmp.
2617 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2618
62efea5e
DA
26192012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2620
2621 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2622 allocated window.
2623 (allocate_process): Likewise for new process.
8edd4a2b 2624 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2625 (allocate_frame): Likewise.
2626 * frame.c (make_frame): Omit redundant initialization.
2627 * window.c (make_parent_window): Use memset.
2628 (make_window): Omit redundant initialization.
2629 * process.c (make_process): Omit redundant initialization.
2630 * terminal.c (create_terminal): Likewise.
2631
42997f4d
DA
26322012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2633
2634 * term.c (delete_tty): Remove redundant call to memset.
2635
1130ecfc
DA
26362012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2637
2638 * alloc.c: Remove build_string.
2639 * lisp.h: Define build_string as static inline. This provides
2640 a better opportunity to optimize away calls to strlen when the
2641 function is called with compile-time constant argument.
2642 * image.c (imagemagick_error): Convert to build_string.
2643 * w32proc.c (sys_spawnve): Likewise.
2644 * xterm.c (x_term_init): Likewise.
2645
cf38a720
PE
26462012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2647
99027bdd
PE
2648 Use sprintf return value instead of invoking strlen on result.
2649 In the old days this wasn't portable, since some sprintf
2650 implementations returned char *. But they died out years ago and
2651 Emacs already assumes sprintf returns int.
2652 Similarly for float_to_string.
2653 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2654 * ccl.c (ccl_driver):
2655 * character.c (string_escape_byte8):
2656 * data.c (Fnumber_to_string):
2657 * doprnt.c (doprnt):
2658 * print.c (print_object):
2659 * xdisp.c (message_dolog):
2660 * xfns.c (syms_of_xfns):
2661 Use sprintf or float_to_string result to avoid need to call strlen.
2662 * data.c (Fnumber_to_string):
2663 Use make_unibyte_string, since the string must be ASCII.
2664 * lisp.h, print.c (float_to_string): Now returns int length.
2665 * term.c (produce_glyphless_glyph):
2666 Use sprintf result rather than recomputing it.
2667
cf38a720
PE
2668 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2669 * Makefile.in (ALL_CFLAGS):
2670 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2671 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2672
3511c784
DA
26732012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2674
0a08eb21 2675 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2676 strcasecmp if available.
2677 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2678
fb7da12e
AS
26792012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2680
2681 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2682 Avoid comma operator.
2683 * menu.c (push_submenu_start, push_submenu_end)
2684 (push_left_right_boundary, push_menu_pane): Likewise.
2685 * msdos.c (dos_rawgetc): Likewise.
2686
afa2ffd8
DA
26872012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2688
2689 * xfns.c (xic_create_fontsetname): Remove redundant calls
2690 to memset.
2691
b3b4476b
PE
26922012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2693
4495ff38
PE
2694 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2695 sprintf already null-terminates its output.
2696
b3b4476b
PE
2697 * xfns.c (x_window): Remove redundant cast.
2698
b00876c9
DA
26992012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2700
2701 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2702 `const char *' to `char *' to avoid compiler warning.
2703
d188e26b
PE
27042012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2705
885d1d74
PE
2706 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2707 instead of truncating it to 63 (admittedly a generous limit).
2708
d188e26b
PE
2709 * process.c: Fix spelling and caps in comments.
2710
e2f560b1
DN
27112012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2712
e86db54b 2713 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2714 * sysdep.c (setpgrp): Remove definition, not used in this file.
2715
7583a3a1
JB
27162012-06-24 Juanma Barranquero <lekktu@gmail.com>
2717
2718 * makefile.w32-in: Update dependencies.
2719
696056c2
EZ
27202012-06-24 Eli Zaretskii <eliz@gnu.org>
2721
2722 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2723 (SYSTIME_H): Add nt/inc/sys/time.h.
2724
2725 * systime.h [WINDOWSNT]: Include sys/time.h.
2726
2727 * s/ms-w32.h (struct timespec): Definition moved from
2728 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2729
845ca893
PE
27302012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2731
2732 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2733 * buffer.h (buffer_slot_type_mismatch):
2734 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2735 * eval.c (unwind_to_catch):
2736 * image.c (my_png_error, my_error_exit):
2737 * keyboard.c (quit_throw_to_read_char, user_error)
2738 (Fexit_recursive_edit, Fabort_recursive_edit):
2739 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2740 (wrong_type_argument, buffer_overflow, __executable_start)
2741 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2742 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2743 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2744 (fatal):
2745 (child_setup) [!DOS_NT]:
2746 * lread.c (end_of_file_error, invalid_syntax):
2747 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2748 * puresize.h (pure_write_error):
2749 * search.c (matcher_overflow):
2750 * sound.c (sound_perror, alsa_sound_perror):
2751 * sysdep.c, syssignal.h (croak):
2752 * term.c (maybe_fatal, vfatal):
2753 * textprop.c (text_read_only):
2754 * undo.c (user_error):
2755 * unexmacosx.c (unexec_error):
2756 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2757 Use _Noreturn rather than NO_RETURN.
2758 No need for separate decl merely because of _Noreturn.
2759 * sound.c (sound_warning, parse_sound):
2760 Remove unnecessary forward decls.
2761
f1dd8073
PE
27622012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2763
2764 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2765 * lisp.h (WAIT_READING_MAX): New macro.
2766 * dispnew.c (Fsleep_for, sit_for):
2767 * keyboard.c (kbd_buffer_get_event):
2768 * process.c (Faccept_process_output):
2769 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2770 This improves on the previous patch, which introduced a bug
2771 when time_t is unsigned and as wide as intmax_t.
2772 See <http://bugs.gnu.org/9000#51>.
2773
b82c1755
EZ
27742012-06-23 Eli Zaretskii <eliz@gnu.org>
2775
2776 * dispnew.c (sit_for, Fsleep_for):
2777 * keyboard.c (kbd_buffer_get_event):
2778 * process.c (Faccept_process_output): Avoid compiler warnings when
2779 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2780
ca300656
JB
27812012-06-23 Juanma Barranquero <lekktu@gmail.com>
2782
049ec95b
JB
2783 * makefile.w32-in: Update dependencies.
2784
ca300656
JB
2785 * w32.c (ltime): Add return type and declare static.
2786 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2787
db7b8d06
PE
27882012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2789
2790 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2791 Privately reported by Herbert J. Skuhra.
2792 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2793 All uses changed.
2794 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2795 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2796
0bd8297f
EZ
27972012-06-23 Eli Zaretskii <eliz@gnu.org>
2798
96512555
EZ
2799 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2800 last argument of make_unibyte_string.
2801
0bd8297f
EZ
2802 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2803 language ID in the event parameters.
2804
2805 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2806 event.code, not the obscure "character set ID".
2807
63def6b6
CY
28082012-06-23 Chong Yidong <cyd@gnu.org>
2809
2810 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2811
e8a02204
EZ
28122012-06-23 Eli Zaretskii <eliz@gnu.org>
2813
388cdec0
EZ
2814 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2815 * w32.c (fdutimens): New function.
2816
2817 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2818
2819 * s/ms-w32.h (pselect): Redirect to sys_select.
2820
2821 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2822
e8a02204
EZ
2823 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2824 in the logic of incrementing and decrementing the value of
2825 use_relocatable_buffers.
2826
d054f3fb
PE
28272012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2828
2829 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2830 Privately reported by Herbert J. Skuhra.
2831 [__FreeBSD__]: Remove "*/" typo after "#include".
2832 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2833 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2834 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2835 Don't assume EMACS_TIME and struct timeval are the same type.
2836
d35af63c
PE
28372012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2838
2839 Support higher-resolution time stamps (Bug#9000).
2840 The time stamps are only nanosecond-resolution at the C level,
2841 since that's the best that any real-world system supports now.
2842 But they are picosecond-resolution at the Lisp level, as that's
2843 easy, and leaves room for future OS improvements.
2844
2845 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2846 (LIBES): Use it.
2847
2848 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2849 Don't get current time unless it's needed.
2850
2851 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2852 now provides it if it's absent.
2853 (start_atimer): Port to higher-res time stamps.
2854 Check for time stamp overflow. Don't get current time more
2855 often than is needed.
2856
2857 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2858 Include systime.h, not time.h.
2859 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2860
2861 * dired.c: Include stat-time.h.
2862 (Ffile-attributes): File times now have higher resolution.
2863
2864 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2865 (struct image): Timestamp now has higher resolution.
2866
2867 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2868 has at least microseconds now. All uses removed.
2869 (update_frame, update_single_window, update_window, update_frame_1)
2870 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2871
2872 * editfns.c (time_overflow): Now extern.
2873 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2874 (float-time, Fformat_time_string, Fcurrent_time_string)
2875 (Fcurrent_time_zone): Accept and generate higher-resolution
2876 time stamps.
2877 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2878 (decode_time_components, lisp_seconds_argument): New functions.
2879 (make_time): Now static.
2880 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2881 Report an error if the time is invalid, rather than having the caller
2882 do that.
2883
2884 * fileio.c: Include <stat-time.h>
2885 (Fcopy_file): Copy higher-resolution time stamps.
2886 Prefer to set the time stamp via a file descriptor if that works.
2887 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2888 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2889 (Fvisited_file_modtime, Fset_visited_file_modtime):
2890 Support higher-resolution time stamps.
2891
2892 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2893
2894 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2895
2896 * image.c (prepare_image_for_display, clear_image_cache)
2897 (lookup_image): Port to higer-resolution time stamps.
2898
2899 * keyboard.c (start_polling, bind_polling_period):
2900 Check for time stamp overflow.
2901 (read_char, kbd_buffer_get_event, timer_start_idle)
2902 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2903 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2904 Port to higher-resolution time stamps. Do not assume time_t is signed.
2905 (decode_timer): New function. Timers are now vectors of length 9,
2906 not 8, to accommodate the picosecond component.
2907 (timer_check_2): Use it.
2908
2909 * nsterm.m (select_timeout, timeval_subtract): Remove.
2910 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2911 as they're a bit more accurate and handle overflow better.
2912 (ns_select): Change prototype to be compatible with pselect.
2913 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2914 * nsterm.h (ns_select): Adjust prototype.
2915
2916 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2917 us-resolution time stamps.
2918 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2919
2920 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2921
2922 * lisp.h (time_overflow): New decl.
2923 (wait_reading_process_output): First arg is now intmax_t, not int,
2924 to accommodate larger waits.
2925
2926 * process.h (struct Lisp_Process.read_output_delay):
2927 Now counts nanoseconds, not microseconds.
2928 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2929 EMACS_HAS_USECS.
2930 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2931 (wait_reading_process_output):
2932 Port to ns-resolution time stamps.
2933 (Faccept_process_output, wait_reading_process_output):
2934 Check for time stamp overflow. Do not assume time_t is signed.
2935 (select_wrapper): Remove; we now use pselect.
2936 (Fprocess_attributes): Now generates ns-resolution time stamps.
2937
2938 * sysdep.c: Include utimens.h. Don't include utime.h
2939 or worry about struct utimbuf; gnulib does that for us now.
2940 (gettimeofday): Remove; gnulib provides a substitute.
2941 (make_timeval): New function.
2942 (set_file_times): Now sets ns-resolution time stamps.
2943 New arg FD; all uses changed.
2944 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2945 (system_process_attributes):
2946 Now returns ns-resolution time stamp. All uses changed.
2947 Check for time stamp overflow.
2948
2949 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2950 provides a substitute now.
2951
2952 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2953 since it guarantees struct timespec.
2954 (EMACS_TIME): Now struct timespec, so that we can support
2955 ns-resolution time stamps.
2956 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2957 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2958 (EMACS_USECS): Remove.
2959 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2960 so multiply the arg by 1000 before storing it.
2961 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2962 New macros.
2963 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2964 Port to ns-resolution time stamps.
2965 (EMACS_TIME_NEG_P): Remove; replaced by....
2966 (EMACS_TIME_SIGN): New macro.
2967 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2968 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2969 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2970 (make_timeval, make_lisp_time, decode_time_components): New decls.
2971 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2972 that it mishandled time_t overflow. You can't compare by subtracting!
2973 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2974 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2975
2976 * term.c: Include <sys/time.h>.
2977 (timeval_to_Time): New function, for proper overflow wraparound.
2978 (term_mouse_position, term_mouse_click): Use it.
2979
2980 * undo.c (record_first_change): Support higher-resolution time stamps
2981 in the undo buffer.
2982 (Fprimitive_undo): Use them when restoring time stamps.
2983
2984 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2985 (w32_get_internal_run_time):
2986 Port to higher-resolution Emacs time stamps.
2987 (ltime): Now accepts single 64-bit integer, as that's more convenient
2988 for callers.
2989
2990 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2991
2992 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2993 for compatibility with pselect. Support ns-resolution time stamps.
2994
2995 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2996
2997 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2998 Check for time stamp overflow, and support ns-resolution time stamps.
2999
3000 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3001 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3002 (timeval_subtract): Remove; no longer needed.
3003 (XTflash, XTring_bell, x_wait_for_event):
3004 Port to ns-resolution time stamps. Don't assume time_t is signed.
3005
b6a92dfe
CY
30062012-06-22 Chong Yidong <cyd@gnu.org>
3007
3008 * xdisp.c (x_consider_frame_title): Revert last change.
3009
d251c37c
EZ
30102012-06-22 Eli Zaretskii <eliz@gnu.org>
3011
3012 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3013 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3014 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3015 staticidx goes up to 1597 out of 1600 = 0x640.)
3016
f10deafb
PE
30172012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3018
3019 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3020 Otherwise, the umask might be mistakenly 0 while handling input signals.
3021
ec6de1e2
SM
30222012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3023
3024 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3025
28be1ada
DA
30262012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3027
3028 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3029 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3030 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3031 access to `contents' member of Lisp_Vector objects with AREF and ASET
3032 where appropriate.
3033
c6bf3022
CY
30342012-06-19 Chong Yidong <cyd@gnu.org>
3035
3036 * frame.c (delete_frame): When selecting a frame on a different
3037 text terminal, do not alter the terminal's top-frame.
3038
3039 * xdisp.c (format_mode_line_unwind_data): Record the target
3040 frame's selected window and its terminal's top-frame.
3041 (unwind_format_mode_line): Restore them.
3042 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3043 Callers changed.
3044 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3045 since tty frames can be explicitly named.
3046 (prepare_menu_bars): Likewise.
3047
3048 * term.c (Ftty_top_frame): New function.
3049
defd4196
PE
30502012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3051
3052 Port byte-code-meter to modern targets.
3053 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3054 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3055 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3056 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3057 (METER_1, METER_2): Simplify.
3058
1053a871
SM
30592012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3060
3061 * data.c (Fdefalias): Return `symbol' (bug#11686).
3062
b7e8d081
MR
30632012-06-18 Martin Rudalics <rudalics@gmx.at>
3064
3065 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3066 gets killed during executing of this function (Bug#11665).
3067 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3068 (Vkill_buffer_query_functions): In doc-string say that functions
3069 run by this hook should not change the current buffer.
3070
7ea2b339
PE
30712012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3072
3073 Fix recently-introduced process.c problems found by static checking.
3074 * process.c (write_queue_push, write_queue_pop, send_process):
3075 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3076 (write_queue_pop): Fix pointer signedness problem.
3077 (send_process): Remove unused local.
3078
96a313a1
CY
30792012-06-17 Chong Yidong <cyd@gnu.org>
3080
3081 * xdisp.c (redisplay_internal): No need to redisplay terminal
3082 frames that are not on top.
3083
20ca2e94
TN
30842012-06-17 Troels Nielsen <bn.troels@gmail.com>
3085
3086 * process.c (make_process): Initialize write_queue.
3087 (write_queue_push, write_queue_pop): New functions.
3088 (send_process): Use them to maintain correct ordering of process
3089 writes (Bug#10815).
3090
9a900ca9
PE
30912012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3092
310fbfa8
PE
3093 * lisp.h (eassert): Assume C89 or later.
3094 This removes the need for CHECK.
3095 (CHECK): Remove. Its comments about always evaluating its
3096 argument were confusing, as 'eassert' typically does not evaluate
3097 its argument.
3098
27bb1ca4
PE
3099 * coding.c (produce_chars): Use ptrdiff_t, not int.
3100
9a900ca9
PE
3101 * xterm.c (x_draw_underwave): Check for integer overflow.
3102 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3103
41b7f8bc 31042012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3105
3106 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3107 referenced (Bug#11583).
3108
9b0e3eba
AA
31092012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3110
3111 Implement wave-style variant of underlining.
3112 * dispextern.h (face_underline_type): New enum.
3113 (face): Add field for underline type.
3114 * nsterm.m (ns_draw_underwave): New function.
3115 (ns_draw_text_decoration): Use it.
3116 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3117 New functions.
3118 (x_draw_glyph_string): Use them.
3119 * xfaces.c (Qline, Qwave): New Lisp objects.
3120 (check_lface_attrs, merge_face_ref)
1053a871
SM
3121 (Finternal_set_lisp_face_attribute, realize_x_face):
3122 Handle wave-style underline face attributes.
9b0e3eba
AA
3123 * xterm.c (x_draw_underwave): New function.
3124 (x_draw_glyph_string): Use it.
3125
0fb52f11
JB
31262012-06-16 Juanma Barranquero <lekktu@gmail.com>
3127
3128 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3129 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3130 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3131 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3132 ($(BLD)/w32select.$(O)): Update dependencies.
3133
e5560ff7
AS
31342012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3135
3136 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3137 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3138 * character.c (_fetch_multibyte_char_p): Remove.
3139 * alloc.c: Include "character.h" before "buffer.h".
3140 * bidi.c: Likewise.
3141 * buffer.c: Likewise.
3142 * bytecode.c: Likewise.
3143 * callint.c: Likewise.
3144 * callproc.c: Likewise.
3145 * casefiddle.c: Likewise.
3146 * casetab.c: Likewise.
3147 * category.c: Likewise.
3148 * cmds.c: Likewise.
3149 * coding.c: Likewise.
3150 * composite.c: Likewise.
3151 * dired.c: Likewise.
3152 * dispnew.c: Likewise.
3153 * doc.c: Likewise.
3154 * dosfns.c: Likewise.
3155 * editfns.c: Likewise.
3156 * emacs.c: Likewise.
3157 * fileio.c: Likewise.
3158 * filelock.c: Likewise.
3159 * font.c: Likewise.
3160 * fontset.c: Likewise.
3161 * fringe.c: Likewise.
3162 * indent.c: Likewise.
3163 * insdel.c: Likewise.
3164 * intervals.c: Likewise.
3165 * keyboard.c: Likewise.
3166 * keymap.c: Likewise.
3167 * lread.c: Likewise.
3168 * macros.c: Likewise.
3169 * marker.c: Likewise.
3170 * minibuf.c: Likewise.
3171 * nsfns.m: Likewise.
3172 * nsmenu.m: Likewise.
3173 * print.c: Likewise.
3174 * process.c: Likewise.
3175 * regex.c: Likewise.
3176 * region-cache.c: Likewise.
3177 * search.c: Likewise.
3178 * syntax.c: Likewise.
3179 * term.c: Likewise.
3180 * textprop.c: Likewise.
3181 * undo.c: Likewise.
3182 * unexsol.c: Likewise.
3183 * w16select.c: Likewise.
3184 * w32fns.c: Likewise.
3185 * w32menu.c: Likewise.
3186 * window.c: Likewise.
3187 * xdisp.c: Likewise.
3188 * xfns.c: Likewise.
3189 * xmenu.c: Likewise.
3190 * xml.c: Likewise.
3191 * xselect.c: Likewise.
3192
2f07e6af
EZ
31932012-06-16 Eli Zaretskii <eliz@gnu.org>
3194
1053a871
SM
3195 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3196 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3197 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3198 row.
3199 (handle_face_prop): Use chunk-relative overlay string index when
3200 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3201 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3202 the rightmost. (Bug#11720)
2f07e6af 3203
29b83cec
AS
32042012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3205
3206 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3207 (CATEGORY_MEMBER): Enforce 1/0 value.
3208 * category.c (_temp_category_set): Remove.
3209
4c5501e9
EZ
32102012-06-16 Eli Zaretskii <eliz@gnu.org>
3211
3212 * window.c (Fdelete_other_windows_internal)
3213 (Fdelete_window_internal): Don't access frame's mouse highlight
3214 info of the initial frame. (Bug#11677)
3215
2b570124
PE
32162012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3217
e93864f9
PE
3218 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3219 Assume USE_2_TAGS_FOR_INTS.
3220 (xreload): Adjust $tagmask width to match recent lisp.h change.
3221
2b570124
PE
3222 Simplify lisp.h in minor ways that should not affect code.
3223 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3224 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3225 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3226 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3227 (INTTYPEBITS): New macro, for clarity.
3228 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3229 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3230 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3231 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3232 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3233
81755f69
JB
32342012-06-13 Juanma Barranquero <lekktu@gmail.com>
3235
3236 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3237
16192a57
GM
32382012-06-13 Glenn Morris <rgm@gnu.org>
3239
3240 * s/bsd-common.h (BSD4_3):
3241 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3242
646b5f55
AS
32432012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3244
3245 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3246 instead of union.
3247 (XLI, XIL): Define.
1053a871
SM
3248 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3249 Use them.
3250 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3251 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3252 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3253 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3254 * frame.c (delete_frame): Remove outdated comment.
3255 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3256 USE_LISP_UNION_TYPE.
3257 (Fw32_unregister_hot_key): Likewise.
3258 (Fw32_toggle_lock_key): Likewise.
3259 * w32menu.c (add_menu_item): Likewise.
3260 (w32_menu_display_help): Use XIL instead of checking
3261 USE_LISP_UNION_TYPE.
3262 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3263 (init_heap): Likewise.
3264 * w32term.c (w32_read_socket): Update comment.
3265
1d3823c9
GM
32662012-06-13 Glenn Morris <rgm@gnu.org>
3267
c62ff706
GM
3268 * s/usg5-4-common.h, src/s/unixware.h:
3269 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3270
1d3823c9
GM
3271 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3272
bfe3e0a2
PE
32732012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3274
3275 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3276 * alloc.c (make_number) [!defined make_number]:
3277 Remove, as lisp.h always defines this now.
3278 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3279 (roundup_size): Verify that it is a power of 2.
3280 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3281 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3282 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3283 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3284 USE_LSB_TAG now is always defined to be either 0 or 1.
3285 All uses changed.
3286 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3287 code works fine either way, and efficiency is not a concern here,
3288 as the union type is for debugging, not for production.
3289 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3290 Use an inline function on all platforms when using the union type,
3291 since this is simpler and 'static inline' can be used portably
3292 within Emacs now.
3293 (LISP_INITIALLY_ZERO): New macro.
3294 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3295 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3296
45fa9c0f
GM
32972012-06-12 Glenn Morris <rgm@gnu.org>
3298
b4492cba
GM
3299 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3300
3301 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3302
45fa9c0f
GM
3303 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3304 Move BROKEN_SIGIO to configure.
3305
3306 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3307 Move NO_TERMIO to configure.
3308
0e25d334
CY
33092012-06-12 Chong Yidong <cyd@gnu.org>
3310
3311 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3312 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3313 MagickExportImagePixels is undefined.
3314
43682bb6
PE
33152012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3316
3317 * image.c (imagemagick_load_image): Remove unused label.
3318
a9be7d2b
GM
33192012-06-11 Glenn Morris <rgm@gnu.org>
3320
3321 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3322 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3323 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3324 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3325
3017f87f
SM
33262012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3327
3328 * alloc.c (make_byte_code): New function.
3329 (Fmake_byte_code): Use it. Don't purify here.
3330 * lread.c (read1): Use it as well to avoid extra allocation.
3331
1b9b4cf4
CY
33322012-06-11 Chong Yidong <cyd@gnu.org>
3333
3334 * image.c (imagemagick_load_image): Implement transparency.
3335
95988fcf
AS
33362012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3337
3338 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3339 account for preceding backslashes. (Bug#11663)
3340
cd4eb164
CY
33412012-06-09 Chong Yidong <cyd@gnu.org>
3342
3343 * term.c: Support italics in capable terminals (Bug#9652).
3344 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3345 (turn_on_face): Output using TS_enter_italic_mode if available.
3346 Don't handle unused blinking and alt-charset cases.
3347 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3348 and tty_alt_charset_p cases.
3349 (tty_capable_p, init_tty): Support italics.
3350
3351 * termchar.h (struct tty_display_info): Add field for italics.
3352 Remove unused blink field.
3353
3354 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3355 Handle slant.
3356
3357 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3358 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3359 tty_alt_charset_p. Add tty_italic_p.
3360
ff88beb8
MA
33612012-06-09 Michael Albinus <michael.albinus@gmx.de>
3362
3363 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3364 dbus_type_is_basic if available.
3365 (xd_extract_signed, xd_extract_unsigned): Rename from
3366 extract_signed and extract_unsigned, respectively. Adapt callers.
3367
44286096
CY
33682012-06-09 Chong Yidong <cyd@gnu.org>
3369
1682701f
CY
3370 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3371
44286096
CY
3372 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3373 case (Bug#9752).
3374
d86feb17
PE
33752012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3376
3377 * xdisp.c (vmessage): Treat frame message as multibyte.
3378 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3379 would generate the diagnostic "Making \302\247 buffer-local while
3380 let-bound!".
3381
d5c20fe8
EZ
33822012-06-08 Eli Zaretskii <eliz@gnu.org>
3383
3384 * dispnew.c (showing_window_margins_p): Undo last change, which
3385 was done due to an inadvertent commit.
3386 (adjust_frame_glyphs_for_frame_redisplay): Do call
3387 showing_window_margins_p.
3388
513749ee
SM
33892012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3390
3391 * eval.c (Fmake_var_non_special): New primitive.
3392 (syms_of_eval): Defsubr it.
3393 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3394
d4a8f5c1
JB
33952012-06-08 Juanma Barranquero <lekktu@gmail.com>
3396
3397 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3398 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3399
8bbbc977
EZ
34002012-06-08 Eli Zaretskii <eliz@gnu.org>
3401
3402 * alloc.c (allocate_vectorlike): Fix last change.
3403
f3372c87
DA
34042012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3405
3406 Block-based vector allocation of small vectors.
3407 * lisp.h (struct vectorlike_header): New field `nbytes',
3408 adjust comment accordingly.
3409 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3410 to denote vector blocks. Adjust users (live_vector_p,
3411 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3412 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3413 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3414 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3415 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3416 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3417 (roundup_size): New constant.
3418 (struct vector_block): New data type.
3419 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3420 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3421 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3422 (sweep_vectors): New functions.
3423 (allocate_vectorlike): Return `zero_vector' as the only vector of
3424 0 items. Allocate new vector from block if vector size is less than
3425 or equal to VBLOCK_BYTES_MAX.
3426 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3427 (init_alloc_once): Add call to init_vectors.
3428
4f18a4ed
SM
34292012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3430
3431 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3432
86f158bc
PE
34332012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3434
3435 * doprnt.c (doprnt): Truncate multibyte char correctly.
3436 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3437 would mishandle a string argument "Xc" if X was a multibyte
3438 character of length 2: it would truncate after X's first byte
3439 rather than including all of X.
3440
c5cfcbe0
CY
34412012-06-06 Chong Yidong <cyd@gnu.org>
3442
3443 * buffer.c (word_wrap): Doc fix.
3444
c05cf390
PE
34452012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3446
3447 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3448
0c3461de
GM
34492012-06-03 Glenn Morris <rgm@gnu.org>
3450
3451 * xdisp.c (tool-bar-style): Doc fix.
3452
c71232db
UM
34532012-06-03 Ulrich Müller <ulm@gentoo.org>
3454
3455 * Makefile.in (PAXCTL): Define.
3456 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3457 binary via PaX flags if the paxctl utility is available.
3458 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3459 Restore PaX flags to their default. (Bug#11398)
3460
383f7350
CY
34612012-06-03 Chong Yidong <cyd@gnu.org>
3462
3463 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3464 buffer (Bug#11226).
3465
5f2c76c6
CY
34662012-06-03 Chong Yidong <cyd@gnu.org>
3467
3468 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3469 (note_mode_line_or_margin_highlight): If there is no help echo,
3470 use mode-line-default-help-echo. Handle the case where the mouse
3471 position is past the end of the mode line string.
3472
3473 * buffer.c (buffer_local_value_1): New function, split from
3474 Fbuffer_local_value; can return Qunbound.
3475 (Fbuffer_local_value): Use it.
3476 (Vmode_line_format): Docstring tweaks.
3477
773d47f6
PE
34782012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3479
3480 * sysdep.c (system_process_attributes): Improve comment.
3481
f2d6a3df
SM
34822012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3483
3484 * keyboard.c: Export real-this-command to Elisp.
3485 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3486 and DEFVAR it. Update all users.
3487
63810350
PE
34882012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3489
7bd5c1f4
PE
3490 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3491
63810350
PE
3492 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3493 Convert pctcpu and pctmem to Lisp float properly.
3494 Let the compiler fold better, as 100.0/0x8000 is exact.
3495
a2821611
AS
34962012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3497
3498 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3499 cons_block.
3500
5fceba1d
PE
35012012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3502
3503 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3504
c98ff5dd
DA
35052012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3506
3507 For a 'struct window', replace some Lisp_Object fields to
3508 bitfields where appropriate, remove unused fields.
3509 * window.h (struct window): Remove unused 'last_mark_x' and
3510 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3511 change it's type from Lisp_Object to bitfield.
3512 Change type of 'force_start', 'optional_new_start',
3513 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3514 fields from Lisp_Object to bitfield. Adjust users accordingly.
3515
ca34e0be
PE
35162012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3517
3518 Pacify gcc -Wdouble-precision when using Xaw.
3519 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3520 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3521 Use 'float' consistently, rather than 'float' in most places
3522 and 'double' in a couple of places.
3523
efc00ab1 35242012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3525
3526 * xdisp.c (handle_stop): Detect whether we have overlay strings
3527 loaded by testing it->current.overlay_string_index to be
3528 non-negative, instead of checking whether n_overlay_strings is
3529 positive. (Bug#11587)
3530
efc00ab1 35312012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3532
3533 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3534
3535 * doc.c (Fsubstitute_command_keys): Doc fix.
3536
efc00ab1 35372012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3538
3539 * search.c (search_buffer): Remove calls to
3540 r_alloc_inhibit_buffer_relocation, as it is now called by
3541 maybe_unify_char, which was the cause of relocation of buffer text
3542 in bug#11519.
3543
efc00ab1 35442012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3545
3546 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3547 for the duration of call to load_charset, to avoid problems with
3548 callers of maybe_unify_char that access buffer text through C
3549 pointers.
3550
3551 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3552 decrement the inhibition flag, instead of just setting or
3553 resetting it.
3554
ba93a187
PE
35552012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3556
3557 Remove obsolete '#define static' cruft.
3558 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3559 This #undef was "temporary" in 2000; it is no longer needed
3560 now that '#define static' has gone away.
3561 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3562 (gray_bitmap_bits): Remove; no longer needed.
3563 All uses replaced with definiens.
3564 * xterm.c: Include "bitmaps/gray.xbm".
3565
9e4bf381
PE
35662012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3567
3568 Clean up __executable_start, monstartup when --enable-profiling.
3569 The following changes affect the code only when profiling.
3570 * dispnew.c (__executable_start): Rename from safe_bcopy.
3571 Define only on platforms that need it.
3572 * emacs.c: Include <sys/gmon.h> when profiling.
3573 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3574 (__executable_start): Remove decl, since lisp.h does it now.
3575 (safe_bcopy): Remove decl; no longer has that name.
3576 (main): Coalesce #if into single bit of code, for simplicity.
3577 Cast pointers to uintptr_t, since standard libraries want integers
3578 and not pointers.
3579 * lisp.h (__executable_start): New decl.
3580
32d72c2f
GM
35812012-05-31 Glenn Morris <rgm@gnu.org>
3582
3583 * image.c (Fimagemagick_types): Doc fix.
3584
baac5bc7
JM
35852012-05-30 Jim Meyering <meyering@redhat.com>
3586
3587 * callproc.c (Fcall_process_region): Include directory component
3588 in mkstemp error message (Bug#11586).
3589
72cb32cf
PE
35902012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3591
3592 * alloc.c, lisp.h (make_pure_vector): Now static.
3593
61b108cc
SM
35942012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3595
3596 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3597 Move to byte-run.el.
3598 (Fautoload): Do the hash-doc more carefully.
3599 * data.c (Fdefalias): Purify definition, except for keymaps.
3600 (Qdefun): Move from eval.c.
3601 * lisp.h (Qdefun): Remove.
3602 * lread.c (read1): Tiny simplification.
3603
471fe23d
TN
36042012-05-29 Troels Nielsen <bn.troels@gmail.com>
3605
934f3f58 3606 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3607 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3608 Bug#9642, but explicitly check that the buffer the overlay would
3609 be moved to is live and rearrange lines to make sure that errors
3610 will not put the overlay in an inconsistent state.
3611 (Fdelete_overlay): Cosmetics.
3612
85d0efd1
EZ
36132012-05-28 Eli Zaretskii <eliz@gnu.org>
3614
3615 * w32term.c (my_bring_window_to_top): New function.
3616 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3617 could be different from the original one.
3618 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3619 (Bug#11513)
3620
3621 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3622 by calling BringWindowToTop.
3623
3624 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3625 (WM_EMACS_END): Increase by one.
3626
da92a98c
PE
36272012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3628
3629 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3630 This avoids undefined behavior that might cause the eassert
3631 to not catch an out-of-range value.
3632
74d1f848
JB
36332012-05-28 Juanma Barranquero <lekktu@gmail.com>
3634
3635 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3636 Update dependencies.
3637
9e1a06fc
EZ
36382012-05-27 Eli Zaretskii <eliz@gnu.org>
3639
3640 * bidi.c (bidi_mirror_char): Fix last change.
3641
f3dd7312
AS
36422012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3643
3644 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3645 when referring to sectname field in printf format.
3646
81899c91
PE
36472012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3648
57b81a9f
PE
3649 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3650 Only r_alloc_inhibit_buffer_relocation needed to be added;
3651 the others were already declared.
3652
81899c91
PE
3653 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3654 before checking whether it's out of range. Put the check inside
3655 eassert. See
3656 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3657
33017faf 36582012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3659
3660 * callproc.c (Fcall_process): Restore a line that was accidentally
3661 commented out in the 2011-02-13 change (bug#11547).
3662
33017faf 36632012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3664
3665 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3666 defined on ralloc.c.
3667
3668 * buffer.c [REL_ALLOC]: Remove prototypes of
3669 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3670 they are now on lisp.h.
3671
3672 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3673
3674 * search.c (search_buffer): Use it to inhibit relocation of buffer
3675 text while re_search_2 is doing its job, because re_search_2 is
3676 passed C pointers to buffer text. (Bug#11519)
3677
23415acf
EZ
3678 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3679 Update value to 24.
3680
44e27368
EZ
3681 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3682 state after an additional call to move_it_in_display_line_to, keep
3683 the values of it->max_ascent and it->max_descent found for the
3684 entire line.
3685 (pos_visible_p): Revert the comparison against bottom_y to what it
3686 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3687 (Bug#11464)
3688
c1892f11
PE
36892012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3690
3691 Fix coding-related core dumps with gcc -ftrapv.
3692 The code was computing A - B, where A and B are pointers, and B is
3693 random garbage. This can lead to core dumps on platforms that
3694 have special pointer registers, and it also leads to core dumps on
3695 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3696 A - B only when B is initialized properly.
3697 * coding.c (coding_set_source, coding_set_destination): Return void.
3698 (coding_change_source, coding_change_destinations): New functions,
3699 with the old behaviors of coding_set_source and coding_set_destination.
3700 All callers that need an offset changed to use these new functions.
3701
eb7afdad
GM
37022012-05-26 Glenn Morris <rgm@gnu.org>
3703
3704 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3705
f12fdf02
EZ
37062012-05-26 Eli Zaretskii <eliz@gnu.org>
3707
53a63be6 3708 Extend mouse support on W32 text-mode console.
61b108cc
SM
3709 * xdisp.c (draw_row_with_mouse_face):
3710 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3711
eb3f6f01 3712 * w32console.c: Include window.h.
61b108cc
SM
3713 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3714 New functions.
eb3f6f01
EZ
3715 (initialize_w32_display): Initialize mouse-highlight data.
3716
53a63be6
EZ
3717 * w32inevt.c: Include termchar.h and window.h.
3718 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3719 moves, call note_mouse_highlight. If help_echo changed, call
3720 gen_help_event to produce help-echo message in the echo area.
3721 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3722 highlight info.
3723
4cfd81f6
PE
37242012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3725
3726 * lread.c (read1): Simplify slightly to avoid an overflow warning
3727 with GCC 4.7.0 on x86-64.
3728
4446092a
EZ
37292012-05-26 Eli Zaretskii <eliz@gnu.org>
3730
3731 * bidi.c (bidi_mirror_char): Revert last change: an int is
3732 definitely wide enough here.
3733
42b2a986 37342012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3735
42b2a986 3736 Fix integer width and related bugs (Bug#9874).
eb106a49 3737 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3738 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3739 (string_bytes, check_sblock, allocate_string_data):
3740 (compact_small_strings, Fmake_bool_vector, make_string)
3741 (make_unibyte_string, make_multibyte_string)
3742 (make_string_from_bytes, make_specified_string)
3743 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3744 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3745 (mark_vectorlike):
3746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3747 (allocate_pseudovector):
3748 Use int, not EMACS_INT, where int is wide enough.
3749 (inhibit_garbage_collection, Fgarbage_collect):
3750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3751 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3752 int might not be wide enough.
3753 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3754 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3755 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3756 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3757 (bidi_level_of_next_char, bidi_move_to_visually_next):
3758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3759 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3760 (Fkill_buffer, Fset_buffer_major_mode)
3761 (advance_to_char_boundary, Fbuffer_swap_text)
3762 (Fset_buffer_multibyte, overlays_at, overlays_in)
3763 (overlay_touches_p, struct sortvec, record_overlay_string)
3764 (overlay_strings, recenter_overlay_lists)
3765 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3766 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3767 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3768 (Foverlay_recenter, last_overlay_modification_hooks_used)
3769 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3770 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3771 (validate_region): Omit unnecessary test for b <= e,
3772 since that's guaranteed by the previous test.
d311d28c
PE
3773 (adjust_overlays_for_delete): Avoid pos + length overflow.
3774 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3775 (report_overlay_modification):
3776 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3777 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3778 Omit pointer cast, which isn't needed anyway, and doesn't work
3779 after the EMACS_INT -> ptrdiff_t change.
02481186 3780 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3781 * buffer.h: Adjust decls to match defn changes elsewhere.
3782 (struct buffer_text, struct buffer):
3783 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3784 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3785 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3786 not int, to avoid needless 32-bit limit on 64-bit hosts.
3787 (exec_byte_code): Use tighter memory-full test, one that checks
3788 for alloca overflow. Don't compute the address of the object just
3789 before an array, as that's not portable. Use EMACS_INT, not
3790 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3791 * callint.c (Fcall_interactively):
3792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3793 * callproc.c (call_process_kill, Fcall_process):
3794 Don't assume pid_t fits into an Emacs fixnum.
3795 (call_process_cleanup, Fcall_process, child_setup):
3796 Don't assume pid_t fits into int.
3797 (call_process_cleanup, Fcall_process, delete_temp_file)
3798 (Fcall_process_region):
3799 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3800 (Fcall_process): Simplify handling of volatile integers.
3801 Use int, not EMACS_INT, where int will do.
3802 * casefiddle.c (casify_object, casify_region, operate_on_word)
3803 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3805 (casify_object): Avoid integer overflow when overallocating buffer.
3806 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3807 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3808 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3809 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3810 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3811 integers are now checked earlier. All uses replaced with XINT.
3812 (ccl_driver):
3813 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3814 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3815 (ccl_driver, Fregister_code_conversion_map):
3816 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3817 (resolve_symbol_ccl_program): Check that vector header is in range.
3818 Always copy the vector, so that we can check its contents reliably
3819 now rather than having to recheck each instruction as it's being
3820 executed. Check that vector words fit in 'int'.
3821 (ccl_get_compiled_code, Fregister_ccl_program)
3822 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3823 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3824 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3825 contents are in range.
3826 (Fccl_execute_on_string): Check that status is in range.
3827 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3828 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3829 Accept and return EMACS_INT, not int, because callers can pass values
3830 out of 'int' range.
3831 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3832 (multibyte_chars_in_text, parse_str_as_multibyte)
3833 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3834 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3835 (string_escape_byte8, Fget_byte):
3836 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3837 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3838 avoid mishandling large integers.
3839 * character.h: Adjust decls to match defn changes elsewhere.
3840 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3841 (Ffind_charset_region):
3842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3843 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3844 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3845 Don't assume fixnum fits in int.
d311d28c
PE
3846 (load_charset_map_from_vector, Fmap_charset_chars):
3847 Remove now-unnecessary CHECK_NATNUMs.
3848 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3849 Don't rely on undefined behavior with signed left shift overflow.
3850 Don't assume unsigned int fits into fixnum, or that fixnum fits
3851 into unsigned int. Don't require max_code to be a valid fixnum;
3852 that's not true for gb10830 4-byte on a 32-bit host. Allow
3853 invalid_code to be a cons, for the same reason. Require code_offset
3854 to be a character. Avoid int overflow if max_char is close
3855 to INT_MAX.
3856 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3857 this is intended anyway and avoids some undefined behavior.
3858 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3859 INDEX_TO_CODE_POINT, as that's what it expects.
3860 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3861 * charset.h (DECODE_CHAR): Return int, not unsigned;
3862 this is what was intended anyway, and it avoids undefined behavior.
3863 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3864 integer-overflow issues.
3865 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3866 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3867 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3868 * chartab.c (Fmake_char_table, Fset_char_table_range)
3869 (uniprop_get_decoder, uniprop_get_encoder):
3870 Don't assume fixnum fits in int.
3871 * cmds.c (move_point): New function, that does the gist of
3872 Fforward_char and Fbackward_char, but does so while checking
3873 for integer overflow more accurately.
c96e5d6a 3874 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3875 (Fforward_line, Fend_of_line, internal_self_insert)
3876 (internal_self_insert):
3877 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3878 Fix a FIXME, by checking for integer overflow when calculating
3879 target_clm and actual_clm.
3880 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3881 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3882 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3883 (coding_alloc_by_making_gap, alloc_destination)
3884 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3885 (encode_coding_utf_16, detect_coding_emacs_mule)
3886 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3887 (detect_coding_iso_2022, decode_coding_iso_2022)
3888 (encode_invocation_designation, encode_designation_at_bol)
3889 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3890 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3891 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3892 (encode_coding_ccl, encode_coding_raw_text)
3893 (detect_coding_charset, decode_coding_charset)
3894 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3895 (produce_composition, produce_charset, produce_annotation)
3896 (decode_coding, handle_composition_annotation)
3897 (handle_charset_annotation, consume_chars, decode_coding_gap)
3898 (decode_coding_object, encode_coding_object, detect_coding_system)
3899 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3900 (code_convert_region, code_convert_string)
8f50130c
PE
3901 (Fdefine_coding_system_internal)
3902 (coding_set_source, coding_set_destination):
d311d28c
PE
3903 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3904 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3905 (Fdefine_coding_system_internal):
3906 Don't assume fixnums fit in int.
3907 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3908 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3909 (Funencodable_char_position, Fcheck_coding_systems_region)
3910 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3911 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3912 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3913 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3914 Don't access memory outside of the args array.
d311d28c 3915 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3916 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3917 result of ENCODE_CHAR.
d311d28c
PE
3918 * coding.h: Adjust decls to match defn changes elsewhere.
3919 (struct coding_system):
3920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3921 * composite.c (get_composition_id, find_composition)
3922 (run_composition_function, update_compositions)
3923 (compose_text, composition_gstring_put_cache)
3924 (composition_gstring_p, composition_gstring_width)
3925 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3926 (composition_compute_stop_pos, composition_reseat_it)
3927 (composition_update_it, struct position_record)
3928 (find_automatic_composition, composition_adjust_point)
3929 (Fcomposition_get_gstring, Ffind_composition_internal):
3930 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3931 (update_compositions):
3932 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3933 * composite.h: Adjust decls to match defn changes elsewhere.
3934 (struct composition):
3935 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3936 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3937 Do not attempt to compute the address of the object just before a
3938 buffer; this is not portable.
3939 (Faref, Faset):
3940 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3941 (Faset): Use int, not EMACS_INT, where int is wide enough.
3942 (Fstring_to_number): Don't assume fixnums fit in int.
3943 (Frem): Don't assume arg is nonnegative.
3944 * dbusbind.c (xd_append_arg): Check for integers out of range.
3945 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3946 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3947 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3948 (xd_get_connection_references): Return ptrdiff_t, not int.
3949 All uses changed.
3950 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3951 (xd_read_message_1):
3952 Use int, not unsigned, where the dbus API uses int.
3953 (Fdbus_message_internal): Don't overflow mtype.
3954 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3955 * dired.c (directory_files_internal, file_name_completion, scmp)
3956 (file_name_completion_stat):
3957 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3958 (file_name_completion): Don't overflow matchcount.
3959 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3960 * dispextern.h: Adjust decls to match defn changes elsewhere.
3961 (struct text_pos, struct glyph, struct bidi_saved_info)
3962 (struct bidi_string_data, struct bidi_it, struct composition_it)
3963 (struct it):
3964 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3965 (struct display_pos, struct composition_it, struct it):
3966 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3967 * dispnew.c (increment_matrix_positions)
3968 (increment_row_positions, mode_line_string)
3969 (marginal_area_string):
3970 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3971 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3972 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3973 (duration_to_sec_usec): New function, to check for overflow better.
3974 (Fsleep_for, sit_for): Use it.
3975 * doc.c (get_doc_string, store_function_docstring):
3976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3977 (get_doc_string, Fsnarf_documentation):
3978 Use int, not EMACS_INT, where int is wide enough.
3979 (get_doc_string):
3980 Use SAFE_ALLOCA, not alloca.
3981 Check for overflow when converting EMACS_INT to off_t.
3982 * doprnt.c (doprnt):
3983 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3984 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3985 Don't assume uid_t fits into fixnum.
3986 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3987 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3988 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3989 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3990 (general_insert_function)
3991 (Finsert_char, make_buffer_string, make_buffer_string_both)
3992 (update_buffer_properties, Fbuffer_substring)
3993 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3994 (Fsubst_char_in_region, check_translation)
3995 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3996 (transpose_markers, Ftranspose_regions):
3997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3998 (clip_to_bounds): Move to lisp.h as an inline function).
3999 (Fconstrain_to_field): Don't assume integers are nonnegative.
4000 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4001 (Fsubst_char_in_region, Fsave_restriction):
4002 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4003 (Femacs_pid): Don't assume pid_t fits into fixnum.
4004 (lo_time): Use int, not EMACS_INT, when int suffices.
4005 (lisp_time_argument): Check for usec out of range.
4006 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4007 (Fuser_login_name, Fuser_full_name): Signal an error
4008 if a uid argument is out of range, rather than relying on
4009 undefined behavior.
c8d5c857
PE
4010 (Fformat_time_string): Remove now-unnecessary check.
4011 lisp_time_argument checks for out-of-range usec now.
243e0530 4012 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4013 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4014 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4015 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4016 (init_cmdargs, Fdump_emacs):
4017 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4018 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4019 the bottom (typically) 32 bits of the fixnum.
4020 * eval.c (specpdl_size, call_debugger):
4021 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4022 (when_entered_debugger, Fbacktrace_debug):
4023 Don't assume fixnum can fit in int.
4024 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4025 the object just before a buffer; this is not portable.
4026 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4027 (grow_specpdl, unbind_to):
4028 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4029 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4030 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4031 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4032 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4033 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4035 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4036 (a_write, e_write):
4037 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4038 (Fcopy_file, non_regular_nbytes, read_non_regular)
4039 (Finsert_file_contents):
4040 Use int, not EMACS_INT, where int is wide enough.
4041 (READ_BUF_SIZE): Verify that it fits in int.
4042 (Finsert_file_contents): Check that counts are in proper range,
4043 rather than assuming fixnums fit into ptrdiff_t etc.
4044 Don't assume fixnums fit into int.
125b3835 4045 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4046 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4047 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4048 (string_char_to_byte, string_byte_to_char)
4049 (string_make_multibyte, string_to_multibyte)
4050 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4051 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4052 (substring_both, Fdelete, internal_equal, Ffillarray)
4053 (Fclear_string, mapcar1)
4054 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4055 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4056 (larger_vector, make_hash_table, maybe_resize_hash_table)
4057 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4058 (Fmaphash, secure_hash):
4059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4060 (concat): Check for string index and length overflow.
4061 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4062 (Frequire):
4063 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4064 (larger_vector): New API (vec, incr_min, size_max) replaces old
4065 one (vec, new_size, init). This catches size overflow.
4066 INIT was removed because it was always Qnil.
4067 All callers changed.
4068 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4069 the upper bound on a hash table index size.
4070 (make_hash_table, maybe_resize_hash_table): Use it.
4071 (secure_hash): Computer start_byte and end_byte only after
4072 they're known to be in ptrdiff_t range.
4073 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4074 (Ffont_get_glyphs, Ffont_at):
4075 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4076 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4077 (Flist_fonts, Fopen_font):
4078 Don't assume fixnum can fit in int.
4079 (check_gstring): Don't assume index can fit in int.
4080 (font_match_p): Check that fixnum is a character, not a nonnegative
4081 fixnum, since the later code needs to stuff it into an int.
4082 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4083 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4084 conversion overflow issues.
4085 (Fopen_font): Check for integer out of range.
4086 (Ffont_get_glyphs): Don't assume index can fit in int.
4087 * font.h: Adjust decls to match defn changes elsewhere.
4088 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4089 integer overflow.
4090 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4091 printmax_t, where ptrdiff_t is wide enough.
4092 (Finternal_char_font):
4093 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4094 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4095 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4096 (Fset_frame_position, x_set_frame_parameters)
4097 (x_set_line_spacing, x_set_border_width)
4098 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4099 Check that fixnums are in proper range for system types.
4100 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4102 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4103 Use SAFE_ALLOCA_LISP, not alloca.
4104 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4105 intptr_t is wide enough.
4106 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4107 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4108 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4109 Check for fixnum out of range.
4110 * ftfont.c (ftfont_list): Don't assume index fits in int.
4111 Check that fixnums are in proper range for system types.
4112 (ftfont_shape_by_flt):
4113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4114 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4115 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4116 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4117 Check that fixnums are in proper range for system types.
4118 * gnutls.h: Adjust decls to match defn changes elsewhere.
4119 * gtkutil.c (xg_dialog_run):
4120 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4121 (update_frame_tool_bar):
4122 Check that fixnums are in proper range for system types.
4123 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4124 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4125 * indent.c (last_known_column, last_known_column_point):
4126 (current_column_bol_cache):
4127 (skip_invisible, current_column, check_display_width):
4128 (check_display_width, scan_for_column, current_column_1)
4129 (Findent_to, Fcurrent_indentation, position_indentation)
4130 (indented_beyond_p, Fmove_to_column, compute_motion):
4131 (Fcompute_motion, Fvertical_motion):
4132 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4133 (last_known_column_modified): Use EMACS_INT, not int.
4134 (check_display_width):
4135 (Fcompute_motion):
4136 Check that fixnums and floats are in proper range for system types.
4137 (compute_motion): Don't assume index or fixnum fits in int.
4138 (compute_motion, Fcompute_motion):
4139 Use int, not EMACS_INT, when it is wide enough.
4140 (vmotion): Omit local var start_hpos that is always 0; that way
4141 we don't need to worry about overflow in expressions involving it.
4142 * indent.h: Adjust decls to match defn changes elsewhere.
4143 (struct position):
4144 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4145 Use int, not EMACS_INT, where int is wide enough.
4146 Remove unused members ovstring_chars_done and tab_offset;
4147 all uses removed.
4148 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4149 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4150 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4151 (make_gap, copy_text, insert, insert_and_inherit)
4152 (insert_before_markers, insert_before_markers_and_inherit)
4153 (insert_1, count_combining_before, count_combining_after)
4154 (insert_1_both, insert_from_string)
4155 (insert_from_string_before_markers, insert_from_string_1)
4156 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4157 (adjust_after_replace, adjust_after_insert, replace_range)
4158 (replace_range_2, del_range, del_range_1, del_range_byte)
4159 (del_range_both, del_range_2, modify_region)
4160 (prepare_to_modify_buffer, signal_before_change)
4161 (signal_after_change, Fcombine_after_change_execute):
4162 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4163 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4164 (balance_an_interval, split_interval_right, split_interval_left)
4165 (find_interval, next_interval, update_interval)
4166 (adjust_intervals_for_insertion, delete_node, delete_interval)
4167 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4168 (static_offset_intervals, offset_intervals)
4169 (merge_interval_right, merge_interval_left, make_new_interval)
4170 (graft_intervals_into_buffer, temp_set_point_both)
4171 (temp_set_point, set_point, adjust_for_invis_intang)
4172 (set_point_both, move_if_not_intangible, get_property_and_range)
4173 (get_local_map, copy_intervals, copy_intervals_to_string)
4174 (compare_string_intervals, set_intervals_multibyte_1):
4175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4176 * intervals.h: Adjust decls to match defn changes elsewhere.
4177 (struct interval):
4178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4179 * keyboard.c (this_command_key_count, this_single_command_key_start)
4180 (before_command_key_count, before_command_echo_length, echo_now)
4181 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4182 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4183 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4184 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4185 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4186 (last_non_minibuf_size, last_point_position, echo_truncate)
4187 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4188 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4189 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4190 (stuff_buffered_input):
4191 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4192 (last_auto_save, command_loop_1, read_char):
4193 Use EMACS_INT, not int, to avoid integer overflow.
4194 (record_char): Avoid overflow in total_keys computation.
4195 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4196 * keyboard.h: Adjust decls to match defn changes elsewhere.
4197 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4198 (Fkey_description, Fdescribe_vector, Flookup_key):
4199 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4200 (click_position): New function, to check that positions are in range.
4201 (Fcurrent_active_maps):
4202 (describe_command):
4203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4204 (Faccessible_keymaps, Fkey_description):
4205 (preferred_sequence_p):
4206 Don't assume fixnum can fit into int.
4207 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4208 Check for integer overflow in size calculations.
4209 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4210 avoid mishandling large integers.
4211 * lisp.h: Adjust decls to match defn changes elsewhere.
4212 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4213 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4214 (struct Lisp_Marker):
4215 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4216 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4217 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4218 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4219 All callers changed.
4220 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4221 Assume the arg has valid form, since it always does.
4222 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4223 unsigned integer system type.
4224 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4225 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4226 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4227 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4228 (duration_to_sec_usec): New decl.
4229 * lread.c (read_from_string_index, read_from_string_index_byte)
4230 (read_from_string_limit, readchar, unreadchar, openp)
4231 (read_internal_start, read1, oblookup):
4232 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4233 (Fload, readevalloop, Feval_buffer, Feval_region):
4234 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4235 (openp): Check for out-of-range argument to 'access'.
4236 (read1): Use int, not EMACS_INT, where int is wide enough.
4237 Don't assume fixnum fits into int.
6efdadfd 4238 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4239 (read_filtered_event): Use duration_to_sec_usec
4240 to do proper overflow checking on durations.
d311d28c
PE
4241 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4242 in size calculation.
4243 (Fexecute_kbd_macro):
4244 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4245 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4246 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4247 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4248 (set_marker_both, set_marker_restricted_both, marker_position)
4249 (marker_byte_position, Fbuffer_has_markers_at):
4250 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4251 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4252 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4253 It now merely ensures that the menu is large enough, without
4254 necessarily growing it, as this avoids some integer overflow issues.
4255 All callers changed.
4256 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4257 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4258 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4259 Use SAFE_ALLOCA_LISP, not alloca.
4260 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4261 to EMACS_INT. Check that fixnums are in proper range for system types.
4262 * minibuf.c (minibuf_prompt_width, string_to_object)
4263 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4264 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4266 (get_minibuffer, read_minibuf_unwind):
4267 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4268 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4269 this simplifies overflow checking. All callers changed.
4270 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4271 (Ftest_completion):
4272 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4273 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4274 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4275 Check that fixnums are in proper range for system types.
4276 (Fx_create_frame, Fx_show_tip):
4277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4278 * nsfont.m (ns_findfonts, nsfont_list_family):
4279 Don't assume fixnum fits in long.
4280 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4281 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4282 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4283 wide enough.
17fdb222 4284 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4285 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4286 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4287 (PRINTDECLARE, PRINTPREPARE):
4288 (strout, print_string):
4289 (print, print_preprocess, print_check_string_charset_prop)
4290 (print_object):
4291 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4292 (PRINTDECLARE):
4293 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4295 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4296 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4297 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4298 (print_error_message): Use SAFE_ALLOCA, not alloca.
4299 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4300 (print_depth, new_backquote_output, print_number_index):
4301 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4302 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4303 (Fset_process_window_size, Fformat_network_address)
4304 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4305 (sigchld_handler):
d311d28c 4306 Check that fixnums are in proper range for system types.
d44287d4 4307 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4308 Check for process-ids out of pid_t range rather than relying on
4309 undefined behavior.
e4d81efc 4310 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4311 (Fformat_network_address, read_process_output, send_process)
4312 (Fprocess_send_region, status_notify):
4313 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4314 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4315 (wait_reading_process_output, read_process_output, exec_sentinel):
4316 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4317 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4318 (Faccept_process_output): Use duration_to_sec_usec to do proper
4319 overflow checking on durations.
dde14581
PE
4320 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4321 Don't assume pid_t fits in int.
02481186
PE
4322 * process.h (struct Lisp_Process): Members tick and update_tick
4323 are now of type EMACS_INT, not int.
b62b53e8
PE
4324 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4325 configured --with-wide-int.
d311d28c
PE
4326 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4327 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4328 * search.c (looking_at_1, string_match_1):
4329 (fast_string_match, fast_c_string_match_ignore_case)
4330 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4331 (scan_newline, find_before_next_newline, search_command)
4332 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4333 (set_search_regs, wordify):
4334 (Freplace_match):
4335 (Fmatch_data):
4336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4337 (string_match_1, search_buffer, set_search_regs):
4338 (Fmatch_data):
4339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4340 (wordify): Check for overflow in size calculation.
4341 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4342 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4343 Check that fixnums are in proper range for system types.
4344 * sound.c (struct sound_device)
4345 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4346 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4347 (Fplay_sound_internal):
4348 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4349 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4350 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4351 (Fparse_partial_sexp):
4352 Don't assume fixnums can fit in int.
4353 (struct lisp_parse_state, find_start_pos, find_start_value)
4354 (find_start_value_byte, find_start_begv)
4355 (update_syntax_table, char_quoted, dec_bytepos)
4356 (find_defun_start, prev_char_comend_first, back_comment):
4357 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4358 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4360 (Finternal_describe_syntax_value): Check that match_lisp is a
4361 character, not an integer, since the code stuffs it into int.
4362 (scan_words, scan_sexps_forward):
4363 Check that fixnums are in proper range for system types.
4364 (Fforward_word):
4365 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4366 (scan_sexps_forward):
4367 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4368 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4369 * syntax.h: Adjust decls to match defn changes elsewhere.
4370 (struct gl_state_s):
4371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4372 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4373 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4374 * sysdep.c (wait_for_termination_1, wait_for_termination)
4375 (interruptible_wait_for_termination, mkdir):
4376 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4377 (emacs_read, emacs_write):
4378 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4379 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4380 and double all fit in int.
d311d28c
PE
4381 * term.c (set_tty_color_mode):
4382 Check that fixnums are in proper range for system types.
4383 * termhooks.h (struct input_event):
4384 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4385 * textprop.c (validate_interval_range, interval_of)
4386 (Fadd_text_properties, set_text_properties_1)
4387 (Fremove_text_properties, Fremove_list_of_text_properties)
4388 (Ftext_property_any, Ftext_property_not_all)
4389 (copy_text_properties, text_property_list, extend_property_ranges)
4390 (verify_interval_modification):
4391 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4392 (Fnext_single_char_property_change)
4393 (Fprevious_single_char_property_change):
4394 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4395 (copy_text_properties):
4396 Check for integer overflow in index calculation.
d311d28c
PE
4397 * undo.c (last_boundary_position, record_point, record_insert)
4398 (record_delete, record_marker_adjustment, record_change)
4399 (record_property_change):
4400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4401 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4402 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4403 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4404 (Fx_hide_tip, Fx_file_dialog):
4405 * w32menu.c (set_frame_menubar):
4406 Use ptrdiff_t, not int, for consistency with rest of code.
4407 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4408 (select_window, Fdelete_other_windows_internal)
4409 (window_scroll_pixel_based, window_scroll_line_based)
4410 (Frecenter, Fset_window_configuration):
4411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4412 (Fset_window_hscroll, run_window_configuration_change_hook)
4413 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4414 (Fscroll_other_window, Frecenter):
d311d28c
PE
4415 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4416 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4417 Don't assume fixnum fits in int.
4418 (Fset_window_scroll_bars):
4419 Check that fixnums are in proper range for system types.
4420 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4421 (string_pos, c_string_pos, number_of_chars, init_iterator)
4422 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4423 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4424 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4425 (face_before_or_after_it_pos, handle_invisible_prop)
4426 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4427 (display_prop_intangible_p, string_buffer_position_lim)
4428 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4429 (get_overlay_strings_1, get_overlay_strings)
4430 (iterate_out_of_display_property, forward_to_next_line_start)
4431 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4432 (get_next_display_element, set_iterator_to_next)
4433 (get_visually_first_element, compute_stop_pos_backwards)
4434 (handle_stop_backwards, next_element_from_buffer)
4435 (move_it_in_display_line_to, move_it_in_display_line)
4436 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4437 (add_to_log, message_dolog, message_log_check_duplicate)
4438 (message2, message2_nolog, message3, message3_nolog
4439 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4440 (current_message_1, truncate_echo_area, truncate_message_1)
4441 (set_message, set_message_1, store_mode_line_noprop)
4442 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4443 (text_outside_line_unchanged_p, check_point_in_composition)
4444 (reconsider_clip_changes)
4445 (redisplay_internal, set_cursor_from_row, try_scrolling)
4446 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4447 (redisplay_window, find_last_unchanged_at_beg_row)
4448 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4449 (trailing_whitespace_p, find_row_edges, display_line)
4450 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4451 (display_mode_element, store_mode_line_string)
4452 (pint2str, pint2hrstr, decode_mode_spec)
4453 (display_count_lines, display_string, draw_glyphs)
4454 (x_produce_glyphs, x_insert_glyphs)
4455 (rows_from_pos_range, mouse_face_from_buffer_pos)
4456 (fast_find_string_pos, mouse_face_from_string_pos)
4457 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4459 (safe_call, init_from_display_pos, handle_fontified_prop)
4460 (handle_single_display_spec, load_overlay_strings)
4461 (with_echo_area_buffer, setup_echo_area_for_printing)
4462 (display_echo_area, echo_area_display)
4463 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4464 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4465 (redisplay_window, dump_glyph_row, display_mode_line)
4466 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4467 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4468 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4469 (handle_single_display_spec, build_desired_tool_bar_string)
4470 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4471 (get_specified_cursor_type):
4472 Check that fixnums are in proper range for system types.
4473 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4474 (Flookup_image_map):
4475 Don't assume fixnums fit in int.
4476 (compare_overlay_entries):
4477 Avoid mishandling comparisons due to subtraction overflow.
4478 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4479 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4480 (handle_tool_bar_click):
4481 Use int, not unsigned, since we prefer signed and the signedness
4482 doesn't matter here.
4483 (get_next_display_element, next_element_from_display_vector):
4484 Use int, not EMACS_INT, when int is wide enough.
4485 (start_hourglass): Use duration_to_sec_usec to do proper
4486 overflow checking on durations.
4487 * xfaces.c (Fbitmap_spec_p):
4488 Check that fixnums are in proper range for system types.
4489 (compare_fonts_by_sort_order):
4490 Avoid mishandling comparisons due to subtraction overflow.
4491 (Fx_family_fonts, realize_basic_faces):
4492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4493 (Fx_family_fonts):
4494 Don't assume fixnum fits in int.
4495 Use SAFE_ALLOCA_LISP, not alloca.
4496 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4497 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4498 (face_at_buffer_position, face_for_overlay_string)
4499 (face_at_string_position):
4500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4501 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4502 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4503 (Fx_show_tip):
4504 Check that fixnums are in proper range for system types.
4505 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4506 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4507 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4508 (Fx_change_window_property): Don't assume fixnums fit in int.
4509 * xfont.c (xfont_chars_supported):
4510 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4511 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4512 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4513 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4514 * xml.c (parse_region):
4515 * xrdb.c (magic_file_p):
4516 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4517 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4518 (x_get_local_selection, x_reply_selection_request)
4519 (x_handle_selection_request, wait_for_property_change):
4520 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4521 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4522 short is wide enough.
4523 (x_send_client_event): Don't assume fixnum fits in int.
4524 * xterm.c (x_x_to_emacs_modifiers):
4525 Don't assume EMACS_INT overflows nicely into int.
4526 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4527 may come from Lisp.
4528 (handle_one_xevent): NATNUMP can eval its arg twice.
4529 (x_connection_closed):
4530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4531 * xterm.h: Adjust decls to match defn changes elsewhere.
4532 (struct scroll_bar): Use struct vectorlike_header
4533 rather than rolling our own approximation.
4534 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4535
c6574eb5
GM
45362012-05-25 Glenn Morris <rgm@gnu.org>
4537
4538 * lisp.mk (lisp): Update for more files being compiled now.
4539
e8d32c7e
SM
45402012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4541
48def666
SM
4542 * lread.c: Remove `read_pure' which makes no difference.
4543 (read_pure): Remove var.
4544 (unreadpure): Remove function.
4545 (readevalloop): Don't call read_list with -1 flag.
4546 (read1, read_vector): Don't test read_pure any more.
4547 (read_list): Simplify.
4548
e8d32c7e
SM
4549 * fileio.c, character.h: Minor style tweaks.
4550
4b2addb7
DA
45512012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4552
4553 * window.h (clip_changed): Remove useless declaration.
4554
584461b2
JB
45552012-05-22 Juanma Barranquero <lekktu@gmail.com>
4556
4557 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4558 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4559
34374650
PE
45602012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4561
4562 Remove src/m/*.
4563 This directory predates autoconf and is no longer needed nowadays.
4564 Move its few remaining bits of functionality to where they're needed.
4565 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4566 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4567 * m/template.h: Remove.
4568 * Makefile.in (M_FILE): Remove. All uses removed.
4569 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4570 * lisp.h (USE_LSB_TAG):
4571 * mem-limits.h (EXCEEDS_LISP_PTR):
4572 Use VAL_MAX, not VALBITS, in #if.
4573 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4574 (EMACS_UINT): Define unconditionally now.
4575 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4576 (BITS_PER_EMACS_INT): New constants, replacing
4577 what used to be in config.h, but not useful in #if.
4578 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4579 define them any more.
4580 (VAL_MAX): New macro.
4581 (VALMASK): Use it.
4582 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4583 BITS_PER_EMACS_INT, in #if.
4584 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4585 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4586 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4587 * s/ms-w32.h (DATA_START):
4588 Move here from removed file m/intel386.h.
4589 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4590 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4591
261cb4bb
PE
45922012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4593
4594 Assume C89 or later.
4595 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4596 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4597 (xrealloc):
4598 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4599 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4600 * textprop.c, tparam.c (NULL): Remove.
4601 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4602 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4603 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4604 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4605 * xterm.c (input_signal_count): Assume volatile works.
4606
ff23cd9f
KB
46072012-05-21 Ken Brown <kbrown@cornell.edu>
4608
4609 * xgselect.c (xg_select): Fix first argument in call to 'select'
4610 (bug#11508).
4611
1b170bc6
KB
46122012-05-20 Ken Brown <kbrown@cornell.edu>
4613
4614 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4615 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4616
b2f4d39f
KB
46172012-05-19 Ken Brown <kbrown@cornell.edu>
4618
4619 * xfns.c (x_in_use): Remove `static' qualifier.
4620 * xterm.h (x_in_use): Declare.
4621 * xgselect.c: Include xterm.h.
4622 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4623 and `display_arg' (bug#9754).
4624
003fdae2
PE
46252012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4626
9232a6d9
PE
4627 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4628
003fdae2
PE
4629 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4630 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4631
784b56e2
EZ
46322012-05-18 Eli Zaretskii <eliz@gnu.org>
4633
4634 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4635
4636 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4637 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4638
4639 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4640 reference to image_cache->refcount.
4641 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4642
a0a79cde
JL
46432012-05-17 Juri Linkov <juri@jurta.org>
4644
4645 * search.c (Fword_search_regexp, Fword_search_backward)
4646 (Fword_search_forward, Fword_search_backward_lax)
4647 (Fword_search_forward_lax): Move functions to isearch.el
4648 (bug#10145, bug#11381).
4649
b0572523
PE
46502012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4651
4652 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4653
9660f5fc
SM
46542012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4655
4656 * lread.c (init_obarray): Declare Qt and Qnil as special.
4657
4374de83
GM
46582012-05-14 Glenn Morris <rgm@gnu.org>
4659
4660 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4661 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4662
dc44c39a
PE
46632012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4664
078c97cb
PE
4665 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4666
dc44c39a
PE
4667 * unexaix.c: Port to more-recent AIX compilers.
4668 (report_error, report_error_1, make_hdr, copy_sym)
4669 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4670 Make arguments const char *, not char *, to avoid violations of C
4671 standard and to fix some AIX warnings reported by Gilles Pion.
4672
e18afed7 46732012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4674
4675 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4676 already have overlays loaded.
4677 (handle_single_display_spec): Before returning without displaying
4678 fringe bitmap, synchronize the bidi iterator with the main display
4679 iterator, by calling iterate_out_of_display_property.
4680 (iterate_out_of_display_property): Detect buffer iteration by
4681 testing that it->string is a Lisp string.
4682 (get_next_display_element): When the current object is exhausted,
4683 and there's something on it->stack, call set_iterator_to_next to
4684 proceed with what's on the stack, instead of returning zero.
4685 (set_iterator_to_next): If called at the end of a Lisp string,
4686 proceed to consider_string_end without incrementing string
4687 position. Don't increment display vector index past the end of
4688 the display vector. (Bug#11417)
c8fb9dc6
EZ
4689 (pos_visible_p): Don't report a position visible when move_it_to
4690 stopped at the last line of window, which happens to be scanned
4691 backwards by the bidi iteration. (Bug#11464)
ac268e67 4692
e18afed7 46932012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4694
4695 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4696 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4697 are on a TTY, and thus unable to display on the fringes.
4698 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4699 so we need to signal to the caller that this is a "replacing"
4700 display spec. This fixes display when the spec is invalid or we
4701 are on a TTY.
4702
e18afed7 47032012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4704
4705 * unexaix.c (make_hdr): Fix typo in prototype.
4706 This bug broke the build on AIX. Problem reported by Gilles Pion.
4707
9d0a235a
MA
47082012-05-14 Michael Albinus <michael.albinus@gmx.de>
4709
4710 * keyboard.c (kbd_buffer_get_event): Read special events also in
4711 batch mode. (Bug#11415)
4712
9e6b06ed
GM
47132012-05-12 Glenn Morris <rgm@gnu.org>
4714
4715 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4716
c1a1d7a3
EZ
47172012-05-12 Eli Zaretskii <eliz@gnu.org>
4718
4719 * lisp.mk (lisp): Add newcomment.elc.
4720
3fe7cdc8
GM
47212012-05-12 Glenn Morris <rgm@gnu.org>
4722
4723 * Makefile.in (MKDIR_P): New, set by configure.
4724 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4725
53f7d2c0
PE
47262012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4727
4728 Remove unused function hourglass_started.
4729 * dispextern.h (hourglass_started):
4730 * w32fns.c (hourglass_started):
4731 * xdisp.c (hourglass_started): Remove.
4732
75aafb17
JB
47332012-05-10 Juanma Barranquero <lekktu@gmail.com>
4734
4735 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4736 Update dependencies.
4737
12959e8e
PE
47382012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4739
97107e2e
PE
4740 * xgselect.c (xg_select): Put maxfds+1 into a var.
4741 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4742
12959e8e
PE
4743 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4744
836d29b3
DA
47452012-05-10 Dave Abrahams <dave@boostpro.com>
4746
4747 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4748 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4749
5cb67954
MA
47502012-05-09 Michael Albinus <michael.albinus@gmx.de>
4751
4752 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4753 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4754 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4755 Initialize xd_registered_buses.
4756
3478ec45
PE
47572012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4758
b263a6b0
PE
4759 Untag more efficiently if USE_LSB_TAG.
4760 This is based on a proposal by YAMAMOTO Mitsuharu in
4761 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4762 For an admittedly artificial (nth 8000 longlist) benchmark on
4763 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4764 Emacs's overall text size by 1%.
4765 * lisp.h (XUNTAG): New macro.
4766 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4767 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4768 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4769 * eval.c (Fautoload):
4770 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4771 * frame.h (XFRAME): Use XUNTAG.
4772
3478ec45
PE
4773 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4774 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4775 Remove unportable assumptions about print widths of types like
4776 dbus_uint32_t.
4777 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4778 intptr_t when converting between pointer and integer, to avoid GCC
4779 warnings about wrong width.
4780
666b903b 47812012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4782
4783 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4784 stack for each reader_thread, instead of defaulting to 8MB
4785 determined by the linker. This avoids failures in creating
4786 subprocesses on Windows 7, see the discussion in this thread:
4787 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4788
b120cc17
JC
47892012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4790
4791 Fix up display of the *Minibuf-0* buffer in the mini window.
4792 * keyboard.c (read_char): Don't clear the echo area if there's no
4793 message to clear.
4794 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4795 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4796
9a4b36f8
MA
47972012-05-07 Michael Albinus <michael.albinus@gmx.de>
4798
4799 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4800 batch mode.
4801
e5f9458f
CY
48022012-05-06 Chong Yidong <cyd@gnu.org>
4803
4804 * lisp.mk (lisp): Update.
4805
eceeb5fc 48062012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4807
4808 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4809
71873e2b
SM
48102012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4811
4812 * data.c (PUT_ERROR): New macro.
4813 (syms_of_data): Use it. Add new error type `user-error'.
4814 * undo.c (user_error): New function.
4815 (Fprimitive_undo): Use it.
4816 * print.c (print_error_message): Adjust print style for `user-error'.
4817 * keyboard.c (user_error): New function.
4818 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4819
ab0fa4e4
PE
48202012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4821
4822 Do not limit current-time-string to years 1000..9999.
4823 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4824 (Fcurrent_time_string): Support any year that is supported by the
4825 underlying localtime representation. Don't use asctime, as it
4826 has undefined behavior for years outside the range -999..9999.
4827
7ed806a7
PE
48282012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4829
4830 Fix race conditions involving setenv, gmtime, localtime, asctime.
4831 Without this fix, interrupts could mess up code that uses these
4832 nonreentrant functions, since setting TZ invalidates existing
4833 tm_zone or tzname values, and since most of these functions return
4834 pointers to static storage.
4835 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4836 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4837 Grow the critical sections to include not just invoking
4838 localtime/gmtime, but also accessing these functions' results
4839 including their tm_zone values if any, and any related TZ setting.
4840 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4841 so that the struct tm is saved in the critical section.
4842 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4843 motivated by the fact that memory allocation needs to be outside
4844 the critical section.
4845
0c16dfed
DA
48462012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4847
4848 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4849 with RESET_INTERVAL.
4850
4851 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4852 Remove duplicated buffer name initialization.
4853
3f83ace8
JM
48542012-05-02 Jim Meyering <jim@meyering.net>
4855
4856 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4857
c7b8541e
JM
4858 * xfns.c (x_window): Use xstrdup (Bug#11375).
4859
90207a15 48602012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4861
4862 * xdisp.c (pos_visible_p): If already at a newline from the
4863 display string before the 'while' loop, don't walk back the glyphs
4864 from it3.glyph_row. Solves assertion violation when the display
4865 string begins with a newline (egg.el). (Bug#11367)
4866
b593d6a9
AH
48672012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4868
4869 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4870 Move to simple.el.
4871
4737362e
GM
48722012-05-01 Glenn Morris <rgm@gnu.org>
4873
99cf43f9
GM
4874 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4875 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4876 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4877 All were removed before 23.1.
4878
9311dcff
GM
4879 * dispnew.c: Remove HAVE_LIBNCURSES test;
4880 it is always true on relevant platforms.
4881
4d5c6349
GM
4882 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4883 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4884
4737362e
GM
4885 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4886
74dd3a6b
AS
48872012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4888
4889 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4890 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4891 Remove.
4892
13c379ee
PE
48932012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4894
4895 Do not avoid creating empty evaporating overlays (Bug#9642).
4896 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4897 That is, do not delete an evaporating overlay if it becomes
4898 empty after its bounds are adjusted to fit within its buffer.
4899 This fix caused other problems, and I'm reverting it until we get
4900 to the bottom of them.
4901
a8e7d6d7 49022012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4903
4904 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4905
a8e7d6d7 49062012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4907
4908 * xdisp.c (pos_visible_p): If the window start position is beyond
4909 ZV, start the display from buffer beginning. Prevents assertion
4910 violation in init_iterator when the minibuffer window is scrolled
4911 via the scroll bar.
4912
4913 * window.c (window_scroll_pixel_based): Likewise.
4914
a8e7d6d7 49152012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4916
4917 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4918
a8e7d6d7 49192012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4920
4921 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4922 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4923
a8e7d6d7 49242012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4925
b593d6a9
AH
4926 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4927 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4928
1c6900d9
EZ
49292012-04-26 Eli Zaretskii <eliz@gnu.org>
4930
4c3fa1d9
EZ
4931 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4932 display element, check also the underlying string or buffer
4933 character. (Bug#11341)
4934
1c6900d9
EZ
4935 * w32menu.c: Include w32heap.h.
4936 (add_menu_item): If the call to AppendMenuW (via
4937 unicode_append_menu) fails, disable Unicode menus only if we are
4938 running on Windows 9X/Me.
4939
42bf8205
AS
49402012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4941
4942 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4943 (xgetint): Add missing shift for LSB tags.
4944
b1bac16e
MR
49452012-04-24 Martin Rudalics <rudalics@gmx.at>
4946
4947 * keyboard.c (read_char): Don't wipe echo area for select window
4948 events: These might get delayed via `mouse-autoselect-window'
4949 (Bug#11304).
4950
d69621cc
JB
49512012-04-24 Juanma Barranquero <lekktu@gmail.com>
4952
4953 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4954 manipulation of :loaded-from data.
4955
02fd101b
JB
49562012-04-23 Juanma Barranquero <lekktu@gmail.com>
4957
4958 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4959 now a cons (bug#11311).
4960
888bec30
PE
49612012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4962
89a438bd
PE
4963 Do not create empty overlays with the evaporate property (Bug#9642).
4964 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4965 if it becomes empty after its bounds are adjusted to fit within
4966 its buffer. Without this fix, in a nonempty buffer (let ((o
4967 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4968 yields an empty overlay that has the evaporate property, which is
4969 not supposed to happen.
4970
1068fe4d
PE
4971 Fix minor GTK3 problems found by static checking.
4972 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4973 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4974 (struct _EmacsFixedClass, emacs_fixed_get_type):
4975 Move decls here from emacsgtkfixed.h, since they needn't be public.
4976 (emacs_fixed_get_type): Now static.
4977 (emacs_fixed_class_init): Omit unused local.
4978 (emacs_fixed_child_type): Remove; unused.
4979 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4980 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4981 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4982 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4983 (EMACS_FIXED_GET_CLASS): Remove; unused.
4984 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4985
888bec30
PE
4986 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4987 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4988
de85e130
PE
49892012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4990
d0baac98 4991 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4992 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4993 (__malloc_size_t, __malloc_ptrdiff_t):
4994 Remove. All uses removed, replaced by the definiens if needed,
4995 since we can assume C89 or better now.
4996 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4997 (protect_malloc_state, align, get_contiguous_space)
4998 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4999 (malloc_atfork_handler_child, malloc_enable_thread)
5000 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5001 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5002 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5003 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5004 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5005 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5006 Define using prototypes, not old style.
5007 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5008 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5009 (align): Don't assume that signed integer overflow wraps around.
5010 Omit unused local var.
5011 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5012 (_free_internal_nolock, memalign, mallochook, reallochook):
5013 Omit no-longer-needed casts.
5014 (valloc): Use getpagesize, not __getpagesize.
5015 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5016 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5017
de85e130
PE
5018 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5019
dcbf5805
MA
50202012-04-22 Michael Albinus <michael.albinus@gmx.de>
5021
5022 Move functions from C to Lisp. Make non-blocking method calls
5023 the default. Implement further D-Bus standard interfaces.
5024
5025 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5026 (QCdbus_request_name_allow_replacement)
5027 (QCdbus_request_name_replace_existing)
5028 (QCdbus_request_name_do_not_queue)
5029 (QCdbus_request_name_reply_primary_owner)
5030 (QCdbus_request_name_reply_in_queue)
5031 (QCdbus_request_name_reply_exists)
5032 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5033 (QCdbus_registered_serial, QCdbus_registered_method)
5034 (QCdbus_registered_signal): New Lisp objects.
5035 (XD_DEBUG_MESSAGE): Use sizeof.
5036 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5037 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5038 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5039 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5040 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5041 (xd_signature, xd_append_arg): Allow float for integer types.
5042 (xd_get_connection_references): New function.
b593d6a9
AH
5043 (xd_get_connection_address): Rename from xd_initialize.
5044 Return cached address.
dcbf5805
MA
5045 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5046 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5047 level.
5048 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5049 Return number of refcounts.
dcbf5805
MA
5050 (Fdbus_get_unique_name): Make stronger parameter check.
5051 (Fdbus_message_internal): New defun.
5052 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5053 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5054 (Fdbus_send_signal, Fdbus_register_service)
5055 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5056 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5057 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5058 (Vdbus_compiled_version, Vdbus_runtime_version)
5059 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5060 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5061 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5062 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5063 Adapt docstring.
dcbf5805 5064
52828e02
PE
50652012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5066
da05bc4c
PE
5067 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5068 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5069 Do not assume ptrdiff_t is the same width as 'int'.
5070
52828e02
PE
5071 * alloc.c: Handle unusual debugging option combinations.
5072 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5073 since the two debugging options are incompatible.
5074 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5075 is defined.
5076 (mem_init, mem_insert, mem_insert_fixup):
5077 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5078 (NEED_MEM_INSERT): Remove; no longer needed.
5079
f01769f9
LL
50802012-04-22 Leo Liu <sdl.web@gmail.com>
5081
5082 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5083
5790543d
PE
50842012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5085
5086 * sysdep.c [__FreeBSD__]: Minor cleanups.
5087 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5088 Use Emacs indenting style more consistently. Avoid some casts.
5089 Use 'double' consistently rather than mixing 'float' and 'double'.
5090
b91b7e4d
EW
50912012-04-21 Eduard Wiebe <usenet@pusto.de>
5092
b593d6a9
AH
5093 * sysdep.c (list_system_processes, system_process_attributes):
5094 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5095
6114eb15
AS
50962012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5097
5098 * lisp.mk (lisp): Update.
5099
2f38dff7
PE
51002012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5101
5102 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5103 It is never used otherwise.
5104
4ae29f89
SM
51052012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5106
5107 * print.c (print_preprocess): Only check print_depth if print-circle
5108 is nil.
5109 (print_object): Check for cycles even when print-circle is nil and
5110 print-gensym is t, but only check print_depth if print-circle is nil.
5111
f30d612a
CY
51122012-04-20 Chong Yidong <cyd@gnu.org>
5113
5114 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5115 set the status to "failed" and ensure that sentinel is run.
5116
c07a4c0b 51172012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5118
5119 * process.c (Fset_process_inherit_coding_system_flag)
5120 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5121 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5122
c07a4c0b 51232012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5124
5125 * xdisp.c (string_buffer_position_lim): Limit starting position to
5126 BEGV.
5127 (set_cursor_from_row): If called for a mode-line or header-line
5128 row, return zero immediately.
5129 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5130 farther than the first row after the header line, if any.
5131 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5132 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5133
c07a4c0b 51342012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5135
4ae29f89
SM
5136 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5137 (bug#11238).
ad3a2b41 5138
c07a4c0b 51392012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 51402012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5141
5142 configure: new option --enable-gcc-warnings (Bug#11207)
5143 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5144 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5145 (ALL_CFLAGS): Use new macros rather than old.
5146 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5147 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5148 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5149 -Wunused-result, -Wunused-variable. This should go away once
5150 the Emacs and Gnulib regex code is merged.
5151 (xmalloc, xrealloc): Now static.
5152
aba027e8
PE
51532012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5154
5155 * dired.c (Fsystem_groups): Remove unused local.
5156
e5a36063
GM
51572012-04-17 Glenn Morris <rgm@gnu.org>
5158
5159 * dired.c (Fsystem_users): Doc fix.
5160
316411f0
DA
51612012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5162
5163 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5164 (syms_of_dired): Add them.
5165
9426aba4
PE
51662012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5167
b62a57be
PE
5168 Fix minor alloc.c problems found by static checking.
5169 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5170 New extern decls, to avoid calling undeclared functions.
5171 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5172 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5173 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5174 (NEED_MEM_INSERT): New macro.
5175 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5176 Remove one incorrect comment and fix another.
b62a57be 5177
3539f31f
PE
5178 Fix minor ralloc.c problems found by static checking.
5179 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5180 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5181 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5182 (r_alloc_sbrk): Now static.
5183
a041960a
PE
5184 Improve ralloc.c interface checking.
5185 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5186 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5187 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5188 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5189 [REL_ALLOC]: ... to here, to check interface.
5190 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5191 Remove decls. This fixes an "It stinks!".
5192
9426aba4
PE
5193 * alloc.c (which_symbols): Fix alignment issue / type clash.
5194
d55c12ed
AS
51952012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5196
5197 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5198 (struct Lisp_Misc_Any): Likewise.
5199 (struct Lisp_Free): Likewise.
5200 * alloc.c (union aligned_Lisp_Symbol): Define.
5201 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5202 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5203 (union aligned_Lisp_Misc): Define.
5204 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5205 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5206 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5207
b948ce8b
PE
52082012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5209
5210 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5211 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5212 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5213 * s/netbsd.h, s/sol2-6.h:
5214 Remove definition of GC_MARK_STACK, since the default now works.
5215 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5216 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5217 no longer the default.
5218 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5219
35dc09a1 52202012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5221
35dc09a1
GM
5222 * lread.c (lisp_file_lexically_bound_p):
5223 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5224
35dc09a1
GM
52252012-04-14 Eli Zaretskii <eliz@gnu.org>
5226
5227 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5228 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5229
52302012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5231
5232 * nsterm.m (constrainFrameRect): Always constrain when there is only
5233 one screen (Bug#10962).
5234
bcd86815
KB
52352012-04-13 Ken Brown <kbrown@cornell.edu>
5236
5237 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5238
c25df26e
RT
52392012-04-13 Reuben Thomas <rrt@sc3d.org>
5240
5241 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5242
0fc59f1e
DC
52432012-04-11 Daniel Colascione <dancol@dancol.org>
5244
5245 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5246 against is gone. It's better to use vfork now so that when Cygwin
5247 gains a new, working vfork, we use it automatically (bug#10398).
5248
de8c03dc
SM
52492012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5250
5251 * window.c (save_window_save): Obey window-point-insertion-type.
5252
2f097256
GM
52532012-04-11 Glenn Morris <rgm@gnu.org>
5254
5255 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5256
453b951e
SM
52572012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5258
5259 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5260
75f1671a 52612012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5262
5263 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5264 (force_quit_count): New var.
5265 (handle_interrupt): Use it.
5266
2a8ce227
JB
52672012-04-10 Juanma Barranquero <lekktu@gmail.com>
5268
5269 * w32.c (w32_delayed_load): Record the full path of the library
5270 being loaded (bug#10424).
5271
935396c0
GM
52722012-04-09 Glenn Morris <rgm@gnu.org>
5273
05920a43
GM
5274 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5275 not just in the obarray, before snarfing them. (Bug#11036)
5276
935396c0
GM
5277 * Makefile.in ($(leimdir)/leim-list.el):
5278 Pass EMACS rather than BUILT_EMACS.
5279
a18ecafa
TZ
52802012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5281
5282 * process.c (make_process):
5283 * process.h: Add integer `gnutls_handshakes_tried' member to
5284 process struct.
5285
6bbef4e5
JC
5286 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5287 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5288
5289 * gnutls.c (gnutls_log_function2i): Convenience log function.
5290 (emacs_gnutls_read): Use new log functions,
5291 `gnutls_handshakes_tried' process member, and
5292 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5293 attempts per process (connection).
5294
b4d3bc10
CY
52952012-04-09 Chong Yidong <cyd@gnu.org>
5296
5297 * eval.c (Fuser_variable_p, user_variable_p_eh)
5298 (lisp_indirect_variable): Functions deleted.
5299 (Fdefvar): Caller changed.
5300
5301 * callint.c (Finteractive, Fcall_interactively):
5302 * minibuf.c (Fread_variable): Callers changed.
5303
70f4d973
EZ
53042012-04-09 Eli Zaretskii <eliz@gnu.org>
5305
5306 * xdisp.c (set_cursor_from_row): If the display string appears in
5307 the buffer at position that is closer to point than the position
5308 after the display string, display the cursor on the first glyph of
5309 the display string. Fixes cursor display when a 'display' text
5310 property immediately follows invisible text. (Bug#11094)
5311
cb3c2e3e
PE
53122012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5313
5314 composite.c: use 'double' consistently
5315 * composite.c (get_composition_id): Use 'double' consistently
5316 instead of converting 'float' to 'double' and vice versa; this is
5317 easier to understand and avoids a GCC warning.
5318
fd06db5d
GM
53192012-04-09 Glenn Morris <rgm@gnu.org>
5320
50fe702a
GM
5321 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5322 preparation for dumping it with emacs. (Bug#4789)
5323 (leimdir): New variable.
5324 ($(leimdir)/leim-list.el): New rule.
5325 (emacs$(EXEEXT)): Depend on leim-list.el.
5326
fd06db5d
GM
5327 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5328 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5329 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5330
55c131ee
AS
53312012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5332
5333 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5334 proper alignment.
5335
9209588f
JB
53362012-04-07 Juanma Barranquero <lekktu@gmail.com>
5337
5338 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5339 Remove unused local variable.
5340
e3fb2efb
PE
53412012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5342
5343 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5344 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5345 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5346 objects, as mark_maybe_pointer will catch them otherwise.
5347 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5348 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5349
b5385551
PE
53502012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5351
5352 Fix typo that broke non-Windows builds.
5353 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5354
9078ead6
EZ
53552012-04-07 Eli Zaretskii <eliz@gnu.org>
5356
5357 Support building on MS-Windows with libxml2.
5358
5359 * makefile.w32-in (OBJ2): Add xml.$(O).
5360 (GLOBAL_SOURCES): Add xml.c.
5361 ($(BLD)/xml.$(O)): New dependency list.
5362
5363 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5364 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5365 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5366 [!WINDOWSNT]: New macros.
5367 (init_libxml2_functions, libxml2_loaded_p): New functions.
5368 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5369 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5370 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5371 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5372 linked in).
6bbef4e5
JC
5373 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5374 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5375 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5376
5377 * emacs.c: Don't include libxml/parser.h.
5378 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5379 xmlCleanupParser directly.
5380
5381 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5382
3811fdf3
EZ
53832012-04-07 Eli Zaretskii <eliz@gnu.org>
5384
5385 * indent.c (Fvertical_motion): If there is a display string at
5386 point, use it.vpos to compute how many lines to backtrack after
5387 move_it_to point. (Bug#11133)
5388
2f8e16b2
EZ
53892012-04-06 Eli Zaretskii <eliz@gnu.org>
5390
5391 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5392 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5393 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5394 macros related to unification of CJK characters. For the details,
5395 see the discussion following the message here:
5396 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5397
3d439cd1
CY
53982012-04-04 Chong Yidong <cyd@gnu.org>
5399
5400 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5401
8bc53d00
EZ
54022012-04-01 Eli Zaretskii <eliz@gnu.org>
5403
5404 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5405 instead of alloca. (Bug#11138)
5406
3b0512a3
AS
54072012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5408
5409 * w32menu.c (is_simple_dialog): Properly check lisp types.
5410 (Bug#11141)
5411
8427ddd2
EZ
54122012-03-31 Eli Zaretskii <eliz@gnu.org>
5413
979022ef
EZ
5414 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5415 position we get to after a call to move_it_to fails the
5416 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5417 only if we wind up in a string from display property. (Bug#11063)
5418
a6b1c7cc
EZ
5419 * window.c (Fdelete_other_windows_internal): Invalidate the row
5420 and column information about mouse highlight, so that redisplay
5421 restores it after reallocating the glyph matrices. (Bug#7464)
5422
8427ddd2
EZ
5423 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5424 string comes from a `display' text property, use the buffer
5425 position of that property as if we actually saw that position in
5426 the row's glyphs.
697ba24b
EZ
5427 (move_it_by_lines): Remove the assertion that
5428 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5429 violated when there's a before-string at the beginning of a line.
5430 (Bug#11063)
8427ddd2 5431
65a0a738
EZ
54322012-03-30 Eli Zaretskii <eliz@gnu.org>
5433
5434 * xdisp.c (append_space_for_newline): If the default face was
5435 remapped, use the remapped face for the appended newline.
5436 (extend_face_to_end_of_line): Use the remapped default face for
5437 extending the face to the end of the line.
5438 (display_line): Call extend_face_to_end_of_line when the default
5439 face was remapped. (Bug#11068)
5440
581355cc
EZ
54412012-03-29 Eli Zaretskii <eliz@gnu.org>
5442
5443 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5444
e8fc049f
SM
54452012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5446
5447 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5448
4fb9a543
GM
54492012-03-27 Glenn Morris <rgm@gnu.org>
5450
5451 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5452 Doc fixes.
5453
679910f1
KH
54542012-03-26 Kenichi Handa <handa@m17n.org>
5455
5456 * dispextern.h (struct glyph): Fix previous change. Change the
5457 bit length of glyphless.ch to 25 (Bug#11082).
5458
90d49b7f
CY
54592012-03-26 Chong Yidong <cyd@gnu.org>
5460
5461 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5462 (command_loop_1): Use it; inhibit selection update for
5463 handle-select-window too (Bug#8996).
5464
f514f6f0
FP
54652012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5466
e8fc049f 5467 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5468
bf43fa51
KH
54692012-03-25 Kenichi Handa <handa@m17n.org>
5470
5471 * dispextern.h (struct glyph): Change the bit length of
5472 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5473
8a0c01dd
EZ
54742012-03-24 Eli Zaretskii <eliz@gnu.org>
5475
5476 * s/ms-w32.h (tzname): Include time.h before redirecting to
5477 _tzname. Fixes the MSVC build. (Bug#9960)
5478
7d1c3a76
AS
54792012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5480
8ed79523
AS
5481 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5482 characters.
5483
7d1c3a76
AS
5484 * xterm.c (XTread_socket): Only modify handling_signal if
5485 !SYNC_INPUT. (Bug#11080)
5486
e99a9b8b
EZ
54872012-03-23 Eli Zaretskii <eliz@gnu.org>
5488
5489 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5490 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5491 when fetching a multibyte character consumes more bytes than
5492 CHAR_BYTES returns, due to unification of CJK characters in
5493 string_char. (Bug#11073)
5494
5063c0e1
TN
54952012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5496
5497 * process.c (wait_reading_process_output): Handle pty disconnect
5498 by refraining from sending oneself a SIGCHLD (bug#10933).
5499
9f851fbd
CY
55002012-03-22 Chong Yidong <cyd@gnu.org>
5501
5502 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5503
5063c0e1 5504 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5505 Mark string as coming from a prefix property.
5506 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5507 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5508
fb5b8aca
CY
55092012-03-21 Chong Yidong <cyd@gnu.org>
5510
5511 * xfaces.c (Vface_remapping_alist): Doc fix.
5512
62356a1b
EZ
55132012-03-20 Eli Zaretskii <eliz@gnu.org>
5514
5515 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5516 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5517 Doc fixes.
62356a1b 5518
025de85b
CY
55192012-03-20 Chong Yidong <cyd@gnu.org>
5520
5521 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5522 to reflect default non-nil value of redisplay-dont-pause.
5523
4827f94e
KH
55242012-03-19 Kenichi Handa <handa@m17n.org>
5525
5526 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5527 it fit in a valid range (Bug#11003).
5528
e50a24a2
EZ
55292012-03-18 Eli Zaretskii <eliz@gnu.org>
5530
5531 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5532 that is not from display property, accept the row as a "cursor
5533 row" if one of the string's character has a non-nil `cursor'
5534 property. Fixes cursor positioning when there are newlines in
5535 overlay strings, e.g. in icomplete.el. (Bug#11035)
5536
9af5ed87
PE
55372012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5538
5539 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5540
d1f55f16
CY
55412012-03-12 Chong Yidong <cyd@gnu.org>
5542
5543 * eval.c (inhibit_lisp_code): Rename from
5544 inhibit_window_configuration_change_hook; move from window.c.
5545
5546 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5547 * window.c (run_window_configuration_change_hook)
5548 (syms_of_window): Callers changed.
5549
66c5eebd
CY
55502012-03-11 Chong Yidong <cyd@gnu.org>
5551
413df973
CY
5552 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5553
66c5eebd
CY
5554 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5555
1de11f56
CY
55562012-03-10 Chong Yidong <cyd@gnu.org>
5557
5558 * frame.c (other_visible_frames): Don't assume the selected frame
5559 is visible (Bug#10955).
5560
cae07000
SM
55612012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5562
5563 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5564
89c94350
JD
55652012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5566
5567 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5568 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5569 zero (Bug#10954).
5570
999dd333
GM
55712012-03-03 Glenn Morris <rgm@gnu.org>
5572
01a6dcc8 5573 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5574
de0100f2
EZ
55752012-03-02 Eli Zaretskii <eliz@gnu.org>
5576
5577 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5578 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5579 (redisplay_window, next_element_from_string): Fix typos in
5580 comments.
3e441275
EZ
5581 (redisplay_window): Pass to move_it_vertically the margin in
5582 pixels, not in screen lines.
de0100f2 5583
96a72ee9
GM
55842012-03-02 Glenn Morris <rgm@gnu.org>
5585
5586 * buffer.c (buffer-list-update-hook): Doc fix.
5587
312508d7
EZ
55882012-02-29 Eli Zaretskii <eliz@gnu.org>
5589
5590 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5591 push_it before setting up the iterator for the first overlay
5592 string, even if we have an empty string loaded.
5593 (next_overlay_string): If there's an empty string on the iterator
5594 stack, pop the stack. (Bug#10903)
5595
27f3c637
PE
55962012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5597
5598 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5599 Suggested by Stefan Monnier in
5600 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5601 * alloc.c (widen_to_Lisp_Object): New static function.
5602 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5603 and widening them to Lisp_Objects. This would work even if
5604 USE_LSB_TAG is defined and wide integers are used, which might
5605 happen in a future version of Emacs.
5606
3c9dfce6
CY
56072012-02-25 Chong Yidong <cyd@gnu.org>
5608
fa74b241
CY
5609 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5610 Doc fix.
5611
3c9dfce6
CY
5612 * xselect.c (Fx_selection_exists_p): Doc fix.
5613 (x_clipboard_manager_save_all): Print an informative message
5614 before saving to clipboard manager.
5615
9486df08
CY
56162012-02-24 Chong Yidong <cyd@gnu.org>
5617
5618 * keyboard.c (process_special_events): Handle all X selection
5619 requests in kbd_buffer, not just the next one (Bug#8869).
5620
f01d3321
CY
56212012-02-23 Chong Yidong <cyd@gnu.org>
5622
5623 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5624 call when setting menu-bar-lines and tool-bar-lines parameters.
5625 (unwind_create_frame_1): New helper function.
5626
5627 * window.c (inhibit_window_configuration_change_hook): New var.
5628 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5629 (syms_of_window): Initialize it.
f01d3321 5630
86b847b6
CY
56312012-02-22 Chong Yidong <cyd@gnu.org>
5632
5633 * xterm.c (x_draw_image_relief): Add missing type check for
5634 Vtool_bar_button_margin (Bug#10743).
5635
a59225b1
CY
56362012-02-21 Chong Yidong <cyd@gnu.org>
5637
5638 * fileio.c (Vfile_name_handler_alist): Doc fix.
5639
5640 * buffer.c (Fget_file_buffer): Protect against invalid file
5641 handler return value.
5642
310f5bd4
PE
56432012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5644
cb3a28cc
PE
5645 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5646 when computing $valmask.
5647
310f5bd4
PE
5648 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5649 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5650 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5651 It's useless in that case, and it can cause problems on hosts
5652 that allocate halves of EMACS_INT values separately.
5653 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5654 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5655 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5656 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5657 it avoids undefined behavior on hosts where shifting right by more
5658 than the word width has undefined behavior.
5659
2375c96a
CY
56602012-02-19 Chong Yidong <cyd@gnu.org>
5661
5662 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5663 (Funhandled_file_name_directory, Ffile_name_as_directory)
5664 (Fdirectory_file_name, Fexpand_file_name)
5665 (Fsubstitute_in_file_name): Protect against invalid file handler
5666 return values (Bug#10845).
5667
3eb49e71
EZ
56682012-02-18 Eli Zaretskii <eliz@gnu.org>
5669
5670 * .gdbinit (pitx): Fix incorrect references to fields of the
5671 iterator stack.
5672
7b926f3f
CY
56732012-02-17 Chong Yidong <cyd@gnu.org>
5674
5675 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5676
11273115
PE
56772012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5678
5679 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5680 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5681
c3a70e2b
CY
56822012-02-15 Chong Yidong <cyd@gnu.org>
5683
5684 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5685 marked as special. Also, starting docstrings with * is obsolete.
5686
0ca43699
AS
56872012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5688
5689 * gnutls.c (emacs_gnutls_write): Fix last change.
5690
2e8f3c56
LI
56912012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5692
5693 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5694 send_process.
5695
af70074f
SM
56962012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5697
5698 * keymap.c (Fsingle_key_description): Handle char ranges.
5699
95986d52
CY
57002012-02-12 Chong Yidong <cyd@gnu.org>
5701
afd83bd1
CY
5702 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5703 as that creates a dangerous corner case.
5704
95986d52
CY
5705 * window.c (Fdelete_window_internal): Invalidate the mouse
5706 highlight (Bug#9904).
5707
bd7da63e
GM
57082012-02-12 Glenn Morris <rgm@gnu.org>
5709
5710 * xselect.c (Fx_own_selection_internal)
5711 (Fx_get_selection_internal, Fx_disown_selection_internal)
5712 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5713 * nsselect.m (Fx_own_selection_internal)
5714 (Fx_disown_selection_internal, Fx_selection_exists_p)
5715 (Fx_selection_owner_p, Fx_get_selection_internal):
5716 Sync docs and argument specs with the xselect.c versions.
5717
77abcbc2
LI
57182012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5719
5720 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5721
90b671e2
EZ
57222012-02-11 Eli Zaretskii <eliz@gnu.org>
5723
1c0ca0b7
EZ
5724 * w32select.c (Fx_selection_exists_p): Sync doc string and
5725 argument list with xselect.c. (Bug#10783)
5726
5727 * w16select.c (Fx_selection_exists_p): Sync doc string and
5728 argument list with xselect.c. (Bug#10783)
90b671e2 5729
49241268
GM
57302012-02-10 Glenn Morris <rgm@gnu.org>
5731
5732 * fns.c (Fsecure_hash): Doc fix.
5733
f998bbe7 57342012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5735
5736 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5737
0992bd9c
CY
57382012-02-07 Chong Yidong <cyd@gnu.org>
5739
5740 * buffer.c (Fbuffer_local_variables)
5741 (buffer_lisp_local_variables): Handle unbound vars correctly;
5742 don't let Qunbound leak into Lisp.
5743
af008560
GM
57442012-02-07 Glenn Morris <rgm@gnu.org>
5745
dd605cc4
GM
5746 * image.c (Fimagemagick_types): Doc fix.
5747
af008560
GM
5748 * image.c (imagemagick-render-type): Change it from a lisp object
5749 to an integer. Move the doc here from the lisp manual.
5750 Treat all values not equal to 0 the same.
5751
1449fa1d
CY
57522012-02-06 Chong Yidong <cyd@gnu.org>
5753
5754 * doc.c (store_function_docstring): Avoid applying docstring of
5755 alias to base function (Bug#2603).
5756
3723ec07
AS
57572012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5758
5759 * .gdbinit (pp1, pv1): Remove redundant defines.
5760 (pr): Use pp.
5761
79c1cc1e
CY
57622012-02-04 Chong Yidong <cyd@gnu.org>
5763
5764 * nsterm.m: Declare a global (Bug#10694).
5765
d7f29f8e
EZ
57662012-02-04 Eli Zaretskii <eliz@gnu.org>
5767
cae07000
SM
5768 * w32.c (get_emacs_configuration_options):
5769 Include --enable-checking, if specified, in the return value.
d7f29f8e 5770
3b95a6f9
MR
57712012-02-04 Martin Rudalics <rudalics@gmx.at>
5772
5773 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5774 after rounding frame sizes. (Bug#9723)
5775
d6fa96a6
EZ
57762012-02-04 Eli Zaretskii <eliz@gnu.org>
5777
5778 * keyboard.c (adjust_point_for_property): Don't position point
5779 before BEGV. (Bug#10696)
5780
df0b2940
PE
57812012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5782
5783 Handle overflow when computing char display width (Bug#9496).
5784 * character.c (char_width): Return EMACS_INT, not int.
5785 (char_width, c_string_width): Check for overflow when
5786 computing the width; this is possible now that individual
5787 characters can have unbounded width. Problem introduced
5788 by merge from Emacs 23 on 2012-01-19.
5789
6bee44d6
MA
57902012-02-02 Michael Albinus <michael.albinus@gmx.de>
5791
5792 * dbusbind.c (Fdbus_register_method): Mention the return value
5793 :ignore in the docstring.
5794
44f92739
GM
57952012-02-02 Glenn Morris <rgm@gnu.org>
5796
1b9f60cc
GM
5797 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5798
44f92739
GM
5799 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5800 Unconditionally set to t. (Bug#10673)
5801 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5802 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5803 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5804
c5d3843c
KH
58052012-02-02 Kenichi Handa <handa@m17n.org>
5806
5807 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5808 0, do not call append_composite_glyph.
5809
159462d4 58102012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5811
5812 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5813 NULL (Bug#6988).
5814 (x_produce_glyphs): If the component of a composition is a null
5815 string, set it->pixel_width to 1 to avoid zero-width glyph.
5816
78cef877
EZ
58172012-02-01 Eli Zaretskii <eliz@gnu.org>
5818
5819 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5820 first 2 arguments are identical. This makes inserting large
5821 output from a subprocess an order of magnitude faster on
5822 MS-Windows, where all sbrk'ed memory is always contiguous.
5823
97897668
GM
58242012-01-31 Glenn Morris <rgm@gnu.org>
5825
5826 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5827 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5828 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5829
31fd3586
GM
58302012-01-29 Glenn Morris <rgm@gnu.org>
5831
5832 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5833
0e24a8b2
CY
58342012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5835
5836 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5837
cc0adcb0
CY
58382012-01-28 Chong Yidong <cyd@gnu.org>
5839
5840 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5841
acc28cb9
CY
58422012-01-26 Chong Yidong <cyd@gnu.org>
5843
9c69cfb7
CY
5844 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5845
acc28cb9
CY
5846 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5847 repeat counts (Bug#10507).
5848
48da7392
GM
58492012-01-26 Glenn Morris <rgm@gnu.org>
5850
5851 * lread.c (syms_of_lread): Doc fix.
5852
14af5f7f
CY
58532012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5854
5855 * coding.c (encode_designation_at_bol): Change return value to
5856 EMACS_INT.
5857
0b21c100
CY
58582012-01-25 Chong Yidong <cyd@gnu.org>
5859
5860 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5861
3c2907f7
CY
58622012-01-21 Chong Yidong <cyd@gnu.org>
5863
5864 * floatfns.c (Fcopysign): Make the second argument non-optional,
5865 since nil is not allowed anyway.
5866
959ad23f
AS
58672012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5868
5869 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5870 (send_process): Likewise.
5871
34a02f46
MR
58722012-01-19 Martin Rudalics <rudalics@gmx.at>
5873
5874 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5875 (Vwindow_persistent_parameters): Do not use Qstate.
5876 Rewrite doc-strings.
34a02f46 5877
1259009a 58782012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5879
5880 * character.c (char_width): New function.
70d4fdf6
GM
5881 (Fchar_width, c_string_width, lisp_string_width):
5882 Use char_width (Bug#9496).
25ed9e61 5883
6a6ee00d
MR
58842012-01-16 Martin Rudalics <rudalics@gmx.at>
5885
5886 * window.c (Vwindow_persistent_parameters): New variable.
5887 (Fset_window_configuration, save_window_save): Handle persistent
5888 window parameters.
5889
c85efaf7
EZ
58902012-01-14 Eli Zaretskii <eliz@gnu.org>
5891
5892 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5893 thrashing the stack of the thread. (Bug#9087)
5894
5944709e
PE
58952012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5896
5897 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5898
e71f5d99
EZ
58992012-01-11 Eli Zaretskii <eliz@gnu.org>
5900
5901 * xdisp.c (rows_from_pos_range): Handle the case where the
5902 highlight ends on a newline. (Bug#10464)
5903 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5904 he end column for display of highlight that ends on a newline
5905 before a R2L line.
5906
ce316182
GM
59072012-01-11 Glenn Morris <rgm@gnu.org>
5908
5909 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5910 from load-path also when installation-directory is nil. (Bug#10208)
5911
5b43da69
GM
59122012-01-10 Glenn Morris <rgm@gnu.org>
5913
74cc8ff9
GM
5914 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5915
7d8d6e4e
GM
5916 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5917 Update template values to be closer to their typical values these days.
5b43da69 5918
a0db8d43
EZ
59192012-01-09 Eli Zaretskii <eliz@gnu.org>
5920
5921 * xdisp.c (rows_from_pos_range): Accept additional argument
5922 DISP_STRING, and accept any glyph in a row whose object is that
5923 string as eligible for mouse highlight. Fixes mouse highlight of
5924 display strings from overlays. (Bug#10464)
5925
9a0115ab 59262012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5927
b9110d6a 5928 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5929 * fileio.c (auto_saving_dir_umask): New static var.
5930 (Fmake_directory_internal): Use it.
5931 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5932 creating the directory. The old code temporarily assigns
5933 too-generous permissions to the directory.
5934 (do_auto_save_eh): Clear it.
b9110d6a 5935 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5936 that the var is always cleared.
5937
6c1bd3f3
EZ
59382012-01-07 Eli Zaretskii <eliz@gnu.org>
5939
5940 * search.c (scan_buffer): Pass character positions to
5941 know_region_cache, not byte positions. (Bug#6540)
5942
069d2b50
L
59432012-01-07 LynX <_LynX@bk.ru> (tiny change)
5944
5945 * w32.c (sys_rename): Report EXDEV when rename of a directory
5946 fails because the target is on another logical disk. (Bug#10284)
5947
75bf0d33
DB
59482012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5949
5950 * xterm.c (x_embed_request_focus): New function.
5951
5952 * xterm.h: Add prototype.
5953
5954 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5955
1c6e5a32
GM
59562012-01-05 Glenn Morris <rgm@gnu.org>
5957
5958 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5959
651e947e
EZ
59602012-01-01 Eli Zaretskii <eliz@gnu.org>
5961
5962 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5963 Load gnutls_transport_set_lowat only if GnuTLS version is below
5964 2.11.1.
5965 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5966 GnuTLS versions below 2.11.1.
5967
3778cdd8
AL
59682011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5969
5970 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5971 to the doc string advising against its use for altering the way
5972 windows are scrolled.
5973
0e5317f7
KH
59742011-12-28 Kenichi Handa <handa@m17n.org>
5975
5976 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5977 coding-system ASCII compatible only when it does not produce BOM
5978 on encoding (Bug#10383).
5979
93d5ca1f
JD
59802011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5981
5982 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5983 can scroll.
5984 (create_and_show_popup_menu): Always use menu_position_func for
5985 Gtk3 (Bug#10361).
5986
ca22b785
AS
59872011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5988
5989 * callint.c (Fcall_interactively): Don't truncate prompt string.
5990
d048e1e6
EZ
59912011-12-23 Eli Zaretskii <eliz@gnu.org>
5992
5993 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5994 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5995 resumed from there (after widening). (Bug#10360)
d048e1e6 5996
5ccaba1f
JD
59972011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5998
5999 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6000
204ee57f
JD
60012011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6002
b81d40f0
JB
6003 * nsterm.m (x_free_frame_resources):
6004 Release f->output_data.ns->miniimage.
204ee57f
JD
6005 (ns_index_color): Fix indentation. Do not retain
6006 color_table->colors[i].
6007
6008 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6009 before returning.
6010
6011 * nsfns.m (x_set_background_color): Assign return value from
6012 ns_index_color to face-background instead of NSColor*.
6013 (ns_implicitly_set_icon_type): Fix indentation.
6014 Change assignment in for loop to comparison.
6015
6016 * emacs.c (ns_pool): New variable.
6017 (main): Assign ns_pool.
6018 (Fkill_emacs): Call ns_release_autorelease_pool.
6019
6020 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6021 autorelease fdesc, release fdAttrs and tdict.
6022 (ns_get_covering_families): Release charset.
6023 (ns_findfonts): Release NSFontDescriptor created with new.
6024 (ns_uni_to_glyphs): Fix indentation.
6025 (setString): Release attrStr before assigning new value.
6026
c803b2b7
JD
60272011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6028
678f4426
JD
6029 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6030 and NS_IMPL_COCOA.
6031 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6032 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6033
cd394be1 60342011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6035
5fecd5fc
JD
6036 * nsterm.m (ns_term_init): Subscribe for notifications
6037 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6038 to method trackingNotification in EmacsMenu.
6039
6040 * nsmenu.m (trackingMenu): New variable.
3771cb17 6041 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6042 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6043 from Aquamacs (Bug#7030).
678f4426
JD
6044
60452011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6046
c803b2b7
JD
6047 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6048 (symbol_to_nsstring): Fix indentation.
6049 (ns_symbol_to_pb): New function.
cae07000
SM
6050 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6051 (Fns_rotate_cut_buffers_internal): Remove.
6052 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6053 Fns_store_cut_buffer_internal.
6054 (ns_get_foreign_selection, Fx_own_selection_internal)
6055 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6056 (Fns_get_selection_internal, Fns_store_selection_internal):
6057 Use ns_symbol_to_pb and check if return value is nil.
6058 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6059 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6060 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6061 renamed to Sns_store_selection_internal.
6062 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6063 and remove this function.
6064 (ns_handle_selection_clear): Remove, never used.
6065 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6066 here.
6067
e1b01a3a
KB
60682011-12-17 Ken Brown <kbrown@cornell.edu>
6069
6070 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6071 GID is unknown (Bug#10257).
6072
2adb6e85
PE
60732011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6074
6075 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6076 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6077 which caused a build failure on GNU/Linux IA-64. This problem was
6078 introduced by my 2011-10-07 patch.
6079
d1d7b339
JL
60802011-12-15 Juri Linkov <juri@jurta.org>
6081
6082 * image.c (imagemagick_error): New function. (Bug#10112)
6083 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6084 Use `imagemagick_error' where ImageMagick functions return
6085 `MagickFalse'.
6086 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6087 proper order.
6088
100d5755
KH
60892011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6090
6091 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6092 fill background (Bug#8992).
6093
454592a6
MR
60942011-12-13 Martin Rudalics <rudalics@gmx.at>
6095
6096 * window.c (Vwindow_combination_resize)
6097 (Vwindow_combination_limit): Use t instead of non-nil in
6098 doc-strings.
61d4b438
MR
6099 (Vrecenter_redisplay): Add first sentence of doc-string on
6100 separate line.
53524d93 6101 (Frecenter): Fix doc-string typo.
454592a6 6102
3633e3aa
KH
61032011-12-11 Kenichi Handa <handa@m17n.org>
6104
6105 * coding.c (Funencodable_char_position): Pay attention to the
6106 buffer text relocation (Bug#9389).
6107
7b9d523a 61082011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6109
7b9d523a
JD
6110 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6111 gtk_init (Bug#10100).
6112
b73189c6
EZ
61132011-12-10 Eli Zaretskii <eliz@gnu.org>
6114
6115 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6116 IT->string is nil. (Bug#10263)
6117
f7dfe5d6
JD
61182011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6119
83faebb4
JD
6120 * nsterm.h (x_free_frame_resources): Declare.
6121
f7dfe5d6
JD
6122 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6123 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6124
6125 * nsterm.h (ns_get_defaults_value): Declare.
6126
6127 * nsterm.m (ns_default): Call ns_get_defaults_value.
6128
7cd4e72c
EZ
61292011-12-09 Eli Zaretskii <eliz@gnu.org>
6130
6131 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6132 (Bug#10170)
6133
b34d7317
YM
61342011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6135
6136 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6137 that where the value of an _OBJC_* symbol points to is in the .bss
6138 section (Bug#10240).
6139
76470ad1
KH
61402011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6141
6142 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6143 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6144
745fff94
KH
61452011-12-08 Kenichi Handa <handa@m17n.org>
6146
6147 * ftfont.c (get_adstyle_property): Fix previous change
6148 (Bug#10233).
6149
6e44397c
JB
61502011-12-07 Juanma Barranquero <lekktu@gmail.com>
6151
6152 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6153 dirs from the default value of EMACSLOADPATH (bug#10208).
6154
7efa6272
GM
61552011-12-07 Glenn Morris <rgm@gnu.org>
6156
6157 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6158 installation and source directories as well. (Bug#10208)
6159
f6fc4d87
CY
61602011-12-06 Chong Yidong <cyd@gnu.org>
6161
6162 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6163
2bf26180
GM
61642011-12-06 Glenn Morris <rgm@gnu.org>
6165
6166 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6167 as an error, not just -1. (Bug#10217)
6168
3a6ad4f0
CY
61692011-12-05 Chong Yidong <cyd@gnu.org>
6170
6171 * keyboard.c (process_special_events): New function.
6172 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6173
75a3b399
PE
61742011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6175
6176 * coding.c (encode_designation_at_bol): Don't use uninitialized
6177 local variable (Bug#9318).
6178
c3c9e25e
KH
61792011-12-05 Kenichi Handa <handa@m17n.org>
6180
6181 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6182 return Qnil (Bug#8046, Bug#10193).
6183
5eb05ea3
KH
61842011-12-05 Kenichi Handa <handa@m17n.org>
6185
6186 * coding.c (encode_designation_at_bol): New args charbuf_end and
6187 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6188 (coding_set_source): Return how many bytes coding->source was
6189 relocated.
6190 (coding_set_destination): Return how many bytes
6191 coding->destination was relocated.
6192 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6193 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6194
61952011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6196
6197 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6198 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6199 macro (Bug#9318).
6200
62012011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6202
6203 The following changes are to fix Bug#9318.
6204
a79703f5 6205 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6206 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6207 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6208 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6209
7dbda6df
JB
62102011-12-05 Juanma Barranquero <lekktu@gmail.com>
6211
6212 * lisp.h (process_quit_flag): Fix external declaration.
6213
6d5eb5b0
SM
62142011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6215
6216 Don't macro-inline non-performance-critical code.
6217 * eval.c (process_quit_flag): New function.
6218 * lisp.h (QUIT): Use it.
6219
a0c3fad0
JD
62202011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6221
6222 * nsfns.m (get_geometry_from_preferences): New function.
6223 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6224
6c07aac2
AS
62252011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6226
6227 * emacs.c (Qkill_emacs): Define.
6228 (syms_of_emacs): Initialize it.
6229 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6230 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6231 (quit_throw_to_read_char): Add parameter `from_signal'.
6232 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6233 * lisp.h (QUIT): Call Fkill_emacs if requested.
6234
c052ead4
JD
62352011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6236
6237 * widget.c (update_wm_hints): Return if wmshell is null.
6238 (widget_update_wm_size_hints): New function.
6239
6240 * widget.h (widget_update_wm_size_hints): Declare.
6241
6242 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6243 widget_update_wm_size_hints (Bug#10104).
6244
9e49252b
EZ
62452011-12-03 Eli Zaretskii <eliz@gnu.org>
6246
6247 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6248 before a newline, prepare the bidi iterator for consuming the
6249 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6250 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6251
02b16839
JL
62522011-12-02 Juri Linkov <juri@jurta.org>
6253
6254 * search.c (Fword_search_regexp): New Lisp function created from
6255 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6256 (Fword_search_backward, Fword_search_forward)
6257 (Fword_search_backward_lax, Fword_search_forward_lax):
6258 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6259 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6260
0068070e
SM
62612011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6262
6263 * fileio.c (Finsert_file_contents): Move after-change-function call
6264 to before the "handled:" label, since all "goto handled" appear in
6265 cases where the *-change-functions have already been properly called
6266 (bug#10117).
6267
3360a3fc
AS
62682011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6269
6270 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6271 waiting for input. (Bug#10169)
6272
73d6c093
EZ
62732011-11-30 Eli Zaretskii <eliz@gnu.org>
6274
6275 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6276 verifies glyph row's hash code--we have just reallocated the
6277 glyphs, so their contents can be complete garbage. (Bug#10164)
6278
febe6bea
JB
62792011-11-30 Juanma Barranquero <lekktu@gmail.com>
6280
6281 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6282
801a4313
EZ
62832011-11-30 Eli Zaretskii <eliz@gnu.org>
6284
6285 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6286 attributes are tested _before_ calling verify_row_hash, to protect
6287 against GCC re-ordering of the tests. (Bug#10164)
6288
2b56b87e
JD
62892011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6290
6291 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6292
6293 * xterm.c (handle_one_xevent): Only set async_visible and friends
6294 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6295 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6296 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6297
dbf31225
PE
62982011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6299
6300 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6301 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6302 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6303 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6304 All uses changed to use GCPRO1 etc.
6305 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6306 Revert to old implementation (i.e., before 2011-03-11).
6307
1305621b
YM
63082011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6309
6310 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6311 of scroll runs so as to avoid assigning disabled bogus rows and
6312 unnecessary graphics copy operations.
6313
8c9afb46
EZ
63142011-11-27 Eli Zaretskii <eliz@gnu.org>
6315
6316 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6317 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6318 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6319 (malloc, free, realloc, calloc): Redirect to e_* only when
6320 compiling Emacs.
6321
6322 * lisp.h (GCTYPEBITS): Move before first use.
6323 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6324 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6325 this macro definition.
6326
6327 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6328 _MSC_VER.
6329
54e9e3bf
JD
63302011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6331
6d5eb5b0
SM
6332 * gtkutil.c (xg_create_frame_widgets):
6333 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6334 present with Gtk+ 2.0.
6335
83aca1cb
PE
63362011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6337
6338 * fileio.c (Finsert_file_contents): Undo previous change; see
6339 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6340
5b76caa4
PE
63412011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6342
6343 Rename locals to avoid shadowing.
6344 * fileio.c (Finsert_file_contents):
6345 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6346 * process.c (wait_reading_process_output):
6347 Rename inner 'proc' to 'p' to avoid shadowing.
6348 Indent for consistency with usual Emacs style.
6349
8c535114
EZ
63502011-11-25 Eli Zaretskii <eliz@gnu.org>
6351
6352 * xdisp.c (redisplay_window): If cursor row is not fully visible
6353 after recentering, and scroll-conservatively is set to a large
6354 number, scroll window by a few more lines to make the cursor fully
6355 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6356 (start_display): Don't move to the next line if the display should
6357 start at a newline that is part of a display vector or an overlay
6358 string. (Bug#10119)
8c535114 6359
fa4fdb5c
JL
63602011-11-24 Juri Linkov <juri@jurta.org>
6361
6362 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6363 after the `MagickPingImage' call. (Bug#10112)
6364
90ec88df
CY
63652011-11-23 Chong Yidong <cyd@gnu.org>
6366
6367 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6368
56e2e794
MR
63692011-11-23 Martin Rudalics <rudalics@gmx.at>
6370
6371 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6372 making another buffer current. (Bug#10114)
6373
b6e64c41
GM
63742011-11-23 Glenn Morris <rgm@gnu.org>
6375
6376 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6377
6b21de18
CY
63782011-11-23 Chong Yidong <cyd@gnu.org>
6379
6380 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6381 using it (Bug#5984).
6382
b12cd789
EZ
63832011-11-22 Eli Zaretskii <eliz@gnu.org>
6384
6385 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6386 and header-lines, as they don't have one computed for them.
6387 (Bug#10098)
6388
6389 * .gdbinit (prow): Make displayed values more self-explaining.
6390 Add row's hash code.
6391
261b6fd4
LMI
63922011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6393
6394 * process.c (wait_reading_process_output): Fix asynchrounous
6395 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6396 (wait_reading_process_output): Add comment and URL.
261b6fd4 6397
e7cfd277
JD
63982011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6399
6400 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6401
a9b9b7f5
CY
64022011-11-21 Chong Yidong <cyd@gnu.org>
6403
6404 * window.c (Fnext_window, Fprevious_window): Doc fix.
6405
b0d15b4f
SM
64062011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6407
6408 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6409
fe7a3057
JB
64102011-11-20 Juanma Barranquero <lekktu@gmail.com>
6411
6412 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6413
d2999b1a
MR
64142011-11-20 Martin Rudalics <rudalics@gmx.at>
6415
6416 * window.c (Fset_window_combination_limit): Rename argument
6417 STATUS to LIMIT.
6418 (Vwindow_combination_limit): Remove "status" from doc-string.
6419
d5ff9cd0
AS
64202011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6421
6422 * m/ibms390.h: Remove.
6423 * m/ibms390x.h: Don't include "ibms390.h".
6424
a5bb9bd3
SM
64252011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6426
6427 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6428 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6429
cd1181db
JB
64302011-11-20 Juanma Barranquero <lekktu@gmail.com>
6431
6432 * casetab.c (Fset_case_table):
6433 * charset.c (Fcharset_after): Fix typos.
6434
615a3b8d 64352011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6436
17e845af
PE
6437 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6438 Otherwise, valgrind does not work on some platforms.
6439 Problem reported by Andreas Schwab in
6a0bf43d
PE
6440 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6441 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6442 is set, removing the need for VIRT_ADDRESS_VARIES.
6443 (PURE_P): Use a more-efficient implementation that needs just one
6444 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6445 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6446 to 4 (xorl, subq, cmpq, setbe).
6447 * alloc.c (pure): Always extern now, since that's the
6448 VIRT_ADDR_VARIES behavior.
6449 (PURE_POINTER_P): Use a single comparison, not two, for
6450 consistency with the new puresize.h.
6451 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6452 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6453 Remove VIRT_ADDR_VARIES no longer needed.
6454
f8fe6f96
EZ
64552011-11-19 Eli Zaretskii <eliz@gnu.org>
6456
6457 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6458 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6459 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6460 behave as if the cursor position were at the window margin.
6461
6462 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6463 and the cursor position is out of bounds, behave as if the cursor
6464 position were at the window margin. (Bug#10075)
6465
df05a53c
CY
64662011-11-18 Chong Yidong <cyd@gnu.org>
6467
6468 * window.c (Fwindow_combination_limit): Make first argument
6469 non-optional, since it is meaningless for live windows like the
6470 selected window.
61ccba97 6471
2071918e
DA
64722011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6473
6474 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6475
b50a28de
SM
64762011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6477
6478 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6479 (graft_intervals_into_buffer): Simplify.
6480
015137db
EZ
64812011-11-18 Eli Zaretskii <eliz@gnu.org>
6482
6483 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6484 hash values of the two rows.
6485 (copy_row_except_pointers): Preserve the used[] arrays and the
6486 hash values of the two rows. (Bug#10035)
68c95424 6487 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6488
6489 * xdisp.c (row_hash): New function, body extracted from
6490 compute_line_metrics.
6491 (compute_line_metrics): Call row_hash, instead of computing the
6492 hash code inline.
6493
6494 * dispnew.c (verify_row_hash): Call row_hash for computing the
6495 hash code of a row, instead of duplicating code from xdisp.c.
6496
6497 * dispextern.h (row_hash): Add prototype.
6498
a2addb04
TH
64992011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6500
6501 * frame.c (delete_frame): Don't delete the terminal when the last
6502 X frame is closed if emacs is built with GTK toolkit.
6503
df85d315
JB
65042011-11-17 Juanma Barranquero <lekktu@gmail.com>
6505
6506 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6507
a0c2d0ae
MR
65082011-11-17 Martin Rudalics <rudalics@gmx.at>
6509
6510 * window.c (Vwindow_splits): Rename to
6511 Vwindow_combination_resize. Suggested by Juri Linkov.
6512 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6513 of Vwindow_splits.
6514
58179cce
JB
65152011-11-16 Juanma Barranquero <lekktu@gmail.com>
6516
7877f373
JB
6517 * nsfns.m (Fns_font_name):
6518 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6519
b6f67890
MR
65202011-11-16 Martin Rudalics <rudalics@gmx.at>
6521
6522 * window.h (window): Rename slot "nest" to "combination_limit".
6523 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6524 (Fset_window_nest): Rename to Fset_window_combination_limit.
6525 (Vwindow_nest): Rename to Vwindow_combination_limit.
6526 (recombine_windows, make_parent_window, make_window)
6527 (Fsplit_window_internal, saved_window)
6528 (Fset_window_configuration, save_window_save): Rename all
6529 occurrences of window_nest to window_combination_limit.
6530
c7015153
JB
65312011-11-15 Juanma Barranquero <lekktu@gmail.com>
6532
6533 * image.c (imagemagick_load_image): Fix typo.
6534
322ad6ec
EZ
65352011-11-14 Eli Zaretskii <eliz@gnu.org>
6536
6537 * xdisp.c (display_line): Move the call to
6538 highlight_trailing_whitespace before the call to
6539 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6540 faces of all the glyphs to compute ROW's hash value.
6541 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6542
f067b8ec
JB
65432011-11-14 Juanma Barranquero <lekktu@gmail.com>
6544
6545 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6546 just return (bug#10044).
6547
1e5b2111
EZ
65482011-11-12 Eli Zaretskii <eliz@gnu.org>
6549
7ef3cbd5
EZ
6550 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6551 with user-defined heap size. Bump the default size of the temacs
6552 heap to 27MB, to avoid memory warning when running temacs.
6553 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6554
1e5b2111
EZ
6555 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6556 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6557 (verify_row_hash) [XASSERTS]: New function.
6558 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6559 that the hash value of glyph rows is correct.
1e5b2111 6560
89d61221
MR
65612011-11-12 Martin Rudalics <rudalics@gmx.at>
6562
6563 * window.h (window): Remove splits slot.
6564 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6565 (Fdelete_other_windows_internal, make_parent_window)
6566 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6567 (Fset_window_configuration, save_window_save): Don't deal with
6568 split status of windows.
6569 (saved_window): Remove splits slot.
6570 (Vwindow_splits): Rewrite doc-string.
6571
97f18cc8
JD
65722011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6573
6574 * xfns.c (unwind_create_frame):
6575 * nsfns.m (unwind_create_frame):
6576 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6577 Vframe_list (Bug#9999).
6578
22a648b4
DA
65792011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6580
0b381c7e 6581 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6582
659afede
KH
65832011-11-11 Kenichi Handa <handa@m17n.org>
6584
6585 * callproc.c (Fcall_process): Set the member dst_multibyte of
6586 process_coding.
6587
9ac0394b
KH
65882011-11-11 Johan Bockgård <bojohan@gnu.org>
6589
6590 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6591 avoid a crash (bug#9496).
6592
2fbdc249
CY
65932011-11-09 Chong Yidong <cyd@gnu.org>
6594
6595 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6596 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6597
ac6b1f81
PE
65982011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6599
6600 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6601
09db192c
PE
66022011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6603
6604 Avoid some portability problems by eschewing 'extern inline' functions.
6605 The trivial performance wins aren't worth the portability hassles; see
6606 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6607 et seq.
6608 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6609 (window_box_width, window_box_left, window_box_left_offset)
6610 (window_box_right, window_box_right_offset): Undo previous change,
6611 by removing the "extern"s.
6612 * intervals.c (adjust_intervals_for_insertion)
6613 (adjust_intervals_for_deletion): Undo previous change,
6614 making these static again.
6615 (offset_intervals, temp_set_point_both, temp_set_point)
6616 (copy_intervals_to_string): No longer inline.
6617 * xdisp.c (window_text_bottom_y, window_box_width)
6618 (window_box_height, window_box_left_offset)
6619 (window_box_right_offset, window_box_left, window_box_right)
6620 (window_box): No longer inline.
6621
105216ed
CY
66222011-11-08 Chong Yidong <cyd@gnu.org>
6623
6624 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6625 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6626 Signal an error if not a live window.
105216ed
CY
6627 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6628 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6629
ae9e237f
JB
66302011-11-07 Juanma Barranquero <lekktu@gmail.com>
6631
6632 * lisp.h (syms_of_abbrev): Remove declaration.
6633 Reported by CHENG Gao <chenggao@royau.me>.
6634
c7aa8333
EZ
66352011-11-07 Eli Zaretskii <eliz@gnu.org>
6636
6637 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6638 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6639 of temacs in GUI mode.
6640
be7f5545
MR
66412011-11-07 Martin Rudalics <rudalics@gmx.at>
6642
6643 * window.h: Declare delete_all_child_windows instead of
6644 delete_all_subwindows.
6645 * window.c (Fwindow_nest, Fset_window_nest)
6646 (Fset_window_new_total, Fset_window_new_normal)
6647 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6648 (delete_all_subwindows): Rename to delete_all_child_windows.
6649 (Fdelete_other_windows_internal, Fset_window_configuration):
6650 Call delete_all_child_windows instead of delete_all_subwindows.
6651 * frame.c (delete_frame): Call delete_all_child_windows instead
6652 of delete_all_subwindows.
6653
ca78dc43
PE
66542011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6655
6656 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6657 This is also needed for porting to any host where GC_MARK_STACK is
6658 not GC_MAKE_GCPROS_NOOPS.
6659 (which_symbols): Use it.
6660
a0241d01
KH
66612011-11-07 Kenichi Handa <handa@m17n.org>
6662
6663 * coding.c (coding_set_destination): Check coding->src_pos only
6664 when coding->src_object is a buffer (bug#9910).
6665
6666 * process.c (send_process): Set the member src_multibyte of coding
6667 to 0 (bug#9911) when sending a unibyte text.
6668
6669 * callproc.c (Fcall_process): Set the member src_multibyte of
6670 process_coding to 0 (bug#9912).
6671
a64bfdfa 66722011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6673
6674 * xmenu.c (cleanup_widget_value_tree): New function.
6675 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6676 calling free_menubar_widget_value_tree directly (Bug#9830).
6677
cb41b32a
PE
66782011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6679
6680 Fix some portability problems with 'inline'.
6681 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6682 (window_box_width, window_box_left, window_box_left_offset)
6683 (window_box_right, window_box_right_offset): Declare extern.
6684 Otherwise, these inline functions do not conform to C99 and
6685 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6686 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6687 * intervals.c (adjust_intervals_for_insertion)
6688 (adjust_intervals_for_deletion): Now extern, because otherwise the
6689 extern inline functions 'offset_intervals' couldn't refer to it.
6690 (static_offset_intervals): Remove.
6691 (offset_intervals): Rewrite using the old contents of
6692 static_offset_intervals. The old version didn't conform to C99
6693 because an extern inline function contained a reference to an
6694 identifier with static linkage.
6695
b7041366
AS
66962011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6697
6698 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6699 GC.
6700
88a37c4d
EZ
67012011-11-06 Eli Zaretskii <eliz@gnu.org>
6702
6703 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6704 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6705 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6706 return Qleft_to_right.
6707
49745b39
CY
67082011-11-06 Chong Yidong <cyd@gnu.org>
6709
6710 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6711 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6712 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6713 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6714 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6715 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6716 (Fwindow_vscroll): Doc fix.
6717 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6718 argument, since it makes no sense to pass a live window and for
6719 consistency with window-child.
6720
1f05cd82
CS
67212011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6722
6723 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6724 support MSVC.
6725
22610910
JR
67262011-11-05 Jason Rumney <jasonr@gnu.org>
6727
6728 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6729 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6730 fonts (Bug#6029).
6731 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6732 bitwise arithmetic preventing use of unicode-sip and non-truetype
6733 opentype fonts.
6734
a06776b2
EZ
67352011-11-05 Eli Zaretskii <eliz@gnu.org>
6736
3ad924ba
EZ
6737 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6738 "emacs"-only part.
6739
a06776b2
EZ
6740 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6741 initialization code to keep similarity to xfns.c after changes
6742 from 2011-11-05.
6743
c9e7db78
JD
67442011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6745
a97f8f3f
JD
6746 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6747 (unwind_create_frame): New function (Bug#9943).
6748 (Fx_create_frame): Restructure code to be more similar to the one in
6749 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6750 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6751 Move terminal->reference_count++ just before making the frame official
6752 (Bug#9943).
6753
6754 * nsterm.m (x_free_frame_resources): New function.
6755 (x_destroy_window): Move code to x_free_frame_resources.
6756
c9e7db78 6757 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6758 (Fx_create_frame, x_create_tip_frame):
6759 Move terminal->reference_count++ just before making the frame
75f1671a 6760 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6761 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6762
a6fc3b5c
EZ
67632011-11-05 Eli Zaretskii <eliz@gnu.org>
6764
6765 Support MSVC build with newer versions of Visual Studio.
6766 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6767 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6768 nt/gmake.defs.
6769
6770 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6771 which are not supported by MSVC.
6772 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6773 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6774 bitfields.
6775 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6776 types in bitfields.
6777 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6778
6779 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6780
58179cce 67812011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6782
6783 Support MSVC build with newer versions of Visual Studio.
6784 * w32.c: Don't include w32api.h for MSVC.
6785 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6786
6787 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6788 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6789 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6790 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6791 e_* cousins.
6792 (alloca) [_MSC_VER]: Define to _alloca.
6793
6794 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6795
6796 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6797
a58c13ed
EZ
67982011-11-04 Eli Zaretskii <eliz@gnu.org>
6799
6800 * xdisp.c (note_mouse_highlight): If either of
6801 previous/next-single-property-change returns nil, treat that as
6802 the beginning or the end of the buffer. (Bug#9955)
6803
fe0b6370
JD
68042011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6805
a58c13ed 6806 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6807 label is not null (Bug#9951).
6808 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6809 may be NULL.
6810
89bd5ee1
EZ
68112011-11-04 Eli Zaretskii <eliz@gnu.org>
6812
6813 * window.c (Fwindow_body_size): Mention in the doc string that the
6814 return value is in frame's canonical units. (Bug#9949)
6815
84c3edb9
EZ
68162011-11-03 Eli Zaretskii <eliz@gnu.org>
6817
4e2fb5c7
EZ
6818 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6819
84c3edb9 6820 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6821 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6822 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6823
bc17a887
EZ
68242011-11-01 Eli Zaretskii <eliz@gnu.org>
6825
6826 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6827 Don't stop backward scan on the continuation glyph, even though
6828 its CHARPOS is positive.
6d5eb5b0
SM
6829 (mouse_face_from_buffer_pos, note_mouse_highlight):
6830 Rename cover_string to disp_string.
bc17a887 6831
4ee88440
MR
68322011-11-01 Martin Rudalics <rudalics@gmx.at>
6833
6834 * window.c (temp_output_buffer_show): Don't use
6835 Vtemp_buffer_show_specifiers.
6836 (Vtemp_buffer_show_specifiers): Remove unused variable.
6837
c2ff3c02
EZ
68382011-10-30 Eli Zaretskii <eliz@gnu.org>
6839
6840 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6841 past the beginning of the current glyph matrix.
6842
58179cce 68432011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6844
6845 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6846 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6847 HAVE_GTK3 (Bug#9869).
b77a6a7f 6848
3b574623
JD
6849 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6850 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6851
b77a6a7f
JD
6852 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6853
6854 * xterm.c: Declare x_handle_net_wm_state to return int.
6855 (handle_one_xevent): Check if we are iconified but don't have
6856 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6857 (get_current_wm_state): Return non-zero if not hidden,
6858 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6859 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6860 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6861 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6862
196e41e4
PE
68632011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6864
6865 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6866 so that this new function doesn't get optimized away by a
6867 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6868
021f2e1a
AS
68692011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6870
6871 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6872
8b058d44
EZ
68732011-10-29 Eli Zaretskii <eliz@gnu.org>
6874
6875 Fix the `xbytecode' command.
6876 * .gdbinit (xprintbytestr): New command.
b50a28de 6877 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6878 (xbytecode): Print the byte-code string as well.
6879
4452fb80
EZ
68802011-10-29 Kim Storm <storm@cua.dk>
6881
8b058d44
EZ
6882 * alloc.c (which_symbols): New function.
6883
21b72067
AS
68842011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6885
6886 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6887 line. (Bug#9903)
6888
83ed7b5c
GM
68892011-10-29 Glenn Morris <rgm@gnu.org>
6890
6891 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6892 Not clear what it was for, and it causes various bugs. (Bug#9839)
6893
5a7a728b
EZ
68942011-10-28 Eli Zaretskii <eliz@gnu.org>
6895
6896 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6897 possible random value that matches one of those tested as
6898 condition to clear the mouse face.
6899
d3d0842f
CY
69002011-10-28 Chong Yidong <cyd@gnu.org>
6901
6902 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6903
31b39d13
DN
69042011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6905
6906 * window.c (make_window): Initialize phys_cursor_on_p.
6907
9aba6043
SM
69082011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6909
6910 * lisp.h (struct Lisp_Symbol): Update comments.
6911
c20992f4
JB
69122011-10-28 Juanma Barranquero <lekktu@gmail.com>
6913
6914 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6915
db4f02f2
EZ
69162011-10-28 Eli Zaretskii <eliz@gnu.org>
6917
6918 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6919 <oslsachem@gmail.com> for helping to debug this.
6920
6921 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6922 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6923 (g_b_init_get_glyph_outline_w): New static variables.
6924 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6925 (GetGlyphOutlineW_Proc): New typedefs.
6926 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6927 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6928 New functions.
6929 (w32font_open_internal, compute_metrics):
6930 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6931 instead of calling the "wide" APIs directly.
6932
6933 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6934
6935 * w32.h (syms_of_w32font): Add prototype.
6936
87e68db4
JB
69372011-10-27 Juanma Barranquero <lekktu@gmail.com>
6938
6939 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6940 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6941 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6942 (Fmove_to_window_line): Doc fix.
6943
435c1d67
CY
69442011-10-27 Chong Yidong <cyd@gnu.org>
6945
6946 * process.c (make_process): Set gnutls_state to NULL.
6947
6948 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6949 non-NULL, regardless of GNUTLS_INITSTAGE.
6950 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6951 an error. Set process slots as soon as we allocate them.
6952
6953 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6954
9c6c6f49
CY
69552011-10-27 Chong Yidong <cyd@gnu.org>
6956
9aba6043
SM
6957 * gnutls.c (emacs_gnutls_deinit): New function.
6958 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6959 (Fgnutls_deinit, Fgnutls_boot): Use it.
6960
6961 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6962 (deactivate_process): Call emacs_gnutls_deinit.
6963
657d08d3
JB
69642011-10-27 Juanma Barranquero <lekktu@gmail.com>
6965
6966 * image.c (x_create_x_image_and_pixmap):
6967 * w32.c (sys_rename, w32_delayed_load):
6968 * w32font.c (fill_in_logfont):
6969 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6970
5430d399
JB
69712011-10-26 Juanma Barranquero <lekktu@gmail.com>
6972
6973 * w32fns.c (w32_default_color_map): New function,
6974 extracted from Fw32_default_color_map.
a7ef684b 6975 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6976
fe0055fa
PE
69772011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6978
6979 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6980
e6346438
SM
69812011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6982
6983 * keyboard.c (test_undefined): New function (bug#9751).
6984 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6985
e112cc37
ET
69862011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6987
6988 * sysdep.c (init_sys_modes): Fix the check for the controlling
6989 terminal (Bug#6649).
6990
7b5d6677
EZ
69912011-10-20 Eli Zaretskii <eliz@gnu.org>
6992
6993 * dispextern.h (struct bidi_it): New member next_en_type.
6994
6995 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6996 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6997 current character, check also for next_en_type being WEAK_EN.
6998 (bidi_resolve_weak): Don't enter the expensive loop if the current
6999 position is before next_en_pos. Record the bidi type of the first
7000 non-ET, non-BN character we find, in addition to its position.
7001 (bidi_level_of_next_char): Invalidate next_en_type when
7002 next_en_pos is over-stepped.
7003
7da0b018
PE
70042011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7005
7006 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7007 * editfns.c: Rewrite current-time-zone so that it invokes
7008 the equivalent of (format-time-string "%Z") to get the time zone name.
7009 This fixes a bug when the time zone name contains characters that
7010 need converting from the system time locale to Emacs internal format.
7011 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7012 that patch fixed format-time-string to do the conversion, but
7013 I forgot to fix current-time-zone.
7014 (format_time_string): New function, containing most of
7015 what Fformat_time_string used to contain.
7016 (Fformat_time_string): Rewrite in terms of format_time_string.
7017 This doesn't change this function's behavior.
7018 (current-time-zone): Rewrite to use format_time_string.
7019 This fixes the bug reported by Michael Schierl in
7020 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7021 Jason Rumney's 2007-06-07 change worked around this bug, but
7022 didn't fix it.
7023 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7024
8547b010
EZ
70252011-10-19 Eli Zaretskii <eliz@gnu.org>
7026
7027 * xdisp.c (start_display): If the character at POS is displayed
7028 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7029 (try_window_reusing_current_matrix): If a line ends in a display
7030 vector or the next line starts in a display vector, continue
7031 redrawing the window even though the character position of
7032 start_row was reached.
8547b010
EZ
7033 (Bug#9771, part 2)
7034
4e948d15
CY
70352011-10-18 Chong Yidong <cyd@gnu.org>
7036
7037 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7038 with nobreak-char-display too.
7039
4787455f
EZ
70402011-10-18 Eli Zaretskii <eliz@gnu.org>
7041
7042 Fix part 3 of bug#9771.
7043 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7044 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7045 non-neutral characters if the current character is a paragraph
7046 separator (a.k.a. Newline). This avoids running the same
7047 expensive loop twice, once when we consume the preceding newline
7048 and the other time when the line actually needs to be displayed.
7049 Avoid the loop when we see neutrals on the base embedding level
7050 following a character whose directionality is the same as the
7051 paragraph's. This avoids running the expensive loop when a line
7052 ends in a long sequence of neutrals, like control characters.
7053 Add assertion against STRONG_AL type. Slightly rearrange code
7054 that determines the type of a neutral given the first non-neutral
7055 that follows it.
7056 (bidi_level_of_next_char): Set next_en_pos to zero when
7057 invalidating its info.
7058
2c91f553
EZ
70592011-10-17 Eli Zaretskii <eliz@gnu.org>
7060
7061 * xdisp.c (push_display_prop): Determine whether to record string
7062 or buffer position by IT->string, not by IT->method. Allow
7063 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7064 (move_it_vertically_backward): Don't look for character position
7065 immediately after the newline when in a continuation line.
7066 (Bug#9771, part 1)
2c91f553 7067
c7b08b0d
MR
70682011-10-15 Martin Rudalics <rudalics@gmx.at>
7069
7070 * window.c (coordinates_in_window): Rewrite and delabelize
7071 vertical border check. (Bug#5357) (Bug#9618)
7072
6b02f655
SM
70732011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7074
7075 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7076 errors in XSetWindowBorder (bug#9310).
7077
81d40c92
DA
70782011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7079
7080 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7081 avoid crash when xmalloc overrun checking is enabled.
7082
d4172c3b
EZ
70832011-10-13 Eli Zaretskii <eliz@gnu.org>
7084
7085 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7086 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7087 cursor motion with <left> and <right> arrow keys.
7088
7089 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7090 some callers set that themselves.
7091
b00eea75
EZ
70922011-10-12 Eli Zaretskii <eliz@gnu.org>
7093
7094 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7095 display string and the previous row comes from the same string and
7096 is empty. (Bug#9739) (Bug#9738)
7097
8fe012c4
SM
70982011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7099
7100 * doc.c (get_doc_string): Encode file name (bug#9735).
7101
0074aef2
EZ
71022011-10-12 Eli Zaretskii <eliz@gnu.org>
7103
79beb178
EZ
7104 * bidi.c (bidi_level_of_next_char):
7105 * xdisp.c (get_visually_first_element): Remove old incorrect
7106 comments regarding the Unicode Line Separator character.
7107
0074aef2
EZ
7108 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7109
6e4b3fbe
DA
71102011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7111
7112 * alloc.c (Fgc_status): Do not access beyond zombies array
7113 boundary if nzombies > MAX_ZOMBIES.
7114 * alloc.c (dump_zombies): Add missing format specifier.
7115
0324f3af
PE
71162011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7117
b5525cac
PE
7118 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7119 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7120
0324f3af
PE
7121 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7122 Some packages use them to denote characters with modifiers.
7123
e9b5f888
AS
71242011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7125
7126 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7127 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7128 matching a pp-number. Rename parameter var to var1.
7129
127827c0
SM
71302011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7131
7132 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7133
c8fd3bd0
GM
71342011-10-08 Glenn Morris <rgm@gnu.org>
7135
7136 * callint.c (Fcall_interactively): Give a more explicit error for the
7137 'c' case with a non-character input. (Bug#8479)
7138
352ec8ff
EZ
71392011-10-08 Eli Zaretskii <eliz@gnu.org>
7140
03669ccb
EZ
7141 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7142 lines.
7061c986
EZ
7143 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7144 lines that are hscrolled on the left.
03669ccb 7145
352ec8ff
EZ
7146 * dispnew.c (buffer_posn_from_coords): Account for a possible
7147 presence of header-line. (Bug#4426)
7148
a66cfb1c
SM
71492011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7150
6b02f655
SM
7151 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7152 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7153
7c5ee88e
PE
71542011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7155
7156 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7157 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7158 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7159 this makes Emacs dump core during garbage collection on rare
7160 occasions. sizeof is obviously inferior to offsetof here, so
7161 stick with offsetof.
7162 (GC_POINTER_ALIGNMENT): New macro.
7163 (mark_memory): Omit 3rd (offset) arg; caller changed.
7164 Don't assume EMACS_INT alignment is the same as pointer alignment.
7165
df1bbe5b
SM
71662011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7167
7168 * keyboard.c (read_key_sequence_remapped): New var.
7169 (read_key_sequence): Compute remapping in the right buffer.
7170 (command_loop_1): Use read_key_sequence's remapping directly.
7171
51553db6
SM
71722011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7173
32c1fffd
SM
7174 * dired.c (file_name_completion): Don't expand file name.
7175 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7176 before checking file name handler.
7177
51553db6
SM
7178 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7179 they've been requested explicitly (bug#9591).
7180
b6bd1599 71812011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7182
7183 * keymap.c (Fsingle_key_description): Use make_specified_string
7184 instead of build_string to build string from push_key_description.
7185 (Bug#5193)
7186
f701dc2a
PE
71872011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7188
4222c55d
PE
7189 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7190 This fixes a Y2038 bug on 64-bit hosts.
7191 * buffer.c (reset_buffer):
7192 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7193 (Fclear_buffer_auto_save_failure):
7194 Use 0, not -1, to represent an unset failure time, since time_t
7195 might not be signed.
7196
f701dc2a
PE
7197 Remove dependency on glibc malloc internals.
7198 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7199 Move back here from lisp.h, but with their new implementations.
7200 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7201 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7202 * charset.c (charset_table_init): New static var.
7203 (syms_of_charset): Use it instead of xmalloc. This removes a
7204 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7205 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7206 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7207 Move back to alloc.c.
7208 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7209 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7210
9ceebf39
JD
72112011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7212
7213 * nsterm.m (windowDidResize): Call x_set_window_size only when
7214 ns_in_resize is true. Otherwise set pixelwidth/height and
7215 call change_frame_size (Bug#9628).
7216
cb993c58
PE
72172011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7218
3930c88b
PE
7219 Port --enable-checking=all to Fedora 14 x86-64.
7220 * charset.c (syms_of_charset): Also account for glibc malloc's
7221 internal overhead when calculating the initial malloc maximum.
7222
cb993c58
PE
7223 Port --enable-checking=all to Fedora 14 x86.
7224 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7225 Move to lisp.h.
7226 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7227 (overrun_check_realloc, overrun_check_free):
7228 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7229 That way, xmalloc returns a properly-aligned pointer even if
7230 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7231 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7232 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7233 into account when calculating the initial malloc maximum.
7234 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7235 Move here from alloc.c, so that charset.c can use it too.
7236 Properly align; the old code wasn't right for common 32-bit hosts
7237 when configured with --enable-checking=all.
7238 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7239 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7240
31bed486
EZ
72412011-09-29 Eli Zaretskii <eliz@gnu.org>
7242
04c70788 7243 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7244 use EDOM.
7245
fbcaa2f3
EZ
72462011-09-28 Eli Zaretskii <eliz@gnu.org>
7247
7248 * xdisp.c (compute_display_string_end): If there's no display
7249 string at CHARPOS, return -1.
7250
7251 * bidi.c (bidi_fetch_char): When compute_display_string_end
7252 returns a negative value, treat the character as a normal
7253 character not covered by a display string. (Bug#9624)
7254
a239d4e9
JB
72552011-09-28 Juanma Barranquero <lekktu@gmail.com>
7256
7257 * lread.c (Fread_from_string): Fix typo in docstring.
7258
88652fd5
EZ
72592011-09-27 Eli Zaretskii <eliz@gnu.org>
7260
7261 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7262 newline, reseat the iterator instead of bidi-iterating there one
7263 character at a time. (Bug#9610)
32c1fffd
SM
7264 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7265 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7266
ed497dd4
AS
72672011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7268
7269 * lread.c (readevalloop): Use correct code for NBSP.
7270 (read1): Likewise. (Bug#9608)
7271
b2bf61aa
MA
72722011-09-25 Michael Albinus <michael.albinus@gmx.de>
7273
7274 * dbusbind.c (Fdbus_register_signal): When service is not
7275 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7276
32bbb17c
GM
72772011-09-25 Glenn Morris <rgm@gnu.org>
7278
7279 * buffer.c (truncate-lines): Doc fix.
7280
94e0933e
CY
72812011-09-24 Chong Yidong <cyd@stupidchicken.com>
7282
7283 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7284 (Fset_window_next_buffers): Doc fix.
7285
cddde921
GM
72862011-09-24 Glenn Morris <rgm@gnu.org>
7287
7288 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7289
1260aef1
PE
72902011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7291
25b4bfa0
PE
7292 Fix minor problems found by static checking.
7293 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7294 * indent.c (Fvertical_motion): Fix == vs = typo.
7295
e3cbd34b
EZ
72962011-09-24 Eli Zaretskii <eliz@gnu.org>
7297
a66cfb1c
SM
7298 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7299 Default value is now t. Doc fix.
6bf7006f 7300
e3cbd34b 7301 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7302 logic when moving up, not only when moving down. Fix the
e3cbd34b 7303 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7304 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7305
7306 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7307 CHARPOS is covered by a display string which includes newlines.
7308 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7309 is covered by a display string with embedded newlines.
7310
a3de0cbd
MA
73112011-09-24 Michael Albinus <michael.albinus@gmx.de>
7312
7313 * dbusbind.c (Fdbus_register_signal): Add match rule to
7314 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7315 (Fdbus_register_method, Vdbus_registered_objects_table):
7316 Fix docstring.
a3de0cbd 7317
b260039d
JM
73182011-09-24 Jim Meyering <meyering@redhat.com>
7319
32c1fffd 7320 do not ignore write error for any output size
b260039d
JM
7321 The previous change was incomplete.
7322 While it makes emacs --batch detect the vast majority of stdout
7323 write failures, errors were still ignored whenever the output size is
7324 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7325 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7326 && echo FAIL: ignored write error
7327 FAIL: ignored write error
7328 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7329 && echo FAIL: ignored write error
7330 FAIL: ignored write error
7331 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7332
8eca8a7c
AS
73332011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7334
7335 * emacs.c (Fkill_emacs): In noninteractive mode exit
7336 non-successfully if a write error occurred on stdout. (Bug#9574)
7337
3341db62
EZ
73382011-09-21 Eli Zaretskii <eliz@gnu.org>
7339
7340 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7341 the xassert test.
7342
7343 * dispextern.h (struct it): Update the comment documenting what
7344 can it->OBJECT be.
7345
8c203dbf
EZ
73462011-09-20 Eli Zaretskii <eliz@gnu.org>
7347
7348 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7349 a display string, extend search for cursor position to end of row.
7350 (find_row_edges): If the row ends in a newline from a display
7351 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7352 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7353 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7354 non-empty line. Fixes confusing cursor motion with arrow keys at
7355 the beginning of a line that starts with whitespace.
8c203dbf 7356
a4824228
LMI
73572011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7358
7359 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7360 (bug#9493).
7361
33ed493b
CY
73622011-09-18 Chong Yidong <cyd@stupidchicken.com>
7363
7364 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7365 boolean (Bug#9154).
7366
56cd55c8
EZ
73672011-09-18 Eli Zaretskii <eliz@gnu.org>
7368
7369 * xdisp.c (display_line): Record maximum and minimum buffer
7370 positions even if no glyphs were produced (e.g., by a zero-width
7371 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7372 buffer positions that will be removed from the glyph row because
7373 they don't fit.
c02dcedf
EZ
7374 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7375 column is beyond frame width: don't subtract 1 "pixel" when
7376 computing width of the stretch.
3e62b7e0
EZ
7377 (reseat_at_next_visible_line_start): Undo the change made on
7378 2011-09-17 that saved paragraph information and restored it after
7379 the call to `reseat'. (Bug#9545)
56cd55c8 7380
5ed99d36 73812011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7382
7383 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7384 and turn window cursor on if cleared (Bug#9415).
7385
5ed99d36 73862011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7387
7388 * search.c (boyer_moore): Take unibyte characters from pattern
7389 literally. (Bug#9458)
7390
9bade7b2
EZ
73912011-09-18 Eli Zaretskii <eliz@gnu.org>
7392
7393 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7394
e5e9d610
PE
73952011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7396
87e4427a
PE
7397 Fix minor problem found by static checking.
7398 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7399 initialized, to pacify gcc -Wuninitialized.
7400
e5e9d610
PE
7401 * fileio.c: Report proper errno when syscall falls.
7402 (Finsert_file_contents): Save and restore errno,
7403 so that report_file_error outputs the correct diagnostic.
7404 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7405
a1674f0b
EZ
74062011-09-18 Eli Zaretskii <eliz@gnu.org>
7407
7408 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7409
fbfb6dd4
EZ
74102011-09-17 Eli Zaretskii <eliz@gnu.org>
7411
7412 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7413 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7414
bb187662
EZ
74152011-09-17 Eli Zaretskii <eliz@gnu.org>
7416
1137e8b8 7417 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7418 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7419
7420 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7421 (bidi_find_paragraph_start): Search back for paragraph beginning
7422 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7423 (bidi_move_to_visually_next): Only trigger paragraph-related
7424 computations when the last character is a newline or at EOB, not
7425 just any NEUTRAL_B. (Bug#9470)
7426
bb187662
EZ
7427 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7428 truncated lines if point is covered by a display string. (Bug#9524)
7429
2e621251
PE
74302011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7431
7432 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7433 (cons_to_x_long): New function.
7434 (lisp_data_to_selection_data): Use it. Correct the test for
7435 short-versus-long data; it was negated. Break out of vector
7436 loop, for efficiency, when a long datum is discovered.
7437
91a15bc6
SM
74382011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7439
7440 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7441
b41c3a35
EZ
74422011-09-16 Eli Zaretskii <eliz@gnu.org>
7443
7444 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7445 GCC PR/17406) by declaring this function with external scope.
7446
7812ba2d
PE
74472011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7448
7449 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7450 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7451
cf7edc2a
AS
74522011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7453
7454 * editfns.c (Fformat): Correctly handle text properties on "%%".
7455
bd01620e
EZ
74562011-09-15 Eli Zaretskii <eliz@gnu.org>
7457
7458 * xterm.c (x_draw_composite_glyph_string_foreground):
7459 * w32term.c (x_draw_composite_glyph_string_foreground):
7460 * term.c (encode_terminal_code):
7461 * composite.c (composition_update_it, get_composition_id):
7462 * xdisp.c (get_next_display_element)
7463 (fill_composite_glyph_string): Add comments about special meaning
7464 of TAB characters in a composition.
7465
a02719a3
PE
74662011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7467
7468 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7469 This occurs when processing a multibyte format.
7470 Problem reported by Wolfgang Jenker.
a02719a3 7471
72589a3c
JB
74722011-09-15 Johan Bockgård <bojohan@gnu.org>
7473
7474 * xdisp.c (try_cursor_movement): Only check for exact match if
7475 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7476
1c14176c
PE
74772011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7478
7479 Remove unused external symbols.
7480 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7481 * xdisp.c (calc_pixel_width_or_height): Now static.
7482 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7483 * indent.c (check_display_width):
7484 * w32term.c: Fix comment to match code.
7485 * xterm.c, xterm.h (x_catching_errors): Remove.
7486
d2eea5b5
PE
74872011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7488
7489 * xselect.c: Use signed conversions more consistently (Bug#9498).
7490 (selection_data_to_lisp_data): Assume incoming selection data are
7491 signed integers, not unsigned. This is to be consistent with
7492 outgoing selection data, which was modified to use signed integers
7493 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7494 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7495 expects long, not unsigned long.
7496
46888499
EZ
74972011-09-14 Eli Zaretskii <eliz@gnu.org>
7498
7499 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7500 computation of loop end. Reported by Johan Bockgård
7501 <bojohan@gnu.org>.
7502
ef8ef9fb
CY
75032011-09-13 Chong Yidong <cyd@stupidchicken.com>
7504
7505 * frame.c (Fother_visible_frames_p): Function deleted.
7506
fa819fed
EZ
75072011-09-12 Eli Zaretskii <eliz@gnu.org>
7508
7509 * indent.c (compute_motion): Process display vector front to back
7510 rather than the other way around. (Bug#2496)
7511
2ba8e008
SM
75122011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7513
7514 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7515
20f53c69
CY
75162011-09-11 Chong Yidong <cyd@stupidchicken.com>
7517
7518 * minibuf.c (Fread_from_minibuffer): Doc fix.
7519
d562d7a4
EZ
75202011-09-11 Eli Zaretskii <eliz@gnu.org>
7521
7522 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7523 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7524
1c4d7f3d
LMI
75252011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7526
7527 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7528 value for non-existent files.
7529
b885bf36
EZ
75302011-09-11 Eli Zaretskii <eliz@gnu.org>
7531
7532 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7533 set its "size" to -1. This will set the modtime_size field of
7534 the corresponding buffer to -1, which is what
7535 verify-visited-file-modtime expects for files that do not exist.
7536 (Bug#9139)
7537
6612f0bf
PE
75382011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7539
7540 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7541 here ...
7542 * lisp.h: ... from here. push_key_description is no longer
7543 defined in keyboard.c, so its declaration should not be in
7544 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7545 logically belongs with push_key_description.
7546
dfb3f755
PE
75472011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7548
7549 * buffer.h: Include <sys/types.h> instead of <time.h>.
7550 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7551 Problem reported by Herbert J. Skuhra.
7552
3134906c
LMI
75532011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7554
7555 * xml.c (parse_region): Make the parsing work for
7556 non-comment-starting XML files again (bug#9144).
7557
8d903f4e
AS
75582011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7559
7560 * image.c (gif_load): Fix calculation of bottom and right corner.
7561 (Bug#9468)
7562
80ad64f4
EZ
75632011-09-10 Eli Zaretskii <eliz@gnu.org>
7564
7565 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7566 redisplay in small windows.
7567
208a048d
EZ
75682011-09-09 Eli Zaretskii <eliz@gnu.org>
7569
7570 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7571
9b1c252e
MR
75722011-09-08 Martin Rudalics <rudalics@gmx.at>
7573
7574 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7575 Operate on live windows only.
7576
2949f33b
JB
75772011-09-08 Juanma Barranquero <lekktu@gmail.com>
7578
7579 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7580
e08dcafd
EZ
75812011-09-07 Eli Zaretskii <eliz@gnu.org>
7582
7583 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7584 only under bidi iteration.
7585
115b96bd
JD
75862011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7587
7588 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7589
c8199d0f
PE
75902011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7591
7592 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7593 Without this fix, the command to link temacs failed due to an
7594 undefined symbol __builtin_isnan. This is because
7595 /usr/include/iso/math_c99.h #defines isnan(x) to
7596 __builtin_isnan(x), but the bundled gcc, which identifies itself
7597 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7598 a __builtin_isnan.
7599 * floatfns.c (isnan): #undef, and then #define to a clone of
7600 what's in data.c.
7601 (Fisnan): Always define, since it's always available now.
7602 (syms_of_floatfns): Always define isnan at the Lisp level.
7603
e39b275c 76042011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7605
7606 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7607
b2db44d9 76082011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7609
f4af5137 7610 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7611 The previous code assumed that file offsets (off_t values) fit in
7612 EMACS_INT variables, which is not true on typical 32-bit hosts.
7613 The code messed up by falsely reporting buffer overflow in cases
7614 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7615 when "big" contains more than 2**29 bytes, even though this
7616 inserts just one byte and does not overflow the buffer.
7617 (Finsert_file_contents): Store file offsets as off_t
7618 values, not as EMACS_INT values. Check for overflow when
7619 converting between EMACS_INT and off_t. When checking for
7620 buffer overflow or for overlap, take the offsets into account.
7621 Don't use EMACS_INT for small values where int suffices.
7622 When checking for overlap, fix a typo: ZV was used where
7623 ZV_BYTE was intended.
7624 (Fwrite_region): Don't assume off_t fits into 'long'.
7625 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7626
ecfc0a49
MA
76272011-09-05 Michael Albinus <michael.albinus@gmx.de>
7628
7629 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7630
6511acf2 76312011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7632
0999621a 7633 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7634
7635 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7636 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7637 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7638 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7639 (modify_event_symbol): Do not assume that the length of
7640 name_alist_or_stem is safe to alloca and fits in int.
7641 (Fexecute_extended_command): Likewise for function name and binding.
7642 (Frecursion_depth): Wrap around reliably on integer overflow.
7643 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7644 since some callers pass EMACS_INT values.
7645 (Fsingle_key_description): Don't crash if symbol name contains more
7646 than MAX_ALLOCA bytes.
7647 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7648 (get_minibuffer): Arg is now EMACS_INT, not int.
7649 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7650 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7651 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7652
2be7d702
PE
7653 * dbusbind.c (signature_cat): New function.
7654 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7655 Do not overrun buffer; instead, report string overflow.
7656
9d1df220
PE
7657 * dispnew.c (add_window_display_history): Don't overrun buffer.
7658 Truncate instead; this is OK since it's just a log.
7659
33ef5c64
PE
7660 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7661 even if the time zone offset is outlandishly large.
7662 Don't mishandle offset == INT_MIN.
7663
66c6fdd5
PE
7664 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7665 when creating daemon; the previous buffer-overflow check was incorrect.
7666
d749b01b
PE
7667 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7668 which has the guts of the old verror function.
7669
b5cd1905
PE
7670 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7671 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7672
6e1a67fb
PE
7673 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7674 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7675 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7676 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7677 length of string rather than counting it via multiple sprintfs;
7678 that's simpler and more reliable.
c21721cc
PE
7679 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7680 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7681 sprintf, in case result does not fit in int.
7682
c57b67fc
PE
7683 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7684 (fontset_from_font): Print it.
7685
8a401434
PE
7686 * frame.c (tty_frame_count): Now printmax_t, not int.
7687 (make_terminal_frame, set_term_frame_name): Print it.
7688 (x_report_frame_params): In X, window IDs are unsigned long,
7689 not signed long, so print them as unsigned.
7690 (validate_x_resource_name): Check for implausibly long names,
7691 and don't assume name length fits in 'int'.
7692 (x_get_resource_string): Don't blindly alloca invocation name;
7693 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7694 not fit in int.
7695
6e1a67fb
PE
7696 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7697 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7698 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7699
0df02bf3
PE
7700 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7701 Use esprintf, not sprintf, in case result does not fit in int.
7702
48e30793
PE
7703 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7704 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7705 it as a large positive number.
7706 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7707 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7708
a66ff6d8
PE
7709 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7710 in case result does not fit in int.
7711
aca216ff
PE
7712 * print.c (float_to_string): Detect width overflow more reliably.
7713 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7714 buffer overrun. Don't assume list length fits in 'int'. Treat
7715 print length of 0 as 0, not as infinity; to be consistent with other
7716 uses of print length in this function. Don't overflow print length
7717 index. Don't assume hash table size fits in 'long', or that
7718 vectorlike size fits in 'unsigned long'.
7719
31c286f7
PE
7720 * process.c (make_process): Use printmax_t, not int, to format
7721 process-name gensyms.
7722
55e5faa1
PE
7723 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7724
80f2e268
PE
7725 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7726 to avoid potential buffer overrun.
7727
670741ab
PE
7728 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7729 if X resource line is longer than 512 bytes.
7730
b7163a50
PE
7731 * xfns.c (x_window): Make sprintf buffer a bit bigger
7732 to avoid potential buffer overrun.
7733
ae58ff1f
PE
7734 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7735
c43c8a6a
PE
7736 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7737
3f8236f4
PE
77382011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7739
53e9fe90 7740 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7741 Without these, Emacs silently mishandles large integers sometimes.
7742 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7743 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7744
6511acf2
PE
7745 * xdisp.c (try_window_id): Check Emacs fixnum range before
7746 converting to 'int'.
806add1d 7747
6511acf2 7748 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7749 Check that an Emacs fixnum is in range before assigning it to 'int'.
7750 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7751 values converted from Emacs fixnums.
7752 (Frecenter): Don't wrap around a line count if it is out of 'int'
7753 range; instead, treat it as an extreme value.
7754 (Fset_window_configuration, compare_window_configurations):
7755 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7756
6511acf2
PE
7757 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7758 that can exceed INT_MAX. Check that EMACS_INT value is in range
7759 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7760 (match_limit): Don't assume that a fixnum can fit in 'int'.
7761
6511acf2 7762 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7763 exceed INT_MAX.
7764
6511acf2 7765 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7766 (Fvertical_motion): Don't wrap around LINES values that don't fit
7767 in 'int'. Instead, treat them as extreme values. This is good
7768 enough for windows, which can't have more than INT_MAX lines anyway.
7769
fcb901a7
LMI
77702011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7771
0f2f6b6d
LMI
7772 * Require libxml/parser.h to avoid compilation warning.
7773
fcb901a7
LMI
7774 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7775
7776 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7777 since this reportedly can destroy thread storage.
7778
6e20a0d4
CY
77792011-08-30 Chong Yidong <cyd@stupidchicken.com>
7780
7781 * syntax.c (find_defun_start): Update all cache variables if
7782 exiting early (Bug#9401).
7783
148ae00e
EZ
77842011-08-30 Eli Zaretskii <eliz@gnu.org>
7785
f6cfbd8f
EZ
7786 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7787
148ae00e
EZ
7788 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7789 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7790 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7791
7792 * term.c (tty_append_glyph): New function.
7793 (produce_stretch_glyph): Static function and its prototype deleted.
7794
a66cfb1c
SM
7795 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7796 Add prototypes.
148ae00e 7797
c4a07a4c
PE
77982011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7799
7800 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7801 when checking :margin (Bug#9390).
7802 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7803 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7804 so that the name doesn't mislead. All uses changed.
7805
6bc8cd65
JB
78062011-08-28 Johan Bockgård <bojohan@gnu.org>
7807
7808 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7809 set_tty_hooks.
7810
dca4927e
EZ
78112011-08-27 Eli Zaretskii <eliz@gnu.org>
7812
7813 * xdisp.c (move_it_to): Don't bail out early when reaching
7814 position beyond to_charpos, if we are scanning backwards.
7815 (move_it_vertically_backward): When DY == 0, make sure we get to
7816 the first character in the line after the newline.
7817
f2cad773
PE
78182011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7819
7820 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7821 (ccl_driver): Do not generate an out-of-range pointer.
7822 (Fccl_execute_on_string): Remove unnecessary check for
7823 integer overflow, noted by Stefan Monnier in
7824 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7825 Remove a FIXME that didn't need fixing.
7826 Simplify the newly-introduced buffer reallocation code.
7827
0cae2cdb
JB
78282011-08-27 Juanma Barranquero <lekktu@gmail.com>
7829
7830 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7831
5fc295a4 78322011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7833
70c60eb2 7834 Integer and memory overflow issues (Bug#9196).
726e0ab1 7835
d31850da
PE
7836 * doc.c (get_doc_string): Rework so that
7837 get_doc_string_buffer_size is the actual buffer size, rather than
7838 being 1 less than the actual buffer size; this makes xpalloc more
7839 convenient.
7840
a69fbedb
PE
7841 * image.c (x_allocate_bitmap_record, cache_image):
7842 * xselect.c (Fx_register_dnd_atom):
7843 Simplify previous changes by using xpalloc.
7844
fe5c5d37
PE
7845 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7846 since either will do and ptrdiff_t is convenient with xpalloc.
7847
0065d054
PE
7848 * charset.c (charset_table_size)
7849 (struct charset_sort_data.priority): Now ptrdiff_t.
7850 (charset_compare): Don't overflow if priorities differ greatly.
7851 (Fsort_charsets): Don't assume list length fits in int.
7852 Check for size-calculation overflow when allocating sort data.
7853 (syms_of_charset): Allocate an initial charset table that is
7854 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7855
7856 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7857
7858 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7859 The actual value is always <= INT_MAX, and leaving it unsigned made
7860 overflow checking harder.
7861
7862 * dispextern.h (struct glyph_matrix.rows_allocated)
7863 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7864 with xpalloc. The values are still always <= INT_MAX.
7865
7866 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7867
7868 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7869 (SAFE_NALLOCA): New macro.
7870
7871 * region-cache.c (struct boundary.pos, find_cache_boundary)
7872 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7873 (set_cache_region, invalidate_region_cache)
7874 (revalidate_region_cache, know_region_cache, region_cache_forward)
7875 (region_cache_backward, pp_cache):
7876 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7877 so that ptrdiff_t * can be passed to xpalloc.
7878 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7879 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7880 (pp_cache): Don't assume cache_len fits in int.
7881 * region-cache.h: Adjust extern decls to match.
7882
7883 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7884 EMACS_INT, since either will do, for xpalloc.
7885
7886 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7887 (xnmalloc, xnrealloc, xpalloc): New functions.
7888
726e0ab1
PE
7889 * bidi.c (bidi_shelve_header_size): New constant.
7890 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7891 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7892
51f30bc5 7893 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7894 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7895 (overlay_strings):
7896 Don't update size of array until after memory allocation succeeds,
7897 because xmalloc/xrealloc may not return.
0065d054
PE
7898 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7899 now that we have proper integer overflow checking.
7900 (record_overlay_string, overlay_strings): Catch overflows when
7901 calculating size of overlay_str_buf.
726e0ab1 7902
0065d054
PE
7903 * callproc.c (Fcall_process): Check for size overflow when
7904 calculating size of args2.
7905 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7906 Normally we prefer signed values, but sticking with ptrdiff_t would
7907 require adding more-complicated checks.
726e0ab1
PE
7908
7909 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7910 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7911 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7912 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7913
7914 * character.c (Fstring): Check for size-calculation overflow.
7915
7916 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7917 unnecessary integer overflow. Check for size overflow.
7918 (encode_coding_object): Don't update size until xmalloc succeeds.
7919
7920 * composite.c (get_composition_id): Check for overflow in glyph
7921 length calculations.
7922
7923 Integer and memory overflow fixes for display code.
7924 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7925 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7926 (scrolling_window): Check for overflow in size calculations.
7927 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7928 Don't assume glyph table len fits in int.
7929 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7930 (row_table_size): Now ptrdiff_t, not int.
7931 (scrolling_window): Avoid overflow in size calculations.
7932 Don't update size until allocation succeeds.
7933 * fns.c (concat): Check for overflow in size calculations.
7934 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7935 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7936 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7937
7938 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7939 (get_doc_string): Check for size calculation overflow.
7940 Don't update size until allocation succeeds.
7941 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7942 EMACS_INT, where ptrdiff_t will do.
7943 (Fsubstitute_command_keys): Check for string overflow.
7944
7945 * editfns.c (set_time_zone_rule): Don't assume environment length
7946 fits in int.
7947 (message_length): Now ptrdiff_t, not int.
7948 (Fmessage_box): Don't update size until allocation succeeds.
7949 Don't assume message length fits in int.
7950 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7951
0065d054
PE
7952 * emacs.c (main): Do not reallocate argv, since there is a null at
7953 the end that can be overwritten, and this way there's no need to
7954 worry about size-calculation overflow.
7955 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7956
7957 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7958 alloc succeeds.
7959 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7960
7961 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7962 (x_set_scroll_bar_width, x_figure_window_size):
7963 Check for integer overflow.
7964 (x_set_alpha): Do not assume XINT fits in int.
7965
7966 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7967 This is for the members text_lines, text_cols, total_lines, total_cols,
7968 where the system imposes an 'int' limit.
7969
7970 * fringe.c (Fdefine_fringe_bitmap):
7971 Don't update size until alloc works.
7972
7973 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7974 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7975
7976 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7977 Check for size-calculation overflow.
7978 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7979 do, as we prefer signed integers.
7980 (id_to_widget.max_size, id_to_widget.used)
7981 (xg_store_widget_in_map, xg_remove_widget_from_map)
7982 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7983 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7984 Use and return ptrdiff_t, not int.
7985 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7986 * gtkutil.h: Change prototypes to match the above.
7987
7988 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7989 are duplicate now that they've been promoted to lisp.h.
7990 (x_allocate_bitmap_record, x_alloc_image_color)
7991 (make_image_cache, cache_image, xpm_load):
7992 Don't update size until alloc is done.
7993 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7994 (x_detect_edges):
3256efce 7995 Check for size calculation overflow.
726e0ab1
PE
7996 (ct_colors_allocated_max): New constant.
7997 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7998 overflow.
3256efce 7999
726e0ab1
PE
8000 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8001 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8002 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8003 Use ptrdiff_t, not int, to count maps.
8004 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8005 calculations. Don't update size until allocation succeeds.
8006 Redo calculations to avoid overflow.
726e0ab1
PE
8007 * keyboard.h: Change prototypes to match the above.
8008
8009 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8010 to count maps.
8011 (current_minor_maps): Check for size calculation overflow.
8012 * keymap.h: Change prototypes to match the above.
8013
8014 * lread.c (read1, init_obarray): Don't update size until alloc done.
8015
8016 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8017 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8018
726e0ab1
PE
8019 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8020 Now ptrdiff_t, not int.
8021 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8022 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8023
8024 * process.c (Fnetwork_interface_list): Check for overflow
8025 in size calculation.
8026
8027 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8028
8029 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8030 overflow. Don't bother calling xmalloc when xrealloc will do.
8031
8032 * search.c (Freplace_match): Check for size calculation overflow.
8033 (Fset_match_data): Don't assume list lengths fit in 'int'.
8034
8035 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8036 for command line length. Do not attempt to address one before the
8037 beginning of an array, as that's not portable.
8038
8039 * term.c (max_frame_lines): Remove; unused.
8040 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8041 not int.
8042 (encode_terminal_code, calculate_costs): Check for size
8043 calculation overflow.
8044 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8045 table lengths and related sizes. Don't update size until alloc
8046 done. Redo calculations to avoid overflow.
8047 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8048
8049 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8050 subtracting pointers.
8051 (gobble_line): Check for overflow more carefully. Don't update size
8052 until alloc done.
8053
8054 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8055 Don't update size until alloc done.
8056 Redo size calculations to avoid overflow.
8057 Check for size calculation overflow.
0065d054 8058 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8059
8060 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8061 Use ptrdiff_t, not int, for sizes.
8062 (store_mode_line_noprop_char): Don't update size until alloc done.
8063
0065d054
PE
8064 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8065 Use ptrdiff_t, not int, for sizes.
8066 (Finternal_make_lisp_face, cache_face):
8067 Check for size calculation overflow.
8068 (cache_face): Treat size calculation overflows as if they were
8069 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8070
8071 * xfns.c (x_encode_text, x_set_name_internal)
8072 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8073 sizes, since they can exceed INT_MAX in size. Check for size
8074 calculation overflow.
8075
0065d054
PE
8076 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8077 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8078 Don't update size until alloc done.
8079
0065d054 8080 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8081 as sprintf is limited to int lengths.
1d526e2f 8082
252c5ee1
PE
8083 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8084 (X_LONG_MIN): New macros.
864d7ce7
PE
8085 Use them to make the following changes clearer.
8086 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8087 This change doesn't affect the value now, but it may help remind
8088 future maintainers not to raise the value too much later.
8089 (SELECTION_QUANTUM): Remove, replacing with ...
8090 (selection_quantum): ... new function, which avoids overflow.
8091 All uses changed.
8092 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8093 assumption that selection length fits in 'int'.
8094 (x_reply_selection_request, x_handle_selection_request)
8095 (x_get_window_property, receive_incremental_selection)
8096 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8097 (lisp_data_to_selection_data, clean_local_selection_data):
8098 Use ptrdiff_t, not int, to record length of selection.
8099 (x_reply_selection_request, x_get_window_property)
8100 (receive_incremental_selection, x_property_data_to_lisp):
8101 Redo calculations to avoid overflow.
8102 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8103 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8104 something.
8105 (x_get_window_property, receive_incremental_selection)
8106 (lisp_data_to_selection_data, x_property_data_to_lisp):
8107 Check for size-calculation overflow.
8108 (x_get_window_property, receive_incremental_selection)
8109 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8110 Don't store size until memory allocation succeeds.
8111 (x_get_window_property): Plug memory leak on memory exhaustion.
8112 Don't double-block input; malloc is safe here. Don't assume 2**34
8113 - 4 fits in unsigned long. Add an xassert to check
8114 XGetWindowProperty overflow. Be more careful about overflow
8115 calculations, and distinguish size from memory overflow better.
8116 (receive_incremental_selection): When tracing, don't assume
8117 unsigned int is less than INT_MAX.
8118 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8119 harmful) conversions of unsigned short to int.
8120 (lisp_data_to_selection_data): Don't assume that integers
8121 in the range -65535 through -1 fit in an X unsigned short.
8122 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8123 result parameters unless successful. Rely on cons_to_unsigned
8124 to report problems with elements; the old code wasn't right anyway.
8125 (x_check_property_data): Check for int overflow; we cannot use
8126 a wider type due to X limits.
8127 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8128
726e0ab1 8129 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8130
0065d054
PE
8131 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8132 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8133 (x_color_cells): Don't store size until memory allocation succeeds.
8134 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8135 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8136 (x_term_init): Don't assume length fits in int (sprintf is limited
8137 to int size).
bc18e09d 8138
ebfa62c0
PE
8139 Use ptrdiff_t for composition IDs.
8140 * character.c (lisp_string_width):
8141 * composite.c (composition_table_size, n_compositions)
8142 (get_composition_id, composition_gstring_from_id):
8143 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8144 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8145 * window.c (Frecenter):
8146 Use ptrdiff_t, not int, for composition IDs.
8147 * composite.c (get_composition_id): Check for integer overflow.
8148 * composite.h: Adjust prototypes to match the above changes.
8149
d3411f89
PE
8150 Use ptrdiff_t for hash table indexes.
8151 * category.c (hash_get_category_set):
8152 * ccl.c (ccl_driver):
8153 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8154 * coding.c (coding_system_charset_list, detect_coding_system):
8155 * coding.h (struct coding_system.id):
8156 * composite.c (get_composition_id, gstring_lookup_cache):
8157 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8158 * image.c (xpm_get_color_table_h):
8159 * lisp.h (hash_lookup, hash_put):
8160 * minibuf.c (Ftest_completion):
8161 Use ptrdiff_t for hash table indexes, not int (which is too
8162 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8163 32-bit --with-wide-int hosts).
8164
e097a6fa
PE
8165 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8166 Add a FIXME comment about memory leaks.
8167 (syms_of_charset): Don't assume xmalloc returns.
8168
5637687f
PE
8169 Don't assume that stated character widths fit in int.
8170 * character.c (Fchar_width, c_string_width, lisp_string_width):
8171 * character.h (CHAR_WIDTH):
8172 * indent.c (MULTIBYTE_BYTES_WIDTH):
8173 Use sanitize_char_width to avoid undefined and/or bad behavior
8174 with outlandish widths.
a66cfb1c 8175 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8176 now that we have two such functions. All uses changed.
8177 (sanitize_char_width): New inline function.
8178
a2271ba2
PE
8179 Don't assume that tab-width fits in int.
8180 * character.h (sanitize_width): New inline function.
8181 (SANE_TAB_WIDTH): New macro.
8182 (ASCII_CHAR_WIDTH): Use it.
8183 * indent.c (sane_tab_width): Remove. All uses replaced by
8184 SANE_TAB_WIDTH (current_buffer).
8185 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8186
18c52557
PE
8187 * fileio.c: Integer overflow issues with file modes.
8188 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8189
caeeedc1
PE
8190 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8191 Remove unreachable code.
8192 (read_hex, load_charset_map_from_file): Check for integer overflow.
8193
6df6ae42 8194 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8195 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8196 (x_send_scroll_bar_event): Likewise. Check that the size does not
8197 exceed limits imposed by XClientMessageEvent, as well as the usual
8198 ptrdiff_t and size_t limits.
8199
b13995db
PE
8200 * keyboard.c: Overflow, signedness and related fixes.
8201 (make_lispy_movement): Use same integer type in forward decl
8202 that is used in the definition.
8203 (read_key_sequence, keyremap_step):
8204 Change bufsize argument back to int, undoing my 2011-03-30 change.
8205 We prefer signed types, and int is wide enough here.
8206 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8207 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8208 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8209 length, not size_t. Use ptrdiff_t for index, not int.
8210 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8211 possibility of integer overflow.
8212
13464394
PE
8213 Overflow, signedness and related fixes for images.
8214
8215 * dispextern.h (struct it.stack[0].u.image.image_id)
8216 (struct_it.image_id, struct image.id, struct image_cache.size)
8217 (struct image_cache.used, struct image_cache.ref_count):
8218 * gtkutil.c (update_frame_tool_bar):
8219 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8220 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8221 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8222 * nsmenu.m (update_frame_tool_bar):
8223 * xdisp.c (calc_pixel_width_or_height):
8224 * xfns.c (image_cache_refcount):
8225 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8226 on typical 64-bit hosts.
8227
8228 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8229 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8230 Omit unnecessary casts to int.
8231 (parse_image_spec): Check that integers fall into 'int' range
8232 when the callers expect that.
8233 (image_ascent): Redo ascent calculation to avoid int overflow.
8234 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8235 (lookup_image): Remove unnecessary tests.
8236 (xbm_image_p): Locals are now of int, not EMACS_INT,
8237 since parse_image_check makes sure they fit into int.
8238 (png_load, gif_load, svg_load_image):
8239 Prefer int to unsigned where either will do.
8240 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8241 old tiff_error_handler and tiff_warning_handler.
8242 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8243 stack buffer overflows. It uses only the features of vsnprintf
8244 that are common to both POSIX and native Microsoft.
8245 (tiff_error_handler, tiff_warning_handler): Use it.
8246 (tiff_load, gif_load, imagemagick_load_image):
8247 Don't assume :index value fits in 'int'.
8248 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8249 (imagemagick_load_image): Check that crop parameters fit into
8250 the integer types that MagickCropImage accepts. Don't assume
8251 Vimagemagick_render_type has a nonnegative value. Don't assume
8252 size_t fits in 'long'.
8253 (gs_load): Use printmax_t to print the widest integers possible.
8254 Check for integer overflow when computing image height and width.
8255
c11821d4
EZ
82562011-08-26 Eli Zaretskii <eliz@gnu.org>
8257
8258 * xdisp.c (redisplay_window): Don't force window start if point
8259 will be invisible in the resulting window. (Bug#9324)
8260
0c95fcf7
EZ
82612011-08-25 Eli Zaretskii <eliz@gnu.org>
8262
8263 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8264 the display spec is of the form `(space ...)'.
8265 (handle_display_spec): Return the value returned by
8266 handle_single_display_spec, not just 1 or zero.
8267 (handle_single_display_spec): If the display spec is of the form
8268 `(space ...)', and specifies display in the text area, return 2
8269 rather than 1.
fee65a97 8270 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8271 accurately, and prefer exact match for point under bidi.
8272 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8273
8274 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8275 into disp_prop; all users changed.
8276
8277 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8278 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8279 for the text covered by the display property.
8280
e4ed06f1
CY
82812011-08-25 Chong Yidong <cyd@stupidchicken.com>
8282
8283 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8284 Change return value to nil.
8285 (Frecord_buffer): Delete unused function.
8286
f67cdd7f
EZ
82872011-08-24 Eli Zaretskii <eliz@gnu.org>
8288
5980d4c6
EZ
8289 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8290 buffers, return left-to-right.
8610fe8b
EZ
8291 (set_cursor_from_row): Consider candidate row a win if its glyph
8292 represents a newline and point is on that newline. Fixes cursor
8293 positioning on the newline at EOL of R2L text within L2R
8294 paragraph, and vice versa.
8295 (try_cursor_movement): Check continued rows, in addition to
8296 continuation rows. Fixes unwarranted scroll when point enters a
8297 continued line of R2L text within an L2R paragraph, or vice versa.
8298 (cursor_row_p): Consider the case of point being equal to
8299 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8300 from the end of a short line to the beginning of a continued line
8301 of R2L text within L2R paragraph.
8302 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8303 composed characters.
5980d4c6 8304
f67cdd7f
EZ
8305 * bidi.c (bidi_check_type): Use xassert.
8306 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8307 members.
8308
bca633fb
EZ
83092011-08-23 Eli Zaretskii <eliz@gnu.org>
8310
8311 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8312 a character.
8313
4a5885a7
CY
83142011-08-23 Chong Yidong <cyd@stupidchicken.com>
8315
8316 * nsfont.m (ns_otf_to_script): Fix typo.
8317
0902a04e
KH
83182011-08-22 Kenichi Handa <handa@m17n.org>
8319
8320 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8321 extra slot even if the purpose is char-code-property-table.
8322
1a2e6670
EZ
83232011-08-23 Eli Zaretskii <eliz@gnu.org>
8324
8ddde651
EZ
8325 * xdisp.c (redisplay_window): When computing centering_position,
8326 account for the height of the header line. (Bug#8874)
8327
425cc014
EZ
8328 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8329 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8330 candidate is selected by the mouse, and that candidate has a
8331 composed character under the mouse.
8332
1a2e6670
EZ
8333 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8334 coordinates reported by pos-visible-in-window-p for a composed
8335 character in column zero.
8336
8b76d6f8
SM
83372011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8338
8339 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8340
dac347dd
EZ
83412011-08-22 Eli Zaretskii <eliz@gnu.org>
8342
8343 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8344 consider it a hit if to_charpos is anywhere in the range of the
8345 composed buffer positions.
8346
e013fb34
CY
83472011-08-22 Chong Yidong <cyd@stupidchicken.com>
8348
8349 * image.c (gif_load): Don't assume that each subimage has the same
8350 dimensions as the base image. Handle disposal method that is
8351 "undefined" by the gif spec (Bug#9335).
8352
bd1ba3e8
CY
83532011-08-20 Chong Yidong <cyd@stupidchicken.com>
8354
8355 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8356 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8357
54a1215b
EZ
83582011-08-19 Eli Zaretskii <eliz@gnu.org>
8359
823564e5
EZ
8360 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8361 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8362 from an Org mode buffer to a Speedbar frame.
8363
54a1215b
EZ
8364 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8365 a composition, take its buffer position from IT->cmp_it.charpos.
8366 Fixes cursor positioning at the beginning of a line that begins
8367 with a composed character.
8368
9778ebcc
EZ
83692011-08-18 Eli Zaretskii <eliz@gnu.org>
8370
0be6ee06
EZ
8371 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8372 character bidirectional type, use STRONG_L instead. Fixes crashes
8373 in a buffer produced by `describe-categories'.
8374
9778ebcc
EZ
8375 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8376 members before the level stack, so they would be saved and
8377 restored when copying iterator state. Fixes incorrect reordering
8378 around TABs covered by display properties.
8379
156bffbe
AS
83802011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8381
6b02f655 8382 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8383
72ad093b
CY
83842011-08-17 Chong Yidong <cyd@stupidchicken.com>
8385
8386 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8387 (internal_condition_case_2, internal_condition_case_n):
8388 Remove unnecessary aborts (Bug#9081).
72ad093b 8389
35774242
EZ
83902011-08-17 Eli Zaretskii <eliz@gnu.org>
8391
8392 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8393 has no `load' handler, try opening the file locally. (Bug#9311)
8394
db76dd85
KB
83952011-08-16 Ken Brown <kbrown@cornell.edu>
8396
8397 * gmalloc.c: Expand comment.
8398
b215eee5
EZ
83992011-08-16 Eli Zaretskii <eliz@gnu.org>
8400
8401 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8402 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8403
a4579d33
KB
84042011-08-16 Ken Brown <kbrown@cornell.edu>
8405
8406 Fix memory allocation problems in Cygwin build (Bug#9273).
8407
8408 * unexcw.c ( __malloc_initialized): Declare external variable.
8409 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8410
8b76d6f8
SM
8411 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8412 New variables.
a4579d33
KB
8413 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8414 dumped emacs.
8415 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8416 in the static heap.
8417 [CYGWIN] (special_realloc): New function.
8418 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8419 requests to realloc storage in the static heap.
8420
3ebec551
PE
84212011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8422
8423 * bidi.c (bidi_initialize): Remove unused local.
8424
9fd8be00
EZ
84252011-08-15 Eli Zaretskii <eliz@gnu.org>
8426
6b02f655
SM
8427 * bidimirror.h:
8428 * biditype.h: Remove file.
8429 * makefile.w32-in ($(BLD)/bidi.$(O)):
8430 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8431
8432 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8433
8434 * chartab.c: Improve commentary for the uniprop_table API.
8435
32413314
EZ
8436 * bidi.c (bidi_paragraph_init): Support zero value of
8437 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8438 (bidi_initialize): Use uniprop_table instead of including
8439 biditype.h and bidimirror.h.
32413314 8440
9fd8be00
EZ
8441 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8442 coordinates of the iterator when restoring from ppos_it.
8443 (Bug#9296)
8444
5cf2b69b
KH
84452011-08-14 Kenichi Handa <handa@m17n.org>
8446
8447 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8448 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8449
daf17d00
EZ
84502011-08-14 Eli Zaretskii <eliz@gnu.org>
8451
8452 * xdisp.c (move_it_in_display_line_to): Don't invoke
8453 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8454 ppos_it. Fixes vertical cursor motion when line beginning is
8455 covered by an image. (Bug#9296)
8456
08e3161a
JD
84572011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8458
8459 * nsterm.h (ns_run_ascript): Declare.
8460 (NSAPP_DATA2_RUNASSCRIPT): Define.
8461
8462 * nsfns.m (as_script, as_result, as_status): New static variables.
8463 (ns_run_ascript): New function.
5e617bc2 8464 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8465 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8466 the event loop. Get status from as_status (Bug#7276).
8467
8468 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8469 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8470 the event loop (Bug#7276).
8471
a3720aa2
AS
84722011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8473
8474 * gnutls.c (QCgnutls_bootprop_priority)
8475 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8476 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8477 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8478 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8479 (QCgnutls_bootprop_verify_hostname_error)
8480 (QCgnutls_bootprop_callbacks_verify): Rename from
8481 Qgnutls_bootprop_..., all uses changed.
8482
8483 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8484 uses changed.
8485
0a0d27fb
PE
84862011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8487
19d5c50c
PE
8488 * xfaces.c (Qframe_set_background_mode): Now static.
8489 * dispextern.h (Qframe_set_background_mode): Remove decl.
8490
0a0d27fb
PE
8491 * process.c (Fnetwork_interface_info): Declare local only if needed.
8492
377538cb
JD
84932011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8494
8495 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8496 (Fnetwork_interface_list): Allocate in increments of bytes instead
8497 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8498 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8499 sockaddr.
8500 (struct ifflag_def): notrailers is smart on OSX.
8501 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8502 Get hardware address with getifaddrs if available.
8503
08fff70c
EZ
85042011-08-12 Eli Zaretskii <eliz@gnu.org>
8505
8506 * xdisp.c (iterate_out_of_display_property): xassert that
8507 IT->position is set to within IT->object's boundaries. Break from
8508 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8509 when IT->position is set up wrongly due to some bug.
8510 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8511 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8512 entry. Force push_it to save on the stack the current
8513 buffer/string position, to be restored by pop_it. Fix flags in
8514 the iterator structure wrt the object coming from a display
8515 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8516 properties. (Bug#9284)
8517
7be1c708 85182011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8519
7be1c708
CY
8520 * fontset.c (fontset_get_font_group): Add proper type checks.
8521 (Bug#9172)
aac0c6e3 8522
7be1c708 85232011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8524
7be1c708
CY
8525 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8526 and LC_VERSION_MIN_MACOSX.
8527 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8528 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8529
97bb72a6
EZ
85302011-08-08 Eli Zaretskii <eliz@gnu.org>
8531
8532 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8533 no-display-properties-and-no-overlays under bidi display.
8534 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8535 properties and overlays.
97bb72a6 8536
d5617611
CY
85372011-08-08 Chong Yidong <cyd@stupidchicken.com>
8538
37e11a63
CY
8539 * editfns.c (Fset_time_zone_rule): Document relationship with the
8540 setenv function.
8541
d5617611
CY
8542 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8543 the font entity extracted from the cache (Bug#8109).
8544
58872834
CY
85452011-08-07 Chong Yidong <cyd@stupidchicken.com>
8546
8547 * composite.c (autocmp_chars): Don't reset point. That is done by
8548 restore_point_unwind (Bug#5984).
8549
75bfc667
JL
85502011-08-07 Juri Linkov <juri@jurta.org>
8551
8552 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8553 to show the arg `TIME' instead of `TIMEVAL'.
8554
d1410150
EZ
85552011-08-06 Eli Zaretskii <eliz@gnu.org>
8556
8557 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8558 display property strides EOL and includes a newline, as in
8559 longlines-mode. (Bug#9254)
75b771e4
EZ
8560 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8561 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8562
8563 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8564 is non-zero, even if the data buffer is NULL. Fixes a crash in
8565 vertical-motion with longlines-mode. (Bug#9254)
8566
35928349
EZ
85672011-08-05 Eli Zaretskii <eliz@gnu.org>
8568
ec7cc85b
EZ
8569 * bidi.c <bidi_cache_total_alloc>: Now static.
8570 (bidi_initialize): Initialize bidi_cache_total_alloc.
8571
8b76d6f8 8572 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8573 cache. (Bug#9221)
8574
8575 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8576 amount allocated this far in `bidi_cache_total_alloc'.
8577 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8578 non-zero, only free the data buffer without restoring the cache
8579 contents. All callers changed.
8580
8581 * dispextern.h (bidi_unshelve_cache): Update prototype.
8582
8583 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8584 (move_it_in_display_line, move_it_to)
8585 (move_it_vertically_backward, move_it_by_lines): Replace the call
8586 to xfree to an equivalent call to bidi_unshelve_cache.
8587 (move_it_in_display_line_to): Fix logic of returning
412b6358 8588 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8589
e2e2423b
EZ
85902011-08-05 Eli Zaretskii <eliz@gnu.org>
8591
8592 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8593 came from a string character with a `cursor' property. (Bug#9229)
8594
ae9e757a
JD
85952011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8596
8597 * Makefile.in (LIB_PTHREAD): New variable.
8598 (LIBES): Add LIB_PTHREAD (Bug#9216).
8599
8600 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8601 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8602
213bd7f2
AS
86032011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8604
6b02f655 8605 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8606
99aaf75f
JD
86072011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8608
8609 * xterm.c (x_find_topmost_parent): New function.
8610 (x_set_frame_alpha): Find topmost parent window with
8611 x_find_topmost_parent and set the property there also (bug#9181).
8612 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8613
c74e9d86
PE
86142011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8615
8616 * callproc.c (Fcall_process): Avoid vfork clobbering
8617 the local vars buffer, coding_systems, current_dir.
8618
640c8776
SM
86192011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8620
8621 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8622
f26d0e4c
PE
86232011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8624
8a10d76c
PE
8625 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8626 so that it is not optimized away.
8627
f26d0e4c
PE
8628 * xdisp.c (compute_display_string_pos): Remove unused local.
8629
55439c61
EZ
86302011-08-02 Eli Zaretskii <eliz@gnu.org>
8631
8632 Fix slow cursor motion and scrolling in large buffers with
8633 selective display, like Org Mode buffers. (Bug#9218)
8634
8635 * dispextern.h (struct bidi_it): New member disp_prop_p.
8636
8637 * xdisp.c: Remove one-slot cache of display string positions.
8638 (compute_display_string_pos): Accept an additional argument
5e617bc2 8639 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8640 for a display string or property. If found, set DISP_PROP_P
8641 non-zero.
8642
8643 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8644 DISP_PROP_P, and pass it to compute_display_string_pos.
8645 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8646 non-zero. All callers of bidi_fetch_char changed.
8647
fb33fa43
SM
86482011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8649
8650 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8651
b099e063
DM
86522010-12-03 Don March <don@ohspite.net>
8653
8654 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8655 last character M-[char] is translated to ESC [char] (bug#7541).
8656
5cc7f7af
KH
86572011-08-02 Kenichi Handa <handa@m17n.org>
8658
d0fffa3f 8659 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8660
8661 * chartab.c (uniprop_table): Make it non-static.
8662
525d5e6e
EZ
86632011-08-01 Eli Zaretskii <eliz@gnu.org>
8664
8665 * xdisp.c (forward_to_next_line_start): Accept additional argument
8666 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8667 on the newline.
8668 (reseat_at_next_visible_line_start): Use the bidi iterator state
8669 returned by forward_to_next_line_start to restore the state of
8670 it->bidi_it after backing up to previous newline. (Bug#9212)
8671
31011111
AS
86722011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8673
8674 * regex.c (re_comp): Protoize.
8675 (re_exec): Fix return type.
8676 (regexec): Fix type of `ret'. (Bug#9203)
8677
476371c4
PE
86782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8679
e5d76069
PE
8680 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8681 This is needed if max-image-size is a floating-point number.
8682
9a79b20c
AS
86832011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8684
8685 * print.c (print_object): Print empty symbol as ##.
8686
8687 * lread.c (read1): Read ## as empty symbol.
8688
d8c2fa78
AA
86892011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8690
8691 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8692 setting frame foreground color (Bug#9175).
8693 (x_set_background_color): Likewise.
8694
ffe57a7a
AA
8695 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8696 contents (Bug#9176).
8697 (EmacsTooltip -init): Remove bezels and add shadows to
8698 tooltip windows.
8699
bf3492a5
AA
8700 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8701 or scroll bar (Bug#8470).
8702
d55e9c53
AA
8703 * nsfont.m (nsfont_open): Remove assignment to voffset and
8704 unnecessary vars hshink, expand, hd, full_height, min_height.
8705 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8706
8707 * nsterm.h (nsfont_info): Remove voffset field.
8708
d8c2fa78 87092011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8710
8711 Implement strike-through and overline on NextStep (Bug#8863).
8712
8713 * nsfont.m (nsfont_open): Use underline position provided by font,
8714 instead of hard-coded value of 2.
8715 (nsfont_draw): Call ns_draw_text_decoration instead.
8716
8717 * nsterm.h: Add declaration for ns_draw_text_decoration.
8718
8719 * nsterm.m (ns_draw_text_decoration): New function for drawing
8720 underline, overline, and strike-through.
8721 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8722 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8723 accommodate underlining, etc.
4843aac3 8724
4cc60b9b
EZ
87252011-07-28 Eli Zaretskii <eliz@gnu.org>
8726
bc7ece87
EZ
8727 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8728 default.
4cc60b9b 8729
476371c4
PE
87302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8731
66606eea
PE
8732 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8733 Without this fix, if a signal arrives just after memory fills up,
8734 'malloc' might be invoked reentrantly.
8735
476371c4
PE
8736 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8737 In other words, assume that every image size is allowed, on non-X
8738 hosts. This assumption is probably wrong, but it lets Emacs compile.
8739
f3fcc40d
AS
87402011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8741
8742 * regex.c (re_iswctype): Convert return values to boolean.
8743
350c992f
EZ
87442011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8745
8746 * xdisp.c (compute_display_string_pos): Don't use cached display
8747 string position if the buffer had its restriction changed.
8748 (Bug#9184)
8749
5266b4bb
PE
87502011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8751
8752 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8753
2573a837 87542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8755
41f55ccd 8756 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8757
39e378da
PE
8758 * bidi.c: Integer size and overflow fixes.
8759 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8760 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8761 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8762 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8763 (bidi_find_other_level_edge):
8764 Use ptrdiff_t instead of EMACS_INT where either will do.
8765 This works better on 32-bit hosts configured --with-wide-int.
8766 (bidi_cache_ensure_space): Check for size-calculation overflow.
8767 Use % rather than repeated addition, for better worst-case speed.
8768 Don't set bidi_cache_size until after xrealloc returns, because it
8769 might not return.
8770 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8771 (bidi_cache_ensure_space): Also check that the bidi cache size
8772 does not exceed that of the largest Lisp string or buffer. See Eli
8773 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8774
5e927815
PE
8775 * alloc.c (__malloc_size_t): Remove.
8776 All uses replaced by size_t. See Andreas Schwab's note
8777 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8778
ca4aa935
PE
8779 * image.c: Improve checking for integer overflow.
8780 (check_image_size): Assume that f is nonnull, since
8781 it is always nonnull in practice. This is one less thing to
8782 worry about when checking for integer overflow later.
8783 (x_check_image_size): New function, which checks for integer
8784 overflow issues inside X.
8785 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8786 This removes the need for a memory_full check.
8787 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8788 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8789 (xbm_read_bitmap_data): Change locals back to 'int', since
8790 their values must fit in 'int'.
8791 (xpm_load_image, png_load, tiff_load):
8792 Invoke x_create_x_image_and_pixmap earlier,
8793 to avoid much needless work if the image is too large.
8794 (tiff_load): Treat overly large images as if
8795 x_create_x_image_and_pixmap failed, not as malloc failures.
8796 (gs_load): Use x_check_image_size.
8797
5f8f9cc2
PE
8798 * gtkutil.c: Omit integer casts.
8799 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8800 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8801
5adf60bc
PE
8802 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8803
c8907a93
PE
8804 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8805 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8806 would wrongly return t on a 64-bit host.
8807
e3c25c68
PE
8808 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8809 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8810 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8811 and therefore cause GCC to emit a bogus diagnostic in some cases.
8812
3f791afe
PE
8813 * image.c: Integer signedness and overflow and related fixes.
8814 This is not an exhaustive set of fixes, but it's time to
8815 record what I've got.
8816 (lookup_pixel_color, check_image_size): Remove redundant decls.
8817 (check_image_size): Don't assume that arbitrary EMACS_INT values
8818 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8819 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8820 (tiff_load, imagemagick_load_image):
8821 Check for overflow in size calculations.
8822 (x_create_x_image_and_pixmap): Remove unnecessary test for
8823 xmalloc returning NULL; that can't happen.
8824 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8825 (xpm_color_bucket): Use better integer hashing function.
8826 (xpm_cache_color): Don't possibly over-allocate memory.
8827 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8828 (gif_memory_source):
8829 Use ptrdiff_t, not int or size_t, to record sizes.
8830 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8831 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8832 either works, as we prefer signed integers.
8833 (tiff_read_from_memory, tiff_write_from_memory):
8834 Return tsize_t, not size_t, since that's what the TIFF API wants.
8835 (tiff_read_from_memory): Don't fail simply because the read would
8836 go past EOF; instead, return a short read.
8837 (tiff_load): Omit no-longer-needed casts.
8838 (Fimagemagick_types): Don't assume size fits into 'int'.
8839
3cc5a532
PE
8840 Improve hashing quality when configured --with-wide-int.
8841 * fns.c (hash_string): New function, taken from sxhash_string.
8842 Do not discard information about ASCII character case; this
8843 discarding is no longer needed.
8844 (sxhash-string): Use it. Change sig to match it. Caller changed.
8845 * lisp.h: Declare it.
8846 * lread.c (hash_string): Remove, since we now use fns.c's version.
8847 The fns.c version returns a wider integer if --with-wide-int is
8848 specified, so this should help the quality of the hashing a bit.
8849
b312a492
PE
8850 * emacs.c: Integer overflow minor fix.
8851 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8852 Define only if GNU_LINUX.
8853 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8854
dfd153ae
PE
8855 * dispnew.c: Integer signedness and overflow fixes.
8856 Remove unnecessary forward decls, that were a maintenance hassle.
8857 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8858 All uses changed.
8859 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8860 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8861 (prepare_desired_row, line_draw_cost):
8862 Use int, not unsigned, where either works.
8863 (save_current_matrix, restore_current_matrix):
8864 Use ptrdiff_t, not size_t, where either works.
8865 (init_display): Check for overflow more accurately, and without
8866 relying on undefined behavior.
8867
a81d11a3
PE
8868 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8869 Remove, replacing with the new symbols in lisp.h. All uses changed.
8870 * fileio.c (make_temp_name):
8871 * filelock.c (lock_file_1, lock_file):
8872 * xdisp.c (message_dolog):
8873 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8874 Use pMd etc. instead.
8875 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8876 replacing the pWIDE etc. symbols removed from editfns.c.
8877
3300e6fd
PE
8878 * keyboard.h (num_input_events): Now uintmax_t.
8879 This is (very slightly) less likely to mess up due to wraparound.
8880 All uses changed.
8881
fd05c7e9
PE
8882 * buffer.c: Integer signedness fixes.
8883 (alloc_buffer_text, enlarge_buffer_text):
8884 Use ptrdiff_t rather than size_t when either will do, as we prefer
8885 signed integers.
8886
903fe15d
PE
8887 * alloc.c: Integer signedness and overflow fixes.
8888 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8889 (__malloc_size_t): Default to size_t, not to int.
8890 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8891 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8892 Prefer ptrdiff_t to size_t when either would do, as we prefer
8893 signed integers.
8894 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8895 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8896 Now const. Initialize with values that are in range even if char
8897 is signed.
8898 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8899 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8900 These functions do the right thing with sizes > 2**32.
8901 (check_depth): Now ptrdiff_t, not int.
8902 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8903 Adjust to new way of storing sizes. Check for size overflow bugs
8904 in rest of code.
8905 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8906 slightly wrong anyway, as it missed one instance of
8907 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8908 (refill_memory_reserve): Omit needless cast to size_t.
8909 (mark_object_loop_halt): Mark as externally visible.
8910
ac82cc6a
PE
8911 * xselect.c: Integer signedness and overflow fixes.
8912 (Fx_register_dnd_atom, x_handle_dnd_message):
8913 Use ptrdiff_t, not size_t, since we prefer signed.
8914 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8915 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8916 x_dnd_atoms_size and x_dnd_atoms_length.
8917
c2d1e36d
PE
8918 * doprnt.c: Prefer signed to unsigned when either works.
8919 * eval.c (verror):
8920 * doprnt.c (doprnt):
8921 * lisp.h (doprnt):
8922 * xdisp.c (vmessage):
8923 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8924 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8925 prefer signed arithmetic to avoid comparison confusion.
8926 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8927 but is a bit tricky.
8928
0e926e56
PE
8929 Assume freestanding C89 headers, string.h, stdlib.h.
8930 * data.c, doprnt.c, floatfns.c, print.c:
8931 Include float.h unconditionally.
8932 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8933 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8934 * regex.c: Likewise for stddef.h, string.h.
8935 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8936 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8937 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8938 (STDC_HEADERS): Remove obsolete defines.
8939 * sysdep.c: Include limits.h unconditionally.
8940
9cfdb3ec
PE
8941 Assume support for memcmp, memcpy, memmove, memset.
8942 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8943 * regex.c (memcmp, memcpy):
8944 Remove; we assume C89 now.
8945
8946 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8947 (__malloc_safe_bcopy): Remove; no longer needed.
8948
cf950e6b 8949 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8950 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8951 well either way, and we prefer signed to unsigned.
8952
dbf38e02
LMI
89532011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8954
8955 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8956 closes the connection while we're reading (bug#9182).
8957
d6f0886c 89582011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8959
d6f0886c
JD
8960 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8961 are specified (Bug#9168).
24e0f6b1 8962
2eb1f9e6
PE
89632011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8964
8965 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8966 Found by GCC static checking and --with-wide-int on a 32-bit host.
8967
22381272 89682011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8969
8970 * xdisp.c (compute_display_string_pos): Fix logic of caching
8971 previous display string position. Initialize cached_prev_pos to
8972 -1. Fixes slow-down at the beginning of a buffer.
8973
f25e39b4
EZ
89742011-07-24 Eli Zaretskii <eliz@gnu.org>
8975
8976 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8977 for attrs[LFACE_FONTSET_INDEX].
8978
04c4b52e
PE
89792011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8980
8981 * xml.c (parse_region): Remove unused local
8982 that was recently introduced.
8983
c1734fbd
EZ
89842011-07-23 Eli Zaretskii <eliz@gnu.org>
8985
be18c5a5
EZ
8986 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8987 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8988
c1734fbd
EZ
8989 * xdisp.c (move_it_in_display_line_to): Record the best matching
8990 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8991 exit if none of the characters scanned was an exact match.
8992 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8993 when exact match is impossible due to invisible text, and the
8994 lines are truncated.
8995
a258d627
JD
89962011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8997
8998 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8999 for OSX >= 10.7.
9000
b6d5a689
EZ
90012011-07-22 Eli Zaretskii <eliz@gnu.org>
9002
0f74f785
EZ
9003 Fix a significant slow-down of cursor motion with C-n, C-p,
9004 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9005 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9006 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9007 (next_element_from_buffer): Call compute_stop_pos_backwards to
9008 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9009 base_level_stop.
9010 (reseat): Don't look for prev_stop, as that could mean a very long
9011 run.
9012 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9013 <cached_disp_overlay_modiff>: Cache for last found display string
9014 position.
551918c1 9015 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9016 about the same buffer in the same area of character positions, and
9017 the buffer wasn't changed since the time the display string
9018 position was cached.
551918c1 9019
b2d0c91a
EZ
90202011-07-22 Eli Zaretskii <eliz@gnu.org>
9021
9022 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9023 is an integer, which is important for empty lines. (Bug#9149)
9024
043604ee
CY
90252011-07-22 Chong Yidong <cyd@stupidchicken.com>
9026
9027 * frame.c (Fmodify_frame_parameters): In tty case, update the
9028 default face if necessary (Bug#4238).
9029
da4adb04
CY
90302011-07-21 Chong Yidong <cyd@stupidchicken.com>
9031
9032 * editfns.c (Fstring_to_char): No need to explain what a character
9033 is in the docstring (Bug#6576).
9034
9abd0532
LMI
90352011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9036
9037 * xml.c (parse_region): Make sure we always return a tree.
9038
36881d16
HK
90392011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9040
9041 * xml.c (parse_region): If a document contains only comments,
9042 return that, too.
9043
1e98674d
LMI
90442011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9045
9046 * xml.c (make_dom): Return comments, too.
9047
590bd467
PE
90482011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9049
9050 Port to OpenBSD.
9051 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9052 and the surrounding thread.
9053 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9054 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9055 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9056 timer goes off.
9057 * s/openbsd.h (BROKEN_SIGIO): Define.
9058 * unexelf.c (unexec) [__OpenBSD__]:
9059 Don't update the .mdebug section of the Alpha COFF symbol table.
9060
f41628b2
LMI
90612011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9062
9063 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9064 (bug#8460).
9065
b59b67c5
PE
90662011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9067
15e3a074
PE
9068 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9069 This fixes some race conditions on the permissions of any newly
9070 created file.
9071
41bed37d
PE
9072 * alloc.c (valid_pointer_p): Use pipe, not open.
9073 This fixes some permissions issues when debugging.
9074
b59b67c5
PE
9075 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9076 If fchown fails to set both uid and gid, try to set just gid,
9077 as that is sometimes allowed. Adjust the file's mode to eliminate
9078 setuid or setgid bits that are inappropriate if fchown fails.
9079
925a6be7
SM
90802011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9081
9082 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9083 to compare Lisp_Objects.
9084 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9085 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9086 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9087
52968808
AS
90882011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9089
0a6a104b
AS
9090 * lread.c (read_integer): Unread even EOF character.
9091 (read1): Likewise. Properly record start position of symbol.
9092
52968808
AS
9093 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9094 symbol character follows.
9095
9e381cdd
PE
90962011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9097
9098 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9099 This works around a problem with the previous change to Fcopy_file.
9100 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9101 and without this change, GCC might complain about discarding
9102 fchown's return value.
9103
b5641435
JB
91042011-07-16 Juanma Barranquero <lekktu@gmail.com>
9105
9106 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9107
a8031457
PE
91082011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9109
9110 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9111
dd889327
LMI
91122011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9113
750c33f7
LMI
9114 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9115 it's used from the C level.
9116
dd889327
LMI
9117 * process.c: Use the same condition for POLL_FOR_INPUT in both
9118 keyboard.c and process.c (bug#1858).
9119
87e86684
LM
91202011-07-09 Lawrence Mitchell <wence@gmx.li>
9121
9122 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9123 (Fgnutls_boot): Use it.
9124
64348f40
AS
91252011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9126
9127 * doc.c (Fsubstitute_command_keys): Revert last change.
9128
1d698799
LMI
91292011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9130
f863868c
LMI
9131 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9132 quotes the next character, and doesn't affect other longer
9133 sequences (bug#8935).
9134
1d698799
LMI
9135 * lread.c (syms_of_lread): Clarify that is isn't only
9136 `eval-buffer' and `eval-defun' that's affected by
9137 `lexical-binding' (bug#8460).
9138
aa4b6df6
EZ
91392011-07-15 Eli Zaretskii <eliz@gnu.org>
9140
9141 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9142 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9143
5d856da6
PE
91442011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9145
ad6042bb
PE
9146 Fix minor problems found by static checking.
9147 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9148 (elsz): Now a signed constant, not a size_t var. We prefer signed
9149 types to unsigned, to avoid integer comparison confusion. Without
9150 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9151 "cannot optimize loop, the loop counter may overflow", a symptom
9152 of the confusion.
f00bbb22 9153 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9154 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9155
6468f31c
LMI
91562011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9157
49080b10
LMI
9158 * search.c (Fre_search_backward): Mention `case-fold-search' in
9159 all the re_search_* functions (bug#8138).
9160
6468f31c
LMI
9161 * keyboard.c (Fopen_dribble_file): Document when the file is
9162 closed (bug#8056).
9163
c965adc5
EZ
91642011-07-14 Eli Zaretskii <eliz@gnu.org>
9165
df9733bf
EZ
9166 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9167 bidi_cache_idx.
9168
0bb23927
EZ
9169 Support bidi reordering of display and overlay strings.
9170 * xdisp.c (compute_display_string_pos)
9171 (compute_display_string_end): Accept additional argument STRING.
9172 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9173 (reseat_to_string): Initialize bidi_it->string.s and
9174 bidi_it->string.schars.
9175 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9176 NULL (avoids a crash in bidi_paragraph_init).
9177 Initialize itb.string.lstring.
0bb23927
EZ
9178 (init_iterator): Call bidi_init_it only of a valid
9179 buffer position was specified. Initialize paragraph_embedding to
9180 L2R.
9181 (reseat_to_string): Initialize the bidi iterator.
9182 (display_string): If we need to ignore text properties of
9183 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9184 original value of -1 will not work with bidi.)
9185 (compute_display_string_pos): First arg is now struct
9186 `text_pos *'; all callers changed. Support display properties on
9187 Lisp strings.
9188 (compute_display_string_end): Support display properties on Lisp
9189 strings.
9190 (init_iterator, reseat_1, reseat_to_string): Initialize the
9191 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9192 when iterating on a string not from display properties).
640c8776
SM
9193 (compute_display_string_pos, compute_display_string_end):
9194 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9195 arrow keys.
9196 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9197 base_level_stop; instead, set base_level_stop to BEGV.
9198 Fixes crashes in vertical-motion.
0bb23927
EZ
9199 (next_element_from_buffer): Improve commentary for when
9200 the iterator is before prev_stop.
9201 (init_iterator): Initialize bidi_p from the default value of
9202 bidi-display-reordering, not from buffer-local value. Use the
9203 buffer-local value only if initializing for buffer iteration.
9204 (handle_invisible_prop): Support invisible properties on strings
9205 that are being bidi-reordered.
9206 (set_iterator_to_next): Support bidi reordering of C strings and
9207 Lisp strings.
9208 (next_element_from_string): Support bidi reordering of Lisp
9209 strings.
9210 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9211 (display_string): Support display of R2L glyph rows.
9212 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9213 (init_iterator): Don't initialize it->bidi_p for strings
9214 here.
9215 (reseat_to_string): Initialize it->bidi_p for strings here.
9216 (next_element_from_string, next_element_from_c_string)
9217 (next_element_from_buffer): Add xassert's for correspondence
9218 between IT's object being iterated and it->bidi_it.string
9219 structure.
9220 (face_before_or_after_it_pos): Support bidi iteration.
9221 (next_element_from_c_string): Handle the case of the first string
9222 character that is not the first one in the visual order.
9223 (get_visually_first_element): New function, refactored from common
9224 parts of next_element_from_buffer, next_element_from_string, and
9225 next_element_from_c_string.
9226 (tool_bar_lines_needed, redisplay_tool_bar)
9227 (display_menu_bar): Force left-to-right direction. Add a FIXME
9228 comment for making that be controlled by a user option.
9229 (push_it, pop_it): Save and restore the state of the
9230 bidi iterator. Save and restore the bidi_p flag.
9231 (pop_it): Iterate out of display property for string iteration as
9232 well.
9233 (iterate_out_of_display_property): Support iteration over strings.
9234 (handle_single_display_spec): Set up it->bidi_it for iteration
9235 over a display string, and call bidi_init_it.
9236 (handle_single_display_spec, next_overlay_string)
9237 (get_overlay_strings_1, push_display_prop): Set up the bidi
9238 iterator for displaying display or overlay strings.
9239 (forward_to_next_line_start): Don't use the shortcut if
9240 bidi-iterating.
9241 (back_to_previous_visible_line_start): If handle_display_prop
9242 pushed the iterator stack, restore the internal state of the bidi
9243 iterator by calling bidi_pop_it same number of times.
9244 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9245 and we are bidi-iterating, don't decrement the iterator position;
9246 instead, set the first_elt flag in the bidi iterator, to produce
9247 the same effect.
9248 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9249 (push_display_prop): xassert that we are iterating a buffer.
9250 (push_it, pop_it): Save and restore paragraph_embedding member.
9251 (handle_single_display_spec, next_overlay_string)
9252 (get_overlay_strings_1, reseat_1, reseat_to_string)
9253 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9254 correctly. Don't assume unibyte strings are not bidi-reordered.
9255 (compute_display_string_pos)
9256 (compute_display_string_end): Fix handling the case of C string.
9257 (push_it, pop_it): Save and restore from_disp_prop_p.
9258 (handle_single_display_spec, push_display_prop): Set the
9259 from_disp_prop_p flag.
9260 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9261 (pop_it): Call iterate_out_of_display_property only if we are
9262 popping after iteration over a string that came from a display
9263 property. Fix a typo in popping stretch info. Add an assertion
9264 for verifying that the iterator position is in sync with the bidi
9265 iterator.
9266 (handle_single_display_spec, get_overlay_strings_1)
9267 (push_display_prop): Fix initialization of paragraph direction for
9268 string when that of the parent object is not yet determined.
9269 (reseat_1): Call bidi_init_it to resync the bidi
9270 iterator with IT's position. (Bug#7616)
9271 (find_row_edges): If ROW->start.pos gives position
9272 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9273 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9274 Reset the from_disp_prop_p flag.
9275 (SAVE_IT, RESTORE_IT): New macros.
9276 (pos_visible_p, face_before_or_after_it_pos)
9277 (back_to_previous_visible_line_start)
9278 (move_it_in_display_line_to, move_it_in_display_line)
9279 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9280 (try_scrolling, redisplay_window, display_line): Use them when
9281 saving a temporary copy of the iterator and restoring it back.
9282 (back_to_previous_visible_line_start, reseat_1)
9283 (init_iterator): Empty the bidi cache "stack".
9284 (move_it_in_display_line_to): If iterator ended up at
9285 EOL, but we never saw any buffer positions smaller than
9286 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9287 motion in bidi-reordered lines.
9288 (move_it_in_display_line_to): Record prev_method and prev_pos
9289 immediately before the call to set_iterator_to_next. Fixes cursor
9290 motion in bidi-reordered lines with stretch glyphs and strings
9291 displayed in margins. (Bug#8133) (Bug#8867)
9292 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9293 TO_CHARPOS.
640c8776
SM
9294 (pos_visible_p): Support positions in bidi-reordered lines.
9295 Save and restore bidi cache.
0bb23927
EZ
9296
9297 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9298 (bidi_paragraph_info): Delete unused struct.
9299 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9300 (bidi_cache_start): New variable.
9301 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9302 to zero.
9303 (bidi_cache_fetch_state, bidi_cache_search)
9304 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9305 (bidi_cache_find, bidi_peek_at_next_level)
9306 (bidi_level_of_next_char, bidi_find_other_level_edge)
9307 (bidi_move_to_visually_next): Compare cache index with
9308 bidi_cache_start rather than with zero.
9309 (bidi_fetch_char): Accept new argument STRING; all callers
9310 changed. Support iteration over a string. Support strings with
9311 display properties. Support unibyte strings. Fix the type of
9312 `len' according to what STRING_CHAR_AND_LENGTH expects.
9313 (bidi_paragraph_init, bidi_resolve_explicit_1)
9314 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9315 (bidi_level_of_next_char, bidi_move_to_visually_next):
9316 Support iteration over a string.
0bb23927
EZ
9317 (bidi_set_sor_type, bidi_resolve_explicit_1)
9318 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9319 can now be zero (for strings); special values 0 and -1 were
9320 changed to -1 and -2, respectively.
9321 (bidi_char_at_pos): New function.
9322 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9323 Call it instead of FETCH_MULTIBYTE_CHAR.
9324 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9325 initialized to valid values.
9326 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9327 values.
9328 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9329 the test for valid cached positions. Fix the logic for looking up
9330 the sentinel state in the cache. GCPRO the Lisp string we are
9331 iterating.
9332 (bidi_push_it, bidi_pop_it): New functions.
9333 (bidi_initialize): Initialize the bidi cache start stack pointer.
9334 (bidi_cache_ensure_space): New function, refactored from part of
9335 bidi_cache_iterator_state. Don't assume the required size is just
9336 one BIDI_CACHE_CHUNK away.
9337 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9338 (bidi_count_bytes, bidi_char_at_pos): New functions.
9339 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9340 always valid if bidi_cache_idx is valid.
9341 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9342 is valid if it's going to be used.
9343 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9344 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9345 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9346 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9347 (bidi_find_other_level_edge, bidi_cache_start_stack):
9348 All variables related to cache indices are now EMACS_INT.
c965adc5 9349
0bb23927
EZ
9350 * dispextern.h (struct bidi_string_data): New structure.
9351 (struct bidi_it): New member `string'. Make flag members be 1-bit
9352 fields, and put them last in the struct.
640c8776
SM
9353 (compute_display_string_pos, compute_display_string_end):
9354 Update prototypes.
0bb23927
EZ
9355 (bidi_push_it, bidi_pop_it): Add prototypes.
9356 (struct iterator_stack_entry): New members bidi_p,
9357 paragraph_embedding, and from_disp_prop_p.
9358 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9359 (bidi_shelve_cache, bidi_unshelve_cache):
9360 Declare prototypes.
0bb23927
EZ
9361
9362 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9363 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9364 and vector-like objects.
9365
9366 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9367 cache around display iteration.
9368
9369 * window.c (Fwindow_end, window_scroll_pixel_based)
9370 (displayed_window_lines, Frecenter): Save and restore the bidi
9371 cache around display iteration.
9372
3bbd2265
LMI
93732011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9374
9375 * editfns.c (Fdelete_region): Clarify the use of the named
9376 parameters (bug#6788).
9377
adc47434
MR
93782011-07-14 Martin Rudalics <rudalics@gmx.at>
9379
9380 * indent.c (Fvertical_motion): Set and restore w->pointm when
9381 saving and restoring the window's buffer (Bug#9006).
9382
837c31f8
LMI
93832011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9384
9385 * editfns.c (Fstring_to_char): Clarify just what is returned
9386 (bug#6576). Text by Eli Zaretskii.
9387
ac389d0c
JB
93882011-07-13 Juanma Barranquero <lekktu@gmail.com>
9389
9390 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9391
0be0ce47
EZ
93922011-07-13 Eli Zaretskii <eliz@gnu.org>
9393
9394 * buffer.c (mmap_find): Fix a typo.
9395
cd18e7e3
JB
93962011-07-13 Johan Bockgård <bojohan@gnu.org>
9397
9398 Fix execution of x selection hooks.
9399 * xselect.c (Qx_lost_selection_functions)
9400 (Qx_sent_selection_functions): New vars.
9401 (syms_of_xselect): DEFSYM them.
9402 (x_handle_selection_request): Pass Qx_sent_selection_functions
9403 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9404 (x_handle_selection_clear,x_clear_frame_selections):
9405 Pass Qx_lost_selection_functions rather than
9406 Vx_lost_selection_functions to Frun_hook_with_args.
9407
47ea7f44
PE
94082011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9409
ac389d0c 9410 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9411 The old code sometimes used this field without initializing it.
9412
47ea7f44
PE
9413 * alloc.c (gc_sweep): Don't read past end of array.
9414 In theory, the old code could also have corrupted Emacs internals,
9415 though it'd be very unlikely.
9416
bc985c87
AS
94172011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9418
9419 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9420 argument. (Bug#4026)
bc985c87 9421
0cf34688
LMI
94222011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9423
b3dadd76
LMI
9424 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9425 key" (bug#4257).
9426
0cf34688
LMI
9427 * window.c (Fset_window_start): Doc fix (bug#4199).
9428 (Fset_window_hscroll): Ditto.
9429
270768cd
PE
94302011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9431
077e3dda 9432 Fix minor new problems caught by GCC 4.6.1.
270768cd 9433 * term.c (init_tty): Remove unused local.
490011a6 9434 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9435 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9436 not used otherwise.
270768cd 9437
b1f58454
CY
94382011-07-12 Chong Yidong <cyd@stupidchicken.com>
9439
9440 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9441
22b9578d
LMI
94422011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9443
6e70ab07
LMI
9444 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9445 are the mini-buffer and the echo area (bug#3320).
9446
22b9578d
LMI
9447 * term.c (init_tty): Remove support for supdup, c10 and perq
9448 terminals, which are no longer supported (bug#1482).
9449
8974cc9f
JB
94502011-07-10 Johan Bockgård <bojohan@gnu.org>
9451
9452 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9453
a560d974
JD
94542011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9455
9456 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9457 for non-popups (Bug#3642).
9458
1dae0f0a
AS
94592011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9460
268c2c36 9461 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9462 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9463 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9464 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9465 * data.c (fmod): Likewise.
9466 * dispnew.c (swap_glyphs_in_rows): Likewise.
9467 * emacs.c (memory_warning_signal): Likewise.
9468 * floatfns.c (float_error): Likewise.
9469 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9470 (otf_open, font_otf_capability, generate_otf_features)
9471 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9472 Likewise.
9473 * image.c (pbm_read_file): Likewise.
9474 * indent.c (string_display_width): Likewise.
9475 * intervals.c (check_for_interval, search_for_interval)
9476 (inc_interval_count, count_intervals, root_interval)
9477 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9478 * lread.c (defalias): Likewise.
268c2c36 9479 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9480 * regex.c (set_image_of_range_1, set_image_of_range)
9481 (regex_grow_registers): Likewise.
9482 * sysdep.c (strerror): Likewise.
9483 * termcap.c (valid_filename_p, tprint, main): Likewise.
9484 * tparam.c (main): Likewise.
9485 * unexhp9k800.c (run_time_remap, save_data_space)
9486 (update_file_ptrs, read_header, write_header, calculate_checksum)
9487 (copy_file, copy_rest, display_header): Likewise.
9488 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9489 Likewise.
9490 * xdisp.c (check_it): Likewise.
9491 * xfaces.c (register_color, unregister_color, unregister_colors):
9492 Likewise.
9493 * xfns.c (print_fontset_result): Likewise.
9494 * xrdb.c (member, fatal, main): Likewise.
9495
99033785
PE
94962011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9497
9498 Fix minor problems found by static checking (Bug#9031).
9499 * chartab.c (char_table_set_range, map_sub_char_table):
9500 Remove unused locals.
9501 (uniprop_table): Now static.
9502 * composite.c (_work_char): Remove unused static var.
9503
9cb2ac56
JB
95042011-07-09 Juanma Barranquero <lekktu@gmail.com>
9505
9506 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9507
f25661f0
JD
95082011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9509
9510 * gtkutil.c (qttip_cb): Remove code without function.
9511
8278c4fe
EZ
95122011-07-09 Eli Zaretskii <eliz@gnu.org>
9513
9514 * w32.c (pthread_sigmask): New stub.
9515
1692ae2d 95162011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9517
8a6ebd58 9518 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9519 sigprocmask is portable only for single-threaded applications, and
9520 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9521 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9522 (LIBES): Use it.
9523 * callproc.c (Fcall_process):
9524 * process.c (create_process):
9525 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9526 Use pthread_sigmask, not sigprocmask.
123403e4 9527
1b854618
JD
95282011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9529
9530 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9531 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9532 wrong (Bug#8591).
9533
3fe4b549
JD
95342011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9535
0ce7e563
JD
9536 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9537 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9538 (xg_hide_tooltip): Fix comment.
9539
3fe4b549
JD
9540 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9541 in registerServicesMenuSendTypes.
9542 (validRequestorForSendType): Don't check ns_return_types.
9543
9544 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9545 ns_return_type.
9546
5df75e47
JR
95472011-07-08 Jason Rumney <jasonr@gnu.org>
9548
22610910
JR
9549 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9550 SH_SHOW for hidden windows (Bug#5482).
9551
5df75e47
JR
9552 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9553 frame struct members of non-existent frames (Bug#6284).
9554
699c10bd
JD
95552011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9556
4393663b
JD
9557 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9558 variable firstTime not needed on OSX >= 10.6.
9559 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9560 >= 10.5. Use setKnobProportion, setDoubleValue.
9561
9562 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9563 (MAC_OS_X_VERSION_10_5): Define if not defined.
9564 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9565 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9566 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9567
9568 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9569 cString and lossyCString on OSX >= 10.4.
4393663b 9570
58179cce 9571 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9572 sizeToFit on OSX >= 10.2.
9573
9574 * nsimage.m (allocInitFromFile): Don't use deprecated method
9575 bestRepresentationForDevice on OSX >= 10.6.
9576
9577 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9578 to avoid warning.
9579
9580 * emacs.c: Declare unexec_init_emacs_zone.
9581
a63e0781
JD
9582 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9583
699c10bd
JD
9584 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9585
9586 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9587 on svcsMenu (Bug#8842).
9588
9589 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9590 ns_return_types.
9591 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9592
9593 * nsterm.m (QUTF8_STRING): Declare.
9594 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9595 (validRequestorForSendType): Return type is (id).
9596 Change indexOfObjectIdenticalTo to indexOfObject.
9597 Check if we have local selection before returning self (Bug#8842).
9598 (writeSelectionToPasteboard): Put local selection into paste board
9599 if we have a local selection (Bug#8842).
9600 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9601
9602 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9603 (ns_get_local_selection): Declare.
9604
54e10184
LMI
96052011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9606
9888ff71
LMI
9607 * keymap.c (describe_map_tree): Don't insert a double newline at
9608 the end of the buffer (bug#1169) and return whether we inserted
9609 something.
9610
54e10184
LMI
9611 * callint.c (Fcall_interactively): Change "reading args" to
9612 "providing args" to try to clarify what it does (bug#1010).
9613
15fa4783
KH
96142011-07-07 Kenichi Handa <handa@m17n.org>
9615
9616 * composite.c (composition_compute_stop_pos): Ignore a static
9617 composition starting before CHARPOS (Bug#8915).
9618
9619 * xdisp.c (handle_composition_prop): Likewise.
9620
a8815b00
EZ
96212011-07-07 Eli Zaretskii <eliz@gnu.org>
9622
9623 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9624 (Bug#9015)
9625
ef7b981d 96262011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9627
9628 * character.h (unicode_category_t): New enum type.
9629
9630 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9631 (Qchar_code_property_table): New variable.
9632 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9633 (UNIPROP_COMPRESSED_FORM_P): New macros.
9634 (char_table_ascii): Uncompress the compressed values.
9635 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9636 Uncompress the compressed values.
ac389d0c 9637 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9638 (char_table_ref_and_range): Uncompress the compressed values.
9639 (sub_char_table_set): New arg is_uniprop. Callers changed.
9640 Uncompress the compressed values.
9641 (sub_char_table_set_range): Args changed. Callers changed.
9642 (char_table_set_range): Adjuted for the above change.
9643 (map_sub_char_table): Delete args default_val and parent. Add arg
9644 top. Give decoded values to a Lisp function.
640c8776 9645 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9646 values to a Lisp function. Gcpro more variables.
9647 (uniprop_table_uncompress)
9648 (uniprop_decode_value_run_length): New functions.
9649 (uniprop_decoder, uniprop_decoder_count): New variables.
9650 (uniprop_get_decoder, uniprop_encode_value_character)
9651 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9652 New functions.
9653 (uniprop_encoder, uniprop_encoder_count): New variables.
9654 (uniprop_get_encoder, uniprop_table)
9655 (Funicode_property_table_internal, Fget_unicode_property_internal)
9656 (Fput_unicode_property_internal): New functions.
9657 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9658 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9659 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9660 char-code-property-alist.
9661
640c8776 9662 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9663 Vunicode_category_table.
9664
640c8776 9665 * font.c (font_range): Adjust for the change of
c805dec0
KH
9666 Vunicode_category_table.
9667
76b397fb
DN
96682011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9669
9670 * m/iris4d.h: Remove file, move contents ...
9671 * s/irix6-5.h: ... here.
9672
22b4128e
PE
96732011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9674
9675 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9676 * alloc.c (mark_buffer):
9677 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9678 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9679 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9680 This isn't true in general, and it's particularly not true
9681 if Emacs is configured with --with-wide-int.
9682 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9683 New macros, used in the buffer.c change.
9684
869795d6
JD
96852011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9686
9687 * xsettings.c: Use both GConf and GSettings if both are available.
9688 (store_config_changed_event): Add comment.
9689 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9690 (store_tool_bar_style_changed): New functions.
5e617bc2 9691 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9692 (struct xsettings): Move font inside HAVE_XFT.
9693 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9694 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9695 Move inside HAVE_XFT.
640c8776 9696 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9697 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9698 also.
9699 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9700 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9701 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9702 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9703 (parse_settings): Move check for font inside HAVE_XFT.
9704 (read_settings, apply_xft_settings): Add comment.
9705 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9706 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9707 call store_font_name_changed.
9708 (xft_settings_event): Add comment.
9709 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9710 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9711 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9712 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9713 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9714 (xsettings_get_system_font, xsettings_get_system_normal_font):
9715 Add comment.
869795d6 9716
d8ed26bd
PE
97172011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9718
9719 Random fixes. E.g., (random) never returned negative values.
9720 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9721 subseconds part to the entropy, as that's a bit more random.
9722 Prefer signed to unsigned, since the signedness doesn't matter and
9723 in general we prefer signed. When given a limit, use a
9724 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9725 latter isn't right if USE_2_TAGS_FOR_INTS.
9726 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9727 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9728
cabf1cac
SM
97292011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9730
9731 * textprop.c (text_property_stickiness):
9732 Obey Vtext_property_default_nonsticky.
9733 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9734 * w32fns.c (syms_of_w32fns):
9735 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9736
6e9b2be9
PE
97372011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9738
9739 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9740 This is more efficient than Ffile_directory_p and avoids a minor race.
9741
90186c68
LMI
97422011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9743
7c301272
LMI
9744 * buffer.c (Foverlay_put): Say what the return value is
9745 (bug#7835).
9746
c4f2d8d4
LMI
9747 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9748 is a directory before asking whether to use the file name
9749 (bug#7564).
ad637907
LMI
9750 (barf_or_query_if_file_exists): Make the "File is a directory"
9751 error be more correct.
c4f2d8d4 9752
90186c68
LMI
9753 * fns.c (Frequire): Remove the mention of the .gz files, since
9754 that's installation-specific, but keep the mention of
9755 `get-load-suffixes'.
9756
da64016e
PE
97572011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9758
9759 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9760 Report string overflow if the output is too long.
9761
7d47b580
JB
97622011-07-04 Juanma Barranquero <lekktu@gmail.com>
9763
a555cb87
JB
9764 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9765 (syms_of_gnutls): Remove duplicate DEFSYM for
9766 Qgnutls_bootprop_verify_hostname_error, an error for
9767 Qgnutls_bootprop_verify_error (which is no longer used).
9768
7d47b580
JB
9769 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9770 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9771 Also (re)move comments that are misplaced or no longer relevant.
9772
1e49bfab
LMI
97732011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9774
9775 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9776
1485f4c0
CY
97772011-07-03 Chong Yidong <cyd@stupidchicken.com>
9778
9779 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9780 and background color parameters if they have been changed.
9781
a9ab721e
LMI
97822011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9783
9784 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9785
cf7cff57
PE
97862011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9787
2e13213d
PE
9788 * xsettings.c (SYSTEM_FONT): Define only when used.
9789 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9790
cf7cff57
PE
9791 * keymap.c (access_keymap_1): Now static.
9792
7a8e04f7
CY
97932011-07-02 Chong Yidong <cyd@stupidchicken.com>
9794
9795 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9796 leave any prefix arg for the up event (Bug#1586).
9797
61352f62
LMI
97982011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9799
69bb1ef7
LMI
9800 * lread.c (syms_of_lread): Mention single symbols defined by
9801 `defvar' or `defconst' (bug#7154).
9802
61352f62 9803 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9804 (Frequire): Mention get-load-suffixes.
61352f62 9805
28545e04
MR
98062011-07-02 Martin Rudalics <rudalics@gmx.at>
9807
9808 * window.h (window): Remove clone_number slot.
9809 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9810 Remove.
9811 (make_parent_window, make_window, saved_window)
9812 (Fset_window_configuration, save_window_save): Don't deal with
9813 clone numbers.
9814 * buffer.c (Qclone_number): Remove declaration.
9815 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9816
3349e122
SM
98172011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9818
9819 Add multiple inheritance to keymaps.
9820 * keymap.c (Fmake_composed_keymap): New function.
9821 (Fset_keymap_parent): Simplify.
9822 (fix_submap_inheritance): Remove.
9823 (access_keymap_1): New function extracted from access_keymap to handle
9824 embedded parents and handle lists of maps.
9825 (access_keymap): Use it.
9826 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9827 (Fcopy_keymap): Handle embedded parents.
9828 (Fcommand_remapping, define_as_prefix): Simplify.
9829 (Fkey_binding): Simplify.
9830 (syms_of_keymap): Move minibuffer-local-completion-map,
9831 minibuffer-local-filename-completion-map,
9832 minibuffer-local-must-match-map, and
9833 minibuffer-local-filename-must-match-map to Elisp.
9834 (syms_of_keymap): Defsubr make-composed-keymap.
9835 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9836 (parse_menu_item): Trivial simplification.
9837
3279eb87
GM
98382011-07-01 Glenn Morris <rgm@gnu.org>
9839
9840 * Makefile.in (SETTINGS_LIBS): Fix typo.
9841
4550efdf
KI
98422011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9843
9844 * coding.c (Fencode_coding_string): Record the last coding system
9845 used, as the function doc string says (bug#8738).
9846
0949d2b6
JD
98472011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9848
9849 * xsettings.c (store_monospaced_changed): Take new font as arg and
9850 check for change against current_mono_font.
9851 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9852 (emacs_settings_constructor, emacs_settings_get_property)
9853 (emacs_settings_set_property, emacs_settings_class_init)
9854 (emacs_settings_init, gsettings_obj): Remove.
9855 (something_changedCB): New function for HAVE_GSETTINGS.
9856 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9857 with value as argument.
9858 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9859 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9860 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9861 "changed".
9862
9863 * xgselect.c: Add defined (HAVE_GSETTINGS).
9864 (xgselect_initialize): Ditto.
9865
9866 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9867 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9868 xg_select.
9869
bbc6b304
PE
98702011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9871
9872 * eval.c (struct backtrace): Simplify and port the data structure.
9873 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9874 signed bit field, as this assumption is not portable and it makes
9875 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9876 "char debug_on_exit : 1" as this is not portable either; instead,
9877 use the portable "unsigned int debug_on_exit : 1". Remove unused
9878 member evalargs. Remove obsolete comments about cc bombing out.
9879
9851bfc5
JD
98802011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9881
51bb811f 9882 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9883 Let HAVE_GSETTINGS override HAVE_GCONF.
9884 (store_monospaced_changed): New function.
9885 (EMACS_SETTINGS): A new type derived from GObject to handle
9886 GSettings notifications.
9887 (emacs_settings_constructor, emacs_settings_get_property)
9888 (emacs_settings_set_property, emacs_settings_class_init):
9889 New functions.
9890 (gsettings_client, gsettings_obj): New variables.
9891 (GSETTINGS_SCHEMA): New define.
9892 (something_changedCB): Call store_monospaced_changed.
9893 (init_gsettings): New function.
9894 (xsettings_initialize): Call init_gsettings.
9895 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9896 to NULL.
9897
640c8776 9898 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9899 GCONF_CFLAGS/LIBS.
9900
5386012d
MR
99012011-06-29 Martin Rudalics <rudalics@gmx.at>
9902
9903 * window.c (resize_root_window, grow_mini_window)
9904 (shrink_mini_window): Rename Qresize_root_window to
9905 Qwindow_resize_root_window and Qresize_root_window_vertically to
9906 Qwindow_resize_root_window_vertically.
9907
f13e0b08
PE
99082011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9909
9910 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9911
94515237
JB
99122011-06-27 Juanma Barranquero <lekktu@gmail.com>
9913
9914 * makefile.w32-in: Redesign dependencies so they reflect more
9915 clearly which files are directly included by each source file,
9916 and not through other includes.
9917
e43b6e43
MR
99182011-06-27 Martin Rudalics <rudalics@gmx.at>
9919
9920 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9921 (sort_overlays, overlay_strings): When an overlay's clone number
9922 matches the window's clone number process the overlay even if
9923 the overlay's window property doesn't match the current window.
9924
d68443dc
MR
9925 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9926 (Fwindow_hchild): Rename to Fwindow_left_child.
9927 (Fwindow_next): Rename to Fwindow_next_sibling.
9928 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9929 (resize_window_check): Rename to window_resize_check.
9930 (resize_window_apply): Rename to window_resize_apply.
9931 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9932 (Fdelete_other_windows_internal, resize_frame_windows)
9933 (Fsplit_window_internal, Fdelete_window_internal)
9934 (grow_mini_window, shrink_mini_window)
9935 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9936
c7e73be5
JD
99372011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9938
9939 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9940 (emacs_fixed_set_min_size): Remove.
9941 (emacs_fixed_new): Take frame as argument.
9942
9943 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9944 (_EmacsFixedPrivate): Remove minwidth/height.
9945 Add struct frame *f.
9946 (emacs_fixed_init): Initialize priv->f.
9947 (get_parent_class, emacs_fixed_set_min_size): Remove.
9948 (emacs_fixed_new): Set priv->f to argument.
9949 (emacs_fixed_get_preferred_width)
9950 (emacs_fixed_get_preferred_height): Use min_width/height from
9951 frames size_hint to set minimum and natural (Bug#8919).
9952 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9953 and use min_width/height from frames size_hint to set
9954 min_width/height (Bug#8919).
9955
9956 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9957 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9958 Fix indentation.
c7e73be5 9959
cf99dcf8
EZ
99602011-06-26 Eli Zaretskii <eliz@gnu.org>
9961
9962 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9963 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9964 called at ZV.
9965
029529ac
CY
99662011-06-26 Chong Yidong <cyd@stupidchicken.com>
9967
9968 * process.c (wait_reading_process_output): Bypass select if
9969 waiting for a cell while ignoring keyboard input, and input is
9970 pending. Suggested by Jan Djärv (Bug#8869).
9971
7a7ef429
PE
99722011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9973
9974 Use gnulib's dup2 module instead of rolling our own.
9975 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9976
11fdef7d 99772011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9978
9979 * dispnew.c (scrolling_window): Before scrolling, turn off a
9980 mouse-highlight in the window being scrolled.
9981
cd3520a4
JB
99822011-06-24 Juanma Barranquero <lekktu@gmail.com>
9983
9984 Move DEFSYM to lisp.h and use everywhere.
9985
9986 * character.h (DEFSYM): Move declaration...
9987 * lisp.h (DEFSYM): ...here.
9988
9989 * gnutls.c:
9990 * minibuf.c:
9991 * w32menu.c:
9992 * w32proc.c:
9993 * w32select.c: Don't include character.h.
9994
9995 * alloc.c (syms_of_alloc):
9996 * buffer.c (syms_of_buffer):
9997 * bytecode.c (syms_of_bytecode):
9998 * callint.c (syms_of_callint):
9999 * casefiddle.c (syms_of_casefiddle):
10000 * casetab.c (init_casetab_once):
10001 * category.c (init_category_once, syms_of_category):
10002 * ccl.c (syms_of_ccl):
10003 * cmds.c (syms_of_cmds):
10004 * composite.c (syms_of_composite):
10005 * dbusbind.c (syms_of_dbusbind):
10006 * dired.c (syms_of_dired):
10007 * dispnew.c (syms_of_display):
10008 * doc.c (syms_of_doc):
10009 * editfns.c (syms_of_editfns):
10010 * emacs.c (syms_of_emacs):
10011 * eval.c (syms_of_eval):
10012 * fileio.c (syms_of_fileio):
10013 * fns.c (syms_of_fns):
10014 * frame.c (syms_of_frame):
10015 * fringe.c (syms_of_fringe):
10016 * insdel.c (syms_of_insdel):
10017 * keymap.c (syms_of_keymap):
10018 * lread.c (init_obarray, syms_of_lread):
10019 * macros.c (syms_of_macros):
10020 * msdos.c (syms_of_msdos):
10021 * print.c (syms_of_print):
10022 * process.c (syms_of_process):
10023 * search.c (syms_of_search):
10024 * sound.c (syms_of_sound):
10025 * syntax.c (init_syntax_once, syms_of_syntax):
10026 * terminal.c (syms_of_terminal):
10027 * textprop.c (syms_of_textprop):
10028 * undo.c (syms_of_undo):
10029 * w32.c (globals_of_w32):
10030 * window.c (syms_of_window):
10031 * xdisp.c (syms_of_xdisp):
10032 * xfaces.c (syms_of_xfaces):
10033 * xfns.c (syms_of_xfns):
10034 * xmenu.c (syms_of_xmenu):
10035 * xsettings.c (syms_of_xsettings):
10036 * xterm.c (syms_of_xterm): Use DEFSYM.
10037
4228cf16
TZ
100382011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10039
cd3520a4 10040 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10041
7fcccf1e
PE
100422011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10043
7efb4e0e
PE
10044 Integer and buffer overflow fixes (Bug#8873).
10045
ff5844ad
PE
10046 * print.c (printchar, strout): Check for string overflow.
10047 (PRINTPREPARE, printchar, strout):
10048 Don't set size unless allocation succeeds.
10049
90532f02
PE
10050 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10051 for sizes. Check for string overflow more accurately.
10052 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10053
6d84508d
PE
10054 * macros.c: Integer and buffer overflow fixes.
10055 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10056 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10057 Use ptrdiff_t, not int, for sizes.
10058 Don't increment bufsize until after realloc succeeds.
10059 Check for size-calculation overflow.
10060 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10061
437b2cb4
PE
10062 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10063
8b9ac8b4
PE
10064 * lread.c: Integer overflow fixes.
10065 (read_integer): Radix is now EMACS_INT, not int,
10066 to improve quality of diagnostics for out-of-range radices.
10067 Calculate buffer size correctly for out-of-range radices.
10068 (read1): Check for integer overflow in radices, and in
10069 read-circle numbers.
82cb60d3
PE
10070 (read_escape): Avoid int overflow.
10071 (Fload, openp, read_buffer_size, read1)
10072 (substitute_object_recurse, read_vector, read_list, map_obarray):
10073 Use ptrdiff_t, not int, for sizes.
10074 (read1): Use EMACS_INT, not int, for sizes.
20270765 10075 Check for size overflow.
8b9ac8b4 10076
7fcccf1e
PE
10077 * image.c (cache_image): Check for size arithmetic overflow.
10078
bfbbd7e7
PE
10079 * lread.c: Integer overflow issues.
10080 (saved_doc_string_size, saved_doc_string_length)
10081 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10082 Now ptrdiff_t, not int.
10083 (read1): Don't assume doc string length fits in int. Check for
10084 out-of-range doc string lengths.
10085 (read_list): Don't assume file position fits in int.
39019e54 10086 (read_escape): Check for hex character overflow.
bfbbd7e7 10087
4e323265
LL
100882011-06-22 Leo Liu <sdl.web@gmail.com>
10089
10090 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10091 Move to minibuffer.el.
10092
85fece3e
PE
100932011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10094
20b84ce9 10095 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10096 The following patches are for when GLYPH_DEBUG && !XASSERT.
10097 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10098 * dispnew.c (flush_stdout):
10099 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10100 Mark as externally visible.
10101 * dispnew.c (check_window_matrix_pointers): Now static.
10102 * dispnew.c (window_to_frame_vpos):
10103 * xfns.c (unwind_create_frame):
10104 * xterm.c (x_check_font): Remove unused local.
10105 * scroll.c (CHECK_BOUNDS):
10106 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10107 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10108 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10109 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10110 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10111 Now static.
10112 (debug_method_add): Use va_list and vsprintf rather than relying
10113 on undefined behavior with wrong number of arguments.
10114 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10115 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10116 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10117 since we're not interested in debugging glyphs with old libraries.
10118 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10119 GCC 4.6.0's static checking.
10120
0766b489
PE
101212011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10122
31fd4b32
PE
10123 Integer overflow and signedness fixes (Bug#8873).
10124 A few related buffer overrun fixes, too.
10125
b79e8648
PE
10126 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10127
0766b489
PE
10128 * dispextern.h (struct face.stipple):
10129 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10130 (x_bitmap_mask, x_allocate_bitmap_record)
10131 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10132 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10133 (x_create_bitmap_from_xpm_data):
10134 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10135 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10136 (.bitmaps_last):
10137 * xfaces.c (load_pixmap):
10138 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10139 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10140 (.bitmaps_last, struct x_output.icon_bitmap):
10141 Use ptrdiff_t, not int, for bitmap indexes.
10142 (x_allocate_bitmap_record): Check for size overflow.
10143 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10144
b081724f
PE
10145 Use ptrdiff_t, not int, for overlay counts.
10146 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10147 * editfns.c (overlays_around, get_pos_property):
10148 * textprop.c (get_char_property_and_overlay):
10149 * xdisp.c (next_overlay_change, note_mouse_highlight):
10150 * xfaces.c (face_at_buffer_position):
21514da7
PE
10151 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10152 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10153 (Fnext_overlay_change, Fprevious_overlay_change)
10154 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10155 Use ptrdiff_t, not int, for sizes.
21514da7 10156 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10157
3de73e5e
PE
10158 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10159
2606c57b
PE
10160 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10161 (x_session_initialize): Do not assume string length fits in int.
10162
aaafe47a
PE
10163 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10164 This is unlikely, but can occur if DPI is outlandish.
10165
2674ddc8 10166 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10167 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10168
28154962
PE
10169 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10170 * xrdb.c (magic_file_p, search_magic_path):
10171 Omit last arg SUFFIX; it was always 0. All callers changed.
10172 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10173
7de51af5
PE
10174 * xfont.c (xfont_match): Avoid need for strlen.
10175
25ed6cc3
PE
10176 * xfns.c: Don't assume strlen fits in int.
10177 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10178
4eab31dd
PE
10179 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10180 not unsigned long, as we prefer signed integers. All callers changed.
10181 Detect integer overflow in repeat count.
10182 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10183 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10184
171e2a58
PE
10185 * termcap.c: Don't assume sizes fit in int and never overflow.
10186 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10187 (gobble_line): Check for size-calculation overflow.
10188
ad39faca 10189 * minibuf.c (Fread_buffer):
6e5bb2dc 10190 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10191 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10192 Don't assume string length fits in int.
10193
52c61c22 10194 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10195 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10196
b5b8c9e5
PE
10197 * font.c: Don't assume string length fits in int.
10198 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10199 Use ptrdiff_t, not int.
ccd6111c
PE
10200 (font_intern_prop): Don't assume string length fits in int.
10201 Don't assume integer property fits in fixnum.
10202 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10203
882f0d81 10204 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10205 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10206 Reformulate so as not to need the command string.
10207 Invoke gzip -cd rather than gunzip, as it's more portable.
10208 (lock_info_type, lock_file_1, lock_file):
10209 Don't assume pid_t and time_t fit in unsigned long.
10210 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10211 (current_lock_owner): Prefer signed type for sizes.
10212 Use memcpy, not strncpy, where memcpy is what is really wanted.
10213 Don't assume (via atoi) that time_t and pid_t fit in int.
10214 Check for time_t and/or pid_t out of range, e.g., via a network share.
10215 Don't alloca where an auto var works fine.
10216
93f4cf88
PE
10217 * fileio.c: Fix some integer overflow issues.
10218 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10219 Don't assume string length fits in int.
10220 (directory_file_name): Don't assume string length fits in long.
10221 (make_temp_name): Don't assume pid fits in int, or that its print
10222 length is less than 20.
10223
f3e92b69
PE
10224 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10225
1bfdaf10
PE
10226 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10227
35016e9a
PE
10228 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10229
3d1e65a1
PE
10230 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10231 We prefer signed integers, even for size calculations.
10232
0b963a93
PE
10233 * emacs.c: Don't assume string length fits in 'int'.
10234 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10235 (main): Don't invoke strlen when not needed.
10236
573f4b54
PE
10237 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10238 (XD_DEBUG_MESSAGE): Don't waste a byte.
10239
989f33ba
PE
10240 * callproc.c (getenv_internal_1, getenv_internal)
10241 (Fgetenv_internal):
965d34eb
PE
10242 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10243
e4d29b33
PE
10244 * lread.c (invalid_syntax): Omit length argument.
10245 All uses changed. This doesn't fix a bug, but it simplifies the
10246 code away from its former Hollerith-constant appearance, and it's
10247 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10248 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10249
eb49b136
PE
10250 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10251 This didn't break anything, but it didn't help either.
10252 It's confusing to put a bogus integer in a place where the actual
10253 value does not matter.
9f62aeb1 10254 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10255 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10256
15375a22
PE
10257 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10258 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10259 implementation.
b61cc01c
PE
10260 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10261 We prefer signed types, and the value cannot exceed the EMACS_INT
10262 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10263 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10264 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10265 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10266
53b2623d
PE
10267 * indent.c (sane_tab_width): New function.
10268 (current_column, scan_for_column, Findent_to, position_indentation)
10269 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10270 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10271
51cab52b 10272 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10273
f2ed8a70
PE
10274 * lisp.h (lint_assume): New macro.
10275 * composite.c (composition_gstring_put_cache):
10276 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10277
abe80cc6
PE
10278 * editfns.c, insdel.c:
10279 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10280
b02c740e
PE
10281 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10282
ebc96716
PE
10283 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10284
b4e50fa0 10285 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10286 Use much-faster test for byte-length change.
311d5d7c 10287 Don't assume string byte-length fits in 'int'.
a4cf38e4 10288 Check that character arg fits in 'int'.
85461888 10289 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10290
c0c1ee9f
PE
10291 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10292
a498d7f4
PE
10293 * fns.c (concat): Catch string overflow earlier.
10294 Do not rely on integer wraparound.
10295
51cab52b
PE
10296 * dispextern.h (struct it.overlay_strings_charpos)
10297 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10298 * xdisp.c (forward_to_next_line_start)
10299 (back_to_previous_visible_line_start)
10300 (reseat_at_next_visible_line_start, next_element_from_buffer):
10301 Don't arbitrarily truncate the value of 'selective' to int.
10302
76031fad
PE
10303 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10304
5eb55db9
PE
10305 * composite.c: Don't truncate sizes to 'int'.
10306 (composition_gstring_p, composition_reseat_it)
10307 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10308 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10309 not EMACS_UINT, for indexes.
5eb55db9 10310
0703a717
PE
10311 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10312
d6202519
PE
10313 * buffer.c: Include <verify.h>.
10314 (struct sortvec.priority, struct sortstr.priority):
8961a454 10315 Now EMACS_INT, not int.
c20998a7 10316 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10317 (struct sortstr.size, record_overlay_string)
10318 (struct sortstrlist.size, struct sortlist.used):
10319 Don't truncate size to int.
10320 (record_overlay_string): Check for size-calculation overflow.
d6202519 10321 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10322
d5a19415
JM
103232011-06-22 Jim Meyering <meyering@redhat.com>
10324
029529ac 10325 Don't leak an XBM-image-sized buffer
d5a19415
JM
10326 * image.c (xbm_load): Free the image buffer after using it.
10327
a9041e6c
PE
103282011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10329
10330 Port to Sun C.
10331 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10332 that Sun C diagnosed.
10333 * fns.c (secure_hash): Fix pointer signedness issue.
10334 * intervals.c (static_offset_intervals): New function.
10335 (offset_intervals): Use it.
10336
7f3f739f
LL
103372011-06-21 Leo Liu <sdl.web@gmail.com>
10338
10339 * deps.mk (fns.o):
10340 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10341 sha512.h.
10342
10343 * fns.c (secure_hash): Rename from crypto_hash_function and change
10344 the first arg to accept symbols.
5b66d427 10345 (Fsecure_hash): New primitive.
7f3f739f
LL
10346 (syms_of_fns): New symbols.
10347
76147d94
DD
103482011-06-20 Deniz Dogan <deniz@dogan.se>
10349
10350 * process.c (Fset_process_buffer): Clarify return value in
10351 docstring.
10352
7d7d0045
CY
103532011-06-18 Chong Yidong <cyd@stupidchicken.com>
10354
10355 * dispnew.c (add_window_display_history): Use BVAR.
10356
10357 * xdisp.c (debug_method_add): Use BVAR.
10358 (check_window_end, dump_glyph_matrix, dump_glyph)
10359 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10360
10361 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10362 Likewise.
10363
10364 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10365 check till after the cache is created in init_frame_faces.
10366
ff2bc410
SM
103672011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10368
10369 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10370
28177add
PE
103712011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10372
dd3482fe
PE
10373 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10374 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10375 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10376
393d71f3 10377 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10378 * fileio.c (Finsert_file_contents):
10379 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10380 Remove the old (too-loose) buffer overflow checks.
10381 They weren't needed, since make_gap checks for buffer overflow.
10382 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10383 The old code merely checked for Emacs fixnum overflow, and relied
10384 on undefined (wraparound) behavior. The new code avoids undefined
10385 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10386
2e6813b0 10387 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10388 Tune. Don't use wider integers than needed. Don't use alloca.
10389 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10390
599a9e4f
PE
10391 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10392
99561444
PE
10393 * insdel.c, lisp.h (buffer_overflow): New function.
10394 (insert_from_buffer_1, replace_range, replace_range_2):
10395 * insdel.c (make_gap_larger):
10396 * editfns.c (Finsert_char):
10397 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10398
28177add
PE
10399 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10400
e69dafad
PE
104012011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10402
4baa020d 10403 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10404
b1c46f02
PE
10405 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10406 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10407
e69dafad
PE
10408 * fileio.c: Don't assume EMACS_INT fits in off_t.
10409 (emacs_lseek): New static function.
10410 (Finsert_file_contents, Fwrite_region): Use it.
10411 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10412
566684ea
PE
10413 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10414
e6966cd6
PE
10415 * fns.c: Don't overflow int when computing a list length.
10416 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10417 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10418 truncation on 64-bit hosts. Check for QUIT every
10419 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10420 faster and is responsive enough.
10421 (Flength): Report an error instead of overflowing an integer.
10422 (Fsafe_length): Return a float if the value is not representable
10423 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10424 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10425 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10426
dd0b0efb
PE
10427 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10428 (header_size, word_size): New constants.
10429 (allocate_vectorlike): Don't check size overflow here.
10430 (allocate_vector): Check it here instead, since this is the only
10431 caller of allocate_vectorlike that could cause overflow.
10432 Check that the new vector's length is representable as a fixnum.
10433
86fe5cfe
PE
10434 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10435 The previous code was bogus. For example, next_almost_prime (32)
10436 returned 39, which is undesirable as it is a multiple of 3; and
10437 next_almost_prime (24) returned 25, which is a multiple of 5 so
10438 why was the code bothering to check for multiples of 7?
10439
80e88859
PE
10440 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10441
4a2f0ad6
PE
10442 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10443
f66c7cf8
PE
10444 Variadic C functions now count arguments with ptrdiff_t.
10445 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10446 Back then I didn't know that the Emacs coding style prefers signed int.
10447 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10448 were being counted with int, which may truncate counts on 64-bit
10449 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10450 * lisp.h (struct Lisp_Subr.function.aMANY)
10451 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10452 Arg counts are now ptrdiff_t, not size_t.
10453 All variadic functions and their callers changed accordingly.
10454 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10455 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10456 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10457 * callint.c (Fcall_interactively): Check arg count for overflow,
10458 to avoid potential buffer overrun. Use signed char, not 'int',
10459 for 'varies' array, so that we needn't bother to check its size
10460 calculation for overflow.
10461 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10462 * eval.c (apply_lambda):
10463 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10464 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10465 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10466
a1759b76
PE
10467 * callint.c (Fcall_interactively): Don't use index var as event count.
10468
d96be9fc
PE
10469 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10470 * mem-limits.h (SIZE): Remove; no longer used.
10471
a690a978 10472 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10473
578c21e6
PE
10474 Remove unnecessary casts.
10475 * xterm.c (x_term_init):
10476 * xfns.c (x_set_border_pixel):
10477 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10478 These aren't needed now that we assume ANSI C.
10479
96f53c6c
PE
10480 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10481 It's more likely to cause problems (due to unsigned overflow)
10482 than to cure them.
10483
83c77d31
PE
10484 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10485
ee2079f1
PE
10486 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10487
6da65536
PE
10488 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10489
7147c4a4
PE
10490 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10491
193e32d9
PE
10492 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10493
e5533da6
PE
10494 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10495
9910e595
PE
10496 GLYPH_CODE_FACE returns EMACS_INT, not int.
10497 * dispextern.h (merge_faces):
10498 * xfaces.c (merge_faces):
01103c44
PE
10499 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10500 Don't assume EMACS_INT fits in int.
9910e595 10501
2638320e
PE
10502 * character.h (CHAR_VALID_P): Remove unused parameter.
10503 * fontset.c, lisp.h, xdisp.c: All uses changed.
10504
045eb8d9
PE
10505 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10506
c1f134b5
PE
10507 * fns.c (concat): Minor tuning based on overflow analysis.
10508 This doesn't fix any bugs. Use int to hold character, instead
10509 of constantly refetching from Emacs object. Use XFASTINT, not
10510 XINT, for value known to be a character. Don't bother comparing
10511 a single byte to 0400, as it's always less.
10512
395fcb93 10513 * floatfns.c (Fexpt):
327eeec8
PE
10514 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10515
abbd3d23
PE
10516 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10517 for characters.
10518
684a03ef
PE
10519 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10520
0fed43f3
PE
10521 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10522 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10523 incorrectly succeed when S was a string, because 4294967386 was
10524 truncated before it was used.
10525
8fd02eb7
PE
10526 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10527 Otherwise, an out-of-range integer could cause undefined behavior
10528 on a 64-bit host.
10529
f8c86b69
PE
10530 * composite.c: Use int, not EMACS_INT, for characters.
10531 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10532 EMACS_INT, for values that are known to be in character range.
10533 This doesn't fix any bugs but is the usual style inside Emacs and
10534 may generate better code on 32-bit machines.
10535
34206dd2
PE
10536 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10537 This is for reasons similar to the recent CHAR_STRING fix.
10538 * charset.c (Fencode_char): Check that character arg is actually
10539 a character. Pass an int to ENCODE_CHAR.
10540 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10541 wider than 'int', as a compile-time check to prevent future regressions
10542 in this area.
10543
c5958d4c 10544 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10545
10546 Make sure a 64-bit char is never passed to CHAR_STRING.
10547 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10548 by silently ignoring the top 32 bits, allowing some values
10549 that were far too large to be valid characters.
10550 * character.h: Include <verify.h>.
10551 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10552 arguments are no wider than unsigned, as a compile-time check
10553 to prevent future regressions in this area.
10554 * data.c (Faset):
01103c44 10555 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10556 (Fsubst_char_in_region):
10557 * fns.c (concat):
10558 * xdisp.c (decode_mode_spec_coding):
10559 Adjust to CHAR_STRING's new requirement.
10560 * editfns.c (Finsert_char, Fsubst_char_in_region):
10561 * fns.c (concat): Check that character args are actually
10562 characters. Without this test, these functions did the wrong
10563 thing with wildly out-of-range values on 64-bit hosts.
10564
d37ca623
PE
10565 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10566 These casts should not be needed on 32-bit hosts, either.
10567 * keyboard.c (read_char):
10568 * lread.c (Fload): Remove casts to unsigned.
10569
ea204efb
PE
10570 * lisp.h (UNSIGNED_CMP): New macro.
10571 This fixes comparison bugs on 64-bit hosts.
10572 (ASCII_CHAR_P): Use it.
10573 * casefiddle.c (casify_object):
01103c44 10574 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10575 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10576 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10577 * dispextern.h (FACE_FROM_ID):
10578 * keyboard.c (read_char): Use UNSIGNED_CMP.
10579
41cb286c
PE
10580 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10581 not to EMACS_INT, to avoid GCC warning.
10582
4a1b9832
PE
10583 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10584
55daad71
PE
10585 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10586 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10587 isn't needed on 32-bit machines.
8f95c75c 10588
01103c44
PE
10589 * buffer.c (Fgenerate_new_buffer_name):
10590 Use EMACS_INT for count, not int.
0ceccced 10591 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10592
10593 * data.c (Qcompiled_function): Now static.
10594
c6f072e7
PE
10595 * window.c (window_body_lines): Now static.
10596
20ce5912
PE
10597 * image.c (gif_load): Rename local to avoid shadowing.
10598
9c4c5f81
PE
10599 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10600 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10601 * alloc.c (make_save_value): Integer argument is now of type
10602 ptrdiff_t, not int.
10603 (mark_object): Use ptrdiff_t, not int.
10604 * lisp.h (pD): New macro.
10605 * print.c (print_object): Use it.
10606
c0c5c8ae
PE
10607 * alloc.c: Use EMACS_INT, not int, to count objects.
10608 (total_conses, total_markers, total_symbols, total_vector_size)
10609 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10610 (total_free_floats, total_floats, total_free_intervals)
10611 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10612 Now EMACS_INT, not int. All uses changed.
10613 (Fgarbage_collect): Compute overall total using a double, so that
10614 integer overflow is less likely to be a problem. Check for overflow
10615 when converting back to an integer.
5a25e253
PE
10616 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10617 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10618 These were 'int' variables that could overflow on 64-bit hosts;
10619 they were never used, so remove them instead of repairing them.
211a0b2a 10620 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10621 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10622 Previously, this ceilinged at INT_MAX, but that doesn't work on
10623 64-bit machines.
e46bb31a 10624 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10625
c78baabf 10626 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10627 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10628 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10629 when a (possibly-narrower) signed value would do just as well.
10630 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10631
c9d624c6
PE
10632 * alloc.c: Catch some string size overflows that we were missing.
10633 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10634 for convenience in STRING_BYTES_MAX.
10635 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10636 The definition here is exact; the one in lisp.h was approximate.
10637 (allocate_string_data): Check for string overflow. This catches
10638 some instances we weren't catching before. Also, it catches
10639 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10640 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10641 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10642
c9d624c6
PE
10643 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10644 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10645 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10646
353032ce
PE
10647 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10648
2bccce07
PE
10649 * alloc.c (Fmake_string): Check for out-of-range init.
10650
0ac30604
SM
106512011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10652
10653 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10654
c195f2de
JD
106552011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10656
10657 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10658 xg_get_default_scrollbar_width.
10659
10660 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10661 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10662 (style_changed_cb): Call update_theme_scrollbar_width and call
10663 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10664 all frames (Bug#8505).
10665 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10666 Call gtk_window_set_resizable if HAVE_GTK3.
10667 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10668 and height if HAVE_GTK3 (Bug#8505).
10669 (scroll_bar_width_for_theme): New variable.
10670 (update_theme_scrollbar_width): New function.
10671 (xg_get_default_scrollbar_width): Move code to
10672 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10673 (xg_initialize): Call update_theme_scrollbar_width.
10674
10675 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10676
10677 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10678
e10ac9f1
MR
106792011-06-12 Martin Rudalics <rudalics@gmx.at>
10680
10681 * frame.c (make_frame): Call other_buffer_safely instead of
10682 other_buffer.
10683
10684 * window.c (temp_output_buffer_show): Call display_buffer with
10685 second argument Vtemp_buffer_show_specifiers and reset latter
10686 immediately after the call.
10687 (Vtemp_buffer_show_specifiers): New variable.
10688 (auto_window_vscroll_p, next_screen_context_lines)
10689 (Vscroll_preserve_screen_position): Remove leading asterisks from
10690 doc-strings.
10691
2d3c217e 106922011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10693
7b7f97e8 10694 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10695 * buffer.c (Qclone_number): Remove for now, as it's unused.
10696 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10697 (record_buffer): Remove unused local.
10698 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10699 (set_frame_buffer_list): Remove; unused.
10700 * frame.h (other_visible_frames): Remove decl.
10701 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10702 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10703 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10704 if HAVE_GPM.
10705 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10706 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10707 Define only if HAVE_GPM.
10708 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10709 (update_hints_inhibit): Remove; never set. All uses removed.
10710 * widgetprv.h (emacsFrameClassRec): Remove decl.
10711 * window.c (delete_deletable_window): Now returns void, since it
10712 wasn't returning anything.
10713 (compare_window_configurations): Remove unused locals.
10714 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10715 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10716 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10717 the same widths as pointers. This follows up on the 2011-05-06 patch.
10718 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10719 * xterm.h: Likewise.
10720 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10721
1384b89e
JB
107222011-06-12 Juanma Barranquero <lekktu@gmail.com>
10723
10724 * makefile.w32-in: Update dependencies.
10725 (LISP_H): Add lib/intprops.h.
10726
1100a63c
CY
107272011-06-11 Chong Yidong <cyd@stupidchicken.com>
10728
10729 * image.c (gif_load): Add animation frame delay to the metadata.
10730 (syms_of_image): Use DEFSYM. New symbol `delay'.
10731
6198ccd0
MR
107322011-06-11 Martin Rudalics <rudalics@gmx.at>
10733
10734 * window.c (delete_deletable_window): Re-add.
10735 (Fset_window_configuration): Rewrite to handle dead buffers and
10736 consequently deletable windows.
10737 (window_tree, Fwindow_tree): Remove. Supply functionality in
10738 window.el.
10739 (compare_window_configurations): Simplify code.
10740
b6e3633c
AS
107412011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10742
1ab0dee5
AS
10743 * image.c (imagemagick_load_image): Fix type mismatch.
10744 (Fimagemagick_types): Likewise.
10745
b6e3633c
AS
10746 * window.h (replace_buffer_in_windows): Declare.
10747
9397e56f
MR
107482011-06-11 Martin Rudalics <rudalics@gmx.at>
10749
10750 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10751 Qclone_number. Remove external declaration of Qdelete_window.
10752 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10753 code.
640c8776
SM
10754 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10755 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10756 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10757 buffer list implementation.
10758 (other_buffer_safely): New function.
10759 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10760 calls to replace_buffer_in_windows and
10761 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10762 if allowed.
10763 (record_buffer): Inhibit quitting and rewrite using quittable
10764 functions. Run Qbuffer_list_update_hook if allowed.
10765 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10766 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10767 Move switch-to-buffer to window.el.
9397e56f
MR
10768 (bury-buffer): Move to window.el.
10769 (Vbuffer_list_update_hook): New variable.
10770
10771 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10772 section.
10773
10774 * window.h (resize_frame_windows): Move up in code.
10775 (Fwindow_frame): Remove EXFUN.
10776 (replace_buffer_in_all_windows): Remove prototype.
10777 (replace_buffer_in_windows_safely): Add prototype.
10778
10779 * window.c: Declare Qdelete_window static again. Move down
10780 declaration of select_count.
10781 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10782 (Fother_window): Move to window.el.
10783 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10784 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10785 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10786 window.el.
10787 (replace_buffer_in_windows): Implement by calling
10788 Qreplace_buffer_in_windows.
10789 (replace_buffer_in_all_windows): Remove with some functionality
10790 moved into replace_buffer_in_windows_safely.
10791 (replace_buffer_in_windows_safely): New function.
10792 (select_window_norecord, select_frame_norecord): Move in front
10793 of run_window_configuration_change_hook. Remove now obsolete
10794 declarations.
640c8776
SM
10795 (Fset_window_buffer): Rewrite doc-string.
10796 Call Qrecord_window_buffer.
9397e56f
MR
10797 (keys_of_window): Move binding for other-window to window.el.
10798
b50691aa
CY
107992011-06-11 Chong Yidong <cyd@stupidchicken.com>
10800
10801 * dispextern.h (struct image): Replace data member, whose int_val
10802 and ptr_val fields were not used by anything, with a single
10803 lisp_val object.
10804
10805 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10806 (gif_clear_image, gif_load, imagemagick_load_image)
10807 (gs_clear_image, gs_load): Callers changed.
10808
3f754b86
PE
108092011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10810
cca69397
PE
10811 * buffer.h: Include <time.h>, for time_t.
10812 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10813
109e28d0
PE
10814 Fix minor problems found by static checking.
10815
60737f02
PE
10816 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10817
4b66faf3
PE
10818 Make identifiers static if they are not used in other modules.
10819 * data.c (Qcompiled_function, Qframe, Qvector):
10820 * image.c (QimageMagick, Qsvg):
10821 * minibuf.c (Qmetadata):
10822 * window.c (resize_window_check, resize_root_window): Now static.
10823 * window.h (resize_window_check, resize_root_window): Remove decls.
10824
109e28d0
PE
10825 * window.c (window_deletion_count, delete_deletable_window):
10826 Remove; unused.
46a4ce9e
PE
10827 (window_body_lines): Now static.
10828 (Fdelete_other_windows_internal): Mark vars as initialized.
10829 Make sure 'resize_failed' is initialized.
10830 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10831 (resize_window_apply): Remove unused local.
10832 * window.h (delete_deletable_window): Remove decl.
10833
109e28d0 10834 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10835 (imagemagick_load_image): Fix pointer signedness problem by changing
10836 last arg from unsigned char * to char *. All uses changed.
10837 Also, fix a local for similar reasons.
10838 Remove unused locals. Remove locals to avoid shadowing.
10839 (fn_rsvg_handle_free): Remove; unused.
10840 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10841 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10842
3f754b86
PE
10843 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10844
2547adb1
CY
108452011-06-10 Chong Yidong <cyd@stupidchicken.com>
10846
10847 * image.c (gif_load): Fix omitted cast error introduced by
10848 2011-06-06 change.
10849
2c8e37d4
MR
108502011-06-10 Martin Rudalics <rudalics@gmx.at>
10851
10852 * window.h (resize_proportionally, orig_total_lines)
10853 (orig_top_line): Remove from window structure.
10854 (set_window_height, set_window_width, change_window_heights)
10855 (Fdelete_window): Remove prototypes.
10856 (resize_frame_windows): Remove duplicate declaration.
10857
440a42e3
EZ
108582011-06-10 Eli Zaretskii <eliz@gnu.org>
10859
10860 * window.h (resize_frame_windows, resize_window_check)
10861 (delete_deletable_window, resize_root_window)
10862 (resize_frame_windows): Declare prototypes.
10863
10864 * window.c (resize_window_apply): Make definition be "static" to
10865 match the prototype.
10866
562dd5e9
MR
108672011-06-10 Martin Rudalics <rudalics@gmx.at>
10868
10869 * window.c: Remove declarations of Qwindow_size_fixed,
10870 window_min_size_1, window_min_size_2, window_min_size,
10871 size_window, window_fixed_size_p, enlarge_window, delete_window.
10872 Remove static from declaration of Qdelete_window, it's
10873 temporarily needed by Fbury_buffer.
10874 (replace_window): Don't assign orig_top_line and
10875 orig_total_lines.
10876 (Fdelete_window, delete_window): Remove. Window deletion is
10877 handled by window.el.
640c8776
SM
10878 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10879 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10880 (Fdelete_other_windows): Remove. Deleting other windows is
10881 handled by window.el.
10882 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10883 handled in window.el.
10884 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10885 Window minimum sizes are handled in window.el.
10886 (shrink_windows, size_window, set_window_height)
10887 (set_window_width, change_window_heights, window_height)
10888 (window_width, CURBEG, CURSIZE, enlarge_window)
10889 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10890 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10891 handled in window.el.
10892 (make_dummy_parent): Rename to make_parent_window and give it a
10893 second argument horflag.
10894 (make_window): Don't set resize_proportionally any more.
10895 (Fsplit_window): Remove. Windows are split in window.el.
10896 (save_restore_action, save_restore_orig_size)
10897 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10898 Resize mini windows in window.el.
10899 (grow_mini_window, shrink_mini_window): Implement by calling
10900 Qresize_root_window_vertically, resize_window_check and
10901 resize_window_apply.
640c8776
SM
10902 (saved_window, Fset_window_configuration, save_window_save):
10903 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10904 resize_proportionally.
10905 (window_min_height, window_min_width): Move to window.el.
10906 (keys_of_window): Move bindings for delete-other-windows,
10907 split-window, delete-window and enlarge-window to window.el.
10908
10909 * buffer.c: Temporarily extern Qdelete_window.
10910 (Fbury_buffer): Temporarily call Qdelete_window instead of
10911 Fdelete_window (Fbury_buffer will move to window.el soon).
10912
10913 * frame.c (set_menu_bar_lines_1): Remove code handling
10914 orig_top_line and orig_total_lines.
10915
10916 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10917 set_window_height but set heights directly.
10918 (change_frame_size_1): Use resize_frame_windows.
10919
10920 * xdisp.c (init_xdisp): Don't use set_window_height but set
10921 heights directly.
10922
640c8776
SM
10923 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10924 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10925 run_window_configuration_change_hook.
10926
10927 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10928 instead of change_window_heights and run
10929 run_window_configuration_change_hook.
10930
1a13852e
MR
109312011-06-09 Martin Rudalics <rudalics@gmx.at>
10932
10933 * window.c (replace_window): Rename second argument REPLACEMENT to
10934 NEW. New third argument SETFLAG. Rewrite.
10935 (delete_window, make_dummy_parent): Call replace_window with
10936 third argument 1.
10937 (window_list_1): Move down in code.
10938 (run_window_configuration_change_hook): Move set_buffer part
10939 before select_frame_norecord part in order to unwind correctly.
10940 Rename count1 to count.
10941 (recombine_windows, delete_deletable_window, resize_root_window)
10942 (Fdelete_other_windows_internal)
10943 (Frun_window_configuration_change_hook, make_parent_window)
10944 (resize_window_check, resize_window_apply, Fresize_window_apply)
10945 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10946 (Fdelete_window_internal, Fresize_mini_window_internal):
10947 New functions.
1a13852e
MR
10948 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10949
f3d1777e
MR
109502011-06-08 Martin Rudalics <rudalics@gmx.at>
10951
496e208e
MR
10952 * window.h (window): Add some new members to window structure -
10953 normal_lines, normal_cols, new_total, new_normal, clone_number,
10954 splits, nest, prev_buffers, next_buffers.
10955 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10956 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10957
f3d1777e
MR
10958 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10959 Remove.
496e208e
MR
10960 (make_dummy_parent): Set new members of windows structure.
10961 (make_window): Move down in code. Handle new members of window
10962 structure.
10963 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10964 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10965 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10966 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10967 (Fset_window_next_buffers, Fset_window_clone_number):
10968 New functions.
496e208e
MR
10969 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10970 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10971 Doc-string fixes.
10972 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10973 Argument WINDOW can be now internal window too.
10974 (Fwindow_use_time): Move up in code.
10975 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10976 Rewrite doc-string.
10977 (Fset_window_configuration, saved_window)
10978 (Fcurrent_window_configuration, save_window_save): Handle new
10979 members of window structure.
b9e809c2
MR
10980 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10981 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10982 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10983 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10984 Qget_mru_window, Qresize_root_window,
10985 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10986 Qauto_buffer_name; staticpro them.
f3d1777e 10987
abde8f8c
MR
109882011-06-07 Martin Rudalics <rudalics@gmx.at>
10989
10990 * window.c (Fwindow_total_size, Fwindow_left_column)
10991 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10992 (Fwindow_list_1): New functions.
10993 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10994 (Fwindow_width, Fscroll_left, Fscroll_right):
10995 Use window_body_cols instead of window_box_text_cols.
10996 (delete_window, Fset_window_configuration):
10997 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10998 (delete_all_subwindows): Take a window as argument and not a
10999 structure. Rewrite.
190b47e6
MR
11000 (window_loop): Remove handling of GET_LRU_WINDOW and
11001 GET_LARGEST_WINDOW.
11002 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11003
11004 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11005 window_box_text_cols. delete_all_subwindows now takes a
11006 Lisp_Object as argument.
abde8f8c 11007
640c8776
SM
11008 * indent.c (compute_motion, Fcompute_motion):
11009 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11010
fa8a67e6
MR
11011 * frame.c (delete_frame): Call delete_all_subwindows with root
11012 window as argument.
11013
a54e3482
DC
110142011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11015
11016 * fns.c (Fputhash): Document return value.
11017
60002bf5
CY
110182011-06-06 Chong Yidong <cyd@stupidchicken.com>
11019
11020 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11021
0c671da6 110222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11023
b862a52a 11024 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11025
be44ca6c
PE
11026 Check for overflow when converting integer to cons and back.
11027 * charset.c (Fdefine_charset_internal, Fdecode_char):
11028 Use cons_to_unsigned to catch overflow.
11029 (Fencode_char): Use INTEGER_TO_CONS.
11030 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11031 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11032 * data.c (long_to_cons, cons_to_long): Remove.
11033 (cons_to_unsigned, cons_to_signed): New functions.
11034 These signal an error for invalid or out-of-range values.
11035 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11036 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11037 * font.c (Ffont_variation_glyphs):
11038 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11039 * lisp.h: Include <intprops.h>.
11040 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11041 (cons_to_signed, cons_to_unsigned): New decls.
11042 (long_to_cons, cons_to_long): Remove decls.
11043 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11044 (Fprimitive_undo): Use CONS_TO_INTEGER.
11045 * xfns.c (Fx_window_property): Likewise.
11046 * xselect.c: Include <limits.h>.
11047 (x_own_selection, selection_data_to_lisp_data):
11048 Use INTEGER_TO_CONS.
11049 (x_handle_selection_request, x_handle_selection_clear)
11050 (x_get_foreign_selection, Fx_disown_selection_internal)
11051 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11052 (lisp_data_to_selection_data): Use cons_to_unsigned.
11053 (x_fill_property_data): Use cons_to_signed.
11054 Report values out of range.
11055
d1f3d2af
PE
11056 Check for buffer and string overflow more precisely.
11057 * buffer.h (BUF_BYTES_MAX): New macro.
11058 * lisp.h (STRING_BYTES_MAX): New macro.
11059 * alloc.c (Fmake_string):
11060 * character.c (string_escape_byte8):
11061 * coding.c (coding_alloc_by_realloc):
11062 * doprnt.c (doprnt):
11063 * editfns.c (Fformat):
11064 * eval.c (verror):
11065 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11066 since they may not be the same number.
11067 * editfns.c (Finsert_char):
11068 * fileio.c (Finsert_file_contents):
11069 Likewise for BUF_BYTES_MAX.
11070
dd52fcea
PE
11071 * image.c: Use ptrdiff_t, not int, for sizes.
11072 (slurp_file): Switch from int to ptrdiff_t.
11073 All uses changed.
11074 (slurp_file): Check that file size fits in both size_t (for
11075 malloc) and ptrdiff_t (for sanity and safety).
11076
7f9bbdbb
PE
11077 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11078 if b->modtime has its maximal value.
11079
dfe18f82
PE
11080 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11081
84acfcf0
PE
11082 Don't assume time_t can fit into int.
11083 * buffer.h (struct buffer.modtime): Now time_t, not int.
11084 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11085 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11086
ccd9a01a
PE
11087 Minor fixes for signed vs unsigned integers.
11088 * character.h (MAYBE_UNIFY_CHAR):
11089 * charset.c (maybe_unify_char):
11090 * keyboard.c (read_char, reorder_modifiers):
11091 XINT -> XFASTINT, since the integer must be nonnegative.
11092 * ftfont.c (ftfont_spec_pattern):
11093 * keymap.c (access_keymap, silly_event_symbol_error):
11094 XUINT -> XFASTINT, since the integer must be nonnegative.
11095 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11096 since it makes no difference and we prefer signed.
11097 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11098 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11099 nonnegative.
11100
d6d100dd
SM
111012011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11102
11103 * window.h (Fwindow_frame): Declare.
11104
2b6148e4
PE
111052011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11106
11107 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11108 (SPARE_MEMORY): Always define.
11109 (LARGE_REQUEST): Remove.
11110 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11111
f230ecc9
MR
111122011-06-06 Martin Rudalics <rudalics@gmx.at>
11113
727e958e
MR
11114 * lisp.h: Move EXFUNS for Fframe_root_window,
11115 Fframe_first_window and Fset_frame_selected_window to window.h.
11116
11117 * window.h: Move EXFUNS for Fframe_root_window,
11118 Fframe_first_window and Fset_frame_selected_window here from
11119 lisp.h.
11120
11121 * frame.c (Fwindow_frame, Fframe_first_window)
11122 (Fframe_root_window, Fframe_selected_window)
11123 (Fset_frame_selected_window): Move to window.c.
11124 (Factive_minibuffer_window): Move to minibuf.c.
11125 (Fother_visible_frames_p): New function.
11126
11127 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11128
f230ecc9
MR
11129 * window.c (decode_window, decode_any_window): Move up in code.
11130 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11131 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11132 (Fwindow_buffer): Move up and rewrite doc-string.
11133 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11134 (Fwindow_prev): New functions.
727e958e
MR
11135 (Fwindow_frame): Move here from frame.c. Accept any window as
11136 argument.
11137 (Fframe_root_window, Fframe_first_window)
11138 (Fframe_selected_window): Move here from frame.c. Accept frame
11139 or arbitrary window as argument. Update doc-strings.
11140 (Fminibuffer_window): Move up in code.
11141 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11142 (Fset_frame_selected_window): Move here from frame.c.
11143 Marginal rewrite.
727e958e
MR
11144 (Fselected_window, select_window, Fselect_window): Move up in
11145 code. Minor doc-string fixes.
f230ecc9 11146
4d09bcf6
PE
111472011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11148
11149 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11150 Do not assume that spare memory exists; that assumption is valid
11151 only if SYSTEM_MALLOC.
11152 (LARGE_REQUEST): New macro, so that the issue of large requests
11153 is separated from the issue of spare memory.
11154
810928a2
AS
111552011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11156
172418ad
AS
11157 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11158 format. (Bug#8806)
11159
43f862f7
AS
11160 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11161
810928a2
AS
11162 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11163 before statements.
11164
a059fe24
JD
111652011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11166
11167 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11168
11169 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11170
11171 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11172 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11173
989bf368
JB
111742011-06-05 Juanma Barranquero <lekktu@gmail.com>
11175
11176 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11177
4b80f674
CY
111782011-06-04 Chong Yidong <cyd@stupidchicken.com>
11179
11180 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11181 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11182 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11183 New error handlers.
4b80f674
CY
11184 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11185 Obey Vx_select_enable_clipboard_manager. Catch errors in
11186 x_clipboard_manager_save (Bug#8779).
11187 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11188 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11189
99a33b77 111902011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11191
11192 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11193
99a33b77 111942011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11195
11196 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11197 in the current matrix if keep_current_p is non-zero.
11198
8264569d
EZ
111992011-06-04 Eli Zaretskii <eliz@gnu.org>
11200
11201 * bidi.c (bidi_level_of_next_char): Fix last change.
11202
57f97249
EZ
112032011-06-03 Eli Zaretskii <eliz@gnu.org>
11204
fec2107c 11205 Support bidi reordering of text covered by display properties.
57f97249 11206
fec2107c
EZ
11207 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11208 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11209 (bidi_cache_search, bidi_cache_iterator_state)
11210 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11211 (bidi_level_of_next_char, bidi_move_to_visually_next):
11212 Support character positions inside a run of characters covered by a
fec2107c
EZ
11213 display string.
11214 (bidi_paragraph_init, bidi_resolve_explicit_1)
11215 (bidi_level_of_next_char): Call bidi_fetch_char and
11216 bidi_fetch_char_advance instead of FETCH_CHAR and
11217 FETCH_CHAR_ADVANCE.
11218 (bidi_init_it): Initialize new members.
11219 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11220 definitions.
11221 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11222 instead of using explicit *_CHAR codes.
d6d100dd
SM
11223 (bidi_resolve_explicit, bidi_resolve_weak):
11224 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11225 bidirectional text is supported only in multibyte buffers.
11226 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11227 it to initialize the frame_window_p member of struct bidi_it.
11228 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11229 (bidi_resolve_explicit, bidi_resolve_weak)
11230 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11231 bidi_it->nchars is non-positive.
11232 (bidi_level_of_next_char): Don't try to lookup the cache for the
11233 next/previous character if nothing is cached there yet, or if we
11234 were just reseat()'ed to a new position.
c40e2fb2 11235
0e14fe90
EZ
11236 * xdisp.c (set_cursor_from_row): Set start and stop points
11237 according to the row's direction when priming the loop that looks
11238 for the glyph on which to display cursor.
11239 (single_display_spec_intangible_p): Function deleted.
11240 (display_prop_intangible_p): Reimplement to call
11241 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11242 Accept 3 additional arguments needed by handle_display_spec.
11243 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11244 values: lists, `(when COND...)' forms, etc.
11245 (single_display_spec_string_p): Support property values that are
11246 lists with the argument STRING its top-level element.
11247 (display_prop_string_p): Fix the condition for processing a
11248 property that is a list to be consistent with handle_display_spec.
fec2107c 11249 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11250 last portion of handle_display_prop.
11251 (compute_display_string_pos): Accept additional argument
11252 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11253 value of a `display' property is a "replacing spec".
11254 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11255 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11256 the display property, but just return a value indicating whether
11257 the display property will replace the characters it covers.
11258 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11259 frame_window_p members of struct bidi_it.
d6d100dd
SM
11260 (compute_display_string_pos, compute_display_string_end):
11261 New functions.
fec2107c
EZ
11262 (push_it): Accept second argument POSITION, where pop_it should
11263 jump to continue iteration.
11264 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11265
fec2107c
EZ
11266 * keyboard.c (adjust_point_for_property): Adjust the call to
11267 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11268
11269 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11270 (bidi_init_it): Update prototypes.
11271 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11272 (compute_display_string_pos, compute_display_string_end):
11273 Declare prototypes.
fec2107c
EZ
11274 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11275 EMACS_INT.
fc6f18ce 11276
40087514 112772011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11278
57f53182
PE
11279 Malloc failure behavior now depends on size of allocation.
11280 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11281 * lisp.h: Change signatures accordingly.
11282 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11283 All callers changed. (Bug#8762)
11284
11285 * gnutls.c: Use Emacs's memory allocators.
11286 Without this change, the gnutls library would invoke malloc etc.
11287 directly, which causes problems on non-SYNC_INPUT hosts, and which
11288 runs afoul of improving memory_full behavior. (Bug#8761)
11289 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11290 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11291 xfree instead of the default malloc, realloc, free.
11292 (Fgnutls_boot): No need to check for memory allocation failure,
11293 since xmalloc does that for us.
11294
ac32cd99 11295 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11296 * category.c (hash_get_category_set):
11297 * ccl.c (ccl_driver):
11298 * charset.c (Fdefine_charset_internal):
11299 * charset.h (struct charset.hash_index):
11300 * composite.c (get_composition_id, gstring_lookup_cache)
11301 (composition_gstring_put_cache):
11302 * composite.h (struct composition.hash_index):
11303 * dispextern.h (struct image.hash):
11304 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11305 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11306 (hashfn_equal, hashfn_user_defined, make_hash_table)
11307 (maybe_resize_hash_table, hash_lookup, hash_put)
11308 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11309 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11310 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11311 * image.c (make_image, search_image_cache, lookup_image)
11312 (xpm_put_color_table_h):
11313 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11314 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11315 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11316 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11317 * alloc.c (allocate_vectorlike):
11318 Check for overflow in vector size calculations.
11319 * ccl.c (ccl_driver):
11320 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11321 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11322 need to be updated by these changes.
40087514
PE
11323 * fns.c (make_hash_table, maybe_resize_hash_table):
11324 Check for integer overflow with large hash tables.
0de4bb68
PE
11325 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11326 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11327 (SXHASH_REDUCE): New macro.
11328 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11329 Use it instead of discarding useful hash info with large hash values.
11330 (sxhash_float): New function.
11331 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11332 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11333 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11334 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11335 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11336 Adjust signatures to match updated version of code.
11337 (consing_since_gc): Now EMACS_INT, since a single hash table can
11338 use more than INT_MAX bytes.
11339
698d32e2
DN
113402011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11341
11342 Make it possible to build with GCC-4.6+ -O2 -flto.
11343
11344 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11345
fd6fa53f
SM
113462011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11347
11348 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11349 Call minibuffer-inactive-mode.
11350
864db017
JB
113512011-05-31 Juanma Barranquero <lekktu@gmail.com>
11352
11353 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11354 Update dependencies.
11355
2ad0baf4
DN
113562011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11357
11358 * data.c (init_data): Remove code for UTS, this system is not
11359 supported anymore.
11360
4fcc2638
DN
113612011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11362
11363 Don't force ./temacs to start in terminal mode.
11364
11365 * frame.c (make_initial_frame): Initialize faces in all cases, not
11366 only when CANNOT_DUMP is defined.
11367 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11368
c56e0fd5
DN
113692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11370
11371 * dispnew.c (add_window_display_history): Use const for the string
11372 pointer. Remove declaration, not needed.
11373
333d54da 113742011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11375
55d4c1b2 11376 Use 'inline', not 'INLINE'.
333d54da 11377 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11378 * alloc.c, fontset.c (INLINE): Remove.
11379 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11380 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11381 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11382 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11383 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11384
738db178
DN
113852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11386
11387 Make it possible to run ./temacs.
11388
11389 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11390 syms_of_callproc does the same thing. Remove test for
11391 "initialized", do it in the caller.
11392 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11393
620c53a6
SM
113942011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11395
11396 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11397 (read_minibuf): Use get_minibuffer.
11398 (syms_of_minibuf): Use DEFSYM.
11399 (Qmetadata): New var.
11400 * data.c (Qbuffer): Don't make it static.
11401 (syms_of_data): Use DEFSYM.
11402
e003a292
PE
114032011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11404
11405 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11406 (CCL_CODE_MIN): New macro.
11407
ed008a6d
PE
114082011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11409
3687c2ef
PE
11410 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11411
ed008a6d
PE
11412 * eval.c (Qdebug): Now static.
11413 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11414 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11415 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11416
d66c4c7c
CY
114172011-05-29 Chong Yidong <cyd@stupidchicken.com>
11418
11419 * image.c: Various fixes to ImageMagick code comments.
11420 (Fimagemagick_types): Doc fix.
11421
5fbc2025
PE
114222011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11423
0196f88a
PE
11424 Minor fixes prompted by GCC 4.6.0 warnings.
11425
11426 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11427
5fbc2025
PE
11428 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11429 (x_clipboard_manager_save_all): Move extern decl to ...
11430 * xterm.h: ... here, so that it can be checked for consistency.
11431
1dd3c2d9
CY
114322011-05-29 Chong Yidong <cyd@stupidchicken.com>
11433
11434 * xselect.c (x_clipboard_manager_save_frame)
11435 (x_clipboard_manager_save_all): New functions.
11436 (Fx_clipboard_manager_save): Lisp function deleted.
11437
11438 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11439 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11440
11441 * xterm.h: Update prototype.
11442
5ba6571d
WX
114432011-05-28 William Xu <william.xwl@gmail.com>
11444
11445 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11446 exiting (Bug#8239).
11447
3eaff834
JM
114482011-05-28 Jim Meyering <meyering@redhat.com>
11449
e1900994 11450 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11451 * fns.c (to_uchar): Define.
11452 (crypto_hash_function): Use it to convert some newly-signed
11453 variables to unsigned, to avoid sign-extension bugs. For example,
11454 without this change, (md5 "truc") would evaluate to
11455 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11456 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11457 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11458
0f6990a7
PE
114592011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11460
11461 Integer overflow fixes.
c8a9ca5a 11462
08686060
PE
11463 * dbusbind.c: Serial number integer overflow fixes.
11464 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11465 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11466 to hold a serial number that is too large for a fixnum.
11467 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11468 Check for serial numbers out of range. Decode any serial number
59568bf0 11469 that was so large that it became a float. (Bug#8722)
08686060 11470
2d1fc3c7
PE
11471 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11472 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11473 Use XFASTINT rather than XUINT when numbers are nonnegative.
11474 (xd_append_arg, Fdbus_method_return_internal):
11475 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11476 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11477 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11478 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11479 (Bug#8722)
2d1fc3c7 11480
c8a9ca5a
PE
11481 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11482
519e1d69
PE
11483 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11484
6df6ae42 11485 ccl: Add integer overflow checks.
30569699
PE
11486 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11487 (IN_INT_RANGE): New macros.
11488 (ccl_driver): Use them to check for integer overflow when
11489 decoding a CCL program. Many of the new checks are whether XINT (x)
11490 fits in int; it doesn't always, on 64-bit hosts. The new version
11491 doesn't catch all possible integer overflows, but it's an
847044ea 11492 improvement. (Bug#8719)
30569699 11493
c11285dc
PE
11494 * alloc.c (make_event_array): Use XINT, not XUINT.
11495 There's no need for unsigned here.
11496
fdccd48e
PE
11497 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11498 This follows up to the 2011-05-06 change that substituted uintptr_t
11499 for EMACS_INT. This case wasn't caught back then.
11500
37910ab2
PE
11501 Rework Fformat to avoid integer overflow issues.
11502 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11503 now (part of C89). Include <verify.h>.
11504 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11505 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11506 (Fformat): Avoid the prepass trying to compute sizes; it was only
11507 approximate and thus did not catch overflow reliably. Instead, walk
11508 through the format just once, formatting and computing sizes as we go,
11509 checking for integer overflow at every step, and allocating a larger
11510 buffer as needed. Keep track separately whether the format is
11511 multibyte. Keep only the most-recently calculated precision, rather
11512 than them all. Record whether each argument has been converted to
11513 string. Use EMACS_INT, not int, for byte and char and arg counts.
11514 Support field widths and precisions larger than INT_MAX. Avoid
11515 sprintf's undefined behavior with conversion specifications such as %#d
11516 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11517 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11518 formatting out-of-range floating point numbers with int
9173deec 11519 formats. (Bug#8668)
37910ab2 11520
2e6578fb
PE
11521 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11522
0ae6bdee
PE
11523 * data.c: Avoid integer truncation in expressions involving floats.
11524 * data.c: Include <intprops.h>.
11525 (arith_driver): When there's an integer overflow in an expression
11526 involving floating point, convert the integers to floating point
11527 so that the resulting value does not suffer from catastrophic
11528 integer truncation. For example, on a 64-bit host (* 4
11529 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11530 Do not rely on undefined behavior after integer overflow.
11531
de883a70
PE
11532 merge count_size_as_multibyte, parse_str_to_multibyte
11533 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11534 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11535 Check for integer overflow.
11536 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11537 since it's now a duplicate of the other. This is more of
11538 a character than a buffer op, so better that it's in character.c.
11539 * fns.c, print.c: Adjust to above changes.
11540
2ff916cb
PE
115412011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11542
11543 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11544
f1b54466
PE
115452011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11546
fb1ac845
PE
11547 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11548 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11549 (x_clipboard_manager_save): Now static.
11550 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11551
f1b54466
PE
11552 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11553 (crypto_hash_function): Now static.
11554 Fix pointer signedness problems. Avoid unnecessary initializations.
11555
a9f737ee
CY
115562011-05-27 Chong Yidong <cyd@stupidchicken.com>
11557
11558 * termhooks.h (Vselection_alist): Make it terminal-local.
11559
11560 * terminal.c (create_terminal): Initialize it.
11561
11562 * xselect.c: Support for clipboard managers.
11563 (Vselection_alist): Move to termhooks.h as terminal-local var.
11564 (LOCAL_SELECTION): New macro.
11565 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11566 (symbol_to_x_atom): Remove gratuitous arg.
11567 (x_handle_selection_request, lisp_data_to_selection_data)
11568 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11569 (x_own_selection, x_get_local_selection, x_convert_selection):
11570 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11571 (some_frame_on_display): Delete unused function.
11572 (Fx_own_selection_internal, Fx_get_selection_internal)
11573 (Fx_disown_selection_internal, Fx_selection_owner_p)
11574 (Fx_selection_exists_p): New optional frame arg.
11575 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11576 (x_handle_selection_clear): Don't treat other terminals with the
11577 same keyboard specially. Use the terminal-local Vselection_alist.
11578 (x_clear_frame_selections): Use Frun_hook_with_args.
11579
11580 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11581
11582 * xterm.h: Add support for those atoms.
11583
e067f0c1
CY
115842011-05-26 Chong Yidong <cyd@stupidchicken.com>
11585
11586 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11587 (converted_selections, conversion_fail_tag): New global variables.
11588 (x_selection_request_lisp_error): Free the above.
11589 (x_get_local_selection): Remove unnecessary code.
11590 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11591 of converted selections stored in converted_selections.
11592 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11593 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11594 (x_convert_selection): New function.
11595 (x_handle_selection_event): Simplify.
11596 (x_get_foreign_selection): Don't ignore incoming requests while
11597 waiting for an answer; this will fail when we implement
11598 SAVE_TARGETS, and seems unnecessary anyway.
11599 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11600 (Vx_sent_selection_functions): Doc fix.
11601
0f4aebc0
LL
116022011-05-26 Leo Liu <sdl.web@gmail.com>
11603
11604 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11605
e61124cd
YM
116062011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11607
11608 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11609
11610 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11611 for fringe update if it has periodic bitmap.
ac389d0c 11612 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11613 and fringe_bitmap_periodic_p.
11614
11615 * fringe.c (get_fringe_bitmap_data): New function.
11616 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11617 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11618 row. Mark glyph row for fringe update if periodicity changed.
11619
11620 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11621 for fringe update unless it has periodic bitmap.
11622
f16d9837
KH
116232011-05-25 Kenichi Handa <handa@m17n.org>
11624
11625 * xdisp.c (get_next_display_element): Set correct it->face_id for
11626 a static composition.
11627
e1b90ef6
LL
116282011-05-24 Leo Liu <sdl.web@gmail.com>
11629
11630 * deps.mk (fns.o):
11631 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11632
11633 * fns.c (crypto_hash_function, Fsha1): New function.
11634 (Fmd5): Use crypto_hash_function.
11635 (syms_of_fns): Add Ssha1.
11636
7400048f
PE
116372011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11638
11639 * gnutls.c: Remove unused macros.
11640 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11641 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11642 Remove macros that are defined and never used.
11643 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11644
abb71cf4
CY
116452011-05-22 Chong Yidong <cyd@stupidchicken.com>
11646
11647 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11648 (Fx_get_selection_internal): Minor cleanup.
11649 (Fx_own_selection_internal): Rename arguments for consistency with
11650 select.el.
11651
6307db39
PE
116522011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11653
11654 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11655
f3d4e0a4
CY
116562011-05-22 Chong Yidong <cyd@stupidchicken.com>
11657
11658 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11659
4d8ade89
YM
116602011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11661
11662 * dispnew.c (scrolling_window): Don't exclude the case that the
11663 last enabled row in the desired matrix touches the bottom boundary.
11664
32078c8d
GM
116652011-05-21 Glenn Morris <rgm@gnu.org>
11666
11667 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11668 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11669 and add some more files.
32078c8d 11670
7285dc67
EZ
116712011-05-20 Eli Zaretskii <eliz@gnu.org>
11672
11673 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11674 report_file_error introduced by the change from 2011-05-07.
11675
89d1bd22
PE
116762011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11677
11678 * systime.h (Time): Define only if emacs is defined.
11679 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11680 where the include path doesn't have X11/X.h by default. See
11681 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11682
cd394be1 116832011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11684
11685 * composite.c (find_automatic_composition): Fix previous change.
11686
b9704ad9
GM
116872011-05-20 Glenn Morris <rgm@gnu.org>
11688
11689 * lisp.mk: New file, split from Makefile.in.
11690 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11691 (shortlisp): Remove.
11692 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11693
4a720484
GM
116942011-05-19 Glenn Morris <rgm@gnu.org>
11695
11696 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11697 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11698 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11699 (lisp): Set the order to that of loadup.el.
11700 (shortlisp): Make it a copy of $lisp.
11701 (SOME_MACHINE_LISP): Remove.
11702 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11703 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11704
a28d4396
KH
117052011-05-18 Kenichi Handa <handa@m17n.org>
11706
11707 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11708 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11709 (find_automatic_composition): Mostly rewrite for efficiency.
11710
a2b1fa8e
JB
117112011-05-18 Juanma Barranquero <lekktu@gmail.com>
11712
11713 * makefile.w32-in: Update dependencies.
11714
8e1f5610
CS
117152011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11716
11717 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11718 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11719
7025ee00 117202011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11721
cdfa6eab
PE
11722 Fix some integer overflow issues, such as string length overflow.
11723
06d6db33
PE
11724 * insdel.c (count_size_as_multibyte): Check for string overflow.
11725
2b4560a8
PE
11726 * character.c (lisp_string_width): Check for string overflow.
11727 Use EMACS_INT, not int, for string indexes and lengths; in
11728 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11729 the resulting string length overflows an EMACS_INT; instead,
11730 report a string overflow if no precision given. When checking for
11731 precision exhaustion, use a check that cannot possibly have
11732 integer overflow. (Bug#8675)
11733 * character.h (lisp_string_width): Adjust to new signature.
11734
cb93f9be
PE
11735 * alloc.c (string_overflow): New function.
11736 (Fmake_string): Use it. This doesn't change behavior, but saves
11737 a few bytes and will simplify future changes.
11738 * character.c (string_escape_byte8): Likewise.
11739 * lisp.h (string_overflow): New decl.
11740
1a1f3366
PE
11741 Fixups, following up to the user-interface timestamp change.
11742 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11743 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11744 * msdos.c (mouse_get_pos): Likewise.
11745 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11746 * w32gui.h (Time): Define by including "systime.h" rather than by
11747 declaring it ourselves. (Bug#8664)
11748
d4e3e4d3
PE
11749 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11750 * image.c (clear_image_cache): Likewise.
11751
f6a24d19
PE
11752 * term.c (term_mouse_position): Don't assume time_t wraparound.
11753
08dc5ae6
PE
11754 Be more systematic about user-interface timestamps.
11755 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11756 and sometimes 'EMACS_UINT', to represent these timestamps.
11757 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11758 This makes the code easier to follow, and makes it easier to catch
11759 integer overflow bugs such as Bug#8664.
11760 * frame.c (Fmouse_position, Fmouse_pixel_position):
11761 Use Time, not unsigned long, for user-interface timestamps.
11762 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11763 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11764 * keyboard.h (last_event_timestamp): Likewise.
11765 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11766 * menu.h (xmenu_show): Likewise.
11767 * term.c (term_mouse_position): Likewise.
11768 * termhooks.h (struct input_event.timestamp): Likewise.
11769 (struct terminal.mouse_position_hook): Likewise.
11770 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11771 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11772 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11773 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11774 what it was before.
11775 * menu.h, termhooks.h: Include "systime.h", for Time.
11776
8e55734a
PE
11777 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11778 Don't assume that the difference between two unsigned long values
11779 can fit into an integer. At this point, we know button_down_time
11780 <= event->timestamp, so the difference must be nonnegative, so
11781 there's no need to cast the result if double-click-time is
11782 nonnegative, as it should be; check that it's nonnegative, just in
11783 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11784 apart (about 25 days). (Bug#8664)
8e55734a 11785
841f1b75 11786 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11787 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11788
3e26f69c
PE
11789 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11790 that always fit in int. Use a sentinel instead of a counter, to
11791 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11792 * frame.h (struct frame): Use int for menu_bar_items_used
11793 instead of EMACS_INT, since it always fits in int.
3e26f69c 11794
5cc152c0
PE
11795 * menu.c (grow_menu_items): Check for int overflow.
11796
d89eb65e
PE
11797 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11798
5235bd3e
PE
11799 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11800 Before, the code was not consistent. These values cannot exceed
11801 2**31 - 1 so there's no need to make them unsigned.
11802 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11803 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11804 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11805 as modifiers.
11806 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11807
bc827e23
PE
11808 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11809 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11810 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11811 presumably because the widths might not match.
11812
78eb494e
PE
11813 * window.c (size_window): Avoid needless test at loop start.
11814
04f2d78b
CB
118152011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11816
11817 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11818
d2fc7e3d 118192011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11820
11821 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11822
d2fc7e3d 118232011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11824
11825 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11826 `width' to `bar_area_x' and `bar_area_width', respectively.
11827 (x_scroll_run): Take account of fringe background extension.
11828
04f2d78b
CB
11829 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11830 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11831 `bar_area_width', respectively.
11832 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11833 background extension.
11834
79b70037
GM
118352011-05-10 Jim Meyering <meyering@redhat.com>
11836
11837 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11838
2f142cc5
JB
118392011-05-10 Juanma Barranquero <lekktu@gmail.com>
11840
11841 * image.c (Finit_image_library): Return t for built-in image types,
11842 like pbm and xbm. (Bug#8640)
11843
57679c86
AS
118442011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11845
11846 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11847
888c9e86
EZ
118482011-05-07 Eli Zaretskii <eliz@gnu.org>
11849
b0512a1d
EZ
11850 * w32console.c (Fset_screen_color): Doc fix.
11851 (Fget_screen_color): New function.
11852 (syms_of_ntterm): Defsubr it.
11853
7285dc67
EZ
11854 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11855 unlink the temporary file if Fcall_process didn't create it in the
11856 first place.
11857 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11858 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11859 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11860 cue to call_process_cleanup not to close that handle.
11861
4d3fcc8e
BK
118622011-05-07 Ben Key <bkey76@gmail.com>
11863
11864 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11865 one of two shell specific rules, either bootstrap-temacs-CMD or
11866 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11867 to the previous implementation of the bootstrap-temacs rule.
11868 The bootstrap-temacs-CMD rule is similar to the previous
11869 implementation of the bootstrap-temacs rule except that it
11870 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11871 variable.
11872
11873 These changes, along with some changes to nt/configure.bat,
11874 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11875 earlier fix to add support for --cflags and --ldflags options
11876 that include quotes so that it works whether make uses cmd or
11877 sh as the shell.
11878
b4289b64
MA
118792011-05-06 Michael Albinus <michael.albinus@gmx.de>
11880
11881 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11882 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11883 is a constant.
11884 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11885 a string. Handle both cases.
11886 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11887 (Fdbus_register_method): Use Qinvalid_function.
11888
af4c0e28
JB
118892011-05-06 Juanma Barranquero <lekktu@gmail.com>
11890
11891 * makefile.w32-in: Update dependencies.
11892 (LISP_H): Add inttypes.h and stdin.h.
11893 (PROCESS_H): Add unistd.h.
11894
c51453d9
EZ
118952011-05-06 Eli Zaretskii <eliz@gnu.org>
11896
11897 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11898 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11899
8ff0ac3c 119002011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11901
4c4b566b
PE
11902 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11903
aab2b9b5
PE
11904 * term.c (vfatal): Remove stray call to va_end.
11905 It's not needed and the C Standard doesn't allow it here anyway.
11906
c378da0b
PE
11907 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11908 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11909
288b08c7
PE
11910 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11911 bytes.
11912
e3601888
PE
11913 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11914
db6c0e74
PE
11915 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11916
dd5963ea
PE
11917 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11918
88c9450f
PE
11919 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11920
2f9442b8
PE
11921 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11922
c032b5f8
PE
11923 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11924 * charset.c (Fdefine_charset_internal): Don't initialize
11925 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11926 32-bit int (Bug#8600).
a108c10b
PE
11927
11928 * lread.c (read_integer): Be more consistent with string-to-number.
11929 Use string_to_number to do the actual conversion; this avoids
11930 rounding errors and fixes some other screwups. Without this fix,
11931 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11932 (digit_to_number): Move earlier, for benefit of read_integer.
11933 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11934 not a digit in any supported base. (Bug#8602)
a108c10b 11935
ad5f9eea
PE
11936 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11937
aec1708a
PE
11938 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11939 to match comment at start of function. This also removes a
11940 GCC warning about overflow in a 32+64-bit port.
11941
47be4ab5
PE
11942 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11943
371cac43
PE
11944 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11945 Reported by Stefan Monnier in
11946 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11947 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11948 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11949
d01a7826
PE
11950 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11951 (EMACS_UINTPTR): Likewise, with uintptr_t.
11952
7fd47d5c
PE
11953 * lisp.h: Prefer 64-bit EMACS_INT if available.
11954 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11955 on 32-bit hosts that have 64-bit int, so that they can access
11956 large files.
122b0c86
PE
11957 However, temporarily disable this change unless the temporary
11958 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11959
8727937b
PE
11960 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11961
8ac068ac
PE
11962 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11963 This removes an assumption that EMACS_INT and long are the same
11964 width as pointers. The assumption is true for Emacs porting targets
11965 now, but we want to make other targets possible.
11966 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11967 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11968 In the rest of the code, change types of integers that hold casted
11969 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11970 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11971 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11972 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11973 No need to cast type when ORing.
11974 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11975 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11976 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11977 assume EMACS_INT is the same width as char *.
11978 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11979 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11980 Remove no-longer-needed casts.
11981 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11982 (xg_tool_bar_help_callback, xg_make_tool_item):
11983 Use EMACS_INTPTR to hold an integer
11984 that will be cast to void *; this can avoid a GCC warning
11985 if EMACS_INT is not the same width as void *.
11986 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11987 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11988 (current_message_1, set_message_1):
11989 Use a local to convert to proper width without a cast.
11990 * xmenu.c (dialog_selection_callback): Likewise.
11991
ede49d71
PE
11992 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11993 Also, don't assume VALBITS / RAND_BITS is less than 5,
11994 and don't rely on undefined behavior when shifting a 1 left into
11995 the sign bit.
11996 * lisp.h (get_random): Change signature to match.
11997
2f30ecd0
PE
11998 * lread.c (hash_string): Use size_t, not int, for hash computation.
11999 Normally we prefer signed values; but hashing is special, because
12000 it's better to use unsigned division on hash table sizes so that
12001 the remainder is nonnegative. Also, size_t is the natural width
12002 for hashing into memory. The previous code used 'int', which doesn't
12003 retain enough info to hash well into very large tables.
12004 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12005
2a866e7b
PE
12006 * dbusbind.c: Don't possibly lose pointer info when converting.
12007 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12008 Use XPNTR rather than XHASH, so that the high-order bits of
12009 the pointer aren't lost when converting through void *.
12010
51639eac
PE
12011 * eval.c (Fautoload): Don't double-shift a pointer.
12012
92394119
PE
12013 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12014
dbdb9a7c
JB
120152011-05-06 Juanma Barranquero <lekktu@gmail.com>
12016
12017 * gnutls.c (DEF_GNUTLS_FN):
12018 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12019
db7a0b4f
AS
120202011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12021
12022 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12023 marker. (Bug#8610)
12024
cd394be1 120252011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12026
12027 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12028 New version that can reserve upto 2GB of heap space.
12029
f7ff1b0f 120302011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12031
12032 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12033
639c109b
TZ
120342011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12035
12036 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12037 `gnutls_certificate_set_x509_key_file'.
12038
d2127135
JB
120392011-05-05 Juanma Barranquero <lekktu@gmail.com>
12040
12041 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12042 Update dependencies.
12043
e968f4f3
JB
120442011-05-04 Juanma Barranquero <lekktu@gmail.com>
12045
12046 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12047 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12048 Remove unused parameter `fildes'.
12049 * process.c (read_process_output, send_process): Don't pass it.
12050
84d358f0
JB
120512011-05-04 Juanma Barranquero <lekktu@gmail.com>
12052
12053 Fix previous change: the library cache is defined in w32.c.
12054 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12055 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12056
0898ca10
JB
120572011-05-04 Juanma Barranquero <lekktu@gmail.com>
12058
12059 Implement dynamic loading of GnuTLS on Windows.
12060
12061 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12062 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12063 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12064 Declare.
12065
12066 * gnutls.c (Qgnutls_dll): Define.
12067 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12068 (gnutls_*): Declare function pointers.
12069 (init_gnutls_functions): New function to initialize function pointers.
12070 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12071 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12072 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12073 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12074 (emacs_gnutls_write, emacs_gnutls_read)
12075 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12076 (Fgnutls_available_p): New function.
12077 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12078 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12079 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12080
12081 * image.c: Include w32.h.
12082 (Vimage_type_cache): Delete.
12083 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12084 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12085 (w32_delayed_load): Move to w32.c.
12086
12087 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12088
12089 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12090 (w32_delayed_load): Move from image.c. When loading a library, record
12091 its filename in the :loaded-from property of the library id.
12092 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12093 Initialize and staticpro them.
12094 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12095
12096 * process.c: Include lisp.h before w32.h, not after.
12097 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12098 instead of gnutls_record_check_pending.
12099
12100 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12101
ff4de4aa
TZ
121022011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12103
12104 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12105 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12106 as passed in.
12107
abe95abb
JD
121082011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12109
12110 * xterm.c (x_set_frame_alpha): Do not set property on anything
12111 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12112
e16e55d4
JB
121132011-05-02 Juanma Barranquero <lekktu@gmail.com>
12114
12115 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12116
bafcf6a5
JB
121172011-05-02 Juanma Barranquero <lekktu@gmail.com>
12118
12119 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12120 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12121 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12122 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12123 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12124 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12125 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12126 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12127 (Qgnutls_bootprop_callbacks_verify): Make static.
12128
e7a6747f
AS
121292011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12130
19ed11ba
AS
12131 * callproc.c: Indentation fixup.
12132
e7a6747f 12133 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12134 (wait_for_termination, interruptible_wait_for_termination):
12135 Move after wait_for_termination_1.
e7a6747f 12136
1ef14cb4
LMI
121372011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12138
12139 * sysdep.c (interruptible_wait_for_termination): New function
12140 which is like wait_for_termination, but allows keyboard
12141 interruptions.
12142
12143 * callproc.c (Fcall_process): Add (:file "file") as an option for
12144 the STDOUT buffer.
12145 (Fcall_process_region): Ditto.
12146
330d880c
EZ
121472011-04-30 Eli Zaretskii <eliz@gnu.org>
12148
8db90b73
EZ
12149 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12150 rather than `XVECTOR (FOO)->size'.
12151
330d880c
EZ
12152 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12153 inttypes.h, as a gnulib replacement is used if it not available in
12154 system headers.
12155
15cbd324
EZ
121562011-04-21 Eli Zaretskii <eliz@gnu.org>
12157
12158 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12159 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12160 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12161
12162 * coding.c (coding_alloc_by_realloc): Error out if destination
12163 will grow beyond MOST_POSITIVE_FIXNUM.
12164 (decode_coding_emacs_mule): Abort if there isn't enough place in
12165 charbuf for the composition carryover bytes. Reserve an extra
12166 space for up to 2 characters produced in a loop.
12167 (decode_coding_iso_2022): Abort if there isn't enough place in
12168 charbuf for the composition carryover bytes.
12169
121702011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12171
ae940cca
EZ
12172 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12173 aborting when %lld or %lll format is passed.
12174 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12175 %llo or %llx format is passed. (Bug#8545)
12176
03ab8921
EZ
12177 * window.c (window_scroll_line_based): Use a marker instead of
12178 simple variables to record original value of point. (Bug#7952)
12179
afda1437
EZ
12180 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12181 produced by %s or %c overflows available buffer space. (Bug#8545)
12182
f76dee0c
PE
121832011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12184
12185 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12186 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12187
fdc5744d
JB
121882011-04-28 Juanma Barranquero <lekktu@gmail.com>
12189
12190 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12191
638f053a
JB
121922011-04-28 Juanma Barranquero <lekktu@gmail.com>
12193
12194 * keyboard.c (Qdelayed_warnings_hook): Define.
12195 (command_loop_1): Run `delayed-warnings-hook'
12196 if Vdelayed_warnings_list is non-nil.
12197 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12198 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12199
d178f871
EZ
122002011-04-28 Eli Zaretskii <eliz@gnu.org>
12201
12202 * doprnt.c (doprnt): Don't return value smaller than the buffer
12203 size if the message was truncated. (Bug#8545).
12204
b124fd93
JB
122052011-04-28 Juanma Barranquero <lekktu@gmail.com>
12206
12207 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12208 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12209
e810457d
PE
122102011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12211
12212 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12213
ea51cceb
JB
122142011-04-27 Juanma Barranquero <lekktu@gmail.com>
12215
12216 * makefile.w32-in: Update dependencies.
12217
94dcfacf
EZ
122182011-04-27 Eli Zaretskii <eliz@gnu.org>
12219
12220 Improve `doprnt' and its usage. (Bug#8545)
12221 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12222 `format_end'. Remove support for %l as a conversion specifier.
12223 Don't use xrealloc. Improve diagnostics when the %l size modifier
12224 is used. Update the commentary.
12225
12226 * eval.c (verror): Simplify calculation of size_t.
12227
12228 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12229 messages.
12230
f61f41d7
PE
122312011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12232
12233 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12234 change.
12235
96fb4434
PE
122362011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12237
12238 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12239 This makes this file independent of the recent pseudovector change.
12240
671875da 122412011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12242
69e9b5a3
PE
12243 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12244
b5f869a7 12245 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12246 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12247 Remove unused local.
c8926152 12248 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12249
841a1577 12250 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12251 GCC 4.6.0 optimizes based on type-based alias analysis.
12252 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12253 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12254 != &v->size, and therefore "v->size = 1; b->size = 2; return
12255 v->size;" must therefore return 1. This assumption is incorrect
12256 for Emacs, since it type-puns struct Lisp_Vector * with many other
12257 types. To fix this problem, this patch adds a new type struct
f904488f 12258 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12259 and pseudovectors, and helps optimizing compilers not get fooled
12260 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12261 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12262 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12263 the size member.
eab3844f
PE
12264 (XSETPVECTYPE): Rewrite in terms of new macro.
12265 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12266 This is a bit clearer, and further avoids the possibility of
12267 undesirable aliasing.
12268 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12269 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12270 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12271 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12272 (ASIZE): Now uses header.size rather than size.
12273 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12274 to avoid the hassle of writing XVECTOR (foo)->header.size.
12275 (struct vectorlike_header): New type.
eab3844f
PE
12276 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12277 object, to help avoid aliasing.
12278 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12279 (SUBRP): Likewise, since Lisp_Subr is a special case.
12280 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12281 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12282 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12283 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12284 changed to be "header.size" and "header.next".
12285 * buffer.h (struct buffer): Likewise.
12286 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12287 * frame.h (struct frame): Likewise.
12288 * process.h (struct Lisp_Process): Likewise.
12289 * termhooks.h (struct terminal): Likewise.
12290 * window.c (struct save_window_data, struct saved_window): Likewise.
12291 * window.h (struct window): Likewise.
12292 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12293 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12294 * buffer.c (init_buffer_once): Likewise.
12295 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12296 special case.
12297 * process.c (Fformat_network_address): Use local var for size,
12298 for brevity.
12299
0df1eac5
PE
12300 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12301
847ab9d1 12302 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12303 * data.c (atof): Remove decl; no longer used or needed.
12304 (digit_to_number): Move to lread.c.
12305 (Fstring_to_number): Use new string_to_number function, to be
12306 consistent with how the Lisp reader treats infinities and NaNs.
12307 Do not assume that floating-point numbers represent EMACS_INT
12308 without losing information; this is not true on most 64-bit hosts.
12309 Avoid double-rounding errors, by insisting on integers when
12310 parsing non-base-10 numbers, as the documentation specifies.
12311 * lisp.h (string_to_number): New decl, replacing ...
12312 (isfloat_string): Remove.
bc0a5c13 12313 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12314 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12315 appears to have been a coding error. Similarly, do not accept
12316 strings like +-1e0 as floating point numbers. Do not report
12317 overflow for integer overflows unless the base is not 10 which
12318 means we have no simple and reliable way to continue.
12319 Break out the floating-point parsing into a new
12320 function string_to_number, so that Fstring_to_number parses
12321 floating point numbers consistently with the Lisp reader.
04f2d78b 12322 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12323 (E_CHAR, EXP_INT): Remove, replacing with ...
12324 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12325 (string_to_number): New function, replacing isfloat_string.
12326 This function checks for valid syntax and produces the resulting
12327 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12328 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12329 so that overflow for non-base-10 numbers is reported only when
12330 there's no portable and simple way to convert to floating point.
452f4150 12331
67769ffc
PE
12332 * textprop.c (set_text_properties_1): Rewrite for clarity,
12333 and to avoid GCC warning about integer overflow.
12334
c20db43f
PE
12335 * intervals.h (struct interval): Use EMACS_INT for members
12336 where EMACS_UINT might cause problems. See
12337 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12338 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12339 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12340 All uses changed.
37aa2f85
PE
12341 (offset_intervals): Tell GCC not to worry about length overflow
12342 when negating a negative length.
c20db43f 12343
2538aa2f
PE
12344 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12345 (overrun_check_free): Likewise.
12346
f2d3008d
PE
12347 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12348 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12349 word size.
12350
ec8df744
PE
12351 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12352 (gnutls_make_error): Rename local to avoid shadowing.
12353 (gnutls_emacs_global_deinit): ifdef out; not used.
12354 (Fgnutls_boot): Use const for pointer to readonly storage.
12355 Comment out unused local. Fix pointer signedness problems.
12356
640ee02d
PE
12357 * lread.c (openp): Don't stuff size_t into an 'int'.
12358 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12359 about possible signed overflow.
12360
6048fb2a
PE
12361 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12362 (GDK_KEY_g): Don't define if already defined.
12363 (xg_prepare_tooltip): Avoid pointer signedness problem.
12364 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12365
fa3c87e1
PE
12366 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12367 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12368
2172544b
PE
12369 * xfns.c (Fx_window_property): Simplify a bit,
12370 to make a bit faster and to avoid GCC 4.6.0 warning.
12371 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12372
9b821a21
PE
12373 * fns.c (internal_equal): Don't assume size_t fits in int.
12374
3c616cfa
PE
12375 * alloc.c (compact_small_strings): Tighten assertion a little.
12376
c2982e87
PE
12377 Replace pEd with more-general pI, and fix some printf arg casts.
12378 * lisp.h (pI): New macro, generalizing old pEd macro to other
12379 conversion specifiers. For example, use "...%"pI"d..." rather
12380 than "...%"pEd"...".
12381 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12382 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12383 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12384 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12385 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12386 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12387 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12388 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12389 64-bit hosts.
12390 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12391 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12392 * print.c (safe_debug_print, print_object): Likewise.
12393 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12394 to int.
6f04d126
PE
12395 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12396 avoiding the 0 flag, which is not portable.
c2982e87
PE
12397 * process.c (Fmake_network_process): Use pI to avoid cast.
12398 * region-cache.c (pp_cache): Likewise.
12399 * xdisp.c (decode_mode_spec): Likewise.
12400 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12401 behavior on 64-bit hosts with printf arg.
6f04d126 12402 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12403 (x_stop_queuing_selection_requests): Likewise.
12404 (x_get_window_property): Don't truncate byte count to an 'int'
12405 when tracing.
0b432f21 12406
5e073ec7
PE
12407 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12408 here, since it parses constructs like leading '-' and spaces,
12409 which are not wanted; and it overflows with large numbers.
12410 Instead, simply match F[0-9]+, which is what is wanted anyway.
12411
36372bf9
PE
12412 * alloc.c: Remove unportable assumptions about struct layout.
12413 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12414 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12415 (allocate_vectorlike, make_pure_vector): Use the new macros,
12416 plus offsetof, to remove unportable assumptions about struct layout.
12417 These assumptions hold on all porting targets that I know of, but
12418 they are not guaranteed, they're easy to remove, and removing them
12419 makes further changes easier.
12420
0b432f21
PE
12421 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12422 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12423 (string_overrun_cookie): Now const. Use initializers that
12424 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12425 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12426 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12427 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12428 multiple of sizeof (EMACS_INT); it need not be, if
12429 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12430 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12431
895009e1
JB
124322011-04-26 Juanma Barranquero <lekktu@gmail.com>
12433
12434 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12435
6a7a1b0b
TZ
124362011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12437
12438 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12439 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12440 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12441
841a1577 124422011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12443
12444 * lisp.h (Qdebug): List symbol.
895009e1 12445 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12446 * keyboard.c (debug-on-event): New variable.
12447 (handle_user_signal): Break into debugger when debug-on-event
12448 matches the current signal symbol.
12449
f2d3ba6f
DN
124502011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12451
12452 * alloc.c (check_sblock, check_string_bytes)
12453 (check_string_free_list): Convert to standard C.
12454
42ce4c63
TZ
124552011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12456
12457 * w32.c (emacs_gnutls_push): Fix typo.
12458
825cd63c
EZ
124592011-04-25 Eli Zaretskii <eliz@gnu.org>
12460
fb11d64d
EZ
12461 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12462 "cast to pointer from integer of different size".
12463
825cd63c
EZ
12464 Improve doprnt and its use in verror. (Bug#8545)
12465 * doprnt.c (doprnt): Document the set of format control sequences
12466 supported by the function. Use SAFE_ALLOCA instead of always
12467 using `alloca'.
12468
12469 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12470 is one byte too soon. Don't use xrealloc; instead xfree and
12471 xmalloc anew.
12472
e061a11b
TZ
124732011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12474
12475 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12476 callbacks stage.
12477
12478 * gnutls.c: Renamed global_initialized to
12479 gnutls_global_initialized. Added internals for the
12480 :verify-hostname-error, :verify-error, and :verify-flags
12481 parameters of `gnutls-boot' and documented those parameters in the
12482 docstring. Start callback support.
9173deec
JB
12483 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12484 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12485 on error. Return error code.
e061a11b
TZ
12486 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12487 (emacs_gnutls_read): Likewise.
12488 (Fgnutls_boot): Return handshake error code.
12489 (emacs_gnutls_handle_error): New function.
12490 (wsaerror_to_errno): Likewise.
12491
12492 * w32.h (emacs_gnutls_pull): Add prototype.
12493 (emacs_gnutls_push): Likewise.
12494
12495 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12496 (emacs_gnutls_push): Likewise.
12497
124982011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12499
12500 * process.c (wait_reading_process_output): Check if GnuTLS
12501 buffered some data internally if no FDs are set for TLS
12502 connections.
12503
12504 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12505 (LIBS): Link to USER_LIBS.
12506 ($(BLD)/gnutls.$(0)): New target.
12507
fa6996bc
EZ
125082011-04-24 Eli Zaretskii <eliz@gnu.org>
12509
eb35682e
EZ
12510 * xdisp.c (handle_single_display_spec): Rename the
12511 display_replaced_before_p argument into display_replaced_p, to
12512 make it consistent with the commentary. Fix typos in the
12513 commentary.
12514
e2ad650c
EZ
12515 * textprop.c (syms_of_textprop): Remove dead code.
12516 (copy_text_properties): Delete obsolete commentary about an
12517 interface that was deleted long ago. Fix typos in the description
12518 of arguments.
12519
1b2de274
EZ
12520 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12521 to changes in oldXMenu/XMenu.h from 2011-04-16.
12522 <menu_help_message, prev_menu_help_message>: Constify.
12523 (IT_menu_make_room): menu->help_text is now `const char **';
12524 adjust.
12525
12526 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12527 to changes in oldXMenu/XMenu.h from 2011-04-16.
12528 (struct XMenu): Declare `help_text' `const char **'.
12529
12530 * xfaces.c <Qunspecified>: Make extern again.
12531
12532 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12533 required by POSIX.
1b2de274 12534
762b15be
EZ
12535 * doc.c (get_doc_string): Improve the format passed to `error'.
12536
12537 * doprnt.c (doprnt): Improve commentary.
12538
12539 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12540
12541 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12542 them with etags.
12543
f1052e5d
EZ
12544 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12545 changes in globals.h immediately force recompilation.
762b15be
EZ
12546 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12547 $(CURDIR)/s/ms-w32.h.
12548 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12549
fa6996bc
EZ
12550 * character.c (Fchar_direction): Function deleted.
12551 (syms_of_character): Don't defsubr it.
12552 <char-direction-table>: Deleted.
12553
e6c3da20
EZ
125542011-04-23 Eli Zaretskii <eliz@gnu.org>
12555
12556 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12557 * doprnt.c: Include limits.h.
12558 (SIZE_MAX): New macro.
04f2d78b
CB
12559 (doprnt): Return a size_t value. 2nd arg is now size_t.
12560 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12561 Improve overflow protection. Support `l' modifier for integer
12562 conversions. Support %l conversion. Don't assume an EMACS_INT
12563 argument for integer conversions and for %c.
12564
12565 * lisp.h (doprnt): Restore prototype.
12566
12567 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12568 $(SRC)/character.h.
12569
12570 * Makefile.in (base_obj): Add back doprnt.o.
12571
12572 * deps.mk (doprnt.o): Add back prerequisites.
12573 (callint.o): Depend on character.h.
12574
12575 * eval.c (internal_lisp_condition_case): Include the handler
12576 representation in the error message.
12577 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12578 when breaking from the loop.
12579
12580 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12581
12582 * callint.c (Fcall_interactively): When displaying error message
12583 about invalid control letter, pass the character's codepoint, not
12584 a pointer to its multibyte form. Improve display of the character
12585 in octal and display also its hex code.
12586
12587 * character.c (char_string): Use %x to display the (unsigned)
12588 codepoint of an invalid character, to avoid displaying a bogus
12589 negative value.
12590
12591 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12592 `error', not SYMBOL_NAME itself.
12593
12594 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12595 character arguments to `error'.
12596
12597 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12598 to `error' in error message about FINAL_CHAR argument. Make sure
12599 FINAL_CHAR is a character, and use %c when it is passed as
12600 argument to `error'.
12601
4ffd0d6b 126022011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12603
12604 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12605
12606 * w32.c: Include <time.h>.
12607 (sys_localtime): New function.
12608
4ffd0d6b 126092011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12610
12611 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12612
4ffd0d6b 12613 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12614
4ffd0d6b 126152011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12616
4ffd0d6b
GM
12617 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12618 zombies (Bug#8467).
aac0c6e3 12619
04c56954
EZ
126202011-04-19 Eli Zaretskii <eliz@gnu.org>
12621
12622 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12623 gl_state.e_property when gl_state.object is Qt.
12624
12625 * insdel.c (make_gap_larger): Remove limitation of buffer size
12626 to <= INT_MAX.
12627
16a43933
CY
126282011-04-18 Chong Yidong <cyd@stupidchicken.com>
12629
12630 * xdisp.c (lookup_glyphless_char_display)
12631 (produce_glyphless_glyph): Handle cons cell entry in
12632 glyphless-char-display.
12633 (Vglyphless_char_display): Document it.
12634
12635 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12636 glyphless-char-display.
12637
4581706e
CY
126382011-04-17 Chong Yidong <cyd@stupidchicken.com>
12639
12640 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12641
12642 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12643
12644 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12645 definition for no-X builds.
12646
4887c6e2 126472011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12648
fd35b6f9
PE
12649 Static checks with GCC 4.6.0 and non-default toolkits.
12650
5c1ccb01
PE
12651 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12652
006c5daa
PE
12653 * process.c (keyboard_bit_set): Define only if SIGIO.
12654 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12655 (send_process): Repair possible setjmp clobbering.
12656
efc736d3
PE
12657 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12658
4e2fe2e6
PE
12659 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12660
f97334a2
PE
12661 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12662
4e75f29d
PE
12663 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12664 Define only if needed.
12665
90efadd1
PE
12666 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12667 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12668 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12669
3c647824
PE
12670 * dispextern.h (struct redisplay_interface): Rename param
12671 to avoid shadowing.
e264f262 12672 * termhooks.h (struct terminal): Likewise.
761383f4 12673 * xterm.c (xembed_send_message): Likewise.
3c647824 12674
b58c5c4a
PE
12675 * insdel.c (make_gap_smaller): Define only if
12676 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12677
cad59032
PE
12678 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12679 it.
12680
c339dc2e
PE
12681 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12682 so that we aren't warned about unused symbols.
12683
91a3e27b
PE
12684 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12685
399c71d3 12686 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12687
8ffc96f5
PE
12688 * xfns.c (x_real_positions): Mark locals as initialized.
12689
eef9bc79
PE
12690 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12691
098db9dd
PE
12692 * xterm.c: Fix problems found by static analysis with other toolkits.
12693 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12694 (x_dispatch_event): Declare static if USE_GTK, and
12695 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12696 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12697 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12698 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12699 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12700
eb18f6cc
PE
12701 * xmenu.c (menu_help_callback): Pointer type fixes.
12702 Use const pointers when pointing at readonly data. Avoid pointer
12703 signedness clashes.
12704 (FALSE): Remove unused macro.
12705 (update_frame_menubar): Remove unused decl.
12706
1fe72bf8
PE
12707 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12708
60d9e1db
PE
12709 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12710 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12711 (single_menu_item): Rename local to avoid shadowing.
12712
39261c26
PE
12713 * keyboard.c (make_lispy_event): Remove unused local var.
12714
018c5e19
PE
12715 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12716 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12717
63d2b86e
PE
12718 * bitmaps: Change bitmaps from unsigned char back to the X11
12719 compatible char. Avoid the old compiler warnings about
12720 out-of-range initializers by using, for example, '\xab' rather
12721 than 0xab.
12722
aefd87e1
PE
12723 * xgselect.c (xgselect_initialize): Check vs interface
12724 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12725
bf501fb9
PE
12726 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12727
e9829fdf
PE
12728 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12729 to read-only memory.
12730
1086c095
PE
12731 * fns.c (vector): Remove; this old hack is no longer needed.
12732
2baccd04 12733 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12734 Remove unused var.
dde42981 12735 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12736
72391843 12737 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12738
436c16df 12739 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12740 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12741 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12742
92bb796d 12743 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12744 (x_term_init): Remove local to avoid shadowing.
92bb796d 12745
764430a3 12746 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12747
12748 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12749 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12750
d1dfb56c
EZ
127512011-04-16 Eli Zaretskii <eliz@gnu.org>
12752
c4354cb4
EZ
12753 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12754
d1dfb56c
EZ
12755 Fix regex.c, syntax.c and friends for buffers > 2GB.
12756 * syntax.h (struct gl_state_s): Declare character position members
12757 EMACS_INT.
12758
12759 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12760
04f2d78b
CB
12761 * textprop.c (verify_interval_modification, interval_of):
12762 Declare arguments EMACS_INT.
d1dfb56c
EZ
12763
12764 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12765 EMACS_INT.
12766
12767 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12768
12769 * indent.c (Fvertical_motion): Local variable it_start is now
12770 EMACS_INT.
12771
12772 * regex.c (re_match, re_match_2, re_match_2_internal)
12773 (bcmp_translate, regcomp, regexec, print_double_string)
12774 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12775 (re_compile_pattern, re_exec): Declare arguments and local
12776 variables `size_t' and `ssize_t' and return values `regoff_t', as
12777 appropriate.
12778 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12779 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12780 <compile_stack_type>: `size' and `avail' are now `size_t'.
12781
12782 * regex.h <regoff_t>: Use ssize_t, not int.
12783 (re_search, re_search_2, re_match, re_match_2): Arguments that
12784 specify buffer/string position and length are now ssize_t and
12785 size_t. Return type is regoff_t.
12786
613052cd
BK
127872011-04-16 Ben Key <bkey76@gmail.com>
12788
12789 * nsfont.m: Fixed bugs in ns_get_family and
12790 ns_descriptor_to_entity that were caused by using free to
12791 deallocate memory blocks that were allocated by xmalloc (via
12792 xstrdup). This caused Emacs to crash when compiled with
12793 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12794 --enable-checking=xmallocoverrun). xfree is now used to
12795 deallocate these memory blocks.
12796
4170f62f 127972011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12798
71b41406
PE
12799 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12800
9587a89d
PE
12801 emacs_write: Accept and return EMACS_INT for sizes.
12802 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12803 et seq.
12804 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12805 Accept and return EMACS_INT.
12806 (emacs_gnutls_write): Return the number of bytes written on
12807 partial writes.
12808 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12809 (emacs_read, emacs_write): Remove check for negative size, as the
12810 Emacs source code has been audited now.
9587a89d
PE
12811 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12812 (emacs_read, emacs_write): Use it.
273a5f82
PE
12813 * process.c (send_process): Adjust to the new signatures of
12814 emacs_write and emacs_gnutls_write. Do not attempt to store
12815 a byte offset into an 'int'; it might overflow.
9587a89d 12816 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12817
3e047f51
PE
12818 * sound.c: Don't assume sizes fit in 'int'.
12819 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12820 Return EMACS_INT, not int.
3e047f51 12821 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12822 Accept EMACS_INT, not int.
12823 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12824 record read return values.
12825
cc39a9db
BK
128262011-04-15 Ben Key <bkey76@gmail.com>
12827
c9d0ec6d
JB
12828 * keyboard.c (Qundefined): Don't declare static since it is used
12829 in nsfns.m.
12830 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12831 static since they are used in nsfont.m.
cc39a9db 12832
6c60eb9f
SM
128332011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12834
12835 * process.c (Qprocessp): Don't declare static.
12836 * lisp.h (Qprocessp): Declare again.
12837
7990b61a
JB
128382011-04-15 Juanma Barranquero <lekktu@gmail.com>
12839
12840 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12841
5d4cb038
PE
128422011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12843
8bd7b830 12844 Improve C-level modularity by making more things 'static'.
cd64ea1d 12845
e3b27b31
PE
12846 Don't publish debugger-only interfaces to other modules.
12847 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12848 (verify_bytepos, count_markers): Move decls to the only modules
12849 that need them.
12850 * region-cache.h (pp_cache): Likewise.
12851 * window.h (check_all_windows): Likewise.
12852 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12853
5d4cb038
PE
12854 * sysdep.c (croak): Now static, if
12855 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12856 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12857
12858 * alloc.c (refill_memory_reserve): Now static if
12859 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12860 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12861
e87b6180
PE
12862 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12863 Define only if USE_LUCID.
12864
ac64929e
PE
12865 * xrdb.c (x_customization_string, x_rm_string): Now static.
12866
6f37259d
PE
12867 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12868 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12869
1683e3ab
PE
12870 * xdisp.c (draw_row_with_mouse_face): Now static.
12871 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12872
de9c2632
PE
12873 * window.h (check_all_windows): Mark externally visible.
12874
2b96acb7
PE
12875 * window.c (window_deletion_count): Now static.
12876
12877 * undo.c: Make symbols static if they're not exported.
12878 (last_undo_buffer, last_boundary_position, pending_boundary):
12879 Now static.
12880
50436f33
PE
12881 * textprop.c (interval_insert_behind_hooks): Now static.
12882 (interval_insert_in_front_hooks): Likewise.
12883
64520e5c
PE
12884 * term.c: Make symbols static if they're not exported.
12885 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12886 (max_frame_lines, tty_set_terminal_modes):
12887 (tty_reset_terminal_modes, tty_turn_off_highlight):
12888 (get_tty_terminal): Now static.
12889 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12890 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12891 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12892 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12893 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12894
1fa53021
PE
12895 * sysdep.c: Make symbols static if they're not exported.
12896 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12897 Now static.
12898 (sigprocmask_set, full_mask): Remove; unused.
12899 (wait_debugging): Mark as visible.
12900 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12901 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12902
d4b43b22
PE
12903 * syntax.c (syntax_temp): Define only if !__GNUC__.
12904
b7c513d0
PE
12905 * sound.c (current_sound_device, current_sound): Now static.
12906
989b29ad
PE
12907 * search.c (searchbufs, searchbuf_head): Now static.
12908
13a55a78
PE
12909 * scroll.c (scroll_cost): Remove; unused.
12910 * dispextern.h (scroll_cost): Remove decl.
12911
de68a1fc
PE
12912 * region-cache.h (pp_cache): Mark as externally visible.
12913
40ccffa6
PE
12914 * process.c: Make symbols static if they're not exported.
12915 (process_tick, update_tick, create_process, chan_process):
12916 (Vprocess_alist, proc_buffered_char, datagram_access):
12917 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12918 (deactivate_process): Mark defn as static, as well as decl.
12919 * lisp.h (create_process): Remove decl.
12920 * process.h (chan_process, Vprocess_alist): Remove decls.
12921
ad64fc97
PE
12922 * print.c: Make symbols static if they're not exported.
12923 (print_depth, new_backquote_output, being_printed, print_buffer):
12924 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12925 (print_interval, print_number_index, initial_stderr_stream):
12926 Now static.
12927 * lisp.h (Fprinc): Remove decl.
12928 (debug_output_compilation_hack): Mark as externally visible.
12929
adddb265
PE
12930 * sysdep.c (croak): Move decl from here to syssignal.h.
12931 * syssignal.h (croak): Put it here, so the API can be checked when
12932 'croak' is called from dissociate_if_controlling_tty.
12933
1717ede2
PE
12934 * minibuf.c: Make symbols static if they're not exported.
12935 (minibuf_save_list, choose_minibuf_frame): Now static.
12936 * lisp.h (choose_minibuf_frame): Remove decl.
12937
fa5fb2bc
PE
12938 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12939
1e3890d1
PE
12940 * lread.c: Make symbols static if they're not exported.
12941 (read_objects, initial_obarray, oblookup_last_bucket_number):
12942 Now static.
12943 (make_symbol): Remove; unused.
12944 * lisp.h (initial_obarray, make_symbol): Remove decls.
12945
8a1414fa
PE
12946 * keyboard.c: Make symbols static if they're not exported.
12947 (single_kboard, recent_keys_index, total_keys, recent_keys):
12948 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12949 (this_single_command_key_start, echoing, last_auto_save):
12950 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12951 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12952 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12953 (Vlispy_mouse_stem, double_click_count):
12954 Now static.
12955 (force_auto_save_soon): Define only if SIGDANGER.
12956 (ignore_mouse_drag_p): Now static if
12957 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12958 (print_help): Remove; unused.
12959 (stop_character, last_timer_event): Mark as externally visible.
12960 * keyboard.h (ignore_mouse_drag_p): Declare only if
12961 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12962 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12963 * lisp.h (echoing): Remove decl.
12964 (force_auto_save_soon): Declare only if SIGDANGER.
12965 * xdisp.c (redisplay_window): Simplify code, to make it more
12966 obvious that ignore_mouse_drag_p is not accessed if !defined
12967 USE_GTK && !defined HAVE_NS.
12968
93ea6e8f
PE
12969 * intervals.c: Make symbols static if they're not exported.
12970 (merge_properties_sticky, merge_interval_right, delete_interval):
12971 Now static.
12972 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12973
77382fcc
PE
12974 * insdel.c: Make symbols static if they're not exported.
12975 However, leave prepare_to_modify_buffer alone. It's never
12976 called from outside this function, but that appears to be a bug.
12977 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12978 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12979 (adjust_after_replace_noundo): Remove; unused.
12980 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12981 (signal_before_change): Remove decls.
77382fcc 12982
9306c32e
PE
12983 * indent.c (val_compute_motion, val_vmotion): Now static.
12984
cd44d2eb
PE
12985 * image.c: Make symbols static if they're not exported.
12986 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12987 if USE_GTK.
12988 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12989 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12990
ad9a7a06
PE
12991 * fringe.c (standard_bitmaps): Now static.
12992 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12993
81626931
PE
12994 * frame.c: Make symbols static if they're not exported.
12995 (x_report_frame_params, make_terminal_frame): Now static.
12996 (get_frame_param): Now static, unless HAVE_NS.
12997 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12998 (x_get_resource_string): Remove; not used.
12999 * frame.h (make_terminal_frame, x_report_frame_params):
13000 (x_get_resource_string); Remove decls.
13001 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13002 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13003
239f9db9
PE
13004 * font.c, fontset.c: Make symbols static if they're not exported.
13005 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13006 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13007 * font.c (font_close_object): Now static.
13008 * font.h (font_close_object): Remove.
13009 * fontset.c (FONTSET_OBJLIST): Remove.
13010 (free_realized_fontset) #if-0 the body, which does nothing.
13011 (face_suitable_for_char_p): #if-0, as it's never called.
13012 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13013 * xfaces.c (face_at_string_position):
13014 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13015 since 0 is always ASCII.
13016
dfcf3579
PE
13017 * fns.c (weak_hash_tables): Now static.
13018
5045092b
PE
13019 * fileio.c: Make symbols static if they're not exported.
13020 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13021 (Vwrite_region_annotation_buffers): Now static.
13022
57a96f5c
PE
13023 * eval.c: Make symbols static if they're not exported.
13024 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13025 * lisp.h (backtrace_list): Remove decl.
13026
35f08c38
PE
13027 * emacs.c: Make symbols static if they're not exported.
13028 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13029 (fatal_error_code, fatal_error_signal_hook, standard_args):
13030 Now static.
13031 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13032 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13033 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13034 * lisp.h (fatal_error_signal_hook): Remove decl.
13035 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13036
f44bd759
PE
13037 * editfns.c: Move a (normally-unused) function to its only use.
13038 * editfns.c, lisp.h (get_operating_system_release): Remove.
13039 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13040 worth the hassle of breaking this out.
13041
b532497d
PE
13042 * xterm.c: Make symbols static if they're not exported.
13043 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13044 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13045 (x_destroy_window, x_delete_display):
13046 Now static.
13047 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13048 (x_mouse_leave): Remove; unused.
13049 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13050 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13051 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13052 Remove decls.
13053 (x_mouse_leave): Declare only if WINDOWSNT.
13054 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13055 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13056 USE_X_TOOLKIT.
13057
1675728f
PE
13058 * ftxfont.c: Make symbols static if they're not exported.
13059 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13060 HAVE_FREETYPE.
13061 * font.h (ftxfont_driver): Likewise.
13062
e4cebfca
PE
13063 * xfns.c: Make symbols static if they're not exported.
13064 (x_last_font_name, x_display_info_for_name):
13065 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13066 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13067 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13068 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13069 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13070 (last_show_tip_args): Now static.
13071 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13072 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13073 (x_screen_planes): Remove; unused.
13074 * dispextern.h (x_screen_planes): Remove decl.
13075
5bf46f05
PE
13076 * dispnew.c: Make symbols static if they're not exported.
13077 * dispextern.h (redraw_garbaged_frames, scrolling):
13078 (increment_row_positions): Remove.
13079 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13080 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13081 Now static.
13082 (redraw_garbaged_frames): Remove; unused.
13083
435f4c28
PE
13084 * xfaces.c: Make symbols static if they're not exported.
13085 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13086 Remove decls.
13087 * xterm.h (defined_color): Remove decls.
13088 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13089 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13090 (menu_face_changed_default, defined_color, free_realized_face):
13091 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13092 (ascii_face_of_lisp_face): Remove; unused.
13093
8524aef3
PE
13094 * xdisp.c: Make symbols static if they're not exported.
13095 * dispextern.h (scratch_glyph_row, window_box_edges):
13096 (glyph_to_pixel_coords, set_cursor_from_row):
13097 (get_next_display_element, set_iterator_to_next):
13098 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13099 (show_mouse_face): Remove decls
13100 * frame.h (message_buf_print): Likewise.
13101 * lisp.h (pop_message, set_message, check_point_in_composition):
13102 Likewise.
13103 * xterm.h (set_vertical_scroll_bar): Likewise.
13104 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13105 (message_buf_print, scratch_glyph_row, displayed_buffer):
13106 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13107 (get_next_display_element, show_mouse_face, window_box_edges):
13108 (frame_to_window_pixel_xy, check_point_in_composition):
13109 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13110 (glyph_to_pixel_coords): Remove; unused.
13111
16390cd2
PE
13112 * dired.c (file_name_completion): Now static.
13113
13114 * dbusbind.c (xd_in_read_queued_messages): Now static.
13115
a25f4dfa
PE
13116 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13117 * data.c (circular_list_error): Remove.
13118
14a9c8df
PE
13119 * commands.h (last_point_position, last_point_position_buffer):
13120 (last_point_position_window): Remove decls.
13121 * keyboard.c: Make these variables static.
13122
04f2d78b
CB
13123 * coding.h (coding, code_convert_region, encode_coding_gap):
13124 Remove decls.
74ab6df5
PE
13125 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13126 (iso_code_class, detect_coding, code_convert_region): Now static.
13127 (encode_coding_gap): Remove; unused.
13128
38dfbee1
PE
13129 * chartab.c (chartab_chars, chartab_bits): Now static.
13130
a2cb4e63
PE
13131 * charset.h (charset_iso_8859_1): Remove decl.
13132 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13133 Now static.
13134
127198fd
PE
13135 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13136 * ccl.c (Vccl_program_table): Now static.
13137 (check_ccl_update): Remove; unused.
13138
d85b608f
PE
13139 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13140 * category.h: ... from here.
13141 * category.c (check_category_table, set_category_set): Now static.
13142
31cd66f3
PE
13143 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13144 * lisp.h: Remove these decls.
13145
c358e587
PE
13146 * buffer.c (buffer_count): Remove unused var.
13147
e78aecca
PE
13148 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13149 so that it's not optimized away.
13150 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13151 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13152 exported only to the debugger.
13153
e192d7d3 13154 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13155 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13156
92470028
PE
13157 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13158 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13159 was inaccessible from Lisp.
13160 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13161 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13162
244ed907
PE
13163 alloc.c: Import and export fewer symbols, and remove unused items.
13164 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13165 is defined.
13166 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13167 it's not optimized away by whole-program optimization.
13168 (message_enable_multibyte, free_misc): Remove.
13169 (catchlist, handlerlist, mark_backtrace):
13170 Declare only if BYTE_MARK_STACK.
13171 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13172 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13173 (message_enable_multibyte): Remove decl.
13174 (free_misc, interval_free_list, float_block, float_block_index):
13175 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13176 (cons_free_list, last_marked_index):
13177 Now static.
13178 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13179 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13180 (mark_backtrace): Define only if BYTE_MARK_STACK.
13181 * xdisp.c (message_enable_multibyte): Now static.
13182
61c2b50e 13183 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13184 This makes it easier for human readers (and static analyzers)
13185 to see whether these variables are used from other modules.
13186 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13187 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13188 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13189 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13190 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13191 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13192 * xmenu.c, xselect.c:
13193 Declare Q* vars static if they are not used in other modules.
13194 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13195 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13196 Remove decls of unexported vars.
13197 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13198
95c82688
PE
13199 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13200
16a97296
PE
13201 Make Emacs functions such as Fatom 'static' by default.
13202 This makes it easier for human readers (and static analyzers)
13203 to see whether these functions can be called from other modules.
13204 DEFUN now defines a static function. To make the function external
13205 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13206 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13207 (Finit_image_library):
16a97296
PE
13208 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13209 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13210 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13211 Remove decls, since these functions are now static.
13212 (Funintern, Fget_internal_run_time): New decls, since these functions
13213 were already external.
95c82688 13214
16a97296
PE
13215 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13216 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13217 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13218 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13219 * keyboard.c, keymap.c, lread.c:
13220 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13221 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13222 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13223 Mark functions with DEFUE instead of DEFUN,
13224 if they are used in other modules.
13225 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13226 decls for now-static functions.
13227 * buffer.h (Fdelete_overlay): Remove decl.
13228 * callproc.c (Fgetenv_internal): Mark as internal.
13229 * composite.c (Fremove_list_of_text_properties): Remove decl.
13230 (Fcomposition_get_gstring): New forward static decl.
13231 * composite.h (Fcomposite_get_gstring): Remove decl.
13232 * dired.c (Ffile_attributes): New forward static decl.
13233 * doc.c (Fdocumntation_property): New forward static decl.
13234 * eval.c (Ffetch_bytecode): New forward static decl.
13235 (Funintern): Remove extern decl; now in .h file where it belongs.
13236 * fileio.c (Fmake_symbolic_link): New forward static decl.
13237 * image.c (Finit_image_library): New forward static decl.
13238 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13239 * intervals.h (Fprevious_property_change):
13240 (Fremove_list_of_text_properties): Remove decls.
13241 * keyboard.c (Fthis_command_keys): Remove decl.
13242 (Fcommand_execute): New forward static decl.
13243 * keymap.c (Flookup_key): New forward static decl.
13244 (Fcopy_keymap): Now static.
13245 * keymap.h (Flookup_key): Remove decl.
13246 * process.c (Fget_process): New forward static decl.
13247 (Fprocess_datagram_address): Mark as internal.
13248 * syntax.c (Fsyntax_table_p): New forward static decl.
13249 (skip_chars): Remove duplicate decl.
13250 * textprop.c (Fprevious_property_change): New forward static decl.
13251 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13252 Now internal.
13253 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13254 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13255
785bbd42
PE
13256 * editfns.c (Fformat): Remove unreachable code.
13257
8b913b57
AS
132582011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13259
13260 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13261 change. (Bug#8496)
13262
a6744a35
EZ
132632011-04-13 Eli Zaretskii <eliz@gnu.org>
13264
13265 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13266 when at ZV. (Bug#8487)
13267
e7974947
AS
132682011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13269
baad03f0
AS
13270 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13271 (Bug#8437)
13272 * keyboard.c (parse_tool_bar_item): Likewise.
13273 * sound.c (sound_cleanup, alsa_close): Likewise.
13274 * termcap.c (tgetent): Likewise.
13275 * xfns.c (x_default_font_parameter): Likewise.
13276 * xsettings.c (read_and_apply_settings): Likewise.
13277
e7974947
AS
13278 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13279 (overrun_check_free): Protoize.
13280
28272684
PE
132812011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13282
13283 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13284 since callers should never pass a negative size.
13285 Change the signature to match that of plain 'read' and 'write'; see
13286 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13287 * lisp.h: Update prototypes of emacs_write and emacs_read.
13288
11997c76
EZ
132892011-04-11 Eli Zaretskii <eliz@gnu.org>
13290
13291 * xdisp.c (redisplay_window): Don't try to determine the character
13292 position of the scroll margin if the window start point w->startp
e896f03c 13293 is outside the buffer's accessible region. (Bug#8468)
11997c76 13294
8a2cbd72
EZ
132952011-04-10 Eli Zaretskii <eliz@gnu.org>
13296
13297 Fix write-region and its subroutines for buffers > 2GB.
13298 * fileio.c (a_write, e_write): Modify declaration of arguments and
13299 local variables to support buffers larger than 2GB.
13300 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13301
13302 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13303 argument, local variables, and return value.
13304
13305 * lisp.h: Update prototypes of emacs_write and emacs_read.
13306
13307 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13308
4073e537 133092011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13310
1ebfdcb6
PE
13311 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13312
b2ded58d
PE
13313 Fix more problems found by GCC 4.6.0's static checks.
13314
7d66342c
PE
13315 * xdisp.c (vmessage): Use a better test for character truncation.
13316
bbf47d44
PE
13317 * charset.c (load_charset_map): <, not <=, for optimization,
13318 and to avoid potential problems with integer overflow.
9248994d 13319 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13320 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13321 * editfns.c (Fformat): Likewise.
1e69125e 13322 * syntax.c (skip_chars): Likewise.
3befa583 13323
e3019616
PE
13324 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13325 This also lets GCC 4.6.0 generate slightly better loop code.
13326
becfa255
PE
13327 * callint.c (Fcall_interactively): <, not <=, for optimization.
13328 (Fcall_interactively): Count the number of arguments produced,
13329 not the number of arguments given. This is simpler and lets GCC
13330 4.6.0 generate slightly better code.
13331
dae0cd48
PE
13332 * ftfont.c: Distingish more carefully between FcChar8 and char.
13333 The previous code passed unsigned char * to a functions like
13334 strlen and xstrcasecmp that expect char *, which does not
13335 conform to the C standard.
13336 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13337 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13338 char * when the C standard requires it.
13339
76032d70
PE
13340 * keyboard.c (read_char): Remove unused var.
13341
eb3f1cc8
PE
13342 * eval.c: Port to Windows vsnprintf (Bug#8435).
13343 Include <limits.h>.
13344 (SIZE_MAX): Define if the headers do not.
13345 (verror): Do not give up if vsnprintf returns a negative count.
13346 Instead, grow the buffer. This ports to Windows vsnprintf, which
13347 does not conform to C99. Problem reported by Eli Zaretskii.
13348 Also, simplify the allocation scheme, by avoiding the need for
13349 calling realloc, and removing the ALLOCATED variable.
13350
70476b54
PE
13351 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13352
12020a9e
PE
13353 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13354 But keep the doprint source code for now, as we might revamp it
13355 and use it again (Bug#8435).
ea6c7ae6
PE
13356 * lisp.h (doprnt): Remove.
13357 * Makefile.in (base_obj): Remove doprnt.o.
13358 * deps.mk (doprnt.o): Remove.
13359
5fdb398c
PE
13360 error: Print 32- and 64-bit integers portably (Bug#8435).
13361 Without this change, on typical 64-bit hosts error ("...%d...", N)
13362 was used to print both 32- and 64-bit integers N, which relied on
13363 undefined behavior.
61bdb816 13364 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13365 * lisp.h (error, verror): Mark as printf-like functions.
13366 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13367 Report overflow in size calculations when allocating printf buffer.
13368 Do not truncate output string at its first null byte.
13369 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13370 Truncate the output at a character boundary, since vsnprintf does not
13371 do that.
13372 * charset.c (check_iso_charset_parameter): Convert internal
13373 character to string before calling 'error', since %c now has the
13374 printf meaning.
13375 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13376 overflow when computing char to be passed to 'error'. Do not
13377 pass Lisp_Object to 'error'; pass the integer instead.
13378 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13379 formatted with plain %d.
13380
b189fa66
PE
13381 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13382
bff87ef0
PE
13383 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13384
7e2cac20
PE
13385 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13386
ce4d90b5
PE
13387 * xterm.c (x_catch_errors): Remove duplicate declaration.
13388
266c9547
PE
13389 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13390
79c49ad2
PE
13391 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13392
368f4090
JM
133932011-04-10 Jim Meyering <meyering@redhat.com>
13394
13395 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13396 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13397 return ssize_t not "int", and use size_t as the buffer length.
13398 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13399 * gnutls.h: Update declarations.
13400 * process.c (read_process_output): Use ssize_t, to match.
13401 (send_process): Likewise.
13402
a32d4040
CY
134032011-04-09 Chong Yidong <cyd@stupidchicken.com>
13404
13405 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13406
8546720e 134072011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13408
04f2d78b
CB
13409 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13410 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13411
8546720e
GM
13412 * xterm.c (handle_one_xevent):
13413 * xmenu.c (create_and_show_popup_menu):
13414 * xselect.c (x_decline_selection_request)
13415 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13416
0a2f5c1a 134172011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13418
13419 Fix some uses of `int' instead of EMACS_INT.
13420 * search.c (string_match_1, fast_string_match)
13421 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13422 (scan_buffer, find_next_newline_no_quit)
13423 (find_before_next_newline, search_command, Freplace_match)
13424 (Fmatch_data): Make some `int' variables be EMACS_INT.
13425
13426 * xdisp.c (display_count_lines): 3rd argument and return value now
13427 EMACS_INT. All callers changed.
13428 (pint2hrstr): Last argument is now EMACS_INT.
13429
13430 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13431 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13432 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13433 (decode_coding_utf_16, decode_coding_emacs_mule)
13434 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13435 (decode_coding_ccl, decode_coding_charset)
13436 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13437 (decode_coding_iso_2022, decode_coding_emacs_mule)
13438 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13439 <char_offset, last_offset>: Declare EMACS_INT.
13440 (encode_coding_utf_8, encode_coding_utf_16)
13441 (encode_coding_emacs_mule, encode_invocation_designation)
13442 (encode_designation_at_bol, encode_coding_iso_2022)
13443 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13444 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13445 Declare EMACS_INT.
13446 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13447 (encode_invocation_designation): Last argument P_NCHARS is now
13448 EMACS_INT.
13449 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13450 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13451
13452 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13453 All users changed.
13454
13455 * ccl.c (Fccl_execute_on_string): Declare some variables
13456 EMACS_INT.
13457
8546720e 134582011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13459
13460 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13461
4e19a977
CS
134622011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13463
13464 * process.c (Fformat_network_address): Doc fix.
13465
87302331
R
134662011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13467
ee7683eb 13468 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13469
cbb59342
CY
134702011-04-08 Chong Yidong <cyd@stupidchicken.com>
13471
13472 * keyboard.c (read_char): Call Lisp function help-form-show,
13473 instead of using internal_with_output_to_temp_buffer.
13474 (Qhelp_form_show): New var.
e0d38eeb 13475 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13476
13477 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13478
13479 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13480
e67a13ab
CY
134812011-04-06 Chong Yidong <cyd@stupidchicken.com>
13482
04f2d78b
CB
13483 * process.c (Flist_processes): Remove to Lisp.
13484 (list_processes_1): Delete.
e67a13ab 13485
973f782d
EZ
134862011-04-06 Eli Zaretskii <eliz@gnu.org>
13487
7c106b1e
EZ
13488 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13489
973f782d
EZ
13490 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13491
41cf7d1a 134922011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13493
ca23cc88
PE
13494 Fix more problems found by GCC 4.6.0's static checks.
13495
f390e2d5
PE
13496 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13497
42eea0d0
PE
13498 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13499
b69769da 13500 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13501
f9541e84
PE
13502 * xdisp.c (vmessage): Mark as a printf-like function.
13503
13841b55
PE
13504 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13505
c136c10f
PE
13506 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13507
5e2d4a30
PE
13508 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13509 printf-like functions.
13510 (tiff_load): Add casts to remove these marks before passing them
13511 to system-supplied API.
13512
583f48b9
PE
13513 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13514
b25d760e
PE
13515 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13516 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13517 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13518 directly, rather than having caller test rule sign. This avoids
13519 some unnecessary tests.
13520 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13521 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13522 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13523
bc7b6697 13524 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13525 (xfont_open): Avoid unnecessary tests.
bc7b6697 13526
27ccc379
PE
13527 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13528
dcd5c89a
PE
13529 * composite.h, composite.c (composition_gstring_put_cache):
13530 Use EMACS_INT, not int, for length.
13531
b13a45c6
PE
13532 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13533 breaking out part of COMPOSITION_DECODE_RULE.
13534 (COMPOSITION_DECODE_RULE): Use it.
13535 * composite.c (get_composition_id): Remove unused local vars,
13536 by using the new macro.
13537
1e792e4d
PE
13538 * textprop.c (set_text_properties_1): Change while to do-while,
13539 since the condition is always true at first.
13540
dc6c6455 13541 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13542 (interval_deletion_adjustment): Return unsigned value.
13543 All uses changed.
dc6c6455 13544
aba7731a
PE
13545 * process.c (list_processes_1, create_pty, read_process_output):
13546 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13547 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13548 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13549 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13550 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13551
fdfc4bf3
PE
13552 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13553
fca8fe46 13554 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13555 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13556
06a0259a 13557 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13558 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13559 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13560
e7b9e80f
PE
13561 * print.c (print_error_message): Avoid int overflow.
13562
56201685
PE
13563 * font.c (font_list_entities): Redo for clarity,
13564 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13565
78834453 13566 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13567 (font_score): Avoid potential overflow in diff calculation.
78834453 13568
0bc0b309 13569 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13570 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13571
e610eaca
PE
13572 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13573
b895abce
PE
13574 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13575 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13576 can always succeed if overflow has undefined behavior.
13577
1f1d9321 13578 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13579 (wordify): Omit three unnecessary tests.
1f1d9321 13580
c59478bc
PE
13581 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13582 All callers changed. This avoids the need for an unused var.
13583
79b73827
PE
13584 * casefiddle.c (casify_region): Remove var that is set but not used.
13585
a4db5dfe
PE
13586 * dired.c (file_name_completion): Remove var that is set but not used.
13587
43aae36e
PE
13588 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13589
2a47c44d 13590 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13591 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13592
a37c69bf
PE
13593 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13594 Check for integer overflow on size calculations.
13595
328ab8e7
PE
13596 * buffer.c (Fprevious_overlay_change): Remove var that is set
13597 but not used.
13598
e5a2a5cb
PE
13599 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13600 Remove vars that are set but not used.
8d84a6eb 13601 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13602 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13603
a60e5f68
PE
13604 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13605
f661cb61 13606 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13607 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13608
f0397f5a
PE
13609 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13610 that are set but not used.
13611
8664db06 13612 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13613 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13614
6abdaa4a
PE
13615 * xselect.c (x_get_local_selection, x_handle_property_notify):
13616 Remove vars that are set but not used.
13617
0ce7538d 13618 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13619 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13620
9ae848fc
PE
13621 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13622 Remove var that is set but not used.
0b918413
PE
13623 (scroll_bar_windows_size): Now size_t, not int.
13624 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13625 Check for overflow.
9ae848fc 13626
a5a62657
PE
13627 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13628 (map_tty_color) [!defined MSDOS]: Likewise.
13629
5c5cdd39
PE
13630 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13631
66ebf983
PE
13632 * coding.c: Remove vars that are set but not used.
13633 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13634 All callers changed.
13635 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13636 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13637 (decode_coding_charset): Remove vars that are set but not used.
13638
1be4d761
PE
13639 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13640 that is set but not used.
13641
47553fa8
PE
13642 * print.c (print_object): Remove var that is set but not used.
13643
1f7196bf 13644 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13645 The gnulib version avoids calling malloc in the usual case,
13646 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13647 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13648 * filelock.c (current_lock_owner): Likewise.
13649 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13650 * sysdep.c: Include allocator.h, careadlinkat.h.
13651 (emacs_no_realloc_allocator): New static constant.
13652 (emacs_readlink): New function.
fdb61804
PE
13653 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13654 ../lib/careadlinkat.h.
d1fdcab7 13655
f84c17c7
SM
136562011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13657
13658 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13659 first non-nil return value).
13660
ef3862ad
JD
136612011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13662
13663 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13664 if not defined (Bug#8403).
13665
376a7006
JB
136662011-04-02 Juanma Barranquero <lekktu@gmail.com>
13667
13668 * xdisp.c (display_count_lines): Remove parameter `start',
13669 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13670 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13671 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13672 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13673 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13674 and thereabouts. All callers changed.
13675 (get_per_char_metric): Remove parameter `f', unused since
13676 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13677
6ca3801d
JM
136782011-04-02 Jim Meyering <meyering@redhat.com>
13679
13680 do not dereference NULL upon failed strdup
13681 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13682 (ns_get_family): Likewise.
13683
d8e2b5ba
JB
136842011-04-02 Juanma Barranquero <lekktu@gmail.com>
13685
13686 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13687
8c74fcbd
JD
136882011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13689
13690 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13691 later (Bug#8403).
13692
7200d79c
SM
136932011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13694
03408648 13695 Add lexical binding.
7200d79c 13696
03408648
SM
13697 * window.c (Ftemp_output_buffer_show): New fun.
13698 (Fsave_window_excursion):
13699 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13700
13701 * lread.c (lisp_file_lexically_bound_p): New function.
13702 (Fload): Bind Qlexical_binding.
13703 (readevalloop): Remove `evalfun' arg.
13704 Bind Qinternal_interpreter_environment.
13705 (Feval_buffer): Bind Qlexical_binding.
13706 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13707 Mark as dynamic.
13708 (syms_of_lread): Declare `lexical-binding'.
13709
13710 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13711
13712 * keyboard.c (eval_dyn): New fun.
13713 (menu_item_eval_property): Use it.
ca105506
SM
13714
13715 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13716
03408648
SM
13717 * fns.c (concat, mapcar1): Accept byte-code-functions.
13718
13719 * eval.c (Fsetq): Handle lexical vars.
13720 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13721 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13722 (FletX, Flet): Obey lexical binding.
13723 (Fcommandp): Handle closures.
13724 (Feval): New `lexical' arg.
13725 (eval_sub): New function extracted from Feval. Use it almost
13726 everywhere where Feval was used. Look up vars in lexical env.
13727 Handle closures.
13728 (Ffunctionp): Move from subr.el.
13729 (Ffuncall): Handle closures.
13730 (apply_lambda): Remove `eval_flags'.
13731 (funcall_lambda): Handle closures and new byte-code-functions.
13732 (Fspecial_variable_p): New function.
13733 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13734 but without exporting it to Lisp.
23aba0ea 13735
23aba0ea 13736 * doc.c (Fdocumentation, store_function_docstring):
03408648 13737 * data.c (Finteractive_form): Handle closures.
23aba0ea 13738
03408648
SM
13739 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13740 interactive spec.
ba83908c 13741
04f2d78b
CB
13742 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13743 New byte-codes.
03408648
SM
13744 (exec_byte_code): New function extracted from Fbyte_code to handle new
13745 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13746
03408648 13747 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13748
03408648 13749 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13750
e2abce01
JB
137512011-03-31 Juanma Barranquero <lekktu@gmail.com>
13752
13753 * xdisp.c (redisplay_internal): Fix prototype.
13754
63696a73 137552011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13756
63696a73 13757 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13758 (try_scrolling): Use it when setting scroll_limit.
13759 Limit scrolling to 100 screen lines.
63696a73
EZ
13760 (redisplay_window): Even when falling back on "recentering",
13761 position point in the window according to scroll-conservatively,
13762 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13763
13764 (try_scrolling): When point is above the window, allow searching
13765 as far as scroll_max, or one screenful, to compute vertical
13766 distance from PT to the scroll margin position. This prevents
13767 try_scrolling from unnecessarily failing when
13768 scroll-conservatively is set to a value slightly larger than the
13769 window height. Clean up the case of PT below the margin at bottom
13770 of window: scroll_max can no longer be INT_MAX. When aggressive
13771 scrolling is in use, don't let point enter the opposite scroll
13772 margin as result of the scroll.
13773 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13774 threshold of 100 lines for never-recentering scrolling.
13775
e4cc2dfc
JB
137762011-03-31 Juanma Barranquero <lekktu@gmail.com>
13777
13778 * dispextern.h (move_it_by_lines):
13779 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13780 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13781 (message_log_check_duplicate): Remove parameters `prev_bol' and
13782 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13783 (redisplay_internal): Remove parameter `preserve_echo_area',
13784 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13785
13786 * indent.c (Fvertical_motion):
13787 * window.c (window_scroll_pixel_based, Frecenter):
13788 Don't pass `need_y_p' to `move_it_by_lines'.
13789
1c470562
SM
137902011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13791
44f230aa
SM
13792 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13793 steal a few bits to be more compact.
13794 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13795 Remove unneeded casts.
13796
1c470562
SM
13797 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13798
888adce9
ZK
137992011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13800
13801 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13802 binding" message (bug#7967).
13803
f838ed7b
PE
138042011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13805
77861b95
PE
13806 Fix more problems found by GCC 4.6.0's static checks.
13807
de6dbc14
PE
13808 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13809 Remove unused local var.
13810
f838ed7b
PE
13811 * editfns.c (Fmessage_box): Remove unused local var.
13812
792c7b2b
PE
13813 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13814 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13815 Omit unused local vars.
c499e557 13816 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13817 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13818 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13819 Omit unused local var.
13820
ba0165e1
PE
13821 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13822 Don't assume string length fits in int.
32ad8845 13823 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13824 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13825
3c59b4c9
PE
13826 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13827 instead of alloca (Bug#8344).
13828
a3eed478 13829 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13830 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13831
eb4d412d
PE
13832 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13833
1658b401
PE
13834 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13835 concerns.
13836
13837 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13838
13839 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13840
9a2c6e05
PE
13841 * keyboard.c (syms_of_keyboard): Use the same style as later
13842 in this function when indexing through an array. This also
13843 works around GCC bug 48267.
13844
03d0a109
PE
13845 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13846
44f730c8
PE
13847 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13848
fe75f926
PE
13849 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13850 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13851
ffa8c828
PE
13852 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13853 This avoids undefined behavior on integer overflow, and is a bit
13854 more convenient anyway since it is compared to a size_t variable.
13855
c5101a77
PE
13856 Variadic C functions now count arguments with size_t, not int.
13857 This avoids an unnecessary limitation on 64-bit machines, which
13858 caused (substring ...) to crash on large vectors (Bug#8344).
13859 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13860 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13861 All variadic functions and their callers changed accordingly.
c5101a77
PE
13862 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13863 * data.c (arith_driver, float_arith_driver): Likewise.
13864 * editfns.c (general_insert_function): Likewise.
13865 * eval.c (struct backtrace.nargs, interactive_p)
13866 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13867 (funcall_lambda, mark_backtrace): Likewise.
13868 * fns.c (concat): Likewise.
13869 * frame.c (x_set_frame_parameters): Likewise.
13870 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13871 0 if not found, not -1. All callers changed.
13872
dd3f25f7
PE
13873 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13874 (stack_copy_size): Now size_t, not int.
13875 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13876
461c2ab9
JB
138772011-03-28 Juanma Barranquero <lekktu@gmail.com>
13878
13879 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13880 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13881 All callers changed.
13882
13883 * lisp.h (multibyte_char_to_unibyte):
13884 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13885 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13886 * character.h (CHAR_TO_BYTE8):
13887 * cmds.c (internal_self_insert):
13888 * editfns.c (general_insert_function):
13889 * keymap.c (push_key_description):
13890 * search.c (Freplace_match):
13891 * xdisp.c (message_dolog, set_message_1): All callers changed.
13892
f6d62986
SM
138932011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13894
13895 * keyboard.c (safe_run_hook_funcall): New function.
13896 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13897 don't set the hook to nil, but remove the offending function instead.
13898 (Qcommand_hook_internal): Remove, unused.
13899 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13900 Vcommand_hook_internal.
13901
13902 * eval.c (enum run_hooks_condition): Remove.
13903 (funcall_nil, funcall_not): New functions.
13904 (run_hook_with_args): Call each function through a `funcall' argument.
13905 Remove `cond' argument, now redundant.
13906 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13907 (Frun_hook_with_args_until_failure): Adjust accordingly.
13908 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13909
1db5b1ad
JB
139102011-03-28 Juanma Barranquero <lekktu@gmail.com>
13911
13912 * dispextern.h (string_buffer_position): Remove declaration.
13913
13914 * print.c (strout): Remove parameter `multibyte', unused since
13915 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13916
13917 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13918 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13919 All callers changed.
13920
13921 * w32.c (_wsa_errlist): Use braces for struct initializers.
13922
13923 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13924 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13925 All callers changed.
13926 (string_buffer_position): Likewise. Also, make static (it's never
13927 used outside xdisp.c).
13928 (cursor_row_p): Remove parameter `w', unused since
13929 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13930 (decode_mode_spec): Remove parameter `precision', introduced during
13931 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13932 All callers changed.
13933
5ffb62aa
JD
139342011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13935
13936 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13937
461c2ab9 139382011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13939
13940 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13941 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13942 (ns_update_auto_hide_menu_bar): New functions.
13943 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13944 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13945 ns_constrain_all_frames.
13946 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13947 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13948
5c380ffb
JD
139492011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13950
13951 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13952
9af30bdf
GM
139532011-03-27 Glenn Morris <rgm@gnu.org>
13954
13955 * syssignal.h: Replace RETSIGTYPE with void.
13956 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13957 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13958 Replace SIGTYPE with void everywhere.
13959 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13960 * s/template.h (SIGTYPE): Remove commented out definition.
13961
e2abce01
JB
139622011-03-26 Eli Zaretskii <eliz@gnu.org>
13963
13964 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13965 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13966
f868cd8a
JB
139672011-03-26 Juanma Barranquero <lekktu@gmail.com>
13968
59eb0929
JB
13969 * w32.c (read_unc_volume): Use parameter `henum', instead of
13970 global variable `wget_enum_handle'.
13971
13972 * keymap.c (describe_vector): Remove parameters `indices' and
13973 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13974 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13975
f868cd8a
JB
13976 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13977
13978 * keyboard.c (timer_check): Remove parameter `do_it_now',
13979 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13980 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13981 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13982
13983 * keyboard.c (read_char):
13984 * w32menu.c (w32_menu_display_help):
13985 * xmenu.c (show_help_event, menu_help_callback):
13986 Adjust calls to `show_help_echo'.
13987
13988 * gtkutil.c (xg_maybe_add_timer):
13989 * keyboard.c (readable_events):
13990 * process.c (wait_reading_process_output):
13991 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13992
13993 * insdel.c (adjust_markers_gap_motion):
13994 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13995 (gap_left, gap_right): Don't call it.
13996
2ecf6fdb
CY
139972011-03-25 Chong Yidong <cyd@stupidchicken.com>
13998
13999 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14000 incurred during fontification.
14001
6b1f9ba4
JB
140022011-03-25 Juanma Barranquero <lekktu@gmail.com>
14003
14004 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14005 (DEFVAR_PER_BUFFER): Don't pass it.
14006
14007 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14008 (scrolling_window): Don't pass it.
14009
0f4a96b5
JB
140102011-03-25 Juanma Barranquero <lekktu@gmail.com>
14011
14012 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14013
14014 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14015 and `suffix'.
14016 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14017 of variables specific to SELinux and computation of `encoded_absname'.
14018
14019 * image.c (XPutPixel): Remove unused variable `height'.
14020
14021 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14022
14023 * unexw32.c (get_section_info): Remove unused variable `section'.
14024
14025 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14026 (system_process_attributes): Remove unused variable `sess'.
14027 (sys_read): Remove unused variable `err'.
14028
14029 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14030 (w32_wnd_proc): Remove unused variable `isdead'.
14031 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14032 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14033 (x_create_tip_frame): Remove unused variable `tem'.
14034
14035 * w32inevt.c (w32_console_read_socket):
14036 Remove unused variable `no_events'.
14037
14038 * w32term.c (x_draw_composite_glyph_string_foreground):
14039 Remove unused variable `width'.
14040
1149507c
JB
140412011-03-24 Juanma Barranquero <lekktu@gmail.com>
14042
14043 * w32term.c (x_set_glyph_string_clipping):
14044 Don't pass uninitialized region to CombineRgn.
14045
9c88f339
JB
140462011-03-23 Juanma Barranquero <lekktu@gmail.com>
14047
14048 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14049 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14050 (Fx_close_connection): Remove unused variable `i'.
14051
14052 * w32font.c (w32font_draw): Return number of glyphs.
14053 (w32font_open_internal): Remove unused variable `i'.
14054 (w32font_driver): Add missing initializer.
14055
14056 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14057 (fill_in_menu): Remove unused variable `items_added'.
14058
14059 * w32term.c (last_mouse_press_frame): Remove static global variable.
14060 (w32_clip_to_row): Remove unused variable `f'.
14061 (x_delete_terminal): Remove unused variable `i'.
14062
14063 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14064 (NOTHING): Remove unused static global variable.
14065 (uniscribe_check_otf): Remove unused variable `table'.
14066 (uniscribe_font_driver): Add missing initializers.
14067
dee091a3
JD
140682011-03-23 Julien Danjou <julien@danjou.info>
14069
14070 * term.c (Fsuspend_tty, Fresume_tty):
14071 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14072 * window.c (temp_output_buffer_show):
14073 * insdel.c (signal_before_change):
14074 * frame.c (Fhandle_switch_frame):
14075 * fileio.c (Fdo_auto_save):
14076 * emacs.c (Fkill_emacs):
14077 * editfns.c (save_excursion_restore):
14078 * cmds.c (internal_self_insert):
14079 * callint.c (Fcall_interactively):
14080 * buffer.c (Fkill_all_local_variables):
14081 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14082 Use Frun_hooks.
0f4a96b5 14083 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14084 unconditionally since it does the check itself.
dee091a3 14085
2c520ab5 140862011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14087
c9c49752
PE
14088 Fix more problems found by GCC 4.5.2's static checks.
14089
8abc3f12
PE
14090 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14091 the first time through the loop, since we know p0 < p1 then.
14092 This also avoids a gcc -Wstrict-overflow warning.
14093
a2d26660
PE
14094 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14095 leading to a memory leak, possible in functions like
14096 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14097 of objects (Bug#8318).
a2d26660 14098
916c72e9
PE
14099 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14100 that could (at least in theory) be that large.
14101
19ab8a18
PE
14102 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14103 This is less likely to overflow, and avoids undefined behavior if
14104 overflow does occur. All callers changed. Use strtoul to scan
14105 for the unsigned long integer.
b7cbbd6f
PE
14106 (pint2hrstr): Simplify and tune code slightly.
14107 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14108
f0641eff
PE
14109 * scroll.c (do_scrolling): Work around GCC bug 48228.
14110 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14111
7f650bb9
PE
14112 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14113 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14114 (validate_x_resource_name): Simplify count usage.
14115 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14116
37dd57d1
PE
14117 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14118 fail (Bug#8306).
81e56e61 14119
699979fc 14120 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14121
401bf9b4
PE
14122 * process.c (Fmake_network_process): Use socklen_t, not int,
14123 where POSIX says socklen_t is required in portable programs.
14124 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14125 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14126 (Fmake_network_process, server_accept_connection):
14127 (wait_reading_process_output, read_process_output):
14128 Likewise.
14129
b93aacde
PE
14130 * process.c: Rename or move locals to avoid shadowing.
14131 (list_processes_1, Fmake_network_process):
14132 (read_process_output_error_handler, exec_sentinel_error_handler):
14133 Rename or move locals.
4dc343ee 14134 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14135 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14136 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14137 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14138 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14139
af8a867c 14140 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14141 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14142 Include tparam.h instead, since it declares them.
af8a867c
PE
14143 * cm.h (PC): Remove extern decl; tparam.h now does this.
14144 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14145 * terminfo.c: Include tparam.h, to check interfaces.
14146 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14147 (tparam): Adjust signature to match interface in tparam.h;
14148 this removes some undefined behavior. Check that outstring and len
14149 are zero, which they always are with Emacs.
14150 * tparam.h (PC, BC, UP): New extern decls.
14151
0248044d 14152 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14153 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14154
8ff096c1 14155 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14156 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14157 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14158 (ftfont_list): Remove unused local.
49eaafba
PE
14159 (get_adstyle_property, ftfont_pattern_entity):
14160 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14161 Rename locals to avoid shadowing.
8ff096c1 14162
e2be39f6
PE
14163 * xfont.c (xfont_list_family): Mark var as initialized.
14164
c9735e30
PE
14165 * xml.c (make_dom): Now static.
14166
8f5201ae
PE
14167 * composite.c (composition_compute_stop_pos): Rename local to
14168 avoid shadowing.
b246f932
PE
14169 (composition_reseat_it): Remove unused locals.
14170 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14171 (composition_update_it): Mark var as initialized.
11b61122
PE
14172 (find_automatic_composition): Mark vars as initialized,
14173 with a FIXME (Bug#8290).
8f5201ae 14174
760fbc2c
PE
14175 character.h: Rename locals to avoid shadowing.
14176 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14177 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14178 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14179 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14180 to avoid shadowing.
14181
ff08eb85
PE
14182 * textprop.c (property_change_between_p): Remove; unused.
14183
fc7bf025
PE
14184 * intervals.c (interval_start_pos): Now static.
14185
235d7abc
PE
14186 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14187
44f230aa
SM
14188 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14189 Rename locals to avoid shadowing.
3e7d6594 14190
50060332
PE
14191 * sound.c (wav_play, au_play, Fplay_sound_internal):
14192 Fix pointer signedness.
d01f234b 14193 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14194 (wav_play): Initialize a variable to 0, to prevent undefined
14195 behavior (Bug#8278).
50060332 14196
c4fc4e30
PE
14197 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14198
918436ed
PE
14199 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14200
c939f91b
PE
14201 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14202 clobbering (Bug#8298).
b9c7f648
PE
14203 * sysdep.c (sys_subshell): Likewise.
14204 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14205
6bd8c144
PE
14206 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14207 This should get cleaned up, so that child_setup has the
14208 same signature on all platforms.
14209
7710357c 14210 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14211 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14212
c59da222
CY
142132011-03-22 Chong Yidong <cyd@stupidchicken.com>
14214
14215 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14216 not to be necessary, and produces flickering.
14217
66b87493
GM
142182011-03-20 Glenn Morris <rgm@gnu.org>
14219
14220 * config.in: Remove file.
14221
45b6f6d5
JB
142222011-03-20 Juanma Barranquero <lekktu@gmail.com>
14223
14224 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14225 are now in src/globals.h.
14226 (syms_of_minibuf): Remove spurious & from previous change.
14227
cd394be1 142282011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14229
14230 * minibuf.c (completing-read-function): New variable.
14231 (completing-read-default): Rename from completing-read.
14232 (completing-read): Call completing-read-function.
14233
b14e3e21
CY
142342011-03-19 Juanma Barranquero <lekktu@gmail.com>
14235
14236 * xfaces.c (Fx_load_color_file):
14237 Read color file from absolute filename (bug#8250).
14238
f2b726e6
JB
142392011-03-19 Juanma Barranquero <lekktu@gmail.com>
14240
14241 * makefile.w32-in: Update dependencies.
14242
09f6ff02
EZ
142432011-03-17 Eli Zaretskii <eliz@gnu.org>
14244
14245 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14246
29a6015a
PE
142472011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14248
a3a6c54e
PE
14249 Fix more problems found by GCC 4.5.2's static checks.
14250
b766f867
PE
14251 * process.c (make_serial_process_unwind, send_process_trap):
14252 (sigchld_handler): Now static.
14253
be02381c
PE
14254 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14255 That way, the code declares only the vars that it needs.
14256 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14257 * s/cygwin.h (PTY_ITERATION): Likewise.
14258 * s/darwin.h (PTY_ITERATION): Likewise.
14259 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14260
57048744
PE
14261 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14262 * process.c (allocate_pty): Don't declare stb unless it's needed.
14263
7914961c 14264 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14265 (CONSTANTLIM): Remove; unused.
14266 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14267 Define only if needed.
7914961c 14268
b3967b18
PE
14269 * unexelf.c (unexec): Name an expression,
14270 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14271 Use a different way to cause a compilation error if anyone uses
14272 n rather than nn, a way that does not involve shadowing.
73366a00 14273 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14274
29a6015a
PE
14275 * deps.mk (unexalpha.o): Remove; unused.
14276
43cfc33e 14277 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14278 * unexec.h: New file.
ce701a33
PE
14279 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14280 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14281 Depend on unexec.h.
14282 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14283 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14284 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14285 Change as necessary to match prototype in unexec.h.
ce701a33 14286
01f44d5a
PE
14287 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14288 shadowing.
4f63c6bb 14289 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14290
a6670b0b
PE
14291 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14292 Rename locals to avoid shadowing.
14293
cef2010d 14294 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14295 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14296
d4d7173a
PE
14297 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14298
f08b802a
PE
14299 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14300 warning when compiling print.c.
14301
3ddb0639
PE
14302 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14303 instead of using an uninitialized var.
5ad03b97 14304 (font_sort_entities): Mark var as initialized.
3ddb0639 14305
170a2692
PE
14306 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14307
e663c700
PE
14308 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14309 pointers to constants.
89bc529a 14310 (font_parse_fcname): Remove unused vars.
7b81e2d0 14311 (font_delete_unmatched): Now static.
ea838e10 14312 (font_get_spec): Remove; unused.
13a547c6
PE
14313 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14314 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14315 Rename or move locals to avoid shadowing.
e663c700 14316
2a80c887 14317 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14318 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14319
1384fa33 14320 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14321 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14322
8b2c52e9
PE
14323 * alloc.c (mark_backtrace): Move decl from here ...
14324 * lisp.h: ... to here, so that it can be checked.
14325
475545b5 14326 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14327 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14328 (lisp_indirect_variable): Name an expression,
14329 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14330 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14331
b1349114 14332 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14333 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14334 Use const pointer when appropriate.
b1349114 14335
a2928364
PE
14336 * lisp.h (get_system_name, get_operating_system_release):
14337 Move decls here, to check interfaces.
14338 * process.c (get_operating_system_release): Move decl to lisp.h.
14339 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14340 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14341 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14342 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14343 (Fformat_time_string, Fencode_time, Finsert_char):
14344 (Ftranslate_region_internal, Fformat):
14345 Rename or remove local vars to avoid shadowing.
9710023e 14346 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14347
a415e694
PE
14348 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14349 avoid shadowing.
14350
8ef4622d
PE
14351 * lisp.h (eassert): Check that the argument compiles, even if
14352 ENABLE_CHECKING is not defined.
14353
946f9a5b
PE
14354 * data.c (Findirect_variable): Name an expression, to avoid
14355 gcc -Wbad-function-cast warning.
112396d6 14356 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14357 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14358 (Fmake_variable_buffer_local, Fmake_local_variable):
14359 Mark variables as initialized.
52746918 14360 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14361
e5aab7e7 14362 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14363 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14364 Rename locals to avoid shadowing.
dff45157
PE
14365 (mark_stack): Move local variables into the #ifdef region where
14366 they're used.
7bc26fdb
PE
14367 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14368 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14369 needed otherwise.
14370 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14371 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14372 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14373
e5aab7e7
PE
14374 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14375 avoids undefined behavior in theory.
14376
4da60324
PE
14377 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14378
88043301
PE
14379 Use functions, not macros, for up- and down-casing (Bug#8254).
14380 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14381 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14382 to use the following functions instead of these macros.
14383 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14384 EMACS_INT, since callers assume the returned value fits in int.
14385 (upcase1): Likewise, for UPCASE_TABLE.
14386 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14387 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14388 the race-condition problem in the old DOWNCASE.
88043301 14389
19ed5445
PE
14390 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14391 Rename locals to avoid shadowing.
14392 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14393 (regex_compile, re_search_2, re_match_2_internal):
14394 Remove unused local vars.
952db0d7
PE
14395 (FREE_VAR): Rewrite so as not to use empty "else",
14396 which gcc can warn about.
da053e48 14397 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14398 (RETALLOC_IF): Define only if needed.
14399 (WORDCHAR_P): Likewise. This one is never needed, but is used
14400 only in a comment talking about a compiler bug, so put inside
14401 the #if 0 of that comment.
14402 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14403 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14404 Remove; unused.
19ed5445 14405
1f3561e4 14406 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14407 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14408 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14409
ded6f8f7
PE
14410 * search.c (simple_search): Remove unused var.
14411
dbd37a95
PE
14412 * dired.c (compile_pattern): Move decl from here ...
14413 * lisp.h: ... to here, so that it can be checked.
14414 (struct re_registers): New forward decl.
14415
7e47afad
PE
14416 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14417
85f24f61
PE
14418 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14419 All uses changed.
14420 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14421 Rename locals to avoid shadowing.
5671df8f 14422 (Fvertical_motion): Mark locals as initialized.
85f24f61 14423
181aa2be 14424 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14425 (casify_region): Mark local as initialized.
181aa2be 14426
930d429c
PE
14427 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14428
7082eac6
PE
14429 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14430 New macros, so that the caller can use some names other than
14431 gcpro1, gcpro2, etc.
14432 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14433 of the new macros.
14434 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14435 argument, for consistency with GCPRO2_VAR, etc: it is now the
14436 prefix of the variable, not the variable itself. All uses
14437 changed.
38b2c076
PE
14438 * dired.c (directory_files_internal, file_name_completion):
14439 Rename locals to avoid shadowing.
14440
15206ed9
PE
14441 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14442 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14443 dired.c's scmp function, had undefined behavior.
14444 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14445 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14446 * buffer.h: ... to here, because these macros use current_buffer,
14447 and the new implementation with inline functions needs to have
14448 current_buffer in scope now, rather than later when the macros
14449 are used.
14450 (downcase, upcase1): New static inline functions.
14451 (DOWNCASE, UPCASE1): Reimplement using these functions.
14452 This avoids undefined behavior in expressions like
14453 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14454 from race conditions in accessing the global variables
14455 case_temp1 and case_temp2.
14456 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14457 * lisp.h (case_temp1, case_temp2): Remove their decls.
14458 * character.h (ASCII_CHAR_P): Move from here ...
14459 * lisp.h: ... to here, so that the inline functions mentioned
14460 above can use them.
14461
4a6bea26
PE
14462 * dired.c (directory_files_internal_unwind): Now static.
14463
f14b7e14
PE
14464 * fileio.c (file_name_as_directory, directory_file_name):
14465 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14466 Now static.
2893f146
PE
14467 (file_name_as_directory): Use const pointers when appropriate.
14468 (Fexpand_file_name): Likewise. In particular, newdir might
14469 point at constant storage, so make it a const pointer.
fd4ead52 14470 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14471 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14472 signedness issues.
f839df0c
PE
14473 (Fset_file_times, Finsert_file_contents, auto_save_error):
14474 Rename locals to avoid shadowing.
f14b7e14 14475
5716756e 14476 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14477 (Ftry_completion, Fall_completions): Rename or remove locals
14478 to avoid shadowing.
5716756e 14479
b4c3046a
PE
14480 * marker.c (bytepos_to_charpos): Remove; unused.
14481
b45db522
PE
14482 * lisp.h (verify_bytepos, count_markers): New decls,
14483 so that gcc does not warn that these functions aren't declared.
14484
85876d07
PE
14485 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14486 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14487 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14488 (copy_text): Remove unused local var.
85876d07 14489
03d78a21 14490 * filelock.c (within_one_second): Now static.
b3dd38ab 14491 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14492
5df8f01b
PE
14493 * buffer.c (fix_overlays_before): Mark locals as initialized.
14494 (fix_start_end_in_overlays): Likewise. This function should be
14495 simplified by using pointers-to-pointers, but that's a different
14496 matter.
b1d876f1 14497 (switch_to_buffer_1): Now static.
8f54f30a
PE
14498 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14499 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14500
a70072c9 14501 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14502 Fix pointer signedness issue.
edced198
PE
14503 (sys_subshell): Mark local as volatile if checking for lint,
14504 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14505 (MAXPATHLEN): Define only if needed.
a70072c9 14506
a0977c44
PE
14507 * process.c (serial_open, serial_configure): Move decls from here ...
14508 * systty.h: ... to here, so that they can be checked.
14509
a884fdcc
PE
14510 * fns.c (get_random, seed_random): Move extern decls from here ...
14511 * lisp.h: ... to here, so that they can be checked.
14512
604efe86 14513 * sysdep.c (reset_io): Now static.
b8950c94 14514 (wait_for_termination_signal): Remove; unused.
604efe86 14515
38fc62d9
PE
14516 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14517 (copy_keymap_item, append_key, push_text_char_description):
14518 Now static.
1004a21a 14519 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14520 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14521 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14522 (describe_map_tree):
14523 Rename locals to avoid shadowing.
38fc62d9 14524
2f2650da
PE
14525 * keyboard.c: Declare functions static if they are not used elsewhere.
14526 (echo_char, echo_dash, cmd_error, top_level_2):
14527 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14528 (read_char, kbd_buffer_get_event, make_lispy_position):
14529 (make_lispy_event, make_lispy_movement, apply_modifiers):
14530 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14531 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14532 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14533 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14534 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14535
a053e86c 14536 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14537 (mark_kboards): Move decl here ...
14538 * alloc.c (mark_kboards): ... from here.
a053e86c 14539
4752793e
PE
14540 * lisp.h (force_auto_save_soon): New decl.
14541
74f10ca7 14542 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14543 (DEFINE_DUMMY_FUNCTION): New macro.
14544 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14545 Use it.
c03cd23f
PE
14546 (main): Add casts to avoid warnings
14547 if GCC considers string literals to be constants.
74f10ca7 14548
022e70d4
PE
14549 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14550
59d6fe83
PE
14551 * dbusbind.c: Pointer signedness fixes.
14552 (xd_signature, xd_append_arg, xd_initialize):
14553 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14554 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14555 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14556 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14557
78320123
PE
14558 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14559 if GCC considers string literals to be constants.
49cebcca 14560 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14561
35ac2a97
SM
145622011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14563
fb103ca9
SM
14564 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14565 (print_preprocess, print_object): New macro to fix last change.
14566
35ac2a97
SM
14567 * print.c (print_preprocess): Don't forget font objects.
14568
62973b41
JB
145692011-03-16 Juanma Barranquero <lekktu@gmail.com>
14570
14571 * emacs.c (USAGE3): Doc fixes.
14572
0e48bb22
AS
145732011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14574
14575 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14576 structure.
14577
7684e57b
JB
145782011-03-14 Juanma Barranquero <lekktu@gmail.com>
14579
14580 * lisp.h (VWindow_system, Qfile_name_history):
14581 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14582 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14583 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14584
14585 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14586 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14587
14588 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14589 * w32console.c (detect_input_pending, read_input_pending)
14590 (encode_terminal_code):
14591 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14592 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14593 (w32_system_caret_y, Qfile_name_history):
14594 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14595 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14596 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14597 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14598 * w32proc.c (Qlocal, report_file_error):
14599 * w32term.c (Vwindow_system, updating_frame):
14600 * w32uniscribe.c (initialized, uniscribe_font_driver):
14601 Remove unneeded extern declarations.
14602
2aa46d6c
CY
146032011-03-14 Chong Yidong <cyd@stupidchicken.com>
14604
c96bbc66 14605 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14606
cffc6f3b
CY
146072011-03-13 Chong Yidong <cyd@stupidchicken.com>
14608
14609 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14610 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14611 These macros can no longer be used for assignment.
14612
44f230aa
SM
14613 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14614 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14615 (record_buffer_markers, fetch_buffer_markers): New functions for
14616 recording and fetching special buffer markers.
14617 (set_buffer_internal_1, set_buffer_temp): Use them.
14618
14619 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14620
14621 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14622
14623 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14624 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14625
14626 * xdisp.c (hscroll_window_tree):
14627 (reconsider_clip_changes): Use PT instead of BUF_PT.
14628
d251f04b
EZ
146292011-03-13 Eli Zaretskii <eliz@gnu.org>
14630
14631 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14632 $(EMACS_ROOT)/lib/intprops.h.
14633
f0c77cd1
PE
146342011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14635
3eca4629
PE
14636 Fix more problems found by GCC 4.5.2's static checks.
14637
7c86ee98
PE
14638 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14639 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14640 (xg_free_frame_widgets): Make it clear that a local variable is
14641 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14642 (gdk_window_get_screen): Make it clear that this macro is needed
14643 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14644 (int_gtk_range_get_value): New function, which avoids a diagnostic
14645 from gcc -Wbad-function-cast.
14646 (xg_set_toolkit_scroll_bar_thumb): Use it.
14647 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14648 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14649 (get_utf8_string, xg_get_file_with_chooser):
14650 Rename locals to avoid shadowing.
14651 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14652
41729b81
PE
14653 * xgselect.c (xg_select): Remove unused var.
14654
f0c77cd1
PE
14655 * image.c (four_corners_best): Mark locals as initialized.
14656 (gif_load): Initialize transparent_p to zero (Bug#8238).
14657 Mark another local as initialized.
ec6cf4c6 14658 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14659
ce0ad53d 14660 * image.c (clear_image_cache): Now static.
d5d5a617 14661 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14662 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14663 (x_edge_detection): Remove unnecessary cast that
14664 gcc -Wbad-function-cast diagnoses.
2037898d 14665 (gif_load): Fix pointer signedness.
6ae141d6
PE
14666 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14667 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14668
33383987 146692011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14670
d32df629
PE
14671 Improve quality of tests for time stamp overflow.
14672 For example, without this patch (encode-time 0 0 0 1 1
14673 1152921504606846976) returns the obviously-bogus value (-948597
14674 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14675 reports time overflow. See
14676 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14677 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14678 * editfns.c: Include limits.h and intprops.h.
14679 (TIME_T_MIN, TIME_T_MAX): New macros.
14680 (time_overflow): Move earlier, to before first use.
14681 (hi_time, lo_time): New functions, for an accurate test for
14682 out-of-range times.
14683 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14684 (Fget_internal_run_time): Don't assume time_t fits in int.
14685 (make_time): Use list2 instead of Fcons twice.
14686 (Fdecode_time): More accurate test for out-of-range times.
14687 (check_tm_member): New function.
14688 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14689 (lisp_time_argument): Don't rely on undefined left-shift and
14690 right-shift behavior when checking for time stamp overflow.
8be6f318 14691
fe31d94c
PE
14692 * editfns.c (time_overflow): New function, refactoring common code.
14693 (Fformat_time_string, Fdecode_time, Fencode_time):
14694 (Fcurrent_time_string): Use it.
14695
8be6f318
PE
14696 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14697 * dired.c (make_time): Move to ...
14698 * editfns.c (make_time): ... here.
14699 * systime.h: Note the move.
14700
09d9db2c 147012011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14702
126bc0dc
YM
14703 * fringe.c (update_window_fringes): Remove unused variables.
14704
c47cbdfd
YM
14705 * unexmacosx.c (copy_data_segment): Also copy __got section.
14706 (Bug#8223)
14707
7ac80be9
EZ
147082011-03-12 Eli Zaretskii <eliz@gnu.org>
14709
c96bbc66 14710 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14711 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14712 Constify `char *' arguments and their references according to
14713 prototypes in tparam.h.
14714
ecb0f94d 14715 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14716
7ac80be9
EZ
14717 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14718 Adapt all references accordingly.
14719
14720 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14721
ef1fd07e
TT
147222011-03-11 Tom Tromey <tromey@redhat.com>
14723
14724 * buffer.c (syms_of_buffer): Remove obsolete comment.
14725
7ef4b50c
EZ
147262011-03-11 Eli Zaretskii <eliz@gnu.org>
14727
14728 * termhooks.h (encode_terminal_code): Declare prototype.
14729
14730 * msdos.c (encode_terminal_code): Don't declare prototype.
14731
14732 * term.c (encode_terminal_code): Now external again, used by
14733 w32console.c and msdos.c.
14734
44f230aa
SM
14735 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14736 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14737
4b1ec863 147382011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14739
1714f52b 14740 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14741
4b1ec863
PE
14742 * fringe.c (update_window_fringes): Mark locals as initialized
14743 (Bug#8227).
14744 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14745
524c7aa6
PE
14746 * alloc.c (mark_fringe_data): Move decl from here ...
14747 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14748 to check its interface.
14749 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14750
a5c0af81 14751 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14752 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14753 (fontset_font): Mark local as initialized.
a9a06e0b 14754 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14755
b4716021
PE
14756 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14757
811e9bac 14758 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14759 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14760 (x_own_selection, Fx_disown_selection_internal): Rename locals
14761 to avoid shadowing.
14762 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14763
7e3ab302
PE
14764 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14765 so that the caller can use some name other than gcpro1.
14766 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14767 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14768 (Fx_backspace_delete_keys_p):
14769 Use them to avoid shadowing, and rename vars to avoid shadowing.
14770 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14771 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14772 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14773 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14774 Remove unused locals.
7e3ab302
PE
14775 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14776 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14777 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14778 macros.
f78faa98 14779
e2b13473
PE
14780 * xterm.h (x_mouse_leave): New decl.
14781
77f23912
PE
14782 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14783 Remove unused functions.
cdf4ba58
PE
14784 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14785 (x_calc_absolute_position): Now static.
7411c686 14786 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14787 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14788 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14789 unless they are used.
38d0b34a
PE
14790 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14791 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14792 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14793 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14794 (x_error_catcher, x_connection_closed, x_error_handler):
14795 (x_error_quitter, xembed_send_message, x_iconify_frame):
14796 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14797 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14798 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14799
44f230aa
SM
14800 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14801 Rename or move locals to avoid shadowing.
6b463e58 14802 (tty_defined_color, merge_face_heights): Now static.
5967d051 14803 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14804 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14805 does not deduce is never used uninitialized.
73719eba
PE
14806 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14807 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14808
426994c3 14809 * terminal.c (store_terminal_param): Now static.
5489860b 14810
032f1620 14811 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14812 (set_frame_menubar): Remove unused local.
d4323972 14813 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14814 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14815 since they might point to immutable storage.
281585b0
PE
14816 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14817 since it's unused otherwise.
032f1620 14818
367c19e5 14819 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14820 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14821 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14822 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14823 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14824 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14825 does not deduce are never used uninitialized.
70739cbe 14826
07b48fa9
PE
14827 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14828
8868a238 14829 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14830 * window.c (window_loop, size_window):
14831 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14832
7e5cf297 14833 * window.c (display_buffer): Now static.
d6550a9f
PE
14834 (size_window): Mark variables that gcc -Wuninitialized
14835 does not deduce are never used uninitialized.
a586633d
PE
14836 * window.h (check_all_windows): New decl, to forestall
14837 gcc -Wmissing-prototypes diagnostic.
5b555da1 14838 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14839
f6095868
PE
14840 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14841 shadowing.
14842 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14843 Include <limits.h>.
14844 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14845 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14846 (load_charset_map): Mark variables that gcc -Wuninitialized
14847 does not deduce are never used uninitialized.
53df7c11 14848 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14849
f38b440c
PE
14850 * coding.c (coding_set_source, coding_set_destination):
14851 Use "else { /* comment */ }" rather than "else /* comment */;"
14852 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14853 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14854 a block, when the outer 'i' will do.
14855 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14856 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14857 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14858 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14859 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14860 Rename locals to avoid shadowing.
14861 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14862 * coding.c (emacs_mule_char, encode_invocation_designation):
14863 Now static, since they're not used elsewhere.
413bb2db 14864 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14865 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14866 (decode_coding_emacs_mule): Mark variables that gcc
14867 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14868 (detect_coding_iso_2022): Initialize a local variable that might
14869 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14870 this initialization is needed. (Bug#8211)
5f58e762
PE
14871 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14872 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14873 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14874 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14875 Remove unused macros.
f38b440c 14876
232b38b9 14877 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14878 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14879 * character.c (string_count_byte8): Likewise.
232b38b9 14880
fb90da1b
PE
14881 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14882 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14883
fb93dbc2
PE
14884 * chartab.c (copy_sub_char_table): Now static, since it's not used
14885 elsewhere.
5c156ace
PE
14886 (sub_char_table_ref_and_range, char_table_ref_and_range):
14887 Rename locals to avoid shadowing.
bbcd0949 14888 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14889
7d3b3862 14890 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14891 (BIDI_BOB): Remove unused macro.
7d3b3862 14892
6be7d3da
PE
14893 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14894 deduce are never used uninitialized.
c2ed9c8b 14895 * term.c (encode_terminal_code): Likewise.
6be7d3da 14896
75f8807f 14897 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14898
50938595
PE
14899 * tparam.h: New file.
14900 * term.c, tparam.h: Include it.
14901 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14902 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14903 Move these decls to tparam.h, and make them agree with what
14904 is actually in tparam.c. The previous trick of using incompatible
14905 decls in different modules does not conform to the C standard.
14906 All callers of tparam changed to use tparam's actual API.
14907 * tparam.c (tparam1, tparam, tgoto):
14908 Use const pointers where appropriate.
14909
fbceeba2
PE
14910 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14911 * cm.h (struct cm): Likewise.
14912 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14913 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14914 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14915 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14916 (turn_on_face, init_tty): Likewise.
14917 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14918
7f3f1250
PE
14919 * term.c (term_mouse_position): Rename local to avoid shadowing.
14920
e6ca6543
PE
14921 * alloc.c (mark_ttys): Move decl from here ...
14922 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14923
c40f8d15
AS
149242011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14925
14926 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14927
cfe0661d
JB
149282011-03-09 Juanma Barranquero <lekktu@gmail.com>
14929
14930 * search.c (compile_pattern_1): Remove argument regp, unused since
14931 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14932 (compile_pattern): Don't pass it.
14933
0afb4571
J
149342011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14935
14936 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14937 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14938 for ! HAVE_GTK3.
14939 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14940
14941 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14942
14943 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14944 gdk_window_get_screen, gdk_window_get_geometry,
14945 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14946 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14947 (xg_get_pixbuf_from_pixmap): New function.
14948 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14949 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14950 Call xg_get_pixbuf_from_pixmap instead of
14951 gdk_pixbuf_get_from_drawable.
14952 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14953 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14954 (xg_check_special_colors): Use GtkStyleContext and its functions
14955 for HAVE_GTK3.
14956 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14957 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14958 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14959 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14960 Call gtk_widget_get_preferred_size.
0afb4571
J
14961 (xg_frame_resized): gdk_window_get_geometry only takes 5
14962 parameters.
44f230aa
SM
14963 (xg_win_to_widget, xg_event_is_for_menubar):
14964 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14965 (xg_set_widget_bg): New function.
14966 (delete_cb): New function.
895009e1 14967 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14968 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14969 (xg_set_background_color): Call xg_set_widget_bg.
14970 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14971 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14972 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14973 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14974 if ! HAVE_GTK3.
14975 (update_frame_tool_bar): Call gtk_widget_hide.
14976 (xg_initialize): Use GDK_KEY_g.
14977
14978 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14979 if ! HAVE_GTK3
14980 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14981
14982 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14983 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14984 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14985
1c2cc4ef
JB
149862011-03-08 Juanma Barranquero <lekktu@gmail.com>
14987
14988 * w32xfns.c (select_palette): Check success of RealizePalette against
14989 GDI_ERROR, not zero.
14990
33383987 14991See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14992
14993;; Local Variables:
14994;; coding: utf-8
aac0c6e3
MR
14995;; End:
14996
2f097256 14997 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14998
14999 This file is part of GNU Emacs.
15000
15001 GNU Emacs is free software: you can redistribute it and/or modify
15002 it under the terms of the GNU General Public License as published by
15003 the Free Software Foundation, either version 3 of the License, or
15004 (at your option) any later version.
15005
15006 GNU Emacs is distributed in the hope that it will be useful,
15007 but WITHOUT ANY WARRANTY; without even the implied warranty of
15008 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15009 GNU General Public License for more details.
15010
15011 You should have received a copy of the GNU General Public License
15012 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.