gnus-win.el (gnus-configure-frame): Pass an arg to window-dedicated-p
[bpt/emacs.git] / src / ChangeLog
CommitLineData
defd4196
PE
12012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2
3 Port byte-code-meter to modern targets.
4 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
5 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
6 CHECK_LISP_OBJECT_TYPE reported by Dmitry Andropov in
7 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
8 (METER_1, METER_2): Simplify.
9
1053a871
SM
102012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
11
12 * data.c (Fdefalias): Return `symbol' (bug#11686).
13
b7e8d081
MR
142012-06-18 Martin Rudalics <rudalics@gmx.at>
15
16 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
17 gets killed during executing of this function (Bug#11665).
18 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
19 (Vkill_buffer_query_functions): In doc-string say that functions
20 run by this hook should not change the current buffer.
21
7ea2b339
PE
222012-06-18 Paul Eggert <eggert@cs.ucla.edu>
23
24 Fix recently-introduced process.c problems found by static checking.
25 * process.c (write_queue_push, write_queue_pop, send_process):
26 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
27 (write_queue_pop): Fix pointer signedness problem.
28 (send_process): Remove unused local.
29
96a313a1
CY
302012-06-17 Chong Yidong <cyd@gnu.org>
31
32 * xdisp.c (redisplay_internal): No need to redisplay terminal
33 frames that are not on top.
34
20ca2e94
TN
352012-06-17 Troels Nielsen <bn.troels@gmail.com>
36
37 * process.c (make_process): Initialize write_queue.
38 (write_queue_push, write_queue_pop): New functions.
39 (send_process): Use them to maintain correct ordering of process
40 writes (Bug#10815).
41
9a900ca9
PE
422012-06-17 Paul Eggert <eggert@cs.ucla.edu>
43
310fbfa8
PE
44 * lisp.h (eassert): Assume C89 or later.
45 This removes the need for CHECK.
46 (CHECK): Remove. Its comments about always evaluating its
47 argument were confusing, as 'eassert' typically does not evaluate
48 its argument.
49
27bb1ca4
PE
50 * coding.c (produce_chars): Use ptrdiff_t, not int.
51
9a900ca9
PE
52 * xterm.c (x_draw_underwave): Check for integer overflow.
53 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
54
41b7f8bc 552012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
56
57 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
58 referenced (Bug#11583).
59
9b0e3eba
AA
602012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
61
62 Implement wave-style variant of underlining.
63 * dispextern.h (face_underline_type): New enum.
64 (face): Add field for underline type.
65 * nsterm.m (ns_draw_underwave): New function.
66 (ns_draw_text_decoration): Use it.
67 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
68 New functions.
69 (x_draw_glyph_string): Use them.
70 * xfaces.c (Qline, Qwave): New Lisp objects.
71 (check_lface_attrs, merge_face_ref)
1053a871
SM
72 (Finternal_set_lisp_face_attribute, realize_x_face):
73 Handle wave-style underline face attributes.
9b0e3eba
AA
74 * xterm.c (x_draw_underwave): New function.
75 (x_draw_glyph_string): Use it.
76
0fb52f11
JB
772012-06-16 Juanma Barranquero <lekktu@gmail.com>
78
79 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
80 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
81 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
82 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
83 ($(BLD)/w32select.$(O)): Update dependencies.
84
e5560ff7
AS
852012-06-16 Andreas Schwab <schwab@linux-m68k.org>
86
87 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
88 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
89 * character.c (_fetch_multibyte_char_p): Remove.
90 * alloc.c: Include "character.h" before "buffer.h".
91 * bidi.c: Likewise.
92 * buffer.c: Likewise.
93 * bytecode.c: Likewise.
94 * callint.c: Likewise.
95 * callproc.c: Likewise.
96 * casefiddle.c: Likewise.
97 * casetab.c: Likewise.
98 * category.c: Likewise.
99 * cmds.c: Likewise.
100 * coding.c: Likewise.
101 * composite.c: Likewise.
102 * dired.c: Likewise.
103 * dispnew.c: Likewise.
104 * doc.c: Likewise.
105 * dosfns.c: Likewise.
106 * editfns.c: Likewise.
107 * emacs.c: Likewise.
108 * fileio.c: Likewise.
109 * filelock.c: Likewise.
110 * font.c: Likewise.
111 * fontset.c: Likewise.
112 * fringe.c: Likewise.
113 * indent.c: Likewise.
114 * insdel.c: Likewise.
115 * intervals.c: Likewise.
116 * keyboard.c: Likewise.
117 * keymap.c: Likewise.
118 * lread.c: Likewise.
119 * macros.c: Likewise.
120 * marker.c: Likewise.
121 * minibuf.c: Likewise.
122 * nsfns.m: Likewise.
123 * nsmenu.m: Likewise.
124 * print.c: Likewise.
125 * process.c: Likewise.
126 * regex.c: Likewise.
127 * region-cache.c: Likewise.
128 * search.c: Likewise.
129 * syntax.c: Likewise.
130 * term.c: Likewise.
131 * textprop.c: Likewise.
132 * undo.c: Likewise.
133 * unexsol.c: Likewise.
134 * w16select.c: Likewise.
135 * w32fns.c: Likewise.
136 * w32menu.c: Likewise.
137 * window.c: Likewise.
138 * xdisp.c: Likewise.
139 * xfns.c: Likewise.
140 * xmenu.c: Likewise.
141 * xml.c: Likewise.
142 * xselect.c: Likewise.
143
2f07e6af
EZ
1442012-06-16 Eli Zaretskii <eliz@gnu.org>
145
1053a871
SM
146 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
147 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 148 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
149 row.
150 (handle_face_prop): Use chunk-relative overlay string index when
151 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
152 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
153 the rightmost. (Bug#11720)
2f07e6af 154
29b83cec
AS
1552012-06-16 Andreas Schwab <schwab@linux-m68k.org>
156
157 * category.h (CHAR_HAS_CATEGORY): Define as inline.
158 (CATEGORY_MEMBER): Enforce 1/0 value.
159 * category.c (_temp_category_set): Remove.
160
4c5501e9
EZ
1612012-06-16 Eli Zaretskii <eliz@gnu.org>
162
163 * window.c (Fdelete_other_windows_internal)
164 (Fdelete_window_internal): Don't access frame's mouse highlight
165 info of the initial frame. (Bug#11677)
166
2b570124
PE
1672012-06-14 Paul Eggert <eggert@cs.ucla.edu>
168
e93864f9
PE
169 * .gdbinit (xgetint): Fix recently-introduced paren typo.
170 Assume USE_2_TAGS_FOR_INTS.
171 (xreload): Adjust $tagmask width to match recent lisp.h change.
172
2b570124
PE
173 Simplify lisp.h in minor ways that should not affect code.
174 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
175 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
176 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
177 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
178 (INTTYPEBITS): New macro, for clarity.
179 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
180 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
181 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
182 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
183 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
184
81755f69
JB
1852012-06-13 Juanma Barranquero <lekktu@gmail.com>
186
187 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
188
16192a57
GM
1892012-06-13 Glenn Morris <rgm@gnu.org>
190
191 * s/bsd-common.h (BSD4_3):
192 * s/usg5-4-common.h (USG5_4): No longer define; unused.
193
646b5f55
AS
1942012-06-13 Andreas Schwab <schwab@linux-m68k.org>
195
196 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
197 instead of union.
198 (XLI, XIL): Define.
1053a871
SM
199 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
200 Use them.
201 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 202 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 203 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
204 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
205 * frame.c (delete_frame): Remove outdated comment.
206 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
207 USE_LISP_UNION_TYPE.
208 (Fw32_unregister_hot_key): Likewise.
209 (Fw32_toggle_lock_key): Likewise.
210 * w32menu.c (add_menu_item): Likewise.
211 (w32_menu_display_help): Use XIL instead of checking
212 USE_LISP_UNION_TYPE.
213 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
214 (init_heap): Likewise.
215 * w32term.c (w32_read_socket): Update comment.
216
1d3823c9
GM
2172012-06-13 Glenn Morris <rgm@gnu.org>
218
c62ff706
GM
219 * s/usg5-4-common.h, src/s/unixware.h:
220 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
221
1d3823c9
GM
222 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
223
bfe3e0a2
PE
2242012-06-13 Paul Eggert <eggert@cs.ucla.edu>
225
226 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
227 * alloc.c (make_number) [!defined make_number]:
228 Remove, as lisp.h always defines this now.
229 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
230 (roundup_size): Verify that it is a power of 2.
231 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
232 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
233 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
234 -DUSE_LSB_TAG=0, to override the automatically-selected default.
235 USE_LSB_TAG now is always defined to be either 0 or 1.
236 All uses changed.
237 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
238 code works fine either way, and efficiency is not a concern here,
239 as the union type is for debugging, not for production.
240 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
241 Use an inline function on all platforms when using the union type,
242 since this is simpler and 'static inline' can be used portably
243 within Emacs now.
244 (LISP_INITIALLY_ZERO): New macro.
245 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
246 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
247
45fa9c0f
GM
2482012-06-12 Glenn Morris <rgm@gnu.org>
249
b4492cba
GM
250 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
251
252 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 253
45fa9c0f
GM
254 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
255 Move BROKEN_SIGIO to configure.
256
257 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
258 Move NO_TERMIO to configure.
259
0e25d334
CY
2602012-06-12 Chong Yidong <cyd@gnu.org>
261
262 * image.c (imagemagick_load_image): Use MagickFlattenImage if
263 MagickMergeImageLayers is undefined. Use pixel pusher loop if
264 MagickExportImagePixels is undefined.
265
43682bb6
PE
2662012-06-12 Paul Eggert <eggert@cs.ucla.edu>
267
268 * image.c (imagemagick_load_image): Remove unused label.
269
a9be7d2b
GM
2702012-06-11 Glenn Morris <rgm@gnu.org>
271
272 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
273 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
274 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
275 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
276
3017f87f
SM
2772012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
278
279 * alloc.c (make_byte_code): New function.
280 (Fmake_byte_code): Use it. Don't purify here.
281 * lread.c (read1): Use it as well to avoid extra allocation.
282
1b9b4cf4
CY
2832012-06-11 Chong Yidong <cyd@gnu.org>
284
285 * image.c (imagemagick_load_image): Implement transparency.
286
95988fcf
AS
2872012-06-10 Andreas Schwab <schwab@linux-m68k.org>
288
289 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
290 account for preceding backslashes. (Bug#11663)
291
cd4eb164
CY
2922012-06-09 Chong Yidong <cyd@gnu.org>
293
294 * term.c: Support italics in capable terminals (Bug#9652).
295 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
296 (turn_on_face): Output using TS_enter_italic_mode if available.
297 Don't handle unused blinking and alt-charset cases.
298 (turn_off_face): Handle italic case; discard unused tty_blinking_p
299 and tty_alt_charset_p cases.
300 (tty_capable_p, init_tty): Support italics.
301
302 * termchar.h (struct tty_display_info): Add field for italics.
303 Remove unused blink field.
304
305 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
306 Handle slant.
307
308 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
309 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
310 tty_alt_charset_p. Add tty_italic_p.
311
ff88beb8
MA
3122012-06-09 Michael Albinus <michael.albinus@gmx.de>
313
314 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
315 dbus_type_is_basic if available.
316 (xd_extract_signed, xd_extract_unsigned): Rename from
317 extract_signed and extract_unsigned, respectively. Adapt callers.
318
44286096
CY
3192012-06-09 Chong Yidong <cyd@gnu.org>
320
1682701f
CY
321 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
322
44286096
CY
323 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
324 case (Bug#9752).
325
d86feb17
PE
3262012-06-08 Paul Eggert <eggert@cs.ucla.edu>
327
328 * xdisp.c (vmessage): Treat frame message as multibyte.
329 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
330 would generate the diagnostic "Making \302\247 buffer-local while
331 let-bound!".
332
d5c20fe8
EZ
3332012-06-08 Eli Zaretskii <eliz@gnu.org>
334
335 * dispnew.c (showing_window_margins_p): Undo last change, which
336 was done due to an inadvertent commit.
337 (adjust_frame_glyphs_for_frame_redisplay): Do call
338 showing_window_margins_p.
339
513749ee
SM
3402012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
341
342 * eval.c (Fmake_var_non_special): New primitive.
343 (syms_of_eval): Defsubr it.
344 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
345
d4a8f5c1
JB
3462012-06-08 Juanma Barranquero <lekktu@gmail.com>
347
348 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
349 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
350
8bbbc977
EZ
3512012-06-08 Eli Zaretskii <eliz@gnu.org>
352
353 * alloc.c (allocate_vectorlike): Fix last change.
354
f3372c87
DA
3552012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
356
357 Block-based vector allocation of small vectors.
358 * lisp.h (struct vectorlike_header): New field `nbytes',
359 adjust comment accordingly.
360 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
361 to denote vector blocks. Adjust users (live_vector_p,
362 mark_maybe_pointer, valid_lisp_object_p) accordingly.
363 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
364 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
365 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
366 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
367 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
368 (roundup_size): New constant.
369 (struct vector_block): New data type.
370 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 371 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
372 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
373 (sweep_vectors): New functions.
374 (allocate_vectorlike): Return `zero_vector' as the only vector of
375 0 items. Allocate new vector from block if vector size is less than
376 or equal to VBLOCK_BYTES_MAX.
377 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
378 (init_alloc_once): Add call to init_vectors.
379
4f18a4ed
SM
3802012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
381
382 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
383
86f158bc
PE
3842012-06-07 Paul Eggert <eggert@cs.ucla.edu>
385
386 * doprnt.c (doprnt): Truncate multibyte char correctly.
387 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
388 would mishandle a string argument "Xc" if X was a multibyte
389 character of length 2: it would truncate after X's first byte
390 rather than including all of X.
391
c5cfcbe0
CY
3922012-06-06 Chong Yidong <cyd@gnu.org>
393
394 * buffer.c (word_wrap): Doc fix.
395
c05cf390
PE
3962012-06-04 Paul Eggert <eggert@cs.ucla.edu>
397
398 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
399
0c3461de
GM
4002012-06-03 Glenn Morris <rgm@gnu.org>
401
402 * xdisp.c (tool-bar-style): Doc fix.
403
c71232db
UM
4042012-06-03 Ulrich Müller <ulm@gentoo.org>
405
406 * Makefile.in (PAXCTL): Define.
407 (temacs$(EXEEXT)): Disable memory randomization for the temacs
408 binary via PaX flags if the paxctl utility is available.
409 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
410 Restore PaX flags to their default. (Bug#11398)
411
383f7350
CY
4122012-06-03 Chong Yidong <cyd@gnu.org>
413
414 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
415 buffer (Bug#11226).
416
5f2c76c6
CY
4172012-06-03 Chong Yidong <cyd@gnu.org>
418
419 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
420 (note_mode_line_or_margin_highlight): If there is no help echo,
421 use mode-line-default-help-echo. Handle the case where the mouse
422 position is past the end of the mode line string.
423
424 * buffer.c (buffer_local_value_1): New function, split from
425 Fbuffer_local_value; can return Qunbound.
426 (Fbuffer_local_value): Use it.
427 (Vmode_line_format): Docstring tweaks.
428
773d47f6
PE
4292012-06-02 Paul Eggert <eggert@cs.ucla.edu>
430
431 * sysdep.c (system_process_attributes): Improve comment.
432
f2d6a3df
SM
4332012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
434
435 * keyboard.c: Export real-this-command to Elisp.
436 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
437 and DEFVAR it. Update all users.
438
63810350
PE
4392012-06-02 Paul Eggert <eggert@cs.ucla.edu>
440
7bd5c1f4
PE
441 * minibuf.c (Fassoc_string): Remove duplicate declaration.
442
63810350
PE
443 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
444 Convert pctcpu and pctmem to Lisp float properly.
445 Let the compiler fold better, as 100.0/0x8000 is exact.
446
a2821611
AS
4472012-06-02 Andreas Schwab <schwab@linux-m68k.org>
448
449 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
450 cons_block.
451
5fceba1d
PE
4522012-06-01 Paul Eggert <eggert@cs.ucla.edu>
453
454 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
455
c98ff5dd
DA
4562012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
457
458 For a 'struct window', replace some Lisp_Object fields to
459 bitfields where appropriate, remove unused fields.
460 * window.h (struct window): Remove unused 'last_mark_x' and
461 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
462 change it's type from Lisp_Object to bitfield.
463 Change type of 'force_start', 'optional_new_start',
464 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
465 fields from Lisp_Object to bitfield. Adjust users accordingly.
466
ca34e0be
PE
4672012-05-31 Paul Eggert <eggert@cs.ucla.edu>
468
469 Pacify gcc -Wdouble-precision when using Xaw.
470 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
471 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
472 Use 'float' consistently, rather than 'float' in most places
473 and 'double' in a couple of places.
474
efc00ab1 4752012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
476
477 * xdisp.c (handle_stop): Detect whether we have overlay strings
478 loaded by testing it->current.overlay_string_index to be
479 non-negative, instead of checking whether n_overlay_strings is
480 positive. (Bug#11587)
481
efc00ab1 4822012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
483
484 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
485
486 * doc.c (Fsubstitute_command_keys): Doc fix.
487
efc00ab1 4882012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
489
490 * search.c (search_buffer): Remove calls to
491 r_alloc_inhibit_buffer_relocation, as it is now called by
492 maybe_unify_char, which was the cause of relocation of buffer text
493 in bug#11519.
494
efc00ab1 4952012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
496
497 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
498 for the duration of call to load_charset, to avoid problems with
499 callers of maybe_unify_char that access buffer text through C
500 pointers.
501
502 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
503 decrement the inhibition flag, instead of just setting or
504 resetting it.
505
ba93a187
PE
5062012-05-31 Paul Eggert <eggert@cs.ucla.edu>
507
508 Remove obsolete '#define static' cruft.
509 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
510 This #undef was "temporary" in 2000; it is no longer needed
511 now that '#define static' has gone away.
512 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
513 (gray_bitmap_bits): Remove; no longer needed.
514 All uses replaced with definiens.
515 * xterm.c: Include "bitmaps/gray.xbm".
516
9e4bf381
PE
5172012-05-30 Paul Eggert <eggert@cs.ucla.edu>
518
519 Clean up __executable_start, monstartup when --enable-profiling.
520 The following changes affect the code only when profiling.
521 * dispnew.c (__executable_start): Rename from safe_bcopy.
522 Define only on platforms that need it.
523 * emacs.c: Include <sys/gmon.h> when profiling.
524 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
525 (__executable_start): Remove decl, since lisp.h does it now.
526 (safe_bcopy): Remove decl; no longer has that name.
527 (main): Coalesce #if into single bit of code, for simplicity.
528 Cast pointers to uintptr_t, since standard libraries want integers
529 and not pointers.
530 * lisp.h (__executable_start): New decl.
531
32d72c2f
GM
5322012-05-31 Glenn Morris <rgm@gnu.org>
533
534 * image.c (Fimagemagick_types): Doc fix.
535
baac5bc7
JM
5362012-05-30 Jim Meyering <meyering@redhat.com>
537
538 * callproc.c (Fcall_process_region): Include directory component
539 in mkstemp error message (Bug#11586).
540
72cb32cf
PE
5412012-05-30 Paul Eggert <eggert@cs.ucla.edu>
542
543 * alloc.c, lisp.h (make_pure_vector): Now static.
544
61b108cc
SM
5452012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
546
547 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
548 Move to byte-run.el.
549 (Fautoload): Do the hash-doc more carefully.
550 * data.c (Fdefalias): Purify definition, except for keymaps.
551 (Qdefun): Move from eval.c.
552 * lisp.h (Qdefun): Remove.
553 * lread.c (read1): Tiny simplification.
554
471fe23d
TN
5552012-05-29 Troels Nielsen <bn.troels@gmail.com>
556
934f3f58 557 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
558 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
559 Bug#9642, but explicitly check that the buffer the overlay would
560 be moved to is live and rearrange lines to make sure that errors
561 will not put the overlay in an inconsistent state.
562 (Fdelete_overlay): Cosmetics.
563
85d0efd1
EZ
5642012-05-28 Eli Zaretskii <eliz@gnu.org>
565
566 * w32term.c (my_bring_window_to_top): New function.
567 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
568 could be different from the original one.
569 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
570 (Bug#11513)
571
572 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
573 by calling BringWindowToTop.
574
575 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
576 (WM_EMACS_END): Increase by one.
577
da92a98c
PE
5782012-05-28 Paul Eggert <eggert@cs.ucla.edu>
579
580 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
581 This avoids undefined behavior that might cause the eassert
582 to not catch an out-of-range value.
583
74d1f848
JB
5842012-05-28 Juanma Barranquero <lekktu@gmail.com>
585
586 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
587 Update dependencies.
588
9e1a06fc
EZ
5892012-05-27 Eli Zaretskii <eliz@gnu.org>
590
591 * bidi.c (bidi_mirror_char): Fix last change.
592
f3dd7312
AS
5932012-05-27 Andreas Schwab <schwab@linux-m68k.org>
594
595 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
596 when referring to sectname field in printf format.
597
81899c91
PE
5982012-05-27 Paul Eggert <eggert@cs.ucla.edu>
599
57b81a9f
PE
600 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
601 Only r_alloc_inhibit_buffer_relocation needed to be added;
602 the others were already declared.
603
81899c91
PE
604 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
605 before checking whether it's out of range. Put the check inside
606 eassert. See
607 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
608
33017faf 6092012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
610
611 * callproc.c (Fcall_process): Restore a line that was accidentally
612 commented out in the 2011-02-13 change (bug#11547).
613
33017faf 6142012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
615
616 * lisp.h [REL_ALLOC]: Add prototypes for external functions
617 defined on ralloc.c.
618
619 * buffer.c [REL_ALLOC]: Remove prototypes of
620 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
621 they are now on lisp.h.
622
623 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
624
625 * search.c (search_buffer): Use it to inhibit relocation of buffer
626 text while re_search_2 is doing its job, because re_search_2 is
627 passed C pointers to buffer text. (Bug#11519)
628
23415acf
EZ
629 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
630 Update value to 24.
631
44e27368
EZ
632 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
633 state after an additional call to move_it_in_display_line_to, keep
634 the values of it->max_ascent and it->max_descent found for the
635 entire line.
636 (pos_visible_p): Revert the comparison against bottom_y to what it
637 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
638 (Bug#11464)
639
c1892f11
PE
6402012-05-26 Paul Eggert <eggert@cs.ucla.edu>
641
642 Fix coding-related core dumps with gcc -ftrapv.
643 The code was computing A - B, where A and B are pointers, and B is
644 random garbage. This can lead to core dumps on platforms that
645 have special pointer registers, and it also leads to core dumps on
646 x86-64 when compiled with gcc -ftrapv. The fix is to compute
647 A - B only when B is initialized properly.
648 * coding.c (coding_set_source, coding_set_destination): Return void.
649 (coding_change_source, coding_change_destinations): New functions,
650 with the old behaviors of coding_set_source and coding_set_destination.
651 All callers that need an offset changed to use these new functions.
652
eb7afdad
GM
6532012-05-26 Glenn Morris <rgm@gnu.org>
654
655 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
656
f12fdf02
EZ
6572012-05-26 Eli Zaretskii <eliz@gnu.org>
658
53a63be6 659 Extend mouse support on W32 text-mode console.
61b108cc
SM
660 * xdisp.c (draw_row_with_mouse_face):
661 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 662
eb3f6f01 663 * w32console.c: Include window.h.
61b108cc
SM
664 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
665 New functions.
eb3f6f01
EZ
666 (initialize_w32_display): Initialize mouse-highlight data.
667
53a63be6
EZ
668 * w32inevt.c: Include termchar.h and window.h.
669 (do_mouse_event): Support mouse-autoselect-window. When the mouse
670 moves, call note_mouse_highlight. If help_echo changed, call
671 gen_help_event to produce help-echo message in the echo area.
672 Call clear_mouse_face if mouse_face_hidden is set in the mouse
673 highlight info.
674
4cfd81f6
PE
6752012-05-26 Paul Eggert <eggert@cs.ucla.edu>
676
677 * lread.c (read1): Simplify slightly to avoid an overflow warning
678 with GCC 4.7.0 on x86-64.
679
4446092a
EZ
6802012-05-26 Eli Zaretskii <eliz@gnu.org>
681
682 * bidi.c (bidi_mirror_char): Revert last change: an int is
683 definitely wide enough here.
684
42b2a986 6852012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 686
42b2a986 687 Fix integer width and related bugs (Bug#9874).
eb106a49 688 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
689 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
690 (string_bytes, check_sblock, allocate_string_data):
691 (compact_small_strings, Fmake_bool_vector, make_string)
692 (make_unibyte_string, make_multibyte_string)
693 (make_string_from_bytes, make_specified_string)
694 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
695 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
696 (mark_vectorlike):
697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
698 (allocate_pseudovector):
699 Use int, not EMACS_INT, where int is wide enough.
700 (inhibit_garbage_collection, Fgarbage_collect):
701 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
702 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
703 int might not be wide enough.
704 (bidi_cache_search, bidi_cache_find, bidi_init_it)
705 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
706 (bidi_at_paragraph_end, bidi_find_paragraph_start)
707 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
708 (bidi_level_of_next_char, bidi_move_to_visually_next):
709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
710 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
711 (Fkill_buffer, Fset_buffer_major_mode)
712 (advance_to_char_boundary, Fbuffer_swap_text)
713 (Fset_buffer_multibyte, overlays_at, overlays_in)
714 (overlay_touches_p, struct sortvec, record_overlay_string)
715 (overlay_strings, recenter_overlay_lists)
716 (adjust_overlays_for_insert, adjust_overlays_for_delete)
717 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
718 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
719 (Foverlay_recenter, last_overlay_modification_hooks_used)
720 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
722 (validate_region): Omit unnecessary test for b <= e,
723 since that's guaranteed by the previous test.
d311d28c
PE
724 (adjust_overlays_for_delete): Avoid pos + length overflow.
725 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
726 (report_overlay_modification):
727 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
728 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
729 Omit pointer cast, which isn't needed anyway, and doesn't work
730 after the EMACS_INT -> ptrdiff_t change.
02481186 731 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
732 * buffer.h: Adjust decls to match defn changes elsewhere.
733 (struct buffer_text, struct buffer):
734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
735 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
736 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
737 not int, to avoid needless 32-bit limit on 64-bit hosts.
738 (exec_byte_code): Use tighter memory-full test, one that checks
739 for alloca overflow. Don't compute the address of the object just
740 before an array, as that's not portable. Use EMACS_INT, not
741 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
742 * callint.c (Fcall_interactively):
743 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
744 * callproc.c (call_process_kill, Fcall_process):
745 Don't assume pid_t fits into an Emacs fixnum.
746 (call_process_cleanup, Fcall_process, child_setup):
747 Don't assume pid_t fits into int.
748 (call_process_cleanup, Fcall_process, delete_temp_file)
749 (Fcall_process_region):
750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
751 (Fcall_process): Simplify handling of volatile integers.
752 Use int, not EMACS_INT, where int will do.
753 * casefiddle.c (casify_object, casify_region, operate_on_word)
754 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
756 (casify_object): Avoid integer overflow when overallocating buffer.
757 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 758 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
759 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
760 * category.h (CATEGORYP): Don't assume arg is nonnegative.
761 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
762 integers are now checked earlier. All uses replaced with XINT.
763 (ccl_driver):
764 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
765 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
766 (ccl_driver, Fregister_code_conversion_map):
767 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
768 (resolve_symbol_ccl_program): Check that vector header is in range.
769 Always copy the vector, so that we can check its contents reliably
770 now rather than having to recheck each instruction as it's being
771 executed. Check that vector words fit in 'int'.
772 (ccl_get_compiled_code, Fregister_ccl_program)
773 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
774 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
775 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
776 contents are in range.
777 (Fccl_execute_on_string): Check that status is in range.
778 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
779 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
780 Accept and return EMACS_INT, not int, because callers can pass values
781 out of 'int' range.
782 (c_string_width, strwidth, lisp_string_width, chars_in_text)
783 (multibyte_chars_in_text, parse_str_as_multibyte)
784 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
785 (str_as_unibyte, str_to_unibyte, string_count_byte8)
786 (string_escape_byte8, Fget_byte):
787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 788 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
789 avoid mishandling large integers.
790 * character.h: Adjust decls to match defn changes elsewhere.
791 * charset.c (load_charset_map_from_file, find_charsets_in_text)
792 (Ffind_charset_region):
793 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
794 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
795 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 796 Don't assume fixnum fits in int.
d311d28c
PE
797 (load_charset_map_from_vector, Fmap_charset_chars):
798 Remove now-unnecessary CHECK_NATNUMs.
799 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
800 Don't rely on undefined behavior with signed left shift overflow.
801 Don't assume unsigned int fits into fixnum, or that fixnum fits
802 into unsigned int. Don't require max_code to be a valid fixnum;
803 that's not true for gb10830 4-byte on a 32-bit host. Allow
804 invalid_code to be a cons, for the same reason. Require code_offset
805 to be a character. Avoid int overflow if max_char is close
806 to INT_MAX.
807 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
808 this is intended anyway and avoids some undefined behavior.
809 (load_charset_map): Pass unsigned, not int, as 2nd arg of
810 INDEX_TO_CODE_POINT, as that's what it expects.
811 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
812 * charset.h (DECODE_CHAR): Return int, not unsigned;
813 this is what was intended anyway, and it avoids undefined behavior.
814 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
815 integer-overflow issues.
816 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
817 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
818 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
819 * chartab.c (Fmake_char_table, Fset_char_table_range)
820 (uniprop_get_decoder, uniprop_get_encoder):
821 Don't assume fixnum fits in int.
822 * cmds.c (move_point): New function, that does the gist of
823 Fforward_char and Fbackward_char, but does so while checking
824 for integer overflow more accurately.
c96e5d6a 825 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
826 (Fforward_line, Fend_of_line, internal_self_insert)
827 (internal_self_insert):
828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
829 Fix a FIXME, by checking for integer overflow when calculating
830 target_clm and actual_clm.
831 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 832 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
833 (ASSURE_DESTINATION, coding_alloc_by_realloc)
834 (coding_alloc_by_making_gap, alloc_destination)
835 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
836 (encode_coding_utf_16, detect_coding_emacs_mule)
837 (decode_coding_emacs_mule, encode_coding_emacs_mule)
838 (detect_coding_iso_2022, decode_coding_iso_2022)
839 (encode_invocation_designation, encode_designation_at_bol)
840 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
841 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
842 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
843 (encode_coding_ccl, encode_coding_raw_text)
844 (detect_coding_charset, decode_coding_charset)
845 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
846 (produce_composition, produce_charset, produce_annotation)
847 (decode_coding, handle_composition_annotation)
848 (handle_charset_annotation, consume_chars, decode_coding_gap)
849 (decode_coding_object, encode_coding_object, detect_coding_system)
850 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
851 (code_convert_region, code_convert_string)
8f50130c
PE
852 (Fdefine_coding_system_internal)
853 (coding_set_source, coding_set_destination):
d311d28c
PE
854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
855 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
856 (Fdefine_coding_system_internal):
857 Don't assume fixnums fit in int.
858 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 859 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
860 (Funencodable_char_position, Fcheck_coding_systems_region)
861 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 862 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 863 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 864 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 865 Don't access memory outside of the args array.
d311d28c 866 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
867 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
868 result of ENCODE_CHAR.
d311d28c
PE
869 * coding.h: Adjust decls to match defn changes elsewhere.
870 (struct coding_system):
871 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
872 * composite.c (get_composition_id, find_composition)
873 (run_composition_function, update_compositions)
874 (compose_text, composition_gstring_put_cache)
875 (composition_gstring_p, composition_gstring_width)
876 (fill_gstring_header, fill_gstring_body, autocmp_chars)
877 (composition_compute_stop_pos, composition_reseat_it)
878 (composition_update_it, struct position_record)
879 (find_automatic_composition, composition_adjust_point)
880 (Fcomposition_get_gstring, Ffind_composition_internal):
881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
882 (update_compositions):
883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
884 * composite.h: Adjust decls to match defn changes elsewhere.
885 (struct composition):
886 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
887 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
888 Do not attempt to compute the address of the object just before a
889 buffer; this is not portable.
890 (Faref, Faset):
891 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
892 (Faset): Use int, not EMACS_INT, where int is wide enough.
893 (Fstring_to_number): Don't assume fixnums fit in int.
894 (Frem): Don't assume arg is nonnegative.
895 * dbusbind.c (xd_append_arg): Check for integers out of range.
896 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 897 (extract_signed, extract_unsigned): New functions.
243e0530
PE
898 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
899 (xd_get_connection_references): Return ptrdiff_t, not int.
900 All uses changed.
901 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
902 (xd_read_message_1):
903 Use int, not unsigned, where the dbus API uses int.
904 (Fdbus_message_internal): Don't overflow mtype.
905 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
906 * dired.c (directory_files_internal, file_name_completion, scmp)
907 (file_name_completion_stat):
908 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
909 (file_name_completion): Don't overflow matchcount.
910 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
911 * dispextern.h: Adjust decls to match defn changes elsewhere.
912 (struct text_pos, struct glyph, struct bidi_saved_info)
913 (struct bidi_string_data, struct bidi_it, struct composition_it)
914 (struct it):
915 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
916 (struct display_pos, struct composition_it, struct it):
917 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
918 * dispnew.c (increment_matrix_positions)
919 (increment_row_positions, mode_line_string)
920 (marginal_area_string):
921 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 922 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
923 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
924 (duration_to_sec_usec): New function, to check for overflow better.
925 (Fsleep_for, sit_for): Use it.
926 * doc.c (get_doc_string, store_function_docstring):
927 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
928 (get_doc_string, Fsnarf_documentation):
929 Use int, not EMACS_INT, where int is wide enough.
930 (get_doc_string):
931 Use SAFE_ALLOCA, not alloca.
932 Check for overflow when converting EMACS_INT to off_t.
933 * doprnt.c (doprnt):
934 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
935 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
936 Don't assume uid_t fits into fixnum.
937 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
938 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
939 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
940 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
941 (general_insert_function)
942 (Finsert_char, make_buffer_string, make_buffer_string_both)
943 (update_buffer_properties, Fbuffer_substring)
944 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
945 (Fsubst_char_in_region, check_translation)
946 (Ftranslate_region_internal, save_restriction_restore, Fformat)
947 (transpose_markers, Ftranspose_regions):
948 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
949 (clip_to_bounds): Move to lisp.h as an inline function).
950 (Fconstrain_to_field): Don't assume integers are nonnegative.
951 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
952 (Fsubst_char_in_region, Fsave_restriction):
953 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
954 (Femacs_pid): Don't assume pid_t fits into fixnum.
955 (lo_time): Use int, not EMACS_INT, when int suffices.
956 (lisp_time_argument): Check for usec out of range.
957 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
958 (Fuser_login_name, Fuser_full_name): Signal an error
959 if a uid argument is out of range, rather than relying on
960 undefined behavior.
c8d5c857
PE
961 (Fformat_time_string): Remove now-unnecessary check.
962 lisp_time_argument checks for out-of-range usec now.
243e0530 963 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
964 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
965 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
966 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
967 (init_cmdargs, Fdump_emacs):
968 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
969 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
970 the bottom (typically) 32 bits of the fixnum.
971 * eval.c (specpdl_size, call_debugger):
972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
973 (when_entered_debugger, Fbacktrace_debug):
974 Don't assume fixnum can fit in int.
975 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
976 the object just before a buffer; this is not portable.
977 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
978 (grow_specpdl, unbind_to):
979 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
980 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
981 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 982 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
983 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
984 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
985 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
986 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
987 (a_write, e_write):
988 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
989 (Fcopy_file, non_regular_nbytes, read_non_regular)
990 (Finsert_file_contents):
991 Use int, not EMACS_INT, where int is wide enough.
992 (READ_BUF_SIZE): Verify that it fits in int.
993 (Finsert_file_contents): Check that counts are in proper range,
994 rather than assuming fixnums fit into ptrdiff_t etc.
995 Don't assume fixnums fit into int.
125b3835 996 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
997 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
998 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
999 (string_char_to_byte, string_byte_to_char)
1000 (string_make_multibyte, string_to_multibyte)
1001 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1002 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1003 (substring_both, Fdelete, internal_equal, Ffillarray)
1004 (Fclear_string, mapcar1)
1005 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1006 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1007 (larger_vector, make_hash_table, maybe_resize_hash_table)
1008 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1009 (Fmaphash, secure_hash):
1010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1011 (concat): Check for string index and length overflow.
1012 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1013 (Frequire):
1014 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1015 (larger_vector): New API (vec, incr_min, size_max) replaces old
1016 one (vec, new_size, init). This catches size overflow.
1017 INIT was removed because it was always Qnil.
1018 All callers changed.
1019 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1020 the upper bound on a hash table index size.
1021 (make_hash_table, maybe_resize_hash_table): Use it.
1022 (secure_hash): Computer start_byte and end_byte only after
1023 they're known to be in ptrdiff_t range.
1024 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1025 (Ffont_get_glyphs, Ffont_at):
1026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1027 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1028 (Flist_fonts, Fopen_font):
1029 Don't assume fixnum can fit in int.
1030 (check_gstring): Don't assume index can fit in int.
1031 (font_match_p): Check that fixnum is a character, not a nonnegative
1032 fixnum, since the later code needs to stuff it into an int.
1033 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1034 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1035 conversion overflow issues.
1036 (Fopen_font): Check for integer out of range.
1037 (Ffont_get_glyphs): Don't assume index can fit in int.
1038 * font.h: Adjust decls to match defn changes elsewhere.
1039 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1040 integer overflow.
1041 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1042 printmax_t, where ptrdiff_t is wide enough.
1043 (Finternal_char_font):
1044 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1045 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1046 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1047 (Fset_frame_position, x_set_frame_parameters)
1048 (x_set_line_spacing, x_set_border_width)
1049 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1050 Check that fixnums are in proper range for system types.
1051 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1052 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1053 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1054 Use SAFE_ALLOCA_LISP, not alloca.
1055 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1056 intptr_t is wide enough.
1057 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1058 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1059 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1060 Check for fixnum out of range.
1061 * ftfont.c (ftfont_list): Don't assume index fits in int.
1062 Check that fixnums are in proper range for system types.
1063 (ftfont_shape_by_flt):
1064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1065 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1066 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1067 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1068 Check that fixnums are in proper range for system types.
1069 * gnutls.h: Adjust decls to match defn changes elsewhere.
1070 * gtkutil.c (xg_dialog_run):
1071 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1072 (update_frame_tool_bar):
1073 Check that fixnums are in proper range for system types.
1074 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1075 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1076 * indent.c (last_known_column, last_known_column_point):
1077 (current_column_bol_cache):
1078 (skip_invisible, current_column, check_display_width):
1079 (check_display_width, scan_for_column, current_column_1)
1080 (Findent_to, Fcurrent_indentation, position_indentation)
1081 (indented_beyond_p, Fmove_to_column, compute_motion):
1082 (Fcompute_motion, Fvertical_motion):
1083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1084 (last_known_column_modified): Use EMACS_INT, not int.
1085 (check_display_width):
1086 (Fcompute_motion):
1087 Check that fixnums and floats are in proper range for system types.
1088 (compute_motion): Don't assume index or fixnum fits in int.
1089 (compute_motion, Fcompute_motion):
1090 Use int, not EMACS_INT, when it is wide enough.
1091 (vmotion): Omit local var start_hpos that is always 0; that way
1092 we don't need to worry about overflow in expressions involving it.
1093 * indent.h: Adjust decls to match defn changes elsewhere.
1094 (struct position):
1095 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1096 Use int, not EMACS_INT, where int is wide enough.
1097 Remove unused members ovstring_chars_done and tab_offset;
1098 all uses removed.
1099 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1100 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1101 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1102 (make_gap, copy_text, insert, insert_and_inherit)
1103 (insert_before_markers, insert_before_markers_and_inherit)
1104 (insert_1, count_combining_before, count_combining_after)
1105 (insert_1_both, insert_from_string)
1106 (insert_from_string_before_markers, insert_from_string_1)
1107 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1108 (adjust_after_replace, adjust_after_insert, replace_range)
1109 (replace_range_2, del_range, del_range_1, del_range_byte)
1110 (del_range_both, del_range_2, modify_region)
1111 (prepare_to_modify_buffer, signal_before_change)
1112 (signal_after_change, Fcombine_after_change_execute):
1113 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1114 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1115 (balance_an_interval, split_interval_right, split_interval_left)
1116 (find_interval, next_interval, update_interval)
1117 (adjust_intervals_for_insertion, delete_node, delete_interval)
1118 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1119 (static_offset_intervals, offset_intervals)
1120 (merge_interval_right, merge_interval_left, make_new_interval)
1121 (graft_intervals_into_buffer, temp_set_point_both)
1122 (temp_set_point, set_point, adjust_for_invis_intang)
1123 (set_point_both, move_if_not_intangible, get_property_and_range)
1124 (get_local_map, copy_intervals, copy_intervals_to_string)
1125 (compare_string_intervals, set_intervals_multibyte_1):
1126 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1127 * intervals.h: Adjust decls to match defn changes elsewhere.
1128 (struct interval):
1129 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1130 * keyboard.c (this_command_key_count, this_single_command_key_start)
1131 (before_command_key_count, before_command_echo_length, echo_now)
1132 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1133 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1134 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1135 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1136 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1137 (last_non_minibuf_size, last_point_position, echo_truncate)
1138 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1139 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1140 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1141 (stuff_buffered_input):
1142 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1143 (last_auto_save, command_loop_1, read_char):
1144 Use EMACS_INT, not int, to avoid integer overflow.
1145 (record_char): Avoid overflow in total_keys computation.
1146 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1147 * keyboard.h: Adjust decls to match defn changes elsewhere.
1148 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1149 (Fkey_description, Fdescribe_vector, Flookup_key):
1150 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1151 (click_position): New function, to check that positions are in range.
1152 (Fcurrent_active_maps):
1153 (describe_command):
1154 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1155 (Faccessible_keymaps, Fkey_description):
1156 (preferred_sequence_p):
1157 Don't assume fixnum can fit into int.
1158 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1159 Check for integer overflow in size calculations.
1160 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1161 avoid mishandling large integers.
1162 * lisp.h: Adjust decls to match defn changes elsewhere.
1163 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1164 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1165 (struct Lisp_Marker):
1166 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1167 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1168 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1169 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1170 All callers changed.
1171 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1172 Assume the arg has valid form, since it always does.
1173 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1174 unsigned integer system type.
1175 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1176 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1177 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1178 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1179 (duration_to_sec_usec): New decl.
1180 * lread.c (read_from_string_index, read_from_string_index_byte)
1181 (read_from_string_limit, readchar, unreadchar, openp)
1182 (read_internal_start, read1, oblookup):
1183 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1184 (Fload, readevalloop, Feval_buffer, Feval_region):
1185 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1186 (openp): Check for out-of-range argument to 'access'.
1187 (read1): Use int, not EMACS_INT, where int is wide enough.
1188 Don't assume fixnum fits into int.
6efdadfd 1189 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1190 (read_filtered_event): Use duration_to_sec_usec
1191 to do proper overflow checking on durations.
d311d28c
PE
1192 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1193 in size calculation.
1194 (Fexecute_kbd_macro):
1195 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1196 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1197 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1198 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1199 (set_marker_both, set_marker_restricted_both, marker_position)
1200 (marker_byte_position, Fbuffer_has_markers_at):
1201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1202 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1203 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1204 It now merely ensures that the menu is large enough, without
1205 necessarily growing it, as this avoids some integer overflow issues.
1206 All callers changed.
1207 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1208 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1209 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1210 Use SAFE_ALLOCA_LISP, not alloca.
1211 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1212 to EMACS_INT. Check that fixnums are in proper range for system types.
1213 * minibuf.c (minibuf_prompt_width, string_to_object)
1214 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1215 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1216 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1217 (get_minibuffer, read_minibuf_unwind):
1218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1219 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1220 this simplifies overflow checking. All callers changed.
1221 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1222 (Ftest_completion):
1223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1224 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1225 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1226 Check that fixnums are in proper range for system types.
1227 (Fx_create_frame, Fx_show_tip):
1228 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1229 * nsfont.m (ns_findfonts, nsfont_list_family):
1230 Don't assume fixnum fits in long.
1231 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1233 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1234 wide enough.
17fdb222 1235 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1236 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1237 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1238 (PRINTDECLARE, PRINTPREPARE):
1239 (strout, print_string):
1240 (print, print_preprocess, print_check_string_charset_prop)
1241 (print_object):
1242 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1243 (PRINTDECLARE):
1244 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1245 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1246 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1247 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1248 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1249 (print_error_message): Use SAFE_ALLOCA, not alloca.
1250 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1251 (print_depth, new_backquote_output, print_number_index):
1252 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1253 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1254 (Fset_process_window_size, Fformat_network_address)
1255 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1256 (sigchld_handler):
d311d28c 1257 Check that fixnums are in proper range for system types.
d44287d4 1258 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1259 Check for process-ids out of pid_t range rather than relying on
1260 undefined behavior.
e4d81efc 1261 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1262 (Fformat_network_address, read_process_output, send_process)
1263 (Fprocess_send_region, status_notify):
1264 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1265 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1266 (wait_reading_process_output, read_process_output, exec_sentinel):
1267 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1268 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1269 (Faccept_process_output): Use duration_to_sec_usec to do proper
1270 overflow checking on durations.
dde14581
PE
1271 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1272 Don't assume pid_t fits in int.
02481186
PE
1273 * process.h (struct Lisp_Process): Members tick and update_tick
1274 are now of type EMACS_INT, not int.
b62b53e8
PE
1275 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1276 configured --with-wide-int.
d311d28c
PE
1277 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1278 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1279 * search.c (looking_at_1, string_match_1):
1280 (fast_string_match, fast_c_string_match_ignore_case)
1281 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1282 (scan_newline, find_before_next_newline, search_command)
1283 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1284 (set_search_regs, wordify):
1285 (Freplace_match):
1286 (Fmatch_data):
1287 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1288 (string_match_1, search_buffer, set_search_regs):
1289 (Fmatch_data):
1290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1291 (wordify): Check for overflow in size calculation.
1292 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1293 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1294 Check that fixnums are in proper range for system types.
1295 * sound.c (struct sound_device)
1296 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1298 (Fplay_sound_internal):
1299 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1300 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1301 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1302 (Fparse_partial_sexp):
1303 Don't assume fixnums can fit in int.
1304 (struct lisp_parse_state, find_start_pos, find_start_value)
1305 (find_start_value_byte, find_start_begv)
1306 (update_syntax_table, char_quoted, dec_bytepos)
1307 (find_defun_start, prev_char_comend_first, back_comment):
1308 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1309 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1310 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1311 (Finternal_describe_syntax_value): Check that match_lisp is a
1312 character, not an integer, since the code stuffs it into int.
1313 (scan_words, scan_sexps_forward):
1314 Check that fixnums are in proper range for system types.
1315 (Fforward_word):
1316 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1317 (scan_sexps_forward):
1318 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1319 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1320 * syntax.h: Adjust decls to match defn changes elsewhere.
1321 (struct gl_state_s):
1322 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1323 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1324 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1325 * sysdep.c (wait_for_termination_1, wait_for_termination)
1326 (interruptible_wait_for_termination, mkdir):
1327 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1328 (emacs_read, emacs_write):
1329 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1330 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1331 and double all fit in int.
d311d28c
PE
1332 * term.c (set_tty_color_mode):
1333 Check that fixnums are in proper range for system types.
1334 * termhooks.h (struct input_event):
1335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1336 * textprop.c (validate_interval_range, interval_of)
1337 (Fadd_text_properties, set_text_properties_1)
1338 (Fremove_text_properties, Fremove_list_of_text_properties)
1339 (Ftext_property_any, Ftext_property_not_all)
1340 (copy_text_properties, text_property_list, extend_property_ranges)
1341 (verify_interval_modification):
1342 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1343 (Fnext_single_char_property_change)
1344 (Fprevious_single_char_property_change):
1345 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1346 (copy_text_properties):
1347 Check for integer overflow in index calculation.
d311d28c
PE
1348 * undo.c (last_boundary_position, record_point, record_insert)
1349 (record_delete, record_marker_adjustment, record_change)
1350 (record_property_change):
1351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1352 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1353 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1354 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1355 (Fx_hide_tip, Fx_file_dialog):
1356 * w32menu.c (set_frame_menubar):
1357 Use ptrdiff_t, not int, for consistency with rest of code.
1358 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1359 (select_window, Fdelete_other_windows_internal)
1360 (window_scroll_pixel_based, window_scroll_line_based)
1361 (Frecenter, Fset_window_configuration):
1362 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1363 (Fset_window_hscroll, run_window_configuration_change_hook)
1364 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1365 (Fscroll_other_window, Frecenter):
d311d28c
PE
1366 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1367 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1368 Don't assume fixnum fits in int.
1369 (Fset_window_scroll_bars):
1370 Check that fixnums are in proper range for system types.
1371 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1372 (string_pos, c_string_pos, number_of_chars, init_iterator)
1373 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1374 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1375 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1376 (face_before_or_after_it_pos, handle_invisible_prop)
1377 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1378 (display_prop_intangible_p, string_buffer_position_lim)
1379 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1380 (get_overlay_strings_1, get_overlay_strings)
1381 (iterate_out_of_display_property, forward_to_next_line_start)
1382 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1383 (get_next_display_element, set_iterator_to_next)
1384 (get_visually_first_element, compute_stop_pos_backwards)
1385 (handle_stop_backwards, next_element_from_buffer)
1386 (move_it_in_display_line_to, move_it_in_display_line)
1387 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1388 (add_to_log, message_dolog, message_log_check_duplicate)
1389 (message2, message2_nolog, message3, message3_nolog
1390 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1391 (current_message_1, truncate_echo_area, truncate_message_1)
1392 (set_message, set_message_1, store_mode_line_noprop)
1393 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1394 (text_outside_line_unchanged_p, check_point_in_composition)
1395 (reconsider_clip_changes)
1396 (redisplay_internal, set_cursor_from_row, try_scrolling)
1397 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1398 (redisplay_window, find_last_unchanged_at_beg_row)
1399 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1400 (trailing_whitespace_p, find_row_edges, display_line)
1401 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1402 (display_mode_element, store_mode_line_string)
1403 (pint2str, pint2hrstr, decode_mode_spec)
1404 (display_count_lines, display_string, draw_glyphs)
1405 (x_produce_glyphs, x_insert_glyphs)
1406 (rows_from_pos_range, mouse_face_from_buffer_pos)
1407 (fast_find_string_pos, mouse_face_from_string_pos)
1408 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1410 (safe_call, init_from_display_pos, handle_fontified_prop)
1411 (handle_single_display_spec, load_overlay_strings)
1412 (with_echo_area_buffer, setup_echo_area_for_printing)
1413 (display_echo_area, echo_area_display)
1414 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1415 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1416 (redisplay_window, dump_glyph_row, display_mode_line)
1417 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1418 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1419 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1420 (handle_single_display_spec, build_desired_tool_bar_string)
1421 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1422 (get_specified_cursor_type):
1423 Check that fixnums are in proper range for system types.
1424 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1425 (Flookup_image_map):
1426 Don't assume fixnums fit in int.
1427 (compare_overlay_entries):
1428 Avoid mishandling comparisons due to subtraction overflow.
1429 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1430 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1431 (handle_tool_bar_click):
1432 Use int, not unsigned, since we prefer signed and the signedness
1433 doesn't matter here.
1434 (get_next_display_element, next_element_from_display_vector):
1435 Use int, not EMACS_INT, when int is wide enough.
1436 (start_hourglass): Use duration_to_sec_usec to do proper
1437 overflow checking on durations.
1438 * xfaces.c (Fbitmap_spec_p):
1439 Check that fixnums are in proper range for system types.
1440 (compare_fonts_by_sort_order):
1441 Avoid mishandling comparisons due to subtraction overflow.
1442 (Fx_family_fonts, realize_basic_faces):
1443 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1444 (Fx_family_fonts):
1445 Don't assume fixnum fits in int.
1446 Use SAFE_ALLOCA_LISP, not alloca.
1447 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1448 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1449 (face_at_buffer_position, face_for_overlay_string)
1450 (face_at_string_position):
1451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1452 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1453 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1454 (Fx_show_tip):
1455 Check that fixnums are in proper range for system types.
1456 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1457 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1458 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1459 (Fx_change_window_property): Don't assume fixnums fit in int.
1460 * xfont.c (xfont_chars_supported):
1461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1462 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1463 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1464 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1465 * xml.c (parse_region):
1466 * xrdb.c (magic_file_p):
1467 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1468 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1469 (x_get_local_selection, x_reply_selection_request)
1470 (x_handle_selection_request, wait_for_property_change):
1471 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1472 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1473 short is wide enough.
1474 (x_send_client_event): Don't assume fixnum fits in int.
1475 * xterm.c (x_x_to_emacs_modifiers):
1476 Don't assume EMACS_INT overflows nicely into int.
1477 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1478 may come from Lisp.
1479 (handle_one_xevent): NATNUMP can eval its arg twice.
1480 (x_connection_closed):
1481 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1482 * xterm.h: Adjust decls to match defn changes elsewhere.
1483 (struct scroll_bar): Use struct vectorlike_header
1484 rather than rolling our own approximation.
1485 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1486
c6574eb5
GM
14872012-05-25 Glenn Morris <rgm@gnu.org>
1488
1489 * lisp.mk (lisp): Update for more files being compiled now.
1490
e8d32c7e
SM
14912012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1492
48def666
SM
1493 * lread.c: Remove `read_pure' which makes no difference.
1494 (read_pure): Remove var.
1495 (unreadpure): Remove function.
1496 (readevalloop): Don't call read_list with -1 flag.
1497 (read1, read_vector): Don't test read_pure any more.
1498 (read_list): Simplify.
1499
e8d32c7e
SM
1500 * fileio.c, character.h: Minor style tweaks.
1501
4b2addb7
DA
15022012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1503
1504 * window.h (clip_changed): Remove useless declaration.
1505
584461b2
JB
15062012-05-22 Juanma Barranquero <lekktu@gmail.com>
1507
1508 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1509 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1510
34374650
PE
15112012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1512
1513 Remove src/m/*.
1514 This directory predates autoconf and is no longer needed nowadays.
1515 Move its few remaining bits of functionality to where they're needed.
1516 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1517 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1518 * m/template.h: Remove.
1519 * Makefile.in (M_FILE): Remove. All uses removed.
1520 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1521 * lisp.h (USE_LSB_TAG):
1522 * mem-limits.h (EXCEEDS_LISP_PTR):
1523 Use VAL_MAX, not VALBITS, in #if.
1524 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1525 (EMACS_UINT): Define unconditionally now.
1526 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1527 (BITS_PER_EMACS_INT): New constants, replacing
1528 what used to be in config.h, but not useful in #if.
1529 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1530 define them any more.
1531 (VAL_MAX): New macro.
1532 (VALMASK): Use it.
1533 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1534 BITS_PER_EMACS_INT, in #if.
1535 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1536 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1537 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1538 * s/ms-w32.h (DATA_START):
1539 Move here from removed file m/intel386.h.
1540 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1541 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1542
261cb4bb
PE
15432012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1544
1545 Assume C89 or later.
1546 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1547 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1548 (xrealloc):
1549 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1550 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1551 * textprop.c, tparam.c (NULL): Remove.
1552 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1553 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1554 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1555 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1556 * xterm.c (input_signal_count): Assume volatile works.
1557
ff23cd9f
KB
15582012-05-21 Ken Brown <kbrown@cornell.edu>
1559
1560 * xgselect.c (xg_select): Fix first argument in call to 'select'
1561 (bug#11508).
1562
1b170bc6
KB
15632012-05-20 Ken Brown <kbrown@cornell.edu>
1564
1565 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1566 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1567
b2f4d39f
KB
15682012-05-19 Ken Brown <kbrown@cornell.edu>
1569
1570 * xfns.c (x_in_use): Remove `static' qualifier.
1571 * xterm.h (x_in_use): Declare.
1572 * xgselect.c: Include xterm.h.
1573 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1574 and `display_arg' (bug#9754).
1575
003fdae2
PE
15762012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1577
9232a6d9
PE
1578 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1579
003fdae2
PE
1580 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1581 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1582
784b56e2
EZ
15832012-05-18 Eli Zaretskii <eliz@gnu.org>
1584
1585 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1586
1587 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1588 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1589
1590 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1591 reference to image_cache->refcount.
1592 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1593
a0a79cde
JL
15942012-05-17 Juri Linkov <juri@jurta.org>
1595
1596 * search.c (Fword_search_regexp, Fword_search_backward)
1597 (Fword_search_forward, Fword_search_backward_lax)
1598 (Fword_search_forward_lax): Move functions to isearch.el
1599 (bug#10145, bug#11381).
1600
b0572523
PE
16012012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1602
1603 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1604
9660f5fc
SM
16052012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1606
1607 * lread.c (init_obarray): Declare Qt and Qnil as special.
1608
4374de83
GM
16092012-05-14 Glenn Morris <rgm@gnu.org>
1610
1611 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1612 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1613
dc44c39a
PE
16142012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1615
078c97cb
PE
1616 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1617
dc44c39a
PE
1618 * unexaix.c: Port to more-recent AIX compilers.
1619 (report_error, report_error_1, make_hdr, copy_sym)
1620 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1621 Make arguments const char *, not char *, to avoid violations of C
1622 standard and to fix some AIX warnings reported by Gilles Pion.
1623
e18afed7 16242012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1625
1626 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1627 already have overlays loaded.
1628 (handle_single_display_spec): Before returning without displaying
1629 fringe bitmap, synchronize the bidi iterator with the main display
1630 iterator, by calling iterate_out_of_display_property.
1631 (iterate_out_of_display_property): Detect buffer iteration by
1632 testing that it->string is a Lisp string.
1633 (get_next_display_element): When the current object is exhausted,
1634 and there's something on it->stack, call set_iterator_to_next to
1635 proceed with what's on the stack, instead of returning zero.
1636 (set_iterator_to_next): If called at the end of a Lisp string,
1637 proceed to consider_string_end without incrementing string
1638 position. Don't increment display vector index past the end of
1639 the display vector. (Bug#11417)
c8fb9dc6
EZ
1640 (pos_visible_p): Don't report a position visible when move_it_to
1641 stopped at the last line of window, which happens to be scanned
1642 backwards by the bidi iteration. (Bug#11464)
ac268e67 1643
e18afed7 16442012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1645
1646 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1647 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1648 are on a TTY, and thus unable to display on the fringes.
1649 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1650 so we need to signal to the caller that this is a "replacing"
1651 display spec. This fixes display when the spec is invalid or we
1652 are on a TTY.
1653
e18afed7 16542012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1655
1656 * unexaix.c (make_hdr): Fix typo in prototype.
1657 This bug broke the build on AIX. Problem reported by Gilles Pion.
1658
9d0a235a
MA
16592012-05-14 Michael Albinus <michael.albinus@gmx.de>
1660
1661 * keyboard.c (kbd_buffer_get_event): Read special events also in
1662 batch mode. (Bug#11415)
1663
9e6b06ed
GM
16642012-05-12 Glenn Morris <rgm@gnu.org>
1665
1666 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1667
c1a1d7a3
EZ
16682012-05-12 Eli Zaretskii <eliz@gnu.org>
1669
1670 * lisp.mk (lisp): Add newcomment.elc.
1671
3fe7cdc8
GM
16722012-05-12 Glenn Morris <rgm@gnu.org>
1673
1674 * Makefile.in (MKDIR_P): New, set by configure.
1675 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1676
53f7d2c0
PE
16772012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1678
1679 Remove unused function hourglass_started.
1680 * dispextern.h (hourglass_started):
1681 * w32fns.c (hourglass_started):
1682 * xdisp.c (hourglass_started): Remove.
1683
75aafb17
JB
16842012-05-10 Juanma Barranquero <lekktu@gmail.com>
1685
1686 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1687 Update dependencies.
1688
12959e8e
PE
16892012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1690
97107e2e
PE
1691 * xgselect.c (xg_select): Put maxfds+1 into a var.
1692 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1693
12959e8e
PE
1694 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1695
836d29b3
DA
16962012-05-10 Dave Abrahams <dave@boostpro.com>
1697
1698 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1699 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1700
5cb67954
MA
17012012-05-09 Michael Albinus <michael.albinus@gmx.de>
1702
1703 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1704 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1705 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1706 Initialize xd_registered_buses.
1707
3478ec45
PE
17082012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1709
b263a6b0
PE
1710 Untag more efficiently if USE_LSB_TAG.
1711 This is based on a proposal by YAMAMOTO Mitsuharu in
1712 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1713 For an admittedly artificial (nth 8000 longlist) benchmark on
1714 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1715 Emacs's overall text size by 1%.
1716 * lisp.h (XUNTAG): New macro.
1717 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1718 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1719 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1720 * eval.c (Fautoload):
1721 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1722 * frame.h (XFRAME): Use XUNTAG.
1723
3478ec45
PE
1724 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1725 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1726 Remove unportable assumptions about print widths of types like
1727 dbus_uint32_t.
1728 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1729 intptr_t when converting between pointer and integer, to avoid GCC
1730 warnings about wrong width.
1731
666b903b 17322012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1733
1734 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1735 stack for each reader_thread, instead of defaulting to 8MB
1736 determined by the linker. This avoids failures in creating
1737 subprocesses on Windows 7, see the discussion in this thread:
1738 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1739
b120cc17
JC
17402012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1741
1742 Fix up display of the *Minibuf-0* buffer in the mini window.
1743 * keyboard.c (read_char): Don't clear the echo area if there's no
1744 message to clear.
1745 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1746 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1747
9a4b36f8
MA
17482012-05-07 Michael Albinus <michael.albinus@gmx.de>
1749
1750 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1751 batch mode.
1752
e5f9458f
CY
17532012-05-06 Chong Yidong <cyd@gnu.org>
1754
1755 * lisp.mk (lisp): Update.
1756
eceeb5fc 17572012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1758
1759 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1760
71873e2b
SM
17612012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1762
1763 * data.c (PUT_ERROR): New macro.
1764 (syms_of_data): Use it. Add new error type `user-error'.
1765 * undo.c (user_error): New function.
1766 (Fprimitive_undo): Use it.
1767 * print.c (print_error_message): Adjust print style for `user-error'.
1768 * keyboard.c (user_error): New function.
1769 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1770
ab0fa4e4
PE
17712012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1772
1773 Do not limit current-time-string to years 1000..9999.
1774 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1775 (Fcurrent_time_string): Support any year that is supported by the
1776 underlying localtime representation. Don't use asctime, as it
1777 has undefined behavior for years outside the range -999..9999.
1778
7ed806a7
PE
17792012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1780
1781 Fix race conditions involving setenv, gmtime, localtime, asctime.
1782 Without this fix, interrupts could mess up code that uses these
1783 nonreentrant functions, since setting TZ invalidates existing
1784 tm_zone or tzname values, and since most of these functions return
1785 pointers to static storage.
1786 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1787 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1788 Grow the critical sections to include not just invoking
1789 localtime/gmtime, but also accessing these functions' results
1790 including their tm_zone values if any, and any related TZ setting.
1791 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1792 so that the struct tm is saved in the critical section.
1793 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1794 motivated by the fact that memory allocation needs to be outside
1795 the critical section.
1796
0c16dfed
DA
17972012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1798
1799 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1800 with RESET_INTERVAL.
1801
1802 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1803 Remove duplicated buffer name initialization.
1804
3f83ace8
JM
18052012-05-02 Jim Meyering <jim@meyering.net>
1806
1807 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1808
c7b8541e
JM
1809 * xfns.c (x_window): Use xstrdup (Bug#11375).
1810
90207a15 18112012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1812
1813 * xdisp.c (pos_visible_p): If already at a newline from the
1814 display string before the 'while' loop, don't walk back the glyphs
1815 from it3.glyph_row. Solves assertion violation when the display
1816 string begins with a newline (egg.el). (Bug#11367)
1817
b593d6a9
AH
18182012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1819
1820 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1821 Move to simple.el.
1822
4737362e
GM
18232012-05-01 Glenn Morris <rgm@gnu.org>
1824
99cf43f9
GM
1825 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1826 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1827 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1828 All were removed before 23.1.
1829
9311dcff
GM
1830 * dispnew.c: Remove HAVE_LIBNCURSES test;
1831 it is always true on relevant platforms.
1832
4d5c6349
GM
1833 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1834 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1835
4737362e
GM
1836 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1837
74dd3a6b
AS
18382012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1839
1840 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1841 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1842 Remove.
1843
13c379ee
PE
18442012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1845
1846 Do not avoid creating empty evaporating overlays (Bug#9642).
1847 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1848 That is, do not delete an evaporating overlay if it becomes
1849 empty after its bounds are adjusted to fit within its buffer.
1850 This fix caused other problems, and I'm reverting it until we get
1851 to the bottom of them.
1852
a8e7d6d7 18532012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1854
1855 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1856
a8e7d6d7 18572012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1858
1859 * xdisp.c (pos_visible_p): If the window start position is beyond
1860 ZV, start the display from buffer beginning. Prevents assertion
1861 violation in init_iterator when the minibuffer window is scrolled
1862 via the scroll bar.
1863
1864 * window.c (window_scroll_pixel_based): Likewise.
1865
a8e7d6d7 18662012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1867
1868 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1869
a8e7d6d7 18702012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1871
1872 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1873 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1874
a8e7d6d7 18752012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1876
b593d6a9
AH
1877 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1878 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1879
1c6900d9
EZ
18802012-04-26 Eli Zaretskii <eliz@gnu.org>
1881
4c3fa1d9
EZ
1882 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1883 display element, check also the underlying string or buffer
1884 character. (Bug#11341)
1885
1c6900d9
EZ
1886 * w32menu.c: Include w32heap.h.
1887 (add_menu_item): If the call to AppendMenuW (via
1888 unicode_append_menu) fails, disable Unicode menus only if we are
1889 running on Windows 9X/Me.
1890
42bf8205
AS
18912012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1892
1893 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1894 (xgetint): Add missing shift for LSB tags.
1895
b1bac16e
MR
18962012-04-24 Martin Rudalics <rudalics@gmx.at>
1897
1898 * keyboard.c (read_char): Don't wipe echo area for select window
1899 events: These might get delayed via `mouse-autoselect-window'
1900 (Bug#11304).
1901
d69621cc
JB
19022012-04-24 Juanma Barranquero <lekktu@gmail.com>
1903
1904 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1905 manipulation of :loaded-from data.
1906
02fd101b
JB
19072012-04-23 Juanma Barranquero <lekktu@gmail.com>
1908
1909 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1910 now a cons (bug#11311).
1911
888bec30
PE
19122012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1913
89a438bd
PE
1914 Do not create empty overlays with the evaporate property (Bug#9642).
1915 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1916 if it becomes empty after its bounds are adjusted to fit within
1917 its buffer. Without this fix, in a nonempty buffer (let ((o
1918 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1919 yields an empty overlay that has the evaporate property, which is
1920 not supposed to happen.
1921
1068fe4d
PE
1922 Fix minor GTK3 problems found by static checking.
1923 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1924 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1925 (struct _EmacsFixedClass, emacs_fixed_get_type):
1926 Move decls here from emacsgtkfixed.h, since they needn't be public.
1927 (emacs_fixed_get_type): Now static.
1928 (emacs_fixed_class_init): Omit unused local.
1929 (emacs_fixed_child_type): Remove; unused.
1930 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1931 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1932 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1933 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1934 (EMACS_FIXED_GET_CLASS): Remove; unused.
1935 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1936
888bec30
PE
1937 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1938 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1939
de85e130
PE
19402012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1941
d0baac98 1942 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1943 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1944 (__malloc_size_t, __malloc_ptrdiff_t):
1945 Remove. All uses removed, replaced by the definiens if needed,
1946 since we can assume C89 or better now.
1947 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1948 (protect_malloc_state, align, get_contiguous_space)
1949 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1950 (malloc_atfork_handler_child, malloc_enable_thread)
1951 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1952 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1953 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1954 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1955 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1956 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1957 Define using prototypes, not old style.
1958 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1959 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1960 (align): Don't assume that signed integer overflow wraps around.
1961 Omit unused local var.
1962 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1963 (_free_internal_nolock, memalign, mallochook, reallochook):
1964 Omit no-longer-needed casts.
1965 (valloc): Use getpagesize, not __getpagesize.
1966 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1967 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1968
de85e130
PE
1969 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1970
dcbf5805
MA
19712012-04-22 Michael Albinus <michael.albinus@gmx.de>
1972
1973 Move functions from C to Lisp. Make non-blocking method calls
1974 the default. Implement further D-Bus standard interfaces.
1975
1976 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1977 (QCdbus_request_name_allow_replacement)
1978 (QCdbus_request_name_replace_existing)
1979 (QCdbus_request_name_do_not_queue)
1980 (QCdbus_request_name_reply_primary_owner)
1981 (QCdbus_request_name_reply_in_queue)
1982 (QCdbus_request_name_reply_exists)
1983 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1984 (QCdbus_registered_serial, QCdbus_registered_method)
1985 (QCdbus_registered_signal): New Lisp objects.
1986 (XD_DEBUG_MESSAGE): Use sizeof.
1987 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1988 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1989 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1990 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1991 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1992 (xd_signature, xd_append_arg): Allow float for integer types.
1993 (xd_get_connection_references): New function.
b593d6a9
AH
1994 (xd_get_connection_address): Rename from xd_initialize.
1995 Return cached address.
dcbf5805
MA
1996 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1997 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1998 level.
1999 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2000 Return number of refcounts.
dcbf5805
MA
2001 (Fdbus_get_unique_name): Make stronger parameter check.
2002 (Fdbus_message_internal): New defun.
2003 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2004 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2005 (Fdbus_send_signal, Fdbus_register_service)
2006 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2007 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2008 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2009 (Vdbus_compiled_version, Vdbus_runtime_version)
2010 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2011 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2012 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2013 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2014 Adapt docstring.
dcbf5805 2015
52828e02
PE
20162012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2017
da05bc4c
PE
2018 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2019 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2020 Do not assume ptrdiff_t is the same width as 'int'.
2021
52828e02
PE
2022 * alloc.c: Handle unusual debugging option combinations.
2023 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2024 since the two debugging options are incompatible.
2025 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2026 is defined.
2027 (mem_init, mem_insert, mem_insert_fixup):
2028 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2029 (NEED_MEM_INSERT): Remove; no longer needed.
2030
f01769f9
LL
20312012-04-22 Leo Liu <sdl.web@gmail.com>
2032
2033 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2034
5790543d
PE
20352012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2036
2037 * sysdep.c [__FreeBSD__]: Minor cleanups.
2038 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2039 Use Emacs indenting style more consistently. Avoid some casts.
2040 Use 'double' consistently rather than mixing 'float' and 'double'.
2041
b91b7e4d
EW
20422012-04-21 Eduard Wiebe <usenet@pusto.de>
2043
b593d6a9
AH
2044 * sysdep.c (list_system_processes, system_process_attributes):
2045 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2046
6114eb15
AS
20472012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2048
2049 * lisp.mk (lisp): Update.
2050
2f38dff7
PE
20512012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2052
2053 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2054 It is never used otherwise.
2055
4ae29f89
SM
20562012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2057
2058 * print.c (print_preprocess): Only check print_depth if print-circle
2059 is nil.
2060 (print_object): Check for cycles even when print-circle is nil and
2061 print-gensym is t, but only check print_depth if print-circle is nil.
2062
f30d612a
CY
20632012-04-20 Chong Yidong <cyd@gnu.org>
2064
2065 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2066 set the status to "failed" and ensure that sentinel is run.
2067
c07a4c0b 20682012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2069
2070 * process.c (Fset_process_inherit_coding_system_flag)
2071 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2072 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2073
c07a4c0b 20742012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2075
2076 * xdisp.c (string_buffer_position_lim): Limit starting position to
2077 BEGV.
2078 (set_cursor_from_row): If called for a mode-line or header-line
2079 row, return zero immediately.
2080 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2081 farther than the first row after the header line, if any.
2082 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2083 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2084
c07a4c0b 20852012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2086
4ae29f89
SM
2087 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2088 (bug#11238).
ad3a2b41 2089
c07a4c0b 20902012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 20912012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2092
2093 configure: new option --enable-gcc-warnings (Bug#11207)
2094 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2095 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2096 (ALL_CFLAGS): Use new macros rather than old.
2097 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2098 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2099 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2100 -Wunused-result, -Wunused-variable. This should go away once
2101 the Emacs and Gnulib regex code is merged.
2102 (xmalloc, xrealloc): Now static.
2103
aba027e8
PE
21042012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2105
2106 * dired.c (Fsystem_groups): Remove unused local.
2107
e5a36063
GM
21082012-04-17 Glenn Morris <rgm@gnu.org>
2109
2110 * dired.c (Fsystem_users): Doc fix.
2111
316411f0
DA
21122012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2113
2114 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2115 (syms_of_dired): Add them.
2116
9426aba4
PE
21172012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2118
b62a57be
PE
2119 Fix minor alloc.c problems found by static checking.
2120 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2121 New extern decls, to avoid calling undeclared functions.
2122 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2123 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2124 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2125 (NEED_MEM_INSERT): New macro.
2126 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2127 Remove one incorrect comment and fix another.
b62a57be 2128
3539f31f
PE
2129 Fix minor ralloc.c problems found by static checking.
2130 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2131 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2132 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2133 (r_alloc_sbrk): Now static.
2134
a041960a
PE
2135 Improve ralloc.c interface checking.
2136 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2137 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2138 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2139 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2140 [REL_ALLOC]: ... to here, to check interface.
2141 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2142 Remove decls. This fixes an "It stinks!".
2143
9426aba4
PE
2144 * alloc.c (which_symbols): Fix alignment issue / type clash.
2145
d55c12ed
AS
21462012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2147
2148 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2149 (struct Lisp_Misc_Any): Likewise.
2150 (struct Lisp_Free): Likewise.
2151 * alloc.c (union aligned_Lisp_Symbol): Define.
2152 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2153 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2154 (union aligned_Lisp_Misc): Define.
2155 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2156 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2157 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2158
b948ce8b
PE
21592012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2160
2161 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2162 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2163 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2164 * s/netbsd.h, s/sol2-6.h:
2165 Remove definition of GC_MARK_STACK, since the default now works.
2166 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2167 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2168 no longer the default.
2169 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2170
35dc09a1 21712012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2172
35dc09a1
GM
2173 * lread.c (lisp_file_lexically_bound_p):
2174 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2175
35dc09a1
GM
21762012-04-14 Eli Zaretskii <eliz@gnu.org>
2177
2178 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2179 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2180
21812012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2182
2183 * nsterm.m (constrainFrameRect): Always constrain when there is only
2184 one screen (Bug#10962).
2185
bcd86815
KB
21862012-04-13 Ken Brown <kbrown@cornell.edu>
2187
2188 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2189
c25df26e
RT
21902012-04-13 Reuben Thomas <rrt@sc3d.org>
2191
2192 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2193
0fc59f1e
DC
21942012-04-11 Daniel Colascione <dancol@dancol.org>
2195
2196 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2197 against is gone. It's better to use vfork now so that when Cygwin
2198 gains a new, working vfork, we use it automatically (bug#10398).
2199
de8c03dc
SM
22002012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2201
2202 * window.c (save_window_save): Obey window-point-insertion-type.
2203
2f097256
GM
22042012-04-11 Glenn Morris <rgm@gnu.org>
2205
2206 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2207
453b951e
SM
22082012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2209
2210 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2211
75f1671a 22122012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2213
2214 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2215 (force_quit_count): New var.
2216 (handle_interrupt): Use it.
2217
2a8ce227
JB
22182012-04-10 Juanma Barranquero <lekktu@gmail.com>
2219
2220 * w32.c (w32_delayed_load): Record the full path of the library
2221 being loaded (bug#10424).
2222
935396c0
GM
22232012-04-09 Glenn Morris <rgm@gnu.org>
2224
05920a43
GM
2225 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2226 not just in the obarray, before snarfing them. (Bug#11036)
2227
935396c0
GM
2228 * Makefile.in ($(leimdir)/leim-list.el):
2229 Pass EMACS rather than BUILT_EMACS.
2230
a18ecafa
TZ
22312012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2232
2233 * process.c (make_process):
2234 * process.h: Add integer `gnutls_handshakes_tried' member to
2235 process struct.
2236
6bbef4e5
JC
2237 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2238 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2239
2240 * gnutls.c (gnutls_log_function2i): Convenience log function.
2241 (emacs_gnutls_read): Use new log functions,
2242 `gnutls_handshakes_tried' process member, and
2243 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2244 attempts per process (connection).
2245
b4d3bc10
CY
22462012-04-09 Chong Yidong <cyd@gnu.org>
2247
2248 * eval.c (Fuser_variable_p, user_variable_p_eh)
2249 (lisp_indirect_variable): Functions deleted.
2250 (Fdefvar): Caller changed.
2251
2252 * callint.c (Finteractive, Fcall_interactively):
2253 * minibuf.c (Fread_variable): Callers changed.
2254
70f4d973
EZ
22552012-04-09 Eli Zaretskii <eliz@gnu.org>
2256
2257 * xdisp.c (set_cursor_from_row): If the display string appears in
2258 the buffer at position that is closer to point than the position
2259 after the display string, display the cursor on the first glyph of
2260 the display string. Fixes cursor display when a 'display' text
2261 property immediately follows invisible text. (Bug#11094)
2262
cb3c2e3e
PE
22632012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2264
2265 composite.c: use 'double' consistently
2266 * composite.c (get_composition_id): Use 'double' consistently
2267 instead of converting 'float' to 'double' and vice versa; this is
2268 easier to understand and avoids a GCC warning.
2269
fd06db5d
GM
22702012-04-09 Glenn Morris <rgm@gnu.org>
2271
50fe702a
GM
2272 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2273 preparation for dumping it with emacs. (Bug#4789)
2274 (leimdir): New variable.
2275 ($(leimdir)/leim-list.el): New rule.
2276 (emacs$(EXEEXT)): Depend on leim-list.el.
2277
fd06db5d
GM
2278 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2279 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2280 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2281
55c131ee
AS
22822012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2283
2284 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2285 proper alignment.
2286
9209588f
JB
22872012-04-07 Juanma Barranquero <lekktu@gmail.com>
2288
2289 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2290 Remove unused local variable.
2291
e3fb2efb
PE
22922012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2293
2294 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2295 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2296 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2297 objects, as mark_maybe_pointer will catch them otherwise.
2298 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2299 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2300
b5385551
PE
23012012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2302
2303 Fix typo that broke non-Windows builds.
2304 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2305
9078ead6
EZ
23062012-04-07 Eli Zaretskii <eliz@gnu.org>
2307
2308 Support building on MS-Windows with libxml2.
2309
2310 * makefile.w32-in (OBJ2): Add xml.$(O).
2311 (GLOBAL_SOURCES): Add xml.c.
2312 ($(BLD)/xml.$(O)): New dependency list.
2313
2314 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2315 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2316 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2317 [!WINDOWSNT]: New macros.
2318 (init_libxml2_functions, libxml2_loaded_p): New functions.
2319 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2320 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2321 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2322 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2323 linked in).
6bbef4e5
JC
2324 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2325 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2326 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2327
2328 * emacs.c: Don't include libxml/parser.h.
2329 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2330 xmlCleanupParser directly.
2331
2332 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2333
3811fdf3
EZ
23342012-04-07 Eli Zaretskii <eliz@gnu.org>
2335
2336 * indent.c (Fvertical_motion): If there is a display string at
2337 point, use it.vpos to compute how many lines to backtrack after
2338 move_it_to point. (Bug#11133)
2339
2f8e16b2
EZ
23402012-04-06 Eli Zaretskii <eliz@gnu.org>
2341
2342 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2343 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2344 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2345 macros related to unification of CJK characters. For the details,
2346 see the discussion following the message here:
2347 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2348
3d439cd1
CY
23492012-04-04 Chong Yidong <cyd@gnu.org>
2350
2351 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2352
8bc53d00
EZ
23532012-04-01 Eli Zaretskii <eliz@gnu.org>
2354
2355 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2356 instead of alloca. (Bug#11138)
2357
3b0512a3
AS
23582012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2359
2360 * w32menu.c (is_simple_dialog): Properly check lisp types.
2361 (Bug#11141)
2362
8427ddd2
EZ
23632012-03-31 Eli Zaretskii <eliz@gnu.org>
2364
979022ef
EZ
2365 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2366 position we get to after a call to move_it_to fails the
2367 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2368 only if we wind up in a string from display property. (Bug#11063)
2369
a6b1c7cc
EZ
2370 * window.c (Fdelete_other_windows_internal): Invalidate the row
2371 and column information about mouse highlight, so that redisplay
2372 restores it after reallocating the glyph matrices. (Bug#7464)
2373
8427ddd2
EZ
2374 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2375 string comes from a `display' text property, use the buffer
2376 position of that property as if we actually saw that position in
2377 the row's glyphs.
697ba24b
EZ
2378 (move_it_by_lines): Remove the assertion that
2379 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2380 violated when there's a before-string at the beginning of a line.
2381 (Bug#11063)
8427ddd2 2382
65a0a738
EZ
23832012-03-30 Eli Zaretskii <eliz@gnu.org>
2384
2385 * xdisp.c (append_space_for_newline): If the default face was
2386 remapped, use the remapped face for the appended newline.
2387 (extend_face_to_end_of_line): Use the remapped default face for
2388 extending the face to the end of the line.
2389 (display_line): Call extend_face_to_end_of_line when the default
2390 face was remapped. (Bug#11068)
2391
581355cc
EZ
23922012-03-29 Eli Zaretskii <eliz@gnu.org>
2393
2394 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2395
e8fc049f
SM
23962012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2397
2398 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2399
4fb9a543
GM
24002012-03-27 Glenn Morris <rgm@gnu.org>
2401
2402 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2403 Doc fixes.
2404
679910f1
KH
24052012-03-26 Kenichi Handa <handa@m17n.org>
2406
2407 * dispextern.h (struct glyph): Fix previous change. Change the
2408 bit length of glyphless.ch to 25 (Bug#11082).
2409
90d49b7f
CY
24102012-03-26 Chong Yidong <cyd@gnu.org>
2411
2412 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2413 (command_loop_1): Use it; inhibit selection update for
2414 handle-select-window too (Bug#8996).
2415
f514f6f0
FP
24162012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2417
e8fc049f 2418 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2419
bf43fa51
KH
24202012-03-25 Kenichi Handa <handa@m17n.org>
2421
2422 * dispextern.h (struct glyph): Change the bit length of
2423 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2424
8a0c01dd
EZ
24252012-03-24 Eli Zaretskii <eliz@gnu.org>
2426
2427 * s/ms-w32.h (tzname): Include time.h before redirecting to
2428 _tzname. Fixes the MSVC build. (Bug#9960)
2429
7d1c3a76
AS
24302012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2431
8ed79523
AS
2432 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2433 characters.
2434
7d1c3a76
AS
2435 * xterm.c (XTread_socket): Only modify handling_signal if
2436 !SYNC_INPUT. (Bug#11080)
2437
e99a9b8b
EZ
24382012-03-23 Eli Zaretskii <eliz@gnu.org>
2439
2440 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2441 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2442 when fetching a multibyte character consumes more bytes than
2443 CHAR_BYTES returns, due to unification of CJK characters in
2444 string_char. (Bug#11073)
2445
5063c0e1
TN
24462012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2447
2448 * process.c (wait_reading_process_output): Handle pty disconnect
2449 by refraining from sending oneself a SIGCHLD (bug#10933).
2450
9f851fbd
CY
24512012-03-22 Chong Yidong <cyd@gnu.org>
2452
2453 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2454
5063c0e1 2455 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2456 Mark string as coming from a prefix property.
2457 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2458 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2459
fb5b8aca
CY
24602012-03-21 Chong Yidong <cyd@gnu.org>
2461
2462 * xfaces.c (Vface_remapping_alist): Doc fix.
2463
62356a1b
EZ
24642012-03-20 Eli Zaretskii <eliz@gnu.org>
2465
2466 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2467 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2468 Doc fixes.
62356a1b 2469
025de85b
CY
24702012-03-20 Chong Yidong <cyd@gnu.org>
2471
2472 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2473 to reflect default non-nil value of redisplay-dont-pause.
2474
4827f94e
KH
24752012-03-19 Kenichi Handa <handa@m17n.org>
2476
2477 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2478 it fit in a valid range (Bug#11003).
2479
e50a24a2
EZ
24802012-03-18 Eli Zaretskii <eliz@gnu.org>
2481
2482 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2483 that is not from display property, accept the row as a "cursor
2484 row" if one of the string's character has a non-nil `cursor'
2485 property. Fixes cursor positioning when there are newlines in
2486 overlay strings, e.g. in icomplete.el. (Bug#11035)
2487
9af5ed87
PE
24882012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2489
2490 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2491
d1f55f16
CY
24922012-03-12 Chong Yidong <cyd@gnu.org>
2493
2494 * eval.c (inhibit_lisp_code): Rename from
2495 inhibit_window_configuration_change_hook; move from window.c.
2496
2497 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2498 * window.c (run_window_configuration_change_hook)
2499 (syms_of_window): Callers changed.
2500
66c5eebd
CY
25012012-03-11 Chong Yidong <cyd@gnu.org>
2502
413df973
CY
2503 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2504
66c5eebd
CY
2505 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2506
1de11f56
CY
25072012-03-10 Chong Yidong <cyd@gnu.org>
2508
2509 * frame.c (other_visible_frames): Don't assume the selected frame
2510 is visible (Bug#10955).
2511
cae07000
SM
25122012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2513
2514 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2515
89c94350
JD
25162012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2517
2518 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2519 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2520 zero (Bug#10954).
2521
999dd333
GM
25222012-03-03 Glenn Morris <rgm@gnu.org>
2523
01a6dcc8 2524 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2525
de0100f2
EZ
25262012-03-02 Eli Zaretskii <eliz@gnu.org>
2527
2528 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2529 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2530 (redisplay_window, next_element_from_string): Fix typos in
2531 comments.
3e441275
EZ
2532 (redisplay_window): Pass to move_it_vertically the margin in
2533 pixels, not in screen lines.
de0100f2 2534
96a72ee9
GM
25352012-03-02 Glenn Morris <rgm@gnu.org>
2536
2537 * buffer.c (buffer-list-update-hook): Doc fix.
2538
312508d7
EZ
25392012-02-29 Eli Zaretskii <eliz@gnu.org>
2540
2541 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2542 push_it before setting up the iterator for the first overlay
2543 string, even if we have an empty string loaded.
2544 (next_overlay_string): If there's an empty string on the iterator
2545 stack, pop the stack. (Bug#10903)
2546
27f3c637
PE
25472012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2548
2549 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2550 Suggested by Stefan Monnier in
2551 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2552 * alloc.c (widen_to_Lisp_Object): New static function.
2553 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2554 and widening them to Lisp_Objects. This would work even if
2555 USE_LSB_TAG is defined and wide integers are used, which might
2556 happen in a future version of Emacs.
2557
3c9dfce6
CY
25582012-02-25 Chong Yidong <cyd@gnu.org>
2559
fa74b241
CY
2560 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2561 Doc fix.
2562
3c9dfce6
CY
2563 * xselect.c (Fx_selection_exists_p): Doc fix.
2564 (x_clipboard_manager_save_all): Print an informative message
2565 before saving to clipboard manager.
2566
9486df08
CY
25672012-02-24 Chong Yidong <cyd@gnu.org>
2568
2569 * keyboard.c (process_special_events): Handle all X selection
2570 requests in kbd_buffer, not just the next one (Bug#8869).
2571
f01d3321
CY
25722012-02-23 Chong Yidong <cyd@gnu.org>
2573
2574 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2575 call when setting menu-bar-lines and tool-bar-lines parameters.
2576 (unwind_create_frame_1): New helper function.
2577
2578 * window.c (inhibit_window_configuration_change_hook): New var.
2579 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2580 (syms_of_window): Initialize it.
f01d3321 2581
86b847b6
CY
25822012-02-22 Chong Yidong <cyd@gnu.org>
2583
2584 * xterm.c (x_draw_image_relief): Add missing type check for
2585 Vtool_bar_button_margin (Bug#10743).
2586
a59225b1
CY
25872012-02-21 Chong Yidong <cyd@gnu.org>
2588
2589 * fileio.c (Vfile_name_handler_alist): Doc fix.
2590
2591 * buffer.c (Fget_file_buffer): Protect against invalid file
2592 handler return value.
2593
310f5bd4
PE
25942012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2595
cb3a28cc
PE
2596 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2597 when computing $valmask.
2598
310f5bd4
PE
2599 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2600 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2601 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2602 It's useless in that case, and it can cause problems on hosts
2603 that allocate halves of EMACS_INT values separately.
2604 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2605 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2606 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2607 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2608 it avoids undefined behavior on hosts where shifting right by more
2609 than the word width has undefined behavior.
2610
2375c96a
CY
26112012-02-19 Chong Yidong <cyd@gnu.org>
2612
2613 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2614 (Funhandled_file_name_directory, Ffile_name_as_directory)
2615 (Fdirectory_file_name, Fexpand_file_name)
2616 (Fsubstitute_in_file_name): Protect against invalid file handler
2617 return values (Bug#10845).
2618
3eb49e71
EZ
26192012-02-18 Eli Zaretskii <eliz@gnu.org>
2620
2621 * .gdbinit (pitx): Fix incorrect references to fields of the
2622 iterator stack.
2623
7b926f3f
CY
26242012-02-17 Chong Yidong <cyd@gnu.org>
2625
2626 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2627
11273115
PE
26282012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2629
2630 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2631 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2632
c3a70e2b
CY
26332012-02-15 Chong Yidong <cyd@gnu.org>
2634
2635 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2636 marked as special. Also, starting docstrings with * is obsolete.
2637
0ca43699
AS
26382012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2639
2640 * gnutls.c (emacs_gnutls_write): Fix last change.
2641
2e8f3c56
LI
26422012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2643
2644 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2645 send_process.
2646
af70074f
SM
26472012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2648
2649 * keymap.c (Fsingle_key_description): Handle char ranges.
2650
95986d52
CY
26512012-02-12 Chong Yidong <cyd@gnu.org>
2652
afd83bd1
CY
2653 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2654 as that creates a dangerous corner case.
2655
95986d52
CY
2656 * window.c (Fdelete_window_internal): Invalidate the mouse
2657 highlight (Bug#9904).
2658
bd7da63e
GM
26592012-02-12 Glenn Morris <rgm@gnu.org>
2660
2661 * xselect.c (Fx_own_selection_internal)
2662 (Fx_get_selection_internal, Fx_disown_selection_internal)
2663 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2664 * nsselect.m (Fx_own_selection_internal)
2665 (Fx_disown_selection_internal, Fx_selection_exists_p)
2666 (Fx_selection_owner_p, Fx_get_selection_internal):
2667 Sync docs and argument specs with the xselect.c versions.
2668
77abcbc2
LI
26692012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2670
2671 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2672
90b671e2
EZ
26732012-02-11 Eli Zaretskii <eliz@gnu.org>
2674
1c0ca0b7
EZ
2675 * w32select.c (Fx_selection_exists_p): Sync doc string and
2676 argument list with xselect.c. (Bug#10783)
2677
2678 * w16select.c (Fx_selection_exists_p): Sync doc string and
2679 argument list with xselect.c. (Bug#10783)
90b671e2 2680
49241268
GM
26812012-02-10 Glenn Morris <rgm@gnu.org>
2682
2683 * fns.c (Fsecure_hash): Doc fix.
2684
f998bbe7 26852012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2686
2687 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2688
0992bd9c
CY
26892012-02-07 Chong Yidong <cyd@gnu.org>
2690
2691 * buffer.c (Fbuffer_local_variables)
2692 (buffer_lisp_local_variables): Handle unbound vars correctly;
2693 don't let Qunbound leak into Lisp.
2694
af008560
GM
26952012-02-07 Glenn Morris <rgm@gnu.org>
2696
dd605cc4
GM
2697 * image.c (Fimagemagick_types): Doc fix.
2698
af008560
GM
2699 * image.c (imagemagick-render-type): Change it from a lisp object
2700 to an integer. Move the doc here from the lisp manual.
2701 Treat all values not equal to 0 the same.
2702
1449fa1d
CY
27032012-02-06 Chong Yidong <cyd@gnu.org>
2704
2705 * doc.c (store_function_docstring): Avoid applying docstring of
2706 alias to base function (Bug#2603).
2707
3723ec07
AS
27082012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2709
2710 * .gdbinit (pp1, pv1): Remove redundant defines.
2711 (pr): Use pp.
2712
79c1cc1e
CY
27132012-02-04 Chong Yidong <cyd@gnu.org>
2714
2715 * nsterm.m: Declare a global (Bug#10694).
2716
d7f29f8e
EZ
27172012-02-04 Eli Zaretskii <eliz@gnu.org>
2718
cae07000
SM
2719 * w32.c (get_emacs_configuration_options):
2720 Include --enable-checking, if specified, in the return value.
d7f29f8e 2721
3b95a6f9
MR
27222012-02-04 Martin Rudalics <rudalics@gmx.at>
2723
2724 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2725 after rounding frame sizes. (Bug#9723)
2726
d6fa96a6
EZ
27272012-02-04 Eli Zaretskii <eliz@gnu.org>
2728
2729 * keyboard.c (adjust_point_for_property): Don't position point
2730 before BEGV. (Bug#10696)
2731
df0b2940
PE
27322012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2733
2734 Handle overflow when computing char display width (Bug#9496).
2735 * character.c (char_width): Return EMACS_INT, not int.
2736 (char_width, c_string_width): Check for overflow when
2737 computing the width; this is possible now that individual
2738 characters can have unbounded width. Problem introduced
2739 by merge from Emacs 23 on 2012-01-19.
2740
6bee44d6
MA
27412012-02-02 Michael Albinus <michael.albinus@gmx.de>
2742
2743 * dbusbind.c (Fdbus_register_method): Mention the return value
2744 :ignore in the docstring.
2745
44f92739
GM
27462012-02-02 Glenn Morris <rgm@gnu.org>
2747
1b9f60cc
GM
2748 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2749
44f92739
GM
2750 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2751 Unconditionally set to t. (Bug#10673)
2752 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2753 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2754 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2755
c5d3843c
KH
27562012-02-02 Kenichi Handa <handa@m17n.org>
2757
2758 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2759 0, do not call append_composite_glyph.
2760
159462d4 27612012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2762
2763 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2764 NULL (Bug#6988).
2765 (x_produce_glyphs): If the component of a composition is a null
2766 string, set it->pixel_width to 1 to avoid zero-width glyph.
2767
78cef877
EZ
27682012-02-01 Eli Zaretskii <eliz@gnu.org>
2769
2770 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2771 first 2 arguments are identical. This makes inserting large
2772 output from a subprocess an order of magnitude faster on
2773 MS-Windows, where all sbrk'ed memory is always contiguous.
2774
97897668
GM
27752012-01-31 Glenn Morris <rgm@gnu.org>
2776
2777 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2778 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2779 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2780
31fd3586
GM
27812012-01-29 Glenn Morris <rgm@gnu.org>
2782
2783 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2784
0e24a8b2
CY
27852012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2786
2787 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2788
cc0adcb0
CY
27892012-01-28 Chong Yidong <cyd@gnu.org>
2790
2791 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2792
acc28cb9
CY
27932012-01-26 Chong Yidong <cyd@gnu.org>
2794
9c69cfb7
CY
2795 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2796
acc28cb9
CY
2797 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2798 repeat counts (Bug#10507).
2799
48da7392
GM
28002012-01-26 Glenn Morris <rgm@gnu.org>
2801
2802 * lread.c (syms_of_lread): Doc fix.
2803
14af5f7f
CY
28042012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2805
2806 * coding.c (encode_designation_at_bol): Change return value to
2807 EMACS_INT.
2808
0b21c100
CY
28092012-01-25 Chong Yidong <cyd@gnu.org>
2810
2811 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2812
3c2907f7
CY
28132012-01-21 Chong Yidong <cyd@gnu.org>
2814
2815 * floatfns.c (Fcopysign): Make the second argument non-optional,
2816 since nil is not allowed anyway.
2817
959ad23f
AS
28182012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2819
2820 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2821 (send_process): Likewise.
2822
34a02f46
MR
28232012-01-19 Martin Rudalics <rudalics@gmx.at>
2824
2825 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2826 (Vwindow_persistent_parameters): Do not use Qstate.
2827 Rewrite doc-strings.
34a02f46 2828
1259009a 28292012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2830
2831 * character.c (char_width): New function.
70d4fdf6
GM
2832 (Fchar_width, c_string_width, lisp_string_width):
2833 Use char_width (Bug#9496).
25ed9e61 2834
6a6ee00d
MR
28352012-01-16 Martin Rudalics <rudalics@gmx.at>
2836
2837 * window.c (Vwindow_persistent_parameters): New variable.
2838 (Fset_window_configuration, save_window_save): Handle persistent
2839 window parameters.
2840
c85efaf7
EZ
28412012-01-14 Eli Zaretskii <eliz@gnu.org>
2842
2843 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2844 thrashing the stack of the thread. (Bug#9087)
2845
5944709e
PE
28462012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2847
2848 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2849
e71f5d99
EZ
28502012-01-11 Eli Zaretskii <eliz@gnu.org>
2851
2852 * xdisp.c (rows_from_pos_range): Handle the case where the
2853 highlight ends on a newline. (Bug#10464)
2854 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2855 he end column for display of highlight that ends on a newline
2856 before a R2L line.
2857
ce316182
GM
28582012-01-11 Glenn Morris <rgm@gnu.org>
2859
2860 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2861 from load-path also when installation-directory is nil. (Bug#10208)
2862
5b43da69
GM
28632012-01-10 Glenn Morris <rgm@gnu.org>
2864
74cc8ff9
GM
2865 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2866
7d8d6e4e
GM
2867 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2868 Update template values to be closer to their typical values these days.
5b43da69 2869
a0db8d43
EZ
28702012-01-09 Eli Zaretskii <eliz@gnu.org>
2871
2872 * xdisp.c (rows_from_pos_range): Accept additional argument
2873 DISP_STRING, and accept any glyph in a row whose object is that
2874 string as eligible for mouse highlight. Fixes mouse highlight of
2875 display strings from overlays. (Bug#10464)
2876
9a0115ab 28772012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2878
b9110d6a 2879 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2880 * fileio.c (auto_saving_dir_umask): New static var.
2881 (Fmake_directory_internal): Use it.
2882 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2883 creating the directory. The old code temporarily assigns
2884 too-generous permissions to the directory.
2885 (do_auto_save_eh): Clear it.
b9110d6a 2886 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2887 that the var is always cleared.
2888
6c1bd3f3
EZ
28892012-01-07 Eli Zaretskii <eliz@gnu.org>
2890
2891 * search.c (scan_buffer): Pass character positions to
2892 know_region_cache, not byte positions. (Bug#6540)
2893
069d2b50
L
28942012-01-07 LynX <_LynX@bk.ru> (tiny change)
2895
2896 * w32.c (sys_rename): Report EXDEV when rename of a directory
2897 fails because the target is on another logical disk. (Bug#10284)
2898
75bf0d33
DB
28992012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2900
2901 * xterm.c (x_embed_request_focus): New function.
2902
2903 * xterm.h: Add prototype.
2904
2905 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2906
1c6e5a32
GM
29072012-01-05 Glenn Morris <rgm@gnu.org>
2908
2909 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2910
651e947e
EZ
29112012-01-01 Eli Zaretskii <eliz@gnu.org>
2912
2913 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2914 Load gnutls_transport_set_lowat only if GnuTLS version is below
2915 2.11.1.
2916 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2917 GnuTLS versions below 2.11.1.
2918
3778cdd8
AL
29192011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2920
2921 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2922 to the doc string advising against its use for altering the way
2923 windows are scrolled.
2924
0e5317f7
KH
29252011-12-28 Kenichi Handa <handa@m17n.org>
2926
2927 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2928 coding-system ASCII compatible only when it does not produce BOM
2929 on encoding (Bug#10383).
2930
93d5ca1f
JD
29312011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2932
2933 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2934 can scroll.
2935 (create_and_show_popup_menu): Always use menu_position_func for
2936 Gtk3 (Bug#10361).
2937
ca22b785
AS
29382011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2939
2940 * callint.c (Fcall_interactively): Don't truncate prompt string.
2941
d048e1e6
EZ
29422011-12-23 Eli Zaretskii <eliz@gnu.org>
2943
2944 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2945 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2946 resumed from there (after widening). (Bug#10360)
d048e1e6 2947
5ccaba1f
JD
29482011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2949
2950 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2951
204ee57f
JD
29522011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2953
b81d40f0
JB
2954 * nsterm.m (x_free_frame_resources):
2955 Release f->output_data.ns->miniimage.
204ee57f
JD
2956 (ns_index_color): Fix indentation. Do not retain
2957 color_table->colors[i].
2958
2959 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2960 before returning.
2961
2962 * nsfns.m (x_set_background_color): Assign return value from
2963 ns_index_color to face-background instead of NSColor*.
2964 (ns_implicitly_set_icon_type): Fix indentation.
2965 Change assignment in for loop to comparison.
2966
2967 * emacs.c (ns_pool): New variable.
2968 (main): Assign ns_pool.
2969 (Fkill_emacs): Call ns_release_autorelease_pool.
2970
2971 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2972 autorelease fdesc, release fdAttrs and tdict.
2973 (ns_get_covering_families): Release charset.
2974 (ns_findfonts): Release NSFontDescriptor created with new.
2975 (ns_uni_to_glyphs): Fix indentation.
2976 (setString): Release attrStr before assigning new value.
2977
c803b2b7
JD
29782011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2979
678f4426
JD
2980 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2981 and NS_IMPL_COCOA.
2982 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2983 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2984
cd394be1 29852011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2986
5fecd5fc
JD
2987 * nsterm.m (ns_term_init): Subscribe for notifications
2988 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2989 to method trackingNotification in EmacsMenu.
2990
2991 * nsmenu.m (trackingMenu): New variable.
3771cb17 2992 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2993 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2994 from Aquamacs (Bug#7030).
678f4426
JD
2995
29962011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2997
c803b2b7
JD
2998 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2999 (symbol_to_nsstring): Fix indentation.
3000 (ns_symbol_to_pb): New function.
cae07000
SM
3001 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3002 (Fns_rotate_cut_buffers_internal): Remove.
3003 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3004 Fns_store_cut_buffer_internal.
3005 (ns_get_foreign_selection, Fx_own_selection_internal)
3006 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3007 (Fns_get_selection_internal, Fns_store_selection_internal):
3008 Use ns_symbol_to_pb and check if return value is nil.
3009 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3010 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3011 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3012 renamed to Sns_store_selection_internal.
3013 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3014 and remove this function.
3015 (ns_handle_selection_clear): Remove, never used.
3016 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3017 here.
3018
e1b01a3a
KB
30192011-12-17 Ken Brown <kbrown@cornell.edu>
3020
3021 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3022 GID is unknown (Bug#10257).
3023
2adb6e85
PE
30242011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3025
3026 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3027 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3028 which caused a build failure on GNU/Linux IA-64. This problem was
3029 introduced by my 2011-10-07 patch.
3030
d1d7b339
JL
30312011-12-15 Juri Linkov <juri@jurta.org>
3032
3033 * image.c (imagemagick_error): New function. (Bug#10112)
3034 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3035 Use `imagemagick_error' where ImageMagick functions return
3036 `MagickFalse'.
3037 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3038 proper order.
3039
100d5755
KH
30402011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3041
3042 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3043 fill background (Bug#8992).
3044
454592a6
MR
30452011-12-13 Martin Rudalics <rudalics@gmx.at>
3046
3047 * window.c (Vwindow_combination_resize)
3048 (Vwindow_combination_limit): Use t instead of non-nil in
3049 doc-strings.
61d4b438
MR
3050 (Vrecenter_redisplay): Add first sentence of doc-string on
3051 separate line.
53524d93 3052 (Frecenter): Fix doc-string typo.
454592a6 3053
3633e3aa
KH
30542011-12-11 Kenichi Handa <handa@m17n.org>
3055
3056 * coding.c (Funencodable_char_position): Pay attention to the
3057 buffer text relocation (Bug#9389).
3058
7b9d523a 30592011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3060
7b9d523a
JD
3061 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3062 gtk_init (Bug#10100).
3063
b73189c6
EZ
30642011-12-10 Eli Zaretskii <eliz@gnu.org>
3065
3066 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3067 IT->string is nil. (Bug#10263)
3068
f7dfe5d6
JD
30692011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3070
83faebb4
JD
3071 * nsterm.h (x_free_frame_resources): Declare.
3072
f7dfe5d6
JD
3073 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3074 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3075
3076 * nsterm.h (ns_get_defaults_value): Declare.
3077
3078 * nsterm.m (ns_default): Call ns_get_defaults_value.
3079
7cd4e72c
EZ
30802011-12-09 Eli Zaretskii <eliz@gnu.org>
3081
3082 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3083 (Bug#10170)
3084
b34d7317
YM
30852011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3086
3087 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3088 that where the value of an _OBJC_* symbol points to is in the .bss
3089 section (Bug#10240).
3090
76470ad1
KH
30912011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3092
3093 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3094 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3095
745fff94
KH
30962011-12-08 Kenichi Handa <handa@m17n.org>
3097
3098 * ftfont.c (get_adstyle_property): Fix previous change
3099 (Bug#10233).
3100
6e44397c
JB
31012011-12-07 Juanma Barranquero <lekktu@gmail.com>
3102
3103 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3104 dirs from the default value of EMACSLOADPATH (bug#10208).
3105
7efa6272
GM
31062011-12-07 Glenn Morris <rgm@gnu.org>
3107
3108 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3109 installation and source directories as well. (Bug#10208)
3110
f6fc4d87
CY
31112011-12-06 Chong Yidong <cyd@gnu.org>
3112
3113 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3114
2bf26180
GM
31152011-12-06 Glenn Morris <rgm@gnu.org>
3116
3117 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3118 as an error, not just -1. (Bug#10217)
3119
3a6ad4f0
CY
31202011-12-05 Chong Yidong <cyd@gnu.org>
3121
3122 * keyboard.c (process_special_events): New function.
3123 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3124
75a3b399
PE
31252011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3126
3127 * coding.c (encode_designation_at_bol): Don't use uninitialized
3128 local variable (Bug#9318).
3129
c3c9e25e
KH
31302011-12-05 Kenichi Handa <handa@m17n.org>
3131
3132 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3133 return Qnil (Bug#8046, Bug#10193).
3134
5eb05ea3
KH
31352011-12-05 Kenichi Handa <handa@m17n.org>
3136
3137 * coding.c (encode_designation_at_bol): New args charbuf_end and
3138 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3139 (coding_set_source): Return how many bytes coding->source was
3140 relocated.
3141 (coding_set_destination): Return how many bytes
3142 coding->destination was relocated.
3143 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3144 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3145
31462011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3147
3148 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3149 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3150 macro (Bug#9318).
3151
31522011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3153
3154 The following changes are to fix Bug#9318.
3155
a79703f5 3156 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3157 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3158 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3159 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3160
7dbda6df
JB
31612011-12-05 Juanma Barranquero <lekktu@gmail.com>
3162
3163 * lisp.h (process_quit_flag): Fix external declaration.
3164
6d5eb5b0
SM
31652011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3166
3167 Don't macro-inline non-performance-critical code.
3168 * eval.c (process_quit_flag): New function.
3169 * lisp.h (QUIT): Use it.
3170
a0c3fad0
JD
31712011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3172
3173 * nsfns.m (get_geometry_from_preferences): New function.
3174 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3175
6c07aac2
AS
31762011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3177
3178 * emacs.c (Qkill_emacs): Define.
3179 (syms_of_emacs): Initialize it.
3180 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3181 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3182 (quit_throw_to_read_char): Add parameter `from_signal'.
3183 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3184 * lisp.h (QUIT): Call Fkill_emacs if requested.
3185
c052ead4
JD
31862011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3187
3188 * widget.c (update_wm_hints): Return if wmshell is null.
3189 (widget_update_wm_size_hints): New function.
3190
3191 * widget.h (widget_update_wm_size_hints): Declare.
3192
3193 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3194 widget_update_wm_size_hints (Bug#10104).
3195
9e49252b
EZ
31962011-12-03 Eli Zaretskii <eliz@gnu.org>
3197
3198 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3199 before a newline, prepare the bidi iterator for consuming the
3200 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3201 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3202
02b16839
JL
32032011-12-02 Juri Linkov <juri@jurta.org>
3204
3205 * search.c (Fword_search_regexp): New Lisp function created from
3206 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3207 (Fword_search_backward, Fword_search_forward)
3208 (Fword_search_backward_lax, Fword_search_forward_lax):
3209 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3210 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3211
0068070e
SM
32122011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3213
3214 * fileio.c (Finsert_file_contents): Move after-change-function call
3215 to before the "handled:" label, since all "goto handled" appear in
3216 cases where the *-change-functions have already been properly called
3217 (bug#10117).
3218
3360a3fc
AS
32192011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3220
3221 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3222 waiting for input. (Bug#10169)
3223
73d6c093
EZ
32242011-11-30 Eli Zaretskii <eliz@gnu.org>
3225
3226 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3227 verifies glyph row's hash code--we have just reallocated the
3228 glyphs, so their contents can be complete garbage. (Bug#10164)
3229
febe6bea
JB
32302011-11-30 Juanma Barranquero <lekktu@gmail.com>
3231
3232 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3233
801a4313
EZ
32342011-11-30 Eli Zaretskii <eliz@gnu.org>
3235
3236 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3237 attributes are tested _before_ calling verify_row_hash, to protect
3238 against GCC re-ordering of the tests. (Bug#10164)
3239
2b56b87e
JD
32402011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3241
3242 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3243
3244 * xterm.c (handle_one_xevent): Only set async_visible and friends
3245 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3246 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3247 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3248
dbf31225
PE
32492011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3250
3251 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3252 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3253 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3254 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3255 All uses changed to use GCPRO1 etc.
3256 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3257 Revert to old implementation (i.e., before 2011-03-11).
3258
1305621b
YM
32592011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3260
3261 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3262 of scroll runs so as to avoid assigning disabled bogus rows and
3263 unnecessary graphics copy operations.
3264
8c9afb46
EZ
32652011-11-27 Eli Zaretskii <eliz@gnu.org>
3266
3267 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3268 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3269 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3270 (malloc, free, realloc, calloc): Redirect to e_* only when
3271 compiling Emacs.
3272
3273 * lisp.h (GCTYPEBITS): Move before first use.
3274 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3275 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3276 this macro definition.
3277
3278 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3279 _MSC_VER.
3280
54e9e3bf
JD
32812011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3282
6d5eb5b0
SM
3283 * gtkutil.c (xg_create_frame_widgets):
3284 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3285 present with Gtk+ 2.0.
3286
83aca1cb
PE
32872011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3288
3289 * fileio.c (Finsert_file_contents): Undo previous change; see
3290 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3291
5b76caa4
PE
32922011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3293
3294 Rename locals to avoid shadowing.
3295 * fileio.c (Finsert_file_contents):
3296 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3297 * process.c (wait_reading_process_output):
3298 Rename inner 'proc' to 'p' to avoid shadowing.
3299 Indent for consistency with usual Emacs style.
3300
8c535114
EZ
33012011-11-25 Eli Zaretskii <eliz@gnu.org>
3302
3303 * xdisp.c (redisplay_window): If cursor row is not fully visible
3304 after recentering, and scroll-conservatively is set to a large
3305 number, scroll window by a few more lines to make the cursor fully
3306 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3307 (start_display): Don't move to the next line if the display should
3308 start at a newline that is part of a display vector or an overlay
3309 string. (Bug#10119)
8c535114 3310
fa4fdb5c
JL
33112011-11-24 Juri Linkov <juri@jurta.org>
3312
3313 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3314 after the `MagickPingImage' call. (Bug#10112)
3315
90ec88df
CY
33162011-11-23 Chong Yidong <cyd@gnu.org>
3317
3318 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3319
56e2e794
MR
33202011-11-23 Martin Rudalics <rudalics@gmx.at>
3321
3322 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3323 making another buffer current. (Bug#10114)
3324
b6e64c41
GM
33252011-11-23 Glenn Morris <rgm@gnu.org>
3326
3327 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3328
6b21de18
CY
33292011-11-23 Chong Yidong <cyd@gnu.org>
3330
3331 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3332 using it (Bug#5984).
3333
b12cd789
EZ
33342011-11-22 Eli Zaretskii <eliz@gnu.org>
3335
3336 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3337 and header-lines, as they don't have one computed for them.
3338 (Bug#10098)
3339
3340 * .gdbinit (prow): Make displayed values more self-explaining.
3341 Add row's hash code.
3342
261b6fd4
LMI
33432011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3344
3345 * process.c (wait_reading_process_output): Fix asynchrounous
3346 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3347 (wait_reading_process_output): Add comment and URL.
261b6fd4 3348
e7cfd277
JD
33492011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3350
3351 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3352
a9b9b7f5
CY
33532011-11-21 Chong Yidong <cyd@gnu.org>
3354
3355 * window.c (Fnext_window, Fprevious_window): Doc fix.
3356
b0d15b4f
SM
33572011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3358
3359 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3360
fe7a3057
JB
33612011-11-20 Juanma Barranquero <lekktu@gmail.com>
3362
3363 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3364
d2999b1a
MR
33652011-11-20 Martin Rudalics <rudalics@gmx.at>
3366
3367 * window.c (Fset_window_combination_limit): Rename argument
3368 STATUS to LIMIT.
3369 (Vwindow_combination_limit): Remove "status" from doc-string.
3370
d5ff9cd0
AS
33712011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3372
3373 * m/ibms390.h: Remove.
3374 * m/ibms390x.h: Don't include "ibms390.h".
3375
a5bb9bd3
SM
33762011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3377
3378 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3379 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3380
cd1181db
JB
33812011-11-20 Juanma Barranquero <lekktu@gmail.com>
3382
3383 * casetab.c (Fset_case_table):
3384 * charset.c (Fcharset_after): Fix typos.
3385
615a3b8d 33862011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3387
17e845af
PE
3388 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3389 Otherwise, valgrind does not work on some platforms.
3390 Problem reported by Andreas Schwab in
6a0bf43d
PE
3391 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3392 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3393 is set, removing the need for VIRT_ADDRESS_VARIES.
3394 (PURE_P): Use a more-efficient implementation that needs just one
3395 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3396 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3397 to 4 (xorl, subq, cmpq, setbe).
3398 * alloc.c (pure): Always extern now, since that's the
3399 VIRT_ADDR_VARIES behavior.
3400 (PURE_POINTER_P): Use a single comparison, not two, for
3401 consistency with the new puresize.h.
3402 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3403 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3404 Remove VIRT_ADDR_VARIES no longer needed.
3405
f8fe6f96
EZ
34062011-11-19 Eli Zaretskii <eliz@gnu.org>
3407
3408 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3409 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3410 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3411 behave as if the cursor position were at the window margin.
3412
3413 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3414 and the cursor position is out of bounds, behave as if the cursor
3415 position were at the window margin. (Bug#10075)
3416
df05a53c
CY
34172011-11-18 Chong Yidong <cyd@gnu.org>
3418
3419 * window.c (Fwindow_combination_limit): Make first argument
3420 non-optional, since it is meaningless for live windows like the
3421 selected window.
61ccba97 3422
2071918e
DA
34232011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3424
3425 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3426
b50a28de
SM
34272011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3428
3429 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3430 (graft_intervals_into_buffer): Simplify.
3431
015137db
EZ
34322011-11-18 Eli Zaretskii <eliz@gnu.org>
3433
3434 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3435 hash values of the two rows.
3436 (copy_row_except_pointers): Preserve the used[] arrays and the
3437 hash values of the two rows. (Bug#10035)
68c95424 3438 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3439
3440 * xdisp.c (row_hash): New function, body extracted from
3441 compute_line_metrics.
3442 (compute_line_metrics): Call row_hash, instead of computing the
3443 hash code inline.
3444
3445 * dispnew.c (verify_row_hash): Call row_hash for computing the
3446 hash code of a row, instead of duplicating code from xdisp.c.
3447
3448 * dispextern.h (row_hash): Add prototype.
3449
a2addb04
TH
34502011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3451
3452 * frame.c (delete_frame): Don't delete the terminal when the last
3453 X frame is closed if emacs is built with GTK toolkit.
3454
df85d315
JB
34552011-11-17 Juanma Barranquero <lekktu@gmail.com>
3456
3457 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3458
a0c2d0ae
MR
34592011-11-17 Martin Rudalics <rudalics@gmx.at>
3460
3461 * window.c (Vwindow_splits): Rename to
3462 Vwindow_combination_resize. Suggested by Juri Linkov.
3463 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3464 of Vwindow_splits.
3465
58179cce
JB
34662011-11-16 Juanma Barranquero <lekktu@gmail.com>
3467
7877f373
JB
3468 * nsfns.m (Fns_font_name):
3469 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3470
b6f67890
MR
34712011-11-16 Martin Rudalics <rudalics@gmx.at>
3472
3473 * window.h (window): Rename slot "nest" to "combination_limit".
3474 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3475 (Fset_window_nest): Rename to Fset_window_combination_limit.
3476 (Vwindow_nest): Rename to Vwindow_combination_limit.
3477 (recombine_windows, make_parent_window, make_window)
3478 (Fsplit_window_internal, saved_window)
3479 (Fset_window_configuration, save_window_save): Rename all
3480 occurrences of window_nest to window_combination_limit.
3481
c7015153
JB
34822011-11-15 Juanma Barranquero <lekktu@gmail.com>
3483
3484 * image.c (imagemagick_load_image): Fix typo.
3485
322ad6ec
EZ
34862011-11-14 Eli Zaretskii <eliz@gnu.org>
3487
3488 * xdisp.c (display_line): Move the call to
3489 highlight_trailing_whitespace before the call to
3490 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3491 faces of all the glyphs to compute ROW's hash value.
3492 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3493
f067b8ec
JB
34942011-11-14 Juanma Barranquero <lekktu@gmail.com>
3495
3496 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3497 just return (bug#10044).
3498
1e5b2111
EZ
34992011-11-12 Eli Zaretskii <eliz@gnu.org>
3500
7ef3cbd5
EZ
3501 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3502 with user-defined heap size. Bump the default size of the temacs
3503 heap to 27MB, to avoid memory warning when running temacs.
3504 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3505
1e5b2111
EZ
3506 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3507 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3508 (verify_row_hash) [XASSERTS]: New function.
3509 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3510 that the hash value of glyph rows is correct.
1e5b2111 3511
89d61221
MR
35122011-11-12 Martin Rudalics <rudalics@gmx.at>
3513
3514 * window.h (window): Remove splits slot.
3515 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3516 (Fdelete_other_windows_internal, make_parent_window)
3517 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3518 (Fset_window_configuration, save_window_save): Don't deal with
3519 split status of windows.
3520 (saved_window): Remove splits slot.
3521 (Vwindow_splits): Rewrite doc-string.
3522
97f18cc8
JD
35232011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3524
3525 * xfns.c (unwind_create_frame):
3526 * nsfns.m (unwind_create_frame):
3527 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3528 Vframe_list (Bug#9999).
3529
22a648b4
DA
35302011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3531
0b381c7e 3532 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3533
659afede
KH
35342011-11-11 Kenichi Handa <handa@m17n.org>
3535
3536 * callproc.c (Fcall_process): Set the member dst_multibyte of
3537 process_coding.
3538
9ac0394b
KH
35392011-11-11 Johan Bockgård <bojohan@gnu.org>
3540
3541 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3542 avoid a crash (bug#9496).
3543
2fbdc249
CY
35442011-11-09 Chong Yidong <cyd@gnu.org>
3545
3546 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3547 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3548
ac6b1f81
PE
35492011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3550
3551 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3552
09db192c
PE
35532011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3554
3555 Avoid some portability problems by eschewing 'extern inline' functions.
3556 The trivial performance wins aren't worth the portability hassles; see
3557 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3558 et seq.
3559 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3560 (window_box_width, window_box_left, window_box_left_offset)
3561 (window_box_right, window_box_right_offset): Undo previous change,
3562 by removing the "extern"s.
3563 * intervals.c (adjust_intervals_for_insertion)
3564 (adjust_intervals_for_deletion): Undo previous change,
3565 making these static again.
3566 (offset_intervals, temp_set_point_both, temp_set_point)
3567 (copy_intervals_to_string): No longer inline.
3568 * xdisp.c (window_text_bottom_y, window_box_width)
3569 (window_box_height, window_box_left_offset)
3570 (window_box_right_offset, window_box_left, window_box_right)
3571 (window_box): No longer inline.
3572
105216ed
CY
35732011-11-08 Chong Yidong <cyd@gnu.org>
3574
3575 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3576 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3577 Signal an error if not a live window.
105216ed
CY
3578 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3579 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3580
ae9e237f
JB
35812011-11-07 Juanma Barranquero <lekktu@gmail.com>
3582
3583 * lisp.h (syms_of_abbrev): Remove declaration.
3584 Reported by CHENG Gao <chenggao@royau.me>.
3585
c7aa8333
EZ
35862011-11-07 Eli Zaretskii <eliz@gnu.org>
3587
3588 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3589 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3590 of temacs in GUI mode.
3591
be7f5545
MR
35922011-11-07 Martin Rudalics <rudalics@gmx.at>
3593
3594 * window.h: Declare delete_all_child_windows instead of
3595 delete_all_subwindows.
3596 * window.c (Fwindow_nest, Fset_window_nest)
3597 (Fset_window_new_total, Fset_window_new_normal)
3598 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3599 (delete_all_subwindows): Rename to delete_all_child_windows.
3600 (Fdelete_other_windows_internal, Fset_window_configuration):
3601 Call delete_all_child_windows instead of delete_all_subwindows.
3602 * frame.c (delete_frame): Call delete_all_child_windows instead
3603 of delete_all_subwindows.
3604
ca78dc43
PE
36052011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3606
3607 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3608 This is also needed for porting to any host where GC_MARK_STACK is
3609 not GC_MAKE_GCPROS_NOOPS.
3610 (which_symbols): Use it.
3611
a0241d01
KH
36122011-11-07 Kenichi Handa <handa@m17n.org>
3613
3614 * coding.c (coding_set_destination): Check coding->src_pos only
3615 when coding->src_object is a buffer (bug#9910).
3616
3617 * process.c (send_process): Set the member src_multibyte of coding
3618 to 0 (bug#9911) when sending a unibyte text.
3619
3620 * callproc.c (Fcall_process): Set the member src_multibyte of
3621 process_coding to 0 (bug#9912).
3622
a64bfdfa 36232011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3624
3625 * xmenu.c (cleanup_widget_value_tree): New function.
3626 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3627 calling free_menubar_widget_value_tree directly (Bug#9830).
3628
cb41b32a
PE
36292011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3630
3631 Fix some portability problems with 'inline'.
3632 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3633 (window_box_width, window_box_left, window_box_left_offset)
3634 (window_box_right, window_box_right_offset): Declare extern.
3635 Otherwise, these inline functions do not conform to C99 and
3636 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3637 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3638 * intervals.c (adjust_intervals_for_insertion)
3639 (adjust_intervals_for_deletion): Now extern, because otherwise the
3640 extern inline functions 'offset_intervals' couldn't refer to it.
3641 (static_offset_intervals): Remove.
3642 (offset_intervals): Rewrite using the old contents of
3643 static_offset_intervals. The old version didn't conform to C99
3644 because an extern inline function contained a reference to an
3645 identifier with static linkage.
3646
b7041366
AS
36472011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3648
3649 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3650 GC.
3651
88a37c4d
EZ
36522011-11-06 Eli Zaretskii <eliz@gnu.org>
3653
3654 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3655 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3656 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3657 return Qleft_to_right.
3658
49745b39
CY
36592011-11-06 Chong Yidong <cyd@gnu.org>
3660
3661 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3662 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3663 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3664 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3665 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3666 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3667 (Fwindow_vscroll): Doc fix.
3668 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3669 argument, since it makes no sense to pass a live window and for
3670 consistency with window-child.
3671
1f05cd82
CS
36722011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3673
3674 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3675 support MSVC.
3676
22610910
JR
36772011-11-05 Jason Rumney <jasonr@gnu.org>
3678
3679 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3680 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3681 fonts (Bug#6029).
3682 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3683 bitwise arithmetic preventing use of unicode-sip and non-truetype
3684 opentype fonts.
3685
a06776b2
EZ
36862011-11-05 Eli Zaretskii <eliz@gnu.org>
3687
3ad924ba
EZ
3688 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3689 "emacs"-only part.
3690
a06776b2
EZ
3691 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3692 initialization code to keep similarity to xfns.c after changes
3693 from 2011-11-05.
3694
c9e7db78
JD
36952011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3696
a97f8f3f
JD
3697 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3698 (unwind_create_frame): New function (Bug#9943).
3699 (Fx_create_frame): Restructure code to be more similar to the one in
3700 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3701 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3702 Move terminal->reference_count++ just before making the frame official
3703 (Bug#9943).
3704
3705 * nsterm.m (x_free_frame_resources): New function.
3706 (x_destroy_window): Move code to x_free_frame_resources.
3707
c9e7db78 3708 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3709 (Fx_create_frame, x_create_tip_frame):
3710 Move terminal->reference_count++ just before making the frame
75f1671a 3711 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3712 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3713
a6fc3b5c
EZ
37142011-11-05 Eli Zaretskii <eliz@gnu.org>
3715
3716 Support MSVC build with newer versions of Visual Studio.
3717 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3718 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3719 nt/gmake.defs.
3720
3721 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3722 which are not supported by MSVC.
3723 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3724 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3725 bitfields.
3726 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3727 types in bitfields.
3728 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3729
3730 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3731
58179cce 37322011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3733
3734 Support MSVC build with newer versions of Visual Studio.
3735 * w32.c: Don't include w32api.h for MSVC.
3736 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3737
3738 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3739 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3740 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3741 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3742 e_* cousins.
3743 (alloca) [_MSC_VER]: Define to _alloca.
3744
3745 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3746
3747 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3748
a58c13ed
EZ
37492011-11-04 Eli Zaretskii <eliz@gnu.org>
3750
3751 * xdisp.c (note_mouse_highlight): If either of
3752 previous/next-single-property-change returns nil, treat that as
3753 the beginning or the end of the buffer. (Bug#9955)
3754
fe0b6370
JD
37552011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3756
a58c13ed 3757 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3758 label is not null (Bug#9951).
3759 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3760 may be NULL.
3761
89bd5ee1
EZ
37622011-11-04 Eli Zaretskii <eliz@gnu.org>
3763
3764 * window.c (Fwindow_body_size): Mention in the doc string that the
3765 return value is in frame's canonical units. (Bug#9949)
3766
84c3edb9
EZ
37672011-11-03 Eli Zaretskii <eliz@gnu.org>
3768
4e2fb5c7
EZ
3769 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3770
84c3edb9 3771 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3772 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3773 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3774
bc17a887
EZ
37752011-11-01 Eli Zaretskii <eliz@gnu.org>
3776
3777 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3778 Don't stop backward scan on the continuation glyph, even though
3779 its CHARPOS is positive.
6d5eb5b0
SM
3780 (mouse_face_from_buffer_pos, note_mouse_highlight):
3781 Rename cover_string to disp_string.
bc17a887 3782
4ee88440
MR
37832011-11-01 Martin Rudalics <rudalics@gmx.at>
3784
3785 * window.c (temp_output_buffer_show): Don't use
3786 Vtemp_buffer_show_specifiers.
3787 (Vtemp_buffer_show_specifiers): Remove unused variable.
3788
c2ff3c02
EZ
37892011-10-30 Eli Zaretskii <eliz@gnu.org>
3790
3791 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3792 past the beginning of the current glyph matrix.
3793
58179cce 37942011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3795
3796 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3797 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3798 HAVE_GTK3 (Bug#9869).
b77a6a7f 3799
3b574623
JD
3800 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3801 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3802
b77a6a7f
JD
3803 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3804
3805 * xterm.c: Declare x_handle_net_wm_state to return int.
3806 (handle_one_xevent): Check if we are iconified but don't have
3807 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3808 (get_current_wm_state): Return non-zero if not hidden,
3809 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3810 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3811 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3812 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3813
196e41e4
PE
38142011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3815
3816 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3817 so that this new function doesn't get optimized away by a
3818 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3819
021f2e1a
AS
38202011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3821
3822 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3823
8b058d44
EZ
38242011-10-29 Eli Zaretskii <eliz@gnu.org>
3825
3826 Fix the `xbytecode' command.
3827 * .gdbinit (xprintbytestr): New command.
b50a28de 3828 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3829 (xbytecode): Print the byte-code string as well.
3830
4452fb80
EZ
38312011-10-29 Kim Storm <storm@cua.dk>
3832
8b058d44
EZ
3833 * alloc.c (which_symbols): New function.
3834
21b72067
AS
38352011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3836
3837 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3838 line. (Bug#9903)
3839
83ed7b5c
GM
38402011-10-29 Glenn Morris <rgm@gnu.org>
3841
3842 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3843 Not clear what it was for, and it causes various bugs. (Bug#9839)
3844
5a7a728b
EZ
38452011-10-28 Eli Zaretskii <eliz@gnu.org>
3846
3847 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3848 possible random value that matches one of those tested as
3849 condition to clear the mouse face.
3850
d3d0842f
CY
38512011-10-28 Chong Yidong <cyd@gnu.org>
3852
3853 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3854
31b39d13
DN
38552011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3856
3857 * window.c (make_window): Initialize phys_cursor_on_p.
3858
9aba6043
SM
38592011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3860
3861 * lisp.h (struct Lisp_Symbol): Update comments.
3862
c20992f4
JB
38632011-10-28 Juanma Barranquero <lekktu@gmail.com>
3864
3865 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3866
db4f02f2
EZ
38672011-10-28 Eli Zaretskii <eliz@gnu.org>
3868
3869 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3870 <oslsachem@gmail.com> for helping to debug this.
3871
3872 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3873 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3874 (g_b_init_get_glyph_outline_w): New static variables.
3875 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3876 (GetGlyphOutlineW_Proc): New typedefs.
3877 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3878 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3879 New functions.
3880 (w32font_open_internal, compute_metrics):
3881 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3882 instead of calling the "wide" APIs directly.
3883
3884 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3885
3886 * w32.h (syms_of_w32font): Add prototype.
3887
87e68db4
JB
38882011-10-27 Juanma Barranquero <lekktu@gmail.com>
3889
3890 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3891 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3892 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3893 (Fmove_to_window_line): Doc fix.
3894
435c1d67
CY
38952011-10-27 Chong Yidong <cyd@gnu.org>
3896
3897 * process.c (make_process): Set gnutls_state to NULL.
3898
3899 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3900 non-NULL, regardless of GNUTLS_INITSTAGE.
3901 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3902 an error. Set process slots as soon as we allocate them.
3903
3904 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3905
9c6c6f49
CY
39062011-10-27 Chong Yidong <cyd@gnu.org>
3907
9aba6043
SM
3908 * gnutls.c (emacs_gnutls_deinit): New function.
3909 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3910 (Fgnutls_deinit, Fgnutls_boot): Use it.
3911
3912 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3913 (deactivate_process): Call emacs_gnutls_deinit.
3914
657d08d3
JB
39152011-10-27 Juanma Barranquero <lekktu@gmail.com>
3916
3917 * image.c (x_create_x_image_and_pixmap):
3918 * w32.c (sys_rename, w32_delayed_load):
3919 * w32font.c (fill_in_logfont):
3920 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3921
5430d399
JB
39222011-10-26 Juanma Barranquero <lekktu@gmail.com>
3923
3924 * w32fns.c (w32_default_color_map): New function,
3925 extracted from Fw32_default_color_map.
a7ef684b 3926 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3927
fe0055fa
PE
39282011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3929
3930 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3931
e6346438
SM
39322011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3933
3934 * keyboard.c (test_undefined): New function (bug#9751).
3935 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3936
e112cc37
ET
39372011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3938
3939 * sysdep.c (init_sys_modes): Fix the check for the controlling
3940 terminal (Bug#6649).
3941
7b5d6677
EZ
39422011-10-20 Eli Zaretskii <eliz@gnu.org>
3943
3944 * dispextern.h (struct bidi_it): New member next_en_type.
3945
3946 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3947 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3948 current character, check also for next_en_type being WEAK_EN.
3949 (bidi_resolve_weak): Don't enter the expensive loop if the current
3950 position is before next_en_pos. Record the bidi type of the first
3951 non-ET, non-BN character we find, in addition to its position.
3952 (bidi_level_of_next_char): Invalidate next_en_type when
3953 next_en_pos is over-stepped.
3954
7da0b018
PE
39552011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3956
3957 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3958 * editfns.c: Rewrite current-time-zone so that it invokes
3959 the equivalent of (format-time-string "%Z") to get the time zone name.
3960 This fixes a bug when the time zone name contains characters that
3961 need converting from the system time locale to Emacs internal format.
3962 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3963 that patch fixed format-time-string to do the conversion, but
3964 I forgot to fix current-time-zone.
3965 (format_time_string): New function, containing most of
3966 what Fformat_time_string used to contain.
3967 (Fformat_time_string): Rewrite in terms of format_time_string.
3968 This doesn't change this function's behavior.
3969 (current-time-zone): Rewrite to use format_time_string.
3970 This fixes the bug reported by Michael Schierl in
3971 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3972 Jason Rumney's 2007-06-07 change worked around this bug, but
3973 didn't fix it.
3974 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3975
8547b010
EZ
39762011-10-19 Eli Zaretskii <eliz@gnu.org>
3977
3978 * xdisp.c (start_display): If the character at POS is displayed
3979 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3980 (try_window_reusing_current_matrix): If a line ends in a display
3981 vector or the next line starts in a display vector, continue
3982 redrawing the window even though the character position of
3983 start_row was reached.
8547b010
EZ
3984 (Bug#9771, part 2)
3985
4e948d15
CY
39862011-10-18 Chong Yidong <cyd@gnu.org>
3987
3988 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3989 with nobreak-char-display too.
3990
4787455f
EZ
39912011-10-18 Eli Zaretskii <eliz@gnu.org>
3992
3993 Fix part 3 of bug#9771.
3994 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3995 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3996 non-neutral characters if the current character is a paragraph
3997 separator (a.k.a. Newline). This avoids running the same
3998 expensive loop twice, once when we consume the preceding newline
3999 and the other time when the line actually needs to be displayed.
4000 Avoid the loop when we see neutrals on the base embedding level
4001 following a character whose directionality is the same as the
4002 paragraph's. This avoids running the expensive loop when a line
4003 ends in a long sequence of neutrals, like control characters.
4004 Add assertion against STRONG_AL type. Slightly rearrange code
4005 that determines the type of a neutral given the first non-neutral
4006 that follows it.
4007 (bidi_level_of_next_char): Set next_en_pos to zero when
4008 invalidating its info.
4009
2c91f553
EZ
40102011-10-17 Eli Zaretskii <eliz@gnu.org>
4011
4012 * xdisp.c (push_display_prop): Determine whether to record string
4013 or buffer position by IT->string, not by IT->method. Allow
4014 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4015 (move_it_vertically_backward): Don't look for character position
4016 immediately after the newline when in a continuation line.
4017 (Bug#9771, part 1)
2c91f553 4018
c7b08b0d
MR
40192011-10-15 Martin Rudalics <rudalics@gmx.at>
4020
4021 * window.c (coordinates_in_window): Rewrite and delabelize
4022 vertical border check. (Bug#5357) (Bug#9618)
4023
6b02f655
SM
40242011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4025
4026 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4027 errors in XSetWindowBorder (bug#9310).
4028
81d40c92
DA
40292011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4030
4031 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4032 avoid crash when xmalloc overrun checking is enabled.
4033
d4172c3b
EZ
40342011-10-13 Eli Zaretskii <eliz@gnu.org>
4035
4036 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4037 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4038 cursor motion with <left> and <right> arrow keys.
4039
4040 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4041 some callers set that themselves.
4042
b00eea75
EZ
40432011-10-12 Eli Zaretskii <eliz@gnu.org>
4044
4045 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4046 display string and the previous row comes from the same string and
4047 is empty. (Bug#9739) (Bug#9738)
4048
8fe012c4
SM
40492011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4050
4051 * doc.c (get_doc_string): Encode file name (bug#9735).
4052
0074aef2
EZ
40532011-10-12 Eli Zaretskii <eliz@gnu.org>
4054
79beb178
EZ
4055 * bidi.c (bidi_level_of_next_char):
4056 * xdisp.c (get_visually_first_element): Remove old incorrect
4057 comments regarding the Unicode Line Separator character.
4058
0074aef2
EZ
4059 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4060
6e4b3fbe
DA
40612011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4062
4063 * alloc.c (Fgc_status): Do not access beyond zombies array
4064 boundary if nzombies > MAX_ZOMBIES.
4065 * alloc.c (dump_zombies): Add missing format specifier.
4066
0324f3af
PE
40672011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4068
b5525cac
PE
4069 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4070 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4071
0324f3af
PE
4072 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4073 Some packages use them to denote characters with modifiers.
4074
e9b5f888
AS
40752011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4076
4077 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4078 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4079 matching a pp-number. Rename parameter var to var1.
4080
127827c0
SM
40812011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4082
4083 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4084
c8fd3bd0
GM
40852011-10-08 Glenn Morris <rgm@gnu.org>
4086
4087 * callint.c (Fcall_interactively): Give a more explicit error for the
4088 'c' case with a non-character input. (Bug#8479)
4089
352ec8ff
EZ
40902011-10-08 Eli Zaretskii <eliz@gnu.org>
4091
03669ccb
EZ
4092 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4093 lines.
7061c986
EZ
4094 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4095 lines that are hscrolled on the left.
03669ccb 4096
352ec8ff
EZ
4097 * dispnew.c (buffer_posn_from_coords): Account for a possible
4098 presence of header-line. (Bug#4426)
4099
a66cfb1c
SM
41002011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4101
6b02f655
SM
4102 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4103 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4104
7c5ee88e
PE
41052011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4106
4107 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4108 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4109 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4110 this makes Emacs dump core during garbage collection on rare
4111 occasions. sizeof is obviously inferior to offsetof here, so
4112 stick with offsetof.
4113 (GC_POINTER_ALIGNMENT): New macro.
4114 (mark_memory): Omit 3rd (offset) arg; caller changed.
4115 Don't assume EMACS_INT alignment is the same as pointer alignment.
4116
df1bbe5b
SM
41172011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4118
4119 * keyboard.c (read_key_sequence_remapped): New var.
4120 (read_key_sequence): Compute remapping in the right buffer.
4121 (command_loop_1): Use read_key_sequence's remapping directly.
4122
51553db6
SM
41232011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4124
32c1fffd
SM
4125 * dired.c (file_name_completion): Don't expand file name.
4126 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4127 before checking file name handler.
4128
51553db6
SM
4129 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4130 they've been requested explicitly (bug#9591).
4131
b6bd1599 41322011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4133
4134 * keymap.c (Fsingle_key_description): Use make_specified_string
4135 instead of build_string to build string from push_key_description.
4136 (Bug#5193)
4137
f701dc2a
PE
41382011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4139
4222c55d
PE
4140 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4141 This fixes a Y2038 bug on 64-bit hosts.
4142 * buffer.c (reset_buffer):
4143 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4144 (Fclear_buffer_auto_save_failure):
4145 Use 0, not -1, to represent an unset failure time, since time_t
4146 might not be signed.
4147
f701dc2a
PE
4148 Remove dependency on glibc malloc internals.
4149 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4150 Move back here from lisp.h, but with their new implementations.
4151 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4152 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4153 * charset.c (charset_table_init): New static var.
4154 (syms_of_charset): Use it instead of xmalloc. This removes a
4155 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4156 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4157 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4158 Move back to alloc.c.
4159 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4160 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4161
9ceebf39
JD
41622011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4163
4164 * nsterm.m (windowDidResize): Call x_set_window_size only when
4165 ns_in_resize is true. Otherwise set pixelwidth/height and
4166 call change_frame_size (Bug#9628).
4167
cb993c58
PE
41682011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4169
3930c88b
PE
4170 Port --enable-checking=all to Fedora 14 x86-64.
4171 * charset.c (syms_of_charset): Also account for glibc malloc's
4172 internal overhead when calculating the initial malloc maximum.
4173
cb993c58
PE
4174 Port --enable-checking=all to Fedora 14 x86.
4175 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4176 Move to lisp.h.
4177 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4178 (overrun_check_realloc, overrun_check_free):
4179 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4180 That way, xmalloc returns a properly-aligned pointer even if
4181 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4182 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4183 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4184 into account when calculating the initial malloc maximum.
4185 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4186 Move here from alloc.c, so that charset.c can use it too.
4187 Properly align; the old code wasn't right for common 32-bit hosts
4188 when configured with --enable-checking=all.
4189 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4190 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4191
31bed486
EZ
41922011-09-29 Eli Zaretskii <eliz@gnu.org>
4193
04c70788 4194 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4195 use EDOM.
4196
fbcaa2f3
EZ
41972011-09-28 Eli Zaretskii <eliz@gnu.org>
4198
4199 * xdisp.c (compute_display_string_end): If there's no display
4200 string at CHARPOS, return -1.
4201
4202 * bidi.c (bidi_fetch_char): When compute_display_string_end
4203 returns a negative value, treat the character as a normal
4204 character not covered by a display string. (Bug#9624)
4205
a239d4e9
JB
42062011-09-28 Juanma Barranquero <lekktu@gmail.com>
4207
4208 * lread.c (Fread_from_string): Fix typo in docstring.
4209
88652fd5
EZ
42102011-09-27 Eli Zaretskii <eliz@gnu.org>
4211
4212 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4213 newline, reseat the iterator instead of bidi-iterating there one
4214 character at a time. (Bug#9610)
32c1fffd
SM
4215 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4216 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4217
ed497dd4
AS
42182011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4219
4220 * lread.c (readevalloop): Use correct code for NBSP.
4221 (read1): Likewise. (Bug#9608)
4222
b2bf61aa
MA
42232011-09-25 Michael Albinus <michael.albinus@gmx.de>
4224
4225 * dbusbind.c (Fdbus_register_signal): When service is not
4226 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4227
32bbb17c
GM
42282011-09-25 Glenn Morris <rgm@gnu.org>
4229
4230 * buffer.c (truncate-lines): Doc fix.
4231
94e0933e
CY
42322011-09-24 Chong Yidong <cyd@stupidchicken.com>
4233
4234 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4235 (Fset_window_next_buffers): Doc fix.
4236
cddde921
GM
42372011-09-24 Glenn Morris <rgm@gnu.org>
4238
4239 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4240
1260aef1
PE
42412011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4242
25b4bfa0
PE
4243 Fix minor problems found by static checking.
4244 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4245 * indent.c (Fvertical_motion): Fix == vs = typo.
4246
e3cbd34b
EZ
42472011-09-24 Eli Zaretskii <eliz@gnu.org>
4248
a66cfb1c
SM
4249 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4250 Default value is now t. Doc fix.
6bf7006f 4251
e3cbd34b 4252 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4253 logic when moving up, not only when moving down. Fix the
e3cbd34b 4254 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4255 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4256
4257 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4258 CHARPOS is covered by a display string which includes newlines.
4259 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4260 is covered by a display string with embedded newlines.
4261
a3de0cbd
MA
42622011-09-24 Michael Albinus <michael.albinus@gmx.de>
4263
4264 * dbusbind.c (Fdbus_register_signal): Add match rule to
4265 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4266 (Fdbus_register_method, Vdbus_registered_objects_table):
4267 Fix docstring.
a3de0cbd 4268
b260039d
JM
42692011-09-24 Jim Meyering <meyering@redhat.com>
4270
32c1fffd 4271 do not ignore write error for any output size
b260039d
JM
4272 The previous change was incomplete.
4273 While it makes emacs --batch detect the vast majority of stdout
4274 write failures, errors were still ignored whenever the output size is
4275 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4276 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4277 && echo FAIL: ignored write error
4278 FAIL: ignored write error
4279 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4280 && echo FAIL: ignored write error
4281 FAIL: ignored write error
4282 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4283
8eca8a7c
AS
42842011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4285
4286 * emacs.c (Fkill_emacs): In noninteractive mode exit
4287 non-successfully if a write error occurred on stdout. (Bug#9574)
4288
3341db62
EZ
42892011-09-21 Eli Zaretskii <eliz@gnu.org>
4290
4291 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4292 the xassert test.
4293
4294 * dispextern.h (struct it): Update the comment documenting what
4295 can it->OBJECT be.
4296
8c203dbf
EZ
42972011-09-20 Eli Zaretskii <eliz@gnu.org>
4298
4299 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4300 a display string, extend search for cursor position to end of row.
4301 (find_row_edges): If the row ends in a newline from a display
4302 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4303 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4304 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4305 non-empty line. Fixes confusing cursor motion with arrow keys at
4306 the beginning of a line that starts with whitespace.
8c203dbf 4307
a4824228
LMI
43082011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4309
4310 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4311 (bug#9493).
4312
33ed493b
CY
43132011-09-18 Chong Yidong <cyd@stupidchicken.com>
4314
4315 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4316 boolean (Bug#9154).
4317
56cd55c8
EZ
43182011-09-18 Eli Zaretskii <eliz@gnu.org>
4319
4320 * xdisp.c (display_line): Record maximum and minimum buffer
4321 positions even if no glyphs were produced (e.g., by a zero-width
4322 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4323 buffer positions that will be removed from the glyph row because
4324 they don't fit.
c02dcedf
EZ
4325 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4326 column is beyond frame width: don't subtract 1 "pixel" when
4327 computing width of the stretch.
3e62b7e0
EZ
4328 (reseat_at_next_visible_line_start): Undo the change made on
4329 2011-09-17 that saved paragraph information and restored it after
4330 the call to `reseat'. (Bug#9545)
56cd55c8 4331
5ed99d36 43322011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4333
4334 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4335 and turn window cursor on if cleared (Bug#9415).
4336
5ed99d36 43372011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4338
4339 * search.c (boyer_moore): Take unibyte characters from pattern
4340 literally. (Bug#9458)
4341
9bade7b2
EZ
43422011-09-18 Eli Zaretskii <eliz@gnu.org>
4343
4344 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4345
e5e9d610
PE
43462011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4347
87e4427a
PE
4348 Fix minor problem found by static checking.
4349 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4350 initialized, to pacify gcc -Wuninitialized.
4351
e5e9d610
PE
4352 * fileio.c: Report proper errno when syscall falls.
4353 (Finsert_file_contents): Save and restore errno,
4354 so that report_file_error outputs the correct diagnostic.
4355 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4356
a1674f0b
EZ
43572011-09-18 Eli Zaretskii <eliz@gnu.org>
4358
4359 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4360
fbfb6dd4
EZ
43612011-09-17 Eli Zaretskii <eliz@gnu.org>
4362
4363 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4364 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4365
bb187662
EZ
43662011-09-17 Eli Zaretskii <eliz@gnu.org>
4367
1137e8b8 4368 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4369 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4370
4371 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4372 (bidi_find_paragraph_start): Search back for paragraph beginning
4373 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4374 (bidi_move_to_visually_next): Only trigger paragraph-related
4375 computations when the last character is a newline or at EOB, not
4376 just any NEUTRAL_B. (Bug#9470)
4377
bb187662
EZ
4378 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4379 truncated lines if point is covered by a display string. (Bug#9524)
4380
2e621251
PE
43812011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4382
4383 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4384 (cons_to_x_long): New function.
4385 (lisp_data_to_selection_data): Use it. Correct the test for
4386 short-versus-long data; it was negated. Break out of vector
4387 loop, for efficiency, when a long datum is discovered.
4388
91a15bc6
SM
43892011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4390
4391 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4392
b41c3a35
EZ
43932011-09-16 Eli Zaretskii <eliz@gnu.org>
4394
4395 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4396 GCC PR/17406) by declaring this function with external scope.
4397
7812ba2d
PE
43982011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4399
4400 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4401 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4402
cf7edc2a
AS
44032011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4404
4405 * editfns.c (Fformat): Correctly handle text properties on "%%".
4406
bd01620e
EZ
44072011-09-15 Eli Zaretskii <eliz@gnu.org>
4408
4409 * xterm.c (x_draw_composite_glyph_string_foreground):
4410 * w32term.c (x_draw_composite_glyph_string_foreground):
4411 * term.c (encode_terminal_code):
4412 * composite.c (composition_update_it, get_composition_id):
4413 * xdisp.c (get_next_display_element)
4414 (fill_composite_glyph_string): Add comments about special meaning
4415 of TAB characters in a composition.
4416
a02719a3
PE
44172011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4418
4419 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4420 This occurs when processing a multibyte format.
4421 Problem reported by Wolfgang Jenker.
a02719a3 4422
72589a3c
JB
44232011-09-15 Johan Bockgård <bojohan@gnu.org>
4424
4425 * xdisp.c (try_cursor_movement): Only check for exact match if
4426 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4427
1c14176c
PE
44282011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4429
4430 Remove unused external symbols.
4431 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4432 * xdisp.c (calc_pixel_width_or_height): Now static.
4433 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4434 * indent.c (check_display_width):
4435 * w32term.c: Fix comment to match code.
4436 * xterm.c, xterm.h (x_catching_errors): Remove.
4437
d2eea5b5
PE
44382011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4439
4440 * xselect.c: Use signed conversions more consistently (Bug#9498).
4441 (selection_data_to_lisp_data): Assume incoming selection data are
4442 signed integers, not unsigned. This is to be consistent with
4443 outgoing selection data, which was modified to use signed integers
4444 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4445 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4446 expects long, not unsigned long.
4447
46888499
EZ
44482011-09-14 Eli Zaretskii <eliz@gnu.org>
4449
4450 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4451 computation of loop end. Reported by Johan Bockgård
4452 <bojohan@gnu.org>.
4453
ef8ef9fb
CY
44542011-09-13 Chong Yidong <cyd@stupidchicken.com>
4455
4456 * frame.c (Fother_visible_frames_p): Function deleted.
4457
fa819fed
EZ
44582011-09-12 Eli Zaretskii <eliz@gnu.org>
4459
4460 * indent.c (compute_motion): Process display vector front to back
4461 rather than the other way around. (Bug#2496)
4462
2ba8e008
SM
44632011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4464
4465 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4466
20f53c69
CY
44672011-09-11 Chong Yidong <cyd@stupidchicken.com>
4468
4469 * minibuf.c (Fread_from_minibuffer): Doc fix.
4470
d562d7a4
EZ
44712011-09-11 Eli Zaretskii <eliz@gnu.org>
4472
4473 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4474 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4475
1c4d7f3d
LMI
44762011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4477
4478 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4479 value for non-existent files.
4480
b885bf36
EZ
44812011-09-11 Eli Zaretskii <eliz@gnu.org>
4482
4483 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4484 set its "size" to -1. This will set the modtime_size field of
4485 the corresponding buffer to -1, which is what
4486 verify-visited-file-modtime expects for files that do not exist.
4487 (Bug#9139)
4488
6612f0bf
PE
44892011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4490
4491 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4492 here ...
4493 * lisp.h: ... from here. push_key_description is no longer
4494 defined in keyboard.c, so its declaration should not be in
4495 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4496 logically belongs with push_key_description.
4497
dfb3f755
PE
44982011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4499
4500 * buffer.h: Include <sys/types.h> instead of <time.h>.
4501 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4502 Problem reported by Herbert J. Skuhra.
4503
3134906c
LMI
45042011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4505
4506 * xml.c (parse_region): Make the parsing work for
4507 non-comment-starting XML files again (bug#9144).
4508
8d903f4e
AS
45092011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4510
4511 * image.c (gif_load): Fix calculation of bottom and right corner.
4512 (Bug#9468)
4513
80ad64f4
EZ
45142011-09-10 Eli Zaretskii <eliz@gnu.org>
4515
4516 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4517 redisplay in small windows.
4518
208a048d
EZ
45192011-09-09 Eli Zaretskii <eliz@gnu.org>
4520
4521 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4522
9b1c252e
MR
45232011-09-08 Martin Rudalics <rudalics@gmx.at>
4524
4525 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4526 Operate on live windows only.
4527
2949f33b
JB
45282011-09-08 Juanma Barranquero <lekktu@gmail.com>
4529
4530 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4531
e08dcafd
EZ
45322011-09-07 Eli Zaretskii <eliz@gnu.org>
4533
4534 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4535 only under bidi iteration.
4536
115b96bd
JD
45372011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4538
4539 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4540
c8199d0f
PE
45412011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4542
4543 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4544 Without this fix, the command to link temacs failed due to an
4545 undefined symbol __builtin_isnan. This is because
4546 /usr/include/iso/math_c99.h #defines isnan(x) to
4547 __builtin_isnan(x), but the bundled gcc, which identifies itself
4548 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4549 a __builtin_isnan.
4550 * floatfns.c (isnan): #undef, and then #define to a clone of
4551 what's in data.c.
4552 (Fisnan): Always define, since it's always available now.
4553 (syms_of_floatfns): Always define isnan at the Lisp level.
4554
e39b275c 45552011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4556
4557 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4558
b2db44d9 45592011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4560
f4af5137 4561 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4562 The previous code assumed that file offsets (off_t values) fit in
4563 EMACS_INT variables, which is not true on typical 32-bit hosts.
4564 The code messed up by falsely reporting buffer overflow in cases
4565 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4566 when "big" contains more than 2**29 bytes, even though this
4567 inserts just one byte and does not overflow the buffer.
4568 (Finsert_file_contents): Store file offsets as off_t
4569 values, not as EMACS_INT values. Check for overflow when
4570 converting between EMACS_INT and off_t. When checking for
4571 buffer overflow or for overlap, take the offsets into account.
4572 Don't use EMACS_INT for small values where int suffices.
4573 When checking for overlap, fix a typo: ZV was used where
4574 ZV_BYTE was intended.
4575 (Fwrite_region): Don't assume off_t fits into 'long'.
4576 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4577
ecfc0a49
MA
45782011-09-05 Michael Albinus <michael.albinus@gmx.de>
4579
4580 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4581
6511acf2 45822011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4583
0999621a 4584 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4585
4586 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4587 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4588 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4589 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4590 (modify_event_symbol): Do not assume that the length of
4591 name_alist_or_stem is safe to alloca and fits in int.
4592 (Fexecute_extended_command): Likewise for function name and binding.
4593 (Frecursion_depth): Wrap around reliably on integer overflow.
4594 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4595 since some callers pass EMACS_INT values.
4596 (Fsingle_key_description): Don't crash if symbol name contains more
4597 than MAX_ALLOCA bytes.
4598 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4599 (get_minibuffer): Arg is now EMACS_INT, not int.
4600 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4601 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4602 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4603
2be7d702
PE
4604 * dbusbind.c (signature_cat): New function.
4605 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4606 Do not overrun buffer; instead, report string overflow.
4607
9d1df220
PE
4608 * dispnew.c (add_window_display_history): Don't overrun buffer.
4609 Truncate instead; this is OK since it's just a log.
4610
33ef5c64
PE
4611 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4612 even if the time zone offset is outlandishly large.
4613 Don't mishandle offset == INT_MIN.
4614
66c6fdd5
PE
4615 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4616 when creating daemon; the previous buffer-overflow check was incorrect.
4617
d749b01b
PE
4618 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4619 which has the guts of the old verror function.
4620
b5cd1905
PE
4621 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4622 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4623
6e1a67fb
PE
4624 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4625 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4626 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4627 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4628 length of string rather than counting it via multiple sprintfs;
4629 that's simpler and more reliable.
c21721cc
PE
4630 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4631 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4632 sprintf, in case result does not fit in int.
4633
c57b67fc
PE
4634 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4635 (fontset_from_font): Print it.
4636
8a401434
PE
4637 * frame.c (tty_frame_count): Now printmax_t, not int.
4638 (make_terminal_frame, set_term_frame_name): Print it.
4639 (x_report_frame_params): In X, window IDs are unsigned long,
4640 not signed long, so print them as unsigned.
4641 (validate_x_resource_name): Check for implausibly long names,
4642 and don't assume name length fits in 'int'.
4643 (x_get_resource_string): Don't blindly alloca invocation name;
4644 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4645 not fit in int.
4646
6e1a67fb
PE
4647 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4648 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4649 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4650
0df02bf3
PE
4651 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4652 Use esprintf, not sprintf, in case result does not fit in int.
4653
48e30793
PE
4654 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4655 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4656 it as a large positive number.
4657 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4658 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4659
a66ff6d8
PE
4660 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4661 in case result does not fit in int.
4662
aca216ff
PE
4663 * print.c (float_to_string): Detect width overflow more reliably.
4664 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4665 buffer overrun. Don't assume list length fits in 'int'. Treat
4666 print length of 0 as 0, not as infinity; to be consistent with other
4667 uses of print length in this function. Don't overflow print length
4668 index. Don't assume hash table size fits in 'long', or that
4669 vectorlike size fits in 'unsigned long'.
4670
31c286f7
PE
4671 * process.c (make_process): Use printmax_t, not int, to format
4672 process-name gensyms.
4673
55e5faa1
PE
4674 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4675
80f2e268
PE
4676 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4677 to avoid potential buffer overrun.
4678
670741ab
PE
4679 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4680 if X resource line is longer than 512 bytes.
4681
b7163a50
PE
4682 * xfns.c (x_window): Make sprintf buffer a bit bigger
4683 to avoid potential buffer overrun.
4684
ae58ff1f
PE
4685 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4686
c43c8a6a
PE
4687 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4688
3f8236f4
PE
46892011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4690
53e9fe90 4691 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4692 Without these, Emacs silently mishandles large integers sometimes.
4693 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4694 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4695
6511acf2
PE
4696 * xdisp.c (try_window_id): Check Emacs fixnum range before
4697 converting to 'int'.
806add1d 4698
6511acf2 4699 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4700 Check that an Emacs fixnum is in range before assigning it to 'int'.
4701 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4702 values converted from Emacs fixnums.
4703 (Frecenter): Don't wrap around a line count if it is out of 'int'
4704 range; instead, treat it as an extreme value.
4705 (Fset_window_configuration, compare_window_configurations):
4706 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4707
6511acf2
PE
4708 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4709 that can exceed INT_MAX. Check that EMACS_INT value is in range
4710 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4711 (match_limit): Don't assume that a fixnum can fit in 'int'.
4712
6511acf2 4713 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4714 exceed INT_MAX.
4715
6511acf2 4716 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4717 (Fvertical_motion): Don't wrap around LINES values that don't fit
4718 in 'int'. Instead, treat them as extreme values. This is good
4719 enough for windows, which can't have more than INT_MAX lines anyway.
4720
fcb901a7
LMI
47212011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4722
0f2f6b6d
LMI
4723 * Require libxml/parser.h to avoid compilation warning.
4724
fcb901a7
LMI
4725 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4726
4727 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4728 since this reportedly can destroy thread storage.
4729
6e20a0d4
CY
47302011-08-30 Chong Yidong <cyd@stupidchicken.com>
4731
4732 * syntax.c (find_defun_start): Update all cache variables if
4733 exiting early (Bug#9401).
4734
148ae00e
EZ
47352011-08-30 Eli Zaretskii <eliz@gnu.org>
4736
f6cfbd8f
EZ
4737 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4738
148ae00e
EZ
4739 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4740 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4741 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4742
4743 * term.c (tty_append_glyph): New function.
4744 (produce_stretch_glyph): Static function and its prototype deleted.
4745
a66cfb1c
SM
4746 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4747 Add prototypes.
148ae00e 4748
c4a07a4c
PE
47492011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4750
4751 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4752 when checking :margin (Bug#9390).
4753 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4754 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4755 so that the name doesn't mislead. All uses changed.
4756
6bc8cd65
JB
47572011-08-28 Johan Bockgård <bojohan@gnu.org>
4758
4759 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4760 set_tty_hooks.
4761
dca4927e
EZ
47622011-08-27 Eli Zaretskii <eliz@gnu.org>
4763
4764 * xdisp.c (move_it_to): Don't bail out early when reaching
4765 position beyond to_charpos, if we are scanning backwards.
4766 (move_it_vertically_backward): When DY == 0, make sure we get to
4767 the first character in the line after the newline.
4768
f2cad773
PE
47692011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4770
4771 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4772 (ccl_driver): Do not generate an out-of-range pointer.
4773 (Fccl_execute_on_string): Remove unnecessary check for
4774 integer overflow, noted by Stefan Monnier in
4775 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4776 Remove a FIXME that didn't need fixing.
4777 Simplify the newly-introduced buffer reallocation code.
4778
0cae2cdb
JB
47792011-08-27 Juanma Barranquero <lekktu@gmail.com>
4780
4781 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4782
5fc295a4 47832011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4784
70c60eb2 4785 Integer and memory overflow issues (Bug#9196).
726e0ab1 4786
d31850da
PE
4787 * doc.c (get_doc_string): Rework so that
4788 get_doc_string_buffer_size is the actual buffer size, rather than
4789 being 1 less than the actual buffer size; this makes xpalloc more
4790 convenient.
4791
a69fbedb
PE
4792 * image.c (x_allocate_bitmap_record, cache_image):
4793 * xselect.c (Fx_register_dnd_atom):
4794 Simplify previous changes by using xpalloc.
4795
fe5c5d37
PE
4796 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4797 since either will do and ptrdiff_t is convenient with xpalloc.
4798
0065d054
PE
4799 * charset.c (charset_table_size)
4800 (struct charset_sort_data.priority): Now ptrdiff_t.
4801 (charset_compare): Don't overflow if priorities differ greatly.
4802 (Fsort_charsets): Don't assume list length fits in int.
4803 Check for size-calculation overflow when allocating sort data.
4804 (syms_of_charset): Allocate an initial charset table that is
4805 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4806
4807 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4808
4809 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4810 The actual value is always <= INT_MAX, and leaving it unsigned made
4811 overflow checking harder.
4812
4813 * dispextern.h (struct glyph_matrix.rows_allocated)
4814 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4815 with xpalloc. The values are still always <= INT_MAX.
4816
4817 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4818
4819 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4820 (SAFE_NALLOCA): New macro.
4821
4822 * region-cache.c (struct boundary.pos, find_cache_boundary)
4823 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4824 (set_cache_region, invalidate_region_cache)
4825 (revalidate_region_cache, know_region_cache, region_cache_forward)
4826 (region_cache_backward, pp_cache):
4827 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4828 so that ptrdiff_t * can be passed to xpalloc.
4829 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4830 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4831 (pp_cache): Don't assume cache_len fits in int.
4832 * region-cache.h: Adjust extern decls to match.
4833
4834 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4835 EMACS_INT, since either will do, for xpalloc.
4836
4837 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4838 (xnmalloc, xnrealloc, xpalloc): New functions.
4839
726e0ab1
PE
4840 * bidi.c (bidi_shelve_header_size): New constant.
4841 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4842 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4843
51f30bc5 4844 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4845 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4846 (overlay_strings):
4847 Don't update size of array until after memory allocation succeeds,
4848 because xmalloc/xrealloc may not return.
0065d054
PE
4849 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4850 now that we have proper integer overflow checking.
4851 (record_overlay_string, overlay_strings): Catch overflows when
4852 calculating size of overlay_str_buf.
726e0ab1 4853
0065d054
PE
4854 * callproc.c (Fcall_process): Check for size overflow when
4855 calculating size of args2.
4856 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4857 Normally we prefer signed values, but sticking with ptrdiff_t would
4858 require adding more-complicated checks.
726e0ab1
PE
4859
4860 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4861 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4862 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4863 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4864
4865 * character.c (Fstring): Check for size-calculation overflow.
4866
4867 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4868 unnecessary integer overflow. Check for size overflow.
4869 (encode_coding_object): Don't update size until xmalloc succeeds.
4870
4871 * composite.c (get_composition_id): Check for overflow in glyph
4872 length calculations.
4873
4874 Integer and memory overflow fixes for display code.
4875 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4876 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4877 (scrolling_window): Check for overflow in size calculations.
4878 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4879 Don't assume glyph table len fits in int.
4880 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4881 (row_table_size): Now ptrdiff_t, not int.
4882 (scrolling_window): Avoid overflow in size calculations.
4883 Don't update size until allocation succeeds.
4884 * fns.c (concat): Check for overflow in size calculations.
4885 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4886 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4887 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4888
4889 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4890 (get_doc_string): Check for size calculation overflow.
4891 Don't update size until allocation succeeds.
4892 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4893 EMACS_INT, where ptrdiff_t will do.
4894 (Fsubstitute_command_keys): Check for string overflow.
4895
4896 * editfns.c (set_time_zone_rule): Don't assume environment length
4897 fits in int.
4898 (message_length): Now ptrdiff_t, not int.
4899 (Fmessage_box): Don't update size until allocation succeeds.
4900 Don't assume message length fits in int.
4901 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4902
0065d054
PE
4903 * emacs.c (main): Do not reallocate argv, since there is a null at
4904 the end that can be overwritten, and this way there's no need to
4905 worry about size-calculation overflow.
4906 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4907
4908 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4909 alloc succeeds.
4910 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4911
4912 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4913 (x_set_scroll_bar_width, x_figure_window_size):
4914 Check for integer overflow.
4915 (x_set_alpha): Do not assume XINT fits in int.
4916
4917 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4918 This is for the members text_lines, text_cols, total_lines, total_cols,
4919 where the system imposes an 'int' limit.
4920
4921 * fringe.c (Fdefine_fringe_bitmap):
4922 Don't update size until alloc works.
4923
4924 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4925 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4926
4927 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4928 Check for size-calculation overflow.
4929 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4930 do, as we prefer signed integers.
4931 (id_to_widget.max_size, id_to_widget.used)
4932 (xg_store_widget_in_map, xg_remove_widget_from_map)
4933 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4934 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4935 Use and return ptrdiff_t, not int.
4936 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4937 * gtkutil.h: Change prototypes to match the above.
4938
4939 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4940 are duplicate now that they've been promoted to lisp.h.
4941 (x_allocate_bitmap_record, x_alloc_image_color)
4942 (make_image_cache, cache_image, xpm_load):
4943 Don't update size until alloc is done.
4944 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4945 (x_detect_edges):
3256efce 4946 Check for size calculation overflow.
726e0ab1
PE
4947 (ct_colors_allocated_max): New constant.
4948 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4949 overflow.
3256efce 4950
726e0ab1
PE
4951 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4952 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4953 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4954 Use ptrdiff_t, not int, to count maps.
4955 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4956 calculations. Don't update size until allocation succeeds.
4957 Redo calculations to avoid overflow.
726e0ab1
PE
4958 * keyboard.h: Change prototypes to match the above.
4959
4960 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4961 to count maps.
4962 (current_minor_maps): Check for size calculation overflow.
4963 * keymap.h: Change prototypes to match the above.
4964
4965 * lread.c (read1, init_obarray): Don't update size until alloc done.
4966
4967 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4968 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4969
726e0ab1
PE
4970 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4971 Now ptrdiff_t, not int.
4972 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4973 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4974
4975 * process.c (Fnetwork_interface_list): Check for overflow
4976 in size calculation.
4977
4978 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4979
4980 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4981 overflow. Don't bother calling xmalloc when xrealloc will do.
4982
4983 * search.c (Freplace_match): Check for size calculation overflow.
4984 (Fset_match_data): Don't assume list lengths fit in 'int'.
4985
4986 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4987 for command line length. Do not attempt to address one before the
4988 beginning of an array, as that's not portable.
4989
4990 * term.c (max_frame_lines): Remove; unused.
4991 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4992 not int.
4993 (encode_terminal_code, calculate_costs): Check for size
4994 calculation overflow.
4995 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4996 table lengths and related sizes. Don't update size until alloc
4997 done. Redo calculations to avoid overflow.
4998 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4999
5000 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5001 subtracting pointers.
5002 (gobble_line): Check for overflow more carefully. Don't update size
5003 until alloc done.
5004
5005 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5006 Don't update size until alloc done.
5007 Redo size calculations to avoid overflow.
5008 Check for size calculation overflow.
0065d054 5009 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5010
5011 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5012 Use ptrdiff_t, not int, for sizes.
5013 (store_mode_line_noprop_char): Don't update size until alloc done.
5014
0065d054
PE
5015 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5016 Use ptrdiff_t, not int, for sizes.
5017 (Finternal_make_lisp_face, cache_face):
5018 Check for size calculation overflow.
5019 (cache_face): Treat size calculation overflows as if they were
5020 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5021
5022 * xfns.c (x_encode_text, x_set_name_internal)
5023 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5024 sizes, since they can exceed INT_MAX in size. Check for size
5025 calculation overflow.
5026
0065d054
PE
5027 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5028 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5029 Don't update size until alloc done.
5030
0065d054 5031 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5032 as sprintf is limited to int lengths.
1d526e2f 5033
252c5ee1
PE
5034 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5035 (X_LONG_MIN): New macros.
864d7ce7
PE
5036 Use them to make the following changes clearer.
5037 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5038 This change doesn't affect the value now, but it may help remind
5039 future maintainers not to raise the value too much later.
5040 (SELECTION_QUANTUM): Remove, replacing with ...
5041 (selection_quantum): ... new function, which avoids overflow.
5042 All uses changed.
5043 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5044 assumption that selection length fits in 'int'.
5045 (x_reply_selection_request, x_handle_selection_request)
5046 (x_get_window_property, receive_incremental_selection)
5047 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5048 (lisp_data_to_selection_data, clean_local_selection_data):
5049 Use ptrdiff_t, not int, to record length of selection.
5050 (x_reply_selection_request, x_get_window_property)
5051 (receive_incremental_selection, x_property_data_to_lisp):
5052 Redo calculations to avoid overflow.
5053 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5054 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5055 something.
5056 (x_get_window_property, receive_incremental_selection)
5057 (lisp_data_to_selection_data, x_property_data_to_lisp):
5058 Check for size-calculation overflow.
5059 (x_get_window_property, receive_incremental_selection)
5060 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5061 Don't store size until memory allocation succeeds.
5062 (x_get_window_property): Plug memory leak on memory exhaustion.
5063 Don't double-block input; malloc is safe here. Don't assume 2**34
5064 - 4 fits in unsigned long. Add an xassert to check
5065 XGetWindowProperty overflow. Be more careful about overflow
5066 calculations, and distinguish size from memory overflow better.
5067 (receive_incremental_selection): When tracing, don't assume
5068 unsigned int is less than INT_MAX.
5069 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5070 harmful) conversions of unsigned short to int.
5071 (lisp_data_to_selection_data): Don't assume that integers
5072 in the range -65535 through -1 fit in an X unsigned short.
5073 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5074 result parameters unless successful. Rely on cons_to_unsigned
5075 to report problems with elements; the old code wasn't right anyway.
5076 (x_check_property_data): Check for int overflow; we cannot use
5077 a wider type due to X limits.
5078 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5079
726e0ab1 5080 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5081
0065d054
PE
5082 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5083 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5084 (x_color_cells): Don't store size until memory allocation succeeds.
5085 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5086 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5087 (x_term_init): Don't assume length fits in int (sprintf is limited
5088 to int size).
bc18e09d 5089
ebfa62c0
PE
5090 Use ptrdiff_t for composition IDs.
5091 * character.c (lisp_string_width):
5092 * composite.c (composition_table_size, n_compositions)
5093 (get_composition_id, composition_gstring_from_id):
5094 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5095 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5096 * window.c (Frecenter):
5097 Use ptrdiff_t, not int, for composition IDs.
5098 * composite.c (get_composition_id): Check for integer overflow.
5099 * composite.h: Adjust prototypes to match the above changes.
5100
d3411f89
PE
5101 Use ptrdiff_t for hash table indexes.
5102 * category.c (hash_get_category_set):
5103 * ccl.c (ccl_driver):
5104 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5105 * coding.c (coding_system_charset_list, detect_coding_system):
5106 * coding.h (struct coding_system.id):
5107 * composite.c (get_composition_id, gstring_lookup_cache):
5108 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5109 * image.c (xpm_get_color_table_h):
5110 * lisp.h (hash_lookup, hash_put):
5111 * minibuf.c (Ftest_completion):
5112 Use ptrdiff_t for hash table indexes, not int (which is too
5113 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5114 32-bit --with-wide-int hosts).
5115
e097a6fa
PE
5116 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5117 Add a FIXME comment about memory leaks.
5118 (syms_of_charset): Don't assume xmalloc returns.
5119
5637687f
PE
5120 Don't assume that stated character widths fit in int.
5121 * character.c (Fchar_width, c_string_width, lisp_string_width):
5122 * character.h (CHAR_WIDTH):
5123 * indent.c (MULTIBYTE_BYTES_WIDTH):
5124 Use sanitize_char_width to avoid undefined and/or bad behavior
5125 with outlandish widths.
a66cfb1c 5126 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5127 now that we have two such functions. All uses changed.
5128 (sanitize_char_width): New inline function.
5129
a2271ba2
PE
5130 Don't assume that tab-width fits in int.
5131 * character.h (sanitize_width): New inline function.
5132 (SANE_TAB_WIDTH): New macro.
5133 (ASCII_CHAR_WIDTH): Use it.
5134 * indent.c (sane_tab_width): Remove. All uses replaced by
5135 SANE_TAB_WIDTH (current_buffer).
5136 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5137
18c52557
PE
5138 * fileio.c: Integer overflow issues with file modes.
5139 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5140
caeeedc1
PE
5141 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5142 Remove unreachable code.
5143 (read_hex, load_charset_map_from_file): Check for integer overflow.
5144
6df6ae42 5145 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5146 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5147 (x_send_scroll_bar_event): Likewise. Check that the size does not
5148 exceed limits imposed by XClientMessageEvent, as well as the usual
5149 ptrdiff_t and size_t limits.
5150
b13995db
PE
5151 * keyboard.c: Overflow, signedness and related fixes.
5152 (make_lispy_movement): Use same integer type in forward decl
5153 that is used in the definition.
5154 (read_key_sequence, keyremap_step):
5155 Change bufsize argument back to int, undoing my 2011-03-30 change.
5156 We prefer signed types, and int is wide enough here.
5157 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5158 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5159 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5160 length, not size_t. Use ptrdiff_t for index, not int.
5161 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5162 possibility of integer overflow.
5163
13464394
PE
5164 Overflow, signedness and related fixes for images.
5165
5166 * dispextern.h (struct it.stack[0].u.image.image_id)
5167 (struct_it.image_id, struct image.id, struct image_cache.size)
5168 (struct image_cache.used, struct image_cache.ref_count):
5169 * gtkutil.c (update_frame_tool_bar):
5170 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5171 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5172 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5173 * nsmenu.m (update_frame_tool_bar):
5174 * xdisp.c (calc_pixel_width_or_height):
5175 * xfns.c (image_cache_refcount):
5176 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5177 on typical 64-bit hosts.
5178
5179 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5180 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5181 Omit unnecessary casts to int.
5182 (parse_image_spec): Check that integers fall into 'int' range
5183 when the callers expect that.
5184 (image_ascent): Redo ascent calculation to avoid int overflow.
5185 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5186 (lookup_image): Remove unnecessary tests.
5187 (xbm_image_p): Locals are now of int, not EMACS_INT,
5188 since parse_image_check makes sure they fit into int.
5189 (png_load, gif_load, svg_load_image):
5190 Prefer int to unsigned where either will do.
5191 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5192 old tiff_error_handler and tiff_warning_handler.
5193 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5194 stack buffer overflows. It uses only the features of vsnprintf
5195 that are common to both POSIX and native Microsoft.
5196 (tiff_error_handler, tiff_warning_handler): Use it.
5197 (tiff_load, gif_load, imagemagick_load_image):
5198 Don't assume :index value fits in 'int'.
5199 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5200 (imagemagick_load_image): Check that crop parameters fit into
5201 the integer types that MagickCropImage accepts. Don't assume
5202 Vimagemagick_render_type has a nonnegative value. Don't assume
5203 size_t fits in 'long'.
5204 (gs_load): Use printmax_t to print the widest integers possible.
5205 Check for integer overflow when computing image height and width.
5206
c11821d4
EZ
52072011-08-26 Eli Zaretskii <eliz@gnu.org>
5208
5209 * xdisp.c (redisplay_window): Don't force window start if point
5210 will be invisible in the resulting window. (Bug#9324)
5211
0c95fcf7
EZ
52122011-08-25 Eli Zaretskii <eliz@gnu.org>
5213
5214 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5215 the display spec is of the form `(space ...)'.
5216 (handle_display_spec): Return the value returned by
5217 handle_single_display_spec, not just 1 or zero.
5218 (handle_single_display_spec): If the display spec is of the form
5219 `(space ...)', and specifies display in the text area, return 2
5220 rather than 1.
fee65a97 5221 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5222 accurately, and prefer exact match for point under bidi.
5223 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5224
5225 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5226 into disp_prop; all users changed.
5227
5228 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5229 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5230 for the text covered by the display property.
5231
e4ed06f1
CY
52322011-08-25 Chong Yidong <cyd@stupidchicken.com>
5233
5234 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5235 Change return value to nil.
5236 (Frecord_buffer): Delete unused function.
5237
f67cdd7f
EZ
52382011-08-24 Eli Zaretskii <eliz@gnu.org>
5239
5980d4c6
EZ
5240 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5241 buffers, return left-to-right.
8610fe8b
EZ
5242 (set_cursor_from_row): Consider candidate row a win if its glyph
5243 represents a newline and point is on that newline. Fixes cursor
5244 positioning on the newline at EOL of R2L text within L2R
5245 paragraph, and vice versa.
5246 (try_cursor_movement): Check continued rows, in addition to
5247 continuation rows. Fixes unwarranted scroll when point enters a
5248 continued line of R2L text within an L2R paragraph, or vice versa.
5249 (cursor_row_p): Consider the case of point being equal to
5250 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5251 from the end of a short line to the beginning of a continued line
5252 of R2L text within L2R paragraph.
5253 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5254 composed characters.
5980d4c6 5255
f67cdd7f
EZ
5256 * bidi.c (bidi_check_type): Use xassert.
5257 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5258 members.
5259
bca633fb
EZ
52602011-08-23 Eli Zaretskii <eliz@gnu.org>
5261
5262 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5263 a character.
5264
4a5885a7
CY
52652011-08-23 Chong Yidong <cyd@stupidchicken.com>
5266
5267 * nsfont.m (ns_otf_to_script): Fix typo.
5268
0902a04e
KH
52692011-08-22 Kenichi Handa <handa@m17n.org>
5270
5271 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5272 extra slot even if the purpose is char-code-property-table.
5273
1a2e6670
EZ
52742011-08-23 Eli Zaretskii <eliz@gnu.org>
5275
8ddde651
EZ
5276 * xdisp.c (redisplay_window): When computing centering_position,
5277 account for the height of the header line. (Bug#8874)
5278
425cc014
EZ
5279 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5280 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5281 candidate is selected by the mouse, and that candidate has a
5282 composed character under the mouse.
5283
1a2e6670
EZ
5284 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5285 coordinates reported by pos-visible-in-window-p for a composed
5286 character in column zero.
5287
8b76d6f8
SM
52882011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5289
5290 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5291
dac347dd
EZ
52922011-08-22 Eli Zaretskii <eliz@gnu.org>
5293
5294 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5295 consider it a hit if to_charpos is anywhere in the range of the
5296 composed buffer positions.
5297
e013fb34
CY
52982011-08-22 Chong Yidong <cyd@stupidchicken.com>
5299
5300 * image.c (gif_load): Don't assume that each subimage has the same
5301 dimensions as the base image. Handle disposal method that is
5302 "undefined" by the gif spec (Bug#9335).
5303
bd1ba3e8
CY
53042011-08-20 Chong Yidong <cyd@stupidchicken.com>
5305
5306 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5307 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5308
54a1215b
EZ
53092011-08-19 Eli Zaretskii <eliz@gnu.org>
5310
823564e5
EZ
5311 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5312 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5313 from an Org mode buffer to a Speedbar frame.
5314
54a1215b
EZ
5315 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5316 a composition, take its buffer position from IT->cmp_it.charpos.
5317 Fixes cursor positioning at the beginning of a line that begins
5318 with a composed character.
5319
9778ebcc
EZ
53202011-08-18 Eli Zaretskii <eliz@gnu.org>
5321
0be6ee06
EZ
5322 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5323 character bidirectional type, use STRONG_L instead. Fixes crashes
5324 in a buffer produced by `describe-categories'.
5325
9778ebcc
EZ
5326 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5327 members before the level stack, so they would be saved and
5328 restored when copying iterator state. Fixes incorrect reordering
5329 around TABs covered by display properties.
5330
156bffbe
AS
53312011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5332
6b02f655 5333 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5334
72ad093b
CY
53352011-08-17 Chong Yidong <cyd@stupidchicken.com>
5336
5337 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5338 (internal_condition_case_2, internal_condition_case_n):
5339 Remove unnecessary aborts (Bug#9081).
72ad093b 5340
35774242
EZ
53412011-08-17 Eli Zaretskii <eliz@gnu.org>
5342
5343 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5344 has no `load' handler, try opening the file locally. (Bug#9311)
5345
db76dd85
KB
53462011-08-16 Ken Brown <kbrown@cornell.edu>
5347
5348 * gmalloc.c: Expand comment.
5349
b215eee5
EZ
53502011-08-16 Eli Zaretskii <eliz@gnu.org>
5351
5352 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5353 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5354
a4579d33
KB
53552011-08-16 Ken Brown <kbrown@cornell.edu>
5356
5357 Fix memory allocation problems in Cygwin build (Bug#9273).
5358
5359 * unexcw.c ( __malloc_initialized): Declare external variable.
5360 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5361
8b76d6f8
SM
5362 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5363 New variables.
a4579d33
KB
5364 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5365 dumped emacs.
5366 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5367 in the static heap.
5368 [CYGWIN] (special_realloc): New function.
5369 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5370 requests to realloc storage in the static heap.
5371
3ebec551
PE
53722011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5373
5374 * bidi.c (bidi_initialize): Remove unused local.
5375
9fd8be00
EZ
53762011-08-15 Eli Zaretskii <eliz@gnu.org>
5377
6b02f655
SM
5378 * bidimirror.h:
5379 * biditype.h: Remove file.
5380 * makefile.w32-in ($(BLD)/bidi.$(O)):
5381 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5382
5383 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5384
5385 * chartab.c: Improve commentary for the uniprop_table API.
5386
32413314
EZ
5387 * bidi.c (bidi_paragraph_init): Support zero value of
5388 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5389 (bidi_initialize): Use uniprop_table instead of including
5390 biditype.h and bidimirror.h.
32413314 5391
9fd8be00
EZ
5392 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5393 coordinates of the iterator when restoring from ppos_it.
5394 (Bug#9296)
5395
5cf2b69b
KH
53962011-08-14 Kenichi Handa <handa@m17n.org>
5397
5398 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5399 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5400
daf17d00
EZ
54012011-08-14 Eli Zaretskii <eliz@gnu.org>
5402
5403 * xdisp.c (move_it_in_display_line_to): Don't invoke
5404 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5405 ppos_it. Fixes vertical cursor motion when line beginning is
5406 covered by an image. (Bug#9296)
5407
08e3161a
JD
54082011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5409
5410 * nsterm.h (ns_run_ascript): Declare.
5411 (NSAPP_DATA2_RUNASSCRIPT): Define.
5412
5413 * nsfns.m (as_script, as_result, as_status): New static variables.
5414 (ns_run_ascript): New function.
5e617bc2 5415 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5416 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5417 the event loop. Get status from as_status (Bug#7276).
5418
5419 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5420 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5421 the event loop (Bug#7276).
5422
a3720aa2
AS
54232011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5424
5425 * gnutls.c (QCgnutls_bootprop_priority)
5426 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5427 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5428 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5429 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5430 (QCgnutls_bootprop_verify_hostname_error)
5431 (QCgnutls_bootprop_callbacks_verify): Rename from
5432 Qgnutls_bootprop_..., all uses changed.
5433
5434 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5435 uses changed.
5436
0a0d27fb
PE
54372011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5438
19d5c50c
PE
5439 * xfaces.c (Qframe_set_background_mode): Now static.
5440 * dispextern.h (Qframe_set_background_mode): Remove decl.
5441
0a0d27fb
PE
5442 * process.c (Fnetwork_interface_info): Declare local only if needed.
5443
377538cb
JD
54442011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5445
5446 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5447 (Fnetwork_interface_list): Allocate in increments of bytes instead
5448 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5449 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5450 sockaddr.
5451 (struct ifflag_def): notrailers is smart on OSX.
5452 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5453 Get hardware address with getifaddrs if available.
5454
08fff70c
EZ
54552011-08-12 Eli Zaretskii <eliz@gnu.org>
5456
5457 * xdisp.c (iterate_out_of_display_property): xassert that
5458 IT->position is set to within IT->object's boundaries. Break from
5459 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5460 when IT->position is set up wrongly due to some bug.
5461 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5462 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5463 entry. Force push_it to save on the stack the current
5464 buffer/string position, to be restored by pop_it. Fix flags in
5465 the iterator structure wrt the object coming from a display
5466 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5467 properties. (Bug#9284)
5468
7be1c708 54692011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5470
7be1c708
CY
5471 * fontset.c (fontset_get_font_group): Add proper type checks.
5472 (Bug#9172)
aac0c6e3 5473
7be1c708 54742011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5475
7be1c708
CY
5476 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5477 and LC_VERSION_MIN_MACOSX.
5478 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5479 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5480
97bb72a6
EZ
54812011-08-08 Eli Zaretskii <eliz@gnu.org>
5482
5483 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5484 no-display-properties-and-no-overlays under bidi display.
5485 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5486 properties and overlays.
97bb72a6 5487
d5617611
CY
54882011-08-08 Chong Yidong <cyd@stupidchicken.com>
5489
37e11a63
CY
5490 * editfns.c (Fset_time_zone_rule): Document relationship with the
5491 setenv function.
5492
d5617611
CY
5493 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5494 the font entity extracted from the cache (Bug#8109).
5495
58872834
CY
54962011-08-07 Chong Yidong <cyd@stupidchicken.com>
5497
5498 * composite.c (autocmp_chars): Don't reset point. That is done by
5499 restore_point_unwind (Bug#5984).
5500
75bfc667
JL
55012011-08-07 Juri Linkov <juri@jurta.org>
5502
5503 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5504 to show the arg `TIME' instead of `TIMEVAL'.
5505
d1410150
EZ
55062011-08-06 Eli Zaretskii <eliz@gnu.org>
5507
5508 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5509 display property strides EOL and includes a newline, as in
5510 longlines-mode. (Bug#9254)
75b771e4
EZ
5511 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5512 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5513
5514 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5515 is non-zero, even if the data buffer is NULL. Fixes a crash in
5516 vertical-motion with longlines-mode. (Bug#9254)
5517
35928349
EZ
55182011-08-05 Eli Zaretskii <eliz@gnu.org>
5519
ec7cc85b
EZ
5520 * bidi.c <bidi_cache_total_alloc>: Now static.
5521 (bidi_initialize): Initialize bidi_cache_total_alloc.
5522
8b76d6f8 5523 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5524 cache. (Bug#9221)
5525
5526 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5527 amount allocated this far in `bidi_cache_total_alloc'.
5528 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5529 non-zero, only free the data buffer without restoring the cache
5530 contents. All callers changed.
5531
5532 * dispextern.h (bidi_unshelve_cache): Update prototype.
5533
5534 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5535 (move_it_in_display_line, move_it_to)
5536 (move_it_vertically_backward, move_it_by_lines): Replace the call
5537 to xfree to an equivalent call to bidi_unshelve_cache.
5538 (move_it_in_display_line_to): Fix logic of returning
412b6358 5539 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5540
e2e2423b
EZ
55412011-08-05 Eli Zaretskii <eliz@gnu.org>
5542
5543 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5544 came from a string character with a `cursor' property. (Bug#9229)
5545
ae9e757a
JD
55462011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5547
5548 * Makefile.in (LIB_PTHREAD): New variable.
5549 (LIBES): Add LIB_PTHREAD (Bug#9216).
5550
5551 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5552 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5553
213bd7f2
AS
55542011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5555
6b02f655 5556 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5557
99aaf75f
JD
55582011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5559
5560 * xterm.c (x_find_topmost_parent): New function.
5561 (x_set_frame_alpha): Find topmost parent window with
5562 x_find_topmost_parent and set the property there also (bug#9181).
5563 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5564
c74e9d86
PE
55652011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5566
5567 * callproc.c (Fcall_process): Avoid vfork clobbering
5568 the local vars buffer, coding_systems, current_dir.
5569
640c8776
SM
55702011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5571
5572 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5573
f26d0e4c
PE
55742011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5575
8a10d76c
PE
5576 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5577 so that it is not optimized away.
5578
f26d0e4c
PE
5579 * xdisp.c (compute_display_string_pos): Remove unused local.
5580
55439c61
EZ
55812011-08-02 Eli Zaretskii <eliz@gnu.org>
5582
5583 Fix slow cursor motion and scrolling in large buffers with
5584 selective display, like Org Mode buffers. (Bug#9218)
5585
5586 * dispextern.h (struct bidi_it): New member disp_prop_p.
5587
5588 * xdisp.c: Remove one-slot cache of display string positions.
5589 (compute_display_string_pos): Accept an additional argument
5e617bc2 5590 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5591 for a display string or property. If found, set DISP_PROP_P
5592 non-zero.
5593
5594 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5595 DISP_PROP_P, and pass it to compute_display_string_pos.
5596 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5597 non-zero. All callers of bidi_fetch_char changed.
5598
fb33fa43
SM
55992011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5600
5601 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5602
b099e063
DM
56032010-12-03 Don March <don@ohspite.net>
5604
5605 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5606 last character M-[char] is translated to ESC [char] (bug#7541).
5607
5cc7f7af
KH
56082011-08-02 Kenichi Handa <handa@m17n.org>
5609
d0fffa3f 5610 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5611
5612 * chartab.c (uniprop_table): Make it non-static.
5613
525d5e6e
EZ
56142011-08-01 Eli Zaretskii <eliz@gnu.org>
5615
5616 * xdisp.c (forward_to_next_line_start): Accept additional argument
5617 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5618 on the newline.
5619 (reseat_at_next_visible_line_start): Use the bidi iterator state
5620 returned by forward_to_next_line_start to restore the state of
5621 it->bidi_it after backing up to previous newline. (Bug#9212)
5622
31011111
AS
56232011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5624
5625 * regex.c (re_comp): Protoize.
5626 (re_exec): Fix return type.
5627 (regexec): Fix type of `ret'. (Bug#9203)
5628
476371c4
PE
56292011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5630
e5d76069
PE
5631 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5632 This is needed if max-image-size is a floating-point number.
5633
9a79b20c
AS
56342011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5635
5636 * print.c (print_object): Print empty symbol as ##.
5637
5638 * lread.c (read1): Read ## as empty symbol.
5639
d8c2fa78
AA
56402011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5641
5642 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5643 setting frame foreground color (Bug#9175).
5644 (x_set_background_color): Likewise.
5645
ffe57a7a
AA
5646 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5647 contents (Bug#9176).
5648 (EmacsTooltip -init): Remove bezels and add shadows to
5649 tooltip windows.
5650
bf3492a5
AA
5651 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5652 or scroll bar (Bug#8470).
5653
d55e9c53
AA
5654 * nsfont.m (nsfont_open): Remove assignment to voffset and
5655 unnecessary vars hshink, expand, hd, full_height, min_height.
5656 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5657
5658 * nsterm.h (nsfont_info): Remove voffset field.
5659
d8c2fa78 56602011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5661
5662 Implement strike-through and overline on NextStep (Bug#8863).
5663
5664 * nsfont.m (nsfont_open): Use underline position provided by font,
5665 instead of hard-coded value of 2.
5666 (nsfont_draw): Call ns_draw_text_decoration instead.
5667
5668 * nsterm.h: Add declaration for ns_draw_text_decoration.
5669
5670 * nsterm.m (ns_draw_text_decoration): New function for drawing
5671 underline, overline, and strike-through.
5672 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5673 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5674 accommodate underlining, etc.
4843aac3 5675
4cc60b9b
EZ
56762011-07-28 Eli Zaretskii <eliz@gnu.org>
5677
bc7ece87
EZ
5678 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5679 default.
4cc60b9b 5680
476371c4
PE
56812011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5682
66606eea
PE
5683 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5684 Without this fix, if a signal arrives just after memory fills up,
5685 'malloc' might be invoked reentrantly.
5686
476371c4
PE
5687 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5688 In other words, assume that every image size is allowed, on non-X
5689 hosts. This assumption is probably wrong, but it lets Emacs compile.
5690
f3fcc40d
AS
56912011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5692
5693 * regex.c (re_iswctype): Convert return values to boolean.
5694
350c992f
EZ
56952011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5696
5697 * xdisp.c (compute_display_string_pos): Don't use cached display
5698 string position if the buffer had its restriction changed.
5699 (Bug#9184)
5700
5266b4bb
PE
57012011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5702
5703 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5704
2573a837 57052011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5706
41f55ccd 5707 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5708
39e378da
PE
5709 * bidi.c: Integer size and overflow fixes.
5710 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5711 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5712 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5713 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5714 (bidi_find_other_level_edge):
5715 Use ptrdiff_t instead of EMACS_INT where either will do.
5716 This works better on 32-bit hosts configured --with-wide-int.
5717 (bidi_cache_ensure_space): Check for size-calculation overflow.
5718 Use % rather than repeated addition, for better worst-case speed.
5719 Don't set bidi_cache_size until after xrealloc returns, because it
5720 might not return.
5721 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5722 (bidi_cache_ensure_space): Also check that the bidi cache size
5723 does not exceed that of the largest Lisp string or buffer. See Eli
5724 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5725
5e927815
PE
5726 * alloc.c (__malloc_size_t): Remove.
5727 All uses replaced by size_t. See Andreas Schwab's note
5728 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5729
ca4aa935
PE
5730 * image.c: Improve checking for integer overflow.
5731 (check_image_size): Assume that f is nonnull, since
5732 it is always nonnull in practice. This is one less thing to
5733 worry about when checking for integer overflow later.
5734 (x_check_image_size): New function, which checks for integer
5735 overflow issues inside X.
5736 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5737 This removes the need for a memory_full check.
5738 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5739 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5740 (xbm_read_bitmap_data): Change locals back to 'int', since
5741 their values must fit in 'int'.
5742 (xpm_load_image, png_load, tiff_load):
5743 Invoke x_create_x_image_and_pixmap earlier,
5744 to avoid much needless work if the image is too large.
5745 (tiff_load): Treat overly large images as if
5746 x_create_x_image_and_pixmap failed, not as malloc failures.
5747 (gs_load): Use x_check_image_size.
5748
5f8f9cc2
PE
5749 * gtkutil.c: Omit integer casts.
5750 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5751 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5752
5adf60bc
PE
5753 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5754
c8907a93
PE
5755 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5756 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5757 would wrongly return t on a 64-bit host.
5758
e3c25c68
PE
5759 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5760 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5761 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5762 and therefore cause GCC to emit a bogus diagnostic in some cases.
5763
3f791afe
PE
5764 * image.c: Integer signedness and overflow and related fixes.
5765 This is not an exhaustive set of fixes, but it's time to
5766 record what I've got.
5767 (lookup_pixel_color, check_image_size): Remove redundant decls.
5768 (check_image_size): Don't assume that arbitrary EMACS_INT values
5769 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5770 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5771 (tiff_load, imagemagick_load_image):
5772 Check for overflow in size calculations.
5773 (x_create_x_image_and_pixmap): Remove unnecessary test for
5774 xmalloc returning NULL; that can't happen.
5775 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5776 (xpm_color_bucket): Use better integer hashing function.
5777 (xpm_cache_color): Don't possibly over-allocate memory.
5778 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5779 (gif_memory_source):
5780 Use ptrdiff_t, not int or size_t, to record sizes.
5781 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5782 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5783 either works, as we prefer signed integers.
5784 (tiff_read_from_memory, tiff_write_from_memory):
5785 Return tsize_t, not size_t, since that's what the TIFF API wants.
5786 (tiff_read_from_memory): Don't fail simply because the read would
5787 go past EOF; instead, return a short read.
5788 (tiff_load): Omit no-longer-needed casts.
5789 (Fimagemagick_types): Don't assume size fits into 'int'.
5790
3cc5a532
PE
5791 Improve hashing quality when configured --with-wide-int.
5792 * fns.c (hash_string): New function, taken from sxhash_string.
5793 Do not discard information about ASCII character case; this
5794 discarding is no longer needed.
5795 (sxhash-string): Use it. Change sig to match it. Caller changed.
5796 * lisp.h: Declare it.
5797 * lread.c (hash_string): Remove, since we now use fns.c's version.
5798 The fns.c version returns a wider integer if --with-wide-int is
5799 specified, so this should help the quality of the hashing a bit.
5800
b312a492
PE
5801 * emacs.c: Integer overflow minor fix.
5802 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5803 Define only if GNU_LINUX.
5804 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5805
dfd153ae
PE
5806 * dispnew.c: Integer signedness and overflow fixes.
5807 Remove unnecessary forward decls, that were a maintenance hassle.
5808 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5809 All uses changed.
5810 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5811 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5812 (prepare_desired_row, line_draw_cost):
5813 Use int, not unsigned, where either works.
5814 (save_current_matrix, restore_current_matrix):
5815 Use ptrdiff_t, not size_t, where either works.
5816 (init_display): Check for overflow more accurately, and without
5817 relying on undefined behavior.
5818
a81d11a3
PE
5819 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5820 Remove, replacing with the new symbols in lisp.h. All uses changed.
5821 * fileio.c (make_temp_name):
5822 * filelock.c (lock_file_1, lock_file):
5823 * xdisp.c (message_dolog):
5824 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5825 Use pMd etc. instead.
5826 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5827 replacing the pWIDE etc. symbols removed from editfns.c.
5828
3300e6fd
PE
5829 * keyboard.h (num_input_events): Now uintmax_t.
5830 This is (very slightly) less likely to mess up due to wraparound.
5831 All uses changed.
5832
fd05c7e9
PE
5833 * buffer.c: Integer signedness fixes.
5834 (alloc_buffer_text, enlarge_buffer_text):
5835 Use ptrdiff_t rather than size_t when either will do, as we prefer
5836 signed integers.
5837
903fe15d
PE
5838 * alloc.c: Integer signedness and overflow fixes.
5839 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5840 (__malloc_size_t): Default to size_t, not to int.
5841 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5842 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5843 Prefer ptrdiff_t to size_t when either would do, as we prefer
5844 signed integers.
5845 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5846 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5847 Now const. Initialize with values that are in range even if char
5848 is signed.
5849 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5850 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5851 These functions do the right thing with sizes > 2**32.
5852 (check_depth): Now ptrdiff_t, not int.
5853 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5854 Adjust to new way of storing sizes. Check for size overflow bugs
5855 in rest of code.
5856 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5857 slightly wrong anyway, as it missed one instance of
5858 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5859 (refill_memory_reserve): Omit needless cast to size_t.
5860 (mark_object_loop_halt): Mark as externally visible.
5861
ac82cc6a
PE
5862 * xselect.c: Integer signedness and overflow fixes.
5863 (Fx_register_dnd_atom, x_handle_dnd_message):
5864 Use ptrdiff_t, not size_t, since we prefer signed.
5865 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5866 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5867 x_dnd_atoms_size and x_dnd_atoms_length.
5868
c2d1e36d
PE
5869 * doprnt.c: Prefer signed to unsigned when either works.
5870 * eval.c (verror):
5871 * doprnt.c (doprnt):
5872 * lisp.h (doprnt):
5873 * xdisp.c (vmessage):
5874 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5875 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5876 prefer signed arithmetic to avoid comparison confusion.
5877 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5878 but is a bit tricky.
5879
0e926e56
PE
5880 Assume freestanding C89 headers, string.h, stdlib.h.
5881 * data.c, doprnt.c, floatfns.c, print.c:
5882 Include float.h unconditionally.
5883 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5884 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5885 * regex.c: Likewise for stddef.h, string.h.
5886 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5887 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5888 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5889 (STDC_HEADERS): Remove obsolete defines.
5890 * sysdep.c: Include limits.h unconditionally.
5891
9cfdb3ec
PE
5892 Assume support for memcmp, memcpy, memmove, memset.
5893 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5894 * regex.c (memcmp, memcpy):
5895 Remove; we assume C89 now.
5896
5897 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5898 (__malloc_safe_bcopy): Remove; no longer needed.
5899
cf950e6b 5900 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5901 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5902 well either way, and we prefer signed to unsigned.
5903
dbf38e02
LMI
59042011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5905
5906 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5907 closes the connection while we're reading (bug#9182).
5908
d6f0886c 59092011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5910
d6f0886c
JD
5911 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5912 are specified (Bug#9168).
24e0f6b1 5913
2eb1f9e6
PE
59142011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5915
5916 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5917 Found by GCC static checking and --with-wide-int on a 32-bit host.
5918
22381272 59192011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5920
5921 * xdisp.c (compute_display_string_pos): Fix logic of caching
5922 previous display string position. Initialize cached_prev_pos to
5923 -1. Fixes slow-down at the beginning of a buffer.
5924
f25e39b4
EZ
59252011-07-24 Eli Zaretskii <eliz@gnu.org>
5926
5927 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5928 for attrs[LFACE_FONTSET_INDEX].
5929
04c4b52e
PE
59302011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5931
5932 * xml.c (parse_region): Remove unused local
5933 that was recently introduced.
5934
c1734fbd
EZ
59352011-07-23 Eli Zaretskii <eliz@gnu.org>
5936
be18c5a5
EZ
5937 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5938 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5939
c1734fbd
EZ
5940 * xdisp.c (move_it_in_display_line_to): Record the best matching
5941 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5942 exit if none of the characters scanned was an exact match.
5943 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5944 when exact match is impossible due to invisible text, and the
5945 lines are truncated.
5946
a258d627
JD
59472011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5948
5949 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5950 for OSX >= 10.7.
5951
b6d5a689
EZ
59522011-07-22 Eli Zaretskii <eliz@gnu.org>
5953
0f74f785
EZ
5954 Fix a significant slow-down of cursor motion with C-n, C-p,
5955 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5956 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5957 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5958 (next_element_from_buffer): Call compute_stop_pos_backwards to
5959 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5960 base_level_stop.
5961 (reseat): Don't look for prev_stop, as that could mean a very long
5962 run.
5963 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5964 <cached_disp_overlay_modiff>: Cache for last found display string
5965 position.
551918c1 5966 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5967 about the same buffer in the same area of character positions, and
5968 the buffer wasn't changed since the time the display string
5969 position was cached.
551918c1 5970
b2d0c91a
EZ
59712011-07-22 Eli Zaretskii <eliz@gnu.org>
5972
5973 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5974 is an integer, which is important for empty lines. (Bug#9149)
5975
043604ee
CY
59762011-07-22 Chong Yidong <cyd@stupidchicken.com>
5977
5978 * frame.c (Fmodify_frame_parameters): In tty case, update the
5979 default face if necessary (Bug#4238).
5980
da4adb04
CY
59812011-07-21 Chong Yidong <cyd@stupidchicken.com>
5982
5983 * editfns.c (Fstring_to_char): No need to explain what a character
5984 is in the docstring (Bug#6576).
5985
9abd0532
LMI
59862011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5987
5988 * xml.c (parse_region): Make sure we always return a tree.
5989
36881d16
HK
59902011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5991
5992 * xml.c (parse_region): If a document contains only comments,
5993 return that, too.
5994
1e98674d
LMI
59952011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5996
5997 * xml.c (make_dom): Return comments, too.
5998
590bd467
PE
59992011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6000
6001 Port to OpenBSD.
6002 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6003 and the surrounding thread.
6004 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6005 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6006 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6007 timer goes off.
6008 * s/openbsd.h (BROKEN_SIGIO): Define.
6009 * unexelf.c (unexec) [__OpenBSD__]:
6010 Don't update the .mdebug section of the Alpha COFF symbol table.
6011
f41628b2
LMI
60122011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6013
6014 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6015 (bug#8460).
6016
b59b67c5
PE
60172011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6018
15e3a074
PE
6019 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6020 This fixes some race conditions on the permissions of any newly
6021 created file.
6022
41bed37d
PE
6023 * alloc.c (valid_pointer_p): Use pipe, not open.
6024 This fixes some permissions issues when debugging.
6025
b59b67c5
PE
6026 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6027 If fchown fails to set both uid and gid, try to set just gid,
6028 as that is sometimes allowed. Adjust the file's mode to eliminate
6029 setuid or setgid bits that are inappropriate if fchown fails.
6030
925a6be7
SM
60312011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6032
6033 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6034 to compare Lisp_Objects.
6035 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6036 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6037 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6038
52968808
AS
60392011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6040
0a6a104b
AS
6041 * lread.c (read_integer): Unread even EOF character.
6042 (read1): Likewise. Properly record start position of symbol.
6043
52968808
AS
6044 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6045 symbol character follows.
6046
9e381cdd
PE
60472011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6048
6049 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6050 This works around a problem with the previous change to Fcopy_file.
6051 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6052 and without this change, GCC might complain about discarding
6053 fchown's return value.
6054
b5641435
JB
60552011-07-16 Juanma Barranquero <lekktu@gmail.com>
6056
6057 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6058
a8031457
PE
60592011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6060
6061 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6062
dd889327
LMI
60632011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6064
750c33f7
LMI
6065 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6066 it's used from the C level.
6067
dd889327
LMI
6068 * process.c: Use the same condition for POLL_FOR_INPUT in both
6069 keyboard.c and process.c (bug#1858).
6070
87e86684
LM
60712011-07-09 Lawrence Mitchell <wence@gmx.li>
6072
6073 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6074 (Fgnutls_boot): Use it.
6075
64348f40
AS
60762011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6077
6078 * doc.c (Fsubstitute_command_keys): Revert last change.
6079
1d698799
LMI
60802011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6081
f863868c
LMI
6082 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6083 quotes the next character, and doesn't affect other longer
6084 sequences (bug#8935).
6085
1d698799
LMI
6086 * lread.c (syms_of_lread): Clarify that is isn't only
6087 `eval-buffer' and `eval-defun' that's affected by
6088 `lexical-binding' (bug#8460).
6089
aa4b6df6
EZ
60902011-07-15 Eli Zaretskii <eliz@gnu.org>
6091
6092 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6093 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6094
5d856da6
PE
60952011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6096
ad6042bb
PE
6097 Fix minor problems found by static checking.
6098 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6099 (elsz): Now a signed constant, not a size_t var. We prefer signed
6100 types to unsigned, to avoid integer comparison confusion. Without
6101 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6102 "cannot optimize loop, the loop counter may overflow", a symptom
6103 of the confusion.
f00bbb22 6104 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6105 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6106
6468f31c
LMI
61072011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6108
49080b10
LMI
6109 * search.c (Fre_search_backward): Mention `case-fold-search' in
6110 all the re_search_* functions (bug#8138).
6111
6468f31c
LMI
6112 * keyboard.c (Fopen_dribble_file): Document when the file is
6113 closed (bug#8056).
6114
c965adc5
EZ
61152011-07-14 Eli Zaretskii <eliz@gnu.org>
6116
df9733bf
EZ
6117 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6118 bidi_cache_idx.
6119
0bb23927
EZ
6120 Support bidi reordering of display and overlay strings.
6121 * xdisp.c (compute_display_string_pos)
6122 (compute_display_string_end): Accept additional argument STRING.
6123 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6124 (reseat_to_string): Initialize bidi_it->string.s and
6125 bidi_it->string.schars.
6126 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6127 NULL (avoids a crash in bidi_paragraph_init).
6128 Initialize itb.string.lstring.
0bb23927
EZ
6129 (init_iterator): Call bidi_init_it only of a valid
6130 buffer position was specified. Initialize paragraph_embedding to
6131 L2R.
6132 (reseat_to_string): Initialize the bidi iterator.
6133 (display_string): If we need to ignore text properties of
6134 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6135 original value of -1 will not work with bidi.)
6136 (compute_display_string_pos): First arg is now struct
6137 `text_pos *'; all callers changed. Support display properties on
6138 Lisp strings.
6139 (compute_display_string_end): Support display properties on Lisp
6140 strings.
6141 (init_iterator, reseat_1, reseat_to_string): Initialize the
6142 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6143 when iterating on a string not from display properties).
640c8776
SM
6144 (compute_display_string_pos, compute_display_string_end):
6145 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6146 arrow keys.
6147 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6148 base_level_stop; instead, set base_level_stop to BEGV.
6149 Fixes crashes in vertical-motion.
0bb23927
EZ
6150 (next_element_from_buffer): Improve commentary for when
6151 the iterator is before prev_stop.
6152 (init_iterator): Initialize bidi_p from the default value of
6153 bidi-display-reordering, not from buffer-local value. Use the
6154 buffer-local value only if initializing for buffer iteration.
6155 (handle_invisible_prop): Support invisible properties on strings
6156 that are being bidi-reordered.
6157 (set_iterator_to_next): Support bidi reordering of C strings and
6158 Lisp strings.
6159 (next_element_from_string): Support bidi reordering of Lisp
6160 strings.
6161 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6162 (display_string): Support display of R2L glyph rows.
6163 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6164 (init_iterator): Don't initialize it->bidi_p for strings
6165 here.
6166 (reseat_to_string): Initialize it->bidi_p for strings here.
6167 (next_element_from_string, next_element_from_c_string)
6168 (next_element_from_buffer): Add xassert's for correspondence
6169 between IT's object being iterated and it->bidi_it.string
6170 structure.
6171 (face_before_or_after_it_pos): Support bidi iteration.
6172 (next_element_from_c_string): Handle the case of the first string
6173 character that is not the first one in the visual order.
6174 (get_visually_first_element): New function, refactored from common
6175 parts of next_element_from_buffer, next_element_from_string, and
6176 next_element_from_c_string.
6177 (tool_bar_lines_needed, redisplay_tool_bar)
6178 (display_menu_bar): Force left-to-right direction. Add a FIXME
6179 comment for making that be controlled by a user option.
6180 (push_it, pop_it): Save and restore the state of the
6181 bidi iterator. Save and restore the bidi_p flag.
6182 (pop_it): Iterate out of display property for string iteration as
6183 well.
6184 (iterate_out_of_display_property): Support iteration over strings.
6185 (handle_single_display_spec): Set up it->bidi_it for iteration
6186 over a display string, and call bidi_init_it.
6187 (handle_single_display_spec, next_overlay_string)
6188 (get_overlay_strings_1, push_display_prop): Set up the bidi
6189 iterator for displaying display or overlay strings.
6190 (forward_to_next_line_start): Don't use the shortcut if
6191 bidi-iterating.
6192 (back_to_previous_visible_line_start): If handle_display_prop
6193 pushed the iterator stack, restore the internal state of the bidi
6194 iterator by calling bidi_pop_it same number of times.
6195 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6196 and we are bidi-iterating, don't decrement the iterator position;
6197 instead, set the first_elt flag in the bidi iterator, to produce
6198 the same effect.
6199 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6200 (push_display_prop): xassert that we are iterating a buffer.
6201 (push_it, pop_it): Save and restore paragraph_embedding member.
6202 (handle_single_display_spec, next_overlay_string)
6203 (get_overlay_strings_1, reseat_1, reseat_to_string)
6204 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6205 correctly. Don't assume unibyte strings are not bidi-reordered.
6206 (compute_display_string_pos)
6207 (compute_display_string_end): Fix handling the case of C string.
6208 (push_it, pop_it): Save and restore from_disp_prop_p.
6209 (handle_single_display_spec, push_display_prop): Set the
6210 from_disp_prop_p flag.
6211 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6212 (pop_it): Call iterate_out_of_display_property only if we are
6213 popping after iteration over a string that came from a display
6214 property. Fix a typo in popping stretch info. Add an assertion
6215 for verifying that the iterator position is in sync with the bidi
6216 iterator.
6217 (handle_single_display_spec, get_overlay_strings_1)
6218 (push_display_prop): Fix initialization of paragraph direction for
6219 string when that of the parent object is not yet determined.
6220 (reseat_1): Call bidi_init_it to resync the bidi
6221 iterator with IT's position. (Bug#7616)
6222 (find_row_edges): If ROW->start.pos gives position
6223 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6224 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6225 Reset the from_disp_prop_p flag.
6226 (SAVE_IT, RESTORE_IT): New macros.
6227 (pos_visible_p, face_before_or_after_it_pos)
6228 (back_to_previous_visible_line_start)
6229 (move_it_in_display_line_to, move_it_in_display_line)
6230 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6231 (try_scrolling, redisplay_window, display_line): Use them when
6232 saving a temporary copy of the iterator and restoring it back.
6233 (back_to_previous_visible_line_start, reseat_1)
6234 (init_iterator): Empty the bidi cache "stack".
6235 (move_it_in_display_line_to): If iterator ended up at
6236 EOL, but we never saw any buffer positions smaller than
6237 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6238 motion in bidi-reordered lines.
6239 (move_it_in_display_line_to): Record prev_method and prev_pos
6240 immediately before the call to set_iterator_to_next. Fixes cursor
6241 motion in bidi-reordered lines with stretch glyphs and strings
6242 displayed in margins. (Bug#8133) (Bug#8867)
6243 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6244 TO_CHARPOS.
640c8776
SM
6245 (pos_visible_p): Support positions in bidi-reordered lines.
6246 Save and restore bidi cache.
0bb23927
EZ
6247
6248 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6249 (bidi_paragraph_info): Delete unused struct.
6250 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6251 (bidi_cache_start): New variable.
6252 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6253 to zero.
6254 (bidi_cache_fetch_state, bidi_cache_search)
6255 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6256 (bidi_cache_find, bidi_peek_at_next_level)
6257 (bidi_level_of_next_char, bidi_find_other_level_edge)
6258 (bidi_move_to_visually_next): Compare cache index with
6259 bidi_cache_start rather than with zero.
6260 (bidi_fetch_char): Accept new argument STRING; all callers
6261 changed. Support iteration over a string. Support strings with
6262 display properties. Support unibyte strings. Fix the type of
6263 `len' according to what STRING_CHAR_AND_LENGTH expects.
6264 (bidi_paragraph_init, bidi_resolve_explicit_1)
6265 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6266 (bidi_level_of_next_char, bidi_move_to_visually_next):
6267 Support iteration over a string.
0bb23927
EZ
6268 (bidi_set_sor_type, bidi_resolve_explicit_1)
6269 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6270 can now be zero (for strings); special values 0 and -1 were
6271 changed to -1 and -2, respectively.
6272 (bidi_char_at_pos): New function.
6273 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6274 Call it instead of FETCH_MULTIBYTE_CHAR.
6275 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6276 initialized to valid values.
6277 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6278 values.
6279 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6280 the test for valid cached positions. Fix the logic for looking up
6281 the sentinel state in the cache. GCPRO the Lisp string we are
6282 iterating.
6283 (bidi_push_it, bidi_pop_it): New functions.
6284 (bidi_initialize): Initialize the bidi cache start stack pointer.
6285 (bidi_cache_ensure_space): New function, refactored from part of
6286 bidi_cache_iterator_state. Don't assume the required size is just
6287 one BIDI_CACHE_CHUNK away.
6288 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6289 (bidi_count_bytes, bidi_char_at_pos): New functions.
6290 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6291 always valid if bidi_cache_idx is valid.
6292 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6293 is valid if it's going to be used.
6294 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6295 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6296 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6297 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6298 (bidi_find_other_level_edge, bidi_cache_start_stack):
6299 All variables related to cache indices are now EMACS_INT.
c965adc5 6300
0bb23927
EZ
6301 * dispextern.h (struct bidi_string_data): New structure.
6302 (struct bidi_it): New member `string'. Make flag members be 1-bit
6303 fields, and put them last in the struct.
640c8776
SM
6304 (compute_display_string_pos, compute_display_string_end):
6305 Update prototypes.
0bb23927
EZ
6306 (bidi_push_it, bidi_pop_it): Add prototypes.
6307 (struct iterator_stack_entry): New members bidi_p,
6308 paragraph_embedding, and from_disp_prop_p.
6309 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6310 (bidi_shelve_cache, bidi_unshelve_cache):
6311 Declare prototypes.
0bb23927
EZ
6312
6313 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6314 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6315 and vector-like objects.
6316
6317 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6318 cache around display iteration.
6319
6320 * window.c (Fwindow_end, window_scroll_pixel_based)
6321 (displayed_window_lines, Frecenter): Save and restore the bidi
6322 cache around display iteration.
6323
3bbd2265
LMI
63242011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6325
6326 * editfns.c (Fdelete_region): Clarify the use of the named
6327 parameters (bug#6788).
6328
adc47434
MR
63292011-07-14 Martin Rudalics <rudalics@gmx.at>
6330
6331 * indent.c (Fvertical_motion): Set and restore w->pointm when
6332 saving and restoring the window's buffer (Bug#9006).
6333
837c31f8
LMI
63342011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6335
6336 * editfns.c (Fstring_to_char): Clarify just what is returned
6337 (bug#6576). Text by Eli Zaretskii.
6338
ac389d0c
JB
63392011-07-13 Juanma Barranquero <lekktu@gmail.com>
6340
6341 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6342
0be0ce47
EZ
63432011-07-13 Eli Zaretskii <eliz@gnu.org>
6344
6345 * buffer.c (mmap_find): Fix a typo.
6346
cd18e7e3
JB
63472011-07-13 Johan Bockgård <bojohan@gnu.org>
6348
6349 Fix execution of x selection hooks.
6350 * xselect.c (Qx_lost_selection_functions)
6351 (Qx_sent_selection_functions): New vars.
6352 (syms_of_xselect): DEFSYM them.
6353 (x_handle_selection_request): Pass Qx_sent_selection_functions
6354 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6355 (x_handle_selection_clear,x_clear_frame_selections):
6356 Pass Qx_lost_selection_functions rather than
6357 Vx_lost_selection_functions to Frun_hook_with_args.
6358
47ea7f44
PE
63592011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6360
ac389d0c 6361 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6362 The old code sometimes used this field without initializing it.
6363
47ea7f44
PE
6364 * alloc.c (gc_sweep): Don't read past end of array.
6365 In theory, the old code could also have corrupted Emacs internals,
6366 though it'd be very unlikely.
6367
bc985c87
AS
63682011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6369
6370 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6371 argument. (Bug#4026)
bc985c87 6372
0cf34688
LMI
63732011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6374
b3dadd76
LMI
6375 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6376 key" (bug#4257).
6377
0cf34688
LMI
6378 * window.c (Fset_window_start): Doc fix (bug#4199).
6379 (Fset_window_hscroll): Ditto.
6380
270768cd
PE
63812011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6382
077e3dda 6383 Fix minor new problems caught by GCC 4.6.1.
270768cd 6384 * term.c (init_tty): Remove unused local.
490011a6 6385 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6386 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6387 not used otherwise.
270768cd 6388
b1f58454
CY
63892011-07-12 Chong Yidong <cyd@stupidchicken.com>
6390
6391 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6392
22b9578d
LMI
63932011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6394
6e70ab07
LMI
6395 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6396 are the mini-buffer and the echo area (bug#3320).
6397
22b9578d
LMI
6398 * term.c (init_tty): Remove support for supdup, c10 and perq
6399 terminals, which are no longer supported (bug#1482).
6400
8974cc9f
JB
64012011-07-10 Johan Bockgård <bojohan@gnu.org>
6402
6403 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6404
a560d974
JD
64052011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6406
6407 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6408 for non-popups (Bug#3642).
6409
1dae0f0a
AS
64102011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6411
268c2c36 6412 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6413 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6414 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6415 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6416 * data.c (fmod): Likewise.
6417 * dispnew.c (swap_glyphs_in_rows): Likewise.
6418 * emacs.c (memory_warning_signal): Likewise.
6419 * floatfns.c (float_error): Likewise.
6420 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6421 (otf_open, font_otf_capability, generate_otf_features)
6422 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6423 Likewise.
6424 * image.c (pbm_read_file): Likewise.
6425 * indent.c (string_display_width): Likewise.
6426 * intervals.c (check_for_interval, search_for_interval)
6427 (inc_interval_count, count_intervals, root_interval)
6428 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6429 * lread.c (defalias): Likewise.
268c2c36 6430 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6431 * regex.c (set_image_of_range_1, set_image_of_range)
6432 (regex_grow_registers): Likewise.
6433 * sysdep.c (strerror): Likewise.
6434 * termcap.c (valid_filename_p, tprint, main): Likewise.
6435 * tparam.c (main): Likewise.
6436 * unexhp9k800.c (run_time_remap, save_data_space)
6437 (update_file_ptrs, read_header, write_header, calculate_checksum)
6438 (copy_file, copy_rest, display_header): Likewise.
6439 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6440 Likewise.
6441 * xdisp.c (check_it): Likewise.
6442 * xfaces.c (register_color, unregister_color, unregister_colors):
6443 Likewise.
6444 * xfns.c (print_fontset_result): Likewise.
6445 * xrdb.c (member, fatal, main): Likewise.
6446
99033785
PE
64472011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6448
6449 Fix minor problems found by static checking (Bug#9031).
6450 * chartab.c (char_table_set_range, map_sub_char_table):
6451 Remove unused locals.
6452 (uniprop_table): Now static.
6453 * composite.c (_work_char): Remove unused static var.
6454
9cb2ac56
JB
64552011-07-09 Juanma Barranquero <lekktu@gmail.com>
6456
6457 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6458
f25661f0
JD
64592011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6460
6461 * gtkutil.c (qttip_cb): Remove code without function.
6462
8278c4fe
EZ
64632011-07-09 Eli Zaretskii <eliz@gnu.org>
6464
6465 * w32.c (pthread_sigmask): New stub.
6466
1692ae2d 64672011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6468
8a6ebd58 6469 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6470 sigprocmask is portable only for single-threaded applications, and
6471 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6472 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6473 (LIBES): Use it.
6474 * callproc.c (Fcall_process):
6475 * process.c (create_process):
6476 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6477 Use pthread_sigmask, not sigprocmask.
123403e4 6478
1b854618
JD
64792011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6480
6481 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6482 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6483 wrong (Bug#8591).
6484
3fe4b549
JD
64852011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6486
0ce7e563
JD
6487 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6488 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6489 (xg_hide_tooltip): Fix comment.
6490
3fe4b549
JD
6491 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6492 in registerServicesMenuSendTypes.
6493 (validRequestorForSendType): Don't check ns_return_types.
6494
6495 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6496 ns_return_type.
6497
5df75e47
JR
64982011-07-08 Jason Rumney <jasonr@gnu.org>
6499
22610910
JR
6500 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6501 SH_SHOW for hidden windows (Bug#5482).
6502
5df75e47
JR
6503 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6504 frame struct members of non-existent frames (Bug#6284).
6505
699c10bd
JD
65062011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6507
4393663b
JD
6508 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6509 variable firstTime not needed on OSX >= 10.6.
6510 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6511 >= 10.5. Use setKnobProportion, setDoubleValue.
6512
6513 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6514 (MAC_OS_X_VERSION_10_5): Define if not defined.
6515 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6516 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6517 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6518
6519 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6520 cString and lossyCString on OSX >= 10.4
6521
58179cce 6522 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6523 sizeToFit on OSX >= 10.2.
6524
6525 * nsimage.m (allocInitFromFile): Don't use deprecated method
6526 bestRepresentationForDevice on OSX >= 10.6.
6527
6528 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6529 to avoid warning.
6530
6531 * emacs.c: Declare unexec_init_emacs_zone.
6532
a63e0781
JD
6533 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6534
699c10bd
JD
6535 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6536
6537 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6538 on svcsMenu (Bug#8842).
6539
6540 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6541 ns_return_types.
6542 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6543
6544 * nsterm.m (QUTF8_STRING): Declare.
6545 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6546 (validRequestorForSendType): Return type is (id).
6547 Change indexOfObjectIdenticalTo to indexOfObject.
6548 Check if we have local selection before returning self (Bug#8842).
6549 (writeSelectionToPasteboard): Put local selection into paste board
6550 if we have a local selection (Bug#8842).
6551 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6552
6553 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6554 (ns_get_local_selection): Declare.
6555
54e10184
LMI
65562011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6557
9888ff71
LMI
6558 * keymap.c (describe_map_tree): Don't insert a double newline at
6559 the end of the buffer (bug#1169) and return whether we inserted
6560 something.
6561
54e10184
LMI
6562 * callint.c (Fcall_interactively): Change "reading args" to
6563 "providing args" to try to clarify what it does (bug#1010).
6564
15fa4783
KH
65652011-07-07 Kenichi Handa <handa@m17n.org>
6566
6567 * composite.c (composition_compute_stop_pos): Ignore a static
6568 composition starting before CHARPOS (Bug#8915).
6569
6570 * xdisp.c (handle_composition_prop): Likewise.
6571
a8815b00
EZ
65722011-07-07 Eli Zaretskii <eliz@gnu.org>
6573
6574 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6575 (Bug#9015)
6576
ef7b981d 65772011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6578
6579 * character.h (unicode_category_t): New enum type.
6580
6581 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6582 (Qchar_code_property_table): New variable.
6583 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6584 (UNIPROP_COMPRESSED_FORM_P): New macros.
6585 (char_table_ascii): Uncompress the compressed values.
6586 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6587 Uncompress the compressed values.
ac389d0c 6588 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6589 (char_table_ref_and_range): Uncompress the compressed values.
6590 (sub_char_table_set): New arg is_uniprop. Callers changed.
6591 Uncompress the compressed values.
6592 (sub_char_table_set_range): Args changed. Callers changed.
6593 (char_table_set_range): Adjuted for the above change.
6594 (map_sub_char_table): Delete args default_val and parent. Add arg
6595 top. Give decoded values to a Lisp function.
640c8776 6596 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6597 values to a Lisp function. Gcpro more variables.
6598 (uniprop_table_uncompress)
6599 (uniprop_decode_value_run_length): New functions.
6600 (uniprop_decoder, uniprop_decoder_count): New variables.
6601 (uniprop_get_decoder, uniprop_encode_value_character)
6602 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6603 New functions.
6604 (uniprop_encoder, uniprop_encoder_count): New variables.
6605 (uniprop_get_encoder, uniprop_table)
6606 (Funicode_property_table_internal, Fget_unicode_property_internal)
6607 (Fput_unicode_property_internal): New functions.
6608 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6609 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6610 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6611 char-code-property-alist.
6612
640c8776 6613 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6614 Vunicode_category_table.
6615
640c8776 6616 * font.c (font_range): Adjust for the change of
c805dec0
KH
6617 Vunicode_category_table.
6618
76b397fb
DN
66192011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6620
6621 * m/iris4d.h: Remove file, move contents ...
6622 * s/irix6-5.h: ... here.
6623
22b4128e
PE
66242011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6625
6626 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6627 * alloc.c (mark_buffer):
6628 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6629 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6630 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6631 This isn't true in general, and it's particularly not true
6632 if Emacs is configured with --with-wide-int.
6633 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6634 New macros, used in the buffer.c change.
6635
869795d6
JD
66362011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6637
6638 * xsettings.c: Use both GConf and GSettings if both are available.
6639 (store_config_changed_event): Add comment.
6640 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6641 (store_tool_bar_style_changed): New functions.
5e617bc2 6642 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6643 (struct xsettings): Move font inside HAVE_XFT.
6644 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6645 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6646 Move inside HAVE_XFT.
640c8776 6647 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6648 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6649 also.
6650 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6651 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6652 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6653 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6654 (parse_settings): Move check for font inside HAVE_XFT.
6655 (read_settings, apply_xft_settings): Add comment.
6656 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6657 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6658 call store_font_name_changed.
6659 (xft_settings_event): Add comment.
6660 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6661 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6662 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6663 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6664 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6665 (xsettings_get_system_font, xsettings_get_system_normal_font):
6666 Add comment.
869795d6 6667
d8ed26bd
PE
66682011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6669
6670 Random fixes. E.g., (random) never returned negative values.
6671 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6672 subseconds part to the entropy, as that's a bit more random.
6673 Prefer signed to unsigned, since the signedness doesn't matter and
6674 in general we prefer signed. When given a limit, use a
6675 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6676 latter isn't right if USE_2_TAGS_FOR_INTS.
6677 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6678 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6679
cabf1cac
SM
66802011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6681
6682 * textprop.c (text_property_stickiness):
6683 Obey Vtext_property_default_nonsticky.
6684 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6685 * w32fns.c (syms_of_w32fns):
6686 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6687
6e9b2be9
PE
66882011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6689
6690 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6691 This is more efficient than Ffile_directory_p and avoids a minor race.
6692
90186c68
LMI
66932011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6694
7c301272
LMI
6695 * buffer.c (Foverlay_put): Say what the return value is
6696 (bug#7835).
6697
c4f2d8d4
LMI
6698 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6699 is a directory before asking whether to use the file name
6700 (bug#7564).
ad637907
LMI
6701 (barf_or_query_if_file_exists): Make the "File is a directory"
6702 error be more correct.
c4f2d8d4 6703
90186c68
LMI
6704 * fns.c (Frequire): Remove the mention of the .gz files, since
6705 that's installation-specific, but keep the mention of
6706 `get-load-suffixes'.
6707
da64016e
PE
67082011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6709
6710 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6711 Report string overflow if the output is too long.
6712
7d47b580
JB
67132011-07-04 Juanma Barranquero <lekktu@gmail.com>
6714
a555cb87
JB
6715 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6716 (syms_of_gnutls): Remove duplicate DEFSYM for
6717 Qgnutls_bootprop_verify_hostname_error, an error for
6718 Qgnutls_bootprop_verify_error (which is no longer used).
6719
7d47b580
JB
6720 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6721 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6722 Also (re)move comments that are misplaced or no longer relevant.
6723
1e49bfab
LMI
67242011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6725
6726 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6727
1485f4c0
CY
67282011-07-03 Chong Yidong <cyd@stupidchicken.com>
6729
6730 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6731 and background color parameters if they have been changed.
6732
a9ab721e
LMI
67332011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6734
6735 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6736
cf7cff57
PE
67372011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6738
2e13213d
PE
6739 * xsettings.c (SYSTEM_FONT): Define only when used.
6740 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6741
cf7cff57
PE
6742 * keymap.c (access_keymap_1): Now static.
6743
7a8e04f7
CY
67442011-07-02 Chong Yidong <cyd@stupidchicken.com>
6745
6746 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6747 leave any prefix arg for the up event (Bug#1586).
6748
61352f62
LMI
67492011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6750
69bb1ef7
LMI
6751 * lread.c (syms_of_lread): Mention single symbols defined by
6752 `defvar' or `defconst' (bug#7154).
6753
61352f62 6754 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6755 (Frequire): Mention get-load-suffixes.
61352f62 6756
28545e04
MR
67572011-07-02 Martin Rudalics <rudalics@gmx.at>
6758
6759 * window.h (window): Remove clone_number slot.
6760 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6761 Remove.
6762 (make_parent_window, make_window, saved_window)
6763 (Fset_window_configuration, save_window_save): Don't deal with
6764 clone numbers.
6765 * buffer.c (Qclone_number): Remove declaration.
6766 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6767
3349e122
SM
67682011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6769
6770 Add multiple inheritance to keymaps.
6771 * keymap.c (Fmake_composed_keymap): New function.
6772 (Fset_keymap_parent): Simplify.
6773 (fix_submap_inheritance): Remove.
6774 (access_keymap_1): New function extracted from access_keymap to handle
6775 embedded parents and handle lists of maps.
6776 (access_keymap): Use it.
6777 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6778 (Fcopy_keymap): Handle embedded parents.
6779 (Fcommand_remapping, define_as_prefix): Simplify.
6780 (Fkey_binding): Simplify.
6781 (syms_of_keymap): Move minibuffer-local-completion-map,
6782 minibuffer-local-filename-completion-map,
6783 minibuffer-local-must-match-map, and
6784 minibuffer-local-filename-must-match-map to Elisp.
6785 (syms_of_keymap): Defsubr make-composed-keymap.
6786 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6787 (parse_menu_item): Trivial simplification.
6788
3279eb87
GM
67892011-07-01 Glenn Morris <rgm@gnu.org>
6790
6791 * Makefile.in (SETTINGS_LIBS): Fix typo.
6792
4550efdf
KI
67932011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6794
6795 * coding.c (Fencode_coding_string): Record the last coding system
6796 used, as the function doc string says (bug#8738).
6797
0949d2b6
JD
67982011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6799
6800 * xsettings.c (store_monospaced_changed): Take new font as arg and
6801 check for change against current_mono_font.
6802 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6803 (emacs_settings_constructor, emacs_settings_get_property)
6804 (emacs_settings_set_property, emacs_settings_class_init)
6805 (emacs_settings_init, gsettings_obj): Remove.
6806 (something_changedCB): New function for HAVE_GSETTINGS.
6807 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6808 with value as argument.
6809 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6810 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6811 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6812 "changed".
6813
6814 * xgselect.c: Add defined (HAVE_GSETTINGS).
6815 (xgselect_initialize): Ditto.
6816
6817 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6818 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6819 xg_select.
6820
bbc6b304
PE
68212011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6822
6823 * eval.c (struct backtrace): Simplify and port the data structure.
6824 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6825 signed bit field, as this assumption is not portable and it makes
6826 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6827 "char debug_on_exit : 1" as this is not portable either; instead,
6828 use the portable "unsigned int debug_on_exit : 1". Remove unused
6829 member evalargs. Remove obsolete comments about cc bombing out.
6830
9851bfc5
JD
68312011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6832
51bb811f 6833 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6834 Let HAVE_GSETTINGS override HAVE_GCONF.
6835 (store_monospaced_changed): New function.
6836 (EMACS_SETTINGS): A new type derived from GObject to handle
6837 GSettings notifications.
6838 (emacs_settings_constructor, emacs_settings_get_property)
6839 (emacs_settings_set_property, emacs_settings_class_init):
6840 New functions.
6841 (gsettings_client, gsettings_obj): New variables.
6842 (GSETTINGS_SCHEMA): New define.
6843 (something_changedCB): Call store_monospaced_changed.
6844 (init_gsettings): New function.
6845 (xsettings_initialize): Call init_gsettings.
6846 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6847 to NULL.
6848
640c8776 6849 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6850 GCONF_CFLAGS/LIBS.
6851
5386012d
MR
68522011-06-29 Martin Rudalics <rudalics@gmx.at>
6853
6854 * window.c (resize_root_window, grow_mini_window)
6855 (shrink_mini_window): Rename Qresize_root_window to
6856 Qwindow_resize_root_window and Qresize_root_window_vertically to
6857 Qwindow_resize_root_window_vertically.
6858
f13e0b08
PE
68592011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6860
6861 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6862
94515237
JB
68632011-06-27 Juanma Barranquero <lekktu@gmail.com>
6864
6865 * makefile.w32-in: Redesign dependencies so they reflect more
6866 clearly which files are directly included by each source file,
6867 and not through other includes.
6868
e43b6e43
MR
68692011-06-27 Martin Rudalics <rudalics@gmx.at>
6870
6871 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6872 (sort_overlays, overlay_strings): When an overlay's clone number
6873 matches the window's clone number process the overlay even if
6874 the overlay's window property doesn't match the current window.
6875
d68443dc
MR
6876 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6877 (Fwindow_hchild): Rename to Fwindow_left_child.
6878 (Fwindow_next): Rename to Fwindow_next_sibling.
6879 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6880 (resize_window_check): Rename to window_resize_check.
6881 (resize_window_apply): Rename to window_resize_apply.
6882 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6883 (Fdelete_other_windows_internal, resize_frame_windows)
6884 (Fsplit_window_internal, Fdelete_window_internal)
6885 (grow_mini_window, shrink_mini_window)
6886 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6887
c7e73be5
JD
68882011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6889
6890 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6891 (emacs_fixed_set_min_size): Remove.
6892 (emacs_fixed_new): Take frame as argument.
6893
6894 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6895 (_EmacsFixedPrivate): Remove minwidth/height.
6896 Add struct frame *f.
6897 (emacs_fixed_init): Initialize priv->f.
6898 (get_parent_class, emacs_fixed_set_min_size): Remove.
6899 (emacs_fixed_new): Set priv->f to argument.
6900 (emacs_fixed_get_preferred_width)
6901 (emacs_fixed_get_preferred_height): Use min_width/height from
6902 frames size_hint to set minimum and natural (Bug#8919).
6903 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6904 and use min_width/height from frames size_hint to set
6905 min_width/height (Bug#8919).
6906
6907 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6908 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6909 Fix indentation.
c7e73be5 6910
cf99dcf8
EZ
69112011-06-26 Eli Zaretskii <eliz@gnu.org>
6912
6913 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6914 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6915 called at ZV.
6916
029529ac
CY
69172011-06-26 Chong Yidong <cyd@stupidchicken.com>
6918
6919 * process.c (wait_reading_process_output): Bypass select if
6920 waiting for a cell while ignoring keyboard input, and input is
6921 pending. Suggested by Jan Djärv (Bug#8869).
6922
7a7ef429
PE
69232011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6924
6925 Use gnulib's dup2 module instead of rolling our own.
6926 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6927
11fdef7d 69282011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6929
6930 * dispnew.c (scrolling_window): Before scrolling, turn off a
6931 mouse-highlight in the window being scrolled.
6932
cd3520a4
JB
69332011-06-24 Juanma Barranquero <lekktu@gmail.com>
6934
6935 Move DEFSYM to lisp.h and use everywhere.
6936
6937 * character.h (DEFSYM): Move declaration...
6938 * lisp.h (DEFSYM): ...here.
6939
6940 * gnutls.c:
6941 * minibuf.c:
6942 * w32menu.c:
6943 * w32proc.c:
6944 * w32select.c: Don't include character.h.
6945
6946 * alloc.c (syms_of_alloc):
6947 * buffer.c (syms_of_buffer):
6948 * bytecode.c (syms_of_bytecode):
6949 * callint.c (syms_of_callint):
6950 * casefiddle.c (syms_of_casefiddle):
6951 * casetab.c (init_casetab_once):
6952 * category.c (init_category_once, syms_of_category):
6953 * ccl.c (syms_of_ccl):
6954 * cmds.c (syms_of_cmds):
6955 * composite.c (syms_of_composite):
6956 * dbusbind.c (syms_of_dbusbind):
6957 * dired.c (syms_of_dired):
6958 * dispnew.c (syms_of_display):
6959 * doc.c (syms_of_doc):
6960 * editfns.c (syms_of_editfns):
6961 * emacs.c (syms_of_emacs):
6962 * eval.c (syms_of_eval):
6963 * fileio.c (syms_of_fileio):
6964 * fns.c (syms_of_fns):
6965 * frame.c (syms_of_frame):
6966 * fringe.c (syms_of_fringe):
6967 * insdel.c (syms_of_insdel):
6968 * keymap.c (syms_of_keymap):
6969 * lread.c (init_obarray, syms_of_lread):
6970 * macros.c (syms_of_macros):
6971 * msdos.c (syms_of_msdos):
6972 * print.c (syms_of_print):
6973 * process.c (syms_of_process):
6974 * search.c (syms_of_search):
6975 * sound.c (syms_of_sound):
6976 * syntax.c (init_syntax_once, syms_of_syntax):
6977 * terminal.c (syms_of_terminal):
6978 * textprop.c (syms_of_textprop):
6979 * undo.c (syms_of_undo):
6980 * w32.c (globals_of_w32):
6981 * window.c (syms_of_window):
6982 * xdisp.c (syms_of_xdisp):
6983 * xfaces.c (syms_of_xfaces):
6984 * xfns.c (syms_of_xfns):
6985 * xmenu.c (syms_of_xmenu):
6986 * xsettings.c (syms_of_xsettings):
6987 * xterm.c (syms_of_xterm): Use DEFSYM.
6988
4228cf16
TZ
69892011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6990
cd3520a4 6991 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6992
7fcccf1e
PE
69932011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6994
7efb4e0e
PE
6995 Integer and buffer overflow fixes (Bug#8873).
6996
ff5844ad
PE
6997 * print.c (printchar, strout): Check for string overflow.
6998 (PRINTPREPARE, printchar, strout):
6999 Don't set size unless allocation succeeds.
7000
90532f02
PE
7001 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7002 for sizes. Check for string overflow more accurately.
7003 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7004
6d84508d
PE
7005 * macros.c: Integer and buffer overflow fixes.
7006 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7007 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7008 Use ptrdiff_t, not int, for sizes.
7009 Don't increment bufsize until after realloc succeeds.
7010 Check for size-calculation overflow.
7011 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7012
437b2cb4
PE
7013 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7014
8b9ac8b4
PE
7015 * lread.c: Integer overflow fixes.
7016 (read_integer): Radix is now EMACS_INT, not int,
7017 to improve quality of diagnostics for out-of-range radices.
7018 Calculate buffer size correctly for out-of-range radices.
7019 (read1): Check for integer overflow in radices, and in
7020 read-circle numbers.
82cb60d3
PE
7021 (read_escape): Avoid int overflow.
7022 (Fload, openp, read_buffer_size, read1)
7023 (substitute_object_recurse, read_vector, read_list, map_obarray):
7024 Use ptrdiff_t, not int, for sizes.
7025 (read1): Use EMACS_INT, not int, for sizes.
20270765 7026 Check for size overflow.
8b9ac8b4 7027
7fcccf1e
PE
7028 * image.c (cache_image): Check for size arithmetic overflow.
7029
bfbbd7e7
PE
7030 * lread.c: Integer overflow issues.
7031 (saved_doc_string_size, saved_doc_string_length)
7032 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7033 Now ptrdiff_t, not int.
7034 (read1): Don't assume doc string length fits in int. Check for
7035 out-of-range doc string lengths.
7036 (read_list): Don't assume file position fits in int.
39019e54 7037 (read_escape): Check for hex character overflow.
bfbbd7e7 7038
4e323265
LL
70392011-06-22 Leo Liu <sdl.web@gmail.com>
7040
7041 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7042 Move to minibuffer.el.
7043
85fece3e
PE
70442011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7045
20b84ce9 7046 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7047 The following patches are for when GLYPH_DEBUG && !XASSERT.
7048 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7049 * dispnew.c (flush_stdout):
7050 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7051 Mark as externally visible.
7052 * dispnew.c (check_window_matrix_pointers): Now static.
7053 * dispnew.c (window_to_frame_vpos):
7054 * xfns.c (unwind_create_frame):
7055 * xterm.c (x_check_font): Remove unused local.
7056 * scroll.c (CHECK_BOUNDS):
7057 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7058 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7059 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7060 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7061 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7062 Now static.
7063 (debug_method_add): Use va_list and vsprintf rather than relying
7064 on undefined behavior with wrong number of arguments.
7065 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7066 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7067 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7068 since we're not interested in debugging glyphs with old libraries.
7069 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7070 GCC 4.6.0's static checking.
7071
0766b489
PE
70722011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7073
31fd4b32
PE
7074 Integer overflow and signedness fixes (Bug#8873).
7075 A few related buffer overrun fixes, too.
7076
b79e8648
PE
7077 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7078
0766b489
PE
7079 * dispextern.h (struct face.stipple):
7080 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7081 (x_bitmap_mask, x_allocate_bitmap_record)
7082 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7083 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7084 (x_create_bitmap_from_xpm_data):
7085 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7086 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7087 (.bitmaps_last):
7088 * xfaces.c (load_pixmap):
7089 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7090 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7091 (.bitmaps_last, struct x_output.icon_bitmap):
7092 Use ptrdiff_t, not int, for bitmap indexes.
7093 (x_allocate_bitmap_record): Check for size overflow.
7094 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7095
b081724f
PE
7096 Use ptrdiff_t, not int, for overlay counts.
7097 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7098 * editfns.c (overlays_around, get_pos_property):
7099 * textprop.c (get_char_property_and_overlay):
7100 * xdisp.c (next_overlay_change, note_mouse_highlight):
7101 * xfaces.c (face_at_buffer_position):
21514da7
PE
7102 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7103 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7104 (Fnext_overlay_change, Fprevious_overlay_change)
7105 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7106 Use ptrdiff_t, not int, for sizes.
21514da7 7107 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7108
3de73e5e
PE
7109 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7110
2606c57b
PE
7111 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7112 (x_session_initialize): Do not assume string length fits in int.
7113
aaafe47a
PE
7114 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7115 This is unlikely, but can occur if DPI is outlandish.
7116
2674ddc8 7117 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7118 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7119
28154962
PE
7120 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7121 * xrdb.c (magic_file_p, search_magic_path):
7122 Omit last arg SUFFIX; it was always 0. All callers changed.
7123 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7124
7de51af5
PE
7125 * xfont.c (xfont_match): Avoid need for strlen.
7126
25ed6cc3
PE
7127 * xfns.c: Don't assume strlen fits in int.
7128 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7129
4eab31dd
PE
7130 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7131 not unsigned long, as we prefer signed integers. All callers changed.
7132 Detect integer overflow in repeat count.
7133 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7134 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7135
171e2a58
PE
7136 * termcap.c: Don't assume sizes fit in int and never overflow.
7137 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7138 (gobble_line): Check for size-calculation overflow.
7139
ad39faca 7140 * minibuf.c (Fread_buffer):
6e5bb2dc 7141 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7142 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7143 Don't assume string length fits in int.
7144
52c61c22 7145 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7146 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7147
b5b8c9e5
PE
7148 * font.c: Don't assume string length fits in int.
7149 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7150 Use ptrdiff_t, not int.
ccd6111c
PE
7151 (font_intern_prop): Don't assume string length fits in int.
7152 Don't assume integer property fits in fixnum.
7153 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7154
882f0d81 7155 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7156 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7157 Reformulate so as not to need the command string.
7158 Invoke gzip -cd rather than gunzip, as it's more portable.
7159 (lock_info_type, lock_file_1, lock_file):
7160 Don't assume pid_t and time_t fit in unsigned long.
7161 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7162 (current_lock_owner): Prefer signed type for sizes.
7163 Use memcpy, not strncpy, where memcpy is what is really wanted.
7164 Don't assume (via atoi) that time_t and pid_t fit in int.
7165 Check for time_t and/or pid_t out of range, e.g., via a network share.
7166 Don't alloca where an auto var works fine.
7167
93f4cf88
PE
7168 * fileio.c: Fix some integer overflow issues.
7169 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7170 Don't assume string length fits in int.
7171 (directory_file_name): Don't assume string length fits in long.
7172 (make_temp_name): Don't assume pid fits in int, or that its print
7173 length is less than 20.
7174
f3e92b69
PE
7175 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7176
1bfdaf10
PE
7177 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7178
35016e9a
PE
7179 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7180
3d1e65a1
PE
7181 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7182 We prefer signed integers, even for size calculations.
7183
0b963a93
PE
7184 * emacs.c: Don't assume string length fits in 'int'.
7185 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7186 (main): Don't invoke strlen when not needed.
7187
573f4b54
PE
7188 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7189 (XD_DEBUG_MESSAGE): Don't waste a byte.
7190
989f33ba
PE
7191 * callproc.c (getenv_internal_1, getenv_internal)
7192 (Fgetenv_internal):
965d34eb
PE
7193 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7194
e4d29b33
PE
7195 * lread.c (invalid_syntax): Omit length argument.
7196 All uses changed. This doesn't fix a bug, but it simplifies the
7197 code away from its former Hollerith-constant appearance, and it's
7198 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7199 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7200
eb49b136
PE
7201 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7202 This didn't break anything, but it didn't help either.
7203 It's confusing to put a bogus integer in a place where the actual
7204 value does not matter.
9f62aeb1 7205 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7206 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7207
15375a22
PE
7208 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7209 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7210 implementation.
b61cc01c
PE
7211 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7212 We prefer signed types, and the value cannot exceed the EMACS_INT
7213 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7214 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7215 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7216 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7217
53b2623d
PE
7218 * indent.c (sane_tab_width): New function.
7219 (current_column, scan_for_column, Findent_to, position_indentation)
7220 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7221 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7222
51cab52b 7223 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7224
f2ed8a70
PE
7225 * lisp.h (lint_assume): New macro.
7226 * composite.c (composition_gstring_put_cache):
7227 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7228
abe80cc6
PE
7229 * editfns.c, insdel.c:
7230 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7231
b02c740e
PE
7232 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7233
ebc96716
PE
7234 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7235
b4e50fa0 7236 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7237 Use much-faster test for byte-length change.
311d5d7c 7238 Don't assume string byte-length fits in 'int'.
a4cf38e4 7239 Check that character arg fits in 'int'.
85461888 7240 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7241
c0c1ee9f
PE
7242 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7243
a498d7f4
PE
7244 * fns.c (concat): Catch string overflow earlier.
7245 Do not rely on integer wraparound.
7246
51cab52b
PE
7247 * dispextern.h (struct it.overlay_strings_charpos)
7248 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7249 * xdisp.c (forward_to_next_line_start)
7250 (back_to_previous_visible_line_start)
7251 (reseat_at_next_visible_line_start, next_element_from_buffer):
7252 Don't arbitrarily truncate the value of 'selective' to int.
7253
76031fad
PE
7254 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7255
5eb55db9
PE
7256 * composite.c: Don't truncate sizes to 'int'.
7257 (composition_gstring_p, composition_reseat_it)
7258 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7259 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7260 not EMACS_UINT, for indexes.
5eb55db9 7261
0703a717
PE
7262 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7263
d6202519
PE
7264 * buffer.c: Include <verify.h>.
7265 (struct sortvec.priority, struct sortstr.priority):
8961a454 7266 Now EMACS_INT, not int.
c20998a7 7267 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7268 (struct sortstr.size, record_overlay_string)
7269 (struct sortstrlist.size, struct sortlist.used):
7270 Don't truncate size to int.
7271 (record_overlay_string): Check for size-calculation overflow.
d6202519 7272 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7273
d5a19415
JM
72742011-06-22 Jim Meyering <meyering@redhat.com>
7275
029529ac 7276 Don't leak an XBM-image-sized buffer
d5a19415
JM
7277 * image.c (xbm_load): Free the image buffer after using it.
7278
a9041e6c
PE
72792011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7280
7281 Port to Sun C.
7282 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7283 that Sun C diagnosed.
7284 * fns.c (secure_hash): Fix pointer signedness issue.
7285 * intervals.c (static_offset_intervals): New function.
7286 (offset_intervals): Use it.
7287
7f3f739f
LL
72882011-06-21 Leo Liu <sdl.web@gmail.com>
7289
7290 * deps.mk (fns.o):
7291 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7292 sha512.h.
7293
7294 * fns.c (secure_hash): Rename from crypto_hash_function and change
7295 the first arg to accept symbols.
5b66d427 7296 (Fsecure_hash): New primitive.
7f3f739f
LL
7297 (syms_of_fns): New symbols.
7298
76147d94
DD
72992011-06-20 Deniz Dogan <deniz@dogan.se>
7300
7301 * process.c (Fset_process_buffer): Clarify return value in
7302 docstring.
7303
7d7d0045
CY
73042011-06-18 Chong Yidong <cyd@stupidchicken.com>
7305
7306 * dispnew.c (add_window_display_history): Use BVAR.
7307
7308 * xdisp.c (debug_method_add): Use BVAR.
7309 (check_window_end, dump_glyph_matrix, dump_glyph)
7310 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7311
7312 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7313 Likewise.
7314
7315 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7316 check till after the cache is created in init_frame_faces.
7317
ff2bc410
SM
73182011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7319
7320 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7321
28177add
PE
73222011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7323
dd3482fe
PE
7324 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7325 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7326 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7327
393d71f3 7328 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7329 * fileio.c (Finsert_file_contents):
7330 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7331 Remove the old (too-loose) buffer overflow checks.
7332 They weren't needed, since make_gap checks for buffer overflow.
7333 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7334 The old code merely checked for Emacs fixnum overflow, and relied
7335 on undefined (wraparound) behavior. The new code avoids undefined
7336 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7337
2e6813b0 7338 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7339 Tune. Don't use wider integers than needed. Don't use alloca.
7340 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7341
599a9e4f
PE
7342 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7343
99561444
PE
7344 * insdel.c, lisp.h (buffer_overflow): New function.
7345 (insert_from_buffer_1, replace_range, replace_range_2):
7346 * insdel.c (make_gap_larger):
7347 * editfns.c (Finsert_char):
7348 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7349
28177add
PE
7350 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7351
e69dafad
PE
73522011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7353
4baa020d 7354 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7355
b1c46f02
PE
7356 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7357 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7358
e69dafad
PE
7359 * fileio.c: Don't assume EMACS_INT fits in off_t.
7360 (emacs_lseek): New static function.
7361 (Finsert_file_contents, Fwrite_region): Use it.
7362 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7363
566684ea
PE
7364 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7365
e6966cd6
PE
7366 * fns.c: Don't overflow int when computing a list length.
7367 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7368 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7369 truncation on 64-bit hosts. Check for QUIT every
7370 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7371 faster and is responsive enough.
7372 (Flength): Report an error instead of overflowing an integer.
7373 (Fsafe_length): Return a float if the value is not representable
7374 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7375 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7376 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7377
dd0b0efb
PE
7378 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7379 (header_size, word_size): New constants.
7380 (allocate_vectorlike): Don't check size overflow here.
7381 (allocate_vector): Check it here instead, since this is the only
7382 caller of allocate_vectorlike that could cause overflow.
7383 Check that the new vector's length is representable as a fixnum.
7384
86fe5cfe
PE
7385 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7386 The previous code was bogus. For example, next_almost_prime (32)
7387 returned 39, which is undesirable as it is a multiple of 3; and
7388 next_almost_prime (24) returned 25, which is a multiple of 5 so
7389 why was the code bothering to check for multiples of 7?
7390
80e88859
PE
7391 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7392
4a2f0ad6
PE
7393 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7394
f66c7cf8
PE
7395 Variadic C functions now count arguments with ptrdiff_t.
7396 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7397 Back then I didn't know that the Emacs coding style prefers signed int.
7398 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7399 were being counted with int, which may truncate counts on 64-bit
7400 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7401 * lisp.h (struct Lisp_Subr.function.aMANY)
7402 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7403 Arg counts are now ptrdiff_t, not size_t.
7404 All variadic functions and their callers changed accordingly.
7405 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7406 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7407 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7408 * callint.c (Fcall_interactively): Check arg count for overflow,
7409 to avoid potential buffer overrun. Use signed char, not 'int',
7410 for 'varies' array, so that we needn't bother to check its size
7411 calculation for overflow.
7412 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7413 * eval.c (apply_lambda):
7414 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7415 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7416 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7417
a1759b76
PE
7418 * callint.c (Fcall_interactively): Don't use index var as event count.
7419
d96be9fc
PE
7420 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7421 * mem-limits.h (SIZE): Remove; no longer used.
7422
a690a978 7423 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7424
578c21e6
PE
7425 Remove unnecessary casts.
7426 * xterm.c (x_term_init):
7427 * xfns.c (x_set_border_pixel):
7428 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7429 These aren't needed now that we assume ANSI C.
7430
96f53c6c
PE
7431 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7432 It's more likely to cause problems (due to unsigned overflow)
7433 than to cure them.
7434
83c77d31
PE
7435 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7436
ee2079f1
PE
7437 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7438
6da65536
PE
7439 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7440
7147c4a4
PE
7441 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7442
193e32d9
PE
7443 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7444
e5533da6
PE
7445 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7446
9910e595
PE
7447 GLYPH_CODE_FACE returns EMACS_INT, not int.
7448 * dispextern.h (merge_faces):
7449 * xfaces.c (merge_faces):
01103c44
PE
7450 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7451 Don't assume EMACS_INT fits in int.
9910e595 7452
2638320e
PE
7453 * character.h (CHAR_VALID_P): Remove unused parameter.
7454 * fontset.c, lisp.h, xdisp.c: All uses changed.
7455
045eb8d9
PE
7456 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7457
c1f134b5
PE
7458 * fns.c (concat): Minor tuning based on overflow analysis.
7459 This doesn't fix any bugs. Use int to hold character, instead
7460 of constantly refetching from Emacs object. Use XFASTINT, not
7461 XINT, for value known to be a character. Don't bother comparing
7462 a single byte to 0400, as it's always less.
7463
395fcb93 7464 * floatfns.c (Fexpt):
327eeec8
PE
7465 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7466
abbd3d23
PE
7467 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7468 for characters.
7469
684a03ef
PE
7470 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7471
0fed43f3
PE
7472 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7473 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7474 incorrectly succeed when S was a string, because 4294967386 was
7475 truncated before it was used.
7476
8fd02eb7
PE
7477 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7478 Otherwise, an out-of-range integer could cause undefined behavior
7479 on a 64-bit host.
7480
f8c86b69
PE
7481 * composite.c: Use int, not EMACS_INT, for characters.
7482 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7483 EMACS_INT, for values that are known to be in character range.
7484 This doesn't fix any bugs but is the usual style inside Emacs and
7485 may generate better code on 32-bit machines.
7486
34206dd2
PE
7487 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7488 This is for reasons similar to the recent CHAR_STRING fix.
7489 * charset.c (Fencode_char): Check that character arg is actually
7490 a character. Pass an int to ENCODE_CHAR.
7491 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7492 wider than 'int', as a compile-time check to prevent future regressions
7493 in this area.
7494
c5958d4c 7495 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7496
7497 Make sure a 64-bit char is never passed to CHAR_STRING.
7498 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7499 by silently ignoring the top 32 bits, allowing some values
7500 that were far too large to be valid characters.
7501 * character.h: Include <verify.h>.
7502 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7503 arguments are no wider than unsigned, as a compile-time check
7504 to prevent future regressions in this area.
7505 * data.c (Faset):
01103c44 7506 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7507 (Fsubst_char_in_region):
7508 * fns.c (concat):
7509 * xdisp.c (decode_mode_spec_coding):
7510 Adjust to CHAR_STRING's new requirement.
7511 * editfns.c (Finsert_char, Fsubst_char_in_region):
7512 * fns.c (concat): Check that character args are actually
7513 characters. Without this test, these functions did the wrong
7514 thing with wildly out-of-range values on 64-bit hosts.
7515
d37ca623
PE
7516 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7517 These casts should not be needed on 32-bit hosts, either.
7518 * keyboard.c (read_char):
7519 * lread.c (Fload): Remove casts to unsigned.
7520
ea204efb
PE
7521 * lisp.h (UNSIGNED_CMP): New macro.
7522 This fixes comparison bugs on 64-bit hosts.
7523 (ASCII_CHAR_P): Use it.
7524 * casefiddle.c (casify_object):
01103c44 7525 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7526 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7527 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7528 * dispextern.h (FACE_FROM_ID):
7529 * keyboard.c (read_char): Use UNSIGNED_CMP.
7530
41cb286c
PE
7531 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7532 not to EMACS_INT, to avoid GCC warning.
7533
4a1b9832
PE
7534 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7535
55daad71
PE
7536 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7537 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7538 isn't needed on 32-bit machines.
8f95c75c 7539
01103c44
PE
7540 * buffer.c (Fgenerate_new_buffer_name):
7541 Use EMACS_INT for count, not int.
0ceccced 7542 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7543
7544 * data.c (Qcompiled_function): Now static.
7545
c6f072e7
PE
7546 * window.c (window_body_lines): Now static.
7547
20ce5912
PE
7548 * image.c (gif_load): Rename local to avoid shadowing.
7549
9c4c5f81
PE
7550 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7551 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7552 * alloc.c (make_save_value): Integer argument is now of type
7553 ptrdiff_t, not int.
7554 (mark_object): Use ptrdiff_t, not int.
7555 * lisp.h (pD): New macro.
7556 * print.c (print_object): Use it.
7557
c0c5c8ae
PE
7558 * alloc.c: Use EMACS_INT, not int, to count objects.
7559 (total_conses, total_markers, total_symbols, total_vector_size)
7560 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7561 (total_free_floats, total_floats, total_free_intervals)
7562 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7563 Now EMACS_INT, not int. All uses changed.
7564 (Fgarbage_collect): Compute overall total using a double, so that
7565 integer overflow is less likely to be a problem. Check for overflow
7566 when converting back to an integer.
5a25e253
PE
7567 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7568 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7569 These were 'int' variables that could overflow on 64-bit hosts;
7570 they were never used, so remove them instead of repairing them.
211a0b2a 7571 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7572 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7573 Previously, this ceilinged at INT_MAX, but that doesn't work on
7574 64-bit machines.
e46bb31a 7575 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7576
c78baabf 7577 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7578 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7579 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7580 when a (possibly-narrower) signed value would do just as well.
7581 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7582
c9d624c6
PE
7583 * alloc.c: Catch some string size overflows that we were missing.
7584 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7585 for convenience in STRING_BYTES_MAX.
7586 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7587 The definition here is exact; the one in lisp.h was approximate.
7588 (allocate_string_data): Check for string overflow. This catches
7589 some instances we weren't catching before. Also, it catches
7590 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7591 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7592 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7593
c9d624c6
PE
7594 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7595 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7596 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7597
353032ce
PE
7598 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7599
2bccce07
PE
7600 * alloc.c (Fmake_string): Check for out-of-range init.
7601
0ac30604
SM
76022011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7603
7604 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7605
c195f2de
JD
76062011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7607
7608 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7609 xg_get_default_scrollbar_width.
7610
7611 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7612 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7613 (style_changed_cb): Call update_theme_scrollbar_width and call
7614 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7615 all frames (Bug#8505).
7616 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7617 Call gtk_window_set_resizable if HAVE_GTK3.
7618 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7619 and height if HAVE_GTK3 (Bug#8505).
7620 (scroll_bar_width_for_theme): New variable.
7621 (update_theme_scrollbar_width): New function.
7622 (xg_get_default_scrollbar_width): Move code to
7623 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7624 (xg_initialize): Call update_theme_scrollbar_width.
7625
7626 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7627
7628 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7629
e10ac9f1
MR
76302011-06-12 Martin Rudalics <rudalics@gmx.at>
7631
7632 * frame.c (make_frame): Call other_buffer_safely instead of
7633 other_buffer.
7634
7635 * window.c (temp_output_buffer_show): Call display_buffer with
7636 second argument Vtemp_buffer_show_specifiers and reset latter
7637 immediately after the call.
7638 (Vtemp_buffer_show_specifiers): New variable.
7639 (auto_window_vscroll_p, next_screen_context_lines)
7640 (Vscroll_preserve_screen_position): Remove leading asterisks from
7641 doc-strings.
7642
2d3c217e 76432011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7644
7b7f97e8 7645 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7646 * buffer.c (Qclone_number): Remove for now, as it's unused.
7647 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7648 (record_buffer): Remove unused local.
7649 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7650 (set_frame_buffer_list): Remove; unused.
7651 * frame.h (other_visible_frames): Remove decl.
7652 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7653 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7654 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7655 if HAVE_GPM.
7656 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7657 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7658 Define only if HAVE_GPM.
7659 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7660 (update_hints_inhibit): Remove; never set. All uses removed.
7661 * widgetprv.h (emacsFrameClassRec): Remove decl.
7662 * window.c (delete_deletable_window): Now returns void, since it
7663 wasn't returning anything.
7664 (compare_window_configurations): Remove unused locals.
7665 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7666 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7667 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7668 the same widths as pointers. This follows up on the 2011-05-06 patch.
7669 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7670 * xterm.h: Likewise.
7671 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7672
1384b89e
JB
76732011-06-12 Juanma Barranquero <lekktu@gmail.com>
7674
7675 * makefile.w32-in: Update dependencies.
7676 (LISP_H): Add lib/intprops.h.
7677
1100a63c
CY
76782011-06-11 Chong Yidong <cyd@stupidchicken.com>
7679
7680 * image.c (gif_load): Add animation frame delay to the metadata.
7681 (syms_of_image): Use DEFSYM. New symbol `delay'.
7682
6198ccd0
MR
76832011-06-11 Martin Rudalics <rudalics@gmx.at>
7684
7685 * window.c (delete_deletable_window): Re-add.
7686 (Fset_window_configuration): Rewrite to handle dead buffers and
7687 consequently deletable windows.
7688 (window_tree, Fwindow_tree): Remove. Supply functionality in
7689 window.el.
7690 (compare_window_configurations): Simplify code.
7691
b6e3633c
AS
76922011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7693
1ab0dee5
AS
7694 * image.c (imagemagick_load_image): Fix type mismatch.
7695 (Fimagemagick_types): Likewise.
7696
b6e3633c
AS
7697 * window.h (replace_buffer_in_windows): Declare.
7698
9397e56f
MR
76992011-06-11 Martin Rudalics <rudalics@gmx.at>
7700
7701 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7702 Qclone_number. Remove external declaration of Qdelete_window.
7703 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7704 code.
640c8776
SM
7705 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7706 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7707 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7708 buffer list implementation.
7709 (other_buffer_safely): New function.
7710 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7711 calls to replace_buffer_in_windows and
7712 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7713 if allowed.
7714 (record_buffer): Inhibit quitting and rewrite using quittable
7715 functions. Run Qbuffer_list_update_hook if allowed.
7716 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7717 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7718 Move switch-to-buffer to window.el.
9397e56f
MR
7719 (bury-buffer): Move to window.el.
7720 (Vbuffer_list_update_hook): New variable.
7721
7722 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7723 section.
7724
7725 * window.h (resize_frame_windows): Move up in code.
7726 (Fwindow_frame): Remove EXFUN.
7727 (replace_buffer_in_all_windows): Remove prototype.
7728 (replace_buffer_in_windows_safely): Add prototype.
7729
7730 * window.c: Declare Qdelete_window static again. Move down
7731 declaration of select_count.
7732 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7733 (Fother_window): Move to window.el.
7734 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7735 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7736 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7737 window.el.
7738 (replace_buffer_in_windows): Implement by calling
7739 Qreplace_buffer_in_windows.
7740 (replace_buffer_in_all_windows): Remove with some functionality
7741 moved into replace_buffer_in_windows_safely.
7742 (replace_buffer_in_windows_safely): New function.
7743 (select_window_norecord, select_frame_norecord): Move in front
7744 of run_window_configuration_change_hook. Remove now obsolete
7745 declarations.
640c8776
SM
7746 (Fset_window_buffer): Rewrite doc-string.
7747 Call Qrecord_window_buffer.
9397e56f
MR
7748 (keys_of_window): Move binding for other-window to window.el.
7749
b50691aa
CY
77502011-06-11 Chong Yidong <cyd@stupidchicken.com>
7751
7752 * dispextern.h (struct image): Replace data member, whose int_val
7753 and ptr_val fields were not used by anything, with a single
7754 lisp_val object.
7755
7756 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7757 (gif_clear_image, gif_load, imagemagick_load_image)
7758 (gs_clear_image, gs_load): Callers changed.
7759
3f754b86
PE
77602011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7761
cca69397
PE
7762 * buffer.h: Include <time.h>, for time_t.
7763 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7764
109e28d0
PE
7765 Fix minor problems found by static checking.
7766
60737f02
PE
7767 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7768
4b66faf3
PE
7769 Make identifiers static if they are not used in other modules.
7770 * data.c (Qcompiled_function, Qframe, Qvector):
7771 * image.c (QimageMagick, Qsvg):
7772 * minibuf.c (Qmetadata):
7773 * window.c (resize_window_check, resize_root_window): Now static.
7774 * window.h (resize_window_check, resize_root_window): Remove decls.
7775
109e28d0
PE
7776 * window.c (window_deletion_count, delete_deletable_window):
7777 Remove; unused.
46a4ce9e
PE
7778 (window_body_lines): Now static.
7779 (Fdelete_other_windows_internal): Mark vars as initialized.
7780 Make sure 'resize_failed' is initialized.
7781 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7782 (resize_window_apply): Remove unused local.
7783 * window.h (delete_deletable_window): Remove decl.
7784
109e28d0 7785 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7786 (imagemagick_load_image): Fix pointer signedness problem by changing
7787 last arg from unsigned char * to char *. All uses changed.
7788 Also, fix a local for similar reasons.
7789 Remove unused locals. Remove locals to avoid shadowing.
7790 (fn_rsvg_handle_free): Remove; unused.
7791 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7792 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7793
3f754b86
PE
7794 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7795
2547adb1
CY
77962011-06-10 Chong Yidong <cyd@stupidchicken.com>
7797
7798 * image.c (gif_load): Fix omitted cast error introduced by
7799 2011-06-06 change.
7800
2c8e37d4
MR
78012011-06-10 Martin Rudalics <rudalics@gmx.at>
7802
7803 * window.h (resize_proportionally, orig_total_lines)
7804 (orig_top_line): Remove from window structure.
7805 (set_window_height, set_window_width, change_window_heights)
7806 (Fdelete_window): Remove prototypes.
7807 (resize_frame_windows): Remove duplicate declaration.
7808
440a42e3
EZ
78092011-06-10 Eli Zaretskii <eliz@gnu.org>
7810
7811 * window.h (resize_frame_windows, resize_window_check)
7812 (delete_deletable_window, resize_root_window)
7813 (resize_frame_windows): Declare prototypes.
7814
7815 * window.c (resize_window_apply): Make definition be "static" to
7816 match the prototype.
7817
562dd5e9
MR
78182011-06-10 Martin Rudalics <rudalics@gmx.at>
7819
7820 * window.c: Remove declarations of Qwindow_size_fixed,
7821 window_min_size_1, window_min_size_2, window_min_size,
7822 size_window, window_fixed_size_p, enlarge_window, delete_window.
7823 Remove static from declaration of Qdelete_window, it's
7824 temporarily needed by Fbury_buffer.
7825 (replace_window): Don't assign orig_top_line and
7826 orig_total_lines.
7827 (Fdelete_window, delete_window): Remove. Window deletion is
7828 handled by window.el.
640c8776
SM
7829 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7830 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7831 (Fdelete_other_windows): Remove. Deleting other windows is
7832 handled by window.el.
7833 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7834 handled in window.el.
7835 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7836 Window minimum sizes are handled in window.el.
7837 (shrink_windows, size_window, set_window_height)
7838 (set_window_width, change_window_heights, window_height)
7839 (window_width, CURBEG, CURSIZE, enlarge_window)
7840 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7841 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7842 handled in window.el.
7843 (make_dummy_parent): Rename to make_parent_window and give it a
7844 second argument horflag.
7845 (make_window): Don't set resize_proportionally any more.
7846 (Fsplit_window): Remove. Windows are split in window.el.
7847 (save_restore_action, save_restore_orig_size)
7848 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7849 Resize mini windows in window.el.
7850 (grow_mini_window, shrink_mini_window): Implement by calling
7851 Qresize_root_window_vertically, resize_window_check and
7852 resize_window_apply.
640c8776
SM
7853 (saved_window, Fset_window_configuration, save_window_save):
7854 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7855 resize_proportionally.
7856 (window_min_height, window_min_width): Move to window.el.
7857 (keys_of_window): Move bindings for delete-other-windows,
7858 split-window, delete-window and enlarge-window to window.el.
7859
7860 * buffer.c: Temporarily extern Qdelete_window.
7861 (Fbury_buffer): Temporarily call Qdelete_window instead of
7862 Fdelete_window (Fbury_buffer will move to window.el soon).
7863
7864 * frame.c (set_menu_bar_lines_1): Remove code handling
7865 orig_top_line and orig_total_lines.
7866
7867 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7868 set_window_height but set heights directly.
7869 (change_frame_size_1): Use resize_frame_windows.
7870
7871 * xdisp.c (init_xdisp): Don't use set_window_height but set
7872 heights directly.
7873
640c8776
SM
7874 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7875 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7876 run_window_configuration_change_hook.
7877
7878 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7879 instead of change_window_heights and run
7880 run_window_configuration_change_hook.
7881
1a13852e
MR
78822011-06-09 Martin Rudalics <rudalics@gmx.at>
7883
7884 * window.c (replace_window): Rename second argument REPLACEMENT to
7885 NEW. New third argument SETFLAG. Rewrite.
7886 (delete_window, make_dummy_parent): Call replace_window with
7887 third argument 1.
7888 (window_list_1): Move down in code.
7889 (run_window_configuration_change_hook): Move set_buffer part
7890 before select_frame_norecord part in order to unwind correctly.
7891 Rename count1 to count.
7892 (recombine_windows, delete_deletable_window, resize_root_window)
7893 (Fdelete_other_windows_internal)
7894 (Frun_window_configuration_change_hook, make_parent_window)
7895 (resize_window_check, resize_window_apply, Fresize_window_apply)
7896 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7897 (Fdelete_window_internal, Fresize_mini_window_internal):
7898 New functions.
1a13852e
MR
7899 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7900
f3d1777e
MR
79012011-06-08 Martin Rudalics <rudalics@gmx.at>
7902
496e208e
MR
7903 * window.h (window): Add some new members to window structure -
7904 normal_lines, normal_cols, new_total, new_normal, clone_number,
7905 splits, nest, prev_buffers, next_buffers.
7906 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7907 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7908
f3d1777e
MR
7909 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7910 Remove.
496e208e
MR
7911 (make_dummy_parent): Set new members of windows structure.
7912 (make_window): Move down in code. Handle new members of window
7913 structure.
7914 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7915 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7916 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7917 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7918 (Fset_window_next_buffers, Fset_window_clone_number):
7919 New functions.
496e208e
MR
7920 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7921 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7922 Doc-string fixes.
7923 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7924 Argument WINDOW can be now internal window too.
7925 (Fwindow_use_time): Move up in code.
7926 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7927 Rewrite doc-string.
7928 (Fset_window_configuration, saved_window)
7929 (Fcurrent_window_configuration, save_window_save): Handle new
7930 members of window structure.
b9e809c2
MR
7931 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7932 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7933 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7934 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7935 Qget_mru_window, Qresize_root_window,
7936 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7937 Qauto_buffer_name; staticpro them.
f3d1777e 7938
abde8f8c
MR
79392011-06-07 Martin Rudalics <rudalics@gmx.at>
7940
7941 * window.c (Fwindow_total_size, Fwindow_left_column)
7942 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7943 (Fwindow_list_1): New functions.
7944 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7945 (Fwindow_width, Fscroll_left, Fscroll_right):
7946 Use window_body_cols instead of window_box_text_cols.
7947 (delete_window, Fset_window_configuration):
7948 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7949 (delete_all_subwindows): Take a window as argument and not a
7950 structure. Rewrite.
190b47e6
MR
7951 (window_loop): Remove handling of GET_LRU_WINDOW and
7952 GET_LARGEST_WINDOW.
7953 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7954
7955 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7956 window_box_text_cols. delete_all_subwindows now takes a
7957 Lisp_Object as argument.
abde8f8c 7958
640c8776
SM
7959 * indent.c (compute_motion, Fcompute_motion):
7960 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7961
fa8a67e6
MR
7962 * frame.c (delete_frame): Call delete_all_subwindows with root
7963 window as argument.
7964
a54e3482
DC
79652011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7966
7967 * fns.c (Fputhash): Document return value.
7968
60002bf5
CY
79692011-06-06 Chong Yidong <cyd@stupidchicken.com>
7970
7971 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7972
0c671da6 79732011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7974
b862a52a 7975 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7976
be44ca6c
PE
7977 Check for overflow when converting integer to cons and back.
7978 * charset.c (Fdefine_charset_internal, Fdecode_char):
7979 Use cons_to_unsigned to catch overflow.
7980 (Fencode_char): Use INTEGER_TO_CONS.
7981 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7982 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7983 * data.c (long_to_cons, cons_to_long): Remove.
7984 (cons_to_unsigned, cons_to_signed): New functions.
7985 These signal an error for invalid or out-of-range values.
7986 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7987 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7988 * font.c (Ffont_variation_glyphs):
7989 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7990 * lisp.h: Include <intprops.h>.
7991 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7992 (cons_to_signed, cons_to_unsigned): New decls.
7993 (long_to_cons, cons_to_long): Remove decls.
7994 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7995 (Fprimitive_undo): Use CONS_TO_INTEGER.
7996 * xfns.c (Fx_window_property): Likewise.
7997 * xselect.c: Include <limits.h>.
7998 (x_own_selection, selection_data_to_lisp_data):
7999 Use INTEGER_TO_CONS.
8000 (x_handle_selection_request, x_handle_selection_clear)
8001 (x_get_foreign_selection, Fx_disown_selection_internal)
8002 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8003 (lisp_data_to_selection_data): Use cons_to_unsigned.
8004 (x_fill_property_data): Use cons_to_signed.
8005 Report values out of range.
8006
d1f3d2af
PE
8007 Check for buffer and string overflow more precisely.
8008 * buffer.h (BUF_BYTES_MAX): New macro.
8009 * lisp.h (STRING_BYTES_MAX): New macro.
8010 * alloc.c (Fmake_string):
8011 * character.c (string_escape_byte8):
8012 * coding.c (coding_alloc_by_realloc):
8013 * doprnt.c (doprnt):
8014 * editfns.c (Fformat):
8015 * eval.c (verror):
8016 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8017 since they may not be the same number.
8018 * editfns.c (Finsert_char):
8019 * fileio.c (Finsert_file_contents):
8020 Likewise for BUF_BYTES_MAX.
8021
dd52fcea
PE
8022 * image.c: Use ptrdiff_t, not int, for sizes.
8023 (slurp_file): Switch from int to ptrdiff_t.
8024 All uses changed.
8025 (slurp_file): Check that file size fits in both size_t (for
8026 malloc) and ptrdiff_t (for sanity and safety).
8027
7f9bbdbb
PE
8028 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8029 if b->modtime has its maximal value.
8030
dfe18f82
PE
8031 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8032
84acfcf0
PE
8033 Don't assume time_t can fit into int.
8034 * buffer.h (struct buffer.modtime): Now time_t, not int.
8035 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8036 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8037
ccd9a01a
PE
8038 Minor fixes for signed vs unsigned integers.
8039 * character.h (MAYBE_UNIFY_CHAR):
8040 * charset.c (maybe_unify_char):
8041 * keyboard.c (read_char, reorder_modifiers):
8042 XINT -> XFASTINT, since the integer must be nonnegative.
8043 * ftfont.c (ftfont_spec_pattern):
8044 * keymap.c (access_keymap, silly_event_symbol_error):
8045 XUINT -> XFASTINT, since the integer must be nonnegative.
8046 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8047 since it makes no difference and we prefer signed.
8048 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8049 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8050 nonnegative.
8051
d6d100dd
SM
80522011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8053
8054 * window.h (Fwindow_frame): Declare.
8055
2b6148e4
PE
80562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8057
8058 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8059 (SPARE_MEMORY): Always define.
8060 (LARGE_REQUEST): Remove.
8061 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8062
f230ecc9
MR
80632011-06-06 Martin Rudalics <rudalics@gmx.at>
8064
727e958e
MR
8065 * lisp.h: Move EXFUNS for Fframe_root_window,
8066 Fframe_first_window and Fset_frame_selected_window to window.h.
8067
8068 * window.h: Move EXFUNS for Fframe_root_window,
8069 Fframe_first_window and Fset_frame_selected_window here from
8070 lisp.h.
8071
8072 * frame.c (Fwindow_frame, Fframe_first_window)
8073 (Fframe_root_window, Fframe_selected_window)
8074 (Fset_frame_selected_window): Move to window.c.
8075 (Factive_minibuffer_window): Move to minibuf.c.
8076 (Fother_visible_frames_p): New function.
8077
8078 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8079
f230ecc9
MR
8080 * window.c (decode_window, decode_any_window): Move up in code.
8081 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8082 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8083 (Fwindow_buffer): Move up and rewrite doc-string.
8084 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8085 (Fwindow_prev): New functions.
727e958e
MR
8086 (Fwindow_frame): Move here from frame.c. Accept any window as
8087 argument.
8088 (Fframe_root_window, Fframe_first_window)
8089 (Fframe_selected_window): Move here from frame.c. Accept frame
8090 or arbitrary window as argument. Update doc-strings.
8091 (Fminibuffer_window): Move up in code.
8092 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8093 (Fset_frame_selected_window): Move here from frame.c.
8094 Marginal rewrite.
727e958e
MR
8095 (Fselected_window, select_window, Fselect_window): Move up in
8096 code. Minor doc-string fixes.
f230ecc9 8097
4d09bcf6
PE
80982011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8099
8100 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8101 Do not assume that spare memory exists; that assumption is valid
8102 only if SYSTEM_MALLOC.
8103 (LARGE_REQUEST): New macro, so that the issue of large requests
8104 is separated from the issue of spare memory.
8105
810928a2
AS
81062011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8107
172418ad
AS
8108 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8109 format. (Bug#8806)
8110
43f862f7
AS
8111 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8112
810928a2
AS
8113 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8114 before statements.
8115
a059fe24
JD
81162011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8117
8118 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8119
8120 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8121
8122 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8123 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8124
989bf368
JB
81252011-06-05 Juanma Barranquero <lekktu@gmail.com>
8126
8127 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8128
4b80f674
CY
81292011-06-04 Chong Yidong <cyd@stupidchicken.com>
8130
8131 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8132 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8133 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8134 New error handlers.
4b80f674
CY
8135 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8136 Obey Vx_select_enable_clipboard_manager. Catch errors in
8137 x_clipboard_manager_save (Bug#8779).
8138 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8139 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8140
99a33b77 81412011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8142
8143 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8144
99a33b77 81452011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8146
8147 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8148 in the current matrix if keep_current_p is non-zero.
8149
8264569d
EZ
81502011-06-04 Eli Zaretskii <eliz@gnu.org>
8151
8152 * bidi.c (bidi_level_of_next_char): Fix last change.
8153
57f97249
EZ
81542011-06-03 Eli Zaretskii <eliz@gnu.org>
8155
fec2107c 8156 Support bidi reordering of text covered by display properties.
57f97249 8157
fec2107c
EZ
8158 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8159 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8160 (bidi_cache_search, bidi_cache_iterator_state)
8161 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8162 (bidi_level_of_next_char, bidi_move_to_visually_next):
8163 Support character positions inside a run of characters covered by a
fec2107c
EZ
8164 display string.
8165 (bidi_paragraph_init, bidi_resolve_explicit_1)
8166 (bidi_level_of_next_char): Call bidi_fetch_char and
8167 bidi_fetch_char_advance instead of FETCH_CHAR and
8168 FETCH_CHAR_ADVANCE.
8169 (bidi_init_it): Initialize new members.
8170 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8171 definitions.
8172 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8173 instead of using explicit *_CHAR codes.
d6d100dd
SM
8174 (bidi_resolve_explicit, bidi_resolve_weak):
8175 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8176 bidirectional text is supported only in multibyte buffers.
8177 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8178 it to initialize the frame_window_p member of struct bidi_it.
8179 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8180 (bidi_resolve_explicit, bidi_resolve_weak)
8181 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8182 bidi_it->nchars is non-positive.
8183 (bidi_level_of_next_char): Don't try to lookup the cache for the
8184 next/previous character if nothing is cached there yet, or if we
8185 were just reseat()'ed to a new position.
c40e2fb2 8186
0e14fe90
EZ
8187 * xdisp.c (set_cursor_from_row): Set start and stop points
8188 according to the row's direction when priming the loop that looks
8189 for the glyph on which to display cursor.
8190 (single_display_spec_intangible_p): Function deleted.
8191 (display_prop_intangible_p): Reimplement to call
8192 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8193 Accept 3 additional arguments needed by handle_display_spec.
8194 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8195 values: lists, `(when COND...)' forms, etc.
8196 (single_display_spec_string_p): Support property values that are
8197 lists with the argument STRING its top-level element.
8198 (display_prop_string_p): Fix the condition for processing a
8199 property that is a list to be consistent with handle_display_spec.
fec2107c 8200 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8201 last portion of handle_display_prop.
8202 (compute_display_string_pos): Accept additional argument
8203 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8204 value of a `display' property is a "replacing spec".
8205 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8206 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8207 the display property, but just return a value indicating whether
8208 the display property will replace the characters it covers.
8209 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8210 frame_window_p members of struct bidi_it.
d6d100dd
SM
8211 (compute_display_string_pos, compute_display_string_end):
8212 New functions.
fec2107c
EZ
8213 (push_it): Accept second argument POSITION, where pop_it should
8214 jump to continue iteration.
8215 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8216
fec2107c
EZ
8217 * keyboard.c (adjust_point_for_property): Adjust the call to
8218 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8219
8220 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8221 (bidi_init_it): Update prototypes.
8222 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8223 (compute_display_string_pos, compute_display_string_end):
8224 Declare prototypes.
fec2107c
EZ
8225 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8226 EMACS_INT.
fc6f18ce 8227
40087514 82282011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8229
57f53182
PE
8230 Malloc failure behavior now depends on size of allocation.
8231 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8232 * lisp.h: Change signatures accordingly.
8233 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8234 All callers changed. (Bug#8762)
8235
8236 * gnutls.c: Use Emacs's memory allocators.
8237 Without this change, the gnutls library would invoke malloc etc.
8238 directly, which causes problems on non-SYNC_INPUT hosts, and which
8239 runs afoul of improving memory_full behavior. (Bug#8761)
8240 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8241 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8242 xfree instead of the default malloc, realloc, free.
8243 (Fgnutls_boot): No need to check for memory allocation failure,
8244 since xmalloc does that for us.
8245
ac32cd99 8246 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8247 * category.c (hash_get_category_set):
8248 * ccl.c (ccl_driver):
8249 * charset.c (Fdefine_charset_internal):
8250 * charset.h (struct charset.hash_index):
8251 * composite.c (get_composition_id, gstring_lookup_cache)
8252 (composition_gstring_put_cache):
8253 * composite.h (struct composition.hash_index):
8254 * dispextern.h (struct image.hash):
8255 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8256 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8257 (hashfn_equal, hashfn_user_defined, make_hash_table)
8258 (maybe_resize_hash_table, hash_lookup, hash_put)
8259 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8260 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8261 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8262 * image.c (make_image, search_image_cache, lookup_image)
8263 (xpm_put_color_table_h):
8264 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8265 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8266 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8267 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8268 * alloc.c (allocate_vectorlike):
8269 Check for overflow in vector size calculations.
8270 * ccl.c (ccl_driver):
8271 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8272 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8273 need to be updated by these changes.
40087514
PE
8274 * fns.c (make_hash_table, maybe_resize_hash_table):
8275 Check for integer overflow with large hash tables.
0de4bb68
PE
8276 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8277 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8278 (SXHASH_REDUCE): New macro.
8279 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8280 Use it instead of discarding useful hash info with large hash values.
8281 (sxhash_float): New function.
8282 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8283 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8284 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8285 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8286 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8287 Adjust signatures to match updated version of code.
8288 (consing_since_gc): Now EMACS_INT, since a single hash table can
8289 use more than INT_MAX bytes.
8290
698d32e2
DN
82912011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8292
8293 Make it possible to build with GCC-4.6+ -O2 -flto.
8294
8295 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8296
fd6fa53f
SM
82972011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8298
8299 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8300 Call minibuffer-inactive-mode.
8301
864db017
JB
83022011-05-31 Juanma Barranquero <lekktu@gmail.com>
8303
8304 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8305 Update dependencies.
8306
2ad0baf4
DN
83072011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8308
8309 * data.c (init_data): Remove code for UTS, this system is not
8310 supported anymore.
8311
4fcc2638
DN
83122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8313
8314 Don't force ./temacs to start in terminal mode.
8315
8316 * frame.c (make_initial_frame): Initialize faces in all cases, not
8317 only when CANNOT_DUMP is defined.
8318 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8319
c56e0fd5
DN
83202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8321
8322 * dispnew.c (add_window_display_history): Use const for the string
8323 pointer. Remove declaration, not needed.
8324
333d54da 83252011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8326
55d4c1b2 8327 Use 'inline', not 'INLINE'.
333d54da 8328 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8329 * alloc.c, fontset.c (INLINE): Remove.
8330 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8331 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8332 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8333 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8334 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8335
738db178
DN
83362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8337
8338 Make it possible to run ./temacs.
8339
8340 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8341 syms_of_callproc does the same thing. Remove test for
8342 "initialized", do it in the caller.
8343 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8344
620c53a6
SM
83452011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8346
8347 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8348 (read_minibuf): Use get_minibuffer.
8349 (syms_of_minibuf): Use DEFSYM.
8350 (Qmetadata): New var.
8351 * data.c (Qbuffer): Don't make it static.
8352 (syms_of_data): Use DEFSYM.
8353
e003a292
PE
83542011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8355
8356 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8357 (CCL_CODE_MIN): New macro.
8358
ed008a6d
PE
83592011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8360
3687c2ef
PE
8361 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8362
ed008a6d
PE
8363 * eval.c (Qdebug): Now static.
8364 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8365 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8366 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8367
d66c4c7c
CY
83682011-05-29 Chong Yidong <cyd@stupidchicken.com>
8369
8370 * image.c: Various fixes to ImageMagick code comments.
8371 (Fimagemagick_types): Doc fix.
8372
5fbc2025
PE
83732011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8374
0196f88a
PE
8375 Minor fixes prompted by GCC 4.6.0 warnings.
8376
8377 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8378
5fbc2025
PE
8379 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8380 (x_clipboard_manager_save_all): Move extern decl to ...
8381 * xterm.h: ... here, so that it can be checked for consistency.
8382
1dd3c2d9
CY
83832011-05-29 Chong Yidong <cyd@stupidchicken.com>
8384
8385 * xselect.c (x_clipboard_manager_save_frame)
8386 (x_clipboard_manager_save_all): New functions.
8387 (Fx_clipboard_manager_save): Lisp function deleted.
8388
8389 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8390 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8391
8392 * xterm.h: Update prototype.
8393
5ba6571d
WX
83942011-05-28 William Xu <william.xwl@gmail.com>
8395
8396 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8397 exiting (Bug#8239).
8398
3eaff834
JM
83992011-05-28 Jim Meyering <meyering@redhat.com>
8400
e1900994 8401 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8402 * fns.c (to_uchar): Define.
8403 (crypto_hash_function): Use it to convert some newly-signed
8404 variables to unsigned, to avoid sign-extension bugs. For example,
8405 without this change, (md5 "truc") would evaluate to
8406 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8407 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8408 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8409
0f6990a7
PE
84102011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8411
8412 Integer overflow fixes.
c8a9ca5a 8413
08686060
PE
8414 * dbusbind.c: Serial number integer overflow fixes.
8415 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8416 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8417 to hold a serial number that is too large for a fixnum.
8418 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8419 Check for serial numbers out of range. Decode any serial number
59568bf0 8420 that was so large that it became a float. (Bug#8722)
08686060 8421
2d1fc3c7
PE
8422 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8423 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8424 Use XFASTINT rather than XUINT when numbers are nonnegative.
8425 (xd_append_arg, Fdbus_method_return_internal):
8426 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8427 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8428 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8429 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8430 (Bug#8722)
2d1fc3c7 8431
c8a9ca5a
PE
8432 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8433
519e1d69
PE
8434 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8435
6df6ae42 8436 ccl: Add integer overflow checks.
30569699
PE
8437 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8438 (IN_INT_RANGE): New macros.
8439 (ccl_driver): Use them to check for integer overflow when
8440 decoding a CCL program. Many of the new checks are whether XINT (x)
8441 fits in int; it doesn't always, on 64-bit hosts. The new version
8442 doesn't catch all possible integer overflows, but it's an
847044ea 8443 improvement. (Bug#8719)
30569699 8444
c11285dc
PE
8445 * alloc.c (make_event_array): Use XINT, not XUINT.
8446 There's no need for unsigned here.
8447
fdccd48e
PE
8448 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8449 This follows up to the 2011-05-06 change that substituted uintptr_t
8450 for EMACS_INT. This case wasn't caught back then.
8451
37910ab2
PE
8452 Rework Fformat to avoid integer overflow issues.
8453 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8454 now (part of C89). Include <verify.h>.
8455 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8456 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8457 (Fformat): Avoid the prepass trying to compute sizes; it was only
8458 approximate and thus did not catch overflow reliably. Instead, walk
8459 through the format just once, formatting and computing sizes as we go,
8460 checking for integer overflow at every step, and allocating a larger
8461 buffer as needed. Keep track separately whether the format is
8462 multibyte. Keep only the most-recently calculated precision, rather
8463 than them all. Record whether each argument has been converted to
8464 string. Use EMACS_INT, not int, for byte and char and arg counts.
8465 Support field widths and precisions larger than INT_MAX. Avoid
8466 sprintf's undefined behavior with conversion specifications such as %#d
8467 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8468 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8469 formatting out-of-range floating point numbers with int
9173deec 8470 formats. (Bug#8668)
37910ab2 8471
2e6578fb
PE
8472 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8473
0ae6bdee
PE
8474 * data.c: Avoid integer truncation in expressions involving floats.
8475 * data.c: Include <intprops.h>.
8476 (arith_driver): When there's an integer overflow in an expression
8477 involving floating point, convert the integers to floating point
8478 so that the resulting value does not suffer from catastrophic
8479 integer truncation. For example, on a 64-bit host (* 4
8480 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8481 Do not rely on undefined behavior after integer overflow.
8482
de883a70
PE
8483 merge count_size_as_multibyte, parse_str_to_multibyte
8484 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8485 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8486 Check for integer overflow.
8487 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8488 since it's now a duplicate of the other. This is more of
8489 a character than a buffer op, so better that it's in character.c.
8490 * fns.c, print.c: Adjust to above changes.
8491
2ff916cb
PE
84922011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8493
8494 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8495
f1b54466
PE
84962011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8497
fb1ac845
PE
8498 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8499 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8500 (x_clipboard_manager_save): Now static.
8501 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8502
f1b54466
PE
8503 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8504 (crypto_hash_function): Now static.
8505 Fix pointer signedness problems. Avoid unnecessary initializations.
8506
a9f737ee
CY
85072011-05-27 Chong Yidong <cyd@stupidchicken.com>
8508
8509 * termhooks.h (Vselection_alist): Make it terminal-local.
8510
8511 * terminal.c (create_terminal): Initialize it.
8512
8513 * xselect.c: Support for clipboard managers.
8514 (Vselection_alist): Move to termhooks.h as terminal-local var.
8515 (LOCAL_SELECTION): New macro.
8516 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8517 (symbol_to_x_atom): Remove gratuitous arg.
8518 (x_handle_selection_request, lisp_data_to_selection_data)
8519 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8520 (x_own_selection, x_get_local_selection, x_convert_selection):
8521 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8522 (some_frame_on_display): Delete unused function.
8523 (Fx_own_selection_internal, Fx_get_selection_internal)
8524 (Fx_disown_selection_internal, Fx_selection_owner_p)
8525 (Fx_selection_exists_p): New optional frame arg.
8526 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8527 (x_handle_selection_clear): Don't treat other terminals with the
8528 same keyboard specially. Use the terminal-local Vselection_alist.
8529 (x_clear_frame_selections): Use Frun_hook_with_args.
8530
8531 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8532
8533 * xterm.h: Add support for those atoms.
8534
e067f0c1
CY
85352011-05-26 Chong Yidong <cyd@stupidchicken.com>
8536
8537 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8538 (converted_selections, conversion_fail_tag): New global variables.
8539 (x_selection_request_lisp_error): Free the above.
8540 (x_get_local_selection): Remove unnecessary code.
8541 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8542 of converted selections stored in converted_selections.
8543 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8544 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8545 (x_convert_selection): New function.
8546 (x_handle_selection_event): Simplify.
8547 (x_get_foreign_selection): Don't ignore incoming requests while
8548 waiting for an answer; this will fail when we implement
8549 SAVE_TARGETS, and seems unnecessary anyway.
8550 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8551 (Vx_sent_selection_functions): Doc fix.
8552
0f4aebc0
LL
85532011-05-26 Leo Liu <sdl.web@gmail.com>
8554
8555 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8556
e61124cd
YM
85572011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8558
8559 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8560
8561 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8562 for fringe update if it has periodic bitmap.
ac389d0c 8563 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8564 and fringe_bitmap_periodic_p.
8565
8566 * fringe.c (get_fringe_bitmap_data): New function.
8567 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8568 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8569 row. Mark glyph row for fringe update if periodicity changed.
8570
8571 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8572 for fringe update unless it has periodic bitmap.
8573
f16d9837
KH
85742011-05-25 Kenichi Handa <handa@m17n.org>
8575
8576 * xdisp.c (get_next_display_element): Set correct it->face_id for
8577 a static composition.
8578
e1b90ef6
LL
85792011-05-24 Leo Liu <sdl.web@gmail.com>
8580
8581 * deps.mk (fns.o):
8582 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8583
8584 * fns.c (crypto_hash_function, Fsha1): New function.
8585 (Fmd5): Use crypto_hash_function.
8586 (syms_of_fns): Add Ssha1.
8587
7400048f
PE
85882011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8589
8590 * gnutls.c: Remove unused macros.
8591 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8592 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8593 Remove macros that are defined and never used.
8594 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8595
abb71cf4
CY
85962011-05-22 Chong Yidong <cyd@stupidchicken.com>
8597
8598 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8599 (Fx_get_selection_internal): Minor cleanup.
8600 (Fx_own_selection_internal): Rename arguments for consistency with
8601 select.el.
8602
6307db39
PE
86032011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8604
8605 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8606
f3d4e0a4
CY
86072011-05-22 Chong Yidong <cyd@stupidchicken.com>
8608
8609 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8610
4d8ade89
YM
86112011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8612
8613 * dispnew.c (scrolling_window): Don't exclude the case that the
8614 last enabled row in the desired matrix touches the bottom boundary.
8615
32078c8d
GM
86162011-05-21 Glenn Morris <rgm@gnu.org>
8617
8618 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8619 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8620 and add some more files.
32078c8d 8621
7285dc67
EZ
86222011-05-20 Eli Zaretskii <eliz@gnu.org>
8623
8624 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8625 report_file_error introduced by the change from 2011-05-07.
8626
89d1bd22
PE
86272011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8628
8629 * systime.h (Time): Define only if emacs is defined.
8630 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8631 where the include path doesn't have X11/X.h by default. See
8632 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8633
cd394be1 86342011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8635
8636 * composite.c (find_automatic_composition): Fix previous change.
8637
b9704ad9
GM
86382011-05-20 Glenn Morris <rgm@gnu.org>
8639
8640 * lisp.mk: New file, split from Makefile.in.
8641 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8642 (shortlisp): Remove.
8643 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8644
4a720484
GM
86452011-05-19 Glenn Morris <rgm@gnu.org>
8646
8647 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8648 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8649 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8650 (lisp): Set the order to that of loadup.el.
8651 (shortlisp): Make it a copy of $lisp.
8652 (SOME_MACHINE_LISP): Remove.
8653 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8654 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8655
a28d4396
KH
86562011-05-18 Kenichi Handa <handa@m17n.org>
8657
8658 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8659 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8660 (find_automatic_composition): Mostly rewrite for efficiency.
8661
a2b1fa8e
JB
86622011-05-18 Juanma Barranquero <lekktu@gmail.com>
8663
8664 * makefile.w32-in: Update dependencies.
8665
8e1f5610
CS
86662011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8667
8668 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8669 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8670
7025ee00 86712011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8672
cdfa6eab
PE
8673 Fix some integer overflow issues, such as string length overflow.
8674
06d6db33
PE
8675 * insdel.c (count_size_as_multibyte): Check for string overflow.
8676
2b4560a8
PE
8677 * character.c (lisp_string_width): Check for string overflow.
8678 Use EMACS_INT, not int, for string indexes and lengths; in
8679 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8680 the resulting string length overflows an EMACS_INT; instead,
8681 report a string overflow if no precision given. When checking for
8682 precision exhaustion, use a check that cannot possibly have
8683 integer overflow. (Bug#8675)
8684 * character.h (lisp_string_width): Adjust to new signature.
8685
cb93f9be
PE
8686 * alloc.c (string_overflow): New function.
8687 (Fmake_string): Use it. This doesn't change behavior, but saves
8688 a few bytes and will simplify future changes.
8689 * character.c (string_escape_byte8): Likewise.
8690 * lisp.h (string_overflow): New decl.
8691
1a1f3366
PE
8692 Fixups, following up to the user-interface timestamp change.
8693 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8694 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8695 * msdos.c (mouse_get_pos): Likewise.
8696 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8697 * w32gui.h (Time): Define by including "systime.h" rather than by
8698 declaring it ourselves. (Bug#8664)
8699
d4e3e4d3
PE
8700 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8701 * image.c (clear_image_cache): Likewise.
8702
f6a24d19
PE
8703 * term.c (term_mouse_position): Don't assume time_t wraparound.
8704
08dc5ae6
PE
8705 Be more systematic about user-interface timestamps.
8706 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8707 and sometimes 'EMACS_UINT', to represent these timestamps.
8708 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8709 This makes the code easier to follow, and makes it easier to catch
8710 integer overflow bugs such as Bug#8664.
8711 * frame.c (Fmouse_position, Fmouse_pixel_position):
8712 Use Time, not unsigned long, for user-interface timestamps.
8713 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8714 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8715 * keyboard.h (last_event_timestamp): Likewise.
8716 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8717 * menu.h (xmenu_show): Likewise.
8718 * term.c (term_mouse_position): Likewise.
8719 * termhooks.h (struct input_event.timestamp): Likewise.
8720 (struct terminal.mouse_position_hook): Likewise.
8721 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8722 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8723 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8724 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8725 what it was before.
8726 * menu.h, termhooks.h: Include "systime.h", for Time.
8727
8e55734a
PE
8728 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8729 Don't assume that the difference between two unsigned long values
8730 can fit into an integer. At this point, we know button_down_time
8731 <= event->timestamp, so the difference must be nonnegative, so
8732 there's no need to cast the result if double-click-time is
8733 nonnegative, as it should be; check that it's nonnegative, just in
8734 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8735 apart (about 25 days). (Bug#8664)
8e55734a 8736
841f1b75 8737 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8738 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8739
3e26f69c
PE
8740 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8741 that always fit in int. Use a sentinel instead of a counter, to
8742 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8743 * frame.h (struct frame): Use int for menu_bar_items_used
8744 instead of EMACS_INT, since it always fits in int.
3e26f69c 8745
5cc152c0
PE
8746 * menu.c (grow_menu_items): Check for int overflow.
8747
d89eb65e
PE
8748 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8749
5235bd3e
PE
8750 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8751 Before, the code was not consistent. These values cannot exceed
8752 2**31 - 1 so there's no need to make them unsigned.
8753 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8754 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8755 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8756 as modifiers.
8757 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8758
bc827e23
PE
8759 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8760 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8761 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8762 presumably because the widths might not match.
8763
78eb494e
PE
8764 * window.c (size_window): Avoid needless test at loop start.
8765
04f2d78b
CB
87662011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8767
8768 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8769
d2fc7e3d 87702011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8771
8772 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8773
d2fc7e3d 87742011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8775
8776 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8777 `width' to `bar_area_x' and `bar_area_width', respectively.
8778 (x_scroll_run): Take account of fringe background extension.
8779
04f2d78b
CB
8780 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8781 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8782 `bar_area_width', respectively.
8783 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8784 background extension.
8785
79b70037
GM
87862011-05-10 Jim Meyering <meyering@redhat.com>
8787
8788 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8789
2f142cc5
JB
87902011-05-10 Juanma Barranquero <lekktu@gmail.com>
8791
8792 * image.c (Finit_image_library): Return t for built-in image types,
8793 like pbm and xbm. (Bug#8640)
8794
57679c86
AS
87952011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8796
8797 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8798
888c9e86
EZ
87992011-05-07 Eli Zaretskii <eliz@gnu.org>
8800
b0512a1d
EZ
8801 * w32console.c (Fset_screen_color): Doc fix.
8802 (Fget_screen_color): New function.
8803 (syms_of_ntterm): Defsubr it.
8804
7285dc67
EZ
8805 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8806 unlink the temporary file if Fcall_process didn't create it in the
8807 first place.
8808 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8809 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8810 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8811 cue to call_process_cleanup not to close that handle.
8812
4d3fcc8e
BK
88132011-05-07 Ben Key <bkey76@gmail.com>
8814
8815 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8816 one of two shell specific rules, either bootstrap-temacs-CMD or
8817 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8818 to the previous implementation of the bootstrap-temacs rule.
8819 The bootstrap-temacs-CMD rule is similar to the previous
8820 implementation of the bootstrap-temacs rule except that it
8821 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8822 variable.
8823
8824 These changes, along with some changes to nt/configure.bat,
8825 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8826 earlier fix to add support for --cflags and --ldflags options
8827 that include quotes so that it works whether make uses cmd or
8828 sh as the shell.
8829
b4289b64
MA
88302011-05-06 Michael Albinus <michael.albinus@gmx.de>
8831
8832 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8833 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8834 is a constant.
8835 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8836 a string. Handle both cases.
8837 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8838 (Fdbus_register_method): Use Qinvalid_function.
8839
af4c0e28
JB
88402011-05-06 Juanma Barranquero <lekktu@gmail.com>
8841
8842 * makefile.w32-in: Update dependencies.
8843 (LISP_H): Add inttypes.h and stdin.h.
8844 (PROCESS_H): Add unistd.h.
8845
c51453d9
EZ
88462011-05-06 Eli Zaretskii <eliz@gnu.org>
8847
8848 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8849 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8850
8ff0ac3c 88512011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8852
4c4b566b
PE
8853 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8854
aab2b9b5
PE
8855 * term.c (vfatal): Remove stray call to va_end.
8856 It's not needed and the C Standard doesn't allow it here anyway.
8857
c378da0b
PE
8858 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8859 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8860
288b08c7
PE
8861 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8862 bytes.
8863
e3601888
PE
8864 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8865
db6c0e74
PE
8866 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8867
dd5963ea
PE
8868 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8869
88c9450f
PE
8870 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8871
2f9442b8
PE
8872 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8873
c032b5f8
PE
8874 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8875 * charset.c (Fdefine_charset_internal): Don't initialize
8876 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8877 32-bit int (Bug#8600).
a108c10b
PE
8878
8879 * lread.c (read_integer): Be more consistent with string-to-number.
8880 Use string_to_number to do the actual conversion; this avoids
8881 rounding errors and fixes some other screwups. Without this fix,
8882 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8883 (digit_to_number): Move earlier, for benefit of read_integer.
8884 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8885 not a digit in any supported base. (Bug#8602)
a108c10b 8886
ad5f9eea
PE
8887 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8888
aec1708a
PE
8889 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8890 to match comment at start of function. This also removes a
8891 GCC warning about overflow in a 32+64-bit port.
8892
47be4ab5
PE
8893 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8894
371cac43
PE
8895 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8896 Reported by Stefan Monnier in
8897 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8898 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8899 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8900
d01a7826
PE
8901 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8902 (EMACS_UINTPTR): Likewise, with uintptr_t.
8903
7fd47d5c
PE
8904 * lisp.h: Prefer 64-bit EMACS_INT if available.
8905 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8906 on 32-bit hosts that have 64-bit int, so that they can access
8907 large files.
122b0c86
PE
8908 However, temporarily disable this change unless the temporary
8909 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8910
8727937b
PE
8911 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8912
8ac068ac
PE
8913 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8914 This removes an assumption that EMACS_INT and long are the same
8915 width as pointers. The assumption is true for Emacs porting targets
8916 now, but we want to make other targets possible.
8917 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8918 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8919 In the rest of the code, change types of integers that hold casted
8920 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8921 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8922 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8923 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8924 No need to cast type when ORing.
8925 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8926 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8927 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8928 assume EMACS_INT is the same width as char *.
8929 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8930 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8931 Remove no-longer-needed casts.
8932 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8933 (xg_tool_bar_help_callback, xg_make_tool_item):
8934 Use EMACS_INTPTR to hold an integer
8935 that will be cast to void *; this can avoid a GCC warning
8936 if EMACS_INT is not the same width as void *.
8937 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8938 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8939 (current_message_1, set_message_1):
8940 Use a local to convert to proper width without a cast.
8941 * xmenu.c (dialog_selection_callback): Likewise.
8942
ede49d71
PE
8943 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8944 Also, don't assume VALBITS / RAND_BITS is less than 5,
8945 and don't rely on undefined behavior when shifting a 1 left into
8946 the sign bit.
8947 * lisp.h (get_random): Change signature to match.
8948
2f30ecd0
PE
8949 * lread.c (hash_string): Use size_t, not int, for hash computation.
8950 Normally we prefer signed values; but hashing is special, because
8951 it's better to use unsigned division on hash table sizes so that
8952 the remainder is nonnegative. Also, size_t is the natural width
8953 for hashing into memory. The previous code used 'int', which doesn't
8954 retain enough info to hash well into very large tables.
8955 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8956
2a866e7b
PE
8957 * dbusbind.c: Don't possibly lose pointer info when converting.
8958 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8959 Use XPNTR rather than XHASH, so that the high-order bits of
8960 the pointer aren't lost when converting through void *.
8961
51639eac
PE
8962 * eval.c (Fautoload): Don't double-shift a pointer.
8963
92394119
PE
8964 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8965
dbdb9a7c
JB
89662011-05-06 Juanma Barranquero <lekktu@gmail.com>
8967
8968 * gnutls.c (DEF_GNUTLS_FN):
8969 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8970
db7a0b4f
AS
89712011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8972
8973 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8974 marker. (Bug#8610)
8975
cd394be1 89762011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8977
8978 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8979 New version that can reserve upto 2GB of heap space.
8980
f7ff1b0f 89812011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8982
8983 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8984
639c109b
TZ
89852011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8986
8987 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8988 `gnutls_certificate_set_x509_key_file'.
8989
d2127135
JB
89902011-05-05 Juanma Barranquero <lekktu@gmail.com>
8991
8992 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8993 Update dependencies.
8994
e968f4f3
JB
89952011-05-04 Juanma Barranquero <lekktu@gmail.com>
8996
8997 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8998 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8999 Remove unused parameter `fildes'.
9000 * process.c (read_process_output, send_process): Don't pass it.
9001
84d358f0
JB
90022011-05-04 Juanma Barranquero <lekktu@gmail.com>
9003
9004 Fix previous change: the library cache is defined in w32.c.
9005 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9006 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9007
0898ca10
JB
90082011-05-04 Juanma Barranquero <lekktu@gmail.com>
9009
9010 Implement dynamic loading of GnuTLS on Windows.
9011
9012 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9013 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9014 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9015 Declare.
9016
9017 * gnutls.c (Qgnutls_dll): Define.
9018 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9019 (gnutls_*): Declare function pointers.
9020 (init_gnutls_functions): New function to initialize function pointers.
9021 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9022 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9023 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9024 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9025 (emacs_gnutls_write, emacs_gnutls_read)
9026 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9027 (Fgnutls_available_p): New function.
9028 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9029 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9030 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9031
9032 * image.c: Include w32.h.
9033 (Vimage_type_cache): Delete.
9034 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9035 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9036 (w32_delayed_load): Move to w32.c.
9037
9038 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9039
9040 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9041 (w32_delayed_load): Move from image.c. When loading a library, record
9042 its filename in the :loaded-from property of the library id.
9043 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9044 Initialize and staticpro them.
9045 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9046
9047 * process.c: Include lisp.h before w32.h, not after.
9048 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9049 instead of gnutls_record_check_pending.
9050
9051 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9052
ff4de4aa
TZ
90532011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9054
9055 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9056 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9057 as passed in.
9058
abe95abb
JD
90592011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9060
9061 * xterm.c (x_set_frame_alpha): Do not set property on anything
9062 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9063
e16e55d4
JB
90642011-05-02 Juanma Barranquero <lekktu@gmail.com>
9065
9066 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9067
bafcf6a5
JB
90682011-05-02 Juanma Barranquero <lekktu@gmail.com>
9069
9070 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9071 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9072 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9073 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9074 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9075 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9076 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9077 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9078 (Qgnutls_bootprop_callbacks_verify): Make static.
9079
e7a6747f
AS
90802011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9081
19ed11ba
AS
9082 * callproc.c: Indentation fixup.
9083
e7a6747f 9084 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9085 (wait_for_termination, interruptible_wait_for_termination):
9086 Move after wait_for_termination_1.
e7a6747f 9087
1ef14cb4
LMI
90882011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9089
9090 * sysdep.c (interruptible_wait_for_termination): New function
9091 which is like wait_for_termination, but allows keyboard
9092 interruptions.
9093
9094 * callproc.c (Fcall_process): Add (:file "file") as an option for
9095 the STDOUT buffer.
9096 (Fcall_process_region): Ditto.
9097
330d880c
EZ
90982011-04-30 Eli Zaretskii <eliz@gnu.org>
9099
8db90b73
EZ
9100 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9101 rather than `XVECTOR (FOO)->size'.
9102
330d880c
EZ
9103 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9104 inttypes.h, as a gnulib replacement is used if it not available in
9105 system headers.
9106
15cbd324
EZ
91072011-04-21 Eli Zaretskii <eliz@gnu.org>
9108
9109 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9110 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9111 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9112
9113 * coding.c (coding_alloc_by_realloc): Error out if destination
9114 will grow beyond MOST_POSITIVE_FIXNUM.
9115 (decode_coding_emacs_mule): Abort if there isn't enough place in
9116 charbuf for the composition carryover bytes. Reserve an extra
9117 space for up to 2 characters produced in a loop.
9118 (decode_coding_iso_2022): Abort if there isn't enough place in
9119 charbuf for the composition carryover bytes.
9120
91212011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9122
ae940cca
EZ
9123 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9124 aborting when %lld or %lll format is passed.
9125 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9126 %llo or %llx format is passed. (Bug#8545)
9127
03ab8921
EZ
9128 * window.c (window_scroll_line_based): Use a marker instead of
9129 simple variables to record original value of point. (Bug#7952)
9130
afda1437
EZ
9131 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9132 produced by %s or %c overflows available buffer space. (Bug#8545)
9133
f76dee0c
PE
91342011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9135
9136 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9137 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9138
fdc5744d
JB
91392011-04-28 Juanma Barranquero <lekktu@gmail.com>
9140
9141 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9142
638f053a
JB
91432011-04-28 Juanma Barranquero <lekktu@gmail.com>
9144
9145 * keyboard.c (Qdelayed_warnings_hook): Define.
9146 (command_loop_1): Run `delayed-warnings-hook'
9147 if Vdelayed_warnings_list is non-nil.
9148 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9149 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9150
d178f871
EZ
91512011-04-28 Eli Zaretskii <eliz@gnu.org>
9152
9153 * doprnt.c (doprnt): Don't return value smaller than the buffer
9154 size if the message was truncated. (Bug#8545).
9155
b124fd93
JB
91562011-04-28 Juanma Barranquero <lekktu@gmail.com>
9157
9158 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9159 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9160
e810457d
PE
91612011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9162
9163 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9164
ea51cceb
JB
91652011-04-27 Juanma Barranquero <lekktu@gmail.com>
9166
9167 * makefile.w32-in: Update dependencies.
9168
94dcfacf
EZ
91692011-04-27 Eli Zaretskii <eliz@gnu.org>
9170
9171 Improve `doprnt' and its usage. (Bug#8545)
9172 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9173 `format_end'. Remove support for %l as a conversion specifier.
9174 Don't use xrealloc. Improve diagnostics when the %l size modifier
9175 is used. Update the commentary.
9176
9177 * eval.c (verror): Simplify calculation of size_t.
9178
9179 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9180 messages.
9181
f61f41d7
PE
91822011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9183
9184 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9185 change.
9186
96fb4434
PE
91872011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9188
9189 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9190 This makes this file independent of the recent pseudovector change.
9191
671875da 91922011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9193
69e9b5a3
PE
9194 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9195
b5f869a7 9196 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9197 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9198 Remove unused local.
c8926152 9199 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9200
841a1577 9201 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9202 GCC 4.6.0 optimizes based on type-based alias analysis.
9203 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9204 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9205 != &v->size, and therefore "v->size = 1; b->size = 2; return
9206 v->size;" must therefore return 1. This assumption is incorrect
9207 for Emacs, since it type-puns struct Lisp_Vector * with many other
9208 types. To fix this problem, this patch adds a new type struct
f904488f 9209 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9210 and pseudovectors, and helps optimizing compilers not get fooled
9211 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9212 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9213 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9214 the size member.
eab3844f
PE
9215 (XSETPVECTYPE): Rewrite in terms of new macro.
9216 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9217 This is a bit clearer, and further avoids the possibility of
9218 undesirable aliasing.
9219 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9220 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9221 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9222 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9223 (ASIZE): Now uses header.size rather than size.
9224 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9225 to avoid the hassle of writing XVECTOR (foo)->header.size.
9226 (struct vectorlike_header): New type.
eab3844f
PE
9227 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9228 object, to help avoid aliasing.
9229 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9230 (SUBRP): Likewise, since Lisp_Subr is a special case.
9231 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9232 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9233 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9234 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9235 changed to be "header.size" and "header.next".
9236 * buffer.h (struct buffer): Likewise.
9237 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9238 * frame.h (struct frame): Likewise.
9239 * process.h (struct Lisp_Process): Likewise.
9240 * termhooks.h (struct terminal): Likewise.
9241 * window.c (struct save_window_data, struct saved_window): Likewise.
9242 * window.h (struct window): Likewise.
9243 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9244 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9245 * buffer.c (init_buffer_once): Likewise.
9246 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9247 special case.
9248 * process.c (Fformat_network_address): Use local var for size,
9249 for brevity.
9250
0df1eac5
PE
9251 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9252
847ab9d1 9253 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9254 * data.c (atof): Remove decl; no longer used or needed.
9255 (digit_to_number): Move to lread.c.
9256 (Fstring_to_number): Use new string_to_number function, to be
9257 consistent with how the Lisp reader treats infinities and NaNs.
9258 Do not assume that floating-point numbers represent EMACS_INT
9259 without losing information; this is not true on most 64-bit hosts.
9260 Avoid double-rounding errors, by insisting on integers when
9261 parsing non-base-10 numbers, as the documentation specifies.
9262 * lisp.h (string_to_number): New decl, replacing ...
9263 (isfloat_string): Remove.
bc0a5c13 9264 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9265 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9266 appears to have been a coding error. Similarly, do not accept
9267 strings like +-1e0 as floating point numbers. Do not report
9268 overflow for integer overflows unless the base is not 10 which
9269 means we have no simple and reliable way to continue.
9270 Break out the floating-point parsing into a new
9271 function string_to_number, so that Fstring_to_number parses
9272 floating point numbers consistently with the Lisp reader.
04f2d78b 9273 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9274 (E_CHAR, EXP_INT): Remove, replacing with ...
9275 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9276 (string_to_number): New function, replacing isfloat_string.
9277 This function checks for valid syntax and produces the resulting
9278 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9279 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9280 so that overflow for non-base-10 numbers is reported only when
9281 there's no portable and simple way to convert to floating point.
452f4150 9282
67769ffc
PE
9283 * textprop.c (set_text_properties_1): Rewrite for clarity,
9284 and to avoid GCC warning about integer overflow.
9285
c20db43f
PE
9286 * intervals.h (struct interval): Use EMACS_INT for members
9287 where EMACS_UINT might cause problems. See
9288 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9289 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9290 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9291 All uses changed.
37aa2f85
PE
9292 (offset_intervals): Tell GCC not to worry about length overflow
9293 when negating a negative length.
c20db43f 9294
2538aa2f
PE
9295 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9296 (overrun_check_free): Likewise.
9297
f2d3008d
PE
9298 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9299 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9300 word size.
9301
ec8df744
PE
9302 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9303 (gnutls_make_error): Rename local to avoid shadowing.
9304 (gnutls_emacs_global_deinit): ifdef out; not used.
9305 (Fgnutls_boot): Use const for pointer to readonly storage.
9306 Comment out unused local. Fix pointer signedness problems.
9307
640ee02d
PE
9308 * lread.c (openp): Don't stuff size_t into an 'int'.
9309 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9310 about possible signed overflow.
9311
6048fb2a
PE
9312 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9313 (GDK_KEY_g): Don't define if already defined.
9314 (xg_prepare_tooltip): Avoid pointer signedness problem.
9315 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9316
fa3c87e1
PE
9317 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9318 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9319
2172544b
PE
9320 * xfns.c (Fx_window_property): Simplify a bit,
9321 to make a bit faster and to avoid GCC 4.6.0 warning.
9322 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9323
9b821a21
PE
9324 * fns.c (internal_equal): Don't assume size_t fits in int.
9325
3c616cfa
PE
9326 * alloc.c (compact_small_strings): Tighten assertion a little.
9327
c2982e87
PE
9328 Replace pEd with more-general pI, and fix some printf arg casts.
9329 * lisp.h (pI): New macro, generalizing old pEd macro to other
9330 conversion specifiers. For example, use "...%"pI"d..." rather
9331 than "...%"pEd"...".
9332 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9333 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9334 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9335 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9336 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9337 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9338 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9339 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9340 64-bit hosts.
9341 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9342 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9343 * print.c (safe_debug_print, print_object): Likewise.
9344 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9345 to int.
6f04d126
PE
9346 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9347 avoiding the 0 flag, which is not portable.
c2982e87
PE
9348 * process.c (Fmake_network_process): Use pI to avoid cast.
9349 * region-cache.c (pp_cache): Likewise.
9350 * xdisp.c (decode_mode_spec): Likewise.
9351 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9352 behavior on 64-bit hosts with printf arg.
6f04d126 9353 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9354 (x_stop_queuing_selection_requests): Likewise.
9355 (x_get_window_property): Don't truncate byte count to an 'int'
9356 when tracing.
0b432f21 9357
5e073ec7
PE
9358 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9359 here, since it parses constructs like leading '-' and spaces,
9360 which are not wanted; and it overflows with large numbers.
9361 Instead, simply match F[0-9]+, which is what is wanted anyway.
9362
36372bf9
PE
9363 * alloc.c: Remove unportable assumptions about struct layout.
9364 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9365 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9366 (allocate_vectorlike, make_pure_vector): Use the new macros,
9367 plus offsetof, to remove unportable assumptions about struct layout.
9368 These assumptions hold on all porting targets that I know of, but
9369 they are not guaranteed, they're easy to remove, and removing them
9370 makes further changes easier.
9371
0b432f21
PE
9372 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9373 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9374 (string_overrun_cookie): Now const. Use initializers that
9375 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9376 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9377 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9378 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9379 multiple of sizeof (EMACS_INT); it need not be, if
9380 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9381 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9382
895009e1
JB
93832011-04-26 Juanma Barranquero <lekktu@gmail.com>
9384
9385 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9386
6a7a1b0b
TZ
93872011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9388
9389 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9390 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9391 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9392
841a1577 93932011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9394
9395 * lisp.h (Qdebug): List symbol.
895009e1 9396 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9397 * keyboard.c (debug-on-event): New variable.
9398 (handle_user_signal): Break into debugger when debug-on-event
9399 matches the current signal symbol.
9400
f2d3ba6f
DN
94012011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9402
9403 * alloc.c (check_sblock, check_string_bytes)
9404 (check_string_free_list): Convert to standard C.
9405
42ce4c63
TZ
94062011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9407
9408 * w32.c (emacs_gnutls_push): Fix typo.
9409
825cd63c
EZ
94102011-04-25 Eli Zaretskii <eliz@gnu.org>
9411
fb11d64d
EZ
9412 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9413 "cast to pointer from integer of different size".
9414
825cd63c
EZ
9415 Improve doprnt and its use in verror. (Bug#8545)
9416 * doprnt.c (doprnt): Document the set of format control sequences
9417 supported by the function. Use SAFE_ALLOCA instead of always
9418 using `alloca'.
9419
9420 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9421 is one byte too soon. Don't use xrealloc; instead xfree and
9422 xmalloc anew.
9423
e061a11b
TZ
94242011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9425
9426 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9427 callbacks stage.
9428
9429 * gnutls.c: Renamed global_initialized to
9430 gnutls_global_initialized. Added internals for the
9431 :verify-hostname-error, :verify-error, and :verify-flags
9432 parameters of `gnutls-boot' and documented those parameters in the
9433 docstring. Start callback support.
9173deec
JB
9434 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9435 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9436 on error. Return error code.
e061a11b
TZ
9437 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9438 (emacs_gnutls_read): Likewise.
9439 (Fgnutls_boot): Return handshake error code.
9440 (emacs_gnutls_handle_error): New function.
9441 (wsaerror_to_errno): Likewise.
9442
9443 * w32.h (emacs_gnutls_pull): Add prototype.
9444 (emacs_gnutls_push): Likewise.
9445
9446 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9447 (emacs_gnutls_push): Likewise.
9448
94492011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9450
9451 * process.c (wait_reading_process_output): Check if GnuTLS
9452 buffered some data internally if no FDs are set for TLS
9453 connections.
9454
9455 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9456 (LIBS): Link to USER_LIBS.
9457 ($(BLD)/gnutls.$(0)): New target.
9458
fa6996bc
EZ
94592011-04-24 Eli Zaretskii <eliz@gnu.org>
9460
eb35682e
EZ
9461 * xdisp.c (handle_single_display_spec): Rename the
9462 display_replaced_before_p argument into display_replaced_p, to
9463 make it consistent with the commentary. Fix typos in the
9464 commentary.
9465
e2ad650c
EZ
9466 * textprop.c (syms_of_textprop): Remove dead code.
9467 (copy_text_properties): Delete obsolete commentary about an
9468 interface that was deleted long ago. Fix typos in the description
9469 of arguments.
9470
1b2de274
EZ
9471 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9472 to changes in oldXMenu/XMenu.h from 2011-04-16.
9473 <menu_help_message, prev_menu_help_message>: Constify.
9474 (IT_menu_make_room): menu->help_text is now `const char **';
9475 adjust.
9476
9477 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9478 to changes in oldXMenu/XMenu.h from 2011-04-16.
9479 (struct XMenu): Declare `help_text' `const char **'.
9480
9481 * xfaces.c <Qunspecified>: Make extern again.
9482
9483 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9484 required by POSIX.
1b2de274 9485
762b15be
EZ
9486 * doc.c (get_doc_string): Improve the format passed to `error'.
9487
9488 * doprnt.c (doprnt): Improve commentary.
9489
9490 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9491
9492 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9493 them with etags.
9494
f1052e5d
EZ
9495 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9496 changes in globals.h immediately force recompilation.
762b15be
EZ
9497 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9498 $(CURDIR)/s/ms-w32.h.
9499 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9500
fa6996bc
EZ
9501 * character.c (Fchar_direction): Function deleted.
9502 (syms_of_character): Don't defsubr it.
9503 <char-direction-table>: Deleted.
9504
e6c3da20
EZ
95052011-04-23 Eli Zaretskii <eliz@gnu.org>
9506
9507 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9508 * doprnt.c: Include limits.h.
9509 (SIZE_MAX): New macro.
04f2d78b
CB
9510 (doprnt): Return a size_t value. 2nd arg is now size_t.
9511 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9512 Improve overflow protection. Support `l' modifier for integer
9513 conversions. Support %l conversion. Don't assume an EMACS_INT
9514 argument for integer conversions and for %c.
9515
9516 * lisp.h (doprnt): Restore prototype.
9517
9518 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9519 $(SRC)/character.h.
9520
9521 * Makefile.in (base_obj): Add back doprnt.o.
9522
9523 * deps.mk (doprnt.o): Add back prerequisites.
9524 (callint.o): Depend on character.h.
9525
9526 * eval.c (internal_lisp_condition_case): Include the handler
9527 representation in the error message.
9528 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9529 when breaking from the loop.
9530
9531 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9532
9533 * callint.c (Fcall_interactively): When displaying error message
9534 about invalid control letter, pass the character's codepoint, not
9535 a pointer to its multibyte form. Improve display of the character
9536 in octal and display also its hex code.
9537
9538 * character.c (char_string): Use %x to display the (unsigned)
9539 codepoint of an invalid character, to avoid displaying a bogus
9540 negative value.
9541
9542 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9543 `error', not SYMBOL_NAME itself.
9544
9545 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9546 character arguments to `error'.
9547
9548 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9549 to `error' in error message about FINAL_CHAR argument. Make sure
9550 FINAL_CHAR is a character, and use %c when it is passed as
9551 argument to `error'.
9552
4ffd0d6b 95532011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9554
9555 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9556
9557 * w32.c: Include <time.h>.
9558 (sys_localtime): New function.
9559
4ffd0d6b 95602011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9561
9562 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9563
4ffd0d6b 9564 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9565
4ffd0d6b 95662011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9567
4ffd0d6b
GM
9568 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9569 zombies (Bug#8467).
aac0c6e3 9570
04c56954
EZ
95712011-04-19 Eli Zaretskii <eliz@gnu.org>
9572
9573 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9574 gl_state.e_property when gl_state.object is Qt.
9575
9576 * insdel.c (make_gap_larger): Remove limitation of buffer size
9577 to <= INT_MAX.
9578
16a43933
CY
95792011-04-18 Chong Yidong <cyd@stupidchicken.com>
9580
9581 * xdisp.c (lookup_glyphless_char_display)
9582 (produce_glyphless_glyph): Handle cons cell entry in
9583 glyphless-char-display.
9584 (Vglyphless_char_display): Document it.
9585
9586 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9587 glyphless-char-display.
9588
4581706e
CY
95892011-04-17 Chong Yidong <cyd@stupidchicken.com>
9590
9591 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9592
9593 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9594
9595 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9596 definition for no-X builds.
9597
4887c6e2 95982011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9599
fd35b6f9
PE
9600 Static checks with GCC 4.6.0 and non-default toolkits.
9601
5c1ccb01
PE
9602 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9603
006c5daa
PE
9604 * process.c (keyboard_bit_set): Define only if SIGIO.
9605 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9606 (send_process): Repair possible setjmp clobbering.
9607
efc736d3
PE
9608 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9609
4e2fe2e6
PE
9610 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9611
f97334a2
PE
9612 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9613
4e75f29d
PE
9614 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9615 Define only if needed.
9616
90efadd1
PE
9617 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9618 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9619 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9620
3c647824
PE
9621 * dispextern.h (struct redisplay_interface): Rename param
9622 to avoid shadowing.
e264f262 9623 * termhooks.h (struct terminal): Likewise.
761383f4 9624 * xterm.c (xembed_send_message): Likewise.
3c647824 9625
b58c5c4a
PE
9626 * insdel.c (make_gap_smaller): Define only if
9627 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9628
cad59032
PE
9629 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9630 it.
9631
c339dc2e
PE
9632 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9633 so that we aren't warned about unused symbols.
9634
91a3e27b
PE
9635 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9636
399c71d3 9637 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9638
8ffc96f5
PE
9639 * xfns.c (x_real_positions): Mark locals as initialized.
9640
eef9bc79
PE
9641 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9642
098db9dd
PE
9643 * xterm.c: Fix problems found by static analysis with other toolkits.
9644 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9645 (x_dispatch_event): Declare static if USE_GTK, and
9646 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9647 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9648 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9649 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9650 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9651
eb18f6cc
PE
9652 * xmenu.c (menu_help_callback): Pointer type fixes.
9653 Use const pointers when pointing at readonly data. Avoid pointer
9654 signedness clashes.
9655 (FALSE): Remove unused macro.
9656 (update_frame_menubar): Remove unused decl.
9657
1fe72bf8
PE
9658 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9659
60d9e1db
PE
9660 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9661 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9662 (single_menu_item): Rename local to avoid shadowing.
9663
39261c26
PE
9664 * keyboard.c (make_lispy_event): Remove unused local var.
9665
018c5e19
PE
9666 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9667 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9668
63d2b86e
PE
9669 * bitmaps: Change bitmaps from unsigned char back to the X11
9670 compatible char. Avoid the old compiler warnings about
9671 out-of-range initializers by using, for example, '\xab' rather
9672 than 0xab.
9673
aefd87e1
PE
9674 * xgselect.c (xgselect_initialize): Check vs interface
9675 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9676
bf501fb9
PE
9677 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9678
e9829fdf
PE
9679 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9680 to read-only memory.
9681
1086c095
PE
9682 * fns.c (vector): Remove; this old hack is no longer needed.
9683
2baccd04 9684 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9685 Remove unused var.
dde42981 9686 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9687
72391843 9688 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9689
436c16df 9690 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9691 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9692 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9693
92bb796d 9694 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9695 (x_term_init): Remove local to avoid shadowing.
92bb796d 9696
764430a3 9697 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9698
9699 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9700 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9701
d1dfb56c
EZ
97022011-04-16 Eli Zaretskii <eliz@gnu.org>
9703
c4354cb4
EZ
9704 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9705
d1dfb56c
EZ
9706 Fix regex.c, syntax.c and friends for buffers > 2GB.
9707 * syntax.h (struct gl_state_s): Declare character position members
9708 EMACS_INT.
9709
9710 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9711
04f2d78b
CB
9712 * textprop.c (verify_interval_modification, interval_of):
9713 Declare arguments EMACS_INT.
d1dfb56c
EZ
9714
9715 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9716 EMACS_INT.
9717
9718 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9719
9720 * indent.c (Fvertical_motion): Local variable it_start is now
9721 EMACS_INT.
9722
9723 * regex.c (re_match, re_match_2, re_match_2_internal)
9724 (bcmp_translate, regcomp, regexec, print_double_string)
9725 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9726 (re_compile_pattern, re_exec): Declare arguments and local
9727 variables `size_t' and `ssize_t' and return values `regoff_t', as
9728 appropriate.
9729 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9730 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9731 <compile_stack_type>: `size' and `avail' are now `size_t'.
9732
9733 * regex.h <regoff_t>: Use ssize_t, not int.
9734 (re_search, re_search_2, re_match, re_match_2): Arguments that
9735 specify buffer/string position and length are now ssize_t and
9736 size_t. Return type is regoff_t.
9737
613052cd
BK
97382011-04-16 Ben Key <bkey76@gmail.com>
9739
9740 * nsfont.m: Fixed bugs in ns_get_family and
9741 ns_descriptor_to_entity that were caused by using free to
9742 deallocate memory blocks that were allocated by xmalloc (via
9743 xstrdup). This caused Emacs to crash when compiled with
9744 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9745 --enable-checking=xmallocoverrun). xfree is now used to
9746 deallocate these memory blocks.
9747
4170f62f 97482011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9749
71b41406
PE
9750 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9751
9587a89d
PE
9752 emacs_write: Accept and return EMACS_INT for sizes.
9753 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9754 et seq.
9755 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9756 Accept and return EMACS_INT.
9757 (emacs_gnutls_write): Return the number of bytes written on
9758 partial writes.
9759 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9760 (emacs_read, emacs_write): Remove check for negative size, as the
9761 Emacs source code has been audited now.
9587a89d
PE
9762 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9763 (emacs_read, emacs_write): Use it.
273a5f82
PE
9764 * process.c (send_process): Adjust to the new signatures of
9765 emacs_write and emacs_gnutls_write. Do not attempt to store
9766 a byte offset into an 'int'; it might overflow.
9587a89d 9767 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9768
3e047f51
PE
9769 * sound.c: Don't assume sizes fit in 'int'.
9770 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9771 Return EMACS_INT, not int.
3e047f51 9772 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9773 Accept EMACS_INT, not int.
9774 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9775 record read return values.
9776
cc39a9db
BK
97772011-04-15 Ben Key <bkey76@gmail.com>
9778
c9d0ec6d
JB
9779 * keyboard.c (Qundefined): Don't declare static since it is used
9780 in nsfns.m.
9781 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9782 static since they are used in nsfont.m.
cc39a9db 9783
6c60eb9f
SM
97842011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9785
9786 * process.c (Qprocessp): Don't declare static.
9787 * lisp.h (Qprocessp): Declare again.
9788
7990b61a
JB
97892011-04-15 Juanma Barranquero <lekktu@gmail.com>
9790
9791 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9792
5d4cb038
PE
97932011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9794
8bd7b830 9795 Improve C-level modularity by making more things 'static'.
cd64ea1d 9796
e3b27b31
PE
9797 Don't publish debugger-only interfaces to other modules.
9798 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9799 (verify_bytepos, count_markers): Move decls to the only modules
9800 that need them.
9801 * region-cache.h (pp_cache): Likewise.
9802 * window.h (check_all_windows): Likewise.
9803 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9804
5d4cb038
PE
9805 * sysdep.c (croak): Now static, if
9806 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9807 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9808
9809 * alloc.c (refill_memory_reserve): Now static if
9810 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9811 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9812
e87b6180
PE
9813 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9814 Define only if USE_LUCID.
9815
ac64929e
PE
9816 * xrdb.c (x_customization_string, x_rm_string): Now static.
9817
6f37259d
PE
9818 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9819 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9820
1683e3ab
PE
9821 * xdisp.c (draw_row_with_mouse_face): Now static.
9822 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9823
de9c2632
PE
9824 * window.h (check_all_windows): Mark externally visible.
9825
2b96acb7
PE
9826 * window.c (window_deletion_count): Now static.
9827
9828 * undo.c: Make symbols static if they're not exported.
9829 (last_undo_buffer, last_boundary_position, pending_boundary):
9830 Now static.
9831
50436f33
PE
9832 * textprop.c (interval_insert_behind_hooks): Now static.
9833 (interval_insert_in_front_hooks): Likewise.
9834
64520e5c
PE
9835 * term.c: Make symbols static if they're not exported.
9836 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9837 (max_frame_lines, tty_set_terminal_modes):
9838 (tty_reset_terminal_modes, tty_turn_off_highlight):
9839 (get_tty_terminal): Now static.
9840 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9841 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9842 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9843 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9844 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9845
1fa53021
PE
9846 * sysdep.c: Make symbols static if they're not exported.
9847 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9848 Now static.
9849 (sigprocmask_set, full_mask): Remove; unused.
9850 (wait_debugging): Mark as visible.
9851 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9852 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9853
d4b43b22
PE
9854 * syntax.c (syntax_temp): Define only if !__GNUC__.
9855
b7c513d0
PE
9856 * sound.c (current_sound_device, current_sound): Now static.
9857
989b29ad
PE
9858 * search.c (searchbufs, searchbuf_head): Now static.
9859
13a55a78
PE
9860 * scroll.c (scroll_cost): Remove; unused.
9861 * dispextern.h (scroll_cost): Remove decl.
9862
de68a1fc
PE
9863 * region-cache.h (pp_cache): Mark as externally visible.
9864
40ccffa6
PE
9865 * process.c: Make symbols static if they're not exported.
9866 (process_tick, update_tick, create_process, chan_process):
9867 (Vprocess_alist, proc_buffered_char, datagram_access):
9868 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9869 (deactivate_process): Mark defn as static, as well as decl.
9870 * lisp.h (create_process): Remove decl.
9871 * process.h (chan_process, Vprocess_alist): Remove decls.
9872
ad64fc97
PE
9873 * print.c: Make symbols static if they're not exported.
9874 (print_depth, new_backquote_output, being_printed, print_buffer):
9875 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9876 (print_interval, print_number_index, initial_stderr_stream):
9877 Now static.
9878 * lisp.h (Fprinc): Remove decl.
9879 (debug_output_compilation_hack): Mark as externally visible.
9880
adddb265
PE
9881 * sysdep.c (croak): Move decl from here to syssignal.h.
9882 * syssignal.h (croak): Put it here, so the API can be checked when
9883 'croak' is called from dissociate_if_controlling_tty.
9884
1717ede2
PE
9885 * minibuf.c: Make symbols static if they're not exported.
9886 (minibuf_save_list, choose_minibuf_frame): Now static.
9887 * lisp.h (choose_minibuf_frame): Remove decl.
9888
fa5fb2bc
PE
9889 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9890
1e3890d1
PE
9891 * lread.c: Make symbols static if they're not exported.
9892 (read_objects, initial_obarray, oblookup_last_bucket_number):
9893 Now static.
9894 (make_symbol): Remove; unused.
9895 * lisp.h (initial_obarray, make_symbol): Remove decls.
9896
8a1414fa
PE
9897 * keyboard.c: Make symbols static if they're not exported.
9898 (single_kboard, recent_keys_index, total_keys, recent_keys):
9899 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9900 (this_single_command_key_start, echoing, last_auto_save):
9901 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9902 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9903 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9904 (Vlispy_mouse_stem, double_click_count):
9905 Now static.
9906 (force_auto_save_soon): Define only if SIGDANGER.
9907 (ignore_mouse_drag_p): Now static if
9908 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9909 (print_help): Remove; unused.
9910 (stop_character, last_timer_event): Mark as externally visible.
9911 * keyboard.h (ignore_mouse_drag_p): Declare only if
9912 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9913 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9914 * lisp.h (echoing): Remove decl.
9915 (force_auto_save_soon): Declare only if SIGDANGER.
9916 * xdisp.c (redisplay_window): Simplify code, to make it more
9917 obvious that ignore_mouse_drag_p is not accessed if !defined
9918 USE_GTK && !defined HAVE_NS.
9919
93ea6e8f
PE
9920 * intervals.c: Make symbols static if they're not exported.
9921 (merge_properties_sticky, merge_interval_right, delete_interval):
9922 Now static.
9923 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9924
77382fcc
PE
9925 * insdel.c: Make symbols static if they're not exported.
9926 However, leave prepare_to_modify_buffer alone. It's never
9927 called from outside this function, but that appears to be a bug.
9928 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9929 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9930 (adjust_after_replace_noundo): Remove; unused.
9931 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9932 (signal_before_change): Remove decls.
77382fcc 9933
9306c32e
PE
9934 * indent.c (val_compute_motion, val_vmotion): Now static.
9935
cd44d2eb
PE
9936 * image.c: Make symbols static if they're not exported.
9937 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9938 if USE_GTK.
9939 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9940 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9941
ad9a7a06
PE
9942 * fringe.c (standard_bitmaps): Now static.
9943 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9944
81626931
PE
9945 * frame.c: Make symbols static if they're not exported.
9946 (x_report_frame_params, make_terminal_frame): Now static.
9947 (get_frame_param): Now static, unless HAVE_NS.
9948 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9949 (x_get_resource_string): Remove; not used.
9950 * frame.h (make_terminal_frame, x_report_frame_params):
9951 (x_get_resource_string); Remove decls.
9952 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9953 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9954
239f9db9
PE
9955 * font.c, fontset.c: Make symbols static if they're not exported.
9956 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9957 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9958 * font.c (font_close_object): Now static.
9959 * font.h (font_close_object): Remove.
9960 * fontset.c (FONTSET_OBJLIST): Remove.
9961 (free_realized_fontset) #if-0 the body, which does nothing.
9962 (face_suitable_for_char_p): #if-0, as it's never called.
9963 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9964 * xfaces.c (face_at_string_position):
9965 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9966 since 0 is always ASCII.
9967
dfcf3579
PE
9968 * fns.c (weak_hash_tables): Now static.
9969
5045092b
PE
9970 * fileio.c: Make symbols static if they're not exported.
9971 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9972 (Vwrite_region_annotation_buffers): Now static.
9973
57a96f5c
PE
9974 * eval.c: Make symbols static if they're not exported.
9975 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9976 * lisp.h (backtrace_list): Remove decl.
9977
35f08c38
PE
9978 * emacs.c: Make symbols static if they're not exported.
9979 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9980 (fatal_error_code, fatal_error_signal_hook, standard_args):
9981 Now static.
9982 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9983 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9984 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9985 * lisp.h (fatal_error_signal_hook): Remove decl.
9986 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9987
f44bd759
PE
9988 * editfns.c: Move a (normally-unused) function to its only use.
9989 * editfns.c, lisp.h (get_operating_system_release): Remove.
9990 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9991 worth the hassle of breaking this out.
9992
b532497d
PE
9993 * xterm.c: Make symbols static if they're not exported.
9994 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9995 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9996 (x_destroy_window, x_delete_display):
9997 Now static.
9998 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9999 (x_mouse_leave): Remove; unused.
10000 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10001 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10002 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10003 Remove decls.
10004 (x_mouse_leave): Declare only if WINDOWSNT.
10005 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10006 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10007 USE_X_TOOLKIT.
10008
1675728f
PE
10009 * ftxfont.c: Make symbols static if they're not exported.
10010 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10011 HAVE_FREETYPE.
10012 * font.h (ftxfont_driver): Likewise.
10013
e4cebfca
PE
10014 * xfns.c: Make symbols static if they're not exported.
10015 (x_last_font_name, x_display_info_for_name):
10016 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10017 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10018 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10019 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10020 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10021 (last_show_tip_args): Now static.
10022 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10023 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10024 (x_screen_planes): Remove; unused.
10025 * dispextern.h (x_screen_planes): Remove decl.
10026
5bf46f05
PE
10027 * dispnew.c: Make symbols static if they're not exported.
10028 * dispextern.h (redraw_garbaged_frames, scrolling):
10029 (increment_row_positions): Remove.
10030 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10031 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10032 Now static.
10033 (redraw_garbaged_frames): Remove; unused.
10034
435f4c28
PE
10035 * xfaces.c: Make symbols static if they're not exported.
10036 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10037 Remove decls.
10038 * xterm.h (defined_color): Remove decls.
10039 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10040 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10041 (menu_face_changed_default, defined_color, free_realized_face):
10042 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10043 (ascii_face_of_lisp_face): Remove; unused.
10044
8524aef3
PE
10045 * xdisp.c: Make symbols static if they're not exported.
10046 * dispextern.h (scratch_glyph_row, window_box_edges):
10047 (glyph_to_pixel_coords, set_cursor_from_row):
10048 (get_next_display_element, set_iterator_to_next):
10049 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10050 (show_mouse_face): Remove decls
10051 * frame.h (message_buf_print): Likewise.
10052 * lisp.h (pop_message, set_message, check_point_in_composition):
10053 Likewise.
10054 * xterm.h (set_vertical_scroll_bar): Likewise.
10055 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10056 (message_buf_print, scratch_glyph_row, displayed_buffer):
10057 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10058 (get_next_display_element, show_mouse_face, window_box_edges):
10059 (frame_to_window_pixel_xy, check_point_in_composition):
10060 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10061 (glyph_to_pixel_coords): Remove; unused.
10062
16390cd2
PE
10063 * dired.c (file_name_completion): Now static.
10064
10065 * dbusbind.c (xd_in_read_queued_messages): Now static.
10066
a25f4dfa
PE
10067 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10068 * data.c (circular_list_error): Remove.
10069
14a9c8df
PE
10070 * commands.h (last_point_position, last_point_position_buffer):
10071 (last_point_position_window): Remove decls.
10072 * keyboard.c: Make these variables static.
10073
04f2d78b
CB
10074 * coding.h (coding, code_convert_region, encode_coding_gap):
10075 Remove decls.
74ab6df5
PE
10076 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10077 (iso_code_class, detect_coding, code_convert_region): Now static.
10078 (encode_coding_gap): Remove; unused.
10079
38dfbee1
PE
10080 * chartab.c (chartab_chars, chartab_bits): Now static.
10081
a2cb4e63
PE
10082 * charset.h (charset_iso_8859_1): Remove decl.
10083 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10084 Now static.
10085
127198fd
PE
10086 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10087 * ccl.c (Vccl_program_table): Now static.
10088 (check_ccl_update): Remove; unused.
10089
d85b608f
PE
10090 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10091 * category.h: ... from here.
10092 * category.c (check_category_table, set_category_set): Now static.
10093
31cd66f3
PE
10094 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10095 * lisp.h: Remove these decls.
10096
c358e587
PE
10097 * buffer.c (buffer_count): Remove unused var.
10098
e78aecca
PE
10099 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10100 so that it's not optimized away.
10101 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10102 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10103 exported only to the debugger.
10104
e192d7d3 10105 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10106 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10107
92470028
PE
10108 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10109 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10110 was inaccessible from Lisp.
10111 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10112 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10113
244ed907
PE
10114 alloc.c: Import and export fewer symbols, and remove unused items.
10115 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10116 is defined.
10117 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10118 it's not optimized away by whole-program optimization.
10119 (message_enable_multibyte, free_misc): Remove.
10120 (catchlist, handlerlist, mark_backtrace):
10121 Declare only if BYTE_MARK_STACK.
10122 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10123 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10124 (message_enable_multibyte): Remove decl.
10125 (free_misc, interval_free_list, float_block, float_block_index):
10126 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10127 (cons_free_list, last_marked_index):
10128 Now static.
10129 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10130 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10131 (mark_backtrace): Define only if BYTE_MARK_STACK.
10132 * xdisp.c (message_enable_multibyte): Now static.
10133
61c2b50e 10134 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10135 This makes it easier for human readers (and static analyzers)
10136 to see whether these variables are used from other modules.
10137 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10138 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10139 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10140 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10141 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10142 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10143 * xmenu.c, xselect.c:
10144 Declare Q* vars static if they are not used in other modules.
10145 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10146 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10147 Remove decls of unexported vars.
10148 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10149
95c82688
PE
10150 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10151
16a97296
PE
10152 Make Emacs functions such as Fatom 'static' by default.
10153 This makes it easier for human readers (and static analyzers)
10154 to see whether these functions can be called from other modules.
10155 DEFUN now defines a static function. To make the function external
10156 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10157 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10158 (Finit_image_library):
16a97296
PE
10159 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10160 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10161 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10162 Remove decls, since these functions are now static.
10163 (Funintern, Fget_internal_run_time): New decls, since these functions
10164 were already external.
95c82688 10165
16a97296
PE
10166 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10167 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10168 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10169 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10170 * keyboard.c, keymap.c, lread.c:
10171 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10172 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10173 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10174 Mark functions with DEFUE instead of DEFUN,
10175 if they are used in other modules.
10176 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10177 decls for now-static functions.
10178 * buffer.h (Fdelete_overlay): Remove decl.
10179 * callproc.c (Fgetenv_internal): Mark as internal.
10180 * composite.c (Fremove_list_of_text_properties): Remove decl.
10181 (Fcomposition_get_gstring): New forward static decl.
10182 * composite.h (Fcomposite_get_gstring): Remove decl.
10183 * dired.c (Ffile_attributes): New forward static decl.
10184 * doc.c (Fdocumntation_property): New forward static decl.
10185 * eval.c (Ffetch_bytecode): New forward static decl.
10186 (Funintern): Remove extern decl; now in .h file where it belongs.
10187 * fileio.c (Fmake_symbolic_link): New forward static decl.
10188 * image.c (Finit_image_library): New forward static decl.
10189 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10190 * intervals.h (Fprevious_property_change):
10191 (Fremove_list_of_text_properties): Remove decls.
10192 * keyboard.c (Fthis_command_keys): Remove decl.
10193 (Fcommand_execute): New forward static decl.
10194 * keymap.c (Flookup_key): New forward static decl.
10195 (Fcopy_keymap): Now static.
10196 * keymap.h (Flookup_key): Remove decl.
10197 * process.c (Fget_process): New forward static decl.
10198 (Fprocess_datagram_address): Mark as internal.
10199 * syntax.c (Fsyntax_table_p): New forward static decl.
10200 (skip_chars): Remove duplicate decl.
10201 * textprop.c (Fprevious_property_change): New forward static decl.
10202 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10203 Now internal.
10204 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10205 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10206
785bbd42
PE
10207 * editfns.c (Fformat): Remove unreachable code.
10208
8b913b57
AS
102092011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10210
10211 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10212 change. (Bug#8496)
10213
a6744a35
EZ
102142011-04-13 Eli Zaretskii <eliz@gnu.org>
10215
10216 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10217 when at ZV. (Bug#8487)
10218
e7974947
AS
102192011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10220
baad03f0
AS
10221 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10222 (Bug#8437)
10223 * keyboard.c (parse_tool_bar_item): Likewise.
10224 * sound.c (sound_cleanup, alsa_close): Likewise.
10225 * termcap.c (tgetent): Likewise.
10226 * xfns.c (x_default_font_parameter): Likewise.
10227 * xsettings.c (read_and_apply_settings): Likewise.
10228
e7974947
AS
10229 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10230 (overrun_check_free): Protoize.
10231
28272684
PE
102322011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10233
10234 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10235 since callers should never pass a negative size.
10236 Change the signature to match that of plain 'read' and 'write'; see
10237 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10238 * lisp.h: Update prototypes of emacs_write and emacs_read.
10239
11997c76
EZ
102402011-04-11 Eli Zaretskii <eliz@gnu.org>
10241
10242 * xdisp.c (redisplay_window): Don't try to determine the character
10243 position of the scroll margin if the window start point w->startp
e896f03c 10244 is outside the buffer's accessible region. (Bug#8468)
11997c76 10245
8a2cbd72
EZ
102462011-04-10 Eli Zaretskii <eliz@gnu.org>
10247
10248 Fix write-region and its subroutines for buffers > 2GB.
10249 * fileio.c (a_write, e_write): Modify declaration of arguments and
10250 local variables to support buffers larger than 2GB.
10251 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10252
10253 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10254 argument, local variables, and return value.
10255
10256 * lisp.h: Update prototypes of emacs_write and emacs_read.
10257
10258 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10259
4073e537 102602011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10261
1ebfdcb6
PE
10262 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10263
b2ded58d
PE
10264 Fix more problems found by GCC 4.6.0's static checks.
10265
7d66342c
PE
10266 * xdisp.c (vmessage): Use a better test for character truncation.
10267
bbf47d44
PE
10268 * charset.c (load_charset_map): <, not <=, for optimization,
10269 and to avoid potential problems with integer overflow.
9248994d 10270 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10271 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10272 * editfns.c (Fformat): Likewise.
1e69125e 10273 * syntax.c (skip_chars): Likewise.
3befa583 10274
e3019616
PE
10275 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10276 This also lets GCC 4.6.0 generate slightly better loop code.
10277
becfa255
PE
10278 * callint.c (Fcall_interactively): <, not <=, for optimization.
10279 (Fcall_interactively): Count the number of arguments produced,
10280 not the number of arguments given. This is simpler and lets GCC
10281 4.6.0 generate slightly better code.
10282
dae0cd48
PE
10283 * ftfont.c: Distingish more carefully between FcChar8 and char.
10284 The previous code passed unsigned char * to a functions like
10285 strlen and xstrcasecmp that expect char *, which does not
10286 conform to the C standard.
10287 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10288 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10289 char * when the C standard requires it.
10290
76032d70
PE
10291 * keyboard.c (read_char): Remove unused var.
10292
eb3f1cc8
PE
10293 * eval.c: Port to Windows vsnprintf (Bug#8435).
10294 Include <limits.h>.
10295 (SIZE_MAX): Define if the headers do not.
10296 (verror): Do not give up if vsnprintf returns a negative count.
10297 Instead, grow the buffer. This ports to Windows vsnprintf, which
10298 does not conform to C99. Problem reported by Eli Zaretskii.
10299 Also, simplify the allocation scheme, by avoiding the need for
10300 calling realloc, and removing the ALLOCATED variable.
10301
70476b54
PE
10302 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10303
12020a9e
PE
10304 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10305 But keep the doprint source code for now, as we might revamp it
10306 and use it again (Bug#8435).
ea6c7ae6
PE
10307 * lisp.h (doprnt): Remove.
10308 * Makefile.in (base_obj): Remove doprnt.o.
10309 * deps.mk (doprnt.o): Remove.
10310
5fdb398c
PE
10311 error: Print 32- and 64-bit integers portably (Bug#8435).
10312 Without this change, on typical 64-bit hosts error ("...%d...", N)
10313 was used to print both 32- and 64-bit integers N, which relied on
10314 undefined behavior.
61bdb816 10315 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10316 * lisp.h (error, verror): Mark as printf-like functions.
10317 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10318 Report overflow in size calculations when allocating printf buffer.
10319 Do not truncate output string at its first null byte.
10320 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10321 Truncate the output at a character boundary, since vsnprintf does not
10322 do that.
10323 * charset.c (check_iso_charset_parameter): Convert internal
10324 character to string before calling 'error', since %c now has the
10325 printf meaning.
10326 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10327 overflow when computing char to be passed to 'error'. Do not
10328 pass Lisp_Object to 'error'; pass the integer instead.
10329 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10330 formatted with plain %d.
10331
b189fa66
PE
10332 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10333
bff87ef0
PE
10334 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10335
7e2cac20
PE
10336 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10337
ce4d90b5
PE
10338 * xterm.c (x_catch_errors): Remove duplicate declaration.
10339
266c9547
PE
10340 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10341
79c49ad2
PE
10342 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10343
368f4090
JM
103442011-04-10 Jim Meyering <meyering@redhat.com>
10345
10346 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10347 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10348 return ssize_t not "int", and use size_t as the buffer length.
10349 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10350 * gnutls.h: Update declarations.
10351 * process.c (read_process_output): Use ssize_t, to match.
10352 (send_process): Likewise.
10353
a32d4040
CY
103542011-04-09 Chong Yidong <cyd@stupidchicken.com>
10355
10356 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10357
8546720e 103582011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10359
04f2d78b
CB
10360 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10361 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10362
8546720e
GM
10363 * xterm.c (handle_one_xevent):
10364 * xmenu.c (create_and_show_popup_menu):
10365 * xselect.c (x_decline_selection_request)
10366 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10367
0a2f5c1a 103682011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10369
10370 Fix some uses of `int' instead of EMACS_INT.
10371 * search.c (string_match_1, fast_string_match)
10372 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10373 (scan_buffer, find_next_newline_no_quit)
10374 (find_before_next_newline, search_command, Freplace_match)
10375 (Fmatch_data): Make some `int' variables be EMACS_INT.
10376
10377 * xdisp.c (display_count_lines): 3rd argument and return value now
10378 EMACS_INT. All callers changed.
10379 (pint2hrstr): Last argument is now EMACS_INT.
10380
10381 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10382 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10383 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10384 (decode_coding_utf_16, decode_coding_emacs_mule)
10385 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10386 (decode_coding_ccl, decode_coding_charset)
10387 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10388 (decode_coding_iso_2022, decode_coding_emacs_mule)
10389 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10390 <char_offset, last_offset>: Declare EMACS_INT.
10391 (encode_coding_utf_8, encode_coding_utf_16)
10392 (encode_coding_emacs_mule, encode_invocation_designation)
10393 (encode_designation_at_bol, encode_coding_iso_2022)
10394 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10395 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10396 Declare EMACS_INT.
10397 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10398 (encode_invocation_designation): Last argument P_NCHARS is now
10399 EMACS_INT.
10400 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10401 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10402
10403 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10404 All users changed.
10405
10406 * ccl.c (Fccl_execute_on_string): Declare some variables
10407 EMACS_INT.
10408
8546720e 104092011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10410
10411 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10412
4e19a977
CS
104132011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10414
10415 * process.c (Fformat_network_address): Doc fix.
10416
87302331
R
104172011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10418
ee7683eb 10419 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10420
cbb59342
CY
104212011-04-08 Chong Yidong <cyd@stupidchicken.com>
10422
10423 * keyboard.c (read_char): Call Lisp function help-form-show,
10424 instead of using internal_with_output_to_temp_buffer.
10425 (Qhelp_form_show): New var.
e0d38eeb 10426 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10427
10428 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10429
10430 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10431
e67a13ab
CY
104322011-04-06 Chong Yidong <cyd@stupidchicken.com>
10433
04f2d78b
CB
10434 * process.c (Flist_processes): Remove to Lisp.
10435 (list_processes_1): Delete.
e67a13ab 10436
973f782d
EZ
104372011-04-06 Eli Zaretskii <eliz@gnu.org>
10438
7c106b1e
EZ
10439 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10440
973f782d
EZ
10441 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10442
41cf7d1a 104432011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10444
ca23cc88
PE
10445 Fix more problems found by GCC 4.6.0's static checks.
10446
f390e2d5
PE
10447 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10448
42eea0d0
PE
10449 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10450
b69769da 10451 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10452
f9541e84
PE
10453 * xdisp.c (vmessage): Mark as a printf-like function.
10454
13841b55
PE
10455 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10456
c136c10f
PE
10457 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10458
5e2d4a30
PE
10459 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10460 printf-like functions.
10461 (tiff_load): Add casts to remove these marks before passing them
10462 to system-supplied API.
10463
583f48b9
PE
10464 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10465
b25d760e
PE
10466 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10467 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10468 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10469 directly, rather than having caller test rule sign. This avoids
10470 some unnecessary tests.
10471 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10472 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10473 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10474
bc7b6697 10475 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10476 (xfont_open): Avoid unnecessary tests.
bc7b6697 10477
27ccc379
PE
10478 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10479
dcd5c89a
PE
10480 * composite.h, composite.c (composition_gstring_put_cache):
10481 Use EMACS_INT, not int, for length.
10482
b13a45c6
PE
10483 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10484 breaking out part of COMPOSITION_DECODE_RULE.
10485 (COMPOSITION_DECODE_RULE): Use it.
10486 * composite.c (get_composition_id): Remove unused local vars,
10487 by using the new macro.
10488
1e792e4d
PE
10489 * textprop.c (set_text_properties_1): Change while to do-while,
10490 since the condition is always true at first.
10491
dc6c6455 10492 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10493 (interval_deletion_adjustment): Return unsigned value.
10494 All uses changed.
dc6c6455 10495
aba7731a
PE
10496 * process.c (list_processes_1, create_pty, read_process_output):
10497 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10498 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10499 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10500 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10501 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10502
fdfc4bf3
PE
10503 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10504
fca8fe46 10505 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10506 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10507
06a0259a 10508 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10509 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10510 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10511
e7b9e80f
PE
10512 * print.c (print_error_message): Avoid int overflow.
10513
56201685
PE
10514 * font.c (font_list_entities): Redo for clarity,
10515 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10516
78834453 10517 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10518 (font_score): Avoid potential overflow in diff calculation.
78834453 10519
0bc0b309 10520 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10521 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10522
e610eaca
PE
10523 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10524
b895abce
PE
10525 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10526 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10527 can always succeed if overflow has undefined behavior.
10528
1f1d9321 10529 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10530 (wordify): Omit three unnecessary tests.
1f1d9321 10531
c59478bc
PE
10532 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10533 All callers changed. This avoids the need for an unused var.
10534
79b73827
PE
10535 * casefiddle.c (casify_region): Remove var that is set but not used.
10536
a4db5dfe
PE
10537 * dired.c (file_name_completion): Remove var that is set but not used.
10538
43aae36e
PE
10539 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10540
2a47c44d 10541 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10542 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10543
a37c69bf
PE
10544 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10545 Check for integer overflow on size calculations.
10546
328ab8e7
PE
10547 * buffer.c (Fprevious_overlay_change): Remove var that is set
10548 but not used.
10549
e5a2a5cb
PE
10550 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10551 Remove vars that are set but not used.
8d84a6eb 10552 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10553 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10554
a60e5f68
PE
10555 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10556
f661cb61 10557 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10558 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10559
f0397f5a
PE
10560 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10561 that are set but not used.
10562
8664db06 10563 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10564 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10565
6abdaa4a
PE
10566 * xselect.c (x_get_local_selection, x_handle_property_notify):
10567 Remove vars that are set but not used.
10568
0ce7538d 10569 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10570 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10571
9ae848fc
PE
10572 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10573 Remove var that is set but not used.
0b918413
PE
10574 (scroll_bar_windows_size): Now size_t, not int.
10575 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10576 Check for overflow.
9ae848fc 10577
a5a62657
PE
10578 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10579 (map_tty_color) [!defined MSDOS]: Likewise.
10580
5c5cdd39
PE
10581 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10582
66ebf983
PE
10583 * coding.c: Remove vars that are set but not used.
10584 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10585 All callers changed.
10586 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10587 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10588 (decode_coding_charset): Remove vars that are set but not used.
10589
1be4d761
PE
10590 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10591 that is set but not used.
10592
47553fa8
PE
10593 * print.c (print_object): Remove var that is set but not used.
10594
1f7196bf 10595 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10596 The gnulib version avoids calling malloc in the usual case,
10597 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10598 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10599 * filelock.c (current_lock_owner): Likewise.
10600 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10601 * sysdep.c: Include allocator.h, careadlinkat.h.
10602 (emacs_no_realloc_allocator): New static constant.
10603 (emacs_readlink): New function.
fdb61804
PE
10604 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10605 ../lib/careadlinkat.h.
d1fdcab7 10606
f84c17c7
SM
106072011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10608
10609 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10610 first non-nil return value).
10611
ef3862ad
JD
106122011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10613
10614 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10615 if not defined (Bug#8403).
10616
376a7006
JB
106172011-04-02 Juanma Barranquero <lekktu@gmail.com>
10618
10619 * xdisp.c (display_count_lines): Remove parameter `start',
10620 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10621 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10622 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10623 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10624 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10625 and thereabouts. All callers changed.
10626 (get_per_char_metric): Remove parameter `f', unused since
10627 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10628
6ca3801d
JM
106292011-04-02 Jim Meyering <meyering@redhat.com>
10630
10631 do not dereference NULL upon failed strdup
10632 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10633 (ns_get_family): Likewise.
10634
d8e2b5ba
JB
106352011-04-02 Juanma Barranquero <lekktu@gmail.com>
10636
10637 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10638
8c74fcbd
JD
106392011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10640
10641 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10642 later (Bug#8403).
10643
7200d79c
SM
106442011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10645
03408648 10646 Add lexical binding.
7200d79c 10647
03408648
SM
10648 * window.c (Ftemp_output_buffer_show): New fun.
10649 (Fsave_window_excursion):
10650 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10651
10652 * lread.c (lisp_file_lexically_bound_p): New function.
10653 (Fload): Bind Qlexical_binding.
10654 (readevalloop): Remove `evalfun' arg.
10655 Bind Qinternal_interpreter_environment.
10656 (Feval_buffer): Bind Qlexical_binding.
10657 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10658 Mark as dynamic.
10659 (syms_of_lread): Declare `lexical-binding'.
10660
10661 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10662
10663 * keyboard.c (eval_dyn): New fun.
10664 (menu_item_eval_property): Use it.
ca105506
SM
10665
10666 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10667
03408648
SM
10668 * fns.c (concat, mapcar1): Accept byte-code-functions.
10669
10670 * eval.c (Fsetq): Handle lexical vars.
10671 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10672 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10673 (FletX, Flet): Obey lexical binding.
10674 (Fcommandp): Handle closures.
10675 (Feval): New `lexical' arg.
10676 (eval_sub): New function extracted from Feval. Use it almost
10677 everywhere where Feval was used. Look up vars in lexical env.
10678 Handle closures.
10679 (Ffunctionp): Move from subr.el.
10680 (Ffuncall): Handle closures.
10681 (apply_lambda): Remove `eval_flags'.
10682 (funcall_lambda): Handle closures and new byte-code-functions.
10683 (Fspecial_variable_p): New function.
10684 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10685 but without exporting it to Lisp.
23aba0ea 10686
23aba0ea 10687 * doc.c (Fdocumentation, store_function_docstring):
03408648 10688 * data.c (Finteractive_form): Handle closures.
23aba0ea 10689
03408648
SM
10690 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10691 interactive spec.
ba83908c 10692
04f2d78b
CB
10693 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10694 New byte-codes.
03408648
SM
10695 (exec_byte_code): New function extracted from Fbyte_code to handle new
10696 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10697
03408648 10698 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10699
03408648 10700 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10701
e2abce01
JB
107022011-03-31 Juanma Barranquero <lekktu@gmail.com>
10703
10704 * xdisp.c (redisplay_internal): Fix prototype.
10705
63696a73 107062011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10707
63696a73 10708 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10709 (try_scrolling): Use it when setting scroll_limit.
10710 Limit scrolling to 100 screen lines.
63696a73
EZ
10711 (redisplay_window): Even when falling back on "recentering",
10712 position point in the window according to scroll-conservatively,
10713 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10714
10715 (try_scrolling): When point is above the window, allow searching
10716 as far as scroll_max, or one screenful, to compute vertical
10717 distance from PT to the scroll margin position. This prevents
10718 try_scrolling from unnecessarily failing when
10719 scroll-conservatively is set to a value slightly larger than the
10720 window height. Clean up the case of PT below the margin at bottom
10721 of window: scroll_max can no longer be INT_MAX. When aggressive
10722 scrolling is in use, don't let point enter the opposite scroll
10723 margin as result of the scroll.
10724 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10725 threshold of 100 lines for never-recentering scrolling.
10726
e4cc2dfc
JB
107272011-03-31 Juanma Barranquero <lekktu@gmail.com>
10728
10729 * dispextern.h (move_it_by_lines):
10730 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10731 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10732 (message_log_check_duplicate): Remove parameters `prev_bol' and
10733 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10734 (redisplay_internal): Remove parameter `preserve_echo_area',
10735 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10736
10737 * indent.c (Fvertical_motion):
10738 * window.c (window_scroll_pixel_based, Frecenter):
10739 Don't pass `need_y_p' to `move_it_by_lines'.
10740
1c470562
SM
107412011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10742
44f230aa
SM
10743 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10744 steal a few bits to be more compact.
10745 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10746 Remove unneeded casts.
10747
1c470562
SM
10748 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10749
888adce9
ZK
107502011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10751
10752 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10753 binding" message (bug#7967).
10754
f838ed7b
PE
107552011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10756
77861b95
PE
10757 Fix more problems found by GCC 4.6.0's static checks.
10758
de6dbc14
PE
10759 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10760 Remove unused local var.
10761
f838ed7b
PE
10762 * editfns.c (Fmessage_box): Remove unused local var.
10763
792c7b2b
PE
10764 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10765 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10766 Omit unused local vars.
c499e557 10767 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10768 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10769 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10770 Omit unused local var.
10771
ba0165e1
PE
10772 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10773 Don't assume string length fits in int.
32ad8845 10774 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10775 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10776
3c59b4c9
PE
10777 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10778 instead of alloca (Bug#8344).
10779
a3eed478 10780 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10781 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10782
eb4d412d
PE
10783 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10784
1658b401
PE
10785 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10786 concerns.
10787
10788 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10789
10790 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10791
9a2c6e05
PE
10792 * keyboard.c (syms_of_keyboard): Use the same style as later
10793 in this function when indexing through an array. This also
10794 works around GCC bug 48267.
10795
03d0a109
PE
10796 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10797
44f730c8
PE
10798 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10799
fe75f926
PE
10800 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10801 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10802
ffa8c828
PE
10803 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10804 This avoids undefined behavior on integer overflow, and is a bit
10805 more convenient anyway since it is compared to a size_t variable.
10806
c5101a77
PE
10807 Variadic C functions now count arguments with size_t, not int.
10808 This avoids an unnecessary limitation on 64-bit machines, which
10809 caused (substring ...) to crash on large vectors (Bug#8344).
10810 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10811 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10812 All variadic functions and their callers changed accordingly.
c5101a77
PE
10813 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10814 * data.c (arith_driver, float_arith_driver): Likewise.
10815 * editfns.c (general_insert_function): Likewise.
10816 * eval.c (struct backtrace.nargs, interactive_p)
10817 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10818 (funcall_lambda, mark_backtrace): Likewise.
10819 * fns.c (concat): Likewise.
10820 * frame.c (x_set_frame_parameters): Likewise.
10821 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10822 0 if not found, not -1. All callers changed.
10823
dd3f25f7
PE
10824 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10825 (stack_copy_size): Now size_t, not int.
10826 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10827
461c2ab9
JB
108282011-03-28 Juanma Barranquero <lekktu@gmail.com>
10829
10830 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10831 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10832 All callers changed.
10833
10834 * lisp.h (multibyte_char_to_unibyte):
10835 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10836 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10837 * character.h (CHAR_TO_BYTE8):
10838 * cmds.c (internal_self_insert):
10839 * editfns.c (general_insert_function):
10840 * keymap.c (push_key_description):
10841 * search.c (Freplace_match):
10842 * xdisp.c (message_dolog, set_message_1): All callers changed.
10843
f6d62986
SM
108442011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10845
10846 * keyboard.c (safe_run_hook_funcall): New function.
10847 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10848 don't set the hook to nil, but remove the offending function instead.
10849 (Qcommand_hook_internal): Remove, unused.
10850 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10851 Vcommand_hook_internal.
10852
10853 * eval.c (enum run_hooks_condition): Remove.
10854 (funcall_nil, funcall_not): New functions.
10855 (run_hook_with_args): Call each function through a `funcall' argument.
10856 Remove `cond' argument, now redundant.
10857 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10858 (Frun_hook_with_args_until_failure): Adjust accordingly.
10859 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10860
1db5b1ad
JB
108612011-03-28 Juanma Barranquero <lekktu@gmail.com>
10862
10863 * dispextern.h (string_buffer_position): Remove declaration.
10864
10865 * print.c (strout): Remove parameter `multibyte', unused since
10866 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10867
10868 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10869 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10870 All callers changed.
10871
10872 * w32.c (_wsa_errlist): Use braces for struct initializers.
10873
10874 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10875 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10876 All callers changed.
10877 (string_buffer_position): Likewise. Also, make static (it's never
10878 used outside xdisp.c).
10879 (cursor_row_p): Remove parameter `w', unused since
10880 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10881 (decode_mode_spec): Remove parameter `precision', introduced during
10882 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10883 All callers changed.
10884
5ffb62aa
JD
108852011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10886
10887 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10888
461c2ab9 108892011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10890
10891 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10892 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10893 (ns_update_auto_hide_menu_bar): New functions.
10894 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10895 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10896 ns_constrain_all_frames.
10897 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10898 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10899
5c380ffb
JD
109002011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10901
10902 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10903
9af30bdf
GM
109042011-03-27 Glenn Morris <rgm@gnu.org>
10905
10906 * syssignal.h: Replace RETSIGTYPE with void.
10907 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10908 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10909 Replace SIGTYPE with void everywhere.
10910 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10911 * s/template.h (SIGTYPE): Remove commented out definition.
10912
e2abce01
JB
109132011-03-26 Eli Zaretskii <eliz@gnu.org>
10914
10915 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10916 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10917
f868cd8a
JB
109182011-03-26 Juanma Barranquero <lekktu@gmail.com>
10919
59eb0929
JB
10920 * w32.c (read_unc_volume): Use parameter `henum', instead of
10921 global variable `wget_enum_handle'.
10922
10923 * keymap.c (describe_vector): Remove parameters `indices' and
10924 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10925 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10926
f868cd8a
JB
10927 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10928
10929 * keyboard.c (timer_check): Remove parameter `do_it_now',
10930 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10931 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10932 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10933
10934 * keyboard.c (read_char):
10935 * w32menu.c (w32_menu_display_help):
10936 * xmenu.c (show_help_event, menu_help_callback):
10937 Adjust calls to `show_help_echo'.
10938
10939 * gtkutil.c (xg_maybe_add_timer):
10940 * keyboard.c (readable_events):
10941 * process.c (wait_reading_process_output):
10942 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10943
10944 * insdel.c (adjust_markers_gap_motion):
10945 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10946 (gap_left, gap_right): Don't call it.
10947
2ecf6fdb
CY
109482011-03-25 Chong Yidong <cyd@stupidchicken.com>
10949
10950 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10951 incurred during fontification.
10952
6b1f9ba4
JB
109532011-03-25 Juanma Barranquero <lekktu@gmail.com>
10954
10955 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10956 (DEFVAR_PER_BUFFER): Don't pass it.
10957
10958 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10959 (scrolling_window): Don't pass it.
10960
0f4a96b5
JB
109612011-03-25 Juanma Barranquero <lekktu@gmail.com>
10962
10963 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10964
10965 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10966 and `suffix'.
10967 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10968 of variables specific to SELinux and computation of `encoded_absname'.
10969
10970 * image.c (XPutPixel): Remove unused variable `height'.
10971
10972 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10973
10974 * unexw32.c (get_section_info): Remove unused variable `section'.
10975
10976 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10977 (system_process_attributes): Remove unused variable `sess'.
10978 (sys_read): Remove unused variable `err'.
10979
10980 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10981 (w32_wnd_proc): Remove unused variable `isdead'.
10982 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10983 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10984 (x_create_tip_frame): Remove unused variable `tem'.
10985
10986 * w32inevt.c (w32_console_read_socket):
10987 Remove unused variable `no_events'.
10988
10989 * w32term.c (x_draw_composite_glyph_string_foreground):
10990 Remove unused variable `width'.
10991
1149507c
JB
109922011-03-24 Juanma Barranquero <lekktu@gmail.com>
10993
10994 * w32term.c (x_set_glyph_string_clipping):
10995 Don't pass uninitialized region to CombineRgn.
10996
9c88f339
JB
109972011-03-23 Juanma Barranquero <lekktu@gmail.com>
10998
10999 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11000 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11001 (Fx_close_connection): Remove unused variable `i'.
11002
11003 * w32font.c (w32font_draw): Return number of glyphs.
11004 (w32font_open_internal): Remove unused variable `i'.
11005 (w32font_driver): Add missing initializer.
11006
11007 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11008 (fill_in_menu): Remove unused variable `items_added'.
11009
11010 * w32term.c (last_mouse_press_frame): Remove static global variable.
11011 (w32_clip_to_row): Remove unused variable `f'.
11012 (x_delete_terminal): Remove unused variable `i'.
11013
11014 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11015 (NOTHING): Remove unused static global variable.
11016 (uniscribe_check_otf): Remove unused variable `table'.
11017 (uniscribe_font_driver): Add missing initializers.
11018
dee091a3
JD
110192011-03-23 Julien Danjou <julien@danjou.info>
11020
11021 * term.c (Fsuspend_tty, Fresume_tty):
11022 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11023 * window.c (temp_output_buffer_show):
11024 * insdel.c (signal_before_change):
11025 * frame.c (Fhandle_switch_frame):
11026 * fileio.c (Fdo_auto_save):
11027 * emacs.c (Fkill_emacs):
11028 * editfns.c (save_excursion_restore):
11029 * cmds.c (internal_self_insert):
11030 * callint.c (Fcall_interactively):
11031 * buffer.c (Fkill_all_local_variables):
11032 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11033 Use Frun_hooks.
0f4a96b5 11034 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11035 unconditionally since it does the check itself.
dee091a3 11036
2c520ab5 110372011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11038
c9c49752
PE
11039 Fix more problems found by GCC 4.5.2's static checks.
11040
8abc3f12
PE
11041 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11042 the first time through the loop, since we know p0 < p1 then.
11043 This also avoids a gcc -Wstrict-overflow warning.
11044
a2d26660
PE
11045 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11046 leading to a memory leak, possible in functions like
11047 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11048 of objects (Bug#8318).
a2d26660 11049
916c72e9
PE
11050 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11051 that could (at least in theory) be that large.
11052
19ab8a18
PE
11053 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11054 This is less likely to overflow, and avoids undefined behavior if
11055 overflow does occur. All callers changed. Use strtoul to scan
11056 for the unsigned long integer.
b7cbbd6f
PE
11057 (pint2hrstr): Simplify and tune code slightly.
11058 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11059
f0641eff
PE
11060 * scroll.c (do_scrolling): Work around GCC bug 48228.
11061 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11062
7f650bb9
PE
11063 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11064 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11065 (validate_x_resource_name): Simplify count usage.
11066 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11067
37dd57d1
PE
11068 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11069 fail (Bug#8306).
81e56e61 11070
699979fc 11071 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11072
401bf9b4
PE
11073 * process.c (Fmake_network_process): Use socklen_t, not int,
11074 where POSIX says socklen_t is required in portable programs.
11075 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11076 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11077 (Fmake_network_process, server_accept_connection):
11078 (wait_reading_process_output, read_process_output):
11079 Likewise.
11080
b93aacde
PE
11081 * process.c: Rename or move locals to avoid shadowing.
11082 (list_processes_1, Fmake_network_process):
11083 (read_process_output_error_handler, exec_sentinel_error_handler):
11084 Rename or move locals.
4dc343ee 11085 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11086 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11087 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11088 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11089 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11090
af8a867c 11091 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11092 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11093 Include tparam.h instead, since it declares them.
af8a867c
PE
11094 * cm.h (PC): Remove extern decl; tparam.h now does this.
11095 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11096 * terminfo.c: Include tparam.h, to check interfaces.
11097 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11098 (tparam): Adjust signature to match interface in tparam.h;
11099 this removes some undefined behavior. Check that outstring and len
11100 are zero, which they always are with Emacs.
11101 * tparam.h (PC, BC, UP): New extern decls.
11102
0248044d 11103 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11104 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11105
8ff096c1 11106 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11107 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11108 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11109 (ftfont_list): Remove unused local.
49eaafba
PE
11110 (get_adstyle_property, ftfont_pattern_entity):
11111 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11112 Rename locals to avoid shadowing.
8ff096c1 11113
e2be39f6
PE
11114 * xfont.c (xfont_list_family): Mark var as initialized.
11115
c9735e30
PE
11116 * xml.c (make_dom): Now static.
11117
8f5201ae
PE
11118 * composite.c (composition_compute_stop_pos): Rename local to
11119 avoid shadowing.
b246f932
PE
11120 (composition_reseat_it): Remove unused locals.
11121 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11122 (composition_update_it): Mark var as initialized.
11b61122
PE
11123 (find_automatic_composition): Mark vars as initialized,
11124 with a FIXME (Bug#8290).
8f5201ae 11125
760fbc2c
PE
11126 character.h: Rename locals to avoid shadowing.
11127 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11128 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11129 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11130 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11131 to avoid shadowing.
11132
ff08eb85
PE
11133 * textprop.c (property_change_between_p): Remove; unused.
11134
fc7bf025
PE
11135 * intervals.c (interval_start_pos): Now static.
11136
235d7abc
PE
11137 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11138
44f230aa
SM
11139 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11140 Rename locals to avoid shadowing.
3e7d6594 11141
50060332
PE
11142 * sound.c (wav_play, au_play, Fplay_sound_internal):
11143 Fix pointer signedness.
d01f234b 11144 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11145 (wav_play): Initialize a variable to 0, to prevent undefined
11146 behavior (Bug#8278).
50060332 11147
c4fc4e30
PE
11148 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11149
918436ed
PE
11150 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11151
c939f91b
PE
11152 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11153 clobbering (Bug#8298).
b9c7f648
PE
11154 * sysdep.c (sys_subshell): Likewise.
11155 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11156
6bd8c144
PE
11157 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11158 This should get cleaned up, so that child_setup has the
11159 same signature on all platforms.
11160
7710357c 11161 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11162 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11163
c59da222
CY
111642011-03-22 Chong Yidong <cyd@stupidchicken.com>
11165
11166 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11167 not to be necessary, and produces flickering.
11168
66b87493
GM
111692011-03-20 Glenn Morris <rgm@gnu.org>
11170
11171 * config.in: Remove file.
11172
45b6f6d5
JB
111732011-03-20 Juanma Barranquero <lekktu@gmail.com>
11174
11175 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11176 are now in src/globals.h.
11177 (syms_of_minibuf): Remove spurious & from previous change.
11178
cd394be1 111792011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11180
11181 * minibuf.c (completing-read-function): New variable.
11182 (completing-read-default): Rename from completing-read.
11183 (completing-read): Call completing-read-function.
11184
b14e3e21
CY
111852011-03-19 Juanma Barranquero <lekktu@gmail.com>
11186
11187 * xfaces.c (Fx_load_color_file):
11188 Read color file from absolute filename (bug#8250).
11189
f2b726e6
JB
111902011-03-19 Juanma Barranquero <lekktu@gmail.com>
11191
11192 * makefile.w32-in: Update dependencies.
11193
09f6ff02
EZ
111942011-03-17 Eli Zaretskii <eliz@gnu.org>
11195
11196 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11197
29a6015a
PE
111982011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11199
a3a6c54e
PE
11200 Fix more problems found by GCC 4.5.2's static checks.
11201
b766f867
PE
11202 * process.c (make_serial_process_unwind, send_process_trap):
11203 (sigchld_handler): Now static.
11204
be02381c
PE
11205 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11206 That way, the code declares only the vars that it needs.
11207 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11208 * s/cygwin.h (PTY_ITERATION): Likewise.
11209 * s/darwin.h (PTY_ITERATION): Likewise.
11210 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11211
57048744
PE
11212 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11213 * process.c (allocate_pty): Don't declare stb unless it's needed.
11214
7914961c 11215 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11216 (CONSTANTLIM): Remove; unused.
11217 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11218 Define only if needed.
7914961c 11219
b3967b18
PE
11220 * unexelf.c (unexec): Name an expression,
11221 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11222 Use a different way to cause a compilation error if anyone uses
11223 n rather than nn, a way that does not involve shadowing.
73366a00 11224 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11225
29a6015a
PE
11226 * deps.mk (unexalpha.o): Remove; unused.
11227
43cfc33e 11228 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11229 * unexec.h: New file.
ce701a33
PE
11230 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11231 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11232 Depend on unexec.h.
11233 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11234 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11235 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11236 Change as necessary to match prototype in unexec.h.
ce701a33 11237
01f44d5a
PE
11238 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11239 shadowing.
4f63c6bb 11240 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11241
a6670b0b
PE
11242 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11243 Rename locals to avoid shadowing.
11244
cef2010d 11245 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11246 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11247
d4d7173a
PE
11248 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11249
f08b802a
PE
11250 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11251 warning when compiling print.c.
11252
3ddb0639
PE
11253 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11254 instead of using an uninitialized var.
5ad03b97 11255 (font_sort_entities): Mark var as initialized.
3ddb0639 11256
170a2692
PE
11257 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11258
e663c700
PE
11259 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11260 pointers to constants.
89bc529a 11261 (font_parse_fcname): Remove unused vars.
7b81e2d0 11262 (font_delete_unmatched): Now static.
ea838e10 11263 (font_get_spec): Remove; unused.
13a547c6
PE
11264 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11265 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11266 Rename or move locals to avoid shadowing.
e663c700 11267
2a80c887 11268 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11269 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11270
1384fa33 11271 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11272 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11273
8b2c52e9
PE
11274 * alloc.c (mark_backtrace): Move decl from here ...
11275 * lisp.h: ... to here, so that it can be checked.
11276
475545b5 11277 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11278 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11279 (lisp_indirect_variable): Name an expression,
11280 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11281 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11282
b1349114 11283 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11284 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11285 Use const pointer when appropriate.
b1349114 11286
a2928364
PE
11287 * lisp.h (get_system_name, get_operating_system_release):
11288 Move decls here, to check interfaces.
11289 * process.c (get_operating_system_release): Move decl to lisp.h.
11290 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11291 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11292 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11293 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11294 (Fformat_time_string, Fencode_time, Finsert_char):
11295 (Ftranslate_region_internal, Fformat):
11296 Rename or remove local vars to avoid shadowing.
9710023e 11297 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11298
a415e694
PE
11299 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11300 avoid shadowing.
11301
8ef4622d
PE
11302 * lisp.h (eassert): Check that the argument compiles, even if
11303 ENABLE_CHECKING is not defined.
11304
946f9a5b
PE
11305 * data.c (Findirect_variable): Name an expression, to avoid
11306 gcc -Wbad-function-cast warning.
112396d6 11307 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11308 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11309 (Fmake_variable_buffer_local, Fmake_local_variable):
11310 Mark variables as initialized.
52746918 11311 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11312
e5aab7e7 11313 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11314 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11315 Rename locals to avoid shadowing.
dff45157
PE
11316 (mark_stack): Move local variables into the #ifdef region where
11317 they're used.
7bc26fdb
PE
11318 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11319 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11320 needed otherwise.
11321 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11322 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11323 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11324
e5aab7e7
PE
11325 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11326 avoids undefined behavior in theory.
11327
4da60324
PE
11328 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11329
88043301
PE
11330 Use functions, not macros, for up- and down-casing (Bug#8254).
11331 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11332 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11333 to use the following functions instead of these macros.
11334 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11335 EMACS_INT, since callers assume the returned value fits in int.
11336 (upcase1): Likewise, for UPCASE_TABLE.
11337 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11338 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11339 the race-condition problem in the old DOWNCASE.
88043301 11340
19ed5445
PE
11341 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11342 Rename locals to avoid shadowing.
11343 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11344 (regex_compile, re_search_2, re_match_2_internal):
11345 Remove unused local vars.
952db0d7
PE
11346 (FREE_VAR): Rewrite so as not to use empty "else",
11347 which gcc can warn about.
da053e48 11348 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11349 (RETALLOC_IF): Define only if needed.
11350 (WORDCHAR_P): Likewise. This one is never needed, but is used
11351 only in a comment talking about a compiler bug, so put inside
11352 the #if 0 of that comment.
11353 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11354 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11355 Remove; unused.
19ed5445 11356
1f3561e4 11357 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11358 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11359 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11360
ded6f8f7
PE
11361 * search.c (simple_search): Remove unused var.
11362
dbd37a95
PE
11363 * dired.c (compile_pattern): Move decl from here ...
11364 * lisp.h: ... to here, so that it can be checked.
11365 (struct re_registers): New forward decl.
11366
7e47afad
PE
11367 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11368
85f24f61
PE
11369 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11370 All uses changed.
11371 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11372 Rename locals to avoid shadowing.
5671df8f 11373 (Fvertical_motion): Mark locals as initialized.
85f24f61 11374
181aa2be 11375 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11376 (casify_region): Mark local as initialized.
181aa2be 11377
930d429c
PE
11378 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11379
7082eac6
PE
11380 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11381 New macros, so that the caller can use some names other than
11382 gcpro1, gcpro2, etc.
11383 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11384 of the new macros.
11385 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11386 argument, for consistency with GCPRO2_VAR, etc: it is now the
11387 prefix of the variable, not the variable itself. All uses
11388 changed.
38b2c076
PE
11389 * dired.c (directory_files_internal, file_name_completion):
11390 Rename locals to avoid shadowing.
11391
15206ed9
PE
11392 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11393 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11394 dired.c's scmp function, had undefined behavior.
11395 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11396 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11397 * buffer.h: ... to here, because these macros use current_buffer,
11398 and the new implementation with inline functions needs to have
11399 current_buffer in scope now, rather than later when the macros
11400 are used.
11401 (downcase, upcase1): New static inline functions.
11402 (DOWNCASE, UPCASE1): Reimplement using these functions.
11403 This avoids undefined behavior in expressions like
11404 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11405 from race conditions in accessing the global variables
11406 case_temp1 and case_temp2.
11407 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11408 * lisp.h (case_temp1, case_temp2): Remove their decls.
11409 * character.h (ASCII_CHAR_P): Move from here ...
11410 * lisp.h: ... to here, so that the inline functions mentioned
11411 above can use them.
11412
4a6bea26
PE
11413 * dired.c (directory_files_internal_unwind): Now static.
11414
f14b7e14
PE
11415 * fileio.c (file_name_as_directory, directory_file_name):
11416 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11417 Now static.
2893f146
PE
11418 (file_name_as_directory): Use const pointers when appropriate.
11419 (Fexpand_file_name): Likewise. In particular, newdir might
11420 point at constant storage, so make it a const pointer.
fd4ead52 11421 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11422 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11423 signedness issues.
f839df0c
PE
11424 (Fset_file_times, Finsert_file_contents, auto_save_error):
11425 Rename locals to avoid shadowing.
f14b7e14 11426
5716756e 11427 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11428 (Ftry_completion, Fall_completions): Rename or remove locals
11429 to avoid shadowing.
5716756e 11430
b4c3046a
PE
11431 * marker.c (bytepos_to_charpos): Remove; unused.
11432
b45db522
PE
11433 * lisp.h (verify_bytepos, count_markers): New decls,
11434 so that gcc does not warn that these functions aren't declared.
11435
85876d07
PE
11436 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11437 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11438 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11439 (copy_text): Remove unused local var.
85876d07 11440
03d78a21 11441 * filelock.c (within_one_second): Now static.
b3dd38ab 11442 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11443
5df8f01b
PE
11444 * buffer.c (fix_overlays_before): Mark locals as initialized.
11445 (fix_start_end_in_overlays): Likewise. This function should be
11446 simplified by using pointers-to-pointers, but that's a different
11447 matter.
b1d876f1 11448 (switch_to_buffer_1): Now static.
8f54f30a
PE
11449 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11450 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11451
a70072c9 11452 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11453 Fix pointer signedness issue.
edced198
PE
11454 (sys_subshell): Mark local as volatile if checking for lint,
11455 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11456 (MAXPATHLEN): Define only if needed.
a70072c9 11457
a0977c44
PE
11458 * process.c (serial_open, serial_configure): Move decls from here ...
11459 * systty.h: ... to here, so that they can be checked.
11460
a884fdcc
PE
11461 * fns.c (get_random, seed_random): Move extern decls from here ...
11462 * lisp.h: ... to here, so that they can be checked.
11463
604efe86 11464 * sysdep.c (reset_io): Now static.
b8950c94 11465 (wait_for_termination_signal): Remove; unused.
604efe86 11466
38fc62d9
PE
11467 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11468 (copy_keymap_item, append_key, push_text_char_description):
11469 Now static.
1004a21a 11470 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11471 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11472 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11473 (describe_map_tree):
11474 Rename locals to avoid shadowing.
38fc62d9 11475
2f2650da
PE
11476 * keyboard.c: Declare functions static if they are not used elsewhere.
11477 (echo_char, echo_dash, cmd_error, top_level_2):
11478 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11479 (read_char, kbd_buffer_get_event, make_lispy_position):
11480 (make_lispy_event, make_lispy_movement, apply_modifiers):
11481 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11482 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11483 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11484 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11485 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11486
a053e86c 11487 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11488 (mark_kboards): Move decl here ...
11489 * alloc.c (mark_kboards): ... from here.
a053e86c 11490
4752793e
PE
11491 * lisp.h (force_auto_save_soon): New decl.
11492
74f10ca7 11493 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11494 (DEFINE_DUMMY_FUNCTION): New macro.
11495 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11496 Use it.
c03cd23f
PE
11497 (main): Add casts to avoid warnings
11498 if GCC considers string literals to be constants.
74f10ca7 11499
022e70d4
PE
11500 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11501
59d6fe83
PE
11502 * dbusbind.c: Pointer signedness fixes.
11503 (xd_signature, xd_append_arg, xd_initialize):
11504 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11505 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11506 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11507 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11508
78320123
PE
11509 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11510 if GCC considers string literals to be constants.
49cebcca 11511 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11512
35ac2a97
SM
115132011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11514
fb103ca9
SM
11515 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11516 (print_preprocess, print_object): New macro to fix last change.
11517
35ac2a97
SM
11518 * print.c (print_preprocess): Don't forget font objects.
11519
62973b41
JB
115202011-03-16 Juanma Barranquero <lekktu@gmail.com>
11521
11522 * emacs.c (USAGE3): Doc fixes.
11523
0e48bb22
AS
115242011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11525
11526 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11527 structure.
11528
7684e57b
JB
115292011-03-14 Juanma Barranquero <lekktu@gmail.com>
11530
11531 * lisp.h (VWindow_system, Qfile_name_history):
11532 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11533 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11534 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11535
11536 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11537 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11538
11539 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11540 * w32console.c (detect_input_pending, read_input_pending)
11541 (encode_terminal_code):
11542 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11543 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11544 (w32_system_caret_y, Qfile_name_history):
11545 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11546 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11547 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11548 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11549 * w32proc.c (Qlocal, report_file_error):
11550 * w32term.c (Vwindow_system, updating_frame):
11551 * w32uniscribe.c (initialized, uniscribe_font_driver):
11552 Remove unneeded extern declarations.
11553
2aa46d6c
CY
115542011-03-14 Chong Yidong <cyd@stupidchicken.com>
11555
c96bbc66 11556 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11557
cffc6f3b
CY
115582011-03-13 Chong Yidong <cyd@stupidchicken.com>
11559
11560 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11561 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11562 These macros can no longer be used for assignment.
11563
44f230aa
SM
11564 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11565 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11566 (record_buffer_markers, fetch_buffer_markers): New functions for
11567 recording and fetching special buffer markers.
11568 (set_buffer_internal_1, set_buffer_temp): Use them.
11569
11570 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11571
11572 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11573
11574 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11575 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11576
11577 * xdisp.c (hscroll_window_tree):
11578 (reconsider_clip_changes): Use PT instead of BUF_PT.
11579
d251f04b
EZ
115802011-03-13 Eli Zaretskii <eliz@gnu.org>
11581
11582 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11583 $(EMACS_ROOT)/lib/intprops.h.
11584
f0c77cd1
PE
115852011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11586
3eca4629
PE
11587 Fix more problems found by GCC 4.5.2's static checks.
11588
7c86ee98
PE
11589 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11590 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11591 (xg_free_frame_widgets): Make it clear that a local variable is
11592 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11593 (gdk_window_get_screen): Make it clear that this macro is needed
11594 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11595 (int_gtk_range_get_value): New function, which avoids a diagnostic
11596 from gcc -Wbad-function-cast.
11597 (xg_set_toolkit_scroll_bar_thumb): Use it.
11598 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11599 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11600 (get_utf8_string, xg_get_file_with_chooser):
11601 Rename locals to avoid shadowing.
11602 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11603
41729b81
PE
11604 * xgselect.c (xg_select): Remove unused var.
11605
f0c77cd1
PE
11606 * image.c (four_corners_best): Mark locals as initialized.
11607 (gif_load): Initialize transparent_p to zero (Bug#8238).
11608 Mark another local as initialized.
ec6cf4c6 11609 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11610
ce0ad53d 11611 * image.c (clear_image_cache): Now static.
d5d5a617 11612 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11613 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11614 (x_edge_detection): Remove unnecessary cast that
11615 gcc -Wbad-function-cast diagnoses.
2037898d 11616 (gif_load): Fix pointer signedness.
6ae141d6
PE
11617 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11618 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11619
33383987 116202011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11621
d32df629
PE
11622 Improve quality of tests for time stamp overflow.
11623 For example, without this patch (encode-time 0 0 0 1 1
11624 1152921504606846976) returns the obviously-bogus value (-948597
11625 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11626 reports time overflow. See
11627 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11628 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11629 * editfns.c: Include limits.h and intprops.h.
11630 (TIME_T_MIN, TIME_T_MAX): New macros.
11631 (time_overflow): Move earlier, to before first use.
11632 (hi_time, lo_time): New functions, for an accurate test for
11633 out-of-range times.
11634 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11635 (Fget_internal_run_time): Don't assume time_t fits in int.
11636 (make_time): Use list2 instead of Fcons twice.
11637 (Fdecode_time): More accurate test for out-of-range times.
11638 (check_tm_member): New function.
11639 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11640 (lisp_time_argument): Don't rely on undefined left-shift and
11641 right-shift behavior when checking for time stamp overflow.
8be6f318 11642
fe31d94c
PE
11643 * editfns.c (time_overflow): New function, refactoring common code.
11644 (Fformat_time_string, Fdecode_time, Fencode_time):
11645 (Fcurrent_time_string): Use it.
11646
8be6f318
PE
11647 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11648 * dired.c (make_time): Move to ...
11649 * editfns.c (make_time): ... here.
11650 * systime.h: Note the move.
11651
09d9db2c 116522011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11653
126bc0dc
YM
11654 * fringe.c (update_window_fringes): Remove unused variables.
11655
c47cbdfd
YM
11656 * unexmacosx.c (copy_data_segment): Also copy __got section.
11657 (Bug#8223)
11658
7ac80be9
EZ
116592011-03-12 Eli Zaretskii <eliz@gnu.org>
11660
c96bbc66 11661 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11662 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11663 Constify `char *' arguments and their references according to
11664 prototypes in tparam.h.
11665
ecb0f94d 11666 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11667
7ac80be9
EZ
11668 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11669 Adapt all references accordingly.
11670
11671 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11672
ef1fd07e
TT
116732011-03-11 Tom Tromey <tromey@redhat.com>
11674
11675 * buffer.c (syms_of_buffer): Remove obsolete comment.
11676
7ef4b50c
EZ
116772011-03-11 Eli Zaretskii <eliz@gnu.org>
11678
11679 * termhooks.h (encode_terminal_code): Declare prototype.
11680
11681 * msdos.c (encode_terminal_code): Don't declare prototype.
11682
11683 * term.c (encode_terminal_code): Now external again, used by
11684 w32console.c and msdos.c.
11685
44f230aa
SM
11686 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11687 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11688
4b1ec863 116892011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11690
1714f52b 11691 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11692
4b1ec863
PE
11693 * fringe.c (update_window_fringes): Mark locals as initialized
11694 (Bug#8227).
11695 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11696
524c7aa6
PE
11697 * alloc.c (mark_fringe_data): Move decl from here ...
11698 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11699 to check its interface.
11700 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11701
a5c0af81 11702 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11703 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11704 (fontset_font): Mark local as initialized.
a9a06e0b 11705 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11706
b4716021
PE
11707 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11708
811e9bac 11709 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11710 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11711 (x_own_selection, Fx_disown_selection_internal): Rename locals
11712 to avoid shadowing.
11713 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11714
7e3ab302
PE
11715 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11716 so that the caller can use some name other than gcpro1.
11717 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11718 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11719 (Fx_backspace_delete_keys_p):
11720 Use them to avoid shadowing, and rename vars to avoid shadowing.
11721 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11722 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11723 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11724 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11725 Remove unused locals.
7e3ab302
PE
11726 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11727 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11728 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11729 macros.
f78faa98 11730
e2b13473
PE
11731 * xterm.h (x_mouse_leave): New decl.
11732
77f23912
PE
11733 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11734 Remove unused functions.
cdf4ba58
PE
11735 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11736 (x_calc_absolute_position): Now static.
7411c686 11737 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11738 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11739 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11740 unless they are used.
38d0b34a
PE
11741 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11742 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11743 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11744 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11745 (x_error_catcher, x_connection_closed, x_error_handler):
11746 (x_error_quitter, xembed_send_message, x_iconify_frame):
11747 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11748 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11749 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11750
44f230aa
SM
11751 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11752 Rename or move locals to avoid shadowing.
6b463e58 11753 (tty_defined_color, merge_face_heights): Now static.
5967d051 11754 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11755 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11756 does not deduce is never used uninitialized.
73719eba
PE
11757 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11758 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11759
426994c3 11760 * terminal.c (store_terminal_param): Now static.
5489860b 11761
032f1620 11762 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11763 (set_frame_menubar): Remove unused local.
d4323972 11764 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11765 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11766 since they might point to immutable storage.
281585b0
PE
11767 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11768 since it's unused otherwise.
032f1620 11769
367c19e5 11770 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11771 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11772 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11773 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11774 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11775 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11776 does not deduce are never used uninitialized.
70739cbe 11777
07b48fa9
PE
11778 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11779
8868a238 11780 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11781 * window.c (window_loop, size_window):
11782 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11783
7e5cf297 11784 * window.c (display_buffer): Now static.
d6550a9f
PE
11785 (size_window): Mark variables that gcc -Wuninitialized
11786 does not deduce are never used uninitialized.
a586633d
PE
11787 * window.h (check_all_windows): New decl, to forestall
11788 gcc -Wmissing-prototypes diagnostic.
5b555da1 11789 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11790
f6095868
PE
11791 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11792 shadowing.
11793 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11794 Include <limits.h>.
11795 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11796 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11797 (load_charset_map): Mark variables that gcc -Wuninitialized
11798 does not deduce are never used uninitialized.
53df7c11 11799 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11800
f38b440c
PE
11801 * coding.c (coding_set_source, coding_set_destination):
11802 Use "else { /* comment */ }" rather than "else /* comment */;"
11803 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11804 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11805 a block, when the outer 'i' will do.
11806 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11807 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11808 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11809 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11810 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11811 Rename locals to avoid shadowing.
11812 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11813 * coding.c (emacs_mule_char, encode_invocation_designation):
11814 Now static, since they're not used elsewhere.
413bb2db 11815 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11816 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11817 (decode_coding_emacs_mule): Mark variables that gcc
11818 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11819 (detect_coding_iso_2022): Initialize a local variable that might
11820 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11821 this initialization is needed. (Bug#8211)
5f58e762
PE
11822 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11823 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11824 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11825 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11826 Remove unused macros.
f38b440c 11827
232b38b9 11828 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11829 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11830 * character.c (string_count_byte8): Likewise.
232b38b9 11831
fb90da1b
PE
11832 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11833 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11834
fb93dbc2
PE
11835 * chartab.c (copy_sub_char_table): Now static, since it's not used
11836 elsewhere.
5c156ace
PE
11837 (sub_char_table_ref_and_range, char_table_ref_and_range):
11838 Rename locals to avoid shadowing.
bbcd0949 11839 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11840
7d3b3862 11841 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11842 (BIDI_BOB): Remove unused macro.
7d3b3862 11843
6be7d3da
PE
11844 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11845 deduce are never used uninitialized.
c2ed9c8b 11846 * term.c (encode_terminal_code): Likewise.
6be7d3da 11847
75f8807f 11848 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11849
50938595
PE
11850 * tparam.h: New file.
11851 * term.c, tparam.h: Include it.
11852 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11853 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11854 Move these decls to tparam.h, and make them agree with what
11855 is actually in tparam.c. The previous trick of using incompatible
11856 decls in different modules does not conform to the C standard.
11857 All callers of tparam changed to use tparam's actual API.
11858 * tparam.c (tparam1, tparam, tgoto):
11859 Use const pointers where appropriate.
11860
fbceeba2
PE
11861 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11862 * cm.h (struct cm): Likewise.
11863 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11864 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11865 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11866 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11867 (turn_on_face, init_tty): Likewise.
11868 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11869
7f3f1250
PE
11870 * term.c (term_mouse_position): Rename local to avoid shadowing.
11871
e6ca6543
PE
11872 * alloc.c (mark_ttys): Move decl from here ...
11873 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11874
c40f8d15
AS
118752011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11876
11877 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11878
cfe0661d
JB
118792011-03-09 Juanma Barranquero <lekktu@gmail.com>
11880
11881 * search.c (compile_pattern_1): Remove argument regp, unused since
11882 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11883 (compile_pattern): Don't pass it.
11884
0afb4571
J
118852011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11886
11887 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11888 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11889 for ! HAVE_GTK3.
11890 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11891
11892 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11893
11894 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11895 gdk_window_get_screen, gdk_window_get_geometry,
11896 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11897 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11898 (xg_get_pixbuf_from_pixmap): New function.
11899 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11900 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11901 Call xg_get_pixbuf_from_pixmap instead of
11902 gdk_pixbuf_get_from_drawable.
11903 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11904 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11905 (xg_check_special_colors): Use GtkStyleContext and its functions
11906 for HAVE_GTK3.
11907 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11908 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11909 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11910 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11911 Call gtk_widget_get_preferred_size.
0afb4571
J
11912 (xg_frame_resized): gdk_window_get_geometry only takes 5
11913 parameters.
44f230aa
SM
11914 (xg_win_to_widget, xg_event_is_for_menubar):
11915 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11916 (xg_set_widget_bg): New function.
11917 (delete_cb): New function.
895009e1 11918 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11919 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11920 (xg_set_background_color): Call xg_set_widget_bg.
11921 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11922 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11923 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11924 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11925 if ! HAVE_GTK3.
11926 (update_frame_tool_bar): Call gtk_widget_hide.
11927 (xg_initialize): Use GDK_KEY_g.
11928
11929 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11930 if ! HAVE_GTK3
11931 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11932
11933 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11934 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11935 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11936
1c2cc4ef
JB
119372011-03-08 Juanma Barranquero <lekktu@gmail.com>
11938
11939 * w32xfns.c (select_palette): Check success of RealizePalette against
11940 GDI_ERROR, not zero.
11941
33383987 11942See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11943
11944;; Local Variables:
11945;; coding: utf-8
aac0c6e3
MR
11946;; End:
11947
2f097256 11948 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11949
11950 This file is part of GNU Emacs.
11951
11952 GNU Emacs is free software: you can redistribute it and/or modify
11953 it under the terms of the GNU General Public License as published by
11954 the Free Software Foundation, either version 3 of the License, or
11955 (at your option) any later version.
11956
11957 GNU Emacs is distributed in the hope that it will be useful,
11958 but WITHOUT ANY WARRANTY; without even the implied warranty of
11959 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11960 GNU General Public License for more details.
11961
11962 You should have received a copy of the GNU General Public License
11963 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.