Force left-to-right paragraphs in Org buffers.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ed497dd4
AS
12011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2
3 * lread.c (readevalloop): Use correct code for NBSP.
4 (read1): Likewise. (Bug#9608)
5
b2bf61aa
MA
62011-09-25 Michael Albinus <michael.albinus@gmx.de>
7
8 * dbusbind.c (Fdbus_register_signal): When service is not
9 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
10
32bbb17c
GM
112011-09-25 Glenn Morris <rgm@gnu.org>
12
13 * buffer.c (truncate-lines): Doc fix.
14
94e0933e
CY
152011-09-24 Chong Yidong <cyd@stupidchicken.com>
16
17 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
18 (Fset_window_next_buffers): Doc fix.
19
cddde921
GM
202011-09-24 Glenn Morris <rgm@gnu.org>
21
22 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
23
1260aef1
PE
242011-09-24 Paul Eggert <eggert@cs.ucla.edu>
25
25b4bfa0
PE
26 Fix minor problems found by static checking.
27 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
28 * indent.c (Fvertical_motion): Fix == vs = typo.
29
e3cbd34b
EZ
302011-09-24 Eli Zaretskii <eliz@gnu.org>
31
6bf7006f
EZ
32 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
33 value is now t. Doc fix.
34
e3cbd34b
EZ
35 * indent.c (Fvertical_motion): Compute and apply the overshoot
36 logic when moving up, not only when moving down. Fix the
37 confusing name and values of the it_overshoot_expected variable;
38 logic changes accordingly. (Bug#9254) (Bug#9549)
39
40 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
41 CHARPOS is covered by a display string which includes newlines.
42 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
43 is covered by a display string with embedded newlines.
44
a3de0cbd
MA
452011-09-24 Michael Albinus <michael.albinus@gmx.de>
46
47 * dbusbind.c (Fdbus_register_signal): Add match rule to
48 Vdbus_registered_objects_table. (Bug#9581)
49 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
50 docstring.
51
b260039d
JM
522011-09-24 Jim Meyering <meyering@redhat.com>
53
54 do not ignore write error for any output size
55 The previous change was incomplete.
56 While it makes emacs --batch detect the vast majority of stdout
57 write failures, errors were still ignored whenever the output size is
58 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
59 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
60 && echo FAIL: ignored write error
61 FAIL: ignored write error
62 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
63 && echo FAIL: ignored write error
64 FAIL: ignored write error
65 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
66
8eca8a7c
AS
672011-09-23 Andreas Schwab <schwab@linux-m68k.org>
68
69 * emacs.c (Fkill_emacs): In noninteractive mode exit
70 non-successfully if a write error occurred on stdout. (Bug#9574)
71
3341db62
EZ
722011-09-21 Eli Zaretskii <eliz@gnu.org>
73
74 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
75 the xassert test.
76
77 * dispextern.h (struct it): Update the comment documenting what
78 can it->OBJECT be.
79
8c203dbf
EZ
802011-09-20 Eli Zaretskii <eliz@gnu.org>
81
82 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
83 a display string, extend search for cursor position to end of row.
84 (find_row_edges): If the row ends in a newline from a display
85 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
86 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
87 (Fcurrent_bidi_paragraph_direction): Fix search for previous
88 non-empty line. Fixes confusing cursor motion with arrow keys at
89 the beginning of a line that starts with whitespace.
8c203dbf 90
a4824228
LMI
912011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
92
93 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
94 (bug#9493).
95
33ed493b
CY
962011-09-18 Chong Yidong <cyd@stupidchicken.com>
97
98 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
99 boolean (Bug#9154).
100
56cd55c8
EZ
1012011-09-18 Eli Zaretskii <eliz@gnu.org>
102
103 * xdisp.c (display_line): Record maximum and minimum buffer
104 positions even if no glyphs were produced (e.g., by a zero-width
105 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
106 buffer positions that will be removed from the glyph row because
107 they don't fit.
c02dcedf
EZ
108 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
109 column is beyond frame width: don't subtract 1 "pixel" when
110 computing width of the stretch.
3e62b7e0
EZ
111 (reseat_at_next_visible_line_start): Undo the change made on
112 2011-09-17 that saved paragraph information and restored it after
113 the call to `reseat'. (Bug#9545)
56cd55c8 114
5ed99d36 1152011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
116
117 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
118 and turn window cursor on if cleared (Bug#9415).
119
5ed99d36 1202011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
121
122 * search.c (boyer_moore): Take unibyte characters from pattern
123 literally. (Bug#9458)
124
9bade7b2
EZ
1252011-09-18 Eli Zaretskii <eliz@gnu.org>
126
127 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
128
e5e9d610
PE
1292011-09-18 Paul Eggert <eggert@cs.ucla.edu>
130
87e4427a
PE
131 Fix minor problem found by static checking.
132 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
133 initialized, to pacify gcc -Wuninitialized.
134
e5e9d610
PE
135 * fileio.c: Report proper errno when syscall falls.
136 (Finsert_file_contents): Save and restore errno,
137 so that report_file_error outputs the correct diagnostic.
138 (Fwrite_region) [CLASH_DETECTION]: Likewise.
139
a1674f0b
EZ
1402011-09-18 Eli Zaretskii <eliz@gnu.org>
141
142 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
143
fbfb6dd4
EZ
1442011-09-17 Eli Zaretskii <eliz@gnu.org>
145
146 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
147 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
148
bb187662
EZ
1492011-09-17 Eli Zaretskii <eliz@gnu.org>
150
1137e8b8
EZ
151 * xdisp.c (reseat_at_next_visible_line_start): Keep information
152 about the current paragraph and restore it after the call to
153 reseat.
154
155 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
156 (bidi_find_paragraph_start): Search back for paragraph beginning
157 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
158 (bidi_move_to_visually_next): Only trigger paragraph-related
159 computations when the last character is a newline or at EOB, not
160 just any NEUTRAL_B. (Bug#9470)
161
bb187662
EZ
162 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
163 truncated lines if point is covered by a display string. (Bug#9524)
164
2e621251
PE
1652011-09-16 Paul Eggert <eggert@cs.ucla.edu>
166
167 * xselect.c: Relax test for outgoing X longs (Bug#9498).
168 (cons_to_x_long): New function.
169 (lisp_data_to_selection_data): Use it. Correct the test for
170 short-versus-long data; it was negated. Break out of vector
171 loop, for efficiency, when a long datum is discovered.
172
91a15bc6
SM
1732011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
174
175 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
176
b41c3a35
EZ
1772011-09-16 Eli Zaretskii <eliz@gnu.org>
178
179 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
180 GCC PR/17406) by declaring this function with external scope.
181
7812ba2d
PE
1822011-09-15 Paul Eggert <eggert@cs.ucla.edu>
183
184 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
185 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
186
cf7edc2a
AS
1872011-09-15 Andreas Schwab <schwab@linux-m68k.org>
188
189 * editfns.c (Fformat): Correctly handle text properties on "%%".
190
bd01620e
EZ
1912011-09-15 Eli Zaretskii <eliz@gnu.org>
192
193 * xterm.c (x_draw_composite_glyph_string_foreground):
194 * w32term.c (x_draw_composite_glyph_string_foreground):
195 * term.c (encode_terminal_code):
196 * composite.c (composition_update_it, get_composition_id):
197 * xdisp.c (get_next_display_element)
198 (fill_composite_glyph_string): Add comments about special meaning
199 of TAB characters in a composition.
200
a02719a3
PE
2012011-09-15 Paul Eggert <eggert@cs.ucla.edu>
202
203 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
204 This occurs when processing a multibyte format.
205 Problem reported by Wolfgang Jenker.
a02719a3 206
72589a3c
JB
2072011-09-15 Johan Bockgård <bojohan@gnu.org>
208
209 * xdisp.c (try_cursor_movement): Only check for exact match if
210 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
211
1c14176c
PE
2122011-09-14 Paul Eggert <eggert@cs.ucla.edu>
213
214 Remove unused external symbols.
215 * dispextern.h (calc_pixel_width_or_height): Remove decl.
216 * xdisp.c (calc_pixel_width_or_height): Now static.
217 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
218 * indent.c (check_display_width):
219 * w32term.c: Fix comment to match code.
220 * xterm.c, xterm.h (x_catching_errors): Remove.
221
d2eea5b5
PE
2222011-09-14 Paul Eggert <eggert@cs.ucla.edu>
223
224 * xselect.c: Use signed conversions more consistently (Bug#9498).
225 (selection_data_to_lisp_data): Assume incoming selection data are
226 signed integers, not unsigned. This is to be consistent with
227 outgoing selection data, which was modified to use signed integers
228 in as part of the fix to Bug#9196 in response to Jan D.'s comment
229 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
230 expects long, not unsigned long.
231
46888499
EZ
2322011-09-14 Eli Zaretskii <eliz@gnu.org>
233
234 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
235 computation of loop end. Reported by Johan Bockgård
236 <bojohan@gnu.org>.
237
ef8ef9fb
CY
2382011-09-13 Chong Yidong <cyd@stupidchicken.com>
239
240 * frame.c (Fother_visible_frames_p): Function deleted.
241
fa819fed
EZ
2422011-09-12 Eli Zaretskii <eliz@gnu.org>
243
244 * indent.c (compute_motion): Process display vector front to back
245 rather than the other way around. (Bug#2496)
246
2ba8e008
SM
2472011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
248
249 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
250
20f53c69
CY
2512011-09-11 Chong Yidong <cyd@stupidchicken.com>
252
253 * minibuf.c (Fread_from_minibuffer): Doc fix.
254
d562d7a4
EZ
2552011-09-11 Eli Zaretskii <eliz@gnu.org>
256
257 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
258 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
259
1c4d7f3d
LMI
2602011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
261
262 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
263 value for non-existent files.
264
b885bf36
EZ
2652011-09-11 Eli Zaretskii <eliz@gnu.org>
266
267 * fileio.c (Finsert_file_contents): If the file cannot be opened,
268 set its "size" to -1. This will set the modtime_size field of
269 the corresponding buffer to -1, which is what
270 verify-visited-file-modtime expects for files that do not exist.
271 (Bug#9139)
272
6612f0bf
PE
2732011-09-11 Paul Eggert <eggert@cs.ucla.edu>
274
275 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
276 here ...
277 * lisp.h: ... from here. push_key_description is no longer
278 defined in keyboard.c, so its declaration should not be in
279 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
280 logically belongs with push_key_description.
281
dfb3f755
PE
2822011-09-10 Paul Eggert <eggert@cs.ucla.edu>
283
284 * buffer.h: Include <sys/types.h> instead of <time.h>.
285 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
286 Problem reported by Herbert J. Skuhra.
287
3134906c
LMI
2882011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
289
290 * xml.c (parse_region): Make the parsing work for
291 non-comment-starting XML files again (bug#9144).
292
8d903f4e
AS
2932011-09-10 Andreas Schwab <schwab@linux-m68k.org>
294
295 * image.c (gif_load): Fix calculation of bottom and right corner.
296 (Bug#9468)
297
80ad64f4
EZ
2982011-09-10 Eli Zaretskii <eliz@gnu.org>
299
300 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
301 redisplay in small windows.
302
208a048d
EZ
3032011-09-09 Eli Zaretskii <eliz@gnu.org>
304
305 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
306
9b1c252e
MR
3072011-09-08 Martin Rudalics <rudalics@gmx.at>
308
309 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
310 Operate on live windows only.
311
2949f33b
JB
3122011-09-08 Juanma Barranquero <lekktu@gmail.com>
313
314 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
315
e08dcafd
EZ
3162011-09-07 Eli Zaretskii <eliz@gnu.org>
317
318 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
319 only under bidi iteration.
320
115b96bd
JD
3212011-09-07 Jan Djärv <jan.h.d@swipnet.se>
322
323 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
324
c8199d0f
PE
3252011-09-06 Paul Eggert <eggert@cs.ucla.edu>
326
327 isnan: Fix porting problem to Solaris 10 with bundled gcc.
328 Without this fix, the command to link temacs failed due to an
329 undefined symbol __builtin_isnan. This is because
330 /usr/include/iso/math_c99.h #defines isnan(x) to
331 __builtin_isnan(x), but the bundled gcc, which identifies itself
332 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
333 a __builtin_isnan.
334 * floatfns.c (isnan): #undef, and then #define to a clone of
335 what's in data.c.
336 (Fisnan): Always define, since it's always available now.
337 (syms_of_floatfns): Always define isnan at the Lisp level.
338
e39b275c 3392011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
340
341 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
342
b2db44d9 3432011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 344
f4af5137 345 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
346 The previous code assumed that file offsets (off_t values) fit in
347 EMACS_INT variables, which is not true on typical 32-bit hosts.
348 The code messed up by falsely reporting buffer overflow in cases
349 such as (insert-file-contents "big" nil 1 2) into an empty buffer
350 when "big" contains more than 2**29 bytes, even though this
351 inserts just one byte and does not overflow the buffer.
352 (Finsert_file_contents): Store file offsets as off_t
353 values, not as EMACS_INT values. Check for overflow when
354 converting between EMACS_INT and off_t. When checking for
355 buffer overflow or for overlap, take the offsets into account.
356 Don't use EMACS_INT for small values where int suffices.
357 When checking for overlap, fix a typo: ZV was used where
358 ZV_BYTE was intended.
359 (Fwrite_region): Don't assume off_t fits into 'long'.
360 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
361
ecfc0a49
MA
3622011-09-05 Michael Albinus <michael.albinus@gmx.de>
363
364 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
365
6511acf2 3662011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 367
0999621a 368 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
369
370 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 371 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
372 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
373 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
374 (modify_event_symbol): Do not assume that the length of
375 name_alist_or_stem is safe to alloca and fits in int.
376 (Fexecute_extended_command): Likewise for function name and binding.
377 (Frecursion_depth): Wrap around reliably on integer overflow.
378 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
379 since some callers pass EMACS_INT values.
380 (Fsingle_key_description): Don't crash if symbol name contains more
381 than MAX_ALLOCA bytes.
382 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
383 (get_minibuffer): Arg is now EMACS_INT, not int.
384 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 385 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
386 * window.h (command_loop_level, minibuf_level): Reflect API changes.
387
2be7d702
PE
388 * dbusbind.c (signature_cat): New function.
389 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
390 Do not overrun buffer; instead, report string overflow.
391
9d1df220
PE
392 * dispnew.c (add_window_display_history): Don't overrun buffer.
393 Truncate instead; this is OK since it's just a log.
394
33ef5c64
PE
395 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
396 even if the time zone offset is outlandishly large.
397 Don't mishandle offset == INT_MIN.
398
66c6fdd5
PE
399 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
400 when creating daemon; the previous buffer-overflow check was incorrect.
401
d749b01b
PE
402 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
403 which has the guts of the old verror function.
404
b5cd1905
PE
405 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
406 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
407
6e1a67fb
PE
408 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
409 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 410 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 411 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
412 length of string rather than counting it via multiple sprintfs;
413 that's simpler and more reliable.
c21721cc
PE
414 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
415 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
416 sprintf, in case result does not fit in int.
417
c57b67fc
PE
418 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
419 (fontset_from_font): Print it.
420
8a401434
PE
421 * frame.c (tty_frame_count): Now printmax_t, not int.
422 (make_terminal_frame, set_term_frame_name): Print it.
423 (x_report_frame_params): In X, window IDs are unsigned long,
424 not signed long, so print them as unsigned.
425 (validate_x_resource_name): Check for implausibly long names,
426 and don't assume name length fits in 'int'.
427 (x_get_resource_string): Don't blindly alloca invocation name;
428 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
429 not fit in int.
430
6e1a67fb
PE
431 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
432 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
433 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
434
0df02bf3
PE
435 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
436 Use esprintf, not sprintf, in case result does not fit in int.
437
48e30793
PE
438 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
439 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
440 it as a large positive number.
441 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
442 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
443
a66ff6d8
PE
444 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
445 in case result does not fit in int.
446
aca216ff
PE
447 * print.c (float_to_string): Detect width overflow more reliably.
448 (print_object): Make sprintf buffer a bit bigger, to avoid potential
449 buffer overrun. Don't assume list length fits in 'int'. Treat
450 print length of 0 as 0, not as infinity; to be consistent with other
451 uses of print length in this function. Don't overflow print length
452 index. Don't assume hash table size fits in 'long', or that
453 vectorlike size fits in 'unsigned long'.
454
31c286f7
PE
455 * process.c (make_process): Use printmax_t, not int, to format
456 process-name gensyms.
457
55e5faa1
PE
458 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
459
80f2e268
PE
460 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
461 to avoid potential buffer overrun.
462
670741ab
PE
463 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
464 if X resource line is longer than 512 bytes.
465
b7163a50
PE
466 * xfns.c (x_window): Make sprintf buffer a bit bigger
467 to avoid potential buffer overrun.
468
ae58ff1f
PE
469 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
470
c43c8a6a
PE
471 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
472
3f8236f4
PE
4732011-09-04 Paul Eggert <eggert@cs.ucla.edu>
474
53e9fe90 475 Integer overflow fixes for scrolling, etc.
6511acf2
PE
476 Without these, Emacs silently mishandles large integers sometimes.
477 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
478 it were "C-u 1 M-x recenter" on a typical 64-bit host.
479
6511acf2
PE
480 * xdisp.c (try_window_id): Check Emacs fixnum range before
481 converting to 'int'.
806add1d 482
6511acf2 483 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
484 Check that an Emacs fixnum is in range before assigning it to 'int'.
485 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
486 values converted from Emacs fixnums.
487 (Frecenter): Don't wrap around a line count if it is out of 'int'
488 range; instead, treat it as an extreme value.
489 (Fset_window_configuration, compare_window_configurations):
490 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
491
6511acf2
PE
492 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
493 that can exceed INT_MAX. Check that EMACS_INT value is in range
494 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
495 (match_limit): Don't assume that a fixnum can fit in 'int'.
496
6511acf2 497 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
498 exceed INT_MAX.
499
6511acf2 500 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
501 (Fvertical_motion): Don't wrap around LINES values that don't fit
502 in 'int'. Instead, treat them as extreme values. This is good
503 enough for windows, which can't have more than INT_MAX lines anyway.
504
fcb901a7
LMI
5052011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
506
0f2f6b6d
LMI
507 * Require libxml/parser.h to avoid compilation warning.
508
fcb901a7
LMI
509 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
510
511 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
512 since this reportedly can destroy thread storage.
513
6e20a0d4
CY
5142011-08-30 Chong Yidong <cyd@stupidchicken.com>
515
516 * syntax.c (find_defun_start): Update all cache variables if
517 exiting early (Bug#9401).
518
148ae00e
EZ
5192011-08-30 Eli Zaretskii <eliz@gnu.org>
520
f6cfbd8f
EZ
521 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
522
148ae00e
EZ
523 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
524 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
525 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
526
527 * term.c (tty_append_glyph): New function.
528 (produce_stretch_glyph): Static function and its prototype deleted.
529
530 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
531 prototypes.
532
c4a07a4c
PE
5332011-08-29 Paul Eggert <eggert@cs.ucla.edu>
534
535 * image.c (parse_image_spec): Check for nonnegative, not for positive,
536 when checking :margin (Bug#9390).
537 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
538 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
539 so that the name doesn't mislead. All uses changed.
540
6bc8cd65
JB
5412011-08-28 Johan Bockgård <bojohan@gnu.org>
542
543 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
544 set_tty_hooks.
545
dca4927e
EZ
5462011-08-27 Eli Zaretskii <eliz@gnu.org>
547
548 * xdisp.c (move_it_to): Don't bail out early when reaching
549 position beyond to_charpos, if we are scanning backwards.
550 (move_it_vertically_backward): When DY == 0, make sure we get to
551 the first character in the line after the newline.
552
f2cad773
PE
5532011-08-27 Paul Eggert <eggert@cs.ucla.edu>
554
555 * ccl.c: Improve and simplify overflow checking (Bug#9196).
556 (ccl_driver): Do not generate an out-of-range pointer.
557 (Fccl_execute_on_string): Remove unnecessary check for
558 integer overflow, noted by Stefan Monnier in
559 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
560 Remove a FIXME that didn't need fixing.
561 Simplify the newly-introduced buffer reallocation code.
562
0cae2cdb
JB
5632011-08-27 Juanma Barranquero <lekktu@gmail.com>
564
565 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
566
5fc295a4 5672011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 568
70c60eb2 569 Integer and memory overflow issues (Bug#9196).
726e0ab1 570
d31850da
PE
571 * doc.c (get_doc_string): Rework so that
572 get_doc_string_buffer_size is the actual buffer size, rather than
573 being 1 less than the actual buffer size; this makes xpalloc more
574 convenient.
575
a69fbedb
PE
576 * image.c (x_allocate_bitmap_record, cache_image):
577 * xselect.c (Fx_register_dnd_atom):
578 Simplify previous changes by using xpalloc.
579
fe5c5d37
PE
580 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
581 since either will do and ptrdiff_t is convenient with xpalloc.
582
0065d054
PE
583 * charset.c (charset_table_size)
584 (struct charset_sort_data.priority): Now ptrdiff_t.
585 (charset_compare): Don't overflow if priorities differ greatly.
586 (Fsort_charsets): Don't assume list length fits in int.
587 Check for size-calculation overflow when allocating sort data.
588 (syms_of_charset): Allocate an initial charset table that is
589 just under 64 KiB, to avoid problems with glibc malloc and mmap.
590
591 * cmds.c (internal_self_insert): Check for size-calculation overflow.
592
593 * composite.h (struct composition.glyph_len): Now int, not unsigned.
594 The actual value is always <= INT_MAX, and leaving it unsigned made
595 overflow checking harder.
596
597 * dispextern.h (struct glyph_matrix.rows_allocated)
598 (struct face_cache.size): Now ptrdiff_t, for convenience in use
599 with xpalloc. The values are still always <= INT_MAX.
600
601 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
602
603 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
604 (SAFE_NALLOCA): New macro.
605
606 * region-cache.c (struct boundary.pos, find_cache_boundary)
607 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
608 (set_cache_region, invalidate_region_cache)
609 (revalidate_region_cache, know_region_cache, region_cache_forward)
610 (region_cache_backward, pp_cache):
611 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
612 so that ptrdiff_t * can be passed to xpalloc.
613 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
614 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
615 (pp_cache): Don't assume cache_len fits in int.
616 * region-cache.h: Adjust extern decls to match.
617
618 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
619 EMACS_INT, since either will do, for xpalloc.
620
621 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
622 (xnmalloc, xnrealloc, xpalloc): New functions.
623
726e0ab1
PE
624 * bidi.c (bidi_shelve_header_size): New constant.
625 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
626 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
627
51f30bc5 628 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
629 * buffer.c (overlays_at, overlays_in, record_overlay_string)
630 (overlay_strings):
631 Don't update size of array until after memory allocation succeeds,
632 because xmalloc/xrealloc may not return.
0065d054
PE
633 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
634 now that we have proper integer overflow checking.
635 (record_overlay_string, overlay_strings): Catch overflows when
636 calculating size of overlay_str_buf.
726e0ab1 637
0065d054
PE
638 * callproc.c (Fcall_process): Check for size overflow when
639 calculating size of args2.
640 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
641 Normally we prefer signed values, but sticking with ptrdiff_t would
642 require adding more-complicated checks.
726e0ab1
PE
643
644 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
645 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
646 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 647 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
648
649 * character.c (Fstring): Check for size-calculation overflow.
650
651 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
652 unnecessary integer overflow. Check for size overflow.
653 (encode_coding_object): Don't update size until xmalloc succeeds.
654
655 * composite.c (get_composition_id): Check for overflow in glyph
656 length calculations.
657
658 Integer and memory overflow fixes for display code.
659 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
660 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
661 (scrolling_window): Check for overflow in size calculations.
662 (line_draw_cost, realloc_glyph_pool, add_row_entry):
663 Don't assume glyph table len fits in int.
664 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
665 (row_table_size): Now ptrdiff_t, not int.
666 (scrolling_window): Avoid overflow in size calculations.
667 Don't update size until allocation succeeds.
668 * fns.c (concat): Check for overflow in size calculations.
669 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
670 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
671 (NEXT_ALMOST_PRIME_LIMIT): New constant.
672
673 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
674 (get_doc_string): Check for size calculation overflow.
675 Don't update size until allocation succeeds.
676 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
677 EMACS_INT, where ptrdiff_t will do.
678 (Fsubstitute_command_keys): Check for string overflow.
679
680 * editfns.c (set_time_zone_rule): Don't assume environment length
681 fits in int.
682 (message_length): Now ptrdiff_t, not int.
683 (Fmessage_box): Don't update size until allocation succeeds.
684 Don't assume message length fits in int.
685 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
686
0065d054
PE
687 * emacs.c (main): Do not reallocate argv, since there is a null at
688 the end that can be overwritten, and this way there's no need to
689 worry about size-calculation overflow.
690 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
691
692 * eval.c (init_eval_once, grow_specpdl): Don't update size until
693 alloc succeeds.
694 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
695
696 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
697 (x_set_scroll_bar_width, x_figure_window_size):
698 Check for integer overflow.
699 (x_set_alpha): Do not assume XINT fits in int.
700
701 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
702 This is for the members text_lines, text_cols, total_lines, total_cols,
703 where the system imposes an 'int' limit.
704
705 * fringe.c (Fdefine_fringe_bitmap):
706 Don't update size until alloc works.
707
708 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
709 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
710
711 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
712 Check for size-calculation overflow.
713 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
714 do, as we prefer signed integers.
715 (id_to_widget.max_size, id_to_widget.used)
716 (xg_store_widget_in_map, xg_remove_widget_from_map)
717 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
718 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
719 Use and return ptrdiff_t, not int.
720 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
721 * gtkutil.h: Change prototypes to match the above.
722
723 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
724 are duplicate now that they've been promoted to lisp.h.
725 (x_allocate_bitmap_record, x_alloc_image_color)
726 (make_image_cache, cache_image, xpm_load):
727 Don't update size until alloc is done.
728 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
729 (x_detect_edges):
3256efce 730 Check for size calculation overflow.
726e0ab1
PE
731 (ct_colors_allocated_max): New constant.
732 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
733 overflow.
3256efce 734
726e0ab1
PE
735 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
736 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
737 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
738 Use ptrdiff_t, not int, to count maps.
739 (read_char_minibuf_menu_prompt): Check for overflow in size
740 calculations. Don't update size until allocation succeeds. Redo
741 calculations to avoid overflow.
742 * keyboard.h: Change prototypes to match the above.
743
744 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
745 to count maps.
746 (current_minor_maps): Check for size calculation overflow.
747 * keymap.h: Change prototypes to match the above.
748
749 * lread.c (read1, init_obarray): Don't update size until alloc done.
750
751 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
752 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
753
726e0ab1
PE
754 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
755 Now ptrdiff_t, not int.
756 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
757 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
758
759 * process.c (Fnetwork_interface_list): Check for overflow
760 in size calculation.
761
762 * region-cache.c (move_cache_gap): Check for size calculation overflow.
763
764 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
765 overflow. Don't bother calling xmalloc when xrealloc will do.
766
767 * search.c (Freplace_match): Check for size calculation overflow.
768 (Fset_match_data): Don't assume list lengths fit in 'int'.
769
770 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
771 for command line length. Do not attempt to address one before the
772 beginning of an array, as that's not portable.
773
774 * term.c (max_frame_lines): Remove; unused.
775 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
776 not int.
777 (encode_terminal_code, calculate_costs): Check for size
778 calculation overflow.
779 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
780 table lengths and related sizes. Don't update size until alloc
781 done. Redo calculations to avoid overflow.
782 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
783
784 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
785 subtracting pointers.
786 (gobble_line): Check for overflow more carefully. Don't update size
787 until alloc done.
788
789 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
790 Don't update size until alloc done.
791 Redo size calculations to avoid overflow.
792 Check for size calculation overflow.
0065d054 793 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
794
795 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
796 Use ptrdiff_t, not int, for sizes.
797 (store_mode_line_noprop_char): Don't update size until alloc done.
798
0065d054
PE
799 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
800 Use ptrdiff_t, not int, for sizes.
801 (Finternal_make_lisp_face, cache_face):
802 Check for size calculation overflow.
803 (cache_face): Treat size calculation overflows as if they were
804 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
805
806 * xfns.c (x_encode_text, x_set_name_internal)
807 (Fx_change_window_property): Use ptrdiff_t, not int, to count
808 sizes, since they can exceed INT_MAX in size. Check for size
809 calculation overflow.
810
0065d054
PE
811 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
812 (xg_select): Check for size calculation overflow.
726e0ab1
PE
813 Don't update size until alloc done.
814
0065d054 815 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 816 as sprintf is limited to int lengths.
1d526e2f 817
252c5ee1
PE
818 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
819 (X_LONG_MIN): New macros.
864d7ce7
PE
820 Use them to make the following changes clearer.
821 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
822 This change doesn't affect the value now, but it may help remind
823 future maintainers not to raise the value too much later.
824 (SELECTION_QUANTUM): Remove, replacing with ...
825 (selection_quantum): ... new function, which avoids overflow.
826 All uses changed.
827 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
828 assumption that selection length fits in 'int'.
829 (x_reply_selection_request, x_handle_selection_request)
830 (x_get_window_property, receive_incremental_selection)
831 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
832 (lisp_data_to_selection_data, clean_local_selection_data):
833 Use ptrdiff_t, not int, to record length of selection.
834 (x_reply_selection_request, x_get_window_property)
835 (receive_incremental_selection, x_property_data_to_lisp):
836 Redo calculations to avoid overflow.
837 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 838 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
839 something.
840 (x_get_window_property, receive_incremental_selection)
841 (lisp_data_to_selection_data, x_property_data_to_lisp):
842 Check for size-calculation overflow.
843 (x_get_window_property, receive_incremental_selection)
844 (lisp_data_to_selection_data, Fx_register_dnd_atom):
845 Don't store size until memory allocation succeeds.
846 (x_get_window_property): Plug memory leak on memory exhaustion.
847 Don't double-block input; malloc is safe here. Don't assume 2**34
848 - 4 fits in unsigned long. Add an xassert to check
849 XGetWindowProperty overflow. Be more careful about overflow
850 calculations, and distinguish size from memory overflow better.
851 (receive_incremental_selection): When tracing, don't assume
852 unsigned int is less than INT_MAX.
853 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
854 harmful) conversions of unsigned short to int.
855 (lisp_data_to_selection_data): Don't assume that integers
856 in the range -65535 through -1 fit in an X unsigned short.
857 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
858 result parameters unless successful. Rely on cons_to_unsigned
859 to report problems with elements; the old code wasn't right anyway.
860 (x_check_property_data): Check for int overflow; we cannot use
861 a wider type due to X limits.
862 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
863
726e0ab1 864 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 865
0065d054
PE
866 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
867 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
868 (x_color_cells): Don't store size until memory allocation succeeds.
869 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 870 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
871 (x_term_init): Don't assume length fits in int (sprintf is limited
872 to int size).
bc18e09d 873
ebfa62c0
PE
874 Use ptrdiff_t for composition IDs.
875 * character.c (lisp_string_width):
876 * composite.c (composition_table_size, n_compositions)
877 (get_composition_id, composition_gstring_from_id):
878 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
879 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
880 * window.c (Frecenter):
881 Use ptrdiff_t, not int, for composition IDs.
882 * composite.c (get_composition_id): Check for integer overflow.
883 * composite.h: Adjust prototypes to match the above changes.
884
d3411f89
PE
885 Use ptrdiff_t for hash table indexes.
886 * category.c (hash_get_category_set):
887 * ccl.c (ccl_driver):
888 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
889 * coding.c (coding_system_charset_list, detect_coding_system):
890 * coding.h (struct coding_system.id):
891 * composite.c (get_composition_id, gstring_lookup_cache):
892 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
893 * image.c (xpm_get_color_table_h):
894 * lisp.h (hash_lookup, hash_put):
895 * minibuf.c (Ftest_completion):
896 Use ptrdiff_t for hash table indexes, not int (which is too
897 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
898 32-bit --with-wide-int hosts).
899
e097a6fa
PE
900 * charset.c (Fdefine_charset_internal): Check for integer overflow.
901 Add a FIXME comment about memory leaks.
902 (syms_of_charset): Don't assume xmalloc returns.
903
5637687f
PE
904 Don't assume that stated character widths fit in int.
905 * character.c (Fchar_width, c_string_width, lisp_string_width):
906 * character.h (CHAR_WIDTH):
907 * indent.c (MULTIBYTE_BYTES_WIDTH):
908 Use sanitize_char_width to avoid undefined and/or bad behavior
909 with outlandish widths.
910 * character.h (sanitize_tab_width): Renamed from sanitize_width,
911 now that we have two such functions. All uses changed.
912 (sanitize_char_width): New inline function.
913
a2271ba2
PE
914 Don't assume that tab-width fits in int.
915 * character.h (sanitize_width): New inline function.
916 (SANE_TAB_WIDTH): New macro.
917 (ASCII_CHAR_WIDTH): Use it.
918 * indent.c (sane_tab_width): Remove. All uses replaced by
919 SANE_TAB_WIDTH (current_buffer).
920 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
921
18c52557
PE
922 * fileio.c: Integer overflow issues with file modes.
923 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
924
caeeedc1
PE
925 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
926 Remove unreachable code.
927 (read_hex, load_charset_map_from_file): Check for integer overflow.
928
50849c52
PE
929 * xterm.c: don't go over XClientMessageEvent limit
930 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
931 (x_send_scroll_bar_event): Likewise. Check that the size does not
932 exceed limits imposed by XClientMessageEvent, as well as the usual
933 ptrdiff_t and size_t limits.
934
b13995db
PE
935 * keyboard.c: Overflow, signedness and related fixes.
936 (make_lispy_movement): Use same integer type in forward decl
937 that is used in the definition.
938 (read_key_sequence, keyremap_step):
939 Change bufsize argument back to int, undoing my 2011-03-30 change.
940 We prefer signed types, and int is wide enough here.
941 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
942 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
943 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
944 length, not size_t. Use ptrdiff_t for index, not int.
945 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
946 possibility of integer overflow.
947
13464394
PE
948 Overflow, signedness and related fixes for images.
949
950 * dispextern.h (struct it.stack[0].u.image.image_id)
951 (struct_it.image_id, struct image.id, struct image_cache.size)
952 (struct image_cache.used, struct image_cache.ref_count):
953 * gtkutil.c (update_frame_tool_bar):
954 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
955 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
956 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
957 * nsmenu.m (update_frame_tool_bar):
958 * xdisp.c (calc_pixel_width_or_height):
959 * xfns.c (image_cache_refcount):
960 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
961 on typical 64-bit hosts.
962
963 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
964 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
965 Omit unnecessary casts to int.
966 (parse_image_spec): Check that integers fall into 'int' range
967 when the callers expect that.
968 (image_ascent): Redo ascent calculation to avoid int overflow.
969 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
970 (lookup_image): Remove unnecessary tests.
971 (xbm_image_p): Locals are now of int, not EMACS_INT,
972 since parse_image_check makes sure they fit into int.
973 (png_load, gif_load, svg_load_image):
974 Prefer int to unsigned where either will do.
975 (tiff_handler): New function, combining the cores of the
976 old tiff_error_handler and tiff_warning_handler. This
977 function is rewritten to use vsnprintf and thereby avoid
978 stack buffer overflows. It uses only the features of vsnprintf
979 that are common to both POSIX and native Microsoft.
980 (tiff_error_handler, tiff_warning_handler): Use it.
981 (tiff_load, gif_load, imagemagick_load_image):
982 Don't assume :index value fits in 'int'.
983 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
984 (imagemagick_load_image): Check that crop parameters fit into
985 the integer types that MagickCropImage accepts. Don't assume
986 Vimagemagick_render_type has a nonnegative value. Don't assume
987 size_t fits in 'long'.
988 (gs_load): Use printmax_t to print the widest integers possible.
989 Check for integer overflow when computing image height and width.
990
c11821d4
EZ
9912011-08-26 Eli Zaretskii <eliz@gnu.org>
992
993 * xdisp.c (redisplay_window): Don't force window start if point
994 will be invisible in the resulting window. (Bug#9324)
995
0c95fcf7
EZ
9962011-08-25 Eli Zaretskii <eliz@gnu.org>
997
998 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
999 the display spec is of the form `(space ...)'.
1000 (handle_display_spec): Return the value returned by
1001 handle_single_display_spec, not just 1 or zero.
1002 (handle_single_display_spec): If the display spec is of the form
1003 `(space ...)', and specifies display in the text area, return 2
1004 rather than 1.
fee65a97 1005 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
1006 accurately, and prefer exact match for point under bidi. Don't
1007 advance `row' beyond the last row of the window.
0c95fcf7
EZ
1008
1009 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1010 into disp_prop; all users changed.
1011
1012 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1013 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1014 for the text covered by the display property.
1015
e4ed06f1
CY
10162011-08-25 Chong Yidong <cyd@stupidchicken.com>
1017
1018 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1019 Change return value to nil.
1020 (Frecord_buffer): Delete unused function.
1021
f67cdd7f
EZ
10222011-08-24 Eli Zaretskii <eliz@gnu.org>
1023
5980d4c6
EZ
1024 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1025 buffers, return left-to-right.
8610fe8b
EZ
1026 (set_cursor_from_row): Consider candidate row a win if its glyph
1027 represents a newline and point is on that newline. Fixes cursor
1028 positioning on the newline at EOL of R2L text within L2R
1029 paragraph, and vice versa.
1030 (try_cursor_movement): Check continued rows, in addition to
1031 continuation rows. Fixes unwarranted scroll when point enters a
1032 continued line of R2L text within an L2R paragraph, or vice versa.
1033 (cursor_row_p): Consider the case of point being equal to
1034 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1035 from the end of a short line to the beginning of a continued line
1036 of R2L text within L2R paragraph.
1037 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1038 composed characters.
5980d4c6 1039
f67cdd7f
EZ
1040 * bidi.c (bidi_check_type): Use xassert.
1041 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1042 members.
1043
bca633fb
EZ
10442011-08-23 Eli Zaretskii <eliz@gnu.org>
1045
1046 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1047 a character.
1048
4a5885a7
CY
10492011-08-23 Chong Yidong <cyd@stupidchicken.com>
1050
1051 * nsfont.m (ns_otf_to_script): Fix typo.
1052
0902a04e
KH
10532011-08-22 Kenichi Handa <handa@m17n.org>
1054
1055 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1056 extra slot even if the purpose is char-code-property-table.
1057
1a2e6670
EZ
10582011-08-23 Eli Zaretskii <eliz@gnu.org>
1059
8ddde651
EZ
1060 * xdisp.c (redisplay_window): When computing centering_position,
1061 account for the height of the header line. (Bug#8874)
1062
425cc014
EZ
1063 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1064 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1065 candidate is selected by the mouse, and that candidate has a
1066 composed character under the mouse.
1067
1a2e6670
EZ
1068 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1069 coordinates reported by pos-visible-in-window-p for a composed
1070 character in column zero.
1071
8b76d6f8
SM
10722011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1073
1074 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1075
dac347dd
EZ
10762011-08-22 Eli Zaretskii <eliz@gnu.org>
1077
1078 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1079 consider it a hit if to_charpos is anywhere in the range of the
1080 composed buffer positions.
1081
e013fb34
CY
10822011-08-22 Chong Yidong <cyd@stupidchicken.com>
1083
1084 * image.c (gif_load): Don't assume that each subimage has the same
1085 dimensions as the base image. Handle disposal method that is
1086 "undefined" by the gif spec (Bug#9335).
1087
bd1ba3e8
CY
10882011-08-20 Chong Yidong <cyd@stupidchicken.com>
1089
1090 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 1091 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 1092
54a1215b
EZ
10932011-08-19 Eli Zaretskii <eliz@gnu.org>
1094
823564e5
EZ
1095 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1096 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1097 from an Org mode buffer to a Speedbar frame.
1098
54a1215b
EZ
1099 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1100 a composition, take its buffer position from IT->cmp_it.charpos.
1101 Fixes cursor positioning at the beginning of a line that begins
1102 with a composed character.
1103
9778ebcc
EZ
11042011-08-18 Eli Zaretskii <eliz@gnu.org>
1105
0be6ee06
EZ
1106 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1107 character bidirectional type, use STRONG_L instead. Fixes crashes
1108 in a buffer produced by `describe-categories'.
1109
9778ebcc
EZ
1110 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1111 members before the level stack, so they would be saved and
1112 restored when copying iterator state. Fixes incorrect reordering
1113 around TABs covered by display properties.
1114
156bffbe
AS
11152011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1116
1117 * process.c (Fnetwork_interface_list): Correctly determine buffer
1118 size.
1119
72ad093b
CY
11202011-08-17 Chong Yidong <cyd@stupidchicken.com>
1121
1122 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
1123 (internal_condition_case_2, internal_condition_case_n):
1124 Remove unnecessary aborts (Bug#9081).
72ad093b 1125
35774242
EZ
11262011-08-17 Eli Zaretskii <eliz@gnu.org>
1127
1128 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1129 has no `load' handler, try opening the file locally. (Bug#9311)
1130
db76dd85
KB
11312011-08-16 Ken Brown <kbrown@cornell.edu>
1132
1133 * gmalloc.c: Expand comment.
1134
b215eee5
EZ
11352011-08-16 Eli Zaretskii <eliz@gnu.org>
1136
1137 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1138 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1139
a4579d33
KB
11402011-08-16 Ken Brown <kbrown@cornell.edu>
1141
1142 Fix memory allocation problems in Cygwin build (Bug#9273).
1143
1144 * unexcw.c ( __malloc_initialized): Declare external variable.
1145 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1146
8b76d6f8
SM
1147 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1148 New variables.
a4579d33
KB
1149 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1150 dumped emacs.
1151 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1152 in the static heap.
1153 [CYGWIN] (special_realloc): New function.
1154 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1155 requests to realloc storage in the static heap.
1156
3ebec551
PE
11572011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1158
1159 * bidi.c (bidi_initialize): Remove unused local.
1160
9fd8be00
EZ
11612011-08-15 Eli Zaretskii <eliz@gnu.org>
1162
474a8465
EZ
1163 * biditype.h: File removed.
1164
1165 * bidimirror.h: File removed.
1166
1167 * deps.mk (bidi.o): Remove biditype.h and
1168 bidimirror.h.
1169
1170 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1171 bidimirror.h.
1172
1173 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1174
1175 * chartab.c: Improve commentary for the uniprop_table API.
1176
32413314
EZ
1177 * bidi.c (bidi_paragraph_init): Support zero value of
1178 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1179 (bidi_initialize): Use uniprop_table instead of including
1180 biditype.h and bidimirror.h.
32413314 1181
9fd8be00
EZ
1182 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1183 coordinates of the iterator when restoring from ppos_it.
1184 (Bug#9296)
1185
5cf2b69b
KH
11862011-08-14 Kenichi Handa <handa@m17n.org>
1187
1188 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1189 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1190
daf17d00
EZ
11912011-08-14 Eli Zaretskii <eliz@gnu.org>
1192
1193 * xdisp.c (move_it_in_display_line_to): Don't invoke
1194 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1195 ppos_it. Fixes vertical cursor motion when line beginning is
1196 covered by an image. (Bug#9296)
1197
08e3161a
JD
11982011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1199
1200 * nsterm.h (ns_run_ascript): Declare.
1201 (NSAPP_DATA2_RUNASSCRIPT): Define.
1202
1203 * nsfns.m (as_script, as_result, as_status): New static variables.
1204 (ns_run_ascript): New function.
5e617bc2 1205 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1206 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1207 the event loop. Get status from as_status (Bug#7276).
1208
1209 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1210 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1211 the event loop (Bug#7276).
1212
a3720aa2
AS
12132011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1214
1215 * gnutls.c (QCgnutls_bootprop_priority)
1216 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1217 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1218 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1219 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1220 (QCgnutls_bootprop_verify_hostname_error)
1221 (QCgnutls_bootprop_callbacks_verify): Rename from
1222 Qgnutls_bootprop_..., all uses changed.
1223
1224 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1225 uses changed.
1226
0a0d27fb
PE
12272011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1228
19d5c50c
PE
1229 * xfaces.c (Qframe_set_background_mode): Now static.
1230 * dispextern.h (Qframe_set_background_mode): Remove decl.
1231
0a0d27fb
PE
1232 * process.c (Fnetwork_interface_info): Declare local only if needed.
1233
377538cb
JD
12342011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1235
1236 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1237 (Fnetwork_interface_list): Allocate in increments of bytes instead
1238 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1239 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1240 sockaddr.
1241 (struct ifflag_def): notrailers is smart on OSX.
1242 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1243 Get hardware address with getifaddrs if available.
1244
08fff70c
EZ
12452011-08-12 Eli Zaretskii <eliz@gnu.org>
1246
1247 * xdisp.c (iterate_out_of_display_property): xassert that
1248 IT->position is set to within IT->object's boundaries. Break from
1249 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1250 when IT->position is set up wrongly due to some bug.
1251 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1252 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1253 entry. Force push_it to save on the stack the current
1254 buffer/string position, to be restored by pop_it. Fix flags in
1255 the iterator structure wrt the object coming from a display
1256 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1257 properties. (Bug#9284)
1258
7be1c708 12592011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1260
7be1c708
CY
1261 * fontset.c (fontset_get_font_group): Add proper type checks.
1262 (Bug#9172)
aac0c6e3 1263
7be1c708 12642011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1265
7be1c708
CY
1266 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1267 and LC_VERSION_MIN_MACOSX.
1268 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1269 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1270
97bb72a6
EZ
12712011-08-08 Eli Zaretskii <eliz@gnu.org>
1272
1273 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1274 no-display-properties-and-no-overlays under bidi display.
1275 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1276 properties and overlays.
97bb72a6 1277
d5617611
CY
12782011-08-08 Chong Yidong <cyd@stupidchicken.com>
1279
37e11a63
CY
1280 * editfns.c (Fset_time_zone_rule): Document relationship with the
1281 setenv function.
1282
d5617611
CY
1283 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1284 the font entity extracted from the cache (Bug#8109).
1285
58872834
CY
12862011-08-07 Chong Yidong <cyd@stupidchicken.com>
1287
1288 * composite.c (autocmp_chars): Don't reset point. That is done by
1289 restore_point_unwind (Bug#5984).
1290
75bfc667
JL
12912011-08-07 Juri Linkov <juri@jurta.org>
1292
1293 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1294 to show the arg `TIME' instead of `TIMEVAL'.
1295
d1410150
EZ
12962011-08-06 Eli Zaretskii <eliz@gnu.org>
1297
1298 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1299 display property strides EOL and includes a newline, as in
1300 longlines-mode. (Bug#9254)
75b771e4
EZ
1301 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1302 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1303
1304 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1305 is non-zero, even if the data buffer is NULL. Fixes a crash in
1306 vertical-motion with longlines-mode. (Bug#9254)
1307
35928349
EZ
13082011-08-05 Eli Zaretskii <eliz@gnu.org>
1309
ec7cc85b
EZ
1310 * bidi.c <bidi_cache_total_alloc>: Now static.
1311 (bidi_initialize): Initialize bidi_cache_total_alloc.
1312
8b76d6f8 1313 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1314 cache. (Bug#9221)
1315
1316 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1317 amount allocated this far in `bidi_cache_total_alloc'.
1318 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1319 non-zero, only free the data buffer without restoring the cache
1320 contents. All callers changed.
1321
1322 * dispextern.h (bidi_unshelve_cache): Update prototype.
1323
1324 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1325 (move_it_in_display_line, move_it_to)
1326 (move_it_vertically_backward, move_it_by_lines): Replace the call
1327 to xfree to an equivalent call to bidi_unshelve_cache.
1328 (move_it_in_display_line_to): Fix logic of returning
412b6358 1329 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1330
e2e2423b
EZ
13312011-08-05 Eli Zaretskii <eliz@gnu.org>
1332
1333 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1334 came from a string character with a `cursor' property. (Bug#9229)
1335
ae9e757a
JD
13362011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1337
1338 * Makefile.in (LIB_PTHREAD): New variable.
1339 (LIBES): Add LIB_PTHREAD (Bug#9216).
1340
1341 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1342 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1343
213bd7f2
AS
13442011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1345
1346 * regex.c (re_iswctype): Remove some redundant boolean
1347 conversions.
1348
99aaf75f
JD
13492011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1350
1351 * xterm.c (x_find_topmost_parent): New function.
1352 (x_set_frame_alpha): Find topmost parent window with
1353 x_find_topmost_parent and set the property there also (bug#9181).
1354 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1355
c74e9d86
PE
13562011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1357
1358 * callproc.c (Fcall_process): Avoid vfork clobbering
1359 the local vars buffer, coding_systems, current_dir.
1360
640c8776
SM
13612011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1362
1363 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1364
f26d0e4c
PE
13652011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1366
8a10d76c
PE
1367 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1368 so that it is not optimized away.
1369
f26d0e4c
PE
1370 * xdisp.c (compute_display_string_pos): Remove unused local.
1371
55439c61
EZ
13722011-08-02 Eli Zaretskii <eliz@gnu.org>
1373
1374 Fix slow cursor motion and scrolling in large buffers with
1375 selective display, like Org Mode buffers. (Bug#9218)
1376
1377 * dispextern.h (struct bidi_it): New member disp_prop_p.
1378
1379 * xdisp.c: Remove one-slot cache of display string positions.
1380 (compute_display_string_pos): Accept an additional argument
5e617bc2 1381 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1382 for a display string or property. If found, set DISP_PROP_P
1383 non-zero.
1384
1385 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1386 DISP_PROP_P, and pass it to compute_display_string_pos.
1387 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1388 non-zero. All callers of bidi_fetch_char changed.
1389
fb33fa43
SM
13902011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1391
1392 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1393
b099e063
DM
13942010-12-03 Don March <don@ohspite.net>
1395
1396 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1397 last character M-[char] is translated to ESC [char] (bug#7541).
1398
5cc7f7af
KH
13992011-08-02 Kenichi Handa <handa@m17n.org>
1400
d0fffa3f 1401 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1402
1403 * chartab.c (uniprop_table): Make it non-static.
1404
525d5e6e
EZ
14052011-08-01 Eli Zaretskii <eliz@gnu.org>
1406
1407 * xdisp.c (forward_to_next_line_start): Accept additional argument
1408 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1409 on the newline.
1410 (reseat_at_next_visible_line_start): Use the bidi iterator state
1411 returned by forward_to_next_line_start to restore the state of
1412 it->bidi_it after backing up to previous newline. (Bug#9212)
1413
31011111
AS
14142011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1415
1416 * regex.c (re_comp): Protoize.
1417 (re_exec): Fix return type.
1418 (regexec): Fix type of `ret'. (Bug#9203)
1419
476371c4
PE
14202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1421
e5d76069
PE
1422 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1423 This is needed if max-image-size is a floating-point number.
1424
9a79b20c
AS
14252011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1426
1427 * print.c (print_object): Print empty symbol as ##.
1428
1429 * lread.c (read1): Read ## as empty symbol.
1430
d8c2fa78
AA
14312011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1432
1433 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1434 setting frame foreground color (Bug#9175).
1435 (x_set_background_color): Likewise.
1436
ffe57a7a
AA
1437 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1438 contents (Bug#9176).
1439 (EmacsTooltip -init): Remove bezels and add shadows to
1440 tooltip windows.
1441
bf3492a5
AA
1442 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1443 or scroll bar (Bug#8470).
1444
d55e9c53
AA
1445 * nsfont.m (nsfont_open): Remove assignment to voffset and
1446 unnecessary vars hshink, expand, hd, full_height, min_height.
1447 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1448
1449 * nsterm.h (nsfont_info): Remove voffset field.
1450
d8c2fa78 14512011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1452
1453 Implement strike-through and overline on NextStep (Bug#8863).
1454
1455 * nsfont.m (nsfont_open): Use underline position provided by font,
1456 instead of hard-coded value of 2.
1457 (nsfont_draw): Call ns_draw_text_decoration instead.
1458
1459 * nsterm.h: Add declaration for ns_draw_text_decoration.
1460
1461 * nsterm.m (ns_draw_text_decoration): New function for drawing
1462 underline, overline, and strike-through.
1463 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1464 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1465 accommodate underlining, etc.
4843aac3 1466
4cc60b9b
EZ
14672011-07-28 Eli Zaretskii <eliz@gnu.org>
1468
bc7ece87
EZ
1469 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1470 default.
4cc60b9b 1471
476371c4
PE
14722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1473
66606eea
PE
1474 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1475 Without this fix, if a signal arrives just after memory fills up,
1476 'malloc' might be invoked reentrantly.
1477
476371c4
PE
1478 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1479 In other words, assume that every image size is allowed, on non-X
1480 hosts. This assumption is probably wrong, but it lets Emacs compile.
1481
f3fcc40d
AS
14822011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1483
1484 * regex.c (re_iswctype): Convert return values to boolean.
1485
350c992f
EZ
14862011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1487
1488 * xdisp.c (compute_display_string_pos): Don't use cached display
1489 string position if the buffer had its restriction changed.
1490 (Bug#9184)
1491
5266b4bb
PE
14922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1493
1494 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1495
2573a837 14962011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1497
41f55ccd 1498 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1499
39e378da
PE
1500 * bidi.c: Integer size and overflow fixes.
1501 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1502 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1503 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1504 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1505 (bidi_find_other_level_edge):
1506 Use ptrdiff_t instead of EMACS_INT where either will do.
1507 This works better on 32-bit hosts configured --with-wide-int.
1508 (bidi_cache_ensure_space): Check for size-calculation overflow.
1509 Use % rather than repeated addition, for better worst-case speed.
1510 Don't set bidi_cache_size until after xrealloc returns, because it
1511 might not return.
1512 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1513 (bidi_cache_ensure_space): Also check that the bidi cache size
1514 does not exceed that of the largest Lisp string or buffer. See Eli
1515 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1516
5e927815
PE
1517 * alloc.c (__malloc_size_t): Remove.
1518 All uses replaced by size_t. See Andreas Schwab's note
1519 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1520
ca4aa935
PE
1521 * image.c: Improve checking for integer overflow.
1522 (check_image_size): Assume that f is nonnull, since
1523 it is always nonnull in practice. This is one less thing to
1524 worry about when checking for integer overflow later.
1525 (x_check_image_size): New function, which checks for integer
1526 overflow issues inside X.
1527 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1528 This removes the need for a memory_full check.
1529 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1530 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1531 (xbm_read_bitmap_data): Change locals back to 'int', since
1532 their values must fit in 'int'.
1533 (xpm_load_image, png_load, tiff_load):
1534 Invoke x_create_x_image_and_pixmap earlier,
1535 to avoid much needless work if the image is too large.
1536 (tiff_load): Treat overly large images as if
1537 x_create_x_image_and_pixmap failed, not as malloc failures.
1538 (gs_load): Use x_check_image_size.
1539
5f8f9cc2
PE
1540 * gtkutil.c: Omit integer casts.
1541 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1542 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1543
5adf60bc
PE
1544 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1545
c8907a93
PE
1546 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1547 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1548 would wrongly return t on a 64-bit host.
1549
e3c25c68
PE
1550 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1551 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1552 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1553 and therefore cause GCC to emit a bogus diagnostic in some cases.
1554
3f791afe
PE
1555 * image.c: Integer signedness and overflow and related fixes.
1556 This is not an exhaustive set of fixes, but it's time to
1557 record what I've got.
1558 (lookup_pixel_color, check_image_size): Remove redundant decls.
1559 (check_image_size): Don't assume that arbitrary EMACS_INT values
1560 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1561 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1562 (tiff_load, imagemagick_load_image):
1563 Check for overflow in size calculations.
1564 (x_create_x_image_and_pixmap): Remove unnecessary test for
1565 xmalloc returning NULL; that can't happen.
1566 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1567 (xpm_color_bucket): Use better integer hashing function.
1568 (xpm_cache_color): Don't possibly over-allocate memory.
1569 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1570 (gif_memory_source):
1571 Use ptrdiff_t, not int or size_t, to record sizes.
1572 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1573 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1574 either works, as we prefer signed integers.
1575 (tiff_read_from_memory, tiff_write_from_memory):
1576 Return tsize_t, not size_t, since that's what the TIFF API wants.
1577 (tiff_read_from_memory): Don't fail simply because the read would
1578 go past EOF; instead, return a short read.
1579 (tiff_load): Omit no-longer-needed casts.
1580 (Fimagemagick_types): Don't assume size fits into 'int'.
1581
3cc5a532
PE
1582 Improve hashing quality when configured --with-wide-int.
1583 * fns.c (hash_string): New function, taken from sxhash_string.
1584 Do not discard information about ASCII character case; this
1585 discarding is no longer needed.
1586 (sxhash-string): Use it. Change sig to match it. Caller changed.
1587 * lisp.h: Declare it.
1588 * lread.c (hash_string): Remove, since we now use fns.c's version.
1589 The fns.c version returns a wider integer if --with-wide-int is
1590 specified, so this should help the quality of the hashing a bit.
1591
b312a492
PE
1592 * emacs.c: Integer overflow minor fix.
1593 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1594 Define only if GNU_LINUX.
1595 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1596
dfd153ae
PE
1597 * dispnew.c: Integer signedness and overflow fixes.
1598 Remove unnecessary forward decls, that were a maintenance hassle.
1599 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1600 All uses changed.
1601 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1602 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1603 (prepare_desired_row, line_draw_cost):
1604 Use int, not unsigned, where either works.
1605 (save_current_matrix, restore_current_matrix):
1606 Use ptrdiff_t, not size_t, where either works.
1607 (init_display): Check for overflow more accurately, and without
1608 relying on undefined behavior.
1609
a81d11a3
PE
1610 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1611 Remove, replacing with the new symbols in lisp.h. All uses changed.
1612 * fileio.c (make_temp_name):
1613 * filelock.c (lock_file_1, lock_file):
1614 * xdisp.c (message_dolog):
1615 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1616 Use pMd etc. instead.
1617 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1618 replacing the pWIDE etc. symbols removed from editfns.c.
1619
3300e6fd
PE
1620 * keyboard.h (num_input_events): Now uintmax_t.
1621 This is (very slightly) less likely to mess up due to wraparound.
1622 All uses changed.
1623
fd05c7e9
PE
1624 * buffer.c: Integer signedness fixes.
1625 (alloc_buffer_text, enlarge_buffer_text):
1626 Use ptrdiff_t rather than size_t when either will do, as we prefer
1627 signed integers.
1628
903fe15d
PE
1629 * alloc.c: Integer signedness and overflow fixes.
1630 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1631 (__malloc_size_t): Default to size_t, not to int.
1632 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1633 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1634 Prefer ptrdiff_t to size_t when either would do, as we prefer
1635 signed integers.
1636 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1637 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1638 Now const. Initialize with values that are in range even if char
1639 is signed.
1640 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1641 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1642 These functions do the right thing with sizes > 2**32.
1643 (check_depth): Now ptrdiff_t, not int.
1644 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1645 Adjust to new way of storing sizes. Check for size overflow bugs
1646 in rest of code.
1647 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1648 slightly wrong anyway, as it missed one instance of
1649 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1650 (refill_memory_reserve): Omit needless cast to size_t.
1651 (mark_object_loop_halt): Mark as externally visible.
1652
ac82cc6a
PE
1653 * xselect.c: Integer signedness and overflow fixes.
1654 (Fx_register_dnd_atom, x_handle_dnd_message):
1655 Use ptrdiff_t, not size_t, since we prefer signed.
1656 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1657 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1658 x_dnd_atoms_size and x_dnd_atoms_length.
1659
c2d1e36d
PE
1660 * doprnt.c: Prefer signed to unsigned when either works.
1661 * eval.c (verror):
1662 * doprnt.c (doprnt):
1663 * lisp.h (doprnt):
1664 * xdisp.c (vmessage):
1665 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1666 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1667 prefer signed arithmetic to avoid comparison confusion.
1668 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1669 but is a bit tricky.
1670
0e926e56
PE
1671 Assume freestanding C89 headers, string.h, stdlib.h.
1672 * data.c, doprnt.c, floatfns.c, print.c:
1673 Include float.h unconditionally.
1674 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1675 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1676 * regex.c: Likewise for stddef.h, string.h.
1677 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1678 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1679 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1680 (STDC_HEADERS): Remove obsolete defines.
1681 * sysdep.c: Include limits.h unconditionally.
1682
9cfdb3ec
PE
1683 Assume support for memcmp, memcpy, memmove, memset.
1684 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1685 * regex.c (memcmp, memcpy):
1686 Remove; we assume C89 now.
1687
1688 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1689 (__malloc_safe_bcopy): Remove; no longer needed.
1690
cf950e6b 1691 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1692 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1693 well either way, and we prefer signed to unsigned.
1694
dbf38e02
LMI
16952011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1696
1697 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1698 closes the connection while we're reading (bug#9182).
1699
d6f0886c 17002011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1701
d6f0886c
JD
1702 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1703 are specified (Bug#9168).
24e0f6b1 1704
2eb1f9e6
PE
17052011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1706
1707 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1708 Found by GCC static checking and --with-wide-int on a 32-bit host.
1709
22381272 17102011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1711
1712 * xdisp.c (compute_display_string_pos): Fix logic of caching
1713 previous display string position. Initialize cached_prev_pos to
1714 -1. Fixes slow-down at the beginning of a buffer.
1715
f25e39b4
EZ
17162011-07-24 Eli Zaretskii <eliz@gnu.org>
1717
1718 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1719 for attrs[LFACE_FONTSET_INDEX].
1720
04c4b52e
PE
17212011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1722
1723 * xml.c (parse_region): Remove unused local
1724 that was recently introduced.
1725
c1734fbd
EZ
17262011-07-23 Eli Zaretskii <eliz@gnu.org>
1727
be18c5a5
EZ
1728 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1729 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1730
c1734fbd
EZ
1731 * xdisp.c (move_it_in_display_line_to): Record the best matching
1732 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1733 exit if none of the characters scanned was an exact match.
1734 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1735 when exact match is impossible due to invisible text, and the
1736 lines are truncated.
1737
a258d627
JD
17382011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1739
1740 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1741 for OSX >= 10.7.
1742
b6d5a689
EZ
17432011-07-22 Eli Zaretskii <eliz@gnu.org>
1744
0f74f785
EZ
1745 Fix a significant slow-down of cursor motion with C-n, C-p,
1746 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1747 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1748 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1749 (next_element_from_buffer): Call compute_stop_pos_backwards to
1750 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1751 base_level_stop.
1752 (reseat): Don't look for prev_stop, as that could mean a very long
1753 run.
1754 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1755 <cached_disp_overlay_modiff>: Cache for last found display string
1756 position.
551918c1 1757 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1758 about the same buffer in the same area of character positions, and
1759 the buffer wasn't changed since the time the display string
1760 position was cached.
551918c1 1761
b2d0c91a
EZ
17622011-07-22 Eli Zaretskii <eliz@gnu.org>
1763
1764 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1765 is an integer, which is important for empty lines. (Bug#9149)
1766
043604ee
CY
17672011-07-22 Chong Yidong <cyd@stupidchicken.com>
1768
1769 * frame.c (Fmodify_frame_parameters): In tty case, update the
1770 default face if necessary (Bug#4238).
1771
da4adb04
CY
17722011-07-21 Chong Yidong <cyd@stupidchicken.com>
1773
1774 * editfns.c (Fstring_to_char): No need to explain what a character
1775 is in the docstring (Bug#6576).
1776
9abd0532
LMI
17772011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1778
1779 * xml.c (parse_region): Make sure we always return a tree.
1780
36881d16
HK
17812011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1782
1783 * xml.c (parse_region): If a document contains only comments,
1784 return that, too.
1785
1e98674d
LMI
17862011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1787
1788 * xml.c (make_dom): Return comments, too.
1789
590bd467
PE
17902011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1791
1792 Port to OpenBSD.
1793 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1794 and the surrounding thread.
1795 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1796 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1797 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1798 timer goes off.
1799 * s/openbsd.h (BROKEN_SIGIO): Define.
1800 * unexelf.c (unexec) [__OpenBSD__]:
1801 Don't update the .mdebug section of the Alpha COFF symbol table.
1802
f41628b2
LMI
18032011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1804
1805 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1806 (bug#8460).
1807
b59b67c5
PE
18082011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1809
15e3a074
PE
1810 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1811 This fixes some race conditions on the permissions of any newly
1812 created file.
1813
41bed37d
PE
1814 * alloc.c (valid_pointer_p): Use pipe, not open.
1815 This fixes some permissions issues when debugging.
1816
b59b67c5
PE
1817 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1818 If fchown fails to set both uid and gid, try to set just gid,
1819 as that is sometimes allowed. Adjust the file's mode to eliminate
1820 setuid or setgid bits that are inappropriate if fchown fails.
1821
925a6be7
SM
18222011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1823
1824 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1825 to compare Lisp_Objects.
1826 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1827 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1828 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1829
52968808
AS
18302011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1831
0a6a104b
AS
1832 * lread.c (read_integer): Unread even EOF character.
1833 (read1): Likewise. Properly record start position of symbol.
1834
52968808
AS
1835 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1836 symbol character follows.
1837
9e381cdd
PE
18382011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1839
1840 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1841 This works around a problem with the previous change to Fcopy_file.
1842 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1843 and without this change, GCC might complain about discarding
1844 fchown's return value.
1845
b5641435
JB
18462011-07-16 Juanma Barranquero <lekktu@gmail.com>
1847
1848 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1849
a8031457
PE
18502011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1851
1852 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1853
dd889327
LMI
18542011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1855
750c33f7
LMI
1856 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1857 it's used from the C level.
1858
dd889327
LMI
1859 * process.c: Use the same condition for POLL_FOR_INPUT in both
1860 keyboard.c and process.c (bug#1858).
1861
87e86684
LM
18622011-07-09 Lawrence Mitchell <wence@gmx.li>
1863
1864 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1865 (Fgnutls_boot): Use it.
1866
64348f40
AS
18672011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1868
1869 * doc.c (Fsubstitute_command_keys): Revert last change.
1870
1d698799
LMI
18712011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1872
f863868c
LMI
1873 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1874 quotes the next character, and doesn't affect other longer
1875 sequences (bug#8935).
1876
1d698799
LMI
1877 * lread.c (syms_of_lread): Clarify that is isn't only
1878 `eval-buffer' and `eval-defun' that's affected by
1879 `lexical-binding' (bug#8460).
1880
aa4b6df6
EZ
18812011-07-15 Eli Zaretskii <eliz@gnu.org>
1882
1883 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1884 bidi redisplay when a line includes both an image and is
1885 truncated.
1886
5d856da6
PE
18872011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1888
ad6042bb
PE
1889 Fix minor problems found by static checking.
1890 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1891 (elsz): Now a signed constant, not a size_t var. We prefer signed
1892 types to unsigned, to avoid integer comparison confusion. Without
1893 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1894 "cannot optimize loop, the loop counter may overflow", a symptom
1895 of the confusion.
f00bbb22 1896 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1897 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1898
6468f31c
LMI
18992011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1900
49080b10
LMI
1901 * search.c (Fre_search_backward): Mention `case-fold-search' in
1902 all the re_search_* functions (bug#8138).
1903
6468f31c
LMI
1904 * keyboard.c (Fopen_dribble_file): Document when the file is
1905 closed (bug#8056).
1906
c965adc5
EZ
19072011-07-14 Eli Zaretskii <eliz@gnu.org>
1908
df9733bf
EZ
1909 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1910 bidi_cache_idx.
1911
0bb23927
EZ
1912 Support bidi reordering of display and overlay strings.
1913 * xdisp.c (compute_display_string_pos)
1914 (compute_display_string_end): Accept additional argument STRING.
1915 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1916 (reseat_to_string): Initialize bidi_it->string.s and
1917 bidi_it->string.schars.
1918 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1919 NULL (avoids a crash in bidi_paragraph_init).
1920 Initialize itb.string.lstring.
0bb23927
EZ
1921 (init_iterator): Call bidi_init_it only of a valid
1922 buffer position was specified. Initialize paragraph_embedding to
1923 L2R.
1924 (reseat_to_string): Initialize the bidi iterator.
1925 (display_string): If we need to ignore text properties of
1926 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1927 original value of -1 will not work with bidi.)
1928 (compute_display_string_pos): First arg is now struct
1929 `text_pos *'; all callers changed. Support display properties on
1930 Lisp strings.
1931 (compute_display_string_end): Support display properties on Lisp
1932 strings.
1933 (init_iterator, reseat_1, reseat_to_string): Initialize the
1934 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1935 when iterating on a string not from display properties).
640c8776
SM
1936 (compute_display_string_pos, compute_display_string_end):
1937 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1938 arrow keys.
1939 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1940 base_level_stop; instead, set base_level_stop to BEGV.
1941 Fixes crashes in vertical-motion.
0bb23927
EZ
1942 (next_element_from_buffer): Improve commentary for when
1943 the iterator is before prev_stop.
1944 (init_iterator): Initialize bidi_p from the default value of
1945 bidi-display-reordering, not from buffer-local value. Use the
1946 buffer-local value only if initializing for buffer iteration.
1947 (handle_invisible_prop): Support invisible properties on strings
1948 that are being bidi-reordered.
1949 (set_iterator_to_next): Support bidi reordering of C strings and
1950 Lisp strings.
1951 (next_element_from_string): Support bidi reordering of Lisp
1952 strings.
1953 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1954 (display_string): Support display of R2L glyph rows.
1955 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1956 (init_iterator): Don't initialize it->bidi_p for strings
1957 here.
1958 (reseat_to_string): Initialize it->bidi_p for strings here.
1959 (next_element_from_string, next_element_from_c_string)
1960 (next_element_from_buffer): Add xassert's for correspondence
1961 between IT's object being iterated and it->bidi_it.string
1962 structure.
1963 (face_before_or_after_it_pos): Support bidi iteration.
1964 (next_element_from_c_string): Handle the case of the first string
1965 character that is not the first one in the visual order.
1966 (get_visually_first_element): New function, refactored from common
1967 parts of next_element_from_buffer, next_element_from_string, and
1968 next_element_from_c_string.
1969 (tool_bar_lines_needed, redisplay_tool_bar)
1970 (display_menu_bar): Force left-to-right direction. Add a FIXME
1971 comment for making that be controlled by a user option.
1972 (push_it, pop_it): Save and restore the state of the
1973 bidi iterator. Save and restore the bidi_p flag.
1974 (pop_it): Iterate out of display property for string iteration as
1975 well.
1976 (iterate_out_of_display_property): Support iteration over strings.
1977 (handle_single_display_spec): Set up it->bidi_it for iteration
1978 over a display string, and call bidi_init_it.
1979 (handle_single_display_spec, next_overlay_string)
1980 (get_overlay_strings_1, push_display_prop): Set up the bidi
1981 iterator for displaying display or overlay strings.
1982 (forward_to_next_line_start): Don't use the shortcut if
1983 bidi-iterating.
1984 (back_to_previous_visible_line_start): If handle_display_prop
1985 pushed the iterator stack, restore the internal state of the bidi
1986 iterator by calling bidi_pop_it same number of times.
1987 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1988 and we are bidi-iterating, don't decrement the iterator position;
1989 instead, set the first_elt flag in the bidi iterator, to produce
1990 the same effect.
1991 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1992 (push_display_prop): xassert that we are iterating a buffer.
1993 (push_it, pop_it): Save and restore paragraph_embedding member.
1994 (handle_single_display_spec, next_overlay_string)
1995 (get_overlay_strings_1, reseat_1, reseat_to_string)
1996 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1997 correctly. Don't assume unibyte strings are not bidi-reordered.
1998 (compute_display_string_pos)
1999 (compute_display_string_end): Fix handling the case of C string.
2000 (push_it, pop_it): Save and restore from_disp_prop_p.
2001 (handle_single_display_spec, push_display_prop): Set the
2002 from_disp_prop_p flag.
2003 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2004 (pop_it): Call iterate_out_of_display_property only if we are
2005 popping after iteration over a string that came from a display
2006 property. Fix a typo in popping stretch info. Add an assertion
2007 for verifying that the iterator position is in sync with the bidi
2008 iterator.
2009 (handle_single_display_spec, get_overlay_strings_1)
2010 (push_display_prop): Fix initialization of paragraph direction for
2011 string when that of the parent object is not yet determined.
2012 (reseat_1): Call bidi_init_it to resync the bidi
2013 iterator with IT's position. (Bug#7616)
2014 (find_row_edges): If ROW->start.pos gives position
2015 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2016 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2017 Reset the from_disp_prop_p flag.
2018 (SAVE_IT, RESTORE_IT): New macros.
2019 (pos_visible_p, face_before_or_after_it_pos)
2020 (back_to_previous_visible_line_start)
2021 (move_it_in_display_line_to, move_it_in_display_line)
2022 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2023 (try_scrolling, redisplay_window, display_line): Use them when
2024 saving a temporary copy of the iterator and restoring it back.
2025 (back_to_previous_visible_line_start, reseat_1)
2026 (init_iterator): Empty the bidi cache "stack".
2027 (move_it_in_display_line_to): If iterator ended up at
2028 EOL, but we never saw any buffer positions smaller than
2029 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2030 motion in bidi-reordered lines.
2031 (move_it_in_display_line_to): Record prev_method and prev_pos
2032 immediately before the call to set_iterator_to_next. Fixes cursor
2033 motion in bidi-reordered lines with stretch glyphs and strings
2034 displayed in margins. (Bug#8133) (Bug#8867)
2035 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2036 TO_CHARPOS.
640c8776
SM
2037 (pos_visible_p): Support positions in bidi-reordered lines.
2038 Save and restore bidi cache.
0bb23927
EZ
2039
2040 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2041 (bidi_paragraph_info): Delete unused struct.
2042 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2043 (bidi_cache_start): New variable.
2044 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2045 to zero.
2046 (bidi_cache_fetch_state, bidi_cache_search)
2047 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2048 (bidi_cache_find, bidi_peek_at_next_level)
2049 (bidi_level_of_next_char, bidi_find_other_level_edge)
2050 (bidi_move_to_visually_next): Compare cache index with
2051 bidi_cache_start rather than with zero.
2052 (bidi_fetch_char): Accept new argument STRING; all callers
2053 changed. Support iteration over a string. Support strings with
2054 display properties. Support unibyte strings. Fix the type of
2055 `len' according to what STRING_CHAR_AND_LENGTH expects.
2056 (bidi_paragraph_init, bidi_resolve_explicit_1)
2057 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
2058 (bidi_level_of_next_char, bidi_move_to_visually_next):
2059 Support iteration over a string.
0bb23927
EZ
2060 (bidi_set_sor_type, bidi_resolve_explicit_1)
2061 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2062 can now be zero (for strings); special values 0 and -1 were
2063 changed to -1 and -2, respectively.
2064 (bidi_char_at_pos): New function.
2065 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2066 Call it instead of FETCH_MULTIBYTE_CHAR.
2067 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2068 initialized to valid values.
2069 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2070 values.
2071 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2072 the test for valid cached positions. Fix the logic for looking up
2073 the sentinel state in the cache. GCPRO the Lisp string we are
2074 iterating.
2075 (bidi_push_it, bidi_pop_it): New functions.
2076 (bidi_initialize): Initialize the bidi cache start stack pointer.
2077 (bidi_cache_ensure_space): New function, refactored from part of
2078 bidi_cache_iterator_state. Don't assume the required size is just
2079 one BIDI_CACHE_CHUNK away.
2080 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2081 (bidi_count_bytes, bidi_char_at_pos): New functions.
2082 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2083 always valid if bidi_cache_idx is valid.
2084 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2085 is valid if it's going to be used.
2086 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2087 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
2088 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2089 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
2090 (bidi_find_other_level_edge, bidi_cache_start_stack):
2091 All variables related to cache indices are now EMACS_INT.
c965adc5 2092
0bb23927
EZ
2093 * dispextern.h (struct bidi_string_data): New structure.
2094 (struct bidi_it): New member `string'. Make flag members be 1-bit
2095 fields, and put them last in the struct.
640c8776
SM
2096 (compute_display_string_pos, compute_display_string_end):
2097 Update prototypes.
0bb23927
EZ
2098 (bidi_push_it, bidi_pop_it): Add prototypes.
2099 (struct iterator_stack_entry): New members bidi_p,
2100 paragraph_embedding, and from_disp_prop_p.
2101 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
2102 (bidi_shelve_cache, bidi_unshelve_cache):
2103 Declare prototypes.
0bb23927
EZ
2104
2105 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2106 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2107 and vector-like objects.
2108
2109 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2110 cache around display iteration.
2111
2112 * window.c (Fwindow_end, window_scroll_pixel_based)
2113 (displayed_window_lines, Frecenter): Save and restore the bidi
2114 cache around display iteration.
2115
3bbd2265
LMI
21162011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2117
2118 * editfns.c (Fdelete_region): Clarify the use of the named
2119 parameters (bug#6788).
2120
adc47434
MR
21212011-07-14 Martin Rudalics <rudalics@gmx.at>
2122
2123 * indent.c (Fvertical_motion): Set and restore w->pointm when
2124 saving and restoring the window's buffer (Bug#9006).
2125
837c31f8
LMI
21262011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2127
2128 * editfns.c (Fstring_to_char): Clarify just what is returned
2129 (bug#6576). Text by Eli Zaretskii.
2130
ac389d0c
JB
21312011-07-13 Juanma Barranquero <lekktu@gmail.com>
2132
2133 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2134
0be0ce47
EZ
21352011-07-13 Eli Zaretskii <eliz@gnu.org>
2136
2137 * buffer.c (mmap_find): Fix a typo.
2138
cd18e7e3
JB
21392011-07-13 Johan Bockgård <bojohan@gnu.org>
2140
2141 Fix execution of x selection hooks.
2142 * xselect.c (Qx_lost_selection_functions)
2143 (Qx_sent_selection_functions): New vars.
2144 (syms_of_xselect): DEFSYM them.
2145 (x_handle_selection_request): Pass Qx_sent_selection_functions
2146 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2147 (x_handle_selection_clear,x_clear_frame_selections):
2148 Pass Qx_lost_selection_functions rather than
2149 Vx_lost_selection_functions to Frun_hook_with_args.
2150
47ea7f44
PE
21512011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2152
ac389d0c 2153 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
2154 The old code sometimes used this field without initializing it.
2155
47ea7f44
PE
2156 * alloc.c (gc_sweep): Don't read past end of array.
2157 In theory, the old code could also have corrupted Emacs internals,
2158 though it'd be very unlikely.
2159
bc985c87
AS
21602011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2161
2162 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2163 argument. (Bug#4026)
bc985c87 2164
0cf34688
LMI
21652011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2166
b3dadd76
LMI
2167 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2168 key" (bug#4257).
2169
0cf34688
LMI
2170 * window.c (Fset_window_start): Doc fix (bug#4199).
2171 (Fset_window_hscroll): Ditto.
2172
270768cd
PE
21732011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2174
077e3dda 2175 Fix minor new problems caught by GCC 4.6.1.
270768cd 2176 * term.c (init_tty): Remove unused local.
490011a6 2177 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2178 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2179 not used otherwise.
270768cd 2180
b1f58454
CY
21812011-07-12 Chong Yidong <cyd@stupidchicken.com>
2182
2183 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2184
22b9578d
LMI
21852011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2186
6e70ab07
LMI
2187 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2188 are the mini-buffer and the echo area (bug#3320).
2189
22b9578d
LMI
2190 * term.c (init_tty): Remove support for supdup, c10 and perq
2191 terminals, which are no longer supported (bug#1482).
2192
8974cc9f
JB
21932011-07-10 Johan Bockgård <bojohan@gnu.org>
2194
2195 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2196
a560d974
JD
21972011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2198
2199 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2200 for non-popups (Bug#3642).
2201
1dae0f0a
AS
22022011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2203
268c2c36 2204 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2205 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2206 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2207 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2208 * data.c (fmod): Likewise.
2209 * dispnew.c (swap_glyphs_in_rows): Likewise.
2210 * emacs.c (memory_warning_signal): Likewise.
2211 * floatfns.c (float_error): Likewise.
2212 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2213 (otf_open, font_otf_capability, generate_otf_features)
2214 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2215 Likewise.
2216 * image.c (pbm_read_file): Likewise.
2217 * indent.c (string_display_width): Likewise.
2218 * intervals.c (check_for_interval, search_for_interval)
2219 (inc_interval_count, count_intervals, root_interval)
2220 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2221 * lread.c (defalias): Likewise.
268c2c36 2222 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2223 * regex.c (set_image_of_range_1, set_image_of_range)
2224 (regex_grow_registers): Likewise.
2225 * sysdep.c (strerror): Likewise.
2226 * termcap.c (valid_filename_p, tprint, main): Likewise.
2227 * tparam.c (main): Likewise.
2228 * unexhp9k800.c (run_time_remap, save_data_space)
2229 (update_file_ptrs, read_header, write_header, calculate_checksum)
2230 (copy_file, copy_rest, display_header): Likewise.
2231 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2232 Likewise.
2233 * xdisp.c (check_it): Likewise.
2234 * xfaces.c (register_color, unregister_color, unregister_colors):
2235 Likewise.
2236 * xfns.c (print_fontset_result): Likewise.
2237 * xrdb.c (member, fatal, main): Likewise.
2238
99033785
PE
22392011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2240
2241 Fix minor problems found by static checking (Bug#9031).
2242 * chartab.c (char_table_set_range, map_sub_char_table):
2243 Remove unused locals.
2244 (uniprop_table): Now static.
2245 * composite.c (_work_char): Remove unused static var.
2246
9cb2ac56
JB
22472011-07-09 Juanma Barranquero <lekktu@gmail.com>
2248
2249 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2250
f25661f0
JD
22512011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2252
2253 * gtkutil.c (qttip_cb): Remove code without function.
2254
8278c4fe
EZ
22552011-07-09 Eli Zaretskii <eliz@gnu.org>
2256
2257 * w32.c (pthread_sigmask): New stub.
2258
1692ae2d 22592011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2260
8a6ebd58 2261 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2262 sigprocmask is portable only for single-threaded applications, and
2263 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2264 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2265 (LIBES): Use it.
2266 * callproc.c (Fcall_process):
2267 * process.c (create_process):
2268 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2269 Use pthread_sigmask, not sigprocmask.
123403e4 2270
1b854618
JD
22712011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2272
2273 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2274 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2275 wrong (Bug#8591).
2276
3fe4b549
JD
22772011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2278
0ce7e563
JD
2279 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2280 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2281 (xg_hide_tooltip): Fix comment.
2282
3fe4b549
JD
2283 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2284 in registerServicesMenuSendTypes.
2285 (validRequestorForSendType): Don't check ns_return_types.
2286
2287 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2288 ns_return_type.
2289
5df75e47
JR
22902011-07-08 Jason Rumney <jasonr@gnu.org>
2291
2292 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2293 frame struct members of non-existent frames (Bug#6284).
2294
699c10bd
JD
22952011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2296
4393663b
JD
2297 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2298 variable firstTime not needed on OSX >= 10.6.
2299 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2300 >= 10.5. Use setKnobProportion, setDoubleValue.
2301
2302 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2303 (MAC_OS_X_VERSION_10_5): Define if not defined.
2304 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2305 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2306 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2307
2308 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2309 cString and lossyCString on OSX >= 10.4
2310
2311 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2312 sizeToFit on OSX >= 10.2.
2313
2314 * nsimage.m (allocInitFromFile): Don't use deprecated method
2315 bestRepresentationForDevice on OSX >= 10.6.
2316
2317 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2318 to avoid warning.
2319
2320 * emacs.c: Declare unexec_init_emacs_zone.
2321
a63e0781
JD
2322 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2323
699c10bd
JD
2324 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2325
2326 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2327 on svcsMenu (Bug#8842).
2328
2329 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2330 ns_return_types.
2331 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2332
2333 * nsterm.m (QUTF8_STRING): Declare.
2334 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2335 (validRequestorForSendType): Return type is (id).
2336 Change indexOfObjectIdenticalTo to indexOfObject.
2337 Check if we have local selection before returning self (Bug#8842).
2338 (writeSelectionToPasteboard): Put local selection into paste board
2339 if we have a local selection (Bug#8842).
2340 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2341
2342 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2343 (ns_get_local_selection): Declare.
2344
54e10184
LMI
23452011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2346
9888ff71
LMI
2347 * keymap.c (describe_map_tree): Don't insert a double newline at
2348 the end of the buffer (bug#1169) and return whether we inserted
2349 something.
2350
54e10184
LMI
2351 * callint.c (Fcall_interactively): Change "reading args" to
2352 "providing args" to try to clarify what it does (bug#1010).
2353
15fa4783
KH
23542011-07-07 Kenichi Handa <handa@m17n.org>
2355
2356 * composite.c (composition_compute_stop_pos): Ignore a static
2357 composition starting before CHARPOS (Bug#8915).
2358
2359 * xdisp.c (handle_composition_prop): Likewise.
2360
a8815b00
EZ
23612011-07-07 Eli Zaretskii <eliz@gnu.org>
2362
2363 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2364 (Bug#9015)
2365
ef7b981d 23662011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2367
2368 * character.h (unicode_category_t): New enum type.
2369
2370 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2371 (Qchar_code_property_table): New variable.
2372 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2373 (UNIPROP_COMPRESSED_FORM_P): New macros.
2374 (char_table_ascii): Uncompress the compressed values.
2375 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2376 Uncompress the compressed values.
ac389d0c 2377 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2378 (char_table_ref_and_range): Uncompress the compressed values.
2379 (sub_char_table_set): New arg is_uniprop. Callers changed.
2380 Uncompress the compressed values.
2381 (sub_char_table_set_range): Args changed. Callers changed.
2382 (char_table_set_range): Adjuted for the above change.
2383 (map_sub_char_table): Delete args default_val and parent. Add arg
2384 top. Give decoded values to a Lisp function.
640c8776 2385 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2386 values to a Lisp function. Gcpro more variables.
2387 (uniprop_table_uncompress)
2388 (uniprop_decode_value_run_length): New functions.
2389 (uniprop_decoder, uniprop_decoder_count): New variables.
2390 (uniprop_get_decoder, uniprop_encode_value_character)
2391 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2392 New functions.
2393 (uniprop_encoder, uniprop_encoder_count): New variables.
2394 (uniprop_get_encoder, uniprop_table)
2395 (Funicode_property_table_internal, Fget_unicode_property_internal)
2396 (Fput_unicode_property_internal): New functions.
2397 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2398 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2399 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2400 char-code-property-alist.
2401
640c8776 2402 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2403 Vunicode_category_table.
2404
640c8776 2405 * font.c (font_range): Adjust for the change of
c805dec0
KH
2406 Vunicode_category_table.
2407
76b397fb
DN
24082011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2409
2410 * m/iris4d.h: Remove file, move contents ...
2411 * s/irix6-5.h: ... here.
2412
22b4128e
PE
24132011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2414
2415 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2416 * alloc.c (mark_buffer):
2417 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2418 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2419 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2420 This isn't true in general, and it's particularly not true
2421 if Emacs is configured with --with-wide-int.
2422 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2423 New macros, used in the buffer.c change.
2424
869795d6
JD
24252011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2426
2427 * xsettings.c: Use both GConf and GSettings if both are available.
2428 (store_config_changed_event): Add comment.
2429 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2430 (store_tool_bar_style_changed): New functions.
5e617bc2 2431 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2432 (struct xsettings): Move font inside HAVE_XFT.
2433 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2434 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2435 Move inside HAVE_XFT.
640c8776 2436 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2437 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2438 also.
2439 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2440 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2441 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2442 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2443 (parse_settings): Move check for font inside HAVE_XFT.
2444 (read_settings, apply_xft_settings): Add comment.
2445 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2446 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2447 call store_font_name_changed.
2448 (xft_settings_event): Add comment.
2449 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2450 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2451 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2452 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2453 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2454 (xsettings_get_system_font, xsettings_get_system_normal_font):
2455 Add comment.
869795d6 2456
d8ed26bd
PE
24572011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2458
2459 Random fixes. E.g., (random) never returned negative values.
2460 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2461 subseconds part to the entropy, as that's a bit more random.
2462 Prefer signed to unsigned, since the signedness doesn't matter and
2463 in general we prefer signed. When given a limit, use a
2464 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2465 latter isn't right if USE_2_TAGS_FOR_INTS.
2466 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2467 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2468
cabf1cac
SM
24692011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2470
2471 * textprop.c (text_property_stickiness):
2472 Obey Vtext_property_default_nonsticky.
2473 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2474 * w32fns.c (syms_of_w32fns):
2475 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2476
6e9b2be9
PE
24772011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2478
2479 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2480 This is more efficient than Ffile_directory_p and avoids a minor race.
2481
90186c68
LMI
24822011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2483
7c301272
LMI
2484 * buffer.c (Foverlay_put): Say what the return value is
2485 (bug#7835).
2486
c4f2d8d4
LMI
2487 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2488 is a directory before asking whether to use the file name
2489 (bug#7564).
ad637907
LMI
2490 (barf_or_query_if_file_exists): Make the "File is a directory"
2491 error be more correct.
c4f2d8d4 2492
90186c68
LMI
2493 * fns.c (Frequire): Remove the mention of the .gz files, since
2494 that's installation-specific, but keep the mention of
2495 `get-load-suffixes'.
2496
da64016e
PE
24972011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2498
2499 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2500 Report string overflow if the output is too long.
2501
7d47b580
JB
25022011-07-04 Juanma Barranquero <lekktu@gmail.com>
2503
a555cb87
JB
2504 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2505 (syms_of_gnutls): Remove duplicate DEFSYM for
2506 Qgnutls_bootprop_verify_hostname_error, an error for
2507 Qgnutls_bootprop_verify_error (which is no longer used).
2508
7d47b580
JB
2509 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2510 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2511 Also (re)move comments that are misplaced or no longer relevant.
2512
1e49bfab
LMI
25132011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2514
2515 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2516
1485f4c0
CY
25172011-07-03 Chong Yidong <cyd@stupidchicken.com>
2518
2519 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2520 and background color parameters if they have been changed.
2521
a9ab721e
LMI
25222011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2523
2524 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2525
cf7cff57
PE
25262011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2527
2e13213d
PE
2528 * xsettings.c (SYSTEM_FONT): Define only when used.
2529 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2530
cf7cff57
PE
2531 * keymap.c (access_keymap_1): Now static.
2532
7a8e04f7
CY
25332011-07-02 Chong Yidong <cyd@stupidchicken.com>
2534
2535 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2536 leave any prefix arg for the up event (Bug#1586).
2537
61352f62
LMI
25382011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2539
69bb1ef7
LMI
2540 * lread.c (syms_of_lread): Mention single symbols defined by
2541 `defvar' or `defconst' (bug#7154).
2542
61352f62 2543 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2544 (Frequire): Mention get-load-suffixes.
61352f62 2545
28545e04
MR
25462011-07-02 Martin Rudalics <rudalics@gmx.at>
2547
2548 * window.h (window): Remove clone_number slot.
2549 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2550 Remove.
2551 (make_parent_window, make_window, saved_window)
2552 (Fset_window_configuration, save_window_save): Don't deal with
2553 clone numbers.
2554 * buffer.c (Qclone_number): Remove declaration.
2555 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2556
3349e122
SM
25572011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2558
2559 Add multiple inheritance to keymaps.
2560 * keymap.c (Fmake_composed_keymap): New function.
2561 (Fset_keymap_parent): Simplify.
2562 (fix_submap_inheritance): Remove.
2563 (access_keymap_1): New function extracted from access_keymap to handle
2564 embedded parents and handle lists of maps.
2565 (access_keymap): Use it.
2566 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2567 (Fcopy_keymap): Handle embedded parents.
2568 (Fcommand_remapping, define_as_prefix): Simplify.
2569 (Fkey_binding): Simplify.
2570 (syms_of_keymap): Move minibuffer-local-completion-map,
2571 minibuffer-local-filename-completion-map,
2572 minibuffer-local-must-match-map, and
2573 minibuffer-local-filename-must-match-map to Elisp.
2574 (syms_of_keymap): Defsubr make-composed-keymap.
2575 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2576 (parse_menu_item): Trivial simplification.
2577
3279eb87
GM
25782011-07-01 Glenn Morris <rgm@gnu.org>
2579
2580 * Makefile.in (SETTINGS_LIBS): Fix typo.
2581
4550efdf
KI
25822011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2583
2584 * coding.c (Fencode_coding_string): Record the last coding system
2585 used, as the function doc string says (bug#8738).
2586
0949d2b6
JD
25872011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2588
2589 * xsettings.c (store_monospaced_changed): Take new font as arg and
2590 check for change against current_mono_font.
2591 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2592 (emacs_settings_constructor, emacs_settings_get_property)
2593 (emacs_settings_set_property, emacs_settings_class_init)
2594 (emacs_settings_init, gsettings_obj): Remove.
2595 (something_changedCB): New function for HAVE_GSETTINGS.
2596 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2597 with value as argument.
2598 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2599 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2600 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2601 "changed".
2602
2603 * xgselect.c: Add defined (HAVE_GSETTINGS).
2604 (xgselect_initialize): Ditto.
2605
2606 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2607 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2608 xg_select.
2609
bbc6b304
PE
26102011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2611
2612 * eval.c (struct backtrace): Simplify and port the data structure.
2613 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2614 signed bit field, as this assumption is not portable and it makes
2615 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2616 "char debug_on_exit : 1" as this is not portable either; instead,
2617 use the portable "unsigned int debug_on_exit : 1". Remove unused
2618 member evalargs. Remove obsolete comments about cc bombing out.
2619
9851bfc5
JD
26202011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2621
51bb811f 2622 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2623 Let HAVE_GSETTINGS override HAVE_GCONF.
2624 (store_monospaced_changed): New function.
2625 (EMACS_SETTINGS): A new type derived from GObject to handle
2626 GSettings notifications.
2627 (emacs_settings_constructor, emacs_settings_get_property)
2628 (emacs_settings_set_property, emacs_settings_class_init):
2629 New functions.
2630 (gsettings_client, gsettings_obj): New variables.
2631 (GSETTINGS_SCHEMA): New define.
2632 (something_changedCB): Call store_monospaced_changed.
2633 (init_gsettings): New function.
2634 (xsettings_initialize): Call init_gsettings.
2635 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2636 to NULL.
2637
640c8776 2638 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2639 GCONF_CFLAGS/LIBS.
2640
5386012d
MR
26412011-06-29 Martin Rudalics <rudalics@gmx.at>
2642
2643 * window.c (resize_root_window, grow_mini_window)
2644 (shrink_mini_window): Rename Qresize_root_window to
2645 Qwindow_resize_root_window and Qresize_root_window_vertically to
2646 Qwindow_resize_root_window_vertically.
2647
f13e0b08
PE
26482011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2649
2650 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2651
94515237
JB
26522011-06-27 Juanma Barranquero <lekktu@gmail.com>
2653
2654 * makefile.w32-in: Redesign dependencies so they reflect more
2655 clearly which files are directly included by each source file,
2656 and not through other includes.
2657
e43b6e43
MR
26582011-06-27 Martin Rudalics <rudalics@gmx.at>
2659
2660 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2661 (sort_overlays, overlay_strings): When an overlay's clone number
2662 matches the window's clone number process the overlay even if
2663 the overlay's window property doesn't match the current window.
2664
d68443dc
MR
2665 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2666 (Fwindow_hchild): Rename to Fwindow_left_child.
2667 (Fwindow_next): Rename to Fwindow_next_sibling.
2668 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2669 (resize_window_check): Rename to window_resize_check.
2670 (resize_window_apply): Rename to window_resize_apply.
2671 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2672 (Fdelete_other_windows_internal, resize_frame_windows)
2673 (Fsplit_window_internal, Fdelete_window_internal)
2674 (grow_mini_window, shrink_mini_window)
2675 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2676
c7e73be5
JD
26772011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2678
2679 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2680 (emacs_fixed_set_min_size): Remove.
2681 (emacs_fixed_new): Take frame as argument.
2682
2683 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2684 (_EmacsFixedPrivate): Remove minwidth/height.
2685 Add struct frame *f.
2686 (emacs_fixed_init): Initialize priv->f.
2687 (get_parent_class, emacs_fixed_set_min_size): Remove.
2688 (emacs_fixed_new): Set priv->f to argument.
2689 (emacs_fixed_get_preferred_width)
2690 (emacs_fixed_get_preferred_height): Use min_width/height from
2691 frames size_hint to set minimum and natural (Bug#8919).
2692 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2693 and use min_width/height from frames size_hint to set
2694 min_width/height (Bug#8919).
2695
2696 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2697 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2698 Fix indentation.
c7e73be5 2699
cf99dcf8
EZ
27002011-06-26 Eli Zaretskii <eliz@gnu.org>
2701
2702 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2703 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2704 called at ZV.
2705
029529ac
CY
27062011-06-26 Chong Yidong <cyd@stupidchicken.com>
2707
2708 * process.c (wait_reading_process_output): Bypass select if
2709 waiting for a cell while ignoring keyboard input, and input is
2710 pending. Suggested by Jan Djärv (Bug#8869).
2711
7a7ef429
PE
27122011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2713
2714 Use gnulib's dup2 module instead of rolling our own.
2715 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2716
11fdef7d 27172011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2718
2719 * dispnew.c (scrolling_window): Before scrolling, turn off a
2720 mouse-highlight in the window being scrolled.
2721
cd3520a4
JB
27222011-06-24 Juanma Barranquero <lekktu@gmail.com>
2723
2724 Move DEFSYM to lisp.h and use everywhere.
2725
2726 * character.h (DEFSYM): Move declaration...
2727 * lisp.h (DEFSYM): ...here.
2728
2729 * gnutls.c:
2730 * minibuf.c:
2731 * w32menu.c:
2732 * w32proc.c:
2733 * w32select.c: Don't include character.h.
2734
2735 * alloc.c (syms_of_alloc):
2736 * buffer.c (syms_of_buffer):
2737 * bytecode.c (syms_of_bytecode):
2738 * callint.c (syms_of_callint):
2739 * casefiddle.c (syms_of_casefiddle):
2740 * casetab.c (init_casetab_once):
2741 * category.c (init_category_once, syms_of_category):
2742 * ccl.c (syms_of_ccl):
2743 * cmds.c (syms_of_cmds):
2744 * composite.c (syms_of_composite):
2745 * dbusbind.c (syms_of_dbusbind):
2746 * dired.c (syms_of_dired):
2747 * dispnew.c (syms_of_display):
2748 * doc.c (syms_of_doc):
2749 * editfns.c (syms_of_editfns):
2750 * emacs.c (syms_of_emacs):
2751 * eval.c (syms_of_eval):
2752 * fileio.c (syms_of_fileio):
2753 * fns.c (syms_of_fns):
2754 * frame.c (syms_of_frame):
2755 * fringe.c (syms_of_fringe):
2756 * insdel.c (syms_of_insdel):
2757 * keymap.c (syms_of_keymap):
2758 * lread.c (init_obarray, syms_of_lread):
2759 * macros.c (syms_of_macros):
2760 * msdos.c (syms_of_msdos):
2761 * print.c (syms_of_print):
2762 * process.c (syms_of_process):
2763 * search.c (syms_of_search):
2764 * sound.c (syms_of_sound):
2765 * syntax.c (init_syntax_once, syms_of_syntax):
2766 * terminal.c (syms_of_terminal):
2767 * textprop.c (syms_of_textprop):
2768 * undo.c (syms_of_undo):
2769 * w32.c (globals_of_w32):
2770 * window.c (syms_of_window):
2771 * xdisp.c (syms_of_xdisp):
2772 * xfaces.c (syms_of_xfaces):
2773 * xfns.c (syms_of_xfns):
2774 * xmenu.c (syms_of_xmenu):
2775 * xsettings.c (syms_of_xsettings):
2776 * xterm.c (syms_of_xterm): Use DEFSYM.
2777
4228cf16
TZ
27782011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2779
cd3520a4 2780 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2781
7fcccf1e
PE
27822011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2783
7efb4e0e
PE
2784 Integer and buffer overflow fixes (Bug#8873).
2785
ff5844ad
PE
2786 * print.c (printchar, strout): Check for string overflow.
2787 (PRINTPREPARE, printchar, strout):
2788 Don't set size unless allocation succeeds.
2789
90532f02
PE
2790 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2791 for sizes. Check for string overflow more accurately.
2792 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2793
6d84508d
PE
2794 * macros.c: Integer and buffer overflow fixes.
2795 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2796 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2797 Use ptrdiff_t, not int, for sizes.
2798 Don't increment bufsize until after realloc succeeds.
2799 Check for size-calculation overflow.
2800 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2801
437b2cb4
PE
2802 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2803
8b9ac8b4
PE
2804 * lread.c: Integer overflow fixes.
2805 (read_integer): Radix is now EMACS_INT, not int,
2806 to improve quality of diagnostics for out-of-range radices.
2807 Calculate buffer size correctly for out-of-range radices.
2808 (read1): Check for integer overflow in radices, and in
2809 read-circle numbers.
82cb60d3
PE
2810 (read_escape): Avoid int overflow.
2811 (Fload, openp, read_buffer_size, read1)
2812 (substitute_object_recurse, read_vector, read_list, map_obarray):
2813 Use ptrdiff_t, not int, for sizes.
2814 (read1): Use EMACS_INT, not int, for sizes.
20270765 2815 Check for size overflow.
8b9ac8b4 2816
7fcccf1e
PE
2817 * image.c (cache_image): Check for size arithmetic overflow.
2818
bfbbd7e7
PE
2819 * lread.c: Integer overflow issues.
2820 (saved_doc_string_size, saved_doc_string_length)
2821 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2822 Now ptrdiff_t, not int.
2823 (read1): Don't assume doc string length fits in int. Check for
2824 out-of-range doc string lengths.
2825 (read_list): Don't assume file position fits in int.
39019e54 2826 (read_escape): Check for hex character overflow.
bfbbd7e7 2827
4e323265
LL
28282011-06-22 Leo Liu <sdl.web@gmail.com>
2829
2830 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2831 Move to minibuffer.el.
2832
85fece3e
PE
28332011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2834
20b84ce9 2835 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2836 The following patches are for when GLYPH_DEBUG && !XASSERT.
2837 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2838 * dispnew.c (flush_stdout):
2839 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2840 Mark as externally visible.
2841 * dispnew.c (check_window_matrix_pointers): Now static.
2842 * dispnew.c (window_to_frame_vpos):
2843 * xfns.c (unwind_create_frame):
2844 * xterm.c (x_check_font): Remove unused local.
2845 * scroll.c (CHECK_BOUNDS):
2846 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2847 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2848 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2849 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2850 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2851 Now static.
2852 (debug_method_add): Use va_list and vsprintf rather than relying
2853 on undefined behavior with wrong number of arguments.
2854 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2855 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2856 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2857 since we're not interested in debugging glyphs with old libraries.
2858 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2859 GCC 4.6.0's static checking.
2860
0766b489
PE
28612011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2862
31fd4b32
PE
2863 Integer overflow and signedness fixes (Bug#8873).
2864 A few related buffer overrun fixes, too.
2865
b79e8648
PE
2866 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2867
0766b489
PE
2868 * dispextern.h (struct face.stipple):
2869 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2870 (x_bitmap_mask, x_allocate_bitmap_record)
2871 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2872 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2873 (x_create_bitmap_from_xpm_data):
2874 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2875 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2876 (.bitmaps_last):
2877 * xfaces.c (load_pixmap):
2878 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2879 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2880 (.bitmaps_last, struct x_output.icon_bitmap):
2881 Use ptrdiff_t, not int, for bitmap indexes.
2882 (x_allocate_bitmap_record): Check for size overflow.
2883 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2884
b081724f
PE
2885 Use ptrdiff_t, not int, for overlay counts.
2886 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2887 * editfns.c (overlays_around, get_pos_property):
2888 * textprop.c (get_char_property_and_overlay):
2889 * xdisp.c (next_overlay_change, note_mouse_highlight):
2890 * xfaces.c (face_at_buffer_position):
21514da7
PE
2891 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2892 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2893 (Fnext_overlay_change, Fprevious_overlay_change)
2894 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2895 Use ptrdiff_t, not int, for sizes.
21514da7 2896 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2897
3de73e5e
PE
2898 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2899
2606c57b
PE
2900 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2901 (x_session_initialize): Do not assume string length fits in int.
2902
aaafe47a
PE
2903 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2904 This is unlikely, but can occur if DPI is outlandish.
2905
2674ddc8 2906 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2907 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2908
28154962
PE
2909 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2910 * xrdb.c (magic_file_p, search_magic_path):
2911 Omit last arg SUFFIX; it was always 0. All callers changed.
2912 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2913
7de51af5
PE
2914 * xfont.c (xfont_match): Avoid need for strlen.
2915
25ed6cc3
PE
2916 * xfns.c: Don't assume strlen fits in int.
2917 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2918
4eab31dd
PE
2919 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2920 not unsigned long, as we prefer signed integers. All callers changed.
2921 Detect integer overflow in repeat count.
2922 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2923 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2924
171e2a58
PE
2925 * termcap.c: Don't assume sizes fit in int and never overflow.
2926 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2927 (gobble_line): Check for size-calculation overflow.
2928
ad39faca 2929 * minibuf.c (Fread_buffer):
6e5bb2dc 2930 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2931 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2932 Don't assume string length fits in int.
2933
52c61c22 2934 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2935 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2936
b5b8c9e5
PE
2937 * font.c: Don't assume string length fits in int.
2938 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2939 Use ptrdiff_t, not int.
ccd6111c
PE
2940 (font_intern_prop): Don't assume string length fits in int.
2941 Don't assume integer property fits in fixnum.
2942 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2943
882f0d81 2944 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2945 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2946 Reformulate so as not to need the command string.
2947 Invoke gzip -cd rather than gunzip, as it's more portable.
2948 (lock_info_type, lock_file_1, lock_file):
2949 Don't assume pid_t and time_t fit in unsigned long.
2950 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2951 (current_lock_owner): Prefer signed type for sizes.
2952 Use memcpy, not strncpy, where memcpy is what is really wanted.
2953 Don't assume (via atoi) that time_t and pid_t fit in int.
2954 Check for time_t and/or pid_t out of range, e.g., via a network share.
2955 Don't alloca where an auto var works fine.
2956
93f4cf88
PE
2957 * fileio.c: Fix some integer overflow issues.
2958 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2959 Don't assume string length fits in int.
2960 (directory_file_name): Don't assume string length fits in long.
2961 (make_temp_name): Don't assume pid fits in int, or that its print
2962 length is less than 20.
2963
f3e92b69
PE
2964 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2965
1bfdaf10
PE
2966 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2967
35016e9a
PE
2968 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2969
3d1e65a1
PE
2970 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2971 We prefer signed integers, even for size calculations.
2972
0b963a93
PE
2973 * emacs.c: Don't assume string length fits in 'int'.
2974 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2975 (main): Don't invoke strlen when not needed.
2976
573f4b54
PE
2977 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2978 (XD_DEBUG_MESSAGE): Don't waste a byte.
2979
989f33ba
PE
2980 * callproc.c (getenv_internal_1, getenv_internal)
2981 (Fgetenv_internal):
965d34eb
PE
2982 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2983
e4d29b33
PE
2984 * lread.c (invalid_syntax): Omit length argument.
2985 All uses changed. This doesn't fix a bug, but it simplifies the
2986 code away from its former Hollerith-constant appearance, and it's
2987 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2988 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2989
eb49b136
PE
2990 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2991 This didn't break anything, but it didn't help either.
2992 It's confusing to put a bogus integer in a place where the actual
2993 value does not matter.
9f62aeb1 2994 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2995 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2996
15375a22
PE
2997 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2998 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2999 implementation.
b61cc01c
PE
3000 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3001 We prefer signed types, and the value cannot exceed the EMACS_INT
3002 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3003 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3004 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3005 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3006
53b2623d
PE
3007 * indent.c (sane_tab_width): New function.
3008 (current_column, scan_for_column, Findent_to, position_indentation)
3009 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3010 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3011
51cab52b 3012 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3013
f2ed8a70
PE
3014 * lisp.h (lint_assume): New macro.
3015 * composite.c (composition_gstring_put_cache):
3016 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3017
abe80cc6
PE
3018 * editfns.c, insdel.c:
3019 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3020
b02c740e
PE
3021 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3022
ebc96716
PE
3023 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3024
b4e50fa0 3025 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3026 Use much-faster test for byte-length change.
311d5d7c 3027 Don't assume string byte-length fits in 'int'.
a4cf38e4 3028 Check that character arg fits in 'int'.
85461888 3029 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3030
c0c1ee9f
PE
3031 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3032
a498d7f4
PE
3033 * fns.c (concat): Catch string overflow earlier.
3034 Do not rely on integer wraparound.
3035
51cab52b
PE
3036 * dispextern.h (struct it.overlay_strings_charpos)
3037 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
3038 * xdisp.c (forward_to_next_line_start)
3039 (back_to_previous_visible_line_start)
3040 (reseat_at_next_visible_line_start, next_element_from_buffer):
3041 Don't arbitrarily truncate the value of 'selective' to int.
3042
76031fad
PE
3043 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3044
5eb55db9
PE
3045 * composite.c: Don't truncate sizes to 'int'.
3046 (composition_gstring_p, composition_reseat_it)
3047 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
3048 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3049 not EMACS_UINT, for indexes.
5eb55db9 3050
0703a717
PE
3051 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3052
d6202519
PE
3053 * buffer.c: Include <verify.h>.
3054 (struct sortvec.priority, struct sortstr.priority):
8961a454 3055 Now EMACS_INT, not int.
c20998a7 3056 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
3057 (struct sortstr.size, record_overlay_string)
3058 (struct sortstrlist.size, struct sortlist.used):
3059 Don't truncate size to int.
3060 (record_overlay_string): Check for size-calculation overflow.
d6202519 3061 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 3062
d5a19415
JM
30632011-06-22 Jim Meyering <meyering@redhat.com>
3064
029529ac 3065 Don't leak an XBM-image-sized buffer
d5a19415
JM
3066 * image.c (xbm_load): Free the image buffer after using it.
3067
a9041e6c
PE
30682011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3069
3070 Port to Sun C.
3071 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3072 that Sun C diagnosed.
3073 * fns.c (secure_hash): Fix pointer signedness issue.
3074 * intervals.c (static_offset_intervals): New function.
3075 (offset_intervals): Use it.
3076
7f3f739f
LL
30772011-06-21 Leo Liu <sdl.web@gmail.com>
3078
3079 * deps.mk (fns.o):
3080 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3081 sha512.h.
3082
3083 * fns.c (secure_hash): Rename from crypto_hash_function and change
3084 the first arg to accept symbols.
5b66d427 3085 (Fsecure_hash): New primitive.
7f3f739f
LL
3086 (syms_of_fns): New symbols.
3087
76147d94
DD
30882011-06-20 Deniz Dogan <deniz@dogan.se>
3089
3090 * process.c (Fset_process_buffer): Clarify return value in
3091 docstring.
3092
7d7d0045
CY
30932011-06-18 Chong Yidong <cyd@stupidchicken.com>
3094
3095 * dispnew.c (add_window_display_history): Use BVAR.
3096
3097 * xdisp.c (debug_method_add): Use BVAR.
3098 (check_window_end, dump_glyph_matrix, dump_glyph)
3099 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3100
3101 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3102 Likewise.
3103
3104 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3105 check till after the cache is created in init_frame_faces.
3106
ff2bc410
SM
31072011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3108
3109 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3110
28177add
PE
31112011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3112
dd3482fe
PE
3113 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3114 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3115 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3116
393d71f3 3117 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
3118 * fileio.c (Finsert_file_contents):
3119 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3120 Remove the old (too-loose) buffer overflow checks.
3121 They weren't needed, since make_gap checks for buffer overflow.
3122 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3123 The old code merely checked for Emacs fixnum overflow, and relied
3124 on undefined (wraparound) behavior. The new code avoids undefined
3125 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3126
2e6813b0 3127 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
3128 Tune. Don't use wider integers than needed. Don't use alloca.
3129 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 3130
599a9e4f
PE
3131 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3132
99561444
PE
3133 * insdel.c, lisp.h (buffer_overflow): New function.
3134 (insert_from_buffer_1, replace_range, replace_range_2):
3135 * insdel.c (make_gap_larger):
3136 * editfns.c (Finsert_char):
3137 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3138
28177add
PE
3139 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3140
e69dafad
PE
31412011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3142
a7af7fde 3143 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 3144
b1c46f02
PE
3145 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3146 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3147
e69dafad
PE
3148 * fileio.c: Don't assume EMACS_INT fits in off_t.
3149 (emacs_lseek): New static function.
3150 (Finsert_file_contents, Fwrite_region): Use it.
3151 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3152
566684ea
PE
3153 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3154
e6966cd6
PE
3155 * fns.c: Don't overflow int when computing a list length.
3156 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3157 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3158 truncation on 64-bit hosts. Check for QUIT every
3159 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3160 faster and is responsive enough.
3161 (Flength): Report an error instead of overflowing an integer.
3162 (Fsafe_length): Return a float if the value is not representable
3163 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3164 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3165 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3166
dd0b0efb
PE
3167 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3168 (header_size, word_size): New constants.
3169 (allocate_vectorlike): Don't check size overflow here.
3170 (allocate_vector): Check it here instead, since this is the only
3171 caller of allocate_vectorlike that could cause overflow.
3172 Check that the new vector's length is representable as a fixnum.
3173
86fe5cfe
PE
3174 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3175 The previous code was bogus. For example, next_almost_prime (32)
3176 returned 39, which is undesirable as it is a multiple of 3; and
3177 next_almost_prime (24) returned 25, which is a multiple of 5 so
3178 why was the code bothering to check for multiples of 7?
3179
80e88859
PE
3180 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3181
4a2f0ad6
PE
3182 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3183
f66c7cf8
PE
3184 Variadic C functions now count arguments with ptrdiff_t.
3185 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3186 Back then I didn't know that the Emacs coding style prefers signed int.
3187 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3188 were being counted with int, which may truncate counts on 64-bit
3189 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3190 * lisp.h (struct Lisp_Subr.function.aMANY)
3191 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3192 Arg counts are now ptrdiff_t, not size_t.
3193 All variadic functions and their callers changed accordingly.
3194 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3195 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3196 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3197 * callint.c (Fcall_interactively): Check arg count for overflow,
3198 to avoid potential buffer overrun. Use signed char, not 'int',
3199 for 'varies' array, so that we needn't bother to check its size
3200 calculation for overflow.
3201 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3202 * eval.c (apply_lambda):
3203 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3204 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3205 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3206
a1759b76
PE
3207 * callint.c (Fcall_interactively): Don't use index var as event count.
3208
d96be9fc
PE
3209 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3210 * mem-limits.h (SIZE): Remove; no longer used.
3211
a690a978 3212 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3213
578c21e6
PE
3214 Remove unnecessary casts.
3215 * xterm.c (x_term_init):
3216 * xfns.c (x_set_border_pixel):
3217 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3218 These aren't needed now that we assume ANSI C.
3219
96f53c6c
PE
3220 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3221 It's more likely to cause problems (due to unsigned overflow)
3222 than to cure them.
3223
83c77d31
PE
3224 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3225
ee2079f1
PE
3226 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3227
6da65536
PE
3228 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3229
7147c4a4
PE
3230 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3231
193e32d9
PE
3232 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3233
e5533da6
PE
3234 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3235
9910e595
PE
3236 GLYPH_CODE_FACE returns EMACS_INT, not int.
3237 * dispextern.h (merge_faces):
3238 * xfaces.c (merge_faces):
01103c44
PE
3239 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3240 Don't assume EMACS_INT fits in int.
9910e595 3241
2638320e
PE
3242 * character.h (CHAR_VALID_P): Remove unused parameter.
3243 * fontset.c, lisp.h, xdisp.c: All uses changed.
3244
045eb8d9
PE
3245 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3246
c1f134b5
PE
3247 * fns.c (concat): Minor tuning based on overflow analysis.
3248 This doesn't fix any bugs. Use int to hold character, instead
3249 of constantly refetching from Emacs object. Use XFASTINT, not
3250 XINT, for value known to be a character. Don't bother comparing
3251 a single byte to 0400, as it's always less.
3252
395fcb93 3253 * floatfns.c (Fexpt):
327eeec8
PE
3254 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3255
abbd3d23
PE
3256 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3257 for characters.
3258
684a03ef
PE
3259 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3260
0fed43f3
PE
3261 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3262 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3263 incorrectly succeed when S was a string, because 4294967386 was
3264 truncated before it was used.
3265
8fd02eb7
PE
3266 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3267 Otherwise, an out-of-range integer could cause undefined behavior
3268 on a 64-bit host.
3269
f8c86b69
PE
3270 * composite.c: Use int, not EMACS_INT, for characters.
3271 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3272 EMACS_INT, for values that are known to be in character range.
3273 This doesn't fix any bugs but is the usual style inside Emacs and
3274 may generate better code on 32-bit machines.
3275
34206dd2
PE
3276 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3277 This is for reasons similar to the recent CHAR_STRING fix.
3278 * charset.c (Fencode_char): Check that character arg is actually
3279 a character. Pass an int to ENCODE_CHAR.
3280 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3281 wider than 'int', as a compile-time check to prevent future regressions
3282 in this area.
3283
c5958d4c 3284 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3285
3286 Make sure a 64-bit char is never passed to CHAR_STRING.
3287 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3288 by silently ignoring the top 32 bits, allowing some values
3289 that were far too large to be valid characters.
3290 * character.h: Include <verify.h>.
3291 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3292 arguments are no wider than unsigned, as a compile-time check
3293 to prevent future regressions in this area.
3294 * data.c (Faset):
01103c44 3295 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3296 (Fsubst_char_in_region):
3297 * fns.c (concat):
3298 * xdisp.c (decode_mode_spec_coding):
3299 Adjust to CHAR_STRING's new requirement.
3300 * editfns.c (Finsert_char, Fsubst_char_in_region):
3301 * fns.c (concat): Check that character args are actually
3302 characters. Without this test, these functions did the wrong
3303 thing with wildly out-of-range values on 64-bit hosts.
3304
d37ca623
PE
3305 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3306 These casts should not be needed on 32-bit hosts, either.
3307 * keyboard.c (read_char):
3308 * lread.c (Fload): Remove casts to unsigned.
3309
ea204efb
PE
3310 * lisp.h (UNSIGNED_CMP): New macro.
3311 This fixes comparison bugs on 64-bit hosts.
3312 (ASCII_CHAR_P): Use it.
3313 * casefiddle.c (casify_object):
01103c44 3314 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3315 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3316 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3317 * dispextern.h (FACE_FROM_ID):
3318 * keyboard.c (read_char): Use UNSIGNED_CMP.
3319
41cb286c
PE
3320 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3321 not to EMACS_INT, to avoid GCC warning.
3322
4a1b9832
PE
3323 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3324
55daad71
PE
3325 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3326 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3327 isn't needed on 32-bit machines.
8f95c75c 3328
01103c44
PE
3329 * buffer.c (Fgenerate_new_buffer_name):
3330 Use EMACS_INT for count, not int.
0ceccced 3331 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3332
3333 * data.c (Qcompiled_function): Now static.
3334
c6f072e7
PE
3335 * window.c (window_body_lines): Now static.
3336
20ce5912
PE
3337 * image.c (gif_load): Rename local to avoid shadowing.
3338
9c4c5f81
PE
3339 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3340 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3341 * alloc.c (make_save_value): Integer argument is now of type
3342 ptrdiff_t, not int.
3343 (mark_object): Use ptrdiff_t, not int.
3344 * lisp.h (pD): New macro.
3345 * print.c (print_object): Use it.
3346
c0c5c8ae
PE
3347 * alloc.c: Use EMACS_INT, not int, to count objects.
3348 (total_conses, total_markers, total_symbols, total_vector_size)
3349 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3350 (total_free_floats, total_floats, total_free_intervals)
3351 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3352 Now EMACS_INT, not int. All uses changed.
3353 (Fgarbage_collect): Compute overall total using a double, so that
3354 integer overflow is less likely to be a problem. Check for overflow
3355 when converting back to an integer.
5a25e253
PE
3356 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3357 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3358 These were 'int' variables that could overflow on 64-bit hosts;
3359 they were never used, so remove them instead of repairing them.
211a0b2a 3360 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3361 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3362 Previously, this ceilinged at INT_MAX, but that doesn't work on
3363 64-bit machines.
e46bb31a 3364 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3365
c78baabf 3366 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3367 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3368 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3369 when a (possibly-narrower) signed value would do just as well.
3370 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3371
c9d624c6
PE
3372 * alloc.c: Catch some string size overflows that we were missing.
3373 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3374 for convenience in STRING_BYTES_MAX.
3375 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3376 The definition here is exact; the one in lisp.h was approximate.
3377 (allocate_string_data): Check for string overflow. This catches
3378 some instances we weren't catching before. Also, it catches
3379 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3380 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3381 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3382
c9d624c6
PE
3383 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3384 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3385 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3386
353032ce
PE
3387 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3388
2bccce07
PE
3389 * alloc.c (Fmake_string): Check for out-of-range init.
3390
0ac30604
SM
33912011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3392
3393 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3394
c195f2de
JD
33952011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3396
3397 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3398 xg_get_default_scrollbar_width.
3399
3400 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3401 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3402 (style_changed_cb): Call update_theme_scrollbar_width and call
3403 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3404 all frames (Bug#8505).
3405 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3406 Call gtk_window_set_resizable if HAVE_GTK3.
3407 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3408 and height if HAVE_GTK3 (Bug#8505).
3409 (scroll_bar_width_for_theme): New variable.
3410 (update_theme_scrollbar_width): New function.
3411 (xg_get_default_scrollbar_width): Move code to
3412 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3413 (xg_initialize): Call update_theme_scrollbar_width.
3414
3415 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3416
3417 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3418
e10ac9f1
MR
34192011-06-12 Martin Rudalics <rudalics@gmx.at>
3420
3421 * frame.c (make_frame): Call other_buffer_safely instead of
3422 other_buffer.
3423
3424 * window.c (temp_output_buffer_show): Call display_buffer with
3425 second argument Vtemp_buffer_show_specifiers and reset latter
3426 immediately after the call.
3427 (Vtemp_buffer_show_specifiers): New variable.
3428 (auto_window_vscroll_p, next_screen_context_lines)
3429 (Vscroll_preserve_screen_position): Remove leading asterisks from
3430 doc-strings.
3431
2d3c217e 34322011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3433
7b7f97e8 3434 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3435 * buffer.c (Qclone_number): Remove for now, as it's unused.
3436 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3437 (record_buffer): Remove unused local.
3438 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3439 (set_frame_buffer_list): Remove; unused.
3440 * frame.h (other_visible_frames): Remove decl.
3441 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3442 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3443 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3444 if HAVE_GPM.
3445 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3446 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3447 Define only if HAVE_GPM.
3448 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3449 (update_hints_inhibit): Remove; never set. All uses removed.
3450 * widgetprv.h (emacsFrameClassRec): Remove decl.
3451 * window.c (delete_deletable_window): Now returns void, since it
3452 wasn't returning anything.
3453 (compare_window_configurations): Remove unused locals.
3454 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3455 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3456 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3457 the same widths as pointers. This follows up on the 2011-05-06 patch.
3458 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3459 * xterm.h: Likewise.
3460 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3461
1384b89e
JB
34622011-06-12 Juanma Barranquero <lekktu@gmail.com>
3463
3464 * makefile.w32-in: Update dependencies.
3465 (LISP_H): Add lib/intprops.h.
3466
1100a63c
CY
34672011-06-11 Chong Yidong <cyd@stupidchicken.com>
3468
3469 * image.c (gif_load): Add animation frame delay to the metadata.
3470 (syms_of_image): Use DEFSYM. New symbol `delay'.
3471
6198ccd0
MR
34722011-06-11 Martin Rudalics <rudalics@gmx.at>
3473
3474 * window.c (delete_deletable_window): Re-add.
3475 (Fset_window_configuration): Rewrite to handle dead buffers and
3476 consequently deletable windows.
3477 (window_tree, Fwindow_tree): Remove. Supply functionality in
3478 window.el.
3479 (compare_window_configurations): Simplify code.
3480
b6e3633c
AS
34812011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3482
1ab0dee5
AS
3483 * image.c (imagemagick_load_image): Fix type mismatch.
3484 (Fimagemagick_types): Likewise.
3485
b6e3633c
AS
3486 * window.h (replace_buffer_in_windows): Declare.
3487
9397e56f
MR
34882011-06-11 Martin Rudalics <rudalics@gmx.at>
3489
3490 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3491 Qclone_number. Remove external declaration of Qdelete_window.
3492 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3493 code.
640c8776
SM
3494 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3495 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3496 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3497 buffer list implementation.
3498 (other_buffer_safely): New function.
3499 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3500 calls to replace_buffer_in_windows and
3501 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3502 if allowed.
3503 (record_buffer): Inhibit quitting and rewrite using quittable
3504 functions. Run Qbuffer_list_update_hook if allowed.
3505 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3506 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3507 Move switch-to-buffer to window.el.
9397e56f
MR
3508 (bury-buffer): Move to window.el.
3509 (Vbuffer_list_update_hook): New variable.
3510
3511 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3512 section.
3513
3514 * window.h (resize_frame_windows): Move up in code.
3515 (Fwindow_frame): Remove EXFUN.
3516 (replace_buffer_in_all_windows): Remove prototype.
3517 (replace_buffer_in_windows_safely): Add prototype.
3518
3519 * window.c: Declare Qdelete_window static again. Move down
3520 declaration of select_count.
3521 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3522 (Fother_window): Move to window.el.
3523 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3524 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3525 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3526 window.el.
3527 (replace_buffer_in_windows): Implement by calling
3528 Qreplace_buffer_in_windows.
3529 (replace_buffer_in_all_windows): Remove with some functionality
3530 moved into replace_buffer_in_windows_safely.
3531 (replace_buffer_in_windows_safely): New function.
3532 (select_window_norecord, select_frame_norecord): Move in front
3533 of run_window_configuration_change_hook. Remove now obsolete
3534 declarations.
640c8776
SM
3535 (Fset_window_buffer): Rewrite doc-string.
3536 Call Qrecord_window_buffer.
9397e56f
MR
3537 (keys_of_window): Move binding for other-window to window.el.
3538
b50691aa
CY
35392011-06-11 Chong Yidong <cyd@stupidchicken.com>
3540
3541 * dispextern.h (struct image): Replace data member, whose int_val
3542 and ptr_val fields were not used by anything, with a single
3543 lisp_val object.
3544
3545 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3546 (gif_clear_image, gif_load, imagemagick_load_image)
3547 (gs_clear_image, gs_load): Callers changed.
3548
3f754b86
PE
35492011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3550
cca69397
PE
3551 * buffer.h: Include <time.h>, for time_t.
3552 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3553
109e28d0
PE
3554 Fix minor problems found by static checking.
3555
60737f02
PE
3556 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3557
4b66faf3
PE
3558 Make identifiers static if they are not used in other modules.
3559 * data.c (Qcompiled_function, Qframe, Qvector):
3560 * image.c (QimageMagick, Qsvg):
3561 * minibuf.c (Qmetadata):
3562 * window.c (resize_window_check, resize_root_window): Now static.
3563 * window.h (resize_window_check, resize_root_window): Remove decls.
3564
109e28d0
PE
3565 * window.c (window_deletion_count, delete_deletable_window):
3566 Remove; unused.
46a4ce9e
PE
3567 (window_body_lines): Now static.
3568 (Fdelete_other_windows_internal): Mark vars as initialized.
3569 Make sure 'resize_failed' is initialized.
3570 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3571 (resize_window_apply): Remove unused local.
3572 * window.h (delete_deletable_window): Remove decl.
3573
109e28d0 3574 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3575 (imagemagick_load_image): Fix pointer signedness problem by changing
3576 last arg from unsigned char * to char *. All uses changed.
3577 Also, fix a local for similar reasons.
3578 Remove unused locals. Remove locals to avoid shadowing.
3579 (fn_rsvg_handle_free): Remove; unused.
3580 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3581 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3582
3f754b86
PE
3583 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3584
2547adb1
CY
35852011-06-10 Chong Yidong <cyd@stupidchicken.com>
3586
3587 * image.c (gif_load): Fix omitted cast error introduced by
3588 2011-06-06 change.
3589
2c8e37d4
MR
35902011-06-10 Martin Rudalics <rudalics@gmx.at>
3591
3592 * window.h (resize_proportionally, orig_total_lines)
3593 (orig_top_line): Remove from window structure.
3594 (set_window_height, set_window_width, change_window_heights)
3595 (Fdelete_window): Remove prototypes.
3596 (resize_frame_windows): Remove duplicate declaration.
3597
440a42e3
EZ
35982011-06-10 Eli Zaretskii <eliz@gnu.org>
3599
3600 * window.h (resize_frame_windows, resize_window_check)
3601 (delete_deletable_window, resize_root_window)
3602 (resize_frame_windows): Declare prototypes.
3603
3604 * window.c (resize_window_apply): Make definition be "static" to
3605 match the prototype.
3606
562dd5e9
MR
36072011-06-10 Martin Rudalics <rudalics@gmx.at>
3608
3609 * window.c: Remove declarations of Qwindow_size_fixed,
3610 window_min_size_1, window_min_size_2, window_min_size,
3611 size_window, window_fixed_size_p, enlarge_window, delete_window.
3612 Remove static from declaration of Qdelete_window, it's
3613 temporarily needed by Fbury_buffer.
3614 (replace_window): Don't assign orig_top_line and
3615 orig_total_lines.
3616 (Fdelete_window, delete_window): Remove. Window deletion is
3617 handled by window.el.
640c8776
SM
3618 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3619 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3620 (Fdelete_other_windows): Remove. Deleting other windows is
3621 handled by window.el.
3622 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3623 handled in window.el.
3624 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3625 Window minimum sizes are handled in window.el.
3626 (shrink_windows, size_window, set_window_height)
3627 (set_window_width, change_window_heights, window_height)
3628 (window_width, CURBEG, CURSIZE, enlarge_window)
3629 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3630 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3631 handled in window.el.
3632 (make_dummy_parent): Rename to make_parent_window and give it a
3633 second argument horflag.
3634 (make_window): Don't set resize_proportionally any more.
3635 (Fsplit_window): Remove. Windows are split in window.el.
3636 (save_restore_action, save_restore_orig_size)
3637 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3638 Resize mini windows in window.el.
3639 (grow_mini_window, shrink_mini_window): Implement by calling
3640 Qresize_root_window_vertically, resize_window_check and
3641 resize_window_apply.
640c8776
SM
3642 (saved_window, Fset_window_configuration, save_window_save):
3643 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3644 resize_proportionally.
3645 (window_min_height, window_min_width): Move to window.el.
3646 (keys_of_window): Move bindings for delete-other-windows,
3647 split-window, delete-window and enlarge-window to window.el.
3648
3649 * buffer.c: Temporarily extern Qdelete_window.
3650 (Fbury_buffer): Temporarily call Qdelete_window instead of
3651 Fdelete_window (Fbury_buffer will move to window.el soon).
3652
3653 * frame.c (set_menu_bar_lines_1): Remove code handling
3654 orig_top_line and orig_total_lines.
3655
3656 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3657 set_window_height but set heights directly.
3658 (change_frame_size_1): Use resize_frame_windows.
3659
3660 * xdisp.c (init_xdisp): Don't use set_window_height but set
3661 heights directly.
3662
640c8776
SM
3663 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3664 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3665 run_window_configuration_change_hook.
3666
3667 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3668 instead of change_window_heights and run
3669 run_window_configuration_change_hook.
3670
1a13852e
MR
36712011-06-09 Martin Rudalics <rudalics@gmx.at>
3672
3673 * window.c (replace_window): Rename second argument REPLACEMENT to
3674 NEW. New third argument SETFLAG. Rewrite.
3675 (delete_window, make_dummy_parent): Call replace_window with
3676 third argument 1.
3677 (window_list_1): Move down in code.
3678 (run_window_configuration_change_hook): Move set_buffer part
3679 before select_frame_norecord part in order to unwind correctly.
3680 Rename count1 to count.
3681 (recombine_windows, delete_deletable_window, resize_root_window)
3682 (Fdelete_other_windows_internal)
3683 (Frun_window_configuration_change_hook, make_parent_window)
3684 (resize_window_check, resize_window_apply, Fresize_window_apply)
3685 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3686 (Fdelete_window_internal, Fresize_mini_window_internal):
3687 New functions.
1a13852e
MR
3688 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3689
f3d1777e
MR
36902011-06-08 Martin Rudalics <rudalics@gmx.at>
3691
496e208e
MR
3692 * window.h (window): Add some new members to window structure -
3693 normal_lines, normal_cols, new_total, new_normal, clone_number,
3694 splits, nest, prev_buffers, next_buffers.
3695 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3696 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3697
f3d1777e
MR
3698 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3699 Remove.
496e208e
MR
3700 (make_dummy_parent): Set new members of windows structure.
3701 (make_window): Move down in code. Handle new members of window
3702 structure.
3703 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3704 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3705 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3706 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3707 (Fset_window_next_buffers, Fset_window_clone_number):
3708 New functions.
496e208e
MR
3709 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3710 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3711 Doc-string fixes.
3712 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3713 Argument WINDOW can be now internal window too.
3714 (Fwindow_use_time): Move up in code.
3715 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3716 Rewrite doc-string.
3717 (Fset_window_configuration, saved_window)
3718 (Fcurrent_window_configuration, save_window_save): Handle new
3719 members of window structure.
b9e809c2
MR
3720 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3721 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3722 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3723 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3724 Qget_mru_window, Qresize_root_window,
3725 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3726 Qauto_buffer_name; staticpro them.
f3d1777e 3727
abde8f8c
MR
37282011-06-07 Martin Rudalics <rudalics@gmx.at>
3729
3730 * window.c (Fwindow_total_size, Fwindow_left_column)
3731 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3732 (Fwindow_list_1): New functions.
3733 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3734 (Fwindow_width, Fscroll_left, Fscroll_right):
3735 Use window_body_cols instead of window_box_text_cols.
3736 (delete_window, Fset_window_configuration):
3737 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3738 (delete_all_subwindows): Take a window as argument and not a
3739 structure. Rewrite.
190b47e6
MR
3740 (window_loop): Remove handling of GET_LRU_WINDOW and
3741 GET_LARGEST_WINDOW.
3742 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3743
3744 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3745 window_box_text_cols. delete_all_subwindows now takes a
3746 Lisp_Object as argument.
abde8f8c 3747
640c8776
SM
3748 * indent.c (compute_motion, Fcompute_motion):
3749 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3750
fa8a67e6
MR
3751 * frame.c (delete_frame): Call delete_all_subwindows with root
3752 window as argument.
3753
a54e3482
DC
37542011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3755
3756 * fns.c (Fputhash): Document return value.
3757
60002bf5
CY
37582011-06-06 Chong Yidong <cyd@stupidchicken.com>
3759
3760 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3761
0c671da6 37622011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3763
b862a52a 3764 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3765
be44ca6c
PE
3766 Check for overflow when converting integer to cons and back.
3767 * charset.c (Fdefine_charset_internal, Fdecode_char):
3768 Use cons_to_unsigned to catch overflow.
3769 (Fencode_char): Use INTEGER_TO_CONS.
3770 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3771 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3772 * data.c (long_to_cons, cons_to_long): Remove.
3773 (cons_to_unsigned, cons_to_signed): New functions.
3774 These signal an error for invalid or out-of-range values.
3775 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3776 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3777 * font.c (Ffont_variation_glyphs):
3778 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3779 * lisp.h: Include <intprops.h>.
3780 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3781 (cons_to_signed, cons_to_unsigned): New decls.
3782 (long_to_cons, cons_to_long): Remove decls.
3783 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3784 (Fprimitive_undo): Use CONS_TO_INTEGER.
3785 * xfns.c (Fx_window_property): Likewise.
3786 * xselect.c: Include <limits.h>.
3787 (x_own_selection, selection_data_to_lisp_data):
3788 Use INTEGER_TO_CONS.
3789 (x_handle_selection_request, x_handle_selection_clear)
3790 (x_get_foreign_selection, Fx_disown_selection_internal)
3791 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3792 (lisp_data_to_selection_data): Use cons_to_unsigned.
3793 (x_fill_property_data): Use cons_to_signed.
3794 Report values out of range.
3795
d1f3d2af
PE
3796 Check for buffer and string overflow more precisely.
3797 * buffer.h (BUF_BYTES_MAX): New macro.
3798 * lisp.h (STRING_BYTES_MAX): New macro.
3799 * alloc.c (Fmake_string):
3800 * character.c (string_escape_byte8):
3801 * coding.c (coding_alloc_by_realloc):
3802 * doprnt.c (doprnt):
3803 * editfns.c (Fformat):
3804 * eval.c (verror):
3805 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3806 since they may not be the same number.
3807 * editfns.c (Finsert_char):
3808 * fileio.c (Finsert_file_contents):
3809 Likewise for BUF_BYTES_MAX.
3810
dd52fcea
PE
3811 * image.c: Use ptrdiff_t, not int, for sizes.
3812 (slurp_file): Switch from int to ptrdiff_t.
3813 All uses changed.
3814 (slurp_file): Check that file size fits in both size_t (for
3815 malloc) and ptrdiff_t (for sanity and safety).
3816
7f9bbdbb
PE
3817 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3818 if b->modtime has its maximal value.
3819
dfe18f82
PE
3820 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3821
84acfcf0
PE
3822 Don't assume time_t can fit into int.
3823 * buffer.h (struct buffer.modtime): Now time_t, not int.
3824 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3825 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3826
ccd9a01a
PE
3827 Minor fixes for signed vs unsigned integers.
3828 * character.h (MAYBE_UNIFY_CHAR):
3829 * charset.c (maybe_unify_char):
3830 * keyboard.c (read_char, reorder_modifiers):
3831 XINT -> XFASTINT, since the integer must be nonnegative.
3832 * ftfont.c (ftfont_spec_pattern):
3833 * keymap.c (access_keymap, silly_event_symbol_error):
3834 XUINT -> XFASTINT, since the integer must be nonnegative.
3835 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3836 since it makes no difference and we prefer signed.
3837 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3838 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3839 nonnegative.
3840
d6d100dd
SM
38412011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3842
3843 * window.h (Fwindow_frame): Declare.
3844
2b6148e4
PE
38452011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3846
3847 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3848 (SPARE_MEMORY): Always define.
3849 (LARGE_REQUEST): Remove.
3850 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3851
f230ecc9
MR
38522011-06-06 Martin Rudalics <rudalics@gmx.at>
3853
727e958e
MR
3854 * lisp.h: Move EXFUNS for Fframe_root_window,
3855 Fframe_first_window and Fset_frame_selected_window to window.h.
3856
3857 * window.h: Move EXFUNS for Fframe_root_window,
3858 Fframe_first_window and Fset_frame_selected_window here from
3859 lisp.h.
3860
3861 * frame.c (Fwindow_frame, Fframe_first_window)
3862 (Fframe_root_window, Fframe_selected_window)
3863 (Fset_frame_selected_window): Move to window.c.
3864 (Factive_minibuffer_window): Move to minibuf.c.
3865 (Fother_visible_frames_p): New function.
3866
3867 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3868
f230ecc9
MR
3869 * window.c (decode_window, decode_any_window): Move up in code.
3870 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3871 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3872 (Fwindow_buffer): Move up and rewrite doc-string.
3873 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3874 (Fwindow_prev): New functions.
727e958e
MR
3875 (Fwindow_frame): Move here from frame.c. Accept any window as
3876 argument.
3877 (Fframe_root_window, Fframe_first_window)
3878 (Fframe_selected_window): Move here from frame.c. Accept frame
3879 or arbitrary window as argument. Update doc-strings.
3880 (Fminibuffer_window): Move up in code.
3881 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3882 (Fset_frame_selected_window): Move here from frame.c.
3883 Marginal rewrite.
727e958e
MR
3884 (Fselected_window, select_window, Fselect_window): Move up in
3885 code. Minor doc-string fixes.
f230ecc9 3886
4d09bcf6
PE
38872011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3888
3889 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3890 Do not assume that spare memory exists; that assumption is valid
3891 only if SYSTEM_MALLOC.
3892 (LARGE_REQUEST): New macro, so that the issue of large requests
3893 is separated from the issue of spare memory.
3894
810928a2
AS
38952011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3896
172418ad
AS
3897 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3898 format. (Bug#8806)
3899
43f862f7
AS
3900 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3901
810928a2
AS
3902 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3903 before statements.
3904
a059fe24
JD
39052011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3906
3907 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3908
3909 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3910
3911 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3912 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3913
989bf368
JB
39142011-06-05 Juanma Barranquero <lekktu@gmail.com>
3915
3916 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3917
4b80f674
CY
39182011-06-04 Chong Yidong <cyd@stupidchicken.com>
3919
3920 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3921 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3922 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3923 New error handlers.
4b80f674
CY
3924 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3925 Obey Vx_select_enable_clipboard_manager. Catch errors in
3926 x_clipboard_manager_save (Bug#8779).
3927 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3928 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3929
99a33b77 39302011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3931
3932 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3933
99a33b77 39342011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3935
3936 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3937 in the current matrix if keep_current_p is non-zero.
3938
8264569d
EZ
39392011-06-04 Eli Zaretskii <eliz@gnu.org>
3940
3941 * bidi.c (bidi_level_of_next_char): Fix last change.
3942
57f97249
EZ
39432011-06-03 Eli Zaretskii <eliz@gnu.org>
3944
fec2107c 3945 Support bidi reordering of text covered by display properties.
57f97249 3946
fec2107c
EZ
3947 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3948 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3949 (bidi_cache_search, bidi_cache_iterator_state)
3950 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3951 (bidi_level_of_next_char, bidi_move_to_visually_next):
3952 Support character positions inside a run of characters covered by a
fec2107c
EZ
3953 display string.
3954 (bidi_paragraph_init, bidi_resolve_explicit_1)
3955 (bidi_level_of_next_char): Call bidi_fetch_char and
3956 bidi_fetch_char_advance instead of FETCH_CHAR and
3957 FETCH_CHAR_ADVANCE.
3958 (bidi_init_it): Initialize new members.
3959 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3960 definitions.
3961 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3962 instead of using explicit *_CHAR codes.
d6d100dd
SM
3963 (bidi_resolve_explicit, bidi_resolve_weak):
3964 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3965 bidirectional text is supported only in multibyte buffers.
3966 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3967 it to initialize the frame_window_p member of struct bidi_it.
3968 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3969 (bidi_resolve_explicit, bidi_resolve_weak)
3970 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3971 bidi_it->nchars is non-positive.
3972 (bidi_level_of_next_char): Don't try to lookup the cache for the
3973 next/previous character if nothing is cached there yet, or if we
3974 were just reseat()'ed to a new position.
c40e2fb2 3975
0e14fe90
EZ
3976 * xdisp.c (set_cursor_from_row): Set start and stop points
3977 according to the row's direction when priming the loop that looks
3978 for the glyph on which to display cursor.
3979 (single_display_spec_intangible_p): Function deleted.
3980 (display_prop_intangible_p): Reimplement to call
3981 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3982 Accept 3 additional arguments needed by handle_display_spec.
3983 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3984 values: lists, `(when COND...)' forms, etc.
3985 (single_display_spec_string_p): Support property values that are
3986 lists with the argument STRING its top-level element.
3987 (display_prop_string_p): Fix the condition for processing a
3988 property that is a list to be consistent with handle_display_spec.
fec2107c 3989 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3990 last portion of handle_display_prop.
3991 (compute_display_string_pos): Accept additional argument
3992 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3993 value of a `display' property is a "replacing spec".
3994 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3995 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3996 the display property, but just return a value indicating whether
3997 the display property will replace the characters it covers.
3998 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3999 frame_window_p members of struct bidi_it.
d6d100dd
SM
4000 (compute_display_string_pos, compute_display_string_end):
4001 New functions.
fec2107c
EZ
4002 (push_it): Accept second argument POSITION, where pop_it should
4003 jump to continue iteration.
4004 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4005
fec2107c
EZ
4006 * keyboard.c (adjust_point_for_property): Adjust the call to
4007 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4008
4009 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4010 (bidi_init_it): Update prototypes.
4011 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4012 (compute_display_string_pos, compute_display_string_end):
4013 Declare prototypes.
fec2107c
EZ
4014 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4015 EMACS_INT.
fc6f18ce 4016
40087514 40172011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4018
57f53182
PE
4019 Malloc failure behavior now depends on size of allocation.
4020 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4021 * lisp.h: Change signatures accordingly.
4022 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4023 All callers changed. (Bug#8762)
4024
4025 * gnutls.c: Use Emacs's memory allocators.
4026 Without this change, the gnutls library would invoke malloc etc.
4027 directly, which causes problems on non-SYNC_INPUT hosts, and which
4028 runs afoul of improving memory_full behavior. (Bug#8761)
4029 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4030 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4031 xfree instead of the default malloc, realloc, free.
4032 (Fgnutls_boot): No need to check for memory allocation failure,
4033 since xmalloc does that for us.
4034
ac32cd99 4035 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4036 * category.c (hash_get_category_set):
4037 * ccl.c (ccl_driver):
4038 * charset.c (Fdefine_charset_internal):
4039 * charset.h (struct charset.hash_index):
4040 * composite.c (get_composition_id, gstring_lookup_cache)
4041 (composition_gstring_put_cache):
4042 * composite.h (struct composition.hash_index):
4043 * dispextern.h (struct image.hash):
4044 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4045 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4046 (hashfn_equal, hashfn_user_defined, make_hash_table)
4047 (maybe_resize_hash_table, hash_lookup, hash_put)
4048 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4049 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4050 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4051 * image.c (make_image, search_image_cache, lookup_image)
4052 (xpm_put_color_table_h):
4053 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 4054 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 4055 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 4056 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
4057 * alloc.c (allocate_vectorlike):
4058 Check for overflow in vector size calculations.
4059 * ccl.c (ccl_driver):
4060 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
4061 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4062 need to be updated by these changes.
40087514
PE
4063 * fns.c (make_hash_table, maybe_resize_hash_table):
4064 Check for integer overflow with large hash tables.
0de4bb68
PE
4065 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4066 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4067 (SXHASH_REDUCE): New macro.
4068 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4069 Use it instead of discarding useful hash info with large hash values.
4070 (sxhash_float): New function.
4071 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4072 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
4073 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4074 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
4075 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4076 Adjust signatures to match updated version of code.
4077 (consing_since_gc): Now EMACS_INT, since a single hash table can
4078 use more than INT_MAX bytes.
4079
698d32e2
DN
40802011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4081
4082 Make it possible to build with GCC-4.6+ -O2 -flto.
4083
4084 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4085
fd6fa53f
SM
40862011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4087
4088 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4089 Call minibuffer-inactive-mode.
4090
864db017
JB
40912011-05-31 Juanma Barranquero <lekktu@gmail.com>
4092
4093 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4094 Update dependencies.
4095
2ad0baf4
DN
40962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4097
4098 * data.c (init_data): Remove code for UTS, this system is not
4099 supported anymore.
4100
4fcc2638
DN
41012011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4102
4103 Don't force ./temacs to start in terminal mode.
4104
4105 * frame.c (make_initial_frame): Initialize faces in all cases, not
4106 only when CANNOT_DUMP is defined.
4107 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4108
c56e0fd5
DN
41092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4110
4111 * dispnew.c (add_window_display_history): Use const for the string
4112 pointer. Remove declaration, not needed.
4113
333d54da 41142011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 4115
55d4c1b2 4116 Use 'inline', not 'INLINE'.
333d54da 4117 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
4118 * alloc.c, fontset.c (INLINE): Remove.
4119 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4120 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4121 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4122 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4123 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4124
738db178
DN
41252011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4126
4127 Make it possible to run ./temacs.
4128
4129 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4130 syms_of_callproc does the same thing. Remove test for
4131 "initialized", do it in the caller.
4132 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4133
620c53a6
SM
41342011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4135
4136 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4137 (read_minibuf): Use get_minibuffer.
4138 (syms_of_minibuf): Use DEFSYM.
4139 (Qmetadata): New var.
4140 * data.c (Qbuffer): Don't make it static.
4141 (syms_of_data): Use DEFSYM.
4142
e003a292
PE
41432011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4144
4145 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4146 (CCL_CODE_MIN): New macro.
4147
ed008a6d
PE
41482011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4149
3687c2ef
PE
4150 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4151
ed008a6d
PE
4152 * eval.c (Qdebug): Now static.
4153 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4154 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4155 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4156
d66c4c7c
CY
41572011-05-29 Chong Yidong <cyd@stupidchicken.com>
4158
4159 * image.c: Various fixes to ImageMagick code comments.
4160 (Fimagemagick_types): Doc fix.
4161
5fbc2025
PE
41622011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4163
0196f88a
PE
4164 Minor fixes prompted by GCC 4.6.0 warnings.
4165
4166 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4167
5fbc2025
PE
4168 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4169 (x_clipboard_manager_save_all): Move extern decl to ...
4170 * xterm.h: ... here, so that it can be checked for consistency.
4171
1dd3c2d9
CY
41722011-05-29 Chong Yidong <cyd@stupidchicken.com>
4173
4174 * xselect.c (x_clipboard_manager_save_frame)
4175 (x_clipboard_manager_save_all): New functions.
4176 (Fx_clipboard_manager_save): Lisp function deleted.
4177
4178 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4179 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4180
4181 * xterm.h: Update prototype.
4182
5ba6571d
WX
41832011-05-28 William Xu <william.xwl@gmail.com>
4184
4185 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4186 exiting (Bug#8239).
4187
3eaff834
JM
41882011-05-28 Jim Meyering <meyering@redhat.com>
4189
e1900994 4190 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4191 * fns.c (to_uchar): Define.
4192 (crypto_hash_function): Use it to convert some newly-signed
4193 variables to unsigned, to avoid sign-extension bugs. For example,
4194 without this change, (md5 "truc") would evaluate to
4195 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4196 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4197 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4198
0f6990a7
PE
41992011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4200
4201 Integer overflow fixes.
c8a9ca5a 4202
08686060
PE
4203 * dbusbind.c: Serial number integer overflow fixes.
4204 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4205 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4206 to hold a serial number that is too large for a fixnum.
4207 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4208 Check for serial numbers out of range. Decode any serial number
59568bf0 4209 that was so large that it became a float. (Bug#8722)
08686060 4210
2d1fc3c7
PE
4211 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4212 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4213 Use XFASTINT rather than XUINT when numbers are nonnegative.
4214 (xd_append_arg, Fdbus_method_return_internal):
4215 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4216 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4217 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4218 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4219 (Bug#8722)
2d1fc3c7 4220
c8a9ca5a
PE
4221 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4222
519e1d69
PE
4223 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4224
30569699
PE
4225 ccl: add integer overflow checks
4226 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4227 (IN_INT_RANGE): New macros.
4228 (ccl_driver): Use them to check for integer overflow when
4229 decoding a CCL program. Many of the new checks are whether XINT (x)
4230 fits in int; it doesn't always, on 64-bit hosts. The new version
4231 doesn't catch all possible integer overflows, but it's an
847044ea 4232 improvement. (Bug#8719)
30569699 4233
c11285dc
PE
4234 * alloc.c (make_event_array): Use XINT, not XUINT.
4235 There's no need for unsigned here.
4236
fdccd48e
PE
4237 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4238 This follows up to the 2011-05-06 change that substituted uintptr_t
4239 for EMACS_INT. This case wasn't caught back then.
4240
37910ab2
PE
4241 Rework Fformat to avoid integer overflow issues.
4242 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4243 now (part of C89). Include <verify.h>.
4244 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4245 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4246 (Fformat): Avoid the prepass trying to compute sizes; it was only
4247 approximate and thus did not catch overflow reliably. Instead, walk
4248 through the format just once, formatting and computing sizes as we go,
4249 checking for integer overflow at every step, and allocating a larger
4250 buffer as needed. Keep track separately whether the format is
4251 multibyte. Keep only the most-recently calculated precision, rather
4252 than them all. Record whether each argument has been converted to
4253 string. Use EMACS_INT, not int, for byte and char and arg counts.
4254 Support field widths and precisions larger than INT_MAX. Avoid
4255 sprintf's undefined behavior with conversion specifications such as %#d
4256 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4257 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4258 formatting out-of-range floating point numbers with int
9173deec 4259 formats. (Bug#8668)
37910ab2 4260
2e6578fb
PE
4261 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4262
0ae6bdee
PE
4263 * data.c: Avoid integer truncation in expressions involving floats.
4264 * data.c: Include <intprops.h>.
4265 (arith_driver): When there's an integer overflow in an expression
4266 involving floating point, convert the integers to floating point
4267 so that the resulting value does not suffer from catastrophic
4268 integer truncation. For example, on a 64-bit host (* 4
4269 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4270 Do not rely on undefined behavior after integer overflow.
4271
de883a70
PE
4272 merge count_size_as_multibyte, parse_str_to_multibyte
4273 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4274 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4275 Check for integer overflow.
4276 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4277 since it's now a duplicate of the other. This is more of
4278 a character than a buffer op, so better that it's in character.c.
4279 * fns.c, print.c: Adjust to above changes.
4280
2ff916cb
PE
42812011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4282
4283 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4284
f1b54466
PE
42852011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4286
fb1ac845
PE
4287 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4288 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4289 (x_clipboard_manager_save): Now static.
4290 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4291
f1b54466
PE
4292 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4293 (crypto_hash_function): Now static.
4294 Fix pointer signedness problems. Avoid unnecessary initializations.
4295
a9f737ee
CY
42962011-05-27 Chong Yidong <cyd@stupidchicken.com>
4297
4298 * termhooks.h (Vselection_alist): Make it terminal-local.
4299
4300 * terminal.c (create_terminal): Initialize it.
4301
4302 * xselect.c: Support for clipboard managers.
4303 (Vselection_alist): Move to termhooks.h as terminal-local var.
4304 (LOCAL_SELECTION): New macro.
4305 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4306 (symbol_to_x_atom): Remove gratuitous arg.
4307 (x_handle_selection_request, lisp_data_to_selection_data)
4308 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4309 (x_own_selection, x_get_local_selection, x_convert_selection):
4310 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4311 (some_frame_on_display): Delete unused function.
4312 (Fx_own_selection_internal, Fx_get_selection_internal)
4313 (Fx_disown_selection_internal, Fx_selection_owner_p)
4314 (Fx_selection_exists_p): New optional frame arg.
4315 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4316 (x_handle_selection_clear): Don't treat other terminals with the
4317 same keyboard specially. Use the terminal-local Vselection_alist.
4318 (x_clear_frame_selections): Use Frun_hook_with_args.
4319
4320 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4321
4322 * xterm.h: Add support for those atoms.
4323
e067f0c1
CY
43242011-05-26 Chong Yidong <cyd@stupidchicken.com>
4325
4326 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4327 (converted_selections, conversion_fail_tag): New global variables.
4328 (x_selection_request_lisp_error): Free the above.
4329 (x_get_local_selection): Remove unnecessary code.
4330 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4331 of converted selections stored in converted_selections.
4332 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4333 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4334 (x_convert_selection): New function.
4335 (x_handle_selection_event): Simplify.
4336 (x_get_foreign_selection): Don't ignore incoming requests while
4337 waiting for an answer; this will fail when we implement
4338 SAVE_TARGETS, and seems unnecessary anyway.
4339 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4340 (Vx_sent_selection_functions): Doc fix.
4341
0f4aebc0
LL
43422011-05-26 Leo Liu <sdl.web@gmail.com>
4343
4344 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4345
e61124cd
YM
43462011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4347
4348 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4349
4350 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4351 for fringe update if it has periodic bitmap.
ac389d0c 4352 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4353 and fringe_bitmap_periodic_p.
4354
4355 * fringe.c (get_fringe_bitmap_data): New function.
4356 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4357 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4358 row. Mark glyph row for fringe update if periodicity changed.
4359
4360 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4361 for fringe update unless it has periodic bitmap.
4362
f16d9837
KH
43632011-05-25 Kenichi Handa <handa@m17n.org>
4364
4365 * xdisp.c (get_next_display_element): Set correct it->face_id for
4366 a static composition.
4367
e1b90ef6
LL
43682011-05-24 Leo Liu <sdl.web@gmail.com>
4369
4370 * deps.mk (fns.o):
4371 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4372
4373 * fns.c (crypto_hash_function, Fsha1): New function.
4374 (Fmd5): Use crypto_hash_function.
4375 (syms_of_fns): Add Ssha1.
4376
7400048f
PE
43772011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4378
4379 * gnutls.c: Remove unused macros.
4380 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4381 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4382 Remove macros that are defined and never used.
4383 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4384
abb71cf4
CY
43852011-05-22 Chong Yidong <cyd@stupidchicken.com>
4386
4387 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4388 (Fx_get_selection_internal): Minor cleanup.
4389 (Fx_own_selection_internal): Rename arguments for consistency with
4390 select.el.
4391
6307db39
PE
43922011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4393
4394 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4395
f3d4e0a4
CY
43962011-05-22 Chong Yidong <cyd@stupidchicken.com>
4397
4398 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4399
4d8ade89
YM
44002011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4401
4402 * dispnew.c (scrolling_window): Don't exclude the case that the
4403 last enabled row in the desired matrix touches the bottom boundary.
4404
32078c8d
GM
44052011-05-21 Glenn Morris <rgm@gnu.org>
4406
4407 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4408 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4409 and add some more files.
32078c8d 4410
7285dc67
EZ
44112011-05-20 Eli Zaretskii <eliz@gnu.org>
4412
4413 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4414 report_file_error introduced by the change from 2011-05-07.
4415
89d1bd22
PE
44162011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4417
4418 * systime.h (Time): Define only if emacs is defined.
4419 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4420 where the include path doesn't have X11/X.h by default. See
4421 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4422
e23640bb 44232011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4424
4425 * composite.c (find_automatic_composition): Fix previous change.
4426
b9704ad9
GM
44272011-05-20 Glenn Morris <rgm@gnu.org>
4428
4429 * lisp.mk: New file, split from Makefile.in.
4430 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4431 (shortlisp): Remove.
4432 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4433
4a720484
GM
44342011-05-19 Glenn Morris <rgm@gnu.org>
4435
4436 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4437 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4438 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4439 (lisp): Set the order to that of loadup.el.
4440 (shortlisp): Make it a copy of $lisp.
4441 (SOME_MACHINE_LISP): Remove.
4442 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4443 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4444
a28d4396
KH
44452011-05-18 Kenichi Handa <handa@m17n.org>
4446
4447 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4448 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4449 (find_automatic_composition): Mostly rewrite for efficiency.
4450
a2b1fa8e
JB
44512011-05-18 Juanma Barranquero <lekktu@gmail.com>
4452
4453 * makefile.w32-in: Update dependencies.
4454
8e1f5610
CS
44552011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4456
4457 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4458 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4459
7025ee00 44602011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4461
cdfa6eab
PE
4462 Fix some integer overflow issues, such as string length overflow.
4463
06d6db33
PE
4464 * insdel.c (count_size_as_multibyte): Check for string overflow.
4465
2b4560a8
PE
4466 * character.c (lisp_string_width): Check for string overflow.
4467 Use EMACS_INT, not int, for string indexes and lengths; in
4468 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4469 the resulting string length overflows an EMACS_INT; instead,
4470 report a string overflow if no precision given. When checking for
4471 precision exhaustion, use a check that cannot possibly have
4472 integer overflow. (Bug#8675)
4473 * character.h (lisp_string_width): Adjust to new signature.
4474
cb93f9be
PE
4475 * alloc.c (string_overflow): New function.
4476 (Fmake_string): Use it. This doesn't change behavior, but saves
4477 a few bytes and will simplify future changes.
4478 * character.c (string_escape_byte8): Likewise.
4479 * lisp.h (string_overflow): New decl.
4480
1a1f3366
PE
4481 Fixups, following up to the user-interface timestamp change.
4482 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4483 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4484 * msdos.c (mouse_get_pos): Likewise.
4485 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4486 * w32gui.h (Time): Define by including "systime.h" rather than by
4487 declaring it ourselves. (Bug#8664)
4488
d4e3e4d3
PE
4489 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4490 * image.c (clear_image_cache): Likewise.
4491
f6a24d19
PE
4492 * term.c (term_mouse_position): Don't assume time_t wraparound.
4493
08dc5ae6
PE
4494 Be more systematic about user-interface timestamps.
4495 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4496 and sometimes 'EMACS_UINT', to represent these timestamps.
4497 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4498 This makes the code easier to follow, and makes it easier to catch
4499 integer overflow bugs such as Bug#8664.
4500 * frame.c (Fmouse_position, Fmouse_pixel_position):
4501 Use Time, not unsigned long, for user-interface timestamps.
4502 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4503 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4504 * keyboard.h (last_event_timestamp): Likewise.
4505 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4506 * menu.h (xmenu_show): Likewise.
4507 * term.c (term_mouse_position): Likewise.
4508 * termhooks.h (struct input_event.timestamp): Likewise.
4509 (struct terminal.mouse_position_hook): Likewise.
4510 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4511 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4512 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4513 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4514 what it was before.
4515 * menu.h, termhooks.h: Include "systime.h", for Time.
4516
8e55734a
PE
4517 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4518 Don't assume that the difference between two unsigned long values
4519 can fit into an integer. At this point, we know button_down_time
4520 <= event->timestamp, so the difference must be nonnegative, so
4521 there's no need to cast the result if double-click-time is
4522 nonnegative, as it should be; check that it's nonnegative, just in
4523 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4524 apart (about 25 days). (Bug#8664)
8e55734a 4525
841f1b75 4526 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4527 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4528
3e26f69c
PE
4529 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4530 that always fit in int. Use a sentinel instead of a counter, to
4531 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4532 * frame.h (struct frame): Use int for menu_bar_items_used
4533 instead of EMACS_INT, since it always fits in int.
3e26f69c 4534
5cc152c0
PE
4535 * menu.c (grow_menu_items): Check for int overflow.
4536
d89eb65e
PE
4537 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4538
5235bd3e
PE
4539 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4540 Before, the code was not consistent. These values cannot exceed
4541 2**31 - 1 so there's no need to make them unsigned.
4542 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4543 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4544 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4545 as modifiers.
4546 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4547
bc827e23
PE
4548 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4549 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4550 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4551 presumably because the widths might not match.
4552
78eb494e
PE
4553 * window.c (size_window): Avoid needless test at loop start.
4554
04f2d78b
CB
45552011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4556
4557 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4558
d2fc7e3d 45592011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4560
4561 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4562
d2fc7e3d 45632011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4564
4565 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4566 `width' to `bar_area_x' and `bar_area_width', respectively.
4567 (x_scroll_run): Take account of fringe background extension.
4568
04f2d78b
CB
4569 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4570 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4571 `bar_area_width', respectively.
4572 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4573 background extension.
4574
79b70037
GM
45752011-05-10 Jim Meyering <meyering@redhat.com>
4576
4577 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4578
2f142cc5
JB
45792011-05-10 Juanma Barranquero <lekktu@gmail.com>
4580
4581 * image.c (Finit_image_library): Return t for built-in image types,
4582 like pbm and xbm. (Bug#8640)
4583
57679c86
AS
45842011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4585
4586 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4587
888c9e86
EZ
45882011-05-07 Eli Zaretskii <eliz@gnu.org>
4589
b0512a1d
EZ
4590 * w32console.c (Fset_screen_color): Doc fix.
4591 (Fget_screen_color): New function.
4592 (syms_of_ntterm): Defsubr it.
4593
7285dc67
EZ
4594 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4595 unlink the temporary file if Fcall_process didn't create it in the
4596 first place.
4597 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4598 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4599 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4600 cue to call_process_cleanup not to close that handle.
4601
4d3fcc8e
BK
46022011-05-07 Ben Key <bkey76@gmail.com>
4603
4604 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4605 one of two shell specific rules, either bootstrap-temacs-CMD or
4606 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4607 to the previous implementation of the bootstrap-temacs rule.
4608 The bootstrap-temacs-CMD rule is similar to the previous
4609 implementation of the bootstrap-temacs rule except that it
4610 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4611 variable.
4612
4613 These changes, along with some changes to nt/configure.bat,
4614 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4615 earlier fix to add support for --cflags and --ldflags options
4616 that include quotes so that it works whether make uses cmd or
4617 sh as the shell.
4618
b4289b64
MA
46192011-05-06 Michael Albinus <michael.albinus@gmx.de>
4620
4621 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4622 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4623 is a constant.
4624 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4625 a string. Handle both cases.
4626 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4627 (Fdbus_register_method): Use Qinvalid_function.
4628
af4c0e28
JB
46292011-05-06 Juanma Barranquero <lekktu@gmail.com>
4630
4631 * makefile.w32-in: Update dependencies.
4632 (LISP_H): Add inttypes.h and stdin.h.
4633 (PROCESS_H): Add unistd.h.
4634
c51453d9
EZ
46352011-05-06 Eli Zaretskii <eliz@gnu.org>
4636
4637 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4638 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4639
8ff0ac3c 46402011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4641
4c4b566b
PE
4642 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4643
aab2b9b5
PE
4644 * term.c (vfatal): Remove stray call to va_end.
4645 It's not needed and the C Standard doesn't allow it here anyway.
4646
c378da0b
PE
4647 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4648 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4649
288b08c7
PE
4650 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4651 bytes.
4652
e3601888
PE
4653 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4654
db6c0e74
PE
4655 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4656
dd5963ea
PE
4657 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4658
88c9450f
PE
4659 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4660
2f9442b8
PE
4661 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4662
c032b5f8
PE
4663 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4664 * charset.c (Fdefine_charset_internal): Don't initialize
4665 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4666 32-bit int (Bug#8600).
a108c10b
PE
4667
4668 * lread.c (read_integer): Be more consistent with string-to-number.
4669 Use string_to_number to do the actual conversion; this avoids
4670 rounding errors and fixes some other screwups. Without this fix,
4671 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4672 (digit_to_number): Move earlier, for benefit of read_integer.
4673 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4674 not a digit in any supported base. (Bug#8602)
a108c10b 4675
ad5f9eea
PE
4676 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4677
aec1708a
PE
4678 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4679 to match comment at start of function. This also removes a
4680 GCC warning about overflow in a 32+64-bit port.
4681
47be4ab5
PE
4682 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4683
371cac43
PE
4684 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4685 Reported by Stefan Monnier in
4686 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4687 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4688 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4689
d01a7826
PE
4690 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4691 (EMACS_UINTPTR): Likewise, with uintptr_t.
4692
7fd47d5c
PE
4693 * lisp.h: Prefer 64-bit EMACS_INT if available.
4694 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4695 on 32-bit hosts that have 64-bit int, so that they can access
4696 large files.
122b0c86
PE
4697 However, temporarily disable this change unless the temporary
4698 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4699
8727937b
PE
4700 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4701
8ac068ac
PE
4702 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4703 This removes an assumption that EMACS_INT and long are the same
4704 width as pointers. The assumption is true for Emacs porting targets
4705 now, but we want to make other targets possible.
4706 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4707 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4708 In the rest of the code, change types of integers that hold casted
4709 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4710 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4711 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4712 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4713 No need to cast type when ORing.
4714 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4715 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4716 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4717 assume EMACS_INT is the same width as char *.
4718 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4719 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4720 Remove no-longer-needed casts.
4721 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4722 (xg_tool_bar_help_callback, xg_make_tool_item):
4723 Use EMACS_INTPTR to hold an integer
4724 that will be cast to void *; this can avoid a GCC warning
4725 if EMACS_INT is not the same width as void *.
4726 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4727 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4728 (current_message_1, set_message_1):
4729 Use a local to convert to proper width without a cast.
4730 * xmenu.c (dialog_selection_callback): Likewise.
4731
ede49d71
PE
4732 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4733 Also, don't assume VALBITS / RAND_BITS is less than 5,
4734 and don't rely on undefined behavior when shifting a 1 left into
4735 the sign bit.
4736 * lisp.h (get_random): Change signature to match.
4737
2f30ecd0
PE
4738 * lread.c (hash_string): Use size_t, not int, for hash computation.
4739 Normally we prefer signed values; but hashing is special, because
4740 it's better to use unsigned division on hash table sizes so that
4741 the remainder is nonnegative. Also, size_t is the natural width
4742 for hashing into memory. The previous code used 'int', which doesn't
4743 retain enough info to hash well into very large tables.
4744 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4745
2a866e7b
PE
4746 * dbusbind.c: Don't possibly lose pointer info when converting.
4747 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4748 Use XPNTR rather than XHASH, so that the high-order bits of
4749 the pointer aren't lost when converting through void *.
4750
51639eac
PE
4751 * eval.c (Fautoload): Don't double-shift a pointer.
4752
92394119
PE
4753 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4754
dbdb9a7c
JB
47552011-05-06 Juanma Barranquero <lekktu@gmail.com>
4756
4757 * gnutls.c (DEF_GNUTLS_FN):
4758 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4759
db7a0b4f
AS
47602011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4761
4762 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4763 marker. (Bug#8610)
4764
f7ff1b0f 47652011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4766
4767 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4768 New version that can reserve upto 2GB of heap space.
4769
f7ff1b0f 47702011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4771
4772 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4773
639c109b
TZ
47742011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4775
4776 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4777 `gnutls_certificate_set_x509_key_file'.
4778
d2127135
JB
47792011-05-05 Juanma Barranquero <lekktu@gmail.com>
4780
4781 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4782 Update dependencies.
4783
e968f4f3
JB
47842011-05-04 Juanma Barranquero <lekktu@gmail.com>
4785
4786 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4787 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4788 Remove unused parameter `fildes'.
4789 * process.c (read_process_output, send_process): Don't pass it.
4790
84d358f0
JB
47912011-05-04 Juanma Barranquero <lekktu@gmail.com>
4792
4793 Fix previous change: the library cache is defined in w32.c.
4794 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4795 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4796
0898ca10
JB
47972011-05-04 Juanma Barranquero <lekktu@gmail.com>
4798
4799 Implement dynamic loading of GnuTLS on Windows.
4800
4801 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4802 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4803 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4804 Declare.
4805
4806 * gnutls.c (Qgnutls_dll): Define.
4807 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4808 (gnutls_*): Declare function pointers.
4809 (init_gnutls_functions): New function to initialize function pointers.
4810 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4811 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4812 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4813 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4814 (emacs_gnutls_write, emacs_gnutls_read)
4815 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4816 (Fgnutls_available_p): New function.
4817 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4818 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4819 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4820
4821 * image.c: Include w32.h.
4822 (Vimage_type_cache): Delete.
4823 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4824 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4825 (w32_delayed_load): Move to w32.c.
4826
4827 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4828
4829 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4830 (w32_delayed_load): Move from image.c. When loading a library, record
4831 its filename in the :loaded-from property of the library id.
4832 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4833 Initialize and staticpro them.
4834 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4835
4836 * process.c: Include lisp.h before w32.h, not after.
4837 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4838 instead of gnutls_record_check_pending.
4839
4840 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4841
ff4de4aa
TZ
48422011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4843
4844 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4845 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4846 as passed in.
4847
abe95abb
JD
48482011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4849
4850 * xterm.c (x_set_frame_alpha): Do not set property on anything
4851 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4852
e16e55d4
JB
48532011-05-02 Juanma Barranquero <lekktu@gmail.com>
4854
4855 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4856
bafcf6a5
JB
48572011-05-02 Juanma Barranquero <lekktu@gmail.com>
4858
4859 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4860 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4861 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4862 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4863 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4864 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4865 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4866 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4867 (Qgnutls_bootprop_callbacks_verify): Make static.
4868
e7a6747f
AS
48692011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4870
19ed11ba
AS
4871 * callproc.c: Indentation fixup.
4872
e7a6747f 4873 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4874 (wait_for_termination, interruptible_wait_for_termination):
4875 Move after wait_for_termination_1.
e7a6747f 4876
1ef14cb4
LMI
48772011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4878
4879 * sysdep.c (interruptible_wait_for_termination): New function
4880 which is like wait_for_termination, but allows keyboard
4881 interruptions.
4882
4883 * callproc.c (Fcall_process): Add (:file "file") as an option for
4884 the STDOUT buffer.
4885 (Fcall_process_region): Ditto.
4886
330d880c
EZ
48872011-04-30 Eli Zaretskii <eliz@gnu.org>
4888
8db90b73
EZ
4889 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4890 rather than `XVECTOR (FOO)->size'.
4891
330d880c
EZ
4892 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4893 inttypes.h, as a gnulib replacement is used if it not available in
4894 system headers.
4895
15cbd324
EZ
48962011-04-21 Eli Zaretskii <eliz@gnu.org>
4897
4898 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4899 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4900 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4901
4902 * coding.c (coding_alloc_by_realloc): Error out if destination
4903 will grow beyond MOST_POSITIVE_FIXNUM.
4904 (decode_coding_emacs_mule): Abort if there isn't enough place in
4905 charbuf for the composition carryover bytes. Reserve an extra
4906 space for up to 2 characters produced in a loop.
4907 (decode_coding_iso_2022): Abort if there isn't enough place in
4908 charbuf for the composition carryover bytes.
4909
49102011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4911
ae940cca
EZ
4912 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4913 aborting when %lld or %lll format is passed.
4914 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4915 %llo or %llx format is passed. (Bug#8545)
4916
03ab8921
EZ
4917 * window.c (window_scroll_line_based): Use a marker instead of
4918 simple variables to record original value of point. (Bug#7952)
4919
afda1437
EZ
4920 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4921 produced by %s or %c overflows available buffer space. (Bug#8545)
4922
f76dee0c
PE
49232011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4924
4925 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4926 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4927
fdc5744d
JB
49282011-04-28 Juanma Barranquero <lekktu@gmail.com>
4929
4930 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4931
638f053a
JB
49322011-04-28 Juanma Barranquero <lekktu@gmail.com>
4933
4934 * keyboard.c (Qdelayed_warnings_hook): Define.
4935 (command_loop_1): Run `delayed-warnings-hook'
4936 if Vdelayed_warnings_list is non-nil.
4937 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4938 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4939
d178f871
EZ
49402011-04-28 Eli Zaretskii <eliz@gnu.org>
4941
4942 * doprnt.c (doprnt): Don't return value smaller than the buffer
4943 size if the message was truncated. (Bug#8545).
4944
b124fd93
JB
49452011-04-28 Juanma Barranquero <lekktu@gmail.com>
4946
4947 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4948 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4949
e810457d
PE
49502011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4951
4952 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4953
ea51cceb
JB
49542011-04-27 Juanma Barranquero <lekktu@gmail.com>
4955
4956 * makefile.w32-in: Update dependencies.
4957
94dcfacf
EZ
49582011-04-27 Eli Zaretskii <eliz@gnu.org>
4959
4960 Improve `doprnt' and its usage. (Bug#8545)
4961 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4962 `format_end'. Remove support for %l as a conversion specifier.
4963 Don't use xrealloc. Improve diagnostics when the %l size modifier
4964 is used. Update the commentary.
4965
4966 * eval.c (verror): Simplify calculation of size_t.
4967
4968 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4969 messages.
4970
f61f41d7
PE
49712011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4972
4973 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4974 change.
4975
96fb4434
PE
49762011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4977
4978 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4979 This makes this file independent of the recent pseudovector change.
4980
671875da 49812011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4982
69e9b5a3
PE
4983 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4984
b5f869a7 4985 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4986 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4987 Remove unused local.
c8926152 4988 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4989
841a1577 4990 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4991 GCC 4.6.0 optimizes based on type-based alias analysis.
4992 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4993 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4994 != &v->size, and therefore "v->size = 1; b->size = 2; return
4995 v->size;" must therefore return 1. This assumption is incorrect
4996 for Emacs, since it type-puns struct Lisp_Vector * with many other
4997 types. To fix this problem, this patch adds a new type struct
f904488f 4998 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4999 and pseudovectors, and helps optimizing compilers not get fooled
5000 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5001 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5002 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5003 the size member.
eab3844f
PE
5004 (XSETPVECTYPE): Rewrite in terms of new macro.
5005 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5006 This is a bit clearer, and further avoids the possibility of
5007 undesirable aliasing.
5008 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5009 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5010 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5011 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5012 (ASIZE): Now uses header.size rather than size.
5013 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5014 to avoid the hassle of writing XVECTOR (foo)->header.size.
5015 (struct vectorlike_header): New type.
eab3844f
PE
5016 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5017 object, to help avoid aliasing.
5018 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5019 (SUBRP): Likewise, since Lisp_Subr is a special case.
5020 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5021 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5022 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5023 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5024 changed to be "header.size" and "header.next".
5025 * buffer.h (struct buffer): Likewise.
5026 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5027 * frame.h (struct frame): Likewise.
5028 * process.h (struct Lisp_Process): Likewise.
5029 * termhooks.h (struct terminal): Likewise.
5030 * window.c (struct save_window_data, struct saved_window): Likewise.
5031 * window.h (struct window): Likewise.
5032 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5033 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5034 * buffer.c (init_buffer_once): Likewise.
5035 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5036 special case.
5037 * process.c (Fformat_network_address): Use local var for size,
5038 for brevity.
5039
0df1eac5
PE
5040 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5041
847ab9d1 5042 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
5043 * data.c (atof): Remove decl; no longer used or needed.
5044 (digit_to_number): Move to lread.c.
5045 (Fstring_to_number): Use new string_to_number function, to be
5046 consistent with how the Lisp reader treats infinities and NaNs.
5047 Do not assume that floating-point numbers represent EMACS_INT
5048 without losing information; this is not true on most 64-bit hosts.
5049 Avoid double-rounding errors, by insisting on integers when
5050 parsing non-base-10 numbers, as the documentation specifies.
5051 * lisp.h (string_to_number): New decl, replacing ...
5052 (isfloat_string): Remove.
bc0a5c13 5053 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 5054 (read1): Do not accept +. and -. as integers; this
452f4150
PE
5055 appears to have been a coding error. Similarly, do not accept
5056 strings like +-1e0 as floating point numbers. Do not report
5057 overflow for integer overflows unless the base is not 10 which
5058 means we have no simple and reliable way to continue.
5059 Break out the floating-point parsing into a new
5060 function string_to_number, so that Fstring_to_number parses
5061 floating point numbers consistently with the Lisp reader.
04f2d78b 5062 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
5063 (E_CHAR, EXP_INT): Remove, replacing with ...
5064 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5065 (string_to_number): New function, replacing isfloat_string.
5066 This function checks for valid syntax and produces the resulting
5067 Lisp float number too. Rework it so that string-to-number
bc0a5c13 5068 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
5069 so that overflow for non-base-10 numbers is reported only when
5070 there's no portable and simple way to convert to floating point.
452f4150 5071
67769ffc
PE
5072 * textprop.c (set_text_properties_1): Rewrite for clarity,
5073 and to avoid GCC warning about integer overflow.
5074
c20db43f
PE
5075 * intervals.h (struct interval): Use EMACS_INT for members
5076 where EMACS_UINT might cause problems. See
5077 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5078 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5079 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5080 All uses changed.
37aa2f85
PE
5081 (offset_intervals): Tell GCC not to worry about length overflow
5082 when negating a negative length.
c20db43f 5083
2538aa2f
PE
5084 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5085 (overrun_check_free): Likewise.
5086
f2d3008d
PE
5087 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5088 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5089 word size.
5090
ec8df744
PE
5091 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5092 (gnutls_make_error): Rename local to avoid shadowing.
5093 (gnutls_emacs_global_deinit): ifdef out; not used.
5094 (Fgnutls_boot): Use const for pointer to readonly storage.
5095 Comment out unused local. Fix pointer signedness problems.
5096
640ee02d
PE
5097 * lread.c (openp): Don't stuff size_t into an 'int'.
5098 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5099 about possible signed overflow.
5100
6048fb2a
PE
5101 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5102 (GDK_KEY_g): Don't define if already defined.
5103 (xg_prepare_tooltip): Avoid pointer signedness problem.
5104 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5105
fa3c87e1
PE
5106 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5107 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5108
2172544b
PE
5109 * xfns.c (Fx_window_property): Simplify a bit,
5110 to make a bit faster and to avoid GCC 4.6.0 warning.
5111 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5112
9b821a21
PE
5113 * fns.c (internal_equal): Don't assume size_t fits in int.
5114
3c616cfa
PE
5115 * alloc.c (compact_small_strings): Tighten assertion a little.
5116
c2982e87
PE
5117 Replace pEd with more-general pI, and fix some printf arg casts.
5118 * lisp.h (pI): New macro, generalizing old pEd macro to other
5119 conversion specifiers. For example, use "...%"pI"d..." rather
5120 than "...%"pEd"...".
5121 (pEd): Remove. All uses replaced with similar uses of pI.
5122 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5123 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5124 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5125 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5126 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5127 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5128 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5129 64-bit hosts.
5130 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5131 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5132 * print.c (safe_debug_print, print_object): Likewise.
5133 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5134 to int.
6f04d126
PE
5135 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5136 avoiding the 0 flag, which is not portable.
c2982e87
PE
5137 * process.c (Fmake_network_process): Use pI to avoid cast.
5138 * region-cache.c (pp_cache): Likewise.
5139 * xdisp.c (decode_mode_spec): Likewise.
5140 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5141 behavior on 64-bit hosts with printf arg.
6f04d126 5142 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
5143 (x_stop_queuing_selection_requests): Likewise.
5144 (x_get_window_property): Don't truncate byte count to an 'int'
5145 when tracing.
0b432f21 5146
5e073ec7
PE
5147 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5148 here, since it parses constructs like leading '-' and spaces,
5149 which are not wanted; and it overflows with large numbers.
5150 Instead, simply match F[0-9]+, which is what is wanted anyway.
5151
36372bf9
PE
5152 * alloc.c: Remove unportable assumptions about struct layout.
5153 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5154 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5155 (allocate_vectorlike, make_pure_vector): Use the new macros,
5156 plus offsetof, to remove unportable assumptions about struct layout.
5157 These assumptions hold on all porting targets that I know of, but
5158 they are not guaranteed, they're easy to remove, and removing them
5159 makes further changes easier.
5160
0b432f21
PE
5161 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5162 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5163 (string_overrun_cookie): Now const. Use initializers that
5164 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5165 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5166 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5167 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5168 multiple of sizeof (EMACS_INT); it need not be, if
5169 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5170 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5171
895009e1
JB
51722011-04-26 Juanma Barranquero <lekktu@gmail.com>
5173
5174 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5175
6a7a1b0b
TZ
51762011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5177
5178 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5179 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5180 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5181
841a1577 51822011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5183
5184 * lisp.h (Qdebug): List symbol.
895009e1 5185 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5186 * keyboard.c (debug-on-event): New variable.
5187 (handle_user_signal): Break into debugger when debug-on-event
5188 matches the current signal symbol.
5189
f2d3ba6f
DN
51902011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5191
5192 * alloc.c (check_sblock, check_string_bytes)
5193 (check_string_free_list): Convert to standard C.
5194
42ce4c63
TZ
51952011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5196
5197 * w32.c (emacs_gnutls_push): Fix typo.
5198
825cd63c
EZ
51992011-04-25 Eli Zaretskii <eliz@gnu.org>
5200
fb11d64d
EZ
5201 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5202 "cast to pointer from integer of different size".
5203
825cd63c
EZ
5204 Improve doprnt and its use in verror. (Bug#8545)
5205 * doprnt.c (doprnt): Document the set of format control sequences
5206 supported by the function. Use SAFE_ALLOCA instead of always
5207 using `alloca'.
5208
5209 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5210 is one byte too soon. Don't use xrealloc; instead xfree and
5211 xmalloc anew.
5212
e061a11b
TZ
52132011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5214
5215 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5216 callbacks stage.
5217
5218 * gnutls.c: Renamed global_initialized to
5219 gnutls_global_initialized. Added internals for the
5220 :verify-hostname-error, :verify-error, and :verify-flags
5221 parameters of `gnutls-boot' and documented those parameters in the
5222 docstring. Start callback support.
9173deec
JB
5223 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5224 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5225 on error. Return error code.
e061a11b
TZ
5226 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5227 (emacs_gnutls_read): Likewise.
5228 (Fgnutls_boot): Return handshake error code.
5229 (emacs_gnutls_handle_error): New function.
5230 (wsaerror_to_errno): Likewise.
5231
5232 * w32.h (emacs_gnutls_pull): Add prototype.
5233 (emacs_gnutls_push): Likewise.
5234
5235 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5236 (emacs_gnutls_push): Likewise.
5237
52382011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5239
5240 * process.c (wait_reading_process_output): Check if GnuTLS
5241 buffered some data internally if no FDs are set for TLS
5242 connections.
5243
5244 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5245 (LIBS): Link to USER_LIBS.
5246 ($(BLD)/gnutls.$(0)): New target.
5247
fa6996bc
EZ
52482011-04-24 Eli Zaretskii <eliz@gnu.org>
5249
eb35682e
EZ
5250 * xdisp.c (handle_single_display_spec): Rename the
5251 display_replaced_before_p argument into display_replaced_p, to
5252 make it consistent with the commentary. Fix typos in the
5253 commentary.
5254
e2ad650c
EZ
5255 * textprop.c (syms_of_textprop): Remove dead code.
5256 (copy_text_properties): Delete obsolete commentary about an
5257 interface that was deleted long ago. Fix typos in the description
5258 of arguments.
5259
1b2de274
EZ
5260 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5261 to changes in oldXMenu/XMenu.h from 2011-04-16.
5262 <menu_help_message, prev_menu_help_message>: Constify.
5263 (IT_menu_make_room): menu->help_text is now `const char **';
5264 adjust.
5265
5266 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5267 to changes in oldXMenu/XMenu.h from 2011-04-16.
5268 (struct XMenu): Declare `help_text' `const char **'.
5269
5270 * xfaces.c <Qunspecified>: Make extern again.
5271
5272 * syntax.c: Include sys/types.h before including regex.h, as
5273 required by Posix.
5274
762b15be
EZ
5275 * doc.c (get_doc_string): Improve the format passed to `error'.
5276
5277 * doprnt.c (doprnt): Improve commentary.
5278
5279 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5280
5281 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5282 them with etags.
5283
f1052e5d
EZ
5284 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5285 changes in globals.h immediately force recompilation.
762b15be
EZ
5286 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5287 $(CURDIR)/s/ms-w32.h.
5288 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5289
fa6996bc
EZ
5290 * character.c (Fchar_direction): Function deleted.
5291 (syms_of_character): Don't defsubr it.
5292 <char-direction-table>: Deleted.
5293
e6c3da20
EZ
52942011-04-23 Eli Zaretskii <eliz@gnu.org>
5295
5296 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5297 * doprnt.c: Include limits.h.
5298 (SIZE_MAX): New macro.
04f2d78b
CB
5299 (doprnt): Return a size_t value. 2nd arg is now size_t.
5300 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5301 Improve overflow protection. Support `l' modifier for integer
5302 conversions. Support %l conversion. Don't assume an EMACS_INT
5303 argument for integer conversions and for %c.
5304
5305 * lisp.h (doprnt): Restore prototype.
5306
5307 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5308 $(SRC)/character.h.
5309
5310 * Makefile.in (base_obj): Add back doprnt.o.
5311
5312 * deps.mk (doprnt.o): Add back prerequisites.
5313 (callint.o): Depend on character.h.
5314
5315 * eval.c (internal_lisp_condition_case): Include the handler
5316 representation in the error message.
5317 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5318 when breaking from the loop.
5319
5320 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5321
5322 * callint.c (Fcall_interactively): When displaying error message
5323 about invalid control letter, pass the character's codepoint, not
5324 a pointer to its multibyte form. Improve display of the character
5325 in octal and display also its hex code.
5326
5327 * character.c (char_string): Use %x to display the (unsigned)
5328 codepoint of an invalid character, to avoid displaying a bogus
5329 negative value.
5330
5331 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5332 `error', not SYMBOL_NAME itself.
5333
5334 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5335 character arguments to `error'.
5336
5337 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5338 to `error' in error message about FINAL_CHAR argument. Make sure
5339 FINAL_CHAR is a character, and use %c when it is passed as
5340 argument to `error'.
5341
4ffd0d6b 53422011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5343
5344 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5345
5346 * w32.c: Include <time.h>.
5347 (sys_localtime): New function.
5348
4ffd0d6b 53492011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5350
5351 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5352
4ffd0d6b 5353 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5354
4ffd0d6b 53552011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5356
4ffd0d6b
GM
5357 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5358 zombies (Bug#8467).
aac0c6e3 5359
04c56954
EZ
53602011-04-19 Eli Zaretskii <eliz@gnu.org>
5361
5362 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5363 gl_state.e_property when gl_state.object is Qt.
5364
5365 * insdel.c (make_gap_larger): Remove limitation of buffer size
5366 to <= INT_MAX.
5367
16a43933
CY
53682011-04-18 Chong Yidong <cyd@stupidchicken.com>
5369
5370 * xdisp.c (lookup_glyphless_char_display)
5371 (produce_glyphless_glyph): Handle cons cell entry in
5372 glyphless-char-display.
5373 (Vglyphless_char_display): Document it.
5374
5375 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5376 glyphless-char-display.
5377
4581706e
CY
53782011-04-17 Chong Yidong <cyd@stupidchicken.com>
5379
5380 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5381
5382 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5383
5384 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5385 definition for no-X builds.
5386
4887c6e2 53872011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5388
fd35b6f9
PE
5389 Static checks with GCC 4.6.0 and non-default toolkits.
5390
5c1ccb01
PE
5391 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5392
006c5daa
PE
5393 * process.c (keyboard_bit_set): Define only if SIGIO.
5394 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5395 (send_process): Repair possible setjmp clobbering.
5396
efc736d3
PE
5397 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5398
4e2fe2e6
PE
5399 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5400
f97334a2
PE
5401 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5402
4e75f29d
PE
5403 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5404 Define only if needed.
5405
90efadd1
PE
5406 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5407 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5408 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5409
3c647824
PE
5410 * dispextern.h (struct redisplay_interface): Rename param
5411 to avoid shadowing.
e264f262 5412 * termhooks.h (struct terminal): Likewise.
761383f4 5413 * xterm.c (xembed_send_message): Likewise.
3c647824 5414
b58c5c4a
PE
5415 * insdel.c (make_gap_smaller): Define only if
5416 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5417
cad59032
PE
5418 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5419 it.
5420
c339dc2e
PE
5421 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5422 so that we aren't warned about unused symbols.
5423
91a3e27b
PE
5424 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5425
399c71d3 5426 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5427
8ffc96f5
PE
5428 * xfns.c (x_real_positions): Mark locals as initialized.
5429
eef9bc79
PE
5430 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5431
098db9dd
PE
5432 * xterm.c: Fix problems found by static analysis with other toolkits.
5433 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5434 (x_dispatch_event): Declare static if USE_GTK, and
5435 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5436 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5437 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5438 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5439 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5440
eb18f6cc
PE
5441 * xmenu.c (menu_help_callback): Pointer type fixes.
5442 Use const pointers when pointing at readonly data. Avoid pointer
5443 signedness clashes.
5444 (FALSE): Remove unused macro.
5445 (update_frame_menubar): Remove unused decl.
5446
1fe72bf8
PE
5447 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5448
60d9e1db
PE
5449 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5450 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5451 (single_menu_item): Rename local to avoid shadowing.
5452
39261c26
PE
5453 * keyboard.c (make_lispy_event): Remove unused local var.
5454
018c5e19
PE
5455 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5456 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5457
63d2b86e
PE
5458 * bitmaps: Change bitmaps from unsigned char back to the X11
5459 compatible char. Avoid the old compiler warnings about
5460 out-of-range initializers by using, for example, '\xab' rather
5461 than 0xab.
5462
aefd87e1
PE
5463 * xgselect.c (xgselect_initialize): Check vs interface
5464 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5465
bf501fb9
PE
5466 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5467
e9829fdf
PE
5468 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5469 to read-only memory.
5470
1086c095
PE
5471 * fns.c (vector): Remove; this old hack is no longer needed.
5472
2baccd04 5473 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5474 Remove unused var.
dde42981 5475 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5476
72391843 5477 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5478
436c16df 5479 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5480 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5481 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5482
92bb796d 5483 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5484 (x_term_init): Remove local to avoid shadowing.
92bb796d 5485
764430a3 5486 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5487
5488 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5489 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5490
d1dfb56c
EZ
54912011-04-16 Eli Zaretskii <eliz@gnu.org>
5492
c4354cb4
EZ
5493 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5494
d1dfb56c
EZ
5495 Fix regex.c, syntax.c and friends for buffers > 2GB.
5496 * syntax.h (struct gl_state_s): Declare character position members
5497 EMACS_INT.
5498
5499 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5500
04f2d78b
CB
5501 * textprop.c (verify_interval_modification, interval_of):
5502 Declare arguments EMACS_INT.
d1dfb56c
EZ
5503
5504 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5505 EMACS_INT.
5506
5507 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5508
5509 * indent.c (Fvertical_motion): Local variable it_start is now
5510 EMACS_INT.
5511
5512 * regex.c (re_match, re_match_2, re_match_2_internal)
5513 (bcmp_translate, regcomp, regexec, print_double_string)
5514 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5515 (re_compile_pattern, re_exec): Declare arguments and local
5516 variables `size_t' and `ssize_t' and return values `regoff_t', as
5517 appropriate.
5518 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5519 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5520 <compile_stack_type>: `size' and `avail' are now `size_t'.
5521
5522 * regex.h <regoff_t>: Use ssize_t, not int.
5523 (re_search, re_search_2, re_match, re_match_2): Arguments that
5524 specify buffer/string position and length are now ssize_t and
5525 size_t. Return type is regoff_t.
5526
613052cd
BK
55272011-04-16 Ben Key <bkey76@gmail.com>
5528
5529 * nsfont.m: Fixed bugs in ns_get_family and
5530 ns_descriptor_to_entity that were caused by using free to
5531 deallocate memory blocks that were allocated by xmalloc (via
5532 xstrdup). This caused Emacs to crash when compiled with
5533 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5534 --enable-checking=xmallocoverrun). xfree is now used to
5535 deallocate these memory blocks.
5536
4170f62f 55372011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5538
71b41406
PE
5539 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5540
9587a89d
PE
5541 emacs_write: Accept and return EMACS_INT for sizes.
5542 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5543 et seq.
5544 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5545 Accept and return EMACS_INT.
5546 (emacs_gnutls_write): Return the number of bytes written on
5547 partial writes.
5548 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5549 (emacs_read, emacs_write): Remove check for negative size, as the
5550 Emacs source code has been audited now.
9587a89d
PE
5551 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5552 (emacs_read, emacs_write): Use it.
273a5f82
PE
5553 * process.c (send_process): Adjust to the new signatures of
5554 emacs_write and emacs_gnutls_write. Do not attempt to store
5555 a byte offset into an 'int'; it might overflow.
9587a89d 5556 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5557
3e047f51
PE
5558 * sound.c: Don't assume sizes fit in 'int'.
5559 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5560 Return EMACS_INT, not int.
3e047f51 5561 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5562 Accept EMACS_INT, not int.
5563 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5564 record read return values.
5565
cc39a9db
BK
55662011-04-15 Ben Key <bkey76@gmail.com>
5567
c9d0ec6d
JB
5568 * keyboard.c (Qundefined): Don't declare static since it is used
5569 in nsfns.m.
5570 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5571 static since they are used in nsfont.m.
cc39a9db 5572
6c60eb9f
SM
55732011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5574
5575 * process.c (Qprocessp): Don't declare static.
5576 * lisp.h (Qprocessp): Declare again.
5577
7990b61a
JB
55782011-04-15 Juanma Barranquero <lekktu@gmail.com>
5579
5580 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5581
5d4cb038
PE
55822011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5583
8bd7b830 5584 Improve C-level modularity by making more things 'static'.
cd64ea1d 5585
e3b27b31
PE
5586 Don't publish debugger-only interfaces to other modules.
5587 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5588 (verify_bytepos, count_markers): Move decls to the only modules
5589 that need them.
5590 * region-cache.h (pp_cache): Likewise.
5591 * window.h (check_all_windows): Likewise.
5592 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5593
5d4cb038
PE
5594 * sysdep.c (croak): Now static, if
5595 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5596 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5597
5598 * alloc.c (refill_memory_reserve): Now static if
5599 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5600 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5601
e87b6180
PE
5602 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5603 Define only if USE_LUCID.
5604
ac64929e
PE
5605 * xrdb.c (x_customization_string, x_rm_string): Now static.
5606
6f37259d
PE
5607 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5608 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5609
1683e3ab
PE
5610 * xdisp.c (draw_row_with_mouse_face): Now static.
5611 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5612
de9c2632
PE
5613 * window.h (check_all_windows): Mark externally visible.
5614
2b96acb7
PE
5615 * window.c (window_deletion_count): Now static.
5616
5617 * undo.c: Make symbols static if they're not exported.
5618 (last_undo_buffer, last_boundary_position, pending_boundary):
5619 Now static.
5620
50436f33
PE
5621 * textprop.c (interval_insert_behind_hooks): Now static.
5622 (interval_insert_in_front_hooks): Likewise.
5623
64520e5c
PE
5624 * term.c: Make symbols static if they're not exported.
5625 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5626 (max_frame_lines, tty_set_terminal_modes):
5627 (tty_reset_terminal_modes, tty_turn_off_highlight):
5628 (get_tty_terminal): Now static.
5629 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5630 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5631 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5632 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5633 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5634
1fa53021
PE
5635 * sysdep.c: Make symbols static if they're not exported.
5636 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5637 Now static.
5638 (sigprocmask_set, full_mask): Remove; unused.
5639 (wait_debugging): Mark as visible.
5640 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5641 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5642
d4b43b22
PE
5643 * syntax.c (syntax_temp): Define only if !__GNUC__.
5644
b7c513d0
PE
5645 * sound.c (current_sound_device, current_sound): Now static.
5646
989b29ad
PE
5647 * search.c (searchbufs, searchbuf_head): Now static.
5648
13a55a78
PE
5649 * scroll.c (scroll_cost): Remove; unused.
5650 * dispextern.h (scroll_cost): Remove decl.
5651
de68a1fc
PE
5652 * region-cache.h (pp_cache): Mark as externally visible.
5653
40ccffa6
PE
5654 * process.c: Make symbols static if they're not exported.
5655 (process_tick, update_tick, create_process, chan_process):
5656 (Vprocess_alist, proc_buffered_char, datagram_access):
5657 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5658 (deactivate_process): Mark defn as static, as well as decl.
5659 * lisp.h (create_process): Remove decl.
5660 * process.h (chan_process, Vprocess_alist): Remove decls.
5661
ad64fc97
PE
5662 * print.c: Make symbols static if they're not exported.
5663 (print_depth, new_backquote_output, being_printed, print_buffer):
5664 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5665 (print_interval, print_number_index, initial_stderr_stream):
5666 Now static.
5667 * lisp.h (Fprinc): Remove decl.
5668 (debug_output_compilation_hack): Mark as externally visible.
5669
adddb265
PE
5670 * sysdep.c (croak): Move decl from here to syssignal.h.
5671 * syssignal.h (croak): Put it here, so the API can be checked when
5672 'croak' is called from dissociate_if_controlling_tty.
5673
1717ede2
PE
5674 * minibuf.c: Make symbols static if they're not exported.
5675 (minibuf_save_list, choose_minibuf_frame): Now static.
5676 * lisp.h (choose_minibuf_frame): Remove decl.
5677
fa5fb2bc
PE
5678 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5679
1e3890d1
PE
5680 * lread.c: Make symbols static if they're not exported.
5681 (read_objects, initial_obarray, oblookup_last_bucket_number):
5682 Now static.
5683 (make_symbol): Remove; unused.
5684 * lisp.h (initial_obarray, make_symbol): Remove decls.
5685
8a1414fa
PE
5686 * keyboard.c: Make symbols static if they're not exported.
5687 (single_kboard, recent_keys_index, total_keys, recent_keys):
5688 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5689 (this_single_command_key_start, echoing, last_auto_save):
5690 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5691 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5692 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5693 (Vlispy_mouse_stem, double_click_count):
5694 Now static.
5695 (force_auto_save_soon): Define only if SIGDANGER.
5696 (ignore_mouse_drag_p): Now static if
5697 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5698 (print_help): Remove; unused.
5699 (stop_character, last_timer_event): Mark as externally visible.
5700 * keyboard.h (ignore_mouse_drag_p): Declare only if
5701 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5702 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5703 * lisp.h (echoing): Remove decl.
5704 (force_auto_save_soon): Declare only if SIGDANGER.
5705 * xdisp.c (redisplay_window): Simplify code, to make it more
5706 obvious that ignore_mouse_drag_p is not accessed if !defined
5707 USE_GTK && !defined HAVE_NS.
5708
93ea6e8f
PE
5709 * intervals.c: Make symbols static if they're not exported.
5710 (merge_properties_sticky, merge_interval_right, delete_interval):
5711 Now static.
5712 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5713
77382fcc
PE
5714 * insdel.c: Make symbols static if they're not exported.
5715 However, leave prepare_to_modify_buffer alone. It's never
5716 called from outside this function, but that appears to be a bug.
5717 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5718 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5719 (adjust_after_replace_noundo): Remove; unused.
5720 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5721 (signal_before_change): Remove decls.
77382fcc 5722
9306c32e
PE
5723 * indent.c (val_compute_motion, val_vmotion): Now static.
5724
cd44d2eb
PE
5725 * image.c: Make symbols static if they're not exported.
5726 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5727 if USE_GTK.
5728 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5729 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5730
ad9a7a06
PE
5731 * fringe.c (standard_bitmaps): Now static.
5732 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5733
81626931
PE
5734 * frame.c: Make symbols static if they're not exported.
5735 (x_report_frame_params, make_terminal_frame): Now static.
5736 (get_frame_param): Now static, unless HAVE_NS.
5737 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5738 (x_get_resource_string): Remove; not used.
5739 * frame.h (make_terminal_frame, x_report_frame_params):
5740 (x_get_resource_string); Remove decls.
5741 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5742 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5743
239f9db9
PE
5744 * font.c, fontset.c: Make symbols static if they're not exported.
5745 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5746 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5747 * font.c (font_close_object): Now static.
5748 * font.h (font_close_object): Remove.
5749 * fontset.c (FONTSET_OBJLIST): Remove.
5750 (free_realized_fontset) #if-0 the body, which does nothing.
5751 (face_suitable_for_char_p): #if-0, as it's never called.
5752 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5753 * xfaces.c (face_at_string_position):
5754 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5755 since 0 is always ASCII.
5756
dfcf3579
PE
5757 * fns.c (weak_hash_tables): Now static.
5758
5045092b
PE
5759 * fileio.c: Make symbols static if they're not exported.
5760 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5761 (Vwrite_region_annotation_buffers): Now static.
5762
57a96f5c
PE
5763 * eval.c: Make symbols static if they're not exported.
5764 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5765 * lisp.h (backtrace_list): Remove decl.
5766
35f08c38
PE
5767 * emacs.c: Make symbols static if they're not exported.
5768 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5769 (fatal_error_code, fatal_error_signal_hook, standard_args):
5770 Now static.
5771 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5772 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5773 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5774 * lisp.h (fatal_error_signal_hook): Remove decl.
5775 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5776
f44bd759
PE
5777 * editfns.c: Move a (normally-unused) function to its only use.
5778 * editfns.c, lisp.h (get_operating_system_release): Remove.
5779 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5780 worth the hassle of breaking this out.
5781
b532497d
PE
5782 * xterm.c: Make symbols static if they're not exported.
5783 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5784 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5785 (x_destroy_window, x_delete_display):
5786 Now static.
5787 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5788 (x_mouse_leave): Remove; unused.
5789 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5790 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5791 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5792 Remove decls.
5793 (x_mouse_leave): Declare only if WINDOWSNT.
5794 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5795 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5796 USE_X_TOOLKIT.
5797
1675728f
PE
5798 * ftxfont.c: Make symbols static if they're not exported.
5799 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5800 HAVE_FREETYPE.
5801 * font.h (ftxfont_driver): Likewise.
5802
e4cebfca
PE
5803 * xfns.c: Make symbols static if they're not exported.
5804 (x_last_font_name, x_display_info_for_name):
5805 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5806 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5807 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5808 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5809 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5810 (last_show_tip_args): Now static.
5811 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5812 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5813 (x_screen_planes): Remove; unused.
5814 * dispextern.h (x_screen_planes): Remove decl.
5815
5bf46f05
PE
5816 * dispnew.c: Make symbols static if they're not exported.
5817 * dispextern.h (redraw_garbaged_frames, scrolling):
5818 (increment_row_positions): Remove.
5819 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5820 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5821 Now static.
5822 (redraw_garbaged_frames): Remove; unused.
5823
435f4c28
PE
5824 * xfaces.c: Make symbols static if they're not exported.
5825 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5826 Remove decls.
5827 * xterm.h (defined_color): Remove decls.
5828 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5829 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5830 (menu_face_changed_default, defined_color, free_realized_face):
5831 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5832 (ascii_face_of_lisp_face): Remove; unused.
5833
8524aef3
PE
5834 * xdisp.c: Make symbols static if they're not exported.
5835 * dispextern.h (scratch_glyph_row, window_box_edges):
5836 (glyph_to_pixel_coords, set_cursor_from_row):
5837 (get_next_display_element, set_iterator_to_next):
5838 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5839 (show_mouse_face): Remove decls
5840 * frame.h (message_buf_print): Likewise.
5841 * lisp.h (pop_message, set_message, check_point_in_composition):
5842 Likewise.
5843 * xterm.h (set_vertical_scroll_bar): Likewise.
5844 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5845 (message_buf_print, scratch_glyph_row, displayed_buffer):
5846 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5847 (get_next_display_element, show_mouse_face, window_box_edges):
5848 (frame_to_window_pixel_xy, check_point_in_composition):
5849 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5850 (glyph_to_pixel_coords): Remove; unused.
5851
16390cd2
PE
5852 * dired.c (file_name_completion): Now static.
5853
5854 * dbusbind.c (xd_in_read_queued_messages): Now static.
5855
a25f4dfa
PE
5856 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5857 * data.c (circular_list_error): Remove.
5858
14a9c8df
PE
5859 * commands.h (last_point_position, last_point_position_buffer):
5860 (last_point_position_window): Remove decls.
5861 * keyboard.c: Make these variables static.
5862
04f2d78b
CB
5863 * coding.h (coding, code_convert_region, encode_coding_gap):
5864 Remove decls.
74ab6df5
PE
5865 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5866 (iso_code_class, detect_coding, code_convert_region): Now static.
5867 (encode_coding_gap): Remove; unused.
5868
38dfbee1
PE
5869 * chartab.c (chartab_chars, chartab_bits): Now static.
5870
a2cb4e63
PE
5871 * charset.h (charset_iso_8859_1): Remove decl.
5872 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5873 Now static.
5874
127198fd
PE
5875 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5876 * ccl.c (Vccl_program_table): Now static.
5877 (check_ccl_update): Remove; unused.
5878
d85b608f
PE
5879 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5880 * category.h: ... from here.
5881 * category.c (check_category_table, set_category_set): Now static.
5882
31cd66f3
PE
5883 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5884 * lisp.h: Remove these decls.
5885
c358e587
PE
5886 * buffer.c (buffer_count): Remove unused var.
5887
e78aecca
PE
5888 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5889 so that it's not optimized away.
5890 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5891 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5892 exported only to the debugger.
5893
e192d7d3 5894 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5895 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5896
92470028
PE
5897 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5898 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5899 was inaccessible from Lisp.
5900 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5901 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5902
244ed907
PE
5903 alloc.c: Import and export fewer symbols, and remove unused items.
5904 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5905 is defined.
5906 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5907 it's not optimized away by whole-program optimization.
5908 (message_enable_multibyte, free_misc): Remove.
5909 (catchlist, handlerlist, mark_backtrace):
5910 Declare only if BYTE_MARK_STACK.
5911 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5912 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5913 (message_enable_multibyte): Remove decl.
5914 (free_misc, interval_free_list, float_block, float_block_index):
5915 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5916 (cons_free_list, last_marked_index):
5917 Now static.
5918 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5919 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5920 (mark_backtrace): Define only if BYTE_MARK_STACK.
5921 * xdisp.c (message_enable_multibyte): Now static.
5922
61c2b50e 5923 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5924 This makes it easier for human readers (and static analyzers)
5925 to see whether these variables are used from other modules.
5926 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5927 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5928 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5929 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5930 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5931 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5932 * xmenu.c, xselect.c:
5933 Declare Q* vars static if they are not used in other modules.
5934 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5935 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5936 Remove decls of unexported vars.
5937 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5938
95c82688
PE
5939 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5940
16a97296
PE
5941 Make Emacs functions such as Fatom 'static' by default.
5942 This makes it easier for human readers (and static analyzers)
5943 to see whether these functions can be called from other modules.
5944 DEFUN now defines a static function. To make the function external
5945 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5946 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5947 (Finit_image_library):
16a97296
PE
5948 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5949 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5950 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5951 Remove decls, since these functions are now static.
5952 (Funintern, Fget_internal_run_time): New decls, since these functions
5953 were already external.
95c82688 5954
16a97296
PE
5955 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5956 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5957 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5958 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5959 * keyboard.c, keymap.c, lread.c:
5960 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5961 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5962 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5963 Mark functions with DEFUE instead of DEFUN,
5964 if they are used in other modules.
5965 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5966 decls for now-static functions.
5967 * buffer.h (Fdelete_overlay): Remove decl.
5968 * callproc.c (Fgetenv_internal): Mark as internal.
5969 * composite.c (Fremove_list_of_text_properties): Remove decl.
5970 (Fcomposition_get_gstring): New forward static decl.
5971 * composite.h (Fcomposite_get_gstring): Remove decl.
5972 * dired.c (Ffile_attributes): New forward static decl.
5973 * doc.c (Fdocumntation_property): New forward static decl.
5974 * eval.c (Ffetch_bytecode): New forward static decl.
5975 (Funintern): Remove extern decl; now in .h file where it belongs.
5976 * fileio.c (Fmake_symbolic_link): New forward static decl.
5977 * image.c (Finit_image_library): New forward static decl.
5978 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5979 * intervals.h (Fprevious_property_change):
5980 (Fremove_list_of_text_properties): Remove decls.
5981 * keyboard.c (Fthis_command_keys): Remove decl.
5982 (Fcommand_execute): New forward static decl.
5983 * keymap.c (Flookup_key): New forward static decl.
5984 (Fcopy_keymap): Now static.
5985 * keymap.h (Flookup_key): Remove decl.
5986 * process.c (Fget_process): New forward static decl.
5987 (Fprocess_datagram_address): Mark as internal.
5988 * syntax.c (Fsyntax_table_p): New forward static decl.
5989 (skip_chars): Remove duplicate decl.
5990 * textprop.c (Fprevious_property_change): New forward static decl.
5991 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5992 Now internal.
5993 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5994 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5995
785bbd42
PE
5996 * editfns.c (Fformat): Remove unreachable code.
5997
8b913b57
AS
59982011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5999
6000 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6001 change. (Bug#8496)
6002
a6744a35
EZ
60032011-04-13 Eli Zaretskii <eliz@gnu.org>
6004
6005 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6006 when at ZV. (Bug#8487)
6007
e7974947
AS
60082011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6009
baad03f0
AS
6010 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6011 (Bug#8437)
6012 * keyboard.c (parse_tool_bar_item): Likewise.
6013 * sound.c (sound_cleanup, alsa_close): Likewise.
6014 * termcap.c (tgetent): Likewise.
6015 * xfns.c (x_default_font_parameter): Likewise.
6016 * xsettings.c (read_and_apply_settings): Likewise.
6017
e7974947
AS
6018 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6019 (overrun_check_free): Protoize.
6020
28272684
PE
60212011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6022
6023 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6024 since callers should never pass a negative size.
6025 Change the signature to match that of plain 'read' and 'write'; see
6026 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6027 * lisp.h: Update prototypes of emacs_write and emacs_read.
6028
11997c76
EZ
60292011-04-11 Eli Zaretskii <eliz@gnu.org>
6030
6031 * xdisp.c (redisplay_window): Don't try to determine the character
6032 position of the scroll margin if the window start point w->startp
e896f03c 6033 is outside the buffer's accessible region. (Bug#8468)
11997c76 6034
8a2cbd72
EZ
60352011-04-10 Eli Zaretskii <eliz@gnu.org>
6036
6037 Fix write-region and its subroutines for buffers > 2GB.
6038 * fileio.c (a_write, e_write): Modify declaration of arguments and
6039 local variables to support buffers larger than 2GB.
6040 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6041
6042 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6043 argument, local variables, and return value.
6044
6045 * lisp.h: Update prototypes of emacs_write and emacs_read.
6046
6047 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6048
4073e537 60492011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 6050
1ebfdcb6
PE
6051 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6052
b2ded58d
PE
6053 Fix more problems found by GCC 4.6.0's static checks.
6054
7d66342c
PE
6055 * xdisp.c (vmessage): Use a better test for character truncation.
6056
bbf47d44
PE
6057 * charset.c (load_charset_map): <, not <=, for optimization,
6058 and to avoid potential problems with integer overflow.
9248994d 6059 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 6060 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 6061 * editfns.c (Fformat): Likewise.
1e69125e 6062 * syntax.c (skip_chars): Likewise.
3befa583 6063
e3019616
PE
6064 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6065 This also lets GCC 4.6.0 generate slightly better loop code.
6066
becfa255
PE
6067 * callint.c (Fcall_interactively): <, not <=, for optimization.
6068 (Fcall_interactively): Count the number of arguments produced,
6069 not the number of arguments given. This is simpler and lets GCC
6070 4.6.0 generate slightly better code.
6071
dae0cd48
PE
6072 * ftfont.c: Distingish more carefully between FcChar8 and char.
6073 The previous code passed unsigned char * to a functions like
6074 strlen and xstrcasecmp that expect char *, which does not
6075 conform to the C standard.
6076 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6077 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6078 char * when the C standard requires it.
6079
76032d70
PE
6080 * keyboard.c (read_char): Remove unused var.
6081
eb3f1cc8
PE
6082 * eval.c: Port to Windows vsnprintf (Bug#8435).
6083 Include <limits.h>.
6084 (SIZE_MAX): Define if the headers do not.
6085 (verror): Do not give up if vsnprintf returns a negative count.
6086 Instead, grow the buffer. This ports to Windows vsnprintf, which
6087 does not conform to C99. Problem reported by Eli Zaretskii.
6088 Also, simplify the allocation scheme, by avoiding the need for
6089 calling realloc, and removing the ALLOCATED variable.
6090
70476b54
PE
6091 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6092
12020a9e
PE
6093 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6094 But keep the doprint source code for now, as we might revamp it
6095 and use it again (Bug#8435).
ea6c7ae6
PE
6096 * lisp.h (doprnt): Remove.
6097 * Makefile.in (base_obj): Remove doprnt.o.
6098 * deps.mk (doprnt.o): Remove.
6099
5fdb398c
PE
6100 error: Print 32- and 64-bit integers portably (Bug#8435).
6101 Without this change, on typical 64-bit hosts error ("...%d...", N)
6102 was used to print both 32- and 64-bit integers N, which relied on
6103 undefined behavior.
6104 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6105 New macro.
6106 * lisp.h (error, verror): Mark as printf-like functions.
6107 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6108 Report overflow in size calculations when allocating printf buffer.
6109 Do not truncate output string at its first null byte.
6110 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6111 Truncate the output at a character boundary, since vsnprintf does not
6112 do that.
6113 * charset.c (check_iso_charset_parameter): Convert internal
6114 character to string before calling 'error', since %c now has the
6115 printf meaning.
6116 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6117 overflow when computing char to be passed to 'error'. Do not
6118 pass Lisp_Object to 'error'; pass the integer instead.
6119 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6120 formatted with plain %d.
6121
b189fa66
PE
6122 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6123
bff87ef0
PE
6124 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6125
7e2cac20
PE
6126 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6127
ce4d90b5
PE
6128 * xterm.c (x_catch_errors): Remove duplicate declaration.
6129
266c9547
PE
6130 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6131
79c49ad2
PE
6132 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6133
368f4090
JM
61342011-04-10 Jim Meyering <meyering@redhat.com>
6135
6136 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6137 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6138 return ssize_t not "int", and use size_t as the buffer length.
6139 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6140 * gnutls.h: Update declarations.
6141 * process.c (read_process_output): Use ssize_t, to match.
6142 (send_process): Likewise.
6143
a32d4040
CY
61442011-04-09 Chong Yidong <cyd@stupidchicken.com>
6145
6146 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6147
8546720e 61482011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 6149
04f2d78b
CB
6150 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6151 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 6152
8546720e
GM
6153 * xterm.c (handle_one_xevent):
6154 * xmenu.c (create_and_show_popup_menu):
6155 * xselect.c (x_decline_selection_request)
6156 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 6157
0a2f5c1a 61582011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6159
6160 Fix some uses of `int' instead of EMACS_INT.
6161 * search.c (string_match_1, fast_string_match)
6162 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6163 (scan_buffer, find_next_newline_no_quit)
6164 (find_before_next_newline, search_command, Freplace_match)
6165 (Fmatch_data): Make some `int' variables be EMACS_INT.
6166
6167 * xdisp.c (display_count_lines): 3rd argument and return value now
6168 EMACS_INT. All callers changed.
6169 (pint2hrstr): Last argument is now EMACS_INT.
6170
6171 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6172 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6173 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6174 (decode_coding_utf_16, decode_coding_emacs_mule)
6175 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6176 (decode_coding_ccl, decode_coding_charset)
6177 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6178 (decode_coding_iso_2022, decode_coding_emacs_mule)
6179 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6180 <char_offset, last_offset>: Declare EMACS_INT.
6181 (encode_coding_utf_8, encode_coding_utf_16)
6182 (encode_coding_emacs_mule, encode_invocation_designation)
6183 (encode_designation_at_bol, encode_coding_iso_2022)
6184 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6185 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6186 Declare EMACS_INT.
6187 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6188 (encode_invocation_designation): Last argument P_NCHARS is now
6189 EMACS_INT.
6190 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6191 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6192
6193 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6194 All users changed.
6195
6196 * ccl.c (Fccl_execute_on_string): Declare some variables
6197 EMACS_INT.
6198
8546720e 61992011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6200
6201 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6202
4e19a977
CS
62032011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6204
6205 * process.c (Fformat_network_address): Doc fix.
6206
87302331
R
62072011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6208
6209 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6210
cbb59342
CY
62112011-04-08 Chong Yidong <cyd@stupidchicken.com>
6212
6213 * keyboard.c (read_char): Call Lisp function help-form-show,
6214 instead of using internal_with_output_to_temp_buffer.
6215 (Qhelp_form_show): New var.
e0d38eeb 6216 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6217
6218 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6219
6220 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6221
e67a13ab
CY
62222011-04-06 Chong Yidong <cyd@stupidchicken.com>
6223
04f2d78b
CB
6224 * process.c (Flist_processes): Remove to Lisp.
6225 (list_processes_1): Delete.
e67a13ab 6226
973f782d
EZ
62272011-04-06 Eli Zaretskii <eliz@gnu.org>
6228
7c106b1e
EZ
6229 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6230
973f782d
EZ
6231 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6232
41cf7d1a 62332011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6234
ca23cc88
PE
6235 Fix more problems found by GCC 4.6.0's static checks.
6236
f390e2d5
PE
6237 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6238
42eea0d0
PE
6239 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6240
b69769da 6241 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6242
f9541e84
PE
6243 * xdisp.c (vmessage): Mark as a printf-like function.
6244
13841b55
PE
6245 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6246
c136c10f
PE
6247 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6248
5e2d4a30
PE
6249 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6250 printf-like functions.
6251 (tiff_load): Add casts to remove these marks before passing them
6252 to system-supplied API.
6253
583f48b9
PE
6254 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6255
b25d760e
PE
6256 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6257 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6258 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6259 directly, rather than having caller test rule sign. This avoids
6260 some unnecessary tests.
6261 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6262 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6263 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6264
bc7b6697 6265 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6266 (xfont_open): Avoid unnecessary tests.
bc7b6697 6267
27ccc379
PE
6268 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6269
dcd5c89a
PE
6270 * composite.h, composite.c (composition_gstring_put_cache):
6271 Use EMACS_INT, not int, for length.
6272
b13a45c6
PE
6273 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6274 breaking out part of COMPOSITION_DECODE_RULE.
6275 (COMPOSITION_DECODE_RULE): Use it.
6276 * composite.c (get_composition_id): Remove unused local vars,
6277 by using the new macro.
6278
1e792e4d
PE
6279 * textprop.c (set_text_properties_1): Change while to do-while,
6280 since the condition is always true at first.
6281
dc6c6455 6282 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6283 (interval_deletion_adjustment): Return unsigned value.
6284 All uses changed.
dc6c6455 6285
aba7731a
PE
6286 * process.c (list_processes_1, create_pty, read_process_output):
6287 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6288 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6289 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6290 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6291 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6292
fdfc4bf3
PE
6293 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6294
fca8fe46 6295 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6296 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6297
06a0259a 6298 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6299 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6300 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6301
e7b9e80f
PE
6302 * print.c (print_error_message): Avoid int overflow.
6303
56201685
PE
6304 * font.c (font_list_entities): Redo for clarity,
6305 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6306
78834453 6307 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6308 (font_score): Avoid potential overflow in diff calculation.
78834453 6309
0bc0b309 6310 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6311 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6312
e610eaca
PE
6313 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6314
b895abce
PE
6315 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6316 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6317 can always succeed if overflow has undefined behavior.
6318
1f1d9321 6319 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6320 (wordify): Omit three unnecessary tests.
1f1d9321 6321
c59478bc
PE
6322 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6323 All callers changed. This avoids the need for an unused var.
6324
79b73827
PE
6325 * casefiddle.c (casify_region): Remove var that is set but not used.
6326
a4db5dfe
PE
6327 * dired.c (file_name_completion): Remove var that is set but not used.
6328
43aae36e
PE
6329 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6330
2a47c44d 6331 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6332 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6333
a37c69bf
PE
6334 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6335 Check for integer overflow on size calculations.
6336
328ab8e7
PE
6337 * buffer.c (Fprevious_overlay_change): Remove var that is set
6338 but not used.
6339
e5a2a5cb
PE
6340 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6341 Remove vars that are set but not used.
8d84a6eb 6342 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6343 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6344
a60e5f68
PE
6345 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6346
f661cb61 6347 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6348 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6349
f0397f5a
PE
6350 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6351 that are set but not used.
6352
8664db06 6353 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6354 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6355
6abdaa4a
PE
6356 * xselect.c (x_get_local_selection, x_handle_property_notify):
6357 Remove vars that are set but not used.
6358
0ce7538d 6359 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6360 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6361
9ae848fc
PE
6362 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6363 Remove var that is set but not used.
0b918413
PE
6364 (scroll_bar_windows_size): Now size_t, not int.
6365 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6366 Check for overflow.
9ae848fc 6367
a5a62657
PE
6368 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6369 (map_tty_color) [!defined MSDOS]: Likewise.
6370
5c5cdd39
PE
6371 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6372
66ebf983
PE
6373 * coding.c: Remove vars that are set but not used.
6374 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6375 All callers changed.
6376 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6377 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6378 (decode_coding_charset): Remove vars that are set but not used.
6379
1be4d761
PE
6380 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6381 that is set but not used.
6382
47553fa8
PE
6383 * print.c (print_object): Remove var that is set but not used.
6384
1f7196bf 6385 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6386 The gnulib version avoids calling malloc in the usual case,
6387 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6388 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6389 * filelock.c (current_lock_owner): Likewise.
6390 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6391 * sysdep.c: Include allocator.h, careadlinkat.h.
6392 (emacs_no_realloc_allocator): New static constant.
6393 (emacs_readlink): New function.
fdb61804
PE
6394 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6395 ../lib/careadlinkat.h.
d1fdcab7 6396
f84c17c7
SM
63972011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6398
6399 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6400 first non-nil return value).
6401
ef3862ad
JD
64022011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6403
6404 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6405 if not defined (Bug#8403).
6406
376a7006
JB
64072011-04-02 Juanma Barranquero <lekktu@gmail.com>
6408
6409 * xdisp.c (display_count_lines): Remove parameter `start',
6410 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6411 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6412 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6413 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6414 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6415 and thereabouts. All callers changed.
6416 (get_per_char_metric): Remove parameter `f', unused since
6417 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6418
6ca3801d
JM
64192011-04-02 Jim Meyering <meyering@redhat.com>
6420
6421 do not dereference NULL upon failed strdup
6422 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6423 (ns_get_family): Likewise.
6424
d8e2b5ba
JB
64252011-04-02 Juanma Barranquero <lekktu@gmail.com>
6426
6427 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6428
8c74fcbd
JD
64292011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6430
6431 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6432 later (Bug#8403).
6433
7200d79c
SM
64342011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6435
03408648 6436 Add lexical binding.
7200d79c 6437
03408648
SM
6438 * window.c (Ftemp_output_buffer_show): New fun.
6439 (Fsave_window_excursion):
6440 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6441
6442 * lread.c (lisp_file_lexically_bound_p): New function.
6443 (Fload): Bind Qlexical_binding.
6444 (readevalloop): Remove `evalfun' arg.
6445 Bind Qinternal_interpreter_environment.
6446 (Feval_buffer): Bind Qlexical_binding.
6447 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6448 Mark as dynamic.
6449 (syms_of_lread): Declare `lexical-binding'.
6450
6451 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6452
6453 * keyboard.c (eval_dyn): New fun.
6454 (menu_item_eval_property): Use it.
ca105506
SM
6455
6456 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6457
03408648
SM
6458 * fns.c (concat, mapcar1): Accept byte-code-functions.
6459
6460 * eval.c (Fsetq): Handle lexical vars.
6461 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6462 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6463 (FletX, Flet): Obey lexical binding.
6464 (Fcommandp): Handle closures.
6465 (Feval): New `lexical' arg.
6466 (eval_sub): New function extracted from Feval. Use it almost
6467 everywhere where Feval was used. Look up vars in lexical env.
6468 Handle closures.
6469 (Ffunctionp): Move from subr.el.
6470 (Ffuncall): Handle closures.
6471 (apply_lambda): Remove `eval_flags'.
6472 (funcall_lambda): Handle closures and new byte-code-functions.
6473 (Fspecial_variable_p): New function.
6474 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6475 but without exporting it to Lisp.
23aba0ea 6476
23aba0ea 6477 * doc.c (Fdocumentation, store_function_docstring):
03408648 6478 * data.c (Finteractive_form): Handle closures.
23aba0ea 6479
03408648
SM
6480 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6481 interactive spec.
ba83908c 6482
04f2d78b
CB
6483 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6484 New byte-codes.
03408648
SM
6485 (exec_byte_code): New function extracted from Fbyte_code to handle new
6486 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6487
03408648 6488 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6489
03408648 6490 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6491
e2abce01
JB
64922011-03-31 Juanma Barranquero <lekktu@gmail.com>
6493
6494 * xdisp.c (redisplay_internal): Fix prototype.
6495
63696a73 64962011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6497
63696a73 6498 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6499 (try_scrolling): Use it when setting scroll_limit.
6500 Limit scrolling to 100 screen lines.
63696a73
EZ
6501 (redisplay_window): Even when falling back on "recentering",
6502 position point in the window according to scroll-conservatively,
6503 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6504
6505 (try_scrolling): When point is above the window, allow searching
6506 as far as scroll_max, or one screenful, to compute vertical
6507 distance from PT to the scroll margin position. This prevents
6508 try_scrolling from unnecessarily failing when
6509 scroll-conservatively is set to a value slightly larger than the
6510 window height. Clean up the case of PT below the margin at bottom
6511 of window: scroll_max can no longer be INT_MAX. When aggressive
6512 scrolling is in use, don't let point enter the opposite scroll
6513 margin as result of the scroll.
6514 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6515 threshold of 100 lines for never-recentering scrolling.
6516
e4cc2dfc
JB
65172011-03-31 Juanma Barranquero <lekktu@gmail.com>
6518
6519 * dispextern.h (move_it_by_lines):
6520 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6521 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6522 (message_log_check_duplicate): Remove parameters `prev_bol' and
6523 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6524 (redisplay_internal): Remove parameter `preserve_echo_area',
6525 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6526
6527 * indent.c (Fvertical_motion):
6528 * window.c (window_scroll_pixel_based, Frecenter):
6529 Don't pass `need_y_p' to `move_it_by_lines'.
6530
1c470562
SM
65312011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6532
44f230aa
SM
6533 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6534 steal a few bits to be more compact.
6535 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6536 Remove unneeded casts.
6537
1c470562
SM
6538 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6539
888adce9
ZK
65402011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6541
6542 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6543 binding" message (bug#7967).
6544
f838ed7b
PE
65452011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6546
77861b95
PE
6547 Fix more problems found by GCC 4.6.0's static checks.
6548
de6dbc14
PE
6549 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6550 Remove unused local var.
6551
f838ed7b
PE
6552 * editfns.c (Fmessage_box): Remove unused local var.
6553
792c7b2b
PE
6554 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6555 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6556 Omit unused local vars.
c499e557 6557 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6558 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6559 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6560 Omit unused local var.
6561
ba0165e1
PE
6562 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6563 Don't assume string length fits in int.
32ad8845 6564 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6565 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6566
3c59b4c9
PE
6567 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6568 instead of alloca (Bug#8344).
6569
a3eed478 6570 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6571 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6572
eb4d412d
PE
6573 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6574
1658b401
PE
6575 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6576 concerns.
6577
6578 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6579
6580 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6581
9a2c6e05
PE
6582 * keyboard.c (syms_of_keyboard): Use the same style as later
6583 in this function when indexing through an array. This also
6584 works around GCC bug 48267.
6585
03d0a109
PE
6586 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6587
44f730c8
PE
6588 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6589
fe75f926
PE
6590 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6591 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6592
ffa8c828
PE
6593 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6594 This avoids undefined behavior on integer overflow, and is a bit
6595 more convenient anyway since it is compared to a size_t variable.
6596
c5101a77
PE
6597 Variadic C functions now count arguments with size_t, not int.
6598 This avoids an unnecessary limitation on 64-bit machines, which
6599 caused (substring ...) to crash on large vectors (Bug#8344).
6600 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6601 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6602 All variadic functions and their callers changed accordingly.
c5101a77
PE
6603 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6604 * data.c (arith_driver, float_arith_driver): Likewise.
6605 * editfns.c (general_insert_function): Likewise.
6606 * eval.c (struct backtrace.nargs, interactive_p)
6607 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6608 (funcall_lambda, mark_backtrace): Likewise.
6609 * fns.c (concat): Likewise.
6610 * frame.c (x_set_frame_parameters): Likewise.
6611 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6612 0 if not found, not -1. All callers changed.
6613
dd3f25f7
PE
6614 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6615 (stack_copy_size): Now size_t, not int.
6616 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6617
461c2ab9
JB
66182011-03-28 Juanma Barranquero <lekktu@gmail.com>
6619
6620 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6621 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6622 All callers changed.
6623
6624 * lisp.h (multibyte_char_to_unibyte):
6625 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6626 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6627 * character.h (CHAR_TO_BYTE8):
6628 * cmds.c (internal_self_insert):
6629 * editfns.c (general_insert_function):
6630 * keymap.c (push_key_description):
6631 * search.c (Freplace_match):
6632 * xdisp.c (message_dolog, set_message_1): All callers changed.
6633
f6d62986
SM
66342011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6635
6636 * keyboard.c (safe_run_hook_funcall): New function.
6637 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6638 don't set the hook to nil, but remove the offending function instead.
6639 (Qcommand_hook_internal): Remove, unused.
6640 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6641 Vcommand_hook_internal.
6642
6643 * eval.c (enum run_hooks_condition): Remove.
6644 (funcall_nil, funcall_not): New functions.
6645 (run_hook_with_args): Call each function through a `funcall' argument.
6646 Remove `cond' argument, now redundant.
6647 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6648 (Frun_hook_with_args_until_failure): Adjust accordingly.
6649 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6650
1db5b1ad
JB
66512011-03-28 Juanma Barranquero <lekktu@gmail.com>
6652
6653 * dispextern.h (string_buffer_position): Remove declaration.
6654
6655 * print.c (strout): Remove parameter `multibyte', unused since
6656 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6657
6658 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6659 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6660 All callers changed.
6661
6662 * w32.c (_wsa_errlist): Use braces for struct initializers.
6663
6664 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6665 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6666 All callers changed.
6667 (string_buffer_position): Likewise. Also, make static (it's never
6668 used outside xdisp.c).
6669 (cursor_row_p): Remove parameter `w', unused since
6670 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6671 (decode_mode_spec): Remove parameter `precision', introduced during
6672 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6673 All callers changed.
6674
5ffb62aa
JD
66752011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6676
6677 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6678
461c2ab9 66792011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6680
6681 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6682 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6683 (ns_update_auto_hide_menu_bar): New functions.
6684 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6685 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6686 ns_constrain_all_frames.
6687 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6688 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6689
5c380ffb
JD
66902011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6691
6692 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6693
9af30bdf
GM
66942011-03-27 Glenn Morris <rgm@gnu.org>
6695
6696 * syssignal.h: Replace RETSIGTYPE with void.
6697 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6698 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6699 Replace SIGTYPE with void everywhere.
6700 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6701 * s/template.h (SIGTYPE): Remove commented out definition.
6702
e2abce01
JB
67032011-03-26 Eli Zaretskii <eliz@gnu.org>
6704
6705 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6706 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6707
f868cd8a
JB
67082011-03-26 Juanma Barranquero <lekktu@gmail.com>
6709
59eb0929
JB
6710 * w32.c (read_unc_volume): Use parameter `henum', instead of
6711 global variable `wget_enum_handle'.
6712
6713 * keymap.c (describe_vector): Remove parameters `indices' and
6714 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6715 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6716
f868cd8a
JB
6717 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6718
6719 * keyboard.c (timer_check): Remove parameter `do_it_now',
6720 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6721 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6722 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6723
6724 * keyboard.c (read_char):
6725 * w32menu.c (w32_menu_display_help):
6726 * xmenu.c (show_help_event, menu_help_callback):
6727 Adjust calls to `show_help_echo'.
6728
6729 * gtkutil.c (xg_maybe_add_timer):
6730 * keyboard.c (readable_events):
6731 * process.c (wait_reading_process_output):
6732 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6733
6734 * insdel.c (adjust_markers_gap_motion):
6735 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6736 (gap_left, gap_right): Don't call it.
6737
2ecf6fdb
CY
67382011-03-25 Chong Yidong <cyd@stupidchicken.com>
6739
6740 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6741 incurred during fontification.
6742
6b1f9ba4
JB
67432011-03-25 Juanma Barranquero <lekktu@gmail.com>
6744
6745 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6746 (DEFVAR_PER_BUFFER): Don't pass it.
6747
6748 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6749 (scrolling_window): Don't pass it.
6750
0f4a96b5
JB
67512011-03-25 Juanma Barranquero <lekktu@gmail.com>
6752
6753 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6754
6755 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6756 and `suffix'.
6757 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6758 of variables specific to SELinux and computation of `encoded_absname'.
6759
6760 * image.c (XPutPixel): Remove unused variable `height'.
6761
6762 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6763
6764 * unexw32.c (get_section_info): Remove unused variable `section'.
6765
6766 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6767 (system_process_attributes): Remove unused variable `sess'.
6768 (sys_read): Remove unused variable `err'.
6769
6770 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6771 (w32_wnd_proc): Remove unused variable `isdead'.
6772 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6773 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6774 (x_create_tip_frame): Remove unused variable `tem'.
6775
6776 * w32inevt.c (w32_console_read_socket):
6777 Remove unused variable `no_events'.
6778
6779 * w32term.c (x_draw_composite_glyph_string_foreground):
6780 Remove unused variable `width'.
6781
1149507c
JB
67822011-03-24 Juanma Barranquero <lekktu@gmail.com>
6783
6784 * w32term.c (x_set_glyph_string_clipping):
6785 Don't pass uninitialized region to CombineRgn.
6786
9c88f339
JB
67872011-03-23 Juanma Barranquero <lekktu@gmail.com>
6788
6789 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6790 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6791 (Fx_close_connection): Remove unused variable `i'.
6792
6793 * w32font.c (w32font_draw): Return number of glyphs.
6794 (w32font_open_internal): Remove unused variable `i'.
6795 (w32font_driver): Add missing initializer.
6796
6797 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6798 (fill_in_menu): Remove unused variable `items_added'.
6799
6800 * w32term.c (last_mouse_press_frame): Remove static global variable.
6801 (w32_clip_to_row): Remove unused variable `f'.
6802 (x_delete_terminal): Remove unused variable `i'.
6803
6804 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6805 (NOTHING): Remove unused static global variable.
6806 (uniscribe_check_otf): Remove unused variable `table'.
6807 (uniscribe_font_driver): Add missing initializers.
6808
dee091a3
JD
68092011-03-23 Julien Danjou <julien@danjou.info>
6810
6811 * term.c (Fsuspend_tty, Fresume_tty):
6812 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6813 * window.c (temp_output_buffer_show):
6814 * insdel.c (signal_before_change):
6815 * frame.c (Fhandle_switch_frame):
6816 * fileio.c (Fdo_auto_save):
6817 * emacs.c (Fkill_emacs):
6818 * editfns.c (save_excursion_restore):
6819 * cmds.c (internal_self_insert):
6820 * callint.c (Fcall_interactively):
6821 * buffer.c (Fkill_all_local_variables):
6822 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6823 Use Frun_hooks.
0f4a96b5 6824 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6825 unconditionnaly since it does the check itself.
6826
2c520ab5 68272011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6828
c9c49752
PE
6829 Fix more problems found by GCC 4.5.2's static checks.
6830
8abc3f12
PE
6831 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6832 the first time through the loop, since we know p0 < p1 then.
6833 This also avoids a gcc -Wstrict-overflow warning.
6834
a2d26660
PE
6835 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6836 leading to a memory leak, possible in functions like
6837 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6838 of objects (Bug#8318).
a2d26660 6839
916c72e9
PE
6840 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6841 that could (at least in theory) be that large.
6842
19ab8a18
PE
6843 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6844 This is less likely to overflow, and avoids undefined behavior if
6845 overflow does occur. All callers changed. Use strtoul to scan
6846 for the unsigned long integer.
b7cbbd6f
PE
6847 (pint2hrstr): Simplify and tune code slightly.
6848 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6849
f0641eff
PE
6850 * scroll.c (do_scrolling): Work around GCC bug 48228.
6851 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6852
7f650bb9
PE
6853 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6854 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6855 (validate_x_resource_name): Simplify count usage.
6856 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6857
37dd57d1
PE
6858 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6859 fail (Bug#8306).
81e56e61 6860
699979fc 6861 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6862
401bf9b4
PE
6863 * process.c (Fmake_network_process): Use socklen_t, not int,
6864 where POSIX says socklen_t is required in portable programs.
6865 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6866 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6867 (Fmake_network_process, server_accept_connection):
6868 (wait_reading_process_output, read_process_output):
6869 Likewise.
6870
b93aacde
PE
6871 * process.c: Rename or move locals to avoid shadowing.
6872 (list_processes_1, Fmake_network_process):
6873 (read_process_output_error_handler, exec_sentinel_error_handler):
6874 Rename or move locals.
4dc343ee 6875 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6876 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6877 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6878 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6879 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6880
af8a867c 6881 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6882 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6883 Include tparam.h instead, since it declares them.
af8a867c
PE
6884 * cm.h (PC): Remove extern decl; tparam.h now does this.
6885 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6886 * terminfo.c: Include tparam.h, to check interfaces.
6887 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6888 (tparam): Adjust signature to match interface in tparam.h;
6889 this removes some undefined behavior. Check that outstring and len
6890 are zero, which they always are with Emacs.
6891 * tparam.h (PC, BC, UP): New extern decls.
6892
0248044d 6893 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6894 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6895
8ff096c1 6896 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6897 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6898 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6899 (ftfont_list): Remove unused local.
49eaafba
PE
6900 (get_adstyle_property, ftfont_pattern_entity):
6901 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6902 Rename locals to avoid shadowing.
8ff096c1 6903
e2be39f6
PE
6904 * xfont.c (xfont_list_family): Mark var as initialized.
6905
c9735e30
PE
6906 * xml.c (make_dom): Now static.
6907
8f5201ae
PE
6908 * composite.c (composition_compute_stop_pos): Rename local to
6909 avoid shadowing.
b246f932
PE
6910 (composition_reseat_it): Remove unused locals.
6911 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6912 (composition_update_it): Mark var as initialized.
11b61122
PE
6913 (find_automatic_composition): Mark vars as initialized,
6914 with a FIXME (Bug#8290).
8f5201ae 6915
760fbc2c
PE
6916 character.h: Rename locals to avoid shadowing.
6917 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6918 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6919 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6920 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6921 to avoid shadowing.
6922
ff08eb85
PE
6923 * textprop.c (property_change_between_p): Remove; unused.
6924
fc7bf025
PE
6925 * intervals.c (interval_start_pos): Now static.
6926
235d7abc
PE
6927 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6928
44f230aa
SM
6929 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6930 Rename locals to avoid shadowing.
3e7d6594 6931
50060332
PE
6932 * sound.c (wav_play, au_play, Fplay_sound_internal):
6933 Fix pointer signedness.
d01f234b 6934 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6935 (wav_play): Initialize a variable to 0, to prevent undefined
6936 behavior (Bug#8278).
50060332 6937
c4fc4e30
PE
6938 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6939
918436ed
PE
6940 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6941
c939f91b
PE
6942 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6943 clobbering (Bug#8298).
b9c7f648
PE
6944 * sysdep.c (sys_subshell): Likewise.
6945 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6946
6bd8c144
PE
6947 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6948 This should get cleaned up, so that child_setup has the
6949 same signature on all platforms.
6950
7710357c 6951 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6952 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6953
c59da222
CY
69542011-03-22 Chong Yidong <cyd@stupidchicken.com>
6955
6956 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6957 not to be necessary, and produces flickering.
6958
66b87493
GM
69592011-03-20 Glenn Morris <rgm@gnu.org>
6960
6961 * config.in: Remove file.
6962
45b6f6d5
JB
69632011-03-20 Juanma Barranquero <lekktu@gmail.com>
6964
6965 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6966 are now in src/globals.h.
6967 (syms_of_minibuf): Remove spurious & from previous change.
6968
3ec03f7e
LL
69692011-03-20 Leo <sdl.web@gmail.com>
6970
6971 * minibuf.c (completing-read-function): New variable.
6972 (completing-read-default): Rename from completing-read.
6973 (completing-read): Call completing-read-function.
6974
b14e3e21
CY
69752011-03-19 Juanma Barranquero <lekktu@gmail.com>
6976
6977 * xfaces.c (Fx_load_color_file):
6978 Read color file from absolute filename (bug#8250).
6979
f2b726e6
JB
69802011-03-19 Juanma Barranquero <lekktu@gmail.com>
6981
6982 * makefile.w32-in: Update dependencies.
6983
09f6ff02
EZ
69842011-03-17 Eli Zaretskii <eliz@gnu.org>
6985
6986 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6987
29a6015a
PE
69882011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6989
a3a6c54e
PE
6990 Fix more problems found by GCC 4.5.2's static checks.
6991
b766f867
PE
6992 * process.c (make_serial_process_unwind, send_process_trap):
6993 (sigchld_handler): Now static.
6994
be02381c
PE
6995 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6996 That way, the code declares only the vars that it needs.
6997 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6998 * s/cygwin.h (PTY_ITERATION): Likewise.
6999 * s/darwin.h (PTY_ITERATION): Likewise.
7000 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7001
57048744
PE
7002 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7003 * process.c (allocate_pty): Don't declare stb unless it's needed.
7004
7914961c 7005 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7006 (CONSTANTLIM): Remove; unused.
7007 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7008 Define only if needed.
7914961c 7009
b3967b18
PE
7010 * unexelf.c (unexec): Name an expression,
7011 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7012 Use a different way to cause a compilation error if anyone uses
7013 n rather than nn, a way that does not involve shadowing.
73366a00 7014 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7015
29a6015a
PE
7016 * deps.mk (unexalpha.o): Remove; unused.
7017
43cfc33e 7018 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7019 * unexec.h: New file.
ce701a33
PE
7020 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7021 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7022 Depend on unexec.h.
7023 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7024 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7025 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7026 Change as necessary to match prototype in unexec.h.
ce701a33 7027
01f44d5a
PE
7028 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7029 shadowing.
4f63c6bb 7030 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7031
a6670b0b
PE
7032 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7033 Rename locals to avoid shadowing.
7034
cef2010d 7035 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7036 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 7037
d4d7173a
PE
7038 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7039
f08b802a
PE
7040 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7041 warning when compiling print.c.
7042
3ddb0639
PE
7043 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7044 instead of using an uninitialized var.
5ad03b97 7045 (font_sort_entities): Mark var as initialized.
3ddb0639 7046
170a2692
PE
7047 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7048
e663c700
PE
7049 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7050 pointers to constants.
89bc529a 7051 (font_parse_fcname): Remove unused vars.
7b81e2d0 7052 (font_delete_unmatched): Now static.
ea838e10 7053 (font_get_spec): Remove; unused.
13a547c6
PE
7054 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7055 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7056 Rename or move locals to avoid shadowing.
e663c700 7057
2a80c887 7058 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 7059 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 7060
1384fa33 7061 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 7062 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 7063
8b2c52e9
PE
7064 * alloc.c (mark_backtrace): Move decl from here ...
7065 * lisp.h: ... to here, so that it can be checked.
7066
475545b5 7067 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 7068 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
7069 (lisp_indirect_variable): Name an expression,
7070 to avoid gcc -Wbad-function-cast warning.
1faed8ae 7071 (Fdefvar): Rename locals to avoid shadowing.
475545b5 7072
b1349114 7073 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 7074 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 7075 Use const pointer when appropriate.
b1349114 7076
a2928364
PE
7077 * lisp.h (get_system_name, get_operating_system_release):
7078 Move decls here, to check interfaces.
7079 * process.c (get_operating_system_release): Move decl to lisp.h.
7080 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
7081 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7082 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7083 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
7084 (Fformat_time_string, Fencode_time, Finsert_char):
7085 (Ftranslate_region_internal, Fformat):
7086 Rename or remove local vars to avoid shadowing.
9710023e 7087 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 7088
a415e694
PE
7089 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7090 avoid shadowing.
7091
8ef4622d
PE
7092 * lisp.h (eassert): Check that the argument compiles, even if
7093 ENABLE_CHECKING is not defined.
7094
946f9a5b
PE
7095 * data.c (Findirect_variable): Name an expression, to avoid
7096 gcc -Wbad-function-cast warning.
112396d6 7097 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 7098 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
7099 (Fmake_variable_buffer_local, Fmake_local_variable):
7100 Mark variables as initialized.
52746918 7101 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 7102
e5aab7e7 7103 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
7104 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7105 Rename locals to avoid shadowing.
dff45157
PE
7106 (mark_stack): Move local variables into the #ifdef region where
7107 they're used.
7bc26fdb
PE
7108 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7109 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7110 needed otherwise.
7111 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7112 (GC_STRING_CHARS): Remove; not used.
d40d4be1 7113 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 7114
e5aab7e7
PE
7115 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7116 avoids undefined behavior in theory.
7117
4da60324
PE
7118 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7119
88043301
PE
7120 Use functions, not macros, for up- and down-casing (Bug#8254).
7121 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7122 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7123 to use the following functions instead of these macros.
7124 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7125 EMACS_INT, since callers assume the returned value fits in int.
7126 (upcase1): Likewise, for UPCASE_TABLE.
7127 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 7128 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 7129 the race-condition problem in the old DOWNCASE.
88043301 7130
19ed5445
PE
7131 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7132 Rename locals to avoid shadowing.
7133 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
7134 (regex_compile, re_search_2, re_match_2_internal):
7135 Remove unused local vars.
952db0d7
PE
7136 (FREE_VAR): Rewrite so as not to use empty "else",
7137 which gcc can warn about.
da053e48 7138 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
7139 (RETALLOC_IF): Define only if needed.
7140 (WORDCHAR_P): Likewise. This one is never needed, but is used
7141 only in a comment talking about a compiler bug, so put inside
7142 the #if 0 of that comment.
7143 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7144 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7145 Remove; unused.
19ed5445 7146
1f3561e4 7147 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
7148 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7149 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 7150
ded6f8f7
PE
7151 * search.c (simple_search): Remove unused var.
7152
dbd37a95
PE
7153 * dired.c (compile_pattern): Move decl from here ...
7154 * lisp.h: ... to here, so that it can be checked.
7155 (struct re_registers): New forward decl.
7156
7e47afad
PE
7157 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7158
85f24f61
PE
7159 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7160 All uses changed.
7161 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7162 Rename locals to avoid shadowing.
5671df8f 7163 (Fvertical_motion): Mark locals as initialized.
85f24f61 7164
181aa2be 7165 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7166 (casify_region): Mark local as initialized.
181aa2be 7167
930d429c
PE
7168 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7169
7082eac6
PE
7170 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7171 New macros, so that the caller can use some names other than
7172 gcpro1, gcpro2, etc.
7173 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7174 of the new macros.
7175 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7176 argument, for consistency with GCPRO2_VAR, etc: it is now the
7177 prefix of the variable, not the variable itself. All uses
7178 changed.
38b2c076
PE
7179 * dired.c (directory_files_internal, file_name_completion):
7180 Rename locals to avoid shadowing.
7181
15206ed9
PE
7182 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7183 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7184 dired.c's scmp function, had undefined behavior.
7185 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7186 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7187 * buffer.h: ... to here, because these macros use current_buffer,
7188 and the new implementation with inline functions needs to have
7189 current_buffer in scope now, rather than later when the macros
7190 are used.
7191 (downcase, upcase1): New static inline functions.
7192 (DOWNCASE, UPCASE1): Reimplement using these functions.
7193 This avoids undefined behavior in expressions like
7194 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7195 from race conditions in accessing the global variables
7196 case_temp1 and case_temp2.
7197 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7198 * lisp.h (case_temp1, case_temp2): Remove their decls.
7199 * character.h (ASCII_CHAR_P): Move from here ...
7200 * lisp.h: ... to here, so that the inline functions mentioned
7201 above can use them.
7202
4a6bea26
PE
7203 * dired.c (directory_files_internal_unwind): Now static.
7204
f14b7e14
PE
7205 * fileio.c (file_name_as_directory, directory_file_name):
7206 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7207 Now static.
2893f146
PE
7208 (file_name_as_directory): Use const pointers when appropriate.
7209 (Fexpand_file_name): Likewise. In particular, newdir might
7210 point at constant storage, so make it a const pointer.
fd4ead52 7211 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7212 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7213 signedness issues.
f839df0c
PE
7214 (Fset_file_times, Finsert_file_contents, auto_save_error):
7215 Rename locals to avoid shadowing.
f14b7e14 7216
5716756e 7217 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7218 (Ftry_completion, Fall_completions): Rename or remove locals
7219 to avoid shadowing.
5716756e 7220
b4c3046a
PE
7221 * marker.c (bytepos_to_charpos): Remove; unused.
7222
b45db522
PE
7223 * lisp.h (verify_bytepos, count_markers): New decls,
7224 so that gcc does not warn that these functions aren't declared.
7225
85876d07
PE
7226 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7227 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7228 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7229 (copy_text): Remove unused local var.
85876d07 7230
03d78a21 7231 * filelock.c (within_one_second): Now static.
b3dd38ab 7232 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7233
5df8f01b
PE
7234 * buffer.c (fix_overlays_before): Mark locals as initialized.
7235 (fix_start_end_in_overlays): Likewise. This function should be
7236 simplified by using pointers-to-pointers, but that's a different
7237 matter.
b1d876f1 7238 (switch_to_buffer_1): Now static.
8f54f30a
PE
7239 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7240 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7241
a70072c9 7242 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7243 Fix pointer signedness issue.
edced198
PE
7244 (sys_subshell): Mark local as volatile if checking for lint,
7245 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7246 (MAXPATHLEN): Define only if needed.
a70072c9 7247
a0977c44
PE
7248 * process.c (serial_open, serial_configure): Move decls from here ...
7249 * systty.h: ... to here, so that they can be checked.
7250
a884fdcc
PE
7251 * fns.c (get_random, seed_random): Move extern decls from here ...
7252 * lisp.h: ... to here, so that they can be checked.
7253
604efe86 7254 * sysdep.c (reset_io): Now static.
b8950c94 7255 (wait_for_termination_signal): Remove; unused.
604efe86 7256
38fc62d9
PE
7257 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7258 (copy_keymap_item, append_key, push_text_char_description):
7259 Now static.
1004a21a 7260 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7261 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7262 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7263 (describe_map_tree):
7264 Rename locals to avoid shadowing.
38fc62d9 7265
2f2650da
PE
7266 * keyboard.c: Declare functions static if they are not used elsewhere.
7267 (echo_char, echo_dash, cmd_error, top_level_2):
7268 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7269 (read_char, kbd_buffer_get_event, make_lispy_position):
7270 (make_lispy_event, make_lispy_movement, apply_modifiers):
7271 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7272 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7273 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7274 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7275 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7276
a053e86c 7277 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7278 (mark_kboards): Move decl here ...
7279 * alloc.c (mark_kboards): ... from here.
a053e86c 7280
4752793e
PE
7281 * lisp.h (force_auto_save_soon): New decl.
7282
74f10ca7 7283 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7284 (DEFINE_DUMMY_FUNCTION): New macro.
7285 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7286 Use it.
c03cd23f
PE
7287 (main): Add casts to avoid warnings
7288 if GCC considers string literals to be constants.
74f10ca7 7289
022e70d4
PE
7290 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7291
59d6fe83
PE
7292 * dbusbind.c: Pointer signedness fixes.
7293 (xd_signature, xd_append_arg, xd_initialize):
7294 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7295 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7296 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7297 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7298
78320123
PE
7299 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7300 if GCC considers string literals to be constants.
49cebcca 7301 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7302
35ac2a97
SM
73032011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7304
fb103ca9
SM
7305 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7306 (print_preprocess, print_object): New macro to fix last change.
7307
35ac2a97
SM
7308 * print.c (print_preprocess): Don't forget font objects.
7309
62973b41
JB
73102011-03-16 Juanma Barranquero <lekktu@gmail.com>
7311
7312 * emacs.c (USAGE3): Doc fixes.
7313
0e48bb22
AS
73142011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7315
7316 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7317 structure.
7318
7684e57b
JB
73192011-03-14 Juanma Barranquero <lekktu@gmail.com>
7320
7321 * lisp.h (VWindow_system, Qfile_name_history):
7322 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7323 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7324 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7325
7326 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7327 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7328
7329 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7330 * w32console.c (detect_input_pending, read_input_pending)
7331 (encode_terminal_code):
7332 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7333 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7334 (w32_system_caret_y, Qfile_name_history):
7335 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7336 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7337 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7338 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7339 * w32proc.c (Qlocal, report_file_error):
7340 * w32term.c (Vwindow_system, updating_frame):
7341 * w32uniscribe.c (initialized, uniscribe_font_driver):
7342 Remove unneeded extern declarations.
7343
2aa46d6c
CY
73442011-03-14 Chong Yidong <cyd@stupidchicken.com>
7345
c96bbc66 7346 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7347
cffc6f3b
CY
73482011-03-13 Chong Yidong <cyd@stupidchicken.com>
7349
7350 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7351 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7352 These macros can no longer be used for assignment.
7353
44f230aa
SM
7354 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7355 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7356 (record_buffer_markers, fetch_buffer_markers): New functions for
7357 recording and fetching special buffer markers.
7358 (set_buffer_internal_1, set_buffer_temp): Use them.
7359
7360 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7361
7362 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7363
7364 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7365 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7366
7367 * xdisp.c (hscroll_window_tree):
7368 (reconsider_clip_changes): Use PT instead of BUF_PT.
7369
d251f04b
EZ
73702011-03-13 Eli Zaretskii <eliz@gnu.org>
7371
7372 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7373 $(EMACS_ROOT)/lib/intprops.h.
7374
f0c77cd1
PE
73752011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7376
3eca4629
PE
7377 Fix more problems found by GCC 4.5.2's static checks.
7378
7c86ee98
PE
7379 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7380 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7381 (xg_free_frame_widgets): Make it clear that a local variable is
7382 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7383 (gdk_window_get_screen): Make it clear that this macro is needed
7384 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7385 (int_gtk_range_get_value): New function, which avoids a diagnostic
7386 from gcc -Wbad-function-cast.
7387 (xg_set_toolkit_scroll_bar_thumb): Use it.
7388 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7389 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7390 (get_utf8_string, xg_get_file_with_chooser):
7391 Rename locals to avoid shadowing.
7392 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7393
41729b81
PE
7394 * xgselect.c (xg_select): Remove unused var.
7395
f0c77cd1
PE
7396 * image.c (four_corners_best): Mark locals as initialized.
7397 (gif_load): Initialize transparent_p to zero (Bug#8238).
7398 Mark another local as initialized.
ec6cf4c6 7399 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7400
ce0ad53d 7401 * image.c (clear_image_cache): Now static.
d5d5a617 7402 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7403 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7404 (x_edge_detection): Remove unnecessary cast that
7405 gcc -Wbad-function-cast diagnoses.
2037898d 7406 (gif_load): Fix pointer signedness.
6ae141d6
PE
7407 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7408 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7409
33383987 74102011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7411
d32df629
PE
7412 Improve quality of tests for time stamp overflow.
7413 For example, without this patch (encode-time 0 0 0 1 1
7414 1152921504606846976) returns the obviously-bogus value (-948597
7415 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7416 reports time overflow. See
7417 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7418 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7419 * editfns.c: Include limits.h and intprops.h.
7420 (TIME_T_MIN, TIME_T_MAX): New macros.
7421 (time_overflow): Move earlier, to before first use.
7422 (hi_time, lo_time): New functions, for an accurate test for
7423 out-of-range times.
7424 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7425 (Fget_internal_run_time): Don't assume time_t fits in int.
7426 (make_time): Use list2 instead of Fcons twice.
7427 (Fdecode_time): More accurate test for out-of-range times.
7428 (check_tm_member): New function.
7429 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7430 (lisp_time_argument): Don't rely on undefined left-shift and
7431 right-shift behavior when checking for time stamp overflow.
8be6f318 7432
fe31d94c
PE
7433 * editfns.c (time_overflow): New function, refactoring common code.
7434 (Fformat_time_string, Fdecode_time, Fencode_time):
7435 (Fcurrent_time_string): Use it.
7436
8be6f318
PE
7437 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7438 * dired.c (make_time): Move to ...
7439 * editfns.c (make_time): ... here.
7440 * systime.h: Note the move.
7441
09d9db2c 74422011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7443
126bc0dc
YM
7444 * fringe.c (update_window_fringes): Remove unused variables.
7445
c47cbdfd
YM
7446 * unexmacosx.c (copy_data_segment): Also copy __got section.
7447 (Bug#8223)
7448
7ac80be9
EZ
74492011-03-12 Eli Zaretskii <eliz@gnu.org>
7450
c96bbc66 7451 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7452 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7453 Constify `char *' arguments and their references according to
7454 prototypes in tparam.h.
7455
ecb0f94d 7456 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7457
7ac80be9
EZ
7458 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7459 Adapt all references accordingly.
7460
7461 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7462
ef1fd07e
TT
74632011-03-11 Tom Tromey <tromey@redhat.com>
7464
7465 * buffer.c (syms_of_buffer): Remove obsolete comment.
7466
7ef4b50c
EZ
74672011-03-11 Eli Zaretskii <eliz@gnu.org>
7468
7469 * termhooks.h (encode_terminal_code): Declare prototype.
7470
7471 * msdos.c (encode_terminal_code): Don't declare prototype.
7472
7473 * term.c (encode_terminal_code): Now external again, used by
7474 w32console.c and msdos.c.
7475
44f230aa
SM
7476 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7477 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7478
4b1ec863 74792011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7480
1714f52b 7481 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7482
4b1ec863
PE
7483 * fringe.c (update_window_fringes): Mark locals as initialized
7484 (Bug#8227).
7485 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7486
524c7aa6
PE
7487 * alloc.c (mark_fringe_data): Move decl from here ...
7488 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7489 to check its interface.
7490 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7491
a5c0af81 7492 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7493 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7494 (fontset_font): Mark local as initialized.
a9a06e0b 7495 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7496
b4716021
PE
7497 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7498
811e9bac 7499 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7500 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7501 (x_own_selection, Fx_disown_selection_internal): Rename locals
7502 to avoid shadowing.
7503 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7504
7e3ab302
PE
7505 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7506 so that the caller can use some name other than gcpro1.
7507 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7508 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7509 (Fx_backspace_delete_keys_p):
7510 Use them to avoid shadowing, and rename vars to avoid shadowing.
7511 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7512 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7513 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7514 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7515 Remove unused locals.
7e3ab302
PE
7516 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7517 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7518 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7519 macros.
f78faa98 7520
e2b13473
PE
7521 * xterm.h (x_mouse_leave): New decl.
7522
77f23912
PE
7523 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7524 Remove unused functions.
cdf4ba58
PE
7525 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7526 (x_calc_absolute_position): Now static.
7411c686 7527 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7528 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7529 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7530 unless they are used.
38d0b34a
PE
7531 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7532 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7533 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7534 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7535 (x_error_catcher, x_connection_closed, x_error_handler):
7536 (x_error_quitter, xembed_send_message, x_iconify_frame):
7537 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7538 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7539 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7540
44f230aa
SM
7541 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7542 Rename or move locals to avoid shadowing.
6b463e58 7543 (tty_defined_color, merge_face_heights): Now static.
5967d051 7544 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7545 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7546 does not deduce is never used uninitialized.
73719eba
PE
7547 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7548 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7549
426994c3 7550 * terminal.c (store_terminal_param): Now static.
5489860b 7551
032f1620 7552 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7553 (set_frame_menubar): Remove unused local.
d4323972 7554 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7555 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7556 since they might point to immutable storage.
281585b0
PE
7557 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7558 since it's unused otherwise.
032f1620 7559
367c19e5 7560 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7561 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7562 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7563 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7564 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7565 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7566 does not deduce are never used uninitialized.
70739cbe 7567
07b48fa9
PE
7568 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7569
8868a238 7570 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7571 * window.c (window_loop, size_window):
7572 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7573
7e5cf297 7574 * window.c (display_buffer): Now static.
d6550a9f
PE
7575 (size_window): Mark variables that gcc -Wuninitialized
7576 does not deduce are never used uninitialized.
a586633d
PE
7577 * window.h (check_all_windows): New decl, to forestall
7578 gcc -Wmissing-prototypes diagnostic.
5b555da1 7579 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7580
f6095868
PE
7581 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7582 shadowing.
7583 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7584 Include <limits.h>.
7585 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7586 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7587 (load_charset_map): Mark variables that gcc -Wuninitialized
7588 does not deduce are never used uninitialized.
53df7c11 7589 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7590
f38b440c
PE
7591 * coding.c (coding_set_source, coding_set_destination):
7592 Use "else { /* comment */ }" rather than "else /* comment */;"
7593 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7594 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7595 a block, when the outer 'i' will do.
7596 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7597 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7598 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7599 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7600 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7601 Rename locals to avoid shadowing.
7602 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7603 * coding.c (emacs_mule_char, encode_invocation_designation):
7604 Now static, since they're not used elsewhere.
413bb2db 7605 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7606 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7607 (decode_coding_emacs_mule): Mark variables that gcc
7608 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7609 (detect_coding_iso_2022): Initialize a local variable that might
7610 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7611 this initialization is needed. (Bug#8211)
5f58e762
PE
7612 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7613 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7614 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7615 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7616 Remove unused macros.
f38b440c 7617
232b38b9 7618 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7619 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7620 * character.c (string_count_byte8): Likewise.
232b38b9 7621
fb90da1b
PE
7622 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7623 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7624
fb93dbc2
PE
7625 * chartab.c (copy_sub_char_table): Now static, since it's not used
7626 elsewhere.
5c156ace
PE
7627 (sub_char_table_ref_and_range, char_table_ref_and_range):
7628 Rename locals to avoid shadowing.
bbcd0949 7629 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7630
7d3b3862 7631 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7632 (BIDI_BOB): Remove unused macro.
7d3b3862 7633
6be7d3da
PE
7634 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7635 deduce are never used uninitialized.
c2ed9c8b 7636 * term.c (encode_terminal_code): Likewise.
6be7d3da 7637
75f8807f 7638 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7639
50938595
PE
7640 * tparam.h: New file.
7641 * term.c, tparam.h: Include it.
7642 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7643 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7644 Move these decls to tparam.h, and make them agree with what
7645 is actually in tparam.c. The previous trick of using incompatible
7646 decls in different modules does not conform to the C standard.
7647 All callers of tparam changed to use tparam's actual API.
7648 * tparam.c (tparam1, tparam, tgoto):
7649 Use const pointers where appropriate.
7650
fbceeba2
PE
7651 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7652 * cm.h (struct cm): Likewise.
7653 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7654 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7655 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7656 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7657 (turn_on_face, init_tty): Likewise.
7658 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7659
7f3f1250
PE
7660 * term.c (term_mouse_position): Rename local to avoid shadowing.
7661
e6ca6543
PE
7662 * alloc.c (mark_ttys): Move decl from here ...
7663 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7664
c40f8d15
AS
76652011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7666
7667 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7668
cfe0661d
JB
76692011-03-09 Juanma Barranquero <lekktu@gmail.com>
7670
7671 * search.c (compile_pattern_1): Remove argument regp, unused since
7672 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7673 (compile_pattern): Don't pass it.
7674
0afb4571
J
76752011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7676
7677 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7678 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7679 for ! HAVE_GTK3.
7680 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7681
7682 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7683
7684 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7685 gdk_window_get_screen, gdk_window_get_geometry,
7686 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7687 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7688 (xg_get_pixbuf_from_pixmap): New function.
7689 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7690 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7691 Call xg_get_pixbuf_from_pixmap instead of
7692 gdk_pixbuf_get_from_drawable.
7693 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7694 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7695 (xg_check_special_colors): Use GtkStyleContext and its functions
7696 for HAVE_GTK3.
7697 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7698 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7699 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7700 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7701 Call gtk_widget_get_preferred_size.
0afb4571
J
7702 (xg_frame_resized): gdk_window_get_geometry only takes 5
7703 parameters.
44f230aa
SM
7704 (xg_win_to_widget, xg_event_is_for_menubar):
7705 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7706 (xg_set_widget_bg): New function.
7707 (delete_cb): New function.
895009e1 7708 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7709 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7710 (xg_set_background_color): Call xg_set_widget_bg.
7711 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7712 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7713 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7714 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7715 if ! HAVE_GTK3.
7716 (update_frame_tool_bar): Call gtk_widget_hide.
7717 (xg_initialize): Use GDK_KEY_g.
7718
7719 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7720 if ! HAVE_GTK3
7721 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7722
7723 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7724 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7725 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7726
1c2cc4ef
JB
77272011-03-08 Juanma Barranquero <lekktu@gmail.com>
7728
7729 * w32xfns.c (select_palette): Check success of RealizePalette against
7730 GDI_ERROR, not zero.
7731
33383987 7732See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7733
7734;; Local Variables:
7735;; coding: utf-8
aac0c6e3
MR
7736;; End:
7737
33383987 7738 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7739
7740 This file is part of GNU Emacs.
7741
7742 GNU Emacs is free software: you can redistribute it and/or modify
7743 it under the terms of the GNU General Public License as published by
7744 the Free Software Foundation, either version 3 of the License, or
7745 (at your option) any later version.
7746
7747 GNU Emacs is distributed in the hope that it will be useful,
7748 but WITHOUT ANY WARRANTY; without even the implied warranty of
7749 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7750 GNU General Public License for more details.
7751
7752 You should have received a copy of the GNU General Public License
7753 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.