* buffer.c (OVERLAY_COUNT_MAX): New macro.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
51cab52b 12011-06-21 Paul Eggert <eggert@cs.ucla.edu>
882f0d81 2
b081724f
PE
3 Use ptrdiff_t, not int, for overlay counts.
4 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5 * editfns.c (overlays_around, get_pos_property):
6 * textprop.c (get_char_property_and_overlay):
7 * xdisp.c (next_overlay_change, note_mouse_highlight):
8 * xfaces.c (face_at_buffer_position):
21514da7
PE
9 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
11 (Fnext_overlay_change, Fprevious_overlay_change)
12 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 13 Use ptrdiff_t, not int, for sizes.
21514da7 14 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 15
3de73e5e
PE
16 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
17
2606c57b
PE
18 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
19 (x_session_initialize): Do not assume string length fits in int.
20
aaafe47a
PE
21 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
22 This is unlikely, but can occur if DPI is outlandish.
23
2674ddc8 24 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
25 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
26
28154962
PE
27 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
28 * xrdb.c (magic_file_p, search_magic_path):
29 Omit last arg SUFFIX; it was always 0. All callers changed.
30 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
31
7de51af5
PE
32 * xfont.c (xfont_match): Avoid need for strlen.
33
25ed6cc3
PE
34 * xfns.c: Don't assume strlen fits in int.
35 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
36
4eab31dd
PE
37 * xdisp.c (message_log_check_duplicate): Return intmax_t,
38 not unsigned long, as we prefer signed integers. All callers changed.
39 Detect integer overflow in repeat count.
40 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 41 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 42
171e2a58
PE
43 * termcap.c: Don't assume sizes fit in int and never overflow.
44 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
45 (gobble_line): Check for size-calculation overflow.
46
ad39faca 47 * minibuf.c (Fread_buffer):
6e5bb2dc 48 * lread.c (intern, intern_c_string):
74ca2eb3
PE
49 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
50 Don't assume string length fits in int.
51
52c61c22 52 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
53 * gtkutil.c (style_changed_cb): Avoid need for strlen.
54
b5b8c9e5
PE
55 * font.c: Don't assume string length fits in int.
56 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
57 Use ptrdiff_t, not int.
ccd6111c
PE
58 (font_intern_prop): Don't assume string length fits in int.
59 Don't assume integer property fits in fixnum.
60 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 61
882f0d81 62 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 63 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
64 Reformulate so as not to need the command string.
65 Invoke gzip -cd rather than gunzip, as it's more portable.
66 (lock_info_type, lock_file_1, lock_file):
67 Don't assume pid_t and time_t fit in unsigned long.
68 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
69 (current_lock_owner): Prefer signed type for sizes.
70 Use memcpy, not strncpy, where memcpy is what is really wanted.
71 Don't assume (via atoi) that time_t and pid_t fit in int.
72 Check for time_t and/or pid_t out of range, e.g., via a network share.
73 Don't alloca where an auto var works fine.
74
93f4cf88
PE
75 * fileio.c: Fix some integer overflow issues.
76 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
77 Don't assume string length fits in int.
78 (directory_file_name): Don't assume string length fits in long.
79 (make_temp_name): Don't assume pid fits in int, or that its print
80 length is less than 20.
81
f3e92b69
PE
82 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
83
1bfdaf10
PE
84 * coding.c (make_subsidiaries): Don't assume string length fits in int.
85
35016e9a
PE
86 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
87
3d1e65a1
PE
88 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
89 We prefer signed integers, even for size calculations.
90
0b963a93
PE
91 * emacs.c: Don't assume string length fits in 'int'.
92 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
93 (main): Don't invoke strlen when not needed.
94
573f4b54
PE
95 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
96 (XD_DEBUG_MESSAGE): Don't waste a byte.
97
989f33ba
PE
98 * callproc.c (getenv_internal_1, getenv_internal)
99 (Fgetenv_internal):
965d34eb
PE
100 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
101
e4d29b33
PE
102 * lread.c (invalid_syntax): Omit length argument.
103 All uses changed. This doesn't fix a bug, but it simplifies the
104 code away from its former Hollerith-constant appearance, and it's
105 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 106 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 107
eb49b136
PE
108 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
109 This didn't break anything, but it didn't help either.
110 It's confusing to put a bogus integer in a place where the actual
111 value does not matter.
9f62aeb1 112 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 113 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 114
15375a22
PE
115 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
116 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
117 implementation.
b61cc01c
PE
118 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
119 We prefer signed types, and the value cannot exceed the EMACS_INT
120 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
121 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
122 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
123 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 124
53b2623d
PE
125 * indent.c (sane_tab_width): New function.
126 (current_column, scan_for_column, Findent_to, position_indentation)
127 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 128 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 129
51cab52b 130 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 131
f2ed8a70
PE
132 * lisp.h (lint_assume): New macro.
133 * composite.c (composition_gstring_put_cache):
134 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
135
abe80cc6
PE
136 * editfns.c, insdel.c:
137 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 138
b02c740e
PE
139 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
140
ebc96716
PE
141 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
142
b4e50fa0 143 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 144 Use much-faster test for byte-length change.
311d5d7c 145 Don't assume string byte-length fits in 'int'.
a4cf38e4 146 Check that character arg fits in 'int'.
85461888 147 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 148
c0c1ee9f
PE
149 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
150
a498d7f4
PE
151 * fns.c (concat): Catch string overflow earlier.
152 Do not rely on integer wraparound.
153
51cab52b
PE
154 * dispextern.h (struct it.overlay_strings_charpos)
155 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
156 * xdisp.c (forward_to_next_line_start)
157 (back_to_previous_visible_line_start)
158 (reseat_at_next_visible_line_start, next_element_from_buffer):
159 Don't arbitrarily truncate the value of 'selective' to int.
160
76031fad
PE
161 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
162
5eb55db9
PE
163 * composite.c: Don't truncate sizes to 'int'.
164 (composition_gstring_p, composition_reseat_it)
165 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
166 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
167 not EMACS_UINT, for indexes.
5eb55db9 168
0703a717
PE
169 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
170
d6202519
PE
171 * buffer.c: Include <verify.h>.
172 (struct sortvec.priority, struct sortstr.priority):
8961a454 173 Now EMACS_INT, not int.
c20998a7 174 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
175 (struct sortstr.size, record_overlay_string)
176 (struct sortstrlist.size, struct sortlist.used):
177 Don't truncate size to int.
178 (record_overlay_string): Check for size-calculation overflow.
d6202519 179 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 180
76147d94
DD
1812011-06-20 Deniz Dogan <deniz@dogan.se>
182
183 * process.c (Fset_process_buffer): Clarify return value in
184 docstring.
185
7d7d0045
CY
1862011-06-18 Chong Yidong <cyd@stupidchicken.com>
187
188 * dispnew.c (add_window_display_history): Use BVAR.
189
190 * xdisp.c (debug_method_add): Use BVAR.
191 (check_window_end, dump_glyph_matrix, dump_glyph)
192 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
193
194 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
195 Likewise.
196
197 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
198 check till after the cache is created in init_frame_faces.
199
ff2bc410
SM
2002011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
201
202 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
203
28177add
PE
2042011-06-16 Paul Eggert <eggert@cs.ucla.edu>
205
dd3482fe
PE
206 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
207 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
208 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
209
393d71f3 210 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
211 * fileio.c (Finsert_file_contents):
212 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
213 Remove the old (too-loose) buffer overflow checks.
214 They weren't needed, since make_gap checks for buffer overflow.
215 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
216 The old code merely checked for Emacs fixnum overflow, and relied
217 on undefined (wraparound) behavior. The new code avoids undefined
218 behavior, and also checks for ptrdiff_t and/or size_t overflow.
219
2e6813b0 220 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
221 Tune. Don't use wider integers than needed. Don't use alloca.
222 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 223
599a9e4f
PE
224 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
225
99561444
PE
226 * insdel.c, lisp.h (buffer_overflow): New function.
227 (insert_from_buffer_1, replace_range, replace_range_2):
228 * insdel.c (make_gap_larger):
229 * editfns.c (Finsert_char):
230 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
231
28177add
PE
232 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
233
e69dafad
PE
2342011-06-15 Paul Eggert <eggert@cs.ucla.edu>
235
a7af7fde 236 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 237
b1c46f02
PE
238 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
239 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
240
e69dafad
PE
241 * fileio.c: Don't assume EMACS_INT fits in off_t.
242 (emacs_lseek): New static function.
243 (Finsert_file_contents, Fwrite_region): Use it.
244 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
245
566684ea
PE
246 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
247
e6966cd6
PE
248 * fns.c: Don't overflow int when computing a list length.
249 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
250 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
251 truncation on 64-bit hosts. Check for QUIT every
252 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
253 faster and is responsive enough.
254 (Flength): Report an error instead of overflowing an integer.
255 (Fsafe_length): Return a float if the value is not representable
256 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 257 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 258 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 259
dd0b0efb
PE
260 * alloc.c: Check that resized vectors' lengths fit in fixnums.
261 (header_size, word_size): New constants.
262 (allocate_vectorlike): Don't check size overflow here.
263 (allocate_vector): Check it here instead, since this is the only
264 caller of allocate_vectorlike that could cause overflow.
265 Check that the new vector's length is representable as a fixnum.
266
86fe5cfe
PE
267 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
268 The previous code was bogus. For example, next_almost_prime (32)
269 returned 39, which is undesirable as it is a multiple of 3; and
270 next_almost_prime (24) returned 25, which is a multiple of 5 so
271 why was the code bothering to check for multiples of 7?
272
80e88859
PE
273 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
274
4a2f0ad6
PE
275 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
276
f66c7cf8
PE
277 Variadic C functions now count arguments with ptrdiff_t.
278 This partly undoes my 2011-03-30 change, which replaced int with size_t.
279 Back then I didn't know that the Emacs coding style prefers signed int.
280 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
281 were being counted with int, which may truncate counts on 64-bit
282 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
283 * lisp.h (struct Lisp_Subr.function.aMANY)
284 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
285 Arg counts are now ptrdiff_t, not size_t.
286 All variadic functions and their callers changed accordingly.
287 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
288 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
289 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
290 * callint.c (Fcall_interactively): Check arg count for overflow,
291 to avoid potential buffer overrun. Use signed char, not 'int',
292 for 'varies' array, so that we needn't bother to check its size
293 calculation for overflow.
294 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
295 * eval.c (apply_lambda):
296 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
297 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
298 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
299
a1759b76
PE
300 * callint.c (Fcall_interactively): Don't use index var as event count.
301
d96be9fc
PE
302 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
303 * mem-limits.h (SIZE): Remove; no longer used.
304
a690a978 305 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 306
578c21e6
PE
307 Remove unnecessary casts.
308 * xterm.c (x_term_init):
309 * xfns.c (x_set_border_pixel):
310 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
311 These aren't needed now that we assume ANSI C.
312
96f53c6c
PE
313 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
314 It's more likely to cause problems (due to unsigned overflow)
315 than to cure them.
316
83c77d31
PE
317 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
318
ee2079f1
PE
319 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
320
6da65536
PE
321 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
322
7147c4a4
PE
323 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
324
193e32d9
PE
325 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
326
e5533da6
PE
327 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
328
9910e595
PE
329 GLYPH_CODE_FACE returns EMACS_INT, not int.
330 * dispextern.h (merge_faces):
331 * xfaces.c (merge_faces):
01103c44
PE
332 * xdisp.c (get_next_display_element, next_element_from_display_vector):
333 Don't assume EMACS_INT fits in int.
9910e595 334
2638320e
PE
335 * character.h (CHAR_VALID_P): Remove unused parameter.
336 * fontset.c, lisp.h, xdisp.c: All uses changed.
337
045eb8d9
PE
338 * editfns.c (Ftranslate_region_internal): Omit redundant test.
339
c1f134b5
PE
340 * fns.c (concat): Minor tuning based on overflow analysis.
341 This doesn't fix any bugs. Use int to hold character, instead
342 of constantly refetching from Emacs object. Use XFASTINT, not
343 XINT, for value known to be a character. Don't bother comparing
344 a single byte to 0400, as it's always less.
345
395fcb93 346 * floatfns.c (Fexpt):
327eeec8
PE
347 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
348
abbd3d23
PE
349 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
350 for characters.
351
684a03ef
PE
352 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
353
0fed43f3
PE
354 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
355 Without this fix, on a 64-bit host (aset S 0 4294967386) would
356 incorrectly succeed when S was a string, because 4294967386 was
357 truncated before it was used.
358
8fd02eb7
PE
359 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
360 Otherwise, an out-of-range integer could cause undefined behavior
361 on a 64-bit host.
362
f8c86b69
PE
363 * composite.c: Use int, not EMACS_INT, for characters.
364 (fill_gstring_body, composition_compute_stop_pos): Use int, not
365 EMACS_INT, for values that are known to be in character range.
366 This doesn't fix any bugs but is the usual style inside Emacs and
367 may generate better code on 32-bit machines.
368
34206dd2
PE
369 Make sure a 64-bit char is never passed to ENCODE_CHAR.
370 This is for reasons similar to the recent CHAR_STRING fix.
371 * charset.c (Fencode_char): Check that character arg is actually
372 a character. Pass an int to ENCODE_CHAR.
373 * charset.h (ENCODE_CHAR): Verify that the character argument is no
374 wider than 'int', as a compile-time check to prevent future regressions
375 in this area.
376
c5958d4c 377 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
378
379 Make sure a 64-bit char is never passed to CHAR_STRING.
380 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
381 by silently ignoring the top 32 bits, allowing some values
382 that were far too large to be valid characters.
383 * character.h: Include <verify.h>.
384 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
385 arguments are no wider than unsigned, as a compile-time check
386 to prevent future regressions in this area.
387 * data.c (Faset):
01103c44 388 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
389 (Fsubst_char_in_region):
390 * fns.c (concat):
391 * xdisp.c (decode_mode_spec_coding):
392 Adjust to CHAR_STRING's new requirement.
393 * editfns.c (Finsert_char, Fsubst_char_in_region):
394 * fns.c (concat): Check that character args are actually
395 characters. Without this test, these functions did the wrong
396 thing with wildly out-of-range values on 64-bit hosts.
397
d37ca623
PE
398 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
399 These casts should not be needed on 32-bit hosts, either.
400 * keyboard.c (read_char):
401 * lread.c (Fload): Remove casts to unsigned.
402
ea204efb
PE
403 * lisp.h (UNSIGNED_CMP): New macro.
404 This fixes comparison bugs on 64-bit hosts.
405 (ASCII_CHAR_P): Use it.
406 * casefiddle.c (casify_object):
01103c44 407 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
408 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
409 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
410 * dispextern.h (FACE_FROM_ID):
411 * keyboard.c (read_char): Use UNSIGNED_CMP.
412
41cb286c
PE
413 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
414 not to EMACS_INT, to avoid GCC warning.
415
4a1b9832
PE
416 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
417
55daad71
PE
418 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
419 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
420 isn't needed on 32-bit machines.
8f95c75c 421
01103c44
PE
422 * buffer.c (Fgenerate_new_buffer_name):
423 Use EMACS_INT for count, not int.
0ceccced 424 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
425
426 * data.c (Qcompiled_function): Now static.
427
c6f072e7
PE
428 * window.c (window_body_lines): Now static.
429
20ce5912
PE
430 * image.c (gif_load): Rename local to avoid shadowing.
431
9c4c5f81
PE
432 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
433 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
434 * alloc.c (make_save_value): Integer argument is now of type
435 ptrdiff_t, not int.
436 (mark_object): Use ptrdiff_t, not int.
437 * lisp.h (pD): New macro.
438 * print.c (print_object): Use it.
439
c0c5c8ae
PE
440 * alloc.c: Use EMACS_INT, not int, to count objects.
441 (total_conses, total_markers, total_symbols, total_vector_size)
442 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
443 (total_free_floats, total_floats, total_free_intervals)
444 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
445 Now EMACS_INT, not int. All uses changed.
446 (Fgarbage_collect): Compute overall total using a double, so that
447 integer overflow is less likely to be a problem. Check for overflow
448 when converting back to an integer.
5a25e253
PE
449 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
450 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
451 These were 'int' variables that could overflow on 64-bit hosts;
452 they were never used, so remove them instead of repairing them.
211a0b2a 453 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
454 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
455 Previously, this ceilinged at INT_MAX, but that doesn't work on
456 64-bit machines.
e46bb31a 457 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 458
c78baabf 459 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 460 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
461 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
462 when a (possibly-narrower) signed value would do just as well.
463 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 464
c9d624c6
PE
465 * alloc.c: Catch some string size overflows that we were missing.
466 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
467 for convenience in STRING_BYTES_MAX.
468 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
469 The definition here is exact; the one in lisp.h was approximate.
470 (allocate_string_data): Check for string overflow. This catches
471 some instances we weren't catching before. Also, it catches
472 size_t overflow on (unusual) hosts where SIZE_MAX <= min
473 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
474 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 475
c9d624c6
PE
476 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
477 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
478 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
479
353032ce
PE
480 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
481
2bccce07
PE
482 * alloc.c (Fmake_string): Check for out-of-range init.
483
0ac30604
SM
4842011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
485
486 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
487
c195f2de
JD
4882011-06-14 Jan Djärv <jan.h.d@swipnet.se>
489
490 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
491 xg_get_default_scrollbar_width.
492
493 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
494 (int_gtk_range_get_value): Move to the scroll bar part of the file.
495 (style_changed_cb): Call update_theme_scrollbar_width and call
496 x_set_scroll_bar_default_width and xg_frame_set_char_size for
497 all frames (Bug#8505).
498 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
499 Call gtk_window_set_resizable if HAVE_GTK3.
500 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
501 and height if HAVE_GTK3 (Bug#8505).
502 (scroll_bar_width_for_theme): New variable.
503 (update_theme_scrollbar_width): New function.
504 (xg_get_default_scrollbar_width): Move code to
505 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
506 (xg_initialize): Call update_theme_scrollbar_width.
507
508 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
509
510 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
511
e10ac9f1
MR
5122011-06-12 Martin Rudalics <rudalics@gmx.at>
513
514 * frame.c (make_frame): Call other_buffer_safely instead of
515 other_buffer.
516
517 * window.c (temp_output_buffer_show): Call display_buffer with
518 second argument Vtemp_buffer_show_specifiers and reset latter
519 immediately after the call.
520 (Vtemp_buffer_show_specifiers): New variable.
521 (auto_window_vscroll_p, next_screen_context_lines)
522 (Vscroll_preserve_screen_position): Remove leading asterisks from
523 doc-strings.
524
2d3c217e 5252011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 526
7b7f97e8 527 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
528 * buffer.c (Qclone_number): Remove for now, as it's unused.
529 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
530 (record_buffer): Remove unused local.
531 * frame.c (other_visible_frames, frame_buffer_list): Now static.
532 (set_frame_buffer_list): Remove; unused.
533 * frame.h (other_visible_frames): Remove decl.
534 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
535 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
536 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
537 if HAVE_GPM.
538 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
539 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
540 Define only if HAVE_GPM.
541 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
542 (update_hints_inhibit): Remove; never set. All uses removed.
543 * widgetprv.h (emacsFrameClassRec): Remove decl.
544 * window.c (delete_deletable_window): Now returns void, since it
545 wasn't returning anything.
546 (compare_window_configurations): Remove unused locals.
547 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
548 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
549 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
550 the same widths as pointers. This follows up on the 2011-05-06 patch.
551 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
552 * xterm.h: Likewise.
553 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
554
1384b89e
JB
5552011-06-12 Juanma Barranquero <lekktu@gmail.com>
556
557 * makefile.w32-in: Update dependencies.
558 (LISP_H): Add lib/intprops.h.
559
1100a63c
CY
5602011-06-11 Chong Yidong <cyd@stupidchicken.com>
561
562 * image.c (gif_load): Add animation frame delay to the metadata.
563 (syms_of_image): Use DEFSYM. New symbol `delay'.
564
6198ccd0
MR
5652011-06-11 Martin Rudalics <rudalics@gmx.at>
566
567 * window.c (delete_deletable_window): Re-add.
568 (Fset_window_configuration): Rewrite to handle dead buffers and
569 consequently deletable windows.
570 (window_tree, Fwindow_tree): Remove. Supply functionality in
571 window.el.
572 (compare_window_configurations): Simplify code.
573
b6e3633c
AS
5742011-06-11 Andreas Schwab <schwab@linux-m68k.org>
575
1ab0dee5
AS
576 * image.c (imagemagick_load_image): Fix type mismatch.
577 (Fimagemagick_types): Likewise.
578
b6e3633c
AS
579 * window.h (replace_buffer_in_windows): Declare.
580
9397e56f
MR
5812011-06-11 Martin Rudalics <rudalics@gmx.at>
582
583 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
584 Qclone_number. Remove external declaration of Qdelete_window.
585 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
586 code.
587 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
588 Qbuffer_list_update_hook if allowed.
589 (Fother_buffer): Rewrite doc-string. Major rewrite for new
590 buffer list implementation.
591 (other_buffer_safely): New function.
592 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
593 calls to replace_buffer_in_windows and
594 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
595 if allowed.
596 (record_buffer): Inhibit quitting and rewrite using quittable
597 functions. Run Qbuffer_list_update_hook if allowed.
598 (Frecord_buffer, Funrecord_buffer): New functions.
599 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
600 switch-to-buffer to window.el.
601 (bury-buffer): Move to window.el.
602 (Vbuffer_list_update_hook): New variable.
603
604 * lisp.h (other_buffer_safely): Add prototype in buffer.c
605 section.
606
607 * window.h (resize_frame_windows): Move up in code.
608 (Fwindow_frame): Remove EXFUN.
609 (replace_buffer_in_all_windows): Remove prototype.
610 (replace_buffer_in_windows_safely): Add prototype.
611
612 * window.c: Declare Qdelete_window static again. Move down
613 declaration of select_count.
614 (Fnext_window, Fprevious_window): Rewrite doc-strings.
615 (Fother_window): Move to window.el.
616 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
617 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
618 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
619 window.el.
620 (replace_buffer_in_windows): Implement by calling
621 Qreplace_buffer_in_windows.
622 (replace_buffer_in_all_windows): Remove with some functionality
623 moved into replace_buffer_in_windows_safely.
624 (replace_buffer_in_windows_safely): New function.
625 (select_window_norecord, select_frame_norecord): Move in front
626 of run_window_configuration_change_hook. Remove now obsolete
627 declarations.
628 (Fset_window_buffer): Rewrite doc-string. Call
629 Qrecord_window_buffer.
630 (keys_of_window): Move binding for other-window to window.el.
631
b50691aa
CY
6322011-06-11 Chong Yidong <cyd@stupidchicken.com>
633
634 * dispextern.h (struct image): Replace data member, whose int_val
635 and ptr_val fields were not used by anything, with a single
636 lisp_val object.
637
638 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
639 (gif_clear_image, gif_load, imagemagick_load_image)
640 (gs_clear_image, gs_load): Callers changed.
641
3f754b86
PE
6422011-06-10 Paul Eggert <eggert@cs.ucla.edu>
643
cca69397
PE
644 * buffer.h: Include <time.h>, for time_t.
645 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
646
109e28d0
PE
647 Fix minor problems found by static checking.
648
60737f02
PE
649 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
650
4b66faf3
PE
651 Make identifiers static if they are not used in other modules.
652 * data.c (Qcompiled_function, Qframe, Qvector):
653 * image.c (QimageMagick, Qsvg):
654 * minibuf.c (Qmetadata):
655 * window.c (resize_window_check, resize_root_window): Now static.
656 * window.h (resize_window_check, resize_root_window): Remove decls.
657
109e28d0
PE
658 * window.c (window_deletion_count, delete_deletable_window):
659 Remove; unused.
46a4ce9e
PE
660 (window_body_lines): Now static.
661 (Fdelete_other_windows_internal): Mark vars as initialized.
662 Make sure 'resize_failed' is initialized.
663 (run_window_configuration_change_hook): Rename local to avoid shadowing.
664 (resize_window_apply): Remove unused local.
665 * window.h (delete_deletable_window): Remove decl.
666
109e28d0 667 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
668 (imagemagick_load_image): Fix pointer signedness problem by changing
669 last arg from unsigned char * to char *. All uses changed.
670 Also, fix a local for similar reasons.
671 Remove unused locals. Remove locals to avoid shadowing.
672 (fn_rsvg_handle_free): Remove; unused.
673 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 674 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 675
3f754b86
PE
676 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
677
2547adb1
CY
6782011-06-10 Chong Yidong <cyd@stupidchicken.com>
679
680 * image.c (gif_load): Fix omitted cast error introduced by
681 2011-06-06 change.
682
2c8e37d4
MR
6832011-06-10 Martin Rudalics <rudalics@gmx.at>
684
685 * window.h (resize_proportionally, orig_total_lines)
686 (orig_top_line): Remove from window structure.
687 (set_window_height, set_window_width, change_window_heights)
688 (Fdelete_window): Remove prototypes.
689 (resize_frame_windows): Remove duplicate declaration.
690
440a42e3
EZ
6912011-06-10 Eli Zaretskii <eliz@gnu.org>
692
693 * window.h (resize_frame_windows, resize_window_check)
694 (delete_deletable_window, resize_root_window)
695 (resize_frame_windows): Declare prototypes.
696
697 * window.c (resize_window_apply): Make definition be "static" to
698 match the prototype.
699
562dd5e9
MR
7002011-06-10 Martin Rudalics <rudalics@gmx.at>
701
702 * window.c: Remove declarations of Qwindow_size_fixed,
703 window_min_size_1, window_min_size_2, window_min_size,
704 size_window, window_fixed_size_p, enlarge_window, delete_window.
705 Remove static from declaration of Qdelete_window, it's
706 temporarily needed by Fbury_buffer.
707 (replace_window): Don't assign orig_top_line and
708 orig_total_lines.
709 (Fdelete_window, delete_window): Remove. Window deletion is
710 handled by window.el.
711 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
712 Fdelete_window calls with calls to Qdelete_window.
713 (Fdelete_other_windows): Remove. Deleting other windows is
714 handled by window.el.
715 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
716 handled in window.el.
717 (window_min_size_2, window_min_size_1, window_min_size): Remove.
718 Window minimum sizes are handled in window.el.
719 (shrink_windows, size_window, set_window_height)
720 (set_window_width, change_window_heights, window_height)
721 (window_width, CURBEG, CURSIZE, enlarge_window)
722 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
723 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
724 handled in window.el.
725 (make_dummy_parent): Rename to make_parent_window and give it a
726 second argument horflag.
727 (make_window): Don't set resize_proportionally any more.
728 (Fsplit_window): Remove. Windows are split in window.el.
729 (save_restore_action, save_restore_orig_size)
730 (shrink_window_lowest_first, save_restore_orig_size): Remove.
731 Resize mini windows in window.el.
732 (grow_mini_window, shrink_mini_window): Implement by calling
733 Qresize_root_window_vertically, resize_window_check and
734 resize_window_apply.
735 (saved_window, Fset_window_configuration, save_window_save): Do
736 not handle orig_top_line, orig_total_lines, and
737 resize_proportionally.
738 (window_min_height, window_min_width): Move to window.el.
739 (keys_of_window): Move bindings for delete-other-windows,
740 split-window, delete-window and enlarge-window to window.el.
741
742 * buffer.c: Temporarily extern Qdelete_window.
743 (Fbury_buffer): Temporarily call Qdelete_window instead of
744 Fdelete_window (Fbury_buffer will move to window.el soon).
745
746 * frame.c (set_menu_bar_lines_1): Remove code handling
747 orig_top_line and orig_total_lines.
748
749 * dispnew.c (adjust_frame_glyphs_initially): Don't use
750 set_window_height but set heights directly.
751 (change_frame_size_1): Use resize_frame_windows.
752
753 * xdisp.c (init_xdisp): Don't use set_window_height but set
754 heights directly.
755
756 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
757 resize_frame_windows instead of change_window_heights and run
758 run_window_configuration_change_hook.
759
760 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
761 instead of change_window_heights and run
762 run_window_configuration_change_hook.
763
1a13852e
MR
7642011-06-09 Martin Rudalics <rudalics@gmx.at>
765
766 * window.c (replace_window): Rename second argument REPLACEMENT to
767 NEW. New third argument SETFLAG. Rewrite.
768 (delete_window, make_dummy_parent): Call replace_window with
769 third argument 1.
770 (window_list_1): Move down in code.
771 (run_window_configuration_change_hook): Move set_buffer part
772 before select_frame_norecord part in order to unwind correctly.
773 Rename count1 to count.
774 (recombine_windows, delete_deletable_window, resize_root_window)
775 (Fdelete_other_windows_internal)
776 (Frun_window_configuration_change_hook, make_parent_window)
777 (resize_window_check, resize_window_apply, Fresize_window_apply)
778 (resize_frame_windows, Fsplit_window_internal)
779 (Fdelete_window_internal, Fresize_mini_window_internal): New
780 functions.
781 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
782
f3d1777e
MR
7832011-06-08 Martin Rudalics <rudalics@gmx.at>
784
496e208e
MR
785 * window.h (window): Add some new members to window structure -
786 normal_lines, normal_cols, new_total, new_normal, clone_number,
787 splits, nest, prev_buffers, next_buffers.
788 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 789 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 790
f3d1777e
MR
791 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
792 Remove.
496e208e
MR
793 (make_dummy_parent): Set new members of windows structure.
794 (make_window): Move down in code. Handle new members of window
795 structure.
796 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
797 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
798 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
799 (Fset_window_prev_buffers, Fwindow_next_buffers)
800 (Fset_window_next_buffers, Fset_window_clone_number): New
801 functions.
802 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
803 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
804 Doc-string fixes.
805 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
806 Argument WINDOW can be now internal window too.
807 (Fwindow_use_time): Move up in code.
808 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
809 Rewrite doc-string.
810 (Fset_window_configuration, saved_window)
811 (Fcurrent_window_configuration, save_window_save): Handle new
812 members of window structure.
b9e809c2
MR
813 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
814 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
815 (syms_of_window): New Lisp objects Qrecord_window_buffer,
816 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
817 Qget_mru_window, Qresize_root_window,
818 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
819 Qauto_buffer_name; staticpro them.
f3d1777e 820
abde8f8c
MR
8212011-06-07 Martin Rudalics <rudalics@gmx.at>
822
823 * window.c (Fwindow_total_size, Fwindow_left_column)
824 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
825 (Fwindow_list_1): New functions.
826 (window_box_text_cols): Replace with window_body_cols.
827 (Fwindow_width, Fscroll_left, Fscroll_right): Use
828 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
829 (delete_window, Fset_window_configuration): Call
830 delete_all_subwindows with window as argument.
831 (delete_all_subwindows): Take a window as argument and not a
832 structure. Rewrite.
190b47e6
MR
833 (window_loop): Remove handling of GET_LRU_WINDOW and
834 GET_LARGEST_WINDOW.
835 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
836
837 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
838 window_box_text_cols. delete_all_subwindows now takes a
839 Lisp_Object as argument.
abde8f8c
MR
840
841 * indent.c (compute_motion, Fcompute_motion): Use
842 window_body_cols instead of window_box_text_cols.
843
fa8a67e6
MR
844 * frame.c (delete_frame): Call delete_all_subwindows with root
845 window as argument.
846
a54e3482
DC
8472011-06-07 Daniel Colascione <dan.colascione@gmail.com>
848
849 * fns.c (Fputhash): Document return value.
850
60002bf5
CY
8512011-06-06 Chong Yidong <cyd@stupidchicken.com>
852
853 * image.c (gif_load): Implement gif89a spec "no disposal" method.
854
0c671da6 8552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 856
b862a52a 857 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 858
be44ca6c
PE
859 Check for overflow when converting integer to cons and back.
860 * charset.c (Fdefine_charset_internal, Fdecode_char):
861 Use cons_to_unsigned to catch overflow.
862 (Fencode_char): Use INTEGER_TO_CONS.
863 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
864 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
865 * data.c (long_to_cons, cons_to_long): Remove.
866 (cons_to_unsigned, cons_to_signed): New functions.
867 These signal an error for invalid or out-of-range values.
868 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
869 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
870 * font.c (Ffont_variation_glyphs):
871 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
872 * lisp.h: Include <intprops.h>.
873 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
874 (cons_to_signed, cons_to_unsigned): New decls.
875 (long_to_cons, cons_to_long): Remove decls.
876 * undo.c (record_first_change): Use INTEGER_TO_CONS.
877 (Fprimitive_undo): Use CONS_TO_INTEGER.
878 * xfns.c (Fx_window_property): Likewise.
879 * xselect.c: Include <limits.h>.
880 (x_own_selection, selection_data_to_lisp_data):
881 Use INTEGER_TO_CONS.
882 (x_handle_selection_request, x_handle_selection_clear)
883 (x_get_foreign_selection, Fx_disown_selection_internal)
884 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
885 (lisp_data_to_selection_data): Use cons_to_unsigned.
886 (x_fill_property_data): Use cons_to_signed.
887 Report values out of range.
888
d1f3d2af
PE
889 Check for buffer and string overflow more precisely.
890 * buffer.h (BUF_BYTES_MAX): New macro.
891 * lisp.h (STRING_BYTES_MAX): New macro.
892 * alloc.c (Fmake_string):
893 * character.c (string_escape_byte8):
894 * coding.c (coding_alloc_by_realloc):
895 * doprnt.c (doprnt):
896 * editfns.c (Fformat):
897 * eval.c (verror):
898 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
899 since they may not be the same number.
900 * editfns.c (Finsert_char):
901 * fileio.c (Finsert_file_contents):
902 Likewise for BUF_BYTES_MAX.
903
dd52fcea
PE
904 * image.c: Use ptrdiff_t, not int, for sizes.
905 (slurp_file): Switch from int to ptrdiff_t.
906 All uses changed.
907 (slurp_file): Check that file size fits in both size_t (for
908 malloc) and ptrdiff_t (for sanity and safety).
909
7f9bbdbb
PE
910 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
911 if b->modtime has its maximal value.
912
dfe18f82
PE
913 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
914
84acfcf0
PE
915 Don't assume time_t can fit into int.
916 * buffer.h (struct buffer.modtime): Now time_t, not int.
917 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
918 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
919
ccd9a01a
PE
920 Minor fixes for signed vs unsigned integers.
921 * character.h (MAYBE_UNIFY_CHAR):
922 * charset.c (maybe_unify_char):
923 * keyboard.c (read_char, reorder_modifiers):
924 XINT -> XFASTINT, since the integer must be nonnegative.
925 * ftfont.c (ftfont_spec_pattern):
926 * keymap.c (access_keymap, silly_event_symbol_error):
927 XUINT -> XFASTINT, since the integer must be nonnegative.
928 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
929 since it makes no difference and we prefer signed.
930 * keyboard.c (record_char): Use XUINT when all the neighbors do.
931 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
932 nonnegative.
933
d6d100dd
SM
9342011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
935
936 * window.h (Fwindow_frame): Declare.
937
2b6148e4
PE
9382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
939
940 * alloc.c: Simplify handling of large-request failures (Bug#8800).
941 (SPARE_MEMORY): Always define.
942 (LARGE_REQUEST): Remove.
943 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
944
f230ecc9
MR
9452011-06-06 Martin Rudalics <rudalics@gmx.at>
946
727e958e
MR
947 * lisp.h: Move EXFUNS for Fframe_root_window,
948 Fframe_first_window and Fset_frame_selected_window to window.h.
949
950 * window.h: Move EXFUNS for Fframe_root_window,
951 Fframe_first_window and Fset_frame_selected_window here from
952 lisp.h.
953
954 * frame.c (Fwindow_frame, Fframe_first_window)
955 (Fframe_root_window, Fframe_selected_window)
956 (Fset_frame_selected_window): Move to window.c.
957 (Factive_minibuffer_window): Move to minibuf.c.
958 (Fother_visible_frames_p): New function.
959
960 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
961
f230ecc9
MR
962 * window.c (decode_window, decode_any_window): Move up in code.
963 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
964 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
965 (Fwindow_buffer): Move up and rewrite doc-string.
966 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
967 (Fwindow_prev): New functions.
727e958e
MR
968 (Fwindow_frame): Move here from frame.c. Accept any window as
969 argument.
970 (Fframe_root_window, Fframe_first_window)
971 (Fframe_selected_window): Move here from frame.c. Accept frame
972 or arbitrary window as argument. Update doc-strings.
973 (Fminibuffer_window): Move up in code.
974 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
975 (Fset_frame_selected_window): Move here from frame.c.
976 Marginal rewrite.
727e958e
MR
977 (Fselected_window, select_window, Fselect_window): Move up in
978 code. Minor doc-string fixes.
f230ecc9 979
4d09bcf6
PE
9802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
981
982 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
983 Do not assume that spare memory exists; that assumption is valid
984 only if SYSTEM_MALLOC.
985 (LARGE_REQUEST): New macro, so that the issue of large requests
986 is separated from the issue of spare memory.
987
810928a2
AS
9882011-06-05 Andreas Schwab <schwab@linux-m68k.org>
989
172418ad
AS
990 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
991 format. (Bug#8806)
992
43f862f7
AS
993 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
994
810928a2
AS
995 * xfns.c (x_set_scroll_bar_default_width): Move declarations
996 before statements.
997
a059fe24
JD
9982011-06-05 Jan Djärv <jan.h.d@swipnet.se>
999
1000 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1001
1002 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1003
1004 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1005 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1006
989bf368
JB
10072011-06-05 Juanma Barranquero <lekktu@gmail.com>
1008
1009 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1010
4b80f674
CY
10112011-06-04 Chong Yidong <cyd@stupidchicken.com>
1012
1013 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1014 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1015 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1016 New error handlers.
4b80f674
CY
1017 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1018 Obey Vx_select_enable_clipboard_manager. Catch errors in
1019 x_clipboard_manager_save (Bug#8779).
1020 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1021 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1022
99a33b77 10232011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1024
1025 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1026
99a33b77 10272011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1028
1029 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1030 in the current matrix if keep_current_p is non-zero.
1031
8264569d
EZ
10322011-06-04 Eli Zaretskii <eliz@gnu.org>
1033
1034 * bidi.c (bidi_level_of_next_char): Fix last change.
1035
57f97249
EZ
10362011-06-03 Eli Zaretskii <eliz@gnu.org>
1037
fec2107c 1038 Support bidi reordering of text covered by display properties.
57f97249 1039
fec2107c
EZ
1040 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1041 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1042 (bidi_cache_search, bidi_cache_iterator_state)
1043 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1044 (bidi_level_of_next_char, bidi_move_to_visually_next):
1045 Support character positions inside a run of characters covered by a
fec2107c
EZ
1046 display string.
1047 (bidi_paragraph_init, bidi_resolve_explicit_1)
1048 (bidi_level_of_next_char): Call bidi_fetch_char and
1049 bidi_fetch_char_advance instead of FETCH_CHAR and
1050 FETCH_CHAR_ADVANCE.
1051 (bidi_init_it): Initialize new members.
1052 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1053 definitions.
1054 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1055 instead of using explicit *_CHAR codes.
d6d100dd
SM
1056 (bidi_resolve_explicit, bidi_resolve_weak):
1057 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1058 bidirectional text is supported only in multibyte buffers.
1059 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1060 it to initialize the frame_window_p member of struct bidi_it.
1061 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1062 (bidi_resolve_explicit, bidi_resolve_weak)
1063 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1064 bidi_it->nchars is non-positive.
1065 (bidi_level_of_next_char): Don't try to lookup the cache for the
1066 next/previous character if nothing is cached there yet, or if we
1067 were just reseat()'ed to a new position.
c40e2fb2 1068
0e14fe90
EZ
1069 * xdisp.c (set_cursor_from_row): Set start and stop points
1070 according to the row's direction when priming the loop that looks
1071 for the glyph on which to display cursor.
1072 (single_display_spec_intangible_p): Function deleted.
1073 (display_prop_intangible_p): Reimplement to call
1074 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1075 Accept 3 additional arguments needed by handle_display_spec.
1076 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1077 values: lists, `(when COND...)' forms, etc.
1078 (single_display_spec_string_p): Support property values that are
1079 lists with the argument STRING its top-level element.
1080 (display_prop_string_p): Fix the condition for processing a
1081 property that is a list to be consistent with handle_display_spec.
fec2107c 1082 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1083 last portion of handle_display_prop.
1084 (compute_display_string_pos): Accept additional argument
1085 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1086 value of a `display' property is a "replacing spec".
1087 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1088 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1089 the display property, but just return a value indicating whether
1090 the display property will replace the characters it covers.
1091 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1092 frame_window_p members of struct bidi_it.
d6d100dd
SM
1093 (compute_display_string_pos, compute_display_string_end):
1094 New functions.
fec2107c
EZ
1095 (push_it): Accept second argument POSITION, where pop_it should
1096 jump to continue iteration.
1097 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1098
fec2107c
EZ
1099 * keyboard.c (adjust_point_for_property): Adjust the call to
1100 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1101
1102 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1103 (bidi_init_it): Update prototypes.
1104 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1105 (compute_display_string_pos, compute_display_string_end):
1106 Declare prototypes.
fec2107c
EZ
1107 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1108 EMACS_INT.
fc6f18ce 1109
40087514 11102011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1111
57f53182
PE
1112 Malloc failure behavior now depends on size of allocation.
1113 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1114 * lisp.h: Change signatures accordingly.
1115 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1116 All callers changed. (Bug#8762)
1117
1118 * gnutls.c: Use Emacs's memory allocators.
1119 Without this change, the gnutls library would invoke malloc etc.
1120 directly, which causes problems on non-SYNC_INPUT hosts, and which
1121 runs afoul of improving memory_full behavior. (Bug#8761)
1122 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1123 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1124 xfree instead of the default malloc, realloc, free.
1125 (Fgnutls_boot): No need to check for memory allocation failure,
1126 since xmalloc does that for us.
1127
ac32cd99 1128 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1129 * category.c (hash_get_category_set):
1130 * ccl.c (ccl_driver):
1131 * charset.c (Fdefine_charset_internal):
1132 * charset.h (struct charset.hash_index):
1133 * composite.c (get_composition_id, gstring_lookup_cache)
1134 (composition_gstring_put_cache):
1135 * composite.h (struct composition.hash_index):
1136 * dispextern.h (struct image.hash):
1137 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1138 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1139 (hashfn_equal, hashfn_user_defined, make_hash_table)
1140 (maybe_resize_hash_table, hash_lookup, hash_put)
1141 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1142 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1143 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1144 * image.c (make_image, search_image_cache, lookup_image)
1145 (xpm_put_color_table_h):
1146 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1147 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1148 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1149 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1150 * alloc.c (allocate_vectorlike):
1151 Check for overflow in vector size calculations.
1152 * ccl.c (ccl_driver):
1153 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1154 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1155 need to be updated by these changes.
40087514
PE
1156 * fns.c (make_hash_table, maybe_resize_hash_table):
1157 Check for integer overflow with large hash tables.
0de4bb68
PE
1158 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1159 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1160 (SXHASH_REDUCE): New macro.
1161 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1162 Use it instead of discarding useful hash info with large hash values.
1163 (sxhash_float): New function.
1164 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1165 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1166 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1167 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1168 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1169 Adjust signatures to match updated version of code.
1170 (consing_since_gc): Now EMACS_INT, since a single hash table can
1171 use more than INT_MAX bytes.
1172
698d32e2
DN
11732011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1174
1175 Make it possible to build with GCC-4.6+ -O2 -flto.
1176
1177 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1178
fd6fa53f
SM
11792011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1180
1181 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1182 Call minibuffer-inactive-mode.
1183
864db017
JB
11842011-05-31 Juanma Barranquero <lekktu@gmail.com>
1185
1186 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1187 Update dependencies.
1188
2ad0baf4
DN
11892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1190
1191 * data.c (init_data): Remove code for UTS, this system is not
1192 supported anymore.
1193
4fcc2638
DN
11942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1195
1196 Don't force ./temacs to start in terminal mode.
1197
1198 * frame.c (make_initial_frame): Initialize faces in all cases, not
1199 only when CANNOT_DUMP is defined.
1200 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1201
c56e0fd5
DN
12022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1203
1204 * dispnew.c (add_window_display_history): Use const for the string
1205 pointer. Remove declaration, not needed.
1206
333d54da 12072011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1208
55d4c1b2 1209 Use 'inline', not 'INLINE'.
333d54da 1210 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1211 * alloc.c, fontset.c (INLINE): Remove.
1212 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1213 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1214 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1215 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1216 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1217
738db178
DN
12182011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1219
1220 Make it possible to run ./temacs.
1221
1222 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1223 syms_of_callproc does the same thing. Remove test for
1224 "initialized", do it in the caller.
1225 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1226
620c53a6
SM
12272011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1228
1229 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1230 (read_minibuf): Use get_minibuffer.
1231 (syms_of_minibuf): Use DEFSYM.
1232 (Qmetadata): New var.
1233 * data.c (Qbuffer): Don't make it static.
1234 (syms_of_data): Use DEFSYM.
1235
e003a292
PE
12362011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1237
1238 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1239 (CCL_CODE_MIN): New macro.
1240
ed008a6d
PE
12412011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1242
3687c2ef
PE
1243 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1244
ed008a6d
PE
1245 * eval.c (Qdebug): Now static.
1246 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1247 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1248 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1249
d66c4c7c
CY
12502011-05-29 Chong Yidong <cyd@stupidchicken.com>
1251
1252 * image.c: Various fixes to ImageMagick code comments.
1253 (Fimagemagick_types): Doc fix.
1254
5fbc2025
PE
12552011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1256
0196f88a
PE
1257 Minor fixes prompted by GCC 4.6.0 warnings.
1258
1259 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1260
5fbc2025
PE
1261 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1262 (x_clipboard_manager_save_all): Move extern decl to ...
1263 * xterm.h: ... here, so that it can be checked for consistency.
1264
1dd3c2d9
CY
12652011-05-29 Chong Yidong <cyd@stupidchicken.com>
1266
1267 * xselect.c (x_clipboard_manager_save_frame)
1268 (x_clipboard_manager_save_all): New functions.
1269 (Fx_clipboard_manager_save): Lisp function deleted.
1270
1271 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1272 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1273
1274 * xterm.h: Update prototype.
1275
5ba6571d
WX
12762011-05-28 William Xu <william.xwl@gmail.com>
1277
1278 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1279 exiting (Bug#8239).
1280
3eaff834
JM
12812011-05-28 Jim Meyering <meyering@redhat.com>
1282
e1900994 1283 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1284 * fns.c (to_uchar): Define.
1285 (crypto_hash_function): Use it to convert some newly-signed
1286 variables to unsigned, to avoid sign-extension bugs. For example,
1287 without this change, (md5 "truc") would evaluate to
1288 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1289 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1290 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1291
0f6990a7
PE
12922011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1293
1294 Integer overflow fixes.
c8a9ca5a 1295
08686060
PE
1296 * dbusbind.c: Serial number integer overflow fixes.
1297 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1298 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1299 to hold a serial number that is too large for a fixnum.
1300 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1301 Check for serial numbers out of range. Decode any serial number
59568bf0 1302 that was so large that it became a float. (Bug#8722)
08686060 1303
2d1fc3c7
PE
1304 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1305 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1306 Use XFASTINT rather than XUINT when numbers are nonnegative.
1307 (xd_append_arg, Fdbus_method_return_internal):
1308 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1309 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1310 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1311 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1312 (Bug#8722)
2d1fc3c7 1313
c8a9ca5a
PE
1314 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1315
519e1d69
PE
1316 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1317
30569699
PE
1318 ccl: add integer overflow checks
1319 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1320 (IN_INT_RANGE): New macros.
1321 (ccl_driver): Use them to check for integer overflow when
1322 decoding a CCL program. Many of the new checks are whether XINT (x)
1323 fits in int; it doesn't always, on 64-bit hosts. The new version
1324 doesn't catch all possible integer overflows, but it's an
847044ea 1325 improvement. (Bug#8719)
30569699 1326
c11285dc
PE
1327 * alloc.c (make_event_array): Use XINT, not XUINT.
1328 There's no need for unsigned here.
1329
fdccd48e
PE
1330 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1331 This follows up to the 2011-05-06 change that substituted uintptr_t
1332 for EMACS_INT. This case wasn't caught back then.
1333
37910ab2
PE
1334 Rework Fformat to avoid integer overflow issues.
1335 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1336 now (part of C89). Include <verify.h>.
1337 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1338 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1339 (Fformat): Avoid the prepass trying to compute sizes; it was only
1340 approximate and thus did not catch overflow reliably. Instead, walk
1341 through the format just once, formatting and computing sizes as we go,
1342 checking for integer overflow at every step, and allocating a larger
1343 buffer as needed. Keep track separately whether the format is
1344 multibyte. Keep only the most-recently calculated precision, rather
1345 than them all. Record whether each argument has been converted to
1346 string. Use EMACS_INT, not int, for byte and char and arg counts.
1347 Support field widths and precisions larger than INT_MAX. Avoid
1348 sprintf's undefined behavior with conversion specifications such as %#d
1349 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1350 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1351 formatting out-of-range floating point numbers with int
1352 formats. (Bug#8668)
1353
2e6578fb
PE
1354 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1355
0ae6bdee
PE
1356 * data.c: Avoid integer truncation in expressions involving floats.
1357 * data.c: Include <intprops.h>.
1358 (arith_driver): When there's an integer overflow in an expression
1359 involving floating point, convert the integers to floating point
1360 so that the resulting value does not suffer from catastrophic
1361 integer truncation. For example, on a 64-bit host (* 4
1362 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1363 Do not rely on undefined behavior after integer overflow.
1364
de883a70
PE
1365 merge count_size_as_multibyte, parse_str_to_multibyte
1366 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1367 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1368 Check for integer overflow.
1369 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1370 since it's now a duplicate of the other. This is more of
1371 a character than a buffer op, so better that it's in character.c.
1372 * fns.c, print.c: Adjust to above changes.
1373
2ff916cb
PE
13742011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1375
1376 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1377
f1b54466
PE
13782011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1379
fb1ac845
PE
1380 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1381 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1382 (x_clipboard_manager_save): Now static.
1383 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1384
f1b54466
PE
1385 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1386 (crypto_hash_function): Now static.
1387 Fix pointer signedness problems. Avoid unnecessary initializations.
1388
a9f737ee
CY
13892011-05-27 Chong Yidong <cyd@stupidchicken.com>
1390
1391 * termhooks.h (Vselection_alist): Make it terminal-local.
1392
1393 * terminal.c (create_terminal): Initialize it.
1394
1395 * xselect.c: Support for clipboard managers.
1396 (Vselection_alist): Move to termhooks.h as terminal-local var.
1397 (LOCAL_SELECTION): New macro.
1398 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1399 (symbol_to_x_atom): Remove gratuitous arg.
1400 (x_handle_selection_request, lisp_data_to_selection_data)
1401 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1402 (x_own_selection, x_get_local_selection, x_convert_selection):
1403 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1404 (some_frame_on_display): Delete unused function.
1405 (Fx_own_selection_internal, Fx_get_selection_internal)
1406 (Fx_disown_selection_internal, Fx_selection_owner_p)
1407 (Fx_selection_exists_p): New optional frame arg.
1408 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1409 (x_handle_selection_clear): Don't treat other terminals with the
1410 same keyboard specially. Use the terminal-local Vselection_alist.
1411 (x_clear_frame_selections): Use Frun_hook_with_args.
1412
1413 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1414
1415 * xterm.h: Add support for those atoms.
1416
e067f0c1
CY
14172011-05-26 Chong Yidong <cyd@stupidchicken.com>
1418
1419 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1420 (converted_selections, conversion_fail_tag): New global variables.
1421 (x_selection_request_lisp_error): Free the above.
1422 (x_get_local_selection): Remove unnecessary code.
1423 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1424 of converted selections stored in converted_selections.
1425 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1426 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1427 (x_convert_selection): New function.
1428 (x_handle_selection_event): Simplify.
1429 (x_get_foreign_selection): Don't ignore incoming requests while
1430 waiting for an answer; this will fail when we implement
1431 SAVE_TARGETS, and seems unnecessary anyway.
1432 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1433 (Vx_sent_selection_functions): Doc fix.
1434
0f4aebc0
LL
14352011-05-26 Leo Liu <sdl.web@gmail.com>
1436
1437 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1438
e61124cd
YM
14392011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1440
1441 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1442
1443 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1444 for fringe update if it has periodic bitmap.
1445 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1446 and fringe_bitmap_periodic_p.
1447
1448 * fringe.c (get_fringe_bitmap_data): New function.
1449 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1450 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1451 row. Mark glyph row for fringe update if periodicity changed.
1452
1453 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1454 for fringe update unless it has periodic bitmap.
1455
f16d9837
KH
14562011-05-25 Kenichi Handa <handa@m17n.org>
1457
1458 * xdisp.c (get_next_display_element): Set correct it->face_id for
1459 a static composition.
1460
e1b90ef6
LL
14612011-05-24 Leo Liu <sdl.web@gmail.com>
1462
1463 * deps.mk (fns.o):
1464 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1465
1466 * fns.c (crypto_hash_function, Fsha1): New function.
1467 (Fmd5): Use crypto_hash_function.
1468 (syms_of_fns): Add Ssha1.
1469
7400048f
PE
14702011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1471
1472 * gnutls.c: Remove unused macros.
1473 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1474 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1475 Remove macros that are defined and never used.
1476 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1477
abb71cf4
CY
14782011-05-22 Chong Yidong <cyd@stupidchicken.com>
1479
1480 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1481 (Fx_get_selection_internal): Minor cleanup.
1482 (Fx_own_selection_internal): Rename arguments for consistency with
1483 select.el.
1484
6307db39
PE
14852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1486
1487 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1488
f3d4e0a4
CY
14892011-05-22 Chong Yidong <cyd@stupidchicken.com>
1490
1491 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1492
4d8ade89
YM
14932011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1494
1495 * dispnew.c (scrolling_window): Don't exclude the case that the
1496 last enabled row in the desired matrix touches the bottom boundary.
1497
32078c8d
GM
14982011-05-21 Glenn Morris <rgm@gnu.org>
1499
1500 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1501 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1502 and add some more files.
32078c8d 1503
7285dc67
EZ
15042011-05-20 Eli Zaretskii <eliz@gnu.org>
1505
1506 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1507 report_file_error introduced by the change from 2011-05-07.
1508
89d1bd22
PE
15092011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1510
1511 * systime.h (Time): Define only if emacs is defined.
1512 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1513 where the include path doesn't have X11/X.h by default. See
1514 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1515
e23640bb 15162011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1517
1518 * composite.c (find_automatic_composition): Fix previous change.
1519
b9704ad9
GM
15202011-05-20 Glenn Morris <rgm@gnu.org>
1521
1522 * lisp.mk: New file, split from Makefile.in.
1523 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1524 (shortlisp): Remove.
1525 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1526
4a720484
GM
15272011-05-19 Glenn Morris <rgm@gnu.org>
1528
1529 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1530 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1531 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1532 (lisp): Set the order to that of loadup.el.
1533 (shortlisp): Make it a copy of $lisp.
1534 (SOME_MACHINE_LISP): Remove.
1535 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1536 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1537
a28d4396
KH
15382011-05-18 Kenichi Handa <handa@m17n.org>
1539
1540 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1541 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1542 (find_automatic_composition): Mostly rewrite for efficiency.
1543
a2b1fa8e
JB
15442011-05-18 Juanma Barranquero <lekktu@gmail.com>
1545
1546 * makefile.w32-in: Update dependencies.
1547
8e1f5610
CS
15482011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1549
1550 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1551 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1552
7025ee00 15532011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1554
cdfa6eab
PE
1555 Fix some integer overflow issues, such as string length overflow.
1556
06d6db33
PE
1557 * insdel.c (count_size_as_multibyte): Check for string overflow.
1558
2b4560a8
PE
1559 * character.c (lisp_string_width): Check for string overflow.
1560 Use EMACS_INT, not int, for string indexes and lengths; in
1561 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1562 the resulting string length overflows an EMACS_INT; instead,
1563 report a string overflow if no precision given. When checking for
1564 precision exhaustion, use a check that cannot possibly have
1565 integer overflow. (Bug#8675)
1566 * character.h (lisp_string_width): Adjust to new signature.
1567
cb93f9be
PE
1568 * alloc.c (string_overflow): New function.
1569 (Fmake_string): Use it. This doesn't change behavior, but saves
1570 a few bytes and will simplify future changes.
1571 * character.c (string_escape_byte8): Likewise.
1572 * lisp.h (string_overflow): New decl.
1573
1a1f3366
PE
1574 Fixups, following up to the user-interface timestamp change.
1575 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1576 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1577 * msdos.c (mouse_get_pos): Likewise.
1578 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1579 * w32gui.h (Time): Define by including "systime.h" rather than by
1580 declaring it ourselves. (Bug#8664)
1581
d4e3e4d3
PE
1582 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1583 * image.c (clear_image_cache): Likewise.
1584
f6a24d19
PE
1585 * term.c (term_mouse_position): Don't assume time_t wraparound.
1586
08dc5ae6
PE
1587 Be more systematic about user-interface timestamps.
1588 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1589 and sometimes 'EMACS_UINT', to represent these timestamps.
1590 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1591 This makes the code easier to follow, and makes it easier to catch
1592 integer overflow bugs such as Bug#8664.
1593 * frame.c (Fmouse_position, Fmouse_pixel_position):
1594 Use Time, not unsigned long, for user-interface timestamps.
1595 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1596 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1597 * keyboard.h (last_event_timestamp): Likewise.
1598 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1599 * menu.h (xmenu_show): Likewise.
1600 * term.c (term_mouse_position): Likewise.
1601 * termhooks.h (struct input_event.timestamp): Likewise.
1602 (struct terminal.mouse_position_hook): Likewise.
1603 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1604 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1605 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1606 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1607 what it was before.
1608 * menu.h, termhooks.h: Include "systime.h", for Time.
1609
8e55734a
PE
1610 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1611 Don't assume that the difference between two unsigned long values
1612 can fit into an integer. At this point, we know button_down_time
1613 <= event->timestamp, so the difference must be nonnegative, so
1614 there's no need to cast the result if double-click-time is
1615 nonnegative, as it should be; check that it's nonnegative, just in
1616 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1617 apart (about 25 days). (Bug#8664)
8e55734a 1618
841f1b75 1619 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1620 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1621
3e26f69c
PE
1622 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1623 that always fit in int. Use a sentinel instead of a counter, to
1624 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1625 * frame.h (struct frame): Use int for menu_bar_items_used
1626 instead of EMACS_INT, since it always fits in int.
3e26f69c 1627
5cc152c0
PE
1628 * menu.c (grow_menu_items): Check for int overflow.
1629
d89eb65e
PE
1630 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1631
5235bd3e
PE
1632 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1633 Before, the code was not consistent. These values cannot exceed
1634 2**31 - 1 so there's no need to make them unsigned.
1635 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1636 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1637 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1638 as modifiers.
1639 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1640
bc827e23
PE
1641 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1642 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1643 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1644 presumably because the widths might not match.
1645
78eb494e
PE
1646 * window.c (size_window): Avoid needless test at loop start.
1647
04f2d78b
CB
16482011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1649
1650 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1651
d2fc7e3d 16522011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1653
1654 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1655
d2fc7e3d 16562011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1657
1658 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1659 `width' to `bar_area_x' and `bar_area_width', respectively.
1660 (x_scroll_run): Take account of fringe background extension.
1661
04f2d78b
CB
1662 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1663 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1664 `bar_area_width', respectively.
1665 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1666 background extension.
1667
79b70037
GM
16682011-05-10 Jim Meyering <meyering@redhat.com>
1669
1670 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1671
2f142cc5
JB
16722011-05-10 Juanma Barranquero <lekktu@gmail.com>
1673
1674 * image.c (Finit_image_library): Return t for built-in image types,
1675 like pbm and xbm. (Bug#8640)
1676
57679c86
AS
16772011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1678
1679 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1680
888c9e86
EZ
16812011-05-07 Eli Zaretskii <eliz@gnu.org>
1682
b0512a1d
EZ
1683 * w32console.c (Fset_screen_color): Doc fix.
1684 (Fget_screen_color): New function.
1685 (syms_of_ntterm): Defsubr it.
1686
7285dc67
EZ
1687 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1688 unlink the temporary file if Fcall_process didn't create it in the
1689 first place.
1690 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1691 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1692 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1693 cue to call_process_cleanup not to close that handle.
1694
4d3fcc8e
BK
16952011-05-07 Ben Key <bkey76@gmail.com>
1696
1697 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1698 one of two shell specific rules, either bootstrap-temacs-CMD or
1699 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1700 to the previous implementation of the bootstrap-temacs rule.
1701 The bootstrap-temacs-CMD rule is similar to the previous
1702 implementation of the bootstrap-temacs rule except that it
1703 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1704 variable.
1705
1706 These changes, along with some changes to nt/configure.bat,
1707 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1708 earlier fix to add support for --cflags and --ldflags options
1709 that include quotes so that it works whether make uses cmd or
1710 sh as the shell.
1711
b4289b64
MA
17122011-05-06 Michael Albinus <michael.albinus@gmx.de>
1713
1714 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1715 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1716 is a constant.
1717 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1718 a string. Handle both cases.
1719 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1720 (Fdbus_register_method): Use Qinvalid_function.
1721
af4c0e28
JB
17222011-05-06 Juanma Barranquero <lekktu@gmail.com>
1723
1724 * makefile.w32-in: Update dependencies.
1725 (LISP_H): Add inttypes.h and stdin.h.
1726 (PROCESS_H): Add unistd.h.
1727
c51453d9
EZ
17282011-05-06 Eli Zaretskii <eliz@gnu.org>
1729
1730 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1731 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1732
8ff0ac3c 17332011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1734
4c4b566b
PE
1735 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1736
aab2b9b5
PE
1737 * term.c (vfatal): Remove stray call to va_end.
1738 It's not needed and the C Standard doesn't allow it here anyway.
1739
c378da0b
PE
1740 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1741 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1742
288b08c7
PE
1743 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1744 bytes.
1745
e3601888
PE
1746 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1747
db6c0e74
PE
1748 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1749
dd5963ea
PE
1750 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1751
88c9450f
PE
1752 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1753
2f9442b8
PE
1754 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1755
c032b5f8
PE
1756 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1757 * charset.c (Fdefine_charset_internal): Don't initialize
1758 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1759 32-bit int (Bug#8600).
a108c10b
PE
1760
1761 * lread.c (read_integer): Be more consistent with string-to-number.
1762 Use string_to_number to do the actual conversion; this avoids
1763 rounding errors and fixes some other screwups. Without this fix,
1764 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1765 (digit_to_number): Move earlier, for benefit of read_integer.
1766 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1767 not a digit in any supported base. (Bug#8602)
a108c10b 1768
ad5f9eea
PE
1769 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1770
aec1708a
PE
1771 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1772 to match comment at start of function. This also removes a
1773 GCC warning about overflow in a 32+64-bit port.
1774
47be4ab5
PE
1775 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1776
371cac43
PE
1777 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1778 Reported by Stefan Monnier in
1779 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1780 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1781 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1782
d01a7826
PE
1783 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1784 (EMACS_UINTPTR): Likewise, with uintptr_t.
1785
7fd47d5c
PE
1786 * lisp.h: Prefer 64-bit EMACS_INT if available.
1787 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1788 on 32-bit hosts that have 64-bit int, so that they can access
1789 large files.
122b0c86
PE
1790 However, temporarily disable this change unless the temporary
1791 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1792
8727937b
PE
1793 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1794
8ac068ac
PE
1795 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1796 This removes an assumption that EMACS_INT and long are the same
1797 width as pointers. The assumption is true for Emacs porting targets
1798 now, but we want to make other targets possible.
1799 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1800 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1801 In the rest of the code, change types of integers that hold casted
1802 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1803 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1804 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1805 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1806 No need to cast type when ORing.
1807 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1808 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1809 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1810 assume EMACS_INT is the same width as char *.
1811 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1812 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1813 Remove no-longer-needed casts.
1814 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1815 (xg_tool_bar_help_callback, xg_make_tool_item):
1816 Use EMACS_INTPTR to hold an integer
1817 that will be cast to void *; this can avoid a GCC warning
1818 if EMACS_INT is not the same width as void *.
1819 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1820 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1821 (current_message_1, set_message_1):
1822 Use a local to convert to proper width without a cast.
1823 * xmenu.c (dialog_selection_callback): Likewise.
1824
ede49d71
PE
1825 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1826 Also, don't assume VALBITS / RAND_BITS is less than 5,
1827 and don't rely on undefined behavior when shifting a 1 left into
1828 the sign bit.
1829 * lisp.h (get_random): Change signature to match.
1830
2f30ecd0
PE
1831 * lread.c (hash_string): Use size_t, not int, for hash computation.
1832 Normally we prefer signed values; but hashing is special, because
1833 it's better to use unsigned division on hash table sizes so that
1834 the remainder is nonnegative. Also, size_t is the natural width
1835 for hashing into memory. The previous code used 'int', which doesn't
1836 retain enough info to hash well into very large tables.
1837 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1838
2a866e7b
PE
1839 * dbusbind.c: Don't possibly lose pointer info when converting.
1840 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1841 Use XPNTR rather than XHASH, so that the high-order bits of
1842 the pointer aren't lost when converting through void *.
1843
51639eac
PE
1844 * eval.c (Fautoload): Don't double-shift a pointer.
1845
92394119
PE
1846 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1847
dbdb9a7c
JB
18482011-05-06 Juanma Barranquero <lekktu@gmail.com>
1849
1850 * gnutls.c (DEF_GNUTLS_FN):
1851 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1852
db7a0b4f
AS
18532011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1854
1855 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1856 marker. (Bug#8610)
1857
f7ff1b0f 18582011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1859
1860 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1861 New version that can reserve upto 2GB of heap space.
1862
f7ff1b0f 18632011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1864
1865 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1866
639c109b
TZ
18672011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1868
1869 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1870 `gnutls_certificate_set_x509_key_file'.
1871
d2127135
JB
18722011-05-05 Juanma Barranquero <lekktu@gmail.com>
1873
1874 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1875 Update dependencies.
1876
e968f4f3
JB
18772011-05-04 Juanma Barranquero <lekktu@gmail.com>
1878
1879 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1880 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1881 Remove unused parameter `fildes'.
1882 * process.c (read_process_output, send_process): Don't pass it.
1883
84d358f0
JB
18842011-05-04 Juanma Barranquero <lekktu@gmail.com>
1885
1886 Fix previous change: the library cache is defined in w32.c.
1887 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1888 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1889
0898ca10
JB
18902011-05-04 Juanma Barranquero <lekktu@gmail.com>
1891
1892 Implement dynamic loading of GnuTLS on Windows.
1893
1894 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1895 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1896 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1897 Declare.
1898
1899 * gnutls.c (Qgnutls_dll): Define.
1900 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1901 (gnutls_*): Declare function pointers.
1902 (init_gnutls_functions): New function to initialize function pointers.
1903 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1904 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1905 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1906 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1907 (emacs_gnutls_write, emacs_gnutls_read)
1908 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1909 (Fgnutls_available_p): New function.
1910 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1911 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1912 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1913
1914 * image.c: Include w32.h.
1915 (Vimage_type_cache): Delete.
1916 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1917 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1918 (w32_delayed_load): Move to w32.c.
1919
1920 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1921
1922 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1923 (w32_delayed_load): Move from image.c. When loading a library, record
1924 its filename in the :loaded-from property of the library id.
1925 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1926 Initialize and staticpro them.
1927 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1928
1929 * process.c: Include lisp.h before w32.h, not after.
1930 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1931 instead of gnutls_record_check_pending.
1932
1933 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1934
ff4de4aa
TZ
19352011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1936
1937 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1938 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1939 as passed in.
1940
abe95abb
JD
19412011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1942
1943 * xterm.c (x_set_frame_alpha): Do not set property on anything
1944 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1945
e16e55d4
JB
19462011-05-02 Juanma Barranquero <lekktu@gmail.com>
1947
1948 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1949
bafcf6a5
JB
19502011-05-02 Juanma Barranquero <lekktu@gmail.com>
1951
1952 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1953 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1954 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1955 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1956 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1957 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1958 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1959 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1960 (Qgnutls_bootprop_callbacks_verify): Make static.
1961
e7a6747f
AS
19622011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1963
19ed11ba
AS
1964 * callproc.c: Indentation fixup.
1965
e7a6747f 1966 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1967 (wait_for_termination, interruptible_wait_for_termination):
1968 Move after wait_for_termination_1.
e7a6747f 1969
1ef14cb4
LMI
19702011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1971
1972 * sysdep.c (interruptible_wait_for_termination): New function
1973 which is like wait_for_termination, but allows keyboard
1974 interruptions.
1975
1976 * callproc.c (Fcall_process): Add (:file "file") as an option for
1977 the STDOUT buffer.
1978 (Fcall_process_region): Ditto.
1979
330d880c
EZ
19802011-04-30 Eli Zaretskii <eliz@gnu.org>
1981
8db90b73
EZ
1982 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1983 rather than `XVECTOR (FOO)->size'.
1984
330d880c
EZ
1985 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1986 inttypes.h, as a gnulib replacement is used if it not available in
1987 system headers.
1988
15cbd324
EZ
19892011-04-21 Eli Zaretskii <eliz@gnu.org>
1990
1991 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1992 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1993 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1994
1995 * coding.c (coding_alloc_by_realloc): Error out if destination
1996 will grow beyond MOST_POSITIVE_FIXNUM.
1997 (decode_coding_emacs_mule): Abort if there isn't enough place in
1998 charbuf for the composition carryover bytes. Reserve an extra
1999 space for up to 2 characters produced in a loop.
2000 (decode_coding_iso_2022): Abort if there isn't enough place in
2001 charbuf for the composition carryover bytes.
2002
20032011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2004
ae940cca
EZ
2005 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2006 aborting when %lld or %lll format is passed.
2007 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2008 %llo or %llx format is passed. (Bug#8545)
2009
03ab8921
EZ
2010 * window.c (window_scroll_line_based): Use a marker instead of
2011 simple variables to record original value of point. (Bug#7952)
2012
afda1437
EZ
2013 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2014 produced by %s or %c overflows available buffer space. (Bug#8545)
2015
f76dee0c
PE
20162011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2017
2018 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2019 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2020
fdc5744d
JB
20212011-04-28 Juanma Barranquero <lekktu@gmail.com>
2022
2023 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2024
638f053a
JB
20252011-04-28 Juanma Barranquero <lekktu@gmail.com>
2026
2027 * keyboard.c (Qdelayed_warnings_hook): Define.
2028 (command_loop_1): Run `delayed-warnings-hook'
2029 if Vdelayed_warnings_list is non-nil.
2030 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2031 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2032
d178f871
EZ
20332011-04-28 Eli Zaretskii <eliz@gnu.org>
2034
2035 * doprnt.c (doprnt): Don't return value smaller than the buffer
2036 size if the message was truncated. (Bug#8545).
2037
b124fd93
JB
20382011-04-28 Juanma Barranquero <lekktu@gmail.com>
2039
2040 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2041 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2042
e810457d
PE
20432011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2044
2045 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2046
ea51cceb
JB
20472011-04-27 Juanma Barranquero <lekktu@gmail.com>
2048
2049 * makefile.w32-in: Update dependencies.
2050
94dcfacf
EZ
20512011-04-27 Eli Zaretskii <eliz@gnu.org>
2052
2053 Improve `doprnt' and its usage. (Bug#8545)
2054 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2055 `format_end'. Remove support for %l as a conversion specifier.
2056 Don't use xrealloc. Improve diagnostics when the %l size modifier
2057 is used. Update the commentary.
2058
2059 * eval.c (verror): Simplify calculation of size_t.
2060
2061 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2062 messages.
2063
f61f41d7
PE
20642011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2065
2066 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2067 change.
2068
96fb4434
PE
20692011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2070
2071 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2072 This makes this file independent of the recent pseudovector change.
2073
671875da 20742011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2075
69e9b5a3
PE
2076 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2077
b5f869a7 2078 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2079 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2080 Remove unused local.
c8926152 2081 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2082
841a1577 2083 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2084 GCC 4.6.0 optimizes based on type-based alias analysis.
2085 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2086 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2087 != &v->size, and therefore "v->size = 1; b->size = 2; return
2088 v->size;" must therefore return 1. This assumption is incorrect
2089 for Emacs, since it type-puns struct Lisp_Vector * with many other
2090 types. To fix this problem, this patch adds a new type struct
f904488f 2091 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2092 and pseudovectors, and helps optimizing compilers not get fooled
2093 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2094 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2095 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2096 the size member.
eab3844f
PE
2097 (XSETPVECTYPE): Rewrite in terms of new macro.
2098 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2099 This is a bit clearer, and further avoids the possibility of
2100 undesirable aliasing.
2101 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2102 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2103 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2104 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2105 (ASIZE): Now uses header.size rather than size.
2106 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2107 to avoid the hassle of writing XVECTOR (foo)->header.size.
2108 (struct vectorlike_header): New type.
eab3844f
PE
2109 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2110 object, to help avoid aliasing.
2111 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2112 (SUBRP): Likewise, since Lisp_Subr is a special case.
2113 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2114 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2115 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2116 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2117 changed to be "header.size" and "header.next".
2118 * buffer.h (struct buffer): Likewise.
2119 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2120 * frame.h (struct frame): Likewise.
2121 * process.h (struct Lisp_Process): Likewise.
2122 * termhooks.h (struct terminal): Likewise.
2123 * window.c (struct save_window_data, struct saved_window): Likewise.
2124 * window.h (struct window): Likewise.
2125 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2126 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2127 * buffer.c (init_buffer_once): Likewise.
2128 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2129 special case.
2130 * process.c (Fformat_network_address): Use local var for size,
2131 for brevity.
2132
0df1eac5
PE
2133 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2134
847ab9d1 2135 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2136 * data.c (atof): Remove decl; no longer used or needed.
2137 (digit_to_number): Move to lread.c.
2138 (Fstring_to_number): Use new string_to_number function, to be
2139 consistent with how the Lisp reader treats infinities and NaNs.
2140 Do not assume that floating-point numbers represent EMACS_INT
2141 without losing information; this is not true on most 64-bit hosts.
2142 Avoid double-rounding errors, by insisting on integers when
2143 parsing non-base-10 numbers, as the documentation specifies.
2144 * lisp.h (string_to_number): New decl, replacing ...
2145 (isfloat_string): Remove.
bc0a5c13 2146 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2147 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2148 appears to have been a coding error. Similarly, do not accept
2149 strings like +-1e0 as floating point numbers. Do not report
2150 overflow for integer overflows unless the base is not 10 which
2151 means we have no simple and reliable way to continue.
2152 Break out the floating-point parsing into a new
2153 function string_to_number, so that Fstring_to_number parses
2154 floating point numbers consistently with the Lisp reader.
04f2d78b 2155 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2156 (E_CHAR, EXP_INT): Remove, replacing with ...
2157 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2158 (string_to_number): New function, replacing isfloat_string.
2159 This function checks for valid syntax and produces the resulting
2160 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2161 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2162 so that overflow for non-base-10 numbers is reported only when
2163 there's no portable and simple way to convert to floating point.
452f4150 2164
67769ffc
PE
2165 * textprop.c (set_text_properties_1): Rewrite for clarity,
2166 and to avoid GCC warning about integer overflow.
2167
c20db43f
PE
2168 * intervals.h (struct interval): Use EMACS_INT for members
2169 where EMACS_UINT might cause problems. See
2170 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2171 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2172 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2173 All uses changed.
37aa2f85
PE
2174 (offset_intervals): Tell GCC not to worry about length overflow
2175 when negating a negative length.
c20db43f 2176
2538aa2f
PE
2177 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2178 (overrun_check_free): Likewise.
2179
f2d3008d
PE
2180 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2181 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2182 word size.
2183
ec8df744
PE
2184 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2185 (gnutls_make_error): Rename local to avoid shadowing.
2186 (gnutls_emacs_global_deinit): ifdef out; not used.
2187 (Fgnutls_boot): Use const for pointer to readonly storage.
2188 Comment out unused local. Fix pointer signedness problems.
2189
640ee02d
PE
2190 * lread.c (openp): Don't stuff size_t into an 'int'.
2191 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2192 about possible signed overflow.
2193
6048fb2a
PE
2194 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2195 (GDK_KEY_g): Don't define if already defined.
2196 (xg_prepare_tooltip): Avoid pointer signedness problem.
2197 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2198
fa3c87e1
PE
2199 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2200 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2201
2172544b
PE
2202 * xfns.c (Fx_window_property): Simplify a bit,
2203 to make a bit faster and to avoid GCC 4.6.0 warning.
2204 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2205
9b821a21
PE
2206 * fns.c (internal_equal): Don't assume size_t fits in int.
2207
3c616cfa
PE
2208 * alloc.c (compact_small_strings): Tighten assertion a little.
2209
c2982e87
PE
2210 Replace pEd with more-general pI, and fix some printf arg casts.
2211 * lisp.h (pI): New macro, generalizing old pEd macro to other
2212 conversion specifiers. For example, use "...%"pI"d..." rather
2213 than "...%"pEd"...".
2214 (pEd): Remove. All uses replaced with similar uses of pI.
2215 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2216 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2217 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2218 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2219 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2220 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2221 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2222 64-bit hosts.
2223 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2224 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2225 * print.c (safe_debug_print, print_object): Likewise.
2226 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2227 to int.
6f04d126
PE
2228 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2229 avoiding the 0 flag, which is not portable.
c2982e87
PE
2230 * process.c (Fmake_network_process): Use pI to avoid cast.
2231 * region-cache.c (pp_cache): Likewise.
2232 * xdisp.c (decode_mode_spec): Likewise.
2233 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2234 behavior on 64-bit hosts with printf arg.
6f04d126 2235 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2236 (x_stop_queuing_selection_requests): Likewise.
2237 (x_get_window_property): Don't truncate byte count to an 'int'
2238 when tracing.
0b432f21 2239
5e073ec7
PE
2240 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2241 here, since it parses constructs like leading '-' and spaces,
2242 which are not wanted; and it overflows with large numbers.
2243 Instead, simply match F[0-9]+, which is what is wanted anyway.
2244
36372bf9
PE
2245 * alloc.c: Remove unportable assumptions about struct layout.
2246 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2247 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2248 (allocate_vectorlike, make_pure_vector): Use the new macros,
2249 plus offsetof, to remove unportable assumptions about struct layout.
2250 These assumptions hold on all porting targets that I know of, but
2251 they are not guaranteed, they're easy to remove, and removing them
2252 makes further changes easier.
2253
0b432f21
PE
2254 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2255 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2256 (string_overrun_cookie): Now const. Use initializers that
2257 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2258 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2259 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2260 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2261 multiple of sizeof (EMACS_INT); it need not be, if
2262 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2263 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2264
895009e1
JB
22652011-04-26 Juanma Barranquero <lekktu@gmail.com>
2266
2267 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2268
6a7a1b0b
TZ
22692011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2270
2271 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2272 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2273 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2274
841a1577 22752011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2276
2277 * lisp.h (Qdebug): List symbol.
895009e1 2278 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2279 * keyboard.c (debug-on-event): New variable.
2280 (handle_user_signal): Break into debugger when debug-on-event
2281 matches the current signal symbol.
2282
f2d3ba6f
DN
22832011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2284
2285 * alloc.c (check_sblock, check_string_bytes)
2286 (check_string_free_list): Convert to standard C.
2287
42ce4c63
TZ
22882011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2289
2290 * w32.c (emacs_gnutls_push): Fix typo.
2291
825cd63c
EZ
22922011-04-25 Eli Zaretskii <eliz@gnu.org>
2293
fb11d64d
EZ
2294 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2295 "cast to pointer from integer of different size".
2296
825cd63c
EZ
2297 Improve doprnt and its use in verror. (Bug#8545)
2298 * doprnt.c (doprnt): Document the set of format control sequences
2299 supported by the function. Use SAFE_ALLOCA instead of always
2300 using `alloca'.
2301
2302 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2303 is one byte too soon. Don't use xrealloc; instead xfree and
2304 xmalloc anew.
2305
e061a11b
TZ
23062011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2307
2308 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2309 callbacks stage.
2310
2311 * gnutls.c: Renamed global_initialized to
2312 gnutls_global_initialized. Added internals for the
2313 :verify-hostname-error, :verify-error, and :verify-flags
2314 parameters of `gnutls-boot' and documented those parameters in the
2315 docstring. Start callback support.
2316 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2317 unless a fatal error occured. Call gnutls_alert_send_appropriate
2318 on error. Return error code.
2319 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2320 (emacs_gnutls_read): Likewise.
2321 (Fgnutls_boot): Return handshake error code.
2322 (emacs_gnutls_handle_error): New function.
2323 (wsaerror_to_errno): Likewise.
2324
2325 * w32.h (emacs_gnutls_pull): Add prototype.
2326 (emacs_gnutls_push): Likewise.
2327
2328 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2329 (emacs_gnutls_push): Likewise.
2330
23312011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2332
2333 * process.c (wait_reading_process_output): Check if GnuTLS
2334 buffered some data internally if no FDs are set for TLS
2335 connections.
2336
2337 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2338 (LIBS): Link to USER_LIBS.
2339 ($(BLD)/gnutls.$(0)): New target.
2340
fa6996bc
EZ
23412011-04-24 Eli Zaretskii <eliz@gnu.org>
2342
eb35682e
EZ
2343 * xdisp.c (handle_single_display_spec): Rename the
2344 display_replaced_before_p argument into display_replaced_p, to
2345 make it consistent with the commentary. Fix typos in the
2346 commentary.
2347
e2ad650c
EZ
2348 * textprop.c (syms_of_textprop): Remove dead code.
2349 (copy_text_properties): Delete obsolete commentary about an
2350 interface that was deleted long ago. Fix typos in the description
2351 of arguments.
2352
1b2de274
EZ
2353 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2354 to changes in oldXMenu/XMenu.h from 2011-04-16.
2355 <menu_help_message, prev_menu_help_message>: Constify.
2356 (IT_menu_make_room): menu->help_text is now `const char **';
2357 adjust.
2358
2359 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2360 to changes in oldXMenu/XMenu.h from 2011-04-16.
2361 (struct XMenu): Declare `help_text' `const char **'.
2362
2363 * xfaces.c <Qunspecified>: Make extern again.
2364
2365 * syntax.c: Include sys/types.h before including regex.h, as
2366 required by Posix.
2367
762b15be
EZ
2368 * doc.c (get_doc_string): Improve the format passed to `error'.
2369
2370 * doprnt.c (doprnt): Improve commentary.
2371
2372 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2373
2374 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2375 them with etags.
2376
f1052e5d
EZ
2377 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2378 changes in globals.h immediately force recompilation.
762b15be
EZ
2379 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2380 $(CURDIR)/s/ms-w32.h.
2381 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2382
fa6996bc
EZ
2383 * character.c (Fchar_direction): Function deleted.
2384 (syms_of_character): Don't defsubr it.
2385 <char-direction-table>: Deleted.
2386
e6c3da20
EZ
23872011-04-23 Eli Zaretskii <eliz@gnu.org>
2388
2389 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2390 * doprnt.c: Include limits.h.
2391 (SIZE_MAX): New macro.
04f2d78b
CB
2392 (doprnt): Return a size_t value. 2nd arg is now size_t.
2393 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2394 Improve overflow protection. Support `l' modifier for integer
2395 conversions. Support %l conversion. Don't assume an EMACS_INT
2396 argument for integer conversions and for %c.
2397
2398 * lisp.h (doprnt): Restore prototype.
2399
2400 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2401 $(SRC)/character.h.
2402
2403 * Makefile.in (base_obj): Add back doprnt.o.
2404
2405 * deps.mk (doprnt.o): Add back prerequisites.
2406 (callint.o): Depend on character.h.
2407
2408 * eval.c (internal_lisp_condition_case): Include the handler
2409 representation in the error message.
2410 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2411 when breaking from the loop.
2412
2413 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2414
2415 * callint.c (Fcall_interactively): When displaying error message
2416 about invalid control letter, pass the character's codepoint, not
2417 a pointer to its multibyte form. Improve display of the character
2418 in octal and display also its hex code.
2419
2420 * character.c (char_string): Use %x to display the (unsigned)
2421 codepoint of an invalid character, to avoid displaying a bogus
2422 negative value.
2423
2424 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2425 `error', not SYMBOL_NAME itself.
2426
2427 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2428 character arguments to `error'.
2429
2430 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2431 to `error' in error message about FINAL_CHAR argument. Make sure
2432 FINAL_CHAR is a character, and use %c when it is passed as
2433 argument to `error'.
2434
4ffd0d6b 24352011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2436
2437 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2438
2439 * w32.c: Include <time.h>.
2440 (sys_localtime): New function.
2441
4ffd0d6b 24422011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2443
2444 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2445
4ffd0d6b 2446 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2447
4ffd0d6b 24482011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2449
4ffd0d6b
GM
2450 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2451 zombies (Bug#8467).
aac0c6e3 2452
04c56954
EZ
24532011-04-19 Eli Zaretskii <eliz@gnu.org>
2454
2455 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2456 gl_state.e_property when gl_state.object is Qt.
2457
2458 * insdel.c (make_gap_larger): Remove limitation of buffer size
2459 to <= INT_MAX.
2460
16a43933
CY
24612011-04-18 Chong Yidong <cyd@stupidchicken.com>
2462
2463 * xdisp.c (lookup_glyphless_char_display)
2464 (produce_glyphless_glyph): Handle cons cell entry in
2465 glyphless-char-display.
2466 (Vglyphless_char_display): Document it.
2467
2468 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2469 glyphless-char-display.
2470
4581706e
CY
24712011-04-17 Chong Yidong <cyd@stupidchicken.com>
2472
2473 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2474
2475 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2476
2477 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2478 definition for no-X builds.
2479
4887c6e2 24802011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2481
fd35b6f9
PE
2482 Static checks with GCC 4.6.0 and non-default toolkits.
2483
5c1ccb01
PE
2484 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2485
006c5daa
PE
2486 * process.c (keyboard_bit_set): Define only if SIGIO.
2487 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2488 (send_process): Repair possible setjmp clobbering.
2489
efc736d3
PE
2490 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2491
4e2fe2e6
PE
2492 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2493
f97334a2
PE
2494 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2495
4e75f29d
PE
2496 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2497 Define only if needed.
2498
90efadd1
PE
2499 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2500 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2501 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2502
3c647824
PE
2503 * dispextern.h (struct redisplay_interface): Rename param
2504 to avoid shadowing.
e264f262 2505 * termhooks.h (struct terminal): Likewise.
761383f4 2506 * xterm.c (xembed_send_message): Likewise.
3c647824 2507
b58c5c4a
PE
2508 * insdel.c (make_gap_smaller): Define only if
2509 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2510
cad59032
PE
2511 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2512 it.
2513
c339dc2e
PE
2514 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2515 so that we aren't warned about unused symbols.
2516
91a3e27b
PE
2517 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2518
399c71d3 2519 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2520
8ffc96f5
PE
2521 * xfns.c (x_real_positions): Mark locals as initialized.
2522
eef9bc79
PE
2523 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2524
098db9dd
PE
2525 * xterm.c: Fix problems found by static analysis with other toolkits.
2526 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2527 (x_dispatch_event): Declare static if USE_GTK, and
2528 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2529 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2530 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2531 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2532 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2533
eb18f6cc
PE
2534 * xmenu.c (menu_help_callback): Pointer type fixes.
2535 Use const pointers when pointing at readonly data. Avoid pointer
2536 signedness clashes.
2537 (FALSE): Remove unused macro.
2538 (update_frame_menubar): Remove unused decl.
2539
1fe72bf8
PE
2540 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2541
60d9e1db
PE
2542 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2543 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2544 (single_menu_item): Rename local to avoid shadowing.
2545
39261c26
PE
2546 * keyboard.c (make_lispy_event): Remove unused local var.
2547
018c5e19
PE
2548 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2549 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2550
63d2b86e
PE
2551 * bitmaps: Change bitmaps from unsigned char back to the X11
2552 compatible char. Avoid the old compiler warnings about
2553 out-of-range initializers by using, for example, '\xab' rather
2554 than 0xab.
2555
aefd87e1
PE
2556 * xgselect.c (xgselect_initialize): Check vs interface
2557 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2558
bf501fb9
PE
2559 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2560
e9829fdf
PE
2561 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2562 to read-only memory.
2563
1086c095
PE
2564 * fns.c (vector): Remove; this old hack is no longer needed.
2565
2baccd04 2566 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2567 Remove unused var.
dde42981 2568 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2569
72391843 2570 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2571
436c16df 2572 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2573 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2574 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2575
92bb796d 2576 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2577 (x_term_init): Remove local to avoid shadowing.
92bb796d 2578
764430a3 2579 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2580
2581 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2582 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2583
d1dfb56c
EZ
25842011-04-16 Eli Zaretskii <eliz@gnu.org>
2585
c4354cb4
EZ
2586 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2587
d1dfb56c
EZ
2588 Fix regex.c, syntax.c and friends for buffers > 2GB.
2589 * syntax.h (struct gl_state_s): Declare character position members
2590 EMACS_INT.
2591
2592 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2593
04f2d78b
CB
2594 * textprop.c (verify_interval_modification, interval_of):
2595 Declare arguments EMACS_INT.
d1dfb56c
EZ
2596
2597 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2598 EMACS_INT.
2599
2600 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2601
2602 * indent.c (Fvertical_motion): Local variable it_start is now
2603 EMACS_INT.
2604
2605 * regex.c (re_match, re_match_2, re_match_2_internal)
2606 (bcmp_translate, regcomp, regexec, print_double_string)
2607 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2608 (re_compile_pattern, re_exec): Declare arguments and local
2609 variables `size_t' and `ssize_t' and return values `regoff_t', as
2610 appropriate.
2611 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2612 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2613 <compile_stack_type>: `size' and `avail' are now `size_t'.
2614
2615 * regex.h <regoff_t>: Use ssize_t, not int.
2616 (re_search, re_search_2, re_match, re_match_2): Arguments that
2617 specify buffer/string position and length are now ssize_t and
2618 size_t. Return type is regoff_t.
2619
613052cd
BK
26202011-04-16 Ben Key <bkey76@gmail.com>
2621
2622 * nsfont.m: Fixed bugs in ns_get_family and
2623 ns_descriptor_to_entity that were caused by using free to
2624 deallocate memory blocks that were allocated by xmalloc (via
2625 xstrdup). This caused Emacs to crash when compiled with
2626 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2627 --enable-checking=xmallocoverrun). xfree is now used to
2628 deallocate these memory blocks.
2629
4170f62f 26302011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2631
71b41406
PE
2632 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2633
9587a89d
PE
2634 emacs_write: Accept and return EMACS_INT for sizes.
2635 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2636 et seq.
2637 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2638 Accept and return EMACS_INT.
2639 (emacs_gnutls_write): Return the number of bytes written on
2640 partial writes.
2641 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2642 (emacs_read, emacs_write): Remove check for negative size, as the
2643 Emacs source code has been audited now.
9587a89d
PE
2644 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2645 (emacs_read, emacs_write): Use it.
273a5f82
PE
2646 * process.c (send_process): Adjust to the new signatures of
2647 emacs_write and emacs_gnutls_write. Do not attempt to store
2648 a byte offset into an 'int'; it might overflow.
9587a89d 2649 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2650
3e047f51
PE
2651 * sound.c: Don't assume sizes fit in 'int'.
2652 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2653 Return EMACS_INT, not int.
3e047f51 2654 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2655 Accept EMACS_INT, not int.
2656 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2657 record read return values.
2658
cc39a9db
BK
26592011-04-15 Ben Key <bkey76@gmail.com>
2660
c9d0ec6d
JB
2661 * keyboard.c (Qundefined): Don't declare static since it is used
2662 in nsfns.m.
2663 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2664 static since they are used in nsfont.m.
cc39a9db 2665
6c60eb9f
SM
26662011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2667
2668 * process.c (Qprocessp): Don't declare static.
2669 * lisp.h (Qprocessp): Declare again.
2670
7990b61a
JB
26712011-04-15 Juanma Barranquero <lekktu@gmail.com>
2672
2673 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2674
5d4cb038
PE
26752011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2676
8bd7b830 2677 Improve C-level modularity by making more things 'static'.
cd64ea1d 2678
e3b27b31
PE
2679 Don't publish debugger-only interfaces to other modules.
2680 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2681 (verify_bytepos, count_markers): Move decls to the only modules
2682 that need them.
2683 * region-cache.h (pp_cache): Likewise.
2684 * window.h (check_all_windows): Likewise.
2685 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2686
5d4cb038
PE
2687 * sysdep.c (croak): Now static, if
2688 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2689 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2690
2691 * alloc.c (refill_memory_reserve): Now static if
2692 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2693 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2694
e87b6180
PE
2695 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2696 Define only if USE_LUCID.
2697
ac64929e
PE
2698 * xrdb.c (x_customization_string, x_rm_string): Now static.
2699
6f37259d
PE
2700 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2701 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2702
1683e3ab
PE
2703 * xdisp.c (draw_row_with_mouse_face): Now static.
2704 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2705
de9c2632
PE
2706 * window.h (check_all_windows): Mark externally visible.
2707
2b96acb7
PE
2708 * window.c (window_deletion_count): Now static.
2709
2710 * undo.c: Make symbols static if they're not exported.
2711 (last_undo_buffer, last_boundary_position, pending_boundary):
2712 Now static.
2713
50436f33
PE
2714 * textprop.c (interval_insert_behind_hooks): Now static.
2715 (interval_insert_in_front_hooks): Likewise.
2716
64520e5c
PE
2717 * term.c: Make symbols static if they're not exported.
2718 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2719 (max_frame_lines, tty_set_terminal_modes):
2720 (tty_reset_terminal_modes, tty_turn_off_highlight):
2721 (get_tty_terminal): Now static.
2722 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2723 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2724 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2725 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2726 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2727
1fa53021
PE
2728 * sysdep.c: Make symbols static if they're not exported.
2729 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2730 Now static.
2731 (sigprocmask_set, full_mask): Remove; unused.
2732 (wait_debugging): Mark as visible.
2733 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2734 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2735
d4b43b22
PE
2736 * syntax.c (syntax_temp): Define only if !__GNUC__.
2737
b7c513d0
PE
2738 * sound.c (current_sound_device, current_sound): Now static.
2739
989b29ad
PE
2740 * search.c (searchbufs, searchbuf_head): Now static.
2741
13a55a78
PE
2742 * scroll.c (scroll_cost): Remove; unused.
2743 * dispextern.h (scroll_cost): Remove decl.
2744
de68a1fc
PE
2745 * region-cache.h (pp_cache): Mark as externally visible.
2746
40ccffa6
PE
2747 * process.c: Make symbols static if they're not exported.
2748 (process_tick, update_tick, create_process, chan_process):
2749 (Vprocess_alist, proc_buffered_char, datagram_access):
2750 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2751 (deactivate_process): Mark defn as static, as well as decl.
2752 * lisp.h (create_process): Remove decl.
2753 * process.h (chan_process, Vprocess_alist): Remove decls.
2754
ad64fc97
PE
2755 * print.c: Make symbols static if they're not exported.
2756 (print_depth, new_backquote_output, being_printed, print_buffer):
2757 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2758 (print_interval, print_number_index, initial_stderr_stream):
2759 Now static.
2760 * lisp.h (Fprinc): Remove decl.
2761 (debug_output_compilation_hack): Mark as externally visible.
2762
adddb265
PE
2763 * sysdep.c (croak): Move decl from here to syssignal.h.
2764 * syssignal.h (croak): Put it here, so the API can be checked when
2765 'croak' is called from dissociate_if_controlling_tty.
2766
1717ede2
PE
2767 * minibuf.c: Make symbols static if they're not exported.
2768 (minibuf_save_list, choose_minibuf_frame): Now static.
2769 * lisp.h (choose_minibuf_frame): Remove decl.
2770
fa5fb2bc
PE
2771 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2772
1e3890d1
PE
2773 * lread.c: Make symbols static if they're not exported.
2774 (read_objects, initial_obarray, oblookup_last_bucket_number):
2775 Now static.
2776 (make_symbol): Remove; unused.
2777 * lisp.h (initial_obarray, make_symbol): Remove decls.
2778
8a1414fa
PE
2779 * keyboard.c: Make symbols static if they're not exported.
2780 (single_kboard, recent_keys_index, total_keys, recent_keys):
2781 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2782 (this_single_command_key_start, echoing, last_auto_save):
2783 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2784 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2785 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2786 (Vlispy_mouse_stem, double_click_count):
2787 Now static.
2788 (force_auto_save_soon): Define only if SIGDANGER.
2789 (ignore_mouse_drag_p): Now static if
2790 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2791 (print_help): Remove; unused.
2792 (stop_character, last_timer_event): Mark as externally visible.
2793 * keyboard.h (ignore_mouse_drag_p): Declare only if
2794 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2795 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2796 * lisp.h (echoing): Remove decl.
2797 (force_auto_save_soon): Declare only if SIGDANGER.
2798 * xdisp.c (redisplay_window): Simplify code, to make it more
2799 obvious that ignore_mouse_drag_p is not accessed if !defined
2800 USE_GTK && !defined HAVE_NS.
2801
93ea6e8f
PE
2802 * intervals.c: Make symbols static if they're not exported.
2803 (merge_properties_sticky, merge_interval_right, delete_interval):
2804 Now static.
2805 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2806
77382fcc
PE
2807 * insdel.c: Make symbols static if they're not exported.
2808 However, leave prepare_to_modify_buffer alone. It's never
2809 called from outside this function, but that appears to be a bug.
2810 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2811 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2812 (adjust_after_replace_noundo): Remove; unused.
2813 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2814 (signal_before_change): Remove decls.
77382fcc 2815
9306c32e
PE
2816 * indent.c (val_compute_motion, val_vmotion): Now static.
2817
cd44d2eb
PE
2818 * image.c: Make symbols static if they're not exported.
2819 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2820 if USE_GTK.
2821 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2822 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2823
ad9a7a06
PE
2824 * fringe.c (standard_bitmaps): Now static.
2825 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2826
81626931
PE
2827 * frame.c: Make symbols static if they're not exported.
2828 (x_report_frame_params, make_terminal_frame): Now static.
2829 (get_frame_param): Now static, unless HAVE_NS.
2830 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2831 (x_get_resource_string): Remove; not used.
2832 * frame.h (make_terminal_frame, x_report_frame_params):
2833 (x_get_resource_string); Remove decls.
2834 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2835 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2836
239f9db9
PE
2837 * font.c, fontset.c: Make symbols static if they're not exported.
2838 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2839 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2840 * font.c (font_close_object): Now static.
2841 * font.h (font_close_object): Remove.
2842 * fontset.c (FONTSET_OBJLIST): Remove.
2843 (free_realized_fontset) #if-0 the body, which does nothing.
2844 (face_suitable_for_char_p): #if-0, as it's never called.
2845 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2846 * xfaces.c (face_at_string_position):
2847 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2848 since 0 is always ASCII.
2849
dfcf3579
PE
2850 * fns.c (weak_hash_tables): Now static.
2851
5045092b
PE
2852 * fileio.c: Make symbols static if they're not exported.
2853 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2854 (Vwrite_region_annotation_buffers): Now static.
2855
57a96f5c
PE
2856 * eval.c: Make symbols static if they're not exported.
2857 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2858 * lisp.h (backtrace_list): Remove decl.
2859
35f08c38
PE
2860 * emacs.c: Make symbols static if they're not exported.
2861 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2862 (fatal_error_code, fatal_error_signal_hook, standard_args):
2863 Now static.
2864 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2865 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2866 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2867 * lisp.h (fatal_error_signal_hook): Remove decl.
2868 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2869
f44bd759
PE
2870 * editfns.c: Move a (normally-unused) function to its only use.
2871 * editfns.c, lisp.h (get_operating_system_release): Remove.
2872 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2873 worth the hassle of breaking this out.
2874
b532497d
PE
2875 * xterm.c: Make symbols static if they're not exported.
2876 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2877 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2878 (x_destroy_window, x_delete_display):
2879 Now static.
2880 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2881 (x_mouse_leave): Remove; unused.
2882 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2883 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2884 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2885 Remove decls.
2886 (x_mouse_leave): Declare only if WINDOWSNT.
2887 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2888 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2889 USE_X_TOOLKIT.
2890
1675728f
PE
2891 * ftxfont.c: Make symbols static if they're not exported.
2892 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2893 HAVE_FREETYPE.
2894 * font.h (ftxfont_driver): Likewise.
2895
e4cebfca
PE
2896 * xfns.c: Make symbols static if they're not exported.
2897 (x_last_font_name, x_display_info_for_name):
2898 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2899 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2900 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2901 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2902 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2903 (last_show_tip_args): Now static.
2904 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2905 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2906 (x_screen_planes): Remove; unused.
2907 * dispextern.h (x_screen_planes): Remove decl.
2908
5bf46f05
PE
2909 * dispnew.c: Make symbols static if they're not exported.
2910 * dispextern.h (redraw_garbaged_frames, scrolling):
2911 (increment_row_positions): Remove.
2912 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2913 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2914 Now static.
2915 (redraw_garbaged_frames): Remove; unused.
2916
435f4c28
PE
2917 * xfaces.c: Make symbols static if they're not exported.
2918 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2919 Remove decls.
2920 * xterm.h (defined_color): Remove decls.
2921 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2922 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2923 (menu_face_changed_default, defined_color, free_realized_face):
2924 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2925 (ascii_face_of_lisp_face): Remove; unused.
2926
8524aef3
PE
2927 * xdisp.c: Make symbols static if they're not exported.
2928 * dispextern.h (scratch_glyph_row, window_box_edges):
2929 (glyph_to_pixel_coords, set_cursor_from_row):
2930 (get_next_display_element, set_iterator_to_next):
2931 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2932 (show_mouse_face): Remove decls
2933 * frame.h (message_buf_print): Likewise.
2934 * lisp.h (pop_message, set_message, check_point_in_composition):
2935 Likewise.
2936 * xterm.h (set_vertical_scroll_bar): Likewise.
2937 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2938 (message_buf_print, scratch_glyph_row, displayed_buffer):
2939 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2940 (get_next_display_element, show_mouse_face, window_box_edges):
2941 (frame_to_window_pixel_xy, check_point_in_composition):
2942 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2943 (glyph_to_pixel_coords): Remove; unused.
2944
16390cd2
PE
2945 * dired.c (file_name_completion): Now static.
2946
2947 * dbusbind.c (xd_in_read_queued_messages): Now static.
2948
a25f4dfa
PE
2949 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2950 * data.c (circular_list_error): Remove.
2951
14a9c8df
PE
2952 * commands.h (last_point_position, last_point_position_buffer):
2953 (last_point_position_window): Remove decls.
2954 * keyboard.c: Make these variables static.
2955
04f2d78b
CB
2956 * coding.h (coding, code_convert_region, encode_coding_gap):
2957 Remove decls.
74ab6df5
PE
2958 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2959 (iso_code_class, detect_coding, code_convert_region): Now static.
2960 (encode_coding_gap): Remove; unused.
2961
38dfbee1
PE
2962 * chartab.c (chartab_chars, chartab_bits): Now static.
2963
a2cb4e63
PE
2964 * charset.h (charset_iso_8859_1): Remove decl.
2965 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2966 Now static.
2967
127198fd
PE
2968 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2969 * ccl.c (Vccl_program_table): Now static.
2970 (check_ccl_update): Remove; unused.
2971
d85b608f
PE
2972 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2973 * category.h: ... from here.
2974 * category.c (check_category_table, set_category_set): Now static.
2975
31cd66f3
PE
2976 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2977 * lisp.h: Remove these decls.
2978
c358e587
PE
2979 * buffer.c (buffer_count): Remove unused var.
2980
e78aecca
PE
2981 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2982 so that it's not optimized away.
2983 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2984 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2985 exported only to the debugger.
2986
e192d7d3 2987 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2988 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2989
92470028
PE
2990 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2991 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2992 was inaccessible from Lisp.
2993 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2994 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2995
244ed907
PE
2996 alloc.c: Import and export fewer symbols, and remove unused items.
2997 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2998 is defined.
2999 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3000 it's not optimized away by whole-program optimization.
3001 (message_enable_multibyte, free_misc): Remove.
3002 (catchlist, handlerlist, mark_backtrace):
3003 Declare only if BYTE_MARK_STACK.
3004 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3005 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3006 (message_enable_multibyte): Remove decl.
3007 (free_misc, interval_free_list, float_block, float_block_index):
3008 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3009 (cons_free_list, last_marked_index):
3010 Now static.
3011 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3012 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3013 (mark_backtrace): Define only if BYTE_MARK_STACK.
3014 * xdisp.c (message_enable_multibyte): Now static.
3015
61c2b50e 3016 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3017 This makes it easier for human readers (and static analyzers)
3018 to see whether these variables are used from other modules.
3019 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3020 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3021 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3022 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3023 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3024 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3025 * xmenu.c, xselect.c:
3026 Declare Q* vars static if they are not used in other modules.
3027 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3028 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3029 Remove decls of unexported vars.
3030 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3031
95c82688
PE
3032 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3033
16a97296
PE
3034 Make Emacs functions such as Fatom 'static' by default.
3035 This makes it easier for human readers (and static analyzers)
3036 to see whether these functions can be called from other modules.
3037 DEFUN now defines a static function. To make the function external
3038 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3039 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3040 (Finit_image_library):
16a97296
PE
3041 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3042 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3043 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3044 Remove decls, since these functions are now static.
3045 (Funintern, Fget_internal_run_time): New decls, since these functions
3046 were already external.
95c82688 3047
16a97296
PE
3048 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3049 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3050 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3051 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3052 * keyboard.c, keymap.c, lread.c:
3053 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3054 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3055 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3056 Mark functions with DEFUE instead of DEFUN,
3057 if they are used in other modules.
3058 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3059 decls for now-static functions.
3060 * buffer.h (Fdelete_overlay): Remove decl.
3061 * callproc.c (Fgetenv_internal): Mark as internal.
3062 * composite.c (Fremove_list_of_text_properties): Remove decl.
3063 (Fcomposition_get_gstring): New forward static decl.
3064 * composite.h (Fcomposite_get_gstring): Remove decl.
3065 * dired.c (Ffile_attributes): New forward static decl.
3066 * doc.c (Fdocumntation_property): New forward static decl.
3067 * eval.c (Ffetch_bytecode): New forward static decl.
3068 (Funintern): Remove extern decl; now in .h file where it belongs.
3069 * fileio.c (Fmake_symbolic_link): New forward static decl.
3070 * image.c (Finit_image_library): New forward static decl.
3071 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3072 * intervals.h (Fprevious_property_change):
3073 (Fremove_list_of_text_properties): Remove decls.
3074 * keyboard.c (Fthis_command_keys): Remove decl.
3075 (Fcommand_execute): New forward static decl.
3076 * keymap.c (Flookup_key): New forward static decl.
3077 (Fcopy_keymap): Now static.
3078 * keymap.h (Flookup_key): Remove decl.
3079 * process.c (Fget_process): New forward static decl.
3080 (Fprocess_datagram_address): Mark as internal.
3081 * syntax.c (Fsyntax_table_p): New forward static decl.
3082 (skip_chars): Remove duplicate decl.
3083 * textprop.c (Fprevious_property_change): New forward static decl.
3084 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3085 Now internal.
3086 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3087 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3088
785bbd42
PE
3089 * editfns.c (Fformat): Remove unreachable code.
3090
8b913b57
AS
30912011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3092
3093 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3094 change. (Bug#8496)
3095
a6744a35
EZ
30962011-04-13 Eli Zaretskii <eliz@gnu.org>
3097
3098 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3099 when at ZV. (Bug#8487)
3100
e7974947
AS
31012011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3102
baad03f0
AS
3103 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3104 (Bug#8437)
3105 * keyboard.c (parse_tool_bar_item): Likewise.
3106 * sound.c (sound_cleanup, alsa_close): Likewise.
3107 * termcap.c (tgetent): Likewise.
3108 * xfns.c (x_default_font_parameter): Likewise.
3109 * xsettings.c (read_and_apply_settings): Likewise.
3110
e7974947
AS
3111 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3112 (overrun_check_free): Protoize.
3113
28272684
PE
31142011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3115
3116 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3117 since callers should never pass a negative size.
3118 Change the signature to match that of plain 'read' and 'write'; see
3119 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3120 * lisp.h: Update prototypes of emacs_write and emacs_read.
3121
11997c76
EZ
31222011-04-11 Eli Zaretskii <eliz@gnu.org>
3123
3124 * xdisp.c (redisplay_window): Don't try to determine the character
3125 position of the scroll margin if the window start point w->startp
e896f03c 3126 is outside the buffer's accessible region. (Bug#8468)
11997c76 3127
8a2cbd72
EZ
31282011-04-10 Eli Zaretskii <eliz@gnu.org>
3129
3130 Fix write-region and its subroutines for buffers > 2GB.
3131 * fileio.c (a_write, e_write): Modify declaration of arguments and
3132 local variables to support buffers larger than 2GB.
3133 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3134
3135 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3136 argument, local variables, and return value.
3137
3138 * lisp.h: Update prototypes of emacs_write and emacs_read.
3139
3140 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3141
4073e537 31422011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3143
1ebfdcb6
PE
3144 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3145
b2ded58d
PE
3146 Fix more problems found by GCC 4.6.0's static checks.
3147
7d66342c
PE
3148 * xdisp.c (vmessage): Use a better test for character truncation.
3149
bbf47d44
PE
3150 * charset.c (load_charset_map): <, not <=, for optimization,
3151 and to avoid potential problems with integer overflow.
9248994d 3152 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3153 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3154 * editfns.c (Fformat): Likewise.
1e69125e 3155 * syntax.c (skip_chars): Likewise.
3befa583 3156
e3019616
PE
3157 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3158 This also lets GCC 4.6.0 generate slightly better loop code.
3159
becfa255
PE
3160 * callint.c (Fcall_interactively): <, not <=, for optimization.
3161 (Fcall_interactively): Count the number of arguments produced,
3162 not the number of arguments given. This is simpler and lets GCC
3163 4.6.0 generate slightly better code.
3164
dae0cd48
PE
3165 * ftfont.c: Distingish more carefully between FcChar8 and char.
3166 The previous code passed unsigned char * to a functions like
3167 strlen and xstrcasecmp that expect char *, which does not
3168 conform to the C standard.
3169 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3170 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3171 char * when the C standard requires it.
3172
76032d70
PE
3173 * keyboard.c (read_char): Remove unused var.
3174
eb3f1cc8
PE
3175 * eval.c: Port to Windows vsnprintf (Bug#8435).
3176 Include <limits.h>.
3177 (SIZE_MAX): Define if the headers do not.
3178 (verror): Do not give up if vsnprintf returns a negative count.
3179 Instead, grow the buffer. This ports to Windows vsnprintf, which
3180 does not conform to C99. Problem reported by Eli Zaretskii.
3181 Also, simplify the allocation scheme, by avoiding the need for
3182 calling realloc, and removing the ALLOCATED variable.
3183
70476b54
PE
3184 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3185
12020a9e
PE
3186 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3187 But keep the doprint source code for now, as we might revamp it
3188 and use it again (Bug#8435).
ea6c7ae6
PE
3189 * lisp.h (doprnt): Remove.
3190 * Makefile.in (base_obj): Remove doprnt.o.
3191 * deps.mk (doprnt.o): Remove.
3192
5fdb398c
PE
3193 error: Print 32- and 64-bit integers portably (Bug#8435).
3194 Without this change, on typical 64-bit hosts error ("...%d...", N)
3195 was used to print both 32- and 64-bit integers N, which relied on
3196 undefined behavior.
3197 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3198 New macro.
3199 * lisp.h (error, verror): Mark as printf-like functions.
3200 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3201 Report overflow in size calculations when allocating printf buffer.
3202 Do not truncate output string at its first null byte.
3203 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3204 Truncate the output at a character boundary, since vsnprintf does not
3205 do that.
3206 * charset.c (check_iso_charset_parameter): Convert internal
3207 character to string before calling 'error', since %c now has the
3208 printf meaning.
3209 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3210 overflow when computing char to be passed to 'error'. Do not
3211 pass Lisp_Object to 'error'; pass the integer instead.
3212 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3213 formatted with plain %d.
3214
b189fa66
PE
3215 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3216
bff87ef0
PE
3217 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3218
7e2cac20
PE
3219 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3220
ce4d90b5
PE
3221 * xterm.c (x_catch_errors): Remove duplicate declaration.
3222
266c9547
PE
3223 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3224
79c49ad2
PE
3225 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3226
368f4090
JM
32272011-04-10 Jim Meyering <meyering@redhat.com>
3228
3229 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3230 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3231 return ssize_t not "int", and use size_t as the buffer length.
3232 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3233 * gnutls.h: Update declarations.
3234 * process.c (read_process_output): Use ssize_t, to match.
3235 (send_process): Likewise.
3236
a32d4040
CY
32372011-04-09 Chong Yidong <cyd@stupidchicken.com>
3238
3239 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3240
8546720e 32412011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3242
04f2d78b
CB
3243 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3244 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3245
8546720e
GM
3246 * xterm.c (handle_one_xevent):
3247 * xmenu.c (create_and_show_popup_menu):
3248 * xselect.c (x_decline_selection_request)
3249 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3250
0a2f5c1a 32512011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3252
3253 Fix some uses of `int' instead of EMACS_INT.
3254 * search.c (string_match_1, fast_string_match)
3255 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3256 (scan_buffer, find_next_newline_no_quit)
3257 (find_before_next_newline, search_command, Freplace_match)
3258 (Fmatch_data): Make some `int' variables be EMACS_INT.
3259
3260 * xdisp.c (display_count_lines): 3rd argument and return value now
3261 EMACS_INT. All callers changed.
3262 (pint2hrstr): Last argument is now EMACS_INT.
3263
3264 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3265 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3266 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3267 (decode_coding_utf_16, decode_coding_emacs_mule)
3268 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3269 (decode_coding_ccl, decode_coding_charset)
3270 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3271 (decode_coding_iso_2022, decode_coding_emacs_mule)
3272 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3273 <char_offset, last_offset>: Declare EMACS_INT.
3274 (encode_coding_utf_8, encode_coding_utf_16)
3275 (encode_coding_emacs_mule, encode_invocation_designation)
3276 (encode_designation_at_bol, encode_coding_iso_2022)
3277 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3278 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3279 Declare EMACS_INT.
3280 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3281 (encode_invocation_designation): Last argument P_NCHARS is now
3282 EMACS_INT.
3283 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3284 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3285
3286 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3287 All users changed.
3288
3289 * ccl.c (Fccl_execute_on_string): Declare some variables
3290 EMACS_INT.
3291
8546720e 32922011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3293
3294 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3295
4e19a977
CS
32962011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3297
3298 * process.c (Fformat_network_address): Doc fix.
3299
87302331
R
33002011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3301
3302 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3303
cbb59342
CY
33042011-04-08 Chong Yidong <cyd@stupidchicken.com>
3305
3306 * keyboard.c (read_char): Call Lisp function help-form-show,
3307 instead of using internal_with_output_to_temp_buffer.
3308 (Qhelp_form_show): New var.
e0d38eeb 3309 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3310
3311 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3312
3313 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3314
e67a13ab
CY
33152011-04-06 Chong Yidong <cyd@stupidchicken.com>
3316
04f2d78b
CB
3317 * process.c (Flist_processes): Remove to Lisp.
3318 (list_processes_1): Delete.
e67a13ab 3319
973f782d
EZ
33202011-04-06 Eli Zaretskii <eliz@gnu.org>
3321
7c106b1e
EZ
3322 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3323
973f782d
EZ
3324 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3325
41cf7d1a 33262011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3327
ca23cc88
PE
3328 Fix more problems found by GCC 4.6.0's static checks.
3329
f390e2d5
PE
3330 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3331
42eea0d0
PE
3332 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3333
b69769da 3334 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3335
f9541e84
PE
3336 * xdisp.c (vmessage): Mark as a printf-like function.
3337
13841b55
PE
3338 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3339
c136c10f
PE
3340 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3341
5e2d4a30
PE
3342 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3343 printf-like functions.
3344 (tiff_load): Add casts to remove these marks before passing them
3345 to system-supplied API.
3346
583f48b9
PE
3347 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3348
b25d760e
PE
3349 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3350 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3351 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3352 directly, rather than having caller test rule sign. This avoids
3353 some unnecessary tests.
3354 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3355 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3356 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3357
bc7b6697 3358 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3359 (xfont_open): Avoid unnecessary tests.
bc7b6697 3360
27ccc379
PE
3361 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3362
dcd5c89a
PE
3363 * composite.h, composite.c (composition_gstring_put_cache):
3364 Use EMACS_INT, not int, for length.
3365
b13a45c6
PE
3366 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3367 breaking out part of COMPOSITION_DECODE_RULE.
3368 (COMPOSITION_DECODE_RULE): Use it.
3369 * composite.c (get_composition_id): Remove unused local vars,
3370 by using the new macro.
3371
1e792e4d
PE
3372 * textprop.c (set_text_properties_1): Change while to do-while,
3373 since the condition is always true at first.
3374
dc6c6455 3375 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3376 (interval_deletion_adjustment): Return unsigned value.
3377 All uses changed.
dc6c6455 3378
aba7731a
PE
3379 * process.c (list_processes_1, create_pty, read_process_output):
3380 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3381 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3382 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3383 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3384 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3385
fdfc4bf3
PE
3386 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3387
fca8fe46 3388 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3389 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3390
06a0259a 3391 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3392 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3393 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3394
e7b9e80f
PE
3395 * print.c (print_error_message): Avoid int overflow.
3396
56201685
PE
3397 * font.c (font_list_entities): Redo for clarity,
3398 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3399
78834453 3400 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3401 (font_score): Avoid potential overflow in diff calculation.
78834453 3402
0bc0b309 3403 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3404 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3405
e610eaca
PE
3406 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3407
b895abce
PE
3408 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3409 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3410 can always succeed if overflow has undefined behavior.
3411
1f1d9321 3412 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3413 (wordify): Omit three unnecessary tests.
1f1d9321 3414
c59478bc
PE
3415 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3416 All callers changed. This avoids the need for an unused var.
3417
79b73827
PE
3418 * casefiddle.c (casify_region): Remove var that is set but not used.
3419
a4db5dfe
PE
3420 * dired.c (file_name_completion): Remove var that is set but not used.
3421
43aae36e
PE
3422 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3423
2a47c44d 3424 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3425 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3426
a37c69bf
PE
3427 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3428 Check for integer overflow on size calculations.
3429
328ab8e7
PE
3430 * buffer.c (Fprevious_overlay_change): Remove var that is set
3431 but not used.
3432
e5a2a5cb
PE
3433 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3434 Remove vars that are set but not used.
8d84a6eb 3435 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3436 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3437
a60e5f68
PE
3438 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3439
f661cb61 3440 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3441 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3442
f0397f5a
PE
3443 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3444 that are set but not used.
3445
8664db06 3446 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3447 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3448
6abdaa4a
PE
3449 * xselect.c (x_get_local_selection, x_handle_property_notify):
3450 Remove vars that are set but not used.
3451
0ce7538d 3452 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3453 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3454
9ae848fc
PE
3455 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3456 Remove var that is set but not used.
0b918413
PE
3457 (scroll_bar_windows_size): Now size_t, not int.
3458 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3459 Check for overflow.
9ae848fc 3460
a5a62657
PE
3461 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3462 (map_tty_color) [!defined MSDOS]: Likewise.
3463
5c5cdd39
PE
3464 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3465
66ebf983
PE
3466 * coding.c: Remove vars that are set but not used.
3467 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3468 All callers changed.
3469 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3470 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3471 (decode_coding_charset): Remove vars that are set but not used.
3472
1be4d761
PE
3473 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3474 that is set but not used.
3475
47553fa8
PE
3476 * print.c (print_object): Remove var that is set but not used.
3477
1f7196bf 3478 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3479 The gnulib version avoids calling malloc in the usual case,
3480 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3481 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3482 * filelock.c (current_lock_owner): Likewise.
3483 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3484 * sysdep.c: Include allocator.h, careadlinkat.h.
3485 (emacs_no_realloc_allocator): New static constant.
3486 (emacs_readlink): New function.
fdb61804
PE
3487 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3488 ../lib/careadlinkat.h.
d1fdcab7 3489
f84c17c7
SM
34902011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3491
3492 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3493 first non-nil return value).
3494
ef3862ad
JD
34952011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3496
3497 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3498 if not defined (Bug#8403).
3499
376a7006
JB
35002011-04-02 Juanma Barranquero <lekktu@gmail.com>
3501
3502 * xdisp.c (display_count_lines): Remove parameter `start',
3503 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3504 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3505 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3506 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3507 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3508 and thereabouts. All callers changed.
3509 (get_per_char_metric): Remove parameter `f', unused since
3510 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3511
6ca3801d
JM
35122011-04-02 Jim Meyering <meyering@redhat.com>
3513
3514 do not dereference NULL upon failed strdup
3515 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3516 (ns_get_family): Likewise.
3517
d8e2b5ba
JB
35182011-04-02 Juanma Barranquero <lekktu@gmail.com>
3519
3520 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3521
8c74fcbd
JD
35222011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3523
3524 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3525 later (Bug#8403).
3526
7200d79c
SM
35272011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3528
03408648 3529 Add lexical binding.
7200d79c 3530
03408648
SM
3531 * window.c (Ftemp_output_buffer_show): New fun.
3532 (Fsave_window_excursion):
3533 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3534
3535 * lread.c (lisp_file_lexically_bound_p): New function.
3536 (Fload): Bind Qlexical_binding.
3537 (readevalloop): Remove `evalfun' arg.
3538 Bind Qinternal_interpreter_environment.
3539 (Feval_buffer): Bind Qlexical_binding.
3540 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3541 Mark as dynamic.
3542 (syms_of_lread): Declare `lexical-binding'.
3543
3544 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3545
3546 * keyboard.c (eval_dyn): New fun.
3547 (menu_item_eval_property): Use it.
ca105506
SM
3548
3549 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3550
03408648
SM
3551 * fns.c (concat, mapcar1): Accept byte-code-functions.
3552
3553 * eval.c (Fsetq): Handle lexical vars.
3554 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3555 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3556 (FletX, Flet): Obey lexical binding.
3557 (Fcommandp): Handle closures.
3558 (Feval): New `lexical' arg.
3559 (eval_sub): New function extracted from Feval. Use it almost
3560 everywhere where Feval was used. Look up vars in lexical env.
3561 Handle closures.
3562 (Ffunctionp): Move from subr.el.
3563 (Ffuncall): Handle closures.
3564 (apply_lambda): Remove `eval_flags'.
3565 (funcall_lambda): Handle closures and new byte-code-functions.
3566 (Fspecial_variable_p): New function.
3567 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3568 but without exporting it to Lisp.
23aba0ea 3569
23aba0ea 3570 * doc.c (Fdocumentation, store_function_docstring):
03408648 3571 * data.c (Finteractive_form): Handle closures.
23aba0ea 3572
03408648
SM
3573 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3574 interactive spec.
ba83908c 3575
04f2d78b
CB
3576 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3577 New byte-codes.
03408648
SM
3578 (exec_byte_code): New function extracted from Fbyte_code to handle new
3579 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3580
03408648 3581 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3582
03408648 3583 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3584
e2abce01
JB
35852011-03-31 Juanma Barranquero <lekktu@gmail.com>
3586
3587 * xdisp.c (redisplay_internal): Fix prototype.
3588
63696a73 35892011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3590
63696a73 3591 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3592 (try_scrolling): Use it when setting scroll_limit.
3593 Limit scrolling to 100 screen lines.
63696a73
EZ
3594 (redisplay_window): Even when falling back on "recentering",
3595 position point in the window according to scroll-conservatively,
3596 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3597
3598 (try_scrolling): When point is above the window, allow searching
3599 as far as scroll_max, or one screenful, to compute vertical
3600 distance from PT to the scroll margin position. This prevents
3601 try_scrolling from unnecessarily failing when
3602 scroll-conservatively is set to a value slightly larger than the
3603 window height. Clean up the case of PT below the margin at bottom
3604 of window: scroll_max can no longer be INT_MAX. When aggressive
3605 scrolling is in use, don't let point enter the opposite scroll
3606 margin as result of the scroll.
3607 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3608 threshold of 100 lines for never-recentering scrolling.
3609
e4cc2dfc
JB
36102011-03-31 Juanma Barranquero <lekktu@gmail.com>
3611
3612 * dispextern.h (move_it_by_lines):
3613 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3614 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3615 (message_log_check_duplicate): Remove parameters `prev_bol' and
3616 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3617 (redisplay_internal): Remove parameter `preserve_echo_area',
3618 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3619
3620 * indent.c (Fvertical_motion):
3621 * window.c (window_scroll_pixel_based, Frecenter):
3622 Don't pass `need_y_p' to `move_it_by_lines'.
3623
1c470562
SM
36242011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3625
44f230aa
SM
3626 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3627 steal a few bits to be more compact.
3628 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3629 Remove unneeded casts.
3630
1c470562
SM
3631 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3632
888adce9
ZK
36332011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3634
3635 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3636 binding" message (bug#7967).
3637
f838ed7b
PE
36382011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3639
77861b95
PE
3640 Fix more problems found by GCC 4.6.0's static checks.
3641
de6dbc14
PE
3642 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3643 Remove unused local var.
3644
f838ed7b
PE
3645 * editfns.c (Fmessage_box): Remove unused local var.
3646
792c7b2b
PE
3647 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3648 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3649 Omit unused local vars.
c499e557 3650 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3651 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3652 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3653 Omit unused local var.
3654
ba0165e1
PE
3655 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3656 Don't assume string length fits in int.
32ad8845 3657 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3658 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3659
3c59b4c9
PE
3660 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3661 instead of alloca (Bug#8344).
3662
a3eed478 3663 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3664 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3665
eb4d412d
PE
3666 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3667
1658b401
PE
3668 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3669 concerns.
3670
3671 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3672
3673 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3674
9a2c6e05
PE
3675 * keyboard.c (syms_of_keyboard): Use the same style as later
3676 in this function when indexing through an array. This also
3677 works around GCC bug 48267.
3678
03d0a109
PE
3679 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3680
44f730c8
PE
3681 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3682
fe75f926
PE
3683 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3684 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3685
ffa8c828
PE
3686 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3687 This avoids undefined behavior on integer overflow, and is a bit
3688 more convenient anyway since it is compared to a size_t variable.
3689
c5101a77
PE
3690 Variadic C functions now count arguments with size_t, not int.
3691 This avoids an unnecessary limitation on 64-bit machines, which
3692 caused (substring ...) to crash on large vectors (Bug#8344).
3693 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3694 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3695 All variadic functions and their callers changed accordingly.
c5101a77
PE
3696 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3697 * data.c (arith_driver, float_arith_driver): Likewise.
3698 * editfns.c (general_insert_function): Likewise.
3699 * eval.c (struct backtrace.nargs, interactive_p)
3700 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3701 (funcall_lambda, mark_backtrace): Likewise.
3702 * fns.c (concat): Likewise.
3703 * frame.c (x_set_frame_parameters): Likewise.
3704 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3705 0 if not found, not -1. All callers changed.
3706
dd3f25f7
PE
3707 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3708 (stack_copy_size): Now size_t, not int.
3709 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3710
461c2ab9
JB
37112011-03-28 Juanma Barranquero <lekktu@gmail.com>
3712
3713 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3714 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3715 All callers changed.
3716
3717 * lisp.h (multibyte_char_to_unibyte):
3718 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3719 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3720 * character.h (CHAR_TO_BYTE8):
3721 * cmds.c (internal_self_insert):
3722 * editfns.c (general_insert_function):
3723 * keymap.c (push_key_description):
3724 * search.c (Freplace_match):
3725 * xdisp.c (message_dolog, set_message_1): All callers changed.
3726
f6d62986
SM
37272011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3728
3729 * keyboard.c (safe_run_hook_funcall): New function.
3730 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3731 don't set the hook to nil, but remove the offending function instead.
3732 (Qcommand_hook_internal): Remove, unused.
3733 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3734 Vcommand_hook_internal.
3735
3736 * eval.c (enum run_hooks_condition): Remove.
3737 (funcall_nil, funcall_not): New functions.
3738 (run_hook_with_args): Call each function through a `funcall' argument.
3739 Remove `cond' argument, now redundant.
3740 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3741 (Frun_hook_with_args_until_failure): Adjust accordingly.
3742 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3743
1db5b1ad
JB
37442011-03-28 Juanma Barranquero <lekktu@gmail.com>
3745
3746 * dispextern.h (string_buffer_position): Remove declaration.
3747
3748 * print.c (strout): Remove parameter `multibyte', unused since
3749 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3750
3751 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3752 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3753 All callers changed.
3754
3755 * w32.c (_wsa_errlist): Use braces for struct initializers.
3756
3757 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3758 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3759 All callers changed.
3760 (string_buffer_position): Likewise. Also, make static (it's never
3761 used outside xdisp.c).
3762 (cursor_row_p): Remove parameter `w', unused since
3763 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3764 (decode_mode_spec): Remove parameter `precision', introduced during
3765 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3766 All callers changed.
3767
5ffb62aa
JD
37682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3769
3770 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3771
461c2ab9 37722011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3773
3774 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3775 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3776 (ns_update_auto_hide_menu_bar): New functions.
3777 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3778 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3779 ns_constrain_all_frames.
3780 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3781 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3782
5c380ffb
JD
37832011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3784
3785 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3786
9af30bdf
GM
37872011-03-27 Glenn Morris <rgm@gnu.org>
3788
3789 * syssignal.h: Replace RETSIGTYPE with void.
3790 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3791 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3792 Replace SIGTYPE with void everywhere.
3793 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3794 * s/template.h (SIGTYPE): Remove commented out definition.
3795
e2abce01
JB
37962011-03-26 Eli Zaretskii <eliz@gnu.org>
3797
3798 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3799 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3800
f868cd8a
JB
38012011-03-26 Juanma Barranquero <lekktu@gmail.com>
3802
59eb0929
JB
3803 * w32.c (read_unc_volume): Use parameter `henum', instead of
3804 global variable `wget_enum_handle'.
3805
3806 * keymap.c (describe_vector): Remove parameters `indices' and
3807 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3808 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3809
f868cd8a
JB
3810 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3811
3812 * keyboard.c (timer_check): Remove parameter `do_it_now',
3813 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3814 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3815 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3816
3817 * keyboard.c (read_char):
3818 * w32menu.c (w32_menu_display_help):
3819 * xmenu.c (show_help_event, menu_help_callback):
3820 Adjust calls to `show_help_echo'.
3821
3822 * gtkutil.c (xg_maybe_add_timer):
3823 * keyboard.c (readable_events):
3824 * process.c (wait_reading_process_output):
3825 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3826
3827 * insdel.c (adjust_markers_gap_motion):
3828 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3829 (gap_left, gap_right): Don't call it.
3830
2ecf6fdb
CY
38312011-03-25 Chong Yidong <cyd@stupidchicken.com>
3832
3833 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3834 incurred during fontification.
3835
6b1f9ba4
JB
38362011-03-25 Juanma Barranquero <lekktu@gmail.com>
3837
3838 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3839 (DEFVAR_PER_BUFFER): Don't pass it.
3840
3841 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3842 (scrolling_window): Don't pass it.
3843
0f4a96b5
JB
38442011-03-25 Juanma Barranquero <lekktu@gmail.com>
3845
3846 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3847
3848 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3849 and `suffix'.
3850 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3851 of variables specific to SELinux and computation of `encoded_absname'.
3852
3853 * image.c (XPutPixel): Remove unused variable `height'.
3854
3855 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3856
3857 * unexw32.c (get_section_info): Remove unused variable `section'.
3858
3859 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3860 (system_process_attributes): Remove unused variable `sess'.
3861 (sys_read): Remove unused variable `err'.
3862
3863 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3864 (w32_wnd_proc): Remove unused variable `isdead'.
3865 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3866 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3867 (x_create_tip_frame): Remove unused variable `tem'.
3868
3869 * w32inevt.c (w32_console_read_socket):
3870 Remove unused variable `no_events'.
3871
3872 * w32term.c (x_draw_composite_glyph_string_foreground):
3873 Remove unused variable `width'.
3874
1149507c
JB
38752011-03-24 Juanma Barranquero <lekktu@gmail.com>
3876
3877 * w32term.c (x_set_glyph_string_clipping):
3878 Don't pass uninitialized region to CombineRgn.
3879
9c88f339
JB
38802011-03-23 Juanma Barranquero <lekktu@gmail.com>
3881
3882 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3883 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3884 (Fx_close_connection): Remove unused variable `i'.
3885
3886 * w32font.c (w32font_draw): Return number of glyphs.
3887 (w32font_open_internal): Remove unused variable `i'.
3888 (w32font_driver): Add missing initializer.
3889
3890 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3891 (fill_in_menu): Remove unused variable `items_added'.
3892
3893 * w32term.c (last_mouse_press_frame): Remove static global variable.
3894 (w32_clip_to_row): Remove unused variable `f'.
3895 (x_delete_terminal): Remove unused variable `i'.
3896
3897 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3898 (NOTHING): Remove unused static global variable.
3899 (uniscribe_check_otf): Remove unused variable `table'.
3900 (uniscribe_font_driver): Add missing initializers.
3901
dee091a3
JD
39022011-03-23 Julien Danjou <julien@danjou.info>
3903
3904 * term.c (Fsuspend_tty, Fresume_tty):
3905 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3906 * window.c (temp_output_buffer_show):
3907 * insdel.c (signal_before_change):
3908 * frame.c (Fhandle_switch_frame):
3909 * fileio.c (Fdo_auto_save):
3910 * emacs.c (Fkill_emacs):
3911 * editfns.c (save_excursion_restore):
3912 * cmds.c (internal_self_insert):
3913 * callint.c (Fcall_interactively):
3914 * buffer.c (Fkill_all_local_variables):
3915 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3916 Use Frun_hooks.
0f4a96b5 3917 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3918 unconditionnaly since it does the check itself.
3919
2c520ab5 39202011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3921
c9c49752
PE
3922 Fix more problems found by GCC 4.5.2's static checks.
3923
8abc3f12
PE
3924 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3925 the first time through the loop, since we know p0 < p1 then.
3926 This also avoids a gcc -Wstrict-overflow warning.
3927
a2d26660
PE
3928 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3929 leading to a memory leak, possible in functions like
3930 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3931 of objects (Bug#8318).
a2d26660 3932
916c72e9
PE
3933 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3934 that could (at least in theory) be that large.
3935
19ab8a18
PE
3936 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3937 This is less likely to overflow, and avoids undefined behavior if
3938 overflow does occur. All callers changed. Use strtoul to scan
3939 for the unsigned long integer.
b7cbbd6f
PE
3940 (pint2hrstr): Simplify and tune code slightly.
3941 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3942
f0641eff
PE
3943 * scroll.c (do_scrolling): Work around GCC bug 48228.
3944 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3945
7f650bb9
PE
3946 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3947 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3948 (validate_x_resource_name): Simplify count usage.
3949 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3950
37dd57d1
PE
3951 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3952 fail (Bug#8306).
81e56e61 3953
699979fc 3954 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3955
401bf9b4
PE
3956 * process.c (Fmake_network_process): Use socklen_t, not int,
3957 where POSIX says socklen_t is required in portable programs.
3958 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3959 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3960 (Fmake_network_process, server_accept_connection):
3961 (wait_reading_process_output, read_process_output):
3962 Likewise.
3963
b93aacde
PE
3964 * process.c: Rename or move locals to avoid shadowing.
3965 (list_processes_1, Fmake_network_process):
3966 (read_process_output_error_handler, exec_sentinel_error_handler):
3967 Rename or move locals.
4dc343ee 3968 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3969 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3970 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3971 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3972 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3973
af8a867c 3974 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3975 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3976 Include tparam.h instead, since it declares them.
af8a867c
PE
3977 * cm.h (PC): Remove extern decl; tparam.h now does this.
3978 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3979 * terminfo.c: Include tparam.h, to check interfaces.
3980 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3981 (tparam): Adjust signature to match interface in tparam.h;
3982 this removes some undefined behavior. Check that outstring and len
3983 are zero, which they always are with Emacs.
3984 * tparam.h (PC, BC, UP): New extern decls.
3985
0248044d 3986 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3987 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3988
8ff096c1 3989 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3990 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3991 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3992 (ftfont_list): Remove unused local.
49eaafba
PE
3993 (get_adstyle_property, ftfont_pattern_entity):
3994 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3995 Rename locals to avoid shadowing.
8ff096c1 3996
e2be39f6
PE
3997 * xfont.c (xfont_list_family): Mark var as initialized.
3998
c9735e30
PE
3999 * xml.c (make_dom): Now static.
4000
8f5201ae
PE
4001 * composite.c (composition_compute_stop_pos): Rename local to
4002 avoid shadowing.
b246f932
PE
4003 (composition_reseat_it): Remove unused locals.
4004 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4005 (composition_update_it): Mark var as initialized.
11b61122
PE
4006 (find_automatic_composition): Mark vars as initialized,
4007 with a FIXME (Bug#8290).
8f5201ae 4008
760fbc2c
PE
4009 character.h: Rename locals to avoid shadowing.
4010 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4011 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4012 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4013 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4014 to avoid shadowing.
4015
ff08eb85
PE
4016 * textprop.c (property_change_between_p): Remove; unused.
4017
fc7bf025
PE
4018 * intervals.c (interval_start_pos): Now static.
4019
235d7abc
PE
4020 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4021
44f230aa
SM
4022 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4023 Rename locals to avoid shadowing.
3e7d6594 4024
50060332
PE
4025 * sound.c (wav_play, au_play, Fplay_sound_internal):
4026 Fix pointer signedness.
d01f234b 4027 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4028 (wav_play): Initialize a variable to 0, to prevent undefined
4029 behavior (Bug#8278).
50060332 4030
c4fc4e30
PE
4031 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4032
918436ed
PE
4033 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4034
c939f91b
PE
4035 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4036 clobbering (Bug#8298).
b9c7f648
PE
4037 * sysdep.c (sys_subshell): Likewise.
4038 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4039
6bd8c144
PE
4040 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4041 This should get cleaned up, so that child_setup has the
4042 same signature on all platforms.
4043
7710357c 4044 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4045 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4046
c59da222
CY
40472011-03-22 Chong Yidong <cyd@stupidchicken.com>
4048
4049 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4050 not to be necessary, and produces flickering.
4051
66b87493
GM
40522011-03-20 Glenn Morris <rgm@gnu.org>
4053
4054 * config.in: Remove file.
4055
45b6f6d5
JB
40562011-03-20 Juanma Barranquero <lekktu@gmail.com>
4057
4058 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4059 are now in src/globals.h.
4060 (syms_of_minibuf): Remove spurious & from previous change.
4061
3ec03f7e
LL
40622011-03-20 Leo <sdl.web@gmail.com>
4063
4064 * minibuf.c (completing-read-function): New variable.
4065 (completing-read-default): Rename from completing-read.
4066 (completing-read): Call completing-read-function.
4067
b14e3e21
CY
40682011-03-19 Juanma Barranquero <lekktu@gmail.com>
4069
4070 * xfaces.c (Fx_load_color_file):
4071 Read color file from absolute filename (bug#8250).
4072
f2b726e6
JB
40732011-03-19 Juanma Barranquero <lekktu@gmail.com>
4074
4075 * makefile.w32-in: Update dependencies.
4076
09f6ff02
EZ
40772011-03-17 Eli Zaretskii <eliz@gnu.org>
4078
4079 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4080
29a6015a
PE
40812011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4082
a3a6c54e
PE
4083 Fix more problems found by GCC 4.5.2's static checks.
4084
b766f867
PE
4085 * process.c (make_serial_process_unwind, send_process_trap):
4086 (sigchld_handler): Now static.
4087
be02381c
PE
4088 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4089 That way, the code declares only the vars that it needs.
4090 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4091 * s/cygwin.h (PTY_ITERATION): Likewise.
4092 * s/darwin.h (PTY_ITERATION): Likewise.
4093 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4094
57048744
PE
4095 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4096 * process.c (allocate_pty): Don't declare stb unless it's needed.
4097
7914961c 4098 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4099 (CONSTANTLIM): Remove; unused.
4100 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4101 Define only if needed.
7914961c 4102
b3967b18
PE
4103 * unexelf.c (unexec): Name an expression,
4104 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4105 Use a different way to cause a compilation error if anyone uses
4106 n rather than nn, a way that does not involve shadowing.
73366a00 4107 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4108
29a6015a
PE
4109 * deps.mk (unexalpha.o): Remove; unused.
4110
43cfc33e 4111 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4112 * unexec.h: New file.
ce701a33
PE
4113 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4114 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4115 Depend on unexec.h.
4116 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4117 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4118 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4119 Change as necessary to match prototype in unexec.h.
ce701a33 4120
01f44d5a
PE
4121 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4122 shadowing.
4f63c6bb 4123 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4124
a6670b0b
PE
4125 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4126 Rename locals to avoid shadowing.
4127
cef2010d 4128 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4129 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4130
d4d7173a
PE
4131 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4132
f08b802a
PE
4133 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4134 warning when compiling print.c.
4135
3ddb0639
PE
4136 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4137 instead of using an uninitialized var.
5ad03b97 4138 (font_sort_entities): Mark var as initialized.
3ddb0639 4139
170a2692
PE
4140 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4141
e663c700
PE
4142 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4143 pointers to constants.
89bc529a 4144 (font_parse_fcname): Remove unused vars.
7b81e2d0 4145 (font_delete_unmatched): Now static.
ea838e10 4146 (font_get_spec): Remove; unused.
13a547c6
PE
4147 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4148 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4149 Rename or move locals to avoid shadowing.
e663c700 4150
2a80c887 4151 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4152 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4153
1384fa33 4154 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4155 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4156
8b2c52e9
PE
4157 * alloc.c (mark_backtrace): Move decl from here ...
4158 * lisp.h: ... to here, so that it can be checked.
4159
475545b5 4160 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4161 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4162 (lisp_indirect_variable): Name an expression,
4163 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4164 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4165
b1349114 4166 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4167 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4168 Use const pointer when appropriate.
b1349114 4169
a2928364
PE
4170 * lisp.h (get_system_name, get_operating_system_release):
4171 Move decls here, to check interfaces.
4172 * process.c (get_operating_system_release): Move decl to lisp.h.
4173 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4174 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4175 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4176 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4177 (Fformat_time_string, Fencode_time, Finsert_char):
4178 (Ftranslate_region_internal, Fformat):
4179 Rename or remove local vars to avoid shadowing.
9710023e 4180 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4181
a415e694
PE
4182 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4183 avoid shadowing.
4184
8ef4622d
PE
4185 * lisp.h (eassert): Check that the argument compiles, even if
4186 ENABLE_CHECKING is not defined.
4187
946f9a5b
PE
4188 * data.c (Findirect_variable): Name an expression, to avoid
4189 gcc -Wbad-function-cast warning.
112396d6 4190 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4191 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4192 (Fmake_variable_buffer_local, Fmake_local_variable):
4193 Mark variables as initialized.
52746918 4194 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4195
e5aab7e7 4196 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4197 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4198 Rename locals to avoid shadowing.
dff45157
PE
4199 (mark_stack): Move local variables into the #ifdef region where
4200 they're used.
7bc26fdb
PE
4201 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4202 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4203 needed otherwise.
4204 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4205 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4206 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4207
e5aab7e7
PE
4208 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4209 avoids undefined behavior in theory.
4210
4da60324
PE
4211 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4212
88043301
PE
4213 Use functions, not macros, for up- and down-casing (Bug#8254).
4214 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4215 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4216 to use the following functions instead of these macros.
4217 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4218 EMACS_INT, since callers assume the returned value fits in int.
4219 (upcase1): Likewise, for UPCASE_TABLE.
4220 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4221 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4222 the race-condition problem in the old DOWNCASE.
88043301 4223
19ed5445
PE
4224 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4225 Rename locals to avoid shadowing.
4226 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4227 (regex_compile, re_search_2, re_match_2_internal):
4228 Remove unused local vars.
952db0d7
PE
4229 (FREE_VAR): Rewrite so as not to use empty "else",
4230 which gcc can warn about.
da053e48 4231 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4232 (RETALLOC_IF): Define only if needed.
4233 (WORDCHAR_P): Likewise. This one is never needed, but is used
4234 only in a comment talking about a compiler bug, so put inside
4235 the #if 0 of that comment.
4236 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4237 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4238 Remove; unused.
19ed5445 4239
1f3561e4 4240 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4241 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4242 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4243
ded6f8f7
PE
4244 * search.c (simple_search): Remove unused var.
4245
dbd37a95
PE
4246 * dired.c (compile_pattern): Move decl from here ...
4247 * lisp.h: ... to here, so that it can be checked.
4248 (struct re_registers): New forward decl.
4249
7e47afad
PE
4250 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4251
85f24f61
PE
4252 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4253 All uses changed.
4254 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4255 Rename locals to avoid shadowing.
5671df8f 4256 (Fvertical_motion): Mark locals as initialized.
85f24f61 4257
181aa2be 4258 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4259 (casify_region): Mark local as initialized.
181aa2be 4260
930d429c
PE
4261 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4262
7082eac6
PE
4263 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4264 New macros, so that the caller can use some names other than
4265 gcpro1, gcpro2, etc.
4266 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4267 of the new macros.
4268 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4269 argument, for consistency with GCPRO2_VAR, etc: it is now the
4270 prefix of the variable, not the variable itself. All uses
4271 changed.
38b2c076
PE
4272 * dired.c (directory_files_internal, file_name_completion):
4273 Rename locals to avoid shadowing.
4274
15206ed9
PE
4275 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4276 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4277 dired.c's scmp function, had undefined behavior.
4278 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4279 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4280 * buffer.h: ... to here, because these macros use current_buffer,
4281 and the new implementation with inline functions needs to have
4282 current_buffer in scope now, rather than later when the macros
4283 are used.
4284 (downcase, upcase1): New static inline functions.
4285 (DOWNCASE, UPCASE1): Reimplement using these functions.
4286 This avoids undefined behavior in expressions like
4287 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4288 from race conditions in accessing the global variables
4289 case_temp1 and case_temp2.
4290 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4291 * lisp.h (case_temp1, case_temp2): Remove their decls.
4292 * character.h (ASCII_CHAR_P): Move from here ...
4293 * lisp.h: ... to here, so that the inline functions mentioned
4294 above can use them.
4295
4a6bea26
PE
4296 * dired.c (directory_files_internal_unwind): Now static.
4297
f14b7e14
PE
4298 * fileio.c (file_name_as_directory, directory_file_name):
4299 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4300 Now static.
2893f146
PE
4301 (file_name_as_directory): Use const pointers when appropriate.
4302 (Fexpand_file_name): Likewise. In particular, newdir might
4303 point at constant storage, so make it a const pointer.
fd4ead52 4304 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4305 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4306 signedness issues.
f839df0c
PE
4307 (Fset_file_times, Finsert_file_contents, auto_save_error):
4308 Rename locals to avoid shadowing.
f14b7e14 4309
5716756e 4310 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4311 (Ftry_completion, Fall_completions): Rename or remove locals
4312 to avoid shadowing.
5716756e 4313
b4c3046a
PE
4314 * marker.c (bytepos_to_charpos): Remove; unused.
4315
b45db522
PE
4316 * lisp.h (verify_bytepos, count_markers): New decls,
4317 so that gcc does not warn that these functions aren't declared.
4318
85876d07
PE
4319 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4320 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4321 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4322 (copy_text): Remove unused local var.
85876d07 4323
03d78a21 4324 * filelock.c (within_one_second): Now static.
b3dd38ab 4325 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4326
5df8f01b
PE
4327 * buffer.c (fix_overlays_before): Mark locals as initialized.
4328 (fix_start_end_in_overlays): Likewise. This function should be
4329 simplified by using pointers-to-pointers, but that's a different
4330 matter.
b1d876f1 4331 (switch_to_buffer_1): Now static.
8f54f30a
PE
4332 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4333 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4334
a70072c9 4335 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4336 Fix pointer signedness issue.
edced198
PE
4337 (sys_subshell): Mark local as volatile if checking for lint,
4338 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4339 (MAXPATHLEN): Define only if needed.
a70072c9 4340
a0977c44
PE
4341 * process.c (serial_open, serial_configure): Move decls from here ...
4342 * systty.h: ... to here, so that they can be checked.
4343
a884fdcc
PE
4344 * fns.c (get_random, seed_random): Move extern decls from here ...
4345 * lisp.h: ... to here, so that they can be checked.
4346
604efe86 4347 * sysdep.c (reset_io): Now static.
b8950c94 4348 (wait_for_termination_signal): Remove; unused.
604efe86 4349
38fc62d9
PE
4350 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4351 (copy_keymap_item, append_key, push_text_char_description):
4352 Now static.
1004a21a 4353 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4354 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4355 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4356 (describe_map_tree):
4357 Rename locals to avoid shadowing.
38fc62d9 4358
2f2650da
PE
4359 * keyboard.c: Declare functions static if they are not used elsewhere.
4360 (echo_char, echo_dash, cmd_error, top_level_2):
4361 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4362 (read_char, kbd_buffer_get_event, make_lispy_position):
4363 (make_lispy_event, make_lispy_movement, apply_modifiers):
4364 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4365 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4366 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4367 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4368 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4369
a053e86c 4370 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4371 (mark_kboards): Move decl here ...
4372 * alloc.c (mark_kboards): ... from here.
a053e86c 4373
4752793e
PE
4374 * lisp.h (force_auto_save_soon): New decl.
4375
74f10ca7 4376 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4377 (DEFINE_DUMMY_FUNCTION): New macro.
4378 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4379 Use it.
c03cd23f
PE
4380 (main): Add casts to avoid warnings
4381 if GCC considers string literals to be constants.
74f10ca7 4382
022e70d4
PE
4383 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4384
59d6fe83
PE
4385 * dbusbind.c: Pointer signedness fixes.
4386 (xd_signature, xd_append_arg, xd_initialize):
4387 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4388 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4389 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4390 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4391
78320123
PE
4392 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4393 if GCC considers string literals to be constants.
49cebcca 4394 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4395
35ac2a97
SM
43962011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4397
fb103ca9
SM
4398 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4399 (print_preprocess, print_object): New macro to fix last change.
4400
35ac2a97
SM
4401 * print.c (print_preprocess): Don't forget font objects.
4402
62973b41
JB
44032011-03-16 Juanma Barranquero <lekktu@gmail.com>
4404
4405 * emacs.c (USAGE3): Doc fixes.
4406
0e48bb22
AS
44072011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4408
4409 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4410 structure.
4411
7684e57b
JB
44122011-03-14 Juanma Barranquero <lekktu@gmail.com>
4413
4414 * lisp.h (VWindow_system, Qfile_name_history):
4415 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4416 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4417 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4418
4419 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4420 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4421
4422 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4423 * w32console.c (detect_input_pending, read_input_pending)
4424 (encode_terminal_code):
4425 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4426 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4427 (w32_system_caret_y, Qfile_name_history):
4428 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4429 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4430 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4431 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4432 * w32proc.c (Qlocal, report_file_error):
4433 * w32term.c (Vwindow_system, updating_frame):
4434 * w32uniscribe.c (initialized, uniscribe_font_driver):
4435 Remove unneeded extern declarations.
4436
2aa46d6c
CY
44372011-03-14 Chong Yidong <cyd@stupidchicken.com>
4438
c96bbc66 4439 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4440
cffc6f3b
CY
44412011-03-13 Chong Yidong <cyd@stupidchicken.com>
4442
4443 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4444 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4445 These macros can no longer be used for assignment.
4446
44f230aa
SM
4447 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4448 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4449 (record_buffer_markers, fetch_buffer_markers): New functions for
4450 recording and fetching special buffer markers.
4451 (set_buffer_internal_1, set_buffer_temp): Use them.
4452
4453 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4454
4455 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4456
4457 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4458 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4459
4460 * xdisp.c (hscroll_window_tree):
4461 (reconsider_clip_changes): Use PT instead of BUF_PT.
4462
d251f04b
EZ
44632011-03-13 Eli Zaretskii <eliz@gnu.org>
4464
4465 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4466 $(EMACS_ROOT)/lib/intprops.h.
4467
f0c77cd1
PE
44682011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4469
3eca4629
PE
4470 Fix more problems found by GCC 4.5.2's static checks.
4471
7c86ee98
PE
4472 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4473 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4474 (xg_free_frame_widgets): Make it clear that a local variable is
4475 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4476 (gdk_window_get_screen): Make it clear that this macro is needed
4477 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4478 (int_gtk_range_get_value): New function, which avoids a diagnostic
4479 from gcc -Wbad-function-cast.
4480 (xg_set_toolkit_scroll_bar_thumb): Use it.
4481 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4482 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4483 (get_utf8_string, xg_get_file_with_chooser):
4484 Rename locals to avoid shadowing.
4485 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4486
41729b81
PE
4487 * xgselect.c (xg_select): Remove unused var.
4488
f0c77cd1
PE
4489 * image.c (four_corners_best): Mark locals as initialized.
4490 (gif_load): Initialize transparent_p to zero (Bug#8238).
4491 Mark another local as initialized.
ec6cf4c6 4492 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4493
ce0ad53d 4494 * image.c (clear_image_cache): Now static.
d5d5a617 4495 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4496 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4497 (x_edge_detection): Remove unnecessary cast that
4498 gcc -Wbad-function-cast diagnoses.
2037898d 4499 (gif_load): Fix pointer signedness.
6ae141d6
PE
4500 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4501 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4502
33383987 45032011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4504
d32df629
PE
4505 Improve quality of tests for time stamp overflow.
4506 For example, without this patch (encode-time 0 0 0 1 1
4507 1152921504606846976) returns the obviously-bogus value (-948597
4508 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4509 reports time overflow. See
4510 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4511 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4512 * editfns.c: Include limits.h and intprops.h.
4513 (TIME_T_MIN, TIME_T_MAX): New macros.
4514 (time_overflow): Move earlier, to before first use.
4515 (hi_time, lo_time): New functions, for an accurate test for
4516 out-of-range times.
4517 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4518 (Fget_internal_run_time): Don't assume time_t fits in int.
4519 (make_time): Use list2 instead of Fcons twice.
4520 (Fdecode_time): More accurate test for out-of-range times.
4521 (check_tm_member): New function.
4522 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4523 (lisp_time_argument): Don't rely on undefined left-shift and
4524 right-shift behavior when checking for time stamp overflow.
8be6f318 4525
fe31d94c
PE
4526 * editfns.c (time_overflow): New function, refactoring common code.
4527 (Fformat_time_string, Fdecode_time, Fencode_time):
4528 (Fcurrent_time_string): Use it.
4529
8be6f318
PE
4530 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4531 * dired.c (make_time): Move to ...
4532 * editfns.c (make_time): ... here.
4533 * systime.h: Note the move.
4534
09d9db2c 45352011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4536
126bc0dc
YM
4537 * fringe.c (update_window_fringes): Remove unused variables.
4538
c47cbdfd
YM
4539 * unexmacosx.c (copy_data_segment): Also copy __got section.
4540 (Bug#8223)
4541
7ac80be9
EZ
45422011-03-12 Eli Zaretskii <eliz@gnu.org>
4543
c96bbc66 4544 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4545 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4546 Constify `char *' arguments and their references according to
4547 prototypes in tparam.h.
4548
ecb0f94d 4549 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4550
7ac80be9
EZ
4551 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4552 Adapt all references accordingly.
4553
4554 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4555
ef1fd07e
TT
45562011-03-11 Tom Tromey <tromey@redhat.com>
4557
4558 * buffer.c (syms_of_buffer): Remove obsolete comment.
4559
7ef4b50c
EZ
45602011-03-11 Eli Zaretskii <eliz@gnu.org>
4561
4562 * termhooks.h (encode_terminal_code): Declare prototype.
4563
4564 * msdos.c (encode_terminal_code): Don't declare prototype.
4565
4566 * term.c (encode_terminal_code): Now external again, used by
4567 w32console.c and msdos.c.
4568
44f230aa
SM
4569 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4570 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4571
4b1ec863 45722011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4573
1714f52b 4574 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4575
4b1ec863
PE
4576 * fringe.c (update_window_fringes): Mark locals as initialized
4577 (Bug#8227).
4578 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4579
524c7aa6
PE
4580 * alloc.c (mark_fringe_data): Move decl from here ...
4581 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4582 to check its interface.
4583 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4584
a5c0af81 4585 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4586 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4587 (fontset_font): Mark local as initialized.
a9a06e0b 4588 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4589
b4716021
PE
4590 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4591
811e9bac 4592 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4593 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4594 (x_own_selection, Fx_disown_selection_internal): Rename locals
4595 to avoid shadowing.
4596 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4597
7e3ab302
PE
4598 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4599 so that the caller can use some name other than gcpro1.
4600 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4601 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4602 (Fx_backspace_delete_keys_p):
4603 Use them to avoid shadowing, and rename vars to avoid shadowing.
4604 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4605 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4606 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4607 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4608 Remove unused locals.
7e3ab302
PE
4609 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4610 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4611 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4612 macros.
f78faa98 4613
e2b13473
PE
4614 * xterm.h (x_mouse_leave): New decl.
4615
77f23912
PE
4616 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4617 Remove unused functions.
cdf4ba58
PE
4618 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4619 (x_calc_absolute_position): Now static.
7411c686 4620 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4621 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4622 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4623 unless they are used.
38d0b34a
PE
4624 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4625 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4626 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4627 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4628 (x_error_catcher, x_connection_closed, x_error_handler):
4629 (x_error_quitter, xembed_send_message, x_iconify_frame):
4630 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4631 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4632 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4633
44f230aa
SM
4634 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4635 Rename or move locals to avoid shadowing.
6b463e58 4636 (tty_defined_color, merge_face_heights): Now static.
5967d051 4637 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4638 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4639 does not deduce is never used uninitialized.
73719eba
PE
4640 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4641 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4642
426994c3 4643 * terminal.c (store_terminal_param): Now static.
5489860b 4644
032f1620 4645 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4646 (set_frame_menubar): Remove unused local.
d4323972 4647 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4648 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4649 since they might point to immutable storage.
281585b0
PE
4650 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4651 since it's unused otherwise.
032f1620 4652
367c19e5 4653 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4654 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4655 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4656 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4657 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4658 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4659 does not deduce are never used uninitialized.
70739cbe 4660
07b48fa9
PE
4661 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4662
8868a238 4663 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4664 * window.c (window_loop, size_window):
4665 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4666
7e5cf297 4667 * window.c (display_buffer): Now static.
d6550a9f
PE
4668 (size_window): Mark variables that gcc -Wuninitialized
4669 does not deduce are never used uninitialized.
a586633d
PE
4670 * window.h (check_all_windows): New decl, to forestall
4671 gcc -Wmissing-prototypes diagnostic.
5b555da1 4672 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4673
f6095868
PE
4674 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4675 shadowing.
4676 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4677 Include <limits.h>.
4678 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4679 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4680 (load_charset_map): Mark variables that gcc -Wuninitialized
4681 does not deduce are never used uninitialized.
53df7c11 4682 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4683
f38b440c
PE
4684 * coding.c (coding_set_source, coding_set_destination):
4685 Use "else { /* comment */ }" rather than "else /* comment */;"
4686 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4687 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4688 a block, when the outer 'i' will do.
4689 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4690 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4691 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4692 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4693 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4694 Rename locals to avoid shadowing.
4695 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4696 * coding.c (emacs_mule_char, encode_invocation_designation):
4697 Now static, since they're not used elsewhere.
413bb2db 4698 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4699 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4700 (decode_coding_emacs_mule): Mark variables that gcc
4701 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4702 (detect_coding_iso_2022): Initialize a local variable that might
4703 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4704 this initialization is needed. (Bug#8211)
5f58e762
PE
4705 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4706 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4707 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4708 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4709 Remove unused macros.
f38b440c 4710
232b38b9 4711 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4712 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4713 * character.c (string_count_byte8): Likewise.
232b38b9 4714
fb90da1b
PE
4715 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4716 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4717
fb93dbc2
PE
4718 * chartab.c (copy_sub_char_table): Now static, since it's not used
4719 elsewhere.
5c156ace
PE
4720 (sub_char_table_ref_and_range, char_table_ref_and_range):
4721 Rename locals to avoid shadowing.
bbcd0949 4722 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4723
7d3b3862 4724 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4725 (BIDI_BOB): Remove unused macro.
7d3b3862 4726
6be7d3da
PE
4727 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4728 deduce are never used uninitialized.
c2ed9c8b 4729 * term.c (encode_terminal_code): Likewise.
6be7d3da 4730
75f8807f 4731 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4732
50938595
PE
4733 * tparam.h: New file.
4734 * term.c, tparam.h: Include it.
4735 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4736 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4737 Move these decls to tparam.h, and make them agree with what
4738 is actually in tparam.c. The previous trick of using incompatible
4739 decls in different modules does not conform to the C standard.
4740 All callers of tparam changed to use tparam's actual API.
4741 * tparam.c (tparam1, tparam, tgoto):
4742 Use const pointers where appropriate.
4743
fbceeba2
PE
4744 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4745 * cm.h (struct cm): Likewise.
4746 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4747 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4748 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4749 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4750 (turn_on_face, init_tty): Likewise.
4751 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4752
7f3f1250
PE
4753 * term.c (term_mouse_position): Rename local to avoid shadowing.
4754
e6ca6543
PE
4755 * alloc.c (mark_ttys): Move decl from here ...
4756 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4757
c40f8d15
AS
47582011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4759
4760 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4761
cfe0661d
JB
47622011-03-09 Juanma Barranquero <lekktu@gmail.com>
4763
4764 * search.c (compile_pattern_1): Remove argument regp, unused since
4765 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4766 (compile_pattern): Don't pass it.
4767
0afb4571
J
47682011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4769
4770 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4771 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4772 for ! HAVE_GTK3.
4773 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4774
4775 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4776
4777 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4778 gdk_window_get_screen, gdk_window_get_geometry,
4779 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4780 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4781 (xg_get_pixbuf_from_pixmap): New function.
4782 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4783 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4784 Call xg_get_pixbuf_from_pixmap instead of
4785 gdk_pixbuf_get_from_drawable.
4786 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4787 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4788 (xg_check_special_colors): Use GtkStyleContext and its functions
4789 for HAVE_GTK3.
4790 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4791 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4792 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4793 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4794 Call gtk_widget_get_preferred_size.
0afb4571
J
4795 (xg_frame_resized): gdk_window_get_geometry only takes 5
4796 parameters.
44f230aa
SM
4797 (xg_win_to_widget, xg_event_is_for_menubar):
4798 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4799 (xg_set_widget_bg): New function.
4800 (delete_cb): New function.
895009e1 4801 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4802 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4803 (xg_set_background_color): Call xg_set_widget_bg.
4804 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4805 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4806 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4807 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4808 if ! HAVE_GTK3.
4809 (update_frame_tool_bar): Call gtk_widget_hide.
4810 (xg_initialize): Use GDK_KEY_g.
4811
4812 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4813 if ! HAVE_GTK3
4814 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4815
4816 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4817 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4818 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4819
1c2cc4ef
JB
48202011-03-08 Juanma Barranquero <lekktu@gmail.com>
4821
4822 * w32xfns.c (select_palette): Check success of RealizePalette against
4823 GDI_ERROR, not zero.
4824
33383987 4825See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4826
4827;; Local Variables:
4828;; coding: utf-8
aac0c6e3
MR
4829;; End:
4830
33383987 4831 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4832
4833 This file is part of GNU Emacs.
4834
4835 GNU Emacs is free software: you can redistribute it and/or modify
4836 it under the terms of the GNU General Public License as published by
4837 the Free Software Foundation, either version 3 of the License, or
4838 (at your option) any later version.
4839
4840 GNU Emacs is distributed in the hope that it will be useful,
4841 but WITHOUT ANY WARRANTY; without even the implied warranty of
4842 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4843 GNU General Public License for more details.
4844
4845 You should have received a copy of the GNU General Public License
4846 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.