* jka-compr.el (jka-compr-call-process): Apply
[bpt/emacs.git] / src / ChangeLog
CommitLineData
de0100f2
EZ
12012-03-02 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5 (redisplay_window, next_element_from_string): Fix typos in
6 comments.
de0100f2 7
96a72ee9
GM
82012-03-02 Glenn Morris <rgm@gnu.org>
9
10 * buffer.c (buffer-list-update-hook): Doc fix.
11
312508d7
EZ
122012-02-29 Eli Zaretskii <eliz@gnu.org>
13
14 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
15 push_it before setting up the iterator for the first overlay
16 string, even if we have an empty string loaded.
17 (next_overlay_string): If there's an empty string on the iterator
18 stack, pop the stack. (Bug#10903)
19
27f3c637
PE
202012-02-25 Paul Eggert <eggert@cs.ucla.edu>
21
22 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
23 Suggested by Stefan Monnier in
24 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
25 * alloc.c (widen_to_Lisp_Object): New static function.
26 (mark_memory): Also mark Lisp_Objects by fetching pointer words
27 and widening them to Lisp_Objects. This would work even if
28 USE_LSB_TAG is defined and wide integers are used, which might
29 happen in a future version of Emacs.
30
3c9dfce6
CY
312012-02-25 Chong Yidong <cyd@gnu.org>
32
fa74b241
CY
33 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
34 Doc fix.
35
3c9dfce6
CY
36 * xselect.c (Fx_selection_exists_p): Doc fix.
37 (x_clipboard_manager_save_all): Print an informative message
38 before saving to clipboard manager.
39
9486df08
CY
402012-02-24 Chong Yidong <cyd@gnu.org>
41
42 * keyboard.c (process_special_events): Handle all X selection
43 requests in kbd_buffer, not just the next one (Bug#8869).
44
f01d3321
CY
452012-02-23 Chong Yidong <cyd@gnu.org>
46
47 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
48 call when setting menu-bar-lines and tool-bar-lines parameters.
49 (unwind_create_frame_1): New helper function.
50
51 * window.c (inhibit_window_configuration_change_hook): New var.
52 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 53 (syms_of_window): Initialize it.
f01d3321 54
86b847b6
CY
552012-02-22 Chong Yidong <cyd@gnu.org>
56
57 * xterm.c (x_draw_image_relief): Add missing type check for
58 Vtool_bar_button_margin (Bug#10743).
59
a59225b1
CY
602012-02-21 Chong Yidong <cyd@gnu.org>
61
62 * fileio.c (Vfile_name_handler_alist): Doc fix.
63
64 * buffer.c (Fget_file_buffer): Protect against invalid file
65 handler return value.
66
310f5bd4
PE
672012-02-20 Paul Eggert <eggert@cs.ucla.edu>
68
cb3a28cc
PE
69 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
70 when computing $valmask.
71
310f5bd4
PE
72 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
73 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
74 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
75 It's useless in that case, and it can cause problems on hosts
76 that allocate halves of EMACS_INT values separately.
77 Reported by Dan Horák. Diagnosed by Andreas Schwab in
78 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
79 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
80 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
81 it avoids undefined behavior on hosts where shifting right by more
82 than the word width has undefined behavior.
83
2375c96a
CY
842012-02-19 Chong Yidong <cyd@gnu.org>
85
86 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
87 (Funhandled_file_name_directory, Ffile_name_as_directory)
88 (Fdirectory_file_name, Fexpand_file_name)
89 (Fsubstitute_in_file_name): Protect against invalid file handler
90 return values (Bug#10845).
91
3eb49e71
EZ
922012-02-18 Eli Zaretskii <eliz@gnu.org>
93
94 * .gdbinit (pitx): Fix incorrect references to fields of the
95 iterator stack.
96
7b926f3f
CY
972012-02-17 Chong Yidong <cyd@gnu.org>
98
99 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
100
11273115
PE
1012012-02-15 Paul Eggert <eggert@cs.ucla.edu>
102
103 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
104 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
105
c3a70e2b
CY
1062012-02-15 Chong Yidong <cyd@gnu.org>
107
108 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
109 marked as special. Also, starting docstrings with * is obsolete.
110
0ca43699
AS
1112012-02-13 Andreas Schwab <schwab@linux-m68k.org>
112
113 * gnutls.c (emacs_gnutls_write): Fix last change.
114
2e8f3c56
LI
1152012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
116
117 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
118 send_process.
119
af70074f
SM
1202012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
121
122 * keymap.c (Fsingle_key_description): Handle char ranges.
123
95986d52
CY
1242012-02-12 Chong Yidong <cyd@gnu.org>
125
afd83bd1
CY
126 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
127 as that creates a dangerous corner case.
128
95986d52
CY
129 * window.c (Fdelete_window_internal): Invalidate the mouse
130 highlight (Bug#9904).
131
bd7da63e
GM
1322012-02-12 Glenn Morris <rgm@gnu.org>
133
134 * xselect.c (Fx_own_selection_internal)
135 (Fx_get_selection_internal, Fx_disown_selection_internal)
136 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
137 * nsselect.m (Fx_own_selection_internal)
138 (Fx_disown_selection_internal, Fx_selection_exists_p)
139 (Fx_selection_owner_p, Fx_get_selection_internal):
140 Sync docs and argument specs with the xselect.c versions.
141
77abcbc2
LI
1422012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
143
144 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
145
90b671e2
EZ
1462012-02-11 Eli Zaretskii <eliz@gnu.org>
147
1c0ca0b7
EZ
148 * w32select.c (Fx_selection_exists_p): Sync doc string and
149 argument list with xselect.c. (Bug#10783)
150
151 * w16select.c (Fx_selection_exists_p): Sync doc string and
152 argument list with xselect.c. (Bug#10783)
90b671e2 153
49241268
GM
1542012-02-10 Glenn Morris <rgm@gnu.org>
155
156 * fns.c (Fsecure_hash): Doc fix.
157
f998bbe7 1582012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
159
160 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
161
0992bd9c
CY
1622012-02-07 Chong Yidong <cyd@gnu.org>
163
164 * buffer.c (Fbuffer_local_variables)
165 (buffer_lisp_local_variables): Handle unbound vars correctly;
166 don't let Qunbound leak into Lisp.
167
af008560
GM
1682012-02-07 Glenn Morris <rgm@gnu.org>
169
dd605cc4
GM
170 * image.c (Fimagemagick_types): Doc fix.
171
af008560
GM
172 * image.c (imagemagick-render-type): Change it from a lisp object
173 to an integer. Move the doc here from the lisp manual.
174 Treat all values not equal to 0 the same.
175
1449fa1d
CY
1762012-02-06 Chong Yidong <cyd@gnu.org>
177
178 * doc.c (store_function_docstring): Avoid applying docstring of
179 alias to base function (Bug#2603).
180
3723ec07
AS
1812012-02-04 Andreas Schwab <schwab@linux-m68k.org>
182
183 * .gdbinit (pp1, pv1): Remove redundant defines.
184 (pr): Use pp.
185
79c1cc1e
CY
1862012-02-04 Chong Yidong <cyd@gnu.org>
187
188 * nsterm.m: Declare a global (Bug#10694).
189
d7f29f8e
EZ
1902012-02-04 Eli Zaretskii <eliz@gnu.org>
191
192 * w32.c (get_emacs_configuration_options): Include
193 --enable-checking, if specified, in the return value.
194
3b95a6f9
MR
1952012-02-04 Martin Rudalics <rudalics@gmx.at>
196
197 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
198 after rounding frame sizes. (Bug#9723)
199
d6fa96a6
EZ
2002012-02-04 Eli Zaretskii <eliz@gnu.org>
201
202 * keyboard.c (adjust_point_for_property): Don't position point
203 before BEGV. (Bug#10696)
204
df0b2940
PE
2052012-02-03 Paul Eggert <eggert@cs.ucla.edu>
206
207 Handle overflow when computing char display width (Bug#9496).
208 * character.c (char_width): Return EMACS_INT, not int.
209 (char_width, c_string_width): Check for overflow when
210 computing the width; this is possible now that individual
211 characters can have unbounded width. Problem introduced
212 by merge from Emacs 23 on 2012-01-19.
213
6bee44d6
MA
2142012-02-02 Michael Albinus <michael.albinus@gmx.de>
215
216 * dbusbind.c (Fdbus_register_method): Mention the return value
217 :ignore in the docstring.
218
44f92739
GM
2192012-02-02 Glenn Morris <rgm@gnu.org>
220
1b9f60cc
GM
221 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
222
44f92739
GM
223 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
224 Unconditionally set to t. (Bug#10673)
225 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
226 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
227 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
228
c5d3843c
KH
2292012-02-02 Kenichi Handa <handa@m17n.org>
230
231 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
232 0, do not call append_composite_glyph.
233
159462d4 2342012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
235
236 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
237 NULL (Bug#6988).
238 (x_produce_glyphs): If the component of a composition is a null
239 string, set it->pixel_width to 1 to avoid zero-width glyph.
240
78cef877
EZ
2412012-02-01 Eli Zaretskii <eliz@gnu.org>
242
243 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
244 first 2 arguments are identical. This makes inserting large
245 output from a subprocess an order of magnitude faster on
246 MS-Windows, where all sbrk'ed memory is always contiguous.
247
97897668
GM
2482012-01-31 Glenn Morris <rgm@gnu.org>
249
250 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 251 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
252 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
253
31fd3586
GM
2542012-01-29 Glenn Morris <rgm@gnu.org>
255
256 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
257
0e24a8b2
CY
2582012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
259
260 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
261
cc0adcb0
CY
2622012-01-28 Chong Yidong <cyd@gnu.org>
263
264 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
265
acc28cb9
CY
2662012-01-26 Chong Yidong <cyd@gnu.org>
267
9c69cfb7
CY
268 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
269
acc28cb9
CY
270 * search.c (Fsearch_forward, Fsearch_backward): Document negative
271 repeat counts (Bug#10507).
272
48da7392
GM
2732012-01-26 Glenn Morris <rgm@gnu.org>
274
275 * lread.c (syms_of_lread): Doc fix.
276
14af5f7f
CY
2772012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
278
279 * coding.c (encode_designation_at_bol): Change return value to
280 EMACS_INT.
281
0b21c100
CY
2822012-01-25 Chong Yidong <cyd@gnu.org>
283
284 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
285
3c2907f7
CY
2862012-01-21 Chong Yidong <cyd@gnu.org>
287
288 * floatfns.c (Fcopysign): Make the second argument non-optional,
289 since nil is not allowed anyway.
290
959ad23f
AS
2912012-01-21 Andreas Schwab <schwab@linux-m68k.org>
292
293 * process.c (read_process_output): Use p instead of XPROCESS (proc).
294 (send_process): Likewise.
295
34a02f46
MR
2962012-01-19 Martin Rudalics <rudalics@gmx.at>
297
298 * window.c (save_window_save, Fcurrent_window_configuration)
299 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
300 doc-strings.
301
1259009a 3022012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
303
304 * character.c (char_width): New function.
70d4fdf6
GM
305 (Fchar_width, c_string_width, lisp_string_width):
306 Use char_width (Bug#9496).
25ed9e61 307
6a6ee00d
MR
3082012-01-16 Martin Rudalics <rudalics@gmx.at>
309
310 * window.c (Vwindow_persistent_parameters): New variable.
311 (Fset_window_configuration, save_window_save): Handle persistent
312 window parameters.
313
c85efaf7
EZ
3142012-01-14 Eli Zaretskii <eliz@gnu.org>
315
316 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
317 thrashing the stack of the thread. (Bug#9087)
318
5944709e
PE
3192012-01-12 Paul Eggert <eggert@cs.ucla.edu>
320
321 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
322
e71f5d99
EZ
3232012-01-11 Eli Zaretskii <eliz@gnu.org>
324
325 * xdisp.c (rows_from_pos_range): Handle the case where the
326 highlight ends on a newline. (Bug#10464)
327 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
328 he end column for display of highlight that ends on a newline
329 before a R2L line.
330
ce316182
GM
3312012-01-11 Glenn Morris <rgm@gnu.org>
332
333 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
334 from load-path also when installation-directory is nil. (Bug#10208)
335
5b43da69
GM
3362012-01-10 Glenn Morris <rgm@gnu.org>
337
74cc8ff9
GM
338 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
339
7d8d6e4e
GM
340 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
341 Update template values to be closer to their typical values these days.
5b43da69 342
a0db8d43
EZ
3432012-01-09 Eli Zaretskii <eliz@gnu.org>
344
345 * xdisp.c (rows_from_pos_range): Accept additional argument
346 DISP_STRING, and accept any glyph in a row whose object is that
347 string as eligible for mouse highlight. Fixes mouse highlight of
348 display strings from overlays. (Bug#10464)
349
9a0115ab 3502012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 351
b9110d6a 352 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
353 * fileio.c (auto_saving_dir_umask): New static var.
354 (Fmake_directory_internal): Use it.
355 (do_auto_save_make_dir): Set it, instead of invoking chmod after
356 creating the directory. The old code temporarily assigns
357 too-generous permissions to the directory.
358 (do_auto_save_eh): Clear it.
b9110d6a 359 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
360 that the var is always cleared.
361
6c1bd3f3
EZ
3622012-01-07 Eli Zaretskii <eliz@gnu.org>
363
364 * search.c (scan_buffer): Pass character positions to
365 know_region_cache, not byte positions. (Bug#6540)
366
069d2b50
L
3672012-01-07 LynX <_LynX@bk.ru> (tiny change)
368
369 * w32.c (sys_rename): Report EXDEV when rename of a directory
370 fails because the target is on another logical disk. (Bug#10284)
371
75bf0d33
DB
3722012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
373
374 * xterm.c (x_embed_request_focus): New function.
375
376 * xterm.h: Add prototype.
377
378 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
379
1c6e5a32
GM
3802012-01-05 Glenn Morris <rgm@gnu.org>
381
382 * emacs.c (emacs_copyright): Update short copyright year to 2012.
383
651e947e
EZ
3842012-01-01 Eli Zaretskii <eliz@gnu.org>
385
386 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
387 Load gnutls_transport_set_lowat only if GnuTLS version is below
388 2.11.1.
389 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
390 GnuTLS versions below 2.11.1.
391
3778cdd8
AL
3922011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
393
394 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
395 to the doc string advising against its use for altering the way
396 windows are scrolled.
397
0e5317f7
KH
3982011-12-28 Kenichi Handa <handa@m17n.org>
399
400 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
401 coding-system ASCII compatible only when it does not produce BOM
402 on encoding (Bug#10383).
403
93d5ca1f
JD
4042011-12-26 Jan Djärv <jan.h.d@swipnet.se>
405
406 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
407 can scroll.
408 (create_and_show_popup_menu): Always use menu_position_func for
409 Gtk3 (Bug#10361).
410
ca22b785
AS
4112011-12-24 Andreas Schwab <schwab@linux-m68k.org>
412
413 * callint.c (Fcall_interactively): Don't truncate prompt string.
414
d048e1e6
EZ
4152011-12-23 Eli Zaretskii <eliz@gnu.org>
416
417 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
418 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 419 resumed from there (after widening). (Bug#10360)
d048e1e6 420
5ccaba1f
JD
4212011-12-22 Jan Djärv <jan.h.d@swipnet.se>
422
423 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
424
204ee57f
JD
4252011-12-21 Jan Djärv <jan.h.d@swipnet.se>
426
b81d40f0
JB
427 * nsterm.m (x_free_frame_resources):
428 Release f->output_data.ns->miniimage.
204ee57f
JD
429 (ns_index_color): Fix indentation. Do not retain
430 color_table->colors[i].
431
432 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
433 before returning.
434
435 * nsfns.m (x_set_background_color): Assign return value from
436 ns_index_color to face-background instead of NSColor*.
437 (ns_implicitly_set_icon_type): Fix indentation.
438 Change assignment in for loop to comparison.
439
440 * emacs.c (ns_pool): New variable.
441 (main): Assign ns_pool.
442 (Fkill_emacs): Call ns_release_autorelease_pool.
443
444 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
445 autorelease fdesc, release fdAttrs and tdict.
446 (ns_get_covering_families): Release charset.
447 (ns_findfonts): Release NSFontDescriptor created with new.
448 (ns_uni_to_glyphs): Fix indentation.
449 (setString): Release attrStr before assigning new value.
450
c803b2b7
JD
4512011-12-18 Jan Djärv <jan.h.d@swipnet.se>
452
678f4426
JD
453 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
454 and NS_IMPL_COCOA.
455 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
456 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
457
cd394be1 4582011-12-18 David Reitter <reitter@cmu.edu>
678f4426 459
5fecd5fc
JD
460 * nsterm.m (ns_term_init): Subscribe for notifications
461 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
462 to method trackingNotification in EmacsMenu.
463
464 * nsmenu.m (trackingMenu): New variable.
3771cb17 465 (trackingNotification): New method (from Aquamacs).
5fecd5fc 466 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 467 from Aquamacs (Bug#7030).
678f4426
JD
468
4692011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 470
c803b2b7
JD
471 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
472 (symbol_to_nsstring): Fix indentation.
473 (ns_symbol_to_pb): New function.
474 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
475 (Fns_rotate_cut_buffers_internal): Removed.
476 (Fns_store_selection_internal): Renamed from
477 Fns_store_cut_buffer_internal.
478 (ns_get_foreign_selection, Fx_own_selection_internal)
479 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
480 (Fns_get_selection_internal, Fns_store_selection_internal):
481 Use ns_symbol_to_pb and check if return value is nil.
482 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
483 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
484 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
485 renamed to Sns_store_selection_internal.
486 (ns_handle_selection_request): Move code to Fx_own_selection_internal
487 and remove this function.
488 (ns_handle_selection_clear): Remove, never used.
489 (Fx_own_selection_internal): Move code from ns_handle_selection_request
490 here.
491
e1b01a3a
KB
4922011-12-17 Ken Brown <kbrown@cornell.edu>
493
494 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
495 GID is unknown (Bug#10257).
496
2adb6e85
PE
4972011-12-17 Paul Eggert <eggert@cs.ucla.edu>
498
499 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
500 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
501 which caused a build failure on GNU/Linux IA-64. This problem was
502 introduced by my 2011-10-07 patch.
503
d1d7b339
JL
5042011-12-15 Juri Linkov <juri@jurta.org>
505
506 * image.c (imagemagick_error): New function. (Bug#10112)
507 (imagemagick_load_image): Comment out `MagickSetResolution' call.
508 Use `imagemagick_error' where ImageMagick functions return
509 `MagickFalse'.
510 (Fimagemagick_types): Add `Fnreverse' to return the list in the
511 proper order.
512
100d5755
KH
5132011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
514
515 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
516 fill background (Bug#8992).
517
454592a6
MR
5182011-12-13 Martin Rudalics <rudalics@gmx.at>
519
520 * window.c (Vwindow_combination_resize)
521 (Vwindow_combination_limit): Use t instead of non-nil in
522 doc-strings.
61d4b438
MR
523 (Vrecenter_redisplay): Add first sentence of doc-string on
524 separate line.
53524d93 525 (Frecenter): Fix doc-string typo.
454592a6 526
3633e3aa
KH
5272011-12-11 Kenichi Handa <handa@m17n.org>
528
529 * coding.c (Funencodable_char_position): Pay attention to the
530 buffer text relocation (Bug#9389).
531
7b9d523a
JD
5322011-12-10 Jan Djärv <jan.h.d@swipnet.se>
533
534 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
535 gtk_init (Bug#10100).
536
b73189c6
EZ
5372011-12-10 Eli Zaretskii <eliz@gnu.org>
538
539 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
540 IT->string is nil. (Bug#10263)
541
f7dfe5d6
JD
5422011-12-10 Jan Djärv <jan.h.d@swipnet.se>
543
83faebb4
JD
544 * nsterm.h (x_free_frame_resources): Declare.
545
f7dfe5d6
JD
546 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
547 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
548
549 * nsterm.h (ns_get_defaults_value): Declare.
550
551 * nsterm.m (ns_default): Call ns_get_defaults_value.
552
7cd4e72c
EZ
5532011-12-09 Eli Zaretskii <eliz@gnu.org>
554
555 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
556 (Bug#10170)
557
b34d7317
YM
5582011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
559
560 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
561 that where the value of an _OBJC_* symbol points to is in the .bss
562 section (Bug#10240).
563
76470ad1
KH
5642011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
565
566 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 567 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 568
745fff94
KH
5692011-12-08 Kenichi Handa <handa@m17n.org>
570
571 * ftfont.c (get_adstyle_property): Fix previous change
572 (Bug#10233).
573
6e44397c
JB
5742011-12-07 Juanma Barranquero <lekktu@gmail.com>
575
576 * w32.c (init_environment): If no_site_lisp, remove site-lisp
577 dirs from the default value of EMACSLOADPATH (bug#10208).
578
7efa6272
GM
5792011-12-07 Glenn Morris <rgm@gnu.org>
580
581 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
582 installation and source directories as well. (Bug#10208)
583
f6fc4d87
CY
5842011-12-06 Chong Yidong <cyd@gnu.org>
585
586 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
587
2bf26180
GM
5882011-12-06 Glenn Morris <rgm@gnu.org>
589
590 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
591 as an error, not just -1. (Bug#10217)
592
3a6ad4f0
CY
5932011-12-05 Chong Yidong <cyd@gnu.org>
594
595 * keyboard.c (process_special_events): New function.
596 (swallow_events, Finput_pending_p): Use it (Bug#10195).
597
75a3b399
PE
5982011-12-05 Paul Eggert <eggert@cs.ucla.edu>
599
600 * coding.c (encode_designation_at_bol): Don't use uninitialized
601 local variable (Bug#9318).
602
c3c9e25e
KH
6032011-12-05 Kenichi Handa <handa@m17n.org>
604
605 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
606 return Qnil (Bug#8046, Bug#10193).
607
5eb05ea3
KH
6082011-12-05 Kenichi Handa <handa@m17n.org>
609
610 * coding.c (encode_designation_at_bol): New args charbuf_end and
611 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
612 (coding_set_source): Return how many bytes coding->source was
613 relocated.
614 (coding_set_destination): Return how many bytes
615 coding->destination was relocated.
616 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
617 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
618
6192011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
620
621 * coding.c (CODING_CHAR_CHARSET_P): New macro.
622 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
623 macro (Bug#9318).
624
6252011-12-05 Andreas Schwab <schwab@linux-m68k.org>
626
627 The following changes are to fix Bug#9318.
628
a79703f5 629 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
630 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
631 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 632 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 633
7dbda6df
JB
6342011-12-05 Juanma Barranquero <lekktu@gmail.com>
635
636 * lisp.h (process_quit_flag): Fix external declaration.
637
6d5eb5b0
SM
6382011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
639
640 Don't macro-inline non-performance-critical code.
641 * eval.c (process_quit_flag): New function.
642 * lisp.h (QUIT): Use it.
643
a0c3fad0
JD
6442011-12-04 Jan Djärv <jan.h.d@swipnet.se>
645
646 * nsfns.m (get_geometry_from_preferences): New function.
647 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
648
6c07aac2
AS
6492011-12-04 Andreas Schwab <schwab@linux-m68k.org>
650
651 * emacs.c (Qkill_emacs): Define.
652 (syms_of_emacs): Initialize it.
653 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
654 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
655 (quit_throw_to_read_char): Add parameter `from_signal'.
656 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
657 * lisp.h (QUIT): Call Fkill_emacs if requested.
658
c052ead4
JD
6592011-12-03 Jan Djärv <jan.h.d@swipnet.se>
660
661 * widget.c (update_wm_hints): Return if wmshell is null.
662 (widget_update_wm_size_hints): New function.
663
664 * widget.h (widget_update_wm_size_hints): Declare.
665
666 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
667 widget_update_wm_size_hints (Bug#10104).
668
9e49252b
EZ
6692011-12-03 Eli Zaretskii <eliz@gnu.org>
670
671 * xdisp.c (handle_invisible_prop): If the invisible text ends just
672 before a newline, prepare the bidi iterator for consuming the
673 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 674 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 675
02b16839
JL
6762011-12-02 Juri Linkov <juri@jurta.org>
677
678 * search.c (Fword_search_regexp): New Lisp function created from
679 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
680 (Fword_search_backward, Fword_search_forward)
681 (Fword_search_backward_lax, Fword_search_forward_lax):
682 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
683 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
684
0068070e
SM
6852011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
686
687 * fileio.c (Finsert_file_contents): Move after-change-function call
688 to before the "handled:" label, since all "goto handled" appear in
689 cases where the *-change-functions have already been properly called
690 (bug#10117).
691
3360a3fc
AS
6922011-12-01 Andreas Schwab <schwab@linux-m68k.org>
693
694 * keyboard.c (interrupt_signal): Don't call kill-emacs when
695 waiting for input. (Bug#10169)
696
73d6c093
EZ
6972011-11-30 Eli Zaretskii <eliz@gnu.org>
698
699 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
700 verifies glyph row's hash code--we have just reallocated the
701 glyphs, so their contents can be complete garbage. (Bug#10164)
702
febe6bea
JB
7032011-11-30 Juanma Barranquero <lekktu@gmail.com>
704
705 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
706
801a4313
EZ
7072011-11-30 Eli Zaretskii <eliz@gnu.org>
708
709 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
710 attributes are tested _before_ calling verify_row_hash, to protect
711 against GCC re-ordering of the tests. (Bug#10164)
712
2b56b87e
JD
7132011-11-29 Jan Djärv <jan.h.d@swipnet.se>
714
715 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
716
717 * xterm.c (handle_one_xevent): Only set async_visible and friends
718 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 719 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
720 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
721
dbf31225
PE
7222011-11-28 Paul Eggert <eggert@cs.ucla.edu>
723
724 Remove GCPRO-related macros that exist only to avoid shadowing locals.
725 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
726 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
727 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
728 All uses changed to use GCPRO1 etc.
729 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
730 Revert to old implementation (i.e., before 2011-03-11).
731
1305621b
YM
7322011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
733
734 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
735 of scroll runs so as to avoid assigning disabled bogus rows and
736 unnecessary graphics copy operations.
737
8c9afb46
EZ
7382011-11-27 Eli Zaretskii <eliz@gnu.org>
739
740 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
741 (snprintf) [_MSC_VER]: Redirect to _snprintf.
742 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
743 (malloc, free, realloc, calloc): Redirect to e_* only when
744 compiling Emacs.
745
746 * lisp.h (GCTYPEBITS): Move before first use.
747 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
748 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
749 this macro definition.
750
751 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
752 _MSC_VER.
753
54e9e3bf
JD
7542011-11-27 Jan Djärv <jan.h.d@swipnet.se>
755
6d5eb5b0
SM
756 * gtkutil.c (xg_create_frame_widgets):
757 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
758 present with Gtk+ 2.0.
759
83aca1cb
PE
7602011-11-26 Paul Eggert <eggert@cs.ucla.edu>
761
762 * fileio.c (Finsert_file_contents): Undo previous change; see
763 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
764
5b76caa4
PE
7652011-11-26 Paul Eggert <eggert@cs.ucla.edu>
766
767 Rename locals to avoid shadowing.
768 * fileio.c (Finsert_file_contents):
769 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
770 * process.c (wait_reading_process_output):
771 Rename inner 'proc' to 'p' to avoid shadowing.
772 Indent for consistency with usual Emacs style.
773
8c535114
EZ
7742011-11-25 Eli Zaretskii <eliz@gnu.org>
775
776 * xdisp.c (redisplay_window): If cursor row is not fully visible
777 after recentering, and scroll-conservatively is set to a large
778 number, scroll window by a few more lines to make the cursor fully
779 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
780 (start_display): Don't move to the next line if the display should
781 start at a newline that is part of a display vector or an overlay
782 string. (Bug#10119)
8c535114 783
fa4fdb5c
JL
7842011-11-24 Juri Linkov <juri@jurta.org>
785
786 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
787 after the `MagickPingImage' call. (Bug#10112)
788
90ec88df
CY
7892011-11-23 Chong Yidong <cyd@gnu.org>
790
791 * window.c (Fcoordinates_in_window_p): Accept only live windows.
792
56e2e794
MR
7932011-11-23 Martin Rudalics <rudalics@gmx.at>
794
795 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
796 making another buffer current. (Bug#10114)
797
b6e64c41
GM
7982011-11-23 Glenn Morris <rgm@gnu.org>
799
800 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
801
6b21de18
CY
8022011-11-23 Chong Yidong <cyd@gnu.org>
803
804 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
805 using it (Bug#5984).
806
b12cd789
EZ
8072011-11-22 Eli Zaretskii <eliz@gnu.org>
808
809 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
810 and header-lines, as they don't have one computed for them.
811 (Bug#10098)
812
813 * .gdbinit (prow): Make displayed values more self-explaining.
814 Add row's hash code.
815
261b6fd4
LMI
8162011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
817
818 * process.c (wait_reading_process_output): Fix asynchrounous
819 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 820 (wait_reading_process_output): Add comment and URL.
261b6fd4 821
e7cfd277
JD
8222011-11-21 Jan Djärv <jan.h.d@swipnet.se>
823
824 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
825
a9b9b7f5
CY
8262011-11-21 Chong Yidong <cyd@gnu.org>
827
828 * window.c (Fnext_window, Fprevious_window): Doc fix.
829
b0d15b4f
SM
8302011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
831
832 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
833
fe7a3057
JB
8342011-11-20 Juanma Barranquero <lekktu@gmail.com>
835
836 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
837
d2999b1a
MR
8382011-11-20 Martin Rudalics <rudalics@gmx.at>
839
840 * window.c (Fset_window_combination_limit): Rename argument
841 STATUS to LIMIT.
842 (Vwindow_combination_limit): Remove "status" from doc-string.
843
d5ff9cd0
AS
8442011-11-20 Andreas Schwab <schwab@linux-m68k.org>
845
846 * m/ibms390.h: Remove.
847 * m/ibms390x.h: Don't include "ibms390.h".
848
a5bb9bd3
SM
8492011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
850
851 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
852 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
853
cd1181db
JB
8542011-11-20 Juanma Barranquero <lekktu@gmail.com>
855
856 * casetab.c (Fset_case_table):
857 * charset.c (Fcharset_after): Fix typos.
858
615a3b8d 8592011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 860
17e845af
PE
861 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
862 Otherwise, valgrind does not work on some platforms.
863 Problem reported by Andreas Schwab in
6a0bf43d
PE
864 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
865 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
866 is set, removing the need for VIRT_ADDRESS_VARIES.
867 (PURE_P): Use a more-efficient implementation that needs just one
868 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
869 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
870 to 4 (xorl, subq, cmpq, setbe).
871 * alloc.c (pure): Always extern now, since that's the
872 VIRT_ADDR_VARIES behavior.
873 (PURE_POINTER_P): Use a single comparison, not two, for
874 consistency with the new puresize.h.
875 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
876 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
877 Remove VIRT_ADDR_VARIES no longer needed.
878
f8fe6f96
EZ
8792011-11-19 Eli Zaretskii <eliz@gnu.org>
880
881 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
882 (erase_phys_cursor, update_window_cursor, show_mouse_face)
883 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
884 behave as if the cursor position were at the window margin.
885
886 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
887 and the cursor position is out of bounds, behave as if the cursor
888 position were at the window margin. (Bug#10075)
889
df05a53c
CY
8902011-11-18 Chong Yidong <cyd@gnu.org>
891
892 * window.c (Fwindow_combination_limit): Make first argument
893 non-optional, since it is meaningless for live windows like the
894 selected window.
895
2071918e
DA
8962011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
897
898 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
899
b50a28de
SM
9002011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
901
902 * intervals.c: Fix grafting over the whole buffer (bug#10071).
903 (graft_intervals_into_buffer): Simplify.
904
015137db
EZ
9052011-11-18 Eli Zaretskii <eliz@gnu.org>
906
907 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
908 hash values of the two rows.
909 (copy_row_except_pointers): Preserve the used[] arrays and the
910 hash values of the two rows. (Bug#10035)
68c95424 911 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
912
913 * xdisp.c (row_hash): New function, body extracted from
914 compute_line_metrics.
915 (compute_line_metrics): Call row_hash, instead of computing the
916 hash code inline.
917
918 * dispnew.c (verify_row_hash): Call row_hash for computing the
919 hash code of a row, instead of duplicating code from xdisp.c.
920
921 * dispextern.h (row_hash): Add prototype.
922
a2addb04
TH
9232011-11-18 Tassilo Horn <tassilo@member.fsf.org>
924
925 * frame.c (delete_frame): Don't delete the terminal when the last
926 X frame is closed if emacs is built with GTK toolkit.
927
df85d315
JB
9282011-11-17 Juanma Barranquero <lekktu@gmail.com>
929
930 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
931
a0c2d0ae
MR
9322011-11-17 Martin Rudalics <rudalics@gmx.at>
933
934 * window.c (Vwindow_splits): Rename to
935 Vwindow_combination_resize. Suggested by Juri Linkov.
936 (Fsplit_window_internal): Use Vwindow_combination_resize instead
937 of Vwindow_splits.
938
58179cce
JB
9392011-11-16 Juanma Barranquero <lekktu@gmail.com>
940
7877f373
JB
941 * nsfns.m (Fns_font_name):
942 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 943
b6f67890
MR
9442011-11-16 Martin Rudalics <rudalics@gmx.at>
945
946 * window.h (window): Rename slot "nest" to "combination_limit".
947 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
948 (Fset_window_nest): Rename to Fset_window_combination_limit.
949 (Vwindow_nest): Rename to Vwindow_combination_limit.
950 (recombine_windows, make_parent_window, make_window)
951 (Fsplit_window_internal, saved_window)
952 (Fset_window_configuration, save_window_save): Rename all
953 occurrences of window_nest to window_combination_limit.
954
c7015153
JB
9552011-11-15 Juanma Barranquero <lekktu@gmail.com>
956
957 * image.c (imagemagick_load_image): Fix typo.
958
322ad6ec
EZ
9592011-11-14 Eli Zaretskii <eliz@gnu.org>
960
961 * xdisp.c (display_line): Move the call to
962 highlight_trailing_whitespace before the call to
963 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
964 faces of all the glyphs to compute ROW's hash value.
965 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 966
f067b8ec
JB
9672011-11-14 Juanma Barranquero <lekktu@gmail.com>
968
969 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
970 just return (bug#10044).
971
1e5b2111
EZ
9722011-11-12 Eli Zaretskii <eliz@gnu.org>
973
7ef3cbd5
EZ
974 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
975 with user-defined heap size. Bump the default size of the temacs
976 heap to 27MB, to avoid memory warning when running temacs.
977 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
978
1e5b2111
EZ
979 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
980 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
981 (verify_row_hash) [XASSERTS]: New function.
982 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
983 that the hash value of glyph rows is correct.
1e5b2111 984
89d61221
MR
9852011-11-12 Martin Rudalics <rudalics@gmx.at>
986
987 * window.h (window): Remove splits slot.
988 * window.c (Fwindow_splits, Fset_window_splits): Remove.
989 (Fdelete_other_windows_internal, make_parent_window)
990 (make_window, Fsplit_window_internal, Fdelete_window_internal)
991 (Fset_window_configuration, save_window_save): Don't deal with
992 split status of windows.
993 (saved_window): Remove splits slot.
994 (Vwindow_splits): Rewrite doc-string.
995
97f18cc8
JD
9962011-11-11 Jan Djärv <jan.h.d@swipnet.se>
997
998 * xfns.c (unwind_create_frame):
999 * nsfns.m (unwind_create_frame):
1000 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1001 Vframe_list (Bug#9999).
1002
22a648b4
DA
10032011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1004
0b381c7e 1005 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1006
659afede
KH
10072011-11-11 Kenichi Handa <handa@m17n.org>
1008
1009 * callproc.c (Fcall_process): Set the member dst_multibyte of
1010 process_coding.
1011
9ac0394b
KH
10122011-11-11 Johan Bockgård <bojohan@gnu.org>
1013
1014 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1015 avoid a crash (bug#9496).
1016
2fbdc249
CY
10172011-11-09 Chong Yidong <cyd@gnu.org>
1018
1019 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1020 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1021
ac6b1f81
PE
10222011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1023
1024 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1025
09db192c
PE
10262011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1027
1028 Avoid some portability problems by eschewing 'extern inline' functions.
1029 The trivial performance wins aren't worth the portability hassles; see
1030 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1031 et seq.
1032 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1033 (window_box_width, window_box_left, window_box_left_offset)
1034 (window_box_right, window_box_right_offset): Undo previous change,
1035 by removing the "extern"s.
1036 * intervals.c (adjust_intervals_for_insertion)
1037 (adjust_intervals_for_deletion): Undo previous change,
1038 making these static again.
1039 (offset_intervals, temp_set_point_both, temp_set_point)
1040 (copy_intervals_to_string): No longer inline.
1041 * xdisp.c (window_text_bottom_y, window_box_width)
1042 (window_box_height, window_box_left_offset)
1043 (window_box_right_offset, window_box_left, window_box_right)
1044 (window_box): No longer inline.
1045
105216ed
CY
10462011-11-08 Chong Yidong <cyd@gnu.org>
1047
1048 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1049 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1050 Signal an error if not a live window.
105216ed
CY
1051 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1052 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1053
ae9e237f
JB
10542011-11-07 Juanma Barranquero <lekktu@gmail.com>
1055
1056 * lisp.h (syms_of_abbrev): Remove declaration.
1057 Reported by CHENG Gao <chenggao@royau.me>.
1058
c7aa8333
EZ
10592011-11-07 Eli Zaretskii <eliz@gnu.org>
1060
1061 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1062 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1063 of temacs in GUI mode.
1064
be7f5545
MR
10652011-11-07 Martin Rudalics <rudalics@gmx.at>
1066
1067 * window.h: Declare delete_all_child_windows instead of
1068 delete_all_subwindows.
1069 * window.c (Fwindow_nest, Fset_window_nest)
1070 (Fset_window_new_total, Fset_window_new_normal)
1071 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1072 (delete_all_subwindows): Rename to delete_all_child_windows.
1073 (Fdelete_other_windows_internal, Fset_window_configuration):
1074 Call delete_all_child_windows instead of delete_all_subwindows.
1075 * frame.c (delete_frame): Call delete_all_child_windows instead
1076 of delete_all_subwindows.
1077
ca78dc43
PE
10782011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1079
1080 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1081 This is also needed for porting to any host where GC_MARK_STACK is
1082 not GC_MAKE_GCPROS_NOOPS.
1083 (which_symbols): Use it.
1084
a0241d01
KH
10852011-11-07 Kenichi Handa <handa@m17n.org>
1086
1087 * coding.c (coding_set_destination): Check coding->src_pos only
1088 when coding->src_object is a buffer (bug#9910).
1089
1090 * process.c (send_process): Set the member src_multibyte of coding
1091 to 0 (bug#9911) when sending a unibyte text.
1092
1093 * callproc.c (Fcall_process): Set the member src_multibyte of
1094 process_coding to 0 (bug#9912).
1095
a64bfdfa 10962011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1097
1098 * xmenu.c (cleanup_widget_value_tree): New function.
1099 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1100 calling free_menubar_widget_value_tree directly (Bug#9830).
1101
cb41b32a
PE
11022011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1103
1104 Fix some portability problems with 'inline'.
1105 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1106 (window_box_width, window_box_left, window_box_left_offset)
1107 (window_box_right, window_box_right_offset): Declare extern.
1108 Otherwise, these inline functions do not conform to C99 and
1109 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1110 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1111 * intervals.c (adjust_intervals_for_insertion)
1112 (adjust_intervals_for_deletion): Now extern, because otherwise the
1113 extern inline functions 'offset_intervals' couldn't refer to it.
1114 (static_offset_intervals): Remove.
1115 (offset_intervals): Rewrite using the old contents of
1116 static_offset_intervals. The old version didn't conform to C99
1117 because an extern inline function contained a reference to an
1118 identifier with static linkage.
1119
b7041366
AS
11202011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1121
1122 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1123 GC.
1124
88a37c4d
EZ
11252011-11-06 Eli Zaretskii <eliz@gnu.org>
1126
1127 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1128 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1129 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1130 return Qleft_to_right.
1131
49745b39
CY
11322011-11-06 Chong Yidong <cyd@gnu.org>
1133
1134 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1135 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1136 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1137 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1138 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1139 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1140 (Fwindow_vscroll): Doc fix.
1141 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1142 argument, since it makes no sense to pass a live window and for
1143 consistency with window-child.
1144
1f05cd82
CS
11452011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1146
1147 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1148 support MSVC.
1149
22610910
JR
11502011-11-05 Jason Rumney <jasonr@gnu.org>
1151
1152 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1153 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1154 fonts (Bug#6029).
1155 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1156 bitwise arithmetic preventing use of unicode-sip and non-truetype
1157 opentype fonts.
1158
a06776b2
EZ
11592011-11-05 Eli Zaretskii <eliz@gnu.org>
1160
3ad924ba
EZ
1161 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1162 "emacs"-only part.
1163
a06776b2
EZ
1164 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1165 initialization code to keep similarity to xfns.c after changes
1166 from 2011-11-05.
1167
c9e7db78
JD
11682011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1169
a97f8f3f
JD
1170 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1171 (unwind_create_frame): New function (Bug#9943).
1172 (Fx_create_frame): Restructure code to be more similar to the one in
1173 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1174 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1175 Move terminal->reference_count++ just before making the frame official
1176 (Bug#9943).
1177
1178 * nsterm.m (x_free_frame_resources): New function.
1179 (x_destroy_window): Move code to x_free_frame_resources.
1180
c9e7db78 1181 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1182 (Fx_create_frame, x_create_tip_frame):
1183 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1184 official. Move initialization of image_cache_refcount and
1185 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1186
a6fc3b5c
EZ
11872011-11-05 Eli Zaretskii <eliz@gnu.org>
1188
1189 Support MSVC build with newer versions of Visual Studio.
1190 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1191 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1192 nt/gmake.defs.
1193
1194 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1195 which are not supported by MSVC.
1196 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1197 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1198 bitfields.
1199 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1200 types in bitfields.
1201 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1202
1203 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1204
58179cce 12052011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1206
1207 Support MSVC build with newer versions of Visual Studio.
1208 * w32.c: Don't include w32api.h for MSVC.
1209 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1210
1211 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1212 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1213 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1214 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1215 e_* cousins.
1216 (alloca) [_MSC_VER]: Define to _alloca.
1217
1218 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1219
1220 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1221
a58c13ed
EZ
12222011-11-04 Eli Zaretskii <eliz@gnu.org>
1223
1224 * xdisp.c (note_mouse_highlight): If either of
1225 previous/next-single-property-change returns nil, treat that as
1226 the beginning or the end of the buffer. (Bug#9955)
1227
fe0b6370
JD
12282011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1229
a58c13ed 1230 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1231 label is not null (Bug#9951).
1232 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1233 may be NULL.
1234
89bd5ee1
EZ
12352011-11-04 Eli Zaretskii <eliz@gnu.org>
1236
1237 * window.c (Fwindow_body_size): Mention in the doc string that the
1238 return value is in frame's canonical units. (Bug#9949)
1239
84c3edb9
EZ
12402011-11-03 Eli Zaretskii <eliz@gnu.org>
1241
4e2fb5c7
EZ
1242 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1243
84c3edb9 1244 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1245 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1246 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1247
bc17a887
EZ
12482011-11-01 Eli Zaretskii <eliz@gnu.org>
1249
1250 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1251 Don't stop backward scan on the continuation glyph, even though
1252 its CHARPOS is positive.
6d5eb5b0
SM
1253 (mouse_face_from_buffer_pos, note_mouse_highlight):
1254 Rename cover_string to disp_string.
bc17a887 1255
4ee88440
MR
12562011-11-01 Martin Rudalics <rudalics@gmx.at>
1257
1258 * window.c (temp_output_buffer_show): Don't use
1259 Vtemp_buffer_show_specifiers.
1260 (Vtemp_buffer_show_specifiers): Remove unused variable.
1261
c2ff3c02
EZ
12622011-10-30 Eli Zaretskii <eliz@gnu.org>
1263
1264 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1265 past the beginning of the current glyph matrix.
1266
58179cce 12672011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1268
1269 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1270 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1271 HAVE_GTK3 (Bug#9869).
b77a6a7f 1272
3b574623
JD
1273 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1274 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1275
b77a6a7f
JD
1276 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1277
1278 * xterm.c: Declare x_handle_net_wm_state to return int.
1279 (handle_one_xevent): Check if we are iconified but don't have
1280 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1281 (get_current_wm_state): Return non-zero if not hidden,
1282 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1283 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1284 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1285 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1286
196e41e4
PE
12872011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1288
1289 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1290 so that this new function doesn't get optimized away by a
1291 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1292
021f2e1a
AS
12932011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1294
1295 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1296
8b058d44
EZ
12972011-10-29 Eli Zaretskii <eliz@gnu.org>
1298
1299 Fix the `xbytecode' command.
1300 * .gdbinit (xprintbytestr): New command.
b50a28de 1301 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1302 (xbytecode): Print the byte-code string as well.
1303
4452fb80
EZ
13042011-10-29 Kim Storm <storm@cua.dk>
1305
8b058d44
EZ
1306 * alloc.c (which_symbols): New function.
1307
21b72067
AS
13082011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1309
1310 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1311 line. (Bug#9903)
1312
83ed7b5c
GM
13132011-10-29 Glenn Morris <rgm@gnu.org>
1314
1315 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1316 Not clear what it was for, and it causes various bugs. (Bug#9839)
1317
5a7a728b
EZ
13182011-10-28 Eli Zaretskii <eliz@gnu.org>
1319
1320 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1321 possible random value that matches one of those tested as
1322 condition to clear the mouse face.
1323
d3d0842f
CY
13242011-10-28 Chong Yidong <cyd@gnu.org>
1325
1326 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1327
31b39d13
DN
13282011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1329
1330 * window.c (make_window): Initialize phys_cursor_on_p.
1331
9aba6043
SM
13322011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1333
1334 * lisp.h (struct Lisp_Symbol): Update comments.
1335
c20992f4
JB
13362011-10-28 Juanma Barranquero <lekktu@gmail.com>
1337
1338 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1339
db4f02f2
EZ
13402011-10-28 Eli Zaretskii <eliz@gnu.org>
1341
1342 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1343 <oslsachem@gmail.com> for helping to debug this.
1344
1345 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1346 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1347 (g_b_init_get_glyph_outline_w): New static variables.
1348 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1349 (GetGlyphOutlineW_Proc): New typedefs.
1350 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1351 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1352 New functions.
1353 (w32font_open_internal, compute_metrics):
1354 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1355 instead of calling the "wide" APIs directly.
1356
1357 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1358
1359 * w32.h (syms_of_w32font): Add prototype.
1360
87e68db4
JB
13612011-10-27 Juanma Barranquero <lekktu@gmail.com>
1362
1363 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1364 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1365 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1366 (Fmove_to_window_line): Doc fix.
1367
435c1d67
CY
13682011-10-27 Chong Yidong <cyd@gnu.org>
1369
1370 * process.c (make_process): Set gnutls_state to NULL.
1371
1372 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1373 non-NULL, regardless of GNUTLS_INITSTAGE.
1374 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1375 an error. Set process slots as soon as we allocate them.
1376
1377 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1378
9c6c6f49
CY
13792011-10-27 Chong Yidong <cyd@gnu.org>
1380
9aba6043
SM
1381 * gnutls.c (emacs_gnutls_deinit): New function.
1382 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1383 (Fgnutls_deinit, Fgnutls_boot): Use it.
1384
1385 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1386 (deactivate_process): Call emacs_gnutls_deinit.
1387
657d08d3
JB
13882011-10-27 Juanma Barranquero <lekktu@gmail.com>
1389
1390 * image.c (x_create_x_image_and_pixmap):
1391 * w32.c (sys_rename, w32_delayed_load):
1392 * w32font.c (fill_in_logfont):
1393 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1394
5430d399
JB
13952011-10-26 Juanma Barranquero <lekktu@gmail.com>
1396
1397 * w32fns.c (w32_default_color_map): New function,
1398 extracted from Fw32_default_color_map.
a7ef684b 1399 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1400
fe0055fa
PE
14012011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1402
1403 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1404
e6346438
SM
14052011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1406
1407 * keyboard.c (test_undefined): New function (bug#9751).
1408 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1409
e112cc37
ET
14102011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1411
1412 * sysdep.c (init_sys_modes): Fix the check for the controlling
1413 terminal (Bug#6649).
1414
7b5d6677
EZ
14152011-10-20 Eli Zaretskii <eliz@gnu.org>
1416
1417 * dispextern.h (struct bidi_it): New member next_en_type.
1418
1419 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1420 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1421 current character, check also for next_en_type being WEAK_EN.
1422 (bidi_resolve_weak): Don't enter the expensive loop if the current
1423 position is before next_en_pos. Record the bidi type of the first
1424 non-ET, non-BN character we find, in addition to its position.
1425 (bidi_level_of_next_char): Invalidate next_en_type when
1426 next_en_pos is over-stepped.
1427
7da0b018
PE
14282011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1429
1430 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1431 * editfns.c: Rewrite current-time-zone so that it invokes
1432 the equivalent of (format-time-string "%Z") to get the time zone name.
1433 This fixes a bug when the time zone name contains characters that
1434 need converting from the system time locale to Emacs internal format.
1435 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1436 that patch fixed format-time-string to do the conversion, but
1437 I forgot to fix current-time-zone.
1438 (format_time_string): New function, containing most of
1439 what Fformat_time_string used to contain.
1440 (Fformat_time_string): Rewrite in terms of format_time_string.
1441 This doesn't change this function's behavior.
1442 (current-time-zone): Rewrite to use format_time_string.
1443 This fixes the bug reported by Michael Schierl in
1444 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1445 Jason Rumney's 2007-06-07 change worked around this bug, but
1446 didn't fix it.
1447 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1448
8547b010
EZ
14492011-10-19 Eli Zaretskii <eliz@gnu.org>
1450
1451 * xdisp.c (start_display): If the character at POS is displayed
1452 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1453 (try_window_reusing_current_matrix): If a line ends in a display
1454 vector or the next line starts in a display vector, continue
1455 redrawing the window even though the character position of
1456 start_row was reached.
8547b010
EZ
1457 (Bug#9771, part 2)
1458
4e948d15
CY
14592011-10-18 Chong Yidong <cyd@gnu.org>
1460
1461 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1462 with nobreak-char-display too.
1463
4787455f
EZ
14642011-10-18 Eli Zaretskii <eliz@gnu.org>
1465
1466 Fix part 3 of bug#9771.
1467 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1468 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1469 non-neutral characters if the current character is a paragraph
1470 separator (a.k.a. Newline). This avoids running the same
1471 expensive loop twice, once when we consume the preceding newline
1472 and the other time when the line actually needs to be displayed.
1473 Avoid the loop when we see neutrals on the base embedding level
1474 following a character whose directionality is the same as the
1475 paragraph's. This avoids running the expensive loop when a line
1476 ends in a long sequence of neutrals, like control characters.
1477 Add assertion against STRONG_AL type. Slightly rearrange code
1478 that determines the type of a neutral given the first non-neutral
1479 that follows it.
1480 (bidi_level_of_next_char): Set next_en_pos to zero when
1481 invalidating its info.
1482
2c91f553
EZ
14832011-10-17 Eli Zaretskii <eliz@gnu.org>
1484
1485 * xdisp.c (push_display_prop): Determine whether to record string
1486 or buffer position by IT->string, not by IT->method. Allow
1487 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1488 (move_it_vertically_backward): Don't look for character position
1489 immediately after the newline when in a continuation line.
1490 (Bug#9771, part 1)
2c91f553 1491
c7b08b0d
MR
14922011-10-15 Martin Rudalics <rudalics@gmx.at>
1493
1494 * window.c (coordinates_in_window): Rewrite and delabelize
1495 vertical border check. (Bug#5357) (Bug#9618)
1496
6b02f655
SM
14972011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1498
1499 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1500 errors in XSetWindowBorder (bug#9310).
1501
81d40c92
DA
15022011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1503
1504 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1505 avoid crash when xmalloc overrun checking is enabled.
1506
d4172c3b
EZ
15072011-10-13 Eli Zaretskii <eliz@gnu.org>
1508
1509 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1510 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1511 cursor motion with <left> and <right> arrow keys.
1512
1513 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1514 some callers set that themselves.
1515
b00eea75
EZ
15162011-10-12 Eli Zaretskii <eliz@gnu.org>
1517
1518 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1519 display string and the previous row comes from the same string and
1520 is empty. (Bug#9739) (Bug#9738)
1521
8fe012c4
SM
15222011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1523
1524 * doc.c (get_doc_string): Encode file name (bug#9735).
1525
0074aef2
EZ
15262011-10-12 Eli Zaretskii <eliz@gnu.org>
1527
79beb178
EZ
1528 * bidi.c (bidi_level_of_next_char):
1529 * xdisp.c (get_visually_first_element): Remove old incorrect
1530 comments regarding the Unicode Line Separator character.
1531
0074aef2
EZ
1532 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1533
6e4b3fbe
DA
15342011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1535
1536 * alloc.c (Fgc_status): Do not access beyond zombies array
1537 boundary if nzombies > MAX_ZOMBIES.
1538 * alloc.c (dump_zombies): Add missing format specifier.
1539
0324f3af
PE
15402011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1541
b5525cac
PE
1542 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1543 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1544
0324f3af
PE
1545 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1546 Some packages use them to denote characters with modifiers.
1547
e9b5f888
AS
15482011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1549
1550 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1551 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1552 matching a pp-number. Rename parameter var to var1.
1553
127827c0
SM
15542011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1555
1556 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1557
c8fd3bd0
GM
15582011-10-08 Glenn Morris <rgm@gnu.org>
1559
1560 * callint.c (Fcall_interactively): Give a more explicit error for the
1561 'c' case with a non-character input. (Bug#8479)
1562
352ec8ff
EZ
15632011-10-08 Eli Zaretskii <eliz@gnu.org>
1564
03669ccb
EZ
1565 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1566 lines.
7061c986
EZ
1567 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1568 lines that are hscrolled on the left.
03669ccb 1569
352ec8ff
EZ
1570 * dispnew.c (buffer_posn_from_coords): Account for a possible
1571 presence of header-line. (Bug#4426)
1572
a66cfb1c
SM
15732011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1574
6b02f655
SM
1575 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1576 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1577
7c5ee88e
PE
15782011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1579
1580 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1581 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1582 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1583 this makes Emacs dump core during garbage collection on rare
1584 occasions. sizeof is obviously inferior to offsetof here, so
1585 stick with offsetof.
1586 (GC_POINTER_ALIGNMENT): New macro.
1587 (mark_memory): Omit 3rd (offset) arg; caller changed.
1588 Don't assume EMACS_INT alignment is the same as pointer alignment.
1589
df1bbe5b
SM
15902011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1591
1592 * keyboard.c (read_key_sequence_remapped): New var.
1593 (read_key_sequence): Compute remapping in the right buffer.
1594 (command_loop_1): Use read_key_sequence's remapping directly.
1595
51553db6
SM
15962011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1597
32c1fffd
SM
1598 * dired.c (file_name_completion): Don't expand file name.
1599 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1600 before checking file name handler.
1601
51553db6
SM
1602 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1603 they've been requested explicitly (bug#9591).
1604
b6bd1599 16052011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1606
1607 * keymap.c (Fsingle_key_description): Use make_specified_string
1608 instead of build_string to build string from push_key_description.
1609 (Bug#5193)
1610
f701dc2a
PE
16112011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1612
4222c55d
PE
1613 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1614 This fixes a Y2038 bug on 64-bit hosts.
1615 * buffer.c (reset_buffer):
1616 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1617 (Fclear_buffer_auto_save_failure):
1618 Use 0, not -1, to represent an unset failure time, since time_t
1619 might not be signed.
1620
f701dc2a
PE
1621 Remove dependency on glibc malloc internals.
1622 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1623 Move back here from lisp.h, but with their new implementations.
1624 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1625 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1626 * charset.c (charset_table_init): New static var.
1627 (syms_of_charset): Use it instead of xmalloc. This removes a
1628 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1629 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1630 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1631 Move back to alloc.c.
1632 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1633 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1634
9ceebf39
JD
16352011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1636
1637 * nsterm.m (windowDidResize): Call x_set_window_size only when
1638 ns_in_resize is true. Otherwise set pixelwidth/height and
1639 call change_frame_size (Bug#9628).
1640
cb993c58
PE
16412011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1642
3930c88b
PE
1643 Port --enable-checking=all to Fedora 14 x86-64.
1644 * charset.c (syms_of_charset): Also account for glibc malloc's
1645 internal overhead when calculating the initial malloc maximum.
1646
cb993c58
PE
1647 Port --enable-checking=all to Fedora 14 x86.
1648 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1649 Move to lisp.h.
1650 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1651 (overrun_check_realloc, overrun_check_free):
1652 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1653 That way, xmalloc returns a properly-aligned pointer even if
1654 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1655 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1656 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1657 into account when calculating the initial malloc maximum.
1658 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1659 Move here from alloc.c, so that charset.c can use it too.
1660 Properly align; the old code wasn't right for common 32-bit hosts
1661 when configured with --enable-checking=all.
1662 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1663 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1664
31bed486
EZ
16652011-09-29 Eli Zaretskii <eliz@gnu.org>
1666
04c70788 1667 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1668 use EDOM.
1669
fbcaa2f3
EZ
16702011-09-28 Eli Zaretskii <eliz@gnu.org>
1671
1672 * xdisp.c (compute_display_string_end): If there's no display
1673 string at CHARPOS, return -1.
1674
1675 * bidi.c (bidi_fetch_char): When compute_display_string_end
1676 returns a negative value, treat the character as a normal
1677 character not covered by a display string. (Bug#9624)
1678
a239d4e9
JB
16792011-09-28 Juanma Barranquero <lekktu@gmail.com>
1680
1681 * lread.c (Fread_from_string): Fix typo in docstring.
1682
88652fd5
EZ
16832011-09-27 Eli Zaretskii <eliz@gnu.org>
1684
1685 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1686 newline, reseat the iterator instead of bidi-iterating there one
1687 character at a time. (Bug#9610)
32c1fffd
SM
1688 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1689 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1690
ed497dd4
AS
16912011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1692
1693 * lread.c (readevalloop): Use correct code for NBSP.
1694 (read1): Likewise. (Bug#9608)
1695
b2bf61aa
MA
16962011-09-25 Michael Albinus <michael.albinus@gmx.de>
1697
1698 * dbusbind.c (Fdbus_register_signal): When service is not
1699 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1700
32bbb17c
GM
17012011-09-25 Glenn Morris <rgm@gnu.org>
1702
1703 * buffer.c (truncate-lines): Doc fix.
1704
94e0933e
CY
17052011-09-24 Chong Yidong <cyd@stupidchicken.com>
1706
1707 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1708 (Fset_window_next_buffers): Doc fix.
1709
cddde921
GM
17102011-09-24 Glenn Morris <rgm@gnu.org>
1711
1712 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1713
1260aef1
PE
17142011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1715
25b4bfa0
PE
1716 Fix minor problems found by static checking.
1717 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1718 * indent.c (Fvertical_motion): Fix == vs = typo.
1719
e3cbd34b
EZ
17202011-09-24 Eli Zaretskii <eliz@gnu.org>
1721
a66cfb1c
SM
1722 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1723 Default value is now t. Doc fix.
6bf7006f 1724
e3cbd34b 1725 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1726 logic when moving up, not only when moving down. Fix the
e3cbd34b 1727 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1728 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1729
1730 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1731 CHARPOS is covered by a display string which includes newlines.
1732 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1733 is covered by a display string with embedded newlines.
1734
a3de0cbd
MA
17352011-09-24 Michael Albinus <michael.albinus@gmx.de>
1736
1737 * dbusbind.c (Fdbus_register_signal): Add match rule to
1738 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1739 (Fdbus_register_method, Vdbus_registered_objects_table):
1740 Fix docstring.
a3de0cbd 1741
b260039d
JM
17422011-09-24 Jim Meyering <meyering@redhat.com>
1743
32c1fffd 1744 do not ignore write error for any output size
b260039d
JM
1745 The previous change was incomplete.
1746 While it makes emacs --batch detect the vast majority of stdout
1747 write failures, errors were still ignored whenever the output size is
1748 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1749 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1750 && echo FAIL: ignored write error
1751 FAIL: ignored write error
1752 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1753 && echo FAIL: ignored write error
1754 FAIL: ignored write error
1755 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1756
8eca8a7c
AS
17572011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1758
1759 * emacs.c (Fkill_emacs): In noninteractive mode exit
1760 non-successfully if a write error occurred on stdout. (Bug#9574)
1761
3341db62
EZ
17622011-09-21 Eli Zaretskii <eliz@gnu.org>
1763
1764 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1765 the xassert test.
1766
1767 * dispextern.h (struct it): Update the comment documenting what
1768 can it->OBJECT be.
1769
8c203dbf
EZ
17702011-09-20 Eli Zaretskii <eliz@gnu.org>
1771
1772 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1773 a display string, extend search for cursor position to end of row.
1774 (find_row_edges): If the row ends in a newline from a display
1775 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1776 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1777 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1778 non-empty line. Fixes confusing cursor motion with arrow keys at
1779 the beginning of a line that starts with whitespace.
8c203dbf 1780
a4824228
LMI
17812011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1782
1783 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1784 (bug#9493).
1785
33ed493b
CY
17862011-09-18 Chong Yidong <cyd@stupidchicken.com>
1787
1788 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1789 boolean (Bug#9154).
1790
56cd55c8
EZ
17912011-09-18 Eli Zaretskii <eliz@gnu.org>
1792
1793 * xdisp.c (display_line): Record maximum and minimum buffer
1794 positions even if no glyphs were produced (e.g., by a zero-width
1795 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1796 buffer positions that will be removed from the glyph row because
1797 they don't fit.
c02dcedf
EZ
1798 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1799 column is beyond frame width: don't subtract 1 "pixel" when
1800 computing width of the stretch.
3e62b7e0
EZ
1801 (reseat_at_next_visible_line_start): Undo the change made on
1802 2011-09-17 that saved paragraph information and restored it after
1803 the call to `reseat'. (Bug#9545)
56cd55c8 1804
5ed99d36 18052011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1806
1807 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1808 and turn window cursor on if cleared (Bug#9415).
1809
5ed99d36 18102011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1811
1812 * search.c (boyer_moore): Take unibyte characters from pattern
1813 literally. (Bug#9458)
1814
9bade7b2
EZ
18152011-09-18 Eli Zaretskii <eliz@gnu.org>
1816
1817 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1818
e5e9d610
PE
18192011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1820
87e4427a
PE
1821 Fix minor problem found by static checking.
1822 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1823 initialized, to pacify gcc -Wuninitialized.
1824
e5e9d610
PE
1825 * fileio.c: Report proper errno when syscall falls.
1826 (Finsert_file_contents): Save and restore errno,
1827 so that report_file_error outputs the correct diagnostic.
1828 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1829
a1674f0b
EZ
18302011-09-18 Eli Zaretskii <eliz@gnu.org>
1831
1832 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1833
fbfb6dd4
EZ
18342011-09-17 Eli Zaretskii <eliz@gnu.org>
1835
1836 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1837 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1838
bb187662
EZ
18392011-09-17 Eli Zaretskii <eliz@gnu.org>
1840
1137e8b8 1841 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1842 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1843
1844 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1845 (bidi_find_paragraph_start): Search back for paragraph beginning
1846 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1847 (bidi_move_to_visually_next): Only trigger paragraph-related
1848 computations when the last character is a newline or at EOB, not
1849 just any NEUTRAL_B. (Bug#9470)
1850
bb187662
EZ
1851 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1852 truncated lines if point is covered by a display string. (Bug#9524)
1853
2e621251
PE
18542011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1855
1856 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1857 (cons_to_x_long): New function.
1858 (lisp_data_to_selection_data): Use it. Correct the test for
1859 short-versus-long data; it was negated. Break out of vector
1860 loop, for efficiency, when a long datum is discovered.
1861
91a15bc6
SM
18622011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1863
1864 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1865
b41c3a35
EZ
18662011-09-16 Eli Zaretskii <eliz@gnu.org>
1867
1868 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1869 GCC PR/17406) by declaring this function with external scope.
1870
7812ba2d
PE
18712011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1872
1873 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1874 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1875
cf7edc2a
AS
18762011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1877
1878 * editfns.c (Fformat): Correctly handle text properties on "%%".
1879
bd01620e
EZ
18802011-09-15 Eli Zaretskii <eliz@gnu.org>
1881
1882 * xterm.c (x_draw_composite_glyph_string_foreground):
1883 * w32term.c (x_draw_composite_glyph_string_foreground):
1884 * term.c (encode_terminal_code):
1885 * composite.c (composition_update_it, get_composition_id):
1886 * xdisp.c (get_next_display_element)
1887 (fill_composite_glyph_string): Add comments about special meaning
1888 of TAB characters in a composition.
1889
a02719a3
PE
18902011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1891
1892 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1893 This occurs when processing a multibyte format.
1894 Problem reported by Wolfgang Jenker.
a02719a3 1895
72589a3c
JB
18962011-09-15 Johan Bockgård <bojohan@gnu.org>
1897
1898 * xdisp.c (try_cursor_movement): Only check for exact match if
1899 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1900
1c14176c
PE
19012011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1902
1903 Remove unused external symbols.
1904 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1905 * xdisp.c (calc_pixel_width_or_height): Now static.
1906 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1907 * indent.c (check_display_width):
1908 * w32term.c: Fix comment to match code.
1909 * xterm.c, xterm.h (x_catching_errors): Remove.
1910
d2eea5b5
PE
19112011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1912
1913 * xselect.c: Use signed conversions more consistently (Bug#9498).
1914 (selection_data_to_lisp_data): Assume incoming selection data are
1915 signed integers, not unsigned. This is to be consistent with
1916 outgoing selection data, which was modified to use signed integers
1917 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1918 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1919 expects long, not unsigned long.
1920
46888499
EZ
19212011-09-14 Eli Zaretskii <eliz@gnu.org>
1922
1923 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1924 computation of loop end. Reported by Johan Bockgård
1925 <bojohan@gnu.org>.
1926
ef8ef9fb
CY
19272011-09-13 Chong Yidong <cyd@stupidchicken.com>
1928
1929 * frame.c (Fother_visible_frames_p): Function deleted.
1930
fa819fed
EZ
19312011-09-12 Eli Zaretskii <eliz@gnu.org>
1932
1933 * indent.c (compute_motion): Process display vector front to back
1934 rather than the other way around. (Bug#2496)
1935
2ba8e008
SM
19362011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1937
1938 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1939
20f53c69
CY
19402011-09-11 Chong Yidong <cyd@stupidchicken.com>
1941
1942 * minibuf.c (Fread_from_minibuffer): Doc fix.
1943
d562d7a4
EZ
19442011-09-11 Eli Zaretskii <eliz@gnu.org>
1945
1946 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1947 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1948
1c4d7f3d
LMI
19492011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1950
1951 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1952 value for non-existent files.
1953
b885bf36
EZ
19542011-09-11 Eli Zaretskii <eliz@gnu.org>
1955
1956 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1957 set its "size" to -1. This will set the modtime_size field of
1958 the corresponding buffer to -1, which is what
1959 verify-visited-file-modtime expects for files that do not exist.
1960 (Bug#9139)
1961
6612f0bf
PE
19622011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1963
1964 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1965 here ...
1966 * lisp.h: ... from here. push_key_description is no longer
1967 defined in keyboard.c, so its declaration should not be in
1968 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1969 logically belongs with push_key_description.
1970
dfb3f755
PE
19712011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1972
1973 * buffer.h: Include <sys/types.h> instead of <time.h>.
1974 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1975 Problem reported by Herbert J. Skuhra.
1976
3134906c
LMI
19772011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1978
1979 * xml.c (parse_region): Make the parsing work for
1980 non-comment-starting XML files again (bug#9144).
1981
8d903f4e
AS
19822011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1983
1984 * image.c (gif_load): Fix calculation of bottom and right corner.
1985 (Bug#9468)
1986
80ad64f4
EZ
19872011-09-10 Eli Zaretskii <eliz@gnu.org>
1988
1989 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1990 redisplay in small windows.
1991
208a048d
EZ
19922011-09-09 Eli Zaretskii <eliz@gnu.org>
1993
1994 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1995
9b1c252e
MR
19962011-09-08 Martin Rudalics <rudalics@gmx.at>
1997
1998 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1999 Operate on live windows only.
2000
2949f33b
JB
20012011-09-08 Juanma Barranquero <lekktu@gmail.com>
2002
2003 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2004
e08dcafd
EZ
20052011-09-07 Eli Zaretskii <eliz@gnu.org>
2006
2007 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2008 only under bidi iteration.
2009
115b96bd
JD
20102011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2011
2012 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2013
c8199d0f
PE
20142011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2015
2016 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2017 Without this fix, the command to link temacs failed due to an
2018 undefined symbol __builtin_isnan. This is because
2019 /usr/include/iso/math_c99.h #defines isnan(x) to
2020 __builtin_isnan(x), but the bundled gcc, which identifies itself
2021 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2022 a __builtin_isnan.
2023 * floatfns.c (isnan): #undef, and then #define to a clone of
2024 what's in data.c.
2025 (Fisnan): Always define, since it's always available now.
2026 (syms_of_floatfns): Always define isnan at the Lisp level.
2027
e39b275c 20282011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2029
2030 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2031
b2db44d9 20322011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2033
f4af5137 2034 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2035 The previous code assumed that file offsets (off_t values) fit in
2036 EMACS_INT variables, which is not true on typical 32-bit hosts.
2037 The code messed up by falsely reporting buffer overflow in cases
2038 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2039 when "big" contains more than 2**29 bytes, even though this
2040 inserts just one byte and does not overflow the buffer.
2041 (Finsert_file_contents): Store file offsets as off_t
2042 values, not as EMACS_INT values. Check for overflow when
2043 converting between EMACS_INT and off_t. When checking for
2044 buffer overflow or for overlap, take the offsets into account.
2045 Don't use EMACS_INT for small values where int suffices.
2046 When checking for overlap, fix a typo: ZV was used where
2047 ZV_BYTE was intended.
2048 (Fwrite_region): Don't assume off_t fits into 'long'.
2049 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2050
ecfc0a49
MA
20512011-09-05 Michael Albinus <michael.albinus@gmx.de>
2052
2053 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2054
6511acf2 20552011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2056
0999621a 2057 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2058
2059 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2060 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2061 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2062 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2063 (modify_event_symbol): Do not assume that the length of
2064 name_alist_or_stem is safe to alloca and fits in int.
2065 (Fexecute_extended_command): Likewise for function name and binding.
2066 (Frecursion_depth): Wrap around reliably on integer overflow.
2067 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2068 since some callers pass EMACS_INT values.
2069 (Fsingle_key_description): Don't crash if symbol name contains more
2070 than MAX_ALLOCA bytes.
2071 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2072 (get_minibuffer): Arg is now EMACS_INT, not int.
2073 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2074 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2075 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2076
2be7d702
PE
2077 * dbusbind.c (signature_cat): New function.
2078 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2079 Do not overrun buffer; instead, report string overflow.
2080
9d1df220
PE
2081 * dispnew.c (add_window_display_history): Don't overrun buffer.
2082 Truncate instead; this is OK since it's just a log.
2083
33ef5c64
PE
2084 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2085 even if the time zone offset is outlandishly large.
2086 Don't mishandle offset == INT_MIN.
2087
66c6fdd5
PE
2088 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2089 when creating daemon; the previous buffer-overflow check was incorrect.
2090
d749b01b
PE
2091 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2092 which has the guts of the old verror function.
2093
b5cd1905
PE
2094 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2095 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2096
6e1a67fb
PE
2097 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2098 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2099 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2100 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2101 length of string rather than counting it via multiple sprintfs;
2102 that's simpler and more reliable.
c21721cc
PE
2103 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2104 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2105 sprintf, in case result does not fit in int.
2106
c57b67fc
PE
2107 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2108 (fontset_from_font): Print it.
2109
8a401434
PE
2110 * frame.c (tty_frame_count): Now printmax_t, not int.
2111 (make_terminal_frame, set_term_frame_name): Print it.
2112 (x_report_frame_params): In X, window IDs are unsigned long,
2113 not signed long, so print them as unsigned.
2114 (validate_x_resource_name): Check for implausibly long names,
2115 and don't assume name length fits in 'int'.
2116 (x_get_resource_string): Don't blindly alloca invocation name;
2117 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2118 not fit in int.
2119
6e1a67fb
PE
2120 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2121 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2122 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2123
0df02bf3
PE
2124 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2125 Use esprintf, not sprintf, in case result does not fit in int.
2126
48e30793
PE
2127 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2128 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2129 it as a large positive number.
2130 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2131 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2132
a66ff6d8
PE
2133 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2134 in case result does not fit in int.
2135
aca216ff
PE
2136 * print.c (float_to_string): Detect width overflow more reliably.
2137 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2138 buffer overrun. Don't assume list length fits in 'int'. Treat
2139 print length of 0 as 0, not as infinity; to be consistent with other
2140 uses of print length in this function. Don't overflow print length
2141 index. Don't assume hash table size fits in 'long', or that
2142 vectorlike size fits in 'unsigned long'.
2143
31c286f7
PE
2144 * process.c (make_process): Use printmax_t, not int, to format
2145 process-name gensyms.
2146
55e5faa1
PE
2147 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2148
80f2e268
PE
2149 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2150 to avoid potential buffer overrun.
2151
670741ab
PE
2152 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2153 if X resource line is longer than 512 bytes.
2154
b7163a50
PE
2155 * xfns.c (x_window): Make sprintf buffer a bit bigger
2156 to avoid potential buffer overrun.
2157
ae58ff1f
PE
2158 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2159
c43c8a6a
PE
2160 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2161
3f8236f4
PE
21622011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2163
53e9fe90 2164 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2165 Without these, Emacs silently mishandles large integers sometimes.
2166 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2167 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2168
6511acf2
PE
2169 * xdisp.c (try_window_id): Check Emacs fixnum range before
2170 converting to 'int'.
806add1d 2171
6511acf2 2172 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2173 Check that an Emacs fixnum is in range before assigning it to 'int'.
2174 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2175 values converted from Emacs fixnums.
2176 (Frecenter): Don't wrap around a line count if it is out of 'int'
2177 range; instead, treat it as an extreme value.
2178 (Fset_window_configuration, compare_window_configurations):
2179 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2180
6511acf2
PE
2181 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2182 that can exceed INT_MAX. Check that EMACS_INT value is in range
2183 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2184 (match_limit): Don't assume that a fixnum can fit in 'int'.
2185
6511acf2 2186 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2187 exceed INT_MAX.
2188
6511acf2 2189 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2190 (Fvertical_motion): Don't wrap around LINES values that don't fit
2191 in 'int'. Instead, treat them as extreme values. This is good
2192 enough for windows, which can't have more than INT_MAX lines anyway.
2193
fcb901a7
LMI
21942011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2195
0f2f6b6d
LMI
2196 * Require libxml/parser.h to avoid compilation warning.
2197
fcb901a7
LMI
2198 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2199
2200 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2201 since this reportedly can destroy thread storage.
2202
6e20a0d4
CY
22032011-08-30 Chong Yidong <cyd@stupidchicken.com>
2204
2205 * syntax.c (find_defun_start): Update all cache variables if
2206 exiting early (Bug#9401).
2207
148ae00e
EZ
22082011-08-30 Eli Zaretskii <eliz@gnu.org>
2209
f6cfbd8f
EZ
2210 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2211
148ae00e
EZ
2212 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2213 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2214 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2215
2216 * term.c (tty_append_glyph): New function.
2217 (produce_stretch_glyph): Static function and its prototype deleted.
2218
a66cfb1c
SM
2219 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2220 Add prototypes.
148ae00e 2221
c4a07a4c
PE
22222011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2223
2224 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2225 when checking :margin (Bug#9390).
2226 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2227 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2228 so that the name doesn't mislead. All uses changed.
2229
6bc8cd65
JB
22302011-08-28 Johan Bockgård <bojohan@gnu.org>
2231
2232 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2233 set_tty_hooks.
2234
dca4927e
EZ
22352011-08-27 Eli Zaretskii <eliz@gnu.org>
2236
2237 * xdisp.c (move_it_to): Don't bail out early when reaching
2238 position beyond to_charpos, if we are scanning backwards.
2239 (move_it_vertically_backward): When DY == 0, make sure we get to
2240 the first character in the line after the newline.
2241
f2cad773
PE
22422011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2243
2244 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2245 (ccl_driver): Do not generate an out-of-range pointer.
2246 (Fccl_execute_on_string): Remove unnecessary check for
2247 integer overflow, noted by Stefan Monnier in
2248 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2249 Remove a FIXME that didn't need fixing.
2250 Simplify the newly-introduced buffer reallocation code.
2251
0cae2cdb
JB
22522011-08-27 Juanma Barranquero <lekktu@gmail.com>
2253
2254 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2255
5fc295a4 22562011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2257
70c60eb2 2258 Integer and memory overflow issues (Bug#9196).
726e0ab1 2259
d31850da
PE
2260 * doc.c (get_doc_string): Rework so that
2261 get_doc_string_buffer_size is the actual buffer size, rather than
2262 being 1 less than the actual buffer size; this makes xpalloc more
2263 convenient.
2264
a69fbedb
PE
2265 * image.c (x_allocate_bitmap_record, cache_image):
2266 * xselect.c (Fx_register_dnd_atom):
2267 Simplify previous changes by using xpalloc.
2268
fe5c5d37
PE
2269 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2270 since either will do and ptrdiff_t is convenient with xpalloc.
2271
0065d054
PE
2272 * charset.c (charset_table_size)
2273 (struct charset_sort_data.priority): Now ptrdiff_t.
2274 (charset_compare): Don't overflow if priorities differ greatly.
2275 (Fsort_charsets): Don't assume list length fits in int.
2276 Check for size-calculation overflow when allocating sort data.
2277 (syms_of_charset): Allocate an initial charset table that is
2278 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2279
2280 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2281
2282 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2283 The actual value is always <= INT_MAX, and leaving it unsigned made
2284 overflow checking harder.
2285
2286 * dispextern.h (struct glyph_matrix.rows_allocated)
2287 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2288 with xpalloc. The values are still always <= INT_MAX.
2289
2290 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2291
2292 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2293 (SAFE_NALLOCA): New macro.
2294
2295 * region-cache.c (struct boundary.pos, find_cache_boundary)
2296 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2297 (set_cache_region, invalidate_region_cache)
2298 (revalidate_region_cache, know_region_cache, region_cache_forward)
2299 (region_cache_backward, pp_cache):
2300 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2301 so that ptrdiff_t * can be passed to xpalloc.
2302 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2303 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2304 (pp_cache): Don't assume cache_len fits in int.
2305 * region-cache.h: Adjust extern decls to match.
2306
2307 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2308 EMACS_INT, since either will do, for xpalloc.
2309
2310 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2311 (xnmalloc, xnrealloc, xpalloc): New functions.
2312
726e0ab1
PE
2313 * bidi.c (bidi_shelve_header_size): New constant.
2314 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2315 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2316
51f30bc5 2317 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2318 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2319 (overlay_strings):
2320 Don't update size of array until after memory allocation succeeds,
2321 because xmalloc/xrealloc may not return.
0065d054
PE
2322 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2323 now that we have proper integer overflow checking.
2324 (record_overlay_string, overlay_strings): Catch overflows when
2325 calculating size of overlay_str_buf.
726e0ab1 2326
0065d054
PE
2327 * callproc.c (Fcall_process): Check for size overflow when
2328 calculating size of args2.
2329 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2330 Normally we prefer signed values, but sticking with ptrdiff_t would
2331 require adding more-complicated checks.
726e0ab1
PE
2332
2333 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2334 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2335 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2336 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2337
2338 * character.c (Fstring): Check for size-calculation overflow.
2339
2340 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2341 unnecessary integer overflow. Check for size overflow.
2342 (encode_coding_object): Don't update size until xmalloc succeeds.
2343
2344 * composite.c (get_composition_id): Check for overflow in glyph
2345 length calculations.
2346
2347 Integer and memory overflow fixes for display code.
2348 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2349 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2350 (scrolling_window): Check for overflow in size calculations.
2351 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2352 Don't assume glyph table len fits in int.
2353 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2354 (row_table_size): Now ptrdiff_t, not int.
2355 (scrolling_window): Avoid overflow in size calculations.
2356 Don't update size until allocation succeeds.
2357 * fns.c (concat): Check for overflow in size calculations.
2358 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2359 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2360 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2361
2362 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2363 (get_doc_string): Check for size calculation overflow.
2364 Don't update size until allocation succeeds.
2365 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2366 EMACS_INT, where ptrdiff_t will do.
2367 (Fsubstitute_command_keys): Check for string overflow.
2368
2369 * editfns.c (set_time_zone_rule): Don't assume environment length
2370 fits in int.
2371 (message_length): Now ptrdiff_t, not int.
2372 (Fmessage_box): Don't update size until allocation succeeds.
2373 Don't assume message length fits in int.
2374 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2375
0065d054
PE
2376 * emacs.c (main): Do not reallocate argv, since there is a null at
2377 the end that can be overwritten, and this way there's no need to
2378 worry about size-calculation overflow.
2379 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2380
2381 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2382 alloc succeeds.
2383 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2384
2385 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2386 (x_set_scroll_bar_width, x_figure_window_size):
2387 Check for integer overflow.
2388 (x_set_alpha): Do not assume XINT fits in int.
2389
2390 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2391 This is for the members text_lines, text_cols, total_lines, total_cols,
2392 where the system imposes an 'int' limit.
2393
2394 * fringe.c (Fdefine_fringe_bitmap):
2395 Don't update size until alloc works.
2396
2397 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2398 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2399
2400 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2401 Check for size-calculation overflow.
2402 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2403 do, as we prefer signed integers.
2404 (id_to_widget.max_size, id_to_widget.used)
2405 (xg_store_widget_in_map, xg_remove_widget_from_map)
2406 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2407 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2408 Use and return ptrdiff_t, not int.
2409 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2410 * gtkutil.h: Change prototypes to match the above.
2411
2412 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2413 are duplicate now that they've been promoted to lisp.h.
2414 (x_allocate_bitmap_record, x_alloc_image_color)
2415 (make_image_cache, cache_image, xpm_load):
2416 Don't update size until alloc is done.
2417 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2418 (x_detect_edges):
3256efce 2419 Check for size calculation overflow.
726e0ab1
PE
2420 (ct_colors_allocated_max): New constant.
2421 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2422 overflow.
3256efce 2423
726e0ab1
PE
2424 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2425 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2426 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2427 Use ptrdiff_t, not int, to count maps.
2428 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2429 calculations. Don't update size until allocation succeeds.
2430 Redo calculations to avoid overflow.
726e0ab1
PE
2431 * keyboard.h: Change prototypes to match the above.
2432
2433 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2434 to count maps.
2435 (current_minor_maps): Check for size calculation overflow.
2436 * keymap.h: Change prototypes to match the above.
2437
2438 * lread.c (read1, init_obarray): Don't update size until alloc done.
2439
2440 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2441 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2442
726e0ab1
PE
2443 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2444 Now ptrdiff_t, not int.
2445 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2446 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2447
2448 * process.c (Fnetwork_interface_list): Check for overflow
2449 in size calculation.
2450
2451 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2452
2453 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2454 overflow. Don't bother calling xmalloc when xrealloc will do.
2455
2456 * search.c (Freplace_match): Check for size calculation overflow.
2457 (Fset_match_data): Don't assume list lengths fit in 'int'.
2458
2459 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2460 for command line length. Do not attempt to address one before the
2461 beginning of an array, as that's not portable.
2462
2463 * term.c (max_frame_lines): Remove; unused.
2464 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2465 not int.
2466 (encode_terminal_code, calculate_costs): Check for size
2467 calculation overflow.
2468 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2469 table lengths and related sizes. Don't update size until alloc
2470 done. Redo calculations to avoid overflow.
2471 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2472
2473 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2474 subtracting pointers.
2475 (gobble_line): Check for overflow more carefully. Don't update size
2476 until alloc done.
2477
2478 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2479 Don't update size until alloc done.
2480 Redo size calculations to avoid overflow.
2481 Check for size calculation overflow.
0065d054 2482 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2483
2484 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2485 Use ptrdiff_t, not int, for sizes.
2486 (store_mode_line_noprop_char): Don't update size until alloc done.
2487
0065d054
PE
2488 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2489 Use ptrdiff_t, not int, for sizes.
2490 (Finternal_make_lisp_face, cache_face):
2491 Check for size calculation overflow.
2492 (cache_face): Treat size calculation overflows as if they were
2493 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2494
2495 * xfns.c (x_encode_text, x_set_name_internal)
2496 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2497 sizes, since they can exceed INT_MAX in size. Check for size
2498 calculation overflow.
2499
0065d054
PE
2500 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2501 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2502 Don't update size until alloc done.
2503
0065d054 2504 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2505 as sprintf is limited to int lengths.
1d526e2f 2506
252c5ee1
PE
2507 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2508 (X_LONG_MIN): New macros.
864d7ce7
PE
2509 Use them to make the following changes clearer.
2510 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2511 This change doesn't affect the value now, but it may help remind
2512 future maintainers not to raise the value too much later.
2513 (SELECTION_QUANTUM): Remove, replacing with ...
2514 (selection_quantum): ... new function, which avoids overflow.
2515 All uses changed.
2516 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2517 assumption that selection length fits in 'int'.
2518 (x_reply_selection_request, x_handle_selection_request)
2519 (x_get_window_property, receive_incremental_selection)
2520 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2521 (lisp_data_to_selection_data, clean_local_selection_data):
2522 Use ptrdiff_t, not int, to record length of selection.
2523 (x_reply_selection_request, x_get_window_property)
2524 (receive_incremental_selection, x_property_data_to_lisp):
2525 Redo calculations to avoid overflow.
2526 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2527 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2528 something.
2529 (x_get_window_property, receive_incremental_selection)
2530 (lisp_data_to_selection_data, x_property_data_to_lisp):
2531 Check for size-calculation overflow.
2532 (x_get_window_property, receive_incremental_selection)
2533 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2534 Don't store size until memory allocation succeeds.
2535 (x_get_window_property): Plug memory leak on memory exhaustion.
2536 Don't double-block input; malloc is safe here. Don't assume 2**34
2537 - 4 fits in unsigned long. Add an xassert to check
2538 XGetWindowProperty overflow. Be more careful about overflow
2539 calculations, and distinguish size from memory overflow better.
2540 (receive_incremental_selection): When tracing, don't assume
2541 unsigned int is less than INT_MAX.
2542 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2543 harmful) conversions of unsigned short to int.
2544 (lisp_data_to_selection_data): Don't assume that integers
2545 in the range -65535 through -1 fit in an X unsigned short.
2546 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2547 result parameters unless successful. Rely on cons_to_unsigned
2548 to report problems with elements; the old code wasn't right anyway.
2549 (x_check_property_data): Check for int overflow; we cannot use
2550 a wider type due to X limits.
2551 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2552
726e0ab1 2553 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2554
0065d054
PE
2555 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2556 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2557 (x_color_cells): Don't store size until memory allocation succeeds.
2558 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2559 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2560 (x_term_init): Don't assume length fits in int (sprintf is limited
2561 to int size).
bc18e09d 2562
ebfa62c0
PE
2563 Use ptrdiff_t for composition IDs.
2564 * character.c (lisp_string_width):
2565 * composite.c (composition_table_size, n_compositions)
2566 (get_composition_id, composition_gstring_from_id):
2567 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2568 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2569 * window.c (Frecenter):
2570 Use ptrdiff_t, not int, for composition IDs.
2571 * composite.c (get_composition_id): Check for integer overflow.
2572 * composite.h: Adjust prototypes to match the above changes.
2573
d3411f89
PE
2574 Use ptrdiff_t for hash table indexes.
2575 * category.c (hash_get_category_set):
2576 * ccl.c (ccl_driver):
2577 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2578 * coding.c (coding_system_charset_list, detect_coding_system):
2579 * coding.h (struct coding_system.id):
2580 * composite.c (get_composition_id, gstring_lookup_cache):
2581 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2582 * image.c (xpm_get_color_table_h):
2583 * lisp.h (hash_lookup, hash_put):
2584 * minibuf.c (Ftest_completion):
2585 Use ptrdiff_t for hash table indexes, not int (which is too
2586 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2587 32-bit --with-wide-int hosts).
2588
e097a6fa
PE
2589 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2590 Add a FIXME comment about memory leaks.
2591 (syms_of_charset): Don't assume xmalloc returns.
2592
5637687f
PE
2593 Don't assume that stated character widths fit in int.
2594 * character.c (Fchar_width, c_string_width, lisp_string_width):
2595 * character.h (CHAR_WIDTH):
2596 * indent.c (MULTIBYTE_BYTES_WIDTH):
2597 Use sanitize_char_width to avoid undefined and/or bad behavior
2598 with outlandish widths.
a66cfb1c 2599 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2600 now that we have two such functions. All uses changed.
2601 (sanitize_char_width): New inline function.
2602
a2271ba2
PE
2603 Don't assume that tab-width fits in int.
2604 * character.h (sanitize_width): New inline function.
2605 (SANE_TAB_WIDTH): New macro.
2606 (ASCII_CHAR_WIDTH): Use it.
2607 * indent.c (sane_tab_width): Remove. All uses replaced by
2608 SANE_TAB_WIDTH (current_buffer).
2609 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2610
18c52557
PE
2611 * fileio.c: Integer overflow issues with file modes.
2612 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2613
caeeedc1
PE
2614 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2615 Remove unreachable code.
2616 (read_hex, load_charset_map_from_file): Check for integer overflow.
2617
6df6ae42 2618 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2619 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2620 (x_send_scroll_bar_event): Likewise. Check that the size does not
2621 exceed limits imposed by XClientMessageEvent, as well as the usual
2622 ptrdiff_t and size_t limits.
2623
b13995db
PE
2624 * keyboard.c: Overflow, signedness and related fixes.
2625 (make_lispy_movement): Use same integer type in forward decl
2626 that is used in the definition.
2627 (read_key_sequence, keyremap_step):
2628 Change bufsize argument back to int, undoing my 2011-03-30 change.
2629 We prefer signed types, and int is wide enough here.
2630 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2631 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2632 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2633 length, not size_t. Use ptrdiff_t for index, not int.
2634 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2635 possibility of integer overflow.
2636
13464394
PE
2637 Overflow, signedness and related fixes for images.
2638
2639 * dispextern.h (struct it.stack[0].u.image.image_id)
2640 (struct_it.image_id, struct image.id, struct image_cache.size)
2641 (struct image_cache.used, struct image_cache.ref_count):
2642 * gtkutil.c (update_frame_tool_bar):
2643 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2644 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2645 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2646 * nsmenu.m (update_frame_tool_bar):
2647 * xdisp.c (calc_pixel_width_or_height):
2648 * xfns.c (image_cache_refcount):
2649 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2650 on typical 64-bit hosts.
2651
2652 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2653 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2654 Omit unnecessary casts to int.
2655 (parse_image_spec): Check that integers fall into 'int' range
2656 when the callers expect that.
2657 (image_ascent): Redo ascent calculation to avoid int overflow.
2658 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2659 (lookup_image): Remove unnecessary tests.
2660 (xbm_image_p): Locals are now of int, not EMACS_INT,
2661 since parse_image_check makes sure they fit into int.
2662 (png_load, gif_load, svg_load_image):
2663 Prefer int to unsigned where either will do.
2664 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2665 old tiff_error_handler and tiff_warning_handler.
2666 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2667 stack buffer overflows. It uses only the features of vsnprintf
2668 that are common to both POSIX and native Microsoft.
2669 (tiff_error_handler, tiff_warning_handler): Use it.
2670 (tiff_load, gif_load, imagemagick_load_image):
2671 Don't assume :index value fits in 'int'.
2672 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2673 (imagemagick_load_image): Check that crop parameters fit into
2674 the integer types that MagickCropImage accepts. Don't assume
2675 Vimagemagick_render_type has a nonnegative value. Don't assume
2676 size_t fits in 'long'.
2677 (gs_load): Use printmax_t to print the widest integers possible.
2678 Check for integer overflow when computing image height and width.
2679
c11821d4
EZ
26802011-08-26 Eli Zaretskii <eliz@gnu.org>
2681
2682 * xdisp.c (redisplay_window): Don't force window start if point
2683 will be invisible in the resulting window. (Bug#9324)
2684
0c95fcf7
EZ
26852011-08-25 Eli Zaretskii <eliz@gnu.org>
2686
2687 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2688 the display spec is of the form `(space ...)'.
2689 (handle_display_spec): Return the value returned by
2690 handle_single_display_spec, not just 1 or zero.
2691 (handle_single_display_spec): If the display spec is of the form
2692 `(space ...)', and specifies display in the text area, return 2
2693 rather than 1.
fee65a97 2694 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2695 accurately, and prefer exact match for point under bidi.
2696 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2697
2698 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2699 into disp_prop; all users changed.
2700
2701 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2702 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2703 for the text covered by the display property.
2704
e4ed06f1
CY
27052011-08-25 Chong Yidong <cyd@stupidchicken.com>
2706
2707 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2708 Change return value to nil.
2709 (Frecord_buffer): Delete unused function.
2710
f67cdd7f
EZ
27112011-08-24 Eli Zaretskii <eliz@gnu.org>
2712
5980d4c6
EZ
2713 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2714 buffers, return left-to-right.
8610fe8b
EZ
2715 (set_cursor_from_row): Consider candidate row a win if its glyph
2716 represents a newline and point is on that newline. Fixes cursor
2717 positioning on the newline at EOL of R2L text within L2R
2718 paragraph, and vice versa.
2719 (try_cursor_movement): Check continued rows, in addition to
2720 continuation rows. Fixes unwarranted scroll when point enters a
2721 continued line of R2L text within an L2R paragraph, or vice versa.
2722 (cursor_row_p): Consider the case of point being equal to
2723 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2724 from the end of a short line to the beginning of a continued line
2725 of R2L text within L2R paragraph.
2726 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2727 composed characters.
5980d4c6 2728
f67cdd7f
EZ
2729 * bidi.c (bidi_check_type): Use xassert.
2730 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2731 members.
2732
bca633fb
EZ
27332011-08-23 Eli Zaretskii <eliz@gnu.org>
2734
2735 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2736 a character.
2737
4a5885a7
CY
27382011-08-23 Chong Yidong <cyd@stupidchicken.com>
2739
2740 * nsfont.m (ns_otf_to_script): Fix typo.
2741
0902a04e
KH
27422011-08-22 Kenichi Handa <handa@m17n.org>
2743
2744 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2745 extra slot even if the purpose is char-code-property-table.
2746
1a2e6670
EZ
27472011-08-23 Eli Zaretskii <eliz@gnu.org>
2748
8ddde651
EZ
2749 * xdisp.c (redisplay_window): When computing centering_position,
2750 account for the height of the header line. (Bug#8874)
2751
425cc014
EZ
2752 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2753 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2754 candidate is selected by the mouse, and that candidate has a
2755 composed character under the mouse.
2756
1a2e6670
EZ
2757 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2758 coordinates reported by pos-visible-in-window-p for a composed
2759 character in column zero.
2760
8b76d6f8
SM
27612011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2762
2763 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2764
dac347dd
EZ
27652011-08-22 Eli Zaretskii <eliz@gnu.org>
2766
2767 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2768 consider it a hit if to_charpos is anywhere in the range of the
2769 composed buffer positions.
2770
e013fb34
CY
27712011-08-22 Chong Yidong <cyd@stupidchicken.com>
2772
2773 * image.c (gif_load): Don't assume that each subimage has the same
2774 dimensions as the base image. Handle disposal method that is
2775 "undefined" by the gif spec (Bug#9335).
2776
bd1ba3e8
CY
27772011-08-20 Chong Yidong <cyd@stupidchicken.com>
2778
2779 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2780 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2781
54a1215b
EZ
27822011-08-19 Eli Zaretskii <eliz@gnu.org>
2783
823564e5
EZ
2784 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2785 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2786 from an Org mode buffer to a Speedbar frame.
2787
54a1215b
EZ
2788 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2789 a composition, take its buffer position from IT->cmp_it.charpos.
2790 Fixes cursor positioning at the beginning of a line that begins
2791 with a composed character.
2792
9778ebcc
EZ
27932011-08-18 Eli Zaretskii <eliz@gnu.org>
2794
0be6ee06
EZ
2795 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2796 character bidirectional type, use STRONG_L instead. Fixes crashes
2797 in a buffer produced by `describe-categories'.
2798
9778ebcc
EZ
2799 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2800 members before the level stack, so they would be saved and
2801 restored when copying iterator state. Fixes incorrect reordering
2802 around TABs covered by display properties.
2803
156bffbe
AS
28042011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2805
6b02f655 2806 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2807
72ad093b
CY
28082011-08-17 Chong Yidong <cyd@stupidchicken.com>
2809
2810 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2811 (internal_condition_case_2, internal_condition_case_n):
2812 Remove unnecessary aborts (Bug#9081).
72ad093b 2813
35774242
EZ
28142011-08-17 Eli Zaretskii <eliz@gnu.org>
2815
2816 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2817 has no `load' handler, try opening the file locally. (Bug#9311)
2818
db76dd85
KB
28192011-08-16 Ken Brown <kbrown@cornell.edu>
2820
2821 * gmalloc.c: Expand comment.
2822
b215eee5
EZ
28232011-08-16 Eli Zaretskii <eliz@gnu.org>
2824
2825 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2826 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2827
a4579d33
KB
28282011-08-16 Ken Brown <kbrown@cornell.edu>
2829
2830 Fix memory allocation problems in Cygwin build (Bug#9273).
2831
2832 * unexcw.c ( __malloc_initialized): Declare external variable.
2833 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2834
8b76d6f8
SM
2835 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2836 New variables.
a4579d33
KB
2837 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2838 dumped emacs.
2839 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2840 in the static heap.
2841 [CYGWIN] (special_realloc): New function.
2842 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2843 requests to realloc storage in the static heap.
2844
3ebec551
PE
28452011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2846
2847 * bidi.c (bidi_initialize): Remove unused local.
2848
9fd8be00
EZ
28492011-08-15 Eli Zaretskii <eliz@gnu.org>
2850
6b02f655
SM
2851 * bidimirror.h:
2852 * biditype.h: Remove file.
2853 * makefile.w32-in ($(BLD)/bidi.$(O)):
2854 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2855
2856 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2857
2858 * chartab.c: Improve commentary for the uniprop_table API.
2859
32413314
EZ
2860 * bidi.c (bidi_paragraph_init): Support zero value of
2861 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2862 (bidi_initialize): Use uniprop_table instead of including
2863 biditype.h and bidimirror.h.
32413314 2864
9fd8be00
EZ
2865 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2866 coordinates of the iterator when restoring from ppos_it.
2867 (Bug#9296)
2868
5cf2b69b
KH
28692011-08-14 Kenichi Handa <handa@m17n.org>
2870
2871 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2872 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2873
daf17d00
EZ
28742011-08-14 Eli Zaretskii <eliz@gnu.org>
2875
2876 * xdisp.c (move_it_in_display_line_to): Don't invoke
2877 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2878 ppos_it. Fixes vertical cursor motion when line beginning is
2879 covered by an image. (Bug#9296)
2880
08e3161a
JD
28812011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2882
2883 * nsterm.h (ns_run_ascript): Declare.
2884 (NSAPP_DATA2_RUNASSCRIPT): Define.
2885
2886 * nsfns.m (as_script, as_result, as_status): New static variables.
2887 (ns_run_ascript): New function.
5e617bc2 2888 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2889 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2890 the event loop. Get status from as_status (Bug#7276).
2891
2892 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2893 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2894 the event loop (Bug#7276).
2895
a3720aa2
AS
28962011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2897
2898 * gnutls.c (QCgnutls_bootprop_priority)
2899 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2900 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2901 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2902 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2903 (QCgnutls_bootprop_verify_hostname_error)
2904 (QCgnutls_bootprop_callbacks_verify): Rename from
2905 Qgnutls_bootprop_..., all uses changed.
2906
2907 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2908 uses changed.
2909
0a0d27fb
PE
29102011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2911
19d5c50c
PE
2912 * xfaces.c (Qframe_set_background_mode): Now static.
2913 * dispextern.h (Qframe_set_background_mode): Remove decl.
2914
0a0d27fb
PE
2915 * process.c (Fnetwork_interface_info): Declare local only if needed.
2916
377538cb
JD
29172011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2918
2919 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2920 (Fnetwork_interface_list): Allocate in increments of bytes instead
2921 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2922 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2923 sockaddr.
2924 (struct ifflag_def): notrailers is smart on OSX.
2925 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2926 Get hardware address with getifaddrs if available.
2927
08fff70c
EZ
29282011-08-12 Eli Zaretskii <eliz@gnu.org>
2929
2930 * xdisp.c (iterate_out_of_display_property): xassert that
2931 IT->position is set to within IT->object's boundaries. Break from
2932 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2933 when IT->position is set up wrongly due to some bug.
2934 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2935 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2936 entry. Force push_it to save on the stack the current
2937 buffer/string position, to be restored by pop_it. Fix flags in
2938 the iterator structure wrt the object coming from a display
2939 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2940 properties. (Bug#9284)
2941
7be1c708 29422011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2943
7be1c708
CY
2944 * fontset.c (fontset_get_font_group): Add proper type checks.
2945 (Bug#9172)
aac0c6e3 2946
7be1c708 29472011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2948
7be1c708
CY
2949 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2950 and LC_VERSION_MIN_MACOSX.
2951 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2952 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2953
97bb72a6
EZ
29542011-08-08 Eli Zaretskii <eliz@gnu.org>
2955
2956 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2957 no-display-properties-and-no-overlays under bidi display.
2958 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2959 properties and overlays.
97bb72a6 2960
d5617611
CY
29612011-08-08 Chong Yidong <cyd@stupidchicken.com>
2962
37e11a63
CY
2963 * editfns.c (Fset_time_zone_rule): Document relationship with the
2964 setenv function.
2965
d5617611
CY
2966 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2967 the font entity extracted from the cache (Bug#8109).
2968
58872834
CY
29692011-08-07 Chong Yidong <cyd@stupidchicken.com>
2970
2971 * composite.c (autocmp_chars): Don't reset point. That is done by
2972 restore_point_unwind (Bug#5984).
2973
75bfc667
JL
29742011-08-07 Juri Linkov <juri@jurta.org>
2975
2976 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2977 to show the arg `TIME' instead of `TIMEVAL'.
2978
d1410150
EZ
29792011-08-06 Eli Zaretskii <eliz@gnu.org>
2980
2981 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2982 display property strides EOL and includes a newline, as in
2983 longlines-mode. (Bug#9254)
75b771e4
EZ
2984 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2985 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2986
2987 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2988 is non-zero, even if the data buffer is NULL. Fixes a crash in
2989 vertical-motion with longlines-mode. (Bug#9254)
2990
35928349
EZ
29912011-08-05 Eli Zaretskii <eliz@gnu.org>
2992
ec7cc85b
EZ
2993 * bidi.c <bidi_cache_total_alloc>: Now static.
2994 (bidi_initialize): Initialize bidi_cache_total_alloc.
2995
8b76d6f8 2996 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2997 cache. (Bug#9221)
2998
2999 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3000 amount allocated this far in `bidi_cache_total_alloc'.
3001 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3002 non-zero, only free the data buffer without restoring the cache
3003 contents. All callers changed.
3004
3005 * dispextern.h (bidi_unshelve_cache): Update prototype.
3006
3007 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3008 (move_it_in_display_line, move_it_to)
3009 (move_it_vertically_backward, move_it_by_lines): Replace the call
3010 to xfree to an equivalent call to bidi_unshelve_cache.
3011 (move_it_in_display_line_to): Fix logic of returning
412b6358 3012 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3013
e2e2423b
EZ
30142011-08-05 Eli Zaretskii <eliz@gnu.org>
3015
3016 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3017 came from a string character with a `cursor' property. (Bug#9229)
3018
ae9e757a
JD
30192011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3020
3021 * Makefile.in (LIB_PTHREAD): New variable.
3022 (LIBES): Add LIB_PTHREAD (Bug#9216).
3023
3024 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3025 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3026
213bd7f2
AS
30272011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3028
6b02f655 3029 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3030
99aaf75f
JD
30312011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3032
3033 * xterm.c (x_find_topmost_parent): New function.
3034 (x_set_frame_alpha): Find topmost parent window with
3035 x_find_topmost_parent and set the property there also (bug#9181).
3036 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3037
c74e9d86
PE
30382011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3039
3040 * callproc.c (Fcall_process): Avoid vfork clobbering
3041 the local vars buffer, coding_systems, current_dir.
3042
640c8776
SM
30432011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3044
3045 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3046
f26d0e4c
PE
30472011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3048
8a10d76c
PE
3049 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3050 so that it is not optimized away.
3051
f26d0e4c
PE
3052 * xdisp.c (compute_display_string_pos): Remove unused local.
3053
55439c61
EZ
30542011-08-02 Eli Zaretskii <eliz@gnu.org>
3055
3056 Fix slow cursor motion and scrolling in large buffers with
3057 selective display, like Org Mode buffers. (Bug#9218)
3058
3059 * dispextern.h (struct bidi_it): New member disp_prop_p.
3060
3061 * xdisp.c: Remove one-slot cache of display string positions.
3062 (compute_display_string_pos): Accept an additional argument
5e617bc2 3063 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3064 for a display string or property. If found, set DISP_PROP_P
3065 non-zero.
3066
3067 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3068 DISP_PROP_P, and pass it to compute_display_string_pos.
3069 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3070 non-zero. All callers of bidi_fetch_char changed.
3071
fb33fa43
SM
30722011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3073
3074 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3075
b099e063
DM
30762010-12-03 Don March <don@ohspite.net>
3077
3078 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3079 last character M-[char] is translated to ESC [char] (bug#7541).
3080
5cc7f7af
KH
30812011-08-02 Kenichi Handa <handa@m17n.org>
3082
d0fffa3f 3083 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3084
3085 * chartab.c (uniprop_table): Make it non-static.
3086
525d5e6e
EZ
30872011-08-01 Eli Zaretskii <eliz@gnu.org>
3088
3089 * xdisp.c (forward_to_next_line_start): Accept additional argument
3090 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3091 on the newline.
3092 (reseat_at_next_visible_line_start): Use the bidi iterator state
3093 returned by forward_to_next_line_start to restore the state of
3094 it->bidi_it after backing up to previous newline. (Bug#9212)
3095
31011111
AS
30962011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3097
3098 * regex.c (re_comp): Protoize.
3099 (re_exec): Fix return type.
3100 (regexec): Fix type of `ret'. (Bug#9203)
3101
476371c4
PE
31022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3103
e5d76069
PE
3104 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3105 This is needed if max-image-size is a floating-point number.
3106
9a79b20c
AS
31072011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3108
3109 * print.c (print_object): Print empty symbol as ##.
3110
3111 * lread.c (read1): Read ## as empty symbol.
3112
d8c2fa78
AA
31132011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3114
3115 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3116 setting frame foreground color (Bug#9175).
3117 (x_set_background_color): Likewise.
3118
ffe57a7a
AA
3119 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3120 contents (Bug#9176).
3121 (EmacsTooltip -init): Remove bezels and add shadows to
3122 tooltip windows.
3123
bf3492a5
AA
3124 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3125 or scroll bar (Bug#8470).
3126
d55e9c53
AA
3127 * nsfont.m (nsfont_open): Remove assignment to voffset and
3128 unnecessary vars hshink, expand, hd, full_height, min_height.
3129 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3130
3131 * nsterm.h (nsfont_info): Remove voffset field.
3132
d8c2fa78 31332011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3134
3135 Implement strike-through and overline on NextStep (Bug#8863).
3136
3137 * nsfont.m (nsfont_open): Use underline position provided by font,
3138 instead of hard-coded value of 2.
3139 (nsfont_draw): Call ns_draw_text_decoration instead.
3140
3141 * nsterm.h: Add declaration for ns_draw_text_decoration.
3142
3143 * nsterm.m (ns_draw_text_decoration): New function for drawing
3144 underline, overline, and strike-through.
3145 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3146 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3147 accommodate underlining, etc.
4843aac3 3148
4cc60b9b
EZ
31492011-07-28 Eli Zaretskii <eliz@gnu.org>
3150
bc7ece87
EZ
3151 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3152 default.
4cc60b9b 3153
476371c4
PE
31542011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3155
66606eea
PE
3156 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3157 Without this fix, if a signal arrives just after memory fills up,
3158 'malloc' might be invoked reentrantly.
3159
476371c4
PE
3160 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3161 In other words, assume that every image size is allowed, on non-X
3162 hosts. This assumption is probably wrong, but it lets Emacs compile.
3163
f3fcc40d
AS
31642011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3165
3166 * regex.c (re_iswctype): Convert return values to boolean.
3167
350c992f
EZ
31682011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3169
3170 * xdisp.c (compute_display_string_pos): Don't use cached display
3171 string position if the buffer had its restriction changed.
3172 (Bug#9184)
3173
5266b4bb
PE
31742011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3175
3176 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3177
2573a837 31782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3179
41f55ccd 3180 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3181
39e378da
PE
3182 * bidi.c: Integer size and overflow fixes.
3183 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3184 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3185 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3186 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3187 (bidi_find_other_level_edge):
3188 Use ptrdiff_t instead of EMACS_INT where either will do.
3189 This works better on 32-bit hosts configured --with-wide-int.
3190 (bidi_cache_ensure_space): Check for size-calculation overflow.
3191 Use % rather than repeated addition, for better worst-case speed.
3192 Don't set bidi_cache_size until after xrealloc returns, because it
3193 might not return.
3194 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3195 (bidi_cache_ensure_space): Also check that the bidi cache size
3196 does not exceed that of the largest Lisp string or buffer. See Eli
3197 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3198
5e927815
PE
3199 * alloc.c (__malloc_size_t): Remove.
3200 All uses replaced by size_t. See Andreas Schwab's note
3201 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3202
ca4aa935
PE
3203 * image.c: Improve checking for integer overflow.
3204 (check_image_size): Assume that f is nonnull, since
3205 it is always nonnull in practice. This is one less thing to
3206 worry about when checking for integer overflow later.
3207 (x_check_image_size): New function, which checks for integer
3208 overflow issues inside X.
3209 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3210 This removes the need for a memory_full check.
3211 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3212 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3213 (xbm_read_bitmap_data): Change locals back to 'int', since
3214 their values must fit in 'int'.
3215 (xpm_load_image, png_load, tiff_load):
3216 Invoke x_create_x_image_and_pixmap earlier,
3217 to avoid much needless work if the image is too large.
3218 (tiff_load): Treat overly large images as if
3219 x_create_x_image_and_pixmap failed, not as malloc failures.
3220 (gs_load): Use x_check_image_size.
3221
5f8f9cc2
PE
3222 * gtkutil.c: Omit integer casts.
3223 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3224 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3225
5adf60bc
PE
3226 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3227
c8907a93
PE
3228 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3229 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3230 would wrongly return t on a 64-bit host.
3231
e3c25c68
PE
3232 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3233 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3234 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3235 and therefore cause GCC to emit a bogus diagnostic in some cases.
3236
3f791afe
PE
3237 * image.c: Integer signedness and overflow and related fixes.
3238 This is not an exhaustive set of fixes, but it's time to
3239 record what I've got.
3240 (lookup_pixel_color, check_image_size): Remove redundant decls.
3241 (check_image_size): Don't assume that arbitrary EMACS_INT values
3242 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3243 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3244 (tiff_load, imagemagick_load_image):
3245 Check for overflow in size calculations.
3246 (x_create_x_image_and_pixmap): Remove unnecessary test for
3247 xmalloc returning NULL; that can't happen.
3248 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3249 (xpm_color_bucket): Use better integer hashing function.
3250 (xpm_cache_color): Don't possibly over-allocate memory.
3251 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3252 (gif_memory_source):
3253 Use ptrdiff_t, not int or size_t, to record sizes.
3254 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3255 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3256 either works, as we prefer signed integers.
3257 (tiff_read_from_memory, tiff_write_from_memory):
3258 Return tsize_t, not size_t, since that's what the TIFF API wants.
3259 (tiff_read_from_memory): Don't fail simply because the read would
3260 go past EOF; instead, return a short read.
3261 (tiff_load): Omit no-longer-needed casts.
3262 (Fimagemagick_types): Don't assume size fits into 'int'.
3263
3cc5a532
PE
3264 Improve hashing quality when configured --with-wide-int.
3265 * fns.c (hash_string): New function, taken from sxhash_string.
3266 Do not discard information about ASCII character case; this
3267 discarding is no longer needed.
3268 (sxhash-string): Use it. Change sig to match it. Caller changed.
3269 * lisp.h: Declare it.
3270 * lread.c (hash_string): Remove, since we now use fns.c's version.
3271 The fns.c version returns a wider integer if --with-wide-int is
3272 specified, so this should help the quality of the hashing a bit.
3273
b312a492
PE
3274 * emacs.c: Integer overflow minor fix.
3275 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3276 Define only if GNU_LINUX.
3277 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3278
dfd153ae
PE
3279 * dispnew.c: Integer signedness and overflow fixes.
3280 Remove unnecessary forward decls, that were a maintenance hassle.
3281 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3282 All uses changed.
3283 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3284 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3285 (prepare_desired_row, line_draw_cost):
3286 Use int, not unsigned, where either works.
3287 (save_current_matrix, restore_current_matrix):
3288 Use ptrdiff_t, not size_t, where either works.
3289 (init_display): Check for overflow more accurately, and without
3290 relying on undefined behavior.
3291
a81d11a3
PE
3292 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3293 Remove, replacing with the new symbols in lisp.h. All uses changed.
3294 * fileio.c (make_temp_name):
3295 * filelock.c (lock_file_1, lock_file):
3296 * xdisp.c (message_dolog):
3297 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3298 Use pMd etc. instead.
3299 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3300 replacing the pWIDE etc. symbols removed from editfns.c.
3301
3300e6fd
PE
3302 * keyboard.h (num_input_events): Now uintmax_t.
3303 This is (very slightly) less likely to mess up due to wraparound.
3304 All uses changed.
3305
fd05c7e9
PE
3306 * buffer.c: Integer signedness fixes.
3307 (alloc_buffer_text, enlarge_buffer_text):
3308 Use ptrdiff_t rather than size_t when either will do, as we prefer
3309 signed integers.
3310
903fe15d
PE
3311 * alloc.c: Integer signedness and overflow fixes.
3312 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3313 (__malloc_size_t): Default to size_t, not to int.
3314 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3315 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3316 Prefer ptrdiff_t to size_t when either would do, as we prefer
3317 signed integers.
3318 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3319 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3320 Now const. Initialize with values that are in range even if char
3321 is signed.
3322 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3323 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3324 These functions do the right thing with sizes > 2**32.
3325 (check_depth): Now ptrdiff_t, not int.
3326 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3327 Adjust to new way of storing sizes. Check for size overflow bugs
3328 in rest of code.
3329 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3330 slightly wrong anyway, as it missed one instance of
3331 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3332 (refill_memory_reserve): Omit needless cast to size_t.
3333 (mark_object_loop_halt): Mark as externally visible.
3334
ac82cc6a
PE
3335 * xselect.c: Integer signedness and overflow fixes.
3336 (Fx_register_dnd_atom, x_handle_dnd_message):
3337 Use ptrdiff_t, not size_t, since we prefer signed.
3338 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3339 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3340 x_dnd_atoms_size and x_dnd_atoms_length.
3341
c2d1e36d
PE
3342 * doprnt.c: Prefer signed to unsigned when either works.
3343 * eval.c (verror):
3344 * doprnt.c (doprnt):
3345 * lisp.h (doprnt):
3346 * xdisp.c (vmessage):
3347 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3348 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3349 prefer signed arithmetic to avoid comparison confusion.
3350 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3351 but is a bit tricky.
3352
0e926e56
PE
3353 Assume freestanding C89 headers, string.h, stdlib.h.
3354 * data.c, doprnt.c, floatfns.c, print.c:
3355 Include float.h unconditionally.
3356 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3357 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3358 * regex.c: Likewise for stddef.h, string.h.
3359 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3360 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3361 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3362 (STDC_HEADERS): Remove obsolete defines.
3363 * sysdep.c: Include limits.h unconditionally.
3364
9cfdb3ec
PE
3365 Assume support for memcmp, memcpy, memmove, memset.
3366 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3367 * regex.c (memcmp, memcpy):
3368 Remove; we assume C89 now.
3369
3370 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3371 (__malloc_safe_bcopy): Remove; no longer needed.
3372
cf950e6b 3373 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3374 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3375 well either way, and we prefer signed to unsigned.
3376
dbf38e02
LMI
33772011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3378
3379 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3380 closes the connection while we're reading (bug#9182).
3381
d6f0886c 33822011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3383
d6f0886c
JD
3384 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3385 are specified (Bug#9168).
24e0f6b1 3386
2eb1f9e6
PE
33872011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3388
3389 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3390 Found by GCC static checking and --with-wide-int on a 32-bit host.
3391
22381272 33922011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3393
3394 * xdisp.c (compute_display_string_pos): Fix logic of caching
3395 previous display string position. Initialize cached_prev_pos to
3396 -1. Fixes slow-down at the beginning of a buffer.
3397
f25e39b4
EZ
33982011-07-24 Eli Zaretskii <eliz@gnu.org>
3399
3400 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3401 for attrs[LFACE_FONTSET_INDEX].
3402
04c4b52e
PE
34032011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3404
3405 * xml.c (parse_region): Remove unused local
3406 that was recently introduced.
3407
c1734fbd
EZ
34082011-07-23 Eli Zaretskii <eliz@gnu.org>
3409
be18c5a5
EZ
3410 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3411 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3412
c1734fbd
EZ
3413 * xdisp.c (move_it_in_display_line_to): Record the best matching
3414 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3415 exit if none of the characters scanned was an exact match.
3416 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3417 when exact match is impossible due to invisible text, and the
3418 lines are truncated.
3419
a258d627
JD
34202011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3421
3422 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3423 for OSX >= 10.7.
3424
b6d5a689
EZ
34252011-07-22 Eli Zaretskii <eliz@gnu.org>
3426
0f74f785
EZ
3427 Fix a significant slow-down of cursor motion with C-n, C-p,
3428 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3429 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3430 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3431 (next_element_from_buffer): Call compute_stop_pos_backwards to
3432 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3433 base_level_stop.
3434 (reseat): Don't look for prev_stop, as that could mean a very long
3435 run.
3436 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3437 <cached_disp_overlay_modiff>: Cache for last found display string
3438 position.
551918c1 3439 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3440 about the same buffer in the same area of character positions, and
3441 the buffer wasn't changed since the time the display string
3442 position was cached.
551918c1 3443
b2d0c91a
EZ
34442011-07-22 Eli Zaretskii <eliz@gnu.org>
3445
3446 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3447 is an integer, which is important for empty lines. (Bug#9149)
3448
043604ee
CY
34492011-07-22 Chong Yidong <cyd@stupidchicken.com>
3450
3451 * frame.c (Fmodify_frame_parameters): In tty case, update the
3452 default face if necessary (Bug#4238).
3453
da4adb04
CY
34542011-07-21 Chong Yidong <cyd@stupidchicken.com>
3455
3456 * editfns.c (Fstring_to_char): No need to explain what a character
3457 is in the docstring (Bug#6576).
3458
9abd0532
LMI
34592011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3460
3461 * xml.c (parse_region): Make sure we always return a tree.
3462
36881d16
HK
34632011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3464
3465 * xml.c (parse_region): If a document contains only comments,
3466 return that, too.
3467
1e98674d
LMI
34682011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3469
3470 * xml.c (make_dom): Return comments, too.
3471
590bd467
PE
34722011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3473
3474 Port to OpenBSD.
3475 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3476 and the surrounding thread.
3477 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3478 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3479 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3480 timer goes off.
3481 * s/openbsd.h (BROKEN_SIGIO): Define.
3482 * unexelf.c (unexec) [__OpenBSD__]:
3483 Don't update the .mdebug section of the Alpha COFF symbol table.
3484
f41628b2
LMI
34852011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3486
3487 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3488 (bug#8460).
3489
b59b67c5
PE
34902011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3491
15e3a074
PE
3492 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3493 This fixes some race conditions on the permissions of any newly
3494 created file.
3495
41bed37d
PE
3496 * alloc.c (valid_pointer_p): Use pipe, not open.
3497 This fixes some permissions issues when debugging.
3498
b59b67c5
PE
3499 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3500 If fchown fails to set both uid and gid, try to set just gid,
3501 as that is sometimes allowed. Adjust the file's mode to eliminate
3502 setuid or setgid bits that are inappropriate if fchown fails.
3503
925a6be7
SM
35042011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3505
3506 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3507 to compare Lisp_Objects.
3508 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3509 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3510 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3511
52968808
AS
35122011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3513
0a6a104b
AS
3514 * lread.c (read_integer): Unread even EOF character.
3515 (read1): Likewise. Properly record start position of symbol.
3516
52968808
AS
3517 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3518 symbol character follows.
3519
9e381cdd
PE
35202011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3521
3522 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3523 This works around a problem with the previous change to Fcopy_file.
3524 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3525 and without this change, GCC might complain about discarding
3526 fchown's return value.
3527
b5641435
JB
35282011-07-16 Juanma Barranquero <lekktu@gmail.com>
3529
3530 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3531
a8031457
PE
35322011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3533
3534 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3535
dd889327
LMI
35362011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3537
750c33f7
LMI
3538 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3539 it's used from the C level.
3540
dd889327
LMI
3541 * process.c: Use the same condition for POLL_FOR_INPUT in both
3542 keyboard.c and process.c (bug#1858).
3543
87e86684
LM
35442011-07-09 Lawrence Mitchell <wence@gmx.li>
3545
3546 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3547 (Fgnutls_boot): Use it.
3548
64348f40
AS
35492011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3550
3551 * doc.c (Fsubstitute_command_keys): Revert last change.
3552
1d698799
LMI
35532011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3554
f863868c
LMI
3555 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3556 quotes the next character, and doesn't affect other longer
3557 sequences (bug#8935).
3558
1d698799
LMI
3559 * lread.c (syms_of_lread): Clarify that is isn't only
3560 `eval-buffer' and `eval-defun' that's affected by
3561 `lexical-binding' (bug#8460).
3562
aa4b6df6
EZ
35632011-07-15 Eli Zaretskii <eliz@gnu.org>
3564
3565 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3566 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3567
5d856da6
PE
35682011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3569
ad6042bb
PE
3570 Fix minor problems found by static checking.
3571 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3572 (elsz): Now a signed constant, not a size_t var. We prefer signed
3573 types to unsigned, to avoid integer comparison confusion. Without
3574 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3575 "cannot optimize loop, the loop counter may overflow", a symptom
3576 of the confusion.
f00bbb22 3577 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3578 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3579
6468f31c
LMI
35802011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3581
49080b10
LMI
3582 * search.c (Fre_search_backward): Mention `case-fold-search' in
3583 all the re_search_* functions (bug#8138).
3584
6468f31c
LMI
3585 * keyboard.c (Fopen_dribble_file): Document when the file is
3586 closed (bug#8056).
3587
c965adc5
EZ
35882011-07-14 Eli Zaretskii <eliz@gnu.org>
3589
df9733bf
EZ
3590 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3591 bidi_cache_idx.
3592
0bb23927
EZ
3593 Support bidi reordering of display and overlay strings.
3594 * xdisp.c (compute_display_string_pos)
3595 (compute_display_string_end): Accept additional argument STRING.
3596 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3597 (reseat_to_string): Initialize bidi_it->string.s and
3598 bidi_it->string.schars.
3599 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3600 NULL (avoids a crash in bidi_paragraph_init).
3601 Initialize itb.string.lstring.
0bb23927
EZ
3602 (init_iterator): Call bidi_init_it only of a valid
3603 buffer position was specified. Initialize paragraph_embedding to
3604 L2R.
3605 (reseat_to_string): Initialize the bidi iterator.
3606 (display_string): If we need to ignore text properties of
3607 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3608 original value of -1 will not work with bidi.)
3609 (compute_display_string_pos): First arg is now struct
3610 `text_pos *'; all callers changed. Support display properties on
3611 Lisp strings.
3612 (compute_display_string_end): Support display properties on Lisp
3613 strings.
3614 (init_iterator, reseat_1, reseat_to_string): Initialize the
3615 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3616 when iterating on a string not from display properties).
640c8776
SM
3617 (compute_display_string_pos, compute_display_string_end):
3618 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3619 arrow keys.
3620 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3621 base_level_stop; instead, set base_level_stop to BEGV.
3622 Fixes crashes in vertical-motion.
0bb23927
EZ
3623 (next_element_from_buffer): Improve commentary for when
3624 the iterator is before prev_stop.
3625 (init_iterator): Initialize bidi_p from the default value of
3626 bidi-display-reordering, not from buffer-local value. Use the
3627 buffer-local value only if initializing for buffer iteration.
3628 (handle_invisible_prop): Support invisible properties on strings
3629 that are being bidi-reordered.
3630 (set_iterator_to_next): Support bidi reordering of C strings and
3631 Lisp strings.
3632 (next_element_from_string): Support bidi reordering of Lisp
3633 strings.
3634 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3635 (display_string): Support display of R2L glyph rows.
3636 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3637 (init_iterator): Don't initialize it->bidi_p for strings
3638 here.
3639 (reseat_to_string): Initialize it->bidi_p for strings here.
3640 (next_element_from_string, next_element_from_c_string)
3641 (next_element_from_buffer): Add xassert's for correspondence
3642 between IT's object being iterated and it->bidi_it.string
3643 structure.
3644 (face_before_or_after_it_pos): Support bidi iteration.
3645 (next_element_from_c_string): Handle the case of the first string
3646 character that is not the first one in the visual order.
3647 (get_visually_first_element): New function, refactored from common
3648 parts of next_element_from_buffer, next_element_from_string, and
3649 next_element_from_c_string.
3650 (tool_bar_lines_needed, redisplay_tool_bar)
3651 (display_menu_bar): Force left-to-right direction. Add a FIXME
3652 comment for making that be controlled by a user option.
3653 (push_it, pop_it): Save and restore the state of the
3654 bidi iterator. Save and restore the bidi_p flag.
3655 (pop_it): Iterate out of display property for string iteration as
3656 well.
3657 (iterate_out_of_display_property): Support iteration over strings.
3658 (handle_single_display_spec): Set up it->bidi_it for iteration
3659 over a display string, and call bidi_init_it.
3660 (handle_single_display_spec, next_overlay_string)
3661 (get_overlay_strings_1, push_display_prop): Set up the bidi
3662 iterator for displaying display or overlay strings.
3663 (forward_to_next_line_start): Don't use the shortcut if
3664 bidi-iterating.
3665 (back_to_previous_visible_line_start): If handle_display_prop
3666 pushed the iterator stack, restore the internal state of the bidi
3667 iterator by calling bidi_pop_it same number of times.
3668 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3669 and we are bidi-iterating, don't decrement the iterator position;
3670 instead, set the first_elt flag in the bidi iterator, to produce
3671 the same effect.
3672 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3673 (push_display_prop): xassert that we are iterating a buffer.
3674 (push_it, pop_it): Save and restore paragraph_embedding member.
3675 (handle_single_display_spec, next_overlay_string)
3676 (get_overlay_strings_1, reseat_1, reseat_to_string)
3677 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3678 correctly. Don't assume unibyte strings are not bidi-reordered.
3679 (compute_display_string_pos)
3680 (compute_display_string_end): Fix handling the case of C string.
3681 (push_it, pop_it): Save and restore from_disp_prop_p.
3682 (handle_single_display_spec, push_display_prop): Set the
3683 from_disp_prop_p flag.
3684 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3685 (pop_it): Call iterate_out_of_display_property only if we are
3686 popping after iteration over a string that came from a display
3687 property. Fix a typo in popping stretch info. Add an assertion
3688 for verifying that the iterator position is in sync with the bidi
3689 iterator.
3690 (handle_single_display_spec, get_overlay_strings_1)
3691 (push_display_prop): Fix initialization of paragraph direction for
3692 string when that of the parent object is not yet determined.
3693 (reseat_1): Call bidi_init_it to resync the bidi
3694 iterator with IT's position. (Bug#7616)
3695 (find_row_edges): If ROW->start.pos gives position
3696 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3697 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3698 Reset the from_disp_prop_p flag.
3699 (SAVE_IT, RESTORE_IT): New macros.
3700 (pos_visible_p, face_before_or_after_it_pos)
3701 (back_to_previous_visible_line_start)
3702 (move_it_in_display_line_to, move_it_in_display_line)
3703 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3704 (try_scrolling, redisplay_window, display_line): Use them when
3705 saving a temporary copy of the iterator and restoring it back.
3706 (back_to_previous_visible_line_start, reseat_1)
3707 (init_iterator): Empty the bidi cache "stack".
3708 (move_it_in_display_line_to): If iterator ended up at
3709 EOL, but we never saw any buffer positions smaller than
3710 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3711 motion in bidi-reordered lines.
3712 (move_it_in_display_line_to): Record prev_method and prev_pos
3713 immediately before the call to set_iterator_to_next. Fixes cursor
3714 motion in bidi-reordered lines with stretch glyphs and strings
3715 displayed in margins. (Bug#8133) (Bug#8867)
3716 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3717 TO_CHARPOS.
640c8776
SM
3718 (pos_visible_p): Support positions in bidi-reordered lines.
3719 Save and restore bidi cache.
0bb23927
EZ
3720
3721 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3722 (bidi_paragraph_info): Delete unused struct.
3723 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3724 (bidi_cache_start): New variable.
3725 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3726 to zero.
3727 (bidi_cache_fetch_state, bidi_cache_search)
3728 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3729 (bidi_cache_find, bidi_peek_at_next_level)
3730 (bidi_level_of_next_char, bidi_find_other_level_edge)
3731 (bidi_move_to_visually_next): Compare cache index with
3732 bidi_cache_start rather than with zero.
3733 (bidi_fetch_char): Accept new argument STRING; all callers
3734 changed. Support iteration over a string. Support strings with
3735 display properties. Support unibyte strings. Fix the type of
3736 `len' according to what STRING_CHAR_AND_LENGTH expects.
3737 (bidi_paragraph_init, bidi_resolve_explicit_1)
3738 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3739 (bidi_level_of_next_char, bidi_move_to_visually_next):
3740 Support iteration over a string.
0bb23927
EZ
3741 (bidi_set_sor_type, bidi_resolve_explicit_1)
3742 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3743 can now be zero (for strings); special values 0 and -1 were
3744 changed to -1 and -2, respectively.
3745 (bidi_char_at_pos): New function.
3746 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3747 Call it instead of FETCH_MULTIBYTE_CHAR.
3748 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3749 initialized to valid values.
3750 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3751 values.
3752 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3753 the test for valid cached positions. Fix the logic for looking up
3754 the sentinel state in the cache. GCPRO the Lisp string we are
3755 iterating.
3756 (bidi_push_it, bidi_pop_it): New functions.
3757 (bidi_initialize): Initialize the bidi cache start stack pointer.
3758 (bidi_cache_ensure_space): New function, refactored from part of
3759 bidi_cache_iterator_state. Don't assume the required size is just
3760 one BIDI_CACHE_CHUNK away.
3761 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3762 (bidi_count_bytes, bidi_char_at_pos): New functions.
3763 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3764 always valid if bidi_cache_idx is valid.
3765 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3766 is valid if it's going to be used.
3767 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3768 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3769 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3770 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3771 (bidi_find_other_level_edge, bidi_cache_start_stack):
3772 All variables related to cache indices are now EMACS_INT.
c965adc5 3773
0bb23927
EZ
3774 * dispextern.h (struct bidi_string_data): New structure.
3775 (struct bidi_it): New member `string'. Make flag members be 1-bit
3776 fields, and put them last in the struct.
640c8776
SM
3777 (compute_display_string_pos, compute_display_string_end):
3778 Update prototypes.
0bb23927
EZ
3779 (bidi_push_it, bidi_pop_it): Add prototypes.
3780 (struct iterator_stack_entry): New members bidi_p,
3781 paragraph_embedding, and from_disp_prop_p.
3782 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3783 (bidi_shelve_cache, bidi_unshelve_cache):
3784 Declare prototypes.
0bb23927
EZ
3785
3786 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3787 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3788 and vector-like objects.
3789
3790 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3791 cache around display iteration.
3792
3793 * window.c (Fwindow_end, window_scroll_pixel_based)
3794 (displayed_window_lines, Frecenter): Save and restore the bidi
3795 cache around display iteration.
3796
3bbd2265
LMI
37972011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3798
3799 * editfns.c (Fdelete_region): Clarify the use of the named
3800 parameters (bug#6788).
3801
adc47434
MR
38022011-07-14 Martin Rudalics <rudalics@gmx.at>
3803
3804 * indent.c (Fvertical_motion): Set and restore w->pointm when
3805 saving and restoring the window's buffer (Bug#9006).
3806
837c31f8
LMI
38072011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3808
3809 * editfns.c (Fstring_to_char): Clarify just what is returned
3810 (bug#6576). Text by Eli Zaretskii.
3811
ac389d0c
JB
38122011-07-13 Juanma Barranquero <lekktu@gmail.com>
3813
3814 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3815
0be0ce47
EZ
38162011-07-13 Eli Zaretskii <eliz@gnu.org>
3817
3818 * buffer.c (mmap_find): Fix a typo.
3819
cd18e7e3
JB
38202011-07-13 Johan Bockgård <bojohan@gnu.org>
3821
3822 Fix execution of x selection hooks.
3823 * xselect.c (Qx_lost_selection_functions)
3824 (Qx_sent_selection_functions): New vars.
3825 (syms_of_xselect): DEFSYM them.
3826 (x_handle_selection_request): Pass Qx_sent_selection_functions
3827 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3828 (x_handle_selection_clear,x_clear_frame_selections):
3829 Pass Qx_lost_selection_functions rather than
3830 Vx_lost_selection_functions to Frun_hook_with_args.
3831
47ea7f44
PE
38322011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3833
ac389d0c 3834 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3835 The old code sometimes used this field without initializing it.
3836
47ea7f44
PE
3837 * alloc.c (gc_sweep): Don't read past end of array.
3838 In theory, the old code could also have corrupted Emacs internals,
3839 though it'd be very unlikely.
3840
bc985c87
AS
38412011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3842
3843 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3844 argument. (Bug#4026)
bc985c87 3845
0cf34688
LMI
38462011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3847
b3dadd76
LMI
3848 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3849 key" (bug#4257).
3850
0cf34688
LMI
3851 * window.c (Fset_window_start): Doc fix (bug#4199).
3852 (Fset_window_hscroll): Ditto.
3853
270768cd
PE
38542011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3855
077e3dda 3856 Fix minor new problems caught by GCC 4.6.1.
270768cd 3857 * term.c (init_tty): Remove unused local.
490011a6 3858 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3859 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3860 not used otherwise.
270768cd 3861
b1f58454
CY
38622011-07-12 Chong Yidong <cyd@stupidchicken.com>
3863
3864 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3865
22b9578d
LMI
38662011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3867
6e70ab07
LMI
3868 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3869 are the mini-buffer and the echo area (bug#3320).
3870
22b9578d
LMI
3871 * term.c (init_tty): Remove support for supdup, c10 and perq
3872 terminals, which are no longer supported (bug#1482).
3873
8974cc9f
JB
38742011-07-10 Johan Bockgård <bojohan@gnu.org>
3875
3876 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3877
a560d974
JD
38782011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3879
3880 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3881 for non-popups (Bug#3642).
3882
1dae0f0a
AS
38832011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3884
268c2c36 3885 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3886 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3887 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3888 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3889 * data.c (fmod): Likewise.
3890 * dispnew.c (swap_glyphs_in_rows): Likewise.
3891 * emacs.c (memory_warning_signal): Likewise.
3892 * floatfns.c (float_error): Likewise.
3893 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3894 (otf_open, font_otf_capability, generate_otf_features)
3895 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3896 Likewise.
3897 * image.c (pbm_read_file): Likewise.
3898 * indent.c (string_display_width): Likewise.
3899 * intervals.c (check_for_interval, search_for_interval)
3900 (inc_interval_count, count_intervals, root_interval)
3901 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3902 * lread.c (defalias): Likewise.
268c2c36 3903 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3904 * regex.c (set_image_of_range_1, set_image_of_range)
3905 (regex_grow_registers): Likewise.
3906 * sysdep.c (strerror): Likewise.
3907 * termcap.c (valid_filename_p, tprint, main): Likewise.
3908 * tparam.c (main): Likewise.
3909 * unexhp9k800.c (run_time_remap, save_data_space)
3910 (update_file_ptrs, read_header, write_header, calculate_checksum)
3911 (copy_file, copy_rest, display_header): Likewise.
3912 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3913 Likewise.
3914 * xdisp.c (check_it): Likewise.
3915 * xfaces.c (register_color, unregister_color, unregister_colors):
3916 Likewise.
3917 * xfns.c (print_fontset_result): Likewise.
3918 * xrdb.c (member, fatal, main): Likewise.
3919
99033785
PE
39202011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3921
3922 Fix minor problems found by static checking (Bug#9031).
3923 * chartab.c (char_table_set_range, map_sub_char_table):
3924 Remove unused locals.
3925 (uniprop_table): Now static.
3926 * composite.c (_work_char): Remove unused static var.
3927
9cb2ac56
JB
39282011-07-09 Juanma Barranquero <lekktu@gmail.com>
3929
3930 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3931
f25661f0
JD
39322011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3933
3934 * gtkutil.c (qttip_cb): Remove code without function.
3935
8278c4fe
EZ
39362011-07-09 Eli Zaretskii <eliz@gnu.org>
3937
3938 * w32.c (pthread_sigmask): New stub.
3939
1692ae2d 39402011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3941
8a6ebd58 3942 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3943 sigprocmask is portable only for single-threaded applications, and
3944 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3945 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3946 (LIBES): Use it.
3947 * callproc.c (Fcall_process):
3948 * process.c (create_process):
3949 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3950 Use pthread_sigmask, not sigprocmask.
123403e4 3951
1b854618
JD
39522011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3953
3954 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3955 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3956 wrong (Bug#8591).
3957
3fe4b549
JD
39582011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3959
0ce7e563
JD
3960 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3961 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3962 (xg_hide_tooltip): Fix comment.
3963
3fe4b549
JD
3964 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3965 in registerServicesMenuSendTypes.
3966 (validRequestorForSendType): Don't check ns_return_types.
3967
3968 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3969 ns_return_type.
3970
5df75e47
JR
39712011-07-08 Jason Rumney <jasonr@gnu.org>
3972
22610910
JR
3973 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3974 SH_SHOW for hidden windows (Bug#5482).
3975
5df75e47
JR
3976 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3977 frame struct members of non-existent frames (Bug#6284).
3978
699c10bd
JD
39792011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3980
4393663b
JD
3981 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3982 variable firstTime not needed on OSX >= 10.6.
3983 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3984 >= 10.5. Use setKnobProportion, setDoubleValue.
3985
3986 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3987 (MAC_OS_X_VERSION_10_5): Define if not defined.
3988 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3989 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3990 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3991
3992 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3993 cString and lossyCString on OSX >= 10.4
3994
58179cce 3995 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3996 sizeToFit on OSX >= 10.2.
3997
3998 * nsimage.m (allocInitFromFile): Don't use deprecated method
3999 bestRepresentationForDevice on OSX >= 10.6.
4000
4001 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4002 to avoid warning.
4003
4004 * emacs.c: Declare unexec_init_emacs_zone.
4005
a63e0781
JD
4006 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4007
699c10bd
JD
4008 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4009
4010 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4011 on svcsMenu (Bug#8842).
4012
4013 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4014 ns_return_types.
4015 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4016
4017 * nsterm.m (QUTF8_STRING): Declare.
4018 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4019 (validRequestorForSendType): Return type is (id).
4020 Change indexOfObjectIdenticalTo to indexOfObject.
4021 Check if we have local selection before returning self (Bug#8842).
4022 (writeSelectionToPasteboard): Put local selection into paste board
4023 if we have a local selection (Bug#8842).
4024 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4025
4026 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4027 (ns_get_local_selection): Declare.
4028
54e10184
LMI
40292011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4030
9888ff71
LMI
4031 * keymap.c (describe_map_tree): Don't insert a double newline at
4032 the end of the buffer (bug#1169) and return whether we inserted
4033 something.
4034
54e10184
LMI
4035 * callint.c (Fcall_interactively): Change "reading args" to
4036 "providing args" to try to clarify what it does (bug#1010).
4037
15fa4783
KH
40382011-07-07 Kenichi Handa <handa@m17n.org>
4039
4040 * composite.c (composition_compute_stop_pos): Ignore a static
4041 composition starting before CHARPOS (Bug#8915).
4042
4043 * xdisp.c (handle_composition_prop): Likewise.
4044
a8815b00
EZ
40452011-07-07 Eli Zaretskii <eliz@gnu.org>
4046
4047 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4048 (Bug#9015)
4049
ef7b981d 40502011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4051
4052 * character.h (unicode_category_t): New enum type.
4053
4054 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4055 (Qchar_code_property_table): New variable.
4056 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4057 (UNIPROP_COMPRESSED_FORM_P): New macros.
4058 (char_table_ascii): Uncompress the compressed values.
4059 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4060 Uncompress the compressed values.
ac389d0c 4061 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4062 (char_table_ref_and_range): Uncompress the compressed values.
4063 (sub_char_table_set): New arg is_uniprop. Callers changed.
4064 Uncompress the compressed values.
4065 (sub_char_table_set_range): Args changed. Callers changed.
4066 (char_table_set_range): Adjuted for the above change.
4067 (map_sub_char_table): Delete args default_val and parent. Add arg
4068 top. Give decoded values to a Lisp function.
640c8776 4069 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4070 values to a Lisp function. Gcpro more variables.
4071 (uniprop_table_uncompress)
4072 (uniprop_decode_value_run_length): New functions.
4073 (uniprop_decoder, uniprop_decoder_count): New variables.
4074 (uniprop_get_decoder, uniprop_encode_value_character)
4075 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4076 New functions.
4077 (uniprop_encoder, uniprop_encoder_count): New variables.
4078 (uniprop_get_encoder, uniprop_table)
4079 (Funicode_property_table_internal, Fget_unicode_property_internal)
4080 (Fput_unicode_property_internal): New functions.
4081 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4082 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4083 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4084 char-code-property-alist.
4085
640c8776 4086 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4087 Vunicode_category_table.
4088
640c8776 4089 * font.c (font_range): Adjust for the change of
c805dec0
KH
4090 Vunicode_category_table.
4091
76b397fb
DN
40922011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4093
4094 * m/iris4d.h: Remove file, move contents ...
4095 * s/irix6-5.h: ... here.
4096
22b4128e
PE
40972011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4098
4099 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4100 * alloc.c (mark_buffer):
4101 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4102 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4103 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4104 This isn't true in general, and it's particularly not true
4105 if Emacs is configured with --with-wide-int.
4106 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4107 New macros, used in the buffer.c change.
4108
869795d6
JD
41092011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4110
4111 * xsettings.c: Use both GConf and GSettings if both are available.
4112 (store_config_changed_event): Add comment.
4113 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4114 (store_tool_bar_style_changed): New functions.
5e617bc2 4115 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4116 (struct xsettings): Move font inside HAVE_XFT.
4117 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4118 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4119 Move inside HAVE_XFT.
640c8776 4120 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4121 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4122 also.
4123 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4124 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4125 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4126 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4127 (parse_settings): Move check for font inside HAVE_XFT.
4128 (read_settings, apply_xft_settings): Add comment.
4129 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4130 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4131 call store_font_name_changed.
4132 (xft_settings_event): Add comment.
4133 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4134 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4135 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4136 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4137 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4138 (xsettings_get_system_font, xsettings_get_system_normal_font):
4139 Add comment.
869795d6 4140
d8ed26bd
PE
41412011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4142
4143 Random fixes. E.g., (random) never returned negative values.
4144 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4145 subseconds part to the entropy, as that's a bit more random.
4146 Prefer signed to unsigned, since the signedness doesn't matter and
4147 in general we prefer signed. When given a limit, use a
4148 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4149 latter isn't right if USE_2_TAGS_FOR_INTS.
4150 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4151 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4152
cabf1cac
SM
41532011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4154
4155 * textprop.c (text_property_stickiness):
4156 Obey Vtext_property_default_nonsticky.
4157 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4158 * w32fns.c (syms_of_w32fns):
4159 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4160
6e9b2be9
PE
41612011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4162
4163 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4164 This is more efficient than Ffile_directory_p and avoids a minor race.
4165
90186c68
LMI
41662011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4167
7c301272
LMI
4168 * buffer.c (Foverlay_put): Say what the return value is
4169 (bug#7835).
4170
c4f2d8d4
LMI
4171 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4172 is a directory before asking whether to use the file name
4173 (bug#7564).
ad637907
LMI
4174 (barf_or_query_if_file_exists): Make the "File is a directory"
4175 error be more correct.
c4f2d8d4 4176
90186c68
LMI
4177 * fns.c (Frequire): Remove the mention of the .gz files, since
4178 that's installation-specific, but keep the mention of
4179 `get-load-suffixes'.
4180
da64016e
PE
41812011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4182
4183 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4184 Report string overflow if the output is too long.
4185
7d47b580
JB
41862011-07-04 Juanma Barranquero <lekktu@gmail.com>
4187
a555cb87
JB
4188 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4189 (syms_of_gnutls): Remove duplicate DEFSYM for
4190 Qgnutls_bootprop_verify_hostname_error, an error for
4191 Qgnutls_bootprop_verify_error (which is no longer used).
4192
7d47b580
JB
4193 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4194 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4195 Also (re)move comments that are misplaced or no longer relevant.
4196
1e49bfab
LMI
41972011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4198
4199 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4200
1485f4c0
CY
42012011-07-03 Chong Yidong <cyd@stupidchicken.com>
4202
4203 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4204 and background color parameters if they have been changed.
4205
a9ab721e
LMI
42062011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4207
4208 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4209
cf7cff57
PE
42102011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4211
2e13213d
PE
4212 * xsettings.c (SYSTEM_FONT): Define only when used.
4213 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4214
cf7cff57
PE
4215 * keymap.c (access_keymap_1): Now static.
4216
7a8e04f7
CY
42172011-07-02 Chong Yidong <cyd@stupidchicken.com>
4218
4219 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4220 leave any prefix arg for the up event (Bug#1586).
4221
61352f62
LMI
42222011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4223
69bb1ef7
LMI
4224 * lread.c (syms_of_lread): Mention single symbols defined by
4225 `defvar' or `defconst' (bug#7154).
4226
61352f62 4227 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4228 (Frequire): Mention get-load-suffixes.
61352f62 4229
28545e04
MR
42302011-07-02 Martin Rudalics <rudalics@gmx.at>
4231
4232 * window.h (window): Remove clone_number slot.
4233 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4234 Remove.
4235 (make_parent_window, make_window, saved_window)
4236 (Fset_window_configuration, save_window_save): Don't deal with
4237 clone numbers.
4238 * buffer.c (Qclone_number): Remove declaration.
4239 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4240
3349e122
SM
42412011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4242
4243 Add multiple inheritance to keymaps.
4244 * keymap.c (Fmake_composed_keymap): New function.
4245 (Fset_keymap_parent): Simplify.
4246 (fix_submap_inheritance): Remove.
4247 (access_keymap_1): New function extracted from access_keymap to handle
4248 embedded parents and handle lists of maps.
4249 (access_keymap): Use it.
4250 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4251 (Fcopy_keymap): Handle embedded parents.
4252 (Fcommand_remapping, define_as_prefix): Simplify.
4253 (Fkey_binding): Simplify.
4254 (syms_of_keymap): Move minibuffer-local-completion-map,
4255 minibuffer-local-filename-completion-map,
4256 minibuffer-local-must-match-map, and
4257 minibuffer-local-filename-must-match-map to Elisp.
4258 (syms_of_keymap): Defsubr make-composed-keymap.
4259 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4260 (parse_menu_item): Trivial simplification.
4261
3279eb87
GM
42622011-07-01 Glenn Morris <rgm@gnu.org>
4263
4264 * Makefile.in (SETTINGS_LIBS): Fix typo.
4265
4550efdf
KI
42662011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4267
4268 * coding.c (Fencode_coding_string): Record the last coding system
4269 used, as the function doc string says (bug#8738).
4270
0949d2b6
JD
42712011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4272
4273 * xsettings.c (store_monospaced_changed): Take new font as arg and
4274 check for change against current_mono_font.
4275 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4276 (emacs_settings_constructor, emacs_settings_get_property)
4277 (emacs_settings_set_property, emacs_settings_class_init)
4278 (emacs_settings_init, gsettings_obj): Remove.
4279 (something_changedCB): New function for HAVE_GSETTINGS.
4280 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4281 with value as argument.
4282 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4283 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4284 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4285 "changed".
4286
4287 * xgselect.c: Add defined (HAVE_GSETTINGS).
4288 (xgselect_initialize): Ditto.
4289
4290 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4291 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4292 xg_select.
4293
bbc6b304
PE
42942011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4295
4296 * eval.c (struct backtrace): Simplify and port the data structure.
4297 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4298 signed bit field, as this assumption is not portable and it makes
4299 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4300 "char debug_on_exit : 1" as this is not portable either; instead,
4301 use the portable "unsigned int debug_on_exit : 1". Remove unused
4302 member evalargs. Remove obsolete comments about cc bombing out.
4303
9851bfc5
JD
43042011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4305
51bb811f 4306 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4307 Let HAVE_GSETTINGS override HAVE_GCONF.
4308 (store_monospaced_changed): New function.
4309 (EMACS_SETTINGS): A new type derived from GObject to handle
4310 GSettings notifications.
4311 (emacs_settings_constructor, emacs_settings_get_property)
4312 (emacs_settings_set_property, emacs_settings_class_init):
4313 New functions.
4314 (gsettings_client, gsettings_obj): New variables.
4315 (GSETTINGS_SCHEMA): New define.
4316 (something_changedCB): Call store_monospaced_changed.
4317 (init_gsettings): New function.
4318 (xsettings_initialize): Call init_gsettings.
4319 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4320 to NULL.
4321
640c8776 4322 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4323 GCONF_CFLAGS/LIBS.
4324
5386012d
MR
43252011-06-29 Martin Rudalics <rudalics@gmx.at>
4326
4327 * window.c (resize_root_window, grow_mini_window)
4328 (shrink_mini_window): Rename Qresize_root_window to
4329 Qwindow_resize_root_window and Qresize_root_window_vertically to
4330 Qwindow_resize_root_window_vertically.
4331
f13e0b08
PE
43322011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4333
4334 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4335
94515237
JB
43362011-06-27 Juanma Barranquero <lekktu@gmail.com>
4337
4338 * makefile.w32-in: Redesign dependencies so they reflect more
4339 clearly which files are directly included by each source file,
4340 and not through other includes.
4341
e43b6e43
MR
43422011-06-27 Martin Rudalics <rudalics@gmx.at>
4343
4344 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4345 (sort_overlays, overlay_strings): When an overlay's clone number
4346 matches the window's clone number process the overlay even if
4347 the overlay's window property doesn't match the current window.
4348
d68443dc
MR
4349 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4350 (Fwindow_hchild): Rename to Fwindow_left_child.
4351 (Fwindow_next): Rename to Fwindow_next_sibling.
4352 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4353 (resize_window_check): Rename to window_resize_check.
4354 (resize_window_apply): Rename to window_resize_apply.
4355 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4356 (Fdelete_other_windows_internal, resize_frame_windows)
4357 (Fsplit_window_internal, Fdelete_window_internal)
4358 (grow_mini_window, shrink_mini_window)
4359 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4360
c7e73be5
JD
43612011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4362
4363 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4364 (emacs_fixed_set_min_size): Remove.
4365 (emacs_fixed_new): Take frame as argument.
4366
4367 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4368 (_EmacsFixedPrivate): Remove minwidth/height.
4369 Add struct frame *f.
4370 (emacs_fixed_init): Initialize priv->f.
4371 (get_parent_class, emacs_fixed_set_min_size): Remove.
4372 (emacs_fixed_new): Set priv->f to argument.
4373 (emacs_fixed_get_preferred_width)
4374 (emacs_fixed_get_preferred_height): Use min_width/height from
4375 frames size_hint to set minimum and natural (Bug#8919).
4376 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4377 and use min_width/height from frames size_hint to set
4378 min_width/height (Bug#8919).
4379
4380 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4381 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4382 Fix indentation.
c7e73be5 4383
cf99dcf8
EZ
43842011-06-26 Eli Zaretskii <eliz@gnu.org>
4385
4386 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4387 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4388 called at ZV.
4389
029529ac
CY
43902011-06-26 Chong Yidong <cyd@stupidchicken.com>
4391
4392 * process.c (wait_reading_process_output): Bypass select if
4393 waiting for a cell while ignoring keyboard input, and input is
4394 pending. Suggested by Jan Djärv (Bug#8869).
4395
7a7ef429
PE
43962011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4397
4398 Use gnulib's dup2 module instead of rolling our own.
4399 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4400
11fdef7d 44012011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4402
4403 * dispnew.c (scrolling_window): Before scrolling, turn off a
4404 mouse-highlight in the window being scrolled.
4405
cd3520a4
JB
44062011-06-24 Juanma Barranquero <lekktu@gmail.com>
4407
4408 Move DEFSYM to lisp.h and use everywhere.
4409
4410 * character.h (DEFSYM): Move declaration...
4411 * lisp.h (DEFSYM): ...here.
4412
4413 * gnutls.c:
4414 * minibuf.c:
4415 * w32menu.c:
4416 * w32proc.c:
4417 * w32select.c: Don't include character.h.
4418
4419 * alloc.c (syms_of_alloc):
4420 * buffer.c (syms_of_buffer):
4421 * bytecode.c (syms_of_bytecode):
4422 * callint.c (syms_of_callint):
4423 * casefiddle.c (syms_of_casefiddle):
4424 * casetab.c (init_casetab_once):
4425 * category.c (init_category_once, syms_of_category):
4426 * ccl.c (syms_of_ccl):
4427 * cmds.c (syms_of_cmds):
4428 * composite.c (syms_of_composite):
4429 * dbusbind.c (syms_of_dbusbind):
4430 * dired.c (syms_of_dired):
4431 * dispnew.c (syms_of_display):
4432 * doc.c (syms_of_doc):
4433 * editfns.c (syms_of_editfns):
4434 * emacs.c (syms_of_emacs):
4435 * eval.c (syms_of_eval):
4436 * fileio.c (syms_of_fileio):
4437 * fns.c (syms_of_fns):
4438 * frame.c (syms_of_frame):
4439 * fringe.c (syms_of_fringe):
4440 * insdel.c (syms_of_insdel):
4441 * keymap.c (syms_of_keymap):
4442 * lread.c (init_obarray, syms_of_lread):
4443 * macros.c (syms_of_macros):
4444 * msdos.c (syms_of_msdos):
4445 * print.c (syms_of_print):
4446 * process.c (syms_of_process):
4447 * search.c (syms_of_search):
4448 * sound.c (syms_of_sound):
4449 * syntax.c (init_syntax_once, syms_of_syntax):
4450 * terminal.c (syms_of_terminal):
4451 * textprop.c (syms_of_textprop):
4452 * undo.c (syms_of_undo):
4453 * w32.c (globals_of_w32):
4454 * window.c (syms_of_window):
4455 * xdisp.c (syms_of_xdisp):
4456 * xfaces.c (syms_of_xfaces):
4457 * xfns.c (syms_of_xfns):
4458 * xmenu.c (syms_of_xmenu):
4459 * xsettings.c (syms_of_xsettings):
4460 * xterm.c (syms_of_xterm): Use DEFSYM.
4461
4228cf16
TZ
44622011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4463
cd3520a4 4464 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4465
7fcccf1e
PE
44662011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4467
7efb4e0e
PE
4468 Integer and buffer overflow fixes (Bug#8873).
4469
ff5844ad
PE
4470 * print.c (printchar, strout): Check for string overflow.
4471 (PRINTPREPARE, printchar, strout):
4472 Don't set size unless allocation succeeds.
4473
90532f02
PE
4474 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4475 for sizes. Check for string overflow more accurately.
4476 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4477
6d84508d
PE
4478 * macros.c: Integer and buffer overflow fixes.
4479 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4480 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4481 Use ptrdiff_t, not int, for sizes.
4482 Don't increment bufsize until after realloc succeeds.
4483 Check for size-calculation overflow.
4484 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4485
437b2cb4
PE
4486 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4487
8b9ac8b4
PE
4488 * lread.c: Integer overflow fixes.
4489 (read_integer): Radix is now EMACS_INT, not int,
4490 to improve quality of diagnostics for out-of-range radices.
4491 Calculate buffer size correctly for out-of-range radices.
4492 (read1): Check for integer overflow in radices, and in
4493 read-circle numbers.
82cb60d3
PE
4494 (read_escape): Avoid int overflow.
4495 (Fload, openp, read_buffer_size, read1)
4496 (substitute_object_recurse, read_vector, read_list, map_obarray):
4497 Use ptrdiff_t, not int, for sizes.
4498 (read1): Use EMACS_INT, not int, for sizes.
20270765 4499 Check for size overflow.
8b9ac8b4 4500
7fcccf1e
PE
4501 * image.c (cache_image): Check for size arithmetic overflow.
4502
bfbbd7e7
PE
4503 * lread.c: Integer overflow issues.
4504 (saved_doc_string_size, saved_doc_string_length)
4505 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4506 Now ptrdiff_t, not int.
4507 (read1): Don't assume doc string length fits in int. Check for
4508 out-of-range doc string lengths.
4509 (read_list): Don't assume file position fits in int.
39019e54 4510 (read_escape): Check for hex character overflow.
bfbbd7e7 4511
4e323265
LL
45122011-06-22 Leo Liu <sdl.web@gmail.com>
4513
4514 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4515 Move to minibuffer.el.
4516
85fece3e
PE
45172011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4518
20b84ce9 4519 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4520 The following patches are for when GLYPH_DEBUG && !XASSERT.
4521 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4522 * dispnew.c (flush_stdout):
4523 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4524 Mark as externally visible.
4525 * dispnew.c (check_window_matrix_pointers): Now static.
4526 * dispnew.c (window_to_frame_vpos):
4527 * xfns.c (unwind_create_frame):
4528 * xterm.c (x_check_font): Remove unused local.
4529 * scroll.c (CHECK_BOUNDS):
4530 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4531 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4532 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4533 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4534 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4535 Now static.
4536 (debug_method_add): Use va_list and vsprintf rather than relying
4537 on undefined behavior with wrong number of arguments.
4538 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4539 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4540 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4541 since we're not interested in debugging glyphs with old libraries.
4542 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4543 GCC 4.6.0's static checking.
4544
0766b489
PE
45452011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4546
31fd4b32
PE
4547 Integer overflow and signedness fixes (Bug#8873).
4548 A few related buffer overrun fixes, too.
4549
b79e8648
PE
4550 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4551
0766b489
PE
4552 * dispextern.h (struct face.stipple):
4553 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4554 (x_bitmap_mask, x_allocate_bitmap_record)
4555 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4556 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4557 (x_create_bitmap_from_xpm_data):
4558 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4559 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4560 (.bitmaps_last):
4561 * xfaces.c (load_pixmap):
4562 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4563 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4564 (.bitmaps_last, struct x_output.icon_bitmap):
4565 Use ptrdiff_t, not int, for bitmap indexes.
4566 (x_allocate_bitmap_record): Check for size overflow.
4567 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4568
b081724f
PE
4569 Use ptrdiff_t, not int, for overlay counts.
4570 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4571 * editfns.c (overlays_around, get_pos_property):
4572 * textprop.c (get_char_property_and_overlay):
4573 * xdisp.c (next_overlay_change, note_mouse_highlight):
4574 * xfaces.c (face_at_buffer_position):
21514da7
PE
4575 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4576 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4577 (Fnext_overlay_change, Fprevious_overlay_change)
4578 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4579 Use ptrdiff_t, not int, for sizes.
21514da7 4580 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4581
3de73e5e
PE
4582 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4583
2606c57b
PE
4584 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4585 (x_session_initialize): Do not assume string length fits in int.
4586
aaafe47a
PE
4587 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4588 This is unlikely, but can occur if DPI is outlandish.
4589
2674ddc8 4590 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4591 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4592
28154962
PE
4593 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4594 * xrdb.c (magic_file_p, search_magic_path):
4595 Omit last arg SUFFIX; it was always 0. All callers changed.
4596 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4597
7de51af5
PE
4598 * xfont.c (xfont_match): Avoid need for strlen.
4599
25ed6cc3
PE
4600 * xfns.c: Don't assume strlen fits in int.
4601 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4602
4eab31dd
PE
4603 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4604 not unsigned long, as we prefer signed integers. All callers changed.
4605 Detect integer overflow in repeat count.
4606 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4607 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4608
171e2a58
PE
4609 * termcap.c: Don't assume sizes fit in int and never overflow.
4610 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4611 (gobble_line): Check for size-calculation overflow.
4612
ad39faca 4613 * minibuf.c (Fread_buffer):
6e5bb2dc 4614 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4615 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4616 Don't assume string length fits in int.
4617
52c61c22 4618 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4619 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4620
b5b8c9e5
PE
4621 * font.c: Don't assume string length fits in int.
4622 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4623 Use ptrdiff_t, not int.
ccd6111c
PE
4624 (font_intern_prop): Don't assume string length fits in int.
4625 Don't assume integer property fits in fixnum.
4626 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4627
882f0d81 4628 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4629 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4630 Reformulate so as not to need the command string.
4631 Invoke gzip -cd rather than gunzip, as it's more portable.
4632 (lock_info_type, lock_file_1, lock_file):
4633 Don't assume pid_t and time_t fit in unsigned long.
4634 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4635 (current_lock_owner): Prefer signed type for sizes.
4636 Use memcpy, not strncpy, where memcpy is what is really wanted.
4637 Don't assume (via atoi) that time_t and pid_t fit in int.
4638 Check for time_t and/or pid_t out of range, e.g., via a network share.
4639 Don't alloca where an auto var works fine.
4640
93f4cf88
PE
4641 * fileio.c: Fix some integer overflow issues.
4642 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4643 Don't assume string length fits in int.
4644 (directory_file_name): Don't assume string length fits in long.
4645 (make_temp_name): Don't assume pid fits in int, or that its print
4646 length is less than 20.
4647
f3e92b69
PE
4648 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4649
1bfdaf10
PE
4650 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4651
35016e9a
PE
4652 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4653
3d1e65a1
PE
4654 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4655 We prefer signed integers, even for size calculations.
4656
0b963a93
PE
4657 * emacs.c: Don't assume string length fits in 'int'.
4658 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4659 (main): Don't invoke strlen when not needed.
4660
573f4b54
PE
4661 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4662 (XD_DEBUG_MESSAGE): Don't waste a byte.
4663
989f33ba
PE
4664 * callproc.c (getenv_internal_1, getenv_internal)
4665 (Fgetenv_internal):
965d34eb
PE
4666 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4667
e4d29b33
PE
4668 * lread.c (invalid_syntax): Omit length argument.
4669 All uses changed. This doesn't fix a bug, but it simplifies the
4670 code away from its former Hollerith-constant appearance, and it's
4671 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4672 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4673
eb49b136
PE
4674 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4675 This didn't break anything, but it didn't help either.
4676 It's confusing to put a bogus integer in a place where the actual
4677 value does not matter.
9f62aeb1 4678 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4679 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4680
15375a22
PE
4681 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4682 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4683 implementation.
b61cc01c
PE
4684 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4685 We prefer signed types, and the value cannot exceed the EMACS_INT
4686 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4687 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4688 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4689 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4690
53b2623d
PE
4691 * indent.c (sane_tab_width): New function.
4692 (current_column, scan_for_column, Findent_to, position_indentation)
4693 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4694 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4695
51cab52b 4696 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4697
f2ed8a70
PE
4698 * lisp.h (lint_assume): New macro.
4699 * composite.c (composition_gstring_put_cache):
4700 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4701
abe80cc6
PE
4702 * editfns.c, insdel.c:
4703 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4704
b02c740e
PE
4705 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4706
ebc96716
PE
4707 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4708
b4e50fa0 4709 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4710 Use much-faster test for byte-length change.
311d5d7c 4711 Don't assume string byte-length fits in 'int'.
a4cf38e4 4712 Check that character arg fits in 'int'.
85461888 4713 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4714
c0c1ee9f
PE
4715 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4716
a498d7f4
PE
4717 * fns.c (concat): Catch string overflow earlier.
4718 Do not rely on integer wraparound.
4719
51cab52b
PE
4720 * dispextern.h (struct it.overlay_strings_charpos)
4721 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4722 * xdisp.c (forward_to_next_line_start)
4723 (back_to_previous_visible_line_start)
4724 (reseat_at_next_visible_line_start, next_element_from_buffer):
4725 Don't arbitrarily truncate the value of 'selective' to int.
4726
76031fad
PE
4727 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4728
5eb55db9
PE
4729 * composite.c: Don't truncate sizes to 'int'.
4730 (composition_gstring_p, composition_reseat_it)
4731 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4732 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4733 not EMACS_UINT, for indexes.
5eb55db9 4734
0703a717
PE
4735 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4736
d6202519
PE
4737 * buffer.c: Include <verify.h>.
4738 (struct sortvec.priority, struct sortstr.priority):
8961a454 4739 Now EMACS_INT, not int.
c20998a7 4740 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4741 (struct sortstr.size, record_overlay_string)
4742 (struct sortstrlist.size, struct sortlist.used):
4743 Don't truncate size to int.
4744 (record_overlay_string): Check for size-calculation overflow.
d6202519 4745 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4746
d5a19415
JM
47472011-06-22 Jim Meyering <meyering@redhat.com>
4748
029529ac 4749 Don't leak an XBM-image-sized buffer
d5a19415
JM
4750 * image.c (xbm_load): Free the image buffer after using it.
4751
a9041e6c
PE
47522011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4753
4754 Port to Sun C.
4755 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4756 that Sun C diagnosed.
4757 * fns.c (secure_hash): Fix pointer signedness issue.
4758 * intervals.c (static_offset_intervals): New function.
4759 (offset_intervals): Use it.
4760
7f3f739f
LL
47612011-06-21 Leo Liu <sdl.web@gmail.com>
4762
4763 * deps.mk (fns.o):
4764 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4765 sha512.h.
4766
4767 * fns.c (secure_hash): Rename from crypto_hash_function and change
4768 the first arg to accept symbols.
5b66d427 4769 (Fsecure_hash): New primitive.
7f3f739f
LL
4770 (syms_of_fns): New symbols.
4771
76147d94
DD
47722011-06-20 Deniz Dogan <deniz@dogan.se>
4773
4774 * process.c (Fset_process_buffer): Clarify return value in
4775 docstring.
4776
7d7d0045
CY
47772011-06-18 Chong Yidong <cyd@stupidchicken.com>
4778
4779 * dispnew.c (add_window_display_history): Use BVAR.
4780
4781 * xdisp.c (debug_method_add): Use BVAR.
4782 (check_window_end, dump_glyph_matrix, dump_glyph)
4783 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4784
4785 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4786 Likewise.
4787
4788 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4789 check till after the cache is created in init_frame_faces.
4790
ff2bc410
SM
47912011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4792
4793 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4794
28177add
PE
47952011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4796
dd3482fe
PE
4797 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4798 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4799 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4800
393d71f3 4801 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4802 * fileio.c (Finsert_file_contents):
4803 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4804 Remove the old (too-loose) buffer overflow checks.
4805 They weren't needed, since make_gap checks for buffer overflow.
4806 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4807 The old code merely checked for Emacs fixnum overflow, and relied
4808 on undefined (wraparound) behavior. The new code avoids undefined
4809 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4810
2e6813b0 4811 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4812 Tune. Don't use wider integers than needed. Don't use alloca.
4813 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4814
599a9e4f
PE
4815 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4816
99561444
PE
4817 * insdel.c, lisp.h (buffer_overflow): New function.
4818 (insert_from_buffer_1, replace_range, replace_range_2):
4819 * insdel.c (make_gap_larger):
4820 * editfns.c (Finsert_char):
4821 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4822
28177add
PE
4823 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4824
e69dafad
PE
48252011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4826
4baa020d 4827 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4828
b1c46f02
PE
4829 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4830 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4831
e69dafad
PE
4832 * fileio.c: Don't assume EMACS_INT fits in off_t.
4833 (emacs_lseek): New static function.
4834 (Finsert_file_contents, Fwrite_region): Use it.
4835 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4836
566684ea
PE
4837 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4838
e6966cd6
PE
4839 * fns.c: Don't overflow int when computing a list length.
4840 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4841 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4842 truncation on 64-bit hosts. Check for QUIT every
4843 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4844 faster and is responsive enough.
4845 (Flength): Report an error instead of overflowing an integer.
4846 (Fsafe_length): Return a float if the value is not representable
4847 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4848 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4849 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4850
dd0b0efb
PE
4851 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4852 (header_size, word_size): New constants.
4853 (allocate_vectorlike): Don't check size overflow here.
4854 (allocate_vector): Check it here instead, since this is the only
4855 caller of allocate_vectorlike that could cause overflow.
4856 Check that the new vector's length is representable as a fixnum.
4857
86fe5cfe
PE
4858 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4859 The previous code was bogus. For example, next_almost_prime (32)
4860 returned 39, which is undesirable as it is a multiple of 3; and
4861 next_almost_prime (24) returned 25, which is a multiple of 5 so
4862 why was the code bothering to check for multiples of 7?
4863
80e88859
PE
4864 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4865
4a2f0ad6
PE
4866 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4867
f66c7cf8
PE
4868 Variadic C functions now count arguments with ptrdiff_t.
4869 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4870 Back then I didn't know that the Emacs coding style prefers signed int.
4871 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4872 were being counted with int, which may truncate counts on 64-bit
4873 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4874 * lisp.h (struct Lisp_Subr.function.aMANY)
4875 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4876 Arg counts are now ptrdiff_t, not size_t.
4877 All variadic functions and their callers changed accordingly.
4878 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4879 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4880 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4881 * callint.c (Fcall_interactively): Check arg count for overflow,
4882 to avoid potential buffer overrun. Use signed char, not 'int',
4883 for 'varies' array, so that we needn't bother to check its size
4884 calculation for overflow.
4885 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4886 * eval.c (apply_lambda):
4887 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4888 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4889 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4890
a1759b76
PE
4891 * callint.c (Fcall_interactively): Don't use index var as event count.
4892
d96be9fc
PE
4893 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4894 * mem-limits.h (SIZE): Remove; no longer used.
4895
a690a978 4896 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4897
578c21e6
PE
4898 Remove unnecessary casts.
4899 * xterm.c (x_term_init):
4900 * xfns.c (x_set_border_pixel):
4901 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4902 These aren't needed now that we assume ANSI C.
4903
96f53c6c
PE
4904 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4905 It's more likely to cause problems (due to unsigned overflow)
4906 than to cure them.
4907
83c77d31
PE
4908 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4909
ee2079f1
PE
4910 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4911
6da65536
PE
4912 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4913
7147c4a4
PE
4914 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4915
193e32d9
PE
4916 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4917
e5533da6
PE
4918 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4919
9910e595
PE
4920 GLYPH_CODE_FACE returns EMACS_INT, not int.
4921 * dispextern.h (merge_faces):
4922 * xfaces.c (merge_faces):
01103c44
PE
4923 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4924 Don't assume EMACS_INT fits in int.
9910e595 4925
2638320e
PE
4926 * character.h (CHAR_VALID_P): Remove unused parameter.
4927 * fontset.c, lisp.h, xdisp.c: All uses changed.
4928
045eb8d9
PE
4929 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4930
c1f134b5
PE
4931 * fns.c (concat): Minor tuning based on overflow analysis.
4932 This doesn't fix any bugs. Use int to hold character, instead
4933 of constantly refetching from Emacs object. Use XFASTINT, not
4934 XINT, for value known to be a character. Don't bother comparing
4935 a single byte to 0400, as it's always less.
4936
395fcb93 4937 * floatfns.c (Fexpt):
327eeec8
PE
4938 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4939
abbd3d23
PE
4940 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4941 for characters.
4942
684a03ef
PE
4943 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4944
0fed43f3
PE
4945 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4946 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4947 incorrectly succeed when S was a string, because 4294967386 was
4948 truncated before it was used.
4949
8fd02eb7
PE
4950 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4951 Otherwise, an out-of-range integer could cause undefined behavior
4952 on a 64-bit host.
4953
f8c86b69
PE
4954 * composite.c: Use int, not EMACS_INT, for characters.
4955 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4956 EMACS_INT, for values that are known to be in character range.
4957 This doesn't fix any bugs but is the usual style inside Emacs and
4958 may generate better code on 32-bit machines.
4959
34206dd2
PE
4960 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4961 This is for reasons similar to the recent CHAR_STRING fix.
4962 * charset.c (Fencode_char): Check that character arg is actually
4963 a character. Pass an int to ENCODE_CHAR.
4964 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4965 wider than 'int', as a compile-time check to prevent future regressions
4966 in this area.
4967
c5958d4c 4968 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4969
4970 Make sure a 64-bit char is never passed to CHAR_STRING.
4971 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4972 by silently ignoring the top 32 bits, allowing some values
4973 that were far too large to be valid characters.
4974 * character.h: Include <verify.h>.
4975 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4976 arguments are no wider than unsigned, as a compile-time check
4977 to prevent future regressions in this area.
4978 * data.c (Faset):
01103c44 4979 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4980 (Fsubst_char_in_region):
4981 * fns.c (concat):
4982 * xdisp.c (decode_mode_spec_coding):
4983 Adjust to CHAR_STRING's new requirement.
4984 * editfns.c (Finsert_char, Fsubst_char_in_region):
4985 * fns.c (concat): Check that character args are actually
4986 characters. Without this test, these functions did the wrong
4987 thing with wildly out-of-range values on 64-bit hosts.
4988
d37ca623
PE
4989 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4990 These casts should not be needed on 32-bit hosts, either.
4991 * keyboard.c (read_char):
4992 * lread.c (Fload): Remove casts to unsigned.
4993
ea204efb
PE
4994 * lisp.h (UNSIGNED_CMP): New macro.
4995 This fixes comparison bugs on 64-bit hosts.
4996 (ASCII_CHAR_P): Use it.
4997 * casefiddle.c (casify_object):
01103c44 4998 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4999 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5000 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5001 * dispextern.h (FACE_FROM_ID):
5002 * keyboard.c (read_char): Use UNSIGNED_CMP.
5003
41cb286c
PE
5004 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5005 not to EMACS_INT, to avoid GCC warning.
5006
4a1b9832
PE
5007 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5008
55daad71
PE
5009 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5010 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5011 isn't needed on 32-bit machines.
8f95c75c 5012
01103c44
PE
5013 * buffer.c (Fgenerate_new_buffer_name):
5014 Use EMACS_INT for count, not int.
0ceccced 5015 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5016
5017 * data.c (Qcompiled_function): Now static.
5018
c6f072e7
PE
5019 * window.c (window_body_lines): Now static.
5020
20ce5912
PE
5021 * image.c (gif_load): Rename local to avoid shadowing.
5022
9c4c5f81
PE
5023 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5024 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5025 * alloc.c (make_save_value): Integer argument is now of type
5026 ptrdiff_t, not int.
5027 (mark_object): Use ptrdiff_t, not int.
5028 * lisp.h (pD): New macro.
5029 * print.c (print_object): Use it.
5030
c0c5c8ae
PE
5031 * alloc.c: Use EMACS_INT, not int, to count objects.
5032 (total_conses, total_markers, total_symbols, total_vector_size)
5033 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5034 (total_free_floats, total_floats, total_free_intervals)
5035 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5036 Now EMACS_INT, not int. All uses changed.
5037 (Fgarbage_collect): Compute overall total using a double, so that
5038 integer overflow is less likely to be a problem. Check for overflow
5039 when converting back to an integer.
5a25e253
PE
5040 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5041 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5042 These were 'int' variables that could overflow on 64-bit hosts;
5043 they were never used, so remove them instead of repairing them.
211a0b2a 5044 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5045 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5046 Previously, this ceilinged at INT_MAX, but that doesn't work on
5047 64-bit machines.
e46bb31a 5048 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5049
c78baabf 5050 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5051 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5052 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5053 when a (possibly-narrower) signed value would do just as well.
5054 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5055
c9d624c6
PE
5056 * alloc.c: Catch some string size overflows that we were missing.
5057 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5058 for convenience in STRING_BYTES_MAX.
5059 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5060 The definition here is exact; the one in lisp.h was approximate.
5061 (allocate_string_data): Check for string overflow. This catches
5062 some instances we weren't catching before. Also, it catches
5063 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5064 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5065 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5066
c9d624c6
PE
5067 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5068 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5069 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5070
353032ce
PE
5071 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5072
2bccce07
PE
5073 * alloc.c (Fmake_string): Check for out-of-range init.
5074
0ac30604
SM
50752011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5076
5077 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5078
c195f2de
JD
50792011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5080
5081 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5082 xg_get_default_scrollbar_width.
5083
5084 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5085 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5086 (style_changed_cb): Call update_theme_scrollbar_width and call
5087 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5088 all frames (Bug#8505).
5089 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5090 Call gtk_window_set_resizable if HAVE_GTK3.
5091 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5092 and height if HAVE_GTK3 (Bug#8505).
5093 (scroll_bar_width_for_theme): New variable.
5094 (update_theme_scrollbar_width): New function.
5095 (xg_get_default_scrollbar_width): Move code to
5096 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5097 (xg_initialize): Call update_theme_scrollbar_width.
5098
5099 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5100
5101 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5102
e10ac9f1
MR
51032011-06-12 Martin Rudalics <rudalics@gmx.at>
5104
5105 * frame.c (make_frame): Call other_buffer_safely instead of
5106 other_buffer.
5107
5108 * window.c (temp_output_buffer_show): Call display_buffer with
5109 second argument Vtemp_buffer_show_specifiers and reset latter
5110 immediately after the call.
5111 (Vtemp_buffer_show_specifiers): New variable.
5112 (auto_window_vscroll_p, next_screen_context_lines)
5113 (Vscroll_preserve_screen_position): Remove leading asterisks from
5114 doc-strings.
5115
2d3c217e 51162011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5117
7b7f97e8 5118 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5119 * buffer.c (Qclone_number): Remove for now, as it's unused.
5120 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5121 (record_buffer): Remove unused local.
5122 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5123 (set_frame_buffer_list): Remove; unused.
5124 * frame.h (other_visible_frames): Remove decl.
5125 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5126 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5127 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5128 if HAVE_GPM.
5129 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5130 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5131 Define only if HAVE_GPM.
5132 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5133 (update_hints_inhibit): Remove; never set. All uses removed.
5134 * widgetprv.h (emacsFrameClassRec): Remove decl.
5135 * window.c (delete_deletable_window): Now returns void, since it
5136 wasn't returning anything.
5137 (compare_window_configurations): Remove unused locals.
5138 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5139 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5140 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5141 the same widths as pointers. This follows up on the 2011-05-06 patch.
5142 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5143 * xterm.h: Likewise.
5144 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5145
1384b89e
JB
51462011-06-12 Juanma Barranquero <lekktu@gmail.com>
5147
5148 * makefile.w32-in: Update dependencies.
5149 (LISP_H): Add lib/intprops.h.
5150
1100a63c
CY
51512011-06-11 Chong Yidong <cyd@stupidchicken.com>
5152
5153 * image.c (gif_load): Add animation frame delay to the metadata.
5154 (syms_of_image): Use DEFSYM. New symbol `delay'.
5155
6198ccd0
MR
51562011-06-11 Martin Rudalics <rudalics@gmx.at>
5157
5158 * window.c (delete_deletable_window): Re-add.
5159 (Fset_window_configuration): Rewrite to handle dead buffers and
5160 consequently deletable windows.
5161 (window_tree, Fwindow_tree): Remove. Supply functionality in
5162 window.el.
5163 (compare_window_configurations): Simplify code.
5164
b6e3633c
AS
51652011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5166
1ab0dee5
AS
5167 * image.c (imagemagick_load_image): Fix type mismatch.
5168 (Fimagemagick_types): Likewise.
5169
b6e3633c
AS
5170 * window.h (replace_buffer_in_windows): Declare.
5171
9397e56f
MR
51722011-06-11 Martin Rudalics <rudalics@gmx.at>
5173
5174 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5175 Qclone_number. Remove external declaration of Qdelete_window.
5176 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5177 code.
640c8776
SM
5178 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5179 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5180 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5181 buffer list implementation.
5182 (other_buffer_safely): New function.
5183 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5184 calls to replace_buffer_in_windows and
5185 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5186 if allowed.
5187 (record_buffer): Inhibit quitting and rewrite using quittable
5188 functions. Run Qbuffer_list_update_hook if allowed.
5189 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5190 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5191 Move switch-to-buffer to window.el.
9397e56f
MR
5192 (bury-buffer): Move to window.el.
5193 (Vbuffer_list_update_hook): New variable.
5194
5195 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5196 section.
5197
5198 * window.h (resize_frame_windows): Move up in code.
5199 (Fwindow_frame): Remove EXFUN.
5200 (replace_buffer_in_all_windows): Remove prototype.
5201 (replace_buffer_in_windows_safely): Add prototype.
5202
5203 * window.c: Declare Qdelete_window static again. Move down
5204 declaration of select_count.
5205 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5206 (Fother_window): Move to window.el.
5207 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5208 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5209 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5210 window.el.
5211 (replace_buffer_in_windows): Implement by calling
5212 Qreplace_buffer_in_windows.
5213 (replace_buffer_in_all_windows): Remove with some functionality
5214 moved into replace_buffer_in_windows_safely.
5215 (replace_buffer_in_windows_safely): New function.
5216 (select_window_norecord, select_frame_norecord): Move in front
5217 of run_window_configuration_change_hook. Remove now obsolete
5218 declarations.
640c8776
SM
5219 (Fset_window_buffer): Rewrite doc-string.
5220 Call Qrecord_window_buffer.
9397e56f
MR
5221 (keys_of_window): Move binding for other-window to window.el.
5222
b50691aa
CY
52232011-06-11 Chong Yidong <cyd@stupidchicken.com>
5224
5225 * dispextern.h (struct image): Replace data member, whose int_val
5226 and ptr_val fields were not used by anything, with a single
5227 lisp_val object.
5228
5229 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5230 (gif_clear_image, gif_load, imagemagick_load_image)
5231 (gs_clear_image, gs_load): Callers changed.
5232
3f754b86
PE
52332011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5234
cca69397
PE
5235 * buffer.h: Include <time.h>, for time_t.
5236 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5237
109e28d0
PE
5238 Fix minor problems found by static checking.
5239
60737f02
PE
5240 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5241
4b66faf3
PE
5242 Make identifiers static if they are not used in other modules.
5243 * data.c (Qcompiled_function, Qframe, Qvector):
5244 * image.c (QimageMagick, Qsvg):
5245 * minibuf.c (Qmetadata):
5246 * window.c (resize_window_check, resize_root_window): Now static.
5247 * window.h (resize_window_check, resize_root_window): Remove decls.
5248
109e28d0
PE
5249 * window.c (window_deletion_count, delete_deletable_window):
5250 Remove; unused.
46a4ce9e
PE
5251 (window_body_lines): Now static.
5252 (Fdelete_other_windows_internal): Mark vars as initialized.
5253 Make sure 'resize_failed' is initialized.
5254 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5255 (resize_window_apply): Remove unused local.
5256 * window.h (delete_deletable_window): Remove decl.
5257
109e28d0 5258 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5259 (imagemagick_load_image): Fix pointer signedness problem by changing
5260 last arg from unsigned char * to char *. All uses changed.
5261 Also, fix a local for similar reasons.
5262 Remove unused locals. Remove locals to avoid shadowing.
5263 (fn_rsvg_handle_free): Remove; unused.
5264 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5265 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5266
3f754b86
PE
5267 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5268
2547adb1
CY
52692011-06-10 Chong Yidong <cyd@stupidchicken.com>
5270
5271 * image.c (gif_load): Fix omitted cast error introduced by
5272 2011-06-06 change.
5273
2c8e37d4
MR
52742011-06-10 Martin Rudalics <rudalics@gmx.at>
5275
5276 * window.h (resize_proportionally, orig_total_lines)
5277 (orig_top_line): Remove from window structure.
5278 (set_window_height, set_window_width, change_window_heights)
5279 (Fdelete_window): Remove prototypes.
5280 (resize_frame_windows): Remove duplicate declaration.
5281
440a42e3
EZ
52822011-06-10 Eli Zaretskii <eliz@gnu.org>
5283
5284 * window.h (resize_frame_windows, resize_window_check)
5285 (delete_deletable_window, resize_root_window)
5286 (resize_frame_windows): Declare prototypes.
5287
5288 * window.c (resize_window_apply): Make definition be "static" to
5289 match the prototype.
5290
562dd5e9
MR
52912011-06-10 Martin Rudalics <rudalics@gmx.at>
5292
5293 * window.c: Remove declarations of Qwindow_size_fixed,
5294 window_min_size_1, window_min_size_2, window_min_size,
5295 size_window, window_fixed_size_p, enlarge_window, delete_window.
5296 Remove static from declaration of Qdelete_window, it's
5297 temporarily needed by Fbury_buffer.
5298 (replace_window): Don't assign orig_top_line and
5299 orig_total_lines.
5300 (Fdelete_window, delete_window): Remove. Window deletion is
5301 handled by window.el.
640c8776
SM
5302 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5303 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5304 (Fdelete_other_windows): Remove. Deleting other windows is
5305 handled by window.el.
5306 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5307 handled in window.el.
5308 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5309 Window minimum sizes are handled in window.el.
5310 (shrink_windows, size_window, set_window_height)
5311 (set_window_width, change_window_heights, window_height)
5312 (window_width, CURBEG, CURSIZE, enlarge_window)
5313 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5314 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5315 handled in window.el.
5316 (make_dummy_parent): Rename to make_parent_window and give it a
5317 second argument horflag.
5318 (make_window): Don't set resize_proportionally any more.
5319 (Fsplit_window): Remove. Windows are split in window.el.
5320 (save_restore_action, save_restore_orig_size)
5321 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5322 Resize mini windows in window.el.
5323 (grow_mini_window, shrink_mini_window): Implement by calling
5324 Qresize_root_window_vertically, resize_window_check and
5325 resize_window_apply.
640c8776
SM
5326 (saved_window, Fset_window_configuration, save_window_save):
5327 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5328 resize_proportionally.
5329 (window_min_height, window_min_width): Move to window.el.
5330 (keys_of_window): Move bindings for delete-other-windows,
5331 split-window, delete-window and enlarge-window to window.el.
5332
5333 * buffer.c: Temporarily extern Qdelete_window.
5334 (Fbury_buffer): Temporarily call Qdelete_window instead of
5335 Fdelete_window (Fbury_buffer will move to window.el soon).
5336
5337 * frame.c (set_menu_bar_lines_1): Remove code handling
5338 orig_top_line and orig_total_lines.
5339
5340 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5341 set_window_height but set heights directly.
5342 (change_frame_size_1): Use resize_frame_windows.
5343
5344 * xdisp.c (init_xdisp): Don't use set_window_height but set
5345 heights directly.
5346
640c8776
SM
5347 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5348 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5349 run_window_configuration_change_hook.
5350
5351 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5352 instead of change_window_heights and run
5353 run_window_configuration_change_hook.
5354
1a13852e
MR
53552011-06-09 Martin Rudalics <rudalics@gmx.at>
5356
5357 * window.c (replace_window): Rename second argument REPLACEMENT to
5358 NEW. New third argument SETFLAG. Rewrite.
5359 (delete_window, make_dummy_parent): Call replace_window with
5360 third argument 1.
5361 (window_list_1): Move down in code.
5362 (run_window_configuration_change_hook): Move set_buffer part
5363 before select_frame_norecord part in order to unwind correctly.
5364 Rename count1 to count.
5365 (recombine_windows, delete_deletable_window, resize_root_window)
5366 (Fdelete_other_windows_internal)
5367 (Frun_window_configuration_change_hook, make_parent_window)
5368 (resize_window_check, resize_window_apply, Fresize_window_apply)
5369 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5370 (Fdelete_window_internal, Fresize_mini_window_internal):
5371 New functions.
1a13852e
MR
5372 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5373
f3d1777e
MR
53742011-06-08 Martin Rudalics <rudalics@gmx.at>
5375
496e208e
MR
5376 * window.h (window): Add some new members to window structure -
5377 normal_lines, normal_cols, new_total, new_normal, clone_number,
5378 splits, nest, prev_buffers, next_buffers.
5379 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5380 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5381
f3d1777e
MR
5382 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5383 Remove.
496e208e
MR
5384 (make_dummy_parent): Set new members of windows structure.
5385 (make_window): Move down in code. Handle new members of window
5386 structure.
5387 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5388 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5389 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5390 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5391 (Fset_window_next_buffers, Fset_window_clone_number):
5392 New functions.
496e208e
MR
5393 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5394 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5395 Doc-string fixes.
5396 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5397 Argument WINDOW can be now internal window too.
5398 (Fwindow_use_time): Move up in code.
5399 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5400 Rewrite doc-string.
5401 (Fset_window_configuration, saved_window)
5402 (Fcurrent_window_configuration, save_window_save): Handle new
5403 members of window structure.
b9e809c2
MR
5404 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5405 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5406 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5407 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5408 Qget_mru_window, Qresize_root_window,
5409 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5410 Qauto_buffer_name; staticpro them.
f3d1777e 5411
abde8f8c
MR
54122011-06-07 Martin Rudalics <rudalics@gmx.at>
5413
5414 * window.c (Fwindow_total_size, Fwindow_left_column)
5415 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5416 (Fwindow_list_1): New functions.
5417 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5418 (Fwindow_width, Fscroll_left, Fscroll_right):
5419 Use window_body_cols instead of window_box_text_cols.
5420 (delete_window, Fset_window_configuration):
5421 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5422 (delete_all_subwindows): Take a window as argument and not a
5423 structure. Rewrite.
190b47e6
MR
5424 (window_loop): Remove handling of GET_LRU_WINDOW and
5425 GET_LARGEST_WINDOW.
5426 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5427
5428 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5429 window_box_text_cols. delete_all_subwindows now takes a
5430 Lisp_Object as argument.
abde8f8c 5431
640c8776
SM
5432 * indent.c (compute_motion, Fcompute_motion):
5433 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5434
fa8a67e6
MR
5435 * frame.c (delete_frame): Call delete_all_subwindows with root
5436 window as argument.
5437
a54e3482
DC
54382011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5439
5440 * fns.c (Fputhash): Document return value.
5441
60002bf5
CY
54422011-06-06 Chong Yidong <cyd@stupidchicken.com>
5443
5444 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5445
0c671da6 54462011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5447
b862a52a 5448 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5449
be44ca6c
PE
5450 Check for overflow when converting integer to cons and back.
5451 * charset.c (Fdefine_charset_internal, Fdecode_char):
5452 Use cons_to_unsigned to catch overflow.
5453 (Fencode_char): Use INTEGER_TO_CONS.
5454 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5455 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5456 * data.c (long_to_cons, cons_to_long): Remove.
5457 (cons_to_unsigned, cons_to_signed): New functions.
5458 These signal an error for invalid or out-of-range values.
5459 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5460 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5461 * font.c (Ffont_variation_glyphs):
5462 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5463 * lisp.h: Include <intprops.h>.
5464 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5465 (cons_to_signed, cons_to_unsigned): New decls.
5466 (long_to_cons, cons_to_long): Remove decls.
5467 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5468 (Fprimitive_undo): Use CONS_TO_INTEGER.
5469 * xfns.c (Fx_window_property): Likewise.
5470 * xselect.c: Include <limits.h>.
5471 (x_own_selection, selection_data_to_lisp_data):
5472 Use INTEGER_TO_CONS.
5473 (x_handle_selection_request, x_handle_selection_clear)
5474 (x_get_foreign_selection, Fx_disown_selection_internal)
5475 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5476 (lisp_data_to_selection_data): Use cons_to_unsigned.
5477 (x_fill_property_data): Use cons_to_signed.
5478 Report values out of range.
5479
d1f3d2af
PE
5480 Check for buffer and string overflow more precisely.
5481 * buffer.h (BUF_BYTES_MAX): New macro.
5482 * lisp.h (STRING_BYTES_MAX): New macro.
5483 * alloc.c (Fmake_string):
5484 * character.c (string_escape_byte8):
5485 * coding.c (coding_alloc_by_realloc):
5486 * doprnt.c (doprnt):
5487 * editfns.c (Fformat):
5488 * eval.c (verror):
5489 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5490 since they may not be the same number.
5491 * editfns.c (Finsert_char):
5492 * fileio.c (Finsert_file_contents):
5493 Likewise for BUF_BYTES_MAX.
5494
dd52fcea
PE
5495 * image.c: Use ptrdiff_t, not int, for sizes.
5496 (slurp_file): Switch from int to ptrdiff_t.
5497 All uses changed.
5498 (slurp_file): Check that file size fits in both size_t (for
5499 malloc) and ptrdiff_t (for sanity and safety).
5500
7f9bbdbb
PE
5501 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5502 if b->modtime has its maximal value.
5503
dfe18f82
PE
5504 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5505
84acfcf0
PE
5506 Don't assume time_t can fit into int.
5507 * buffer.h (struct buffer.modtime): Now time_t, not int.
5508 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5509 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5510
ccd9a01a
PE
5511 Minor fixes for signed vs unsigned integers.
5512 * character.h (MAYBE_UNIFY_CHAR):
5513 * charset.c (maybe_unify_char):
5514 * keyboard.c (read_char, reorder_modifiers):
5515 XINT -> XFASTINT, since the integer must be nonnegative.
5516 * ftfont.c (ftfont_spec_pattern):
5517 * keymap.c (access_keymap, silly_event_symbol_error):
5518 XUINT -> XFASTINT, since the integer must be nonnegative.
5519 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5520 since it makes no difference and we prefer signed.
5521 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5522 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5523 nonnegative.
5524
d6d100dd
SM
55252011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5526
5527 * window.h (Fwindow_frame): Declare.
5528
2b6148e4
PE
55292011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5530
5531 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5532 (SPARE_MEMORY): Always define.
5533 (LARGE_REQUEST): Remove.
5534 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5535
f230ecc9
MR
55362011-06-06 Martin Rudalics <rudalics@gmx.at>
5537
727e958e
MR
5538 * lisp.h: Move EXFUNS for Fframe_root_window,
5539 Fframe_first_window and Fset_frame_selected_window to window.h.
5540
5541 * window.h: Move EXFUNS for Fframe_root_window,
5542 Fframe_first_window and Fset_frame_selected_window here from
5543 lisp.h.
5544
5545 * frame.c (Fwindow_frame, Fframe_first_window)
5546 (Fframe_root_window, Fframe_selected_window)
5547 (Fset_frame_selected_window): Move to window.c.
5548 (Factive_minibuffer_window): Move to minibuf.c.
5549 (Fother_visible_frames_p): New function.
5550
5551 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5552
f230ecc9
MR
5553 * window.c (decode_window, decode_any_window): Move up in code.
5554 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5555 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5556 (Fwindow_buffer): Move up and rewrite doc-string.
5557 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5558 (Fwindow_prev): New functions.
727e958e
MR
5559 (Fwindow_frame): Move here from frame.c. Accept any window as
5560 argument.
5561 (Fframe_root_window, Fframe_first_window)
5562 (Fframe_selected_window): Move here from frame.c. Accept frame
5563 or arbitrary window as argument. Update doc-strings.
5564 (Fminibuffer_window): Move up in code.
5565 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5566 (Fset_frame_selected_window): Move here from frame.c.
5567 Marginal rewrite.
727e958e
MR
5568 (Fselected_window, select_window, Fselect_window): Move up in
5569 code. Minor doc-string fixes.
f230ecc9 5570
4d09bcf6
PE
55712011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5572
5573 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5574 Do not assume that spare memory exists; that assumption is valid
5575 only if SYSTEM_MALLOC.
5576 (LARGE_REQUEST): New macro, so that the issue of large requests
5577 is separated from the issue of spare memory.
5578
810928a2
AS
55792011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5580
172418ad
AS
5581 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5582 format. (Bug#8806)
5583
43f862f7
AS
5584 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5585
810928a2
AS
5586 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5587 before statements.
5588
a059fe24
JD
55892011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5590
5591 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5592
5593 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5594
5595 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5596 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5597
989bf368
JB
55982011-06-05 Juanma Barranquero <lekktu@gmail.com>
5599
5600 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5601
4b80f674
CY
56022011-06-04 Chong Yidong <cyd@stupidchicken.com>
5603
5604 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5605 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5606 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5607 New error handlers.
4b80f674
CY
5608 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5609 Obey Vx_select_enable_clipboard_manager. Catch errors in
5610 x_clipboard_manager_save (Bug#8779).
5611 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5612 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5613
99a33b77 56142011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5615
5616 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5617
99a33b77 56182011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5619
5620 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5621 in the current matrix if keep_current_p is non-zero.
5622
8264569d
EZ
56232011-06-04 Eli Zaretskii <eliz@gnu.org>
5624
5625 * bidi.c (bidi_level_of_next_char): Fix last change.
5626
57f97249
EZ
56272011-06-03 Eli Zaretskii <eliz@gnu.org>
5628
fec2107c 5629 Support bidi reordering of text covered by display properties.
57f97249 5630
fec2107c
EZ
5631 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5632 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5633 (bidi_cache_search, bidi_cache_iterator_state)
5634 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5635 (bidi_level_of_next_char, bidi_move_to_visually_next):
5636 Support character positions inside a run of characters covered by a
fec2107c
EZ
5637 display string.
5638 (bidi_paragraph_init, bidi_resolve_explicit_1)
5639 (bidi_level_of_next_char): Call bidi_fetch_char and
5640 bidi_fetch_char_advance instead of FETCH_CHAR and
5641 FETCH_CHAR_ADVANCE.
5642 (bidi_init_it): Initialize new members.
5643 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5644 definitions.
5645 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5646 instead of using explicit *_CHAR codes.
d6d100dd
SM
5647 (bidi_resolve_explicit, bidi_resolve_weak):
5648 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5649 bidirectional text is supported only in multibyte buffers.
5650 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5651 it to initialize the frame_window_p member of struct bidi_it.
5652 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5653 (bidi_resolve_explicit, bidi_resolve_weak)
5654 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5655 bidi_it->nchars is non-positive.
5656 (bidi_level_of_next_char): Don't try to lookup the cache for the
5657 next/previous character if nothing is cached there yet, or if we
5658 were just reseat()'ed to a new position.
c40e2fb2 5659
0e14fe90
EZ
5660 * xdisp.c (set_cursor_from_row): Set start and stop points
5661 according to the row's direction when priming the loop that looks
5662 for the glyph on which to display cursor.
5663 (single_display_spec_intangible_p): Function deleted.
5664 (display_prop_intangible_p): Reimplement to call
5665 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5666 Accept 3 additional arguments needed by handle_display_spec.
5667 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5668 values: lists, `(when COND...)' forms, etc.
5669 (single_display_spec_string_p): Support property values that are
5670 lists with the argument STRING its top-level element.
5671 (display_prop_string_p): Fix the condition for processing a
5672 property that is a list to be consistent with handle_display_spec.
fec2107c 5673 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5674 last portion of handle_display_prop.
5675 (compute_display_string_pos): Accept additional argument
5676 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5677 value of a `display' property is a "replacing spec".
5678 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5679 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5680 the display property, but just return a value indicating whether
5681 the display property will replace the characters it covers.
5682 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5683 frame_window_p members of struct bidi_it.
d6d100dd
SM
5684 (compute_display_string_pos, compute_display_string_end):
5685 New functions.
fec2107c
EZ
5686 (push_it): Accept second argument POSITION, where pop_it should
5687 jump to continue iteration.
5688 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5689
fec2107c
EZ
5690 * keyboard.c (adjust_point_for_property): Adjust the call to
5691 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5692
5693 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5694 (bidi_init_it): Update prototypes.
5695 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5696 (compute_display_string_pos, compute_display_string_end):
5697 Declare prototypes.
fec2107c
EZ
5698 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5699 EMACS_INT.
fc6f18ce 5700
40087514 57012011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5702
57f53182
PE
5703 Malloc failure behavior now depends on size of allocation.
5704 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5705 * lisp.h: Change signatures accordingly.
5706 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5707 All callers changed. (Bug#8762)
5708
5709 * gnutls.c: Use Emacs's memory allocators.
5710 Without this change, the gnutls library would invoke malloc etc.
5711 directly, which causes problems on non-SYNC_INPUT hosts, and which
5712 runs afoul of improving memory_full behavior. (Bug#8761)
5713 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5714 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5715 xfree instead of the default malloc, realloc, free.
5716 (Fgnutls_boot): No need to check for memory allocation failure,
5717 since xmalloc does that for us.
5718
ac32cd99 5719 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5720 * category.c (hash_get_category_set):
5721 * ccl.c (ccl_driver):
5722 * charset.c (Fdefine_charset_internal):
5723 * charset.h (struct charset.hash_index):
5724 * composite.c (get_composition_id, gstring_lookup_cache)
5725 (composition_gstring_put_cache):
5726 * composite.h (struct composition.hash_index):
5727 * dispextern.h (struct image.hash):
5728 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5729 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5730 (hashfn_equal, hashfn_user_defined, make_hash_table)
5731 (maybe_resize_hash_table, hash_lookup, hash_put)
5732 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5733 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5734 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5735 * image.c (make_image, search_image_cache, lookup_image)
5736 (xpm_put_color_table_h):
5737 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5738 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5739 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5740 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5741 * alloc.c (allocate_vectorlike):
5742 Check for overflow in vector size calculations.
5743 * ccl.c (ccl_driver):
5744 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5745 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5746 need to be updated by these changes.
40087514
PE
5747 * fns.c (make_hash_table, maybe_resize_hash_table):
5748 Check for integer overflow with large hash tables.
0de4bb68
PE
5749 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5750 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5751 (SXHASH_REDUCE): New macro.
5752 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5753 Use it instead of discarding useful hash info with large hash values.
5754 (sxhash_float): New function.
5755 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5756 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5757 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5758 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5759 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5760 Adjust signatures to match updated version of code.
5761 (consing_since_gc): Now EMACS_INT, since a single hash table can
5762 use more than INT_MAX bytes.
5763
698d32e2
DN
57642011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5765
5766 Make it possible to build with GCC-4.6+ -O2 -flto.
5767
5768 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5769
fd6fa53f
SM
57702011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5771
5772 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5773 Call minibuffer-inactive-mode.
5774
864db017
JB
57752011-05-31 Juanma Barranquero <lekktu@gmail.com>
5776
5777 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5778 Update dependencies.
5779
2ad0baf4
DN
57802011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5781
5782 * data.c (init_data): Remove code for UTS, this system is not
5783 supported anymore.
5784
4fcc2638
DN
57852011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5786
5787 Don't force ./temacs to start in terminal mode.
5788
5789 * frame.c (make_initial_frame): Initialize faces in all cases, not
5790 only when CANNOT_DUMP is defined.
5791 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5792
c56e0fd5
DN
57932011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5794
5795 * dispnew.c (add_window_display_history): Use const for the string
5796 pointer. Remove declaration, not needed.
5797
333d54da 57982011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5799
55d4c1b2 5800 Use 'inline', not 'INLINE'.
333d54da 5801 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5802 * alloc.c, fontset.c (INLINE): Remove.
5803 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5804 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5805 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5806 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5807 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5808
738db178
DN
58092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5810
5811 Make it possible to run ./temacs.
5812
5813 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5814 syms_of_callproc does the same thing. Remove test for
5815 "initialized", do it in the caller.
5816 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5817
620c53a6
SM
58182011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5819
5820 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5821 (read_minibuf): Use get_minibuffer.
5822 (syms_of_minibuf): Use DEFSYM.
5823 (Qmetadata): New var.
5824 * data.c (Qbuffer): Don't make it static.
5825 (syms_of_data): Use DEFSYM.
5826
e003a292
PE
58272011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5828
5829 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5830 (CCL_CODE_MIN): New macro.
5831
ed008a6d
PE
58322011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5833
3687c2ef
PE
5834 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5835
ed008a6d
PE
5836 * eval.c (Qdebug): Now static.
5837 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5838 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5839 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5840
d66c4c7c
CY
58412011-05-29 Chong Yidong <cyd@stupidchicken.com>
5842
5843 * image.c: Various fixes to ImageMagick code comments.
5844 (Fimagemagick_types): Doc fix.
5845
5fbc2025
PE
58462011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5847
0196f88a
PE
5848 Minor fixes prompted by GCC 4.6.0 warnings.
5849
5850 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5851
5fbc2025
PE
5852 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5853 (x_clipboard_manager_save_all): Move extern decl to ...
5854 * xterm.h: ... here, so that it can be checked for consistency.
5855
1dd3c2d9
CY
58562011-05-29 Chong Yidong <cyd@stupidchicken.com>
5857
5858 * xselect.c (x_clipboard_manager_save_frame)
5859 (x_clipboard_manager_save_all): New functions.
5860 (Fx_clipboard_manager_save): Lisp function deleted.
5861
5862 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5863 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5864
5865 * xterm.h: Update prototype.
5866
5ba6571d
WX
58672011-05-28 William Xu <william.xwl@gmail.com>
5868
5869 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5870 exiting (Bug#8239).
5871
3eaff834
JM
58722011-05-28 Jim Meyering <meyering@redhat.com>
5873
e1900994 5874 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5875 * fns.c (to_uchar): Define.
5876 (crypto_hash_function): Use it to convert some newly-signed
5877 variables to unsigned, to avoid sign-extension bugs. For example,
5878 without this change, (md5 "truc") would evaluate to
5879 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5880 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5881 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5882
0f6990a7
PE
58832011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5884
5885 Integer overflow fixes.
c8a9ca5a 5886
08686060
PE
5887 * dbusbind.c: Serial number integer overflow fixes.
5888 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5889 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5890 to hold a serial number that is too large for a fixnum.
5891 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5892 Check for serial numbers out of range. Decode any serial number
59568bf0 5893 that was so large that it became a float. (Bug#8722)
08686060 5894
2d1fc3c7
PE
5895 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5896 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5897 Use XFASTINT rather than XUINT when numbers are nonnegative.
5898 (xd_append_arg, Fdbus_method_return_internal):
5899 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5900 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5901 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5902 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5903 (Bug#8722)
2d1fc3c7 5904
c8a9ca5a
PE
5905 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5906
519e1d69
PE
5907 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5908
6df6ae42 5909 ccl: Add integer overflow checks.
30569699
PE
5910 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5911 (IN_INT_RANGE): New macros.
5912 (ccl_driver): Use them to check for integer overflow when
5913 decoding a CCL program. Many of the new checks are whether XINT (x)
5914 fits in int; it doesn't always, on 64-bit hosts. The new version
5915 doesn't catch all possible integer overflows, but it's an
847044ea 5916 improvement. (Bug#8719)
30569699 5917
c11285dc
PE
5918 * alloc.c (make_event_array): Use XINT, not XUINT.
5919 There's no need for unsigned here.
5920
fdccd48e
PE
5921 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5922 This follows up to the 2011-05-06 change that substituted uintptr_t
5923 for EMACS_INT. This case wasn't caught back then.
5924
37910ab2
PE
5925 Rework Fformat to avoid integer overflow issues.
5926 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5927 now (part of C89). Include <verify.h>.
5928 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5929 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5930 (Fformat): Avoid the prepass trying to compute sizes; it was only
5931 approximate and thus did not catch overflow reliably. Instead, walk
5932 through the format just once, formatting and computing sizes as we go,
5933 checking for integer overflow at every step, and allocating a larger
5934 buffer as needed. Keep track separately whether the format is
5935 multibyte. Keep only the most-recently calculated precision, rather
5936 than them all. Record whether each argument has been converted to
5937 string. Use EMACS_INT, not int, for byte and char and arg counts.
5938 Support field widths and precisions larger than INT_MAX. Avoid
5939 sprintf's undefined behavior with conversion specifications such as %#d
5940 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5941 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5942 formatting out-of-range floating point numbers with int
9173deec 5943 formats. (Bug#8668)
37910ab2 5944
2e6578fb
PE
5945 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5946
0ae6bdee
PE
5947 * data.c: Avoid integer truncation in expressions involving floats.
5948 * data.c: Include <intprops.h>.
5949 (arith_driver): When there's an integer overflow in an expression
5950 involving floating point, convert the integers to floating point
5951 so that the resulting value does not suffer from catastrophic
5952 integer truncation. For example, on a 64-bit host (* 4
5953 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5954 Do not rely on undefined behavior after integer overflow.
5955
de883a70
PE
5956 merge count_size_as_multibyte, parse_str_to_multibyte
5957 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5958 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5959 Check for integer overflow.
5960 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5961 since it's now a duplicate of the other. This is more of
5962 a character than a buffer op, so better that it's in character.c.
5963 * fns.c, print.c: Adjust to above changes.
5964
2ff916cb
PE
59652011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5966
5967 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5968
f1b54466
PE
59692011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5970
fb1ac845
PE
5971 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5972 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5973 (x_clipboard_manager_save): Now static.
5974 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5975
f1b54466
PE
5976 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5977 (crypto_hash_function): Now static.
5978 Fix pointer signedness problems. Avoid unnecessary initializations.
5979
a9f737ee
CY
59802011-05-27 Chong Yidong <cyd@stupidchicken.com>
5981
5982 * termhooks.h (Vselection_alist): Make it terminal-local.
5983
5984 * terminal.c (create_terminal): Initialize it.
5985
5986 * xselect.c: Support for clipboard managers.
5987 (Vselection_alist): Move to termhooks.h as terminal-local var.
5988 (LOCAL_SELECTION): New macro.
5989 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5990 (symbol_to_x_atom): Remove gratuitous arg.
5991 (x_handle_selection_request, lisp_data_to_selection_data)
5992 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5993 (x_own_selection, x_get_local_selection, x_convert_selection):
5994 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5995 (some_frame_on_display): Delete unused function.
5996 (Fx_own_selection_internal, Fx_get_selection_internal)
5997 (Fx_disown_selection_internal, Fx_selection_owner_p)
5998 (Fx_selection_exists_p): New optional frame arg.
5999 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6000 (x_handle_selection_clear): Don't treat other terminals with the
6001 same keyboard specially. Use the terminal-local Vselection_alist.
6002 (x_clear_frame_selections): Use Frun_hook_with_args.
6003
6004 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6005
6006 * xterm.h: Add support for those atoms.
6007
e067f0c1
CY
60082011-05-26 Chong Yidong <cyd@stupidchicken.com>
6009
6010 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6011 (converted_selections, conversion_fail_tag): New global variables.
6012 (x_selection_request_lisp_error): Free the above.
6013 (x_get_local_selection): Remove unnecessary code.
6014 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6015 of converted selections stored in converted_selections.
6016 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6017 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6018 (x_convert_selection): New function.
6019 (x_handle_selection_event): Simplify.
6020 (x_get_foreign_selection): Don't ignore incoming requests while
6021 waiting for an answer; this will fail when we implement
6022 SAVE_TARGETS, and seems unnecessary anyway.
6023 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6024 (Vx_sent_selection_functions): Doc fix.
6025
0f4aebc0
LL
60262011-05-26 Leo Liu <sdl.web@gmail.com>
6027
6028 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6029
e61124cd
YM
60302011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6031
6032 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6033
6034 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6035 for fringe update if it has periodic bitmap.
ac389d0c 6036 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6037 and fringe_bitmap_periodic_p.
6038
6039 * fringe.c (get_fringe_bitmap_data): New function.
6040 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6041 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6042 row. Mark glyph row for fringe update if periodicity changed.
6043
6044 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6045 for fringe update unless it has periodic bitmap.
6046
f16d9837
KH
60472011-05-25 Kenichi Handa <handa@m17n.org>
6048
6049 * xdisp.c (get_next_display_element): Set correct it->face_id for
6050 a static composition.
6051
e1b90ef6
LL
60522011-05-24 Leo Liu <sdl.web@gmail.com>
6053
6054 * deps.mk (fns.o):
6055 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6056
6057 * fns.c (crypto_hash_function, Fsha1): New function.
6058 (Fmd5): Use crypto_hash_function.
6059 (syms_of_fns): Add Ssha1.
6060
7400048f
PE
60612011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6062
6063 * gnutls.c: Remove unused macros.
6064 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6065 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6066 Remove macros that are defined and never used.
6067 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6068
abb71cf4
CY
60692011-05-22 Chong Yidong <cyd@stupidchicken.com>
6070
6071 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6072 (Fx_get_selection_internal): Minor cleanup.
6073 (Fx_own_selection_internal): Rename arguments for consistency with
6074 select.el.
6075
6307db39
PE
60762011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6077
6078 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6079
f3d4e0a4
CY
60802011-05-22 Chong Yidong <cyd@stupidchicken.com>
6081
6082 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6083
4d8ade89
YM
60842011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6085
6086 * dispnew.c (scrolling_window): Don't exclude the case that the
6087 last enabled row in the desired matrix touches the bottom boundary.
6088
32078c8d
GM
60892011-05-21 Glenn Morris <rgm@gnu.org>
6090
6091 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6092 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6093 and add some more files.
32078c8d 6094
7285dc67
EZ
60952011-05-20 Eli Zaretskii <eliz@gnu.org>
6096
6097 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6098 report_file_error introduced by the change from 2011-05-07.
6099
89d1bd22
PE
61002011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6101
6102 * systime.h (Time): Define only if emacs is defined.
6103 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6104 where the include path doesn't have X11/X.h by default. See
6105 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6106
cd394be1 61072011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6108
6109 * composite.c (find_automatic_composition): Fix previous change.
6110
b9704ad9
GM
61112011-05-20 Glenn Morris <rgm@gnu.org>
6112
6113 * lisp.mk: New file, split from Makefile.in.
6114 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6115 (shortlisp): Remove.
6116 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6117
4a720484
GM
61182011-05-19 Glenn Morris <rgm@gnu.org>
6119
6120 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6121 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6122 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6123 (lisp): Set the order to that of loadup.el.
6124 (shortlisp): Make it a copy of $lisp.
6125 (SOME_MACHINE_LISP): Remove.
6126 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6127 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6128
a28d4396
KH
61292011-05-18 Kenichi Handa <handa@m17n.org>
6130
6131 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6132 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6133 (find_automatic_composition): Mostly rewrite for efficiency.
6134
a2b1fa8e
JB
61352011-05-18 Juanma Barranquero <lekktu@gmail.com>
6136
6137 * makefile.w32-in: Update dependencies.
6138
8e1f5610
CS
61392011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6140
6141 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6142 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6143
7025ee00 61442011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6145
cdfa6eab
PE
6146 Fix some integer overflow issues, such as string length overflow.
6147
06d6db33
PE
6148 * insdel.c (count_size_as_multibyte): Check for string overflow.
6149
2b4560a8
PE
6150 * character.c (lisp_string_width): Check for string overflow.
6151 Use EMACS_INT, not int, for string indexes and lengths; in
6152 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6153 the resulting string length overflows an EMACS_INT; instead,
6154 report a string overflow if no precision given. When checking for
6155 precision exhaustion, use a check that cannot possibly have
6156 integer overflow. (Bug#8675)
6157 * character.h (lisp_string_width): Adjust to new signature.
6158
cb93f9be
PE
6159 * alloc.c (string_overflow): New function.
6160 (Fmake_string): Use it. This doesn't change behavior, but saves
6161 a few bytes and will simplify future changes.
6162 * character.c (string_escape_byte8): Likewise.
6163 * lisp.h (string_overflow): New decl.
6164
1a1f3366
PE
6165 Fixups, following up to the user-interface timestamp change.
6166 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6167 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6168 * msdos.c (mouse_get_pos): Likewise.
6169 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6170 * w32gui.h (Time): Define by including "systime.h" rather than by
6171 declaring it ourselves. (Bug#8664)
6172
d4e3e4d3
PE
6173 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6174 * image.c (clear_image_cache): Likewise.
6175
f6a24d19
PE
6176 * term.c (term_mouse_position): Don't assume time_t wraparound.
6177
08dc5ae6
PE
6178 Be more systematic about user-interface timestamps.
6179 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6180 and sometimes 'EMACS_UINT', to represent these timestamps.
6181 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6182 This makes the code easier to follow, and makes it easier to catch
6183 integer overflow bugs such as Bug#8664.
6184 * frame.c (Fmouse_position, Fmouse_pixel_position):
6185 Use Time, not unsigned long, for user-interface timestamps.
6186 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6187 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6188 * keyboard.h (last_event_timestamp): Likewise.
6189 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6190 * menu.h (xmenu_show): Likewise.
6191 * term.c (term_mouse_position): Likewise.
6192 * termhooks.h (struct input_event.timestamp): Likewise.
6193 (struct terminal.mouse_position_hook): Likewise.
6194 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6195 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6196 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6197 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6198 what it was before.
6199 * menu.h, termhooks.h: Include "systime.h", for Time.
6200
8e55734a
PE
6201 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6202 Don't assume that the difference between two unsigned long values
6203 can fit into an integer. At this point, we know button_down_time
6204 <= event->timestamp, so the difference must be nonnegative, so
6205 there's no need to cast the result if double-click-time is
6206 nonnegative, as it should be; check that it's nonnegative, just in
6207 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6208 apart (about 25 days). (Bug#8664)
8e55734a 6209
841f1b75 6210 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6211 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6212
3e26f69c
PE
6213 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6214 that always fit in int. Use a sentinel instead of a counter, to
6215 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6216 * frame.h (struct frame): Use int for menu_bar_items_used
6217 instead of EMACS_INT, since it always fits in int.
3e26f69c 6218
5cc152c0
PE
6219 * menu.c (grow_menu_items): Check for int overflow.
6220
d89eb65e
PE
6221 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6222
5235bd3e
PE
6223 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6224 Before, the code was not consistent. These values cannot exceed
6225 2**31 - 1 so there's no need to make them unsigned.
6226 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6227 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6228 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6229 as modifiers.
6230 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6231
bc827e23
PE
6232 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6233 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6234 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6235 presumably because the widths might not match.
6236
78eb494e
PE
6237 * window.c (size_window): Avoid needless test at loop start.
6238
04f2d78b
CB
62392011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6240
6241 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6242
d2fc7e3d 62432011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6244
6245 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6246
d2fc7e3d 62472011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6248
6249 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6250 `width' to `bar_area_x' and `bar_area_width', respectively.
6251 (x_scroll_run): Take account of fringe background extension.
6252
04f2d78b
CB
6253 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6254 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6255 `bar_area_width', respectively.
6256 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6257 background extension.
6258
79b70037
GM
62592011-05-10 Jim Meyering <meyering@redhat.com>
6260
6261 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6262
2f142cc5
JB
62632011-05-10 Juanma Barranquero <lekktu@gmail.com>
6264
6265 * image.c (Finit_image_library): Return t for built-in image types,
6266 like pbm and xbm. (Bug#8640)
6267
57679c86
AS
62682011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6269
6270 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6271
888c9e86
EZ
62722011-05-07 Eli Zaretskii <eliz@gnu.org>
6273
b0512a1d
EZ
6274 * w32console.c (Fset_screen_color): Doc fix.
6275 (Fget_screen_color): New function.
6276 (syms_of_ntterm): Defsubr it.
6277
7285dc67
EZ
6278 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6279 unlink the temporary file if Fcall_process didn't create it in the
6280 first place.
6281 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6282 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6283 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6284 cue to call_process_cleanup not to close that handle.
6285
4d3fcc8e
BK
62862011-05-07 Ben Key <bkey76@gmail.com>
6287
6288 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6289 one of two shell specific rules, either bootstrap-temacs-CMD or
6290 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6291 to the previous implementation of the bootstrap-temacs rule.
6292 The bootstrap-temacs-CMD rule is similar to the previous
6293 implementation of the bootstrap-temacs rule except that it
6294 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6295 variable.
6296
6297 These changes, along with some changes to nt/configure.bat,
6298 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6299 earlier fix to add support for --cflags and --ldflags options
6300 that include quotes so that it works whether make uses cmd or
6301 sh as the shell.
6302
b4289b64
MA
63032011-05-06 Michael Albinus <michael.albinus@gmx.de>
6304
6305 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6306 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6307 is a constant.
6308 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6309 a string. Handle both cases.
6310 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6311 (Fdbus_register_method): Use Qinvalid_function.
6312
af4c0e28
JB
63132011-05-06 Juanma Barranquero <lekktu@gmail.com>
6314
6315 * makefile.w32-in: Update dependencies.
6316 (LISP_H): Add inttypes.h and stdin.h.
6317 (PROCESS_H): Add unistd.h.
6318
c51453d9
EZ
63192011-05-06 Eli Zaretskii <eliz@gnu.org>
6320
6321 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6322 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6323
8ff0ac3c 63242011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6325
4c4b566b
PE
6326 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6327
aab2b9b5
PE
6328 * term.c (vfatal): Remove stray call to va_end.
6329 It's not needed and the C Standard doesn't allow it here anyway.
6330
c378da0b
PE
6331 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6332 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6333
288b08c7
PE
6334 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6335 bytes.
6336
e3601888
PE
6337 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6338
db6c0e74
PE
6339 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6340
dd5963ea
PE
6341 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6342
88c9450f
PE
6343 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6344
2f9442b8
PE
6345 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6346
c032b5f8
PE
6347 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6348 * charset.c (Fdefine_charset_internal): Don't initialize
6349 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6350 32-bit int (Bug#8600).
a108c10b
PE
6351
6352 * lread.c (read_integer): Be more consistent with string-to-number.
6353 Use string_to_number to do the actual conversion; this avoids
6354 rounding errors and fixes some other screwups. Without this fix,
6355 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6356 (digit_to_number): Move earlier, for benefit of read_integer.
6357 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6358 not a digit in any supported base. (Bug#8602)
a108c10b 6359
ad5f9eea
PE
6360 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6361
aec1708a
PE
6362 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6363 to match comment at start of function. This also removes a
6364 GCC warning about overflow in a 32+64-bit port.
6365
47be4ab5
PE
6366 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6367
371cac43
PE
6368 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6369 Reported by Stefan Monnier in
6370 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6371 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6372 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6373
d01a7826
PE
6374 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6375 (EMACS_UINTPTR): Likewise, with uintptr_t.
6376
7fd47d5c
PE
6377 * lisp.h: Prefer 64-bit EMACS_INT if available.
6378 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6379 on 32-bit hosts that have 64-bit int, so that they can access
6380 large files.
122b0c86
PE
6381 However, temporarily disable this change unless the temporary
6382 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6383
8727937b
PE
6384 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6385
8ac068ac
PE
6386 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6387 This removes an assumption that EMACS_INT and long are the same
6388 width as pointers. The assumption is true for Emacs porting targets
6389 now, but we want to make other targets possible.
6390 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6391 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6392 In the rest of the code, change types of integers that hold casted
6393 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6394 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6395 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6396 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6397 No need to cast type when ORing.
6398 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6399 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6400 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6401 assume EMACS_INT is the same width as char *.
6402 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6403 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6404 Remove no-longer-needed casts.
6405 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6406 (xg_tool_bar_help_callback, xg_make_tool_item):
6407 Use EMACS_INTPTR to hold an integer
6408 that will be cast to void *; this can avoid a GCC warning
6409 if EMACS_INT is not the same width as void *.
6410 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6411 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6412 (current_message_1, set_message_1):
6413 Use a local to convert to proper width without a cast.
6414 * xmenu.c (dialog_selection_callback): Likewise.
6415
ede49d71
PE
6416 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6417 Also, don't assume VALBITS / RAND_BITS is less than 5,
6418 and don't rely on undefined behavior when shifting a 1 left into
6419 the sign bit.
6420 * lisp.h (get_random): Change signature to match.
6421
2f30ecd0
PE
6422 * lread.c (hash_string): Use size_t, not int, for hash computation.
6423 Normally we prefer signed values; but hashing is special, because
6424 it's better to use unsigned division on hash table sizes so that
6425 the remainder is nonnegative. Also, size_t is the natural width
6426 for hashing into memory. The previous code used 'int', which doesn't
6427 retain enough info to hash well into very large tables.
6428 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6429
2a866e7b
PE
6430 * dbusbind.c: Don't possibly lose pointer info when converting.
6431 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6432 Use XPNTR rather than XHASH, so that the high-order bits of
6433 the pointer aren't lost when converting through void *.
6434
51639eac
PE
6435 * eval.c (Fautoload): Don't double-shift a pointer.
6436
92394119
PE
6437 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6438
dbdb9a7c
JB
64392011-05-06 Juanma Barranquero <lekktu@gmail.com>
6440
6441 * gnutls.c (DEF_GNUTLS_FN):
6442 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6443
db7a0b4f
AS
64442011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6445
6446 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6447 marker. (Bug#8610)
6448
cd394be1 64492011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6450
6451 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6452 New version that can reserve upto 2GB of heap space.
6453
f7ff1b0f 64542011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6455
6456 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6457
639c109b
TZ
64582011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6459
6460 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6461 `gnutls_certificate_set_x509_key_file'.
6462
d2127135
JB
64632011-05-05 Juanma Barranquero <lekktu@gmail.com>
6464
6465 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6466 Update dependencies.
6467
e968f4f3
JB
64682011-05-04 Juanma Barranquero <lekktu@gmail.com>
6469
6470 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6471 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6472 Remove unused parameter `fildes'.
6473 * process.c (read_process_output, send_process): Don't pass it.
6474
84d358f0
JB
64752011-05-04 Juanma Barranquero <lekktu@gmail.com>
6476
6477 Fix previous change: the library cache is defined in w32.c.
6478 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6479 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6480
0898ca10
JB
64812011-05-04 Juanma Barranquero <lekktu@gmail.com>
6482
6483 Implement dynamic loading of GnuTLS on Windows.
6484
6485 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6486 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6487 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6488 Declare.
6489
6490 * gnutls.c (Qgnutls_dll): Define.
6491 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6492 (gnutls_*): Declare function pointers.
6493 (init_gnutls_functions): New function to initialize function pointers.
6494 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6495 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6496 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6497 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6498 (emacs_gnutls_write, emacs_gnutls_read)
6499 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6500 (Fgnutls_available_p): New function.
6501 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6502 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6503 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6504
6505 * image.c: Include w32.h.
6506 (Vimage_type_cache): Delete.
6507 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6508 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6509 (w32_delayed_load): Move to w32.c.
6510
6511 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6512
6513 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6514 (w32_delayed_load): Move from image.c. When loading a library, record
6515 its filename in the :loaded-from property of the library id.
6516 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6517 Initialize and staticpro them.
6518 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6519
6520 * process.c: Include lisp.h before w32.h, not after.
6521 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6522 instead of gnutls_record_check_pending.
6523
6524 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6525
ff4de4aa
TZ
65262011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6527
6528 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6529 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6530 as passed in.
6531
abe95abb
JD
65322011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6533
6534 * xterm.c (x_set_frame_alpha): Do not set property on anything
6535 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6536
e16e55d4
JB
65372011-05-02 Juanma Barranquero <lekktu@gmail.com>
6538
6539 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6540
bafcf6a5
JB
65412011-05-02 Juanma Barranquero <lekktu@gmail.com>
6542
6543 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6544 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6545 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6546 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6547 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6548 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6549 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6550 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6551 (Qgnutls_bootprop_callbacks_verify): Make static.
6552
e7a6747f
AS
65532011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6554
19ed11ba
AS
6555 * callproc.c: Indentation fixup.
6556
e7a6747f 6557 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6558 (wait_for_termination, interruptible_wait_for_termination):
6559 Move after wait_for_termination_1.
e7a6747f 6560
1ef14cb4
LMI
65612011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6562
6563 * sysdep.c (interruptible_wait_for_termination): New function
6564 which is like wait_for_termination, but allows keyboard
6565 interruptions.
6566
6567 * callproc.c (Fcall_process): Add (:file "file") as an option for
6568 the STDOUT buffer.
6569 (Fcall_process_region): Ditto.
6570
330d880c
EZ
65712011-04-30 Eli Zaretskii <eliz@gnu.org>
6572
8db90b73
EZ
6573 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6574 rather than `XVECTOR (FOO)->size'.
6575
330d880c
EZ
6576 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6577 inttypes.h, as a gnulib replacement is used if it not available in
6578 system headers.
6579
15cbd324
EZ
65802011-04-21 Eli Zaretskii <eliz@gnu.org>
6581
6582 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6583 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6584 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6585
6586 * coding.c (coding_alloc_by_realloc): Error out if destination
6587 will grow beyond MOST_POSITIVE_FIXNUM.
6588 (decode_coding_emacs_mule): Abort if there isn't enough place in
6589 charbuf for the composition carryover bytes. Reserve an extra
6590 space for up to 2 characters produced in a loop.
6591 (decode_coding_iso_2022): Abort if there isn't enough place in
6592 charbuf for the composition carryover bytes.
6593
65942011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6595
ae940cca
EZ
6596 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6597 aborting when %lld or %lll format is passed.
6598 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6599 %llo or %llx format is passed. (Bug#8545)
6600
03ab8921
EZ
6601 * window.c (window_scroll_line_based): Use a marker instead of
6602 simple variables to record original value of point. (Bug#7952)
6603
afda1437
EZ
6604 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6605 produced by %s or %c overflows available buffer space. (Bug#8545)
6606
f76dee0c
PE
66072011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6608
6609 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6610 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6611
fdc5744d
JB
66122011-04-28 Juanma Barranquero <lekktu@gmail.com>
6613
6614 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6615
638f053a
JB
66162011-04-28 Juanma Barranquero <lekktu@gmail.com>
6617
6618 * keyboard.c (Qdelayed_warnings_hook): Define.
6619 (command_loop_1): Run `delayed-warnings-hook'
6620 if Vdelayed_warnings_list is non-nil.
6621 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6622 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6623
d178f871
EZ
66242011-04-28 Eli Zaretskii <eliz@gnu.org>
6625
6626 * doprnt.c (doprnt): Don't return value smaller than the buffer
6627 size if the message was truncated. (Bug#8545).
6628
b124fd93
JB
66292011-04-28 Juanma Barranquero <lekktu@gmail.com>
6630
6631 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6632 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6633
e810457d
PE
66342011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6635
6636 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6637
ea51cceb
JB
66382011-04-27 Juanma Barranquero <lekktu@gmail.com>
6639
6640 * makefile.w32-in: Update dependencies.
6641
94dcfacf
EZ
66422011-04-27 Eli Zaretskii <eliz@gnu.org>
6643
6644 Improve `doprnt' and its usage. (Bug#8545)
6645 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6646 `format_end'. Remove support for %l as a conversion specifier.
6647 Don't use xrealloc. Improve diagnostics when the %l size modifier
6648 is used. Update the commentary.
6649
6650 * eval.c (verror): Simplify calculation of size_t.
6651
6652 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6653 messages.
6654
f61f41d7
PE
66552011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6656
6657 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6658 change.
6659
96fb4434
PE
66602011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6661
6662 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6663 This makes this file independent of the recent pseudovector change.
6664
671875da 66652011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6666
69e9b5a3
PE
6667 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6668
b5f869a7 6669 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6670 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6671 Remove unused local.
c8926152 6672 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6673
841a1577 6674 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6675 GCC 4.6.0 optimizes based on type-based alias analysis.
6676 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6677 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6678 != &v->size, and therefore "v->size = 1; b->size = 2; return
6679 v->size;" must therefore return 1. This assumption is incorrect
6680 for Emacs, since it type-puns struct Lisp_Vector * with many other
6681 types. To fix this problem, this patch adds a new type struct
f904488f 6682 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6683 and pseudovectors, and helps optimizing compilers not get fooled
6684 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6685 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6686 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6687 the size member.
eab3844f
PE
6688 (XSETPVECTYPE): Rewrite in terms of new macro.
6689 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6690 This is a bit clearer, and further avoids the possibility of
6691 undesirable aliasing.
6692 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6693 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6694 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6695 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6696 (ASIZE): Now uses header.size rather than size.
6697 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6698 to avoid the hassle of writing XVECTOR (foo)->header.size.
6699 (struct vectorlike_header): New type.
eab3844f
PE
6700 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6701 object, to help avoid aliasing.
6702 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6703 (SUBRP): Likewise, since Lisp_Subr is a special case.
6704 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6705 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6706 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6707 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6708 changed to be "header.size" and "header.next".
6709 * buffer.h (struct buffer): Likewise.
6710 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6711 * frame.h (struct frame): Likewise.
6712 * process.h (struct Lisp_Process): Likewise.
6713 * termhooks.h (struct terminal): Likewise.
6714 * window.c (struct save_window_data, struct saved_window): Likewise.
6715 * window.h (struct window): Likewise.
6716 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6717 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6718 * buffer.c (init_buffer_once): Likewise.
6719 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6720 special case.
6721 * process.c (Fformat_network_address): Use local var for size,
6722 for brevity.
6723
0df1eac5
PE
6724 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6725
847ab9d1 6726 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6727 * data.c (atof): Remove decl; no longer used or needed.
6728 (digit_to_number): Move to lread.c.
6729 (Fstring_to_number): Use new string_to_number function, to be
6730 consistent with how the Lisp reader treats infinities and NaNs.
6731 Do not assume that floating-point numbers represent EMACS_INT
6732 without losing information; this is not true on most 64-bit hosts.
6733 Avoid double-rounding errors, by insisting on integers when
6734 parsing non-base-10 numbers, as the documentation specifies.
6735 * lisp.h (string_to_number): New decl, replacing ...
6736 (isfloat_string): Remove.
bc0a5c13 6737 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6738 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6739 appears to have been a coding error. Similarly, do not accept
6740 strings like +-1e0 as floating point numbers. Do not report
6741 overflow for integer overflows unless the base is not 10 which
6742 means we have no simple and reliable way to continue.
6743 Break out the floating-point parsing into a new
6744 function string_to_number, so that Fstring_to_number parses
6745 floating point numbers consistently with the Lisp reader.
04f2d78b 6746 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6747 (E_CHAR, EXP_INT): Remove, replacing with ...
6748 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6749 (string_to_number): New function, replacing isfloat_string.
6750 This function checks for valid syntax and produces the resulting
6751 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6752 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6753 so that overflow for non-base-10 numbers is reported only when
6754 there's no portable and simple way to convert to floating point.
452f4150 6755
67769ffc
PE
6756 * textprop.c (set_text_properties_1): Rewrite for clarity,
6757 and to avoid GCC warning about integer overflow.
6758
c20db43f
PE
6759 * intervals.h (struct interval): Use EMACS_INT for members
6760 where EMACS_UINT might cause problems. See
6761 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6762 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6763 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6764 All uses changed.
37aa2f85
PE
6765 (offset_intervals): Tell GCC not to worry about length overflow
6766 when negating a negative length.
c20db43f 6767
2538aa2f
PE
6768 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6769 (overrun_check_free): Likewise.
6770
f2d3008d
PE
6771 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6772 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6773 word size.
6774
ec8df744
PE
6775 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6776 (gnutls_make_error): Rename local to avoid shadowing.
6777 (gnutls_emacs_global_deinit): ifdef out; not used.
6778 (Fgnutls_boot): Use const for pointer to readonly storage.
6779 Comment out unused local. Fix pointer signedness problems.
6780
640ee02d
PE
6781 * lread.c (openp): Don't stuff size_t into an 'int'.
6782 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6783 about possible signed overflow.
6784
6048fb2a
PE
6785 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6786 (GDK_KEY_g): Don't define if already defined.
6787 (xg_prepare_tooltip): Avoid pointer signedness problem.
6788 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6789
fa3c87e1
PE
6790 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6791 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6792
2172544b
PE
6793 * xfns.c (Fx_window_property): Simplify a bit,
6794 to make a bit faster and to avoid GCC 4.6.0 warning.
6795 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6796
9b821a21
PE
6797 * fns.c (internal_equal): Don't assume size_t fits in int.
6798
3c616cfa
PE
6799 * alloc.c (compact_small_strings): Tighten assertion a little.
6800
c2982e87
PE
6801 Replace pEd with more-general pI, and fix some printf arg casts.
6802 * lisp.h (pI): New macro, generalizing old pEd macro to other
6803 conversion specifiers. For example, use "...%"pI"d..." rather
6804 than "...%"pEd"...".
6805 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 6806 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
6807 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6808 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6809 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6810 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6811 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6812 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6813 64-bit hosts.
6814 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6815 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6816 * print.c (safe_debug_print, print_object): Likewise.
6817 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6818 to int.
6f04d126
PE
6819 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6820 avoiding the 0 flag, which is not portable.
c2982e87
PE
6821 * process.c (Fmake_network_process): Use pI to avoid cast.
6822 * region-cache.c (pp_cache): Likewise.
6823 * xdisp.c (decode_mode_spec): Likewise.
6824 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6825 behavior on 64-bit hosts with printf arg.
6f04d126 6826 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6827 (x_stop_queuing_selection_requests): Likewise.
6828 (x_get_window_property): Don't truncate byte count to an 'int'
6829 when tracing.
0b432f21 6830
5e073ec7
PE
6831 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6832 here, since it parses constructs like leading '-' and spaces,
6833 which are not wanted; and it overflows with large numbers.
6834 Instead, simply match F[0-9]+, which is what is wanted anyway.
6835
36372bf9
PE
6836 * alloc.c: Remove unportable assumptions about struct layout.
6837 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6838 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6839 (allocate_vectorlike, make_pure_vector): Use the new macros,
6840 plus offsetof, to remove unportable assumptions about struct layout.
6841 These assumptions hold on all porting targets that I know of, but
6842 they are not guaranteed, they're easy to remove, and removing them
6843 makes further changes easier.
6844
0b432f21
PE
6845 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6846 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6847 (string_overrun_cookie): Now const. Use initializers that
6848 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6849 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6850 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6851 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6852 multiple of sizeof (EMACS_INT); it need not be, if
6853 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6854 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6855
895009e1
JB
68562011-04-26 Juanma Barranquero <lekktu@gmail.com>
6857
6858 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6859
6a7a1b0b
TZ
68602011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6861
6862 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6863 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6864 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6865
841a1577 68662011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6867
6868 * lisp.h (Qdebug): List symbol.
895009e1 6869 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6870 * keyboard.c (debug-on-event): New variable.
6871 (handle_user_signal): Break into debugger when debug-on-event
6872 matches the current signal symbol.
6873
f2d3ba6f
DN
68742011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6875
6876 * alloc.c (check_sblock, check_string_bytes)
6877 (check_string_free_list): Convert to standard C.
6878
42ce4c63
TZ
68792011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6880
6881 * w32.c (emacs_gnutls_push): Fix typo.
6882
825cd63c
EZ
68832011-04-25 Eli Zaretskii <eliz@gnu.org>
6884
fb11d64d
EZ
6885 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6886 "cast to pointer from integer of different size".
6887
825cd63c
EZ
6888 Improve doprnt and its use in verror. (Bug#8545)
6889 * doprnt.c (doprnt): Document the set of format control sequences
6890 supported by the function. Use SAFE_ALLOCA instead of always
6891 using `alloca'.
6892
6893 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6894 is one byte too soon. Don't use xrealloc; instead xfree and
6895 xmalloc anew.
6896
e061a11b
TZ
68972011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6898
6899 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6900 callbacks stage.
6901
6902 * gnutls.c: Renamed global_initialized to
6903 gnutls_global_initialized. Added internals for the
6904 :verify-hostname-error, :verify-error, and :verify-flags
6905 parameters of `gnutls-boot' and documented those parameters in the
6906 docstring. Start callback support.
9173deec
JB
6907 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6908 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6909 on error. Return error code.
e061a11b
TZ
6910 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6911 (emacs_gnutls_read): Likewise.
6912 (Fgnutls_boot): Return handshake error code.
6913 (emacs_gnutls_handle_error): New function.
6914 (wsaerror_to_errno): Likewise.
6915
6916 * w32.h (emacs_gnutls_pull): Add prototype.
6917 (emacs_gnutls_push): Likewise.
6918
6919 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6920 (emacs_gnutls_push): Likewise.
6921
69222011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6923
6924 * process.c (wait_reading_process_output): Check if GnuTLS
6925 buffered some data internally if no FDs are set for TLS
6926 connections.
6927
6928 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6929 (LIBS): Link to USER_LIBS.
6930 ($(BLD)/gnutls.$(0)): New target.
6931
fa6996bc
EZ
69322011-04-24 Eli Zaretskii <eliz@gnu.org>
6933
eb35682e
EZ
6934 * xdisp.c (handle_single_display_spec): Rename the
6935 display_replaced_before_p argument into display_replaced_p, to
6936 make it consistent with the commentary. Fix typos in the
6937 commentary.
6938
e2ad650c
EZ
6939 * textprop.c (syms_of_textprop): Remove dead code.
6940 (copy_text_properties): Delete obsolete commentary about an
6941 interface that was deleted long ago. Fix typos in the description
6942 of arguments.
6943
1b2de274
EZ
6944 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6945 to changes in oldXMenu/XMenu.h from 2011-04-16.
6946 <menu_help_message, prev_menu_help_message>: Constify.
6947 (IT_menu_make_room): menu->help_text is now `const char **';
6948 adjust.
6949
6950 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6951 to changes in oldXMenu/XMenu.h from 2011-04-16.
6952 (struct XMenu): Declare `help_text' `const char **'.
6953
6954 * xfaces.c <Qunspecified>: Make extern again.
6955
6956 * syntax.c: Include sys/types.h before including regex.h, as
6957 required by Posix.
6958
762b15be
EZ
6959 * doc.c (get_doc_string): Improve the format passed to `error'.
6960
6961 * doprnt.c (doprnt): Improve commentary.
6962
6963 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6964
6965 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6966 them with etags.
6967
f1052e5d
EZ
6968 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6969 changes in globals.h immediately force recompilation.
762b15be
EZ
6970 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6971 $(CURDIR)/s/ms-w32.h.
6972 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6973
fa6996bc
EZ
6974 * character.c (Fchar_direction): Function deleted.
6975 (syms_of_character): Don't defsubr it.
6976 <char-direction-table>: Deleted.
6977
e6c3da20
EZ
69782011-04-23 Eli Zaretskii <eliz@gnu.org>
6979
6980 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6981 * doprnt.c: Include limits.h.
6982 (SIZE_MAX): New macro.
04f2d78b
CB
6983 (doprnt): Return a size_t value. 2nd arg is now size_t.
6984 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6985 Improve overflow protection. Support `l' modifier for integer
6986 conversions. Support %l conversion. Don't assume an EMACS_INT
6987 argument for integer conversions and for %c.
6988
6989 * lisp.h (doprnt): Restore prototype.
6990
6991 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6992 $(SRC)/character.h.
6993
6994 * Makefile.in (base_obj): Add back doprnt.o.
6995
6996 * deps.mk (doprnt.o): Add back prerequisites.
6997 (callint.o): Depend on character.h.
6998
6999 * eval.c (internal_lisp_condition_case): Include the handler
7000 representation in the error message.
7001 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7002 when breaking from the loop.
7003
7004 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7005
7006 * callint.c (Fcall_interactively): When displaying error message
7007 about invalid control letter, pass the character's codepoint, not
7008 a pointer to its multibyte form. Improve display of the character
7009 in octal and display also its hex code.
7010
7011 * character.c (char_string): Use %x to display the (unsigned)
7012 codepoint of an invalid character, to avoid displaying a bogus
7013 negative value.
7014
7015 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7016 `error', not SYMBOL_NAME itself.
7017
7018 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7019 character arguments to `error'.
7020
7021 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7022 to `error' in error message about FINAL_CHAR argument. Make sure
7023 FINAL_CHAR is a character, and use %c when it is passed as
7024 argument to `error'.
7025
4ffd0d6b 70262011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7027
7028 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7029
7030 * w32.c: Include <time.h>.
7031 (sys_localtime): New function.
7032
4ffd0d6b 70332011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7034
7035 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7036
4ffd0d6b 7037 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7038
4ffd0d6b 70392011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7040
4ffd0d6b
GM
7041 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7042 zombies (Bug#8467).
aac0c6e3 7043
04c56954
EZ
70442011-04-19 Eli Zaretskii <eliz@gnu.org>
7045
7046 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7047 gl_state.e_property when gl_state.object is Qt.
7048
7049 * insdel.c (make_gap_larger): Remove limitation of buffer size
7050 to <= INT_MAX.
7051
16a43933
CY
70522011-04-18 Chong Yidong <cyd@stupidchicken.com>
7053
7054 * xdisp.c (lookup_glyphless_char_display)
7055 (produce_glyphless_glyph): Handle cons cell entry in
7056 glyphless-char-display.
7057 (Vglyphless_char_display): Document it.
7058
7059 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7060 glyphless-char-display.
7061
4581706e
CY
70622011-04-17 Chong Yidong <cyd@stupidchicken.com>
7063
7064 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7065
7066 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7067
7068 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7069 definition for no-X builds.
7070
4887c6e2 70712011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7072
fd35b6f9
PE
7073 Static checks with GCC 4.6.0 and non-default toolkits.
7074
5c1ccb01
PE
7075 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7076
006c5daa
PE
7077 * process.c (keyboard_bit_set): Define only if SIGIO.
7078 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7079 (send_process): Repair possible setjmp clobbering.
7080
efc736d3
PE
7081 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7082
4e2fe2e6
PE
7083 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7084
f97334a2
PE
7085 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7086
4e75f29d
PE
7087 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7088 Define only if needed.
7089
90efadd1
PE
7090 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7091 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7092 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7093
3c647824
PE
7094 * dispextern.h (struct redisplay_interface): Rename param
7095 to avoid shadowing.
e264f262 7096 * termhooks.h (struct terminal): Likewise.
761383f4 7097 * xterm.c (xembed_send_message): Likewise.
3c647824 7098
b58c5c4a
PE
7099 * insdel.c (make_gap_smaller): Define only if
7100 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7101
cad59032
PE
7102 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7103 it.
7104
c339dc2e
PE
7105 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7106 so that we aren't warned about unused symbols.
7107
91a3e27b
PE
7108 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7109
399c71d3 7110 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7111
8ffc96f5
PE
7112 * xfns.c (x_real_positions): Mark locals as initialized.
7113
eef9bc79
PE
7114 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7115
098db9dd
PE
7116 * xterm.c: Fix problems found by static analysis with other toolkits.
7117 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7118 (x_dispatch_event): Declare static if USE_GTK, and
7119 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7120 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7121 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7122 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7123 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7124
eb18f6cc
PE
7125 * xmenu.c (menu_help_callback): Pointer type fixes.
7126 Use const pointers when pointing at readonly data. Avoid pointer
7127 signedness clashes.
7128 (FALSE): Remove unused macro.
7129 (update_frame_menubar): Remove unused decl.
7130
1fe72bf8
PE
7131 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7132
60d9e1db
PE
7133 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7134 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7135 (single_menu_item): Rename local to avoid shadowing.
7136
39261c26
PE
7137 * keyboard.c (make_lispy_event): Remove unused local var.
7138
018c5e19
PE
7139 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7140 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7141
63d2b86e
PE
7142 * bitmaps: Change bitmaps from unsigned char back to the X11
7143 compatible char. Avoid the old compiler warnings about
7144 out-of-range initializers by using, for example, '\xab' rather
7145 than 0xab.
7146
aefd87e1
PE
7147 * xgselect.c (xgselect_initialize): Check vs interface
7148 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7149
bf501fb9
PE
7150 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7151
e9829fdf
PE
7152 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7153 to read-only memory.
7154
1086c095
PE
7155 * fns.c (vector): Remove; this old hack is no longer needed.
7156
2baccd04 7157 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7158 Remove unused var.
dde42981 7159 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7160
72391843 7161 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7162
436c16df 7163 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7164 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7165 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7166
92bb796d 7167 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7168 (x_term_init): Remove local to avoid shadowing.
92bb796d 7169
764430a3 7170 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7171
7172 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7173 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7174
d1dfb56c
EZ
71752011-04-16 Eli Zaretskii <eliz@gnu.org>
7176
c4354cb4
EZ
7177 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7178
d1dfb56c
EZ
7179 Fix regex.c, syntax.c and friends for buffers > 2GB.
7180 * syntax.h (struct gl_state_s): Declare character position members
7181 EMACS_INT.
7182
7183 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7184
04f2d78b
CB
7185 * textprop.c (verify_interval_modification, interval_of):
7186 Declare arguments EMACS_INT.
d1dfb56c
EZ
7187
7188 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7189 EMACS_INT.
7190
7191 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7192
7193 * indent.c (Fvertical_motion): Local variable it_start is now
7194 EMACS_INT.
7195
7196 * regex.c (re_match, re_match_2, re_match_2_internal)
7197 (bcmp_translate, regcomp, regexec, print_double_string)
7198 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7199 (re_compile_pattern, re_exec): Declare arguments and local
7200 variables `size_t' and `ssize_t' and return values `regoff_t', as
7201 appropriate.
7202 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7203 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7204 <compile_stack_type>: `size' and `avail' are now `size_t'.
7205
7206 * regex.h <regoff_t>: Use ssize_t, not int.
7207 (re_search, re_search_2, re_match, re_match_2): Arguments that
7208 specify buffer/string position and length are now ssize_t and
7209 size_t. Return type is regoff_t.
7210
613052cd
BK
72112011-04-16 Ben Key <bkey76@gmail.com>
7212
7213 * nsfont.m: Fixed bugs in ns_get_family and
7214 ns_descriptor_to_entity that were caused by using free to
7215 deallocate memory blocks that were allocated by xmalloc (via
7216 xstrdup). This caused Emacs to crash when compiled with
7217 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7218 --enable-checking=xmallocoverrun). xfree is now used to
7219 deallocate these memory blocks.
7220
4170f62f 72212011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7222
71b41406
PE
7223 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7224
9587a89d
PE
7225 emacs_write: Accept and return EMACS_INT for sizes.
7226 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7227 et seq.
7228 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7229 Accept and return EMACS_INT.
7230 (emacs_gnutls_write): Return the number of bytes written on
7231 partial writes.
7232 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7233 (emacs_read, emacs_write): Remove check for negative size, as the
7234 Emacs source code has been audited now.
9587a89d
PE
7235 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7236 (emacs_read, emacs_write): Use it.
273a5f82
PE
7237 * process.c (send_process): Adjust to the new signatures of
7238 emacs_write and emacs_gnutls_write. Do not attempt to store
7239 a byte offset into an 'int'; it might overflow.
9587a89d 7240 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7241
3e047f51
PE
7242 * sound.c: Don't assume sizes fit in 'int'.
7243 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7244 Return EMACS_INT, not int.
3e047f51 7245 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7246 Accept EMACS_INT, not int.
7247 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7248 record read return values.
7249
cc39a9db
BK
72502011-04-15 Ben Key <bkey76@gmail.com>
7251
c9d0ec6d
JB
7252 * keyboard.c (Qundefined): Don't declare static since it is used
7253 in nsfns.m.
7254 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7255 static since they are used in nsfont.m.
cc39a9db 7256
6c60eb9f
SM
72572011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7258
7259 * process.c (Qprocessp): Don't declare static.
7260 * lisp.h (Qprocessp): Declare again.
7261
7990b61a
JB
72622011-04-15 Juanma Barranquero <lekktu@gmail.com>
7263
7264 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7265
5d4cb038
PE
72662011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7267
8bd7b830 7268 Improve C-level modularity by making more things 'static'.
cd64ea1d 7269
e3b27b31
PE
7270 Don't publish debugger-only interfaces to other modules.
7271 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7272 (verify_bytepos, count_markers): Move decls to the only modules
7273 that need them.
7274 * region-cache.h (pp_cache): Likewise.
7275 * window.h (check_all_windows): Likewise.
7276 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7277
5d4cb038
PE
7278 * sysdep.c (croak): Now static, if
7279 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7280 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7281
7282 * alloc.c (refill_memory_reserve): Now static if
7283 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7284 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7285
e87b6180
PE
7286 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7287 Define only if USE_LUCID.
7288
ac64929e
PE
7289 * xrdb.c (x_customization_string, x_rm_string): Now static.
7290
6f37259d
PE
7291 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7292 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7293
1683e3ab
PE
7294 * xdisp.c (draw_row_with_mouse_face): Now static.
7295 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7296
de9c2632
PE
7297 * window.h (check_all_windows): Mark externally visible.
7298
2b96acb7
PE
7299 * window.c (window_deletion_count): Now static.
7300
7301 * undo.c: Make symbols static if they're not exported.
7302 (last_undo_buffer, last_boundary_position, pending_boundary):
7303 Now static.
7304
50436f33
PE
7305 * textprop.c (interval_insert_behind_hooks): Now static.
7306 (interval_insert_in_front_hooks): Likewise.
7307
64520e5c
PE
7308 * term.c: Make symbols static if they're not exported.
7309 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7310 (max_frame_lines, tty_set_terminal_modes):
7311 (tty_reset_terminal_modes, tty_turn_off_highlight):
7312 (get_tty_terminal): Now static.
7313 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7314 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7315 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7316 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7317 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7318
1fa53021
PE
7319 * sysdep.c: Make symbols static if they're not exported.
7320 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7321 Now static.
7322 (sigprocmask_set, full_mask): Remove; unused.
7323 (wait_debugging): Mark as visible.
7324 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7325 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7326
d4b43b22
PE
7327 * syntax.c (syntax_temp): Define only if !__GNUC__.
7328
b7c513d0
PE
7329 * sound.c (current_sound_device, current_sound): Now static.
7330
989b29ad
PE
7331 * search.c (searchbufs, searchbuf_head): Now static.
7332
13a55a78
PE
7333 * scroll.c (scroll_cost): Remove; unused.
7334 * dispextern.h (scroll_cost): Remove decl.
7335
de68a1fc
PE
7336 * region-cache.h (pp_cache): Mark as externally visible.
7337
40ccffa6
PE
7338 * process.c: Make symbols static if they're not exported.
7339 (process_tick, update_tick, create_process, chan_process):
7340 (Vprocess_alist, proc_buffered_char, datagram_access):
7341 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7342 (deactivate_process): Mark defn as static, as well as decl.
7343 * lisp.h (create_process): Remove decl.
7344 * process.h (chan_process, Vprocess_alist): Remove decls.
7345
ad64fc97
PE
7346 * print.c: Make symbols static if they're not exported.
7347 (print_depth, new_backquote_output, being_printed, print_buffer):
7348 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7349 (print_interval, print_number_index, initial_stderr_stream):
7350 Now static.
7351 * lisp.h (Fprinc): Remove decl.
7352 (debug_output_compilation_hack): Mark as externally visible.
7353
adddb265
PE
7354 * sysdep.c (croak): Move decl from here to syssignal.h.
7355 * syssignal.h (croak): Put it here, so the API can be checked when
7356 'croak' is called from dissociate_if_controlling_tty.
7357
1717ede2
PE
7358 * minibuf.c: Make symbols static if they're not exported.
7359 (minibuf_save_list, choose_minibuf_frame): Now static.
7360 * lisp.h (choose_minibuf_frame): Remove decl.
7361
fa5fb2bc
PE
7362 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7363
1e3890d1
PE
7364 * lread.c: Make symbols static if they're not exported.
7365 (read_objects, initial_obarray, oblookup_last_bucket_number):
7366 Now static.
7367 (make_symbol): Remove; unused.
7368 * lisp.h (initial_obarray, make_symbol): Remove decls.
7369
8a1414fa
PE
7370 * keyboard.c: Make symbols static if they're not exported.
7371 (single_kboard, recent_keys_index, total_keys, recent_keys):
7372 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7373 (this_single_command_key_start, echoing, last_auto_save):
7374 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7375 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7376 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7377 (Vlispy_mouse_stem, double_click_count):
7378 Now static.
7379 (force_auto_save_soon): Define only if SIGDANGER.
7380 (ignore_mouse_drag_p): Now static if
7381 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7382 (print_help): Remove; unused.
7383 (stop_character, last_timer_event): Mark as externally visible.
7384 * keyboard.h (ignore_mouse_drag_p): Declare only if
7385 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7386 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7387 * lisp.h (echoing): Remove decl.
7388 (force_auto_save_soon): Declare only if SIGDANGER.
7389 * xdisp.c (redisplay_window): Simplify code, to make it more
7390 obvious that ignore_mouse_drag_p is not accessed if !defined
7391 USE_GTK && !defined HAVE_NS.
7392
93ea6e8f
PE
7393 * intervals.c: Make symbols static if they're not exported.
7394 (merge_properties_sticky, merge_interval_right, delete_interval):
7395 Now static.
7396 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7397
77382fcc
PE
7398 * insdel.c: Make symbols static if they're not exported.
7399 However, leave prepare_to_modify_buffer alone. It's never
7400 called from outside this function, but that appears to be a bug.
7401 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7402 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7403 (adjust_after_replace_noundo): Remove; unused.
7404 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7405 (signal_before_change): Remove decls.
77382fcc 7406
9306c32e
PE
7407 * indent.c (val_compute_motion, val_vmotion): Now static.
7408
cd44d2eb
PE
7409 * image.c: Make symbols static if they're not exported.
7410 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7411 if USE_GTK.
7412 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7413 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7414
ad9a7a06
PE
7415 * fringe.c (standard_bitmaps): Now static.
7416 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7417
81626931
PE
7418 * frame.c: Make symbols static if they're not exported.
7419 (x_report_frame_params, make_terminal_frame): Now static.
7420 (get_frame_param): Now static, unless HAVE_NS.
7421 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7422 (x_get_resource_string): Remove; not used.
7423 * frame.h (make_terminal_frame, x_report_frame_params):
7424 (x_get_resource_string); Remove decls.
7425 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7426 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7427
239f9db9
PE
7428 * font.c, fontset.c: Make symbols static if they're not exported.
7429 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7430 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7431 * font.c (font_close_object): Now static.
7432 * font.h (font_close_object): Remove.
7433 * fontset.c (FONTSET_OBJLIST): Remove.
7434 (free_realized_fontset) #if-0 the body, which does nothing.
7435 (face_suitable_for_char_p): #if-0, as it's never called.
7436 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7437 * xfaces.c (face_at_string_position):
7438 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7439 since 0 is always ASCII.
7440
dfcf3579
PE
7441 * fns.c (weak_hash_tables): Now static.
7442
5045092b
PE
7443 * fileio.c: Make symbols static if they're not exported.
7444 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7445 (Vwrite_region_annotation_buffers): Now static.
7446
57a96f5c
PE
7447 * eval.c: Make symbols static if they're not exported.
7448 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7449 * lisp.h (backtrace_list): Remove decl.
7450
35f08c38
PE
7451 * emacs.c: Make symbols static if they're not exported.
7452 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7453 (fatal_error_code, fatal_error_signal_hook, standard_args):
7454 Now static.
7455 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7456 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7457 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7458 * lisp.h (fatal_error_signal_hook): Remove decl.
7459 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7460
f44bd759
PE
7461 * editfns.c: Move a (normally-unused) function to its only use.
7462 * editfns.c, lisp.h (get_operating_system_release): Remove.
7463 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7464 worth the hassle of breaking this out.
7465
b532497d
PE
7466 * xterm.c: Make symbols static if they're not exported.
7467 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7468 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7469 (x_destroy_window, x_delete_display):
7470 Now static.
7471 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7472 (x_mouse_leave): Remove; unused.
7473 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7474 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7475 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7476 Remove decls.
7477 (x_mouse_leave): Declare only if WINDOWSNT.
7478 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7479 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7480 USE_X_TOOLKIT.
7481
1675728f
PE
7482 * ftxfont.c: Make symbols static if they're not exported.
7483 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7484 HAVE_FREETYPE.
7485 * font.h (ftxfont_driver): Likewise.
7486
e4cebfca
PE
7487 * xfns.c: Make symbols static if they're not exported.
7488 (x_last_font_name, x_display_info_for_name):
7489 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7490 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7491 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7492 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7493 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7494 (last_show_tip_args): Now static.
7495 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7496 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7497 (x_screen_planes): Remove; unused.
7498 * dispextern.h (x_screen_planes): Remove decl.
7499
5bf46f05
PE
7500 * dispnew.c: Make symbols static if they're not exported.
7501 * dispextern.h (redraw_garbaged_frames, scrolling):
7502 (increment_row_positions): Remove.
7503 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7504 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7505 Now static.
7506 (redraw_garbaged_frames): Remove; unused.
7507
435f4c28
PE
7508 * xfaces.c: Make symbols static if they're not exported.
7509 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7510 Remove decls.
7511 * xterm.h (defined_color): Remove decls.
7512 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7513 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7514 (menu_face_changed_default, defined_color, free_realized_face):
7515 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7516 (ascii_face_of_lisp_face): Remove; unused.
7517
8524aef3
PE
7518 * xdisp.c: Make symbols static if they're not exported.
7519 * dispextern.h (scratch_glyph_row, window_box_edges):
7520 (glyph_to_pixel_coords, set_cursor_from_row):
7521 (get_next_display_element, set_iterator_to_next):
7522 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7523 (show_mouse_face): Remove decls
7524 * frame.h (message_buf_print): Likewise.
7525 * lisp.h (pop_message, set_message, check_point_in_composition):
7526 Likewise.
7527 * xterm.h (set_vertical_scroll_bar): Likewise.
7528 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7529 (message_buf_print, scratch_glyph_row, displayed_buffer):
7530 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7531 (get_next_display_element, show_mouse_face, window_box_edges):
7532 (frame_to_window_pixel_xy, check_point_in_composition):
7533 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7534 (glyph_to_pixel_coords): Remove; unused.
7535
16390cd2
PE
7536 * dired.c (file_name_completion): Now static.
7537
7538 * dbusbind.c (xd_in_read_queued_messages): Now static.
7539
a25f4dfa
PE
7540 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7541 * data.c (circular_list_error): Remove.
7542
14a9c8df
PE
7543 * commands.h (last_point_position, last_point_position_buffer):
7544 (last_point_position_window): Remove decls.
7545 * keyboard.c: Make these variables static.
7546
04f2d78b
CB
7547 * coding.h (coding, code_convert_region, encode_coding_gap):
7548 Remove decls.
74ab6df5
PE
7549 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7550 (iso_code_class, detect_coding, code_convert_region): Now static.
7551 (encode_coding_gap): Remove; unused.
7552
38dfbee1
PE
7553 * chartab.c (chartab_chars, chartab_bits): Now static.
7554
a2cb4e63
PE
7555 * charset.h (charset_iso_8859_1): Remove decl.
7556 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7557 Now static.
7558
127198fd
PE
7559 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7560 * ccl.c (Vccl_program_table): Now static.
7561 (check_ccl_update): Remove; unused.
7562
d85b608f
PE
7563 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7564 * category.h: ... from here.
7565 * category.c (check_category_table, set_category_set): Now static.
7566
31cd66f3
PE
7567 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7568 * lisp.h: Remove these decls.
7569
c358e587
PE
7570 * buffer.c (buffer_count): Remove unused var.
7571
e78aecca
PE
7572 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7573 so that it's not optimized away.
7574 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7575 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7576 exported only to the debugger.
7577
e192d7d3 7578 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7579 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7580
92470028
PE
7581 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7582 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7583 was inaccessible from Lisp.
7584 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7585 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7586
244ed907
PE
7587 alloc.c: Import and export fewer symbols, and remove unused items.
7588 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7589 is defined.
7590 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7591 it's not optimized away by whole-program optimization.
7592 (message_enable_multibyte, free_misc): Remove.
7593 (catchlist, handlerlist, mark_backtrace):
7594 Declare only if BYTE_MARK_STACK.
7595 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7596 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7597 (message_enable_multibyte): Remove decl.
7598 (free_misc, interval_free_list, float_block, float_block_index):
7599 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7600 (cons_free_list, last_marked_index):
7601 Now static.
7602 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7603 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7604 (mark_backtrace): Define only if BYTE_MARK_STACK.
7605 * xdisp.c (message_enable_multibyte): Now static.
7606
61c2b50e 7607 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7608 This makes it easier for human readers (and static analyzers)
7609 to see whether these variables are used from other modules.
7610 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7611 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7612 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7613 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7614 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7615 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7616 * xmenu.c, xselect.c:
7617 Declare Q* vars static if they are not used in other modules.
7618 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7619 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7620 Remove decls of unexported vars.
7621 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7622
95c82688
PE
7623 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7624
16a97296
PE
7625 Make Emacs functions such as Fatom 'static' by default.
7626 This makes it easier for human readers (and static analyzers)
7627 to see whether these functions can be called from other modules.
7628 DEFUN now defines a static function. To make the function external
7629 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7630 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7631 (Finit_image_library):
16a97296
PE
7632 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7633 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7634 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7635 Remove decls, since these functions are now static.
7636 (Funintern, Fget_internal_run_time): New decls, since these functions
7637 were already external.
95c82688 7638
16a97296
PE
7639 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7640 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7641 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7642 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7643 * keyboard.c, keymap.c, lread.c:
7644 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7645 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7646 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7647 Mark functions with DEFUE instead of DEFUN,
7648 if they are used in other modules.
7649 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7650 decls for now-static functions.
7651 * buffer.h (Fdelete_overlay): Remove decl.
7652 * callproc.c (Fgetenv_internal): Mark as internal.
7653 * composite.c (Fremove_list_of_text_properties): Remove decl.
7654 (Fcomposition_get_gstring): New forward static decl.
7655 * composite.h (Fcomposite_get_gstring): Remove decl.
7656 * dired.c (Ffile_attributes): New forward static decl.
7657 * doc.c (Fdocumntation_property): New forward static decl.
7658 * eval.c (Ffetch_bytecode): New forward static decl.
7659 (Funintern): Remove extern decl; now in .h file where it belongs.
7660 * fileio.c (Fmake_symbolic_link): New forward static decl.
7661 * image.c (Finit_image_library): New forward static decl.
7662 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7663 * intervals.h (Fprevious_property_change):
7664 (Fremove_list_of_text_properties): Remove decls.
7665 * keyboard.c (Fthis_command_keys): Remove decl.
7666 (Fcommand_execute): New forward static decl.
7667 * keymap.c (Flookup_key): New forward static decl.
7668 (Fcopy_keymap): Now static.
7669 * keymap.h (Flookup_key): Remove decl.
7670 * process.c (Fget_process): New forward static decl.
7671 (Fprocess_datagram_address): Mark as internal.
7672 * syntax.c (Fsyntax_table_p): New forward static decl.
7673 (skip_chars): Remove duplicate decl.
7674 * textprop.c (Fprevious_property_change): New forward static decl.
7675 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7676 Now internal.
7677 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7678 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7679
785bbd42
PE
7680 * editfns.c (Fformat): Remove unreachable code.
7681
8b913b57
AS
76822011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7683
7684 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7685 change. (Bug#8496)
7686
a6744a35
EZ
76872011-04-13 Eli Zaretskii <eliz@gnu.org>
7688
7689 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7690 when at ZV. (Bug#8487)
7691
e7974947
AS
76922011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7693
baad03f0
AS
7694 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7695 (Bug#8437)
7696 * keyboard.c (parse_tool_bar_item): Likewise.
7697 * sound.c (sound_cleanup, alsa_close): Likewise.
7698 * termcap.c (tgetent): Likewise.
7699 * xfns.c (x_default_font_parameter): Likewise.
7700 * xsettings.c (read_and_apply_settings): Likewise.
7701
e7974947
AS
7702 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7703 (overrun_check_free): Protoize.
7704
28272684
PE
77052011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7706
7707 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7708 since callers should never pass a negative size.
7709 Change the signature to match that of plain 'read' and 'write'; see
7710 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7711 * lisp.h: Update prototypes of emacs_write and emacs_read.
7712
11997c76
EZ
77132011-04-11 Eli Zaretskii <eliz@gnu.org>
7714
7715 * xdisp.c (redisplay_window): Don't try to determine the character
7716 position of the scroll margin if the window start point w->startp
e896f03c 7717 is outside the buffer's accessible region. (Bug#8468)
11997c76 7718
8a2cbd72
EZ
77192011-04-10 Eli Zaretskii <eliz@gnu.org>
7720
7721 Fix write-region and its subroutines for buffers > 2GB.
7722 * fileio.c (a_write, e_write): Modify declaration of arguments and
7723 local variables to support buffers larger than 2GB.
7724 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7725
7726 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7727 argument, local variables, and return value.
7728
7729 * lisp.h: Update prototypes of emacs_write and emacs_read.
7730
7731 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7732
4073e537 77332011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7734
1ebfdcb6
PE
7735 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7736
b2ded58d
PE
7737 Fix more problems found by GCC 4.6.0's static checks.
7738
7d66342c
PE
7739 * xdisp.c (vmessage): Use a better test for character truncation.
7740
bbf47d44
PE
7741 * charset.c (load_charset_map): <, not <=, for optimization,
7742 and to avoid potential problems with integer overflow.
9248994d 7743 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7744 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7745 * editfns.c (Fformat): Likewise.
1e69125e 7746 * syntax.c (skip_chars): Likewise.
3befa583 7747
e3019616
PE
7748 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7749 This also lets GCC 4.6.0 generate slightly better loop code.
7750
becfa255
PE
7751 * callint.c (Fcall_interactively): <, not <=, for optimization.
7752 (Fcall_interactively): Count the number of arguments produced,
7753 not the number of arguments given. This is simpler and lets GCC
7754 4.6.0 generate slightly better code.
7755
dae0cd48
PE
7756 * ftfont.c: Distingish more carefully between FcChar8 and char.
7757 The previous code passed unsigned char * to a functions like
7758 strlen and xstrcasecmp that expect char *, which does not
7759 conform to the C standard.
7760 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7761 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7762 char * when the C standard requires it.
7763
76032d70
PE
7764 * keyboard.c (read_char): Remove unused var.
7765
eb3f1cc8
PE
7766 * eval.c: Port to Windows vsnprintf (Bug#8435).
7767 Include <limits.h>.
7768 (SIZE_MAX): Define if the headers do not.
7769 (verror): Do not give up if vsnprintf returns a negative count.
7770 Instead, grow the buffer. This ports to Windows vsnprintf, which
7771 does not conform to C99. Problem reported by Eli Zaretskii.
7772 Also, simplify the allocation scheme, by avoiding the need for
7773 calling realloc, and removing the ALLOCATED variable.
7774
70476b54
PE
7775 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7776
12020a9e
PE
7777 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7778 But keep the doprint source code for now, as we might revamp it
7779 and use it again (Bug#8435).
ea6c7ae6
PE
7780 * lisp.h (doprnt): Remove.
7781 * Makefile.in (base_obj): Remove doprnt.o.
7782 * deps.mk (doprnt.o): Remove.
7783
5fdb398c
PE
7784 error: Print 32- and 64-bit integers portably (Bug#8435).
7785 Without this change, on typical 64-bit hosts error ("...%d...", N)
7786 was used to print both 32- and 64-bit integers N, which relied on
7787 undefined behavior.
61bdb816 7788 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
7789 * lisp.h (error, verror): Mark as printf-like functions.
7790 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7791 Report overflow in size calculations when allocating printf buffer.
7792 Do not truncate output string at its first null byte.
7793 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7794 Truncate the output at a character boundary, since vsnprintf does not
7795 do that.
7796 * charset.c (check_iso_charset_parameter): Convert internal
7797 character to string before calling 'error', since %c now has the
7798 printf meaning.
7799 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7800 overflow when computing char to be passed to 'error'. Do not
7801 pass Lisp_Object to 'error'; pass the integer instead.
7802 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7803 formatted with plain %d.
7804
b189fa66
PE
7805 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7806
bff87ef0
PE
7807 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7808
7e2cac20
PE
7809 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7810
ce4d90b5
PE
7811 * xterm.c (x_catch_errors): Remove duplicate declaration.
7812
266c9547
PE
7813 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7814
79c49ad2
PE
7815 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7816
368f4090
JM
78172011-04-10 Jim Meyering <meyering@redhat.com>
7818
7819 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7820 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7821 return ssize_t not "int", and use size_t as the buffer length.
7822 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7823 * gnutls.h: Update declarations.
7824 * process.c (read_process_output): Use ssize_t, to match.
7825 (send_process): Likewise.
7826
a32d4040
CY
78272011-04-09 Chong Yidong <cyd@stupidchicken.com>
7828
7829 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7830
8546720e 78312011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7832
04f2d78b
CB
7833 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7834 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7835
8546720e
GM
7836 * xterm.c (handle_one_xevent):
7837 * xmenu.c (create_and_show_popup_menu):
7838 * xselect.c (x_decline_selection_request)
7839 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7840
0a2f5c1a 78412011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7842
7843 Fix some uses of `int' instead of EMACS_INT.
7844 * search.c (string_match_1, fast_string_match)
7845 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7846 (scan_buffer, find_next_newline_no_quit)
7847 (find_before_next_newline, search_command, Freplace_match)
7848 (Fmatch_data): Make some `int' variables be EMACS_INT.
7849
7850 * xdisp.c (display_count_lines): 3rd argument and return value now
7851 EMACS_INT. All callers changed.
7852 (pint2hrstr): Last argument is now EMACS_INT.
7853
7854 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7855 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7856 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7857 (decode_coding_utf_16, decode_coding_emacs_mule)
7858 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7859 (decode_coding_ccl, decode_coding_charset)
7860 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7861 (decode_coding_iso_2022, decode_coding_emacs_mule)
7862 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7863 <char_offset, last_offset>: Declare EMACS_INT.
7864 (encode_coding_utf_8, encode_coding_utf_16)
7865 (encode_coding_emacs_mule, encode_invocation_designation)
7866 (encode_designation_at_bol, encode_coding_iso_2022)
7867 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7868 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7869 Declare EMACS_INT.
7870 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7871 (encode_invocation_designation): Last argument P_NCHARS is now
7872 EMACS_INT.
7873 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7874 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7875
7876 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7877 All users changed.
7878
7879 * ccl.c (Fccl_execute_on_string): Declare some variables
7880 EMACS_INT.
7881
8546720e 78822011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7883
7884 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7885
4e19a977
CS
78862011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7887
7888 * process.c (Fformat_network_address): Doc fix.
7889
87302331
R
78902011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7891
ee7683eb 7892 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7893
cbb59342
CY
78942011-04-08 Chong Yidong <cyd@stupidchicken.com>
7895
7896 * keyboard.c (read_char): Call Lisp function help-form-show,
7897 instead of using internal_with_output_to_temp_buffer.
7898 (Qhelp_form_show): New var.
e0d38eeb 7899 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7900
7901 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7902
7903 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7904
e67a13ab
CY
79052011-04-06 Chong Yidong <cyd@stupidchicken.com>
7906
04f2d78b
CB
7907 * process.c (Flist_processes): Remove to Lisp.
7908 (list_processes_1): Delete.
e67a13ab 7909
973f782d
EZ
79102011-04-06 Eli Zaretskii <eliz@gnu.org>
7911
7c106b1e
EZ
7912 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7913
973f782d
EZ
7914 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7915
41cf7d1a 79162011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7917
ca23cc88
PE
7918 Fix more problems found by GCC 4.6.0's static checks.
7919
f390e2d5
PE
7920 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7921
42eea0d0
PE
7922 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7923
b69769da 7924 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7925
f9541e84
PE
7926 * xdisp.c (vmessage): Mark as a printf-like function.
7927
13841b55
PE
7928 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7929
c136c10f
PE
7930 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7931
5e2d4a30
PE
7932 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7933 printf-like functions.
7934 (tiff_load): Add casts to remove these marks before passing them
7935 to system-supplied API.
7936
583f48b9
PE
7937 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7938
b25d760e
PE
7939 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7940 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7941 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7942 directly, rather than having caller test rule sign. This avoids
7943 some unnecessary tests.
7944 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7945 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7946 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7947
bc7b6697 7948 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7949 (xfont_open): Avoid unnecessary tests.
bc7b6697 7950
27ccc379
PE
7951 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7952
dcd5c89a
PE
7953 * composite.h, composite.c (composition_gstring_put_cache):
7954 Use EMACS_INT, not int, for length.
7955
b13a45c6
PE
7956 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7957 breaking out part of COMPOSITION_DECODE_RULE.
7958 (COMPOSITION_DECODE_RULE): Use it.
7959 * composite.c (get_composition_id): Remove unused local vars,
7960 by using the new macro.
7961
1e792e4d
PE
7962 * textprop.c (set_text_properties_1): Change while to do-while,
7963 since the condition is always true at first.
7964
dc6c6455 7965 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7966 (interval_deletion_adjustment): Return unsigned value.
7967 All uses changed.
dc6c6455 7968
aba7731a
PE
7969 * process.c (list_processes_1, create_pty, read_process_output):
7970 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7971 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7972 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7973 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7974 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7975
fdfc4bf3
PE
7976 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7977
fca8fe46 7978 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7979 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7980
06a0259a 7981 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7982 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7983 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7984
e7b9e80f
PE
7985 * print.c (print_error_message): Avoid int overflow.
7986
56201685
PE
7987 * font.c (font_list_entities): Redo for clarity,
7988 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7989
78834453 7990 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7991 (font_score): Avoid potential overflow in diff calculation.
78834453 7992
0bc0b309 7993 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7994 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7995
e610eaca
PE
7996 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7997
b895abce
PE
7998 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7999 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8000 can always succeed if overflow has undefined behavior.
8001
1f1d9321 8002 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8003 (wordify): Omit three unnecessary tests.
1f1d9321 8004
c59478bc
PE
8005 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8006 All callers changed. This avoids the need for an unused var.
8007
79b73827
PE
8008 * casefiddle.c (casify_region): Remove var that is set but not used.
8009
a4db5dfe
PE
8010 * dired.c (file_name_completion): Remove var that is set but not used.
8011
43aae36e
PE
8012 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8013
2a47c44d 8014 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8015 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8016
a37c69bf
PE
8017 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8018 Check for integer overflow on size calculations.
8019
328ab8e7
PE
8020 * buffer.c (Fprevious_overlay_change): Remove var that is set
8021 but not used.
8022
e5a2a5cb
PE
8023 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8024 Remove vars that are set but not used.
8d84a6eb 8025 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8026 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8027
a60e5f68
PE
8028 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8029
f661cb61 8030 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8031 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8032
f0397f5a
PE
8033 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8034 that are set but not used.
8035
8664db06 8036 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8037 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8038
6abdaa4a
PE
8039 * xselect.c (x_get_local_selection, x_handle_property_notify):
8040 Remove vars that are set but not used.
8041
0ce7538d 8042 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8043 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8044
9ae848fc
PE
8045 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8046 Remove var that is set but not used.
0b918413
PE
8047 (scroll_bar_windows_size): Now size_t, not int.
8048 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8049 Check for overflow.
9ae848fc 8050
a5a62657
PE
8051 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8052 (map_tty_color) [!defined MSDOS]: Likewise.
8053
5c5cdd39
PE
8054 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8055
66ebf983
PE
8056 * coding.c: Remove vars that are set but not used.
8057 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8058 All callers changed.
8059 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8060 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8061 (decode_coding_charset): Remove vars that are set but not used.
8062
1be4d761
PE
8063 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8064 that is set but not used.
8065
47553fa8
PE
8066 * print.c (print_object): Remove var that is set but not used.
8067
1f7196bf 8068 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8069 The gnulib version avoids calling malloc in the usual case,
8070 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8071 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8072 * filelock.c (current_lock_owner): Likewise.
8073 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8074 * sysdep.c: Include allocator.h, careadlinkat.h.
8075 (emacs_no_realloc_allocator): New static constant.
8076 (emacs_readlink): New function.
fdb61804
PE
8077 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8078 ../lib/careadlinkat.h.
d1fdcab7 8079
f84c17c7
SM
80802011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8081
8082 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8083 first non-nil return value).
8084
ef3862ad
JD
80852011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8086
8087 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8088 if not defined (Bug#8403).
8089
376a7006
JB
80902011-04-02 Juanma Barranquero <lekktu@gmail.com>
8091
8092 * xdisp.c (display_count_lines): Remove parameter `start',
8093 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8094 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8095 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8096 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8097 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8098 and thereabouts. All callers changed.
8099 (get_per_char_metric): Remove parameter `f', unused since
8100 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8101
6ca3801d
JM
81022011-04-02 Jim Meyering <meyering@redhat.com>
8103
8104 do not dereference NULL upon failed strdup
8105 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8106 (ns_get_family): Likewise.
8107
d8e2b5ba
JB
81082011-04-02 Juanma Barranquero <lekktu@gmail.com>
8109
8110 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8111
8c74fcbd
JD
81122011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8113
8114 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8115 later (Bug#8403).
8116
7200d79c
SM
81172011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8118
03408648 8119 Add lexical binding.
7200d79c 8120
03408648
SM
8121 * window.c (Ftemp_output_buffer_show): New fun.
8122 (Fsave_window_excursion):
8123 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8124
8125 * lread.c (lisp_file_lexically_bound_p): New function.
8126 (Fload): Bind Qlexical_binding.
8127 (readevalloop): Remove `evalfun' arg.
8128 Bind Qinternal_interpreter_environment.
8129 (Feval_buffer): Bind Qlexical_binding.
8130 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8131 Mark as dynamic.
8132 (syms_of_lread): Declare `lexical-binding'.
8133
8134 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8135
8136 * keyboard.c (eval_dyn): New fun.
8137 (menu_item_eval_property): Use it.
ca105506
SM
8138
8139 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8140
03408648
SM
8141 * fns.c (concat, mapcar1): Accept byte-code-functions.
8142
8143 * eval.c (Fsetq): Handle lexical vars.
8144 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8145 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8146 (FletX, Flet): Obey lexical binding.
8147 (Fcommandp): Handle closures.
8148 (Feval): New `lexical' arg.
8149 (eval_sub): New function extracted from Feval. Use it almost
8150 everywhere where Feval was used. Look up vars in lexical env.
8151 Handle closures.
8152 (Ffunctionp): Move from subr.el.
8153 (Ffuncall): Handle closures.
8154 (apply_lambda): Remove `eval_flags'.
8155 (funcall_lambda): Handle closures and new byte-code-functions.
8156 (Fspecial_variable_p): New function.
8157 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8158 but without exporting it to Lisp.
23aba0ea 8159
23aba0ea 8160 * doc.c (Fdocumentation, store_function_docstring):
03408648 8161 * data.c (Finteractive_form): Handle closures.
23aba0ea 8162
03408648
SM
8163 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8164 interactive spec.
ba83908c 8165
04f2d78b
CB
8166 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8167 New byte-codes.
03408648
SM
8168 (exec_byte_code): New function extracted from Fbyte_code to handle new
8169 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8170
03408648 8171 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8172
03408648 8173 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8174
e2abce01
JB
81752011-03-31 Juanma Barranquero <lekktu@gmail.com>
8176
8177 * xdisp.c (redisplay_internal): Fix prototype.
8178
63696a73 81792011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8180
63696a73 8181 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8182 (try_scrolling): Use it when setting scroll_limit.
8183 Limit scrolling to 100 screen lines.
63696a73
EZ
8184 (redisplay_window): Even when falling back on "recentering",
8185 position point in the window according to scroll-conservatively,
8186 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8187
8188 (try_scrolling): When point is above the window, allow searching
8189 as far as scroll_max, or one screenful, to compute vertical
8190 distance from PT to the scroll margin position. This prevents
8191 try_scrolling from unnecessarily failing when
8192 scroll-conservatively is set to a value slightly larger than the
8193 window height. Clean up the case of PT below the margin at bottom
8194 of window: scroll_max can no longer be INT_MAX. When aggressive
8195 scrolling is in use, don't let point enter the opposite scroll
8196 margin as result of the scroll.
8197 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8198 threshold of 100 lines for never-recentering scrolling.
8199
e4cc2dfc
JB
82002011-03-31 Juanma Barranquero <lekktu@gmail.com>
8201
8202 * dispextern.h (move_it_by_lines):
8203 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8204 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8205 (message_log_check_duplicate): Remove parameters `prev_bol' and
8206 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8207 (redisplay_internal): Remove parameter `preserve_echo_area',
8208 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8209
8210 * indent.c (Fvertical_motion):
8211 * window.c (window_scroll_pixel_based, Frecenter):
8212 Don't pass `need_y_p' to `move_it_by_lines'.
8213
1c470562
SM
82142011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8215
44f230aa
SM
8216 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8217 steal a few bits to be more compact.
8218 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8219 Remove unneeded casts.
8220
1c470562
SM
8221 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8222
888adce9
ZK
82232011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8224
8225 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8226 binding" message (bug#7967).
8227
f838ed7b
PE
82282011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8229
77861b95
PE
8230 Fix more problems found by GCC 4.6.0's static checks.
8231
de6dbc14
PE
8232 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8233 Remove unused local var.
8234
f838ed7b
PE
8235 * editfns.c (Fmessage_box): Remove unused local var.
8236
792c7b2b
PE
8237 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8238 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8239 Omit unused local vars.
c499e557 8240 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8241 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8242 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8243 Omit unused local var.
8244
ba0165e1
PE
8245 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8246 Don't assume string length fits in int.
32ad8845 8247 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8248 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8249
3c59b4c9
PE
8250 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8251 instead of alloca (Bug#8344).
8252
a3eed478 8253 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8254 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8255
eb4d412d
PE
8256 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8257
1658b401
PE
8258 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8259 concerns.
8260
8261 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8262
8263 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8264
9a2c6e05
PE
8265 * keyboard.c (syms_of_keyboard): Use the same style as later
8266 in this function when indexing through an array. This also
8267 works around GCC bug 48267.
8268
03d0a109
PE
8269 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8270
44f730c8
PE
8271 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8272
fe75f926
PE
8273 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8274 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8275
ffa8c828
PE
8276 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8277 This avoids undefined behavior on integer overflow, and is a bit
8278 more convenient anyway since it is compared to a size_t variable.
8279
c5101a77
PE
8280 Variadic C functions now count arguments with size_t, not int.
8281 This avoids an unnecessary limitation on 64-bit machines, which
8282 caused (substring ...) to crash on large vectors (Bug#8344).
8283 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8284 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8285 All variadic functions and their callers changed accordingly.
c5101a77
PE
8286 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8287 * data.c (arith_driver, float_arith_driver): Likewise.
8288 * editfns.c (general_insert_function): Likewise.
8289 * eval.c (struct backtrace.nargs, interactive_p)
8290 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8291 (funcall_lambda, mark_backtrace): Likewise.
8292 * fns.c (concat): Likewise.
8293 * frame.c (x_set_frame_parameters): Likewise.
8294 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8295 0 if not found, not -1. All callers changed.
8296
dd3f25f7
PE
8297 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8298 (stack_copy_size): Now size_t, not int.
8299 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8300
461c2ab9
JB
83012011-03-28 Juanma Barranquero <lekktu@gmail.com>
8302
8303 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8304 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8305 All callers changed.
8306
8307 * lisp.h (multibyte_char_to_unibyte):
8308 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8309 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8310 * character.h (CHAR_TO_BYTE8):
8311 * cmds.c (internal_self_insert):
8312 * editfns.c (general_insert_function):
8313 * keymap.c (push_key_description):
8314 * search.c (Freplace_match):
8315 * xdisp.c (message_dolog, set_message_1): All callers changed.
8316
f6d62986
SM
83172011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8318
8319 * keyboard.c (safe_run_hook_funcall): New function.
8320 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8321 don't set the hook to nil, but remove the offending function instead.
8322 (Qcommand_hook_internal): Remove, unused.
8323 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8324 Vcommand_hook_internal.
8325
8326 * eval.c (enum run_hooks_condition): Remove.
8327 (funcall_nil, funcall_not): New functions.
8328 (run_hook_with_args): Call each function through a `funcall' argument.
8329 Remove `cond' argument, now redundant.
8330 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8331 (Frun_hook_with_args_until_failure): Adjust accordingly.
8332 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8333
1db5b1ad
JB
83342011-03-28 Juanma Barranquero <lekktu@gmail.com>
8335
8336 * dispextern.h (string_buffer_position): Remove declaration.
8337
8338 * print.c (strout): Remove parameter `multibyte', unused since
8339 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8340
8341 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8342 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8343 All callers changed.
8344
8345 * w32.c (_wsa_errlist): Use braces for struct initializers.
8346
8347 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8348 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8349 All callers changed.
8350 (string_buffer_position): Likewise. Also, make static (it's never
8351 used outside xdisp.c).
8352 (cursor_row_p): Remove parameter `w', unused since
8353 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8354 (decode_mode_spec): Remove parameter `precision', introduced during
8355 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8356 All callers changed.
8357
5ffb62aa
JD
83582011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8359
8360 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8361
461c2ab9 83622011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8363
8364 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8365 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8366 (ns_update_auto_hide_menu_bar): New functions.
8367 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8368 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8369 ns_constrain_all_frames.
8370 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8371 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8372
5c380ffb
JD
83732011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8374
8375 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8376
9af30bdf
GM
83772011-03-27 Glenn Morris <rgm@gnu.org>
8378
8379 * syssignal.h: Replace RETSIGTYPE with void.
8380 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8381 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8382 Replace SIGTYPE with void everywhere.
8383 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8384 * s/template.h (SIGTYPE): Remove commented out definition.
8385
e2abce01
JB
83862011-03-26 Eli Zaretskii <eliz@gnu.org>
8387
8388 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8389 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8390
f868cd8a
JB
83912011-03-26 Juanma Barranquero <lekktu@gmail.com>
8392
59eb0929
JB
8393 * w32.c (read_unc_volume): Use parameter `henum', instead of
8394 global variable `wget_enum_handle'.
8395
8396 * keymap.c (describe_vector): Remove parameters `indices' and
8397 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8398 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8399
f868cd8a
JB
8400 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8401
8402 * keyboard.c (timer_check): Remove parameter `do_it_now',
8403 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8404 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8405 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8406
8407 * keyboard.c (read_char):
8408 * w32menu.c (w32_menu_display_help):
8409 * xmenu.c (show_help_event, menu_help_callback):
8410 Adjust calls to `show_help_echo'.
8411
8412 * gtkutil.c (xg_maybe_add_timer):
8413 * keyboard.c (readable_events):
8414 * process.c (wait_reading_process_output):
8415 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8416
8417 * insdel.c (adjust_markers_gap_motion):
8418 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8419 (gap_left, gap_right): Don't call it.
8420
2ecf6fdb
CY
84212011-03-25 Chong Yidong <cyd@stupidchicken.com>
8422
8423 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8424 incurred during fontification.
8425
6b1f9ba4
JB
84262011-03-25 Juanma Barranquero <lekktu@gmail.com>
8427
8428 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8429 (DEFVAR_PER_BUFFER): Don't pass it.
8430
8431 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8432 (scrolling_window): Don't pass it.
8433
0f4a96b5
JB
84342011-03-25 Juanma Barranquero <lekktu@gmail.com>
8435
8436 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8437
8438 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8439 and `suffix'.
8440 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8441 of variables specific to SELinux and computation of `encoded_absname'.
8442
8443 * image.c (XPutPixel): Remove unused variable `height'.
8444
8445 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8446
8447 * unexw32.c (get_section_info): Remove unused variable `section'.
8448
8449 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8450 (system_process_attributes): Remove unused variable `sess'.
8451 (sys_read): Remove unused variable `err'.
8452
8453 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8454 (w32_wnd_proc): Remove unused variable `isdead'.
8455 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8456 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8457 (x_create_tip_frame): Remove unused variable `tem'.
8458
8459 * w32inevt.c (w32_console_read_socket):
8460 Remove unused variable `no_events'.
8461
8462 * w32term.c (x_draw_composite_glyph_string_foreground):
8463 Remove unused variable `width'.
8464
1149507c
JB
84652011-03-24 Juanma Barranquero <lekktu@gmail.com>
8466
8467 * w32term.c (x_set_glyph_string_clipping):
8468 Don't pass uninitialized region to CombineRgn.
8469
9c88f339
JB
84702011-03-23 Juanma Barranquero <lekktu@gmail.com>
8471
8472 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8473 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8474 (Fx_close_connection): Remove unused variable `i'.
8475
8476 * w32font.c (w32font_draw): Return number of glyphs.
8477 (w32font_open_internal): Remove unused variable `i'.
8478 (w32font_driver): Add missing initializer.
8479
8480 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8481 (fill_in_menu): Remove unused variable `items_added'.
8482
8483 * w32term.c (last_mouse_press_frame): Remove static global variable.
8484 (w32_clip_to_row): Remove unused variable `f'.
8485 (x_delete_terminal): Remove unused variable `i'.
8486
8487 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8488 (NOTHING): Remove unused static global variable.
8489 (uniscribe_check_otf): Remove unused variable `table'.
8490 (uniscribe_font_driver): Add missing initializers.
8491
dee091a3
JD
84922011-03-23 Julien Danjou <julien@danjou.info>
8493
8494 * term.c (Fsuspend_tty, Fresume_tty):
8495 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8496 * window.c (temp_output_buffer_show):
8497 * insdel.c (signal_before_change):
8498 * frame.c (Fhandle_switch_frame):
8499 * fileio.c (Fdo_auto_save):
8500 * emacs.c (Fkill_emacs):
8501 * editfns.c (save_excursion_restore):
8502 * cmds.c (internal_self_insert):
8503 * callint.c (Fcall_interactively):
8504 * buffer.c (Fkill_all_local_variables):
8505 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8506 Use Frun_hooks.
0f4a96b5 8507 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8508 unconditionally since it does the check itself.
dee091a3 8509
2c520ab5 85102011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8511
c9c49752
PE
8512 Fix more problems found by GCC 4.5.2's static checks.
8513
8abc3f12
PE
8514 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8515 the first time through the loop, since we know p0 < p1 then.
8516 This also avoids a gcc -Wstrict-overflow warning.
8517
a2d26660
PE
8518 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8519 leading to a memory leak, possible in functions like
8520 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8521 of objects (Bug#8318).
a2d26660 8522
916c72e9
PE
8523 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8524 that could (at least in theory) be that large.
8525
19ab8a18
PE
8526 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8527 This is less likely to overflow, and avoids undefined behavior if
8528 overflow does occur. All callers changed. Use strtoul to scan
8529 for the unsigned long integer.
b7cbbd6f
PE
8530 (pint2hrstr): Simplify and tune code slightly.
8531 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8532
f0641eff
PE
8533 * scroll.c (do_scrolling): Work around GCC bug 48228.
8534 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8535
7f650bb9
PE
8536 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8537 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8538 (validate_x_resource_name): Simplify count usage.
8539 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8540
37dd57d1
PE
8541 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8542 fail (Bug#8306).
81e56e61 8543
699979fc 8544 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8545
401bf9b4
PE
8546 * process.c (Fmake_network_process): Use socklen_t, not int,
8547 where POSIX says socklen_t is required in portable programs.
8548 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8549 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8550 (Fmake_network_process, server_accept_connection):
8551 (wait_reading_process_output, read_process_output):
8552 Likewise.
8553
b93aacde
PE
8554 * process.c: Rename or move locals to avoid shadowing.
8555 (list_processes_1, Fmake_network_process):
8556 (read_process_output_error_handler, exec_sentinel_error_handler):
8557 Rename or move locals.
4dc343ee 8558 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8559 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8560 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8561 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8562 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8563
af8a867c 8564 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8565 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8566 Include tparam.h instead, since it declares them.
af8a867c
PE
8567 * cm.h (PC): Remove extern decl; tparam.h now does this.
8568 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8569 * terminfo.c: Include tparam.h, to check interfaces.
8570 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8571 (tparam): Adjust signature to match interface in tparam.h;
8572 this removes some undefined behavior. Check that outstring and len
8573 are zero, which they always are with Emacs.
8574 * tparam.h (PC, BC, UP): New extern decls.
8575
0248044d 8576 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8577 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8578
8ff096c1 8579 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8580 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8581 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8582 (ftfont_list): Remove unused local.
49eaafba
PE
8583 (get_adstyle_property, ftfont_pattern_entity):
8584 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8585 Rename locals to avoid shadowing.
8ff096c1 8586
e2be39f6
PE
8587 * xfont.c (xfont_list_family): Mark var as initialized.
8588
c9735e30
PE
8589 * xml.c (make_dom): Now static.
8590
8f5201ae
PE
8591 * composite.c (composition_compute_stop_pos): Rename local to
8592 avoid shadowing.
b246f932
PE
8593 (composition_reseat_it): Remove unused locals.
8594 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8595 (composition_update_it): Mark var as initialized.
11b61122
PE
8596 (find_automatic_composition): Mark vars as initialized,
8597 with a FIXME (Bug#8290).
8f5201ae 8598
760fbc2c
PE
8599 character.h: Rename locals to avoid shadowing.
8600 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8601 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8602 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8603 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8604 to avoid shadowing.
8605
ff08eb85
PE
8606 * textprop.c (property_change_between_p): Remove; unused.
8607
fc7bf025
PE
8608 * intervals.c (interval_start_pos): Now static.
8609
235d7abc
PE
8610 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8611
44f230aa
SM
8612 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8613 Rename locals to avoid shadowing.
3e7d6594 8614
50060332
PE
8615 * sound.c (wav_play, au_play, Fplay_sound_internal):
8616 Fix pointer signedness.
d01f234b 8617 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8618 (wav_play): Initialize a variable to 0, to prevent undefined
8619 behavior (Bug#8278).
50060332 8620
c4fc4e30
PE
8621 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8622
918436ed
PE
8623 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8624
c939f91b
PE
8625 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8626 clobbering (Bug#8298).
b9c7f648
PE
8627 * sysdep.c (sys_subshell): Likewise.
8628 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8629
6bd8c144
PE
8630 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8631 This should get cleaned up, so that child_setup has the
8632 same signature on all platforms.
8633
7710357c 8634 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8635 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8636
c59da222
CY
86372011-03-22 Chong Yidong <cyd@stupidchicken.com>
8638
8639 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8640 not to be necessary, and produces flickering.
8641
66b87493
GM
86422011-03-20 Glenn Morris <rgm@gnu.org>
8643
8644 * config.in: Remove file.
8645
45b6f6d5
JB
86462011-03-20 Juanma Barranquero <lekktu@gmail.com>
8647
8648 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8649 are now in src/globals.h.
8650 (syms_of_minibuf): Remove spurious & from previous change.
8651
cd394be1 86522011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8653
8654 * minibuf.c (completing-read-function): New variable.
8655 (completing-read-default): Rename from completing-read.
8656 (completing-read): Call completing-read-function.
8657
b14e3e21
CY
86582011-03-19 Juanma Barranquero <lekktu@gmail.com>
8659
8660 * xfaces.c (Fx_load_color_file):
8661 Read color file from absolute filename (bug#8250).
8662
f2b726e6
JB
86632011-03-19 Juanma Barranquero <lekktu@gmail.com>
8664
8665 * makefile.w32-in: Update dependencies.
8666
09f6ff02
EZ
86672011-03-17 Eli Zaretskii <eliz@gnu.org>
8668
8669 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8670
29a6015a
PE
86712011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8672
a3a6c54e
PE
8673 Fix more problems found by GCC 4.5.2's static checks.
8674
b766f867
PE
8675 * process.c (make_serial_process_unwind, send_process_trap):
8676 (sigchld_handler): Now static.
8677
be02381c
PE
8678 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8679 That way, the code declares only the vars that it needs.
8680 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8681 * s/cygwin.h (PTY_ITERATION): Likewise.
8682 * s/darwin.h (PTY_ITERATION): Likewise.
8683 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8684
57048744
PE
8685 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8686 * process.c (allocate_pty): Don't declare stb unless it's needed.
8687
7914961c 8688 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8689 (CONSTANTLIM): Remove; unused.
8690 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8691 Define only if needed.
7914961c 8692
b3967b18
PE
8693 * unexelf.c (unexec): Name an expression,
8694 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8695 Use a different way to cause a compilation error if anyone uses
8696 n rather than nn, a way that does not involve shadowing.
73366a00 8697 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8698
29a6015a
PE
8699 * deps.mk (unexalpha.o): Remove; unused.
8700
43cfc33e 8701 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8702 * unexec.h: New file.
ce701a33
PE
8703 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8704 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8705 Depend on unexec.h.
8706 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8707 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8708 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8709 Change as necessary to match prototype in unexec.h.
ce701a33 8710
01f44d5a
PE
8711 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8712 shadowing.
4f63c6bb 8713 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8714
a6670b0b
PE
8715 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8716 Rename locals to avoid shadowing.
8717
cef2010d 8718 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8719 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8720
d4d7173a
PE
8721 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8722
f08b802a
PE
8723 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8724 warning when compiling print.c.
8725
3ddb0639
PE
8726 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8727 instead of using an uninitialized var.
5ad03b97 8728 (font_sort_entities): Mark var as initialized.
3ddb0639 8729
170a2692
PE
8730 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8731
e663c700
PE
8732 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8733 pointers to constants.
89bc529a 8734 (font_parse_fcname): Remove unused vars.
7b81e2d0 8735 (font_delete_unmatched): Now static.
ea838e10 8736 (font_get_spec): Remove; unused.
13a547c6
PE
8737 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8738 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8739 Rename or move locals to avoid shadowing.
e663c700 8740
2a80c887 8741 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8742 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8743
1384fa33 8744 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8745 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8746
8b2c52e9
PE
8747 * alloc.c (mark_backtrace): Move decl from here ...
8748 * lisp.h: ... to here, so that it can be checked.
8749
475545b5 8750 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8751 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8752 (lisp_indirect_variable): Name an expression,
8753 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8754 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8755
b1349114 8756 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8757 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8758 Use const pointer when appropriate.
b1349114 8759
a2928364
PE
8760 * lisp.h (get_system_name, get_operating_system_release):
8761 Move decls here, to check interfaces.
8762 * process.c (get_operating_system_release): Move decl to lisp.h.
8763 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8764 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8765 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8766 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8767 (Fformat_time_string, Fencode_time, Finsert_char):
8768 (Ftranslate_region_internal, Fformat):
8769 Rename or remove local vars to avoid shadowing.
9710023e 8770 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8771
a415e694
PE
8772 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8773 avoid shadowing.
8774
8ef4622d
PE
8775 * lisp.h (eassert): Check that the argument compiles, even if
8776 ENABLE_CHECKING is not defined.
8777
946f9a5b
PE
8778 * data.c (Findirect_variable): Name an expression, to avoid
8779 gcc -Wbad-function-cast warning.
112396d6 8780 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8781 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8782 (Fmake_variable_buffer_local, Fmake_local_variable):
8783 Mark variables as initialized.
52746918 8784 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8785
e5aab7e7 8786 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8787 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8788 Rename locals to avoid shadowing.
dff45157
PE
8789 (mark_stack): Move local variables into the #ifdef region where
8790 they're used.
7bc26fdb
PE
8791 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8792 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8793 needed otherwise.
8794 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8795 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8796 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8797
e5aab7e7
PE
8798 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8799 avoids undefined behavior in theory.
8800
4da60324
PE
8801 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8802
88043301
PE
8803 Use functions, not macros, for up- and down-casing (Bug#8254).
8804 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8805 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8806 to use the following functions instead of these macros.
8807 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8808 EMACS_INT, since callers assume the returned value fits in int.
8809 (upcase1): Likewise, for UPCASE_TABLE.
8810 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8811 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8812 the race-condition problem in the old DOWNCASE.
88043301 8813
19ed5445
PE
8814 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8815 Rename locals to avoid shadowing.
8816 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8817 (regex_compile, re_search_2, re_match_2_internal):
8818 Remove unused local vars.
952db0d7
PE
8819 (FREE_VAR): Rewrite so as not to use empty "else",
8820 which gcc can warn about.
da053e48 8821 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8822 (RETALLOC_IF): Define only if needed.
8823 (WORDCHAR_P): Likewise. This one is never needed, but is used
8824 only in a comment talking about a compiler bug, so put inside
8825 the #if 0 of that comment.
8826 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8827 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8828 Remove; unused.
19ed5445 8829
1f3561e4 8830 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8831 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8832 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8833
ded6f8f7
PE
8834 * search.c (simple_search): Remove unused var.
8835
dbd37a95
PE
8836 * dired.c (compile_pattern): Move decl from here ...
8837 * lisp.h: ... to here, so that it can be checked.
8838 (struct re_registers): New forward decl.
8839
7e47afad
PE
8840 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8841
85f24f61
PE
8842 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8843 All uses changed.
8844 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8845 Rename locals to avoid shadowing.
5671df8f 8846 (Fvertical_motion): Mark locals as initialized.
85f24f61 8847
181aa2be 8848 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8849 (casify_region): Mark local as initialized.
181aa2be 8850
930d429c
PE
8851 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8852
7082eac6
PE
8853 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8854 New macros, so that the caller can use some names other than
8855 gcpro1, gcpro2, etc.
8856 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8857 of the new macros.
8858 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8859 argument, for consistency with GCPRO2_VAR, etc: it is now the
8860 prefix of the variable, not the variable itself. All uses
8861 changed.
38b2c076
PE
8862 * dired.c (directory_files_internal, file_name_completion):
8863 Rename locals to avoid shadowing.
8864
15206ed9
PE
8865 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8866 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8867 dired.c's scmp function, had undefined behavior.
8868 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8869 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8870 * buffer.h: ... to here, because these macros use current_buffer,
8871 and the new implementation with inline functions needs to have
8872 current_buffer in scope now, rather than later when the macros
8873 are used.
8874 (downcase, upcase1): New static inline functions.
8875 (DOWNCASE, UPCASE1): Reimplement using these functions.
8876 This avoids undefined behavior in expressions like
8877 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8878 from race conditions in accessing the global variables
8879 case_temp1 and case_temp2.
8880 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8881 * lisp.h (case_temp1, case_temp2): Remove their decls.
8882 * character.h (ASCII_CHAR_P): Move from here ...
8883 * lisp.h: ... to here, so that the inline functions mentioned
8884 above can use them.
8885
4a6bea26
PE
8886 * dired.c (directory_files_internal_unwind): Now static.
8887
f14b7e14
PE
8888 * fileio.c (file_name_as_directory, directory_file_name):
8889 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8890 Now static.
2893f146
PE
8891 (file_name_as_directory): Use const pointers when appropriate.
8892 (Fexpand_file_name): Likewise. In particular, newdir might
8893 point at constant storage, so make it a const pointer.
fd4ead52 8894 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8895 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8896 signedness issues.
f839df0c
PE
8897 (Fset_file_times, Finsert_file_contents, auto_save_error):
8898 Rename locals to avoid shadowing.
f14b7e14 8899
5716756e 8900 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8901 (Ftry_completion, Fall_completions): Rename or remove locals
8902 to avoid shadowing.
5716756e 8903
b4c3046a
PE
8904 * marker.c (bytepos_to_charpos): Remove; unused.
8905
b45db522
PE
8906 * lisp.h (verify_bytepos, count_markers): New decls,
8907 so that gcc does not warn that these functions aren't declared.
8908
85876d07
PE
8909 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8910 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8911 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8912 (copy_text): Remove unused local var.
85876d07 8913
03d78a21 8914 * filelock.c (within_one_second): Now static.
b3dd38ab 8915 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8916
5df8f01b
PE
8917 * buffer.c (fix_overlays_before): Mark locals as initialized.
8918 (fix_start_end_in_overlays): Likewise. This function should be
8919 simplified by using pointers-to-pointers, but that's a different
8920 matter.
b1d876f1 8921 (switch_to_buffer_1): Now static.
8f54f30a
PE
8922 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8923 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8924
a70072c9 8925 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8926 Fix pointer signedness issue.
edced198
PE
8927 (sys_subshell): Mark local as volatile if checking for lint,
8928 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8929 (MAXPATHLEN): Define only if needed.
a70072c9 8930
a0977c44
PE
8931 * process.c (serial_open, serial_configure): Move decls from here ...
8932 * systty.h: ... to here, so that they can be checked.
8933
a884fdcc
PE
8934 * fns.c (get_random, seed_random): Move extern decls from here ...
8935 * lisp.h: ... to here, so that they can be checked.
8936
604efe86 8937 * sysdep.c (reset_io): Now static.
b8950c94 8938 (wait_for_termination_signal): Remove; unused.
604efe86 8939
38fc62d9
PE
8940 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8941 (copy_keymap_item, append_key, push_text_char_description):
8942 Now static.
1004a21a 8943 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8944 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8945 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8946 (describe_map_tree):
8947 Rename locals to avoid shadowing.
38fc62d9 8948
2f2650da
PE
8949 * keyboard.c: Declare functions static if they are not used elsewhere.
8950 (echo_char, echo_dash, cmd_error, top_level_2):
8951 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8952 (read_char, kbd_buffer_get_event, make_lispy_position):
8953 (make_lispy_event, make_lispy_movement, apply_modifiers):
8954 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8955 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8956 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8957 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8958 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8959
a053e86c 8960 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8961 (mark_kboards): Move decl here ...
8962 * alloc.c (mark_kboards): ... from here.
a053e86c 8963
4752793e
PE
8964 * lisp.h (force_auto_save_soon): New decl.
8965
74f10ca7 8966 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8967 (DEFINE_DUMMY_FUNCTION): New macro.
8968 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8969 Use it.
c03cd23f
PE
8970 (main): Add casts to avoid warnings
8971 if GCC considers string literals to be constants.
74f10ca7 8972
022e70d4
PE
8973 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8974
59d6fe83
PE
8975 * dbusbind.c: Pointer signedness fixes.
8976 (xd_signature, xd_append_arg, xd_initialize):
8977 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8978 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8979 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8980 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8981
78320123
PE
8982 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8983 if GCC considers string literals to be constants.
49cebcca 8984 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8985
35ac2a97
SM
89862011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8987
fb103ca9
SM
8988 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8989 (print_preprocess, print_object): New macro to fix last change.
8990
35ac2a97
SM
8991 * print.c (print_preprocess): Don't forget font objects.
8992
62973b41
JB
89932011-03-16 Juanma Barranquero <lekktu@gmail.com>
8994
8995 * emacs.c (USAGE3): Doc fixes.
8996
0e48bb22
AS
89972011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8998
8999 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9000 structure.
9001
7684e57b
JB
90022011-03-14 Juanma Barranquero <lekktu@gmail.com>
9003
9004 * lisp.h (VWindow_system, Qfile_name_history):
9005 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9006 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9007 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9008
9009 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9010 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9011
9012 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9013 * w32console.c (detect_input_pending, read_input_pending)
9014 (encode_terminal_code):
9015 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9016 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9017 (w32_system_caret_y, Qfile_name_history):
9018 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9019 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9020 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9021 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9022 * w32proc.c (Qlocal, report_file_error):
9023 * w32term.c (Vwindow_system, updating_frame):
9024 * w32uniscribe.c (initialized, uniscribe_font_driver):
9025 Remove unneeded extern declarations.
9026
2aa46d6c
CY
90272011-03-14 Chong Yidong <cyd@stupidchicken.com>
9028
c96bbc66 9029 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9030
cffc6f3b
CY
90312011-03-13 Chong Yidong <cyd@stupidchicken.com>
9032
9033 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9034 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9035 These macros can no longer be used for assignment.
9036
44f230aa
SM
9037 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9038 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9039 (record_buffer_markers, fetch_buffer_markers): New functions for
9040 recording and fetching special buffer markers.
9041 (set_buffer_internal_1, set_buffer_temp): Use them.
9042
9043 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9044
9045 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9046
9047 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9048 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9049
9050 * xdisp.c (hscroll_window_tree):
9051 (reconsider_clip_changes): Use PT instead of BUF_PT.
9052
d251f04b
EZ
90532011-03-13 Eli Zaretskii <eliz@gnu.org>
9054
9055 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9056 $(EMACS_ROOT)/lib/intprops.h.
9057
f0c77cd1
PE
90582011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9059
3eca4629
PE
9060 Fix more problems found by GCC 4.5.2's static checks.
9061
7c86ee98
PE
9062 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9063 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9064 (xg_free_frame_widgets): Make it clear that a local variable is
9065 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9066 (gdk_window_get_screen): Make it clear that this macro is needed
9067 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9068 (int_gtk_range_get_value): New function, which avoids a diagnostic
9069 from gcc -Wbad-function-cast.
9070 (xg_set_toolkit_scroll_bar_thumb): Use it.
9071 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9072 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9073 (get_utf8_string, xg_get_file_with_chooser):
9074 Rename locals to avoid shadowing.
9075 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9076
41729b81
PE
9077 * xgselect.c (xg_select): Remove unused var.
9078
f0c77cd1
PE
9079 * image.c (four_corners_best): Mark locals as initialized.
9080 (gif_load): Initialize transparent_p to zero (Bug#8238).
9081 Mark another local as initialized.
ec6cf4c6 9082 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9083
ce0ad53d 9084 * image.c (clear_image_cache): Now static.
d5d5a617 9085 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9086 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9087 (x_edge_detection): Remove unnecessary cast that
9088 gcc -Wbad-function-cast diagnoses.
2037898d 9089 (gif_load): Fix pointer signedness.
6ae141d6
PE
9090 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9091 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9092
33383987 90932011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9094
d32df629
PE
9095 Improve quality of tests for time stamp overflow.
9096 For example, without this patch (encode-time 0 0 0 1 1
9097 1152921504606846976) returns the obviously-bogus value (-948597
9098 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9099 reports time overflow. See
9100 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9101 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9102 * editfns.c: Include limits.h and intprops.h.
9103 (TIME_T_MIN, TIME_T_MAX): New macros.
9104 (time_overflow): Move earlier, to before first use.
9105 (hi_time, lo_time): New functions, for an accurate test for
9106 out-of-range times.
9107 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9108 (Fget_internal_run_time): Don't assume time_t fits in int.
9109 (make_time): Use list2 instead of Fcons twice.
9110 (Fdecode_time): More accurate test for out-of-range times.
9111 (check_tm_member): New function.
9112 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9113 (lisp_time_argument): Don't rely on undefined left-shift and
9114 right-shift behavior when checking for time stamp overflow.
8be6f318 9115
fe31d94c
PE
9116 * editfns.c (time_overflow): New function, refactoring common code.
9117 (Fformat_time_string, Fdecode_time, Fencode_time):
9118 (Fcurrent_time_string): Use it.
9119
8be6f318
PE
9120 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9121 * dired.c (make_time): Move to ...
9122 * editfns.c (make_time): ... here.
9123 * systime.h: Note the move.
9124
09d9db2c 91252011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9126
126bc0dc
YM
9127 * fringe.c (update_window_fringes): Remove unused variables.
9128
c47cbdfd
YM
9129 * unexmacosx.c (copy_data_segment): Also copy __got section.
9130 (Bug#8223)
9131
7ac80be9
EZ
91322011-03-12 Eli Zaretskii <eliz@gnu.org>
9133
c96bbc66 9134 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9135 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9136 Constify `char *' arguments and their references according to
9137 prototypes in tparam.h.
9138
ecb0f94d 9139 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9140
7ac80be9
EZ
9141 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9142 Adapt all references accordingly.
9143
9144 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9145
ef1fd07e
TT
91462011-03-11 Tom Tromey <tromey@redhat.com>
9147
9148 * buffer.c (syms_of_buffer): Remove obsolete comment.
9149
7ef4b50c
EZ
91502011-03-11 Eli Zaretskii <eliz@gnu.org>
9151
9152 * termhooks.h (encode_terminal_code): Declare prototype.
9153
9154 * msdos.c (encode_terminal_code): Don't declare prototype.
9155
9156 * term.c (encode_terminal_code): Now external again, used by
9157 w32console.c and msdos.c.
9158
44f230aa
SM
9159 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9160 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9161
4b1ec863 91622011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9163
1714f52b 9164 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9165
4b1ec863
PE
9166 * fringe.c (update_window_fringes): Mark locals as initialized
9167 (Bug#8227).
9168 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9169
524c7aa6
PE
9170 * alloc.c (mark_fringe_data): Move decl from here ...
9171 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9172 to check its interface.
9173 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9174
a5c0af81 9175 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9176 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9177 (fontset_font): Mark local as initialized.
a9a06e0b 9178 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9179
b4716021
PE
9180 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9181
811e9bac 9182 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9183 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9184 (x_own_selection, Fx_disown_selection_internal): Rename locals
9185 to avoid shadowing.
9186 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9187
7e3ab302
PE
9188 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9189 so that the caller can use some name other than gcpro1.
9190 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9191 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9192 (Fx_backspace_delete_keys_p):
9193 Use them to avoid shadowing, and rename vars to avoid shadowing.
9194 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9195 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9196 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9197 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9198 Remove unused locals.
7e3ab302
PE
9199 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9200 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9201 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9202 macros.
f78faa98 9203
e2b13473
PE
9204 * xterm.h (x_mouse_leave): New decl.
9205
77f23912
PE
9206 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9207 Remove unused functions.
cdf4ba58
PE
9208 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9209 (x_calc_absolute_position): Now static.
7411c686 9210 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9211 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9212 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9213 unless they are used.
38d0b34a
PE
9214 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9215 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9216 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9217 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9218 (x_error_catcher, x_connection_closed, x_error_handler):
9219 (x_error_quitter, xembed_send_message, x_iconify_frame):
9220 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9221 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9222 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9223
44f230aa
SM
9224 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9225 Rename or move locals to avoid shadowing.
6b463e58 9226 (tty_defined_color, merge_face_heights): Now static.
5967d051 9227 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9228 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9229 does not deduce is never used uninitialized.
73719eba
PE
9230 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9231 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9232
426994c3 9233 * terminal.c (store_terminal_param): Now static.
5489860b 9234
032f1620 9235 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9236 (set_frame_menubar): Remove unused local.
d4323972 9237 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9238 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9239 since they might point to immutable storage.
281585b0
PE
9240 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9241 since it's unused otherwise.
032f1620 9242
367c19e5 9243 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9244 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9245 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9246 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9247 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9248 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9249 does not deduce are never used uninitialized.
70739cbe 9250
07b48fa9
PE
9251 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9252
8868a238 9253 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9254 * window.c (window_loop, size_window):
9255 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9256
7e5cf297 9257 * window.c (display_buffer): Now static.
d6550a9f
PE
9258 (size_window): Mark variables that gcc -Wuninitialized
9259 does not deduce are never used uninitialized.
a586633d
PE
9260 * window.h (check_all_windows): New decl, to forestall
9261 gcc -Wmissing-prototypes diagnostic.
5b555da1 9262 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9263
f6095868
PE
9264 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9265 shadowing.
9266 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9267 Include <limits.h>.
9268 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9269 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9270 (load_charset_map): Mark variables that gcc -Wuninitialized
9271 does not deduce are never used uninitialized.
53df7c11 9272 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9273
f38b440c
PE
9274 * coding.c (coding_set_source, coding_set_destination):
9275 Use "else { /* comment */ }" rather than "else /* comment */;"
9276 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9277 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9278 a block, when the outer 'i' will do.
9279 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9280 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9281 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9282 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9283 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9284 Rename locals to avoid shadowing.
9285 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9286 * coding.c (emacs_mule_char, encode_invocation_designation):
9287 Now static, since they're not used elsewhere.
413bb2db 9288 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9289 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9290 (decode_coding_emacs_mule): Mark variables that gcc
9291 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9292 (detect_coding_iso_2022): Initialize a local variable that might
9293 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9294 this initialization is needed. (Bug#8211)
5f58e762
PE
9295 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9296 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9297 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9298 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9299 Remove unused macros.
f38b440c 9300
232b38b9 9301 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9302 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9303 * character.c (string_count_byte8): Likewise.
232b38b9 9304
fb90da1b
PE
9305 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9306 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9307
fb93dbc2
PE
9308 * chartab.c (copy_sub_char_table): Now static, since it's not used
9309 elsewhere.
5c156ace
PE
9310 (sub_char_table_ref_and_range, char_table_ref_and_range):
9311 Rename locals to avoid shadowing.
bbcd0949 9312 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9313
7d3b3862 9314 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9315 (BIDI_BOB): Remove unused macro.
7d3b3862 9316
6be7d3da
PE
9317 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9318 deduce are never used uninitialized.
c2ed9c8b 9319 * term.c (encode_terminal_code): Likewise.
6be7d3da 9320
75f8807f 9321 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9322
50938595
PE
9323 * tparam.h: New file.
9324 * term.c, tparam.h: Include it.
9325 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9326 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9327 Move these decls to tparam.h, and make them agree with what
9328 is actually in tparam.c. The previous trick of using incompatible
9329 decls in different modules does not conform to the C standard.
9330 All callers of tparam changed to use tparam's actual API.
9331 * tparam.c (tparam1, tparam, tgoto):
9332 Use const pointers where appropriate.
9333
fbceeba2
PE
9334 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9335 * cm.h (struct cm): Likewise.
9336 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9337 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9338 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9339 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9340 (turn_on_face, init_tty): Likewise.
9341 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9342
7f3f1250
PE
9343 * term.c (term_mouse_position): Rename local to avoid shadowing.
9344
e6ca6543
PE
9345 * alloc.c (mark_ttys): Move decl from here ...
9346 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9347
c40f8d15
AS
93482011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9349
9350 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9351
cfe0661d
JB
93522011-03-09 Juanma Barranquero <lekktu@gmail.com>
9353
9354 * search.c (compile_pattern_1): Remove argument regp, unused since
9355 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9356 (compile_pattern): Don't pass it.
9357
0afb4571
J
93582011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9359
9360 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9361 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9362 for ! HAVE_GTK3.
9363 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9364
9365 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9366
9367 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9368 gdk_window_get_screen, gdk_window_get_geometry,
9369 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9370 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9371 (xg_get_pixbuf_from_pixmap): New function.
9372 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9373 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9374 Call xg_get_pixbuf_from_pixmap instead of
9375 gdk_pixbuf_get_from_drawable.
9376 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9377 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9378 (xg_check_special_colors): Use GtkStyleContext and its functions
9379 for HAVE_GTK3.
9380 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9381 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9382 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9383 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9384 Call gtk_widget_get_preferred_size.
0afb4571
J
9385 (xg_frame_resized): gdk_window_get_geometry only takes 5
9386 parameters.
44f230aa
SM
9387 (xg_win_to_widget, xg_event_is_for_menubar):
9388 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9389 (xg_set_widget_bg): New function.
9390 (delete_cb): New function.
895009e1 9391 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9392 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9393 (xg_set_background_color): Call xg_set_widget_bg.
9394 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9395 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9396 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9397 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9398 if ! HAVE_GTK3.
9399 (update_frame_tool_bar): Call gtk_widget_hide.
9400 (xg_initialize): Use GDK_KEY_g.
9401
9402 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9403 if ! HAVE_GTK3
9404 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9405
9406 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9407 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9408 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9409
1c2cc4ef
JB
94102011-03-08 Juanma Barranquero <lekktu@gmail.com>
9411
9412 * w32xfns.c (select_palette): Check success of RealizePalette against
9413 GDI_ERROR, not zero.
9414
33383987 9415See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9416
9417;; Local Variables:
9418;; coding: utf-8
aac0c6e3
MR
9419;; End:
9420
acaf905b 9421 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9422
9423 This file is part of GNU Emacs.
9424
9425 GNU Emacs is free software: you can redistribute it and/or modify
9426 it under the terms of the GNU General Public License as published by
9427 the Free Software Foundation, either version 3 of the License, or
9428 (at your option) any later version.
9429
9430 GNU Emacs is distributed in the hope that it will be useful,
9431 but WITHOUT ANY WARRANTY; without even the implied warranty of
9432 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9433 GNU General Public License for more details.
9434
9435 You should have received a copy of the GNU General Public License
9436 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.