* buffer.c (struct sortstr.priority): Now EMACS_INT, not int.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
fadf4e30
PE
12011-06-17 Paul Eggert <eggert@cs.ucla.edu>
2
8961a454
PE
3 * buffer.c (struct sortvec.priority, struct sortstr.priority):
4 Now EMACS_INT, not int.
fadf4e30 5
28177add
PE
62011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7
dd3482fe
PE
8 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
11
393d71f3 12 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
13 * fileio.c (Finsert_file_contents):
14 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
15 Remove the old (too-loose) buffer overflow checks.
16 They weren't needed, since make_gap checks for buffer overflow.
17 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
18 The old code merely checked for Emacs fixnum overflow, and relied
19 on undefined (wraparound) behavior. The new code avoids undefined
20 behavior, and also checks for ptrdiff_t and/or size_t overflow.
21
2e6813b0 22 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
23 Tune. Don't use wider integers than needed. Don't use alloca.
24 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 25
599a9e4f
PE
26 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
27
99561444
PE
28 * insdel.c, lisp.h (buffer_overflow): New function.
29 (insert_from_buffer_1, replace_range, replace_range_2):
30 * insdel.c (make_gap_larger):
31 * editfns.c (Finsert_char):
32 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
33
28177add
PE
34 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
35
e69dafad
PE
362011-06-15 Paul Eggert <eggert@cs.ucla.edu>
37
a7af7fde 38 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 39
b1c46f02
PE
40 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
41 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
42
e69dafad
PE
43 * fileio.c: Don't assume EMACS_INT fits in off_t.
44 (emacs_lseek): New static function.
45 (Finsert_file_contents, Fwrite_region): Use it.
46 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
47
566684ea
PE
48 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
49
e6966cd6
PE
50 * fns.c: Don't overflow int when computing a list length.
51 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
52 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
53 truncation on 64-bit hosts. Check for QUIT every
54 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
55 faster and is responsive enough.
56 (Flength): Report an error instead of overflowing an integer.
57 (Fsafe_length): Return a float if the value is not representable
58 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 59 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 60 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 61
dd0b0efb
PE
62 * alloc.c: Check that resized vectors' lengths fit in fixnums.
63 (header_size, word_size): New constants.
64 (allocate_vectorlike): Don't check size overflow here.
65 (allocate_vector): Check it here instead, since this is the only
66 caller of allocate_vectorlike that could cause overflow.
67 Check that the new vector's length is representable as a fixnum.
68
86fe5cfe
PE
69 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
70 The previous code was bogus. For example, next_almost_prime (32)
71 returned 39, which is undesirable as it is a multiple of 3; and
72 next_almost_prime (24) returned 25, which is a multiple of 5 so
73 why was the code bothering to check for multiples of 7?
74
80e88859
PE
75 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
76
4a2f0ad6
PE
77 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
78
f66c7cf8
PE
79 Variadic C functions now count arguments with ptrdiff_t.
80 This partly undoes my 2011-03-30 change, which replaced int with size_t.
81 Back then I didn't know that the Emacs coding style prefers signed int.
82 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
83 were being counted with int, which may truncate counts on 64-bit
84 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
85 * lisp.h (struct Lisp_Subr.function.aMANY)
86 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
87 Arg counts are now ptrdiff_t, not size_t.
88 All variadic functions and their callers changed accordingly.
89 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
90 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
91 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
92 * callint.c (Fcall_interactively): Check arg count for overflow,
93 to avoid potential buffer overrun. Use signed char, not 'int',
94 for 'varies' array, so that we needn't bother to check its size
95 calculation for overflow.
96 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
97 * eval.c (apply_lambda):
98 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
99 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
100 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
101
a1759b76
PE
102 * callint.c (Fcall_interactively): Don't use index var as event count.
103
d96be9fc
PE
104 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
105 * mem-limits.h (SIZE): Remove; no longer used.
106
a690a978 107 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 108
578c21e6
PE
109 Remove unnecessary casts.
110 * xterm.c (x_term_init):
111 * xfns.c (x_set_border_pixel):
112 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
113 These aren't needed now that we assume ANSI C.
114
96f53c6c
PE
115 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
116 It's more likely to cause problems (due to unsigned overflow)
117 than to cure them.
118
83c77d31
PE
119 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
120
ee2079f1
PE
121 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
122
6da65536
PE
123 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
124
7147c4a4
PE
125 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
126
193e32d9
PE
127 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
128
e5533da6
PE
129 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
130
9910e595
PE
131 GLYPH_CODE_FACE returns EMACS_INT, not int.
132 * dispextern.h (merge_faces):
133 * xfaces.c (merge_faces):
01103c44
PE
134 * xdisp.c (get_next_display_element, next_element_from_display_vector):
135 Don't assume EMACS_INT fits in int.
9910e595 136
2638320e
PE
137 * character.h (CHAR_VALID_P): Remove unused parameter.
138 * fontset.c, lisp.h, xdisp.c: All uses changed.
139
045eb8d9
PE
140 * editfns.c (Ftranslate_region_internal): Omit redundant test.
141
c1f134b5
PE
142 * fns.c (concat): Minor tuning based on overflow analysis.
143 This doesn't fix any bugs. Use int to hold character, instead
144 of constantly refetching from Emacs object. Use XFASTINT, not
145 XINT, for value known to be a character. Don't bother comparing
146 a single byte to 0400, as it's always less.
147
395fcb93 148 * floatfns.c (Fexpt):
327eeec8
PE
149 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
150
abbd3d23
PE
151 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
152 for characters.
153
684a03ef
PE
154 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
155
0fed43f3
PE
156 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
157 Without this fix, on a 64-bit host (aset S 0 4294967386) would
158 incorrectly succeed when S was a string, because 4294967386 was
159 truncated before it was used.
160
8fd02eb7
PE
161 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
162 Otherwise, an out-of-range integer could cause undefined behavior
163 on a 64-bit host.
164
f8c86b69
PE
165 * composite.c: Use int, not EMACS_INT, for characters.
166 (fill_gstring_body, composition_compute_stop_pos): Use int, not
167 EMACS_INT, for values that are known to be in character range.
168 This doesn't fix any bugs but is the usual style inside Emacs and
169 may generate better code on 32-bit machines.
170
34206dd2
PE
171 Make sure a 64-bit char is never passed to ENCODE_CHAR.
172 This is for reasons similar to the recent CHAR_STRING fix.
173 * charset.c (Fencode_char): Check that character arg is actually
174 a character. Pass an int to ENCODE_CHAR.
175 * charset.h (ENCODE_CHAR): Verify that the character argument is no
176 wider than 'int', as a compile-time check to prevent future regressions
177 in this area.
178
c5958d4c 179 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
180
181 Make sure a 64-bit char is never passed to CHAR_STRING.
182 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
183 by silently ignoring the top 32 bits, allowing some values
184 that were far too large to be valid characters.
185 * character.h: Include <verify.h>.
186 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
187 arguments are no wider than unsigned, as a compile-time check
188 to prevent future regressions in this area.
189 * data.c (Faset):
01103c44 190 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
191 (Fsubst_char_in_region):
192 * fns.c (concat):
193 * xdisp.c (decode_mode_spec_coding):
194 Adjust to CHAR_STRING's new requirement.
195 * editfns.c (Finsert_char, Fsubst_char_in_region):
196 * fns.c (concat): Check that character args are actually
197 characters. Without this test, these functions did the wrong
198 thing with wildly out-of-range values on 64-bit hosts.
199
d37ca623
PE
200 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
201 These casts should not be needed on 32-bit hosts, either.
202 * keyboard.c (read_char):
203 * lread.c (Fload): Remove casts to unsigned.
204
ea204efb
PE
205 * lisp.h (UNSIGNED_CMP): New macro.
206 This fixes comparison bugs on 64-bit hosts.
207 (ASCII_CHAR_P): Use it.
208 * casefiddle.c (casify_object):
01103c44 209 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
210 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
211 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
212 * dispextern.h (FACE_FROM_ID):
213 * keyboard.c (read_char): Use UNSIGNED_CMP.
214
41cb286c
PE
215 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
216 not to EMACS_INT, to avoid GCC warning.
217
4a1b9832
PE
218 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
219
55daad71
PE
220 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
221 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
222 isn't needed on 32-bit machines.
8f95c75c 223
01103c44
PE
224 * buffer.c (Fgenerate_new_buffer_name):
225 Use EMACS_INT for count, not int.
0ceccced 226 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
227
228 * data.c (Qcompiled_function): Now static.
229
c6f072e7
PE
230 * window.c (window_body_lines): Now static.
231
20ce5912
PE
232 * image.c (gif_load): Rename local to avoid shadowing.
233
9c4c5f81
PE
234 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
235 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
236 * alloc.c (make_save_value): Integer argument is now of type
237 ptrdiff_t, not int.
238 (mark_object): Use ptrdiff_t, not int.
239 * lisp.h (pD): New macro.
240 * print.c (print_object): Use it.
241
c0c5c8ae
PE
242 * alloc.c: Use EMACS_INT, not int, to count objects.
243 (total_conses, total_markers, total_symbols, total_vector_size)
244 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
245 (total_free_floats, total_floats, total_free_intervals)
246 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
247 Now EMACS_INT, not int. All uses changed.
248 (Fgarbage_collect): Compute overall total using a double, so that
249 integer overflow is less likely to be a problem. Check for overflow
250 when converting back to an integer.
5a25e253
PE
251 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
252 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
253 These were 'int' variables that could overflow on 64-bit hosts;
254 they were never used, so remove them instead of repairing them.
211a0b2a 255 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
256 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
257 Previously, this ceilinged at INT_MAX, but that doesn't work on
258 64-bit machines.
e46bb31a 259 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 260
c78baabf 261 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 262 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
263 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
264 when a (possibly-narrower) signed value would do just as well.
265 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 266
c9d624c6
PE
267 * alloc.c: Catch some string size overflows that we were missing.
268 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
269 for convenience in STRING_BYTES_MAX.
270 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
271 The definition here is exact; the one in lisp.h was approximate.
272 (allocate_string_data): Check for string overflow. This catches
273 some instances we weren't catching before. Also, it catches
274 size_t overflow on (unusual) hosts where SIZE_MAX <= min
275 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
276 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 277
c9d624c6
PE
278 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
279 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
280 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
281
353032ce
PE
282 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
283
2bccce07
PE
284 * alloc.c (Fmake_string): Check for out-of-range init.
285
0ac30604
SM
2862011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
287
288 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
289
c195f2de
JD
2902011-06-14 Jan Djärv <jan.h.d@swipnet.se>
291
292 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
293 xg_get_default_scrollbar_width.
294
295 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
296 (int_gtk_range_get_value): Move to the scroll bar part of the file.
297 (style_changed_cb): Call update_theme_scrollbar_width and call
298 x_set_scroll_bar_default_width and xg_frame_set_char_size for
299 all frames (Bug#8505).
300 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
301 Call gtk_window_set_resizable if HAVE_GTK3.
302 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
303 and height if HAVE_GTK3 (Bug#8505).
304 (scroll_bar_width_for_theme): New variable.
305 (update_theme_scrollbar_width): New function.
306 (xg_get_default_scrollbar_width): Move code to
307 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
308 (xg_initialize): Call update_theme_scrollbar_width.
309
310 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
311
312 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
313
e10ac9f1
MR
3142011-06-12 Martin Rudalics <rudalics@gmx.at>
315
316 * frame.c (make_frame): Call other_buffer_safely instead of
317 other_buffer.
318
319 * window.c (temp_output_buffer_show): Call display_buffer with
320 second argument Vtemp_buffer_show_specifiers and reset latter
321 immediately after the call.
322 (Vtemp_buffer_show_specifiers): New variable.
323 (auto_window_vscroll_p, next_screen_context_lines)
324 (Vscroll_preserve_screen_position): Remove leading asterisks from
325 doc-strings.
326
2d3c217e 3272011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 328
7b7f97e8 329 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
330 * buffer.c (Qclone_number): Remove for now, as it's unused.
331 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
332 (record_buffer): Remove unused local.
333 * frame.c (other_visible_frames, frame_buffer_list): Now static.
334 (set_frame_buffer_list): Remove; unused.
335 * frame.h (other_visible_frames): Remove decl.
336 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
337 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
338 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
339 if HAVE_GPM.
340 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
341 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
342 Define only if HAVE_GPM.
343 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
344 (update_hints_inhibit): Remove; never set. All uses removed.
345 * widgetprv.h (emacsFrameClassRec): Remove decl.
346 * window.c (delete_deletable_window): Now returns void, since it
347 wasn't returning anything.
348 (compare_window_configurations): Remove unused locals.
349 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
350 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
351 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
352 the same widths as pointers. This follows up on the 2011-05-06 patch.
353 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
354 * xterm.h: Likewise.
355 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
356
1384b89e
JB
3572011-06-12 Juanma Barranquero <lekktu@gmail.com>
358
359 * makefile.w32-in: Update dependencies.
360 (LISP_H): Add lib/intprops.h.
361
1100a63c
CY
3622011-06-11 Chong Yidong <cyd@stupidchicken.com>
363
364 * image.c (gif_load): Add animation frame delay to the metadata.
365 (syms_of_image): Use DEFSYM. New symbol `delay'.
366
6198ccd0
MR
3672011-06-11 Martin Rudalics <rudalics@gmx.at>
368
369 * window.c (delete_deletable_window): Re-add.
370 (Fset_window_configuration): Rewrite to handle dead buffers and
371 consequently deletable windows.
372 (window_tree, Fwindow_tree): Remove. Supply functionality in
373 window.el.
374 (compare_window_configurations): Simplify code.
375
b6e3633c
AS
3762011-06-11 Andreas Schwab <schwab@linux-m68k.org>
377
1ab0dee5
AS
378 * image.c (imagemagick_load_image): Fix type mismatch.
379 (Fimagemagick_types): Likewise.
380
b6e3633c
AS
381 * window.h (replace_buffer_in_windows): Declare.
382
9397e56f
MR
3832011-06-11 Martin Rudalics <rudalics@gmx.at>
384
385 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
386 Qclone_number. Remove external declaration of Qdelete_window.
387 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
388 code.
389 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
390 Qbuffer_list_update_hook if allowed.
391 (Fother_buffer): Rewrite doc-string. Major rewrite for new
392 buffer list implementation.
393 (other_buffer_safely): New function.
394 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
395 calls to replace_buffer_in_windows and
396 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
397 if allowed.
398 (record_buffer): Inhibit quitting and rewrite using quittable
399 functions. Run Qbuffer_list_update_hook if allowed.
400 (Frecord_buffer, Funrecord_buffer): New functions.
401 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
402 switch-to-buffer to window.el.
403 (bury-buffer): Move to window.el.
404 (Vbuffer_list_update_hook): New variable.
405
406 * lisp.h (other_buffer_safely): Add prototype in buffer.c
407 section.
408
409 * window.h (resize_frame_windows): Move up in code.
410 (Fwindow_frame): Remove EXFUN.
411 (replace_buffer_in_all_windows): Remove prototype.
412 (replace_buffer_in_windows_safely): Add prototype.
413
414 * window.c: Declare Qdelete_window static again. Move down
415 declaration of select_count.
416 (Fnext_window, Fprevious_window): Rewrite doc-strings.
417 (Fother_window): Move to window.el.
418 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
419 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
420 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
421 window.el.
422 (replace_buffer_in_windows): Implement by calling
423 Qreplace_buffer_in_windows.
424 (replace_buffer_in_all_windows): Remove with some functionality
425 moved into replace_buffer_in_windows_safely.
426 (replace_buffer_in_windows_safely): New function.
427 (select_window_norecord, select_frame_norecord): Move in front
428 of run_window_configuration_change_hook. Remove now obsolete
429 declarations.
430 (Fset_window_buffer): Rewrite doc-string. Call
431 Qrecord_window_buffer.
432 (keys_of_window): Move binding for other-window to window.el.
433
b50691aa
CY
4342011-06-11 Chong Yidong <cyd@stupidchicken.com>
435
436 * dispextern.h (struct image): Replace data member, whose int_val
437 and ptr_val fields were not used by anything, with a single
438 lisp_val object.
439
440 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
441 (gif_clear_image, gif_load, imagemagick_load_image)
442 (gs_clear_image, gs_load): Callers changed.
443
3f754b86
PE
4442011-06-10 Paul Eggert <eggert@cs.ucla.edu>
445
cca69397
PE
446 * buffer.h: Include <time.h>, for time_t.
447 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
448
109e28d0
PE
449 Fix minor problems found by static checking.
450
60737f02
PE
451 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
452
4b66faf3
PE
453 Make identifiers static if they are not used in other modules.
454 * data.c (Qcompiled_function, Qframe, Qvector):
455 * image.c (QimageMagick, Qsvg):
456 * minibuf.c (Qmetadata):
457 * window.c (resize_window_check, resize_root_window): Now static.
458 * window.h (resize_window_check, resize_root_window): Remove decls.
459
109e28d0
PE
460 * window.c (window_deletion_count, delete_deletable_window):
461 Remove; unused.
46a4ce9e
PE
462 (window_body_lines): Now static.
463 (Fdelete_other_windows_internal): Mark vars as initialized.
464 Make sure 'resize_failed' is initialized.
465 (run_window_configuration_change_hook): Rename local to avoid shadowing.
466 (resize_window_apply): Remove unused local.
467 * window.h (delete_deletable_window): Remove decl.
468
109e28d0 469 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
470 (imagemagick_load_image): Fix pointer signedness problem by changing
471 last arg from unsigned char * to char *. All uses changed.
472 Also, fix a local for similar reasons.
473 Remove unused locals. Remove locals to avoid shadowing.
474 (fn_rsvg_handle_free): Remove; unused.
475 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 476 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 477
3f754b86
PE
478 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
479
2547adb1
CY
4802011-06-10 Chong Yidong <cyd@stupidchicken.com>
481
482 * image.c (gif_load): Fix omitted cast error introduced by
483 2011-06-06 change.
484
2c8e37d4
MR
4852011-06-10 Martin Rudalics <rudalics@gmx.at>
486
487 * window.h (resize_proportionally, orig_total_lines)
488 (orig_top_line): Remove from window structure.
489 (set_window_height, set_window_width, change_window_heights)
490 (Fdelete_window): Remove prototypes.
491 (resize_frame_windows): Remove duplicate declaration.
492
440a42e3
EZ
4932011-06-10 Eli Zaretskii <eliz@gnu.org>
494
495 * window.h (resize_frame_windows, resize_window_check)
496 (delete_deletable_window, resize_root_window)
497 (resize_frame_windows): Declare prototypes.
498
499 * window.c (resize_window_apply): Make definition be "static" to
500 match the prototype.
501
562dd5e9
MR
5022011-06-10 Martin Rudalics <rudalics@gmx.at>
503
504 * window.c: Remove declarations of Qwindow_size_fixed,
505 window_min_size_1, window_min_size_2, window_min_size,
506 size_window, window_fixed_size_p, enlarge_window, delete_window.
507 Remove static from declaration of Qdelete_window, it's
508 temporarily needed by Fbury_buffer.
509 (replace_window): Don't assign orig_top_line and
510 orig_total_lines.
511 (Fdelete_window, delete_window): Remove. Window deletion is
512 handled by window.el.
513 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
514 Fdelete_window calls with calls to Qdelete_window.
515 (Fdelete_other_windows): Remove. Deleting other windows is
516 handled by window.el.
517 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
518 handled in window.el.
519 (window_min_size_2, window_min_size_1, window_min_size): Remove.
520 Window minimum sizes are handled in window.el.
521 (shrink_windows, size_window, set_window_height)
522 (set_window_width, change_window_heights, window_height)
523 (window_width, CURBEG, CURSIZE, enlarge_window)
524 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
525 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
526 handled in window.el.
527 (make_dummy_parent): Rename to make_parent_window and give it a
528 second argument horflag.
529 (make_window): Don't set resize_proportionally any more.
530 (Fsplit_window): Remove. Windows are split in window.el.
531 (save_restore_action, save_restore_orig_size)
532 (shrink_window_lowest_first, save_restore_orig_size): Remove.
533 Resize mini windows in window.el.
534 (grow_mini_window, shrink_mini_window): Implement by calling
535 Qresize_root_window_vertically, resize_window_check and
536 resize_window_apply.
537 (saved_window, Fset_window_configuration, save_window_save): Do
538 not handle orig_top_line, orig_total_lines, and
539 resize_proportionally.
540 (window_min_height, window_min_width): Move to window.el.
541 (keys_of_window): Move bindings for delete-other-windows,
542 split-window, delete-window and enlarge-window to window.el.
543
544 * buffer.c: Temporarily extern Qdelete_window.
545 (Fbury_buffer): Temporarily call Qdelete_window instead of
546 Fdelete_window (Fbury_buffer will move to window.el soon).
547
548 * frame.c (set_menu_bar_lines_1): Remove code handling
549 orig_top_line and orig_total_lines.
550
551 * dispnew.c (adjust_frame_glyphs_initially): Don't use
552 set_window_height but set heights directly.
553 (change_frame_size_1): Use resize_frame_windows.
554
555 * xdisp.c (init_xdisp): Don't use set_window_height but set
556 heights directly.
557
558 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
559 resize_frame_windows instead of change_window_heights and run
560 run_window_configuration_change_hook.
561
562 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
563 instead of change_window_heights and run
564 run_window_configuration_change_hook.
565
1a13852e
MR
5662011-06-09 Martin Rudalics <rudalics@gmx.at>
567
568 * window.c (replace_window): Rename second argument REPLACEMENT to
569 NEW. New third argument SETFLAG. Rewrite.
570 (delete_window, make_dummy_parent): Call replace_window with
571 third argument 1.
572 (window_list_1): Move down in code.
573 (run_window_configuration_change_hook): Move set_buffer part
574 before select_frame_norecord part in order to unwind correctly.
575 Rename count1 to count.
576 (recombine_windows, delete_deletable_window, resize_root_window)
577 (Fdelete_other_windows_internal)
578 (Frun_window_configuration_change_hook, make_parent_window)
579 (resize_window_check, resize_window_apply, Fresize_window_apply)
580 (resize_frame_windows, Fsplit_window_internal)
581 (Fdelete_window_internal, Fresize_mini_window_internal): New
582 functions.
583 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
584
f3d1777e
MR
5852011-06-08 Martin Rudalics <rudalics@gmx.at>
586
496e208e
MR
587 * window.h (window): Add some new members to window structure -
588 normal_lines, normal_cols, new_total, new_normal, clone_number,
589 splits, nest, prev_buffers, next_buffers.
590 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 591 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 592
f3d1777e
MR
593 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
594 Remove.
496e208e
MR
595 (make_dummy_parent): Set new members of windows structure.
596 (make_window): Move down in code. Handle new members of window
597 structure.
598 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
599 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
600 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
601 (Fset_window_prev_buffers, Fwindow_next_buffers)
602 (Fset_window_next_buffers, Fset_window_clone_number): New
603 functions.
604 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
605 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
606 Doc-string fixes.
607 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
608 Argument WINDOW can be now internal window too.
609 (Fwindow_use_time): Move up in code.
610 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
611 Rewrite doc-string.
612 (Fset_window_configuration, saved_window)
613 (Fcurrent_window_configuration, save_window_save): Handle new
614 members of window structure.
b9e809c2
MR
615 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
616 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
617 (syms_of_window): New Lisp objects Qrecord_window_buffer,
618 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
619 Qget_mru_window, Qresize_root_window,
620 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
621 Qauto_buffer_name; staticpro them.
f3d1777e 622
abde8f8c
MR
6232011-06-07 Martin Rudalics <rudalics@gmx.at>
624
625 * window.c (Fwindow_total_size, Fwindow_left_column)
626 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
627 (Fwindow_list_1): New functions.
628 (window_box_text_cols): Replace with window_body_cols.
629 (Fwindow_width, Fscroll_left, Fscroll_right): Use
630 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
631 (delete_window, Fset_window_configuration): Call
632 delete_all_subwindows with window as argument.
633 (delete_all_subwindows): Take a window as argument and not a
634 structure. Rewrite.
190b47e6
MR
635 (window_loop): Remove handling of GET_LRU_WINDOW and
636 GET_LARGEST_WINDOW.
637 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
638
639 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
640 window_box_text_cols. delete_all_subwindows now takes a
641 Lisp_Object as argument.
abde8f8c
MR
642
643 * indent.c (compute_motion, Fcompute_motion): Use
644 window_body_cols instead of window_box_text_cols.
645
fa8a67e6
MR
646 * frame.c (delete_frame): Call delete_all_subwindows with root
647 window as argument.
648
a54e3482
DC
6492011-06-07 Daniel Colascione <dan.colascione@gmail.com>
650
651 * fns.c (Fputhash): Document return value.
652
60002bf5
CY
6532011-06-06 Chong Yidong <cyd@stupidchicken.com>
654
655 * image.c (gif_load): Implement gif89a spec "no disposal" method.
656
0c671da6 6572011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 658
b862a52a 659 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 660
be44ca6c
PE
661 Check for overflow when converting integer to cons and back.
662 * charset.c (Fdefine_charset_internal, Fdecode_char):
663 Use cons_to_unsigned to catch overflow.
664 (Fencode_char): Use INTEGER_TO_CONS.
665 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
666 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
667 * data.c (long_to_cons, cons_to_long): Remove.
668 (cons_to_unsigned, cons_to_signed): New functions.
669 These signal an error for invalid or out-of-range values.
670 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
671 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
672 * font.c (Ffont_variation_glyphs):
673 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
674 * lisp.h: Include <intprops.h>.
675 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
676 (cons_to_signed, cons_to_unsigned): New decls.
677 (long_to_cons, cons_to_long): Remove decls.
678 * undo.c (record_first_change): Use INTEGER_TO_CONS.
679 (Fprimitive_undo): Use CONS_TO_INTEGER.
680 * xfns.c (Fx_window_property): Likewise.
681 * xselect.c: Include <limits.h>.
682 (x_own_selection, selection_data_to_lisp_data):
683 Use INTEGER_TO_CONS.
684 (x_handle_selection_request, x_handle_selection_clear)
685 (x_get_foreign_selection, Fx_disown_selection_internal)
686 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
687 (lisp_data_to_selection_data): Use cons_to_unsigned.
688 (x_fill_property_data): Use cons_to_signed.
689 Report values out of range.
690
d1f3d2af
PE
691 Check for buffer and string overflow more precisely.
692 * buffer.h (BUF_BYTES_MAX): New macro.
693 * lisp.h (STRING_BYTES_MAX): New macro.
694 * alloc.c (Fmake_string):
695 * character.c (string_escape_byte8):
696 * coding.c (coding_alloc_by_realloc):
697 * doprnt.c (doprnt):
698 * editfns.c (Fformat):
699 * eval.c (verror):
700 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
701 since they may not be the same number.
702 * editfns.c (Finsert_char):
703 * fileio.c (Finsert_file_contents):
704 Likewise for BUF_BYTES_MAX.
705
dd52fcea
PE
706 * image.c: Use ptrdiff_t, not int, for sizes.
707 (slurp_file): Switch from int to ptrdiff_t.
708 All uses changed.
709 (slurp_file): Check that file size fits in both size_t (for
710 malloc) and ptrdiff_t (for sanity and safety).
711
7f9bbdbb
PE
712 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
713 if b->modtime has its maximal value.
714
dfe18f82
PE
715 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
716
84acfcf0
PE
717 Don't assume time_t can fit into int.
718 * buffer.h (struct buffer.modtime): Now time_t, not int.
719 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
720 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
721
ccd9a01a
PE
722 Minor fixes for signed vs unsigned integers.
723 * character.h (MAYBE_UNIFY_CHAR):
724 * charset.c (maybe_unify_char):
725 * keyboard.c (read_char, reorder_modifiers):
726 XINT -> XFASTINT, since the integer must be nonnegative.
727 * ftfont.c (ftfont_spec_pattern):
728 * keymap.c (access_keymap, silly_event_symbol_error):
729 XUINT -> XFASTINT, since the integer must be nonnegative.
730 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
731 since it makes no difference and we prefer signed.
732 * keyboard.c (record_char): Use XUINT when all the neighbors do.
733 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
734 nonnegative.
735
d6d100dd
SM
7362011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
737
738 * window.h (Fwindow_frame): Declare.
739
2b6148e4
PE
7402011-06-06 Paul Eggert <eggert@cs.ucla.edu>
741
742 * alloc.c: Simplify handling of large-request failures (Bug#8800).
743 (SPARE_MEMORY): Always define.
744 (LARGE_REQUEST): Remove.
745 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
746
f230ecc9
MR
7472011-06-06 Martin Rudalics <rudalics@gmx.at>
748
727e958e
MR
749 * lisp.h: Move EXFUNS for Fframe_root_window,
750 Fframe_first_window and Fset_frame_selected_window to window.h.
751
752 * window.h: Move EXFUNS for Fframe_root_window,
753 Fframe_first_window and Fset_frame_selected_window here from
754 lisp.h.
755
756 * frame.c (Fwindow_frame, Fframe_first_window)
757 (Fframe_root_window, Fframe_selected_window)
758 (Fset_frame_selected_window): Move to window.c.
759 (Factive_minibuffer_window): Move to minibuf.c.
760 (Fother_visible_frames_p): New function.
761
762 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
763
f230ecc9
MR
764 * window.c (decode_window, decode_any_window): Move up in code.
765 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
766 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
767 (Fwindow_buffer): Move up and rewrite doc-string.
768 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
769 (Fwindow_prev): New functions.
727e958e
MR
770 (Fwindow_frame): Move here from frame.c. Accept any window as
771 argument.
772 (Fframe_root_window, Fframe_first_window)
773 (Fframe_selected_window): Move here from frame.c. Accept frame
774 or arbitrary window as argument. Update doc-strings.
775 (Fminibuffer_window): Move up in code.
776 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
777 (Fset_frame_selected_window): Move here from frame.c.
778 Marginal rewrite.
727e958e
MR
779 (Fselected_window, select_window, Fselect_window): Move up in
780 code. Minor doc-string fixes.
f230ecc9 781
4d09bcf6
PE
7822011-06-06 Paul Eggert <eggert@cs.ucla.edu>
783
784 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
785 Do not assume that spare memory exists; that assumption is valid
786 only if SYSTEM_MALLOC.
787 (LARGE_REQUEST): New macro, so that the issue of large requests
788 is separated from the issue of spare memory.
789
810928a2
AS
7902011-06-05 Andreas Schwab <schwab@linux-m68k.org>
791
172418ad
AS
792 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
793 format. (Bug#8806)
794
43f862f7
AS
795 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
796
810928a2
AS
797 * xfns.c (x_set_scroll_bar_default_width): Move declarations
798 before statements.
799
a059fe24
JD
8002011-06-05 Jan Djärv <jan.h.d@swipnet.se>
801
802 * gtkutil.c (xg_get_default_scrollbar_width): New function.
803
804 * gtkutil.h: Declare xg_get_default_scrollbar_width.
805
806 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
807 min width by calling x_set_scroll_bar_default_width (Bug#8505).
808
989bf368
JB
8092011-06-05 Juanma Barranquero <lekktu@gmail.com>
810
811 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
812
4b80f674
CY
8132011-06-04 Chong Yidong <cyd@stupidchicken.com>
814
815 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
816 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
817 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
818 New error handlers.
4b80f674
CY
819 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
820 Obey Vx_select_enable_clipboard_manager. Catch errors in
821 x_clipboard_manager_save (Bug#8779).
822 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 823 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 824
99a33b77 8252011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
826
827 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
828
99a33b77 8292011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
830
831 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
832 in the current matrix if keep_current_p is non-zero.
833
8264569d
EZ
8342011-06-04 Eli Zaretskii <eliz@gnu.org>
835
836 * bidi.c (bidi_level_of_next_char): Fix last change.
837
57f97249
EZ
8382011-06-03 Eli Zaretskii <eliz@gnu.org>
839
fec2107c 840 Support bidi reordering of text covered by display properties.
57f97249 841
fec2107c
EZ
842 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
843 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
844 (bidi_cache_search, bidi_cache_iterator_state)
845 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
846 (bidi_level_of_next_char, bidi_move_to_visually_next):
847 Support character positions inside a run of characters covered by a
fec2107c
EZ
848 display string.
849 (bidi_paragraph_init, bidi_resolve_explicit_1)
850 (bidi_level_of_next_char): Call bidi_fetch_char and
851 bidi_fetch_char_advance instead of FETCH_CHAR and
852 FETCH_CHAR_ADVANCE.
853 (bidi_init_it): Initialize new members.
854 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
855 definitions.
856 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
857 instead of using explicit *_CHAR codes.
d6d100dd
SM
858 (bidi_resolve_explicit, bidi_resolve_weak):
859 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
860 bidirectional text is supported only in multibyte buffers.
861 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
862 it to initialize the frame_window_p member of struct bidi_it.
863 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
864 (bidi_resolve_explicit, bidi_resolve_weak)
865 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
866 bidi_it->nchars is non-positive.
867 (bidi_level_of_next_char): Don't try to lookup the cache for the
868 next/previous character if nothing is cached there yet, or if we
869 were just reseat()'ed to a new position.
c40e2fb2 870
0e14fe90
EZ
871 * xdisp.c (set_cursor_from_row): Set start and stop points
872 according to the row's direction when priming the loop that looks
873 for the glyph on which to display cursor.
874 (single_display_spec_intangible_p): Function deleted.
875 (display_prop_intangible_p): Reimplement to call
876 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
877 Accept 3 additional arguments needed by handle_display_spec.
878 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
879 values: lists, `(when COND...)' forms, etc.
880 (single_display_spec_string_p): Support property values that are
881 lists with the argument STRING its top-level element.
882 (display_prop_string_p): Fix the condition for processing a
883 property that is a list to be consistent with handle_display_spec.
fec2107c 884 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
885 last portion of handle_display_prop.
886 (compute_display_string_pos): Accept additional argument
887 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
888 value of a `display' property is a "replacing spec".
889 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
890 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
891 the display property, but just return a value indicating whether
892 the display property will replace the characters it covers.
893 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
894 frame_window_p members of struct bidi_it.
d6d100dd
SM
895 (compute_display_string_pos, compute_display_string_end):
896 New functions.
fec2107c
EZ
897 (push_it): Accept second argument POSITION, where pop_it should
898 jump to continue iteration.
899 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 900
fec2107c
EZ
901 * keyboard.c (adjust_point_for_property): Adjust the call to
902 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
903
904 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
905 (bidi_init_it): Update prototypes.
906 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
907 (compute_display_string_pos, compute_display_string_end):
908 Declare prototypes.
fec2107c
EZ
909 (struct bidi_it): New members nchars and disp_pos. ch_len is now
910 EMACS_INT.
fc6f18ce 911
40087514 9122011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 913
57f53182
PE
914 Malloc failure behavior now depends on size of allocation.
915 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
916 * lisp.h: Change signatures accordingly.
917 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
918 All callers changed. (Bug#8762)
919
920 * gnutls.c: Use Emacs's memory allocators.
921 Without this change, the gnutls library would invoke malloc etc.
922 directly, which causes problems on non-SYNC_INPUT hosts, and which
923 runs afoul of improving memory_full behavior. (Bug#8761)
924 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
925 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
926 xfree instead of the default malloc, realloc, free.
927 (Fgnutls_boot): No need to check for memory allocation failure,
928 since xmalloc does that for us.
929
ac32cd99 930 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
931 * category.c (hash_get_category_set):
932 * ccl.c (ccl_driver):
933 * charset.c (Fdefine_charset_internal):
934 * charset.h (struct charset.hash_index):
935 * composite.c (get_composition_id, gstring_lookup_cache)
936 (composition_gstring_put_cache):
937 * composite.h (struct composition.hash_index):
938 * dispextern.h (struct image.hash):
939 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
940 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
941 (hashfn_equal, hashfn_user_defined, make_hash_table)
942 (maybe_resize_hash_table, hash_lookup, hash_put)
943 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
944 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
945 (Fsxhash, Fgethash, Fputhash, Fmaphash):
946 * image.c (make_image, search_image_cache, lookup_image)
947 (xpm_put_color_table_h):
948 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 949 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
950 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
951 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
952 * alloc.c (allocate_vectorlike):
953 Check for overflow in vector size calculations.
954 * ccl.c (ccl_driver):
955 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
956 * fns.c, image.c: Remove unnecessary static decls that would otherwise
957 need to be updated by these changes.
40087514
PE
958 * fns.c (make_hash_table, maybe_resize_hash_table):
959 Check for integer overflow with large hash tables.
0de4bb68
PE
960 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
961 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
962 (SXHASH_REDUCE): New macro.
963 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
964 Use it instead of discarding useful hash info with large hash values.
965 (sxhash_float): New function.
966 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
967 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
968 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
969 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
970 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
971 Adjust signatures to match updated version of code.
972 (consing_since_gc): Now EMACS_INT, since a single hash table can
973 use more than INT_MAX bytes.
974
698d32e2
DN
9752011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
976
977 Make it possible to build with GCC-4.6+ -O2 -flto.
978
979 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
980
fd6fa53f
SM
9812011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
982
983 * minibuf.c (get_minibuffer, read_minibuf_unwind):
984 Call minibuffer-inactive-mode.
985
864db017
JB
9862011-05-31 Juanma Barranquero <lekktu@gmail.com>
987
988 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
989 Update dependencies.
990
2ad0baf4
DN
9912011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
992
993 * data.c (init_data): Remove code for UTS, this system is not
994 supported anymore.
995
4fcc2638
DN
9962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
997
998 Don't force ./temacs to start in terminal mode.
999
1000 * frame.c (make_initial_frame): Initialize faces in all cases, not
1001 only when CANNOT_DUMP is defined.
1002 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1003
c56e0fd5
DN
10042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1005
1006 * dispnew.c (add_window_display_history): Use const for the string
1007 pointer. Remove declaration, not needed.
1008
333d54da 10092011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1010
55d4c1b2 1011 Use 'inline', not 'INLINE'.
333d54da 1012 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1013 * alloc.c, fontset.c (INLINE): Remove.
1014 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1015 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1016 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1017 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1018 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1019
738db178
DN
10202011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1021
1022 Make it possible to run ./temacs.
1023
1024 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1025 syms_of_callproc does the same thing. Remove test for
1026 "initialized", do it in the caller.
1027 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1028
620c53a6
SM
10292011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1030
1031 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1032 (read_minibuf): Use get_minibuffer.
1033 (syms_of_minibuf): Use DEFSYM.
1034 (Qmetadata): New var.
1035 * data.c (Qbuffer): Don't make it static.
1036 (syms_of_data): Use DEFSYM.
1037
e003a292
PE
10382011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1039
1040 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1041 (CCL_CODE_MIN): New macro.
1042
ed008a6d
PE
10432011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1044
3687c2ef
PE
1045 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1046
ed008a6d
PE
1047 * eval.c (Qdebug): Now static.
1048 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1049 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1050 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1051
d66c4c7c
CY
10522011-05-29 Chong Yidong <cyd@stupidchicken.com>
1053
1054 * image.c: Various fixes to ImageMagick code comments.
1055 (Fimagemagick_types): Doc fix.
1056
5fbc2025
PE
10572011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1058
0196f88a
PE
1059 Minor fixes prompted by GCC 4.6.0 warnings.
1060
1061 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1062
5fbc2025
PE
1063 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1064 (x_clipboard_manager_save_all): Move extern decl to ...
1065 * xterm.h: ... here, so that it can be checked for consistency.
1066
1dd3c2d9
CY
10672011-05-29 Chong Yidong <cyd@stupidchicken.com>
1068
1069 * xselect.c (x_clipboard_manager_save_frame)
1070 (x_clipboard_manager_save_all): New functions.
1071 (Fx_clipboard_manager_save): Lisp function deleted.
1072
1073 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1074 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1075
1076 * xterm.h: Update prototype.
1077
5ba6571d
WX
10782011-05-28 William Xu <william.xwl@gmail.com>
1079
1080 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1081 exiting (Bug#8239).
1082
3eaff834
JM
10832011-05-28 Jim Meyering <meyering@redhat.com>
1084
e1900994 1085 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1086 * fns.c (to_uchar): Define.
1087 (crypto_hash_function): Use it to convert some newly-signed
1088 variables to unsigned, to avoid sign-extension bugs. For example,
1089 without this change, (md5 "truc") would evaluate to
1090 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1091 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1092 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1093
0f6990a7
PE
10942011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1095
1096 Integer overflow fixes.
c8a9ca5a 1097
08686060
PE
1098 * dbusbind.c: Serial number integer overflow fixes.
1099 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1100 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1101 to hold a serial number that is too large for a fixnum.
1102 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1103 Check for serial numbers out of range. Decode any serial number
59568bf0 1104 that was so large that it became a float. (Bug#8722)
08686060 1105
2d1fc3c7
PE
1106 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1107 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1108 Use XFASTINT rather than XUINT when numbers are nonnegative.
1109 (xd_append_arg, Fdbus_method_return_internal):
1110 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1111 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1112 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1113 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1114 (Bug#8722)
2d1fc3c7 1115
c8a9ca5a
PE
1116 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1117
519e1d69
PE
1118 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1119
30569699
PE
1120 ccl: add integer overflow checks
1121 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1122 (IN_INT_RANGE): New macros.
1123 (ccl_driver): Use them to check for integer overflow when
1124 decoding a CCL program. Many of the new checks are whether XINT (x)
1125 fits in int; it doesn't always, on 64-bit hosts. The new version
1126 doesn't catch all possible integer overflows, but it's an
847044ea 1127 improvement. (Bug#8719)
30569699 1128
c11285dc
PE
1129 * alloc.c (make_event_array): Use XINT, not XUINT.
1130 There's no need for unsigned here.
1131
fdccd48e
PE
1132 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1133 This follows up to the 2011-05-06 change that substituted uintptr_t
1134 for EMACS_INT. This case wasn't caught back then.
1135
37910ab2
PE
1136 Rework Fformat to avoid integer overflow issues.
1137 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1138 now (part of C89). Include <verify.h>.
1139 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1140 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1141 (Fformat): Avoid the prepass trying to compute sizes; it was only
1142 approximate and thus did not catch overflow reliably. Instead, walk
1143 through the format just once, formatting and computing sizes as we go,
1144 checking for integer overflow at every step, and allocating a larger
1145 buffer as needed. Keep track separately whether the format is
1146 multibyte. Keep only the most-recently calculated precision, rather
1147 than them all. Record whether each argument has been converted to
1148 string. Use EMACS_INT, not int, for byte and char and arg counts.
1149 Support field widths and precisions larger than INT_MAX. Avoid
1150 sprintf's undefined behavior with conversion specifications such as %#d
1151 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1152 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1153 formatting out-of-range floating point numbers with int
1154 formats. (Bug#8668)
1155
2e6578fb
PE
1156 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1157
0ae6bdee
PE
1158 * data.c: Avoid integer truncation in expressions involving floats.
1159 * data.c: Include <intprops.h>.
1160 (arith_driver): When there's an integer overflow in an expression
1161 involving floating point, convert the integers to floating point
1162 so that the resulting value does not suffer from catastrophic
1163 integer truncation. For example, on a 64-bit host (* 4
1164 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1165 Do not rely on undefined behavior after integer overflow.
1166
de883a70
PE
1167 merge count_size_as_multibyte, parse_str_to_multibyte
1168 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1169 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1170 Check for integer overflow.
1171 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1172 since it's now a duplicate of the other. This is more of
1173 a character than a buffer op, so better that it's in character.c.
1174 * fns.c, print.c: Adjust to above changes.
1175
2ff916cb
PE
11762011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1177
1178 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1179
f1b54466
PE
11802011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1181
fb1ac845
PE
1182 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1183 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1184 (x_clipboard_manager_save): Now static.
1185 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1186
f1b54466
PE
1187 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1188 (crypto_hash_function): Now static.
1189 Fix pointer signedness problems. Avoid unnecessary initializations.
1190
a9f737ee
CY
11912011-05-27 Chong Yidong <cyd@stupidchicken.com>
1192
1193 * termhooks.h (Vselection_alist): Make it terminal-local.
1194
1195 * terminal.c (create_terminal): Initialize it.
1196
1197 * xselect.c: Support for clipboard managers.
1198 (Vselection_alist): Move to termhooks.h as terminal-local var.
1199 (LOCAL_SELECTION): New macro.
1200 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1201 (symbol_to_x_atom): Remove gratuitous arg.
1202 (x_handle_selection_request, lisp_data_to_selection_data)
1203 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1204 (x_own_selection, x_get_local_selection, x_convert_selection):
1205 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1206 (some_frame_on_display): Delete unused function.
1207 (Fx_own_selection_internal, Fx_get_selection_internal)
1208 (Fx_disown_selection_internal, Fx_selection_owner_p)
1209 (Fx_selection_exists_p): New optional frame arg.
1210 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1211 (x_handle_selection_clear): Don't treat other terminals with the
1212 same keyboard specially. Use the terminal-local Vselection_alist.
1213 (x_clear_frame_selections): Use Frun_hook_with_args.
1214
1215 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1216
1217 * xterm.h: Add support for those atoms.
1218
e067f0c1
CY
12192011-05-26 Chong Yidong <cyd@stupidchicken.com>
1220
1221 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1222 (converted_selections, conversion_fail_tag): New global variables.
1223 (x_selection_request_lisp_error): Free the above.
1224 (x_get_local_selection): Remove unnecessary code.
1225 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1226 of converted selections stored in converted_selections.
1227 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1228 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1229 (x_convert_selection): New function.
1230 (x_handle_selection_event): Simplify.
1231 (x_get_foreign_selection): Don't ignore incoming requests while
1232 waiting for an answer; this will fail when we implement
1233 SAVE_TARGETS, and seems unnecessary anyway.
1234 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1235 (Vx_sent_selection_functions): Doc fix.
1236
0f4aebc0
LL
12372011-05-26 Leo Liu <sdl.web@gmail.com>
1238
1239 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1240
e61124cd
YM
12412011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1242
1243 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1244
1245 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1246 for fringe update if it has periodic bitmap.
1247 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1248 and fringe_bitmap_periodic_p.
1249
1250 * fringe.c (get_fringe_bitmap_data): New function.
1251 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1252 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1253 row. Mark glyph row for fringe update if periodicity changed.
1254
1255 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1256 for fringe update unless it has periodic bitmap.
1257
f16d9837
KH
12582011-05-25 Kenichi Handa <handa@m17n.org>
1259
1260 * xdisp.c (get_next_display_element): Set correct it->face_id for
1261 a static composition.
1262
e1b90ef6
LL
12632011-05-24 Leo Liu <sdl.web@gmail.com>
1264
1265 * deps.mk (fns.o):
1266 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1267
1268 * fns.c (crypto_hash_function, Fsha1): New function.
1269 (Fmd5): Use crypto_hash_function.
1270 (syms_of_fns): Add Ssha1.
1271
7400048f
PE
12722011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1273
1274 * gnutls.c: Remove unused macros.
1275 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1276 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1277 Remove macros that are defined and never used.
1278 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1279
abb71cf4
CY
12802011-05-22 Chong Yidong <cyd@stupidchicken.com>
1281
1282 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1283 (Fx_get_selection_internal): Minor cleanup.
1284 (Fx_own_selection_internal): Rename arguments for consistency with
1285 select.el.
1286
6307db39
PE
12872011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1288
1289 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1290
f3d4e0a4
CY
12912011-05-22 Chong Yidong <cyd@stupidchicken.com>
1292
1293 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1294
4d8ade89
YM
12952011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1296
1297 * dispnew.c (scrolling_window): Don't exclude the case that the
1298 last enabled row in the desired matrix touches the bottom boundary.
1299
32078c8d
GM
13002011-05-21 Glenn Morris <rgm@gnu.org>
1301
1302 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
1303 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1304 and add some more files.
32078c8d 1305
7285dc67
EZ
13062011-05-20 Eli Zaretskii <eliz@gnu.org>
1307
1308 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1309 report_file_error introduced by the change from 2011-05-07.
1310
89d1bd22
PE
13112011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1312
1313 * systime.h (Time): Define only if emacs is defined.
1314 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1315 where the include path doesn't have X11/X.h by default. See
1316 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1317
e23640bb 13182011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
1319
1320 * composite.c (find_automatic_composition): Fix previous change.
1321
b9704ad9
GM
13222011-05-20 Glenn Morris <rgm@gnu.org>
1323
1324 * lisp.mk: New file, split from Makefile.in.
1325 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1326 (shortlisp): Remove.
1327 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1328
4a720484
GM
13292011-05-19 Glenn Morris <rgm@gnu.org>
1330
1331 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1332 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1333 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1334 (lisp): Set the order to that of loadup.el.
1335 (shortlisp): Make it a copy of $lisp.
1336 (SOME_MACHINE_LISP): Remove.
1337 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1338 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1339
a28d4396
KH
13402011-05-18 Kenichi Handa <handa@m17n.org>
1341
1342 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1343 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1344 (find_automatic_composition): Mostly rewrite for efficiency.
1345
a2b1fa8e
JB
13462011-05-18 Juanma Barranquero <lekktu@gmail.com>
1347
1348 * makefile.w32-in: Update dependencies.
1349
8e1f5610
CS
13502011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1351
1352 * menu.c: Include limits.h (fixes the MS-Windows build broken by
fadf4e30 1353 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 1354
7025ee00 13552011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1356
cdfa6eab
PE
1357 Fix some integer overflow issues, such as string length overflow.
1358
06d6db33
PE
1359 * insdel.c (count_size_as_multibyte): Check for string overflow.
1360
2b4560a8
PE
1361 * character.c (lisp_string_width): Check for string overflow.
1362 Use EMACS_INT, not int, for string indexes and lengths; in
1363 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1364 the resulting string length overflows an EMACS_INT; instead,
1365 report a string overflow if no precision given. When checking for
1366 precision exhaustion, use a check that cannot possibly have
1367 integer overflow. (Bug#8675)
1368 * character.h (lisp_string_width): Adjust to new signature.
1369
cb93f9be
PE
1370 * alloc.c (string_overflow): New function.
1371 (Fmake_string): Use it. This doesn't change behavior, but saves
1372 a few bytes and will simplify future changes.
1373 * character.c (string_escape_byte8): Likewise.
1374 * lisp.h (string_overflow): New decl.
1375
1a1f3366
PE
1376 Fixups, following up to the user-interface timestamp change.
1377 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1378 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1379 * msdos.c (mouse_get_pos): Likewise.
1380 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1381 * w32gui.h (Time): Define by including "systime.h" rather than by
1382 declaring it ourselves. (Bug#8664)
1383
d4e3e4d3
PE
1384 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1385 * image.c (clear_image_cache): Likewise.
1386
f6a24d19
PE
1387 * term.c (term_mouse_position): Don't assume time_t wraparound.
1388
08dc5ae6
PE
1389 Be more systematic about user-interface timestamps.
1390 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1391 and sometimes 'EMACS_UINT', to represent these timestamps.
1392 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1393 This makes the code easier to follow, and makes it easier to catch
1394 integer overflow bugs such as Bug#8664.
1395 * frame.c (Fmouse_position, Fmouse_pixel_position):
1396 Use Time, not unsigned long, for user-interface timestamps.
1397 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1398 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1399 * keyboard.h (last_event_timestamp): Likewise.
1400 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1401 * menu.h (xmenu_show): Likewise.
1402 * term.c (term_mouse_position): Likewise.
1403 * termhooks.h (struct input_event.timestamp): Likewise.
1404 (struct terminal.mouse_position_hook): Likewise.
1405 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1406 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1407 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1408 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1409 what it was before.
1410 * menu.h, termhooks.h: Include "systime.h", for Time.
1411
8e55734a
PE
1412 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1413 Don't assume that the difference between two unsigned long values
1414 can fit into an integer. At this point, we know button_down_time
1415 <= event->timestamp, so the difference must be nonnegative, so
1416 there's no need to cast the result if double-click-time is
1417 nonnegative, as it should be; check that it's nonnegative, just in
1418 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1419 apart (about 25 days). (Bug#8664)
8e55734a 1420
841f1b75 1421 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1422 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1423
3e26f69c
PE
1424 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1425 that always fit in int. Use a sentinel instead of a counter, to
1426 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1427 * frame.h (struct frame): Use int for menu_bar_items_used
1428 instead of EMACS_INT, since it always fits in int.
3e26f69c 1429
5cc152c0
PE
1430 * menu.c (grow_menu_items): Check for int overflow.
1431
d89eb65e
PE
1432 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1433
5235bd3e
PE
1434 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1435 Before, the code was not consistent. These values cannot exceed
1436 2**31 - 1 so there's no need to make them unsigned.
1437 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1438 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1439 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1440 as modifiers.
1441 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1442
bc827e23
PE
1443 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1444 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1445 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1446 presumably because the widths might not match.
1447
78eb494e
PE
1448 * window.c (size_window): Avoid needless test at loop start.
1449
04f2d78b
CB
14502011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1451
1452 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1453
d2fc7e3d 14542011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1455
1456 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1457
d2fc7e3d 14582011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1459
1460 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1461 `width' to `bar_area_x' and `bar_area_width', respectively.
1462 (x_scroll_run): Take account of fringe background extension.
1463
04f2d78b
CB
1464 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1465 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1466 `bar_area_width', respectively.
1467 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1468 background extension.
1469
79b70037
GM
14702011-05-10 Jim Meyering <meyering@redhat.com>
1471
1472 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1473
2f142cc5
JB
14742011-05-10 Juanma Barranquero <lekktu@gmail.com>
1475
1476 * image.c (Finit_image_library): Return t for built-in image types,
1477 like pbm and xbm. (Bug#8640)
1478
57679c86
AS
14792011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1480
1481 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1482
888c9e86
EZ
14832011-05-07 Eli Zaretskii <eliz@gnu.org>
1484
b0512a1d
EZ
1485 * w32console.c (Fset_screen_color): Doc fix.
1486 (Fget_screen_color): New function.
1487 (syms_of_ntterm): Defsubr it.
1488
7285dc67
EZ
1489 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1490 unlink the temporary file if Fcall_process didn't create it in the
1491 first place.
1492 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1493 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1494 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1495 cue to call_process_cleanup not to close that handle.
1496
4d3fcc8e
BK
14972011-05-07 Ben Key <bkey76@gmail.com>
1498
1499 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1500 one of two shell specific rules, either bootstrap-temacs-CMD or
1501 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1502 to the previous implementation of the bootstrap-temacs rule.
1503 The bootstrap-temacs-CMD rule is similar to the previous
1504 implementation of the bootstrap-temacs rule except that it
1505 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1506 variable.
1507
1508 These changes, along with some changes to nt/configure.bat,
1509 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1510 earlier fix to add support for --cflags and --ldflags options
1511 that include quotes so that it works whether make uses cmd or
1512 sh as the shell.
1513
b4289b64
MA
15142011-05-06 Michael Albinus <michael.albinus@gmx.de>
1515
1516 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1517 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1518 is a constant.
1519 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1520 a string. Handle both cases.
1521 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1522 (Fdbus_register_method): Use Qinvalid_function.
1523
af4c0e28
JB
15242011-05-06 Juanma Barranquero <lekktu@gmail.com>
1525
1526 * makefile.w32-in: Update dependencies.
1527 (LISP_H): Add inttypes.h and stdin.h.
1528 (PROCESS_H): Add unistd.h.
1529
c51453d9
EZ
15302011-05-06 Eli Zaretskii <eliz@gnu.org>
1531
1532 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1533 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1534
8ff0ac3c 15352011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1536
4c4b566b
PE
1537 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1538
aab2b9b5
PE
1539 * term.c (vfatal): Remove stray call to va_end.
1540 It's not needed and the C Standard doesn't allow it here anyway.
1541
c378da0b
PE
1542 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1543 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1544
288b08c7
PE
1545 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1546 bytes.
1547
e3601888
PE
1548 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1549
db6c0e74
PE
1550 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1551
dd5963ea
PE
1552 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1553
88c9450f
PE
1554 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1555
2f9442b8
PE
1556 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1557
c032b5f8
PE
1558 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1559 * charset.c (Fdefine_charset_internal): Don't initialize
1560 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1561 32-bit int (Bug#8600).
a108c10b
PE
1562
1563 * lread.c (read_integer): Be more consistent with string-to-number.
1564 Use string_to_number to do the actual conversion; this avoids
1565 rounding errors and fixes some other screwups. Without this fix,
1566 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1567 (digit_to_number): Move earlier, for benefit of read_integer.
1568 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1569 not a digit in any supported base. (Bug#8602)
a108c10b 1570
ad5f9eea
PE
1571 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1572
aec1708a
PE
1573 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1574 to match comment at start of function. This also removes a
1575 GCC warning about overflow in a 32+64-bit port.
1576
47be4ab5
PE
1577 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1578
371cac43
PE
1579 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1580 Reported by Stefan Monnier in
1581 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1582 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1583 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1584
d01a7826
PE
1585 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1586 (EMACS_UINTPTR): Likewise, with uintptr_t.
1587
7fd47d5c
PE
1588 * lisp.h: Prefer 64-bit EMACS_INT if available.
1589 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1590 on 32-bit hosts that have 64-bit int, so that they can access
1591 large files.
122b0c86
PE
1592 However, temporarily disable this change unless the temporary
1593 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1594
8727937b
PE
1595 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1596
8ac068ac
PE
1597 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1598 This removes an assumption that EMACS_INT and long are the same
1599 width as pointers. The assumption is true for Emacs porting targets
1600 now, but we want to make other targets possible.
1601 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1602 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1603 In the rest of the code, change types of integers that hold casted
1604 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1605 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1606 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1607 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1608 No need to cast type when ORing.
1609 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1610 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1611 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1612 assume EMACS_INT is the same width as char *.
1613 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1614 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1615 Remove no-longer-needed casts.
1616 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1617 (xg_tool_bar_help_callback, xg_make_tool_item):
1618 Use EMACS_INTPTR to hold an integer
1619 that will be cast to void *; this can avoid a GCC warning
1620 if EMACS_INT is not the same width as void *.
1621 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1622 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1623 (current_message_1, set_message_1):
1624 Use a local to convert to proper width without a cast.
1625 * xmenu.c (dialog_selection_callback): Likewise.
1626
ede49d71
PE
1627 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1628 Also, don't assume VALBITS / RAND_BITS is less than 5,
1629 and don't rely on undefined behavior when shifting a 1 left into
1630 the sign bit.
1631 * lisp.h (get_random): Change signature to match.
1632
2f30ecd0
PE
1633 * lread.c (hash_string): Use size_t, not int, for hash computation.
1634 Normally we prefer signed values; but hashing is special, because
1635 it's better to use unsigned division on hash table sizes so that
1636 the remainder is nonnegative. Also, size_t is the natural width
1637 for hashing into memory. The previous code used 'int', which doesn't
1638 retain enough info to hash well into very large tables.
1639 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1640
2a866e7b
PE
1641 * dbusbind.c: Don't possibly lose pointer info when converting.
1642 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1643 Use XPNTR rather than XHASH, so that the high-order bits of
1644 the pointer aren't lost when converting through void *.
1645
51639eac
PE
1646 * eval.c (Fautoload): Don't double-shift a pointer.
1647
92394119
PE
1648 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1649
dbdb9a7c
JB
16502011-05-06 Juanma Barranquero <lekktu@gmail.com>
1651
1652 * gnutls.c (DEF_GNUTLS_FN):
1653 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1654
db7a0b4f
AS
16552011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1656
1657 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1658 marker. (Bug#8610)
1659
f7ff1b0f 16602011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1661
1662 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1663 New version that can reserve upto 2GB of heap space.
1664
f7ff1b0f 16652011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1666
1667 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1668
639c109b
TZ
16692011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1670
1671 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1672 `gnutls_certificate_set_x509_key_file'.
1673
d2127135
JB
16742011-05-05 Juanma Barranquero <lekktu@gmail.com>
1675
1676 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1677 Update dependencies.
1678
e968f4f3
JB
16792011-05-04 Juanma Barranquero <lekktu@gmail.com>
1680
1681 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1682 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1683 Remove unused parameter `fildes'.
1684 * process.c (read_process_output, send_process): Don't pass it.
1685
84d358f0
JB
16862011-05-04 Juanma Barranquero <lekktu@gmail.com>
1687
1688 Fix previous change: the library cache is defined in w32.c.
1689 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1690 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1691
0898ca10
JB
16922011-05-04 Juanma Barranquero <lekktu@gmail.com>
1693
1694 Implement dynamic loading of GnuTLS on Windows.
1695
1696 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1697 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1698 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1699 Declare.
1700
1701 * gnutls.c (Qgnutls_dll): Define.
1702 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1703 (gnutls_*): Declare function pointers.
1704 (init_gnutls_functions): New function to initialize function pointers.
1705 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1706 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1707 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1708 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1709 (emacs_gnutls_write, emacs_gnutls_read)
1710 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1711 (Fgnutls_available_p): New function.
1712 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1713 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1714 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1715
1716 * image.c: Include w32.h.
1717 (Vimage_type_cache): Delete.
1718 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1719 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1720 (w32_delayed_load): Move to w32.c.
1721
1722 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1723
1724 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1725 (w32_delayed_load): Move from image.c. When loading a library, record
1726 its filename in the :loaded-from property of the library id.
1727 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1728 Initialize and staticpro them.
1729 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1730
1731 * process.c: Include lisp.h before w32.h, not after.
1732 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1733 instead of gnutls_record_check_pending.
1734
1735 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1736
ff4de4aa
TZ
17372011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1738
1739 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1740 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1741 as passed in.
1742
abe95abb
JD
17432011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1744
1745 * xterm.c (x_set_frame_alpha): Do not set property on anything
1746 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1747
e16e55d4
JB
17482011-05-02 Juanma Barranquero <lekktu@gmail.com>
1749
1750 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1751
bafcf6a5
JB
17522011-05-02 Juanma Barranquero <lekktu@gmail.com>
1753
1754 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1755 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1756 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1757 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1758 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1759 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1760 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1761 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1762 (Qgnutls_bootprop_callbacks_verify): Make static.
1763
e7a6747f
AS
17642011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1765
19ed11ba
AS
1766 * callproc.c: Indentation fixup.
1767
e7a6747f 1768 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1769 (wait_for_termination, interruptible_wait_for_termination):
1770 Move after wait_for_termination_1.
e7a6747f 1771
1ef14cb4
LMI
17722011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1773
1774 * sysdep.c (interruptible_wait_for_termination): New function
1775 which is like wait_for_termination, but allows keyboard
1776 interruptions.
1777
1778 * callproc.c (Fcall_process): Add (:file "file") as an option for
1779 the STDOUT buffer.
1780 (Fcall_process_region): Ditto.
1781
330d880c
EZ
17822011-04-30 Eli Zaretskii <eliz@gnu.org>
1783
8db90b73
EZ
1784 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1785 rather than `XVECTOR (FOO)->size'.
1786
330d880c
EZ
1787 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1788 inttypes.h, as a gnulib replacement is used if it not available in
1789 system headers.
1790
15cbd324
EZ
17912011-04-21 Eli Zaretskii <eliz@gnu.org>
1792
1793 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1794 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1795 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1796
1797 * coding.c (coding_alloc_by_realloc): Error out if destination
1798 will grow beyond MOST_POSITIVE_FIXNUM.
1799 (decode_coding_emacs_mule): Abort if there isn't enough place in
1800 charbuf for the composition carryover bytes. Reserve an extra
1801 space for up to 2 characters produced in a loop.
1802 (decode_coding_iso_2022): Abort if there isn't enough place in
1803 charbuf for the composition carryover bytes.
1804
18052011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1806
ae940cca
EZ
1807 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1808 aborting when %lld or %lll format is passed.
1809 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1810 %llo or %llx format is passed. (Bug#8545)
1811
03ab8921
EZ
1812 * window.c (window_scroll_line_based): Use a marker instead of
1813 simple variables to record original value of point. (Bug#7952)
1814
afda1437
EZ
1815 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1816 produced by %s or %c overflows available buffer space. (Bug#8545)
1817
f76dee0c
PE
18182011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1819
1820 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1821 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1822
fdc5744d
JB
18232011-04-28 Juanma Barranquero <lekktu@gmail.com>
1824
1825 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1826
638f053a
JB
18272011-04-28 Juanma Barranquero <lekktu@gmail.com>
1828
1829 * keyboard.c (Qdelayed_warnings_hook): Define.
1830 (command_loop_1): Run `delayed-warnings-hook'
1831 if Vdelayed_warnings_list is non-nil.
1832 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1833 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1834
d178f871
EZ
18352011-04-28 Eli Zaretskii <eliz@gnu.org>
1836
1837 * doprnt.c (doprnt): Don't return value smaller than the buffer
1838 size if the message was truncated. (Bug#8545).
1839
b124fd93
JB
18402011-04-28 Juanma Barranquero <lekktu@gmail.com>
1841
1842 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1843 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1844
e810457d
PE
18452011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1846
1847 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1848
ea51cceb
JB
18492011-04-27 Juanma Barranquero <lekktu@gmail.com>
1850
1851 * makefile.w32-in: Update dependencies.
1852
94dcfacf
EZ
18532011-04-27 Eli Zaretskii <eliz@gnu.org>
1854
1855 Improve `doprnt' and its usage. (Bug#8545)
1856 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1857 `format_end'. Remove support for %l as a conversion specifier.
1858 Don't use xrealloc. Improve diagnostics when the %l size modifier
1859 is used. Update the commentary.
1860
1861 * eval.c (verror): Simplify calculation of size_t.
1862
1863 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1864 messages.
1865
f61f41d7
PE
18662011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1867
1868 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1869 change.
1870
96fb4434
PE
18712011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1872
1873 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1874 This makes this file independent of the recent pseudovector change.
1875
671875da 18762011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1877
69e9b5a3
PE
1878 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1879
b5f869a7 1880 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1881 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1882 Remove unused local.
c8926152 1883 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1884
841a1577 1885 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1886 GCC 4.6.0 optimizes based on type-based alias analysis.
1887 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1888 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1889 != &v->size, and therefore "v->size = 1; b->size = 2; return
1890 v->size;" must therefore return 1. This assumption is incorrect
1891 for Emacs, since it type-puns struct Lisp_Vector * with many other
1892 types. To fix this problem, this patch adds a new type struct
f904488f 1893 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1894 and pseudovectors, and helps optimizing compilers not get fooled
1895 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1896 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1897 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1898 the size member.
eab3844f
PE
1899 (XSETPVECTYPE): Rewrite in terms of new macro.
1900 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1901 This is a bit clearer, and further avoids the possibility of
1902 undesirable aliasing.
1903 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1904 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1905 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1906 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1907 (ASIZE): Now uses header.size rather than size.
1908 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1909 to avoid the hassle of writing XVECTOR (foo)->header.size.
1910 (struct vectorlike_header): New type.
eab3844f
PE
1911 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1912 object, to help avoid aliasing.
1913 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1914 (SUBRP): Likewise, since Lisp_Subr is a special case.
1915 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1916 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1917 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1918 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1919 changed to be "header.size" and "header.next".
1920 * buffer.h (struct buffer): Likewise.
1921 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1922 * frame.h (struct frame): Likewise.
1923 * process.h (struct Lisp_Process): Likewise.
1924 * termhooks.h (struct terminal): Likewise.
1925 * window.c (struct save_window_data, struct saved_window): Likewise.
1926 * window.h (struct window): Likewise.
1927 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1928 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1929 * buffer.c (init_buffer_once): Likewise.
1930 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1931 special case.
1932 * process.c (Fformat_network_address): Use local var for size,
1933 for brevity.
1934
0df1eac5
PE
1935 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1936
847ab9d1 1937 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1938 * data.c (atof): Remove decl; no longer used or needed.
1939 (digit_to_number): Move to lread.c.
1940 (Fstring_to_number): Use new string_to_number function, to be
1941 consistent with how the Lisp reader treats infinities and NaNs.
1942 Do not assume that floating-point numbers represent EMACS_INT
1943 without losing information; this is not true on most 64-bit hosts.
1944 Avoid double-rounding errors, by insisting on integers when
1945 parsing non-base-10 numbers, as the documentation specifies.
1946 * lisp.h (string_to_number): New decl, replacing ...
1947 (isfloat_string): Remove.
bc0a5c13 1948 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1949 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1950 appears to have been a coding error. Similarly, do not accept
1951 strings like +-1e0 as floating point numbers. Do not report
1952 overflow for integer overflows unless the base is not 10 which
1953 means we have no simple and reliable way to continue.
1954 Break out the floating-point parsing into a new
1955 function string_to_number, so that Fstring_to_number parses
1956 floating point numbers consistently with the Lisp reader.
04f2d78b 1957 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1958 (E_CHAR, EXP_INT): Remove, replacing with ...
1959 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1960 (string_to_number): New function, replacing isfloat_string.
1961 This function checks for valid syntax and produces the resulting
1962 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1963 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1964 so that overflow for non-base-10 numbers is reported only when
1965 there's no portable and simple way to convert to floating point.
452f4150 1966
67769ffc
PE
1967 * textprop.c (set_text_properties_1): Rewrite for clarity,
1968 and to avoid GCC warning about integer overflow.
1969
c20db43f
PE
1970 * intervals.h (struct interval): Use EMACS_INT for members
1971 where EMACS_UINT might cause problems. See
1972 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1973 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1974 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1975 All uses changed.
37aa2f85
PE
1976 (offset_intervals): Tell GCC not to worry about length overflow
1977 when negating a negative length.
c20db43f 1978
2538aa2f
PE
1979 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1980 (overrun_check_free): Likewise.
1981
f2d3008d
PE
1982 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1983 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1984 word size.
1985
ec8df744
PE
1986 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1987 (gnutls_make_error): Rename local to avoid shadowing.
1988 (gnutls_emacs_global_deinit): ifdef out; not used.
1989 (Fgnutls_boot): Use const for pointer to readonly storage.
1990 Comment out unused local. Fix pointer signedness problems.
1991
640ee02d
PE
1992 * lread.c (openp): Don't stuff size_t into an 'int'.
1993 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1994 about possible signed overflow.
1995
6048fb2a
PE
1996 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1997 (GDK_KEY_g): Don't define if already defined.
1998 (xg_prepare_tooltip): Avoid pointer signedness problem.
1999 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2000
fa3c87e1
PE
2001 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2002 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2003
2172544b
PE
2004 * xfns.c (Fx_window_property): Simplify a bit,
2005 to make a bit faster and to avoid GCC 4.6.0 warning.
2006 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2007
9b821a21
PE
2008 * fns.c (internal_equal): Don't assume size_t fits in int.
2009
3c616cfa
PE
2010 * alloc.c (compact_small_strings): Tighten assertion a little.
2011
c2982e87
PE
2012 Replace pEd with more-general pI, and fix some printf arg casts.
2013 * lisp.h (pI): New macro, generalizing old pEd macro to other
2014 conversion specifiers. For example, use "...%"pI"d..." rather
2015 than "...%"pEd"...".
2016 (pEd): Remove. All uses replaced with similar uses of pI.
2017 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2018 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2019 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2020 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2021 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2022 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2023 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2024 64-bit hosts.
2025 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2026 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2027 * print.c (safe_debug_print, print_object): Likewise.
2028 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2029 to int.
6f04d126
PE
2030 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2031 avoiding the 0 flag, which is not portable.
c2982e87
PE
2032 * process.c (Fmake_network_process): Use pI to avoid cast.
2033 * region-cache.c (pp_cache): Likewise.
2034 * xdisp.c (decode_mode_spec): Likewise.
2035 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2036 behavior on 64-bit hosts with printf arg.
6f04d126 2037 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2038 (x_stop_queuing_selection_requests): Likewise.
2039 (x_get_window_property): Don't truncate byte count to an 'int'
2040 when tracing.
0b432f21 2041
5e073ec7
PE
2042 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2043 here, since it parses constructs like leading '-' and spaces,
2044 which are not wanted; and it overflows with large numbers.
2045 Instead, simply match F[0-9]+, which is what is wanted anyway.
2046
36372bf9
PE
2047 * alloc.c: Remove unportable assumptions about struct layout.
2048 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2049 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2050 (allocate_vectorlike, make_pure_vector): Use the new macros,
2051 plus offsetof, to remove unportable assumptions about struct layout.
2052 These assumptions hold on all porting targets that I know of, but
2053 they are not guaranteed, they're easy to remove, and removing them
2054 makes further changes easier.
2055
0b432f21
PE
2056 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2057 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2058 (string_overrun_cookie): Now const. Use initializers that
2059 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2060 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2061 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2062 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2063 multiple of sizeof (EMACS_INT); it need not be, if
2064 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2065 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2066
895009e1
JB
20672011-04-26 Juanma Barranquero <lekktu@gmail.com>
2068
2069 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2070
6a7a1b0b
TZ
20712011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2072
2073 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2074 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2075 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2076
841a1577 20772011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2078
2079 * lisp.h (Qdebug): List symbol.
895009e1 2080 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2081 * keyboard.c (debug-on-event): New variable.
2082 (handle_user_signal): Break into debugger when debug-on-event
2083 matches the current signal symbol.
2084
f2d3ba6f
DN
20852011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2086
2087 * alloc.c (check_sblock, check_string_bytes)
2088 (check_string_free_list): Convert to standard C.
2089
42ce4c63
TZ
20902011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2091
2092 * w32.c (emacs_gnutls_push): Fix typo.
2093
825cd63c
EZ
20942011-04-25 Eli Zaretskii <eliz@gnu.org>
2095
fb11d64d
EZ
2096 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2097 "cast to pointer from integer of different size".
2098
825cd63c
EZ
2099 Improve doprnt and its use in verror. (Bug#8545)
2100 * doprnt.c (doprnt): Document the set of format control sequences
2101 supported by the function. Use SAFE_ALLOCA instead of always
2102 using `alloca'.
2103
2104 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2105 is one byte too soon. Don't use xrealloc; instead xfree and
2106 xmalloc anew.
2107
e061a11b
TZ
21082011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2109
2110 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2111 callbacks stage.
2112
2113 * gnutls.c: Renamed global_initialized to
2114 gnutls_global_initialized. Added internals for the
2115 :verify-hostname-error, :verify-error, and :verify-flags
2116 parameters of `gnutls-boot' and documented those parameters in the
2117 docstring. Start callback support.
2118 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2119 unless a fatal error occured. Call gnutls_alert_send_appropriate
2120 on error. Return error code.
2121 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2122 (emacs_gnutls_read): Likewise.
2123 (Fgnutls_boot): Return handshake error code.
2124 (emacs_gnutls_handle_error): New function.
2125 (wsaerror_to_errno): Likewise.
2126
2127 * w32.h (emacs_gnutls_pull): Add prototype.
2128 (emacs_gnutls_push): Likewise.
2129
2130 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2131 (emacs_gnutls_push): Likewise.
2132
21332011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2134
2135 * process.c (wait_reading_process_output): Check if GnuTLS
2136 buffered some data internally if no FDs are set for TLS
2137 connections.
2138
2139 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2140 (LIBS): Link to USER_LIBS.
2141 ($(BLD)/gnutls.$(0)): New target.
2142
fa6996bc
EZ
21432011-04-24 Eli Zaretskii <eliz@gnu.org>
2144
eb35682e
EZ
2145 * xdisp.c (handle_single_display_spec): Rename the
2146 display_replaced_before_p argument into display_replaced_p, to
2147 make it consistent with the commentary. Fix typos in the
2148 commentary.
2149
e2ad650c
EZ
2150 * textprop.c (syms_of_textprop): Remove dead code.
2151 (copy_text_properties): Delete obsolete commentary about an
2152 interface that was deleted long ago. Fix typos in the description
2153 of arguments.
2154
1b2de274
EZ
2155 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2156 to changes in oldXMenu/XMenu.h from 2011-04-16.
2157 <menu_help_message, prev_menu_help_message>: Constify.
2158 (IT_menu_make_room): menu->help_text is now `const char **';
2159 adjust.
2160
2161 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2162 to changes in oldXMenu/XMenu.h from 2011-04-16.
2163 (struct XMenu): Declare `help_text' `const char **'.
2164
2165 * xfaces.c <Qunspecified>: Make extern again.
2166
2167 * syntax.c: Include sys/types.h before including regex.h, as
2168 required by Posix.
2169
762b15be
EZ
2170 * doc.c (get_doc_string): Improve the format passed to `error'.
2171
2172 * doprnt.c (doprnt): Improve commentary.
2173
2174 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2175
2176 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2177 them with etags.
2178
f1052e5d
EZ
2179 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2180 changes in globals.h immediately force recompilation.
762b15be
EZ
2181 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2182 $(CURDIR)/s/ms-w32.h.
2183 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2184
fa6996bc
EZ
2185 * character.c (Fchar_direction): Function deleted.
2186 (syms_of_character): Don't defsubr it.
2187 <char-direction-table>: Deleted.
2188
e6c3da20
EZ
21892011-04-23 Eli Zaretskii <eliz@gnu.org>
2190
2191 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2192 * doprnt.c: Include limits.h.
2193 (SIZE_MAX): New macro.
04f2d78b
CB
2194 (doprnt): Return a size_t value. 2nd arg is now size_t.
2195 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2196 Improve overflow protection. Support `l' modifier for integer
2197 conversions. Support %l conversion. Don't assume an EMACS_INT
2198 argument for integer conversions and for %c.
2199
2200 * lisp.h (doprnt): Restore prototype.
2201
2202 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2203 $(SRC)/character.h.
2204
2205 * Makefile.in (base_obj): Add back doprnt.o.
2206
2207 * deps.mk (doprnt.o): Add back prerequisites.
2208 (callint.o): Depend on character.h.
2209
2210 * eval.c (internal_lisp_condition_case): Include the handler
2211 representation in the error message.
2212 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2213 when breaking from the loop.
2214
2215 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2216
2217 * callint.c (Fcall_interactively): When displaying error message
2218 about invalid control letter, pass the character's codepoint, not
2219 a pointer to its multibyte form. Improve display of the character
2220 in octal and display also its hex code.
2221
2222 * character.c (char_string): Use %x to display the (unsigned)
2223 codepoint of an invalid character, to avoid displaying a bogus
2224 negative value.
2225
2226 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2227 `error', not SYMBOL_NAME itself.
2228
2229 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2230 character arguments to `error'.
2231
2232 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2233 to `error' in error message about FINAL_CHAR argument. Make sure
2234 FINAL_CHAR is a character, and use %c when it is passed as
2235 argument to `error'.
2236
4ffd0d6b 22372011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2238
2239 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2240
2241 * w32.c: Include <time.h>.
2242 (sys_localtime): New function.
2243
4ffd0d6b 22442011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2245
2246 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2247
4ffd0d6b 2248 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2249
4ffd0d6b 22502011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2251
4ffd0d6b
GM
2252 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2253 zombies (Bug#8467).
aac0c6e3 2254
04c56954
EZ
22552011-04-19 Eli Zaretskii <eliz@gnu.org>
2256
2257 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2258 gl_state.e_property when gl_state.object is Qt.
2259
2260 * insdel.c (make_gap_larger): Remove limitation of buffer size
2261 to <= INT_MAX.
2262
16a43933
CY
22632011-04-18 Chong Yidong <cyd@stupidchicken.com>
2264
2265 * xdisp.c (lookup_glyphless_char_display)
2266 (produce_glyphless_glyph): Handle cons cell entry in
2267 glyphless-char-display.
2268 (Vglyphless_char_display): Document it.
2269
2270 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2271 glyphless-char-display.
2272
4581706e
CY
22732011-04-17 Chong Yidong <cyd@stupidchicken.com>
2274
2275 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2276
2277 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2278
2279 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2280 definition for no-X builds.
2281
4887c6e2 22822011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2283
fd35b6f9
PE
2284 Static checks with GCC 4.6.0 and non-default toolkits.
2285
5c1ccb01
PE
2286 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2287
006c5daa
PE
2288 * process.c (keyboard_bit_set): Define only if SIGIO.
2289 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2290 (send_process): Repair possible setjmp clobbering.
2291
efc736d3
PE
2292 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2293
4e2fe2e6
PE
2294 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2295
f97334a2
PE
2296 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2297
4e75f29d
PE
2298 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2299 Define only if needed.
2300
90efadd1
PE
2301 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2302 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 2303 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 2304
3c647824
PE
2305 * dispextern.h (struct redisplay_interface): Rename param
2306 to avoid shadowing.
e264f262 2307 * termhooks.h (struct terminal): Likewise.
761383f4 2308 * xterm.c (xembed_send_message): Likewise.
3c647824 2309
b58c5c4a
PE
2310 * insdel.c (make_gap_smaller): Define only if
2311 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2312
cad59032
PE
2313 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2314 it.
2315
c339dc2e
PE
2316 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2317 so that we aren't warned about unused symbols.
2318
91a3e27b
PE
2319 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2320
399c71d3 2321 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2322
8ffc96f5
PE
2323 * xfns.c (x_real_positions): Mark locals as initialized.
2324
eef9bc79
PE
2325 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2326
098db9dd
PE
2327 * xterm.c: Fix problems found by static analysis with other toolkits.
2328 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2329 (x_dispatch_event): Declare static if USE_GTK, and
2330 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2331 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2332 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2333 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2334 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2335
eb18f6cc
PE
2336 * xmenu.c (menu_help_callback): Pointer type fixes.
2337 Use const pointers when pointing at readonly data. Avoid pointer
2338 signedness clashes.
2339 (FALSE): Remove unused macro.
2340 (update_frame_menubar): Remove unused decl.
2341
1fe72bf8
PE
2342 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2343
60d9e1db
PE
2344 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2345 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2346 (single_menu_item): Rename local to avoid shadowing.
2347
39261c26
PE
2348 * keyboard.c (make_lispy_event): Remove unused local var.
2349
018c5e19
PE
2350 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2351 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2352
63d2b86e
PE
2353 * bitmaps: Change bitmaps from unsigned char back to the X11
2354 compatible char. Avoid the old compiler warnings about
2355 out-of-range initializers by using, for example, '\xab' rather
2356 than 0xab.
2357
aefd87e1
PE
2358 * xgselect.c (xgselect_initialize): Check vs interface
2359 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2360
bf501fb9
PE
2361 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2362
e9829fdf
PE
2363 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2364 to read-only memory.
2365
1086c095
PE
2366 * fns.c (vector): Remove; this old hack is no longer needed.
2367
2baccd04 2368 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2369 Remove unused var.
dde42981 2370 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2371
72391843 2372 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2373
436c16df 2374 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2375 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2376 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2377
92bb796d 2378 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2379 (x_term_init): Remove local to avoid shadowing.
92bb796d 2380
764430a3 2381 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2382
2383 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2384 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2385
d1dfb56c
EZ
23862011-04-16 Eli Zaretskii <eliz@gnu.org>
2387
c4354cb4
EZ
2388 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2389
d1dfb56c
EZ
2390 Fix regex.c, syntax.c and friends for buffers > 2GB.
2391 * syntax.h (struct gl_state_s): Declare character position members
2392 EMACS_INT.
2393
2394 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2395
04f2d78b
CB
2396 * textprop.c (verify_interval_modification, interval_of):
2397 Declare arguments EMACS_INT.
d1dfb56c
EZ
2398
2399 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2400 EMACS_INT.
2401
2402 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2403
2404 * indent.c (Fvertical_motion): Local variable it_start is now
2405 EMACS_INT.
2406
2407 * regex.c (re_match, re_match_2, re_match_2_internal)
2408 (bcmp_translate, regcomp, regexec, print_double_string)
2409 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2410 (re_compile_pattern, re_exec): Declare arguments and local
2411 variables `size_t' and `ssize_t' and return values `regoff_t', as
2412 appropriate.
2413 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2414 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2415 <compile_stack_type>: `size' and `avail' are now `size_t'.
2416
2417 * regex.h <regoff_t>: Use ssize_t, not int.
2418 (re_search, re_search_2, re_match, re_match_2): Arguments that
2419 specify buffer/string position and length are now ssize_t and
2420 size_t. Return type is regoff_t.
2421
613052cd
BK
24222011-04-16 Ben Key <bkey76@gmail.com>
2423
2424 * nsfont.m: Fixed bugs in ns_get_family and
2425 ns_descriptor_to_entity that were caused by using free to
2426 deallocate memory blocks that were allocated by xmalloc (via
2427 xstrdup). This caused Emacs to crash when compiled with
2428 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2429 --enable-checking=xmallocoverrun). xfree is now used to
2430 deallocate these memory blocks.
2431
4170f62f 24322011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2433
71b41406
PE
2434 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2435
9587a89d
PE
2436 emacs_write: Accept and return EMACS_INT for sizes.
2437 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2438 et seq.
2439 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2440 Accept and return EMACS_INT.
2441 (emacs_gnutls_write): Return the number of bytes written on
2442 partial writes.
2443 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2444 (emacs_read, emacs_write): Remove check for negative size, as the
2445 Emacs source code has been audited now.
9587a89d
PE
2446 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2447 (emacs_read, emacs_write): Use it.
273a5f82
PE
2448 * process.c (send_process): Adjust to the new signatures of
2449 emacs_write and emacs_gnutls_write. Do not attempt to store
2450 a byte offset into an 'int'; it might overflow.
9587a89d 2451 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2452
3e047f51
PE
2453 * sound.c: Don't assume sizes fit in 'int'.
2454 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2455 Return EMACS_INT, not int.
3e047f51 2456 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2457 Accept EMACS_INT, not int.
2458 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2459 record read return values.
2460
cc39a9db
BK
24612011-04-15 Ben Key <bkey76@gmail.com>
2462
c9d0ec6d
JB
2463 * keyboard.c (Qundefined): Don't declare static since it is used
2464 in nsfns.m.
2465 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2466 static since they are used in nsfont.m.
cc39a9db 2467
6c60eb9f
SM
24682011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2469
2470 * process.c (Qprocessp): Don't declare static.
2471 * lisp.h (Qprocessp): Declare again.
2472
7990b61a
JB
24732011-04-15 Juanma Barranquero <lekktu@gmail.com>
2474
2475 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2476
5d4cb038
PE
24772011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2478
8bd7b830 2479 Improve C-level modularity by making more things 'static'.
cd64ea1d 2480
e3b27b31
PE
2481 Don't publish debugger-only interfaces to other modules.
2482 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2483 (verify_bytepos, count_markers): Move decls to the only modules
2484 that need them.
2485 * region-cache.h (pp_cache): Likewise.
2486 * window.h (check_all_windows): Likewise.
2487 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2488
5d4cb038
PE
2489 * sysdep.c (croak): Now static, if
2490 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2491 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2492
2493 * alloc.c (refill_memory_reserve): Now static if
2494 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2495 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2496
e87b6180
PE
2497 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2498 Define only if USE_LUCID.
2499
ac64929e
PE
2500 * xrdb.c (x_customization_string, x_rm_string): Now static.
2501
6f37259d
PE
2502 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2503 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2504
1683e3ab
PE
2505 * xdisp.c (draw_row_with_mouse_face): Now static.
2506 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2507
de9c2632
PE
2508 * window.h (check_all_windows): Mark externally visible.
2509
2b96acb7
PE
2510 * window.c (window_deletion_count): Now static.
2511
2512 * undo.c: Make symbols static if they're not exported.
2513 (last_undo_buffer, last_boundary_position, pending_boundary):
2514 Now static.
2515
50436f33
PE
2516 * textprop.c (interval_insert_behind_hooks): Now static.
2517 (interval_insert_in_front_hooks): Likewise.
2518
64520e5c
PE
2519 * term.c: Make symbols static if they're not exported.
2520 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2521 (max_frame_lines, tty_set_terminal_modes):
2522 (tty_reset_terminal_modes, tty_turn_off_highlight):
2523 (get_tty_terminal): Now static.
2524 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2525 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2526 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2527 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2528 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2529
1fa53021
PE
2530 * sysdep.c: Make symbols static if they're not exported.
2531 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2532 Now static.
2533 (sigprocmask_set, full_mask): Remove; unused.
2534 (wait_debugging): Mark as visible.
2535 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2536 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2537
d4b43b22
PE
2538 * syntax.c (syntax_temp): Define only if !__GNUC__.
2539
b7c513d0
PE
2540 * sound.c (current_sound_device, current_sound): Now static.
2541
989b29ad
PE
2542 * search.c (searchbufs, searchbuf_head): Now static.
2543
13a55a78
PE
2544 * scroll.c (scroll_cost): Remove; unused.
2545 * dispextern.h (scroll_cost): Remove decl.
2546
de68a1fc
PE
2547 * region-cache.h (pp_cache): Mark as externally visible.
2548
40ccffa6
PE
2549 * process.c: Make symbols static if they're not exported.
2550 (process_tick, update_tick, create_process, chan_process):
2551 (Vprocess_alist, proc_buffered_char, datagram_access):
2552 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2553 (deactivate_process): Mark defn as static, as well as decl.
2554 * lisp.h (create_process): Remove decl.
2555 * process.h (chan_process, Vprocess_alist): Remove decls.
2556
ad64fc97
PE
2557 * print.c: Make symbols static if they're not exported.
2558 (print_depth, new_backquote_output, being_printed, print_buffer):
2559 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2560 (print_interval, print_number_index, initial_stderr_stream):
2561 Now static.
2562 * lisp.h (Fprinc): Remove decl.
2563 (debug_output_compilation_hack): Mark as externally visible.
2564
adddb265
PE
2565 * sysdep.c (croak): Move decl from here to syssignal.h.
2566 * syssignal.h (croak): Put it here, so the API can be checked when
2567 'croak' is called from dissociate_if_controlling_tty.
2568
1717ede2
PE
2569 * minibuf.c: Make symbols static if they're not exported.
2570 (minibuf_save_list, choose_minibuf_frame): Now static.
2571 * lisp.h (choose_minibuf_frame): Remove decl.
2572
fa5fb2bc
PE
2573 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2574
1e3890d1
PE
2575 * lread.c: Make symbols static if they're not exported.
2576 (read_objects, initial_obarray, oblookup_last_bucket_number):
2577 Now static.
2578 (make_symbol): Remove; unused.
2579 * lisp.h (initial_obarray, make_symbol): Remove decls.
2580
8a1414fa
PE
2581 * keyboard.c: Make symbols static if they're not exported.
2582 (single_kboard, recent_keys_index, total_keys, recent_keys):
2583 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2584 (this_single_command_key_start, echoing, last_auto_save):
2585 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2586 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2587 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2588 (Vlispy_mouse_stem, double_click_count):
2589 Now static.
2590 (force_auto_save_soon): Define only if SIGDANGER.
2591 (ignore_mouse_drag_p): Now static if
2592 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2593 (print_help): Remove; unused.
2594 (stop_character, last_timer_event): Mark as externally visible.
2595 * keyboard.h (ignore_mouse_drag_p): Declare only if
2596 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2597 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2598 * lisp.h (echoing): Remove decl.
2599 (force_auto_save_soon): Declare only if SIGDANGER.
2600 * xdisp.c (redisplay_window): Simplify code, to make it more
2601 obvious that ignore_mouse_drag_p is not accessed if !defined
2602 USE_GTK && !defined HAVE_NS.
2603
93ea6e8f
PE
2604 * intervals.c: Make symbols static if they're not exported.
2605 (merge_properties_sticky, merge_interval_right, delete_interval):
2606 Now static.
2607 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2608
77382fcc
PE
2609 * insdel.c: Make symbols static if they're not exported.
2610 However, leave prepare_to_modify_buffer alone. It's never
2611 called from outside this function, but that appears to be a bug.
2612 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2613 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2614 (adjust_after_replace_noundo): Remove; unused.
2615 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2616 (signal_before_change): Remove decls.
77382fcc 2617
9306c32e
PE
2618 * indent.c (val_compute_motion, val_vmotion): Now static.
2619
cd44d2eb
PE
2620 * image.c: Make symbols static if they're not exported.
2621 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2622 if USE_GTK.
2623 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2624 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2625
ad9a7a06
PE
2626 * fringe.c (standard_bitmaps): Now static.
2627 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2628
81626931
PE
2629 * frame.c: Make symbols static if they're not exported.
2630 (x_report_frame_params, make_terminal_frame): Now static.
2631 (get_frame_param): Now static, unless HAVE_NS.
2632 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2633 (x_get_resource_string): Remove; not used.
2634 * frame.h (make_terminal_frame, x_report_frame_params):
2635 (x_get_resource_string); Remove decls.
2636 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2637 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2638
239f9db9
PE
2639 * font.c, fontset.c: Make symbols static if they're not exported.
2640 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2641 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2642 * font.c (font_close_object): Now static.
2643 * font.h (font_close_object): Remove.
2644 * fontset.c (FONTSET_OBJLIST): Remove.
2645 (free_realized_fontset) #if-0 the body, which does nothing.
2646 (face_suitable_for_char_p): #if-0, as it's never called.
2647 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2648 * xfaces.c (face_at_string_position):
2649 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2650 since 0 is always ASCII.
2651
dfcf3579
PE
2652 * fns.c (weak_hash_tables): Now static.
2653
5045092b
PE
2654 * fileio.c: Make symbols static if they're not exported.
2655 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2656 (Vwrite_region_annotation_buffers): Now static.
2657
57a96f5c
PE
2658 * eval.c: Make symbols static if they're not exported.
2659 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2660 * lisp.h (backtrace_list): Remove decl.
2661
35f08c38
PE
2662 * emacs.c: Make symbols static if they're not exported.
2663 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2664 (fatal_error_code, fatal_error_signal_hook, standard_args):
2665 Now static.
2666 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2667 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2668 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2669 * lisp.h (fatal_error_signal_hook): Remove decl.
2670 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2671
f44bd759
PE
2672 * editfns.c: Move a (normally-unused) function to its only use.
2673 * editfns.c, lisp.h (get_operating_system_release): Remove.
2674 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2675 worth the hassle of breaking this out.
2676
b532497d
PE
2677 * xterm.c: Make symbols static if they're not exported.
2678 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2679 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2680 (x_destroy_window, x_delete_display):
2681 Now static.
2682 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2683 (x_mouse_leave): Remove; unused.
2684 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2685 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2686 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2687 Remove decls.
2688 (x_mouse_leave): Declare only if WINDOWSNT.
2689 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2690 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2691 USE_X_TOOLKIT.
2692
1675728f
PE
2693 * ftxfont.c: Make symbols static if they're not exported.
2694 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2695 HAVE_FREETYPE.
2696 * font.h (ftxfont_driver): Likewise.
2697
e4cebfca
PE
2698 * xfns.c: Make symbols static if they're not exported.
2699 (x_last_font_name, x_display_info_for_name):
2700 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2701 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2702 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2703 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2704 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2705 (last_show_tip_args): Now static.
2706 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2707 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2708 (x_screen_planes): Remove; unused.
2709 * dispextern.h (x_screen_planes): Remove decl.
2710
5bf46f05
PE
2711 * dispnew.c: Make symbols static if they're not exported.
2712 * dispextern.h (redraw_garbaged_frames, scrolling):
2713 (increment_row_positions): Remove.
2714 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2715 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2716 Now static.
2717 (redraw_garbaged_frames): Remove; unused.
2718
435f4c28
PE
2719 * xfaces.c: Make symbols static if they're not exported.
2720 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2721 Remove decls.
2722 * xterm.h (defined_color): Remove decls.
2723 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2724 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2725 (menu_face_changed_default, defined_color, free_realized_face):
2726 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2727 (ascii_face_of_lisp_face): Remove; unused.
2728
8524aef3
PE
2729 * xdisp.c: Make symbols static if they're not exported.
2730 * dispextern.h (scratch_glyph_row, window_box_edges):
2731 (glyph_to_pixel_coords, set_cursor_from_row):
2732 (get_next_display_element, set_iterator_to_next):
2733 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2734 (show_mouse_face): Remove decls
2735 * frame.h (message_buf_print): Likewise.
2736 * lisp.h (pop_message, set_message, check_point_in_composition):
2737 Likewise.
2738 * xterm.h (set_vertical_scroll_bar): Likewise.
2739 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2740 (message_buf_print, scratch_glyph_row, displayed_buffer):
2741 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2742 (get_next_display_element, show_mouse_face, window_box_edges):
2743 (frame_to_window_pixel_xy, check_point_in_composition):
2744 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2745 (glyph_to_pixel_coords): Remove; unused.
2746
16390cd2
PE
2747 * dired.c (file_name_completion): Now static.
2748
2749 * dbusbind.c (xd_in_read_queued_messages): Now static.
2750
a25f4dfa
PE
2751 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2752 * data.c (circular_list_error): Remove.
2753
14a9c8df
PE
2754 * commands.h (last_point_position, last_point_position_buffer):
2755 (last_point_position_window): Remove decls.
2756 * keyboard.c: Make these variables static.
2757
04f2d78b
CB
2758 * coding.h (coding, code_convert_region, encode_coding_gap):
2759 Remove decls.
74ab6df5
PE
2760 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2761 (iso_code_class, detect_coding, code_convert_region): Now static.
2762 (encode_coding_gap): Remove; unused.
2763
38dfbee1
PE
2764 * chartab.c (chartab_chars, chartab_bits): Now static.
2765
a2cb4e63
PE
2766 * charset.h (charset_iso_8859_1): Remove decl.
2767 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2768 Now static.
2769
127198fd
PE
2770 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2771 * ccl.c (Vccl_program_table): Now static.
2772 (check_ccl_update): Remove; unused.
2773
d85b608f
PE
2774 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2775 * category.h: ... from here.
2776 * category.c (check_category_table, set_category_set): Now static.
2777
31cd66f3
PE
2778 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2779 * lisp.h: Remove these decls.
2780
c358e587
PE
2781 * buffer.c (buffer_count): Remove unused var.
2782
e78aecca
PE
2783 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2784 so that it's not optimized away.
2785 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2786 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2787 exported only to the debugger.
2788
e192d7d3 2789 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2790 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2791
92470028
PE
2792 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2793 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2794 was inaccessible from Lisp.
2795 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2796 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2797
244ed907
PE
2798 alloc.c: Import and export fewer symbols, and remove unused items.
2799 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2800 is defined.
2801 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2802 it's not optimized away by whole-program optimization.
2803 (message_enable_multibyte, free_misc): Remove.
2804 (catchlist, handlerlist, mark_backtrace):
2805 Declare only if BYTE_MARK_STACK.
2806 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2807 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2808 (message_enable_multibyte): Remove decl.
2809 (free_misc, interval_free_list, float_block, float_block_index):
2810 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2811 (cons_free_list, last_marked_index):
2812 Now static.
2813 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2814 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2815 (mark_backtrace): Define only if BYTE_MARK_STACK.
2816 * xdisp.c (message_enable_multibyte): Now static.
2817
61c2b50e 2818 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2819 This makes it easier for human readers (and static analyzers)
2820 to see whether these variables are used from other modules.
2821 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2822 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2823 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2824 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2825 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2826 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2827 * xmenu.c, xselect.c:
2828 Declare Q* vars static if they are not used in other modules.
2829 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2830 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2831 Remove decls of unexported vars.
2832 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2833
95c82688
PE
2834 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2835
16a97296
PE
2836 Make Emacs functions such as Fatom 'static' by default.
2837 This makes it easier for human readers (and static analyzers)
2838 to see whether these functions can be called from other modules.
2839 DEFUN now defines a static function. To make the function external
2840 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2841 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2842 (Finit_image_library):
16a97296
PE
2843 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2844 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2845 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2846 Remove decls, since these functions are now static.
2847 (Funintern, Fget_internal_run_time): New decls, since these functions
2848 were already external.
95c82688 2849
16a97296
PE
2850 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2851 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2852 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2853 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2854 * keyboard.c, keymap.c, lread.c:
2855 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2856 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2857 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2858 Mark functions with DEFUE instead of DEFUN,
2859 if they are used in other modules.
2860 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2861 decls for now-static functions.
2862 * buffer.h (Fdelete_overlay): Remove decl.
2863 * callproc.c (Fgetenv_internal): Mark as internal.
2864 * composite.c (Fremove_list_of_text_properties): Remove decl.
2865 (Fcomposition_get_gstring): New forward static decl.
2866 * composite.h (Fcomposite_get_gstring): Remove decl.
2867 * dired.c (Ffile_attributes): New forward static decl.
2868 * doc.c (Fdocumntation_property): New forward static decl.
2869 * eval.c (Ffetch_bytecode): New forward static decl.
2870 (Funintern): Remove extern decl; now in .h file where it belongs.
2871 * fileio.c (Fmake_symbolic_link): New forward static decl.
2872 * image.c (Finit_image_library): New forward static decl.
2873 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2874 * intervals.h (Fprevious_property_change):
2875 (Fremove_list_of_text_properties): Remove decls.
2876 * keyboard.c (Fthis_command_keys): Remove decl.
2877 (Fcommand_execute): New forward static decl.
2878 * keymap.c (Flookup_key): New forward static decl.
2879 (Fcopy_keymap): Now static.
2880 * keymap.h (Flookup_key): Remove decl.
2881 * process.c (Fget_process): New forward static decl.
2882 (Fprocess_datagram_address): Mark as internal.
2883 * syntax.c (Fsyntax_table_p): New forward static decl.
2884 (skip_chars): Remove duplicate decl.
2885 * textprop.c (Fprevious_property_change): New forward static decl.
2886 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2887 Now internal.
2888 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2889 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2890
785bbd42
PE
2891 * editfns.c (Fformat): Remove unreachable code.
2892
8b913b57
AS
28932011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2894
2895 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2896 change. (Bug#8496)
2897
a6744a35
EZ
28982011-04-13 Eli Zaretskii <eliz@gnu.org>
2899
2900 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2901 when at ZV. (Bug#8487)
2902
e7974947
AS
29032011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2904
baad03f0
AS
2905 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2906 (Bug#8437)
2907 * keyboard.c (parse_tool_bar_item): Likewise.
2908 * sound.c (sound_cleanup, alsa_close): Likewise.
2909 * termcap.c (tgetent): Likewise.
2910 * xfns.c (x_default_font_parameter): Likewise.
2911 * xsettings.c (read_and_apply_settings): Likewise.
2912
e7974947
AS
2913 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2914 (overrun_check_free): Protoize.
2915
28272684
PE
29162011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2917
2918 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2919 since callers should never pass a negative size.
2920 Change the signature to match that of plain 'read' and 'write'; see
2921 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2922 * lisp.h: Update prototypes of emacs_write and emacs_read.
2923
11997c76
EZ
29242011-04-11 Eli Zaretskii <eliz@gnu.org>
2925
2926 * xdisp.c (redisplay_window): Don't try to determine the character
2927 position of the scroll margin if the window start point w->startp
e896f03c 2928 is outside the buffer's accessible region. (Bug#8468)
11997c76 2929
8a2cbd72
EZ
29302011-04-10 Eli Zaretskii <eliz@gnu.org>
2931
2932 Fix write-region and its subroutines for buffers > 2GB.
2933 * fileio.c (a_write, e_write): Modify declaration of arguments and
2934 local variables to support buffers larger than 2GB.
2935 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2936
2937 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2938 argument, local variables, and return value.
2939
2940 * lisp.h: Update prototypes of emacs_write and emacs_read.
2941
2942 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2943
4073e537 29442011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2945
1ebfdcb6
PE
2946 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2947
b2ded58d
PE
2948 Fix more problems found by GCC 4.6.0's static checks.
2949
7d66342c
PE
2950 * xdisp.c (vmessage): Use a better test for character truncation.
2951
bbf47d44
PE
2952 * charset.c (load_charset_map): <, not <=, for optimization,
2953 and to avoid potential problems with integer overflow.
9248994d 2954 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2955 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2956 * editfns.c (Fformat): Likewise.
1e69125e 2957 * syntax.c (skip_chars): Likewise.
3befa583 2958
e3019616
PE
2959 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2960 This also lets GCC 4.6.0 generate slightly better loop code.
2961
becfa255
PE
2962 * callint.c (Fcall_interactively): <, not <=, for optimization.
2963 (Fcall_interactively): Count the number of arguments produced,
2964 not the number of arguments given. This is simpler and lets GCC
2965 4.6.0 generate slightly better code.
2966
dae0cd48
PE
2967 * ftfont.c: Distingish more carefully between FcChar8 and char.
2968 The previous code passed unsigned char * to a functions like
2969 strlen and xstrcasecmp that expect char *, which does not
2970 conform to the C standard.
2971 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2972 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2973 char * when the C standard requires it.
2974
76032d70
PE
2975 * keyboard.c (read_char): Remove unused var.
2976
eb3f1cc8
PE
2977 * eval.c: Port to Windows vsnprintf (Bug#8435).
2978 Include <limits.h>.
2979 (SIZE_MAX): Define if the headers do not.
2980 (verror): Do not give up if vsnprintf returns a negative count.
2981 Instead, grow the buffer. This ports to Windows vsnprintf, which
2982 does not conform to C99. Problem reported by Eli Zaretskii.
2983 Also, simplify the allocation scheme, by avoiding the need for
2984 calling realloc, and removing the ALLOCATED variable.
2985
70476b54
PE
2986 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2987
12020a9e
PE
2988 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2989 But keep the doprint source code for now, as we might revamp it
2990 and use it again (Bug#8435).
ea6c7ae6
PE
2991 * lisp.h (doprnt): Remove.
2992 * Makefile.in (base_obj): Remove doprnt.o.
2993 * deps.mk (doprnt.o): Remove.
2994
5fdb398c
PE
2995 error: Print 32- and 64-bit integers portably (Bug#8435).
2996 Without this change, on typical 64-bit hosts error ("...%d...", N)
2997 was used to print both 32- and 64-bit integers N, which relied on
2998 undefined behavior.
2999 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3000 New macro.
3001 * lisp.h (error, verror): Mark as printf-like functions.
3002 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3003 Report overflow in size calculations when allocating printf buffer.
3004 Do not truncate output string at its first null byte.
3005 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3006 Truncate the output at a character boundary, since vsnprintf does not
3007 do that.
3008 * charset.c (check_iso_charset_parameter): Convert internal
3009 character to string before calling 'error', since %c now has the
3010 printf meaning.
3011 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3012 overflow when computing char to be passed to 'error'. Do not
3013 pass Lisp_Object to 'error'; pass the integer instead.
3014 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3015 formatted with plain %d.
3016
b189fa66
PE
3017 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3018
bff87ef0
PE
3019 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3020
7e2cac20
PE
3021 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3022
ce4d90b5
PE
3023 * xterm.c (x_catch_errors): Remove duplicate declaration.
3024
266c9547
PE
3025 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3026
79c49ad2
PE
3027 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3028
368f4090
JM
30292011-04-10 Jim Meyering <meyering@redhat.com>
3030
3031 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3032 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3033 return ssize_t not "int", and use size_t as the buffer length.
3034 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3035 * gnutls.h: Update declarations.
3036 * process.c (read_process_output): Use ssize_t, to match.
3037 (send_process): Likewise.
3038
a32d4040
CY
30392011-04-09 Chong Yidong <cyd@stupidchicken.com>
3040
3041 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3042
8546720e 30432011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3044
04f2d78b
CB
3045 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3046 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3047
8546720e
GM
3048 * xterm.c (handle_one_xevent):
3049 * xmenu.c (create_and_show_popup_menu):
3050 * xselect.c (x_decline_selection_request)
3051 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3052
0a2f5c1a 30532011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3054
3055 Fix some uses of `int' instead of EMACS_INT.
3056 * search.c (string_match_1, fast_string_match)
3057 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3058 (scan_buffer, find_next_newline_no_quit)
3059 (find_before_next_newline, search_command, Freplace_match)
3060 (Fmatch_data): Make some `int' variables be EMACS_INT.
3061
3062 * xdisp.c (display_count_lines): 3rd argument and return value now
3063 EMACS_INT. All callers changed.
3064 (pint2hrstr): Last argument is now EMACS_INT.
3065
3066 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3067 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3068 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3069 (decode_coding_utf_16, decode_coding_emacs_mule)
3070 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3071 (decode_coding_ccl, decode_coding_charset)
3072 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3073 (decode_coding_iso_2022, decode_coding_emacs_mule)
3074 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3075 <char_offset, last_offset>: Declare EMACS_INT.
3076 (encode_coding_utf_8, encode_coding_utf_16)
3077 (encode_coding_emacs_mule, encode_invocation_designation)
3078 (encode_designation_at_bol, encode_coding_iso_2022)
3079 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3080 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3081 Declare EMACS_INT.
3082 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3083 (encode_invocation_designation): Last argument P_NCHARS is now
3084 EMACS_INT.
3085 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3086 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3087
3088 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3089 All users changed.
3090
3091 * ccl.c (Fccl_execute_on_string): Declare some variables
3092 EMACS_INT.
3093
8546720e 30942011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3095
3096 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3097
4e19a977
CS
30982011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3099
3100 * process.c (Fformat_network_address): Doc fix.
3101
87302331
R
31022011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3103
3104 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3105
cbb59342
CY
31062011-04-08 Chong Yidong <cyd@stupidchicken.com>
3107
3108 * keyboard.c (read_char): Call Lisp function help-form-show,
3109 instead of using internal_with_output_to_temp_buffer.
3110 (Qhelp_form_show): New var.
e0d38eeb 3111 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3112
3113 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3114
3115 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3116
e67a13ab
CY
31172011-04-06 Chong Yidong <cyd@stupidchicken.com>
3118
04f2d78b
CB
3119 * process.c (Flist_processes): Remove to Lisp.
3120 (list_processes_1): Delete.
e67a13ab 3121
973f782d
EZ
31222011-04-06 Eli Zaretskii <eliz@gnu.org>
3123
7c106b1e
EZ
3124 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3125
973f782d
EZ
3126 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3127
41cf7d1a 31282011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3129
ca23cc88
PE
3130 Fix more problems found by GCC 4.6.0's static checks.
3131
f390e2d5
PE
3132 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3133
42eea0d0
PE
3134 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3135
b69769da 3136 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3137
f9541e84
PE
3138 * xdisp.c (vmessage): Mark as a printf-like function.
3139
13841b55
PE
3140 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3141
c136c10f
PE
3142 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3143
5e2d4a30
PE
3144 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3145 printf-like functions.
3146 (tiff_load): Add casts to remove these marks before passing them
3147 to system-supplied API.
3148
583f48b9
PE
3149 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3150
b25d760e
PE
3151 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3152 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3153 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3154 directly, rather than having caller test rule sign. This avoids
3155 some unnecessary tests.
3156 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3157 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3158 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3159
bc7b6697 3160 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3161 (xfont_open): Avoid unnecessary tests.
bc7b6697 3162
27ccc379
PE
3163 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3164
dcd5c89a
PE
3165 * composite.h, composite.c (composition_gstring_put_cache):
3166 Use EMACS_INT, not int, for length.
3167
b13a45c6
PE
3168 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3169 breaking out part of COMPOSITION_DECODE_RULE.
3170 (COMPOSITION_DECODE_RULE): Use it.
3171 * composite.c (get_composition_id): Remove unused local vars,
3172 by using the new macro.
3173
1e792e4d
PE
3174 * textprop.c (set_text_properties_1): Change while to do-while,
3175 since the condition is always true at first.
3176
dc6c6455 3177 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3178 (interval_deletion_adjustment): Return unsigned value.
3179 All uses changed.
dc6c6455 3180
aba7731a
PE
3181 * process.c (list_processes_1, create_pty, read_process_output):
3182 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3183 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3184 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3185 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3186 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3187
fdfc4bf3
PE
3188 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3189
fca8fe46 3190 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3191 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3192
06a0259a 3193 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3194 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3195 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3196
e7b9e80f
PE
3197 * print.c (print_error_message): Avoid int overflow.
3198
56201685
PE
3199 * font.c (font_list_entities): Redo for clarity,
3200 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3201
78834453 3202 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3203 (font_score): Avoid potential overflow in diff calculation.
78834453 3204
0bc0b309 3205 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3206 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3207
e610eaca
PE
3208 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3209
b895abce
PE
3210 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3211 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3212 can always succeed if overflow has undefined behavior.
3213
1f1d9321 3214 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3215 (wordify): Omit three unnecessary tests.
1f1d9321 3216
c59478bc
PE
3217 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3218 All callers changed. This avoids the need for an unused var.
3219
79b73827
PE
3220 * casefiddle.c (casify_region): Remove var that is set but not used.
3221
a4db5dfe
PE
3222 * dired.c (file_name_completion): Remove var that is set but not used.
3223
43aae36e
PE
3224 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3225
2a47c44d 3226 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3227 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3228
a37c69bf
PE
3229 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3230 Check for integer overflow on size calculations.
3231
328ab8e7
PE
3232 * buffer.c (Fprevious_overlay_change): Remove var that is set
3233 but not used.
3234
e5a2a5cb
PE
3235 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3236 Remove vars that are set but not used.
8d84a6eb 3237 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3238 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3239
a60e5f68
PE
3240 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3241
f661cb61 3242 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3243 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3244
f0397f5a
PE
3245 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3246 that are set but not used.
3247
8664db06 3248 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3249 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3250
6abdaa4a
PE
3251 * xselect.c (x_get_local_selection, x_handle_property_notify):
3252 Remove vars that are set but not used.
3253
0ce7538d 3254 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3255 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3256
9ae848fc
PE
3257 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3258 Remove var that is set but not used.
0b918413
PE
3259 (scroll_bar_windows_size): Now size_t, not int.
3260 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3261 Check for overflow.
9ae848fc 3262
a5a62657
PE
3263 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3264 (map_tty_color) [!defined MSDOS]: Likewise.
3265
5c5cdd39
PE
3266 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3267
66ebf983
PE
3268 * coding.c: Remove vars that are set but not used.
3269 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3270 All callers changed.
3271 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3272 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3273 (decode_coding_charset): Remove vars that are set but not used.
3274
1be4d761
PE
3275 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3276 that is set but not used.
3277
47553fa8
PE
3278 * print.c (print_object): Remove var that is set but not used.
3279
1f7196bf 3280 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
3281 The gnulib version avoids calling malloc in the usual case,
3282 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3283 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3284 * filelock.c (current_lock_owner): Likewise.
3285 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3286 * sysdep.c: Include allocator.h, careadlinkat.h.
3287 (emacs_no_realloc_allocator): New static constant.
3288 (emacs_readlink): New function.
fdb61804
PE
3289 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3290 ../lib/careadlinkat.h.
d1fdcab7 3291
f84c17c7
SM
32922011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3293
3294 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3295 first non-nil return value).
3296
ef3862ad
JD
32972011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3298
3299 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3300 if not defined (Bug#8403).
3301
376a7006
JB
33022011-04-02 Juanma Barranquero <lekktu@gmail.com>
3303
3304 * xdisp.c (display_count_lines): Remove parameter `start',
3305 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3306 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3307 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3308 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3309 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3310 and thereabouts. All callers changed.
3311 (get_per_char_metric): Remove parameter `f', unused since
3312 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3313
6ca3801d
JM
33142011-04-02 Jim Meyering <meyering@redhat.com>
3315
3316 do not dereference NULL upon failed strdup
3317 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3318 (ns_get_family): Likewise.
3319
d8e2b5ba
JB
33202011-04-02 Juanma Barranquero <lekktu@gmail.com>
3321
3322 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3323
8c74fcbd
JD
33242011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3325
3326 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3327 later (Bug#8403).
3328
7200d79c
SM
33292011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3330
03408648 3331 Add lexical binding.
7200d79c 3332
03408648
SM
3333 * window.c (Ftemp_output_buffer_show): New fun.
3334 (Fsave_window_excursion):
3335 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3336
3337 * lread.c (lisp_file_lexically_bound_p): New function.
3338 (Fload): Bind Qlexical_binding.
3339 (readevalloop): Remove `evalfun' arg.
3340 Bind Qinternal_interpreter_environment.
3341 (Feval_buffer): Bind Qlexical_binding.
3342 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3343 Mark as dynamic.
3344 (syms_of_lread): Declare `lexical-binding'.
3345
3346 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3347
3348 * keyboard.c (eval_dyn): New fun.
3349 (menu_item_eval_property): Use it.
ca105506
SM
3350
3351 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3352
03408648
SM
3353 * fns.c (concat, mapcar1): Accept byte-code-functions.
3354
3355 * eval.c (Fsetq): Handle lexical vars.
3356 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3357 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3358 (FletX, Flet): Obey lexical binding.
3359 (Fcommandp): Handle closures.
3360 (Feval): New `lexical' arg.
3361 (eval_sub): New function extracted from Feval. Use it almost
3362 everywhere where Feval was used. Look up vars in lexical env.
3363 Handle closures.
3364 (Ffunctionp): Move from subr.el.
3365 (Ffuncall): Handle closures.
3366 (apply_lambda): Remove `eval_flags'.
3367 (funcall_lambda): Handle closures and new byte-code-functions.
3368 (Fspecial_variable_p): New function.
3369 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3370 but without exporting it to Lisp.
23aba0ea 3371
23aba0ea 3372 * doc.c (Fdocumentation, store_function_docstring):
03408648 3373 * data.c (Finteractive_form): Handle closures.
23aba0ea 3374
03408648
SM
3375 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3376 interactive spec.
ba83908c 3377
04f2d78b
CB
3378 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3379 New byte-codes.
03408648
SM
3380 (exec_byte_code): New function extracted from Fbyte_code to handle new
3381 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3382
03408648 3383 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3384
03408648 3385 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3386
e2abce01
JB
33872011-03-31 Juanma Barranquero <lekktu@gmail.com>
3388
3389 * xdisp.c (redisplay_internal): Fix prototype.
3390
63696a73 33912011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3392
63696a73 3393 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3394 (try_scrolling): Use it when setting scroll_limit.
3395 Limit scrolling to 100 screen lines.
63696a73
EZ
3396 (redisplay_window): Even when falling back on "recentering",
3397 position point in the window according to scroll-conservatively,
3398 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3399
3400 (try_scrolling): When point is above the window, allow searching
3401 as far as scroll_max, or one screenful, to compute vertical
3402 distance from PT to the scroll margin position. This prevents
3403 try_scrolling from unnecessarily failing when
3404 scroll-conservatively is set to a value slightly larger than the
3405 window height. Clean up the case of PT below the margin at bottom
3406 of window: scroll_max can no longer be INT_MAX. When aggressive
3407 scrolling is in use, don't let point enter the opposite scroll
3408 margin as result of the scroll.
3409 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3410 threshold of 100 lines for never-recentering scrolling.
3411
e4cc2dfc
JB
34122011-03-31 Juanma Barranquero <lekktu@gmail.com>
3413
3414 * dispextern.h (move_it_by_lines):
3415 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3416 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3417 (message_log_check_duplicate): Remove parameters `prev_bol' and
3418 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3419 (redisplay_internal): Remove parameter `preserve_echo_area',
3420 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3421
3422 * indent.c (Fvertical_motion):
3423 * window.c (window_scroll_pixel_based, Frecenter):
3424 Don't pass `need_y_p' to `move_it_by_lines'.
3425
1c470562
SM
34262011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3427
44f230aa
SM
3428 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3429 steal a few bits to be more compact.
3430 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3431 Remove unneeded casts.
3432
1c470562
SM
3433 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3434
888adce9
ZK
34352011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3436
3437 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3438 binding" message (bug#7967).
3439
f838ed7b
PE
34402011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3441
77861b95
PE
3442 Fix more problems found by GCC 4.6.0's static checks.
3443
de6dbc14
PE
3444 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3445 Remove unused local var.
3446
f838ed7b
PE
3447 * editfns.c (Fmessage_box): Remove unused local var.
3448
792c7b2b
PE
3449 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3450 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3451 Omit unused local vars.
c499e557 3452 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3453 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3454 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3455 Omit unused local var.
3456
ba0165e1
PE
3457 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3458 Don't assume string length fits in int.
32ad8845 3459 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3460 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3461
3c59b4c9
PE
3462 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3463 instead of alloca (Bug#8344).
3464
a3eed478 3465 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3466 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3467
eb4d412d
PE
3468 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3469
1658b401
PE
3470 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3471 concerns.
3472
3473 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3474
3475 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3476
9a2c6e05
PE
3477 * keyboard.c (syms_of_keyboard): Use the same style as later
3478 in this function when indexing through an array. This also
3479 works around GCC bug 48267.
3480
03d0a109
PE
3481 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3482
44f730c8
PE
3483 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3484
fe75f926
PE
3485 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3486 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3487
ffa8c828
PE
3488 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3489 This avoids undefined behavior on integer overflow, and is a bit
3490 more convenient anyway since it is compared to a size_t variable.
3491
c5101a77
PE
3492 Variadic C functions now count arguments with size_t, not int.
3493 This avoids an unnecessary limitation on 64-bit machines, which
3494 caused (substring ...) to crash on large vectors (Bug#8344).
3495 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3496 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3497 All variadic functions and their callers changed accordingly.
c5101a77
PE
3498 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3499 * data.c (arith_driver, float_arith_driver): Likewise.
3500 * editfns.c (general_insert_function): Likewise.
3501 * eval.c (struct backtrace.nargs, interactive_p)
3502 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3503 (funcall_lambda, mark_backtrace): Likewise.
3504 * fns.c (concat): Likewise.
3505 * frame.c (x_set_frame_parameters): Likewise.
3506 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3507 0 if not found, not -1. All callers changed.
3508
dd3f25f7
PE
3509 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3510 (stack_copy_size): Now size_t, not int.
3511 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3512
461c2ab9
JB
35132011-03-28 Juanma Barranquero <lekktu@gmail.com>
3514
3515 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3516 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3517 All callers changed.
3518
3519 * lisp.h (multibyte_char_to_unibyte):
3520 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3521 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3522 * character.h (CHAR_TO_BYTE8):
3523 * cmds.c (internal_self_insert):
3524 * editfns.c (general_insert_function):
3525 * keymap.c (push_key_description):
3526 * search.c (Freplace_match):
3527 * xdisp.c (message_dolog, set_message_1): All callers changed.
3528
f6d62986
SM
35292011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3530
3531 * keyboard.c (safe_run_hook_funcall): New function.
3532 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3533 don't set the hook to nil, but remove the offending function instead.
3534 (Qcommand_hook_internal): Remove, unused.
3535 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3536 Vcommand_hook_internal.
3537
3538 * eval.c (enum run_hooks_condition): Remove.
3539 (funcall_nil, funcall_not): New functions.
3540 (run_hook_with_args): Call each function through a `funcall' argument.
3541 Remove `cond' argument, now redundant.
3542 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3543 (Frun_hook_with_args_until_failure): Adjust accordingly.
3544 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3545
1db5b1ad
JB
35462011-03-28 Juanma Barranquero <lekktu@gmail.com>
3547
3548 * dispextern.h (string_buffer_position): Remove declaration.
3549
3550 * print.c (strout): Remove parameter `multibyte', unused since
3551 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3552
3553 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3554 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3555 All callers changed.
3556
3557 * w32.c (_wsa_errlist): Use braces for struct initializers.
3558
3559 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3560 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3561 All callers changed.
3562 (string_buffer_position): Likewise. Also, make static (it's never
3563 used outside xdisp.c).
3564 (cursor_row_p): Remove parameter `w', unused since
3565 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3566 (decode_mode_spec): Remove parameter `precision', introduced during
3567 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3568 All callers changed.
3569
5ffb62aa
JD
35702011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3571
3572 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3573
461c2ab9 35742011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3575
3576 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3577 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3578 (ns_update_auto_hide_menu_bar): New functions.
3579 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3580 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3581 ns_constrain_all_frames.
3582 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3583 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3584
5c380ffb
JD
35852011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3586
3587 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3588
9af30bdf
GM
35892011-03-27 Glenn Morris <rgm@gnu.org>
3590
3591 * syssignal.h: Replace RETSIGTYPE with void.
3592 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3593 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3594 Replace SIGTYPE with void everywhere.
3595 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3596 * s/template.h (SIGTYPE): Remove commented out definition.
3597
e2abce01
JB
35982011-03-26 Eli Zaretskii <eliz@gnu.org>
3599
3600 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3601 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3602
f868cd8a
JB
36032011-03-26 Juanma Barranquero <lekktu@gmail.com>
3604
59eb0929
JB
3605 * w32.c (read_unc_volume): Use parameter `henum', instead of
3606 global variable `wget_enum_handle'.
3607
3608 * keymap.c (describe_vector): Remove parameters `indices' and
3609 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3610 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3611
f868cd8a
JB
3612 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3613
3614 * keyboard.c (timer_check): Remove parameter `do_it_now',
3615 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3616 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3617 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3618
3619 * keyboard.c (read_char):
3620 * w32menu.c (w32_menu_display_help):
3621 * xmenu.c (show_help_event, menu_help_callback):
3622 Adjust calls to `show_help_echo'.
3623
3624 * gtkutil.c (xg_maybe_add_timer):
3625 * keyboard.c (readable_events):
3626 * process.c (wait_reading_process_output):
3627 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3628
3629 * insdel.c (adjust_markers_gap_motion):
3630 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3631 (gap_left, gap_right): Don't call it.
3632
2ecf6fdb
CY
36332011-03-25 Chong Yidong <cyd@stupidchicken.com>
3634
3635 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3636 incurred during fontification.
3637
6b1f9ba4
JB
36382011-03-25 Juanma Barranquero <lekktu@gmail.com>
3639
3640 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3641 (DEFVAR_PER_BUFFER): Don't pass it.
3642
3643 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3644 (scrolling_window): Don't pass it.
3645
0f4a96b5
JB
36462011-03-25 Juanma Barranquero <lekktu@gmail.com>
3647
3648 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3649
3650 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3651 and `suffix'.
3652 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3653 of variables specific to SELinux and computation of `encoded_absname'.
3654
3655 * image.c (XPutPixel): Remove unused variable `height'.
3656
3657 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3658
3659 * unexw32.c (get_section_info): Remove unused variable `section'.
3660
3661 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3662 (system_process_attributes): Remove unused variable `sess'.
3663 (sys_read): Remove unused variable `err'.
3664
3665 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3666 (w32_wnd_proc): Remove unused variable `isdead'.
3667 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3668 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3669 (x_create_tip_frame): Remove unused variable `tem'.
3670
3671 * w32inevt.c (w32_console_read_socket):
3672 Remove unused variable `no_events'.
3673
3674 * w32term.c (x_draw_composite_glyph_string_foreground):
3675 Remove unused variable `width'.
3676
1149507c
JB
36772011-03-24 Juanma Barranquero <lekktu@gmail.com>
3678
3679 * w32term.c (x_set_glyph_string_clipping):
3680 Don't pass uninitialized region to CombineRgn.
3681
9c88f339
JB
36822011-03-23 Juanma Barranquero <lekktu@gmail.com>
3683
3684 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3685 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3686 (Fx_close_connection): Remove unused variable `i'.
3687
3688 * w32font.c (w32font_draw): Return number of glyphs.
3689 (w32font_open_internal): Remove unused variable `i'.
3690 (w32font_driver): Add missing initializer.
3691
3692 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3693 (fill_in_menu): Remove unused variable `items_added'.
3694
3695 * w32term.c (last_mouse_press_frame): Remove static global variable.
3696 (w32_clip_to_row): Remove unused variable `f'.
3697 (x_delete_terminal): Remove unused variable `i'.
3698
3699 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3700 (NOTHING): Remove unused static global variable.
3701 (uniscribe_check_otf): Remove unused variable `table'.
3702 (uniscribe_font_driver): Add missing initializers.
3703
dee091a3
JD
37042011-03-23 Julien Danjou <julien@danjou.info>
3705
3706 * term.c (Fsuspend_tty, Fresume_tty):
3707 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3708 * window.c (temp_output_buffer_show):
3709 * insdel.c (signal_before_change):
3710 * frame.c (Fhandle_switch_frame):
3711 * fileio.c (Fdo_auto_save):
3712 * emacs.c (Fkill_emacs):
3713 * editfns.c (save_excursion_restore):
3714 * cmds.c (internal_self_insert):
3715 * callint.c (Fcall_interactively):
3716 * buffer.c (Fkill_all_local_variables):
3717 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3718 Use Frun_hooks.
0f4a96b5 3719 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3720 unconditionnaly since it does the check itself.
3721
2c520ab5 37222011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3723
c9c49752
PE
3724 Fix more problems found by GCC 4.5.2's static checks.
3725
8abc3f12
PE
3726 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3727 the first time through the loop, since we know p0 < p1 then.
3728 This also avoids a gcc -Wstrict-overflow warning.
3729
a2d26660
PE
3730 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3731 leading to a memory leak, possible in functions like
3732 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3733 of objects (Bug#8318).
a2d26660 3734
916c72e9
PE
3735 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3736 that could (at least in theory) be that large.
3737
19ab8a18
PE
3738 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3739 This is less likely to overflow, and avoids undefined behavior if
3740 overflow does occur. All callers changed. Use strtoul to scan
3741 for the unsigned long integer.
b7cbbd6f
PE
3742 (pint2hrstr): Simplify and tune code slightly.
3743 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3744
f0641eff
PE
3745 * scroll.c (do_scrolling): Work around GCC bug 48228.
3746 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3747
7f650bb9
PE
3748 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3749 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3750 (validate_x_resource_name): Simplify count usage.
3751 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3752
37dd57d1
PE
3753 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3754 fail (Bug#8306).
81e56e61 3755
699979fc 3756 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3757
401bf9b4
PE
3758 * process.c (Fmake_network_process): Use socklen_t, not int,
3759 where POSIX says socklen_t is required in portable programs.
3760 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3761 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3762 (Fmake_network_process, server_accept_connection):
3763 (wait_reading_process_output, read_process_output):
3764 Likewise.
3765
b93aacde
PE
3766 * process.c: Rename or move locals to avoid shadowing.
3767 (list_processes_1, Fmake_network_process):
3768 (read_process_output_error_handler, exec_sentinel_error_handler):
3769 Rename or move locals.
4dc343ee 3770 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3771 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3772 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3773 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3774 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3775
af8a867c 3776 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3777 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3778 Include tparam.h instead, since it declares them.
af8a867c
PE
3779 * cm.h (PC): Remove extern decl; tparam.h now does this.
3780 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3781 * terminfo.c: Include tparam.h, to check interfaces.
3782 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3783 (tparam): Adjust signature to match interface in tparam.h;
3784 this removes some undefined behavior. Check that outstring and len
3785 are zero, which they always are with Emacs.
3786 * tparam.h (PC, BC, UP): New extern decls.
3787
0248044d 3788 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3789 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3790
8ff096c1 3791 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3792 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3793 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3794 (ftfont_list): Remove unused local.
49eaafba
PE
3795 (get_adstyle_property, ftfont_pattern_entity):
3796 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3797 Rename locals to avoid shadowing.
8ff096c1 3798
e2be39f6
PE
3799 * xfont.c (xfont_list_family): Mark var as initialized.
3800
c9735e30
PE
3801 * xml.c (make_dom): Now static.
3802
8f5201ae
PE
3803 * composite.c (composition_compute_stop_pos): Rename local to
3804 avoid shadowing.
b246f932
PE
3805 (composition_reseat_it): Remove unused locals.
3806 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3807 (composition_update_it): Mark var as initialized.
11b61122
PE
3808 (find_automatic_composition): Mark vars as initialized,
3809 with a FIXME (Bug#8290).
8f5201ae 3810
760fbc2c
PE
3811 character.h: Rename locals to avoid shadowing.
3812 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3813 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3814 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3815 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3816 to avoid shadowing.
3817
ff08eb85
PE
3818 * textprop.c (property_change_between_p): Remove; unused.
3819
fc7bf025
PE
3820 * intervals.c (interval_start_pos): Now static.
3821
235d7abc
PE
3822 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3823
44f230aa
SM
3824 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3825 Rename locals to avoid shadowing.
3e7d6594 3826
50060332
PE
3827 * sound.c (wav_play, au_play, Fplay_sound_internal):
3828 Fix pointer signedness.
d01f234b 3829 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3830 (wav_play): Initialize a variable to 0, to prevent undefined
3831 behavior (Bug#8278).
50060332 3832
c4fc4e30
PE
3833 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3834
918436ed
PE
3835 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3836
c939f91b
PE
3837 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3838 clobbering (Bug#8298).
b9c7f648
PE
3839 * sysdep.c (sys_subshell): Likewise.
3840 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3841
6bd8c144
PE
3842 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3843 This should get cleaned up, so that child_setup has the
3844 same signature on all platforms.
3845
7710357c 3846 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3847 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3848
c59da222
CY
38492011-03-22 Chong Yidong <cyd@stupidchicken.com>
3850
3851 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3852 not to be necessary, and produces flickering.
3853
66b87493
GM
38542011-03-20 Glenn Morris <rgm@gnu.org>
3855
3856 * config.in: Remove file.
3857
45b6f6d5
JB
38582011-03-20 Juanma Barranquero <lekktu@gmail.com>
3859
3860 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3861 are now in src/globals.h.
3862 (syms_of_minibuf): Remove spurious & from previous change.
3863
3ec03f7e
LL
38642011-03-20 Leo <sdl.web@gmail.com>
3865
3866 * minibuf.c (completing-read-function): New variable.
3867 (completing-read-default): Rename from completing-read.
3868 (completing-read): Call completing-read-function.
3869
b14e3e21
CY
38702011-03-19 Juanma Barranquero <lekktu@gmail.com>
3871
3872 * xfaces.c (Fx_load_color_file):
3873 Read color file from absolute filename (bug#8250).
3874
f2b726e6
JB
38752011-03-19 Juanma Barranquero <lekktu@gmail.com>
3876
3877 * makefile.w32-in: Update dependencies.
3878
09f6ff02
EZ
38792011-03-17 Eli Zaretskii <eliz@gnu.org>
3880
3881 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3882
29a6015a
PE
38832011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3884
a3a6c54e
PE
3885 Fix more problems found by GCC 4.5.2's static checks.
3886
b766f867
PE
3887 * process.c (make_serial_process_unwind, send_process_trap):
3888 (sigchld_handler): Now static.
3889
be02381c
PE
3890 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3891 That way, the code declares only the vars that it needs.
3892 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3893 * s/cygwin.h (PTY_ITERATION): Likewise.
3894 * s/darwin.h (PTY_ITERATION): Likewise.
3895 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3896
57048744
PE
3897 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3898 * process.c (allocate_pty): Don't declare stb unless it's needed.
3899
7914961c 3900 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3901 (CONSTANTLIM): Remove; unused.
3902 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3903 Define only if needed.
7914961c 3904
b3967b18
PE
3905 * unexelf.c (unexec): Name an expression,
3906 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3907 Use a different way to cause a compilation error if anyone uses
3908 n rather than nn, a way that does not involve shadowing.
73366a00 3909 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3910
29a6015a
PE
3911 * deps.mk (unexalpha.o): Remove; unused.
3912
43cfc33e 3913 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3914 * unexec.h: New file.
ce701a33
PE
3915 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3916 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3917 Depend on unexec.h.
3918 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3919 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3920 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3921 Change as necessary to match prototype in unexec.h.
ce701a33 3922
01f44d5a
PE
3923 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3924 shadowing.
4f63c6bb 3925 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3926
a6670b0b
PE
3927 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3928 Rename locals to avoid shadowing.
3929
cef2010d 3930 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3931 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3932
d4d7173a
PE
3933 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3934
f08b802a
PE
3935 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3936 warning when compiling print.c.
3937
3ddb0639
PE
3938 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3939 instead of using an uninitialized var.
5ad03b97 3940 (font_sort_entities): Mark var as initialized.
3ddb0639 3941
170a2692
PE
3942 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3943
e663c700
PE
3944 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3945 pointers to constants.
89bc529a 3946 (font_parse_fcname): Remove unused vars.
7b81e2d0 3947 (font_delete_unmatched): Now static.
ea838e10 3948 (font_get_spec): Remove; unused.
13a547c6
PE
3949 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3950 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3951 Rename or move locals to avoid shadowing.
e663c700 3952
2a80c887 3953 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3954 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3955
1384fa33 3956 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3957 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3958
8b2c52e9
PE
3959 * alloc.c (mark_backtrace): Move decl from here ...
3960 * lisp.h: ... to here, so that it can be checked.
3961
475545b5 3962 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3963 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3964 (lisp_indirect_variable): Name an expression,
3965 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3966 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3967
b1349114 3968 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3969 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3970 Use const pointer when appropriate.
b1349114 3971
a2928364
PE
3972 * lisp.h (get_system_name, get_operating_system_release):
3973 Move decls here, to check interfaces.
3974 * process.c (get_operating_system_release): Move decl to lisp.h.
3975 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3976 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3977 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3978 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3979 (Fformat_time_string, Fencode_time, Finsert_char):
3980 (Ftranslate_region_internal, Fformat):
3981 Rename or remove local vars to avoid shadowing.
9710023e 3982 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3983
a415e694
PE
3984 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3985 avoid shadowing.
3986
8ef4622d
PE
3987 * lisp.h (eassert): Check that the argument compiles, even if
3988 ENABLE_CHECKING is not defined.
3989
946f9a5b
PE
3990 * data.c (Findirect_variable): Name an expression, to avoid
3991 gcc -Wbad-function-cast warning.
112396d6 3992 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3993 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3994 (Fmake_variable_buffer_local, Fmake_local_variable):
3995 Mark variables as initialized.
52746918 3996 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3997
e5aab7e7 3998 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3999 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4000 Rename locals to avoid shadowing.
dff45157
PE
4001 (mark_stack): Move local variables into the #ifdef region where
4002 they're used.
7bc26fdb
PE
4003 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4004 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4005 needed otherwise.
4006 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4007 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4008 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4009
e5aab7e7
PE
4010 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4011 avoids undefined behavior in theory.
4012
4da60324
PE
4013 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4014
88043301
PE
4015 Use functions, not macros, for up- and down-casing (Bug#8254).
4016 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4017 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4018 to use the following functions instead of these macros.
4019 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4020 EMACS_INT, since callers assume the returned value fits in int.
4021 (upcase1): Likewise, for UPCASE_TABLE.
4022 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4023 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4024 the race-condition problem in the old DOWNCASE.
88043301 4025
19ed5445
PE
4026 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4027 Rename locals to avoid shadowing.
4028 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4029 (regex_compile, re_search_2, re_match_2_internal):
4030 Remove unused local vars.
952db0d7
PE
4031 (FREE_VAR): Rewrite so as not to use empty "else",
4032 which gcc can warn about.
da053e48 4033 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4034 (RETALLOC_IF): Define only if needed.
4035 (WORDCHAR_P): Likewise. This one is never needed, but is used
4036 only in a comment talking about a compiler bug, so put inside
4037 the #if 0 of that comment.
4038 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4039 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4040 Remove; unused.
19ed5445 4041
1f3561e4 4042 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4043 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4044 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4045
ded6f8f7
PE
4046 * search.c (simple_search): Remove unused var.
4047
dbd37a95
PE
4048 * dired.c (compile_pattern): Move decl from here ...
4049 * lisp.h: ... to here, so that it can be checked.
4050 (struct re_registers): New forward decl.
4051
7e47afad
PE
4052 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4053
85f24f61
PE
4054 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4055 All uses changed.
4056 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4057 Rename locals to avoid shadowing.
5671df8f 4058 (Fvertical_motion): Mark locals as initialized.
85f24f61 4059
181aa2be 4060 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4061 (casify_region): Mark local as initialized.
181aa2be 4062
930d429c
PE
4063 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4064
7082eac6
PE
4065 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4066 New macros, so that the caller can use some names other than
4067 gcpro1, gcpro2, etc.
4068 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4069 of the new macros.
4070 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4071 argument, for consistency with GCPRO2_VAR, etc: it is now the
4072 prefix of the variable, not the variable itself. All uses
4073 changed.
38b2c076
PE
4074 * dired.c (directory_files_internal, file_name_completion):
4075 Rename locals to avoid shadowing.
4076
15206ed9
PE
4077 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4078 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4079 dired.c's scmp function, had undefined behavior.
4080 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4081 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4082 * buffer.h: ... to here, because these macros use current_buffer,
4083 and the new implementation with inline functions needs to have
4084 current_buffer in scope now, rather than later when the macros
4085 are used.
4086 (downcase, upcase1): New static inline functions.
4087 (DOWNCASE, UPCASE1): Reimplement using these functions.
4088 This avoids undefined behavior in expressions like
4089 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4090 from race conditions in accessing the global variables
4091 case_temp1 and case_temp2.
4092 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4093 * lisp.h (case_temp1, case_temp2): Remove their decls.
4094 * character.h (ASCII_CHAR_P): Move from here ...
4095 * lisp.h: ... to here, so that the inline functions mentioned
4096 above can use them.
4097
4a6bea26
PE
4098 * dired.c (directory_files_internal_unwind): Now static.
4099
f14b7e14
PE
4100 * fileio.c (file_name_as_directory, directory_file_name):
4101 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4102 Now static.
2893f146
PE
4103 (file_name_as_directory): Use const pointers when appropriate.
4104 (Fexpand_file_name): Likewise. In particular, newdir might
4105 point at constant storage, so make it a const pointer.
fd4ead52 4106 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4107 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4108 signedness issues.
f839df0c
PE
4109 (Fset_file_times, Finsert_file_contents, auto_save_error):
4110 Rename locals to avoid shadowing.
f14b7e14 4111
5716756e 4112 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4113 (Ftry_completion, Fall_completions): Rename or remove locals
4114 to avoid shadowing.
5716756e 4115
b4c3046a
PE
4116 * marker.c (bytepos_to_charpos): Remove; unused.
4117
b45db522
PE
4118 * lisp.h (verify_bytepos, count_markers): New decls,
4119 so that gcc does not warn that these functions aren't declared.
4120
85876d07
PE
4121 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4122 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4123 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4124 (copy_text): Remove unused local var.
85876d07 4125
03d78a21 4126 * filelock.c (within_one_second): Now static.
b3dd38ab 4127 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4128
5df8f01b
PE
4129 * buffer.c (fix_overlays_before): Mark locals as initialized.
4130 (fix_start_end_in_overlays): Likewise. This function should be
4131 simplified by using pointers-to-pointers, but that's a different
4132 matter.
b1d876f1 4133 (switch_to_buffer_1): Now static.
8f54f30a
PE
4134 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4135 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4136
a70072c9 4137 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4138 Fix pointer signedness issue.
edced198
PE
4139 (sys_subshell): Mark local as volatile if checking for lint,
4140 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4141 (MAXPATHLEN): Define only if needed.
a70072c9 4142
a0977c44
PE
4143 * process.c (serial_open, serial_configure): Move decls from here ...
4144 * systty.h: ... to here, so that they can be checked.
4145
a884fdcc
PE
4146 * fns.c (get_random, seed_random): Move extern decls from here ...
4147 * lisp.h: ... to here, so that they can be checked.
4148
604efe86 4149 * sysdep.c (reset_io): Now static.
b8950c94 4150 (wait_for_termination_signal): Remove; unused.
604efe86 4151
38fc62d9
PE
4152 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4153 (copy_keymap_item, append_key, push_text_char_description):
4154 Now static.
1004a21a 4155 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4156 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4157 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4158 (describe_map_tree):
4159 Rename locals to avoid shadowing.
38fc62d9 4160
2f2650da
PE
4161 * keyboard.c: Declare functions static if they are not used elsewhere.
4162 (echo_char, echo_dash, cmd_error, top_level_2):
4163 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4164 (read_char, kbd_buffer_get_event, make_lispy_position):
4165 (make_lispy_event, make_lispy_movement, apply_modifiers):
4166 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4167 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4168 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4169 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4170 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4171
a053e86c 4172 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4173 (mark_kboards): Move decl here ...
4174 * alloc.c (mark_kboards): ... from here.
a053e86c 4175
4752793e
PE
4176 * lisp.h (force_auto_save_soon): New decl.
4177
74f10ca7 4178 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4179 (DEFINE_DUMMY_FUNCTION): New macro.
4180 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4181 Use it.
c03cd23f
PE
4182 (main): Add casts to avoid warnings
4183 if GCC considers string literals to be constants.
74f10ca7 4184
022e70d4
PE
4185 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4186
59d6fe83
PE
4187 * dbusbind.c: Pointer signedness fixes.
4188 (xd_signature, xd_append_arg, xd_initialize):
4189 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4190 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4191 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4192 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4193
78320123
PE
4194 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4195 if GCC considers string literals to be constants.
49cebcca 4196 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4197
35ac2a97
SM
41982011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4199
fb103ca9
SM
4200 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4201 (print_preprocess, print_object): New macro to fix last change.
4202
35ac2a97
SM
4203 * print.c (print_preprocess): Don't forget font objects.
4204
62973b41
JB
42052011-03-16 Juanma Barranquero <lekktu@gmail.com>
4206
4207 * emacs.c (USAGE3): Doc fixes.
4208
0e48bb22
AS
42092011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4210
4211 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4212 structure.
4213
7684e57b
JB
42142011-03-14 Juanma Barranquero <lekktu@gmail.com>
4215
4216 * lisp.h (VWindow_system, Qfile_name_history):
4217 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4218 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4219 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4220
4221 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4222 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4223
4224 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4225 * w32console.c (detect_input_pending, read_input_pending)
4226 (encode_terminal_code):
4227 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4228 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4229 (w32_system_caret_y, Qfile_name_history):
4230 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4231 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4232 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4233 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4234 * w32proc.c (Qlocal, report_file_error):
4235 * w32term.c (Vwindow_system, updating_frame):
4236 * w32uniscribe.c (initialized, uniscribe_font_driver):
4237 Remove unneeded extern declarations.
4238
2aa46d6c
CY
42392011-03-14 Chong Yidong <cyd@stupidchicken.com>
4240
c96bbc66 4241 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4242
cffc6f3b
CY
42432011-03-13 Chong Yidong <cyd@stupidchicken.com>
4244
4245 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4246 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4247 These macros can no longer be used for assignment.
4248
44f230aa
SM
4249 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4250 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4251 (record_buffer_markers, fetch_buffer_markers): New functions for
4252 recording and fetching special buffer markers.
4253 (set_buffer_internal_1, set_buffer_temp): Use them.
4254
4255 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4256
4257 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4258
4259 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4260 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4261
4262 * xdisp.c (hscroll_window_tree):
4263 (reconsider_clip_changes): Use PT instead of BUF_PT.
4264
d251f04b
EZ
42652011-03-13 Eli Zaretskii <eliz@gnu.org>
4266
4267 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4268 $(EMACS_ROOT)/lib/intprops.h.
4269
f0c77cd1
PE
42702011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4271
3eca4629
PE
4272 Fix more problems found by GCC 4.5.2's static checks.
4273
7c86ee98
PE
4274 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4275 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
4276 (xg_free_frame_widgets): Make it clear that a local variable is
4277 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
4278 (gdk_window_get_screen): Make it clear that this macro is needed
4279 only if USE_GTK_TOOLTIP.
1e5524e7
PE
4280 (int_gtk_range_get_value): New function, which avoids a diagnostic
4281 from gcc -Wbad-function-cast.
4282 (xg_set_toolkit_scroll_bar_thumb): Use it.
4283 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4284 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
4285 (get_utf8_string, xg_get_file_with_chooser):
4286 Rename locals to avoid shadowing.
4287 (create_dialog): Move locals to avoid shadowing.
7c86ee98 4288
41729b81
PE
4289 * xgselect.c (xg_select): Remove unused var.
4290
f0c77cd1
PE
4291 * image.c (four_corners_best): Mark locals as initialized.
4292 (gif_load): Initialize transparent_p to zero (Bug#8238).
4293 Mark another local as initialized.
ec6cf4c6 4294 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 4295
ce0ad53d 4296 * image.c (clear_image_cache): Now static.
d5d5a617 4297 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 4298 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
4299 (x_edge_detection): Remove unnecessary cast that
4300 gcc -Wbad-function-cast diagnoses.
2037898d 4301 (gif_load): Fix pointer signedness.
6ae141d6
PE
4302 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4303 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 4304
33383987 43052011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 4306
d32df629
PE
4307 Improve quality of tests for time stamp overflow.
4308 For example, without this patch (encode-time 0 0 0 1 1
4309 1152921504606846976) returns the obviously-bogus value (-948597
4310 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4311 reports time overflow. See
4312 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
4313 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4314 * editfns.c: Include limits.h and intprops.h.
4315 (TIME_T_MIN, TIME_T_MAX): New macros.
4316 (time_overflow): Move earlier, to before first use.
4317 (hi_time, lo_time): New functions, for an accurate test for
4318 out-of-range times.
4319 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4320 (Fget_internal_run_time): Don't assume time_t fits in int.
4321 (make_time): Use list2 instead of Fcons twice.
4322 (Fdecode_time): More accurate test for out-of-range times.
4323 (check_tm_member): New function.
4324 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4325 (lisp_time_argument): Don't rely on undefined left-shift and
4326 right-shift behavior when checking for time stamp overflow.
8be6f318 4327
fe31d94c
PE
4328 * editfns.c (time_overflow): New function, refactoring common code.
4329 (Fformat_time_string, Fdecode_time, Fencode_time):
4330 (Fcurrent_time_string): Use it.
4331
8be6f318
PE
4332 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4333 * dired.c (make_time): Move to ...
4334 * editfns.c (make_time): ... here.
4335 * systime.h: Note the move.
4336
09d9db2c 43372011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4338
126bc0dc
YM
4339 * fringe.c (update_window_fringes): Remove unused variables.
4340
c47cbdfd
YM
4341 * unexmacosx.c (copy_data_segment): Also copy __got section.
4342 (Bug#8223)
4343
7ac80be9
EZ
43442011-03-12 Eli Zaretskii <eliz@gnu.org>
4345
c96bbc66 4346 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4347 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4348 Constify `char *' arguments and their references according to
4349 prototypes in tparam.h.
4350
ecb0f94d 4351 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4352
7ac80be9
EZ
4353 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4354 Adapt all references accordingly.
4355
4356 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4357
ef1fd07e
TT
43582011-03-11 Tom Tromey <tromey@redhat.com>
4359
4360 * buffer.c (syms_of_buffer): Remove obsolete comment.
4361
7ef4b50c
EZ
43622011-03-11 Eli Zaretskii <eliz@gnu.org>
4363
4364 * termhooks.h (encode_terminal_code): Declare prototype.
4365
4366 * msdos.c (encode_terminal_code): Don't declare prototype.
4367
4368 * term.c (encode_terminal_code): Now external again, used by
4369 w32console.c and msdos.c.
4370
44f230aa
SM
4371 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4372 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4373
4b1ec863 43742011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4375
1714f52b 4376 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4377
4b1ec863
PE
4378 * fringe.c (update_window_fringes): Mark locals as initialized
4379 (Bug#8227).
4380 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4381
524c7aa6
PE
4382 * alloc.c (mark_fringe_data): Move decl from here ...
4383 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4384 to check its interface.
4385 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4386
a5c0af81 4387 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4388 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4389 (fontset_font): Mark local as initialized.
a9a06e0b 4390 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4391
b4716021
PE
4392 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4393
811e9bac 4394 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4395 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4396 (x_own_selection, Fx_disown_selection_internal): Rename locals
4397 to avoid shadowing.
4398 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4399
7e3ab302
PE
4400 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4401 so that the caller can use some name other than gcpro1.
4402 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4403 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4404 (Fx_backspace_delete_keys_p):
4405 Use them to avoid shadowing, and rename vars to avoid shadowing.
4406 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4407 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4408 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4409 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4410 Remove unused locals.
7e3ab302
PE
4411 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4412 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4413 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4414 macros.
f78faa98 4415
e2b13473
PE
4416 * xterm.h (x_mouse_leave): New decl.
4417
77f23912
PE
4418 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4419 Remove unused functions.
cdf4ba58
PE
4420 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4421 (x_calc_absolute_position): Now static.
7411c686 4422 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4423 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4424 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4425 unless they are used.
38d0b34a
PE
4426 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4427 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4428 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4429 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4430 (x_error_catcher, x_connection_closed, x_error_handler):
4431 (x_error_quitter, xembed_send_message, x_iconify_frame):
4432 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4433 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4434 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4435
44f230aa
SM
4436 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4437 Rename or move locals to avoid shadowing.
6b463e58 4438 (tty_defined_color, merge_face_heights): Now static.
5967d051 4439 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4440 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4441 does not deduce is never used uninitialized.
73719eba
PE
4442 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4443 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4444
426994c3 4445 * terminal.c (store_terminal_param): Now static.
5489860b 4446
032f1620 4447 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4448 (set_frame_menubar): Remove unused local.
d4323972 4449 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4450 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4451 since they might point to immutable storage.
281585b0
PE
4452 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4453 since it's unused otherwise.
032f1620 4454
367c19e5 4455 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4456 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4457 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4458 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4459 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4460 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4461 does not deduce are never used uninitialized.
70739cbe 4462
07b48fa9
PE
4463 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4464
8868a238 4465 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4466 * window.c (window_loop, size_window):
4467 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4468
7e5cf297 4469 * window.c (display_buffer): Now static.
d6550a9f
PE
4470 (size_window): Mark variables that gcc -Wuninitialized
4471 does not deduce are never used uninitialized.
a586633d
PE
4472 * window.h (check_all_windows): New decl, to forestall
4473 gcc -Wmissing-prototypes diagnostic.
5b555da1 4474 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4475
f6095868
PE
4476 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4477 shadowing.
4478 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4479 Include <limits.h>.
4480 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4481 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4482 (load_charset_map): Mark variables that gcc -Wuninitialized
4483 does not deduce are never used uninitialized.
53df7c11 4484 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4485
f38b440c
PE
4486 * coding.c (coding_set_source, coding_set_destination):
4487 Use "else { /* comment */ }" rather than "else /* comment */;"
4488 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4489 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4490 a block, when the outer 'i' will do.
4491 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4492 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4493 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4494 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4495 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4496 Rename locals to avoid shadowing.
4497 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4498 * coding.c (emacs_mule_char, encode_invocation_designation):
4499 Now static, since they're not used elsewhere.
413bb2db 4500 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4501 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4502 (decode_coding_emacs_mule): Mark variables that gcc
4503 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4504 (detect_coding_iso_2022): Initialize a local variable that might
4505 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4506 this initialization is needed. (Bug#8211)
5f58e762
PE
4507 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4508 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4509 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4510 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4511 Remove unused macros.
f38b440c 4512
232b38b9 4513 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4514 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4515 * character.c (string_count_byte8): Likewise.
232b38b9 4516
fb90da1b
PE
4517 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4518 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4519
fb93dbc2
PE
4520 * chartab.c (copy_sub_char_table): Now static, since it's not used
4521 elsewhere.
5c156ace
PE
4522 (sub_char_table_ref_and_range, char_table_ref_and_range):
4523 Rename locals to avoid shadowing.
bbcd0949 4524 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4525
7d3b3862 4526 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4527 (BIDI_BOB): Remove unused macro.
7d3b3862 4528
6be7d3da
PE
4529 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4530 deduce are never used uninitialized.
c2ed9c8b 4531 * term.c (encode_terminal_code): Likewise.
6be7d3da 4532
75f8807f 4533 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4534
50938595
PE
4535 * tparam.h: New file.
4536 * term.c, tparam.h: Include it.
4537 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4538 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4539 Move these decls to tparam.h, and make them agree with what
4540 is actually in tparam.c. The previous trick of using incompatible
4541 decls in different modules does not conform to the C standard.
4542 All callers of tparam changed to use tparam's actual API.
4543 * tparam.c (tparam1, tparam, tgoto):
4544 Use const pointers where appropriate.
4545
fbceeba2
PE
4546 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4547 * cm.h (struct cm): Likewise.
4548 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4549 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4550 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4551 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4552 (turn_on_face, init_tty): Likewise.
4553 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4554
7f3f1250
PE
4555 * term.c (term_mouse_position): Rename local to avoid shadowing.
4556
e6ca6543
PE
4557 * alloc.c (mark_ttys): Move decl from here ...
4558 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4559
c40f8d15
AS
45602011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4561
4562 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4563
cfe0661d
JB
45642011-03-09 Juanma Barranquero <lekktu@gmail.com>
4565
4566 * search.c (compile_pattern_1): Remove argument regp, unused since
4567 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4568 (compile_pattern): Don't pass it.
4569
0afb4571
J
45702011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4571
4572 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4573 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4574 for ! HAVE_GTK3.
4575 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4576
4577 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4578
4579 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4580 gdk_window_get_screen, gdk_window_get_geometry,
4581 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4582 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4583 (xg_get_pixbuf_from_pixmap): New function.
4584 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4585 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4586 Call xg_get_pixbuf_from_pixmap instead of
4587 gdk_pixbuf_get_from_drawable.
4588 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4589 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4590 (xg_check_special_colors): Use GtkStyleContext and its functions
4591 for HAVE_GTK3.
4592 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4593 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4594 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4595 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4596 Call gtk_widget_get_preferred_size.
0afb4571
J
4597 (xg_frame_resized): gdk_window_get_geometry only takes 5
4598 parameters.
44f230aa
SM
4599 (xg_win_to_widget, xg_event_is_for_menubar):
4600 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4601 (xg_set_widget_bg): New function.
4602 (delete_cb): New function.
895009e1 4603 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4604 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4605 (xg_set_background_color): Call xg_set_widget_bg.
4606 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4607 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4608 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4609 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4610 if ! HAVE_GTK3.
4611 (update_frame_tool_bar): Call gtk_widget_hide.
4612 (xg_initialize): Use GDK_KEY_g.
4613
4614 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4615 if ! HAVE_GTK3
4616 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4617
4618 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4619 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4620 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4621
1c2cc4ef
JB
46222011-03-08 Juanma Barranquero <lekktu@gmail.com>
4623
4624 * w32xfns.c (select_palette): Check success of RealizePalette against
4625 GDI_ERROR, not zero.
4626
33383987 4627See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4628
4629;; Local Variables:
4630;; coding: utf-8
aac0c6e3
MR
4631;; End:
4632
33383987 4633 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4634
4635 This file is part of GNU Emacs.
4636
4637 GNU Emacs is free software: you can redistribute it and/or modify
4638 it under the terms of the GNU General Public License as published by
4639 the Free Software Foundation, either version 3 of the License, or
4640 (at your option) any later version.
4641
4642 GNU Emacs is distributed in the hope that it will be useful,
4643 but WITHOUT ANY WARRANTY; without even the implied warranty of
4644 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4645 GNU General Public License for more details.
4646
4647 You should have received a copy of the GNU General Public License
4648 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.