Trivial re-ordering and comment updating
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c43fb4c3
GM
12012-07-11 Glenn Morris <rgm@gnu.org>
2
3 * s/darwin.h, s/gnu-linux.h, s/template.h:
4 Move INTERRUPT_INPUT to configure.
5
e8df9267
DA
62012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
7
8 Minor adjustments to interning code.
9 * lisp.h (intern, intern_c_string): Redefine as static inline
10 wrappers for intern_1 and intern_c_string_1, respectively.
11 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
12 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
13 Vobarray checking.
e8df9267
DA
14 * font.c (font_intern_prop): Likewise. Adjust comment.
15 * w32font.c (intern_font_name): Likewise.
16
34348bd4
AS
172012-07-11 Andreas Schwab <schwab@linux-m68k.org>
18
d96a1e0c
AS
19 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
20
34348bd4
AS
21 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
22 of Fcar/Fcdr if possible.
23 * font.c (check_otf_features): Likewise.
24 * fontset.c (Fnew_fontset): Likewise.
25 * gnutls.c (Fgnutls_boot): Likewise.
26 * minibuf.c (read_minibuf): Likewise.
27 * msdos.c (IT_set_frame_parameters): Likewise.
28 * xmenu.c (Fx_popup_dialog): Likewise.
29 * w32menu.c (Fx_popup_dialog): Likewise.
30
c8add24e
GM
312012-07-11 Glenn Morris <rgm@gnu.org>
32
4b575b3c
GM
33 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
34 since nothing has defined it on these platforms.
35
09f4e3b0
GM
36 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
37 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
38
172bedef
GM
39 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
40 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
41 Move CLASH_DETECTION to configure.
42
249685df
GM
43 * s/gnu.h: Remove file, which is now empty.
44
c8add24e
GM
45 * s/gnu.h, s/gnu-linux.h:
46 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
47
b41253a3
JW
482012-07-11 John Wiegley <johnw@newartisans.com>
49
50 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
51 function attribute, so we only use it if it exists in the
52 compiler.
53
d923b542
DA
542012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
55
56 Avoid call to strlen in fast_c_string_match_ignore_case.
57 * search.c (fast_c_string_match_ignore_case): Change to use
58 length argument. Adjust users accordingly.
59 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
60
5ebbef1d
PE
612012-07-11 Paul Eggert <eggert@cs.ucla.edu>
62
bb352260
PE
63 Assume mkdir, rmdir.
64 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
65 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
66
57054ddd
PE
67 Assume rename.
68 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
69
b747d3f7
PE
70 Assume perror.
71 * s/hpux10-20.h (HAVE_PERROR): Remove.
72 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
73 Remove dummy definition, as this problem was obsolete long ago.
74
5ebbef1d
PE
75 Assume strerror.
76 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
77
984e7f30
DA
782012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
79
80 Avoid calls to strlen in font processing functions.
81 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 82 (font_open_by_name): Change to use length argument. Adjust
984e7f30 83 users accordingly.
d923b542
DA
84 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
85 Adjust prototypes.
86 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
87 Change to return ptrdiff_t.
984e7f30
DA
88 (xfont_list_pattern, xfont_match): Use length returned by
89 xfont_decode_coding_xlfd.
90 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
91
20e94fdd
GM
922012-07-11 Glenn Morris <rgm@gnu.org>
93
9d596af3
GM
94 * s/darwin.h, s/freebsd.h, s/netbsd.h:
95 Move DONT_REOPEN_PTY to configure.
96
20e94fdd
GM
97 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
98 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
99
e99a530f
PE
1002012-07-10 Paul Eggert <eggert@cs.ucla.edu>
101
22ffb973
PE
102 Remove "#define unix" that is no longer needed (Bug#11905).
103 * s/aix4-2.h (unix): Remove; no longer needed.
104
e9a9ae03
PE
105 EMACS_TIME simplification (Bug#11875).
106 This replaces macros (which typically do not work in GDB)
107 with functions, typedefs and enums, making the code easier to debug.
108 The functional style also makes code easier to read and maintain.
109 * systime.h: Include <sys/time.h> on all hosts, not just if
110 WINDOWSNT, since 'struct timeval' is needed in general.
111 (EMACS_TIME): Now a typedef, not a macro.
112 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
113 not macros.
114 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
115 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
116 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
117 (EMACS_TIME_LE): Now functions, not macros.
118 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
119 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
120 which are not functions. All uses rewritten to use:
121 (make_emacs_time): New function.
122 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
123 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
124 not functions. All uses rewritten to use the following, respectively:
125 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
126 (add_emacs_time, sub_emacs_time): New functions.
127 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
128 * fileio.c (Fcopy_file):
129 * xterm.c (XTflash): Get the current time closer to when it's used.
130 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
131
ffacb126
PE
132 * bytecode.c (targets): Suppress -Woverride-init warnings.
133
e99a530f
PE
134 Simplify by avoiding confusing use of strncpy etc.
135 * doc.c (Fsnarf_documentation):
136 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
137 * frame.c (Fmake_terminal_frame):
138 * gtkutil.c (get_utf8_string):
139 * lread.c (openp):
140 * nsmenu.m (ns_update_menubar):
141 * regex.c (regerror):
142 Prefer memcpy to strncpy and strncat when either will do.
143 * fileio.c (Fsubstitute_in_file_name):
144 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
145 (menu_separator_name_p):
146 * nsmenu.m (ns_update_menubar):
147 Prefer memcmp to strncmp when either will do.
148 * nsterm.m: Include <ftoastr.h>.
149 (ns_get_color):
150 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
151 Prefer snprintf to strncpy.
152 * nsterm.m (ns_term_init):
153 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
154 * nsterm.m (ns_term_init):
155 Avoid the need for strncpy, by using build_string or
156 make_unibyte_string directly. Use dtoastr, not snprintf.
157 * process.c (Fmake_network_process): Diagnose service names that
158 are too long, rather than silently truncating them or creating
159 non-null-terminated names.
160 (Fnetwork_interface_info): Likewise, for interface names.
161 * sysdep.c (system_process_attributes) [GNU_LINUX]:
162 Prefer sprintf to strncat.
163 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
164 Prefer vsnprintf to vsprintf + strncpy.
165
c59592b3
GM
1662012-07-10 Glenn Morris <rgm@gnu.org>
167
168 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
169 Clarify fallback case.
170
7d7bbefd
DA
1712012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
172
173 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
174 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
175 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 176 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
177 where argument type is known to be a Lisp_Cons.
178
3a4c8000
TT
1792012-07-10 Tom Tromey <tromey@redhat.com>
180
181 * bytecode.c (BYTE_CODE_THREADED): New macro.
182 (BYTE_CODES): New macro. Replaces all old byte-code defines.
183 (enum byte_code_op): New type.
184 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
185 (exec_byte_code): Use them. Use token threading when applicable.
186
2a0213a6
DA
1872012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
188
189 Optimize pure C strings initialization.
190 * lisp.h (make_pure_string): Fix prototype.
191 (build_pure_c_string): New function, defined as static inline. This
192 provides a better opportunity to optimize away calls to strlen when
193 the function is called with compile-time constant argument.
194 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
195 argument, adjust users accordingly. Use build_pure_c_string where
196 appropriate.
197 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
198 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
199 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
200
cb1caeaf
DA
2012012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
202
203 Avoid calls to strlen in miscellaneous functions.
204 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
205 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
206 * lread.c (openp): Likewise.
207
c293e30c
DA
2082012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
209
210 Avoid calls to strlen in path processing functions.
211 * fileio.c (file_name_as_directory): Add comment. Change to add
212 srclen argument and return the length of result. Adjust users
213 accordingly.
214 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 215 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
216 users accordingly.
217 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
218
9e059e3f
GM
2192012-07-10 Glenn Morris <rgm@gnu.org>
220
d02eb359
GM
221 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
222 Move PENDING_OUTPUT_COUNT definition to configure.
223
882cf227
GM
224 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
225 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
226 * s/gnu.h (DATA_START): Move definitions to configure.
227
af6e839f
GM
228 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
229 We include usg5-4-common.h, which defines them both.
230
40289a12
GM
231 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
232 O_RDONLY already includes it).
233
9e059e3f
GM
234 Stop ns builds setting the EMACSLOADPATH environment variable.
235 * nsterm.m (ns_load_path): Rename from ns_init_paths.
236 Now it does not set EMACSLOADPATH, just returns the load-path string.
237 * nsterm.h: Update accordingly.
238 * lread.c [HAVE_NS]: Include nsterm.h.
239 (init_lread) [HAVE_NS]: Use ns_load_path.
240 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
241
7c4e8ec0
GM
2422012-07-09 Glenn Morris <rgm@gnu.org>
243
d4f600ff
GM
244 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
245 since the included bsd-common.h does so.
246
cbb31951
GM
247 Stop ns builds setting the EMACSPATH environment variable.
248 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
249 (ns_init_paths): Do not set EMACSPATH.
250 * nsterm.h (ns_exec_path): Add it.
251 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
252 Use ns_exec_path.
253
7c4e8ec0
GM
254 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
255
26bccfae
PE
2562012-07-09 Paul Eggert <eggert@cs.ucla.edu>
257
a0bee46f
PE
258 * process.c (wait_reading_process_output): 'waitchannels' was unset
259 when read_kbd || !NILP (wait_for_cell); fix this.
260
5994c183
PE
261 Add GCC-style 'const' attribute to functions that can use it.
262 * character.h (char_resolve_modifier_mask):
263 * keyboard.h (make_ctrl_char):
264 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
265 (init_character_once, next_almost_prime, init_fns, init_image)
266 (flush_pending_output, init_sound):
267 * mem-limits.h (start_of_data):
268 * menu.h (finish_menu_items):
269 Add ATTRIBUTE_CONST.
270 * emacs.c (DEFINE_DUMMY_FUNCTION):
271 Declare the dummy function with ATTRIBUTE_CONST.
272 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
273 Add decls with ATTRIBUTE_CONST.
274
26bccfae
PE
275 Minor improvements to make_formatted_string.
276 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
277 where int is good enough, as vsprintf returns an int.
278 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
279
a8290ec3
DA
2802012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
281
282 Use make_formatted_string to avoid double length calculation.
283 * lisp.h (make_formatted_string): New prototype.
284 * alloc.c (make_formatted_string): New function.
285 * buffer.c (Fgenerate_new_buffer_name): Use it.
286 * dbus.c (syms_of_dbusbind): Likewise.
287 * editfns.c (Fcurrent_time_zone): Likewise.
288 * filelock.c (get_boot_time): Likewise.
289 * frame.c (make_terminal_frame, set_term_frame_name)
290 (x_report_frame_params): Likewise.
291 * image.c (gs_load): Likewise.
292 * minibuf.c (get_minibuffer): Likewise.
293 * msdos.c (dos_set_window_size): Likewise.
294 * process.c (make_process): Likewise.
295 * xdisp.c (ensure_echo_area_buffers): Likewise.
296 * xsettings.c (apply_xft_settings): Likewise.
297
d01ba2f1
GM
2982012-07-09 Glenn Morris <rgm@gnu.org>
299
300 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
301 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
302 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
303 * nsterm.h (ns_etc_directory): Add it.
304 * callproc.c [HAVE_NS]: Include nsterm.h.
305 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
306
f1f924b6
DA
3072012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
308
309 Move marker debugging code under MARKER_DEBUG.
310 * marker.c (MARKER_DEBUG): Move marker debugging code under
311 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
312 for bootstrap with --enable-checking (~3x slowdown reported
313 by Juanma Barranquero <lekktu@gmail.com>).
314 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
315
ab531b66
PE
3162012-07-08 Paul Eggert <eggert@cs.ucla.edu>
317
318 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
319 See <http://bugs.gnu.org/11825#29>.
320
c4b3bc8a
EZ
3212012-07-08 Eli Zaretskii <eliz@gnu.org>
322
323 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
324 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
325 (display_line): Add commentary about displaying truncation glyphs
326 on GUI frames.
327 (produce_special_glyphs): Move here from term.c.
328
329 * term.c (produce_special_glyphs): Move to xdisp.c.
330
331 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
332 section.
c4b3bc8a 333
b676b881
AS
3342012-07-07 Andreas Schwab <schwab@linux-m68k.org>
335
f17c5273
AS
336 * xdisp.c (display_line): Avoid warning about implicit declaration
337 of FRAME_FONT.
338
298819b9
AS
339 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
340
b676b881
AS
341 * lisp.h: Remove empty conditional.
342
6045c4fd
PE
3432012-07-07 Paul Eggert <eggert@cs.ucla.edu>
344
b3350bf9
PE
345 * lread.c (load_path_check): Now static.
346
6045c4fd
PE
347 Fix some minor --with-ns problems found by static checking.
348 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
349 (x_set_font) [!HAVE_X_WINDOWS]:
350 * image.c (xpm_load_image) [HAVE_NS]:
351 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
352 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
353 Remove unused local.
354 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
355 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
356 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
357 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
358 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
359 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
360 Fix pointer signedness problem.
361 * xfaces.c (FRAME_X_FONT_TABLE):
362 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
363
929e7845
GM
3642012-07-07 Glenn Morris <rgm@gnu.org>
365
366 * lread.c (load_path_check): New function, split from init_lread.
367 (init_lread): Reorganize. Motivation:
368 If EMACSLOADPATH is set, check/warn about that rather than the
369 defaults, which we are not going to use. Hence we can remove
370 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
371 Don't warn if site-lisp directories are missing.
372 If not installed, start from a blank load-path, since
373 PATH_LOADSEARCH refers to the eventual installation directories.
374
58dd0aa4
EZ
3752012-07-07 Eli Zaretskii <eliz@gnu.org>
376
377 Support truncation and continuation glyphs on GUI frames, when
378 fringes are disabled. (Bug#11832)
379 * xdisp.c (init_iterator): Get dimensions of truncation and
380 continuation glyphs even if on GUI frames. Adjust
381 it->last_visible_x on GUI frames when the left or right fringes,
382 or both, are absent.
383 (start_display, move_it_in_display_line_to): Handle the case of a
384 GUI frame without a fringe to display continuation or truncation
385 glyphs.
386 (insert_left_trunc_glyphs): Support GUI frames: make sure
387 truncation glyphs overwrite enough glyphs from the current line to
388 have sufficient space in pixels.
389 (display_line): Support truncation and continuation glyphs on GUI
390 frames. If some spare pixels are left on the line after inserting
391 the truncation glyphs, fill that space with a stretch glyph of a
392 suitably computed width.
393
394 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
395 produce_glyphs, to support GUI sessions.
396
31571fd7
PE
3972012-07-07 Paul Eggert <eggert@cs.ucla.edu>
398
5a16b9bc
PE
399 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
400
f3047c75
PE
401 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
402
31571fd7
PE
403 Do not require float-time's arg to fit in time_t (Bug#11825).
404 This works better on hosts where time_t is unsigned, and where
405 float-time is applied to the (negative) difference between two times.
406 * editfns.c (decode_time_components): Last arg is now double *,
407 not int *, and means to store all the result as a double, without
408 worrying about whether the seconds part fits in time_t.
409 All callers changed.
410 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
411 All callers changed.
412 (Ffloat_time): Do not fail merely because the specified time falls
413 outside of time_t range.
414
4516fbef
GM
4152012-07-07 Glenn Morris <rgm@gnu.org>
416
417 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
418 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
419 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
420
07adc2c6
JB
4212012-07-07 Juanma Barranquero <lekktu@gmail.com>
422
423 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
424 Update dependencies.
425
426 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
427
fd573f31
PE
4282012-07-06 Paul Eggert <eggert@cs.ucla.edu>
429
fee5959d
PE
430 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
431 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
432 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
433 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
434 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
435 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
436
fd573f31
PE
437 * xfont.c (compare_font_names): Redo to omit the need for casts.
438
ddadbc0e
AS
4392012-07-06 Andreas Schwab <schwab@linux-m68k.org>
440
fca8d6b6
AS
441 * xfns.c (Fx_change_window_property): Doc fix.
442 * w32fns.c (Fx_change_window_property): Doc fix.
443
ddadbc0e
AS
444 * w32fns.c (Fx_window_property): Accept the same arguments as the
445 X Windows version. Doc fix.
446 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
447
f247498e
JB
4482012-07-06 Juanma Barranquero <lekktu@gmail.com>
449 Eli Zaretskii <eliz@gnu.org>
450
451 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
452 Windows-specific code from nt/config.nt moved here.
453 Obsolete settings removed.
454
216ee680
PE
4552012-07-06 Paul Eggert <eggert@cs.ucla.edu>
456
457 * process.c: Avoid unnecessary calls to gettime.
458 (wait_reading_process_output): Don't get the time of day
459 when gobbling data immediately and not waiting, as there's no need
460 for it in that case. This removes a FIXME.
461
bdd091e4
JD
4622012-07-06 Jan Djärv <jan.h.d@swipnet.se>
463
464 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
465 is defined (Bug#11768).
466
9d44f8ce
DA
4672012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
468
469 Fix marker debugging code.
470 * marker.c (byte_char_debug_check): Do not perform the check
471 if buffer is not multibyte.
090bd7cb
JB
472 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
473 Call byte_char_debug_check with correct arguments.
9d44f8ce 474
90fc4786
DA
4752012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
476
477 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
478 * marker.c (byte_char_debug_check, count_markers):
479 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
480 (byte_debug_flag): Remove.
481 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
482 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
483
7b7ae965
DA
4842012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
485
4e57b342
DA
486 Avoid code repetition in marker-related functions.
487 * marker.c (attach_marker): New function.
488 (Fset_marker, set_marker_restricted, set_marker_both)
489 (set_marker_restricted_both): Use it.
490 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
491 Consistently rename charno to charpos.
492 (marker_position): Add eassert.
493 (marker_byte_position): Convert to eassert.
494
4952012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
496
497 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 498 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 499 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 500
657924ff
DA
5012012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
502
503 Introduce fast path for the widely used marker operation.
504 * alloc.c (build_marker): New function.
505 * lisp.h (build_marker): New prototype.
506 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
507 * composite.c (autocmp_chars): Likewise.
508 * editfns.c (buildmark): Remove.
509 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
510 (save_restriction_save): Use build_marker.
511 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
512 * window.c (save_window_save): Likewise.
513
041a49a6
DA
5142012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
515
516 Do not use Fdelete_overlay in delete_all_overlays
517 to avoid redundant calls to unchain_overlay.
518 * buffer.c (drop_overlay): New function.
519 (delete_all_overlays, Fdelete_overlay): Use it.
520 * minibuf.c (get_minibuffer): Fix comment.
521
7dca65a4
PE
5222012-07-06 Paul Eggert <eggert@cs.ucla.edu>
523
524 Port to OpenBSD 5.1 amd64.
525 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
526 This is needed for OpenBSD, and should be harmless on all BSD systems.
527 Also, include <sys/sysctl.h>, as it should be available on all
528 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
529 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
530 use p_pid member, not kp_proc.pid.
531
8eb876e2
GM
5322012-07-06 Glenn Morris <rgm@gnu.org>
533
534 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
535
38182d90
PE
5362012-07-05 Paul Eggert <eggert@cs.ucla.edu>
537
538 More xmalloc and related cleanup.
539 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
540 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
541 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
542 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
543 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
544 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
545 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
546 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
547 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
548 * xterm.c:
549 Omit needless casts involving void * pointers and allocation.
550 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
551 as the former is more robust if P's type is changed.
552 Prefer xzalloc to xmalloc + memset 0.
553 Simplify malloc-or-realloc to realloc.
554 Don't worry about xmalloc returning a null pointer.
555 Prefer xstrdup to xmalloc + strcpy.
556 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
557 growing it.
558 * keyboard.c (apply_modifiers_uncached): Prefer local array to
559 alloca of a constant.
560
6dd5a677
EZ
5612012-07-05 Eli Zaretskii <eliz@gnu.org>
562
563 * xdisp.c (display_line): Fix horizontal pixel coordinates when
564 hscroll is larger than the line width. Fixes long and futile
565 looping inside extend_face_to_end_of_line (on a TTY) producing
566 glyphs that are not needed and thrown away.
567
6b312f0f
DA
5682012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
569
570 * marker.c (set_marker_restricted_both): Simplify by using
571 clip_to_bounds.
572
f520ef9b
PE
5732012-07-05 Paul Eggert <eggert@cs.ucla.edu>
574
575 * editfns.c (region_limit): Simplify by using clip_to_bounds.
576
383b7c95
JD
5772012-07-05 Jan Djärv <jan.h.d@swipnet.se>
578
579 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
580 not defined (Bug#11768).
581 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
582 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
583 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
584 followed by gtk_box_set_homogeneous (Bug#11768).
585 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
586 (update_theme_scrollbar_width, xg_create_scroll_bar):
587 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
588 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
589 (is_box_type): New function (Bug#11768).
590 (xg_tool_item_stale_p): Call is_box_type.
5293d758 591 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
592 with default display (Bug#11768).
593
d6e7bf45
EZ
5942012-07-05 Eli Zaretskii <eliz@gnu.org>
595
596 * xdisp.c (window_hscroll_limited): New function.
597 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
598 coordinates when window's hscroll is set to insanely large
599 values. (Bug#11857)
600
431391ec
JB
6012012-07-05 Juanma Barranquero <lekktu@gmail.com>
602
603 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
604 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
605
23f86fce
DA
6062012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
607
608 Cleanup xmalloc.
609 * lisp.h (xzalloc): New prototype. Omit needless casts.
610 * alloc.c (xzalloc): New function. Omit needless casts.
611 * charset.c: Omit needless casts. Convert all calls to
612 xmalloc with following memset to xzalloc.
613 * dispnew.c: Likewise.
614 * fringe.c: Likewise.
615 * image.c: Likewise.
616 * sound.c: Likewise.
617 * term.c: Likewise.
618 * w32fns.c: Likewise.
619 * w32font.c: Likewise.
620 * w32term.c: Likewise.
621 * xfaces.c: Likewise.
622 * xfns.c: Likewise.
623 * xterm.c: Likewise.
624 * atimer.c: Omit needless casts.
625 * buffer.c: Likewise.
626 * callproc.c: Likewise.
627 * ccl.c: Likewise.
628 * coding.c: Likewise.
629 * composite.c: Likewise.
630 * doc.c: Likewise.
631 * doprnt.c: Likewise.
632 * editfns.c: Likewise.
633 * emacs.c: Likewise.
634 * eval.c: Likewise.
635 * filelock.c: Likewise.
636 * fns.c: Likewise.
637 * gtkutil.c: Likewise.
638 * keyboard.c: Likewise.
639 * lisp.h: Likewise.
640 * lread.c: Likewise.
641 * minibuf.c: Likewise.
642 * msdos.c: Likewise.
643 * print.c: Likewise.
644 * process.c: Likewise.
645 * region-cache.c: Likewise.
646 * search.c: Likewise.
647 * sysdep.c: Likewise.
648 * termcap.c: Likewise.
649 * terminal.c: Likewise.
650 * tparam.c: Likewise.
651 * w16select.c: Likewise.
652 * w32.c: Likewise.
653 * w32reg.c: Likewise.
654 * w32select.c: Likewise.
655 * w32uniscribe.c: Likewise.
656 * widget.c: Likewise.
657 * xdisp.c: Likewise.
658 * xmenu.c: Likewise.
659 * xrdb.c: Likewise.
660 * xselect.c: Likewise.
661
0497dc44
PE
6622012-07-05 Paul Eggert <eggert@cs.ucla.edu>
663
664 * fileio.c (time_error_value): Check the right error number.
665 Problem reported by Troels Nielsen in
666 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
667
356e7178
PE
6682012-07-04 Paul Eggert <eggert@cs.ucla.edu>
669
4e71fd89
PE
670 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
671 This should be fixed in a better way; see Eli Zaretskii in
672 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
673 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
674
f0941253
PE
675 * fileio.c (time_error_value): Rename from special_mtime.
676 The old name's problems were noted by Eli Zaretskii in
677 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
678
065c9eb4
PE
679 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
680 This variable's comment says Emacs needs at least one GDB-visible
681 symbol of type enum pvec_type, to work around GDB problems.
682 The symbol's value doesn't matter.
683
356e7178
PE
684 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
685 that causes compilation to fail on pre-C99 compilers.
686
95f61aa2
JB
6872012-07-04 Juanma Barranquero <lekktu@gmail.com>
688
689 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
690 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
691
3884d954
DA
6922012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
693
d209e2fb 694 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
695 headers for buffer_defaults and buffer_local_symbols.
696 Reported by Juanma Barranquero <lekktu@gmail.com>.
697
ee28be33
SM
6982012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
699
700 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
701 * lisp.h (enum pvec_type): Use fewer bits.
702 (PSEUDOVECTOR_SIZE_BITS): New constant.
703 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
704 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
705 change in pvec_type.
706 (PSEUDOVECTOR_TYPEP): New macro.
707 (TYPED_PSEUDOVECTORP): Use it.
708 * fns.c (internal_equal): Adapt code to extract pvectype.
709 * emacs.c (gdb_pvec_type): Update type.
710 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
711 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
712 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
713 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
714 (sweep_vectors): Use it. Use local var `total_bytes' instead of
715 abusing vector->header.next.nbytes.
716 (live_vector_p): Use PVEC_TYPE.
717 (mark_object): Adapt code to extract pvectype. Use switch.
718
c7f2cd7f
PE
7192012-07-04 Paul Eggert <eggert@cs.ucla.edu>
720
721 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
722 Tighten new eassert a bit.
723
8ce70ed2
DA
7242012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
725
726 Fix compilation with --enable-gcc-warnings and -O1
727 optimization level.
728 * doprnt.c (doprnt): Change type of tem to int, initialize
729 to avoid compiler warning. Add eassert.
730 * search.c (simple_search): Initialize match_byte to avoid
731 compiler warning. Add eassert.
732
dea7f1e5
PE
7332012-07-04 Paul Eggert <eggert@cs.ucla.edu>
734
24a212eb
PE
735 Avoid weird behavior with large horizontal scrolls.
736 Without this change, for example, large hscroll values would
737 mess up Emacs's display on Fedora 15 x86, presumably due to
738 overflows in int calculations in the display code.
739 Also, if buffers had long lines, Emacs would freeze.
740 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
741 (set_window_hscroll): New function, containing the old guts of
742 Fset_window_hscroll. Return the clipped value.
743 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
744 This avoids the need to check against PTRDIFF_MAX.
745
dea7f1e5
PE
746 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
747
76046526
DA
7482012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
749
750 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
751
39adff0d
PE
7522012-07-04 Paul Eggert <eggert@cs.ucla.edu>
753
63807d47
PE
754 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
755 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
756 since GCC 4.4.6 issues a bogus warning for them.
757
39adff0d
PE
758 Fix bugs in file timestamp newness comparisons.
759 * fileio.c (Ffile_newer_than_file_p):
760 * lread.c (Fload): Use full timestamp resolution of files,
761 not just the 1-second resolution, so that files that are only
762 slightly newer still count as newer.
763 * fileio.c (Ffile_newer_than_file_p): Don't assume file
764 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
765
dbeed9a6
PE
7662012-07-03 Paul Eggert <eggert@cs.ucla.edu>
767
768 * fileio.c: Improve handling of file time marker. (Bug#11852)
769 (special_mtime): New function.
770 (Finsert_file_contents, Fverify_visited_file_modtime):
771 Use it to set special mtime values consistently.
772
636334d6
AS
7732012-07-03 Andreas Schwab <schwab@linux-m68k.org>
774
775 * fileio.c (Finsert_file_contents): Properly handle st_mtime
776 marker for non-existing file. (Bug#11852)
777
e2017fe2
GM
7782012-07-03 Glenn Morris <rgm@gnu.org>
779
780 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
781 and did not make it into globals.h).
782
404dbd37
TT
7832012-07-03 Tom Tromey <tromey@redhat.com>
784
785 * window.c (Fset_window_margins, Fset_window_fringes)
786 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
787 * textprop.c (Fprevious_property_change): No longer static.
788 * syntax.c (Fsyntax_table_p): No longer static.
789 * process.c (Fget_process, Fprocess_datagram_address): No longer
790 static.
791 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
792 * keyboard.c (Fcommand_execute): No longer static.
793 Remove EXFUN.
794 * insdel.c (Fcombine_after_change_execute): No longer static.
795 * image.c (Finit_image_library): No longer static.
796 * fileio.c (Fmake_symbolic_link): No longer static.
797 * eval.c (Ffetch_bytecode): No longer static.
798 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
799 * doc.c (Fdocumentation_property, Fsnarf_documentation):
800 No longer static.
404dbd37
TT
801 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
802 static.
803 * dired.c (Ffile_attributes): No longer static.
804 * composite.c (Fcomposition_get_gstring): No longer static.
805 * callproc.c (Fgetenv_internal): No longer static.
806
807 * ccl.h: Remove EXFUNs.
808 * buffer.h: Remove EXFUNs.
809 * dispextern.h: Remove EXFUNs.
810 * intervals.h: Remove EXFUNs.
811 * fontset.h: Remove EXFUN.
812 * font.h: Remove EXFUNs.
813 * dosfns.c (system_process_attributes): Remove EXFUN.
814 * keymap.h: Remove EXFUNs.
815 * lisp.h: Remove EXFUNs.
816 * w32term.h: Remove EXFUNs.
817 * window.h: Remove EXFUNs.
818 * xsettings.h: Remove EXFUN.
819 * xterm.h: Remove EXFUN.
820
8e4fd1e1
GM
8212012-07-03 Glenn Morris <rgm@gnu.org>
822
823 * lisp.h (Frandom): Make it visible to C.
824 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
825 buffer for invisible buffers. (Bug#1229)
826
ca95b3eb
DA
8272012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
828
829 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
830 values which aren't power of 2.
831 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
832 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
833 accordingly.
834
7555c33f
SM
8352012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
836
837 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
838
839 * alloc.c (mark_object): Revert part of last patch to use `switch'.
840
d12e8f5a
DA
8412012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
842
843 * alloc.c (allocate_vector_block): Remove redundant
844 calls to mallopt if DOUG_LEA_MALLOC is defined.
845 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
846 avoid calls to mallopt if zero_vector is returned.
847
296094c3
DA
8482012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
849
850 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
851 is enabled, avoid dereferencing NULL current_sblock if
852 running undumped.
853
36429c89
DA
8542012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
855
856 Cleanup basic buffer management.
857 * buffer.h (struct buffer): Change layout to use generic vector
858 marking code. Fix some comments. Change type of 'clip_changed'
859 to bitfield. Remove unused #ifndef old.
860 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
861 (GET_OVERLAYS_AT): Fix indentation.
862 (for_each_per_buffer_object_at): New macro.
863 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
864 (Fbuffer_local_variables): Use it.
865 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
866 * alloc.c (allocate_buffer): Adjust to match new layout of
867 struct buffer. Fix comment.
868 (mark_overlay): New function.
869 (mark_buffer): Use it. Use mark_vectorlike to mark normal
870 Lisp area of struct buffer.
871 (mark_object): Use it. Adjust marking of misc objects
872 and related comments.
873
3b3e4cac
PE
8742012-07-02 Paul Eggert <eggert@cs.ucla.edu>
875
876 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
877 wrapper that is not needed because the wrapped code is a no-op (zero
878 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
879 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
880
cf5c0175
DA
8812012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
882
883 * alloc.c (mark_buffer): Simplify. Remove prototype.
884 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 885 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
886 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
887 redundant calls to mark_vectorlike for bool vectors.
888
ca26824c
GM
8892012-06-30 Glenn Morris <rgm@gnu.org>
890
2e4c5312
GM
891 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
892
ca26824c
GM
893 * epaths.in (PATH_SITELOADSEARCH): New.
894 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
895 This is rather than relying on --enable-locallisppath elements
896 having "site-lisp" in their names. (Bug#10208#25, 11658)
897
0d23c240
EZ
8982012-06-30 Eli Zaretskii <eliz@gnu.org>
899
c9240d7a
EZ
900 * w32proc.c (sys_select): Accept and ignore one more argument.
901
902 * w32.c (emacs_gnutls_pull): Call select with one more argument.
903
0d23c240 904 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 905 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
906
907 * sysdep.c: Don't include dos.h and dosfns.h.
908
909 * process.c (sys_select):
910 * msdos.c (sys_select): Accept one more argument and ignore it.
911
912 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
913 adapt data types and code to that.
914
915 * dosfns.c:
916 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
917 which clashes with the gnulib function of the same name.
918
af5a5a98
AS
9192012-06-30 Andreas Schwab <schwab@linux-m68k.org>
920
c5e4379c
AS
921 * font.c (font_style_to_value, font_style_symbolic)
922 (font_prop_validate_style): Add type checks for values in
923 font_style_table.
924
af5a5a98
AS
925 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
926 argument.
927 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
928 uses.
929
8d38f461
EZ
9302012-06-29 Eli Zaretskii <eliz@gnu.org>
931
2e5a6631
EZ
932 * xdisp.c (try_window_id): Undo last change.
933
8d38f461
EZ
934 * w32.c (getwd): Adjust commentary about startup_dir.
935 (init_environment): Always call sys_access, even in non-MSVC
936 builds. Don't chdir to the directory of the Emacs executable.
937 This undoes code from 1997 which was justified by the need to
938 "avoid conflicts when removing and renaming directories". But its
939 downside was that every relative file name was being interpreted
940 relative to the directory of the Emacs executable, which can never
941 be TRT. In particular, it broke sys_access when called with
942 relative file names.
943 (sys_access): Map GetLastError to errno.
944
2af3565e
DA
9452012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
946
947 * window.h (struct window): Change type of 'fringes_outside_margins'
948 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 949 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
950 Adjust comment.
951 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
952 to ptrdiff_t.
953
c8d3a25c 9542012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 955
c8d3a25c
GM
956 * gnutls.c (emacs_gnutls_handshake):
957 Add QUIT to make the loop interruptible.
57570cd3 958
c8d3a25c 9592012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 960
c8d3a25c
GM
961 * charset.c (init_charset): Make lack of etc/charsets fatal.
962
3e984ee8
DA
9632012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
964
965 * editfns.c (region_limit): Fix type mismatch.
966
ef884f23
DA
9672012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
968
969 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
970 undefined. Convert from xassert to eassert.
971 * nsmenu.m: Convert from xassert to eassert.
972 * nsterm.m: Likewise.
973
7d7e0027
SM
9742012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
975
976 * editfns.c (region_limit): Clip to narrowing (bug#11770).
977
aa754e6a
PE
9782012-06-28 Paul Eggert <eggert@cs.ucla.edu>
979
980 Avoid integer overflow on scroll-left and scroll-right.
981 * window.c (HSCROLL_MAX): New macro.
982 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
983 overflow when requested scroll falls outside ptrdiff_t range.
984
80b00b08
DA
9852012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
986
987 * window.h (struct window): Change type of 'hscroll',
988 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
989 'last_modified' and 'last_overlay_modified' to EMACS_INT.
990 Adjust users accordingly.
991 * xdisp.c (try_cursor_movement): Replace type check with eassert.
992 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
993 from EMACS_INT to ptrdiff_t.
994 (make_window): Omit redundant initialization.
995
62b2bcf6
JB
9962012-06-28 Juanma Barranquero <lekktu@gmail.com>
997
998 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
999
45942c7d
DA
10002012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1001
1002 * window.h (struct window): Change type of 'use_time' and
1003 'sequence_number' from Lisp_Object to int.
1004 * frame.c (make_frame): Adjust users accordingly.
1005 * print.c (print_object): Likewise.
1006 * window.c (select_window, Fwindow_use_time, make_parent_window)
1007 (make_window): Likewise.
1008
e509cfa6
DA
10092012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1010
1011 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1012 enabled with --enable-checking=[all,glyphs] configure option.
1013 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1014 adjust comments accordingly.
1015 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1016 undefined, adjust comments accordingly.
1017 * image.c: Likewise.
1018 * scroll.c: Likewise.
1019 * w32fns.c: Likewise.
1020 * w32term.c: Likewise.
1021 * xdisp.c: Likewise.
1022 * xfaces.c: Likewise.
1023 * xfns.c: Likewise.
1024 * xterm.c: Likewise.
1025
a54e2c05
DA
10262012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1027
1028 Generalize run-time debugging checks.
1029 * dispextern.h (XASSERTS): Remove.
1030 * fontset.c (xassert): Remove.
1031 Convert from xassert to eassert.
1032 * alloc.c: Convert from xassert to eassert.
1033 * bidi.c: Likewise.
1034 * dispnew.c: Likewise.
1035 * fns.c: Likewise.
1036 * fringe.c: Likewise.
1037 * ftfont.c: Likewise.
1038 * gtkutil.c: Likewise.
1039 * image.c: Likewise.
1040 * keyboard.c: Likewise.
1041 * menu.c: Likewise.
1042 * process.c: Likewise.
1043 * scroll.c: Likewise.
1044 * sound.c: Likewise.
1045 * term.c: Likewise.
1046 * w32console.c: Likewise.
1047 * w32fns.c: Likewise.
1048 * w32term.c: Likewise.
1049 * window.c: Likewise.
1050 * xdisp.c: Likewise.
1051 * xfaces.c: Likewise.
1052 * xfns.c: Likewise.
1053 * xselect.c: Likewise.
1054 * xterm.c: Likewise.
1055
1ec4b7b2
SM
10562012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1057
1058 * fns.c (maybe_resize_hash_table): Output message when growing the
1059 purify-hashtable.
1060
2014308a
DA
10612012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1062
1063 * alloc.c (allocate_string_data): Remove dead code.
1064 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1065 avoid GCC warning about unused macro.
1066
246155eb
DA
10672012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1068
1069 * alloc.c (allocate_string): Omit intervals initialization.
1070 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1071 as in make_pure_string and make_pure_c_string.
1072
43184b7b
DA
10732012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1074
d209e2fb 1075 * alloc.c (allocate_string): Fix last change.
43184b7b 1076
3fe6dd74
DA
10772012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1078
d209e2fb 1079 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1080 to memset, add explicit initialization where appropriate.
1081
1ba6038a
GM
10822012-06-27 Glenn Morris <rgm@gnu.org>
1083
1084 * lisp.mk (lisp): Remove paths.elc.
1085
c89926a5
CY
10862012-06-27 Chong Yidong <cyd@gnu.org>
1087
1088 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1089
ed6b3510
JW
10902012-06-26 John Wiegley <johnw@newartisans.com>
1091
1ec4b7b2 1092 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1093 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1094
ed6b3510
JW
1095 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1096 when building with Clang.
1097
8edd4a2b
SM
10982012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1099
1100 * eval.c (Fapply): Allow calling it with a single argument.
1101
f6f62d1b
EZ
11022012-06-26 Eli Zaretskii <eliz@gnu.org>
1103
1104 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1105 _stricmp and _strnicmp.
1106 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1107
62efea5e
DA
11082012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1109
1110 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1111 allocated window.
1112 (allocate_process): Likewise for new process.
8edd4a2b 1113 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1114 (allocate_frame): Likewise.
1115 * frame.c (make_frame): Omit redundant initialization.
1116 * window.c (make_parent_window): Use memset.
1117 (make_window): Omit redundant initialization.
1118 * process.c (make_process): Omit redundant initialization.
1119 * terminal.c (create_terminal): Likewise.
1120
42997f4d
DA
11212012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1122
1123 * term.c (delete_tty): Remove redundant call to memset.
1124
1130ecfc
DA
11252012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1126
1127 * alloc.c: Remove build_string.
1128 * lisp.h: Define build_string as static inline. This provides
1129 a better opportunity to optimize away calls to strlen when the
1130 function is called with compile-time constant argument.
1131 * image.c (imagemagick_error): Convert to build_string.
1132 * w32proc.c (sys_spawnve): Likewise.
1133 * xterm.c (x_term_init): Likewise.
1134
cf38a720
PE
11352012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1136
99027bdd
PE
1137 Use sprintf return value instead of invoking strlen on result.
1138 In the old days this wasn't portable, since some sprintf
1139 implementations returned char *. But they died out years ago and
1140 Emacs already assumes sprintf returns int.
1141 Similarly for float_to_string.
1142 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1143 * ccl.c (ccl_driver):
1144 * character.c (string_escape_byte8):
1145 * data.c (Fnumber_to_string):
1146 * doprnt.c (doprnt):
1147 * print.c (print_object):
1148 * xdisp.c (message_dolog):
1149 * xfns.c (syms_of_xfns):
1150 Use sprintf or float_to_string result to avoid need to call strlen.
1151 * data.c (Fnumber_to_string):
1152 Use make_unibyte_string, since the string must be ASCII.
1153 * lisp.h, print.c (float_to_string): Now returns int length.
1154 * term.c (produce_glyphless_glyph):
1155 Use sprintf result rather than recomputing it.
1156
cf38a720
PE
1157 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1158 * Makefile.in (ALL_CFLAGS):
1159 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1160 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1161
3511c784
DA
11622012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1163
0a08eb21 1164 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
1165 strcasecmp if available.
1166 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1167
fb7da12e
AS
11682012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1169
1170 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1171 Avoid comma operator.
1172 * menu.c (push_submenu_start, push_submenu_end)
1173 (push_left_right_boundary, push_menu_pane): Likewise.
1174 * msdos.c (dos_rawgetc): Likewise.
1175
afa2ffd8
DA
11762012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1177
1178 * xfns.c (xic_create_fontsetname): Remove redundant calls
1179 to memset.
1180
b3b4476b
PE
11812012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1182
4495ff38
PE
1183 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1184 sprintf already null-terminates its output.
1185
b3b4476b
PE
1186 * xfns.c (x_window): Remove redundant cast.
1187
b00876c9
DA
11882012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1189
1190 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1191 `const char *' to `char *' to avoid compiler warning.
1192
d188e26b
PE
11932012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1194
885d1d74
PE
1195 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1196 instead of truncating it to 63 (admittedly a generous limit).
1197
d188e26b
PE
1198 * process.c: Fix spelling and caps in comments.
1199
e2f560b1
DN
12002012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1201
e86db54b 1202 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
1203 * sysdep.c (setpgrp): Remove definition, not used in this file.
1204
7583a3a1
JB
12052012-06-24 Juanma Barranquero <lekktu@gmail.com>
1206
1207 * makefile.w32-in: Update dependencies.
1208
696056c2
EZ
12092012-06-24 Eli Zaretskii <eliz@gnu.org>
1210
1211 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1212 (SYSTIME_H): Add nt/inc/sys/time.h.
1213
1214 * systime.h [WINDOWSNT]: Include sys/time.h.
1215
1216 * s/ms-w32.h (struct timespec): Definition moved from
1217 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1218
845ca893
PE
12192012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1220
1221 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1222 * buffer.h (buffer_slot_type_mismatch):
1223 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1224 * eval.c (unwind_to_catch):
1225 * image.c (my_png_error, my_error_exit):
1226 * keyboard.c (quit_throw_to_read_char, user_error)
1227 (Fexit_recursive_edit, Fabort_recursive_edit):
1228 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1229 (wrong_type_argument, buffer_overflow, __executable_start)
1230 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1231 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1232 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1233 (fatal):
1234 (child_setup) [!DOS_NT]:
1235 * lread.c (end_of_file_error, invalid_syntax):
1236 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1237 * puresize.h (pure_write_error):
1238 * search.c (matcher_overflow):
1239 * sound.c (sound_perror, alsa_sound_perror):
1240 * sysdep.c, syssignal.h (croak):
1241 * term.c (maybe_fatal, vfatal):
1242 * textprop.c (text_read_only):
1243 * undo.c (user_error):
1244 * unexmacosx.c (unexec_error):
1245 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1246 Use _Noreturn rather than NO_RETURN.
1247 No need for separate decl merely because of _Noreturn.
1248 * sound.c (sound_warning, parse_sound):
1249 Remove unnecessary forward decls.
1250
f1dd8073
PE
12512012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1252
1253 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1254 * lisp.h (WAIT_READING_MAX): New macro.
1255 * dispnew.c (Fsleep_for, sit_for):
1256 * keyboard.c (kbd_buffer_get_event):
1257 * process.c (Faccept_process_output):
1258 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1259 This improves on the previous patch, which introduced a bug
1260 when time_t is unsigned and as wide as intmax_t.
1261 See <http://bugs.gnu.org/9000#51>.
1262
b82c1755
EZ
12632012-06-23 Eli Zaretskii <eliz@gnu.org>
1264
1265 * dispnew.c (sit_for, Fsleep_for):
1266 * keyboard.c (kbd_buffer_get_event):
1267 * process.c (Faccept_process_output): Avoid compiler warnings when
1268 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1269
ca300656
JB
12702012-06-23 Juanma Barranquero <lekktu@gmail.com>
1271
049ec95b
JB
1272 * makefile.w32-in: Update dependencies.
1273
ca300656
JB
1274 * w32.c (ltime): Add return type and declare static.
1275 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1276
db7b8d06
PE
12772012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1278
1279 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1280 Privately reported by Herbert J. Skuhra.
1281 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1282 All uses changed.
1283 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1284 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1285
0bd8297f
EZ
12862012-06-23 Eli Zaretskii <eliz@gnu.org>
1287
96512555
EZ
1288 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1289 last argument of make_unibyte_string.
1290
0bd8297f
EZ
1291 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1292 language ID in the event parameters.
1293
1294 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1295 event.code, not the obscure "character set ID".
1296
63def6b6
CY
12972012-06-23 Chong Yidong <cyd@gnu.org>
1298
1299 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1300
e8a02204
EZ
13012012-06-23 Eli Zaretskii <eliz@gnu.org>
1302
388cdec0
EZ
1303 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1304 * w32.c (fdutimens): New function.
1305
1306 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1307
1308 * s/ms-w32.h (pselect): Redirect to sys_select.
1309
1310 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1311
e8a02204
EZ
1312 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1313 in the logic of incrementing and decrementing the value of
1314 use_relocatable_buffers.
1315
d054f3fb
PE
13162012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1317
1318 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1319 Privately reported by Herbert J. Skuhra.
1320 [__FreeBSD__]: Remove "*/" typo after "#include".
1321 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1322 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1323 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1324 Don't assume EMACS_TIME and struct timeval are the same type.
1325
d35af63c
PE
13262012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1327
1328 Support higher-resolution time stamps (Bug#9000).
1329 The time stamps are only nanosecond-resolution at the C level,
1330 since that's the best that any real-world system supports now.
1331 But they are picosecond-resolution at the Lisp level, as that's
1332 easy, and leaves room for future OS improvements.
1333
1334 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1335 (LIBES): Use it.
1336
1337 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1338 Don't get current time unless it's needed.
1339
1340 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1341 now provides it if it's absent.
1342 (start_atimer): Port to higher-res time stamps.
1343 Check for time stamp overflow. Don't get current time more
1344 often than is needed.
1345
1346 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1347 Include systime.h, not time.h.
1348 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1349
1350 * dired.c: Include stat-time.h.
1351 (Ffile-attributes): File times now have higher resolution.
1352
1353 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1354 (struct image): Timestamp now has higher resolution.
1355
1356 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1357 has at least microseconds now. All uses removed.
1358 (update_frame, update_single_window, update_window, update_frame_1)
1359 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1360
1361 * editfns.c (time_overflow): Now extern.
1362 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1363 (float-time, Fformat_time_string, Fcurrent_time_string)
1364 (Fcurrent_time_zone): Accept and generate higher-resolution
1365 time stamps.
1366 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1367 (decode_time_components, lisp_seconds_argument): New functions.
1368 (make_time): Now static.
1369 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1370 Report an error if the time is invalid, rather than having the caller
1371 do that.
1372
1373 * fileio.c: Include <stat-time.h>
1374 (Fcopy_file): Copy higher-resolution time stamps.
1375 Prefer to set the time stamp via a file descriptor if that works.
1376 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1377 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1378 (Fvisited_file_modtime, Fset_visited_file_modtime):
1379 Support higher-resolution time stamps.
1380
1381 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1382
1383 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1384
1385 * image.c (prepare_image_for_display, clear_image_cache)
1386 (lookup_image): Port to higer-resolution time stamps.
1387
1388 * keyboard.c (start_polling, bind_polling_period):
1389 Check for time stamp overflow.
1390 (read_char, kbd_buffer_get_event, timer_start_idle)
1391 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1392 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1393 Port to higher-resolution time stamps. Do not assume time_t is signed.
1394 (decode_timer): New function. Timers are now vectors of length 9,
1395 not 8, to accommodate the picosecond component.
1396 (timer_check_2): Use it.
1397
1398 * nsterm.m (select_timeout, timeval_subtract): Remove.
1399 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1400 as they're a bit more accurate and handle overflow better.
1401 (ns_select): Change prototype to be compatible with pselect.
1402 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1403 * nsterm.h (ns_select): Adjust prototype.
1404
1405 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1406 us-resolution time stamps.
1407 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1408
1409 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1410
1411 * lisp.h (time_overflow): New decl.
1412 (wait_reading_process_output): First arg is now intmax_t, not int,
1413 to accommodate larger waits.
1414
1415 * process.h (struct Lisp_Process.read_output_delay):
1416 Now counts nanoseconds, not microseconds.
1417 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1418 EMACS_HAS_USECS.
1419 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1420 (wait_reading_process_output):
1421 Port to ns-resolution time stamps.
1422 (Faccept_process_output, wait_reading_process_output):
1423 Check for time stamp overflow. Do not assume time_t is signed.
1424 (select_wrapper): Remove; we now use pselect.
1425 (Fprocess_attributes): Now generates ns-resolution time stamps.
1426
1427 * sysdep.c: Include utimens.h. Don't include utime.h
1428 or worry about struct utimbuf; gnulib does that for us now.
1429 (gettimeofday): Remove; gnulib provides a substitute.
1430 (make_timeval): New function.
1431 (set_file_times): Now sets ns-resolution time stamps.
1432 New arg FD; all uses changed.
1433 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1434 (system_process_attributes):
1435 Now returns ns-resolution time stamp. All uses changed.
1436 Check for time stamp overflow.
1437
1438 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1439 provides a substitute now.
1440
1441 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1442 since it guarantees struct timespec.
1443 (EMACS_TIME): Now struct timespec, so that we can support
1444 ns-resolution time stamps.
1445 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1446 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1447 (EMACS_USECS): Remove.
1448 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1449 so multiply the arg by 1000 before storing it.
1450 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1451 New macros.
1452 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1453 Port to ns-resolution time stamps.
1454 (EMACS_TIME_NEG_P): Remove; replaced by....
1455 (EMACS_TIME_SIGN): New macro.
1456 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1457 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1458 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1459 (make_timeval, make_lisp_time, decode_time_components): New decls.
1460 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1461 that it mishandled time_t overflow. You can't compare by subtracting!
1462 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1463 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1464
1465 * term.c: Include <sys/time.h>.
1466 (timeval_to_Time): New function, for proper overflow wraparound.
1467 (term_mouse_position, term_mouse_click): Use it.
1468
1469 * undo.c (record_first_change): Support higher-resolution time stamps
1470 in the undo buffer.
1471 (Fprimitive_undo): Use them when restoring time stamps.
1472
1473 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1474 (w32_get_internal_run_time):
1475 Port to higher-resolution Emacs time stamps.
1476 (ltime): Now accepts single 64-bit integer, as that's more convenient
1477 for callers.
1478
1479 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1480
1481 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1482 for compatibility with pselect. Support ns-resolution time stamps.
1483
1484 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1485
1486 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1487 Check for time stamp overflow, and support ns-resolution time stamps.
1488
1489 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1490 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1491 (timeval_subtract): Remove; no longer needed.
1492 (XTflash, XTring_bell, x_wait_for_event):
1493 Port to ns-resolution time stamps. Don't assume time_t is signed.
1494
b6a92dfe
CY
14952012-06-22 Chong Yidong <cyd@gnu.org>
1496
1497 * xdisp.c (x_consider_frame_title): Revert last change.
1498
d251c37c
EZ
14992012-06-22 Eli Zaretskii <eliz@gnu.org>
1500
1501 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1502 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1503 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1504 staticidx goes up to 1597 out of 1600 = 0x640.)
1505
f10deafb
PE
15062012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1507
1508 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1509 Otherwise, the umask might be mistakenly 0 while handling input signals.
1510
ec6de1e2
SM
15112012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1512
1513 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1514
28be1ada
DA
15152012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1516
1517 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1518 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1519 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1520 access to `contents' member of Lisp_Vector objects with AREF and ASET
1521 where appropriate.
1522
c6bf3022
CY
15232012-06-19 Chong Yidong <cyd@gnu.org>
1524
1525 * frame.c (delete_frame): When selecting a frame on a different
1526 text terminal, do not alter the terminal's top-frame.
1527
1528 * xdisp.c (format_mode_line_unwind_data): Record the target
1529 frame's selected window and its terminal's top-frame.
1530 (unwind_format_mode_line): Restore them.
1531 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1532 Callers changed.
1533 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1534 since tty frames can be explicitly named.
1535 (prepare_menu_bars): Likewise.
1536
1537 * term.c (Ftty_top_frame): New function.
1538
defd4196
PE
15392012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1540
1541 Port byte-code-meter to modern targets.
1542 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1543 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1544 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1545 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1546 (METER_1, METER_2): Simplify.
1547
1053a871
SM
15482012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1549
1550 * data.c (Fdefalias): Return `symbol' (bug#11686).
1551
b7e8d081
MR
15522012-06-18 Martin Rudalics <rudalics@gmx.at>
1553
1554 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1555 gets killed during executing of this function (Bug#11665).
1556 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1557 (Vkill_buffer_query_functions): In doc-string say that functions
1558 run by this hook should not change the current buffer.
1559
7ea2b339
PE
15602012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1561
1562 Fix recently-introduced process.c problems found by static checking.
1563 * process.c (write_queue_push, write_queue_pop, send_process):
1564 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1565 (write_queue_pop): Fix pointer signedness problem.
1566 (send_process): Remove unused local.
1567
96a313a1
CY
15682012-06-17 Chong Yidong <cyd@gnu.org>
1569
1570 * xdisp.c (redisplay_internal): No need to redisplay terminal
1571 frames that are not on top.
1572
20ca2e94
TN
15732012-06-17 Troels Nielsen <bn.troels@gmail.com>
1574
1575 * process.c (make_process): Initialize write_queue.
1576 (write_queue_push, write_queue_pop): New functions.
1577 (send_process): Use them to maintain correct ordering of process
1578 writes (Bug#10815).
1579
9a900ca9
PE
15802012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1581
310fbfa8
PE
1582 * lisp.h (eassert): Assume C89 or later.
1583 This removes the need for CHECK.
1584 (CHECK): Remove. Its comments about always evaluating its
1585 argument were confusing, as 'eassert' typically does not evaluate
1586 its argument.
1587
27bb1ca4
PE
1588 * coding.c (produce_chars): Use ptrdiff_t, not int.
1589
9a900ca9
PE
1590 * xterm.c (x_draw_underwave): Check for integer overflow.
1591 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1592
41b7f8bc 15932012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1594
1595 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1596 referenced (Bug#11583).
1597
9b0e3eba
AA
15982012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1599
1600 Implement wave-style variant of underlining.
1601 * dispextern.h (face_underline_type): New enum.
1602 (face): Add field for underline type.
1603 * nsterm.m (ns_draw_underwave): New function.
1604 (ns_draw_text_decoration): Use it.
1605 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1606 New functions.
1607 (x_draw_glyph_string): Use them.
1608 * xfaces.c (Qline, Qwave): New Lisp objects.
1609 (check_lface_attrs, merge_face_ref)
1053a871
SM
1610 (Finternal_set_lisp_face_attribute, realize_x_face):
1611 Handle wave-style underline face attributes.
9b0e3eba
AA
1612 * xterm.c (x_draw_underwave): New function.
1613 (x_draw_glyph_string): Use it.
1614
0fb52f11
JB
16152012-06-16 Juanma Barranquero <lekktu@gmail.com>
1616
1617 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1618 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1619 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1620 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1621 ($(BLD)/w32select.$(O)): Update dependencies.
1622
e5560ff7
AS
16232012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1624
1625 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1626 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1627 * character.c (_fetch_multibyte_char_p): Remove.
1628 * alloc.c: Include "character.h" before "buffer.h".
1629 * bidi.c: Likewise.
1630 * buffer.c: Likewise.
1631 * bytecode.c: Likewise.
1632 * callint.c: Likewise.
1633 * callproc.c: Likewise.
1634 * casefiddle.c: Likewise.
1635 * casetab.c: Likewise.
1636 * category.c: Likewise.
1637 * cmds.c: Likewise.
1638 * coding.c: Likewise.
1639 * composite.c: Likewise.
1640 * dired.c: Likewise.
1641 * dispnew.c: Likewise.
1642 * doc.c: Likewise.
1643 * dosfns.c: Likewise.
1644 * editfns.c: Likewise.
1645 * emacs.c: Likewise.
1646 * fileio.c: Likewise.
1647 * filelock.c: Likewise.
1648 * font.c: Likewise.
1649 * fontset.c: Likewise.
1650 * fringe.c: Likewise.
1651 * indent.c: Likewise.
1652 * insdel.c: Likewise.
1653 * intervals.c: Likewise.
1654 * keyboard.c: Likewise.
1655 * keymap.c: Likewise.
1656 * lread.c: Likewise.
1657 * macros.c: Likewise.
1658 * marker.c: Likewise.
1659 * minibuf.c: Likewise.
1660 * nsfns.m: Likewise.
1661 * nsmenu.m: Likewise.
1662 * print.c: Likewise.
1663 * process.c: Likewise.
1664 * regex.c: Likewise.
1665 * region-cache.c: Likewise.
1666 * search.c: Likewise.
1667 * syntax.c: Likewise.
1668 * term.c: Likewise.
1669 * textprop.c: Likewise.
1670 * undo.c: Likewise.
1671 * unexsol.c: Likewise.
1672 * w16select.c: Likewise.
1673 * w32fns.c: Likewise.
1674 * w32menu.c: Likewise.
1675 * window.c: Likewise.
1676 * xdisp.c: Likewise.
1677 * xfns.c: Likewise.
1678 * xmenu.c: Likewise.
1679 * xml.c: Likewise.
1680 * xselect.c: Likewise.
1681
2f07e6af
EZ
16822012-06-16 Eli Zaretskii <eliz@gnu.org>
1683
1053a871
SM
1684 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1685 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1686 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1687 row.
1688 (handle_face_prop): Use chunk-relative overlay string index when
1689 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1690 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1691 the rightmost. (Bug#11720)
2f07e6af 1692
29b83cec
AS
16932012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1694
1695 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1696 (CATEGORY_MEMBER): Enforce 1/0 value.
1697 * category.c (_temp_category_set): Remove.
1698
4c5501e9
EZ
16992012-06-16 Eli Zaretskii <eliz@gnu.org>
1700
1701 * window.c (Fdelete_other_windows_internal)
1702 (Fdelete_window_internal): Don't access frame's mouse highlight
1703 info of the initial frame. (Bug#11677)
1704
2b570124
PE
17052012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1706
e93864f9
PE
1707 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1708 Assume USE_2_TAGS_FOR_INTS.
1709 (xreload): Adjust $tagmask width to match recent lisp.h change.
1710
2b570124
PE
1711 Simplify lisp.h in minor ways that should not affect code.
1712 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1713 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1714 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1715 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1716 (INTTYPEBITS): New macro, for clarity.
1717 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1718 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1719 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1720 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1721 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1722
81755f69
JB
17232012-06-13 Juanma Barranquero <lekktu@gmail.com>
1724
1725 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1726
16192a57
GM
17272012-06-13 Glenn Morris <rgm@gnu.org>
1728
1729 * s/bsd-common.h (BSD4_3):
1730 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1731
646b5f55
AS
17322012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1733
1734 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1735 instead of union.
1736 (XLI, XIL): Define.
1053a871
SM
1737 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1738 Use them.
1739 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1740 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1741 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1742 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1743 * frame.c (delete_frame): Remove outdated comment.
1744 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1745 USE_LISP_UNION_TYPE.
1746 (Fw32_unregister_hot_key): Likewise.
1747 (Fw32_toggle_lock_key): Likewise.
1748 * w32menu.c (add_menu_item): Likewise.
1749 (w32_menu_display_help): Use XIL instead of checking
1750 USE_LISP_UNION_TYPE.
1751 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1752 (init_heap): Likewise.
1753 * w32term.c (w32_read_socket): Update comment.
1754
1d3823c9
GM
17552012-06-13 Glenn Morris <rgm@gnu.org>
1756
c62ff706
GM
1757 * s/usg5-4-common.h, src/s/unixware.h:
1758 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1759
1d3823c9
GM
1760 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1761
bfe3e0a2
PE
17622012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1763
1764 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1765 * alloc.c (make_number) [!defined make_number]:
1766 Remove, as lisp.h always defines this now.
1767 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1768 (roundup_size): Verify that it is a power of 2.
1769 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1770 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1771 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1772 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1773 USE_LSB_TAG now is always defined to be either 0 or 1.
1774 All uses changed.
1775 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1776 code works fine either way, and efficiency is not a concern here,
1777 as the union type is for debugging, not for production.
1778 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1779 Use an inline function on all platforms when using the union type,
1780 since this is simpler and 'static inline' can be used portably
1781 within Emacs now.
1782 (LISP_INITIALLY_ZERO): New macro.
1783 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1784 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1785
45fa9c0f
GM
17862012-06-12 Glenn Morris <rgm@gnu.org>
1787
b4492cba
GM
1788 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1789
1790 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1791
45fa9c0f
GM
1792 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1793 Move BROKEN_SIGIO to configure.
1794
1795 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1796 Move NO_TERMIO to configure.
1797
0e25d334
CY
17982012-06-12 Chong Yidong <cyd@gnu.org>
1799
1800 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1801 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1802 MagickExportImagePixels is undefined.
1803
43682bb6
PE
18042012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1805
1806 * image.c (imagemagick_load_image): Remove unused label.
1807
a9be7d2b
GM
18082012-06-11 Glenn Morris <rgm@gnu.org>
1809
1810 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1811 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1812 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1813 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1814
3017f87f
SM
18152012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1816
1817 * alloc.c (make_byte_code): New function.
1818 (Fmake_byte_code): Use it. Don't purify here.
1819 * lread.c (read1): Use it as well to avoid extra allocation.
1820
1b9b4cf4
CY
18212012-06-11 Chong Yidong <cyd@gnu.org>
1822
1823 * image.c (imagemagick_load_image): Implement transparency.
1824
95988fcf
AS
18252012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1826
1827 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1828 account for preceding backslashes. (Bug#11663)
1829
cd4eb164
CY
18302012-06-09 Chong Yidong <cyd@gnu.org>
1831
1832 * term.c: Support italics in capable terminals (Bug#9652).
1833 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1834 (turn_on_face): Output using TS_enter_italic_mode if available.
1835 Don't handle unused blinking and alt-charset cases.
1836 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1837 and tty_alt_charset_p cases.
1838 (tty_capable_p, init_tty): Support italics.
1839
1840 * termchar.h (struct tty_display_info): Add field for italics.
1841 Remove unused blink field.
1842
1843 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1844 Handle slant.
1845
1846 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1847 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1848 tty_alt_charset_p. Add tty_italic_p.
1849
ff88beb8
MA
18502012-06-09 Michael Albinus <michael.albinus@gmx.de>
1851
1852 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1853 dbus_type_is_basic if available.
1854 (xd_extract_signed, xd_extract_unsigned): Rename from
1855 extract_signed and extract_unsigned, respectively. Adapt callers.
1856
44286096
CY
18572012-06-09 Chong Yidong <cyd@gnu.org>
1858
1682701f
CY
1859 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1860
44286096
CY
1861 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1862 case (Bug#9752).
1863
d86feb17
PE
18642012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1865
1866 * xdisp.c (vmessage): Treat frame message as multibyte.
1867 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1868 would generate the diagnostic "Making \302\247 buffer-local while
1869 let-bound!".
1870
d5c20fe8
EZ
18712012-06-08 Eli Zaretskii <eliz@gnu.org>
1872
1873 * dispnew.c (showing_window_margins_p): Undo last change, which
1874 was done due to an inadvertent commit.
1875 (adjust_frame_glyphs_for_frame_redisplay): Do call
1876 showing_window_margins_p.
1877
513749ee
SM
18782012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1879
1880 * eval.c (Fmake_var_non_special): New primitive.
1881 (syms_of_eval): Defsubr it.
1882 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1883
d4a8f5c1
JB
18842012-06-08 Juanma Barranquero <lekktu@gmail.com>
1885
1886 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1887 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1888
8bbbc977
EZ
18892012-06-08 Eli Zaretskii <eliz@gnu.org>
1890
1891 * alloc.c (allocate_vectorlike): Fix last change.
1892
f3372c87
DA
18932012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1894
1895 Block-based vector allocation of small vectors.
1896 * lisp.h (struct vectorlike_header): New field `nbytes',
1897 adjust comment accordingly.
1898 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1899 to denote vector blocks. Adjust users (live_vector_p,
1900 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1901 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1902 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1903 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1904 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1905 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1906 (roundup_size): New constant.
1907 (struct vector_block): New data type.
1908 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1909 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1910 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1911 (sweep_vectors): New functions.
1912 (allocate_vectorlike): Return `zero_vector' as the only vector of
1913 0 items. Allocate new vector from block if vector size is less than
1914 or equal to VBLOCK_BYTES_MAX.
1915 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1916 (init_alloc_once): Add call to init_vectors.
1917
4f18a4ed
SM
19182012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1919
1920 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1921
86f158bc
PE
19222012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1923
1924 * doprnt.c (doprnt): Truncate multibyte char correctly.
1925 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1926 would mishandle a string argument "Xc" if X was a multibyte
1927 character of length 2: it would truncate after X's first byte
1928 rather than including all of X.
1929
c5cfcbe0
CY
19302012-06-06 Chong Yidong <cyd@gnu.org>
1931
1932 * buffer.c (word_wrap): Doc fix.
1933
c05cf390
PE
19342012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1935
1936 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1937
0c3461de
GM
19382012-06-03 Glenn Morris <rgm@gnu.org>
1939
1940 * xdisp.c (tool-bar-style): Doc fix.
1941
c71232db
UM
19422012-06-03 Ulrich Müller <ulm@gentoo.org>
1943
1944 * Makefile.in (PAXCTL): Define.
1945 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1946 binary via PaX flags if the paxctl utility is available.
1947 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1948 Restore PaX flags to their default. (Bug#11398)
1949
383f7350
CY
19502012-06-03 Chong Yidong <cyd@gnu.org>
1951
1952 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1953 buffer (Bug#11226).
1954
5f2c76c6
CY
19552012-06-03 Chong Yidong <cyd@gnu.org>
1956
1957 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1958 (note_mode_line_or_margin_highlight): If there is no help echo,
1959 use mode-line-default-help-echo. Handle the case where the mouse
1960 position is past the end of the mode line string.
1961
1962 * buffer.c (buffer_local_value_1): New function, split from
1963 Fbuffer_local_value; can return Qunbound.
1964 (Fbuffer_local_value): Use it.
1965 (Vmode_line_format): Docstring tweaks.
1966
773d47f6
PE
19672012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1968
1969 * sysdep.c (system_process_attributes): Improve comment.
1970
f2d6a3df
SM
19712012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1972
1973 * keyboard.c: Export real-this-command to Elisp.
1974 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1975 and DEFVAR it. Update all users.
1976
63810350
PE
19772012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1978
7bd5c1f4
PE
1979 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1980
63810350
PE
1981 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1982 Convert pctcpu and pctmem to Lisp float properly.
1983 Let the compiler fold better, as 100.0/0x8000 is exact.
1984
a2821611
AS
19852012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1986
1987 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1988 cons_block.
1989
5fceba1d
PE
19902012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1991
1992 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1993
c98ff5dd
DA
19942012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1995
1996 For a 'struct window', replace some Lisp_Object fields to
1997 bitfields where appropriate, remove unused fields.
1998 * window.h (struct window): Remove unused 'last_mark_x' and
1999 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2000 change it's type from Lisp_Object to bitfield.
2001 Change type of 'force_start', 'optional_new_start',
2002 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2003 fields from Lisp_Object to bitfield. Adjust users accordingly.
2004
ca34e0be
PE
20052012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2006
2007 Pacify gcc -Wdouble-precision when using Xaw.
2008 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2009 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2010 Use 'float' consistently, rather than 'float' in most places
2011 and 'double' in a couple of places.
2012
efc00ab1 20132012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2014
2015 * xdisp.c (handle_stop): Detect whether we have overlay strings
2016 loaded by testing it->current.overlay_string_index to be
2017 non-negative, instead of checking whether n_overlay_strings is
2018 positive. (Bug#11587)
2019
efc00ab1 20202012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2021
2022 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2023
2024 * doc.c (Fsubstitute_command_keys): Doc fix.
2025
efc00ab1 20262012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2027
2028 * search.c (search_buffer): Remove calls to
2029 r_alloc_inhibit_buffer_relocation, as it is now called by
2030 maybe_unify_char, which was the cause of relocation of buffer text
2031 in bug#11519.
2032
efc00ab1 20332012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2034
2035 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2036 for the duration of call to load_charset, to avoid problems with
2037 callers of maybe_unify_char that access buffer text through C
2038 pointers.
2039
2040 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2041 decrement the inhibition flag, instead of just setting or
2042 resetting it.
2043
ba93a187
PE
20442012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2045
2046 Remove obsolete '#define static' cruft.
2047 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2048 This #undef was "temporary" in 2000; it is no longer needed
2049 now that '#define static' has gone away.
2050 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2051 (gray_bitmap_bits): Remove; no longer needed.
2052 All uses replaced with definiens.
2053 * xterm.c: Include "bitmaps/gray.xbm".
2054
9e4bf381
PE
20552012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2056
2057 Clean up __executable_start, monstartup when --enable-profiling.
2058 The following changes affect the code only when profiling.
2059 * dispnew.c (__executable_start): Rename from safe_bcopy.
2060 Define only on platforms that need it.
2061 * emacs.c: Include <sys/gmon.h> when profiling.
2062 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2063 (__executable_start): Remove decl, since lisp.h does it now.
2064 (safe_bcopy): Remove decl; no longer has that name.
2065 (main): Coalesce #if into single bit of code, for simplicity.
2066 Cast pointers to uintptr_t, since standard libraries want integers
2067 and not pointers.
2068 * lisp.h (__executable_start): New decl.
2069
32d72c2f
GM
20702012-05-31 Glenn Morris <rgm@gnu.org>
2071
2072 * image.c (Fimagemagick_types): Doc fix.
2073
baac5bc7
JM
20742012-05-30 Jim Meyering <meyering@redhat.com>
2075
2076 * callproc.c (Fcall_process_region): Include directory component
2077 in mkstemp error message (Bug#11586).
2078
72cb32cf
PE
20792012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2080
2081 * alloc.c, lisp.h (make_pure_vector): Now static.
2082
61b108cc
SM
20832012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2084
2085 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2086 Move to byte-run.el.
2087 (Fautoload): Do the hash-doc more carefully.
2088 * data.c (Fdefalias): Purify definition, except for keymaps.
2089 (Qdefun): Move from eval.c.
2090 * lisp.h (Qdefun): Remove.
2091 * lread.c (read1): Tiny simplification.
2092
471fe23d
TN
20932012-05-29 Troels Nielsen <bn.troels@gmail.com>
2094
934f3f58 2095 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2096 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2097 Bug#9642, but explicitly check that the buffer the overlay would
2098 be moved to is live and rearrange lines to make sure that errors
2099 will not put the overlay in an inconsistent state.
2100 (Fdelete_overlay): Cosmetics.
2101
85d0efd1
EZ
21022012-05-28 Eli Zaretskii <eliz@gnu.org>
2103
2104 * w32term.c (my_bring_window_to_top): New function.
2105 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2106 could be different from the original one.
2107 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2108 (Bug#11513)
2109
2110 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2111 by calling BringWindowToTop.
2112
2113 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2114 (WM_EMACS_END): Increase by one.
2115
da92a98c
PE
21162012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2117
2118 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2119 This avoids undefined behavior that might cause the eassert
2120 to not catch an out-of-range value.
2121
74d1f848
JB
21222012-05-28 Juanma Barranquero <lekktu@gmail.com>
2123
2124 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2125 Update dependencies.
2126
9e1a06fc
EZ
21272012-05-27 Eli Zaretskii <eliz@gnu.org>
2128
2129 * bidi.c (bidi_mirror_char): Fix last change.
2130
f3dd7312
AS
21312012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2132
2133 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2134 when referring to sectname field in printf format.
2135
81899c91
PE
21362012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2137
57b81a9f
PE
2138 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2139 Only r_alloc_inhibit_buffer_relocation needed to be added;
2140 the others were already declared.
2141
81899c91
PE
2142 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2143 before checking whether it's out of range. Put the check inside
2144 eassert. See
2145 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2146
33017faf 21472012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
2148
2149 * callproc.c (Fcall_process): Restore a line that was accidentally
2150 commented out in the 2011-02-13 change (bug#11547).
2151
33017faf 21522012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
2153
2154 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2155 defined on ralloc.c.
2156
2157 * buffer.c [REL_ALLOC]: Remove prototypes of
2158 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2159 they are now on lisp.h.
2160
2161 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2162
2163 * search.c (search_buffer): Use it to inhibit relocation of buffer
2164 text while re_search_2 is doing its job, because re_search_2 is
2165 passed C pointers to buffer text. (Bug#11519)
2166
23415acf
EZ
2167 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2168 Update value to 24.
2169
44e27368
EZ
2170 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2171 state after an additional call to move_it_in_display_line_to, keep
2172 the values of it->max_ascent and it->max_descent found for the
2173 entire line.
2174 (pos_visible_p): Revert the comparison against bottom_y to what it
2175 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2176 (Bug#11464)
2177
c1892f11
PE
21782012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2179
2180 Fix coding-related core dumps with gcc -ftrapv.
2181 The code was computing A - B, where A and B are pointers, and B is
2182 random garbage. This can lead to core dumps on platforms that
2183 have special pointer registers, and it also leads to core dumps on
2184 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2185 A - B only when B is initialized properly.
2186 * coding.c (coding_set_source, coding_set_destination): Return void.
2187 (coding_change_source, coding_change_destinations): New functions,
2188 with the old behaviors of coding_set_source and coding_set_destination.
2189 All callers that need an offset changed to use these new functions.
2190
eb7afdad
GM
21912012-05-26 Glenn Morris <rgm@gnu.org>
2192
2193 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2194
f12fdf02
EZ
21952012-05-26 Eli Zaretskii <eliz@gnu.org>
2196
53a63be6 2197 Extend mouse support on W32 text-mode console.
61b108cc
SM
2198 * xdisp.c (draw_row_with_mouse_face):
2199 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 2200
eb3f6f01 2201 * w32console.c: Include window.h.
61b108cc
SM
2202 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2203 New functions.
eb3f6f01
EZ
2204 (initialize_w32_display): Initialize mouse-highlight data.
2205
53a63be6
EZ
2206 * w32inevt.c: Include termchar.h and window.h.
2207 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2208 moves, call note_mouse_highlight. If help_echo changed, call
2209 gen_help_event to produce help-echo message in the echo area.
2210 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2211 highlight info.
2212
4cfd81f6
PE
22132012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2214
2215 * lread.c (read1): Simplify slightly to avoid an overflow warning
2216 with GCC 4.7.0 on x86-64.
2217
4446092a
EZ
22182012-05-26 Eli Zaretskii <eliz@gnu.org>
2219
2220 * bidi.c (bidi_mirror_char): Revert last change: an int is
2221 definitely wide enough here.
2222
42b2a986 22232012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 2224
42b2a986 2225 Fix integer width and related bugs (Bug#9874).
eb106a49 2226 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
2227 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2228 (string_bytes, check_sblock, allocate_string_data):
2229 (compact_small_strings, Fmake_bool_vector, make_string)
2230 (make_unibyte_string, make_multibyte_string)
2231 (make_string_from_bytes, make_specified_string)
2232 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2233 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2234 (mark_vectorlike):
2235 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2236 (allocate_pseudovector):
2237 Use int, not EMACS_INT, where int is wide enough.
2238 (inhibit_garbage_collection, Fgarbage_collect):
2239 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2240 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2241 int might not be wide enough.
2242 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2243 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2244 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2245 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2246 (bidi_level_of_next_char, bidi_move_to_visually_next):
2247 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2248 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2249 (Fkill_buffer, Fset_buffer_major_mode)
2250 (advance_to_char_boundary, Fbuffer_swap_text)
2251 (Fset_buffer_multibyte, overlays_at, overlays_in)
2252 (overlay_touches_p, struct sortvec, record_overlay_string)
2253 (overlay_strings, recenter_overlay_lists)
2254 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2255 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2256 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2257 (Foverlay_recenter, last_overlay_modification_hooks_used)
2258 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2259 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2260 (validate_region): Omit unnecessary test for b <= e,
2261 since that's guaranteed by the previous test.
d311d28c
PE
2262 (adjust_overlays_for_delete): Avoid pos + length overflow.
2263 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2264 (report_overlay_modification):
2265 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2266 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2267 Omit pointer cast, which isn't needed anyway, and doesn't work
2268 after the EMACS_INT -> ptrdiff_t change.
02481186 2269 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2270 * buffer.h: Adjust decls to match defn changes elsewhere.
2271 (struct buffer_text, struct buffer):
2272 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2273 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2274 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2275 not int, to avoid needless 32-bit limit on 64-bit hosts.
2276 (exec_byte_code): Use tighter memory-full test, one that checks
2277 for alloca overflow. Don't compute the address of the object just
2278 before an array, as that's not portable. Use EMACS_INT, not
2279 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2280 * callint.c (Fcall_interactively):
2281 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2282 * callproc.c (call_process_kill, Fcall_process):
2283 Don't assume pid_t fits into an Emacs fixnum.
2284 (call_process_cleanup, Fcall_process, child_setup):
2285 Don't assume pid_t fits into int.
2286 (call_process_cleanup, Fcall_process, delete_temp_file)
2287 (Fcall_process_region):
2288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2289 (Fcall_process): Simplify handling of volatile integers.
2290 Use int, not EMACS_INT, where int will do.
2291 * casefiddle.c (casify_object, casify_region, operate_on_word)
2292 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2294 (casify_object): Avoid integer overflow when overallocating buffer.
2295 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2296 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2297 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2298 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2299 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2300 integers are now checked earlier. All uses replaced with XINT.
2301 (ccl_driver):
2302 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2303 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2304 (ccl_driver, Fregister_code_conversion_map):
2305 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2306 (resolve_symbol_ccl_program): Check that vector header is in range.
2307 Always copy the vector, so that we can check its contents reliably
2308 now rather than having to recheck each instruction as it's being
2309 executed. Check that vector words fit in 'int'.
2310 (ccl_get_compiled_code, Fregister_ccl_program)
2311 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2312 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2313 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2314 contents are in range.
2315 (Fccl_execute_on_string): Check that status is in range.
2316 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2317 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2318 Accept and return EMACS_INT, not int, because callers can pass values
2319 out of 'int' range.
2320 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2321 (multibyte_chars_in_text, parse_str_as_multibyte)
2322 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2323 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2324 (string_escape_byte8, Fget_byte):
2325 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2326 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2327 avoid mishandling large integers.
2328 * character.h: Adjust decls to match defn changes elsewhere.
2329 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2330 (Ffind_charset_region):
2331 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2332 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2333 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2334 Don't assume fixnum fits in int.
d311d28c
PE
2335 (load_charset_map_from_vector, Fmap_charset_chars):
2336 Remove now-unnecessary CHECK_NATNUMs.
2337 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2338 Don't rely on undefined behavior with signed left shift overflow.
2339 Don't assume unsigned int fits into fixnum, or that fixnum fits
2340 into unsigned int. Don't require max_code to be a valid fixnum;
2341 that's not true for gb10830 4-byte on a 32-bit host. Allow
2342 invalid_code to be a cons, for the same reason. Require code_offset
2343 to be a character. Avoid int overflow if max_char is close
2344 to INT_MAX.
2345 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2346 this is intended anyway and avoids some undefined behavior.
2347 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2348 INDEX_TO_CODE_POINT, as that's what it expects.
2349 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2350 * charset.h (DECODE_CHAR): Return int, not unsigned;
2351 this is what was intended anyway, and it avoids undefined behavior.
2352 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2353 integer-overflow issues.
2354 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2355 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2356 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2357 * chartab.c (Fmake_char_table, Fset_char_table_range)
2358 (uniprop_get_decoder, uniprop_get_encoder):
2359 Don't assume fixnum fits in int.
2360 * cmds.c (move_point): New function, that does the gist of
2361 Fforward_char and Fbackward_char, but does so while checking
2362 for integer overflow more accurately.
c96e5d6a 2363 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2364 (Fforward_line, Fend_of_line, internal_self_insert)
2365 (internal_self_insert):
2366 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2367 Fix a FIXME, by checking for integer overflow when calculating
2368 target_clm and actual_clm.
2369 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2370 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2371 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2372 (coding_alloc_by_making_gap, alloc_destination)
2373 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2374 (encode_coding_utf_16, detect_coding_emacs_mule)
2375 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2376 (detect_coding_iso_2022, decode_coding_iso_2022)
2377 (encode_invocation_designation, encode_designation_at_bol)
2378 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2379 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2380 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2381 (encode_coding_ccl, encode_coding_raw_text)
2382 (detect_coding_charset, decode_coding_charset)
2383 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2384 (produce_composition, produce_charset, produce_annotation)
2385 (decode_coding, handle_composition_annotation)
2386 (handle_charset_annotation, consume_chars, decode_coding_gap)
2387 (decode_coding_object, encode_coding_object, detect_coding_system)
2388 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2389 (code_convert_region, code_convert_string)
8f50130c
PE
2390 (Fdefine_coding_system_internal)
2391 (coding_set_source, coding_set_destination):
d311d28c
PE
2392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2393 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2394 (Fdefine_coding_system_internal):
2395 Don't assume fixnums fit in int.
2396 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2397 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2398 (Funencodable_char_position, Fcheck_coding_systems_region)
2399 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2400 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2401 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2402 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2403 Don't access memory outside of the args array.
d311d28c 2404 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2405 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2406 result of ENCODE_CHAR.
d311d28c
PE
2407 * coding.h: Adjust decls to match defn changes elsewhere.
2408 (struct coding_system):
2409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2410 * composite.c (get_composition_id, find_composition)
2411 (run_composition_function, update_compositions)
2412 (compose_text, composition_gstring_put_cache)
2413 (composition_gstring_p, composition_gstring_width)
2414 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2415 (composition_compute_stop_pos, composition_reseat_it)
2416 (composition_update_it, struct position_record)
2417 (find_automatic_composition, composition_adjust_point)
2418 (Fcomposition_get_gstring, Ffind_composition_internal):
2419 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2420 (update_compositions):
2421 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2422 * composite.h: Adjust decls to match defn changes elsewhere.
2423 (struct composition):
2424 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2425 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2426 Do not attempt to compute the address of the object just before a
2427 buffer; this is not portable.
2428 (Faref, Faset):
2429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2430 (Faset): Use int, not EMACS_INT, where int is wide enough.
2431 (Fstring_to_number): Don't assume fixnums fit in int.
2432 (Frem): Don't assume arg is nonnegative.
2433 * dbusbind.c (xd_append_arg): Check for integers out of range.
2434 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2435 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2436 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2437 (xd_get_connection_references): Return ptrdiff_t, not int.
2438 All uses changed.
2439 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2440 (xd_read_message_1):
2441 Use int, not unsigned, where the dbus API uses int.
2442 (Fdbus_message_internal): Don't overflow mtype.
2443 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2444 * dired.c (directory_files_internal, file_name_completion, scmp)
2445 (file_name_completion_stat):
2446 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2447 (file_name_completion): Don't overflow matchcount.
2448 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2449 * dispextern.h: Adjust decls to match defn changes elsewhere.
2450 (struct text_pos, struct glyph, struct bidi_saved_info)
2451 (struct bidi_string_data, struct bidi_it, struct composition_it)
2452 (struct it):
2453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2454 (struct display_pos, struct composition_it, struct it):
2455 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2456 * dispnew.c (increment_matrix_positions)
2457 (increment_row_positions, mode_line_string)
2458 (marginal_area_string):
2459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2460 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2462 (duration_to_sec_usec): New function, to check for overflow better.
2463 (Fsleep_for, sit_for): Use it.
2464 * doc.c (get_doc_string, store_function_docstring):
2465 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2466 (get_doc_string, Fsnarf_documentation):
2467 Use int, not EMACS_INT, where int is wide enough.
2468 (get_doc_string):
2469 Use SAFE_ALLOCA, not alloca.
2470 Check for overflow when converting EMACS_INT to off_t.
2471 * doprnt.c (doprnt):
2472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2473 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2474 Don't assume uid_t fits into fixnum.
2475 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2476 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2477 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2478 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2479 (general_insert_function)
2480 (Finsert_char, make_buffer_string, make_buffer_string_both)
2481 (update_buffer_properties, Fbuffer_substring)
2482 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2483 (Fsubst_char_in_region, check_translation)
2484 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2485 (transpose_markers, Ftranspose_regions):
2486 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2487 (clip_to_bounds): Move to lisp.h as an inline function).
2488 (Fconstrain_to_field): Don't assume integers are nonnegative.
2489 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2490 (Fsubst_char_in_region, Fsave_restriction):
2491 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2492 (Femacs_pid): Don't assume pid_t fits into fixnum.
2493 (lo_time): Use int, not EMACS_INT, when int suffices.
2494 (lisp_time_argument): Check for usec out of range.
2495 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2496 (Fuser_login_name, Fuser_full_name): Signal an error
2497 if a uid argument is out of range, rather than relying on
2498 undefined behavior.
c8d5c857
PE
2499 (Fformat_time_string): Remove now-unnecessary check.
2500 lisp_time_argument checks for out-of-range usec now.
243e0530 2501 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2502 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2503 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2504 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2505 (init_cmdargs, Fdump_emacs):
2506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2507 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2508 the bottom (typically) 32 bits of the fixnum.
2509 * eval.c (specpdl_size, call_debugger):
2510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2511 (when_entered_debugger, Fbacktrace_debug):
2512 Don't assume fixnum can fit in int.
2513 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2514 the object just before a buffer; this is not portable.
2515 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2516 (grow_specpdl, unbind_to):
2517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2518 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2519 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2520 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2521 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2522 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2523 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2524 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2525 (a_write, e_write):
2526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2527 (Fcopy_file, non_regular_nbytes, read_non_regular)
2528 (Finsert_file_contents):
2529 Use int, not EMACS_INT, where int is wide enough.
2530 (READ_BUF_SIZE): Verify that it fits in int.
2531 (Finsert_file_contents): Check that counts are in proper range,
2532 rather than assuming fixnums fit into ptrdiff_t etc.
2533 Don't assume fixnums fit into int.
125b3835 2534 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2535 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2536 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2537 (string_char_to_byte, string_byte_to_char)
2538 (string_make_multibyte, string_to_multibyte)
2539 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2540 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2541 (substring_both, Fdelete, internal_equal, Ffillarray)
2542 (Fclear_string, mapcar1)
2543 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2544 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2545 (larger_vector, make_hash_table, maybe_resize_hash_table)
2546 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2547 (Fmaphash, secure_hash):
2548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2549 (concat): Check for string index and length overflow.
2550 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2551 (Frequire):
2552 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2553 (larger_vector): New API (vec, incr_min, size_max) replaces old
2554 one (vec, new_size, init). This catches size overflow.
2555 INIT was removed because it was always Qnil.
2556 All callers changed.
2557 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2558 the upper bound on a hash table index size.
2559 (make_hash_table, maybe_resize_hash_table): Use it.
2560 (secure_hash): Computer start_byte and end_byte only after
2561 they're known to be in ptrdiff_t range.
2562 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2563 (Ffont_get_glyphs, Ffont_at):
2564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2565 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2566 (Flist_fonts, Fopen_font):
2567 Don't assume fixnum can fit in int.
2568 (check_gstring): Don't assume index can fit in int.
2569 (font_match_p): Check that fixnum is a character, not a nonnegative
2570 fixnum, since the later code needs to stuff it into an int.
2571 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2572 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2573 conversion overflow issues.
2574 (Fopen_font): Check for integer out of range.
2575 (Ffont_get_glyphs): Don't assume index can fit in int.
2576 * font.h: Adjust decls to match defn changes elsewhere.
2577 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2578 integer overflow.
2579 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2580 printmax_t, where ptrdiff_t is wide enough.
2581 (Finternal_char_font):
2582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2583 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2584 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2585 (Fset_frame_position, x_set_frame_parameters)
2586 (x_set_line_spacing, x_set_border_width)
2587 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2588 Check that fixnums are in proper range for system types.
2589 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2590 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2591 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2592 Use SAFE_ALLOCA_LISP, not alloca.
2593 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2594 intptr_t is wide enough.
2595 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2596 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2597 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2598 Check for fixnum out of range.
2599 * ftfont.c (ftfont_list): Don't assume index fits in int.
2600 Check that fixnums are in proper range for system types.
2601 (ftfont_shape_by_flt):
2602 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2603 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2605 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2606 Check that fixnums are in proper range for system types.
2607 * gnutls.h: Adjust decls to match defn changes elsewhere.
2608 * gtkutil.c (xg_dialog_run):
2609 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2610 (update_frame_tool_bar):
2611 Check that fixnums are in proper range for system types.
2612 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2613 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2614 * indent.c (last_known_column, last_known_column_point):
2615 (current_column_bol_cache):
2616 (skip_invisible, current_column, check_display_width):
2617 (check_display_width, scan_for_column, current_column_1)
2618 (Findent_to, Fcurrent_indentation, position_indentation)
2619 (indented_beyond_p, Fmove_to_column, compute_motion):
2620 (Fcompute_motion, Fvertical_motion):
2621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2622 (last_known_column_modified): Use EMACS_INT, not int.
2623 (check_display_width):
2624 (Fcompute_motion):
2625 Check that fixnums and floats are in proper range for system types.
2626 (compute_motion): Don't assume index or fixnum fits in int.
2627 (compute_motion, Fcompute_motion):
2628 Use int, not EMACS_INT, when it is wide enough.
2629 (vmotion): Omit local var start_hpos that is always 0; that way
2630 we don't need to worry about overflow in expressions involving it.
2631 * indent.h: Adjust decls to match defn changes elsewhere.
2632 (struct position):
2633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2634 Use int, not EMACS_INT, where int is wide enough.
2635 Remove unused members ovstring_chars_done and tab_offset;
2636 all uses removed.
2637 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2638 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2639 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2640 (make_gap, copy_text, insert, insert_and_inherit)
2641 (insert_before_markers, insert_before_markers_and_inherit)
2642 (insert_1, count_combining_before, count_combining_after)
2643 (insert_1_both, insert_from_string)
2644 (insert_from_string_before_markers, insert_from_string_1)
2645 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2646 (adjust_after_replace, adjust_after_insert, replace_range)
2647 (replace_range_2, del_range, del_range_1, del_range_byte)
2648 (del_range_both, del_range_2, modify_region)
2649 (prepare_to_modify_buffer, signal_before_change)
2650 (signal_after_change, Fcombine_after_change_execute):
2651 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2652 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2653 (balance_an_interval, split_interval_right, split_interval_left)
2654 (find_interval, next_interval, update_interval)
2655 (adjust_intervals_for_insertion, delete_node, delete_interval)
2656 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2657 (static_offset_intervals, offset_intervals)
2658 (merge_interval_right, merge_interval_left, make_new_interval)
2659 (graft_intervals_into_buffer, temp_set_point_both)
2660 (temp_set_point, set_point, adjust_for_invis_intang)
2661 (set_point_both, move_if_not_intangible, get_property_and_range)
2662 (get_local_map, copy_intervals, copy_intervals_to_string)
2663 (compare_string_intervals, set_intervals_multibyte_1):
2664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2665 * intervals.h: Adjust decls to match defn changes elsewhere.
2666 (struct interval):
2667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2668 * keyboard.c (this_command_key_count, this_single_command_key_start)
2669 (before_command_key_count, before_command_echo_length, echo_now)
2670 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2671 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2672 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2673 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2674 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2675 (last_non_minibuf_size, last_point_position, echo_truncate)
2676 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2677 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2678 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2679 (stuff_buffered_input):
2680 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2681 (last_auto_save, command_loop_1, read_char):
2682 Use EMACS_INT, not int, to avoid integer overflow.
2683 (record_char): Avoid overflow in total_keys computation.
2684 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2685 * keyboard.h: Adjust decls to match defn changes elsewhere.
2686 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2687 (Fkey_description, Fdescribe_vector, Flookup_key):
2688 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2689 (click_position): New function, to check that positions are in range.
2690 (Fcurrent_active_maps):
2691 (describe_command):
2692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2693 (Faccessible_keymaps, Fkey_description):
2694 (preferred_sequence_p):
2695 Don't assume fixnum can fit into int.
2696 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2697 Check for integer overflow in size calculations.
2698 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2699 avoid mishandling large integers.
2700 * lisp.h: Adjust decls to match defn changes elsewhere.
2701 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2702 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2703 (struct Lisp_Marker):
2704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2705 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2706 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2707 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2708 All callers changed.
2709 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2710 Assume the arg has valid form, since it always does.
2711 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2712 unsigned integer system type.
2713 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2714 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2715 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2716 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2717 (duration_to_sec_usec): New decl.
2718 * lread.c (read_from_string_index, read_from_string_index_byte)
2719 (read_from_string_limit, readchar, unreadchar, openp)
2720 (read_internal_start, read1, oblookup):
2721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2722 (Fload, readevalloop, Feval_buffer, Feval_region):
2723 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2724 (openp): Check for out-of-range argument to 'access'.
2725 (read1): Use int, not EMACS_INT, where int is wide enough.
2726 Don't assume fixnum fits into int.
6efdadfd 2727 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2728 (read_filtered_event): Use duration_to_sec_usec
2729 to do proper overflow checking on durations.
d311d28c
PE
2730 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2731 in size calculation.
2732 (Fexecute_kbd_macro):
2733 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2734 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2735 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2736 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2737 (set_marker_both, set_marker_restricted_both, marker_position)
2738 (marker_byte_position, Fbuffer_has_markers_at):
2739 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2740 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2741 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2742 It now merely ensures that the menu is large enough, without
2743 necessarily growing it, as this avoids some integer overflow issues.
2744 All callers changed.
2745 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2746 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2747 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2748 Use SAFE_ALLOCA_LISP, not alloca.
2749 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2750 to EMACS_INT. Check that fixnums are in proper range for system types.
2751 * minibuf.c (minibuf_prompt_width, string_to_object)
2752 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2753 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2754 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2755 (get_minibuffer, read_minibuf_unwind):
2756 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2757 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2758 this simplifies overflow checking. All callers changed.
2759 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2760 (Ftest_completion):
2761 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2762 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2763 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2764 Check that fixnums are in proper range for system types.
2765 (Fx_create_frame, Fx_show_tip):
2766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2767 * nsfont.m (ns_findfonts, nsfont_list_family):
2768 Don't assume fixnum fits in long.
2769 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2771 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2772 wide enough.
17fdb222 2773 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2775 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2776 (PRINTDECLARE, PRINTPREPARE):
2777 (strout, print_string):
2778 (print, print_preprocess, print_check_string_charset_prop)
2779 (print_object):
2780 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2781 (PRINTDECLARE):
2782 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2784 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2785 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2786 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2787 (print_error_message): Use SAFE_ALLOCA, not alloca.
2788 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2789 (print_depth, new_backquote_output, print_number_index):
2790 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2791 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2792 (Fset_process_window_size, Fformat_network_address)
2793 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2794 (sigchld_handler):
d311d28c 2795 Check that fixnums are in proper range for system types.
d44287d4 2796 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2797 Check for process-ids out of pid_t range rather than relying on
2798 undefined behavior.
e4d81efc 2799 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2800 (Fformat_network_address, read_process_output, send_process)
2801 (Fprocess_send_region, status_notify):
2802 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2803 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2804 (wait_reading_process_output, read_process_output, exec_sentinel):
2805 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2806 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2807 (Faccept_process_output): Use duration_to_sec_usec to do proper
2808 overflow checking on durations.
dde14581
PE
2809 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2810 Don't assume pid_t fits in int.
02481186
PE
2811 * process.h (struct Lisp_Process): Members tick and update_tick
2812 are now of type EMACS_INT, not int.
b62b53e8
PE
2813 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2814 configured --with-wide-int.
d311d28c
PE
2815 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2816 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2817 * search.c (looking_at_1, string_match_1):
2818 (fast_string_match, fast_c_string_match_ignore_case)
2819 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2820 (scan_newline, find_before_next_newline, search_command)
2821 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2822 (set_search_regs, wordify):
2823 (Freplace_match):
2824 (Fmatch_data):
2825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2826 (string_match_1, search_buffer, set_search_regs):
2827 (Fmatch_data):
2828 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2829 (wordify): Check for overflow in size calculation.
2830 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2831 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2832 Check that fixnums are in proper range for system types.
2833 * sound.c (struct sound_device)
2834 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2835 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2836 (Fplay_sound_internal):
2837 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2838 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2839 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2840 (Fparse_partial_sexp):
2841 Don't assume fixnums can fit in int.
2842 (struct lisp_parse_state, find_start_pos, find_start_value)
2843 (find_start_value_byte, find_start_begv)
2844 (update_syntax_table, char_quoted, dec_bytepos)
2845 (find_defun_start, prev_char_comend_first, back_comment):
2846 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2847 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2849 (Finternal_describe_syntax_value): Check that match_lisp is a
2850 character, not an integer, since the code stuffs it into int.
2851 (scan_words, scan_sexps_forward):
2852 Check that fixnums are in proper range for system types.
2853 (Fforward_word):
2854 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2855 (scan_sexps_forward):
2856 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2857 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2858 * syntax.h: Adjust decls to match defn changes elsewhere.
2859 (struct gl_state_s):
2860 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2861 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2862 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2863 * sysdep.c (wait_for_termination_1, wait_for_termination)
2864 (interruptible_wait_for_termination, mkdir):
2865 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2866 (emacs_read, emacs_write):
2867 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2868 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2869 and double all fit in int.
d311d28c
PE
2870 * term.c (set_tty_color_mode):
2871 Check that fixnums are in proper range for system types.
2872 * termhooks.h (struct input_event):
2873 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2874 * textprop.c (validate_interval_range, interval_of)
2875 (Fadd_text_properties, set_text_properties_1)
2876 (Fremove_text_properties, Fremove_list_of_text_properties)
2877 (Ftext_property_any, Ftext_property_not_all)
2878 (copy_text_properties, text_property_list, extend_property_ranges)
2879 (verify_interval_modification):
2880 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2881 (Fnext_single_char_property_change)
2882 (Fprevious_single_char_property_change):
2883 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2884 (copy_text_properties):
2885 Check for integer overflow in index calculation.
d311d28c
PE
2886 * undo.c (last_boundary_position, record_point, record_insert)
2887 (record_delete, record_marker_adjustment, record_change)
2888 (record_property_change):
2889 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2890 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2891 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2892 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2893 (Fx_hide_tip, Fx_file_dialog):
2894 * w32menu.c (set_frame_menubar):
2895 Use ptrdiff_t, not int, for consistency with rest of code.
2896 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2897 (select_window, Fdelete_other_windows_internal)
2898 (window_scroll_pixel_based, window_scroll_line_based)
2899 (Frecenter, Fset_window_configuration):
2900 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2901 (Fset_window_hscroll, run_window_configuration_change_hook)
2902 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2903 (Fscroll_other_window, Frecenter):
d311d28c
PE
2904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2905 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2906 Don't assume fixnum fits in int.
2907 (Fset_window_scroll_bars):
2908 Check that fixnums are in proper range for system types.
2909 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2910 (string_pos, c_string_pos, number_of_chars, init_iterator)
2911 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2912 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2913 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2914 (face_before_or_after_it_pos, handle_invisible_prop)
2915 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2916 (display_prop_intangible_p, string_buffer_position_lim)
2917 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2918 (get_overlay_strings_1, get_overlay_strings)
2919 (iterate_out_of_display_property, forward_to_next_line_start)
2920 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2921 (get_next_display_element, set_iterator_to_next)
2922 (get_visually_first_element, compute_stop_pos_backwards)
2923 (handle_stop_backwards, next_element_from_buffer)
2924 (move_it_in_display_line_to, move_it_in_display_line)
2925 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2926 (add_to_log, message_dolog, message_log_check_duplicate)
2927 (message2, message2_nolog, message3, message3_nolog
2928 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2929 (current_message_1, truncate_echo_area, truncate_message_1)
2930 (set_message, set_message_1, store_mode_line_noprop)
2931 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2932 (text_outside_line_unchanged_p, check_point_in_composition)
2933 (reconsider_clip_changes)
2934 (redisplay_internal, set_cursor_from_row, try_scrolling)
2935 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2936 (redisplay_window, find_last_unchanged_at_beg_row)
2937 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2938 (trailing_whitespace_p, find_row_edges, display_line)
2939 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2940 (display_mode_element, store_mode_line_string)
2941 (pint2str, pint2hrstr, decode_mode_spec)
2942 (display_count_lines, display_string, draw_glyphs)
2943 (x_produce_glyphs, x_insert_glyphs)
2944 (rows_from_pos_range, mouse_face_from_buffer_pos)
2945 (fast_find_string_pos, mouse_face_from_string_pos)
2946 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2947 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2948 (safe_call, init_from_display_pos, handle_fontified_prop)
2949 (handle_single_display_spec, load_overlay_strings)
2950 (with_echo_area_buffer, setup_echo_area_for_printing)
2951 (display_echo_area, echo_area_display)
2952 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2953 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2954 (redisplay_window, dump_glyph_row, display_mode_line)
2955 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2956 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2957 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2958 (handle_single_display_spec, build_desired_tool_bar_string)
2959 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2960 (get_specified_cursor_type):
2961 Check that fixnums are in proper range for system types.
2962 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2963 (Flookup_image_map):
2964 Don't assume fixnums fit in int.
2965 (compare_overlay_entries):
2966 Avoid mishandling comparisons due to subtraction overflow.
2967 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2968 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2969 (handle_tool_bar_click):
2970 Use int, not unsigned, since we prefer signed and the signedness
2971 doesn't matter here.
2972 (get_next_display_element, next_element_from_display_vector):
2973 Use int, not EMACS_INT, when int is wide enough.
2974 (start_hourglass): Use duration_to_sec_usec to do proper
2975 overflow checking on durations.
2976 * xfaces.c (Fbitmap_spec_p):
2977 Check that fixnums are in proper range for system types.
2978 (compare_fonts_by_sort_order):
2979 Avoid mishandling comparisons due to subtraction overflow.
2980 (Fx_family_fonts, realize_basic_faces):
2981 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2982 (Fx_family_fonts):
2983 Don't assume fixnum fits in int.
2984 Use SAFE_ALLOCA_LISP, not alloca.
2985 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2986 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2987 (face_at_buffer_position, face_for_overlay_string)
2988 (face_at_string_position):
2989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2990 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2991 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2992 (Fx_show_tip):
2993 Check that fixnums are in proper range for system types.
2994 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2995 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2996 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2997 (Fx_change_window_property): Don't assume fixnums fit in int.
2998 * xfont.c (xfont_chars_supported):
2999 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3000 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3001 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3002 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3003 * xml.c (parse_region):
3004 * xrdb.c (magic_file_p):
3005 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3006 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3007 (x_get_local_selection, x_reply_selection_request)
3008 (x_handle_selection_request, wait_for_property_change):
3009 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3010 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3011 short is wide enough.
3012 (x_send_client_event): Don't assume fixnum fits in int.
3013 * xterm.c (x_x_to_emacs_modifiers):
3014 Don't assume EMACS_INT overflows nicely into int.
3015 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3016 may come from Lisp.
3017 (handle_one_xevent): NATNUMP can eval its arg twice.
3018 (x_connection_closed):
3019 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3020 * xterm.h: Adjust decls to match defn changes elsewhere.
3021 (struct scroll_bar): Use struct vectorlike_header
3022 rather than rolling our own approximation.
3023 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3024
c6574eb5
GM
30252012-05-25 Glenn Morris <rgm@gnu.org>
3026
3027 * lisp.mk (lisp): Update for more files being compiled now.
3028
e8d32c7e
SM
30292012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3030
48def666
SM
3031 * lread.c: Remove `read_pure' which makes no difference.
3032 (read_pure): Remove var.
3033 (unreadpure): Remove function.
3034 (readevalloop): Don't call read_list with -1 flag.
3035 (read1, read_vector): Don't test read_pure any more.
3036 (read_list): Simplify.
3037
e8d32c7e
SM
3038 * fileio.c, character.h: Minor style tweaks.
3039
4b2addb7
DA
30402012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3041
3042 * window.h (clip_changed): Remove useless declaration.
3043
584461b2
JB
30442012-05-22 Juanma Barranquero <lekktu@gmail.com>
3045
3046 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3047 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3048
34374650
PE
30492012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3050
3051 Remove src/m/*.
3052 This directory predates autoconf and is no longer needed nowadays.
3053 Move its few remaining bits of functionality to where they're needed.
3054 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3055 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3056 * m/template.h: Remove.
3057 * Makefile.in (M_FILE): Remove. All uses removed.
3058 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3059 * lisp.h (USE_LSB_TAG):
3060 * mem-limits.h (EXCEEDS_LISP_PTR):
3061 Use VAL_MAX, not VALBITS, in #if.
3062 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3063 (EMACS_UINT): Define unconditionally now.
3064 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3065 (BITS_PER_EMACS_INT): New constants, replacing
3066 what used to be in config.h, but not useful in #if.
3067 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3068 define them any more.
3069 (VAL_MAX): New macro.
3070 (VALMASK): Use it.
3071 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3072 BITS_PER_EMACS_INT, in #if.
3073 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3074 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3075 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3076 * s/ms-w32.h (DATA_START):
3077 Move here from removed file m/intel386.h.
3078 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3079 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3080
261cb4bb
PE
30812012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3082
3083 Assume C89 or later.
3084 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3085 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3086 (xrealloc):
3087 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3088 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3089 * textprop.c, tparam.c (NULL): Remove.
3090 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3091 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3092 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3093 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3094 * xterm.c (input_signal_count): Assume volatile works.
3095
ff23cd9f
KB
30962012-05-21 Ken Brown <kbrown@cornell.edu>
3097
3098 * xgselect.c (xg_select): Fix first argument in call to 'select'
3099 (bug#11508).
3100
1b170bc6
KB
31012012-05-20 Ken Brown <kbrown@cornell.edu>
3102
3103 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3104 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3105
b2f4d39f
KB
31062012-05-19 Ken Brown <kbrown@cornell.edu>
3107
3108 * xfns.c (x_in_use): Remove `static' qualifier.
3109 * xterm.h (x_in_use): Declare.
3110 * xgselect.c: Include xterm.h.
3111 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3112 and `display_arg' (bug#9754).
3113
003fdae2
PE
31142012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3115
9232a6d9
PE
3116 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3117
003fdae2
PE
3118 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3119 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3120
784b56e2
EZ
31212012-05-18 Eli Zaretskii <eliz@gnu.org>
3122
3123 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3124
3125 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3126 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3127
3128 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3129 reference to image_cache->refcount.
3130 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3131
a0a79cde
JL
31322012-05-17 Juri Linkov <juri@jurta.org>
3133
3134 * search.c (Fword_search_regexp, Fword_search_backward)
3135 (Fword_search_forward, Fword_search_backward_lax)
3136 (Fword_search_forward_lax): Move functions to isearch.el
3137 (bug#10145, bug#11381).
3138
b0572523
PE
31392012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3140
3141 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3142
9660f5fc
SM
31432012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3144
3145 * lread.c (init_obarray): Declare Qt and Qnil as special.
3146
4374de83
GM
31472012-05-14 Glenn Morris <rgm@gnu.org>
3148
3149 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 3150 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 3151
dc44c39a
PE
31522012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3153
078c97cb
PE
3154 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3155
dc44c39a
PE
3156 * unexaix.c: Port to more-recent AIX compilers.
3157 (report_error, report_error_1, make_hdr, copy_sym)
3158 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3159 Make arguments const char *, not char *, to avoid violations of C
3160 standard and to fix some AIX warnings reported by Gilles Pion.
3161
e18afed7 31622012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
3163
3164 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3165 already have overlays loaded.
3166 (handle_single_display_spec): Before returning without displaying
3167 fringe bitmap, synchronize the bidi iterator with the main display
3168 iterator, by calling iterate_out_of_display_property.
3169 (iterate_out_of_display_property): Detect buffer iteration by
3170 testing that it->string is a Lisp string.
3171 (get_next_display_element): When the current object is exhausted,
3172 and there's something on it->stack, call set_iterator_to_next to
3173 proceed with what's on the stack, instead of returning zero.
3174 (set_iterator_to_next): If called at the end of a Lisp string,
3175 proceed to consider_string_end without incrementing string
3176 position. Don't increment display vector index past the end of
3177 the display vector. (Bug#11417)
c8fb9dc6
EZ
3178 (pos_visible_p): Don't report a position visible when move_it_to
3179 stopped at the last line of window, which happens to be scanned
3180 backwards by the bidi iteration. (Bug#11464)
ac268e67 3181
e18afed7 31822012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
3183
3184 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3185 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
3186 are on a TTY, and thus unable to display on the fringes.
3187 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
3188 so we need to signal to the caller that this is a "replacing"
3189 display spec. This fixes display when the spec is invalid or we
3190 are on a TTY.
3191
e18afed7 31922012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
3193
3194 * unexaix.c (make_hdr): Fix typo in prototype.
3195 This bug broke the build on AIX. Problem reported by Gilles Pion.
3196
9d0a235a
MA
31972012-05-14 Michael Albinus <michael.albinus@gmx.de>
3198
3199 * keyboard.c (kbd_buffer_get_event): Read special events also in
3200 batch mode. (Bug#11415)
3201
9e6b06ed
GM
32022012-05-12 Glenn Morris <rgm@gnu.org>
3203
3204 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3205
c1a1d7a3
EZ
32062012-05-12 Eli Zaretskii <eliz@gnu.org>
3207
3208 * lisp.mk (lisp): Add newcomment.elc.
3209
3fe7cdc8
GM
32102012-05-12 Glenn Morris <rgm@gnu.org>
3211
3212 * Makefile.in (MKDIR_P): New, set by configure.
3213 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3214
53f7d2c0
PE
32152012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3216
3217 Remove unused function hourglass_started.
3218 * dispextern.h (hourglass_started):
3219 * w32fns.c (hourglass_started):
3220 * xdisp.c (hourglass_started): Remove.
3221
75aafb17
JB
32222012-05-10 Juanma Barranquero <lekktu@gmail.com>
3223
3224 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3225 Update dependencies.
3226
12959e8e
PE
32272012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3228
97107e2e
PE
3229 * xgselect.c (xg_select): Put maxfds+1 into a var.
3230 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3231
12959e8e
PE
3232 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3233
836d29b3
DA
32342012-05-10 Dave Abrahams <dave@boostpro.com>
3235
3236 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3237 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3238
5cb67954
MA
32392012-05-09 Michael Albinus <michael.albinus@gmx.de>
3240
3241 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3242 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3243 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3244 Initialize xd_registered_buses.
3245
3478ec45
PE
32462012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3247
b263a6b0
PE
3248 Untag more efficiently if USE_LSB_TAG.
3249 This is based on a proposal by YAMAMOTO Mitsuharu in
3250 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3251 For an admittedly artificial (nth 8000 longlist) benchmark on
3252 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3253 Emacs's overall text size by 1%.
3254 * lisp.h (XUNTAG): New macro.
3255 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3256 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3257 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3258 * eval.c (Fautoload):
3259 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3260 * frame.h (XFRAME): Use XUNTAG.
3261
3478ec45
PE
3262 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3263 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3264 Remove unportable assumptions about print widths of types like
3265 dbus_uint32_t.
3266 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3267 intptr_t when converting between pointer and integer, to avoid GCC
3268 warnings about wrong width.
3269
666b903b 32702012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3271
3272 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3273 stack for each reader_thread, instead of defaulting to 8MB
3274 determined by the linker. This avoids failures in creating
3275 subprocesses on Windows 7, see the discussion in this thread:
3276 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3277
b120cc17
JC
32782012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3279
3280 Fix up display of the *Minibuf-0* buffer in the mini window.
3281 * keyboard.c (read_char): Don't clear the echo area if there's no
3282 message to clear.
3283 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3284 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3285
9a4b36f8
MA
32862012-05-07 Michael Albinus <michael.albinus@gmx.de>
3287
3288 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3289 batch mode.
3290
e5f9458f
CY
32912012-05-06 Chong Yidong <cyd@gnu.org>
3292
3293 * lisp.mk (lisp): Update.
3294
eceeb5fc 32952012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3296
3297 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3298
71873e2b
SM
32992012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3300
3301 * data.c (PUT_ERROR): New macro.
3302 (syms_of_data): Use it. Add new error type `user-error'.
3303 * undo.c (user_error): New function.
3304 (Fprimitive_undo): Use it.
3305 * print.c (print_error_message): Adjust print style for `user-error'.
3306 * keyboard.c (user_error): New function.
3307 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3308
ab0fa4e4
PE
33092012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3310
3311 Do not limit current-time-string to years 1000..9999.
3312 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3313 (Fcurrent_time_string): Support any year that is supported by the
3314 underlying localtime representation. Don't use asctime, as it
3315 has undefined behavior for years outside the range -999..9999.
3316
7ed806a7
PE
33172012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3318
3319 Fix race conditions involving setenv, gmtime, localtime, asctime.
3320 Without this fix, interrupts could mess up code that uses these
3321 nonreentrant functions, since setting TZ invalidates existing
3322 tm_zone or tzname values, and since most of these functions return
3323 pointers to static storage.
3324 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3325 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3326 Grow the critical sections to include not just invoking
3327 localtime/gmtime, but also accessing these functions' results
3328 including their tm_zone values if any, and any related TZ setting.
3329 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3330 so that the struct tm is saved in the critical section.
3331 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3332 motivated by the fact that memory allocation needs to be outside
3333 the critical section.
3334
0c16dfed
DA
33352012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3336
3337 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3338 with RESET_INTERVAL.
3339
3340 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3341 Remove duplicated buffer name initialization.
3342
3f83ace8
JM
33432012-05-02 Jim Meyering <jim@meyering.net>
3344
3345 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3346
c7b8541e
JM
3347 * xfns.c (x_window): Use xstrdup (Bug#11375).
3348
90207a15 33492012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3350
3351 * xdisp.c (pos_visible_p): If already at a newline from the
3352 display string before the 'while' loop, don't walk back the glyphs
3353 from it3.glyph_row. Solves assertion violation when the display
3354 string begins with a newline (egg.el). (Bug#11367)
3355
b593d6a9
AH
33562012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3357
3358 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3359 Move to simple.el.
3360
4737362e
GM
33612012-05-01 Glenn Morris <rgm@gnu.org>
3362
99cf43f9
GM
3363 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3364 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3365 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3366 All were removed before 23.1.
3367
9311dcff
GM
3368 * dispnew.c: Remove HAVE_LIBNCURSES test;
3369 it is always true on relevant platforms.
3370
4d5c6349
GM
3371 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3372 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3373
4737362e
GM
3374 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3375
74dd3a6b
AS
33762012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3377
3378 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3379 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3380 Remove.
3381
13c379ee
PE
33822012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3383
3384 Do not avoid creating empty evaporating overlays (Bug#9642).
3385 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3386 That is, do not delete an evaporating overlay if it becomes
3387 empty after its bounds are adjusted to fit within its buffer.
3388 This fix caused other problems, and I'm reverting it until we get
3389 to the bottom of them.
3390
a8e7d6d7 33912012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3392
3393 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3394
a8e7d6d7 33952012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3396
3397 * xdisp.c (pos_visible_p): If the window start position is beyond
3398 ZV, start the display from buffer beginning. Prevents assertion
3399 violation in init_iterator when the minibuffer window is scrolled
3400 via the scroll bar.
3401
3402 * window.c (window_scroll_pixel_based): Likewise.
3403
a8e7d6d7 34042012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3405
3406 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3407
a8e7d6d7 34082012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3409
3410 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3411 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3412
a8e7d6d7 34132012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3414
b593d6a9
AH
3415 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3416 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3417
1c6900d9
EZ
34182012-04-26 Eli Zaretskii <eliz@gnu.org>
3419
4c3fa1d9
EZ
3420 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3421 display element, check also the underlying string or buffer
3422 character. (Bug#11341)
3423
1c6900d9
EZ
3424 * w32menu.c: Include w32heap.h.
3425 (add_menu_item): If the call to AppendMenuW (via
3426 unicode_append_menu) fails, disable Unicode menus only if we are
3427 running on Windows 9X/Me.
3428
42bf8205
AS
34292012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3430
3431 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3432 (xgetint): Add missing shift for LSB tags.
3433
b1bac16e
MR
34342012-04-24 Martin Rudalics <rudalics@gmx.at>
3435
3436 * keyboard.c (read_char): Don't wipe echo area for select window
3437 events: These might get delayed via `mouse-autoselect-window'
3438 (Bug#11304).
3439
d69621cc
JB
34402012-04-24 Juanma Barranquero <lekktu@gmail.com>
3441
3442 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3443 manipulation of :loaded-from data.
3444
02fd101b
JB
34452012-04-23 Juanma Barranquero <lekktu@gmail.com>
3446
3447 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3448 now a cons (bug#11311).
3449
888bec30
PE
34502012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3451
89a438bd
PE
3452 Do not create empty overlays with the evaporate property (Bug#9642).
3453 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3454 if it becomes empty after its bounds are adjusted to fit within
3455 its buffer. Without this fix, in a nonempty buffer (let ((o
3456 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3457 yields an empty overlay that has the evaporate property, which is
3458 not supposed to happen.
3459
1068fe4d
PE
3460 Fix minor GTK3 problems found by static checking.
3461 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3462 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3463 (struct _EmacsFixedClass, emacs_fixed_get_type):
3464 Move decls here from emacsgtkfixed.h, since they needn't be public.
3465 (emacs_fixed_get_type): Now static.
3466 (emacs_fixed_class_init): Omit unused local.
3467 (emacs_fixed_child_type): Remove; unused.
3468 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3469 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3470 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3471 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3472 (EMACS_FIXED_GET_CLASS): Remove; unused.
3473 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3474
888bec30
PE
3475 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3476 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3477
de85e130
PE
34782012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3479
d0baac98 3480 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3481 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3482 (__malloc_size_t, __malloc_ptrdiff_t):
3483 Remove. All uses removed, replaced by the definiens if needed,
3484 since we can assume C89 or better now.
3485 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3486 (protect_malloc_state, align, get_contiguous_space)
3487 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3488 (malloc_atfork_handler_child, malloc_enable_thread)
3489 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3490 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3491 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3492 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3493 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3494 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3495 Define using prototypes, not old style.
3496 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3497 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3498 (align): Don't assume that signed integer overflow wraps around.
3499 Omit unused local var.
3500 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3501 (_free_internal_nolock, memalign, mallochook, reallochook):
3502 Omit no-longer-needed casts.
3503 (valloc): Use getpagesize, not __getpagesize.
3504 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3505 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3506
de85e130
PE
3507 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3508
dcbf5805
MA
35092012-04-22 Michael Albinus <michael.albinus@gmx.de>
3510
3511 Move functions from C to Lisp. Make non-blocking method calls
3512 the default. Implement further D-Bus standard interfaces.
3513
3514 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3515 (QCdbus_request_name_allow_replacement)
3516 (QCdbus_request_name_replace_existing)
3517 (QCdbus_request_name_do_not_queue)
3518 (QCdbus_request_name_reply_primary_owner)
3519 (QCdbus_request_name_reply_in_queue)
3520 (QCdbus_request_name_reply_exists)
3521 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3522 (QCdbus_registered_serial, QCdbus_registered_method)
3523 (QCdbus_registered_signal): New Lisp objects.
3524 (XD_DEBUG_MESSAGE): Use sizeof.
3525 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3526 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3527 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3528 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3529 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3530 (xd_signature, xd_append_arg): Allow float for integer types.
3531 (xd_get_connection_references): New function.
b593d6a9
AH
3532 (xd_get_connection_address): Rename from xd_initialize.
3533 Return cached address.
dcbf5805
MA
3534 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3535 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3536 level.
3537 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3538 Return number of refcounts.
dcbf5805
MA
3539 (Fdbus_get_unique_name): Make stronger parameter check.
3540 (Fdbus_message_internal): New defun.
3541 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3542 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3543 (Fdbus_send_signal, Fdbus_register_service)
3544 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3545 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3546 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3547 (Vdbus_compiled_version, Vdbus_runtime_version)
3548 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3549 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3550 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3551 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3552 Adapt docstring.
dcbf5805 3553
52828e02
PE
35542012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3555
da05bc4c
PE
3556 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3557 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3558 Do not assume ptrdiff_t is the same width as 'int'.
3559
52828e02
PE
3560 * alloc.c: Handle unusual debugging option combinations.
3561 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3562 since the two debugging options are incompatible.
3563 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3564 is defined.
3565 (mem_init, mem_insert, mem_insert_fixup):
3566 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3567 (NEED_MEM_INSERT): Remove; no longer needed.
3568
f01769f9
LL
35692012-04-22 Leo Liu <sdl.web@gmail.com>
3570
3571 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3572
5790543d
PE
35732012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3574
3575 * sysdep.c [__FreeBSD__]: Minor cleanups.
3576 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3577 Use Emacs indenting style more consistently. Avoid some casts.
3578 Use 'double' consistently rather than mixing 'float' and 'double'.
3579
b91b7e4d
EW
35802012-04-21 Eduard Wiebe <usenet@pusto.de>
3581
b593d6a9
AH
3582 * sysdep.c (list_system_processes, system_process_attributes):
3583 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3584
6114eb15
AS
35852012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3586
3587 * lisp.mk (lisp): Update.
3588
2f38dff7
PE
35892012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3590
3591 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3592 It is never used otherwise.
3593
4ae29f89
SM
35942012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3595
3596 * print.c (print_preprocess): Only check print_depth if print-circle
3597 is nil.
3598 (print_object): Check for cycles even when print-circle is nil and
3599 print-gensym is t, but only check print_depth if print-circle is nil.
3600
f30d612a
CY
36012012-04-20 Chong Yidong <cyd@gnu.org>
3602
3603 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3604 set the status to "failed" and ensure that sentinel is run.
3605
c07a4c0b 36062012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3607
3608 * process.c (Fset_process_inherit_coding_system_flag)
3609 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3610 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3611
c07a4c0b 36122012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3613
3614 * xdisp.c (string_buffer_position_lim): Limit starting position to
3615 BEGV.
3616 (set_cursor_from_row): If called for a mode-line or header-line
3617 row, return zero immediately.
3618 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3619 farther than the first row after the header line, if any.
3620 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3621 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3622
c07a4c0b 36232012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3624
4ae29f89
SM
3625 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3626 (bug#11238).
ad3a2b41 3627
c07a4c0b 36282012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 36292012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3630
3631 configure: new option --enable-gcc-warnings (Bug#11207)
3632 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3633 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3634 (ALL_CFLAGS): Use new macros rather than old.
3635 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3636 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3637 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3638 -Wunused-result, -Wunused-variable. This should go away once
3639 the Emacs and Gnulib regex code is merged.
3640 (xmalloc, xrealloc): Now static.
3641
aba027e8
PE
36422012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3643
3644 * dired.c (Fsystem_groups): Remove unused local.
3645
e5a36063
GM
36462012-04-17 Glenn Morris <rgm@gnu.org>
3647
3648 * dired.c (Fsystem_users): Doc fix.
3649
316411f0
DA
36502012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3651
3652 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3653 (syms_of_dired): Add them.
3654
9426aba4
PE
36552012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3656
b62a57be
PE
3657 Fix minor alloc.c problems found by static checking.
3658 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3659 New extern decls, to avoid calling undeclared functions.
3660 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3661 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3662 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3663 (NEED_MEM_INSERT): New macro.
3664 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3665 Remove one incorrect comment and fix another.
b62a57be 3666
3539f31f
PE
3667 Fix minor ralloc.c problems found by static checking.
3668 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3669 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3670 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3671 (r_alloc_sbrk): Now static.
3672
a041960a
PE
3673 Improve ralloc.c interface checking.
3674 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3675 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3676 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3677 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3678 [REL_ALLOC]: ... to here, to check interface.
3679 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3680 Remove decls. This fixes an "It stinks!".
3681
9426aba4
PE
3682 * alloc.c (which_symbols): Fix alignment issue / type clash.
3683
d55c12ed
AS
36842012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3685
3686 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3687 (struct Lisp_Misc_Any): Likewise.
3688 (struct Lisp_Free): Likewise.
3689 * alloc.c (union aligned_Lisp_Symbol): Define.
3690 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3691 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3692 (union aligned_Lisp_Misc): Define.
3693 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3694 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3695 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3696
b948ce8b
PE
36972012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3698
3699 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3700 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3701 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3702 * s/netbsd.h, s/sol2-6.h:
3703 Remove definition of GC_MARK_STACK, since the default now works.
3704 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3705 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3706 no longer the default.
3707 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3708
35dc09a1 37092012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3710
35dc09a1
GM
3711 * lread.c (lisp_file_lexically_bound_p):
3712 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3713
35dc09a1
GM
37142012-04-14 Eli Zaretskii <eliz@gnu.org>
3715
3716 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3717 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3718
37192012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3720
3721 * nsterm.m (constrainFrameRect): Always constrain when there is only
3722 one screen (Bug#10962).
3723
bcd86815
KB
37242012-04-13 Ken Brown <kbrown@cornell.edu>
3725
3726 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3727
c25df26e
RT
37282012-04-13 Reuben Thomas <rrt@sc3d.org>
3729
3730 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3731
0fc59f1e
DC
37322012-04-11 Daniel Colascione <dancol@dancol.org>
3733
3734 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3735 against is gone. It's better to use vfork now so that when Cygwin
3736 gains a new, working vfork, we use it automatically (bug#10398).
3737
de8c03dc
SM
37382012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3739
3740 * window.c (save_window_save): Obey window-point-insertion-type.
3741
2f097256
GM
37422012-04-11 Glenn Morris <rgm@gnu.org>
3743
3744 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3745
453b951e
SM
37462012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3747
3748 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3749
75f1671a 37502012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3751
3752 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3753 (force_quit_count): New var.
3754 (handle_interrupt): Use it.
3755
2a8ce227
JB
37562012-04-10 Juanma Barranquero <lekktu@gmail.com>
3757
3758 * w32.c (w32_delayed_load): Record the full path of the library
3759 being loaded (bug#10424).
3760
935396c0
GM
37612012-04-09 Glenn Morris <rgm@gnu.org>
3762
05920a43
GM
3763 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3764 not just in the obarray, before snarfing them. (Bug#11036)
3765
935396c0
GM
3766 * Makefile.in ($(leimdir)/leim-list.el):
3767 Pass EMACS rather than BUILT_EMACS.
3768
a18ecafa
TZ
37692012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3770
3771 * process.c (make_process):
3772 * process.h: Add integer `gnutls_handshakes_tried' member to
3773 process struct.
3774
6bbef4e5
JC
3775 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3776 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3777
3778 * gnutls.c (gnutls_log_function2i): Convenience log function.
3779 (emacs_gnutls_read): Use new log functions,
3780 `gnutls_handshakes_tried' process member, and
3781 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3782 attempts per process (connection).
3783
b4d3bc10
CY
37842012-04-09 Chong Yidong <cyd@gnu.org>
3785
3786 * eval.c (Fuser_variable_p, user_variable_p_eh)
3787 (lisp_indirect_variable): Functions deleted.
3788 (Fdefvar): Caller changed.
3789
3790 * callint.c (Finteractive, Fcall_interactively):
3791 * minibuf.c (Fread_variable): Callers changed.
3792
70f4d973
EZ
37932012-04-09 Eli Zaretskii <eliz@gnu.org>
3794
3795 * xdisp.c (set_cursor_from_row): If the display string appears in
3796 the buffer at position that is closer to point than the position
3797 after the display string, display the cursor on the first glyph of
3798 the display string. Fixes cursor display when a 'display' text
3799 property immediately follows invisible text. (Bug#11094)
3800
cb3c2e3e
PE
38012012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3802
3803 composite.c: use 'double' consistently
3804 * composite.c (get_composition_id): Use 'double' consistently
3805 instead of converting 'float' to 'double' and vice versa; this is
3806 easier to understand and avoids a GCC warning.
3807
fd06db5d
GM
38082012-04-09 Glenn Morris <rgm@gnu.org>
3809
50fe702a
GM
3810 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3811 preparation for dumping it with emacs. (Bug#4789)
3812 (leimdir): New variable.
3813 ($(leimdir)/leim-list.el): New rule.
3814 (emacs$(EXEEXT)): Depend on leim-list.el.
3815
fd06db5d
GM
3816 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3817 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3818 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3819
55c131ee
AS
38202012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3821
3822 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3823 proper alignment.
3824
9209588f
JB
38252012-04-07 Juanma Barranquero <lekktu@gmail.com>
3826
3827 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3828 Remove unused local variable.
3829
e3fb2efb
PE
38302012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3831
3832 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3833 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3834 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3835 objects, as mark_maybe_pointer will catch them otherwise.
3836 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3837 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3838
b5385551
PE
38392012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3840
3841 Fix typo that broke non-Windows builds.
3842 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3843
9078ead6
EZ
38442012-04-07 Eli Zaretskii <eliz@gnu.org>
3845
3846 Support building on MS-Windows with libxml2.
3847
3848 * makefile.w32-in (OBJ2): Add xml.$(O).
3849 (GLOBAL_SOURCES): Add xml.c.
3850 ($(BLD)/xml.$(O)): New dependency list.
3851
3852 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3853 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3854 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3855 [!WINDOWSNT]: New macros.
3856 (init_libxml2_functions, libxml2_loaded_p): New functions.
3857 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3858 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3859 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3860 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3861 linked in).
6bbef4e5
JC
3862 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3863 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3864 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3865
3866 * emacs.c: Don't include libxml/parser.h.
3867 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3868 xmlCleanupParser directly.
3869
3870 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3871
3811fdf3
EZ
38722012-04-07 Eli Zaretskii <eliz@gnu.org>
3873
3874 * indent.c (Fvertical_motion): If there is a display string at
3875 point, use it.vpos to compute how many lines to backtrack after
3876 move_it_to point. (Bug#11133)
3877
2f8e16b2
EZ
38782012-04-06 Eli Zaretskii <eliz@gnu.org>
3879
3880 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3881 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3882 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3883 macros related to unification of CJK characters. For the details,
3884 see the discussion following the message here:
3885 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3886
3d439cd1
CY
38872012-04-04 Chong Yidong <cyd@gnu.org>
3888
3889 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3890
8bc53d00
EZ
38912012-04-01 Eli Zaretskii <eliz@gnu.org>
3892
3893 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3894 instead of alloca. (Bug#11138)
3895
3b0512a3
AS
38962012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3897
3898 * w32menu.c (is_simple_dialog): Properly check lisp types.
3899 (Bug#11141)
3900
8427ddd2
EZ
39012012-03-31 Eli Zaretskii <eliz@gnu.org>
3902
979022ef
EZ
3903 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3904 position we get to after a call to move_it_to fails the
3905 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3906 only if we wind up in a string from display property. (Bug#11063)
3907
a6b1c7cc
EZ
3908 * window.c (Fdelete_other_windows_internal): Invalidate the row
3909 and column information about mouse highlight, so that redisplay
3910 restores it after reallocating the glyph matrices. (Bug#7464)
3911
8427ddd2
EZ
3912 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3913 string comes from a `display' text property, use the buffer
3914 position of that property as if we actually saw that position in
3915 the row's glyphs.
697ba24b
EZ
3916 (move_it_by_lines): Remove the assertion that
3917 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3918 violated when there's a before-string at the beginning of a line.
3919 (Bug#11063)
8427ddd2 3920
65a0a738
EZ
39212012-03-30 Eli Zaretskii <eliz@gnu.org>
3922
3923 * xdisp.c (append_space_for_newline): If the default face was
3924 remapped, use the remapped face for the appended newline.
3925 (extend_face_to_end_of_line): Use the remapped default face for
3926 extending the face to the end of the line.
3927 (display_line): Call extend_face_to_end_of_line when the default
3928 face was remapped. (Bug#11068)
3929
581355cc
EZ
39302012-03-29 Eli Zaretskii <eliz@gnu.org>
3931
3932 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3933
e8fc049f
SM
39342012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3935
3936 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3937
4fb9a543
GM
39382012-03-27 Glenn Morris <rgm@gnu.org>
3939
3940 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3941 Doc fixes.
3942
679910f1
KH
39432012-03-26 Kenichi Handa <handa@m17n.org>
3944
3945 * dispextern.h (struct glyph): Fix previous change. Change the
3946 bit length of glyphless.ch to 25 (Bug#11082).
3947
90d49b7f
CY
39482012-03-26 Chong Yidong <cyd@gnu.org>
3949
3950 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3951 (command_loop_1): Use it; inhibit selection update for
3952 handle-select-window too (Bug#8996).
3953
f514f6f0
FP
39542012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3955
e8fc049f 3956 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3957
bf43fa51
KH
39582012-03-25 Kenichi Handa <handa@m17n.org>
3959
3960 * dispextern.h (struct glyph): Change the bit length of
3961 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3962
8a0c01dd
EZ
39632012-03-24 Eli Zaretskii <eliz@gnu.org>
3964
3965 * s/ms-w32.h (tzname): Include time.h before redirecting to
3966 _tzname. Fixes the MSVC build. (Bug#9960)
3967
7d1c3a76
AS
39682012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3969
8ed79523
AS
3970 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3971 characters.
3972
7d1c3a76
AS
3973 * xterm.c (XTread_socket): Only modify handling_signal if
3974 !SYNC_INPUT. (Bug#11080)
3975
e99a9b8b
EZ
39762012-03-23 Eli Zaretskii <eliz@gnu.org>
3977
3978 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3979 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3980 when fetching a multibyte character consumes more bytes than
3981 CHAR_BYTES returns, due to unification of CJK characters in
3982 string_char. (Bug#11073)
3983
5063c0e1
TN
39842012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3985
3986 * process.c (wait_reading_process_output): Handle pty disconnect
3987 by refraining from sending oneself a SIGCHLD (bug#10933).
3988
9f851fbd
CY
39892012-03-22 Chong Yidong <cyd@gnu.org>
3990
3991 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3992
5063c0e1 3993 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3994 Mark string as coming from a prefix property.
3995 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3996 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3997
fb5b8aca
CY
39982012-03-21 Chong Yidong <cyd@gnu.org>
3999
4000 * xfaces.c (Vface_remapping_alist): Doc fix.
4001
62356a1b
EZ
40022012-03-20 Eli Zaretskii <eliz@gnu.org>
4003
4004 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4005 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4006 Doc fixes.
62356a1b 4007
025de85b
CY
40082012-03-20 Chong Yidong <cyd@gnu.org>
4009
4010 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4011 to reflect default non-nil value of redisplay-dont-pause.
4012
4827f94e
KH
40132012-03-19 Kenichi Handa <handa@m17n.org>
4014
4015 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4016 it fit in a valid range (Bug#11003).
4017
e50a24a2
EZ
40182012-03-18 Eli Zaretskii <eliz@gnu.org>
4019
4020 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4021 that is not from display property, accept the row as a "cursor
4022 row" if one of the string's character has a non-nil `cursor'
4023 property. Fixes cursor positioning when there are newlines in
4024 overlay strings, e.g. in icomplete.el. (Bug#11035)
4025
9af5ed87
PE
40262012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4027
4028 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4029
d1f55f16
CY
40302012-03-12 Chong Yidong <cyd@gnu.org>
4031
4032 * eval.c (inhibit_lisp_code): Rename from
4033 inhibit_window_configuration_change_hook; move from window.c.
4034
4035 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4036 * window.c (run_window_configuration_change_hook)
4037 (syms_of_window): Callers changed.
4038
66c5eebd
CY
40392012-03-11 Chong Yidong <cyd@gnu.org>
4040
413df973
CY
4041 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4042
66c5eebd
CY
4043 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4044
1de11f56
CY
40452012-03-10 Chong Yidong <cyd@gnu.org>
4046
4047 * frame.c (other_visible_frames): Don't assume the selected frame
4048 is visible (Bug#10955).
4049
cae07000
SM
40502012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4051
4052 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4053
89c94350
JD
40542012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4055
4056 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4057 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4058 zero (Bug#10954).
4059
999dd333
GM
40602012-03-03 Glenn Morris <rgm@gnu.org>
4061
01a6dcc8 4062 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4063
de0100f2
EZ
40642012-03-02 Eli Zaretskii <eliz@gnu.org>
4065
4066 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4067 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4068 (redisplay_window, next_element_from_string): Fix typos in
4069 comments.
3e441275
EZ
4070 (redisplay_window): Pass to move_it_vertically the margin in
4071 pixels, not in screen lines.
de0100f2 4072
96a72ee9
GM
40732012-03-02 Glenn Morris <rgm@gnu.org>
4074
4075 * buffer.c (buffer-list-update-hook): Doc fix.
4076
312508d7
EZ
40772012-02-29 Eli Zaretskii <eliz@gnu.org>
4078
4079 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4080 push_it before setting up the iterator for the first overlay
4081 string, even if we have an empty string loaded.
4082 (next_overlay_string): If there's an empty string on the iterator
4083 stack, pop the stack. (Bug#10903)
4084
27f3c637
PE
40852012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4086
4087 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4088 Suggested by Stefan Monnier in
4089 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4090 * alloc.c (widen_to_Lisp_Object): New static function.
4091 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4092 and widening them to Lisp_Objects. This would work even if
4093 USE_LSB_TAG is defined and wide integers are used, which might
4094 happen in a future version of Emacs.
4095
3c9dfce6
CY
40962012-02-25 Chong Yidong <cyd@gnu.org>
4097
fa74b241
CY
4098 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4099 Doc fix.
4100
3c9dfce6
CY
4101 * xselect.c (Fx_selection_exists_p): Doc fix.
4102 (x_clipboard_manager_save_all): Print an informative message
4103 before saving to clipboard manager.
4104
9486df08
CY
41052012-02-24 Chong Yidong <cyd@gnu.org>
4106
4107 * keyboard.c (process_special_events): Handle all X selection
4108 requests in kbd_buffer, not just the next one (Bug#8869).
4109
f01d3321
CY
41102012-02-23 Chong Yidong <cyd@gnu.org>
4111
4112 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4113 call when setting menu-bar-lines and tool-bar-lines parameters.
4114 (unwind_create_frame_1): New helper function.
4115
4116 * window.c (inhibit_window_configuration_change_hook): New var.
4117 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4118 (syms_of_window): Initialize it.
f01d3321 4119
86b847b6
CY
41202012-02-22 Chong Yidong <cyd@gnu.org>
4121
4122 * xterm.c (x_draw_image_relief): Add missing type check for
4123 Vtool_bar_button_margin (Bug#10743).
4124
a59225b1
CY
41252012-02-21 Chong Yidong <cyd@gnu.org>
4126
4127 * fileio.c (Vfile_name_handler_alist): Doc fix.
4128
4129 * buffer.c (Fget_file_buffer): Protect against invalid file
4130 handler return value.
4131
310f5bd4
PE
41322012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4133
cb3a28cc
PE
4134 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4135 when computing $valmask.
4136
310f5bd4
PE
4137 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4138 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4139 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4140 It's useless in that case, and it can cause problems on hosts
4141 that allocate halves of EMACS_INT values separately.
4142 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4143 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4144 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4145 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4146 it avoids undefined behavior on hosts where shifting right by more
4147 than the word width has undefined behavior.
4148
2375c96a
CY
41492012-02-19 Chong Yidong <cyd@gnu.org>
4150
4151 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4152 (Funhandled_file_name_directory, Ffile_name_as_directory)
4153 (Fdirectory_file_name, Fexpand_file_name)
4154 (Fsubstitute_in_file_name): Protect against invalid file handler
4155 return values (Bug#10845).
4156
3eb49e71
EZ
41572012-02-18 Eli Zaretskii <eliz@gnu.org>
4158
4159 * .gdbinit (pitx): Fix incorrect references to fields of the
4160 iterator stack.
4161
7b926f3f
CY
41622012-02-17 Chong Yidong <cyd@gnu.org>
4163
4164 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4165
11273115
PE
41662012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4167
4168 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4169 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4170
c3a70e2b
CY
41712012-02-15 Chong Yidong <cyd@gnu.org>
4172
4173 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4174 marked as special. Also, starting docstrings with * is obsolete.
4175
0ca43699
AS
41762012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4177
4178 * gnutls.c (emacs_gnutls_write): Fix last change.
4179
2e8f3c56
LI
41802012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4181
4182 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4183 send_process.
4184
af70074f
SM
41852012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4186
4187 * keymap.c (Fsingle_key_description): Handle char ranges.
4188
95986d52
CY
41892012-02-12 Chong Yidong <cyd@gnu.org>
4190
afd83bd1
CY
4191 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4192 as that creates a dangerous corner case.
4193
95986d52
CY
4194 * window.c (Fdelete_window_internal): Invalidate the mouse
4195 highlight (Bug#9904).
4196
bd7da63e
GM
41972012-02-12 Glenn Morris <rgm@gnu.org>
4198
4199 * xselect.c (Fx_own_selection_internal)
4200 (Fx_get_selection_internal, Fx_disown_selection_internal)
4201 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4202 * nsselect.m (Fx_own_selection_internal)
4203 (Fx_disown_selection_internal, Fx_selection_exists_p)
4204 (Fx_selection_owner_p, Fx_get_selection_internal):
4205 Sync docs and argument specs with the xselect.c versions.
4206
77abcbc2
LI
42072012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4208
4209 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4210
90b671e2
EZ
42112012-02-11 Eli Zaretskii <eliz@gnu.org>
4212
1c0ca0b7
EZ
4213 * w32select.c (Fx_selection_exists_p): Sync doc string and
4214 argument list with xselect.c. (Bug#10783)
4215
4216 * w16select.c (Fx_selection_exists_p): Sync doc string and
4217 argument list with xselect.c. (Bug#10783)
90b671e2 4218
49241268
GM
42192012-02-10 Glenn Morris <rgm@gnu.org>
4220
4221 * fns.c (Fsecure_hash): Doc fix.
4222
f998bbe7 42232012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
4224
4225 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4226
0992bd9c
CY
42272012-02-07 Chong Yidong <cyd@gnu.org>
4228
4229 * buffer.c (Fbuffer_local_variables)
4230 (buffer_lisp_local_variables): Handle unbound vars correctly;
4231 don't let Qunbound leak into Lisp.
4232
af008560
GM
42332012-02-07 Glenn Morris <rgm@gnu.org>
4234
dd605cc4
GM
4235 * image.c (Fimagemagick_types): Doc fix.
4236
af008560
GM
4237 * image.c (imagemagick-render-type): Change it from a lisp object
4238 to an integer. Move the doc here from the lisp manual.
4239 Treat all values not equal to 0 the same.
4240
1449fa1d
CY
42412012-02-06 Chong Yidong <cyd@gnu.org>
4242
4243 * doc.c (store_function_docstring): Avoid applying docstring of
4244 alias to base function (Bug#2603).
4245
3723ec07
AS
42462012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4247
4248 * .gdbinit (pp1, pv1): Remove redundant defines.
4249 (pr): Use pp.
4250
79c1cc1e
CY
42512012-02-04 Chong Yidong <cyd@gnu.org>
4252
4253 * nsterm.m: Declare a global (Bug#10694).
4254
d7f29f8e
EZ
42552012-02-04 Eli Zaretskii <eliz@gnu.org>
4256
cae07000
SM
4257 * w32.c (get_emacs_configuration_options):
4258 Include --enable-checking, if specified, in the return value.
d7f29f8e 4259
3b95a6f9
MR
42602012-02-04 Martin Rudalics <rudalics@gmx.at>
4261
4262 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4263 after rounding frame sizes. (Bug#9723)
4264
d6fa96a6
EZ
42652012-02-04 Eli Zaretskii <eliz@gnu.org>
4266
4267 * keyboard.c (adjust_point_for_property): Don't position point
4268 before BEGV. (Bug#10696)
4269
df0b2940
PE
42702012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4271
4272 Handle overflow when computing char display width (Bug#9496).
4273 * character.c (char_width): Return EMACS_INT, not int.
4274 (char_width, c_string_width): Check for overflow when
4275 computing the width; this is possible now that individual
4276 characters can have unbounded width. Problem introduced
4277 by merge from Emacs 23 on 2012-01-19.
4278
6bee44d6
MA
42792012-02-02 Michael Albinus <michael.albinus@gmx.de>
4280
4281 * dbusbind.c (Fdbus_register_method): Mention the return value
4282 :ignore in the docstring.
4283
44f92739
GM
42842012-02-02 Glenn Morris <rgm@gnu.org>
4285
1b9f60cc
GM
4286 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4287
44f92739
GM
4288 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4289 Unconditionally set to t. (Bug#10673)
4290 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4291 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4292 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4293
c5d3843c
KH
42942012-02-02 Kenichi Handa <handa@m17n.org>
4295
4296 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4297 0, do not call append_composite_glyph.
4298
159462d4 42992012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4300
4301 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4302 NULL (Bug#6988).
4303 (x_produce_glyphs): If the component of a composition is a null
4304 string, set it->pixel_width to 1 to avoid zero-width glyph.
4305
78cef877
EZ
43062012-02-01 Eli Zaretskii <eliz@gnu.org>
4307
4308 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4309 first 2 arguments are identical. This makes inserting large
4310 output from a subprocess an order of magnitude faster on
4311 MS-Windows, where all sbrk'ed memory is always contiguous.
4312
97897668
GM
43132012-01-31 Glenn Morris <rgm@gnu.org>
4314
4315 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4316 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4317 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4318
31fd3586
GM
43192012-01-29 Glenn Morris <rgm@gnu.org>
4320
4321 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4322
0e24a8b2
CY
43232012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4324
4325 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4326
cc0adcb0
CY
43272012-01-28 Chong Yidong <cyd@gnu.org>
4328
4329 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4330
acc28cb9
CY
43312012-01-26 Chong Yidong <cyd@gnu.org>
4332
9c69cfb7
CY
4333 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4334
acc28cb9
CY
4335 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4336 repeat counts (Bug#10507).
4337
48da7392
GM
43382012-01-26 Glenn Morris <rgm@gnu.org>
4339
4340 * lread.c (syms_of_lread): Doc fix.
4341
14af5f7f
CY
43422012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4343
4344 * coding.c (encode_designation_at_bol): Change return value to
4345 EMACS_INT.
4346
0b21c100
CY
43472012-01-25 Chong Yidong <cyd@gnu.org>
4348
4349 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4350
3c2907f7
CY
43512012-01-21 Chong Yidong <cyd@gnu.org>
4352
4353 * floatfns.c (Fcopysign): Make the second argument non-optional,
4354 since nil is not allowed anyway.
4355
959ad23f
AS
43562012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4357
4358 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4359 (send_process): Likewise.
4360
34a02f46
MR
43612012-01-19 Martin Rudalics <rudalics@gmx.at>
4362
4363 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4364 (Vwindow_persistent_parameters): Do not use Qstate.
4365 Rewrite doc-strings.
34a02f46 4366
1259009a 43672012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4368
4369 * character.c (char_width): New function.
70d4fdf6
GM
4370 (Fchar_width, c_string_width, lisp_string_width):
4371 Use char_width (Bug#9496).
25ed9e61 4372
6a6ee00d
MR
43732012-01-16 Martin Rudalics <rudalics@gmx.at>
4374
4375 * window.c (Vwindow_persistent_parameters): New variable.
4376 (Fset_window_configuration, save_window_save): Handle persistent
4377 window parameters.
4378
c85efaf7
EZ
43792012-01-14 Eli Zaretskii <eliz@gnu.org>
4380
4381 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4382 thrashing the stack of the thread. (Bug#9087)
4383
5944709e
PE
43842012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4385
4386 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4387
e71f5d99
EZ
43882012-01-11 Eli Zaretskii <eliz@gnu.org>
4389
4390 * xdisp.c (rows_from_pos_range): Handle the case where the
4391 highlight ends on a newline. (Bug#10464)
4392 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4393 he end column for display of highlight that ends on a newline
4394 before a R2L line.
4395
ce316182
GM
43962012-01-11 Glenn Morris <rgm@gnu.org>
4397
4398 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4399 from load-path also when installation-directory is nil. (Bug#10208)
4400
5b43da69
GM
44012012-01-10 Glenn Morris <rgm@gnu.org>
4402
74cc8ff9
GM
4403 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4404
7d8d6e4e
GM
4405 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4406 Update template values to be closer to their typical values these days.
5b43da69 4407
a0db8d43
EZ
44082012-01-09 Eli Zaretskii <eliz@gnu.org>
4409
4410 * xdisp.c (rows_from_pos_range): Accept additional argument
4411 DISP_STRING, and accept any glyph in a row whose object is that
4412 string as eligible for mouse highlight. Fixes mouse highlight of
4413 display strings from overlays. (Bug#10464)
4414
9a0115ab 44152012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4416
b9110d6a 4417 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4418 * fileio.c (auto_saving_dir_umask): New static var.
4419 (Fmake_directory_internal): Use it.
4420 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4421 creating the directory. The old code temporarily assigns
4422 too-generous permissions to the directory.
4423 (do_auto_save_eh): Clear it.
b9110d6a 4424 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4425 that the var is always cleared.
4426
6c1bd3f3
EZ
44272012-01-07 Eli Zaretskii <eliz@gnu.org>
4428
4429 * search.c (scan_buffer): Pass character positions to
4430 know_region_cache, not byte positions. (Bug#6540)
4431
069d2b50
L
44322012-01-07 LynX <_LynX@bk.ru> (tiny change)
4433
4434 * w32.c (sys_rename): Report EXDEV when rename of a directory
4435 fails because the target is on another logical disk. (Bug#10284)
4436
75bf0d33
DB
44372012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4438
4439 * xterm.c (x_embed_request_focus): New function.
4440
4441 * xterm.h: Add prototype.
4442
4443 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4444
1c6e5a32
GM
44452012-01-05 Glenn Morris <rgm@gnu.org>
4446
4447 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4448
651e947e
EZ
44492012-01-01 Eli Zaretskii <eliz@gnu.org>
4450
4451 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4452 Load gnutls_transport_set_lowat only if GnuTLS version is below
4453 2.11.1.
4454 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4455 GnuTLS versions below 2.11.1.
4456
3778cdd8
AL
44572011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4458
4459 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4460 to the doc string advising against its use for altering the way
4461 windows are scrolled.
4462
0e5317f7
KH
44632011-12-28 Kenichi Handa <handa@m17n.org>
4464
4465 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4466 coding-system ASCII compatible only when it does not produce BOM
4467 on encoding (Bug#10383).
4468
93d5ca1f
JD
44692011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4470
4471 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4472 can scroll.
4473 (create_and_show_popup_menu): Always use menu_position_func for
4474 Gtk3 (Bug#10361).
4475
ca22b785
AS
44762011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4477
4478 * callint.c (Fcall_interactively): Don't truncate prompt string.
4479
d048e1e6
EZ
44802011-12-23 Eli Zaretskii <eliz@gnu.org>
4481
4482 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4483 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4484 resumed from there (after widening). (Bug#10360)
d048e1e6 4485
5ccaba1f
JD
44862011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4487
4488 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4489
204ee57f
JD
44902011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4491
b81d40f0
JB
4492 * nsterm.m (x_free_frame_resources):
4493 Release f->output_data.ns->miniimage.
204ee57f
JD
4494 (ns_index_color): Fix indentation. Do not retain
4495 color_table->colors[i].
4496
4497 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4498 before returning.
4499
4500 * nsfns.m (x_set_background_color): Assign return value from
4501 ns_index_color to face-background instead of NSColor*.
4502 (ns_implicitly_set_icon_type): Fix indentation.
4503 Change assignment in for loop to comparison.
4504
4505 * emacs.c (ns_pool): New variable.
4506 (main): Assign ns_pool.
4507 (Fkill_emacs): Call ns_release_autorelease_pool.
4508
4509 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4510 autorelease fdesc, release fdAttrs and tdict.
4511 (ns_get_covering_families): Release charset.
4512 (ns_findfonts): Release NSFontDescriptor created with new.
4513 (ns_uni_to_glyphs): Fix indentation.
4514 (setString): Release attrStr before assigning new value.
4515
c803b2b7
JD
45162011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4517
678f4426
JD
4518 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4519 and NS_IMPL_COCOA.
4520 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4521 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4522
cd394be1 45232011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4524
5fecd5fc
JD
4525 * nsterm.m (ns_term_init): Subscribe for notifications
4526 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4527 to method trackingNotification in EmacsMenu.
4528
4529 * nsmenu.m (trackingMenu): New variable.
3771cb17 4530 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4531 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4532 from Aquamacs (Bug#7030).
678f4426
JD
4533
45342011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4535
c803b2b7
JD
4536 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4537 (symbol_to_nsstring): Fix indentation.
4538 (ns_symbol_to_pb): New function.
cae07000
SM
4539 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4540 (Fns_rotate_cut_buffers_internal): Remove.
4541 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4542 Fns_store_cut_buffer_internal.
4543 (ns_get_foreign_selection, Fx_own_selection_internal)
4544 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4545 (Fns_get_selection_internal, Fns_store_selection_internal):
4546 Use ns_symbol_to_pb and check if return value is nil.
4547 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4548 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4549 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4550 renamed to Sns_store_selection_internal.
4551 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4552 and remove this function.
4553 (ns_handle_selection_clear): Remove, never used.
4554 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4555 here.
4556
e1b01a3a
KB
45572011-12-17 Ken Brown <kbrown@cornell.edu>
4558
4559 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4560 GID is unknown (Bug#10257).
4561
2adb6e85
PE
45622011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4563
4564 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4565 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4566 which caused a build failure on GNU/Linux IA-64. This problem was
4567 introduced by my 2011-10-07 patch.
4568
d1d7b339
JL
45692011-12-15 Juri Linkov <juri@jurta.org>
4570
4571 * image.c (imagemagick_error): New function. (Bug#10112)
4572 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4573 Use `imagemagick_error' where ImageMagick functions return
4574 `MagickFalse'.
4575 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4576 proper order.
4577
100d5755
KH
45782011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4579
4580 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4581 fill background (Bug#8992).
4582
454592a6
MR
45832011-12-13 Martin Rudalics <rudalics@gmx.at>
4584
4585 * window.c (Vwindow_combination_resize)
4586 (Vwindow_combination_limit): Use t instead of non-nil in
4587 doc-strings.
61d4b438
MR
4588 (Vrecenter_redisplay): Add first sentence of doc-string on
4589 separate line.
53524d93 4590 (Frecenter): Fix doc-string typo.
454592a6 4591
3633e3aa
KH
45922011-12-11 Kenichi Handa <handa@m17n.org>
4593
4594 * coding.c (Funencodable_char_position): Pay attention to the
4595 buffer text relocation (Bug#9389).
4596
7b9d523a 45972011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4598
7b9d523a
JD
4599 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4600 gtk_init (Bug#10100).
4601
b73189c6
EZ
46022011-12-10 Eli Zaretskii <eliz@gnu.org>
4603
4604 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4605 IT->string is nil. (Bug#10263)
4606
f7dfe5d6
JD
46072011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4608
83faebb4
JD
4609 * nsterm.h (x_free_frame_resources): Declare.
4610
f7dfe5d6
JD
4611 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4612 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4613
4614 * nsterm.h (ns_get_defaults_value): Declare.
4615
4616 * nsterm.m (ns_default): Call ns_get_defaults_value.
4617
7cd4e72c
EZ
46182011-12-09 Eli Zaretskii <eliz@gnu.org>
4619
4620 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4621 (Bug#10170)
4622
b34d7317
YM
46232011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4624
4625 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4626 that where the value of an _OBJC_* symbol points to is in the .bss
4627 section (Bug#10240).
4628
76470ad1
KH
46292011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4630
4631 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4632 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4633
745fff94
KH
46342011-12-08 Kenichi Handa <handa@m17n.org>
4635
4636 * ftfont.c (get_adstyle_property): Fix previous change
4637 (Bug#10233).
4638
6e44397c
JB
46392011-12-07 Juanma Barranquero <lekktu@gmail.com>
4640
4641 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4642 dirs from the default value of EMACSLOADPATH (bug#10208).
4643
7efa6272
GM
46442011-12-07 Glenn Morris <rgm@gnu.org>
4645
4646 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4647 installation and source directories as well. (Bug#10208)
4648
f6fc4d87
CY
46492011-12-06 Chong Yidong <cyd@gnu.org>
4650
4651 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4652
2bf26180
GM
46532011-12-06 Glenn Morris <rgm@gnu.org>
4654
4655 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4656 as an error, not just -1. (Bug#10217)
4657
3a6ad4f0
CY
46582011-12-05 Chong Yidong <cyd@gnu.org>
4659
4660 * keyboard.c (process_special_events): New function.
4661 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4662
75a3b399
PE
46632011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4664
4665 * coding.c (encode_designation_at_bol): Don't use uninitialized
4666 local variable (Bug#9318).
4667
c3c9e25e
KH
46682011-12-05 Kenichi Handa <handa@m17n.org>
4669
4670 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4671 return Qnil (Bug#8046, Bug#10193).
4672
5eb05ea3
KH
46732011-12-05 Kenichi Handa <handa@m17n.org>
4674
4675 * coding.c (encode_designation_at_bol): New args charbuf_end and
4676 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4677 (coding_set_source): Return how many bytes coding->source was
4678 relocated.
4679 (coding_set_destination): Return how many bytes
4680 coding->destination was relocated.
4681 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4682 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4683
46842011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4685
4686 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4687 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4688 macro (Bug#9318).
4689
46902011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4691
4692 The following changes are to fix Bug#9318.
4693
a79703f5 4694 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4695 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4696 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4697 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4698
7dbda6df
JB
46992011-12-05 Juanma Barranquero <lekktu@gmail.com>
4700
4701 * lisp.h (process_quit_flag): Fix external declaration.
4702
6d5eb5b0
SM
47032011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4704
4705 Don't macro-inline non-performance-critical code.
4706 * eval.c (process_quit_flag): New function.
4707 * lisp.h (QUIT): Use it.
4708
a0c3fad0
JD
47092011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4710
4711 * nsfns.m (get_geometry_from_preferences): New function.
4712 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4713
6c07aac2
AS
47142011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4715
4716 * emacs.c (Qkill_emacs): Define.
4717 (syms_of_emacs): Initialize it.
4718 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4719 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4720 (quit_throw_to_read_char): Add parameter `from_signal'.
4721 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4722 * lisp.h (QUIT): Call Fkill_emacs if requested.
4723
c052ead4
JD
47242011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4725
4726 * widget.c (update_wm_hints): Return if wmshell is null.
4727 (widget_update_wm_size_hints): New function.
4728
4729 * widget.h (widget_update_wm_size_hints): Declare.
4730
4731 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4732 widget_update_wm_size_hints (Bug#10104).
4733
9e49252b
EZ
47342011-12-03 Eli Zaretskii <eliz@gnu.org>
4735
4736 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4737 before a newline, prepare the bidi iterator for consuming the
4738 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4739 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4740
02b16839
JL
47412011-12-02 Juri Linkov <juri@jurta.org>
4742
4743 * search.c (Fword_search_regexp): New Lisp function created from
4744 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4745 (Fword_search_backward, Fword_search_forward)
4746 (Fword_search_backward_lax, Fword_search_forward_lax):
4747 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4748 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4749
0068070e
SM
47502011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4751
4752 * fileio.c (Finsert_file_contents): Move after-change-function call
4753 to before the "handled:" label, since all "goto handled" appear in
4754 cases where the *-change-functions have already been properly called
4755 (bug#10117).
4756
3360a3fc
AS
47572011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4758
4759 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4760 waiting for input. (Bug#10169)
4761
73d6c093
EZ
47622011-11-30 Eli Zaretskii <eliz@gnu.org>
4763
4764 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4765 verifies glyph row's hash code--we have just reallocated the
4766 glyphs, so their contents can be complete garbage. (Bug#10164)
4767
febe6bea
JB
47682011-11-30 Juanma Barranquero <lekktu@gmail.com>
4769
4770 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4771
801a4313
EZ
47722011-11-30 Eli Zaretskii <eliz@gnu.org>
4773
4774 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4775 attributes are tested _before_ calling verify_row_hash, to protect
4776 against GCC re-ordering of the tests. (Bug#10164)
4777
2b56b87e
JD
47782011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4779
4780 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4781
4782 * xterm.c (handle_one_xevent): Only set async_visible and friends
4783 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4784 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4785 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4786
dbf31225
PE
47872011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4788
4789 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4790 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4791 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4792 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4793 All uses changed to use GCPRO1 etc.
4794 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4795 Revert to old implementation (i.e., before 2011-03-11).
4796
1305621b
YM
47972011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4798
4799 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4800 of scroll runs so as to avoid assigning disabled bogus rows and
4801 unnecessary graphics copy operations.
4802
8c9afb46
EZ
48032011-11-27 Eli Zaretskii <eliz@gnu.org>
4804
4805 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4806 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4807 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4808 (malloc, free, realloc, calloc): Redirect to e_* only when
4809 compiling Emacs.
4810
4811 * lisp.h (GCTYPEBITS): Move before first use.
4812 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4813 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4814 this macro definition.
4815
4816 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4817 _MSC_VER.
4818
54e9e3bf
JD
48192011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4820
6d5eb5b0
SM
4821 * gtkutil.c (xg_create_frame_widgets):
4822 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4823 present with Gtk+ 2.0.
4824
83aca1cb
PE
48252011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4826
4827 * fileio.c (Finsert_file_contents): Undo previous change; see
4828 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4829
5b76caa4
PE
48302011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4831
4832 Rename locals to avoid shadowing.
4833 * fileio.c (Finsert_file_contents):
4834 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4835 * process.c (wait_reading_process_output):
4836 Rename inner 'proc' to 'p' to avoid shadowing.
4837 Indent for consistency with usual Emacs style.
4838
8c535114
EZ
48392011-11-25 Eli Zaretskii <eliz@gnu.org>
4840
4841 * xdisp.c (redisplay_window): If cursor row is not fully visible
4842 after recentering, and scroll-conservatively is set to a large
4843 number, scroll window by a few more lines to make the cursor fully
4844 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4845 (start_display): Don't move to the next line if the display should
4846 start at a newline that is part of a display vector or an overlay
4847 string. (Bug#10119)
8c535114 4848
fa4fdb5c
JL
48492011-11-24 Juri Linkov <juri@jurta.org>
4850
4851 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4852 after the `MagickPingImage' call. (Bug#10112)
4853
90ec88df
CY
48542011-11-23 Chong Yidong <cyd@gnu.org>
4855
4856 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4857
56e2e794
MR
48582011-11-23 Martin Rudalics <rudalics@gmx.at>
4859
4860 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4861 making another buffer current. (Bug#10114)
4862
b6e64c41
GM
48632011-11-23 Glenn Morris <rgm@gnu.org>
4864
4865 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4866
6b21de18
CY
48672011-11-23 Chong Yidong <cyd@gnu.org>
4868
4869 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4870 using it (Bug#5984).
4871
b12cd789
EZ
48722011-11-22 Eli Zaretskii <eliz@gnu.org>
4873
4874 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4875 and header-lines, as they don't have one computed for them.
4876 (Bug#10098)
4877
4878 * .gdbinit (prow): Make displayed values more self-explaining.
4879 Add row's hash code.
4880
261b6fd4
LMI
48812011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4882
4883 * process.c (wait_reading_process_output): Fix asynchrounous
4884 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4885 (wait_reading_process_output): Add comment and URL.
261b6fd4 4886
e7cfd277
JD
48872011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4888
4889 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4890
a9b9b7f5
CY
48912011-11-21 Chong Yidong <cyd@gnu.org>
4892
4893 * window.c (Fnext_window, Fprevious_window): Doc fix.
4894
b0d15b4f
SM
48952011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4896
4897 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4898
fe7a3057
JB
48992011-11-20 Juanma Barranquero <lekktu@gmail.com>
4900
4901 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4902
d2999b1a
MR
49032011-11-20 Martin Rudalics <rudalics@gmx.at>
4904
4905 * window.c (Fset_window_combination_limit): Rename argument
4906 STATUS to LIMIT.
4907 (Vwindow_combination_limit): Remove "status" from doc-string.
4908
d5ff9cd0
AS
49092011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4910
4911 * m/ibms390.h: Remove.
4912 * m/ibms390x.h: Don't include "ibms390.h".
4913
a5bb9bd3
SM
49142011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4915
4916 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4917 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4918
cd1181db
JB
49192011-11-20 Juanma Barranquero <lekktu@gmail.com>
4920
4921 * casetab.c (Fset_case_table):
4922 * charset.c (Fcharset_after): Fix typos.
4923
615a3b8d 49242011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4925
17e845af
PE
4926 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4927 Otherwise, valgrind does not work on some platforms.
4928 Problem reported by Andreas Schwab in
6a0bf43d
PE
4929 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4930 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4931 is set, removing the need for VIRT_ADDRESS_VARIES.
4932 (PURE_P): Use a more-efficient implementation that needs just one
4933 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4934 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4935 to 4 (xorl, subq, cmpq, setbe).
4936 * alloc.c (pure): Always extern now, since that's the
4937 VIRT_ADDR_VARIES behavior.
4938 (PURE_POINTER_P): Use a single comparison, not two, for
4939 consistency with the new puresize.h.
4940 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4941 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4942 Remove VIRT_ADDR_VARIES no longer needed.
4943
f8fe6f96
EZ
49442011-11-19 Eli Zaretskii <eliz@gnu.org>
4945
4946 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4947 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4948 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4949 behave as if the cursor position were at the window margin.
4950
4951 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4952 and the cursor position is out of bounds, behave as if the cursor
4953 position were at the window margin. (Bug#10075)
4954
df05a53c
CY
49552011-11-18 Chong Yidong <cyd@gnu.org>
4956
4957 * window.c (Fwindow_combination_limit): Make first argument
4958 non-optional, since it is meaningless for live windows like the
4959 selected window.
61ccba97 4960
2071918e
DA
49612011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4962
4963 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4964
b50a28de
SM
49652011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4966
4967 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4968 (graft_intervals_into_buffer): Simplify.
4969
015137db
EZ
49702011-11-18 Eli Zaretskii <eliz@gnu.org>
4971
4972 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4973 hash values of the two rows.
4974 (copy_row_except_pointers): Preserve the used[] arrays and the
4975 hash values of the two rows. (Bug#10035)
68c95424 4976 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4977
4978 * xdisp.c (row_hash): New function, body extracted from
4979 compute_line_metrics.
4980 (compute_line_metrics): Call row_hash, instead of computing the
4981 hash code inline.
4982
4983 * dispnew.c (verify_row_hash): Call row_hash for computing the
4984 hash code of a row, instead of duplicating code from xdisp.c.
4985
4986 * dispextern.h (row_hash): Add prototype.
4987
a2addb04
TH
49882011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4989
4990 * frame.c (delete_frame): Don't delete the terminal when the last
4991 X frame is closed if emacs is built with GTK toolkit.
4992
df85d315
JB
49932011-11-17 Juanma Barranquero <lekktu@gmail.com>
4994
4995 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4996
a0c2d0ae
MR
49972011-11-17 Martin Rudalics <rudalics@gmx.at>
4998
4999 * window.c (Vwindow_splits): Rename to
5000 Vwindow_combination_resize. Suggested by Juri Linkov.
5001 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5002 of Vwindow_splits.
5003
58179cce
JB
50042011-11-16 Juanma Barranquero <lekktu@gmail.com>
5005
7877f373
JB
5006 * nsfns.m (Fns_font_name):
5007 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5008
b6f67890
MR
50092011-11-16 Martin Rudalics <rudalics@gmx.at>
5010
5011 * window.h (window): Rename slot "nest" to "combination_limit".
5012 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5013 (Fset_window_nest): Rename to Fset_window_combination_limit.
5014 (Vwindow_nest): Rename to Vwindow_combination_limit.
5015 (recombine_windows, make_parent_window, make_window)
5016 (Fsplit_window_internal, saved_window)
5017 (Fset_window_configuration, save_window_save): Rename all
5018 occurrences of window_nest to window_combination_limit.
5019
c7015153
JB
50202011-11-15 Juanma Barranquero <lekktu@gmail.com>
5021
5022 * image.c (imagemagick_load_image): Fix typo.
5023
322ad6ec
EZ
50242011-11-14 Eli Zaretskii <eliz@gnu.org>
5025
5026 * xdisp.c (display_line): Move the call to
5027 highlight_trailing_whitespace before the call to
5028 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5029 faces of all the glyphs to compute ROW's hash value.
5030 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5031
f067b8ec
JB
50322011-11-14 Juanma Barranquero <lekktu@gmail.com>
5033
5034 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5035 just return (bug#10044).
5036
1e5b2111
EZ
50372011-11-12 Eli Zaretskii <eliz@gnu.org>
5038
7ef3cbd5
EZ
5039 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5040 with user-defined heap size. Bump the default size of the temacs
5041 heap to 27MB, to avoid memory warning when running temacs.
5042 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5043
1e5b2111
EZ
5044 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5045 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5046 (verify_row_hash) [XASSERTS]: New function.
5047 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5048 that the hash value of glyph rows is correct.
1e5b2111 5049
89d61221
MR
50502011-11-12 Martin Rudalics <rudalics@gmx.at>
5051
5052 * window.h (window): Remove splits slot.
5053 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5054 (Fdelete_other_windows_internal, make_parent_window)
5055 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5056 (Fset_window_configuration, save_window_save): Don't deal with
5057 split status of windows.
5058 (saved_window): Remove splits slot.
5059 (Vwindow_splits): Rewrite doc-string.
5060
97f18cc8
JD
50612011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5062
5063 * xfns.c (unwind_create_frame):
5064 * nsfns.m (unwind_create_frame):
5065 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5066 Vframe_list (Bug#9999).
5067
22a648b4
DA
50682011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5069
0b381c7e 5070 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5071
659afede
KH
50722011-11-11 Kenichi Handa <handa@m17n.org>
5073
5074 * callproc.c (Fcall_process): Set the member dst_multibyte of
5075 process_coding.
5076
9ac0394b
KH
50772011-11-11 Johan Bockgård <bojohan@gnu.org>
5078
5079 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5080 avoid a crash (bug#9496).
5081
2fbdc249
CY
50822011-11-09 Chong Yidong <cyd@gnu.org>
5083
5084 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5085 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5086
ac6b1f81
PE
50872011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5088
5089 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5090
09db192c
PE
50912011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5092
5093 Avoid some portability problems by eschewing 'extern inline' functions.
5094 The trivial performance wins aren't worth the portability hassles; see
5095 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5096 et seq.
5097 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5098 (window_box_width, window_box_left, window_box_left_offset)
5099 (window_box_right, window_box_right_offset): Undo previous change,
5100 by removing the "extern"s.
5101 * intervals.c (adjust_intervals_for_insertion)
5102 (adjust_intervals_for_deletion): Undo previous change,
5103 making these static again.
5104 (offset_intervals, temp_set_point_both, temp_set_point)
5105 (copy_intervals_to_string): No longer inline.
5106 * xdisp.c (window_text_bottom_y, window_box_width)
5107 (window_box_height, window_box_left_offset)
5108 (window_box_right_offset, window_box_left, window_box_right)
5109 (window_box): No longer inline.
5110
105216ed
CY
51112011-11-08 Chong Yidong <cyd@gnu.org>
5112
5113 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5114 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5115 Signal an error if not a live window.
105216ed
CY
5116 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5117 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5118
ae9e237f
JB
51192011-11-07 Juanma Barranquero <lekktu@gmail.com>
5120
5121 * lisp.h (syms_of_abbrev): Remove declaration.
5122 Reported by CHENG Gao <chenggao@royau.me>.
5123
c7aa8333
EZ
51242011-11-07 Eli Zaretskii <eliz@gnu.org>
5125
5126 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5127 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5128 of temacs in GUI mode.
5129
be7f5545
MR
51302011-11-07 Martin Rudalics <rudalics@gmx.at>
5131
5132 * window.h: Declare delete_all_child_windows instead of
5133 delete_all_subwindows.
5134 * window.c (Fwindow_nest, Fset_window_nest)
5135 (Fset_window_new_total, Fset_window_new_normal)
5136 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5137 (delete_all_subwindows): Rename to delete_all_child_windows.
5138 (Fdelete_other_windows_internal, Fset_window_configuration):
5139 Call delete_all_child_windows instead of delete_all_subwindows.
5140 * frame.c (delete_frame): Call delete_all_child_windows instead
5141 of delete_all_subwindows.
5142
ca78dc43
PE
51432011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5144
5145 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5146 This is also needed for porting to any host where GC_MARK_STACK is
5147 not GC_MAKE_GCPROS_NOOPS.
5148 (which_symbols): Use it.
5149
a0241d01
KH
51502011-11-07 Kenichi Handa <handa@m17n.org>
5151
5152 * coding.c (coding_set_destination): Check coding->src_pos only
5153 when coding->src_object is a buffer (bug#9910).
5154
5155 * process.c (send_process): Set the member src_multibyte of coding
5156 to 0 (bug#9911) when sending a unibyte text.
5157
5158 * callproc.c (Fcall_process): Set the member src_multibyte of
5159 process_coding to 0 (bug#9912).
5160
a64bfdfa 51612011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
5162
5163 * xmenu.c (cleanup_widget_value_tree): New function.
5164 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5165 calling free_menubar_widget_value_tree directly (Bug#9830).
5166
cb41b32a
PE
51672011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5168
5169 Fix some portability problems with 'inline'.
5170 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5171 (window_box_width, window_box_left, window_box_left_offset)
5172 (window_box_right, window_box_right_offset): Declare extern.
5173 Otherwise, these inline functions do not conform to C99 and
5174 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5175 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5176 * intervals.c (adjust_intervals_for_insertion)
5177 (adjust_intervals_for_deletion): Now extern, because otherwise the
5178 extern inline functions 'offset_intervals' couldn't refer to it.
5179 (static_offset_intervals): Remove.
5180 (offset_intervals): Rewrite using the old contents of
5181 static_offset_intervals. The old version didn't conform to C99
5182 because an extern inline function contained a reference to an
5183 identifier with static linkage.
5184
b7041366
AS
51852011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5186
5187 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5188 GC.
5189
88a37c4d
EZ
51902011-11-06 Eli Zaretskii <eliz@gnu.org>
5191
5192 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5193 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5194 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5195 return Qleft_to_right.
5196
49745b39
CY
51972011-11-06 Chong Yidong <cyd@gnu.org>
5198
5199 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5200 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5201 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5202 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5203 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5204 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5205 (Fwindow_vscroll): Doc fix.
5206 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5207 argument, since it makes no sense to pass a live window and for
5208 consistency with window-child.
5209
1f05cd82
CS
52102011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5211
5212 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5213 support MSVC.
5214
22610910
JR
52152011-11-05 Jason Rumney <jasonr@gnu.org>
5216
5217 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5218 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5219 fonts (Bug#6029).
5220 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5221 bitwise arithmetic preventing use of unicode-sip and non-truetype
5222 opentype fonts.
5223
a06776b2
EZ
52242011-11-05 Eli Zaretskii <eliz@gnu.org>
5225
3ad924ba
EZ
5226 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5227 "emacs"-only part.
5228
a06776b2
EZ
5229 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5230 initialization code to keep similarity to xfns.c after changes
5231 from 2011-11-05.
5232
c9e7db78
JD
52332011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5234
a97f8f3f
JD
5235 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5236 (unwind_create_frame): New function (Bug#9943).
5237 (Fx_create_frame): Restructure code to be more similar to the one in
5238 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5239 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5240 Move terminal->reference_count++ just before making the frame official
5241 (Bug#9943).
5242
5243 * nsterm.m (x_free_frame_resources): New function.
5244 (x_destroy_window): Move code to x_free_frame_resources.
5245
c9e7db78 5246 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
5247 (Fx_create_frame, x_create_tip_frame):
5248 Move terminal->reference_count++ just before making the frame
75f1671a 5249 official. Move initialization of image_cache_refcount and
c9e7db78
JD
5250 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5251
a6fc3b5c
EZ
52522011-11-05 Eli Zaretskii <eliz@gnu.org>
5253
5254 Support MSVC build with newer versions of Visual Studio.
5255 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5256 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5257 nt/gmake.defs.
5258
5259 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5260 which are not supported by MSVC.
5261 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5262 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5263 bitfields.
5264 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5265 types in bitfields.
5266 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5267
5268 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5269
58179cce 52702011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5271
5272 Support MSVC build with newer versions of Visual Studio.
5273 * w32.c: Don't include w32api.h for MSVC.
5274 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5275
5276 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5277 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5278 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5279 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5280 e_* cousins.
5281 (alloca) [_MSC_VER]: Define to _alloca.
5282
5283 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5284
5285 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5286
a58c13ed
EZ
52872011-11-04 Eli Zaretskii <eliz@gnu.org>
5288
5289 * xdisp.c (note_mouse_highlight): If either of
5290 previous/next-single-property-change returns nil, treat that as
5291 the beginning or the end of the buffer. (Bug#9955)
5292
fe0b6370
JD
52932011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5294
a58c13ed 5295 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5296 label is not null (Bug#9951).
5297 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5298 may be NULL.
5299
89bd5ee1
EZ
53002011-11-04 Eli Zaretskii <eliz@gnu.org>
5301
5302 * window.c (Fwindow_body_size): Mention in the doc string that the
5303 return value is in frame's canonical units. (Bug#9949)
5304
84c3edb9
EZ
53052011-11-03 Eli Zaretskii <eliz@gnu.org>
5306
4e2fb5c7
EZ
5307 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5308
84c3edb9 5309 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5310 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5311 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5312
bc17a887
EZ
53132011-11-01 Eli Zaretskii <eliz@gnu.org>
5314
5315 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5316 Don't stop backward scan on the continuation glyph, even though
5317 its CHARPOS is positive.
6d5eb5b0
SM
5318 (mouse_face_from_buffer_pos, note_mouse_highlight):
5319 Rename cover_string to disp_string.
bc17a887 5320
4ee88440
MR
53212011-11-01 Martin Rudalics <rudalics@gmx.at>
5322
5323 * window.c (temp_output_buffer_show): Don't use
5324 Vtemp_buffer_show_specifiers.
5325 (Vtemp_buffer_show_specifiers): Remove unused variable.
5326
c2ff3c02
EZ
53272011-10-30 Eli Zaretskii <eliz@gnu.org>
5328
5329 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5330 past the beginning of the current glyph matrix.
5331
58179cce 53322011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5333
5334 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5335 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5336 HAVE_GTK3 (Bug#9869).
b77a6a7f 5337
3b574623
JD
5338 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5339 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5340
b77a6a7f
JD
5341 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5342
5343 * xterm.c: Declare x_handle_net_wm_state to return int.
5344 (handle_one_xevent): Check if we are iconified but don't have
5345 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5346 (get_current_wm_state): Return non-zero if not hidden,
5347 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5348 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5349 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5350 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5351
196e41e4
PE
53522011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5353
5354 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5355 so that this new function doesn't get optimized away by a
5356 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5357
021f2e1a
AS
53582011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5359
5360 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5361
8b058d44
EZ
53622011-10-29 Eli Zaretskii <eliz@gnu.org>
5363
5364 Fix the `xbytecode' command.
5365 * .gdbinit (xprintbytestr): New command.
b50a28de 5366 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5367 (xbytecode): Print the byte-code string as well.
5368
4452fb80
EZ
53692011-10-29 Kim Storm <storm@cua.dk>
5370
8b058d44
EZ
5371 * alloc.c (which_symbols): New function.
5372
21b72067
AS
53732011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5374
5375 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5376 line. (Bug#9903)
5377
83ed7b5c
GM
53782011-10-29 Glenn Morris <rgm@gnu.org>
5379
5380 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5381 Not clear what it was for, and it causes various bugs. (Bug#9839)
5382
5a7a728b
EZ
53832011-10-28 Eli Zaretskii <eliz@gnu.org>
5384
5385 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5386 possible random value that matches one of those tested as
5387 condition to clear the mouse face.
5388
d3d0842f
CY
53892011-10-28 Chong Yidong <cyd@gnu.org>
5390
5391 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5392
31b39d13
DN
53932011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5394
5395 * window.c (make_window): Initialize phys_cursor_on_p.
5396
9aba6043
SM
53972011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5398
5399 * lisp.h (struct Lisp_Symbol): Update comments.
5400
c20992f4
JB
54012011-10-28 Juanma Barranquero <lekktu@gmail.com>
5402
5403 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5404
db4f02f2
EZ
54052011-10-28 Eli Zaretskii <eliz@gnu.org>
5406
5407 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5408 <oslsachem@gmail.com> for helping to debug this.
5409
5410 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5411 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5412 (g_b_init_get_glyph_outline_w): New static variables.
5413 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5414 (GetGlyphOutlineW_Proc): New typedefs.
5415 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5416 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5417 New functions.
5418 (w32font_open_internal, compute_metrics):
5419 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5420 instead of calling the "wide" APIs directly.
5421
5422 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5423
5424 * w32.h (syms_of_w32font): Add prototype.
5425
87e68db4
JB
54262011-10-27 Juanma Barranquero <lekktu@gmail.com>
5427
5428 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5429 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5430 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5431 (Fmove_to_window_line): Doc fix.
5432
435c1d67
CY
54332011-10-27 Chong Yidong <cyd@gnu.org>
5434
5435 * process.c (make_process): Set gnutls_state to NULL.
5436
5437 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5438 non-NULL, regardless of GNUTLS_INITSTAGE.
5439 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5440 an error. Set process slots as soon as we allocate them.
5441
5442 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5443
9c6c6f49
CY
54442011-10-27 Chong Yidong <cyd@gnu.org>
5445
9aba6043
SM
5446 * gnutls.c (emacs_gnutls_deinit): New function.
5447 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5448 (Fgnutls_deinit, Fgnutls_boot): Use it.
5449
5450 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5451 (deactivate_process): Call emacs_gnutls_deinit.
5452
657d08d3
JB
54532011-10-27 Juanma Barranquero <lekktu@gmail.com>
5454
5455 * image.c (x_create_x_image_and_pixmap):
5456 * w32.c (sys_rename, w32_delayed_load):
5457 * w32font.c (fill_in_logfont):
5458 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5459
5430d399
JB
54602011-10-26 Juanma Barranquero <lekktu@gmail.com>
5461
5462 * w32fns.c (w32_default_color_map): New function,
5463 extracted from Fw32_default_color_map.
a7ef684b 5464 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5465
fe0055fa
PE
54662011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5467
5468 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5469
e6346438
SM
54702011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5471
5472 * keyboard.c (test_undefined): New function (bug#9751).
5473 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5474
e112cc37
ET
54752011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5476
5477 * sysdep.c (init_sys_modes): Fix the check for the controlling
5478 terminal (Bug#6649).
5479
7b5d6677
EZ
54802011-10-20 Eli Zaretskii <eliz@gnu.org>
5481
5482 * dispextern.h (struct bidi_it): New member next_en_type.
5483
5484 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5485 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5486 current character, check also for next_en_type being WEAK_EN.
5487 (bidi_resolve_weak): Don't enter the expensive loop if the current
5488 position is before next_en_pos. Record the bidi type of the first
5489 non-ET, non-BN character we find, in addition to its position.
5490 (bidi_level_of_next_char): Invalidate next_en_type when
5491 next_en_pos is over-stepped.
5492
7da0b018
PE
54932011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5494
5495 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5496 * editfns.c: Rewrite current-time-zone so that it invokes
5497 the equivalent of (format-time-string "%Z") to get the time zone name.
5498 This fixes a bug when the time zone name contains characters that
5499 need converting from the system time locale to Emacs internal format.
5500 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5501 that patch fixed format-time-string to do the conversion, but
5502 I forgot to fix current-time-zone.
5503 (format_time_string): New function, containing most of
5504 what Fformat_time_string used to contain.
5505 (Fformat_time_string): Rewrite in terms of format_time_string.
5506 This doesn't change this function's behavior.
5507 (current-time-zone): Rewrite to use format_time_string.
5508 This fixes the bug reported by Michael Schierl in
5509 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5510 Jason Rumney's 2007-06-07 change worked around this bug, but
5511 didn't fix it.
5512 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5513
8547b010
EZ
55142011-10-19 Eli Zaretskii <eliz@gnu.org>
5515
5516 * xdisp.c (start_display): If the character at POS is displayed
5517 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5518 (try_window_reusing_current_matrix): If a line ends in a display
5519 vector or the next line starts in a display vector, continue
5520 redrawing the window even though the character position of
5521 start_row was reached.
8547b010
EZ
5522 (Bug#9771, part 2)
5523
4e948d15
CY
55242011-10-18 Chong Yidong <cyd@gnu.org>
5525
5526 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5527 with nobreak-char-display too.
5528
4787455f
EZ
55292011-10-18 Eli Zaretskii <eliz@gnu.org>
5530
5531 Fix part 3 of bug#9771.
5532 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5533 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5534 non-neutral characters if the current character is a paragraph
5535 separator (a.k.a. Newline). This avoids running the same
5536 expensive loop twice, once when we consume the preceding newline
5537 and the other time when the line actually needs to be displayed.
5538 Avoid the loop when we see neutrals on the base embedding level
5539 following a character whose directionality is the same as the
5540 paragraph's. This avoids running the expensive loop when a line
5541 ends in a long sequence of neutrals, like control characters.
5542 Add assertion against STRONG_AL type. Slightly rearrange code
5543 that determines the type of a neutral given the first non-neutral
5544 that follows it.
5545 (bidi_level_of_next_char): Set next_en_pos to zero when
5546 invalidating its info.
5547
2c91f553
EZ
55482011-10-17 Eli Zaretskii <eliz@gnu.org>
5549
5550 * xdisp.c (push_display_prop): Determine whether to record string
5551 or buffer position by IT->string, not by IT->method. Allow
5552 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5553 (move_it_vertically_backward): Don't look for character position
5554 immediately after the newline when in a continuation line.
5555 (Bug#9771, part 1)
2c91f553 5556
c7b08b0d
MR
55572011-10-15 Martin Rudalics <rudalics@gmx.at>
5558
5559 * window.c (coordinates_in_window): Rewrite and delabelize
5560 vertical border check. (Bug#5357) (Bug#9618)
5561
6b02f655
SM
55622011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5563
5564 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5565 errors in XSetWindowBorder (bug#9310).
5566
81d40c92
DA
55672011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5568
5569 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5570 avoid crash when xmalloc overrun checking is enabled.
5571
d4172c3b
EZ
55722011-10-13 Eli Zaretskii <eliz@gnu.org>
5573
5574 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5575 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5576 cursor motion with <left> and <right> arrow keys.
5577
5578 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5579 some callers set that themselves.
5580
b00eea75
EZ
55812011-10-12 Eli Zaretskii <eliz@gnu.org>
5582
5583 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5584 display string and the previous row comes from the same string and
5585 is empty. (Bug#9739) (Bug#9738)
5586
8fe012c4
SM
55872011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5588
5589 * doc.c (get_doc_string): Encode file name (bug#9735).
5590
0074aef2
EZ
55912011-10-12 Eli Zaretskii <eliz@gnu.org>
5592
79beb178
EZ
5593 * bidi.c (bidi_level_of_next_char):
5594 * xdisp.c (get_visually_first_element): Remove old incorrect
5595 comments regarding the Unicode Line Separator character.
5596
0074aef2
EZ
5597 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5598
6e4b3fbe
DA
55992011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5600
5601 * alloc.c (Fgc_status): Do not access beyond zombies array
5602 boundary if nzombies > MAX_ZOMBIES.
5603 * alloc.c (dump_zombies): Add missing format specifier.
5604
0324f3af
PE
56052011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5606
b5525cac
PE
5607 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5608 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5609
0324f3af
PE
5610 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5611 Some packages use them to denote characters with modifiers.
5612
e9b5f888
AS
56132011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5614
5615 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5616 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5617 matching a pp-number. Rename parameter var to var1.
5618
127827c0
SM
56192011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5620
5621 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5622
c8fd3bd0
GM
56232011-10-08 Glenn Morris <rgm@gnu.org>
5624
5625 * callint.c (Fcall_interactively): Give a more explicit error for the
5626 'c' case with a non-character input. (Bug#8479)
5627
352ec8ff
EZ
56282011-10-08 Eli Zaretskii <eliz@gnu.org>
5629
03669ccb
EZ
5630 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5631 lines.
7061c986
EZ
5632 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5633 lines that are hscrolled on the left.
03669ccb 5634
352ec8ff
EZ
5635 * dispnew.c (buffer_posn_from_coords): Account for a possible
5636 presence of header-line. (Bug#4426)
5637
a66cfb1c
SM
56382011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5639
6b02f655
SM
5640 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5641 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5642
7c5ee88e
PE
56432011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5644
5645 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5646 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5647 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5648 this makes Emacs dump core during garbage collection on rare
5649 occasions. sizeof is obviously inferior to offsetof here, so
5650 stick with offsetof.
5651 (GC_POINTER_ALIGNMENT): New macro.
5652 (mark_memory): Omit 3rd (offset) arg; caller changed.
5653 Don't assume EMACS_INT alignment is the same as pointer alignment.
5654
df1bbe5b
SM
56552011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5656
5657 * keyboard.c (read_key_sequence_remapped): New var.
5658 (read_key_sequence): Compute remapping in the right buffer.
5659 (command_loop_1): Use read_key_sequence's remapping directly.
5660
51553db6
SM
56612011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5662
32c1fffd
SM
5663 * dired.c (file_name_completion): Don't expand file name.
5664 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5665 before checking file name handler.
5666
51553db6
SM
5667 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5668 they've been requested explicitly (bug#9591).
5669
b6bd1599 56702011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5671
5672 * keymap.c (Fsingle_key_description): Use make_specified_string
5673 instead of build_string to build string from push_key_description.
5674 (Bug#5193)
5675
f701dc2a
PE
56762011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5677
4222c55d
PE
5678 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5679 This fixes a Y2038 bug on 64-bit hosts.
5680 * buffer.c (reset_buffer):
5681 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5682 (Fclear_buffer_auto_save_failure):
5683 Use 0, not -1, to represent an unset failure time, since time_t
5684 might not be signed.
5685
f701dc2a
PE
5686 Remove dependency on glibc malloc internals.
5687 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5688 Move back here from lisp.h, but with their new implementations.
5689 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5690 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5691 * charset.c (charset_table_init): New static var.
5692 (syms_of_charset): Use it instead of xmalloc. This removes a
5693 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5694 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5695 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5696 Move back to alloc.c.
5697 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5698 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5699
9ceebf39
JD
57002011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5701
5702 * nsterm.m (windowDidResize): Call x_set_window_size only when
5703 ns_in_resize is true. Otherwise set pixelwidth/height and
5704 call change_frame_size (Bug#9628).
5705
cb993c58
PE
57062011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5707
3930c88b
PE
5708 Port --enable-checking=all to Fedora 14 x86-64.
5709 * charset.c (syms_of_charset): Also account for glibc malloc's
5710 internal overhead when calculating the initial malloc maximum.
5711
cb993c58
PE
5712 Port --enable-checking=all to Fedora 14 x86.
5713 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5714 Move to lisp.h.
5715 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5716 (overrun_check_realloc, overrun_check_free):
5717 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5718 That way, xmalloc returns a properly-aligned pointer even if
5719 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5720 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5721 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5722 into account when calculating the initial malloc maximum.
5723 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5724 Move here from alloc.c, so that charset.c can use it too.
5725 Properly align; the old code wasn't right for common 32-bit hosts
5726 when configured with --enable-checking=all.
5727 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5728 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5729
31bed486
EZ
57302011-09-29 Eli Zaretskii <eliz@gnu.org>
5731
04c70788 5732 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5733 use EDOM.
5734
fbcaa2f3
EZ
57352011-09-28 Eli Zaretskii <eliz@gnu.org>
5736
5737 * xdisp.c (compute_display_string_end): If there's no display
5738 string at CHARPOS, return -1.
5739
5740 * bidi.c (bidi_fetch_char): When compute_display_string_end
5741 returns a negative value, treat the character as a normal
5742 character not covered by a display string. (Bug#9624)
5743
a239d4e9
JB
57442011-09-28 Juanma Barranquero <lekktu@gmail.com>
5745
5746 * lread.c (Fread_from_string): Fix typo in docstring.
5747
88652fd5
EZ
57482011-09-27 Eli Zaretskii <eliz@gnu.org>
5749
5750 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5751 newline, reseat the iterator instead of bidi-iterating there one
5752 character at a time. (Bug#9610)
32c1fffd
SM
5753 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5754 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5755
ed497dd4
AS
57562011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5757
5758 * lread.c (readevalloop): Use correct code for NBSP.
5759 (read1): Likewise. (Bug#9608)
5760
b2bf61aa
MA
57612011-09-25 Michael Albinus <michael.albinus@gmx.de>
5762
5763 * dbusbind.c (Fdbus_register_signal): When service is not
5764 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5765
32bbb17c
GM
57662011-09-25 Glenn Morris <rgm@gnu.org>
5767
5768 * buffer.c (truncate-lines): Doc fix.
5769
94e0933e
CY
57702011-09-24 Chong Yidong <cyd@stupidchicken.com>
5771
5772 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5773 (Fset_window_next_buffers): Doc fix.
5774
cddde921
GM
57752011-09-24 Glenn Morris <rgm@gnu.org>
5776
5777 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5778
1260aef1
PE
57792011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5780
25b4bfa0
PE
5781 Fix minor problems found by static checking.
5782 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5783 * indent.c (Fvertical_motion): Fix == vs = typo.
5784
e3cbd34b
EZ
57852011-09-24 Eli Zaretskii <eliz@gnu.org>
5786
a66cfb1c
SM
5787 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5788 Default value is now t. Doc fix.
6bf7006f 5789
e3cbd34b 5790 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5791 logic when moving up, not only when moving down. Fix the
e3cbd34b 5792 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5793 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5794
5795 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5796 CHARPOS is covered by a display string which includes newlines.
5797 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5798 is covered by a display string with embedded newlines.
5799
a3de0cbd
MA
58002011-09-24 Michael Albinus <michael.albinus@gmx.de>
5801
5802 * dbusbind.c (Fdbus_register_signal): Add match rule to
5803 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5804 (Fdbus_register_method, Vdbus_registered_objects_table):
5805 Fix docstring.
a3de0cbd 5806
b260039d
JM
58072011-09-24 Jim Meyering <meyering@redhat.com>
5808
32c1fffd 5809 do not ignore write error for any output size
b260039d
JM
5810 The previous change was incomplete.
5811 While it makes emacs --batch detect the vast majority of stdout
5812 write failures, errors were still ignored whenever the output size is
5813 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5814 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5815 && echo FAIL: ignored write error
5816 FAIL: ignored write error
5817 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5818 && echo FAIL: ignored write error
5819 FAIL: ignored write error
5820 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5821
8eca8a7c
AS
58222011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5823
5824 * emacs.c (Fkill_emacs): In noninteractive mode exit
5825 non-successfully if a write error occurred on stdout. (Bug#9574)
5826
3341db62
EZ
58272011-09-21 Eli Zaretskii <eliz@gnu.org>
5828
5829 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5830 the xassert test.
5831
5832 * dispextern.h (struct it): Update the comment documenting what
5833 can it->OBJECT be.
5834
8c203dbf
EZ
58352011-09-20 Eli Zaretskii <eliz@gnu.org>
5836
5837 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5838 a display string, extend search for cursor position to end of row.
5839 (find_row_edges): If the row ends in a newline from a display
5840 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5841 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5842 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5843 non-empty line. Fixes confusing cursor motion with arrow keys at
5844 the beginning of a line that starts with whitespace.
8c203dbf 5845
a4824228
LMI
58462011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5847
5848 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5849 (bug#9493).
5850
33ed493b
CY
58512011-09-18 Chong Yidong <cyd@stupidchicken.com>
5852
5853 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5854 boolean (Bug#9154).
5855
56cd55c8
EZ
58562011-09-18 Eli Zaretskii <eliz@gnu.org>
5857
5858 * xdisp.c (display_line): Record maximum and minimum buffer
5859 positions even if no glyphs were produced (e.g., by a zero-width
5860 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5861 buffer positions that will be removed from the glyph row because
5862 they don't fit.
c02dcedf
EZ
5863 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5864 column is beyond frame width: don't subtract 1 "pixel" when
5865 computing width of the stretch.
3e62b7e0
EZ
5866 (reseat_at_next_visible_line_start): Undo the change made on
5867 2011-09-17 that saved paragraph information and restored it after
5868 the call to `reseat'. (Bug#9545)
56cd55c8 5869
5ed99d36 58702011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5871
5872 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5873 and turn window cursor on if cleared (Bug#9415).
5874
5ed99d36 58752011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5876
5877 * search.c (boyer_moore): Take unibyte characters from pattern
5878 literally. (Bug#9458)
5879
9bade7b2
EZ
58802011-09-18 Eli Zaretskii <eliz@gnu.org>
5881
5882 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5883
e5e9d610
PE
58842011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5885
87e4427a
PE
5886 Fix minor problem found by static checking.
5887 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5888 initialized, to pacify gcc -Wuninitialized.
5889
e5e9d610
PE
5890 * fileio.c: Report proper errno when syscall falls.
5891 (Finsert_file_contents): Save and restore errno,
5892 so that report_file_error outputs the correct diagnostic.
5893 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5894
a1674f0b
EZ
58952011-09-18 Eli Zaretskii <eliz@gnu.org>
5896
5897 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5898
fbfb6dd4
EZ
58992011-09-17 Eli Zaretskii <eliz@gnu.org>
5900
5901 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5902 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5903
bb187662
EZ
59042011-09-17 Eli Zaretskii <eliz@gnu.org>
5905
1137e8b8 5906 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5907 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5908
5909 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5910 (bidi_find_paragraph_start): Search back for paragraph beginning
5911 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5912 (bidi_move_to_visually_next): Only trigger paragraph-related
5913 computations when the last character is a newline or at EOB, not
5914 just any NEUTRAL_B. (Bug#9470)
5915
bb187662
EZ
5916 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5917 truncated lines if point is covered by a display string. (Bug#9524)
5918
2e621251
PE
59192011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5920
5921 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5922 (cons_to_x_long): New function.
5923 (lisp_data_to_selection_data): Use it. Correct the test for
5924 short-versus-long data; it was negated. Break out of vector
5925 loop, for efficiency, when a long datum is discovered.
5926
91a15bc6
SM
59272011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5928
5929 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5930
b41c3a35
EZ
59312011-09-16 Eli Zaretskii <eliz@gnu.org>
5932
5933 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5934 GCC PR/17406) by declaring this function with external scope.
5935
7812ba2d
PE
59362011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5937
5938 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5939 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5940
cf7edc2a
AS
59412011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5942
5943 * editfns.c (Fformat): Correctly handle text properties on "%%".
5944
bd01620e
EZ
59452011-09-15 Eli Zaretskii <eliz@gnu.org>
5946
5947 * xterm.c (x_draw_composite_glyph_string_foreground):
5948 * w32term.c (x_draw_composite_glyph_string_foreground):
5949 * term.c (encode_terminal_code):
5950 * composite.c (composition_update_it, get_composition_id):
5951 * xdisp.c (get_next_display_element)
5952 (fill_composite_glyph_string): Add comments about special meaning
5953 of TAB characters in a composition.
5954
a02719a3
PE
59552011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5956
5957 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5958 This occurs when processing a multibyte format.
5959 Problem reported by Wolfgang Jenker.
a02719a3 5960
72589a3c
JB
59612011-09-15 Johan Bockgård <bojohan@gnu.org>
5962
5963 * xdisp.c (try_cursor_movement): Only check for exact match if
5964 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5965
1c14176c
PE
59662011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5967
5968 Remove unused external symbols.
5969 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5970 * xdisp.c (calc_pixel_width_or_height): Now static.
5971 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5972 * indent.c (check_display_width):
5973 * w32term.c: Fix comment to match code.
5974 * xterm.c, xterm.h (x_catching_errors): Remove.
5975
d2eea5b5
PE
59762011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5977
5978 * xselect.c: Use signed conversions more consistently (Bug#9498).
5979 (selection_data_to_lisp_data): Assume incoming selection data are
5980 signed integers, not unsigned. This is to be consistent with
5981 outgoing selection data, which was modified to use signed integers
5982 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5983 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5984 expects long, not unsigned long.
5985
46888499
EZ
59862011-09-14 Eli Zaretskii <eliz@gnu.org>
5987
5988 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5989 computation of loop end. Reported by Johan Bockgård
5990 <bojohan@gnu.org>.
5991
ef8ef9fb
CY
59922011-09-13 Chong Yidong <cyd@stupidchicken.com>
5993
5994 * frame.c (Fother_visible_frames_p): Function deleted.
5995
fa819fed
EZ
59962011-09-12 Eli Zaretskii <eliz@gnu.org>
5997
5998 * indent.c (compute_motion): Process display vector front to back
5999 rather than the other way around. (Bug#2496)
6000
2ba8e008
SM
60012011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6002
6003 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6004
20f53c69
CY
60052011-09-11 Chong Yidong <cyd@stupidchicken.com>
6006
6007 * minibuf.c (Fread_from_minibuffer): Doc fix.
6008
d562d7a4
EZ
60092011-09-11 Eli Zaretskii <eliz@gnu.org>
6010
6011 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6012 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6013
1c4d7f3d
LMI
60142011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6015
6016 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6017 value for non-existent files.
6018
b885bf36
EZ
60192011-09-11 Eli Zaretskii <eliz@gnu.org>
6020
6021 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6022 set its "size" to -1. This will set the modtime_size field of
6023 the corresponding buffer to -1, which is what
6024 verify-visited-file-modtime expects for files that do not exist.
6025 (Bug#9139)
6026
6612f0bf
PE
60272011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6028
6029 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6030 here ...
6031 * lisp.h: ... from here. push_key_description is no longer
6032 defined in keyboard.c, so its declaration should not be in
6033 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6034 logically belongs with push_key_description.
6035
dfb3f755
PE
60362011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6037
6038 * buffer.h: Include <sys/types.h> instead of <time.h>.
6039 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6040 Problem reported by Herbert J. Skuhra.
6041
3134906c
LMI
60422011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6043
6044 * xml.c (parse_region): Make the parsing work for
6045 non-comment-starting XML files again (bug#9144).
6046
8d903f4e
AS
60472011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6048
6049 * image.c (gif_load): Fix calculation of bottom and right corner.
6050 (Bug#9468)
6051
80ad64f4
EZ
60522011-09-10 Eli Zaretskii <eliz@gnu.org>
6053
6054 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6055 redisplay in small windows.
6056
208a048d
EZ
60572011-09-09 Eli Zaretskii <eliz@gnu.org>
6058
6059 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6060
9b1c252e
MR
60612011-09-08 Martin Rudalics <rudalics@gmx.at>
6062
6063 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6064 Operate on live windows only.
6065
2949f33b
JB
60662011-09-08 Juanma Barranquero <lekktu@gmail.com>
6067
6068 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6069
e08dcafd
EZ
60702011-09-07 Eli Zaretskii <eliz@gnu.org>
6071
6072 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6073 only under bidi iteration.
6074
115b96bd
JD
60752011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6076
6077 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6078
c8199d0f
PE
60792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6080
6081 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6082 Without this fix, the command to link temacs failed due to an
6083 undefined symbol __builtin_isnan. This is because
6084 /usr/include/iso/math_c99.h #defines isnan(x) to
6085 __builtin_isnan(x), but the bundled gcc, which identifies itself
6086 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6087 a __builtin_isnan.
6088 * floatfns.c (isnan): #undef, and then #define to a clone of
6089 what's in data.c.
6090 (Fisnan): Always define, since it's always available now.
6091 (syms_of_floatfns): Always define isnan at the Lisp level.
6092
e39b275c 60932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6094
6095 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6096
b2db44d9 60972011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6098
f4af5137 6099 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6100 The previous code assumed that file offsets (off_t values) fit in
6101 EMACS_INT variables, which is not true on typical 32-bit hosts.
6102 The code messed up by falsely reporting buffer overflow in cases
6103 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6104 when "big" contains more than 2**29 bytes, even though this
6105 inserts just one byte and does not overflow the buffer.
6106 (Finsert_file_contents): Store file offsets as off_t
6107 values, not as EMACS_INT values. Check for overflow when
6108 converting between EMACS_INT and off_t. When checking for
6109 buffer overflow or for overlap, take the offsets into account.
6110 Don't use EMACS_INT for small values where int suffices.
6111 When checking for overlap, fix a typo: ZV was used where
6112 ZV_BYTE was intended.
6113 (Fwrite_region): Don't assume off_t fits into 'long'.
6114 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6115
ecfc0a49
MA
61162011-09-05 Michael Albinus <michael.albinus@gmx.de>
6117
6118 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6119
6511acf2 61202011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6121
0999621a 6122 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6123
6124 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6125 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6126 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6127 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6128 (modify_event_symbol): Do not assume that the length of
6129 name_alist_or_stem is safe to alloca and fits in int.
6130 (Fexecute_extended_command): Likewise for function name and binding.
6131 (Frecursion_depth): Wrap around reliably on integer overflow.
6132 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6133 since some callers pass EMACS_INT values.
6134 (Fsingle_key_description): Don't crash if symbol name contains more
6135 than MAX_ALLOCA bytes.
6136 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6137 (get_minibuffer): Arg is now EMACS_INT, not int.
6138 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6139 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6140 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6141
2be7d702
PE
6142 * dbusbind.c (signature_cat): New function.
6143 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
6144 Do not overrun buffer; instead, report string overflow.
6145
9d1df220
PE
6146 * dispnew.c (add_window_display_history): Don't overrun buffer.
6147 Truncate instead; this is OK since it's just a log.
6148
33ef5c64
PE
6149 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6150 even if the time zone offset is outlandishly large.
6151 Don't mishandle offset == INT_MIN.
6152
66c6fdd5
PE
6153 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6154 when creating daemon; the previous buffer-overflow check was incorrect.
6155
d749b01b
PE
6156 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6157 which has the guts of the old verror function.
6158
b5cd1905
PE
6159 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6160 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6161
6e1a67fb
PE
6162 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6163 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 6164 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 6165 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
6166 length of string rather than counting it via multiple sprintfs;
6167 that's simpler and more reliable.
c21721cc
PE
6168 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6169 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6170 sprintf, in case result does not fit in int.
6171
c57b67fc
PE
6172 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6173 (fontset_from_font): Print it.
6174
8a401434
PE
6175 * frame.c (tty_frame_count): Now printmax_t, not int.
6176 (make_terminal_frame, set_term_frame_name): Print it.
6177 (x_report_frame_params): In X, window IDs are unsigned long,
6178 not signed long, so print them as unsigned.
6179 (validate_x_resource_name): Check for implausibly long names,
6180 and don't assume name length fits in 'int'.
6181 (x_get_resource_string): Don't blindly alloca invocation name;
6182 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6183 not fit in int.
6184
6e1a67fb
PE
6185 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6186 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
6187 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6188
0df02bf3
PE
6189 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6190 Use esprintf, not sprintf, in case result does not fit in int.
6191
48e30793
PE
6192 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6193 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6194 it as a large positive number.
6195 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6196 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6197
a66ff6d8
PE
6198 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6199 in case result does not fit in int.
6200
aca216ff
PE
6201 * print.c (float_to_string): Detect width overflow more reliably.
6202 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6203 buffer overrun. Don't assume list length fits in 'int'. Treat
6204 print length of 0 as 0, not as infinity; to be consistent with other
6205 uses of print length in this function. Don't overflow print length
6206 index. Don't assume hash table size fits in 'long', or that
6207 vectorlike size fits in 'unsigned long'.
6208
31c286f7
PE
6209 * process.c (make_process): Use printmax_t, not int, to format
6210 process-name gensyms.
6211
55e5faa1
PE
6212 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6213
80f2e268
PE
6214 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6215 to avoid potential buffer overrun.
6216
670741ab
PE
6217 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6218 if X resource line is longer than 512 bytes.
6219
b7163a50
PE
6220 * xfns.c (x_window): Make sprintf buffer a bit bigger
6221 to avoid potential buffer overrun.
6222
ae58ff1f
PE
6223 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6224
c43c8a6a
PE
6225 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6226
3f8236f4
PE
62272011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6228
53e9fe90 6229 Integer overflow fixes for scrolling, etc.
6511acf2
PE
6230 Without these, Emacs silently mishandles large integers sometimes.
6231 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
6232 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6233
6511acf2
PE
6234 * xdisp.c (try_window_id): Check Emacs fixnum range before
6235 converting to 'int'.
806add1d 6236
6511acf2 6237 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
6238 Check that an Emacs fixnum is in range before assigning it to 'int'.
6239 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6240 values converted from Emacs fixnums.
6241 (Frecenter): Don't wrap around a line count if it is out of 'int'
6242 range; instead, treat it as an extreme value.
6243 (Fset_window_configuration, compare_window_configurations):
6244 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6245
6511acf2
PE
6246 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6247 that can exceed INT_MAX. Check that EMACS_INT value is in range
6248 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
6249 (match_limit): Don't assume that a fixnum can fit in 'int'.
6250
6511acf2 6251 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
6252 exceed INT_MAX.
6253
6511acf2 6254 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6255 (Fvertical_motion): Don't wrap around LINES values that don't fit
6256 in 'int'. Instead, treat them as extreme values. This is good
6257 enough for windows, which can't have more than INT_MAX lines anyway.
6258
fcb901a7
LMI
62592011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6260
0f2f6b6d
LMI
6261 * Require libxml/parser.h to avoid compilation warning.
6262
fcb901a7
LMI
6263 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6264
6265 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6266 since this reportedly can destroy thread storage.
6267
6e20a0d4
CY
62682011-08-30 Chong Yidong <cyd@stupidchicken.com>
6269
6270 * syntax.c (find_defun_start): Update all cache variables if
6271 exiting early (Bug#9401).
6272
148ae00e
EZ
62732011-08-30 Eli Zaretskii <eliz@gnu.org>
6274
f6cfbd8f
EZ
6275 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6276
148ae00e
EZ
6277 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6278 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6279 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6280
6281 * term.c (tty_append_glyph): New function.
6282 (produce_stretch_glyph): Static function and its prototype deleted.
6283
a66cfb1c
SM
6284 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6285 Add prototypes.
148ae00e 6286
c4a07a4c
PE
62872011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6288
6289 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6290 when checking :margin (Bug#9390).
6291 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6292 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6293 so that the name doesn't mislead. All uses changed.
6294
6bc8cd65
JB
62952011-08-28 Johan Bockgård <bojohan@gnu.org>
6296
6297 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6298 set_tty_hooks.
6299
dca4927e
EZ
63002011-08-27 Eli Zaretskii <eliz@gnu.org>
6301
6302 * xdisp.c (move_it_to): Don't bail out early when reaching
6303 position beyond to_charpos, if we are scanning backwards.
6304 (move_it_vertically_backward): When DY == 0, make sure we get to
6305 the first character in the line after the newline.
6306
f2cad773
PE
63072011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6308
6309 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6310 (ccl_driver): Do not generate an out-of-range pointer.
6311 (Fccl_execute_on_string): Remove unnecessary check for
6312 integer overflow, noted by Stefan Monnier in
6313 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6314 Remove a FIXME that didn't need fixing.
6315 Simplify the newly-introduced buffer reallocation code.
6316
0cae2cdb
JB
63172011-08-27 Juanma Barranquero <lekktu@gmail.com>
6318
6319 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6320
5fc295a4 63212011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6322
70c60eb2 6323 Integer and memory overflow issues (Bug#9196).
726e0ab1 6324
d31850da
PE
6325 * doc.c (get_doc_string): Rework so that
6326 get_doc_string_buffer_size is the actual buffer size, rather than
6327 being 1 less than the actual buffer size; this makes xpalloc more
6328 convenient.
6329
a69fbedb
PE
6330 * image.c (x_allocate_bitmap_record, cache_image):
6331 * xselect.c (Fx_register_dnd_atom):
6332 Simplify previous changes by using xpalloc.
6333
fe5c5d37
PE
6334 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6335 since either will do and ptrdiff_t is convenient with xpalloc.
6336
0065d054
PE
6337 * charset.c (charset_table_size)
6338 (struct charset_sort_data.priority): Now ptrdiff_t.
6339 (charset_compare): Don't overflow if priorities differ greatly.
6340 (Fsort_charsets): Don't assume list length fits in int.
6341 Check for size-calculation overflow when allocating sort data.
6342 (syms_of_charset): Allocate an initial charset table that is
6343 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6344
6345 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6346
6347 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6348 The actual value is always <= INT_MAX, and leaving it unsigned made
6349 overflow checking harder.
6350
6351 * dispextern.h (struct glyph_matrix.rows_allocated)
6352 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6353 with xpalloc. The values are still always <= INT_MAX.
6354
6355 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6356
6357 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6358 (SAFE_NALLOCA): New macro.
6359
6360 * region-cache.c (struct boundary.pos, find_cache_boundary)
6361 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6362 (set_cache_region, invalidate_region_cache)
6363 (revalidate_region_cache, know_region_cache, region_cache_forward)
6364 (region_cache_backward, pp_cache):
6365 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6366 so that ptrdiff_t * can be passed to xpalloc.
6367 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6368 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6369 (pp_cache): Don't assume cache_len fits in int.
6370 * region-cache.h: Adjust extern decls to match.
6371
6372 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6373 EMACS_INT, since either will do, for xpalloc.
6374
6375 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6376 (xnmalloc, xnrealloc, xpalloc): New functions.
6377
726e0ab1
PE
6378 * bidi.c (bidi_shelve_header_size): New constant.
6379 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6380 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6381
51f30bc5 6382 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6383 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6384 (overlay_strings):
6385 Don't update size of array until after memory allocation succeeds,
6386 because xmalloc/xrealloc may not return.
0065d054
PE
6387 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6388 now that we have proper integer overflow checking.
6389 (record_overlay_string, overlay_strings): Catch overflows when
6390 calculating size of overlay_str_buf.
726e0ab1 6391
0065d054
PE
6392 * callproc.c (Fcall_process): Check for size overflow when
6393 calculating size of args2.
6394 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6395 Normally we prefer signed values, but sticking with ptrdiff_t would
6396 require adding more-complicated checks.
726e0ab1
PE
6397
6398 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6399 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6400 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6401 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6402
6403 * character.c (Fstring): Check for size-calculation overflow.
6404
6405 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6406 unnecessary integer overflow. Check for size overflow.
6407 (encode_coding_object): Don't update size until xmalloc succeeds.
6408
6409 * composite.c (get_composition_id): Check for overflow in glyph
6410 length calculations.
6411
6412 Integer and memory overflow fixes for display code.
6413 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6414 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6415 (scrolling_window): Check for overflow in size calculations.
6416 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6417 Don't assume glyph table len fits in int.
6418 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6419 (row_table_size): Now ptrdiff_t, not int.
6420 (scrolling_window): Avoid overflow in size calculations.
6421 Don't update size until allocation succeeds.
6422 * fns.c (concat): Check for overflow in size calculations.
6423 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6424 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6425 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6426
6427 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6428 (get_doc_string): Check for size calculation overflow.
6429 Don't update size until allocation succeeds.
6430 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6431 EMACS_INT, where ptrdiff_t will do.
6432 (Fsubstitute_command_keys): Check for string overflow.
6433
6434 * editfns.c (set_time_zone_rule): Don't assume environment length
6435 fits in int.
6436 (message_length): Now ptrdiff_t, not int.
6437 (Fmessage_box): Don't update size until allocation succeeds.
6438 Don't assume message length fits in int.
6439 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6440
0065d054
PE
6441 * emacs.c (main): Do not reallocate argv, since there is a null at
6442 the end that can be overwritten, and this way there's no need to
6443 worry about size-calculation overflow.
6444 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6445
6446 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6447 alloc succeeds.
6448 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6449
6450 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6451 (x_set_scroll_bar_width, x_figure_window_size):
6452 Check for integer overflow.
6453 (x_set_alpha): Do not assume XINT fits in int.
6454
6455 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6456 This is for the members text_lines, text_cols, total_lines, total_cols,
6457 where the system imposes an 'int' limit.
6458
6459 * fringe.c (Fdefine_fringe_bitmap):
6460 Don't update size until alloc works.
6461
6462 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6463 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6464
6465 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6466 Check for size-calculation overflow.
6467 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6468 do, as we prefer signed integers.
6469 (id_to_widget.max_size, id_to_widget.used)
6470 (xg_store_widget_in_map, xg_remove_widget_from_map)
6471 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6472 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6473 Use and return ptrdiff_t, not int.
6474 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6475 * gtkutil.h: Change prototypes to match the above.
6476
6477 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6478 are duplicate now that they've been promoted to lisp.h.
6479 (x_allocate_bitmap_record, x_alloc_image_color)
6480 (make_image_cache, cache_image, xpm_load):
6481 Don't update size until alloc is done.
6482 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6483 (x_detect_edges):
3256efce 6484 Check for size calculation overflow.
726e0ab1
PE
6485 (ct_colors_allocated_max): New constant.
6486 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6487 overflow.
3256efce 6488
726e0ab1
PE
6489 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6490 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6491 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6492 Use ptrdiff_t, not int, to count maps.
6493 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6494 calculations. Don't update size until allocation succeeds.
6495 Redo calculations to avoid overflow.
726e0ab1
PE
6496 * keyboard.h: Change prototypes to match the above.
6497
6498 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6499 to count maps.
6500 (current_minor_maps): Check for size calculation overflow.
6501 * keymap.h: Change prototypes to match the above.
6502
6503 * lread.c (read1, init_obarray): Don't update size until alloc done.
6504
6505 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6506 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6507
726e0ab1
PE
6508 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6509 Now ptrdiff_t, not int.
6510 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6511 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6512
6513 * process.c (Fnetwork_interface_list): Check for overflow
6514 in size calculation.
6515
6516 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6517
6518 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6519 overflow. Don't bother calling xmalloc when xrealloc will do.
6520
6521 * search.c (Freplace_match): Check for size calculation overflow.
6522 (Fset_match_data): Don't assume list lengths fit in 'int'.
6523
6524 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6525 for command line length. Do not attempt to address one before the
6526 beginning of an array, as that's not portable.
6527
6528 * term.c (max_frame_lines): Remove; unused.
6529 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6530 not int.
6531 (encode_terminal_code, calculate_costs): Check for size
6532 calculation overflow.
6533 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6534 table lengths and related sizes. Don't update size until alloc
6535 done. Redo calculations to avoid overflow.
6536 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6537
6538 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6539 subtracting pointers.
6540 (gobble_line): Check for overflow more carefully. Don't update size
6541 until alloc done.
6542
6543 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6544 Don't update size until alloc done.
6545 Redo size calculations to avoid overflow.
6546 Check for size calculation overflow.
0065d054 6547 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6548
6549 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6550 Use ptrdiff_t, not int, for sizes.
6551 (store_mode_line_noprop_char): Don't update size until alloc done.
6552
0065d054
PE
6553 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6554 Use ptrdiff_t, not int, for sizes.
6555 (Finternal_make_lisp_face, cache_face):
6556 Check for size calculation overflow.
6557 (cache_face): Treat size calculation overflows as if they were
6558 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6559
6560 * xfns.c (x_encode_text, x_set_name_internal)
6561 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6562 sizes, since they can exceed INT_MAX in size. Check for size
6563 calculation overflow.
6564
0065d054
PE
6565 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6566 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6567 Don't update size until alloc done.
6568
0065d054 6569 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6570 as sprintf is limited to int lengths.
1d526e2f 6571
252c5ee1
PE
6572 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6573 (X_LONG_MIN): New macros.
864d7ce7
PE
6574 Use them to make the following changes clearer.
6575 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6576 This change doesn't affect the value now, but it may help remind
6577 future maintainers not to raise the value too much later.
6578 (SELECTION_QUANTUM): Remove, replacing with ...
6579 (selection_quantum): ... new function, which avoids overflow.
6580 All uses changed.
6581 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6582 assumption that selection length fits in 'int'.
6583 (x_reply_selection_request, x_handle_selection_request)
6584 (x_get_window_property, receive_incremental_selection)
6585 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6586 (lisp_data_to_selection_data, clean_local_selection_data):
6587 Use ptrdiff_t, not int, to record length of selection.
6588 (x_reply_selection_request, x_get_window_property)
6589 (receive_incremental_selection, x_property_data_to_lisp):
6590 Redo calculations to avoid overflow.
6591 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6592 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6593 something.
6594 (x_get_window_property, receive_incremental_selection)
6595 (lisp_data_to_selection_data, x_property_data_to_lisp):
6596 Check for size-calculation overflow.
6597 (x_get_window_property, receive_incremental_selection)
6598 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6599 Don't store size until memory allocation succeeds.
6600 (x_get_window_property): Plug memory leak on memory exhaustion.
6601 Don't double-block input; malloc is safe here. Don't assume 2**34
6602 - 4 fits in unsigned long. Add an xassert to check
6603 XGetWindowProperty overflow. Be more careful about overflow
6604 calculations, and distinguish size from memory overflow better.
6605 (receive_incremental_selection): When tracing, don't assume
6606 unsigned int is less than INT_MAX.
6607 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6608 harmful) conversions of unsigned short to int.
6609 (lisp_data_to_selection_data): Don't assume that integers
6610 in the range -65535 through -1 fit in an X unsigned short.
6611 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6612 result parameters unless successful. Rely on cons_to_unsigned
6613 to report problems with elements; the old code wasn't right anyway.
6614 (x_check_property_data): Check for int overflow; we cannot use
6615 a wider type due to X limits.
6616 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6617
726e0ab1 6618 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6619
0065d054
PE
6620 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6621 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6622 (x_color_cells): Don't store size until memory allocation succeeds.
6623 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6624 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6625 (x_term_init): Don't assume length fits in int (sprintf is limited
6626 to int size).
bc18e09d 6627
ebfa62c0
PE
6628 Use ptrdiff_t for composition IDs.
6629 * character.c (lisp_string_width):
6630 * composite.c (composition_table_size, n_compositions)
6631 (get_composition_id, composition_gstring_from_id):
6632 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6633 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6634 * window.c (Frecenter):
6635 Use ptrdiff_t, not int, for composition IDs.
6636 * composite.c (get_composition_id): Check for integer overflow.
6637 * composite.h: Adjust prototypes to match the above changes.
6638
d3411f89
PE
6639 Use ptrdiff_t for hash table indexes.
6640 * category.c (hash_get_category_set):
6641 * ccl.c (ccl_driver):
6642 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6643 * coding.c (coding_system_charset_list, detect_coding_system):
6644 * coding.h (struct coding_system.id):
6645 * composite.c (get_composition_id, gstring_lookup_cache):
6646 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6647 * image.c (xpm_get_color_table_h):
6648 * lisp.h (hash_lookup, hash_put):
6649 * minibuf.c (Ftest_completion):
6650 Use ptrdiff_t for hash table indexes, not int (which is too
6651 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6652 32-bit --with-wide-int hosts).
6653
e097a6fa
PE
6654 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6655 Add a FIXME comment about memory leaks.
6656 (syms_of_charset): Don't assume xmalloc returns.
6657
5637687f
PE
6658 Don't assume that stated character widths fit in int.
6659 * character.c (Fchar_width, c_string_width, lisp_string_width):
6660 * character.h (CHAR_WIDTH):
6661 * indent.c (MULTIBYTE_BYTES_WIDTH):
6662 Use sanitize_char_width to avoid undefined and/or bad behavior
6663 with outlandish widths.
a66cfb1c 6664 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6665 now that we have two such functions. All uses changed.
6666 (sanitize_char_width): New inline function.
6667
a2271ba2
PE
6668 Don't assume that tab-width fits in int.
6669 * character.h (sanitize_width): New inline function.
6670 (SANE_TAB_WIDTH): New macro.
6671 (ASCII_CHAR_WIDTH): Use it.
6672 * indent.c (sane_tab_width): Remove. All uses replaced by
6673 SANE_TAB_WIDTH (current_buffer).
6674 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6675
18c52557
PE
6676 * fileio.c: Integer overflow issues with file modes.
6677 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6678
caeeedc1
PE
6679 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6680 Remove unreachable code.
6681 (read_hex, load_charset_map_from_file): Check for integer overflow.
6682
6df6ae42 6683 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6684 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6685 (x_send_scroll_bar_event): Likewise. Check that the size does not
6686 exceed limits imposed by XClientMessageEvent, as well as the usual
6687 ptrdiff_t and size_t limits.
6688
b13995db
PE
6689 * keyboard.c: Overflow, signedness and related fixes.
6690 (make_lispy_movement): Use same integer type in forward decl
6691 that is used in the definition.
6692 (read_key_sequence, keyremap_step):
6693 Change bufsize argument back to int, undoing my 2011-03-30 change.
6694 We prefer signed types, and int is wide enough here.
6695 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6696 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6697 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6698 length, not size_t. Use ptrdiff_t for index, not int.
6699 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6700 possibility of integer overflow.
6701
13464394
PE
6702 Overflow, signedness and related fixes for images.
6703
6704 * dispextern.h (struct it.stack[0].u.image.image_id)
6705 (struct_it.image_id, struct image.id, struct image_cache.size)
6706 (struct image_cache.used, struct image_cache.ref_count):
6707 * gtkutil.c (update_frame_tool_bar):
6708 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6709 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6710 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6711 * nsmenu.m (update_frame_tool_bar):
6712 * xdisp.c (calc_pixel_width_or_height):
6713 * xfns.c (image_cache_refcount):
6714 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6715 on typical 64-bit hosts.
6716
6717 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6718 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6719 Omit unnecessary casts to int.
6720 (parse_image_spec): Check that integers fall into 'int' range
6721 when the callers expect that.
6722 (image_ascent): Redo ascent calculation to avoid int overflow.
6723 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6724 (lookup_image): Remove unnecessary tests.
6725 (xbm_image_p): Locals are now of int, not EMACS_INT,
6726 since parse_image_check makes sure they fit into int.
6727 (png_load, gif_load, svg_load_image):
6728 Prefer int to unsigned where either will do.
6729 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6730 old tiff_error_handler and tiff_warning_handler.
6731 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6732 stack buffer overflows. It uses only the features of vsnprintf
6733 that are common to both POSIX and native Microsoft.
6734 (tiff_error_handler, tiff_warning_handler): Use it.
6735 (tiff_load, gif_load, imagemagick_load_image):
6736 Don't assume :index value fits in 'int'.
6737 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6738 (imagemagick_load_image): Check that crop parameters fit into
6739 the integer types that MagickCropImage accepts. Don't assume
6740 Vimagemagick_render_type has a nonnegative value. Don't assume
6741 size_t fits in 'long'.
6742 (gs_load): Use printmax_t to print the widest integers possible.
6743 Check for integer overflow when computing image height and width.
6744
c11821d4
EZ
67452011-08-26 Eli Zaretskii <eliz@gnu.org>
6746
6747 * xdisp.c (redisplay_window): Don't force window start if point
6748 will be invisible in the resulting window. (Bug#9324)
6749
0c95fcf7
EZ
67502011-08-25 Eli Zaretskii <eliz@gnu.org>
6751
6752 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6753 the display spec is of the form `(space ...)'.
6754 (handle_display_spec): Return the value returned by
6755 handle_single_display_spec, not just 1 or zero.
6756 (handle_single_display_spec): If the display spec is of the form
6757 `(space ...)', and specifies display in the text area, return 2
6758 rather than 1.
fee65a97 6759 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6760 accurately, and prefer exact match for point under bidi.
6761 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6762
6763 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6764 into disp_prop; all users changed.
6765
6766 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6767 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6768 for the text covered by the display property.
6769
e4ed06f1
CY
67702011-08-25 Chong Yidong <cyd@stupidchicken.com>
6771
6772 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6773 Change return value to nil.
6774 (Frecord_buffer): Delete unused function.
6775
f67cdd7f
EZ
67762011-08-24 Eli Zaretskii <eliz@gnu.org>
6777
5980d4c6
EZ
6778 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6779 buffers, return left-to-right.
8610fe8b
EZ
6780 (set_cursor_from_row): Consider candidate row a win if its glyph
6781 represents a newline and point is on that newline. Fixes cursor
6782 positioning on the newline at EOL of R2L text within L2R
6783 paragraph, and vice versa.
6784 (try_cursor_movement): Check continued rows, in addition to
6785 continuation rows. Fixes unwarranted scroll when point enters a
6786 continued line of R2L text within an L2R paragraph, or vice versa.
6787 (cursor_row_p): Consider the case of point being equal to
6788 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6789 from the end of a short line to the beginning of a continued line
6790 of R2L text within L2R paragraph.
6791 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6792 composed characters.
5980d4c6 6793
f67cdd7f
EZ
6794 * bidi.c (bidi_check_type): Use xassert.
6795 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6796 members.
6797
bca633fb
EZ
67982011-08-23 Eli Zaretskii <eliz@gnu.org>
6799
6800 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6801 a character.
6802
4a5885a7
CY
68032011-08-23 Chong Yidong <cyd@stupidchicken.com>
6804
6805 * nsfont.m (ns_otf_to_script): Fix typo.
6806
0902a04e
KH
68072011-08-22 Kenichi Handa <handa@m17n.org>
6808
6809 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6810 extra slot even if the purpose is char-code-property-table.
6811
1a2e6670
EZ
68122011-08-23 Eli Zaretskii <eliz@gnu.org>
6813
8ddde651
EZ
6814 * xdisp.c (redisplay_window): When computing centering_position,
6815 account for the height of the header line. (Bug#8874)
6816
425cc014
EZ
6817 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6818 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6819 candidate is selected by the mouse, and that candidate has a
6820 composed character under the mouse.
6821
1a2e6670
EZ
6822 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6823 coordinates reported by pos-visible-in-window-p for a composed
6824 character in column zero.
6825
8b76d6f8
SM
68262011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6827
6828 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6829
dac347dd
EZ
68302011-08-22 Eli Zaretskii <eliz@gnu.org>
6831
6832 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6833 consider it a hit if to_charpos is anywhere in the range of the
6834 composed buffer positions.
6835
e013fb34
CY
68362011-08-22 Chong Yidong <cyd@stupidchicken.com>
6837
6838 * image.c (gif_load): Don't assume that each subimage has the same
6839 dimensions as the base image. Handle disposal method that is
6840 "undefined" by the gif spec (Bug#9335).
6841
bd1ba3e8
CY
68422011-08-20 Chong Yidong <cyd@stupidchicken.com>
6843
6844 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6845 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6846
54a1215b
EZ
68472011-08-19 Eli Zaretskii <eliz@gnu.org>
6848
823564e5
EZ
6849 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6850 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6851 from an Org mode buffer to a Speedbar frame.
6852
54a1215b
EZ
6853 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6854 a composition, take its buffer position from IT->cmp_it.charpos.
6855 Fixes cursor positioning at the beginning of a line that begins
6856 with a composed character.
6857
9778ebcc
EZ
68582011-08-18 Eli Zaretskii <eliz@gnu.org>
6859
0be6ee06
EZ
6860 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6861 character bidirectional type, use STRONG_L instead. Fixes crashes
6862 in a buffer produced by `describe-categories'.
6863
9778ebcc
EZ
6864 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6865 members before the level stack, so they would be saved and
6866 restored when copying iterator state. Fixes incorrect reordering
6867 around TABs covered by display properties.
6868
156bffbe
AS
68692011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6870
6b02f655 6871 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6872
72ad093b
CY
68732011-08-17 Chong Yidong <cyd@stupidchicken.com>
6874
6875 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6876 (internal_condition_case_2, internal_condition_case_n):
6877 Remove unnecessary aborts (Bug#9081).
72ad093b 6878
35774242
EZ
68792011-08-17 Eli Zaretskii <eliz@gnu.org>
6880
6881 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6882 has no `load' handler, try opening the file locally. (Bug#9311)
6883
db76dd85
KB
68842011-08-16 Ken Brown <kbrown@cornell.edu>
6885
6886 * gmalloc.c: Expand comment.
6887
b215eee5
EZ
68882011-08-16 Eli Zaretskii <eliz@gnu.org>
6889
6890 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6891 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6892
a4579d33
KB
68932011-08-16 Ken Brown <kbrown@cornell.edu>
6894
6895 Fix memory allocation problems in Cygwin build (Bug#9273).
6896
6897 * unexcw.c ( __malloc_initialized): Declare external variable.
6898 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6899
8b76d6f8
SM
6900 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6901 New variables.
a4579d33
KB
6902 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6903 dumped emacs.
6904 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6905 in the static heap.
6906 [CYGWIN] (special_realloc): New function.
6907 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6908 requests to realloc storage in the static heap.
6909
3ebec551
PE
69102011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6911
6912 * bidi.c (bidi_initialize): Remove unused local.
6913
9fd8be00
EZ
69142011-08-15 Eli Zaretskii <eliz@gnu.org>
6915
6b02f655
SM
6916 * bidimirror.h:
6917 * biditype.h: Remove file.
6918 * makefile.w32-in ($(BLD)/bidi.$(O)):
6919 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6920
6921 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6922
6923 * chartab.c: Improve commentary for the uniprop_table API.
6924
32413314
EZ
6925 * bidi.c (bidi_paragraph_init): Support zero value of
6926 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6927 (bidi_initialize): Use uniprop_table instead of including
6928 biditype.h and bidimirror.h.
32413314 6929
9fd8be00
EZ
6930 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6931 coordinates of the iterator when restoring from ppos_it.
6932 (Bug#9296)
6933
5cf2b69b
KH
69342011-08-14 Kenichi Handa <handa@m17n.org>
6935
6936 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6937 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6938
daf17d00
EZ
69392011-08-14 Eli Zaretskii <eliz@gnu.org>
6940
6941 * xdisp.c (move_it_in_display_line_to): Don't invoke
6942 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6943 ppos_it. Fixes vertical cursor motion when line beginning is
6944 covered by an image. (Bug#9296)
6945
08e3161a
JD
69462011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6947
6948 * nsterm.h (ns_run_ascript): Declare.
6949 (NSAPP_DATA2_RUNASSCRIPT): Define.
6950
6951 * nsfns.m (as_script, as_result, as_status): New static variables.
6952 (ns_run_ascript): New function.
5e617bc2 6953 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6954 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6955 the event loop. Get status from as_status (Bug#7276).
6956
6957 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6958 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6959 the event loop (Bug#7276).
6960
a3720aa2
AS
69612011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6962
6963 * gnutls.c (QCgnutls_bootprop_priority)
6964 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6965 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6966 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6967 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6968 (QCgnutls_bootprop_verify_hostname_error)
6969 (QCgnutls_bootprop_callbacks_verify): Rename from
6970 Qgnutls_bootprop_..., all uses changed.
6971
6972 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6973 uses changed.
6974
0a0d27fb
PE
69752011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6976
19d5c50c
PE
6977 * xfaces.c (Qframe_set_background_mode): Now static.
6978 * dispextern.h (Qframe_set_background_mode): Remove decl.
6979
0a0d27fb
PE
6980 * process.c (Fnetwork_interface_info): Declare local only if needed.
6981
377538cb
JD
69822011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6983
6984 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6985 (Fnetwork_interface_list): Allocate in increments of bytes instead
6986 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6987 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6988 sockaddr.
6989 (struct ifflag_def): notrailers is smart on OSX.
6990 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6991 Get hardware address with getifaddrs if available.
6992
08fff70c
EZ
69932011-08-12 Eli Zaretskii <eliz@gnu.org>
6994
6995 * xdisp.c (iterate_out_of_display_property): xassert that
6996 IT->position is set to within IT->object's boundaries. Break from
6997 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6998 when IT->position is set up wrongly due to some bug.
6999 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7000 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7001 entry. Force push_it to save on the stack the current
7002 buffer/string position, to be restored by pop_it. Fix flags in
7003 the iterator structure wrt the object coming from a display
7004 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7005 properties. (Bug#9284)
7006
7be1c708 70072011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7008
7be1c708
CY
7009 * fontset.c (fontset_get_font_group): Add proper type checks.
7010 (Bug#9172)
aac0c6e3 7011
7be1c708 70122011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7013
7be1c708
CY
7014 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7015 and LC_VERSION_MIN_MACOSX.
7016 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7017 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7018
97bb72a6
EZ
70192011-08-08 Eli Zaretskii <eliz@gnu.org>
7020
7021 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7022 no-display-properties-and-no-overlays under bidi display.
7023 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7024 properties and overlays.
97bb72a6 7025
d5617611
CY
70262011-08-08 Chong Yidong <cyd@stupidchicken.com>
7027
37e11a63
CY
7028 * editfns.c (Fset_time_zone_rule): Document relationship with the
7029 setenv function.
7030
d5617611
CY
7031 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7032 the font entity extracted from the cache (Bug#8109).
7033
58872834
CY
70342011-08-07 Chong Yidong <cyd@stupidchicken.com>
7035
7036 * composite.c (autocmp_chars): Don't reset point. That is done by
7037 restore_point_unwind (Bug#5984).
7038
75bfc667
JL
70392011-08-07 Juri Linkov <juri@jurta.org>
7040
7041 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7042 to show the arg `TIME' instead of `TIMEVAL'.
7043
d1410150
EZ
70442011-08-06 Eli Zaretskii <eliz@gnu.org>
7045
7046 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7047 display property strides EOL and includes a newline, as in
7048 longlines-mode. (Bug#9254)
75b771e4
EZ
7049 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7050 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7051
7052 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7053 is non-zero, even if the data buffer is NULL. Fixes a crash in
7054 vertical-motion with longlines-mode. (Bug#9254)
7055
35928349
EZ
70562011-08-05 Eli Zaretskii <eliz@gnu.org>
7057
ec7cc85b
EZ
7058 * bidi.c <bidi_cache_total_alloc>: Now static.
7059 (bidi_initialize): Initialize bidi_cache_total_alloc.
7060
8b76d6f8 7061 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7062 cache. (Bug#9221)
7063
7064 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7065 amount allocated this far in `bidi_cache_total_alloc'.
7066 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7067 non-zero, only free the data buffer without restoring the cache
7068 contents. All callers changed.
7069
7070 * dispextern.h (bidi_unshelve_cache): Update prototype.
7071
7072 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7073 (move_it_in_display_line, move_it_to)
7074 (move_it_vertically_backward, move_it_by_lines): Replace the call
7075 to xfree to an equivalent call to bidi_unshelve_cache.
7076 (move_it_in_display_line_to): Fix logic of returning
412b6358 7077 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7078
e2e2423b
EZ
70792011-08-05 Eli Zaretskii <eliz@gnu.org>
7080
7081 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7082 came from a string character with a `cursor' property. (Bug#9229)
7083
ae9e757a
JD
70842011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7085
7086 * Makefile.in (LIB_PTHREAD): New variable.
7087 (LIBES): Add LIB_PTHREAD (Bug#9216).
7088
7089 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7090 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7091
213bd7f2
AS
70922011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7093
6b02f655 7094 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7095
99aaf75f
JD
70962011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7097
7098 * xterm.c (x_find_topmost_parent): New function.
7099 (x_set_frame_alpha): Find topmost parent window with
7100 x_find_topmost_parent and set the property there also (bug#9181).
7101 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7102
c74e9d86
PE
71032011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7104
7105 * callproc.c (Fcall_process): Avoid vfork clobbering
7106 the local vars buffer, coding_systems, current_dir.
7107
640c8776
SM
71082011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7109
7110 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7111
f26d0e4c
PE
71122011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7113
8a10d76c
PE
7114 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7115 so that it is not optimized away.
7116
f26d0e4c
PE
7117 * xdisp.c (compute_display_string_pos): Remove unused local.
7118
55439c61
EZ
71192011-08-02 Eli Zaretskii <eliz@gnu.org>
7120
7121 Fix slow cursor motion and scrolling in large buffers with
7122 selective display, like Org Mode buffers. (Bug#9218)
7123
7124 * dispextern.h (struct bidi_it): New member disp_prop_p.
7125
7126 * xdisp.c: Remove one-slot cache of display string positions.
7127 (compute_display_string_pos): Accept an additional argument
5e617bc2 7128 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7129 for a display string or property. If found, set DISP_PROP_P
7130 non-zero.
7131
7132 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7133 DISP_PROP_P, and pass it to compute_display_string_pos.
7134 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7135 non-zero. All callers of bidi_fetch_char changed.
7136
fb33fa43
SM
71372011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7138
7139 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7140
b099e063
DM
71412010-12-03 Don March <don@ohspite.net>
7142
7143 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7144 last character M-[char] is translated to ESC [char] (bug#7541).
7145
5cc7f7af
KH
71462011-08-02 Kenichi Handa <handa@m17n.org>
7147
d0fffa3f 7148 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
7149
7150 * chartab.c (uniprop_table): Make it non-static.
7151
525d5e6e
EZ
71522011-08-01 Eli Zaretskii <eliz@gnu.org>
7153
7154 * xdisp.c (forward_to_next_line_start): Accept additional argument
7155 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7156 on the newline.
7157 (reseat_at_next_visible_line_start): Use the bidi iterator state
7158 returned by forward_to_next_line_start to restore the state of
7159 it->bidi_it after backing up to previous newline. (Bug#9212)
7160
31011111
AS
71612011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7162
7163 * regex.c (re_comp): Protoize.
7164 (re_exec): Fix return type.
7165 (regexec): Fix type of `ret'. (Bug#9203)
7166
476371c4
PE
71672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7168
e5d76069
PE
7169 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7170 This is needed if max-image-size is a floating-point number.
7171
9a79b20c
AS
71722011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7173
7174 * print.c (print_object): Print empty symbol as ##.
7175
7176 * lread.c (read1): Read ## as empty symbol.
7177
d8c2fa78
AA
71782011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7179
7180 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7181 setting frame foreground color (Bug#9175).
7182 (x_set_background_color): Likewise.
7183
ffe57a7a
AA
7184 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7185 contents (Bug#9176).
7186 (EmacsTooltip -init): Remove bezels and add shadows to
7187 tooltip windows.
7188
bf3492a5
AA
7189 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7190 or scroll bar (Bug#8470).
7191
d55e9c53
AA
7192 * nsfont.m (nsfont_open): Remove assignment to voffset and
7193 unnecessary vars hshink, expand, hd, full_height, min_height.
7194 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7195
7196 * nsterm.h (nsfont_info): Remove voffset field.
7197
d8c2fa78 71982011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
7199
7200 Implement strike-through and overline on NextStep (Bug#8863).
7201
7202 * nsfont.m (nsfont_open): Use underline position provided by font,
7203 instead of hard-coded value of 2.
7204 (nsfont_draw): Call ns_draw_text_decoration instead.
7205
7206 * nsterm.h: Add declaration for ns_draw_text_decoration.
7207
7208 * nsterm.m (ns_draw_text_decoration): New function for drawing
7209 underline, overline, and strike-through.
7210 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7211 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 7212 accommodate underlining, etc.
4843aac3 7213
4cc60b9b
EZ
72142011-07-28 Eli Zaretskii <eliz@gnu.org>
7215
bc7ece87
EZ
7216 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7217 default.
4cc60b9b 7218
476371c4
PE
72192011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7220
66606eea
PE
7221 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7222 Without this fix, if a signal arrives just after memory fills up,
7223 'malloc' might be invoked reentrantly.
7224
476371c4
PE
7225 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7226 In other words, assume that every image size is allowed, on non-X
7227 hosts. This assumption is probably wrong, but it lets Emacs compile.
7228
f3fcc40d
AS
72292011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7230
7231 * regex.c (re_iswctype): Convert return values to boolean.
7232
350c992f
EZ
72332011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7234
7235 * xdisp.c (compute_display_string_pos): Don't use cached display
7236 string position if the buffer had its restriction changed.
7237 (Bug#9184)
7238
5266b4bb
PE
72392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7240
7241 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7242
2573a837 72432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 7244
41f55ccd 7245 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 7246
39e378da
PE
7247 * bidi.c: Integer size and overflow fixes.
7248 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7249 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7250 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7251 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7252 (bidi_find_other_level_edge):
7253 Use ptrdiff_t instead of EMACS_INT where either will do.
7254 This works better on 32-bit hosts configured --with-wide-int.
7255 (bidi_cache_ensure_space): Check for size-calculation overflow.
7256 Use % rather than repeated addition, for better worst-case speed.
7257 Don't set bidi_cache_size until after xrealloc returns, because it
7258 might not return.
7259 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7260 (bidi_cache_ensure_space): Also check that the bidi cache size
7261 does not exceed that of the largest Lisp string or buffer. See Eli
7262 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7263
5e927815
PE
7264 * alloc.c (__malloc_size_t): Remove.
7265 All uses replaced by size_t. See Andreas Schwab's note
7266 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7267
ca4aa935
PE
7268 * image.c: Improve checking for integer overflow.
7269 (check_image_size): Assume that f is nonnull, since
7270 it is always nonnull in practice. This is one less thing to
7271 worry about when checking for integer overflow later.
7272 (x_check_image_size): New function, which checks for integer
7273 overflow issues inside X.
7274 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7275 This removes the need for a memory_full check.
7276 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7277 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7278 (xbm_read_bitmap_data): Change locals back to 'int', since
7279 their values must fit in 'int'.
7280 (xpm_load_image, png_load, tiff_load):
7281 Invoke x_create_x_image_and_pixmap earlier,
7282 to avoid much needless work if the image is too large.
7283 (tiff_load): Treat overly large images as if
7284 x_create_x_image_and_pixmap failed, not as malloc failures.
7285 (gs_load): Use x_check_image_size.
7286
5f8f9cc2
PE
7287 * gtkutil.c: Omit integer casts.
7288 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7289 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7290
5adf60bc
PE
7291 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7292
c8907a93
PE
7293 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7294 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7295 would wrongly return t on a 64-bit host.
7296
e3c25c68
PE
7297 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7298 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7299 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7300 and therefore cause GCC to emit a bogus diagnostic in some cases.
7301
3f791afe
PE
7302 * image.c: Integer signedness and overflow and related fixes.
7303 This is not an exhaustive set of fixes, but it's time to
7304 record what I've got.
7305 (lookup_pixel_color, check_image_size): Remove redundant decls.
7306 (check_image_size): Don't assume that arbitrary EMACS_INT values
7307 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7308 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7309 (tiff_load, imagemagick_load_image):
7310 Check for overflow in size calculations.
7311 (x_create_x_image_and_pixmap): Remove unnecessary test for
7312 xmalloc returning NULL; that can't happen.
7313 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7314 (xpm_color_bucket): Use better integer hashing function.
7315 (xpm_cache_color): Don't possibly over-allocate memory.
7316 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7317 (gif_memory_source):
7318 Use ptrdiff_t, not int or size_t, to record sizes.
7319 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7320 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7321 either works, as we prefer signed integers.
7322 (tiff_read_from_memory, tiff_write_from_memory):
7323 Return tsize_t, not size_t, since that's what the TIFF API wants.
7324 (tiff_read_from_memory): Don't fail simply because the read would
7325 go past EOF; instead, return a short read.
7326 (tiff_load): Omit no-longer-needed casts.
7327 (Fimagemagick_types): Don't assume size fits into 'int'.
7328
3cc5a532
PE
7329 Improve hashing quality when configured --with-wide-int.
7330 * fns.c (hash_string): New function, taken from sxhash_string.
7331 Do not discard information about ASCII character case; this
7332 discarding is no longer needed.
7333 (sxhash-string): Use it. Change sig to match it. Caller changed.
7334 * lisp.h: Declare it.
7335 * lread.c (hash_string): Remove, since we now use fns.c's version.
7336 The fns.c version returns a wider integer if --with-wide-int is
7337 specified, so this should help the quality of the hashing a bit.
7338
b312a492
PE
7339 * emacs.c: Integer overflow minor fix.
7340 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7341 Define only if GNU_LINUX.
7342 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7343
dfd153ae
PE
7344 * dispnew.c: Integer signedness and overflow fixes.
7345 Remove unnecessary forward decls, that were a maintenance hassle.
7346 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7347 All uses changed.
7348 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7349 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7350 (prepare_desired_row, line_draw_cost):
7351 Use int, not unsigned, where either works.
7352 (save_current_matrix, restore_current_matrix):
7353 Use ptrdiff_t, not size_t, where either works.
7354 (init_display): Check for overflow more accurately, and without
7355 relying on undefined behavior.
7356
a81d11a3
PE
7357 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7358 Remove, replacing with the new symbols in lisp.h. All uses changed.
7359 * fileio.c (make_temp_name):
7360 * filelock.c (lock_file_1, lock_file):
7361 * xdisp.c (message_dolog):
7362 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7363 Use pMd etc. instead.
7364 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7365 replacing the pWIDE etc. symbols removed from editfns.c.
7366
3300e6fd
PE
7367 * keyboard.h (num_input_events): Now uintmax_t.
7368 This is (very slightly) less likely to mess up due to wraparound.
7369 All uses changed.
7370
fd05c7e9
PE
7371 * buffer.c: Integer signedness fixes.
7372 (alloc_buffer_text, enlarge_buffer_text):
7373 Use ptrdiff_t rather than size_t when either will do, as we prefer
7374 signed integers.
7375
903fe15d
PE
7376 * alloc.c: Integer signedness and overflow fixes.
7377 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7378 (__malloc_size_t): Default to size_t, not to int.
7379 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7380 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7381 Prefer ptrdiff_t to size_t when either would do, as we prefer
7382 signed integers.
7383 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7384 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7385 Now const. Initialize with values that are in range even if char
7386 is signed.
7387 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7388 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7389 These functions do the right thing with sizes > 2**32.
7390 (check_depth): Now ptrdiff_t, not int.
7391 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7392 Adjust to new way of storing sizes. Check for size overflow bugs
7393 in rest of code.
7394 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7395 slightly wrong anyway, as it missed one instance of
7396 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7397 (refill_memory_reserve): Omit needless cast to size_t.
7398 (mark_object_loop_halt): Mark as externally visible.
7399
ac82cc6a
PE
7400 * xselect.c: Integer signedness and overflow fixes.
7401 (Fx_register_dnd_atom, x_handle_dnd_message):
7402 Use ptrdiff_t, not size_t, since we prefer signed.
7403 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7404 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7405 x_dnd_atoms_size and x_dnd_atoms_length.
7406
c2d1e36d
PE
7407 * doprnt.c: Prefer signed to unsigned when either works.
7408 * eval.c (verror):
7409 * doprnt.c (doprnt):
7410 * lisp.h (doprnt):
7411 * xdisp.c (vmessage):
7412 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7413 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7414 prefer signed arithmetic to avoid comparison confusion.
7415 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7416 but is a bit tricky.
7417
0e926e56
PE
7418 Assume freestanding C89 headers, string.h, stdlib.h.
7419 * data.c, doprnt.c, floatfns.c, print.c:
7420 Include float.h unconditionally.
7421 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7422 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7423 * regex.c: Likewise for stddef.h, string.h.
7424 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7425 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7426 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7427 (STDC_HEADERS): Remove obsolete defines.
7428 * sysdep.c: Include limits.h unconditionally.
7429
9cfdb3ec
PE
7430 Assume support for memcmp, memcpy, memmove, memset.
7431 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7432 * regex.c (memcmp, memcpy):
7433 Remove; we assume C89 now.
7434
7435 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7436 (__malloc_safe_bcopy): Remove; no longer needed.
7437
cf950e6b 7438 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7439 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7440 well either way, and we prefer signed to unsigned.
7441
dbf38e02
LMI
74422011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7443
7444 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7445 closes the connection while we're reading (bug#9182).
7446
d6f0886c 74472011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7448
d6f0886c
JD
7449 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7450 are specified (Bug#9168).
24e0f6b1 7451
2eb1f9e6
PE
74522011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7453
7454 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7455 Found by GCC static checking and --with-wide-int on a 32-bit host.
7456
22381272 74572011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7458
7459 * xdisp.c (compute_display_string_pos): Fix logic of caching
7460 previous display string position. Initialize cached_prev_pos to
7461 -1. Fixes slow-down at the beginning of a buffer.
7462
f25e39b4
EZ
74632011-07-24 Eli Zaretskii <eliz@gnu.org>
7464
7465 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7466 for attrs[LFACE_FONTSET_INDEX].
7467
04c4b52e
PE
74682011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7469
7470 * xml.c (parse_region): Remove unused local
7471 that was recently introduced.
7472
c1734fbd
EZ
74732011-07-23 Eli Zaretskii <eliz@gnu.org>
7474
be18c5a5
EZ
7475 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7476 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7477
c1734fbd
EZ
7478 * xdisp.c (move_it_in_display_line_to): Record the best matching
7479 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7480 exit if none of the characters scanned was an exact match.
7481 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7482 when exact match is impossible due to invisible text, and the
7483 lines are truncated.
7484
a258d627
JD
74852011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7486
7487 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7488 for OSX >= 10.7.
7489
b6d5a689
EZ
74902011-07-22 Eli Zaretskii <eliz@gnu.org>
7491
0f74f785
EZ
7492 Fix a significant slow-down of cursor motion with C-n, C-p,
7493 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7494 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7495 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7496 (next_element_from_buffer): Call compute_stop_pos_backwards to
7497 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7498 base_level_stop.
7499 (reseat): Don't look for prev_stop, as that could mean a very long
7500 run.
7501 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7502 <cached_disp_overlay_modiff>: Cache for last found display string
7503 position.
551918c1 7504 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7505 about the same buffer in the same area of character positions, and
7506 the buffer wasn't changed since the time the display string
7507 position was cached.
551918c1 7508
b2d0c91a
EZ
75092011-07-22 Eli Zaretskii <eliz@gnu.org>
7510
7511 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7512 is an integer, which is important for empty lines. (Bug#9149)
7513
043604ee
CY
75142011-07-22 Chong Yidong <cyd@stupidchicken.com>
7515
7516 * frame.c (Fmodify_frame_parameters): In tty case, update the
7517 default face if necessary (Bug#4238).
7518
da4adb04
CY
75192011-07-21 Chong Yidong <cyd@stupidchicken.com>
7520
7521 * editfns.c (Fstring_to_char): No need to explain what a character
7522 is in the docstring (Bug#6576).
7523
9abd0532
LMI
75242011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7525
7526 * xml.c (parse_region): Make sure we always return a tree.
7527
36881d16
HK
75282011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7529
7530 * xml.c (parse_region): If a document contains only comments,
7531 return that, too.
7532
1e98674d
LMI
75332011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7534
7535 * xml.c (make_dom): Return comments, too.
7536
590bd467
PE
75372011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7538
7539 Port to OpenBSD.
7540 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7541 and the surrounding thread.
7542 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7543 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7544 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7545 timer goes off.
7546 * s/openbsd.h (BROKEN_SIGIO): Define.
7547 * unexelf.c (unexec) [__OpenBSD__]:
7548 Don't update the .mdebug section of the Alpha COFF symbol table.
7549
f41628b2
LMI
75502011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7551
7552 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7553 (bug#8460).
7554
b59b67c5
PE
75552011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7556
15e3a074
PE
7557 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7558 This fixes some race conditions on the permissions of any newly
7559 created file.
7560
41bed37d
PE
7561 * alloc.c (valid_pointer_p): Use pipe, not open.
7562 This fixes some permissions issues when debugging.
7563
b59b67c5
PE
7564 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7565 If fchown fails to set both uid and gid, try to set just gid,
7566 as that is sometimes allowed. Adjust the file's mode to eliminate
7567 setuid or setgid bits that are inappropriate if fchown fails.
7568
925a6be7
SM
75692011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7570
7571 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7572 to compare Lisp_Objects.
7573 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7574 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7575 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7576
52968808
AS
75772011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7578
0a6a104b
AS
7579 * lread.c (read_integer): Unread even EOF character.
7580 (read1): Likewise. Properly record start position of symbol.
7581
52968808
AS
7582 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7583 symbol character follows.
7584
9e381cdd
PE
75852011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7586
7587 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7588 This works around a problem with the previous change to Fcopy_file.
7589 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7590 and without this change, GCC might complain about discarding
7591 fchown's return value.
7592
b5641435
JB
75932011-07-16 Juanma Barranquero <lekktu@gmail.com>
7594
7595 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7596
a8031457
PE
75972011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7598
7599 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7600
dd889327
LMI
76012011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7602
750c33f7
LMI
7603 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7604 it's used from the C level.
7605
dd889327
LMI
7606 * process.c: Use the same condition for POLL_FOR_INPUT in both
7607 keyboard.c and process.c (bug#1858).
7608
87e86684
LM
76092011-07-09 Lawrence Mitchell <wence@gmx.li>
7610
7611 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7612 (Fgnutls_boot): Use it.
7613
64348f40
AS
76142011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7615
7616 * doc.c (Fsubstitute_command_keys): Revert last change.
7617
1d698799
LMI
76182011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7619
f863868c
LMI
7620 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7621 quotes the next character, and doesn't affect other longer
7622 sequences (bug#8935).
7623
1d698799
LMI
7624 * lread.c (syms_of_lread): Clarify that is isn't only
7625 `eval-buffer' and `eval-defun' that's affected by
7626 `lexical-binding' (bug#8460).
7627
aa4b6df6
EZ
76282011-07-15 Eli Zaretskii <eliz@gnu.org>
7629
7630 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7631 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7632
5d856da6
PE
76332011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7634
ad6042bb
PE
7635 Fix minor problems found by static checking.
7636 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7637 (elsz): Now a signed constant, not a size_t var. We prefer signed
7638 types to unsigned, to avoid integer comparison confusion. Without
7639 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7640 "cannot optimize loop, the loop counter may overflow", a symptom
7641 of the confusion.
f00bbb22 7642 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7643 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7644
6468f31c
LMI
76452011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7646
49080b10
LMI
7647 * search.c (Fre_search_backward): Mention `case-fold-search' in
7648 all the re_search_* functions (bug#8138).
7649
6468f31c
LMI
7650 * keyboard.c (Fopen_dribble_file): Document when the file is
7651 closed (bug#8056).
7652
c965adc5
EZ
76532011-07-14 Eli Zaretskii <eliz@gnu.org>
7654
df9733bf
EZ
7655 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7656 bidi_cache_idx.
7657
0bb23927
EZ
7658 Support bidi reordering of display and overlay strings.
7659 * xdisp.c (compute_display_string_pos)
7660 (compute_display_string_end): Accept additional argument STRING.
7661 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7662 (reseat_to_string): Initialize bidi_it->string.s and
7663 bidi_it->string.schars.
7664 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7665 NULL (avoids a crash in bidi_paragraph_init).
7666 Initialize itb.string.lstring.
0bb23927
EZ
7667 (init_iterator): Call bidi_init_it only of a valid
7668 buffer position was specified. Initialize paragraph_embedding to
7669 L2R.
7670 (reseat_to_string): Initialize the bidi iterator.
7671 (display_string): If we need to ignore text properties of
7672 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7673 original value of -1 will not work with bidi.)
7674 (compute_display_string_pos): First arg is now struct
7675 `text_pos *'; all callers changed. Support display properties on
7676 Lisp strings.
7677 (compute_display_string_end): Support display properties on Lisp
7678 strings.
7679 (init_iterator, reseat_1, reseat_to_string): Initialize the
7680 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7681 when iterating on a string not from display properties).
640c8776
SM
7682 (compute_display_string_pos, compute_display_string_end):
7683 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7684 arrow keys.
7685 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7686 base_level_stop; instead, set base_level_stop to BEGV.
7687 Fixes crashes in vertical-motion.
0bb23927
EZ
7688 (next_element_from_buffer): Improve commentary for when
7689 the iterator is before prev_stop.
7690 (init_iterator): Initialize bidi_p from the default value of
7691 bidi-display-reordering, not from buffer-local value. Use the
7692 buffer-local value only if initializing for buffer iteration.
7693 (handle_invisible_prop): Support invisible properties on strings
7694 that are being bidi-reordered.
7695 (set_iterator_to_next): Support bidi reordering of C strings and
7696 Lisp strings.
7697 (next_element_from_string): Support bidi reordering of Lisp
7698 strings.
7699 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7700 (display_string): Support display of R2L glyph rows.
7701 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7702 (init_iterator): Don't initialize it->bidi_p for strings
7703 here.
7704 (reseat_to_string): Initialize it->bidi_p for strings here.
7705 (next_element_from_string, next_element_from_c_string)
7706 (next_element_from_buffer): Add xassert's for correspondence
7707 between IT's object being iterated and it->bidi_it.string
7708 structure.
7709 (face_before_or_after_it_pos): Support bidi iteration.
7710 (next_element_from_c_string): Handle the case of the first string
7711 character that is not the first one in the visual order.
7712 (get_visually_first_element): New function, refactored from common
7713 parts of next_element_from_buffer, next_element_from_string, and
7714 next_element_from_c_string.
7715 (tool_bar_lines_needed, redisplay_tool_bar)
7716 (display_menu_bar): Force left-to-right direction. Add a FIXME
7717 comment for making that be controlled by a user option.
7718 (push_it, pop_it): Save and restore the state of the
7719 bidi iterator. Save and restore the bidi_p flag.
7720 (pop_it): Iterate out of display property for string iteration as
7721 well.
7722 (iterate_out_of_display_property): Support iteration over strings.
7723 (handle_single_display_spec): Set up it->bidi_it for iteration
7724 over a display string, and call bidi_init_it.
7725 (handle_single_display_spec, next_overlay_string)
7726 (get_overlay_strings_1, push_display_prop): Set up the bidi
7727 iterator for displaying display or overlay strings.
7728 (forward_to_next_line_start): Don't use the shortcut if
7729 bidi-iterating.
7730 (back_to_previous_visible_line_start): If handle_display_prop
7731 pushed the iterator stack, restore the internal state of the bidi
7732 iterator by calling bidi_pop_it same number of times.
7733 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7734 and we are bidi-iterating, don't decrement the iterator position;
7735 instead, set the first_elt flag in the bidi iterator, to produce
7736 the same effect.
7737 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7738 (push_display_prop): xassert that we are iterating a buffer.
7739 (push_it, pop_it): Save and restore paragraph_embedding member.
7740 (handle_single_display_spec, next_overlay_string)
7741 (get_overlay_strings_1, reseat_1, reseat_to_string)
7742 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7743 correctly. Don't assume unibyte strings are not bidi-reordered.
7744 (compute_display_string_pos)
7745 (compute_display_string_end): Fix handling the case of C string.
7746 (push_it, pop_it): Save and restore from_disp_prop_p.
7747 (handle_single_display_spec, push_display_prop): Set the
7748 from_disp_prop_p flag.
7749 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7750 (pop_it): Call iterate_out_of_display_property only if we are
7751 popping after iteration over a string that came from a display
7752 property. Fix a typo in popping stretch info. Add an assertion
7753 for verifying that the iterator position is in sync with the bidi
7754 iterator.
7755 (handle_single_display_spec, get_overlay_strings_1)
7756 (push_display_prop): Fix initialization of paragraph direction for
7757 string when that of the parent object is not yet determined.
7758 (reseat_1): Call bidi_init_it to resync the bidi
7759 iterator with IT's position. (Bug#7616)
7760 (find_row_edges): If ROW->start.pos gives position
7761 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7762 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7763 Reset the from_disp_prop_p flag.
7764 (SAVE_IT, RESTORE_IT): New macros.
7765 (pos_visible_p, face_before_or_after_it_pos)
7766 (back_to_previous_visible_line_start)
7767 (move_it_in_display_line_to, move_it_in_display_line)
7768 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7769 (try_scrolling, redisplay_window, display_line): Use them when
7770 saving a temporary copy of the iterator and restoring it back.
7771 (back_to_previous_visible_line_start, reseat_1)
7772 (init_iterator): Empty the bidi cache "stack".
7773 (move_it_in_display_line_to): If iterator ended up at
7774 EOL, but we never saw any buffer positions smaller than
7775 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7776 motion in bidi-reordered lines.
7777 (move_it_in_display_line_to): Record prev_method and prev_pos
7778 immediately before the call to set_iterator_to_next. Fixes cursor
7779 motion in bidi-reordered lines with stretch glyphs and strings
7780 displayed in margins. (Bug#8133) (Bug#8867)
7781 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7782 TO_CHARPOS.
640c8776
SM
7783 (pos_visible_p): Support positions in bidi-reordered lines.
7784 Save and restore bidi cache.
0bb23927
EZ
7785
7786 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7787 (bidi_paragraph_info): Delete unused struct.
7788 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7789 (bidi_cache_start): New variable.
7790 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7791 to zero.
7792 (bidi_cache_fetch_state, bidi_cache_search)
7793 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7794 (bidi_cache_find, bidi_peek_at_next_level)
7795 (bidi_level_of_next_char, bidi_find_other_level_edge)
7796 (bidi_move_to_visually_next): Compare cache index with
7797 bidi_cache_start rather than with zero.
7798 (bidi_fetch_char): Accept new argument STRING; all callers
7799 changed. Support iteration over a string. Support strings with
7800 display properties. Support unibyte strings. Fix the type of
7801 `len' according to what STRING_CHAR_AND_LENGTH expects.
7802 (bidi_paragraph_init, bidi_resolve_explicit_1)
7803 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7804 (bidi_level_of_next_char, bidi_move_to_visually_next):
7805 Support iteration over a string.
0bb23927
EZ
7806 (bidi_set_sor_type, bidi_resolve_explicit_1)
7807 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7808 can now be zero (for strings); special values 0 and -1 were
7809 changed to -1 and -2, respectively.
7810 (bidi_char_at_pos): New function.
7811 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7812 Call it instead of FETCH_MULTIBYTE_CHAR.
7813 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7814 initialized to valid values.
7815 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7816 values.
7817 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7818 the test for valid cached positions. Fix the logic for looking up
7819 the sentinel state in the cache. GCPRO the Lisp string we are
7820 iterating.
7821 (bidi_push_it, bidi_pop_it): New functions.
7822 (bidi_initialize): Initialize the bidi cache start stack pointer.
7823 (bidi_cache_ensure_space): New function, refactored from part of
7824 bidi_cache_iterator_state. Don't assume the required size is just
7825 one BIDI_CACHE_CHUNK away.
7826 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7827 (bidi_count_bytes, bidi_char_at_pos): New functions.
7828 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7829 always valid if bidi_cache_idx is valid.
7830 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7831 is valid if it's going to be used.
7832 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7833 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7834 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7835 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7836 (bidi_find_other_level_edge, bidi_cache_start_stack):
7837 All variables related to cache indices are now EMACS_INT.
c965adc5 7838
0bb23927
EZ
7839 * dispextern.h (struct bidi_string_data): New structure.
7840 (struct bidi_it): New member `string'. Make flag members be 1-bit
7841 fields, and put them last in the struct.
640c8776
SM
7842 (compute_display_string_pos, compute_display_string_end):
7843 Update prototypes.
0bb23927
EZ
7844 (bidi_push_it, bidi_pop_it): Add prototypes.
7845 (struct iterator_stack_entry): New members bidi_p,
7846 paragraph_embedding, and from_disp_prop_p.
7847 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7848 (bidi_shelve_cache, bidi_unshelve_cache):
7849 Declare prototypes.
0bb23927
EZ
7850
7851 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7852 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7853 and vector-like objects.
7854
7855 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7856 cache around display iteration.
7857
7858 * window.c (Fwindow_end, window_scroll_pixel_based)
7859 (displayed_window_lines, Frecenter): Save and restore the bidi
7860 cache around display iteration.
7861
3bbd2265
LMI
78622011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7863
7864 * editfns.c (Fdelete_region): Clarify the use of the named
7865 parameters (bug#6788).
7866
adc47434
MR
78672011-07-14 Martin Rudalics <rudalics@gmx.at>
7868
7869 * indent.c (Fvertical_motion): Set and restore w->pointm when
7870 saving and restoring the window's buffer (Bug#9006).
7871
837c31f8
LMI
78722011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7873
7874 * editfns.c (Fstring_to_char): Clarify just what is returned
7875 (bug#6576). Text by Eli Zaretskii.
7876
ac389d0c
JB
78772011-07-13 Juanma Barranquero <lekktu@gmail.com>
7878
7879 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7880
0be0ce47
EZ
78812011-07-13 Eli Zaretskii <eliz@gnu.org>
7882
7883 * buffer.c (mmap_find): Fix a typo.
7884
cd18e7e3
JB
78852011-07-13 Johan Bockgård <bojohan@gnu.org>
7886
7887 Fix execution of x selection hooks.
7888 * xselect.c (Qx_lost_selection_functions)
7889 (Qx_sent_selection_functions): New vars.
7890 (syms_of_xselect): DEFSYM them.
7891 (x_handle_selection_request): Pass Qx_sent_selection_functions
7892 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7893 (x_handle_selection_clear,x_clear_frame_selections):
7894 Pass Qx_lost_selection_functions rather than
7895 Vx_lost_selection_functions to Frun_hook_with_args.
7896
47ea7f44
PE
78972011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7898
ac389d0c 7899 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7900 The old code sometimes used this field without initializing it.
7901
47ea7f44
PE
7902 * alloc.c (gc_sweep): Don't read past end of array.
7903 In theory, the old code could also have corrupted Emacs internals,
7904 though it'd be very unlikely.
7905
bc985c87
AS
79062011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7907
7908 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7909 argument. (Bug#4026)
bc985c87 7910
0cf34688
LMI
79112011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7912
b3dadd76
LMI
7913 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7914 key" (bug#4257).
7915
0cf34688
LMI
7916 * window.c (Fset_window_start): Doc fix (bug#4199).
7917 (Fset_window_hscroll): Ditto.
7918
270768cd
PE
79192011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7920
077e3dda 7921 Fix minor new problems caught by GCC 4.6.1.
270768cd 7922 * term.c (init_tty): Remove unused local.
490011a6 7923 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7924 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7925 not used otherwise.
270768cd 7926
b1f58454
CY
79272011-07-12 Chong Yidong <cyd@stupidchicken.com>
7928
7929 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7930
22b9578d
LMI
79312011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7932
6e70ab07
LMI
7933 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7934 are the mini-buffer and the echo area (bug#3320).
7935
22b9578d
LMI
7936 * term.c (init_tty): Remove support for supdup, c10 and perq
7937 terminals, which are no longer supported (bug#1482).
7938
8974cc9f
JB
79392011-07-10 Johan Bockgård <bojohan@gnu.org>
7940
7941 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7942
a560d974
JD
79432011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7944
7945 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7946 for non-popups (Bug#3642).
7947
1dae0f0a
AS
79482011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7949
268c2c36 7950 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7951 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7952 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7953 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7954 * data.c (fmod): Likewise.
7955 * dispnew.c (swap_glyphs_in_rows): Likewise.
7956 * emacs.c (memory_warning_signal): Likewise.
7957 * floatfns.c (float_error): Likewise.
7958 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7959 (otf_open, font_otf_capability, generate_otf_features)
7960 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7961 Likewise.
7962 * image.c (pbm_read_file): Likewise.
7963 * indent.c (string_display_width): Likewise.
7964 * intervals.c (check_for_interval, search_for_interval)
7965 (inc_interval_count, count_intervals, root_interval)
7966 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7967 * lread.c (defalias): Likewise.
268c2c36 7968 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7969 * regex.c (set_image_of_range_1, set_image_of_range)
7970 (regex_grow_registers): Likewise.
7971 * sysdep.c (strerror): Likewise.
7972 * termcap.c (valid_filename_p, tprint, main): Likewise.
7973 * tparam.c (main): Likewise.
7974 * unexhp9k800.c (run_time_remap, save_data_space)
7975 (update_file_ptrs, read_header, write_header, calculate_checksum)
7976 (copy_file, copy_rest, display_header): Likewise.
7977 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7978 Likewise.
7979 * xdisp.c (check_it): Likewise.
7980 * xfaces.c (register_color, unregister_color, unregister_colors):
7981 Likewise.
7982 * xfns.c (print_fontset_result): Likewise.
7983 * xrdb.c (member, fatal, main): Likewise.
7984
99033785
PE
79852011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7986
7987 Fix minor problems found by static checking (Bug#9031).
7988 * chartab.c (char_table_set_range, map_sub_char_table):
7989 Remove unused locals.
7990 (uniprop_table): Now static.
7991 * composite.c (_work_char): Remove unused static var.
7992
9cb2ac56
JB
79932011-07-09 Juanma Barranquero <lekktu@gmail.com>
7994
7995 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7996
f25661f0
JD
79972011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7998
7999 * gtkutil.c (qttip_cb): Remove code without function.
8000
8278c4fe
EZ
80012011-07-09 Eli Zaretskii <eliz@gnu.org>
8002
8003 * w32.c (pthread_sigmask): New stub.
8004
1692ae2d 80052011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8006
8a6ebd58 8007 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8008 sigprocmask is portable only for single-threaded applications, and
8009 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8010 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8011 (LIBES): Use it.
8012 * callproc.c (Fcall_process):
8013 * process.c (create_process):
8014 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8015 Use pthread_sigmask, not sigprocmask.
123403e4 8016
1b854618
JD
80172011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8018
8019 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8020 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8021 wrong (Bug#8591).
8022
3fe4b549
JD
80232011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8024
0ce7e563
JD
8025 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8026 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8027 (xg_hide_tooltip): Fix comment.
8028
3fe4b549
JD
8029 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8030 in registerServicesMenuSendTypes.
8031 (validRequestorForSendType): Don't check ns_return_types.
8032
8033 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8034 ns_return_type.
8035
5df75e47
JR
80362011-07-08 Jason Rumney <jasonr@gnu.org>
8037
22610910
JR
8038 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8039 SH_SHOW for hidden windows (Bug#5482).
8040
5df75e47
JR
8041 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8042 frame struct members of non-existent frames (Bug#6284).
8043
699c10bd
JD
80442011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8045
4393663b
JD
8046 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8047 variable firstTime not needed on OSX >= 10.6.
8048 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8049 >= 10.5. Use setKnobProportion, setDoubleValue.
8050
8051 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8052 (MAC_OS_X_VERSION_10_5): Define if not defined.
8053 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8054 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8055 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8056
8057 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8058 cString and lossyCString on OSX >= 10.4.
4393663b 8059
58179cce 8060 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8061 sizeToFit on OSX >= 10.2.
8062
8063 * nsimage.m (allocInitFromFile): Don't use deprecated method
8064 bestRepresentationForDevice on OSX >= 10.6.
8065
8066 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8067 to avoid warning.
8068
8069 * emacs.c: Declare unexec_init_emacs_zone.
8070
a63e0781
JD
8071 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8072
699c10bd
JD
8073 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8074
8075 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8076 on svcsMenu (Bug#8842).
8077
8078 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8079 ns_return_types.
8080 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8081
8082 * nsterm.m (QUTF8_STRING): Declare.
8083 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8084 (validRequestorForSendType): Return type is (id).
8085 Change indexOfObjectIdenticalTo to indexOfObject.
8086 Check if we have local selection before returning self (Bug#8842).
8087 (writeSelectionToPasteboard): Put local selection into paste board
8088 if we have a local selection (Bug#8842).
8089 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8090
8091 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8092 (ns_get_local_selection): Declare.
8093
54e10184
LMI
80942011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8095
9888ff71
LMI
8096 * keymap.c (describe_map_tree): Don't insert a double newline at
8097 the end of the buffer (bug#1169) and return whether we inserted
8098 something.
8099
54e10184
LMI
8100 * callint.c (Fcall_interactively): Change "reading args" to
8101 "providing args" to try to clarify what it does (bug#1010).
8102
15fa4783
KH
81032011-07-07 Kenichi Handa <handa@m17n.org>
8104
8105 * composite.c (composition_compute_stop_pos): Ignore a static
8106 composition starting before CHARPOS (Bug#8915).
8107
8108 * xdisp.c (handle_composition_prop): Likewise.
8109
a8815b00
EZ
81102011-07-07 Eli Zaretskii <eliz@gnu.org>
8111
8112 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8113 (Bug#9015)
8114
ef7b981d 81152011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8116
8117 * character.h (unicode_category_t): New enum type.
8118
8119 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8120 (Qchar_code_property_table): New variable.
8121 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8122 (UNIPROP_COMPRESSED_FORM_P): New macros.
8123 (char_table_ascii): Uncompress the compressed values.
8124 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8125 Uncompress the compressed values.
ac389d0c 8126 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8127 (char_table_ref_and_range): Uncompress the compressed values.
8128 (sub_char_table_set): New arg is_uniprop. Callers changed.
8129 Uncompress the compressed values.
8130 (sub_char_table_set_range): Args changed. Callers changed.
8131 (char_table_set_range): Adjuted for the above change.
8132 (map_sub_char_table): Delete args default_val and parent. Add arg
8133 top. Give decoded values to a Lisp function.
640c8776 8134 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8135 values to a Lisp function. Gcpro more variables.
8136 (uniprop_table_uncompress)
8137 (uniprop_decode_value_run_length): New functions.
8138 (uniprop_decoder, uniprop_decoder_count): New variables.
8139 (uniprop_get_decoder, uniprop_encode_value_character)
8140 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8141 New functions.
8142 (uniprop_encoder, uniprop_encoder_count): New variables.
8143 (uniprop_get_encoder, uniprop_table)
8144 (Funicode_property_table_internal, Fget_unicode_property_internal)
8145 (Fput_unicode_property_internal): New functions.
8146 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8147 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 8148 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
8149 char-code-property-alist.
8150
640c8776 8151 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
8152 Vunicode_category_table.
8153
640c8776 8154 * font.c (font_range): Adjust for the change of
c805dec0
KH
8155 Vunicode_category_table.
8156
76b397fb
DN
81572011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8158
8159 * m/iris4d.h: Remove file, move contents ...
8160 * s/irix6-5.h: ... here.
8161
22b4128e
PE
81622011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8163
8164 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
8165 * alloc.c (mark_buffer):
8166 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8167 (clone_per_buffer_values): Don't assume that
22b4128e
PE
8168 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8169 This isn't true in general, and it's particularly not true
8170 if Emacs is configured with --with-wide-int.
8171 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8172 New macros, used in the buffer.c change.
8173
869795d6
JD
81742011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8175
8176 * xsettings.c: Use both GConf and GSettings if both are available.
8177 (store_config_changed_event): Add comment.
8178 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8179 (store_tool_bar_style_changed): New functions.
5e617bc2 8180 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
8181 (struct xsettings): Move font inside HAVE_XFT.
8182 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 8183 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 8184 Move inside HAVE_XFT.
640c8776 8185 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
8186 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8187 also.
8188 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 8189 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 8190 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
8191 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8192 (parse_settings): Move check for font inside HAVE_XFT.
8193 (read_settings, apply_xft_settings): Add comment.
8194 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8195 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8196 call store_font_name_changed.
8197 (xft_settings_event): Add comment.
8198 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8199 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8200 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8201 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8202 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
8203 (xsettings_get_system_font, xsettings_get_system_normal_font):
8204 Add comment.
869795d6 8205
d8ed26bd
PE
82062011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8207
8208 Random fixes. E.g., (random) never returned negative values.
8209 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8210 subseconds part to the entropy, as that's a bit more random.
8211 Prefer signed to unsigned, since the signedness doesn't matter and
8212 in general we prefer signed. When given a limit, use a
8213 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8214 latter isn't right if USE_2_TAGS_FOR_INTS.
8215 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8216 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8217
cabf1cac
SM
82182011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8219
8220 * textprop.c (text_property_stickiness):
8221 Obey Vtext_property_default_nonsticky.
8222 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8223 * w32fns.c (syms_of_w32fns):
8224 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8225
6e9b2be9
PE
82262011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8227
8228 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8229 This is more efficient than Ffile_directory_p and avoids a minor race.
8230
90186c68
LMI
82312011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8232
7c301272
LMI
8233 * buffer.c (Foverlay_put): Say what the return value is
8234 (bug#7835).
8235
c4f2d8d4
LMI
8236 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8237 is a directory before asking whether to use the file name
8238 (bug#7564).
ad637907
LMI
8239 (barf_or_query_if_file_exists): Make the "File is a directory"
8240 error be more correct.
c4f2d8d4 8241
90186c68
LMI
8242 * fns.c (Frequire): Remove the mention of the .gz files, since
8243 that's installation-specific, but keep the mention of
8244 `get-load-suffixes'.
8245
da64016e
PE
82462011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8247
8248 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8249 Report string overflow if the output is too long.
8250
7d47b580
JB
82512011-07-04 Juanma Barranquero <lekktu@gmail.com>
8252
a555cb87
JB
8253 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8254 (syms_of_gnutls): Remove duplicate DEFSYM for
8255 Qgnutls_bootprop_verify_hostname_error, an error for
8256 Qgnutls_bootprop_verify_error (which is no longer used).
8257
7d47b580
JB
8258 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8259 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8260 Also (re)move comments that are misplaced or no longer relevant.
8261
1e49bfab
LMI
82622011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8263
8264 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8265
1485f4c0
CY
82662011-07-03 Chong Yidong <cyd@stupidchicken.com>
8267
8268 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8269 and background color parameters if they have been changed.
8270
a9ab721e
LMI
82712011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8272
8273 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8274
cf7cff57
PE
82752011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8276
2e13213d
PE
8277 * xsettings.c (SYSTEM_FONT): Define only when used.
8278 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8279
cf7cff57
PE
8280 * keymap.c (access_keymap_1): Now static.
8281
7a8e04f7
CY
82822011-07-02 Chong Yidong <cyd@stupidchicken.com>
8283
8284 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8285 leave any prefix arg for the up event (Bug#1586).
8286
61352f62
LMI
82872011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8288
69bb1ef7
LMI
8289 * lread.c (syms_of_lread): Mention single symbols defined by
8290 `defvar' or `defconst' (bug#7154).
8291
61352f62 8292 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8293 (Frequire): Mention get-load-suffixes.
61352f62 8294
28545e04
MR
82952011-07-02 Martin Rudalics <rudalics@gmx.at>
8296
8297 * window.h (window): Remove clone_number slot.
8298 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8299 Remove.
8300 (make_parent_window, make_window, saved_window)
8301 (Fset_window_configuration, save_window_save): Don't deal with
8302 clone numbers.
8303 * buffer.c (Qclone_number): Remove declaration.
8304 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8305
3349e122
SM
83062011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8307
8308 Add multiple inheritance to keymaps.
8309 * keymap.c (Fmake_composed_keymap): New function.
8310 (Fset_keymap_parent): Simplify.
8311 (fix_submap_inheritance): Remove.
8312 (access_keymap_1): New function extracted from access_keymap to handle
8313 embedded parents and handle lists of maps.
8314 (access_keymap): Use it.
8315 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8316 (Fcopy_keymap): Handle embedded parents.
8317 (Fcommand_remapping, define_as_prefix): Simplify.
8318 (Fkey_binding): Simplify.
8319 (syms_of_keymap): Move minibuffer-local-completion-map,
8320 minibuffer-local-filename-completion-map,
8321 minibuffer-local-must-match-map, and
8322 minibuffer-local-filename-must-match-map to Elisp.
8323 (syms_of_keymap): Defsubr make-composed-keymap.
8324 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8325 (parse_menu_item): Trivial simplification.
8326
3279eb87
GM
83272011-07-01 Glenn Morris <rgm@gnu.org>
8328
8329 * Makefile.in (SETTINGS_LIBS): Fix typo.
8330
4550efdf
KI
83312011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8332
8333 * coding.c (Fencode_coding_string): Record the last coding system
8334 used, as the function doc string says (bug#8738).
8335
0949d2b6
JD
83362011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8337
8338 * xsettings.c (store_monospaced_changed): Take new font as arg and
8339 check for change against current_mono_font.
8340 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8341 (emacs_settings_constructor, emacs_settings_get_property)
8342 (emacs_settings_set_property, emacs_settings_class_init)
8343 (emacs_settings_init, gsettings_obj): Remove.
8344 (something_changedCB): New function for HAVE_GSETTINGS.
8345 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8346 with value as argument.
8347 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8348 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8349 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8350 "changed".
8351
8352 * xgselect.c: Add defined (HAVE_GSETTINGS).
8353 (xgselect_initialize): Ditto.
8354
8355 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8356 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8357 xg_select.
8358
bbc6b304
PE
83592011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8360
8361 * eval.c (struct backtrace): Simplify and port the data structure.
8362 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8363 signed bit field, as this assumption is not portable and it makes
8364 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8365 "char debug_on_exit : 1" as this is not portable either; instead,
8366 use the portable "unsigned int debug_on_exit : 1". Remove unused
8367 member evalargs. Remove obsolete comments about cc bombing out.
8368
9851bfc5
JD
83692011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8370
51bb811f 8371 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8372 Let HAVE_GSETTINGS override HAVE_GCONF.
8373 (store_monospaced_changed): New function.
8374 (EMACS_SETTINGS): A new type derived from GObject to handle
8375 GSettings notifications.
8376 (emacs_settings_constructor, emacs_settings_get_property)
8377 (emacs_settings_set_property, emacs_settings_class_init):
8378 New functions.
8379 (gsettings_client, gsettings_obj): New variables.
8380 (GSETTINGS_SCHEMA): New define.
8381 (something_changedCB): Call store_monospaced_changed.
8382 (init_gsettings): New function.
8383 (xsettings_initialize): Call init_gsettings.
8384 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8385 to NULL.
8386
640c8776 8387 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8388 GCONF_CFLAGS/LIBS.
8389
5386012d
MR
83902011-06-29 Martin Rudalics <rudalics@gmx.at>
8391
8392 * window.c (resize_root_window, grow_mini_window)
8393 (shrink_mini_window): Rename Qresize_root_window to
8394 Qwindow_resize_root_window and Qresize_root_window_vertically to
8395 Qwindow_resize_root_window_vertically.
8396
f13e0b08
PE
83972011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8398
8399 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8400
94515237
JB
84012011-06-27 Juanma Barranquero <lekktu@gmail.com>
8402
8403 * makefile.w32-in: Redesign dependencies so they reflect more
8404 clearly which files are directly included by each source file,
8405 and not through other includes.
8406
e43b6e43
MR
84072011-06-27 Martin Rudalics <rudalics@gmx.at>
8408
8409 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8410 (sort_overlays, overlay_strings): When an overlay's clone number
8411 matches the window's clone number process the overlay even if
8412 the overlay's window property doesn't match the current window.
8413
d68443dc
MR
8414 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8415 (Fwindow_hchild): Rename to Fwindow_left_child.
8416 (Fwindow_next): Rename to Fwindow_next_sibling.
8417 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8418 (resize_window_check): Rename to window_resize_check.
8419 (resize_window_apply): Rename to window_resize_apply.
8420 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8421 (Fdelete_other_windows_internal, resize_frame_windows)
8422 (Fsplit_window_internal, Fdelete_window_internal)
8423 (grow_mini_window, shrink_mini_window)
8424 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8425
c7e73be5
JD
84262011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8427
8428 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8429 (emacs_fixed_set_min_size): Remove.
8430 (emacs_fixed_new): Take frame as argument.
8431
8432 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8433 (_EmacsFixedPrivate): Remove minwidth/height.
8434 Add struct frame *f.
8435 (emacs_fixed_init): Initialize priv->f.
8436 (get_parent_class, emacs_fixed_set_min_size): Remove.
8437 (emacs_fixed_new): Set priv->f to argument.
8438 (emacs_fixed_get_preferred_width)
8439 (emacs_fixed_get_preferred_height): Use min_width/height from
8440 frames size_hint to set minimum and natural (Bug#8919).
8441 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8442 and use min_width/height from frames size_hint to set
8443 min_width/height (Bug#8919).
8444
8445 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8446 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8447 Fix indentation.
c7e73be5 8448
cf99dcf8
EZ
84492011-06-26 Eli Zaretskii <eliz@gnu.org>
8450
8451 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8452 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8453 called at ZV.
8454
029529ac
CY
84552011-06-26 Chong Yidong <cyd@stupidchicken.com>
8456
8457 * process.c (wait_reading_process_output): Bypass select if
8458 waiting for a cell while ignoring keyboard input, and input is
8459 pending. Suggested by Jan Djärv (Bug#8869).
8460
7a7ef429
PE
84612011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8462
8463 Use gnulib's dup2 module instead of rolling our own.
8464 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8465
11fdef7d 84662011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8467
8468 * dispnew.c (scrolling_window): Before scrolling, turn off a
8469 mouse-highlight in the window being scrolled.
8470
cd3520a4
JB
84712011-06-24 Juanma Barranquero <lekktu@gmail.com>
8472
8473 Move DEFSYM to lisp.h and use everywhere.
8474
8475 * character.h (DEFSYM): Move declaration...
8476 * lisp.h (DEFSYM): ...here.
8477
8478 * gnutls.c:
8479 * minibuf.c:
8480 * w32menu.c:
8481 * w32proc.c:
8482 * w32select.c: Don't include character.h.
8483
8484 * alloc.c (syms_of_alloc):
8485 * buffer.c (syms_of_buffer):
8486 * bytecode.c (syms_of_bytecode):
8487 * callint.c (syms_of_callint):
8488 * casefiddle.c (syms_of_casefiddle):
8489 * casetab.c (init_casetab_once):
8490 * category.c (init_category_once, syms_of_category):
8491 * ccl.c (syms_of_ccl):
8492 * cmds.c (syms_of_cmds):
8493 * composite.c (syms_of_composite):
8494 * dbusbind.c (syms_of_dbusbind):
8495 * dired.c (syms_of_dired):
8496 * dispnew.c (syms_of_display):
8497 * doc.c (syms_of_doc):
8498 * editfns.c (syms_of_editfns):
8499 * emacs.c (syms_of_emacs):
8500 * eval.c (syms_of_eval):
8501 * fileio.c (syms_of_fileio):
8502 * fns.c (syms_of_fns):
8503 * frame.c (syms_of_frame):
8504 * fringe.c (syms_of_fringe):
8505 * insdel.c (syms_of_insdel):
8506 * keymap.c (syms_of_keymap):
8507 * lread.c (init_obarray, syms_of_lread):
8508 * macros.c (syms_of_macros):
8509 * msdos.c (syms_of_msdos):
8510 * print.c (syms_of_print):
8511 * process.c (syms_of_process):
8512 * search.c (syms_of_search):
8513 * sound.c (syms_of_sound):
8514 * syntax.c (init_syntax_once, syms_of_syntax):
8515 * terminal.c (syms_of_terminal):
8516 * textprop.c (syms_of_textprop):
8517 * undo.c (syms_of_undo):
8518 * w32.c (globals_of_w32):
8519 * window.c (syms_of_window):
8520 * xdisp.c (syms_of_xdisp):
8521 * xfaces.c (syms_of_xfaces):
8522 * xfns.c (syms_of_xfns):
8523 * xmenu.c (syms_of_xmenu):
8524 * xsettings.c (syms_of_xsettings):
8525 * xterm.c (syms_of_xterm): Use DEFSYM.
8526
4228cf16
TZ
85272011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8528
cd3520a4 8529 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8530
7fcccf1e
PE
85312011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8532
7efb4e0e
PE
8533 Integer and buffer overflow fixes (Bug#8873).
8534
ff5844ad
PE
8535 * print.c (printchar, strout): Check for string overflow.
8536 (PRINTPREPARE, printchar, strout):
8537 Don't set size unless allocation succeeds.
8538
90532f02
PE
8539 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8540 for sizes. Check for string overflow more accurately.
8541 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8542
6d84508d
PE
8543 * macros.c: Integer and buffer overflow fixes.
8544 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8545 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8546 Use ptrdiff_t, not int, for sizes.
8547 Don't increment bufsize until after realloc succeeds.
8548 Check for size-calculation overflow.
8549 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8550
437b2cb4
PE
8551 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8552
8b9ac8b4
PE
8553 * lread.c: Integer overflow fixes.
8554 (read_integer): Radix is now EMACS_INT, not int,
8555 to improve quality of diagnostics for out-of-range radices.
8556 Calculate buffer size correctly for out-of-range radices.
8557 (read1): Check for integer overflow in radices, and in
8558 read-circle numbers.
82cb60d3
PE
8559 (read_escape): Avoid int overflow.
8560 (Fload, openp, read_buffer_size, read1)
8561 (substitute_object_recurse, read_vector, read_list, map_obarray):
8562 Use ptrdiff_t, not int, for sizes.
8563 (read1): Use EMACS_INT, not int, for sizes.
20270765 8564 Check for size overflow.
8b9ac8b4 8565
7fcccf1e
PE
8566 * image.c (cache_image): Check for size arithmetic overflow.
8567
bfbbd7e7
PE
8568 * lread.c: Integer overflow issues.
8569 (saved_doc_string_size, saved_doc_string_length)
8570 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8571 Now ptrdiff_t, not int.
8572 (read1): Don't assume doc string length fits in int. Check for
8573 out-of-range doc string lengths.
8574 (read_list): Don't assume file position fits in int.
39019e54 8575 (read_escape): Check for hex character overflow.
bfbbd7e7 8576
4e323265
LL
85772011-06-22 Leo Liu <sdl.web@gmail.com>
8578
8579 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8580 Move to minibuffer.el.
8581
85fece3e
PE
85822011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8583
20b84ce9 8584 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8585 The following patches are for when GLYPH_DEBUG && !XASSERT.
8586 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8587 * dispnew.c (flush_stdout):
8588 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8589 Mark as externally visible.
8590 * dispnew.c (check_window_matrix_pointers): Now static.
8591 * dispnew.c (window_to_frame_vpos):
8592 * xfns.c (unwind_create_frame):
8593 * xterm.c (x_check_font): Remove unused local.
8594 * scroll.c (CHECK_BOUNDS):
8595 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8596 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8597 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8598 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8599 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8600 Now static.
8601 (debug_method_add): Use va_list and vsprintf rather than relying
8602 on undefined behavior with wrong number of arguments.
8603 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8604 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8605 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8606 since we're not interested in debugging glyphs with old libraries.
8607 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8608 GCC 4.6.0's static checking.
8609
0766b489
PE
86102011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8611
31fd4b32
PE
8612 Integer overflow and signedness fixes (Bug#8873).
8613 A few related buffer overrun fixes, too.
8614
b79e8648
PE
8615 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8616
0766b489
PE
8617 * dispextern.h (struct face.stipple):
8618 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8619 (x_bitmap_mask, x_allocate_bitmap_record)
8620 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8621 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8622 (x_create_bitmap_from_xpm_data):
8623 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8624 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8625 (.bitmaps_last):
8626 * xfaces.c (load_pixmap):
8627 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8628 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8629 (.bitmaps_last, struct x_output.icon_bitmap):
8630 Use ptrdiff_t, not int, for bitmap indexes.
8631 (x_allocate_bitmap_record): Check for size overflow.
8632 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8633
b081724f
PE
8634 Use ptrdiff_t, not int, for overlay counts.
8635 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8636 * editfns.c (overlays_around, get_pos_property):
8637 * textprop.c (get_char_property_and_overlay):
8638 * xdisp.c (next_overlay_change, note_mouse_highlight):
8639 * xfaces.c (face_at_buffer_position):
21514da7
PE
8640 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8641 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8642 (Fnext_overlay_change, Fprevious_overlay_change)
8643 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8644 Use ptrdiff_t, not int, for sizes.
21514da7 8645 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8646
3de73e5e
PE
8647 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8648
2606c57b
PE
8649 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8650 (x_session_initialize): Do not assume string length fits in int.
8651
aaafe47a
PE
8652 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8653 This is unlikely, but can occur if DPI is outlandish.
8654
2674ddc8 8655 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8656 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8657
28154962
PE
8658 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8659 * xrdb.c (magic_file_p, search_magic_path):
8660 Omit last arg SUFFIX; it was always 0. All callers changed.
8661 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8662
7de51af5
PE
8663 * xfont.c (xfont_match): Avoid need for strlen.
8664
25ed6cc3
PE
8665 * xfns.c: Don't assume strlen fits in int.
8666 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8667
4eab31dd
PE
8668 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8669 not unsigned long, as we prefer signed integers. All callers changed.
8670 Detect integer overflow in repeat count.
8671 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8672 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8673
171e2a58
PE
8674 * termcap.c: Don't assume sizes fit in int and never overflow.
8675 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8676 (gobble_line): Check for size-calculation overflow.
8677
ad39faca 8678 * minibuf.c (Fread_buffer):
6e5bb2dc 8679 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8680 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8681 Don't assume string length fits in int.
8682
52c61c22 8683 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8684 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8685
b5b8c9e5
PE
8686 * font.c: Don't assume string length fits in int.
8687 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8688 Use ptrdiff_t, not int.
ccd6111c
PE
8689 (font_intern_prop): Don't assume string length fits in int.
8690 Don't assume integer property fits in fixnum.
8691 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8692
882f0d81 8693 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8694 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8695 Reformulate so as not to need the command string.
8696 Invoke gzip -cd rather than gunzip, as it's more portable.
8697 (lock_info_type, lock_file_1, lock_file):
8698 Don't assume pid_t and time_t fit in unsigned long.
8699 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8700 (current_lock_owner): Prefer signed type for sizes.
8701 Use memcpy, not strncpy, where memcpy is what is really wanted.
8702 Don't assume (via atoi) that time_t and pid_t fit in int.
8703 Check for time_t and/or pid_t out of range, e.g., via a network share.
8704 Don't alloca where an auto var works fine.
8705
93f4cf88
PE
8706 * fileio.c: Fix some integer overflow issues.
8707 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8708 Don't assume string length fits in int.
8709 (directory_file_name): Don't assume string length fits in long.
8710 (make_temp_name): Don't assume pid fits in int, or that its print
8711 length is less than 20.
8712
f3e92b69
PE
8713 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8714
1bfdaf10
PE
8715 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8716
35016e9a
PE
8717 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8718
3d1e65a1
PE
8719 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8720 We prefer signed integers, even for size calculations.
8721
0b963a93
PE
8722 * emacs.c: Don't assume string length fits in 'int'.
8723 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8724 (main): Don't invoke strlen when not needed.
8725
573f4b54
PE
8726 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8727 (XD_DEBUG_MESSAGE): Don't waste a byte.
8728
989f33ba
PE
8729 * callproc.c (getenv_internal_1, getenv_internal)
8730 (Fgetenv_internal):
965d34eb
PE
8731 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8732
e4d29b33
PE
8733 * lread.c (invalid_syntax): Omit length argument.
8734 All uses changed. This doesn't fix a bug, but it simplifies the
8735 code away from its former Hollerith-constant appearance, and it's
8736 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8737 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8738
eb49b136
PE
8739 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8740 This didn't break anything, but it didn't help either.
8741 It's confusing to put a bogus integer in a place where the actual
8742 value does not matter.
9f62aeb1 8743 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8744 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8745
15375a22
PE
8746 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8747 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8748 implementation.
b61cc01c
PE
8749 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8750 We prefer signed types, and the value cannot exceed the EMACS_INT
8751 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8752 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8753 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8754 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8755
53b2623d
PE
8756 * indent.c (sane_tab_width): New function.
8757 (current_column, scan_for_column, Findent_to, position_indentation)
8758 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8759 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8760
51cab52b 8761 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8762
f2ed8a70
PE
8763 * lisp.h (lint_assume): New macro.
8764 * composite.c (composition_gstring_put_cache):
8765 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8766
abe80cc6
PE
8767 * editfns.c, insdel.c:
8768 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8769
b02c740e
PE
8770 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8771
ebc96716
PE
8772 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8773
b4e50fa0 8774 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8775 Use much-faster test for byte-length change.
311d5d7c 8776 Don't assume string byte-length fits in 'int'.
a4cf38e4 8777 Check that character arg fits in 'int'.
85461888 8778 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8779
c0c1ee9f
PE
8780 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8781
a498d7f4
PE
8782 * fns.c (concat): Catch string overflow earlier.
8783 Do not rely on integer wraparound.
8784
51cab52b
PE
8785 * dispextern.h (struct it.overlay_strings_charpos)
8786 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8787 * xdisp.c (forward_to_next_line_start)
8788 (back_to_previous_visible_line_start)
8789 (reseat_at_next_visible_line_start, next_element_from_buffer):
8790 Don't arbitrarily truncate the value of 'selective' to int.
8791
76031fad
PE
8792 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8793
5eb55db9
PE
8794 * composite.c: Don't truncate sizes to 'int'.
8795 (composition_gstring_p, composition_reseat_it)
8796 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8797 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8798 not EMACS_UINT, for indexes.
5eb55db9 8799
0703a717
PE
8800 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8801
d6202519
PE
8802 * buffer.c: Include <verify.h>.
8803 (struct sortvec.priority, struct sortstr.priority):
8961a454 8804 Now EMACS_INT, not int.
c20998a7 8805 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8806 (struct sortstr.size, record_overlay_string)
8807 (struct sortstrlist.size, struct sortlist.used):
8808 Don't truncate size to int.
8809 (record_overlay_string): Check for size-calculation overflow.
d6202519 8810 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8811
d5a19415
JM
88122011-06-22 Jim Meyering <meyering@redhat.com>
8813
029529ac 8814 Don't leak an XBM-image-sized buffer
d5a19415
JM
8815 * image.c (xbm_load): Free the image buffer after using it.
8816
a9041e6c
PE
88172011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8818
8819 Port to Sun C.
8820 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8821 that Sun C diagnosed.
8822 * fns.c (secure_hash): Fix pointer signedness issue.
8823 * intervals.c (static_offset_intervals): New function.
8824 (offset_intervals): Use it.
8825
7f3f739f
LL
88262011-06-21 Leo Liu <sdl.web@gmail.com>
8827
8828 * deps.mk (fns.o):
8829 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8830 sha512.h.
8831
8832 * fns.c (secure_hash): Rename from crypto_hash_function and change
8833 the first arg to accept symbols.
5b66d427 8834 (Fsecure_hash): New primitive.
7f3f739f
LL
8835 (syms_of_fns): New symbols.
8836
76147d94
DD
88372011-06-20 Deniz Dogan <deniz@dogan.se>
8838
8839 * process.c (Fset_process_buffer): Clarify return value in
8840 docstring.
8841
7d7d0045
CY
88422011-06-18 Chong Yidong <cyd@stupidchicken.com>
8843
8844 * dispnew.c (add_window_display_history): Use BVAR.
8845
8846 * xdisp.c (debug_method_add): Use BVAR.
8847 (check_window_end, dump_glyph_matrix, dump_glyph)
8848 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8849
8850 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8851 Likewise.
8852
8853 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8854 check till after the cache is created in init_frame_faces.
8855
ff2bc410
SM
88562011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8857
8858 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8859
28177add
PE
88602011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8861
dd3482fe
PE
8862 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8863 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8864 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8865
393d71f3 8866 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8867 * fileio.c (Finsert_file_contents):
8868 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8869 Remove the old (too-loose) buffer overflow checks.
8870 They weren't needed, since make_gap checks for buffer overflow.
8871 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8872 The old code merely checked for Emacs fixnum overflow, and relied
8873 on undefined (wraparound) behavior. The new code avoids undefined
8874 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8875
2e6813b0 8876 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8877 Tune. Don't use wider integers than needed. Don't use alloca.
8878 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8879
599a9e4f
PE
8880 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8881
99561444
PE
8882 * insdel.c, lisp.h (buffer_overflow): New function.
8883 (insert_from_buffer_1, replace_range, replace_range_2):
8884 * insdel.c (make_gap_larger):
8885 * editfns.c (Finsert_char):
8886 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8887
28177add
PE
8888 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8889
e69dafad
PE
88902011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8891
4baa020d 8892 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8893
b1c46f02
PE
8894 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8895 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8896
e69dafad
PE
8897 * fileio.c: Don't assume EMACS_INT fits in off_t.
8898 (emacs_lseek): New static function.
8899 (Finsert_file_contents, Fwrite_region): Use it.
8900 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8901
566684ea
PE
8902 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8903
e6966cd6
PE
8904 * fns.c: Don't overflow int when computing a list length.
8905 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8906 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8907 truncation on 64-bit hosts. Check for QUIT every
8908 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8909 faster and is responsive enough.
8910 (Flength): Report an error instead of overflowing an integer.
8911 (Fsafe_length): Return a float if the value is not representable
8912 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8913 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8914 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8915
dd0b0efb
PE
8916 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8917 (header_size, word_size): New constants.
8918 (allocate_vectorlike): Don't check size overflow here.
8919 (allocate_vector): Check it here instead, since this is the only
8920 caller of allocate_vectorlike that could cause overflow.
8921 Check that the new vector's length is representable as a fixnum.
8922
86fe5cfe
PE
8923 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8924 The previous code was bogus. For example, next_almost_prime (32)
8925 returned 39, which is undesirable as it is a multiple of 3; and
8926 next_almost_prime (24) returned 25, which is a multiple of 5 so
8927 why was the code bothering to check for multiples of 7?
8928
80e88859
PE
8929 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8930
4a2f0ad6
PE
8931 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8932
f66c7cf8
PE
8933 Variadic C functions now count arguments with ptrdiff_t.
8934 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8935 Back then I didn't know that the Emacs coding style prefers signed int.
8936 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8937 were being counted with int, which may truncate counts on 64-bit
8938 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8939 * lisp.h (struct Lisp_Subr.function.aMANY)
8940 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8941 Arg counts are now ptrdiff_t, not size_t.
8942 All variadic functions and their callers changed accordingly.
8943 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8944 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8945 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8946 * callint.c (Fcall_interactively): Check arg count for overflow,
8947 to avoid potential buffer overrun. Use signed char, not 'int',
8948 for 'varies' array, so that we needn't bother to check its size
8949 calculation for overflow.
8950 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8951 * eval.c (apply_lambda):
8952 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8953 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8954 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8955
a1759b76
PE
8956 * callint.c (Fcall_interactively): Don't use index var as event count.
8957
d96be9fc
PE
8958 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8959 * mem-limits.h (SIZE): Remove; no longer used.
8960
a690a978 8961 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8962
578c21e6
PE
8963 Remove unnecessary casts.
8964 * xterm.c (x_term_init):
8965 * xfns.c (x_set_border_pixel):
8966 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8967 These aren't needed now that we assume ANSI C.
8968
96f53c6c
PE
8969 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8970 It's more likely to cause problems (due to unsigned overflow)
8971 than to cure them.
8972
83c77d31
PE
8973 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8974
ee2079f1
PE
8975 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8976
6da65536
PE
8977 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8978
7147c4a4
PE
8979 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8980
193e32d9
PE
8981 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8982
e5533da6
PE
8983 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8984
9910e595
PE
8985 GLYPH_CODE_FACE returns EMACS_INT, not int.
8986 * dispextern.h (merge_faces):
8987 * xfaces.c (merge_faces):
01103c44
PE
8988 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8989 Don't assume EMACS_INT fits in int.
9910e595 8990
2638320e
PE
8991 * character.h (CHAR_VALID_P): Remove unused parameter.
8992 * fontset.c, lisp.h, xdisp.c: All uses changed.
8993
045eb8d9
PE
8994 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8995
c1f134b5
PE
8996 * fns.c (concat): Minor tuning based on overflow analysis.
8997 This doesn't fix any bugs. Use int to hold character, instead
8998 of constantly refetching from Emacs object. Use XFASTINT, not
8999 XINT, for value known to be a character. Don't bother comparing
9000 a single byte to 0400, as it's always less.
9001
395fcb93 9002 * floatfns.c (Fexpt):
327eeec8
PE
9003 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9004
abbd3d23
PE
9005 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9006 for characters.
9007
684a03ef
PE
9008 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9009
0fed43f3
PE
9010 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9011 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9012 incorrectly succeed when S was a string, because 4294967386 was
9013 truncated before it was used.
9014
8fd02eb7
PE
9015 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9016 Otherwise, an out-of-range integer could cause undefined behavior
9017 on a 64-bit host.
9018
f8c86b69
PE
9019 * composite.c: Use int, not EMACS_INT, for characters.
9020 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9021 EMACS_INT, for values that are known to be in character range.
9022 This doesn't fix any bugs but is the usual style inside Emacs and
9023 may generate better code on 32-bit machines.
9024
34206dd2
PE
9025 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9026 This is for reasons similar to the recent CHAR_STRING fix.
9027 * charset.c (Fencode_char): Check that character arg is actually
9028 a character. Pass an int to ENCODE_CHAR.
9029 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9030 wider than 'int', as a compile-time check to prevent future regressions
9031 in this area.
9032
c5958d4c 9033 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9034
9035 Make sure a 64-bit char is never passed to CHAR_STRING.
9036 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9037 by silently ignoring the top 32 bits, allowing some values
9038 that were far too large to be valid characters.
9039 * character.h: Include <verify.h>.
9040 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9041 arguments are no wider than unsigned, as a compile-time check
9042 to prevent future regressions in this area.
9043 * data.c (Faset):
01103c44 9044 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9045 (Fsubst_char_in_region):
9046 * fns.c (concat):
9047 * xdisp.c (decode_mode_spec_coding):
9048 Adjust to CHAR_STRING's new requirement.
9049 * editfns.c (Finsert_char, Fsubst_char_in_region):
9050 * fns.c (concat): Check that character args are actually
9051 characters. Without this test, these functions did the wrong
9052 thing with wildly out-of-range values on 64-bit hosts.
9053
d37ca623
PE
9054 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9055 These casts should not be needed on 32-bit hosts, either.
9056 * keyboard.c (read_char):
9057 * lread.c (Fload): Remove casts to unsigned.
9058
ea204efb
PE
9059 * lisp.h (UNSIGNED_CMP): New macro.
9060 This fixes comparison bugs on 64-bit hosts.
9061 (ASCII_CHAR_P): Use it.
9062 * casefiddle.c (casify_object):
01103c44 9063 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9064 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9065 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9066 * dispextern.h (FACE_FROM_ID):
9067 * keyboard.c (read_char): Use UNSIGNED_CMP.
9068
41cb286c
PE
9069 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9070 not to EMACS_INT, to avoid GCC warning.
9071
4a1b9832
PE
9072 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9073
55daad71
PE
9074 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9075 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9076 isn't needed on 32-bit machines.
8f95c75c 9077
01103c44
PE
9078 * buffer.c (Fgenerate_new_buffer_name):
9079 Use EMACS_INT for count, not int.
0ceccced 9080 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9081
9082 * data.c (Qcompiled_function): Now static.
9083
c6f072e7
PE
9084 * window.c (window_body_lines): Now static.
9085
20ce5912
PE
9086 * image.c (gif_load): Rename local to avoid shadowing.
9087
9c4c5f81
PE
9088 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9089 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9090 * alloc.c (make_save_value): Integer argument is now of type
9091 ptrdiff_t, not int.
9092 (mark_object): Use ptrdiff_t, not int.
9093 * lisp.h (pD): New macro.
9094 * print.c (print_object): Use it.
9095
c0c5c8ae
PE
9096 * alloc.c: Use EMACS_INT, not int, to count objects.
9097 (total_conses, total_markers, total_symbols, total_vector_size)
9098 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9099 (total_free_floats, total_floats, total_free_intervals)
9100 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9101 Now EMACS_INT, not int. All uses changed.
9102 (Fgarbage_collect): Compute overall total using a double, so that
9103 integer overflow is less likely to be a problem. Check for overflow
9104 when converting back to an integer.
5a25e253
PE
9105 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9106 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9107 These were 'int' variables that could overflow on 64-bit hosts;
9108 they were never used, so remove them instead of repairing them.
211a0b2a 9109 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9110 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9111 Previously, this ceilinged at INT_MAX, but that doesn't work on
9112 64-bit machines.
e46bb31a 9113 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9114
c78baabf 9115 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9116 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9117 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9118 when a (possibly-narrower) signed value would do just as well.
9119 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9120
c9d624c6
PE
9121 * alloc.c: Catch some string size overflows that we were missing.
9122 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9123 for convenience in STRING_BYTES_MAX.
9124 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9125 The definition here is exact; the one in lisp.h was approximate.
9126 (allocate_string_data): Check for string overflow. This catches
9127 some instances we weren't catching before. Also, it catches
9128 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9129 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9130 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9131
c9d624c6
PE
9132 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9133 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9134 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9135
353032ce
PE
9136 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9137
2bccce07
PE
9138 * alloc.c (Fmake_string): Check for out-of-range init.
9139
0ac30604
SM
91402011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9141
9142 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9143
c195f2de
JD
91442011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9145
9146 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9147 xg_get_default_scrollbar_width.
9148
9149 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9150 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9151 (style_changed_cb): Call update_theme_scrollbar_width and call
9152 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9153 all frames (Bug#8505).
9154 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9155 Call gtk_window_set_resizable if HAVE_GTK3.
9156 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9157 and height if HAVE_GTK3 (Bug#8505).
9158 (scroll_bar_width_for_theme): New variable.
9159 (update_theme_scrollbar_width): New function.
9160 (xg_get_default_scrollbar_width): Move code to
9161 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9162 (xg_initialize): Call update_theme_scrollbar_width.
9163
9164 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9165
9166 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9167
e10ac9f1
MR
91682011-06-12 Martin Rudalics <rudalics@gmx.at>
9169
9170 * frame.c (make_frame): Call other_buffer_safely instead of
9171 other_buffer.
9172
9173 * window.c (temp_output_buffer_show): Call display_buffer with
9174 second argument Vtemp_buffer_show_specifiers and reset latter
9175 immediately after the call.
9176 (Vtemp_buffer_show_specifiers): New variable.
9177 (auto_window_vscroll_p, next_screen_context_lines)
9178 (Vscroll_preserve_screen_position): Remove leading asterisks from
9179 doc-strings.
9180
2d3c217e 91812011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 9182
7b7f97e8 9183 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
9184 * buffer.c (Qclone_number): Remove for now, as it's unused.
9185 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9186 (record_buffer): Remove unused local.
9187 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9188 (set_frame_buffer_list): Remove; unused.
9189 * frame.h (other_visible_frames): Remove decl.
9190 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9191 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9192 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9193 if HAVE_GPM.
9194 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9195 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9196 Define only if HAVE_GPM.
9197 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9198 (update_hints_inhibit): Remove; never set. All uses removed.
9199 * widgetprv.h (emacsFrameClassRec): Remove decl.
9200 * window.c (delete_deletable_window): Now returns void, since it
9201 wasn't returning anything.
9202 (compare_window_configurations): Remove unused locals.
9203 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9204 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
9205 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9206 the same widths as pointers. This follows up on the 2011-05-06 patch.
9207 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9208 * xterm.h: Likewise.
9209 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9210
1384b89e
JB
92112011-06-12 Juanma Barranquero <lekktu@gmail.com>
9212
9213 * makefile.w32-in: Update dependencies.
9214 (LISP_H): Add lib/intprops.h.
9215
1100a63c
CY
92162011-06-11 Chong Yidong <cyd@stupidchicken.com>
9217
9218 * image.c (gif_load): Add animation frame delay to the metadata.
9219 (syms_of_image): Use DEFSYM. New symbol `delay'.
9220
6198ccd0
MR
92212011-06-11 Martin Rudalics <rudalics@gmx.at>
9222
9223 * window.c (delete_deletable_window): Re-add.
9224 (Fset_window_configuration): Rewrite to handle dead buffers and
9225 consequently deletable windows.
9226 (window_tree, Fwindow_tree): Remove. Supply functionality in
9227 window.el.
9228 (compare_window_configurations): Simplify code.
9229
b6e3633c
AS
92302011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9231
1ab0dee5
AS
9232 * image.c (imagemagick_load_image): Fix type mismatch.
9233 (Fimagemagick_types): Likewise.
9234
b6e3633c
AS
9235 * window.h (replace_buffer_in_windows): Declare.
9236
9397e56f
MR
92372011-06-11 Martin Rudalics <rudalics@gmx.at>
9238
9239 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9240 Qclone_number. Remove external declaration of Qdelete_window.
9241 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9242 code.
640c8776
SM
9243 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9244 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
9245 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9246 buffer list implementation.
9247 (other_buffer_safely): New function.
9248 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9249 calls to replace_buffer_in_windows and
9250 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9251 if allowed.
9252 (record_buffer): Inhibit quitting and rewrite using quittable
9253 functions. Run Qbuffer_list_update_hook if allowed.
9254 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9255 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9256 Move switch-to-buffer to window.el.
9397e56f
MR
9257 (bury-buffer): Move to window.el.
9258 (Vbuffer_list_update_hook): New variable.
9259
9260 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9261 section.
9262
9263 * window.h (resize_frame_windows): Move up in code.
9264 (Fwindow_frame): Remove EXFUN.
9265 (replace_buffer_in_all_windows): Remove prototype.
9266 (replace_buffer_in_windows_safely): Add prototype.
9267
9268 * window.c: Declare Qdelete_window static again. Move down
9269 declaration of select_count.
9270 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9271 (Fother_window): Move to window.el.
9272 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9273 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9274 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9275 window.el.
9276 (replace_buffer_in_windows): Implement by calling
9277 Qreplace_buffer_in_windows.
9278 (replace_buffer_in_all_windows): Remove with some functionality
9279 moved into replace_buffer_in_windows_safely.
9280 (replace_buffer_in_windows_safely): New function.
9281 (select_window_norecord, select_frame_norecord): Move in front
9282 of run_window_configuration_change_hook. Remove now obsolete
9283 declarations.
640c8776
SM
9284 (Fset_window_buffer): Rewrite doc-string.
9285 Call Qrecord_window_buffer.
9397e56f
MR
9286 (keys_of_window): Move binding for other-window to window.el.
9287
b50691aa
CY
92882011-06-11 Chong Yidong <cyd@stupidchicken.com>
9289
9290 * dispextern.h (struct image): Replace data member, whose int_val
9291 and ptr_val fields were not used by anything, with a single
9292 lisp_val object.
9293
9294 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9295 (gif_clear_image, gif_load, imagemagick_load_image)
9296 (gs_clear_image, gs_load): Callers changed.
9297
3f754b86
PE
92982011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9299
cca69397
PE
9300 * buffer.h: Include <time.h>, for time_t.
9301 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9302
109e28d0
PE
9303 Fix minor problems found by static checking.
9304
60737f02
PE
9305 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9306
4b66faf3
PE
9307 Make identifiers static if they are not used in other modules.
9308 * data.c (Qcompiled_function, Qframe, Qvector):
9309 * image.c (QimageMagick, Qsvg):
9310 * minibuf.c (Qmetadata):
9311 * window.c (resize_window_check, resize_root_window): Now static.
9312 * window.h (resize_window_check, resize_root_window): Remove decls.
9313
109e28d0
PE
9314 * window.c (window_deletion_count, delete_deletable_window):
9315 Remove; unused.
46a4ce9e
PE
9316 (window_body_lines): Now static.
9317 (Fdelete_other_windows_internal): Mark vars as initialized.
9318 Make sure 'resize_failed' is initialized.
9319 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9320 (resize_window_apply): Remove unused local.
9321 * window.h (delete_deletable_window): Remove decl.
9322
109e28d0 9323 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9324 (imagemagick_load_image): Fix pointer signedness problem by changing
9325 last arg from unsigned char * to char *. All uses changed.
9326 Also, fix a local for similar reasons.
9327 Remove unused locals. Remove locals to avoid shadowing.
9328 (fn_rsvg_handle_free): Remove; unused.
9329 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9330 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9331
3f754b86
PE
9332 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9333
2547adb1
CY
93342011-06-10 Chong Yidong <cyd@stupidchicken.com>
9335
9336 * image.c (gif_load): Fix omitted cast error introduced by
9337 2011-06-06 change.
9338
2c8e37d4
MR
93392011-06-10 Martin Rudalics <rudalics@gmx.at>
9340
9341 * window.h (resize_proportionally, orig_total_lines)
9342 (orig_top_line): Remove from window structure.
9343 (set_window_height, set_window_width, change_window_heights)
9344 (Fdelete_window): Remove prototypes.
9345 (resize_frame_windows): Remove duplicate declaration.
9346
440a42e3
EZ
93472011-06-10 Eli Zaretskii <eliz@gnu.org>
9348
9349 * window.h (resize_frame_windows, resize_window_check)
9350 (delete_deletable_window, resize_root_window)
9351 (resize_frame_windows): Declare prototypes.
9352
9353 * window.c (resize_window_apply): Make definition be "static" to
9354 match the prototype.
9355
562dd5e9
MR
93562011-06-10 Martin Rudalics <rudalics@gmx.at>
9357
9358 * window.c: Remove declarations of Qwindow_size_fixed,
9359 window_min_size_1, window_min_size_2, window_min_size,
9360 size_window, window_fixed_size_p, enlarge_window, delete_window.
9361 Remove static from declaration of Qdelete_window, it's
9362 temporarily needed by Fbury_buffer.
9363 (replace_window): Don't assign orig_top_line and
9364 orig_total_lines.
9365 (Fdelete_window, delete_window): Remove. Window deletion is
9366 handled by window.el.
640c8776
SM
9367 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9368 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9369 (Fdelete_other_windows): Remove. Deleting other windows is
9370 handled by window.el.
9371 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9372 handled in window.el.
9373 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9374 Window minimum sizes are handled in window.el.
9375 (shrink_windows, size_window, set_window_height)
9376 (set_window_width, change_window_heights, window_height)
9377 (window_width, CURBEG, CURSIZE, enlarge_window)
9378 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9379 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9380 handled in window.el.
9381 (make_dummy_parent): Rename to make_parent_window and give it a
9382 second argument horflag.
9383 (make_window): Don't set resize_proportionally any more.
9384 (Fsplit_window): Remove. Windows are split in window.el.
9385 (save_restore_action, save_restore_orig_size)
9386 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9387 Resize mini windows in window.el.
9388 (grow_mini_window, shrink_mini_window): Implement by calling
9389 Qresize_root_window_vertically, resize_window_check and
9390 resize_window_apply.
640c8776
SM
9391 (saved_window, Fset_window_configuration, save_window_save):
9392 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9393 resize_proportionally.
9394 (window_min_height, window_min_width): Move to window.el.
9395 (keys_of_window): Move bindings for delete-other-windows,
9396 split-window, delete-window and enlarge-window to window.el.
9397
9398 * buffer.c: Temporarily extern Qdelete_window.
9399 (Fbury_buffer): Temporarily call Qdelete_window instead of
9400 Fdelete_window (Fbury_buffer will move to window.el soon).
9401
9402 * frame.c (set_menu_bar_lines_1): Remove code handling
9403 orig_top_line and orig_total_lines.
9404
9405 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9406 set_window_height but set heights directly.
9407 (change_frame_size_1): Use resize_frame_windows.
9408
9409 * xdisp.c (init_xdisp): Don't use set_window_height but set
9410 heights directly.
9411
640c8776
SM
9412 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9413 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9414 run_window_configuration_change_hook.
9415
9416 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9417 instead of change_window_heights and run
9418 run_window_configuration_change_hook.
9419
1a13852e
MR
94202011-06-09 Martin Rudalics <rudalics@gmx.at>
9421
9422 * window.c (replace_window): Rename second argument REPLACEMENT to
9423 NEW. New third argument SETFLAG. Rewrite.
9424 (delete_window, make_dummy_parent): Call replace_window with
9425 third argument 1.
9426 (window_list_1): Move down in code.
9427 (run_window_configuration_change_hook): Move set_buffer part
9428 before select_frame_norecord part in order to unwind correctly.
9429 Rename count1 to count.
9430 (recombine_windows, delete_deletable_window, resize_root_window)
9431 (Fdelete_other_windows_internal)
9432 (Frun_window_configuration_change_hook, make_parent_window)
9433 (resize_window_check, resize_window_apply, Fresize_window_apply)
9434 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9435 (Fdelete_window_internal, Fresize_mini_window_internal):
9436 New functions.
1a13852e
MR
9437 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9438
f3d1777e
MR
94392011-06-08 Martin Rudalics <rudalics@gmx.at>
9440
496e208e
MR
9441 * window.h (window): Add some new members to window structure -
9442 normal_lines, normal_cols, new_total, new_normal, clone_number,
9443 splits, nest, prev_buffers, next_buffers.
9444 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9445 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9446
f3d1777e
MR
9447 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9448 Remove.
496e208e
MR
9449 (make_dummy_parent): Set new members of windows structure.
9450 (make_window): Move down in code. Handle new members of window
9451 structure.
9452 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9453 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9454 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9455 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9456 (Fset_window_next_buffers, Fset_window_clone_number):
9457 New functions.
496e208e
MR
9458 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9459 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9460 Doc-string fixes.
9461 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9462 Argument WINDOW can be now internal window too.
9463 (Fwindow_use_time): Move up in code.
9464 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9465 Rewrite doc-string.
9466 (Fset_window_configuration, saved_window)
9467 (Fcurrent_window_configuration, save_window_save): Handle new
9468 members of window structure.
b9e809c2
MR
9469 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9470 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9471 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9472 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9473 Qget_mru_window, Qresize_root_window,
9474 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9475 Qauto_buffer_name; staticpro them.
f3d1777e 9476
abde8f8c
MR
94772011-06-07 Martin Rudalics <rudalics@gmx.at>
9478
9479 * window.c (Fwindow_total_size, Fwindow_left_column)
9480 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9481 (Fwindow_list_1): New functions.
9482 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9483 (Fwindow_width, Fscroll_left, Fscroll_right):
9484 Use window_body_cols instead of window_box_text_cols.
9485 (delete_window, Fset_window_configuration):
9486 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9487 (delete_all_subwindows): Take a window as argument and not a
9488 structure. Rewrite.
190b47e6
MR
9489 (window_loop): Remove handling of GET_LRU_WINDOW and
9490 GET_LARGEST_WINDOW.
9491 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9492
9493 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9494 window_box_text_cols. delete_all_subwindows now takes a
9495 Lisp_Object as argument.
abde8f8c 9496
640c8776
SM
9497 * indent.c (compute_motion, Fcompute_motion):
9498 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9499
fa8a67e6
MR
9500 * frame.c (delete_frame): Call delete_all_subwindows with root
9501 window as argument.
9502
a54e3482
DC
95032011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9504
9505 * fns.c (Fputhash): Document return value.
9506
60002bf5
CY
95072011-06-06 Chong Yidong <cyd@stupidchicken.com>
9508
9509 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9510
0c671da6 95112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9512
b862a52a 9513 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9514
be44ca6c
PE
9515 Check for overflow when converting integer to cons and back.
9516 * charset.c (Fdefine_charset_internal, Fdecode_char):
9517 Use cons_to_unsigned to catch overflow.
9518 (Fencode_char): Use INTEGER_TO_CONS.
9519 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9520 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9521 * data.c (long_to_cons, cons_to_long): Remove.
9522 (cons_to_unsigned, cons_to_signed): New functions.
9523 These signal an error for invalid or out-of-range values.
9524 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9525 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9526 * font.c (Ffont_variation_glyphs):
9527 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9528 * lisp.h: Include <intprops.h>.
9529 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9530 (cons_to_signed, cons_to_unsigned): New decls.
9531 (long_to_cons, cons_to_long): Remove decls.
9532 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9533 (Fprimitive_undo): Use CONS_TO_INTEGER.
9534 * xfns.c (Fx_window_property): Likewise.
9535 * xselect.c: Include <limits.h>.
9536 (x_own_selection, selection_data_to_lisp_data):
9537 Use INTEGER_TO_CONS.
9538 (x_handle_selection_request, x_handle_selection_clear)
9539 (x_get_foreign_selection, Fx_disown_selection_internal)
9540 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9541 (lisp_data_to_selection_data): Use cons_to_unsigned.
9542 (x_fill_property_data): Use cons_to_signed.
9543 Report values out of range.
9544
d1f3d2af
PE
9545 Check for buffer and string overflow more precisely.
9546 * buffer.h (BUF_BYTES_MAX): New macro.
9547 * lisp.h (STRING_BYTES_MAX): New macro.
9548 * alloc.c (Fmake_string):
9549 * character.c (string_escape_byte8):
9550 * coding.c (coding_alloc_by_realloc):
9551 * doprnt.c (doprnt):
9552 * editfns.c (Fformat):
9553 * eval.c (verror):
9554 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9555 since they may not be the same number.
9556 * editfns.c (Finsert_char):
9557 * fileio.c (Finsert_file_contents):
9558 Likewise for BUF_BYTES_MAX.
9559
dd52fcea
PE
9560 * image.c: Use ptrdiff_t, not int, for sizes.
9561 (slurp_file): Switch from int to ptrdiff_t.
9562 All uses changed.
9563 (slurp_file): Check that file size fits in both size_t (for
9564 malloc) and ptrdiff_t (for sanity and safety).
9565
7f9bbdbb
PE
9566 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9567 if b->modtime has its maximal value.
9568
dfe18f82
PE
9569 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9570
84acfcf0
PE
9571 Don't assume time_t can fit into int.
9572 * buffer.h (struct buffer.modtime): Now time_t, not int.
9573 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9574 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9575
ccd9a01a
PE
9576 Minor fixes for signed vs unsigned integers.
9577 * character.h (MAYBE_UNIFY_CHAR):
9578 * charset.c (maybe_unify_char):
9579 * keyboard.c (read_char, reorder_modifiers):
9580 XINT -> XFASTINT, since the integer must be nonnegative.
9581 * ftfont.c (ftfont_spec_pattern):
9582 * keymap.c (access_keymap, silly_event_symbol_error):
9583 XUINT -> XFASTINT, since the integer must be nonnegative.
9584 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9585 since it makes no difference and we prefer signed.
9586 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9587 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9588 nonnegative.
9589
d6d100dd
SM
95902011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9591
9592 * window.h (Fwindow_frame): Declare.
9593
2b6148e4
PE
95942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9595
9596 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9597 (SPARE_MEMORY): Always define.
9598 (LARGE_REQUEST): Remove.
9599 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9600
f230ecc9
MR
96012011-06-06 Martin Rudalics <rudalics@gmx.at>
9602
727e958e
MR
9603 * lisp.h: Move EXFUNS for Fframe_root_window,
9604 Fframe_first_window and Fset_frame_selected_window to window.h.
9605
9606 * window.h: Move EXFUNS for Fframe_root_window,
9607 Fframe_first_window and Fset_frame_selected_window here from
9608 lisp.h.
9609
9610 * frame.c (Fwindow_frame, Fframe_first_window)
9611 (Fframe_root_window, Fframe_selected_window)
9612 (Fset_frame_selected_window): Move to window.c.
9613 (Factive_minibuffer_window): Move to minibuf.c.
9614 (Fother_visible_frames_p): New function.
9615
9616 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9617
f230ecc9
MR
9618 * window.c (decode_window, decode_any_window): Move up in code.
9619 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9620 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9621 (Fwindow_buffer): Move up and rewrite doc-string.
9622 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9623 (Fwindow_prev): New functions.
727e958e
MR
9624 (Fwindow_frame): Move here from frame.c. Accept any window as
9625 argument.
9626 (Fframe_root_window, Fframe_first_window)
9627 (Fframe_selected_window): Move here from frame.c. Accept frame
9628 or arbitrary window as argument. Update doc-strings.
9629 (Fminibuffer_window): Move up in code.
9630 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9631 (Fset_frame_selected_window): Move here from frame.c.
9632 Marginal rewrite.
727e958e
MR
9633 (Fselected_window, select_window, Fselect_window): Move up in
9634 code. Minor doc-string fixes.
f230ecc9 9635
4d09bcf6
PE
96362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9637
9638 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9639 Do not assume that spare memory exists; that assumption is valid
9640 only if SYSTEM_MALLOC.
9641 (LARGE_REQUEST): New macro, so that the issue of large requests
9642 is separated from the issue of spare memory.
9643
810928a2
AS
96442011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9645
172418ad
AS
9646 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9647 format. (Bug#8806)
9648
43f862f7
AS
9649 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9650
810928a2
AS
9651 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9652 before statements.
9653
a059fe24
JD
96542011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9655
9656 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9657
9658 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9659
9660 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9661 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9662
989bf368
JB
96632011-06-05 Juanma Barranquero <lekktu@gmail.com>
9664
9665 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9666
4b80f674
CY
96672011-06-04 Chong Yidong <cyd@stupidchicken.com>
9668
9669 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9670 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9671 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9672 New error handlers.
4b80f674
CY
9673 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9674 Obey Vx_select_enable_clipboard_manager. Catch errors in
9675 x_clipboard_manager_save (Bug#8779).
9676 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9677 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9678
99a33b77 96792011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9680
9681 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9682
99a33b77 96832011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9684
9685 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9686 in the current matrix if keep_current_p is non-zero.
9687
8264569d
EZ
96882011-06-04 Eli Zaretskii <eliz@gnu.org>
9689
9690 * bidi.c (bidi_level_of_next_char): Fix last change.
9691
57f97249
EZ
96922011-06-03 Eli Zaretskii <eliz@gnu.org>
9693
fec2107c 9694 Support bidi reordering of text covered by display properties.
57f97249 9695
fec2107c
EZ
9696 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9697 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9698 (bidi_cache_search, bidi_cache_iterator_state)
9699 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9700 (bidi_level_of_next_char, bidi_move_to_visually_next):
9701 Support character positions inside a run of characters covered by a
fec2107c
EZ
9702 display string.
9703 (bidi_paragraph_init, bidi_resolve_explicit_1)
9704 (bidi_level_of_next_char): Call bidi_fetch_char and
9705 bidi_fetch_char_advance instead of FETCH_CHAR and
9706 FETCH_CHAR_ADVANCE.
9707 (bidi_init_it): Initialize new members.
9708 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9709 definitions.
9710 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9711 instead of using explicit *_CHAR codes.
d6d100dd
SM
9712 (bidi_resolve_explicit, bidi_resolve_weak):
9713 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9714 bidirectional text is supported only in multibyte buffers.
9715 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9716 it to initialize the frame_window_p member of struct bidi_it.
9717 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9718 (bidi_resolve_explicit, bidi_resolve_weak)
9719 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9720 bidi_it->nchars is non-positive.
9721 (bidi_level_of_next_char): Don't try to lookup the cache for the
9722 next/previous character if nothing is cached there yet, or if we
9723 were just reseat()'ed to a new position.
c40e2fb2 9724
0e14fe90
EZ
9725 * xdisp.c (set_cursor_from_row): Set start and stop points
9726 according to the row's direction when priming the loop that looks
9727 for the glyph on which to display cursor.
9728 (single_display_spec_intangible_p): Function deleted.
9729 (display_prop_intangible_p): Reimplement to call
9730 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9731 Accept 3 additional arguments needed by handle_display_spec.
9732 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9733 values: lists, `(when COND...)' forms, etc.
9734 (single_display_spec_string_p): Support property values that are
9735 lists with the argument STRING its top-level element.
9736 (display_prop_string_p): Fix the condition for processing a
9737 property that is a list to be consistent with handle_display_spec.
fec2107c 9738 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9739 last portion of handle_display_prop.
9740 (compute_display_string_pos): Accept additional argument
9741 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9742 value of a `display' property is a "replacing spec".
9743 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9744 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9745 the display property, but just return a value indicating whether
9746 the display property will replace the characters it covers.
9747 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9748 frame_window_p members of struct bidi_it.
d6d100dd
SM
9749 (compute_display_string_pos, compute_display_string_end):
9750 New functions.
fec2107c
EZ
9751 (push_it): Accept second argument POSITION, where pop_it should
9752 jump to continue iteration.
9753 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9754
fec2107c
EZ
9755 * keyboard.c (adjust_point_for_property): Adjust the call to
9756 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9757
9758 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9759 (bidi_init_it): Update prototypes.
9760 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9761 (compute_display_string_pos, compute_display_string_end):
9762 Declare prototypes.
fec2107c
EZ
9763 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9764 EMACS_INT.
fc6f18ce 9765
40087514 97662011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9767
57f53182
PE
9768 Malloc failure behavior now depends on size of allocation.
9769 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9770 * lisp.h: Change signatures accordingly.
9771 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9772 All callers changed. (Bug#8762)
9773
9774 * gnutls.c: Use Emacs's memory allocators.
9775 Without this change, the gnutls library would invoke malloc etc.
9776 directly, which causes problems on non-SYNC_INPUT hosts, and which
9777 runs afoul of improving memory_full behavior. (Bug#8761)
9778 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9779 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9780 xfree instead of the default malloc, realloc, free.
9781 (Fgnutls_boot): No need to check for memory allocation failure,
9782 since xmalloc does that for us.
9783
ac32cd99 9784 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9785 * category.c (hash_get_category_set):
9786 * ccl.c (ccl_driver):
9787 * charset.c (Fdefine_charset_internal):
9788 * charset.h (struct charset.hash_index):
9789 * composite.c (get_composition_id, gstring_lookup_cache)
9790 (composition_gstring_put_cache):
9791 * composite.h (struct composition.hash_index):
9792 * dispextern.h (struct image.hash):
9793 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9794 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9795 (hashfn_equal, hashfn_user_defined, make_hash_table)
9796 (maybe_resize_hash_table, hash_lookup, hash_put)
9797 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9798 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9799 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9800 * image.c (make_image, search_image_cache, lookup_image)
9801 (xpm_put_color_table_h):
9802 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9803 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9804 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9805 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9806 * alloc.c (allocate_vectorlike):
9807 Check for overflow in vector size calculations.
9808 * ccl.c (ccl_driver):
9809 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9810 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9811 need to be updated by these changes.
40087514
PE
9812 * fns.c (make_hash_table, maybe_resize_hash_table):
9813 Check for integer overflow with large hash tables.
0de4bb68
PE
9814 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9815 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9816 (SXHASH_REDUCE): New macro.
9817 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9818 Use it instead of discarding useful hash info with large hash values.
9819 (sxhash_float): New function.
9820 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9821 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9822 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9823 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9824 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9825 Adjust signatures to match updated version of code.
9826 (consing_since_gc): Now EMACS_INT, since a single hash table can
9827 use more than INT_MAX bytes.
9828
698d32e2
DN
98292011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9830
9831 Make it possible to build with GCC-4.6+ -O2 -flto.
9832
9833 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9834
fd6fa53f
SM
98352011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9836
9837 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9838 Call minibuffer-inactive-mode.
9839
864db017
JB
98402011-05-31 Juanma Barranquero <lekktu@gmail.com>
9841
9842 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9843 Update dependencies.
9844
2ad0baf4
DN
98452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9846
9847 * data.c (init_data): Remove code for UTS, this system is not
9848 supported anymore.
9849
4fcc2638
DN
98502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9851
9852 Don't force ./temacs to start in terminal mode.
9853
9854 * frame.c (make_initial_frame): Initialize faces in all cases, not
9855 only when CANNOT_DUMP is defined.
9856 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9857
c56e0fd5
DN
98582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9859
9860 * dispnew.c (add_window_display_history): Use const for the string
9861 pointer. Remove declaration, not needed.
9862
333d54da 98632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9864
55d4c1b2 9865 Use 'inline', not 'INLINE'.
333d54da 9866 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9867 * alloc.c, fontset.c (INLINE): Remove.
9868 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9869 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9870 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9871 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9872 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9873
738db178
DN
98742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9875
9876 Make it possible to run ./temacs.
9877
9878 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9879 syms_of_callproc does the same thing. Remove test for
9880 "initialized", do it in the caller.
9881 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9882
620c53a6
SM
98832011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9884
9885 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9886 (read_minibuf): Use get_minibuffer.
9887 (syms_of_minibuf): Use DEFSYM.
9888 (Qmetadata): New var.
9889 * data.c (Qbuffer): Don't make it static.
9890 (syms_of_data): Use DEFSYM.
9891
e003a292
PE
98922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9893
9894 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9895 (CCL_CODE_MIN): New macro.
9896
ed008a6d
PE
98972011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9898
3687c2ef
PE
9899 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9900
ed008a6d
PE
9901 * eval.c (Qdebug): Now static.
9902 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9903 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9904 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9905
d66c4c7c
CY
99062011-05-29 Chong Yidong <cyd@stupidchicken.com>
9907
9908 * image.c: Various fixes to ImageMagick code comments.
9909 (Fimagemagick_types): Doc fix.
9910
5fbc2025
PE
99112011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9912
0196f88a
PE
9913 Minor fixes prompted by GCC 4.6.0 warnings.
9914
9915 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9916
5fbc2025
PE
9917 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9918 (x_clipboard_manager_save_all): Move extern decl to ...
9919 * xterm.h: ... here, so that it can be checked for consistency.
9920
1dd3c2d9
CY
99212011-05-29 Chong Yidong <cyd@stupidchicken.com>
9922
9923 * xselect.c (x_clipboard_manager_save_frame)
9924 (x_clipboard_manager_save_all): New functions.
9925 (Fx_clipboard_manager_save): Lisp function deleted.
9926
9927 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9928 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9929
9930 * xterm.h: Update prototype.
9931
5ba6571d
WX
99322011-05-28 William Xu <william.xwl@gmail.com>
9933
9934 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9935 exiting (Bug#8239).
9936
3eaff834
JM
99372011-05-28 Jim Meyering <meyering@redhat.com>
9938
e1900994 9939 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9940 * fns.c (to_uchar): Define.
9941 (crypto_hash_function): Use it to convert some newly-signed
9942 variables to unsigned, to avoid sign-extension bugs. For example,
9943 without this change, (md5 "truc") would evaluate to
9944 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9945 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9946 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9947
0f6990a7
PE
99482011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9949
9950 Integer overflow fixes.
c8a9ca5a 9951
08686060
PE
9952 * dbusbind.c: Serial number integer overflow fixes.
9953 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9954 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9955 to hold a serial number that is too large for a fixnum.
9956 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9957 Check for serial numbers out of range. Decode any serial number
59568bf0 9958 that was so large that it became a float. (Bug#8722)
08686060 9959
2d1fc3c7
PE
9960 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9961 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9962 Use XFASTINT rather than XUINT when numbers are nonnegative.
9963 (xd_append_arg, Fdbus_method_return_internal):
9964 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9965 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9966 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9967 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9968 (Bug#8722)
2d1fc3c7 9969
c8a9ca5a
PE
9970 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9971
519e1d69
PE
9972 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9973
6df6ae42 9974 ccl: Add integer overflow checks.
30569699
PE
9975 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9976 (IN_INT_RANGE): New macros.
9977 (ccl_driver): Use them to check for integer overflow when
9978 decoding a CCL program. Many of the new checks are whether XINT (x)
9979 fits in int; it doesn't always, on 64-bit hosts. The new version
9980 doesn't catch all possible integer overflows, but it's an
847044ea 9981 improvement. (Bug#8719)
30569699 9982
c11285dc
PE
9983 * alloc.c (make_event_array): Use XINT, not XUINT.
9984 There's no need for unsigned here.
9985
fdccd48e
PE
9986 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9987 This follows up to the 2011-05-06 change that substituted uintptr_t
9988 for EMACS_INT. This case wasn't caught back then.
9989
37910ab2
PE
9990 Rework Fformat to avoid integer overflow issues.
9991 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9992 now (part of C89). Include <verify.h>.
9993 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9994 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9995 (Fformat): Avoid the prepass trying to compute sizes; it was only
9996 approximate and thus did not catch overflow reliably. Instead, walk
9997 through the format just once, formatting and computing sizes as we go,
9998 checking for integer overflow at every step, and allocating a larger
9999 buffer as needed. Keep track separately whether the format is
10000 multibyte. Keep only the most-recently calculated precision, rather
10001 than them all. Record whether each argument has been converted to
10002 string. Use EMACS_INT, not int, for byte and char and arg counts.
10003 Support field widths and precisions larger than INT_MAX. Avoid
10004 sprintf's undefined behavior with conversion specifications such as %#d
10005 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10006 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10007 formatting out-of-range floating point numbers with int
9173deec 10008 formats. (Bug#8668)
37910ab2 10009
2e6578fb
PE
10010 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10011
0ae6bdee
PE
10012 * data.c: Avoid integer truncation in expressions involving floats.
10013 * data.c: Include <intprops.h>.
10014 (arith_driver): When there's an integer overflow in an expression
10015 involving floating point, convert the integers to floating point
10016 so that the resulting value does not suffer from catastrophic
10017 integer truncation. For example, on a 64-bit host (* 4
10018 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10019 Do not rely on undefined behavior after integer overflow.
10020
de883a70
PE
10021 merge count_size_as_multibyte, parse_str_to_multibyte
10022 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10023 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10024 Check for integer overflow.
10025 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10026 since it's now a duplicate of the other. This is more of
10027 a character than a buffer op, so better that it's in character.c.
10028 * fns.c, print.c: Adjust to above changes.
10029
2ff916cb
PE
100302011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10031
10032 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10033
f1b54466
PE
100342011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10035
fb1ac845
PE
10036 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10037 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10038 (x_clipboard_manager_save): Now static.
10039 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10040
f1b54466
PE
10041 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10042 (crypto_hash_function): Now static.
10043 Fix pointer signedness problems. Avoid unnecessary initializations.
10044
a9f737ee
CY
100452011-05-27 Chong Yidong <cyd@stupidchicken.com>
10046
10047 * termhooks.h (Vselection_alist): Make it terminal-local.
10048
10049 * terminal.c (create_terminal): Initialize it.
10050
10051 * xselect.c: Support for clipboard managers.
10052 (Vselection_alist): Move to termhooks.h as terminal-local var.
10053 (LOCAL_SELECTION): New macro.
10054 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10055 (symbol_to_x_atom): Remove gratuitous arg.
10056 (x_handle_selection_request, lisp_data_to_selection_data)
10057 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10058 (x_own_selection, x_get_local_selection, x_convert_selection):
10059 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10060 (some_frame_on_display): Delete unused function.
10061 (Fx_own_selection_internal, Fx_get_selection_internal)
10062 (Fx_disown_selection_internal, Fx_selection_owner_p)
10063 (Fx_selection_exists_p): New optional frame arg.
10064 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10065 (x_handle_selection_clear): Don't treat other terminals with the
10066 same keyboard specially. Use the terminal-local Vselection_alist.
10067 (x_clear_frame_selections): Use Frun_hook_with_args.
10068
10069 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10070
10071 * xterm.h: Add support for those atoms.
10072
e067f0c1
CY
100732011-05-26 Chong Yidong <cyd@stupidchicken.com>
10074
10075 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10076 (converted_selections, conversion_fail_tag): New global variables.
10077 (x_selection_request_lisp_error): Free the above.
10078 (x_get_local_selection): Remove unnecessary code.
10079 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10080 of converted selections stored in converted_selections.
10081 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10082 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10083 (x_convert_selection): New function.
10084 (x_handle_selection_event): Simplify.
10085 (x_get_foreign_selection): Don't ignore incoming requests while
10086 waiting for an answer; this will fail when we implement
10087 SAVE_TARGETS, and seems unnecessary anyway.
10088 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10089 (Vx_sent_selection_functions): Doc fix.
10090
0f4aebc0
LL
100912011-05-26 Leo Liu <sdl.web@gmail.com>
10092
10093 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10094
e61124cd
YM
100952011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10096
10097 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10098
10099 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10100 for fringe update if it has periodic bitmap.
ac389d0c 10101 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10102 and fringe_bitmap_periodic_p.
10103
10104 * fringe.c (get_fringe_bitmap_data): New function.
10105 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10106 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10107 row. Mark glyph row for fringe update if periodicity changed.
10108
10109 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10110 for fringe update unless it has periodic bitmap.
10111
f16d9837
KH
101122011-05-25 Kenichi Handa <handa@m17n.org>
10113
10114 * xdisp.c (get_next_display_element): Set correct it->face_id for
10115 a static composition.
10116
e1b90ef6
LL
101172011-05-24 Leo Liu <sdl.web@gmail.com>
10118
10119 * deps.mk (fns.o):
10120 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10121
10122 * fns.c (crypto_hash_function, Fsha1): New function.
10123 (Fmd5): Use crypto_hash_function.
10124 (syms_of_fns): Add Ssha1.
10125
7400048f
PE
101262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10127
10128 * gnutls.c: Remove unused macros.
10129 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10130 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10131 Remove macros that are defined and never used.
10132 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10133
abb71cf4
CY
101342011-05-22 Chong Yidong <cyd@stupidchicken.com>
10135
10136 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10137 (Fx_get_selection_internal): Minor cleanup.
10138 (Fx_own_selection_internal): Rename arguments for consistency with
10139 select.el.
10140
6307db39
PE
101412011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10142
10143 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10144
f3d4e0a4
CY
101452011-05-22 Chong Yidong <cyd@stupidchicken.com>
10146
10147 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10148
4d8ade89
YM
101492011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10150
10151 * dispnew.c (scrolling_window): Don't exclude the case that the
10152 last enabled row in the desired matrix touches the bottom boundary.
10153
32078c8d
GM
101542011-05-21 Glenn Morris <rgm@gnu.org>
10155
10156 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
10157 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10158 and add some more files.
32078c8d 10159
7285dc67
EZ
101602011-05-20 Eli Zaretskii <eliz@gnu.org>
10161
10162 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10163 report_file_error introduced by the change from 2011-05-07.
10164
89d1bd22
PE
101652011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10166
10167 * systime.h (Time): Define only if emacs is defined.
10168 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10169 where the include path doesn't have X11/X.h by default. See
10170 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10171
cd394be1 101722011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
10173
10174 * composite.c (find_automatic_composition): Fix previous change.
10175
b9704ad9
GM
101762011-05-20 Glenn Morris <rgm@gnu.org>
10177
10178 * lisp.mk: New file, split from Makefile.in.
10179 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10180 (shortlisp): Remove.
10181 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10182
4a720484
GM
101832011-05-19 Glenn Morris <rgm@gnu.org>
10184
10185 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10186 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10187 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10188 (lisp): Set the order to that of loadup.el.
10189 (shortlisp): Make it a copy of $lisp.
10190 (SOME_MACHINE_LISP): Remove.
10191 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10192 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10193
a28d4396
KH
101942011-05-18 Kenichi Handa <handa@m17n.org>
10195
10196 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10197 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10198 (find_automatic_composition): Mostly rewrite for efficiency.
10199
a2b1fa8e
JB
102002011-05-18 Juanma Barranquero <lekktu@gmail.com>
10201
10202 * makefile.w32-in: Update dependencies.
10203
8e1f5610
CS
102042011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10205
10206 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 10207 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 10208
7025ee00 102092011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 10210
cdfa6eab
PE
10211 Fix some integer overflow issues, such as string length overflow.
10212
06d6db33
PE
10213 * insdel.c (count_size_as_multibyte): Check for string overflow.
10214
2b4560a8
PE
10215 * character.c (lisp_string_width): Check for string overflow.
10216 Use EMACS_INT, not int, for string indexes and lengths; in
10217 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10218 the resulting string length overflows an EMACS_INT; instead,
10219 report a string overflow if no precision given. When checking for
10220 precision exhaustion, use a check that cannot possibly have
10221 integer overflow. (Bug#8675)
10222 * character.h (lisp_string_width): Adjust to new signature.
10223
cb93f9be
PE
10224 * alloc.c (string_overflow): New function.
10225 (Fmake_string): Use it. This doesn't change behavior, but saves
10226 a few bytes and will simplify future changes.
10227 * character.c (string_escape_byte8): Likewise.
10228 * lisp.h (string_overflow): New decl.
10229
1a1f3366
PE
10230 Fixups, following up to the user-interface timestamp change.
10231 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10232 for UI timestamps, instead of unsigned long.
9fbd6841
PE
10233 * msdos.c (mouse_get_pos): Likewise.
10234 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
10235 * w32gui.h (Time): Define by including "systime.h" rather than by
10236 declaring it ourselves. (Bug#8664)
10237
d4e3e4d3
PE
10238 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10239 * image.c (clear_image_cache): Likewise.
10240
f6a24d19
PE
10241 * term.c (term_mouse_position): Don't assume time_t wraparound.
10242
08dc5ae6
PE
10243 Be more systematic about user-interface timestamps.
10244 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
10245 and sometimes 'EMACS_UINT', to represent these timestamps.
10246 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
10247 This makes the code easier to follow, and makes it easier to catch
10248 integer overflow bugs such as Bug#8664.
10249 * frame.c (Fmouse_position, Fmouse_pixel_position):
10250 Use Time, not unsigned long, for user-interface timestamps.
10251 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10252 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10253 * keyboard.h (last_event_timestamp): Likewise.
10254 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10255 * menu.h (xmenu_show): Likewise.
10256 * term.c (term_mouse_position): Likewise.
10257 * termhooks.h (struct input_event.timestamp): Likewise.
10258 (struct terminal.mouse_position_hook): Likewise.
10259 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10260 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10261 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10262 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10263 what it was before.
10264 * menu.h, termhooks.h: Include "systime.h", for Time.
10265
8e55734a
PE
10266 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10267 Don't assume that the difference between two unsigned long values
10268 can fit into an integer. At this point, we know button_down_time
10269 <= event->timestamp, so the difference must be nonnegative, so
10270 there's no need to cast the result if double-click-time is
10271 nonnegative, as it should be; check that it's nonnegative, just in
10272 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10273 apart (about 25 days). (Bug#8664)
8e55734a 10274
841f1b75 10275 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10276 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10277
3e26f69c
PE
10278 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10279 that always fit in int. Use a sentinel instead of a counter, to
10280 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10281 * frame.h (struct frame): Use int for menu_bar_items_used
10282 instead of EMACS_INT, since it always fits in int.
3e26f69c 10283
5cc152c0
PE
10284 * menu.c (grow_menu_items): Check for int overflow.
10285
d89eb65e
PE
10286 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10287
5235bd3e
PE
10288 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10289 Before, the code was not consistent. These values cannot exceed
10290 2**31 - 1 so there's no need to make them unsigned.
10291 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10292 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10293 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10294 as modifiers.
10295 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10296
bc827e23
PE
10297 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10298 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10299 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10300 presumably because the widths might not match.
10301
78eb494e
PE
10302 * window.c (size_window): Avoid needless test at loop start.
10303
04f2d78b
CB
103042011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10305
10306 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10307
d2fc7e3d 103082011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10309
10310 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10311
d2fc7e3d 103122011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10313
10314 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10315 `width' to `bar_area_x' and `bar_area_width', respectively.
10316 (x_scroll_run): Take account of fringe background extension.
10317
04f2d78b
CB
10318 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10319 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10320 `bar_area_width', respectively.
10321 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10322 background extension.
10323
79b70037
GM
103242011-05-10 Jim Meyering <meyering@redhat.com>
10325
10326 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10327
2f142cc5
JB
103282011-05-10 Juanma Barranquero <lekktu@gmail.com>
10329
10330 * image.c (Finit_image_library): Return t for built-in image types,
10331 like pbm and xbm. (Bug#8640)
10332
57679c86
AS
103332011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10334
10335 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10336
888c9e86
EZ
103372011-05-07 Eli Zaretskii <eliz@gnu.org>
10338
b0512a1d
EZ
10339 * w32console.c (Fset_screen_color): Doc fix.
10340 (Fget_screen_color): New function.
10341 (syms_of_ntterm): Defsubr it.
10342
7285dc67
EZ
10343 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10344 unlink the temporary file if Fcall_process didn't create it in the
10345 first place.
10346 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10347 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10348 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10349 cue to call_process_cleanup not to close that handle.
10350
4d3fcc8e
BK
103512011-05-07 Ben Key <bkey76@gmail.com>
10352
10353 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10354 one of two shell specific rules, either bootstrap-temacs-CMD or
10355 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10356 to the previous implementation of the bootstrap-temacs rule.
10357 The bootstrap-temacs-CMD rule is similar to the previous
10358 implementation of the bootstrap-temacs rule except that it
10359 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10360 variable.
10361
10362 These changes, along with some changes to nt/configure.bat,
10363 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10364 earlier fix to add support for --cflags and --ldflags options
10365 that include quotes so that it works whether make uses cmd or
10366 sh as the shell.
10367
b4289b64
MA
103682011-05-06 Michael Albinus <michael.albinus@gmx.de>
10369
10370 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10371 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10372 is a constant.
10373 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10374 a string. Handle both cases.
10375 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10376 (Fdbus_register_method): Use Qinvalid_function.
10377
af4c0e28
JB
103782011-05-06 Juanma Barranquero <lekktu@gmail.com>
10379
10380 * makefile.w32-in: Update dependencies.
10381 (LISP_H): Add inttypes.h and stdin.h.
10382 (PROCESS_H): Add unistd.h.
10383
c51453d9
EZ
103842011-05-06 Eli Zaretskii <eliz@gnu.org>
10385
10386 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10387 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10388
8ff0ac3c 103892011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10390
4c4b566b
PE
10391 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10392
aab2b9b5
PE
10393 * term.c (vfatal): Remove stray call to va_end.
10394 It's not needed and the C Standard doesn't allow it here anyway.
10395
c378da0b
PE
10396 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10397 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10398
288b08c7
PE
10399 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10400 bytes.
10401
e3601888
PE
10402 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10403
db6c0e74
PE
10404 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10405
dd5963ea
PE
10406 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10407
88c9450f
PE
10408 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10409
2f9442b8
PE
10410 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10411
c032b5f8
PE
10412 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10413 * charset.c (Fdefine_charset_internal): Don't initialize
10414 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10415 32-bit int (Bug#8600).
a108c10b
PE
10416
10417 * lread.c (read_integer): Be more consistent with string-to-number.
10418 Use string_to_number to do the actual conversion; this avoids
10419 rounding errors and fixes some other screwups. Without this fix,
10420 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10421 (digit_to_number): Move earlier, for benefit of read_integer.
10422 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10423 not a digit in any supported base. (Bug#8602)
a108c10b 10424
ad5f9eea
PE
10425 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10426
aec1708a
PE
10427 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10428 to match comment at start of function. This also removes a
10429 GCC warning about overflow in a 32+64-bit port.
10430
47be4ab5
PE
10431 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10432
371cac43
PE
10433 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10434 Reported by Stefan Monnier in
10435 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10436 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10437 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10438
d01a7826
PE
10439 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10440 (EMACS_UINTPTR): Likewise, with uintptr_t.
10441
7fd47d5c
PE
10442 * lisp.h: Prefer 64-bit EMACS_INT if available.
10443 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10444 on 32-bit hosts that have 64-bit int, so that they can access
10445 large files.
122b0c86
PE
10446 However, temporarily disable this change unless the temporary
10447 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10448
8727937b
PE
10449 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10450
8ac068ac
PE
10451 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10452 This removes an assumption that EMACS_INT and long are the same
10453 width as pointers. The assumption is true for Emacs porting targets
10454 now, but we want to make other targets possible.
10455 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10456 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10457 In the rest of the code, change types of integers that hold casted
10458 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10459 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10460 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10461 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10462 No need to cast type when ORing.
10463 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10464 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10465 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10466 assume EMACS_INT is the same width as char *.
10467 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10468 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10469 Remove no-longer-needed casts.
10470 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10471 (xg_tool_bar_help_callback, xg_make_tool_item):
10472 Use EMACS_INTPTR to hold an integer
10473 that will be cast to void *; this can avoid a GCC warning
10474 if EMACS_INT is not the same width as void *.
10475 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10476 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10477 (current_message_1, set_message_1):
10478 Use a local to convert to proper width without a cast.
10479 * xmenu.c (dialog_selection_callback): Likewise.
10480
ede49d71
PE
10481 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10482 Also, don't assume VALBITS / RAND_BITS is less than 5,
10483 and don't rely on undefined behavior when shifting a 1 left into
10484 the sign bit.
10485 * lisp.h (get_random): Change signature to match.
10486
2f30ecd0
PE
10487 * lread.c (hash_string): Use size_t, not int, for hash computation.
10488 Normally we prefer signed values; but hashing is special, because
10489 it's better to use unsigned division on hash table sizes so that
10490 the remainder is nonnegative. Also, size_t is the natural width
10491 for hashing into memory. The previous code used 'int', which doesn't
10492 retain enough info to hash well into very large tables.
10493 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10494
2a866e7b
PE
10495 * dbusbind.c: Don't possibly lose pointer info when converting.
10496 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10497 Use XPNTR rather than XHASH, so that the high-order bits of
10498 the pointer aren't lost when converting through void *.
10499
51639eac
PE
10500 * eval.c (Fautoload): Don't double-shift a pointer.
10501
92394119
PE
10502 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10503
dbdb9a7c
JB
105042011-05-06 Juanma Barranquero <lekktu@gmail.com>
10505
10506 * gnutls.c (DEF_GNUTLS_FN):
10507 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10508
db7a0b4f
AS
105092011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10510
10511 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10512 marker. (Bug#8610)
10513
cd394be1 105142011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10515
10516 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10517 New version that can reserve upto 2GB of heap space.
10518
f7ff1b0f 105192011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10520
10521 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10522
639c109b
TZ
105232011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10524
10525 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10526 `gnutls_certificate_set_x509_key_file'.
10527
d2127135
JB
105282011-05-05 Juanma Barranquero <lekktu@gmail.com>
10529
10530 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10531 Update dependencies.
10532
e968f4f3
JB
105332011-05-04 Juanma Barranquero <lekktu@gmail.com>
10534
10535 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10536 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10537 Remove unused parameter `fildes'.
10538 * process.c (read_process_output, send_process): Don't pass it.
10539
84d358f0
JB
105402011-05-04 Juanma Barranquero <lekktu@gmail.com>
10541
10542 Fix previous change: the library cache is defined in w32.c.
10543 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10544 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10545
0898ca10
JB
105462011-05-04 Juanma Barranquero <lekktu@gmail.com>
10547
10548 Implement dynamic loading of GnuTLS on Windows.
10549
10550 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10551 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10552 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10553 Declare.
10554
10555 * gnutls.c (Qgnutls_dll): Define.
10556 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10557 (gnutls_*): Declare function pointers.
10558 (init_gnutls_functions): New function to initialize function pointers.
10559 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10560 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10561 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10562 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10563 (emacs_gnutls_write, emacs_gnutls_read)
10564 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10565 (Fgnutls_available_p): New function.
10566 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10567 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10568 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10569
10570 * image.c: Include w32.h.
10571 (Vimage_type_cache): Delete.
10572 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10573 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10574 (w32_delayed_load): Move to w32.c.
10575
10576 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10577
10578 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10579 (w32_delayed_load): Move from image.c. When loading a library, record
10580 its filename in the :loaded-from property of the library id.
10581 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10582 Initialize and staticpro them.
10583 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10584
10585 * process.c: Include lisp.h before w32.h, not after.
10586 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10587 instead of gnutls_record_check_pending.
10588
10589 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10590
ff4de4aa
TZ
105912011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10592
10593 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10594 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10595 as passed in.
10596
abe95abb
JD
105972011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10598
10599 * xterm.c (x_set_frame_alpha): Do not set property on anything
10600 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10601
e16e55d4
JB
106022011-05-02 Juanma Barranquero <lekktu@gmail.com>
10603
10604 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10605
bafcf6a5
JB
106062011-05-02 Juanma Barranquero <lekktu@gmail.com>
10607
10608 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10609 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10610 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10611 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10612 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10613 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10614 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10615 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10616 (Qgnutls_bootprop_callbacks_verify): Make static.
10617
e7a6747f
AS
106182011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10619
19ed11ba
AS
10620 * callproc.c: Indentation fixup.
10621
e7a6747f 10622 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10623 (wait_for_termination, interruptible_wait_for_termination):
10624 Move after wait_for_termination_1.
e7a6747f 10625
1ef14cb4
LMI
106262011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10627
10628 * sysdep.c (interruptible_wait_for_termination): New function
10629 which is like wait_for_termination, but allows keyboard
10630 interruptions.
10631
10632 * callproc.c (Fcall_process): Add (:file "file") as an option for
10633 the STDOUT buffer.
10634 (Fcall_process_region): Ditto.
10635
330d880c
EZ
106362011-04-30 Eli Zaretskii <eliz@gnu.org>
10637
8db90b73
EZ
10638 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10639 rather than `XVECTOR (FOO)->size'.
10640
330d880c
EZ
10641 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10642 inttypes.h, as a gnulib replacement is used if it not available in
10643 system headers.
10644
15cbd324
EZ
106452011-04-21 Eli Zaretskii <eliz@gnu.org>
10646
10647 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10648 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10649 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10650
10651 * coding.c (coding_alloc_by_realloc): Error out if destination
10652 will grow beyond MOST_POSITIVE_FIXNUM.
10653 (decode_coding_emacs_mule): Abort if there isn't enough place in
10654 charbuf for the composition carryover bytes. Reserve an extra
10655 space for up to 2 characters produced in a loop.
10656 (decode_coding_iso_2022): Abort if there isn't enough place in
10657 charbuf for the composition carryover bytes.
10658
106592011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10660
ae940cca
EZ
10661 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10662 aborting when %lld or %lll format is passed.
10663 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10664 %llo or %llx format is passed. (Bug#8545)
10665
03ab8921
EZ
10666 * window.c (window_scroll_line_based): Use a marker instead of
10667 simple variables to record original value of point. (Bug#7952)
10668
afda1437
EZ
10669 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10670 produced by %s or %c overflows available buffer space. (Bug#8545)
10671
f76dee0c
PE
106722011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10673
10674 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10675 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10676
fdc5744d
JB
106772011-04-28 Juanma Barranquero <lekktu@gmail.com>
10678
10679 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10680
638f053a
JB
106812011-04-28 Juanma Barranquero <lekktu@gmail.com>
10682
10683 * keyboard.c (Qdelayed_warnings_hook): Define.
10684 (command_loop_1): Run `delayed-warnings-hook'
10685 if Vdelayed_warnings_list is non-nil.
10686 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10687 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10688
d178f871
EZ
106892011-04-28 Eli Zaretskii <eliz@gnu.org>
10690
10691 * doprnt.c (doprnt): Don't return value smaller than the buffer
10692 size if the message was truncated. (Bug#8545).
10693
b124fd93
JB
106942011-04-28 Juanma Barranquero <lekktu@gmail.com>
10695
10696 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10697 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10698
e810457d
PE
106992011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10700
10701 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10702
ea51cceb
JB
107032011-04-27 Juanma Barranquero <lekktu@gmail.com>
10704
10705 * makefile.w32-in: Update dependencies.
10706
94dcfacf
EZ
107072011-04-27 Eli Zaretskii <eliz@gnu.org>
10708
10709 Improve `doprnt' and its usage. (Bug#8545)
10710 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10711 `format_end'. Remove support for %l as a conversion specifier.
10712 Don't use xrealloc. Improve diagnostics when the %l size modifier
10713 is used. Update the commentary.
10714
10715 * eval.c (verror): Simplify calculation of size_t.
10716
10717 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10718 messages.
10719
f61f41d7
PE
107202011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10721
10722 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10723 change.
10724
96fb4434
PE
107252011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10726
10727 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10728 This makes this file independent of the recent pseudovector change.
10729
671875da 107302011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10731
69e9b5a3
PE
10732 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10733
b5f869a7 10734 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10735 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10736 Remove unused local.
c8926152 10737 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10738
841a1577 10739 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10740 GCC 4.6.0 optimizes based on type-based alias analysis.
10741 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10742 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10743 != &v->size, and therefore "v->size = 1; b->size = 2; return
10744 v->size;" must therefore return 1. This assumption is incorrect
10745 for Emacs, since it type-puns struct Lisp_Vector * with many other
10746 types. To fix this problem, this patch adds a new type struct
f904488f 10747 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10748 and pseudovectors, and helps optimizing compilers not get fooled
10749 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10750 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10751 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10752 the size member.
eab3844f
PE
10753 (XSETPVECTYPE): Rewrite in terms of new macro.
10754 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10755 This is a bit clearer, and further avoids the possibility of
10756 undesirable aliasing.
10757 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10758 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10759 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10760 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10761 (ASIZE): Now uses header.size rather than size.
10762 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10763 to avoid the hassle of writing XVECTOR (foo)->header.size.
10764 (struct vectorlike_header): New type.
eab3844f
PE
10765 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10766 object, to help avoid aliasing.
10767 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10768 (SUBRP): Likewise, since Lisp_Subr is a special case.
10769 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10770 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10771 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10772 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10773 changed to be "header.size" and "header.next".
10774 * buffer.h (struct buffer): Likewise.
10775 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10776 * frame.h (struct frame): Likewise.
10777 * process.h (struct Lisp_Process): Likewise.
10778 * termhooks.h (struct terminal): Likewise.
10779 * window.c (struct save_window_data, struct saved_window): Likewise.
10780 * window.h (struct window): Likewise.
10781 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10782 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10783 * buffer.c (init_buffer_once): Likewise.
10784 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10785 special case.
10786 * process.c (Fformat_network_address): Use local var for size,
10787 for brevity.
10788
0df1eac5
PE
10789 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10790
847ab9d1 10791 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10792 * data.c (atof): Remove decl; no longer used or needed.
10793 (digit_to_number): Move to lread.c.
10794 (Fstring_to_number): Use new string_to_number function, to be
10795 consistent with how the Lisp reader treats infinities and NaNs.
10796 Do not assume that floating-point numbers represent EMACS_INT
10797 without losing information; this is not true on most 64-bit hosts.
10798 Avoid double-rounding errors, by insisting on integers when
10799 parsing non-base-10 numbers, as the documentation specifies.
10800 * lisp.h (string_to_number): New decl, replacing ...
10801 (isfloat_string): Remove.
bc0a5c13 10802 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10803 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10804 appears to have been a coding error. Similarly, do not accept
10805 strings like +-1e0 as floating point numbers. Do not report
10806 overflow for integer overflows unless the base is not 10 which
10807 means we have no simple and reliable way to continue.
10808 Break out the floating-point parsing into a new
10809 function string_to_number, so that Fstring_to_number parses
10810 floating point numbers consistently with the Lisp reader.
04f2d78b 10811 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10812 (E_CHAR, EXP_INT): Remove, replacing with ...
10813 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10814 (string_to_number): New function, replacing isfloat_string.
10815 This function checks for valid syntax and produces the resulting
10816 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10817 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10818 so that overflow for non-base-10 numbers is reported only when
10819 there's no portable and simple way to convert to floating point.
452f4150 10820
67769ffc
PE
10821 * textprop.c (set_text_properties_1): Rewrite for clarity,
10822 and to avoid GCC warning about integer overflow.
10823
c20db43f
PE
10824 * intervals.h (struct interval): Use EMACS_INT for members
10825 where EMACS_UINT might cause problems. See
10826 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10827 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10828 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10829 All uses changed.
37aa2f85
PE
10830 (offset_intervals): Tell GCC not to worry about length overflow
10831 when negating a negative length.
c20db43f 10832
2538aa2f
PE
10833 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10834 (overrun_check_free): Likewise.
10835
f2d3008d
PE
10836 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10837 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10838 word size.
10839
ec8df744
PE
10840 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10841 (gnutls_make_error): Rename local to avoid shadowing.
10842 (gnutls_emacs_global_deinit): ifdef out; not used.
10843 (Fgnutls_boot): Use const for pointer to readonly storage.
10844 Comment out unused local. Fix pointer signedness problems.
10845
640ee02d
PE
10846 * lread.c (openp): Don't stuff size_t into an 'int'.
10847 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10848 about possible signed overflow.
10849
6048fb2a
PE
10850 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10851 (GDK_KEY_g): Don't define if already defined.
10852 (xg_prepare_tooltip): Avoid pointer signedness problem.
10853 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10854
fa3c87e1
PE
10855 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10856 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10857
2172544b
PE
10858 * xfns.c (Fx_window_property): Simplify a bit,
10859 to make a bit faster and to avoid GCC 4.6.0 warning.
10860 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10861
9b821a21
PE
10862 * fns.c (internal_equal): Don't assume size_t fits in int.
10863
3c616cfa
PE
10864 * alloc.c (compact_small_strings): Tighten assertion a little.
10865
c2982e87
PE
10866 Replace pEd with more-general pI, and fix some printf arg casts.
10867 * lisp.h (pI): New macro, generalizing old pEd macro to other
10868 conversion specifiers. For example, use "...%"pI"d..." rather
10869 than "...%"pEd"...".
10870 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10871 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10872 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10873 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10874 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10875 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10876 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10877 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10878 64-bit hosts.
10879 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10880 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10881 * print.c (safe_debug_print, print_object): Likewise.
10882 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10883 to int.
6f04d126
PE
10884 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10885 avoiding the 0 flag, which is not portable.
c2982e87
PE
10886 * process.c (Fmake_network_process): Use pI to avoid cast.
10887 * region-cache.c (pp_cache): Likewise.
10888 * xdisp.c (decode_mode_spec): Likewise.
10889 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10890 behavior on 64-bit hosts with printf arg.
6f04d126 10891 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10892 (x_stop_queuing_selection_requests): Likewise.
10893 (x_get_window_property): Don't truncate byte count to an 'int'
10894 when tracing.
0b432f21 10895
5e073ec7
PE
10896 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10897 here, since it parses constructs like leading '-' and spaces,
10898 which are not wanted; and it overflows with large numbers.
10899 Instead, simply match F[0-9]+, which is what is wanted anyway.
10900
36372bf9
PE
10901 * alloc.c: Remove unportable assumptions about struct layout.
10902 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10903 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10904 (allocate_vectorlike, make_pure_vector): Use the new macros,
10905 plus offsetof, to remove unportable assumptions about struct layout.
10906 These assumptions hold on all porting targets that I know of, but
10907 they are not guaranteed, they're easy to remove, and removing them
10908 makes further changes easier.
10909
0b432f21
PE
10910 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10911 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10912 (string_overrun_cookie): Now const. Use initializers that
10913 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10914 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10915 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10916 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10917 multiple of sizeof (EMACS_INT); it need not be, if
10918 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10919 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10920
895009e1
JB
109212011-04-26 Juanma Barranquero <lekktu@gmail.com>
10922
10923 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10924
6a7a1b0b
TZ
109252011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10926
10927 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10928 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10929 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10930
841a1577 109312011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10932
10933 * lisp.h (Qdebug): List symbol.
895009e1 10934 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10935 * keyboard.c (debug-on-event): New variable.
10936 (handle_user_signal): Break into debugger when debug-on-event
10937 matches the current signal symbol.
10938
f2d3ba6f
DN
109392011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10940
10941 * alloc.c (check_sblock, check_string_bytes)
10942 (check_string_free_list): Convert to standard C.
10943
42ce4c63
TZ
109442011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10945
10946 * w32.c (emacs_gnutls_push): Fix typo.
10947
825cd63c
EZ
109482011-04-25 Eli Zaretskii <eliz@gnu.org>
10949
fb11d64d
EZ
10950 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10951 "cast to pointer from integer of different size".
10952
825cd63c
EZ
10953 Improve doprnt and its use in verror. (Bug#8545)
10954 * doprnt.c (doprnt): Document the set of format control sequences
10955 supported by the function. Use SAFE_ALLOCA instead of always
10956 using `alloca'.
10957
10958 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10959 is one byte too soon. Don't use xrealloc; instead xfree and
10960 xmalloc anew.
10961
e061a11b
TZ
109622011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10963
10964 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10965 callbacks stage.
10966
10967 * gnutls.c: Renamed global_initialized to
10968 gnutls_global_initialized. Added internals for the
10969 :verify-hostname-error, :verify-error, and :verify-flags
10970 parameters of `gnutls-boot' and documented those parameters in the
10971 docstring. Start callback support.
9173deec
JB
10972 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10973 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10974 on error. Return error code.
e061a11b
TZ
10975 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10976 (emacs_gnutls_read): Likewise.
10977 (Fgnutls_boot): Return handshake error code.
10978 (emacs_gnutls_handle_error): New function.
10979 (wsaerror_to_errno): Likewise.
10980
10981 * w32.h (emacs_gnutls_pull): Add prototype.
10982 (emacs_gnutls_push): Likewise.
10983
10984 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10985 (emacs_gnutls_push): Likewise.
10986
109872011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10988
10989 * process.c (wait_reading_process_output): Check if GnuTLS
10990 buffered some data internally if no FDs are set for TLS
10991 connections.
10992
10993 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10994 (LIBS): Link to USER_LIBS.
10995 ($(BLD)/gnutls.$(0)): New target.
10996
fa6996bc
EZ
109972011-04-24 Eli Zaretskii <eliz@gnu.org>
10998
eb35682e
EZ
10999 * xdisp.c (handle_single_display_spec): Rename the
11000 display_replaced_before_p argument into display_replaced_p, to
11001 make it consistent with the commentary. Fix typos in the
11002 commentary.
11003
e2ad650c
EZ
11004 * textprop.c (syms_of_textprop): Remove dead code.
11005 (copy_text_properties): Delete obsolete commentary about an
11006 interface that was deleted long ago. Fix typos in the description
11007 of arguments.
11008
1b2de274
EZ
11009 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11010 to changes in oldXMenu/XMenu.h from 2011-04-16.
11011 <menu_help_message, prev_menu_help_message>: Constify.
11012 (IT_menu_make_room): menu->help_text is now `const char **';
11013 adjust.
11014
11015 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11016 to changes in oldXMenu/XMenu.h from 2011-04-16.
11017 (struct XMenu): Declare `help_text' `const char **'.
11018
11019 * xfaces.c <Qunspecified>: Make extern again.
11020
11021 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11022 required by POSIX.
1b2de274 11023
762b15be
EZ
11024 * doc.c (get_doc_string): Improve the format passed to `error'.
11025
11026 * doprnt.c (doprnt): Improve commentary.
11027
11028 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11029
11030 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11031 them with etags.
11032
f1052e5d
EZ
11033 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11034 changes in globals.h immediately force recompilation.
762b15be
EZ
11035 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11036 $(CURDIR)/s/ms-w32.h.
11037 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11038
fa6996bc
EZ
11039 * character.c (Fchar_direction): Function deleted.
11040 (syms_of_character): Don't defsubr it.
11041 <char-direction-table>: Deleted.
11042
e6c3da20
EZ
110432011-04-23 Eli Zaretskii <eliz@gnu.org>
11044
11045 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11046 * doprnt.c: Include limits.h.
11047 (SIZE_MAX): New macro.
04f2d78b
CB
11048 (doprnt): Return a size_t value. 2nd arg is now size_t.
11049 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11050 Improve overflow protection. Support `l' modifier for integer
11051 conversions. Support %l conversion. Don't assume an EMACS_INT
11052 argument for integer conversions and for %c.
11053
11054 * lisp.h (doprnt): Restore prototype.
11055
11056 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11057 $(SRC)/character.h.
11058
11059 * Makefile.in (base_obj): Add back doprnt.o.
11060
11061 * deps.mk (doprnt.o): Add back prerequisites.
11062 (callint.o): Depend on character.h.
11063
11064 * eval.c (internal_lisp_condition_case): Include the handler
11065 representation in the error message.
11066 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11067 when breaking from the loop.
11068
11069 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11070
11071 * callint.c (Fcall_interactively): When displaying error message
11072 about invalid control letter, pass the character's codepoint, not
11073 a pointer to its multibyte form. Improve display of the character
11074 in octal and display also its hex code.
11075
11076 * character.c (char_string): Use %x to display the (unsigned)
11077 codepoint of an invalid character, to avoid displaying a bogus
11078 negative value.
11079
11080 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11081 `error', not SYMBOL_NAME itself.
11082
11083 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11084 character arguments to `error'.
11085
11086 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11087 to `error' in error message about FINAL_CHAR argument. Make sure
11088 FINAL_CHAR is a character, and use %c when it is passed as
11089 argument to `error'.
11090
4ffd0d6b 110912011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11092
11093 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11094
11095 * w32.c: Include <time.h>.
11096 (sys_localtime): New function.
11097
4ffd0d6b 110982011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11099
11100 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11101
4ffd0d6b 11102 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11103
4ffd0d6b 111042011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11105
4ffd0d6b
GM
11106 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11107 zombies (Bug#8467).
aac0c6e3 11108
04c56954
EZ
111092011-04-19 Eli Zaretskii <eliz@gnu.org>
11110
11111 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11112 gl_state.e_property when gl_state.object is Qt.
11113
11114 * insdel.c (make_gap_larger): Remove limitation of buffer size
11115 to <= INT_MAX.
11116
16a43933
CY
111172011-04-18 Chong Yidong <cyd@stupidchicken.com>
11118
11119 * xdisp.c (lookup_glyphless_char_display)
11120 (produce_glyphless_glyph): Handle cons cell entry in
11121 glyphless-char-display.
11122 (Vglyphless_char_display): Document it.
11123
11124 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11125 glyphless-char-display.
11126
4581706e
CY
111272011-04-17 Chong Yidong <cyd@stupidchicken.com>
11128
11129 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11130
11131 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11132
11133 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11134 definition for no-X builds.
11135
4887c6e2 111362011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11137
fd35b6f9
PE
11138 Static checks with GCC 4.6.0 and non-default toolkits.
11139
5c1ccb01
PE
11140 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11141
006c5daa
PE
11142 * process.c (keyboard_bit_set): Define only if SIGIO.
11143 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11144 (send_process): Repair possible setjmp clobbering.
11145
efc736d3
PE
11146 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11147
4e2fe2e6
PE
11148 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11149
f97334a2
PE
11150 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11151
4e75f29d
PE
11152 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11153 Define only if needed.
11154
90efadd1
PE
11155 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11156 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 11157 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 11158
3c647824
PE
11159 * dispextern.h (struct redisplay_interface): Rename param
11160 to avoid shadowing.
e264f262 11161 * termhooks.h (struct terminal): Likewise.
761383f4 11162 * xterm.c (xembed_send_message): Likewise.
3c647824 11163
b58c5c4a
PE
11164 * insdel.c (make_gap_smaller): Define only if
11165 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11166
cad59032
PE
11167 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11168 it.
11169
c339dc2e
PE
11170 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11171 so that we aren't warned about unused symbols.
11172
91a3e27b
PE
11173 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11174
399c71d3 11175 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 11176
8ffc96f5
PE
11177 * xfns.c (x_real_positions): Mark locals as initialized.
11178
eef9bc79
PE
11179 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11180
098db9dd
PE
11181 * xterm.c: Fix problems found by static analysis with other toolkits.
11182 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
11183 (x_dispatch_event): Declare static if USE_GTK, and
11184 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 11185 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 11186 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
11187 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11188 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 11189
eb18f6cc
PE
11190 * xmenu.c (menu_help_callback): Pointer type fixes.
11191 Use const pointers when pointing at readonly data. Avoid pointer
11192 signedness clashes.
11193 (FALSE): Remove unused macro.
11194 (update_frame_menubar): Remove unused decl.
11195
1fe72bf8
PE
11196 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11197
60d9e1db
PE
11198 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11199 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11200 (single_menu_item): Rename local to avoid shadowing.
11201
39261c26
PE
11202 * keyboard.c (make_lispy_event): Remove unused local var.
11203
018c5e19
PE
11204 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11205 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11206
63d2b86e
PE
11207 * bitmaps: Change bitmaps from unsigned char back to the X11
11208 compatible char. Avoid the old compiler warnings about
11209 out-of-range initializers by using, for example, '\xab' rather
11210 than 0xab.
11211
aefd87e1
PE
11212 * xgselect.c (xgselect_initialize): Check vs interface
11213 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11214
bf501fb9
PE
11215 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11216
e9829fdf
PE
11217 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11218 to read-only memory.
11219
1086c095
PE
11220 * fns.c (vector): Remove; this old hack is no longer needed.
11221
2baccd04 11222 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 11223 Remove unused var.
dde42981 11224 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 11225
72391843 11226 * xrdb.c (x_load_resources): Omit unused local.
3565b346 11227
436c16df 11228 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 11229 (x_window): Rename locals to avoid shadowing.
dc5ddd85 11230 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 11231
92bb796d 11232 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 11233 (x_term_init): Remove local to avoid shadowing.
92bb796d 11234
764430a3 11235 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
11236
11237 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11238 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11239
d1dfb56c
EZ
112402011-04-16 Eli Zaretskii <eliz@gnu.org>
11241
c4354cb4
EZ
11242 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11243
d1dfb56c
EZ
11244 Fix regex.c, syntax.c and friends for buffers > 2GB.
11245 * syntax.h (struct gl_state_s): Declare character position members
11246 EMACS_INT.
11247
11248 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11249
04f2d78b
CB
11250 * textprop.c (verify_interval_modification, interval_of):
11251 Declare arguments EMACS_INT.
d1dfb56c
EZ
11252
11253 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11254 EMACS_INT.
11255
11256 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11257
11258 * indent.c (Fvertical_motion): Local variable it_start is now
11259 EMACS_INT.
11260
11261 * regex.c (re_match, re_match_2, re_match_2_internal)
11262 (bcmp_translate, regcomp, regexec, print_double_string)
11263 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11264 (re_compile_pattern, re_exec): Declare arguments and local
11265 variables `size_t' and `ssize_t' and return values `regoff_t', as
11266 appropriate.
11267 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11268 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11269 <compile_stack_type>: `size' and `avail' are now `size_t'.
11270
11271 * regex.h <regoff_t>: Use ssize_t, not int.
11272 (re_search, re_search_2, re_match, re_match_2): Arguments that
11273 specify buffer/string position and length are now ssize_t and
11274 size_t. Return type is regoff_t.
11275
613052cd
BK
112762011-04-16 Ben Key <bkey76@gmail.com>
11277
11278 * nsfont.m: Fixed bugs in ns_get_family and
11279 ns_descriptor_to_entity that were caused by using free to
11280 deallocate memory blocks that were allocated by xmalloc (via
11281 xstrdup). This caused Emacs to crash when compiled with
11282 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11283 --enable-checking=xmallocoverrun). xfree is now used to
11284 deallocate these memory blocks.
11285
4170f62f 112862011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11287
71b41406
PE
11288 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11289
9587a89d
PE
11290 emacs_write: Accept and return EMACS_INT for sizes.
11291 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11292 et seq.
11293 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11294 Accept and return EMACS_INT.
11295 (emacs_gnutls_write): Return the number of bytes written on
11296 partial writes.
11297 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11298 (emacs_read, emacs_write): Remove check for negative size, as the
11299 Emacs source code has been audited now.
9587a89d
PE
11300 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11301 (emacs_read, emacs_write): Use it.
273a5f82
PE
11302 * process.c (send_process): Adjust to the new signatures of
11303 emacs_write and emacs_gnutls_write. Do not attempt to store
11304 a byte offset into an 'int'; it might overflow.
9587a89d 11305 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11306
3e047f51
PE
11307 * sound.c: Don't assume sizes fit in 'int'.
11308 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11309 Return EMACS_INT, not int.
3e047f51 11310 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11311 Accept EMACS_INT, not int.
11312 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11313 record read return values.
11314
cc39a9db
BK
113152011-04-15 Ben Key <bkey76@gmail.com>
11316
c9d0ec6d
JB
11317 * keyboard.c (Qundefined): Don't declare static since it is used
11318 in nsfns.m.
11319 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11320 static since they are used in nsfont.m.
cc39a9db 11321
6c60eb9f
SM
113222011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11323
11324 * process.c (Qprocessp): Don't declare static.
11325 * lisp.h (Qprocessp): Declare again.
11326
7990b61a
JB
113272011-04-15 Juanma Barranquero <lekktu@gmail.com>
11328
11329 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11330
5d4cb038
PE
113312011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11332
8bd7b830 11333 Improve C-level modularity by making more things 'static'.
cd64ea1d 11334
e3b27b31
PE
11335 Don't publish debugger-only interfaces to other modules.
11336 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11337 (verify_bytepos, count_markers): Move decls to the only modules
11338 that need them.
11339 * region-cache.h (pp_cache): Likewise.
11340 * window.h (check_all_windows): Likewise.
11341 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11342
5d4cb038
PE
11343 * sysdep.c (croak): Now static, if
11344 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11345 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11346
11347 * alloc.c (refill_memory_reserve): Now static if
11348 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11349 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11350
e87b6180
PE
11351 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11352 Define only if USE_LUCID.
11353
ac64929e
PE
11354 * xrdb.c (x_customization_string, x_rm_string): Now static.
11355
6f37259d
PE
11356 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11357 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11358
1683e3ab
PE
11359 * xdisp.c (draw_row_with_mouse_face): Now static.
11360 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11361
de9c2632
PE
11362 * window.h (check_all_windows): Mark externally visible.
11363
2b96acb7
PE
11364 * window.c (window_deletion_count): Now static.
11365
11366 * undo.c: Make symbols static if they're not exported.
11367 (last_undo_buffer, last_boundary_position, pending_boundary):
11368 Now static.
11369
50436f33
PE
11370 * textprop.c (interval_insert_behind_hooks): Now static.
11371 (interval_insert_in_front_hooks): Likewise.
11372
64520e5c
PE
11373 * term.c: Make symbols static if they're not exported.
11374 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11375 (max_frame_lines, tty_set_terminal_modes):
11376 (tty_reset_terminal_modes, tty_turn_off_highlight):
11377 (get_tty_terminal): Now static.
11378 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11379 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11380 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11381 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11382 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11383
1fa53021
PE
11384 * sysdep.c: Make symbols static if they're not exported.
11385 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11386 Now static.
11387 (sigprocmask_set, full_mask): Remove; unused.
11388 (wait_debugging): Mark as visible.
11389 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11390 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11391
d4b43b22
PE
11392 * syntax.c (syntax_temp): Define only if !__GNUC__.
11393
b7c513d0
PE
11394 * sound.c (current_sound_device, current_sound): Now static.
11395
989b29ad
PE
11396 * search.c (searchbufs, searchbuf_head): Now static.
11397
13a55a78
PE
11398 * scroll.c (scroll_cost): Remove; unused.
11399 * dispextern.h (scroll_cost): Remove decl.
11400
de68a1fc
PE
11401 * region-cache.h (pp_cache): Mark as externally visible.
11402
40ccffa6
PE
11403 * process.c: Make symbols static if they're not exported.
11404 (process_tick, update_tick, create_process, chan_process):
11405 (Vprocess_alist, proc_buffered_char, datagram_access):
11406 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11407 (deactivate_process): Mark defn as static, as well as decl.
11408 * lisp.h (create_process): Remove decl.
11409 * process.h (chan_process, Vprocess_alist): Remove decls.
11410
ad64fc97
PE
11411 * print.c: Make symbols static if they're not exported.
11412 (print_depth, new_backquote_output, being_printed, print_buffer):
11413 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11414 (print_interval, print_number_index, initial_stderr_stream):
11415 Now static.
11416 * lisp.h (Fprinc): Remove decl.
11417 (debug_output_compilation_hack): Mark as externally visible.
11418
adddb265
PE
11419 * sysdep.c (croak): Move decl from here to syssignal.h.
11420 * syssignal.h (croak): Put it here, so the API can be checked when
11421 'croak' is called from dissociate_if_controlling_tty.
11422
1717ede2
PE
11423 * minibuf.c: Make symbols static if they're not exported.
11424 (minibuf_save_list, choose_minibuf_frame): Now static.
11425 * lisp.h (choose_minibuf_frame): Remove decl.
11426
fa5fb2bc
PE
11427 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11428
1e3890d1
PE
11429 * lread.c: Make symbols static if they're not exported.
11430 (read_objects, initial_obarray, oblookup_last_bucket_number):
11431 Now static.
11432 (make_symbol): Remove; unused.
11433 * lisp.h (initial_obarray, make_symbol): Remove decls.
11434
8a1414fa
PE
11435 * keyboard.c: Make symbols static if they're not exported.
11436 (single_kboard, recent_keys_index, total_keys, recent_keys):
11437 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11438 (this_single_command_key_start, echoing, last_auto_save):
11439 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11440 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11441 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11442 (Vlispy_mouse_stem, double_click_count):
11443 Now static.
11444 (force_auto_save_soon): Define only if SIGDANGER.
11445 (ignore_mouse_drag_p): Now static if
11446 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11447 (print_help): Remove; unused.
11448 (stop_character, last_timer_event): Mark as externally visible.
11449 * keyboard.h (ignore_mouse_drag_p): Declare only if
11450 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11451 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11452 * lisp.h (echoing): Remove decl.
11453 (force_auto_save_soon): Declare only if SIGDANGER.
11454 * xdisp.c (redisplay_window): Simplify code, to make it more
11455 obvious that ignore_mouse_drag_p is not accessed if !defined
11456 USE_GTK && !defined HAVE_NS.
11457
93ea6e8f
PE
11458 * intervals.c: Make symbols static if they're not exported.
11459 (merge_properties_sticky, merge_interval_right, delete_interval):
11460 Now static.
11461 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11462
77382fcc
PE
11463 * insdel.c: Make symbols static if they're not exported.
11464 However, leave prepare_to_modify_buffer alone. It's never
11465 called from outside this function, but that appears to be a bug.
11466 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11467 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11468 (adjust_after_replace_noundo): Remove; unused.
11469 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11470 (signal_before_change): Remove decls.
77382fcc 11471
9306c32e
PE
11472 * indent.c (val_compute_motion, val_vmotion): Now static.
11473
cd44d2eb
PE
11474 * image.c: Make symbols static if they're not exported.
11475 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11476 if USE_GTK.
11477 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11478 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11479
ad9a7a06
PE
11480 * fringe.c (standard_bitmaps): Now static.
11481 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11482
81626931
PE
11483 * frame.c: Make symbols static if they're not exported.
11484 (x_report_frame_params, make_terminal_frame): Now static.
11485 (get_frame_param): Now static, unless HAVE_NS.
11486 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11487 (x_get_resource_string): Remove; not used.
11488 * frame.h (make_terminal_frame, x_report_frame_params):
11489 (x_get_resource_string); Remove decls.
11490 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11491 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11492
239f9db9
PE
11493 * font.c, fontset.c: Make symbols static if they're not exported.
11494 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11495 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11496 * font.c (font_close_object): Now static.
11497 * font.h (font_close_object): Remove.
11498 * fontset.c (FONTSET_OBJLIST): Remove.
11499 (free_realized_fontset) #if-0 the body, which does nothing.
11500 (face_suitable_for_char_p): #if-0, as it's never called.
11501 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11502 * xfaces.c (face_at_string_position):
11503 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11504 since 0 is always ASCII.
11505
dfcf3579
PE
11506 * fns.c (weak_hash_tables): Now static.
11507
5045092b
PE
11508 * fileio.c: Make symbols static if they're not exported.
11509 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11510 (Vwrite_region_annotation_buffers): Now static.
11511
57a96f5c
PE
11512 * eval.c: Make symbols static if they're not exported.
11513 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11514 * lisp.h (backtrace_list): Remove decl.
11515
35f08c38
PE
11516 * emacs.c: Make symbols static if they're not exported.
11517 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11518 (fatal_error_code, fatal_error_signal_hook, standard_args):
11519 Now static.
11520 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11521 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11522 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11523 * lisp.h (fatal_error_signal_hook): Remove decl.
11524 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11525
f44bd759
PE
11526 * editfns.c: Move a (normally-unused) function to its only use.
11527 * editfns.c, lisp.h (get_operating_system_release): Remove.
11528 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11529 worth the hassle of breaking this out.
11530
b532497d
PE
11531 * xterm.c: Make symbols static if they're not exported.
11532 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11533 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11534 (x_destroy_window, x_delete_display):
11535 Now static.
11536 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11537 (x_mouse_leave): Remove; unused.
11538 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11539 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11540 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11541 Remove decls.
11542 (x_mouse_leave): Declare only if WINDOWSNT.
11543 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11544 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11545 USE_X_TOOLKIT.
11546
1675728f
PE
11547 * ftxfont.c: Make symbols static if they're not exported.
11548 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11549 HAVE_FREETYPE.
11550 * font.h (ftxfont_driver): Likewise.
11551
e4cebfca
PE
11552 * xfns.c: Make symbols static if they're not exported.
11553 (x_last_font_name, x_display_info_for_name):
11554 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11555 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11556 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11557 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11558 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11559 (last_show_tip_args): Now static.
11560 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11561 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11562 (x_screen_planes): Remove; unused.
11563 * dispextern.h (x_screen_planes): Remove decl.
11564
5bf46f05
PE
11565 * dispnew.c: Make symbols static if they're not exported.
11566 * dispextern.h (redraw_garbaged_frames, scrolling):
11567 (increment_row_positions): Remove.
11568 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11569 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11570 Now static.
11571 (redraw_garbaged_frames): Remove; unused.
11572
435f4c28
PE
11573 * xfaces.c: Make symbols static if they're not exported.
11574 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11575 Remove decls.
11576 * xterm.h (defined_color): Remove decls.
11577 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11578 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11579 (menu_face_changed_default, defined_color, free_realized_face):
11580 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11581 (ascii_face_of_lisp_face): Remove; unused.
11582
8524aef3
PE
11583 * xdisp.c: Make symbols static if they're not exported.
11584 * dispextern.h (scratch_glyph_row, window_box_edges):
11585 (glyph_to_pixel_coords, set_cursor_from_row):
11586 (get_next_display_element, set_iterator_to_next):
11587 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11588 (show_mouse_face): Remove decls
11589 * frame.h (message_buf_print): Likewise.
11590 * lisp.h (pop_message, set_message, check_point_in_composition):
11591 Likewise.
11592 * xterm.h (set_vertical_scroll_bar): Likewise.
11593 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11594 (message_buf_print, scratch_glyph_row, displayed_buffer):
11595 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11596 (get_next_display_element, show_mouse_face, window_box_edges):
11597 (frame_to_window_pixel_xy, check_point_in_composition):
11598 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11599 (glyph_to_pixel_coords): Remove; unused.
11600
16390cd2
PE
11601 * dired.c (file_name_completion): Now static.
11602
11603 * dbusbind.c (xd_in_read_queued_messages): Now static.
11604
a25f4dfa
PE
11605 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11606 * data.c (circular_list_error): Remove.
11607
14a9c8df
PE
11608 * commands.h (last_point_position, last_point_position_buffer):
11609 (last_point_position_window): Remove decls.
11610 * keyboard.c: Make these variables static.
11611
04f2d78b
CB
11612 * coding.h (coding, code_convert_region, encode_coding_gap):
11613 Remove decls.
74ab6df5
PE
11614 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11615 (iso_code_class, detect_coding, code_convert_region): Now static.
11616 (encode_coding_gap): Remove; unused.
11617
38dfbee1
PE
11618 * chartab.c (chartab_chars, chartab_bits): Now static.
11619
a2cb4e63
PE
11620 * charset.h (charset_iso_8859_1): Remove decl.
11621 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11622 Now static.
11623
127198fd
PE
11624 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11625 * ccl.c (Vccl_program_table): Now static.
11626 (check_ccl_update): Remove; unused.
11627
d85b608f
PE
11628 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11629 * category.h: ... from here.
11630 * category.c (check_category_table, set_category_set): Now static.
11631
31cd66f3
PE
11632 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11633 * lisp.h: Remove these decls.
11634
c358e587
PE
11635 * buffer.c (buffer_count): Remove unused var.
11636
e78aecca
PE
11637 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11638 so that it's not optimized away.
11639 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11640 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11641 exported only to the debugger.
11642
e192d7d3 11643 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11644 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11645
92470028
PE
11646 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11647 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11648 was inaccessible from Lisp.
11649 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11650 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11651
244ed907
PE
11652 alloc.c: Import and export fewer symbols, and remove unused items.
11653 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11654 is defined.
11655 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11656 it's not optimized away by whole-program optimization.
11657 (message_enable_multibyte, free_misc): Remove.
11658 (catchlist, handlerlist, mark_backtrace):
11659 Declare only if BYTE_MARK_STACK.
11660 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11661 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11662 (message_enable_multibyte): Remove decl.
11663 (free_misc, interval_free_list, float_block, float_block_index):
11664 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11665 (cons_free_list, last_marked_index):
11666 Now static.
11667 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11668 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11669 (mark_backtrace): Define only if BYTE_MARK_STACK.
11670 * xdisp.c (message_enable_multibyte): Now static.
11671
61c2b50e 11672 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11673 This makes it easier for human readers (and static analyzers)
11674 to see whether these variables are used from other modules.
11675 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11676 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11677 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11678 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11679 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11680 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11681 * xmenu.c, xselect.c:
11682 Declare Q* vars static if they are not used in other modules.
11683 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11684 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11685 Remove decls of unexported vars.
11686 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11687
95c82688
PE
11688 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11689
16a97296
PE
11690 Make Emacs functions such as Fatom 'static' by default.
11691 This makes it easier for human readers (and static analyzers)
11692 to see whether these functions can be called from other modules.
11693 DEFUN now defines a static function. To make the function external
11694 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11695 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11696 (Finit_image_library):
16a97296
PE
11697 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11698 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11699 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11700 Remove decls, since these functions are now static.
11701 (Funintern, Fget_internal_run_time): New decls, since these functions
11702 were already external.
95c82688 11703
16a97296
PE
11704 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11705 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11706 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11707 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11708 * keyboard.c, keymap.c, lread.c:
11709 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11710 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11711 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11712 Mark functions with DEFUE instead of DEFUN,
11713 if they are used in other modules.
11714 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11715 decls for now-static functions.
11716 * buffer.h (Fdelete_overlay): Remove decl.
11717 * callproc.c (Fgetenv_internal): Mark as internal.
11718 * composite.c (Fremove_list_of_text_properties): Remove decl.
11719 (Fcomposition_get_gstring): New forward static decl.
11720 * composite.h (Fcomposite_get_gstring): Remove decl.
11721 * dired.c (Ffile_attributes): New forward static decl.
11722 * doc.c (Fdocumntation_property): New forward static decl.
11723 * eval.c (Ffetch_bytecode): New forward static decl.
11724 (Funintern): Remove extern decl; now in .h file where it belongs.
11725 * fileio.c (Fmake_symbolic_link): New forward static decl.
11726 * image.c (Finit_image_library): New forward static decl.
11727 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11728 * intervals.h (Fprevious_property_change):
11729 (Fremove_list_of_text_properties): Remove decls.
11730 * keyboard.c (Fthis_command_keys): Remove decl.
11731 (Fcommand_execute): New forward static decl.
11732 * keymap.c (Flookup_key): New forward static decl.
11733 (Fcopy_keymap): Now static.
11734 * keymap.h (Flookup_key): Remove decl.
11735 * process.c (Fget_process): New forward static decl.
11736 (Fprocess_datagram_address): Mark as internal.
11737 * syntax.c (Fsyntax_table_p): New forward static decl.
11738 (skip_chars): Remove duplicate decl.
11739 * textprop.c (Fprevious_property_change): New forward static decl.
11740 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11741 Now internal.
11742 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11743 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11744
785bbd42
PE
11745 * editfns.c (Fformat): Remove unreachable code.
11746
8b913b57
AS
117472011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11748
11749 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11750 change. (Bug#8496)
11751
a6744a35
EZ
117522011-04-13 Eli Zaretskii <eliz@gnu.org>
11753
11754 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11755 when at ZV. (Bug#8487)
11756
e7974947
AS
117572011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11758
baad03f0
AS
11759 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11760 (Bug#8437)
11761 * keyboard.c (parse_tool_bar_item): Likewise.
11762 * sound.c (sound_cleanup, alsa_close): Likewise.
11763 * termcap.c (tgetent): Likewise.
11764 * xfns.c (x_default_font_parameter): Likewise.
11765 * xsettings.c (read_and_apply_settings): Likewise.
11766
e7974947
AS
11767 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11768 (overrun_check_free): Protoize.
11769
28272684
PE
117702011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11771
11772 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11773 since callers should never pass a negative size.
11774 Change the signature to match that of plain 'read' and 'write'; see
11775 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11776 * lisp.h: Update prototypes of emacs_write and emacs_read.
11777
11997c76
EZ
117782011-04-11 Eli Zaretskii <eliz@gnu.org>
11779
11780 * xdisp.c (redisplay_window): Don't try to determine the character
11781 position of the scroll margin if the window start point w->startp
e896f03c 11782 is outside the buffer's accessible region. (Bug#8468)
11997c76 11783
8a2cbd72
EZ
117842011-04-10 Eli Zaretskii <eliz@gnu.org>
11785
11786 Fix write-region and its subroutines for buffers > 2GB.
11787 * fileio.c (a_write, e_write): Modify declaration of arguments and
11788 local variables to support buffers larger than 2GB.
11789 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11790
11791 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11792 argument, local variables, and return value.
11793
11794 * lisp.h: Update prototypes of emacs_write and emacs_read.
11795
11796 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11797
4073e537 117982011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11799
1ebfdcb6
PE
11800 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11801
b2ded58d
PE
11802 Fix more problems found by GCC 4.6.0's static checks.
11803
7d66342c
PE
11804 * xdisp.c (vmessage): Use a better test for character truncation.
11805
bbf47d44
PE
11806 * charset.c (load_charset_map): <, not <=, for optimization,
11807 and to avoid potential problems with integer overflow.
9248994d 11808 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11809 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11810 * editfns.c (Fformat): Likewise.
1e69125e 11811 * syntax.c (skip_chars): Likewise.
3befa583 11812
e3019616
PE
11813 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11814 This also lets GCC 4.6.0 generate slightly better loop code.
11815
becfa255
PE
11816 * callint.c (Fcall_interactively): <, not <=, for optimization.
11817 (Fcall_interactively): Count the number of arguments produced,
11818 not the number of arguments given. This is simpler and lets GCC
11819 4.6.0 generate slightly better code.
11820
dae0cd48
PE
11821 * ftfont.c: Distingish more carefully between FcChar8 and char.
11822 The previous code passed unsigned char * to a functions like
11823 strlen and xstrcasecmp that expect char *, which does not
11824 conform to the C standard.
11825 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11826 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11827 char * when the C standard requires it.
11828
76032d70
PE
11829 * keyboard.c (read_char): Remove unused var.
11830
eb3f1cc8
PE
11831 * eval.c: Port to Windows vsnprintf (Bug#8435).
11832 Include <limits.h>.
11833 (SIZE_MAX): Define if the headers do not.
11834 (verror): Do not give up if vsnprintf returns a negative count.
11835 Instead, grow the buffer. This ports to Windows vsnprintf, which
11836 does not conform to C99. Problem reported by Eli Zaretskii.
11837 Also, simplify the allocation scheme, by avoiding the need for
11838 calling realloc, and removing the ALLOCATED variable.
11839
70476b54
PE
11840 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11841
12020a9e
PE
11842 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11843 But keep the doprint source code for now, as we might revamp it
11844 and use it again (Bug#8435).
ea6c7ae6
PE
11845 * lisp.h (doprnt): Remove.
11846 * Makefile.in (base_obj): Remove doprnt.o.
11847 * deps.mk (doprnt.o): Remove.
11848
5fdb398c
PE
11849 error: Print 32- and 64-bit integers portably (Bug#8435).
11850 Without this change, on typical 64-bit hosts error ("...%d...", N)
11851 was used to print both 32- and 64-bit integers N, which relied on
11852 undefined behavior.
61bdb816 11853 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11854 * lisp.h (error, verror): Mark as printf-like functions.
11855 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11856 Report overflow in size calculations when allocating printf buffer.
11857 Do not truncate output string at its first null byte.
11858 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11859 Truncate the output at a character boundary, since vsnprintf does not
11860 do that.
11861 * charset.c (check_iso_charset_parameter): Convert internal
11862 character to string before calling 'error', since %c now has the
11863 printf meaning.
11864 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11865 overflow when computing char to be passed to 'error'. Do not
11866 pass Lisp_Object to 'error'; pass the integer instead.
11867 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11868 formatted with plain %d.
11869
b189fa66
PE
11870 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11871
bff87ef0
PE
11872 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11873
7e2cac20
PE
11874 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11875
ce4d90b5
PE
11876 * xterm.c (x_catch_errors): Remove duplicate declaration.
11877
266c9547
PE
11878 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11879
79c49ad2
PE
11880 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11881
368f4090
JM
118822011-04-10 Jim Meyering <meyering@redhat.com>
11883
11884 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11885 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11886 return ssize_t not "int", and use size_t as the buffer length.
11887 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11888 * gnutls.h: Update declarations.
11889 * process.c (read_process_output): Use ssize_t, to match.
11890 (send_process): Likewise.
11891
a32d4040
CY
118922011-04-09 Chong Yidong <cyd@stupidchicken.com>
11893
11894 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11895
8546720e 118962011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11897
04f2d78b
CB
11898 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11899 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11900
8546720e
GM
11901 * xterm.c (handle_one_xevent):
11902 * xmenu.c (create_and_show_popup_menu):
11903 * xselect.c (x_decline_selection_request)
11904 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11905
0a2f5c1a 119062011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11907
11908 Fix some uses of `int' instead of EMACS_INT.
11909 * search.c (string_match_1, fast_string_match)
11910 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11911 (scan_buffer, find_next_newline_no_quit)
11912 (find_before_next_newline, search_command, Freplace_match)
11913 (Fmatch_data): Make some `int' variables be EMACS_INT.
11914
11915 * xdisp.c (display_count_lines): 3rd argument and return value now
11916 EMACS_INT. All callers changed.
11917 (pint2hrstr): Last argument is now EMACS_INT.
11918
11919 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11920 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11921 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11922 (decode_coding_utf_16, decode_coding_emacs_mule)
11923 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11924 (decode_coding_ccl, decode_coding_charset)
11925 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11926 (decode_coding_iso_2022, decode_coding_emacs_mule)
11927 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11928 <char_offset, last_offset>: Declare EMACS_INT.
11929 (encode_coding_utf_8, encode_coding_utf_16)
11930 (encode_coding_emacs_mule, encode_invocation_designation)
11931 (encode_designation_at_bol, encode_coding_iso_2022)
11932 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11933 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11934 Declare EMACS_INT.
11935 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11936 (encode_invocation_designation): Last argument P_NCHARS is now
11937 EMACS_INT.
11938 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11939 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11940
11941 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11942 All users changed.
11943
11944 * ccl.c (Fccl_execute_on_string): Declare some variables
11945 EMACS_INT.
11946
8546720e 119472011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11948
11949 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11950
4e19a977
CS
119512011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11952
11953 * process.c (Fformat_network_address): Doc fix.
11954
87302331
R
119552011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11956
ee7683eb 11957 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11958
cbb59342
CY
119592011-04-08 Chong Yidong <cyd@stupidchicken.com>
11960
11961 * keyboard.c (read_char): Call Lisp function help-form-show,
11962 instead of using internal_with_output_to_temp_buffer.
11963 (Qhelp_form_show): New var.
e0d38eeb 11964 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11965
11966 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11967
11968 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11969
e67a13ab
CY
119702011-04-06 Chong Yidong <cyd@stupidchicken.com>
11971
04f2d78b
CB
11972 * process.c (Flist_processes): Remove to Lisp.
11973 (list_processes_1): Delete.
e67a13ab 11974
973f782d
EZ
119752011-04-06 Eli Zaretskii <eliz@gnu.org>
11976
7c106b1e
EZ
11977 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11978
973f782d
EZ
11979 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11980
41cf7d1a 119812011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11982
ca23cc88
PE
11983 Fix more problems found by GCC 4.6.0's static checks.
11984
f390e2d5
PE
11985 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11986
42eea0d0
PE
11987 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11988
b69769da 11989 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11990
f9541e84
PE
11991 * xdisp.c (vmessage): Mark as a printf-like function.
11992
13841b55
PE
11993 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11994
c136c10f
PE
11995 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11996
5e2d4a30
PE
11997 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11998 printf-like functions.
11999 (tiff_load): Add casts to remove these marks before passing them
12000 to system-supplied API.
12001
583f48b9
PE
12002 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12003
b25d760e
PE
12004 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12005 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12006 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12007 directly, rather than having caller test rule sign. This avoids
12008 some unnecessary tests.
12009 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12010 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12011 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12012
bc7b6697 12013 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12014 (xfont_open): Avoid unnecessary tests.
bc7b6697 12015
27ccc379
PE
12016 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12017
dcd5c89a
PE
12018 * composite.h, composite.c (composition_gstring_put_cache):
12019 Use EMACS_INT, not int, for length.
12020
b13a45c6
PE
12021 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12022 breaking out part of COMPOSITION_DECODE_RULE.
12023 (COMPOSITION_DECODE_RULE): Use it.
12024 * composite.c (get_composition_id): Remove unused local vars,
12025 by using the new macro.
12026
1e792e4d
PE
12027 * textprop.c (set_text_properties_1): Change while to do-while,
12028 since the condition is always true at first.
12029
dc6c6455 12030 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12031 (interval_deletion_adjustment): Return unsigned value.
12032 All uses changed.
dc6c6455 12033
aba7731a
PE
12034 * process.c (list_processes_1, create_pty, read_process_output):
12035 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12036 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12037 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12038 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12039 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12040
fdfc4bf3
PE
12041 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12042
fca8fe46 12043 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12044 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12045
06a0259a 12046 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12047 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12048 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12049
e7b9e80f
PE
12050 * print.c (print_error_message): Avoid int overflow.
12051
56201685
PE
12052 * font.c (font_list_entities): Redo for clarity,
12053 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12054
78834453 12055 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12056 (font_score): Avoid potential overflow in diff calculation.
78834453 12057
0bc0b309 12058 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12059 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12060
e610eaca
PE
12061 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12062
b895abce
PE
12063 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12064 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12065 can always succeed if overflow has undefined behavior.
12066
1f1d9321 12067 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12068 (wordify): Omit three unnecessary tests.
1f1d9321 12069
c59478bc
PE
12070 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12071 All callers changed. This avoids the need for an unused var.
12072
79b73827
PE
12073 * casefiddle.c (casify_region): Remove var that is set but not used.
12074
a4db5dfe
PE
12075 * dired.c (file_name_completion): Remove var that is set but not used.
12076
43aae36e
PE
12077 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12078
2a47c44d 12079 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12080 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12081
a37c69bf
PE
12082 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12083 Check for integer overflow on size calculations.
12084
328ab8e7
PE
12085 * buffer.c (Fprevious_overlay_change): Remove var that is set
12086 but not used.
12087
e5a2a5cb
PE
12088 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12089 Remove vars that are set but not used.
8d84a6eb 12090 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12091 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12092
a60e5f68
PE
12093 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12094
f661cb61 12095 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12096 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12097
f0397f5a
PE
12098 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12099 that are set but not used.
12100
8664db06 12101 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12102 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12103
6abdaa4a
PE
12104 * xselect.c (x_get_local_selection, x_handle_property_notify):
12105 Remove vars that are set but not used.
12106
0ce7538d 12107 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12108 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12109
9ae848fc
PE
12110 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12111 Remove var that is set but not used.
0b918413
PE
12112 (scroll_bar_windows_size): Now size_t, not int.
12113 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12114 Check for overflow.
9ae848fc 12115
a5a62657
PE
12116 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12117 (map_tty_color) [!defined MSDOS]: Likewise.
12118
5c5cdd39
PE
12119 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12120
66ebf983
PE
12121 * coding.c: Remove vars that are set but not used.
12122 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12123 All callers changed.
12124 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12125 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12126 (decode_coding_charset): Remove vars that are set but not used.
12127
1be4d761
PE
12128 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12129 that is set but not used.
12130
47553fa8
PE
12131 * print.c (print_object): Remove var that is set but not used.
12132
1f7196bf 12133 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12134 The gnulib version avoids calling malloc in the usual case,
12135 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12136 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12137 * filelock.c (current_lock_owner): Likewise.
12138 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12139 * sysdep.c: Include allocator.h, careadlinkat.h.
12140 (emacs_no_realloc_allocator): New static constant.
12141 (emacs_readlink): New function.
fdb61804
PE
12142 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12143 ../lib/careadlinkat.h.
d1fdcab7 12144
f84c17c7
SM
121452011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12146
12147 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12148 first non-nil return value).
12149
ef3862ad
JD
121502011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12151
12152 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12153 if not defined (Bug#8403).
12154
376a7006
JB
121552011-04-02 Juanma Barranquero <lekktu@gmail.com>
12156
12157 * xdisp.c (display_count_lines): Remove parameter `start',
12158 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12159 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12160 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12161 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12162 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12163 and thereabouts. All callers changed.
12164 (get_per_char_metric): Remove parameter `f', unused since
12165 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12166
6ca3801d
JM
121672011-04-02 Jim Meyering <meyering@redhat.com>
12168
12169 do not dereference NULL upon failed strdup
12170 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12171 (ns_get_family): Likewise.
12172
d8e2b5ba
JB
121732011-04-02 Juanma Barranquero <lekktu@gmail.com>
12174
12175 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12176
8c74fcbd
JD
121772011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12178
12179 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12180 later (Bug#8403).
12181
7200d79c
SM
121822011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12183
03408648 12184 Add lexical binding.
7200d79c 12185
03408648
SM
12186 * window.c (Ftemp_output_buffer_show): New fun.
12187 (Fsave_window_excursion):
12188 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12189
12190 * lread.c (lisp_file_lexically_bound_p): New function.
12191 (Fload): Bind Qlexical_binding.
12192 (readevalloop): Remove `evalfun' arg.
12193 Bind Qinternal_interpreter_environment.
12194 (Feval_buffer): Bind Qlexical_binding.
12195 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12196 Mark as dynamic.
12197 (syms_of_lread): Declare `lexical-binding'.
12198
12199 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12200
12201 * keyboard.c (eval_dyn): New fun.
12202 (menu_item_eval_property): Use it.
ca105506
SM
12203
12204 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 12205
03408648
SM
12206 * fns.c (concat, mapcar1): Accept byte-code-functions.
12207
12208 * eval.c (Fsetq): Handle lexical vars.
12209 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12210 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12211 (FletX, Flet): Obey lexical binding.
12212 (Fcommandp): Handle closures.
12213 (Feval): New `lexical' arg.
12214 (eval_sub): New function extracted from Feval. Use it almost
12215 everywhere where Feval was used. Look up vars in lexical env.
12216 Handle closures.
12217 (Ffunctionp): Move from subr.el.
12218 (Ffuncall): Handle closures.
12219 (apply_lambda): Remove `eval_flags'.
12220 (funcall_lambda): Handle closures and new byte-code-functions.
12221 (Fspecial_variable_p): New function.
12222 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12223 but without exporting it to Lisp.
23aba0ea 12224
23aba0ea 12225 * doc.c (Fdocumentation, store_function_docstring):
03408648 12226 * data.c (Finteractive_form): Handle closures.
23aba0ea 12227
03408648
SM
12228 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12229 interactive spec.
ba83908c 12230
04f2d78b
CB
12231 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12232 New byte-codes.
03408648
SM
12233 (exec_byte_code): New function extracted from Fbyte_code to handle new
12234 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 12235
03408648 12236 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 12237
03408648 12238 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 12239
e2abce01
JB
122402011-03-31 Juanma Barranquero <lekktu@gmail.com>
12241
12242 * xdisp.c (redisplay_internal): Fix prototype.
12243
63696a73 122442011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 12245
63696a73 12246 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
12247 (try_scrolling): Use it when setting scroll_limit.
12248 Limit scrolling to 100 screen lines.
63696a73
EZ
12249 (redisplay_window): Even when falling back on "recentering",
12250 position point in the window according to scroll-conservatively,
12251 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12252
12253 (try_scrolling): When point is above the window, allow searching
12254 as far as scroll_max, or one screenful, to compute vertical
12255 distance from PT to the scroll margin position. This prevents
12256 try_scrolling from unnecessarily failing when
12257 scroll-conservatively is set to a value slightly larger than the
12258 window height. Clean up the case of PT below the margin at bottom
12259 of window: scroll_max can no longer be INT_MAX. When aggressive
12260 scrolling is in use, don't let point enter the opposite scroll
12261 margin as result of the scroll.
12262 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12263 threshold of 100 lines for never-recentering scrolling.
12264
e4cc2dfc
JB
122652011-03-31 Juanma Barranquero <lekktu@gmail.com>
12266
12267 * dispextern.h (move_it_by_lines):
12268 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12269 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12270 (message_log_check_duplicate): Remove parameters `prev_bol' and
12271 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12272 (redisplay_internal): Remove parameter `preserve_echo_area',
12273 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12274
12275 * indent.c (Fvertical_motion):
12276 * window.c (window_scroll_pixel_based, Frecenter):
12277 Don't pass `need_y_p' to `move_it_by_lines'.
12278
1c470562
SM
122792011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12280
44f230aa
SM
12281 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12282 steal a few bits to be more compact.
12283 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12284 Remove unneeded casts.
12285
1c470562
SM
12286 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12287
888adce9
ZK
122882011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12289
12290 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12291 binding" message (bug#7967).
12292
f838ed7b
PE
122932011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12294
77861b95
PE
12295 Fix more problems found by GCC 4.6.0's static checks.
12296
de6dbc14
PE
12297 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12298 Remove unused local var.
12299
f838ed7b
PE
12300 * editfns.c (Fmessage_box): Remove unused local var.
12301
792c7b2b
PE
12302 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12303 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12304 Omit unused local vars.
c499e557 12305 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12306 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12307 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12308 Omit unused local var.
12309
ba0165e1
PE
12310 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12311 Don't assume string length fits in int.
32ad8845 12312 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12313 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12314
3c59b4c9
PE
12315 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12316 instead of alloca (Bug#8344).
12317
a3eed478 12318 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12319 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12320
eb4d412d
PE
12321 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12322
1658b401
PE
12323 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12324 concerns.
12325
12326 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12327
12328 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12329
9a2c6e05
PE
12330 * keyboard.c (syms_of_keyboard): Use the same style as later
12331 in this function when indexing through an array. This also
12332 works around GCC bug 48267.
12333
03d0a109
PE
12334 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12335
44f730c8
PE
12336 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12337
fe75f926
PE
12338 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12339 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12340
ffa8c828
PE
12341 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12342 This avoids undefined behavior on integer overflow, and is a bit
12343 more convenient anyway since it is compared to a size_t variable.
12344
c5101a77
PE
12345 Variadic C functions now count arguments with size_t, not int.
12346 This avoids an unnecessary limitation on 64-bit machines, which
12347 caused (substring ...) to crash on large vectors (Bug#8344).
12348 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12349 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12350 All variadic functions and their callers changed accordingly.
c5101a77
PE
12351 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12352 * data.c (arith_driver, float_arith_driver): Likewise.
12353 * editfns.c (general_insert_function): Likewise.
12354 * eval.c (struct backtrace.nargs, interactive_p)
12355 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12356 (funcall_lambda, mark_backtrace): Likewise.
12357 * fns.c (concat): Likewise.
12358 * frame.c (x_set_frame_parameters): Likewise.
12359 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12360 0 if not found, not -1. All callers changed.
12361
dd3f25f7
PE
12362 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12363 (stack_copy_size): Now size_t, not int.
12364 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12365
461c2ab9
JB
123662011-03-28 Juanma Barranquero <lekktu@gmail.com>
12367
12368 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12369 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12370 All callers changed.
12371
12372 * lisp.h (multibyte_char_to_unibyte):
12373 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12374 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12375 * character.h (CHAR_TO_BYTE8):
12376 * cmds.c (internal_self_insert):
12377 * editfns.c (general_insert_function):
12378 * keymap.c (push_key_description):
12379 * search.c (Freplace_match):
12380 * xdisp.c (message_dolog, set_message_1): All callers changed.
12381
f6d62986
SM
123822011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12383
12384 * keyboard.c (safe_run_hook_funcall): New function.
12385 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12386 don't set the hook to nil, but remove the offending function instead.
12387 (Qcommand_hook_internal): Remove, unused.
12388 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12389 Vcommand_hook_internal.
12390
12391 * eval.c (enum run_hooks_condition): Remove.
12392 (funcall_nil, funcall_not): New functions.
12393 (run_hook_with_args): Call each function through a `funcall' argument.
12394 Remove `cond' argument, now redundant.
12395 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12396 (Frun_hook_with_args_until_failure): Adjust accordingly.
12397 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12398
1db5b1ad
JB
123992011-03-28 Juanma Barranquero <lekktu@gmail.com>
12400
12401 * dispextern.h (string_buffer_position): Remove declaration.
12402
12403 * print.c (strout): Remove parameter `multibyte', unused since
12404 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12405
12406 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12407 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12408 All callers changed.
12409
12410 * w32.c (_wsa_errlist): Use braces for struct initializers.
12411
12412 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12413 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12414 All callers changed.
12415 (string_buffer_position): Likewise. Also, make static (it's never
12416 used outside xdisp.c).
12417 (cursor_row_p): Remove parameter `w', unused since
12418 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12419 (decode_mode_spec): Remove parameter `precision', introduced during
12420 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12421 All callers changed.
12422
5ffb62aa
JD
124232011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12424
12425 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12426
461c2ab9 124272011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12428
12429 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12430 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12431 (ns_update_auto_hide_menu_bar): New functions.
12432 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12433 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12434 ns_constrain_all_frames.
12435 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12436 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12437
5c380ffb
JD
124382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12439
12440 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12441
9af30bdf
GM
124422011-03-27 Glenn Morris <rgm@gnu.org>
12443
12444 * syssignal.h: Replace RETSIGTYPE with void.
12445 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12446 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12447 Replace SIGTYPE with void everywhere.
12448 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12449 * s/template.h (SIGTYPE): Remove commented out definition.
12450
e2abce01
JB
124512011-03-26 Eli Zaretskii <eliz@gnu.org>
12452
12453 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12454 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12455
f868cd8a
JB
124562011-03-26 Juanma Barranquero <lekktu@gmail.com>
12457
59eb0929
JB
12458 * w32.c (read_unc_volume): Use parameter `henum', instead of
12459 global variable `wget_enum_handle'.
12460
12461 * keymap.c (describe_vector): Remove parameters `indices' and
12462 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12463 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12464
f868cd8a
JB
12465 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12466
12467 * keyboard.c (timer_check): Remove parameter `do_it_now',
12468 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12469 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12470 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12471
12472 * keyboard.c (read_char):
12473 * w32menu.c (w32_menu_display_help):
12474 * xmenu.c (show_help_event, menu_help_callback):
12475 Adjust calls to `show_help_echo'.
12476
12477 * gtkutil.c (xg_maybe_add_timer):
12478 * keyboard.c (readable_events):
12479 * process.c (wait_reading_process_output):
12480 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12481
12482 * insdel.c (adjust_markers_gap_motion):
12483 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12484 (gap_left, gap_right): Don't call it.
12485
2ecf6fdb
CY
124862011-03-25 Chong Yidong <cyd@stupidchicken.com>
12487
12488 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12489 incurred during fontification.
12490
6b1f9ba4
JB
124912011-03-25 Juanma Barranquero <lekktu@gmail.com>
12492
12493 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12494 (DEFVAR_PER_BUFFER): Don't pass it.
12495
12496 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12497 (scrolling_window): Don't pass it.
12498
0f4a96b5
JB
124992011-03-25 Juanma Barranquero <lekktu@gmail.com>
12500
12501 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12502
12503 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12504 and `suffix'.
12505 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12506 of variables specific to SELinux and computation of `encoded_absname'.
12507
12508 * image.c (XPutPixel): Remove unused variable `height'.
12509
12510 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12511
12512 * unexw32.c (get_section_info): Remove unused variable `section'.
12513
12514 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12515 (system_process_attributes): Remove unused variable `sess'.
12516 (sys_read): Remove unused variable `err'.
12517
12518 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12519 (w32_wnd_proc): Remove unused variable `isdead'.
12520 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12521 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12522 (x_create_tip_frame): Remove unused variable `tem'.
12523
12524 * w32inevt.c (w32_console_read_socket):
12525 Remove unused variable `no_events'.
12526
12527 * w32term.c (x_draw_composite_glyph_string_foreground):
12528 Remove unused variable `width'.
12529
1149507c
JB
125302011-03-24 Juanma Barranquero <lekktu@gmail.com>
12531
12532 * w32term.c (x_set_glyph_string_clipping):
12533 Don't pass uninitialized region to CombineRgn.
12534
9c88f339
JB
125352011-03-23 Juanma Barranquero <lekktu@gmail.com>
12536
12537 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12538 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12539 (Fx_close_connection): Remove unused variable `i'.
12540
12541 * w32font.c (w32font_draw): Return number of glyphs.
12542 (w32font_open_internal): Remove unused variable `i'.
12543 (w32font_driver): Add missing initializer.
12544
12545 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12546 (fill_in_menu): Remove unused variable `items_added'.
12547
12548 * w32term.c (last_mouse_press_frame): Remove static global variable.
12549 (w32_clip_to_row): Remove unused variable `f'.
12550 (x_delete_terminal): Remove unused variable `i'.
12551
12552 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12553 (NOTHING): Remove unused static global variable.
12554 (uniscribe_check_otf): Remove unused variable `table'.
12555 (uniscribe_font_driver): Add missing initializers.
12556
dee091a3
JD
125572011-03-23 Julien Danjou <julien@danjou.info>
12558
12559 * term.c (Fsuspend_tty, Fresume_tty):
12560 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12561 * window.c (temp_output_buffer_show):
12562 * insdel.c (signal_before_change):
12563 * frame.c (Fhandle_switch_frame):
12564 * fileio.c (Fdo_auto_save):
12565 * emacs.c (Fkill_emacs):
12566 * editfns.c (save_excursion_restore):
12567 * cmds.c (internal_self_insert):
12568 * callint.c (Fcall_interactively):
12569 * buffer.c (Fkill_all_local_variables):
12570 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12571 Use Frun_hooks.
0f4a96b5 12572 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12573 unconditionally since it does the check itself.
dee091a3 12574
2c520ab5 125752011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12576
c9c49752
PE
12577 Fix more problems found by GCC 4.5.2's static checks.
12578
8abc3f12
PE
12579 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12580 the first time through the loop, since we know p0 < p1 then.
12581 This also avoids a gcc -Wstrict-overflow warning.
12582
a2d26660
PE
12583 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12584 leading to a memory leak, possible in functions like
12585 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12586 of objects (Bug#8318).
a2d26660 12587
916c72e9
PE
12588 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12589 that could (at least in theory) be that large.
12590
19ab8a18
PE
12591 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12592 This is less likely to overflow, and avoids undefined behavior if
12593 overflow does occur. All callers changed. Use strtoul to scan
12594 for the unsigned long integer.
b7cbbd6f
PE
12595 (pint2hrstr): Simplify and tune code slightly.
12596 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12597
f0641eff
PE
12598 * scroll.c (do_scrolling): Work around GCC bug 48228.
12599 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12600
7f650bb9
PE
12601 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12602 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12603 (validate_x_resource_name): Simplify count usage.
12604 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12605
37dd57d1
PE
12606 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12607 fail (Bug#8306).
81e56e61 12608
699979fc 12609 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12610
401bf9b4
PE
12611 * process.c (Fmake_network_process): Use socklen_t, not int,
12612 where POSIX says socklen_t is required in portable programs.
12613 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12614 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12615 (Fmake_network_process, server_accept_connection):
12616 (wait_reading_process_output, read_process_output):
12617 Likewise.
12618
b93aacde
PE
12619 * process.c: Rename or move locals to avoid shadowing.
12620 (list_processes_1, Fmake_network_process):
12621 (read_process_output_error_handler, exec_sentinel_error_handler):
12622 Rename or move locals.
4dc343ee 12623 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12624 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12625 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12626 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12627 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12628
af8a867c 12629 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12630 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12631 Include tparam.h instead, since it declares them.
af8a867c
PE
12632 * cm.h (PC): Remove extern decl; tparam.h now does this.
12633 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12634 * terminfo.c: Include tparam.h, to check interfaces.
12635 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12636 (tparam): Adjust signature to match interface in tparam.h;
12637 this removes some undefined behavior. Check that outstring and len
12638 are zero, which they always are with Emacs.
12639 * tparam.h (PC, BC, UP): New extern decls.
12640
0248044d 12641 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12642 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12643
8ff096c1 12644 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12645 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12646 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12647 (ftfont_list): Remove unused local.
49eaafba
PE
12648 (get_adstyle_property, ftfont_pattern_entity):
12649 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12650 Rename locals to avoid shadowing.
8ff096c1 12651
e2be39f6
PE
12652 * xfont.c (xfont_list_family): Mark var as initialized.
12653
c9735e30
PE
12654 * xml.c (make_dom): Now static.
12655
8f5201ae
PE
12656 * composite.c (composition_compute_stop_pos): Rename local to
12657 avoid shadowing.
b246f932
PE
12658 (composition_reseat_it): Remove unused locals.
12659 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12660 (composition_update_it): Mark var as initialized.
11b61122
PE
12661 (find_automatic_composition): Mark vars as initialized,
12662 with a FIXME (Bug#8290).
8f5201ae 12663
760fbc2c
PE
12664 character.h: Rename locals to avoid shadowing.
12665 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12666 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12667 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12668 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12669 to avoid shadowing.
12670
ff08eb85
PE
12671 * textprop.c (property_change_between_p): Remove; unused.
12672
fc7bf025
PE
12673 * intervals.c (interval_start_pos): Now static.
12674
235d7abc
PE
12675 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12676
44f230aa
SM
12677 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12678 Rename locals to avoid shadowing.
3e7d6594 12679
50060332
PE
12680 * sound.c (wav_play, au_play, Fplay_sound_internal):
12681 Fix pointer signedness.
d01f234b 12682 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12683 (wav_play): Initialize a variable to 0, to prevent undefined
12684 behavior (Bug#8278).
50060332 12685
c4fc4e30
PE
12686 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12687
918436ed
PE
12688 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12689
c939f91b
PE
12690 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12691 clobbering (Bug#8298).
b9c7f648
PE
12692 * sysdep.c (sys_subshell): Likewise.
12693 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12694
6bd8c144
PE
12695 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12696 This should get cleaned up, so that child_setup has the
12697 same signature on all platforms.
12698
7710357c 12699 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12700 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12701
c59da222
CY
127022011-03-22 Chong Yidong <cyd@stupidchicken.com>
12703
12704 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12705 not to be necessary, and produces flickering.
12706
66b87493
GM
127072011-03-20 Glenn Morris <rgm@gnu.org>
12708
12709 * config.in: Remove file.
12710
45b6f6d5
JB
127112011-03-20 Juanma Barranquero <lekktu@gmail.com>
12712
12713 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12714 are now in src/globals.h.
12715 (syms_of_minibuf): Remove spurious & from previous change.
12716
cd394be1 127172011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12718
12719 * minibuf.c (completing-read-function): New variable.
12720 (completing-read-default): Rename from completing-read.
12721 (completing-read): Call completing-read-function.
12722
b14e3e21
CY
127232011-03-19 Juanma Barranquero <lekktu@gmail.com>
12724
12725 * xfaces.c (Fx_load_color_file):
12726 Read color file from absolute filename (bug#8250).
12727
f2b726e6
JB
127282011-03-19 Juanma Barranquero <lekktu@gmail.com>
12729
12730 * makefile.w32-in: Update dependencies.
12731
09f6ff02
EZ
127322011-03-17 Eli Zaretskii <eliz@gnu.org>
12733
12734 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12735
29a6015a
PE
127362011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12737
a3a6c54e
PE
12738 Fix more problems found by GCC 4.5.2's static checks.
12739
b766f867
PE
12740 * process.c (make_serial_process_unwind, send_process_trap):
12741 (sigchld_handler): Now static.
12742
be02381c
PE
12743 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12744 That way, the code declares only the vars that it needs.
12745 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12746 * s/cygwin.h (PTY_ITERATION): Likewise.
12747 * s/darwin.h (PTY_ITERATION): Likewise.
12748 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12749
57048744
PE
12750 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12751 * process.c (allocate_pty): Don't declare stb unless it's needed.
12752
7914961c 12753 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12754 (CONSTANTLIM): Remove; unused.
12755 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12756 Define only if needed.
7914961c 12757
b3967b18
PE
12758 * unexelf.c (unexec): Name an expression,
12759 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12760 Use a different way to cause a compilation error if anyone uses
12761 n rather than nn, a way that does not involve shadowing.
73366a00 12762 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12763
29a6015a
PE
12764 * deps.mk (unexalpha.o): Remove; unused.
12765
43cfc33e 12766 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12767 * unexec.h: New file.
ce701a33
PE
12768 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12769 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12770 Depend on unexec.h.
12771 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12772 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12773 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12774 Change as necessary to match prototype in unexec.h.
ce701a33 12775
01f44d5a
PE
12776 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12777 shadowing.
4f63c6bb 12778 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12779
a6670b0b
PE
12780 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12781 Rename locals to avoid shadowing.
12782
cef2010d 12783 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12784 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12785
d4d7173a
PE
12786 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12787
f08b802a
PE
12788 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12789 warning when compiling print.c.
12790
3ddb0639
PE
12791 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12792 instead of using an uninitialized var.
5ad03b97 12793 (font_sort_entities): Mark var as initialized.
3ddb0639 12794
170a2692
PE
12795 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12796
e663c700
PE
12797 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12798 pointers to constants.
89bc529a 12799 (font_parse_fcname): Remove unused vars.
7b81e2d0 12800 (font_delete_unmatched): Now static.
ea838e10 12801 (font_get_spec): Remove; unused.
13a547c6
PE
12802 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12803 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12804 Rename or move locals to avoid shadowing.
e663c700 12805
2a80c887 12806 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12807 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12808
1384fa33 12809 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12810 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12811
8b2c52e9
PE
12812 * alloc.c (mark_backtrace): Move decl from here ...
12813 * lisp.h: ... to here, so that it can be checked.
12814
475545b5 12815 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12816 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12817 (lisp_indirect_variable): Name an expression,
12818 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12819 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12820
b1349114 12821 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12822 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12823 Use const pointer when appropriate.
b1349114 12824
a2928364
PE
12825 * lisp.h (get_system_name, get_operating_system_release):
12826 Move decls here, to check interfaces.
12827 * process.c (get_operating_system_release): Move decl to lisp.h.
12828 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12829 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12830 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12831 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12832 (Fformat_time_string, Fencode_time, Finsert_char):
12833 (Ftranslate_region_internal, Fformat):
12834 Rename or remove local vars to avoid shadowing.
9710023e 12835 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12836
a415e694
PE
12837 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12838 avoid shadowing.
12839
8ef4622d
PE
12840 * lisp.h (eassert): Check that the argument compiles, even if
12841 ENABLE_CHECKING is not defined.
12842
946f9a5b
PE
12843 * data.c (Findirect_variable): Name an expression, to avoid
12844 gcc -Wbad-function-cast warning.
112396d6 12845 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12846 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12847 (Fmake_variable_buffer_local, Fmake_local_variable):
12848 Mark variables as initialized.
52746918 12849 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12850
e5aab7e7 12851 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12852 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12853 Rename locals to avoid shadowing.
dff45157
PE
12854 (mark_stack): Move local variables into the #ifdef region where
12855 they're used.
7bc26fdb
PE
12856 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12857 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12858 needed otherwise.
12859 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12860 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12861 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12862
e5aab7e7
PE
12863 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12864 avoids undefined behavior in theory.
12865
4da60324
PE
12866 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12867
88043301
PE
12868 Use functions, not macros, for up- and down-casing (Bug#8254).
12869 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12870 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12871 to use the following functions instead of these macros.
12872 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12873 EMACS_INT, since callers assume the returned value fits in int.
12874 (upcase1): Likewise, for UPCASE_TABLE.
12875 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12876 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12877 the race-condition problem in the old DOWNCASE.
88043301 12878
19ed5445
PE
12879 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12880 Rename locals to avoid shadowing.
12881 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12882 (regex_compile, re_search_2, re_match_2_internal):
12883 Remove unused local vars.
952db0d7
PE
12884 (FREE_VAR): Rewrite so as not to use empty "else",
12885 which gcc can warn about.
da053e48 12886 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12887 (RETALLOC_IF): Define only if needed.
12888 (WORDCHAR_P): Likewise. This one is never needed, but is used
12889 only in a comment talking about a compiler bug, so put inside
12890 the #if 0 of that comment.
12891 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12892 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12893 Remove; unused.
19ed5445 12894
1f3561e4 12895 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12896 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12897 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12898
ded6f8f7
PE
12899 * search.c (simple_search): Remove unused var.
12900
dbd37a95
PE
12901 * dired.c (compile_pattern): Move decl from here ...
12902 * lisp.h: ... to here, so that it can be checked.
12903 (struct re_registers): New forward decl.
12904
7e47afad
PE
12905 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12906
85f24f61
PE
12907 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12908 All uses changed.
12909 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12910 Rename locals to avoid shadowing.
5671df8f 12911 (Fvertical_motion): Mark locals as initialized.
85f24f61 12912
181aa2be 12913 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12914 (casify_region): Mark local as initialized.
181aa2be 12915
930d429c
PE
12916 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12917
7082eac6
PE
12918 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12919 New macros, so that the caller can use some names other than
12920 gcpro1, gcpro2, etc.
12921 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12922 of the new macros.
12923 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12924 argument, for consistency with GCPRO2_VAR, etc: it is now the
12925 prefix of the variable, not the variable itself. All uses
12926 changed.
38b2c076
PE
12927 * dired.c (directory_files_internal, file_name_completion):
12928 Rename locals to avoid shadowing.
12929
15206ed9
PE
12930 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12931 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12932 dired.c's scmp function, had undefined behavior.
12933 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12934 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12935 * buffer.h: ... to here, because these macros use current_buffer,
12936 and the new implementation with inline functions needs to have
12937 current_buffer in scope now, rather than later when the macros
12938 are used.
12939 (downcase, upcase1): New static inline functions.
12940 (DOWNCASE, UPCASE1): Reimplement using these functions.
12941 This avoids undefined behavior in expressions like
12942 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12943 from race conditions in accessing the global variables
12944 case_temp1 and case_temp2.
12945 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12946 * lisp.h (case_temp1, case_temp2): Remove their decls.
12947 * character.h (ASCII_CHAR_P): Move from here ...
12948 * lisp.h: ... to here, so that the inline functions mentioned
12949 above can use them.
12950
4a6bea26
PE
12951 * dired.c (directory_files_internal_unwind): Now static.
12952
f14b7e14
PE
12953 * fileio.c (file_name_as_directory, directory_file_name):
12954 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12955 Now static.
2893f146
PE
12956 (file_name_as_directory): Use const pointers when appropriate.
12957 (Fexpand_file_name): Likewise. In particular, newdir might
12958 point at constant storage, so make it a const pointer.
fd4ead52 12959 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12960 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12961 signedness issues.
f839df0c
PE
12962 (Fset_file_times, Finsert_file_contents, auto_save_error):
12963 Rename locals to avoid shadowing.
f14b7e14 12964
5716756e 12965 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12966 (Ftry_completion, Fall_completions): Rename or remove locals
12967 to avoid shadowing.
5716756e 12968
b4c3046a
PE
12969 * marker.c (bytepos_to_charpos): Remove; unused.
12970
b45db522
PE
12971 * lisp.h (verify_bytepos, count_markers): New decls,
12972 so that gcc does not warn that these functions aren't declared.
12973
85876d07
PE
12974 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12975 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12976 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12977 (copy_text): Remove unused local var.
85876d07 12978
03d78a21 12979 * filelock.c (within_one_second): Now static.
b3dd38ab 12980 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12981
5df8f01b
PE
12982 * buffer.c (fix_overlays_before): Mark locals as initialized.
12983 (fix_start_end_in_overlays): Likewise. This function should be
12984 simplified by using pointers-to-pointers, but that's a different
12985 matter.
b1d876f1 12986 (switch_to_buffer_1): Now static.
8f54f30a
PE
12987 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12988 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12989
a70072c9 12990 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12991 Fix pointer signedness issue.
edced198
PE
12992 (sys_subshell): Mark local as volatile if checking for lint,
12993 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12994 (MAXPATHLEN): Define only if needed.
a70072c9 12995
a0977c44
PE
12996 * process.c (serial_open, serial_configure): Move decls from here ...
12997 * systty.h: ... to here, so that they can be checked.
12998
a884fdcc
PE
12999 * fns.c (get_random, seed_random): Move extern decls from here ...
13000 * lisp.h: ... to here, so that they can be checked.
13001
604efe86 13002 * sysdep.c (reset_io): Now static.
b8950c94 13003 (wait_for_termination_signal): Remove; unused.
604efe86 13004
38fc62d9
PE
13005 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13006 (copy_keymap_item, append_key, push_text_char_description):
13007 Now static.
1004a21a 13008 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13009 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13010 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13011 (describe_map_tree):
13012 Rename locals to avoid shadowing.
38fc62d9 13013
2f2650da
PE
13014 * keyboard.c: Declare functions static if they are not used elsewhere.
13015 (echo_char, echo_dash, cmd_error, top_level_2):
13016 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13017 (read_char, kbd_buffer_get_event, make_lispy_position):
13018 (make_lispy_event, make_lispy_movement, apply_modifiers):
13019 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13020 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13021 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13022 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13023 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13024
a053e86c 13025 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13026 (mark_kboards): Move decl here ...
13027 * alloc.c (mark_kboards): ... from here.
a053e86c 13028
4752793e
PE
13029 * lisp.h (force_auto_save_soon): New decl.
13030
74f10ca7 13031 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13032 (DEFINE_DUMMY_FUNCTION): New macro.
13033 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13034 Use it.
c03cd23f
PE
13035 (main): Add casts to avoid warnings
13036 if GCC considers string literals to be constants.
74f10ca7 13037
022e70d4
PE
13038 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13039
59d6fe83
PE
13040 * dbusbind.c: Pointer signedness fixes.
13041 (xd_signature, xd_append_arg, xd_initialize):
13042 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13043 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13044 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13045 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13046
78320123
PE
13047 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13048 if GCC considers string literals to be constants.
49cebcca 13049 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13050
35ac2a97
SM
130512011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13052
fb103ca9
SM
13053 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13054 (print_preprocess, print_object): New macro to fix last change.
13055
35ac2a97
SM
13056 * print.c (print_preprocess): Don't forget font objects.
13057
62973b41
JB
130582011-03-16 Juanma Barranquero <lekktu@gmail.com>
13059
13060 * emacs.c (USAGE3): Doc fixes.
13061
0e48bb22
AS
130622011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13063
13064 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13065 structure.
13066
7684e57b
JB
130672011-03-14 Juanma Barranquero <lekktu@gmail.com>
13068
13069 * lisp.h (VWindow_system, Qfile_name_history):
13070 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13071 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13072 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13073
13074 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13075 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13076
13077 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13078 * w32console.c (detect_input_pending, read_input_pending)
13079 (encode_terminal_code):
13080 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13081 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13082 (w32_system_caret_y, Qfile_name_history):
13083 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13084 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13085 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13086 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13087 * w32proc.c (Qlocal, report_file_error):
13088 * w32term.c (Vwindow_system, updating_frame):
13089 * w32uniscribe.c (initialized, uniscribe_font_driver):
13090 Remove unneeded extern declarations.
13091
2aa46d6c
CY
130922011-03-14 Chong Yidong <cyd@stupidchicken.com>
13093
c96bbc66 13094 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13095
cffc6f3b
CY
130962011-03-13 Chong Yidong <cyd@stupidchicken.com>
13097
13098 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13099 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13100 These macros can no longer be used for assignment.
13101
44f230aa
SM
13102 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13103 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13104 (record_buffer_markers, fetch_buffer_markers): New functions for
13105 recording and fetching special buffer markers.
13106 (set_buffer_internal_1, set_buffer_temp): Use them.
13107
13108 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13109
13110 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13111
13112 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13113 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13114
13115 * xdisp.c (hscroll_window_tree):
13116 (reconsider_clip_changes): Use PT instead of BUF_PT.
13117
d251f04b
EZ
131182011-03-13 Eli Zaretskii <eliz@gnu.org>
13119
13120 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13121 $(EMACS_ROOT)/lib/intprops.h.
13122
f0c77cd1
PE
131232011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13124
3eca4629
PE
13125 Fix more problems found by GCC 4.5.2's static checks.
13126
7c86ee98
PE
13127 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13128 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13129 (xg_free_frame_widgets): Make it clear that a local variable is
13130 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13131 (gdk_window_get_screen): Make it clear that this macro is needed
13132 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13133 (int_gtk_range_get_value): New function, which avoids a diagnostic
13134 from gcc -Wbad-function-cast.
13135 (xg_set_toolkit_scroll_bar_thumb): Use it.
13136 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13137 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13138 (get_utf8_string, xg_get_file_with_chooser):
13139 Rename locals to avoid shadowing.
13140 (create_dialog): Move locals to avoid shadowing.
7c86ee98 13141
41729b81
PE
13142 * xgselect.c (xg_select): Remove unused var.
13143
f0c77cd1
PE
13144 * image.c (four_corners_best): Mark locals as initialized.
13145 (gif_load): Initialize transparent_p to zero (Bug#8238).
13146 Mark another local as initialized.
ec6cf4c6 13147 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 13148
ce0ad53d 13149 * image.c (clear_image_cache): Now static.
d5d5a617 13150 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 13151 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
13152 (x_edge_detection): Remove unnecessary cast that
13153 gcc -Wbad-function-cast diagnoses.
2037898d 13154 (gif_load): Fix pointer signedness.
6ae141d6
PE
13155 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13156 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 13157
33383987 131582011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 13159
d32df629
PE
13160 Improve quality of tests for time stamp overflow.
13161 For example, without this patch (encode-time 0 0 0 1 1
13162 1152921504606846976) returns the obviously-bogus value (-948597
13163 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13164 reports time overflow. See
13165 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
13166 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13167 * editfns.c: Include limits.h and intprops.h.
13168 (TIME_T_MIN, TIME_T_MAX): New macros.
13169 (time_overflow): Move earlier, to before first use.
13170 (hi_time, lo_time): New functions, for an accurate test for
13171 out-of-range times.
13172 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13173 (Fget_internal_run_time): Don't assume time_t fits in int.
13174 (make_time): Use list2 instead of Fcons twice.
13175 (Fdecode_time): More accurate test for out-of-range times.
13176 (check_tm_member): New function.
13177 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
13178 (lisp_time_argument): Don't rely on undefined left-shift and
13179 right-shift behavior when checking for time stamp overflow.
8be6f318 13180
fe31d94c
PE
13181 * editfns.c (time_overflow): New function, refactoring common code.
13182 (Fformat_time_string, Fdecode_time, Fencode_time):
13183 (Fcurrent_time_string): Use it.
13184
8be6f318
PE
13185 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13186 * dired.c (make_time): Move to ...
13187 * editfns.c (make_time): ... here.
13188 * systime.h: Note the move.
13189
09d9db2c 131902011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 13191
126bc0dc
YM
13192 * fringe.c (update_window_fringes): Remove unused variables.
13193
c47cbdfd
YM
13194 * unexmacosx.c (copy_data_segment): Also copy __got section.
13195 (Bug#8223)
13196
7ac80be9
EZ
131972011-03-12 Eli Zaretskii <eliz@gnu.org>
13198
c96bbc66 13199 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
13200 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13201 Constify `char *' arguments and their references according to
13202 prototypes in tparam.h.
13203
ecb0f94d 13204 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 13205
7ac80be9
EZ
13206 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13207 Adapt all references accordingly.
13208
13209 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13210
ef1fd07e
TT
132112011-03-11 Tom Tromey <tromey@redhat.com>
13212
13213 * buffer.c (syms_of_buffer): Remove obsolete comment.
13214
7ef4b50c
EZ
132152011-03-11 Eli Zaretskii <eliz@gnu.org>
13216
13217 * termhooks.h (encode_terminal_code): Declare prototype.
13218
13219 * msdos.c (encode_terminal_code): Don't declare prototype.
13220
13221 * term.c (encode_terminal_code): Now external again, used by
13222 w32console.c and msdos.c.
13223
44f230aa
SM
13224 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13225 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 13226
4b1ec863 132272011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 13228
1714f52b 13229 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 13230
4b1ec863
PE
13231 * fringe.c (update_window_fringes): Mark locals as initialized
13232 (Bug#8227).
13233 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 13234
524c7aa6
PE
13235 * alloc.c (mark_fringe_data): Move decl from here ...
13236 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13237 to check its interface.
13238 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13239
a5c0af81 13240 * fontset.c (free_realized_fontset): Now static.
7519b8cd 13241 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 13242 (fontset_font): Mark local as initialized.
a9a06e0b 13243 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 13244
b4716021
PE
13245 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13246
811e9bac 13247 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 13248 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
13249 (x_own_selection, Fx_disown_selection_internal): Rename locals
13250 to avoid shadowing.
13251 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 13252
7e3ab302
PE
13253 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13254 so that the caller can use some name other than gcpro1.
13255 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13256 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13257 (Fx_backspace_delete_keys_p):
13258 Use them to avoid shadowing, and rename vars to avoid shadowing.
13259 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13260 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13261 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13262 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13263 Remove unused locals.
7e3ab302
PE
13264 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13265 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13266 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13267 macros.
f78faa98 13268
e2b13473
PE
13269 * xterm.h (x_mouse_leave): New decl.
13270
77f23912
PE
13271 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13272 Remove unused functions.
cdf4ba58
PE
13273 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13274 (x_calc_absolute_position): Now static.
7411c686 13275 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13276 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13277 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13278 unless they are used.
38d0b34a
PE
13279 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13280 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13281 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13282 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13283 (x_error_catcher, x_connection_closed, x_error_handler):
13284 (x_error_quitter, xembed_send_message, x_iconify_frame):
13285 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13286 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13287 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13288
44f230aa
SM
13289 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13290 Rename or move locals to avoid shadowing.
6b463e58 13291 (tty_defined_color, merge_face_heights): Now static.
5967d051 13292 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13293 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13294 does not deduce is never used uninitialized.
73719eba
PE
13295 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13296 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13297
426994c3 13298 * terminal.c (store_terminal_param): Now static.
5489860b 13299
032f1620 13300 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13301 (set_frame_menubar): Remove unused local.
d4323972 13302 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13303 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13304 since they might point to immutable storage.
281585b0
PE
13305 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13306 since it's unused otherwise.
032f1620 13307
367c19e5 13308 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13309 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13310 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13311 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13312 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13313 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13314 does not deduce are never used uninitialized.
70739cbe 13315
07b48fa9
PE
13316 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13317
8868a238 13318 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13319 * window.c (window_loop, size_window):
13320 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13321
7e5cf297 13322 * window.c (display_buffer): Now static.
d6550a9f
PE
13323 (size_window): Mark variables that gcc -Wuninitialized
13324 does not deduce are never used uninitialized.
a586633d
PE
13325 * window.h (check_all_windows): New decl, to forestall
13326 gcc -Wmissing-prototypes diagnostic.
5b555da1 13327 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13328
f6095868
PE
13329 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13330 shadowing.
13331 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13332 Include <limits.h>.
13333 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13334 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13335 (load_charset_map): Mark variables that gcc -Wuninitialized
13336 does not deduce are never used uninitialized.
53df7c11 13337 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13338
f38b440c
PE
13339 * coding.c (coding_set_source, coding_set_destination):
13340 Use "else { /* comment */ }" rather than "else /* comment */;"
13341 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13342 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13343 a block, when the outer 'i' will do.
13344 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13345 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13346 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13347 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13348 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13349 Rename locals to avoid shadowing.
13350 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13351 * coding.c (emacs_mule_char, encode_invocation_designation):
13352 Now static, since they're not used elsewhere.
413bb2db 13353 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13354 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13355 (decode_coding_emacs_mule): Mark variables that gcc
13356 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13357 (detect_coding_iso_2022): Initialize a local variable that might
13358 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13359 this initialization is needed. (Bug#8211)
5f58e762
PE
13360 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13361 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13362 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13363 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13364 Remove unused macros.
f38b440c 13365
232b38b9 13366 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13367 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13368 * character.c (string_count_byte8): Likewise.
232b38b9 13369
fb90da1b
PE
13370 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13371 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13372
fb93dbc2
PE
13373 * chartab.c (copy_sub_char_table): Now static, since it's not used
13374 elsewhere.
5c156ace
PE
13375 (sub_char_table_ref_and_range, char_table_ref_and_range):
13376 Rename locals to avoid shadowing.
bbcd0949 13377 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13378
7d3b3862 13379 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13380 (BIDI_BOB): Remove unused macro.
7d3b3862 13381
6be7d3da
PE
13382 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13383 deduce are never used uninitialized.
c2ed9c8b 13384 * term.c (encode_terminal_code): Likewise.
6be7d3da 13385
75f8807f 13386 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13387
50938595
PE
13388 * tparam.h: New file.
13389 * term.c, tparam.h: Include it.
13390 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13391 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13392 Move these decls to tparam.h, and make them agree with what
13393 is actually in tparam.c. The previous trick of using incompatible
13394 decls in different modules does not conform to the C standard.
13395 All callers of tparam changed to use tparam's actual API.
13396 * tparam.c (tparam1, tparam, tgoto):
13397 Use const pointers where appropriate.
13398
fbceeba2
PE
13399 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13400 * cm.h (struct cm): Likewise.
13401 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13402 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13403 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13404 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13405 (turn_on_face, init_tty): Likewise.
13406 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13407
7f3f1250
PE
13408 * term.c (term_mouse_position): Rename local to avoid shadowing.
13409
e6ca6543
PE
13410 * alloc.c (mark_ttys): Move decl from here ...
13411 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13412
c40f8d15
AS
134132011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13414
13415 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13416
cfe0661d
JB
134172011-03-09 Juanma Barranquero <lekktu@gmail.com>
13418
13419 * search.c (compile_pattern_1): Remove argument regp, unused since
13420 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13421 (compile_pattern): Don't pass it.
13422
0afb4571
J
134232011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13424
13425 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13426 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13427 for ! HAVE_GTK3.
13428 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13429
13430 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13431
13432 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13433 gdk_window_get_screen, gdk_window_get_geometry,
13434 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13435 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13436 (xg_get_pixbuf_from_pixmap): New function.
13437 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13438 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13439 Call xg_get_pixbuf_from_pixmap instead of
13440 gdk_pixbuf_get_from_drawable.
13441 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13442 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13443 (xg_check_special_colors): Use GtkStyleContext and its functions
13444 for HAVE_GTK3.
13445 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13446 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13447 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13448 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13449 Call gtk_widget_get_preferred_size.
0afb4571
J
13450 (xg_frame_resized): gdk_window_get_geometry only takes 5
13451 parameters.
44f230aa
SM
13452 (xg_win_to_widget, xg_event_is_for_menubar):
13453 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13454 (xg_set_widget_bg): New function.
13455 (delete_cb): New function.
895009e1 13456 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13457 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13458 (xg_set_background_color): Call xg_set_widget_bg.
13459 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13460 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13461 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13462 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13463 if ! HAVE_GTK3.
13464 (update_frame_tool_bar): Call gtk_widget_hide.
13465 (xg_initialize): Use GDK_KEY_g.
13466
13467 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13468 if ! HAVE_GTK3
13469 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13470
13471 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13472 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13473 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13474
1c2cc4ef
JB
134752011-03-08 Juanma Barranquero <lekktu@gmail.com>
13476
13477 * w32xfns.c (select_palette): Check success of RealizePalette against
13478 GDI_ERROR, not zero.
13479
33383987 13480See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13481
13482;; Local Variables:
13483;; coding: utf-8
aac0c6e3
MR
13484;; End:
13485
2f097256 13486 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13487
13488 This file is part of GNU Emacs.
13489
13490 GNU Emacs is free software: you can redistribute it and/or modify
13491 it under the terms of the GNU General Public License as published by
13492 the Free Software Foundation, either version 3 of the License, or
13493 (at your option) any later version.
13494
13495 GNU Emacs is distributed in the hope that it will be useful,
13496 but WITHOUT ANY WARRANTY; without even the implied warranty of
13497 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13498 GNU General Public License for more details.
13499
13500 You should have received a copy of the GNU General Public License
13501 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.