* xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
93ea6e8f
PE
12011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2
6f37259d
PE
3 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5
1683e3ab
PE
6 * xdisp.c (draw_row_with_mouse_face): Now static.
7 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8
de9c2632
PE
9 * window.h (check_all_windows): Mark externally visible.
10
2b96acb7
PE
11 * window.c (window_deletion_count): Now static.
12
13 * undo.c: Make symbols static if they're not exported.
14 (last_undo_buffer, last_boundary_position, pending_boundary):
15 Now static.
16
50436f33
PE
17 * textprop.c (interval_insert_behind_hooks): Now static.
18 (interval_insert_in_front_hooks): Likewise.
19
64520e5c
PE
20 * term.c: Make symbols static if they're not exported.
21 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
22 (max_frame_lines, tty_set_terminal_modes):
23 (tty_reset_terminal_modes, tty_turn_off_highlight):
24 (get_tty_terminal): Now static.
25 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
26 * termhooks.h (term_mouse_moveto): Do not declare if
27 HAVE_WINDOW_SYSTEMM.
28 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
29 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
30
1fa53021
PE
31 * sysdep.c: Make symbols static if they're not exported.
32 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
33 Now static.
34 (sigprocmask_set, full_mask): Remove; unused.
35 (wait_debugging): Mark as visible.
36 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
37 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
38
d4b43b22
PE
39 * syntax.c (syntax_temp): Define only if !__GNUC__.
40
b7c513d0
PE
41 * sound.c (current_sound_device, current_sound): Now static.
42
989b29ad
PE
43 * search.c (searchbufs, searchbuf_head): Now static.
44
13a55a78
PE
45 * scroll.c (scroll_cost): Remove; unused.
46 * dispextern.h (scroll_cost): Remove decl.
47
de68a1fc
PE
48 * region-cache.h (pp_cache): Mark as externally visible.
49
40ccffa6
PE
50 * process.c: Make symbols static if they're not exported.
51 (process_tick, update_tick, create_process, chan_process):
52 (Vprocess_alist, proc_buffered_char, datagram_access):
53 (fd_callback_data, send_process_frame, process_sent_to): Now static.
54 (deactivate_process): Mark defn as static, as well as decl.
55 * lisp.h (create_process): Remove decl.
56 * process.h (chan_process, Vprocess_alist): Remove decls.
57
ad64fc97
PE
58 * print.c: Make symbols static if they're not exported.
59 (print_depth, new_backquote_output, being_printed, print_buffer):
60 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
61 (print_interval, print_number_index, initial_stderr_stream):
62 Now static.
63 * lisp.h (Fprinc): Remove decl.
64 (debug_output_compilation_hack): Mark as externally visible.
65
adddb265
PE
66 * sysdep.c (croak): Move decl from here to syssignal.h.
67 * syssignal.h (croak): Put it here, so the API can be checked when
68 'croak' is called from dissociate_if_controlling_tty.
69
1717ede2
PE
70 * minibuf.c: Make symbols static if they're not exported.
71 (minibuf_save_list, choose_minibuf_frame): Now static.
72 * lisp.h (choose_minibuf_frame): Remove decl.
73
fa5fb2bc
PE
74 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
75
1e3890d1
PE
76 * lread.c: Make symbols static if they're not exported.
77 (read_objects, initial_obarray, oblookup_last_bucket_number):
78 Now static.
79 (make_symbol): Remove; unused.
80 * lisp.h (initial_obarray, make_symbol): Remove decls.
81
8a1414fa
PE
82 * keyboard.c: Make symbols static if they're not exported.
83 (single_kboard, recent_keys_index, total_keys, recent_keys):
84 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
85 (this_single_command_key_start, echoing, last_auto_save):
86 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
87 (command_loop, echo_now, keyboard_init_hook, help_char_p):
88 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
89 (Vlispy_mouse_stem, double_click_count):
90 Now static.
91 (force_auto_save_soon): Define only if SIGDANGER.
92 (ignore_mouse_drag_p): Now static if
93 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
94 (print_help): Remove; unused.
95 (stop_character, last_timer_event): Mark as externally visible.
96 * keyboard.h (ignore_mouse_drag_p): Declare only if
97 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
98 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
99 * lisp.h (echoing): Remove decl.
100 (force_auto_save_soon): Declare only if SIGDANGER.
101 * xdisp.c (redisplay_window): Simplify code, to make it more
102 obvious that ignore_mouse_drag_p is not accessed if !defined
103 USE_GTK && !defined HAVE_NS.
104
93ea6e8f
PE
105 * intervals.c: Make symbols static if they're not exported.
106 (merge_properties_sticky, merge_interval_right, delete_interval):
107 Now static.
108 * intervals.h (merge_interval_right, delete_interval): Remove decls.
109
b532497d
PE
1102011-04-13 Paul Eggert <eggert@cs.ucla.edu>
111
77382fcc
PE
112 * insdel.c: Make symbols static if they're not exported.
113 However, leave prepare_to_modify_buffer alone. It's never
114 called from outside this function, but that appears to be a bug.
115 (combine_after_change_list, combine_after_change_buffer):
4889fc82 116 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
117 (adjust_after_replace_noundo): Remove; unused.
118 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 119 (signal_before_change): Remove decls.
77382fcc 120
9306c32e
PE
121 * indent.c (val_compute_motion, val_vmotion): Now static.
122
cd44d2eb
PE
123 * image.c: Make symbols static if they're not exported.
124 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
125 if USE_GTK.
126 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
127 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
128
ad9a7a06
PE
129 * fringe.c (standard_bitmaps): Now static.
130 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
131
81626931
PE
132 * frame.c: Make symbols static if they're not exported.
133 (x_report_frame_params, make_terminal_frame): Now static.
134 (get_frame_param): Now static, unless HAVE_NS.
135 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
136 (x_get_resource_string): Remove; not used.
137 * frame.h (make_terminal_frame, x_report_frame_params):
138 (x_get_resource_string); Remove decls.
139 (x_fullscreen_adjust): Declare only if WINDOWSNT.
140 * lisp.h (get_frame_param): Declare only if HAVE_NS.
141
239f9db9
PE
142 * font.c, fontset.c: Make symbols static if they're not exported.
143 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
144 (FACE_SUITABLE_FOR_CHAR_P): Use it.
145 * font.c (font_close_object): Now static.
146 * font.h (font_close_object): Remove.
147 * fontset.c (FONTSET_OBJLIST): Remove.
148 (free_realized_fontset) #if-0 the body, which does nothing.
149 (face_suitable_for_char_p): #if-0, as it's never called.
150 * fontset.h (face_suitable_for_char_p): Remove decl.
151 * xfaces.c (face_at_string_position): Use
152 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
153 since 0 is always ASCII.
154
dfcf3579
PE
155 * fns.c (weak_hash_tables): Now static.
156
5045092b
PE
157 * fileio.c: Make symbols static if they're not exported.
158 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
159 (Vwrite_region_annotation_buffers): Now static.
160
57a96f5c
PE
161 * eval.c: Make symbols static if they're not exported.
162 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
163 * lisp.h (backtrace_list): Remove decl.
164
35f08c38
PE
165 * emacs.c: Make symbols static if they're not exported.
166 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
167 (fatal_error_code, fatal_error_signal_hook, standard_args):
168 Now static.
169 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
170 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
171 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
172 * lisp.h (fatal_error_signal_hook): Remove decl.
173 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
174
f44bd759
PE
175 * editfns.c: Move a (normally-unused) function to its only use.
176 * editfns.c, lisp.h (get_operating_system_release): Remove.
177 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
178 worth the hassle of breaking this out.
179
b532497d
PE
180 * xterm.c: Make symbols static if they're not exported.
181 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
182 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
183 (x_destroy_window, x_delete_display):
184 Now static.
185 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
186 (x_mouse_leave): Remove; unused.
187 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
188 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
189 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
190 Remove decls.
191 (x_mouse_leave): Declare only if WINDOWSNT.
192 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
193 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
194 USE_X_TOOLKIT.
195
a25f4dfa
PE
1962011-04-12 Paul Eggert <eggert@cs.ucla.edu>
197
1675728f
PE
198 * ftxfont.c: Make symbols static if they're not exported.
199 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
200 HAVE_FREETYPE.
201 * font.h (ftxfont_driver): Likewise.
202
e4cebfca
PE
203 * xfns.c: Make symbols static if they're not exported.
204 (x_last_font_name, x_display_info_for_name):
205 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
206 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
207 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
208 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
209 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
210 (last_show_tip_args): Now static.
211 (xic_defaut_fontset, xic_create_fontsetname): Define only if
212 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
213 (x_screen_planes): Remove; unused.
214 * dispextern.h (x_screen_planes): Remove decl.
215
5bf46f05
PE
216 * dispnew.c: Make symbols static if they're not exported.
217 * dispextern.h (redraw_garbaged_frames, scrolling):
218 (increment_row_positions): Remove.
219 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
220 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
221 Now static.
222 (redraw_garbaged_frames): Remove; unused.
223
435f4c28
PE
224 * xfaces.c: Make symbols static if they're not exported.
225 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
226 Remove decls.
227 * xterm.h (defined_color): Remove decls.
228 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
229 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
230 (menu_face_changed_default, defined_color, free_realized_face):
231 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
232 (ascii_face_of_lisp_face): Remove; unused.
233
8524aef3
PE
234 * xdisp.c: Make symbols static if they're not exported.
235 * dispextern.h (scratch_glyph_row, window_box_edges):
236 (glyph_to_pixel_coords, set_cursor_from_row):
237 (get_next_display_element, set_iterator_to_next):
238 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
239 (show_mouse_face): Remove decls
240 * frame.h (message_buf_print): Likewise.
241 * lisp.h (pop_message, set_message, check_point_in_composition):
242 Likewise.
243 * xterm.h (set_vertical_scroll_bar): Likewise.
244 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
245 (message_buf_print, scratch_glyph_row, displayed_buffer):
246 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
247 (get_next_display_element, show_mouse_face, window_box_edges):
248 (frame_to_window_pixel_xy, check_point_in_composition):
249 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
250 (glyph_to_pixel_coords): Remove; unused.
251
16390cd2
PE
252 * dired.c (file_name_completion): Now static.
253
254 * dbusbind.c (xd_in_read_queued_messages): Now static.
255
a25f4dfa
PE
256 * lisp.h (circular_list_error, FOREACH): Remove; unused.
257 * data.c (circular_list_error): Remove.
258
16a97296
PE
2592011-04-11 Paul Eggert <eggert@cs.ucla.edu>
260
14a9c8df
PE
261 * commands.h (last_point_position, last_point_position_buffer):
262 (last_point_position_window): Remove decls.
263 * keyboard.c: Make these variables static.
264
74ab6df5
PE
265 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
266 decls.
267 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
268 (iso_code_class, detect_coding, code_convert_region): Now static.
269 (encode_coding_gap): Remove; unused.
270
38dfbee1
PE
271 * chartab.c (chartab_chars, chartab_bits): Now static.
272
a2cb4e63
PE
273 * charset.h (charset_iso_8859_1): Remove decl.
274 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
275 Now static.
276
127198fd
PE
277 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
278 * ccl.c (Vccl_program_table): Now static.
279 (check_ccl_update): Remove; unused.
280
d85b608f
PE
281 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
282 * category.h: ... from here.
283 * category.c (check_category_table, set_category_set): Now static.
284
31cd66f3
PE
285 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
286 * lisp.h: Remove these decls.
287
c358e587
PE
288 * buffer.c (buffer_count): Remove unused var.
289
e78aecca
PE
290 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
291 so that it's not optimized away.
292 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
293 * dispextern.h (bidi_dump_cached_states): Remove, since it's
294 exported only to the debugger.
295
e192d7d3
PE
296 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
297 * atimer.h (run_all_atimers): Removed; not exported.
298
92470028
PE
299 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
300 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
301 was inaccessible from Lisp.
302 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
303 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
304
244ed907
PE
305 alloc.c: Import and export fewer symbols, and remove unused items.
306 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
307 is defined.
308 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
309 it's not optimized away by whole-program optimization.
310 (message_enable_multibyte, free_misc): Remove.
311 (catchlist, handlerlist, mark_backtrace):
312 Declare only if BYTE_MARK_STACK.
313 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
314 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
315 (message_enable_multibyte): Remove decl.
316 (free_misc, interval_free_list, float_block, float_block_index):
317 (n_float_blocks, float_free_list, cons_block, cons_block_index):
318 (cons_free_list, last_marked_index):
319 Now static.
320 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
321 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
322 (mark_backtrace): Define only if BYTE_MARK_STACK.
323 * xdisp.c (message_enable_multibyte): Now static.
324
955cbe7b
PE
325 Declare Lisp_Object Q* variables to be 'static' if not exproted.
326 This makes it easier for human readers (and static analyzers)
327 to see whether these variables are used from other modules.
328 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
329 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
330 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
331 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
332 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
333 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
334 * xmenu.c, xselect.c:
335 Declare Q* vars static if they are not used in other modules.
336 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
337 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
338 Remove decls of unexported vars.
339 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
340
95c82688
PE
341 * lisp.h (DEFINE_FUNC): Make sname 'static'.
342
16a97296
PE
343 Make Emacs functions such as Fatom 'static' by default.
344 This makes it easier for human readers (and static analyzers)
345 to see whether these functions can be called from other modules.
346 DEFUN now defines a static function. To make the function external
347 so that it can be used in other C modules, use the new macro DEFUE.
348 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
349 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
350 static function definition. Use DEFUE if you want an extern one.
351 (DEFUE, INFUN): New macros.
352 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
353 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
354 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
355 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
356 Remove decls, since these functions are now static.
357 (Funintern, Fget_internal_run_time): New decls, since these functions
358 were already external.
95c82688 359
16a97296
PE
360 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
361 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
362 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
363 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
364 * keyboard.c, keymap.c, lread.c:
365 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
366 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
367 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
368 Mark functions with DEFUE instead of DEFUN,
369 if they are used in other modules.
370 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
371 decls for now-static functions.
372 * buffer.h (Fdelete_overlay): Remove decl.
373 * callproc.c (Fgetenv_internal): Mark as internal.
374 * composite.c (Fremove_list_of_text_properties): Remove decl.
375 (Fcomposition_get_gstring): New forward static decl.
376 * composite.h (Fcomposite_get_gstring): Remove decl.
377 * dired.c (Ffile_attributes): New forward static decl.
378 * doc.c (Fdocumntation_property): New forward static decl.
379 * eval.c (Ffetch_bytecode): New forward static decl.
380 (Funintern): Remove extern decl; now in .h file where it belongs.
381 * fileio.c (Fmake_symbolic_link): New forward static decl.
382 * image.c (Finit_image_library): New forward static decl.
383 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
384 * intervals.h (Fprevious_property_change):
385 (Fremove_list_of_text_properties): Remove decls.
386 * keyboard.c (Fthis_command_keys): Remove decl.
387 (Fcommand_execute): New forward static decl.
388 * keymap.c (Flookup_key): New forward static decl.
389 (Fcopy_keymap): Now static.
390 * keymap.h (Flookup_key): Remove decl.
391 * process.c (Fget_process): New forward static decl.
392 (Fprocess_datagram_address): Mark as internal.
393 * syntax.c (Fsyntax_table_p): New forward static decl.
394 (skip_chars): Remove duplicate decl.
395 * textprop.c (Fprevious_property_change): New forward static decl.
396 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
397 Now internal.
398 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
399 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
400
785bbd42
PE
4012011-04-10 Paul Eggert <eggert@cs.ucla.edu>
402
403 * editfns.c (Fformat): Remove unreachable code.
404
4073e537 4052011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 406
b2ded58d
PE
407 Fix more problems found by GCC 4.6.0's static checks.
408
7d66342c
PE
409 * xdisp.c (vmessage): Use a better test for character truncation.
410
bbf47d44
PE
411 * charset.c (load_charset_map): <, not <=, for optimization,
412 and to avoid potential problems with integer overflow.
9248994d 413 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 414 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 415 * editfns.c (Fformat): Likewise.
1e69125e 416 * syntax.c (skip_chars): Likewise.
3befa583 417
e3019616
PE
418 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
419 This also lets GCC 4.6.0 generate slightly better loop code.
420
becfa255
PE
421 * callint.c (Fcall_interactively): <, not <=, for optimization.
422 (Fcall_interactively): Count the number of arguments produced,
423 not the number of arguments given. This is simpler and lets GCC
424 4.6.0 generate slightly better code.
425
dae0cd48
PE
426 * ftfont.c: Distingish more carefully between FcChar8 and char.
427 The previous code passed unsigned char * to a functions like
428 strlen and xstrcasecmp that expect char *, which does not
429 conform to the C standard.
430 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
431 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
432 char * when the C standard requires it.
433
76032d70
PE
434 * keyboard.c (read_char): Remove unused var.
435
eb3f1cc8
PE
436 * eval.c: Port to Windows vsnprintf (Bug#8435).
437 Include <limits.h>.
438 (SIZE_MAX): Define if the headers do not.
439 (verror): Do not give up if vsnprintf returns a negative count.
440 Instead, grow the buffer. This ports to Windows vsnprintf, which
441 does not conform to C99. Problem reported by Eli Zaretskii.
442 Also, simplify the allocation scheme, by avoiding the need for
443 calling realloc, and removing the ALLOCATED variable.
444
70476b54
PE
445 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
446
12020a9e
PE
447 Remove invocations of doprnt, as Emacs now uses vsnprintf.
448 But keep the doprint source code for now, as we might revamp it
449 and use it again (Bug#8435).
ea6c7ae6
PE
450 * lisp.h (doprnt): Remove.
451 * Makefile.in (base_obj): Remove doprnt.o.
452 * deps.mk (doprnt.o): Remove.
453
5fdb398c
PE
454 error: Print 32- and 64-bit integers portably (Bug#8435).
455 Without this change, on typical 64-bit hosts error ("...%d...", N)
456 was used to print both 32- and 64-bit integers N, which relied on
457 undefined behavior.
458 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
459 New macro.
460 * lisp.h (error, verror): Mark as printf-like functions.
461 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
462 Report overflow in size calculations when allocating printf buffer.
463 Do not truncate output string at its first null byte.
464 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
465 Truncate the output at a character boundary, since vsnprintf does not
466 do that.
467 * charset.c (check_iso_charset_parameter): Convert internal
468 character to string before calling 'error', since %c now has the
469 printf meaning.
470 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
471 overflow when computing char to be passed to 'error'. Do not
472 pass Lisp_Object to 'error'; pass the integer instead.
473 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
474 formatted with plain %d.
475
b189fa66
PE
476 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
477
bff87ef0
PE
478 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
479
7e2cac20
PE
480 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
481
ce4d90b5
PE
482 * xterm.c (x_catch_errors): Remove duplicate declaration.
483
266c9547
PE
484 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
485
79c49ad2
PE
486 * xdisp.c, lisp.h (message_nolog): Remove; unused.
487
368f4090
JM
4882011-04-10 Jim Meyering <meyering@redhat.com>
489
490 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
491 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
492 return ssize_t not "int", and use size_t as the buffer length.
493 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
494 * gnutls.h: Update declarations.
495 * process.c (read_process_output): Use ssize_t, to match.
496 (send_process): Likewise.
497
a32d4040
CY
4982011-04-09 Chong Yidong <cyd@stupidchicken.com>
499
500 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
501
8546720e 5022011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 503
8546720e
GM
504 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
505 unsigned char, to match FcChar8 type definition.
aac0c6e3 506
8546720e
GM
507 * xterm.c (handle_one_xevent):
508 * xmenu.c (create_and_show_popup_menu):
509 * xselect.c (x_decline_selection_request)
510 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 511
a53e2e89
EZ
5122011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
513
514 Fix some uses of `int' instead of EMACS_INT.
515 * search.c (string_match_1, fast_string_match)
516 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
517 (scan_buffer, find_next_newline_no_quit)
518 (find_before_next_newline, search_command, Freplace_match)
519 (Fmatch_data): Make some `int' variables be EMACS_INT.
520
521 * xdisp.c (display_count_lines): 3rd argument and return value now
522 EMACS_INT. All callers changed.
523 (pint2hrstr): Last argument is now EMACS_INT.
524
525 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
526 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
527 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
528 (decode_coding_utf_16, decode_coding_emacs_mule)
529 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
530 (decode_coding_ccl, decode_coding_charset)
531 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
532 (decode_coding_iso_2022, decode_coding_emacs_mule)
533 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
534 <char_offset, last_offset>: Declare EMACS_INT.
535 (encode_coding_utf_8, encode_coding_utf_16)
536 (encode_coding_emacs_mule, encode_invocation_designation)
537 (encode_designation_at_bol, encode_coding_iso_2022)
538 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
539 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
540 Declare EMACS_INT.
541 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
542 (encode_invocation_designation): Last argument P_NCHARS is now
543 EMACS_INT.
544 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
545 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
546
547 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
548 All users changed.
549
550 * ccl.c (Fccl_execute_on_string): Declare some variables
551 EMACS_INT.
552
8546720e 5532011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
554
555 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
556
4e19a977
CS
5572011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
558
559 * process.c (Fformat_network_address): Doc fix.
560
87302331
R
5612011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
562
563 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
564
cbb59342
CY
5652011-04-08 Chong Yidong <cyd@stupidchicken.com>
566
567 * keyboard.c (read_char): Call Lisp function help-form-show,
568 instead of using internal_with_output_to_temp_buffer.
569 (Qhelp_form_show): New var.
e0d38eeb 570 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
571
572 * print.c (internal_with_output_to_temp_buffer): Function deleted.
573
574 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
575
e67a13ab
CY
5762011-04-06 Chong Yidong <cyd@stupidchicken.com>
577
578 * process.c (Flist_processes): Removed to Lisp.
579 (list_processes_1): Deleted.
580
973f782d
EZ
5812011-04-06 Eli Zaretskii <eliz@gnu.org>
582
7c106b1e
EZ
583 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
584
973f782d
EZ
585 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
586
41cf7d1a 5872011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 588
ca23cc88
PE
589 Fix more problems found by GCC 4.6.0's static checks.
590
f390e2d5
PE
591 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
592
42eea0d0
PE
593 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
594
b69769da 595 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 596
f9541e84
PE
597 * xdisp.c (vmessage): Mark as a printf-like function.
598
13841b55
PE
599 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
600
c136c10f
PE
601 * sound.c (sound_warning): Don't crash if arg contains a printf format.
602
5e2d4a30
PE
603 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
604 printf-like functions.
605 (tiff_load): Add casts to remove these marks before passing them
606 to system-supplied API.
607
583f48b9
PE
608 * eval.c (Fsignal): Remove excess argument to 'fatal'.
609
b25d760e
PE
610 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
611 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
612 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
613 directly, rather than having caller test rule sign. This avoids
614 some unnecessary tests.
615 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
616 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
617 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 618
bc7b6697 619 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 620 (xfont_open): Avoid unnecessary tests.
bc7b6697 621
27ccc379
PE
622 * composite.c (composition_gstring_put_cache): Use unsigned integer.
623
dcd5c89a
PE
624 * composite.h, composite.c (composition_gstring_put_cache):
625 Use EMACS_INT, not int, for length.
626
b13a45c6
PE
627 * composite.h (COMPOSITION_DECODE_REFS): New macro,
628 breaking out part of COMPOSITION_DECODE_RULE.
629 (COMPOSITION_DECODE_RULE): Use it.
630 * composite.c (get_composition_id): Remove unused local vars,
631 by using the new macro.
632
1e792e4d
PE
633 * textprop.c (set_text_properties_1): Change while to do-while,
634 since the condition is always true at first.
635
dc6c6455 636 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
637 (interval_deletion_adjustment): Return unsigned value.
638 All uses changed.
dc6c6455 639
aba7731a
PE
640 * process.c (list_processes_1, create_pty, read_process_output):
641 (exec_sentinel): Remove vars that were set but not used.
afd4052b 642 (create_pty): Remove unnecessary "volatile"s.
bc57d757 643 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 644 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 645 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 646
fdfc4bf3
PE
647 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
648
fca8fe46 649 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 650 (update_syntax_table): Use unsigned instead of int.
fca8fe46 651
06a0259a 652 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 653 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 654 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 655
e7b9e80f
PE
656 * print.c (print_error_message): Avoid int overflow.
657
56201685
PE
658 * font.c (font_list_entities): Redo for clarity,
659 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
660
78834453 661 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 662 (font_score): Avoid potential overflow in diff calculation.
78834453 663
0bc0b309 664 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 665 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 666
e610eaca
PE
667 * eval.c (funcall_lambda): Rename local to avoid shadowing.
668
b895abce
PE
669 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
670 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
671 can always succeed if overflow has undefined behavior.
672
1f1d9321 673 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 674 (wordify): Omit three unnecessary tests.
1f1d9321 675
c59478bc
PE
676 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
677 All callers changed. This avoids the need for an unused var.
678
79b73827
PE
679 * casefiddle.c (casify_region): Remove var that is set but not used.
680
a4db5dfe
PE
681 * dired.c (file_name_completion): Remove var that is set but not used.
682
43aae36e
PE
683 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
684
2a47c44d 685 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 686 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 687
a37c69bf
PE
688 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
689 Check for integer overflow on size calculations.
690
328ab8e7
PE
691 * buffer.c (Fprevious_overlay_change): Remove var that is set
692 but not used.
693
e5a2a5cb
PE
694 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
695 Remove vars that are set but not used.
8d84a6eb 696 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 697 (timer_check_2): Mark vars as initialized.
e5a2a5cb 698
a60e5f68
PE
699 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
700
f661cb61 701 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 702 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 703
f0397f5a
PE
704 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
705 that are set but not used.
706
8664db06 707 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 708 if XCreateBitmapFromData fails (Bug#8410).
8664db06 709
6abdaa4a
PE
710 * xselect.c (x_get_local_selection, x_handle_property_notify):
711 Remove vars that are set but not used.
712
0ce7538d 713 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 714 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 715
9ae848fc
PE
716 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
717 Remove var that is set but not used.
0b918413
PE
718 (scroll_bar_windows_size): Now size_t, not int.
719 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
720 Check for overflow.
9ae848fc 721
a5a62657
PE
722 * xfaces.c (realize_named_face): Remove vars that are set but not used.
723 (map_tty_color) [!defined MSDOS]: Likewise.
724
5c5cdd39
PE
725 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
726
66ebf983
PE
727 * coding.c: Remove vars that are set but not used.
728 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
729 All callers changed.
730 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
731 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
732 (decode_coding_charset): Remove vars that are set but not used.
733
1be4d761
PE
734 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
735 that is set but not used.
736
47553fa8
PE
737 * print.c (print_object): Remove var that is set but not used.
738
1f7196bf 739 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
740 The gnulib version avoids calling malloc in the usual case,
741 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
742 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
743 * filelock.c (current_lock_owner): Likewise.
744 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
745 * sysdep.c: Include allocator.h, careadlinkat.h.
746 (emacs_no_realloc_allocator): New static constant.
747 (emacs_readlink): New function.
fdb61804
PE
748 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
749 ../lib/careadlinkat.h.
d1fdcab7 750
f84c17c7
SM
7512011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
752
753 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
754 first non-nil return value).
755
ef3862ad
JD
7562011-04-03 Jan Djärv <jan.h.d@swipnet.se>
757
758 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
759 if not defined (Bug#8403).
760
376a7006
JB
7612011-04-02 Juanma Barranquero <lekktu@gmail.com>
762
763 * xdisp.c (display_count_lines): Remove parameter `start',
764 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
765 (get_char_face_and_encoding): Remove parameter `multibyte_p',
766 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
767 (fill_stretch_glyph_string): Remove parameters `row' and `area',
768 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
769 and thereabouts. All callers changed.
770 (get_per_char_metric): Remove parameter `f', unused since
771 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
772
6ca3801d
JM
7732011-04-02 Jim Meyering <meyering@redhat.com>
774
775 do not dereference NULL upon failed strdup
776 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
777 (ns_get_family): Likewise.
778
d8e2b5ba
JB
7792011-04-02 Juanma Barranquero <lekktu@gmail.com>
780
781 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
782
8c74fcbd
JD
7832011-04-02 Jan Djärv <jan.h.d@swipnet.se>
784
785 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
786 later (Bug#8403).
787
7200d79c
SM
7882011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
789
03408648 790 Add lexical binding.
7200d79c 791
03408648
SM
792 * window.c (Ftemp_output_buffer_show): New fun.
793 (Fsave_window_excursion):
794 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
795
796 * lread.c (lisp_file_lexically_bound_p): New function.
797 (Fload): Bind Qlexical_binding.
798 (readevalloop): Remove `evalfun' arg.
799 Bind Qinternal_interpreter_environment.
800 (Feval_buffer): Bind Qlexical_binding.
801 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
802 Mark as dynamic.
803 (syms_of_lread): Declare `lexical-binding'.
804
805 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
806
807 * keyboard.c (eval_dyn): New fun.
808 (menu_item_eval_property): Use it.
ca105506
SM
809
810 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 811
03408648
SM
812 * fns.c (concat, mapcar1): Accept byte-code-functions.
813
814 * eval.c (Fsetq): Handle lexical vars.
815 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
816 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
817 (FletX, Flet): Obey lexical binding.
818 (Fcommandp): Handle closures.
819 (Feval): New `lexical' arg.
820 (eval_sub): New function extracted from Feval. Use it almost
821 everywhere where Feval was used. Look up vars in lexical env.
822 Handle closures.
823 (Ffunctionp): Move from subr.el.
824 (Ffuncall): Handle closures.
825 (apply_lambda): Remove `eval_flags'.
826 (funcall_lambda): Handle closures and new byte-code-functions.
827 (Fspecial_variable_p): New function.
828 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
829 but without exporting it to Lisp.
23aba0ea 830
23aba0ea 831 * doc.c (Fdocumentation, store_function_docstring):
03408648 832 * data.c (Finteractive_form): Handle closures.
23aba0ea 833
03408648
SM
834 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
835 interactive spec.
ba83908c 836
03408648
SM
837 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
838 byte-codes.
839 (exec_byte_code): New function extracted from Fbyte_code to handle new
840 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 841
03408648 842 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 843
03408648 844 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 845
e2abce01
JB
8462011-03-31 Juanma Barranquero <lekktu@gmail.com>
847
848 * xdisp.c (redisplay_internal): Fix prototype.
849
63696a73 8502011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 851
63696a73
EZ
852 * xdisp.c (SCROLL_LIMIT): New macro.
853 (try_scrolling): Use it when setting scroll_limit. Limit
854 scrolling to 100 screen lines.
855 (redisplay_window): Even when falling back on "recentering",
856 position point in the window according to scroll-conservatively,
857 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
858
859 (try_scrolling): When point is above the window, allow searching
860 as far as scroll_max, or one screenful, to compute vertical
861 distance from PT to the scroll margin position. This prevents
862 try_scrolling from unnecessarily failing when
863 scroll-conservatively is set to a value slightly larger than the
864 window height. Clean up the case of PT below the margin at bottom
865 of window: scroll_max can no longer be INT_MAX. When aggressive
866 scrolling is in use, don't let point enter the opposite scroll
867 margin as result of the scroll.
868 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
869 threshold of 100 lines for never-recentering scrolling.
870
e4cc2dfc
JB
8712011-03-31 Juanma Barranquero <lekktu@gmail.com>
872
873 * dispextern.h (move_it_by_lines):
874 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
875 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
876 (message_log_check_duplicate): Remove parameters `prev_bol' and
877 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
878 (redisplay_internal): Remove parameter `preserve_echo_area',
879 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
880
881 * indent.c (Fvertical_motion):
882 * window.c (window_scroll_pixel_based, Frecenter):
883 Don't pass `need_y_p' to `move_it_by_lines'.
884
1c470562
SM
8852011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
886
44f230aa
SM
887 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
888 steal a few bits to be more compact.
889 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
890 Remove unneeded casts.
891
1c470562
SM
892 * bytecode.c (Fbyte_code): CAR and CDR can GC.
893
888adce9
ZK
8942011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
895
896 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
897 binding" message (bug#7967).
898
f838ed7b
PE
8992011-03-30 Paul Eggert <eggert@cs.ucla.edu>
900
77861b95
PE
901 Fix more problems found by GCC 4.6.0's static checks.
902
de6dbc14
PE
903 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
904 Remove unused local var.
905
f838ed7b
PE
906 * editfns.c (Fmessage_box): Remove unused local var.
907
792c7b2b
PE
908 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
909 (note_mode_line_or_margin_highlight, note_mouse_highlight):
910 Omit unused local vars.
c499e557 911 * window.c (shrink_windows): Omit unused local var.
b01a1c29 912 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
913 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
914 Omit unused local var.
915
ba0165e1
PE
916 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
917 Don't assume string length fits in int.
32ad8845 918 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 919 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 920
3c59b4c9
PE
921 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
922 instead of alloca (Bug#8344).
923
a3eed478 924 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 925 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 926
eb4d412d
PE
927 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
928
1658b401
PE
929 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
930 concerns.
931
932 * term.c (produce_glyphless_glyph): Remove unnecessary test.
933
934 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 935
9a2c6e05
PE
936 * keyboard.c (syms_of_keyboard): Use the same style as later
937 in this function when indexing through an array. This also
938 works around GCC bug 48267.
939
03d0a109
PE
940 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
941
44f730c8
PE
942 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
943
fe75f926
PE
944 * chartab.c (sub_char_table_ref_and_range): Redo for slight
945 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
946
ffa8c828
PE
947 * keyboard.c, keyboard.h (num_input_events): Now size_t.
948 This avoids undefined behavior on integer overflow, and is a bit
949 more convenient anyway since it is compared to a size_t variable.
950
c5101a77
PE
951 Variadic C functions now count arguments with size_t, not int.
952 This avoids an unnecessary limitation on 64-bit machines, which
953 caused (substring ...) to crash on large vectors (Bug#8344).
954 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
955 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 956 All variadic functions and their callers changed accordingly.
c5101a77
PE
957 (struct gcpro.nvars): Now size_t, not int. All uses changed.
958 * data.c (arith_driver, float_arith_driver): Likewise.
959 * editfns.c (general_insert_function): Likewise.
960 * eval.c (struct backtrace.nargs, interactive_p)
961 (internal_condition_case_n, run_hook_with_args, apply_lambda)
962 (funcall_lambda, mark_backtrace): Likewise.
963 * fns.c (concat): Likewise.
964 * frame.c (x_set_frame_parameters): Likewise.
965 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
966 0 if not found, not -1. All callers changed.
967
dd3f25f7
PE
968 * alloc.c (garbage_collect): Don't assume stack size fits in int.
969 (stack_copy_size): Now size_t, not int.
970 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
971
461c2ab9
JB
9722011-03-28 Juanma Barranquero <lekktu@gmail.com>
973
974 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
975 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
976 All callers changed.
977
978 * lisp.h (multibyte_char_to_unibyte):
979 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
980 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
981 * character.h (CHAR_TO_BYTE8):
982 * cmds.c (internal_self_insert):
983 * editfns.c (general_insert_function):
984 * keymap.c (push_key_description):
985 * search.c (Freplace_match):
986 * xdisp.c (message_dolog, set_message_1): All callers changed.
987
f6d62986
SM
9882011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
989
990 * keyboard.c (safe_run_hook_funcall): New function.
991 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
992 don't set the hook to nil, but remove the offending function instead.
993 (Qcommand_hook_internal): Remove, unused.
994 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
995 Vcommand_hook_internal.
996
997 * eval.c (enum run_hooks_condition): Remove.
998 (funcall_nil, funcall_not): New functions.
999 (run_hook_with_args): Call each function through a `funcall' argument.
1000 Remove `cond' argument, now redundant.
1001 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1002 (Frun_hook_with_args_until_failure): Adjust accordingly.
1003 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1004
1db5b1ad
JB
10052011-03-28 Juanma Barranquero <lekktu@gmail.com>
1006
1007 * dispextern.h (string_buffer_position): Remove declaration.
1008
1009 * print.c (strout): Remove parameter `multibyte', unused since
1010 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1011
1012 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1013 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1014 All callers changed.
1015
1016 * w32.c (_wsa_errlist): Use braces for struct initializers.
1017
1018 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1019 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1020 All callers changed.
1021 (string_buffer_position): Likewise. Also, make static (it's never
1022 used outside xdisp.c).
1023 (cursor_row_p): Remove parameter `w', unused since
1024 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1025 (decode_mode_spec): Remove parameter `precision', introduced during
1026 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1027 All callers changed.
1028
5ffb62aa
JD
10292011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1030
1031 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1032
461c2ab9 10332011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1034
1035 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1036 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1037 (ns_update_auto_hide_menu_bar): New functions.
1038 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1039 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1040 ns_constrain_all_frames.
1041 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1042 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1043
5c380ffb
JD
10442011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1045
1046 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1047
9af30bdf
GM
10482011-03-27 Glenn Morris <rgm@gnu.org>
1049
1050 * syssignal.h: Replace RETSIGTYPE with void.
1051 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1052 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1053 Replace SIGTYPE with void everywhere.
1054 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1055 * s/template.h (SIGTYPE): Remove commented out definition.
1056
e2abce01
JB
10572011-03-26 Eli Zaretskii <eliz@gnu.org>
1058
1059 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1060 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1061
f868cd8a
JB
10622011-03-26 Juanma Barranquero <lekktu@gmail.com>
1063
59eb0929
JB
1064 * w32.c (read_unc_volume): Use parameter `henum', instead of
1065 global variable `wget_enum_handle'.
1066
1067 * keymap.c (describe_vector): Remove parameters `indices' and
1068 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1069 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1070
f868cd8a
JB
1071 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1072
1073 * keyboard.c (timer_check): Remove parameter `do_it_now',
1074 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1075 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1076 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1077
1078 * keyboard.c (read_char):
1079 * w32menu.c (w32_menu_display_help):
1080 * xmenu.c (show_help_event, menu_help_callback):
1081 Adjust calls to `show_help_echo'.
1082
1083 * gtkutil.c (xg_maybe_add_timer):
1084 * keyboard.c (readable_events):
1085 * process.c (wait_reading_process_output):
1086 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1087
1088 * insdel.c (adjust_markers_gap_motion):
1089 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1090 (gap_left, gap_right): Don't call it.
1091
2ecf6fdb
CY
10922011-03-25 Chong Yidong <cyd@stupidchicken.com>
1093
1094 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1095 incurred during fontification.
1096
6b1f9ba4
JB
10972011-03-25 Juanma Barranquero <lekktu@gmail.com>
1098
1099 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1100 (DEFVAR_PER_BUFFER): Don't pass it.
1101
1102 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1103 (scrolling_window): Don't pass it.
1104
0f4a96b5
JB
11052011-03-25 Juanma Barranquero <lekktu@gmail.com>
1106
1107 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1108
1109 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1110 and `suffix'.
1111 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1112 of variables specific to SELinux and computation of `encoded_absname'.
1113
1114 * image.c (XPutPixel): Remove unused variable `height'.
1115
1116 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1117
1118 * unexw32.c (get_section_info): Remove unused variable `section'.
1119
1120 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1121 (system_process_attributes): Remove unused variable `sess'.
1122 (sys_read): Remove unused variable `err'.
1123
1124 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1125 (w32_wnd_proc): Remove unused variable `isdead'.
1126 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1127 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1128 (x_create_tip_frame): Remove unused variable `tem'.
1129
1130 * w32inevt.c (w32_console_read_socket):
1131 Remove unused variable `no_events'.
1132
1133 * w32term.c (x_draw_composite_glyph_string_foreground):
1134 Remove unused variable `width'.
1135
1149507c
JB
11362011-03-24 Juanma Barranquero <lekktu@gmail.com>
1137
1138 * w32term.c (x_set_glyph_string_clipping):
1139 Don't pass uninitialized region to CombineRgn.
1140
9c88f339
JB
11412011-03-23 Juanma Barranquero <lekktu@gmail.com>
1142
1143 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1144 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1145 (Fx_close_connection): Remove unused variable `i'.
1146
1147 * w32font.c (w32font_draw): Return number of glyphs.
1148 (w32font_open_internal): Remove unused variable `i'.
1149 (w32font_driver): Add missing initializer.
1150
1151 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1152 (fill_in_menu): Remove unused variable `items_added'.
1153
1154 * w32term.c (last_mouse_press_frame): Remove static global variable.
1155 (w32_clip_to_row): Remove unused variable `f'.
1156 (x_delete_terminal): Remove unused variable `i'.
1157
1158 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1159 (NOTHING): Remove unused static global variable.
1160 (uniscribe_check_otf): Remove unused variable `table'.
1161 (uniscribe_font_driver): Add missing initializers.
1162
dee091a3
JD
11632011-03-23 Julien Danjou <julien@danjou.info>
1164
1165 * term.c (Fsuspend_tty, Fresume_tty):
1166 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1167 * window.c (temp_output_buffer_show):
1168 * insdel.c (signal_before_change):
1169 * frame.c (Fhandle_switch_frame):
1170 * fileio.c (Fdo_auto_save):
1171 * emacs.c (Fkill_emacs):
1172 * editfns.c (save_excursion_restore):
1173 * cmds.c (internal_self_insert):
1174 * callint.c (Fcall_interactively):
1175 * buffer.c (Fkill_all_local_variables):
1176 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1177 Use Frun_hooks.
0f4a96b5 1178 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1179 unconditionnaly since it does the check itself.
1180
2c520ab5 11812011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1182
c9c49752
PE
1183 Fix more problems found by GCC 4.5.2's static checks.
1184
8abc3f12
PE
1185 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1186 the first time through the loop, since we know p0 < p1 then.
1187 This also avoids a gcc -Wstrict-overflow warning.
1188
a2d26660
PE
1189 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1190 leading to a memory leak, possible in functions like
1191 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1192 of objects (Bug#8318).
a2d26660 1193
916c72e9
PE
1194 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1195 that could (at least in theory) be that large.
1196
19ab8a18
PE
1197 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1198 This is less likely to overflow, and avoids undefined behavior if
1199 overflow does occur. All callers changed. Use strtoul to scan
1200 for the unsigned long integer.
b7cbbd6f
PE
1201 (pint2hrstr): Simplify and tune code slightly.
1202 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1203
f0641eff
PE
1204 * scroll.c (do_scrolling): Work around GCC bug 48228.
1205 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1206
7f650bb9
PE
1207 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1208 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1209 (validate_x_resource_name): Simplify count usage.
1210 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1211
37dd57d1
PE
1212 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1213 fail (Bug#8306).
81e56e61 1214
699979fc 1215 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1216
401bf9b4
PE
1217 * process.c (Fmake_network_process): Use socklen_t, not int,
1218 where POSIX says socklen_t is required in portable programs.
1219 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1220 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1221 (Fmake_network_process, server_accept_connection):
1222 (wait_reading_process_output, read_process_output):
1223 Likewise.
1224
b93aacde
PE
1225 * process.c: Rename or move locals to avoid shadowing.
1226 (list_processes_1, Fmake_network_process):
1227 (read_process_output_error_handler, exec_sentinel_error_handler):
1228 Rename or move locals.
4dc343ee 1229 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1230 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1231 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1232 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1233 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1234
af8a867c 1235 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1236 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1237 Include tparam.h instead, since it declares them.
af8a867c
PE
1238 * cm.h (PC): Remove extern decl; tparam.h now does this.
1239 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1240 * terminfo.c: Include tparam.h, to check interfaces.
1241 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1242 (tparam): Adjust signature to match interface in tparam.h;
1243 this removes some undefined behavior. Check that outstring and len
1244 are zero, which they always are with Emacs.
1245 * tparam.h (PC, BC, UP): New extern decls.
1246
0248044d 1247 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1248 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1249
8ff096c1 1250 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1251 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1252 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1253 (ftfont_list): Remove unused local.
49eaafba
PE
1254 (get_adstyle_property, ftfont_pattern_entity):
1255 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1256 Rename locals to avoid shadowing.
8ff096c1 1257
e2be39f6
PE
1258 * xfont.c (xfont_list_family): Mark var as initialized.
1259
c9735e30
PE
1260 * xml.c (make_dom): Now static.
1261
8f5201ae
PE
1262 * composite.c (composition_compute_stop_pos): Rename local to
1263 avoid shadowing.
b246f932
PE
1264 (composition_reseat_it): Remove unused locals.
1265 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1266 (composition_update_it): Mark var as initialized.
11b61122
PE
1267 (find_automatic_composition): Mark vars as initialized,
1268 with a FIXME (Bug#8290).
8f5201ae 1269
760fbc2c
PE
1270 character.h: Rename locals to avoid shadowing.
1271 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1272 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1273 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1274 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1275 to avoid shadowing.
1276
ff08eb85
PE
1277 * textprop.c (property_change_between_p): Remove; unused.
1278
fc7bf025
PE
1279 * intervals.c (interval_start_pos): Now static.
1280
235d7abc
PE
1281 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1282
44f230aa
SM
1283 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1284 Rename locals to avoid shadowing.
3e7d6594 1285
50060332
PE
1286 * sound.c (wav_play, au_play, Fplay_sound_internal):
1287 Fix pointer signedness.
d01f234b 1288 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1289 (wav_play): Initialize a variable to 0, to prevent undefined
1290 behavior (Bug#8278).
50060332 1291
c4fc4e30
PE
1292 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1293
918436ed
PE
1294 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1295
c939f91b
PE
1296 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1297 clobbering (Bug#8298).
b9c7f648
PE
1298 * sysdep.c (sys_subshell): Likewise.
1299 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1300
6bd8c144
PE
1301 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1302 This should get cleaned up, so that child_setup has the
1303 same signature on all platforms.
1304
7710357c 1305 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1306 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1307
c59da222
CY
13082011-03-22 Chong Yidong <cyd@stupidchicken.com>
1309
1310 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1311 not to be necessary, and produces flickering.
1312
66b87493
GM
13132011-03-20 Glenn Morris <rgm@gnu.org>
1314
1315 * config.in: Remove file.
1316
45b6f6d5
JB
13172011-03-20 Juanma Barranquero <lekktu@gmail.com>
1318
1319 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1320 are now in src/globals.h.
1321 (syms_of_minibuf): Remove spurious & from previous change.
1322
3ec03f7e
LL
13232011-03-20 Leo <sdl.web@gmail.com>
1324
1325 * minibuf.c (completing-read-function): New variable.
1326 (completing-read-default): Rename from completing-read.
1327 (completing-read): Call completing-read-function.
1328
b14e3e21
CY
13292011-03-19 Juanma Barranquero <lekktu@gmail.com>
1330
1331 * xfaces.c (Fx_load_color_file):
1332 Read color file from absolute filename (bug#8250).
1333
f2b726e6
JB
13342011-03-19 Juanma Barranquero <lekktu@gmail.com>
1335
1336 * makefile.w32-in: Update dependencies.
1337
09f6ff02
EZ
13382011-03-17 Eli Zaretskii <eliz@gnu.org>
1339
1340 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1341
29a6015a
PE
13422011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1343
a3a6c54e
PE
1344 Fix more problems found by GCC 4.5.2's static checks.
1345
b766f867
PE
1346 * process.c (make_serial_process_unwind, send_process_trap):
1347 (sigchld_handler): Now static.
1348
be02381c
PE
1349 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1350 That way, the code declares only the vars that it needs.
1351 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1352 * s/cygwin.h (PTY_ITERATION): Likewise.
1353 * s/darwin.h (PTY_ITERATION): Likewise.
1354 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1355
57048744
PE
1356 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1357 * process.c (allocate_pty): Don't declare stb unless it's needed.
1358
7914961c 1359 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1360 (CONSTANTLIM): Remove; unused.
1361 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1362 Define only if needed.
7914961c 1363
b3967b18
PE
1364 * unexelf.c (unexec): Name an expression,
1365 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1366 Use a different way to cause a compilation error if anyone uses
1367 n rather than nn, a way that does not involve shadowing.
73366a00 1368 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1369
29a6015a
PE
1370 * deps.mk (unexalpha.o): Remove; unused.
1371
43cfc33e 1372 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1373 * unexec.h: New file.
ce701a33
PE
1374 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1375 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1376 Depend on unexec.h.
1377 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1378 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1379 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1380 Change as necessary to match prototype in unexec.h.
ce701a33 1381
01f44d5a
PE
1382 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1383 shadowing.
4f63c6bb 1384 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1385
a6670b0b
PE
1386 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1387 Rename locals to avoid shadowing.
1388
cef2010d 1389 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1390 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1391
d4d7173a
PE
1392 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1393
f08b802a
PE
1394 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1395 warning when compiling print.c.
1396
3ddb0639
PE
1397 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1398 instead of using an uninitialized var.
5ad03b97 1399 (font_sort_entities): Mark var as initialized.
3ddb0639 1400
170a2692
PE
1401 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1402
e663c700
PE
1403 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1404 pointers to constants.
89bc529a 1405 (font_parse_fcname): Remove unused vars.
7b81e2d0 1406 (font_delete_unmatched): Now static.
ea838e10 1407 (font_get_spec): Remove; unused.
13a547c6
PE
1408 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1409 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1410 Rename or move locals to avoid shadowing.
e663c700 1411
2a80c887 1412 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1413 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1414
1384fa33 1415 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1416 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1417
8b2c52e9
PE
1418 * alloc.c (mark_backtrace): Move decl from here ...
1419 * lisp.h: ... to here, so that it can be checked.
1420
475545b5 1421 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1422 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1423 (lisp_indirect_variable): Name an expression,
1424 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1425 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1426
b1349114 1427 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1428 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1429 Use const pointer when appropriate.
b1349114 1430
a2928364
PE
1431 * lisp.h (get_system_name, get_operating_system_release):
1432 Move decls here, to check interfaces.
1433 * process.c (get_operating_system_release): Move decl to lisp.h.
1434 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1435 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1436 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1437 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1438 (Fformat_time_string, Fencode_time, Finsert_char):
1439 (Ftranslate_region_internal, Fformat):
1440 Rename or remove local vars to avoid shadowing.
9710023e 1441 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1442
a415e694
PE
1443 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1444 avoid shadowing.
1445
8ef4622d
PE
1446 * lisp.h (eassert): Check that the argument compiles, even if
1447 ENABLE_CHECKING is not defined.
1448
946f9a5b
PE
1449 * data.c (Findirect_variable): Name an expression, to avoid
1450 gcc -Wbad-function-cast warning.
112396d6 1451 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1452 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1453 (Fmake_variable_buffer_local, Fmake_local_variable):
1454 Mark variables as initialized.
52746918 1455 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1456
e5aab7e7 1457 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1458 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1459 Rename locals to avoid shadowing.
dff45157
PE
1460 (mark_stack): Move local variables into the #ifdef region where
1461 they're used.
7bc26fdb
PE
1462 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1463 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1464 needed otherwise.
1465 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1466 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1467 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1468
e5aab7e7
PE
1469 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1470 avoids undefined behavior in theory.
1471
4da60324
PE
1472 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1473
88043301
PE
1474 Use functions, not macros, for up- and down-casing (Bug#8254).
1475 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1476 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1477 to use the following functions instead of these macros.
1478 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1479 EMACS_INT, since callers assume the returned value fits in int.
1480 (upcase1): Likewise, for UPCASE_TABLE.
1481 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1482 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1483 the race-condition problem in the old DOWNCASE.
88043301 1484
19ed5445
PE
1485 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1486 Rename locals to avoid shadowing.
1487 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1488 (regex_compile, re_search_2, re_match_2_internal):
1489 Remove unused local vars.
952db0d7
PE
1490 (FREE_VAR): Rewrite so as not to use empty "else",
1491 which gcc can warn about.
da053e48 1492 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1493 (RETALLOC_IF): Define only if needed.
1494 (WORDCHAR_P): Likewise. This one is never needed, but is used
1495 only in a comment talking about a compiler bug, so put inside
1496 the #if 0 of that comment.
1497 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1498 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1499 Remove; unused.
19ed5445 1500
1f3561e4 1501 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1502 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1503 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1504
ded6f8f7
PE
1505 * search.c (simple_search): Remove unused var.
1506
dbd37a95
PE
1507 * dired.c (compile_pattern): Move decl from here ...
1508 * lisp.h: ... to here, so that it can be checked.
1509 (struct re_registers): New forward decl.
1510
7e47afad
PE
1511 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1512
85f24f61
PE
1513 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1514 All uses changed.
1515 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1516 Rename locals to avoid shadowing.
5671df8f 1517 (Fvertical_motion): Mark locals as initialized.
85f24f61 1518
181aa2be 1519 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1520 (casify_region): Mark local as initialized.
181aa2be 1521
930d429c
PE
1522 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1523
7082eac6
PE
1524 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1525 New macros, so that the caller can use some names other than
1526 gcpro1, gcpro2, etc.
1527 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1528 of the new macros.
1529 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1530 argument, for consistency with GCPRO2_VAR, etc: it is now the
1531 prefix of the variable, not the variable itself. All uses
1532 changed.
38b2c076
PE
1533 * dired.c (directory_files_internal, file_name_completion):
1534 Rename locals to avoid shadowing.
1535
15206ed9
PE
1536 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1537 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1538 dired.c's scmp function, had undefined behavior.
1539 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1540 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1541 * buffer.h: ... to here, because these macros use current_buffer,
1542 and the new implementation with inline functions needs to have
1543 current_buffer in scope now, rather than later when the macros
1544 are used.
1545 (downcase, upcase1): New static inline functions.
1546 (DOWNCASE, UPCASE1): Reimplement using these functions.
1547 This avoids undefined behavior in expressions like
1548 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1549 from race conditions in accessing the global variables
1550 case_temp1 and case_temp2.
1551 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1552 * lisp.h (case_temp1, case_temp2): Remove their decls.
1553 * character.h (ASCII_CHAR_P): Move from here ...
1554 * lisp.h: ... to here, so that the inline functions mentioned
1555 above can use them.
1556
4a6bea26
PE
1557 * dired.c (directory_files_internal_unwind): Now static.
1558
f14b7e14
PE
1559 * fileio.c (file_name_as_directory, directory_file_name):
1560 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1561 Now static.
2893f146
PE
1562 (file_name_as_directory): Use const pointers when appropriate.
1563 (Fexpand_file_name): Likewise. In particular, newdir might
1564 point at constant storage, so make it a const pointer.
fd4ead52 1565 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1566 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1567 signedness issues.
f839df0c
PE
1568 (Fset_file_times, Finsert_file_contents, auto_save_error):
1569 Rename locals to avoid shadowing.
f14b7e14 1570
5716756e 1571 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1572 (Ftry_completion, Fall_completions): Rename or remove locals
1573 to avoid shadowing.
5716756e 1574
b4c3046a
PE
1575 * marker.c (bytepos_to_charpos): Remove; unused.
1576
b45db522
PE
1577 * lisp.h (verify_bytepos, count_markers): New decls,
1578 so that gcc does not warn that these functions aren't declared.
1579
85876d07
PE
1580 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1581 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1582 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1583 (copy_text): Remove unused local var.
85876d07 1584
03d78a21 1585 * filelock.c (within_one_second): Now static.
b3dd38ab 1586 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1587
5df8f01b
PE
1588 * buffer.c (fix_overlays_before): Mark locals as initialized.
1589 (fix_start_end_in_overlays): Likewise. This function should be
1590 simplified by using pointers-to-pointers, but that's a different
1591 matter.
b1d876f1 1592 (switch_to_buffer_1): Now static.
8f54f30a
PE
1593 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1594 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1595
a70072c9 1596 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1597 Fix pointer signedness issue.
edced198
PE
1598 (sys_subshell): Mark local as volatile if checking for lint,
1599 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1600 (MAXPATHLEN): Define only if needed.
a70072c9 1601
a0977c44
PE
1602 * process.c (serial_open, serial_configure): Move decls from here ...
1603 * systty.h: ... to here, so that they can be checked.
1604
a884fdcc
PE
1605 * fns.c (get_random, seed_random): Move extern decls from here ...
1606 * lisp.h: ... to here, so that they can be checked.
1607
604efe86 1608 * sysdep.c (reset_io): Now static.
b8950c94 1609 (wait_for_termination_signal): Remove; unused.
604efe86 1610
38fc62d9
PE
1611 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1612 (copy_keymap_item, append_key, push_text_char_description):
1613 Now static.
1004a21a 1614 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1615 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1616 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1617 (describe_map_tree):
1618 Rename locals to avoid shadowing.
38fc62d9 1619
2f2650da
PE
1620 * keyboard.c: Declare functions static if they are not used elsewhere.
1621 (echo_char, echo_dash, cmd_error, top_level_2):
1622 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1623 (read_char, kbd_buffer_get_event, make_lispy_position):
1624 (make_lispy_event, make_lispy_movement, apply_modifiers):
1625 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1626 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1627 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1628 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1629 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1630
a053e86c 1631 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1632 (mark_kboards): Move decl here ...
1633 * alloc.c (mark_kboards): ... from here.
a053e86c 1634
4752793e
PE
1635 * lisp.h (force_auto_save_soon): New decl.
1636
74f10ca7 1637 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1638 (DEFINE_DUMMY_FUNCTION): New macro.
1639 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1640 Use it.
c03cd23f
PE
1641 (main): Add casts to avoid warnings
1642 if GCC considers string literals to be constants.
74f10ca7 1643
022e70d4
PE
1644 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1645
59d6fe83
PE
1646 * dbusbind.c: Pointer signedness fixes.
1647 (xd_signature, xd_append_arg, xd_initialize):
1648 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1649 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1650 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1651 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1652
78320123
PE
1653 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1654 if GCC considers string literals to be constants.
49cebcca 1655 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1656
35ac2a97
SM
16572011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1658
fb103ca9
SM
1659 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1660 (print_preprocess, print_object): New macro to fix last change.
1661
35ac2a97
SM
1662 * print.c (print_preprocess): Don't forget font objects.
1663
62973b41
JB
16642011-03-16 Juanma Barranquero <lekktu@gmail.com>
1665
1666 * emacs.c (USAGE3): Doc fixes.
1667
0e48bb22
AS
16682011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1669
1670 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1671 structure.
1672
7684e57b
JB
16732011-03-14 Juanma Barranquero <lekktu@gmail.com>
1674
1675 * lisp.h (VWindow_system, Qfile_name_history):
1676 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1677 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1678 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1679
1680 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1681 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1682
1683 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1684 * w32console.c (detect_input_pending, read_input_pending)
1685 (encode_terminal_code):
1686 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1687 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1688 (w32_system_caret_y, Qfile_name_history):
1689 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1690 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1691 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1692 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1693 * w32proc.c (Qlocal, report_file_error):
1694 * w32term.c (Vwindow_system, updating_frame):
1695 * w32uniscribe.c (initialized, uniscribe_font_driver):
1696 Remove unneeded extern declarations.
1697
2aa46d6c
CY
16982011-03-14 Chong Yidong <cyd@stupidchicken.com>
1699
c96bbc66 1700 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1701
cffc6f3b
CY
17022011-03-13 Chong Yidong <cyd@stupidchicken.com>
1703
1704 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1705 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1706 These macros can no longer be used for assignment.
1707
44f230aa
SM
1708 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1709 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1710 (record_buffer_markers, fetch_buffer_markers): New functions for
1711 recording and fetching special buffer markers.
1712 (set_buffer_internal_1, set_buffer_temp): Use them.
1713
1714 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1715
1716 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1717
1718 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1719 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1720
1721 * xdisp.c (hscroll_window_tree):
1722 (reconsider_clip_changes): Use PT instead of BUF_PT.
1723
d251f04b
EZ
17242011-03-13 Eli Zaretskii <eliz@gnu.org>
1725
1726 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1727 $(EMACS_ROOT)/lib/intprops.h.
1728
f0c77cd1
PE
17292011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1730
3eca4629
PE
1731 Fix more problems found by GCC 4.5.2's static checks.
1732
7c86ee98
PE
1733 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1734 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1735 (xg_free_frame_widgets): Make it clear that a local variable is
1736 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1737 (gdk_window_get_screen): Make it clear that this macro is needed
1738 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1739 (int_gtk_range_get_value): New function, which avoids a diagnostic
1740 from gcc -Wbad-function-cast.
1741 (xg_set_toolkit_scroll_bar_thumb): Use it.
1742 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1743 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1744 (get_utf8_string, xg_get_file_with_chooser):
1745 Rename locals to avoid shadowing.
1746 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1747
41729b81
PE
1748 * xgselect.c (xg_select): Remove unused var.
1749
f0c77cd1
PE
1750 * image.c (four_corners_best): Mark locals as initialized.
1751 (gif_load): Initialize transparent_p to zero (Bug#8238).
1752 Mark another local as initialized.
ec6cf4c6 1753 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1754
ce0ad53d 1755 * image.c (clear_image_cache): Now static.
d5d5a617 1756 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1757 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1758 (x_edge_detection): Remove unnecessary cast that
1759 gcc -Wbad-function-cast diagnoses.
2037898d 1760 (gif_load): Fix pointer signedness.
6ae141d6
PE
1761 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1762 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1763
33383987 17642011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1765
d32df629
PE
1766 Improve quality of tests for time stamp overflow.
1767 For example, without this patch (encode-time 0 0 0 1 1
1768 1152921504606846976) returns the obviously-bogus value (-948597
1769 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1770 reports time overflow. See
1771 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1772 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1773 * editfns.c: Include limits.h and intprops.h.
1774 (TIME_T_MIN, TIME_T_MAX): New macros.
1775 (time_overflow): Move earlier, to before first use.
1776 (hi_time, lo_time): New functions, for an accurate test for
1777 out-of-range times.
1778 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1779 (Fget_internal_run_time): Don't assume time_t fits in int.
1780 (make_time): Use list2 instead of Fcons twice.
1781 (Fdecode_time): More accurate test for out-of-range times.
1782 (check_tm_member): New function.
1783 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1784 (lisp_time_argument): Don't rely on undefined left-shift and
1785 right-shift behavior when checking for time stamp overflow.
8be6f318 1786
fe31d94c
PE
1787 * editfns.c (time_overflow): New function, refactoring common code.
1788 (Fformat_time_string, Fdecode_time, Fencode_time):
1789 (Fcurrent_time_string): Use it.
1790
8be6f318
PE
1791 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1792 * dired.c (make_time): Move to ...
1793 * editfns.c (make_time): ... here.
1794 * systime.h: Note the move.
1795
09d9db2c 17962011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1797
126bc0dc
YM
1798 * fringe.c (update_window_fringes): Remove unused variables.
1799
c47cbdfd
YM
1800 * unexmacosx.c (copy_data_segment): Also copy __got section.
1801 (Bug#8223)
1802
7ac80be9
EZ
18032011-03-12 Eli Zaretskii <eliz@gnu.org>
1804
c96bbc66 1805 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1806 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1807 Constify `char *' arguments and their references according to
1808 prototypes in tparam.h.
1809
ecb0f94d 1810 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1811
7ac80be9
EZ
1812 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1813 Adapt all references accordingly.
1814
1815 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1816
ef1fd07e
TT
18172011-03-11 Tom Tromey <tromey@redhat.com>
1818
1819 * buffer.c (syms_of_buffer): Remove obsolete comment.
1820
7ef4b50c
EZ
18212011-03-11 Eli Zaretskii <eliz@gnu.org>
1822
1823 * termhooks.h (encode_terminal_code): Declare prototype.
1824
1825 * msdos.c (encode_terminal_code): Don't declare prototype.
1826
1827 * term.c (encode_terminal_code): Now external again, used by
1828 w32console.c and msdos.c.
1829
44f230aa
SM
1830 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1831 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1832
4b1ec863 18332011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1834
1714f52b 1835 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1836
4b1ec863
PE
1837 * fringe.c (update_window_fringes): Mark locals as initialized
1838 (Bug#8227).
1839 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1840
524c7aa6
PE
1841 * alloc.c (mark_fringe_data): Move decl from here ...
1842 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1843 to check its interface.
1844 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1845
a5c0af81 1846 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1847 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1848 (fontset_font): Mark local as initialized.
a9a06e0b 1849 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1850
b4716021
PE
1851 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1852
811e9bac 1853 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1854 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1855 (x_own_selection, Fx_disown_selection_internal): Rename locals
1856 to avoid shadowing.
1857 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1858
7e3ab302
PE
1859 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1860 so that the caller can use some name other than gcpro1.
1861 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1862 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1863 (Fx_backspace_delete_keys_p):
1864 Use them to avoid shadowing, and rename vars to avoid shadowing.
1865 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1866 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1867 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1868 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1869 Remove unused locals.
7e3ab302
PE
1870 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1871 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1872 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1873 macros.
f78faa98 1874
e2b13473
PE
1875 * xterm.h (x_mouse_leave): New decl.
1876
77f23912
PE
1877 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1878 Remove unused functions.
cdf4ba58
PE
1879 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1880 (x_calc_absolute_position): Now static.
7411c686 1881 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1882 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1883 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1884 unless they are used.
38d0b34a
PE
1885 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1886 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1887 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1888 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1889 (x_error_catcher, x_connection_closed, x_error_handler):
1890 (x_error_quitter, xembed_send_message, x_iconify_frame):
1891 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1892 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1893 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1894
44f230aa
SM
1895 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1896 Rename or move locals to avoid shadowing.
6b463e58 1897 (tty_defined_color, merge_face_heights): Now static.
5967d051 1898 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1899 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1900 does not deduce is never used uninitialized.
73719eba
PE
1901 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1902 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1903
426994c3 1904 * terminal.c (store_terminal_param): Now static.
5489860b 1905
032f1620 1906 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1907 (set_frame_menubar): Remove unused local.
d4323972 1908 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1909 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1910 since they might point to immutable storage.
281585b0
PE
1911 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1912 since it's unused otherwise.
032f1620 1913
367c19e5 1914 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1915 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1916 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1917 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1918 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1919 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1920 does not deduce are never used uninitialized.
70739cbe 1921
07b48fa9
PE
1922 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1923
8868a238 1924 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1925 * window.c (window_loop, size_window):
1926 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1927
7e5cf297 1928 * window.c (display_buffer): Now static.
d6550a9f
PE
1929 (size_window): Mark variables that gcc -Wuninitialized
1930 does not deduce are never used uninitialized.
a586633d
PE
1931 * window.h (check_all_windows): New decl, to forestall
1932 gcc -Wmissing-prototypes diagnostic.
5b555da1 1933 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1934
f6095868
PE
1935 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1936 shadowing.
1937 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1938 Include <limits.h>.
1939 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1940 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1941 (load_charset_map): Mark variables that gcc -Wuninitialized
1942 does not deduce are never used uninitialized.
53df7c11 1943 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1944
f38b440c
PE
1945 * coding.c (coding_set_source, coding_set_destination):
1946 Use "else { /* comment */ }" rather than "else /* comment */;"
1947 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1948 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1949 a block, when the outer 'i' will do.
1950 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1951 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1952 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1953 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1954 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1955 Rename locals to avoid shadowing.
1956 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1957 * coding.c (emacs_mule_char, encode_invocation_designation):
1958 Now static, since they're not used elsewhere.
413bb2db 1959 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1960 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1961 (decode_coding_emacs_mule): Mark variables that gcc
1962 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1963 (detect_coding_iso_2022): Initialize a local variable that might
1964 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1965 this initialization is needed. (Bug#8211)
5f58e762
PE
1966 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1967 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1968 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1969 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1970 Remove unused macros.
f38b440c 1971
232b38b9 1972 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1973 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1974 * character.c (string_count_byte8): Likewise.
232b38b9 1975
fb90da1b
PE
1976 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1977 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1978
fb93dbc2
PE
1979 * chartab.c (copy_sub_char_table): Now static, since it's not used
1980 elsewhere.
5c156ace
PE
1981 (sub_char_table_ref_and_range, char_table_ref_and_range):
1982 Rename locals to avoid shadowing.
bbcd0949 1983 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 1984
7d3b3862 1985 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 1986 (BIDI_BOB): Remove unused macro.
7d3b3862 1987
6be7d3da
PE
1988 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1989 deduce are never used uninitialized.
c2ed9c8b 1990 * term.c (encode_terminal_code): Likewise.
6be7d3da 1991
75f8807f 1992 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 1993
50938595
PE
1994 * tparam.h: New file.
1995 * term.c, tparam.h: Include it.
1996 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1997 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1998 Move these decls to tparam.h, and make them agree with what
1999 is actually in tparam.c. The previous trick of using incompatible
2000 decls in different modules does not conform to the C standard.
2001 All callers of tparam changed to use tparam's actual API.
2002 * tparam.c (tparam1, tparam, tgoto):
2003 Use const pointers where appropriate.
2004
fbceeba2
PE
2005 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2006 * cm.h (struct cm): Likewise.
2007 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2008 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2009 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2010 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2011 (turn_on_face, init_tty): Likewise.
2012 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2013
7f3f1250
PE
2014 * term.c (term_mouse_position): Rename local to avoid shadowing.
2015
e6ca6543
PE
2016 * alloc.c (mark_ttys): Move decl from here ...
2017 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2018
c40f8d15
AS
20192011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2020
2021 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2022
cfe0661d
JB
20232011-03-09 Juanma Barranquero <lekktu@gmail.com>
2024
2025 * search.c (compile_pattern_1): Remove argument regp, unused since
2026 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2027 (compile_pattern): Don't pass it.
2028
0afb4571
J
20292011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2030
2031 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2032 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2033 for ! HAVE_GTK3.
2034 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2035
2036 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2037
2038 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2039 gdk_window_get_screen, gdk_window_get_geometry,
2040 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2041 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2042 (xg_get_pixbuf_from_pixmap): New function.
2043 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2044 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2045 Call xg_get_pixbuf_from_pixmap instead of
2046 gdk_pixbuf_get_from_drawable.
2047 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2048 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2049 (xg_check_special_colors): Use GtkStyleContext and its functions
2050 for HAVE_GTK3.
2051 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2052 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2053 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2054 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2055 Call gtk_widget_get_preferred_size.
0afb4571
J
2056 (xg_frame_resized): gdk_window_get_geometry only takes 5
2057 parameters.
44f230aa
SM
2058 (xg_win_to_widget, xg_event_is_for_menubar):
2059 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2060 (xg_set_widget_bg): New function.
2061 (delete_cb): New function.
2062 (xg_create_frame_widgets): connect delete-event to delete_cb.
2063 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2064 (xg_set_background_color): Call xg_set_widget_bg.
2065 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2066 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2067 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2068 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2069 if ! HAVE_GTK3.
2070 (update_frame_tool_bar): Call gtk_widget_hide.
2071 (xg_initialize): Use GDK_KEY_g.
2072
2073 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2074 if ! HAVE_GTK3
2075 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2076
2077 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2078 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2079 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2080
1c2cc4ef
JB
20812011-03-08 Juanma Barranquero <lekktu@gmail.com>
2082
2083 * w32xfns.c (select_palette): Check success of RealizePalette against
2084 GDI_ERROR, not zero.
2085
33383987 2086See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2087
2088;; Local Variables:
2089;; coding: utf-8
aac0c6e3
MR
2090;; End:
2091
33383987 2092 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2093
2094 This file is part of GNU Emacs.
2095
2096 GNU Emacs is free software: you can redistribute it and/or modify
2097 it under the terms of the GNU General Public License as published by
2098 the Free Software Foundation, either version 3 of the License, or
2099 (at your option) any later version.
2100
2101 GNU Emacs is distributed in the hope that it will be useful,
2102 but WITHOUT ANY WARRANTY; without even the implied warranty of
2103 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2104 GNU General Public License for more details.
2105
2106 You should have received a copy of the GNU General Public License
2107 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.