* gtkutil.c: Omit integer casts.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5adf60bc
PE
12011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2
5f8f9cc2
PE
3 * gtkutil.c: Omit integer casts.
4 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6
5adf60bc
PE
7 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8
82d66f4e
PE
9 * bidi.c (bidi_dump_cached_states): Use pD to print ptrdiff_t.
10
c8907a93
PE
11 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
12 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
13 would wrongly return t on a 64-bit host.
14
e3c25c68
PE
15 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
16 The plain *_OVERFLOW macros run afoul of GCC bug 49705
17 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
18 and therefore cause GCC to emit a bogus diagnostic in some cases.
19
3f791afe
PE
20 * image.c: Integer signedness and overflow and related fixes.
21 This is not an exhaustive set of fixes, but it's time to
22 record what I've got.
23 (lookup_pixel_color, check_image_size): Remove redundant decls.
24 (check_image_size): Don't assume that arbitrary EMACS_INT values
25 fit in 'int', or that arbitrary 'double' values fit in 'int'.
26 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
27 (tiff_load, imagemagick_load_image):
28 Check for overflow in size calculations.
29 (x_create_x_image_and_pixmap): Remove unnecessary test for
30 xmalloc returning NULL; that can't happen.
31 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
32 (xpm_color_bucket): Use better integer hashing function.
33 (xpm_cache_color): Don't possibly over-allocate memory.
34 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
35 (gif_memory_source):
36 Use ptrdiff_t, not int or size_t, to record sizes.
37 (png_load): Don't assume values greater than 2**31 fit in 'int'.
38 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
39 either works, as we prefer signed integers.
40 (tiff_read_from_memory, tiff_write_from_memory):
41 Return tsize_t, not size_t, since that's what the TIFF API wants.
42 (tiff_read_from_memory): Don't fail simply because the read would
43 go past EOF; instead, return a short read.
44 (tiff_load): Omit no-longer-needed casts.
45 (Fimagemagick_types): Don't assume size fits into 'int'.
46
3cc5a532
PE
47 Improve hashing quality when configured --with-wide-int.
48 * fns.c (hash_string): New function, taken from sxhash_string.
49 Do not discard information about ASCII character case; this
50 discarding is no longer needed.
51 (sxhash-string): Use it. Change sig to match it. Caller changed.
52 * lisp.h: Declare it.
53 * lread.c (hash_string): Remove, since we now use fns.c's version.
54 The fns.c version returns a wider integer if --with-wide-int is
55 specified, so this should help the quality of the hashing a bit.
56
b312a492
PE
57 * emacs.c: Integer overflow minor fix.
58 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
59 Define only if GNU_LINUX.
60 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
61
dfd153ae
PE
62 * dispnew.c: Integer signedness and overflow fixes.
63 Remove unnecessary forward decls, that were a maintenance hassle.
64 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
65 All uses changed.
66 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
67 (scrolling_window): Use ptrdiff_t, not int, for byte count.
68 (prepare_desired_row, line_draw_cost):
69 Use int, not unsigned, where either works.
70 (save_current_matrix, restore_current_matrix):
71 Use ptrdiff_t, not size_t, where either works.
72 (init_display): Check for overflow more accurately, and without
73 relying on undefined behavior.
74
a81d11a3
PE
75 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
76 Remove, replacing with the new symbols in lisp.h. All uses changed.
77 * fileio.c (make_temp_name):
78 * filelock.c (lock_file_1, lock_file):
79 * xdisp.c (message_dolog):
80 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
81 Use pMd etc. instead.
82 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
83 replacing the pWIDE etc. symbols removed from editfns.c.
84
3300e6fd
PE
85 * keyboard.h (num_input_events): Now uintmax_t.
86 This is (very slightly) less likely to mess up due to wraparound.
87 All uses changed.
88
fd05c7e9
PE
89 * buffer.c: Integer signedness fixes.
90 (alloc_buffer_text, enlarge_buffer_text):
91 Use ptrdiff_t rather than size_t when either will do, as we prefer
92 signed integers.
93
5b8ffbdd
PE
94 * bidi.c: Integer signedness and overflow fixes.
95 (bidi_cache_idx, bidi_cache_last_idx, bidi_cache_fetch_state)
96 (bidi_cache_search, bidi_cache_find_level_change)
89bfafe5
PE
97 (bidi_cache_iterator_state, bidi_cache_find)
98 (bidi_find_other_level_edge, bidi_dump_cached_states):
5b8ffbdd
PE
99 Don't arbitrarily limit cache indexes to int; use ptrdiff_t instead.
100 (bidi_cache_size): Use ptrdiff_t rather than size_t, as we prefer
101 signed integers.
102 (elsz): Make it a (signed) constant.
103 (bidi_cache_iterator_state): Check for size-calculation overflow.
104
903fe15d
PE
105 * alloc.c: Integer signedness and overflow fixes.
106 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
107 (__malloc_size_t): Default to size_t, not to int.
108 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
109 (Fgarbage_collect, mark_object_loop_halt, mark_object):
110 Prefer ptrdiff_t to size_t when either would do, as we prefer
111 signed integers.
112 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
113 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
114 Now const. Initialize with values that are in range even if char
115 is signed.
116 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
117 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
118 These functions do the right thing with sizes > 2**32.
119 (check_depth): Now ptrdiff_t, not int.
120 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
121 Adjust to new way of storing sizes. Check for size overflow bugs
122 in rest of code.
123 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
124 slightly wrong anyway, as it missed one instance of
125 XMALLOC_OVERRUN_CHECK_OVERHEAD.
126 (refill_memory_reserve): Omit needless cast to size_t.
127 (mark_object_loop_halt): Mark as externally visible.
128
ac82cc6a
PE
129 * xselect.c: Integer signedness and overflow fixes.
130 (Fx_register_dnd_atom, x_handle_dnd_message):
131 Use ptrdiff_t, not size_t, since we prefer signed.
132 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
133 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
134 x_dnd_atoms_size and x_dnd_atoms_length.
135
c2d1e36d
PE
136 * doprnt.c: Prefer signed to unsigned when either works.
137 * eval.c (verror):
138 * doprnt.c (doprnt):
139 * lisp.h (doprnt):
140 * xdisp.c (vmessage):
141 Use ptrdiff_t, not size_t, when using or implementing doprnt,
142 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
143 prefer signed arithmetic to avoid comparison confusion.
144 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
145 but is a bit tricky.
146
0e926e56
PE
147 Assume freestanding C89 headers, string.h, stdlib.h.
148 * data.c, doprnt.c, floatfns.c, print.c:
149 Include float.h unconditionally.
150 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
151 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
152 * regex.c: Likewise for stddef.h, string.h.
153 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
154 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
155 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
156 (STDC_HEADERS): Remove obsolete defines.
157 * sysdep.c: Include limits.h unconditionally.
158
9cfdb3ec
PE
159 Assume support for memcmp, memcpy, memmove, memset.
160 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
161 * regex.c (memcmp, memcpy):
162 Remove; we assume C89 now.
163
164 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
165 (__malloc_safe_bcopy): Remove; no longer needed.
166
6089c567
PE
167 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
168 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
169 well either way, and we prefer signed to unsigned.
170
cd18e7e3
JB
1712011-07-13 Johan Bockgård <bojohan@gnu.org>
172
173 Fix execution of x selection hooks.
174 * xselect.c (Qx_lost_selection_functions)
175 (Qx_sent_selection_functions): New vars.
176 (syms_of_xselect): DEFSYM them.
177 (x_handle_selection_request): Pass Qx_sent_selection_functions
178 rather than Vx_sent_selection_functions to Frun_hook_with_args.
179 (x_handle_selection_clear,x_clear_frame_selections):
180 Pass Qx_lost_selection_functions rather than
181 Vx_lost_selection_functions to Frun_hook_with_args.
182
47ea7f44
PE
1832011-07-13 Paul Eggert <eggert@cs.ucla.edu>
184
2941c447
PE
185 * buffer.c (Fget_buffer_create): Initialized inhibit_shrinking.
186 The old code sometimes used this field without initializing it.
187
47ea7f44
PE
188 * alloc.c (gc_sweep): Don't read past end of array.
189 In theory, the old code could also have corrupted Emacs internals,
190 though it'd be very unlikely.
191
bc985c87
AS
1922011-07-12 Andreas Schwab <schwab@linux-m68k.org>
193
194 * character.c (Fcharacterp): Don't advertise optional ignored
195 argument. (Bug#4026)
196
0cf34688
LMI
1972011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
198
b3dadd76
LMI
199 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
200 key" (bug#4257).
201
0cf34688
LMI
202 * window.c (Fset_window_start): Doc fix (bug#4199).
203 (Fset_window_hscroll): Ditto.
204
270768cd
PE
2052011-07-12 Paul Eggert <eggert@cs.ucla.edu>
206
077e3dda 207 Fix minor new problems caught by GCC 4.6.1.
270768cd 208 * term.c (init_tty): Remove unused local.
490011a6 209 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 210 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 211 not used otherwise.
270768cd 212
b1f58454
CY
2132011-07-12 Chong Yidong <cyd@stupidchicken.com>
214
215 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
216
22b9578d
LMI
2172011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
218
6e70ab07
LMI
219 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
220 are the mini-buffer and the echo area (bug#3320).
221
22b9578d
LMI
222 * term.c (init_tty): Remove support for supdup, c10 and perq
223 terminals, which are no longer supported (bug#1482).
224
8974cc9f
JB
2252011-07-10 Johan Bockgård <bojohan@gnu.org>
226
227 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
228
a560d974
JD
2292011-07-10 Jan Djärv <jan.h.d@swipnet.se>
230
231 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
232 for non-popups (Bug#3642).
233
1dae0f0a
AS
2342011-07-10 Andreas Schwab <schwab@linux-m68k.org>
235
268c2c36 236 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 237 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
238 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
239 * cm.c (losecursor): Likewise.
1dae0f0a
AS
240 * data.c (fmod): Likewise.
241 * dispnew.c (swap_glyphs_in_rows): Likewise.
242 * emacs.c (memory_warning_signal): Likewise.
243 * floatfns.c (float_error): Likewise.
244 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
245 (otf_open, font_otf_capability, generate_otf_features)
246 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
247 Likewise.
248 * image.c (pbm_read_file): Likewise.
249 * indent.c (string_display_width): Likewise.
250 * intervals.c (check_for_interval, search_for_interval)
251 (inc_interval_count, count_intervals, root_interval)
252 (adjust_intervals_for_insertion, make_new_interval): Likewise.
253 * lread.c (defalias): Likewise.
268c2c36 254 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
255 * regex.c (set_image_of_range_1, set_image_of_range)
256 (regex_grow_registers): Likewise.
257 * sysdep.c (strerror): Likewise.
258 * termcap.c (valid_filename_p, tprint, main): Likewise.
259 * tparam.c (main): Likewise.
260 * unexhp9k800.c (run_time_remap, save_data_space)
261 (update_file_ptrs, read_header, write_header, calculate_checksum)
262 (copy_file, copy_rest, display_header): Likewise.
263 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
264 Likewise.
265 * xdisp.c (check_it): Likewise.
266 * xfaces.c (register_color, unregister_color, unregister_colors):
267 Likewise.
268 * xfns.c (print_fontset_result): Likewise.
269 * xrdb.c (member, fatal, main): Likewise.
270
99033785
PE
2712011-07-10 Paul Eggert <eggert@cs.ucla.edu>
272
273 Fix minor problems found by static checking (Bug#9031).
274 * chartab.c (char_table_set_range, map_sub_char_table):
275 Remove unused locals.
276 (uniprop_table): Now static.
277 * composite.c (_work_char): Remove unused static var.
278
9cb2ac56
JB
2792011-07-09 Juanma Barranquero <lekktu@gmail.com>
280
281 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
282
f25661f0
JD
2832011-07-09 Jan Djärv <jan.h.d@swipnet.se>
284
285 * gtkutil.c (qttip_cb): Remove code without function.
286
8278c4fe
EZ
2872011-07-09 Eli Zaretskii <eliz@gnu.org>
288
289 * w32.c (pthread_sigmask): New stub.
290
1692ae2d 2912011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 292
8a6ebd58 293 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
294 sigprocmask is portable only for single-threaded applications, and
295 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
296 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
297 (LIBES): Use it.
298 * callproc.c (Fcall_process):
299 * process.c (create_process):
300 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
301 Use pthread_sigmask, not sigprocmask.
123403e4 302
1b854618
JD
3032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
304
305 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
306 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
307 wrong (Bug#8591).
308
3fe4b549
JD
3092011-07-08 Jan Djärv <jan.h.d@swipnet.se>
310
0ce7e563
JD
311 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
312 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
313 (xg_hide_tooltip): Fix comment.
314
3fe4b549
JD
315 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
316 in registerServicesMenuSendTypes.
317 (validRequestorForSendType): Don't check ns_return_types.
318
319 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
320 ns_return_type.
321
5df75e47
JR
3222011-07-08 Jason Rumney <jasonr@gnu.org>
323
324 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
325 frame struct members of non-existent frames (Bug#6284).
326
699c10bd
JD
3272011-07-08 Jan Djärv <jan.h.d@swipnet.se>
328
4393663b
JD
329 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
330 variable firstTime not needed on OSX >= 10.6.
331 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
332 >= 10.5. Use setKnobProportion, setDoubleValue.
333
334 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
335 (MAC_OS_X_VERSION_10_5): Define if not defined.
336 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
337 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
338 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
339
340 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
341 cString and lossyCString on OSX >= 10.4
342
343 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
344 sizeToFit on OSX >= 10.2.
345
346 * nsimage.m (allocInitFromFile): Don't use deprecated method
347 bestRepresentationForDevice on OSX >= 10.6.
348
349 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
350 to avoid warning.
351
352 * emacs.c: Declare unexec_init_emacs_zone.
353
a63e0781
JD
354 * nsgui.h: Fix compiler warning about gnulib redefining verify.
355
699c10bd
JD
356 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
357
358 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
359 on svcsMenu (Bug#8842).
360
361 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
362 ns_return_types.
363 (Fns_list_services): Just return Qnil on 10.6, code not working there.
364
365 * nsterm.m (QUTF8_STRING): Declare.
366 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
367 (validRequestorForSendType): Return type is (id).
368 Change indexOfObjectIdenticalTo to indexOfObject.
369 Check if we have local selection before returning self (Bug#8842).
370 (writeSelectionToPasteboard): Put local selection into paste board
371 if we have a local selection (Bug#8842).
372 (syms_of_nsterm): DEFSYM QUTF8_STRING.
373
374 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
375 (ns_get_local_selection): Declare.
376
54e10184
LMI
3772011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
378
9888ff71
LMI
379 * keymap.c (describe_map_tree): Don't insert a double newline at
380 the end of the buffer (bug#1169) and return whether we inserted
381 something.
382
54e10184
LMI
383 * callint.c (Fcall_interactively): Change "reading args" to
384 "providing args" to try to clarify what it does (bug#1010).
385
15fa4783
KH
3862011-07-07 Kenichi Handa <handa@m17n.org>
387
388 * composite.c (composition_compute_stop_pos): Ignore a static
389 composition starting before CHARPOS (Bug#8915).
390
391 * xdisp.c (handle_composition_prop): Likewise.
392
a8815b00
EZ
3932011-07-07 Eli Zaretskii <eliz@gnu.org>
394
395 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
396 (Bug#9015)
397
ef7b981d 3982011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
399
400 * character.h (unicode_category_t): New enum type.
401
402 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
403 (Qchar_code_property_table): New variable.
404 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
405 (UNIPROP_COMPRESSED_FORM_P): New macros.
406 (char_table_ascii): Uncompress the compressed values.
407 (sub_char_table_ref): New arg is_uniprop. Callers changed.
408 Uncompress the compressed values.
409 (sub_char_table_ref_and_range): Likewise.
410 (char_table_ref_and_range): Uncompress the compressed values.
411 (sub_char_table_set): New arg is_uniprop. Callers changed.
412 Uncompress the compressed values.
413 (sub_char_table_set_range): Args changed. Callers changed.
414 (char_table_set_range): Adjuted for the above change.
415 (map_sub_char_table): Delete args default_val and parent. Add arg
416 top. Give decoded values to a Lisp function.
417 (map_char_table): Adjusted for the above change. Give decoded
418 values to a Lisp function. Gcpro more variables.
419 (uniprop_table_uncompress)
420 (uniprop_decode_value_run_length): New functions.
421 (uniprop_decoder, uniprop_decoder_count): New variables.
422 (uniprop_get_decoder, uniprop_encode_value_character)
423 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
424 New functions.
425 (uniprop_encoder, uniprop_encoder_count): New variables.
426 (uniprop_get_encoder, uniprop_table)
427 (Funicode_property_table_internal, Fget_unicode_property_internal)
428 (Fput_unicode_property_internal): New functions.
429 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
430 Sunicode_property_table_internal, Sget_unicode_property_internal,
431 and Sput_unicode_property_internal. Defvar_lisp
432 char-code-property-alist.
433
434 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
435 Vunicode_category_table.
436
437 * font.c (font_range): Adjusted for the change of
438 Vunicode_category_table.
439
76b397fb
DN
4402011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
441
442 * m/iris4d.h: Remove file, move contents ...
443 * s/irix6-5.h: ... here.
444
22b4128e
PE
4452011-07-06 Paul Eggert <eggert@cs.ucla.edu>
446
447 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
448 * alloc.c (mark_buffer):
449 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
450 (clone_per_buffer_values): Don't assume that
22b4128e
PE
451 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
452 This isn't true in general, and it's particularly not true
453 if Emacs is configured with --with-wide-int.
454 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
455 New macros, used in the buffer.c change.
456
869795d6
JD
4572011-07-05 Jan Djärv <jan.h.d@swipnet.se>
458
459 * xsettings.c: Use both GConf and GSettings if both are available.
460 (store_config_changed_event): Add comment.
461 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
462 (store_tool_bar_style_changed): New functions.
463 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
464 (struct xsettings): Move font inside HAVE_XFT.
465 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
466 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
467 Move inside HAVE_XFT.
468 (something_changed_gsettingsCB): Renamed from something_changedCB.
469 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
470 also.
471 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
472 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
473 (something_changed_gconfCB): Renamed from something_changedCB.
474 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
475 (parse_settings): Move check for font inside HAVE_XFT.
476 (read_settings, apply_xft_settings): Add comment.
477 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
478 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
479 call store_font_name_changed.
480 (xft_settings_event): Add comment.
481 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
482 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
483 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
484 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
485 (xsettings_initialize): Call init_gsettings last.
486 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
487 comment.
488
d8ed26bd
PE
4892011-07-05 Paul Eggert <eggert@cs.ucla.edu>
490
491 Random fixes. E.g., (random) never returned negative values.
492 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
493 subseconds part to the entropy, as that's a bit more random.
494 Prefer signed to unsigned, since the signedness doesn't matter and
495 in general we prefer signed. When given a limit, use a
496 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
497 latter isn't right if USE_2_TAGS_FOR_INTS.
498 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
499 not 0..VALMASK. Don't discard "excess" bits that random () returns.
500
cabf1cac
SM
5012011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
502
503 * textprop.c (text_property_stickiness):
504 Obey Vtext_property_default_nonsticky.
505 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
506 * w32fns.c (syms_of_w32fns):
507 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
508
6e9b2be9
PE
5092011-07-04 Paul Eggert <eggert@cs.ucla.edu>
510
511 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
512 This is more efficient than Ffile_directory_p and avoids a minor race.
513
90186c68
LMI
5142011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
515
7c301272
LMI
516 * buffer.c (Foverlay_put): Say what the return value is
517 (bug#7835).
518
c4f2d8d4
LMI
519 * fileio.c (barf_or_query_if_file_exists): Check first if the file
520 is a directory before asking whether to use the file name
521 (bug#7564).
ad637907
LMI
522 (barf_or_query_if_file_exists): Make the "File is a directory"
523 error be more correct.
c4f2d8d4 524
90186c68
LMI
525 * fns.c (Frequire): Remove the mention of the .gz files, since
526 that's installation-specific, but keep the mention of
527 `get-load-suffixes'.
528
da64016e
PE
5292011-07-04 Paul Eggert <eggert@cs.ucla.edu>
530
531 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
532 Report string overflow if the output is too long.
533
7d47b580
JB
5342011-07-04 Juanma Barranquero <lekktu@gmail.com>
535
a555cb87
JB
536 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
537 (syms_of_gnutls): Remove duplicate DEFSYM for
538 Qgnutls_bootprop_verify_hostname_error, an error for
539 Qgnutls_bootprop_verify_error (which is no longer used).
540
7d47b580
JB
541 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
542 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
543 Also (re)move comments that are misplaced or no longer relevant.
544
1e49bfab
LMI
5452011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
546
547 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
548
1485f4c0
CY
5492011-07-03 Chong Yidong <cyd@stupidchicken.com>
550
551 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
552 and background color parameters if they have been changed.
553
a9ab721e
LMI
5542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
555
556 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
557
cf7cff57
PE
5582011-07-03 Paul Eggert <eggert@cs.ucla.edu>
559
2e13213d
PE
560 * xsettings.c (SYSTEM_FONT): Define only when used.
561 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
562
cf7cff57
PE
563 * keymap.c (access_keymap_1): Now static.
564
7a8e04f7
CY
5652011-07-02 Chong Yidong <cyd@stupidchicken.com>
566
567 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
568 leave any prefix arg for the up event (Bug#1586).
569
61352f62
LMI
5702011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
571
69bb1ef7
LMI
572 * lread.c (syms_of_lread): Mention single symbols defined by
573 `defvar' or `defconst' (bug#7154).
574
61352f62 575 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 576 (Frequire): Mention get-load-suffixes.
61352f62 577
28545e04
MR
5782011-07-02 Martin Rudalics <rudalics@gmx.at>
579
580 * window.h (window): Remove clone_number slot.
581 * window.c (Fwindow_clone_number, Fset_window_clone_number):
582 Remove.
583 (make_parent_window, make_window, saved_window)
584 (Fset_window_configuration, save_window_save): Don't deal with
585 clone numbers.
586 * buffer.c (Qclone_number): Remove declaration.
587 (sort_overlays, overlay_strings): Don't deal with clone numbers.
588
3349e122
SM
5892011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
590
591 Add multiple inheritance to keymaps.
592 * keymap.c (Fmake_composed_keymap): New function.
593 (Fset_keymap_parent): Simplify.
594 (fix_submap_inheritance): Remove.
595 (access_keymap_1): New function extracted from access_keymap to handle
596 embedded parents and handle lists of maps.
597 (access_keymap): Use it.
598 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
599 (Fcopy_keymap): Handle embedded parents.
600 (Fcommand_remapping, define_as_prefix): Simplify.
601 (Fkey_binding): Simplify.
602 (syms_of_keymap): Move minibuffer-local-completion-map,
603 minibuffer-local-filename-completion-map,
604 minibuffer-local-must-match-map, and
605 minibuffer-local-filename-must-match-map to Elisp.
606 (syms_of_keymap): Defsubr make-composed-keymap.
607 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
608 (parse_menu_item): Trivial simplification.
609
3279eb87
GM
6102011-07-01 Glenn Morris <rgm@gnu.org>
611
612 * Makefile.in (SETTINGS_LIBS): Fix typo.
613
4550efdf
KI
6142011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
615
616 * coding.c (Fencode_coding_string): Record the last coding system
617 used, as the function doc string says (bug#8738).
618
0949d2b6
JD
6192011-07-01 Jan Djärv <jan.h.d@swipnet.se>
620
621 * xsettings.c (store_monospaced_changed): Take new font as arg and
622 check for change against current_mono_font.
623 (EMACS_TYPE_SETTINGS): Remove this and related defines.
624 (emacs_settings_constructor, emacs_settings_get_property)
625 (emacs_settings_set_property, emacs_settings_class_init)
626 (emacs_settings_init, gsettings_obj): Remove.
627 (something_changedCB): New function for HAVE_GSETTINGS.
628 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
629 with value as argument.
630 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
631 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 632 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
633 "changed".
634
635 * xgselect.c: Add defined (HAVE_GSETTINGS).
636 (xgselect_initialize): Ditto.
637
638 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
639 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
640 xg_select.
641
bbc6b304
PE
6422011-07-01 Paul Eggert <eggert@cs.ucla.edu>
643
644 * eval.c (struct backtrace): Simplify and port the data structure.
645 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
646 signed bit field, as this assumption is not portable and it makes
647 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
648 "char debug_on_exit : 1" as this is not portable either; instead,
649 use the portable "unsigned int debug_on_exit : 1". Remove unused
650 member evalargs. Remove obsolete comments about cc bombing out.
651
9851bfc5
JD
6522011-06-30 Jan Djärv <jan.h.d@swipnet.se>
653
51bb811f 654 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
655 Let HAVE_GSETTINGS override HAVE_GCONF.
656 (store_monospaced_changed): New function.
657 (EMACS_SETTINGS): A new type derived from GObject to handle
658 GSettings notifications.
659 (emacs_settings_constructor, emacs_settings_get_property)
660 (emacs_settings_set_property, emacs_settings_class_init):
661 New functions.
662 (gsettings_client, gsettings_obj): New variables.
663 (GSETTINGS_SCHEMA): New define.
664 (something_changedCB): Call store_monospaced_changed.
665 (init_gsettings): New function.
666 (xsettings_initialize): Call init_gsettings.
667 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
668 to NULL.
669
670 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
671 GCONF_CFLAGS/LIBS.
672
5386012d
MR
6732011-06-29 Martin Rudalics <rudalics@gmx.at>
674
675 * window.c (resize_root_window, grow_mini_window)
676 (shrink_mini_window): Rename Qresize_root_window to
677 Qwindow_resize_root_window and Qresize_root_window_vertically to
678 Qwindow_resize_root_window_vertically.
679
f13e0b08
PE
6802011-06-28 Paul Eggert <eggert@cs.ucla.edu>
681
682 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
683
94515237
JB
6842011-06-27 Juanma Barranquero <lekktu@gmail.com>
685
686 * makefile.w32-in: Redesign dependencies so they reflect more
687 clearly which files are directly included by each source file,
688 and not through other includes.
689
e43b6e43
MR
6902011-06-27 Martin Rudalics <rudalics@gmx.at>
691
692 * buffer.c (Qclone_number): Declare static and DEFSYM it.
693 (sort_overlays, overlay_strings): When an overlay's clone number
694 matches the window's clone number process the overlay even if
695 the overlay's window property doesn't match the current window.
696
d68443dc
MR
697 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
698 (Fwindow_hchild): Rename to Fwindow_left_child.
699 (Fwindow_next): Rename to Fwindow_next_sibling.
700 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
701 (resize_window_check): Rename to window_resize_check.
702 (resize_window_apply): Rename to window_resize_apply.
703 (Fresize_window_apply): Rename to Fwindow_resize_apply.
704 (Fdelete_other_windows_internal, resize_frame_windows)
705 (Fsplit_window_internal, Fdelete_window_internal)
706 (grow_mini_window, shrink_mini_window)
707 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 708
c7e73be5
JD
7092011-06-26 Jan Djärv <jan.h.d@swipnet.se>
710
711 * emacsgtkfixed.h: State that this is only used with Gtk+3.
712 (emacs_fixed_set_min_size): Remove.
713 (emacs_fixed_new): Take frame as argument.
714
715 * emacsgtkfixed.c: State that this is only used with Gtk+3.
716 (_EmacsFixedPrivate): Remove minwidth/height.
717 Add struct frame *f.
718 (emacs_fixed_init): Initialize priv->f.
719 (get_parent_class, emacs_fixed_set_min_size): Remove.
720 (emacs_fixed_new): Set priv->f to argument.
721 (emacs_fixed_get_preferred_width)
722 (emacs_fixed_get_preferred_height): Use min_width/height from
723 frames size_hint to set minimum and natural (Bug#8919).
724 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
725 and use min_width/height from frames size_hint to set
726 min_width/height (Bug#8919).
727
728 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
729 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
730 Fix indentation.
c7e73be5 731
cf99dcf8
EZ
7322011-06-26 Eli Zaretskii <eliz@gnu.org>
733
734 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
735 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
736 called at ZV.
737
029529ac
CY
7382011-06-26 Chong Yidong <cyd@stupidchicken.com>
739
740 * process.c (wait_reading_process_output): Bypass select if
741 waiting for a cell while ignoring keyboard input, and input is
742 pending. Suggested by Jan Djärv (Bug#8869).
743
7a7ef429
PE
7442011-06-25 Paul Eggert <eggert@cs.ucla.edu>
745
746 Use gnulib's dup2 module instead of rolling our own.
747 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
748
11fdef7d 7492011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
750
751 * dispnew.c (scrolling_window): Before scrolling, turn off a
752 mouse-highlight in the window being scrolled.
753
cd3520a4
JB
7542011-06-24 Juanma Barranquero <lekktu@gmail.com>
755
756 Move DEFSYM to lisp.h and use everywhere.
757
758 * character.h (DEFSYM): Move declaration...
759 * lisp.h (DEFSYM): ...here.
760
761 * gnutls.c:
762 * minibuf.c:
763 * w32menu.c:
764 * w32proc.c:
765 * w32select.c: Don't include character.h.
766
767 * alloc.c (syms_of_alloc):
768 * buffer.c (syms_of_buffer):
769 * bytecode.c (syms_of_bytecode):
770 * callint.c (syms_of_callint):
771 * casefiddle.c (syms_of_casefiddle):
772 * casetab.c (init_casetab_once):
773 * category.c (init_category_once, syms_of_category):
774 * ccl.c (syms_of_ccl):
775 * cmds.c (syms_of_cmds):
776 * composite.c (syms_of_composite):
777 * dbusbind.c (syms_of_dbusbind):
778 * dired.c (syms_of_dired):
779 * dispnew.c (syms_of_display):
780 * doc.c (syms_of_doc):
781 * editfns.c (syms_of_editfns):
782 * emacs.c (syms_of_emacs):
783 * eval.c (syms_of_eval):
784 * fileio.c (syms_of_fileio):
785 * fns.c (syms_of_fns):
786 * frame.c (syms_of_frame):
787 * fringe.c (syms_of_fringe):
788 * insdel.c (syms_of_insdel):
789 * keymap.c (syms_of_keymap):
790 * lread.c (init_obarray, syms_of_lread):
791 * macros.c (syms_of_macros):
792 * msdos.c (syms_of_msdos):
793 * print.c (syms_of_print):
794 * process.c (syms_of_process):
795 * search.c (syms_of_search):
796 * sound.c (syms_of_sound):
797 * syntax.c (init_syntax_once, syms_of_syntax):
798 * terminal.c (syms_of_terminal):
799 * textprop.c (syms_of_textprop):
800 * undo.c (syms_of_undo):
801 * w32.c (globals_of_w32):
802 * window.c (syms_of_window):
803 * xdisp.c (syms_of_xdisp):
804 * xfaces.c (syms_of_xfaces):
805 * xfns.c (syms_of_xfns):
806 * xmenu.c (syms_of_xmenu):
807 * xsettings.c (syms_of_xsettings):
808 * xterm.c (syms_of_xterm): Use DEFSYM.
809
4228cf16
TZ
8102011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
811
cd3520a4 812 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 813
7fcccf1e
PE
8142011-06-23 Paul Eggert <eggert@cs.ucla.edu>
815
7efb4e0e
PE
816 Integer and buffer overflow fixes (Bug#8873).
817
ff5844ad
PE
818 * print.c (printchar, strout): Check for string overflow.
819 (PRINTPREPARE, printchar, strout):
820 Don't set size unless allocation succeeds.
821
90532f02
PE
822 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
823 for sizes. Check for string overflow more accurately.
824 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
825
6d84508d
PE
826 * macros.c: Integer and buffer overflow fixes.
827 * keyboard.h (struct keyboard.kbd_macro_bufsize):
828 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
829 Use ptrdiff_t, not int, for sizes.
830 Don't increment bufsize until after realloc succeeds.
831 Check for size-calculation overflow.
832 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
833
437b2cb4
PE
834 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
835
8b9ac8b4
PE
836 * lread.c: Integer overflow fixes.
837 (read_integer): Radix is now EMACS_INT, not int,
838 to improve quality of diagnostics for out-of-range radices.
839 Calculate buffer size correctly for out-of-range radices.
840 (read1): Check for integer overflow in radices, and in
841 read-circle numbers.
82cb60d3
PE
842 (read_escape): Avoid int overflow.
843 (Fload, openp, read_buffer_size, read1)
844 (substitute_object_recurse, read_vector, read_list, map_obarray):
845 Use ptrdiff_t, not int, for sizes.
846 (read1): Use EMACS_INT, not int, for sizes.
20270765 847 Check for size overflow.
8b9ac8b4 848
7fcccf1e
PE
849 * image.c (cache_image): Check for size arithmetic overflow.
850
bfbbd7e7
PE
851 * lread.c: Integer overflow issues.
852 (saved_doc_string_size, saved_doc_string_length)
853 (prev_saved_doc_string_size, prev_saved_doc_string_length):
854 Now ptrdiff_t, not int.
855 (read1): Don't assume doc string length fits in int. Check for
856 out-of-range doc string lengths.
857 (read_list): Don't assume file position fits in int.
39019e54 858 (read_escape): Check for hex character overflow.
bfbbd7e7 859
4e323265
LL
8602011-06-22 Leo Liu <sdl.web@gmail.com>
861
862 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
863 Move to minibuffer.el.
864
85fece3e
PE
8652011-06-22 Paul Eggert <eggert@cs.ucla.edu>
866
20b84ce9 867 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
868 The following patches are for when GLYPH_DEBUG && !XASSERT.
869 * dispextern.h (trace_redisplay_p, dump_glyph_string):
870 * dispnew.c (flush_stdout):
871 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
872 Mark as externally visible.
873 * dispnew.c (check_window_matrix_pointers): Now static.
874 * dispnew.c (window_to_frame_vpos):
875 * xfns.c (unwind_create_frame):
876 * xterm.c (x_check_font): Remove unused local.
877 * scroll.c (CHECK_BOUNDS):
878 * xfaces.c (cache_fache): Rename local to avoid shadowing.
879 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
880 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
881 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
882 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
883 Now static.
884 (debug_method_add): Use va_list and vsprintf rather than relying
885 on undefined behavior with wrong number of arguments.
886 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
887 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
888 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
889 since we're not interested in debugging glyphs with old libraries.
890 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
891 GCC 4.6.0's static checking.
892
0766b489
PE
8932011-06-22 Paul Eggert <eggert@cs.ucla.edu>
894
31fd4b32
PE
895 Integer overflow and signedness fixes (Bug#8873).
896 A few related buffer overrun fixes, too.
897
b79e8648
PE
898 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
899
0766b489
PE
900 * dispextern.h (struct face.stipple):
901 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
902 (x_bitmap_mask, x_allocate_bitmap_record)
903 (x_create_bitmap_from_data, x_create_bitmap_from_file)
904 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
905 (x_create_bitmap_from_xpm_data):
906 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
907 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
908 (.bitmaps_last):
909 * xfaces.c (load_pixmap):
910 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
911 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
912 (.bitmaps_last, struct x_output.icon_bitmap):
913 Use ptrdiff_t, not int, for bitmap indexes.
914 (x_allocate_bitmap_record): Check for size overflow.
915 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
916
b081724f
PE
917 Use ptrdiff_t, not int, for overlay counts.
918 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
919 * editfns.c (overlays_around, get_pos_property):
920 * textprop.c (get_char_property_and_overlay):
921 * xdisp.c (next_overlay_change, note_mouse_highlight):
922 * xfaces.c (face_at_buffer_position):
21514da7
PE
923 * buffer.c (OVERLAY_COUNT_MAX): New macro.
924 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
925 (Fnext_overlay_change, Fprevious_overlay_change)
926 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 927 Use ptrdiff_t, not int, for sizes.
21514da7 928 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 929
3de73e5e
PE
930 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
931
2606c57b
PE
932 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
933 (x_session_initialize): Do not assume string length fits in int.
934
aaafe47a
PE
935 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
936 This is unlikely, but can occur if DPI is outlandish.
937
2674ddc8 938 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
939 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
940
28154962
PE
941 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
942 * xrdb.c (magic_file_p, search_magic_path):
943 Omit last arg SUFFIX; it was always 0. All callers changed.
944 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
945
7de51af5
PE
946 * xfont.c (xfont_match): Avoid need for strlen.
947
25ed6cc3
PE
948 * xfns.c: Don't assume strlen fits in int.
949 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
950
4eab31dd
PE
951 * xdisp.c (message_log_check_duplicate): Return intmax_t,
952 not unsigned long, as we prefer signed integers. All callers changed.
953 Detect integer overflow in repeat count.
954 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 955 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 956
171e2a58
PE
957 * termcap.c: Don't assume sizes fit in int and never overflow.
958 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
959 (gobble_line): Check for size-calculation overflow.
960
ad39faca 961 * minibuf.c (Fread_buffer):
6e5bb2dc 962 * lread.c (intern, intern_c_string):
74ca2eb3
PE
963 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
964 Don't assume string length fits in int.
965
52c61c22 966 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
967 * gtkutil.c (style_changed_cb): Avoid need for strlen.
968
b5b8c9e5
PE
969 * font.c: Don't assume string length fits in int.
970 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
971 Use ptrdiff_t, not int.
ccd6111c
PE
972 (font_intern_prop): Don't assume string length fits in int.
973 Don't assume integer property fits in fixnum.
974 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 975
882f0d81 976 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 977 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
978 Reformulate so as not to need the command string.
979 Invoke gzip -cd rather than gunzip, as it's more portable.
980 (lock_info_type, lock_file_1, lock_file):
981 Don't assume pid_t and time_t fit in unsigned long.
982 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
983 (current_lock_owner): Prefer signed type for sizes.
984 Use memcpy, not strncpy, where memcpy is what is really wanted.
985 Don't assume (via atoi) that time_t and pid_t fit in int.
986 Check for time_t and/or pid_t out of range, e.g., via a network share.
987 Don't alloca where an auto var works fine.
988
93f4cf88
PE
989 * fileio.c: Fix some integer overflow issues.
990 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
991 Don't assume string length fits in int.
992 (directory_file_name): Don't assume string length fits in long.
993 (make_temp_name): Don't assume pid fits in int, or that its print
994 length is less than 20.
995
f3e92b69
PE
996 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
997
1bfdaf10
PE
998 * coding.c (make_subsidiaries): Don't assume string length fits in int.
999
35016e9a
PE
1000 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1001
3d1e65a1
PE
1002 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1003 We prefer signed integers, even for size calculations.
1004
0b963a93
PE
1005 * emacs.c: Don't assume string length fits in 'int'.
1006 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1007 (main): Don't invoke strlen when not needed.
1008
573f4b54
PE
1009 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1010 (XD_DEBUG_MESSAGE): Don't waste a byte.
1011
989f33ba
PE
1012 * callproc.c (getenv_internal_1, getenv_internal)
1013 (Fgetenv_internal):
965d34eb
PE
1014 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1015
e4d29b33
PE
1016 * lread.c (invalid_syntax): Omit length argument.
1017 All uses changed. This doesn't fix a bug, but it simplifies the
1018 code away from its former Hollerith-constant appearance, and it's
1019 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1020 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1021
eb49b136
PE
1022 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1023 This didn't break anything, but it didn't help either.
1024 It's confusing to put a bogus integer in a place where the actual
1025 value does not matter.
9f62aeb1 1026 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1027 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1028
15375a22
PE
1029 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1030 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1031 implementation.
b61cc01c
PE
1032 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1033 We prefer signed types, and the value cannot exceed the EMACS_INT
1034 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1035 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1036 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1037 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1038
53b2623d
PE
1039 * indent.c (sane_tab_width): New function.
1040 (current_column, scan_for_column, Findent_to, position_indentation)
1041 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1042 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1043
51cab52b 1044 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1045
f2ed8a70
PE
1046 * lisp.h (lint_assume): New macro.
1047 * composite.c (composition_gstring_put_cache):
1048 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1049
abe80cc6
PE
1050 * editfns.c, insdel.c:
1051 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1052
b02c740e
PE
1053 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1054
ebc96716
PE
1055 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1056
b4e50fa0 1057 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1058 Use much-faster test for byte-length change.
311d5d7c 1059 Don't assume string byte-length fits in 'int'.
a4cf38e4 1060 Check that character arg fits in 'int'.
85461888 1061 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1062
c0c1ee9f
PE
1063 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1064
a498d7f4
PE
1065 * fns.c (concat): Catch string overflow earlier.
1066 Do not rely on integer wraparound.
1067
51cab52b
PE
1068 * dispextern.h (struct it.overlay_strings_charpos)
1069 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1070 * xdisp.c (forward_to_next_line_start)
1071 (back_to_previous_visible_line_start)
1072 (reseat_at_next_visible_line_start, next_element_from_buffer):
1073 Don't arbitrarily truncate the value of 'selective' to int.
1074
76031fad
PE
1075 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1076
5eb55db9
PE
1077 * composite.c: Don't truncate sizes to 'int'.
1078 (composition_gstring_p, composition_reseat_it)
1079 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1080 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1081 not EMACS_UINT, for indexes.
5eb55db9 1082
0703a717
PE
1083 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1084
d6202519
PE
1085 * buffer.c: Include <verify.h>.
1086 (struct sortvec.priority, struct sortstr.priority):
8961a454 1087 Now EMACS_INT, not int.
c20998a7 1088 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1089 (struct sortstr.size, record_overlay_string)
1090 (struct sortstrlist.size, struct sortlist.used):
1091 Don't truncate size to int.
1092 (record_overlay_string): Check for size-calculation overflow.
d6202519 1093 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1094
d5a19415
JM
10952011-06-22 Jim Meyering <meyering@redhat.com>
1096
029529ac 1097 Don't leak an XBM-image-sized buffer
d5a19415
JM
1098 * image.c (xbm_load): Free the image buffer after using it.
1099
a9041e6c
PE
11002011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1101
1102 Port to Sun C.
1103 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1104 that Sun C diagnosed.
1105 * fns.c (secure_hash): Fix pointer signedness issue.
1106 * intervals.c (static_offset_intervals): New function.
1107 (offset_intervals): Use it.
1108
7f3f739f
LL
11092011-06-21 Leo Liu <sdl.web@gmail.com>
1110
1111 * deps.mk (fns.o):
1112 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1113 sha512.h.
1114
1115 * fns.c (secure_hash): Rename from crypto_hash_function and change
1116 the first arg to accept symbols.
5b66d427 1117 (Fsecure_hash): New primitive.
7f3f739f
LL
1118 (syms_of_fns): New symbols.
1119
76147d94
DD
11202011-06-20 Deniz Dogan <deniz@dogan.se>
1121
1122 * process.c (Fset_process_buffer): Clarify return value in
1123 docstring.
1124
7d7d0045
CY
11252011-06-18 Chong Yidong <cyd@stupidchicken.com>
1126
1127 * dispnew.c (add_window_display_history): Use BVAR.
1128
1129 * xdisp.c (debug_method_add): Use BVAR.
1130 (check_window_end, dump_glyph_matrix, dump_glyph)
1131 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1132
1133 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1134 Likewise.
1135
1136 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1137 check till after the cache is created in init_frame_faces.
1138
ff2bc410
SM
11392011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1140
1141 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1142
28177add
PE
11432011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1144
dd3482fe
PE
1145 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1146 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1147 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1148
393d71f3 1149 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1150 * fileio.c (Finsert_file_contents):
1151 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1152 Remove the old (too-loose) buffer overflow checks.
1153 They weren't needed, since make_gap checks for buffer overflow.
1154 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1155 The old code merely checked for Emacs fixnum overflow, and relied
1156 on undefined (wraparound) behavior. The new code avoids undefined
1157 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1158
2e6813b0 1159 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1160 Tune. Don't use wider integers than needed. Don't use alloca.
1161 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1162
599a9e4f
PE
1163 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1164
99561444
PE
1165 * insdel.c, lisp.h (buffer_overflow): New function.
1166 (insert_from_buffer_1, replace_range, replace_range_2):
1167 * insdel.c (make_gap_larger):
1168 * editfns.c (Finsert_char):
1169 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1170
28177add
PE
1171 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1172
e69dafad
PE
11732011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1174
a7af7fde 1175 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1176
b1c46f02
PE
1177 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1178 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1179
e69dafad
PE
1180 * fileio.c: Don't assume EMACS_INT fits in off_t.
1181 (emacs_lseek): New static function.
1182 (Finsert_file_contents, Fwrite_region): Use it.
1183 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1184
566684ea
PE
1185 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1186
e6966cd6
PE
1187 * fns.c: Don't overflow int when computing a list length.
1188 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1189 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1190 truncation on 64-bit hosts. Check for QUIT every
1191 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1192 faster and is responsive enough.
1193 (Flength): Report an error instead of overflowing an integer.
1194 (Fsafe_length): Return a float if the value is not representable
1195 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1196 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1197 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1198
dd0b0efb
PE
1199 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1200 (header_size, word_size): New constants.
1201 (allocate_vectorlike): Don't check size overflow here.
1202 (allocate_vector): Check it here instead, since this is the only
1203 caller of allocate_vectorlike that could cause overflow.
1204 Check that the new vector's length is representable as a fixnum.
1205
86fe5cfe
PE
1206 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1207 The previous code was bogus. For example, next_almost_prime (32)
1208 returned 39, which is undesirable as it is a multiple of 3; and
1209 next_almost_prime (24) returned 25, which is a multiple of 5 so
1210 why was the code bothering to check for multiples of 7?
1211
80e88859
PE
1212 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1213
4a2f0ad6
PE
1214 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1215
f66c7cf8
PE
1216 Variadic C functions now count arguments with ptrdiff_t.
1217 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1218 Back then I didn't know that the Emacs coding style prefers signed int.
1219 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1220 were being counted with int, which may truncate counts on 64-bit
1221 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1222 * lisp.h (struct Lisp_Subr.function.aMANY)
1223 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1224 Arg counts are now ptrdiff_t, not size_t.
1225 All variadic functions and their callers changed accordingly.
1226 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1227 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1228 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1229 * callint.c (Fcall_interactively): Check arg count for overflow,
1230 to avoid potential buffer overrun. Use signed char, not 'int',
1231 for 'varies' array, so that we needn't bother to check its size
1232 calculation for overflow.
1233 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1234 * eval.c (apply_lambda):
1235 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1236 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1237 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1238
a1759b76
PE
1239 * callint.c (Fcall_interactively): Don't use index var as event count.
1240
d96be9fc
PE
1241 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1242 * mem-limits.h (SIZE): Remove; no longer used.
1243
a690a978 1244 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1245
578c21e6
PE
1246 Remove unnecessary casts.
1247 * xterm.c (x_term_init):
1248 * xfns.c (x_set_border_pixel):
1249 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1250 These aren't needed now that we assume ANSI C.
1251
96f53c6c
PE
1252 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1253 It's more likely to cause problems (due to unsigned overflow)
1254 than to cure them.
1255
83c77d31
PE
1256 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1257
ee2079f1
PE
1258 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1259
6da65536
PE
1260 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1261
7147c4a4
PE
1262 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1263
193e32d9
PE
1264 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1265
e5533da6
PE
1266 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1267
9910e595
PE
1268 GLYPH_CODE_FACE returns EMACS_INT, not int.
1269 * dispextern.h (merge_faces):
1270 * xfaces.c (merge_faces):
01103c44
PE
1271 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1272 Don't assume EMACS_INT fits in int.
9910e595 1273
2638320e
PE
1274 * character.h (CHAR_VALID_P): Remove unused parameter.
1275 * fontset.c, lisp.h, xdisp.c: All uses changed.
1276
045eb8d9
PE
1277 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1278
c1f134b5
PE
1279 * fns.c (concat): Minor tuning based on overflow analysis.
1280 This doesn't fix any bugs. Use int to hold character, instead
1281 of constantly refetching from Emacs object. Use XFASTINT, not
1282 XINT, for value known to be a character. Don't bother comparing
1283 a single byte to 0400, as it's always less.
1284
395fcb93 1285 * floatfns.c (Fexpt):
327eeec8
PE
1286 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1287
abbd3d23
PE
1288 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1289 for characters.
1290
684a03ef
PE
1291 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1292
0fed43f3
PE
1293 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1294 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1295 incorrectly succeed when S was a string, because 4294967386 was
1296 truncated before it was used.
1297
8fd02eb7
PE
1298 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1299 Otherwise, an out-of-range integer could cause undefined behavior
1300 on a 64-bit host.
1301
f8c86b69
PE
1302 * composite.c: Use int, not EMACS_INT, for characters.
1303 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1304 EMACS_INT, for values that are known to be in character range.
1305 This doesn't fix any bugs but is the usual style inside Emacs and
1306 may generate better code on 32-bit machines.
1307
34206dd2
PE
1308 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1309 This is for reasons similar to the recent CHAR_STRING fix.
1310 * charset.c (Fencode_char): Check that character arg is actually
1311 a character. Pass an int to ENCODE_CHAR.
1312 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1313 wider than 'int', as a compile-time check to prevent future regressions
1314 in this area.
1315
c5958d4c 1316 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1317
1318 Make sure a 64-bit char is never passed to CHAR_STRING.
1319 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1320 by silently ignoring the top 32 bits, allowing some values
1321 that were far too large to be valid characters.
1322 * character.h: Include <verify.h>.
1323 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1324 arguments are no wider than unsigned, as a compile-time check
1325 to prevent future regressions in this area.
1326 * data.c (Faset):
01103c44 1327 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1328 (Fsubst_char_in_region):
1329 * fns.c (concat):
1330 * xdisp.c (decode_mode_spec_coding):
1331 Adjust to CHAR_STRING's new requirement.
1332 * editfns.c (Finsert_char, Fsubst_char_in_region):
1333 * fns.c (concat): Check that character args are actually
1334 characters. Without this test, these functions did the wrong
1335 thing with wildly out-of-range values on 64-bit hosts.
1336
d37ca623
PE
1337 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1338 These casts should not be needed on 32-bit hosts, either.
1339 * keyboard.c (read_char):
1340 * lread.c (Fload): Remove casts to unsigned.
1341
ea204efb
PE
1342 * lisp.h (UNSIGNED_CMP): New macro.
1343 This fixes comparison bugs on 64-bit hosts.
1344 (ASCII_CHAR_P): Use it.
1345 * casefiddle.c (casify_object):
01103c44 1346 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1347 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1348 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1349 * dispextern.h (FACE_FROM_ID):
1350 * keyboard.c (read_char): Use UNSIGNED_CMP.
1351
41cb286c
PE
1352 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1353 not to EMACS_INT, to avoid GCC warning.
1354
4a1b9832
PE
1355 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1356
55daad71
PE
1357 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1358 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1359 isn't needed on 32-bit machines.
8f95c75c 1360
01103c44
PE
1361 * buffer.c (Fgenerate_new_buffer_name):
1362 Use EMACS_INT for count, not int.
0ceccced 1363 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1364
1365 * data.c (Qcompiled_function): Now static.
1366
c6f072e7
PE
1367 * window.c (window_body_lines): Now static.
1368
20ce5912
PE
1369 * image.c (gif_load): Rename local to avoid shadowing.
1370
9c4c5f81
PE
1371 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1372 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1373 * alloc.c (make_save_value): Integer argument is now of type
1374 ptrdiff_t, not int.
1375 (mark_object): Use ptrdiff_t, not int.
1376 * lisp.h (pD): New macro.
1377 * print.c (print_object): Use it.
1378
c0c5c8ae
PE
1379 * alloc.c: Use EMACS_INT, not int, to count objects.
1380 (total_conses, total_markers, total_symbols, total_vector_size)
1381 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1382 (total_free_floats, total_floats, total_free_intervals)
1383 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1384 Now EMACS_INT, not int. All uses changed.
1385 (Fgarbage_collect): Compute overall total using a double, so that
1386 integer overflow is less likely to be a problem. Check for overflow
1387 when converting back to an integer.
5a25e253
PE
1388 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1389 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1390 These were 'int' variables that could overflow on 64-bit hosts;
1391 they were never used, so remove them instead of repairing them.
211a0b2a 1392 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1393 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1394 Previously, this ceilinged at INT_MAX, but that doesn't work on
1395 64-bit machines.
e46bb31a 1396 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1397
c78baabf 1398 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1399 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1400 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1401 when a (possibly-narrower) signed value would do just as well.
1402 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1403
c9d624c6
PE
1404 * alloc.c: Catch some string size overflows that we were missing.
1405 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1406 for convenience in STRING_BYTES_MAX.
1407 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1408 The definition here is exact; the one in lisp.h was approximate.
1409 (allocate_string_data): Check for string overflow. This catches
1410 some instances we weren't catching before. Also, it catches
1411 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1412 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1413 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1414
c9d624c6
PE
1415 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1416 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1417 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1418
353032ce
PE
1419 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1420
2bccce07
PE
1421 * alloc.c (Fmake_string): Check for out-of-range init.
1422
0ac30604
SM
14232011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1424
1425 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1426
c195f2de
JD
14272011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1428
1429 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1430 xg_get_default_scrollbar_width.
1431
1432 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1433 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1434 (style_changed_cb): Call update_theme_scrollbar_width and call
1435 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1436 all frames (Bug#8505).
1437 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1438 Call gtk_window_set_resizable if HAVE_GTK3.
1439 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1440 and height if HAVE_GTK3 (Bug#8505).
1441 (scroll_bar_width_for_theme): New variable.
1442 (update_theme_scrollbar_width): New function.
1443 (xg_get_default_scrollbar_width): Move code to
1444 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1445 (xg_initialize): Call update_theme_scrollbar_width.
1446
1447 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1448
1449 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1450
e10ac9f1
MR
14512011-06-12 Martin Rudalics <rudalics@gmx.at>
1452
1453 * frame.c (make_frame): Call other_buffer_safely instead of
1454 other_buffer.
1455
1456 * window.c (temp_output_buffer_show): Call display_buffer with
1457 second argument Vtemp_buffer_show_specifiers and reset latter
1458 immediately after the call.
1459 (Vtemp_buffer_show_specifiers): New variable.
1460 (auto_window_vscroll_p, next_screen_context_lines)
1461 (Vscroll_preserve_screen_position): Remove leading asterisks from
1462 doc-strings.
1463
2d3c217e 14642011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1465
7b7f97e8 1466 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1467 * buffer.c (Qclone_number): Remove for now, as it's unused.
1468 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1469 (record_buffer): Remove unused local.
1470 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1471 (set_frame_buffer_list): Remove; unused.
1472 * frame.h (other_visible_frames): Remove decl.
1473 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1474 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1475 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1476 if HAVE_GPM.
1477 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1478 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1479 Define only if HAVE_GPM.
1480 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1481 (update_hints_inhibit): Remove; never set. All uses removed.
1482 * widgetprv.h (emacsFrameClassRec): Remove decl.
1483 * window.c (delete_deletable_window): Now returns void, since it
1484 wasn't returning anything.
1485 (compare_window_configurations): Remove unused locals.
1486 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1487 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1488 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1489 the same widths as pointers. This follows up on the 2011-05-06 patch.
1490 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1491 * xterm.h: Likewise.
1492 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1493
1384b89e
JB
14942011-06-12 Juanma Barranquero <lekktu@gmail.com>
1495
1496 * makefile.w32-in: Update dependencies.
1497 (LISP_H): Add lib/intprops.h.
1498
1100a63c
CY
14992011-06-11 Chong Yidong <cyd@stupidchicken.com>
1500
1501 * image.c (gif_load): Add animation frame delay to the metadata.
1502 (syms_of_image): Use DEFSYM. New symbol `delay'.
1503
6198ccd0
MR
15042011-06-11 Martin Rudalics <rudalics@gmx.at>
1505
1506 * window.c (delete_deletable_window): Re-add.
1507 (Fset_window_configuration): Rewrite to handle dead buffers and
1508 consequently deletable windows.
1509 (window_tree, Fwindow_tree): Remove. Supply functionality in
1510 window.el.
1511 (compare_window_configurations): Simplify code.
1512
b6e3633c
AS
15132011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1514
1ab0dee5
AS
1515 * image.c (imagemagick_load_image): Fix type mismatch.
1516 (Fimagemagick_types): Likewise.
1517
b6e3633c
AS
1518 * window.h (replace_buffer_in_windows): Declare.
1519
9397e56f
MR
15202011-06-11 Martin Rudalics <rudalics@gmx.at>
1521
1522 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1523 Qclone_number. Remove external declaration of Qdelete_window.
1524 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1525 code.
1526 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1527 Qbuffer_list_update_hook if allowed.
1528 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1529 buffer list implementation.
1530 (other_buffer_safely): New function.
1531 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1532 calls to replace_buffer_in_windows and
1533 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1534 if allowed.
1535 (record_buffer): Inhibit quitting and rewrite using quittable
1536 functions. Run Qbuffer_list_update_hook if allowed.
1537 (Frecord_buffer, Funrecord_buffer): New functions.
1538 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1539 switch-to-buffer to window.el.
1540 (bury-buffer): Move to window.el.
1541 (Vbuffer_list_update_hook): New variable.
1542
1543 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1544 section.
1545
1546 * window.h (resize_frame_windows): Move up in code.
1547 (Fwindow_frame): Remove EXFUN.
1548 (replace_buffer_in_all_windows): Remove prototype.
1549 (replace_buffer_in_windows_safely): Add prototype.
1550
1551 * window.c: Declare Qdelete_window static again. Move down
1552 declaration of select_count.
1553 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1554 (Fother_window): Move to window.el.
1555 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1556 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1557 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1558 window.el.
1559 (replace_buffer_in_windows): Implement by calling
1560 Qreplace_buffer_in_windows.
1561 (replace_buffer_in_all_windows): Remove with some functionality
1562 moved into replace_buffer_in_windows_safely.
1563 (replace_buffer_in_windows_safely): New function.
1564 (select_window_norecord, select_frame_norecord): Move in front
1565 of run_window_configuration_change_hook. Remove now obsolete
1566 declarations.
1567 (Fset_window_buffer): Rewrite doc-string. Call
1568 Qrecord_window_buffer.
1569 (keys_of_window): Move binding for other-window to window.el.
1570
b50691aa
CY
15712011-06-11 Chong Yidong <cyd@stupidchicken.com>
1572
1573 * dispextern.h (struct image): Replace data member, whose int_val
1574 and ptr_val fields were not used by anything, with a single
1575 lisp_val object.
1576
1577 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1578 (gif_clear_image, gif_load, imagemagick_load_image)
1579 (gs_clear_image, gs_load): Callers changed.
1580
3f754b86
PE
15812011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1582
cca69397
PE
1583 * buffer.h: Include <time.h>, for time_t.
1584 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1585
109e28d0
PE
1586 Fix minor problems found by static checking.
1587
60737f02
PE
1588 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1589
4b66faf3
PE
1590 Make identifiers static if they are not used in other modules.
1591 * data.c (Qcompiled_function, Qframe, Qvector):
1592 * image.c (QimageMagick, Qsvg):
1593 * minibuf.c (Qmetadata):
1594 * window.c (resize_window_check, resize_root_window): Now static.
1595 * window.h (resize_window_check, resize_root_window): Remove decls.
1596
109e28d0
PE
1597 * window.c (window_deletion_count, delete_deletable_window):
1598 Remove; unused.
46a4ce9e
PE
1599 (window_body_lines): Now static.
1600 (Fdelete_other_windows_internal): Mark vars as initialized.
1601 Make sure 'resize_failed' is initialized.
1602 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1603 (resize_window_apply): Remove unused local.
1604 * window.h (delete_deletable_window): Remove decl.
1605
109e28d0 1606 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1607 (imagemagick_load_image): Fix pointer signedness problem by changing
1608 last arg from unsigned char * to char *. All uses changed.
1609 Also, fix a local for similar reasons.
1610 Remove unused locals. Remove locals to avoid shadowing.
1611 (fn_rsvg_handle_free): Remove; unused.
1612 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1613 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1614
3f754b86
PE
1615 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1616
2547adb1
CY
16172011-06-10 Chong Yidong <cyd@stupidchicken.com>
1618
1619 * image.c (gif_load): Fix omitted cast error introduced by
1620 2011-06-06 change.
1621
2c8e37d4
MR
16222011-06-10 Martin Rudalics <rudalics@gmx.at>
1623
1624 * window.h (resize_proportionally, orig_total_lines)
1625 (orig_top_line): Remove from window structure.
1626 (set_window_height, set_window_width, change_window_heights)
1627 (Fdelete_window): Remove prototypes.
1628 (resize_frame_windows): Remove duplicate declaration.
1629
440a42e3
EZ
16302011-06-10 Eli Zaretskii <eliz@gnu.org>
1631
1632 * window.h (resize_frame_windows, resize_window_check)
1633 (delete_deletable_window, resize_root_window)
1634 (resize_frame_windows): Declare prototypes.
1635
1636 * window.c (resize_window_apply): Make definition be "static" to
1637 match the prototype.
1638
562dd5e9
MR
16392011-06-10 Martin Rudalics <rudalics@gmx.at>
1640
1641 * window.c: Remove declarations of Qwindow_size_fixed,
1642 window_min_size_1, window_min_size_2, window_min_size,
1643 size_window, window_fixed_size_p, enlarge_window, delete_window.
1644 Remove static from declaration of Qdelete_window, it's
1645 temporarily needed by Fbury_buffer.
1646 (replace_window): Don't assign orig_top_line and
1647 orig_total_lines.
1648 (Fdelete_window, delete_window): Remove. Window deletion is
1649 handled by window.el.
1650 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1651 Fdelete_window calls with calls to Qdelete_window.
1652 (Fdelete_other_windows): Remove. Deleting other windows is
1653 handled by window.el.
1654 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1655 handled in window.el.
1656 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1657 Window minimum sizes are handled in window.el.
1658 (shrink_windows, size_window, set_window_height)
1659 (set_window_width, change_window_heights, window_height)
1660 (window_width, CURBEG, CURSIZE, enlarge_window)
1661 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1662 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1663 handled in window.el.
1664 (make_dummy_parent): Rename to make_parent_window and give it a
1665 second argument horflag.
1666 (make_window): Don't set resize_proportionally any more.
1667 (Fsplit_window): Remove. Windows are split in window.el.
1668 (save_restore_action, save_restore_orig_size)
1669 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1670 Resize mini windows in window.el.
1671 (grow_mini_window, shrink_mini_window): Implement by calling
1672 Qresize_root_window_vertically, resize_window_check and
1673 resize_window_apply.
1674 (saved_window, Fset_window_configuration, save_window_save): Do
1675 not handle orig_top_line, orig_total_lines, and
1676 resize_proportionally.
1677 (window_min_height, window_min_width): Move to window.el.
1678 (keys_of_window): Move bindings for delete-other-windows,
1679 split-window, delete-window and enlarge-window to window.el.
1680
1681 * buffer.c: Temporarily extern Qdelete_window.
1682 (Fbury_buffer): Temporarily call Qdelete_window instead of
1683 Fdelete_window (Fbury_buffer will move to window.el soon).
1684
1685 * frame.c (set_menu_bar_lines_1): Remove code handling
1686 orig_top_line and orig_total_lines.
1687
1688 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1689 set_window_height but set heights directly.
1690 (change_frame_size_1): Use resize_frame_windows.
1691
1692 * xdisp.c (init_xdisp): Don't use set_window_height but set
1693 heights directly.
1694
1695 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1696 resize_frame_windows instead of change_window_heights and run
1697 run_window_configuration_change_hook.
1698
1699 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1700 instead of change_window_heights and run
1701 run_window_configuration_change_hook.
1702
1a13852e
MR
17032011-06-09 Martin Rudalics <rudalics@gmx.at>
1704
1705 * window.c (replace_window): Rename second argument REPLACEMENT to
1706 NEW. New third argument SETFLAG. Rewrite.
1707 (delete_window, make_dummy_parent): Call replace_window with
1708 third argument 1.
1709 (window_list_1): Move down in code.
1710 (run_window_configuration_change_hook): Move set_buffer part
1711 before select_frame_norecord part in order to unwind correctly.
1712 Rename count1 to count.
1713 (recombine_windows, delete_deletable_window, resize_root_window)
1714 (Fdelete_other_windows_internal)
1715 (Frun_window_configuration_change_hook, make_parent_window)
1716 (resize_window_check, resize_window_apply, Fresize_window_apply)
1717 (resize_frame_windows, Fsplit_window_internal)
1718 (Fdelete_window_internal, Fresize_mini_window_internal): New
1719 functions.
1720 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1721
f3d1777e
MR
17222011-06-08 Martin Rudalics <rudalics@gmx.at>
1723
496e208e
MR
1724 * window.h (window): Add some new members to window structure -
1725 normal_lines, normal_cols, new_total, new_normal, clone_number,
1726 splits, nest, prev_buffers, next_buffers.
1727 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1728 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1729
f3d1777e
MR
1730 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1731 Remove.
496e208e
MR
1732 (make_dummy_parent): Set new members of windows structure.
1733 (make_window): Move down in code. Handle new members of window
1734 structure.
1735 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1736 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1737 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1738 (Fset_window_prev_buffers, Fwindow_next_buffers)
1739 (Fset_window_next_buffers, Fset_window_clone_number): New
1740 functions.
1741 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1742 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1743 Doc-string fixes.
1744 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1745 Argument WINDOW can be now internal window too.
1746 (Fwindow_use_time): Move up in code.
1747 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1748 Rewrite doc-string.
1749 (Fset_window_configuration, saved_window)
1750 (Fcurrent_window_configuration, save_window_save): Handle new
1751 members of window structure.
b9e809c2
MR
1752 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1753 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1754 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1755 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1756 Qget_mru_window, Qresize_root_window,
1757 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1758 Qauto_buffer_name; staticpro them.
f3d1777e 1759
abde8f8c
MR
17602011-06-07 Martin Rudalics <rudalics@gmx.at>
1761
1762 * window.c (Fwindow_total_size, Fwindow_left_column)
1763 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1764 (Fwindow_list_1): New functions.
1765 (window_box_text_cols): Replace with window_body_cols.
1766 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1767 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1768 (delete_window, Fset_window_configuration): Call
1769 delete_all_subwindows with window as argument.
1770 (delete_all_subwindows): Take a window as argument and not a
1771 structure. Rewrite.
190b47e6
MR
1772 (window_loop): Remove handling of GET_LRU_WINDOW and
1773 GET_LARGEST_WINDOW.
1774 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1775
1776 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1777 window_box_text_cols. delete_all_subwindows now takes a
1778 Lisp_Object as argument.
abde8f8c
MR
1779
1780 * indent.c (compute_motion, Fcompute_motion): Use
1781 window_body_cols instead of window_box_text_cols.
1782
fa8a67e6
MR
1783 * frame.c (delete_frame): Call delete_all_subwindows with root
1784 window as argument.
1785
a54e3482
DC
17862011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1787
1788 * fns.c (Fputhash): Document return value.
1789
60002bf5
CY
17902011-06-06 Chong Yidong <cyd@stupidchicken.com>
1791
1792 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1793
0c671da6 17942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1795
b862a52a 1796 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1797
be44ca6c
PE
1798 Check for overflow when converting integer to cons and back.
1799 * charset.c (Fdefine_charset_internal, Fdecode_char):
1800 Use cons_to_unsigned to catch overflow.
1801 (Fencode_char): Use INTEGER_TO_CONS.
1802 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1803 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1804 * data.c (long_to_cons, cons_to_long): Remove.
1805 (cons_to_unsigned, cons_to_signed): New functions.
1806 These signal an error for invalid or out-of-range values.
1807 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1808 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1809 * font.c (Ffont_variation_glyphs):
1810 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1811 * lisp.h: Include <intprops.h>.
1812 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1813 (cons_to_signed, cons_to_unsigned): New decls.
1814 (long_to_cons, cons_to_long): Remove decls.
1815 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1816 (Fprimitive_undo): Use CONS_TO_INTEGER.
1817 * xfns.c (Fx_window_property): Likewise.
1818 * xselect.c: Include <limits.h>.
1819 (x_own_selection, selection_data_to_lisp_data):
1820 Use INTEGER_TO_CONS.
1821 (x_handle_selection_request, x_handle_selection_clear)
1822 (x_get_foreign_selection, Fx_disown_selection_internal)
1823 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1824 (lisp_data_to_selection_data): Use cons_to_unsigned.
1825 (x_fill_property_data): Use cons_to_signed.
1826 Report values out of range.
1827
d1f3d2af
PE
1828 Check for buffer and string overflow more precisely.
1829 * buffer.h (BUF_BYTES_MAX): New macro.
1830 * lisp.h (STRING_BYTES_MAX): New macro.
1831 * alloc.c (Fmake_string):
1832 * character.c (string_escape_byte8):
1833 * coding.c (coding_alloc_by_realloc):
1834 * doprnt.c (doprnt):
1835 * editfns.c (Fformat):
1836 * eval.c (verror):
1837 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1838 since they may not be the same number.
1839 * editfns.c (Finsert_char):
1840 * fileio.c (Finsert_file_contents):
1841 Likewise for BUF_BYTES_MAX.
1842
dd52fcea
PE
1843 * image.c: Use ptrdiff_t, not int, for sizes.
1844 (slurp_file): Switch from int to ptrdiff_t.
1845 All uses changed.
1846 (slurp_file): Check that file size fits in both size_t (for
1847 malloc) and ptrdiff_t (for sanity and safety).
1848
7f9bbdbb
PE
1849 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1850 if b->modtime has its maximal value.
1851
dfe18f82
PE
1852 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1853
84acfcf0
PE
1854 Don't assume time_t can fit into int.
1855 * buffer.h (struct buffer.modtime): Now time_t, not int.
1856 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1857 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1858
ccd9a01a
PE
1859 Minor fixes for signed vs unsigned integers.
1860 * character.h (MAYBE_UNIFY_CHAR):
1861 * charset.c (maybe_unify_char):
1862 * keyboard.c (read_char, reorder_modifiers):
1863 XINT -> XFASTINT, since the integer must be nonnegative.
1864 * ftfont.c (ftfont_spec_pattern):
1865 * keymap.c (access_keymap, silly_event_symbol_error):
1866 XUINT -> XFASTINT, since the integer must be nonnegative.
1867 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1868 since it makes no difference and we prefer signed.
1869 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1870 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1871 nonnegative.
1872
d6d100dd
SM
18732011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1874
1875 * window.h (Fwindow_frame): Declare.
1876
2b6148e4
PE
18772011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1878
1879 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1880 (SPARE_MEMORY): Always define.
1881 (LARGE_REQUEST): Remove.
1882 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1883
f230ecc9
MR
18842011-06-06 Martin Rudalics <rudalics@gmx.at>
1885
727e958e
MR
1886 * lisp.h: Move EXFUNS for Fframe_root_window,
1887 Fframe_first_window and Fset_frame_selected_window to window.h.
1888
1889 * window.h: Move EXFUNS for Fframe_root_window,
1890 Fframe_first_window and Fset_frame_selected_window here from
1891 lisp.h.
1892
1893 * frame.c (Fwindow_frame, Fframe_first_window)
1894 (Fframe_root_window, Fframe_selected_window)
1895 (Fset_frame_selected_window): Move to window.c.
1896 (Factive_minibuffer_window): Move to minibuf.c.
1897 (Fother_visible_frames_p): New function.
1898
1899 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1900
f230ecc9
MR
1901 * window.c (decode_window, decode_any_window): Move up in code.
1902 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1903 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1904 (Fwindow_buffer): Move up and rewrite doc-string.
1905 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1906 (Fwindow_prev): New functions.
727e958e
MR
1907 (Fwindow_frame): Move here from frame.c. Accept any window as
1908 argument.
1909 (Fframe_root_window, Fframe_first_window)
1910 (Fframe_selected_window): Move here from frame.c. Accept frame
1911 or arbitrary window as argument. Update doc-strings.
1912 (Fminibuffer_window): Move up in code.
1913 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1914 (Fset_frame_selected_window): Move here from frame.c.
1915 Marginal rewrite.
727e958e
MR
1916 (Fselected_window, select_window, Fselect_window): Move up in
1917 code. Minor doc-string fixes.
f230ecc9 1918
4d09bcf6
PE
19192011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1920
1921 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1922 Do not assume that spare memory exists; that assumption is valid
1923 only if SYSTEM_MALLOC.
1924 (LARGE_REQUEST): New macro, so that the issue of large requests
1925 is separated from the issue of spare memory.
1926
810928a2
AS
19272011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1928
172418ad
AS
1929 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1930 format. (Bug#8806)
1931
43f862f7
AS
1932 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1933
810928a2
AS
1934 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1935 before statements.
1936
a059fe24
JD
19372011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1938
1939 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1940
1941 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1942
1943 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1944 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1945
989bf368
JB
19462011-06-05 Juanma Barranquero <lekktu@gmail.com>
1947
1948 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1949
4b80f674
CY
19502011-06-04 Chong Yidong <cyd@stupidchicken.com>
1951
1952 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1953 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1954 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1955 New error handlers.
4b80f674
CY
1956 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1957 Obey Vx_select_enable_clipboard_manager. Catch errors in
1958 x_clipboard_manager_save (Bug#8779).
1959 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1960 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1961
99a33b77 19622011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1963
1964 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1965
99a33b77 19662011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1967
1968 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1969 in the current matrix if keep_current_p is non-zero.
1970
8264569d
EZ
19712011-06-04 Eli Zaretskii <eliz@gnu.org>
1972
1973 * bidi.c (bidi_level_of_next_char): Fix last change.
1974
57f97249
EZ
19752011-06-03 Eli Zaretskii <eliz@gnu.org>
1976
fec2107c 1977 Support bidi reordering of text covered by display properties.
57f97249 1978
fec2107c
EZ
1979 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1980 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1981 (bidi_cache_search, bidi_cache_iterator_state)
1982 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1983 (bidi_level_of_next_char, bidi_move_to_visually_next):
1984 Support character positions inside a run of characters covered by a
fec2107c
EZ
1985 display string.
1986 (bidi_paragraph_init, bidi_resolve_explicit_1)
1987 (bidi_level_of_next_char): Call bidi_fetch_char and
1988 bidi_fetch_char_advance instead of FETCH_CHAR and
1989 FETCH_CHAR_ADVANCE.
1990 (bidi_init_it): Initialize new members.
1991 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1992 definitions.
1993 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1994 instead of using explicit *_CHAR codes.
d6d100dd
SM
1995 (bidi_resolve_explicit, bidi_resolve_weak):
1996 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1997 bidirectional text is supported only in multibyte buffers.
1998 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1999 it to initialize the frame_window_p member of struct bidi_it.
2000 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2001 (bidi_resolve_explicit, bidi_resolve_weak)
2002 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2003 bidi_it->nchars is non-positive.
2004 (bidi_level_of_next_char): Don't try to lookup the cache for the
2005 next/previous character if nothing is cached there yet, or if we
2006 were just reseat()'ed to a new position.
c40e2fb2 2007
0e14fe90
EZ
2008 * xdisp.c (set_cursor_from_row): Set start and stop points
2009 according to the row's direction when priming the loop that looks
2010 for the glyph on which to display cursor.
2011 (single_display_spec_intangible_p): Function deleted.
2012 (display_prop_intangible_p): Reimplement to call
2013 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2014 Accept 3 additional arguments needed by handle_display_spec.
2015 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2016 values: lists, `(when COND...)' forms, etc.
2017 (single_display_spec_string_p): Support property values that are
2018 lists with the argument STRING its top-level element.
2019 (display_prop_string_p): Fix the condition for processing a
2020 property that is a list to be consistent with handle_display_spec.
fec2107c 2021 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2022 last portion of handle_display_prop.
2023 (compute_display_string_pos): Accept additional argument
2024 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2025 value of a `display' property is a "replacing spec".
2026 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2027 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2028 the display property, but just return a value indicating whether
2029 the display property will replace the characters it covers.
2030 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2031 frame_window_p members of struct bidi_it.
d6d100dd
SM
2032 (compute_display_string_pos, compute_display_string_end):
2033 New functions.
fec2107c
EZ
2034 (push_it): Accept second argument POSITION, where pop_it should
2035 jump to continue iteration.
2036 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2037
fec2107c
EZ
2038 * keyboard.c (adjust_point_for_property): Adjust the call to
2039 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2040
2041 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2042 (bidi_init_it): Update prototypes.
2043 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2044 (compute_display_string_pos, compute_display_string_end):
2045 Declare prototypes.
fec2107c
EZ
2046 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2047 EMACS_INT.
fc6f18ce 2048
40087514 20492011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2050
57f53182
PE
2051 Malloc failure behavior now depends on size of allocation.
2052 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2053 * lisp.h: Change signatures accordingly.
2054 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2055 All callers changed. (Bug#8762)
2056
2057 * gnutls.c: Use Emacs's memory allocators.
2058 Without this change, the gnutls library would invoke malloc etc.
2059 directly, which causes problems on non-SYNC_INPUT hosts, and which
2060 runs afoul of improving memory_full behavior. (Bug#8761)
2061 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2062 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2063 xfree instead of the default malloc, realloc, free.
2064 (Fgnutls_boot): No need to check for memory allocation failure,
2065 since xmalloc does that for us.
2066
ac32cd99 2067 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2068 * category.c (hash_get_category_set):
2069 * ccl.c (ccl_driver):
2070 * charset.c (Fdefine_charset_internal):
2071 * charset.h (struct charset.hash_index):
2072 * composite.c (get_composition_id, gstring_lookup_cache)
2073 (composition_gstring_put_cache):
2074 * composite.h (struct composition.hash_index):
2075 * dispextern.h (struct image.hash):
2076 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2077 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2078 (hashfn_equal, hashfn_user_defined, make_hash_table)
2079 (maybe_resize_hash_table, hash_lookup, hash_put)
2080 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2081 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2082 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2083 * image.c (make_image, search_image_cache, lookup_image)
2084 (xpm_put_color_table_h):
2085 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2086 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
2087 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2088 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2089 * alloc.c (allocate_vectorlike):
2090 Check for overflow in vector size calculations.
2091 * ccl.c (ccl_driver):
2092 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2093 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2094 need to be updated by these changes.
40087514
PE
2095 * fns.c (make_hash_table, maybe_resize_hash_table):
2096 Check for integer overflow with large hash tables.
0de4bb68
PE
2097 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2098 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2099 (SXHASH_REDUCE): New macro.
2100 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2101 Use it instead of discarding useful hash info with large hash values.
2102 (sxhash_float): New function.
2103 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2104 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2105 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2106 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2107 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2108 Adjust signatures to match updated version of code.
2109 (consing_since_gc): Now EMACS_INT, since a single hash table can
2110 use more than INT_MAX bytes.
2111
698d32e2
DN
21122011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2113
2114 Make it possible to build with GCC-4.6+ -O2 -flto.
2115
2116 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2117
fd6fa53f
SM
21182011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2119
2120 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2121 Call minibuffer-inactive-mode.
2122
864db017
JB
21232011-05-31 Juanma Barranquero <lekktu@gmail.com>
2124
2125 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2126 Update dependencies.
2127
2ad0baf4
DN
21282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2129
2130 * data.c (init_data): Remove code for UTS, this system is not
2131 supported anymore.
2132
4fcc2638
DN
21332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2134
2135 Don't force ./temacs to start in terminal mode.
2136
2137 * frame.c (make_initial_frame): Initialize faces in all cases, not
2138 only when CANNOT_DUMP is defined.
2139 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2140
c56e0fd5
DN
21412011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2142
2143 * dispnew.c (add_window_display_history): Use const for the string
2144 pointer. Remove declaration, not needed.
2145
333d54da 21462011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2147
55d4c1b2 2148 Use 'inline', not 'INLINE'.
333d54da 2149 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2150 * alloc.c, fontset.c (INLINE): Remove.
2151 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2152 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2153 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2154 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2155 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2156
738db178
DN
21572011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2158
2159 Make it possible to run ./temacs.
2160
2161 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2162 syms_of_callproc does the same thing. Remove test for
2163 "initialized", do it in the caller.
2164 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2165
620c53a6
SM
21662011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2167
2168 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2169 (read_minibuf): Use get_minibuffer.
2170 (syms_of_minibuf): Use DEFSYM.
2171 (Qmetadata): New var.
2172 * data.c (Qbuffer): Don't make it static.
2173 (syms_of_data): Use DEFSYM.
2174
e003a292
PE
21752011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2176
2177 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2178 (CCL_CODE_MIN): New macro.
2179
ed008a6d
PE
21802011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2181
3687c2ef
PE
2182 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2183
ed008a6d
PE
2184 * eval.c (Qdebug): Now static.
2185 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2186 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2187 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2188
d66c4c7c
CY
21892011-05-29 Chong Yidong <cyd@stupidchicken.com>
2190
2191 * image.c: Various fixes to ImageMagick code comments.
2192 (Fimagemagick_types): Doc fix.
2193
5fbc2025
PE
21942011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2195
0196f88a
PE
2196 Minor fixes prompted by GCC 4.6.0 warnings.
2197
2198 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2199
5fbc2025
PE
2200 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2201 (x_clipboard_manager_save_all): Move extern decl to ...
2202 * xterm.h: ... here, so that it can be checked for consistency.
2203
1dd3c2d9
CY
22042011-05-29 Chong Yidong <cyd@stupidchicken.com>
2205
2206 * xselect.c (x_clipboard_manager_save_frame)
2207 (x_clipboard_manager_save_all): New functions.
2208 (Fx_clipboard_manager_save): Lisp function deleted.
2209
2210 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2211 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2212
2213 * xterm.h: Update prototype.
2214
5ba6571d
WX
22152011-05-28 William Xu <william.xwl@gmail.com>
2216
2217 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2218 exiting (Bug#8239).
2219
3eaff834
JM
22202011-05-28 Jim Meyering <meyering@redhat.com>
2221
e1900994 2222 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2223 * fns.c (to_uchar): Define.
2224 (crypto_hash_function): Use it to convert some newly-signed
2225 variables to unsigned, to avoid sign-extension bugs. For example,
2226 without this change, (md5 "truc") would evaluate to
2227 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2228 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2229 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2230
0f6990a7
PE
22312011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2232
2233 Integer overflow fixes.
c8a9ca5a 2234
08686060
PE
2235 * dbusbind.c: Serial number integer overflow fixes.
2236 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2237 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2238 to hold a serial number that is too large for a fixnum.
2239 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2240 Check for serial numbers out of range. Decode any serial number
59568bf0 2241 that was so large that it became a float. (Bug#8722)
08686060 2242
2d1fc3c7
PE
2243 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2244 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2245 Use XFASTINT rather than XUINT when numbers are nonnegative.
2246 (xd_append_arg, Fdbus_method_return_internal):
2247 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2248 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2249 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2250 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2251 (Bug#8722)
2d1fc3c7 2252
c8a9ca5a
PE
2253 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2254
519e1d69
PE
2255 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2256
30569699
PE
2257 ccl: add integer overflow checks
2258 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2259 (IN_INT_RANGE): New macros.
2260 (ccl_driver): Use them to check for integer overflow when
2261 decoding a CCL program. Many of the new checks are whether XINT (x)
2262 fits in int; it doesn't always, on 64-bit hosts. The new version
2263 doesn't catch all possible integer overflows, but it's an
847044ea 2264 improvement. (Bug#8719)
30569699 2265
c11285dc
PE
2266 * alloc.c (make_event_array): Use XINT, not XUINT.
2267 There's no need for unsigned here.
2268
fdccd48e
PE
2269 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2270 This follows up to the 2011-05-06 change that substituted uintptr_t
2271 for EMACS_INT. This case wasn't caught back then.
2272
37910ab2
PE
2273 Rework Fformat to avoid integer overflow issues.
2274 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2275 now (part of C89). Include <verify.h>.
2276 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2277 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2278 (Fformat): Avoid the prepass trying to compute sizes; it was only
2279 approximate and thus did not catch overflow reliably. Instead, walk
2280 through the format just once, formatting and computing sizes as we go,
2281 checking for integer overflow at every step, and allocating a larger
2282 buffer as needed. Keep track separately whether the format is
2283 multibyte. Keep only the most-recently calculated precision, rather
2284 than them all. Record whether each argument has been converted to
2285 string. Use EMACS_INT, not int, for byte and char and arg counts.
2286 Support field widths and precisions larger than INT_MAX. Avoid
2287 sprintf's undefined behavior with conversion specifications such as %#d
2288 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2289 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2290 formatting out-of-range floating point numbers with int
9173deec 2291 formats. (Bug#8668)
37910ab2 2292
2e6578fb
PE
2293 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2294
0ae6bdee
PE
2295 * data.c: Avoid integer truncation in expressions involving floats.
2296 * data.c: Include <intprops.h>.
2297 (arith_driver): When there's an integer overflow in an expression
2298 involving floating point, convert the integers to floating point
2299 so that the resulting value does not suffer from catastrophic
2300 integer truncation. For example, on a 64-bit host (* 4
2301 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2302 Do not rely on undefined behavior after integer overflow.
2303
de883a70
PE
2304 merge count_size_as_multibyte, parse_str_to_multibyte
2305 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2306 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2307 Check for integer overflow.
2308 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2309 since it's now a duplicate of the other. This is more of
2310 a character than a buffer op, so better that it's in character.c.
2311 * fns.c, print.c: Adjust to above changes.
2312
2ff916cb
PE
23132011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2314
2315 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2316
f1b54466
PE
23172011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2318
fb1ac845
PE
2319 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2320 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2321 (x_clipboard_manager_save): Now static.
2322 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2323
f1b54466
PE
2324 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2325 (crypto_hash_function): Now static.
2326 Fix pointer signedness problems. Avoid unnecessary initializations.
2327
a9f737ee
CY
23282011-05-27 Chong Yidong <cyd@stupidchicken.com>
2329
2330 * termhooks.h (Vselection_alist): Make it terminal-local.
2331
2332 * terminal.c (create_terminal): Initialize it.
2333
2334 * xselect.c: Support for clipboard managers.
2335 (Vselection_alist): Move to termhooks.h as terminal-local var.
2336 (LOCAL_SELECTION): New macro.
2337 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2338 (symbol_to_x_atom): Remove gratuitous arg.
2339 (x_handle_selection_request, lisp_data_to_selection_data)
2340 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2341 (x_own_selection, x_get_local_selection, x_convert_selection):
2342 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2343 (some_frame_on_display): Delete unused function.
2344 (Fx_own_selection_internal, Fx_get_selection_internal)
2345 (Fx_disown_selection_internal, Fx_selection_owner_p)
2346 (Fx_selection_exists_p): New optional frame arg.
2347 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2348 (x_handle_selection_clear): Don't treat other terminals with the
2349 same keyboard specially. Use the terminal-local Vselection_alist.
2350 (x_clear_frame_selections): Use Frun_hook_with_args.
2351
2352 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2353
2354 * xterm.h: Add support for those atoms.
2355
e067f0c1
CY
23562011-05-26 Chong Yidong <cyd@stupidchicken.com>
2357
2358 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2359 (converted_selections, conversion_fail_tag): New global variables.
2360 (x_selection_request_lisp_error): Free the above.
2361 (x_get_local_selection): Remove unnecessary code.
2362 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2363 of converted selections stored in converted_selections.
2364 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2365 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2366 (x_convert_selection): New function.
2367 (x_handle_selection_event): Simplify.
2368 (x_get_foreign_selection): Don't ignore incoming requests while
2369 waiting for an answer; this will fail when we implement
2370 SAVE_TARGETS, and seems unnecessary anyway.
2371 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2372 (Vx_sent_selection_functions): Doc fix.
2373
0f4aebc0
LL
23742011-05-26 Leo Liu <sdl.web@gmail.com>
2375
2376 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2377
e61124cd
YM
23782011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2379
2380 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2381
2382 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2383 for fringe update if it has periodic bitmap.
2384 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2385 and fringe_bitmap_periodic_p.
2386
2387 * fringe.c (get_fringe_bitmap_data): New function.
2388 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2389 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2390 row. Mark glyph row for fringe update if periodicity changed.
2391
2392 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2393 for fringe update unless it has periodic bitmap.
2394
f16d9837
KH
23952011-05-25 Kenichi Handa <handa@m17n.org>
2396
2397 * xdisp.c (get_next_display_element): Set correct it->face_id for
2398 a static composition.
2399
e1b90ef6
LL
24002011-05-24 Leo Liu <sdl.web@gmail.com>
2401
2402 * deps.mk (fns.o):
2403 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2404
2405 * fns.c (crypto_hash_function, Fsha1): New function.
2406 (Fmd5): Use crypto_hash_function.
2407 (syms_of_fns): Add Ssha1.
2408
7400048f
PE
24092011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2410
2411 * gnutls.c: Remove unused macros.
2412 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2413 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2414 Remove macros that are defined and never used.
2415 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2416
abb71cf4
CY
24172011-05-22 Chong Yidong <cyd@stupidchicken.com>
2418
2419 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2420 (Fx_get_selection_internal): Minor cleanup.
2421 (Fx_own_selection_internal): Rename arguments for consistency with
2422 select.el.
2423
6307db39
PE
24242011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2425
2426 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2427
f3d4e0a4
CY
24282011-05-22 Chong Yidong <cyd@stupidchicken.com>
2429
2430 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2431
4d8ade89
YM
24322011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2433
2434 * dispnew.c (scrolling_window): Don't exclude the case that the
2435 last enabled row in the desired matrix touches the bottom boundary.
2436
32078c8d
GM
24372011-05-21 Glenn Morris <rgm@gnu.org>
2438
2439 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2440 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2441 and add some more files.
32078c8d 2442
7285dc67
EZ
24432011-05-20 Eli Zaretskii <eliz@gnu.org>
2444
2445 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2446 report_file_error introduced by the change from 2011-05-07.
2447
89d1bd22
PE
24482011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2449
2450 * systime.h (Time): Define only if emacs is defined.
2451 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2452 where the include path doesn't have X11/X.h by default. See
2453 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2454
e23640bb 24552011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2456
2457 * composite.c (find_automatic_composition): Fix previous change.
2458
b9704ad9
GM
24592011-05-20 Glenn Morris <rgm@gnu.org>
2460
2461 * lisp.mk: New file, split from Makefile.in.
2462 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2463 (shortlisp): Remove.
2464 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2465
4a720484
GM
24662011-05-19 Glenn Morris <rgm@gnu.org>
2467
2468 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2469 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2470 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2471 (lisp): Set the order to that of loadup.el.
2472 (shortlisp): Make it a copy of $lisp.
2473 (SOME_MACHINE_LISP): Remove.
2474 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2475 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2476
a28d4396
KH
24772011-05-18 Kenichi Handa <handa@m17n.org>
2478
2479 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2480 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2481 (find_automatic_composition): Mostly rewrite for efficiency.
2482
a2b1fa8e
JB
24832011-05-18 Juanma Barranquero <lekktu@gmail.com>
2484
2485 * makefile.w32-in: Update dependencies.
2486
8e1f5610
CS
24872011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2488
2489 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2490 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2491
7025ee00 24922011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2493
cdfa6eab
PE
2494 Fix some integer overflow issues, such as string length overflow.
2495
06d6db33
PE
2496 * insdel.c (count_size_as_multibyte): Check for string overflow.
2497
2b4560a8
PE
2498 * character.c (lisp_string_width): Check for string overflow.
2499 Use EMACS_INT, not int, for string indexes and lengths; in
2500 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2501 the resulting string length overflows an EMACS_INT; instead,
2502 report a string overflow if no precision given. When checking for
2503 precision exhaustion, use a check that cannot possibly have
2504 integer overflow. (Bug#8675)
2505 * character.h (lisp_string_width): Adjust to new signature.
2506
cb93f9be
PE
2507 * alloc.c (string_overflow): New function.
2508 (Fmake_string): Use it. This doesn't change behavior, but saves
2509 a few bytes and will simplify future changes.
2510 * character.c (string_escape_byte8): Likewise.
2511 * lisp.h (string_overflow): New decl.
2512
1a1f3366
PE
2513 Fixups, following up to the user-interface timestamp change.
2514 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2515 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2516 * msdos.c (mouse_get_pos): Likewise.
2517 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2518 * w32gui.h (Time): Define by including "systime.h" rather than by
2519 declaring it ourselves. (Bug#8664)
2520
d4e3e4d3
PE
2521 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2522 * image.c (clear_image_cache): Likewise.
2523
f6a24d19
PE
2524 * term.c (term_mouse_position): Don't assume time_t wraparound.
2525
08dc5ae6
PE
2526 Be more systematic about user-interface timestamps.
2527 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2528 and sometimes 'EMACS_UINT', to represent these timestamps.
2529 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2530 This makes the code easier to follow, and makes it easier to catch
2531 integer overflow bugs such as Bug#8664.
2532 * frame.c (Fmouse_position, Fmouse_pixel_position):
2533 Use Time, not unsigned long, for user-interface timestamps.
2534 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2535 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2536 * keyboard.h (last_event_timestamp): Likewise.
2537 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2538 * menu.h (xmenu_show): Likewise.
2539 * term.c (term_mouse_position): Likewise.
2540 * termhooks.h (struct input_event.timestamp): Likewise.
2541 (struct terminal.mouse_position_hook): Likewise.
2542 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2543 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2544 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2545 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2546 what it was before.
2547 * menu.h, termhooks.h: Include "systime.h", for Time.
2548
8e55734a
PE
2549 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2550 Don't assume that the difference between two unsigned long values
2551 can fit into an integer. At this point, we know button_down_time
2552 <= event->timestamp, so the difference must be nonnegative, so
2553 there's no need to cast the result if double-click-time is
2554 nonnegative, as it should be; check that it's nonnegative, just in
2555 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2556 apart (about 25 days). (Bug#8664)
8e55734a 2557
841f1b75 2558 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2559 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2560
3e26f69c
PE
2561 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2562 that always fit in int. Use a sentinel instead of a counter, to
2563 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2564 * frame.h (struct frame): Use int for menu_bar_items_used
2565 instead of EMACS_INT, since it always fits in int.
3e26f69c 2566
5cc152c0
PE
2567 * menu.c (grow_menu_items): Check for int overflow.
2568
d89eb65e
PE
2569 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2570
5235bd3e
PE
2571 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2572 Before, the code was not consistent. These values cannot exceed
2573 2**31 - 1 so there's no need to make them unsigned.
2574 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2575 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2576 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2577 as modifiers.
2578 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2579
bc827e23
PE
2580 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2581 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2582 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2583 presumably because the widths might not match.
2584
78eb494e
PE
2585 * window.c (size_window): Avoid needless test at loop start.
2586
04f2d78b
CB
25872011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2588
2589 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2590
d2fc7e3d 25912011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2592
2593 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2594
d2fc7e3d 25952011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2596
2597 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2598 `width' to `bar_area_x' and `bar_area_width', respectively.
2599 (x_scroll_run): Take account of fringe background extension.
2600
04f2d78b
CB
2601 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2602 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2603 `bar_area_width', respectively.
2604 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2605 background extension.
2606
79b70037
GM
26072011-05-10 Jim Meyering <meyering@redhat.com>
2608
2609 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2610
2f142cc5
JB
26112011-05-10 Juanma Barranquero <lekktu@gmail.com>
2612
2613 * image.c (Finit_image_library): Return t for built-in image types,
2614 like pbm and xbm. (Bug#8640)
2615
57679c86
AS
26162011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2617
2618 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2619
888c9e86
EZ
26202011-05-07 Eli Zaretskii <eliz@gnu.org>
2621
b0512a1d
EZ
2622 * w32console.c (Fset_screen_color): Doc fix.
2623 (Fget_screen_color): New function.
2624 (syms_of_ntterm): Defsubr it.
2625
7285dc67
EZ
2626 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2627 unlink the temporary file if Fcall_process didn't create it in the
2628 first place.
2629 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2630 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2631 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2632 cue to call_process_cleanup not to close that handle.
2633
4d3fcc8e
BK
26342011-05-07 Ben Key <bkey76@gmail.com>
2635
2636 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2637 one of two shell specific rules, either bootstrap-temacs-CMD or
2638 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2639 to the previous implementation of the bootstrap-temacs rule.
2640 The bootstrap-temacs-CMD rule is similar to the previous
2641 implementation of the bootstrap-temacs rule except that it
2642 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2643 variable.
2644
2645 These changes, along with some changes to nt/configure.bat,
2646 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2647 earlier fix to add support for --cflags and --ldflags options
2648 that include quotes so that it works whether make uses cmd or
2649 sh as the shell.
2650
b4289b64
MA
26512011-05-06 Michael Albinus <michael.albinus@gmx.de>
2652
2653 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2654 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2655 is a constant.
2656 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2657 a string. Handle both cases.
2658 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2659 (Fdbus_register_method): Use Qinvalid_function.
2660
af4c0e28
JB
26612011-05-06 Juanma Barranquero <lekktu@gmail.com>
2662
2663 * makefile.w32-in: Update dependencies.
2664 (LISP_H): Add inttypes.h and stdin.h.
2665 (PROCESS_H): Add unistd.h.
2666
c51453d9
EZ
26672011-05-06 Eli Zaretskii <eliz@gnu.org>
2668
2669 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2670 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2671
8ff0ac3c 26722011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2673
4c4b566b
PE
2674 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2675
aab2b9b5
PE
2676 * term.c (vfatal): Remove stray call to va_end.
2677 It's not needed and the C Standard doesn't allow it here anyway.
2678
c378da0b
PE
2679 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2680 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2681
288b08c7
PE
2682 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2683 bytes.
2684
e3601888
PE
2685 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2686
db6c0e74
PE
2687 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2688
dd5963ea
PE
2689 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2690
88c9450f
PE
2691 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2692
2f9442b8
PE
2693 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2694
c032b5f8
PE
2695 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2696 * charset.c (Fdefine_charset_internal): Don't initialize
2697 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2698 32-bit int (Bug#8600).
a108c10b
PE
2699
2700 * lread.c (read_integer): Be more consistent with string-to-number.
2701 Use string_to_number to do the actual conversion; this avoids
2702 rounding errors and fixes some other screwups. Without this fix,
2703 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2704 (digit_to_number): Move earlier, for benefit of read_integer.
2705 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2706 not a digit in any supported base. (Bug#8602)
a108c10b 2707
ad5f9eea
PE
2708 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2709
aec1708a
PE
2710 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2711 to match comment at start of function. This also removes a
2712 GCC warning about overflow in a 32+64-bit port.
2713
47be4ab5
PE
2714 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2715
371cac43
PE
2716 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2717 Reported by Stefan Monnier in
2718 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2719 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2720 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2721
d01a7826
PE
2722 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2723 (EMACS_UINTPTR): Likewise, with uintptr_t.
2724
7fd47d5c
PE
2725 * lisp.h: Prefer 64-bit EMACS_INT if available.
2726 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2727 on 32-bit hosts that have 64-bit int, so that they can access
2728 large files.
122b0c86
PE
2729 However, temporarily disable this change unless the temporary
2730 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2731
8727937b
PE
2732 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2733
8ac068ac
PE
2734 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2735 This removes an assumption that EMACS_INT and long are the same
2736 width as pointers. The assumption is true for Emacs porting targets
2737 now, but we want to make other targets possible.
2738 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2739 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2740 In the rest of the code, change types of integers that hold casted
2741 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2742 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2743 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2744 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2745 No need to cast type when ORing.
2746 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2747 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2748 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2749 assume EMACS_INT is the same width as char *.
2750 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2751 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2752 Remove no-longer-needed casts.
2753 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2754 (xg_tool_bar_help_callback, xg_make_tool_item):
2755 Use EMACS_INTPTR to hold an integer
2756 that will be cast to void *; this can avoid a GCC warning
2757 if EMACS_INT is not the same width as void *.
2758 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2759 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2760 (current_message_1, set_message_1):
2761 Use a local to convert to proper width without a cast.
2762 * xmenu.c (dialog_selection_callback): Likewise.
2763
ede49d71
PE
2764 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2765 Also, don't assume VALBITS / RAND_BITS is less than 5,
2766 and don't rely on undefined behavior when shifting a 1 left into
2767 the sign bit.
2768 * lisp.h (get_random): Change signature to match.
2769
2f30ecd0
PE
2770 * lread.c (hash_string): Use size_t, not int, for hash computation.
2771 Normally we prefer signed values; but hashing is special, because
2772 it's better to use unsigned division on hash table sizes so that
2773 the remainder is nonnegative. Also, size_t is the natural width
2774 for hashing into memory. The previous code used 'int', which doesn't
2775 retain enough info to hash well into very large tables.
2776 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2777
2a866e7b
PE
2778 * dbusbind.c: Don't possibly lose pointer info when converting.
2779 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2780 Use XPNTR rather than XHASH, so that the high-order bits of
2781 the pointer aren't lost when converting through void *.
2782
51639eac
PE
2783 * eval.c (Fautoload): Don't double-shift a pointer.
2784
92394119
PE
2785 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2786
dbdb9a7c
JB
27872011-05-06 Juanma Barranquero <lekktu@gmail.com>
2788
2789 * gnutls.c (DEF_GNUTLS_FN):
2790 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2791
db7a0b4f
AS
27922011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2793
2794 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2795 marker. (Bug#8610)
2796
f7ff1b0f 27972011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2798
2799 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2800 New version that can reserve upto 2GB of heap space.
2801
f7ff1b0f 28022011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2803
2804 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2805
639c109b
TZ
28062011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2807
2808 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2809 `gnutls_certificate_set_x509_key_file'.
2810
d2127135
JB
28112011-05-05 Juanma Barranquero <lekktu@gmail.com>
2812
2813 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2814 Update dependencies.
2815
e968f4f3
JB
28162011-05-04 Juanma Barranquero <lekktu@gmail.com>
2817
2818 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2819 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2820 Remove unused parameter `fildes'.
2821 * process.c (read_process_output, send_process): Don't pass it.
2822
84d358f0
JB
28232011-05-04 Juanma Barranquero <lekktu@gmail.com>
2824
2825 Fix previous change: the library cache is defined in w32.c.
2826 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2827 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2828
0898ca10
JB
28292011-05-04 Juanma Barranquero <lekktu@gmail.com>
2830
2831 Implement dynamic loading of GnuTLS on Windows.
2832
2833 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2834 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2835 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2836 Declare.
2837
2838 * gnutls.c (Qgnutls_dll): Define.
2839 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2840 (gnutls_*): Declare function pointers.
2841 (init_gnutls_functions): New function to initialize function pointers.
2842 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2843 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2844 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2845 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2846 (emacs_gnutls_write, emacs_gnutls_read)
2847 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2848 (Fgnutls_available_p): New function.
2849 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2850 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2851 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2852
2853 * image.c: Include w32.h.
2854 (Vimage_type_cache): Delete.
2855 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2856 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2857 (w32_delayed_load): Move to w32.c.
2858
2859 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2860
2861 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2862 (w32_delayed_load): Move from image.c. When loading a library, record
2863 its filename in the :loaded-from property of the library id.
2864 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2865 Initialize and staticpro them.
2866 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2867
2868 * process.c: Include lisp.h before w32.h, not after.
2869 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2870 instead of gnutls_record_check_pending.
2871
2872 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2873
ff4de4aa
TZ
28742011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2875
2876 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2877 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2878 as passed in.
2879
abe95abb
JD
28802011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2881
2882 * xterm.c (x_set_frame_alpha): Do not set property on anything
2883 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2884
e16e55d4
JB
28852011-05-02 Juanma Barranquero <lekktu@gmail.com>
2886
2887 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2888
bafcf6a5
JB
28892011-05-02 Juanma Barranquero <lekktu@gmail.com>
2890
2891 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2892 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2893 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2894 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2895 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2896 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2897 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2898 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2899 (Qgnutls_bootprop_callbacks_verify): Make static.
2900
e7a6747f
AS
29012011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2902
19ed11ba
AS
2903 * callproc.c: Indentation fixup.
2904
e7a6747f 2905 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2906 (wait_for_termination, interruptible_wait_for_termination):
2907 Move after wait_for_termination_1.
e7a6747f 2908
1ef14cb4
LMI
29092011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2910
2911 * sysdep.c (interruptible_wait_for_termination): New function
2912 which is like wait_for_termination, but allows keyboard
2913 interruptions.
2914
2915 * callproc.c (Fcall_process): Add (:file "file") as an option for
2916 the STDOUT buffer.
2917 (Fcall_process_region): Ditto.
2918
330d880c
EZ
29192011-04-30 Eli Zaretskii <eliz@gnu.org>
2920
8db90b73
EZ
2921 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2922 rather than `XVECTOR (FOO)->size'.
2923
330d880c
EZ
2924 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2925 inttypes.h, as a gnulib replacement is used if it not available in
2926 system headers.
2927
15cbd324
EZ
29282011-04-21 Eli Zaretskii <eliz@gnu.org>
2929
2930 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2931 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2932 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2933
2934 * coding.c (coding_alloc_by_realloc): Error out if destination
2935 will grow beyond MOST_POSITIVE_FIXNUM.
2936 (decode_coding_emacs_mule): Abort if there isn't enough place in
2937 charbuf for the composition carryover bytes. Reserve an extra
2938 space for up to 2 characters produced in a loop.
2939 (decode_coding_iso_2022): Abort if there isn't enough place in
2940 charbuf for the composition carryover bytes.
2941
29422011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2943
ae940cca
EZ
2944 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2945 aborting when %lld or %lll format is passed.
2946 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2947 %llo or %llx format is passed. (Bug#8545)
2948
03ab8921
EZ
2949 * window.c (window_scroll_line_based): Use a marker instead of
2950 simple variables to record original value of point. (Bug#7952)
2951
afda1437
EZ
2952 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2953 produced by %s or %c overflows available buffer space. (Bug#8545)
2954
f76dee0c
PE
29552011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2956
2957 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2958 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2959
fdc5744d
JB
29602011-04-28 Juanma Barranquero <lekktu@gmail.com>
2961
2962 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2963
638f053a
JB
29642011-04-28 Juanma Barranquero <lekktu@gmail.com>
2965
2966 * keyboard.c (Qdelayed_warnings_hook): Define.
2967 (command_loop_1): Run `delayed-warnings-hook'
2968 if Vdelayed_warnings_list is non-nil.
2969 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2970 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2971
d178f871
EZ
29722011-04-28 Eli Zaretskii <eliz@gnu.org>
2973
2974 * doprnt.c (doprnt): Don't return value smaller than the buffer
2975 size if the message was truncated. (Bug#8545).
2976
b124fd93
JB
29772011-04-28 Juanma Barranquero <lekktu@gmail.com>
2978
2979 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2980 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2981
e810457d
PE
29822011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2983
2984 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2985
ea51cceb
JB
29862011-04-27 Juanma Barranquero <lekktu@gmail.com>
2987
2988 * makefile.w32-in: Update dependencies.
2989
94dcfacf
EZ
29902011-04-27 Eli Zaretskii <eliz@gnu.org>
2991
2992 Improve `doprnt' and its usage. (Bug#8545)
2993 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2994 `format_end'. Remove support for %l as a conversion specifier.
2995 Don't use xrealloc. Improve diagnostics when the %l size modifier
2996 is used. Update the commentary.
2997
2998 * eval.c (verror): Simplify calculation of size_t.
2999
3000 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3001 messages.
3002
f61f41d7
PE
30032011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3004
3005 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3006 change.
3007
96fb4434
PE
30082011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3009
3010 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3011 This makes this file independent of the recent pseudovector change.
3012
671875da 30132011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3014
69e9b5a3
PE
3015 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3016
b5f869a7 3017 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3018 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3019 Remove unused local.
c8926152 3020 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3021
841a1577 3022 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3023 GCC 4.6.0 optimizes based on type-based alias analysis.
3024 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3025 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3026 != &v->size, and therefore "v->size = 1; b->size = 2; return
3027 v->size;" must therefore return 1. This assumption is incorrect
3028 for Emacs, since it type-puns struct Lisp_Vector * with many other
3029 types. To fix this problem, this patch adds a new type struct
f904488f 3030 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3031 and pseudovectors, and helps optimizing compilers not get fooled
3032 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3033 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3034 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3035 the size member.
eab3844f
PE
3036 (XSETPVECTYPE): Rewrite in terms of new macro.
3037 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3038 This is a bit clearer, and further avoids the possibility of
3039 undesirable aliasing.
3040 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3041 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3042 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3043 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3044 (ASIZE): Now uses header.size rather than size.
3045 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3046 to avoid the hassle of writing XVECTOR (foo)->header.size.
3047 (struct vectorlike_header): New type.
eab3844f
PE
3048 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3049 object, to help avoid aliasing.
3050 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3051 (SUBRP): Likewise, since Lisp_Subr is a special case.
3052 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3053 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3054 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3055 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3056 changed to be "header.size" and "header.next".
3057 * buffer.h (struct buffer): Likewise.
3058 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3059 * frame.h (struct frame): Likewise.
3060 * process.h (struct Lisp_Process): Likewise.
3061 * termhooks.h (struct terminal): Likewise.
3062 * window.c (struct save_window_data, struct saved_window): Likewise.
3063 * window.h (struct window): Likewise.
3064 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3065 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3066 * buffer.c (init_buffer_once): Likewise.
3067 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3068 special case.
3069 * process.c (Fformat_network_address): Use local var for size,
3070 for brevity.
3071
0df1eac5
PE
3072 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3073
847ab9d1 3074 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3075 * data.c (atof): Remove decl; no longer used or needed.
3076 (digit_to_number): Move to lread.c.
3077 (Fstring_to_number): Use new string_to_number function, to be
3078 consistent with how the Lisp reader treats infinities and NaNs.
3079 Do not assume that floating-point numbers represent EMACS_INT
3080 without losing information; this is not true on most 64-bit hosts.
3081 Avoid double-rounding errors, by insisting on integers when
3082 parsing non-base-10 numbers, as the documentation specifies.
3083 * lisp.h (string_to_number): New decl, replacing ...
3084 (isfloat_string): Remove.
bc0a5c13 3085 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3086 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3087 appears to have been a coding error. Similarly, do not accept
3088 strings like +-1e0 as floating point numbers. Do not report
3089 overflow for integer overflows unless the base is not 10 which
3090 means we have no simple and reliable way to continue.
3091 Break out the floating-point parsing into a new
3092 function string_to_number, so that Fstring_to_number parses
3093 floating point numbers consistently with the Lisp reader.
04f2d78b 3094 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3095 (E_CHAR, EXP_INT): Remove, replacing with ...
3096 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3097 (string_to_number): New function, replacing isfloat_string.
3098 This function checks for valid syntax and produces the resulting
3099 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3100 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3101 so that overflow for non-base-10 numbers is reported only when
3102 there's no portable and simple way to convert to floating point.
452f4150 3103
67769ffc
PE
3104 * textprop.c (set_text_properties_1): Rewrite for clarity,
3105 and to avoid GCC warning about integer overflow.
3106
c20db43f
PE
3107 * intervals.h (struct interval): Use EMACS_INT for members
3108 where EMACS_UINT might cause problems. See
3109 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3110 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3111 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3112 All uses changed.
37aa2f85
PE
3113 (offset_intervals): Tell GCC not to worry about length overflow
3114 when negating a negative length.
c20db43f 3115
2538aa2f
PE
3116 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3117 (overrun_check_free): Likewise.
3118
f2d3008d
PE
3119 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3120 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3121 word size.
3122
ec8df744
PE
3123 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3124 (gnutls_make_error): Rename local to avoid shadowing.
3125 (gnutls_emacs_global_deinit): ifdef out; not used.
3126 (Fgnutls_boot): Use const for pointer to readonly storage.
3127 Comment out unused local. Fix pointer signedness problems.
3128
640ee02d
PE
3129 * lread.c (openp): Don't stuff size_t into an 'int'.
3130 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3131 about possible signed overflow.
3132
6048fb2a
PE
3133 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3134 (GDK_KEY_g): Don't define if already defined.
3135 (xg_prepare_tooltip): Avoid pointer signedness problem.
3136 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3137
fa3c87e1
PE
3138 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3139 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3140
2172544b
PE
3141 * xfns.c (Fx_window_property): Simplify a bit,
3142 to make a bit faster and to avoid GCC 4.6.0 warning.
3143 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3144
9b821a21
PE
3145 * fns.c (internal_equal): Don't assume size_t fits in int.
3146
3c616cfa
PE
3147 * alloc.c (compact_small_strings): Tighten assertion a little.
3148
c2982e87
PE
3149 Replace pEd with more-general pI, and fix some printf arg casts.
3150 * lisp.h (pI): New macro, generalizing old pEd macro to other
3151 conversion specifiers. For example, use "...%"pI"d..." rather
3152 than "...%"pEd"...".
3153 (pEd): Remove. All uses replaced with similar uses of pI.
3154 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3155 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3156 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3157 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3158 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3159 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3160 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3161 64-bit hosts.
3162 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3163 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3164 * print.c (safe_debug_print, print_object): Likewise.
3165 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3166 to int.
6f04d126
PE
3167 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3168 avoiding the 0 flag, which is not portable.
c2982e87
PE
3169 * process.c (Fmake_network_process): Use pI to avoid cast.
3170 * region-cache.c (pp_cache): Likewise.
3171 * xdisp.c (decode_mode_spec): Likewise.
3172 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3173 behavior on 64-bit hosts with printf arg.
6f04d126 3174 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3175 (x_stop_queuing_selection_requests): Likewise.
3176 (x_get_window_property): Don't truncate byte count to an 'int'
3177 when tracing.
0b432f21 3178
5e073ec7
PE
3179 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3180 here, since it parses constructs like leading '-' and spaces,
3181 which are not wanted; and it overflows with large numbers.
3182 Instead, simply match F[0-9]+, which is what is wanted anyway.
3183
36372bf9
PE
3184 * alloc.c: Remove unportable assumptions about struct layout.
3185 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3186 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3187 (allocate_vectorlike, make_pure_vector): Use the new macros,
3188 plus offsetof, to remove unportable assumptions about struct layout.
3189 These assumptions hold on all porting targets that I know of, but
3190 they are not guaranteed, they're easy to remove, and removing them
3191 makes further changes easier.
3192
0b432f21
PE
3193 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3194 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3195 (string_overrun_cookie): Now const. Use initializers that
3196 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3197 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3198 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3199 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3200 multiple of sizeof (EMACS_INT); it need not be, if
3201 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3202 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3203
895009e1
JB
32042011-04-26 Juanma Barranquero <lekktu@gmail.com>
3205
3206 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3207
6a7a1b0b
TZ
32082011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3209
3210 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3211 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3212 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3213
841a1577 32142011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3215
3216 * lisp.h (Qdebug): List symbol.
895009e1 3217 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3218 * keyboard.c (debug-on-event): New variable.
3219 (handle_user_signal): Break into debugger when debug-on-event
3220 matches the current signal symbol.
3221
f2d3ba6f
DN
32222011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3223
3224 * alloc.c (check_sblock, check_string_bytes)
3225 (check_string_free_list): Convert to standard C.
3226
42ce4c63
TZ
32272011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3228
3229 * w32.c (emacs_gnutls_push): Fix typo.
3230
825cd63c
EZ
32312011-04-25 Eli Zaretskii <eliz@gnu.org>
3232
fb11d64d
EZ
3233 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3234 "cast to pointer from integer of different size".
3235
825cd63c
EZ
3236 Improve doprnt and its use in verror. (Bug#8545)
3237 * doprnt.c (doprnt): Document the set of format control sequences
3238 supported by the function. Use SAFE_ALLOCA instead of always
3239 using `alloca'.
3240
3241 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3242 is one byte too soon. Don't use xrealloc; instead xfree and
3243 xmalloc anew.
3244
e061a11b
TZ
32452011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3246
3247 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3248 callbacks stage.
3249
3250 * gnutls.c: Renamed global_initialized to
3251 gnutls_global_initialized. Added internals for the
3252 :verify-hostname-error, :verify-error, and :verify-flags
3253 parameters of `gnutls-boot' and documented those parameters in the
3254 docstring. Start callback support.
9173deec
JB
3255 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3256 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3257 on error. Return error code.
e061a11b
TZ
3258 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3259 (emacs_gnutls_read): Likewise.
3260 (Fgnutls_boot): Return handshake error code.
3261 (emacs_gnutls_handle_error): New function.
3262 (wsaerror_to_errno): Likewise.
3263
3264 * w32.h (emacs_gnutls_pull): Add prototype.
3265 (emacs_gnutls_push): Likewise.
3266
3267 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3268 (emacs_gnutls_push): Likewise.
3269
32702011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3271
3272 * process.c (wait_reading_process_output): Check if GnuTLS
3273 buffered some data internally if no FDs are set for TLS
3274 connections.
3275
3276 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3277 (LIBS): Link to USER_LIBS.
3278 ($(BLD)/gnutls.$(0)): New target.
3279
fa6996bc
EZ
32802011-04-24 Eli Zaretskii <eliz@gnu.org>
3281
eb35682e
EZ
3282 * xdisp.c (handle_single_display_spec): Rename the
3283 display_replaced_before_p argument into display_replaced_p, to
3284 make it consistent with the commentary. Fix typos in the
3285 commentary.
3286
e2ad650c
EZ
3287 * textprop.c (syms_of_textprop): Remove dead code.
3288 (copy_text_properties): Delete obsolete commentary about an
3289 interface that was deleted long ago. Fix typos in the description
3290 of arguments.
3291
1b2de274
EZ
3292 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3293 to changes in oldXMenu/XMenu.h from 2011-04-16.
3294 <menu_help_message, prev_menu_help_message>: Constify.
3295 (IT_menu_make_room): menu->help_text is now `const char **';
3296 adjust.
3297
3298 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3299 to changes in oldXMenu/XMenu.h from 2011-04-16.
3300 (struct XMenu): Declare `help_text' `const char **'.
3301
3302 * xfaces.c <Qunspecified>: Make extern again.
3303
3304 * syntax.c: Include sys/types.h before including regex.h, as
3305 required by Posix.
3306
762b15be
EZ
3307 * doc.c (get_doc_string): Improve the format passed to `error'.
3308
3309 * doprnt.c (doprnt): Improve commentary.
3310
3311 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3312
3313 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3314 them with etags.
3315
f1052e5d
EZ
3316 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3317 changes in globals.h immediately force recompilation.
762b15be
EZ
3318 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3319 $(CURDIR)/s/ms-w32.h.
3320 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3321
fa6996bc
EZ
3322 * character.c (Fchar_direction): Function deleted.
3323 (syms_of_character): Don't defsubr it.
3324 <char-direction-table>: Deleted.
3325
e6c3da20
EZ
33262011-04-23 Eli Zaretskii <eliz@gnu.org>
3327
3328 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3329 * doprnt.c: Include limits.h.
3330 (SIZE_MAX): New macro.
04f2d78b
CB
3331 (doprnt): Return a size_t value. 2nd arg is now size_t.
3332 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3333 Improve overflow protection. Support `l' modifier for integer
3334 conversions. Support %l conversion. Don't assume an EMACS_INT
3335 argument for integer conversions and for %c.
3336
3337 * lisp.h (doprnt): Restore prototype.
3338
3339 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3340 $(SRC)/character.h.
3341
3342 * Makefile.in (base_obj): Add back doprnt.o.
3343
3344 * deps.mk (doprnt.o): Add back prerequisites.
3345 (callint.o): Depend on character.h.
3346
3347 * eval.c (internal_lisp_condition_case): Include the handler
3348 representation in the error message.
3349 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3350 when breaking from the loop.
3351
3352 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3353
3354 * callint.c (Fcall_interactively): When displaying error message
3355 about invalid control letter, pass the character's codepoint, not
3356 a pointer to its multibyte form. Improve display of the character
3357 in octal and display also its hex code.
3358
3359 * character.c (char_string): Use %x to display the (unsigned)
3360 codepoint of an invalid character, to avoid displaying a bogus
3361 negative value.
3362
3363 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3364 `error', not SYMBOL_NAME itself.
3365
3366 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3367 character arguments to `error'.
3368
3369 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3370 to `error' in error message about FINAL_CHAR argument. Make sure
3371 FINAL_CHAR is a character, and use %c when it is passed as
3372 argument to `error'.
3373
4ffd0d6b 33742011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3375
3376 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3377
3378 * w32.c: Include <time.h>.
3379 (sys_localtime): New function.
3380
4ffd0d6b 33812011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3382
3383 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3384
4ffd0d6b 3385 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3386
4ffd0d6b 33872011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3388
4ffd0d6b
GM
3389 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3390 zombies (Bug#8467).
aac0c6e3 3391
04c56954
EZ
33922011-04-19 Eli Zaretskii <eliz@gnu.org>
3393
3394 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3395 gl_state.e_property when gl_state.object is Qt.
3396
3397 * insdel.c (make_gap_larger): Remove limitation of buffer size
3398 to <= INT_MAX.
3399
16a43933
CY
34002011-04-18 Chong Yidong <cyd@stupidchicken.com>
3401
3402 * xdisp.c (lookup_glyphless_char_display)
3403 (produce_glyphless_glyph): Handle cons cell entry in
3404 glyphless-char-display.
3405 (Vglyphless_char_display): Document it.
3406
3407 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3408 glyphless-char-display.
3409
4581706e
CY
34102011-04-17 Chong Yidong <cyd@stupidchicken.com>
3411
3412 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3413
3414 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3415
3416 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3417 definition for no-X builds.
3418
4887c6e2 34192011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3420
fd35b6f9
PE
3421 Static checks with GCC 4.6.0 and non-default toolkits.
3422
5c1ccb01
PE
3423 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3424
006c5daa
PE
3425 * process.c (keyboard_bit_set): Define only if SIGIO.
3426 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3427 (send_process): Repair possible setjmp clobbering.
3428
efc736d3
PE
3429 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3430
4e2fe2e6
PE
3431 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3432
f97334a2
PE
3433 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3434
4e75f29d
PE
3435 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3436 Define only if needed.
3437
90efadd1
PE
3438 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3439 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3440 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3441
3c647824
PE
3442 * dispextern.h (struct redisplay_interface): Rename param
3443 to avoid shadowing.
e264f262 3444 * termhooks.h (struct terminal): Likewise.
761383f4 3445 * xterm.c (xembed_send_message): Likewise.
3c647824 3446
b58c5c4a
PE
3447 * insdel.c (make_gap_smaller): Define only if
3448 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3449
cad59032
PE
3450 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3451 it.
3452
c339dc2e
PE
3453 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3454 so that we aren't warned about unused symbols.
3455
91a3e27b
PE
3456 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3457
399c71d3 3458 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3459
8ffc96f5
PE
3460 * xfns.c (x_real_positions): Mark locals as initialized.
3461
eef9bc79
PE
3462 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3463
098db9dd
PE
3464 * xterm.c: Fix problems found by static analysis with other toolkits.
3465 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3466 (x_dispatch_event): Declare static if USE_GTK, and
3467 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3468 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3469 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3470 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3471 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3472
eb18f6cc
PE
3473 * xmenu.c (menu_help_callback): Pointer type fixes.
3474 Use const pointers when pointing at readonly data. Avoid pointer
3475 signedness clashes.
3476 (FALSE): Remove unused macro.
3477 (update_frame_menubar): Remove unused decl.
3478
1fe72bf8
PE
3479 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3480
60d9e1db
PE
3481 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3482 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3483 (single_menu_item): Rename local to avoid shadowing.
3484
39261c26
PE
3485 * keyboard.c (make_lispy_event): Remove unused local var.
3486
018c5e19
PE
3487 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3488 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3489
63d2b86e
PE
3490 * bitmaps: Change bitmaps from unsigned char back to the X11
3491 compatible char. Avoid the old compiler warnings about
3492 out-of-range initializers by using, for example, '\xab' rather
3493 than 0xab.
3494
aefd87e1
PE
3495 * xgselect.c (xgselect_initialize): Check vs interface
3496 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3497
bf501fb9
PE
3498 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3499
e9829fdf
PE
3500 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3501 to read-only memory.
3502
1086c095
PE
3503 * fns.c (vector): Remove; this old hack is no longer needed.
3504
2baccd04 3505 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3506 Remove unused var.
dde42981 3507 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3508
72391843 3509 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3510
436c16df 3511 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3512 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3513 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3514
92bb796d 3515 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3516 (x_term_init): Remove local to avoid shadowing.
92bb796d 3517
764430a3 3518 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3519
3520 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3521 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3522
d1dfb56c
EZ
35232011-04-16 Eli Zaretskii <eliz@gnu.org>
3524
c4354cb4
EZ
3525 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3526
d1dfb56c
EZ
3527 Fix regex.c, syntax.c and friends for buffers > 2GB.
3528 * syntax.h (struct gl_state_s): Declare character position members
3529 EMACS_INT.
3530
3531 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3532
04f2d78b
CB
3533 * textprop.c (verify_interval_modification, interval_of):
3534 Declare arguments EMACS_INT.
d1dfb56c
EZ
3535
3536 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3537 EMACS_INT.
3538
3539 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3540
3541 * indent.c (Fvertical_motion): Local variable it_start is now
3542 EMACS_INT.
3543
3544 * regex.c (re_match, re_match_2, re_match_2_internal)
3545 (bcmp_translate, regcomp, regexec, print_double_string)
3546 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3547 (re_compile_pattern, re_exec): Declare arguments and local
3548 variables `size_t' and `ssize_t' and return values `regoff_t', as
3549 appropriate.
3550 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3551 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3552 <compile_stack_type>: `size' and `avail' are now `size_t'.
3553
3554 * regex.h <regoff_t>: Use ssize_t, not int.
3555 (re_search, re_search_2, re_match, re_match_2): Arguments that
3556 specify buffer/string position and length are now ssize_t and
3557 size_t. Return type is regoff_t.
3558
613052cd
BK
35592011-04-16 Ben Key <bkey76@gmail.com>
3560
3561 * nsfont.m: Fixed bugs in ns_get_family and
3562 ns_descriptor_to_entity that were caused by using free to
3563 deallocate memory blocks that were allocated by xmalloc (via
3564 xstrdup). This caused Emacs to crash when compiled with
3565 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3566 --enable-checking=xmallocoverrun). xfree is now used to
3567 deallocate these memory blocks.
3568
4170f62f 35692011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3570
71b41406
PE
3571 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3572
9587a89d
PE
3573 emacs_write: Accept and return EMACS_INT for sizes.
3574 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3575 et seq.
3576 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3577 Accept and return EMACS_INT.
3578 (emacs_gnutls_write): Return the number of bytes written on
3579 partial writes.
3580 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3581 (emacs_read, emacs_write): Remove check for negative size, as the
3582 Emacs source code has been audited now.
9587a89d
PE
3583 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3584 (emacs_read, emacs_write): Use it.
273a5f82
PE
3585 * process.c (send_process): Adjust to the new signatures of
3586 emacs_write and emacs_gnutls_write. Do not attempt to store
3587 a byte offset into an 'int'; it might overflow.
9587a89d 3588 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3589
3e047f51
PE
3590 * sound.c: Don't assume sizes fit in 'int'.
3591 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3592 Return EMACS_INT, not int.
3e047f51 3593 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3594 Accept EMACS_INT, not int.
3595 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3596 record read return values.
3597
cc39a9db
BK
35982011-04-15 Ben Key <bkey76@gmail.com>
3599
c9d0ec6d
JB
3600 * keyboard.c (Qundefined): Don't declare static since it is used
3601 in nsfns.m.
3602 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3603 static since they are used in nsfont.m.
cc39a9db 3604
6c60eb9f
SM
36052011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3606
3607 * process.c (Qprocessp): Don't declare static.
3608 * lisp.h (Qprocessp): Declare again.
3609
7990b61a
JB
36102011-04-15 Juanma Barranquero <lekktu@gmail.com>
3611
3612 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3613
5d4cb038
PE
36142011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3615
8bd7b830 3616 Improve C-level modularity by making more things 'static'.
cd64ea1d 3617
e3b27b31
PE
3618 Don't publish debugger-only interfaces to other modules.
3619 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3620 (verify_bytepos, count_markers): Move decls to the only modules
3621 that need them.
3622 * region-cache.h (pp_cache): Likewise.
3623 * window.h (check_all_windows): Likewise.
3624 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3625
5d4cb038
PE
3626 * sysdep.c (croak): Now static, if
3627 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3628 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3629
3630 * alloc.c (refill_memory_reserve): Now static if
3631 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3632 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3633
e87b6180
PE
3634 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3635 Define only if USE_LUCID.
3636
ac64929e
PE
3637 * xrdb.c (x_customization_string, x_rm_string): Now static.
3638
6f37259d
PE
3639 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3640 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3641
1683e3ab
PE
3642 * xdisp.c (draw_row_with_mouse_face): Now static.
3643 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3644
de9c2632
PE
3645 * window.h (check_all_windows): Mark externally visible.
3646
2b96acb7
PE
3647 * window.c (window_deletion_count): Now static.
3648
3649 * undo.c: Make symbols static if they're not exported.
3650 (last_undo_buffer, last_boundary_position, pending_boundary):
3651 Now static.
3652
50436f33
PE
3653 * textprop.c (interval_insert_behind_hooks): Now static.
3654 (interval_insert_in_front_hooks): Likewise.
3655
64520e5c
PE
3656 * term.c: Make symbols static if they're not exported.
3657 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3658 (max_frame_lines, tty_set_terminal_modes):
3659 (tty_reset_terminal_modes, tty_turn_off_highlight):
3660 (get_tty_terminal): Now static.
3661 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3662 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3663 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3664 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3665 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3666
1fa53021
PE
3667 * sysdep.c: Make symbols static if they're not exported.
3668 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3669 Now static.
3670 (sigprocmask_set, full_mask): Remove; unused.
3671 (wait_debugging): Mark as visible.
3672 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3673 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3674
d4b43b22
PE
3675 * syntax.c (syntax_temp): Define only if !__GNUC__.
3676
b7c513d0
PE
3677 * sound.c (current_sound_device, current_sound): Now static.
3678
989b29ad
PE
3679 * search.c (searchbufs, searchbuf_head): Now static.
3680
13a55a78
PE
3681 * scroll.c (scroll_cost): Remove; unused.
3682 * dispextern.h (scroll_cost): Remove decl.
3683
de68a1fc
PE
3684 * region-cache.h (pp_cache): Mark as externally visible.
3685
40ccffa6
PE
3686 * process.c: Make symbols static if they're not exported.
3687 (process_tick, update_tick, create_process, chan_process):
3688 (Vprocess_alist, proc_buffered_char, datagram_access):
3689 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3690 (deactivate_process): Mark defn as static, as well as decl.
3691 * lisp.h (create_process): Remove decl.
3692 * process.h (chan_process, Vprocess_alist): Remove decls.
3693
ad64fc97
PE
3694 * print.c: Make symbols static if they're not exported.
3695 (print_depth, new_backquote_output, being_printed, print_buffer):
3696 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3697 (print_interval, print_number_index, initial_stderr_stream):
3698 Now static.
3699 * lisp.h (Fprinc): Remove decl.
3700 (debug_output_compilation_hack): Mark as externally visible.
3701
adddb265
PE
3702 * sysdep.c (croak): Move decl from here to syssignal.h.
3703 * syssignal.h (croak): Put it here, so the API can be checked when
3704 'croak' is called from dissociate_if_controlling_tty.
3705
1717ede2
PE
3706 * minibuf.c: Make symbols static if they're not exported.
3707 (minibuf_save_list, choose_minibuf_frame): Now static.
3708 * lisp.h (choose_minibuf_frame): Remove decl.
3709
fa5fb2bc
PE
3710 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3711
1e3890d1
PE
3712 * lread.c: Make symbols static if they're not exported.
3713 (read_objects, initial_obarray, oblookup_last_bucket_number):
3714 Now static.
3715 (make_symbol): Remove; unused.
3716 * lisp.h (initial_obarray, make_symbol): Remove decls.
3717
8a1414fa
PE
3718 * keyboard.c: Make symbols static if they're not exported.
3719 (single_kboard, recent_keys_index, total_keys, recent_keys):
3720 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3721 (this_single_command_key_start, echoing, last_auto_save):
3722 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3723 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3724 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3725 (Vlispy_mouse_stem, double_click_count):
3726 Now static.
3727 (force_auto_save_soon): Define only if SIGDANGER.
3728 (ignore_mouse_drag_p): Now static if
3729 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3730 (print_help): Remove; unused.
3731 (stop_character, last_timer_event): Mark as externally visible.
3732 * keyboard.h (ignore_mouse_drag_p): Declare only if
3733 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3734 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3735 * lisp.h (echoing): Remove decl.
3736 (force_auto_save_soon): Declare only if SIGDANGER.
3737 * xdisp.c (redisplay_window): Simplify code, to make it more
3738 obvious that ignore_mouse_drag_p is not accessed if !defined
3739 USE_GTK && !defined HAVE_NS.
3740
93ea6e8f
PE
3741 * intervals.c: Make symbols static if they're not exported.
3742 (merge_properties_sticky, merge_interval_right, delete_interval):
3743 Now static.
3744 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3745
77382fcc
PE
3746 * insdel.c: Make symbols static if they're not exported.
3747 However, leave prepare_to_modify_buffer alone. It's never
3748 called from outside this function, but that appears to be a bug.
3749 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3750 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3751 (adjust_after_replace_noundo): Remove; unused.
3752 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3753 (signal_before_change): Remove decls.
77382fcc 3754
9306c32e
PE
3755 * indent.c (val_compute_motion, val_vmotion): Now static.
3756
cd44d2eb
PE
3757 * image.c: Make symbols static if they're not exported.
3758 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3759 if USE_GTK.
3760 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3761 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3762
ad9a7a06
PE
3763 * fringe.c (standard_bitmaps): Now static.
3764 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3765
81626931
PE
3766 * frame.c: Make symbols static if they're not exported.
3767 (x_report_frame_params, make_terminal_frame): Now static.
3768 (get_frame_param): Now static, unless HAVE_NS.
3769 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3770 (x_get_resource_string): Remove; not used.
3771 * frame.h (make_terminal_frame, x_report_frame_params):
3772 (x_get_resource_string); Remove decls.
3773 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3774 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3775
239f9db9
PE
3776 * font.c, fontset.c: Make symbols static if they're not exported.
3777 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3778 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3779 * font.c (font_close_object): Now static.
3780 * font.h (font_close_object): Remove.
3781 * fontset.c (FONTSET_OBJLIST): Remove.
3782 (free_realized_fontset) #if-0 the body, which does nothing.
3783 (face_suitable_for_char_p): #if-0, as it's never called.
3784 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3785 * xfaces.c (face_at_string_position):
3786 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3787 since 0 is always ASCII.
3788
dfcf3579
PE
3789 * fns.c (weak_hash_tables): Now static.
3790
5045092b
PE
3791 * fileio.c: Make symbols static if they're not exported.
3792 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3793 (Vwrite_region_annotation_buffers): Now static.
3794
57a96f5c
PE
3795 * eval.c: Make symbols static if they're not exported.
3796 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3797 * lisp.h (backtrace_list): Remove decl.
3798
35f08c38
PE
3799 * emacs.c: Make symbols static if they're not exported.
3800 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3801 (fatal_error_code, fatal_error_signal_hook, standard_args):
3802 Now static.
3803 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3804 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3805 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3806 * lisp.h (fatal_error_signal_hook): Remove decl.
3807 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3808
f44bd759
PE
3809 * editfns.c: Move a (normally-unused) function to its only use.
3810 * editfns.c, lisp.h (get_operating_system_release): Remove.
3811 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3812 worth the hassle of breaking this out.
3813
b532497d
PE
3814 * xterm.c: Make symbols static if they're not exported.
3815 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3816 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3817 (x_destroy_window, x_delete_display):
3818 Now static.
3819 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3820 (x_mouse_leave): Remove; unused.
3821 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3822 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3823 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3824 Remove decls.
3825 (x_mouse_leave): Declare only if WINDOWSNT.
3826 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3827 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3828 USE_X_TOOLKIT.
3829
1675728f
PE
3830 * ftxfont.c: Make symbols static if they're not exported.
3831 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3832 HAVE_FREETYPE.
3833 * font.h (ftxfont_driver): Likewise.
3834
e4cebfca
PE
3835 * xfns.c: Make symbols static if they're not exported.
3836 (x_last_font_name, x_display_info_for_name):
3837 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3838 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3839 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3840 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3841 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3842 (last_show_tip_args): Now static.
3843 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3844 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3845 (x_screen_planes): Remove; unused.
3846 * dispextern.h (x_screen_planes): Remove decl.
3847
5bf46f05
PE
3848 * dispnew.c: Make symbols static if they're not exported.
3849 * dispextern.h (redraw_garbaged_frames, scrolling):
3850 (increment_row_positions): Remove.
3851 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3852 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3853 Now static.
3854 (redraw_garbaged_frames): Remove; unused.
3855
435f4c28
PE
3856 * xfaces.c: Make symbols static if they're not exported.
3857 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3858 Remove decls.
3859 * xterm.h (defined_color): Remove decls.
3860 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3861 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3862 (menu_face_changed_default, defined_color, free_realized_face):
3863 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3864 (ascii_face_of_lisp_face): Remove; unused.
3865
8524aef3
PE
3866 * xdisp.c: Make symbols static if they're not exported.
3867 * dispextern.h (scratch_glyph_row, window_box_edges):
3868 (glyph_to_pixel_coords, set_cursor_from_row):
3869 (get_next_display_element, set_iterator_to_next):
3870 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3871 (show_mouse_face): Remove decls
3872 * frame.h (message_buf_print): Likewise.
3873 * lisp.h (pop_message, set_message, check_point_in_composition):
3874 Likewise.
3875 * xterm.h (set_vertical_scroll_bar): Likewise.
3876 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3877 (message_buf_print, scratch_glyph_row, displayed_buffer):
3878 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3879 (get_next_display_element, show_mouse_face, window_box_edges):
3880 (frame_to_window_pixel_xy, check_point_in_composition):
3881 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3882 (glyph_to_pixel_coords): Remove; unused.
3883
16390cd2
PE
3884 * dired.c (file_name_completion): Now static.
3885
3886 * dbusbind.c (xd_in_read_queued_messages): Now static.
3887
a25f4dfa
PE
3888 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3889 * data.c (circular_list_error): Remove.
3890
14a9c8df
PE
3891 * commands.h (last_point_position, last_point_position_buffer):
3892 (last_point_position_window): Remove decls.
3893 * keyboard.c: Make these variables static.
3894
04f2d78b
CB
3895 * coding.h (coding, code_convert_region, encode_coding_gap):
3896 Remove decls.
74ab6df5
PE
3897 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3898 (iso_code_class, detect_coding, code_convert_region): Now static.
3899 (encode_coding_gap): Remove; unused.
3900
38dfbee1
PE
3901 * chartab.c (chartab_chars, chartab_bits): Now static.
3902
a2cb4e63
PE
3903 * charset.h (charset_iso_8859_1): Remove decl.
3904 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3905 Now static.
3906
127198fd
PE
3907 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3908 * ccl.c (Vccl_program_table): Now static.
3909 (check_ccl_update): Remove; unused.
3910
d85b608f
PE
3911 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3912 * category.h: ... from here.
3913 * category.c (check_category_table, set_category_set): Now static.
3914
31cd66f3
PE
3915 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3916 * lisp.h: Remove these decls.
3917
c358e587
PE
3918 * buffer.c (buffer_count): Remove unused var.
3919
e78aecca
PE
3920 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3921 so that it's not optimized away.
3922 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3923 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3924 exported only to the debugger.
3925
e192d7d3 3926 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3927 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3928
92470028
PE
3929 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3930 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3931 was inaccessible from Lisp.
3932 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3933 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3934
244ed907
PE
3935 alloc.c: Import and export fewer symbols, and remove unused items.
3936 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3937 is defined.
3938 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3939 it's not optimized away by whole-program optimization.
3940 (message_enable_multibyte, free_misc): Remove.
3941 (catchlist, handlerlist, mark_backtrace):
3942 Declare only if BYTE_MARK_STACK.
3943 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3944 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3945 (message_enable_multibyte): Remove decl.
3946 (free_misc, interval_free_list, float_block, float_block_index):
3947 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3948 (cons_free_list, last_marked_index):
3949 Now static.
3950 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3951 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3952 (mark_backtrace): Define only if BYTE_MARK_STACK.
3953 * xdisp.c (message_enable_multibyte): Now static.
3954
61c2b50e 3955 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3956 This makes it easier for human readers (and static analyzers)
3957 to see whether these variables are used from other modules.
3958 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3959 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3960 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3961 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3962 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3963 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3964 * xmenu.c, xselect.c:
3965 Declare Q* vars static if they are not used in other modules.
3966 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3967 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3968 Remove decls of unexported vars.
3969 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3970
95c82688
PE
3971 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3972
16a97296
PE
3973 Make Emacs functions such as Fatom 'static' by default.
3974 This makes it easier for human readers (and static analyzers)
3975 to see whether these functions can be called from other modules.
3976 DEFUN now defines a static function. To make the function external
3977 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3978 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3979 (Finit_image_library):
16a97296
PE
3980 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3981 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3982 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3983 Remove decls, since these functions are now static.
3984 (Funintern, Fget_internal_run_time): New decls, since these functions
3985 were already external.
95c82688 3986
16a97296
PE
3987 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3988 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3989 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3990 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3991 * keyboard.c, keymap.c, lread.c:
3992 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3993 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3994 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3995 Mark functions with DEFUE instead of DEFUN,
3996 if they are used in other modules.
3997 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3998 decls for now-static functions.
3999 * buffer.h (Fdelete_overlay): Remove decl.
4000 * callproc.c (Fgetenv_internal): Mark as internal.
4001 * composite.c (Fremove_list_of_text_properties): Remove decl.
4002 (Fcomposition_get_gstring): New forward static decl.
4003 * composite.h (Fcomposite_get_gstring): Remove decl.
4004 * dired.c (Ffile_attributes): New forward static decl.
4005 * doc.c (Fdocumntation_property): New forward static decl.
4006 * eval.c (Ffetch_bytecode): New forward static decl.
4007 (Funintern): Remove extern decl; now in .h file where it belongs.
4008 * fileio.c (Fmake_symbolic_link): New forward static decl.
4009 * image.c (Finit_image_library): New forward static decl.
4010 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4011 * intervals.h (Fprevious_property_change):
4012 (Fremove_list_of_text_properties): Remove decls.
4013 * keyboard.c (Fthis_command_keys): Remove decl.
4014 (Fcommand_execute): New forward static decl.
4015 * keymap.c (Flookup_key): New forward static decl.
4016 (Fcopy_keymap): Now static.
4017 * keymap.h (Flookup_key): Remove decl.
4018 * process.c (Fget_process): New forward static decl.
4019 (Fprocess_datagram_address): Mark as internal.
4020 * syntax.c (Fsyntax_table_p): New forward static decl.
4021 (skip_chars): Remove duplicate decl.
4022 * textprop.c (Fprevious_property_change): New forward static decl.
4023 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4024 Now internal.
4025 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4026 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4027
785bbd42
PE
4028 * editfns.c (Fformat): Remove unreachable code.
4029
8b913b57
AS
40302011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4031
4032 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4033 change. (Bug#8496)
4034
a6744a35
EZ
40352011-04-13 Eli Zaretskii <eliz@gnu.org>
4036
4037 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4038 when at ZV. (Bug#8487)
4039
e7974947
AS
40402011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4041
baad03f0
AS
4042 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4043 (Bug#8437)
4044 * keyboard.c (parse_tool_bar_item): Likewise.
4045 * sound.c (sound_cleanup, alsa_close): Likewise.
4046 * termcap.c (tgetent): Likewise.
4047 * xfns.c (x_default_font_parameter): Likewise.
4048 * xsettings.c (read_and_apply_settings): Likewise.
4049
e7974947
AS
4050 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4051 (overrun_check_free): Protoize.
4052
28272684
PE
40532011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4054
4055 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4056 since callers should never pass a negative size.
4057 Change the signature to match that of plain 'read' and 'write'; see
4058 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4059 * lisp.h: Update prototypes of emacs_write and emacs_read.
4060
11997c76
EZ
40612011-04-11 Eli Zaretskii <eliz@gnu.org>
4062
4063 * xdisp.c (redisplay_window): Don't try to determine the character
4064 position of the scroll margin if the window start point w->startp
e896f03c 4065 is outside the buffer's accessible region. (Bug#8468)
11997c76 4066
8a2cbd72
EZ
40672011-04-10 Eli Zaretskii <eliz@gnu.org>
4068
4069 Fix write-region and its subroutines for buffers > 2GB.
4070 * fileio.c (a_write, e_write): Modify declaration of arguments and
4071 local variables to support buffers larger than 2GB.
4072 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4073
4074 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4075 argument, local variables, and return value.
4076
4077 * lisp.h: Update prototypes of emacs_write and emacs_read.
4078
4079 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4080
4073e537 40812011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4082
1ebfdcb6
PE
4083 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4084
b2ded58d
PE
4085 Fix more problems found by GCC 4.6.0's static checks.
4086
7d66342c
PE
4087 * xdisp.c (vmessage): Use a better test for character truncation.
4088
bbf47d44
PE
4089 * charset.c (load_charset_map): <, not <=, for optimization,
4090 and to avoid potential problems with integer overflow.
9248994d 4091 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4092 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4093 * editfns.c (Fformat): Likewise.
1e69125e 4094 * syntax.c (skip_chars): Likewise.
3befa583 4095
e3019616
PE
4096 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4097 This also lets GCC 4.6.0 generate slightly better loop code.
4098
becfa255
PE
4099 * callint.c (Fcall_interactively): <, not <=, for optimization.
4100 (Fcall_interactively): Count the number of arguments produced,
4101 not the number of arguments given. This is simpler and lets GCC
4102 4.6.0 generate slightly better code.
4103
dae0cd48
PE
4104 * ftfont.c: Distingish more carefully between FcChar8 and char.
4105 The previous code passed unsigned char * to a functions like
4106 strlen and xstrcasecmp that expect char *, which does not
4107 conform to the C standard.
4108 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4109 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4110 char * when the C standard requires it.
4111
76032d70
PE
4112 * keyboard.c (read_char): Remove unused var.
4113
eb3f1cc8
PE
4114 * eval.c: Port to Windows vsnprintf (Bug#8435).
4115 Include <limits.h>.
4116 (SIZE_MAX): Define if the headers do not.
4117 (verror): Do not give up if vsnprintf returns a negative count.
4118 Instead, grow the buffer. This ports to Windows vsnprintf, which
4119 does not conform to C99. Problem reported by Eli Zaretskii.
4120 Also, simplify the allocation scheme, by avoiding the need for
4121 calling realloc, and removing the ALLOCATED variable.
4122
70476b54
PE
4123 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4124
12020a9e
PE
4125 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4126 But keep the doprint source code for now, as we might revamp it
4127 and use it again (Bug#8435).
ea6c7ae6
PE
4128 * lisp.h (doprnt): Remove.
4129 * Makefile.in (base_obj): Remove doprnt.o.
4130 * deps.mk (doprnt.o): Remove.
4131
5fdb398c
PE
4132 error: Print 32- and 64-bit integers portably (Bug#8435).
4133 Without this change, on typical 64-bit hosts error ("...%d...", N)
4134 was used to print both 32- and 64-bit integers N, which relied on
4135 undefined behavior.
4136 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4137 New macro.
4138 * lisp.h (error, verror): Mark as printf-like functions.
4139 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4140 Report overflow in size calculations when allocating printf buffer.
4141 Do not truncate output string at its first null byte.
4142 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4143 Truncate the output at a character boundary, since vsnprintf does not
4144 do that.
4145 * charset.c (check_iso_charset_parameter): Convert internal
4146 character to string before calling 'error', since %c now has the
4147 printf meaning.
4148 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4149 overflow when computing char to be passed to 'error'. Do not
4150 pass Lisp_Object to 'error'; pass the integer instead.
4151 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4152 formatted with plain %d.
4153
b189fa66
PE
4154 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4155
bff87ef0
PE
4156 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4157
7e2cac20
PE
4158 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4159
ce4d90b5
PE
4160 * xterm.c (x_catch_errors): Remove duplicate declaration.
4161
266c9547
PE
4162 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4163
79c49ad2
PE
4164 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4165
368f4090
JM
41662011-04-10 Jim Meyering <meyering@redhat.com>
4167
4168 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4169 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4170 return ssize_t not "int", and use size_t as the buffer length.
4171 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4172 * gnutls.h: Update declarations.
4173 * process.c (read_process_output): Use ssize_t, to match.
4174 (send_process): Likewise.
4175
a32d4040
CY
41762011-04-09 Chong Yidong <cyd@stupidchicken.com>
4177
4178 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4179
8546720e 41802011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4181
04f2d78b
CB
4182 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4183 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4184
8546720e
GM
4185 * xterm.c (handle_one_xevent):
4186 * xmenu.c (create_and_show_popup_menu):
4187 * xselect.c (x_decline_selection_request)
4188 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4189
0a2f5c1a 41902011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4191
4192 Fix some uses of `int' instead of EMACS_INT.
4193 * search.c (string_match_1, fast_string_match)
4194 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4195 (scan_buffer, find_next_newline_no_quit)
4196 (find_before_next_newline, search_command, Freplace_match)
4197 (Fmatch_data): Make some `int' variables be EMACS_INT.
4198
4199 * xdisp.c (display_count_lines): 3rd argument and return value now
4200 EMACS_INT. All callers changed.
4201 (pint2hrstr): Last argument is now EMACS_INT.
4202
4203 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4204 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4205 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4206 (decode_coding_utf_16, decode_coding_emacs_mule)
4207 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4208 (decode_coding_ccl, decode_coding_charset)
4209 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4210 (decode_coding_iso_2022, decode_coding_emacs_mule)
4211 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4212 <char_offset, last_offset>: Declare EMACS_INT.
4213 (encode_coding_utf_8, encode_coding_utf_16)
4214 (encode_coding_emacs_mule, encode_invocation_designation)
4215 (encode_designation_at_bol, encode_coding_iso_2022)
4216 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4217 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4218 Declare EMACS_INT.
4219 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4220 (encode_invocation_designation): Last argument P_NCHARS is now
4221 EMACS_INT.
4222 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4223 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4224
4225 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4226 All users changed.
4227
4228 * ccl.c (Fccl_execute_on_string): Declare some variables
4229 EMACS_INT.
4230
8546720e 42312011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4232
4233 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4234
4e19a977
CS
42352011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4236
4237 * process.c (Fformat_network_address): Doc fix.
4238
87302331
R
42392011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4240
4241 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4242
cbb59342
CY
42432011-04-08 Chong Yidong <cyd@stupidchicken.com>
4244
4245 * keyboard.c (read_char): Call Lisp function help-form-show,
4246 instead of using internal_with_output_to_temp_buffer.
4247 (Qhelp_form_show): New var.
e0d38eeb 4248 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4249
4250 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4251
4252 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4253
e67a13ab
CY
42542011-04-06 Chong Yidong <cyd@stupidchicken.com>
4255
04f2d78b
CB
4256 * process.c (Flist_processes): Remove to Lisp.
4257 (list_processes_1): Delete.
e67a13ab 4258
973f782d
EZ
42592011-04-06 Eli Zaretskii <eliz@gnu.org>
4260
7c106b1e
EZ
4261 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4262
973f782d
EZ
4263 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4264
41cf7d1a 42652011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4266
ca23cc88
PE
4267 Fix more problems found by GCC 4.6.0's static checks.
4268
f390e2d5
PE
4269 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4270
42eea0d0
PE
4271 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4272
b69769da 4273 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4274
f9541e84
PE
4275 * xdisp.c (vmessage): Mark as a printf-like function.
4276
13841b55
PE
4277 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4278
c136c10f
PE
4279 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4280
5e2d4a30
PE
4281 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4282 printf-like functions.
4283 (tiff_load): Add casts to remove these marks before passing them
4284 to system-supplied API.
4285
583f48b9
PE
4286 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4287
b25d760e
PE
4288 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4289 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4290 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4291 directly, rather than having caller test rule sign. This avoids
4292 some unnecessary tests.
4293 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4294 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4295 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4296
bc7b6697 4297 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4298 (xfont_open): Avoid unnecessary tests.
bc7b6697 4299
27ccc379
PE
4300 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4301
dcd5c89a
PE
4302 * composite.h, composite.c (composition_gstring_put_cache):
4303 Use EMACS_INT, not int, for length.
4304
b13a45c6
PE
4305 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4306 breaking out part of COMPOSITION_DECODE_RULE.
4307 (COMPOSITION_DECODE_RULE): Use it.
4308 * composite.c (get_composition_id): Remove unused local vars,
4309 by using the new macro.
4310
1e792e4d
PE
4311 * textprop.c (set_text_properties_1): Change while to do-while,
4312 since the condition is always true at first.
4313
dc6c6455 4314 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4315 (interval_deletion_adjustment): Return unsigned value.
4316 All uses changed.
dc6c6455 4317
aba7731a
PE
4318 * process.c (list_processes_1, create_pty, read_process_output):
4319 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4320 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4321 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4322 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4323 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4324
fdfc4bf3
PE
4325 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4326
fca8fe46 4327 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4328 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4329
06a0259a 4330 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4331 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4332 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4333
e7b9e80f
PE
4334 * print.c (print_error_message): Avoid int overflow.
4335
56201685
PE
4336 * font.c (font_list_entities): Redo for clarity,
4337 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4338
78834453 4339 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4340 (font_score): Avoid potential overflow in diff calculation.
78834453 4341
0bc0b309 4342 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4343 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4344
e610eaca
PE
4345 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4346
b895abce
PE
4347 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4348 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4349 can always succeed if overflow has undefined behavior.
4350
1f1d9321 4351 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4352 (wordify): Omit three unnecessary tests.
1f1d9321 4353
c59478bc
PE
4354 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4355 All callers changed. This avoids the need for an unused var.
4356
79b73827
PE
4357 * casefiddle.c (casify_region): Remove var that is set but not used.
4358
a4db5dfe
PE
4359 * dired.c (file_name_completion): Remove var that is set but not used.
4360
43aae36e
PE
4361 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4362
2a47c44d 4363 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4364 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4365
a37c69bf
PE
4366 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4367 Check for integer overflow on size calculations.
4368
328ab8e7
PE
4369 * buffer.c (Fprevious_overlay_change): Remove var that is set
4370 but not used.
4371
e5a2a5cb
PE
4372 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4373 Remove vars that are set but not used.
8d84a6eb 4374 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4375 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4376
a60e5f68
PE
4377 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4378
f661cb61 4379 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4380 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4381
f0397f5a
PE
4382 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4383 that are set but not used.
4384
8664db06 4385 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4386 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4387
6abdaa4a
PE
4388 * xselect.c (x_get_local_selection, x_handle_property_notify):
4389 Remove vars that are set but not used.
4390
0ce7538d 4391 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4392 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4393
9ae848fc
PE
4394 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4395 Remove var that is set but not used.
0b918413
PE
4396 (scroll_bar_windows_size): Now size_t, not int.
4397 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4398 Check for overflow.
9ae848fc 4399
a5a62657
PE
4400 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4401 (map_tty_color) [!defined MSDOS]: Likewise.
4402
5c5cdd39
PE
4403 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4404
66ebf983
PE
4405 * coding.c: Remove vars that are set but not used.
4406 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4407 All callers changed.
4408 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4409 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4410 (decode_coding_charset): Remove vars that are set but not used.
4411
1be4d761
PE
4412 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4413 that is set but not used.
4414
47553fa8
PE
4415 * print.c (print_object): Remove var that is set but not used.
4416
1f7196bf 4417 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4418 The gnulib version avoids calling malloc in the usual case,
4419 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4420 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4421 * filelock.c (current_lock_owner): Likewise.
4422 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4423 * sysdep.c: Include allocator.h, careadlinkat.h.
4424 (emacs_no_realloc_allocator): New static constant.
4425 (emacs_readlink): New function.
fdb61804
PE
4426 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4427 ../lib/careadlinkat.h.
d1fdcab7 4428
f84c17c7
SM
44292011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4430
4431 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4432 first non-nil return value).
4433
ef3862ad
JD
44342011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4435
4436 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4437 if not defined (Bug#8403).
4438
376a7006
JB
44392011-04-02 Juanma Barranquero <lekktu@gmail.com>
4440
4441 * xdisp.c (display_count_lines): Remove parameter `start',
4442 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4443 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4444 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4445 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4446 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4447 and thereabouts. All callers changed.
4448 (get_per_char_metric): Remove parameter `f', unused since
4449 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4450
6ca3801d
JM
44512011-04-02 Jim Meyering <meyering@redhat.com>
4452
4453 do not dereference NULL upon failed strdup
4454 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4455 (ns_get_family): Likewise.
4456
d8e2b5ba
JB
44572011-04-02 Juanma Barranquero <lekktu@gmail.com>
4458
4459 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4460
8c74fcbd
JD
44612011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4462
4463 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4464 later (Bug#8403).
4465
7200d79c
SM
44662011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4467
03408648 4468 Add lexical binding.
7200d79c 4469
03408648
SM
4470 * window.c (Ftemp_output_buffer_show): New fun.
4471 (Fsave_window_excursion):
4472 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4473
4474 * lread.c (lisp_file_lexically_bound_p): New function.
4475 (Fload): Bind Qlexical_binding.
4476 (readevalloop): Remove `evalfun' arg.
4477 Bind Qinternal_interpreter_environment.
4478 (Feval_buffer): Bind Qlexical_binding.
4479 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4480 Mark as dynamic.
4481 (syms_of_lread): Declare `lexical-binding'.
4482
4483 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4484
4485 * keyboard.c (eval_dyn): New fun.
4486 (menu_item_eval_property): Use it.
ca105506
SM
4487
4488 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4489
03408648
SM
4490 * fns.c (concat, mapcar1): Accept byte-code-functions.
4491
4492 * eval.c (Fsetq): Handle lexical vars.
4493 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4494 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4495 (FletX, Flet): Obey lexical binding.
4496 (Fcommandp): Handle closures.
4497 (Feval): New `lexical' arg.
4498 (eval_sub): New function extracted from Feval. Use it almost
4499 everywhere where Feval was used. Look up vars in lexical env.
4500 Handle closures.
4501 (Ffunctionp): Move from subr.el.
4502 (Ffuncall): Handle closures.
4503 (apply_lambda): Remove `eval_flags'.
4504 (funcall_lambda): Handle closures and new byte-code-functions.
4505 (Fspecial_variable_p): New function.
4506 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4507 but without exporting it to Lisp.
23aba0ea 4508
23aba0ea 4509 * doc.c (Fdocumentation, store_function_docstring):
03408648 4510 * data.c (Finteractive_form): Handle closures.
23aba0ea 4511
03408648
SM
4512 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4513 interactive spec.
ba83908c 4514
04f2d78b
CB
4515 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4516 New byte-codes.
03408648
SM
4517 (exec_byte_code): New function extracted from Fbyte_code to handle new
4518 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4519
03408648 4520 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4521
03408648 4522 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4523
e2abce01
JB
45242011-03-31 Juanma Barranquero <lekktu@gmail.com>
4525
4526 * xdisp.c (redisplay_internal): Fix prototype.
4527
63696a73 45282011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4529
63696a73 4530 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4531 (try_scrolling): Use it when setting scroll_limit.
4532 Limit scrolling to 100 screen lines.
63696a73
EZ
4533 (redisplay_window): Even when falling back on "recentering",
4534 position point in the window according to scroll-conservatively,
4535 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4536
4537 (try_scrolling): When point is above the window, allow searching
4538 as far as scroll_max, or one screenful, to compute vertical
4539 distance from PT to the scroll margin position. This prevents
4540 try_scrolling from unnecessarily failing when
4541 scroll-conservatively is set to a value slightly larger than the
4542 window height. Clean up the case of PT below the margin at bottom
4543 of window: scroll_max can no longer be INT_MAX. When aggressive
4544 scrolling is in use, don't let point enter the opposite scroll
4545 margin as result of the scroll.
4546 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4547 threshold of 100 lines for never-recentering scrolling.
4548
e4cc2dfc
JB
45492011-03-31 Juanma Barranquero <lekktu@gmail.com>
4550
4551 * dispextern.h (move_it_by_lines):
4552 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4553 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4554 (message_log_check_duplicate): Remove parameters `prev_bol' and
4555 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4556 (redisplay_internal): Remove parameter `preserve_echo_area',
4557 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4558
4559 * indent.c (Fvertical_motion):
4560 * window.c (window_scroll_pixel_based, Frecenter):
4561 Don't pass `need_y_p' to `move_it_by_lines'.
4562
1c470562
SM
45632011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4564
44f230aa
SM
4565 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4566 steal a few bits to be more compact.
4567 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4568 Remove unneeded casts.
4569
1c470562
SM
4570 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4571
888adce9
ZK
45722011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4573
4574 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4575 binding" message (bug#7967).
4576
f838ed7b
PE
45772011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4578
77861b95
PE
4579 Fix more problems found by GCC 4.6.0's static checks.
4580
de6dbc14
PE
4581 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4582 Remove unused local var.
4583
f838ed7b
PE
4584 * editfns.c (Fmessage_box): Remove unused local var.
4585
792c7b2b
PE
4586 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4587 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4588 Omit unused local vars.
c499e557 4589 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4590 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4591 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4592 Omit unused local var.
4593
ba0165e1
PE
4594 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4595 Don't assume string length fits in int.
32ad8845 4596 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4597 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4598
3c59b4c9
PE
4599 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4600 instead of alloca (Bug#8344).
4601
a3eed478 4602 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4603 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4604
eb4d412d
PE
4605 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4606
1658b401
PE
4607 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4608 concerns.
4609
4610 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4611
4612 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4613
9a2c6e05
PE
4614 * keyboard.c (syms_of_keyboard): Use the same style as later
4615 in this function when indexing through an array. This also
4616 works around GCC bug 48267.
4617
03d0a109
PE
4618 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4619
44f730c8
PE
4620 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4621
fe75f926
PE
4622 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4623 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4624
ffa8c828
PE
4625 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4626 This avoids undefined behavior on integer overflow, and is a bit
4627 more convenient anyway since it is compared to a size_t variable.
4628
c5101a77
PE
4629 Variadic C functions now count arguments with size_t, not int.
4630 This avoids an unnecessary limitation on 64-bit machines, which
4631 caused (substring ...) to crash on large vectors (Bug#8344).
4632 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4633 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4634 All variadic functions and their callers changed accordingly.
c5101a77
PE
4635 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4636 * data.c (arith_driver, float_arith_driver): Likewise.
4637 * editfns.c (general_insert_function): Likewise.
4638 * eval.c (struct backtrace.nargs, interactive_p)
4639 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4640 (funcall_lambda, mark_backtrace): Likewise.
4641 * fns.c (concat): Likewise.
4642 * frame.c (x_set_frame_parameters): Likewise.
4643 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4644 0 if not found, not -1. All callers changed.
4645
dd3f25f7
PE
4646 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4647 (stack_copy_size): Now size_t, not int.
4648 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4649
461c2ab9
JB
46502011-03-28 Juanma Barranquero <lekktu@gmail.com>
4651
4652 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4653 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4654 All callers changed.
4655
4656 * lisp.h (multibyte_char_to_unibyte):
4657 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4658 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4659 * character.h (CHAR_TO_BYTE8):
4660 * cmds.c (internal_self_insert):
4661 * editfns.c (general_insert_function):
4662 * keymap.c (push_key_description):
4663 * search.c (Freplace_match):
4664 * xdisp.c (message_dolog, set_message_1): All callers changed.
4665
f6d62986
SM
46662011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4667
4668 * keyboard.c (safe_run_hook_funcall): New function.
4669 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4670 don't set the hook to nil, but remove the offending function instead.
4671 (Qcommand_hook_internal): Remove, unused.
4672 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4673 Vcommand_hook_internal.
4674
4675 * eval.c (enum run_hooks_condition): Remove.
4676 (funcall_nil, funcall_not): New functions.
4677 (run_hook_with_args): Call each function through a `funcall' argument.
4678 Remove `cond' argument, now redundant.
4679 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4680 (Frun_hook_with_args_until_failure): Adjust accordingly.
4681 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4682
1db5b1ad
JB
46832011-03-28 Juanma Barranquero <lekktu@gmail.com>
4684
4685 * dispextern.h (string_buffer_position): Remove declaration.
4686
4687 * print.c (strout): Remove parameter `multibyte', unused since
4688 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4689
4690 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4691 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4692 All callers changed.
4693
4694 * w32.c (_wsa_errlist): Use braces for struct initializers.
4695
4696 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4697 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4698 All callers changed.
4699 (string_buffer_position): Likewise. Also, make static (it's never
4700 used outside xdisp.c).
4701 (cursor_row_p): Remove parameter `w', unused since
4702 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4703 (decode_mode_spec): Remove parameter `precision', introduced during
4704 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4705 All callers changed.
4706
5ffb62aa
JD
47072011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4708
4709 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4710
461c2ab9 47112011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4712
4713 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4714 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4715 (ns_update_auto_hide_menu_bar): New functions.
4716 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4717 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4718 ns_constrain_all_frames.
4719 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4720 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4721
5c380ffb
JD
47222011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4723
4724 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4725
9af30bdf
GM
47262011-03-27 Glenn Morris <rgm@gnu.org>
4727
4728 * syssignal.h: Replace RETSIGTYPE with void.
4729 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4730 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4731 Replace SIGTYPE with void everywhere.
4732 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4733 * s/template.h (SIGTYPE): Remove commented out definition.
4734
e2abce01
JB
47352011-03-26 Eli Zaretskii <eliz@gnu.org>
4736
4737 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4738 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4739
f868cd8a
JB
47402011-03-26 Juanma Barranquero <lekktu@gmail.com>
4741
59eb0929
JB
4742 * w32.c (read_unc_volume): Use parameter `henum', instead of
4743 global variable `wget_enum_handle'.
4744
4745 * keymap.c (describe_vector): Remove parameters `indices' and
4746 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4747 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4748
f868cd8a
JB
4749 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4750
4751 * keyboard.c (timer_check): Remove parameter `do_it_now',
4752 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4753 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4754 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4755
4756 * keyboard.c (read_char):
4757 * w32menu.c (w32_menu_display_help):
4758 * xmenu.c (show_help_event, menu_help_callback):
4759 Adjust calls to `show_help_echo'.
4760
4761 * gtkutil.c (xg_maybe_add_timer):
4762 * keyboard.c (readable_events):
4763 * process.c (wait_reading_process_output):
4764 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4765
4766 * insdel.c (adjust_markers_gap_motion):
4767 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4768 (gap_left, gap_right): Don't call it.
4769
2ecf6fdb
CY
47702011-03-25 Chong Yidong <cyd@stupidchicken.com>
4771
4772 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4773 incurred during fontification.
4774
6b1f9ba4
JB
47752011-03-25 Juanma Barranquero <lekktu@gmail.com>
4776
4777 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4778 (DEFVAR_PER_BUFFER): Don't pass it.
4779
4780 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4781 (scrolling_window): Don't pass it.
4782
0f4a96b5
JB
47832011-03-25 Juanma Barranquero <lekktu@gmail.com>
4784
4785 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4786
4787 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4788 and `suffix'.
4789 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4790 of variables specific to SELinux and computation of `encoded_absname'.
4791
4792 * image.c (XPutPixel): Remove unused variable `height'.
4793
4794 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4795
4796 * unexw32.c (get_section_info): Remove unused variable `section'.
4797
4798 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4799 (system_process_attributes): Remove unused variable `sess'.
4800 (sys_read): Remove unused variable `err'.
4801
4802 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4803 (w32_wnd_proc): Remove unused variable `isdead'.
4804 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4805 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4806 (x_create_tip_frame): Remove unused variable `tem'.
4807
4808 * w32inevt.c (w32_console_read_socket):
4809 Remove unused variable `no_events'.
4810
4811 * w32term.c (x_draw_composite_glyph_string_foreground):
4812 Remove unused variable `width'.
4813
1149507c
JB
48142011-03-24 Juanma Barranquero <lekktu@gmail.com>
4815
4816 * w32term.c (x_set_glyph_string_clipping):
4817 Don't pass uninitialized region to CombineRgn.
4818
9c88f339
JB
48192011-03-23 Juanma Barranquero <lekktu@gmail.com>
4820
4821 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4822 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4823 (Fx_close_connection): Remove unused variable `i'.
4824
4825 * w32font.c (w32font_draw): Return number of glyphs.
4826 (w32font_open_internal): Remove unused variable `i'.
4827 (w32font_driver): Add missing initializer.
4828
4829 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4830 (fill_in_menu): Remove unused variable `items_added'.
4831
4832 * w32term.c (last_mouse_press_frame): Remove static global variable.
4833 (w32_clip_to_row): Remove unused variable `f'.
4834 (x_delete_terminal): Remove unused variable `i'.
4835
4836 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4837 (NOTHING): Remove unused static global variable.
4838 (uniscribe_check_otf): Remove unused variable `table'.
4839 (uniscribe_font_driver): Add missing initializers.
4840
dee091a3
JD
48412011-03-23 Julien Danjou <julien@danjou.info>
4842
4843 * term.c (Fsuspend_tty, Fresume_tty):
4844 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4845 * window.c (temp_output_buffer_show):
4846 * insdel.c (signal_before_change):
4847 * frame.c (Fhandle_switch_frame):
4848 * fileio.c (Fdo_auto_save):
4849 * emacs.c (Fkill_emacs):
4850 * editfns.c (save_excursion_restore):
4851 * cmds.c (internal_self_insert):
4852 * callint.c (Fcall_interactively):
4853 * buffer.c (Fkill_all_local_variables):
4854 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4855 Use Frun_hooks.
0f4a96b5 4856 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4857 unconditionnaly since it does the check itself.
4858
2c520ab5 48592011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4860
c9c49752
PE
4861 Fix more problems found by GCC 4.5.2's static checks.
4862
8abc3f12
PE
4863 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4864 the first time through the loop, since we know p0 < p1 then.
4865 This also avoids a gcc -Wstrict-overflow warning.
4866
a2d26660
PE
4867 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4868 leading to a memory leak, possible in functions like
4869 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4870 of objects (Bug#8318).
a2d26660 4871
916c72e9
PE
4872 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4873 that could (at least in theory) be that large.
4874
19ab8a18
PE
4875 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4876 This is less likely to overflow, and avoids undefined behavior if
4877 overflow does occur. All callers changed. Use strtoul to scan
4878 for the unsigned long integer.
b7cbbd6f
PE
4879 (pint2hrstr): Simplify and tune code slightly.
4880 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4881
f0641eff
PE
4882 * scroll.c (do_scrolling): Work around GCC bug 48228.
4883 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4884
7f650bb9
PE
4885 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4886 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4887 (validate_x_resource_name): Simplify count usage.
4888 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4889
37dd57d1
PE
4890 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4891 fail (Bug#8306).
81e56e61 4892
699979fc 4893 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4894
401bf9b4
PE
4895 * process.c (Fmake_network_process): Use socklen_t, not int,
4896 where POSIX says socklen_t is required in portable programs.
4897 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4898 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4899 (Fmake_network_process, server_accept_connection):
4900 (wait_reading_process_output, read_process_output):
4901 Likewise.
4902
b93aacde
PE
4903 * process.c: Rename or move locals to avoid shadowing.
4904 (list_processes_1, Fmake_network_process):
4905 (read_process_output_error_handler, exec_sentinel_error_handler):
4906 Rename or move locals.
4dc343ee 4907 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4908 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4909 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4910 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4911 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4912
af8a867c 4913 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4914 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4915 Include tparam.h instead, since it declares them.
af8a867c
PE
4916 * cm.h (PC): Remove extern decl; tparam.h now does this.
4917 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4918 * terminfo.c: Include tparam.h, to check interfaces.
4919 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4920 (tparam): Adjust signature to match interface in tparam.h;
4921 this removes some undefined behavior. Check that outstring and len
4922 are zero, which they always are with Emacs.
4923 * tparam.h (PC, BC, UP): New extern decls.
4924
0248044d 4925 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4926 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4927
8ff096c1 4928 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4929 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4930 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4931 (ftfont_list): Remove unused local.
49eaafba
PE
4932 (get_adstyle_property, ftfont_pattern_entity):
4933 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4934 Rename locals to avoid shadowing.
8ff096c1 4935
e2be39f6
PE
4936 * xfont.c (xfont_list_family): Mark var as initialized.
4937
c9735e30
PE
4938 * xml.c (make_dom): Now static.
4939
8f5201ae
PE
4940 * composite.c (composition_compute_stop_pos): Rename local to
4941 avoid shadowing.
b246f932
PE
4942 (composition_reseat_it): Remove unused locals.
4943 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4944 (composition_update_it): Mark var as initialized.
11b61122
PE
4945 (find_automatic_composition): Mark vars as initialized,
4946 with a FIXME (Bug#8290).
8f5201ae 4947
760fbc2c
PE
4948 character.h: Rename locals to avoid shadowing.
4949 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4950 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4951 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4952 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4953 to avoid shadowing.
4954
ff08eb85
PE
4955 * textprop.c (property_change_between_p): Remove; unused.
4956
fc7bf025
PE
4957 * intervals.c (interval_start_pos): Now static.
4958
235d7abc
PE
4959 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4960
44f230aa
SM
4961 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4962 Rename locals to avoid shadowing.
3e7d6594 4963
50060332
PE
4964 * sound.c (wav_play, au_play, Fplay_sound_internal):
4965 Fix pointer signedness.
d01f234b 4966 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4967 (wav_play): Initialize a variable to 0, to prevent undefined
4968 behavior (Bug#8278).
50060332 4969
c4fc4e30
PE
4970 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4971
918436ed
PE
4972 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4973
c939f91b
PE
4974 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4975 clobbering (Bug#8298).
b9c7f648
PE
4976 * sysdep.c (sys_subshell): Likewise.
4977 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4978
6bd8c144
PE
4979 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4980 This should get cleaned up, so that child_setup has the
4981 same signature on all platforms.
4982
7710357c 4983 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4984 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4985
c59da222
CY
49862011-03-22 Chong Yidong <cyd@stupidchicken.com>
4987
4988 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4989 not to be necessary, and produces flickering.
4990
66b87493
GM
49912011-03-20 Glenn Morris <rgm@gnu.org>
4992
4993 * config.in: Remove file.
4994
45b6f6d5
JB
49952011-03-20 Juanma Barranquero <lekktu@gmail.com>
4996
4997 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4998 are now in src/globals.h.
4999 (syms_of_minibuf): Remove spurious & from previous change.
5000
3ec03f7e
LL
50012011-03-20 Leo <sdl.web@gmail.com>
5002
5003 * minibuf.c (completing-read-function): New variable.
5004 (completing-read-default): Rename from completing-read.
5005 (completing-read): Call completing-read-function.
5006
b14e3e21
CY
50072011-03-19 Juanma Barranquero <lekktu@gmail.com>
5008
5009 * xfaces.c (Fx_load_color_file):
5010 Read color file from absolute filename (bug#8250).
5011
f2b726e6
JB
50122011-03-19 Juanma Barranquero <lekktu@gmail.com>
5013
5014 * makefile.w32-in: Update dependencies.
5015
09f6ff02
EZ
50162011-03-17 Eli Zaretskii <eliz@gnu.org>
5017
5018 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5019
29a6015a
PE
50202011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5021
a3a6c54e
PE
5022 Fix more problems found by GCC 4.5.2's static checks.
5023
b766f867
PE
5024 * process.c (make_serial_process_unwind, send_process_trap):
5025 (sigchld_handler): Now static.
5026
be02381c
PE
5027 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5028 That way, the code declares only the vars that it needs.
5029 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5030 * s/cygwin.h (PTY_ITERATION): Likewise.
5031 * s/darwin.h (PTY_ITERATION): Likewise.
5032 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5033
57048744
PE
5034 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5035 * process.c (allocate_pty): Don't declare stb unless it's needed.
5036
7914961c 5037 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5038 (CONSTANTLIM): Remove; unused.
5039 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5040 Define only if needed.
7914961c 5041
b3967b18
PE
5042 * unexelf.c (unexec): Name an expression,
5043 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5044 Use a different way to cause a compilation error if anyone uses
5045 n rather than nn, a way that does not involve shadowing.
73366a00 5046 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5047
29a6015a
PE
5048 * deps.mk (unexalpha.o): Remove; unused.
5049
43cfc33e 5050 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5051 * unexec.h: New file.
ce701a33
PE
5052 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5053 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5054 Depend on unexec.h.
5055 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5056 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5057 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5058 Change as necessary to match prototype in unexec.h.
ce701a33 5059
01f44d5a
PE
5060 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5061 shadowing.
4f63c6bb 5062 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5063
a6670b0b
PE
5064 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5065 Rename locals to avoid shadowing.
5066
cef2010d 5067 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5068 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5069
d4d7173a
PE
5070 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5071
f08b802a
PE
5072 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5073 warning when compiling print.c.
5074
3ddb0639
PE
5075 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5076 instead of using an uninitialized var.
5ad03b97 5077 (font_sort_entities): Mark var as initialized.
3ddb0639 5078
170a2692
PE
5079 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5080
e663c700
PE
5081 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5082 pointers to constants.
89bc529a 5083 (font_parse_fcname): Remove unused vars.
7b81e2d0 5084 (font_delete_unmatched): Now static.
ea838e10 5085 (font_get_spec): Remove; unused.
13a547c6
PE
5086 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5087 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5088 Rename or move locals to avoid shadowing.
e663c700 5089
2a80c887 5090 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5091 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5092
1384fa33 5093 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5094 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5095
8b2c52e9
PE
5096 * alloc.c (mark_backtrace): Move decl from here ...
5097 * lisp.h: ... to here, so that it can be checked.
5098
475545b5 5099 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5100 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5101 (lisp_indirect_variable): Name an expression,
5102 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5103 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5104
b1349114 5105 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5106 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5107 Use const pointer when appropriate.
b1349114 5108
a2928364
PE
5109 * lisp.h (get_system_name, get_operating_system_release):
5110 Move decls here, to check interfaces.
5111 * process.c (get_operating_system_release): Move decl to lisp.h.
5112 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5113 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5114 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5115 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5116 (Fformat_time_string, Fencode_time, Finsert_char):
5117 (Ftranslate_region_internal, Fformat):
5118 Rename or remove local vars to avoid shadowing.
9710023e 5119 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5120
a415e694
PE
5121 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5122 avoid shadowing.
5123
8ef4622d
PE
5124 * lisp.h (eassert): Check that the argument compiles, even if
5125 ENABLE_CHECKING is not defined.
5126
946f9a5b
PE
5127 * data.c (Findirect_variable): Name an expression, to avoid
5128 gcc -Wbad-function-cast warning.
112396d6 5129 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5130 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5131 (Fmake_variable_buffer_local, Fmake_local_variable):
5132 Mark variables as initialized.
52746918 5133 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5134
e5aab7e7 5135 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5136 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5137 Rename locals to avoid shadowing.
dff45157
PE
5138 (mark_stack): Move local variables into the #ifdef region where
5139 they're used.
7bc26fdb
PE
5140 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5141 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5142 needed otherwise.
5143 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5144 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5145 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5146
e5aab7e7
PE
5147 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5148 avoids undefined behavior in theory.
5149
4da60324
PE
5150 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5151
88043301
PE
5152 Use functions, not macros, for up- and down-casing (Bug#8254).
5153 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5154 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5155 to use the following functions instead of these macros.
5156 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5157 EMACS_INT, since callers assume the returned value fits in int.
5158 (upcase1): Likewise, for UPCASE_TABLE.
5159 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5160 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5161 the race-condition problem in the old DOWNCASE.
88043301 5162
19ed5445
PE
5163 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5164 Rename locals to avoid shadowing.
5165 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5166 (regex_compile, re_search_2, re_match_2_internal):
5167 Remove unused local vars.
952db0d7
PE
5168 (FREE_VAR): Rewrite so as not to use empty "else",
5169 which gcc can warn about.
da053e48 5170 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5171 (RETALLOC_IF): Define only if needed.
5172 (WORDCHAR_P): Likewise. This one is never needed, but is used
5173 only in a comment talking about a compiler bug, so put inside
5174 the #if 0 of that comment.
5175 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5176 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5177 Remove; unused.
19ed5445 5178
1f3561e4 5179 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5180 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5181 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5182
ded6f8f7
PE
5183 * search.c (simple_search): Remove unused var.
5184
dbd37a95
PE
5185 * dired.c (compile_pattern): Move decl from here ...
5186 * lisp.h: ... to here, so that it can be checked.
5187 (struct re_registers): New forward decl.
5188
7e47afad
PE
5189 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5190
85f24f61
PE
5191 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5192 All uses changed.
5193 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5194 Rename locals to avoid shadowing.
5671df8f 5195 (Fvertical_motion): Mark locals as initialized.
85f24f61 5196
181aa2be 5197 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5198 (casify_region): Mark local as initialized.
181aa2be 5199
930d429c
PE
5200 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5201
7082eac6
PE
5202 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5203 New macros, so that the caller can use some names other than
5204 gcpro1, gcpro2, etc.
5205 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5206 of the new macros.
5207 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5208 argument, for consistency with GCPRO2_VAR, etc: it is now the
5209 prefix of the variable, not the variable itself. All uses
5210 changed.
38b2c076
PE
5211 * dired.c (directory_files_internal, file_name_completion):
5212 Rename locals to avoid shadowing.
5213
15206ed9
PE
5214 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5215 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5216 dired.c's scmp function, had undefined behavior.
5217 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5218 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5219 * buffer.h: ... to here, because these macros use current_buffer,
5220 and the new implementation with inline functions needs to have
5221 current_buffer in scope now, rather than later when the macros
5222 are used.
5223 (downcase, upcase1): New static inline functions.
5224 (DOWNCASE, UPCASE1): Reimplement using these functions.
5225 This avoids undefined behavior in expressions like
5226 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5227 from race conditions in accessing the global variables
5228 case_temp1 and case_temp2.
5229 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5230 * lisp.h (case_temp1, case_temp2): Remove their decls.
5231 * character.h (ASCII_CHAR_P): Move from here ...
5232 * lisp.h: ... to here, so that the inline functions mentioned
5233 above can use them.
5234
4a6bea26
PE
5235 * dired.c (directory_files_internal_unwind): Now static.
5236
f14b7e14
PE
5237 * fileio.c (file_name_as_directory, directory_file_name):
5238 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5239 Now static.
2893f146
PE
5240 (file_name_as_directory): Use const pointers when appropriate.
5241 (Fexpand_file_name): Likewise. In particular, newdir might
5242 point at constant storage, so make it a const pointer.
fd4ead52 5243 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5244 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5245 signedness issues.
f839df0c
PE
5246 (Fset_file_times, Finsert_file_contents, auto_save_error):
5247 Rename locals to avoid shadowing.
f14b7e14 5248
5716756e 5249 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5250 (Ftry_completion, Fall_completions): Rename or remove locals
5251 to avoid shadowing.
5716756e 5252
b4c3046a
PE
5253 * marker.c (bytepos_to_charpos): Remove; unused.
5254
b45db522
PE
5255 * lisp.h (verify_bytepos, count_markers): New decls,
5256 so that gcc does not warn that these functions aren't declared.
5257
85876d07
PE
5258 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5259 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5260 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5261 (copy_text): Remove unused local var.
85876d07 5262
03d78a21 5263 * filelock.c (within_one_second): Now static.
b3dd38ab 5264 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5265
5df8f01b
PE
5266 * buffer.c (fix_overlays_before): Mark locals as initialized.
5267 (fix_start_end_in_overlays): Likewise. This function should be
5268 simplified by using pointers-to-pointers, but that's a different
5269 matter.
b1d876f1 5270 (switch_to_buffer_1): Now static.
8f54f30a
PE
5271 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5272 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5273
a70072c9 5274 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5275 Fix pointer signedness issue.
edced198
PE
5276 (sys_subshell): Mark local as volatile if checking for lint,
5277 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5278 (MAXPATHLEN): Define only if needed.
a70072c9 5279
a0977c44
PE
5280 * process.c (serial_open, serial_configure): Move decls from here ...
5281 * systty.h: ... to here, so that they can be checked.
5282
a884fdcc
PE
5283 * fns.c (get_random, seed_random): Move extern decls from here ...
5284 * lisp.h: ... to here, so that they can be checked.
5285
604efe86 5286 * sysdep.c (reset_io): Now static.
b8950c94 5287 (wait_for_termination_signal): Remove; unused.
604efe86 5288
38fc62d9
PE
5289 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5290 (copy_keymap_item, append_key, push_text_char_description):
5291 Now static.
1004a21a 5292 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5293 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5294 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5295 (describe_map_tree):
5296 Rename locals to avoid shadowing.
38fc62d9 5297
2f2650da
PE
5298 * keyboard.c: Declare functions static if they are not used elsewhere.
5299 (echo_char, echo_dash, cmd_error, top_level_2):
5300 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5301 (read_char, kbd_buffer_get_event, make_lispy_position):
5302 (make_lispy_event, make_lispy_movement, apply_modifiers):
5303 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5304 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5305 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5306 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5307 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5308
a053e86c 5309 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5310 (mark_kboards): Move decl here ...
5311 * alloc.c (mark_kboards): ... from here.
a053e86c 5312
4752793e
PE
5313 * lisp.h (force_auto_save_soon): New decl.
5314
74f10ca7 5315 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5316 (DEFINE_DUMMY_FUNCTION): New macro.
5317 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5318 Use it.
c03cd23f
PE
5319 (main): Add casts to avoid warnings
5320 if GCC considers string literals to be constants.
74f10ca7 5321
022e70d4
PE
5322 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5323
59d6fe83
PE
5324 * dbusbind.c: Pointer signedness fixes.
5325 (xd_signature, xd_append_arg, xd_initialize):
5326 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5327 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5328 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5329 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5330
78320123
PE
5331 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5332 if GCC considers string literals to be constants.
49cebcca 5333 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5334
35ac2a97
SM
53352011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5336
fb103ca9
SM
5337 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5338 (print_preprocess, print_object): New macro to fix last change.
5339
35ac2a97
SM
5340 * print.c (print_preprocess): Don't forget font objects.
5341
62973b41
JB
53422011-03-16 Juanma Barranquero <lekktu@gmail.com>
5343
5344 * emacs.c (USAGE3): Doc fixes.
5345
0e48bb22
AS
53462011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5347
5348 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5349 structure.
5350
7684e57b
JB
53512011-03-14 Juanma Barranquero <lekktu@gmail.com>
5352
5353 * lisp.h (VWindow_system, Qfile_name_history):
5354 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5355 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5356 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5357
5358 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5359 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5360
5361 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5362 * w32console.c (detect_input_pending, read_input_pending)
5363 (encode_terminal_code):
5364 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5365 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5366 (w32_system_caret_y, Qfile_name_history):
5367 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5368 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5369 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5370 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5371 * w32proc.c (Qlocal, report_file_error):
5372 * w32term.c (Vwindow_system, updating_frame):
5373 * w32uniscribe.c (initialized, uniscribe_font_driver):
5374 Remove unneeded extern declarations.
5375
2aa46d6c
CY
53762011-03-14 Chong Yidong <cyd@stupidchicken.com>
5377
c96bbc66 5378 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5379
cffc6f3b
CY
53802011-03-13 Chong Yidong <cyd@stupidchicken.com>
5381
5382 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5383 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5384 These macros can no longer be used for assignment.
5385
44f230aa
SM
5386 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5387 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5388 (record_buffer_markers, fetch_buffer_markers): New functions for
5389 recording and fetching special buffer markers.
5390 (set_buffer_internal_1, set_buffer_temp): Use them.
5391
5392 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5393
5394 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5395
5396 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5397 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5398
5399 * xdisp.c (hscroll_window_tree):
5400 (reconsider_clip_changes): Use PT instead of BUF_PT.
5401
d251f04b
EZ
54022011-03-13 Eli Zaretskii <eliz@gnu.org>
5403
5404 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5405 $(EMACS_ROOT)/lib/intprops.h.
5406
f0c77cd1
PE
54072011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5408
3eca4629
PE
5409 Fix more problems found by GCC 4.5.2's static checks.
5410
7c86ee98
PE
5411 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5412 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5413 (xg_free_frame_widgets): Make it clear that a local variable is
5414 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5415 (gdk_window_get_screen): Make it clear that this macro is needed
5416 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5417 (int_gtk_range_get_value): New function, which avoids a diagnostic
5418 from gcc -Wbad-function-cast.
5419 (xg_set_toolkit_scroll_bar_thumb): Use it.
5420 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5421 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5422 (get_utf8_string, xg_get_file_with_chooser):
5423 Rename locals to avoid shadowing.
5424 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5425
41729b81
PE
5426 * xgselect.c (xg_select): Remove unused var.
5427
f0c77cd1
PE
5428 * image.c (four_corners_best): Mark locals as initialized.
5429 (gif_load): Initialize transparent_p to zero (Bug#8238).
5430 Mark another local as initialized.
ec6cf4c6 5431 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5432
ce0ad53d 5433 * image.c (clear_image_cache): Now static.
d5d5a617 5434 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5435 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5436 (x_edge_detection): Remove unnecessary cast that
5437 gcc -Wbad-function-cast diagnoses.
2037898d 5438 (gif_load): Fix pointer signedness.
6ae141d6
PE
5439 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5440 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5441
33383987 54422011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5443
d32df629
PE
5444 Improve quality of tests for time stamp overflow.
5445 For example, without this patch (encode-time 0 0 0 1 1
5446 1152921504606846976) returns the obviously-bogus value (-948597
5447 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5448 reports time overflow. See
5449 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5450 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5451 * editfns.c: Include limits.h and intprops.h.
5452 (TIME_T_MIN, TIME_T_MAX): New macros.
5453 (time_overflow): Move earlier, to before first use.
5454 (hi_time, lo_time): New functions, for an accurate test for
5455 out-of-range times.
5456 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5457 (Fget_internal_run_time): Don't assume time_t fits in int.
5458 (make_time): Use list2 instead of Fcons twice.
5459 (Fdecode_time): More accurate test for out-of-range times.
5460 (check_tm_member): New function.
5461 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5462 (lisp_time_argument): Don't rely on undefined left-shift and
5463 right-shift behavior when checking for time stamp overflow.
8be6f318 5464
fe31d94c
PE
5465 * editfns.c (time_overflow): New function, refactoring common code.
5466 (Fformat_time_string, Fdecode_time, Fencode_time):
5467 (Fcurrent_time_string): Use it.
5468
8be6f318
PE
5469 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5470 * dired.c (make_time): Move to ...
5471 * editfns.c (make_time): ... here.
5472 * systime.h: Note the move.
5473
09d9db2c 54742011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5475
126bc0dc
YM
5476 * fringe.c (update_window_fringes): Remove unused variables.
5477
c47cbdfd
YM
5478 * unexmacosx.c (copy_data_segment): Also copy __got section.
5479 (Bug#8223)
5480
7ac80be9
EZ
54812011-03-12 Eli Zaretskii <eliz@gnu.org>
5482
c96bbc66 5483 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5484 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5485 Constify `char *' arguments and their references according to
5486 prototypes in tparam.h.
5487
ecb0f94d 5488 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5489
7ac80be9
EZ
5490 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5491 Adapt all references accordingly.
5492
5493 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5494
ef1fd07e
TT
54952011-03-11 Tom Tromey <tromey@redhat.com>
5496
5497 * buffer.c (syms_of_buffer): Remove obsolete comment.
5498
7ef4b50c
EZ
54992011-03-11 Eli Zaretskii <eliz@gnu.org>
5500
5501 * termhooks.h (encode_terminal_code): Declare prototype.
5502
5503 * msdos.c (encode_terminal_code): Don't declare prototype.
5504
5505 * term.c (encode_terminal_code): Now external again, used by
5506 w32console.c and msdos.c.
5507
44f230aa
SM
5508 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5509 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5510
4b1ec863 55112011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5512
1714f52b 5513 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5514
4b1ec863
PE
5515 * fringe.c (update_window_fringes): Mark locals as initialized
5516 (Bug#8227).
5517 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5518
524c7aa6
PE
5519 * alloc.c (mark_fringe_data): Move decl from here ...
5520 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5521 to check its interface.
5522 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5523
a5c0af81 5524 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5525 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5526 (fontset_font): Mark local as initialized.
a9a06e0b 5527 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5528
b4716021
PE
5529 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5530
811e9bac 5531 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5532 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5533 (x_own_selection, Fx_disown_selection_internal): Rename locals
5534 to avoid shadowing.
5535 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5536
7e3ab302
PE
5537 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5538 so that the caller can use some name other than gcpro1.
5539 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5540 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5541 (Fx_backspace_delete_keys_p):
5542 Use them to avoid shadowing, and rename vars to avoid shadowing.
5543 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5544 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5545 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5546 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5547 Remove unused locals.
7e3ab302
PE
5548 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5549 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5550 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5551 macros.
f78faa98 5552
e2b13473
PE
5553 * xterm.h (x_mouse_leave): New decl.
5554
77f23912
PE
5555 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5556 Remove unused functions.
cdf4ba58
PE
5557 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5558 (x_calc_absolute_position): Now static.
7411c686 5559 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5560 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5561 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5562 unless they are used.
38d0b34a
PE
5563 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5564 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5565 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5566 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5567 (x_error_catcher, x_connection_closed, x_error_handler):
5568 (x_error_quitter, xembed_send_message, x_iconify_frame):
5569 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5570 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5571 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5572
44f230aa
SM
5573 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5574 Rename or move locals to avoid shadowing.
6b463e58 5575 (tty_defined_color, merge_face_heights): Now static.
5967d051 5576 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5577 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5578 does not deduce is never used uninitialized.
73719eba
PE
5579 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5580 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5581
426994c3 5582 * terminal.c (store_terminal_param): Now static.
5489860b 5583
032f1620 5584 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5585 (set_frame_menubar): Remove unused local.
d4323972 5586 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5587 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5588 since they might point to immutable storage.
281585b0
PE
5589 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5590 since it's unused otherwise.
032f1620 5591
367c19e5 5592 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5593 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5594 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5595 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5596 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5597 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5598 does not deduce are never used uninitialized.
70739cbe 5599
07b48fa9
PE
5600 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5601
8868a238 5602 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5603 * window.c (window_loop, size_window):
5604 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5605
7e5cf297 5606 * window.c (display_buffer): Now static.
d6550a9f
PE
5607 (size_window): Mark variables that gcc -Wuninitialized
5608 does not deduce are never used uninitialized.
a586633d
PE
5609 * window.h (check_all_windows): New decl, to forestall
5610 gcc -Wmissing-prototypes diagnostic.
5b555da1 5611 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5612
f6095868
PE
5613 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5614 shadowing.
5615 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5616 Include <limits.h>.
5617 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5618 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5619 (load_charset_map): Mark variables that gcc -Wuninitialized
5620 does not deduce are never used uninitialized.
53df7c11 5621 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5622
f38b440c
PE
5623 * coding.c (coding_set_source, coding_set_destination):
5624 Use "else { /* comment */ }" rather than "else /* comment */;"
5625 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5626 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5627 a block, when the outer 'i' will do.
5628 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5629 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5630 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5631 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5632 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5633 Rename locals to avoid shadowing.
5634 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5635 * coding.c (emacs_mule_char, encode_invocation_designation):
5636 Now static, since they're not used elsewhere.
413bb2db 5637 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5638 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5639 (decode_coding_emacs_mule): Mark variables that gcc
5640 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5641 (detect_coding_iso_2022): Initialize a local variable that might
5642 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5643 this initialization is needed. (Bug#8211)
5f58e762
PE
5644 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5645 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5646 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5647 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5648 Remove unused macros.
f38b440c 5649
232b38b9 5650 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5651 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5652 * character.c (string_count_byte8): Likewise.
232b38b9 5653
fb90da1b
PE
5654 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5655 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5656
fb93dbc2
PE
5657 * chartab.c (copy_sub_char_table): Now static, since it's not used
5658 elsewhere.
5c156ace
PE
5659 (sub_char_table_ref_and_range, char_table_ref_and_range):
5660 Rename locals to avoid shadowing.
bbcd0949 5661 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5662
7d3b3862 5663 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5664 (BIDI_BOB): Remove unused macro.
7d3b3862 5665
6be7d3da
PE
5666 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5667 deduce are never used uninitialized.
c2ed9c8b 5668 * term.c (encode_terminal_code): Likewise.
6be7d3da 5669
75f8807f 5670 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5671
50938595
PE
5672 * tparam.h: New file.
5673 * term.c, tparam.h: Include it.
5674 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5675 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5676 Move these decls to tparam.h, and make them agree with what
5677 is actually in tparam.c. The previous trick of using incompatible
5678 decls in different modules does not conform to the C standard.
5679 All callers of tparam changed to use tparam's actual API.
5680 * tparam.c (tparam1, tparam, tgoto):
5681 Use const pointers where appropriate.
5682
fbceeba2
PE
5683 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5684 * cm.h (struct cm): Likewise.
5685 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5686 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5687 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5688 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5689 (turn_on_face, init_tty): Likewise.
5690 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5691
7f3f1250
PE
5692 * term.c (term_mouse_position): Rename local to avoid shadowing.
5693
e6ca6543
PE
5694 * alloc.c (mark_ttys): Move decl from here ...
5695 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5696
c40f8d15
AS
56972011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5698
5699 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5700
cfe0661d
JB
57012011-03-09 Juanma Barranquero <lekktu@gmail.com>
5702
5703 * search.c (compile_pattern_1): Remove argument regp, unused since
5704 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5705 (compile_pattern): Don't pass it.
5706
0afb4571
J
57072011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5708
5709 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5710 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5711 for ! HAVE_GTK3.
5712 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5713
5714 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5715
5716 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5717 gdk_window_get_screen, gdk_window_get_geometry,
5718 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5719 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5720 (xg_get_pixbuf_from_pixmap): New function.
5721 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5722 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5723 Call xg_get_pixbuf_from_pixmap instead of
5724 gdk_pixbuf_get_from_drawable.
5725 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5726 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5727 (xg_check_special_colors): Use GtkStyleContext and its functions
5728 for HAVE_GTK3.
5729 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5730 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5731 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5732 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5733 Call gtk_widget_get_preferred_size.
0afb4571
J
5734 (xg_frame_resized): gdk_window_get_geometry only takes 5
5735 parameters.
44f230aa
SM
5736 (xg_win_to_widget, xg_event_is_for_menubar):
5737 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5738 (xg_set_widget_bg): New function.
5739 (delete_cb): New function.
895009e1 5740 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5741 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5742 (xg_set_background_color): Call xg_set_widget_bg.
5743 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5744 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5745 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5746 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5747 if ! HAVE_GTK3.
5748 (update_frame_tool_bar): Call gtk_widget_hide.
5749 (xg_initialize): Use GDK_KEY_g.
5750
5751 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5752 if ! HAVE_GTK3
5753 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5754
5755 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5756 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5757 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5758
1c2cc4ef
JB
57592011-03-08 Juanma Barranquero <lekktu@gmail.com>
5760
5761 * w32xfns.c (select_palette): Check success of RealizePalette against
5762 GDI_ERROR, not zero.
5763
33383987 5764See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5765
5766;; Local Variables:
5767;; coding: utf-8
aac0c6e3
MR
5768;; End:
5769
33383987 5770 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5771
5772 This file is part of GNU Emacs.
5773
5774 GNU Emacs is free software: you can redistribute it and/or modify
5775 it under the terms of the GNU General Public License as published by
5776 the Free Software Foundation, either version 3 of the License, or
5777 (at your option) any later version.
5778
5779 GNU Emacs is distributed in the hope that it will be useful,
5780 but WITHOUT ANY WARRANTY; without even the implied warranty of
5781 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5782 GNU General Public License for more details.
5783
5784 You should have received a copy of the GNU General Public License
5785 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.