Add NEWS for language/persian.el.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
edd74c35
DA
12012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Separate read and write access to Lisp_Object slots of struct frame.
4 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
5 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
6 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
7 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
8 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
9
8671676c
AS
102012-08-05 Andreas Schwab <schwab@linux-m68k.org>
11
12 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
13
663e2b3f
DA
142012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
15
16 Generalize common compile-time constants.
17 * lisp.h (header_size, bool_header_size, word_size): Now here.
18 (struct Lisp_Vector): Add comment.
19 (struct Lisp_Bool_Vector): Move up to define handy constants.
20 (VECSIZE, PSEUDOVECSIZE): Simplify.
21 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
22 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
23 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
24 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
25 * xfont.c, xmenu.c: Use word_size where appropriate.
26
d32e47af
LM
272012-08-05 Lawrence Mitchell <wence@gmx.li>
28
29 * search.c (Freplace_match): Treat \? in the replacement text
30 literally (Bug#8161).
31
e5d9c0d1
CY
322012-08-05 Chong Yidong <cyd@gnu.org>
33
34 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
35 * frame.c (Vdelete_frame_functions):
36 * emacs.c (Vkill_emacs_hook): Doc fix.
37
8da0576b
EZ
382012-08-04 Eli Zaretskii <eliz@gnu.org>
39
40 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
41 --with-x-toolkit=no builds.
42 Reported by Carsten Mattner <carstenmattner@gmail.com>.
43
02676e5d
CY
442012-08-04 Chong Yidong <cyd@gnu.org>
45
46 * syntax.c (Fmodify_syntax_entry): Doc fix.
47
97147da9
EZ
482012-08-04 Eli Zaretskii <eliz@gnu.org>
49
76151e2c
EZ
50 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
51 * w32.c (init_environment): Change the default values of many
52 environment variables in dflt_envvars[] to NULL, to avoid pushing
53 them into environment when they were not already defined. Remove
54 the code that deletes site-lisp subdirectories from the default
55 value of EMACSLOADPATH, as it is no longer needed.
56 (check_windows_init_file): Now external, not static. Use
57 Vload_path as is, without adding anything, as this function is now
58 called when Vload_path is already set up.
59
60 * w32.h (check_windows_init_file): Add prototype.
61
62 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
63 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
64 compatibility with Posix platforms.
65 (main): Move the call to check_windows_init_file to here from
66 w32.c.
67 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
68 any, in the DEFALT argument into the root of the Emacs build or
69 installation tree, as appropriate.
70
71 * callproc.c (init_callproc_1): Call decode_env_path instead of
72 doing its equivalent by hand.
73 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
74 the code that sets Vexec_path run on MS-Windows.
75
76 * lread.c (init_lread): Add comments to #ifdef's.
77
97147da9
EZ
78 * msdos.c (dos_set_window_size, IT_update_begin)
79 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
80 instead of direct references.
81
185ee146
PE
822012-08-04 Paul Eggert <eggert@cs.ucla.edu>
83
84 Export DEFAULT_REHASH_* to GDB.
85 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
86 Now constants, not macros.
87
8834c57a
PE
882012-08-03 Paul Eggert <eggert@cs.ucla.edu>
89
98c6f1e3
PE
90 Remove unnecessary casts involving pointers.
91 These casts are no longer needed now that we assume C89 or later,
92 since they involve casting to or from void *.
93 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
94 (make_pure_float, make_pure_vector):
95 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
96 * macros.c (Fstart_kbd_macro):
97 * menu.c (find_and_return_menu_selection):
98 * minibuf.c (read_minibuf_noninteractive):
99 * sysdep.c (closedir):
100 * xdisp.c (x_produce_glyphs):
101 * xfaces.c (compare_fonts_by_sort_order):
102 * xfns.c (x_real_positions, select_visual):
103 * xselect.c (x_stop_queuing_selection_requests)
104 (x_get_window_property, x_get_window_property_as_lisp_data):
105 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
106 Remove unnecessary pointer casts.
107 * alloc.c (record_xmalloc): New function.
108 * lisp.h (record_xmalloc): New decl.
109 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
110 more like a function. This is because the pointer cast is not
111 needed. All uses changed.
112 * print.c (print_string, print_error_message): Avoid length recalc.
113
8834c57a
PE
114 Improve fix for macroexp crash with debugging (Bug#12118).
115 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
116 ARRAY_MARK_FLAG when checking subscripts, because ASET is
117 not supposed to be invoked from the garbage collector.
118 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
119 (gc_aset): New function, which is like ASET but can be
120 used in the garbage collector.
121 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
122 (set_hash_index): Use it instead of ASET.
123
6dad7178
EZ
1242012-08-03 Eli Zaretskii <eliz@gnu.org>
125
126 Support symlinks on latest versions of MS-Windows.
127 * w32.c: Include winioctl.h and aclapi.h.
128 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
129 (revert_to_self): Forward declarations of static functions.
130 <static BOOL g_b_init_get_security_info>:
131 <g_b_init_create_symbolic_link>: New static flags.
132 (globals_of_w32): Initialize them to zero.
133 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
134 (map_w32_filename): Improve commentary. Simplify switch.
135 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
136 headers (most versions of MinGW w32api don't).
137 (get_security_info, create_symbolic_link)
138 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
139 New functions.
140 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
141 in the argument file name.
142 (sys_access): Call unc_volume_file_attributes only if
143 GetFileAttributes fails with network-related error codes.
144 (sys_rename): Diagnose renaming of a symlink when the user doesn't
145 have the required privileges.
146 (get_file_security_desc_by_name): Renamed from
147 get_file_security_desc.
148 (stat_worker): New function, with most of the guts of 'stat', and
149 with addition of handling of symlinks and support for 'lstat'. If
150 possible, get file's attributes and security information by
151 handle, not by name. Produce S_IFLNK bit for symlinks, when
152 called from 'lstat'.
153 (stat, lstat): New functions, call 'stat_worker'.
154 (symlink, readlink, careadlinkat): Rewritten to create and resolve
155 symlinks when the underlying filesystem supports them.
156
f162bcc3
PE
1572012-08-02 Paul Eggert <eggert@cs.ucla.edu>
158
79ea6c20
PE
159 Fix macroexp crash on Windows with debugging (Bug#12118).
160 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
161 checking subscripts; problem introduced with the recent
162 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
163 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
164 since it's used in non-static inline functions now.
165
c0ce93fd
PE
166 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
167 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 168
f162bcc3
PE
169 Use C99-style 'extern inline' if available.
170 * buffer.h (BUFFER_INLINE):
171 * category.h (CATEGORY_INLINE):
172 * character.h (CHARACTER_INLINE):
173 * charset.h (CHARSET_INLINE):
174 * composite.h (COMPOSITE_INLINE):
175 * dispextern.h (DISPEXTERN_INLINE):
176 * lisp.h (LISP_INLINE):
177 * systime.h (SYSTIME_INLINE):
178 New macro, replacing 'static inline' in this header.
179 * buffer.h, category.h, character.h, charset.h, composite.h:
180 * dispextern.h, lisp.h, systime.h:
181 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
182 * alloc.c (LISP_INLINE):
183 * buffer.c (BUFFER_INLINE):
184 * category.c (CATEGORY_INLINE):
185 * character.c (CHARACTER_INLINE):
186 * charset.c (CHARSET_INLINE):
187 * composite.c (COMPOSITE_INLINE):
188 * dispnew.c (DISPEXTERN_INLINE):
189 * sysdep.c (SYSTIME_INLINE):
190 Define to EXTERN_INLINE, so that the corresponding functions
191 are compiled into code.
192 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
193 (INLINE_HEADER_END): New macros.
194 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
195 since it's used in non-static inline functions now.
a8333d03 196 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 197
837b365b
GM
1982012-08-02 Glenn Morris <rgm@gnu.org>
199
d66b744d
GM
200 * s/: Remove empty directory.
201
837b365b
GM
202 * s/ms-w32.h: Move to ../nt/inc.
203 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
204 Update for new ms-w32.h location.
205
13294f95
PE
2062012-08-02 Paul Eggert <eggert@cs.ucla.edu>
207
208 Port to Solaris 8.
209 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
210
90df0db3
GM
2112012-08-02 Glenn Morris <rgm@gnu.org>
212
213 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
214 hard-coding the path separator.
215
4939150c
PE
2162012-08-01 Paul Eggert <eggert@cs.ucla.edu>
217
218 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
219 This how ASET and AREF are supposed to work, and makes
220 it easier to think about future improvements. See
221 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
222 * charset.h (set_charset_attr): New function.
223 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
224 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
225 (aref_addr): New function. All uses of &AREF(...) changed.
226 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
227 (set_hash_index): New functions. All lvalue-style uses of
228 HASH_KEY etc. changed.
229 * keyboard.c (set_prop): New function. All lvalue-style uses
230 of PROP changed.
231
947b2afd
AA
2322012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
233
234 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
235 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
236 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
237 * nsfns.m (ns_set_name_as_filename): Likewise.
238 * nsmenu.m (ns_update_menubar): Likewise.
239 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
240
4f5d0325
EZ
2412012-08-01 Eli Zaretskii <eliz@gnu.org>
242
2008beae
EZ
243 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
244 Adapt to latest changes in field names of the corresponding Lisp
288479f6 245 objects.
2008beae 246
4f5d0325
EZ
247 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
248
fe3cc771
GM
2492012-08-01 Glenn Morris <rgm@gnu.org>
250
251 * s/msdos.h: Remove file.
252 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
253 * Makefile.in (S_FILE): Remove.
254 (config_h): Remove S_FILE.
255
c90acc54
JB
2562012-08-01 Juanma Barranquero <lekktu@gmail.com>
257
258 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
259 Remove; moved to nt/config.nt.
260
d8a05828
DA
2612012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
262
263 Use INTERNAL_FIELD for conses and overlays.
264 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
265 Remove obsolete comment.
266 (MVAR): New macro.
267 (struct Lisp_Overlay): Use INTERNAL_FIELD.
268 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
269
8271d590
DA
2702012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
271
272 Use INTERNAL_FIELD for symbols.
273 * lisp.h (SVAR): New macro. Adjust users.
274 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
275 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
276
3193acd2
DA
2772012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
278
279 Use INTERNAL_FIELD for processes.
280 * process.h (PVAR): New macro. Adjust style.
281 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
282 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
283
3a45383a
DA
2842012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
285
286 Use INTERNAL_FIELD for windows.
287 * window.h (WVAR): New macro.
288 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
289 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
290 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
291 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
292 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
293 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
294
c1dbc63c
PE
2952012-08-01 Paul Eggert <eggert@cs.ucla.edu>
296
297 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
298
5c0c0e8a
GM
2992012-08-01 Glenn Morris <rgm@gnu.org>
300
301 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
302 Move to configure.ac.
303
552a99b4
JB
3042012-08-01 Juanma Barranquero <lekktu@gmail.com>
305
306 * makefile.w32-in (CONFIG_H): Update dependencies.
307 (CONF_POST_H): New macro.
308
309 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
310
8d8e2dfe
GM
3112012-07-31 Glenn Morris <rgm@gnu.org>
312
bc96620a
GM
313 * Makefile.in (S_FILE): No longer set by configure.
314
476b1b2d
GM
315 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
316 is available.
317 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
318
b2c7a106
GM
319 * process.h (NULL_DEVICE):
320 * emacs.c (SEPCHAR):
321 * editfns.c (USER_FULL_NAME): Let configure set them.
322
d53d062a
GM
323 * s/README, s/template.h: Remove files.
324
4515017f
GM
325 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
326
8d8e2dfe
GM
327 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
328 Move to configure.ac.
329
5b20b3cc
EZ
3302012-07-31 Eli Zaretskii <eliz@gnu.org>
331
1e0afd9a
EZ
332 * .gdbinit (xframe): Adapt to introduction of FVAR and the
333 resulting renaming of 'struct frame' members.
334
5b20b3cc
EZ
335 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
336
337 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
338 after introduction of FVAR.
339
f1310128
JD
3402012-07-31 Jan Djärv <jan.h.d@swipnet.se>
341
79e721e0
JD
342 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
343
344 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
345 instead of compositeToPoint.
346 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
347
8d7c7eed 348 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 349
e34f7f79
DA
3502012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
351
352 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
353 * lisp.h (INTERNAL_FIELD): New macro.
354 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
355 (BVAR): Change to use INTERNAL_FIELD.
356 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
357 (KVAR): Change to use INTERNAL_FIELD.
358 * frame.h (FVAR): New macro.
359 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
360 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
361 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
362 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
363 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
364
c09bfb2f
DA
3652012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
366
367 Miscellaneous fixes for non-default X toolkits.
368 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
369 * xterm.c (x_frame_of_widget): Remove redundant prototype.
370 Move under #ifdef USE_LUCID.
371 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
372 definition and usage to avoid warnings.
373
14c114ae
JD
3742012-07-31 Jan Djärv <jan.h.d@swipnet.se>
375
376 * nsterm.m (openFiles): Fix previous checkin.
377
3bd21e82
PE
3782012-07-31 Paul Eggert <eggert@cs.ucla.edu>
379
380 * indent.c (compute_motion): Remove unused local.
381
c1529ded
GM
3822012-07-31 Glenn Morris <rgm@gnu.org>
383
400d5621
GM
384 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
385
268e2432
GM
386 * conf_post.h [USG5_4]:
387 Move remaining contents of s/usg5-4-common.h here.
388 * s/usg5-4-common.h: Remove file.
389
7552f3ee
GM
390 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
391 * s/irix6-5.h: Remove file.
392
6a381852
GM
393 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
394 * s/darwin.h: Remove file.
395
c1529ded
GM
396 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
397 * s/hpux10-20.h: Remove file, which is now empty.
398
b429a4ee
GM
3992012-07-30 Glenn Morris <rgm@gnu.org>
400
401 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
402 * Makefile.in (config_h): Add conf_post.h.
403 * makefile.w32-in (CONFIG_H): Add conf_post.h.
404
adff3182
JD
4052012-07-30 Jan Djärv <jan.h.d@swipnet.se>
406
407 * nsterm.m (ns_do_open_file): New variable.
b9031d69 408 (ns_term_init): Set ns_do_open_file to YES after run returns.
adff3182
JD
409 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
410 files only if ns_do_open_file.
411
c32af1e4
PE
4122012-07-30 Paul Eggert <eggert@cs.ucla.edu>
413
7393bcbb
PE
414 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
415 This no-op macro hasn't been needed for many years.
416 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
417
c32af1e4
PE
418 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
419 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
420 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
421 gdb_make_enums_visible.
422 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
423 (DIRECTORY_SEP): Now a constant, not a macro.
424
302fc036
EZ
4252012-07-30 Eli Zaretskii <eliz@gnu.org>
426
427 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
428 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
429
430 * w32term.c <w32_keyboard_codepage>: Renamed from
431 keyboard_codepage and now external. All users changed.
432
433 * w32term.h: Add declaration of w32_keyboard_codepage.
434
435 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
436 the codepage to translate keys to Unicode. If this argument is
437 -1, use the value returned by GetConsoleCP. All callers changed.
438
88fb40b4
PE
4392012-07-30 Paul Eggert <eggert@cs.ucla.edu>
440
0aee6912
PE
441 Update .PHONY listings in makefiles.
442 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
443 bootstrap-clean, distclean, maintainer-clean, versioclean,
444 extraclean, frc.
445
88fb40b4
PE
446 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
447 This is a bit clearer. Fix some commentary typos.
448
0a763bd1
GM
4492012-07-30 Glenn Morris <rgm@gnu.org>
450
32bac6d6
GM
451 * s/netbsd.h: Let configure include signal.h if needed.
452 Remove file, which is now empty.
453
b65e7c46
GM
454 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
455 Let configure set them.
456 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
457 No more need to undefine.
0a763bd1 458
169304bd
AS
4592012-07-30 Andreas Schwab <schwab@linux-m68k.org>
460
461 * keymap.c (Fkey_description): Don't remove 0x80 bit from
462 non-single-byte char when adding meta modifier. (Bug#12090)
463
6cd7a139
DA
4642012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
465
466 Convert safe_call to use variable number of arguments.
467 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
468 (safe_call2): Fix comment.
469 * lisp.h (safe_call): Adjust prototype.
470 * coding.c (encode_coding_object): Change to use safe_call2.
471 * xfaces.c (merge_face_heights): Change to use safe_call1.
472
d34d6ffc
GM
4732012-07-30 Glenn Morris <rgm@gnu.org>
474
7b8a48e4 475 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 476 does that unconditionally. Remove file, which is now empty.
7b8a48e4 477
d34d6ffc
GM
478 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
479 Remove empty files.
480
03a660a6
PE
4812012-07-30 Paul Eggert <eggert@cs.ucla.edu>
482
483 Export to GDB most of lisp.h's remaining object-like macros.
484 * lisp.h (min, max): Move earlier, because they're used earlier now.
485 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
486 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
487 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
488 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
489 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
490 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
491 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
492 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
493 Now constants, for GDB. They need not be macros.
494 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
495 Now constants, for GDB, as well as macros, for static initializers.
496 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
497 Move to after the definition of struct Lisp_Char_Table,
498 since the former now needs that type defined.
499 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
500 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
501 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
502 New enums, for gdb_make_enums_visible.
503 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 504 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
505 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
506 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
507 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
508 enum maxargs, enum MAX_ALLOCA.
509 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
510 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
511 no longer needed, now that they are done in lisp.h.
512
e499d0ee
DA
5132012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
514
515 Cleanup string bytes checking.
516 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
517 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
518 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
519 (check_sblock, compact_small_strings): Simplify.
520
d5040d2d
PE
5212012-07-29 Paul Eggert <eggert@cs.ucla.edu>
522
523 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
524 These macros are confusing and no longer need to be defined, as
525 the enum values now suffice. All uses replaced with definiens.
526 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
527
7f259ae6
JB
5282012-07-29 Juanma Barranquero <lekktu@gmail.com>
529
530 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
531 ($(BLD)/w32console.$(O)): Update dependencies.
532
7e63e0c3
DA
5332012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
534
535 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
536 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
537 time. Adjust users.
538 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
539
ffd817eb
JD
5402012-07-29 Jan Djärv <jan.h.d@swipnet.se>
541
542 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
543 setting sitelisp (Bug#12010).
544
417a7a0e
EZ
5452012-07-29 Eli Zaretskii <eliz@gnu.org>
546
547 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
548
549 * w32heap.c (cache_system_info):
550 * w32.c (sys_rename):
551 * w32proc.c (find_child_console, sys_kill): All users changed.
552
387d4d92
PE
5532012-07-29 Paul Eggert <eggert@cs.ucla.edu>
554
555 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
556
55a6cca6
EZ
5572012-07-29 Eli Zaretskii <eliz@gnu.org>
558
559 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
560
dbcf001c
DA
5612012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
562
563 Cleanup statistics calculation in Fgarbage_collect.
564 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
565 zombies percentage calculation. Simplify elapsed time calculation.
566
e2688e4a
DA
5672012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
568
569 Generalize marker debugging code under MARKER_DEBUG and use eassert.
570 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
571 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
572 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
573 (replace_range, replace_range_2, del_range_2): Change to eassert.
574 * marker.c (byte_char_debug_check): Adjust style.
575
b46a6a83
PE
5762012-07-29 Paul Eggert <eggert@cs.ucla.edu>
577
578 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
579 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
580 long-ago-commented-out code that talks about "WIN32".
581 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
582 All uses changed.
583
e32a5799
PE
5842012-07-28 Paul Eggert <eggert@cs.ucla.edu>
585
586 Use Gnulib stdalign module (Bug#9772, Bug#9960).
587 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
588 Simplify by using alignof.
589 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
590 * lisp.h: Include <stdalign.h>.
591 (GCALIGNMENT): New macro and constant.
592 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
593 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
594 (stdalign): New macro, if not already defined.
595
df81cd29
EZ
5962012-07-28 Eli Zaretskii <eliz@gnu.org>
597
01bd1b0d
EZ
598 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
599 * w32inevt.c: Include w32inevt.h.
600 (w32_read_console_input): New inline function, calls either
601 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
602 w32_console_unicode_input.
603 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
604 (w32_kbd_patch_key, key_event): Use the codepage returned by
605 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
606 (key_event): use uChar.UnicodeChar only if
607 w32_console_unicode_input is non-zero.
608
609 * w32console.c: Include w32heap.h.
610 <w32_console_unicode_input>: New global variable.
611 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
612 family of Windows, zero otherwise.
613
614 * w32inevt.h: Declare w32_console_unicode_input.
615
df81cd29
EZ
616 * xdisp.c (init_iterator): Don't reference tip_frame in a build
617 --without-x. (Bug#11742)
618
c20fdd9e
PE
6192012-07-27 Paul Eggert <eggert@cs.ucla.edu>
620
621 Adjust GDB to reflect pvec_type changes (Bug#12036).
622 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
623 2012-07-04 changes to pseudovector representation. Problem
624 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
625
32770973 6262012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
627
628 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
629 bus address.
630 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
631
3438fe21
EZ
6322012-07-27 Eli Zaretskii <eliz@gnu.org>
633
bcfbc9de
EZ
634 * alloc.c (listn): Fix the order the arguments are consed onto the
635 list.
636
3438fe21
EZ
637 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
638 enumeration constants, as PURE and HEAP are too general, and clash
639 with other headers and sources, such as gmalloc.c and the
640 MS-Windows system headers. All users changed.
641
eeaea515
DA
6422012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
643
644 Revert last save_excursion_save and save_excursion_restore changes.
645 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
646 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
647
073c88c2
DA
6482012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
649
650 Fix recently-introduced typos in Windows port.
651 Reported by Martin Rudalics <rudalics@gmx.at>.
652 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 653 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 654
4706125e
PE
6552012-07-27 Paul Eggert <eggert@cs.ucla.edu>
656
657 Improve GDB symbol export (Bug#12036).
658 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
659 arms of an 'if', not using conditional expressions; otherwise GDB
660 complains about the types in the unevaluated arm when the argument
661 is an integer literal.
662 (xgetint): Simplify expression.
663 * alloc.c (gdb_make_enums_visible): New constant. This ports to
664 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
665 Zaretskii in <http://bugs.gnu.org/12036#13>.
666 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
667 needed now that we have gdb_make_enums_visible.
668 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
669 (enum enum_USE_LSB_TAG):
670 New enum types, packaging up enums that need to be exported to GDB.
671
694b6c97
DA
6722012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
673
674 Utility function to make a list from specified amount of objects.
675 * lisp.h (enum constype): New datatype.
676 (listn): New prototype.
677 * alloc.c (listn): New function.
678 (Fmemory_use_count, syms_of_alloc): Use it.
679 * buffer.c (syms_of_buffer): Likewise.
680 * callint.c (syms_of_callint): Likewise.
681 * charset.c (define_charset_internal): Likewise.
682 * coding.c (syms_of_coding): Likewise.
683 * keymap.c (syms_of_keymap): Likewise.
684 * search.c (syms_of_search): Likewise.
685 * syntax.c (syms_of_syntax): Likewise.
686 * w32.c (init_environment): Likewise.
687 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
688 * xdisp.c (syms_of_xdisp): Likewise.
689 * xfns.c (syms_of_xfns): Likewise.
690
6195f384
DA
6912012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
692
693 Fast save_excursion_save and save_excursion_restore.
694 * lisp.h (struct Lisp_Excursion): New data type.
695 (PVEC_EXCURSION): New pseudovector type.
696 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
697 to deal with it. Adjust comments.
698 (init_marker, attach_marker): New prototype.
699 (unchain_marker): Adjust prototype.
700 * marker.c (attach_marker): Change to global.
701 (init_marker): New function.
702 * alloc.c (Fmake_marker, build_marker): Use it.
703 (build_marker): More easserts.
704 (mark_object): Handle struct Lisp_Excursion.
705 * editfns.c (save_excursion_save, save_excursion_restore):
706 Reimplement to use struct Lisp_Excursion. Add comments.
707
5eceb8fb
PE
7082012-07-26 Paul Eggert <eggert@cs.ucla.edu>
709
710 Fix export of symbols to GDB (Bug#12036).
711 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
712 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
713 emacs.c, as this is a more-suitable home. Had this been done earlier
714 the fix for 12036 would have avoided some of the problems noted in
715 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
716 would have been more obvious.
562157c8
PE
717 * emacs.c: Do not include <verify.h>; no longer needed.
718 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
719 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
720 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
721 Remove; now done in lisp.h.
722 * lisp.h (PUBLISH_TO_GDB): New macro.
723 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
724 (DATA_SEG_BITS): Use it.
725 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
726 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
727 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
728 not be usable in #if. This simplifies things.
729
d6749401
JB
7302012-07-26 Juanma Barranquero <lekktu@gmail.com>
731
732 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
733
1781b9e9
PE
7342012-07-26 Paul Eggert <eggert@cs.ucla.edu>
735
d89518db 736 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
737 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
738 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
739 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
740 Adjust to changes in lisp.h and emacs.c, by using
741 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
742 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
743 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
744 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
745 instead of gdb_valbits.
746 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
747 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
748 instead of gdb_array_mark_flag.
749 (xboolvector): Get size from $->size, not $->header.size.
750 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
751 (xreload, hook-run, hookpost-run): Remove.
752 * emacs.c: Include <verify.h>.
753 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
754 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
755 Remove.
756 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
757 (gdb_USE_LSB_TAG): New enum constants.
758 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
759 Also define these as enum constants, so they're visible to GDB.
760 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
761 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
762 as constants, so they're visible to GDB.
763 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
764 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
765 Now enum constants, not macros, so they're visible to GDB.
766 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
767 more convenient now. All uses changed.
768 (VALMASK) [USE_LSB_TAG]: Also define in this case.
769 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
770
3628596a
DA
7712012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
772
773 Explicitly free restriction data that are not needed anymore.
774 * editfns.c (save_restriction_restore): Free restriction data.
775
7abaf5cc
SM
7762012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
777
778 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
779 add argument, tune behavior, and adjust all callers.
780
71f88e00
PE
7812012-07-25 Paul Eggert <eggert@cs.ucla.edu>
782
783 Use typedef for EMACS_INT, EMACS_UINT.
784 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
785 than macros. This simplifies debugging in the usual case, since
786 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
787 and it allows expressions involving EMACS_INT casts.
788 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
789
57ec3034
JD
7902012-07-25 Jan Djärv <jan.h.d@swipnet.se>
791
792 * nsterm.m (ns_read_socket): Return early if there is a modal
793 window (Bug#12043).
794
8137e7b3
MR
7952012-07-25 Martin Rudalics <rudalics@gmx.at>
796
797 * frame.c (Fredirect_frame_focus): In doc-string don't mention
798 that FOCUS-FRAME can be omitted.
799
04e9897c
DA
8002012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
801
802 Adjust buffer text indirection counters at the end of Fkill_buffer.
803 * buffer.c (Fkill_buffer): Adjust indirection counters when the
804 buffer is definitely dead. This should really fix an issue reported
805 by Christoph Scholtes again. (Bug#12007).
806 (init_buffer_once): Initialize indirection counters of
807 buffer_defaults and buffer_local_symbols (for sanity and safety).
808
8a0484e1
EZ
8092012-07-24 Eli Zaretskii <eliz@gnu.org>
810
811 * xdisp.c (init_iterator): Don't compute dimensions of truncation
812 and continuation glyphs on tooltip frames, leave them at zero.
813 Avoids continued lines in tooltips. (Bug#11832)
814
fa691a83
DA
8152012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
816
817 Simplify copy_overlay.
04e9897c 818 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
819 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
820
436bc8e0
EZ
8212012-07-23 Eli Zaretskii <eliz@gnu.org>
822
823 * print.c (print_object): Don't crash when a frame's name is nil
824 or invalid. (Bug#12025)
825
826 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
827 it signals an error when a tooltip frame is being created.
828
d7a7fda3
DA
8292012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
830
831 Cleanup miscellaneous objects allocation and initialization.
832 * alloc.c (allocate_misc): Change to static. Add argument to
833 specify the subtype. Adjust comment and users.
834 (build_overlay): New function.
835 * buffer.c (copy_overlays, Fmake_overlay): Use it.
836 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
837 (allocate_misc): Remove prototype.
838 (build_overlay): Add prototype.
839
8402012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
841
842 Swap buffer text indirection counters in Fbuffer_swap_text.
843 * buffer.c (Fbuffer_swap_text): Swap indirections too.
844 This avoids crash reported by Christoph Scholtes at
845 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
846
9d7fa573
JD
8472012-07-22 Jan Djärv <jan.h.d@swipnet.se>
848
849 * nsmenu.m (Popdown_data): New struct.
850 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
851 free Popdown_data.
852 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
853 (initWithContentRect): Make imgView and contentView non-static
854 and autorelease them. Also autorelease img and matrix (Bug#12005).
855 (dealloc): Remove (Bug#12005).
856
0dd6d66d
DA
8572012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
858
859 Adjust consing_since_gc when objects are explicitly freed.
860 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
861 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
862 (free_cons, free_misc): Subtract object size from consing_since_gc.
863
d36d71df
DA
8642012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
865
866 Simplify and cleanup markers positioning code.
867 * marker.c (attach_marker): More useful eassert.
868 (live_buffer, set_marker_internal): New function.
869 (Fset_marker, set_marker_restricted): Use set_marker_internal.
870 (set_marker_both, set_marker_restricted_both): Use live_buffer.
871
fb9ea40f
PE
8722012-07-22 Paul Eggert <eggert@cs.ucla.edu>
873
874 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
875 as it's limited by the amount of memory, not by INT_MAX.
876
2d5c5f7d
EZ
8772012-07-21 Eli Zaretskii <eliz@gnu.org>
878
07fb592e
EZ
879 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
880 in special-event-map. See the discussion at
881 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
882 for the reasons.
883
37a9eac8 884 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
885 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
886 Fabrice Popineau <fabrice.popineau@supelec.fr>.
887
c4328746
JD
8882012-07-21 Jan Djärv <jan.h.d@swipnet.se>
889
890 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 891 (conversationIdentifier): Return value is NSInteger.
784051c4 892 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 893
6e5d1c12
CY
8942012-07-21 Chong Yidong <cyd@gnu.org>
895
896 * window.c (decode_any_window): Signal an error if the window is
897 on a dead frame (Bug#11984).
898
9928463d
DA
8992012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
900
901 Add indirection counting to speed up Fkill_buffer.
902 * buffer.h (struct buffer): New member.
903 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
904 (Fmake_indirect_buffer): Set indirection counter to -1, increment
905 base buffer indirection counter.
906 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
907 (Fkill_buffer): Adjust indirection counters as needed, don't walk
908 through buffer list if indirection counter is 0.
909
f8643a6b
DA
9102012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
911
912 Extend the value returned by Fgarbage_collect with heap statistics.
913 * alloc.c (Qheap): New symbol.
914 (syms_of_alloc): DEFSYM it.
915 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
916 (Fmemory_free): Remove.
917 (syms_of_alloc): Don't defsubr it.
918 * buffer.c (Fcompact_buffer): Remove.
919 (syms_of_buffer): Don't defsubr it.
920
dac616ff
DA
9212012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
922
923 Make maybe_gc inline.
924 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
925 * lisp.h (consing_since_gc, gc_relative_threshold)
926 (memory_full_cons_threshold): Revert declaration.
927 (maybe_gc): Remove prototype, define as inline.
928 * alloc.c: Remove old commented-out code.
929 (consing_since_gc, gc_relative_threshold)
930 (memory_full_cons_threshold): Revert to global.
931 (maybe_gc): Remove.
932
d7ea76b4
DA
9332012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
934
935 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
936 * lisp.h (build_unibyte_string): New function.
937 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
938 * sysdep.c, w32fns.c, xfns.c: Use it.
939 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
940 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
941 Adjust users accordingly.
942 * font.h (font_open_by_name): Adjust prototype.
943
765e61e3
DA
9442012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
945
946 Cleanup calls to Fgarbage_collect.
947 * lisp.h (maybe_gc): New prototype.
948 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
949 Remove declarations.
950 * alloc.c (maybe_gc): New function.
951 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
952 Make them static.
953 * bytecode.c (MAYBE_GC): Use maybe_gc.
954 * eval.c (eval_sub, Ffuncall): Likewise.
955 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
956 to avoid dependency from auto-save feature.
957
52b852c7
PE
9582012-07-19 Paul Eggert <eggert@cs.ucla.edu>
959
960 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
961 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
962 'for_each_per_buffer_object_at'.
963 All uses changed. It's better to use upper-case for macros that
964 cannot be implemented as functions, to give the reader a clue
965 that they're special.
966
5db81e33
SM
9672012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
968
969 * alloc.c (Fgarbage_collect): Tweak docstring.
970
5b835e1d
DA
9712012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
972
973 Tweak the value returned from Fgarbage_collect again.
974 * alloc.c (Fgarbage_collect): New return value, as confirmed in
975 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
976 Adjust documentation.
977 (total_vector_bytes): Rename to total_vector_slots, adjust
978 accounting.
979 (total_free_vector_bytes): Rename to total_free_vector_slots,
980 adjust accounting.
981 (Qstring_bytes, Qvector_slots): New symbols.
982 (syms_of_alloc): DEFSYM them.
983
9cd47b72
DA
9842012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
985
986 Buffer compaction primitive which may be used from Lisp.
987 * buffer.c (compact_buffer, Fcompact_buffer): New function.
988 (syms_of_buffer): Register Fcompact_buffer.
989 * alloc.c (Fgarbage_collect): Use compact_buffer.
990 * buffer.h (compact_buffer): New prototype.
991 (struct buffer_text): New member.
992
d17337e5
DA
9932012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
994
995 New macro to iterate over all buffers, miscellaneous cleanups.
996 * lisp.h (all_buffers): Remove declaration.
997 * buffer.h (all_buffers): Add declaration, with comment.
998 (for_each_buffer): New macro.
999 * alloc.c (Fgarbage_collect, mark_object): Use it.
1000 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1001 (init_buffer): Likewise.
1002 * data.c (Fset_default): Likewise.
1003 * coding.c (code_conversion_restore): Remove redundant check
1004 for dead buffer.
1005 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1006
60cfd278
AS
10072012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1008
1009 Fix bug that created negative-length intervals.
1010 * intervals.c (merge_interval_right, merge_interval_left):
1011 Do not zero out this interval if it is absorbed by its children,
1012 as this interval's total length doesn't change in that case. See
1013 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1014
d06714cb
PE
10152012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1016
83713154
PE
1017 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1018 when invoking (make-bool-vector N t) and N is a positive
1019 multiple of 8 -- the last 8 bits were mistakenly cleared.
1020
d06714cb
PE
1021 Remove some struct layout assumptions in bool vectors.
1022 * alloc.c (bool_header_size): New constant.
1023 (header_size, word_size): Move earlier, as they're now used earlier.
1024 Use 'word_size' in a few more places, where it's appropriate.
1025 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1026 padding before the data member of a bool vector.
1027 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1028 than doing the check by hand with an abort ().
1029
464d5a5e
SM
10302012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1031
5fbc0409
SM
1032 * eval.c (Fdefvar): Don't check constants since we only set the var if
1033 it's not yet defined anyway (bug#11904).
1034
464d5a5e
SM
1035 * lisp.h (last_undo_boundary): Declare new var.
1036 * keyboard.c (command_loop_1): Set it.
1037 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1038 were auto-added by the command loop (bug#11774).
1039
8dc2e44a
AS
10402012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1041
1042 * w32font.c (Qsymbol): Remove local definition.
1043 (syms_of_w32font): Don't DEFSYM it.
1044
169925ec
DA
10452012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1046
1047 Fix sweep_vectors to handle large bool vectors correctly.
1048 * alloc.c (sweep_vectors): Account total_vector_bytes for
1049 bool vectors larger than VBLOCK_BYTES_MAX.
1050
5fbfb018
CY
10512012-07-18 Chong Yidong <cyd@gnu.org>
1052
1053 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1054 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1055
3ab6e069
DA
10562012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1057
1058 Return more descriptive data from Fgarbage_collect.
1059 Suggested by Stefan Monnier in
1060 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1061 * alloc.c (bounded_number): New function.
1062 (total_buffers, total_vectors): New variable.
1063 (total_string_size): Rename to total_string_bytes, adjust users.
1064 (total_vector_size): Rename to total_vector_bytes, adjust users.
1065 (sweep_vectors): Account total_vectors and total_vector_bytes.
1066 (Fgarbage_collect): New return value. Adjust documentation.
1067 (gc_sweep): Account total_buffers.
1068 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1069 (VECTOR_SIZE): Remove.
1070 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1071 (Qinterval, Qmisc): New symbols.
1072 (syms_of_data): Initialize them.
1073 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1074 (Qcons, Qbuffer): New declarations.
1075
6d02fe5b
PE
10762012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1077
1078 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1079 Round up, not down. Improve doc.
1080
b7ffe040
DA
10812012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1082
1083 Restore old code in allocate_string_data to avoid Faset breakage.
1084 Reported by Julien Danjou <julien@danjou.info> in
1085 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1086 * alloc.c (allocate_string_data): Restore old code with minor
1087 adjustments, fix comment to explain this subtle issue.
1088
4dc7c8d5
SM
10892012-07-17 Eli Zaretskii <eliz@gnu.org>
1090
1091 Remove FILE_SYSTEM_CASE.
1092 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1093
1094 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1095 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1096 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1097 call-process-region passes it through expand-file-name.
1098
1099 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1100
11012012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1102
1103 Fix crash when creating indirect buffer (Bug#11917)
1104 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1105 Don't handle unbound variables specially if non-zero.
1106 (Fbuffer_local_variables): Pass zero.
1107 (clone_per_buffer_values): Pass non-zero.
1108
11092012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1110
1111 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1112 to make the loop interruptible.
1113
11142012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1115
1116 * gnutls.c (emacs_gnutls_handshake): Only retry if
1117 GNUTLS_E_INTERRUPTED.
1118
cce7fefc
DA
11192012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1120
1121 Cleanup and convert miscellaneous checks to eassert.
1122 * alloc.c (mark_interval): Fix comment, partially rephrase
1123 old comment from intervals.h (see below).
1124 * intervals.c (find_interval, adjust_intervals_for_insertion)
1125 (delete_interval, adjust_intervals_for_deletion)
1126 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1127 Convert to eassert.
1128 (adjust_intervals_for_insertion, make_new_interval):
1129 Remove obsolete and unused code.
1130 * intervals.h (struct interval): Remove obsolete comment.
1131 * textprotp.c (erase_properties): Remove unused code.
1132 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1133 (Fremove_list_of_text_properties): Convert to eassert.
1134
9ea10cc3
CY
11352012-07-17 Chong Yidong <cyd@gnu.org>
1136
1137 * editfns.c (Finsert_char): Doc fix.
1138
3900d5de
DA
11392012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1140
1141 Fix previous change to make Fmemory_free always accurate.
1142 * alloc.c (make_interval): Update total_free_intervals.
1143 (make_float): Likewise for total_free_floats.
1144 (free_cons, Fcons): Likewise for total_free_conses.
1145 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1146 Likewise for total_free_vector_bytes.
1147 (Fmake_symbol): Likewise for total_free_symbols.
1148 (bytes_free): Remove.
1149
7098646f
DA
11502012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1151
1152 Simple free memory accounting feature.
1153 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1154 (sweep_vectors): Accumulate size of free vectors.
1155 (Fgarbage_collect): Setup bytes_free.
1156 (Fmemory_free): New function.
1157 (syms_of_alloc): Register it.
1158
22657b40
DA
11592012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1160
1161 Cleanup overlays checking.
1162 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1163 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1164 eassert and OVERLAYP.
1165 (sort_overlays): Change to use OVERLAYP.
1166
ddfc8813
RK
11672012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1168
1169 * editfns.c (Finsert_char): Make it interactive, and make the
1170 second arg optional. Copy interactive spec and docstring from
1171 ucs-insert.
1172
7c26cf3c
PE
11732012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1174
1175 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1176 Unlike the other wrapped functions, fabs has an unspecified
1177 effect on errno.
1178
5d127af9
JD
11792012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1180
1181 * nsterm.m (keyDown): Interpret flags without left/right bits
1182 as the left key (Bug#11670).
1183
6a0dd1d7
DA
11842012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1185
1186 Remove empty and useless init functions.
1187 * lisp.h (init_character_once, init_fns, init_image)
1188 (init_filelock, init_sound): Remove prototype.
1189 * character.c (init_character_once): Remove.
1190 * filelock.c (init_filelock): Likewise.
1191 * fns.c (init_fns): Likewise.
1192 * image.c (init_image): Likewise.
1193 * sound.c (init_sound): Likewise.
1194 * emacs.c (main): Adjust accordingly.
1195
7a6136fd
DA
11962012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1197
1198 * gtkutil.h: Tiny cleanups.
1199 (use_old_gtk_file_dialog): Remove useless declaration.
1200 (xg_uses_old_file_dialog): Add suggested const attribute.
1201
ce811ad9
EZ
12022012-07-15 Eli Zaretskii <eliz@gnu.org>
1203
1204 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1205 (bidi_paragraph_init): Use it to limit search forward for a strong
1206 directional character in abnormally large paragraphs full of
1207 neutral or weak characters. (Bug#11943)
1208
c9adfeaa
SF
12092012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1210
1211 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1212 the toolbar (Bug#9451).
1213 (xg_make_tool_item): Give the widget event box a transparent
1214 background.
1215
fff62aa9
DA
12162012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1217
1218 Cleanup basic allocation variables and functions.
1219 * alloc.c (ignore_warnings, init_intervals, init_float)
1220 (init_cons, init_symbol, init_marker): Remove.
1221 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1222 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1223 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1224 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1225 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1226 (staticidx, init_alloc_once, init_strings, free_ablock):
1227 Remove redundant initialization.
1228 * fns.c (init_weak_hash_tables): Remove.
1229 * lisp.h (init_weak_hash_tables): Remove prototype.
1230
9730daca
DA
12312012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1232
1233 Use zero_vector where appropriate.
1234 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1235 accordingly.
1236 * lisp.h (zero_vector): New declaration.
1237 * font.c (null_vector): Remove.
1238 (syms_of_font): Remove initialization and staticpro.
1239 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1240 * keymap.c (Faccessible_keymaps): Likewise.
1241
2e2d2a13
LL
12422012-07-15 Leo Liu <sdl.web@gmail.com>
1243
1244 * fringe.c: Fix typo in comments.
1245
cd276f6e
LL
12462012-07-14 Leo Liu <sdl.web@gmail.com>
1247
1248 * fringe.c: Add a new bitmap exclamation-mark.
1249
5a1131d9
EZ
12502012-07-14 Eli Zaretskii <eliz@gnu.org>
1251
1252 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1253
1254 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1255 (HAVE_MENUS): Don't define, defined by editing config.in with
1256 msdos/sed2v2.inp.
1257 (GMALLOC_INHIBIT_VALLOC): Don't define.
1258 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1259
22e983b7
JB
12602012-07-14 Juanma Barranquero <lekktu@gmail.com>
1261
1262 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1263
5b3f250f
GM
12642012-07-14 Glenn Morris <rgm@gnu.org>
1265
1266 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1267 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1268 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1269
33d63ff4
GM
12702012-07-13 Glenn Morris <rgm@gnu.org>
1271
5b633342
GM
1272 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1273
33d63ff4
GM
1274 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1275 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1276
b55b9f85
JD
12772012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1278
0dc8cf50
JD
1279 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1280 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1281 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1282 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1283 where appropriate.
1284 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1285 as boolean expression.
1286 (x_set_window_size): Remove unused variable toolbar.
1287 (ns_get_color_default, ns_mod_to_lisp): Remove.
1288 (ns_mouse_position): Remove unused variables xchar and ychar.
1289 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1290 (ns_set_vertical_scroll_bar): Remove unused variable count.
1291 (ns_delete_terminal): Remove unused variable i.
1292 (ns_term_init): Remove unused variables r, g and b.
1293 (mouseDown): Remove unused variable window.
1294 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1295 (initFrameFromEmacs): Remove unused variable vbextra.
1296 (mouseEntered): Remove unused variables p and dpyinfo.
1297 (mouseExited): Remove unused variables p and r.
1298 (ns_define_frame_cursor, ns_clear_frame_area)
1299 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1300 (menuDown): Assign [sender tag] to variable and cast the variable.
1301
1302 * nsterm.h (menuDown): Add id as type to argument sender.
1303 (ns_display_info_for_name): Add Lisp_Object argument.
1304 (ns_term_init): Add Lisp_Object argument.
1305 (ns_map_event_to_object): Add void argument.
1306 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1307 prototype with arguments and only declare if __OBJC__.
1308 (nxatoms_of_nsselect): Add void argument.
1309 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1310 (ns_alloc_autorelease_pool): Add void argument.
1311 (ns_release_autorelease_pool): Add void* argument.
1312 (ns_get_defaults_value): Add const char* argument.
1313
1314 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1315 (initFromContents): Use SSDATA where appropriate.
1316 (ns_update_menubar): Add braces to ambigous if-else.
1317 (initWithTitle): Put () around assignment in if statement.
1318 (ns_menu_show): Remove unused variables window and keymap.
1319 (update_frame_tool_bar): Remove unused variable selected_p.
1320 (initWithContentRect): Remove unused variable this_cmd_name.
1321
1322 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1323 appropriate.
1324 (setXBMColor): Remove unused variable len.
1325 (setPixmapData): Put () around assignment in loop statement.
1326
1327 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1328 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1329 where appropriate.
1330 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1331 around assignment in loop statement.
1332 (nsfont_open): Remove unused variable i.
1333 (nsfont_open): Remove unused variable len.
1334 (nsfont_draw): Remove unused variable cs.
1335
1336 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1337 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1338 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1339 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1340 (Fns_font_name, Fns_perform_service)
1341 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1342 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1343 (ns_set_name): Remove unused variable view.
1344 (x_set_menu_bar_lines): Remove unused variable olines.
1345 (x_set_tool_bar_lines): Remove unused variable root_window.
1346 (Fns_list_colors): Put () around assignment in while statement.
1347 (Fns_perform_service): Remove unused variable len.
1348 (Fns_display_usable_bounds): Remove unused variable top.
1349 (syms_of_nsfns): Remove unused variable i.
1350
b55b9f85
JD
1351 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1352 memcpy (Bug#11907).
1353
ed9265fc 13542012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1355
1356 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1357 and free it with DestroyExceptionInfo (Bug#11558).
1358
ef099b57
JB
13592012-07-13 Juanma Barranquero <lekktu@gmail.com>
1360
1361 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1362 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1363 Set here, not in nt/config.nt.
1364
ea814a5d
EZ
13652012-07-13 Eli Zaretskii <eliz@gnu.org>
1366
1367 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1368 cursor overflow into the last glyph on display line when the right
1369 fringe is off. (Bug#11832)
1370
1a952767
PE
13712012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1372
1373 * xdisp.c (produce_special_glyphs): Now static.
1374 * dispextern.h (produce_special_glyphs): Remove decl.
1375
983188fd
GM
13762012-07-13 Glenn Morris <rgm@gnu.org>
1377
8d7c7eed 1378 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1379 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1380
983188fd
GM
1381 * s/usg5-4-common.h (USG, USG5):
1382 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1383 * s/sol2-6.h (SOLARIS2):
1384 * s/irix6-5.h (IRIX6_5):
1385 * s/hpux10-20.h (USG, USG5, HPUX):
1386 * s/gnu-linux.h (USG, GNU_LINUX):
1387 * s/freebsd.h (BSD_SYSTEM):
1388 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1389 * s/cygwin.h (CYGWIN):
1390 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1391 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1392
d1e68667 13932012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1394
1395 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1396
6de0e799
GM
13972012-07-13 Glenn Morris <rgm@gnu.org>
1398
739ae010
GM
1399 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1400
dbee5793
GM
1401 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1402
6de0e799
GM
1403 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1404 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1405
b82da769
GM
14062012-07-12 Glenn Morris <rgm@gnu.org>
1407
4fae5a7a 1408 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1409
1410 * process.c (init_process_emacs): Rename from init_process.
1411 The old name is also the name of a Mach system call.
1412 * lisp.h, emacs.c: Update for this name change.
1413 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1414 longer needed.
1415
5a979817
EZ
14162012-07-12 Eli Zaretskii <eliz@gnu.org>
1417
1418 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1419 memmove call that removes glyphs covered by the left truncation
1420 glyph. Improve commentary.
1421 (display_line): Fix display of continuation glyphs on GUI frames
1422 when the right fringe is turned off and variable-size fonts are
1423 used in the window. Move the code that appends a stretch glyph to
1424 produce_special_glyphs, so that it could be used for truncation
1425 and continuation glyphs alike.
1426 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1427 glyph of a suitably computed width, to align the special glyphs at
1428 the window margin. Code moved from display_line. (Bug#11832)
1429
3e91a053
GM
14302012-07-12 Glenn Morris <rgm@gnu.org>
1431
ba9e4b84
GM
1432 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1433
1434 * s/gnu-linux.h, s/hpux10-20.h:
1435 Do not unconditionally define HAVE_XRMSETDATABASE.
1436
3e91a053
GM
1437 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1438
b300b1f4
PE
14392012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1440
1441 Fix typos that broke OS X build.
1442 Reported by Randal L. Schwartz in
1443 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1444 * nsterm.m (ns_timeout): Add missing local decl.
1445 (ns_get_color): snprintf -> sprintf, to fix typo.
1446
6e777848
GM
14472012-07-12 Glenn Morris <rgm@gnu.org>
1448
3f922c37
GM
1449 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1450 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1451 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1452 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1453
0ab7b23a
GM
1454 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1455 Move PTY_OPEN to configure.
1456
6e777848
GM
1457 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1458 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1459 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1460
4a7edc24
DA
14612012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1462
1463 Use empty_unibyte_string where applicable.
1464 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1465 * lread.c (read1): Likewise.
1466 * xsettings.c (syms_of_xsettings): Likewise.
1467
308aab79
GM
14682012-07-12 Glenn Morris <rgm@gnu.org>
1469
42bd1719
GM
1470 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1471 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1472 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1473 * s/hpux10-20.h (RUN_TIME_REMAP):
1474 * s/bsd-common.h (TABDLY): Move to configure.
1475
1476 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1477
1478 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1479
ea0bbd17 1480 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1481 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1482
1483 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1484
308aab79
GM
1485 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1486 * s/template.h: Move NARROWPROTO to configure.
1487
ee1cf5cf
GM
14882012-07-11 Glenn Morris <rgm@gnu.org>
1489
30fe9bf4
GM
1490 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1491 unused since 2011-01-17 change to systty.h.
1492
ee1cf5cf
GM
1493 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1494 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1495 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1496
63e47e07
PE
14972012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1498
1499 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1500
c43fb4c3
GM
15012012-07-11 Glenn Morris <rgm@gnu.org>
1502
1503 * s/darwin.h, s/gnu-linux.h, s/template.h:
1504 Move INTERRUPT_INPUT to configure.
1505
e8df9267
DA
15062012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1507
1508 Minor adjustments to interning code.
1509 * lisp.h (intern, intern_c_string): Redefine as static inline
1510 wrappers for intern_1 and intern_c_string_1, respectively.
1511 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1512 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1513 Vobarray checking.
e8df9267
DA
1514 * font.c (font_intern_prop): Likewise. Adjust comment.
1515 * w32font.c (intern_font_name): Likewise.
1516
34348bd4
AS
15172012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1518
d96a1e0c
AS
1519 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1520
34348bd4
AS
1521 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1522 of Fcar/Fcdr if possible.
1523 * font.c (check_otf_features): Likewise.
1524 * fontset.c (Fnew_fontset): Likewise.
1525 * gnutls.c (Fgnutls_boot): Likewise.
1526 * minibuf.c (read_minibuf): Likewise.
1527 * msdos.c (IT_set_frame_parameters): Likewise.
1528 * xmenu.c (Fx_popup_dialog): Likewise.
1529 * w32menu.c (Fx_popup_dialog): Likewise.
1530
c8add24e
GM
15312012-07-11 Glenn Morris <rgm@gnu.org>
1532
4b575b3c
GM
1533 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1534 since nothing has defined it on these platforms.
1535
09f4e3b0
GM
1536 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1537 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1538
172bedef
GM
1539 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1540 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1541 Move CLASH_DETECTION to configure.
1542
249685df
GM
1543 * s/gnu.h: Remove file, which is now empty.
1544
c8add24e
GM
1545 * s/gnu.h, s/gnu-linux.h:
1546 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1547
b41253a3
JW
15482012-07-11 John Wiegley <johnw@newartisans.com>
1549
1550 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1551 function attribute, so we only use it if it exists in the
1552 compiler.
1553
d923b542
DA
15542012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1555
1556 Avoid call to strlen in fast_c_string_match_ignore_case.
1557 * search.c (fast_c_string_match_ignore_case): Change to use
1558 length argument. Adjust users accordingly.
1559 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1560
5ebbef1d
PE
15612012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1562
bb352260
PE
1563 Assume mkdir, rmdir.
1564 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1565 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1566
57054ddd
PE
1567 Assume rename.
1568 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1569
b747d3f7
PE
1570 Assume perror.
1571 * s/hpux10-20.h (HAVE_PERROR): Remove.
1572 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1573 Remove dummy definition, as this problem was obsolete long ago.
1574
5ebbef1d
PE
1575 Assume strerror.
1576 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1577
984e7f30
DA
15782012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1579
1580 Avoid calls to strlen in font processing functions.
1581 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1582 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1583 users accordingly.
d923b542
DA
1584 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1585 Adjust prototypes.
1586 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1587 Change to return ptrdiff_t.
984e7f30
DA
1588 (xfont_list_pattern, xfont_match): Use length returned by
1589 xfont_decode_coding_xlfd.
1590 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1591
20e94fdd
GM
15922012-07-11 Glenn Morris <rgm@gnu.org>
1593
9d596af3
GM
1594 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1595 Move DONT_REOPEN_PTY to configure.
1596
20e94fdd
GM
1597 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1598 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1599
e99a530f
PE
16002012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1601
22ffb973
PE
1602 Remove "#define unix" that is no longer needed (Bug#11905).
1603 * s/aix4-2.h (unix): Remove; no longer needed.
1604
e9a9ae03
PE
1605 EMACS_TIME simplification (Bug#11875).
1606 This replaces macros (which typically do not work in GDB)
1607 with functions, typedefs and enums, making the code easier to debug.
1608 The functional style also makes code easier to read and maintain.
1609 * systime.h: Include <sys/time.h> on all hosts, not just if
1610 WINDOWSNT, since 'struct timeval' is needed in general.
1611 (EMACS_TIME): Now a typedef, not a macro.
1612 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1613 not macros.
1614 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1615 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1616 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1617 (EMACS_TIME_LE): Now functions, not macros.
1618 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1619 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1620 which are not functions. All uses rewritten to use:
1621 (make_emacs_time): New function.
1622 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1623 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1624 not functions. All uses rewritten to use the following, respectively:
1625 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1626 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1627 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1628 * fileio.c (Fcopy_file):
1629 * xterm.c (XTflash): Get the current time closer to when it's used.
1630 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1631
ffacb126
PE
1632 * bytecode.c (targets): Suppress -Woverride-init warnings.
1633
e99a530f
PE
1634 Simplify by avoiding confusing use of strncpy etc.
1635 * doc.c (Fsnarf_documentation):
1636 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1637 * frame.c (Fmake_terminal_frame):
1638 * gtkutil.c (get_utf8_string):
1639 * lread.c (openp):
1640 * nsmenu.m (ns_update_menubar):
1641 * regex.c (regerror):
1642 Prefer memcpy to strncpy and strncat when either will do.
1643 * fileio.c (Fsubstitute_in_file_name):
1644 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1645 (menu_separator_name_p):
1646 * nsmenu.m (ns_update_menubar):
1647 Prefer memcmp to strncmp when either will do.
1648 * nsterm.m: Include <ftoastr.h>.
1649 (ns_get_color):
1650 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1651 Prefer snprintf to strncpy.
1652 * nsterm.m (ns_term_init):
1653 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1654 * nsterm.m (ns_term_init):
1655 Avoid the need for strncpy, by using build_string or
1656 make_unibyte_string directly. Use dtoastr, not snprintf.
1657 * process.c (Fmake_network_process): Diagnose service names that
1658 are too long, rather than silently truncating them or creating
1659 non-null-terminated names.
1660 (Fnetwork_interface_info): Likewise, for interface names.
1661 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1662 Prefer sprintf to strncat.
1663 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1664 Prefer vsnprintf to vsprintf + strncpy.
1665
c59592b3
GM
16662012-07-10 Glenn Morris <rgm@gnu.org>
1667
1668 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1669 Clarify fallback case.
1670
7d7bbefd
DA
16712012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1672
1673 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1674 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1675 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1676 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1677 where argument type is known to be a Lisp_Cons.
1678
3a4c8000
TT
16792012-07-10 Tom Tromey <tromey@redhat.com>
1680
1681 * bytecode.c (BYTE_CODE_THREADED): New macro.
1682 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1683 (enum byte_code_op): New type.
1684 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1685 (exec_byte_code): Use them. Use token threading when applicable.
1686
2a0213a6
DA
16872012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1688
1689 Optimize pure C strings initialization.
1690 * lisp.h (make_pure_string): Fix prototype.
1691 (build_pure_c_string): New function, defined as static inline. This
1692 provides a better opportunity to optimize away calls to strlen when
1693 the function is called with compile-time constant argument.
1694 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1695 argument, adjust users accordingly. Use build_pure_c_string where
1696 appropriate.
1697 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1698 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1699 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1700
cb1caeaf
DA
17012012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1702
1703 Avoid calls to strlen in miscellaneous functions.
1704 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1705 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1706 * lread.c (openp): Likewise.
1707
c293e30c
DA
17082012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1709
1710 Avoid calls to strlen in path processing functions.
1711 * fileio.c (file_name_as_directory): Add comment. Change to add
1712 srclen argument and return the length of result. Adjust users
1713 accordingly.
1714 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1715 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1716 users accordingly.
1717 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1718
9e059e3f
GM
17192012-07-10 Glenn Morris <rgm@gnu.org>
1720
d02eb359
GM
1721 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1722 Move PENDING_OUTPUT_COUNT definition to configure.
1723
882cf227
GM
1724 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1725 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1726 * s/gnu.h (DATA_START): Move definitions to configure.
1727
af6e839f
GM
1728 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1729 We include usg5-4-common.h, which defines them both.
1730
40289a12
GM
1731 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1732 O_RDONLY already includes it).
1733
9e059e3f
GM
1734 Stop ns builds setting the EMACSLOADPATH environment variable.
1735 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1736 Now it does not set EMACSLOADPATH, just returns the load-path string.
1737 * nsterm.h: Update accordingly.
1738 * lread.c [HAVE_NS]: Include nsterm.h.
1739 (init_lread) [HAVE_NS]: Use ns_load_path.
1740 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1741
7c4e8ec0
GM
17422012-07-09 Glenn Morris <rgm@gnu.org>
1743
d4f600ff
GM
1744 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1745 since the included bsd-common.h does so.
1746
cbb31951
GM
1747 Stop ns builds setting the EMACSPATH environment variable.
1748 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1749 (ns_init_paths): Do not set EMACSPATH.
1750 * nsterm.h (ns_exec_path): Add it.
1751 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1752 Use ns_exec_path.
1753
7c4e8ec0
GM
1754 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1755
26bccfae
PE
17562012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1757
a0bee46f
PE
1758 * process.c (wait_reading_process_output): 'waitchannels' was unset
1759 when read_kbd || !NILP (wait_for_cell); fix this.
1760
5994c183
PE
1761 Add GCC-style 'const' attribute to functions that can use it.
1762 * character.h (char_resolve_modifier_mask):
1763 * keyboard.h (make_ctrl_char):
1764 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1765 (init_character_once, next_almost_prime, init_fns, init_image)
1766 (flush_pending_output, init_sound):
1767 * mem-limits.h (start_of_data):
1768 * menu.h (finish_menu_items):
1769 Add ATTRIBUTE_CONST.
1770 * emacs.c (DEFINE_DUMMY_FUNCTION):
1771 Declare the dummy function with ATTRIBUTE_CONST.
1772 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1773 Add decls with ATTRIBUTE_CONST.
1774
26bccfae
PE
1775 Minor improvements to make_formatted_string.
1776 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1777 where int is good enough, as vsprintf returns an int.
1778 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1779
a8290ec3
DA
17802012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1781
1782 Use make_formatted_string to avoid double length calculation.
1783 * lisp.h (make_formatted_string): New prototype.
1784 * alloc.c (make_formatted_string): New function.
1785 * buffer.c (Fgenerate_new_buffer_name): Use it.
1786 * dbus.c (syms_of_dbusbind): Likewise.
1787 * editfns.c (Fcurrent_time_zone): Likewise.
1788 * filelock.c (get_boot_time): Likewise.
1789 * frame.c (make_terminal_frame, set_term_frame_name)
1790 (x_report_frame_params): Likewise.
1791 * image.c (gs_load): Likewise.
1792 * minibuf.c (get_minibuffer): Likewise.
1793 * msdos.c (dos_set_window_size): Likewise.
1794 * process.c (make_process): Likewise.
1795 * xdisp.c (ensure_echo_area_buffers): Likewise.
1796 * xsettings.c (apply_xft_settings): Likewise.
1797
d01ba2f1
GM
17982012-07-09 Glenn Morris <rgm@gnu.org>
1799
1800 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1801 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1802 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1803 * nsterm.h (ns_etc_directory): Add it.
1804 * callproc.c [HAVE_NS]: Include nsterm.h.
1805 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1806
f1f924b6
DA
18072012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1808
1809 Move marker debugging code under MARKER_DEBUG.
1810 * marker.c (MARKER_DEBUG): Move marker debugging code under
1811 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1812 for bootstrap with --enable-checking (~3x slowdown reported
1813 by Juanma Barranquero <lekktu@gmail.com>).
1814 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1815
ab531b66
PE
18162012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1817
1818 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1819 See <http://bugs.gnu.org/11825#29>.
1820
c4b3bc8a
EZ
18212012-07-08 Eli Zaretskii <eliz@gnu.org>
1822
1823 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1824 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1825 (display_line): Add commentary about displaying truncation glyphs
1826 on GUI frames.
1827 (produce_special_glyphs): Move here from term.c.
1828
1829 * term.c (produce_special_glyphs): Move to xdisp.c.
1830
1831 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1832 section.
c4b3bc8a 1833
b676b881
AS
18342012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1835
f17c5273
AS
1836 * xdisp.c (display_line): Avoid warning about implicit declaration
1837 of FRAME_FONT.
1838
298819b9
AS
1839 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1840
b676b881
AS
1841 * lisp.h: Remove empty conditional.
1842
6045c4fd
PE
18432012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1844
b3350bf9
PE
1845 * lread.c (load_path_check): Now static.
1846
6045c4fd
PE
1847 Fix some minor --with-ns problems found by static checking.
1848 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1849 (x_set_font) [!HAVE_X_WINDOWS]:
1850 * image.c (xpm_load_image) [HAVE_NS]:
1851 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1852 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1853 Remove unused local.
1854 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1855 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1856 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1857 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1858 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1859 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1860 Fix pointer signedness problem.
1861 * xfaces.c (FRAME_X_FONT_TABLE):
1862 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1863
929e7845
GM
18642012-07-07 Glenn Morris <rgm@gnu.org>
1865
1866 * lread.c (load_path_check): New function, split from init_lread.
1867 (init_lread): Reorganize. Motivation:
1868 If EMACSLOADPATH is set, check/warn about that rather than the
1869 defaults, which we are not going to use. Hence we can remove
1870 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1871 Don't warn if site-lisp directories are missing.
1872 If not installed, start from a blank load-path, since
1873 PATH_LOADSEARCH refers to the eventual installation directories.
1874
58dd0aa4
EZ
18752012-07-07 Eli Zaretskii <eliz@gnu.org>
1876
1877 Support truncation and continuation glyphs on GUI frames, when
1878 fringes are disabled. (Bug#11832)
1879 * xdisp.c (init_iterator): Get dimensions of truncation and
1880 continuation glyphs even if on GUI frames. Adjust
1881 it->last_visible_x on GUI frames when the left or right fringes,
1882 or both, are absent.
1883 (start_display, move_it_in_display_line_to): Handle the case of a
1884 GUI frame without a fringe to display continuation or truncation
1885 glyphs.
1886 (insert_left_trunc_glyphs): Support GUI frames: make sure
1887 truncation glyphs overwrite enough glyphs from the current line to
1888 have sufficient space in pixels.
1889 (display_line): Support truncation and continuation glyphs on GUI
1890 frames. If some spare pixels are left on the line after inserting
1891 the truncation glyphs, fill that space with a stretch glyph of a
1892 suitably computed width.
1893
1894 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1895 produce_glyphs, to support GUI sessions.
1896
31571fd7
PE
18972012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1898
5a16b9bc
PE
1899 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1900
f3047c75
PE
1901 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1902
31571fd7
PE
1903 Do not require float-time's arg to fit in time_t (Bug#11825).
1904 This works better on hosts where time_t is unsigned, and where
1905 float-time is applied to the (negative) difference between two times.
1906 * editfns.c (decode_time_components): Last arg is now double *,
1907 not int *, and means to store all the result as a double, without
1908 worrying about whether the seconds part fits in time_t.
1909 All callers changed.
1910 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1911 All callers changed.
1912 (Ffloat_time): Do not fail merely because the specified time falls
1913 outside of time_t range.
1914
4516fbef
GM
19152012-07-07 Glenn Morris <rgm@gnu.org>
1916
1917 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1918 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1919 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1920
07adc2c6
JB
19212012-07-07 Juanma Barranquero <lekktu@gmail.com>
1922
1923 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1924 Update dependencies.
1925
1926 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1927
fd573f31
PE
19282012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1929
fee5959d
PE
1930 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1931 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1932 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1933 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1934 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1935 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1936
fd573f31
PE
1937 * xfont.c (compare_font_names): Redo to omit the need for casts.
1938
ddadbc0e
AS
19392012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1940
fca8d6b6
AS
1941 * xfns.c (Fx_change_window_property): Doc fix.
1942 * w32fns.c (Fx_change_window_property): Doc fix.
1943
ddadbc0e
AS
1944 * w32fns.c (Fx_window_property): Accept the same arguments as the
1945 X Windows version. Doc fix.
1946 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1947
ed9265fc 19482012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1949 Eli Zaretskii <eliz@gnu.org>
1950
1951 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1952 Windows-specific code from nt/config.nt moved here.
1953 Obsolete settings removed.
1954
216ee680
PE
19552012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1956
1957 * process.c: Avoid unnecessary calls to gettime.
1958 (wait_reading_process_output): Don't get the time of day
1959 when gobbling data immediately and not waiting, as there's no need
1960 for it in that case. This removes a FIXME.
1961
bdd091e4
JD
19622012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1963
1964 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1965 is defined (Bug#11768).
1966
9d44f8ce
DA
19672012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1968
1969 Fix marker debugging code.
1970 * marker.c (byte_char_debug_check): Do not perform the check
1971 if buffer is not multibyte.
090bd7cb
JB
1972 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1973 Call byte_char_debug_check with correct arguments.
9d44f8ce 1974
90fc4786
DA
19752012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1976
1977 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1978 * marker.c (byte_char_debug_check, count_markers):
1979 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1980 (byte_debug_flag): Remove.
1981 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1982 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1983
7b7ae965
DA
19842012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1985
4e57b342
DA
1986 Avoid code repetition in marker-related functions.
1987 * marker.c (attach_marker): New function.
1988 (Fset_marker, set_marker_restricted, set_marker_both)
1989 (set_marker_restricted_both): Use it.
1990 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1991 Consistently rename charno to charpos.
1992 (marker_position): Add eassert.
1993 (marker_byte_position): Convert to eassert.
1994
19952012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1996
1997 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1998 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1999 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2000
657924ff
DA
20012012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2002
2003 Introduce fast path for the widely used marker operation.
2004 * alloc.c (build_marker): New function.
2005 * lisp.h (build_marker): New prototype.
2006 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2007 * composite.c (autocmp_chars): Likewise.
2008 * editfns.c (buildmark): Remove.
2009 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2010 (save_restriction_save): Use build_marker.
2011 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2012 * window.c (save_window_save): Likewise.
2013
041a49a6
DA
20142012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2015
2016 Do not use Fdelete_overlay in delete_all_overlays
2017 to avoid redundant calls to unchain_overlay.
2018 * buffer.c (drop_overlay): New function.
2019 (delete_all_overlays, Fdelete_overlay): Use it.
2020 * minibuf.c (get_minibuffer): Fix comment.
2021
7dca65a4
PE
20222012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2023
2024 Port to OpenBSD 5.1 amd64.
2025 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2026 This is needed for OpenBSD, and should be harmless on all BSD systems.
2027 Also, include <sys/sysctl.h>, as it should be available on all
2028 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2029 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2030 use p_pid member, not kp_proc.pid.
2031
8eb876e2
GM
20322012-07-06 Glenn Morris <rgm@gnu.org>
2033
2034 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2035
38182d90
PE
20362012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2037
2038 More xmalloc and related cleanup.
2039 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2040 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2041 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2042 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2043 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2044 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2045 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2046 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2047 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2048 * xterm.c:
2049 Omit needless casts involving void * pointers and allocation.
2050 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2051 as the former is more robust if P's type is changed.
2052 Prefer xzalloc to xmalloc + memset 0.
2053 Simplify malloc-or-realloc to realloc.
2054 Don't worry about xmalloc returning a null pointer.
2055 Prefer xstrdup to xmalloc + strcpy.
2056 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2057 growing it.
2058 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2059 alloca of a constant.
2060
6dd5a677
EZ
20612012-07-05 Eli Zaretskii <eliz@gnu.org>
2062
2063 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2064 hscroll is larger than the line width. Fixes long and futile
2065 looping inside extend_face_to_end_of_line (on a TTY) producing
2066 glyphs that are not needed and thrown away.
2067
6b312f0f
DA
20682012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2069
2070 * marker.c (set_marker_restricted_both): Simplify by using
2071 clip_to_bounds.
2072
f520ef9b
PE
20732012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2074
2075 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2076
383b7c95
JD
20772012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2078
2079 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2080 not defined (Bug#11768).
2081 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2082 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2083 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2084 followed by gtk_box_set_homogeneous (Bug#11768).
2085 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2086 (update_theme_scrollbar_width, xg_create_scroll_bar):
2087 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2088 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2089 (is_box_type): New function (Bug#11768).
2090 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2091 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2092 with default display (Bug#11768).
2093
d6e7bf45
EZ
20942012-07-05 Eli Zaretskii <eliz@gnu.org>
2095
2096 * xdisp.c (window_hscroll_limited): New function.
2097 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2098 coordinates when window's hscroll is set to insanely large
2099 values. (Bug#11857)
2100
431391ec
JB
21012012-07-05 Juanma Barranquero <lekktu@gmail.com>
2102
2103 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2104 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2105
23f86fce
DA
21062012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2107
2108 Cleanup xmalloc.
2109 * lisp.h (xzalloc): New prototype. Omit needless casts.
2110 * alloc.c (xzalloc): New function. Omit needless casts.
2111 * charset.c: Omit needless casts. Convert all calls to
2112 xmalloc with following memset to xzalloc.
2113 * dispnew.c: Likewise.
2114 * fringe.c: Likewise.
2115 * image.c: Likewise.
2116 * sound.c: Likewise.
2117 * term.c: Likewise.
2118 * w32fns.c: Likewise.
2119 * w32font.c: Likewise.
2120 * w32term.c: Likewise.
2121 * xfaces.c: Likewise.
2122 * xfns.c: Likewise.
2123 * xterm.c: Likewise.
2124 * atimer.c: Omit needless casts.
2125 * buffer.c: Likewise.
2126 * callproc.c: Likewise.
2127 * ccl.c: Likewise.
2128 * coding.c: Likewise.
2129 * composite.c: Likewise.
2130 * doc.c: Likewise.
2131 * doprnt.c: Likewise.
2132 * editfns.c: Likewise.
2133 * emacs.c: Likewise.
2134 * eval.c: Likewise.
2135 * filelock.c: Likewise.
2136 * fns.c: Likewise.
2137 * gtkutil.c: Likewise.
2138 * keyboard.c: Likewise.
2139 * lisp.h: Likewise.
2140 * lread.c: Likewise.
2141 * minibuf.c: Likewise.
2142 * msdos.c: Likewise.
2143 * print.c: Likewise.
2144 * process.c: Likewise.
2145 * region-cache.c: Likewise.
2146 * search.c: Likewise.
2147 * sysdep.c: Likewise.
2148 * termcap.c: Likewise.
2149 * terminal.c: Likewise.
2150 * tparam.c: Likewise.
2151 * w16select.c: Likewise.
2152 * w32.c: Likewise.
2153 * w32reg.c: Likewise.
2154 * w32select.c: Likewise.
2155 * w32uniscribe.c: Likewise.
2156 * widget.c: Likewise.
2157 * xdisp.c: Likewise.
2158 * xmenu.c: Likewise.
2159 * xrdb.c: Likewise.
2160 * xselect.c: Likewise.
2161
0497dc44
PE
21622012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2163
2164 * fileio.c (time_error_value): Check the right error number.
2165 Problem reported by Troels Nielsen in
2166 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2167
356e7178
PE
21682012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2169
4e71fd89
PE
2170 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2171 This should be fixed in a better way; see Eli Zaretskii in
2172 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2173 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2174
f0941253
PE
2175 * fileio.c (time_error_value): Rename from special_mtime.
2176 The old name's problems were noted by Eli Zaretskii in
2177 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2178
065c9eb4
PE
2179 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2180 This variable's comment says Emacs needs at least one GDB-visible
2181 symbol of type enum pvec_type, to work around GDB problems.
2182 The symbol's value doesn't matter.
2183
356e7178
PE
2184 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2185 that causes compilation to fail on pre-C99 compilers.
2186
ed9265fc 21872012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2188
2189 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2190 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2191
3884d954
DA
21922012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2193
d209e2fb 2194 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2195 headers for buffer_defaults and buffer_local_symbols.
2196 Reported by Juanma Barranquero <lekktu@gmail.com>.
2197
ee28be33
SM
21982012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2199
2200 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2201 * lisp.h (enum pvec_type): Use fewer bits.
2202 (PSEUDOVECTOR_SIZE_BITS): New constant.
2203 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2204 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2205 change in pvec_type.
2206 (PSEUDOVECTOR_TYPEP): New macro.
2207 (TYPED_PSEUDOVECTORP): Use it.
2208 * fns.c (internal_equal): Adapt code to extract pvectype.
2209 * emacs.c (gdb_pvec_type): Update type.
2210 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2211 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2212 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2213 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2214 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2215 abusing vector->header.next.nbytes.
2216 (live_vector_p): Use PVEC_TYPE.
2217 (mark_object): Adapt code to extract pvectype. Use switch.
2218
c7f2cd7f
PE
22192012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2220
2221 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2222 Tighten new eassert a bit.
2223
8ce70ed2
DA
22242012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2225
2226 Fix compilation with --enable-gcc-warnings and -O1
2227 optimization level.
2228 * doprnt.c (doprnt): Change type of tem to int, initialize
2229 to avoid compiler warning. Add eassert.
2230 * search.c (simple_search): Initialize match_byte to avoid
2231 compiler warning. Add eassert.
2232
dea7f1e5
PE
22332012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2234
24a212eb
PE
2235 Avoid weird behavior with large horizontal scrolls.
2236 Without this change, for example, large hscroll values would
2237 mess up Emacs's display on Fedora 15 x86, presumably due to
2238 overflows in int calculations in the display code.
2239 Also, if buffers had long lines, Emacs would freeze.
2240 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2241 (set_window_hscroll): New function, containing the old guts of
2242 Fset_window_hscroll. Return the clipped value.
2243 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2244 This avoids the need to check against PTRDIFF_MAX.
2245
dea7f1e5
PE
2246 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2247
76046526
DA
22482012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2249
2250 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2251
39adff0d
PE
22522012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2253
63807d47
PE
2254 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2255 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2256 since GCC 4.4.6 issues a bogus warning for them.
2257
39adff0d
PE
2258 Fix bugs in file timestamp newness comparisons.
2259 * fileio.c (Ffile_newer_than_file_p):
2260 * lread.c (Fload): Use full timestamp resolution of files,
2261 not just the 1-second resolution, so that files that are only
2262 slightly newer still count as newer.
2263 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2264 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2265
dbeed9a6
PE
22662012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2267
2268 * fileio.c: Improve handling of file time marker. (Bug#11852)
2269 (special_mtime): New function.
2270 (Finsert_file_contents, Fverify_visited_file_modtime):
2271 Use it to set special mtime values consistently.
2272
636334d6
AS
22732012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2274
2275 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2276 marker for non-existing file. (Bug#11852)
2277
e2017fe2
GM
22782012-07-03 Glenn Morris <rgm@gnu.org>
2279
2280 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2281 and did not make it into globals.h).
2282
404dbd37
TT
22832012-07-03 Tom Tromey <tromey@redhat.com>
2284
2285 * window.c (Fset_window_margins, Fset_window_fringes)
2286 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2287 * textprop.c (Fprevious_property_change): No longer static.
2288 * syntax.c (Fsyntax_table_p): No longer static.
2289 * process.c (Fget_process, Fprocess_datagram_address): No longer
2290 static.
2291 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2292 * keyboard.c (Fcommand_execute): No longer static.
2293 Remove EXFUN.
2294 * insdel.c (Fcombine_after_change_execute): No longer static.
2295 * image.c (Finit_image_library): No longer static.
2296 * fileio.c (Fmake_symbolic_link): No longer static.
2297 * eval.c (Ffetch_bytecode): No longer static.
2298 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2299 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2300 No longer static.
404dbd37
TT
2301 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2302 static.
2303 * dired.c (Ffile_attributes): No longer static.
2304 * composite.c (Fcomposition_get_gstring): No longer static.
2305 * callproc.c (Fgetenv_internal): No longer static.
2306
2307 * ccl.h: Remove EXFUNs.
2308 * buffer.h: Remove EXFUNs.
2309 * dispextern.h: Remove EXFUNs.
2310 * intervals.h: Remove EXFUNs.
2311 * fontset.h: Remove EXFUN.
2312 * font.h: Remove EXFUNs.
2313 * dosfns.c (system_process_attributes): Remove EXFUN.
2314 * keymap.h: Remove EXFUNs.
2315 * lisp.h: Remove EXFUNs.
2316 * w32term.h: Remove EXFUNs.
2317 * window.h: Remove EXFUNs.
2318 * xsettings.h: Remove EXFUN.
2319 * xterm.h: Remove EXFUN.
2320
8e4fd1e1
GM
23212012-07-03 Glenn Morris <rgm@gnu.org>
2322
2323 * lisp.h (Frandom): Make it visible to C.
2324 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2325 buffer for invisible buffers. (Bug#1229)
2326
ca95b3eb
DA
23272012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2328
2329 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2330 values which aren't power of 2.
2331 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2332 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2333 accordingly.
2334
7555c33f
SM
23352012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2336
2337 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2338
2339 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2340
d12e8f5a
DA
23412012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2342
2343 * alloc.c (allocate_vector_block): Remove redundant
2344 calls to mallopt if DOUG_LEA_MALLOC is defined.
2345 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2346 avoid calls to mallopt if zero_vector is returned.
2347
296094c3
DA
23482012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2349
2350 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2351 is enabled, avoid dereferencing NULL current_sblock if
2352 running undumped.
2353
36429c89
DA
23542012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2355
2356 Cleanup basic buffer management.
2357 * buffer.h (struct buffer): Change layout to use generic vector
2358 marking code. Fix some comments. Change type of 'clip_changed'
2359 to bitfield. Remove unused #ifndef old.
2360 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2361 (GET_OVERLAYS_AT): Fix indentation.
2362 (for_each_per_buffer_object_at): New macro.
2363 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2364 (Fbuffer_local_variables): Use it.
2365 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2366 * alloc.c (allocate_buffer): Adjust to match new layout of
2367 struct buffer. Fix comment.
2368 (mark_overlay): New function.
2369 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2370 Lisp area of struct buffer.
2371 (mark_object): Use it. Adjust marking of misc objects
2372 and related comments.
2373
3b3e4cac
PE
23742012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2375
2376 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2377 wrapper that is not needed because the wrapped code is a no-op (zero
2378 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2379 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2380
cf5c0175
DA
23812012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2382
2383 * alloc.c (mark_buffer): Simplify. Remove prototype.
2384 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2385 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
2386 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2387 redundant calls to mark_vectorlike for bool vectors.
2388
ca26824c
GM
23892012-06-30 Glenn Morris <rgm@gnu.org>
2390
2e4c5312
GM
2391 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2392
ca26824c
GM
2393 * epaths.in (PATH_SITELOADSEARCH): New.
2394 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2395 This is rather than relying on --enable-locallisppath elements
2396 having "site-lisp" in their names. (Bug#10208#25, 11658)
2397
0d23c240
EZ
23982012-06-30 Eli Zaretskii <eliz@gnu.org>
2399
c9240d7a
EZ
2400 * w32proc.c (sys_select): Accept and ignore one more argument.
2401
2402 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2403
0d23c240 2404 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2405 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2406
2407 * sysdep.c: Don't include dos.h and dosfns.h.
2408
2409 * process.c (sys_select):
2410 * msdos.c (sys_select): Accept one more argument and ignore it.
2411
2412 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2413 adapt data types and code to that.
2414
2415 * dosfns.c:
2416 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2417 which clashes with the gnulib function of the same name.
2418
af5a5a98
AS
24192012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2420
c5e4379c
AS
2421 * font.c (font_style_to_value, font_style_symbolic)
2422 (font_prop_validate_style): Add type checks for values in
2423 font_style_table.
2424
af5a5a98
AS
2425 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2426 argument.
2427 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2428 uses.
2429
8d38f461
EZ
24302012-06-29 Eli Zaretskii <eliz@gnu.org>
2431
2e5a6631
EZ
2432 * xdisp.c (try_window_id): Undo last change.
2433
8d38f461
EZ
2434 * w32.c (getwd): Adjust commentary about startup_dir.
2435 (init_environment): Always call sys_access, even in non-MSVC
2436 builds. Don't chdir to the directory of the Emacs executable.
2437 This undoes code from 1997 which was justified by the need to
2438 "avoid conflicts when removing and renaming directories". But its
2439 downside was that every relative file name was being interpreted
2440 relative to the directory of the Emacs executable, which can never
2441 be TRT. In particular, it broke sys_access when called with
2442 relative file names.
2443 (sys_access): Map GetLastError to errno.
2444
2af3565e
DA
24452012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2446
2447 * window.h (struct window): Change type of 'fringes_outside_margins'
2448 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2449 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2450 Adjust comment.
2451 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2452 to ptrdiff_t.
2453
c8d3a25c 24542012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2455
c8d3a25c
GM
2456 * gnutls.c (emacs_gnutls_handshake):
2457 Add QUIT to make the loop interruptible.
57570cd3 2458
c8d3a25c 24592012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2460
c8d3a25c
GM
2461 * charset.c (init_charset): Make lack of etc/charsets fatal.
2462
3e984ee8
DA
24632012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2464
2465 * editfns.c (region_limit): Fix type mismatch.
2466
ef884f23
DA
24672012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2468
2469 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2470 undefined. Convert from xassert to eassert.
2471 * nsmenu.m: Convert from xassert to eassert.
2472 * nsterm.m: Likewise.
2473
7d7e0027
SM
24742012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2475
2476 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2477
aa754e6a
PE
24782012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2479
2480 Avoid integer overflow on scroll-left and scroll-right.
2481 * window.c (HSCROLL_MAX): New macro.
2482 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2483 overflow when requested scroll falls outside ptrdiff_t range.
2484
80b00b08
DA
24852012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2486
2487 * window.h (struct window): Change type of 'hscroll',
2488 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2489 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2490 Adjust users accordingly.
2491 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2492 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2493 from EMACS_INT to ptrdiff_t.
2494 (make_window): Omit redundant initialization.
2495
62b2bcf6
JB
24962012-06-28 Juanma Barranquero <lekktu@gmail.com>
2497
2498 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2499
45942c7d
DA
25002012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2501
2502 * window.h (struct window): Change type of 'use_time' and
2503 'sequence_number' from Lisp_Object to int.
2504 * frame.c (make_frame): Adjust users accordingly.
2505 * print.c (print_object): Likewise.
2506 * window.c (select_window, Fwindow_use_time, make_parent_window)
2507 (make_window): Likewise.
2508
e509cfa6
DA
25092012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2510
2511 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2512 enabled with --enable-checking=[all,glyphs] configure option.
2513 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2514 adjust comments accordingly.
2515 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2516 undefined, adjust comments accordingly.
2517 * image.c: Likewise.
2518 * scroll.c: Likewise.
2519 * w32fns.c: Likewise.
2520 * w32term.c: Likewise.
2521 * xdisp.c: Likewise.
2522 * xfaces.c: Likewise.
2523 * xfns.c: Likewise.
2524 * xterm.c: Likewise.
2525
a54e2c05
DA
25262012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2527
2528 Generalize run-time debugging checks.
2529 * dispextern.h (XASSERTS): Remove.
2530 * fontset.c (xassert): Remove.
2531 Convert from xassert to eassert.
2532 * alloc.c: Convert from xassert to eassert.
2533 * bidi.c: Likewise.
2534 * dispnew.c: Likewise.
2535 * fns.c: Likewise.
2536 * fringe.c: Likewise.
2537 * ftfont.c: Likewise.
2538 * gtkutil.c: Likewise.
2539 * image.c: Likewise.
2540 * keyboard.c: Likewise.
2541 * menu.c: Likewise.
2542 * process.c: Likewise.
2543 * scroll.c: Likewise.
2544 * sound.c: Likewise.
2545 * term.c: Likewise.
2546 * w32console.c: Likewise.
2547 * w32fns.c: Likewise.
2548 * w32term.c: Likewise.
2549 * window.c: Likewise.
2550 * xdisp.c: Likewise.
2551 * xfaces.c: Likewise.
2552 * xfns.c: Likewise.
2553 * xselect.c: Likewise.
2554 * xterm.c: Likewise.
2555
1ec4b7b2
SM
25562012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2557
2558 * fns.c (maybe_resize_hash_table): Output message when growing the
2559 purify-hashtable.
2560
2014308a
DA
25612012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2562
2563 * alloc.c (allocate_string_data): Remove dead code.
2564 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2565 avoid GCC warning about unused macro.
2566
246155eb
DA
25672012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2568
2569 * alloc.c (allocate_string): Omit intervals initialization.
2570 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2571 as in make_pure_string and make_pure_c_string.
2572
43184b7b
DA
25732012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2574
d209e2fb 2575 * alloc.c (allocate_string): Fix last change.
43184b7b 2576
3fe6dd74
DA
25772012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2578
d209e2fb 2579 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2580 to memset, add explicit initialization where appropriate.
2581
1ba6038a
GM
25822012-06-27 Glenn Morris <rgm@gnu.org>
2583
2584 * lisp.mk (lisp): Remove paths.elc.
2585
c89926a5
CY
25862012-06-27 Chong Yidong <cyd@gnu.org>
2587
2588 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2589
ed6b3510
JW
25902012-06-26 John Wiegley <johnw@newartisans.com>
2591
1ec4b7b2 2592 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2593 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2594
ed6b3510
JW
2595 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2596 when building with Clang.
2597
8edd4a2b
SM
25982012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2599
2600 * eval.c (Fapply): Allow calling it with a single argument.
2601
f6f62d1b
EZ
26022012-06-26 Eli Zaretskii <eliz@gnu.org>
2603
2604 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2605 _stricmp and _strnicmp.
2606 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2607
62efea5e
DA
26082012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2609
2610 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2611 allocated window.
2612 (allocate_process): Likewise for new process.
8edd4a2b 2613 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2614 (allocate_frame): Likewise.
2615 * frame.c (make_frame): Omit redundant initialization.
2616 * window.c (make_parent_window): Use memset.
2617 (make_window): Omit redundant initialization.
2618 * process.c (make_process): Omit redundant initialization.
2619 * terminal.c (create_terminal): Likewise.
2620
42997f4d
DA
26212012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2622
2623 * term.c (delete_tty): Remove redundant call to memset.
2624
1130ecfc
DA
26252012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2626
2627 * alloc.c: Remove build_string.
2628 * lisp.h: Define build_string as static inline. This provides
2629 a better opportunity to optimize away calls to strlen when the
2630 function is called with compile-time constant argument.
2631 * image.c (imagemagick_error): Convert to build_string.
2632 * w32proc.c (sys_spawnve): Likewise.
2633 * xterm.c (x_term_init): Likewise.
2634
cf38a720
PE
26352012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2636
99027bdd
PE
2637 Use sprintf return value instead of invoking strlen on result.
2638 In the old days this wasn't portable, since some sprintf
2639 implementations returned char *. But they died out years ago and
2640 Emacs already assumes sprintf returns int.
2641 Similarly for float_to_string.
2642 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2643 * ccl.c (ccl_driver):
2644 * character.c (string_escape_byte8):
2645 * data.c (Fnumber_to_string):
2646 * doprnt.c (doprnt):
2647 * print.c (print_object):
2648 * xdisp.c (message_dolog):
2649 * xfns.c (syms_of_xfns):
2650 Use sprintf or float_to_string result to avoid need to call strlen.
2651 * data.c (Fnumber_to_string):
2652 Use make_unibyte_string, since the string must be ASCII.
2653 * lisp.h, print.c (float_to_string): Now returns int length.
2654 * term.c (produce_glyphless_glyph):
2655 Use sprintf result rather than recomputing it.
2656
cf38a720
PE
2657 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2658 * Makefile.in (ALL_CFLAGS):
2659 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2660 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2661
3511c784
DA
26622012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2663
0a08eb21 2664 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2665 strcasecmp if available.
2666 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2667
fb7da12e
AS
26682012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2669
2670 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2671 Avoid comma operator.
2672 * menu.c (push_submenu_start, push_submenu_end)
2673 (push_left_right_boundary, push_menu_pane): Likewise.
2674 * msdos.c (dos_rawgetc): Likewise.
2675
afa2ffd8
DA
26762012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2677
2678 * xfns.c (xic_create_fontsetname): Remove redundant calls
2679 to memset.
2680
b3b4476b
PE
26812012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2682
4495ff38
PE
2683 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2684 sprintf already null-terminates its output.
2685
b3b4476b
PE
2686 * xfns.c (x_window): Remove redundant cast.
2687
b00876c9
DA
26882012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2689
2690 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2691 `const char *' to `char *' to avoid compiler warning.
2692
d188e26b
PE
26932012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2694
885d1d74
PE
2695 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2696 instead of truncating it to 63 (admittedly a generous limit).
2697
d188e26b
PE
2698 * process.c: Fix spelling and caps in comments.
2699
e2f560b1
DN
27002012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2701
e86db54b 2702 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2703 * sysdep.c (setpgrp): Remove definition, not used in this file.
2704
7583a3a1
JB
27052012-06-24 Juanma Barranquero <lekktu@gmail.com>
2706
2707 * makefile.w32-in: Update dependencies.
2708
696056c2
EZ
27092012-06-24 Eli Zaretskii <eliz@gnu.org>
2710
2711 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2712 (SYSTIME_H): Add nt/inc/sys/time.h.
2713
2714 * systime.h [WINDOWSNT]: Include sys/time.h.
2715
2716 * s/ms-w32.h (struct timespec): Definition moved from
2717 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2718
845ca893
PE
27192012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2720
2721 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2722 * buffer.h (buffer_slot_type_mismatch):
2723 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2724 * eval.c (unwind_to_catch):
2725 * image.c (my_png_error, my_error_exit):
2726 * keyboard.c (quit_throw_to_read_char, user_error)
2727 (Fexit_recursive_edit, Fabort_recursive_edit):
2728 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2729 (wrong_type_argument, buffer_overflow, __executable_start)
2730 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2731 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2732 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2733 (fatal):
2734 (child_setup) [!DOS_NT]:
2735 * lread.c (end_of_file_error, invalid_syntax):
2736 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2737 * puresize.h (pure_write_error):
2738 * search.c (matcher_overflow):
2739 * sound.c (sound_perror, alsa_sound_perror):
2740 * sysdep.c, syssignal.h (croak):
2741 * term.c (maybe_fatal, vfatal):
2742 * textprop.c (text_read_only):
2743 * undo.c (user_error):
2744 * unexmacosx.c (unexec_error):
2745 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2746 Use _Noreturn rather than NO_RETURN.
2747 No need for separate decl merely because of _Noreturn.
2748 * sound.c (sound_warning, parse_sound):
2749 Remove unnecessary forward decls.
2750
f1dd8073
PE
27512012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2752
2753 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2754 * lisp.h (WAIT_READING_MAX): New macro.
2755 * dispnew.c (Fsleep_for, sit_for):
2756 * keyboard.c (kbd_buffer_get_event):
2757 * process.c (Faccept_process_output):
2758 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2759 This improves on the previous patch, which introduced a bug
2760 when time_t is unsigned and as wide as intmax_t.
2761 See <http://bugs.gnu.org/9000#51>.
2762
b82c1755
EZ
27632012-06-23 Eli Zaretskii <eliz@gnu.org>
2764
2765 * dispnew.c (sit_for, Fsleep_for):
2766 * keyboard.c (kbd_buffer_get_event):
2767 * process.c (Faccept_process_output): Avoid compiler warnings when
2768 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2769
ca300656
JB
27702012-06-23 Juanma Barranquero <lekktu@gmail.com>
2771
049ec95b
JB
2772 * makefile.w32-in: Update dependencies.
2773
ca300656
JB
2774 * w32.c (ltime): Add return type and declare static.
2775 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2776
db7b8d06
PE
27772012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2778
2779 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2780 Privately reported by Herbert J. Skuhra.
2781 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2782 All uses changed.
2783 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2784 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2785
0bd8297f
EZ
27862012-06-23 Eli Zaretskii <eliz@gnu.org>
2787
96512555
EZ
2788 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2789 last argument of make_unibyte_string.
2790
0bd8297f
EZ
2791 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2792 language ID in the event parameters.
2793
2794 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2795 event.code, not the obscure "character set ID".
2796
63def6b6
CY
27972012-06-23 Chong Yidong <cyd@gnu.org>
2798
2799 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2800
e8a02204
EZ
28012012-06-23 Eli Zaretskii <eliz@gnu.org>
2802
388cdec0
EZ
2803 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2804 * w32.c (fdutimens): New function.
2805
2806 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2807
2808 * s/ms-w32.h (pselect): Redirect to sys_select.
2809
2810 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2811
e8a02204
EZ
2812 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2813 in the logic of incrementing and decrementing the value of
2814 use_relocatable_buffers.
2815
d054f3fb
PE
28162012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2817
2818 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2819 Privately reported by Herbert J. Skuhra.
2820 [__FreeBSD__]: Remove "*/" typo after "#include".
2821 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2822 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2823 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2824 Don't assume EMACS_TIME and struct timeval are the same type.
2825
d35af63c
PE
28262012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2827
2828 Support higher-resolution time stamps (Bug#9000).
2829 The time stamps are only nanosecond-resolution at the C level,
2830 since that's the best that any real-world system supports now.
2831 But they are picosecond-resolution at the Lisp level, as that's
2832 easy, and leaves room for future OS improvements.
2833
2834 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2835 (LIBES): Use it.
2836
2837 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2838 Don't get current time unless it's needed.
2839
2840 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2841 now provides it if it's absent.
2842 (start_atimer): Port to higher-res time stamps.
2843 Check for time stamp overflow. Don't get current time more
2844 often than is needed.
2845
2846 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2847 Include systime.h, not time.h.
2848 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2849
2850 * dired.c: Include stat-time.h.
2851 (Ffile-attributes): File times now have higher resolution.
2852
2853 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2854 (struct image): Timestamp now has higher resolution.
2855
2856 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2857 has at least microseconds now. All uses removed.
2858 (update_frame, update_single_window, update_window, update_frame_1)
2859 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2860
2861 * editfns.c (time_overflow): Now extern.
2862 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2863 (float-time, Fformat_time_string, Fcurrent_time_string)
2864 (Fcurrent_time_zone): Accept and generate higher-resolution
2865 time stamps.
2866 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2867 (decode_time_components, lisp_seconds_argument): New functions.
2868 (make_time): Now static.
2869 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2870 Report an error if the time is invalid, rather than having the caller
2871 do that.
2872
2873 * fileio.c: Include <stat-time.h>
2874 (Fcopy_file): Copy higher-resolution time stamps.
2875 Prefer to set the time stamp via a file descriptor if that works.
2876 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2877 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2878 (Fvisited_file_modtime, Fset_visited_file_modtime):
2879 Support higher-resolution time stamps.
2880
2881 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2882
2883 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2884
2885 * image.c (prepare_image_for_display, clear_image_cache)
2886 (lookup_image): Port to higer-resolution time stamps.
2887
2888 * keyboard.c (start_polling, bind_polling_period):
2889 Check for time stamp overflow.
2890 (read_char, kbd_buffer_get_event, timer_start_idle)
2891 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2892 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2893 Port to higher-resolution time stamps. Do not assume time_t is signed.
2894 (decode_timer): New function. Timers are now vectors of length 9,
2895 not 8, to accommodate the picosecond component.
2896 (timer_check_2): Use it.
2897
2898 * nsterm.m (select_timeout, timeval_subtract): Remove.
2899 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2900 as they're a bit more accurate and handle overflow better.
2901 (ns_select): Change prototype to be compatible with pselect.
2902 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2903 * nsterm.h (ns_select): Adjust prototype.
2904
2905 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2906 us-resolution time stamps.
2907 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2908
2909 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2910
2911 * lisp.h (time_overflow): New decl.
2912 (wait_reading_process_output): First arg is now intmax_t, not int,
2913 to accommodate larger waits.
2914
2915 * process.h (struct Lisp_Process.read_output_delay):
2916 Now counts nanoseconds, not microseconds.
2917 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2918 EMACS_HAS_USECS.
2919 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2920 (wait_reading_process_output):
2921 Port to ns-resolution time stamps.
2922 (Faccept_process_output, wait_reading_process_output):
2923 Check for time stamp overflow. Do not assume time_t is signed.
2924 (select_wrapper): Remove; we now use pselect.
2925 (Fprocess_attributes): Now generates ns-resolution time stamps.
2926
2927 * sysdep.c: Include utimens.h. Don't include utime.h
2928 or worry about struct utimbuf; gnulib does that for us now.
2929 (gettimeofday): Remove; gnulib provides a substitute.
2930 (make_timeval): New function.
2931 (set_file_times): Now sets ns-resolution time stamps.
2932 New arg FD; all uses changed.
2933 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2934 (system_process_attributes):
2935 Now returns ns-resolution time stamp. All uses changed.
2936 Check for time stamp overflow.
2937
2938 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2939 provides a substitute now.
2940
2941 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2942 since it guarantees struct timespec.
2943 (EMACS_TIME): Now struct timespec, so that we can support
2944 ns-resolution time stamps.
2945 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2946 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2947 (EMACS_USECS): Remove.
2948 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2949 so multiply the arg by 1000 before storing it.
2950 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2951 New macros.
2952 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2953 Port to ns-resolution time stamps.
2954 (EMACS_TIME_NEG_P): Remove; replaced by....
2955 (EMACS_TIME_SIGN): New macro.
2956 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2957 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2958 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2959 (make_timeval, make_lisp_time, decode_time_components): New decls.
2960 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2961 that it mishandled time_t overflow. You can't compare by subtracting!
2962 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2963 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2964
2965 * term.c: Include <sys/time.h>.
2966 (timeval_to_Time): New function, for proper overflow wraparound.
2967 (term_mouse_position, term_mouse_click): Use it.
2968
2969 * undo.c (record_first_change): Support higher-resolution time stamps
2970 in the undo buffer.
2971 (Fprimitive_undo): Use them when restoring time stamps.
2972
2973 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2974 (w32_get_internal_run_time):
2975 Port to higher-resolution Emacs time stamps.
2976 (ltime): Now accepts single 64-bit integer, as that's more convenient
2977 for callers.
2978
2979 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2980
2981 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2982 for compatibility with pselect. Support ns-resolution time stamps.
2983
2984 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2985
2986 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2987 Check for time stamp overflow, and support ns-resolution time stamps.
2988
2989 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2990 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2991 (timeval_subtract): Remove; no longer needed.
2992 (XTflash, XTring_bell, x_wait_for_event):
2993 Port to ns-resolution time stamps. Don't assume time_t is signed.
2994
b6a92dfe
CY
29952012-06-22 Chong Yidong <cyd@gnu.org>
2996
2997 * xdisp.c (x_consider_frame_title): Revert last change.
2998
d251c37c
EZ
29992012-06-22 Eli Zaretskii <eliz@gnu.org>
3000
3001 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3002 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3003 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3004 staticidx goes up to 1597 out of 1600 = 0x640.)
3005
f10deafb
PE
30062012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3007
3008 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3009 Otherwise, the umask might be mistakenly 0 while handling input signals.
3010
ec6de1e2
SM
30112012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3012
3013 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3014
28be1ada
DA
30152012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3016
3017 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3018 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3019 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3020 access to `contents' member of Lisp_Vector objects with AREF and ASET
3021 where appropriate.
3022
c6bf3022
CY
30232012-06-19 Chong Yidong <cyd@gnu.org>
3024
3025 * frame.c (delete_frame): When selecting a frame on a different
3026 text terminal, do not alter the terminal's top-frame.
3027
3028 * xdisp.c (format_mode_line_unwind_data): Record the target
3029 frame's selected window and its terminal's top-frame.
3030 (unwind_format_mode_line): Restore them.
3031 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3032 Callers changed.
3033 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3034 since tty frames can be explicitly named.
3035 (prepare_menu_bars): Likewise.
3036
3037 * term.c (Ftty_top_frame): New function.
3038
defd4196
PE
30392012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3040
3041 Port byte-code-meter to modern targets.
3042 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3043 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3044 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3045 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3046 (METER_1, METER_2): Simplify.
3047
1053a871
SM
30482012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3049
3050 * data.c (Fdefalias): Return `symbol' (bug#11686).
3051
b7e8d081
MR
30522012-06-18 Martin Rudalics <rudalics@gmx.at>
3053
3054 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3055 gets killed during executing of this function (Bug#11665).
3056 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3057 (Vkill_buffer_query_functions): In doc-string say that functions
3058 run by this hook should not change the current buffer.
3059
7ea2b339
PE
30602012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3061
3062 Fix recently-introduced process.c problems found by static checking.
3063 * process.c (write_queue_push, write_queue_pop, send_process):
3064 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3065 (write_queue_pop): Fix pointer signedness problem.
3066 (send_process): Remove unused local.
3067
96a313a1
CY
30682012-06-17 Chong Yidong <cyd@gnu.org>
3069
3070 * xdisp.c (redisplay_internal): No need to redisplay terminal
3071 frames that are not on top.
3072
20ca2e94
TN
30732012-06-17 Troels Nielsen <bn.troels@gmail.com>
3074
3075 * process.c (make_process): Initialize write_queue.
3076 (write_queue_push, write_queue_pop): New functions.
3077 (send_process): Use them to maintain correct ordering of process
3078 writes (Bug#10815).
3079
9a900ca9
PE
30802012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3081
310fbfa8
PE
3082 * lisp.h (eassert): Assume C89 or later.
3083 This removes the need for CHECK.
3084 (CHECK): Remove. Its comments about always evaluating its
3085 argument were confusing, as 'eassert' typically does not evaluate
3086 its argument.
3087
27bb1ca4
PE
3088 * coding.c (produce_chars): Use ptrdiff_t, not int.
3089
9a900ca9
PE
3090 * xterm.c (x_draw_underwave): Check for integer overflow.
3091 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3092
41b7f8bc 30932012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3094
3095 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3096 referenced (Bug#11583).
3097
9b0e3eba
AA
30982012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3099
3100 Implement wave-style variant of underlining.
3101 * dispextern.h (face_underline_type): New enum.
3102 (face): Add field for underline type.
3103 * nsterm.m (ns_draw_underwave): New function.
3104 (ns_draw_text_decoration): Use it.
3105 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3106 New functions.
3107 (x_draw_glyph_string): Use them.
3108 * xfaces.c (Qline, Qwave): New Lisp objects.
3109 (check_lface_attrs, merge_face_ref)
1053a871
SM
3110 (Finternal_set_lisp_face_attribute, realize_x_face):
3111 Handle wave-style underline face attributes.
9b0e3eba
AA
3112 * xterm.c (x_draw_underwave): New function.
3113 (x_draw_glyph_string): Use it.
3114
0fb52f11
JB
31152012-06-16 Juanma Barranquero <lekktu@gmail.com>
3116
3117 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3118 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3119 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3120 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3121 ($(BLD)/w32select.$(O)): Update dependencies.
3122
e5560ff7
AS
31232012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3124
3125 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3126 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3127 * character.c (_fetch_multibyte_char_p): Remove.
3128 * alloc.c: Include "character.h" before "buffer.h".
3129 * bidi.c: Likewise.
3130 * buffer.c: Likewise.
3131 * bytecode.c: Likewise.
3132 * callint.c: Likewise.
3133 * callproc.c: Likewise.
3134 * casefiddle.c: Likewise.
3135 * casetab.c: Likewise.
3136 * category.c: Likewise.
3137 * cmds.c: Likewise.
3138 * coding.c: Likewise.
3139 * composite.c: Likewise.
3140 * dired.c: Likewise.
3141 * dispnew.c: Likewise.
3142 * doc.c: Likewise.
3143 * dosfns.c: Likewise.
3144 * editfns.c: Likewise.
3145 * emacs.c: Likewise.
3146 * fileio.c: Likewise.
3147 * filelock.c: Likewise.
3148 * font.c: Likewise.
3149 * fontset.c: Likewise.
3150 * fringe.c: Likewise.
3151 * indent.c: Likewise.
3152 * insdel.c: Likewise.
3153 * intervals.c: Likewise.
3154 * keyboard.c: Likewise.
3155 * keymap.c: Likewise.
3156 * lread.c: Likewise.
3157 * macros.c: Likewise.
3158 * marker.c: Likewise.
3159 * minibuf.c: Likewise.
3160 * nsfns.m: Likewise.
3161 * nsmenu.m: Likewise.
3162 * print.c: Likewise.
3163 * process.c: Likewise.
3164 * regex.c: Likewise.
3165 * region-cache.c: Likewise.
3166 * search.c: Likewise.
3167 * syntax.c: Likewise.
3168 * term.c: Likewise.
3169 * textprop.c: Likewise.
3170 * undo.c: Likewise.
3171 * unexsol.c: Likewise.
3172 * w16select.c: Likewise.
3173 * w32fns.c: Likewise.
3174 * w32menu.c: Likewise.
3175 * window.c: Likewise.
3176 * xdisp.c: Likewise.
3177 * xfns.c: Likewise.
3178 * xmenu.c: Likewise.
3179 * xml.c: Likewise.
3180 * xselect.c: Likewise.
3181
2f07e6af
EZ
31822012-06-16 Eli Zaretskii <eliz@gnu.org>
3183
1053a871
SM
3184 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3185 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3186 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3187 row.
3188 (handle_face_prop): Use chunk-relative overlay string index when
3189 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3190 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3191 the rightmost. (Bug#11720)
2f07e6af 3192
29b83cec
AS
31932012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3194
3195 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3196 (CATEGORY_MEMBER): Enforce 1/0 value.
3197 * category.c (_temp_category_set): Remove.
3198
4c5501e9
EZ
31992012-06-16 Eli Zaretskii <eliz@gnu.org>
3200
3201 * window.c (Fdelete_other_windows_internal)
3202 (Fdelete_window_internal): Don't access frame's mouse highlight
3203 info of the initial frame. (Bug#11677)
3204
2b570124
PE
32052012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3206
e93864f9
PE
3207 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3208 Assume USE_2_TAGS_FOR_INTS.
3209 (xreload): Adjust $tagmask width to match recent lisp.h change.
3210
2b570124
PE
3211 Simplify lisp.h in minor ways that should not affect code.
3212 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3213 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3214 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3215 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3216 (INTTYPEBITS): New macro, for clarity.
3217 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3218 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3219 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3220 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3221 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3222
81755f69
JB
32232012-06-13 Juanma Barranquero <lekktu@gmail.com>
3224
3225 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3226
16192a57
GM
32272012-06-13 Glenn Morris <rgm@gnu.org>
3228
3229 * s/bsd-common.h (BSD4_3):
3230 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3231
646b5f55
AS
32322012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3233
3234 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3235 instead of union.
3236 (XLI, XIL): Define.
1053a871
SM
3237 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3238 Use them.
3239 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3240 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3241 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3242 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3243 * frame.c (delete_frame): Remove outdated comment.
3244 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3245 USE_LISP_UNION_TYPE.
3246 (Fw32_unregister_hot_key): Likewise.
3247 (Fw32_toggle_lock_key): Likewise.
3248 * w32menu.c (add_menu_item): Likewise.
3249 (w32_menu_display_help): Use XIL instead of checking
3250 USE_LISP_UNION_TYPE.
3251 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3252 (init_heap): Likewise.
3253 * w32term.c (w32_read_socket): Update comment.
3254
1d3823c9
GM
32552012-06-13 Glenn Morris <rgm@gnu.org>
3256
c62ff706
GM
3257 * s/usg5-4-common.h, src/s/unixware.h:
3258 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3259
1d3823c9
GM
3260 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3261
bfe3e0a2
PE
32622012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3263
3264 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3265 * alloc.c (make_number) [!defined make_number]:
3266 Remove, as lisp.h always defines this now.
3267 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3268 (roundup_size): Verify that it is a power of 2.
3269 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3270 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3271 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3272 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3273 USE_LSB_TAG now is always defined to be either 0 or 1.
3274 All uses changed.
3275 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3276 code works fine either way, and efficiency is not a concern here,
3277 as the union type is for debugging, not for production.
3278 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3279 Use an inline function on all platforms when using the union type,
3280 since this is simpler and 'static inline' can be used portably
3281 within Emacs now.
3282 (LISP_INITIALLY_ZERO): New macro.
3283 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3284 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3285
45fa9c0f
GM
32862012-06-12 Glenn Morris <rgm@gnu.org>
3287
b4492cba
GM
3288 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3289
3290 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3291
45fa9c0f
GM
3292 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3293 Move BROKEN_SIGIO to configure.
3294
3295 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3296 Move NO_TERMIO to configure.
3297
0e25d334
CY
32982012-06-12 Chong Yidong <cyd@gnu.org>
3299
3300 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3301 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3302 MagickExportImagePixels is undefined.
3303
43682bb6
PE
33042012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3305
3306 * image.c (imagemagick_load_image): Remove unused label.
3307
a9be7d2b
GM
33082012-06-11 Glenn Morris <rgm@gnu.org>
3309
3310 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3311 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3312 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3313 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3314
3017f87f
SM
33152012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3316
3317 * alloc.c (make_byte_code): New function.
3318 (Fmake_byte_code): Use it. Don't purify here.
3319 * lread.c (read1): Use it as well to avoid extra allocation.
3320
1b9b4cf4
CY
33212012-06-11 Chong Yidong <cyd@gnu.org>
3322
3323 * image.c (imagemagick_load_image): Implement transparency.
3324
95988fcf
AS
33252012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3326
3327 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3328 account for preceding backslashes. (Bug#11663)
3329
cd4eb164
CY
33302012-06-09 Chong Yidong <cyd@gnu.org>
3331
3332 * term.c: Support italics in capable terminals (Bug#9652).
3333 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3334 (turn_on_face): Output using TS_enter_italic_mode if available.
3335 Don't handle unused blinking and alt-charset cases.
3336 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3337 and tty_alt_charset_p cases.
3338 (tty_capable_p, init_tty): Support italics.
3339
3340 * termchar.h (struct tty_display_info): Add field for italics.
3341 Remove unused blink field.
3342
3343 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3344 Handle slant.
3345
3346 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3347 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3348 tty_alt_charset_p. Add tty_italic_p.
3349
ff88beb8
MA
33502012-06-09 Michael Albinus <michael.albinus@gmx.de>
3351
3352 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3353 dbus_type_is_basic if available.
3354 (xd_extract_signed, xd_extract_unsigned): Rename from
3355 extract_signed and extract_unsigned, respectively. Adapt callers.
3356
44286096
CY
33572012-06-09 Chong Yidong <cyd@gnu.org>
3358
1682701f
CY
3359 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3360
44286096
CY
3361 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3362 case (Bug#9752).
3363
d86feb17
PE
33642012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3365
3366 * xdisp.c (vmessage): Treat frame message as multibyte.
3367 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3368 would generate the diagnostic "Making \302\247 buffer-local while
3369 let-bound!".
3370
d5c20fe8
EZ
33712012-06-08 Eli Zaretskii <eliz@gnu.org>
3372
3373 * dispnew.c (showing_window_margins_p): Undo last change, which
3374 was done due to an inadvertent commit.
3375 (adjust_frame_glyphs_for_frame_redisplay): Do call
3376 showing_window_margins_p.
3377
513749ee
SM
33782012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3379
3380 * eval.c (Fmake_var_non_special): New primitive.
3381 (syms_of_eval): Defsubr it.
3382 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3383
d4a8f5c1
JB
33842012-06-08 Juanma Barranquero <lekktu@gmail.com>
3385
3386 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3387 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3388
8bbbc977
EZ
33892012-06-08 Eli Zaretskii <eliz@gnu.org>
3390
3391 * alloc.c (allocate_vectorlike): Fix last change.
3392
f3372c87
DA
33932012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3394
3395 Block-based vector allocation of small vectors.
3396 * lisp.h (struct vectorlike_header): New field `nbytes',
3397 adjust comment accordingly.
3398 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3399 to denote vector blocks. Adjust users (live_vector_p,
3400 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3401 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3402 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3403 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3404 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3405 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3406 (roundup_size): New constant.
3407 (struct vector_block): New data type.
3408 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3409 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3410 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3411 (sweep_vectors): New functions.
3412 (allocate_vectorlike): Return `zero_vector' as the only vector of
3413 0 items. Allocate new vector from block if vector size is less than
3414 or equal to VBLOCK_BYTES_MAX.
3415 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3416 (init_alloc_once): Add call to init_vectors.
3417
4f18a4ed
SM
34182012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3419
3420 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3421
86f158bc
PE
34222012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3423
3424 * doprnt.c (doprnt): Truncate multibyte char correctly.
3425 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3426 would mishandle a string argument "Xc" if X was a multibyte
3427 character of length 2: it would truncate after X's first byte
3428 rather than including all of X.
3429
c5cfcbe0
CY
34302012-06-06 Chong Yidong <cyd@gnu.org>
3431
3432 * buffer.c (word_wrap): Doc fix.
3433
c05cf390
PE
34342012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3435
3436 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3437
0c3461de
GM
34382012-06-03 Glenn Morris <rgm@gnu.org>
3439
3440 * xdisp.c (tool-bar-style): Doc fix.
3441
c71232db
UM
34422012-06-03 Ulrich Müller <ulm@gentoo.org>
3443
3444 * Makefile.in (PAXCTL): Define.
3445 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3446 binary via PaX flags if the paxctl utility is available.
3447 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3448 Restore PaX flags to their default. (Bug#11398)
3449
383f7350
CY
34502012-06-03 Chong Yidong <cyd@gnu.org>
3451
3452 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3453 buffer (Bug#11226).
3454
5f2c76c6
CY
34552012-06-03 Chong Yidong <cyd@gnu.org>
3456
3457 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3458 (note_mode_line_or_margin_highlight): If there is no help echo,
3459 use mode-line-default-help-echo. Handle the case where the mouse
3460 position is past the end of the mode line string.
3461
3462 * buffer.c (buffer_local_value_1): New function, split from
3463 Fbuffer_local_value; can return Qunbound.
3464 (Fbuffer_local_value): Use it.
3465 (Vmode_line_format): Docstring tweaks.
3466
773d47f6
PE
34672012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3468
3469 * sysdep.c (system_process_attributes): Improve comment.
3470
f2d6a3df
SM
34712012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3472
3473 * keyboard.c: Export real-this-command to Elisp.
3474 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3475 and DEFVAR it. Update all users.
3476
63810350
PE
34772012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3478
7bd5c1f4
PE
3479 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3480
63810350
PE
3481 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3482 Convert pctcpu and pctmem to Lisp float properly.
3483 Let the compiler fold better, as 100.0/0x8000 is exact.
3484
a2821611
AS
34852012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3486
3487 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3488 cons_block.
3489
5fceba1d
PE
34902012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3491
3492 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3493
c98ff5dd
DA
34942012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3495
3496 For a 'struct window', replace some Lisp_Object fields to
3497 bitfields where appropriate, remove unused fields.
3498 * window.h (struct window): Remove unused 'last_mark_x' and
3499 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3500 change it's type from Lisp_Object to bitfield.
3501 Change type of 'force_start', 'optional_new_start',
3502 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3503 fields from Lisp_Object to bitfield. Adjust users accordingly.
3504
ca34e0be
PE
35052012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3506
3507 Pacify gcc -Wdouble-precision when using Xaw.
3508 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3509 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3510 Use 'float' consistently, rather than 'float' in most places
3511 and 'double' in a couple of places.
3512
efc00ab1 35132012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3514
3515 * xdisp.c (handle_stop): Detect whether we have overlay strings
3516 loaded by testing it->current.overlay_string_index to be
3517 non-negative, instead of checking whether n_overlay_strings is
3518 positive. (Bug#11587)
3519
efc00ab1 35202012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3521
3522 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3523
3524 * doc.c (Fsubstitute_command_keys): Doc fix.
3525
efc00ab1 35262012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3527
3528 * search.c (search_buffer): Remove calls to
3529 r_alloc_inhibit_buffer_relocation, as it is now called by
3530 maybe_unify_char, which was the cause of relocation of buffer text
3531 in bug#11519.
3532
efc00ab1 35332012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3534
3535 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3536 for the duration of call to load_charset, to avoid problems with
3537 callers of maybe_unify_char that access buffer text through C
3538 pointers.
3539
3540 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3541 decrement the inhibition flag, instead of just setting or
3542 resetting it.
3543
ba93a187
PE
35442012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3545
3546 Remove obsolete '#define static' cruft.
3547 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3548 This #undef was "temporary" in 2000; it is no longer needed
3549 now that '#define static' has gone away.
3550 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3551 (gray_bitmap_bits): Remove; no longer needed.
3552 All uses replaced with definiens.
3553 * xterm.c: Include "bitmaps/gray.xbm".
3554
9e4bf381
PE
35552012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3556
3557 Clean up __executable_start, monstartup when --enable-profiling.
3558 The following changes affect the code only when profiling.
3559 * dispnew.c (__executable_start): Rename from safe_bcopy.
3560 Define only on platforms that need it.
3561 * emacs.c: Include <sys/gmon.h> when profiling.
3562 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3563 (__executable_start): Remove decl, since lisp.h does it now.
3564 (safe_bcopy): Remove decl; no longer has that name.
3565 (main): Coalesce #if into single bit of code, for simplicity.
3566 Cast pointers to uintptr_t, since standard libraries want integers
3567 and not pointers.
3568 * lisp.h (__executable_start): New decl.
3569
32d72c2f
GM
35702012-05-31 Glenn Morris <rgm@gnu.org>
3571
3572 * image.c (Fimagemagick_types): Doc fix.
3573
baac5bc7
JM
35742012-05-30 Jim Meyering <meyering@redhat.com>
3575
3576 * callproc.c (Fcall_process_region): Include directory component
3577 in mkstemp error message (Bug#11586).
3578
72cb32cf
PE
35792012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3580
3581 * alloc.c, lisp.h (make_pure_vector): Now static.
3582
61b108cc
SM
35832012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3584
3585 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3586 Move to byte-run.el.
3587 (Fautoload): Do the hash-doc more carefully.
3588 * data.c (Fdefalias): Purify definition, except for keymaps.
3589 (Qdefun): Move from eval.c.
3590 * lisp.h (Qdefun): Remove.
3591 * lread.c (read1): Tiny simplification.
3592
471fe23d
TN
35932012-05-29 Troels Nielsen <bn.troels@gmail.com>
3594
934f3f58 3595 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3596 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3597 Bug#9642, but explicitly check that the buffer the overlay would
3598 be moved to is live and rearrange lines to make sure that errors
3599 will not put the overlay in an inconsistent state.
3600 (Fdelete_overlay): Cosmetics.
3601
85d0efd1
EZ
36022012-05-28 Eli Zaretskii <eliz@gnu.org>
3603
3604 * w32term.c (my_bring_window_to_top): New function.
3605 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3606 could be different from the original one.
3607 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3608 (Bug#11513)
3609
3610 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3611 by calling BringWindowToTop.
3612
3613 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3614 (WM_EMACS_END): Increase by one.
3615
da92a98c
PE
36162012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3617
3618 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3619 This avoids undefined behavior that might cause the eassert
3620 to not catch an out-of-range value.
3621
74d1f848
JB
36222012-05-28 Juanma Barranquero <lekktu@gmail.com>
3623
3624 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3625 Update dependencies.
3626
9e1a06fc
EZ
36272012-05-27 Eli Zaretskii <eliz@gnu.org>
3628
3629 * bidi.c (bidi_mirror_char): Fix last change.
3630
f3dd7312
AS
36312012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3632
3633 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3634 when referring to sectname field in printf format.
3635
81899c91
PE
36362012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3637
57b81a9f
PE
3638 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3639 Only r_alloc_inhibit_buffer_relocation needed to be added;
3640 the others were already declared.
3641
81899c91
PE
3642 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3643 before checking whether it's out of range. Put the check inside
3644 eassert. See
3645 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3646
33017faf 36472012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3648
3649 * callproc.c (Fcall_process): Restore a line that was accidentally
3650 commented out in the 2011-02-13 change (bug#11547).
3651
33017faf 36522012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3653
3654 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3655 defined on ralloc.c.
3656
3657 * buffer.c [REL_ALLOC]: Remove prototypes of
3658 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3659 they are now on lisp.h.
3660
3661 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3662
3663 * search.c (search_buffer): Use it to inhibit relocation of buffer
3664 text while re_search_2 is doing its job, because re_search_2 is
3665 passed C pointers to buffer text. (Bug#11519)
3666
23415acf
EZ
3667 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3668 Update value to 24.
3669
44e27368
EZ
3670 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3671 state after an additional call to move_it_in_display_line_to, keep
3672 the values of it->max_ascent and it->max_descent found for the
3673 entire line.
3674 (pos_visible_p): Revert the comparison against bottom_y to what it
3675 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3676 (Bug#11464)
3677
c1892f11
PE
36782012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3679
3680 Fix coding-related core dumps with gcc -ftrapv.
3681 The code was computing A - B, where A and B are pointers, and B is
3682 random garbage. This can lead to core dumps on platforms that
3683 have special pointer registers, and it also leads to core dumps on
3684 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3685 A - B only when B is initialized properly.
3686 * coding.c (coding_set_source, coding_set_destination): Return void.
3687 (coding_change_source, coding_change_destinations): New functions,
3688 with the old behaviors of coding_set_source and coding_set_destination.
3689 All callers that need an offset changed to use these new functions.
3690
eb7afdad
GM
36912012-05-26 Glenn Morris <rgm@gnu.org>
3692
3693 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3694
f12fdf02
EZ
36952012-05-26 Eli Zaretskii <eliz@gnu.org>
3696
53a63be6 3697 Extend mouse support on W32 text-mode console.
61b108cc
SM
3698 * xdisp.c (draw_row_with_mouse_face):
3699 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3700
eb3f6f01 3701 * w32console.c: Include window.h.
61b108cc
SM
3702 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3703 New functions.
eb3f6f01
EZ
3704 (initialize_w32_display): Initialize mouse-highlight data.
3705
53a63be6
EZ
3706 * w32inevt.c: Include termchar.h and window.h.
3707 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3708 moves, call note_mouse_highlight. If help_echo changed, call
3709 gen_help_event to produce help-echo message in the echo area.
3710 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3711 highlight info.
3712
4cfd81f6
PE
37132012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3714
3715 * lread.c (read1): Simplify slightly to avoid an overflow warning
3716 with GCC 4.7.0 on x86-64.
3717
4446092a
EZ
37182012-05-26 Eli Zaretskii <eliz@gnu.org>
3719
3720 * bidi.c (bidi_mirror_char): Revert last change: an int is
3721 definitely wide enough here.
3722
42b2a986 37232012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3724
42b2a986 3725 Fix integer width and related bugs (Bug#9874).
eb106a49 3726 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3727 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3728 (string_bytes, check_sblock, allocate_string_data):
3729 (compact_small_strings, Fmake_bool_vector, make_string)
3730 (make_unibyte_string, make_multibyte_string)
3731 (make_string_from_bytes, make_specified_string)
3732 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3733 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3734 (mark_vectorlike):
3735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3736 (allocate_pseudovector):
3737 Use int, not EMACS_INT, where int is wide enough.
3738 (inhibit_garbage_collection, Fgarbage_collect):
3739 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3740 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3741 int might not be wide enough.
3742 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3743 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3744 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3745 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3746 (bidi_level_of_next_char, bidi_move_to_visually_next):
3747 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3748 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3749 (Fkill_buffer, Fset_buffer_major_mode)
3750 (advance_to_char_boundary, Fbuffer_swap_text)
3751 (Fset_buffer_multibyte, overlays_at, overlays_in)
3752 (overlay_touches_p, struct sortvec, record_overlay_string)
3753 (overlay_strings, recenter_overlay_lists)
3754 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3755 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3756 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3757 (Foverlay_recenter, last_overlay_modification_hooks_used)
3758 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3759 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3760 (validate_region): Omit unnecessary test for b <= e,
3761 since that's guaranteed by the previous test.
d311d28c
PE
3762 (adjust_overlays_for_delete): Avoid pos + length overflow.
3763 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3764 (report_overlay_modification):
3765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3766 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3767 Omit pointer cast, which isn't needed anyway, and doesn't work
3768 after the EMACS_INT -> ptrdiff_t change.
02481186 3769 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3770 * buffer.h: Adjust decls to match defn changes elsewhere.
3771 (struct buffer_text, struct buffer):
3772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3773 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3774 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3775 not int, to avoid needless 32-bit limit on 64-bit hosts.
3776 (exec_byte_code): Use tighter memory-full test, one that checks
3777 for alloca overflow. Don't compute the address of the object just
3778 before an array, as that's not portable. Use EMACS_INT, not
3779 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3780 * callint.c (Fcall_interactively):
3781 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3782 * callproc.c (call_process_kill, Fcall_process):
3783 Don't assume pid_t fits into an Emacs fixnum.
3784 (call_process_cleanup, Fcall_process, child_setup):
3785 Don't assume pid_t fits into int.
3786 (call_process_cleanup, Fcall_process, delete_temp_file)
3787 (Fcall_process_region):
3788 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3789 (Fcall_process): Simplify handling of volatile integers.
3790 Use int, not EMACS_INT, where int will do.
3791 * casefiddle.c (casify_object, casify_region, operate_on_word)
3792 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3793 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3794 (casify_object): Avoid integer overflow when overallocating buffer.
3795 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3796 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3797 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3798 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3799 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3800 integers are now checked earlier. All uses replaced with XINT.
3801 (ccl_driver):
3802 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3803 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3804 (ccl_driver, Fregister_code_conversion_map):
3805 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3806 (resolve_symbol_ccl_program): Check that vector header is in range.
3807 Always copy the vector, so that we can check its contents reliably
3808 now rather than having to recheck each instruction as it's being
3809 executed. Check that vector words fit in 'int'.
3810 (ccl_get_compiled_code, Fregister_ccl_program)
3811 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3812 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3813 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3814 contents are in range.
3815 (Fccl_execute_on_string): Check that status is in range.
3816 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3817 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3818 Accept and return EMACS_INT, not int, because callers can pass values
3819 out of 'int' range.
3820 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3821 (multibyte_chars_in_text, parse_str_as_multibyte)
3822 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3823 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3824 (string_escape_byte8, Fget_byte):
3825 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3826 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3827 avoid mishandling large integers.
3828 * character.h: Adjust decls to match defn changes elsewhere.
3829 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3830 (Ffind_charset_region):
3831 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3832 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3833 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3834 Don't assume fixnum fits in int.
d311d28c
PE
3835 (load_charset_map_from_vector, Fmap_charset_chars):
3836 Remove now-unnecessary CHECK_NATNUMs.
3837 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3838 Don't rely on undefined behavior with signed left shift overflow.
3839 Don't assume unsigned int fits into fixnum, or that fixnum fits
3840 into unsigned int. Don't require max_code to be a valid fixnum;
3841 that's not true for gb10830 4-byte on a 32-bit host. Allow
3842 invalid_code to be a cons, for the same reason. Require code_offset
3843 to be a character. Avoid int overflow if max_char is close
3844 to INT_MAX.
3845 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3846 this is intended anyway and avoids some undefined behavior.
3847 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3848 INDEX_TO_CODE_POINT, as that's what it expects.
3849 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3850 * charset.h (DECODE_CHAR): Return int, not unsigned;
3851 this is what was intended anyway, and it avoids undefined behavior.
3852 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3853 integer-overflow issues.
3854 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3855 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3856 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3857 * chartab.c (Fmake_char_table, Fset_char_table_range)
3858 (uniprop_get_decoder, uniprop_get_encoder):
3859 Don't assume fixnum fits in int.
3860 * cmds.c (move_point): New function, that does the gist of
3861 Fforward_char and Fbackward_char, but does so while checking
3862 for integer overflow more accurately.
c96e5d6a 3863 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3864 (Fforward_line, Fend_of_line, internal_self_insert)
3865 (internal_self_insert):
3866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3867 Fix a FIXME, by checking for integer overflow when calculating
3868 target_clm and actual_clm.
3869 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3870 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3871 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3872 (coding_alloc_by_making_gap, alloc_destination)
3873 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3874 (encode_coding_utf_16, detect_coding_emacs_mule)
3875 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3876 (detect_coding_iso_2022, decode_coding_iso_2022)
3877 (encode_invocation_designation, encode_designation_at_bol)
3878 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3879 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3880 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3881 (encode_coding_ccl, encode_coding_raw_text)
3882 (detect_coding_charset, decode_coding_charset)
3883 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3884 (produce_composition, produce_charset, produce_annotation)
3885 (decode_coding, handle_composition_annotation)
3886 (handle_charset_annotation, consume_chars, decode_coding_gap)
3887 (decode_coding_object, encode_coding_object, detect_coding_system)
3888 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3889 (code_convert_region, code_convert_string)
8f50130c
PE
3890 (Fdefine_coding_system_internal)
3891 (coding_set_source, coding_set_destination):
d311d28c
PE
3892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3893 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3894 (Fdefine_coding_system_internal):
3895 Don't assume fixnums fit in int.
3896 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3897 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3898 (Funencodable_char_position, Fcheck_coding_systems_region)
3899 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3900 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3901 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3902 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3903 Don't access memory outside of the args array.
d311d28c 3904 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3905 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3906 result of ENCODE_CHAR.
d311d28c
PE
3907 * coding.h: Adjust decls to match defn changes elsewhere.
3908 (struct coding_system):
3909 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3910 * composite.c (get_composition_id, find_composition)
3911 (run_composition_function, update_compositions)
3912 (compose_text, composition_gstring_put_cache)
3913 (composition_gstring_p, composition_gstring_width)
3914 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3915 (composition_compute_stop_pos, composition_reseat_it)
3916 (composition_update_it, struct position_record)
3917 (find_automatic_composition, composition_adjust_point)
3918 (Fcomposition_get_gstring, Ffind_composition_internal):
3919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3920 (update_compositions):
3921 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3922 * composite.h: Adjust decls to match defn changes elsewhere.
3923 (struct composition):
3924 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3925 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3926 Do not attempt to compute the address of the object just before a
3927 buffer; this is not portable.
3928 (Faref, Faset):
3929 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3930 (Faset): Use int, not EMACS_INT, where int is wide enough.
3931 (Fstring_to_number): Don't assume fixnums fit in int.
3932 (Frem): Don't assume arg is nonnegative.
3933 * dbusbind.c (xd_append_arg): Check for integers out of range.
3934 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3935 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3936 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3937 (xd_get_connection_references): Return ptrdiff_t, not int.
3938 All uses changed.
3939 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3940 (xd_read_message_1):
3941 Use int, not unsigned, where the dbus API uses int.
3942 (Fdbus_message_internal): Don't overflow mtype.
3943 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3944 * dired.c (directory_files_internal, file_name_completion, scmp)
3945 (file_name_completion_stat):
3946 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3947 (file_name_completion): Don't overflow matchcount.
3948 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3949 * dispextern.h: Adjust decls to match defn changes elsewhere.
3950 (struct text_pos, struct glyph, struct bidi_saved_info)
3951 (struct bidi_string_data, struct bidi_it, struct composition_it)
3952 (struct it):
3953 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3954 (struct display_pos, struct composition_it, struct it):
3955 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3956 * dispnew.c (increment_matrix_positions)
3957 (increment_row_positions, mode_line_string)
3958 (marginal_area_string):
3959 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3960 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3961 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3962 (duration_to_sec_usec): New function, to check for overflow better.
3963 (Fsleep_for, sit_for): Use it.
3964 * doc.c (get_doc_string, store_function_docstring):
3965 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3966 (get_doc_string, Fsnarf_documentation):
3967 Use int, not EMACS_INT, where int is wide enough.
3968 (get_doc_string):
3969 Use SAFE_ALLOCA, not alloca.
3970 Check for overflow when converting EMACS_INT to off_t.
3971 * doprnt.c (doprnt):
3972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3973 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3974 Don't assume uid_t fits into fixnum.
3975 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3976 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3977 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3978 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3979 (general_insert_function)
3980 (Finsert_char, make_buffer_string, make_buffer_string_both)
3981 (update_buffer_properties, Fbuffer_substring)
3982 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3983 (Fsubst_char_in_region, check_translation)
3984 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3985 (transpose_markers, Ftranspose_regions):
3986 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3987 (clip_to_bounds): Move to lisp.h as an inline function).
3988 (Fconstrain_to_field): Don't assume integers are nonnegative.
3989 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3990 (Fsubst_char_in_region, Fsave_restriction):
3991 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3992 (Femacs_pid): Don't assume pid_t fits into fixnum.
3993 (lo_time): Use int, not EMACS_INT, when int suffices.
3994 (lisp_time_argument): Check for usec out of range.
3995 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3996 (Fuser_login_name, Fuser_full_name): Signal an error
3997 if a uid argument is out of range, rather than relying on
3998 undefined behavior.
c8d5c857
PE
3999 (Fformat_time_string): Remove now-unnecessary check.
4000 lisp_time_argument checks for out-of-range usec now.
243e0530 4001 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4002 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4003 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4004 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4005 (init_cmdargs, Fdump_emacs):
4006 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4007 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4008 the bottom (typically) 32 bits of the fixnum.
4009 * eval.c (specpdl_size, call_debugger):
4010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4011 (when_entered_debugger, Fbacktrace_debug):
4012 Don't assume fixnum can fit in int.
4013 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4014 the object just before a buffer; this is not portable.
4015 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4016 (grow_specpdl, unbind_to):
4017 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4018 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4019 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4020 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4021 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4022 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4024 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4025 (a_write, e_write):
4026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4027 (Fcopy_file, non_regular_nbytes, read_non_regular)
4028 (Finsert_file_contents):
4029 Use int, not EMACS_INT, where int is wide enough.
4030 (READ_BUF_SIZE): Verify that it fits in int.
4031 (Finsert_file_contents): Check that counts are in proper range,
4032 rather than assuming fixnums fit into ptrdiff_t etc.
4033 Don't assume fixnums fit into int.
125b3835 4034 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4035 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4036 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4037 (string_char_to_byte, string_byte_to_char)
4038 (string_make_multibyte, string_to_multibyte)
4039 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4040 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4041 (substring_both, Fdelete, internal_equal, Ffillarray)
4042 (Fclear_string, mapcar1)
4043 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4044 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4045 (larger_vector, make_hash_table, maybe_resize_hash_table)
4046 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4047 (Fmaphash, secure_hash):
4048 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4049 (concat): Check for string index and length overflow.
4050 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4051 (Frequire):
4052 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4053 (larger_vector): New API (vec, incr_min, size_max) replaces old
4054 one (vec, new_size, init). This catches size overflow.
4055 INIT was removed because it was always Qnil.
4056 All callers changed.
4057 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4058 the upper bound on a hash table index size.
4059 (make_hash_table, maybe_resize_hash_table): Use it.
4060 (secure_hash): Computer start_byte and end_byte only after
4061 they're known to be in ptrdiff_t range.
4062 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4063 (Ffont_get_glyphs, Ffont_at):
4064 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4065 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4066 (Flist_fonts, Fopen_font):
4067 Don't assume fixnum can fit in int.
4068 (check_gstring): Don't assume index can fit in int.
4069 (font_match_p): Check that fixnum is a character, not a nonnegative
4070 fixnum, since the later code needs to stuff it into an int.
4071 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4072 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4073 conversion overflow issues.
4074 (Fopen_font): Check for integer out of range.
4075 (Ffont_get_glyphs): Don't assume index can fit in int.
4076 * font.h: Adjust decls to match defn changes elsewhere.
4077 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4078 integer overflow.
4079 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4080 printmax_t, where ptrdiff_t is wide enough.
4081 (Finternal_char_font):
4082 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4083 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4084 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4085 (Fset_frame_position, x_set_frame_parameters)
4086 (x_set_line_spacing, x_set_border_width)
4087 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4088 Check that fixnums are in proper range for system types.
4089 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4090 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4091 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4092 Use SAFE_ALLOCA_LISP, not alloca.
4093 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4094 intptr_t is wide enough.
4095 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4096 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4097 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4098 Check for fixnum out of range.
4099 * ftfont.c (ftfont_list): Don't assume index fits in int.
4100 Check that fixnums are in proper range for system types.
4101 (ftfont_shape_by_flt):
4102 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4103 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4104 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4105 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4106 Check that fixnums are in proper range for system types.
4107 * gnutls.h: Adjust decls to match defn changes elsewhere.
4108 * gtkutil.c (xg_dialog_run):
4109 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4110 (update_frame_tool_bar):
4111 Check that fixnums are in proper range for system types.
4112 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4113 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4114 * indent.c (last_known_column, last_known_column_point):
4115 (current_column_bol_cache):
4116 (skip_invisible, current_column, check_display_width):
4117 (check_display_width, scan_for_column, current_column_1)
4118 (Findent_to, Fcurrent_indentation, position_indentation)
4119 (indented_beyond_p, Fmove_to_column, compute_motion):
4120 (Fcompute_motion, Fvertical_motion):
4121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4122 (last_known_column_modified): Use EMACS_INT, not int.
4123 (check_display_width):
4124 (Fcompute_motion):
4125 Check that fixnums and floats are in proper range for system types.
4126 (compute_motion): Don't assume index or fixnum fits in int.
4127 (compute_motion, Fcompute_motion):
4128 Use int, not EMACS_INT, when it is wide enough.
4129 (vmotion): Omit local var start_hpos that is always 0; that way
4130 we don't need to worry about overflow in expressions involving it.
4131 * indent.h: Adjust decls to match defn changes elsewhere.
4132 (struct position):
4133 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4134 Use int, not EMACS_INT, where int is wide enough.
4135 Remove unused members ovstring_chars_done and tab_offset;
4136 all uses removed.
4137 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4138 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4139 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4140 (make_gap, copy_text, insert, insert_and_inherit)
4141 (insert_before_markers, insert_before_markers_and_inherit)
4142 (insert_1, count_combining_before, count_combining_after)
4143 (insert_1_both, insert_from_string)
4144 (insert_from_string_before_markers, insert_from_string_1)
4145 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4146 (adjust_after_replace, adjust_after_insert, replace_range)
4147 (replace_range_2, del_range, del_range_1, del_range_byte)
4148 (del_range_both, del_range_2, modify_region)
4149 (prepare_to_modify_buffer, signal_before_change)
4150 (signal_after_change, Fcombine_after_change_execute):
4151 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4152 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4153 (balance_an_interval, split_interval_right, split_interval_left)
4154 (find_interval, next_interval, update_interval)
4155 (adjust_intervals_for_insertion, delete_node, delete_interval)
4156 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4157 (static_offset_intervals, offset_intervals)
4158 (merge_interval_right, merge_interval_left, make_new_interval)
4159 (graft_intervals_into_buffer, temp_set_point_both)
4160 (temp_set_point, set_point, adjust_for_invis_intang)
4161 (set_point_both, move_if_not_intangible, get_property_and_range)
4162 (get_local_map, copy_intervals, copy_intervals_to_string)
4163 (compare_string_intervals, set_intervals_multibyte_1):
4164 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4165 * intervals.h: Adjust decls to match defn changes elsewhere.
4166 (struct interval):
4167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4168 * keyboard.c (this_command_key_count, this_single_command_key_start)
4169 (before_command_key_count, before_command_echo_length, echo_now)
4170 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4171 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4172 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4173 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4174 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4175 (last_non_minibuf_size, last_point_position, echo_truncate)
4176 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4177 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4178 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4179 (stuff_buffered_input):
4180 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4181 (last_auto_save, command_loop_1, read_char):
4182 Use EMACS_INT, not int, to avoid integer overflow.
4183 (record_char): Avoid overflow in total_keys computation.
4184 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4185 * keyboard.h: Adjust decls to match defn changes elsewhere.
4186 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4187 (Fkey_description, Fdescribe_vector, Flookup_key):
4188 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4189 (click_position): New function, to check that positions are in range.
4190 (Fcurrent_active_maps):
4191 (describe_command):
4192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4193 (Faccessible_keymaps, Fkey_description):
4194 (preferred_sequence_p):
4195 Don't assume fixnum can fit into int.
4196 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4197 Check for integer overflow in size calculations.
4198 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4199 avoid mishandling large integers.
4200 * lisp.h: Adjust decls to match defn changes elsewhere.
4201 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4202 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4203 (struct Lisp_Marker):
4204 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4205 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4206 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4207 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4208 All callers changed.
4209 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4210 Assume the arg has valid form, since it always does.
4211 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4212 unsigned integer system type.
4213 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4214 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4215 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4216 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4217 (duration_to_sec_usec): New decl.
4218 * lread.c (read_from_string_index, read_from_string_index_byte)
4219 (read_from_string_limit, readchar, unreadchar, openp)
4220 (read_internal_start, read1, oblookup):
4221 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4222 (Fload, readevalloop, Feval_buffer, Feval_region):
4223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4224 (openp): Check for out-of-range argument to 'access'.
4225 (read1): Use int, not EMACS_INT, where int is wide enough.
4226 Don't assume fixnum fits into int.
6efdadfd 4227 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4228 (read_filtered_event): Use duration_to_sec_usec
4229 to do proper overflow checking on durations.
d311d28c
PE
4230 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4231 in size calculation.
4232 (Fexecute_kbd_macro):
4233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4234 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4235 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4236 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4237 (set_marker_both, set_marker_restricted_both, marker_position)
4238 (marker_byte_position, Fbuffer_has_markers_at):
4239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4240 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4241 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4242 It now merely ensures that the menu is large enough, without
4243 necessarily growing it, as this avoids some integer overflow issues.
4244 All callers changed.
4245 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4246 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4247 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4248 Use SAFE_ALLOCA_LISP, not alloca.
4249 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4250 to EMACS_INT. Check that fixnums are in proper range for system types.
4251 * minibuf.c (minibuf_prompt_width, string_to_object)
4252 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4253 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4254 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4255 (get_minibuffer, read_minibuf_unwind):
4256 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4257 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4258 this simplifies overflow checking. All callers changed.
4259 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4260 (Ftest_completion):
4261 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4262 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4263 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4264 Check that fixnums are in proper range for system types.
4265 (Fx_create_frame, Fx_show_tip):
4266 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4267 * nsfont.m (ns_findfonts, nsfont_list_family):
4268 Don't assume fixnum fits in long.
4269 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4270 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4271 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4272 wide enough.
17fdb222 4273 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4274 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4275 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4276 (PRINTDECLARE, PRINTPREPARE):
4277 (strout, print_string):
4278 (print, print_preprocess, print_check_string_charset_prop)
4279 (print_object):
4280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4281 (PRINTDECLARE):
4282 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4283 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4284 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4285 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4286 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4287 (print_error_message): Use SAFE_ALLOCA, not alloca.
4288 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4289 (print_depth, new_backquote_output, print_number_index):
4290 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4291 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4292 (Fset_process_window_size, Fformat_network_address)
4293 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4294 (sigchld_handler):
d311d28c 4295 Check that fixnums are in proper range for system types.
d44287d4 4296 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4297 Check for process-ids out of pid_t range rather than relying on
4298 undefined behavior.
e4d81efc 4299 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4300 (Fformat_network_address, read_process_output, send_process)
4301 (Fprocess_send_region, status_notify):
4302 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4303 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4304 (wait_reading_process_output, read_process_output, exec_sentinel):
4305 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4306 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4307 (Faccept_process_output): Use duration_to_sec_usec to do proper
4308 overflow checking on durations.
dde14581
PE
4309 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4310 Don't assume pid_t fits in int.
02481186
PE
4311 * process.h (struct Lisp_Process): Members tick and update_tick
4312 are now of type EMACS_INT, not int.
b62b53e8
PE
4313 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4314 configured --with-wide-int.
d311d28c
PE
4315 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4316 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4317 * search.c (looking_at_1, string_match_1):
4318 (fast_string_match, fast_c_string_match_ignore_case)
4319 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4320 (scan_newline, find_before_next_newline, search_command)
4321 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4322 (set_search_regs, wordify):
4323 (Freplace_match):
4324 (Fmatch_data):
4325 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4326 (string_match_1, search_buffer, set_search_regs):
4327 (Fmatch_data):
4328 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4329 (wordify): Check for overflow in size calculation.
4330 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4331 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4332 Check that fixnums are in proper range for system types.
4333 * sound.c (struct sound_device)
4334 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4336 (Fplay_sound_internal):
4337 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4338 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4339 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4340 (Fparse_partial_sexp):
4341 Don't assume fixnums can fit in int.
4342 (struct lisp_parse_state, find_start_pos, find_start_value)
4343 (find_start_value_byte, find_start_begv)
4344 (update_syntax_table, char_quoted, dec_bytepos)
4345 (find_defun_start, prev_char_comend_first, back_comment):
4346 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4347 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4349 (Finternal_describe_syntax_value): Check that match_lisp is a
4350 character, not an integer, since the code stuffs it into int.
4351 (scan_words, scan_sexps_forward):
4352 Check that fixnums are in proper range for system types.
4353 (Fforward_word):
4354 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4355 (scan_sexps_forward):
4356 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4357 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4358 * syntax.h: Adjust decls to match defn changes elsewhere.
4359 (struct gl_state_s):
4360 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4361 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4362 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4363 * sysdep.c (wait_for_termination_1, wait_for_termination)
4364 (interruptible_wait_for_termination, mkdir):
4365 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4366 (emacs_read, emacs_write):
4367 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4368 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4369 and double all fit in int.
d311d28c
PE
4370 * term.c (set_tty_color_mode):
4371 Check that fixnums are in proper range for system types.
4372 * termhooks.h (struct input_event):
4373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4374 * textprop.c (validate_interval_range, interval_of)
4375 (Fadd_text_properties, set_text_properties_1)
4376 (Fremove_text_properties, Fremove_list_of_text_properties)
4377 (Ftext_property_any, Ftext_property_not_all)
4378 (copy_text_properties, text_property_list, extend_property_ranges)
4379 (verify_interval_modification):
4380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4381 (Fnext_single_char_property_change)
4382 (Fprevious_single_char_property_change):
4383 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4384 (copy_text_properties):
4385 Check for integer overflow in index calculation.
d311d28c
PE
4386 * undo.c (last_boundary_position, record_point, record_insert)
4387 (record_delete, record_marker_adjustment, record_change)
4388 (record_property_change):
4389 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4390 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4391 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4392 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4393 (Fx_hide_tip, Fx_file_dialog):
4394 * w32menu.c (set_frame_menubar):
4395 Use ptrdiff_t, not int, for consistency with rest of code.
4396 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4397 (select_window, Fdelete_other_windows_internal)
4398 (window_scroll_pixel_based, window_scroll_line_based)
4399 (Frecenter, Fset_window_configuration):
4400 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4401 (Fset_window_hscroll, run_window_configuration_change_hook)
4402 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4403 (Fscroll_other_window, Frecenter):
d311d28c
PE
4404 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4405 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4406 Don't assume fixnum fits in int.
4407 (Fset_window_scroll_bars):
4408 Check that fixnums are in proper range for system types.
4409 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4410 (string_pos, c_string_pos, number_of_chars, init_iterator)
4411 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4412 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4413 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4414 (face_before_or_after_it_pos, handle_invisible_prop)
4415 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4416 (display_prop_intangible_p, string_buffer_position_lim)
4417 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4418 (get_overlay_strings_1, get_overlay_strings)
4419 (iterate_out_of_display_property, forward_to_next_line_start)
4420 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4421 (get_next_display_element, set_iterator_to_next)
4422 (get_visually_first_element, compute_stop_pos_backwards)
4423 (handle_stop_backwards, next_element_from_buffer)
4424 (move_it_in_display_line_to, move_it_in_display_line)
4425 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4426 (add_to_log, message_dolog, message_log_check_duplicate)
4427 (message2, message2_nolog, message3, message3_nolog
4428 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4429 (current_message_1, truncate_echo_area, truncate_message_1)
4430 (set_message, set_message_1, store_mode_line_noprop)
4431 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4432 (text_outside_line_unchanged_p, check_point_in_composition)
4433 (reconsider_clip_changes)
4434 (redisplay_internal, set_cursor_from_row, try_scrolling)
4435 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4436 (redisplay_window, find_last_unchanged_at_beg_row)
4437 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4438 (trailing_whitespace_p, find_row_edges, display_line)
4439 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4440 (display_mode_element, store_mode_line_string)
4441 (pint2str, pint2hrstr, decode_mode_spec)
4442 (display_count_lines, display_string, draw_glyphs)
4443 (x_produce_glyphs, x_insert_glyphs)
4444 (rows_from_pos_range, mouse_face_from_buffer_pos)
4445 (fast_find_string_pos, mouse_face_from_string_pos)
4446 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4447 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4448 (safe_call, init_from_display_pos, handle_fontified_prop)
4449 (handle_single_display_spec, load_overlay_strings)
4450 (with_echo_area_buffer, setup_echo_area_for_printing)
4451 (display_echo_area, echo_area_display)
4452 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4453 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4454 (redisplay_window, dump_glyph_row, display_mode_line)
4455 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4456 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4458 (handle_single_display_spec, build_desired_tool_bar_string)
4459 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4460 (get_specified_cursor_type):
4461 Check that fixnums are in proper range for system types.
4462 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4463 (Flookup_image_map):
4464 Don't assume fixnums fit in int.
4465 (compare_overlay_entries):
4466 Avoid mishandling comparisons due to subtraction overflow.
4467 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4468 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4469 (handle_tool_bar_click):
4470 Use int, not unsigned, since we prefer signed and the signedness
4471 doesn't matter here.
4472 (get_next_display_element, next_element_from_display_vector):
4473 Use int, not EMACS_INT, when int is wide enough.
4474 (start_hourglass): Use duration_to_sec_usec to do proper
4475 overflow checking on durations.
4476 * xfaces.c (Fbitmap_spec_p):
4477 Check that fixnums are in proper range for system types.
4478 (compare_fonts_by_sort_order):
4479 Avoid mishandling comparisons due to subtraction overflow.
4480 (Fx_family_fonts, realize_basic_faces):
4481 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4482 (Fx_family_fonts):
4483 Don't assume fixnum fits in int.
4484 Use SAFE_ALLOCA_LISP, not alloca.
4485 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4486 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4487 (face_at_buffer_position, face_for_overlay_string)
4488 (face_at_string_position):
4489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4490 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4491 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4492 (Fx_show_tip):
4493 Check that fixnums are in proper range for system types.
4494 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4495 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4497 (Fx_change_window_property): Don't assume fixnums fit in int.
4498 * xfont.c (xfont_chars_supported):
4499 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4500 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4501 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4503 * xml.c (parse_region):
4504 * xrdb.c (magic_file_p):
4505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4506 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4507 (x_get_local_selection, x_reply_selection_request)
4508 (x_handle_selection_request, wait_for_property_change):
4509 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4510 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4511 short is wide enough.
4512 (x_send_client_event): Don't assume fixnum fits in int.
4513 * xterm.c (x_x_to_emacs_modifiers):
4514 Don't assume EMACS_INT overflows nicely into int.
4515 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4516 may come from Lisp.
4517 (handle_one_xevent): NATNUMP can eval its arg twice.
4518 (x_connection_closed):
4519 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4520 * xterm.h: Adjust decls to match defn changes elsewhere.
4521 (struct scroll_bar): Use struct vectorlike_header
4522 rather than rolling our own approximation.
4523 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4524
c6574eb5
GM
45252012-05-25 Glenn Morris <rgm@gnu.org>
4526
4527 * lisp.mk (lisp): Update for more files being compiled now.
4528
e8d32c7e
SM
45292012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4530
48def666
SM
4531 * lread.c: Remove `read_pure' which makes no difference.
4532 (read_pure): Remove var.
4533 (unreadpure): Remove function.
4534 (readevalloop): Don't call read_list with -1 flag.
4535 (read1, read_vector): Don't test read_pure any more.
4536 (read_list): Simplify.
4537
e8d32c7e
SM
4538 * fileio.c, character.h: Minor style tweaks.
4539
4b2addb7
DA
45402012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4541
4542 * window.h (clip_changed): Remove useless declaration.
4543
584461b2
JB
45442012-05-22 Juanma Barranquero <lekktu@gmail.com>
4545
4546 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4547 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4548
34374650
PE
45492012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4550
4551 Remove src/m/*.
4552 This directory predates autoconf and is no longer needed nowadays.
4553 Move its few remaining bits of functionality to where they're needed.
4554 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4555 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4556 * m/template.h: Remove.
4557 * Makefile.in (M_FILE): Remove. All uses removed.
4558 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4559 * lisp.h (USE_LSB_TAG):
4560 * mem-limits.h (EXCEEDS_LISP_PTR):
4561 Use VAL_MAX, not VALBITS, in #if.
4562 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4563 (EMACS_UINT): Define unconditionally now.
4564 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4565 (BITS_PER_EMACS_INT): New constants, replacing
4566 what used to be in config.h, but not useful in #if.
4567 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4568 define them any more.
4569 (VAL_MAX): New macro.
4570 (VALMASK): Use it.
4571 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4572 BITS_PER_EMACS_INT, in #if.
4573 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4574 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4575 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4576 * s/ms-w32.h (DATA_START):
4577 Move here from removed file m/intel386.h.
4578 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4579 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4580
261cb4bb
PE
45812012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4582
4583 Assume C89 or later.
4584 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4585 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4586 (xrealloc):
4587 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4588 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4589 * textprop.c, tparam.c (NULL): Remove.
4590 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4591 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4592 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4593 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4594 * xterm.c (input_signal_count): Assume volatile works.
4595
ff23cd9f
KB
45962012-05-21 Ken Brown <kbrown@cornell.edu>
4597
4598 * xgselect.c (xg_select): Fix first argument in call to 'select'
4599 (bug#11508).
4600
1b170bc6
KB
46012012-05-20 Ken Brown <kbrown@cornell.edu>
4602
4603 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4604 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4605
b2f4d39f
KB
46062012-05-19 Ken Brown <kbrown@cornell.edu>
4607
4608 * xfns.c (x_in_use): Remove `static' qualifier.
4609 * xterm.h (x_in_use): Declare.
4610 * xgselect.c: Include xterm.h.
4611 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4612 and `display_arg' (bug#9754).
4613
003fdae2
PE
46142012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4615
9232a6d9
PE
4616 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4617
003fdae2
PE
4618 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4619 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4620
784b56e2
EZ
46212012-05-18 Eli Zaretskii <eliz@gnu.org>
4622
4623 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4624
4625 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4626 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4627
4628 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4629 reference to image_cache->refcount.
4630 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4631
a0a79cde
JL
46322012-05-17 Juri Linkov <juri@jurta.org>
4633
4634 * search.c (Fword_search_regexp, Fword_search_backward)
4635 (Fword_search_forward, Fword_search_backward_lax)
4636 (Fword_search_forward_lax): Move functions to isearch.el
4637 (bug#10145, bug#11381).
4638
b0572523
PE
46392012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4640
4641 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4642
9660f5fc
SM
46432012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4644
4645 * lread.c (init_obarray): Declare Qt and Qnil as special.
4646
4374de83
GM
46472012-05-14 Glenn Morris <rgm@gnu.org>
4648
4649 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4650 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4651
dc44c39a
PE
46522012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4653
078c97cb
PE
4654 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4655
dc44c39a
PE
4656 * unexaix.c: Port to more-recent AIX compilers.
4657 (report_error, report_error_1, make_hdr, copy_sym)
4658 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4659 Make arguments const char *, not char *, to avoid violations of C
4660 standard and to fix some AIX warnings reported by Gilles Pion.
4661
e18afed7 46622012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4663
4664 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4665 already have overlays loaded.
4666 (handle_single_display_spec): Before returning without displaying
4667 fringe bitmap, synchronize the bidi iterator with the main display
4668 iterator, by calling iterate_out_of_display_property.
4669 (iterate_out_of_display_property): Detect buffer iteration by
4670 testing that it->string is a Lisp string.
4671 (get_next_display_element): When the current object is exhausted,
4672 and there's something on it->stack, call set_iterator_to_next to
4673 proceed with what's on the stack, instead of returning zero.
4674 (set_iterator_to_next): If called at the end of a Lisp string,
4675 proceed to consider_string_end without incrementing string
4676 position. Don't increment display vector index past the end of
4677 the display vector. (Bug#11417)
c8fb9dc6
EZ
4678 (pos_visible_p): Don't report a position visible when move_it_to
4679 stopped at the last line of window, which happens to be scanned
4680 backwards by the bidi iteration. (Bug#11464)
ac268e67 4681
e18afed7 46822012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4683
4684 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4685 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4686 are on a TTY, and thus unable to display on the fringes.
4687 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4688 so we need to signal to the caller that this is a "replacing"
4689 display spec. This fixes display when the spec is invalid or we
4690 are on a TTY.
4691
e18afed7 46922012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4693
4694 * unexaix.c (make_hdr): Fix typo in prototype.
4695 This bug broke the build on AIX. Problem reported by Gilles Pion.
4696
9d0a235a
MA
46972012-05-14 Michael Albinus <michael.albinus@gmx.de>
4698
4699 * keyboard.c (kbd_buffer_get_event): Read special events also in
4700 batch mode. (Bug#11415)
4701
9e6b06ed
GM
47022012-05-12 Glenn Morris <rgm@gnu.org>
4703
4704 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4705
c1a1d7a3
EZ
47062012-05-12 Eli Zaretskii <eliz@gnu.org>
4707
4708 * lisp.mk (lisp): Add newcomment.elc.
4709
3fe7cdc8
GM
47102012-05-12 Glenn Morris <rgm@gnu.org>
4711
4712 * Makefile.in (MKDIR_P): New, set by configure.
4713 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4714
53f7d2c0
PE
47152012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4716
4717 Remove unused function hourglass_started.
4718 * dispextern.h (hourglass_started):
4719 * w32fns.c (hourglass_started):
4720 * xdisp.c (hourglass_started): Remove.
4721
75aafb17
JB
47222012-05-10 Juanma Barranquero <lekktu@gmail.com>
4723
4724 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4725 Update dependencies.
4726
12959e8e
PE
47272012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4728
97107e2e
PE
4729 * xgselect.c (xg_select): Put maxfds+1 into a var.
4730 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4731
12959e8e
PE
4732 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4733
836d29b3
DA
47342012-05-10 Dave Abrahams <dave@boostpro.com>
4735
4736 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4737 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4738
5cb67954
MA
47392012-05-09 Michael Albinus <michael.albinus@gmx.de>
4740
4741 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4742 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4743 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4744 Initialize xd_registered_buses.
4745
3478ec45
PE
47462012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4747
b263a6b0
PE
4748 Untag more efficiently if USE_LSB_TAG.
4749 This is based on a proposal by YAMAMOTO Mitsuharu in
4750 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4751 For an admittedly artificial (nth 8000 longlist) benchmark on
4752 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4753 Emacs's overall text size by 1%.
4754 * lisp.h (XUNTAG): New macro.
4755 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4756 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4757 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4758 * eval.c (Fautoload):
4759 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4760 * frame.h (XFRAME): Use XUNTAG.
4761
3478ec45
PE
4762 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4763 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4764 Remove unportable assumptions about print widths of types like
4765 dbus_uint32_t.
4766 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4767 intptr_t when converting between pointer and integer, to avoid GCC
4768 warnings about wrong width.
4769
666b903b 47702012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4771
4772 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4773 stack for each reader_thread, instead of defaulting to 8MB
4774 determined by the linker. This avoids failures in creating
4775 subprocesses on Windows 7, see the discussion in this thread:
4776 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4777
b120cc17
JC
47782012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4779
4780 Fix up display of the *Minibuf-0* buffer in the mini window.
4781 * keyboard.c (read_char): Don't clear the echo area if there's no
4782 message to clear.
4783 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4784 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4785
9a4b36f8
MA
47862012-05-07 Michael Albinus <michael.albinus@gmx.de>
4787
4788 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4789 batch mode.
4790
e5f9458f
CY
47912012-05-06 Chong Yidong <cyd@gnu.org>
4792
4793 * lisp.mk (lisp): Update.
4794
eceeb5fc 47952012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4796
4797 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4798
71873e2b
SM
47992012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4800
4801 * data.c (PUT_ERROR): New macro.
4802 (syms_of_data): Use it. Add new error type `user-error'.
4803 * undo.c (user_error): New function.
4804 (Fprimitive_undo): Use it.
4805 * print.c (print_error_message): Adjust print style for `user-error'.
4806 * keyboard.c (user_error): New function.
4807 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4808
ab0fa4e4
PE
48092012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4810
4811 Do not limit current-time-string to years 1000..9999.
4812 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4813 (Fcurrent_time_string): Support any year that is supported by the
4814 underlying localtime representation. Don't use asctime, as it
4815 has undefined behavior for years outside the range -999..9999.
4816
7ed806a7
PE
48172012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4818
4819 Fix race conditions involving setenv, gmtime, localtime, asctime.
4820 Without this fix, interrupts could mess up code that uses these
4821 nonreentrant functions, since setting TZ invalidates existing
4822 tm_zone or tzname values, and since most of these functions return
4823 pointers to static storage.
4824 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4825 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4826 Grow the critical sections to include not just invoking
4827 localtime/gmtime, but also accessing these functions' results
4828 including their tm_zone values if any, and any related TZ setting.
4829 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4830 so that the struct tm is saved in the critical section.
4831 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4832 motivated by the fact that memory allocation needs to be outside
4833 the critical section.
4834
0c16dfed
DA
48352012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4836
4837 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4838 with RESET_INTERVAL.
4839
4840 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4841 Remove duplicated buffer name initialization.
4842
3f83ace8
JM
48432012-05-02 Jim Meyering <jim@meyering.net>
4844
4845 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4846
c7b8541e
JM
4847 * xfns.c (x_window): Use xstrdup (Bug#11375).
4848
90207a15 48492012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4850
4851 * xdisp.c (pos_visible_p): If already at a newline from the
4852 display string before the 'while' loop, don't walk back the glyphs
4853 from it3.glyph_row. Solves assertion violation when the display
4854 string begins with a newline (egg.el). (Bug#11367)
4855
b593d6a9
AH
48562012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4857
4858 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4859 Move to simple.el.
4860
4737362e
GM
48612012-05-01 Glenn Morris <rgm@gnu.org>
4862
99cf43f9
GM
4863 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4864 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4865 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4866 All were removed before 23.1.
4867
9311dcff
GM
4868 * dispnew.c: Remove HAVE_LIBNCURSES test;
4869 it is always true on relevant platforms.
4870
4d5c6349
GM
4871 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4872 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4873
4737362e
GM
4874 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4875
74dd3a6b
AS
48762012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4877
4878 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4879 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4880 Remove.
4881
13c379ee
PE
48822012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4883
4884 Do not avoid creating empty evaporating overlays (Bug#9642).
4885 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4886 That is, do not delete an evaporating overlay if it becomes
4887 empty after its bounds are adjusted to fit within its buffer.
4888 This fix caused other problems, and I'm reverting it until we get
4889 to the bottom of them.
4890
a8e7d6d7 48912012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4892
4893 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4894
a8e7d6d7 48952012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4896
4897 * xdisp.c (pos_visible_p): If the window start position is beyond
4898 ZV, start the display from buffer beginning. Prevents assertion
4899 violation in init_iterator when the minibuffer window is scrolled
4900 via the scroll bar.
4901
4902 * window.c (window_scroll_pixel_based): Likewise.
4903
a8e7d6d7 49042012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4905
4906 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4907
a8e7d6d7 49082012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4909
4910 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4911 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4912
a8e7d6d7 49132012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4914
b593d6a9
AH
4915 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4916 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4917
1c6900d9
EZ
49182012-04-26 Eli Zaretskii <eliz@gnu.org>
4919
4c3fa1d9
EZ
4920 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4921 display element, check also the underlying string or buffer
4922 character. (Bug#11341)
4923
1c6900d9
EZ
4924 * w32menu.c: Include w32heap.h.
4925 (add_menu_item): If the call to AppendMenuW (via
4926 unicode_append_menu) fails, disable Unicode menus only if we are
4927 running on Windows 9X/Me.
4928
42bf8205
AS
49292012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4930
4931 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4932 (xgetint): Add missing shift for LSB tags.
4933
b1bac16e
MR
49342012-04-24 Martin Rudalics <rudalics@gmx.at>
4935
4936 * keyboard.c (read_char): Don't wipe echo area for select window
4937 events: These might get delayed via `mouse-autoselect-window'
4938 (Bug#11304).
4939
d69621cc
JB
49402012-04-24 Juanma Barranquero <lekktu@gmail.com>
4941
4942 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4943 manipulation of :loaded-from data.
4944
02fd101b
JB
49452012-04-23 Juanma Barranquero <lekktu@gmail.com>
4946
4947 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4948 now a cons (bug#11311).
4949
888bec30
PE
49502012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4951
89a438bd
PE
4952 Do not create empty overlays with the evaporate property (Bug#9642).
4953 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4954 if it becomes empty after its bounds are adjusted to fit within
4955 its buffer. Without this fix, in a nonempty buffer (let ((o
4956 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4957 yields an empty overlay that has the evaporate property, which is
4958 not supposed to happen.
4959
1068fe4d
PE
4960 Fix minor GTK3 problems found by static checking.
4961 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4962 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4963 (struct _EmacsFixedClass, emacs_fixed_get_type):
4964 Move decls here from emacsgtkfixed.h, since they needn't be public.
4965 (emacs_fixed_get_type): Now static.
4966 (emacs_fixed_class_init): Omit unused local.
4967 (emacs_fixed_child_type): Remove; unused.
4968 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4969 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4970 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4971 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4972 (EMACS_FIXED_GET_CLASS): Remove; unused.
4973 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4974
888bec30
PE
4975 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4976 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4977
de85e130
PE
49782012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4979
d0baac98 4980 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4981 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4982 (__malloc_size_t, __malloc_ptrdiff_t):
4983 Remove. All uses removed, replaced by the definiens if needed,
4984 since we can assume C89 or better now.
4985 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4986 (protect_malloc_state, align, get_contiguous_space)
4987 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4988 (malloc_atfork_handler_child, malloc_enable_thread)
4989 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4990 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4991 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4992 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4993 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4994 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4995 Define using prototypes, not old style.
4996 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4997 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4998 (align): Don't assume that signed integer overflow wraps around.
4999 Omit unused local var.
5000 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5001 (_free_internal_nolock, memalign, mallochook, reallochook):
5002 Omit no-longer-needed casts.
5003 (valloc): Use getpagesize, not __getpagesize.
5004 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5005 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5006
de85e130
PE
5007 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5008
dcbf5805
MA
50092012-04-22 Michael Albinus <michael.albinus@gmx.de>
5010
5011 Move functions from C to Lisp. Make non-blocking method calls
5012 the default. Implement further D-Bus standard interfaces.
5013
5014 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5015 (QCdbus_request_name_allow_replacement)
5016 (QCdbus_request_name_replace_existing)
5017 (QCdbus_request_name_do_not_queue)
5018 (QCdbus_request_name_reply_primary_owner)
5019 (QCdbus_request_name_reply_in_queue)
5020 (QCdbus_request_name_reply_exists)
5021 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5022 (QCdbus_registered_serial, QCdbus_registered_method)
5023 (QCdbus_registered_signal): New Lisp objects.
5024 (XD_DEBUG_MESSAGE): Use sizeof.
5025 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5026 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5027 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5028 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5029 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5030 (xd_signature, xd_append_arg): Allow float for integer types.
5031 (xd_get_connection_references): New function.
b593d6a9
AH
5032 (xd_get_connection_address): Rename from xd_initialize.
5033 Return cached address.
dcbf5805
MA
5034 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5035 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5036 level.
5037 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5038 Return number of refcounts.
dcbf5805
MA
5039 (Fdbus_get_unique_name): Make stronger parameter check.
5040 (Fdbus_message_internal): New defun.
5041 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5042 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5043 (Fdbus_send_signal, Fdbus_register_service)
5044 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5045 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5046 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5047 (Vdbus_compiled_version, Vdbus_runtime_version)
5048 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5049 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5050 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5051 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5052 Adapt docstring.
dcbf5805 5053
52828e02
PE
50542012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5055
da05bc4c
PE
5056 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5057 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5058 Do not assume ptrdiff_t is the same width as 'int'.
5059
52828e02
PE
5060 * alloc.c: Handle unusual debugging option combinations.
5061 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5062 since the two debugging options are incompatible.
5063 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5064 is defined.
5065 (mem_init, mem_insert, mem_insert_fixup):
5066 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5067 (NEED_MEM_INSERT): Remove; no longer needed.
5068
f01769f9
LL
50692012-04-22 Leo Liu <sdl.web@gmail.com>
5070
5071 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5072
5790543d
PE
50732012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5074
5075 * sysdep.c [__FreeBSD__]: Minor cleanups.
5076 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5077 Use Emacs indenting style more consistently. Avoid some casts.
5078 Use 'double' consistently rather than mixing 'float' and 'double'.
5079
b91b7e4d
EW
50802012-04-21 Eduard Wiebe <usenet@pusto.de>
5081
b593d6a9
AH
5082 * sysdep.c (list_system_processes, system_process_attributes):
5083 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5084
6114eb15
AS
50852012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5086
5087 * lisp.mk (lisp): Update.
5088
2f38dff7
PE
50892012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5090
5091 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5092 It is never used otherwise.
5093
4ae29f89
SM
50942012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5095
5096 * print.c (print_preprocess): Only check print_depth if print-circle
5097 is nil.
5098 (print_object): Check for cycles even when print-circle is nil and
5099 print-gensym is t, but only check print_depth if print-circle is nil.
5100
f30d612a
CY
51012012-04-20 Chong Yidong <cyd@gnu.org>
5102
5103 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5104 set the status to "failed" and ensure that sentinel is run.
5105
c07a4c0b 51062012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5107
5108 * process.c (Fset_process_inherit_coding_system_flag)
5109 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5110 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5111
c07a4c0b 51122012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5113
5114 * xdisp.c (string_buffer_position_lim): Limit starting position to
5115 BEGV.
5116 (set_cursor_from_row): If called for a mode-line or header-line
5117 row, return zero immediately.
5118 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5119 farther than the first row after the header line, if any.
5120 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5121 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5122
c07a4c0b 51232012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5124
4ae29f89
SM
5125 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5126 (bug#11238).
ad3a2b41 5127
c07a4c0b 51282012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 51292012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5130
5131 configure: new option --enable-gcc-warnings (Bug#11207)
5132 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5133 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5134 (ALL_CFLAGS): Use new macros rather than old.
5135 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5136 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5137 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5138 -Wunused-result, -Wunused-variable. This should go away once
5139 the Emacs and Gnulib regex code is merged.
5140 (xmalloc, xrealloc): Now static.
5141
aba027e8
PE
51422012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5143
5144 * dired.c (Fsystem_groups): Remove unused local.
5145
e5a36063
GM
51462012-04-17 Glenn Morris <rgm@gnu.org>
5147
5148 * dired.c (Fsystem_users): Doc fix.
5149
316411f0
DA
51502012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5151
5152 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5153 (syms_of_dired): Add them.
5154
9426aba4
PE
51552012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5156
b62a57be
PE
5157 Fix minor alloc.c problems found by static checking.
5158 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5159 New extern decls, to avoid calling undeclared functions.
5160 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5161 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5162 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5163 (NEED_MEM_INSERT): New macro.
5164 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5165 Remove one incorrect comment and fix another.
b62a57be 5166
3539f31f
PE
5167 Fix minor ralloc.c problems found by static checking.
5168 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5169 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5170 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5171 (r_alloc_sbrk): Now static.
5172
a041960a
PE
5173 Improve ralloc.c interface checking.
5174 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5175 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5176 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5177 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5178 [REL_ALLOC]: ... to here, to check interface.
5179 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5180 Remove decls. This fixes an "It stinks!".
5181
9426aba4
PE
5182 * alloc.c (which_symbols): Fix alignment issue / type clash.
5183
d55c12ed
AS
51842012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5185
5186 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5187 (struct Lisp_Misc_Any): Likewise.
5188 (struct Lisp_Free): Likewise.
5189 * alloc.c (union aligned_Lisp_Symbol): Define.
5190 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5191 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5192 (union aligned_Lisp_Misc): Define.
5193 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5194 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5195 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5196
b948ce8b
PE
51972012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5198
5199 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5200 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5201 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5202 * s/netbsd.h, s/sol2-6.h:
5203 Remove definition of GC_MARK_STACK, since the default now works.
5204 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5205 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5206 no longer the default.
5207 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5208
35dc09a1 52092012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5210
35dc09a1
GM
5211 * lread.c (lisp_file_lexically_bound_p):
5212 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5213
35dc09a1
GM
52142012-04-14 Eli Zaretskii <eliz@gnu.org>
5215
5216 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5217 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5218
52192012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5220
5221 * nsterm.m (constrainFrameRect): Always constrain when there is only
5222 one screen (Bug#10962).
5223
bcd86815
KB
52242012-04-13 Ken Brown <kbrown@cornell.edu>
5225
5226 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5227
c25df26e
RT
52282012-04-13 Reuben Thomas <rrt@sc3d.org>
5229
5230 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5231
0fc59f1e
DC
52322012-04-11 Daniel Colascione <dancol@dancol.org>
5233
5234 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5235 against is gone. It's better to use vfork now so that when Cygwin
5236 gains a new, working vfork, we use it automatically (bug#10398).
5237
de8c03dc
SM
52382012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5239
5240 * window.c (save_window_save): Obey window-point-insertion-type.
5241
2f097256
GM
52422012-04-11 Glenn Morris <rgm@gnu.org>
5243
5244 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5245
453b951e
SM
52462012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5247
5248 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5249
75f1671a 52502012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5251
5252 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5253 (force_quit_count): New var.
5254 (handle_interrupt): Use it.
5255
2a8ce227
JB
52562012-04-10 Juanma Barranquero <lekktu@gmail.com>
5257
5258 * w32.c (w32_delayed_load): Record the full path of the library
5259 being loaded (bug#10424).
5260
935396c0
GM
52612012-04-09 Glenn Morris <rgm@gnu.org>
5262
05920a43
GM
5263 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5264 not just in the obarray, before snarfing them. (Bug#11036)
5265
935396c0
GM
5266 * Makefile.in ($(leimdir)/leim-list.el):
5267 Pass EMACS rather than BUILT_EMACS.
5268
a18ecafa
TZ
52692012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5270
5271 * process.c (make_process):
5272 * process.h: Add integer `gnutls_handshakes_tried' member to
5273 process struct.
5274
6bbef4e5
JC
5275 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5276 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5277
5278 * gnutls.c (gnutls_log_function2i): Convenience log function.
5279 (emacs_gnutls_read): Use new log functions,
5280 `gnutls_handshakes_tried' process member, and
5281 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5282 attempts per process (connection).
5283
b4d3bc10
CY
52842012-04-09 Chong Yidong <cyd@gnu.org>
5285
5286 * eval.c (Fuser_variable_p, user_variable_p_eh)
5287 (lisp_indirect_variable): Functions deleted.
5288 (Fdefvar): Caller changed.
5289
5290 * callint.c (Finteractive, Fcall_interactively):
5291 * minibuf.c (Fread_variable): Callers changed.
5292
70f4d973
EZ
52932012-04-09 Eli Zaretskii <eliz@gnu.org>
5294
5295 * xdisp.c (set_cursor_from_row): If the display string appears in
5296 the buffer at position that is closer to point than the position
5297 after the display string, display the cursor on the first glyph of
5298 the display string. Fixes cursor display when a 'display' text
5299 property immediately follows invisible text. (Bug#11094)
5300
cb3c2e3e
PE
53012012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5302
5303 composite.c: use 'double' consistently
5304 * composite.c (get_composition_id): Use 'double' consistently
5305 instead of converting 'float' to 'double' and vice versa; this is
5306 easier to understand and avoids a GCC warning.
5307
fd06db5d
GM
53082012-04-09 Glenn Morris <rgm@gnu.org>
5309
50fe702a
GM
5310 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5311 preparation for dumping it with emacs. (Bug#4789)
5312 (leimdir): New variable.
5313 ($(leimdir)/leim-list.el): New rule.
5314 (emacs$(EXEEXT)): Depend on leim-list.el.
5315
fd06db5d
GM
5316 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5317 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5318 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5319
55c131ee
AS
53202012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5321
5322 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5323 proper alignment.
5324
9209588f
JB
53252012-04-07 Juanma Barranquero <lekktu@gmail.com>
5326
5327 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5328 Remove unused local variable.
5329
e3fb2efb
PE
53302012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5331
5332 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5333 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5334 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5335 objects, as mark_maybe_pointer will catch them otherwise.
5336 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5337 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5338
b5385551
PE
53392012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5340
5341 Fix typo that broke non-Windows builds.
5342 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5343
9078ead6
EZ
53442012-04-07 Eli Zaretskii <eliz@gnu.org>
5345
5346 Support building on MS-Windows with libxml2.
5347
5348 * makefile.w32-in (OBJ2): Add xml.$(O).
5349 (GLOBAL_SOURCES): Add xml.c.
5350 ($(BLD)/xml.$(O)): New dependency list.
5351
5352 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5353 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5354 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5355 [!WINDOWSNT]: New macros.
5356 (init_libxml2_functions, libxml2_loaded_p): New functions.
5357 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5358 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5359 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5360 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5361 linked in).
6bbef4e5
JC
5362 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5363 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5364 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5365
5366 * emacs.c: Don't include libxml/parser.h.
5367 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5368 xmlCleanupParser directly.
5369
5370 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5371
3811fdf3
EZ
53722012-04-07 Eli Zaretskii <eliz@gnu.org>
5373
5374 * indent.c (Fvertical_motion): If there is a display string at
5375 point, use it.vpos to compute how many lines to backtrack after
5376 move_it_to point. (Bug#11133)
5377
2f8e16b2
EZ
53782012-04-06 Eli Zaretskii <eliz@gnu.org>
5379
5380 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5381 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5382 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5383 macros related to unification of CJK characters. For the details,
5384 see the discussion following the message here:
5385 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5386
3d439cd1
CY
53872012-04-04 Chong Yidong <cyd@gnu.org>
5388
5389 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5390
8bc53d00
EZ
53912012-04-01 Eli Zaretskii <eliz@gnu.org>
5392
5393 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5394 instead of alloca. (Bug#11138)
5395
3b0512a3
AS
53962012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5397
5398 * w32menu.c (is_simple_dialog): Properly check lisp types.
5399 (Bug#11141)
5400
8427ddd2
EZ
54012012-03-31 Eli Zaretskii <eliz@gnu.org>
5402
979022ef
EZ
5403 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5404 position we get to after a call to move_it_to fails the
5405 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5406 only if we wind up in a string from display property. (Bug#11063)
5407
a6b1c7cc
EZ
5408 * window.c (Fdelete_other_windows_internal): Invalidate the row
5409 and column information about mouse highlight, so that redisplay
5410 restores it after reallocating the glyph matrices. (Bug#7464)
5411
8427ddd2
EZ
5412 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5413 string comes from a `display' text property, use the buffer
5414 position of that property as if we actually saw that position in
5415 the row's glyphs.
697ba24b
EZ
5416 (move_it_by_lines): Remove the assertion that
5417 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5418 violated when there's a before-string at the beginning of a line.
5419 (Bug#11063)
8427ddd2 5420
65a0a738
EZ
54212012-03-30 Eli Zaretskii <eliz@gnu.org>
5422
5423 * xdisp.c (append_space_for_newline): If the default face was
5424 remapped, use the remapped face for the appended newline.
5425 (extend_face_to_end_of_line): Use the remapped default face for
5426 extending the face to the end of the line.
5427 (display_line): Call extend_face_to_end_of_line when the default
5428 face was remapped. (Bug#11068)
5429
581355cc
EZ
54302012-03-29 Eli Zaretskii <eliz@gnu.org>
5431
5432 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5433
e8fc049f
SM
54342012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5435
5436 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5437
4fb9a543
GM
54382012-03-27 Glenn Morris <rgm@gnu.org>
5439
5440 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5441 Doc fixes.
5442
679910f1
KH
54432012-03-26 Kenichi Handa <handa@m17n.org>
5444
5445 * dispextern.h (struct glyph): Fix previous change. Change the
5446 bit length of glyphless.ch to 25 (Bug#11082).
5447
90d49b7f
CY
54482012-03-26 Chong Yidong <cyd@gnu.org>
5449
5450 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5451 (command_loop_1): Use it; inhibit selection update for
5452 handle-select-window too (Bug#8996).
5453
f514f6f0
FP
54542012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5455
e8fc049f 5456 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5457
bf43fa51
KH
54582012-03-25 Kenichi Handa <handa@m17n.org>
5459
5460 * dispextern.h (struct glyph): Change the bit length of
5461 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5462
8a0c01dd
EZ
54632012-03-24 Eli Zaretskii <eliz@gnu.org>
5464
5465 * s/ms-w32.h (tzname): Include time.h before redirecting to
5466 _tzname. Fixes the MSVC build. (Bug#9960)
5467
7d1c3a76
AS
54682012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5469
8ed79523
AS
5470 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5471 characters.
5472
7d1c3a76
AS
5473 * xterm.c (XTread_socket): Only modify handling_signal if
5474 !SYNC_INPUT. (Bug#11080)
5475
e99a9b8b
EZ
54762012-03-23 Eli Zaretskii <eliz@gnu.org>
5477
5478 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5479 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5480 when fetching a multibyte character consumes more bytes than
5481 CHAR_BYTES returns, due to unification of CJK characters in
5482 string_char. (Bug#11073)
5483
5063c0e1
TN
54842012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5485
5486 * process.c (wait_reading_process_output): Handle pty disconnect
5487 by refraining from sending oneself a SIGCHLD (bug#10933).
5488
9f851fbd
CY
54892012-03-22 Chong Yidong <cyd@gnu.org>
5490
5491 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5492
5063c0e1 5493 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5494 Mark string as coming from a prefix property.
5495 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5496 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5497
fb5b8aca
CY
54982012-03-21 Chong Yidong <cyd@gnu.org>
5499
5500 * xfaces.c (Vface_remapping_alist): Doc fix.
5501
62356a1b
EZ
55022012-03-20 Eli Zaretskii <eliz@gnu.org>
5503
5504 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5505 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5506 Doc fixes.
62356a1b 5507
025de85b
CY
55082012-03-20 Chong Yidong <cyd@gnu.org>
5509
5510 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5511 to reflect default non-nil value of redisplay-dont-pause.
5512
4827f94e
KH
55132012-03-19 Kenichi Handa <handa@m17n.org>
5514
5515 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5516 it fit in a valid range (Bug#11003).
5517
e50a24a2
EZ
55182012-03-18 Eli Zaretskii <eliz@gnu.org>
5519
5520 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5521 that is not from display property, accept the row as a "cursor
5522 row" if one of the string's character has a non-nil `cursor'
5523 property. Fixes cursor positioning when there are newlines in
5524 overlay strings, e.g. in icomplete.el. (Bug#11035)
5525
9af5ed87
PE
55262012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5527
5528 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5529
d1f55f16
CY
55302012-03-12 Chong Yidong <cyd@gnu.org>
5531
5532 * eval.c (inhibit_lisp_code): Rename from
5533 inhibit_window_configuration_change_hook; move from window.c.
5534
5535 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5536 * window.c (run_window_configuration_change_hook)
5537 (syms_of_window): Callers changed.
5538
66c5eebd
CY
55392012-03-11 Chong Yidong <cyd@gnu.org>
5540
413df973
CY
5541 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5542
66c5eebd
CY
5543 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5544
1de11f56
CY
55452012-03-10 Chong Yidong <cyd@gnu.org>
5546
5547 * frame.c (other_visible_frames): Don't assume the selected frame
5548 is visible (Bug#10955).
5549
cae07000
SM
55502012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5551
5552 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5553
89c94350
JD
55542012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5555
5556 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5557 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5558 zero (Bug#10954).
5559
999dd333
GM
55602012-03-03 Glenn Morris <rgm@gnu.org>
5561
01a6dcc8 5562 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5563
de0100f2
EZ
55642012-03-02 Eli Zaretskii <eliz@gnu.org>
5565
5566 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5567 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5568 (redisplay_window, next_element_from_string): Fix typos in
5569 comments.
3e441275
EZ
5570 (redisplay_window): Pass to move_it_vertically the margin in
5571 pixels, not in screen lines.
de0100f2 5572
96a72ee9
GM
55732012-03-02 Glenn Morris <rgm@gnu.org>
5574
5575 * buffer.c (buffer-list-update-hook): Doc fix.
5576
312508d7
EZ
55772012-02-29 Eli Zaretskii <eliz@gnu.org>
5578
5579 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5580 push_it before setting up the iterator for the first overlay
5581 string, even if we have an empty string loaded.
5582 (next_overlay_string): If there's an empty string on the iterator
5583 stack, pop the stack. (Bug#10903)
5584
27f3c637
PE
55852012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5586
5587 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5588 Suggested by Stefan Monnier in
5589 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5590 * alloc.c (widen_to_Lisp_Object): New static function.
5591 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5592 and widening them to Lisp_Objects. This would work even if
5593 USE_LSB_TAG is defined and wide integers are used, which might
5594 happen in a future version of Emacs.
5595
3c9dfce6
CY
55962012-02-25 Chong Yidong <cyd@gnu.org>
5597
fa74b241
CY
5598 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5599 Doc fix.
5600
3c9dfce6
CY
5601 * xselect.c (Fx_selection_exists_p): Doc fix.
5602 (x_clipboard_manager_save_all): Print an informative message
5603 before saving to clipboard manager.
5604
9486df08
CY
56052012-02-24 Chong Yidong <cyd@gnu.org>
5606
5607 * keyboard.c (process_special_events): Handle all X selection
5608 requests in kbd_buffer, not just the next one (Bug#8869).
5609
f01d3321
CY
56102012-02-23 Chong Yidong <cyd@gnu.org>
5611
5612 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5613 call when setting menu-bar-lines and tool-bar-lines parameters.
5614 (unwind_create_frame_1): New helper function.
5615
5616 * window.c (inhibit_window_configuration_change_hook): New var.
5617 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5618 (syms_of_window): Initialize it.
f01d3321 5619
86b847b6
CY
56202012-02-22 Chong Yidong <cyd@gnu.org>
5621
5622 * xterm.c (x_draw_image_relief): Add missing type check for
5623 Vtool_bar_button_margin (Bug#10743).
5624
a59225b1
CY
56252012-02-21 Chong Yidong <cyd@gnu.org>
5626
5627 * fileio.c (Vfile_name_handler_alist): Doc fix.
5628
5629 * buffer.c (Fget_file_buffer): Protect against invalid file
5630 handler return value.
5631
310f5bd4
PE
56322012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5633
cb3a28cc
PE
5634 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5635 when computing $valmask.
5636
310f5bd4
PE
5637 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5638 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5639 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5640 It's useless in that case, and it can cause problems on hosts
5641 that allocate halves of EMACS_INT values separately.
5642 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5643 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5644 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5645 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5646 it avoids undefined behavior on hosts where shifting right by more
5647 than the word width has undefined behavior.
5648
2375c96a
CY
56492012-02-19 Chong Yidong <cyd@gnu.org>
5650
5651 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5652 (Funhandled_file_name_directory, Ffile_name_as_directory)
5653 (Fdirectory_file_name, Fexpand_file_name)
5654 (Fsubstitute_in_file_name): Protect against invalid file handler
5655 return values (Bug#10845).
5656
3eb49e71
EZ
56572012-02-18 Eli Zaretskii <eliz@gnu.org>
5658
5659 * .gdbinit (pitx): Fix incorrect references to fields of the
5660 iterator stack.
5661
7b926f3f
CY
56622012-02-17 Chong Yidong <cyd@gnu.org>
5663
5664 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5665
11273115
PE
56662012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5667
5668 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5669 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5670
c3a70e2b
CY
56712012-02-15 Chong Yidong <cyd@gnu.org>
5672
5673 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5674 marked as special. Also, starting docstrings with * is obsolete.
5675
0ca43699
AS
56762012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5677
5678 * gnutls.c (emacs_gnutls_write): Fix last change.
5679
2e8f3c56
LI
56802012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5681
5682 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5683 send_process.
5684
af70074f
SM
56852012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5686
5687 * keymap.c (Fsingle_key_description): Handle char ranges.
5688
95986d52
CY
56892012-02-12 Chong Yidong <cyd@gnu.org>
5690
afd83bd1
CY
5691 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5692 as that creates a dangerous corner case.
5693
95986d52
CY
5694 * window.c (Fdelete_window_internal): Invalidate the mouse
5695 highlight (Bug#9904).
5696
bd7da63e
GM
56972012-02-12 Glenn Morris <rgm@gnu.org>
5698
5699 * xselect.c (Fx_own_selection_internal)
5700 (Fx_get_selection_internal, Fx_disown_selection_internal)
5701 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5702 * nsselect.m (Fx_own_selection_internal)
5703 (Fx_disown_selection_internal, Fx_selection_exists_p)
5704 (Fx_selection_owner_p, Fx_get_selection_internal):
5705 Sync docs and argument specs with the xselect.c versions.
5706
77abcbc2
LI
57072012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5708
5709 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5710
90b671e2
EZ
57112012-02-11 Eli Zaretskii <eliz@gnu.org>
5712
1c0ca0b7
EZ
5713 * w32select.c (Fx_selection_exists_p): Sync doc string and
5714 argument list with xselect.c. (Bug#10783)
5715
5716 * w16select.c (Fx_selection_exists_p): Sync doc string and
5717 argument list with xselect.c. (Bug#10783)
90b671e2 5718
49241268
GM
57192012-02-10 Glenn Morris <rgm@gnu.org>
5720
5721 * fns.c (Fsecure_hash): Doc fix.
5722
f998bbe7 57232012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5724
5725 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5726
0992bd9c
CY
57272012-02-07 Chong Yidong <cyd@gnu.org>
5728
5729 * buffer.c (Fbuffer_local_variables)
5730 (buffer_lisp_local_variables): Handle unbound vars correctly;
5731 don't let Qunbound leak into Lisp.
5732
af008560
GM
57332012-02-07 Glenn Morris <rgm@gnu.org>
5734
dd605cc4
GM
5735 * image.c (Fimagemagick_types): Doc fix.
5736
af008560
GM
5737 * image.c (imagemagick-render-type): Change it from a lisp object
5738 to an integer. Move the doc here from the lisp manual.
5739 Treat all values not equal to 0 the same.
5740
1449fa1d
CY
57412012-02-06 Chong Yidong <cyd@gnu.org>
5742
5743 * doc.c (store_function_docstring): Avoid applying docstring of
5744 alias to base function (Bug#2603).
5745
3723ec07
AS
57462012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5747
5748 * .gdbinit (pp1, pv1): Remove redundant defines.
5749 (pr): Use pp.
5750
79c1cc1e
CY
57512012-02-04 Chong Yidong <cyd@gnu.org>
5752
5753 * nsterm.m: Declare a global (Bug#10694).
5754
d7f29f8e
EZ
57552012-02-04 Eli Zaretskii <eliz@gnu.org>
5756
cae07000
SM
5757 * w32.c (get_emacs_configuration_options):
5758 Include --enable-checking, if specified, in the return value.
d7f29f8e 5759
3b95a6f9
MR
57602012-02-04 Martin Rudalics <rudalics@gmx.at>
5761
5762 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5763 after rounding frame sizes. (Bug#9723)
5764
d6fa96a6
EZ
57652012-02-04 Eli Zaretskii <eliz@gnu.org>
5766
5767 * keyboard.c (adjust_point_for_property): Don't position point
5768 before BEGV. (Bug#10696)
5769
df0b2940
PE
57702012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5771
5772 Handle overflow when computing char display width (Bug#9496).
5773 * character.c (char_width): Return EMACS_INT, not int.
5774 (char_width, c_string_width): Check for overflow when
5775 computing the width; this is possible now that individual
5776 characters can have unbounded width. Problem introduced
5777 by merge from Emacs 23 on 2012-01-19.
5778
6bee44d6
MA
57792012-02-02 Michael Albinus <michael.albinus@gmx.de>
5780
5781 * dbusbind.c (Fdbus_register_method): Mention the return value
5782 :ignore in the docstring.
5783
44f92739
GM
57842012-02-02 Glenn Morris <rgm@gnu.org>
5785
1b9f60cc
GM
5786 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5787
44f92739
GM
5788 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5789 Unconditionally set to t. (Bug#10673)
5790 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5791 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5792 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5793
c5d3843c
KH
57942012-02-02 Kenichi Handa <handa@m17n.org>
5795
5796 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5797 0, do not call append_composite_glyph.
5798
159462d4 57992012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5800
5801 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5802 NULL (Bug#6988).
5803 (x_produce_glyphs): If the component of a composition is a null
5804 string, set it->pixel_width to 1 to avoid zero-width glyph.
5805
78cef877
EZ
58062012-02-01 Eli Zaretskii <eliz@gnu.org>
5807
5808 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5809 first 2 arguments are identical. This makes inserting large
5810 output from a subprocess an order of magnitude faster on
5811 MS-Windows, where all sbrk'ed memory is always contiguous.
5812
97897668
GM
58132012-01-31 Glenn Morris <rgm@gnu.org>
5814
5815 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5816 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5817 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5818
31fd3586
GM
58192012-01-29 Glenn Morris <rgm@gnu.org>
5820
5821 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5822
0e24a8b2
CY
58232012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5824
5825 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5826
cc0adcb0
CY
58272012-01-28 Chong Yidong <cyd@gnu.org>
5828
5829 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5830
acc28cb9
CY
58312012-01-26 Chong Yidong <cyd@gnu.org>
5832
9c69cfb7
CY
5833 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5834
acc28cb9
CY
5835 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5836 repeat counts (Bug#10507).
5837
48da7392
GM
58382012-01-26 Glenn Morris <rgm@gnu.org>
5839
5840 * lread.c (syms_of_lread): Doc fix.
5841
14af5f7f
CY
58422012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5843
5844 * coding.c (encode_designation_at_bol): Change return value to
5845 EMACS_INT.
5846
0b21c100
CY
58472012-01-25 Chong Yidong <cyd@gnu.org>
5848
5849 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5850
3c2907f7
CY
58512012-01-21 Chong Yidong <cyd@gnu.org>
5852
5853 * floatfns.c (Fcopysign): Make the second argument non-optional,
5854 since nil is not allowed anyway.
5855
959ad23f
AS
58562012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5857
5858 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5859 (send_process): Likewise.
5860
34a02f46
MR
58612012-01-19 Martin Rudalics <rudalics@gmx.at>
5862
5863 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5864 (Vwindow_persistent_parameters): Do not use Qstate.
5865 Rewrite doc-strings.
34a02f46 5866
1259009a 58672012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5868
5869 * character.c (char_width): New function.
70d4fdf6
GM
5870 (Fchar_width, c_string_width, lisp_string_width):
5871 Use char_width (Bug#9496).
25ed9e61 5872
6a6ee00d
MR
58732012-01-16 Martin Rudalics <rudalics@gmx.at>
5874
5875 * window.c (Vwindow_persistent_parameters): New variable.
5876 (Fset_window_configuration, save_window_save): Handle persistent
5877 window parameters.
5878
c85efaf7
EZ
58792012-01-14 Eli Zaretskii <eliz@gnu.org>
5880
5881 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5882 thrashing the stack of the thread. (Bug#9087)
5883
5944709e
PE
58842012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5885
5886 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5887
e71f5d99
EZ
58882012-01-11 Eli Zaretskii <eliz@gnu.org>
5889
5890 * xdisp.c (rows_from_pos_range): Handle the case where the
5891 highlight ends on a newline. (Bug#10464)
5892 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5893 he end column for display of highlight that ends on a newline
5894 before a R2L line.
5895
ce316182
GM
58962012-01-11 Glenn Morris <rgm@gnu.org>
5897
5898 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5899 from load-path also when installation-directory is nil. (Bug#10208)
5900
5b43da69
GM
59012012-01-10 Glenn Morris <rgm@gnu.org>
5902
74cc8ff9
GM
5903 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5904
7d8d6e4e
GM
5905 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5906 Update template values to be closer to their typical values these days.
5b43da69 5907
a0db8d43
EZ
59082012-01-09 Eli Zaretskii <eliz@gnu.org>
5909
5910 * xdisp.c (rows_from_pos_range): Accept additional argument
5911 DISP_STRING, and accept any glyph in a row whose object is that
5912 string as eligible for mouse highlight. Fixes mouse highlight of
5913 display strings from overlays. (Bug#10464)
5914
9a0115ab 59152012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5916
b9110d6a 5917 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5918 * fileio.c (auto_saving_dir_umask): New static var.
5919 (Fmake_directory_internal): Use it.
5920 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5921 creating the directory. The old code temporarily assigns
5922 too-generous permissions to the directory.
5923 (do_auto_save_eh): Clear it.
b9110d6a 5924 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5925 that the var is always cleared.
5926
6c1bd3f3
EZ
59272012-01-07 Eli Zaretskii <eliz@gnu.org>
5928
5929 * search.c (scan_buffer): Pass character positions to
5930 know_region_cache, not byte positions. (Bug#6540)
5931
069d2b50
L
59322012-01-07 LynX <_LynX@bk.ru> (tiny change)
5933
5934 * w32.c (sys_rename): Report EXDEV when rename of a directory
5935 fails because the target is on another logical disk. (Bug#10284)
5936
75bf0d33
DB
59372012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5938
5939 * xterm.c (x_embed_request_focus): New function.
5940
5941 * xterm.h: Add prototype.
5942
5943 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5944
1c6e5a32
GM
59452012-01-05 Glenn Morris <rgm@gnu.org>
5946
5947 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5948
651e947e
EZ
59492012-01-01 Eli Zaretskii <eliz@gnu.org>
5950
5951 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5952 Load gnutls_transport_set_lowat only if GnuTLS version is below
5953 2.11.1.
5954 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5955 GnuTLS versions below 2.11.1.
5956
3778cdd8
AL
59572011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5958
5959 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5960 to the doc string advising against its use for altering the way
5961 windows are scrolled.
5962
0e5317f7
KH
59632011-12-28 Kenichi Handa <handa@m17n.org>
5964
5965 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5966 coding-system ASCII compatible only when it does not produce BOM
5967 on encoding (Bug#10383).
5968
93d5ca1f
JD
59692011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5970
5971 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5972 can scroll.
5973 (create_and_show_popup_menu): Always use menu_position_func for
5974 Gtk3 (Bug#10361).
5975
ca22b785
AS
59762011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5977
5978 * callint.c (Fcall_interactively): Don't truncate prompt string.
5979
d048e1e6
EZ
59802011-12-23 Eli Zaretskii <eliz@gnu.org>
5981
5982 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5983 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5984 resumed from there (after widening). (Bug#10360)
d048e1e6 5985
5ccaba1f
JD
59862011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5987
5988 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5989
204ee57f
JD
59902011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5991
b81d40f0
JB
5992 * nsterm.m (x_free_frame_resources):
5993 Release f->output_data.ns->miniimage.
204ee57f
JD
5994 (ns_index_color): Fix indentation. Do not retain
5995 color_table->colors[i].
5996
5997 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5998 before returning.
5999
6000 * nsfns.m (x_set_background_color): Assign return value from
6001 ns_index_color to face-background instead of NSColor*.
6002 (ns_implicitly_set_icon_type): Fix indentation.
6003 Change assignment in for loop to comparison.
6004
6005 * emacs.c (ns_pool): New variable.
6006 (main): Assign ns_pool.
6007 (Fkill_emacs): Call ns_release_autorelease_pool.
6008
6009 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6010 autorelease fdesc, release fdAttrs and tdict.
6011 (ns_get_covering_families): Release charset.
6012 (ns_findfonts): Release NSFontDescriptor created with new.
6013 (ns_uni_to_glyphs): Fix indentation.
6014 (setString): Release attrStr before assigning new value.
6015
c803b2b7
JD
60162011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6017
678f4426
JD
6018 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6019 and NS_IMPL_COCOA.
6020 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6021 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6022
cd394be1 60232011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6024
5fecd5fc
JD
6025 * nsterm.m (ns_term_init): Subscribe for notifications
6026 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6027 to method trackingNotification in EmacsMenu.
6028
6029 * nsmenu.m (trackingMenu): New variable.
3771cb17 6030 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6031 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6032 from Aquamacs (Bug#7030).
678f4426
JD
6033
60342011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6035
c803b2b7
JD
6036 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6037 (symbol_to_nsstring): Fix indentation.
6038 (ns_symbol_to_pb): New function.
cae07000
SM
6039 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6040 (Fns_rotate_cut_buffers_internal): Remove.
6041 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6042 Fns_store_cut_buffer_internal.
6043 (ns_get_foreign_selection, Fx_own_selection_internal)
6044 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6045 (Fns_get_selection_internal, Fns_store_selection_internal):
6046 Use ns_symbol_to_pb and check if return value is nil.
6047 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6048 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6049 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6050 renamed to Sns_store_selection_internal.
6051 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6052 and remove this function.
6053 (ns_handle_selection_clear): Remove, never used.
6054 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6055 here.
6056
e1b01a3a
KB
60572011-12-17 Ken Brown <kbrown@cornell.edu>
6058
6059 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6060 GID is unknown (Bug#10257).
6061
2adb6e85
PE
60622011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6063
6064 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6065 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6066 which caused a build failure on GNU/Linux IA-64. This problem was
6067 introduced by my 2011-10-07 patch.
6068
d1d7b339
JL
60692011-12-15 Juri Linkov <juri@jurta.org>
6070
6071 * image.c (imagemagick_error): New function. (Bug#10112)
6072 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6073 Use `imagemagick_error' where ImageMagick functions return
6074 `MagickFalse'.
6075 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6076 proper order.
6077
100d5755
KH
60782011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6079
6080 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6081 fill background (Bug#8992).
6082
454592a6
MR
60832011-12-13 Martin Rudalics <rudalics@gmx.at>
6084
6085 * window.c (Vwindow_combination_resize)
6086 (Vwindow_combination_limit): Use t instead of non-nil in
6087 doc-strings.
61d4b438
MR
6088 (Vrecenter_redisplay): Add first sentence of doc-string on
6089 separate line.
53524d93 6090 (Frecenter): Fix doc-string typo.
454592a6 6091
3633e3aa
KH
60922011-12-11 Kenichi Handa <handa@m17n.org>
6093
6094 * coding.c (Funencodable_char_position): Pay attention to the
6095 buffer text relocation (Bug#9389).
6096
7b9d523a 60972011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6098
7b9d523a
JD
6099 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6100 gtk_init (Bug#10100).
6101
b73189c6
EZ
61022011-12-10 Eli Zaretskii <eliz@gnu.org>
6103
6104 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6105 IT->string is nil. (Bug#10263)
6106
f7dfe5d6
JD
61072011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6108
83faebb4
JD
6109 * nsterm.h (x_free_frame_resources): Declare.
6110
f7dfe5d6
JD
6111 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6112 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6113
6114 * nsterm.h (ns_get_defaults_value): Declare.
6115
6116 * nsterm.m (ns_default): Call ns_get_defaults_value.
6117
7cd4e72c
EZ
61182011-12-09 Eli Zaretskii <eliz@gnu.org>
6119
6120 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6121 (Bug#10170)
6122
b34d7317
YM
61232011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6124
6125 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6126 that where the value of an _OBJC_* symbol points to is in the .bss
6127 section (Bug#10240).
6128
76470ad1
KH
61292011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6130
6131 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6132 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6133
745fff94
KH
61342011-12-08 Kenichi Handa <handa@m17n.org>
6135
6136 * ftfont.c (get_adstyle_property): Fix previous change
6137 (Bug#10233).
6138
6e44397c
JB
61392011-12-07 Juanma Barranquero <lekktu@gmail.com>
6140
6141 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6142 dirs from the default value of EMACSLOADPATH (bug#10208).
6143
7efa6272
GM
61442011-12-07 Glenn Morris <rgm@gnu.org>
6145
6146 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6147 installation and source directories as well. (Bug#10208)
6148
f6fc4d87
CY
61492011-12-06 Chong Yidong <cyd@gnu.org>
6150
6151 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6152
2bf26180
GM
61532011-12-06 Glenn Morris <rgm@gnu.org>
6154
6155 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6156 as an error, not just -1. (Bug#10217)
6157
3a6ad4f0
CY
61582011-12-05 Chong Yidong <cyd@gnu.org>
6159
6160 * keyboard.c (process_special_events): New function.
6161 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6162
75a3b399
PE
61632011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6164
6165 * coding.c (encode_designation_at_bol): Don't use uninitialized
6166 local variable (Bug#9318).
6167
c3c9e25e
KH
61682011-12-05 Kenichi Handa <handa@m17n.org>
6169
6170 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6171 return Qnil (Bug#8046, Bug#10193).
6172
5eb05ea3
KH
61732011-12-05 Kenichi Handa <handa@m17n.org>
6174
6175 * coding.c (encode_designation_at_bol): New args charbuf_end and
6176 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6177 (coding_set_source): Return how many bytes coding->source was
6178 relocated.
6179 (coding_set_destination): Return how many bytes
6180 coding->destination was relocated.
6181 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6182 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6183
61842011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6185
6186 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6187 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6188 macro (Bug#9318).
6189
61902011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6191
6192 The following changes are to fix Bug#9318.
6193
a79703f5 6194 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6195 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6196 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6197 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6198
7dbda6df
JB
61992011-12-05 Juanma Barranquero <lekktu@gmail.com>
6200
6201 * lisp.h (process_quit_flag): Fix external declaration.
6202
6d5eb5b0
SM
62032011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6204
6205 Don't macro-inline non-performance-critical code.
6206 * eval.c (process_quit_flag): New function.
6207 * lisp.h (QUIT): Use it.
6208
a0c3fad0
JD
62092011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6210
6211 * nsfns.m (get_geometry_from_preferences): New function.
6212 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6213
6c07aac2
AS
62142011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6215
6216 * emacs.c (Qkill_emacs): Define.
6217 (syms_of_emacs): Initialize it.
6218 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6219 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6220 (quit_throw_to_read_char): Add parameter `from_signal'.
6221 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6222 * lisp.h (QUIT): Call Fkill_emacs if requested.
6223
c052ead4
JD
62242011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6225
6226 * widget.c (update_wm_hints): Return if wmshell is null.
6227 (widget_update_wm_size_hints): New function.
6228
6229 * widget.h (widget_update_wm_size_hints): Declare.
6230
6231 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6232 widget_update_wm_size_hints (Bug#10104).
6233
9e49252b
EZ
62342011-12-03 Eli Zaretskii <eliz@gnu.org>
6235
6236 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6237 before a newline, prepare the bidi iterator for consuming the
6238 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6239 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6240
02b16839
JL
62412011-12-02 Juri Linkov <juri@jurta.org>
6242
6243 * search.c (Fword_search_regexp): New Lisp function created from
6244 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6245 (Fword_search_backward, Fword_search_forward)
6246 (Fword_search_backward_lax, Fword_search_forward_lax):
6247 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6248 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6249
0068070e
SM
62502011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6251
6252 * fileio.c (Finsert_file_contents): Move after-change-function call
6253 to before the "handled:" label, since all "goto handled" appear in
6254 cases where the *-change-functions have already been properly called
6255 (bug#10117).
6256
3360a3fc
AS
62572011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6258
6259 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6260 waiting for input. (Bug#10169)
6261
73d6c093
EZ
62622011-11-30 Eli Zaretskii <eliz@gnu.org>
6263
6264 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6265 verifies glyph row's hash code--we have just reallocated the
6266 glyphs, so their contents can be complete garbage. (Bug#10164)
6267
febe6bea
JB
62682011-11-30 Juanma Barranquero <lekktu@gmail.com>
6269
6270 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6271
801a4313
EZ
62722011-11-30 Eli Zaretskii <eliz@gnu.org>
6273
6274 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6275 attributes are tested _before_ calling verify_row_hash, to protect
6276 against GCC re-ordering of the tests. (Bug#10164)
6277
2b56b87e
JD
62782011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6279
6280 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6281
6282 * xterm.c (handle_one_xevent): Only set async_visible and friends
6283 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6284 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6285 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6286
dbf31225
PE
62872011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6288
6289 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6290 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6291 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6292 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6293 All uses changed to use GCPRO1 etc.
6294 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6295 Revert to old implementation (i.e., before 2011-03-11).
6296
1305621b
YM
62972011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6298
6299 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6300 of scroll runs so as to avoid assigning disabled bogus rows and
6301 unnecessary graphics copy operations.
6302
8c9afb46
EZ
63032011-11-27 Eli Zaretskii <eliz@gnu.org>
6304
6305 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6306 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6307 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6308 (malloc, free, realloc, calloc): Redirect to e_* only when
6309 compiling Emacs.
6310
6311 * lisp.h (GCTYPEBITS): Move before first use.
6312 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6313 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6314 this macro definition.
6315
6316 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6317 _MSC_VER.
6318
54e9e3bf
JD
63192011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6320
6d5eb5b0
SM
6321 * gtkutil.c (xg_create_frame_widgets):
6322 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6323 present with Gtk+ 2.0.
6324
83aca1cb
PE
63252011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6326
6327 * fileio.c (Finsert_file_contents): Undo previous change; see
6328 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6329
5b76caa4
PE
63302011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6331
6332 Rename locals to avoid shadowing.
6333 * fileio.c (Finsert_file_contents):
6334 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6335 * process.c (wait_reading_process_output):
6336 Rename inner 'proc' to 'p' to avoid shadowing.
6337 Indent for consistency with usual Emacs style.
6338
8c535114
EZ
63392011-11-25 Eli Zaretskii <eliz@gnu.org>
6340
6341 * xdisp.c (redisplay_window): If cursor row is not fully visible
6342 after recentering, and scroll-conservatively is set to a large
6343 number, scroll window by a few more lines to make the cursor fully
6344 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6345 (start_display): Don't move to the next line if the display should
6346 start at a newline that is part of a display vector or an overlay
6347 string. (Bug#10119)
8c535114 6348
fa4fdb5c
JL
63492011-11-24 Juri Linkov <juri@jurta.org>
6350
6351 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6352 after the `MagickPingImage' call. (Bug#10112)
6353
90ec88df
CY
63542011-11-23 Chong Yidong <cyd@gnu.org>
6355
6356 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6357
56e2e794
MR
63582011-11-23 Martin Rudalics <rudalics@gmx.at>
6359
6360 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6361 making another buffer current. (Bug#10114)
6362
b6e64c41
GM
63632011-11-23 Glenn Morris <rgm@gnu.org>
6364
6365 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6366
6b21de18
CY
63672011-11-23 Chong Yidong <cyd@gnu.org>
6368
6369 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6370 using it (Bug#5984).
6371
b12cd789
EZ
63722011-11-22 Eli Zaretskii <eliz@gnu.org>
6373
6374 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6375 and header-lines, as they don't have one computed for them.
6376 (Bug#10098)
6377
6378 * .gdbinit (prow): Make displayed values more self-explaining.
6379 Add row's hash code.
6380
261b6fd4
LMI
63812011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6382
6383 * process.c (wait_reading_process_output): Fix asynchrounous
6384 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6385 (wait_reading_process_output): Add comment and URL.
261b6fd4 6386
e7cfd277
JD
63872011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6388
6389 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6390
a9b9b7f5
CY
63912011-11-21 Chong Yidong <cyd@gnu.org>
6392
6393 * window.c (Fnext_window, Fprevious_window): Doc fix.
6394
b0d15b4f
SM
63952011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6396
6397 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6398
fe7a3057
JB
63992011-11-20 Juanma Barranquero <lekktu@gmail.com>
6400
6401 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6402
d2999b1a
MR
64032011-11-20 Martin Rudalics <rudalics@gmx.at>
6404
6405 * window.c (Fset_window_combination_limit): Rename argument
6406 STATUS to LIMIT.
6407 (Vwindow_combination_limit): Remove "status" from doc-string.
6408
d5ff9cd0
AS
64092011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6410
6411 * m/ibms390.h: Remove.
6412 * m/ibms390x.h: Don't include "ibms390.h".
6413
a5bb9bd3
SM
64142011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6415
6416 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6417 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6418
cd1181db
JB
64192011-11-20 Juanma Barranquero <lekktu@gmail.com>
6420
6421 * casetab.c (Fset_case_table):
6422 * charset.c (Fcharset_after): Fix typos.
6423
615a3b8d 64242011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6425
17e845af
PE
6426 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6427 Otherwise, valgrind does not work on some platforms.
6428 Problem reported by Andreas Schwab in
6a0bf43d
PE
6429 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6430 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6431 is set, removing the need for VIRT_ADDRESS_VARIES.
6432 (PURE_P): Use a more-efficient implementation that needs just one
6433 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6434 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6435 to 4 (xorl, subq, cmpq, setbe).
6436 * alloc.c (pure): Always extern now, since that's the
6437 VIRT_ADDR_VARIES behavior.
6438 (PURE_POINTER_P): Use a single comparison, not two, for
6439 consistency with the new puresize.h.
6440 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6441 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6442 Remove VIRT_ADDR_VARIES no longer needed.
6443
f8fe6f96
EZ
64442011-11-19 Eli Zaretskii <eliz@gnu.org>
6445
6446 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6447 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6448 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6449 behave as if the cursor position were at the window margin.
6450
6451 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6452 and the cursor position is out of bounds, behave as if the cursor
6453 position were at the window margin. (Bug#10075)
6454
df05a53c
CY
64552011-11-18 Chong Yidong <cyd@gnu.org>
6456
6457 * window.c (Fwindow_combination_limit): Make first argument
6458 non-optional, since it is meaningless for live windows like the
6459 selected window.
61ccba97 6460
2071918e
DA
64612011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6462
6463 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6464
b50a28de
SM
64652011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6466
6467 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6468 (graft_intervals_into_buffer): Simplify.
6469
015137db
EZ
64702011-11-18 Eli Zaretskii <eliz@gnu.org>
6471
6472 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6473 hash values of the two rows.
6474 (copy_row_except_pointers): Preserve the used[] arrays and the
6475 hash values of the two rows. (Bug#10035)
68c95424 6476 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6477
6478 * xdisp.c (row_hash): New function, body extracted from
6479 compute_line_metrics.
6480 (compute_line_metrics): Call row_hash, instead of computing the
6481 hash code inline.
6482
6483 * dispnew.c (verify_row_hash): Call row_hash for computing the
6484 hash code of a row, instead of duplicating code from xdisp.c.
6485
6486 * dispextern.h (row_hash): Add prototype.
6487
a2addb04
TH
64882011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6489
6490 * frame.c (delete_frame): Don't delete the terminal when the last
6491 X frame is closed if emacs is built with GTK toolkit.
6492
df85d315
JB
64932011-11-17 Juanma Barranquero <lekktu@gmail.com>
6494
6495 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6496
a0c2d0ae
MR
64972011-11-17 Martin Rudalics <rudalics@gmx.at>
6498
6499 * window.c (Vwindow_splits): Rename to
6500 Vwindow_combination_resize. Suggested by Juri Linkov.
6501 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6502 of Vwindow_splits.
6503
58179cce
JB
65042011-11-16 Juanma Barranquero <lekktu@gmail.com>
6505
7877f373
JB
6506 * nsfns.m (Fns_font_name):
6507 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6508
b6f67890
MR
65092011-11-16 Martin Rudalics <rudalics@gmx.at>
6510
6511 * window.h (window): Rename slot "nest" to "combination_limit".
6512 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6513 (Fset_window_nest): Rename to Fset_window_combination_limit.
6514 (Vwindow_nest): Rename to Vwindow_combination_limit.
6515 (recombine_windows, make_parent_window, make_window)
6516 (Fsplit_window_internal, saved_window)
6517 (Fset_window_configuration, save_window_save): Rename all
6518 occurrences of window_nest to window_combination_limit.
6519
c7015153
JB
65202011-11-15 Juanma Barranquero <lekktu@gmail.com>
6521
6522 * image.c (imagemagick_load_image): Fix typo.
6523
322ad6ec
EZ
65242011-11-14 Eli Zaretskii <eliz@gnu.org>
6525
6526 * xdisp.c (display_line): Move the call to
6527 highlight_trailing_whitespace before the call to
6528 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6529 faces of all the glyphs to compute ROW's hash value.
6530 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6531
f067b8ec
JB
65322011-11-14 Juanma Barranquero <lekktu@gmail.com>
6533
6534 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6535 just return (bug#10044).
6536
1e5b2111
EZ
65372011-11-12 Eli Zaretskii <eliz@gnu.org>
6538
7ef3cbd5
EZ
6539 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6540 with user-defined heap size. Bump the default size of the temacs
6541 heap to 27MB, to avoid memory warning when running temacs.
6542 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6543
1e5b2111
EZ
6544 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6545 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6546 (verify_row_hash) [XASSERTS]: New function.
6547 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6548 that the hash value of glyph rows is correct.
1e5b2111 6549
89d61221
MR
65502011-11-12 Martin Rudalics <rudalics@gmx.at>
6551
6552 * window.h (window): Remove splits slot.
6553 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6554 (Fdelete_other_windows_internal, make_parent_window)
6555 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6556 (Fset_window_configuration, save_window_save): Don't deal with
6557 split status of windows.
6558 (saved_window): Remove splits slot.
6559 (Vwindow_splits): Rewrite doc-string.
6560
97f18cc8
JD
65612011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6562
6563 * xfns.c (unwind_create_frame):
6564 * nsfns.m (unwind_create_frame):
6565 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6566 Vframe_list (Bug#9999).
6567
22a648b4
DA
65682011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6569
0b381c7e 6570 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6571
659afede
KH
65722011-11-11 Kenichi Handa <handa@m17n.org>
6573
6574 * callproc.c (Fcall_process): Set the member dst_multibyte of
6575 process_coding.
6576
9ac0394b
KH
65772011-11-11 Johan Bockgård <bojohan@gnu.org>
6578
6579 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6580 avoid a crash (bug#9496).
6581
2fbdc249
CY
65822011-11-09 Chong Yidong <cyd@gnu.org>
6583
6584 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6585 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6586
ac6b1f81
PE
65872011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6588
6589 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6590
09db192c
PE
65912011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6592
6593 Avoid some portability problems by eschewing 'extern inline' functions.
6594 The trivial performance wins aren't worth the portability hassles; see
6595 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6596 et seq.
6597 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6598 (window_box_width, window_box_left, window_box_left_offset)
6599 (window_box_right, window_box_right_offset): Undo previous change,
6600 by removing the "extern"s.
6601 * intervals.c (adjust_intervals_for_insertion)
6602 (adjust_intervals_for_deletion): Undo previous change,
6603 making these static again.
6604 (offset_intervals, temp_set_point_both, temp_set_point)
6605 (copy_intervals_to_string): No longer inline.
6606 * xdisp.c (window_text_bottom_y, window_box_width)
6607 (window_box_height, window_box_left_offset)
6608 (window_box_right_offset, window_box_left, window_box_right)
6609 (window_box): No longer inline.
6610
105216ed
CY
66112011-11-08 Chong Yidong <cyd@gnu.org>
6612
6613 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6614 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6615 Signal an error if not a live window.
105216ed
CY
6616 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6617 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6618
ae9e237f
JB
66192011-11-07 Juanma Barranquero <lekktu@gmail.com>
6620
6621 * lisp.h (syms_of_abbrev): Remove declaration.
6622 Reported by CHENG Gao <chenggao@royau.me>.
6623
c7aa8333
EZ
66242011-11-07 Eli Zaretskii <eliz@gnu.org>
6625
6626 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6627 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6628 of temacs in GUI mode.
6629
be7f5545
MR
66302011-11-07 Martin Rudalics <rudalics@gmx.at>
6631
6632 * window.h: Declare delete_all_child_windows instead of
6633 delete_all_subwindows.
6634 * window.c (Fwindow_nest, Fset_window_nest)
6635 (Fset_window_new_total, Fset_window_new_normal)
6636 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6637 (delete_all_subwindows): Rename to delete_all_child_windows.
6638 (Fdelete_other_windows_internal, Fset_window_configuration):
6639 Call delete_all_child_windows instead of delete_all_subwindows.
6640 * frame.c (delete_frame): Call delete_all_child_windows instead
6641 of delete_all_subwindows.
6642
ca78dc43
PE
66432011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6644
6645 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6646 This is also needed for porting to any host where GC_MARK_STACK is
6647 not GC_MAKE_GCPROS_NOOPS.
6648 (which_symbols): Use it.
6649
a0241d01
KH
66502011-11-07 Kenichi Handa <handa@m17n.org>
6651
6652 * coding.c (coding_set_destination): Check coding->src_pos only
6653 when coding->src_object is a buffer (bug#9910).
6654
6655 * process.c (send_process): Set the member src_multibyte of coding
6656 to 0 (bug#9911) when sending a unibyte text.
6657
6658 * callproc.c (Fcall_process): Set the member src_multibyte of
6659 process_coding to 0 (bug#9912).
6660
a64bfdfa 66612011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6662
6663 * xmenu.c (cleanup_widget_value_tree): New function.
6664 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6665 calling free_menubar_widget_value_tree directly (Bug#9830).
6666
cb41b32a
PE
66672011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6668
6669 Fix some portability problems with 'inline'.
6670 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6671 (window_box_width, window_box_left, window_box_left_offset)
6672 (window_box_right, window_box_right_offset): Declare extern.
6673 Otherwise, these inline functions do not conform to C99 and
6674 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6675 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6676 * intervals.c (adjust_intervals_for_insertion)
6677 (adjust_intervals_for_deletion): Now extern, because otherwise the
6678 extern inline functions 'offset_intervals' couldn't refer to it.
6679 (static_offset_intervals): Remove.
6680 (offset_intervals): Rewrite using the old contents of
6681 static_offset_intervals. The old version didn't conform to C99
6682 because an extern inline function contained a reference to an
6683 identifier with static linkage.
6684
b7041366
AS
66852011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6686
6687 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6688 GC.
6689
88a37c4d
EZ
66902011-11-06 Eli Zaretskii <eliz@gnu.org>
6691
6692 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6693 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6694 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6695 return Qleft_to_right.
6696
49745b39
CY
66972011-11-06 Chong Yidong <cyd@gnu.org>
6698
6699 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6700 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6701 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6702 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6703 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6704 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6705 (Fwindow_vscroll): Doc fix.
6706 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6707 argument, since it makes no sense to pass a live window and for
6708 consistency with window-child.
6709
1f05cd82
CS
67102011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6711
6712 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6713 support MSVC.
6714
22610910
JR
67152011-11-05 Jason Rumney <jasonr@gnu.org>
6716
6717 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6718 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6719 fonts (Bug#6029).
6720 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6721 bitwise arithmetic preventing use of unicode-sip and non-truetype
6722 opentype fonts.
6723
a06776b2
EZ
67242011-11-05 Eli Zaretskii <eliz@gnu.org>
6725
3ad924ba
EZ
6726 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6727 "emacs"-only part.
6728
a06776b2
EZ
6729 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6730 initialization code to keep similarity to xfns.c after changes
6731 from 2011-11-05.
6732
c9e7db78
JD
67332011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6734
a97f8f3f
JD
6735 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6736 (unwind_create_frame): New function (Bug#9943).
6737 (Fx_create_frame): Restructure code to be more similar to the one in
6738 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6739 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6740 Move terminal->reference_count++ just before making the frame official
6741 (Bug#9943).
6742
6743 * nsterm.m (x_free_frame_resources): New function.
6744 (x_destroy_window): Move code to x_free_frame_resources.
6745
c9e7db78 6746 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6747 (Fx_create_frame, x_create_tip_frame):
6748 Move terminal->reference_count++ just before making the frame
75f1671a 6749 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6750 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6751
a6fc3b5c
EZ
67522011-11-05 Eli Zaretskii <eliz@gnu.org>
6753
6754 Support MSVC build with newer versions of Visual Studio.
6755 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6756 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6757 nt/gmake.defs.
6758
6759 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6760 which are not supported by MSVC.
6761 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6762 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6763 bitfields.
6764 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6765 types in bitfields.
6766 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6767
6768 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6769
58179cce 67702011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6771
6772 Support MSVC build with newer versions of Visual Studio.
6773 * w32.c: Don't include w32api.h for MSVC.
6774 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6775
6776 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6777 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6778 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6779 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6780 e_* cousins.
6781 (alloca) [_MSC_VER]: Define to _alloca.
6782
6783 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6784
6785 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6786
a58c13ed
EZ
67872011-11-04 Eli Zaretskii <eliz@gnu.org>
6788
6789 * xdisp.c (note_mouse_highlight): If either of
6790 previous/next-single-property-change returns nil, treat that as
6791 the beginning or the end of the buffer. (Bug#9955)
6792
fe0b6370
JD
67932011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6794
a58c13ed 6795 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6796 label is not null (Bug#9951).
6797 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6798 may be NULL.
6799
89bd5ee1
EZ
68002011-11-04 Eli Zaretskii <eliz@gnu.org>
6801
6802 * window.c (Fwindow_body_size): Mention in the doc string that the
6803 return value is in frame's canonical units. (Bug#9949)
6804
84c3edb9
EZ
68052011-11-03 Eli Zaretskii <eliz@gnu.org>
6806
4e2fb5c7
EZ
6807 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6808
84c3edb9 6809 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6810 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6811 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6812
bc17a887
EZ
68132011-11-01 Eli Zaretskii <eliz@gnu.org>
6814
6815 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6816 Don't stop backward scan on the continuation glyph, even though
6817 its CHARPOS is positive.
6d5eb5b0
SM
6818 (mouse_face_from_buffer_pos, note_mouse_highlight):
6819 Rename cover_string to disp_string.
bc17a887 6820
4ee88440
MR
68212011-11-01 Martin Rudalics <rudalics@gmx.at>
6822
6823 * window.c (temp_output_buffer_show): Don't use
6824 Vtemp_buffer_show_specifiers.
6825 (Vtemp_buffer_show_specifiers): Remove unused variable.
6826
c2ff3c02
EZ
68272011-10-30 Eli Zaretskii <eliz@gnu.org>
6828
6829 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6830 past the beginning of the current glyph matrix.
6831
58179cce 68322011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6833
6834 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6835 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6836 HAVE_GTK3 (Bug#9869).
b77a6a7f 6837
3b574623
JD
6838 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6839 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6840
b77a6a7f
JD
6841 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6842
6843 * xterm.c: Declare x_handle_net_wm_state to return int.
6844 (handle_one_xevent): Check if we are iconified but don't have
6845 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6846 (get_current_wm_state): Return non-zero if not hidden,
6847 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6848 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6849 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6850 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6851
196e41e4
PE
68522011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6853
6854 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6855 so that this new function doesn't get optimized away by a
6856 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6857
021f2e1a
AS
68582011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6859
6860 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6861
8b058d44
EZ
68622011-10-29 Eli Zaretskii <eliz@gnu.org>
6863
6864 Fix the `xbytecode' command.
6865 * .gdbinit (xprintbytestr): New command.
b50a28de 6866 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6867 (xbytecode): Print the byte-code string as well.
6868
4452fb80
EZ
68692011-10-29 Kim Storm <storm@cua.dk>
6870
8b058d44
EZ
6871 * alloc.c (which_symbols): New function.
6872
21b72067
AS
68732011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6874
6875 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6876 line. (Bug#9903)
6877
83ed7b5c
GM
68782011-10-29 Glenn Morris <rgm@gnu.org>
6879
6880 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6881 Not clear what it was for, and it causes various bugs. (Bug#9839)
6882
5a7a728b
EZ
68832011-10-28 Eli Zaretskii <eliz@gnu.org>
6884
6885 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6886 possible random value that matches one of those tested as
6887 condition to clear the mouse face.
6888
d3d0842f
CY
68892011-10-28 Chong Yidong <cyd@gnu.org>
6890
6891 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6892
31b39d13
DN
68932011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6894
6895 * window.c (make_window): Initialize phys_cursor_on_p.
6896
9aba6043
SM
68972011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6898
6899 * lisp.h (struct Lisp_Symbol): Update comments.
6900
c20992f4
JB
69012011-10-28 Juanma Barranquero <lekktu@gmail.com>
6902
6903 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6904
db4f02f2
EZ
69052011-10-28 Eli Zaretskii <eliz@gnu.org>
6906
6907 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6908 <oslsachem@gmail.com> for helping to debug this.
6909
6910 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6911 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6912 (g_b_init_get_glyph_outline_w): New static variables.
6913 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6914 (GetGlyphOutlineW_Proc): New typedefs.
6915 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6916 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6917 New functions.
6918 (w32font_open_internal, compute_metrics):
6919 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6920 instead of calling the "wide" APIs directly.
6921
6922 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6923
6924 * w32.h (syms_of_w32font): Add prototype.
6925
87e68db4
JB
69262011-10-27 Juanma Barranquero <lekktu@gmail.com>
6927
6928 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6929 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6930 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6931 (Fmove_to_window_line): Doc fix.
6932
435c1d67
CY
69332011-10-27 Chong Yidong <cyd@gnu.org>
6934
6935 * process.c (make_process): Set gnutls_state to NULL.
6936
6937 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6938 non-NULL, regardless of GNUTLS_INITSTAGE.
6939 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6940 an error. Set process slots as soon as we allocate them.
6941
6942 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6943
9c6c6f49
CY
69442011-10-27 Chong Yidong <cyd@gnu.org>
6945
9aba6043
SM
6946 * gnutls.c (emacs_gnutls_deinit): New function.
6947 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6948 (Fgnutls_deinit, Fgnutls_boot): Use it.
6949
6950 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6951 (deactivate_process): Call emacs_gnutls_deinit.
6952
657d08d3
JB
69532011-10-27 Juanma Barranquero <lekktu@gmail.com>
6954
6955 * image.c (x_create_x_image_and_pixmap):
6956 * w32.c (sys_rename, w32_delayed_load):
6957 * w32font.c (fill_in_logfont):
6958 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6959
5430d399
JB
69602011-10-26 Juanma Barranquero <lekktu@gmail.com>
6961
6962 * w32fns.c (w32_default_color_map): New function,
6963 extracted from Fw32_default_color_map.
a7ef684b 6964 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6965
fe0055fa
PE
69662011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6967
6968 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6969
e6346438
SM
69702011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6971
6972 * keyboard.c (test_undefined): New function (bug#9751).
6973 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6974
e112cc37
ET
69752011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6976
6977 * sysdep.c (init_sys_modes): Fix the check for the controlling
6978 terminal (Bug#6649).
6979
7b5d6677
EZ
69802011-10-20 Eli Zaretskii <eliz@gnu.org>
6981
6982 * dispextern.h (struct bidi_it): New member next_en_type.
6983
6984 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6985 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6986 current character, check also for next_en_type being WEAK_EN.
6987 (bidi_resolve_weak): Don't enter the expensive loop if the current
6988 position is before next_en_pos. Record the bidi type of the first
6989 non-ET, non-BN character we find, in addition to its position.
6990 (bidi_level_of_next_char): Invalidate next_en_type when
6991 next_en_pos is over-stepped.
6992
7da0b018
PE
69932011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6994
6995 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6996 * editfns.c: Rewrite current-time-zone so that it invokes
6997 the equivalent of (format-time-string "%Z") to get the time zone name.
6998 This fixes a bug when the time zone name contains characters that
6999 need converting from the system time locale to Emacs internal format.
7000 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7001 that patch fixed format-time-string to do the conversion, but
7002 I forgot to fix current-time-zone.
7003 (format_time_string): New function, containing most of
7004 what Fformat_time_string used to contain.
7005 (Fformat_time_string): Rewrite in terms of format_time_string.
7006 This doesn't change this function's behavior.
7007 (current-time-zone): Rewrite to use format_time_string.
7008 This fixes the bug reported by Michael Schierl in
7009 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7010 Jason Rumney's 2007-06-07 change worked around this bug, but
7011 didn't fix it.
7012 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7013
8547b010
EZ
70142011-10-19 Eli Zaretskii <eliz@gnu.org>
7015
7016 * xdisp.c (start_display): If the character at POS is displayed
7017 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7018 (try_window_reusing_current_matrix): If a line ends in a display
7019 vector or the next line starts in a display vector, continue
7020 redrawing the window even though the character position of
7021 start_row was reached.
8547b010
EZ
7022 (Bug#9771, part 2)
7023
4e948d15
CY
70242011-10-18 Chong Yidong <cyd@gnu.org>
7025
7026 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7027 with nobreak-char-display too.
7028
4787455f
EZ
70292011-10-18 Eli Zaretskii <eliz@gnu.org>
7030
7031 Fix part 3 of bug#9771.
7032 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7033 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7034 non-neutral characters if the current character is a paragraph
7035 separator (a.k.a. Newline). This avoids running the same
7036 expensive loop twice, once when we consume the preceding newline
7037 and the other time when the line actually needs to be displayed.
7038 Avoid the loop when we see neutrals on the base embedding level
7039 following a character whose directionality is the same as the
7040 paragraph's. This avoids running the expensive loop when a line
7041 ends in a long sequence of neutrals, like control characters.
7042 Add assertion against STRONG_AL type. Slightly rearrange code
7043 that determines the type of a neutral given the first non-neutral
7044 that follows it.
7045 (bidi_level_of_next_char): Set next_en_pos to zero when
7046 invalidating its info.
7047
2c91f553
EZ
70482011-10-17 Eli Zaretskii <eliz@gnu.org>
7049
7050 * xdisp.c (push_display_prop): Determine whether to record string
7051 or buffer position by IT->string, not by IT->method. Allow
7052 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7053 (move_it_vertically_backward): Don't look for character position
7054 immediately after the newline when in a continuation line.
7055 (Bug#9771, part 1)
2c91f553 7056
c7b08b0d
MR
70572011-10-15 Martin Rudalics <rudalics@gmx.at>
7058
7059 * window.c (coordinates_in_window): Rewrite and delabelize
7060 vertical border check. (Bug#5357) (Bug#9618)
7061
6b02f655
SM
70622011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7063
7064 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7065 errors in XSetWindowBorder (bug#9310).
7066
81d40c92
DA
70672011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7068
7069 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7070 avoid crash when xmalloc overrun checking is enabled.
7071
d4172c3b
EZ
70722011-10-13 Eli Zaretskii <eliz@gnu.org>
7073
7074 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7075 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7076 cursor motion with <left> and <right> arrow keys.
7077
7078 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7079 some callers set that themselves.
7080
b00eea75
EZ
70812011-10-12 Eli Zaretskii <eliz@gnu.org>
7082
7083 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7084 display string and the previous row comes from the same string and
7085 is empty. (Bug#9739) (Bug#9738)
7086
8fe012c4
SM
70872011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7088
7089 * doc.c (get_doc_string): Encode file name (bug#9735).
7090
0074aef2
EZ
70912011-10-12 Eli Zaretskii <eliz@gnu.org>
7092
79beb178
EZ
7093 * bidi.c (bidi_level_of_next_char):
7094 * xdisp.c (get_visually_first_element): Remove old incorrect
7095 comments regarding the Unicode Line Separator character.
7096
0074aef2
EZ
7097 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7098
6e4b3fbe
DA
70992011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7100
7101 * alloc.c (Fgc_status): Do not access beyond zombies array
7102 boundary if nzombies > MAX_ZOMBIES.
7103 * alloc.c (dump_zombies): Add missing format specifier.
7104
0324f3af
PE
71052011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7106
b5525cac
PE
7107 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7108 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7109
0324f3af
PE
7110 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7111 Some packages use them to denote characters with modifiers.
7112
e9b5f888
AS
71132011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7114
7115 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7116 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7117 matching a pp-number. Rename parameter var to var1.
7118
127827c0
SM
71192011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7120
7121 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7122
c8fd3bd0
GM
71232011-10-08 Glenn Morris <rgm@gnu.org>
7124
7125 * callint.c (Fcall_interactively): Give a more explicit error for the
7126 'c' case with a non-character input. (Bug#8479)
7127
352ec8ff
EZ
71282011-10-08 Eli Zaretskii <eliz@gnu.org>
7129
03669ccb
EZ
7130 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7131 lines.
7061c986
EZ
7132 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7133 lines that are hscrolled on the left.
03669ccb 7134
352ec8ff
EZ
7135 * dispnew.c (buffer_posn_from_coords): Account for a possible
7136 presence of header-line. (Bug#4426)
7137
a66cfb1c
SM
71382011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7139
6b02f655
SM
7140 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7141 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7142
7c5ee88e
PE
71432011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7144
7145 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7146 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7147 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7148 this makes Emacs dump core during garbage collection on rare
7149 occasions. sizeof is obviously inferior to offsetof here, so
7150 stick with offsetof.
7151 (GC_POINTER_ALIGNMENT): New macro.
7152 (mark_memory): Omit 3rd (offset) arg; caller changed.
7153 Don't assume EMACS_INT alignment is the same as pointer alignment.
7154
df1bbe5b
SM
71552011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7156
7157 * keyboard.c (read_key_sequence_remapped): New var.
7158 (read_key_sequence): Compute remapping in the right buffer.
7159 (command_loop_1): Use read_key_sequence's remapping directly.
7160
51553db6
SM
71612011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7162
32c1fffd
SM
7163 * dired.c (file_name_completion): Don't expand file name.
7164 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7165 before checking file name handler.
7166
51553db6
SM
7167 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7168 they've been requested explicitly (bug#9591).
7169
b6bd1599 71702011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7171
7172 * keymap.c (Fsingle_key_description): Use make_specified_string
7173 instead of build_string to build string from push_key_description.
7174 (Bug#5193)
7175
f701dc2a
PE
71762011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7177
4222c55d
PE
7178 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7179 This fixes a Y2038 bug on 64-bit hosts.
7180 * buffer.c (reset_buffer):
7181 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7182 (Fclear_buffer_auto_save_failure):
7183 Use 0, not -1, to represent an unset failure time, since time_t
7184 might not be signed.
7185
f701dc2a
PE
7186 Remove dependency on glibc malloc internals.
7187 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7188 Move back here from lisp.h, but with their new implementations.
7189 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7190 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7191 * charset.c (charset_table_init): New static var.
7192 (syms_of_charset): Use it instead of xmalloc. This removes a
7193 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7194 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7195 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7196 Move back to alloc.c.
7197 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7198 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7199
9ceebf39
JD
72002011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7201
7202 * nsterm.m (windowDidResize): Call x_set_window_size only when
7203 ns_in_resize is true. Otherwise set pixelwidth/height and
7204 call change_frame_size (Bug#9628).
7205
cb993c58
PE
72062011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7207
3930c88b
PE
7208 Port --enable-checking=all to Fedora 14 x86-64.
7209 * charset.c (syms_of_charset): Also account for glibc malloc's
7210 internal overhead when calculating the initial malloc maximum.
7211
cb993c58
PE
7212 Port --enable-checking=all to Fedora 14 x86.
7213 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7214 Move to lisp.h.
7215 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7216 (overrun_check_realloc, overrun_check_free):
7217 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7218 That way, xmalloc returns a properly-aligned pointer even if
7219 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7220 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7221 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7222 into account when calculating the initial malloc maximum.
7223 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7224 Move here from alloc.c, so that charset.c can use it too.
7225 Properly align; the old code wasn't right for common 32-bit hosts
7226 when configured with --enable-checking=all.
7227 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7228 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7229
31bed486
EZ
72302011-09-29 Eli Zaretskii <eliz@gnu.org>
7231
04c70788 7232 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7233 use EDOM.
7234
fbcaa2f3
EZ
72352011-09-28 Eli Zaretskii <eliz@gnu.org>
7236
7237 * xdisp.c (compute_display_string_end): If there's no display
7238 string at CHARPOS, return -1.
7239
7240 * bidi.c (bidi_fetch_char): When compute_display_string_end
7241 returns a negative value, treat the character as a normal
7242 character not covered by a display string. (Bug#9624)
7243
a239d4e9
JB
72442011-09-28 Juanma Barranquero <lekktu@gmail.com>
7245
7246 * lread.c (Fread_from_string): Fix typo in docstring.
7247
88652fd5
EZ
72482011-09-27 Eli Zaretskii <eliz@gnu.org>
7249
7250 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7251 newline, reseat the iterator instead of bidi-iterating there one
7252 character at a time. (Bug#9610)
32c1fffd
SM
7253 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7254 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7255
ed497dd4
AS
72562011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7257
7258 * lread.c (readevalloop): Use correct code for NBSP.
7259 (read1): Likewise. (Bug#9608)
7260
b2bf61aa
MA
72612011-09-25 Michael Albinus <michael.albinus@gmx.de>
7262
7263 * dbusbind.c (Fdbus_register_signal): When service is not
7264 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7265
32bbb17c
GM
72662011-09-25 Glenn Morris <rgm@gnu.org>
7267
7268 * buffer.c (truncate-lines): Doc fix.
7269
94e0933e
CY
72702011-09-24 Chong Yidong <cyd@stupidchicken.com>
7271
7272 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7273 (Fset_window_next_buffers): Doc fix.
7274
cddde921
GM
72752011-09-24 Glenn Morris <rgm@gnu.org>
7276
7277 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7278
1260aef1
PE
72792011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7280
25b4bfa0
PE
7281 Fix minor problems found by static checking.
7282 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7283 * indent.c (Fvertical_motion): Fix == vs = typo.
7284
e3cbd34b
EZ
72852011-09-24 Eli Zaretskii <eliz@gnu.org>
7286
a66cfb1c
SM
7287 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7288 Default value is now t. Doc fix.
6bf7006f 7289
e3cbd34b 7290 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7291 logic when moving up, not only when moving down. Fix the
e3cbd34b 7292 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7293 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7294
7295 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7296 CHARPOS is covered by a display string which includes newlines.
7297 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7298 is covered by a display string with embedded newlines.
7299
a3de0cbd
MA
73002011-09-24 Michael Albinus <michael.albinus@gmx.de>
7301
7302 * dbusbind.c (Fdbus_register_signal): Add match rule to
7303 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7304 (Fdbus_register_method, Vdbus_registered_objects_table):
7305 Fix docstring.
a3de0cbd 7306
b260039d
JM
73072011-09-24 Jim Meyering <meyering@redhat.com>
7308
32c1fffd 7309 do not ignore write error for any output size
b260039d
JM
7310 The previous change was incomplete.
7311 While it makes emacs --batch detect the vast majority of stdout
7312 write failures, errors were still ignored whenever the output size is
7313 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7314 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7315 && echo FAIL: ignored write error
7316 FAIL: ignored write error
7317 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7318 && echo FAIL: ignored write error
7319 FAIL: ignored write error
7320 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7321
8eca8a7c
AS
73222011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7323
7324 * emacs.c (Fkill_emacs): In noninteractive mode exit
7325 non-successfully if a write error occurred on stdout. (Bug#9574)
7326
3341db62
EZ
73272011-09-21 Eli Zaretskii <eliz@gnu.org>
7328
7329 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7330 the xassert test.
7331
7332 * dispextern.h (struct it): Update the comment documenting what
7333 can it->OBJECT be.
7334
8c203dbf
EZ
73352011-09-20 Eli Zaretskii <eliz@gnu.org>
7336
7337 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7338 a display string, extend search for cursor position to end of row.
7339 (find_row_edges): If the row ends in a newline from a display
7340 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7341 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7342 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7343 non-empty line. Fixes confusing cursor motion with arrow keys at
7344 the beginning of a line that starts with whitespace.
8c203dbf 7345
a4824228
LMI
73462011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7347
7348 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7349 (bug#9493).
7350
33ed493b
CY
73512011-09-18 Chong Yidong <cyd@stupidchicken.com>
7352
7353 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7354 boolean (Bug#9154).
7355
56cd55c8
EZ
73562011-09-18 Eli Zaretskii <eliz@gnu.org>
7357
7358 * xdisp.c (display_line): Record maximum and minimum buffer
7359 positions even if no glyphs were produced (e.g., by a zero-width
7360 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7361 buffer positions that will be removed from the glyph row because
7362 they don't fit.
c02dcedf
EZ
7363 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7364 column is beyond frame width: don't subtract 1 "pixel" when
7365 computing width of the stretch.
3e62b7e0
EZ
7366 (reseat_at_next_visible_line_start): Undo the change made on
7367 2011-09-17 that saved paragraph information and restored it after
7368 the call to `reseat'. (Bug#9545)
56cd55c8 7369
5ed99d36 73702011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7371
7372 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7373 and turn window cursor on if cleared (Bug#9415).
7374
5ed99d36 73752011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7376
7377 * search.c (boyer_moore): Take unibyte characters from pattern
7378 literally. (Bug#9458)
7379
9bade7b2
EZ
73802011-09-18 Eli Zaretskii <eliz@gnu.org>
7381
7382 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7383
e5e9d610
PE
73842011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7385
87e4427a
PE
7386 Fix minor problem found by static checking.
7387 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7388 initialized, to pacify gcc -Wuninitialized.
7389
e5e9d610
PE
7390 * fileio.c: Report proper errno when syscall falls.
7391 (Finsert_file_contents): Save and restore errno,
7392 so that report_file_error outputs the correct diagnostic.
7393 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7394
a1674f0b
EZ
73952011-09-18 Eli Zaretskii <eliz@gnu.org>
7396
7397 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7398
fbfb6dd4
EZ
73992011-09-17 Eli Zaretskii <eliz@gnu.org>
7400
7401 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7402 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7403
bb187662
EZ
74042011-09-17 Eli Zaretskii <eliz@gnu.org>
7405
1137e8b8 7406 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7407 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7408
7409 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7410 (bidi_find_paragraph_start): Search back for paragraph beginning
7411 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7412 (bidi_move_to_visually_next): Only trigger paragraph-related
7413 computations when the last character is a newline or at EOB, not
7414 just any NEUTRAL_B. (Bug#9470)
7415
bb187662
EZ
7416 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7417 truncated lines if point is covered by a display string. (Bug#9524)
7418
2e621251
PE
74192011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7420
7421 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7422 (cons_to_x_long): New function.
7423 (lisp_data_to_selection_data): Use it. Correct the test for
7424 short-versus-long data; it was negated. Break out of vector
7425 loop, for efficiency, when a long datum is discovered.
7426
91a15bc6
SM
74272011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7428
7429 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7430
b41c3a35
EZ
74312011-09-16 Eli Zaretskii <eliz@gnu.org>
7432
7433 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7434 GCC PR/17406) by declaring this function with external scope.
7435
7812ba2d
PE
74362011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7437
7438 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7439 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7440
cf7edc2a
AS
74412011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7442
7443 * editfns.c (Fformat): Correctly handle text properties on "%%".
7444
bd01620e
EZ
74452011-09-15 Eli Zaretskii <eliz@gnu.org>
7446
7447 * xterm.c (x_draw_composite_glyph_string_foreground):
7448 * w32term.c (x_draw_composite_glyph_string_foreground):
7449 * term.c (encode_terminal_code):
7450 * composite.c (composition_update_it, get_composition_id):
7451 * xdisp.c (get_next_display_element)
7452 (fill_composite_glyph_string): Add comments about special meaning
7453 of TAB characters in a composition.
7454
a02719a3
PE
74552011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7456
7457 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7458 This occurs when processing a multibyte format.
7459 Problem reported by Wolfgang Jenker.
a02719a3 7460
72589a3c
JB
74612011-09-15 Johan Bockgård <bojohan@gnu.org>
7462
7463 * xdisp.c (try_cursor_movement): Only check for exact match if
7464 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7465
1c14176c
PE
74662011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7467
7468 Remove unused external symbols.
7469 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7470 * xdisp.c (calc_pixel_width_or_height): Now static.
7471 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7472 * indent.c (check_display_width):
7473 * w32term.c: Fix comment to match code.
7474 * xterm.c, xterm.h (x_catching_errors): Remove.
7475
d2eea5b5
PE
74762011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7477
7478 * xselect.c: Use signed conversions more consistently (Bug#9498).
7479 (selection_data_to_lisp_data): Assume incoming selection data are
7480 signed integers, not unsigned. This is to be consistent with
7481 outgoing selection data, which was modified to use signed integers
7482 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7483 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7484 expects long, not unsigned long.
7485
46888499
EZ
74862011-09-14 Eli Zaretskii <eliz@gnu.org>
7487
7488 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7489 computation of loop end. Reported by Johan Bockgård
7490 <bojohan@gnu.org>.
7491
ef8ef9fb
CY
74922011-09-13 Chong Yidong <cyd@stupidchicken.com>
7493
7494 * frame.c (Fother_visible_frames_p): Function deleted.
7495
fa819fed
EZ
74962011-09-12 Eli Zaretskii <eliz@gnu.org>
7497
7498 * indent.c (compute_motion): Process display vector front to back
7499 rather than the other way around. (Bug#2496)
7500
2ba8e008
SM
75012011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7502
7503 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7504
20f53c69
CY
75052011-09-11 Chong Yidong <cyd@stupidchicken.com>
7506
7507 * minibuf.c (Fread_from_minibuffer): Doc fix.
7508
d562d7a4
EZ
75092011-09-11 Eli Zaretskii <eliz@gnu.org>
7510
7511 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7512 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7513
1c4d7f3d
LMI
75142011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7515
7516 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7517 value for non-existent files.
7518
b885bf36
EZ
75192011-09-11 Eli Zaretskii <eliz@gnu.org>
7520
7521 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7522 set its "size" to -1. This will set the modtime_size field of
7523 the corresponding buffer to -1, which is what
7524 verify-visited-file-modtime expects for files that do not exist.
7525 (Bug#9139)
7526
6612f0bf
PE
75272011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7528
7529 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7530 here ...
7531 * lisp.h: ... from here. push_key_description is no longer
7532 defined in keyboard.c, so its declaration should not be in
7533 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7534 logically belongs with push_key_description.
7535
dfb3f755
PE
75362011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7537
7538 * buffer.h: Include <sys/types.h> instead of <time.h>.
7539 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7540 Problem reported by Herbert J. Skuhra.
7541
3134906c
LMI
75422011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7543
7544 * xml.c (parse_region): Make the parsing work for
7545 non-comment-starting XML files again (bug#9144).
7546
8d903f4e
AS
75472011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7548
7549 * image.c (gif_load): Fix calculation of bottom and right corner.
7550 (Bug#9468)
7551
80ad64f4
EZ
75522011-09-10 Eli Zaretskii <eliz@gnu.org>
7553
7554 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7555 redisplay in small windows.
7556
208a048d
EZ
75572011-09-09 Eli Zaretskii <eliz@gnu.org>
7558
7559 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7560
9b1c252e
MR
75612011-09-08 Martin Rudalics <rudalics@gmx.at>
7562
7563 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7564 Operate on live windows only.
7565
2949f33b
JB
75662011-09-08 Juanma Barranquero <lekktu@gmail.com>
7567
7568 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7569
e08dcafd
EZ
75702011-09-07 Eli Zaretskii <eliz@gnu.org>
7571
7572 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7573 only under bidi iteration.
7574
115b96bd
JD
75752011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7576
7577 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7578
c8199d0f
PE
75792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7580
7581 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7582 Without this fix, the command to link temacs failed due to an
7583 undefined symbol __builtin_isnan. This is because
7584 /usr/include/iso/math_c99.h #defines isnan(x) to
7585 __builtin_isnan(x), but the bundled gcc, which identifies itself
7586 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7587 a __builtin_isnan.
7588 * floatfns.c (isnan): #undef, and then #define to a clone of
7589 what's in data.c.
7590 (Fisnan): Always define, since it's always available now.
7591 (syms_of_floatfns): Always define isnan at the Lisp level.
7592
e39b275c 75932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7594
7595 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7596
b2db44d9 75972011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7598
f4af5137 7599 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7600 The previous code assumed that file offsets (off_t values) fit in
7601 EMACS_INT variables, which is not true on typical 32-bit hosts.
7602 The code messed up by falsely reporting buffer overflow in cases
7603 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7604 when "big" contains more than 2**29 bytes, even though this
7605 inserts just one byte and does not overflow the buffer.
7606 (Finsert_file_contents): Store file offsets as off_t
7607 values, not as EMACS_INT values. Check for overflow when
7608 converting between EMACS_INT and off_t. When checking for
7609 buffer overflow or for overlap, take the offsets into account.
7610 Don't use EMACS_INT for small values where int suffices.
7611 When checking for overlap, fix a typo: ZV was used where
7612 ZV_BYTE was intended.
7613 (Fwrite_region): Don't assume off_t fits into 'long'.
7614 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7615
ecfc0a49
MA
76162011-09-05 Michael Albinus <michael.albinus@gmx.de>
7617
7618 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7619
6511acf2 76202011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7621
0999621a 7622 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7623
7624 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7625 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7626 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7627 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7628 (modify_event_symbol): Do not assume that the length of
7629 name_alist_or_stem is safe to alloca and fits in int.
7630 (Fexecute_extended_command): Likewise for function name and binding.
7631 (Frecursion_depth): Wrap around reliably on integer overflow.
7632 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7633 since some callers pass EMACS_INT values.
7634 (Fsingle_key_description): Don't crash if symbol name contains more
7635 than MAX_ALLOCA bytes.
7636 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7637 (get_minibuffer): Arg is now EMACS_INT, not int.
7638 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7639 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7640 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7641
2be7d702
PE
7642 * dbusbind.c (signature_cat): New function.
7643 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7644 Do not overrun buffer; instead, report string overflow.
7645
9d1df220
PE
7646 * dispnew.c (add_window_display_history): Don't overrun buffer.
7647 Truncate instead; this is OK since it's just a log.
7648
33ef5c64
PE
7649 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7650 even if the time zone offset is outlandishly large.
7651 Don't mishandle offset == INT_MIN.
7652
66c6fdd5
PE
7653 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7654 when creating daemon; the previous buffer-overflow check was incorrect.
7655
d749b01b
PE
7656 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7657 which has the guts of the old verror function.
7658
b5cd1905
PE
7659 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7660 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7661
6e1a67fb
PE
7662 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7663 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7664 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7665 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7666 length of string rather than counting it via multiple sprintfs;
7667 that's simpler and more reliable.
c21721cc
PE
7668 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7669 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7670 sprintf, in case result does not fit in int.
7671
c57b67fc
PE
7672 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7673 (fontset_from_font): Print it.
7674
8a401434
PE
7675 * frame.c (tty_frame_count): Now printmax_t, not int.
7676 (make_terminal_frame, set_term_frame_name): Print it.
7677 (x_report_frame_params): In X, window IDs are unsigned long,
7678 not signed long, so print them as unsigned.
7679 (validate_x_resource_name): Check for implausibly long names,
7680 and don't assume name length fits in 'int'.
7681 (x_get_resource_string): Don't blindly alloca invocation name;
7682 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7683 not fit in int.
7684
6e1a67fb
PE
7685 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7686 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7687 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7688
0df02bf3
PE
7689 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7690 Use esprintf, not sprintf, in case result does not fit in int.
7691
48e30793
PE
7692 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7693 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7694 it as a large positive number.
7695 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7696 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7697
a66ff6d8
PE
7698 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7699 in case result does not fit in int.
7700
aca216ff
PE
7701 * print.c (float_to_string): Detect width overflow more reliably.
7702 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7703 buffer overrun. Don't assume list length fits in 'int'. Treat
7704 print length of 0 as 0, not as infinity; to be consistent with other
7705 uses of print length in this function. Don't overflow print length
7706 index. Don't assume hash table size fits in 'long', or that
7707 vectorlike size fits in 'unsigned long'.
7708
31c286f7
PE
7709 * process.c (make_process): Use printmax_t, not int, to format
7710 process-name gensyms.
7711
55e5faa1
PE
7712 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7713
80f2e268
PE
7714 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7715 to avoid potential buffer overrun.
7716
670741ab
PE
7717 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7718 if X resource line is longer than 512 bytes.
7719
b7163a50
PE
7720 * xfns.c (x_window): Make sprintf buffer a bit bigger
7721 to avoid potential buffer overrun.
7722
ae58ff1f
PE
7723 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7724
c43c8a6a
PE
7725 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7726
3f8236f4
PE
77272011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7728
53e9fe90 7729 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7730 Without these, Emacs silently mishandles large integers sometimes.
7731 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7732 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7733
6511acf2
PE
7734 * xdisp.c (try_window_id): Check Emacs fixnum range before
7735 converting to 'int'.
806add1d 7736
6511acf2 7737 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7738 Check that an Emacs fixnum is in range before assigning it to 'int'.
7739 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7740 values converted from Emacs fixnums.
7741 (Frecenter): Don't wrap around a line count if it is out of 'int'
7742 range; instead, treat it as an extreme value.
7743 (Fset_window_configuration, compare_window_configurations):
7744 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7745
6511acf2
PE
7746 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7747 that can exceed INT_MAX. Check that EMACS_INT value is in range
7748 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7749 (match_limit): Don't assume that a fixnum can fit in 'int'.
7750
6511acf2 7751 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7752 exceed INT_MAX.
7753
6511acf2 7754 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7755 (Fvertical_motion): Don't wrap around LINES values that don't fit
7756 in 'int'. Instead, treat them as extreme values. This is good
7757 enough for windows, which can't have more than INT_MAX lines anyway.
7758
fcb901a7
LMI
77592011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7760
0f2f6b6d
LMI
7761 * Require libxml/parser.h to avoid compilation warning.
7762
fcb901a7
LMI
7763 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7764
7765 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7766 since this reportedly can destroy thread storage.
7767
6e20a0d4
CY
77682011-08-30 Chong Yidong <cyd@stupidchicken.com>
7769
7770 * syntax.c (find_defun_start): Update all cache variables if
7771 exiting early (Bug#9401).
7772
148ae00e
EZ
77732011-08-30 Eli Zaretskii <eliz@gnu.org>
7774
f6cfbd8f
EZ
7775 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7776
148ae00e
EZ
7777 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7778 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7779 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7780
7781 * term.c (tty_append_glyph): New function.
7782 (produce_stretch_glyph): Static function and its prototype deleted.
7783
a66cfb1c
SM
7784 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7785 Add prototypes.
148ae00e 7786
c4a07a4c
PE
77872011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7788
7789 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7790 when checking :margin (Bug#9390).
7791 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7792 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7793 so that the name doesn't mislead. All uses changed.
7794
6bc8cd65
JB
77952011-08-28 Johan Bockgård <bojohan@gnu.org>
7796
7797 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7798 set_tty_hooks.
7799
dca4927e
EZ
78002011-08-27 Eli Zaretskii <eliz@gnu.org>
7801
7802 * xdisp.c (move_it_to): Don't bail out early when reaching
7803 position beyond to_charpos, if we are scanning backwards.
7804 (move_it_vertically_backward): When DY == 0, make sure we get to
7805 the first character in the line after the newline.
7806
f2cad773
PE
78072011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7808
7809 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7810 (ccl_driver): Do not generate an out-of-range pointer.
7811 (Fccl_execute_on_string): Remove unnecessary check for
7812 integer overflow, noted by Stefan Monnier in
7813 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7814 Remove a FIXME that didn't need fixing.
7815 Simplify the newly-introduced buffer reallocation code.
7816
0cae2cdb
JB
78172011-08-27 Juanma Barranquero <lekktu@gmail.com>
7818
7819 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7820
5fc295a4 78212011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7822
70c60eb2 7823 Integer and memory overflow issues (Bug#9196).
726e0ab1 7824
d31850da
PE
7825 * doc.c (get_doc_string): Rework so that
7826 get_doc_string_buffer_size is the actual buffer size, rather than
7827 being 1 less than the actual buffer size; this makes xpalloc more
7828 convenient.
7829
a69fbedb
PE
7830 * image.c (x_allocate_bitmap_record, cache_image):
7831 * xselect.c (Fx_register_dnd_atom):
7832 Simplify previous changes by using xpalloc.
7833
fe5c5d37
PE
7834 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7835 since either will do and ptrdiff_t is convenient with xpalloc.
7836
0065d054
PE
7837 * charset.c (charset_table_size)
7838 (struct charset_sort_data.priority): Now ptrdiff_t.
7839 (charset_compare): Don't overflow if priorities differ greatly.
7840 (Fsort_charsets): Don't assume list length fits in int.
7841 Check for size-calculation overflow when allocating sort data.
7842 (syms_of_charset): Allocate an initial charset table that is
7843 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7844
7845 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7846
7847 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7848 The actual value is always <= INT_MAX, and leaving it unsigned made
7849 overflow checking harder.
7850
7851 * dispextern.h (struct glyph_matrix.rows_allocated)
7852 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7853 with xpalloc. The values are still always <= INT_MAX.
7854
7855 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7856
7857 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7858 (SAFE_NALLOCA): New macro.
7859
7860 * region-cache.c (struct boundary.pos, find_cache_boundary)
7861 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7862 (set_cache_region, invalidate_region_cache)
7863 (revalidate_region_cache, know_region_cache, region_cache_forward)
7864 (region_cache_backward, pp_cache):
7865 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7866 so that ptrdiff_t * can be passed to xpalloc.
7867 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7868 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7869 (pp_cache): Don't assume cache_len fits in int.
7870 * region-cache.h: Adjust extern decls to match.
7871
7872 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7873 EMACS_INT, since either will do, for xpalloc.
7874
7875 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7876 (xnmalloc, xnrealloc, xpalloc): New functions.
7877
726e0ab1
PE
7878 * bidi.c (bidi_shelve_header_size): New constant.
7879 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7880 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7881
51f30bc5 7882 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7883 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7884 (overlay_strings):
7885 Don't update size of array until after memory allocation succeeds,
7886 because xmalloc/xrealloc may not return.
0065d054
PE
7887 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7888 now that we have proper integer overflow checking.
7889 (record_overlay_string, overlay_strings): Catch overflows when
7890 calculating size of overlay_str_buf.
726e0ab1 7891
0065d054
PE
7892 * callproc.c (Fcall_process): Check for size overflow when
7893 calculating size of args2.
7894 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7895 Normally we prefer signed values, but sticking with ptrdiff_t would
7896 require adding more-complicated checks.
726e0ab1
PE
7897
7898 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7899 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7900 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7901 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7902
7903 * character.c (Fstring): Check for size-calculation overflow.
7904
7905 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7906 unnecessary integer overflow. Check for size overflow.
7907 (encode_coding_object): Don't update size until xmalloc succeeds.
7908
7909 * composite.c (get_composition_id): Check for overflow in glyph
7910 length calculations.
7911
7912 Integer and memory overflow fixes for display code.
7913 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7914 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7915 (scrolling_window): Check for overflow in size calculations.
7916 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7917 Don't assume glyph table len fits in int.
7918 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7919 (row_table_size): Now ptrdiff_t, not int.
7920 (scrolling_window): Avoid overflow in size calculations.
7921 Don't update size until allocation succeeds.
7922 * fns.c (concat): Check for overflow in size calculations.
7923 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7924 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7925 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7926
7927 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7928 (get_doc_string): Check for size calculation overflow.
7929 Don't update size until allocation succeeds.
7930 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7931 EMACS_INT, where ptrdiff_t will do.
7932 (Fsubstitute_command_keys): Check for string overflow.
7933
7934 * editfns.c (set_time_zone_rule): Don't assume environment length
7935 fits in int.
7936 (message_length): Now ptrdiff_t, not int.
7937 (Fmessage_box): Don't update size until allocation succeeds.
7938 Don't assume message length fits in int.
7939 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7940
0065d054
PE
7941 * emacs.c (main): Do not reallocate argv, since there is a null at
7942 the end that can be overwritten, and this way there's no need to
7943 worry about size-calculation overflow.
7944 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7945
7946 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7947 alloc succeeds.
7948 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7949
7950 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7951 (x_set_scroll_bar_width, x_figure_window_size):
7952 Check for integer overflow.
7953 (x_set_alpha): Do not assume XINT fits in int.
7954
7955 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7956 This is for the members text_lines, text_cols, total_lines, total_cols,
7957 where the system imposes an 'int' limit.
7958
7959 * fringe.c (Fdefine_fringe_bitmap):
7960 Don't update size until alloc works.
7961
7962 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7963 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7964
7965 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7966 Check for size-calculation overflow.
7967 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7968 do, as we prefer signed integers.
7969 (id_to_widget.max_size, id_to_widget.used)
7970 (xg_store_widget_in_map, xg_remove_widget_from_map)
7971 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7972 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7973 Use and return ptrdiff_t, not int.
7974 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7975 * gtkutil.h: Change prototypes to match the above.
7976
7977 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7978 are duplicate now that they've been promoted to lisp.h.
7979 (x_allocate_bitmap_record, x_alloc_image_color)
7980 (make_image_cache, cache_image, xpm_load):
7981 Don't update size until alloc is done.
7982 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7983 (x_detect_edges):
3256efce 7984 Check for size calculation overflow.
726e0ab1
PE
7985 (ct_colors_allocated_max): New constant.
7986 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7987 overflow.
3256efce 7988
726e0ab1
PE
7989 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7990 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7991 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7992 Use ptrdiff_t, not int, to count maps.
7993 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7994 calculations. Don't update size until allocation succeeds.
7995 Redo calculations to avoid overflow.
726e0ab1
PE
7996 * keyboard.h: Change prototypes to match the above.
7997
7998 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7999 to count maps.
8000 (current_minor_maps): Check for size calculation overflow.
8001 * keymap.h: Change prototypes to match the above.
8002
8003 * lread.c (read1, init_obarray): Don't update size until alloc done.
8004
8005 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8006 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8007
726e0ab1
PE
8008 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8009 Now ptrdiff_t, not int.
8010 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8011 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8012
8013 * process.c (Fnetwork_interface_list): Check for overflow
8014 in size calculation.
8015
8016 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8017
8018 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8019 overflow. Don't bother calling xmalloc when xrealloc will do.
8020
8021 * search.c (Freplace_match): Check for size calculation overflow.
8022 (Fset_match_data): Don't assume list lengths fit in 'int'.
8023
8024 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8025 for command line length. Do not attempt to address one before the
8026 beginning of an array, as that's not portable.
8027
8028 * term.c (max_frame_lines): Remove; unused.
8029 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8030 not int.
8031 (encode_terminal_code, calculate_costs): Check for size
8032 calculation overflow.
8033 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8034 table lengths and related sizes. Don't update size until alloc
8035 done. Redo calculations to avoid overflow.
8036 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8037
8038 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8039 subtracting pointers.
8040 (gobble_line): Check for overflow more carefully. Don't update size
8041 until alloc done.
8042
8043 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8044 Don't update size until alloc done.
8045 Redo size calculations to avoid overflow.
8046 Check for size calculation overflow.
0065d054 8047 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8048
8049 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8050 Use ptrdiff_t, not int, for sizes.
8051 (store_mode_line_noprop_char): Don't update size until alloc done.
8052
0065d054
PE
8053 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8054 Use ptrdiff_t, not int, for sizes.
8055 (Finternal_make_lisp_face, cache_face):
8056 Check for size calculation overflow.
8057 (cache_face): Treat size calculation overflows as if they were
8058 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8059
8060 * xfns.c (x_encode_text, x_set_name_internal)
8061 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8062 sizes, since they can exceed INT_MAX in size. Check for size
8063 calculation overflow.
8064
0065d054
PE
8065 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8066 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8067 Don't update size until alloc done.
8068
0065d054 8069 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8070 as sprintf is limited to int lengths.
1d526e2f 8071
252c5ee1
PE
8072 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8073 (X_LONG_MIN): New macros.
864d7ce7
PE
8074 Use them to make the following changes clearer.
8075 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8076 This change doesn't affect the value now, but it may help remind
8077 future maintainers not to raise the value too much later.
8078 (SELECTION_QUANTUM): Remove, replacing with ...
8079 (selection_quantum): ... new function, which avoids overflow.
8080 All uses changed.
8081 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8082 assumption that selection length fits in 'int'.
8083 (x_reply_selection_request, x_handle_selection_request)
8084 (x_get_window_property, receive_incremental_selection)
8085 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8086 (lisp_data_to_selection_data, clean_local_selection_data):
8087 Use ptrdiff_t, not int, to record length of selection.
8088 (x_reply_selection_request, x_get_window_property)
8089 (receive_incremental_selection, x_property_data_to_lisp):
8090 Redo calculations to avoid overflow.
8091 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8092 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8093 something.
8094 (x_get_window_property, receive_incremental_selection)
8095 (lisp_data_to_selection_data, x_property_data_to_lisp):
8096 Check for size-calculation overflow.
8097 (x_get_window_property, receive_incremental_selection)
8098 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8099 Don't store size until memory allocation succeeds.
8100 (x_get_window_property): Plug memory leak on memory exhaustion.
8101 Don't double-block input; malloc is safe here. Don't assume 2**34
8102 - 4 fits in unsigned long. Add an xassert to check
8103 XGetWindowProperty overflow. Be more careful about overflow
8104 calculations, and distinguish size from memory overflow better.
8105 (receive_incremental_selection): When tracing, don't assume
8106 unsigned int is less than INT_MAX.
8107 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8108 harmful) conversions of unsigned short to int.
8109 (lisp_data_to_selection_data): Don't assume that integers
8110 in the range -65535 through -1 fit in an X unsigned short.
8111 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8112 result parameters unless successful. Rely on cons_to_unsigned
8113 to report problems with elements; the old code wasn't right anyway.
8114 (x_check_property_data): Check for int overflow; we cannot use
8115 a wider type due to X limits.
8116 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8117
726e0ab1 8118 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8119
0065d054
PE
8120 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8121 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8122 (x_color_cells): Don't store size until memory allocation succeeds.
8123 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8124 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8125 (x_term_init): Don't assume length fits in int (sprintf is limited
8126 to int size).
bc18e09d 8127
ebfa62c0
PE
8128 Use ptrdiff_t for composition IDs.
8129 * character.c (lisp_string_width):
8130 * composite.c (composition_table_size, n_compositions)
8131 (get_composition_id, composition_gstring_from_id):
8132 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8133 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8134 * window.c (Frecenter):
8135 Use ptrdiff_t, not int, for composition IDs.
8136 * composite.c (get_composition_id): Check for integer overflow.
8137 * composite.h: Adjust prototypes to match the above changes.
8138
d3411f89
PE
8139 Use ptrdiff_t for hash table indexes.
8140 * category.c (hash_get_category_set):
8141 * ccl.c (ccl_driver):
8142 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8143 * coding.c (coding_system_charset_list, detect_coding_system):
8144 * coding.h (struct coding_system.id):
8145 * composite.c (get_composition_id, gstring_lookup_cache):
8146 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8147 * image.c (xpm_get_color_table_h):
8148 * lisp.h (hash_lookup, hash_put):
8149 * minibuf.c (Ftest_completion):
8150 Use ptrdiff_t for hash table indexes, not int (which is too
8151 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8152 32-bit --with-wide-int hosts).
8153
e097a6fa
PE
8154 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8155 Add a FIXME comment about memory leaks.
8156 (syms_of_charset): Don't assume xmalloc returns.
8157
5637687f
PE
8158 Don't assume that stated character widths fit in int.
8159 * character.c (Fchar_width, c_string_width, lisp_string_width):
8160 * character.h (CHAR_WIDTH):
8161 * indent.c (MULTIBYTE_BYTES_WIDTH):
8162 Use sanitize_char_width to avoid undefined and/or bad behavior
8163 with outlandish widths.
a66cfb1c 8164 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8165 now that we have two such functions. All uses changed.
8166 (sanitize_char_width): New inline function.
8167
a2271ba2
PE
8168 Don't assume that tab-width fits in int.
8169 * character.h (sanitize_width): New inline function.
8170 (SANE_TAB_WIDTH): New macro.
8171 (ASCII_CHAR_WIDTH): Use it.
8172 * indent.c (sane_tab_width): Remove. All uses replaced by
8173 SANE_TAB_WIDTH (current_buffer).
8174 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8175
18c52557
PE
8176 * fileio.c: Integer overflow issues with file modes.
8177 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8178
caeeedc1
PE
8179 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8180 Remove unreachable code.
8181 (read_hex, load_charset_map_from_file): Check for integer overflow.
8182
6df6ae42 8183 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8184 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8185 (x_send_scroll_bar_event): Likewise. Check that the size does not
8186 exceed limits imposed by XClientMessageEvent, as well as the usual
8187 ptrdiff_t and size_t limits.
8188
b13995db
PE
8189 * keyboard.c: Overflow, signedness and related fixes.
8190 (make_lispy_movement): Use same integer type in forward decl
8191 that is used in the definition.
8192 (read_key_sequence, keyremap_step):
8193 Change bufsize argument back to int, undoing my 2011-03-30 change.
8194 We prefer signed types, and int is wide enough here.
8195 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8196 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8197 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8198 length, not size_t. Use ptrdiff_t for index, not int.
8199 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8200 possibility of integer overflow.
8201
13464394
PE
8202 Overflow, signedness and related fixes for images.
8203
8204 * dispextern.h (struct it.stack[0].u.image.image_id)
8205 (struct_it.image_id, struct image.id, struct image_cache.size)
8206 (struct image_cache.used, struct image_cache.ref_count):
8207 * gtkutil.c (update_frame_tool_bar):
8208 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8209 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8210 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8211 * nsmenu.m (update_frame_tool_bar):
8212 * xdisp.c (calc_pixel_width_or_height):
8213 * xfns.c (image_cache_refcount):
8214 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8215 on typical 64-bit hosts.
8216
8217 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8218 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8219 Omit unnecessary casts to int.
8220 (parse_image_spec): Check that integers fall into 'int' range
8221 when the callers expect that.
8222 (image_ascent): Redo ascent calculation to avoid int overflow.
8223 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8224 (lookup_image): Remove unnecessary tests.
8225 (xbm_image_p): Locals are now of int, not EMACS_INT,
8226 since parse_image_check makes sure they fit into int.
8227 (png_load, gif_load, svg_load_image):
8228 Prefer int to unsigned where either will do.
8229 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8230 old tiff_error_handler and tiff_warning_handler.
8231 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8232 stack buffer overflows. It uses only the features of vsnprintf
8233 that are common to both POSIX and native Microsoft.
8234 (tiff_error_handler, tiff_warning_handler): Use it.
8235 (tiff_load, gif_load, imagemagick_load_image):
8236 Don't assume :index value fits in 'int'.
8237 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8238 (imagemagick_load_image): Check that crop parameters fit into
8239 the integer types that MagickCropImage accepts. Don't assume
8240 Vimagemagick_render_type has a nonnegative value. Don't assume
8241 size_t fits in 'long'.
8242 (gs_load): Use printmax_t to print the widest integers possible.
8243 Check for integer overflow when computing image height and width.
8244
c11821d4
EZ
82452011-08-26 Eli Zaretskii <eliz@gnu.org>
8246
8247 * xdisp.c (redisplay_window): Don't force window start if point
8248 will be invisible in the resulting window. (Bug#9324)
8249
0c95fcf7
EZ
82502011-08-25 Eli Zaretskii <eliz@gnu.org>
8251
8252 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8253 the display spec is of the form `(space ...)'.
8254 (handle_display_spec): Return the value returned by
8255 handle_single_display_spec, not just 1 or zero.
8256 (handle_single_display_spec): If the display spec is of the form
8257 `(space ...)', and specifies display in the text area, return 2
8258 rather than 1.
fee65a97 8259 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8260 accurately, and prefer exact match for point under bidi.
8261 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8262
8263 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8264 into disp_prop; all users changed.
8265
8266 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8267 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8268 for the text covered by the display property.
8269
e4ed06f1
CY
82702011-08-25 Chong Yidong <cyd@stupidchicken.com>
8271
8272 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8273 Change return value to nil.
8274 (Frecord_buffer): Delete unused function.
8275
f67cdd7f
EZ
82762011-08-24 Eli Zaretskii <eliz@gnu.org>
8277
5980d4c6
EZ
8278 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8279 buffers, return left-to-right.
8610fe8b
EZ
8280 (set_cursor_from_row): Consider candidate row a win if its glyph
8281 represents a newline and point is on that newline. Fixes cursor
8282 positioning on the newline at EOL of R2L text within L2R
8283 paragraph, and vice versa.
8284 (try_cursor_movement): Check continued rows, in addition to
8285 continuation rows. Fixes unwarranted scroll when point enters a
8286 continued line of R2L text within an L2R paragraph, or vice versa.
8287 (cursor_row_p): Consider the case of point being equal to
8288 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8289 from the end of a short line to the beginning of a continued line
8290 of R2L text within L2R paragraph.
8291 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8292 composed characters.
5980d4c6 8293
f67cdd7f
EZ
8294 * bidi.c (bidi_check_type): Use xassert.
8295 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8296 members.
8297
bca633fb
EZ
82982011-08-23 Eli Zaretskii <eliz@gnu.org>
8299
8300 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8301 a character.
8302
4a5885a7
CY
83032011-08-23 Chong Yidong <cyd@stupidchicken.com>
8304
8305 * nsfont.m (ns_otf_to_script): Fix typo.
8306
0902a04e
KH
83072011-08-22 Kenichi Handa <handa@m17n.org>
8308
8309 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8310 extra slot even if the purpose is char-code-property-table.
8311
1a2e6670
EZ
83122011-08-23 Eli Zaretskii <eliz@gnu.org>
8313
8ddde651
EZ
8314 * xdisp.c (redisplay_window): When computing centering_position,
8315 account for the height of the header line. (Bug#8874)
8316
425cc014
EZ
8317 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8318 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8319 candidate is selected by the mouse, and that candidate has a
8320 composed character under the mouse.
8321
1a2e6670
EZ
8322 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8323 coordinates reported by pos-visible-in-window-p for a composed
8324 character in column zero.
8325
8b76d6f8
SM
83262011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8327
8328 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8329
dac347dd
EZ
83302011-08-22 Eli Zaretskii <eliz@gnu.org>
8331
8332 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8333 consider it a hit if to_charpos is anywhere in the range of the
8334 composed buffer positions.
8335
e013fb34
CY
83362011-08-22 Chong Yidong <cyd@stupidchicken.com>
8337
8338 * image.c (gif_load): Don't assume that each subimage has the same
8339 dimensions as the base image. Handle disposal method that is
8340 "undefined" by the gif spec (Bug#9335).
8341
bd1ba3e8
CY
83422011-08-20 Chong Yidong <cyd@stupidchicken.com>
8343
8344 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8345 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8346
54a1215b
EZ
83472011-08-19 Eli Zaretskii <eliz@gnu.org>
8348
823564e5
EZ
8349 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8350 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8351 from an Org mode buffer to a Speedbar frame.
8352
54a1215b
EZ
8353 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8354 a composition, take its buffer position from IT->cmp_it.charpos.
8355 Fixes cursor positioning at the beginning of a line that begins
8356 with a composed character.
8357
9778ebcc
EZ
83582011-08-18 Eli Zaretskii <eliz@gnu.org>
8359
0be6ee06
EZ
8360 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8361 character bidirectional type, use STRONG_L instead. Fixes crashes
8362 in a buffer produced by `describe-categories'.
8363
9778ebcc
EZ
8364 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8365 members before the level stack, so they would be saved and
8366 restored when copying iterator state. Fixes incorrect reordering
8367 around TABs covered by display properties.
8368
156bffbe
AS
83692011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8370
6b02f655 8371 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8372
72ad093b
CY
83732011-08-17 Chong Yidong <cyd@stupidchicken.com>
8374
8375 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8376 (internal_condition_case_2, internal_condition_case_n):
8377 Remove unnecessary aborts (Bug#9081).
72ad093b 8378
35774242
EZ
83792011-08-17 Eli Zaretskii <eliz@gnu.org>
8380
8381 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8382 has no `load' handler, try opening the file locally. (Bug#9311)
8383
db76dd85
KB
83842011-08-16 Ken Brown <kbrown@cornell.edu>
8385
8386 * gmalloc.c: Expand comment.
8387
b215eee5
EZ
83882011-08-16 Eli Zaretskii <eliz@gnu.org>
8389
8390 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8391 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8392
a4579d33
KB
83932011-08-16 Ken Brown <kbrown@cornell.edu>
8394
8395 Fix memory allocation problems in Cygwin build (Bug#9273).
8396
8397 * unexcw.c ( __malloc_initialized): Declare external variable.
8398 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8399
8b76d6f8
SM
8400 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8401 New variables.
a4579d33
KB
8402 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8403 dumped emacs.
8404 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8405 in the static heap.
8406 [CYGWIN] (special_realloc): New function.
8407 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8408 requests to realloc storage in the static heap.
8409
3ebec551
PE
84102011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8411
8412 * bidi.c (bidi_initialize): Remove unused local.
8413
9fd8be00
EZ
84142011-08-15 Eli Zaretskii <eliz@gnu.org>
8415
6b02f655
SM
8416 * bidimirror.h:
8417 * biditype.h: Remove file.
8418 * makefile.w32-in ($(BLD)/bidi.$(O)):
8419 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8420
8421 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8422
8423 * chartab.c: Improve commentary for the uniprop_table API.
8424
32413314
EZ
8425 * bidi.c (bidi_paragraph_init): Support zero value of
8426 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8427 (bidi_initialize): Use uniprop_table instead of including
8428 biditype.h and bidimirror.h.
32413314 8429
9fd8be00
EZ
8430 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8431 coordinates of the iterator when restoring from ppos_it.
8432 (Bug#9296)
8433
5cf2b69b
KH
84342011-08-14 Kenichi Handa <handa@m17n.org>
8435
8436 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8437 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8438
daf17d00
EZ
84392011-08-14 Eli Zaretskii <eliz@gnu.org>
8440
8441 * xdisp.c (move_it_in_display_line_to): Don't invoke
8442 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8443 ppos_it. Fixes vertical cursor motion when line beginning is
8444 covered by an image. (Bug#9296)
8445
08e3161a
JD
84462011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8447
8448 * nsterm.h (ns_run_ascript): Declare.
8449 (NSAPP_DATA2_RUNASSCRIPT): Define.
8450
8451 * nsfns.m (as_script, as_result, as_status): New static variables.
8452 (ns_run_ascript): New function.
5e617bc2 8453 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8454 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8455 the event loop. Get status from as_status (Bug#7276).
8456
8457 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8458 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8459 the event loop (Bug#7276).
8460
a3720aa2
AS
84612011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8462
8463 * gnutls.c (QCgnutls_bootprop_priority)
8464 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8465 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8466 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8467 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8468 (QCgnutls_bootprop_verify_hostname_error)
8469 (QCgnutls_bootprop_callbacks_verify): Rename from
8470 Qgnutls_bootprop_..., all uses changed.
8471
8472 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8473 uses changed.
8474
0a0d27fb
PE
84752011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8476
19d5c50c
PE
8477 * xfaces.c (Qframe_set_background_mode): Now static.
8478 * dispextern.h (Qframe_set_background_mode): Remove decl.
8479
0a0d27fb
PE
8480 * process.c (Fnetwork_interface_info): Declare local only if needed.
8481
377538cb
JD
84822011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8483
8484 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8485 (Fnetwork_interface_list): Allocate in increments of bytes instead
8486 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8487 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8488 sockaddr.
8489 (struct ifflag_def): notrailers is smart on OSX.
8490 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8491 Get hardware address with getifaddrs if available.
8492
08fff70c
EZ
84932011-08-12 Eli Zaretskii <eliz@gnu.org>
8494
8495 * xdisp.c (iterate_out_of_display_property): xassert that
8496 IT->position is set to within IT->object's boundaries. Break from
8497 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8498 when IT->position is set up wrongly due to some bug.
8499 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8500 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8501 entry. Force push_it to save on the stack the current
8502 buffer/string position, to be restored by pop_it. Fix flags in
8503 the iterator structure wrt the object coming from a display
8504 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8505 properties. (Bug#9284)
8506
7be1c708 85072011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8508
7be1c708
CY
8509 * fontset.c (fontset_get_font_group): Add proper type checks.
8510 (Bug#9172)
aac0c6e3 8511
7be1c708 85122011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8513
7be1c708
CY
8514 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8515 and LC_VERSION_MIN_MACOSX.
8516 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8517 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8518
97bb72a6
EZ
85192011-08-08 Eli Zaretskii <eliz@gnu.org>
8520
8521 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8522 no-display-properties-and-no-overlays under bidi display.
8523 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8524 properties and overlays.
97bb72a6 8525
d5617611
CY
85262011-08-08 Chong Yidong <cyd@stupidchicken.com>
8527
37e11a63
CY
8528 * editfns.c (Fset_time_zone_rule): Document relationship with the
8529 setenv function.
8530
d5617611
CY
8531 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8532 the font entity extracted from the cache (Bug#8109).
8533
58872834
CY
85342011-08-07 Chong Yidong <cyd@stupidchicken.com>
8535
8536 * composite.c (autocmp_chars): Don't reset point. That is done by
8537 restore_point_unwind (Bug#5984).
8538
75bfc667
JL
85392011-08-07 Juri Linkov <juri@jurta.org>
8540
8541 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8542 to show the arg `TIME' instead of `TIMEVAL'.
8543
d1410150
EZ
85442011-08-06 Eli Zaretskii <eliz@gnu.org>
8545
8546 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8547 display property strides EOL and includes a newline, as in
8548 longlines-mode. (Bug#9254)
75b771e4
EZ
8549 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8550 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8551
8552 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8553 is non-zero, even if the data buffer is NULL. Fixes a crash in
8554 vertical-motion with longlines-mode. (Bug#9254)
8555
35928349
EZ
85562011-08-05 Eli Zaretskii <eliz@gnu.org>
8557
ec7cc85b
EZ
8558 * bidi.c <bidi_cache_total_alloc>: Now static.
8559 (bidi_initialize): Initialize bidi_cache_total_alloc.
8560
8b76d6f8 8561 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8562 cache. (Bug#9221)
8563
8564 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8565 amount allocated this far in `bidi_cache_total_alloc'.
8566 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8567 non-zero, only free the data buffer without restoring the cache
8568 contents. All callers changed.
8569
8570 * dispextern.h (bidi_unshelve_cache): Update prototype.
8571
8572 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8573 (move_it_in_display_line, move_it_to)
8574 (move_it_vertically_backward, move_it_by_lines): Replace the call
8575 to xfree to an equivalent call to bidi_unshelve_cache.
8576 (move_it_in_display_line_to): Fix logic of returning
412b6358 8577 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8578
e2e2423b
EZ
85792011-08-05 Eli Zaretskii <eliz@gnu.org>
8580
8581 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8582 came from a string character with a `cursor' property. (Bug#9229)
8583
ae9e757a
JD
85842011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8585
8586 * Makefile.in (LIB_PTHREAD): New variable.
8587 (LIBES): Add LIB_PTHREAD (Bug#9216).
8588
8589 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8590 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8591
213bd7f2
AS
85922011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8593
6b02f655 8594 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8595
99aaf75f
JD
85962011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8597
8598 * xterm.c (x_find_topmost_parent): New function.
8599 (x_set_frame_alpha): Find topmost parent window with
8600 x_find_topmost_parent and set the property there also (bug#9181).
8601 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8602
c74e9d86
PE
86032011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8604
8605 * callproc.c (Fcall_process): Avoid vfork clobbering
8606 the local vars buffer, coding_systems, current_dir.
8607
640c8776
SM
86082011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8609
8610 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8611
f26d0e4c
PE
86122011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8613
8a10d76c
PE
8614 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8615 so that it is not optimized away.
8616
f26d0e4c
PE
8617 * xdisp.c (compute_display_string_pos): Remove unused local.
8618
55439c61
EZ
86192011-08-02 Eli Zaretskii <eliz@gnu.org>
8620
8621 Fix slow cursor motion and scrolling in large buffers with
8622 selective display, like Org Mode buffers. (Bug#9218)
8623
8624 * dispextern.h (struct bidi_it): New member disp_prop_p.
8625
8626 * xdisp.c: Remove one-slot cache of display string positions.
8627 (compute_display_string_pos): Accept an additional argument
5e617bc2 8628 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8629 for a display string or property. If found, set DISP_PROP_P
8630 non-zero.
8631
8632 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8633 DISP_PROP_P, and pass it to compute_display_string_pos.
8634 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8635 non-zero. All callers of bidi_fetch_char changed.
8636
fb33fa43
SM
86372011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8638
8639 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8640
b099e063
DM
86412010-12-03 Don March <don@ohspite.net>
8642
8643 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8644 last character M-[char] is translated to ESC [char] (bug#7541).
8645
5cc7f7af
KH
86462011-08-02 Kenichi Handa <handa@m17n.org>
8647
d0fffa3f 8648 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8649
8650 * chartab.c (uniprop_table): Make it non-static.
8651
525d5e6e
EZ
86522011-08-01 Eli Zaretskii <eliz@gnu.org>
8653
8654 * xdisp.c (forward_to_next_line_start): Accept additional argument
8655 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8656 on the newline.
8657 (reseat_at_next_visible_line_start): Use the bidi iterator state
8658 returned by forward_to_next_line_start to restore the state of
8659 it->bidi_it after backing up to previous newline. (Bug#9212)
8660
31011111
AS
86612011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8662
8663 * regex.c (re_comp): Protoize.
8664 (re_exec): Fix return type.
8665 (regexec): Fix type of `ret'. (Bug#9203)
8666
476371c4
PE
86672011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8668
e5d76069
PE
8669 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8670 This is needed if max-image-size is a floating-point number.
8671
9a79b20c
AS
86722011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8673
8674 * print.c (print_object): Print empty symbol as ##.
8675
8676 * lread.c (read1): Read ## as empty symbol.
8677
d8c2fa78
AA
86782011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8679
8680 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8681 setting frame foreground color (Bug#9175).
8682 (x_set_background_color): Likewise.
8683
ffe57a7a
AA
8684 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8685 contents (Bug#9176).
8686 (EmacsTooltip -init): Remove bezels and add shadows to
8687 tooltip windows.
8688
bf3492a5
AA
8689 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8690 or scroll bar (Bug#8470).
8691
d55e9c53
AA
8692 * nsfont.m (nsfont_open): Remove assignment to voffset and
8693 unnecessary vars hshink, expand, hd, full_height, min_height.
8694 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8695
8696 * nsterm.h (nsfont_info): Remove voffset field.
8697
d8c2fa78 86982011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8699
8700 Implement strike-through and overline on NextStep (Bug#8863).
8701
8702 * nsfont.m (nsfont_open): Use underline position provided by font,
8703 instead of hard-coded value of 2.
8704 (nsfont_draw): Call ns_draw_text_decoration instead.
8705
8706 * nsterm.h: Add declaration for ns_draw_text_decoration.
8707
8708 * nsterm.m (ns_draw_text_decoration): New function for drawing
8709 underline, overline, and strike-through.
8710 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8711 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8712 accommodate underlining, etc.
4843aac3 8713
4cc60b9b
EZ
87142011-07-28 Eli Zaretskii <eliz@gnu.org>
8715
bc7ece87
EZ
8716 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8717 default.
4cc60b9b 8718
476371c4
PE
87192011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8720
66606eea
PE
8721 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8722 Without this fix, if a signal arrives just after memory fills up,
8723 'malloc' might be invoked reentrantly.
8724
476371c4
PE
8725 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8726 In other words, assume that every image size is allowed, on non-X
8727 hosts. This assumption is probably wrong, but it lets Emacs compile.
8728
f3fcc40d
AS
87292011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8730
8731 * regex.c (re_iswctype): Convert return values to boolean.
8732
350c992f
EZ
87332011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8734
8735 * xdisp.c (compute_display_string_pos): Don't use cached display
8736 string position if the buffer had its restriction changed.
8737 (Bug#9184)
8738
5266b4bb
PE
87392011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8740
8741 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8742
2573a837 87432011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8744
41f55ccd 8745 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8746
39e378da
PE
8747 * bidi.c: Integer size and overflow fixes.
8748 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8749 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8750 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8751 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8752 (bidi_find_other_level_edge):
8753 Use ptrdiff_t instead of EMACS_INT where either will do.
8754 This works better on 32-bit hosts configured --with-wide-int.
8755 (bidi_cache_ensure_space): Check for size-calculation overflow.
8756 Use % rather than repeated addition, for better worst-case speed.
8757 Don't set bidi_cache_size until after xrealloc returns, because it
8758 might not return.
8759 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8760 (bidi_cache_ensure_space): Also check that the bidi cache size
8761 does not exceed that of the largest Lisp string or buffer. See Eli
8762 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8763
5e927815
PE
8764 * alloc.c (__malloc_size_t): Remove.
8765 All uses replaced by size_t. See Andreas Schwab's note
8766 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8767
ca4aa935
PE
8768 * image.c: Improve checking for integer overflow.
8769 (check_image_size): Assume that f is nonnull, since
8770 it is always nonnull in practice. This is one less thing to
8771 worry about when checking for integer overflow later.
8772 (x_check_image_size): New function, which checks for integer
8773 overflow issues inside X.
8774 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8775 This removes the need for a memory_full check.
8776 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8777 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8778 (xbm_read_bitmap_data): Change locals back to 'int', since
8779 their values must fit in 'int'.
8780 (xpm_load_image, png_load, tiff_load):
8781 Invoke x_create_x_image_and_pixmap earlier,
8782 to avoid much needless work if the image is too large.
8783 (tiff_load): Treat overly large images as if
8784 x_create_x_image_and_pixmap failed, not as malloc failures.
8785 (gs_load): Use x_check_image_size.
8786
5f8f9cc2
PE
8787 * gtkutil.c: Omit integer casts.
8788 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8789 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8790
5adf60bc
PE
8791 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8792
c8907a93
PE
8793 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8794 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8795 would wrongly return t on a 64-bit host.
8796
e3c25c68
PE
8797 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8798 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8799 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8800 and therefore cause GCC to emit a bogus diagnostic in some cases.
8801
3f791afe
PE
8802 * image.c: Integer signedness and overflow and related fixes.
8803 This is not an exhaustive set of fixes, but it's time to
8804 record what I've got.
8805 (lookup_pixel_color, check_image_size): Remove redundant decls.
8806 (check_image_size): Don't assume that arbitrary EMACS_INT values
8807 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8808 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8809 (tiff_load, imagemagick_load_image):
8810 Check for overflow in size calculations.
8811 (x_create_x_image_and_pixmap): Remove unnecessary test for
8812 xmalloc returning NULL; that can't happen.
8813 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8814 (xpm_color_bucket): Use better integer hashing function.
8815 (xpm_cache_color): Don't possibly over-allocate memory.
8816 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8817 (gif_memory_source):
8818 Use ptrdiff_t, not int or size_t, to record sizes.
8819 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8820 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8821 either works, as we prefer signed integers.
8822 (tiff_read_from_memory, tiff_write_from_memory):
8823 Return tsize_t, not size_t, since that's what the TIFF API wants.
8824 (tiff_read_from_memory): Don't fail simply because the read would
8825 go past EOF; instead, return a short read.
8826 (tiff_load): Omit no-longer-needed casts.
8827 (Fimagemagick_types): Don't assume size fits into 'int'.
8828
3cc5a532
PE
8829 Improve hashing quality when configured --with-wide-int.
8830 * fns.c (hash_string): New function, taken from sxhash_string.
8831 Do not discard information about ASCII character case; this
8832 discarding is no longer needed.
8833 (sxhash-string): Use it. Change sig to match it. Caller changed.
8834 * lisp.h: Declare it.
8835 * lread.c (hash_string): Remove, since we now use fns.c's version.
8836 The fns.c version returns a wider integer if --with-wide-int is
8837 specified, so this should help the quality of the hashing a bit.
8838
b312a492
PE
8839 * emacs.c: Integer overflow minor fix.
8840 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8841 Define only if GNU_LINUX.
8842 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8843
dfd153ae
PE
8844 * dispnew.c: Integer signedness and overflow fixes.
8845 Remove unnecessary forward decls, that were a maintenance hassle.
8846 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8847 All uses changed.
8848 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8849 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8850 (prepare_desired_row, line_draw_cost):
8851 Use int, not unsigned, where either works.
8852 (save_current_matrix, restore_current_matrix):
8853 Use ptrdiff_t, not size_t, where either works.
8854 (init_display): Check for overflow more accurately, and without
8855 relying on undefined behavior.
8856
a81d11a3
PE
8857 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8858 Remove, replacing with the new symbols in lisp.h. All uses changed.
8859 * fileio.c (make_temp_name):
8860 * filelock.c (lock_file_1, lock_file):
8861 * xdisp.c (message_dolog):
8862 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8863 Use pMd etc. instead.
8864 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8865 replacing the pWIDE etc. symbols removed from editfns.c.
8866
3300e6fd
PE
8867 * keyboard.h (num_input_events): Now uintmax_t.
8868 This is (very slightly) less likely to mess up due to wraparound.
8869 All uses changed.
8870
fd05c7e9
PE
8871 * buffer.c: Integer signedness fixes.
8872 (alloc_buffer_text, enlarge_buffer_text):
8873 Use ptrdiff_t rather than size_t when either will do, as we prefer
8874 signed integers.
8875
903fe15d
PE
8876 * alloc.c: Integer signedness and overflow fixes.
8877 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8878 (__malloc_size_t): Default to size_t, not to int.
8879 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8880 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8881 Prefer ptrdiff_t to size_t when either would do, as we prefer
8882 signed integers.
8883 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8884 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8885 Now const. Initialize with values that are in range even if char
8886 is signed.
8887 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8888 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8889 These functions do the right thing with sizes > 2**32.
8890 (check_depth): Now ptrdiff_t, not int.
8891 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8892 Adjust to new way of storing sizes. Check for size overflow bugs
8893 in rest of code.
8894 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8895 slightly wrong anyway, as it missed one instance of
8896 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8897 (refill_memory_reserve): Omit needless cast to size_t.
8898 (mark_object_loop_halt): Mark as externally visible.
8899
ac82cc6a
PE
8900 * xselect.c: Integer signedness and overflow fixes.
8901 (Fx_register_dnd_atom, x_handle_dnd_message):
8902 Use ptrdiff_t, not size_t, since we prefer signed.
8903 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8904 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8905 x_dnd_atoms_size and x_dnd_atoms_length.
8906
c2d1e36d
PE
8907 * doprnt.c: Prefer signed to unsigned when either works.
8908 * eval.c (verror):
8909 * doprnt.c (doprnt):
8910 * lisp.h (doprnt):
8911 * xdisp.c (vmessage):
8912 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8913 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8914 prefer signed arithmetic to avoid comparison confusion.
8915 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8916 but is a bit tricky.
8917
0e926e56
PE
8918 Assume freestanding C89 headers, string.h, stdlib.h.
8919 * data.c, doprnt.c, floatfns.c, print.c:
8920 Include float.h unconditionally.
8921 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8922 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8923 * regex.c: Likewise for stddef.h, string.h.
8924 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8925 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8926 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8927 (STDC_HEADERS): Remove obsolete defines.
8928 * sysdep.c: Include limits.h unconditionally.
8929
9cfdb3ec
PE
8930 Assume support for memcmp, memcpy, memmove, memset.
8931 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8932 * regex.c (memcmp, memcpy):
8933 Remove; we assume C89 now.
8934
8935 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8936 (__malloc_safe_bcopy): Remove; no longer needed.
8937
cf950e6b 8938 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8939 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8940 well either way, and we prefer signed to unsigned.
8941
dbf38e02
LMI
89422011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8943
8944 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8945 closes the connection while we're reading (bug#9182).
8946
d6f0886c 89472011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8948
d6f0886c
JD
8949 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8950 are specified (Bug#9168).
24e0f6b1 8951
2eb1f9e6
PE
89522011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8953
8954 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8955 Found by GCC static checking and --with-wide-int on a 32-bit host.
8956
22381272 89572011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8958
8959 * xdisp.c (compute_display_string_pos): Fix logic of caching
8960 previous display string position. Initialize cached_prev_pos to
8961 -1. Fixes slow-down at the beginning of a buffer.
8962
f25e39b4
EZ
89632011-07-24 Eli Zaretskii <eliz@gnu.org>
8964
8965 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8966 for attrs[LFACE_FONTSET_INDEX].
8967
04c4b52e
PE
89682011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8969
8970 * xml.c (parse_region): Remove unused local
8971 that was recently introduced.
8972
c1734fbd
EZ
89732011-07-23 Eli Zaretskii <eliz@gnu.org>
8974
be18c5a5
EZ
8975 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8976 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8977
c1734fbd
EZ
8978 * xdisp.c (move_it_in_display_line_to): Record the best matching
8979 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8980 exit if none of the characters scanned was an exact match.
8981 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8982 when exact match is impossible due to invisible text, and the
8983 lines are truncated.
8984
a258d627
JD
89852011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8986
8987 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8988 for OSX >= 10.7.
8989
b6d5a689
EZ
89902011-07-22 Eli Zaretskii <eliz@gnu.org>
8991
0f74f785
EZ
8992 Fix a significant slow-down of cursor motion with C-n, C-p,
8993 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8994 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8995 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8996 (next_element_from_buffer): Call compute_stop_pos_backwards to
8997 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8998 base_level_stop.
8999 (reseat): Don't look for prev_stop, as that could mean a very long
9000 run.
9001 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9002 <cached_disp_overlay_modiff>: Cache for last found display string
9003 position.
551918c1 9004 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9005 about the same buffer in the same area of character positions, and
9006 the buffer wasn't changed since the time the display string
9007 position was cached.
551918c1 9008
b2d0c91a
EZ
90092011-07-22 Eli Zaretskii <eliz@gnu.org>
9010
9011 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9012 is an integer, which is important for empty lines. (Bug#9149)
9013
043604ee
CY
90142011-07-22 Chong Yidong <cyd@stupidchicken.com>
9015
9016 * frame.c (Fmodify_frame_parameters): In tty case, update the
9017 default face if necessary (Bug#4238).
9018
da4adb04
CY
90192011-07-21 Chong Yidong <cyd@stupidchicken.com>
9020
9021 * editfns.c (Fstring_to_char): No need to explain what a character
9022 is in the docstring (Bug#6576).
9023
9abd0532
LMI
90242011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9025
9026 * xml.c (parse_region): Make sure we always return a tree.
9027
36881d16
HK
90282011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9029
9030 * xml.c (parse_region): If a document contains only comments,
9031 return that, too.
9032
1e98674d
LMI
90332011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9034
9035 * xml.c (make_dom): Return comments, too.
9036
590bd467
PE
90372011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9038
9039 Port to OpenBSD.
9040 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9041 and the surrounding thread.
9042 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9043 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9044 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9045 timer goes off.
9046 * s/openbsd.h (BROKEN_SIGIO): Define.
9047 * unexelf.c (unexec) [__OpenBSD__]:
9048 Don't update the .mdebug section of the Alpha COFF symbol table.
9049
f41628b2
LMI
90502011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9051
9052 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9053 (bug#8460).
9054
b59b67c5
PE
90552011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9056
15e3a074
PE
9057 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9058 This fixes some race conditions on the permissions of any newly
9059 created file.
9060
41bed37d
PE
9061 * alloc.c (valid_pointer_p): Use pipe, not open.
9062 This fixes some permissions issues when debugging.
9063
b59b67c5
PE
9064 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9065 If fchown fails to set both uid and gid, try to set just gid,
9066 as that is sometimes allowed. Adjust the file's mode to eliminate
9067 setuid or setgid bits that are inappropriate if fchown fails.
9068
925a6be7
SM
90692011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9070
9071 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9072 to compare Lisp_Objects.
9073 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9074 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9075 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9076
52968808
AS
90772011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9078
0a6a104b
AS
9079 * lread.c (read_integer): Unread even EOF character.
9080 (read1): Likewise. Properly record start position of symbol.
9081
52968808
AS
9082 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9083 symbol character follows.
9084
9e381cdd
PE
90852011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9086
9087 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9088 This works around a problem with the previous change to Fcopy_file.
9089 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9090 and without this change, GCC might complain about discarding
9091 fchown's return value.
9092
b5641435
JB
90932011-07-16 Juanma Barranquero <lekktu@gmail.com>
9094
9095 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9096
a8031457
PE
90972011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9098
9099 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9100
dd889327
LMI
91012011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9102
750c33f7
LMI
9103 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9104 it's used from the C level.
9105
dd889327
LMI
9106 * process.c: Use the same condition for POLL_FOR_INPUT in both
9107 keyboard.c and process.c (bug#1858).
9108
87e86684
LM
91092011-07-09 Lawrence Mitchell <wence@gmx.li>
9110
9111 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9112 (Fgnutls_boot): Use it.
9113
64348f40
AS
91142011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9115
9116 * doc.c (Fsubstitute_command_keys): Revert last change.
9117
1d698799
LMI
91182011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9119
f863868c
LMI
9120 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9121 quotes the next character, and doesn't affect other longer
9122 sequences (bug#8935).
9123
1d698799
LMI
9124 * lread.c (syms_of_lread): Clarify that is isn't only
9125 `eval-buffer' and `eval-defun' that's affected by
9126 `lexical-binding' (bug#8460).
9127
aa4b6df6
EZ
91282011-07-15 Eli Zaretskii <eliz@gnu.org>
9129
9130 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9131 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9132
5d856da6
PE
91332011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9134
ad6042bb
PE
9135 Fix minor problems found by static checking.
9136 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9137 (elsz): Now a signed constant, not a size_t var. We prefer signed
9138 types to unsigned, to avoid integer comparison confusion. Without
9139 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9140 "cannot optimize loop, the loop counter may overflow", a symptom
9141 of the confusion.
f00bbb22 9142 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9143 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9144
6468f31c
LMI
91452011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9146
49080b10
LMI
9147 * search.c (Fre_search_backward): Mention `case-fold-search' in
9148 all the re_search_* functions (bug#8138).
9149
6468f31c
LMI
9150 * keyboard.c (Fopen_dribble_file): Document when the file is
9151 closed (bug#8056).
9152
c965adc5
EZ
91532011-07-14 Eli Zaretskii <eliz@gnu.org>
9154
df9733bf
EZ
9155 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9156 bidi_cache_idx.
9157
0bb23927
EZ
9158 Support bidi reordering of display and overlay strings.
9159 * xdisp.c (compute_display_string_pos)
9160 (compute_display_string_end): Accept additional argument STRING.
9161 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9162 (reseat_to_string): Initialize bidi_it->string.s and
9163 bidi_it->string.schars.
9164 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9165 NULL (avoids a crash in bidi_paragraph_init).
9166 Initialize itb.string.lstring.
0bb23927
EZ
9167 (init_iterator): Call bidi_init_it only of a valid
9168 buffer position was specified. Initialize paragraph_embedding to
9169 L2R.
9170 (reseat_to_string): Initialize the bidi iterator.
9171 (display_string): If we need to ignore text properties of
9172 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9173 original value of -1 will not work with bidi.)
9174 (compute_display_string_pos): First arg is now struct
9175 `text_pos *'; all callers changed. Support display properties on
9176 Lisp strings.
9177 (compute_display_string_end): Support display properties on Lisp
9178 strings.
9179 (init_iterator, reseat_1, reseat_to_string): Initialize the
9180 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9181 when iterating on a string not from display properties).
640c8776
SM
9182 (compute_display_string_pos, compute_display_string_end):
9183 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9184 arrow keys.
9185 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9186 base_level_stop; instead, set base_level_stop to BEGV.
9187 Fixes crashes in vertical-motion.
0bb23927
EZ
9188 (next_element_from_buffer): Improve commentary for when
9189 the iterator is before prev_stop.
9190 (init_iterator): Initialize bidi_p from the default value of
9191 bidi-display-reordering, not from buffer-local value. Use the
9192 buffer-local value only if initializing for buffer iteration.
9193 (handle_invisible_prop): Support invisible properties on strings
9194 that are being bidi-reordered.
9195 (set_iterator_to_next): Support bidi reordering of C strings and
9196 Lisp strings.
9197 (next_element_from_string): Support bidi reordering of Lisp
9198 strings.
9199 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9200 (display_string): Support display of R2L glyph rows.
9201 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9202 (init_iterator): Don't initialize it->bidi_p for strings
9203 here.
9204 (reseat_to_string): Initialize it->bidi_p for strings here.
9205 (next_element_from_string, next_element_from_c_string)
9206 (next_element_from_buffer): Add xassert's for correspondence
9207 between IT's object being iterated and it->bidi_it.string
9208 structure.
9209 (face_before_or_after_it_pos): Support bidi iteration.
9210 (next_element_from_c_string): Handle the case of the first string
9211 character that is not the first one in the visual order.
9212 (get_visually_first_element): New function, refactored from common
9213 parts of next_element_from_buffer, next_element_from_string, and
9214 next_element_from_c_string.
9215 (tool_bar_lines_needed, redisplay_tool_bar)
9216 (display_menu_bar): Force left-to-right direction. Add a FIXME
9217 comment for making that be controlled by a user option.
9218 (push_it, pop_it): Save and restore the state of the
9219 bidi iterator. Save and restore the bidi_p flag.
9220 (pop_it): Iterate out of display property for string iteration as
9221 well.
9222 (iterate_out_of_display_property): Support iteration over strings.
9223 (handle_single_display_spec): Set up it->bidi_it for iteration
9224 over a display string, and call bidi_init_it.
9225 (handle_single_display_spec, next_overlay_string)
9226 (get_overlay_strings_1, push_display_prop): Set up the bidi
9227 iterator for displaying display or overlay strings.
9228 (forward_to_next_line_start): Don't use the shortcut if
9229 bidi-iterating.
9230 (back_to_previous_visible_line_start): If handle_display_prop
9231 pushed the iterator stack, restore the internal state of the bidi
9232 iterator by calling bidi_pop_it same number of times.
9233 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9234 and we are bidi-iterating, don't decrement the iterator position;
9235 instead, set the first_elt flag in the bidi iterator, to produce
9236 the same effect.
9237 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9238 (push_display_prop): xassert that we are iterating a buffer.
9239 (push_it, pop_it): Save and restore paragraph_embedding member.
9240 (handle_single_display_spec, next_overlay_string)
9241 (get_overlay_strings_1, reseat_1, reseat_to_string)
9242 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9243 correctly. Don't assume unibyte strings are not bidi-reordered.
9244 (compute_display_string_pos)
9245 (compute_display_string_end): Fix handling the case of C string.
9246 (push_it, pop_it): Save and restore from_disp_prop_p.
9247 (handle_single_display_spec, push_display_prop): Set the
9248 from_disp_prop_p flag.
9249 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9250 (pop_it): Call iterate_out_of_display_property only if we are
9251 popping after iteration over a string that came from a display
9252 property. Fix a typo in popping stretch info. Add an assertion
9253 for verifying that the iterator position is in sync with the bidi
9254 iterator.
9255 (handle_single_display_spec, get_overlay_strings_1)
9256 (push_display_prop): Fix initialization of paragraph direction for
9257 string when that of the parent object is not yet determined.
9258 (reseat_1): Call bidi_init_it to resync the bidi
9259 iterator with IT's position. (Bug#7616)
9260 (find_row_edges): If ROW->start.pos gives position
9261 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9262 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9263 Reset the from_disp_prop_p flag.
9264 (SAVE_IT, RESTORE_IT): New macros.
9265 (pos_visible_p, face_before_or_after_it_pos)
9266 (back_to_previous_visible_line_start)
9267 (move_it_in_display_line_to, move_it_in_display_line)
9268 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9269 (try_scrolling, redisplay_window, display_line): Use them when
9270 saving a temporary copy of the iterator and restoring it back.
9271 (back_to_previous_visible_line_start, reseat_1)
9272 (init_iterator): Empty the bidi cache "stack".
9273 (move_it_in_display_line_to): If iterator ended up at
9274 EOL, but we never saw any buffer positions smaller than
9275 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9276 motion in bidi-reordered lines.
9277 (move_it_in_display_line_to): Record prev_method and prev_pos
9278 immediately before the call to set_iterator_to_next. Fixes cursor
9279 motion in bidi-reordered lines with stretch glyphs and strings
9280 displayed in margins. (Bug#8133) (Bug#8867)
9281 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9282 TO_CHARPOS.
640c8776
SM
9283 (pos_visible_p): Support positions in bidi-reordered lines.
9284 Save and restore bidi cache.
0bb23927
EZ
9285
9286 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9287 (bidi_paragraph_info): Delete unused struct.
9288 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9289 (bidi_cache_start): New variable.
9290 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9291 to zero.
9292 (bidi_cache_fetch_state, bidi_cache_search)
9293 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9294 (bidi_cache_find, bidi_peek_at_next_level)
9295 (bidi_level_of_next_char, bidi_find_other_level_edge)
9296 (bidi_move_to_visually_next): Compare cache index with
9297 bidi_cache_start rather than with zero.
9298 (bidi_fetch_char): Accept new argument STRING; all callers
9299 changed. Support iteration over a string. Support strings with
9300 display properties. Support unibyte strings. Fix the type of
9301 `len' according to what STRING_CHAR_AND_LENGTH expects.
9302 (bidi_paragraph_init, bidi_resolve_explicit_1)
9303 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9304 (bidi_level_of_next_char, bidi_move_to_visually_next):
9305 Support iteration over a string.
0bb23927
EZ
9306 (bidi_set_sor_type, bidi_resolve_explicit_1)
9307 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9308 can now be zero (for strings); special values 0 and -1 were
9309 changed to -1 and -2, respectively.
9310 (bidi_char_at_pos): New function.
9311 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9312 Call it instead of FETCH_MULTIBYTE_CHAR.
9313 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9314 initialized to valid values.
9315 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9316 values.
9317 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9318 the test for valid cached positions. Fix the logic for looking up
9319 the sentinel state in the cache. GCPRO the Lisp string we are
9320 iterating.
9321 (bidi_push_it, bidi_pop_it): New functions.
9322 (bidi_initialize): Initialize the bidi cache start stack pointer.
9323 (bidi_cache_ensure_space): New function, refactored from part of
9324 bidi_cache_iterator_state. Don't assume the required size is just
9325 one BIDI_CACHE_CHUNK away.
9326 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9327 (bidi_count_bytes, bidi_char_at_pos): New functions.
9328 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9329 always valid if bidi_cache_idx is valid.
9330 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9331 is valid if it's going to be used.
9332 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9333 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9334 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9335 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9336 (bidi_find_other_level_edge, bidi_cache_start_stack):
9337 All variables related to cache indices are now EMACS_INT.
c965adc5 9338
0bb23927
EZ
9339 * dispextern.h (struct bidi_string_data): New structure.
9340 (struct bidi_it): New member `string'. Make flag members be 1-bit
9341 fields, and put them last in the struct.
640c8776
SM
9342 (compute_display_string_pos, compute_display_string_end):
9343 Update prototypes.
0bb23927
EZ
9344 (bidi_push_it, bidi_pop_it): Add prototypes.
9345 (struct iterator_stack_entry): New members bidi_p,
9346 paragraph_embedding, and from_disp_prop_p.
9347 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9348 (bidi_shelve_cache, bidi_unshelve_cache):
9349 Declare prototypes.
0bb23927
EZ
9350
9351 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9352 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9353 and vector-like objects.
9354
9355 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9356 cache around display iteration.
9357
9358 * window.c (Fwindow_end, window_scroll_pixel_based)
9359 (displayed_window_lines, Frecenter): Save and restore the bidi
9360 cache around display iteration.
9361
3bbd2265
LMI
93622011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9363
9364 * editfns.c (Fdelete_region): Clarify the use of the named
9365 parameters (bug#6788).
9366
adc47434
MR
93672011-07-14 Martin Rudalics <rudalics@gmx.at>
9368
9369 * indent.c (Fvertical_motion): Set and restore w->pointm when
9370 saving and restoring the window's buffer (Bug#9006).
9371
837c31f8
LMI
93722011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9373
9374 * editfns.c (Fstring_to_char): Clarify just what is returned
9375 (bug#6576). Text by Eli Zaretskii.
9376
ac389d0c
JB
93772011-07-13 Juanma Barranquero <lekktu@gmail.com>
9378
9379 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9380
0be0ce47
EZ
93812011-07-13 Eli Zaretskii <eliz@gnu.org>
9382
9383 * buffer.c (mmap_find): Fix a typo.
9384
cd18e7e3
JB
93852011-07-13 Johan Bockgård <bojohan@gnu.org>
9386
9387 Fix execution of x selection hooks.
9388 * xselect.c (Qx_lost_selection_functions)
9389 (Qx_sent_selection_functions): New vars.
9390 (syms_of_xselect): DEFSYM them.
9391 (x_handle_selection_request): Pass Qx_sent_selection_functions
9392 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9393 (x_handle_selection_clear,x_clear_frame_selections):
9394 Pass Qx_lost_selection_functions rather than
9395 Vx_lost_selection_functions to Frun_hook_with_args.
9396
47ea7f44
PE
93972011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9398
ac389d0c 9399 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9400 The old code sometimes used this field without initializing it.
9401
47ea7f44
PE
9402 * alloc.c (gc_sweep): Don't read past end of array.
9403 In theory, the old code could also have corrupted Emacs internals,
9404 though it'd be very unlikely.
9405
bc985c87
AS
94062011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9407
9408 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9409 argument. (Bug#4026)
bc985c87 9410
0cf34688
LMI
94112011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9412
b3dadd76
LMI
9413 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9414 key" (bug#4257).
9415
0cf34688
LMI
9416 * window.c (Fset_window_start): Doc fix (bug#4199).
9417 (Fset_window_hscroll): Ditto.
9418
270768cd
PE
94192011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9420
077e3dda 9421 Fix minor new problems caught by GCC 4.6.1.
270768cd 9422 * term.c (init_tty): Remove unused local.
490011a6 9423 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9424 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9425 not used otherwise.
270768cd 9426
b1f58454
CY
94272011-07-12 Chong Yidong <cyd@stupidchicken.com>
9428
9429 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9430
22b9578d
LMI
94312011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9432
6e70ab07
LMI
9433 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9434 are the mini-buffer and the echo area (bug#3320).
9435
22b9578d
LMI
9436 * term.c (init_tty): Remove support for supdup, c10 and perq
9437 terminals, which are no longer supported (bug#1482).
9438
8974cc9f
JB
94392011-07-10 Johan Bockgård <bojohan@gnu.org>
9440
9441 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9442
a560d974
JD
94432011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9444
9445 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9446 for non-popups (Bug#3642).
9447
1dae0f0a
AS
94482011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9449
268c2c36 9450 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9451 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9452 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9453 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9454 * data.c (fmod): Likewise.
9455 * dispnew.c (swap_glyphs_in_rows): Likewise.
9456 * emacs.c (memory_warning_signal): Likewise.
9457 * floatfns.c (float_error): Likewise.
9458 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9459 (otf_open, font_otf_capability, generate_otf_features)
9460 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9461 Likewise.
9462 * image.c (pbm_read_file): Likewise.
9463 * indent.c (string_display_width): Likewise.
9464 * intervals.c (check_for_interval, search_for_interval)
9465 (inc_interval_count, count_intervals, root_interval)
9466 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9467 * lread.c (defalias): Likewise.
268c2c36 9468 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9469 * regex.c (set_image_of_range_1, set_image_of_range)
9470 (regex_grow_registers): Likewise.
9471 * sysdep.c (strerror): Likewise.
9472 * termcap.c (valid_filename_p, tprint, main): Likewise.
9473 * tparam.c (main): Likewise.
9474 * unexhp9k800.c (run_time_remap, save_data_space)
9475 (update_file_ptrs, read_header, write_header, calculate_checksum)
9476 (copy_file, copy_rest, display_header): Likewise.
9477 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9478 Likewise.
9479 * xdisp.c (check_it): Likewise.
9480 * xfaces.c (register_color, unregister_color, unregister_colors):
9481 Likewise.
9482 * xfns.c (print_fontset_result): Likewise.
9483 * xrdb.c (member, fatal, main): Likewise.
9484
99033785
PE
94852011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9486
9487 Fix minor problems found by static checking (Bug#9031).
9488 * chartab.c (char_table_set_range, map_sub_char_table):
9489 Remove unused locals.
9490 (uniprop_table): Now static.
9491 * composite.c (_work_char): Remove unused static var.
9492
9cb2ac56
JB
94932011-07-09 Juanma Barranquero <lekktu@gmail.com>
9494
9495 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9496
f25661f0
JD
94972011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9498
9499 * gtkutil.c (qttip_cb): Remove code without function.
9500
8278c4fe
EZ
95012011-07-09 Eli Zaretskii <eliz@gnu.org>
9502
9503 * w32.c (pthread_sigmask): New stub.
9504
1692ae2d 95052011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9506
8a6ebd58 9507 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9508 sigprocmask is portable only for single-threaded applications, and
9509 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9510 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9511 (LIBES): Use it.
9512 * callproc.c (Fcall_process):
9513 * process.c (create_process):
9514 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9515 Use pthread_sigmask, not sigprocmask.
123403e4 9516
1b854618
JD
95172011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9518
9519 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9520 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9521 wrong (Bug#8591).
9522
3fe4b549
JD
95232011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9524
0ce7e563
JD
9525 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9526 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9527 (xg_hide_tooltip): Fix comment.
9528
3fe4b549
JD
9529 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9530 in registerServicesMenuSendTypes.
9531 (validRequestorForSendType): Don't check ns_return_types.
9532
9533 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9534 ns_return_type.
9535
5df75e47
JR
95362011-07-08 Jason Rumney <jasonr@gnu.org>
9537
22610910
JR
9538 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9539 SH_SHOW for hidden windows (Bug#5482).
9540
5df75e47
JR
9541 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9542 frame struct members of non-existent frames (Bug#6284).
9543
699c10bd
JD
95442011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9545
4393663b
JD
9546 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9547 variable firstTime not needed on OSX >= 10.6.
9548 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9549 >= 10.5. Use setKnobProportion, setDoubleValue.
9550
9551 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9552 (MAC_OS_X_VERSION_10_5): Define if not defined.
9553 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9554 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9555 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9556
9557 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9558 cString and lossyCString on OSX >= 10.4.
4393663b 9559
58179cce 9560 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9561 sizeToFit on OSX >= 10.2.
9562
9563 * nsimage.m (allocInitFromFile): Don't use deprecated method
9564 bestRepresentationForDevice on OSX >= 10.6.
9565
9566 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9567 to avoid warning.
9568
9569 * emacs.c: Declare unexec_init_emacs_zone.
9570
a63e0781
JD
9571 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9572
699c10bd
JD
9573 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9574
9575 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9576 on svcsMenu (Bug#8842).
9577
9578 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9579 ns_return_types.
9580 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9581
9582 * nsterm.m (QUTF8_STRING): Declare.
9583 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9584 (validRequestorForSendType): Return type is (id).
9585 Change indexOfObjectIdenticalTo to indexOfObject.
9586 Check if we have local selection before returning self (Bug#8842).
9587 (writeSelectionToPasteboard): Put local selection into paste board
9588 if we have a local selection (Bug#8842).
9589 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9590
9591 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9592 (ns_get_local_selection): Declare.
9593
54e10184
LMI
95942011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9595
9888ff71
LMI
9596 * keymap.c (describe_map_tree): Don't insert a double newline at
9597 the end of the buffer (bug#1169) and return whether we inserted
9598 something.
9599
54e10184
LMI
9600 * callint.c (Fcall_interactively): Change "reading args" to
9601 "providing args" to try to clarify what it does (bug#1010).
9602
15fa4783
KH
96032011-07-07 Kenichi Handa <handa@m17n.org>
9604
9605 * composite.c (composition_compute_stop_pos): Ignore a static
9606 composition starting before CHARPOS (Bug#8915).
9607
9608 * xdisp.c (handle_composition_prop): Likewise.
9609
a8815b00
EZ
96102011-07-07 Eli Zaretskii <eliz@gnu.org>
9611
9612 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9613 (Bug#9015)
9614
ef7b981d 96152011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9616
9617 * character.h (unicode_category_t): New enum type.
9618
9619 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9620 (Qchar_code_property_table): New variable.
9621 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9622 (UNIPROP_COMPRESSED_FORM_P): New macros.
9623 (char_table_ascii): Uncompress the compressed values.
9624 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9625 Uncompress the compressed values.
ac389d0c 9626 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9627 (char_table_ref_and_range): Uncompress the compressed values.
9628 (sub_char_table_set): New arg is_uniprop. Callers changed.
9629 Uncompress the compressed values.
9630 (sub_char_table_set_range): Args changed. Callers changed.
9631 (char_table_set_range): Adjuted for the above change.
9632 (map_sub_char_table): Delete args default_val and parent. Add arg
9633 top. Give decoded values to a Lisp function.
640c8776 9634 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9635 values to a Lisp function. Gcpro more variables.
9636 (uniprop_table_uncompress)
9637 (uniprop_decode_value_run_length): New functions.
9638 (uniprop_decoder, uniprop_decoder_count): New variables.
9639 (uniprop_get_decoder, uniprop_encode_value_character)
9640 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9641 New functions.
9642 (uniprop_encoder, uniprop_encoder_count): New variables.
9643 (uniprop_get_encoder, uniprop_table)
9644 (Funicode_property_table_internal, Fget_unicode_property_internal)
9645 (Fput_unicode_property_internal): New functions.
9646 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9647 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9648 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9649 char-code-property-alist.
9650
640c8776 9651 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9652 Vunicode_category_table.
9653
640c8776 9654 * font.c (font_range): Adjust for the change of
c805dec0
KH
9655 Vunicode_category_table.
9656
76b397fb
DN
96572011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9658
9659 * m/iris4d.h: Remove file, move contents ...
9660 * s/irix6-5.h: ... here.
9661
22b4128e
PE
96622011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9663
9664 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9665 * alloc.c (mark_buffer):
9666 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9667 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9668 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9669 This isn't true in general, and it's particularly not true
9670 if Emacs is configured with --with-wide-int.
9671 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9672 New macros, used in the buffer.c change.
9673
869795d6
JD
96742011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9675
9676 * xsettings.c: Use both GConf and GSettings if both are available.
9677 (store_config_changed_event): Add comment.
9678 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9679 (store_tool_bar_style_changed): New functions.
5e617bc2 9680 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9681 (struct xsettings): Move font inside HAVE_XFT.
9682 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9683 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9684 Move inside HAVE_XFT.
640c8776 9685 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9686 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9687 also.
9688 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9689 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9690 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9691 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9692 (parse_settings): Move check for font inside HAVE_XFT.
9693 (read_settings, apply_xft_settings): Add comment.
9694 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9695 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9696 call store_font_name_changed.
9697 (xft_settings_event): Add comment.
9698 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9699 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9700 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9701 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9702 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9703 (xsettings_get_system_font, xsettings_get_system_normal_font):
9704 Add comment.
869795d6 9705
d8ed26bd
PE
97062011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9707
9708 Random fixes. E.g., (random) never returned negative values.
9709 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9710 subseconds part to the entropy, as that's a bit more random.
9711 Prefer signed to unsigned, since the signedness doesn't matter and
9712 in general we prefer signed. When given a limit, use a
9713 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9714 latter isn't right if USE_2_TAGS_FOR_INTS.
9715 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9716 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9717
cabf1cac
SM
97182011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9719
9720 * textprop.c (text_property_stickiness):
9721 Obey Vtext_property_default_nonsticky.
9722 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9723 * w32fns.c (syms_of_w32fns):
9724 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9725
6e9b2be9
PE
97262011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9727
9728 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9729 This is more efficient than Ffile_directory_p and avoids a minor race.
9730
90186c68
LMI
97312011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9732
7c301272
LMI
9733 * buffer.c (Foverlay_put): Say what the return value is
9734 (bug#7835).
9735
c4f2d8d4
LMI
9736 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9737 is a directory before asking whether to use the file name
9738 (bug#7564).
ad637907
LMI
9739 (barf_or_query_if_file_exists): Make the "File is a directory"
9740 error be more correct.
c4f2d8d4 9741
90186c68
LMI
9742 * fns.c (Frequire): Remove the mention of the .gz files, since
9743 that's installation-specific, but keep the mention of
9744 `get-load-suffixes'.
9745
da64016e
PE
97462011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9747
9748 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9749 Report string overflow if the output is too long.
9750
7d47b580
JB
97512011-07-04 Juanma Barranquero <lekktu@gmail.com>
9752
a555cb87
JB
9753 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9754 (syms_of_gnutls): Remove duplicate DEFSYM for
9755 Qgnutls_bootprop_verify_hostname_error, an error for
9756 Qgnutls_bootprop_verify_error (which is no longer used).
9757
7d47b580
JB
9758 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9759 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9760 Also (re)move comments that are misplaced or no longer relevant.
9761
1e49bfab
LMI
97622011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9763
9764 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9765
1485f4c0
CY
97662011-07-03 Chong Yidong <cyd@stupidchicken.com>
9767
9768 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9769 and background color parameters if they have been changed.
9770
a9ab721e
LMI
97712011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9772
9773 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9774
cf7cff57
PE
97752011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9776
2e13213d
PE
9777 * xsettings.c (SYSTEM_FONT): Define only when used.
9778 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9779
cf7cff57
PE
9780 * keymap.c (access_keymap_1): Now static.
9781
7a8e04f7
CY
97822011-07-02 Chong Yidong <cyd@stupidchicken.com>
9783
9784 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9785 leave any prefix arg for the up event (Bug#1586).
9786
61352f62
LMI
97872011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9788
69bb1ef7
LMI
9789 * lread.c (syms_of_lread): Mention single symbols defined by
9790 `defvar' or `defconst' (bug#7154).
9791
61352f62 9792 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9793 (Frequire): Mention get-load-suffixes.
61352f62 9794
28545e04
MR
97952011-07-02 Martin Rudalics <rudalics@gmx.at>
9796
9797 * window.h (window): Remove clone_number slot.
9798 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9799 Remove.
9800 (make_parent_window, make_window, saved_window)
9801 (Fset_window_configuration, save_window_save): Don't deal with
9802 clone numbers.
9803 * buffer.c (Qclone_number): Remove declaration.
9804 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9805
3349e122
SM
98062011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9807
9808 Add multiple inheritance to keymaps.
9809 * keymap.c (Fmake_composed_keymap): New function.
9810 (Fset_keymap_parent): Simplify.
9811 (fix_submap_inheritance): Remove.
9812 (access_keymap_1): New function extracted from access_keymap to handle
9813 embedded parents and handle lists of maps.
9814 (access_keymap): Use it.
9815 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9816 (Fcopy_keymap): Handle embedded parents.
9817 (Fcommand_remapping, define_as_prefix): Simplify.
9818 (Fkey_binding): Simplify.
9819 (syms_of_keymap): Move minibuffer-local-completion-map,
9820 minibuffer-local-filename-completion-map,
9821 minibuffer-local-must-match-map, and
9822 minibuffer-local-filename-must-match-map to Elisp.
9823 (syms_of_keymap): Defsubr make-composed-keymap.
9824 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9825 (parse_menu_item): Trivial simplification.
9826
3279eb87
GM
98272011-07-01 Glenn Morris <rgm@gnu.org>
9828
9829 * Makefile.in (SETTINGS_LIBS): Fix typo.
9830
4550efdf
KI
98312011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9832
9833 * coding.c (Fencode_coding_string): Record the last coding system
9834 used, as the function doc string says (bug#8738).
9835
0949d2b6
JD
98362011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9837
9838 * xsettings.c (store_monospaced_changed): Take new font as arg and
9839 check for change against current_mono_font.
9840 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9841 (emacs_settings_constructor, emacs_settings_get_property)
9842 (emacs_settings_set_property, emacs_settings_class_init)
9843 (emacs_settings_init, gsettings_obj): Remove.
9844 (something_changedCB): New function for HAVE_GSETTINGS.
9845 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9846 with value as argument.
9847 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9848 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9849 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9850 "changed".
9851
9852 * xgselect.c: Add defined (HAVE_GSETTINGS).
9853 (xgselect_initialize): Ditto.
9854
9855 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9856 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9857 xg_select.
9858
bbc6b304
PE
98592011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9860
9861 * eval.c (struct backtrace): Simplify and port the data structure.
9862 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9863 signed bit field, as this assumption is not portable and it makes
9864 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9865 "char debug_on_exit : 1" as this is not portable either; instead,
9866 use the portable "unsigned int debug_on_exit : 1". Remove unused
9867 member evalargs. Remove obsolete comments about cc bombing out.
9868
9851bfc5
JD
98692011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9870
51bb811f 9871 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9872 Let HAVE_GSETTINGS override HAVE_GCONF.
9873 (store_monospaced_changed): New function.
9874 (EMACS_SETTINGS): A new type derived from GObject to handle
9875 GSettings notifications.
9876 (emacs_settings_constructor, emacs_settings_get_property)
9877 (emacs_settings_set_property, emacs_settings_class_init):
9878 New functions.
9879 (gsettings_client, gsettings_obj): New variables.
9880 (GSETTINGS_SCHEMA): New define.
9881 (something_changedCB): Call store_monospaced_changed.
9882 (init_gsettings): New function.
9883 (xsettings_initialize): Call init_gsettings.
9884 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9885 to NULL.
9886
640c8776 9887 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9888 GCONF_CFLAGS/LIBS.
9889
5386012d
MR
98902011-06-29 Martin Rudalics <rudalics@gmx.at>
9891
9892 * window.c (resize_root_window, grow_mini_window)
9893 (shrink_mini_window): Rename Qresize_root_window to
9894 Qwindow_resize_root_window and Qresize_root_window_vertically to
9895 Qwindow_resize_root_window_vertically.
9896
f13e0b08
PE
98972011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9898
9899 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9900
94515237
JB
99012011-06-27 Juanma Barranquero <lekktu@gmail.com>
9902
9903 * makefile.w32-in: Redesign dependencies so they reflect more
9904 clearly which files are directly included by each source file,
9905 and not through other includes.
9906
e43b6e43
MR
99072011-06-27 Martin Rudalics <rudalics@gmx.at>
9908
9909 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9910 (sort_overlays, overlay_strings): When an overlay's clone number
9911 matches the window's clone number process the overlay even if
9912 the overlay's window property doesn't match the current window.
9913
d68443dc
MR
9914 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9915 (Fwindow_hchild): Rename to Fwindow_left_child.
9916 (Fwindow_next): Rename to Fwindow_next_sibling.
9917 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9918 (resize_window_check): Rename to window_resize_check.
9919 (resize_window_apply): Rename to window_resize_apply.
9920 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9921 (Fdelete_other_windows_internal, resize_frame_windows)
9922 (Fsplit_window_internal, Fdelete_window_internal)
9923 (grow_mini_window, shrink_mini_window)
9924 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9925
c7e73be5
JD
99262011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9927
9928 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9929 (emacs_fixed_set_min_size): Remove.
9930 (emacs_fixed_new): Take frame as argument.
9931
9932 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9933 (_EmacsFixedPrivate): Remove minwidth/height.
9934 Add struct frame *f.
9935 (emacs_fixed_init): Initialize priv->f.
9936 (get_parent_class, emacs_fixed_set_min_size): Remove.
9937 (emacs_fixed_new): Set priv->f to argument.
9938 (emacs_fixed_get_preferred_width)
9939 (emacs_fixed_get_preferred_height): Use min_width/height from
9940 frames size_hint to set minimum and natural (Bug#8919).
9941 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9942 and use min_width/height from frames size_hint to set
9943 min_width/height (Bug#8919).
9944
9945 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9946 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9947 Fix indentation.
c7e73be5 9948
cf99dcf8
EZ
99492011-06-26 Eli Zaretskii <eliz@gnu.org>
9950
9951 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9952 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9953 called at ZV.
9954
029529ac
CY
99552011-06-26 Chong Yidong <cyd@stupidchicken.com>
9956
9957 * process.c (wait_reading_process_output): Bypass select if
9958 waiting for a cell while ignoring keyboard input, and input is
9959 pending. Suggested by Jan Djärv (Bug#8869).
9960
7a7ef429
PE
99612011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9962
9963 Use gnulib's dup2 module instead of rolling our own.
9964 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9965
11fdef7d 99662011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9967
9968 * dispnew.c (scrolling_window): Before scrolling, turn off a
9969 mouse-highlight in the window being scrolled.
9970
cd3520a4
JB
99712011-06-24 Juanma Barranquero <lekktu@gmail.com>
9972
9973 Move DEFSYM to lisp.h and use everywhere.
9974
9975 * character.h (DEFSYM): Move declaration...
9976 * lisp.h (DEFSYM): ...here.
9977
9978 * gnutls.c:
9979 * minibuf.c:
9980 * w32menu.c:
9981 * w32proc.c:
9982 * w32select.c: Don't include character.h.
9983
9984 * alloc.c (syms_of_alloc):
9985 * buffer.c (syms_of_buffer):
9986 * bytecode.c (syms_of_bytecode):
9987 * callint.c (syms_of_callint):
9988 * casefiddle.c (syms_of_casefiddle):
9989 * casetab.c (init_casetab_once):
9990 * category.c (init_category_once, syms_of_category):
9991 * ccl.c (syms_of_ccl):
9992 * cmds.c (syms_of_cmds):
9993 * composite.c (syms_of_composite):
9994 * dbusbind.c (syms_of_dbusbind):
9995 * dired.c (syms_of_dired):
9996 * dispnew.c (syms_of_display):
9997 * doc.c (syms_of_doc):
9998 * editfns.c (syms_of_editfns):
9999 * emacs.c (syms_of_emacs):
10000 * eval.c (syms_of_eval):
10001 * fileio.c (syms_of_fileio):
10002 * fns.c (syms_of_fns):
10003 * frame.c (syms_of_frame):
10004 * fringe.c (syms_of_fringe):
10005 * insdel.c (syms_of_insdel):
10006 * keymap.c (syms_of_keymap):
10007 * lread.c (init_obarray, syms_of_lread):
10008 * macros.c (syms_of_macros):
10009 * msdos.c (syms_of_msdos):
10010 * print.c (syms_of_print):
10011 * process.c (syms_of_process):
10012 * search.c (syms_of_search):
10013 * sound.c (syms_of_sound):
10014 * syntax.c (init_syntax_once, syms_of_syntax):
10015 * terminal.c (syms_of_terminal):
10016 * textprop.c (syms_of_textprop):
10017 * undo.c (syms_of_undo):
10018 * w32.c (globals_of_w32):
10019 * window.c (syms_of_window):
10020 * xdisp.c (syms_of_xdisp):
10021 * xfaces.c (syms_of_xfaces):
10022 * xfns.c (syms_of_xfns):
10023 * xmenu.c (syms_of_xmenu):
10024 * xsettings.c (syms_of_xsettings):
10025 * xterm.c (syms_of_xterm): Use DEFSYM.
10026
4228cf16
TZ
100272011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10028
cd3520a4 10029 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10030
7fcccf1e
PE
100312011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10032
7efb4e0e
PE
10033 Integer and buffer overflow fixes (Bug#8873).
10034
ff5844ad
PE
10035 * print.c (printchar, strout): Check for string overflow.
10036 (PRINTPREPARE, printchar, strout):
10037 Don't set size unless allocation succeeds.
10038
90532f02
PE
10039 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10040 for sizes. Check for string overflow more accurately.
10041 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10042
6d84508d
PE
10043 * macros.c: Integer and buffer overflow fixes.
10044 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10045 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10046 Use ptrdiff_t, not int, for sizes.
10047 Don't increment bufsize until after realloc succeeds.
10048 Check for size-calculation overflow.
10049 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10050
437b2cb4
PE
10051 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10052
8b9ac8b4
PE
10053 * lread.c: Integer overflow fixes.
10054 (read_integer): Radix is now EMACS_INT, not int,
10055 to improve quality of diagnostics for out-of-range radices.
10056 Calculate buffer size correctly for out-of-range radices.
10057 (read1): Check for integer overflow in radices, and in
10058 read-circle numbers.
82cb60d3
PE
10059 (read_escape): Avoid int overflow.
10060 (Fload, openp, read_buffer_size, read1)
10061 (substitute_object_recurse, read_vector, read_list, map_obarray):
10062 Use ptrdiff_t, not int, for sizes.
10063 (read1): Use EMACS_INT, not int, for sizes.
20270765 10064 Check for size overflow.
8b9ac8b4 10065
7fcccf1e
PE
10066 * image.c (cache_image): Check for size arithmetic overflow.
10067
bfbbd7e7
PE
10068 * lread.c: Integer overflow issues.
10069 (saved_doc_string_size, saved_doc_string_length)
10070 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10071 Now ptrdiff_t, not int.
10072 (read1): Don't assume doc string length fits in int. Check for
10073 out-of-range doc string lengths.
10074 (read_list): Don't assume file position fits in int.
39019e54 10075 (read_escape): Check for hex character overflow.
bfbbd7e7 10076
4e323265
LL
100772011-06-22 Leo Liu <sdl.web@gmail.com>
10078
10079 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10080 Move to minibuffer.el.
10081
85fece3e
PE
100822011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10083
20b84ce9 10084 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10085 The following patches are for when GLYPH_DEBUG && !XASSERT.
10086 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10087 * dispnew.c (flush_stdout):
10088 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10089 Mark as externally visible.
10090 * dispnew.c (check_window_matrix_pointers): Now static.
10091 * dispnew.c (window_to_frame_vpos):
10092 * xfns.c (unwind_create_frame):
10093 * xterm.c (x_check_font): Remove unused local.
10094 * scroll.c (CHECK_BOUNDS):
10095 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10096 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10097 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10098 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10099 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10100 Now static.
10101 (debug_method_add): Use va_list and vsprintf rather than relying
10102 on undefined behavior with wrong number of arguments.
10103 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10104 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10105 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10106 since we're not interested in debugging glyphs with old libraries.
10107 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10108 GCC 4.6.0's static checking.
10109
0766b489
PE
101102011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10111
31fd4b32
PE
10112 Integer overflow and signedness fixes (Bug#8873).
10113 A few related buffer overrun fixes, too.
10114
b79e8648
PE
10115 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10116
0766b489
PE
10117 * dispextern.h (struct face.stipple):
10118 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10119 (x_bitmap_mask, x_allocate_bitmap_record)
10120 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10121 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10122 (x_create_bitmap_from_xpm_data):
10123 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10124 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10125 (.bitmaps_last):
10126 * xfaces.c (load_pixmap):
10127 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10128 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10129 (.bitmaps_last, struct x_output.icon_bitmap):
10130 Use ptrdiff_t, not int, for bitmap indexes.
10131 (x_allocate_bitmap_record): Check for size overflow.
10132 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10133
b081724f
PE
10134 Use ptrdiff_t, not int, for overlay counts.
10135 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10136 * editfns.c (overlays_around, get_pos_property):
10137 * textprop.c (get_char_property_and_overlay):
10138 * xdisp.c (next_overlay_change, note_mouse_highlight):
10139 * xfaces.c (face_at_buffer_position):
21514da7
PE
10140 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10141 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10142 (Fnext_overlay_change, Fprevious_overlay_change)
10143 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10144 Use ptrdiff_t, not int, for sizes.
21514da7 10145 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10146
3de73e5e
PE
10147 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10148
2606c57b
PE
10149 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10150 (x_session_initialize): Do not assume string length fits in int.
10151
aaafe47a
PE
10152 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10153 This is unlikely, but can occur if DPI is outlandish.
10154
2674ddc8 10155 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10156 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10157
28154962
PE
10158 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10159 * xrdb.c (magic_file_p, search_magic_path):
10160 Omit last arg SUFFIX; it was always 0. All callers changed.
10161 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10162
7de51af5
PE
10163 * xfont.c (xfont_match): Avoid need for strlen.
10164
25ed6cc3
PE
10165 * xfns.c: Don't assume strlen fits in int.
10166 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10167
4eab31dd
PE
10168 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10169 not unsigned long, as we prefer signed integers. All callers changed.
10170 Detect integer overflow in repeat count.
10171 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10172 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10173
171e2a58
PE
10174 * termcap.c: Don't assume sizes fit in int and never overflow.
10175 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10176 (gobble_line): Check for size-calculation overflow.
10177
ad39faca 10178 * minibuf.c (Fread_buffer):
6e5bb2dc 10179 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10180 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10181 Don't assume string length fits in int.
10182
52c61c22 10183 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10184 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10185
b5b8c9e5
PE
10186 * font.c: Don't assume string length fits in int.
10187 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10188 Use ptrdiff_t, not int.
ccd6111c
PE
10189 (font_intern_prop): Don't assume string length fits in int.
10190 Don't assume integer property fits in fixnum.
10191 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10192
882f0d81 10193 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10194 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10195 Reformulate so as not to need the command string.
10196 Invoke gzip -cd rather than gunzip, as it's more portable.
10197 (lock_info_type, lock_file_1, lock_file):
10198 Don't assume pid_t and time_t fit in unsigned long.
10199 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10200 (current_lock_owner): Prefer signed type for sizes.
10201 Use memcpy, not strncpy, where memcpy is what is really wanted.
10202 Don't assume (via atoi) that time_t and pid_t fit in int.
10203 Check for time_t and/or pid_t out of range, e.g., via a network share.
10204 Don't alloca where an auto var works fine.
10205
93f4cf88
PE
10206 * fileio.c: Fix some integer overflow issues.
10207 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10208 Don't assume string length fits in int.
10209 (directory_file_name): Don't assume string length fits in long.
10210 (make_temp_name): Don't assume pid fits in int, or that its print
10211 length is less than 20.
10212
f3e92b69
PE
10213 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10214
1bfdaf10
PE
10215 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10216
35016e9a
PE
10217 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10218
3d1e65a1
PE
10219 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10220 We prefer signed integers, even for size calculations.
10221
0b963a93
PE
10222 * emacs.c: Don't assume string length fits in 'int'.
10223 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10224 (main): Don't invoke strlen when not needed.
10225
573f4b54
PE
10226 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10227 (XD_DEBUG_MESSAGE): Don't waste a byte.
10228
989f33ba
PE
10229 * callproc.c (getenv_internal_1, getenv_internal)
10230 (Fgetenv_internal):
965d34eb
PE
10231 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10232
e4d29b33
PE
10233 * lread.c (invalid_syntax): Omit length argument.
10234 All uses changed. This doesn't fix a bug, but it simplifies the
10235 code away from its former Hollerith-constant appearance, and it's
10236 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10237 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10238
eb49b136
PE
10239 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10240 This didn't break anything, but it didn't help either.
10241 It's confusing to put a bogus integer in a place where the actual
10242 value does not matter.
9f62aeb1 10243 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10244 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10245
15375a22
PE
10246 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10247 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10248 implementation.
b61cc01c
PE
10249 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10250 We prefer signed types, and the value cannot exceed the EMACS_INT
10251 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10252 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10253 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10254 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10255
53b2623d
PE
10256 * indent.c (sane_tab_width): New function.
10257 (current_column, scan_for_column, Findent_to, position_indentation)
10258 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10259 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10260
51cab52b 10261 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10262
f2ed8a70
PE
10263 * lisp.h (lint_assume): New macro.
10264 * composite.c (composition_gstring_put_cache):
10265 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10266
abe80cc6
PE
10267 * editfns.c, insdel.c:
10268 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10269
b02c740e
PE
10270 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10271
ebc96716
PE
10272 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10273
b4e50fa0 10274 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10275 Use much-faster test for byte-length change.
311d5d7c 10276 Don't assume string byte-length fits in 'int'.
a4cf38e4 10277 Check that character arg fits in 'int'.
85461888 10278 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10279
c0c1ee9f
PE
10280 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10281
a498d7f4
PE
10282 * fns.c (concat): Catch string overflow earlier.
10283 Do not rely on integer wraparound.
10284
51cab52b
PE
10285 * dispextern.h (struct it.overlay_strings_charpos)
10286 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10287 * xdisp.c (forward_to_next_line_start)
10288 (back_to_previous_visible_line_start)
10289 (reseat_at_next_visible_line_start, next_element_from_buffer):
10290 Don't arbitrarily truncate the value of 'selective' to int.
10291
76031fad
PE
10292 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10293
5eb55db9
PE
10294 * composite.c: Don't truncate sizes to 'int'.
10295 (composition_gstring_p, composition_reseat_it)
10296 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10297 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10298 not EMACS_UINT, for indexes.
5eb55db9 10299
0703a717
PE
10300 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10301
d6202519
PE
10302 * buffer.c: Include <verify.h>.
10303 (struct sortvec.priority, struct sortstr.priority):
8961a454 10304 Now EMACS_INT, not int.
c20998a7 10305 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10306 (struct sortstr.size, record_overlay_string)
10307 (struct sortstrlist.size, struct sortlist.used):
10308 Don't truncate size to int.
10309 (record_overlay_string): Check for size-calculation overflow.
d6202519 10310 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10311
d5a19415
JM
103122011-06-22 Jim Meyering <meyering@redhat.com>
10313
029529ac 10314 Don't leak an XBM-image-sized buffer
d5a19415
JM
10315 * image.c (xbm_load): Free the image buffer after using it.
10316
a9041e6c
PE
103172011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10318
10319 Port to Sun C.
10320 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10321 that Sun C diagnosed.
10322 * fns.c (secure_hash): Fix pointer signedness issue.
10323 * intervals.c (static_offset_intervals): New function.
10324 (offset_intervals): Use it.
10325
7f3f739f
LL
103262011-06-21 Leo Liu <sdl.web@gmail.com>
10327
10328 * deps.mk (fns.o):
10329 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10330 sha512.h.
10331
10332 * fns.c (secure_hash): Rename from crypto_hash_function and change
10333 the first arg to accept symbols.
5b66d427 10334 (Fsecure_hash): New primitive.
7f3f739f
LL
10335 (syms_of_fns): New symbols.
10336
76147d94
DD
103372011-06-20 Deniz Dogan <deniz@dogan.se>
10338
10339 * process.c (Fset_process_buffer): Clarify return value in
10340 docstring.
10341
7d7d0045
CY
103422011-06-18 Chong Yidong <cyd@stupidchicken.com>
10343
10344 * dispnew.c (add_window_display_history): Use BVAR.
10345
10346 * xdisp.c (debug_method_add): Use BVAR.
10347 (check_window_end, dump_glyph_matrix, dump_glyph)
10348 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10349
10350 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10351 Likewise.
10352
10353 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10354 check till after the cache is created in init_frame_faces.
10355
ff2bc410
SM
103562011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10357
10358 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10359
28177add
PE
103602011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10361
dd3482fe
PE
10362 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10363 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10364 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10365
393d71f3 10366 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10367 * fileio.c (Finsert_file_contents):
10368 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10369 Remove the old (too-loose) buffer overflow checks.
10370 They weren't needed, since make_gap checks for buffer overflow.
10371 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10372 The old code merely checked for Emacs fixnum overflow, and relied
10373 on undefined (wraparound) behavior. The new code avoids undefined
10374 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10375
2e6813b0 10376 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10377 Tune. Don't use wider integers than needed. Don't use alloca.
10378 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10379
599a9e4f
PE
10380 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10381
99561444
PE
10382 * insdel.c, lisp.h (buffer_overflow): New function.
10383 (insert_from_buffer_1, replace_range, replace_range_2):
10384 * insdel.c (make_gap_larger):
10385 * editfns.c (Finsert_char):
10386 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10387
28177add
PE
10388 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10389
e69dafad
PE
103902011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10391
4baa020d 10392 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10393
b1c46f02
PE
10394 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10395 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10396
e69dafad
PE
10397 * fileio.c: Don't assume EMACS_INT fits in off_t.
10398 (emacs_lseek): New static function.
10399 (Finsert_file_contents, Fwrite_region): Use it.
10400 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10401
566684ea
PE
10402 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10403
e6966cd6
PE
10404 * fns.c: Don't overflow int when computing a list length.
10405 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10406 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10407 truncation on 64-bit hosts. Check for QUIT every
10408 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10409 faster and is responsive enough.
10410 (Flength): Report an error instead of overflowing an integer.
10411 (Fsafe_length): Return a float if the value is not representable
10412 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10413 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10414 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10415
dd0b0efb
PE
10416 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10417 (header_size, word_size): New constants.
10418 (allocate_vectorlike): Don't check size overflow here.
10419 (allocate_vector): Check it here instead, since this is the only
10420 caller of allocate_vectorlike that could cause overflow.
10421 Check that the new vector's length is representable as a fixnum.
10422
86fe5cfe
PE
10423 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10424 The previous code was bogus. For example, next_almost_prime (32)
10425 returned 39, which is undesirable as it is a multiple of 3; and
10426 next_almost_prime (24) returned 25, which is a multiple of 5 so
10427 why was the code bothering to check for multiples of 7?
10428
80e88859
PE
10429 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10430
4a2f0ad6
PE
10431 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10432
f66c7cf8
PE
10433 Variadic C functions now count arguments with ptrdiff_t.
10434 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10435 Back then I didn't know that the Emacs coding style prefers signed int.
10436 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10437 were being counted with int, which may truncate counts on 64-bit
10438 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10439 * lisp.h (struct Lisp_Subr.function.aMANY)
10440 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10441 Arg counts are now ptrdiff_t, not size_t.
10442 All variadic functions and their callers changed accordingly.
10443 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10444 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10445 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10446 * callint.c (Fcall_interactively): Check arg count for overflow,
10447 to avoid potential buffer overrun. Use signed char, not 'int',
10448 for 'varies' array, so that we needn't bother to check its size
10449 calculation for overflow.
10450 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10451 * eval.c (apply_lambda):
10452 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10453 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10454 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10455
a1759b76
PE
10456 * callint.c (Fcall_interactively): Don't use index var as event count.
10457
d96be9fc
PE
10458 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10459 * mem-limits.h (SIZE): Remove; no longer used.
10460
a690a978 10461 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10462
578c21e6
PE
10463 Remove unnecessary casts.
10464 * xterm.c (x_term_init):
10465 * xfns.c (x_set_border_pixel):
10466 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10467 These aren't needed now that we assume ANSI C.
10468
96f53c6c
PE
10469 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10470 It's more likely to cause problems (due to unsigned overflow)
10471 than to cure them.
10472
83c77d31
PE
10473 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10474
ee2079f1
PE
10475 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10476
6da65536
PE
10477 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10478
7147c4a4
PE
10479 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10480
193e32d9
PE
10481 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10482
e5533da6
PE
10483 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10484
9910e595
PE
10485 GLYPH_CODE_FACE returns EMACS_INT, not int.
10486 * dispextern.h (merge_faces):
10487 * xfaces.c (merge_faces):
01103c44
PE
10488 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10489 Don't assume EMACS_INT fits in int.
9910e595 10490
2638320e
PE
10491 * character.h (CHAR_VALID_P): Remove unused parameter.
10492 * fontset.c, lisp.h, xdisp.c: All uses changed.
10493
045eb8d9
PE
10494 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10495
c1f134b5
PE
10496 * fns.c (concat): Minor tuning based on overflow analysis.
10497 This doesn't fix any bugs. Use int to hold character, instead
10498 of constantly refetching from Emacs object. Use XFASTINT, not
10499 XINT, for value known to be a character. Don't bother comparing
10500 a single byte to 0400, as it's always less.
10501
395fcb93 10502 * floatfns.c (Fexpt):
327eeec8
PE
10503 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10504
abbd3d23
PE
10505 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10506 for characters.
10507
684a03ef
PE
10508 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10509
0fed43f3
PE
10510 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10511 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10512 incorrectly succeed when S was a string, because 4294967386 was
10513 truncated before it was used.
10514
8fd02eb7
PE
10515 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10516 Otherwise, an out-of-range integer could cause undefined behavior
10517 on a 64-bit host.
10518
f8c86b69
PE
10519 * composite.c: Use int, not EMACS_INT, for characters.
10520 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10521 EMACS_INT, for values that are known to be in character range.
10522 This doesn't fix any bugs but is the usual style inside Emacs and
10523 may generate better code on 32-bit machines.
10524
34206dd2
PE
10525 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10526 This is for reasons similar to the recent CHAR_STRING fix.
10527 * charset.c (Fencode_char): Check that character arg is actually
10528 a character. Pass an int to ENCODE_CHAR.
10529 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10530 wider than 'int', as a compile-time check to prevent future regressions
10531 in this area.
10532
c5958d4c 10533 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10534
10535 Make sure a 64-bit char is never passed to CHAR_STRING.
10536 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10537 by silently ignoring the top 32 bits, allowing some values
10538 that were far too large to be valid characters.
10539 * character.h: Include <verify.h>.
10540 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10541 arguments are no wider than unsigned, as a compile-time check
10542 to prevent future regressions in this area.
10543 * data.c (Faset):
01103c44 10544 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10545 (Fsubst_char_in_region):
10546 * fns.c (concat):
10547 * xdisp.c (decode_mode_spec_coding):
10548 Adjust to CHAR_STRING's new requirement.
10549 * editfns.c (Finsert_char, Fsubst_char_in_region):
10550 * fns.c (concat): Check that character args are actually
10551 characters. Without this test, these functions did the wrong
10552 thing with wildly out-of-range values on 64-bit hosts.
10553
d37ca623
PE
10554 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10555 These casts should not be needed on 32-bit hosts, either.
10556 * keyboard.c (read_char):
10557 * lread.c (Fload): Remove casts to unsigned.
10558
ea204efb
PE
10559 * lisp.h (UNSIGNED_CMP): New macro.
10560 This fixes comparison bugs on 64-bit hosts.
10561 (ASCII_CHAR_P): Use it.
10562 * casefiddle.c (casify_object):
01103c44 10563 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10564 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10565 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10566 * dispextern.h (FACE_FROM_ID):
10567 * keyboard.c (read_char): Use UNSIGNED_CMP.
10568
41cb286c
PE
10569 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10570 not to EMACS_INT, to avoid GCC warning.
10571
4a1b9832
PE
10572 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10573
55daad71
PE
10574 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10575 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10576 isn't needed on 32-bit machines.
8f95c75c 10577
01103c44
PE
10578 * buffer.c (Fgenerate_new_buffer_name):
10579 Use EMACS_INT for count, not int.
0ceccced 10580 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10581
10582 * data.c (Qcompiled_function): Now static.
10583
c6f072e7
PE
10584 * window.c (window_body_lines): Now static.
10585
20ce5912
PE
10586 * image.c (gif_load): Rename local to avoid shadowing.
10587
9c4c5f81
PE
10588 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10589 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10590 * alloc.c (make_save_value): Integer argument is now of type
10591 ptrdiff_t, not int.
10592 (mark_object): Use ptrdiff_t, not int.
10593 * lisp.h (pD): New macro.
10594 * print.c (print_object): Use it.
10595
c0c5c8ae
PE
10596 * alloc.c: Use EMACS_INT, not int, to count objects.
10597 (total_conses, total_markers, total_symbols, total_vector_size)
10598 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10599 (total_free_floats, total_floats, total_free_intervals)
10600 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10601 Now EMACS_INT, not int. All uses changed.
10602 (Fgarbage_collect): Compute overall total using a double, so that
10603 integer overflow is less likely to be a problem. Check for overflow
10604 when converting back to an integer.
5a25e253
PE
10605 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10606 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10607 These were 'int' variables that could overflow on 64-bit hosts;
10608 they were never used, so remove them instead of repairing them.
211a0b2a 10609 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10610 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10611 Previously, this ceilinged at INT_MAX, but that doesn't work on
10612 64-bit machines.
e46bb31a 10613 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10614
c78baabf 10615 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10616 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10617 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10618 when a (possibly-narrower) signed value would do just as well.
10619 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10620
c9d624c6
PE
10621 * alloc.c: Catch some string size overflows that we were missing.
10622 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10623 for convenience in STRING_BYTES_MAX.
10624 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10625 The definition here is exact; the one in lisp.h was approximate.
10626 (allocate_string_data): Check for string overflow. This catches
10627 some instances we weren't catching before. Also, it catches
10628 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10629 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10630 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10631
c9d624c6
PE
10632 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10633 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10634 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10635
353032ce
PE
10636 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10637
2bccce07
PE
10638 * alloc.c (Fmake_string): Check for out-of-range init.
10639
0ac30604
SM
106402011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10641
10642 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10643
c195f2de
JD
106442011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10645
10646 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10647 xg_get_default_scrollbar_width.
10648
10649 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10650 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10651 (style_changed_cb): Call update_theme_scrollbar_width and call
10652 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10653 all frames (Bug#8505).
10654 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10655 Call gtk_window_set_resizable if HAVE_GTK3.
10656 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10657 and height if HAVE_GTK3 (Bug#8505).
10658 (scroll_bar_width_for_theme): New variable.
10659 (update_theme_scrollbar_width): New function.
10660 (xg_get_default_scrollbar_width): Move code to
10661 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10662 (xg_initialize): Call update_theme_scrollbar_width.
10663
10664 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10665
10666 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10667
e10ac9f1
MR
106682011-06-12 Martin Rudalics <rudalics@gmx.at>
10669
10670 * frame.c (make_frame): Call other_buffer_safely instead of
10671 other_buffer.
10672
10673 * window.c (temp_output_buffer_show): Call display_buffer with
10674 second argument Vtemp_buffer_show_specifiers and reset latter
10675 immediately after the call.
10676 (Vtemp_buffer_show_specifiers): New variable.
10677 (auto_window_vscroll_p, next_screen_context_lines)
10678 (Vscroll_preserve_screen_position): Remove leading asterisks from
10679 doc-strings.
10680
2d3c217e 106812011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10682
7b7f97e8 10683 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10684 * buffer.c (Qclone_number): Remove for now, as it's unused.
10685 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10686 (record_buffer): Remove unused local.
10687 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10688 (set_frame_buffer_list): Remove; unused.
10689 * frame.h (other_visible_frames): Remove decl.
10690 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10691 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10692 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10693 if HAVE_GPM.
10694 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10695 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10696 Define only if HAVE_GPM.
10697 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10698 (update_hints_inhibit): Remove; never set. All uses removed.
10699 * widgetprv.h (emacsFrameClassRec): Remove decl.
10700 * window.c (delete_deletable_window): Now returns void, since it
10701 wasn't returning anything.
10702 (compare_window_configurations): Remove unused locals.
10703 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10704 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10705 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10706 the same widths as pointers. This follows up on the 2011-05-06 patch.
10707 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10708 * xterm.h: Likewise.
10709 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10710
1384b89e
JB
107112011-06-12 Juanma Barranquero <lekktu@gmail.com>
10712
10713 * makefile.w32-in: Update dependencies.
10714 (LISP_H): Add lib/intprops.h.
10715
1100a63c
CY
107162011-06-11 Chong Yidong <cyd@stupidchicken.com>
10717
10718 * image.c (gif_load): Add animation frame delay to the metadata.
10719 (syms_of_image): Use DEFSYM. New symbol `delay'.
10720
6198ccd0
MR
107212011-06-11 Martin Rudalics <rudalics@gmx.at>
10722
10723 * window.c (delete_deletable_window): Re-add.
10724 (Fset_window_configuration): Rewrite to handle dead buffers and
10725 consequently deletable windows.
10726 (window_tree, Fwindow_tree): Remove. Supply functionality in
10727 window.el.
10728 (compare_window_configurations): Simplify code.
10729
b6e3633c
AS
107302011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10731
1ab0dee5
AS
10732 * image.c (imagemagick_load_image): Fix type mismatch.
10733 (Fimagemagick_types): Likewise.
10734
b6e3633c
AS
10735 * window.h (replace_buffer_in_windows): Declare.
10736
9397e56f
MR
107372011-06-11 Martin Rudalics <rudalics@gmx.at>
10738
10739 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10740 Qclone_number. Remove external declaration of Qdelete_window.
10741 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10742 code.
640c8776
SM
10743 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10744 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10745 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10746 buffer list implementation.
10747 (other_buffer_safely): New function.
10748 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10749 calls to replace_buffer_in_windows and
10750 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10751 if allowed.
10752 (record_buffer): Inhibit quitting and rewrite using quittable
10753 functions. Run Qbuffer_list_update_hook if allowed.
10754 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10755 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10756 Move switch-to-buffer to window.el.
9397e56f
MR
10757 (bury-buffer): Move to window.el.
10758 (Vbuffer_list_update_hook): New variable.
10759
10760 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10761 section.
10762
10763 * window.h (resize_frame_windows): Move up in code.
10764 (Fwindow_frame): Remove EXFUN.
10765 (replace_buffer_in_all_windows): Remove prototype.
10766 (replace_buffer_in_windows_safely): Add prototype.
10767
10768 * window.c: Declare Qdelete_window static again. Move down
10769 declaration of select_count.
10770 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10771 (Fother_window): Move to window.el.
10772 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10773 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10774 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10775 window.el.
10776 (replace_buffer_in_windows): Implement by calling
10777 Qreplace_buffer_in_windows.
10778 (replace_buffer_in_all_windows): Remove with some functionality
10779 moved into replace_buffer_in_windows_safely.
10780 (replace_buffer_in_windows_safely): New function.
10781 (select_window_norecord, select_frame_norecord): Move in front
10782 of run_window_configuration_change_hook. Remove now obsolete
10783 declarations.
640c8776
SM
10784 (Fset_window_buffer): Rewrite doc-string.
10785 Call Qrecord_window_buffer.
9397e56f
MR
10786 (keys_of_window): Move binding for other-window to window.el.
10787
b50691aa
CY
107882011-06-11 Chong Yidong <cyd@stupidchicken.com>
10789
10790 * dispextern.h (struct image): Replace data member, whose int_val
10791 and ptr_val fields were not used by anything, with a single
10792 lisp_val object.
10793
10794 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10795 (gif_clear_image, gif_load, imagemagick_load_image)
10796 (gs_clear_image, gs_load): Callers changed.
10797
3f754b86
PE
107982011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10799
cca69397
PE
10800 * buffer.h: Include <time.h>, for time_t.
10801 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10802
109e28d0
PE
10803 Fix minor problems found by static checking.
10804
60737f02
PE
10805 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10806
4b66faf3
PE
10807 Make identifiers static if they are not used in other modules.
10808 * data.c (Qcompiled_function, Qframe, Qvector):
10809 * image.c (QimageMagick, Qsvg):
10810 * minibuf.c (Qmetadata):
10811 * window.c (resize_window_check, resize_root_window): Now static.
10812 * window.h (resize_window_check, resize_root_window): Remove decls.
10813
109e28d0
PE
10814 * window.c (window_deletion_count, delete_deletable_window):
10815 Remove; unused.
46a4ce9e
PE
10816 (window_body_lines): Now static.
10817 (Fdelete_other_windows_internal): Mark vars as initialized.
10818 Make sure 'resize_failed' is initialized.
10819 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10820 (resize_window_apply): Remove unused local.
10821 * window.h (delete_deletable_window): Remove decl.
10822
109e28d0 10823 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10824 (imagemagick_load_image): Fix pointer signedness problem by changing
10825 last arg from unsigned char * to char *. All uses changed.
10826 Also, fix a local for similar reasons.
10827 Remove unused locals. Remove locals to avoid shadowing.
10828 (fn_rsvg_handle_free): Remove; unused.
10829 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10830 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10831
3f754b86
PE
10832 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10833
2547adb1
CY
108342011-06-10 Chong Yidong <cyd@stupidchicken.com>
10835
10836 * image.c (gif_load): Fix omitted cast error introduced by
10837 2011-06-06 change.
10838
2c8e37d4
MR
108392011-06-10 Martin Rudalics <rudalics@gmx.at>
10840
10841 * window.h (resize_proportionally, orig_total_lines)
10842 (orig_top_line): Remove from window structure.
10843 (set_window_height, set_window_width, change_window_heights)
10844 (Fdelete_window): Remove prototypes.
10845 (resize_frame_windows): Remove duplicate declaration.
10846
440a42e3
EZ
108472011-06-10 Eli Zaretskii <eliz@gnu.org>
10848
10849 * window.h (resize_frame_windows, resize_window_check)
10850 (delete_deletable_window, resize_root_window)
10851 (resize_frame_windows): Declare prototypes.
10852
10853 * window.c (resize_window_apply): Make definition be "static" to
10854 match the prototype.
10855
562dd5e9
MR
108562011-06-10 Martin Rudalics <rudalics@gmx.at>
10857
10858 * window.c: Remove declarations of Qwindow_size_fixed,
10859 window_min_size_1, window_min_size_2, window_min_size,
10860 size_window, window_fixed_size_p, enlarge_window, delete_window.
10861 Remove static from declaration of Qdelete_window, it's
10862 temporarily needed by Fbury_buffer.
10863 (replace_window): Don't assign orig_top_line and
10864 orig_total_lines.
10865 (Fdelete_window, delete_window): Remove. Window deletion is
10866 handled by window.el.
640c8776
SM
10867 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10868 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10869 (Fdelete_other_windows): Remove. Deleting other windows is
10870 handled by window.el.
10871 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10872 handled in window.el.
10873 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10874 Window minimum sizes are handled in window.el.
10875 (shrink_windows, size_window, set_window_height)
10876 (set_window_width, change_window_heights, window_height)
10877 (window_width, CURBEG, CURSIZE, enlarge_window)
10878 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10879 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10880 handled in window.el.
10881 (make_dummy_parent): Rename to make_parent_window and give it a
10882 second argument horflag.
10883 (make_window): Don't set resize_proportionally any more.
10884 (Fsplit_window): Remove. Windows are split in window.el.
10885 (save_restore_action, save_restore_orig_size)
10886 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10887 Resize mini windows in window.el.
10888 (grow_mini_window, shrink_mini_window): Implement by calling
10889 Qresize_root_window_vertically, resize_window_check and
10890 resize_window_apply.
640c8776
SM
10891 (saved_window, Fset_window_configuration, save_window_save):
10892 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10893 resize_proportionally.
10894 (window_min_height, window_min_width): Move to window.el.
10895 (keys_of_window): Move bindings for delete-other-windows,
10896 split-window, delete-window and enlarge-window to window.el.
10897
10898 * buffer.c: Temporarily extern Qdelete_window.
10899 (Fbury_buffer): Temporarily call Qdelete_window instead of
10900 Fdelete_window (Fbury_buffer will move to window.el soon).
10901
10902 * frame.c (set_menu_bar_lines_1): Remove code handling
10903 orig_top_line and orig_total_lines.
10904
10905 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10906 set_window_height but set heights directly.
10907 (change_frame_size_1): Use resize_frame_windows.
10908
10909 * xdisp.c (init_xdisp): Don't use set_window_height but set
10910 heights directly.
10911
640c8776
SM
10912 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10913 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10914 run_window_configuration_change_hook.
10915
10916 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10917 instead of change_window_heights and run
10918 run_window_configuration_change_hook.
10919
1a13852e
MR
109202011-06-09 Martin Rudalics <rudalics@gmx.at>
10921
10922 * window.c (replace_window): Rename second argument REPLACEMENT to
10923 NEW. New third argument SETFLAG. Rewrite.
10924 (delete_window, make_dummy_parent): Call replace_window with
10925 third argument 1.
10926 (window_list_1): Move down in code.
10927 (run_window_configuration_change_hook): Move set_buffer part
10928 before select_frame_norecord part in order to unwind correctly.
10929 Rename count1 to count.
10930 (recombine_windows, delete_deletable_window, resize_root_window)
10931 (Fdelete_other_windows_internal)
10932 (Frun_window_configuration_change_hook, make_parent_window)
10933 (resize_window_check, resize_window_apply, Fresize_window_apply)
10934 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10935 (Fdelete_window_internal, Fresize_mini_window_internal):
10936 New functions.
1a13852e
MR
10937 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10938
f3d1777e
MR
109392011-06-08 Martin Rudalics <rudalics@gmx.at>
10940
496e208e
MR
10941 * window.h (window): Add some new members to window structure -
10942 normal_lines, normal_cols, new_total, new_normal, clone_number,
10943 splits, nest, prev_buffers, next_buffers.
10944 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10945 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10946
f3d1777e
MR
10947 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10948 Remove.
496e208e
MR
10949 (make_dummy_parent): Set new members of windows structure.
10950 (make_window): Move down in code. Handle new members of window
10951 structure.
10952 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10953 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10954 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10955 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10956 (Fset_window_next_buffers, Fset_window_clone_number):
10957 New functions.
496e208e
MR
10958 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10959 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10960 Doc-string fixes.
10961 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10962 Argument WINDOW can be now internal window too.
10963 (Fwindow_use_time): Move up in code.
10964 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10965 Rewrite doc-string.
10966 (Fset_window_configuration, saved_window)
10967 (Fcurrent_window_configuration, save_window_save): Handle new
10968 members of window structure.
b9e809c2
MR
10969 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10970 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10971 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10972 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10973 Qget_mru_window, Qresize_root_window,
10974 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10975 Qauto_buffer_name; staticpro them.
f3d1777e 10976
abde8f8c
MR
109772011-06-07 Martin Rudalics <rudalics@gmx.at>
10978
10979 * window.c (Fwindow_total_size, Fwindow_left_column)
10980 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10981 (Fwindow_list_1): New functions.
10982 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10983 (Fwindow_width, Fscroll_left, Fscroll_right):
10984 Use window_body_cols instead of window_box_text_cols.
10985 (delete_window, Fset_window_configuration):
10986 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10987 (delete_all_subwindows): Take a window as argument and not a
10988 structure. Rewrite.
190b47e6
MR
10989 (window_loop): Remove handling of GET_LRU_WINDOW and
10990 GET_LARGEST_WINDOW.
10991 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10992
10993 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10994 window_box_text_cols. delete_all_subwindows now takes a
10995 Lisp_Object as argument.
abde8f8c 10996
640c8776
SM
10997 * indent.c (compute_motion, Fcompute_motion):
10998 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10999
fa8a67e6
MR
11000 * frame.c (delete_frame): Call delete_all_subwindows with root
11001 window as argument.
11002
a54e3482
DC
110032011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11004
11005 * fns.c (Fputhash): Document return value.
11006
60002bf5
CY
110072011-06-06 Chong Yidong <cyd@stupidchicken.com>
11008
11009 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11010
0c671da6 110112011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11012
b862a52a 11013 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11014
be44ca6c
PE
11015 Check for overflow when converting integer to cons and back.
11016 * charset.c (Fdefine_charset_internal, Fdecode_char):
11017 Use cons_to_unsigned to catch overflow.
11018 (Fencode_char): Use INTEGER_TO_CONS.
11019 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11020 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11021 * data.c (long_to_cons, cons_to_long): Remove.
11022 (cons_to_unsigned, cons_to_signed): New functions.
11023 These signal an error for invalid or out-of-range values.
11024 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11025 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11026 * font.c (Ffont_variation_glyphs):
11027 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11028 * lisp.h: Include <intprops.h>.
11029 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11030 (cons_to_signed, cons_to_unsigned): New decls.
11031 (long_to_cons, cons_to_long): Remove decls.
11032 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11033 (Fprimitive_undo): Use CONS_TO_INTEGER.
11034 * xfns.c (Fx_window_property): Likewise.
11035 * xselect.c: Include <limits.h>.
11036 (x_own_selection, selection_data_to_lisp_data):
11037 Use INTEGER_TO_CONS.
11038 (x_handle_selection_request, x_handle_selection_clear)
11039 (x_get_foreign_selection, Fx_disown_selection_internal)
11040 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11041 (lisp_data_to_selection_data): Use cons_to_unsigned.
11042 (x_fill_property_data): Use cons_to_signed.
11043 Report values out of range.
11044
d1f3d2af
PE
11045 Check for buffer and string overflow more precisely.
11046 * buffer.h (BUF_BYTES_MAX): New macro.
11047 * lisp.h (STRING_BYTES_MAX): New macro.
11048 * alloc.c (Fmake_string):
11049 * character.c (string_escape_byte8):
11050 * coding.c (coding_alloc_by_realloc):
11051 * doprnt.c (doprnt):
11052 * editfns.c (Fformat):
11053 * eval.c (verror):
11054 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11055 since they may not be the same number.
11056 * editfns.c (Finsert_char):
11057 * fileio.c (Finsert_file_contents):
11058 Likewise for BUF_BYTES_MAX.
11059
dd52fcea
PE
11060 * image.c: Use ptrdiff_t, not int, for sizes.
11061 (slurp_file): Switch from int to ptrdiff_t.
11062 All uses changed.
11063 (slurp_file): Check that file size fits in both size_t (for
11064 malloc) and ptrdiff_t (for sanity and safety).
11065
7f9bbdbb
PE
11066 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11067 if b->modtime has its maximal value.
11068
dfe18f82
PE
11069 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11070
84acfcf0
PE
11071 Don't assume time_t can fit into int.
11072 * buffer.h (struct buffer.modtime): Now time_t, not int.
11073 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11074 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11075
ccd9a01a
PE
11076 Minor fixes for signed vs unsigned integers.
11077 * character.h (MAYBE_UNIFY_CHAR):
11078 * charset.c (maybe_unify_char):
11079 * keyboard.c (read_char, reorder_modifiers):
11080 XINT -> XFASTINT, since the integer must be nonnegative.
11081 * ftfont.c (ftfont_spec_pattern):
11082 * keymap.c (access_keymap, silly_event_symbol_error):
11083 XUINT -> XFASTINT, since the integer must be nonnegative.
11084 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11085 since it makes no difference and we prefer signed.
11086 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11087 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11088 nonnegative.
11089
d6d100dd
SM
110902011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11091
11092 * window.h (Fwindow_frame): Declare.
11093
2b6148e4
PE
110942011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11095
11096 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11097 (SPARE_MEMORY): Always define.
11098 (LARGE_REQUEST): Remove.
11099 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11100
f230ecc9
MR
111012011-06-06 Martin Rudalics <rudalics@gmx.at>
11102
727e958e
MR
11103 * lisp.h: Move EXFUNS for Fframe_root_window,
11104 Fframe_first_window and Fset_frame_selected_window to window.h.
11105
11106 * window.h: Move EXFUNS for Fframe_root_window,
11107 Fframe_first_window and Fset_frame_selected_window here from
11108 lisp.h.
11109
11110 * frame.c (Fwindow_frame, Fframe_first_window)
11111 (Fframe_root_window, Fframe_selected_window)
11112 (Fset_frame_selected_window): Move to window.c.
11113 (Factive_minibuffer_window): Move to minibuf.c.
11114 (Fother_visible_frames_p): New function.
11115
11116 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11117
f230ecc9
MR
11118 * window.c (decode_window, decode_any_window): Move up in code.
11119 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11120 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11121 (Fwindow_buffer): Move up and rewrite doc-string.
11122 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11123 (Fwindow_prev): New functions.
727e958e
MR
11124 (Fwindow_frame): Move here from frame.c. Accept any window as
11125 argument.
11126 (Fframe_root_window, Fframe_first_window)
11127 (Fframe_selected_window): Move here from frame.c. Accept frame
11128 or arbitrary window as argument. Update doc-strings.
11129 (Fminibuffer_window): Move up in code.
11130 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11131 (Fset_frame_selected_window): Move here from frame.c.
11132 Marginal rewrite.
727e958e
MR
11133 (Fselected_window, select_window, Fselect_window): Move up in
11134 code. Minor doc-string fixes.
f230ecc9 11135
4d09bcf6
PE
111362011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11137
11138 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11139 Do not assume that spare memory exists; that assumption is valid
11140 only if SYSTEM_MALLOC.
11141 (LARGE_REQUEST): New macro, so that the issue of large requests
11142 is separated from the issue of spare memory.
11143
810928a2
AS
111442011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11145
172418ad
AS
11146 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11147 format. (Bug#8806)
11148
43f862f7
AS
11149 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11150
810928a2
AS
11151 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11152 before statements.
11153
a059fe24
JD
111542011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11155
11156 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11157
11158 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11159
11160 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11161 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11162
989bf368
JB
111632011-06-05 Juanma Barranquero <lekktu@gmail.com>
11164
11165 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11166
4b80f674
CY
111672011-06-04 Chong Yidong <cyd@stupidchicken.com>
11168
11169 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11170 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11171 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11172 New error handlers.
4b80f674
CY
11173 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11174 Obey Vx_select_enable_clipboard_manager. Catch errors in
11175 x_clipboard_manager_save (Bug#8779).
11176 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11177 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11178
99a33b77 111792011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11180
11181 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11182
99a33b77 111832011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11184
11185 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11186 in the current matrix if keep_current_p is non-zero.
11187
8264569d
EZ
111882011-06-04 Eli Zaretskii <eliz@gnu.org>
11189
11190 * bidi.c (bidi_level_of_next_char): Fix last change.
11191
57f97249
EZ
111922011-06-03 Eli Zaretskii <eliz@gnu.org>
11193
fec2107c 11194 Support bidi reordering of text covered by display properties.
57f97249 11195
fec2107c
EZ
11196 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11197 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11198 (bidi_cache_search, bidi_cache_iterator_state)
11199 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11200 (bidi_level_of_next_char, bidi_move_to_visually_next):
11201 Support character positions inside a run of characters covered by a
fec2107c
EZ
11202 display string.
11203 (bidi_paragraph_init, bidi_resolve_explicit_1)
11204 (bidi_level_of_next_char): Call bidi_fetch_char and
11205 bidi_fetch_char_advance instead of FETCH_CHAR and
11206 FETCH_CHAR_ADVANCE.
11207 (bidi_init_it): Initialize new members.
11208 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11209 definitions.
11210 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11211 instead of using explicit *_CHAR codes.
d6d100dd
SM
11212 (bidi_resolve_explicit, bidi_resolve_weak):
11213 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11214 bidirectional text is supported only in multibyte buffers.
11215 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11216 it to initialize the frame_window_p member of struct bidi_it.
11217 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11218 (bidi_resolve_explicit, bidi_resolve_weak)
11219 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11220 bidi_it->nchars is non-positive.
11221 (bidi_level_of_next_char): Don't try to lookup the cache for the
11222 next/previous character if nothing is cached there yet, or if we
11223 were just reseat()'ed to a new position.
c40e2fb2 11224
0e14fe90
EZ
11225 * xdisp.c (set_cursor_from_row): Set start and stop points
11226 according to the row's direction when priming the loop that looks
11227 for the glyph on which to display cursor.
11228 (single_display_spec_intangible_p): Function deleted.
11229 (display_prop_intangible_p): Reimplement to call
11230 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11231 Accept 3 additional arguments needed by handle_display_spec.
11232 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11233 values: lists, `(when COND...)' forms, etc.
11234 (single_display_spec_string_p): Support property values that are
11235 lists with the argument STRING its top-level element.
11236 (display_prop_string_p): Fix the condition for processing a
11237 property that is a list to be consistent with handle_display_spec.
fec2107c 11238 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11239 last portion of handle_display_prop.
11240 (compute_display_string_pos): Accept additional argument
11241 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11242 value of a `display' property is a "replacing spec".
11243 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11244 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11245 the display property, but just return a value indicating whether
11246 the display property will replace the characters it covers.
11247 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11248 frame_window_p members of struct bidi_it.
d6d100dd
SM
11249 (compute_display_string_pos, compute_display_string_end):
11250 New functions.
fec2107c
EZ
11251 (push_it): Accept second argument POSITION, where pop_it should
11252 jump to continue iteration.
11253 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11254
fec2107c
EZ
11255 * keyboard.c (adjust_point_for_property): Adjust the call to
11256 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11257
11258 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11259 (bidi_init_it): Update prototypes.
11260 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11261 (compute_display_string_pos, compute_display_string_end):
11262 Declare prototypes.
fec2107c
EZ
11263 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11264 EMACS_INT.
fc6f18ce 11265
40087514 112662011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11267
57f53182
PE
11268 Malloc failure behavior now depends on size of allocation.
11269 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11270 * lisp.h: Change signatures accordingly.
11271 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11272 All callers changed. (Bug#8762)
11273
11274 * gnutls.c: Use Emacs's memory allocators.
11275 Without this change, the gnutls library would invoke malloc etc.
11276 directly, which causes problems on non-SYNC_INPUT hosts, and which
11277 runs afoul of improving memory_full behavior. (Bug#8761)
11278 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11279 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11280 xfree instead of the default malloc, realloc, free.
11281 (Fgnutls_boot): No need to check for memory allocation failure,
11282 since xmalloc does that for us.
11283
ac32cd99 11284 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11285 * category.c (hash_get_category_set):
11286 * ccl.c (ccl_driver):
11287 * charset.c (Fdefine_charset_internal):
11288 * charset.h (struct charset.hash_index):
11289 * composite.c (get_composition_id, gstring_lookup_cache)
11290 (composition_gstring_put_cache):
11291 * composite.h (struct composition.hash_index):
11292 * dispextern.h (struct image.hash):
11293 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11294 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11295 (hashfn_equal, hashfn_user_defined, make_hash_table)
11296 (maybe_resize_hash_table, hash_lookup, hash_put)
11297 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11298 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11299 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11300 * image.c (make_image, search_image_cache, lookup_image)
11301 (xpm_put_color_table_h):
11302 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11303 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11304 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11305 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11306 * alloc.c (allocate_vectorlike):
11307 Check for overflow in vector size calculations.
11308 * ccl.c (ccl_driver):
11309 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11310 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11311 need to be updated by these changes.
40087514
PE
11312 * fns.c (make_hash_table, maybe_resize_hash_table):
11313 Check for integer overflow with large hash tables.
0de4bb68
PE
11314 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11315 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11316 (SXHASH_REDUCE): New macro.
11317 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11318 Use it instead of discarding useful hash info with large hash values.
11319 (sxhash_float): New function.
11320 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11321 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11322 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11323 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11324 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11325 Adjust signatures to match updated version of code.
11326 (consing_since_gc): Now EMACS_INT, since a single hash table can
11327 use more than INT_MAX bytes.
11328
698d32e2
DN
113292011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11330
11331 Make it possible to build with GCC-4.6+ -O2 -flto.
11332
11333 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11334
fd6fa53f
SM
113352011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11336
11337 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11338 Call minibuffer-inactive-mode.
11339
864db017
JB
113402011-05-31 Juanma Barranquero <lekktu@gmail.com>
11341
11342 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11343 Update dependencies.
11344
2ad0baf4
DN
113452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11346
11347 * data.c (init_data): Remove code for UTS, this system is not
11348 supported anymore.
11349
4fcc2638
DN
113502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11351
11352 Don't force ./temacs to start in terminal mode.
11353
11354 * frame.c (make_initial_frame): Initialize faces in all cases, not
11355 only when CANNOT_DUMP is defined.
11356 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11357
c56e0fd5
DN
113582011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11359
11360 * dispnew.c (add_window_display_history): Use const for the string
11361 pointer. Remove declaration, not needed.
11362
333d54da 113632011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11364
55d4c1b2 11365 Use 'inline', not 'INLINE'.
333d54da 11366 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11367 * alloc.c, fontset.c (INLINE): Remove.
11368 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11369 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11370 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11371 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11372 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11373
738db178
DN
113742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11375
11376 Make it possible to run ./temacs.
11377
11378 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11379 syms_of_callproc does the same thing. Remove test for
11380 "initialized", do it in the caller.
11381 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11382
620c53a6
SM
113832011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11384
11385 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11386 (read_minibuf): Use get_minibuffer.
11387 (syms_of_minibuf): Use DEFSYM.
11388 (Qmetadata): New var.
11389 * data.c (Qbuffer): Don't make it static.
11390 (syms_of_data): Use DEFSYM.
11391
e003a292
PE
113922011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11393
11394 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11395 (CCL_CODE_MIN): New macro.
11396
ed008a6d
PE
113972011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11398
3687c2ef
PE
11399 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11400
ed008a6d
PE
11401 * eval.c (Qdebug): Now static.
11402 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11403 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11404 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11405
d66c4c7c
CY
114062011-05-29 Chong Yidong <cyd@stupidchicken.com>
11407
11408 * image.c: Various fixes to ImageMagick code comments.
11409 (Fimagemagick_types): Doc fix.
11410
5fbc2025
PE
114112011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11412
0196f88a
PE
11413 Minor fixes prompted by GCC 4.6.0 warnings.
11414
11415 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11416
5fbc2025
PE
11417 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11418 (x_clipboard_manager_save_all): Move extern decl to ...
11419 * xterm.h: ... here, so that it can be checked for consistency.
11420
1dd3c2d9
CY
114212011-05-29 Chong Yidong <cyd@stupidchicken.com>
11422
11423 * xselect.c (x_clipboard_manager_save_frame)
11424 (x_clipboard_manager_save_all): New functions.
11425 (Fx_clipboard_manager_save): Lisp function deleted.
11426
11427 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11428 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11429
11430 * xterm.h: Update prototype.
11431
5ba6571d
WX
114322011-05-28 William Xu <william.xwl@gmail.com>
11433
11434 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11435 exiting (Bug#8239).
11436
3eaff834
JM
114372011-05-28 Jim Meyering <meyering@redhat.com>
11438
e1900994 11439 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11440 * fns.c (to_uchar): Define.
11441 (crypto_hash_function): Use it to convert some newly-signed
11442 variables to unsigned, to avoid sign-extension bugs. For example,
11443 without this change, (md5 "truc") would evaluate to
11444 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11445 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11446 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11447
0f6990a7
PE
114482011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11449
11450 Integer overflow fixes.
c8a9ca5a 11451
08686060
PE
11452 * dbusbind.c: Serial number integer overflow fixes.
11453 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11454 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11455 to hold a serial number that is too large for a fixnum.
11456 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11457 Check for serial numbers out of range. Decode any serial number
59568bf0 11458 that was so large that it became a float. (Bug#8722)
08686060 11459
2d1fc3c7
PE
11460 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11461 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11462 Use XFASTINT rather than XUINT when numbers are nonnegative.
11463 (xd_append_arg, Fdbus_method_return_internal):
11464 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11465 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11466 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11467 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11468 (Bug#8722)
2d1fc3c7 11469
c8a9ca5a
PE
11470 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11471
519e1d69
PE
11472 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11473
6df6ae42 11474 ccl: Add integer overflow checks.
30569699
PE
11475 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11476 (IN_INT_RANGE): New macros.
11477 (ccl_driver): Use them to check for integer overflow when
11478 decoding a CCL program. Many of the new checks are whether XINT (x)
11479 fits in int; it doesn't always, on 64-bit hosts. The new version
11480 doesn't catch all possible integer overflows, but it's an
847044ea 11481 improvement. (Bug#8719)
30569699 11482
c11285dc
PE
11483 * alloc.c (make_event_array): Use XINT, not XUINT.
11484 There's no need for unsigned here.
11485
fdccd48e
PE
11486 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11487 This follows up to the 2011-05-06 change that substituted uintptr_t
11488 for EMACS_INT. This case wasn't caught back then.
11489
37910ab2
PE
11490 Rework Fformat to avoid integer overflow issues.
11491 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11492 now (part of C89). Include <verify.h>.
11493 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11494 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11495 (Fformat): Avoid the prepass trying to compute sizes; it was only
11496 approximate and thus did not catch overflow reliably. Instead, walk
11497 through the format just once, formatting and computing sizes as we go,
11498 checking for integer overflow at every step, and allocating a larger
11499 buffer as needed. Keep track separately whether the format is
11500 multibyte. Keep only the most-recently calculated precision, rather
11501 than them all. Record whether each argument has been converted to
11502 string. Use EMACS_INT, not int, for byte and char and arg counts.
11503 Support field widths and precisions larger than INT_MAX. Avoid
11504 sprintf's undefined behavior with conversion specifications such as %#d
11505 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11506 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11507 formatting out-of-range floating point numbers with int
9173deec 11508 formats. (Bug#8668)
37910ab2 11509
2e6578fb
PE
11510 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11511
0ae6bdee
PE
11512 * data.c: Avoid integer truncation in expressions involving floats.
11513 * data.c: Include <intprops.h>.
11514 (arith_driver): When there's an integer overflow in an expression
11515 involving floating point, convert the integers to floating point
11516 so that the resulting value does not suffer from catastrophic
11517 integer truncation. For example, on a 64-bit host (* 4
11518 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11519 Do not rely on undefined behavior after integer overflow.
11520
de883a70
PE
11521 merge count_size_as_multibyte, parse_str_to_multibyte
11522 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11523 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11524 Check for integer overflow.
11525 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11526 since it's now a duplicate of the other. This is more of
11527 a character than a buffer op, so better that it's in character.c.
11528 * fns.c, print.c: Adjust to above changes.
11529
2ff916cb
PE
115302011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11531
11532 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11533
f1b54466
PE
115342011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11535
fb1ac845
PE
11536 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11537 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11538 (x_clipboard_manager_save): Now static.
11539 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11540
f1b54466
PE
11541 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11542 (crypto_hash_function): Now static.
11543 Fix pointer signedness problems. Avoid unnecessary initializations.
11544
a9f737ee
CY
115452011-05-27 Chong Yidong <cyd@stupidchicken.com>
11546
11547 * termhooks.h (Vselection_alist): Make it terminal-local.
11548
11549 * terminal.c (create_terminal): Initialize it.
11550
11551 * xselect.c: Support for clipboard managers.
11552 (Vselection_alist): Move to termhooks.h as terminal-local var.
11553 (LOCAL_SELECTION): New macro.
11554 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11555 (symbol_to_x_atom): Remove gratuitous arg.
11556 (x_handle_selection_request, lisp_data_to_selection_data)
11557 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11558 (x_own_selection, x_get_local_selection, x_convert_selection):
11559 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11560 (some_frame_on_display): Delete unused function.
11561 (Fx_own_selection_internal, Fx_get_selection_internal)
11562 (Fx_disown_selection_internal, Fx_selection_owner_p)
11563 (Fx_selection_exists_p): New optional frame arg.
11564 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11565 (x_handle_selection_clear): Don't treat other terminals with the
11566 same keyboard specially. Use the terminal-local Vselection_alist.
11567 (x_clear_frame_selections): Use Frun_hook_with_args.
11568
11569 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11570
11571 * xterm.h: Add support for those atoms.
11572
e067f0c1
CY
115732011-05-26 Chong Yidong <cyd@stupidchicken.com>
11574
11575 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11576 (converted_selections, conversion_fail_tag): New global variables.
11577 (x_selection_request_lisp_error): Free the above.
11578 (x_get_local_selection): Remove unnecessary code.
11579 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11580 of converted selections stored in converted_selections.
11581 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11582 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11583 (x_convert_selection): New function.
11584 (x_handle_selection_event): Simplify.
11585 (x_get_foreign_selection): Don't ignore incoming requests while
11586 waiting for an answer; this will fail when we implement
11587 SAVE_TARGETS, and seems unnecessary anyway.
11588 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11589 (Vx_sent_selection_functions): Doc fix.
11590
0f4aebc0
LL
115912011-05-26 Leo Liu <sdl.web@gmail.com>
11592
11593 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11594
e61124cd
YM
115952011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11596
11597 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11598
11599 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11600 for fringe update if it has periodic bitmap.
ac389d0c 11601 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11602 and fringe_bitmap_periodic_p.
11603
11604 * fringe.c (get_fringe_bitmap_data): New function.
11605 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11606 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11607 row. Mark glyph row for fringe update if periodicity changed.
11608
11609 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11610 for fringe update unless it has periodic bitmap.
11611
f16d9837
KH
116122011-05-25 Kenichi Handa <handa@m17n.org>
11613
11614 * xdisp.c (get_next_display_element): Set correct it->face_id for
11615 a static composition.
11616
e1b90ef6
LL
116172011-05-24 Leo Liu <sdl.web@gmail.com>
11618
11619 * deps.mk (fns.o):
11620 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11621
11622 * fns.c (crypto_hash_function, Fsha1): New function.
11623 (Fmd5): Use crypto_hash_function.
11624 (syms_of_fns): Add Ssha1.
11625
7400048f
PE
116262011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11627
11628 * gnutls.c: Remove unused macros.
11629 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11630 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11631 Remove macros that are defined and never used.
11632 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11633
abb71cf4
CY
116342011-05-22 Chong Yidong <cyd@stupidchicken.com>
11635
11636 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11637 (Fx_get_selection_internal): Minor cleanup.
11638 (Fx_own_selection_internal): Rename arguments for consistency with
11639 select.el.
11640
6307db39
PE
116412011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11642
11643 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11644
f3d4e0a4
CY
116452011-05-22 Chong Yidong <cyd@stupidchicken.com>
11646
11647 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11648
4d8ade89
YM
116492011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11650
11651 * dispnew.c (scrolling_window): Don't exclude the case that the
11652 last enabled row in the desired matrix touches the bottom boundary.
11653
32078c8d
GM
116542011-05-21 Glenn Morris <rgm@gnu.org>
11655
11656 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11657 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11658 and add some more files.
32078c8d 11659
7285dc67
EZ
116602011-05-20 Eli Zaretskii <eliz@gnu.org>
11661
11662 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11663 report_file_error introduced by the change from 2011-05-07.
11664
89d1bd22
PE
116652011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11666
11667 * systime.h (Time): Define only if emacs is defined.
11668 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11669 where the include path doesn't have X11/X.h by default. See
11670 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11671
cd394be1 116722011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11673
11674 * composite.c (find_automatic_composition): Fix previous change.
11675
b9704ad9
GM
116762011-05-20 Glenn Morris <rgm@gnu.org>
11677
11678 * lisp.mk: New file, split from Makefile.in.
11679 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11680 (shortlisp): Remove.
11681 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11682
4a720484
GM
116832011-05-19 Glenn Morris <rgm@gnu.org>
11684
11685 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11686 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11687 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11688 (lisp): Set the order to that of loadup.el.
11689 (shortlisp): Make it a copy of $lisp.
11690 (SOME_MACHINE_LISP): Remove.
11691 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11692 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11693
a28d4396
KH
116942011-05-18 Kenichi Handa <handa@m17n.org>
11695
11696 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11697 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11698 (find_automatic_composition): Mostly rewrite for efficiency.
11699
a2b1fa8e
JB
117002011-05-18 Juanma Barranquero <lekktu@gmail.com>
11701
11702 * makefile.w32-in: Update dependencies.
11703
8e1f5610
CS
117042011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11705
11706 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11707 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11708
7025ee00 117092011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11710
cdfa6eab
PE
11711 Fix some integer overflow issues, such as string length overflow.
11712
06d6db33
PE
11713 * insdel.c (count_size_as_multibyte): Check for string overflow.
11714
2b4560a8
PE
11715 * character.c (lisp_string_width): Check for string overflow.
11716 Use EMACS_INT, not int, for string indexes and lengths; in
11717 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11718 the resulting string length overflows an EMACS_INT; instead,
11719 report a string overflow if no precision given. When checking for
11720 precision exhaustion, use a check that cannot possibly have
11721 integer overflow. (Bug#8675)
11722 * character.h (lisp_string_width): Adjust to new signature.
11723
cb93f9be
PE
11724 * alloc.c (string_overflow): New function.
11725 (Fmake_string): Use it. This doesn't change behavior, but saves
11726 a few bytes and will simplify future changes.
11727 * character.c (string_escape_byte8): Likewise.
11728 * lisp.h (string_overflow): New decl.
11729
1a1f3366
PE
11730 Fixups, following up to the user-interface timestamp change.
11731 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11732 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11733 * msdos.c (mouse_get_pos): Likewise.
11734 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11735 * w32gui.h (Time): Define by including "systime.h" rather than by
11736 declaring it ourselves. (Bug#8664)
11737
d4e3e4d3
PE
11738 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11739 * image.c (clear_image_cache): Likewise.
11740
f6a24d19
PE
11741 * term.c (term_mouse_position): Don't assume time_t wraparound.
11742
08dc5ae6
PE
11743 Be more systematic about user-interface timestamps.
11744 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11745 and sometimes 'EMACS_UINT', to represent these timestamps.
11746 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11747 This makes the code easier to follow, and makes it easier to catch
11748 integer overflow bugs such as Bug#8664.
11749 * frame.c (Fmouse_position, Fmouse_pixel_position):
11750 Use Time, not unsigned long, for user-interface timestamps.
11751 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11752 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11753 * keyboard.h (last_event_timestamp): Likewise.
11754 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11755 * menu.h (xmenu_show): Likewise.
11756 * term.c (term_mouse_position): Likewise.
11757 * termhooks.h (struct input_event.timestamp): Likewise.
11758 (struct terminal.mouse_position_hook): Likewise.
11759 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11760 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11761 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11762 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11763 what it was before.
11764 * menu.h, termhooks.h: Include "systime.h", for Time.
11765
8e55734a
PE
11766 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11767 Don't assume that the difference between two unsigned long values
11768 can fit into an integer. At this point, we know button_down_time
11769 <= event->timestamp, so the difference must be nonnegative, so
11770 there's no need to cast the result if double-click-time is
11771 nonnegative, as it should be; check that it's nonnegative, just in
11772 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11773 apart (about 25 days). (Bug#8664)
8e55734a 11774
841f1b75 11775 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11776 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11777
3e26f69c
PE
11778 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11779 that always fit in int. Use a sentinel instead of a counter, to
11780 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11781 * frame.h (struct frame): Use int for menu_bar_items_used
11782 instead of EMACS_INT, since it always fits in int.
3e26f69c 11783
5cc152c0
PE
11784 * menu.c (grow_menu_items): Check for int overflow.
11785
d89eb65e
PE
11786 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11787
5235bd3e
PE
11788 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11789 Before, the code was not consistent. These values cannot exceed
11790 2**31 - 1 so there's no need to make them unsigned.
11791 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11792 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11793 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11794 as modifiers.
11795 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11796
bc827e23
PE
11797 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11798 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11799 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11800 presumably because the widths might not match.
11801
78eb494e
PE
11802 * window.c (size_window): Avoid needless test at loop start.
11803
04f2d78b
CB
118042011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11805
11806 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11807
d2fc7e3d 118082011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11809
11810 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11811
d2fc7e3d 118122011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11813
11814 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11815 `width' to `bar_area_x' and `bar_area_width', respectively.
11816 (x_scroll_run): Take account of fringe background extension.
11817
04f2d78b
CB
11818 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11819 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11820 `bar_area_width', respectively.
11821 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11822 background extension.
11823
79b70037
GM
118242011-05-10 Jim Meyering <meyering@redhat.com>
11825
11826 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11827
2f142cc5
JB
118282011-05-10 Juanma Barranquero <lekktu@gmail.com>
11829
11830 * image.c (Finit_image_library): Return t for built-in image types,
11831 like pbm and xbm. (Bug#8640)
11832
57679c86
AS
118332011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11834
11835 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11836
888c9e86
EZ
118372011-05-07 Eli Zaretskii <eliz@gnu.org>
11838
b0512a1d
EZ
11839 * w32console.c (Fset_screen_color): Doc fix.
11840 (Fget_screen_color): New function.
11841 (syms_of_ntterm): Defsubr it.
11842
7285dc67
EZ
11843 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11844 unlink the temporary file if Fcall_process didn't create it in the
11845 first place.
11846 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11847 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11848 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11849 cue to call_process_cleanup not to close that handle.
11850
4d3fcc8e
BK
118512011-05-07 Ben Key <bkey76@gmail.com>
11852
11853 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11854 one of two shell specific rules, either bootstrap-temacs-CMD or
11855 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11856 to the previous implementation of the bootstrap-temacs rule.
11857 The bootstrap-temacs-CMD rule is similar to the previous
11858 implementation of the bootstrap-temacs rule except that it
11859 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11860 variable.
11861
11862 These changes, along with some changes to nt/configure.bat,
11863 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11864 earlier fix to add support for --cflags and --ldflags options
11865 that include quotes so that it works whether make uses cmd or
11866 sh as the shell.
11867
b4289b64
MA
118682011-05-06 Michael Albinus <michael.albinus@gmx.de>
11869
11870 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11871 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11872 is a constant.
11873 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11874 a string. Handle both cases.
11875 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11876 (Fdbus_register_method): Use Qinvalid_function.
11877
af4c0e28
JB
118782011-05-06 Juanma Barranquero <lekktu@gmail.com>
11879
11880 * makefile.w32-in: Update dependencies.
11881 (LISP_H): Add inttypes.h and stdin.h.
11882 (PROCESS_H): Add unistd.h.
11883
c51453d9
EZ
118842011-05-06 Eli Zaretskii <eliz@gnu.org>
11885
11886 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11887 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11888
8ff0ac3c 118892011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11890
4c4b566b
PE
11891 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11892
aab2b9b5
PE
11893 * term.c (vfatal): Remove stray call to va_end.
11894 It's not needed and the C Standard doesn't allow it here anyway.
11895
c378da0b
PE
11896 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11897 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11898
288b08c7
PE
11899 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11900 bytes.
11901
e3601888
PE
11902 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11903
db6c0e74
PE
11904 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11905
dd5963ea
PE
11906 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11907
88c9450f
PE
11908 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11909
2f9442b8
PE
11910 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11911
c032b5f8
PE
11912 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11913 * charset.c (Fdefine_charset_internal): Don't initialize
11914 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11915 32-bit int (Bug#8600).
a108c10b
PE
11916
11917 * lread.c (read_integer): Be more consistent with string-to-number.
11918 Use string_to_number to do the actual conversion; this avoids
11919 rounding errors and fixes some other screwups. Without this fix,
11920 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11921 (digit_to_number): Move earlier, for benefit of read_integer.
11922 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11923 not a digit in any supported base. (Bug#8602)
a108c10b 11924
ad5f9eea
PE
11925 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11926
aec1708a
PE
11927 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11928 to match comment at start of function. This also removes a
11929 GCC warning about overflow in a 32+64-bit port.
11930
47be4ab5
PE
11931 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11932
371cac43
PE
11933 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11934 Reported by Stefan Monnier in
11935 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11936 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11937 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11938
d01a7826
PE
11939 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11940 (EMACS_UINTPTR): Likewise, with uintptr_t.
11941
7fd47d5c
PE
11942 * lisp.h: Prefer 64-bit EMACS_INT if available.
11943 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11944 on 32-bit hosts that have 64-bit int, so that they can access
11945 large files.
122b0c86
PE
11946 However, temporarily disable this change unless the temporary
11947 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11948
8727937b
PE
11949 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11950
8ac068ac
PE
11951 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11952 This removes an assumption that EMACS_INT and long are the same
11953 width as pointers. The assumption is true for Emacs porting targets
11954 now, but we want to make other targets possible.
11955 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11956 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11957 In the rest of the code, change types of integers that hold casted
11958 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11959 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11960 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11961 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11962 No need to cast type when ORing.
11963 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11964 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11965 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11966 assume EMACS_INT is the same width as char *.
11967 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11968 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11969 Remove no-longer-needed casts.
11970 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11971 (xg_tool_bar_help_callback, xg_make_tool_item):
11972 Use EMACS_INTPTR to hold an integer
11973 that will be cast to void *; this can avoid a GCC warning
11974 if EMACS_INT is not the same width as void *.
11975 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11976 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11977 (current_message_1, set_message_1):
11978 Use a local to convert to proper width without a cast.
11979 * xmenu.c (dialog_selection_callback): Likewise.
11980
ede49d71
PE
11981 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11982 Also, don't assume VALBITS / RAND_BITS is less than 5,
11983 and don't rely on undefined behavior when shifting a 1 left into
11984 the sign bit.
11985 * lisp.h (get_random): Change signature to match.
11986
2f30ecd0
PE
11987 * lread.c (hash_string): Use size_t, not int, for hash computation.
11988 Normally we prefer signed values; but hashing is special, because
11989 it's better to use unsigned division on hash table sizes so that
11990 the remainder is nonnegative. Also, size_t is the natural width
11991 for hashing into memory. The previous code used 'int', which doesn't
11992 retain enough info to hash well into very large tables.
11993 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11994
2a866e7b
PE
11995 * dbusbind.c: Don't possibly lose pointer info when converting.
11996 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11997 Use XPNTR rather than XHASH, so that the high-order bits of
11998 the pointer aren't lost when converting through void *.
11999
51639eac
PE
12000 * eval.c (Fautoload): Don't double-shift a pointer.
12001
92394119
PE
12002 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12003
dbdb9a7c
JB
120042011-05-06 Juanma Barranquero <lekktu@gmail.com>
12005
12006 * gnutls.c (DEF_GNUTLS_FN):
12007 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12008
db7a0b4f
AS
120092011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12010
12011 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12012 marker. (Bug#8610)
12013
cd394be1 120142011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12015
12016 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12017 New version that can reserve upto 2GB of heap space.
12018
f7ff1b0f 120192011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12020
12021 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12022
639c109b
TZ
120232011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12024
12025 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12026 `gnutls_certificate_set_x509_key_file'.
12027
d2127135
JB
120282011-05-05 Juanma Barranquero <lekktu@gmail.com>
12029
12030 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12031 Update dependencies.
12032
e968f4f3
JB
120332011-05-04 Juanma Barranquero <lekktu@gmail.com>
12034
12035 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12036 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12037 Remove unused parameter `fildes'.
12038 * process.c (read_process_output, send_process): Don't pass it.
12039
84d358f0
JB
120402011-05-04 Juanma Barranquero <lekktu@gmail.com>
12041
12042 Fix previous change: the library cache is defined in w32.c.
12043 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12044 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12045
0898ca10
JB
120462011-05-04 Juanma Barranquero <lekktu@gmail.com>
12047
12048 Implement dynamic loading of GnuTLS on Windows.
12049
12050 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12051 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12052 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12053 Declare.
12054
12055 * gnutls.c (Qgnutls_dll): Define.
12056 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12057 (gnutls_*): Declare function pointers.
12058 (init_gnutls_functions): New function to initialize function pointers.
12059 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12060 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12061 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12062 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12063 (emacs_gnutls_write, emacs_gnutls_read)
12064 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12065 (Fgnutls_available_p): New function.
12066 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12067 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12068 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12069
12070 * image.c: Include w32.h.
12071 (Vimage_type_cache): Delete.
12072 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12073 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12074 (w32_delayed_load): Move to w32.c.
12075
12076 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12077
12078 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12079 (w32_delayed_load): Move from image.c. When loading a library, record
12080 its filename in the :loaded-from property of the library id.
12081 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12082 Initialize and staticpro them.
12083 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12084
12085 * process.c: Include lisp.h before w32.h, not after.
12086 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12087 instead of gnutls_record_check_pending.
12088
12089 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12090
ff4de4aa
TZ
120912011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12092
12093 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12094 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12095 as passed in.
12096
abe95abb
JD
120972011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12098
12099 * xterm.c (x_set_frame_alpha): Do not set property on anything
12100 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12101
e16e55d4
JB
121022011-05-02 Juanma Barranquero <lekktu@gmail.com>
12103
12104 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12105
bafcf6a5
JB
121062011-05-02 Juanma Barranquero <lekktu@gmail.com>
12107
12108 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12109 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12110 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12111 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12112 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12113 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12114 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12115 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12116 (Qgnutls_bootprop_callbacks_verify): Make static.
12117
e7a6747f
AS
121182011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12119
19ed11ba
AS
12120 * callproc.c: Indentation fixup.
12121
e7a6747f 12122 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12123 (wait_for_termination, interruptible_wait_for_termination):
12124 Move after wait_for_termination_1.
e7a6747f 12125
1ef14cb4
LMI
121262011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12127
12128 * sysdep.c (interruptible_wait_for_termination): New function
12129 which is like wait_for_termination, but allows keyboard
12130 interruptions.
12131
12132 * callproc.c (Fcall_process): Add (:file "file") as an option for
12133 the STDOUT buffer.
12134 (Fcall_process_region): Ditto.
12135
330d880c
EZ
121362011-04-30 Eli Zaretskii <eliz@gnu.org>
12137
8db90b73
EZ
12138 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12139 rather than `XVECTOR (FOO)->size'.
12140
330d880c
EZ
12141 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12142 inttypes.h, as a gnulib replacement is used if it not available in
12143 system headers.
12144
15cbd324
EZ
121452011-04-21 Eli Zaretskii <eliz@gnu.org>
12146
12147 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12148 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12149 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12150
12151 * coding.c (coding_alloc_by_realloc): Error out if destination
12152 will grow beyond MOST_POSITIVE_FIXNUM.
12153 (decode_coding_emacs_mule): Abort if there isn't enough place in
12154 charbuf for the composition carryover bytes. Reserve an extra
12155 space for up to 2 characters produced in a loop.
12156 (decode_coding_iso_2022): Abort if there isn't enough place in
12157 charbuf for the composition carryover bytes.
12158
121592011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12160
ae940cca
EZ
12161 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12162 aborting when %lld or %lll format is passed.
12163 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12164 %llo or %llx format is passed. (Bug#8545)
12165
03ab8921
EZ
12166 * window.c (window_scroll_line_based): Use a marker instead of
12167 simple variables to record original value of point. (Bug#7952)
12168
afda1437
EZ
12169 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12170 produced by %s or %c overflows available buffer space. (Bug#8545)
12171
f76dee0c
PE
121722011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12173
12174 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12175 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12176
fdc5744d
JB
121772011-04-28 Juanma Barranquero <lekktu@gmail.com>
12178
12179 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12180
638f053a
JB
121812011-04-28 Juanma Barranquero <lekktu@gmail.com>
12182
12183 * keyboard.c (Qdelayed_warnings_hook): Define.
12184 (command_loop_1): Run `delayed-warnings-hook'
12185 if Vdelayed_warnings_list is non-nil.
12186 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12187 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12188
d178f871
EZ
121892011-04-28 Eli Zaretskii <eliz@gnu.org>
12190
12191 * doprnt.c (doprnt): Don't return value smaller than the buffer
12192 size if the message was truncated. (Bug#8545).
12193
b124fd93
JB
121942011-04-28 Juanma Barranquero <lekktu@gmail.com>
12195
12196 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12197 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12198
e810457d
PE
121992011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12200
12201 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12202
ea51cceb
JB
122032011-04-27 Juanma Barranquero <lekktu@gmail.com>
12204
12205 * makefile.w32-in: Update dependencies.
12206
94dcfacf
EZ
122072011-04-27 Eli Zaretskii <eliz@gnu.org>
12208
12209 Improve `doprnt' and its usage. (Bug#8545)
12210 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12211 `format_end'. Remove support for %l as a conversion specifier.
12212 Don't use xrealloc. Improve diagnostics when the %l size modifier
12213 is used. Update the commentary.
12214
12215 * eval.c (verror): Simplify calculation of size_t.
12216
12217 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12218 messages.
12219
f61f41d7
PE
122202011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12221
12222 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12223 change.
12224
96fb4434
PE
122252011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12226
12227 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12228 This makes this file independent of the recent pseudovector change.
12229
671875da 122302011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12231
69e9b5a3
PE
12232 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12233
b5f869a7 12234 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12235 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12236 Remove unused local.
c8926152 12237 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12238
841a1577 12239 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12240 GCC 4.6.0 optimizes based on type-based alias analysis.
12241 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12242 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12243 != &v->size, and therefore "v->size = 1; b->size = 2; return
12244 v->size;" must therefore return 1. This assumption is incorrect
12245 for Emacs, since it type-puns struct Lisp_Vector * with many other
12246 types. To fix this problem, this patch adds a new type struct
f904488f 12247 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12248 and pseudovectors, and helps optimizing compilers not get fooled
12249 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12250 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12251 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12252 the size member.
eab3844f
PE
12253 (XSETPVECTYPE): Rewrite in terms of new macro.
12254 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12255 This is a bit clearer, and further avoids the possibility of
12256 undesirable aliasing.
12257 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12258 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12259 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12260 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12261 (ASIZE): Now uses header.size rather than size.
12262 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12263 to avoid the hassle of writing XVECTOR (foo)->header.size.
12264 (struct vectorlike_header): New type.
eab3844f
PE
12265 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12266 object, to help avoid aliasing.
12267 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12268 (SUBRP): Likewise, since Lisp_Subr is a special case.
12269 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12270 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12271 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12272 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12273 changed to be "header.size" and "header.next".
12274 * buffer.h (struct buffer): Likewise.
12275 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12276 * frame.h (struct frame): Likewise.
12277 * process.h (struct Lisp_Process): Likewise.
12278 * termhooks.h (struct terminal): Likewise.
12279 * window.c (struct save_window_data, struct saved_window): Likewise.
12280 * window.h (struct window): Likewise.
12281 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12282 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12283 * buffer.c (init_buffer_once): Likewise.
12284 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12285 special case.
12286 * process.c (Fformat_network_address): Use local var for size,
12287 for brevity.
12288
0df1eac5
PE
12289 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12290
847ab9d1 12291 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12292 * data.c (atof): Remove decl; no longer used or needed.
12293 (digit_to_number): Move to lread.c.
12294 (Fstring_to_number): Use new string_to_number function, to be
12295 consistent with how the Lisp reader treats infinities and NaNs.
12296 Do not assume that floating-point numbers represent EMACS_INT
12297 without losing information; this is not true on most 64-bit hosts.
12298 Avoid double-rounding errors, by insisting on integers when
12299 parsing non-base-10 numbers, as the documentation specifies.
12300 * lisp.h (string_to_number): New decl, replacing ...
12301 (isfloat_string): Remove.
bc0a5c13 12302 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12303 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12304 appears to have been a coding error. Similarly, do not accept
12305 strings like +-1e0 as floating point numbers. Do not report
12306 overflow for integer overflows unless the base is not 10 which
12307 means we have no simple and reliable way to continue.
12308 Break out the floating-point parsing into a new
12309 function string_to_number, so that Fstring_to_number parses
12310 floating point numbers consistently with the Lisp reader.
04f2d78b 12311 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12312 (E_CHAR, EXP_INT): Remove, replacing with ...
12313 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12314 (string_to_number): New function, replacing isfloat_string.
12315 This function checks for valid syntax and produces the resulting
12316 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12317 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12318 so that overflow for non-base-10 numbers is reported only when
12319 there's no portable and simple way to convert to floating point.
452f4150 12320
67769ffc
PE
12321 * textprop.c (set_text_properties_1): Rewrite for clarity,
12322 and to avoid GCC warning about integer overflow.
12323
c20db43f
PE
12324 * intervals.h (struct interval): Use EMACS_INT for members
12325 where EMACS_UINT might cause problems. See
12326 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12327 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12328 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12329 All uses changed.
37aa2f85
PE
12330 (offset_intervals): Tell GCC not to worry about length overflow
12331 when negating a negative length.
c20db43f 12332
2538aa2f
PE
12333 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12334 (overrun_check_free): Likewise.
12335
f2d3008d
PE
12336 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12337 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12338 word size.
12339
ec8df744
PE
12340 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12341 (gnutls_make_error): Rename local to avoid shadowing.
12342 (gnutls_emacs_global_deinit): ifdef out; not used.
12343 (Fgnutls_boot): Use const for pointer to readonly storage.
12344 Comment out unused local. Fix pointer signedness problems.
12345
640ee02d
PE
12346 * lread.c (openp): Don't stuff size_t into an 'int'.
12347 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12348 about possible signed overflow.
12349
6048fb2a
PE
12350 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12351 (GDK_KEY_g): Don't define if already defined.
12352 (xg_prepare_tooltip): Avoid pointer signedness problem.
12353 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12354
fa3c87e1
PE
12355 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12356 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12357
2172544b
PE
12358 * xfns.c (Fx_window_property): Simplify a bit,
12359 to make a bit faster and to avoid GCC 4.6.0 warning.
12360 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12361
9b821a21
PE
12362 * fns.c (internal_equal): Don't assume size_t fits in int.
12363
3c616cfa
PE
12364 * alloc.c (compact_small_strings): Tighten assertion a little.
12365
c2982e87
PE
12366 Replace pEd with more-general pI, and fix some printf arg casts.
12367 * lisp.h (pI): New macro, generalizing old pEd macro to other
12368 conversion specifiers. For example, use "...%"pI"d..." rather
12369 than "...%"pEd"...".
12370 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12371 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12372 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12373 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12374 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12375 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12376 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12377 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12378 64-bit hosts.
12379 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12380 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12381 * print.c (safe_debug_print, print_object): Likewise.
12382 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12383 to int.
6f04d126
PE
12384 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12385 avoiding the 0 flag, which is not portable.
c2982e87
PE
12386 * process.c (Fmake_network_process): Use pI to avoid cast.
12387 * region-cache.c (pp_cache): Likewise.
12388 * xdisp.c (decode_mode_spec): Likewise.
12389 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12390 behavior on 64-bit hosts with printf arg.
6f04d126 12391 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12392 (x_stop_queuing_selection_requests): Likewise.
12393 (x_get_window_property): Don't truncate byte count to an 'int'
12394 when tracing.
0b432f21 12395
5e073ec7
PE
12396 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12397 here, since it parses constructs like leading '-' and spaces,
12398 which are not wanted; and it overflows with large numbers.
12399 Instead, simply match F[0-9]+, which is what is wanted anyway.
12400
36372bf9
PE
12401 * alloc.c: Remove unportable assumptions about struct layout.
12402 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12403 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12404 (allocate_vectorlike, make_pure_vector): Use the new macros,
12405 plus offsetof, to remove unportable assumptions about struct layout.
12406 These assumptions hold on all porting targets that I know of, but
12407 they are not guaranteed, they're easy to remove, and removing them
12408 makes further changes easier.
12409
0b432f21
PE
12410 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12411 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12412 (string_overrun_cookie): Now const. Use initializers that
12413 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12414 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12415 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12416 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12417 multiple of sizeof (EMACS_INT); it need not be, if
12418 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12419 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12420
895009e1
JB
124212011-04-26 Juanma Barranquero <lekktu@gmail.com>
12422
12423 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12424
6a7a1b0b
TZ
124252011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12426
12427 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12428 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12429 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12430
841a1577 124312011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12432
12433 * lisp.h (Qdebug): List symbol.
895009e1 12434 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12435 * keyboard.c (debug-on-event): New variable.
12436 (handle_user_signal): Break into debugger when debug-on-event
12437 matches the current signal symbol.
12438
f2d3ba6f
DN
124392011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12440
12441 * alloc.c (check_sblock, check_string_bytes)
12442 (check_string_free_list): Convert to standard C.
12443
42ce4c63
TZ
124442011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12445
12446 * w32.c (emacs_gnutls_push): Fix typo.
12447
825cd63c
EZ
124482011-04-25 Eli Zaretskii <eliz@gnu.org>
12449
fb11d64d
EZ
12450 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12451 "cast to pointer from integer of different size".
12452
825cd63c
EZ
12453 Improve doprnt and its use in verror. (Bug#8545)
12454 * doprnt.c (doprnt): Document the set of format control sequences
12455 supported by the function. Use SAFE_ALLOCA instead of always
12456 using `alloca'.
12457
12458 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12459 is one byte too soon. Don't use xrealloc; instead xfree and
12460 xmalloc anew.
12461
e061a11b
TZ
124622011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12463
12464 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12465 callbacks stage.
12466
12467 * gnutls.c: Renamed global_initialized to
12468 gnutls_global_initialized. Added internals for the
12469 :verify-hostname-error, :verify-error, and :verify-flags
12470 parameters of `gnutls-boot' and documented those parameters in the
12471 docstring. Start callback support.
9173deec
JB
12472 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12473 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12474 on error. Return error code.
e061a11b
TZ
12475 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12476 (emacs_gnutls_read): Likewise.
12477 (Fgnutls_boot): Return handshake error code.
12478 (emacs_gnutls_handle_error): New function.
12479 (wsaerror_to_errno): Likewise.
12480
12481 * w32.h (emacs_gnutls_pull): Add prototype.
12482 (emacs_gnutls_push): Likewise.
12483
12484 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12485 (emacs_gnutls_push): Likewise.
12486
124872011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12488
12489 * process.c (wait_reading_process_output): Check if GnuTLS
12490 buffered some data internally if no FDs are set for TLS
12491 connections.
12492
12493 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12494 (LIBS): Link to USER_LIBS.
12495 ($(BLD)/gnutls.$(0)): New target.
12496
fa6996bc
EZ
124972011-04-24 Eli Zaretskii <eliz@gnu.org>
12498
eb35682e
EZ
12499 * xdisp.c (handle_single_display_spec): Rename the
12500 display_replaced_before_p argument into display_replaced_p, to
12501 make it consistent with the commentary. Fix typos in the
12502 commentary.
12503
e2ad650c
EZ
12504 * textprop.c (syms_of_textprop): Remove dead code.
12505 (copy_text_properties): Delete obsolete commentary about an
12506 interface that was deleted long ago. Fix typos in the description
12507 of arguments.
12508
1b2de274
EZ
12509 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12510 to changes in oldXMenu/XMenu.h from 2011-04-16.
12511 <menu_help_message, prev_menu_help_message>: Constify.
12512 (IT_menu_make_room): menu->help_text is now `const char **';
12513 adjust.
12514
12515 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12516 to changes in oldXMenu/XMenu.h from 2011-04-16.
12517 (struct XMenu): Declare `help_text' `const char **'.
12518
12519 * xfaces.c <Qunspecified>: Make extern again.
12520
12521 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12522 required by POSIX.
1b2de274 12523
762b15be
EZ
12524 * doc.c (get_doc_string): Improve the format passed to `error'.
12525
12526 * doprnt.c (doprnt): Improve commentary.
12527
12528 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12529
12530 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12531 them with etags.
12532
f1052e5d
EZ
12533 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12534 changes in globals.h immediately force recompilation.
762b15be
EZ
12535 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12536 $(CURDIR)/s/ms-w32.h.
12537 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12538
fa6996bc
EZ
12539 * character.c (Fchar_direction): Function deleted.
12540 (syms_of_character): Don't defsubr it.
12541 <char-direction-table>: Deleted.
12542
e6c3da20
EZ
125432011-04-23 Eli Zaretskii <eliz@gnu.org>
12544
12545 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12546 * doprnt.c: Include limits.h.
12547 (SIZE_MAX): New macro.
04f2d78b
CB
12548 (doprnt): Return a size_t value. 2nd arg is now size_t.
12549 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12550 Improve overflow protection. Support `l' modifier for integer
12551 conversions. Support %l conversion. Don't assume an EMACS_INT
12552 argument for integer conversions and for %c.
12553
12554 * lisp.h (doprnt): Restore prototype.
12555
12556 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12557 $(SRC)/character.h.
12558
12559 * Makefile.in (base_obj): Add back doprnt.o.
12560
12561 * deps.mk (doprnt.o): Add back prerequisites.
12562 (callint.o): Depend on character.h.
12563
12564 * eval.c (internal_lisp_condition_case): Include the handler
12565 representation in the error message.
12566 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12567 when breaking from the loop.
12568
12569 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12570
12571 * callint.c (Fcall_interactively): When displaying error message
12572 about invalid control letter, pass the character's codepoint, not
12573 a pointer to its multibyte form. Improve display of the character
12574 in octal and display also its hex code.
12575
12576 * character.c (char_string): Use %x to display the (unsigned)
12577 codepoint of an invalid character, to avoid displaying a bogus
12578 negative value.
12579
12580 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12581 `error', not SYMBOL_NAME itself.
12582
12583 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12584 character arguments to `error'.
12585
12586 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12587 to `error' in error message about FINAL_CHAR argument. Make sure
12588 FINAL_CHAR is a character, and use %c when it is passed as
12589 argument to `error'.
12590
4ffd0d6b 125912011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12592
12593 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12594
12595 * w32.c: Include <time.h>.
12596 (sys_localtime): New function.
12597
4ffd0d6b 125982011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12599
12600 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12601
4ffd0d6b 12602 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12603
4ffd0d6b 126042011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12605
4ffd0d6b
GM
12606 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12607 zombies (Bug#8467).
aac0c6e3 12608
04c56954
EZ
126092011-04-19 Eli Zaretskii <eliz@gnu.org>
12610
12611 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12612 gl_state.e_property when gl_state.object is Qt.
12613
12614 * insdel.c (make_gap_larger): Remove limitation of buffer size
12615 to <= INT_MAX.
12616
16a43933
CY
126172011-04-18 Chong Yidong <cyd@stupidchicken.com>
12618
12619 * xdisp.c (lookup_glyphless_char_display)
12620 (produce_glyphless_glyph): Handle cons cell entry in
12621 glyphless-char-display.
12622 (Vglyphless_char_display): Document it.
12623
12624 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12625 glyphless-char-display.
12626
4581706e
CY
126272011-04-17 Chong Yidong <cyd@stupidchicken.com>
12628
12629 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12630
12631 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12632
12633 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12634 definition for no-X builds.
12635
4887c6e2 126362011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12637
fd35b6f9
PE
12638 Static checks with GCC 4.6.0 and non-default toolkits.
12639
5c1ccb01
PE
12640 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12641
006c5daa
PE
12642 * process.c (keyboard_bit_set): Define only if SIGIO.
12643 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12644 (send_process): Repair possible setjmp clobbering.
12645
efc736d3
PE
12646 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12647
4e2fe2e6
PE
12648 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12649
f97334a2
PE
12650 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12651
4e75f29d
PE
12652 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12653 Define only if needed.
12654
90efadd1
PE
12655 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12656 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12657 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12658
3c647824
PE
12659 * dispextern.h (struct redisplay_interface): Rename param
12660 to avoid shadowing.
e264f262 12661 * termhooks.h (struct terminal): Likewise.
761383f4 12662 * xterm.c (xembed_send_message): Likewise.
3c647824 12663
b58c5c4a
PE
12664 * insdel.c (make_gap_smaller): Define only if
12665 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12666
cad59032
PE
12667 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12668 it.
12669
c339dc2e
PE
12670 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12671 so that we aren't warned about unused symbols.
12672
91a3e27b
PE
12673 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12674
399c71d3 12675 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12676
8ffc96f5
PE
12677 * xfns.c (x_real_positions): Mark locals as initialized.
12678
eef9bc79
PE
12679 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12680
098db9dd
PE
12681 * xterm.c: Fix problems found by static analysis with other toolkits.
12682 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12683 (x_dispatch_event): Declare static if USE_GTK, and
12684 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12685 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12686 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12687 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12688 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12689
eb18f6cc
PE
12690 * xmenu.c (menu_help_callback): Pointer type fixes.
12691 Use const pointers when pointing at readonly data. Avoid pointer
12692 signedness clashes.
12693 (FALSE): Remove unused macro.
12694 (update_frame_menubar): Remove unused decl.
12695
1fe72bf8
PE
12696 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12697
60d9e1db
PE
12698 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12699 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12700 (single_menu_item): Rename local to avoid shadowing.
12701
39261c26
PE
12702 * keyboard.c (make_lispy_event): Remove unused local var.
12703
018c5e19
PE
12704 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12705 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12706
63d2b86e
PE
12707 * bitmaps: Change bitmaps from unsigned char back to the X11
12708 compatible char. Avoid the old compiler warnings about
12709 out-of-range initializers by using, for example, '\xab' rather
12710 than 0xab.
12711
aefd87e1
PE
12712 * xgselect.c (xgselect_initialize): Check vs interface
12713 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12714
bf501fb9
PE
12715 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12716
e9829fdf
PE
12717 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12718 to read-only memory.
12719
1086c095
PE
12720 * fns.c (vector): Remove; this old hack is no longer needed.
12721
2baccd04 12722 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12723 Remove unused var.
dde42981 12724 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12725
72391843 12726 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12727
436c16df 12728 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12729 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12730 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12731
92bb796d 12732 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12733 (x_term_init): Remove local to avoid shadowing.
92bb796d 12734
764430a3 12735 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12736
12737 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12738 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12739
d1dfb56c
EZ
127402011-04-16 Eli Zaretskii <eliz@gnu.org>
12741
c4354cb4
EZ
12742 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12743
d1dfb56c
EZ
12744 Fix regex.c, syntax.c and friends for buffers > 2GB.
12745 * syntax.h (struct gl_state_s): Declare character position members
12746 EMACS_INT.
12747
12748 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12749
04f2d78b
CB
12750 * textprop.c (verify_interval_modification, interval_of):
12751 Declare arguments EMACS_INT.
d1dfb56c
EZ
12752
12753 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12754 EMACS_INT.
12755
12756 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12757
12758 * indent.c (Fvertical_motion): Local variable it_start is now
12759 EMACS_INT.
12760
12761 * regex.c (re_match, re_match_2, re_match_2_internal)
12762 (bcmp_translate, regcomp, regexec, print_double_string)
12763 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12764 (re_compile_pattern, re_exec): Declare arguments and local
12765 variables `size_t' and `ssize_t' and return values `regoff_t', as
12766 appropriate.
12767 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12768 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12769 <compile_stack_type>: `size' and `avail' are now `size_t'.
12770
12771 * regex.h <regoff_t>: Use ssize_t, not int.
12772 (re_search, re_search_2, re_match, re_match_2): Arguments that
12773 specify buffer/string position and length are now ssize_t and
12774 size_t. Return type is regoff_t.
12775
613052cd
BK
127762011-04-16 Ben Key <bkey76@gmail.com>
12777
12778 * nsfont.m: Fixed bugs in ns_get_family and
12779 ns_descriptor_to_entity that were caused by using free to
12780 deallocate memory blocks that were allocated by xmalloc (via
12781 xstrdup). This caused Emacs to crash when compiled with
12782 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12783 --enable-checking=xmallocoverrun). xfree is now used to
12784 deallocate these memory blocks.
12785
4170f62f 127862011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12787
71b41406
PE
12788 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12789
9587a89d
PE
12790 emacs_write: Accept and return EMACS_INT for sizes.
12791 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12792 et seq.
12793 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12794 Accept and return EMACS_INT.
12795 (emacs_gnutls_write): Return the number of bytes written on
12796 partial writes.
12797 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12798 (emacs_read, emacs_write): Remove check for negative size, as the
12799 Emacs source code has been audited now.
9587a89d
PE
12800 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12801 (emacs_read, emacs_write): Use it.
273a5f82
PE
12802 * process.c (send_process): Adjust to the new signatures of
12803 emacs_write and emacs_gnutls_write. Do not attempt to store
12804 a byte offset into an 'int'; it might overflow.
9587a89d 12805 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12806
3e047f51
PE
12807 * sound.c: Don't assume sizes fit in 'int'.
12808 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12809 Return EMACS_INT, not int.
3e047f51 12810 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12811 Accept EMACS_INT, not int.
12812 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12813 record read return values.
12814
cc39a9db
BK
128152011-04-15 Ben Key <bkey76@gmail.com>
12816
c9d0ec6d
JB
12817 * keyboard.c (Qundefined): Don't declare static since it is used
12818 in nsfns.m.
12819 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12820 static since they are used in nsfont.m.
cc39a9db 12821
6c60eb9f
SM
128222011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12823
12824 * process.c (Qprocessp): Don't declare static.
12825 * lisp.h (Qprocessp): Declare again.
12826
7990b61a
JB
128272011-04-15 Juanma Barranquero <lekktu@gmail.com>
12828
12829 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12830
5d4cb038
PE
128312011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12832
8bd7b830 12833 Improve C-level modularity by making more things 'static'.
cd64ea1d 12834
e3b27b31
PE
12835 Don't publish debugger-only interfaces to other modules.
12836 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12837 (verify_bytepos, count_markers): Move decls to the only modules
12838 that need them.
12839 * region-cache.h (pp_cache): Likewise.
12840 * window.h (check_all_windows): Likewise.
12841 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12842
5d4cb038
PE
12843 * sysdep.c (croak): Now static, if
12844 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12845 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12846
12847 * alloc.c (refill_memory_reserve): Now static if
12848 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12849 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12850
e87b6180
PE
12851 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12852 Define only if USE_LUCID.
12853
ac64929e
PE
12854 * xrdb.c (x_customization_string, x_rm_string): Now static.
12855
6f37259d
PE
12856 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12857 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12858
1683e3ab
PE
12859 * xdisp.c (draw_row_with_mouse_face): Now static.
12860 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12861
de9c2632
PE
12862 * window.h (check_all_windows): Mark externally visible.
12863
2b96acb7
PE
12864 * window.c (window_deletion_count): Now static.
12865
12866 * undo.c: Make symbols static if they're not exported.
12867 (last_undo_buffer, last_boundary_position, pending_boundary):
12868 Now static.
12869
50436f33
PE
12870 * textprop.c (interval_insert_behind_hooks): Now static.
12871 (interval_insert_in_front_hooks): Likewise.
12872
64520e5c
PE
12873 * term.c: Make symbols static if they're not exported.
12874 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12875 (max_frame_lines, tty_set_terminal_modes):
12876 (tty_reset_terminal_modes, tty_turn_off_highlight):
12877 (get_tty_terminal): Now static.
12878 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12879 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12880 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12881 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12882 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12883
1fa53021
PE
12884 * sysdep.c: Make symbols static if they're not exported.
12885 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12886 Now static.
12887 (sigprocmask_set, full_mask): Remove; unused.
12888 (wait_debugging): Mark as visible.
12889 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12890 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12891
d4b43b22
PE
12892 * syntax.c (syntax_temp): Define only if !__GNUC__.
12893
b7c513d0
PE
12894 * sound.c (current_sound_device, current_sound): Now static.
12895
989b29ad
PE
12896 * search.c (searchbufs, searchbuf_head): Now static.
12897
13a55a78
PE
12898 * scroll.c (scroll_cost): Remove; unused.
12899 * dispextern.h (scroll_cost): Remove decl.
12900
de68a1fc
PE
12901 * region-cache.h (pp_cache): Mark as externally visible.
12902
40ccffa6
PE
12903 * process.c: Make symbols static if they're not exported.
12904 (process_tick, update_tick, create_process, chan_process):
12905 (Vprocess_alist, proc_buffered_char, datagram_access):
12906 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12907 (deactivate_process): Mark defn as static, as well as decl.
12908 * lisp.h (create_process): Remove decl.
12909 * process.h (chan_process, Vprocess_alist): Remove decls.
12910
ad64fc97
PE
12911 * print.c: Make symbols static if they're not exported.
12912 (print_depth, new_backquote_output, being_printed, print_buffer):
12913 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12914 (print_interval, print_number_index, initial_stderr_stream):
12915 Now static.
12916 * lisp.h (Fprinc): Remove decl.
12917 (debug_output_compilation_hack): Mark as externally visible.
12918
adddb265
PE
12919 * sysdep.c (croak): Move decl from here to syssignal.h.
12920 * syssignal.h (croak): Put it here, so the API can be checked when
12921 'croak' is called from dissociate_if_controlling_tty.
12922
1717ede2
PE
12923 * minibuf.c: Make symbols static if they're not exported.
12924 (minibuf_save_list, choose_minibuf_frame): Now static.
12925 * lisp.h (choose_minibuf_frame): Remove decl.
12926
fa5fb2bc
PE
12927 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12928
1e3890d1
PE
12929 * lread.c: Make symbols static if they're not exported.
12930 (read_objects, initial_obarray, oblookup_last_bucket_number):
12931 Now static.
12932 (make_symbol): Remove; unused.
12933 * lisp.h (initial_obarray, make_symbol): Remove decls.
12934
8a1414fa
PE
12935 * keyboard.c: Make symbols static if they're not exported.
12936 (single_kboard, recent_keys_index, total_keys, recent_keys):
12937 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12938 (this_single_command_key_start, echoing, last_auto_save):
12939 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12940 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12941 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12942 (Vlispy_mouse_stem, double_click_count):
12943 Now static.
12944 (force_auto_save_soon): Define only if SIGDANGER.
12945 (ignore_mouse_drag_p): Now static if
12946 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12947 (print_help): Remove; unused.
12948 (stop_character, last_timer_event): Mark as externally visible.
12949 * keyboard.h (ignore_mouse_drag_p): Declare only if
12950 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12951 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12952 * lisp.h (echoing): Remove decl.
12953 (force_auto_save_soon): Declare only if SIGDANGER.
12954 * xdisp.c (redisplay_window): Simplify code, to make it more
12955 obvious that ignore_mouse_drag_p is not accessed if !defined
12956 USE_GTK && !defined HAVE_NS.
12957
93ea6e8f
PE
12958 * intervals.c: Make symbols static if they're not exported.
12959 (merge_properties_sticky, merge_interval_right, delete_interval):
12960 Now static.
12961 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12962
77382fcc
PE
12963 * insdel.c: Make symbols static if they're not exported.
12964 However, leave prepare_to_modify_buffer alone. It's never
12965 called from outside this function, but that appears to be a bug.
12966 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12967 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12968 (adjust_after_replace_noundo): Remove; unused.
12969 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12970 (signal_before_change): Remove decls.
77382fcc 12971
9306c32e
PE
12972 * indent.c (val_compute_motion, val_vmotion): Now static.
12973
cd44d2eb
PE
12974 * image.c: Make symbols static if they're not exported.
12975 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12976 if USE_GTK.
12977 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12978 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12979
ad9a7a06
PE
12980 * fringe.c (standard_bitmaps): Now static.
12981 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12982
81626931
PE
12983 * frame.c: Make symbols static if they're not exported.
12984 (x_report_frame_params, make_terminal_frame): Now static.
12985 (get_frame_param): Now static, unless HAVE_NS.
12986 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12987 (x_get_resource_string): Remove; not used.
12988 * frame.h (make_terminal_frame, x_report_frame_params):
12989 (x_get_resource_string); Remove decls.
12990 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12991 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12992
239f9db9
PE
12993 * font.c, fontset.c: Make symbols static if they're not exported.
12994 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12995 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12996 * font.c (font_close_object): Now static.
12997 * font.h (font_close_object): Remove.
12998 * fontset.c (FONTSET_OBJLIST): Remove.
12999 (free_realized_fontset) #if-0 the body, which does nothing.
13000 (face_suitable_for_char_p): #if-0, as it's never called.
13001 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13002 * xfaces.c (face_at_string_position):
13003 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13004 since 0 is always ASCII.
13005
dfcf3579
PE
13006 * fns.c (weak_hash_tables): Now static.
13007
5045092b
PE
13008 * fileio.c: Make symbols static if they're not exported.
13009 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13010 (Vwrite_region_annotation_buffers): Now static.
13011
57a96f5c
PE
13012 * eval.c: Make symbols static if they're not exported.
13013 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13014 * lisp.h (backtrace_list): Remove decl.
13015
35f08c38
PE
13016 * emacs.c: Make symbols static if they're not exported.
13017 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13018 (fatal_error_code, fatal_error_signal_hook, standard_args):
13019 Now static.
13020 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13021 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13022 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13023 * lisp.h (fatal_error_signal_hook): Remove decl.
13024 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13025
f44bd759
PE
13026 * editfns.c: Move a (normally-unused) function to its only use.
13027 * editfns.c, lisp.h (get_operating_system_release): Remove.
13028 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13029 worth the hassle of breaking this out.
13030
b532497d
PE
13031 * xterm.c: Make symbols static if they're not exported.
13032 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13033 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13034 (x_destroy_window, x_delete_display):
13035 Now static.
13036 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13037 (x_mouse_leave): Remove; unused.
13038 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13039 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13040 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13041 Remove decls.
13042 (x_mouse_leave): Declare only if WINDOWSNT.
13043 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13044 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13045 USE_X_TOOLKIT.
13046
1675728f
PE
13047 * ftxfont.c: Make symbols static if they're not exported.
13048 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13049 HAVE_FREETYPE.
13050 * font.h (ftxfont_driver): Likewise.
13051
e4cebfca
PE
13052 * xfns.c: Make symbols static if they're not exported.
13053 (x_last_font_name, x_display_info_for_name):
13054 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13055 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13056 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13057 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13058 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13059 (last_show_tip_args): Now static.
13060 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13061 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13062 (x_screen_planes): Remove; unused.
13063 * dispextern.h (x_screen_planes): Remove decl.
13064
5bf46f05
PE
13065 * dispnew.c: Make symbols static if they're not exported.
13066 * dispextern.h (redraw_garbaged_frames, scrolling):
13067 (increment_row_positions): Remove.
13068 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13069 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13070 Now static.
13071 (redraw_garbaged_frames): Remove; unused.
13072
435f4c28
PE
13073 * xfaces.c: Make symbols static if they're not exported.
13074 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13075 Remove decls.
13076 * xterm.h (defined_color): Remove decls.
13077 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13078 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13079 (menu_face_changed_default, defined_color, free_realized_face):
13080 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13081 (ascii_face_of_lisp_face): Remove; unused.
13082
8524aef3
PE
13083 * xdisp.c: Make symbols static if they're not exported.
13084 * dispextern.h (scratch_glyph_row, window_box_edges):
13085 (glyph_to_pixel_coords, set_cursor_from_row):
13086 (get_next_display_element, set_iterator_to_next):
13087 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13088 (show_mouse_face): Remove decls
13089 * frame.h (message_buf_print): Likewise.
13090 * lisp.h (pop_message, set_message, check_point_in_composition):
13091 Likewise.
13092 * xterm.h (set_vertical_scroll_bar): Likewise.
13093 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13094 (message_buf_print, scratch_glyph_row, displayed_buffer):
13095 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13096 (get_next_display_element, show_mouse_face, window_box_edges):
13097 (frame_to_window_pixel_xy, check_point_in_composition):
13098 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13099 (glyph_to_pixel_coords): Remove; unused.
13100
16390cd2
PE
13101 * dired.c (file_name_completion): Now static.
13102
13103 * dbusbind.c (xd_in_read_queued_messages): Now static.
13104
a25f4dfa
PE
13105 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13106 * data.c (circular_list_error): Remove.
13107
14a9c8df
PE
13108 * commands.h (last_point_position, last_point_position_buffer):
13109 (last_point_position_window): Remove decls.
13110 * keyboard.c: Make these variables static.
13111
04f2d78b
CB
13112 * coding.h (coding, code_convert_region, encode_coding_gap):
13113 Remove decls.
74ab6df5
PE
13114 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13115 (iso_code_class, detect_coding, code_convert_region): Now static.
13116 (encode_coding_gap): Remove; unused.
13117
38dfbee1
PE
13118 * chartab.c (chartab_chars, chartab_bits): Now static.
13119
a2cb4e63
PE
13120 * charset.h (charset_iso_8859_1): Remove decl.
13121 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13122 Now static.
13123
127198fd
PE
13124 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13125 * ccl.c (Vccl_program_table): Now static.
13126 (check_ccl_update): Remove; unused.
13127
d85b608f
PE
13128 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13129 * category.h: ... from here.
13130 * category.c (check_category_table, set_category_set): Now static.
13131
31cd66f3
PE
13132 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13133 * lisp.h: Remove these decls.
13134
c358e587
PE
13135 * buffer.c (buffer_count): Remove unused var.
13136
e78aecca
PE
13137 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13138 so that it's not optimized away.
13139 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13140 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13141 exported only to the debugger.
13142
e192d7d3 13143 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13144 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13145
92470028
PE
13146 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13147 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13148 was inaccessible from Lisp.
13149 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13150 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13151
244ed907
PE
13152 alloc.c: Import and export fewer symbols, and remove unused items.
13153 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13154 is defined.
13155 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13156 it's not optimized away by whole-program optimization.
13157 (message_enable_multibyte, free_misc): Remove.
13158 (catchlist, handlerlist, mark_backtrace):
13159 Declare only if BYTE_MARK_STACK.
13160 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13161 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13162 (message_enable_multibyte): Remove decl.
13163 (free_misc, interval_free_list, float_block, float_block_index):
13164 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13165 (cons_free_list, last_marked_index):
13166 Now static.
13167 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13168 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13169 (mark_backtrace): Define only if BYTE_MARK_STACK.
13170 * xdisp.c (message_enable_multibyte): Now static.
13171
61c2b50e 13172 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13173 This makes it easier for human readers (and static analyzers)
13174 to see whether these variables are used from other modules.
13175 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13176 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13177 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13178 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13179 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13180 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13181 * xmenu.c, xselect.c:
13182 Declare Q* vars static if they are not used in other modules.
13183 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13184 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13185 Remove decls of unexported vars.
13186 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13187
95c82688
PE
13188 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13189
16a97296
PE
13190 Make Emacs functions such as Fatom 'static' by default.
13191 This makes it easier for human readers (and static analyzers)
13192 to see whether these functions can be called from other modules.
13193 DEFUN now defines a static function. To make the function external
13194 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13195 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13196 (Finit_image_library):
16a97296
PE
13197 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13198 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13199 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13200 Remove decls, since these functions are now static.
13201 (Funintern, Fget_internal_run_time): New decls, since these functions
13202 were already external.
95c82688 13203
16a97296
PE
13204 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13205 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13206 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13207 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13208 * keyboard.c, keymap.c, lread.c:
13209 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13210 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13211 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13212 Mark functions with DEFUE instead of DEFUN,
13213 if they are used in other modules.
13214 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13215 decls for now-static functions.
13216 * buffer.h (Fdelete_overlay): Remove decl.
13217 * callproc.c (Fgetenv_internal): Mark as internal.
13218 * composite.c (Fremove_list_of_text_properties): Remove decl.
13219 (Fcomposition_get_gstring): New forward static decl.
13220 * composite.h (Fcomposite_get_gstring): Remove decl.
13221 * dired.c (Ffile_attributes): New forward static decl.
13222 * doc.c (Fdocumntation_property): New forward static decl.
13223 * eval.c (Ffetch_bytecode): New forward static decl.
13224 (Funintern): Remove extern decl; now in .h file where it belongs.
13225 * fileio.c (Fmake_symbolic_link): New forward static decl.
13226 * image.c (Finit_image_library): New forward static decl.
13227 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13228 * intervals.h (Fprevious_property_change):
13229 (Fremove_list_of_text_properties): Remove decls.
13230 * keyboard.c (Fthis_command_keys): Remove decl.
13231 (Fcommand_execute): New forward static decl.
13232 * keymap.c (Flookup_key): New forward static decl.
13233 (Fcopy_keymap): Now static.
13234 * keymap.h (Flookup_key): Remove decl.
13235 * process.c (Fget_process): New forward static decl.
13236 (Fprocess_datagram_address): Mark as internal.
13237 * syntax.c (Fsyntax_table_p): New forward static decl.
13238 (skip_chars): Remove duplicate decl.
13239 * textprop.c (Fprevious_property_change): New forward static decl.
13240 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13241 Now internal.
13242 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13243 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13244
785bbd42
PE
13245 * editfns.c (Fformat): Remove unreachable code.
13246
8b913b57
AS
132472011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13248
13249 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13250 change. (Bug#8496)
13251
a6744a35
EZ
132522011-04-13 Eli Zaretskii <eliz@gnu.org>
13253
13254 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13255 when at ZV. (Bug#8487)
13256
e7974947
AS
132572011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13258
baad03f0
AS
13259 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13260 (Bug#8437)
13261 * keyboard.c (parse_tool_bar_item): Likewise.
13262 * sound.c (sound_cleanup, alsa_close): Likewise.
13263 * termcap.c (tgetent): Likewise.
13264 * xfns.c (x_default_font_parameter): Likewise.
13265 * xsettings.c (read_and_apply_settings): Likewise.
13266
e7974947
AS
13267 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13268 (overrun_check_free): Protoize.
13269
28272684
PE
132702011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13271
13272 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13273 since callers should never pass a negative size.
13274 Change the signature to match that of plain 'read' and 'write'; see
13275 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13276 * lisp.h: Update prototypes of emacs_write and emacs_read.
13277
11997c76
EZ
132782011-04-11 Eli Zaretskii <eliz@gnu.org>
13279
13280 * xdisp.c (redisplay_window): Don't try to determine the character
13281 position of the scroll margin if the window start point w->startp
e896f03c 13282 is outside the buffer's accessible region. (Bug#8468)
11997c76 13283
8a2cbd72
EZ
132842011-04-10 Eli Zaretskii <eliz@gnu.org>
13285
13286 Fix write-region and its subroutines for buffers > 2GB.
13287 * fileio.c (a_write, e_write): Modify declaration of arguments and
13288 local variables to support buffers larger than 2GB.
13289 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13290
13291 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13292 argument, local variables, and return value.
13293
13294 * lisp.h: Update prototypes of emacs_write and emacs_read.
13295
13296 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13297
4073e537 132982011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13299
1ebfdcb6
PE
13300 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13301
b2ded58d
PE
13302 Fix more problems found by GCC 4.6.0's static checks.
13303
7d66342c
PE
13304 * xdisp.c (vmessage): Use a better test for character truncation.
13305
bbf47d44
PE
13306 * charset.c (load_charset_map): <, not <=, for optimization,
13307 and to avoid potential problems with integer overflow.
9248994d 13308 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13309 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13310 * editfns.c (Fformat): Likewise.
1e69125e 13311 * syntax.c (skip_chars): Likewise.
3befa583 13312
e3019616
PE
13313 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13314 This also lets GCC 4.6.0 generate slightly better loop code.
13315
becfa255
PE
13316 * callint.c (Fcall_interactively): <, not <=, for optimization.
13317 (Fcall_interactively): Count the number of arguments produced,
13318 not the number of arguments given. This is simpler and lets GCC
13319 4.6.0 generate slightly better code.
13320
dae0cd48
PE
13321 * ftfont.c: Distingish more carefully between FcChar8 and char.
13322 The previous code passed unsigned char * to a functions like
13323 strlen and xstrcasecmp that expect char *, which does not
13324 conform to the C standard.
13325 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13326 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13327 char * when the C standard requires it.
13328
76032d70
PE
13329 * keyboard.c (read_char): Remove unused var.
13330
eb3f1cc8
PE
13331 * eval.c: Port to Windows vsnprintf (Bug#8435).
13332 Include <limits.h>.
13333 (SIZE_MAX): Define if the headers do not.
13334 (verror): Do not give up if vsnprintf returns a negative count.
13335 Instead, grow the buffer. This ports to Windows vsnprintf, which
13336 does not conform to C99. Problem reported by Eli Zaretskii.
13337 Also, simplify the allocation scheme, by avoiding the need for
13338 calling realloc, and removing the ALLOCATED variable.
13339
70476b54
PE
13340 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13341
12020a9e
PE
13342 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13343 But keep the doprint source code for now, as we might revamp it
13344 and use it again (Bug#8435).
ea6c7ae6
PE
13345 * lisp.h (doprnt): Remove.
13346 * Makefile.in (base_obj): Remove doprnt.o.
13347 * deps.mk (doprnt.o): Remove.
13348
5fdb398c
PE
13349 error: Print 32- and 64-bit integers portably (Bug#8435).
13350 Without this change, on typical 64-bit hosts error ("...%d...", N)
13351 was used to print both 32- and 64-bit integers N, which relied on
13352 undefined behavior.
61bdb816 13353 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13354 * lisp.h (error, verror): Mark as printf-like functions.
13355 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13356 Report overflow in size calculations when allocating printf buffer.
13357 Do not truncate output string at its first null byte.
13358 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13359 Truncate the output at a character boundary, since vsnprintf does not
13360 do that.
13361 * charset.c (check_iso_charset_parameter): Convert internal
13362 character to string before calling 'error', since %c now has the
13363 printf meaning.
13364 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13365 overflow when computing char to be passed to 'error'. Do not
13366 pass Lisp_Object to 'error'; pass the integer instead.
13367 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13368 formatted with plain %d.
13369
b189fa66
PE
13370 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13371
bff87ef0
PE
13372 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13373
7e2cac20
PE
13374 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13375
ce4d90b5
PE
13376 * xterm.c (x_catch_errors): Remove duplicate declaration.
13377
266c9547
PE
13378 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13379
79c49ad2
PE
13380 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13381
368f4090
JM
133822011-04-10 Jim Meyering <meyering@redhat.com>
13383
13384 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13385 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13386 return ssize_t not "int", and use size_t as the buffer length.
13387 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13388 * gnutls.h: Update declarations.
13389 * process.c (read_process_output): Use ssize_t, to match.
13390 (send_process): Likewise.
13391
a32d4040
CY
133922011-04-09 Chong Yidong <cyd@stupidchicken.com>
13393
13394 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13395
8546720e 133962011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13397
04f2d78b
CB
13398 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13399 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13400
8546720e
GM
13401 * xterm.c (handle_one_xevent):
13402 * xmenu.c (create_and_show_popup_menu):
13403 * xselect.c (x_decline_selection_request)
13404 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13405
0a2f5c1a 134062011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13407
13408 Fix some uses of `int' instead of EMACS_INT.
13409 * search.c (string_match_1, fast_string_match)
13410 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13411 (scan_buffer, find_next_newline_no_quit)
13412 (find_before_next_newline, search_command, Freplace_match)
13413 (Fmatch_data): Make some `int' variables be EMACS_INT.
13414
13415 * xdisp.c (display_count_lines): 3rd argument and return value now
13416 EMACS_INT. All callers changed.
13417 (pint2hrstr): Last argument is now EMACS_INT.
13418
13419 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13420 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13421 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13422 (decode_coding_utf_16, decode_coding_emacs_mule)
13423 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13424 (decode_coding_ccl, decode_coding_charset)
13425 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13426 (decode_coding_iso_2022, decode_coding_emacs_mule)
13427 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13428 <char_offset, last_offset>: Declare EMACS_INT.
13429 (encode_coding_utf_8, encode_coding_utf_16)
13430 (encode_coding_emacs_mule, encode_invocation_designation)
13431 (encode_designation_at_bol, encode_coding_iso_2022)
13432 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13433 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13434 Declare EMACS_INT.
13435 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13436 (encode_invocation_designation): Last argument P_NCHARS is now
13437 EMACS_INT.
13438 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13439 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13440
13441 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13442 All users changed.
13443
13444 * ccl.c (Fccl_execute_on_string): Declare some variables
13445 EMACS_INT.
13446
8546720e 134472011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13448
13449 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13450
4e19a977
CS
134512011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13452
13453 * process.c (Fformat_network_address): Doc fix.
13454
87302331
R
134552011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13456
ee7683eb 13457 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13458
cbb59342
CY
134592011-04-08 Chong Yidong <cyd@stupidchicken.com>
13460
13461 * keyboard.c (read_char): Call Lisp function help-form-show,
13462 instead of using internal_with_output_to_temp_buffer.
13463 (Qhelp_form_show): New var.
e0d38eeb 13464 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13465
13466 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13467
13468 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13469
e67a13ab
CY
134702011-04-06 Chong Yidong <cyd@stupidchicken.com>
13471
04f2d78b
CB
13472 * process.c (Flist_processes): Remove to Lisp.
13473 (list_processes_1): Delete.
e67a13ab 13474
973f782d
EZ
134752011-04-06 Eli Zaretskii <eliz@gnu.org>
13476
7c106b1e
EZ
13477 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13478
973f782d
EZ
13479 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13480
41cf7d1a 134812011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13482
ca23cc88
PE
13483 Fix more problems found by GCC 4.6.0's static checks.
13484
f390e2d5
PE
13485 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13486
42eea0d0
PE
13487 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13488
b69769da 13489 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13490
f9541e84
PE
13491 * xdisp.c (vmessage): Mark as a printf-like function.
13492
13841b55
PE
13493 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13494
c136c10f
PE
13495 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13496
5e2d4a30
PE
13497 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13498 printf-like functions.
13499 (tiff_load): Add casts to remove these marks before passing them
13500 to system-supplied API.
13501
583f48b9
PE
13502 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13503
b25d760e
PE
13504 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13505 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13506 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13507 directly, rather than having caller test rule sign. This avoids
13508 some unnecessary tests.
13509 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13510 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13511 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13512
bc7b6697 13513 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13514 (xfont_open): Avoid unnecessary tests.
bc7b6697 13515
27ccc379
PE
13516 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13517
dcd5c89a
PE
13518 * composite.h, composite.c (composition_gstring_put_cache):
13519 Use EMACS_INT, not int, for length.
13520
b13a45c6
PE
13521 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13522 breaking out part of COMPOSITION_DECODE_RULE.
13523 (COMPOSITION_DECODE_RULE): Use it.
13524 * composite.c (get_composition_id): Remove unused local vars,
13525 by using the new macro.
13526
1e792e4d
PE
13527 * textprop.c (set_text_properties_1): Change while to do-while,
13528 since the condition is always true at first.
13529
dc6c6455 13530 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13531 (interval_deletion_adjustment): Return unsigned value.
13532 All uses changed.
dc6c6455 13533
aba7731a
PE
13534 * process.c (list_processes_1, create_pty, read_process_output):
13535 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13536 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13537 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13538 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13539 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13540
fdfc4bf3
PE
13541 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13542
fca8fe46 13543 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13544 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13545
06a0259a 13546 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13547 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13548 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13549
e7b9e80f
PE
13550 * print.c (print_error_message): Avoid int overflow.
13551
56201685
PE
13552 * font.c (font_list_entities): Redo for clarity,
13553 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13554
78834453 13555 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13556 (font_score): Avoid potential overflow in diff calculation.
78834453 13557
0bc0b309 13558 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13559 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13560
e610eaca
PE
13561 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13562
b895abce
PE
13563 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13564 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13565 can always succeed if overflow has undefined behavior.
13566
1f1d9321 13567 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13568 (wordify): Omit three unnecessary tests.
1f1d9321 13569
c59478bc
PE
13570 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13571 All callers changed. This avoids the need for an unused var.
13572
79b73827
PE
13573 * casefiddle.c (casify_region): Remove var that is set but not used.
13574
a4db5dfe
PE
13575 * dired.c (file_name_completion): Remove var that is set but not used.
13576
43aae36e
PE
13577 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13578
2a47c44d 13579 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13580 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13581
a37c69bf
PE
13582 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13583 Check for integer overflow on size calculations.
13584
328ab8e7
PE
13585 * buffer.c (Fprevious_overlay_change): Remove var that is set
13586 but not used.
13587
e5a2a5cb
PE
13588 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13589 Remove vars that are set but not used.
8d84a6eb 13590 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13591 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13592
a60e5f68
PE
13593 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13594
f661cb61 13595 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13596 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13597
f0397f5a
PE
13598 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13599 that are set but not used.
13600
8664db06 13601 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13602 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13603
6abdaa4a
PE
13604 * xselect.c (x_get_local_selection, x_handle_property_notify):
13605 Remove vars that are set but not used.
13606
0ce7538d 13607 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13608 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13609
9ae848fc
PE
13610 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13611 Remove var that is set but not used.
0b918413
PE
13612 (scroll_bar_windows_size): Now size_t, not int.
13613 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13614 Check for overflow.
9ae848fc 13615
a5a62657
PE
13616 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13617 (map_tty_color) [!defined MSDOS]: Likewise.
13618
5c5cdd39
PE
13619 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13620
66ebf983
PE
13621 * coding.c: Remove vars that are set but not used.
13622 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13623 All callers changed.
13624 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13625 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13626 (decode_coding_charset): Remove vars that are set but not used.
13627
1be4d761
PE
13628 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13629 that is set but not used.
13630
47553fa8
PE
13631 * print.c (print_object): Remove var that is set but not used.
13632
1f7196bf 13633 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13634 The gnulib version avoids calling malloc in the usual case,
13635 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13636 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13637 * filelock.c (current_lock_owner): Likewise.
13638 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13639 * sysdep.c: Include allocator.h, careadlinkat.h.
13640 (emacs_no_realloc_allocator): New static constant.
13641 (emacs_readlink): New function.
fdb61804
PE
13642 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13643 ../lib/careadlinkat.h.
d1fdcab7 13644
f84c17c7
SM
136452011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13646
13647 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13648 first non-nil return value).
13649
ef3862ad
JD
136502011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13651
13652 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13653 if not defined (Bug#8403).
13654
376a7006
JB
136552011-04-02 Juanma Barranquero <lekktu@gmail.com>
13656
13657 * xdisp.c (display_count_lines): Remove parameter `start',
13658 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13659 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13660 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13661 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13662 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13663 and thereabouts. All callers changed.
13664 (get_per_char_metric): Remove parameter `f', unused since
13665 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13666
6ca3801d
JM
136672011-04-02 Jim Meyering <meyering@redhat.com>
13668
13669 do not dereference NULL upon failed strdup
13670 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13671 (ns_get_family): Likewise.
13672
d8e2b5ba
JB
136732011-04-02 Juanma Barranquero <lekktu@gmail.com>
13674
13675 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13676
8c74fcbd
JD
136772011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13678
13679 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13680 later (Bug#8403).
13681
7200d79c
SM
136822011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13683
03408648 13684 Add lexical binding.
7200d79c 13685
03408648
SM
13686 * window.c (Ftemp_output_buffer_show): New fun.
13687 (Fsave_window_excursion):
13688 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13689
13690 * lread.c (lisp_file_lexically_bound_p): New function.
13691 (Fload): Bind Qlexical_binding.
13692 (readevalloop): Remove `evalfun' arg.
13693 Bind Qinternal_interpreter_environment.
13694 (Feval_buffer): Bind Qlexical_binding.
13695 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13696 Mark as dynamic.
13697 (syms_of_lread): Declare `lexical-binding'.
13698
13699 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13700
13701 * keyboard.c (eval_dyn): New fun.
13702 (menu_item_eval_property): Use it.
ca105506
SM
13703
13704 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13705
03408648
SM
13706 * fns.c (concat, mapcar1): Accept byte-code-functions.
13707
13708 * eval.c (Fsetq): Handle lexical vars.
13709 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13710 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13711 (FletX, Flet): Obey lexical binding.
13712 (Fcommandp): Handle closures.
13713 (Feval): New `lexical' arg.
13714 (eval_sub): New function extracted from Feval. Use it almost
13715 everywhere where Feval was used. Look up vars in lexical env.
13716 Handle closures.
13717 (Ffunctionp): Move from subr.el.
13718 (Ffuncall): Handle closures.
13719 (apply_lambda): Remove `eval_flags'.
13720 (funcall_lambda): Handle closures and new byte-code-functions.
13721 (Fspecial_variable_p): New function.
13722 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13723 but without exporting it to Lisp.
23aba0ea 13724
23aba0ea 13725 * doc.c (Fdocumentation, store_function_docstring):
03408648 13726 * data.c (Finteractive_form): Handle closures.
23aba0ea 13727
03408648
SM
13728 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13729 interactive spec.
ba83908c 13730
04f2d78b
CB
13731 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13732 New byte-codes.
03408648
SM
13733 (exec_byte_code): New function extracted from Fbyte_code to handle new
13734 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13735
03408648 13736 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13737
03408648 13738 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13739
e2abce01
JB
137402011-03-31 Juanma Barranquero <lekktu@gmail.com>
13741
13742 * xdisp.c (redisplay_internal): Fix prototype.
13743
63696a73 137442011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13745
63696a73 13746 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13747 (try_scrolling): Use it when setting scroll_limit.
13748 Limit scrolling to 100 screen lines.
63696a73
EZ
13749 (redisplay_window): Even when falling back on "recentering",
13750 position point in the window according to scroll-conservatively,
13751 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13752
13753 (try_scrolling): When point is above the window, allow searching
13754 as far as scroll_max, or one screenful, to compute vertical
13755 distance from PT to the scroll margin position. This prevents
13756 try_scrolling from unnecessarily failing when
13757 scroll-conservatively is set to a value slightly larger than the
13758 window height. Clean up the case of PT below the margin at bottom
13759 of window: scroll_max can no longer be INT_MAX. When aggressive
13760 scrolling is in use, don't let point enter the opposite scroll
13761 margin as result of the scroll.
13762 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13763 threshold of 100 lines for never-recentering scrolling.
13764
e4cc2dfc
JB
137652011-03-31 Juanma Barranquero <lekktu@gmail.com>
13766
13767 * dispextern.h (move_it_by_lines):
13768 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13769 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13770 (message_log_check_duplicate): Remove parameters `prev_bol' and
13771 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13772 (redisplay_internal): Remove parameter `preserve_echo_area',
13773 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13774
13775 * indent.c (Fvertical_motion):
13776 * window.c (window_scroll_pixel_based, Frecenter):
13777 Don't pass `need_y_p' to `move_it_by_lines'.
13778
1c470562
SM
137792011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13780
44f230aa
SM
13781 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13782 steal a few bits to be more compact.
13783 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13784 Remove unneeded casts.
13785
1c470562
SM
13786 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13787
888adce9
ZK
137882011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13789
13790 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13791 binding" message (bug#7967).
13792
f838ed7b
PE
137932011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13794
77861b95
PE
13795 Fix more problems found by GCC 4.6.0's static checks.
13796
de6dbc14
PE
13797 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13798 Remove unused local var.
13799
f838ed7b
PE
13800 * editfns.c (Fmessage_box): Remove unused local var.
13801
792c7b2b
PE
13802 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13803 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13804 Omit unused local vars.
c499e557 13805 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13806 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13807 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13808 Omit unused local var.
13809
ba0165e1
PE
13810 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13811 Don't assume string length fits in int.
32ad8845 13812 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13813 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13814
3c59b4c9
PE
13815 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13816 instead of alloca (Bug#8344).
13817
a3eed478 13818 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13819 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13820
eb4d412d
PE
13821 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13822
1658b401
PE
13823 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13824 concerns.
13825
13826 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13827
13828 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13829
9a2c6e05
PE
13830 * keyboard.c (syms_of_keyboard): Use the same style as later
13831 in this function when indexing through an array. This also
13832 works around GCC bug 48267.
13833
03d0a109
PE
13834 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13835
44f730c8
PE
13836 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13837
fe75f926
PE
13838 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13839 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13840
ffa8c828
PE
13841 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13842 This avoids undefined behavior on integer overflow, and is a bit
13843 more convenient anyway since it is compared to a size_t variable.
13844
c5101a77
PE
13845 Variadic C functions now count arguments with size_t, not int.
13846 This avoids an unnecessary limitation on 64-bit machines, which
13847 caused (substring ...) to crash on large vectors (Bug#8344).
13848 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13849 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13850 All variadic functions and their callers changed accordingly.
c5101a77
PE
13851 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13852 * data.c (arith_driver, float_arith_driver): Likewise.
13853 * editfns.c (general_insert_function): Likewise.
13854 * eval.c (struct backtrace.nargs, interactive_p)
13855 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13856 (funcall_lambda, mark_backtrace): Likewise.
13857 * fns.c (concat): Likewise.
13858 * frame.c (x_set_frame_parameters): Likewise.
13859 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13860 0 if not found, not -1. All callers changed.
13861
dd3f25f7
PE
13862 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13863 (stack_copy_size): Now size_t, not int.
13864 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13865
461c2ab9
JB
138662011-03-28 Juanma Barranquero <lekktu@gmail.com>
13867
13868 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13869 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13870 All callers changed.
13871
13872 * lisp.h (multibyte_char_to_unibyte):
13873 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13874 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13875 * character.h (CHAR_TO_BYTE8):
13876 * cmds.c (internal_self_insert):
13877 * editfns.c (general_insert_function):
13878 * keymap.c (push_key_description):
13879 * search.c (Freplace_match):
13880 * xdisp.c (message_dolog, set_message_1): All callers changed.
13881
f6d62986
SM
138822011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13883
13884 * keyboard.c (safe_run_hook_funcall): New function.
13885 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13886 don't set the hook to nil, but remove the offending function instead.
13887 (Qcommand_hook_internal): Remove, unused.
13888 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13889 Vcommand_hook_internal.
13890
13891 * eval.c (enum run_hooks_condition): Remove.
13892 (funcall_nil, funcall_not): New functions.
13893 (run_hook_with_args): Call each function through a `funcall' argument.
13894 Remove `cond' argument, now redundant.
13895 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13896 (Frun_hook_with_args_until_failure): Adjust accordingly.
13897 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13898
1db5b1ad
JB
138992011-03-28 Juanma Barranquero <lekktu@gmail.com>
13900
13901 * dispextern.h (string_buffer_position): Remove declaration.
13902
13903 * print.c (strout): Remove parameter `multibyte', unused since
13904 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13905
13906 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13907 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13908 All callers changed.
13909
13910 * w32.c (_wsa_errlist): Use braces for struct initializers.
13911
13912 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13913 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13914 All callers changed.
13915 (string_buffer_position): Likewise. Also, make static (it's never
13916 used outside xdisp.c).
13917 (cursor_row_p): Remove parameter `w', unused since
13918 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13919 (decode_mode_spec): Remove parameter `precision', introduced during
13920 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13921 All callers changed.
13922
5ffb62aa
JD
139232011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13924
13925 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13926
461c2ab9 139272011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13928
13929 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13930 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13931 (ns_update_auto_hide_menu_bar): New functions.
13932 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13933 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13934 ns_constrain_all_frames.
13935 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13936 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13937
5c380ffb
JD
139382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13939
13940 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13941
9af30bdf
GM
139422011-03-27 Glenn Morris <rgm@gnu.org>
13943
13944 * syssignal.h: Replace RETSIGTYPE with void.
13945 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13946 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13947 Replace SIGTYPE with void everywhere.
13948 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13949 * s/template.h (SIGTYPE): Remove commented out definition.
13950
e2abce01
JB
139512011-03-26 Eli Zaretskii <eliz@gnu.org>
13952
13953 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13954 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13955
f868cd8a
JB
139562011-03-26 Juanma Barranquero <lekktu@gmail.com>
13957
59eb0929
JB
13958 * w32.c (read_unc_volume): Use parameter `henum', instead of
13959 global variable `wget_enum_handle'.
13960
13961 * keymap.c (describe_vector): Remove parameters `indices' and
13962 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13963 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13964
f868cd8a
JB
13965 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13966
13967 * keyboard.c (timer_check): Remove parameter `do_it_now',
13968 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13969 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13970 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13971
13972 * keyboard.c (read_char):
13973 * w32menu.c (w32_menu_display_help):
13974 * xmenu.c (show_help_event, menu_help_callback):
13975 Adjust calls to `show_help_echo'.
13976
13977 * gtkutil.c (xg_maybe_add_timer):
13978 * keyboard.c (readable_events):
13979 * process.c (wait_reading_process_output):
13980 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13981
13982 * insdel.c (adjust_markers_gap_motion):
13983 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13984 (gap_left, gap_right): Don't call it.
13985
2ecf6fdb
CY
139862011-03-25 Chong Yidong <cyd@stupidchicken.com>
13987
13988 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13989 incurred during fontification.
13990
6b1f9ba4
JB
139912011-03-25 Juanma Barranquero <lekktu@gmail.com>
13992
13993 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13994 (DEFVAR_PER_BUFFER): Don't pass it.
13995
13996 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13997 (scrolling_window): Don't pass it.
13998
0f4a96b5
JB
139992011-03-25 Juanma Barranquero <lekktu@gmail.com>
14000
14001 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14002
14003 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14004 and `suffix'.
14005 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14006 of variables specific to SELinux and computation of `encoded_absname'.
14007
14008 * image.c (XPutPixel): Remove unused variable `height'.
14009
14010 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14011
14012 * unexw32.c (get_section_info): Remove unused variable `section'.
14013
14014 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14015 (system_process_attributes): Remove unused variable `sess'.
14016 (sys_read): Remove unused variable `err'.
14017
14018 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14019 (w32_wnd_proc): Remove unused variable `isdead'.
14020 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14021 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14022 (x_create_tip_frame): Remove unused variable `tem'.
14023
14024 * w32inevt.c (w32_console_read_socket):
14025 Remove unused variable `no_events'.
14026
14027 * w32term.c (x_draw_composite_glyph_string_foreground):
14028 Remove unused variable `width'.
14029
1149507c
JB
140302011-03-24 Juanma Barranquero <lekktu@gmail.com>
14031
14032 * w32term.c (x_set_glyph_string_clipping):
14033 Don't pass uninitialized region to CombineRgn.
14034
9c88f339
JB
140352011-03-23 Juanma Barranquero <lekktu@gmail.com>
14036
14037 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14038 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14039 (Fx_close_connection): Remove unused variable `i'.
14040
14041 * w32font.c (w32font_draw): Return number of glyphs.
14042 (w32font_open_internal): Remove unused variable `i'.
14043 (w32font_driver): Add missing initializer.
14044
14045 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14046 (fill_in_menu): Remove unused variable `items_added'.
14047
14048 * w32term.c (last_mouse_press_frame): Remove static global variable.
14049 (w32_clip_to_row): Remove unused variable `f'.
14050 (x_delete_terminal): Remove unused variable `i'.
14051
14052 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14053 (NOTHING): Remove unused static global variable.
14054 (uniscribe_check_otf): Remove unused variable `table'.
14055 (uniscribe_font_driver): Add missing initializers.
14056
dee091a3
JD
140572011-03-23 Julien Danjou <julien@danjou.info>
14058
14059 * term.c (Fsuspend_tty, Fresume_tty):
14060 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14061 * window.c (temp_output_buffer_show):
14062 * insdel.c (signal_before_change):
14063 * frame.c (Fhandle_switch_frame):
14064 * fileio.c (Fdo_auto_save):
14065 * emacs.c (Fkill_emacs):
14066 * editfns.c (save_excursion_restore):
14067 * cmds.c (internal_self_insert):
14068 * callint.c (Fcall_interactively):
14069 * buffer.c (Fkill_all_local_variables):
14070 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14071 Use Frun_hooks.
0f4a96b5 14072 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14073 unconditionally since it does the check itself.
dee091a3 14074
2c520ab5 140752011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14076
c9c49752
PE
14077 Fix more problems found by GCC 4.5.2's static checks.
14078
8abc3f12
PE
14079 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14080 the first time through the loop, since we know p0 < p1 then.
14081 This also avoids a gcc -Wstrict-overflow warning.
14082
a2d26660
PE
14083 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14084 leading to a memory leak, possible in functions like
14085 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14086 of objects (Bug#8318).
a2d26660 14087
916c72e9
PE
14088 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14089 that could (at least in theory) be that large.
14090
19ab8a18
PE
14091 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14092 This is less likely to overflow, and avoids undefined behavior if
14093 overflow does occur. All callers changed. Use strtoul to scan
14094 for the unsigned long integer.
b7cbbd6f
PE
14095 (pint2hrstr): Simplify and tune code slightly.
14096 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14097
f0641eff
PE
14098 * scroll.c (do_scrolling): Work around GCC bug 48228.
14099 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14100
7f650bb9
PE
14101 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14102 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14103 (validate_x_resource_name): Simplify count usage.
14104 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14105
37dd57d1
PE
14106 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14107 fail (Bug#8306).
81e56e61 14108
699979fc 14109 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14110
401bf9b4
PE
14111 * process.c (Fmake_network_process): Use socklen_t, not int,
14112 where POSIX says socklen_t is required in portable programs.
14113 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14114 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14115 (Fmake_network_process, server_accept_connection):
14116 (wait_reading_process_output, read_process_output):
14117 Likewise.
14118
b93aacde
PE
14119 * process.c: Rename or move locals to avoid shadowing.
14120 (list_processes_1, Fmake_network_process):
14121 (read_process_output_error_handler, exec_sentinel_error_handler):
14122 Rename or move locals.
4dc343ee 14123 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14124 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14125 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14126 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14127 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14128
af8a867c 14129 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14130 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14131 Include tparam.h instead, since it declares them.
af8a867c
PE
14132 * cm.h (PC): Remove extern decl; tparam.h now does this.
14133 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14134 * terminfo.c: Include tparam.h, to check interfaces.
14135 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14136 (tparam): Adjust signature to match interface in tparam.h;
14137 this removes some undefined behavior. Check that outstring and len
14138 are zero, which they always are with Emacs.
14139 * tparam.h (PC, BC, UP): New extern decls.
14140
0248044d 14141 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14142 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14143
8ff096c1 14144 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14145 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14146 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14147 (ftfont_list): Remove unused local.
49eaafba
PE
14148 (get_adstyle_property, ftfont_pattern_entity):
14149 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14150 Rename locals to avoid shadowing.
8ff096c1 14151
e2be39f6
PE
14152 * xfont.c (xfont_list_family): Mark var as initialized.
14153
c9735e30
PE
14154 * xml.c (make_dom): Now static.
14155
8f5201ae
PE
14156 * composite.c (composition_compute_stop_pos): Rename local to
14157 avoid shadowing.
b246f932
PE
14158 (composition_reseat_it): Remove unused locals.
14159 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14160 (composition_update_it): Mark var as initialized.
11b61122
PE
14161 (find_automatic_composition): Mark vars as initialized,
14162 with a FIXME (Bug#8290).
8f5201ae 14163
760fbc2c
PE
14164 character.h: Rename locals to avoid shadowing.
14165 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14166 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14167 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14168 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14169 to avoid shadowing.
14170
ff08eb85
PE
14171 * textprop.c (property_change_between_p): Remove; unused.
14172
fc7bf025
PE
14173 * intervals.c (interval_start_pos): Now static.
14174
235d7abc
PE
14175 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14176
44f230aa
SM
14177 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14178 Rename locals to avoid shadowing.
3e7d6594 14179
50060332
PE
14180 * sound.c (wav_play, au_play, Fplay_sound_internal):
14181 Fix pointer signedness.
d01f234b 14182 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14183 (wav_play): Initialize a variable to 0, to prevent undefined
14184 behavior (Bug#8278).
50060332 14185
c4fc4e30
PE
14186 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14187
918436ed
PE
14188 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14189
c939f91b
PE
14190 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14191 clobbering (Bug#8298).
b9c7f648
PE
14192 * sysdep.c (sys_subshell): Likewise.
14193 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14194
6bd8c144
PE
14195 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14196 This should get cleaned up, so that child_setup has the
14197 same signature on all platforms.
14198
7710357c 14199 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14200 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14201
c59da222
CY
142022011-03-22 Chong Yidong <cyd@stupidchicken.com>
14203
14204 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14205 not to be necessary, and produces flickering.
14206
66b87493
GM
142072011-03-20 Glenn Morris <rgm@gnu.org>
14208
14209 * config.in: Remove file.
14210
45b6f6d5
JB
142112011-03-20 Juanma Barranquero <lekktu@gmail.com>
14212
14213 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14214 are now in src/globals.h.
14215 (syms_of_minibuf): Remove spurious & from previous change.
14216
cd394be1 142172011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14218
14219 * minibuf.c (completing-read-function): New variable.
14220 (completing-read-default): Rename from completing-read.
14221 (completing-read): Call completing-read-function.
14222
b14e3e21
CY
142232011-03-19 Juanma Barranquero <lekktu@gmail.com>
14224
14225 * xfaces.c (Fx_load_color_file):
14226 Read color file from absolute filename (bug#8250).
14227
f2b726e6
JB
142282011-03-19 Juanma Barranquero <lekktu@gmail.com>
14229
14230 * makefile.w32-in: Update dependencies.
14231
09f6ff02
EZ
142322011-03-17 Eli Zaretskii <eliz@gnu.org>
14233
14234 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14235
29a6015a
PE
142362011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14237
a3a6c54e
PE
14238 Fix more problems found by GCC 4.5.2's static checks.
14239
b766f867
PE
14240 * process.c (make_serial_process_unwind, send_process_trap):
14241 (sigchld_handler): Now static.
14242
be02381c
PE
14243 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14244 That way, the code declares only the vars that it needs.
14245 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14246 * s/cygwin.h (PTY_ITERATION): Likewise.
14247 * s/darwin.h (PTY_ITERATION): Likewise.
14248 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14249
57048744
PE
14250 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14251 * process.c (allocate_pty): Don't declare stb unless it's needed.
14252
7914961c 14253 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14254 (CONSTANTLIM): Remove; unused.
14255 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14256 Define only if needed.
7914961c 14257
b3967b18
PE
14258 * unexelf.c (unexec): Name an expression,
14259 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14260 Use a different way to cause a compilation error if anyone uses
14261 n rather than nn, a way that does not involve shadowing.
73366a00 14262 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14263
29a6015a
PE
14264 * deps.mk (unexalpha.o): Remove; unused.
14265
43cfc33e 14266 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14267 * unexec.h: New file.
ce701a33
PE
14268 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14269 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14270 Depend on unexec.h.
14271 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14272 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14273 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14274 Change as necessary to match prototype in unexec.h.
ce701a33 14275
01f44d5a
PE
14276 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14277 shadowing.
4f63c6bb 14278 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14279
a6670b0b
PE
14280 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14281 Rename locals to avoid shadowing.
14282
cef2010d 14283 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14284 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14285
d4d7173a
PE
14286 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14287
f08b802a
PE
14288 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14289 warning when compiling print.c.
14290
3ddb0639
PE
14291 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14292 instead of using an uninitialized var.
5ad03b97 14293 (font_sort_entities): Mark var as initialized.
3ddb0639 14294
170a2692
PE
14295 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14296
e663c700
PE
14297 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14298 pointers to constants.
89bc529a 14299 (font_parse_fcname): Remove unused vars.
7b81e2d0 14300 (font_delete_unmatched): Now static.
ea838e10 14301 (font_get_spec): Remove; unused.
13a547c6
PE
14302 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14303 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14304 Rename or move locals to avoid shadowing.
e663c700 14305
2a80c887 14306 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14307 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14308
1384fa33 14309 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14310 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14311
8b2c52e9
PE
14312 * alloc.c (mark_backtrace): Move decl from here ...
14313 * lisp.h: ... to here, so that it can be checked.
14314
475545b5 14315 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14316 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14317 (lisp_indirect_variable): Name an expression,
14318 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14319 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14320
b1349114 14321 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14322 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14323 Use const pointer when appropriate.
b1349114 14324
a2928364
PE
14325 * lisp.h (get_system_name, get_operating_system_release):
14326 Move decls here, to check interfaces.
14327 * process.c (get_operating_system_release): Move decl to lisp.h.
14328 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14329 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14330 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14331 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14332 (Fformat_time_string, Fencode_time, Finsert_char):
14333 (Ftranslate_region_internal, Fformat):
14334 Rename or remove local vars to avoid shadowing.
9710023e 14335 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14336
a415e694
PE
14337 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14338 avoid shadowing.
14339
8ef4622d
PE
14340 * lisp.h (eassert): Check that the argument compiles, even if
14341 ENABLE_CHECKING is not defined.
14342
946f9a5b
PE
14343 * data.c (Findirect_variable): Name an expression, to avoid
14344 gcc -Wbad-function-cast warning.
112396d6 14345 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14346 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14347 (Fmake_variable_buffer_local, Fmake_local_variable):
14348 Mark variables as initialized.
52746918 14349 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14350
e5aab7e7 14351 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14352 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14353 Rename locals to avoid shadowing.
dff45157
PE
14354 (mark_stack): Move local variables into the #ifdef region where
14355 they're used.
7bc26fdb
PE
14356 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14357 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14358 needed otherwise.
14359 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14360 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14361 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14362
e5aab7e7
PE
14363 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14364 avoids undefined behavior in theory.
14365
4da60324
PE
14366 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14367
88043301
PE
14368 Use functions, not macros, for up- and down-casing (Bug#8254).
14369 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14370 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14371 to use the following functions instead of these macros.
14372 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14373 EMACS_INT, since callers assume the returned value fits in int.
14374 (upcase1): Likewise, for UPCASE_TABLE.
14375 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14376 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14377 the race-condition problem in the old DOWNCASE.
88043301 14378
19ed5445
PE
14379 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14380 Rename locals to avoid shadowing.
14381 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14382 (regex_compile, re_search_2, re_match_2_internal):
14383 Remove unused local vars.
952db0d7
PE
14384 (FREE_VAR): Rewrite so as not to use empty "else",
14385 which gcc can warn about.
da053e48 14386 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14387 (RETALLOC_IF): Define only if needed.
14388 (WORDCHAR_P): Likewise. This one is never needed, but is used
14389 only in a comment talking about a compiler bug, so put inside
14390 the #if 0 of that comment.
14391 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14392 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14393 Remove; unused.
19ed5445 14394
1f3561e4 14395 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14396 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14397 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14398
ded6f8f7
PE
14399 * search.c (simple_search): Remove unused var.
14400
dbd37a95
PE
14401 * dired.c (compile_pattern): Move decl from here ...
14402 * lisp.h: ... to here, so that it can be checked.
14403 (struct re_registers): New forward decl.
14404
7e47afad
PE
14405 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14406
85f24f61
PE
14407 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14408 All uses changed.
14409 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14410 Rename locals to avoid shadowing.
5671df8f 14411 (Fvertical_motion): Mark locals as initialized.
85f24f61 14412
181aa2be 14413 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14414 (casify_region): Mark local as initialized.
181aa2be 14415
930d429c
PE
14416 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14417
7082eac6
PE
14418 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14419 New macros, so that the caller can use some names other than
14420 gcpro1, gcpro2, etc.
14421 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14422 of the new macros.
14423 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14424 argument, for consistency with GCPRO2_VAR, etc: it is now the
14425 prefix of the variable, not the variable itself. All uses
14426 changed.
38b2c076
PE
14427 * dired.c (directory_files_internal, file_name_completion):
14428 Rename locals to avoid shadowing.
14429
15206ed9
PE
14430 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14431 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14432 dired.c's scmp function, had undefined behavior.
14433 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14434 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14435 * buffer.h: ... to here, because these macros use current_buffer,
14436 and the new implementation with inline functions needs to have
14437 current_buffer in scope now, rather than later when the macros
14438 are used.
14439 (downcase, upcase1): New static inline functions.
14440 (DOWNCASE, UPCASE1): Reimplement using these functions.
14441 This avoids undefined behavior in expressions like
14442 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14443 from race conditions in accessing the global variables
14444 case_temp1 and case_temp2.
14445 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14446 * lisp.h (case_temp1, case_temp2): Remove their decls.
14447 * character.h (ASCII_CHAR_P): Move from here ...
14448 * lisp.h: ... to here, so that the inline functions mentioned
14449 above can use them.
14450
4a6bea26
PE
14451 * dired.c (directory_files_internal_unwind): Now static.
14452
f14b7e14
PE
14453 * fileio.c (file_name_as_directory, directory_file_name):
14454 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14455 Now static.
2893f146
PE
14456 (file_name_as_directory): Use const pointers when appropriate.
14457 (Fexpand_file_name): Likewise. In particular, newdir might
14458 point at constant storage, so make it a const pointer.
fd4ead52 14459 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14460 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14461 signedness issues.
f839df0c
PE
14462 (Fset_file_times, Finsert_file_contents, auto_save_error):
14463 Rename locals to avoid shadowing.
f14b7e14 14464
5716756e 14465 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14466 (Ftry_completion, Fall_completions): Rename or remove locals
14467 to avoid shadowing.
5716756e 14468
b4c3046a
PE
14469 * marker.c (bytepos_to_charpos): Remove; unused.
14470
b45db522
PE
14471 * lisp.h (verify_bytepos, count_markers): New decls,
14472 so that gcc does not warn that these functions aren't declared.
14473
85876d07
PE
14474 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14475 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14476 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14477 (copy_text): Remove unused local var.
85876d07 14478
03d78a21 14479 * filelock.c (within_one_second): Now static.
b3dd38ab 14480 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14481
5df8f01b
PE
14482 * buffer.c (fix_overlays_before): Mark locals as initialized.
14483 (fix_start_end_in_overlays): Likewise. This function should be
14484 simplified by using pointers-to-pointers, but that's a different
14485 matter.
b1d876f1 14486 (switch_to_buffer_1): Now static.
8f54f30a
PE
14487 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14488 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14489
a70072c9 14490 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14491 Fix pointer signedness issue.
edced198
PE
14492 (sys_subshell): Mark local as volatile if checking for lint,
14493 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14494 (MAXPATHLEN): Define only if needed.
a70072c9 14495
a0977c44
PE
14496 * process.c (serial_open, serial_configure): Move decls from here ...
14497 * systty.h: ... to here, so that they can be checked.
14498
a884fdcc
PE
14499 * fns.c (get_random, seed_random): Move extern decls from here ...
14500 * lisp.h: ... to here, so that they can be checked.
14501
604efe86 14502 * sysdep.c (reset_io): Now static.
b8950c94 14503 (wait_for_termination_signal): Remove; unused.
604efe86 14504
38fc62d9
PE
14505 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14506 (copy_keymap_item, append_key, push_text_char_description):
14507 Now static.
1004a21a 14508 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14509 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14510 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14511 (describe_map_tree):
14512 Rename locals to avoid shadowing.
38fc62d9 14513
2f2650da
PE
14514 * keyboard.c: Declare functions static if they are not used elsewhere.
14515 (echo_char, echo_dash, cmd_error, top_level_2):
14516 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14517 (read_char, kbd_buffer_get_event, make_lispy_position):
14518 (make_lispy_event, make_lispy_movement, apply_modifiers):
14519 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14520 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14521 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14522 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14523 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14524
a053e86c 14525 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14526 (mark_kboards): Move decl here ...
14527 * alloc.c (mark_kboards): ... from here.
a053e86c 14528
4752793e
PE
14529 * lisp.h (force_auto_save_soon): New decl.
14530
74f10ca7 14531 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14532 (DEFINE_DUMMY_FUNCTION): New macro.
14533 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14534 Use it.
c03cd23f
PE
14535 (main): Add casts to avoid warnings
14536 if GCC considers string literals to be constants.
74f10ca7 14537
022e70d4
PE
14538 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14539
59d6fe83
PE
14540 * dbusbind.c: Pointer signedness fixes.
14541 (xd_signature, xd_append_arg, xd_initialize):
14542 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14543 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14544 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14545 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14546
78320123
PE
14547 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14548 if GCC considers string literals to be constants.
49cebcca 14549 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14550
35ac2a97
SM
145512011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14552
fb103ca9
SM
14553 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14554 (print_preprocess, print_object): New macro to fix last change.
14555
35ac2a97
SM
14556 * print.c (print_preprocess): Don't forget font objects.
14557
62973b41
JB
145582011-03-16 Juanma Barranquero <lekktu@gmail.com>
14559
14560 * emacs.c (USAGE3): Doc fixes.
14561
0e48bb22
AS
145622011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14563
14564 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14565 structure.
14566
7684e57b
JB
145672011-03-14 Juanma Barranquero <lekktu@gmail.com>
14568
14569 * lisp.h (VWindow_system, Qfile_name_history):
14570 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14571 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14572 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14573
14574 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14575 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14576
14577 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14578 * w32console.c (detect_input_pending, read_input_pending)
14579 (encode_terminal_code):
14580 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14581 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14582 (w32_system_caret_y, Qfile_name_history):
14583 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14584 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14585 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14586 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14587 * w32proc.c (Qlocal, report_file_error):
14588 * w32term.c (Vwindow_system, updating_frame):
14589 * w32uniscribe.c (initialized, uniscribe_font_driver):
14590 Remove unneeded extern declarations.
14591
2aa46d6c
CY
145922011-03-14 Chong Yidong <cyd@stupidchicken.com>
14593
c96bbc66 14594 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14595
cffc6f3b
CY
145962011-03-13 Chong Yidong <cyd@stupidchicken.com>
14597
14598 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14599 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14600 These macros can no longer be used for assignment.
14601
44f230aa
SM
14602 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14603 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14604 (record_buffer_markers, fetch_buffer_markers): New functions for
14605 recording and fetching special buffer markers.
14606 (set_buffer_internal_1, set_buffer_temp): Use them.
14607
14608 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14609
14610 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14611
14612 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14613 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14614
14615 * xdisp.c (hscroll_window_tree):
14616 (reconsider_clip_changes): Use PT instead of BUF_PT.
14617
d251f04b
EZ
146182011-03-13 Eli Zaretskii <eliz@gnu.org>
14619
14620 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14621 $(EMACS_ROOT)/lib/intprops.h.
14622
f0c77cd1
PE
146232011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14624
3eca4629
PE
14625 Fix more problems found by GCC 4.5.2's static checks.
14626
7c86ee98
PE
14627 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14628 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14629 (xg_free_frame_widgets): Make it clear that a local variable is
14630 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14631 (gdk_window_get_screen): Make it clear that this macro is needed
14632 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14633 (int_gtk_range_get_value): New function, which avoids a diagnostic
14634 from gcc -Wbad-function-cast.
14635 (xg_set_toolkit_scroll_bar_thumb): Use it.
14636 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14637 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14638 (get_utf8_string, xg_get_file_with_chooser):
14639 Rename locals to avoid shadowing.
14640 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14641
41729b81
PE
14642 * xgselect.c (xg_select): Remove unused var.
14643
f0c77cd1
PE
14644 * image.c (four_corners_best): Mark locals as initialized.
14645 (gif_load): Initialize transparent_p to zero (Bug#8238).
14646 Mark another local as initialized.
ec6cf4c6 14647 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14648
ce0ad53d 14649 * image.c (clear_image_cache): Now static.
d5d5a617 14650 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14651 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14652 (x_edge_detection): Remove unnecessary cast that
14653 gcc -Wbad-function-cast diagnoses.
2037898d 14654 (gif_load): Fix pointer signedness.
6ae141d6
PE
14655 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14656 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14657
33383987 146582011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14659
d32df629
PE
14660 Improve quality of tests for time stamp overflow.
14661 For example, without this patch (encode-time 0 0 0 1 1
14662 1152921504606846976) returns the obviously-bogus value (-948597
14663 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14664 reports time overflow. See
14665 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14666 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14667 * editfns.c: Include limits.h and intprops.h.
14668 (TIME_T_MIN, TIME_T_MAX): New macros.
14669 (time_overflow): Move earlier, to before first use.
14670 (hi_time, lo_time): New functions, for an accurate test for
14671 out-of-range times.
14672 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14673 (Fget_internal_run_time): Don't assume time_t fits in int.
14674 (make_time): Use list2 instead of Fcons twice.
14675 (Fdecode_time): More accurate test for out-of-range times.
14676 (check_tm_member): New function.
14677 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14678 (lisp_time_argument): Don't rely on undefined left-shift and
14679 right-shift behavior when checking for time stamp overflow.
8be6f318 14680
fe31d94c
PE
14681 * editfns.c (time_overflow): New function, refactoring common code.
14682 (Fformat_time_string, Fdecode_time, Fencode_time):
14683 (Fcurrent_time_string): Use it.
14684
8be6f318
PE
14685 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14686 * dired.c (make_time): Move to ...
14687 * editfns.c (make_time): ... here.
14688 * systime.h: Note the move.
14689
09d9db2c 146902011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14691
126bc0dc
YM
14692 * fringe.c (update_window_fringes): Remove unused variables.
14693
c47cbdfd
YM
14694 * unexmacosx.c (copy_data_segment): Also copy __got section.
14695 (Bug#8223)
14696
7ac80be9
EZ
146972011-03-12 Eli Zaretskii <eliz@gnu.org>
14698
c96bbc66 14699 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14700 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14701 Constify `char *' arguments and their references according to
14702 prototypes in tparam.h.
14703
ecb0f94d 14704 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14705
7ac80be9
EZ
14706 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14707 Adapt all references accordingly.
14708
14709 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14710
ef1fd07e
TT
147112011-03-11 Tom Tromey <tromey@redhat.com>
14712
14713 * buffer.c (syms_of_buffer): Remove obsolete comment.
14714
7ef4b50c
EZ
147152011-03-11 Eli Zaretskii <eliz@gnu.org>
14716
14717 * termhooks.h (encode_terminal_code): Declare prototype.
14718
14719 * msdos.c (encode_terminal_code): Don't declare prototype.
14720
14721 * term.c (encode_terminal_code): Now external again, used by
14722 w32console.c and msdos.c.
14723
44f230aa
SM
14724 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14725 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14726
4b1ec863 147272011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14728
1714f52b 14729 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14730
4b1ec863
PE
14731 * fringe.c (update_window_fringes): Mark locals as initialized
14732 (Bug#8227).
14733 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14734
524c7aa6
PE
14735 * alloc.c (mark_fringe_data): Move decl from here ...
14736 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14737 to check its interface.
14738 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14739
a5c0af81 14740 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14741 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14742 (fontset_font): Mark local as initialized.
a9a06e0b 14743 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14744
b4716021
PE
14745 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14746
811e9bac 14747 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14748 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14749 (x_own_selection, Fx_disown_selection_internal): Rename locals
14750 to avoid shadowing.
14751 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14752
7e3ab302
PE
14753 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14754 so that the caller can use some name other than gcpro1.
14755 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14756 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14757 (Fx_backspace_delete_keys_p):
14758 Use them to avoid shadowing, and rename vars to avoid shadowing.
14759 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14760 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14761 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14762 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14763 Remove unused locals.
7e3ab302
PE
14764 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14765 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14766 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14767 macros.
f78faa98 14768
e2b13473
PE
14769 * xterm.h (x_mouse_leave): New decl.
14770
77f23912
PE
14771 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14772 Remove unused functions.
cdf4ba58
PE
14773 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14774 (x_calc_absolute_position): Now static.
7411c686 14775 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14776 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14777 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14778 unless they are used.
38d0b34a
PE
14779 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14780 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14781 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14782 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14783 (x_error_catcher, x_connection_closed, x_error_handler):
14784 (x_error_quitter, xembed_send_message, x_iconify_frame):
14785 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14786 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14787 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14788
44f230aa
SM
14789 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14790 Rename or move locals to avoid shadowing.
6b463e58 14791 (tty_defined_color, merge_face_heights): Now static.
5967d051 14792 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14793 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14794 does not deduce is never used uninitialized.
73719eba
PE
14795 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14796 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14797
426994c3 14798 * terminal.c (store_terminal_param): Now static.
5489860b 14799
032f1620 14800 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14801 (set_frame_menubar): Remove unused local.
d4323972 14802 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14803 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14804 since they might point to immutable storage.
281585b0
PE
14805 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14806 since it's unused otherwise.
032f1620 14807
367c19e5 14808 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14809 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14810 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14811 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14812 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14813 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14814 does not deduce are never used uninitialized.
70739cbe 14815
07b48fa9
PE
14816 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14817
8868a238 14818 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14819 * window.c (window_loop, size_window):
14820 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14821
7e5cf297 14822 * window.c (display_buffer): Now static.
d6550a9f
PE
14823 (size_window): Mark variables that gcc -Wuninitialized
14824 does not deduce are never used uninitialized.
a586633d
PE
14825 * window.h (check_all_windows): New decl, to forestall
14826 gcc -Wmissing-prototypes diagnostic.
5b555da1 14827 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14828
f6095868
PE
14829 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14830 shadowing.
14831 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14832 Include <limits.h>.
14833 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14834 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14835 (load_charset_map): Mark variables that gcc -Wuninitialized
14836 does not deduce are never used uninitialized.
53df7c11 14837 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14838
f38b440c
PE
14839 * coding.c (coding_set_source, coding_set_destination):
14840 Use "else { /* comment */ }" rather than "else /* comment */;"
14841 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14842 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14843 a block, when the outer 'i' will do.
14844 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14845 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14846 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14847 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14848 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14849 Rename locals to avoid shadowing.
14850 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14851 * coding.c (emacs_mule_char, encode_invocation_designation):
14852 Now static, since they're not used elsewhere.
413bb2db 14853 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14854 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14855 (decode_coding_emacs_mule): Mark variables that gcc
14856 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14857 (detect_coding_iso_2022): Initialize a local variable that might
14858 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14859 this initialization is needed. (Bug#8211)
5f58e762
PE
14860 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14861 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14862 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14863 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14864 Remove unused macros.
f38b440c 14865
232b38b9 14866 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14867 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14868 * character.c (string_count_byte8): Likewise.
232b38b9 14869
fb90da1b
PE
14870 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14871 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14872
fb93dbc2
PE
14873 * chartab.c (copy_sub_char_table): Now static, since it's not used
14874 elsewhere.
5c156ace
PE
14875 (sub_char_table_ref_and_range, char_table_ref_and_range):
14876 Rename locals to avoid shadowing.
bbcd0949 14877 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14878
7d3b3862 14879 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14880 (BIDI_BOB): Remove unused macro.
7d3b3862 14881
6be7d3da
PE
14882 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14883 deduce are never used uninitialized.
c2ed9c8b 14884 * term.c (encode_terminal_code): Likewise.
6be7d3da 14885
75f8807f 14886 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14887
50938595
PE
14888 * tparam.h: New file.
14889 * term.c, tparam.h: Include it.
14890 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14891 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14892 Move these decls to tparam.h, and make them agree with what
14893 is actually in tparam.c. The previous trick of using incompatible
14894 decls in different modules does not conform to the C standard.
14895 All callers of tparam changed to use tparam's actual API.
14896 * tparam.c (tparam1, tparam, tgoto):
14897 Use const pointers where appropriate.
14898
fbceeba2
PE
14899 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14900 * cm.h (struct cm): Likewise.
14901 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14902 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14903 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14904 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14905 (turn_on_face, init_tty): Likewise.
14906 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14907
7f3f1250
PE
14908 * term.c (term_mouse_position): Rename local to avoid shadowing.
14909
e6ca6543
PE
14910 * alloc.c (mark_ttys): Move decl from here ...
14911 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14912
c40f8d15
AS
149132011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14914
14915 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14916
cfe0661d
JB
149172011-03-09 Juanma Barranquero <lekktu@gmail.com>
14918
14919 * search.c (compile_pattern_1): Remove argument regp, unused since
14920 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14921 (compile_pattern): Don't pass it.
14922
0afb4571
J
149232011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14924
14925 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14926 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14927 for ! HAVE_GTK3.
14928 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14929
14930 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14931
14932 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14933 gdk_window_get_screen, gdk_window_get_geometry,
14934 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14935 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14936 (xg_get_pixbuf_from_pixmap): New function.
14937 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14938 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14939 Call xg_get_pixbuf_from_pixmap instead of
14940 gdk_pixbuf_get_from_drawable.
14941 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14942 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14943 (xg_check_special_colors): Use GtkStyleContext and its functions
14944 for HAVE_GTK3.
14945 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14946 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14947 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14948 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14949 Call gtk_widget_get_preferred_size.
0afb4571
J
14950 (xg_frame_resized): gdk_window_get_geometry only takes 5
14951 parameters.
44f230aa
SM
14952 (xg_win_to_widget, xg_event_is_for_menubar):
14953 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14954 (xg_set_widget_bg): New function.
14955 (delete_cb): New function.
895009e1 14956 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14957 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14958 (xg_set_background_color): Call xg_set_widget_bg.
14959 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14960 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14961 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14962 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14963 if ! HAVE_GTK3.
14964 (update_frame_tool_bar): Call gtk_widget_hide.
14965 (xg_initialize): Use GDK_KEY_g.
14966
14967 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14968 if ! HAVE_GTK3
14969 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14970
14971 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14972 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14973 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14974
1c2cc4ef
JB
149752011-03-08 Juanma Barranquero <lekktu@gmail.com>
14976
14977 * w32xfns.c (select_palette): Check success of RealizePalette against
14978 GDI_ERROR, not zero.
14979
33383987 14980See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14981
14982;; Local Variables:
14983;; coding: utf-8
aac0c6e3
MR
14984;; End:
14985
2f097256 14986 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14987
14988 This file is part of GNU Emacs.
14989
14990 GNU Emacs is free software: you can redistribute it and/or modify
14991 it under the terms of the GNU General Public License as published by
14992 the Free Software Foundation, either version 3 of the License, or
14993 (at your option) any later version.
14994
14995 GNU Emacs is distributed in the hope that it will be useful,
14996 but WITHOUT ANY WARRANTY; without even the implied warranty of
14997 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14998 GNU General Public License for more details.
14999
15000 You should have received a copy of the GNU General Public License
15001 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.